Reviewed by NOBODY (OOPS!).
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2
3         Reviewed by NOBODY (OOPS!).
4
5         - Small cleanup in the ServerConnection class.
6
7         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
8         and added an include.
9         (ServerConnection::currentFrame):
10         (ServerConnection::getCallerFrame):
11         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
12         made a pointer into a COMPtr, and cleaned up the includes.
13
14 2007-10-29  Timothy Hatcher  <timothy@apple.com>
15
16         Reviewed by John Sullivan.
17         
18         - Place the Localizable.strings file in mac or win directories
19           if that location exists.
20         - Also look for UI_STRING in .c files.
21
22         * Scripts/extract-localizable-strings:
23
24 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
25
26         Reviewed by Adam.
27
28         - Set the eol-style to native and made all the line endings the same
29         so that I avoid messy diffs that show eol changes.
30
31         * Drosera/win/ServerConnection.cpp:
32         (ServerConnection::didParseSource):
33         (ServerConnection::didEnterCallFrame):
34         (ServerConnection::willExecuteStatement):
35         (ServerConnection::willLeaveCallFrame):
36         (ServerConnection::exceptionWasRaised):
37
38 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
39
40         Reviewed by Adam.
41
42         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
43         functionality that could not have existed previously without the new
44         interfaces.
45         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
46         from a BSTR to a JSValueRef.
47         (DebuggerDocument::platformEvaluateScript): Implemented.
48         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
49         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
50         Implemented.
51         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
52         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
53         * Drosera/win/ServerConnection.cpp: Added a helper function.
54         (ServerConnection::getCallerFrame):
55         * Drosera/win/ServerConnection.h: Added a helper function.
56
57 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
58
59         updated reviewers for my previous changelog.
60
61 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
62         Reviewed by Maciej and Adam and Geoff.
63
64         - Minor mac-side improvements including moving a function to a more
65         appropriate location, fixing a warning, and correctly checking
66         exceptions.
67
68         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
69         (DebuggerDocument::willExecuteStatement):
70         (DebuggerDocument::didEnterCallFrame):
71         (DebuggerDocument::willLeaveCallFrame):
72         (DebuggerDocument::windowScriptObjectAvailable):
73         (DebuggerDocument::callFunctionOnObject):
74         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
75         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
76         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
77         because it doesn't require the ServerConnection at all.
78         (NSStringCreateWithJSStringRef): Made an argument const.
79         (JSValueRefCreateWithNSString): Made an argument const.
80         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
81         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
82         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
83         * Drosera/mac/ServerConnection.mm: Ditto.
84         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
85
86 2007-10-29  Sam Weinig  <sam@webkit.org>
87
88         Reviewed by Adam Roben.
89
90         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
91
92         * DumpRenderTree/LayoutTestController.cpp:
93         (LayoutTestController::LayoutTestController):
94         (getGlobalFlagCallback):
95         (setGlobalFlagCallback):
96         (LayoutTestController::getJSClass):
97         (LayoutTestController::staticValues):
98         * DumpRenderTree/LayoutTestController.h:
99         (LayoutTestController::globalFlag):
100         (LayoutTestController::setGlobalFlag):
101
102 2007-10-29  Darin Adler  <darin@apple.com>
103
104         Reviewed by Maciej.
105
106         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
107         resolution instead of its default.
108
109 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
110
111         Fixed showStatus() to print status for successfully resolved conflicts when using git.
112
113         Reviewed by Mark Rowe.
114
115         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
116         was successfully resolved, but this would not show any status because the change had
117         already been cached in the index using "git add".  The solution is to add an optional
118         second argument to showStatus() which adds the "--cached" switch to the command.
119
120         * Scripts/resolve-ChangeLogs:
121         (showStatus):
122
123 2007-10-28  Eric Seidel  <eric@webkit.org>
124
125         Reviewed by Maciej and Geoff, in unison.
126
127         * Scripts/run-webkit-tests: remove broken --svg option
128
129 2007-10-28  Darin Adler  <darin@apple.com>
130
131         Reviewed by Adam.
132
133         * Scripts/run-sunspider: Default to "Release" configuration rather than
134         defaulting to the last configuration used as other scripts do. This can
135         still be overriden on the command line with "--debug" if there's some
136         reason to do so. Also fix a typo.
137
138         * Scripts/sunspider-compare-results: Fix a typo.
139
140 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
141
142         Reviewed by Adam.
143
144         - Implemented the WebScriptDebugListener functions now that the
145         WebScriptDebugServer exists
146
147         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
148         functions.
149         (ServerConnection::currentFrame):
150         (ServerConnection::didLoadMainResourceForDataSource):
151         (ServerConnection::didParseSource):
152         (ServerConnection::failedToParseSource):
153         (ServerConnection::didEnterCallFrame):
154         (ServerConnection::willExecuteStatement):
155         (ServerConnection::willLeaveCallFrame):
156         (ServerConnection::exceptionWasRaised):
157         * Drosera/win/ServerConnection.h: Removed unused arguments from the
158         members arguments list.
159
160 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
161
162         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
163         <http://bugs.webkit.org/show_bug.cgi?id=15600>
164
165         Reviewed by Darin.
166
167         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
168         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
169         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
170         file.  Note that it may also be used as a stand-alone script.
171
172         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
173         * Scripts/resolve-ChangeLogs: Added.
174         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
175
176 2007-10-26  Mark Rowe  <mrowe@apple.com>
177
178         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
179         to the Qt port on the assumption that it was an implementation of the cross-platform
180         LayoutTestController class.  It is not, so it did not need to be changed.
181
182         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
183
184 2007-10-25  Mark Rowe  <mrowe@apple.com>
185
186         Reviewed by Maciej.
187
188         Fix builds with code coverage enabled.
189
190         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
191
192 2007-10-25  Darin Adler  <darin@apple.com>
193
194         Reviewed by Mark Rowe.
195
196         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
197         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
198
199 2007-10-25  Stephanie  <slewis@apple.com>
200
201         build Fix
202
203         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
204
205 2007-10-25  Stephanie  <slewis@apple.com>
206
207         Reviewed by Mark Rowe, Adam Roben.
208
209         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
210
211         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
212
213 2007-10-25  Alice Liu  <alice.liu@apple.com>
214
215         Reviewed by Adam.
216
217         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
218
219         Moving destructor into platform-specific files
220         * DumpRenderTree/LayoutTestController.cpp:
221         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
222         (LayoutTestController::~LayoutTestController):
223         * DumpRenderTree/qt/jsobjects.cpp:
224         (LayoutTestController::~LayoutTestController):
225
226         LayoutTestController wasn't being destroyed
227         * DumpRenderTree/win/DumpRenderTree.cpp:
228         (runTest):
229
230         Added declspec
231         * DumpRenderTree/win/EditingDelegate.h:
232
233         Reset certain values on the webview (or related delegate) that might 
234         have changed while running a test
235         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
236         (LayoutTestController::~LayoutTestController):
237
238 2007-10-25  Adam Roben  <aroben@apple.com>
239
240         Make sunspider-compare-results work with relative paths
241
242         Reviewed by Sam.
243
244         * Scripts/sunspider-compare-results: Convert arguments to absolute
245         paths before we chdir.
246
247 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
248
249         Reviewed by Sam.
250
251         - Implemented server calls now the WebScriptDebugServer exists.
252         - Also removed no longer needed call to initialize CG.
253
254         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
255         automatically now.
256         (_tWinMain):
257         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
258         (ServerConnection::ServerConnection):
259         (ServerConnection::~ServerConnection):
260         (ServerConnection::pause):
261         (ServerConnection::resume):
262         (ServerConnection::stepInto):
263         (ServerConnection::applicationTerminating):
264         (ServerConnection::serverConnectionDidDie):
265         * Drosera/win/ServerConnection.h: Now uses the COM class.
266
267 2007-10-24  George Staikos  <staikos@kde.org>
268
269         Unbreak Qt build.
270
271         * Scripts/build-webkit:
272
273 2007-10-24  Adam Roben  <aroben@apple.com>
274
275         Remove now-unnecessary call to InitializeCoreGraphics
276
277         WebKit takes care of this now.
278
279         Reviewed by Ada.
280
281         * DumpRenderTree/win/DumpRenderTree.cpp:
282         (initialize):
283
284 2007-10-24  Adam Roben  <aroben@apple.com>
285
286         Use WebTextRenderer in DRT
287
288         Reviewed by Ada.
289
290         * DumpRenderTree/win/DumpRenderTree.cpp:
291         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
292
293 2007-10-24  Sven Herzberg  <sven@imendio.com>
294
295         Reviewed by Mark Rowe.
296
297         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
298         Bug 15614: [GTK] qmake based backends don't build on OS X
299
300         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
301         GTK backend on a Mac
302         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
303         isDarwin() to make it reusable in other places (like the workaround-
304         for-prebuilt-qmake in build-webkit)
305
306 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
307
308         Refurbish update-webkit script.
309
310         Reviewed by Adam.
311
312         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
313         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
314         multi-argument version of system() for flexibility and security.  Check for existence
315         of Internal directory using -d test instead of -x.
316
317 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
318
319         Minor clean-up of prepare-ChangeLog script.
320
321         Reviewed by Adam.
322
323         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
324         of a string.  Use multi-argument versions of open() and system() for flexibility and
325         security.
326
327 2007-10-24  Alice Liu  <alice.liu@apple.com>
328
329         Reviewed by Oliver.
330
331         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
332
333         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
334         replay the saved events when we're still processing the mousedown that starts the drag
335         * DumpRenderTree/win/EventSender.cpp:
336         (doMouseMove):
337         * DumpRenderTree/win/UIDelegate.cpp:
338         (UIDelegate::doDragDrop):
339
340 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
341
342         Reviewed by Sam, Steve and Darin.
343
344         - Stubbed out the WebScriptDebugListener functionality in the Server
345         Connection class to prepare it for receiving those callbacks.
346         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
347         and the ServerConnection to not need to be initialized with a server
348         name, since that is not the way we connect to the WebKit server. 
349
350         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
351         no exception.  Now it only loggs when there is an exception
352         (DebuggerDocument::willExecuteStatement):
353         (DebuggerDocument::didEnterCallFrame):
354         (DebuggerDocument::willLeaveCallFrame):
355         (DebuggerDocument::windowScriptObjectAvailable):
356         (DebuggerDocument::callFunctionOnObject):
357         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
358         to be instantiated with a server's name.
359         (DebuggerClient::DebuggerClient):
360         (DebuggerClient::didFinishLoadForFrame):
361         * Drosera/win/DebuggerClient.h: Removed unsued variable.
362         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
363         a server name.
364         (Drosera::init):
365         (Drosera::initServer):
366         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
367         instantiated with a server's name.
368         * Drosera/win/ServerConnection.cpp: 
369         (ServerConnection::ServerConnection): No longer needs a server name
370         (ServerConnection::~ServerConnection): Only release the global context
371         if there is one.
372         (ServerConnection::serverConnectionDidDie): Stub for
373         IWebScriptDebugListener
374         (ServerConnection::QueryInterface): ditto
375         (ServerConnection::AddRef): ditto
376         (ServerConnection::Release): ditto
377         (ServerConnection::didLoadMainResourceForDataSource): ditto
378         (ServerConnection::didParseSource): ditto
379         (ServerConnection::failedToParseSource): ditto
380         (ServerConnection::didEnterCallFrame): ditto
381         (ServerConnection::willExecuteStatement): ditto
382         (ServerConnection::willLeaveCallFrame): ditto
383         (ServerConnection::exceptionWasRaised): ditto
384         * Drosera/win/ServerConnection.h: Stubbed out the
385         IWebScriptDebugListener functions, and this class no longer needs to be
386         instantiated with a server name.
387
388 2007-10-24  Lars Knoll  <lars@trolltech.com>
389
390         Reviewed by Simon.
391
392         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
393
394         * DumpRenderTree/qt/jsobjects.h:
395
396 2007-10-24  Lars Knoll  <lars@trolltech.com>
397
398         Reviewed by Simon.
399
400         add another command.
401
402         * DumpRenderTree/qt/jsobjects.cpp:
403         (TextInputController::doCommand):
404
405 2007-10-24  Lars Knoll  <lars@trolltech.com>
406
407         Reviewed by Simon.
408
409         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
410
411         * DumpRenderTree/qt/jsobjects.cpp:
412         (EventSender::keyDown):
413         * DumpRenderTree/qt/jsobjects.h:
414
415 2007-10-24  Lars Knoll  <lars@trolltech.com>
416
417         Reviewed by Simon.
418
419         implement eventSender.keyDown().
420
421         * DumpRenderTree/qt/jsobjects.cpp:
422         (EventSender::keyDown):
423
424 2007-10-24  Lars Knoll  <lars@trolltech.com>
425
426         Reviewed by Simon.
427
428         some smaller fixes to the editing support in DRT. Makes another few tests pass.
429
430         * DumpRenderTree/qt/DumpRenderTree.cpp:
431         (WebCore::DumpRenderTree::DumpRenderTree):
432         (WebCore::DumpRenderTree::initJSObjects):
433         * DumpRenderTree/qt/jsobjects.cpp:
434         (TextInputController::doCommand):
435
436 2007-10-24  Lars Knoll  <lars@trolltech.com>
437
438         Reviewed by Simon.
439
440         first bit of implementation for the textinputcontroller.
441
442         * DumpRenderTree/qt/DumpRenderTree.cpp:
443         (WebCore::DumpRenderTree::DumpRenderTree):
444         * DumpRenderTree/qt/DumpRenderTree.h:
445         * DumpRenderTree/qt/jsobjects.cpp:
446         (TextInputController::TextInputController):
447         (TextInputController::doCommand):
448         * DumpRenderTree/qt/jsobjects.h:
449
450 2007-10-24  Lars Knoll  <lars@trolltech.com>
451
452         Reviewed by Simon.
453
454         make the man webpage believe it has focus, so the editing tests work correctly.
455
456         * DumpRenderTree/qt/DumpRenderTree.cpp:
457         (WebCore::DumpRenderTree::DumpRenderTree):
458
459 2007-10-24  Lars Knoll  <lars@trolltech.com>
460
461         Reviewed by Simon.
462
463         implement layoutTestController.dumpEditingCallbacks() correctly.
464
465         * DumpRenderTree/qt/DumpRenderTree.cpp:
466         (WebCore::DumpRenderTree::DumpRenderTree):
467         * DumpRenderTree/qt/jsobjects.cpp:
468         (LayoutTestController::reset):
469         (LayoutTestController::dumpEditingCallbacks):
470
471 2007-10-24  Lars Knoll  <lars@trolltech.com>
472
473         Reviewed by Simon.
474
475         Implement support for testing editing.
476
477         * DumpRenderTree/qt/DumpRenderTree.cpp:
478         (WebCore::DumpRenderTree::DumpRenderTree):
479
480 2007-10-23  Sam Weinig  <sam@webkit.org>
481
482         Check for null BSTR that can be passed to the UIDelegate methods
483         from javascript null and undefined.  Fixes a failing test case on
484         Windows (fast/dom/Window/alert-undefined.html)
485
486         Reviewed by Eric Seidel.
487
488         * DumpRenderTree/win/UIDelegate.cpp:
489         (UIDelegate::runJavaScriptAlertPanelWithMessage):
490         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
491         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
492         (UIDelegate::webViewAddMessageToConsole):
493
494 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
495
496         Reviewed by Darin.
497         
498         Don't print a massive pile of setenvs from tools that automatically build testkjs.
499
500         * Scripts/build-testkjs:
501
502 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
503
504         Reviewed by Darin.
505
506         - add wrapper that finds the right copy of testkjs
507         
508         * Scripts/sunspider-compare-results: Added.
509
510 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
511
512         Reviewed by Sam.
513
514         - After talking with Steve I now see that the WebKit server must be
515         running for DCOM to create the distributed objects, which makes sense
516         and currently WebKit only allows one instance to be running at a time
517         which avoids accidentally connecting to the wrong server
518         - In light of this I have removed the code for the attach box and
519         NotificationServer and known server names, since they are all extranious
520         now.
521
522         * Drosera/win/Drosera.cpp: Removed notification classes and known server
523         names.
524         (_tWinMain): Uses init instead of initUI.
525         (droseraWndProc): No longer creats an attach dialog box.
526         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
527         it's not manditory to call init before doing COM stuff.
528         (Drosera::init): calls initUI and will call attach when the
529         functionality exists. 
530         (Drosera::initUI): Has changed very little.
531         (Drosera::attach): Changed the signature to reflect that we no longer
532         need the dictionary of known server names.
533         * Drosera/win/Drosera.h: Removed notification classes and known server
534         names.  Also renamed and moved some functions.
535         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
536         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
537         headers to the resources folder. 
538         * Drosera/win/resource.h: Removed the Attach box.
539
540 2007-10-22  Adam Roben  <aroben@apple.com>
541
542         Windows build fix
543
544         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
545
546 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
547
548         - Removed a leak that was fixed.
549
550         * Scripts/run-webkit-tests:
551
552 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
553
554         Reviewed by Darin.
555
556         - Changed the Client so that the DebuggerDocument now own the
557         ServerConnection.  This simplifies ownership and cleanup. 
558
559         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
560         ServerConnection.
561         (DebuggerClient::initWithServerName):
562         (DebuggerClient::didFinishLoadForFrame):
563         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
564         ServerConnection.
565         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
566         until after we have a server which we are attached to.
567         (Drosera::initUI):
568         (Drosera::attach):
569         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
570         out previously.
571
572 2007-10-22  Simon Hausmann  <hausmann@kde.org>
573
574         Reviewed by Nikolas.
575
576         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
577
578         * Scripts/run-javascriptcore-tests:
579
580 2007-10-22  Simon Hausmann  <hausmann@kde.org>
581
582         Reviewed by Nikolas.
583
584         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
585
586         * Scripts/build-drosera:
587         * Scripts/build-dumprendertree:
588         * Scripts/build-testkjs:
589         * Scripts/build-webkit:
590         * Scripts/run-javascriptcore-tests:
591         * Scripts/run-sunspider:
592         * Scripts/run-webkit-tests:
593         * Scripts/webkitdirs.pm:
594
595 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
596
597         Reviewed by Mark Rowe.
598         
599         Fix for local database support after r26879
600         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
601
602         * Scripts/build-webkit:
603
604 2007-10-22  Holger Freyther  <zecke@selfish.org>
605
606         Reviewed by Simon Hausmann <hausmann@kde.org>.
607
608         - Do not build testkjs as an application bundle. This is
609         needed for run-javascriptcore-tests on OSX.
610         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
611         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
612         as we do not have -rpath on OSX.
613
614         * DumpRenderTree/qt/DumpRenderTree.pro:
615         * Scripts/run-webkit-tests:
616
617 2007-10-22  Simon Hausmann  <hausmann@kde.org>
618
619         Reviewed by aroben.
620
621         Fix support for Signed-off-by detection in prepare-ChangeLog
622         --git-commit. The Signed-off-by tag does not appear in the header
623         but usually at the end.
624
625         * Scripts/prepare-ChangeLog:
626
627 2007-10-21  Mark Rowe  <mrowe@apple.com>
628
629         Reviewed by Eric.
630
631         Fix run-javascriptcore-tests for Gtk.
632
633         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
634
635 2007-10-20  Eric Seidel  <eric@webkit.org>
636
637         Reviewed by aroben.
638
639         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
640
641 2007-10-20  Eric Seidel  <eric@webkit.org>
642
643         Reviewed by darin.
644         
645         Add improved argument handling to run-sunspider, including
646         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
647         Also re-factor code into subroutines
648
649         * Scripts/build-dumprendertree: removed bogus comments
650         * Scripts/build-testkjs: Added.
651         * Scripts/run-javascriptcore-tests: use build-testkjs
652         * Scripts/run-sunspider: improved argument handling, abstraction
653         * Scripts/run-webkit-tests: improved abstraction
654
655 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
656
657         Not reviewed, Windows build fix.
658
659         * DumpRenderTree/win/EventSender.cpp:
660         (keyDownCallback):
661
662 2007-10-20  Darin Adler  <darin@apple.com>
663
664         Reviewed by Tim Hatcher.
665
666         - http://bugs.webkit.org/show_bug.cgi?id=15544
667           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
668           not rely on Apple-specific key codes
669
670         * DumpRenderTree/mac/EventSendingController.mm:
671         (-[EventSendingController keyDown:withModifiers:]):
672         Added named key "rightArrow". Later we could have a whole table of these.
673         Also tweaked modifiers code a little.
674
675         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
676
677 2007-10-19  Darin Adler  <darin@apple.com>
678
679         Reviewed by Eric.
680
681         - http://bugs.webkit.org/show_bug.cgi?id=15566
682           possible fix for leak seen in DumpRenderTree
683
684         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
685         Delete the item if it's not put on the queue, since the caller has
686         no way of knowing that. Would be better to have the parameter type
687         be auto_ptr to express the fact that we take ownership.
688
689         - unrelated change
690
691         * Drosera/mac/main.m: Add missing include.
692
693 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
694
695         Reviewed by Adam.
696
697         - This change should be identical but for some reason was not working
698         on my machine.
699
700         * Scripts/prepare-ChangeLog:
701
702 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
703
704         Reviewed by Oliver and Tim.
705
706         - Made use of RetainPtr to avoid retain and release issues and moved the
707         log function to DebuggerDocumentPlatform, which seems to be a more
708         logical place for it to live.
709         - Also moved knownServers from the ServerConnection to
710         DebuggerApplication to match the Windows code and because it makes sense
711         that a connection knows its own server but not all of them.
712
713         * Drosera/mac/DebuggerClient.h: Moved the log function to
714           DebuggerDocumentPlatform.
715         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
716           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
717           call for the server name up from the ServerConnection class.
718         (-[DebuggerClient dealloc]):
719         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
720           for the server name up from the ServerConnection.
721         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
722         (DebuggerDocument::platformPause):
723         (DebuggerDocument::platformResume):
724         (DebuggerDocument::platformStepInto):
725         (DebuggerDocument::platformEvaluateScript):
726         (DebuggerDocument::getPlatformCurrentFunctionStack):
727         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
728         (DebuggerDocument::platformValueForScopeVariableNamed):
729         (DebuggerDocument::platformLog): Log directly from here. No need to call
730           DebuggerClient.
731         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
732           way I see it, a ServerConnection should only know about its connection
733           and the group of all possible servers should be kept by the
734           application.
735         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
736           currentServerName, it makes sense that the connection should know that
737           name.
738         (-[ServerConnection currentServerName]):
739
740 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
741
742         Reviewed by Adam.
743
744         - Integrated changes from mac drosera.  Recently I've encapsulated
745         out the server connection object from the rest of Drosera because
746         it is very platform dependent right now and RPC is not implemented on
747         windows.  This functionality, of communicating with the WebKit server
748         is the next area I will be focusing on in Windows.
749
750         - Other changes and cleanup were made to organize the code and add notes
751         on which parts still need work.  Also some mac code is added and
752         commented out, to act as pseudocode for the logic of those parts.
753
754         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
755           pointer.
756         * Drosera/config.h: Added whitespace.
757         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
758           these files got moved into Drosera.h/cpp
759         * Drosera/win/DebuggerApplication.h: Removed.
760         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
761           happened here to better match the logic flow of the same code on the 
762           mac side and to use the new ServerConnection class.
763         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
764         (DebuggerClient::initWithServerName): Initializer that will set up the
765           class to use a ServerConnection object.  This was necessary so I could
766           create a DebuggerClient without having to initilaize it at
767           construction.
768         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
769           will be the UIDelegate and FrameLoadDelegate.
770         (DebuggerClient::AddRef): For IUnknown.
771         (DebuggerClient::Release): For IUnknown.
772         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
773           this still needs to set the global context of the server, but
774           IWebFrame does not have an accessor for the global context yet. 
775         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
776           this is a pass through for the same function in the document.
777         (DebuggerClient::didReceiveTitle): Unimplemented part of
778           FrameLoadDelegate this would change the title of the window.
779         (DebuggerClient::createWebViewWithRequest): Part of the
780           FrameLoadDelegate.  This is about new windows via Window.open() and
781           how their delegates are set.
782         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
783           UIDelegate.  Just a debug function for printing messages.
784         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
785           because the Client should be the UIDelegate and FrameLoadDelegate
786           to match the delegates on mac.
787         (DebuggerClient::webViewLoaded): Added accessor method.
788         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
789           forgotten to add this file before.  This is where the platform
790           dependent versions of the Documents functions live. Most of these are
791           unimplemented because some piece of functionality does not exist on
792           Windows yet.
793         (DebuggerDocument::platformPause):
794         (DebuggerDocument::platformResume):
795         (DebuggerDocument::platformStepInto):
796         (DebuggerDocument::platformEvaluateScript):
797         (DebuggerDocument::getPlatformCurrentFunctionStack):
798         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
799         (DebuggerDocument::platformValueForScopeVariableNamed):
800         (DebuggerDocument::platformLog):
801         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
802           responsibilities becaue they belong in the Client. Also I laid the
803           groundwork for attaching Drosera to a WebKit process
804         (attachWndProc): Now if a server is selected the Client becomes it's
805           delegate.
806         (Drosera::Drosera): Added the construction of the Client and dictionary
807           of server names. 
808         (Drosera::initUI): This is no longer the delegates, the Client is.
809         (Drosera::webViewLoaded): Now asks the Client instead of holding local
810           state. 
811         (Drosera::applicationDidFinishLaunching): Placeholder for needed
812           notification registration when it's possible to implement.
813         (Drosera::serverLoaded): Ditto
814         (Drosera::serverUnloaded): Ditto
815         (Drosera::attach): Attach Drosera to the WebKit server.
816         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
817         (Drosera::getInst): 
818         (Drosera::setInst):
819         (Drosera::knownServers):
820         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
821           and added the ServerConnection.
822         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
823         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
824           Most of the functions are completely unimlemented because they cannot
825           connect with the WebKit server, because one does not exist on Windows
826           yet.
827         (ServerConnection::initWithServerName): 
828         (ServerConnection::~ServerConnection):
829         (ServerConnection::setGlobalContext):
830         (ServerConnection::pause):
831         (ServerConnection::resume):
832         (ServerConnection::stepInto):
833         (ServerConnection::switchToServerNamed):
834         (ServerConnection::applicationTerminating):
835         (ServerConnection::serverConnectionDidDie):
836         (ServerConnection::currentFrame):
837         * Drosera/win/ServerConnection.h: Added. Ditto.
838         (ServerConnection::ServerConnection):
839
840 2007-10-19  Alice Liu  <alice.liu@apple.com>
841
842         Reviewed by Darin.
843
844         Fix for these broken layout tests on Windows:
845         
846         fast/forms/focus-selection-input.html
847         fast/forms/focus-selection-textarea.html
848         fast/forms/select-accesskey.html
849         
850         * DumpRenderTree/win/EventSender.cpp:
851         (keyDownCallback):
852         correct the VK code for alt key.
853         
854 2007-10-19  Eric Seidel  <eric@webkit.org>
855
856         Reviewed by Mark Rowe.
857         
858         Make the GtkLauncher code slightly more readable.
859
860         * GtkLauncher/main.cpp:
861         (setupMainMenu): Added.
862         (setupMainWindowUI): Added.
863         (main):
864
865 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
866
867         Rubber stamped by Adam.
868         
869         - don't delay-load WebKit in DumpRenderTree.
870
871         * DumpRenderTree/win/DumpRenderTree.vcproj:
872
873 2007-10-18  Dan Bernstein  <dan.bernstein@apple.com>
874
875         Reviewed by Adam Roben.
876
877         - fix <rdar://problem/5313523>
878         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
879
880         * DumpRenderTree/mac/DumpRenderTree.mm:
881         (dump): Changed to use _responseMIMEType.
882
883 2007-10-17  Adam Roben  <aroben@apple.com>
884
885         Make it possible to have Windows-specific tests and results
886
887         When searching for tests to run and the Skipped file, we will only
888         look in platform/win and the cross-platform directory. When looking
889         for expected results, we will look in platform/win, then
890         platform/mac-leopard, then platform/mac, then finally the
891         cross-platform directory.
892
893         Reviewed by Sam.
894
895         * Scripts/run-webkit-tests:
896         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
897         searching in the cross-platform directory.
898         (sub buildPlatformHierarchy): Removed some unneeded calls to
899         dirname/basename.
900
901 2007-10-17  Adam Roben  <aroben@apple.com>
902
903         Add back the call to register WebKit that we had before WebKitInitializer existed
904
905         This is needed to ensure that the right WebKit is used when
906         instantiating COM objects.
907
908         Reviewed by Oliver.
909
910         * DumpRenderTree/win/debug_internal.vsprops: Define
911         DEBUG_WEBKIT_HAS_SUFFIX.
912         * DumpRenderTree/win/DumpRenderTree.cpp:
913         (initialize):
914
915 2007-10-17  Adam Roben  <aroben@apple.com>
916
917         Import File::Basename in webkitdirs since we use it
918
919         * Scripts/webkitdirs.pm:
920
921 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
922
923         - Updated the tiger leaks list to make the internal bots green.
924
925         * Scripts/run-webkit-tests:
926
927 2007-10-17  Adam Roben  <aroben@apple.com>
928
929         Build fix for VC++ Express
930
931         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
932         and ole32.lib.
933
934 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
935
936         Reviewed by Sam.
937
938         - Minor mac improvements based on observations I made while implementing the
939         Windows code.
940
941         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
942         then hand it to the Client who will retain it, it should just be the client who
943         creates and owns the server.
944         (-[DebuggerApplication attach:]):
945         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
946         * Drosera/mac/DebuggerClient.mm: Creates the server.
947         (-[DebuggerClient initWithServerName:]):
948         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
949         can instead forward declare what it needs.
950
951 2007-10-16  Darin Adler  <darin@apple.com>
952
953         Reviewed by Geoff Garen.
954
955         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
956         want to turn failing tests into platform-specific test results. Also did a
957         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
958         would take the type of results into account only some of the time.
959
960 2007-10-16  Adam Roben  <aroben@apple.com>
961
962         Add a new nightly launcher script for Windows
963
964         This new script is for versions of Safari that don't delay-load
965         WebKit. I had to make FindSafari be able to print out the nightly
966         launcher script on stdout because Windows shell scripts can't capture
967         the output from a command into an environment variable.
968
969         Reviewed by Steve.
970
971         * FindSafari/FindSafari.cpp:
972         (_tmain): Added /printSafariLauncher option.
973         * Scripts/run-webkit-nightly.cmd: Added.
974
975 2007-10-16  Adam Roben  <aroben@apple.com>
976
977         Replace WebKitInitializer with FindSafari
978
979         We now rely on setting the PATH environment variable to tell Windows
980         where to find WebKit and its dependencies (similar to
981         DYLD_FRAMEWORK_PATH on Mac).
982
983         This change also make DumpRenderTree no longer delay-load WebKit.
984
985         Reviewed by Sam.
986
987         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
988         FindSafari.
989         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
990         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
991         WebKitInitializer, don't delay-load WebKit.
992         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
993         * Scripts/run-webkit-tests: Ditto.
994         * Scripts/webkitdirs.pm:
995         (sub setPathForRunningWebKitApp): Added.
996         * WebKitInitializer/WebKitInitializer.cpp: Removed.
997         * WebKitInitializer/WebKitInitializer.h: Removed.
998         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
999         * WebKitInitializer/debug.vsprops: Removed.
1000         * WebKitInitializer/debug_internal.vsprops: Removed.
1001         * WebKitInitializer/release.vsprops: Removed.
1002
1003 2007-10-16  Adam Roben  <aroben@apple.com>
1004
1005         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
1006
1007         http://bugs.webkit.org/show_bug.cgi?id=15532
1008
1009         FindSafari simply prints the location of an installed Safari.exe on
1010         stdout.
1011
1012         Reviewed by Darin.
1013
1014         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
1015         (getStringValue):
1016         (getWebViewCLSID):
1017         (getInstalledWebKitDirectory):
1018         (_tmain):
1019         * FindSafari/FindSafari.vcproj: Added.
1020         * Scripts/webkitdirs.pm:
1021         (sub installedSafariPath): Added. Calls FindSafari on Windows.
1022
1023 2007-10-16  Adam Roben  <aroben@apple.com>
1024
1025         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
1026
1027         Reviewed by Kevin McCullough.
1028
1029         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
1030         when referring to WebKit.dll.
1031         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
1032         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
1033         * DumpRenderTree/win/release.vsprops: Ditto.
1034         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
1035         never have a _debug suffix on WebKit.dll.
1036         * WebKitInitializer/WebKitInitializer.cpp:
1037         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
1038         specified.
1039         * WebKitInitializer/debug_internal.vsprops: Added
1040         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
1041
1042 2007-10-16  Darin Adler  <darin@apple.com>
1043
1044         Reviewed by Adele.
1045
1046         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
1047         Remove now-unneeded control/alt key hack; the tests have been updated.
1048
1049 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1050
1051         - Updated leaks list because our internal bot upgraded it's version of leopard and 
1052         one of the leaks was fixed between that revision and the bot's previous version of
1053         leopard.
1054
1055         * Scripts/run-webkit-tests:
1056
1057 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
1058
1059         Reviewed by Tim.
1060
1061         - I encapsulated out the server connecton functionality because it is a specific part
1062         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
1063         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
1064         Windows.  So the majority of this patch is moving preexisting functionality.
1065
1066         - Also I removed the prefix header and changed to use config.h because it is more
1067         standard on how we use config.h in windows and it didn't make much sense to keep
1068         the prefix header and the config.h
1069
1070         * Drosera/DebuggerDocument.cpp:
1071         (DebuggerDocument::DebuggerDocument):
1072         * Drosera/DebuggerDocument.h:
1073         * Drosera/config.h:
1074         * Drosera/mac/DebuggerApplication.mm:
1075         (-[DebuggerApplication attach:]):
1076         * Drosera/mac/DebuggerClient.h:
1077         * Drosera/mac/DebuggerClient.mm:
1078         (-[DebuggerClient initWithServerConnection:]):
1079         (-[DebuggerClient dealloc]):
1080         (-[DebuggerClient windowDidLoad]):
1081         (-[DebuggerClient windowWillClose:]):
1082         (-[DebuggerClient webView:didFinishLoadForFrame:]):
1083         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
1084         * Drosera/mac/DebuggerDocumentPlatform.mm:
1085         (DebuggerDocument::platformPause):
1086         (DebuggerDocument::platformResume):
1087         (DebuggerDocument::platformStepInto):
1088         (DebuggerDocument::platformEvaluateScript):
1089         (DebuggerDocument::getPlatformCurrentFunctionStack):
1090         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1091         (DebuggerDocument::platformValueForScopeVariableNamed):
1092         (DebuggerDocument::platformLog):
1093         * Drosera/mac/Drosera.pch: Removed.
1094         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1095         * Drosera/mac/ServerConnection.h: Added.
1096         * Drosera/mac/ServerConnection.mm: Added.
1097         (-[ServerConnection initWithServerName:]):
1098         (-[ServerConnection dealloc]):
1099         (-[ServerConnection setGlobalContext:]):
1100         (-[ServerConnection pause]):
1101         (-[ServerConnection resume]):
1102         (-[ServerConnection stepInto]):
1103         (-[ServerConnection switchToServerNamed:]):
1104         (-[ServerConnection applicationTerminating:]):
1105         (-[ServerConnection serverConnectionDidDie:]):
1106         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1107         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
1108         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
1109         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
1110         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
1111         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
1112         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
1113         (-[ServerConnection currentFrame]):
1114         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
1115         (-[ServerConnection knownServers]):
1116
1117 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
1118
1119         Reviewed by Eric.
1120
1121         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
1122           Script to automatically search nightly builds for regressions (bisect-builds)
1123
1124         * Scripts/bisect-builds: Added.
1125
1126 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
1127
1128         Reviewed by Darin.
1129
1130         - New JavaScript benchmark
1131         http://bugs.webkit.org/show_bug.cgi?id=15515
1132
1133         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
1134         current development or release build of JavaScriptCore.
1135
1136 2007-10-15  Mark Rowe  <mrowe@apple.com>
1137
1138         Reviewed by Sam.
1139
1140         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
1141
1142         * Scripts/webkitdirs.pm:
1143         - Change checkArgv to remove the options from @ARGV to prevent
1144         them from interfering with further option processing.
1145         - Fix logic error in determineIsQt that would prevent it from bailing out early.
1146         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
1147         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
1148         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
1149
1150 2007-10-15  Darin Adler  <darin@apple.com>
1151
1152         Reviewed by Sam.
1153
1154         - added logging of window.prompt and window.confirm
1155
1156         * DumpRenderTree/mac/UIDelegate.mm:
1157         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1158         Implement the recommended delegate rather than the deprecated one.
1159         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
1160         Added.
1161         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1162         Added.
1163
1164         * DumpRenderTree/win/UIDelegate.h:
1165         * DumpRenderTree/win/UIDelegate.cpp:
1166         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
1167         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1168         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
1169         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
1170
1171 2007-10-15  Alice Liu  <alice.liu@apple.com>
1172
1173         Reviewed by Sam Weinig.
1174
1175         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
1176
1177         * DumpRenderTree/win/DumpRenderTree.cpp:
1178         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
1179         (main): allocate the global policy delegate for DRT's custom use
1180         * DumpRenderTree/win/DumpRenderTree.vcproj:
1181         Adding files to project
1182         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
1183         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1184         (LayoutTestController::setCustomPolicyDelegate):
1185         set the webview's policy delegate to DRT's custom one if the test requests it.
1186         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
1187         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
1188         (PolicyDelegate::PolicyDelegate):
1189         (PolicyDelegate::QueryInterface):
1190         (PolicyDelegate::AddRef):
1191         (PolicyDelegate::Release):
1192         (PolicyDelegate::decidePolicyForNavigationAction):
1193         * DumpRenderTree/win/PolicyDelegate.h: Added.
1194         (PolicyDelegate::decidePolicyForNewWindowAction):
1195         (PolicyDelegate::decidePolicyForMIMEType):
1196         (PolicyDelegate::unableToImplementPolicyWithError):
1197
1198 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
1199
1200         Reviewed by Mark.
1201
1202         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
1203         when querying for QMAKE_MKSPECS.
1204
1205 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
1206
1207         Reviewed by Adam Roben.
1208         
1209         Fix run-webkit-tests is too greedy calculating platform hierarchy
1210         http://bugs.webkit.org/show_bug.cgi?id=15465
1211         
1212         Fix run-webkit-tests being too greedy in trying to split the platform name up
1213         causing it to try and find tests in every directory above the first "-" in the
1214         path to the LayoutTests
1215
1216         * Scripts/run-webkit-tests:
1217
1218 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
1219
1220         Reviewed by Darin.
1221
1222         http://bugs.webkit.org/show_bug.cgi?id=15006
1223         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
1224         to reduce code duplication.
1225
1226         * Scripts/build-webkit:
1227         * Scripts/webkitdirs.pm:
1228         buildQMakeProject() renamed to buildQMakeQtProject().
1229         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
1230         unused $colorize has been removed.
1231
1232 === Start merge of feature-branch 2007-10-12 ===
1233
1234 2007-10-08  Eric Seidel  <eric@webkit.org>
1235
1236         Reviewed by Mark Rowe.
1237
1238         * Scripts/build-webkit: add --help, remove unused --color
1239
1240 2007-10-07  Eric Seidel  <eric@webkit.org>
1241
1242         Reviewed by darin.
1243
1244         * Drosera/mac/DebuggerDocumentPlatform.mm:
1245         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
1246
1247 2007-10-03  Rob Buis  <buis@kde.org>
1248
1249         Reviewed by Olliej.
1250
1251         Adapt to changed location of Ahem font.
1252
1253         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1254
1255 2007-10-02  Eric Seidel  <eric@webkit.org>
1256
1257         Reviewed by Adam Roben.
1258         
1259         Make pixel tests more useful!
1260         Finally fix the image diff 0.00% mystery problem
1261         Highlight any image differences in the image diff.
1262         Add a link from image diffs back to original test file.
1263
1264         * DumpRenderTree/mac/ImageDiff.m:
1265         (compareImages): highlight any differences
1266         (computePercentageDifferent): round to two decimal places
1267         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
1268
1269 2007-10-02  Eric Seidel  <eric@webkit.org>
1270
1271         Reviewed by Alexey Proskuryakov.
1272
1273         * Scripts/run-webkit-tests: print the % image difference on main results page
1274
1275 2007-10-02  Mark Rowe  <mrowe@apple.com>
1276
1277         Reviewed by Oliver.
1278
1279         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1280
1281         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1282         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1283
1284 2007-10-01  Mark Rowe  <mrowe@apple.com>
1285
1286         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1287
1288 2007-09-25  Eric Seidel  <eric@webkit.org>
1289
1290         Reviewed by Mark Rowe.
1291         
1292         DerivedSources.make was finding "ENABLE_SVG" in the string
1293         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
1294         quite correctly.
1295
1296         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
1297
1298 2007-09-25  Mark Rowe  <mrowe@apple.com>
1299
1300         Rubber-stamped by Eric.
1301
1302         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1303         This makes it possible to automate nightly builds for the feature-branch.
1304
1305 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
1306
1307         Rubber stamped by Mark.
1308
1309         Enable svg experimental features as default here in feature-branch.
1310
1311         * Scripts/build-webkit:
1312
1313 2007-06-29  Antti Koivisto  <antti@apple.com>
1314
1315         Reviewed by Weinig.
1316         
1317         Add VIDEO flag for timed media features
1318
1319         * Scripts/build-webkit
1320         
1321 === End merge of feature-branch 2007-10-12 ===
1322
1323 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1324
1325         Reviewed by Darin.
1326
1327         - Updated rational for the leaks list to be more clear.
1328
1329         * Scripts/run-webkit-tests:
1330
1331 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1332
1333         Rubber Stamp by Sam.
1334
1335         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
1336         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
1337
1338         * Scripts/run-webkit-tests:
1339
1340 2007-10-10  Simon Hausmann  <hausmann@kde.org>
1341
1342         Reviewed by Lars.
1343
1344         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
1345         includes are needed for INT_MAX, std::auto_ptr and the like.
1346
1347         * DumpRenderTree/qt/main.cpp:
1348
1349 2007-10-09  Lars Knoll  <lars@trolltech.com>
1350
1351         Reviewed by Simon.
1352
1353         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
1354
1355         * DumpRenderTree/qt/jsobjects.cpp:
1356         (LayoutTestController::encodeHostName):
1357         (LayoutTestController::decodeHostName):
1358         * DumpRenderTree/qt/jsobjects.h:
1359
1360 2007-10-09  Lars Knoll  <lars@trolltech.com>
1361
1362         Reviewed by Simon.
1363
1364         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
1365
1366         * DumpRenderTree/qt/DumpRenderTree.cpp:
1367         (WebCore::WebPage::createFrame):
1368         (WebCore::DumpRenderTree::DumpRenderTree):
1369         (WebCore::DumpRenderTree::titleChanged):
1370         * DumpRenderTree/qt/DumpRenderTree.h:
1371         * DumpRenderTree/qt/jsobjects.cpp:
1372         (LayoutTestController::reset):
1373         * DumpRenderTree/qt/jsobjects.h:
1374
1375 2007-10-09  Lars Knoll  <lars@trolltech.com>
1376
1377         Reviewed by Simon.
1378
1379         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
1380
1381         * DumpRenderTree/qt/DumpRenderTree.h:
1382         * DumpRenderTree/qt/jsobjects.cpp:
1383         (LayoutTestController::clearBackForwardList):
1384         * DumpRenderTree/qt/jsobjects.h:
1385
1386 2007-10-09  Lars Knoll  <lars@trolltech.com>
1387
1388         Reviewed by Simon.
1389
1390         make --git-reviewer work again.
1391
1392         * Scripts/prepare-ChangeLog:
1393
1394 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
1395
1396         Rubber stamped by Eric.
1397
1398         Connect to the "hovering-over-link" signal emitted by WebKitPage and
1399         show the current link inside the statusbar.
1400         This shows how to make use of this signal and allows to easily test
1401         http://bugs.webkit.org/show_bug.cgi?id=15299.
1402
1403         * GtkLauncher/main.cpp:
1404         (hoveringOverLink):
1405         (main):
1406
1407 2007-10-05  Lars Knoll  <lars@trolltech.com>
1408
1409         add proper error messages to the FrameLoaderClient.
1410         Implement ChromeClientQt::closeWindowSoon and
1411         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
1412         Some fixes in DRT to make it work correctly with multiple windows.
1413
1414         Reviewed by Maciej.
1415
1416         * DumpRenderTree/qt/DumpRenderTree.cpp:
1417         (WebCore::DumpRenderTree::DumpRenderTree):
1418         (WebCore::DumpRenderTree::createWindow):
1419         (WebCore::DumpRenderTree::windowCount):
1420         * DumpRenderTree/qt/DumpRenderTree.h:
1421         * DumpRenderTree/qt/jsobjects.cpp:
1422         (LayoutTestController::maybeDump):
1423         (LayoutTestController::windowCount):
1424         * DumpRenderTree/qt/jsobjects.h:
1425
1426 2007-10-05  Lars Knoll  <lars@trolltech.com>
1427
1428         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
1429         Add support for layoutTextController.setCanOpenWindows() to DRT
1430         fixing another 2 test cases in fast/dom/Window.
1431
1432         Reviewed by Maciej.
1433
1434         * DumpRenderTree/qt/DumpRenderTree.cpp:
1435         (WebCore::WebPage::WebPage):
1436         (WebCore::WebPage::createWindow):
1437         (WebCore::DumpRenderTree::resetJSObjects):
1438         (WebCore::DumpRenderTree::createWindow):
1439         * DumpRenderTree/qt/DumpRenderTree.h:
1440         * DumpRenderTree/qt/DumpRenderTree.pro:
1441         * DumpRenderTree/qt/jsobjects.cpp:
1442         (LayoutTestController::LayoutTestController):
1443         (LayoutTestController::reset):
1444         * DumpRenderTree/qt/jsobjects.h:
1445         * DumpRenderTree/qt/main.cpp:
1446         * DumpRenderTree/qt/testplugin.cpp: Added.
1447         * DumpRenderTree/qt/testplugin.h: Added.
1448
1449 2007-10-04  Sam Weinig  <sam@webkit.org>
1450
1451         Rubber stamped by Adam.
1452
1453         Remove empty directories.
1454
1455         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
1456         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
1457
1458 2007-10-03  Darin Adler  <darin@apple.com>
1459
1460         Reviewed by Adam.
1461
1462         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
1463         we find the internal libraries in the libraries directory. This
1464         is helpful for Safari team engineers at Apple.
1465
1466 2007-10-03  Adam Roben  <aroben@apple.com>
1467
1468         Update the location of AHEM___.TTF after r25968
1469
1470         Reviewed by Sam.
1471
1472         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1473
1474 2007-10-03  Alp Toker  <alp@atoker.com>
1475
1476         Reviewed by Adam.
1477
1478         http://bugs.webkit.org/show_bug.cgi?id=14726
1479         [gtk] API design. Mapping the WebView delegates to signals.
1480
1481         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
1482
1483         * GtkLauncher/main.cpp:
1484         (goToURLBarText):
1485         (titleChanged):
1486         (progressChanged):
1487         (menuMainBackCallback):
1488         (menuMainForwardCallback):
1489         (main):
1490
1491 2007-10-03  Lars Knoll  <lars@trolltech.com>
1492
1493         Reviewed by Rob.
1494
1495         This fixes --strict mode in run-webkit-tests again after
1496         the platform dependent test results have been moved.
1497
1498         * Scripts/run-webkit-tests:
1499
1500 2007-10-03  Lars Knoll  <lars@trolltech.com>
1501
1502         Reviewed by bdash.
1503
1504         remove the hack in run-webkit-tests that forced text only test
1505         to be taken from the platform independent dir. It was only left
1506         there from early days.
1507         
1508         Remove platform dependent results for tests that are text only nowadays,
1509         and add one platform dependent result for a text only test that requires it.
1510
1511         * Scripts/run-webkit-tests:
1512
1513 2007-10-03  Lars Knoll  <lars@trolltech.com>
1514
1515         Reviewed by olliej.
1516
1517         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
1518
1519         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
1520         (WebCore::WebFrame::WebFrame):
1521         (WebCore::WebPage::WebPage):
1522         (WebCore::WebPage::createFrame):
1523         (WebCore::WebPage::javaScriptAlert):
1524         (WebCore::WebPage::javaScriptConsoleMessage):
1525         (WebCore::DumpRenderTree::DumpRenderTree):
1526         (WebCore::DumpRenderTree::~DumpRenderTree):
1527         (WebCore::DumpRenderTree::open):
1528         (WebCore::DumpRenderTree::readStdin):
1529         (WebCore::DumpRenderTree::resetJSObjects):
1530         (WebCore::DumpRenderTree::initJSObjects):
1531         (WebCore::DumpRenderTree::dumpFramesAsText):
1532         (WebCore::DumpRenderTree::dump):
1533         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
1534         (WebCore::DumpRenderTree::layoutTestController):
1535         (WebCore::DumpRenderTree::eventSender):
1536         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
1537         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
1538         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
1539         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
1540         (HackWebFrame::mousePressEvent):
1541         (HackWebFrame::mouseReleaseEvent):
1542         (HackWebFrame::mouseMoveEvent):
1543         (HackWebFrame::HackWebFrame):
1544         (HackWebFrame::~HackWebFrame):
1545         (LayoutTestController::LayoutTestController):
1546         (LayoutTestController::reset):
1547         (LayoutTestController::maybeDump):
1548         (LayoutTestController::waitUntilDone):
1549         (LayoutTestController::notifyDone):
1550         (LayoutTestController::dumpEditingCallbacks):
1551         (LayoutTestController::queueReload):
1552         (LayoutTestController::provisionalLoad):
1553         (LayoutTestController::timerEvent):
1554         (EventSender::EventSender):
1555         (EventSender::mouseDown):
1556         (EventSender::mouseUp):
1557         (EventSender::mouseMoveTo):
1558         (EventSender::leapForward):
1559         (EventSender::keyDown):
1560         (EventSender::frameUnderMouse):
1561         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
1562         (LayoutTestController::isLoading):
1563         (LayoutTestController::setLoading):
1564         (LayoutTestController::shouldDumpAsText):
1565         (LayoutTestController::shouldDumpChildrenAsText):
1566         (LayoutTestController::shouldWaitUntilDone):
1567         (LayoutTestController::dumpAsText):
1568         (LayoutTestController::dumpChildFramesAsText):
1569         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
1570         (messageHandler):
1571         (crashHandler):
1572         (main):
1573         * Scripts/run-webkit-tests:
1574
1575 2007-10-03  Mark Rowe  <mrowe@apple.com>
1576
1577         Reviewed by Alp Toker.
1578
1579         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
1580         should take precedence over QTDIR when determining which port we are working with.
1581
1582         * Scripts/webkitdirs.pm: 
1583
1584 2007-10-02  Adam Roben  <aroben@apple.com>
1585
1586         Add keychain to the list of default packages to install
1587
1588         Rubberstamped by Sam.
1589
1590         * CygwinDownloader/cygwin-downloader.py:
1591         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
1592
1593 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
1594
1595         Reviewed by Adam.
1596
1597         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
1598         Also makes WebCore regression test case logic work when using git.
1599
1600         * Scripts/prepare-ChangeLog:
1601         (reviewerAndDescriptionForGitCommit): Added.
1602
1603 2007-10-02  Lars Knoll  <lars@trolltech.com>
1604
1605         Reviewed by bdash.
1606
1607         Add API to retrieve the frame name from QWebFrame.
1608         Implement support for DRT::dumpChildrenAsText.
1609
1610         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1611         (WebCore::DumpRenderTree::dumpFramesAsText):
1612         (WebCore::DumpRenderTree::dump):
1613         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
1614         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1615         (LayoutTestController::LayoutTestController):
1616         (LayoutTestController::reset):
1617         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
1618
1619 2007-10-02  Lars Knoll  <lars@trolltech.com>
1620
1621         Reviewed by bdash.
1622
1623         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
1624
1625         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1626         (WebCore::DumpRenderTree::readStdin):
1627
1628 2007-10-02  Mark Rowe  <mrowe@apple.com>
1629
1630         Reviewed by Oliver.
1631
1632         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1633
1634         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1635         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1636
1637 2007-10-02  Mark Rowe  <mrowe@apple.com>
1638
1639         Rubber-stamped by Maciej.
1640
1641         Configuration changes from build.webkit.org.  The major change is refactoring to work
1642         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
1643         last few weeks.
1644
1645         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1646         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
1647         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
1648         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
1649         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
1650         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
1651         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
1652         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
1653
1654 2007-10-02  Lars Knoll  <lars@trolltech.com>
1655
1656         Reviewed by Maciej.
1657
1658         Add support for eventSender.mouseMove to DRT.
1659         Fixes fast/css/hover-affects-child.html
1660
1661         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1662         (EventSender::mouseMoveTo):
1663
1664 2007-10-01  Mark Rowe  <mrowe@apple.com>
1665
1666         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1667
1668 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
1669
1670         Reviewed by Hyatt.
1671
1672         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
1673
1674         * Scripts/svn-apply:
1675         (gitdiff2svndiff): Ignore lines beginning with "new file".
1676         * Scripts/svn-unapply:
1677         (gitdiff2svndiff): Ditto.
1678
1679 2007-09-30  George Staikos  <staikos@kde.org>
1680
1681         Qt build fix (Mac OS X specific)
1682
1683         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
1684
1685 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
1686
1687         Reviewed by Mark.
1688
1689         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
1690         Remove Bakefiles from svn.
1691
1692         * GtkLauncher/Bakefiles.bkgen: Removed.
1693         * GtkLauncher/ENV: Removed.
1694         * GtkLauncher/gdklauncher.bkl: Removed.
1695         * GtkLauncher/mk: Removed.
1696         * Scripts/regenerate-makefiles: Removed.
1697
1698 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
1699
1700         Reviewed by John.
1701
1702         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
1703
1704         * Scripts/run-webkit-tests:
1705
1706 2007-09-26  Adam Roben  <aroben@apple.com>
1707
1708         Make not finding an installed WebKit non-fatal
1709
1710         What really matters is that we are able to load WebKit and its
1711         dependencies, not whether we think we've found an installed WebKit.
1712
1713         Reviewed by Sam.
1714
1715         * WebKitInitializer/WebKitInitializer.cpp:
1716         (getWebViewCLSID): Use new LOG_WARNING macro.
1717         (getInstalledWebKitDirectory): Ditto.
1718         (initializeWebKit): Don't die if we didn't find an installed WebKit,
1719         and use new macros.
1720         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
1721
1722 2007-09-26  Adam Roben  <aroben@apple.com>
1723
1724         Committed this file before saving it
1725
1726         * WebKitInitializer/debug_internal.vsprops:
1727
1728 2007-09-26  Adam Roben  <aroben@apple.com>
1729
1730         Load WebKit and its dependencies manually so they come from DllDirectory
1731
1732         I had to change WebKitInitializer to use malloc/free instead of
1733         new/delete to avoid pulling in WebKit (and its dependencies) early
1734         through use of fastMalloc.
1735
1736         Reviewed by Oliver.
1737
1738         * WebKitInitializer/WebKitInitializer.cpp:
1739         (getStringValue): Changed to use malloc/free.
1740         (getInstalledWebKitDirectory): Ditto.
1741         (initializeWebKit): Call SetDllDirectory first, then load all of
1742         WebKit's dependencies manually, finally followed by WebKit itself.
1743         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
1744         configuration to match our other projects.
1745         * WebKitInitializer/debug_internal.vsprops: Added.
1746
1747 2007-09-25  Adam Roben  <aroben@apple.com>
1748
1749         Actually define DEBUG/NDEBUG so that we load WebKit correctly
1750
1751         Rubberstamped by Sam.
1752
1753         * WebKitInitializer/WebKitInitializer.vcproj:
1754
1755 2007-09-25  Adam Roben  <aroben@apple.com>
1756
1757         Make DumpRenderTree delay-load its dependencies
1758
1759         This lets WebKitInitializer re-route the dependencies to be loaded out
1760         of the Safari installation directory.
1761
1762         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
1763         same thing), since we can't import the kCFAllocatorDefault symbol when
1764         delay-loading CoreFoundation.dll.
1765
1766         Rubberstamped by Sam.
1767
1768         * DumpRenderTree/win/DumpRenderTree.cpp:
1769         (runTest):
1770         (javaScriptThreads):
1771         * DumpRenderTree/win/DumpRenderTree.vcproj:
1772         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1773         (LayoutTestController::setWaitToDump):
1774
1775 2007-09-25  Adam Roben  <aroben@apple.com>
1776
1777         Pull ole32.lib into WebKitInitializer
1778
1779         Rubberstamped by Sam.
1780
1781         * WebKitInitializer/WebKitInitializer.vcproj:
1782
1783 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
1784
1785         Reviewed by Adam.
1786
1787         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
1788           LGPL'ed files contain incorrect FSF address
1789
1790         * Drosera/config.h:
1791
1792 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
1793
1794         Reviewed by Adam.
1795
1796         Make svn-apply and svn-unapply work with git-diff formatted patches.
1797
1798         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
1799         (gitdiff2svndiff): Added.
1800         * Scripts/svn-unapply: Ditto.
1801         (gitdiff2svndiff): Added.
1802
1803 2007-09-25  Adam Roben  <aroben@apple.com>
1804
1805         Pull advapi32.lib into WebKitInitializer
1806
1807         This is needed to get the registry functions we use.
1808
1809         Rubberstamped by Sam.
1810
1811         * WebKitInitializer/WebKitInitializer.vcproj:
1812
1813 2007-09-25  Adam Roben  <aroben@apple.com>
1814
1815         Add python and rsync to cygwin-downloader
1816
1817         Our build slaves need this, and it can't hurt for everyone else to
1818         have it, too.
1819
1820         Reviewed by Sam.
1821
1822         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
1823         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
1824
1825 2007-09-25  Adam Roben  <aroben@apple.com>
1826
1827         Add WebKitInitializer and use it in DumpRenderTree
1828
1829         WebKitInitializer is a static library that has one function,
1830         initializeWebKit(). This registers WebKit and sets up the DLL search
1831         path so that WebKit's dependencies that are installed with Safari can
1832         be found.
1833
1834         Reviewed by Sam.
1835
1836         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
1837         DumpRenderTree depend on it.
1838         * DumpRenderTree/win/DumpRenderTree.cpp:
1839         (initialize): Call initializeWebKit.
1840         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
1841         WebKitInitializer.lib.
1842         * WebKitInitializer/WebKitInitializer.cpp: Added.
1843         (getStringValue):
1844         (getWebViewCLSID):
1845         (getInstalledWebKitDirectory):
1846         (initializeWebKit):
1847         * WebKitInitializer/WebKitInitializer.h: Added.
1848         * WebKitInitializer/WebKitInitializer.vcproj: Added.
1849         * WebKitInitializer/debug.vsprops: Added.
1850         * WebKitInitializer/release.vsprops: Added.
1851
1852 2007-09-25  Adam Roben  <aroben@apple.com>
1853
1854         Make run-webkit-tests respect set-webkit-configuration
1855
1856         Reviewed by Sam.
1857
1858         * Scripts/run-webkit-tests: Initialize $configuration to whatever
1859         set-webkit-configuration was last set to.
1860
1861 2007-09-25  Mark Rowe  <mrowe@apple.com>
1862
1863         Rubber-stamped by Eric.
1864
1865         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1866         This makes it possible to automate nightly builds for the feature-branch.
1867
1868 2007-09-25  Adam Roben  <aroben@apple.com>
1869
1870         A couple of fixes/enhancements to update-webkit-*-libs
1871
1872         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
1873         to tell update-webkit-support-libraries where it should find the
1874         WebKitSupportLibrary.zip file you downloaded.
1875
1876         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
1877         Windows-style path.
1878
1879         Reviewed by Sam.
1880
1881         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
1882         to $auxiliaryLibsURL and removed an irrelevant comment.
1883         * Scripts/update-webkit-support-libs:
1884
1885 2007-09-25  Adam Treat  <treat@kde.org>
1886
1887         Reviewed by Simon and Lars.
1888
1889         Refactors and cleans up Qt DRT member variable names, member variable
1890         initialization, style fixes and general code cleanup.
1891
1892         Adds queueReload slot to LayoutTestController that some tests require.
1893
1894         Subclasses QWebFrame to make sure that all frames have an associated
1895         LayoutTestController JS window object.
1896
1897         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
1898         aren't dumped twice.
1899
1900         EOF fixes.
1901
1902         Together, this patch fixes some 20+ layout tests in QtWebKit.
1903
1904         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1905         (WebCore::WebFrame::WebFrame):
1906         (WebCore::WebPage::WebPage):
1907         (WebCore::WebPage::createFrame):
1908         (WebCore::DumpRenderTree::DumpRenderTree):
1909         (WebCore::DumpRenderTree::open):
1910         (WebCore::DumpRenderTree::readStdin):
1911         (WebCore::DumpRenderTree::initJSObjects):
1912         (WebCore::DumpRenderTree::dump):
1913         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
1914         (WebCore::DumpRenderTree::layoutTestController):
1915         (WebCore::DumpRenderTree::eventSender):
1916         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1917         (LayoutTestController::LayoutTestController):
1918         (LayoutTestController::reset):
1919         (LayoutTestController::maybeDump):
1920         (LayoutTestController::waitUntilDone):
1921         (LayoutTestController::notifyDone):
1922         (LayoutTestController::queueReload):
1923         (LayoutTestController::provisionalLoad):
1924         (EventSender::EventSender):
1925         (EventSender::mouseDown):
1926         (EventSender::mouseUp):
1927         (EventSender::mouseMoveTo):
1928         (EventSender::frameUnderMouse):
1929         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
1930         (LayoutTestController::isLoading):
1931         (LayoutTestController::setLoading):
1932         (LayoutTestController::dumpAsText):
1933         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
1934         (main):
1935
1936 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
1937
1938
1939         - Reverted an accidentally checked in file.
1940
1941         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
1942
1943 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
1944         Reviewed by Sam.
1945
1946         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
1947
1948         * DumpRenderTree/win/DumpRenderTree.vcproj:
1949         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1950
1951 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
1952
1953         Rubber stamped by Adam.
1954
1955         * GdkLauncher: Removed.
1956         * GdkLauncher/Bakefiles.bkgen: Removed.
1957         * GdkLauncher/ENV: Removed.
1958         * GdkLauncher/GdkLauncher.pro: Removed.
1959         * GdkLauncher/gdklauncher.bkl: Removed.
1960         * GdkLauncher/main.cpp: Removed.
1961         * GdkLauncher/mk: Removed.
1962         * GdkLauncher/simple.svg: Removed.
1963         * GdkLauncher/text.html: Removed.
1964         * GtkLauncher: Added.
1965         * GtkLauncher/GdkLauncher.pro: Removed.
1966         * GtkLauncher/GtkLauncher.pro: Added.
1967         * GtkLauncher/main.cpp:
1968         (updateWindowTitle):
1969         (main):
1970         * Scripts/build-webkit:
1971         * Scripts/regenerate-makefiles:
1972         * Scripts/run-javascriptcore-tests:
1973         * Scripts/run-launcher:
1974         * Scripts/run-webkit-tests:
1975         * Scripts/webkitdirs.pm:
1976
1977 2007-09-21  Timothy Hatcher  <timothy@apple.com>
1978
1979         Reviewed by Darin.
1980
1981         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
1982
1983         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
1984         This is tested by plugins/root-object-premature-delete-crash.html.
1985
1986         * DumpRenderTree/mac/ObjCController.m:
1987         (-[ObjCController accessStoredWebScriptObject]):
1988
1989 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
1990
1991         Reviewed by Oliver.
1992
1993         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
1994
1995         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1996         (FrameLoadDelegate::FrameLoadDelegate):
1997
1998 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
1999
2000         Reviewed by Adam.
2001
2002         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
2003         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
2004
2005         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
2006         Now isQt() and isGdk() use global variables that are only set once.
2007
2008         An array of all the parameters is now given to build-dumprender which includes
2009         the platform on linux.
2010
2011         * Scripts/build-dumprendertree:
2012         * Scripts/run-webkit-tests:
2013         * Scripts/webkitdirs.pm:
2014
2015 2007-09-19  Adam Roben  <aroben@apple.com>
2016
2017         Rubberstamped by Hyatt.
2018
2019         * Spinneret: Removed.
2020
2021 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
2022
2023         Reviewed by David Kilzer.
2024
2025         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
2026
2027 2007-09-18  Sam Weinig  <sam@webkit.org>
2028
2029         Add JSRetainPtr.h #include to fix some builds.
2030
2031         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2032
2033 2007-09-18  Mike Hommey  <glandium@debian.org>
2034
2035         Reviewed by Adam.
2036
2037         * Scripts/prepare-ChangeLog:
2038         - Properly parse GECOS field.
2039         - Use git configuration for user name and email when appropriate.
2040
2041 2007-09-17  Sam Weinig  <sam@webkit.org>
2042
2043         Build fix.
2044
2045         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2046
2047 2007-09-17  Sam Weinig  <sam@webkit.org>
2048
2049         Reviewed by Adam Roben.
2050
2051         Share more code between mac and windows DRT.
2052             - GCController is now shared.
2053             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
2054
2055         * DumpRenderTree/GCController.cpp:
2056         * DumpRenderTree/win/DumpRenderTree.cpp:
2057         * DumpRenderTree/win/DumpRenderTree.vcproj:
2058         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
2059         (FrameLoadDelegate::FrameLoadDelegate):
2060         (FrameLoadDelegate::~FrameLoadDelegate):
2061         (FrameLoadDelegate::windowScriptObjectAvailable):
2062         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
2063         * DumpRenderTree/win/GCController.cpp: Removed.
2064         * DumpRenderTree/win/GCController.h: Removed.
2065         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
2066         (GCController::collect):
2067         (GCController::collectOnAlternateThread):
2068         (GCController::getJSObjectCount):
2069         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
2070         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
2071
2072 2007-09-17  Sam Weinig  <sam@webkit.org>
2073
2074         Reviewed by Adam Roben.
2075
2076         Begin sharing code between mac and windows DRT.
2077             - both now share LayoutTestController.h/cpp and implement platform dependant 
2078               operations in LayoutTestControllerMac/Win.
2079             - DumpRenderTree.h is now shared.
2080             - WorkQueue and WorkQueueItem are also shared.
2081
2082         * DumpRenderTree/DumpRenderTree.h:
2083         * DumpRenderTree/LayoutTestController.cpp:
2084         * DumpRenderTree/win/DumpRenderTree.cpp:
2085         (displayWebView):
2086         (dumpFrameScrollPosition):
2087         (dumpFramesAsText):
2088         (dump):
2089         (runTest):
2090         * DumpRenderTree/win/DumpRenderTree.h: Removed.
2091         * DumpRenderTree/win/DumpRenderTree.vcproj:
2092         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
2093         * DumpRenderTree/win/EditingDelegate.cpp:
2094         (EditingDelegate::shouldBeginEditingInDOMRange):
2095         (EditingDelegate::shouldEndEditingInDOMRange):
2096         (EditingDelegate::shouldInsertNode):
2097         (EditingDelegate::shouldInsertText):
2098         (EditingDelegate::shouldDeleteDOMRange):
2099         (EditingDelegate::shouldChangeSelectedDOMRange):
2100         (EditingDelegate::shouldApplyStyle):
2101         (EditingDelegate::shouldChangeTypingStyle):
2102         (EditingDelegate::doPlatformCommand):
2103         (EditingDelegate::webViewDidBeginEditing):
2104         (EditingDelegate::webViewDidChange):
2105         (EditingDelegate::webViewDidEndEditing):
2106         (EditingDelegate::webViewDidChangeTypingStyle):
2107         (EditingDelegate::webViewDidChangeSelection):
2108         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
2109         * DumpRenderTree/win/LayoutTestController.h: Removed.
2110         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
2111         (LayoutTestController::addDisallowedURL):
2112         (LayoutTestController::clearBackForwardList):
2113         (LayoutTestController::copyDecodedHostName):
2114         (LayoutTestController::copyEncodedHostName):
2115         (LayoutTestController::display):
2116         (LayoutTestController::keepWebHistory):
2117         (LayoutTestController::notifyDone):
2118         (LayoutTestController::queueBackNavigation):
2119         (LayoutTestController::queueForwardNavigation):
2120         (jsStringRefToWString):
2121         (LayoutTestController::queueLoad):
2122         (LayoutTestController::queueReload):
2123         (LayoutTestController::queueScript):
2124         (LayoutTestController::setAcceptsEditing):
2125         (LayoutTestController::setCustomPolicyDelegate):
2126         (LayoutTestController::setMainFrameIsFirstResponder):
2127         (LayoutTestController::setTabKeyCyclesThroughElements):
2128         (LayoutTestController::setUseDashboardCompatibilityMode):
2129         (LayoutTestController::setUserStyleSheetEnabled):
2130         (LayoutTestController::setUserStyleSheetLocation):
2131         (LayoutTestController::setWindowIsKey):
2132         (waitUntilDoneWatchdogFired):
2133         (LayoutTestController::setWaitToDump):
2134         (LayoutTestController::windowCount):
2135         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
2136         (FrameLoadDelegate::didReceiveTitle):
2137         (FrameLoadDelegate::processWork):
2138         (FrameLoadDelegate::locationChangeDone):
2139         (FrameLoadDelegate::windowScriptObjectAvailable):
2140         * DumpRenderTree/win/WorkQueue.cpp: Removed.
2141         * DumpRenderTree/win/WorkQueue.h: Removed.
2142         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
2143         * DumpRenderTree/win/WorkQueueItem.h: Removed.
2144         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
2145         (jsStringRefToWString):
2146         (LoadItem::invoke):
2147         (ScriptItem::invoke):
2148
2149 2007-09-17  Sam Weinig  <sam@webkit.org>
2150
2151         Reviewed by Adam Roben.
2152
2153         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
2154
2155         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
2156         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
2157         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
2158         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
2159         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
2160         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
2161         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
2162         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
2163         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
2164         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
2165         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
2166         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
2167         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
2168         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
2169         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
2170         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
2171         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
2172         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
2173         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
2174         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
2175         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
2176         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
2177         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
2178         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
2179         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
2180         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
2181         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
2182         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
2183         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
2184         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
2185         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
2186         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
2187         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
2188         * DumpRenderTree/win: Added.
2189         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
2190         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
2191         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
2192         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
2193         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
2194         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
2195         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
2196         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
2197         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
2198         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
2199         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
2200         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
2201         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
2202         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2203         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
2204         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
2205         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
2206         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
2207         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2208         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2209         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
2210         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2211         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
2212         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
2213         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
2214         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
2215
2216 2007-09-15  Mark Rowe  <mrowe@apple.com>
2217
2218         Build fix for DumpRenderTree.
2219
2220         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
2221
2222 2007-09-14  Sam Weinig  <sam@webkit.org>
2223
2224         Rubber stamped by Adam Roben.
2225
2226         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
2227           - The UIDelegate was put into a new file while the FrameLoadDelegate was
2228             kept in the WaitUntilDoneDelegate file for the time being.
2229
2230         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
2231         (main):
2232         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
2233         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
2234         (UIDelegate::QueryInterface):
2235         (UIDelegate::AddRef):
2236         (UIDelegate::Release):
2237         (UIDelegate::hasCustomMenuImplementation):
2238         (UIDelegate::setFrame):
2239         (UIDelegate::webViewFrame):
2240         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2241         (UIDelegate::webViewAddMessageToConsole):
2242         (UIDelegate::doDragDrop):
2243         (UIDelegate::webViewGetDlgCode):
2244         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
2245         (UIDelegate::UIDelegate):
2246         (UIDelegate::createWebViewWithRequest):
2247         (UIDelegate::webViewShow):
2248         (UIDelegate::webViewClose):
2249         (UIDelegate::webViewFocus):
2250         (UIDelegate::webViewUnfocus):
2251         (UIDelegate::webViewFirstResponder):
2252         (UIDelegate::makeFirstResponder):
2253         (UIDelegate::setStatusText):
2254         (UIDelegate::webViewStatusText):
2255         (UIDelegate::webViewAreToolbarsVisible):
2256         (UIDelegate::setToolbarsVisible):
2257         (UIDelegate::webViewIsStatusBarVisible):
2258         (UIDelegate::setStatusBarVisible):
2259         (UIDelegate::webViewIsResizable):
2260         (UIDelegate::setResizable):
2261         (UIDelegate::setContentRect):
2262         (UIDelegate::webViewContentRect):
2263         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2264         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2265         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2266         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
2267         (UIDelegate::mouseDidMoveOverElement):
2268         (UIDelegate::contextMenuItemsForElement):
2269         (UIDelegate::validateUserInterfaceItem):
2270         (UIDelegate::shouldPerformAction):
2271         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
2272         (UIDelegate::willPerformDragDestinationAction):
2273         (UIDelegate::dragSourceActionMaskForPoint):
2274         (UIDelegate::willPerformDragSourceAction):
2275         (UIDelegate::contextMenuItemSelected):
2276         (UIDelegate::trackCustomPopupMenu):
2277         (UIDelegate::measureCustomMenuItem):
2278         (UIDelegate::drawCustomMenuItem):
2279         (UIDelegate::addCustomMenuDrawingData):
2280         (UIDelegate::cleanUpCustomMenuDrawingData):
2281         (UIDelegate::canTakeFocus):
2282         (UIDelegate::takeFocus):
2283         (UIDelegate::registerUndoWithTarget):
2284         (UIDelegate::removeAllActionsWithTarget):
2285         (UIDelegate::setActionTitle):
2286         (UIDelegate::undo):
2287         (UIDelegate::redo):
2288         (UIDelegate::canUndo):
2289         (UIDelegate::canRedo):
2290         (UIDelegate::webViewResizerRect):
2291         (UIDelegate::webViewDrawResizer):
2292         (UIDelegate::webViewScrolled):
2293         (UIDelegate::webViewShouldInterruptJavaScript):
2294         (UIDelegate::webViewReceivedFocus):
2295         (UIDelegate::webViewLostFocus):
2296         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
2297         (FrameLoadDelegate::QueryInterface):
2298         (FrameLoadDelegate::AddRef):
2299         (FrameLoadDelegate::Release):
2300         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2301         (FrameLoadDelegate::didCommitLoadForFrame):
2302         (FrameLoadDelegate::didReceiveTitle):
2303         (FrameLoadDelegate::processWork):
2304         (processWorkTimer):
2305         (FrameLoadDelegate::locationChangeDone):
2306         (FrameLoadDelegate::didFinishLoadForFrame):
2307         (FrameLoadDelegate::didFailLoadWithError):
2308         (FrameLoadDelegate::windowScriptObjectAvailable):
2309         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
2310         (FrameLoadDelegate::FrameLoadDelegate):
2311
2312 2007-09-14  Sam Weinig  <sam@webkit.org>
2313
2314         Reviewed by Kevin McCullough.
2315
2316         Move mac specific globals in to mac/DumpRenderTreeMac.h
2317
2318         * DumpRenderTree/DumpRenderTree.h:
2319         * DumpRenderTree/DumpRenderTree.mm: Removed.
2320         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2321         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
2322         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
2323
2324 2007-09-14  Brady Eidson  <beidson@apple.com>
2325
2326         Rubberstamped by Weinig
2327
2328         You know, Sam, some of us use case-sensitve filesystems...
2329
2330         * DumpRenderTree/DumpRenderTree.h:
2331         * DumpRenderTree/mac/UIDelegate.mm:
2332
2333 2007-09-14  Sam Weinig  <sam@webkit.org>
2334
2335         Rubber stamped by Adam Roben.
2336
2337         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
2338         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
2339
2340         * DumpRenderTree/AppleScriptController.h: Removed.
2341         * DumpRenderTree/AppleScriptController.m: Removed.
2342         * DumpRenderTree/DumpRenderTree.h:
2343         * DumpRenderTree/DumpRenderTree.mm:
2344         (startJavaScriptThreads):
2345         (stopJavaScriptThreads):
2346         (activateAhemFont):
2347         (setDefaultColorProfileToRGB):
2348         (makeLargeMallocFailSilently):
2349         (dumpFrameScrollPosition):
2350         (dumpFramesAsText):
2351         (dump):
2352         (runTest):
2353         (-[DumpRenderTreeWindow isKeyWindow]):
2354         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2355         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
2356         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
2357         * DumpRenderTree/EditingDelegate.h: Removed.
2358         * DumpRenderTree/EditingDelegate.m: Removed.
2359         * DumpRenderTree/EventSendingController.h: Removed.
2360         * DumpRenderTree/EventSendingController.m: Removed.
2361         * DumpRenderTree/FrameLoadDelegate.h: Removed.
2362         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
2363         * DumpRenderTree/GCController.mm: Removed.
2364         * DumpRenderTree/ImageDiff.m: Removed.
2365         * DumpRenderTree/LayoutTestController.cpp:
2366         (LayoutTestController::LayoutTestController):
2367         (dumpAsTextCallback):
2368         (dumpBackForwardListCallback):
2369         (dumpChildFramesAsTextCallback):
2370         (dumpChildFrameScrollPositionsCallback):
2371         (dumpDOMAsWebArchiveCallback):
2372         (dumpEditingCallbacksCallback):
2373         (dumpFrameLoadCallbacksCallback):
2374         (dumpResourceLoadCallbacksCallback):
2375         (dumpSelectionRectCallback):
2376         (dumpSourceAsWebArchiveCallback):
2377         (dumpTitleChangesCallback):
2378         (repaintSweepHorizontallyCallback):
2379         (setCallCloseOnWebViewsCallback):
2380         (setCanOpenWindowsCallback):
2381         (setCloseRemainingWindowsWhenCompleteCallback):
2382         (testRepaintCallback):
2383         (addFileToPasteboardOnDragCallback):
2384         (waitUntilDoneCallback):
2385         * DumpRenderTree/LayoutTestController.h:
2386         (LayoutTestController::dumpAsText):
2387         (LayoutTestController::setDumpAsText):
2388         (LayoutTestController::dumpBackForwardList):
2389         (LayoutTestController::setDumpBackForwardList):
2390         (LayoutTestController::dumpChildFrameScrollPositions):
2391         (LayoutTestController::setDumpChildFrameScrollPositions):
2392         (LayoutTestController::dumpChildFramesAsText):
2393         (LayoutTestController::setDumpChildFramesAsText):
2394         (LayoutTestController::dumpDOMAsWebArchive):
2395         (LayoutTestController::setDumpDOMAsWebArchive):
2396         (LayoutTestController::dumpSelectionRect):
2397         (LayoutTestController::setDumpSelectionRect):
2398         (LayoutTestController::dumpSourceAsWebArchive):
2399         (LayoutTestController::setDumpSourceAsWebArchive):
2400         (LayoutTestController::dumpTitleChanges):
2401         (LayoutTestController::setDumpTitleChanges):
2402         (LayoutTestController::dumpEditingCallbacks):
2403         (LayoutTestController::setDumpEditingCallbacks):
2404         (LayoutTestController::dumpResourceLoadCallbacks):
2405         (LayoutTestController::setDumpResourceLoadCallbacks):
2406         (LayoutTestController::dumpFrameLoadCallbacks):
2407         (LayoutTestController::setDumpFrameLoadCallbacks):
2408         (LayoutTestController::addFileToPasteboardOnDrag):
2409         (LayoutTestController::setAddFileToPasteboardOnDrag):
2410         (LayoutTestController::callCloseOnWebViews):
2411         (LayoutTestController::setCallCloseOnWebViews):
2412         (LayoutTestController::canOpenWindows):
2413         (LayoutTestController::setCanOpenWindows):
2414         (LayoutTestController::closeRemainingWindowsWhenComplete):
2415         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2416         (LayoutTestController::testRepaint):
2417         (LayoutTestController::setTestRepaint):
2418         (LayoutTestController::testRepaintSweepHorizontally):
2419         (LayoutTestController::setTestRepaintSweepHorizontally):
2420         (LayoutTestController::waitToDump):
2421         (LayoutTestController::windowIsKey):
2422         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
2423         * DumpRenderTree/NavigationController.h: Removed.
2424         * DumpRenderTree/NavigationController.m: Removed.
2425         * DumpRenderTree/ObjCController.h: Removed.
2426         * DumpRenderTree/ObjCController.m: Removed.
2427         * DumpRenderTree/ObjCPlugin.h: Removed.
2428         * DumpRenderTree/ObjCPlugin.m: Removed.
2429         * DumpRenderTree/ObjCPluginFunction.h: Removed.
2430         * DumpRenderTree/ObjCPluginFunction.m: Removed.
2431         * DumpRenderTree/PolicyDelegate.h: Removed.
2432         * DumpRenderTree/PolicyDelegate.m: Removed.
2433         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
2434         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
2435         * DumpRenderTree/TextInputController.h: Removed.
2436         * DumpRenderTree/TextInputController.m: Removed.
2437         * DumpRenderTree/UIDelegate.h: Removed.
2438         * DumpRenderTree/UIDelegate.mm: Removed.
2439         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
2440         * DumpRenderTree/mac: Added.
2441         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
2442         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
2443         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
2444         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
2445         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
2446         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
2447         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2448         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2449         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2450         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2451         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2452         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2453         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2454         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2455         (-[EditingDelegate webViewDidBeginEditing:]):
2456         (-[EditingDelegate webViewDidChange:]):
2457         (-[EditingDelegate webViewDidEndEditing:]):
2458         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2459         (-[EditingDelegate webViewDidChangeSelection:]):
2460         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
2461         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
2462         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
2463         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
2464         (-[FrameLoadDelegate init]):
2465         (-[FrameLoadDelegate dealloc]):
2466         (-[FrameLoadDelegate processWork:]):
2467         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2468         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2469         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2470         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2471         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2472         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2473         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2474         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2475         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2476         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2477         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2478         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2479         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2480         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2481         (-[FrameLoadDelegate webView:willCloseFrame:]):
2482         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2483         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2484         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
2485         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
2486         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
2487         (LayoutTestController::notifyDone):
2488         (LayoutTestController::setWindowIsKey):
2489         (LayoutTestController::setWaitToDump):
2490         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
2491         * DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
2492         * DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
2493         * DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
2494         * DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
2495         * DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
2496         * DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
2497         * DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
2498         * DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
2499         * DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
2500         * DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
2501         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m.
2502         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2503         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2504         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2505         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2506         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2507         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2508         * DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
2509         * DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
2510         * DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
2511         * DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm.
2512         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
2513         (-[UIDelegate webViewFocus:]):
2514         (-[UIDelegate webView:createWebViewWithRequest:]):
2515         (-[UIDelegate webViewClose:]):
2516         * DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.
2517
2518 2007-09-14  Kevin McCullough  <kmccullough@apple.com>
2519
2520         Reviewed by Adam.
2521
2522         - Changing Win version of Drosera work with recent changes.
2523
2524         * Drosera/DebuggerDocument.cpp:
2525         * Drosera/DebuggerDocument.h:
2526         * Drosera/mac/DebuggerDocumentPlatform.mm:
2527         (NSStringCreateWithJSStringRef):
2528         (JSValueRefCreateWithNSString):
2529         * Drosera/win/DebuggerClient.cpp:
2530         (DebuggerClient::stepInto):
2531         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2532
2533 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
2534
2535         Reviewed by Tim.
2536
2537         - Moved isPaused into the JS for efficiency and simplicity.
2538
2539         * Drosera/DebuggerDocument.cpp:
2540         (DebuggerDocument::DebuggerDocument):
2541         (DebuggerDocument::pauseCallback):
2542         (DebuggerDocument::resumeCallback):
2543         (DebuggerDocument::isPaused):
2544         (DebuggerDocument::staticFunctions):
2545         * Drosera/DebuggerDocument.h:
2546         * Drosera/console.js:
2547         * Drosera/debugger.js:
2548         * Drosera/mac/DebuggerClient.mm:
2549         (-[DebuggerClient validateUserInterfaceItem:]):
2550
2551 2007-09-13  Sam Weinig  <sam@webkit.org>
2552
2553         Rubber stamped by Darin.
2554
2555         Make DumpRenderTree more cross platform ready.
2556         - Convert GCController to use the JSCore API instead of the WebScriptObject.
2557         - Use CF types instead of NS objects.
2558         - General cleanup.
2559
2560         * DumpRenderTree/DumpRenderTree.h:
2561         * DumpRenderTree/DumpRenderTree.mm:
2562         (dumpRenderTree):
2563         (dump):
2564         (runTest):
2565         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2566         * DumpRenderTree/EditingDelegate.m:
2567         * DumpRenderTree/FrameLoadDelegate.h:
2568         * DumpRenderTree/FrameLoadDelegate.mm:
2569         (-[FrameLoadDelegate init]):
2570         (-[FrameLoadDelegate dealloc]):
2571         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2572         * DumpRenderTree/GCController.cpp: Added.
2573         (GCController::GCController):
2574         (GCController::~GCController):
2575         (collectCallback):
2576         (collectOnAlternateThreadCallback):
2577         (getJSObjectCountCallback):
2578         (GCController::makeWindowObject):
2579         (GCController::getJSClass):
2580         (GCController::staticFunctions):
2581         * DumpRenderTree/GCController.h:
2582         * DumpRenderTree/GCController.mm:
2583         (GCController::collect):
2584         (GCController::collectOnAlternateThread):
2585         (GCController::getJSObjectCount):
2586         * DumpRenderTree/LayoutTestController.cpp:
2587         (LayoutTestController::makeWindowObject):
2588         (LayoutTestController::getJSClass):
2589         * DumpRenderTree/LayoutTestController.h:
2590         * DumpRenderTree/LayoutTestControllerMac.mm:
2591         (LayoutTestController::addDisallowedURL):
2592         (waitUntilDoneWatchdogFired):
2593         (LayoutTestController::waitUntilDone):
2594         * DumpRenderTree/ResourceLoadDelegate.m:
2595         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2596
2597 2007-09-12  Sam Weinig  <sam@webkit.org>
2598
2599         Reviewed by Stephanie.
2600
2601         Fix leaks in mac DumpRenderTree.
2602
2603         * DumpRenderTree/FrameLoadDelegate.mm:
2604         (-[FrameLoadDelegate init]): Initalize in the correct order.
2605         (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
2606         * DumpRenderTree/LayoutTestController.cpp:
2607         (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released.
2608         (encodeHostNameCallback): ditto.
2609         * DumpRenderTree/LayoutTestController.h:
2610         * DumpRenderTree/LayoutTestControllerMac.mm:
2611         (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule.
2612         (LayoutTestController::copyEncodedHostName): ditto
2613         (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.
2614
2615 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2616
2617         Reviewed by Geof.
2618
2619         - Updated Leopard leak list to include a leak which appears to be fixed in 9A549 but not the version the bot is on.  This will allow us to get the bot green, but later we should remove it.
2620
2621         * Scripts/run-webkit-tests:
2622
2623 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2624
2625         Reviewed by Darin.
2626
2627         - Simplified code paths and extracted out functions to increase encapsulation.
2628
2629         * Drosera/DebuggerDocument.cpp:
2630         (DebuggerDocument::breakpointEditorHTMLCallback):
2631         (DebuggerDocument::isPausedCallback):
2632         (DebuggerDocument::pauseCallback):
2633         (DebuggerDocument::resumeCallback):
2634         (DebuggerDocument::stepIntoCallback):
2635         (DebuggerDocument::evaluateScriptCallback):
2636         (DebuggerDocument::currentFunctionStackCallback):
2637         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
2638         (DebuggerDocument::valueForScopeVariableNamedCallback):
2639         (DebuggerDocument::logCallback):
2640         * Drosera/DebuggerDocument.h:
2641         (DebuggerDocument::getPaused):
2642         * Drosera/mac/DebuggerClient.mm:
2643         (-[DebuggerClient pause:]):
2644         (-[DebuggerClient resume:]):
2645         (-[DebuggerClient stepInto:]):
2646         (-[DebuggerClient stepOver:]):
2647         (-[DebuggerClient stepOut:]):
2648         (-[DebuggerClient showConsole:]):
2649         (-[DebuggerClient closeCurrentFile:]):
2650         (-[DebuggerClient validateUserInterfaceItem:]):
2651         * Drosera/mac/DebuggerDocumentPlatform.mm: Added.
2652         (+[NSString stringOrNilFromWebScriptResult:]):
2653         (DebuggerDocument::platformPause):
2654         (DebuggerDocument::platformResume):
2655         (DebuggerDocument::platformStepInto):
2656         (DebuggerDocument::platformEvaluateScript):
2657         (DebuggerDocument::getPlatformCurrentFunctionStack):
2658         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2659         (DebuggerDocument::platformValueForScopeVariableNamed):
2660         (DebuggerDocument::platformLog):
2661         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2662
2663 2007-09-12  Sam Weinig  <sam@webkit.org>
2664
2665         Build fix for Buildbot.
2666
2667         * DumpRenderTree/DumpRenderTree.mm:
2668         (dump):
2669
2670 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2671
2672         Reviewed by Geoff.
2673
2674         - Updated the leaks list for leopard to help identify regressions.
2675
2676         * Scripts/run-webkit-tests:
2677
2678 2007-09-12  Sam Weinig  <sam@webkit.org>
2679
2680         Rubber stamped by Darin.
2681
2682         Convert the LayoutTestController to use the JSCore API instead of WebScriptObject.
2683
2684         * DumpRenderTree/DumpRenderTree.h: Re-order variables. 
2685         * DumpRenderTree/DumpRenderTree.m: Removed.
2686         * DumpRenderTree/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.m.
2687         (stopJavaScriptThreads): Fix initialization.
2688         (setDefaultColorProfileToRGB): Add explicit cast from void*.
2689         (dumpRenderTree): Ditto.
2690         (runTest):
2691         Used the WorkQueue from the windows DRT instead of the old NSMutableArray one.
2692
2693         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2694         * DumpRenderTree/FrameLoadDelegate.h: Add LayoutTestController instance variable.
2695         * DumpRenderTree/FrameLoadDelegate.m: Removed.
2696         * DumpRenderTree/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.m.
2697         (-[FrameLoadDelegate init]):
2698         (-[FrameLoadDelegate dealloc]):
2699         (-[FrameLoadDelegate processWork:]):
2700         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2701         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2702         Convert to use the new JSCore based LayoutTestController and the new WorkQueue.
2703         
2704         * DumpRenderTree/LayoutTestController.cpp: Added.
2705         (LayoutTestController::LayoutTestController):
2706         (LayoutTestController::~LayoutTestController):
2707         (dumpAsTextCallback):
2708         (dumpBackForwardListCallback):
2709         (dumpChildFramesAsTextCallback):
2710         (dumpChildFrameScrollPositionsCallback):
2711         (dumpDOMAsWebArchiveCallback):
2712         (dumpEditingCallbacksCallback):
2713         (dumpFrameLoadCallbacksCallback):
2714         (dumpResourceLoadCallbacksCallback):
2715         (dumpSelectionRectCallback):
2716         (dumpSourceAsWebArchiveCallback):
2717         (dumpTitleChangesCallback):
2718         (repaintSweepHorizontallyCallback):
2719         (setCallCloseOnWebViewsCallback):
2720         (setCanOpenWindowsCallback):
2721         (setCloseRemainingWindowsWhenCompleteCallback):
2722         (testRepaintCallback):
2723         (addFileToPasteboardOnDragCallback):
2724         (addDisallowedURLCallback):
2725         (clearBackForwardListCallback):
2726         (decodeHostNameCallback):
2727         (displayCallback):
2728         (encodeHostNameCallback):
2729         (keepWebHistoryCallback):
2730         (notifyDoneCallback):
2731         (queueBackNavigationCallback):
2732         (queueForwardNavigationCallback):
2733         (queueLoadCallback):
2734         (queueReloadCallback):
2735         (queueScriptCallback):
2736         (setAcceptsEditingCallback):
2737         (setCustomPolicyDelegateCallback):
2738         (setMainFrameIsFirstResponderCallback):
2739         (setTabKeyCyclesThroughElementsCallback):
2740         (setUseDashboardCompatibilityModeCallback):
2741         (setUserStyleSheetEnabledCallback):
2742         (setUserStyleSheetLocationCallback):
2743         (setWindowIsKeyCallback):
2744         (waitUntilDoneCallback):
2745         (windowCountCallback):
2746         (LayoutTestController::makeWindowObject):
2747         (LayoutTestController::getLayoutTestControllerJSClass):
2748         (LayoutTestController::staticFunctions):
2749         * DumpRenderTree/LayoutTestController.h: Replaced.
2750         * DumpRenderTree/LayoutTestController.m: Removed.
2751         * DumpRenderTree/LayoutTestControllerMac.mm: Added.
2752         (LayoutTestController::dumpAsText):
2753         (LayoutTestController::dumpBackForwardList):
2754         (LayoutTestController::dumpChildFramesAsText):
2755         (LayoutTestController::dumpChildFrameScrollPositions):
2756         (LayoutTestController::dumpDOMAsWebArchive):
2757         (LayoutTestController::dumpEditingCallbacks):
2758         (LayoutTestController::dumpFrameLoadCallbacks):
2759         (LayoutTestController::dumpResourceLoadCallbacks):
2760         (LayoutTestController::dumpSelectionRect):
2761         (LayoutTestController::dumpSourceAsWebArchive):
2762         (LayoutTestController::dumpTitleChanges):
2763         (LayoutTestController::repaintSweepHorizontally):
2764         (LayoutTestController::setCallCloseOnWebViews):
2765         (LayoutTestController::setCanOpenWindows):
2766         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2767         (LayoutTestController::testRepaint):
2768         (LayoutTestController::addFileToPasteboardOnDrag):
2769         (LayoutTestController::addDisallowedURL):
2770         (LayoutTestController::clearBackForwardList):
2771         (LayoutTestController::decodeHostName):
2772         (LayoutTestController::encodeHostName):
2773         (LayoutTestController::display):
2774         (LayoutTestController::keepWebHistory):
2775         (LayoutTestController::notifyDone):
2776         (LayoutTestController::queueBackNavigation):
2777         (LayoutTestController::queueForwardNavigation):
2778         (LayoutTestController::queueLoad):
2779         (LayoutTestController::queueReload):
2780         (LayoutTestController::queueScript):
2781         (LayoutTestController::setAcceptsEditing):
2782         (LayoutTestController::setCustomPolicyDelegate):
2783         (LayoutTestController::setMainFrameIsFirstResponder):
2784         (LayoutTestController::setTabKeyCyclesThroughElements):
2785         (LayoutTestController::setUseDashboardCompatibilityMode):
2786         (LayoutTestController::setUserStyleSheetEnabled):
2787         (LayoutTestController::setUserStyleSheetLocation):
2788         (LayoutTestController::setWindowIsKey):
2789         (+[WaitToDumpWatchdog waitUntilDoneWatchdogFired]):
2790         (LayoutTestController::waitUntilDone):
2791         (LayoutTestController::windowCount):
2792         Use the JSCore API to implement the LayoutTestController.
2793
2794         * DumpRenderTree/ObjCController.h:
2795         * DumpRenderTree/ObjCController.m:
2796         (+[ObjCController isSelectorExcludedFromWebScript:]):
2797         (+[ObjCController webScriptNameForSelector:]):
2798         (-[ObjCController accessStoredWebScriptObject]):
2799         (-[ObjCController storeWebScriptObject:]):
2800         (-[ObjCController dealloc]):
2801         (-[ObjCController invokeUndefinedMethodFromWebScript:withArguments:]):
2802         Move WebScriptObject tests to ObjCController.
2803
2804         * DumpRenderTree/UIDelegate.m: Removed.
2805         * DumpRenderTree/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.m.
2806
2807         * DumpRenderTree/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2808         * DumpRenderTree/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2809         * DumpRenderTree/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2810         (WorkQueueItem::~WorkQueueItem):
2811         (LoadItem::LoadItem):
2812         (LoadItem::url):
2813         (LoadItem::target):
2814         (ScriptItem::ScriptItem):
2815         (ScriptItem::script):
2816         * DumpRenderTree/WorkQueueItemMac.mm: Added.
2817         (LoadItem::invoke):
2818         (ReloadItem::invoke):
2819         (ScriptItem::invoke):
2820         (BackForwardItem::invoke):
2821         Copy WorkQueue and WorkQueueItem from windows DRT. Changed the WorkQueueItem to use JSStringRefs instead of wstrings
2822         to avoid conversion until the last possible moment.  These changes will be merged with the windows DRT when we start
2823         sharing code.
2824
2825 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
2826
2827         Reviewed by Maciej.
2828
2829         - Updated Win side to take advantage of the platform separating changes.
2830
2831         * Drosera/DebuggerDocument.cpp:
2832         (DebuggerDocument::localScopeVariableNamesForCallFrame):
2833         * Drosera/DebuggerDocument.h:
2834         * Drosera/win/DebuggerClient.cpp:
2835         (DebuggerClient::pause):
2836         (DebuggerClient::resume):
2837         (DebuggerClient::stepInto):
2838         (DebuggerDocument::platformPause):
2839         (DebuggerDocument::platformResume):
2840         (DebuggerDocument::platformStepInto):
2841         (DebuggerDocument::platformEvaluateScript):
2842         (DebuggerDocument::getPlatformCurrentFunctionStack):
2843         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2844         (DebuggerDocument::platformValueForScopeVariableNamed):
2845         (DebuggerDocument::platformLog):
2846         * Drosera/win/DebuggerClient.h:
2847         * Drosera/win/Drosera.cpp:
2848         (Drosera::Drosera):
2849         (Drosera::windowScriptObjectAvailable):
2850         (Drosera::initWithServerName):
2851         (Drosera::switchToServerNamed):
2852         * Drosera/win/Drosera.h:
2853         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2854
2855 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
2856
2857         Reviewed by Adam.
2858
2859         - Just doing the moves in a separate patch so the changes are easier to see.
2860
2861         * Drosera/win/DebuggerClient.cpp: Copied from Drosera/win/DebuggerDocumentWin.cpp.
2862         * Drosera/win/DebuggerClient.h: Copied from Drosera/win/DebuggerDocumentWin.h.
2863         * Drosera/win/DebuggerDocumentWin.cpp: Removed.
2864         * Drosera/win/DebuggerDocumentWin.h: Removed.
2865         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2866
2867 2007-09-11  Sven Herzberg  <sven@imendio.com>
2868
2869         Don't overwrite LD_LIBRARY_PATH, prepend to it. Fixes:
2870         http://bugs.webkit.org/show_bug.cgi?id=15176
2871
2872         * Scripts/run-launcher: don't replace LD_LIBRARY_PATH with
2873         $projectDir, but prepend $projectDir to LD_LIBRARY_PATH (to preserve
2874         other paths eg. from jhbuild)
2875
2876 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
2877
2878         Reviewed by Adam.
2879
2880         - Made an order-of-deletion mistake.
2881
2882         * Drosera/DebuggerDocument.h:
2883         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
2884         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
2885         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
2886         * Drosera/mac/DebuggerClient.mm:
2887         (DebuggerDocument::platformPause):
2888         (DebuggerDocument::platformResume):
2889         (DebuggerDocument::platformStepInto):
2890         (DebuggerDocument::platformEvaluateScript):
2891         (DebuggerDocument::getPlatformCurrentFunctionStack):
2892         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2893         (DebuggerDocument::platformValueForScopeVariableNamed):
2894         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2895
2896 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
2897
2898         Reviewed by Darin.
2899
2900         - Renaming DebuggerDocument[platform] to DebuggerClient to be more clear.
2901
2902         * Drosera/DebuggerDocument.cpp:
2903         (DebuggerDocument::DebuggerDocument):
2904         * Drosera/DebuggerDocument.h:
2905         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2906         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2907         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2908         * Drosera/mac/DebuggerApplication.mm:
2909         (-[DebuggerApplication attach:]):
2910         * Drosera/mac/DebuggerClient.h: Copied from Drosera/mac/DebuggerDocumentMac.h.
2911         * Drosera/mac/DebuggerClient.mm: Copied from Drosera/mac/DebuggerDocumentMac.mm.
2912         (DebuggerDocument::platformPause):
2913         (DebuggerDocument::platformResume):
2914         (DebuggerDocument::platformStepInto):
2915         (DebuggerDocument::platformEvaluateScript):
2916         (DebuggerDocument::getPlatformCurrentFunctionStack):
2917         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2918         (DebuggerDocument::platformValueForScopeVariableNamed):
2919         (DebuggerDocument::platformLog):
2920         * Drosera/mac/DebuggerDocumentMac.h: Removed.
2921         * Drosera/mac/DebuggerDocumentMac.mm: Removed.
2922         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2923
2924 2007-09-09  Sam Weinig  <sam@webkit.org>
2925
2926         Reviewed by Mark Rowe.
2927
2928         Remove 'objC' prefix from methods now in the ObjCController. 
2929
2930         * DumpRenderTree/ObjCController.m:
2931         (+[ObjCController isSelectorExcludedFromWebScript:]):
2932         (+[ObjCController webScriptNameForSelector:]):
2933         (-[ObjCController classNameOf:]):
2934         (-[ObjCController objectOfClass:]):
2935         (-[ObjCController identityIsEqual::]):
2936         (-[ObjCController longLongRoundTrip:]):
2937         (-[ObjCController unsignedLongLongRoundTrip:]):
2938
2939 2007-09-09  Sam Weinig  <sam@webkit.org>
2940
2941         Reviewed by Oliver.
2942
2943         Initial refactor of DumpRenderTree in preparation of making it more platform independent. 
2944         - Move LayoutTestController into its own file.
2945         - Move Objective-C only functions on LayoutTestController into a new controller called the
2946           ObjCController. 
2947
2948         * DumpRenderTree/DumpRenderTree.h:
2949         * DumpRenderTree/DumpRenderTree.m:
2950         (displayWebView):
2951         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2952         * DumpRenderTree/FrameLoadDelegate.m:
2953         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2954         * DumpRenderTree/LayoutTestController.h: Added.
2955         * DumpRenderTree/LayoutTestController.m: Added.
2956         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
2957         (+[LayoutTestController webScriptNameForSelector:]):
2958         (-[LayoutTestController clearBackForwardList]):
2959         (-[LayoutTestController setUseDashboardCompatibilityMode:]):
2960         (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]):
2961         (-[LayoutTestController setCustomPolicyDelegate:]):
2962         (-[LayoutTestController keepWebHistory]):
2963         (-[LayoutTestController setCallCloseOnWebViews:]):
2964         (-[LayoutTestController setCanOpenWindows]):
2965         (-[LayoutTestController waitUntilDone]):
2966         (-[LayoutTestController waitUntilDoneWatchdogFired]):
2967         (-[LayoutTestController notifyDone]):
2968         (-[LayoutTestController dumpAsText]):
2969         (-[LayoutTestController addFileToPasteboardOnDrag]):
2970         (-[LayoutTestController addDisallowedURL:]):
2971         (-[LayoutTestController setUserStyleSheetLocation:]):
2972         (-[LayoutTestController setUserStyleSheetEnabled:]):
2973         (-[LayoutTestController dumpDOMAsWebArchive]):
2974         (-[LayoutTestController dumpSourceAsWebArchive]):
2975         (-[LayoutTestController dumpSelectionRect]):
2976         (-[LayoutTestController dumpTitleChanges]):
2977         (-[LayoutTestController dumpBackForwardList]):
2978         (-[LayoutTestController windowCount]):
2979         (-[LayoutTestController dumpChildFrameScrollPositions]):
2980         (-[LayoutTestController dumpChildFramesAsText]):
2981         (-[LayoutTestController dumpEditingCallbacks]):
2982         (-[LayoutTestController dumpResourceLoadCallbacks]):
2983         (-[LayoutTestController dumpFrameLoadCallbacks]):
2984         (-[LayoutTestController setWindowIsKey:]):
2985         (-[LayoutTestController setMainFrameIsFirstResponder:]):
2986         (-[LayoutTestController display]):
2987         (-[LayoutTestController testRepaint]):
2988         (-[LayoutTestController repaintSweepHorizontally]):
2989         (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]):
2990         (-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]):
2991         (-[LayoutTestController _doLoad:target:]):
2992         (-[LayoutTestController _doBackOrForwardNavigation:]):
2993         (-[LayoutTestController queueBackNavigation:]):
2994         (-[LayoutTestController queueForwardNavigation:]):
2995         (-[LayoutTestController queueReload]):
2996         (-[LayoutTestController queueScript:]):
2997         (-[LayoutTestController queueLoad:target:]):
2998         (-[LayoutTestController setAcceptsEditing:]):
2999         (-[LayoutTestController setTabKeyCyclesThroughElements:]):
3000         (-[LayoutTestController storeWebScriptObject:]):
3001         (-[LayoutTestController accessStoredWebScriptObject]):
3002         (-[LayoutTestController dealloc]):
3003         (-[LayoutTestController decodeHostName:]):
3004         (-[LayoutTestController encodeHostName:]):
3005         * DumpRenderTree/ObjCController.h: Added.
3006         * DumpRenderTree/ObjCController.m: Added.
3007         (+[ObjCController isSelectorExcludedFromWebScript:]):
3008         (+[ObjCController webScriptNameForSelector:]):
3009         (-[ObjCController objCClassNameOf:]):
3010         (-[ObjCController objCObjectOfClass:]):
3011         (-[ObjCController objCIdentityIsEqual::]):
3012         (-[ObjCController objCLongLongRoundTrip:]):
3013         (-[ObjCController objCUnsignedLongLongRoundTrip:]):
3014         (-[ObjCController testWrapperRoundTripping:]):
3015
3016 2007-09-07  Sam Weinig  <sam@webkit.org>
3017
3018         Reviewed by Alice.
3019
3020         Strip trailing and leading space/newline characters from skiplist file names.
3021
3022         * Scripts/run-webkit-tests:
3023
3024 2007-09-06  Kevin McCullough  <kmccullough@apple.com>
3025
3026         Reviewed by Maciej.
3027
3028         - Changed Drosera to take advantage of the JSRetainPtr changes.
3029
3030         * Drosera/DebuggerDocument.cpp:
3031         (DebuggerDocument::breakpointEditorHTML):
3032         (DebuggerDocument::evaluateScript):
3033         (DebuggerDocument::valueForScopeVariableNamed):
3034         (DebuggerDocument::log):
3035         (DebuggerDocument::windowScriptObjectAvailable):
3036         (DebuggerDocument::toJSArray):
3037         (DebuggerDocument::callFunctionOnObject):
3038         (DebuggerDocument::logException):
3039         * Drosera/mac/DebuggerDocumentMac.mm:
3040         (-[DebuggerClientMac webView:didLoadMainResourceForDataSource:]):
3041         (-[DebuggerClientMac webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3042         (DebuggerDocument::platformEvaluateScript):
3043         (DebuggerDocument::getPlatformCurrentFunctionStack):
3044         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3045         (DebuggerDocument::platformValueForScopeVariableNamed):
3046
3047 2007-09-05  Kevin McCullough  <kmccullough@apple.com>
3048
3049         Reviewed by Adam, Sam, Darin.
3050
3051         - Separated what is platform dependant from what is not.  Creating the structure needed for Drosera for Win.
3052
3053         * Drosera/Debugger.h: Added.
3054         * Drosera/DebuggerDocument.cpp:
3055         (DebuggerDocument::breakpointEditorHTMLCallback):
3056         (DebuggerDocument::isPausedCallback):
3057         (DebuggerDocument::pauseCallback):
3058         (DebuggerDocument::resumeCallback):
3059         (DebuggerDocument::stepIntoCallback):
3060         (DebuggerDocument::evaluateScriptCallback):
3061         (DebuggerDocument::currentFunctionStackCallback):
3062         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3063         (DebuggerDocument::valueForScopeVariableNamedCallback):
3064         (DebuggerDocument::logCallback):
3065         (DebuggerDocument::breakpointEditorHTML):
3066         (DebuggerDocument::isPaused):
3067         (DebuggerDocument::pause):
3068         (DebuggerDocument::resume):
3069         (DebuggerDocument::stepInto):
3070         (DebuggerDocument::evaluateScript):
3071         (DebuggerDocument::currentFunctionStack):
3072         (DebuggerDocument::localScopeVariableNamesForCallFrame):
3073         (DebuggerDocument::valueForScopeVariableNamed):
3074         (DebuggerDocument::log):
3075         (DebuggerDocument::toolbarPause):
3076         (DebuggerDocument::toolbarResume):
3077         (DebuggerDocument::toolbarStepInto):
3078         (DebuggerDocument::toolbarStepOver):
3079         (DebuggerDocument::toolbarStepOut):
3080         (DebuggerDocument::toolbarShowConsole):
3081         (DebuggerDocument::toolbarCloseCurrentFile):
3082         (DebuggerDocument::updateFileSource):
3083         (DebuggerDocument::didParseScript):
3084         (DebuggerDocument::willExecuteStatement):
3085         (DebuggerDocument::didEnterCallFrame):
3086         (DebuggerDocument::willLeaveCallFrame):
3087         (DebuggerDocument::exceptionWasRaised):
3088         (DebuggerDocument::windowScriptObjectAvailable):
3089         (DebuggerDocument::toJSArray):
3090         (DebuggerDocument::callGlobalFunction):
3091         (DebuggerDocument::callFunctionOnObject):
3092         (DebuggerDocument::getDroseraJSClass):
3093         (DebuggerDocument::staticFunctions):
3094         (DebuggerDocument::logException):
3095         * Drosera/DebuggerDocument.h:
3096         (DebuggerDocument::DebuggerDocument):
3097         * Drosera/ForwardingHeaders: Added.
3098         * Drosera/ForwardingHeaders/wtf: Added.
3099         * Drosera/ForwardingHeaders/wtf/Platform.h: Added.
3100         * Drosera/config.h:
3101         * Drosera/console.html:
3102         * Drosera/console.js:
3103         * Drosera/debugger.js:
3104         * Drosera/mac/DebuggerApplication.mm:
3105         (-[DebuggerApplication attach:]):
3106         * Drosera/mac/DebuggerDocumentMac.h:
3107         * Drosera/mac/DebuggerDocumentMac.mm:
3108         (+[NSString stringOrNilFromWebScriptResult:]):
3109         (+[DebuggerClientMac log:]):
3110         (-[DebuggerClientMac initWithServerName:]):
3111         (-[DebuggerClientMac dealloc]):
3112         (-[DebuggerClientMac pause]):
3113         (-[DebuggerClientMac resume]):
3114         (-[DebuggerClientMac pause:]):
3115         (-[DebuggerClientMac resume:]):
3116         (-[DebuggerClientMac stepInto:]):
3117         (-[DebuggerClientMac stepOver:]):
3118         (-[DebuggerClientMac stepOut:]):
3119         (-[DebuggerClientMac showConsole:]):
3120         (-[DebuggerClientMac closeCurrentFile:]):
3121         (-[DebuggerClientMac validateUserInterfaceItem:]):
3122         (-[DebuggerClientMac webView:windowScriptObjectAvailable:]):
3123         (-[DebuggerClientMac webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3124         (-[DebuggerClientMac webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3125         (-[DebuggerClientMac webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3126         (-[DebuggerClientMac webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3127         (DebuggerDocument::platformPause):
3128         (DebuggerDocument::platformResume):
3129         (DebuggerDocument::platformStepInto):
3130         (DebuggerDocument::platformEvaluateScript):
3131         (DebuggerDocument::platformCurrentFunctionStack):
3132         (DebuggerDocument::platformLocalScopeVariableNamesForCallFrame):
3133         (DebuggerDocument::platformValueForScopeVariableNamed):
3134         (DebuggerDocument::platformLog):
3135         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3136
3137 2007-09-06  Sam Weinig  <sam@webkit.org>
3138
3139         Reviewed by Adam Roben.
3140
3141         Register the WebKit DLL on initialization of the DumpRenderTree.
3142
3143         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3144         (initialize):
3145
3146 2007-09-05  Sam Weinig  <sam@webkit.org>
3147
3148         Reviewed by Oliver.
3149
3150         Fix many layout test failures caused by r25364.
3151         Set text size to standand size at the begining of each test matching the mac.
3152
3153         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3154         (runTest):
3155
3156 2007-09-04  Sam Weinig  <sam@webkit.org>
3157
3158         Reviewed by Adam.
3159
3160         Fix for <rdar://problem/5382277>
3161         Implement eventSender.textZoomIn and eventSender.textZoomOut for windows DRT.
3162
3163         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp:
3164         (textZoomInCallback):
3165         (textZoomOutCallback):
3166
3167 2007-08-29  David Kilzer  <ddkilzer@apple.com>
3168
3169         Reviewed by Adam.
3170
3171         Added case-insensitivity to checks for adding regression tests.
3172
3173         * Scripts/prepare-ChangeLog:
3174         (generateFileList):
3175
3176 2007-08-28  David Kilzer  <ddkilzer@apple.com>
3177
3178         Reviewed by Maciej.
3179
3180         Ignore files in /resources/ subdirectories when creating a list of added tests.
3181
3182         * Scripts/prepare-ChangeLog:
3183         (generateFileList):
3184
3185 2007-08-27  Kevin McCullough  <kmccullough@apple.com>
3186
3187         Reviewed by John.
3188
3189         - Removed Leopard leaks list since all of those radars were fixed.
3190
3191         * Scripts/run-webkit-tests:
3192
3193 2007-08-27  Adam Roben  <aroben@apple.com>
3194
3195         Rubberstamped by Mark.
3196
3197         * Scripts/pdevenv: Pass arguments along to devenv.com.
3198
3199 2007-08-26  David Kilzer  <ddkilzer@webkit.org>
3200
3201         Reviewed by Mark Rowe.
3202
3203         Update prepare-ChangeLog to generate the datestamp in the correct timezone.
3204
3205         * Scripts/prepare-ChangeLog:
3206         (changeLogDate): Added.
3207
3208 2007-08-24  Sam Weinig  <sam@webkit.org>
3209
3210         Revert r25216 which renamed the COM DOM bindings to use Deprecated prefix.
3211
3212 2007-08-24  Sam Weinig  <sam@webkit.org>
3213
3214         Rubber-stamped by Adam Roben.
3215
3216         <rdar://problem/5434593> Deprecate current manually written COM DOM bindings in anticipation of autogeneration
3217
3218         Rename COM DOM bindings to use Deprecated prefix.
3219
3220         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3221         (dumpFramesAsText):
3222         (dump):
3223         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp:
3224         (dumpPath):
3225         (dump):
3226         (EditingDelegate::shouldBeginEditingInDOMRange):
3227         (EditingDelegate::shouldEndEditingInDOMRange):
3228         (EditingDelegate::shouldInsertNode):
3229         (EditingDelegate::shouldInsertText):
3230         (EditingDelegate::shouldDeleteDOMRange):
3231         (EditingDelegate::shouldChangeSelectedDOMRange):
3232         (EditingDelegate::shouldApplyStyle):
3233         (EditingDelegate::shouldChangeTypingStyle):
3234         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h:
3235
3236 2007-08-24  Oliver Hunt  <oliver@apple.com>
3237
3238         Reviewed by John H.
3239
3240         WebDataSource::response can legitimately have a null response, so we
3241         must check that case.
3242
3243         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
3244         (queueLoadCallback):
3245
3246 2007-08-23  Mitz Pettel  <mitz@webkit.org>
3247
3248         Reviewed by Darin and Adam.
3249
3250         - DumpRenderTree changes to allow testing for
3251           http://bugs.webkit.org/show_bug.cgi?id=11756
3252           REGRESSION: link targeting a frame in another window does not work
3253           <rdar://problem/5286420>
3254
3255         Use a frame group name for all WebViews created by DumpRenderTree to
3256         allow testing of cross-page frame lookup.
3257
3258         * DumpRenderTree/DumpRenderTree.m:
3259         (createWebView): Pass group name to -[WebView initWithFrame:frameName:groupName:].
3260         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3261         (main): Pass group name to WebView::initWithFrame(RECT, BSTR, BSTR).
3262
3263 2007-08-23  David Kilzer  <ddkilzer@webkit.org>
3264
3265         Reviewed by Adam.
3266
3267         Quote the $sslCertificate path in case it contains a space.
3268
3269         * Scripts/run-webkit-httpd:
3270         * Scripts/run-webkit-tests:
3271
3272 2007-08-22  Oliver Hunt  <oliver@apple.com>
3273
3274         Reviewed by John and Adam.
3275         
3276         WebDataSource::response can legitimately have a null response, so we
3277         must check that case.
3278
3279         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3280         (dump):
3281
3282 2007-08-21  Kevin McCullough  <kmccullough@apple.com>
3283
3284         Reviewed by Geof.
3285
3286         - Changing the usage to be more clear.
3287
3288         * Scripts/run-testkjs:
3289
3290 2007-08-20  John Sullivan  <sullivan@apple.com>
3291
3292         Reviewed by Adam Roben
3293
3294         * DumpRenderTree/DumpRenderTree.m:
3295         (runTest):
3296         call new +[WebView _setUsesTestModeFocusRingColor:YES] so we get the same focus ring colors
3297         in layout tests on Tiger and Leopard
3298
3299 2007-08-20  Adam Roben  <aroben@apple.com>
3300
3301         Put LayoutTests after all other ChangeLogs in commit logs
3302
3303         We use "~" to sort LayoutTests after all the other ChangeLogs because
3304         "~" is the last ASCII character (other than "DEL").
3305
3306         Reviewed by Sam.
3307
3308         * Scripts/commit-log-editor:
3309
3310 2007-08-20  Adam Roben  <aroben@apple.com>
3311
3312         Detect that DRT crashed even if a crash dialog is running
3313
3314         On Windows, when DRT crashes a crash dialog commonly appears. The DRT
3315         process is still running at this point, so run-webkit-tests wouldn't
3316         detect that DRT had crashed. We now record the crash in our SIGPIPE
3317         handler so that we know if DRT crashed even if the crash dialog is up.
3318
3319         Reviewed by Sam.
3320
3321         * Scripts/run-webkit-tests:
3322         (sub catch_pipe): Set the crashed bit.
3323         (sub openDumpTool): Reset the crashed bit.
3324         (sub dumpToolDidCrash): Check the crashed bit.
3325
3326 2007-08-20  Adam Roben  <aroben@apple.com>
3327
3328         Fix Bug 15026: prepare-ChangeLog should list new tests in WebCore/ChangeLog
3329
3330         http://bugs.webkit.org/show_bug.cgi?id=15026
3331
3332         Reviewed by David Kilzer and Darin Adler.
3333
3334         * Scripts/prepare-ChangeLog:
3335         (sub isModifiedStatus): Split out from isModifiedOrAddedStatus.
3336         (sub isAddedStatus): Ditto.
3337         (sub testListForChangeLog): Added.
3338
3339 2007-08-19  Oleg Sukhodolsky  <son.two@gmail.com>
3340
3341         Reviewed by Mark.
3342
3343         -fixes http://bugs.webkit.org/show_bug.cgi?id=14632
3344
3345         * Scripts/webkitdirs.pm:
3346         qt and gtk ports now explicitly pass debug (or release) mode to qmake.
3347
3348 2007-08-17  Darin Adler  <darin@apple.com>
3349
3350         Reviewed by Oliver Hunt.
3351
3352         - don't look for Apple-style localizable strings in the GTK version of WebKit
3353
3354         * Scripts/extract-localizable-strings: Add a feature where you can pass in the
3355         name of subdirectories to skip.
3356         * Scripts/update-webkit-localizable-strings: Pass WebKit/gtk as a subdirectory
3357         to skip.
3358
3359 2007-08-17  Anders Carlsson  <andersca@apple.com>
3360
3361         Build fix.
3362         
3363         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3364         (NPP_SetWindow):
3365
3366 2007-08-17  Anders Carlsson  <andersca@apple.com>
3367
3368         Reviewed by Dave Hyatt.
3369
3370         <rdar://problem/5379040>
3371         REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes
3372
3373         Add a way for the plug-in to dump the width and height when it gets its  NPP_SetWindow call.
3374         
3375         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
3376         (pluginAllocate):
3377         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3378         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3379         (NPP_New):
3380         (NPP_SetWindow):
3381
3382 2007-08-16  Alice Liu  <alice.liu@apple.com>
3383
3384         Reviewed by Maciej.
3385
3386         Fix <rdar://problem/5360135> REGRESSION (Leopard only): editing/selection/5354455-1.html is causing subsequent tests to fail
3387
3388         * DumpRenderTree/DumpRenderTree.m:
3389         (createWebView):
3390         Create a DumpRenderTreeWindow instead of a NSWindow, now that a DumpRenderTreeWindow no longer poses as a NSWindow.
3391         (dumpRenderTree):
3392         Don't pose as a NSWindow, since when the spelling panel gets created, it creates an NSWindow which ends up creating a DumpRenderTreeWindow. 
3393
3394 2007-08-16  Kevin McCullough  <kmccullough@apple.com>
3395
3396         Reviewed by Adam.
3397
3398         - Added tests for regressions in other components.  In this case we also need to add a skipped list for Tiger since this functionality didn't exist in 10.4.
3399
3400         * Scripts/run-webkit-tests:
3401
3402 2007-08-15  Timothy Hatcher  <timothy@apple.com>
3403
3404         Look for the new Xcode 3 preference key (PBXApplicationwideBuildSettings) for the global build locations.
3405         The value of PBXApplicationwideBuildSettings is a dictionary, so we have to pull the SYMROOT out of it.
3406
3407         Also pass xcodebuild OBJROOT with the same value as SYMROOT if we fallback to the default WebKitBuild,
3408         this prevents making "build" directories in each project folder.
3409
3410         * Scripts/webkitdirs.pm:
3411
3412 2007-08-14  Geoffrey Garen  <ggaren@apple.com>
3413
3414         Reviewed by Kevin Mccullough.
3415         
3416         Removed special case that didn't belong. (It would allow a global 
3417         initializer to sneak into production builds, which would cause a 
3418         system-wide performance regression on Mac OS X.)
3419
3420         * Scripts/check-for-global-initializers:
3421
3422 2007-08-14  Justin Garcia  <justin.garcia@apple.com>
3423
3424         Reviewed by Tim.
3425         
3426         <rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element
3427
3428         * DumpRenderTree/EditingDelegate.m:
3429         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Added, return YES
3430         only for elements with the class needsDeletionUI.
3431
3432 2007-08-14  David Kilzer  <ddkilzer@webkit.org>
3433
3434         Reviewed by Darin.
3435
3436         - fix http://bugs.webkit.org/show_bug.cgi?id=14965
3437           svn-create-patch uses deprecated tail switch
3438
3439         * Scripts/svn-create-patch: Use 'tail -n +3' instead of 'tail +3'.
3440
3441 2007-08-13  Sam Weinig  <sam@webkit.org>
3442
3443         Reviewed by Adam Roben.
3444
3445         Use the cygwin specific Apache config file under cygwin.
3446
3447         * Scripts/run-webkit-httpd:
3448
3449 2007-08-12  Adam Roben  <aroben@apple.com>
3450
3451         Generate results for new tests in a more logical location
3452
3453         New platform-specific tests always have their results generated right
3454         next to the test. New cross-platform tests will have their results
3455         generated a) in the cross-platform directory, if they are text-only,
3456         or b) in the least-specific platform directory, if they are render
3457         tree dumps.
3458
3459         Reviewed by Lars.
3460
3461         * Scripts/run-webkit-tests:
3462
3463 2007-08-12  Adam Roben  <aroben@apple.com>
3464
3465         Print the actual directory where new results are generated.
3466
3467         Before, we were printing an unpredictable, context-specific substring
3468         of the directory.
3469
3470         Reviewed by Lars.
3471
3472         * Scripts/run-webkit-tests:
3473
3474 2007-08-12  Adam Roben  <aroben@apple.com>
3475
3476         Factor some common code into a stripExtension() subroutine.
3477
3478         Reviewed by Lars.
3479
3480         * Scripts/run-webkit-tests: Also removed some debugging output.
3481
3482 2007-08-11  Matt Lilek  <pewtermoose@gmail.com>
3483
3484         Reviewed over and over and over by Adam Roben.
3485
3486         Bug 14740: Hierarchical layout tests and platform organization
3487         http://bugs.webkit.org/show_bug.cgi?id=14740
3488
3489         Add support for platform-specific layout tests and results.
3490
3491         * Scripts/run-webkit-tests:
3492
3493 2007-08-11  David Kilzer  <ddkilzer@webkit.org>
3494
3495         Reviewed by Adam.
3496
3497         Refactored svn-create-path to use a hash-of-hashes data structure to keep
3498         track of changed files.  In the top level hash, keys are paths to files and
3499         values are 'fileData' hashes with the following keys and values:
3500
3501         - isBinary: boolean value (set to true for non-text files like images, etc.)
3502         - isTestFile: boolean value (set to true if file exists within a known test
3503           directory)
3504         - modificationType: string equal to one of 'addition', 'additionWithHistory',
3505           'modification' or 'deletion'
3506         - path: string equal to the path to the file (this may seem redundant, but it
3507           is required to use the second-level 'fileData' hash independent of the
3508           top-level hash)
3509         - sourceFile: [optional] string equal to the path of the original file that was
3510           copied or moved
3511         - sourceRevision: [optional] string equal to the revision of the original file
3512           that was copied or moved
3513
3514         * Scripts/svn-create-patch: Moved call to GetOptions() to its own statement
3515         that saves the return value in $result, then checks it before printing help.
3516         Combined sourceFiles, %testFiles, and %binaryFiles into single %diffFiles hash
3517         and eliminated two for() loops.
3518         (binarycmp): Added.  Used with sort() to order non-binary files before binary
3519         files.
3520         (findBaseUrl): Added.  Extracted from findSourceFileAndRevision().
3521         (findMimeType): Added optional second argument that takes a revision number.
3522         (generateDiff): Updated to take one fileData argument instead of three ($file,
3523         $modificationType, $isBinary).
3524         (generateFileList): Updated to take one hash ref argument (%diffFiles)
3525         instead of three (%sourceFiles, %testFiles, %binaryFiles).  Populates
3526         %diffFiles using paths for keys and fileData hashes for values.
3527         (manufacturePatchForAdditionWithHistory): Updated to take one fileData
3528         argument.
3529         (pathcmp): Updated to take two fileData arguments instead of two strings.
3530         (testfilecmp): Added.  Used with sort() to order non-test files before test
3531         files.
3532
3533 2007-08-11  Darin Adler  <darin@apple.com>
3534
3535         * Scripts/run-webkit-tests: Give a different message when only the pixel test failed.
3536
3537 2007-08-06  Nigel Tao  <nigeltao@gnome.org>
3538
3539         Reviewed by David Kilzer.
3540
3541         Fix bug 14745: WebKitTools/Scripts/run-launcher doesn't speak --gdk
3542         http://bugs.webkit.org/show_bug.cgi?id=14745
3543
3544         * Scripts/run-launcher: