2010-06-18 Leandro Pereira <leandro@profusion.mobi>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-06-18  Leandro Pereira  <leandro@profusion.mobi>
2
3         Unreviewed.
4
5         Adding myself to the committers list.
6
7         * Scripts/webkitpy/common/config/committers.py:
8
9 2010-06-17  Tony Chang  <tony@chromium.org>
10
11         Reviewed by Kent Tamura.
12
13         [chromium] cleanup redundant DEPS value and remove buildbot cleanup code
14         https://bugs.webkit.org/show_bug.cgi?id=40615
15
16         * Scripts/update-webkit-chromium: remove directory removal of third_party in old checkouts
17
18 2010-06-17  Ada Chan  <adachan@apple.com>
19
20         Rolling out http://trac.webkit.org/changeset/61297 due to build errors.
21
22         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
23         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Copied from MiniBrowser/mac/WebBundle/WebBundleMain.c.
24         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
25
26 2010-06-17  Darin Adler  <darin@apple.com>
27
28         One more try at fix for Chromium build.
29
30         * DumpRenderTree/chromium/TestShell.cpp:
31         (TestShell::TestShell): Use set again instead of =.
32
33 2010-06-17  Darin Adler  <darin@apple.com>
34
35         Fix Chromium build.
36
37         I didn't realize that neither Chromium nor Qt share the DumpRenderTree
38         code with all the other platforms! Wow, that should be fixed at some point.
39
40         * DumpRenderTree/chromium/TestShell.cpp:
41         (TestShell::TestShell): Changed back to using "new".
42         * DumpRenderTree/chromium/TestShell.h: Changed back to OwnPtr.
43
44 2010-06-17  Simon Hausmann  <simon.hausmann@nokia.com>
45
46         Unreviewed Qt build fix.
47
48         LayoutTestController in the Qt DRT is not using refs :)
49
50         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
51         (WebCore::DumpRenderTree::DumpRenderTree):
52
53 2010-06-17  Darin Adler  <darin@apple.com>
54
55         Reviewed by Sam Weinig.
56
57         Use adoptRef and create functions in more code paths
58         https://bugs.webkit.org/show_bug.cgi?id=40760
59
60         * DumpRenderTree/DumpRenderTree.h: Change gLayoutTestController to a RefPtr.
61
62         * DumpRenderTree/LayoutTestController.cpp:
63         (LayoutTestController::create): Added.
64         * DumpRenderTree/LayoutTestController.h: Declare the create function.
65
66         * DumpRenderTree/chromium/TestShell.cpp:
67         (TestShell::TestShell): Use create instead of new.
68         * DumpRenderTree/chromium/TestShell.h: Use RefPtr instead of OwnPtr.
69
70         * DumpRenderTree/gtk/DumpRenderTree.cpp:
71         (runTest): Use RefPtr and create instead of OwnPtr and new.
72
73         * DumpRenderTree/mac/DumpRenderTree.mm:
74         (runTest): Use RefPtr and create instead of OwnPtr and new.
75
76         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
77         (WebCore::DumpRenderTree::DumpRenderTree): Use create and releaseRef
78         instead of new.
79
80         * DumpRenderTree/win/DumpRenderTree.cpp:
81         (runTest): Use RefPtr and create instead of OwnPtr and new.
82
83         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
84         (runTest): Use RefPtr and create instead of OwnPtr and new.
85         (MyApp::OnInit): Removed unneeded code to delete the layout
86         test controller. This is done during each test.
87
88 2010-06-17  Kent Tamura  <tkent@chromium.org>
89
90         Reviewed by Shinichiro Hamaji.
91
92         [DRT/Chromium] Fix a bug of Windows pixel tests
93         https://bugs.webkit.org/show_bug.cgi?id=40763
94
95         * DumpRenderTree/chromium/TestEventPrinter.cpp:
96         (TestShellPrinter::handleImage):
97
98 2010-06-16  Kent Tamura  <tkent@chromium.org>
99
100         Reviewed by Shinichiro Hamaji.
101
102         [DRT/Chromium] Fix crash on Mac Release
103         https://bugs.webkit.org/show_bug.cgi?id=40759
104
105         * DumpRenderTree/chromium/WebViewHost.cpp:
106         (WebViewHost::paintRect): We should not use m_canvas directly because
107           it is created lazily in canvas().
108
109 2010-06-16  Kevin Ollivier  <kevino@theolliviers.com>
110
111         [wx] Build fix after new method addition.
112
113         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
114         (LayoutTestController::pageProperty):
115
116 2010-06-16  Kent Tamura  <tkent@chromium.org>
117
118         Reviewed by Dimitri Glazkov.
119
120         [DRT/Chromium] Set current working directory for each of tests
121         https://bugs.webkit.org/show_bug.cgi?id=40668
122
123         This change fixes tests with eventSender.beginDragWithFiles().
124
125         * DumpRenderTree/chromium/DumpRenderTree.cpp:
126         (runTest):
127
128 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
129
130         Reviewed by Gustavo Noronha Silva.
131
132         [GTK] r60803 broke media/controls-drag-timebar.html
133         https://bugs.webkit.org/show_bug.cgi?id=40269
134
135         Only queue events while the mouse button is down, if drag mode is enabled. Some
136         tests may disable drag mode, to prevent the queuing of events in this situation.
137
138         * DumpRenderTree/gtk/EventSender.cpp:
139         (sendOrQueueEvent): Only queue events here if dragMode is true.
140
141 2010-06-16  Martin Robinson  <mrobinson@igalia.com>
142
143         Reviewed by Gustavo Noronha Silva.
144
145         [GTK] Remove the abuse of GDK_CURRENT_TIME in the DRT
146         https://bugs.webkit.org/show_bug.cgi?id=40600
147
148         * DumpRenderTree/gtk/EventSender.cpp:
149         (prepareMouseButtonEvent): Remove logic adding an offset to GDK_CURRENT_TIME.
150
151 2010-06-16  Adam Barth  <abarth@webkit.org>
152
153         Reviewed by Dimitri Glazkov.
154
155         Add a hidden land-cowboy command to webkit-patch to help land quick
156         build fixes.
157
158         * Scripts/webkitpy/tool/commands/download.py:
159         * Scripts/webkitpy/tool/steps/preparechangelog.py:
160
161 2010-06-16  Adam Roben  <aroben@apple.com>
162
163         Convert console messages to UTF-8 before printing them
164
165         Speculative fix for <http://webkit.org/b/40731> REGRESSION (r61234):
166         http/tests/security/xssAuditor/embed-tag-null-char.html and
167         http/tests/security/xssAuditor/object-embed-tag-null-char.html fail on
168         Windows. (I can't test the fix because Apache is crashing on my
169         computer.)
170
171         Reviewed by Alexey Proskuryakov.
172
173         * DumpRenderTree/win/DumpRenderTree.cpp:
174         (toUTF8): Extracted the code into an overload that takes a wide string
175         and a length, then added an overload that takes a wstring.
176
177         * DumpRenderTree/win/DumpRenderTreeWin.h: Declare the new toUTF8
178         overload.
179
180         * DumpRenderTree/win/UIDelegate.cpp:
181         (UIDelegate::webViewAddMessageToConsole): Use toUTF8 to convert to
182         UTF-8 instead of letting printf convert to the current code page.
183
184 2010-06-16  Drew Wilson  <atwilson@chromium.org>
185
186         Reviewed by Kent Tamura.
187
188         [Chromium] Plumbing for top-level frame names
189         https://bugs.webkit.org/show_bug.cgi?id=40430
190
191         * DumpRenderTree/chromium/WebViewHost.cpp:
192         (WebViewHost::createView):
193         Migrate to new createView() API.
194         * DumpRenderTree/chromium/WebViewHost.h:
195         Remove obsolete createView() methods, add new createView() API that takes a frameName parameter.
196
197 2010-06-16  Diego Gonzalez  <diegohcg@webkit.org>
198
199         Reviewed by Kenneth Rohde Christiansen.
200
201         [Qt] Scroll wheel event support to graphics based DRT
202         https://bugs.webkit.org/show_bug.cgi?id=40577
203
204         * DumpRenderTree/qt/EventSenderQt.cpp:
205         (EventSender::continuousMouseScrollBy):
206         (EventSender::createGraphicsSceneWheelEvent):
207         * DumpRenderTree/qt/EventSenderQt.h:
208
209 2010-06-16  Adam Roben  <aroben@apple.com>
210
211         Remove a stray newline from the Windows version of TestNetscapePlugin
212
213         Reviewed by Alexey Proskuryakov.
214
215         Fixes <http://webkit.org/b/40728>
216         plugins/geturlnotify-during-document-teardown.html fails on Windows
217
218         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
219         (NPP_Destroy): Removed extra newline that the Mac version doesn't
220         have.
221
222 2010-06-16  Adam Roben  <aroben@apple.com>
223
224         Respect LayoutTestController::isPrinting on Windows
225
226         This gets some printing tests closer to passing (like
227         printing/page-rule-in-media-query.html).
228
229         Fixes <http://webkit.org/b/40727>.
230
231         Reviewed by Dan Bernstein.
232
233         * DumpRenderTree/win/DumpRenderTree.cpp:
234         (dump): Pass LayoutTestController::isPrinting to
235         IWebFramePrivate::renderTreeAsExternalRepresentation.
236
237 2010-06-15  Adam Barth  <abarth@webkit.org>
238
239         Reviewed by Eric Seidel.
240
241         Enable HTML5 lexer
242         https://bugs.webkit.org/show_bug.cgi?id=40650
243
244         * DumpRenderTree/mac/DumpRenderTree.mm:
245         (initializeGlobalsFromCommandLineOptions):
246
247 2010-06-10  Yuzo Fujishima  <yuzo@google.com>
248
249         Reviewed by Shinichiro Hamaji.
250
251         Implement render style selection for pages to support CSS3 Paged Media.
252         https://bugs.webkit.org/show_bug.cgi?id=35961
253
254         * DumpRenderTree/LayoutTestController.cpp:
255         (parsePagePropertyParameters):
256         (pagePropertyCallback):
257         (LayoutTestController::staticFunctions):
258         * DumpRenderTree/LayoutTestController.h:
259         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
260         (LayoutTestController::pageProperty):
261         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
262         (LayoutTestController::pageProperty):
263         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
264         (LayoutTestController::pageProperty):
265
266 2010-06-15  Sam Weinig  <sam@webkit.org>
267
268         Reviewed by Anders Carlsson.
269
270         Fix for https://bugs.webkit.org/show_bug.cgi?id=40630
271         WebKit2: Add mechanism to inject code into the WebProcess on startup
272
273         Add initial InjectedBundle support.
274
275         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
276         * MiniBrowser/WebBundle-Info.plist: Added.
277         Add test InjectedBundle to the project.
278
279         * MiniBrowser/mac/AppDelegate.m:
280         (-[BrowserAppDelegate init]):
281         Get the path to the WebBundle from the the main bundle and pass it to the new
282         WKContextCreateWithInjectedBundlePath function.
283
284         * MiniBrowser/mac/BrowserWindowController.m:
285         (_didChangeProgress):
286         Fix the build.  This has been broken for a while.
287
288         * MiniBrowser/mac/WebBundle: Added.
289         * MiniBrowser/mac/WebBundle/WebBundleMain.c: Added.
290         (_didCreatePage):
291         (WKBundleInitialize):
292         Add really basic InjectedBundle.
293
294         * MiniBrowser/win/BrowserView.cpp:
295         (BrowserView::create):
296         Switch from WKContextCreateWithProcessModel to WKContextCreate and remove commented out code.
297
298 2010-06-15  Dumitru Daniliuc  <dumi@chromium.org>
299
300         Reviewed by Darin Adler.
301
302         Adding myself to the reviewers list.
303         https://bugs.webkit.org/show_bug.cgi?id=40693
304
305         * Scripts/webkitpy/common/config/committers.py:
306
307 2010-06-15  Martin Robinson  <mrobinson@igalia.com>
308
309         Reviewed by Xan Lopez.
310
311         Switch to using GIO methods instead of realpath in GtkLauncher to determine
312         the file URI. This should remove warnings about realpath being undefined
313         when compiling with '-ansi'.
314
315         * GtkLauncher/main.c:
316         (filenameToURL): Use GIO instead of realpath to determine file URI.
317
318 2010-06-15  Adam Roben  <aroben@apple.com>
319
320         Remove the redundant set-apple-windows-environment-variables script
321
322         Apparently update-webkit does this for you these days.
323
324         Rubber-stamped by Steve Falkenburg.
325
326         * Scripts/set-apple-windows-environment-variables: Removed.
327
328 2010-06-14  Adam Roben  <aroben@apple.com>
329
330         Add a script to set the WebKitOutputDir and WebKitLibrariesDir
331         environment variables
332
333         Fixes <http://webkit.org/b/40595>.
334
335         Reviewed by Steve Falkenburg.
336
337         * Scripts/set-apple-windows-environment-variables: Added.
338         (to_windows_path): Passes the passed-in path through cygpath to
339         generate a Windows-style path.
340         (main): Sets the WebKitOutputDir and WebKitLibrariesDir environment
341         variables to their defaults, if they aren't already set.
342
343 2010-06-14  Adam Roben  <aroben@apple.com>
344
345         Speed up run-safari/debug-safari on Windows
346
347         Fixes <http://webkit.org/b/40586>.
348
349         Reviewed by Steve Falkenburg.
350
351         * Scripts/webkitdirs.pm:
352         (runSafari): When debugging, set up the environment to run Safari
353         using the built WebKit.dll, then use "devenv /debugexe Safari.exe" to
354         actually launch the debugger. When not debugging, just run WebKit.exe
355         and it will do the rest for us.
356
357 2010-06-15  Diego Gonzalez  <diegohcg@webkit.org>
358
359         Reviewed by Kenneth Rohde Christiansen.
360
361         [Qt] DRT EventSender support to graphics context events
362         https://bugs.webkit.org/show_bug.cgi?id=40324
363
364         * DumpRenderTree/qt/EventSenderQt.cpp:
365         (EventSender::contextClick):
366
367 2010-06-14  Tony Chang  <tony@chromium.org>
368
369         Reviewed by Darin Fisher.
370
371         [chromium] checkout chromium third_party directly
372         https://bugs.webkit.org/show_bug.cgi?id=40556
373
374         * Scripts/update-webkit-chromium: some migration code for the bots
375
376 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
377
378         Chromium build fix.
379
380         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown): Chromium uses differently
381         named constants for Windows virtual key codes, replacing VK_DELETE with VKEY_DELETE.
382
383 2010-06-14  Alexey Proskuryakov  <ap@apple.com>
384
385         Reviewed by Darin Adler.
386
387         https://bugs.webkit.org/show_bug.cgi?id=40529
388         eventSender.keyDown("delete") incorrectly sends a backspace on some platforms
389
390         * DumpRenderTree/mac/EventSendingController.mm:
391         (-[EventSendingController keyDown:withModifiers:withLocation:]): We were sending a broken
392         event for "delete" - it had virtual key code from forward delete, and text from backspace.
393         Fixed "delete" to mean forward delete.
394
395         * DumpRenderTree/chromium/EventSender.cpp: (EventSender::keyDown):
396         * DumpRenderTree/gtk/EventSender.cpp: (keyDownCallback):
397         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
398         Mac DRT confusion has propagated to other platforms, fixing those.
399
400 2010-06-14  Martin Robinson  <mrobinson@igalia.com>
401
402         Reviewed by Xan Lopez.
403
404         Small GtkLauncher build fix for some systems.
405
406         * GtkLauncher/main.c: Add <limit.h> include.
407
408 2010-06-14  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
409
410         Reviewed by Laszlo Gombos.
411
412         [Qt] navigator.geolocation support for Qt port
413         https://bugs.webkit.org/show_bug.cgi?id=39724
414
415         Implementation for geolocation cases to DumpRenderTreeQt
416
417         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
418         (WebCore::WebPage::allowGeolocationRequest):
419         * DumpRenderTree/qt/DumpRenderTreeQt.h:
420         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
421         (LayoutTestController::setGeolocationPermission):
422         (LayoutTestController::setMockGeolocationError):
423         (LayoutTestController::setMockGeolocationPosition):
424         * DumpRenderTree/qt/LayoutTestControllerQt.h:
425         (LayoutTestController::isGeolocationPermissionSet):
426         (LayoutTestController::geolocationPermission):
427
428 2010-06-13  Nathan Lawrence  <nlawrence@apple.com>
429
430         Reviewed by Darin Adler.
431
432         Outside of Xcode (make or WebKitTools/Scripts), there doesn't seem to
433         be a way of overwriting the Xcode system path.  Making
434         $WEBKITOUTPUTDIR take precedence over the system default would make
435         this possible.
436
437         * Scripts/webkitdirs.pm:
438
439 2010-06-13  Chris Fleizach  <cfleizach@apple.com>
440
441         Reviewed by Darin Adler.
442
443         AX: link won't return linked element if URL contains #
444         https://bugs.webkit.org/show_bug.cgi?id=40192
445
446         * DumpRenderTree/AccessibilityUIElement.cpp:
447         (linkedUIElementAtIndexCallback):
448         (AccessibilityUIElement::getJSClass):
449         * DumpRenderTree/AccessibilityUIElement.h:
450         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
451         (AccessibilityUIElement::linkedUIElementAtIndex):
452         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
453         (AccessibilityUIElement::linkedUIElementAtIndex):
454         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
455         (AccessibilityUIElement::linkedUIElementAtIndex):
456
457 2010-06-13  Adam Barth  <abarth@webkit.org>
458
459         Reviewed by Darin Adler.
460
461         webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
462         https://bugs.webkit.org/show_bug.cgi?id=39550
463
464         This can cause an extra request to bugs.webkit.org durig upload, but it
465         shouldn't be too bad.  Also, this won't work if you remove the
466         boilerplate created by prepare-ChangeLog.
467
468         * Scripts/webkitpy/common/checkout/changelog.py:
469         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
470         * Scripts/webkitpy/common/net/bugzilla.py:
471         * Scripts/webkitpy/tool/steps/abstractstep.py:
472         * Scripts/webkitpy/tool/steps/preparechangelog.py:
473         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.
474
475 2010-06-08  Robert Hogan  <robert@webkit.org>
476
477         Reviewed by Eric Seidel.
478
479         [Qt] Add support for callShouldCloseOnWebView() to DRT
480         https://bugs.webkit.org/show_bug.cgi?id=40330
481
482         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
483         (LayoutTestController::callShouldCloseOnWebView):
484         * DumpRenderTree/qt/LayoutTestControllerQt.h:
485         (LayoutTestController::setCallCloseOnWebViews):
486
487 2010-06-12  Eric Seidel  <eric@webkit.org>
488
489         Reviewed by Daniel Bates.
490
491         do-webcore-rename should have a --verbose option
492         https://bugs.webkit.org/show_bug.cgi?id=40497
493
494         * Scripts/do-webcore-rename:
495          - Unified how we handle skipping files/directories
496            this will allow us to "black list" certain files and
497            directories when performing renames.
498          - Made do-webcore-rename log what it's skipping when passed --verbose.
499
500 2010-06-12  Darin Adler  <darin@apple.com>
501
502         * Scripts/run-bindings-tests: Fixed a typo in a message.
503
504 2010-06-12  Kent Tamura  <tkent@chromium.org>
505
506         Reviewed by Dimitri Glazkov.
507
508         [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
509         https://bugs.webkit.org/show_bug.cgi?id=40402
510
511         _build_path() of each Chromium port check existence of build path
512         of Chromium checkout first, then check existence of build path of
513         WebKit-only checkout.
514
515         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
516         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
517         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
518
519 2010-06-12  Robert Hogan  <robert@webkit.org>
520
521         Reviewed by Kenneth Rohde Christiansen.
522
523         [Qt] Back-forward list dumping is incorrect
524
525         https://bugs.webkit.org/show_bug.cgi?id=36392
526
527         Support dumping child history items in DRT.
528
529         Unskip:
530
531         fast/loader/frame-src-change-added-to-history.html
532         fast/loader/frame-src-change-not-added-to-history.html
533         fast/loader/frame-location-change-not-added-to-history.html
534
535         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
536         (WebCore::dumpHistoryItem):
537
538 2010-06-10  Ojan Vafai  <ojan@chromium.org>
539
540         Reviewed by Eric Seidel.
541
542         upload all patches that lack in-rietveld to rietveld
543         https://bugs.webkit.org/show_bug.cgi?id=40444
544
545         If it's a patch, then we'll try to upload it as long as it
546         doesn't have in-rietveld set. No longer set in-rietveld? since
547         it's not needed.
548
549         * Scripts/webkitpy/common/net/bugzilla.py:
550
551 2010-06-10  Ojan Vafai  <ojan@chromium.org>
552
553         Reviewed by Darin Fisher.
554
555         Fix rietveld upload when message length > 100 characters
556         https://bugs.webkit.org/show_bug.cgi?id=40457
557
558         * Scripts/webkitpy/common/net/rietveld.py:
559
560 2010-06-11  Yael Aharon  <yael.aharon@nokia.com>
561
562         Reviewed by Laszlo Gombos.
563
564         [Qt] There should be a way to enable popups in QtTestBrowser
565         https://bugs.webkit.org/show_bug.cgi?id=40427
566
567         * QtTestBrowser/main.cpp:
568         (LauncherWindow::toggleJavascriptCanOpenWindows):
569         (LauncherWindow::createChrome):
570
571 2010-06-10  Adam Barth  <abarth@webkit.org>
572
573         Reviewed by Daniel Bates.
574
575         Make SheriffBot more chatty
576         https://bugs.webkit.org/show_bug.cgi?id=40463
577
578         People seem to like to talk to SheriffBot, so let's make him chat back.
579
580         * Scripts/webkitpy/thirdparty/__init__.py:
581         * Scripts/webkitpy/tool/bot/irc_command.py:
582         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
583         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
584         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
585
586 2010-06-10  Brian Weinstein  <bweinstein@apple.com>
587
588         Reviewed by Darin Adler.
589
590         Fix the Windows buildbot when WebKitAuxiliaryLibs.zip cannot be found on our server.
591         
592         Robustify update-webkit-auxiliary-libs to be able to handle the case when WebKitAuxiliaryLibs.zip doesn't exist,
593         and allow the script to fall back to an existing file, only failing if there is no fallback file. Also switch to checking
594         WEXITSTATUS on $result instead of just comparing $result to 0.
595
596         * Scripts/update-webkit-auxiliary-libs:
597
598 2010-06-10  Ojan Vafai  <ojan@chromium.org>
599
600         Reviewed by Alexey Proskuryakov.
601
602         don't use Exception.message as it's deprecated in python 2.6+
603         https://bugs.webkit.org/show_bug.cgi?id=40449
604
605         * Scripts/webkitpy/tool/commands/queues.py:
606
607 2010-06-10  Ojan Vafai  <ojan@chromium.org>
608
609         Reviewed by Adam Barth.
610
611         fix handle_script_error in rietveld upload queue and add testing for handle_script_error
612         https://bugs.webkit.org/show_bug.cgi?id=40436
613
614         * Scripts/webkitpy/common/system/outputcapture.py:
615         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
616         * Scripts/webkitpy/tool/commands/queues.py:
617         * Scripts/webkitpy/tool/commands/queues_unittest.py:
618         * Scripts/webkitpy/tool/commands/queuestest.py:
619         * Scripts/webkitpy/tool/mocktool.py:
620
621 2010-06-10  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
622
623         Reviewed by Simon Hausmann.
624
625         [Qt] *All* WebGL layout tests fail!
626         https://bugs.webkit.org/show_bug.cgi?id=40296
627
628         Added test for WebKitWebGLEnabled to
629         LayoutTestController::overridePreference().
630
631         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
632         (LayoutTestController::overridePreference):
633
634 2010-06-10  Diego Gonzalez  <diegohcg@webkit.org>
635
636         Reviewed by Kenneth Rohde Christiansen.
637
638         [Qt] DRT EventSender support to graphics mouse events activation
639         https://bugs.webkit.org/show_bug.cgi?id=40017
640
641         * DumpRenderTree/qt/EventSenderQt.cpp:
642         (EventSender::mouseDown):
643         (EventSender::mouseUp):
644         (EventSender::mouseMoveTo):
645         (EventSender::keyDown):
646         (EventSender::contextClick):
647         (EventSender::sendTouchEvent):
648         (EventSender::sendOrQueueEvent):
649         (EventSender::eventFilter):
650         (EventSender::createGraphicsSceneMouseEvent):
651         (EventSender::sendEvent):
652         * DumpRenderTree/qt/EventSenderQt.h:
653         (EventSender::isGraphicsBased):
654
655 2010-06-09  Adam Barth  <abarth@webkit.org>
656
657         Reviewed by Ojan Vafai.
658
659         webkit-patch upload fails for security bugs because there's no rietveld flag
660         https://bugs.webkit.org/show_bug.cgi?id=40309
661
662         There's probably a more elegant way of seeing whether the form control
663         exists, but this seems to work.
664
665         * Scripts/webkitpy/common/net/bugzilla.py:
666
667 2010-06-09  Ojan Vafai  <ojan@chromium.org>
668
669         Reviewed by Adam Barth.
670
671         make rietveld upload faster and avoid posting to bug on errors
672         https://bugs.webkit.org/show_bug.cgi?id=40389
673
674         Only grab the first item of the upload queue instead of trying
675         to compute the whole list upfront (which is O(n) bugzilla lookups!).
676
677         Also, don't post comments to the bug when uploading fails.
678
679         * Scripts/webkitpy/common/net/bugzilla.py:
680         * Scripts/webkitpy/tool/commands/queues.py:
681         * Scripts/webkitpy/tool/commands/queues_unittest.py:
682         * Scripts/webkitpy/tool/commands/stepsequence.py:
683         * Scripts/webkitpy/tool/mocktool.py:
684
685 2010-06-09  Ojan Vafai  <ojan@chromium.org>
686
687         Reviewed by Adam Barth.
688
689         Rietveld upload queue fails when setting in-rietveld flag
690         https://bugs.webkit.org/show_bug.cgi?id=40371
691
692         Make the comment arguments to set_flag_on_attachment optional
693         and add it to the MockBugzilla.
694
695         * Scripts/webkitpy/common/net/bugzilla.py:
696         * Scripts/webkitpy/tool/bot/queueengine.py:
697         * Scripts/webkitpy/tool/commands/download_unittest.py:
698         * Scripts/webkitpy/tool/commands/queues.py:
699         * Scripts/webkitpy/tool/commands/queues_unittest.py:
700         * Scripts/webkitpy/tool/mocktool.py:
701
702 2010-06-09  Kenneth Russell  <kbr@google.com>
703
704         Reviewed by Dimitri Glazkov.
705
706         Rename FloatArray to Float32Array
707         https://bugs.webkit.org/show_bug.cgi?id=40323
708
709         Used do-webcore-rename to perform renaming. Manually undid
710         incorrect changes to WebCore/bridge/jni/jsc/JNIBridgeJSC.cpp,
711         WebCore/manual-tests/resources/ArrayParameterTestApplet.java and
712         ArrayParameterTestApplet.class. Updated LayoutTests. Built and ran
713         all layout tests on Safari; built Chromium and ran selected WebGL
714         tests.
715
716         * Scripts/do-webcore-rename:
717
718 2010-06-08  Tony Chang  <tony@chromium.org>
719
720         Reviewed by David Levin.
721
722         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
723         https://bugs.webkit.org/show_bug.cgi?id=40285
724
725         * Scripts/webkitdirs.pm:
726         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
727
728 2010-06-03  Roland Steiner  <rolandsteiner@chromium.org>
729
730         Reviewed by Tamura Kent.
731
732         Bug 40052 - [DRT/Chromium] Upstream test_shell_webthemeengine as WebThemeEngineDRT
733         https://bugs.webkit.org/show_bug.cgi?id=40052
734         
735         Add WebThemeEngineDRT and WebThemeControlDRT ported from Chromium rev. 48907
736
737         * DumpRenderTree/DumpRenderTree.gypi:
738         * DumpRenderTree/chromium/TestShellWin.cpp:
739         (platformInit):
740         * DumpRenderTree/chromium/WebThemeControlDRT.cpp: Added.
741         (WebKit::):
742         (WebKit::WebThemeControlDRT::WebThemeControlDRT):
743         (WebKit::WebThemeControlDRT::~WebThemeControlDRT):
744         (WebKit::WebThemeControlDRT::box):
745         (WebKit::WebThemeControlDRT::line):
746         (WebKit::WebThemeControlDRT::triangle):
747         (WebKit::WebThemeControlDRT::roundRect):
748         (WebKit::WebThemeControlDRT::oval):
749         (WebKit::WebThemeControlDRT::circle):
750         (WebKit::WebThemeControlDRT::nestedBoxes):
751         (WebKit::WebThemeControlDRT::markState):
752         (WebKit::WebThemeControlDRT::draw):
753         (WebKit::WebThemeControlDRT::drawTextField):
754         (WebKit::WebThemeControlDRT::drawProgressBar):
755         * DumpRenderTree/chromium/WebThemeControlDRT.h: Added.
756         (WebKit::WebThemeControlDRT::):
757         * DumpRenderTree/chromium/WebThemeEngineDRT.cpp: Added.
758         (WebKit::):
759         (WebKit::WebThemeEngineDRT::paintButton):
760         (WebKit::WebThemeEngineDRT::paintMenuList):
761         (WebKit::WebThemeEngineDRT::paintScrollbarArrow):
762         (WebKit::WebThemeEngineDRT::paintScrollbarThumb):
763         (WebKit::WebThemeEngineDRT::paintScrollbarTrack):
764         (WebKit::WebThemeEngineDRT::paintTextField):
765         (WebKit::WebThemeEngineDRT::paintTrackbar):
766         (WebKit::WebThemeEngineDRT::paintProgressBar):
767         * DumpRenderTree/chromium/WebThemeEngineDRT.h: Added.
768         (WebKit::WebThemeEngineDRT::WebThemeEngineDRT):
769
770 2010-06-08  Sheriff Bot  <webkit.review.bot@gmail.com>
771
772         Unreviewed, rolling out r60878.
773         http://trac.webkit.org/changeset/60878
774         https://bugs.webkit.org/show_bug.cgi?id=40349
775
776         broke linux build (Requested by tony^work on #webkit).
777
778         * Scripts/webkitdirs.pm:
779         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
780
781 2010-06-08  Tony Chang  <tony@chromium.org>
782
783         Reviewed by David Levin.
784
785         [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
786         https://bugs.webkit.org/show_bug.cgi?id=40285
787
788         * Scripts/webkitdirs.pm:
789         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
790
791 2010-06-08  Kenneth Russell  <kbr@google.com>
792
793         Unreviewed, build fix.
794
795         Fix build breakage from 38145
796         https://bugs.webkit.org/show_bug.cgi?id=40346
797
798         The fix for bug 38145 broke the Chromium Win build because
799         Microsoft's cmath doesn't define log2. Suggested fix by zmo is to
800         change log2(x) to log(x) / log(2). Built and ran WebGL layout
801         tests in Safari on Mac OS X. Changed download mirrors for
802         python-irclib to working ones.
803
804         * Scripts/webkitpy/thirdparty/__init__.py:
805
806 2010-06-08  Fumitoshi Ukai  <ukai@chromium.org>
807
808         Reviewed by Eric Seidel.
809
810         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
811         https://bugs.webkit.org/show_bug.cgi?id=39058
812
813         * Scripts/old-run-webkit-tests:
814          use sourceDir() to find ensure-valid-python in checkPythonVersion()
815
816 2010-06-08  Andras Becsi  <abecsi@webkit.org>
817
818         Unreviewed buildfix after r60479.
819
820         [GTK] Move the declaration of getRootCoords higher up to fix the build on GTK
821         versions other than 2.17.3.
822
823         * DumpRenderTree/gtk/EventSender.cpp:
824         (getRootCoords):
825
826 2010-06-07  Martin Robinson  <mrobinson@igalia.com>
827
828         Reviewed by Oliver Hunt.
829
830         [GTK] Mouse movement should not trigger a replay of saved events in the event sender
831         https://bugs.webkit.org/show_bug.cgi?id=40267
832
833         When a mouse button is down, automatically queue mouse motion events and
834         do not play them back until the mouse button is released. This matches the
835         behavior of other ports' EventSenders.
836
837         * DumpRenderTree/gtk/EventSender.cpp:
838         (mouseMoveToCallback): Don't automatically replaySavedEvents for mouse motion.
839         (sendOrQueueEvent): Add a shouldReplaySavedEvents argument defaulting to true.
840
841 2010-06-07  Nikolas Zimmermann  <nzimmermann@rim.com>
842
843         Reviewed by Sam Weinig.
844
845         Add CPP bindings generator
846         https://bugs.webkit.org/show_bug.cgi?id=38279
847
848         Integrate CPP bindings in run-bindings-tests.
849
850         * Scripts/run-bindings-tests:
851
852 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
853
854         Reviewed by Ojan Vafai.
855
856         Rename 'svn_merge_base' -> 'remote_merge_base'. This was left out of r60633.
857         https://bugs.webkit.org/show_bug.cgi?id=40183
858
859         * Scripts/webkitpy/tool/steps/preparechangelog.py:
860
861 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
862
863         Unreviewed.
864
865         Add my new email and IRC nick to committers.py.
866
867         * Scripts/webkitpy/common/config/committers.py:
868
869 2010-06-04  Kinuko Yasuda  <kinuko@chromium.org>
870
871         Unreviewed.
872
873         Revert changes in json_results_generator.py's _get_svn_revision.
874
875         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
876
877 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
878
879         Reviewed by Xan Lopez.
880
881         [GTK] GtkLauncher should support relative file paths
882         https://bugs.webkit.org/show_bug.cgi?id=39944
883
884         Allow GtkLauncher to handle relative file paths passed via command-line arguments.
885
886         * GtkLauncher/main.c:
887         (filename_to_url): Added.
888         (main): Try to resolve arguments as relative file URLs first.
889
890 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
891
892         Reviewed by Xan Lopez.
893
894         [GTK] EventSender should call gtk_main_do_event instead of invoking signal handlers directly
895         https://bugs.webkit.org/show_bug.cgi?id=40182
896
897         Instead of invoking signal handlers directly via g_signal_emit_by_name, call
898         gtk_main_do_event. This will allow us to call gtk_get_current_event() in WebKit
899         without breaking DRT.
900
901         * DumpRenderTree/gtk/EventSender.cpp:
902         (dispatchEvent): Use gtk_main_do_event instead of invoking signal handlers directly.
903         (keyDownCallback): Use dispatchEvent here which now uses gtk_main_do_event.
904
905 2010-06-04  Anders Carlsson  <andersca@apple.com>
906
907         Reviewed by David Hyatt.
908
909         Make the editing/spelling/context-menu-suggestions.html test more robust
910         https://bugs.webkit.org/show_bug.cgi?id=40178
911
912         Change the contextClick method to return an array of strings describing the context menu items.
913
914         * DumpRenderTree/mac/EventSendingController.mm:
915         (+[EventSendingController isSelectorExcludedFromWebScript:]):
916         (+[EventSendingController webScriptNameForSelector:]):
917         (-[EventSendingController contextClick]):
918
919 2010-06-03  Kinuko Yasuda  <kinuko@chromium.org>
920
921         Reviewed by Shinichiro Hamaji.
922
923         Clean up chromium-specific code from json_results_generator.py.
924         https://bugs.webkit.org/show_bug.cgi?id=39665
925
926         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
927         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
928         * Scripts/webkitpy/layout_tests/port/base.py:
929         * Scripts/webkitpy/layout_tests/port/chromium.py:
930
931 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
932
933         Reviewed by Adam Barth.
934
935         Utilize new takeFirst() method where appropriate.
936         https://bugs.webkit.org/show_bug.cgi?id=40089
937
938         * DumpRenderTree/chromium/EventSender.cpp:
939         (EventSender::replaySavedEvents):
940         * DumpRenderTree/chromium/LayoutTestController.cpp:
941         (LayoutTestController::WorkQueue::processWork):
942         (LayoutTestController::WorkQueue::reset):
943
944 2010-06-04  Yael Aharon  <yael.aharon@nokia.com>
945
946         Reviewed by Simon Hausmann.
947
948         [Qt] QtTestLauncher should allow notifications by default.
949         https://bugs.webkit.org/show_bug.cgi?id=40078
950
951         * QtTestBrowser/main.cpp:
952         (NotificationsPermissionController::NotificationsPermissionController):
953         (NotificationsPermissionController::checkPermission):
954         (NotificationsPermissionController::requestPermission):
955         (LauncherWindow::LauncherWindow):
956
957 2010-06-04  Tony Gentilcore  <tonyg@chromium.org>
958
959         Reviewed by Adam Barth.
960
961         Detect whether the user's environment can open a browser.
962         https://bugs.webkit.org/show_bug.cgi?id=40136
963
964         Some environments like cygwin silently fail webbrowser.open() causing
965         webkit-patch upload not to display any diff. This detects environments
966         where webbrowser.open() would fail by testing if webbrowser.get()
967         raises an exception.
968
969         * Scripts/webkitpy/common/system/user.py:
970         * Scripts/webkitpy/tool/mocktool.py:
971         * Scripts/webkitpy/tool/steps/confirmdiff.py:
972
973 2010-06-03  Tony Gentilcore  <tonyg@chromium.org>
974
975         Reviewed by David Levin.
976
977         Add dependencies required to link with VS Express 2005.
978         https://bugs.webkit.org/show_bug.cgi?id=40038
979
980         Visual Studio implicitly links against these libs.
981         VC++ Express does not.
982
983         * WebKitAPITest/WebKitAPITestCommon.vsprops:
984         * WinLauncher/WinLauncher.vcproj:
985
986 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
987
988         Reviewed by David Levin.
989
990         bad codecs.open in webkitpy/layout_tests/ports/websocket_server.py
991         https://bugs.webkit.org/show_bug.cgi?id=40105
992
993         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
994         - kill pywebsocket process when url is not alive and the process is not
995           terminated, not to leave pywebsocket server running.
996         - fix codecs.open parameters.
997
998 2010-06-03  Fumitoshi Ukai  <ukai@chromium.org>
999
1000         Reviewed by Alexey Proskuryakov.
1001
1002         old-run-webkit-tests should use ensure-valid-python to check if it can run the websockets tests
1003         https://bugs.webkit.org/show_bug.cgi?id=39058
1004
1005         * Scripts/ensure-valid-python:
1006           - Perl 5.8 doesn't have File::Temp->newdir().  Use File::Temp->tempdir() instead.
1007           - Add --check-only and --help option.
1008           - --check-only option only checks python version and don't try to install Python 2.5.
1009           - Set executable bit.
1010         * Scripts/old-run-webkit-tests:
1011           - Check if it can run the websocket tests by calling ensure-valid-python --check-only.
1012
1013 2010-05-14  Ojan Vafai  <ojan@chromium.org>
1014
1015         Reviewed by Adam Barth.
1016
1017         add a RietveldUploadQueue to upload in-rietveld? patches to rietveld
1018         https://bugs.webkit.org/show_bug.cgi?id=38918
1019
1020         Patches with in-rietveld? get uploaded to rietveld and get marked
1021         in-rietveld+. If the upload fails, they are marked in-rietveld-
1022         and an error is logged to the bug, like the commit-queue.
1023
1024         Also, get rid of --fancy-review and the ability to upload to rietveld
1025         using webkit-patch upload/post.
1026
1027         * Scripts/webkitpy/common/net/bugzilla.py:
1028         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1029         * Scripts/webkitpy/tool/commands/download.py:
1030         * Scripts/webkitpy/tool/commands/download_unittest.py:
1031         * Scripts/webkitpy/tool/commands/queues.py:
1032         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1033         * Scripts/webkitpy/tool/commands/upload.py:
1034         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1035         * Scripts/webkitpy/tool/mocktool.py:
1036         * Scripts/webkitpy/tool/steps/options.py:
1037         * Scripts/webkitpy/tool/steps/postcodereview.py:
1038
1039 2010-05-24  Ojan Vafai  <ojan@chromium.org>
1040
1041         Reviewed by Chris Jerdonek.
1042
1043         many webkit-patch commands fail in a non-svn tracking git checkout
1044         https://bugs.webkit.org/show_bug.cgi?id=38156
1045
1046         If the svn-tracking-branch (trunk) doesn't exist, fallback to the git remote-tracking-branch (master).
1047         If neither exists, then error out. This makes webkit-patch work
1048         for anyone that follows the intructions at http://trac.webkit.org/wiki/UsingGitWithWebKit
1049         to checkout webkit. The fallback to master is for people who don't
1050         do the steps on that page for tracking svn.
1051
1052         * Scripts/webkitpy/common/checkout/scm.py:
1053         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1054
1055 2010-06-03  Mike Fenton  <mifenton@rim.com>
1056
1057         Unreviewed.
1058
1059         Reverse e-mail for myself in committers.py to correspond with bugzilla account.
1060
1061         * Scripts/webkitpy/common/config/committers.py:
1062
1063 2010-06-03  Pavel Feldman  <pfeldman@chromium.org>
1064
1065         Reviewed by Yury Semikhatsky.
1066
1067         Web Inspector: a number of fixes that make InspectorController
1068         happy with null redirects.
1069
1070         https://bugs.webkit.org/show_bug.cgi?id=40109
1071
1072         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1073         (runTest):
1074         * DumpRenderTree/mac/DumpRenderTree.mm:
1075         (runTest):
1076         * DumpRenderTree/win/DumpRenderTree.cpp:
1077         (runTest):
1078
1079 2010-06-02  Tasuku Suzuki  <tasuku.suzuki@nokia.com>
1080
1081         Reviewed by Shinichiro Hamaji.
1082
1083         [Qt] Fix compilation with QT_NO_PROPERTIES
1084         https://bugs.webkit.org/show_bug.cgi?id=38324
1085
1086         * QtTestBrowser/main.cpp:
1087         (LauncherWindow::init):
1088
1089 2010-06-02  Diego Gonzalez  <diegohcg@webkit.org>
1090
1091         Reviewed by Kenneth Rohde Christiansen.
1092
1093         [Qt] Make possible run DRT with QGraphicsWebView
1094         https://bugs.webkit.org/show_bug.cgi?id=40016
1095
1096         Make possible to use a environment variable for switching backend.
1097         Usage: QT_DRT_WEBVIEW_MODE=graphics WebKitTools/Scripts/run-webkit-tests --qt
1098
1099         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1100         (WebCore::WebViewGraphicsBased::WebViewGraphicsBased):
1101         (WebCore::DumpRenderTree::DumpRenderTree):
1102         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1103         (WebCore::DumpRenderTree::setGraphicsBased):
1104         (WebCore::DumpRenderTree::isGraphicsBased):
1105         (WebCore::WebViewGraphicsBased::graphicsView):
1106         (WebCore::WebViewGraphicsBased::setPage):
1107         * Scripts/old-run-webkit-tests:
1108
1109 2010-06-02  Csaba Osztrogon√°c  <ossy@webkit.org>
1110
1111         Reviewed by Eric Seidel.
1112
1113         Slave lost shouldn't be recognized as build failed.
1114         https://bugs.webkit.org/show_bug.cgi?id=39282
1115
1116         * Scripts/webkitpy/common/net/buildbot.py: Treat slave lost as green.
1117         * Scripts/webkitpy/common/net/buildbot_unittest.py: Add unit test for slave lost.
1118
1119 2010-06-01  Yael Aharon  <yael.aharon@nokia.com>
1120
1121         Reviewed by Kenneth Rohde Christiansen.
1122
1123         [Qt] Fix the lifecycle of notification objects
1124         https://bugs.webkit.org/show_bug.cgi?id=40003
1125
1126         Remove the dependency of notifications on QWebPage.
1127
1128         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1129         (WebCore::requestPermissionCallback):
1130         (WebCore::WebPage::WebPage):
1131         (WebCore::DumpRenderTree::requestPermission):
1132         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1133
1134 2010-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1135
1136         Unreviewed, rolling out r60559.
1137         http://trac.webkit.org/changeset/60559
1138         https://bugs.webkit.org/show_bug.cgi?id=40055
1139
1140         It broke python unit test (Requested by Ossy on #webkit).
1141
1142         * Scripts/webkitpy/common/net/buildbot.py:
1143
1144 2010-06-02  Csaba Osztrogon√°c  <ossy@webkit.org>
1145
1146         Reviewed by Eric Seidel.
1147
1148         Slave lost shouldn't be recognized as build failed.
1149         https://bugs.webkit.org/show_bug.cgi?id=39282
1150
1151         * Scripts/webkitpy/common/net/buildbot.py:
1152
1153 2010-06-02  Tony Gentilcore  <tonyg@chromium.org>
1154
1155         Reviewed by Eric Seidel.
1156
1157         Fix crash caused when assigned_to is disabled
1158         https://bugs.webkit.org/show_bug.cgi?id=40039
1159
1160         * Scripts/webkitpy/common/net/bugzilla.py:
1161
1162 2010-06-02  Sterling Swigart  <sswigart@google.com>
1163
1164         Reviewed by David Levin.
1165
1166         Image Resizer Patch 0: Added compilation argument to conditionally compile pending patches.
1167         https://bugs.webkit.org/show_bug.cgi?id=39906
1168
1169         * Scripts/build-webkit:
1170
1171 2010-06-01  Raine Makelainen  <raine.makelainen@nokia.com>
1172
1173         Reviewed by Simon Hausmann.
1174
1175         Fixed tests to use QWebSettings::JavascriptCanAccessClipboard instead of QWebSettings::JavaScriptCanAccessClipboard.
1176
1177         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1178         (WebCore::WebPage::WebPage):
1179         (WebCore::WebPage::resetSettings):
1180         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1181         (LayoutTestController::setJavaScriptCanAccessClipboard):
1182
1183 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
1184
1185         Reviewed by Mark Rowe.
1186
1187         A nicer Tiger build fix.
1188
1189         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1190         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1191         Enable GCC_OBJC_CALL_CXX_CDTORS via .xcconfig.
1192
1193 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
1194
1195         A real Tiger build fix.
1196
1197         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS
1198         for all configurations, not just debug.
1199
1200 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
1201
1202         Tiger build fix.
1203
1204         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Enable GCC_OBJC_CALL_CXX_CDTORS.
1205
1206 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
1207
1208         Reviewed by Xan Lopez.
1209
1210         [GTK] Get more mouse tests passing
1211         https://bugs.webkit.org/show_bug.cgi?id=39040
1212
1213         Reproduce the logic from the Windows EventSender for mapping
1214         button numbers to GDK button numbers. Move this logic to the
1215         prepareMouseButtonEvent helper.
1216
1217         * DumpRenderTree/gtk/EventSender.cpp:
1218         (prepareMouseButtonEvent): Reproduce Windows logic.
1219         (contextClickCallback): Move mapping logic to prepareMouseButtonEvent.
1220         (mouseDownCallback): Ditto.
1221         (mouseUpCallback): Ditto.
1222
1223 2010-06-01  Alexey Proskuryakov  <ap@apple.com>
1224
1225         Reviewed by Sam Weinig.
1226
1227         https://bugs.webkit.org/show_bug.cgi?id=39434
1228         REGRESSION (r59811): Geolocation callbacks cannot be created
1229
1230         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added MockGeolocationProvider.
1231
1232         * DumpRenderTree/mac/DumpRenderTree.mm:
1233         (createWebViewAndOffscreenWindow): Tell the view to use MockGeolocationProvider. 
1234         (resetWebViewToConsistentStateBeforeTesting): Make sure that mock notifications don't leak
1235         into subsequent tests.
1236
1237         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1238         (LayoutTestController::setMockGeolocationPosition): Changed to use MockGeolocationProvider.
1239         (LayoutTestController::setMockGeolocationError): Ditto.
1240
1241         * DumpRenderTree/mac/MockGeolocationProvider.h: Added.
1242         * DumpRenderTree/mac/MockGeolocationProvider.mm: Added.
1243         (+[MockGeolocationProvider shared]):
1244         (-[MockGeolocationProvider dealloc]):
1245         (-[MockGeolocationProvider setPosition:]):
1246         (-[MockGeolocationProvider setError:]):
1247         (-[MockGeolocationProvider registerWebView:]):
1248         (-[MockGeolocationProvider unregisterWebView:]):
1249         (-[MockGeolocationProvider lastPosition]):
1250         (-[MockGeolocationProvider stopTimer]):
1251         (-[MockGeolocationProvider timerFired]):
1252
1253         * DumpRenderTree/mac/UIDelegate.mm:
1254         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1255         This delegate method must send a response. I'm not sure what the two-stage check is supposed
1256         to achieve, it seems unnecessary.
1257
1258 2010-05-12  Martin Robinson  <mrobinson@igalia.com>
1259
1260         Reviewed by Xan Lopez.
1261
1262         [GTK] Double clicks cause three button press events
1263         https://bugs.webkit.org/show_bug.cgi?id=38853
1264
1265         WebKit now filters the extra GDK_BUTTON_PRESS before GDK_2BUTTON_PRESS
1266         and GDK_3BUTTON_PRESS via gdk_event_peek(). Since EventSender bypasses
1267         the GDK event queue entirely, we simply do not send the extra event.
1268
1269         * DumpRenderTree/gtk/EventSender.cpp:
1270         (mouseDownCallback): Do not send extra event. Send GDK_3BUTTON_PRESS appropriately.
1271         (dispatchEvent): Properly handle GDK_3BUTTON_PRESS.
1272
1273 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
1274
1275         Not reviewed. Build fix.
1276
1277         Fix GTK+ build caused by a bad merge.
1278
1279         * DumpRenderTree/gtk/EventSender.cpp: 
1280         (prepareMouseButtonEvent): Use the GdkEvent union as a pointer here.
1281
1282 2010-06-01  Martin Robinson  <mrobinson@webkit.org>
1283
1284         Reviewed by Xan Lopez.
1285
1286         [GTK] Double clicks cause three button press events
1287         https://bugs.webkit.org/show_bug.cgi?id=38853
1288
1289         Small EventSender cleanups. Consolidate some common code. Style fixes.
1290
1291         * DumpRenderTree/gtk/EventSender.cpp:
1292         (prepareMouseButtonEvent): Added.
1293         (contextClickCallback): Use prepareMouseButtonEvent.
1294         (mouseDownCallback): Use prepareMouseButtonEvent.
1295         (mouseUpCallback): Use prepareMouseButtonEvent.
1296         (mouseMoveToCallback): Small style fix.
1297
1298 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
1299
1300         Reviewed by Xan Lopez.
1301
1302         [GTK] Double clicks cause three button press events
1303         https://bugs.webkit.org/show_bug.cgi?id=38853
1304
1305         Add rudimentary leapForward support to the GTK+ DRT. leapForward allows a test
1306         to pause for a specified amount of time. It is used in the processing of drag-
1307         -and-drop data as well as to separate distinct mouse double-clicks in some tests.
1308         This patch enables tests that rely on the latter behavior to pass.
1309
1310         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1311         (webViewWindowObjectCleared): Only initialize the EventSender when loading the top frame.
1312         * DumpRenderTree/gtk/EventSender.cpp:
1313         (leapForwardCallback): Add support for adjusting the time offset on leapForward().
1314         (contextClickCallback): Use sendOrQueueEvent.
1315         (updateClickCount): Take the time offset into account when counting clicks.
1316         (mouseDownCallback): Use sendOrQueueEvent.
1317         (getStateFlags): Change down/currentEventButton into buttonCurrentlyDown/lastClickButton.
1318         (mouseUpCallback): Use sendOrQueueEvent.
1319         (mouseMoveToCallback): Ditto.
1320         (mouseWheelToCallback): Ditto.
1321         (sendOrQueueEvent): Added.
1322         (dispatchEvent): Added.
1323         (replaySavedEvents): Pause when an event has a delay and defer to dispatchEvent.
1324         (makeEventSender): Only initialize the EventSender when loading the top frame.
1325         * DumpRenderTree/gtk/EventSender.h: Ditto.
1326
1327 2010-06-01  Martin Robinson  <mrobinson@igalia.com>
1328
1329         Reviewed by Xan Lopez.
1330
1331         [GTK] css1/color_and_background/background_attachment.html fails on the 32-bit debug bot
1332         https://bugs.webkit.org/show_bug.cgi?id=39101
1333
1334         Work around timing issues for render tree dumps by pumping the
1335         main loop before doing the dump. Resize events are asynchronous
1336         in GTK+, so sometimes resize requests are still pending when DRT
1337         dumps the tree.
1338
1339         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1340         (dump): Pump the main loop before dumping the render tree.
1341
1342 2010-05-31  Kent Tamura  <tkent@chromium.org>
1343
1344         Reviewed by Dimitri Glazkov.
1345
1346         [DRT/Chromium] Fix crash of a test after another test with multiple windows
1347         https://bugs.webkit.org/show_bug.cgi?id=39942
1348
1349         If a test opens multiple windows, focuses on non-main window, and
1350         the focused window is closed, TestShell::m_focusedWidget points a
1351         deleted object.
1352
1353         * DumpRenderTree/chromium/TestShell.cpp:
1354         (TestShell::closeWindow): Clear m_focusedWidget.
1355
1356 2010-05-30  Kent Tamura  <tkent@chromium.org>
1357
1358         Reviewed by Dimitri Glazkov.
1359
1360         new-run-webkit-tests: Support DRT on Chromium-win
1361         https://bugs.webkit.org/show_bug.cgi?id=39810
1362
1363         Add --test-shell flag to DRT/Chromium, and it changes DRT so that
1364         it behaves like test_shell about command analysis, printing
1365         format, pixel dumping, and timeout handling.
1366
1367         chromium.py and chromium_win.py supports the --test-shell flag and
1368         DRT/Chromium-win binary names.
1369         
1370         * DumpRenderTree/DumpRenderTree.gypi: Add new files.
1371         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1372         (runTest): Support for test_shell-style command.
1373         (main): Introduce --test-shell.
1374         * DumpRenderTree/chromium/TestEventPrinter.cpp: Added.
1375         * DumpRenderTree/chromium/TestEventPrinter.h: Added.
1376           TestEventPrinter class manages stdio output and image output.
1377           TestEventPrinter.cpp has two implementations; DRTPrinter and
1378           TestShellPrinter.
1379         * DumpRenderTree/chromium/TestShell.cpp:
1380           Some changes for TestEventPrinter.
1381         (TestShell::TestShell):
1382         (TestShell::runFileTest):
1383         (TestShell::testTimedOut):
1384         (TestShell::dump):
1385         (TestShell::dumpImage):
1386         * DumpRenderTree/chromium/TestShell.h:
1387         (TestShell::printer):
1388         (TestShell::layoutTestTimeout):
1389         (TestShell::layoutTestTimeoutForWatchDog):
1390         (TestShell::setLayoutTestTimeout):
1391         * DumpRenderTree/chromium/TestShellWin.cpp:
1392         (watchDogThread): Use TestShell::layoutTestTimeoutForWatchDog().
1393         * Scripts/webkitpy/layout_tests/port/chromium.py:
1394         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1395
1396 2010-05-30  Robert Hogan  <robert@webkit.org>
1397
1398         Reviewed by Kenneth Rohde Christiansen.
1399
1400         [Qt] Enhance Qt DRT implementation to support platform scroll wheel events.
1401
1402         https://bugs.webkit.org/show_bug.cgi?id=36004
1403
1404         * DumpRenderTree/qt/EventSenderQt.cpp:
1405         (EventSender::EventSender): QApplication::setWheelScrollLines(2) in order to match
1406                                     Scrollbar::pixelsPerLineStep() for DRT testing.
1407         (EventSender::mouseScrollBy): Added
1408         (EventSender::continuousMouseScrollBy): Added
1409         * DumpRenderTree/qt/EventSenderQt.h:
1410
1411 2010-05-28  Adam Barth  <abarth@webkit.org>
1412
1413         Reviewed by David Levin.
1414
1415         webkit-patch should support CHANGE_LOG_EDIT_APPLICATION
1416         https://bugs.webkit.org/show_bug.cgi?id=39546
1417
1418         One sublty is that we want to wait for the user to finish editing the
1419         ChangeLog before moving on to the next step.  That means we want to pass
1420         -W to open.  However, if the user is using Xcode to edit the ChangeLog,
1421         we don't want them to have to exit the Xcode application.  For this reason,
1422         we create a new instance of the application with -n.
1423         
1424         Overall, xed seems like a better solution, so we recommend that too.
1425
1426         * Scripts/webkitpy/common/system/user.py:
1427         * Scripts/webkitpy/tool/mocktool.py:
1428         * Scripts/webkitpy/tool/steps/editchangelog.py:
1429
1430 2010-05-21  Dirk Pranke  <dpranke@chromium.org>
1431
1432         Reviewed by Ojan Vafai.
1433
1434         new-run-webkit-tests: fix handling of Ctrl-C to exit even if some
1435         threads are wedged. Also, the script will print the results of the
1436         tests completed when the interrupt occurs.
1437
1438         https://bugs.webkit.org/show_bug.cgi?id=33238
1439
1440         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1441         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1442         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1443         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1444
1445 2010-05-28  Darin Adler  <darin@apple.com>
1446
1447         Ignore more Python messiness.
1448
1449         * Scripts/webkitpy/layout_tests/data/platform/test: Added property svn:ignore.
1450         * Scripts/webkitpy/layout_tests/layout_package: Added property svn:ignore.
1451         * Scripts/webkitpy/layout_tests/test_types: Added property svn:ignore.
1452         * Scripts/webkitpy/test: Added property svn:ignore.
1453         * Scripts/webkitpy/thirdparty/simplejson: Added property svn:ignore.
1454
1455 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
1456
1457         Reviewed by Beth Dakin.
1458
1459         Adding myself as a reviewer.
1460
1461         * Scripts/webkitpy/common/config/committers.py:
1462
1463 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
1464
1465         Build fix. No review.
1466
1467         AX: need to catch NSAccessibilityExceptions in DRT
1468         https://bugs.webkit.org/show_bug.cgi?id=39881
1469
1470         It looks like Tiger doesn't like seeing a NSMakeRange inside a @try.
1471
1472         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1473         (AccessibilityUIElement::rowIndexRange):
1474         (AccessibilityUIElement::columnIndexRange):
1475         (AccessibilityUIElement::selectedTextRange):
1476
1477 2010-05-28  Chris Fleizach  <cfleizach@apple.com>
1478
1479         Reviewed by Darin Adler.
1480
1481         AX: need to catch NSAccessibilityExceptions in DRT
1482         https://bugs.webkit.org/show_bug.cgi?id=39881
1483
1484         Normally, accessibility exceptions are caught in the AX Runtime on the Mac, but 
1485         because DRT is its own AX client, no one is there to catch these otherwise innocuous exceptions.
1486   
1487         So DRT should wrap exception handlers around its AX related calls.
1488
1489         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1490         (attributesOfElement):
1491         (AccessibilityUIElement::getLinkedUIElements):
1492         (AccessibilityUIElement::getDocumentLinks):
1493         (AccessibilityUIElement::getChildren):
1494         (AccessibilityUIElement::getChildrenWithRange):
1495         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1496         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1497         (AccessibilityUIElement::disclosedRowAtIndex):
1498         (AccessibilityUIElement::selectedRowAtIndex):
1499         (AccessibilityUIElement::titleUIElement):
1500         (AccessibilityUIElement::parentElement):
1501         (AccessibilityUIElement::disclosedByRow):
1502         (AccessibilityUIElement::stringAttributeValue):
1503         (AccessibilityUIElement::boolAttributeValue):
1504         (AccessibilityUIElement::isAttributeSettable):
1505         (AccessibilityUIElement::isAttributeSupported):
1506         (AccessibilityUIElement::role):
1507         (AccessibilityUIElement::subrole):
1508         (AccessibilityUIElement::roleDescription):
1509         (AccessibilityUIElement::title):
1510         (AccessibilityUIElement::description):
1511         (AccessibilityUIElement::orientation):
1512         (AccessibilityUIElement::stringValue):
1513         (AccessibilityUIElement::language):
1514         (AccessibilityUIElement::helpText):
1515         (AccessibilityUIElement::x):
1516         (AccessibilityUIElement::y):
1517         (AccessibilityUIElement::width):
1518         (AccessibilityUIElement::height):
1519         (AccessibilityUIElement::clickPointX):
1520         (AccessibilityUIElement::clickPointY):
1521         (AccessibilityUIElement::intValue):
1522         (AccessibilityUIElement::minValue):
1523         (AccessibilityUIElement::maxValue):
1524         (AccessibilityUIElement::valueDescription):
1525         (AccessibilityUIElement::insertionPointLineNumber):
1526         (AccessibilityUIElement::isActionSupported):
1527         (AccessibilityUIElement::isEnabled):
1528         (AccessibilityUIElement::isRequired):
1529         (AccessibilityUIElement::isSelected):
1530         (AccessibilityUIElement::isExpanded):
1531         (AccessibilityUIElement::hierarchicalLevel):
1532         (AccessibilityUIElement::ariaIsGrabbed):
1533         (AccessibilityUIElement::ariaDropEffects):
1534         (AccessibilityUIElement::lineForIndex):
1535         (AccessibilityUIElement::boundsForRange):
1536         (AccessibilityUIElement::stringForRange):
1537         (AccessibilityUIElement::attributesOfColumnHeaders):
1538         (AccessibilityUIElement::attributesOfRowHeaders):
1539         (AccessibilityUIElement::attributesOfColumns):
1540         (AccessibilityUIElement::attributesOfRows):
1541         (AccessibilityUIElement::attributesOfVisibleCells):
1542         (AccessibilityUIElement::attributesOfHeader):
1543         (AccessibilityUIElement::rowCount):
1544         (AccessibilityUIElement::columnCount):
1545         (AccessibilityUIElement::indexInTable):
1546         (AccessibilityUIElement::rowIndexRange):
1547         (AccessibilityUIElement::columnIndexRange):
1548         (AccessibilityUIElement::cellForColumnAndRow):
1549         (AccessibilityUIElement::selectedTextRange):
1550         (AccessibilityUIElement::setSelectedTextRange):
1551         (AccessibilityUIElement::increment):
1552         (AccessibilityUIElement::decrement):
1553         (AccessibilityUIElement::showMenu):
1554         (AccessibilityUIElement::press):
1555         (AccessibilityUIElement::url):
1556         (AccessibilityUIElement::hasPopup):
1557
1558 2010-05-28  Yael Aharon  <yael.aharon@nokia.com>
1559
1560         Reviewed by Laszlo Gombos.
1561
1562         [Qt] Pass all web notification layout tests
1563         https://bugs.webkit.org/show_bug.cgi?id=39146
1564
1565         Mimic Chromium's test_shell security model in Qt's DRT.
1566         It makes a list of origins which were granted permission to display
1567         notifications, and only those origins can display notifications.
1568
1569         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1570         (WebCore::checkPermissionCallback):
1571         (WebCore::requestPermissionCallback):
1572         (WebCore::WebPage::WebPage):
1573         (WebCore::DumpRenderTree::checkPermission):
1574         (WebCore::DumpRenderTree::requestPermission):
1575         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1576         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1577         (LayoutTestController::reset):
1578         (LayoutTestController::grantDesktopNotificationPermission):
1579         (LayoutTestController::checkDesktopNotificationPermission):
1580         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1581
1582 2010-05-27  Philippe Normand  <pnormand@igalia.com>
1583
1584         Reviewed by Shinichiro Hamaji.
1585
1586         check-webkit-style complains about use of NULL in GTK function calls that require sentinels
1587         https://bugs.webkit.org/show_bug.cgi?id=39372
1588
1589         Don't warn about NULL in g_*() calls. Zero can't be used instead
1590         for calls like g_build_filename and g_object_get/set.
1591
1592         * Scripts/webkitpy/style/checkers/cpp.py:
1593         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1594
1595 2010-05-27  Luiz Agostini  <luiz.agostini@openbossa.org>
1596
1597         Reviewed by Kenneth Rohde Christiansen.
1598
1599         [Qt] Platform plugin example
1600         https://bugs.webkit.org/show_bug.cgi?id=39489
1601
1602         Exempting directory WebKit/qt/examples/ from style guide.
1603
1604         * Scripts/webkitpy/style/checker.py:
1605
1606 2010-05-26  Philippe Normand  <pnormand@igalia.com>
1607
1608         Reviewed by David Levin.
1609
1610         [style] Allow usage of NULL in gst_*_many()
1611         https://bugs.webkit.org/show_bug.cgi?id=39740
1612
1613         Don't warn if NULL is used by gst_*_many() functions. Zero can't
1614         be used for the reason explained in Bug 32858.
1615
1616         * Scripts/webkitpy/style/checkers/cpp.py:
1617         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1618
1619 2010-05-27  Adam Barth  <abarth@webkit.org>
1620
1621         Reviewed by Eric Seidel.
1622
1623         Update script to run the normal version of the parser tests.
1624
1625         * Scripts/test-html5-parser:
1626
1627 2010-05-27  Adam Barth  <abarth@webkit.org>
1628
1629         Reviewed by Eric Seidel.
1630
1631         Add HTML5 parser support to run-webkit-tests
1632         https://bugs.webkit.org/show_bug.cgi?id=39815
1633
1634         * Scripts/old-run-webkit-tests:
1635
1636 2010-05-26  Adam Barth  <abarth@webkit.org>
1637
1638         Reviewed by Eric Seidel.
1639
1640         Make HTML5 lexer not ASSERT when resuming partial parses
1641         https://bugs.webkit.org/show_bug.cgi?id=39755
1642
1643         Add webkit-resumer.html to the HTML5 parser test suite.
1644
1645         * Scripts/test-html5-parser:
1646
1647 2010-05-24  Tony Chang  <tony@chromium.org>
1648
1649         Reviewed by Kent Tamura.
1650
1651         [chromium] setup fonts on chromium linux DRT
1652         https://bugs.webkit.org/show_bug.cgi?id=39644
1653
1654         * DumpRenderTree/chromium/TestShellGtk.cpp:
1655         (setupFontconfig):
1656         (platformInit):
1657         * DumpRenderTree/chromium/WebViewHost.cpp:
1658         (WebViewHost::paintRect):  Fix a bug where in release builds, we didn't initialize m_canvas.
1659         * DumpRenderTree/chromium/fonts.conf: Added.
1660
1661 2010-05-24  Dirk Pranke  <dpranke@chromium.org>
1662
1663         Reviewed by Dimitri Glazkov.
1664
1665         Re-commit r58765 - it had been rolled out to see if it was causing
1666         a perf regression (in r59787 and r59789), but that does not seem to
1667         have been the case.
1668
1669         https://bugs.webkit.org/show_bug.cgi?id=39605
1670
1671         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1672         (NotificationPresenter::show):
1673
1674 2010-05-25  Ojan Vafai  <ojan@chromium.org>
1675
1676         Reviewed by Chris Jerdonek.
1677
1678         remove suppression of rietveld logging
1679         https://bugs.webkit.org/show_bug.cgi?id=39693
1680
1681         Now that we only upload to rietveld explicitly, e.g. on the bot
1682         or via webkit-patch post-attachment-to-rietveld, we should print
1683         all the rietveld logging. It was suppressed before to avoid making
1684         webkit-patch upload too noisy.
1685
1686         * Scripts/webkitpy/common/net/rietveld.py:
1687
1688 2010-05-25  Antonio Gomes  <tonikitoo@webkit.org>
1689
1690         Reviewed by Ojan Vafai.
1691
1692         [Qt] Expose the editing behavior setting in DRT to test all editing code paths
1693         https://bugs.webkit.org/show_bug.cgi?id=39680
1694
1695         Implement LayoutTestController::setEditingBehavior in Qt's DRT.
1696
1697         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1698         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1699         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1700         (LayoutTestController::setEditingBehavior):
1701
1702 2010-05-25  Kevin Ollivier  <kevino@theolliviers.com>
1703
1704         [wx] Build fix after API change and addition of WebCore/platform/text/transcoder dir. 
1705
1706         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1707         (LayoutTestController::setEditingBehavior):
1708         * wx/build/settings.py:
1709
1710 2010-05-24  Antonio Gomes  <tonikitoo@webkit.org>
1711
1712         Reviewed by Eric Seidel and Kent Tamura (for the Chromium part).
1713
1714         editingBehavior settings needs to be set back to a reasonable default between tests
1715         https://bugs.webkit.org/show_bug.cgi?id=39433
1716
1717         Similarly to r59861, hard code the default setting during reset for Gtk and Chromium,
1718         so that the serialized version of the setting stays in sync with expectations.
1719
1720         * DumpRenderTree/chromium/TestShell.cpp:
1721         (TestShell::resetWebSettings):
1722         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1723         (resetDefaultsToConsistentValues):
1724
1725 2010-05-24  Eric Seidel  <eric@webkit.org>
1726
1727         Reviewed by Adam Barth.
1728
1729         webkit-patch land calls scm.changed_files 4 times!
1730         https://bugs.webkit.org/show_bug.cgi?id=39584
1731
1732         * Scripts/webkitpy/tool/commands/download_unittest.py:
1733          - Assert that we don't call modified_changelogs too often.
1734         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1735          - Use cached changelogs list instead of calling modified_changelogs directly.
1736         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1737          - ditto.
1738
1739 2010-05-24  Kent Tamura  <tkent@chromium.org>
1740
1741         Reviewed by Dimitri Glazkov.
1742
1743         [DRT/Chromium] Import layout_test_helper for Windows
1744         https://bugs.webkit.org/show_bug.cgi?id=39581
1745
1746         Import Chromium win/layout_test_helper.cc as LayoutTestHelperWin.cpp.
1747         http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/win/layout_test_helper.cc
1748
1749         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Added.
1750
1751 2010-05-24  Kent Tamura  <tkent@chromium.org>
1752
1753         Reviewed by Dimitri Glazkov.
1754
1755         [DRT/Chromium] Reset frame name
1756         https://bugs.webkit.org/show_bug.cgi?id=39586
1757
1758         This change fixes about 70 unexpected results.
1759
1760         * DumpRenderTree/chromium/WebViewHost.cpp:
1761         (WebViewHost::reset):
1762
1763 2010-05-24  Marcus Bulach  <bulach@chromium.org>
1764
1765         Reviewed by Kent Tamura.
1766
1767         [chromium] Adds WebGeolocationServiceMockImpl to remove public dependency on wtf/HashMap.h
1768         https://bugs.webkit.org/show_bug.cgi?id=39587
1769
1770         * DumpRenderTree/chromium/WebViewHost.cpp:
1771         (WebViewHost::geolocationService):
1772
1773 2010-05-24  Robert Hogan  <robert@webkit.org>
1774
1775         Reviewed by Laszlo Gombos.
1776
1777         [Qt] DRT Support for removeOriginAccessWhitelistEntry
1778
1779         Unskips http/tests/xmlhttprequest/origin-whitelisting-removal.html
1780
1781         [Qt] DRT Support for removeOriginAccessWhitelistEntry
1782         https://bugs.webkit.org/show_bug.cgi?id=39565
1783
1784         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1785         (LayoutTestController::removeOriginAccessWhitelistEntry):
1786
1787 2010-05-24  Marcus Bulach  <bulach@google.com>
1788
1789         Reviewed by Ojan Vafai.
1790
1791         _svn_branch_has_extra_commits needs to check for ^HEAD instead of ^head.
1792         https://bugs.webkit.org/show_bug.cgi?id=39603
1793
1794         * Scripts/webkitpy/common/checkout/scm.py:
1795
1796 == Rolled over to ChangeLog-2010-05-24 ==