85b232e5f5fba19ecfb2c4dd8eebb51aa29a8456
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-12-06  Dan Bernstein  <mitz@apple.com>
2
3         Reviewed by Adele Peterson.
4
5         REGRESSION (r51728): update-webkit fails when the current directory is
6         not inside a Subversion working copy
7         https://bugs.webkit.org/show_bug.cgi?id=32204
8
9         * Scripts/update-webkit: Invoke isSVN() in the correct working
10         directory.
11
12 2009-12-06  Adam Barth  <abarth@webkit.org>
13
14         Reviewed by Eric Seidel.
15
16         [bzt] Rename AbstractTryQueue to AbstractReviewQueue
17         https://bugs.webkit.org/show_bug.cgi?id=32202
18
19         * Scripts/modules/commands/queues.py:
20
21 2009-12-05  Adam Barth  <abarth@webkit.org>
22
23         Reviewed by Eric Seidel.
24
25         [bzt] Implement ChromiumPort
26         https://bugs.webkit.org/show_bug.cgi?id=32182
27
28         * Scripts/modules/webkitport.py:
29         * Scripts/modules/webkitport_unittest.py:
30
31 2009-12-05  Adam Barth  <abarth@webkit.org>
32
33         Reviewed by Eric Seidel.
34
35         Move update-webkit into BuildSteps
36         https://bugs.webkit.org/show_bug.cgi?id=32181
37
38         We need to move update-webkit out of SCM.py because SCM isn't supposed to know
39         that WebKit exists.  The proper place for the knowledge of the existence of
40         update-webkit is in WebKitPort because some ports have specialized update
41         scripts (analogous to build-webkit).
42
43         * Scripts/modules/buildsteps.py:
44         * Scripts/modules/commands/download.py:
45         * Scripts/modules/landingsequence.py:
46         * Scripts/modules/scm.py:
47         * Scripts/modules/webkitport.py:
48
49 2009-12-05  Adam Barth  <abarth@webkit.org>
50
51         Reviewed by Eric Seidel.
52
53         update-webkit should call git svn rebase and resolve-ChangeLogs -f
54         https://bugs.webkit.org/show_bug.cgi?id=27162
55
56         Teach update-webkit about Git.  I didn't add the call to
57         resolve-ChangeLogs -f because sometimes that script goes bananas.  We
58         can iterate from here, however.
59
60         * Scripts/update-webkit:
61
62 2009-12-04  Yael Aharon  <yael.aharon@nokia.com>
63
64         Unreviewed build fix.
65
66         [Qt] build fix after r51634 removed unused QBoxLayout include which included limits.h.
67
68         * DumpRenderTree/qt/DumpRenderTree.cpp:
69
70 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
71
72         Reviewed by Adam Treat.
73
74         Add some missing methods for showing and hiding the
75         Web Inspector.
76
77         * DumpRenderTree/qt/DumpRenderTree.cpp:
78         (WebCore::WebPage::WebPage):
79         (WebCore::WebPage::~WebPage):
80         (WebCore::WebPage::webInspector):
81         * DumpRenderTree/qt/DumpRenderTree.h:
82         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
83         (LayoutTestController::showWebInspector):
84         (LayoutTestController::hideWebInspector):
85         * DumpRenderTree/qt/LayoutTestControllerQt.h:
86
87 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
88
89         Reviewed by Adam Treat.
90
91         Implement the setAllowUniversalAccessFromFileURLs method
92         for the Qt LayoutTestController.
93
94         * DumpRenderTree/qt/DumpRenderTree.cpp:
95         (WebCore::WebPage::resetSettings):
96         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
97         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
98         * DumpRenderTree/qt/LayoutTestControllerQt.h:
99
100 2009-12-04  Chris Fleizach  <cfleizach@apple.com>
101
102         Reviewed by Darin Adler.
103
104         REGRESSION: AX: buttons now extremely repetitive
105         https://bugs.webkit.org/show_bug.cgi?id=32164
106
107         * DumpRenderTree/AccessibilityUIElement.cpp:
108         (isAttributeSupportedCallback):
109         (AccessibilityUIElement::getJSClass):
110         * DumpRenderTree/AccessibilityUIElement.h:
111         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
112         (AccessibilityUIElement::isAttributeSupported):
113         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
114         (AccessibilityUIElement::isAttributeSupported):
115         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
116         (AccessibilityUIElement::isAttributeSupported):
117
118 2009-12-03  Shinichiro Hamaji  <hamaji@chromium.org>
119
120         Reviewed by David Levin.
121
122         check-webkit-style should check for camelCase variable names
123         https://bugs.webkit.org/show_bug.cgi?id=32051
124
125         * Scripts/modules/cpp_style.py:
126         * Scripts/modules/cpp_style_unittest.py:
127
128 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
129
130         Reviewed by Eric Seidel.
131
132         AX: VO just says "term" on many web sites
133         https://bugs.webkit.org/show_bug.cgi?id=32139
134
135         * DumpRenderTree/AccessibilityUIElement.cpp:
136         (getRoleDescriptionCallback):
137         (AccessibilityUIElement::getJSClass):
138         * DumpRenderTree/AccessibilityUIElement.h:
139         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
140         (AccessibilityUIElement::roleDescription):
141         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
142         (AccessibilityUIElement::roleDescription):
143         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
144         (AccessibilityUIElement::roleDescription):
145
146 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
147
148         Reviewed by Beth Dakin.
149
150         Implement WAI-ARIA scrollbar role and related property aria-orientation
151         https://bugs.webkit.org/show_bug.cgi?id=32126
152
153         * DumpRenderTree/AccessibilityUIElement.cpp:
154         (getOrientationCallback):
155         (AccessibilityUIElement::getJSClass):
156         * DumpRenderTree/AccessibilityUIElement.h:
157         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
158         (AccessibilityUIElement::orientation):
159         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
160         (AccessibilityUIElement::orientation):
161         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
162         (AccessibilityUIElement::orientation):
163
164 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
165
166         Reviewed by Adam Roben.
167
168         Minor correction to r51663.
169
170         * DumpRenderTree/win/DumpRenderTree.cpp:
171         (addQTDirToPATH):
172             GetEnvironmentVariable -> GetEnvironmentVariableW.
173
174 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
175
176         Reviewed by Adam Roben.
177
178         ~96 regression tests fail when using QuickTime 7.6 (they pass with QuickTime 7.3)
179         https://bugs.webkit.org/show_bug.cgi?id=30256
180
181         Add the QuickTime dll directory to the PATH environment variable so
182         inialization can succeed.
183
184         * DumpRenderTree/win/DumpRenderTree.cpp:
185         (addQTDirToPATH):
186         (initialize):
187
188 2009-12-03  Shu Chang  <Chang.Shu@nokia.com>
189
190         Reviewed by Kenneth Rohde Christiansen.
191
192         [Qt] After revision 32643, sender() is of type QWebPage instead of QWebFrame.
193
194         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
195         (LayoutTestController::maybeDump):
196
197 2009-12-03  Yuzo Fujishima  <yuzo@google.com>
198
199         Reviewed by Eric Seidel.
200
201         Update pywebsocket to 0.4.3
202         This version logs friendlier and higher-level messages in WARN level, which is used for LayoutTests.
203         Stack trace is logged now in INFO level.
204         https://bugs.webkit.org/show_bug.cgi?id=32097
205
206         * pywebsocket/mod_pywebsocket/dispatch.py:
207         * pywebsocket/mod_pywebsocket/msgutil.py:
208         * pywebsocket/mod_pywebsocket/standalone.py:
209         * pywebsocket/mod_pywebsocket/util.py:
210         * pywebsocket/setup.py:
211         * pywebsocket/test/test_dispatch.py:
212         * pywebsocket/test/test_util.py:
213
214 2009-12-03  Sam Weinig  <sam@webkit.org>
215
216         Reviewed by Gavin Barraclough.
217
218         Fix JSClassRef leak.
219
220         * DumpRenderTree/AccessibilityController.cpp:
221         (AccessibilityController::makeWindowObject):
222         * DumpRenderTree/GCController.cpp:
223         (GCController::makeWindowObject):
224         * DumpRenderTree/LayoutTestController.cpp:
225         (LayoutTestController::makeWindowObject):
226
227 2009-12-03  Brady Eidson  <beidson@apple.com>
228
229         Reviewed by Sam Weinig.
230
231         <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
232
233         Keep DRT-win building...
234
235         * DumpRenderTree/win/FrameLoadDelegate.h:
236         (FrameLoadDelegate::didPushStateWithinPageForFrame):
237         (FrameLoadDelegate::didReplaceStateWithinPageForFrame):
238         (FrameLoadDelegate::didPopStateWithinPageForFrame):
239
240 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
241
242         Unreviewed build fix.
243
244         [Qt] ARM-Linux build fix after r51634 removed unused QBoxLayout include which included limits.h on ARM.
245
246         * DumpRenderTree/qt/DumpRenderTree.cpp:
247
248 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
249
250         Reviewed by Kenneth Rohde Christiansen.
251
252         [Qt] Refactor DRT to not crash on tests which open child windows from javascript.
253         Prevent DRT from showing the main view if these childs get deleted.
254         This fixes https://bugs.webkit.org/show_bug.cgi?id=31591.
255
256         * DumpRenderTree/qt/DumpRenderTree.cpp:
257         (WebCore::WebPage::WebPage):
258         (WebCore::DumpRenderTree::DumpRenderTree):
259         (WebCore::DumpRenderTree::~DumpRenderTree):
260         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
261         (WebCore::DumpRenderTree::open):
262         (WebCore::DumpRenderTree::closeRemainingWindows):
263         (WebCore::DumpRenderTree::createWindow):
264         (WebCore::DumpRenderTree::windowCount):
265         * DumpRenderTree/qt/DumpRenderTree.h:
266
267 2009-12-02  Eric Seidel  <eric@webkit.org>
268
269         Reviewed by Adam Barth.
270
271         REGRESSION(51595): commit-queue is throwing exceptions
272         https://bugs.webkit.org/show_bug.cgi?id=32083
273
274         * Scripts/modules/commands/queues.py:
275          - Don't use default value of [] as it ends up getting shared.
276          - Make log_progress accept arrays of ints as well as strings.
277          - Return an exit code from execute()
278         * Scripts/modules/commands/queues_unittest.py: Added.
279          - Test to make sure log_progress will accept ints.
280          - Test to make sure run_bugzilla_tool will accept ints.
281         * Scripts/modules/workqueue.py:
282          - Print the stack trace on unexpected exceptions for easier debugging.
283         * Scripts/run-webkit-unittests:
284          - Add queues_unittest.
285
286         * Scripts/modules/commands/queues.py:
287         * Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py.
288         * Scripts/modules/mock_bugzillatool.py:
289         * Scripts/modules/workqueue.py:
290         * Scripts/run-webkit-unittests:
291
292 2009-12-02  David Levin  <levin@chromium.org>
293
294         Reviewed by Adam Barth.
295
296         check-webkit-style is too noisy about namespace indenting issues.
297         https://bugs.webkit.org/show_bug.cgi?id=32096
298
299         * Scripts/modules/cpp_style.py:
300         Added a _FileState object to be able to track file level information. In this
301         case, it simply tracks whether the error has already been given, so that it isn't
302         done again.
303         * Scripts/modules/cpp_style_unittest.py:
304         Modified test cases to pass in the _FileState object and fix a test that expected
305         to see the namespace error twice (now it only occurs once). No new tests because
306         existing tests cover the change in functionality.
307
308 2009-12-01  Kevin Ollivier  <kevino@theolliviers.com>
309
310         Reviewed by Eric Seidel.
311
312         [wx] Get DumpRenderTree building after waf switch.
313         
314         https://bugs.webkit.org/show_bug.cgi?id=32041
315
316         * DumpRenderTree/wscript: Added.
317         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
318         (LayoutTestController::setTimelineProfilingEnabled):
319         (LayoutTestController::evaluateScriptInIsolatedWorld):
320         (LayoutTestController::disableImageLoading):
321         (LayoutTestController::whiteListAccessFromOrigin):
322         (LayoutTestController::counterValueForElementById):
323         * Scripts/build-webkit:
324
325 2009-12-02  Adam Barth  <abarth@webkit.org>
326
327         Reviewed by Eric Seidel.
328
329         [bzt] build-attachment shouldn't check whether the builders are red
330         https://bugs.webkit.org/show_bug.cgi?id=32062
331
332         build-attachment doesn't touch the remote repository, so there isn't a
333         need to hold off when the builders are red.
334
335         * Scripts/modules/commands/download.py:
336         * Scripts/modules/landingsequence.py:
337
338 2009-12-02  Eric Seidel  <eric@webkit.org>
339
340         Reviewed by Adam Barth.
341
342         REGRESSION(51590): style-queue and build-queue think their empty when they are not
343         https://bugs.webkit.org/show_bug.cgi?id=32061
344
345         * Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings.
346         * Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints.
347
348 2009-12-02  Eric Seidel  <eric@webkit.org>
349
350         Reviewed by Adam Barth.
351
352         build-queue is throwing exceptions and complaining about
353         lack of --no-update on build-attachment.  Make it stop.
354
355         * Scripts/modules/buildsteps.py:
356         * Scripts/modules/commands/download.py:
357
358 2009-12-02  Adam Barth  <abarth@webkit.org>
359
360         Unreviewed "build" fix.  Forgot to declare my variables.  :(
361
362         * QueueStatusServer/queue_status.py:
363
364 2009-12-02  Adam Barth  <abarth@webkit.org>
365
366         Reviewed by Eric Seidel.
367
368         [bzt] Implement status bubble view
369         https://bugs.webkit.org/show_bug.cgi?id=32057
370
371         The status bubble is a compact representation of the queue status for a
372         given patch.  This will eventually help us reduce the comment spam from
373         the queues.
374
375         * QueueStatusServer/index.html: Added HTML5 doctype for sanity.
376         * QueueStatusServer/queue_status.py:
377         * QueueStatusServer/status_bubble.html: Added.
378
379 2009-12-02  Eric Seidel  <eric@webkit.org>
380
381         Reviewed by Adam Barth.
382
383         trim commands/*.py includes now that commands are unit tested
384         https://bugs.webkit.org/show_bug.cgi?id=32056
385
386         In the course of ensuring that the unit tests still
387         passed after this change, I had to actually make them
388         pass in the first place.
389
390         * Scripts/modules/bugzilla.py:
391          - Fix _parse_attachment_ids_request_query to return ints instead of strings.
392         * Scripts/modules/commands/download.py: Remove unneeded imports.
393         * Scripts/modules/commands/queries.py: Ditto.
394         * Scripts/modules/commands/queues.py: Ditto.
395         * Scripts/modules/commands/upload.py: Ditto.
396         * Scripts/modules/scm_unittest.py:
397          - Fix to expect the \n after the path since echo adds an \n.
398
399 2009-12-01  Yaar Schnitman  <yaar@chromium.org>
400
401         build-webkit: Remove flex,bison,gperf check for chromium
402         https://bugs.webkit.org/show_bug.cgi?id=32043
403
404         * Scripts/webkitdirs.pm:
405
406 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
407
408         Build fixage for Windows/GTK for DumpRenderTree.
409
410         WAI-ARIA: implement support for ARIA drag and drop
411         https://bugs.webkit.org/show_bug.cgi?id=32007
412
413         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
414         (AccessibilityUIElement::ariaIsGrabbed):
415         (AccessibilityUIElement::ariaDropEffects):
416         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
417         (AccessibilityUIElement::ariaIsGrabbed):
418         (AccessibilityUIElement::ariaDropEffects):
419
420 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
421
422         Reviewed by Darin Adler.
423
424         WAI-ARIA: implement support for ARIA drag and drop
425         https://bugs.webkit.org/show_bug.cgi?id=32007
426
427         * DumpRenderTree/AccessibilityUIElement.cpp:
428         (getARIADropEffectsCallback):
429         (getARIAIsGrabbedCallback):
430         (AccessibilityUIElement::getJSClass):
431         * DumpRenderTree/AccessibilityUIElement.h:
432         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
433         (AccessibilityUIElement::ariaIsGrabbed):
434         (AccessibilityUIElement::ariaDropEffects):
435
436 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
437
438         Not reviewed. GTK DRT try 2.
439
440         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
441         (LayoutTestController::sampleSVGAnimationForElementAtTime):
442
443 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
444
445         Not reviewed. Try to fix gtk DRT build.
446
447         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
448
449 2009-12-01  David Levin  <levin@chromium.org>
450
451         Reviewed by Eric Seidel.
452
453         check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
454         https://bugs.webkit.org/show_bug.cgi?id=32033
455
456         * Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find
457                                         instead of startswith.
458         * Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior.
459
460 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
461
462         Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well.
463
464         * DumpRenderTree/qt/LayoutTestControllerQt.h: Update old function signature.
465
466 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
467
468         Reviewed by Simon Fraser.
469
470         Add SVG animation test framework with 'snapshot' functionality
471         https://bugs.webkit.org/show_bug.cgi?id=31897
472
473         Add new 'sampleSVGAnimationForElementAtTime' DRT method,
474         used by the new SVG animation testing framework, implemented
475         for qt/gtk/win/mac.
476
477         * DumpRenderTree/LayoutTestController.cpp:
478         (sampleSVGAnimationForElementAtTimeCallback):
479         (LayoutTestController::staticFunctions):
480         * DumpRenderTree/LayoutTestController.h:
481         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
482         (LayoutTestController::sampleSVGAnimationForElementAtTime):
483         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
484         (LayoutTestController::sampleSVGAnimationForElementAtTime):
485         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
486         (LayoutTestController::sampleSVGAnimationForElementAtTime):
487         * DumpRenderTree/qt/LayoutTestControllerQt.h:
488         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
489         (LayoutTestController::sampleSVGAnimationForElementAtTime):
490         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
491         (LayoutTestController::sampleSVGAnimationForElementAtTime):
492
493 2009-12-01  Adam Roben  <aroben@apple.com>
494
495         Remove user content before running each test on Windows
496
497         Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows
498
499         Reviewed by Alexey Proskuryakov.
500
501         * DumpRenderTree/win/DumpRenderTree.cpp:
502         (resetWebViewToConsistentStateBeforeTesting): Remove all user content
503         before each test, which matches Mac.
504
505 2009-12-01  Yuzo Fujishima  <yuzo@google.com>
506
507         Reviewed by Alexey Proskuryakov.
508
509         Make pywebsocket log errors to a file
510         https://bugs.webkit.org/show_bug.cgi?id=31604
511
512         * Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory
513         (by passing the path to the server via a recently added -l option).
514
515 2009-12-01  Adam Roben  <aroben@apple.com>
516
517         Fix tests that use the TestNetscapePlugin in Debug_Internal builds
518
519         Reviewed by Ada Chan.
520
521         Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
522         TestNetscapePlugin fail in Debug_Internal builds
523
524         * DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin
525         directory in Debug and Debug_All builds, but not in Debug_Internal
526         builds.
527
528 2009-12-01  Adam Roben  <aroben@apple.com>
529
530         Re-enable DRT's watchdog timer on Windows
531
532         It was accidentally disabled in r50907.
533
534         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
535         (LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
536         into an if condition.
537
538 2009-12-01  Adam Barth  <abarth@webkit.org>
539
540         Reviewed by Eric Seidel.
541
542         check-webkit-style complains about #imports with / in them
543         https://bugs.webkit.org/show_bug.cgi?id=32022
544
545         We need to exclude #import directives in addition to #include from the
546         binary operator whitespace checks.
547
548         * Scripts/modules/cpp_style.py:
549         * Scripts/modules/cpp_style_unittest.py:
550
551 2009-11-30  Adam Barth  <abarth@webkit.org>
552
553         Reviewed by Eric Seidel.
554
555         check-webkit-style is slightly too verbose
556         https://bugs.webkit.org/show_bug.cgi?id=32010
557
558         check-webkit-style prints out a bunch of "done" lines that seem redundant,
559         especially for the style-queue.
560
561         * Scripts/modules/cpp_style.py:
562
563 2009-11-30  Alejandro G. Castro  <alex@igalia.com>
564
565         Reviewed by Eric Seidel.
566
567         [GTK] Moved the functions that are closing the result log of the
568         tests to the last line of the runTest function, this avoids
569         reporting crashes in the wrong test if there is a problem when
570         reseting the state after the test.
571
572         * DumpRenderTree/gtk/DumpRenderTree.cpp:
573         (dump):
574         (runTest):
575
576 2009-11-30  Sam Weinig  <sam@webkit.org>
577
578         Reviewed by Geoffrey Garen.
579
580         Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
581         fast/js/date-proto-generic-invocation breaks another test
582
583         Don't cache JSClassRefs, a change to the prototype chain will
584         last between tests.
585
586         * DumpRenderTree/AccessibilityController.cpp:
587         (AccessibilityController::getJSClass):
588         * DumpRenderTree/GCController.cpp:
589         (GCController::getJSClass):
590         * DumpRenderTree/GCController.h:
591         * DumpRenderTree/LayoutTestController.cpp:
592         (LayoutTestController::getJSClass):
593
594 2009-11-30  Yuzo Fujishima  <yuzo@google.com>
595
596         Reviewed by Alexey Proskuryakov.
597
598         Update pywebsocket to 0.4.2.1.
599         This is to fix a bug that some messages are logged to stderr even when the log file is specified.
600         https://bugs.webkit.org/show_bug.cgi?id=31976
601
602         * pywebsocket/mod_pywebsocket/standalone.py:
603         * pywebsocket/setup.py:
604
605 2009-11-30  Adam Barth  <abarth@webkit.org>
606
607         Reviewed by Eric Seidel.
608
609         [bzt] Generate pass messages for style-queue
610         https://bugs.webkit.org/show_bug.cgi?id=31995
611
612         With this change, the style-queue posts "pass" messages to bugs as
613         well.  Also, added more information to the state store w.r.t. passing
614         and failing.
615
616         * Scripts/modules/commands/queues.py:
617         * Scripts/modules/patchcollection.py:
618
619 2009-11-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
620
621         Reviewed by Simon Fraser.
622
623         Check for WEBKIT_TESTFONTS environment variable in
624         run-webkit-tests, for GTK+, to have a more prominent error
625         message.
626
627         * Scripts/run-webkit-tests:
628
629 2009-11-30  Yaar Schnitman  <yaar@chromium.org>
630
631         Reviewed by Dimitri Glazkov.
632
633         update-webkit --chromium forces gclient sync
634
635         https://bugs.webkit.org/show_bug.cgi?id=31967
636
637         * Scripts/update-webkit-chromium:
638
639 2009-11-29  Eric Seidel  <eric@webkit.org>
640
641         Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.
642
643         * Scripts/modules/committers.py:
644
645 2009-11-29  Eric Seidel  <eric@webkit.org>
646
647         No review, just adding missing svn property.
648
649         Set svn:executable property on new scripts.
650         These were added by commit-queue commits, but the executable
651         property was lost due to a bug in svn-apply:
652         https://bugs.webkit.org/show_bug.cgi?id=27204
653
654         * Scripts/update-webkit-chromium: Added property svn:executable.
655         * Scripts/validate-committer-lists: Added property svn:executable.
656
657 2009-11-29  Eric Seidel  <eric@webkit.org>
658
659         Reviewed by Adam Barth.
660
661         Need a way to validate that committers.py includes all committers/reviewers
662         https://bugs.webkit.org/show_bug.cgi?id=30970
663
664         Add a script which knows how to compare our public committer/reviewer
665         lists and show discrepancies between them.
666
667         Validates mailing lists vs. committers.py:
668         - committers.py committers missing from webkit-committers@lists
669         - webkit-committers@lists members missing from committers.py
670         - committers.py reviewers missing from webkit-reviewers@lists
671         - webkit-reviewers@lists members missing from committers.py
672         - webkit-reviewers@lists members missing from committers.py reviewer list
673
674         Validates committers.py vs. trunk/ SVN history:
675         - committers who have not committed in over a year
676         - SVN committers missing from committers.py
677         - committers.py members who have no record in SVN.
678
679         All of these lists still show "false positives" until a few more committers.py updates are made, like:
680         https://bugs.webkit.org/show_bug.cgi?id=31366
681
682         * Scripts/validate-committer-lists: Added.
683
684 2009-11-28  Adam Barth  <abarth@webkit.org>
685
686         Reviewed by Eric Seidel.
687
688         [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
689         https://bugs.webkit.org/show_bug.cgi?id=31950
690
691         Now we cache the last status that we get back from QueueStatusServer.
692         Eventually we'll have to do something more fancy if we want to support
693         a "try again" button on QueueStatusServer, but we can cross that bridge
694         when we come to it.
695
696         * Scripts/modules/patchcollection.py:
697
698 2009-11-28  Adam Barth  <abarth@webkit.org>
699
700         Reviewed by Eric Seidel.
701
702         StyleQueue scans ~100 bug pages every 5 minutes
703         https://bugs.webkit.org/show_bug.cgi?id=31947
704
705         Instead of getting the pending-review attachment ids by scanning each
706         bug (which results in a network request), we should just get them all
707         from webkit.org/pending-review in one shot.
708
709         * Scripts/modules/bugzilla.py:
710         * Scripts/modules/bugzilla_unittest.py:
711         * Scripts/modules/commands/queries.py:
712         * Scripts/modules/commands/queries_unittest.py:
713         * Scripts/modules/commands/queues.py:
714         * Scripts/modules/mock_bugzillatool.py:
715         * Scripts/modules/patchcollection.py:
716
717 2009-11-28  Adam Barth  <abarth@webkit.org>
718
719         Reviewed by Eric Seidel.
720
721         [bzt] CC webkit-bot-watchers whenever the bots touch bugs
722         https://bugs.webkit.org/show_bug.cgi?id=31952
723
724         The mailing list is open for anyone to subscribe.
725
726         * Scripts/modules/bugzilla.py:
727         * Scripts/modules/commands/queues.py:
728
729 2009-11-28  Adam Barth  <abarth@webkit.org>
730
731         Reviewed by Eric Seidel.
732
733         [bzt] style-queue should report style errors to bugzilla
734         https://bugs.webkit.org/show_bug.cgi?id=31945
735
736         Currently, we're just logging the style errors locally.  With this
737         patch we'll actually log the errors to bugzilla.  Note: I plan to run
738         with the "local-only" logging during development.
739
740         * Scripts/modules/commands/queues.py:
741         * Scripts/modules/scm.py:
742
743 2009-11-28  Adam Barth  <abarth@webkit.org>
744
745         Reviewed by Eric Seidel.
746
747         [bzt] style-queue shouldn't reject patches from the commit-queue
748         https://bugs.webkit.org/show_bug.cgi?id=31944
749
750         Currently the style-queue subprocess gets confused and thinks its the
751         commit-queue.  If the patch has an error, it rejects it from the
752         commit-queue.  Instead, we should have style-queue specific logic.
753         This patch doesn't add that logic, but it gives us a callback we can
754         use to add that logic.
755
756         * Scripts/modules/buildsteps.py:
757         * Scripts/modules/commands/queues.py:
758         * Scripts/modules/landingsequence.py:
759
760 2009-11-27  Adam Barth  <abarth@webkit.org>
761
762         Rubber stamped by Eric Seidel.
763
764         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
765
766         * CommitQueueStatus: Removed.
767         * CommitQueueStatus/app.yaml: Removed.
768         * CommitQueueStatus/filters: Removed.
769         * CommitQueueStatus/filters/__init__.py: Removed.
770         * CommitQueueStatus/filters/webkit_extras.py: Removed.
771         * CommitQueueStatus/index.html: Removed.
772         * CommitQueueStatus/index.yaml: Removed.
773         * CommitQueueStatus/queue_status.py: Removed.
774         * CommitQueueStatus/stylesheets: Removed.
775         * CommitQueueStatus/stylesheets/main.css: Removed.
776         * CommitQueueStatus/update_status.html: Removed.
777         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
778
779 2009-11-27  Adam Barth  <abarth@webkit.org>
780
781         Reviewed by Eric Seidel.
782
783         style-queue should only process each patch once
784         https://bugs.webkit.org/show_bug.cgi?id=31939
785
786         Actually address reviewer comments!
787
788         * Scripts/bugzilla-tool:
789
790 2009-11-27  Adam Barth  <abarth@webkit.org>
791
792         Reviewed by Eric Seidel.
793
794         [bzt] style-queue fails to apply a bunch of patches for no reason
795         https://bugs.webkit.org/show_bug.cgi?id=31942
796
797         By passing --non-interactive to check-style, we convince check-style
798         to pass --force to svn-apply, which lets it apply more patches.
799
800         * Scripts/modules/commands/queues.py:
801
802 2009-11-27  Adam Barth  <abarth@webkit.org>
803
804         Reviewed by Eric Seidel.
805
806         [bzt] Support --status-host in style-queue
807         https://bugs.webkit.org/show_bug.cgi?id=31941
808
809         * Scripts/modules/commands/queues.py:
810         * Scripts/modules/statusbot.py:
811
812 2009-11-27  Adam Barth  <abarth@webkit.org>
813
814         Reviewed by Eric Seidel.
815
816         style-queue should only process each patch once
817         https://bugs.webkit.org/show_bug.cgi?id=31939
818
819         Before processing a patch, the try-queues now ask the web service
820         whether they have already processed the patch.  This is an initial cut
821         of this functionality.  I expect we're make it richer over time.
822
823         * Scripts/bugzilla-tool:
824         * Scripts/modules/commands/queues.py:
825         * Scripts/modules/patchcollection.py:
826
827 2009-11-27  Adam Barth  <abarth@webkit.org>
828
829         Reviewed by Eric Seidel.
830
831         PatchStatus does not return status
832         https://bugs.webkit.org/show_bug.cgi?id=31938
833
834         We need to parse attachment_id as an int.  Otherwise, we can't find
835         anything in the datastore.
836
837         * CommitQueueStatus/queue_status.py:
838
839 2009-11-27  Adam Barth  <abarth@webkit.org>
840
841         Reviewed by Eric Seidel.
842
843         Make commit-queue status not throw an exception where there is not
844         status
845         https://bugs.webkit.org/show_bug.cgi?id=31936
846
847         We need to actually fetch the results of the query to see what's in the
848         datastore.
849
850         * CommitQueueStatus/queue_status.py:
851
852 2009-11-27  Adam Barth  <abarth@webkit.org>
853
854         Reviewed by Eric Seidel.
855
856         [bzt] unit test ApplyPatches and ApplyAttachment
857         https://bugs.webkit.org/show_bug.cgi?id=31935
858
859         * Scripts/modules/commands/download.py:
860         * Scripts/modules/commands/download_unittest.py:
861
862 2009-11-27  Adam Barth  <abarth@webkit.org>
863
864         Reviewed by Eric Seidel.
865
866         [bzt] Unit test download commands
867         https://bugs.webkit.org/show_bug.cgi?id=31923
868
869         Adds download_unittest and fixes a bug found while testing.
870
871         * Scripts/modules/commands/commandtest.py:
872         * Scripts/modules/commands/download.py:
873             Fixed a bug where we'd throw an error because [].append returns
874             None.
875         * Scripts/modules/commands/download_unittest.py: Added.
876         * Scripts/modules/mock_bugzillatool.py:
877         * Scripts/run-webkit-unittests:
878
879 2009-11-27  Adam Barth  <abarth@webkit.org>
880
881         Unreviewed "build" fix found while writing unit tests.
882
883         * Scripts/modules/commands/download.py:
884
885 2009-11-27  Adam Barth  <abarth@webkit.org>
886
887         Reviewed by Eric Seidel.
888
889         [bzt] Kill WebKitLandingScripts
890         https://bugs.webkit.org/show_bug.cgi?id=31904
891
892         Step 6: Kill the rest.
893
894         * Scripts/modules/buildsteps.py:
895         * Scripts/modules/commands/download.py:
896         * Scripts/modules/commands/queries.py:
897         * Scripts/modules/commands/upload.py:
898         * Scripts/modules/landingsequence.py:
899         * Scripts/modules/scm.py:
900         * Scripts/modules/webkitlandingscripts.py: Removed.
901
902 2009-11-27  Adam Barth  <abarth@webkit.org>
903
904         Reviewed by Eric Seidel.
905
906         [bzt] Unit test upload commands
907         https://bugs.webkit.org/show_bug.cgi?id=31903
908
909         Adds unit tests for all but two of the upload commands.  The two
910         remaining ones are more difficult.  I'll return to them later.  The
911         goal of these tests is just to run the commands.  We can test more
912         detailed behavior later.
913
914         * Scripts/modules/commands/commandtest.py:
915         * Scripts/modules/commands/upload.py:
916         * Scripts/modules/commands/upload_unittest.py:
917         * Scripts/modules/mock.py: Added.
918         * Scripts/modules/mock_bugzillatool.py:
919
920 2009-11-26  Adam Barth  <abarth@webkit.org>
921
922         Reviewed by Eric Seidel.
923
924         [bzt] Kill WebKitLandingScripts
925         https://bugs.webkit.org/show_bug.cgi?id=31904
926
927         Step 5: Kill run_and_throw_if_fail.
928
929         * Scripts/modules/buildsteps.py:
930         * Scripts/modules/processutils.py: Added.
931         * Scripts/modules/webkitlandingscripts.py:
932
933 2009-11-26  Adam Barth  <abarth@webkit.org>
934
935         Reviewed by Eric Seidel.
936
937         [bzt] Kill WebKitLandingScripts
938         https://bugs.webkit.org/show_bug.cgi?id=31904
939
940         Step 4: Kill run_webkit_script.
941
942         * Scripts/modules/buildsteps.py:
943         * Scripts/modules/commands/download.py:
944         * Scripts/modules/webkitlandingscripts.py:
945
946 2009-11-26  Adam Barth  <abarth@webkit.org>
947
948         Reviewed by Eric Seidel.
949
950         [bzt] Kill WebKitLandingScripts
951         https://bugs.webkit.org/show_bug.cgi?id=31904
952
953         Step 3: Kill build_webkit.
954
955         * Scripts/modules/buildsteps.py:
956         * Scripts/modules/landingsequence.py:
957         * Scripts/modules/webkitlandingscripts.py:
958
959 2009-11-26  Adam Barth  <abarth@webkit.org>
960
961         Reviewed by Eric Seidel.
962
963         [bzt] Kill WebKitLandingScripts
964         https://bugs.webkit.org/show_bug.cgi?id=31904
965
966         Step 2: Kill ensure_builders_are_green.
967
968         * Scripts/modules/buildsteps.py:
969         * Scripts/modules/commands/download.py:
970         * Scripts/modules/landingsequence.py:
971         * Scripts/modules/webkitlandingscripts.py:
972
973 2009-11-26  Adam Barth  <abarth@webkit.org>
974
975         Reviewed by Eric Seidel.
976
977         [bzt] Kill WebKitLandingScripts
978         https://bugs.webkit.org/show_bug.cgi?id=31904
979
980         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
981
982         * Scripts/bugzilla-tool:
983         * Scripts/modules/buildsteps.py: Added.
984         * Scripts/modules/commands/download.py:
985         * Scripts/modules/landingsequence.py:
986         * Scripts/modules/webkitlandingscripts.py:
987
988 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
989
990         Reviewed by Adam Barth.
991
992         Remove directory prefixes from linux commands
993
994         SCM unittests can cause errors on some systems if we use absolute reference to
995         the commands, so directory prefixes have been removed.
996
997         * Scripts/modules/scm_unittest.py:
998
999 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
1000
1001         Reviewed by Kenneth Rohde Christiansen.
1002
1003         Link DumpRenderTree to the Qt Ui Tools
1004         https://bugs.webkit.org/show_bug.cgi?id=31203
1005
1006         Implement QWebPage::createPlugin using the Qt Ui Tools
1007         to be able to create classes like QProgressBar from within
1008         the <object></object> tags This is required for the
1009         new automatic test of Qt Plugins.
1010
1011         * DumpRenderTree/qt/DumpRenderTree.cpp:
1012         (WebCore::WebPage::createPlugin):
1013         * DumpRenderTree/qt/DumpRenderTree.h:
1014         * DumpRenderTree/qt/DumpRenderTree.pro:
1015
1016 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
1017
1018         Reviewed by Eric Seidel.
1019
1020         Update pywebsocket to 0.4.2
1021
1022         Update pywebsocket to 0.4.2
1023         https://bugs.webkit.org/show_bug.cgi?id=31861
1024
1025         * pywebsocket/example/echo_client.py:
1026         * pywebsocket/example/echo_wsh.py:
1027         * pywebsocket/mod_pywebsocket/__init__.py:
1028         * pywebsocket/mod_pywebsocket/dispatch.py:
1029         * pywebsocket/mod_pywebsocket/msgutil.py:
1030         * pywebsocket/mod_pywebsocket/standalone.py:
1031         * pywebsocket/setup.py:
1032         * pywebsocket/test/test_dispatch.py:
1033         * pywebsocket/test/test_msgutil.py:
1034
1035 2009-11-25  Adam Barth  <abarth@webkit.org>
1036
1037         Reviewed by Eric Seidel.
1038
1039         Add unit test for mark-fixed
1040         https://bugs.webkit.org/show_bug.cgi?id=31896
1041
1042         * Scripts/modules/commands/commandtest.py: Added.
1043         * Scripts/modules/commands/queries_unittest.py:
1044         * Scripts/modules/commands/upload_unittest.py: Added.
1045         * Scripts/modules/mock_bugzillatool.py:
1046         * Scripts/run-webkit-unittests:
1047
1048 2009-11-25  Adam Barth  <abarth@webkit.org>
1049
1050         Reviewed by Eric Seidel.
1051
1052         bugzilla-tool should have a mark-fixed command
1053         https://bugs.webkit.org/show_bug.cgi?id=31853
1054
1055         Pretty simple stuff.
1056
1057         * Scripts/modules/commands/upload.py:
1058
1059 2009-11-25  Eric Seidel  <eric@webkit.org>
1060
1061         Reviewed by Adam Barth.
1062
1063         'bugzilla-tool help' should only show common commands like how 'git help' does
1064         https://bugs.webkit.org/show_bug.cgi?id=31772
1065
1066         I also took this opportunity to make 'help' a real Command.
1067         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
1068
1069         * Scripts/bugzilla-tool:
1070          - change should_show_command_help to should_show_in_main_help
1071         * Scripts/modules/commands/download.py:
1072          - Mark commands as being shown in main help or not.
1073          - show_in_main_help = False is not required (default is false),
1074            but it seemed to make the commands more self-documenting.
1075         * Scripts/modules/commands/queries.py: ditto
1076         * Scripts/modules/commands/queues.py: ditto
1077         * Scripts/modules/commands/upload.py: ditto
1078         * Scripts/modules/multicommandtool.py:
1079          - Make Command hold a pointer to tool in self.tool.  Most Command
1080            subclasses do not take advantage of this yet, but it was required
1081            for HelpCommand to be able to reach the tool from _help_epilog().
1082          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
1083          - Move MultiCommandTool._help_epilog to Command._help_epilog
1084          - Move "help" logic into HelpCommand.execute()
1085          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
1086         * Scripts/modules/multicommandtool_unittest.py:
1087          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
1088
1089 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
1090
1091         Reviewed by Dan Bernstein.
1092         
1093         Patch by Mark Rowe.
1094
1095         The buildbots are failing on Windows because when they were upgraded
1096         to 4.0.4, Apple Application Support was not in their path. Add it to
1097         the path to fix the buildots.
1098
1099         * Scripts/webkitdirs.pm:
1100
1101 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
1102
1103         Reviewed by David Kilzer.
1104
1105         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
1106         https://bugs.webkit.org/show_bug.cgi?id=31799
1107
1108         * Scripts/run-webkit-tests: Fixed.
1109
1110 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
1111
1112         Reviewed by Eric Seidel.
1113
1114         Change run_command to give back stderr by default
1115         https://bugs.webkit.org/show_bug.cgi?id=31734
1116
1117         Change run_command to give back stderr by default.
1118         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
1119         Change the related unittest call.
1120
1121         * Scripts/modules/scm.py:
1122         * Scripts/modules/scm_unittest.py:
1123
1124 2009-11-25  Eric Seidel  <eric@webkit.org>
1125
1126         Reviewed by Adam Barth.
1127
1128         Centralize required argument parsing in Command
1129         https://bugs.webkit.org/show_bug.cgi?id=31872
1130
1131         * Scripts/modules/commands/download.py: remove custom required arg message.
1132         * Scripts/modules/commands/upload.py: ditto.
1133         * Scripts/modules/multicommandtool.py:
1134          - Add _parse_required_arguments.
1135          - Pass program name off to OptionParser.
1136          - Add name() for access to tool name.
1137          - Add check_arguments_and_execute and make it return a return code.
1138          - Replace a couple uses of + with %.
1139         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
1140
1141 2009-11-25  Eric Seidel  <eric@webkit.org>
1142
1143         Reviewed by Adam Barth.
1144
1145         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
1146         https://bugs.webkit.org/show_bug.cgi?id=31870
1147
1148         * Scripts/modules/commands/queries_unittest.py: Use the new class.
1149         * Scripts/modules/multicommandtool_unittest.py: Ditto.
1150         * Scripts/modules/outputcapture.py: Added.
1151
1152 2009-11-24  Dmitry Titov  <dimich@chromium.org>
1153
1154         Reviewed by Eric Seidel.
1155
1156         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
1157         https://bugs.webkit.org/show_bug.cgi?id=31444
1158
1159         * Scripts/build-webkit:
1160
1161 2009-11-24  Chris Marrin  <cmarrin@apple.com>
1162
1163         Reviewed by Simon Fraser.
1164
1165         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
1166         https://bugs.webkit.org/show_bug.cgi?id=27314
1167         
1168         Now the script allows the directories with these tests to be included on all
1169         platforms but Mac, where they behave the same as always. For all other platforms
1170         the tests need to be excluded using the Skipped files, which is currently done
1171         for all platforms (including win since we're not turned on yet)
1172
1173         * Scripts/webkitdirs.pm:
1174
1175 2009-11-24  Eric Seidel  <eric@webkit.org>
1176
1177         Reviewed by Adam Barth.
1178
1179         queries_unittest.py should test command output
1180         https://bugs.webkit.org/show_bug.cgi?id=31845
1181
1182         * Scripts/modules/commands/queries_unittest.py:
1183          - Capture stdout and stderr and compare with expected strings.
1184
1185 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
1186
1187         No Review.
1188
1189         Fix spelling error ("depenedencies").
1190
1191         * Scripts/build-webkit:
1192
1193 2009-11-24  Mark Rowe  <mrowe@apple.com>
1194
1195         Land the configuration that includes the two debug GTK Linux builders.
1196
1197         * BuildSlaveSupport/build.webkit.org-config/config.json:
1198
1199 2009-11-24  David Kilzer  <ddkilzer@apple.com>
1200
1201         <http://webkit.org/b/31840> bisect-builds broke after r50080
1202
1203         Reviewed by Dan Bernstein.
1204
1205         * Scripts/bisect-builds:
1206         (mountAndRunNightly): Switched back to using backticks to run
1207         the hdiutil command since exec() will terminate the existing
1208         script, which is not what we want.  Store the output of
1209         File::Spec->devnull() in a variable for use in the hdiutil
1210         detach commands.
1211
1212 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1213
1214         Reviewed by Kenneth Rohde Christiansen.
1215
1216         Include "config.h" to meet Coding Style Guidelines
1217         https://bugs.webkit.org/show_bug.cgi?id=31792
1218
1219         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
1220         * DumpRenderTree/qt/jsobjects.cpp:
1221         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1222
1223 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1224
1225         Reviewed by Oliver Hunt.
1226
1227         Implement new required function to pass test we used to pass. This
1228         change is required since r51294.
1229
1230         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1231         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1232
1233 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
1234
1235         Reviewed by Kenneth Rohde Christiansen.
1236
1237         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
1238         https://bugs.webkit.org/show_bug.cgi?id=31775
1239
1240         LayoutTestController::dumpBackForwardList() should work with local URLs
1241         as well as with normal URLs (in http tests for instance).
1242         Currently it does not output the latter properly.
1243
1244         Unskip a bunch of passing http/navigation tests.
1245
1246         * DumpRenderTree/qt/DumpRenderTree.cpp:
1247         (WebCore::dumpHistoryItem):
1248
1249 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
1250
1251         Reviewed by Oliver Hunt.
1252
1253         ARIA: support aria-flowto
1254         https://bugs.webkit.org/show_bug.cgi?id=31762
1255
1256         * DumpRenderTree/AccessibilityUIElement.cpp:
1257         (ariaFlowToElementAtIndexCallback):
1258         (AccessibilityUIElement::getJSClass):
1259         * DumpRenderTree/AccessibilityUIElement.h:
1260         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1261         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1262         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1263         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1264         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1265         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1266
1267 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
1268
1269         Reviewed by Kenneth Christiansen.
1270
1271         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
1272         https://bugs.webkit.org/show_bug.cgi?id=31638
1273
1274         Unfreeze WorkQueue after each test execution.
1275
1276         * DumpRenderTree/qt/DumpRenderTree.cpp:
1277         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1278
1279 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
1280
1281         Reviewed by Adam Barth.
1282
1283         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
1284         for localhost and 127.0.0.1.
1285         https://bugs.webkit.org/show_bug.cgi?id=31783
1286
1287         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
1288
1289         * DumpRenderTree/qt/DumpRenderTree.cpp:
1290         (WebCore::NetworkAccessManager::NetworkAccessManager):
1291         (WebCore::NetworkAccessManager::sslErrorsEncountered):
1292         (WebCore::WebPage::WebPage):
1293         * DumpRenderTree/qt/DumpRenderTree.h:
1294
1295 2009-11-22  Chris Evans  <cevans@chromium.org>
1296
1297         Reviewed by Adam Barth.
1298
1299         Disable access to file:/// directory listings
1300         https://bugs.webkit.org/show_bug.cgi?id=31329
1301
1302         Implemented setAllowUniversalAccessFromFileURLs to support testing of
1303         file URL security.
1304
1305         * DumpRenderTree/LayoutTestController.cpp:
1306         (setAllowUniversalAccessFromFileURLsCallback):
1307         (LayoutTestController::staticFunctions):
1308         * DumpRenderTree/LayoutTestController.h:
1309         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1310         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1311         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1312         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1313         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1314         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1315         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1316         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1317
1318 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
1319
1320         Reviewed by Kenneth Rohde Christiansen.
1321
1322         [Qt] Fix the timeout of fast/frames/frame-navigation.html
1323         https://bugs.webkit.org/show_bug.cgi?id=31638
1324
1325         The test is timeouting, because it uses the WorkQueue to load a document in one
1326         of the child frames and once the loading is finished, the DRT does not dump the
1327         tree. This is because it waits for the QWebFrame::loadFinished() signal from
1328         the main frame, while it should connect to QWebPage::loadFinished().
1329
1330         * DumpRenderTree/qt/DumpRenderTree.cpp:
1331         (WebCore::DumpRenderTree::DumpRenderTree):
1332
1333 2009-11-21  Eric Seidel  <eric@webkit.org>
1334
1335         Reviewed by Adam Barth.
1336
1337         bugzilla-tool --help spews way too much text
1338         https://bugs.webkit.org/show_bug.cgi?id=31771
1339
1340         * Scripts/bugzilla-tool:
1341          - Remove self.cached_scm initialization hack.
1342         * Scripts/modules/buildbot.py:
1343          - Make default_host accessible to callers.
1344         * Scripts/modules/commands/download.py:
1345          - Phrase help for all commands consistently and remove spurious help text punctuation.
1346         * Scripts/modules/commands/queries.py: Ditto.
1347         * Scripts/modules/commands/queues.py: Ditto.
1348         * Scripts/modules/commands/upload.py: Ditto.
1349         * Scripts/modules/multicommandtool.py:
1350          - Add HelpPrintingOptionParser.format_epilog to replace
1351            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
1352            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
1353          - Make --help only show a list of commands like "svn help" and "git help" do --
1354            previously --help was listing all commands and options.
1355          - Sort list of commands alphabetically.
1356
1357 2009-11-21  Eric Seidel  <eric@webkit.org>
1358
1359         No review.  Fixing a typo from the previous patch for bug 31767.
1360
1361         AbstractQueue.run_bugzilla_tool throws an exception
1362         https://bugs.webkit.org/show_bug.cgi?id=31769
1363
1364         * Scripts/modules/commands/queues.py:
1365
1366 2009-11-21  Eric Seidel  <eric@webkit.org>
1367
1368         Reviewed by Adam Barth.
1369
1370         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
1371         https://bugs.webkit.org/show_bug.cgi?id=31767
1372
1373         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
1374         Since we don't have a good way to test BugzillaTool pieces, I've
1375         left out a test for now.
1376
1377         * Scripts/bugzilla-tool:
1378          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
1379         * Scripts/modules/commands/queues.py:
1380          - Use tool.path() instead of __file__.
1381         * Scripts/modules/multicommandtool.py:
1382          - Add a new path() method to MultiComandTool.
1383         * Scripts/modules/multicommandtool_unittest.py:
1384          - Provide a path() method.  Little point in testing this mock implementation.
1385
1386 2009-11-21  Adam Barth  <abarth@webkit.org>
1387
1388         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
1389         WebKitTools.
1390
1391         * Scripts/modules/commands/download.py:
1392
1393 2009-11-21  Adam Barth  <abarth@webkit.org>
1394
1395         Reviewed by Eric Seidel.
1396
1397         Convert check-style to use LandingSequence
1398         https://bugs.webkit.org/show_bug.cgi?id=31763
1399
1400         Instead of manipulating the working copy by hand, we should use the
1401         LandingSequence in CheckStyle.  This will make this code eaiser to
1402         test.
1403
1404         * Scripts/modules/commands/download.py:
1405
1406 2009-11-20  Adam Barth  <abarth@webkit.org>
1407
1408         Reviewed by Eric Seidel.
1409
1410         Unit test query commands
1411         https://bugs.webkit.org/show_bug.cgi?id=31755
1412
1413         These tests are pretty rough, but hopefully they'll grow.
1414
1415         * Scripts/modules/commands/queries_unittest.py: Added.
1416         * Scripts/modules/mock_bugzillatool.py: Added.
1417         * Scripts/run-webkit-unittests:
1418
1419 2009-11-20  Eric Seidel  <eric@webkit.org>
1420
1421         Reviewed by Adam Barth.
1422
1423         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
1424         https://bugs.webkit.org/show_bug.cgi?id=31758
1425
1426         * Scripts/modules/multicommandtool.py:
1427          - Allow passing of explicit commands to MultiCommandTool.__init__
1428         * Scripts/modules/multicommandtool_unittest.py:
1429          - Use new Command.name naming system.
1430          - Test Command auto-discovery.
1431         * Scripts/modules/workqueue.py:
1432          - bug_id no longer exists, use patch['bug_id'] instead.
1433         * Scripts/modules/workqueue_unittest.py:
1434          - WorkQueues require names now.
1435          - should_proceed_with_work_item must return a patch object.
1436
1437 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
1438
1439         Reviewed by Beth Dakin.
1440
1441         WAI-ARIA: add support for aria-owns
1442         https://bugs.webkit.org/show_bug.cgi?id=31702
1443
1444         * DumpRenderTree/AccessibilityUIElement.cpp:
1445         (ariaOwnsElementAtIndexCallback):
1446         (AccessibilityUIElement::getJSClass):
1447         * DumpRenderTree/AccessibilityUIElement.h:
1448         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1449         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1450         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1451         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1452         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1453         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1454
1455 2009-11-20  Eric Seidel  <eric@webkit.org>
1456
1457         Reviewed by Adam Barth.
1458
1459         Fix exception thrown when running the commit-queue.
1460
1461         * Scripts/modules/statusbot.py: patch is optional.
1462         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
1463
1464 2009-11-20  Eric Seidel  <eric@webkit.org>
1465
1466         Reviewed by Adam Barth.
1467
1468         Teach the StatusBot how to support more than just the commit-queue
1469         https://bugs.webkit.org/show_bug.cgi?id=31754
1470
1471         * Scripts/modules/workqueue.py: Another typo.
1472
1473 2009-11-20  Eric Seidel  <eric@webkit.org>
1474
1475         Reviewed by Adam Barth.
1476
1477         Teach the StatusBot how to support more than just the commit-queue
1478         https://bugs.webkit.org/show_bug.cgi?id=31754
1479
1480         * Scripts/modules/commands/queues.py: Fix silly typo.
1481
1482 2009-11-20  Eric Seidel  <eric@webkit.org>
1483
1484         Reviewed by Adam Barth.
1485
1486         Teach the StatusBot how to support more than just the commit-queue
1487         https://bugs.webkit.org/show_bug.cgi?id=31754
1488
1489         * CommitQueueStatus/index.yaml:
1490          - Add indices required for the new queries.
1491         * CommitQueueStatus/queue_status.py:
1492          - Add a patch-status page and move update_status to update-status.
1493          - Only display "commit-queue" status records for the commit-queue.
1494          - Add support for a queue_name property on status records.
1495          - Fix _int_from_request to actually work.
1496         * CommitQueueStatus/update_status.html:
1497          - Add support for a queue_name on status records.
1498          - Remove unused list of bug ids.
1499          * Scripts/modules/commands/queues.py
1500           - Make the queues pass the patch instead of the bug_id to StatusBot.
1501         * Scripts/modules/statusbot.py:
1502          - Support passing the queue_name to the status updates.
1503          - Support fetching patch status with patch_status().
1504         * Scripts/modules/workqueue.py:
1505          - Pass the patch to the StatusBot instead of the bug_id.
1506          - Let WorkQueues have a name.
1507
1508 2009-11-20  Adam Barth  <abarth@webkit.org>
1509
1510         Reviewed by Eric Seidel.
1511
1512         Move bugzilla-tool commands into their own file
1513         https://bugs.webkit.org/show_bug.cgi?id=31752
1514
1515         This will let us write unit tests.
1516
1517         * Scripts/bugzilla-tool:
1518         * Scripts/modules/commands/__init__.py: Added.
1519         * Scripts/modules/commands/download.py: Added.
1520         * Scripts/modules/commands/queries.py: Added.
1521         * Scripts/modules/commands/queues.py: Added.
1522         * Scripts/modules/commands/upload.py: Added.
1523         * Scripts/modules/grammar.py: Added.
1524
1525 2009-11-20  Adam Barth  <abarth@webkit.org>
1526
1527         Reviewed by Eric Seidel.
1528
1529         BuildQueue should check if the tree is currently buildable
1530         https://bugs.webkit.org/show_bug.cgi?id=31744
1531
1532         * Scripts/bugzilla-tool:
1533         * Scripts/modules/landingsequence.py:
1534         * Scripts/modules/webkitlandingscripts.py:
1535
1536 2009-11-20  Adam Barth  <abarth@webkit.org>
1537
1538         Reviewed by Eric Seidel.
1539
1540         Move prepare_clean_working_directory into the LandingSequence
1541         https://bugs.webkit.org/show_bug.cgi?id=31743
1542
1543         * Scripts/bugzilla-tool:
1544         * Scripts/modules/landingsequence.py:
1545
1546 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
1547
1548         Reviewed by Kenneth Rohde Christiansen.
1549
1550         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
1551         https://bugs.webkit.org/show_bug.cgi?id=30460
1552
1553         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
1554
1555         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1556         (pluginInvoke):
1557
1558 2009-11-20  Adam Barth  <abarth@webkit.org>
1559
1560         Reviewed by Eric Seidel.
1561
1562         Pass the port information to the child process
1563         https://bugs.webkit.org/show_bug.cgi?id=31736
1564
1565         We need to do this so the child process knows what to build!
1566
1567         * Scripts/bugzilla-tool:
1568         * Scripts/modules/landingsequence.py:
1569         * Scripts/modules/webkitport.py:
1570         * Scripts/modules/webkitport_unittest.py:
1571
1572 2009-11-20  Adam Barth  <abarth@webkit.org>
1573
1574         Reviewed by Eric Seidel.
1575
1576         Support Qt port in build-queue
1577         https://bugs.webkit.org/show_bug.cgi?id=31733
1578
1579         * Scripts/bugzilla-tool:
1580
1581 2009-11-20  Adam Barth  <abarth@webkit.org>
1582
1583         Reviewed by Eric Seidel.
1584
1585         Implement a build-queue
1586         https://bugs.webkit.org/show_bug.cgi?id=31725
1587
1588         Currently this just builds the first 10 patches in the review queue.
1589         We'll want to do something smarter soon.
1590
1591         * Scripts/bugzilla-tool:
1592
1593 2009-11-20  Adam Barth  <abarth@webkit.org>
1594
1595         Reviewed by Eric Seidel.
1596
1597         Make commit-queue and style-queue show up in help
1598         https://bugs.webkit.org/show_bug.cgi?id=31724
1599
1600         We need to store their names on their class to make these commands
1601         properly register themselves with MultiCommandTool.
1602
1603         * Scripts/bugzilla-tool:
1604
1605 2009-11-20  Adam Barth  <abarth@webkit.org>
1606
1607         Reviewed by Eric Seidel.
1608
1609         Implement bugzilla-tool build-attachment
1610         https://bugs.webkit.org/show_bug.cgi?id=31722
1611
1612         This command builds an attachment from bugzilla.  It leaves the built
1613         patch in the working copy.
1614
1615         * Scripts/bugzilla-tool:
1616         * Scripts/modules/landingsequence.py:
1617         * Scripts/modules/webkitlandingscripts.py:
1618
1619 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
1620
1621         Reviewed by Xan Lopez.
1622
1623         [GTK] DRT release event does not create the state correctly
1624         https://bugs.webkit.org/show_bug.cgi?id=31717
1625
1626         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1627
1628 2009-11-20  Eric Seidel  <eric@webkit.org>
1629
1630         Reviewed by Adam Barth.
1631
1632         MultiCommandTool should find Command objects automatically instead of with a manual list
1633         https://bugs.webkit.org/show_bug.cgi?id=31710
1634
1635         * Scripts/bugzilla-tool:
1636         * Scripts/modules/multicommandtool.py:
1637          - Use some wild python-fu to crawl all the known subclasses of Command.
1638
1639 2009-11-20  Adam Barth  <abarth@webkit.org>
1640
1641         Unreviewed "build" fix.  Added missing import.
1642
1643         * Scripts/bugzilla-tool:
1644
1645 2009-11-20  Adam Barth  <abarth@webkit.org>
1646
1647         Unreviewed "build" fix.  I failed to update LandingSequence.test
1648         properly.
1649
1650         * Scripts/modules/landingsequence.py:
1651
1652 2009-11-20  Adam Barth  <abarth@webkit.org>
1653
1654         Reviewed by Eric Seidel.
1655
1656         Create LandingSequence as the all-sing, all-dance landing class
1657         https://bugs.webkit.org/show_bug.cgi?id=31709
1658
1659         Client can inherit from this class to carefully control exactly which
1660         steps they wish to have happen in the landing sequence.
1661
1662         * Scripts/bugzilla-tool:
1663         * Scripts/modules/landingsequence.py: Added.
1664         * Scripts/modules/webkitlandingscripts.py: Added.
1665
1666 2009-11-19  Adam Barth  <abarth@webkit.org>
1667
1668         Reviewed by Eric Seidel.
1669
1670         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
1671         https://bugs.webkit.org/show_bug.cgi?id=31707
1672
1673         This is to help when we implement build-attachment.
1674
1675         * Scripts/bugzilla-tool:
1676
1677 2009-11-19  Adam Barth  <abarth@webkit.org>
1678
1679         Reviewed by Eric Seidel.
1680
1681         Support Qt port in bugzilla-tool
1682         https://bugs.webkit.org/show_bug.cgi?id=31701
1683
1684         Now we support building with Qt!
1685
1686         * Scripts/bugzilla-tool:
1687         * Scripts/modules/webkitport.py: Added.
1688         * Scripts/modules/webkitport_unittest.py: Added.
1689         * Scripts/run-webkit-unittests:
1690
1691 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
1692
1693         Reviewed by Adam Barth.
1694
1695         Remove inserting stderr into patch in bugzilla-tool
1696         https://bugs.webkit.org/show_bug.cgi?id=29914
1697
1698         Modify SCM python module's run_command function to avoid return of stderr
1699         by default, so stderr won't be inserted into the patches.
1700         Modify the related unit test.
1701
1702         * Scripts/modules/scm.py:
1703         * Scripts/modules/scm_unittest.py:
1704
1705 2009-11-19  Eric Seidel  <eric@webkit.org>
1706
1707         Reviewed by Adam Barth.
1708
1709         bugzilla-tool needs per-command help
1710         https://bugs.webkit.org/show_bug.cgi?id=31697
1711
1712         Added support for "bugzilla-tool help command-name"
1713         and a unit test to make sure it works.
1714
1715         * Scripts/modules/multicommandtool.py:
1716         * Scripts/modules/multicommandtool_unittest.py:
1717
1718 2009-11-19  Eric Seidel  <eric@webkit.org>
1719
1720         Reviewed by Adam Barth.
1721
1722         Move MultiCommandTool and Command into a separate file and add some basic unit tests
1723         https://bugs.webkit.org/show_bug.cgi?id=31695
1724
1725         * Scripts/bugzilla-tool:
1726         * Scripts/modules/multicommandtool.py: Added.
1727         * Scripts/modules/multicommandtool_unittest.py: Added.
1728         * Scripts/run-webkit-unittests:
1729
1730 2009-11-19  Eric Seidel  <eric@webkit.org>
1731
1732         No review, just adding a FIXME.
1733
1734         Split out command parsing and help printing from BugzillaTool
1735         https://bugs.webkit.org/show_bug.cgi?id=31688
1736
1737         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
1738
1739 2009-11-19  Eric Seidel  <eric@webkit.org>
1740
1741         Reviewed by Adam Barth.
1742
1743         Split out command parsing and help printing from BugzillaTool
1744         https://bugs.webkit.org/show_bug.cgi?id=31688
1745
1746         * Scripts/bugzilla-tool:
1747          - Add new MultiCommandTool class to contain option parsing and help printing logic.
1748          - Rename private methods to use _ pattern.
1749          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
1750          - 
1751
1752 2009-11-19  Eric Seidel  <eric@webkit.org>
1753
1754         Reviewed by Adam Barth.
1755
1756         Re-factor help printing to use modern python idioms
1757         https://bugs.webkit.org/show_bug.cgi?id=31685
1758
1759         * Scripts/bugzilla-tool:
1760
1761 2009-11-19  Eric Seidel  <eric@webkit.org>
1762
1763         Reviewed by Darin Adler.
1764
1765         commit-queue empty queue logs twice
1766         https://bugs.webkit.org/show_bug.cgi?id=31679
1767
1768         * Scripts/bugzilla-tool:
1769
1770 2009-11-19  Eric Seidel  <eric@webkit.org>
1771
1772         Reviewed by Darin Adler.
1773
1774         bugzilla-tool's reviewer/committer rejection message should be clearer
1775         https://bugs.webkit.org/show_bug.cgi?id=31126
1776
1777         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
1778
1779         * Scripts/modules/bugzilla.py:
1780
1781 2009-11-19  Eric Z. Ayers  <zundel@google.com>
1782
1783         Reviewed by Pavel Feldman.
1784
1785         Forces a WM_PAINT event on calling layoutTestController.display()
1786         in order to enable the timeline-paint.html test on Windows.
1787         ::UpdateWindow() does not force an event becaue the window is 
1788         not visible.
1789
1790         https://bugs.webkit.org/show_bug.cgi?id=31402
1791
1792         * DumpRenderTree/win/DumpRenderTree.cpp:
1793         (displayWebView):
1794
1795 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
1796
1797         No review needed.
1798
1799         Added myself to committers list.
1800
1801         * Scripts/modules/committers.py:
1802
1803 2009-11-19  Adam Barth  <abarth@webkit.org>
1804
1805         Reviewed by Eric Seidel.
1806
1807         Bugzilla-tool command classes should match command names
1808         https://bugs.webkit.org/show_bug.cgi?id=31666
1809
1810         I renamed all the commands except CommitMessageForCurrentDiff because
1811         the new name would conflict with an existing class.
1812
1813         * Scripts/bugzilla-tool:
1814
1815 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
1816
1817         Reviewed by Gustavo Noronha Silva.
1818
1819         Web Inspector: Implement "show inspector" in WebKit GTK
1820         API and enable console tests.
1821
1822         https://bugs.webkit.org/show_bug.cgi?id=31669
1823
1824         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1825         (LayoutTestController::showWebInspector):
1826
1827 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1828
1829         Reviewed by Simon Hausmann.
1830
1831         Minor refactoring + more documentation.
1832
1833         * DumpRenderTree/qt/DumpRenderTree.cpp:
1834         (WebCore::clearHistory):
1835         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1836
1837 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
1838
1839         Reviewed by Eric Seidel.
1840
1841         Ignore websocket tests when --no-http is specified.
1842         https://bugs.webkit.org/show_bug.cgi?id=31662
1843
1844         * Scripts/run-webkit-tests:
1845
1846 2009-11-18  Adam Barth  <abarth@webkit.org>
1847
1848         Reviewed by Eric Seidel.
1849
1850         Normalize ' and " in bugzilla-tool
1851         https://bugs.webkit.org/show_bug.cgi?id=31655
1852
1853         We decided " is better than ' and we should be consistent.
1854
1855         * Scripts/bugzilla-tool:
1856
1857 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1858
1859         Reviewed by Kenneth Rohde Christiansen.
1860
1861         [Qt] Remove support for Qt v4.3 or older versions
1862         https://bugs.webkit.org/show_bug.cgi?id=29469
1863
1864         * DumpRenderTree/qt/DumpRenderTree.pro:
1865         * DumpRenderTree/qt/ImageDiff.pro:
1866
1867 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1868
1869         Reviewed by Eric Seidel.
1870
1871         GitTest.test_create_binary_patch fails if /tmp is symlink
1872         https://bugs.webkit.org/show_bug.cgi?id=31536
1873
1874         * Scripts/modules/scm_unittest.py:
1875
1876 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
1877
1878         Reviewed by Darin Adler.
1879
1880         Configuration for Chromium Build Slaves.
1881
1882         https://bugs.webkit.org/show_bug.cgi?id=31442
1883
1884         * BuildSlaveSupport/build.webkit.org-config/config.json:
1885         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1886
1887 2009-11-18  Eric Seidel  <eric@webkit.org>
1888
1889         Reviewed by Darin Adler.
1890
1891         workqueue.py results in totally broken commit-queue UI
1892         https://bugs.webkit.org/show_bug.cgi?id=31645
1893
1894         * Scripts/bugzilla-tool:
1895          - Remove unneeded use of PatchCollection.
1896          - Grab a new copy of the cq'd patches every run of the queue.
1897
1898 2009-11-18  Sam Weinig  <sam@webkit.org>
1899
1900         Reviewed by Anders Carlsson.
1901
1902         Make the Mac Geolocation API async.
1903
1904         Update DRT to use the new async Mac Geolocation API.
1905
1906         * DumpRenderTree/mac/UIDelegate.mm:
1907         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1908
1909 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1910
1911         Reviewed by Kenneth Rohde Christiansen.
1912
1913         Add and option to toggle HTML5 datalist support to build-webkit
1914         https://bugs.webkit.org/show_bug.cgi?id=31599
1915
1916         * Scripts/build-webkit:
1917
1918 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1919
1920         Reviewed by Kevin Ollivier.
1921
1922         Enable wx plugin support using the Windows implementation as a base.
1923         
1924         https://bugs.webkit.org/show_bug.cgi?id=31636
1925
1926         * wx/build/settings.py:
1927
1928 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1929
1930         Reviewed by Simon Hausmann.
1931
1932         Change the initialization order so that the controllers
1933         will be created before exporting them to the JS DOM window.
1934
1935         * DumpRenderTree/qt/DumpRenderTree.cpp:
1936         (WebCore::DumpRenderTree::DumpRenderTree):
1937
1938 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1939
1940         Reviewed by Simon Hausmann.
1941
1942         Fix a code copy and paste error. m_page should be page.
1943
1944         * DumpRenderTree/qt/DumpRenderTree.cpp:
1945         (WebCore::DumpRenderTree::createWindow):
1946
1947 2009-11-17  Mark Rowe  <mrowe@apple.com>
1948
1949         Reviewed by Alexey Proskuryakov.
1950
1951         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
1952
1953         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
1954         This prevents symlinks from confusing the descendant check.
1955
1956 2009-11-17  Mark Rowe  <mrowe@apple.com>
1957
1958         Reviewed by Alexey Proskuryakov.
1959
1960         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
1961
1962         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
1963         server to be up rather than having run-webkit-tests abort immediately.
1964
1965         * Scripts/run-webkit-tests:
1966
1967 2009-11-17  Eric Seidel  <eric@webkit.org>
1968
1969         Reviewed by Darin Adler.
1970
1971         commit-queue is failing to set reviewer in ChangeLogs
1972         https://bugs.webkit.org/show_bug.cgi?id=31592
1973
1974         * Scripts/bugzilla-tool: Clarify the "applying" log message.
1975         * Scripts/modules/bugzilla.py:
1976          - Add a new _validate_committer_and_reviewer function as a
1977            temporary solution until we can make a real Attachment object
1978            which knows how to fill in its committer/reviewer fields automatically.
1979
1980 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1981
1982         Unreviewed buildbot fix.
1983
1984         Revert part of earlier patch and add comment, as it
1985         was causing timeouts on the buildbot.
1986
1987         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1988         (LayoutTestController::notifyDone):
1989
1990 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1991
1992         Reviewed by Oliver Hunt.
1993
1994         Make the timeout 15 sec as for the other DRT's and make
1995         it print out the same output when a test timeout.
1996
1997         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1998         (LayoutTestController::waitUntilDone):
1999         (LayoutTestController::notifyDone):
2000         (LayoutTestController::timerEvent):
2001
2002 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
2003
2004         Reviewed by Timothy Hatcher.
2005
2006         Fixed typos in comments.
2007
2008         * Scripts/modules/committers.py:
2009
2010 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
2011
2012         Reviewed by Timothy Hatcher.
2013
2014         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
2015         - Updated DRT to show/close inspector for all tests under /inspector
2016         - Introduced LayoutTestController::setTimelineProfilingEnabled and
2017           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
2018         - Removed reload on each inspector test
2019         - Renamed fast/inspector to fast/inspector-support in order not to trigger
2020         inspector for those.
2021         - Reimplemented timeline tests in order to get rid of reload there.
2022         - Moved tests that don't require harness into the fast group.
2023
2024         https://bugs.webkit.org/show_bug.cgi?id=31472
2025
2026         * DumpRenderTree/LayoutTestController.cpp:
2027         (setTimelineProfilingEnabledCallback):
2028         (closeWebInspectorCallback):
2029         (LayoutTestController::staticFunctions):
2030         * DumpRenderTree/LayoutTestController.h:
2031         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2032         (shouldOpenWebInspector):
2033         (runTest):
2034         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2035         (LayoutTestController::setTimelineProfilingEnabled):
2036         * DumpRenderTree/mac/DumpRenderTree.mm:
2037         (shouldOpenWebInspector):
2038         (runTest):
2039         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2040         (LayoutTestController::setTimelineProfilingEnabled):
2041         * DumpRenderTree/win/DumpRenderTree.cpp:
2042         (shouldOpenWebInspector):
2043         (runTest):
2044         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2045         (LayoutTestController::setTimelineProfilingEnabled):
2046
2047 2009-11-17  Oliver Hunt  <oliver@apple.com>
2048
2049         Reviewed by Maciej Stachowiak.
2050
2051         Incorrect use of JavaScriptCore API in DumpRenderTree
2052         https://bugs.webkit.org/show_bug.cgi?id=31577
2053
2054         Return undefined rather than a literal null.
2055
2056         * DumpRenderTree/AccessibilityUIElement.cpp:
2057         (setSelectedTextRangeCallback):
2058         (incrementCallback):
2059         (decrementCallback):
2060         (showMenuCallback):
2061
2062 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
2063
2064         Reviewed by Beth Dakin.
2065
2066         AX: aria-labelledby duplicates some of its WAI-ARIA label
2067         https://bugs.webkit.org/show_bug.cgi?id=31565
2068
2069         * DumpRenderTree/AccessibilityUIElement.cpp:
2070         (titleUIElementCallback):
2071         (getIsValidCallback):
2072         (AccessibilityUIElement::getJSClass):
2073
2074 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2075
2076         Reviewed by Simon Hausmann.
2077
2078         r50942 broke output from created windows. Make the
2079         m_enableTextOutput a member of the DRT and not the
2080         WebPage.
2081
2082         * DumpRenderTree/qt/DumpRenderTree.cpp:
2083         (WebCore::WebPage::WebPage):
2084         (WebCore::WebPage::javaScriptAlert):
2085         (WebCore::WebPage::javaScriptConsoleMessage):
2086         (WebCore::WebPage::javaScriptConfirm):
2087         (WebCore::WebPage::javaScriptPrompt):
2088         (WebCore::WebPage::acceptNavigationRequest):
2089         (WebCore::DumpRenderTree::DumpRenderTree):
2090         (WebCore::DumpRenderTree::open):
2091         (WebCore::DumpRenderTree::createWindow):
2092         * DumpRenderTree/qt/DumpRenderTree.h:
2093         (WebCore::DumpRenderTree::setTextOutputEnabled):
2094         (WebCore::DumpRenderTree::isTextOutputEnabled):
2095         (WebCore::WebPage::shouldInterruptJavaScript):
2096         (WebCore::WebPage::isTextOutputEnabled):
2097         (WebCore::WebPage::setViewGeometry):
2098
2099 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2100
2101         Reviewed by Gustavo Noronha Silva.
2102
2103         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
2104         as the implementation is being used by at least Qt and Gtk+.
2105
2106         Update buildsystems as well.
2107
2108         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2109         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
2110         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
2111         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
2112         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2113         * GNUmakefile.am:
2114
2115 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
2116
2117         Reviewed by Alexey Proskuryakov.
2118
2119         Disable wss until all platforms support pyOpenSSL
2120
2121         https://bugs.webkit.org/show_bug.cgi?id=31479
2122
2123         * Scripts/run-webkit-tests:
2124
2125 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
2126
2127         Reviewed by Kenneth Christiansen.
2128
2129         [Qt] Implement load error pages support for Qt's DRT.
2130         https://bugs.webkit.org/show_bug.cgi?id=31509
2131
2132         For now, it will not be a default feature, and layout tests
2133         that want to make use of this have to explicitily call
2134         'handleErrorPages();' for the test source.
2135
2136         Any of the other DumpRenderTree's (mac, win and gtk)
2137         support handling error pages. Qt's will be the first.
2138
2139         * DumpRenderTree/qt/DumpRenderTree.cpp:
2140         (WebCore::WebPage::supportsExtension):
2141         (WebCore::WebPage::extension):
2142         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2143         (LayoutTestController::reset):
2144         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2145         (LayoutTestController::shouldHandleErrorPages):
2146         (LayoutTestController::handleErrorPages):
2147
2148 2009-11-16  Eric Seidel  <eric@webkit.org>
2149
2150         Reviewed by Adam Barth.
2151
2152         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
2153         https://bugs.webkit.org/show_bug.cgi?id=31549
2154
2155         Renamed --commit-queue to --non-interactive in most places
2156         and remove the code in land-patches which is no longer needed.
2157
2158         * Scripts/bugzilla-tool:
2159
2160 2009-11-16  Eric Seidel  <eric@webkit.org>
2161
2162         Reviewed by Adam Barth.
2163
2164         The commit-queue should use land-attachment
2165         https://bugs.webkit.org/show_bug.cgi?id=31548
2166
2167         * Scripts/bugzilla-tool:
2168
2169 2009-11-16  Adam Barth  <abarth@webkit.org>
2170
2171         Reviewed by Eric Seidel.
2172
2173         Convert CommitQueue over to PatchCollection
2174         https://bugs.webkit.org/show_bug.cgi?id=31547
2175
2176         Also fixes a bug in workqueue and adds a test!
2177
2178         * Scripts/bugzilla-tool:
2179         * Scripts/modules/workqueue.py:
2180         * Scripts/modules/workqueue_unittest.py:
2181
2182 2009-11-16  Adam Barth  <abarth@webkit.org>
2183
2184         Reviewed by Eric Seidel.
2185
2186         Move StyleQueue over to using PatchCollection
2187         https://bugs.webkit.org/show_bug.cgi?id=31544
2188
2189         That's what the class it's for.
2190
2191         * Scripts/bugzilla-tool:
2192         * Scripts/modules/patchcollection.py:
2193         * Scripts/modules/patchcollection_unittest.py:
2194
2195 2009-11-16  Eric Seidel  <eric@webkit.org>
2196
2197         Reviewed by Adam Barth.
2198
2199         bugzilla-tool needs a land-attachment command
2200         https://bugs.webkit.org/show_bug.cgi?id=31546
2201
2202         * Scripts/bugzilla-tool:
2203          - Move all the logic into AbstractLandingCommand and
2204            add a new LandAttachment command subclass.
2205          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
2206
2207 2009-11-16  Eric Seidel  <eric@webkit.org>
2208
2209         Reviewed by Adam Barth.
2210
2211         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
2212         https://bugs.webkit.org/show_bug.cgi?id=31543
2213
2214         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
2215
2216         * Scripts/bugzilla-tool:
2217
2218 2009-11-16  Eric Seidel  <eric@webkit.org>
2219
2220         Reviewed by Adam Barth.
2221
2222         Disable the style queue from posting to the commit queue status page.
2223
2224         * Scripts/bugzilla-tool:
2225
2226 2009-11-16  Adam Barth  <abarth@webkit.org>
2227
2228         Reviewed by Eric Seidel.
2229
2230         Implement PatchCollection
2231         https://bugs.webkit.org/show_bug.cgi?id=31541
2232
2233         This class holds a set of patches and lets clients iterate through
2234         them.  Optionally, clients can install a filter.
2235
2236         * Scripts/modules/patchcollection.py: Added.
2237         * Scripts/modules/patchcollection_unittest.py: Added.
2238         * Scripts/run-webkit-unittests:
2239
2240 2009-11-16  Eric Seidel  <eric@webkit.org>
2241
2242         Reviewed by Adam Barth.
2243
2244         bugzilla-tool land-patches will close bugs with patches r=?
2245         https://bugs.webkit.org/show_bug.cgi?id=28230
2246
2247         The commit-queue shouldn't close patches with outstanding reviews on them,
2248         even if many reviewers seem to be against multi-patch bugs.
2249
2250         * Scripts/bugzilla-tool:
2251
2252 2009-11-16  Eric Seidel  <eric@webkit.org>
2253
2254         Reviewed by Adam Barth.
2255
2256         bugzilla-tool check-style should work with attachment ids instead of bug ids
2257         https://bugs.webkit.org/show_bug.cgi?id=31540
2258
2259         * Scripts/bugzilla-tool:
2260
2261 2009-11-16  Eric Seidel  <eric@webkit.org>
2262
2263         Reviewed by Adam Barth.
2264
2265         WorkQueue is the only place that should know about special exit codes
2266         https://bugs.webkit.org/show_bug.cgi?id=31534
2267
2268         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
2269         and add tests for handling exit codes.
2270         I also cleaned up workqueue_unittest.py more.
2271
2272         * Scripts/bugzilla-tool:
2273         * Scripts/modules/workqueue.py:
2274         * Scripts/modules/workqueue_unittest.py:
2275
2276 2009-11-16  Eric Seidel  <eric@webkit.org>
2277
2278         Reviewed by Adam Barth.
2279
2280         Re-factor workqueue_unittest to allow for more than one test.
2281         https://bugs.webkit.org/show_bug.cgi?id=31535
2282
2283         * Scripts/modules/workqueue_unittest.py:
2284
2285 2009-11-16  Eric Seidel  <eric@webkit.org>
2286
2287         Reviewed by Adam Barth.
2288
2289         land-patches needs to be re-factored into smaller chunks
2290         https://bugs.webkit.org/show_bug.cgi?id=31532
2291
2292         * Scripts/bugzilla-tool: fix a couple obvious typos.
2293
2294 2009-11-16  Eric Seidel  <eric@webkit.org>
2295
2296         Reviewed by Adam Barth.
2297
2298         land-patches needs to be re-factored into smaller chunks
2299         https://bugs.webkit.org/show_bug.cgi?id=31532
2300
2301         The next patch will move these methods into WebKitLandingScripts.
2302
2303         * Scripts/bugzilla-tool:
2304          - Split out _land_patch and _close_bug_if_no_active_patches.
2305
2306 2009-11-16  Adam Barth  <abarth@webkit.org>
2307
2308         Reviewed by Eric Seidel.
2309
2310         Fix silly copy-and-paste code.  I am a terrible coder.
2311
2312         * Scripts/modules/bugzilla.py:
2313
2314 2009-11-16  Adam Barth  <abarth@webkit.org>
2315
2316         Reviewed by Eric Seidel.
2317
2318         Implement a StyleQueue
2319         https://bugs.webkit.org/show_bug.cgi?id=31537
2320
2321         The first iteration of the style queue only produces output locally.
2322         There is also a limit of 10 patches because it's not that useful to
2323         iterate through the entire review queue at this point.  We can remove
2324         the limit later.
2325
2326         * Scripts/bugzilla-tool:
2327         * Scripts/modules/bugzilla.py:
2328
2329 2009-11-16  Adam Barth  <abarth@webkit.org>
2330
2331         Reviewed by Eric Seidel.
2332
2333         Unit test WorkQueue
2334         https://bugs.webkit.org/show_bug.cgi?id=31531
2335
2336         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
2337
2338         * Scripts/bugzilla-tool:
2339         * Scripts/modules/statusbot.py:
2340         * Scripts/modules/workqueue.py:
2341         * Scripts/modules/workqueue_unittest.py: Added.
2342         * Scripts/run-webkit-unittests:
2343
2344 2009-11-16  Eric Seidel  <eric@webkit.org>
2345
2346         Reviewed by Adam Barth.
2347
2348         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
2349         https://bugs.webkit.org/show_bug.cgi?id=31530
2350
2351         * Scripts/bugzilla-tool:
2352
2353 2009-11-16  Eric Seidel  <eric@webkit.org>
2354
2355         Reviewed by Adam Barth.
2356
2357         bugzilla-tool needs apply-attachment
2358         https://bugs.webkit.org/show_bug.cgi?id=31528
2359
2360         * Scripts/bugzilla-tool:
2361          - Add ApplyAttachment command.
2362          - Abstract applying code into WebKitApplyingScripts.
2363          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
2364         * Scripts/modules/bugzilla.py:
2365          - Add fetch_attachment and bug_id_for_attachment_id.
2366         * Scripts/modules/bugzilla_unittest.py:
2367          - Add test for new parsing.
2368          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
2369
2370 2009-11-16  Eric Seidel  <eric@webkit.org>
2371
2372         Reviewed by Adam Barth.
2373
2374         Document check-style's use of force_clean.
2375
2376         * Scripts/bugzilla-tool:
2377         * Scripts/modules/scm.py:
2378
2379 2009-11-16  Adam Barth  <abarth@webkit.org>
2380
2381         Reviewed by Eric Seidel.
2382
2383         Move WorkQueue to its own file
2384         https://bugs.webkit.org/show_bug.cgi?id=31529
2385
2386         WorkQueue and WorkQueueDelegate are separate concerns from
2387         bugzilla-tool.  Also added a missing include to logging.py.
2388
2389         * Scripts/bugzilla-tool:
2390         * Scripts/modules/logging.py:
2391         * Scripts/modules/workqueue.py:
2392
2393 2009-11-16  Adam Barth  <abarth@webkit.org>
2394
2395         Reviewed by Eric Seidel.
2396
2397         Move OutputTee to logging.py.
2398
2399         * Scripts/bugzilla-tool:
2400         * Scripts/modules/logging.py:
2401
2402 2009-11-15  Adam Barth  <abarth@webkit.org>
2403
2404         Reviewed by Eric Seidel.
2405
2406         Refactor bugzilla-tool to allow for multiple queues
2407         https://bugs.webkit.org/show_bug.cgi?id=31513
2408
2409         Divide the commit queue class into three class to make creating
2410         additional queues easier.
2411
2412         * Scripts/bugzilla-tool:
2413
2414 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
2415
2416         Reviewed by Eric Seidel.
2417
2418         svn-apply may not handle git patches created by bugzilla-tool
2419         https://bugs.webkit.org/show_bug.cgi?id=31457
2420
2421         * Scripts/modules/scm.py:
2422         * Scripts/modules/scm_unittest.py:
2423
2424 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
2425
2426         Reviewed by Eric Seidel.
2427
2428         bugzilla-tool should post git binary diff
2429         https://bugs.webkit.org/show_bug.cgi?id=31458
2430
2431         Add --binary option to Git.create_patch.
2432
2433         * Scripts/modules/scm.py:
2434         * Scripts/modules/scm_unittest.py:
2435
2436 2009-11-15  Adam Barth  <abarth@webkit.org>
2437
2438         Reviewed by Darin Adler.
2439
2440         Add bugzilla-tool check-style
2441         https://bugs.webkit.org/show_bug.cgi?id=31515
2442
2443         * Scripts/bugzilla-tool:
2444         * Scripts/modules/bugzilla.py:
2445
2446 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2447
2448         Reviewed by Simon Hausmann.
2449
2450         Make the Qt Linux only --valgrind feature, suppress errors
2451         defined in the SuppressedValgrindErrors file.
2452
2453         * Scripts/run-webkit-tests:
2454
2455 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2456
2457         Reviewed by Simon Hausmann.
2458
2459         Set the locale to C and not to the current one in use on the system.
2460
2461         * DumpRenderTree/qt/DumpRenderTree.cpp:
2462         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2463
2464 2009-11-13  Adam Roben  <aroben@apple.com>
2465
2466         Add support for
2467         http/tests/security/isolatedWorld/didClearWindowObject.html
2468
2469         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
2470         window objects in isolated worlds are cleared
2471
2472         Reviewed by Dave Hyatt.
2473
2474         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
2475
2476         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2477         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2478         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
2479         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
2480         Added. Sets a __worldID property on the global object whose value is
2481         the ID of this world.
2482         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
2483         Respond to this new delegate callback by calling through to one of the
2484         above new methods.
2485         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2486         (worldMap): Added. Returns a HashMap containing all the worlds we've
2487         created.
2488         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
2489         haven't kept track of this world.
2490         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
2491         instead of declaring our own.
2492
2493         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
2494
2495         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2496         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
2497         didClearWindowObjectForFrameInStandardWorld.
2498         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
2499         Respond to this new delegate callback by calling through to one of the
2500         below new methods.
2501         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
2502         Added. Sets a __worldID property on the gobal object whose value is
2503         the ID of this world.
2504         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
2505         Added. Moved code here from didClearWindowObject.
2506
2507         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
2508         didClearWindowObjectForFrame* functions.
2509
2510         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2511         (worldMap): Added. Returns a HashMap containing all the worlds we've
2512         created.
2513         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
2514         haven't kept track of this world.
2515         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
2516         instead of declaring our own.
2517
2518 2009-11-13  Adam Roben  <aroben@apple.com>
2519
2520         Finish replacing worldIDs with world objects
2521
2522         The only remaining use of worldIDs was in a method only used by DRT
2523         for the isolated worlds tests.
2524
2525         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
2526
2527         Reviewed by Mark Rowe.
2528
2529         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2530         (LayoutTestController::evaluateScriptInIsolatedWorld):
2531         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2532         (LayoutTestController::evaluateScriptInIsolatedWorld):
2533         Updated for changes to WebFrame. Now holds the map of worldID -> world
2534         at this level instead of making WebKit do it.
2535
2536 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2537
2538         Reviewed by Simon Hausmann.
2539
2540         [Qt] Ensure the DRT does not output anything until first test is run
2541
2542         * DumpRenderTree/qt/DumpRenderTree.cpp:
2543         * DumpRenderTree/qt/DumpRenderTree.h:
2544
2545 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2546
2547         Reviewed by Tor Arne Vestbø.
2548
2549         Clear the undo stack in before each new test run.
2550
2551         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
2552
2553         * DumpRenderTree/qt/DumpRenderTree.cpp:
2554         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2555
2556 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2557
2558         Reviewed by Kenneth Rohde Christiansen.
2559
2560         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
2561
2562         * DumpRenderTree/qt/DumpRenderTree.cpp:
2563         (WebCore::WebPage::resetSettings):
2564         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2565         (LayoutTestController::overridePreference):
2566
2567 2009-11-13  Eric Seidel  <eric@webkit.org>
2568
2569         Reviewed by Adam Barth.
2570
2571         Update committers.py based on svn records
2572         https://bugs.webkit.org/show_bug.cgi?id=31366
2573
2574         This list was generated using validate-committer-lists from
2575         https://bugs.webkit.org/show_bug.cgi?id=30970
2576         and makes committers.py current for committers who have
2577         committed in the last 3 years.
2578
2579         * Scripts/modules/committers.py:
2580
2581 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
2582
2583         Reviewed by Adam Barth.
2584
2585         The document-open.html test was flaky at times. The test invokes the layout test plugin
2586         which in its destroy stream handler opens a new document. This basically tears down the
2587         stream and the associated plugin instance. The pluginLog function in the layout test
2588         plugin attempts to retrieve the window script object on a torn down plugin instance
2589         which crashed consistently on windows in the debugger. The functions which issue
2590         these logs already have a valid window script object. We now have variants of the pluginLog
2591         function which take in a window script object with and without variable arguments. 
2592
2593         https://bugs.webkit.org/show_bug.cgi?id=31067
2594
2595         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2596         (pluginLogWithWindowObject):
2597         (pluginLogWithWindowObjectVariableArgs):
2598         (pluginLog):
2599         (notifyTestCompletion):
2600         (testDocumentOpen):
2601         (testWindowOpen):
2602
2603 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2604
2605         Reviewed by Gustavo Noronha Silva.
2606
2607         https://bugs.webkit.org/show_bug.cgi?id=30997
2608         [Gtk] Implemment AtkDocument
2609
2610         Added testing support.
2611
2612         * DumpRenderTree/AccessibilityUIElement.cpp:
2613         * DumpRenderTree/AccessibilityUIElement.h:
2614         (getDocumentEncodingCallback):
2615         (getDocumentURICallback):
2616         (AccessibilityUIElement::getJSClass):
2617         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2618         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2619         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2620         (AccessibilityUIElement::documentEncoding):
2621         (AccessibilityUIElement::documentURI):
2622
2623 2009-11-12  Adam Roben  <aroben@apple.com>
2624
2625         Replace worldIDs with world objects
2626
2627         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
2628         user scripts/stylesheets and isolated worlds
2629
2630         Reviewed by Sam Weinig.
2631
2632         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2633         (LayoutTestController::addUserScript):
2634         (LayoutTestController::addUserStyleSheet):
2635         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2636         (LayoutTestController::addUserScript):
2637         (LayoutTestController::addUserStyleSheet):
2638         Changed these functions to create a new WebJSWorld each time they're
2639         called and to pass that world to WebKit.
2640
2641 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
2642
2643         Reviewed by Oliver Hunt.
2644
2645         need to implement aria tree roles
2646         https://bugs.webkit.org/show_bug.cgi?id=31284
2647
2648         * DumpRenderTree/AccessibilityUIElement.cpp:
2649         (disclosedRowAtIndexCallback):
2650         (selectedRowAtIndexCallback):
2651         (isEqualCallback):
2652         (isAttributeSettableCallback):
2653         (isActionSupportedCallback):
2654         (disclosedByRowCallback):
2655         (hierarchicalLevelCallback):
2656         (AccessibilityUIElement::getJSClass):
2657         * DumpRenderTree/AccessibilityUIElement.h:
2658         (AccessibilityUIElement::isEqual):
2659         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2660         (AccessibilityUIElement::hierarchicalLevel):
2661         (AccessibilityUIElement::disclosedRowAtIndex):
2662         (AccessibilityUIElement::selectedRowAtIndex):
2663         (AccessibilityUIElement::disclosedByRow):
2664         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2665         (AccessibilityUIElement::getChildAtIndex):
2666         (AccessibilityUIElement::disclosedRowAtIndex):
2667         (AccessibilityUIElement::selectedRowAtIndex):
2668         (AccessibilityUIElement::titleUIElement):
2669         (AccessibilityUIElement::parentElement):
2670         (AccessibilityUIElement::disclosedByRow):
2671         (AccessibilityUIElement::hierarchicalLevel):
2672         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2673         (AccessibilityUIElement::hierarchicalLevel):
2674         (AccessibilityUIElement::disclosedRowAtIndex):
2675         (AccessibilityUIElement::selectedRowAtIndex):
2676         (AccessibilityUIElement::disclosedByRow):
2677
2678 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
2679
2680         Reviewed by Darin Adler.
2681
2682         svn-apply can not handle git binary diffs
2683         https://bugs.webkit.org/show_bug.cgi?id=26830
2684
2685         Support "literal" type git binary diffs.
2686
2687         * Scripts/VCSUtils.pm:
2688         * Scripts/modules/scm_unittest.py:
2689         * Scripts/svn-apply:
2690
2691 2009-11-11  Dmitry Titov  <dimich@chromium.org>
2692
2693         Not reviewed, removing duplicate entry for myself in committers.py.
2694
2695         * Scripts/modules/committers.py:
2696
2697 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
2698
2699         Reviewed by Darin Adler and Mark Rowe.
2700
2701         https://bugs.webkit.org/show_bug.cgi?id=31200
2702         Tests in http/tests/security/mixedContent start to fail when new tests are added
2703
2704         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
2705
2706 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2707
2708         Reviewed by Jan Alonzo.
2709
2710         Create, and display a window for the inspector, for inspector
2711         tests.
2712
2713         Need to also show/hide the inspector window to avoid having
2714         problems with code assuming it is realized
2715         https://bugs.webkit.org/show_bug.cgi?id=31347
2716
2717         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2718         (webInspectorShowWindow):
2719         (webInspectorCloseWindow):
2720         (webInspectorInspectWebView):
2721         (createWebView):
2722
2723 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2724
2725         Unreviewed Qt buildbot fix.
2726
2727         My previous fix was wrong, so revert that change and fix it by
2728         returning when the document of the frame has no document element.
2729         Idea is borrowed from mac and win DRT.
2730
2731         * DumpRenderTree/qt/DumpRenderTree.cpp:
2732         (WebCore::DumpRenderTree::dumpFramesAsText):
2733
2734 2009-11-11  Eric Seidel  <eric@webkit.org>
2735
2736         Reviewed byg Kenneth Rohde Christiansen.
2737
2738         Update Kenneth's committer record to include the email he
2739         uses on lists.webkit.org.
2740
2741         * Scripts/modules/committers.py:
2742
2743 2009-11-11  Eric Seidel  <eric@webkit.org>
2744
2745         Reviewed by Gustavo Noronha Silva.
2746
2747         Several committers use separate email addresses for bugzilla and svn.webkit.org
2748         https://bugs.webkit.org/show_bug.cgi?id=31364
2749
2750         Update records for existing committers to include email addresses
2751         used in svn.webkit.org and lists.webkit.org.
2752         Most committers use the same email address in all 3 places, but some use
2753         separate addresses.  committers.py needs record of each of these addresses.
2754
2755         * Scripts/modules/committers.py:
2756
2757 2009-11-11  Eric Seidel  <eric@webkit.org>
2758
2759         No review, adding second email address for an existing committer.
2760
2761         Add Yong Li's second bugzilla account to his committer record.
2762         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
2763
2764         * Scripts/modules/committers.py:
2765
2766 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2767
2768         Reviewed by Simon Hausmann.
2769
2770         If the frame has no innerText don't append it, and
2771         do not add a newline which breaks some cross platform
2772         results.
2773
2774         * DumpRenderTree/qt/DumpRenderTree.cpp:
2775         (WebCore::DumpRenderTree::dumpFramesAsText):
2776
2777 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2778
2779         Reviewed by Simon Hausmann.
2780
2781         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
2782
2783         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2784         (webkit_test_plugin_new_instance):
2785         (webkit_test_plugin_destroy_instance):
2786         (webkit_test_plugin_destroy_stream):
2787
2788 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2789
2790         Reviewed by Mark Rowe.
2791
2792         Implement the functionality needed by plugins/window-open.html
2793
2794         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2795         (webkit_test_plugin_new_instance):
2796         (webkit_test_plugin_set_window):
2797
2798 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2799
2800         Reviewed by Simon Hausmann.
2801
2802         [Qt] Force -graphicssystem raster and -style windows when running DRT
2803
2804         * DumpRenderTree/qt/main.cpp:
2805         * Scripts/run-webkit-tests:
2806
2807 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2808
2809         Reviewed by Simon Hausmann.
2810
2811         Compute correct library paths for Qt
2812
2813         * Scripts/webkitdirs.pm:
2814
2815 2009-11-10  Mark Rowe  <mrowe@apple.com>
2816
2817         Reviewed by Sam Weinig.
2818
2819         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
2820
2821         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
2822         about the validity of the self-signed certificates used in the regression tests.  We would then add the
2823         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
2824         that had enabled frame load delegate logging this would result in extra log messages being generated,
2825         causing the test to fail.
2826
2827         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
2828         tests.
2829
2830         * DumpRenderTree/mac/DumpRenderTree.mm:
2831         (dumpRenderTree):
2832         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2833         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2834
2835 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2836
2837         Reviewed by Kenneth Rohde Christiansen.
2838
2839         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
2840
2841         * DumpRenderTree/qt/DumpRenderTree.cpp:
2842         (WebCore::DumpRenderTree::DumpRenderTree):
2843
2844 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2845
2846         Reviewed by Jan Alonzo.
2847
2848         [GTK] Remove WebSocket configuration from WebKitWebSettings
2849         https://bugs.webkit.org/show_bug.cgi?id=31244
2850
2851         Follow-up of r50724. Don't set the enable-web-socket property
2852         anymore.
2853
2854         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2855         (resetDefaultsToConsistentValues):
2856
2857 2009-11-10  Oliver Hunt  <oliver@apple.com>
2858
2859         Reviewed by Maciej Stachowiak.
2860
2861         Rename 3D Canvas related classes to use WebGL prefix
2862         https://bugs.webkit.org/show_bug.cgi?id=29095
2863
2864         Checkin new version of do-webcore-rename used to do the WebGL type rename,
2865         and upate webkitdirs script to new method of testing for WebGL.
2866
2867         * Scripts/do-webcore-rename:
2868         * Scripts/webkitdirs.pm:
2869
2870 2009-11-09  Oliver Hunt  <oliver@apple.com>
2871
2872         Reviewed by Geoff Garen.
2873
2874         Make do-webcore-rename work with git.
2875
2876         * Scripts/do-webcore-rename:
2877
2878 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2879
2880         Adding Kenneth to the reviewers list.
2881
2882         * Scripts/modules/committers.py:
2883
2884 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2885
2886         Reviewed by Jan Alonzo.
2887
2888         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2889         https://bugs.webkit.org/show_bug.cgi?id=30482
2890
2891         LayoutTestControllerGtk now uses the exposed
2892         Page::tabKeyCyclesThroughElements API
2893
2894         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2895         (LayoutTestController::setTabKeyCyclesThroughElements):
2896
2897 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
2898
2899         Reviewed by Holger Freyther.
2900
2901         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
2902         This helps to pass the test case below. Also replaced hardcoded
2903         code numbers with defined constants.
2904         https://bugs.webkit.org/show_bug.cgi?id=31185
2905         
2906         Test: editing/undo/undo-deleteWord.html
2907
2908         * DumpRenderTree/qt/EventSenderQt.cpp:
2909         (EventSender::keyDown):
2910
2911 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
2912
2913         Reviewed by Holger Freyther.
2914
2915         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
2916         https://bugs.webkit.org/show_bug.cgi?id=31164
2917
2918         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
2919
2920         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2921         (LayoutTestController::processWork):
2922
2923 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
2924
2925         Reviewed by Holger Freyther.
2926
2927         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
2928         https://bugs.webkit.org/show_bug.cgi?id=31158
2929
2930         By invoking a script queue'd by queueScript(), 'true' was beeing returned
2931         always, which from WorkQueue prospective means that a load has been started
2932         and the queue processing should stop and wait for the load to finish.
2933         Spinning it off into a loading and a non-loading variants was the solution
2934         adopted by Mac's DRT to work around this problem. The former keeps returning
2935         'true' while the later executes the script synchronously and returns 'false'
2936         making it possible to the WorkQueue to proceed right away.
2937
2938         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2939         (LayoutTestController::processWork):
2940         (LayoutTestController::queueLoadingScript):
2941         (LayoutTestController::queueNonLoadingScript):
2942         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2943         * DumpRenderTree/qt/WorkQueueItem.h:
2944         (LoadingScriptItem::LoadingScriptItem):
2945         (LoadingScriptItem::invoke):
2946         (NonLoadingScriptItem::NonLoadingScriptItem):
2947         (NonLoadingScriptItem::invoke):
2948
2949 2009-11-07  Mark Rowe  <mrowe@apple.com>
2950
2951         Rubber-stamped by Cameron Zwarich.
2952
2953         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
2954
2955         * Scripts/commit-log-editor:
2956
2957 2009-11-07  Mark Rowe  <mrowe@apple.com>
2958
2959         Reviewed by Darin Adler.
2960
2961         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
2962         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
2963
2964         Move logic for determining the name and email address to use in a ChangeLog entry from
2965         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
2966         whether the author of the patch matches committer, and therefore needs access to the
2967         email address that would be used in a ChangeLog entry.
2968
2969         Based on a patch by Pierre d'Herbemont.
2970
2971         * Scripts/VCSUtils.pm:
2972         * Scripts/commit-log-editor:
2973         * Scripts/prepare-ChangeLog:
2974         * Scripts/webkitdirs.pm:
2975
2976 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2977
2978         Reviewed by Adam Barth.
2979
2980         Added functionality to the layout test plugin to invoke document.open and
2981         window.open with default arguments. The associated webkit bug is
2982         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
2983         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
2984         work in Chromium (V8) if there is no calling javascript context. To achieve this
2985         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
2986         for the window.open test case and in NPP_DestroyStream for the document.open test case.
2987
2988         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2989         (testDocumentOpen):
2990         (testWindowOpen):
2991         (pluginAllocate):
2992         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2993         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2994         (NPP_New):
2995         (NPP_SetWindow):
2996         (NPP_DestroyStream):
2997         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2998         (NPP_New):
2999         (NPP_SetWindow):
3000         (NPP_NewStream):
3001         (NPP_DestroyStream):
3002
3003 2009-11-06  Eric Seidel  <eric@webkit.org>
3004
3005         Reviewed by Adam Barth.
3006
3007         bugzilla-tool crashed with exception
3008         https://bugs.webkit.org/show_bug.cgi?id=31092
3009
3010         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
3011
3012 2009-11-04  Eric Seidel  <eric@webkit.org>
3013
3014         No review, just add a line which got left out of the patch uploaded for commit.
3015
3016         commit-queue is crashing when trying to reject patches after unknown failures
3017         https://bugs.webkit.org/show_bug.cgi?id=31091
3018
3019         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
3020
3021 2009-11-04  Adam Roben  <aroben@apple.com>
3022
3023         Remove bogus else clause in bugzilla-tool
3024
3025         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
3026         create-bug raises exception after entering bug description
3027
3028         Reviewed by David Kilzer.
3029
3030         * Scripts/bugzilla-tool:
3031         (CreateBug): else clauses are only hit if no exception is raised, so
3032         it makes no sense to try to re-raise the exception in an else clause.
3033         The exception will automatically be re-raised if it doesn't match any
3034         of the except clauses, so we don't have to do anything special here at
3035         all to get the desired behavior.
3036
3037 2009-11-04  Eric Seidel  <eric@webkit.org>
3038
3039         Reviewed by David Kilzer.
3040
3041         svn-apply's fixChangeLogPatch function seems broken
3042         https://bugs.webkit.org/show_bug.cgi?id=30683
3043
3044         Update fixChangeLogPatch to be able to handle patches which
3045         don't start at line 1.
3046         Add unit tests for svn-apply to scm_unittest.py.
3047
3048         * Scripts/VCSUtils.pm:
3049         * Scripts/modules/scm_unittest.py:
3050
3051 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
3052
3053         Reviewed by Beth Dakin.
3054
3055         Need to implement ARIA role="combobox"
3056         https://bugs.webkit.org/show_bug.cgi?id=31096
3057
3058         * DumpRenderTree/AccessibilityUIElement.cpp:
3059         (showMenuCallback):
3060         (getIsExpandedCallback):
3061         (AccessibilityUIElement::getJSClass):
3062         * DumpRenderTree/AccessibilityUIElement.h:
3063         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3064         (AccessibilityUIElement::isExpanded):
3065         (AccessibilityUIElement::showMenu):
3066         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3067         (AccessibilityUIElement::isExpanded):
3068         (AccessibilityUIElement::showMenu):
3069         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3070         (AccessibilityUIElement::isSelected):
3071         (AccessibilityUIElement::isExpanded):
3072         (AccessibilityUIElement::showMenu):
3073
3074 2009-11-04  Eric Seidel  <eric@webkit.org>
3075
3076         Reviewed by Adam Barth.
3077
3078         commit-queue is crashing when trying to reject patches after unknown failures
3079         https://bugs.webkit.org/show_bug.cgi?id=31091
3080
3081         * Scripts/bugzilla-tool:
3082          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
3083            so we have to find out what the current patch is by asking bugzilla again.
3084          - Discovered that this code was also leaking file descriptors, so fixed that.
3085
3086 2009-11-04  Adam Roben  <aroben@apple.com>
3087
3088         Make run-webkit-tests work for the Debug_Internal Windows
3089         configuration
3090
3091         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
3092         suffix.
3093
3094         Fixes <http://webkit.org/b/31123>.
3095
3096         Reviewed by Sam Weinig.
3097
3098         * Scripts/run-webkit-tests: Don't add the _debug suffix in
3099         Debug_Internal, either.
3100
3101 2009-11-04  Eric Seidel  <eric@webkit.org>
3102
3103         Reviewed by Adam Barth.
3104
3105         committers.py needs a way to store non-bugzilla email addresses
3106         https://bugs.webkit.org/show_bug.cgi?id=31037
3107
3108         Make Committer and Reviewer constructors take a single email or a list of emails.
3109         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
3110         Expose reviewers(), used by validate-committer-lists on bug 30970.
3111
3112         * Scripts/modules/committers.py:
3113         * Scripts/modules/committers_unittest.py: Added tests for the new code.
3114
3115 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
3116
3117         Reviewed by David Levin.
3118
3119         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
3120         https://bugs.webkit.org/show_bug.cgi?id=27491
3121
3122         The test path determination logic is changed to handle websocket and websocket/ssl cases.
3123         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
3124
3125         Functions to start or stop Web Socket servers are added.
3126
3127         * Scripts/run-webkit-tests:
3128
3129 2009-11-03  Eric Seidel  <eric@webkit.org>
3130
3131         No review, just changing wording of log message.
3132
3133         Change log string to say "failed" instead of "rejected"
3134         when a commit fails due to an out of date checkout.
3135         This makes grepping the commit-queue log for rejected patches easier.
3136
3137         * Scripts/bugzilla-tool:
3138
3139 2009-11-03  Eric Seidel  <eric@webkit.org>
3140
3141         No review, adding commonly known committers missing from the file.
3142
3143         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
3144
3145 2009-11-03  Eric Seidel  <eric@webkit.org>
3146
3147         No review, just sort-order cleanup.
3148
3149         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
3150
3151 2009-11-03  Stephen White  <senorblanco@chromium.org>
3152
3153         (Unreviewed).
3154
3155         Add myself to committers.py.
3156
3157         * Scripts/modules/committers.py:
3158
3159 2009-11-03  Robin Dunn  <robin@alldunn.com>
3160
3161         Reviewed by Kevin Ollviier.
3162
3163         Add packaging scripts for Debian-based Linux distros.
3164         
3165         https://bugs.webkit.org/show_bug.cgi?id=31075
3166
3167         * wx/packaging/build-debian-installer.py: Added.
3168         * wx/packaging/debian: Added.
3169
3170 2009-11-03  Dan Bernstein  <mitz@apple.com>
3171
3172         Reviewed by Anders Carlsson and Beth Dakin.
3173
3174         https://bugs.webkit.org/show_bug.cgi?id=31070
3175
3176         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
3177         destroyed, it executes the value of the 'ondestroy' parameter as a
3178         script.
3179
3180         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3181         (pluginAllocate): Initialize onDestroy.
3182         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
3183         onDestroy.
3184         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3185         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
3186         specified.
3187         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
3188
3189 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3190
3191         Reviewed by Xan Lopez.
3192
3193         https://bugs.webkit.org/show_bug.cgi?id=31035
3194         [GTK] some accessibility tests hitting assertion in debug builds
3195
3196         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
3197
3198         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3199         (AccessibilityController::rootElement):
3200
3201 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
3202
3203         Reviewed by Beth Dakin.
3204
3205         Support ARIA "tab" roles
3206         https://bugs.webkit.org/show_bug.cgi?id=30842
3207
3208         * DumpRenderTree/AccessibilityUIElement.cpp:
3209         * DumpRenderTree/AccessibilityUIElement.h:
3210         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3211         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3212         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3213
3214 2009-11-01  Eric Seidel  <eric@webkit.org>
3215
3216         Reviewed by David Levin.
3217
3218         buildbots should use --exit-after-N-failures
3219         https://bugs.webkit.org/show_bug.cgi?id=30809
3220
3221         Make the bots exit after 20 failures to prevent never-ending
3222         test runs where every test spends a minute crashing.
3223
3224         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3225
3226 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3227
3228         Reviewed by Eric Seidel.
3229
3230         Turn on warnings for QtWebKit for gcc
3231         https://bugs.webkit.org/show_bug.cgi?id=30958
3232
3233         * DumpRenderTree/qt/main.cpp: 
3234         (crashHandler): Mark function NO_RETURN
3235
3236 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
3237
3238         Adding myself to the committers list.
3239
3240         * Scripts/modules/committers.py:
3241
3242 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
3243
3244         Fix an issue that Adam noticed in DRT.
3245
3246         Reviewed by Darin Adler.
3247
3248         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3249         (AccessibilityUIElement::role):
3250         Get the length of the role text, and create a buffer dynamically.
3251
3252 2009-10-30  Eric Seidel  <eric@webkit.org>
3253
3254         No review, rolling out r50105.
3255         http://trac.webkit.org/changeset/50105
3256
3257         This commit was causing:
3258         https://bugs.webkit.org/show_bug.cgi?id=30869
3259         We'll re-implement the feature a different way.
3260
3261         * Scripts/bugzilla-tool:
3262
3263 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
3264
3265         Test for MSAA: Accessibility of headings is not correct
3266
3267         https://bugs.webkit.org/show_bug.cgi?id=30937
3268
3269         Reviewed by Adam Roben.
3270
3271         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3272         (AccessibilityUIElement::role):
3273         Allow the role returned to be a BSTR.
3274         (AccessibilityUIElement::description):
3275         Fix a copy/paste error.
3276
3277 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
3278
3279         Test for MSAA: Accessibility of links is wrong
3280
3281         https://bugs.webkit.org/show_bug.cgi?id=30928
3282
3283         Reviewed by Darin Adler.
3284
3285         * DumpRenderTree/AccessibilityUIElement.cpp:
3286         (getAccessibilityValueCallback):
3287         Return the accessibility value.
3288         (AccessibilityUIElement::getJSClass):
3289         Added "accessibilityValue" value.
3290
3291         * DumpRenderTree/AccessibilityUIElement.h:
3292
3293         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3294         (AccessibilityUIElement::accessibilityValue):
3295         Stubbed.
3296
3297         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3298         (AccessibilityUIElement::accessibilityValue):
3299         Stubbed.
3300
3301         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3302         (AccessibilityUIElement::accessibilityValue):
3303         Get the object's value, and return it as a JS string.
3304
3305 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
3306
3307         Fix typo in command name used by wx build system.
3308
3309         * wx/build/build_utils.py:
3310
3311 2009-10-30  Adam Barth  <abarth@webkit.org>
3312
3313         Reviewed by Darin Adler.
3314
3315         Patch v1 is a dumb default name for patches
3316         https://bugs.webkit.org/show_bug.cgi?id=30952
3317
3318         Let's use "Patch" instead.
3319
3320         * Scripts/bugzilla-tool:
3321
3322 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3323
3324         Unreviewed trivial buildfix.
3325
3326         [Qt] Buildfix for r50333.
3327
3328         * DumpRenderTree/qt/DumpRenderTree.pro:
3329
3330 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
3331
3332         Reviewed by Holger Freyther.
3333
3334         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
3335         https://bugs.webkit.org/show_bug.cgi?id=30953
3336
3337         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
3338         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
3339         makes qt DRT to share this implementation (as gtk and mac ports do).
3340
3341         * DumpRenderTree/qt/DumpRenderTree.pro:
3342         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
3343         * DumpRenderTree/qt/WorkQueue.h: Removed.
3344
3345 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3346
3347         Unreviewed potential buildbot fix.
3348
3349         Second try: Reset page history before running each test.
3350
3351         Apparently the QWebHistory::clear() keeps the current page
3352         in history which is not what we want, so we not additionally
3353         sets the history capacity to 0 (forces removing everything)
3354         and then sets it back to its original value.
3355
3356         * DumpRenderTree/qt/DumpRenderTree.cpp:
3357         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3358
3359 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3360
3361         Unreviewed potential buildbot fix.
3362
3363         Reset page history before running each test.
3364
3365         * DumpRenderTree/qt/DumpRenderTree.cpp:
3366         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3367
3368 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
3369
3370         Reviewed by Eric Seidel.
3371
3372         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
3373
3374         Bug 28420 -  Implement HTML5 <ruby> rendering
3375         (https://bugs.webkit.org/show_bug.cgi?id=28420)
3376
3377         No new tests (no functional change).
3378
3379         * Scripts/build-webkit:
3380
3381 2009-10-29  Dan Bernstein  <mitz@apple.com>
3382
3383         Reviewed by Mark Rowe.
3384
3385         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
3386         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
3387         define it.
3388
3389         * Scripts/VCSUtils.pm:
3390         * Scripts/svn-apply:
3391         * Scripts/svn-unapply:
3392
3393 2009-10-29  Xan Lopez  <xlopez@igalia.com>
3394
3395         Reviewed by Gustavo Noronha.
3396
3397         Use the GTK+ main loop instead of rolling our own mini-version of
3398         it.
3399
3400         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3401         (dump):
3402         (runTest):
3403         (webViewLoadFinished):
3404
3405 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3406
3407         Reviewed by Oliver Hunt.
3408
3409         Implement the Qt version of DRT dumpBackForwardList().
3410
3411         * DumpRenderTree/qt/DumpRenderTree.cpp:
3412         (WebCore::dumpHistoryItem):
3413         (WebCore::DumpRenderTree::dumpBackForwardList):
3414
3415 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3416
3417         Reviewed by Adam Roben.
3418
3419         Implement DRT functionality for Qt introduced in
3420         r28690 and r28705.
3421
3422         - Implemented pathToLocalResource which exposes the functionality of
3423         converting a given unix path to the correct location on Windows.
3424         - Implemented a way to remove machine-dependent information from paths
3425         in layout test results.
3426
3427         * DumpRenderTree/qt/DumpRenderTree.cpp:
3428         (WebCore::urlSuitableForTestResult):
3429         (WebCore::WebPage::javaScriptConsoleMessage):
3430         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3431         (LayoutTestController::pathToLocalResource):
3432         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3433
3434 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
3435
3436         Adding myself to the committers list.
3437
3438         * Scripts/modules/committers.py:
3439
3440 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
3441
3442         Adding myself to the committers list.
3443
3444         * Scripts/modules/committers.py:
3445
3446 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3447
3448         Reviewed by Jan Alonzo.
3449
3450         [GTK] API to start inspector for a WebView
3451         https://bugs.webkit.org/show_bug.cgi?id=22551
3452
3453         Use the new inspector API to implement the LayoutTestController
3454         interfaces used to test the inspector.
3455
3456         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3457         (webInspectorInspectWebView):
3458         (createWebView):
3459         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3460         (LayoutTestController::showWebInspector):
3461         (LayoutTestController::closeWebInspector):
3462         (LayoutTestController::evaluateInWebInspector):
3463
3464 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
3465
3466         Reviewed by Eric Seidel.
3467
3468         [Qt] WebFrame::counterValueForElementById must not be exposed
3469         https://bugs.webkit.org/show_bug.cgi?id=30882
3470
3471         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3472         (LayoutTestController::counterValueForElementById):
3473
3474 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3475
3476         Rubberstamped by Oliver Hunt.
3477
3478         Fix the warning:
3479
3480         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
3481         declared with attribute warn_unused_result".
3482
3483         by actually checking the result. In the case it is null, an
3484         error has occoured, so treat it as the other fatal errors.
3485
3486         * DumpRenderTree/qt/DumpRenderTree.cpp:
3487         (WebCore::DumpRenderTree::initializeFonts):
3488
3489 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
3490
3491         Reviewed by Darin Adler.
3492
3493         Provide a way to get counter values with layoutTestContoller
3494         https://bugs.webkit.org/show_bug.cgi?id=30555
3495
3496         Define layoutTestContoller.counterValueForElementById.
3497
3498         * DumpRenderTree/LayoutTestController.cpp:
3499         (counterValueForElementByIdCallback):
3500         (LayoutTestController::staticFunctions):
3501         * DumpRenderTree/LayoutTestController.h:
3502         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3503         (LayoutTestController::counterValueForElementById):
3504
3505 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3506
3507         Rubberstamped by Oliver Hunt.
3508
3509         Change two methods to be internal for DRT use only.
3510
3511         Part of [Qt] Review all new API in Qt 4.6
3512         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
3513
3514         * DumpRenderTree/qt/DumpRenderTree.cpp:
3515         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3516         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3517         (LayoutTestController::whiteListAccessFromOrigin):
3518
3519 2009-10-27  Eric Seidel  <eric@webkit.org>
3520
3521         Reviewed by Adam Barth.
3522
3523         REGRESSION: svn-apply exits(1) when applying a patch with a file add
3524         https://bugs.webkit.org/show_bug.cgi?id=30826
3525
3526         * Scripts/svn-apply:
3527          - Add () around all system() calls.
3528          - Use the correct system() == 0 or die instead of system() or die
3529          - Add descriptive messages to all die statements.
3530
3531 2009-10-27  Steve Block  <steveblock@google.com>
3532
3533         Reviewed by NOBODY.
3534
3535         Adds steveblock@google.com to list of committers.
3536
3537         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
3538
3539 2009-10-27  Eric Seidel  <eric@webkit.org>
3540
3541         Reviewed by Adam Barth.
3542
3543         svn-apply can exit(0) even on patch failure
3544         https://bugs.webkit.org/show_bug.cgi?id=29622
3545
3546         * Scripts/svn-apply:
3547          - Add a bunch of "or die" statements, hopefully catching all
3548            possible cases where failure could still exit(0).
3549
3550 2009-10-27  Eric Seidel  <eric@webkit.org>
3551
3552         Reviewed by Adam Barth.
3553
3554         svn-* scripts should share code through VCSUtils.pm
3555         https://bugs.webkit.org/show_bug.cgi?id=30791
3556
3557         Just moving code into a shared location.
3558
3559         * Scripts/VCSUtils.pm:
3560         * Scripts/prepare-ChangeLog:
3561         * Scripts/resolve-ChangeLogs:
3562         * Scripts/svn-apply:
3563         * Scripts/svn-create-patch:
3564         * Scripts/svn-unapply:
3565         * Scripts/update-webkit:
3566
3567 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
3568
3569         Suppress a huge number of MSVC warnings when building wxWebKit.
3570
3571         * wx/build/settings.py:
3572
3573 2009-10-26  Eric Seidel  <eric@webkit.org>
3574
3575         No review, just adding Mike Belshe to the committers list.
3576
3577         * Scripts/modules/committers.py:
3578
3579 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3580
3581         Reviewed by Darin Adler.
3582
3583         Make .rc files compile on Windows without depending on MFC headers
3584         https://bugs.webkit.org/show_bug.cgi?id=30750
3585
3586         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
3587         windows.h instead of afxres.h because it exists even when MFC is not 
3588         installed, and is all that's needed here.
3589
3590         * FindSafari/FindSafari.rc: Ditto
3591
3592 2009-10-24  Eric Seidel  <eric@webkit.org>
3593
3594         Reviewed by Adam Barth.
3595
3596         bugzilla-tool post-diff should know how to mark commit-queue=?
3597         https://bugs.webkit.org/show_bug.cgi?id=29202
3598
3599         * Scripts/bugzilla-tool:
3600          - Add --commit-queue option to post-diff, post-commits and create-bug.
3601         * Scripts/modules/bugzilla.py:
3602          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
3603          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
3604
3605 2009-10-23  Eric Seidel  <eric@webkit.org>
3606
3607         Reviewed by Adam Barth.
3608
3609         bugzilla-tool commit-queue does not notice modifications to committers.py
3610         https://bugs.webkit.org/show_bug.cgi?id=30084
3611
3612         * Scripts/bugzilla-tool:
3613          - Make commit-queue re-exec itself instead of using while(1).
3614          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
3615          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
3616
3617 2009-10-22  Eric Seidel  <eric@webkit.org>
3618
3619         Reviewed by Adam Barth.
3620
3621         commit-queue will get stuck on patches if land-patches terminates unexpectedly
3622         https://bugs.webkit.org/show_bug.cgi?id=30634
3623
3624         * Scripts/bugzilla-tool:
3625          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
3626          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
3627
3628 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
3629
3630         Reviewed by Eric Seidel.
3631
3632         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
3633
3634         https://bugs.webkit.org/show_bug.cgi?id=30763
3635
3636         * pywebsocket/mod_pywebsocket/__init__.py:
3637         * pywebsocket/mod_pywebsocket/dispatch.py:
3638         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
3639         * pywebsocket/mod_pywebsocket/standalone.py:
3640         * pywebsocket/setup.py:
3641         * pywebsocket/test/test_dispatch.py:
3642
3643 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
3644
3645         Reviewed by David Levin.
3646
3647         REGRESSION: 2 failures in run-webkit-unittests
3648         https://bugs.webkit.org/show_bug.cgi?id=30645
3649
3650         * Scripts/modules/cpp_style_unittest.py:
3651         Fixed a few test scenarios which apparently lost some spaces from 
3652         text literals.
3653
3654 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
3655
3656         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
3657
3658         * Scripts/webkitdirs.pm:
3659
3660 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
3661
3662         Reviewed by Darin Adler.
3663
3664         Unification of using null device in perl scripts.
3665         https://bugs.webkit.org/show_bug.cgi?id=30572
3666
3667         * Scripts/VCSUtils.pm:
3668         * Scripts/bisect-builds:
3669         * Scripts/resolve-ChangeLogs:
3670         * Scripts/run-iexploder-tests:
3671         * Scripts/run-jsc:
3672         * Scripts/run-mangleme-tests:
3673         * Scripts/run-webkit-tests:
3674         * Scripts/webkitdirs.pm:
3675         Using File::Spec->devnull() instead of hard coded /dev/null.
3676
3677 2009-10-26  Eric Seidel  <eric@webkit.org>
3678
3679         Reviewed by Holger Freyther.
3680
3681         Reviewers are missing from committers.py
3682         https://bugs.webkit.org/show_bug.cgi?id=30733
3683
3684         * Scripts/modules/committers.py:
3685
3686 2009-10-23  Eric Seidel  <eric@webkit.org>
3687
3688         No review, only adding Alice to the list of reviewers.
3689
3690         * Scripts/modules/committers.py:
3691
3692 2009-10-23  Eric Seidel  <eric@webkit.org>
3693
3694         Reviewed by Eric Carlson.
3695
3696         fast/media/mq-transform-02.html failed on Leopard Commit Bot
3697         https://bugs.webkit.org/show_bug.cgi?id=30700
3698
3699         * DumpRenderTree/mac/DumpRenderTree.mm:
3700         (resetDefaultsToConsistentValues): Update QuickTime version check.
3701
3702 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
3703
3704         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
3705         character measurement APIs that are private on Tiger.
3706
3707         * wx/build/settings.py:
3708
3709 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3710
3711         Reviewed by NOBODY (build fix).
3712         Build fix following bug #30696.
3713
3714         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3715         (LayoutTestController::evaluateScriptInIsolatedWorld):
3716
3717 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3718
3719         Reviewed by Sam Weinig & Geoff Garen.
3720
3721         https://bugs.webkit.org/show_bug.cgi?id=30696
3722         Enable isolated-worlds tests on mac.
3723
3724         Add private interface for DRT to invoke execution in a given world.
3725
3726         * DumpRenderTree/LayoutTestController.cpp:
3727         (evaluateScriptInIsolatedWorldCallback):
3728         (LayoutTestController::staticFunctions):
3729         * DumpRenderTree/LayoutTestController.h:
3730         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3731         (LayoutTestController::evaluateScriptInIsolatedWorld):
3732         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3733         (LayoutTestController::evaluateScriptInIsolatedWorld):
3734
3735 2009-10-21  Eric Seidel  <eric@webkit.org>
3736
3737         Reviewed by Adam Barth.
3738
3739         bugzilla-tool's "patch failed to download an apply" error should give more information
3740         https://bugs.webkit.org/show_bug.cgi?id=30632
3741
3742         * Scripts/modules/scm.py:
3743          - Use the common run_command method instead of custom POpen code.
3744          - Make run_command know how to take pipes as input.
3745         * Scripts/modules/scm_unittest.py:
3746          - Add new tests to cover change.
3747          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
3748
3749 2009-10-21  Kent Tamura  <tkent@chromium.org>
3750
3751         Unreviewed.  Adding myself to the committers list.
3752
3753         * Scripts/modules/committers.py:
3754
3755 2009-10-21  Robin Dunn  <robin@alldunn.com>
3756
3757         Reviewed by Kevin Ollivier.
3758
3759         Update the Windows installer builder to work with Vista / Win 7 and with git.
3760         
3761         https://bugs.webkit.org/show_bug.cgi?id=30649
3762
3763         * wx/build/build_utils.py:
3764         * wx/packaging/build-mac-installer.py:
3765         * wx/packaging/build-win-installer.py:
3766         * wx/packaging/wxWebKitInstaller.iss.in:
3767
3768 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3769
3770         Reviewed by Gustavo Noronha.
3771
3772         [GTK] Added conditional code to avoid using
3773         gdk_window_get_root_coords if we do not have a gtk+ release newer
3774         than 2.17.3.
3775         https://bugs.webkit.org/show_bug.cgi?id=30636
3776
3777         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3778
3779 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
3780
3781         Reviewed by Eric Seidel.
3782
3783         [Qt] Added dummy implementation for keepWebHistory()
3784         https://bugs.webkit.org/show_bug.cgi?id=30592
3785
3786         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3787         (LayoutTestController::keepWebHistory):
3788         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3789
3790 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3791
3792         Reviewed by Xan Lopez.
3793
3794         [GTK] Fixed the double click condition, it is not double click if
3795         we move in just in one direction.
3796         https://bugs.webkit.org/show_bug.cgi?id=30636
3797
3798         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3799
3800 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3801
3802         Reviewed by Xan Lopez.
3803
3804         [GTK] Initialize the events completly before emitting them.
3805         https://bugs.webkit.org/show_bug.cgi?id=30633
3806
3807         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3808
3809 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3810
3811         wx build fix. Fix for when linking using --as-needed with gcc.
3812
3813         * wx/browser/wscript:
3814
3815 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3816
3817         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
3818         to support all the features used by CURL backend.
3819         
3820         * wx/build/settings.py:
3821         * wx/install-unix-extras:
3822
3823 2009-10-20  Anton Muhin  <antonm@chromium.org>
3824
3825         Reviewed by Adam Barth.
3826
3827         Add {ager,antonm,yurys}@chromium.org into committers.py
3828         https://bugs.webkit.org/show_bug.cgi?id=30560
3829
3830         * Scripts/modules/committers.py:
3831
3832 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3833
3834         Reviewed by Tor Arne Vestbø.
3835
3836         Make the Netscape Test plugin available to the Qt launcher.
3837
3838         * Scripts/run-launcher:
3839
3840 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
3841
3842         Reviewed by David Levin.
3843
3844         Removed WebSocket runtime settings.
3845         https://bugs.webkit.org/show_bug.cgi?id=29896
3846
3847         WebSocket runtime configuration is supported by chromium/v8 only.
3848
3849         * DumpRenderTree/mac/DumpRenderTree.mm:
3850         (resetDefaultsToConsistentValues):
3851         * DumpRenderTree/win/DumpRenderTree.cpp:
3852         (resetDefaultsToConsistentValues):
3853
3854 2009-10-19  Nate Chapin  <japhet@chromium.org>
3855
3856         Reviewed by Adam Barth.
3857
3858         Add testFail() to test plugin so we can test our handling of a
3859         plugin invoke call returning false.
3860
3861         https://bugs.webkit.org/show_bug.cgi?id=30239
3862
3863         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
3864         (pluginInvoke):
3865         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
3866
3867 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
3868
3869         Reviewed by Gustavo Noronha.
3870
3871         Enable DOM pasting when running layout tests.
3872
3873         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3874         (resetDefaultsToConsistentValues):
3875
3876 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3877
3878         Reviewed by Simon Hausmann.
3879
3880         Use the setPreferredContentsSize method instead
3881         of setFixedContentsSize, as the method has been renamed.
3882
3883         * DumpRenderTree/qt/DumpRenderTree.cpp:
3884         (WebCore::DumpRenderTree::open):
3885         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3886         (LayoutTestController::setFixedContentsSize):
3887
3888 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3889
3890         Reviewed by Dan Bernstein.
3891
3892         https://bugs.webkit.org/show_bug.cgi?id=30456
3893         Fixes for new Debug_All Windows build configuration.
3894
3895         * DumpRenderTree/win/DumpRenderTree.cpp:
3896         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
3897         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
3898
3899 2009-10-16  Eric Seidel  <eric@webkit.org>
3900
3901         Reviewed by Adam Barth.
3902
3903         commit-queue status bot should list which buildbot is blocking the queue
3904         https://bugs.webkit.org/show_bug.cgi?id=30452
3905
3906         Add new methods and testing.
3907
3908         * Scripts/bugzilla-tool:
3909         * Scripts/modules/buildbot.py:
3910         * Scripts/modules/buildbot_unittest.py:
3911
3912 2009-10-16  Eric Seidel  <eric@webkit.org>
3913
3914         Reviewed by Adam Barth.
3915
3916         run-webkit-tests fails when CWD is not inside a WebKit checkout
3917         https://bugs.webkit.org/show_bug.cgi?id=30451
3918
3919         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
3920         * Scripts/modules/scm_unittest.py:
3921           - Remove use of original_path (we don't need to restore the CWD).
3922           - Don't use '.' to find the webkit checkout, use __file__ instead.
3923
3924 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3925
3926         Reviewed by Adam Roben.
3927
3928         Add a Debug_All configuration to build entire stack as debug.
3929         Change Debug_Internal to:
3930         - stop using _debug suffix for all WebKit/Safari binaries
3931         - not use _debug as a DLL naming suffix
3932         - use non-debug C runtime lib.
3933
3934         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
3935         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
3936         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
3937         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3938         Add missing debug.vsprops inherited property sheet.
3939         Add Debug_All configuration.
3940         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
3941         * WinLauncher/WinLauncher.vcproj:
3942         Removed extraneous definitions inherited from vsprops.
3943         Add Debug_All configuration.
3944
3945 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
3946
3947         Reviewed by David Levin.
3948
3949         check-webkit-style is wrong about indent checking in namespaces
3950         in header files and a few other things
3951         https://bugs.webkit.org/show_bug.cgi?id=30362
3952
3953         The few other things include:
3954         + check-webkit-style does not require spaces around the equal sign
3955           inside 'if' statements and around binary operators that take 
3956           numeric literals.
3957         + check-webkit-style reports false errors for the / operator
3958           when part of a filename in the #include directive.
3959
3960         * Scripts/modules/cpp_style.py:
3961         Improved indentation checking and space checking around
3962         binary operators. While the checks are still not perfect,
3963         they are clearly better than before.
3964         * Scripts/modules/cpp_style_unittest.py:
3965         Added test cases for the newly supported checks and modified old
3966         test cases to match the new guidelines
3967
3968 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
3969
3970         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
3971
3972         * wx/build/settings.py:
3973
3974 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
3975
3976         Reviewed by David Levin.
3977
3978         Add mod_pywebsocket to test Web Sockets.
3979         http://code.google.com/p/pywebsocket/
3980         https://bugs.webkit.org/show_bug.cgi?id=27490
3981
3982         * pywebsocket/COPYING: Added.
3983         * pywebsocket/MANIFEST.in: Added.
3984         * pywebsocket/README: Added.
3985         * pywebsocket/example/echo_client.py: Added.
3986         * pywebsocket/example/echo_wsh.py: Added.
3987         * pywebsocket/mod_pywebsocket/__init__.py: Added.
3988         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
3989         * pywebsocket/mod_pywebsocket/handshake.py: Added.
3990         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
3991         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
3992         * pywebsocket/mod_pywebsocket/standalone.py: Added.
3993         * pywebsocket/mod_pywebsocket/util.py: Added.
3994         * pywebsocket/setup.py: Added.
3995         * pywebsocket/test/config.py: Added.
3996         * pywebsocket/test/mock.py: Added.
3997         * pywebsocket/test/run_all.py: Added.
3998         * pywebsocket/test/test_dispatch.py: Added.
3999         * pywebsocket/test/test_handshake.py: Added.
4000         * pywebsocket/test/test_mock.py: Added.
4001         * pywebsocket/test/test_msgutil.py: Added.
4002         * pywebsocket/test/test_util.py: Added.
4003         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
4004         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
4005         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
4006         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
4007         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
4008         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
4009         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
4010         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
4011
4012 2009-10-15  James Robinson  <jamesr@google.com>
4013
4014         Reviewed by David Levin.
4015
4016         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
4017
4018         https://bugs.webkit.org/show_bug.cgi?id=30426
4019
4020         * Scripts/modules/cpp_style.py:
4021         * Scripts/modules/cpp_style_unittest.py:
4022
4023 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
4024
4025         Reviewed by Adam Roben.
4026
4027         Fixes <http://webkit.org/b/30411>.
4028         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
4029         
4030         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
4031         building Chromium.
4032
4033         * Scripts/pdevenv:
4034
4035 2009-10-15  Robin Dunn  <robin@alldunn.com>
4036
4037         Reviewed by Kevin Ollivier.
4038
4039         Add Mac package building scripts for wx.
4040         
4041         https://bugs.webkit.org/show_bug.cgi?id=30405
4042
4043         * wx/build/build_utils.py:
4044         * wx/build/settings.py:
4045         * wx/packaging/build-mac-installer.py: Added.
4046
4047 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
4048
4049         Reviewed by Gustavo Noronha.
4050
4051         Enable Web Sockets support when running layout tests.
4052
4053         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4054         (resetDefaultsToConsistentValues):
4055
4056 2009-10-15  Xan Lopez  <xlopez@igalia.com>
4057
4058         Reviewed by Gustavo Noronha.
4059
4060         Need to initialize event.button.button, since in most cases a
4061         button number is not passed as an argument.
4062
4063         * DumpRenderTree/gtk/EventSender.cpp:
4064         (mouseDownCallback):
4065         (mouseUpCallback):
4066
4067 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
4068
4069         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
4070         the OS if none was explicitly set.
4071
4072         * wx/build/settings.py:
4073
4074 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
4075
4076         Reviewed by Timothy Hatcher.
4077
4078         Web Inspector: enable developers extras within inspector layout tests.
4079
4080         https://bugs.webkit.org/show_bug.cgi?id=30014
4081
4082         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4083         (LayoutTestController::showWebInspector):
4084         (LayoutTestController::closeWebInspector):
4085         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4086         (LayoutTestController::showWebInspector):
4087         (LayoutTestController::closeWebInspector):
4088
4089 2009-10-14  José Millán Soto  <jmillan@igalia.com>
4090
4091         Reviewed by Jan Alonzo.
4092
4093         GtkLauncher is using a deprecated signal
4094         https://bugs.webkit.org/show_bug.cgi?id=30364
4095
4096         Modified GtkLauncher to use notify::title signal instead of
4097         deprecated title-changed signal
4098
4099         * GtkLauncher/main.c:
4100         (notify_title_cb):
4101         (create_browser):
4102
4103 2009-10-14  Brady Eidson  <beidson@apple.com>
4104
4105         Reviewed by Sam Weinig.
4106
4107         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
4108         1 - Disables WebHistory
4109         2 - Doesn't make sense in that context anyway.
4110
4111         * DumpRenderTree/win/DumpRenderTree.cpp:
4112         (createWebViewAndOffscreenWindow):
4113
4114 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
4115
4116         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
4117         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
4118
4119         * wx/build/settings.py:
4120         * wx/install-unix-extras:
4121
4122 2009-10-14  Brady Eidson  <beidson@apple.com>
4123
4124         Reviewed by Sam Weinig.
4125
4126         WebKit Win API should provide a delegate interface for global history.
4127         https://bugs.webkit.org/show_bug.cgi?id=29905
4128
4129         * DumpRenderTree/LayoutTestController.cpp:
4130         (LayoutTestController::LayoutTestController):
4131         * DumpRenderTree/LayoutTestController.h:
4132         (LayoutTestController::dumpHistoryDelegateCallbacks):
4133         (LayoutTestController::setDumpHistoryDelegateCallbacks):
4134                 
4135         * DumpRenderTree/win/DumpRenderTree.cpp:
4136         (shouldLogHistoryDelegates):
4137         (runTest):
4138         (createWebViewAndOffscreenWindow):
4139         (main):
4140         * DumpRenderTree/win/DumpRenderTree.vcproj:
4141         
4142         Add the IWebHistoryDelegate to DRT Windows:
4143         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
4144         (wstringFromBSTR):
4145         (HistoryDelegate::HistoryDelegate):
4146         (HistoryDelegate::~HistoryDelegate):
4147         (HistoryDelegate::QueryInterface):
4148         (HistoryDelegate::AddRef):
4149         (HistoryDelegate::Release):
4150         (HistoryDelegate::didNavigateWithNavigationData):
4151         (HistoryDelegate::didPerformClientRedirectFromURL):
4152         (HistoryDelegate::didPerformServerRedirectFromURL):
4153         (HistoryDelegate::updateHistoryTitle):
4154         (HistoryDelegate::populateVisitedLinksForWebView):
4155         * DumpRenderTree/win/HistoryDelegate.h: Added.
4156
4157         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4158         (LayoutTestController::removeAllVisitedLinks):
4159
4160 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
4161
4162         Reviewed by Simon Hausmann.
4163
4164         [Qt] Implement support for setPOSIXLocale on Qt.
4165         https://bugs.webkit.org/show_bug.cgi?id=30268 
4166  
4167         * DumpRenderTree/qt/DumpRenderTree.cpp:
4168         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4169         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4170         (LayoutTestController::setPOSIXLocale):
4171         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4172
4173 2009-10-13  Stephanie Lewis  <slewis@apple.com>
4174
4175         Unreviewed, adding myself to reviewers list.
4176
4177         * Scripts/modules/committers.py:
4178
4179 2009-10-13  Stephanie Lewis  <slewis@apple.com>
4180
4181         Reviewed by Mark Rowe.
4182
4183         Fix null assignment so root tests work again.
4184
4185         * Scripts/webkitdirs.pm:
4186
4187 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
4188
4189         Reviewed by Simon Hausmann.
4190
4191         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
4192         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
4193         This is done in preparation of implementing missing features in DRT.
4194         No functionality changes made yet.
4195
4196         * DumpRenderTree/qt/DumpRenderTree.cpp:
4197         * DumpRenderTree/qt/DumpRenderTree.pro:
4198         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
4199         (EventSender::EventSender):
4200         (EventSender::mouseDown):
4201         (EventSender::mouseUp):
4202         (EventSender::mouseMoveTo):
4203         (EventSender::leapForward):
4204         (EventSender::keyDown):
4205         (EventSender::contextClick):
4206         (EventSender::scheduleAsynchronousClick):
4207         (EventSender::frameUnderMouse):
4208         * DumpRenderTree/qt/EventSenderQt.h: Added.
4209         (EventSender::clearKillRing):
4210         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
4211         (LayoutTestController::LayoutTestController):
4212         (LayoutTestController::reset):
4213         (LayoutTestController::processWork):
4214         (LayoutTestController::maybeDump):
4215         (LayoutTestController::waitUntilDone):
4216         (LayoutTestController::notifyDone):
4217         (LayoutTestController::windowCount):
4218         (LayoutTestController::clearBackForwardList):
4219         (LayoutTestController::dumpEditingCallbacks):
4220         (LayoutTestController::dumpResourceLoadCallbacks):
4221         (LayoutTestController::queueBackNavigation):
4222         (LayoutTestController::queueForwardNavigation):
4223         (LayoutTestController::queueLoad):
4224         (LayoutTestController::queueReload):
4225         (LayoutTestController::queueScript):
4226         (LayoutTestController::provisionalLoad):
4227         (LayoutTestController::timerEvent):
4228         (LayoutTestController::encodeHostName):
4229         (LayoutTestController::decodeHostName):
4230         (LayoutTestController::setJavaScriptProfilingEnabled):
4231         (LayoutTestController::setFixedContentsSize):
4232         (LayoutTestController::setPrivateBrowsingEnabled):
4233         (LayoutTestController::setPopupBlockingEnabled):
4234         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
4235         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
4236         (LayoutTestController::numberOfActiveAnimations):
4237         (LayoutTestController::disableImageLoading):
4238         (LayoutTestController::dispatchPendingLoadRequests):
4239         (LayoutTestController::setDatabaseQuota):
4240         (LayoutTestController::clearAllDatabases):
4241         (LayoutTestController::whiteListAccessFromOrigin):
4242         (LayoutTestController::waitForPolicyDelegate):
4243         (LayoutTestController::overridePreference):
4244         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
4245         (LayoutTestController::isLoading):
4246         (LayoutTestController::setLoading):
4247         (LayoutTestController::shouldDumpAsText):
4248         (LayoutTestController::shouldDumpBackForwardList):
4249         (LayoutTestController::shouldDumpChildrenAsText):
4250         (LayoutTestController::shouldDumpDatabaseCallbacks):
4251         (LayoutTestController::shouldDumpStatusCallbacks):
4252         (LayoutTestController::shouldWaitUntilDone):
4253         (LayoutTestController::canOpenWindows):
4254         (LayoutTestController::shouldDumpTitleChanges):
4255         (LayoutTestController::waitForPolicy):
4256         (LayoutTestController::dumpAsText):
4257         (LayoutTestController::dumpChildFramesAsText):
4258         (LayoutTestController::dumpDatabaseCallbacks):
4259         (LayoutTestController::dumpStatusCallbacks):
4260         (LayoutTestController::setCanOpenWindows):
4261         (LayoutTestController::dumpBackForwardList):
4262         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
4263         (LayoutTestController::display):
4264         (LayoutTestController::dumpTitleChanges):
4265         (LayoutTestController::dumpSelectionRect):
4266         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
4267         (TextInputController::TextInputController):
4268         (TextInputController::doCommand):
4269         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
4270         * DumpRenderTree/qt/WorkQueue.cpp:
4271         * DumpRenderTree/qt/WorkQueue.h:
4272         * DumpRenderTree/qt/WorkQueueItem.h:
4273         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
4274         (findFrameNamed):
4275         (LoadItem::invoke):
4276         (ReloadItem::invoke):
4277         (ScriptItem::invoke):
4278         (BackForwardItem::invoke):
4279         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
4280         * DumpRenderTree/qt/jsobjects.h:
4281
4282 2009-10-13  Dmitry Titov  <dimich@chromium.org>
4283
4284         Not reviewed, adding myself to the list of reviewers.
4285
4286         * Scripts/modules/committers.py:
4287
4288 2009-10-13  Anders Carlsson  <andersca@apple.com>
4289
4290         Reviewed by Sam Weinig.
4291
4292         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
4293
4294         Make the private browsing mode testable by the test plug-in.
4295         
4296         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
4297         (pluginGetProperty):
4298         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
4299         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
4300         (NPP_New):
4301         (NPP_SetValue):
4302
4303 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
4304
4305         No review, just adding self to the list of reviewers.
4306
4307         * Scripts/modules/committers.py:
4308
4309 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
4310
4311         Reviewed by Adam Roben.
4312
4313         Web Inspector: Use proper web view in inspector layout
4314         tests for windows.
4315
4316         https://bugs.webkit.org/show_bug.cgi?id=30298
4317
4318         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4319         (LayoutTestController::showWebInspector):
4320         (LayoutTestController::closeWebInspector):
4321         (LayoutTestController::evaluateInWebInspector):
4322
4323 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
4324
4325         Reviewed by Sam Weinig.
4326
4327         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
4328         https://bugs.webkit.org/show_bug.cgi?id=29841
4329
4330         * DumpRenderTree/mac/DumpRenderTree.mm:
4331         (resetDefaultsToConsistentValues):
4332         * DumpRenderTree/win/DumpRenderTree.cpp:
4333         (resetDefaultsToConsistentValues):
4334
4335 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
4336
4337         Reviewed by Dimitri Glazkov.
4338
4339         Chromium Port - Windows
4340         https://bugs.webkit.org/show_bug.cgi?id=29969
4341
4342         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
4343         * Scripts/webkitdirs.pm:
4344
4345 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
4346
4347         Reviewed by Darin Adler.
4348
4349         jsc scripts cleanup and Qt/GTK fix
4350         https://bugs.webkit.org/show_bug.cgi?id=30288
4351
4352         Duplicated jscPath() moved to webkitdirs.pm.
4353         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
4354         Configuration added (release/debug) to path for Qt-port on Windows.
4355
4356         * Scripts/run-javascriptcore-tests:
4357         * Scripts/run-jsc:
4358         * Scripts/run-sunspider:
4359         * Scripts/sunspider-compare-results:
4360         * Scripts/webkitdirs.pm:
4361
4362 2009-10-11  Adam Barth  <abarth@webkit.org>