WebKitTools/ChangeLog

   1 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
   2
   3         Reviewed by Adam.
   4
   5         - Make Drosera show source, source URLs, and function stack on Windows,
   6         and some minor fixes.
   7
   8         * Drosera/DebuggerDocument.cpp: Force source to always update display.
   9         (DebuggerDocument::updateFileSource):
  10         * Drosera/debugger.js: Force source to always update display.
  11         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
  12         menu controls.
  13         (DebuggerClient::resume):
  14         (DebuggerClient::pause):
  15         (DebuggerClient::stepInto):
  16         (DebuggerClient::stepOver):
  17         (DebuggerClient::stepOut):
  18         (DebuggerClient::showConsole):
  19         (DebuggerClient::closeCurrentFile):
  20         * Drosera/win/DebuggerClient.h: Ditto.
  21         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
  22         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
  23         removed two bugs.  1) caller could be in a bad state when asked to
  24         assign into it. 2) BSTRs were not created correctly.
  25         (DebuggerDocument::getPlatformCurrentFunctionStack):
  26         * Drosera/win/Drosera.cpp: Hook up the menu controls.
  27         (droseraWndProc):
  28         (handleCommand):
  29         (Drosera::resume):
  30         (Drosera::pause):
  31         (Drosera::stepInto):
  32         (Drosera::stepOver):
  33         (Drosera::stepOut):
  34         (Drosera::showConsole):
  35         (Drosera::closeCurrentFile):
  36         * Drosera/win/Drosera.h: Hook up the menu controls.
  37         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
  38         functions, added a null check, and fixed another bug where caller could
  39         be in a bad state when asked to assign into it.
  40         (ServerConnection::didLoadMainResourceForDataSource):
  41         (ServerConnection::getCallerFrame):
  42         * Drosera/win/ServerConnection.h: Safety first.
  43
  44 2007-11-13  Dan Bernstein  <mitz@apple.com>
  45
  46         Reviewed by Darin Adler.
  47
  48         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
  49           DumpRenderTree --pixel-tests renders each test twice
  50
  51         * DumpRenderTree/mac/DumpRenderTree.mm:
  52         (dumpRenderTree): Removed the --paint option because the painting code
  53         is always exercised as a result of
  54         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
  55         calling -displayIfNeeded.
  56         (dump): Changed to always grab the image from the window since the view
  57         is always displayed.
  58         (runTest):
  59         (displayWebView):
  60         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
  61         because it always paints.
  62
  63 2007-11-12  Antti Koivisto  <antti@apple.com>
  64
  65         Reviewed by Adele.
  66
  67         Add support for http media tests
  68
  69         * Scripts/run-webkit-tests:
  70
  71 2007-11-12  Sam Weinig  <sam@webkit.org>
  72
  73         Reviewed by Adam Roben.
  74
  75         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
  76
  77         * DumpRenderTree/win/DumpRenderTree.cpp:
  78         (runTest):
  79         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  80         (LayoutTestController::setPrivateBrowsingEnabled):
  81
  82 2007-11-12  Adam Roben  <aroben@apple.com>
  83
  84         * Scripts/update-webkit-localizable-strings: Changed to only scan the
  85         mac and win subdirectories.
  86
  87 2007-11-11  Adam Roben  <aroben@apple.com>
  88
  89         Fix <rdar://5133816> keepWebHistory is not implemented
  90
  91         Fixes fast/history/clicked-link-is-visited.html.
  92
  93         Reviewed by Darin.
  94
  95         * DumpRenderTree/win/DumpRenderTree.cpp:
  96         (runTest): Clear the optionalSharedHistory.
  97         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  98         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
  99
 100 2007-11-10  Sam Weinig  <sam@webkit.org>
 101
 102         Reviewed by Tim Hatcher.
 103
 104         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript
 105         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions
 106         is turned on)
 107
 108         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
 109
 110         Added test: http/tests/security/cross-frame-access-private-browsing.html
 111
 112         * DumpRenderTree/LayoutTestController.cpp:
 113         (setPrivateBrowsingEnabledCallback):
 114         (LayoutTestController::staticFunctions):
 115         * DumpRenderTree/LayoutTestController.h:
 116         * DumpRenderTree/mac/DumpRenderTree.mm:
 117         (runTest): Default to private browsing disabled.
 118         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 119         (LayoutTestController::setPrivateBrowsingEnabled):
 120         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 121         (LayoutTestController::setPrivateBrowsingEnabled):
 122
 123 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
 124
 125         Reviewed by Adam.
 126
 127         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
 128         WebCore's!
 129
 130         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
 131         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
 132         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
 133         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
 134         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
 135         * Drosera/win/Drosera.cpp:
 136         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 137
 138 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
 139
 140         Reviewed by Sam.
 141
 142         - Use the new IWebFrame [local] function signature and get the shared
 143         server correctly.
 144
 145         * Drosera/win/DebuggerClient.cpp:
 146         (DebuggerClient::didFinishLoadForFrame):
 147         * Drosera/win/ServerConnection.cpp:
 148         (ServerConnection::attemptToCreateServerConnection):
 149
 150 2007-11-07  Dan Bernstein  <mitz@apple.com>
 151
 152         Reviewed by Darin Adler.
 153
 154         - add an option to run-webkit-tests to ignore pixel test failures where
 155           all pixels differ by no more than a specified threshold
 156
 157         * DumpRenderTree/mac/ImageDiff.m:
 158         (main):
 159         (compareImages):
 160         (computePercentageDifferent):
 161         * Scripts/run-webkit-tests:
 162
 163 2007-11-07  Simon Hausmann  <hausmann@kde.org>
 164
 165         Reviewed by Lars.
 166
 167         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
 168
 169         * DumpRenderTree/qt/DumpRenderTree.cpp:
 170
 171 2007-11-07  Simon Hausmann  <hausmann@kde.org>
 172
 173         Reviewed by Lars.
 174
 175         Reworked the QWebSettings API.
 176         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
 177
 178         * DumpRenderTree/qt/DumpRenderTree.cpp:
 179
 180 2007-11-07  Simon Hausmann  <hausmann@kde.org>
 181
 182         Reviewed by Lars.
 183
 184         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
 185
 186         * DumpRenderTree/qt/jsobjects.cpp:
 187
 188 2007-11-07  Simon Hausmann  <hausmann@kde.org>
 189
 190         Reviewed by Lars Knoll <lars@trolltech.com>.
 191
 192         Add a QWebPage::frameCreated() signal and fix DRT
 193
 194         The removal of createFrame in QWebPage broke the re-implementation
 195         in DumpRenderTree. Instead emit a frameCreated() signal and
 196         connect to it in DumpRenderTree.
 197
 198
 199         * DumpRenderTree/qt/DumpRenderTree.cpp:
 200         (WebCore::WebPage::WebPage):
 201         (WebCore::DumpRenderTree::dump):
 202         (WebCore::DumpRenderTree::connectFrame):
 203         * DumpRenderTree/qt/DumpRenderTree.h:
 204
 205 2007-11-07  Simon Hausmann  <hausmann@kde.org>
 206
 207         Reviewed by Lars Knoll <lars@trolltech.com>.
 208
 209         Moved all the event handlers from QWebFrame into QWebPage.
 210
 211         This cleans up the public API and allows us to remove the
 212         HackWebFrame hack in DumpRenderTree.
 213
 214
 215         * DumpRenderTree/qt/jsobjects.cpp:
 216         (EventSender::mouseDown):
 217         (EventSender::mouseUp):
 218         (EventSender::mouseMoveTo):
 219
 220 2007-11-07  Simon Hausmann  <hausmann@kde.org>
 221
 222         Reviewed by Mark.
 223
 224         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
 225         to prevent the default implementation from popping up messageboxes.
 226
 227         * DumpRenderTree/qt/DumpRenderTree.cpp:
 228         (WebCore::WebPage::javaScriptConfirm):
 229         (WebCore::WebPage::javaScriptPrompt):
 230
 231 2007-11-06  Eric Seidel  <eric@webkit.org>
 232
 233         * Scripts/build-testkjs: build fix... too many $$
 234
 235 2007-11-06  Eric Seidel  <eric@webkit.org>
 236
 237         Reviewed by Mark Rowe.
 238
 239         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
 240
 241 2007-11-05  Adam Roben  <aroben@apple.com>
 242
 243         Add support on Windows for WEBKIT_TESTFONTS
 244
 245         This environment variable lets you specify where the fonts to be used
 246         by DumpRenderTree reside. The Qt port is already using this, so I'm
 247         just following their lead.
 248
 249         Reviewed by Darin.
 250
 251         * DumpRenderTree/win/DumpRenderTree.cpp:
 252         (exePath): Refactored code out of initialize().
 253         (fontsPath): Returns either $WEBKIT_TESTFONTS or
 254         DumpRenderTree.resources.
 255         (initialize): Use the new fontsPath function.
 256         (main): Use the new exePath function.
 257         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
 258         variable to DRT, like Qt does.
 259
 260 2007-11-05  Mark Rowe  <mrowe@apple.com>
 261
 262         Rubber-stamped by Alp Toker.
 263
 264         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
 265
 266         * GtkLauncher/main.cpp:
 267         (goToURLBarText):
 268         (main):
 269
 270 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
 271
 272         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
 273         <http://bugs.webkit.org/show_bug.cgi?id=15830>
 274
 275         Reviewed by Timothy.
 276
 277         Restrict the range of nightly builds used by the bisect-builds script
 278         based on the version of Safari and the version of Mac OS X being used.
 279
 280         Mac OS X 10.4: Safari 2.0: r11976 or newer
 281         Mac OS X 10.4: Safari 3.0: r19992 or newer
 282
 283         Mac OS X 10.5: Safari 2.0: r19594 or newer
 284         Mac OS X 10.5: Safari 3.0: r25124 or newer
 285
 286         * Scripts/bisect-builds:
 287         (findMacOSXVersion): Added.
 288         (makeNightlyList): Added argument to provide version of Mac OS X.
 289         Restrict range of nightly builds based on Safari and Mac OS X versions.
 290
 291 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
 292
 293         Reviewed by Maciej.
 294
 295         - This patch involves several changes, all of them were noticed that
 296         they were needed by the work being done in WebKit to get Drosera and
 297         WebKit working together on Windows.
 298         - The changes are:
 299         1) Added a debugger console for output messages.
 300         2) Drosera now listens for the WebKit server (before, the server would
 301         have to be running before Drosera was started.)
 302         3) Fixed a bug where the WebView started out as 0x0 pixels.
 303         4) Fixed a bug when there is no scope.
 304         5) Added the HTML, JS, and CSS to the project file to make them easy to
 305         find.
 306         6) Made the ServerConnection functions virtual.
 307
 308         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
 309         for the WebKit server.
 310         (DebuggerClient::DebuggerClient):
 311         (DebuggerClient::~DebuggerClient):
 312         (DebuggerClient::didFinishLoadForFrame):
 313         (DebuggerClient::serverConnected):
 314         (DebuggerClient::attemptToCreateServerConnection):
 315         * Drosera/win/DebuggerClient.h: Ditto.
 316         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
 317         scope.
 318         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 319         (DebuggerDocument::platformValueForScopeVariableNamed):
 320         * Drosera/win/Drosera.cpp:
 321         (_tWinMain): Added a console in debug for output messages.
 322         (Drosera::Drosera): Listen for server.
 323         (Drosera::initUI): The server now Initializes COM.
 324         (Drosera::serverConnected): Part of the listening for the server.
 325         (Drosera::attemptToCreateServerConnection): Ditto.
 326         * Drosera/win/Drosera.h: New interface for listening for the server.
 327         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
 328         files to the VS project.
 329         * Drosera/win/ServerConnection.cpp: Part of listening for the server
 330         connection.
 331         (ServerConnection::ServerConnection):
 332         (ServerConnection::attemptToCreateServerConnection):
 333         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
 334         methods.
 335         (ServerConnection::serverConnected):
 336
 337 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
 338
 339         Reviewed by Maciej.
 340
 341         http://bugs.webkit.org/show_bug.cgi?id=15832
 342         fast/dom/gc-10.html crashes when run alone
 343
 344         Check for !done before using objects that can be already deallocated.
 345
 346         * DumpRenderTree/mac/EditingDelegate.mm:
 347         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
 348         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
 349         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
 350         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
 351         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
 352         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
 353         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
 354         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
 355         (-[EditingDelegate webViewDidBeginEditing:]):
 356         (-[EditingDelegate webViewDidChange:]):
 357         (-[EditingDelegate webViewDidEndEditing:]):
 358         (-[EditingDelegate webViewDidChangeTypingStyle:]):
 359         (-[EditingDelegate webViewDidChangeSelection:]):
 360         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 361         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
 362         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
 363         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
 364         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
 365         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
 366         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
 367         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
 368         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
 369         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
 370         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
 371         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
 372         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
 373         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
 374         (-[FrameLoadDelegate webView:willCloseFrame:]):
 375         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
 376         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
 377         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
 378         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
 379         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
 380         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
 381         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
 382         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
 383         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
 384
 385 2007-11-04  Mark Rowe  <mrowe@apple.com>
 386
 387         Build fix.  Don't use Carbon.h as the prefix header as it triggers
 388         warnings that would otherwise be suppressed due to it being a system header.
 389
 390         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 391
 392 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
 393
 394         Rubber stamped by Adam.
 395
 396         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
 397
 398         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 399
 400 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
 401
 402         Sort files(...); sections of Xcode project files.
 403
 404         Rubber-stamped by Darin.
 405
 406         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
 407         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
 408         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 409         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
 410
 411 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
 412
 413         Script to sort "files(...);" sections in Xcode project.pbxproj files.
 414
 415         Reviewed by Darin.
 416
 417         * Scripts/sort-Xcode-project-file: Added.
 418
 419 2007-11-02  Darin Adler  <darin@apple.com>
 420
 421         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
 422
 423 2007-11-02  Darin Adler  <darin@apple.com>
 424
 425         Reviewed by Maciej.
 426
 427         * Scripts/run-sunspider: Pass the "--base" option through.
 428
 429         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
 430         the real script do that. Default configuration to Release to match run-sunspider
 431         so we don't end up building Debug just to compare results.
 432
 433 2007-11-01  Adam Roben  <aroben@apple.com>
 434
 435         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
 436
 437         Reviewed by Sam.
 438
 439         * Scripts/commit-log-editor: Show all the directories beneath the
 440         source root, instead of just the last one.
 441
 442 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
 443
 444         Reviewed by Adam Roben.
 445
 446         Print out an error message when the Windows build fails
 447         and provide guidance on how to find out what went wrong.
 448
 449         * Scripts/build-webkit:
 450         * Scripts/webkitdirs.pm:
 451
 452 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
 453
 454         Rubber-stamped by Adam Roben.
 455
 456         Rolled out r27326 - debug CRT seems to cause no problems after all.
 457
 458         * DumpRenderTree/win/DumpRenderTree.vcproj:
 459
 460 2007-10-31  Adam Roben  <aroben@apple.com>
 461
 462         Switch the Debug configuration to using the non-debug CRT
 463
 464         This matches WebKit.
 465
 466         Reviewed by Steve.
 467
 468         * DumpRenderTree/win/DumpRenderTree.vcproj:
 469
 470 2007-10-31  Antti Koivisto  <antti@apple.com>
 471
 472         Reviewed by bdash.
 473
 474         Disable media tests when doing leak checking on Tiger.
 475         They crash in QuickTime (rdar://problem/5537157).
 476
 477         * Scripts/run-webkit-tests:
 478
 479 2007-10-29  Antti Koivisto  <antti@apple.com>
 480
 481         Reviewed by Maciej.
 482
 483         Build media support by default on OSX only.
 484
 485         * Scripts/build-webkit:
 486
 487 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
 488
 489         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
 490         get caught by the pre-commit hooks.
 491
 492 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
 493
 494         Reviewed by Adam.
 495
 496         - This is a collection of relatively unrelated changes and cleanups
 497         to Drosera to prepare it for interacting with WebKit.  A lot of these
 498         changes are just correcting mistakes, for example removing included
 499         headers that are no longer needed.
 500
 501         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
 502         this will be needed by the DebuggerClient.
 503         (DebuggerDocument::server):
 504         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
 505         * Drosera/win/DebuggerClient.cpp:
 506         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
 507         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
 508         (DebuggerClient::createWebViewWithRequest): Added comment about its
 509         purpose.
 510         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
 511         declarations.
 512         (DebuggerClient::webViewLoaded): Moved.
 513         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
 514         file, since this was the only place it was used.
 515         (cfStringToBSTR):
 516         * Drosera/win/Drosera.h: Cleaned up the includes.
 517         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
 518         * Drosera/win/HelperFunctions.h: Removed.
 519
 520 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
 521
 522         Reviewed by Adam.
 523
 524         - Small cleanup in the ServerConnection class.
 525
 526         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
 527         and added an include.
 528         (ServerConnection::currentFrame):
 529         (ServerConnection::getCallerFrame):
 530         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
 531         made a pointer into a COMPtr, and cleaned up the includes.
 532
 533 2007-10-29  Timothy Hatcher  <timothy@apple.com>
 534
 535         Reviewed by John Sullivan.
 536
 537         - Place the Localizable.strings file in mac or win directories
 538           if that location exists.
 539         - Also look for UI_STRING in .c files.
 540
 541         * Scripts/extract-localizable-strings:
 542
 543 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
 544
 545         Reviewed by Adam.
 546
 547         - Set the eol-style to native and made all the line endings the same
 548         so that I avoid messy diffs that show eol changes.
 549
 550         * Drosera/win/ServerConnection.cpp:
 551         (ServerConnection::didParseSource):
 552         (ServerConnection::didEnterCallFrame):
 553         (ServerConnection::willExecuteStatement):
 554         (ServerConnection::willLeaveCallFrame):
 555         (ServerConnection::exceptionWasRaised):
 556
 557 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
 558
 559         Reviewed by Adam.
 560
 561         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
 562         functionality that could not have existed previously without the new
 563         interfaces.
 564         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
 565         from a BSTR to a JSValueRef.
 566         (DebuggerDocument::platformEvaluateScript): Implemented.
 567         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
 568         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 569         Implemented.
 570         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
 571         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
 572         * Drosera/win/ServerConnection.cpp: Added a helper function.
 573         (ServerConnection::getCallerFrame):
 574         * Drosera/win/ServerConnection.h: Added a helper function.
 575
 576 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
 577
 578         updated reviewers for my previous changelog.
 579
 580 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
 581         Reviewed by Maciej and Adam and Geoff.
 582
 583         - Minor mac-side improvements including moving a function to a more
 584         appropriate location, fixing a warning, and correctly checking
 585         exceptions.
 586
 587         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
 588         (DebuggerDocument::willExecuteStatement):
 589         (DebuggerDocument::didEnterCallFrame):
 590         (DebuggerDocument::willLeaveCallFrame):
 591         (DebuggerDocument::windowScriptObjectAvailable):
 592         (DebuggerDocument::callFunctionOnObject):
 593         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
 594         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
 595         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
 596         because it doesn't require the ServerConnection at all.
 597         (NSStringCreateWithJSStringRef): Made an argument const.
 598         (JSValueRefCreateWithNSString): Made an argument const.
 599         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
 600         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 601         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
 602         * Drosera/mac/ServerConnection.mm: Ditto.
 603         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
 604
 605 2007-10-29  Sam Weinig  <sam@webkit.org>
 606
 607         Reviewed by Adam Roben.
 608
 609         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
 610
 611         * DumpRenderTree/LayoutTestController.cpp:
 612         (LayoutTestController::LayoutTestController):
 613         (getGlobalFlagCallback):
 614         (setGlobalFlagCallback):
 615         (LayoutTestController::getJSClass):
 616         (LayoutTestController::staticValues):
 617         * DumpRenderTree/LayoutTestController.h:
 618         (LayoutTestController::globalFlag):
 619         (LayoutTestController::setGlobalFlag):
 620
 621 2007-10-29  Darin Adler  <darin@apple.com>
 622
 623         Reviewed by Maciej.
 624
 625         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
 626         resolution instead of its default.
 627
 628 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
 629
 630         Fixed showStatus() to print status for successfully resolved conflicts when using git.
 631
 632         Reviewed by Mark Rowe.
 633
 634         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
 635         was successfully resolved, but this would not show any status because the change had
 636         already been cached in the index using "git add".  The solution is to add an optional
 637         second argument to showStatus() which adds the "--cached" switch to the command.
 638
 639         * Scripts/resolve-ChangeLogs:
 640         (showStatus):
 641
 642 2007-10-28  Eric Seidel  <eric@webkit.org>
 643
 644         Reviewed by Maciej and Geoff, in unison.
 645
 646         * Scripts/run-webkit-tests: remove broken --svg option
 647
 648 2007-10-28  Darin Adler  <darin@apple.com>
 649
 650         Reviewed by Adam.
 651
 652         * Scripts/run-sunspider: Default to "Release" configuration rather than
 653         defaulting to the last configuration used as other scripts do. This can
 654         still be overriden on the command line with "--debug" if there's some
 655         reason to do so. Also fix a typo.
 656
 657         * Scripts/sunspider-compare-results: Fix a typo.
 658
 659 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
 660
 661         Reviewed by Adam.
 662
 663         - Implemented the WebScriptDebugListener functions now that the
 664         WebScriptDebugServer exists
 665
 666         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
 667         functions.
 668         (ServerConnection::currentFrame):
 669         (ServerConnection::didLoadMainResourceForDataSource):
 670         (ServerConnection::didParseSource):
 671         (ServerConnection::failedToParseSource):
 672         (ServerConnection::didEnterCallFrame):
 673         (ServerConnection::willExecuteStatement):
 674         (ServerConnection::willLeaveCallFrame):
 675         (ServerConnection::exceptionWasRaised):
 676         * Drosera/win/ServerConnection.h: Removed unused arguments from the
 677         members arguments list.
 678
 679 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
 680
 681         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
 682         <http://bugs.webkit.org/show_bug.cgi?id=15600>
 683
 684         Reviewed by Darin.
 685
 686         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
 687         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
 688         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
 689         file.  Note that it may also be used as a stand-alone script.
 690
 691         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
 692         * Scripts/resolve-ChangeLogs: Added.
 693         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
 694
 695 2007-10-26  Mark Rowe  <mrowe@apple.com>
 696
 697         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
 698         to the Qt port on the assumption that it was an implementation of the cross-platform
 699         LayoutTestController class.  It is not, so it did not need to be changed.
 700
 701         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
 702
 703 2007-10-25  Mark Rowe  <mrowe@apple.com>
 704
 705         Reviewed by Maciej.
 706
 707         Fix builds with code coverage enabled.
 708
 709         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
 710
 711 2007-10-25  Darin Adler  <darin@apple.com>
 712
 713         Reviewed by Mark Rowe.
 714
 715         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
 716         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
 717
 718 2007-10-25  Stephanie  <slewis@apple.com>
 719
 720         build Fix
 721
 722         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 723
 724 2007-10-25  Stephanie  <slewis@apple.com>
 725
 726         Reviewed by Mark Rowe, Adam Roben.
 727
 728         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
 729
 730         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 731
 732 2007-10-25  Alice Liu  <alice.liu@apple.com>
 733
 734         Reviewed by Adam.
 735
 736         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
 737
 738         Moving destructor into platform-specific files
 739         * DumpRenderTree/LayoutTestController.cpp:
 740         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 741         (LayoutTestController::~LayoutTestController):
 742         * DumpRenderTree/qt/jsobjects.cpp:
 743         (LayoutTestController::~LayoutTestController):
 744
 745         LayoutTestController wasn't being destroyed
 746         * DumpRenderTree/win/DumpRenderTree.cpp:
 747         (runTest):
 748
 749         Added declspec
 750         * DumpRenderTree/win/EditingDelegate.h:
 751
 752         Reset certain values on the webview (or related delegate) that might
 753         have changed while running a test
 754         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 755         (LayoutTestController::~LayoutTestController):
 756
 757 2007-10-25  Adam Roben  <aroben@apple.com>
 758
 759         Make sunspider-compare-results work with relative paths
 760
 761         Reviewed by Sam.
 762
 763         * Scripts/sunspider-compare-results: Convert arguments to absolute
 764         paths before we chdir.
 765
 766 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
 767
 768         Reviewed by Sam.
 769
 770         - Implemented server calls now the WebScriptDebugServer exists.
 771         - Also removed no longer needed call to initialize CG.
 772
 773         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
 774         automatically now.
 775         (_tWinMain):
 776         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
 777         (ServerConnection::ServerConnection):
 778         (ServerConnection::~ServerConnection):
 779         (ServerConnection::pause):
 780         (ServerConnection::resume):
 781         (ServerConnection::stepInto):
 782         (ServerConnection::applicationTerminating):
 783         (ServerConnection::serverConnectionDidDie):
 784         * Drosera/win/ServerConnection.h: Now uses the COM class.
 785
 786 2007-10-24  George Staikos  <staikos@kde.org>
 787
 788         Unbreak Qt build.
 789
 790         * Scripts/build-webkit:
 791
 792 2007-10-24  Adam Roben  <aroben@apple.com>
 793
 794         Remove now-unnecessary call to InitializeCoreGraphics
 795
 796         WebKit takes care of this now.
 797
 798         Reviewed by Ada.
 799
 800         * DumpRenderTree/win/DumpRenderTree.cpp:
 801         (initialize):
 802
 803 2007-10-24  Adam Roben  <aroben@apple.com>
 804
 805         Use WebTextRenderer in DRT
 806
 807         Reviewed by Ada.
 808
 809         * DumpRenderTree/win/DumpRenderTree.cpp:
 810         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
 811
 812 2007-10-24  Sven Herzberg  <sven@imendio.com>
 813
 814         Reviewed by Mark Rowe.
 815
 816         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
 817         Bug 15614: [GTK] qmake based backends don't build on OS X
 818
 819         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
 820         GTK backend on a Mac
 821         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
 822         isDarwin() to make it reusable in other places (like the workaround-
 823         for-prebuilt-qmake in build-webkit)
 824
 825 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
 826
 827         Refurbish update-webkit script.
 828
 829         Reviewed by Adam.
 830
 831         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
 832         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
 833         multi-argument version of system() for flexibility and security.  Check for existence
 834         of Internal directory using -d test instead of -x.
 835
 836 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
 837
 838         Minor clean-up of prepare-ChangeLog script.
 839
 840         Reviewed by Adam.
 841
 842         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
 843         of a string.  Use multi-argument versions of open() and system() for flexibility and
 844         security.
 845
 846 2007-10-24  Alice Liu  <alice.liu@apple.com>
 847
 848         Reviewed by Oliver.
 849
 850         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
 851
 852         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
 853         replay the saved events when we're still processing the mousedown that starts the drag
 854         * DumpRenderTree/win/EventSender.cpp:
 855         (doMouseMove):
 856         * DumpRenderTree/win/UIDelegate.cpp:
 857         (UIDelegate::doDragDrop):
 858
 859 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
 860
 861         Reviewed by Sam, Steve and Darin.
 862
 863         - Stubbed out the WebScriptDebugListener functionality in the Server
 864         Connection class to prepare it for receiving those callbacks.
 865         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
 866         and the ServerConnection to not need to be initialized with a server
 867         name, since that is not the way we connect to the WebKit server.
 868
 869         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
 870         no exception.  Now it only loggs when there is an exception
 871         (DebuggerDocument::willExecuteStatement):
 872         (DebuggerDocument::didEnterCallFrame):
 873         (DebuggerDocument::willLeaveCallFrame):
 874         (DebuggerDocument::windowScriptObjectAvailable):
 875         (DebuggerDocument::callFunctionOnObject):
 876         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
 877         to be instantiated with a server's name.
 878         (DebuggerClient::DebuggerClient):
 879         (DebuggerClient::didFinishLoadForFrame):
 880         * Drosera/win/DebuggerClient.h: Removed unsued variable.
 881         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
 882         a server name.
 883         (Drosera::init):
 884         (Drosera::initServer):
 885         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
 886         instantiated with a server's name.
 887         * Drosera/win/ServerConnection.cpp:
 888         (ServerConnection::ServerConnection): No longer needs a server name
 889         (ServerConnection::~ServerConnection): Only release the global context
 890         if there is one.
 891         (ServerConnection::serverConnectionDidDie): Stub for
 892         IWebScriptDebugListener
 893         (ServerConnection::QueryInterface): ditto
 894         (ServerConnection::AddRef): ditto
 895         (ServerConnection::Release): ditto
 896         (ServerConnection::didLoadMainResourceForDataSource): ditto
 897         (ServerConnection::didParseSource): ditto
 898         (ServerConnection::failedToParseSource): ditto
 899         (ServerConnection::didEnterCallFrame): ditto
 900         (ServerConnection::willExecuteStatement): ditto
 901         (ServerConnection::willLeaveCallFrame): ditto
 902         (ServerConnection::exceptionWasRaised): ditto
 903         * Drosera/win/ServerConnection.h: Stubbed out the
 904         IWebScriptDebugListener functions, and this class no longer needs to be
 905         instantiated with a server name.
 906
 907 2007-10-24  Lars Knoll  <lars@trolltech.com>
 908
 909         Reviewed by Simon.
 910
 911         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
 912
 913         * DumpRenderTree/qt/jsobjects.h:
 914
 915 2007-10-24  Lars Knoll  <lars@trolltech.com>
 916
 917         Reviewed by Simon.
 918
 919         add another command.
 920
 921         * DumpRenderTree/qt/jsobjects.cpp:
 922         (TextInputController::doCommand):
 923
 924 2007-10-24  Lars Knoll  <lars@trolltech.com>
 925
 926         Reviewed by Simon.
 927
 928         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
 929
 930         * DumpRenderTree/qt/jsobjects.cpp:
 931         (EventSender::keyDown):
 932         * DumpRenderTree/qt/jsobjects.h:
 933
 934 2007-10-24  Lars Knoll  <lars@trolltech.com>
 935
 936         Reviewed by Simon.
 937
 938         implement eventSender.keyDown().
 939
 940         * DumpRenderTree/qt/jsobjects.cpp:
 941         (EventSender::keyDown):
 942
 943 2007-10-24  Lars Knoll  <lars@trolltech.com>
 944
 945         Reviewed by Simon.
 946
 947         some smaller fixes to the editing support in DRT. Makes another few tests pass.
 948
 949         * DumpRenderTree/qt/DumpRenderTree.cpp:
 950         (WebCore::DumpRenderTree::DumpRenderTree):
 951         (WebCore::DumpRenderTree::initJSObjects):
 952         * DumpRenderTree/qt/jsobjects.cpp:
 953         (TextInputController::doCommand):
 954
 955 2007-10-24  Lars Knoll  <lars@trolltech.com>
 956
 957         Reviewed by Simon.
 958
 959         first bit of implementation for the textinputcontroller.
 960
 961         * DumpRenderTree/qt/DumpRenderTree.cpp:
 962         (WebCore::DumpRenderTree::DumpRenderTree):
 963         * DumpRenderTree/qt/DumpRenderTree.h:
 964         * DumpRenderTree/qt/jsobjects.cpp:
 965         (TextInputController::TextInputController):
 966         (TextInputController::doCommand):
 967         * DumpRenderTree/qt/jsobjects.h:
 968
 969 2007-10-24  Lars Knoll  <lars@trolltech.com>
 970
 971         Reviewed by Simon.
 972
 973         make the man webpage believe it has focus, so the editing tests work correctly.
 974
 975         * DumpRenderTree/qt/DumpRenderTree.cpp:
 976         (WebCore::DumpRenderTree::DumpRenderTree):
 977
 978 2007-10-24  Lars Knoll  <lars@trolltech.com>
 979
 980         Reviewed by Simon.
 981
 982         implement layoutTestController.dumpEditingCallbacks() correctly.
 983
 984         * DumpRenderTree/qt/DumpRenderTree.cpp:
 985         (WebCore::DumpRenderTree::DumpRenderTree):
 986         * DumpRenderTree/qt/jsobjects.cpp:
 987         (LayoutTestController::reset):
 988         (LayoutTestController::dumpEditingCallbacks):
 989
 990 2007-10-24  Lars Knoll  <lars@trolltech.com>
 991
 992         Reviewed by Simon.
 993
 994         Implement support for testing editing.
 995
 996         * DumpRenderTree/qt/DumpRenderTree.cpp:
 997         (WebCore::DumpRenderTree::DumpRenderTree):
 998
 999 2007-10-23  Sam Weinig  <sam@webkit.org>
1000
1001         Check for null BSTR that can be passed to the UIDelegate methods
1002         from javascript null and undefined.  Fixes a failing test case on
1003         Windows (fast/dom/Window/alert-undefined.html)
1004
1005         Reviewed by Eric Seidel.
1006
1007         * DumpRenderTree/win/UIDelegate.cpp:
1008         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1009         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1010         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1011         (UIDelegate::webViewAddMessageToConsole):
1012
1013 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1014
1015         Reviewed by Darin.
1016
1017         Don't print a massive pile of setenvs from tools that automatically build testkjs.
1018
1019         * Scripts/build-testkjs:
1020
1021 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1022
1023         Reviewed by Darin.
1024
1025         - add wrapper that finds the right copy of testkjs
1026
1027         * Scripts/sunspider-compare-results: Added.
1028
1029 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
1030
1031         Reviewed by Sam.
1032
1033         - After talking with Steve I now see that the WebKit server must be
1034         running for DCOM to create the distributed objects, which makes sense
1035         and currently WebKit only allows one instance to be running at a time
1036         which avoids accidentally connecting to the wrong server
1037         - In light of this I have removed the code for the attach box and
1038         NotificationServer and known server names, since they are all extranious
1039         now.
1040
1041         * Drosera/win/Drosera.cpp: Removed notification classes and known server
1042         names.
1043         (_tWinMain): Uses init instead of initUI.
1044         (droseraWndProc): No longer creats an attach dialog box.
1045         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
1046         it's not manditory to call init before doing COM stuff.
1047         (Drosera::init): calls initUI and will call attach when the
1048         functionality exists.
1049         (Drosera::initUI): Has changed very little.
1050         (Drosera::attach): Changed the signature to reflect that we no longer
1051         need the dictionary of known server names.
1052         * Drosera/win/Drosera.h: Removed notification classes and known server
1053         names.  Also renamed and moved some functions.
1054         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
1055         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
1056         headers to the resources folder.
1057         * Drosera/win/resource.h: Removed the Attach box.
1058
1059 2007-10-22  Adam Roben  <aroben@apple.com>
1060
1061         Windows build fix
1062
1063         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
1064
1065 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
1066
1067         - Removed a leak that was fixed.
1068
1069         * Scripts/run-webkit-tests:
1070
1071 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1072
1073         Reviewed by Darin.
1074
1075         - Changed the Client so that the DebuggerDocument now own the
1076         ServerConnection.  This simplifies ownership and cleanup.
1077
1078         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
1079         ServerConnection.
1080         (DebuggerClient::initWithServerName):
1081         (DebuggerClient::didFinishLoadForFrame):
1082         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the
1083         ServerConnection.
1084         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
1085         until after we have a server which we are attached to.
1086         (Drosera::initUI):
1087         (Drosera::attach):
1088         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
1089         out previously.
1090
1091 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1092
1093         Reviewed by Nikolas.
1094
1095         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
1096
1097         * Scripts/run-javascriptcore-tests:
1098
1099 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1100
1101         Reviewed by Nikolas.
1102
1103         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
1104
1105         * Scripts/build-drosera:
1106         * Scripts/build-dumprendertree:
1107         * Scripts/build-testkjs:
1108         * Scripts/build-webkit:
1109         * Scripts/run-javascriptcore-tests:
1110         * Scripts/run-sunspider:
1111         * Scripts/run-webkit-tests:
1112         * Scripts/webkitdirs.pm:
1113
1114 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
1115
1116         Reviewed by Mark Rowe.
1117
1118         Fix for local database support after r26879
1119         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
1120
1121         * Scripts/build-webkit:
1122
1123 2007-10-22  Holger Freyther  <zecke@selfish.org>
1124
1125         Reviewed by Simon Hausmann <hausmann@kde.org>.
1126
1127         - Do not build testkjs as an application bundle. This is
1128         needed for run-javascriptcore-tests on OSX.
1129         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
1130         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
1131         as we do not have -rpath on OSX.
1132
1133         * DumpRenderTree/qt/DumpRenderTree.pro:
1134         * Scripts/run-webkit-tests:
1135
1136 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1137
1138         Reviewed by aroben.
1139
1140         Fix support for Signed-off-by detection in prepare-ChangeLog
1141         --git-commit. The Signed-off-by tag does not appear in the header
1142         but usually at the end.
1143
1144         * Scripts/prepare-ChangeLog:
1145
1146 2007-10-21  Mark Rowe  <mrowe@apple.com>
1147
1148         Reviewed by Eric.
1149
1150         Fix run-javascriptcore-tests for Gtk.
1151
1152         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
1153
1154 2007-10-20  Eric Seidel  <eric@webkit.org>
1155
1156         Reviewed by aroben.
1157
1158         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
1159
1160 2007-10-20  Eric Seidel  <eric@webkit.org>
1161
1162         Reviewed by darin.
1163
1164         Add improved argument handling to run-sunspider, including
1165         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
1166         Also re-factor code into subroutines
1167
1168         * Scripts/build-dumprendertree: removed bogus comments
1169         * Scripts/build-testkjs: Added.
1170         * Scripts/run-javascriptcore-tests: use build-testkjs
1171         * Scripts/run-sunspider: improved argument handling, abstraction
1172         * Scripts/run-webkit-tests: improved abstraction
1173
1174 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
1175
1176         Not reviewed, Windows build fix.
1177
1178         * DumpRenderTree/win/EventSender.cpp:
1179         (keyDownCallback):
1180
1181 2007-10-20  Darin Adler  <darin@apple.com>
1182
1183         Reviewed by Tim Hatcher.
1184
1185         - http://bugs.webkit.org/show_bug.cgi?id=15544
1186           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
1187           not rely on Apple-specific key codes
1188
1189         * DumpRenderTree/mac/EventSendingController.mm:
1190         (-[EventSendingController keyDown:withModifiers:]):
1191         Added named key "rightArrow". Later we could have a whole table of these.
1192         Also tweaked modifiers code a little.
1193
1194         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
1195
1196 2007-10-19  Darin Adler  <darin@apple.com>
1197
1198         Reviewed by Eric.
1199
1200         - http://bugs.webkit.org/show_bug.cgi?id=15566
1201           possible fix for leak seen in DumpRenderTree
1202
1203         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
1204         Delete the item if it's not put on the queue, since the caller has
1205         no way of knowing that. Would be better to have the parameter type
1206         be auto_ptr to express the fact that we take ownership.
1207
1208         - unrelated change
1209
1210         * Drosera/mac/main.m: Add missing include.
1211
1212 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1213
1214         Reviewed by Adam.
1215
1216         - This change should be identical but for some reason was not working
1217         on my machine.
1218
1219         * Scripts/prepare-ChangeLog:
1220
1221 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1222
1223         Reviewed by Oliver and Tim.
1224
1225         - Made use of RetainPtr to avoid retain and release issues and moved the
1226         log function to DebuggerDocumentPlatform, which seems to be a more
1227         logical place for it to live.
1228         - Also moved knownServers from the ServerConnection to
1229         DebuggerApplication to match the Windows code and because it makes sense
1230         that a connection knows its own server but not all of them.
1231
1232         * Drosera/mac/DebuggerClient.h: Moved the log function to
1233           DebuggerDocumentPlatform.
1234         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
1235           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
1236           call for the server name up from the ServerConnection class.
1237         (-[DebuggerClient dealloc]):
1238         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
1239           for the server name up from the ServerConnection.
1240         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
1241         (DebuggerDocument::platformPause):
1242         (DebuggerDocument::platformResume):
1243         (DebuggerDocument::platformStepInto):
1244         (DebuggerDocument::platformEvaluateScript):
1245         (DebuggerDocument::getPlatformCurrentFunctionStack):
1246         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1247         (DebuggerDocument::platformValueForScopeVariableNamed):
1248         (DebuggerDocument::platformLog): Log directly from here. No need to call
1249           DebuggerClient.
1250         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
1251           way I see it, a ServerConnection should only know about its connection
1252           and the group of all possible servers should be kept by the
1253           application.
1254         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
1255           currentServerName, it makes sense that the connection should know that
1256           name.
1257         (-[ServerConnection currentServerName]):
1258
1259 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1260
1261         Reviewed by Adam.
1262
1263         - Integrated changes from mac drosera.  Recently I've encapsulated
1264         out the server connection object from the rest of Drosera because
1265         it is very platform dependent right now and RPC is not implemented on
1266         windows.  This functionality, of communicating with the WebKit server
1267         is the next area I will be focusing on in Windows.
1268
1269         - Other changes and cleanup were made to organize the code and add notes
1270         on which parts still need work.  Also some mac code is added and
1271         commented out, to act as pseudocode for the logic of those parts.
1272
1273         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
1274           pointer.
1275         * Drosera/config.h: Added whitespace.
1276         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
1277           these files got moved into Drosera.h/cpp
1278         * Drosera/win/DebuggerApplication.h: Removed.
1279         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring
1280           happened here to better match the logic flow of the same code on the
1281           mac side and to use the new ServerConnection class.
1282         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
1283         (DebuggerClient::initWithServerName): Initializer that will set up the
1284           class to use a ServerConnection object.  This was necessary so I could
1285           create a DebuggerClient without having to initilaize it at
1286           construction.
1287         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
1288           will be the UIDelegate and FrameLoadDelegate.
1289         (DebuggerClient::AddRef): For IUnknown.
1290         (DebuggerClient::Release): For IUnknown.
1291         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
1292           this still needs to set the global context of the server, but
1293           IWebFrame does not have an accessor for the global context yet.
1294         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
1295           this is a pass through for the same function in the document.
1296         (DebuggerClient::didReceiveTitle): Unimplemented part of
1297           FrameLoadDelegate this would change the title of the window.
1298         (DebuggerClient::createWebViewWithRequest): Part of the
1299           FrameLoadDelegate.  This is about new windows via Window.open() and
1300           how their delegates are set.
1301         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
1302           UIDelegate.  Just a debug function for printing messages.
1303         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
1304           because the Client should be the UIDelegate and FrameLoadDelegate
1305           to match the delegates on mac.
1306         (DebuggerClient::webViewLoaded): Added accessor method.
1307         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
1308           forgotten to add this file before.  This is where the platform
1309           dependent versions of the Documents functions live. Most of these are
1310           unimplemented because some piece of functionality does not exist on
1311           Windows yet.
1312         (DebuggerDocument::platformPause):
1313         (DebuggerDocument::platformResume):
1314         (DebuggerDocument::platformStepInto):
1315         (DebuggerDocument::platformEvaluateScript):
1316         (DebuggerDocument::getPlatformCurrentFunctionStack):
1317         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1318         (DebuggerDocument::platformValueForScopeVariableNamed):
1319         (DebuggerDocument::platformLog):
1320         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
1321           responsibilities becaue they belong in the Client. Also I laid the
1322           groundwork for attaching Drosera to a WebKit process
1323         (attachWndProc): Now if a server is selected the Client becomes it's
1324           delegate.
1325         (Drosera::Drosera): Added the construction of the Client and dictionary
1326           of server names.
1327         (Drosera::initUI): This is no longer the delegates, the Client is.
1328         (Drosera::webViewLoaded): Now asks the Client instead of holding local
1329           state.
1330         (Drosera::applicationDidFinishLaunching): Placeholder for needed
1331           notification registration when it's possible to implement.
1332         (Drosera::serverLoaded): Ditto
1333         (Drosera::serverUnloaded): Ditto
1334         (Drosera::attach): Attach Drosera to the WebKit server.
1335         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
1336         (Drosera::getInst):
1337         (Drosera::setInst):
1338         (Drosera::knownServers):
1339         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
1340           and added the ServerConnection.
1341         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
1342         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
1343           Most of the functions are completely unimlemented because they cannot
1344           connect with the WebKit server, because one does not exist on Windows
1345           yet.
1346         (ServerConnection::initWithServerName):
1347         (ServerConnection::~ServerConnection):
1348         (ServerConnection::setGlobalContext):
1349         (ServerConnection::pause):
1350         (ServerConnection::resume):
1351         (ServerConnection::stepInto):
1352         (ServerConnection::switchToServerNamed):
1353         (ServerConnection::applicationTerminating):
1354         (ServerConnection::serverConnectionDidDie):
1355         (ServerConnection::currentFrame):
1356         * Drosera/win/ServerConnection.h: Added. Ditto.
1357         (ServerConnection::ServerConnection):
1358
1359 2007-10-19  Alice Liu  <alice.liu@apple.com>
1360
1361         Reviewed by Darin.
1362
1363         Fix for these broken layout tests on Windows:
1364
1365         fast/forms/focus-selection-input.html
1366         fast/forms/focus-selection-textarea.html
1367         fast/forms/select-accesskey.html
1368
1369         * DumpRenderTree/win/EventSender.cpp:
1370         (keyDownCallback):
1371         correct the VK code for alt key.
1372
1373 2007-10-19  Eric Seidel  <eric@webkit.org>
1374
1375         Reviewed by Mark Rowe.
1376
1377         Make the GtkLauncher code slightly more readable.
1378
1379         * GtkLauncher/main.cpp:
1380         (setupMainMenu): Added.
1381         (setupMainWindowUI): Added.
1382         (main):
1383
1384 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
1385
1386         Rubber stamped by Adam.
1387
1388         - don't delay-load WebKit in DumpRenderTree.
1389
1390         * DumpRenderTree/win/DumpRenderTree.vcproj:
1391
1392 2007-10-18  Dan Bernstein  <mitz@apple.com>
1393
1394         Reviewed by Adam Roben.
1395
1396         - fix <rdar://problem/5313523>
1397         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
1398
1399         * DumpRenderTree/mac/DumpRenderTree.mm:
1400         (dump): Changed to use _responseMIMEType.
1401
1402 2007-10-17  Adam Roben  <aroben@apple.com>
1403
1404         Make it possible to have Windows-specific tests and results
1405
1406         When searching for tests to run and the Skipped file, we will only
1407         look in platform/win and the cross-platform directory. When looking
1408         for expected results, we will look in platform/win, then
1409         platform/mac-leopard, then platform/mac, then finally the
1410         cross-platform directory.
1411
1412         Reviewed by Sam.
1413
1414         * Scripts/run-webkit-tests:
1415         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
1416         searching in the cross-platform directory.
1417         (sub buildPlatformHierarchy): Removed some unneeded calls to
1418         dirname/basename.
1419
1420 2007-10-17  Adam Roben  <aroben@apple.com>
1421
1422         Add back the call to register WebKit that we had before WebKitInitializer existed
1423
1424         This is needed to ensure that the right WebKit is used when
1425         instantiating COM objects.
1426
1427         Reviewed by Oliver.
1428
1429         * DumpRenderTree/win/debug_internal.vsprops: Define
1430         DEBUG_WEBKIT_HAS_SUFFIX.
1431         * DumpRenderTree/win/DumpRenderTree.cpp:
1432         (initialize):
1433
1434 2007-10-17  Adam Roben  <aroben@apple.com>
1435
1436         Import File::Basename in webkitdirs since we use it
1437
1438         * Scripts/webkitdirs.pm:
1439
1440 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
1441
1442         - Updated the tiger leaks list to make the internal bots green.
1443
1444         * Scripts/run-webkit-tests:
1445
1446 2007-10-17  Adam Roben  <aroben@apple.com>
1447
1448         Build fix for VC++ Express
1449
1450         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
1451         and ole32.lib.
1452
1453 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1454
1455         Reviewed by Sam.
1456
1457         - Minor mac improvements based on observations I made while implementing the
1458         Windows code.
1459
1460         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
1461         then hand it to the Client who will retain it, it should just be the client who
1462         creates and owns the server.
1463         (-[DebuggerApplication attach:]):
1464         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
1465         * Drosera/mac/DebuggerClient.mm: Creates the server.
1466         (-[DebuggerClient initWithServerName:]):
1467         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
1468         can instead forward declare what it needs.
1469
1470 2007-10-16  Darin Adler  <darin@apple.com>
1471
1472         Reviewed by Geoff Garen.
1473
1474         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
1475         want to turn failing tests into platform-specific test results. Also did a
1476         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
1477         would take the type of results into account only some of the time.
1478
1479 2007-10-16  Adam Roben  <aroben@apple.com>
1480
1481         Add a new nightly launcher script for Windows
1482
1483         This new script is for versions of Safari that don't delay-load
1484         WebKit. I had to make FindSafari be able to print out the nightly
1485         launcher script on stdout because Windows shell scripts can't capture
1486         the output from a command into an environment variable.
1487
1488         Reviewed by Steve.
1489
1490         * FindSafari/FindSafari.cpp:
1491         (_tmain): Added /printSafariLauncher option.
1492         * Scripts/run-webkit-nightly.cmd: Added.
1493
1494 2007-10-16  Adam Roben  <aroben@apple.com>
1495
1496         Replace WebKitInitializer with FindSafari
1497
1498         We now rely on setting the PATH environment variable to tell Windows
1499         where to find WebKit and its dependencies (similar to
1500         DYLD_FRAMEWORK_PATH on Mac).
1501
1502         This change also make DumpRenderTree no longer delay-load WebKit.
1503
1504         Reviewed by Sam.
1505
1506         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
1507         FindSafari.
1508         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
1509         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
1510         WebKitInitializer, don't delay-load WebKit.
1511         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
1512         * Scripts/run-webkit-tests: Ditto.
1513         * Scripts/webkitdirs.pm:
1514         (sub setPathForRunningWebKitApp): Added.
1515         * WebKitInitializer/WebKitInitializer.cpp: Removed.
1516         * WebKitInitializer/WebKitInitializer.h: Removed.
1517         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
1518         * WebKitInitializer/debug.vsprops: Removed.
1519         * WebKitInitializer/debug_internal.vsprops: Removed.
1520         * WebKitInitializer/release.vsprops: Removed.
1521
1522 2007-10-16  Adam Roben  <aroben@apple.com>
1523
1524         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
1525
1526         http://bugs.webkit.org/show_bug.cgi?id=15532
1527
1528         FindSafari simply prints the location of an installed Safari.exe on
1529         stdout.
1530
1531         Reviewed by Darin.
1532
1533         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
1534         (getStringValue):
1535         (getWebViewCLSID):
1536         (getInstalledWebKitDirectory):
1537         (_tmain):
1538         * FindSafari/FindSafari.vcproj: Added.
1539         * Scripts/webkitdirs.pm:
1540         (sub installedSafariPath): Added. Calls FindSafari on Windows.
1541
1542 2007-10-16  Adam Roben  <aroben@apple.com>
1543
1544         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
1545
1546         Reviewed by Kevin McCullough.
1547
1548         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
1549         when referring to WebKit.dll.
1550         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
1551         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
1552         * DumpRenderTree/win/release.vsprops: Ditto.
1553         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
1554         never have a _debug suffix on WebKit.dll.
1555         * WebKitInitializer/WebKitInitializer.cpp:
1556         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
1557         specified.
1558         * WebKitInitializer/debug_internal.vsprops: Added
1559         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
1560
1561 2007-10-16  Darin Adler  <darin@apple.com>
1562
1563         Reviewed by Adele.
1564
1565         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
1566         Remove now-unneeded control/alt key hack; the tests have been updated.
1567
1568 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1569
1570         - Updated leaks list because our internal bot upgraded it's version of leopard and
1571         one of the leaks was fixed between that revision and the bot's previous version of
1572         leopard.
1573
1574         * Scripts/run-webkit-tests:
1575
1576 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
1577
1578         Reviewed by Tim.
1579
1580         - I encapsulated out the server connecton functionality because it is a specific part
1581         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
1582         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
1583         Windows.  So the majority of this patch is moving preexisting functionality.
1584
1585         - Also I removed the prefix header and changed to use config.h because it is more
1586         standard on how we use config.h in windows and it didn't make much sense to keep
1587         the prefix header and the config.h
1588
1589         * Drosera/DebuggerDocument.cpp:
1590         (DebuggerDocument::DebuggerDocument):
1591         * Drosera/DebuggerDocument.h:
1592         * Drosera/config.h:
1593         * Drosera/mac/DebuggerApplication.mm:
1594         (-[DebuggerApplication attach:]):
1595         * Drosera/mac/DebuggerClient.h:
1596         * Drosera/mac/DebuggerClient.mm:
1597         (-[DebuggerClient initWithServerConnection:]):
1598         (-[DebuggerClient dealloc]):
1599         (-[DebuggerClient windowDidLoad]):
1600         (-[DebuggerClient windowWillClose:]):
1601         (-[DebuggerClient webView:didFinishLoadForFrame:]):
1602         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
1603         * Drosera/mac/DebuggerDocumentPlatform.mm:
1604         (DebuggerDocument::platformPause):
1605         (DebuggerDocument::platformResume):
1606         (DebuggerDocument::platformStepInto):
1607         (DebuggerDocument::platformEvaluateScript):
1608         (DebuggerDocument::getPlatformCurrentFunctionStack):
1609         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1610         (DebuggerDocument::platformValueForScopeVariableNamed):
1611         (DebuggerDocument::platformLog):
1612         * Drosera/mac/Drosera.pch: Removed.
1613         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1614         * Drosera/mac/ServerConnection.h: Added.
1615         * Drosera/mac/ServerConnection.mm: Added.
1616         (-[ServerConnection initWithServerName:]):
1617         (-[ServerConnection dealloc]):
1618         (-[ServerConnection setGlobalContext:]):
1619         (-[ServerConnection pause]):
1620         (-[ServerConnection resume]):
1621         (-[ServerConnection stepInto]):
1622         (-[ServerConnection switchToServerNamed:]):
1623         (-[ServerConnection applicationTerminating:]):
1624         (-[ServerConnection serverConnectionDidDie:]):
1625         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1626         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
1627         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
1628         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
1629         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
1630         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
1631         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
1632         (-[ServerConnection currentFrame]):
1633         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
1634         (-[ServerConnection knownServers]):
1635
1636 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
1637
1638         Reviewed by Eric.
1639
1640         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
1641           Script to automatically search nightly builds for regressions (bisect-builds)
1642
1643         * Scripts/bisect-builds: Added.
1644
1645 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
1646
1647         Reviewed by Darin.
1648
1649         - New JavaScript benchmark
1650         http://bugs.webkit.org/show_bug.cgi?id=15515
1651
1652         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
1653         current development or release build of JavaScriptCore.
1654
1655 2007-10-15  Mark Rowe  <mrowe@apple.com>
1656
1657         Reviewed by Sam.
1658
1659         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
1660
1661         * Scripts/webkitdirs.pm:
1662         - Change checkArgv to remove the options from @ARGV to prevent
1663         them from interfering with further option processing.
1664         - Fix logic error in determineIsQt that would prevent it from bailing out early.
1665         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
1666         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
1667         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
1668
1669 2007-10-15  Darin Adler  <darin@apple.com>
1670
1671         Reviewed by Sam.
1672
1673         - added logging of window.prompt and window.confirm
1674
1675         * DumpRenderTree/mac/UIDelegate.mm:
1676         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1677         Implement the recommended delegate rather than the deprecated one.
1678         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
1679         Added.
1680         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1681         Added.
1682
1683         * DumpRenderTree/win/UIDelegate.h:
1684         * DumpRenderTree/win/UIDelegate.cpp:
1685         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
1686         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1687         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
1688         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
1689
1690 2007-10-15  Alice Liu  <alice.liu@apple.com>
1691
1692         Reviewed by Sam Weinig.
1693
1694         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
1695
1696         * DumpRenderTree/win/DumpRenderTree.cpp:
1697         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
1698         (main): allocate the global policy delegate for DRT's custom use
1699         * DumpRenderTree/win/DumpRenderTree.vcproj:
1700         Adding files to project
1701         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
1702         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1703         (LayoutTestController::setCustomPolicyDelegate):
1704         set the webview's policy delegate to DRT's custom one if the test requests it.
1705         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
1706         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
1707         (PolicyDelegate::PolicyDelegate):
1708         (PolicyDelegate::QueryInterface):
1709         (PolicyDelegate::AddRef):
1710         (PolicyDelegate::Release):
1711         (PolicyDelegate::decidePolicyForNavigationAction):
1712         * DumpRenderTree/win/PolicyDelegate.h: Added.
1713         (PolicyDelegate::decidePolicyForNewWindowAction):
1714         (PolicyDelegate::decidePolicyForMIMEType):
1715         (PolicyDelegate::unableToImplementPolicyWithError):
1716
1717 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
1718
1719         Reviewed by Mark.
1720
1721         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
1722         when querying for QMAKE_MKSPECS.
1723
1724 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
1725
1726         Reviewed by Adam Roben.
1727
1728         Fix run-webkit-tests is too greedy calculating platform hierarchy
1729         http://bugs.webkit.org/show_bug.cgi?id=15465
1730
1731         Fix run-webkit-tests being too greedy in trying to split the platform name up
1732         causing it to try and find tests in every directory above the first "-" in the
1733         path to the LayoutTests
1734
1735         * Scripts/run-webkit-tests:
1736
1737 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
1738
1739         Reviewed by Darin.
1740
1741         http://bugs.webkit.org/show_bug.cgi?id=15006
1742         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
1743         to reduce code duplication.
1744
1745         * Scripts/build-webkit:
1746         * Scripts/webkitdirs.pm:
1747         buildQMakeProject() renamed to buildQMakeQtProject().
1748         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
1749         unused $colorize has been removed.
1750
1751 === Start merge of feature-branch 2007-10-12 ===
1752
1753 2007-10-08  Eric Seidel  <eric@webkit.org>
1754
1755         Reviewed by Mark Rowe.
1756
1757         * Scripts/build-webkit: add --help, remove unused --color
1758
1759 2007-10-07  Eric Seidel  <eric@webkit.org>
1760
1761         Reviewed by darin.
1762
1763         * Drosera/mac/DebuggerDocumentPlatform.mm:
1764         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
1765
1766 2007-10-03  Rob Buis  <buis@kde.org>
1767
1768         Reviewed by Olliej.
1769
1770         Adapt to changed location of Ahem font.
1771
1772         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1773
1774 2007-10-02  Eric Seidel  <eric@webkit.org>
1775
1776         Reviewed by Adam Roben.
1777
1778         Make pixel tests more useful!
1779         Finally fix the image diff 0.00% mystery problem
1780         Highlight any image differences in the image diff.
1781         Add a link from image diffs back to original test file.
1782
1783         * DumpRenderTree/mac/ImageDiff.m:
1784         (compareImages): highlight any differences
1785         (computePercentageDifferent): round to two decimal places
1786         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
1787
1788 2007-10-02  Eric Seidel  <eric@webkit.org>
1789
1790         Reviewed by Alexey Proskuryakov.
1791
1792         * Scripts/run-webkit-tests: print the % image difference on main results page
1793
1794 2007-10-02  Mark Rowe  <mrowe@apple.com>
1795
1796         Reviewed by Oliver.
1797
1798         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1799
1800         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1801         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1802
1803 2007-10-01  Mark Rowe  <mrowe@apple.com>
1804
1805         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1806
1807 2007-09-25  Eric Seidel  <eric@webkit.org>
1808
1809         Reviewed by Mark Rowe.
1810
1811         DerivedSources.make was finding "ENABLE_SVG" in the string
1812         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
1813         quite correctly.
1814
1815         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
1816
1817 2007-09-25  Mark Rowe  <mrowe@apple.com>
1818
1819         Rubber-stamped by Eric.
1820
1821         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1822         This makes it possible to automate nightly builds for the feature-branch.
1823
1824 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
1825
1826         Rubber stamped by Mark.
1827
1828         Enable svg experimental features as default here in feature-branch.
1829
1830         * Scripts/build-webkit:
1831
1832 2007-06-29  Antti Koivisto  <antti@apple.com>
1833
1834         Reviewed by Weinig.
1835
1836         Add VIDEO flag for timed media features
1837
1838         * Scripts/build-webkit
1839
1840 === End merge of feature-branch 2007-10-12 ===
1841
1842 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1843
1844         Reviewed by Darin.
1845
1846         - Updated rational for the leaks list to be more clear.
1847
1848         * Scripts/run-webkit-tests:
1849
1850 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1851
1852         Rubber Stamp by Sam.
1853
1854         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
1855         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
1856
1857         * Scripts/run-webkit-tests:
1858
1859 2007-10-10  Simon Hausmann  <hausmann@kde.org>
1860
1861         Reviewed by Lars.
1862
1863         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
1864         includes are needed for INT_MAX, std::auto_ptr and the like.
1865
1866         * DumpRenderTree/qt/main.cpp:
1867
1868 2007-10-09  Lars Knoll  <lars@trolltech.com>
1869
1870         Reviewed by Simon.
1871
1872         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
1873
1874         * DumpRenderTree/qt/jsobjects.cpp:
1875         (LayoutTestController::encodeHostName):
1876         (LayoutTestController::decodeHostName):
1877         * DumpRenderTree/qt/jsobjects.h:
1878
1879 2007-10-09  Lars Knoll  <lars@trolltech.com>
1880
1881         Reviewed by Simon.
1882
1883         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
1884
1885         * DumpRenderTree/qt/DumpRenderTree.cpp:
1886         (WebCore::WebPage::createFrame):
1887         (WebCore::DumpRenderTree::DumpRenderTree):
1888         (WebCore::DumpRenderTree::titleChanged):
1889         * DumpRenderTree/qt/DumpRenderTree.h:
1890         * DumpRenderTree/qt/jsobjects.cpp:
1891         (LayoutTestController::reset):
1892         * DumpRenderTree/qt/jsobjects.h:
1893
1894 2007-10-09  Lars Knoll  <lars@trolltech.com>
1895
1896         Reviewed by Simon.
1897
1898         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
1899
1900         * DumpRenderTree/qt/DumpRenderTree.h:
1901         * DumpRenderTree/qt/jsobjects.cpp:
1902         (LayoutTestController::clearBackForwardList):
1903         * DumpRenderTree/qt/jsobjects.h:
1904
1905 2007-10-09  Lars Knoll  <lars@trolltech.com>
1906
1907         Reviewed by Simon.
1908
1909         make --git-reviewer work again.
1910
1911         * Scripts/prepare-ChangeLog:
1912
1913 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
1914
1915         Rubber stamped by Eric.
1916
1917         Connect to the "hovering-over-link" signal emitted by WebKitPage and
1918         show the current link inside the statusbar.
1919         This shows how to make use of this signal and allows to easily test
1920         http://bugs.webkit.org/show_bug.cgi?id=15299.
1921
1922         * GtkLauncher/main.cpp:
1923         (hoveringOverLink):
1924         (main):
1925
1926 2007-10-05  Lars Knoll  <lars@trolltech.com>
1927
1928         add proper error messages to the FrameLoaderClient.
1929         Implement ChromeClientQt::closeWindowSoon and
1930         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
1931         Some fixes in DRT to make it work correctly with multiple windows.
1932
1933         Reviewed by Maciej.
1934
1935         * DumpRenderTree/qt/DumpRenderTree.cpp:
1936         (WebCore::DumpRenderTree::DumpRenderTree):
1937         (WebCore::DumpRenderTree::createWindow):
1938         (WebCore::DumpRenderTree::windowCount):
1939         * DumpRenderTree/qt/DumpRenderTree.h:
1940         * DumpRenderTree/qt/jsobjects.cpp:
1941         (LayoutTestController::maybeDump):
1942         (LayoutTestController::windowCount):
1943         * DumpRenderTree/qt/jsobjects.h:
1944
1945 2007-10-05  Lars Knoll  <lars@trolltech.com>
1946
1947         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
1948         Add support for layoutTextController.setCanOpenWindows() to DRT
1949         fixing another 2 test cases in fast/dom/Window.
1950
1951         Reviewed by Maciej.
1952
1953         * DumpRenderTree/qt/DumpRenderTree.cpp:
1954         (WebCore::WebPage::WebPage):
1955         (WebCore::WebPage::createWindow):
1956         (WebCore::DumpRenderTree::resetJSObjects):
1957         (WebCore::DumpRenderTree::createWindow):
1958         * DumpRenderTree/qt/DumpRenderTree.h:
1959         * DumpRenderTree/qt/DumpRenderTree.pro:
1960         * DumpRenderTree/qt/jsobjects.cpp:
1961         (LayoutTestController::LayoutTestController):
1962         (LayoutTestController::reset):
1963         * DumpRenderTree/qt/jsobjects.h:
1964         * DumpRenderTree/qt/main.cpp:
1965         * DumpRenderTree/qt/testplugin.cpp: Added.
1966         * DumpRenderTree/qt/testplugin.h: Added.
1967
1968 2007-10-04  Sam Weinig  <sam@webkit.org>
1969
1970         Rubber stamped by Adam.
1971
1972         Remove empty directories.
1973
1974         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
1975         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
1976
1977 2007-10-03  Darin Adler  <darin@apple.com>
1978
1979         Reviewed by Adam.
1980
1981         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
1982         we find the internal libraries in the libraries directory. This
1983         is helpful for Safari team engineers at Apple.
1984
1985 2007-10-03  Adam Roben  <aroben@apple.com>
1986
1987         Update the location of AHEM___.TTF after r25968
1988
1989         Reviewed by Sam.
1990
1991         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1992
1993 2007-10-03  Alp Toker  <alp@atoker.com>
1994
1995         Reviewed by Adam.
1996
1997         http://bugs.webkit.org/show_bug.cgi?id=14726
1998         [gtk] API design. Mapping the WebView delegates to signals.
1999
2000         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
2001
2002         * GtkLauncher/main.cpp:
2003         (goToURLBarText):
2004         (titleChanged):
2005         (progressChanged):
2006         (menuMainBackCallback):
2007         (menuMainForwardCallback):
2008         (main):
2009
2010 2007-10-03  Lars Knoll  <lars@trolltech.com>
2011
2012         Reviewed by Rob.
2013
2014         This fixes --strict mode in run-webkit-tests again after
2015         the platform dependent test results have been moved.
2016
2017         * Scripts/run-webkit-tests:
2018
2019 2007-10-03  Lars Knoll  <lars@trolltech.com>
2020
2021         Reviewed by bdash.
2022
2023         remove the hack in run-webkit-tests that forced text only test
2024         to be taken from the platform independent dir. It was only left
2025         there from early days.
2026
2027         Remove platform dependent results for tests that are text only nowadays,
2028         and add one platform dependent result for a text only test that requires it.
2029
2030         * Scripts/run-webkit-tests:
2031
2032 2007-10-03  Lars Knoll  <lars@trolltech.com>
2033
2034         Reviewed by olliej.
2035
2036         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
2037
2038         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
2039         (WebCore::WebFrame::WebFrame):
2040         (WebCore::WebPage::WebPage):
2041         (WebCore::WebPage::createFrame):
2042         (WebCore::WebPage::javaScriptAlert):
2043         (WebCore::WebPage::javaScriptConsoleMessage):
2044         (WebCore::DumpRenderTree::DumpRenderTree):
2045         (WebCore::DumpRenderTree::~DumpRenderTree):
2046         (WebCore::DumpRenderTree::open):
2047         (WebCore::DumpRenderTree::readStdin):
2048         (WebCore::DumpRenderTree::resetJSObjects):
2049         (WebCore::DumpRenderTree::initJSObjects):
2050         (WebCore::DumpRenderTree::dumpFramesAsText):
2051         (WebCore::DumpRenderTree::dump):
2052         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
2053         (WebCore::DumpRenderTree::layoutTestController):
2054         (WebCore::DumpRenderTree::eventSender):
2055         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
2056         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
2057         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
2058         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
2059         (HackWebFrame::mousePressEvent):
2060         (HackWebFrame::mouseReleaseEvent):
2061         (HackWebFrame::mouseMoveEvent):
2062         (HackWebFrame::HackWebFrame):
2063         (HackWebFrame::~HackWebFrame):
2064         (LayoutTestController::LayoutTestController):
2065         (LayoutTestController::reset):
2066         (LayoutTestController::maybeDump):
2067         (LayoutTestController::waitUntilDone):
2068         (LayoutTestController::notifyDone):
2069         (LayoutTestController::dumpEditingCallbacks):
2070         (LayoutTestController::queueReload):
2071         (LayoutTestController::provisionalLoad):
2072         (LayoutTestController::timerEvent):
2073         (EventSender::EventSender):
2074         (EventSender::mouseDown):
2075         (EventSender::mouseUp):
2076         (EventSender::mouseMoveTo):
2077         (EventSender::leapForward):
2078         (EventSender::keyDown):
2079         (EventSender::frameUnderMouse):
2080         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
2081         (LayoutTestController::isLoading):
2082         (LayoutTestController::setLoading):
2083         (LayoutTestController::shouldDumpAsText):
2084         (LayoutTestController::shouldDumpChildrenAsText):
2085         (LayoutTestController::shouldWaitUntilDone):
2086         (LayoutTestController::dumpAsText):
2087         (LayoutTestController::dumpChildFramesAsText):
2088         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
2089         (messageHandler):
2090         (crashHandler):
2091         (main):
2092         * Scripts/run-webkit-tests:
2093
2094 2007-10-03  Mark Rowe  <mrowe@apple.com>
2095
2096         Reviewed by Alp Toker.
2097
2098         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
2099         should take precedence over QTDIR when determining which port we are working with.
2100
2101         * Scripts/webkitdirs.pm:
2102
2103 2007-10-02  Adam Roben  <aroben@apple.com>
2104
2105         Add keychain to the list of default packages to install
2106
2107         Rubberstamped by Sam.
2108
2109         * CygwinDownloader/cygwin-downloader.py:
2110         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2111
2112 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
2113
2114         Reviewed by Adam.
2115
2116         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
2117         Also makes WebCore regression test case logic work when using git.
2118
2119         * Scripts/prepare-ChangeLog:
2120         (reviewerAndDescriptionForGitCommit): Added.
2121
2122 2007-10-02  Lars Knoll  <lars@trolltech.com>
2123
2124         Reviewed by bdash.
2125
2126         Add API to retrieve the frame name from QWebFrame.
2127         Implement support for DRT::dumpChildrenAsText.
2128
2129         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2130         (WebCore::DumpRenderTree::dumpFramesAsText):
2131         (WebCore::DumpRenderTree::dump):
2132         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2133         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2134         (LayoutTestController::LayoutTestController):
2135         (LayoutTestController::reset):
2136         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2137
2138 2007-10-02  Lars Knoll  <lars@trolltech.com>
2139
2140         Reviewed by bdash.
2141
2142         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
2143
2144         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2145         (WebCore::DumpRenderTree::readStdin):
2146
2147 2007-10-02  Mark Rowe  <mrowe@apple.com>
2148
2149         Reviewed by Oliver.
2150
2151         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2152
2153         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2154         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2155
2156 2007-10-02  Mark Rowe  <mrowe@apple.com>
2157
2158         Rubber-stamped by Maciej.
2159
2160         Configuration changes from build.webkit.org.  The major change is refactoring to work
2161         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
2162         last few weeks.
2163
2164         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2165         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
2166         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
2167         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
2168         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
2169         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
2170         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
2171         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
2172
2173 2007-10-02  Lars Knoll  <lars@trolltech.com>
2174
2175         Reviewed by Maciej.
2176
2177         Add support for eventSender.mouseMove to DRT.
2178         Fixes fast/css/hover-affects-child.html
2179
2180         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2181         (EventSender::mouseMoveTo):
2182
2183 2007-10-01  Mark Rowe  <mrowe@apple.com>
2184
2185         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2186
2187 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
2188
2189         Reviewed by Hyatt.
2190
2191         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
2192
2193         * Scripts/svn-apply:
2194         (gitdiff2svndiff): Ignore lines beginning with "new file".
2195         * Scripts/svn-unapply:
2196         (gitdiff2svndiff): Ditto.
2197
2198 2007-09-30  George Staikos  <staikos@kde.org>
2199
2200         Qt build fix (Mac OS X specific)
2201
2202         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
2203
2204 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
2205
2206         Reviewed by Mark.
2207
2208         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
2209         Remove Bakefiles from svn.
2210
2211         * GtkLauncher/Bakefiles.bkgen: Removed.
2212         * GtkLauncher/ENV: Removed.
2213         * GtkLauncher/gdklauncher.bkl: Removed.
2214         * GtkLauncher/mk: Removed.
2215         * Scripts/regenerate-makefiles: Removed.
2216
2217 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
2218
2219         Reviewed by John.
2220
2221         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
2222
2223         * Scripts/run-webkit-tests:
2224
2225 2007-09-26  Adam Roben  <aroben@apple.com>
2226
2227         Make not finding an installed WebKit non-fatal
2228
2229         What really matters is that we are able to load WebKit and its
2230         dependencies, not whether we think we've found an installed WebKit.
2231
2232         Reviewed by Sam.
2233
2234         * WebKitInitializer/WebKitInitializer.cpp:
2235         (getWebViewCLSID): Use new LOG_WARNING macro.
2236         (getInstalledWebKitDirectory): Ditto.
2237         (initializeWebKit): Don't die if we didn't find an installed WebKit,
2238         and use new macros.
2239         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
2240
2241 2007-09-26  Adam Roben  <aroben@apple.com>
2242
2243         Committed this file before saving it
2244
2245         * WebKitInitializer/debug_internal.vsprops:
2246
2247 2007-09-26  Adam Roben  <aroben@apple.com>
2248
2249         Load WebKit and its dependencies manually so they come from DllDirectory
2250
2251         I had to change WebKitInitializer to use malloc/free instead of
2252         new/delete to avoid pulling in WebKit (and its dependencies) early
2253         through use of fastMalloc.
2254
2255         Reviewed by Oliver.
2256
2257         * WebKitInitializer/WebKitInitializer.cpp:
2258         (getStringValue): Changed to use malloc/free.
2259         (getInstalledWebKitDirectory): Ditto.
2260         (initializeWebKit): Call SetDllDirectory first, then load all of
2261         WebKit's dependencies manually, finally followed by WebKit itself.
2262         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
2263         configuration to match our other projects.
2264         * WebKitInitializer/debug_internal.vsprops: Added.
2265
2266 2007-09-25  Adam Roben  <aroben@apple.com>
2267
2268         Actually define DEBUG/NDEBUG so that we load WebKit correctly
2269
2270         Rubberstamped by Sam.
2271
2272         * WebKitInitializer/WebKitInitializer.vcproj:
2273
2274 2007-09-25  Adam Roben  <aroben@apple.com>
2275
2276         Make DumpRenderTree delay-load its dependencies
2277
2278         This lets WebKitInitializer re-route the dependencies to be loaded out
2279         of the Safari installation directory.
2280
2281         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
2282         same thing), since we can't import the kCFAllocatorDefault symbol when
2283         delay-loading CoreFoundation.dll.
2284
2285         Rubberstamped by Sam.
2286
2287         * DumpRenderTree/win/DumpRenderTree.cpp:
2288         (runTest):
2289         (javaScriptThreads):
2290         * DumpRenderTree/win/DumpRenderTree.vcproj:
2291         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2292         (LayoutTestController::setWaitToDump):
2293
2294 2007-09-25  Adam Roben  <aroben@apple.com>
2295
2296         Pull ole32.lib into WebKitInitializer
2297
2298         Rubberstamped by Sam.
2299
2300         * WebKitInitializer/WebKitInitializer.vcproj:
2301
2302 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2303
2304         Reviewed by Adam.
2305
2306         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
2307           LGPL'ed files contain incorrect FSF address
2308
2309         * Drosera/config.h:
2310
2311 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2312
2313         Reviewed by Adam.
2314
2315         Make svn-apply and svn-unapply work with git-diff formatted patches.
2316
2317         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
2318         (gitdiff2svndiff): Added.
2319         * Scripts/svn-unapply: Ditto.
2320         (gitdiff2svndiff): Added.
2321
2322 2007-09-25  Adam Roben  <aroben@apple.com>
2323
2324         Pull advapi32.lib into WebKitInitializer
2325
2326         This is needed to get the registry functions we use.
2327
2328         Rubberstamped by Sam.
2329
2330         * WebKitInitializer/WebKitInitializer.vcproj:
2331
2332 2007-09-25  Adam Roben  <aroben@apple.com>
2333
2334         Add python and rsync to cygwin-downloader
2335
2336         Our build slaves need this, and it can't hurt for everyone else to
2337         have it, too.
2338
2339         Reviewed by Sam.
2340
2341         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
2342         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2343
2344 2007-09-25  Adam Roben  <aroben@apple.com>
2345
2346         Add WebKitInitializer and use it in DumpRenderTree
2347
2348         WebKitInitializer is a static library that has one function,
2349         initializeWebKit(). This registers WebKit and sets up the DLL search
2350         path so that WebKit's dependencies that are installed with Safari can
2351         be found.
2352
2353         Reviewed by Sam.
2354
2355         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
2356         DumpRenderTree depend on it.
2357         * DumpRenderTree/win/DumpRenderTree.cpp:
2358         (initialize): Call initializeWebKit.
2359         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
2360         WebKitInitializer.lib.
2361         * WebKitInitializer/WebKitInitializer.cpp: Added.
2362         (getStringValue):
2363         (getWebViewCLSID):
2364         (getInstalledWebKitDirectory):
2365         (initializeWebKit):
2366         * WebKitInitializer/WebKitInitializer.h: Added.
2367         * WebKitInitializer/WebKitInitializer.vcproj: Added.
2368         * WebKitInitializer/debug.vsprops: Added.
2369         * WebKitInitializer/release.vsprops: Added.
2370
2371 2007-09-25  Adam Roben  <aroben@apple.com>
2372
2373         Make run-webkit-tests respect set-webkit-configuration
2374
2375         Reviewed by Sam.
2376
2377         * Scripts/run-webkit-tests: Initialize $configuration to whatever
2378         set-webkit-configuration was last set to.
2379
2380 2007-09-25  Mark Rowe  <mrowe@apple.com>
2381
2382         Rubber-stamped by Eric.
2383
2384         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2385         This makes it possible to automate nightly builds for the feature-branch.
2386
2387 2007-09-25  Adam Roben  <aroben@apple.com>
2388
2389         A couple of fixes/enhancements to update-webkit-*-libs
2390
2391         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
2392         to tell update-webkit-support-libraries where it should find the
2393         WebKitSupportLibrary.zip file you downloaded.
2394
2395         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
2396         Windows-style path.
2397
2398         Reviewed by Sam.
2399
2400         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
2401         to $auxiliaryLibsURL and removed an irrelevant comment.
2402         * Scripts/update-webkit-support-libs:
2403
2404 2007-09-25  Adam Treat  <treat@kde.org>
2405
2406         Reviewed by Simon and Lars.
2407
2408         Refactors and cleans up Qt DRT member variable names, member variable
2409         initialization, style fixes and general code cleanup.
2410
2411         Adds queueReload slot to LayoutTestController that some tests require.
2412
2413         Subclasses QWebFrame to make sure that all frames have an associated
2414         LayoutTestController JS window object.
2415
2416         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
2417         aren't dumped twice.
2418
2419         EOF fixes.
2420
2421         Together, this patch fixes some 20+ layout tests in QtWebKit.
2422
2423         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2424         (WebCore::WebFrame::WebFrame):
2425         (WebCore::WebPage::WebPage):
2426         (WebCore::WebPage::createFrame):
2427         (WebCore::DumpRenderTree::DumpRenderTree):
2428         (WebCore::DumpRenderTree::open):
2429         (WebCore::DumpRenderTree::readStdin):
2430         (WebCore::DumpRenderTree::initJSObjects):
2431         (WebCore::DumpRenderTree::dump):
2432         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2433         (WebCore::DumpRenderTree::layoutTestController):
2434         (WebCore::DumpRenderTree::eventSender):
2435         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2436         (LayoutTestController::LayoutTestController):
2437         (LayoutTestController::reset):
2438         (LayoutTestController::maybeDump):
2439         (LayoutTestController::waitUntilDone):
2440         (LayoutTestController::notifyDone):
2441         (LayoutTestController::queueReload):
2442         (LayoutTestController::provisionalLoad):
2443         (EventSender::EventSender):
2444         (EventSender::mouseDown):
2445         (EventSender::mouseUp):
2446         (EventSender::mouseMoveTo):
2447         (EventSender::frameUnderMouse):
2448         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2449         (LayoutTestController::isLoading):
2450         (LayoutTestController::setLoading):
2451         (LayoutTestController::dumpAsText):
2452         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
2453         (main):
2454
2455 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2456
2457
2458         - Reverted an accidentally checked in file.
2459
2460         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
2461
2462 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2463         Reviewed by Sam.
2464
2465         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
2466
2467         * DumpRenderTree/win/DumpRenderTree.vcproj:
2468         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2469
2470 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
2471
2472         Rubber stamped by Adam.
2473
2474         * GdkLauncher: Removed.
2475         * GdkLauncher/Bakefiles.bkgen: Removed.
2476         * GdkLauncher/ENV: Removed.
2477         * GdkLauncher/GdkLauncher.pro: Removed.
2478         * GdkLauncher/gdklauncher.bkl: Removed.
2479         * GdkLauncher/main.cpp: Removed.
2480         * GdkLauncher/mk: Removed.
2481         * GdkLauncher/simple.svg: Removed.
2482         * GdkLauncher/text.html: Removed.
2483         * GtkLauncher: Added.
2484         * GtkLauncher/GdkLauncher.pro: Removed.
2485         * GtkLauncher/GtkLauncher.pro: Added.
2486         * GtkLauncher/main.cpp:
2487         (updateWindowTitle):
2488         (main):
2489         * Scripts/build-webkit:
2490         * Scripts/regenerate-makefiles:
2491         * Scripts/run-javascriptcore-tests:
2492         * Scripts/run-launcher:
2493         * Scripts/run-webkit-tests:
2494         * Scripts/webkitdirs.pm:
2495
2496 2007-09-21  Timothy Hatcher  <timothy@apple.com>
2497
2498         Reviewed by Darin.
2499
2500         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
2501
2502         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
2503         This is tested by plugins/root-object-premature-delete-crash.html.
2504
2505         * DumpRenderTree/mac/ObjCController.m:
2506         (-[ObjCController accessStoredWebScriptObject]):
2507
2508 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
2509
2510         Reviewed by Oliver.
2511
2512         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
2513
2514         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2515         (FrameLoadDelegate::FrameLoadDelegate):
2516
2517 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
2518
2519         Reviewed by Adam.
2520
2521         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
2522         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
2523
2524         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
2525         Now isQt() and isGdk() use global variables that are only set once.
2526
2527         An array of all the parameters is now given to build-dumprender which includes
2528         the platform on linux.
2529
2530         * Scripts/build-dumprendertree:
2531         * Scripts/run-webkit-tests:
2532         * Scripts/webkitdirs.pm:
2533
2534 2007-09-19  Adam Roben  <aroben@apple.com>
2535
2536         Rubberstamped by Hyatt.
2537
2538         * Spinneret: Removed.
2539
2540 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
2541
2542         Reviewed by David Kilzer.
2543
2544         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
2545
2546 2007-09-18  Sam Weinig  <sam@webkit.org>
2547
2548         Add JSRetainPtr.h #include to fix some builds.
2549
2550         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2551
2552 2007-09-18  Mike Hommey  <glandium@debian.org>
2553
2554         Reviewed by Adam.
2555
2556         * Scripts/prepare-ChangeLog:
2557         - Properly parse GECOS field.
2558         - Use git configuration for user name and email when appropriate.
2559
2560 2007-09-17  Sam Weinig  <sam@webkit.org>
2561
2562         Build fix.
2563
2564         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2565
2566 2007-09-17  Sam Weinig  <sam@webkit.org>
2567
2568         Reviewed by Adam Roben.
2569
2570         Share more code between mac and windows DRT.
2571             - GCController is now shared.
2572             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
2573
2574         * DumpRenderTree/GCController.cpp:
2575         * DumpRenderTree/win/DumpRenderTree.cpp:
2576         * DumpRenderTree/win/DumpRenderTree.vcproj:
2577         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
2578         (FrameLoadDelegate::FrameLoadDelegate):
2579         (FrameLoadDelegate::~FrameLoadDelegate):
2580         (FrameLoadDelegate::windowScriptObjectAvailable):
2581         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
2582         * DumpRenderTree/win/GCController.cpp: Removed.
2583         * DumpRenderTree/win/GCController.h: Removed.
2584         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
2585         (GCController::collect):
2586         (GCController::collectOnAlternateThread):
2587         (GCController::getJSObjectCount):
2588         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
2589         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
2590
2591 2007-09-17  Sam Weinig  <sam@webkit.org>
2592
2593         Reviewed by Adam Roben.
2594
2595         Begin sharing code between mac and windows DRT.
2596             - both now share LayoutTestController.h/cpp and implement platform dependant
2597               operations in LayoutTestControllerMac/Win.
2598             - DumpRenderTree.h is now shared.
2599             - WorkQueue and WorkQueueItem are also shared.
2600
2601         * DumpRenderTree/DumpRenderTree.h:
2602         * DumpRenderTree/LayoutTestController.cpp:
2603         * DumpRenderTree/win/DumpRenderTree.cpp:
2604         (displayWebView):
2605         (dumpFrameScrollPosition):
2606         (dumpFramesAsText):
2607         (dump):
2608         (runTest):
2609         * DumpRenderTree/win/DumpRenderTree.h: Removed.
2610         * DumpRenderTree/win/DumpRenderTree.vcproj:
2611         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
2612         * DumpRenderTree/win/EditingDelegate.cpp:
2613         (EditingDelegate::shouldBeginEditingInDOMRange):
2614         (EditingDelegate::shouldEndEditingInDOMRange):
2615         (EditingDelegate::shouldInsertNode):
2616         (EditingDelegate::shouldInsertText):
2617         (EditingDelegate::shouldDeleteDOMRange):
2618         (EditingDelegate::shouldChangeSelectedDOMRange):
2619         (EditingDelegate::shouldApplyStyle):
2620         (EditingDelegate::shouldChangeTypingStyle):
2621         (EditingDelegate::doPlatformCommand):
2622         (EditingDelegate::webViewDidBeginEditing):
2623         (EditingDelegate::webViewDidChange):
2624         (EditingDelegate::webViewDidEndEditing):
2625         (EditingDelegate::webViewDidChangeTypingStyle):
2626         (EditingDelegate::webViewDidChangeSelection):
2627         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
2628         * DumpRenderTree/win/LayoutTestController.h: Removed.
2629         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
2630         (LayoutTestController::addDisallowedURL):
2631         (LayoutTestController::clearBackForwardList):
2632         (LayoutTestController::copyDecodedHostName):
2633         (LayoutTestController::copyEncodedHostName):
2634         (LayoutTestController::display):
2635         (LayoutTestController::keepWebHistory):
2636         (LayoutTestController::notifyDone):
2637         (LayoutTestController::queueBackNavigation):
2638         (LayoutTestController::queueForwardNavigation):
2639         (jsStringRefToWString):
2640         (LayoutTestController::queueLoad):
2641         (LayoutTestController::queueReload):
2642         (LayoutTestController::queueScript):
2643         (LayoutTestController::setAcceptsEditing):
2644         (LayoutTestController::setCustomPolicyDelegate):
2645         (LayoutTestController::setMainFrameIsFirstResponder):
2646         (LayoutTestController::setTabKeyCyclesThroughElements):
2647         (LayoutTestController::setUseDashboardCompatibilityMode):
2648         (LayoutTestController::setUserStyleSheetEnabled):
2649         (LayoutTestController::setUserStyleSheetLocation):
2650         (LayoutTestController::setWindowIsKey):
2651         (waitUntilDoneWatchdogFired):
2652         (LayoutTestController::setWaitToDump):
2653         (LayoutTestController::windowCount):
2654         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
2655         (FrameLoadDelegate::didReceiveTitle):
2656         (FrameLoadDelegate::processWork):
2657         (FrameLoadDelegate::locationChangeDone):
2658         (FrameLoadDelegate::windowScriptObjectAvailable):
2659         * DumpRenderTree/win/WorkQueue.cpp: Removed.
2660         * DumpRenderTree/win/WorkQueue.h: Removed.
2661         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
2662         * DumpRenderTree/win/WorkQueueItem.h: Removed.
2663         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
2664         (jsStringRefToWString):
2665         (LoadItem::invoke):
2666         (ScriptItem::invoke):
2667
2668 2007-09-17  Sam Weinig  <sam@webkit.org>
2669
2670         Reviewed by Adam Roben.
2671
2672         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
2673
2674         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
2675         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
2676         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
2677         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
2678         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
2679         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
2680         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
2681         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
2682         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
2683         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
2684         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
2685         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
2686         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
2687         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
2688         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
2689         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
2690         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
2691         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
2692         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
2693         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
2694         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
2695         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
2696         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
2697         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
2698         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
2699         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
2700         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
2701         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
2702         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
2703         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
2704         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
2705         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
2706         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
2707         * DumpRenderTree/win: Added.
2708         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
2709         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
2710         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
2711         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
2712         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
2713         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
2714         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
2715         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
2716         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
2717         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
2718         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
2719         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
2720         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
2721         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2722         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
2723         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
2724         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
2725         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
2726         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2727         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2728         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
2729         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2730         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
2731         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
2732         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
2733         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
2734
2735 2007-09-15  Mark Rowe  <mrowe@apple.com>
2736
2737         Build fix for DumpRenderTree.
2738
2739         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
2740
2741 2007-09-14  Sam Weinig  <sam@webkit.org>
2742
2743         Rubber stamped by Adam Roben.
2744
2745         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
2746           - The UIDelegate was put into a new file while the FrameLoadDelegate was
2747             kept in the WaitUntilDoneDelegate file for the time being.
2748
2749         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
2750         (main):
2751         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
2752         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
2753         (UIDelegate::QueryInterface):
2754         (UIDelegate::AddRef):
2755         (UIDelegate::Release):
2756         (UIDelegate::hasCustomMenuImplementation):
2757         (UIDelegate::setFrame):
2758         (UIDelegate::webViewFrame):
2759         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2760         (UIDelegate::webViewAddMessageToConsole):
2761         (UIDelegate::doDragDrop):
2762         (UIDelegate::webViewGetDlgCode):
2763         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
2764         (UIDelegate::UIDelegate):
2765         (UIDelegate::createWebViewWithRequest):
2766         (UIDelegate::webViewShow):
2767         (UIDelegate::webViewClose):
2768         (UIDelegate::webViewFocus):
2769         (UIDelegate::webViewUnfocus):
2770         (UIDelegate::webViewFirstResponder):
2771         (UIDelegate::makeFirstResponder):
2772         (UIDelegate::setStatusText):
2773         (UIDelegate::webViewStatusText):
2774         (UIDelegate::webViewAreToolbarsVisible):
2775         (UIDelegate::setToolbarsVisible):
2776         (UIDelegate::webViewIsStatusBarVisible):
2777         (UIDelegate::setStatusBarVisible):
2778         (UIDelegate::webViewIsResizable):
2779         (UIDelegate::setResizable):
2780         (UIDelegate::setContentRect):
2781         (UIDelegate::webViewContentRect):
2782         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2783         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2784         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2785         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
2786         (UIDelegate::mouseDidMoveOverElement):
2787         (UIDelegate::contextMenuItemsForElement):
2788         (UIDelegate::validateUserInterfaceItem):
2789         (UIDelegate::shouldPerformAction):
2790         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
2791         (UIDelegate::willPerformDragDestinationAction):
2792         (UIDelegate::dragSourceActionMaskForPoint):
2793         (UIDelegate::willPerformDragSourceAction):
2794         (UIDelegate::contextMenuItemSelected):
2795         (UIDelegate::trackCustomPopupMenu):
2796         (UIDelegate::measureCustomMenuItem):
2797         (UIDelegate::drawCustomMenuItem):
2798         (UIDelegate::addCustomMenuDrawingData):
2799         (UIDelegate::cleanUpCustomMenuDrawingData):
2800         (UIDelegate::canTakeFocus):
2801         (UIDelegate::takeFocus):
2802         (UIDelegate::registerUndoWithTarget):
2803         (UIDelegate::removeAllActionsWithTarget):
2804         (UIDelegate::setActionTitle):
2805         (UIDelegate::undo):
2806         (UIDelegate::redo):
2807         (UIDelegate::canUndo):
2808         (UIDelegate::canRedo):
2809         (UIDelegate::webViewResizerRect):
2810         (UIDelegate::webViewDrawResizer):
2811         (UIDelegate::webViewScrolled):
2812         (UIDelegate::webViewShouldInterruptJavaScript):
2813         (UIDelegate::webViewReceivedFocus):
2814         (UIDelegate::webViewLostFocus):
2815         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
2816         (FrameLoadDelegate::QueryInterface):
2817         (FrameLoadDelegate::AddRef):
2818         (FrameLoadDelegate::Release):
2819         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2820         (FrameLoadDelegate::didCommitLoadForFrame):
2821         (FrameLoadDelegate::didReceiveTitle):
2822         (FrameLoadDelegate::processWork):
2823         (processWorkTimer):
2824         (FrameLoadDelegate::locationChangeDone):
2825         (FrameLoadDelegate::didFinishLoadForFrame):
2826         (FrameLoadDelegate::didFailLoadWithError):
2827         (FrameLoadDelegate::windowScriptObjectAvailable):
2828         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
2829         (FrameLoadDelegate::FrameLoadDelegate):
2830
2831 2007-09-14  Sam Weinig  <sam@webkit.org>
2832
2833         Reviewed by Kevin McCullough.
2834
2835         Move mac specific globals in to mac/DumpRenderTreeMac.h
2836
2837         * DumpRenderTree/DumpRenderTree.h:
2838         * DumpRenderTree/DumpRenderTree.mm: Removed.
2839         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2840         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
2841         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
2842
2843 2007-09-14  Brady Eidson  <beidson@apple.com>
2844
2845         Rubberstamped by Weinig
2846
2847         You know, Sam, some of us use case-sensitve filesystems...
2848
2849         * DumpRenderTree/DumpRenderTree.h:
2850         * DumpRenderTree/mac/UIDelegate.mm:
2851
2852 2007-09-14  Sam Weinig  <sam@webkit.org>
2853
2854         Rubber stamped by Adam Roben.
2855
2856         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
2857         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
2858
2859         * DumpRenderTree/AppleScriptController.h: Removed.
2860         * DumpRenderTree/AppleScriptController.m: Removed.
2861         * DumpRenderTree/DumpRenderTree.h:
2862         * DumpRenderTree/DumpRenderTree.mm:
2863         (startJavaScriptThreads):
2864         (stopJavaScriptThreads):
2865         (activateAhemFont):
2866         (setDefaultColorProfileToRGB):
2867         (makeLargeMallocFailSilently):
2868         (dumpFrameScrollPosition):
2869         (dumpFramesAsText):
2870         (dump):
2871         (runTest):
2872         (-[DumpRenderTreeWindow isKeyWindow]):
2873         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2874         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
2875         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
2876         * DumpRenderTree/EditingDelegate.h: Removed.
2877         * DumpRenderTree/EditingDelegate.m: Removed.
2878         * DumpRenderTree/EventSendingController.h: Removed.
2879         * DumpRenderTree/EventSendingController.m: Removed.
2880         * DumpRenderTree/FrameLoadDelegate.h: Removed.
2881         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
2882         * DumpRenderTree/GCController.mm: Removed.
2883         * DumpRenderTree/ImageDiff.m: Removed.
2884         * DumpRenderTree/LayoutTestController.cpp:
2885         (LayoutTestController::LayoutTestController):
2886         (dumpAsTextCallback):
2887         (dumpBackForwardListCallback):
2888         (dumpChildFramesAsTextCallback):
2889         (dumpChildFrameScrollPositionsCallback):
2890         (dumpDOMAsWebArchiveCallback):
2891         (dumpEditingCallbacksCallback):
2892         (dumpFrameLoadCallbacksCallback):
2893         (dumpResourceLoadCallbacksCallback):
2894         (dumpSelectionRectCallback):
2895         (dumpSourceAsWebArchiveCallback):
2896         (dumpTitleChangesCallback):
2897         (repaintSweepHorizontallyCallback):
2898         (setCallCloseOnWebViewsCallback):
2899         (setCanOpenWindowsCallback):
2900         (setCloseRemainingWindowsWhenCompleteCallback):
2901         (testRepaintCallback):
2902         (addFileToPasteboardOnDragCallback):
2903         (waitUntilDoneCallback):
2904         * DumpRenderTree/LayoutTestController.h:
2905         (LayoutTestController::dumpAsText):
2906         (LayoutTestController::setDumpAsText):
2907         (LayoutTestController::dumpBackForwardList):
2908         (LayoutTestController::setDumpBackForwardList):
2909         (LayoutTestController::dumpChildFrameScrollPositions):
2910         (LayoutTestController::setDumpChildFrameScrollPositions):
2911         (LayoutTestController::dumpChildFramesAsText):
2912         (LayoutTestController::setDumpChildFramesAsText):
2913         (LayoutTestController::dumpDOMAsWebArchive):
2914         (LayoutTestController::setDumpDOMAsWebArchive):
2915         (LayoutTestController::dumpSelectionRect):
2916         (LayoutTestController::setDumpSelectionRect):
2917         (LayoutTestController::dumpSourceAsWebArchive):
2918         (LayoutTestController::setDumpSourceAsWebArchive):
2919         (LayoutTestController::dumpTitleChanges):
2920         (LayoutTestController::setDumpTitleChanges):
2921         (LayoutTestController::dumpEditingCallbacks):
2922         (LayoutTestController::setDumpEditingCallbacks):
2923         (LayoutTestController::dumpResourceLoadCallbacks):
2924         (LayoutTestController::setDumpResourceLoadCallbacks):
2925         (LayoutTestController::dumpFrameLoadCallbacks):
2926         (LayoutTestController::setDumpFrameLoadCallbacks):
2927         (LayoutTestController::addFileToPasteboardOnDrag):
2928         (LayoutTestController::setAddFileToPasteboardOnDrag):
2929         (LayoutTestController::callCloseOnWebViews):
2930         (LayoutTestController::setCallCloseOnWebViews):
2931         (LayoutTestController::canOpenWindows):
2932         (LayoutTestController::setCanOpenWindows):
2933         (LayoutTestController::closeRemainingWindowsWhenComplete):
2934         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2935         (LayoutTestController::testRepaint):
2936         (LayoutTestController::setTestRepaint):
2937         (LayoutTestController::testRepaintSweepHorizontally):
2938         (LayoutTestController::setTestRepaintSweepHorizontally):
2939         (LayoutTestController::waitToDump):
2940         (LayoutTestController::windowIsKey):
2941         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
2942         * DumpRenderTree/NavigationController.h: Removed.
2943         * DumpRenderTree/NavigationController.m: Removed.
2944         * DumpRenderTree/ObjCController.h: Removed.
2945         * DumpRenderTree/ObjCController.m: Removed.
2946         * DumpRenderTree/ObjCPlugin.h: Removed.
2947         * DumpRenderTree/ObjCPlugin.m: Removed.
2948         * DumpRenderTree/ObjCPluginFunction.h: Removed.
2949         * DumpRenderTree/ObjCPluginFunction.m: Removed.
2950         * DumpRenderTree/PolicyDelegate.h: Removed.
2951         * DumpRenderTree/PolicyDelegate.m: Removed.
2952         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
2953         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
2954         * DumpRenderTree/TextInputController.h: Removed.
2955         * DumpRenderTree/TextInputController.m: Removed.
2956         * DumpRenderTree/UIDelegate.h: Removed.
2957         * DumpRenderTree/UIDelegate.mm: Removed.
2958         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
2959         * DumpRenderTree/mac: Added.
2960         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
2961         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
2962         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
2963         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
2964         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
2965         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
2966         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2967         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2968         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2969         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2970         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2971         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2972         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2973         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2974         (-[EditingDelegate webViewDidBeginEditing:]):
2975         (-[EditingDelegate webViewDidChange:]):
2976         (-[EditingDelegate webViewDidEndEditing:]):
2977         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2978         (-[EditingDelegate webViewDidChangeSelection:]):
2979         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
2980         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
2981         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
2982         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
2983         (-[FrameLoadDelegate init]):
2984         (-[FrameLoadDelegate dealloc]):
2985         (-[FrameLoadDelegate processWork:]):
2986         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2987         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2988         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2989         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2990         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2991         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2992         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2993         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2994         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2995         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2996         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2997         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2998         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2999         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3000         (-[FrameLoadDelegate webView:willCloseFrame:]):
3001         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3002         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3003         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
3004         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
3005         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
3006         (LayoutTestController::notifyDone):
3007         (LayoutTestController::setWindowIsKey):
3008         (LayoutTestController::setWaitToDump):
3009         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
3010         * DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
3011         * DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
3012         * DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
3013         * DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
3014         * DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
3015         * DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
3016         * DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
3017         * DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
3018         * DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
3019         * DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
3020         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m.
3021         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3022         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3023         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3024         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3025         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3026         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3027         * DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
3028         * DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
3029         * DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
3030         * DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm.
3031         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
3032         (-[UIDelegate webViewFocus:]):
3033         (-[UIDelegate webView:createWebViewWithRequest:]):
3034         (-[UIDelegate webViewClose:]):
3035         * DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.
3036
3037 2007-09-14  Kevin McCullough  <kmccullough@apple.com>
3038
3039         Reviewed by Adam.
3040
3041         - Changing Win version of Drosera work with recent changes.
3042
3043         * Drosera/DebuggerDocument.cpp:
3044         * Drosera/DebuggerDocument.h:
3045         * Drosera/mac/DebuggerDocumentPlatform.mm:
3046         (NSStringCreateWithJSStringRef):
3047         (JSValueRefCreateWithNSString):
3048         * Drosera/win/DebuggerClient.cpp:
3049         (DebuggerClient::stepInto):
3050         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3051
3052 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
3053
3054         Reviewed by Tim.
3055
3056         - Moved isPaused into the JS for efficiency and simplicity.
3057
3058         * Drosera/DebuggerDocument.cpp:
3059         (DebuggerDocument::DebuggerDocument):
3060         (DebuggerDocument::pauseCallback):
3061         (DebuggerDocument::resumeCallback):
3062         (DebuggerDocument::isPaused):
3063         (DebuggerDocument::staticFunctions):
3064         * Drosera/DebuggerDocument.h:
3065         * Drosera/console.js:
3066         * Drosera/debugger.js:
3067         * Drosera/mac/DebuggerClient.mm:
3068         (-[DebuggerClient validateUserInterfaceItem:]):
3069
3070 2007-09-13  Sam Weinig  <sam@webkit.org>
3071
3072         Rubber stamped by Darin.
3073
3074         Make DumpRenderTree more cross platform ready.
3075         - Convert GCController to use the JSCore API instead of the WebScriptObject.
3076         - Use CF types instead of NS objects.
3077         - General cleanup.
3078
3079         * DumpRenderTree/DumpRenderTree.h:
3080         * DumpRenderTree/DumpRenderTree.mm:
3081         (dumpRenderTree):
3082         (dump):
3083         (runTest):
3084         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3085         * DumpRenderTree/EditingDelegate.m:
3086         * DumpRenderTree/FrameLoadDelegate.h:
3087         * DumpRenderTree/FrameLoadDelegate.mm:
3088         (-[FrameLoadDelegate init]):
3089         (-[FrameLoadDelegate dealloc]):
3090         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3091         * DumpRenderTree/GCController.cpp: Added.
3092         (GCController::GCController):
3093         (GCController::~GCController):
3094         (collectCallback):
3095         (collectOnAlternateThreadCallback):
3096         (getJSObjectCountCallback):
3097         (GCController::makeWindowObject):
3098         (GCController::getJSClass):
3099         (GCController::staticFunctions):
3100         * DumpRenderTree/GCController.h:
3101         * DumpRenderTree/GCController.mm:
3102         (GCController::collect):
3103         (GCController::collectOnAlternateThread):
3104         (GCController::getJSObjectCount):
3105         * DumpRenderTree/LayoutTestController.cpp:
3106         (LayoutTestController::makeWindowObject):
3107         (LayoutTestController::getJSClass):
3108         * DumpRenderTree/LayoutTestController.h:
3109         * DumpRenderTree/LayoutTestControllerMac.mm:
3110         (LayoutTestController::addDisallowedURL):
3111         (waitUntilDoneWatchdogFired):
3112         (LayoutTestController::waitUntilDone):
3113         * DumpRenderTree/ResourceLoadDelegate.m:
3114         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3115
3116 2007-09-12  Sam Weinig  <sam@webkit.org>
3117
3118         Reviewed by Stephanie.
3119
3120         Fix leaks in mac DumpRenderTree.
3121
3122         * DumpRenderTree/FrameLoadDelegate.mm:
3123         (-[FrameLoadDelegate init]): Initalize in the correct order.
3124         (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
3125         * DumpRenderTree/LayoutTestController.cpp:
3126         (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released.
3127         (encodeHostNameCallback): ditto.
3128         * DumpRenderTree/LayoutTestController.h:
3129         * DumpRenderTree/LayoutTestControllerMac.mm:
3130         (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule.
3131         (LayoutTestController::copyEncodedHostName): ditto
3132         (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.
3133
3134 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3135
3136         Reviewed by Geof.
3137
3138         - Updated Leopard leak list to include a leak which appears to be fixed in 9A549 but not the version the bot is on.  This will allow us to get the bot green, but later we should remove it.
3139
3140         * Scripts/run-webkit-tests:
3141
3142 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3143
3144         Reviewed by Darin.
3145
3146         - Simplified code paths and extracted out functions to increase encapsulation.
3147
3148         * Drosera/DebuggerDocument.cpp:
3149         (DebuggerDocument::breakpointEditorHTMLCallback):
3150         (DebuggerDocument::isPausedCallback):
3151         (DebuggerDocument::pauseCallback):
3152         (DebuggerDocument::resumeCallback):
3153         (DebuggerDocument::stepIntoCallback):
3154         (DebuggerDocument::evaluateScriptCallback):
3155         (DebuggerDocument::currentFunctionStackCallback):
3156         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3157         (DebuggerDocument::valueForScopeVariableNamedCallback):
3158         (DebuggerDocument::logCallback):
3159         * Drosera/DebuggerDocument.h:
3160         (DebuggerDocument::getPaused):
3161         * Drosera/mac/DebuggerClient.mm:
3162         (-[DebuggerClient pause:]):
3163         (-[DebuggerClient resume:]):
3164         (-[DebuggerClient stepInto:]):
3165         (-[DebuggerClient stepOver:]):
3166         (-[DebuggerClient stepOut:]):
3167         (-[DebuggerClient showConsole:]):
3168         (-[DebuggerClient closeCurrentFile:]):
3169         (-[DebuggerClient validateUserInterfaceItem:]):
3170         * Drosera/mac/DebuggerDocumentPlatform.mm: Added.
3171         (+[NSString stringOrNilFromWebScriptResult:]):
3172         (DebuggerDocument::platformPause):
3173         (DebuggerDocument::platformResume):
3174         (DebuggerDocument::platformStepInto):
3175         (DebuggerDocument::platformEvaluateScript):
3176         (DebuggerDocument::getPlatformCurrentFunctionStack):
3177         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3178         (DebuggerDocument::platformValueForScopeVariableNamed):
3179         (DebuggerDocument::platformLog):
3180         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3181
3182 2007-09-12  Sam Weinig  <sam@webkit.org>
3183
3184         Build fix for Buildbot.
3185
3186         * DumpRenderTree/DumpRenderTree.mm:
3187         (dump):
3188
3189 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3190
3191         Reviewed by Geoff.
3192
3193         - Updated the leaks list for leopard to help identify regressions.
3194
3195         * Scripts/run-webkit-tests:
3196
3197 2007-09-12  Sam Weinig  <sam@webkit.org>
3198
3199         Rubber stamped by Darin.
3200
3201         Convert the LayoutTestController to use the JSCore API instead of WebScriptObject.
3202
3203         * DumpRenderTree/DumpRenderTree.h: Re-order variables.
3204         * DumpRenderTree/DumpRenderTree.m: Removed.
3205         * DumpRenderTree/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.m.
3206         (stopJavaScriptThreads): Fix initialization.
3207         (setDefaultColorProfileToRGB): Add explicit cast from void*.
3208         (dumpRenderTree): Ditto.
3209         (runTest):
3210         Used the WorkQueue from the windows DRT instead of the old NSMutableArray one.
3211
3212         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3213         * DumpRenderTree/FrameLoadDelegate.h: Add LayoutTestController instance variable.
3214         * DumpRenderTree/FrameLoadDelegate.m: Removed.
3215         * DumpRenderTree/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.m.
3216         (-[FrameLoadDelegate init]):
3217         (-[FrameLoadDelegate dealloc]):
3218         (-[FrameLoadDelegate processWork:]):
3219         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3220         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3221         Convert to use the new JSCore based LayoutTestController and the new WorkQueue.
3222
3223         * DumpRenderTree/LayoutTestController.cpp: Added.
3224         (LayoutTestController::LayoutTestController):
3225         (LayoutTestController::~LayoutTestController):
3226         (dumpAsTextCallback):
3227         (dumpBackForwardListCallback):
3228         (dumpChildFramesAsTextCallback):
3229         (dumpChildFrameScrollPositionsCallback):
3230         (dumpDOMAsWebArchiveCallback):
3231         (dumpEditingCallbacksCallback):
3232         (dumpFrameLoadCallbacksCallback):
3233         (dumpResourceLoadCallbacksCallback):
3234         (dumpSelectionRectCallback):
3235         (dumpSourceAsWebArchiveCallback):
3236         (dumpTitleChangesCallback):
3237         (repaintSweepHorizontallyCallback):
3238         (setCallCloseOnWebViewsCallback):
3239         (setCanOpenWindowsCallback):
3240         (setCloseRemainingWindowsWhenCompleteCallback):
3241         (testRepaintCallback):
3242         (addFileToPasteboardOnDragCallback):
3243         (addDisallowedURLCallback):
3244         (clearBackForwardListCallback):
3245         (decodeHostNameCallback):
3246         (displayCallback):
3247         (encodeHostNameCallback):
3248         (keepWebHistoryCallback):
3249         (notifyDoneCallback):
3250         (queueBackNavigationCallback):
3251         (queueForwardNavigationCallback):
3252         (queueLoadCallback):
3253         (queueReloadCallback):
3254         (queueScriptCallback):
3255         (setAcceptsEditingCallback):
3256         (setCustomPolicyDelegateCallback):
3257         (setMainFrameIsFirstResponderCallback):
3258         (setTabKeyCyclesThroughElementsCallback):
3259         (setUseDashboardCompatibilityModeCallback):
3260         (setUserStyleSheetEnabledCallback):
3261         (setUserStyleSheetLocationCallback):
3262         (setWindowIsKeyCallback):
3263         (waitUntilDoneCallback):
3264         (windowCountCallback):
3265         (LayoutTestController::makeWindowObject):
3266         (LayoutTestController::getLayoutTestControllerJSClass):
3267         (LayoutTestController::staticFunctions):
3268         * DumpRenderTree/LayoutTestController.h: Replaced.
3269         * DumpRenderTree/LayoutTestController.m: Removed.
3270         * DumpRenderTree/LayoutTestControllerMac.mm: Added.
3271         (LayoutTestController::dumpAsText):
3272         (LayoutTestController::dumpBackForwardList):
3273         (LayoutTestController::dumpChildFramesAsText):
3274         (LayoutTestController::dumpChildFrameScrollPositions):
3275         (LayoutTestController::dumpDOMAsWebArchive):
3276         (LayoutTestController::dumpEditingCallbacks):
3277         (LayoutTestController::dumpFrameLoadCallbacks):
3278         (LayoutTestController::dumpResourceLoadCallbacks):
3279         (LayoutTestController::dumpSelectionRect):
3280         (LayoutTestController::dumpSourceAsWebArchive):
3281         (LayoutTestController::dumpTitleChanges):
3282         (LayoutTestController::repaintSweepHorizontally):
3283         (LayoutTestController::setCallCloseOnWebViews):
3284         (LayoutTestController::setCanOpenWindows):
3285         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3286         (LayoutTestController::testRepaint):
3287         (LayoutTestController::addFileToPasteboardOnDrag):
3288         (LayoutTestController::addDisallowedURL):
3289         (LayoutTestController::clearBackForwardList):
3290         (LayoutTestController::decodeHostName):
3291         (LayoutTestController::encodeHostName):
3292         (LayoutTestController::display):
3293         (LayoutTestController::keepWebHistory):
3294         (LayoutTestController::notifyDone):
3295         (LayoutTestController::queueBackNavigation):
3296         (LayoutTestController::queueForwardNavigation):
3297         (LayoutTestController::queueLoad):
3298         (LayoutTestController::queueReload):
3299         (LayoutTestController::queueScript):
3300         (LayoutTestController::setAcceptsEditing):
3301         (LayoutTestController::setCustomPolicyDelegate):
3302         (LayoutTestController::setMainFrameIsFirstResponder):
3303         (LayoutTestController::setTabKeyCyclesThroughElements):
3304         (LayoutTestController::setUseDashboardCompatibilityMode):
3305         (LayoutTestController::setUserStyleSheetEnabled):
3306         (LayoutTestController::setUserStyleSheetLocation):
3307         (LayoutTestController::setWindowIsKey):
3308         (+[WaitToDumpWatchdog waitUntilDoneWatchdogFired]):
3309         (LayoutTestController::waitUntilDone):
3310         (LayoutTestController::windowCount):
3311         Use the JSCore API to implement the LayoutTestController.
3312
3313         * DumpRenderTree/ObjCController.h:
3314         * DumpRenderTree/ObjCController.m:
3315         (+[ObjCController isSelectorExcludedFromWebScript:]):
3316         (+[ObjCController webScriptNameForSelector:]):
3317         (-[ObjCController accessStoredWebScriptObject]):
3318         (-[ObjCController storeWebScriptObject:]):
3319         (-[ObjCController dealloc]):
3320         (-[ObjCController invokeUndefinedMethodFromWebScript:withArguments:]):
3321         Move WebScriptObject tests to ObjCController.
3322
3323         * DumpRenderTree/UIDelegate.m: Removed.
3324         * DumpRenderTree/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.m.
3325
3326         * DumpRenderTree/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
3327         * DumpRenderTree/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
3328         * DumpRenderTree/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
3329         (WorkQueueItem::~WorkQueueItem):
3330         (LoadItem::LoadItem):
3331         (LoadItem::url):
3332         (LoadItem::target):
3333         (ScriptItem::ScriptItem):
3334         (ScriptItem::script):
3335         * DumpRenderTree/WorkQueueItemMac.mm: Added.
3336         (LoadItem::invoke):
3337         (ReloadItem::invoke):
3338         (ScriptItem::invoke):
3339         (BackForwardItem::invoke):
3340         Copy WorkQueue and WorkQueueItem from windows DRT. Changed the WorkQueueItem to use JSStringRefs instead of wstrings
3341         to avoid conversion until the last possible moment.  These changes will be merged with the windows DRT when we start
3342         sharing code.
3343
3344 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
3345
3346         Reviewed by Maciej.
3347
3348         - Updated Win side to take advantage of the platform separating changes.
3349
3350         * Drosera/DebuggerDocument.cpp:
3351         (DebuggerDocument::localScopeVariableNamesForCallFrame):
3352         * Drosera/DebuggerDocument.h:
3353         * Drosera/win/DebuggerClient.cpp:
3354         (DebuggerClient::pause):
3355         (DebuggerClient::resume):
3356         (DebuggerClient::stepInto):
3357         (DebuggerDocument::platformPause):
3358         (DebuggerDocument::platformResume):
3359         (DebuggerDocument::platformStepInto):
3360         (DebuggerDocument::platformEvaluateScript):
3361         (DebuggerDocument::getPlatformCurrentFunctionStack):
3362         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3363         (DebuggerDocument::platformValueForScopeVariableNamed):
3364         (DebuggerDocument::platformLog):
3365         * Drosera/win/DebuggerClient.h:
3366         * Drosera/win/Drosera.cpp:
3367         (Drosera::Drosera):
3368         (Drosera::windowScriptObjectAvailable):
3369         (Drosera::initWithServerName):
3370         (Drosera::switchToServerNamed):
3371         * Drosera/win/Drosera.h:
3372         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3373
3374 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
3375
3376         Reviewed by Adam.
3377
3378         - Just doing the moves in a separate patch so the changes are easier to see.
3379
3380         * Drosera/win/DebuggerClient.cpp: Copied from Drosera/win/DebuggerDocumentWin.cpp.
3381         * Drosera/win/DebuggerClient.h: Copied from Drosera/win/DebuggerDocumentWin.h.
3382         * Drosera/win/DebuggerDocumentWin.cpp: Removed.
3383         * Drosera/win/DebuggerDocumentWin.h: Removed.
3384         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3385
3386 2007-09-11  Sven Herzberg  <sven@imendio.com>
3387
3388         Don't overwrite LD_LIBRARY_PATH, prepend to it. Fixes:
3389         http://bugs.webkit.org/show_bug.cgi?id=15176
3390
3391         * Scripts/run-launcher: don't replace LD_LIBRARY_PATH with
3392         $projectDir, but prepend $projectDir to LD_LIBRARY_PATH (to preserve
3393         other paths eg. from jhbuild)
3394
3395 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
3396
3397         Reviewed by Adam.
3398
3399         - Made an order-of-deletion mistake.
3400
3401         * Drosera/DebuggerDocument.h:
3402         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
3403         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
3404         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
3405         * Drosera/mac/DebuggerClient.mm:
3406         (DebuggerDocument::platformPause):
3407         (DebuggerDocument::platformResume):
3408         (DebuggerDocument::platformStepInto):
3409         (DebuggerDocument::platformEvaluateScript):
3410         (DebuggerDocument::getPlatformCurrentFunctionStack):
3411         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3412         (DebuggerDocument::platformValueForScopeVariableNamed):
3413         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3414
3415 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
3416
3417         Reviewed by Darin.
3418
3419         - Renaming DebuggerDocument[platform] to DebuggerClient to be more clear.
3420
3421         * Drosera/DebuggerDocument.cpp:
3422         (DebuggerDocument::DebuggerDocument):
3423         * Drosera/DebuggerDocument.h:
3424         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
3425         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
3426         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
3427         * Drosera/mac/DebuggerApplication.mm:
3428         (-[DebuggerApplication attach:]):
3429         * Drosera/mac/DebuggerClient.h: Copied from Drosera/mac/DebuggerDocumentMac.h.
3430         * Drosera/mac/DebuggerClient.mm: Copied from Drosera/mac/DebuggerDocumentMac.mm.
3431         (DebuggerDocument::platformPause):
3432         (DebuggerDocument::platformResume):
3433         (DebuggerDocument::platformStepInto):
3434         (DebuggerDocument::platformEvaluateScript):
3435         (DebuggerDocument::getPlatformCurrentFunctionStack):
3436         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3437         (DebuggerDocument::platformValueForScopeVariableNamed):
3438         (DebuggerDocument::platformLog):
3439         * Drosera/mac/DebuggerDocumentMac.h: Removed.
3440         * Drosera/mac/DebuggerDocumentMac.mm: Removed.
3441         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3442
3443 2007-09-09  Sam Weinig  <sam@webkit.org>
3444
3445         Reviewed by Mark Rowe.
3446
3447         Remove 'objC' prefix from methods now in the ObjCController.
3448
3449         * DumpRenderTree/ObjCController.m:
3450         (+[ObjCController isSelectorExcludedFromWebScript:]):
3451         (+[ObjCController webScriptNameForSelector:]):
3452         (-[ObjCController classNameOf:]):
3453         (-[ObjCController objectOfClass:]):
3454         (-[ObjCController identityIsEqual::]):
3455         (-[ObjCController longLongRoundTrip:]):
3456         (-[ObjCController unsignedLongLongRoundTrip:]):
3457
3458 2007-09-09  Sam Weinig  <sam@webkit.org>
3459
3460         Reviewed by Oliver.
3461
3462         Initial refactor of DumpRenderTree in preparation of making it more platform independent.
3463         - Move LayoutTestController into its own file.
3464         - Move Objective-C only functions on LayoutTestController into a new controller called the
3465           ObjCController.
3466
3467         * DumpRenderTree/DumpRenderTree.h:
3468         * DumpRenderTree/DumpRenderTree.m:
3469         (displayWebView):
3470         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3471         * DumpRenderTree/FrameLoadDelegate.m:
3472         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3473         * DumpRenderTree/LayoutTestController.h: Added.
3474         * DumpRenderTree/LayoutTestController.m: Added.
3475         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
3476         (+[LayoutTestController webScriptNameForSelector:]):
3477         (-[LayoutTestController clearBackForwardList]):
3478         (-[LayoutTestController setUseDashboardCompatibilityMode:]):
3479         (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]):
3480         (-[LayoutTestController setCustomPolicyDelegate:]):
3481         (-[LayoutTestController keepWebHistory]):
3482         (-[LayoutTestController setCallCloseOnWebViews:]):
3483         (-[LayoutTestController setCanOpenWindows]):
3484         (-[LayoutTestController waitUntilDone]):
3485         (-[LayoutTestController waitUntilDoneWatchdogFired]):
3486         (-[LayoutTestController notifyDone]):
3487         (-[LayoutTestController dumpAsText]):
3488         (-[LayoutTestController addFileToPasteboardOnDrag]):
3489         (-[LayoutTestController addDisallowedURL:]):
3490         (-[LayoutTestController setUserStyleSheetLocation:]):
3491         (-[LayoutTestController setUserStyleSheetEnabled:]):
3492         (-[LayoutTestController dumpDOMAsWebArchive]):
3493         (-[LayoutTestController dumpSourceAsWebArchive]):
3494         (-[LayoutTestController dumpSelectionRect]):
3495         (-[LayoutTestController dumpTitleChanges]):
3496         (-[LayoutTestController dumpBackForwardList]):
3497         (-[LayoutTestController windowCount]):
3498         (-[LayoutTestController dumpChildFrameScrollPositions]):
3499         (-[LayoutTestController dumpChildFramesAsText]):
3500         (-[LayoutTestController dumpEditingCallbacks]):
3501         (-[LayoutTestController dumpResourceLoadCallbacks]):
3502         (-[LayoutTestController dumpFrameLoadCallbacks]):
3503         (-[LayoutTestController setWindowIsKey:]):
3504         (-[LayoutTestController setMainFrameIsFirstResponder:]):
3505         (-[LayoutTestController display]):
3506         (-[LayoutTestController testRepaint]):
3507         (-[LayoutTestController repaintSweepHorizontally]):
3508         (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]):
3509         (-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]):
3510         (-[LayoutTestController _doLoad:target:]):
3511         (-[LayoutTestController _doBackOrForwardNavigation:]):
3512         (-[LayoutTestController queueBackNavigation:]):
3513         (-[LayoutTestController queueForwardNavigation:]):
3514         (-[LayoutTestController queueReload]):
3515         (-[LayoutTestController queueScript:]):
3516         (-[LayoutTestController queueLoad:target:]):
3517         (-[LayoutTestController setAcceptsEditing:]):
3518         (-[LayoutTestController setTabKeyCyclesThroughElements:]):
3519         (-[LayoutTestController storeWebScriptObject:]):
3520         (-[LayoutTestController accessStoredWebScriptObject]):
3521         (-[LayoutTestController dealloc]):
3522         (-[LayoutTestController decodeHostName:]):
3523         (-[LayoutTestController encodeHostName:]):
3524         * DumpRenderTree/ObjCController.h: Added.
3525         * DumpRenderTree/ObjCController.m: Added.
3526         (+[ObjCController isSelectorExcludedFromWebScript:]):
3527         (+[ObjCController webScriptNameForSelector:]):
3528         (-[ObjCController objCClassNameOf:]):
3529         (-[ObjCController objCObjectOfClass:]):
3530         (-[ObjCController objCIdentityIsEqual::]):
3531         (-[ObjCController objCLongLongRoundTrip:]):
3532         (-[ObjCController objCUnsignedLongLongRoundTrip:]):
3533         (-[ObjCController testWrapperRoundTripping:]):
3534
3535 2007-09-07  Sam Weinig  <sam@webkit.org>
3536
3537         Reviewed by Alice.
3538
3539         Strip trailing and leading space/newline characters from skiplist file names.
3540
3541         * Scripts/run-webkit-tests:
3542
3543 2007-09-06  Kevin McCullough  <kmccullough@apple.com>
3544
3545         Reviewed by Maciej.
3546
3547         - Changed Drosera to take advantage of the JSRetainPtr changes.
3548
3549         * Drosera/DebuggerDocument.cpp:
3550         (DebuggerDocument::breakpointEditorHTML):
3551         (DebuggerDocument::evaluateScript):
3552         (DebuggerDocument::valueForScopeVariableNamed):
3553         (DebuggerDocument::log):
3554         (DebuggerDocument::windowScriptObjectAvailable):
3555         (DebuggerDocument::toJSArray):
3556         (DebuggerDocument::callFunctionOnObject):
3557         (DebuggerDocument::logException):
3558         * Drosera/mac/DebuggerDocumentMac.mm:
3559         (-[DebuggerClientMac webView:didLoadMainResourceForDataSource:]):
3560         (-[DebuggerClientMac webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3561         (DebuggerDocument::platformEvaluateScript):
3562         (DebuggerDocument::getPlatformCurrentFunctionStack):
3563         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3564         (DebuggerDocument::platformValueForScopeVariableNamed):
3565
3566 2007-09-05  Kevin McCullough  <kmccullough@apple.com>
3567
3568         Reviewed by Adam, Sam, Darin.
3569
3570         - Separated what is platform dependant from what is not.  Creating the structure needed for Drosera for Win.
3571
3572         * Drosera/Debugger.h: Added.
3573         * Drosera/DebuggerDocument.cpp:
3574         (DebuggerDocument::breakpointEditorHTMLCallback):
3575         (DebuggerDocument::isPausedCallback):
3576         (DebuggerDocument::pauseCallback):
3577         (DebuggerDocument::resumeCallback):
3578         (DebuggerDocument::stepIntoCallback):
3579         (DebuggerDocument::evaluateScriptCallback):
3580         (DebuggerDocument::currentFunctionStackCallback):
3581         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3582         (DebuggerDocument::valueForScopeVariableNamedCallback):
3583         (DebuggerDocument::logCallback):
3584         (DebuggerDocument::breakpointEditorHTML):
3585         (DebuggerDocument::isPaused):
3586         (DebuggerDocument::pause):
3587         (DebuggerDocument::resume):
3588         (DebuggerDocument::stepInto):
3589         (DebuggerDocument::evaluateScript):
3590         (DebuggerDocument::currentFunctionStack):
3591         (DebuggerDocument::localScopeVariableNamesForCallFrame):
3592         (DebuggerDocument::valueForScopeVariableNamed):
3593         (DebuggerDocument::log):
3594         (DebuggerDocument::toolbarPause):
3595         (DebuggerDocument::toolbarResume):
3596         (DebuggerDocument::toolbarStepInto):
3597         (DebuggerDocument::toolbarStepOver):
3598         (DebuggerDocument::toolbarStepOut):
3599         (DebuggerDocument::toolbarShowConsole):
3600         (DebuggerDocument::toolbarCloseCurrentFile):
3601         (DebuggerDocument::updateFileSource):
3602         (DebuggerDocument::didParseScript):
3603         (DebuggerDocument::willExecuteStatement):
3604         (DebuggerDocument::didEnterCallFrame):
3605         (DebuggerDocument::willLeaveCallFrame):
3606         (DebuggerDocument::exceptionWasRaised):
3607         (DebuggerDocument::windowScriptObjectAvailable):
3608         (DebuggerDocument::toJSArray):
3609         (DebuggerDocument::callGlobalFunction):
3610         (DebuggerDocument::callFunctionOnObject):
3611         (DebuggerDocument::getDroseraJSClass):
3612         (DebuggerDocument::staticFunctions):
3613         (DebuggerDocument::logException):
3614         * Drosera/DebuggerDocument.h:
3615         (DebuggerDocument::DebuggerDocument):
3616         * Drosera/ForwardingHeaders: Added.
3617         * Drosera/ForwardingHeaders/wtf: Added.
3618         * Drosera/ForwardingHeaders/wtf/Platform.h: Added.
3619         * Drosera/config.h:
3620         * Drosera/console.html:
3621         * Drosera/console.js:
3622         * Drosera/debugger.js:
3623         * Drosera/mac/DebuggerApplication.mm:
3624         (-[DebuggerApplication attach:]):
3625         * Drosera/mac/DebuggerDocumentMac.h:
3626         * Drosera/mac/DebuggerDocumentMac.mm:
3627         (+[NSString stringOrNilFromWebScriptResult:]):
3628         (+[DebuggerClientMac log:]):
3629         (-[DebuggerClientMac initWithServerName:]):
3630         (-[DebuggerClientMac dealloc]):
3631         (-[DebuggerClientMac pause]):
3632         (-[DebuggerClientMac resume]):
3633         (-[DebuggerClientMac pause:]):
3634         (-[DebuggerClientMac resume:]):
3635         (-[DebuggerClientMac stepInto:]):
3636         (-[DebuggerClientMac stepOver:]):
3637         (-[DebuggerClientMac stepOut:]):
3638         (-[DebuggerClientMac showConsole:]):
3639         (-[DebuggerClientMac closeCurrentFile:]):
3640         (-[DebuggerClientMac validateUserInterfaceItem:]):
3641         (-[DebuggerClientMac webView:windowScriptObjectAvailable:]):
3642         (-[DebuggerClientMac webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3643         (-[DebuggerClientMac webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3644         (-[DebuggerClientMac webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3645         (-[DebuggerClientMac webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3646         (DebuggerDocument::platformPause):
3647         (DebuggerDocument::platformResume):
3648         (DebuggerDocument::platformStepInto):
3649         (DebuggerDocument::platformEvaluateScript):
3650         (DebuggerDocument::platformCurrentFunctionStack):
3651         (DebuggerDocument::platformLocalScopeVariableNamesForCallFrame):
3652         (DebuggerDocument::platformValueForScopeVariableNamed):
3653         (DebuggerDocument::platformLog):
3654         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3655
3656 2007-09-06  Sam Weinig  <sam@webkit.org>
3657
3658         Reviewed by Adam Roben.
3659
3660         Register the WebKit DLL on initialization of the DumpRenderTree.
3661
3662         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3663         (initialize):
3664
3665 2007-09-05  Sam Weinig  <sam@webkit.org>
3666
3667         Reviewed by Oliver.
3668
3669         Fix many layout test failures caused by r25364.
3670         Set text size to standand size at the begining of each test matching the mac.
3671
3672         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3673         (runTest):
3674
3675 2007-09-04  Sam Weinig  <sam@webkit.org>
3676
3677         Reviewed by Adam.
3678
3679         Fix for <rdar://problem/5382277>
3680         Implement eventSender.textZoomIn and eventSender.textZoomOut for windows DRT.
3681
3682         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp:
3683         (textZoomInCallback):
3684         (textZoomOutCallback):
3685
3686 2007-08-29  David Kilzer  <ddkilzer@apple.com>
3687
3688         Reviewed by Adam.
3689
3690         Added case-insensitivity to checks for adding regression tests.
3691
3692         * Scripts/prepare-ChangeLog:
3693         (generateFileList):
3694
3695 2007-08-28  David Kilzer  <ddkilzer@apple.com>
3696
3697         Reviewed by Maciej.
3698
3699         Ignore files in /resources/ subdirectories when creating a list of added tests.
3700
3701         * Scripts/prepare-ChangeLog:
3702         (generateFileList):
3703
3704 2007-08-27  Kevin McCullough  <kmccullough@apple.com>
3705
3706         Reviewed by John.
3707
3708         - Removed Leopard leaks list since all of those radars were fixed.
3709
3710         * Scripts/run-webkit-tests:
3711
3712 2007-08-27  Adam Roben  <aroben@apple.com>
3713
3714         Rubberstamped by Mark.
3715
3716         * Scripts/pdevenv: Pass arguments along to devenv.com.
3717
3718 2007-08-26  David Kilzer  <ddkilzer@webkit.org>
3719
3720         Reviewed by Mark Rowe.
3721
3722         Update prepare-ChangeLog to generate the datestamp in the correct timezone.
3723
3724         * Scripts/prepare-ChangeLog:
3725         (changeLogDate): Added.
3726
3727 2007-08-24  Sam Weinig  <sam@webkit.org>
3728
3729         Revert r25216 which renamed the COM DOM bindings to use Deprecated prefix.
3730
3731 2007-08-24  Sam Weinig  <sam@webkit.org>
3732
3733         Rubber-stamped by Adam Roben.
3734
3735         <rdar://problem/5434593> Deprecate current manually written COM DOM bindings in anticipation of autogeneration
3736
3737         Rename COM DOM bindings to use Deprecated prefix.
3738
3739         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3740         (dumpFramesAsText):
3741         (dump):
3742         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp:
3743         (dumpPath):
3744         (dump):
3745         (EditingDelegate::shouldBeginEditingInDOMRange):
3746         (EditingDelegate::shouldEndEditingInDOMRange):
3747         (EditingDelegate::shouldInsertNode):
3748         (EditingDelegate::shouldInsertText):
3749         (EditingDelegate::shouldDeleteDOMRange):
3750         (EditingDelegate::shouldChangeSelectedDOMRange):
3751         (EditingDelegate::shouldApplyStyle):
3752         (EditingDelegate::shouldChangeTypingStyle):
3753         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h:
3754
3755 2007-08-24  Oliver Hunt  <oliver@apple.com>
3756
3757         Reviewed by John H.
3758
3759         WebDataSource::response can legitimately have a null response, so we
3760         must check that case.
3761
3762         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
3763         (queueLoadCallback):
3764
3765 2007-08-23  Mitz Pettel  <mitz@webkit.org>
3766
3767         Reviewed by Darin and Adam.
3768
3769         - DumpRenderTree changes to allow testing for
3770           http://bugs.webkit.org/show_bug.cgi?id=11756
3771           REGRESSION: link targeting a frame in another window does not work
3772           <rdar://problem/5286420>
3773
3774         Use a frame group name for all WebViews created by DumpRenderTree to
3775         allow testing of cross-page frame lookup.
3776
3777         * DumpRenderTree/DumpRenderTree.m:
3778         (createWebView): Pass group name to -[WebView initWithFrame:frameName:groupName:].
3779         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3780         (main): Pass group name to WebView::initWithFrame(RECT, BSTR, BSTR).
3781
3782 2007-08-23  David Kilzer  <ddkilzer@webkit.org>
3783
3784         Reviewed by Adam.
3785
3786         Quote the $sslCertificate path in case it contains a space.
3787
3788         * Scripts/run-webkit-httpd:
3789         * Scripts/run-webkit-tests:
3790
3791 2007-08-22  Oliver Hunt  <oliver@apple.com>
3792
3793         Reviewed by John and Adam.
3794
3795         WebDataSource::response can legitimately have a null response, so we
3796         must check that case.
3797
3798         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3799         (dump):
3800
3801 2007-08-21  Kevin McCullough  <kmccullough@apple.com>
3802
3803         Reviewed by Geof.
3804
3805         - Changing the usage to be more clear.
3806
3807         * Scripts/run-testkjs:
3808
3809 2007-08-20  John Sullivan  <sullivan@apple.com>
3810
3811         Reviewed by Adam Roben
3812
3813         * DumpRenderTree/DumpRenderTree.m:
3814         (runTest):
3815         call new +[WebView _setUsesTestModeFocusRingColor:YES] so we get the same focus ring colors
3816         in layout tests on Tiger and Leopard
3817
3818 2007-08-20  Adam Roben  <aroben@apple.com>
3819
3820         Put LayoutTests after all other ChangeLogs in commit logs
3821
3822         We use "~" to sort LayoutTests after all the other ChangeLogs because
3823         "~" is the last ASCII character (other than "DEL").
3824
3825         Reviewed by Sam.
3826
3827         * Scripts/commit-log-editor:
3828
3829 2007-08-20  Adam Roben  <aroben@apple.com>
3830
3831         Detect that DRT crashed even if a crash dialog is running
3832
3833         On Windows, when DRT crashes a crash dialog commonly appears. The DRT
3834         process is still running at this point, so run-webkit-tests wouldn't
3835         detect that DRT had crashed. We now record the crash in our SIGPIPE
3836         handler so that we know if DRT crashed even if the crash dialog is up.
3837
3838         Reviewed by Sam.
3839
3840         * Scripts/run-webkit-tests:
3841         (sub catch_pipe): Set the crashed bit.
3842         (sub openDumpTool): Reset the crashed bit.
3843         (sub dumpToolDidCrash): Check the crashed bit.
3844
3845 2007-08-20  Adam Roben  <aroben@apple.com>
3846
3847         Fix Bug 15026: prepare-ChangeLog should list new tests in WebCore/ChangeLog
3848
3849         http://bugs.webkit.org/show_bug.cgi?id=15026
3850
3851         Reviewed by David Kilzer and Darin Adler.
3852
3853         * Scripts/prepare-ChangeLog:
3854         (sub isModifiedStatus): Split out from isModifiedOrAddedStatus.
3855         (sub isAddedStatus): Ditto.
3856         (sub testListForChangeLog): Added.
3857
3858 2007-08-19  Oleg Sukhodolsky  <son.two@gmail.com>
3859
3860         Reviewed by Mark.
3861
3862         -fixes http://bugs.webkit.org/show_bug.cgi?id=14632
3863
3864         * Scripts/webkitdirs.pm:
3865         qt and gtk ports now explicitly pass debug (or release) mode to qmake.
3866
3867 2007-08-17  Darin Adler  <darin@apple.com>
3868
3869         Reviewed by Oliver Hunt.
3870
3871         - don't look for Apple-style localizable strings in the GTK version of WebKit
3872
3873         * Scripts/extract-localizable-strings: Add a feature where you can pass in the
3874         name of subdirectories to skip.
3875         * Scripts/update-webkit-localizable-strings: Pass WebKit/gtk as a subdirectory
3876         to skip.
3877
3878 2007-08-17  Anders Carlsson  <andersca@apple.com>
3879
3880         Build fix.
3881
3882         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3883         (NPP_SetWindow):
3884
3885 2007-08-17  Anders Carlsson  <andersca@apple.com>
3886
3887         Reviewed by Dave Hyatt.
3888
3889         <rdar://problem/5379040>
3890         REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes
3891
3892         Add a way for the plug-in to dump the width and height when it gets its  NPP_SetWindow call.
3893
3894         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
3895         (pluginAllocate):
3896         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3897         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3898         (NPP_New):
3899         (NPP_SetWindow):
3900
3901 2007-08-16  Alice Liu  <alice.liu@apple.com>
3902
3903         Reviewed by Maciej.
3904
3905         Fix <rdar://problem/5360135> REGRESSION (Leopard only): editing/selection/5354455-1.html is causing subsequent tests to fail
3906
3907         * DumpRenderTree/DumpRenderTree.m:
3908         (createWebView):
3909         Create a DumpRenderTreeWindow instead of a NSWindow, now that a DumpRenderTreeWindow no longer poses as a NSWindow.
3910         (dumpRenderTree):
3911         Don't pose as a NSWindow, since when the spelling panel gets created, it creates an NSWindow which ends up creating a DumpRenderTreeWindow.
3912
3913 2007-08-16  Kevin McCullough  <kmccullough@apple.com>
3914
3915         Reviewed by Adam.
3916
3917         - Added tests for regressions in other components.  In this case we also need to add a skipped list for Tiger since this functionality didn't exist in 10.4.
3918
3919         * Scripts/run-webkit-tests:
3920
3921 2007-08-15  Timothy Hatcher  <timothy@apple.com>
3922
3923         Look for the new Xcode 3 preference key (PBXApplicationwideBuildSettings) for the global build locations.
3924         The value of PBXApplicationwideBuildSettings is a dictionary, so we have to pull the SYMROOT out of it.
3925
3926         Also pass xcodebuild OBJROOT with the same value as SYMROOT if we fallback to the default WebKitBuild,
3927         this prevents making "build" directories in each project folder.
3928
3929         * Scripts/webkitdirs.pm:
3930
3931 2007-08-14  Geoffrey Garen  <ggaren@apple.com>
3932
3933         Reviewed by Kevin Mccullough.
3934
3935         Removed special case that didn't belong. (It would allow a global
3936         initializer to sneak into production builds, which would cause a
3937         system-wide performance regression on Mac OS X.)
3938
3939         * Scripts/check-for-global-initializers:
3940
3941 2007-08-14  Justin Garcia  <justin.garcia@apple.com>
3942
3943         Reviewed by Tim.
3944
3945         <rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element
3946
3947         * DumpRenderTree/EditingDelegate.m:
3948         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Added, return YES
3949         only for elements with the class needsDeletionUI.
3950
3951 2007-08-14  David Kilzer  <ddkilzer@webkit.org>
3952
3953         Reviewed by Darin.
3954
3955         - fix http://bugs.webkit.org/show_bug.cgi?id=14965
3956           svn-create-patch uses deprecated tail switch
3957
3958         * Scripts/svn-create-patch: Use 'tail -n +3' instead of 'tail +3'.
3959
3960 2007-08-13  Sam Weinig  <sam@webkit.org>
3961
3962         Reviewed by Adam Roben.
3963
3964         Use the cygwin specific Apache config file under cygwin.
3965
3966         * Scripts/run-webkit-httpd:
3967
3968 2007-08-12  Adam Roben  <aroben@apple.com>
3969
3970         Generate results for new tests in a more logical location
3971
3972         New platform-specific tests always have their results generated right
3973         next to the test. New cross-platform tests will have their results
3974         generated a) in the cross-platform directory, if they are text-only,
3975         or b) in the least-specific platform directory, if they are render
3976         tree dumps.
3977
3978         Reviewed by Lars.
3979
3980         * Scripts/run-webkit-tests:
3981
3982 2007-08-12  Adam Roben  <aroben@apple.com>
3983
3984         Print the actual directory where new results are generated.
3985
3986         Before, we were printing an unpredictable, context-specific substring
3987         of the directory.
3988
3989         Reviewed by Lars.
3990
3991         * Scripts/run-webkit-tests:
3992
3993 2007-08-12  Adam Roben  <aroben@apple.com>
3994
3995         Factor some common code into a stripExtension() subroutine.
3996
3997         Reviewed by Lars.
3998
3999         * Scripts/run-webkit-tests: Also removed some debugging output.
4000
4001 2007-08-11  Matt Lilek  <pewtermoose@gmail.com>
4002
4003         Reviewed over and over and over by Adam Roben.
4004
4005         Bug 14740: Hierarchical layout tests and platform organization
4006         http://bugs.webkit.org/show_bug.cgi?id=14740
4007
4008         Add support for platform-specific layout tests and results.
4009
4010         * Scripts/run-webkit-tests:
4011
4012 2007-08-11  David Kilzer  <ddkilzer@webkit.org>
4013
4014         Reviewed by Adam.
4015
4016         Refactored svn-create-path to use a hash-of-hashes data structure to keep
4017         track of changed files.  In the top level hash, keys are paths to files and
4018         values are 'fileData' hashes with the following keys and values:
4019
4020         - isBinary: boolean value (set to true for non-text files like images, etc.)
4021         - isTestFile: boolean value (set to true if file exists within a known test
4022           directory)
4023         - modificationType: string equal to one of 'addition', 'additionWithHistory',
4024           'modification' or 'deletion'
4025         - path: string equal to the path to the file (this may seem redundant, but it
4026           is required to use the second-level 'fileData' hash independent of the
4027           top-level hash)
4028         - sourceFile: [optional] string equal to the path of the original file that was
4029           copied or moved
4030         - sourceRevision: [optional] string equal to the revision of the original file
4031           that was copied or moved
4032
4033         * Scripts/svn-create-patch: Moved call to GetOptions() to its own statement
4034         that saves the return value in $result, then checks it before printing help.
4035         Combined sourceFiles, %testFiles, and %binaryFiles into single %diffFiles hash
4036         and eliminated two for() loops.
4037         (binarycmp): Added.  Used with sort() to order non-binary files before binary
4038         files.
4039         (findBaseUrl): Added.  Extracted from findSourceFileAndRevision().
4040         (findMimeType): Added optional second argument that takes a revision number.
4041         (generateDiff): Updated to take one fileData argument instead of three ($file,
4042         $modificationType, $isBinary).
4043         (generateFileList): Updated to take one hash ref argument (%diffFiles)
4044         instead of three (%sourceFiles, %testFiles, %binaryFiles).  Populates
4045         %diffFiles using paths for keys and fileData hashes for values.
4046         (manufacturePatchForAdditionWithHistory): Updated to take one fileData
4047         argument.
4048         (pathcmp): Updated to take two fileData arguments instead of two strings.
4049         (testfilecmp): Added.  Used with sort() to order non-test files before test
4050         files.
4051
4052 2007-08-11  Darin Adler  <darin@apple.com>
4053
4054         * Scripts/run-webkit-tests: Give a different message when only the pixel test failed.
4055
4056 2007-08-06  Nigel Tao  <nigeltao@gnome.org>
4057
4058         Reviewed by David Kilzer.
4059
4060         Fix bug 14745: WebKitTools/Scripts/run-launcher doesn't speak --gdk
4061         http://bugs.webkit.org/show_bug.cgi?id=14745
4062
4063         * Scripts/run-launcher:
4064         Scrub the "--gdk" out of the command line args, if given, so that
4065         GdkLauncher doesn't try to interpret it as a URL.
4066
4067 2007-08-03  Adam Roben  <aroben@apple.com>
4068
4069         Catch SIGPIPE on Windows so that run-webkit-tests doesn't quit when DRT crashes
4070
4071         Reviewed by Sam.
4072
4073         * Scripts/run-webkit-tests: Also close ERROR when we finish running the tests.
4074
4075 2007-08-03  Sam Weinig  <sam@webkit.org>
4076
4077         Reviewed by Darin.
4078
4079         Recursively dump all frames as text using new
4080         layoutTestController.dumpChildFramesAsText() function.
4081
4082         * DumpRenderTree/DumpRenderTree.m:
4083         (dumpFramesAsText):
4084         (dump):
4085         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
4086         (-[LayoutTestController dumpChildFramesAsText]):
4087         (runTest):
4088         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
4089         (dumpFramesAsText):
4090         (dump):
4091         (runTest):
4092         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h:
4093         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
4094         (dumpChildFramesAsTextCallback):
4095         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4096
4097 2007-08-02  Adam Roben  <aroben@apple.com>
4098
4099         Fix fast/dom/Window/alert-undefined.html
4100
4101         Reviewed by Sam.
4102
4103         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
4104         (WaitUntilDoneDelegate::runJavaScriptAlertPanelWithMessage): Don't let
4105         Windows translate a null BSTR into "(null)"
4106
4107 2007-08-02  Kevin McCullough  <kmccullough@apple.com>
4108
4109         Reviewed by Tim.
4110
4111         - It would help if I actually called the right function.
4112
4113         * Drosera/DebuggerDocument.cpp:
4114         (DebuggerDocument::showConsole):
4115
4116 2007-08-02  Adam Roben  <aroben@apple.com>
4117
4118         Don't delete the stderr file right after creating it
4119
4120         * Scripts/run-webkit-tests:
4121
4122 2007-08-01  Adam Roben  <aroben@apple.com>
4123
4124         When DRT crashes, record stderr and restart DRT
4125
4126         This prevents a DRT crash from causing the next few hundred tests to
4127         "fail" because DRT is no longer running.
4128
4129         I also changed the terminology that run-webkit-tests uses in its
4130         output a bit, so that crashing tests are referred to as "crashes"
4131         instead of "failures".
4132
4133         Reviewed by Mark.
4134
4135         * Scripts/run-webkit-tests: Detect a crash and record it as a tool
4136         failure.
4137         (sub openDumpTool): Use open3 so that we can access stderr.
4138         (sub dumpToolCrashed): Added.
4139         (sub printFailureMessageForTest): Added.
4140         (sub htmlForExpectedAndActualResults): Added.
4141         (sub deleteExpectedAndActualResults): Added.
4142         (sub recordActualResultsAndDiff): Added.
4143
4144 2007-07-30  Darin Adler  <darin@apple.com>
4145
4146         Reviewed by Tim Hatcher.
4147
4148         * DumpRenderTree/DumpRenderTree.m: (dump): Fix dumping for documents that include null
4149         characters. This turned out not to be needed for the test case that motivated me to
4150         do it, but it's nice to have this for the future.
4151
4152 2007-07-30  Simon Hausmann  <hausmann@kde.org>
4153
4154         Reviewed by Lars.
4155
4156         Link QtLauncher into $$OUTPUT_DIR/bin
4157
4158         * Scripts/run-launcher:
4159
4160 2007-07-27  David Kilzer  <ddkilzer@apple.com>
4161
4162         Reviewed by Geoff and Darin.
4163
4164         Use a subroutine for validating the --skipped switch.
4165
4166         * Scripts/run-webkit-tests:
4167
4168 2007-07-27  Darin Adler  <darin@apple.com>
4169
4170         Reviewed by Sam.
4171
4172         * Scripts/run-webkit-tests: Remove exception for leaks bug that has been fixed on Leopard.
4173
4174 2007-07-27  Holger Hans Peter Freyther  <zecke@selfish.org>
4175
4176         Reviewed by Mark.
4177
4178         Correct the path of GdkLauncher and make checkFrameworks work on OSX
4179         when building the Qt or Gtk+ port.
4180
4181         * GdkLauncher/GdkLauncher.pro: Don't create an app bundle on OSX
4182         * Sc