7f86d7845ef20f34743c3a6cb886ea6cebf3f8fd
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-26  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         [bzt] Kill WebKitLandingScripts
6         https://bugs.webkit.org/show_bug.cgi?id=31904
7
8         Step 2: Kill ensure_builders_are_green.
9
10         * Scripts/modules/buildsteps.py:
11         * Scripts/modules/commands/download.py:
12         * Scripts/modules/landingsequence.py:
13         * Scripts/modules/webkitlandingscripts.py:
14
15 2009-11-26  Adam Barth  <abarth@webkit.org>
16
17         Reviewed by Eric Seidel.
18
19         [bzt] Kill WebKitLandingScripts
20         https://bugs.webkit.org/show_bug.cgi?id=31904
21
22         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
23
24         * Scripts/bugzilla-tool:
25         * Scripts/modules/buildsteps.py: Added.
26         * Scripts/modules/commands/download.py:
27         * Scripts/modules/landingsequence.py:
28         * Scripts/modules/webkitlandingscripts.py:
29
30 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
31
32         Reviewed by Adam Barth.
33
34         Remove directory prefixes from linux commands
35
36         SCM unittests can cause errors on some systems if we use absolute reference to
37         the commands, so directory prefixes have been removed.
38
39         * Scripts/modules/scm_unittest.py:
40
41 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
42
43         Reviewed by Kenneth Rohde Christiansen.
44
45         Link DumpRenderTree to the Qt Ui Tools
46         https://bugs.webkit.org/show_bug.cgi?id=31203
47
48         Implement QWebPage::createPlugin using the Qt Ui Tools
49         to be able to create classes like QProgressBar from within
50         the <object></object> tags This is required for the
51         new automatic test of Qt Plugins.
52
53         * DumpRenderTree/qt/DumpRenderTree.cpp:
54         (WebCore::WebPage::createPlugin):
55         * DumpRenderTree/qt/DumpRenderTree.h:
56         * DumpRenderTree/qt/DumpRenderTree.pro:
57
58 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
59
60         Reviewed by Eric Seidel.
61
62         Update pywebsocket to 0.4.2
63
64         Update pywebsocket to 0.4.2
65         https://bugs.webkit.org/show_bug.cgi?id=31861
66
67         * pywebsocket/example/echo_client.py:
68         * pywebsocket/example/echo_wsh.py:
69         * pywebsocket/mod_pywebsocket/__init__.py:
70         * pywebsocket/mod_pywebsocket/dispatch.py:
71         * pywebsocket/mod_pywebsocket/msgutil.py:
72         * pywebsocket/mod_pywebsocket/standalone.py:
73         * pywebsocket/setup.py:
74         * pywebsocket/test/test_dispatch.py:
75         * pywebsocket/test/test_msgutil.py:
76
77 2009-11-25  Adam Barth  <abarth@webkit.org>
78
79         Reviewed by Eric Seidel.
80
81         Add unit test for mark-fixed
82         https://bugs.webkit.org/show_bug.cgi?id=31896
83
84         * Scripts/modules/commands/commandtest.py: Added.
85         * Scripts/modules/commands/queries_unittest.py:
86         * Scripts/modules/commands/upload_unittest.py: Added.
87         * Scripts/modules/mock_bugzillatool.py:
88         * Scripts/run-webkit-unittests:
89
90 2009-11-25  Adam Barth  <abarth@webkit.org>
91
92         Reviewed by Eric Seidel.
93
94         bugzilla-tool should have a mark-fixed command
95         https://bugs.webkit.org/show_bug.cgi?id=31853
96
97         Pretty simple stuff.
98
99         * Scripts/modules/commands/upload.py:
100
101 2009-11-25  Eric Seidel  <eric@webkit.org>
102
103         Reviewed by Adam Barth.
104
105         'bugzilla-tool help' should only show common commands like how 'git help' does
106         https://bugs.webkit.org/show_bug.cgi?id=31772
107
108         I also took this opportunity to make 'help' a real Command.
109         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
110
111         * Scripts/bugzilla-tool:
112          - change should_show_command_help to should_show_in_main_help
113         * Scripts/modules/commands/download.py:
114          - Mark commands as being shown in main help or not.
115          - show_in_main_help = False is not required (default is false),
116            but it seemed to make the commands more self-documenting.
117         * Scripts/modules/commands/queries.py: ditto
118         * Scripts/modules/commands/queues.py: ditto
119         * Scripts/modules/commands/upload.py: ditto
120         * Scripts/modules/multicommandtool.py:
121          - Make Command hold a pointer to tool in self.tool.  Most Command
122            subclasses do not take advantage of this yet, but it was required
123            for HelpCommand to be able to reach the tool from _help_epilog().
124          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
125          - Move MultiCommandTool._help_epilog to Command._help_epilog
126          - Move "help" logic into HelpCommand.execute()
127          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
128         * Scripts/modules/multicommandtool_unittest.py:
129          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
130
131 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
132
133         Reviewed by Dan Bernstein.
134         
135         Patch by Mark Rowe.
136
137         The buildbots are failing on Windows because when they were upgraded
138         to 4.0.4, Apple Application Support was not in their path. Add it to
139         the path to fix the buildots.
140
141         * Scripts/webkitdirs.pm:
142
143 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
144
145         Reviewed by David Kilzer.
146
147         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
148         https://bugs.webkit.org/show_bug.cgi?id=31799
149
150         * Scripts/run-webkit-tests: Fixed.
151
152 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
153
154         Reviewed by Eric Seidel.
155
156         Change run_command to give back stderr by default
157         https://bugs.webkit.org/show_bug.cgi?id=31734
158
159         Change run_command to give back stderr by default.
160         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
161         Change the related unittest call.
162
163         * Scripts/modules/scm.py:
164         * Scripts/modules/scm_unittest.py:
165
166 2009-11-25  Eric Seidel  <eric@webkit.org>
167
168         Reviewed by Adam Barth.
169
170         Centralize required argument parsing in Command
171         https://bugs.webkit.org/show_bug.cgi?id=31872
172
173         * Scripts/modules/commands/download.py: remove custom required arg message.
174         * Scripts/modules/commands/upload.py: ditto.
175         * Scripts/modules/multicommandtool.py:
176          - Add _parse_required_arguments.
177          - Pass program name off to OptionParser.
178          - Add name() for access to tool name.
179          - Add check_arguments_and_execute and make it return a return code.
180          - Replace a couple uses of + with %.
181         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
182
183 2009-11-25  Eric Seidel  <eric@webkit.org>
184
185         Reviewed by Adam Barth.
186
187         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
188         https://bugs.webkit.org/show_bug.cgi?id=31870
189
190         * Scripts/modules/commands/queries_unittest.py: Use the new class.
191         * Scripts/modules/multicommandtool_unittest.py: Ditto.
192         * Scripts/modules/outputcapture.py: Added.
193
194 2009-11-24  Dmitry Titov  <dimich@chromium.org>
195
196         Reviewed by Eric Seidel.
197
198         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
199         https://bugs.webkit.org/show_bug.cgi?id=31444
200
201         * Scripts/build-webkit:
202
203 2009-11-24  Chris Marrin  <cmarrin@apple.com>
204
205         Reviewed by Simon Fraser.
206
207         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
208         https://bugs.webkit.org/show_bug.cgi?id=27314
209         
210         Now the script allows the directories with these tests to be included on all
211         platforms but Mac, where they behave the same as always. For all other platforms
212         the tests need to be excluded using the Skipped files, which is currently done
213         for all platforms (including win since we're not turned on yet)
214
215         * Scripts/webkitdirs.pm:
216
217 2009-11-24  Eric Seidel  <eric@webkit.org>
218
219         Reviewed by Adam Barth.
220
221         queries_unittest.py should test command output
222         https://bugs.webkit.org/show_bug.cgi?id=31845
223
224         * Scripts/modules/commands/queries_unittest.py:
225          - Capture stdout and stderr and compare with expected strings.
226
227 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
228
229         No Review.
230
231         Fix spelling error ("depenedencies").
232
233         * Scripts/build-webkit:
234
235 2009-11-24  Mark Rowe  <mrowe@apple.com>
236
237         Land the configuration that includes the two debug GTK Linux builders.
238
239         * BuildSlaveSupport/build.webkit.org-config/config.json:
240
241 2009-11-24  David Kilzer  <ddkilzer@apple.com>
242
243         <http://webkit.org/b/31840> bisect-builds broke after r50080
244
245         Reviewed by Dan Bernstein.
246
247         * Scripts/bisect-builds:
248         (mountAndRunNightly): Switched back to using backticks to run
249         the hdiutil command since exec() will terminate the existing
250         script, which is not what we want.  Store the output of
251         File::Spec->devnull() in a variable for use in the hdiutil
252         detach commands.
253
254 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
255
256         Reviewed by Kenneth Rohde Christiansen.
257
258         Include "config.h" to meet Coding Style Guidelines
259         https://bugs.webkit.org/show_bug.cgi?id=31792
260
261         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
262         * DumpRenderTree/qt/jsobjects.cpp:
263         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
264
265 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
266
267         Reviewed by Oliver Hunt.
268
269         Implement new required function to pass test we used to pass. This
270         change is required since r51294.
271
272         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
273         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
274
275 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
276
277         Reviewed by Kenneth Rohde Christiansen.
278
279         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
280         https://bugs.webkit.org/show_bug.cgi?id=31775
281
282         LayoutTestController::dumpBackForwardList() should work with local URLs
283         as well as with normal URLs (in http tests for instance).
284         Currently it does not output the latter properly.
285
286         Unskip a bunch of passing http/navigation tests.
287
288         * DumpRenderTree/qt/DumpRenderTree.cpp:
289         (WebCore::dumpHistoryItem):
290
291 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
292
293         Reviewed by Oliver Hunt.
294
295         ARIA: support aria-flowto
296         https://bugs.webkit.org/show_bug.cgi?id=31762
297
298         * DumpRenderTree/AccessibilityUIElement.cpp:
299         (ariaFlowToElementAtIndexCallback):
300         (AccessibilityUIElement::getJSClass):
301         * DumpRenderTree/AccessibilityUIElement.h:
302         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
303         (AccessibilityUIElement::ariaFlowToElementAtIndex):
304         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
305         (AccessibilityUIElement::ariaFlowToElementAtIndex):
306         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
307         (AccessibilityUIElement::ariaFlowToElementAtIndex):
308
309 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
310
311         Reviewed by Kenneth Christiansen.
312
313         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
314         https://bugs.webkit.org/show_bug.cgi?id=31638
315
316         Unfreeze WorkQueue after each test execution.
317
318         * DumpRenderTree/qt/DumpRenderTree.cpp:
319         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
320
321 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
322
323         Reviewed by Adam Barth.
324
325         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
326         for localhost and 127.0.0.1.
327         https://bugs.webkit.org/show_bug.cgi?id=31783
328
329         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
330
331         * DumpRenderTree/qt/DumpRenderTree.cpp:
332         (WebCore::NetworkAccessManager::NetworkAccessManager):
333         (WebCore::NetworkAccessManager::sslErrorsEncountered):
334         (WebCore::WebPage::WebPage):
335         * DumpRenderTree/qt/DumpRenderTree.h:
336
337 2009-11-22  Chris Evans  <cevans@chromium.org>
338
339         Reviewed by Adam Barth.
340
341         Disable access to file:/// directory listings
342         https://bugs.webkit.org/show_bug.cgi?id=31329
343
344         Implemented setAllowUniversalAccessFromFileURLs to support testing of
345         file URL security.
346
347         * DumpRenderTree/LayoutTestController.cpp:
348         (setAllowUniversalAccessFromFileURLsCallback):
349         (LayoutTestController::staticFunctions):
350         * DumpRenderTree/LayoutTestController.h:
351         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
352         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
353         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
354         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
355         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
356         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
357         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
358         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
359
360 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
361
362         Reviewed by Kenneth Rohde Christiansen.
363
364         [Qt] Fix the timeout of fast/frames/frame-navigation.html
365         https://bugs.webkit.org/show_bug.cgi?id=31638
366
367         The test is timeouting, because it uses the WorkQueue to load a document in one
368         of the child frames and once the loading is finished, the DRT does not dump the
369         tree. This is because it waits for the QWebFrame::loadFinished() signal from
370         the main frame, while it should connect to QWebPage::loadFinished().
371
372         * DumpRenderTree/qt/DumpRenderTree.cpp:
373         (WebCore::DumpRenderTree::DumpRenderTree):
374
375 2009-11-21  Eric Seidel  <eric@webkit.org>
376
377         Reviewed by Adam Barth.
378
379         bugzilla-tool --help spews way too much text
380         https://bugs.webkit.org/show_bug.cgi?id=31771
381
382         * Scripts/bugzilla-tool:
383          - Remove self.cached_scm initialization hack.
384         * Scripts/modules/buildbot.py:
385          - Make default_host accessible to callers.
386         * Scripts/modules/commands/download.py:
387          - Phrase help for all commands consistently and remove spurious help text punctuation.
388         * Scripts/modules/commands/queries.py: Ditto.
389         * Scripts/modules/commands/queues.py: Ditto.
390         * Scripts/modules/commands/upload.py: Ditto.
391         * Scripts/modules/multicommandtool.py:
392          - Add HelpPrintingOptionParser.format_epilog to replace
393            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
394            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
395          - Make --help only show a list of commands like "svn help" and "git help" do --
396            previously --help was listing all commands and options.
397          - Sort list of commands alphabetically.
398
399 2009-11-21  Eric Seidel  <eric@webkit.org>
400
401         No review.  Fixing a typo from the previous patch for bug 31767.
402
403         AbstractQueue.run_bugzilla_tool throws an exception
404         https://bugs.webkit.org/show_bug.cgi?id=31769
405
406         * Scripts/modules/commands/queues.py:
407
408 2009-11-21  Eric Seidel  <eric@webkit.org>
409
410         Reviewed by Adam Barth.
411
412         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
413         https://bugs.webkit.org/show_bug.cgi?id=31767
414
415         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
416         Since we don't have a good way to test BugzillaTool pieces, I've
417         left out a test for now.
418
419         * Scripts/bugzilla-tool:
420          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
421         * Scripts/modules/commands/queues.py:
422          - Use tool.path() instead of __file__.
423         * Scripts/modules/multicommandtool.py:
424          - Add a new path() method to MultiComandTool.
425         * Scripts/modules/multicommandtool_unittest.py:
426          - Provide a path() method.  Little point in testing this mock implementation.
427
428 2009-11-21  Adam Barth  <abarth@webkit.org>
429
430         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
431         WebKitTools.
432
433         * Scripts/modules/commands/download.py:
434
435 2009-11-21  Adam Barth  <abarth@webkit.org>
436
437         Reviewed by Eric Seidel.
438
439         Convert check-style to use LandingSequence
440         https://bugs.webkit.org/show_bug.cgi?id=31763
441
442         Instead of manipulating the working copy by hand, we should use the
443         LandingSequence in CheckStyle.  This will make this code eaiser to
444         test.
445
446         * Scripts/modules/commands/download.py:
447
448 2009-11-20  Adam Barth  <abarth@webkit.org>
449
450         Reviewed by Eric Seidel.
451
452         Unit test query commands
453         https://bugs.webkit.org/show_bug.cgi?id=31755
454
455         These tests are pretty rough, but hopefully they'll grow.
456
457         * Scripts/modules/commands/queries_unittest.py: Added.
458         * Scripts/modules/mock_bugzillatool.py: Added.
459         * Scripts/run-webkit-unittests:
460
461 2009-11-20  Eric Seidel  <eric@webkit.org>
462
463         Reviewed by Adam Barth.
464
465         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
466         https://bugs.webkit.org/show_bug.cgi?id=31758
467
468         * Scripts/modules/multicommandtool.py:
469          - Allow passing of explicit commands to MultiCommandTool.__init__
470         * Scripts/modules/multicommandtool_unittest.py:
471          - Use new Command.name naming system.
472          - Test Command auto-discovery.
473         * Scripts/modules/workqueue.py:
474          - bug_id no longer exists, use patch['bug_id'] instead.
475         * Scripts/modules/workqueue_unittest.py:
476          - WorkQueues require names now.
477          - should_proceed_with_work_item must return a patch object.
478
479 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
480
481         Reviewed by Beth Dakin.
482
483         WAI-ARIA: add support for aria-owns
484         https://bugs.webkit.org/show_bug.cgi?id=31702
485
486         * DumpRenderTree/AccessibilityUIElement.cpp:
487         (ariaOwnsElementAtIndexCallback):
488         (AccessibilityUIElement::getJSClass):
489         * DumpRenderTree/AccessibilityUIElement.h:
490         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
491         (AccessibilityUIElement::ariaOwnsElementAtIndex):
492         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
493         (AccessibilityUIElement::ariaOwnsElementAtIndex):
494         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
495         (AccessibilityUIElement::ariaOwnsElementAtIndex):
496
497 2009-11-20  Eric Seidel  <eric@webkit.org>
498
499         Reviewed by Adam Barth.
500
501         Fix exception thrown when running the commit-queue.
502
503         * Scripts/modules/statusbot.py: patch is optional.
504         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
505
506 2009-11-20  Eric Seidel  <eric@webkit.org>
507
508         Reviewed by Adam Barth.
509
510         Teach the StatusBot how to support more than just the commit-queue
511         https://bugs.webkit.org/show_bug.cgi?id=31754
512
513         * Scripts/modules/workqueue.py: Another typo.
514
515 2009-11-20  Eric Seidel  <eric@webkit.org>
516
517         Reviewed by Adam Barth.
518
519         Teach the StatusBot how to support more than just the commit-queue
520         https://bugs.webkit.org/show_bug.cgi?id=31754
521
522         * Scripts/modules/commands/queues.py: Fix silly typo.
523
524 2009-11-20  Eric Seidel  <eric@webkit.org>
525
526         Reviewed by Adam Barth.
527
528         Teach the StatusBot how to support more than just the commit-queue
529         https://bugs.webkit.org/show_bug.cgi?id=31754
530
531         * CommitQueueStatus/index.yaml:
532          - Add indices required for the new queries.
533         * CommitQueueStatus/queue_status.py:
534          - Add a patch-status page and move update_status to update-status.
535          - Only display "commit-queue" status records for the commit-queue.
536          - Add support for a queue_name property on status records.
537          - Fix _int_from_request to actually work.
538         * CommitQueueStatus/update_status.html:
539          - Add support for a queue_name on status records.
540          - Remove unused list of bug ids.
541          * Scripts/modules/commands/queues.py
542           - Make the queues pass the patch instead of the bug_id to StatusBot.
543         * Scripts/modules/statusbot.py:
544          - Support passing the queue_name to the status updates.
545          - Support fetching patch status with patch_status().
546         * Scripts/modules/workqueue.py:
547          - Pass the patch to the StatusBot instead of the bug_id.
548          - Let WorkQueues have a name.
549
550 2009-11-20  Adam Barth  <abarth@webkit.org>
551
552         Reviewed by Eric Seidel.
553
554         Move bugzilla-tool commands into their own file
555         https://bugs.webkit.org/show_bug.cgi?id=31752
556
557         This will let us write unit tests.
558
559         * Scripts/bugzilla-tool:
560         * Scripts/modules/commands/__init__.py: Added.
561         * Scripts/modules/commands/download.py: Added.
562         * Scripts/modules/commands/queries.py: Added.
563         * Scripts/modules/commands/queues.py: Added.
564         * Scripts/modules/commands/upload.py: Added.
565         * Scripts/modules/grammar.py: Added.
566
567 2009-11-20  Adam Barth  <abarth@webkit.org>
568
569         Reviewed by Eric Seidel.
570
571         BuildQueue should check if the tree is currently buildable
572         https://bugs.webkit.org/show_bug.cgi?id=31744
573
574         * Scripts/bugzilla-tool:
575         * Scripts/modules/landingsequence.py:
576         * Scripts/modules/webkitlandingscripts.py:
577
578 2009-11-20  Adam Barth  <abarth@webkit.org>
579
580         Reviewed by Eric Seidel.
581
582         Move prepare_clean_working_directory into the LandingSequence
583         https://bugs.webkit.org/show_bug.cgi?id=31743
584
585         * Scripts/bugzilla-tool:
586         * Scripts/modules/landingsequence.py:
587
588 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
589
590         Reviewed by Kenneth Rohde Christiansen.
591
592         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
593         https://bugs.webkit.org/show_bug.cgi?id=30460
594
595         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
596
597         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
598         (pluginInvoke):
599
600 2009-11-20  Adam Barth  <abarth@webkit.org>
601
602         Reviewed by Eric Seidel.
603
604         Pass the port information to the child process
605         https://bugs.webkit.org/show_bug.cgi?id=31736
606
607         We need to do this so the child process knows what to build!
608
609         * Scripts/bugzilla-tool:
610         * Scripts/modules/landingsequence.py:
611         * Scripts/modules/webkitport.py:
612         * Scripts/modules/webkitport_unittest.py:
613
614 2009-11-20  Adam Barth  <abarth@webkit.org>
615
616         Reviewed by Eric Seidel.
617
618         Support Qt port in build-queue
619         https://bugs.webkit.org/show_bug.cgi?id=31733
620
621         * Scripts/bugzilla-tool:
622
623 2009-11-20  Adam Barth  <abarth@webkit.org>
624
625         Reviewed by Eric Seidel.
626
627         Implement a build-queue
628         https://bugs.webkit.org/show_bug.cgi?id=31725
629
630         Currently this just builds the first 10 patches in the review queue.
631         We'll want to do something smarter soon.
632
633         * Scripts/bugzilla-tool:
634
635 2009-11-20  Adam Barth  <abarth@webkit.org>
636
637         Reviewed by Eric Seidel.
638
639         Make commit-queue and style-queue show up in help
640         https://bugs.webkit.org/show_bug.cgi?id=31724
641
642         We need to store their names on their class to make these commands
643         properly register themselves with MultiCommandTool.
644
645         * Scripts/bugzilla-tool:
646
647 2009-11-20  Adam Barth  <abarth@webkit.org>
648
649         Reviewed by Eric Seidel.
650
651         Implement bugzilla-tool build-attachment
652         https://bugs.webkit.org/show_bug.cgi?id=31722
653
654         This command builds an attachment from bugzilla.  It leaves the built
655         patch in the working copy.
656
657         * Scripts/bugzilla-tool:
658         * Scripts/modules/landingsequence.py:
659         * Scripts/modules/webkitlandingscripts.py:
660
661 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
662
663         Reviewed by Xan Lopez.
664
665         [GTK] DRT release event does not create the state correctly
666         https://bugs.webkit.org/show_bug.cgi?id=31717
667
668         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
669
670 2009-11-20  Eric Seidel  <eric@webkit.org>
671
672         Reviewed by Adam Barth.
673
674         MultiCommandTool should find Command objects automatically instead of with a manual list
675         https://bugs.webkit.org/show_bug.cgi?id=31710
676
677         * Scripts/bugzilla-tool:
678         * Scripts/modules/multicommandtool.py:
679          - Use some wild python-fu to crawl all the known subclasses of Command.
680
681 2009-11-20  Adam Barth  <abarth@webkit.org>
682
683         Unreviewed "build" fix.  Added missing import.
684
685         * Scripts/bugzilla-tool:
686
687 2009-11-20  Adam Barth  <abarth@webkit.org>
688
689         Unreviewed "build" fix.  I failed to update LandingSequence.test
690         properly.
691
692         * Scripts/modules/landingsequence.py:
693
694 2009-11-20  Adam Barth  <abarth@webkit.org>
695
696         Reviewed by Eric Seidel.
697
698         Create LandingSequence as the all-sing, all-dance landing class
699         https://bugs.webkit.org/show_bug.cgi?id=31709
700
701         Client can inherit from this class to carefully control exactly which
702         steps they wish to have happen in the landing sequence.
703
704         * Scripts/bugzilla-tool:
705         * Scripts/modules/landingsequence.py: Added.
706         * Scripts/modules/webkitlandingscripts.py: Added.
707
708 2009-11-19  Adam Barth  <abarth@webkit.org>
709
710         Reviewed by Eric Seidel.
711
712         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
713         https://bugs.webkit.org/show_bug.cgi?id=31707
714
715         This is to help when we implement build-attachment.
716
717         * Scripts/bugzilla-tool:
718
719 2009-11-19  Adam Barth  <abarth@webkit.org>
720
721         Reviewed by Eric Seidel.
722
723         Support Qt port in bugzilla-tool
724         https://bugs.webkit.org/show_bug.cgi?id=31701
725
726         Now we support building with Qt!
727
728         * Scripts/bugzilla-tool:
729         * Scripts/modules/webkitport.py: Added.
730         * Scripts/modules/webkitport_unittest.py: Added.
731         * Scripts/run-webkit-unittests:
732
733 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
734
735         Reviewed by Adam Barth.
736
737         Remove inserting stderr into patch in bugzilla-tool
738         https://bugs.webkit.org/show_bug.cgi?id=29914
739
740         Modify SCM python module's run_command function to avoid return of stderr
741         by default, so stderr won't be inserted into the patches.
742         Modify the related unit test.
743
744         * Scripts/modules/scm.py:
745         * Scripts/modules/scm_unittest.py:
746
747 2009-11-19  Eric Seidel  <eric@webkit.org>
748
749         Reviewed by Adam Barth.
750
751         bugzilla-tool needs per-command help
752         https://bugs.webkit.org/show_bug.cgi?id=31697
753
754         Added support for "bugzilla-tool help command-name"
755         and a unit test to make sure it works.
756
757         * Scripts/modules/multicommandtool.py:
758         * Scripts/modules/multicommandtool_unittest.py:
759
760 2009-11-19  Eric Seidel  <eric@webkit.org>
761
762         Reviewed by Adam Barth.
763
764         Move MultiCommandTool and Command into a separate file and add some basic unit tests
765         https://bugs.webkit.org/show_bug.cgi?id=31695
766
767         * Scripts/bugzilla-tool:
768         * Scripts/modules/multicommandtool.py: Added.
769         * Scripts/modules/multicommandtool_unittest.py: Added.
770         * Scripts/run-webkit-unittests:
771
772 2009-11-19  Eric Seidel  <eric@webkit.org>
773
774         No review, just adding a FIXME.
775
776         Split out command parsing and help printing from BugzillaTool
777         https://bugs.webkit.org/show_bug.cgi?id=31688
778
779         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
780
781 2009-11-19  Eric Seidel  <eric@webkit.org>
782
783         Reviewed by Adam Barth.
784
785         Split out command parsing and help printing from BugzillaTool
786         https://bugs.webkit.org/show_bug.cgi?id=31688
787
788         * Scripts/bugzilla-tool:
789          - Add new MultiCommandTool class to contain option parsing and help printing logic.
790          - Rename private methods to use _ pattern.
791          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
792          - 
793
794 2009-11-19  Eric Seidel  <eric@webkit.org>
795
796         Reviewed by Adam Barth.
797
798         Re-factor help printing to use modern python idioms
799         https://bugs.webkit.org/show_bug.cgi?id=31685
800
801         * Scripts/bugzilla-tool:
802
803 2009-11-19  Eric Seidel  <eric@webkit.org>
804
805         Reviewed by Darin Adler.
806
807         commit-queue empty queue logs twice
808         https://bugs.webkit.org/show_bug.cgi?id=31679
809
810         * Scripts/bugzilla-tool:
811
812 2009-11-19  Eric Seidel  <eric@webkit.org>
813
814         Reviewed by Darin Adler.
815
816         bugzilla-tool's reviewer/committer rejection message should be clearer
817         https://bugs.webkit.org/show_bug.cgi?id=31126
818
819         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
820
821         * Scripts/modules/bugzilla.py:
822
823 2009-11-19  Eric Z. Ayers  <zundel@google.com>
824
825         Reviewed by Pavel Feldman.
826
827         Forces a WM_PAINT event on calling layoutTestController.display()
828         in order to enable the timeline-paint.html test on Windows.
829         ::UpdateWindow() does not force an event becaue the window is 
830         not visible.
831
832         https://bugs.webkit.org/show_bug.cgi?id=31402
833
834         * DumpRenderTree/win/DumpRenderTree.cpp:
835         (displayWebView):
836
837 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
838
839         No review needed.
840
841         Added myself to committers list.
842
843         * Scripts/modules/committers.py:
844
845 2009-11-19  Adam Barth  <abarth@webkit.org>
846
847         Reviewed by Eric Seidel.
848
849         Bugzilla-tool command classes should match command names
850         https://bugs.webkit.org/show_bug.cgi?id=31666
851
852         I renamed all the commands except CommitMessageForCurrentDiff because
853         the new name would conflict with an existing class.
854
855         * Scripts/bugzilla-tool:
856
857 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
858
859         Reviewed by Gustavo Noronha Silva.
860
861         Web Inspector: Implement "show inspector" in WebKit GTK
862         API and enable console tests.
863
864         https://bugs.webkit.org/show_bug.cgi?id=31669
865
866         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
867         (LayoutTestController::showWebInspector):
868
869 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
870
871         Reviewed by Simon Hausmann.
872
873         Minor refactoring + more documentation.
874
875         * DumpRenderTree/qt/DumpRenderTree.cpp:
876         (WebCore::clearHistory):
877         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
878
879 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
880
881         Reviewed by Eric Seidel.
882
883         Ignore websocket tests when --no-http is specified.
884         https://bugs.webkit.org/show_bug.cgi?id=31662
885
886         * Scripts/run-webkit-tests:
887
888 2009-11-18  Adam Barth  <abarth@webkit.org>
889
890         Reviewed by Eric Seidel.
891
892         Normalize ' and " in bugzilla-tool
893         https://bugs.webkit.org/show_bug.cgi?id=31655
894
895         We decided " is better than ' and we should be consistent.
896
897         * Scripts/bugzilla-tool:
898
899 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
900
901         Reviewed by Kenneth Rohde Christiansen.
902
903         [Qt] Remove support for Qt v4.3 or older versions
904         https://bugs.webkit.org/show_bug.cgi?id=29469
905
906         * DumpRenderTree/qt/DumpRenderTree.pro:
907         * DumpRenderTree/qt/ImageDiff.pro:
908
909 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
910
911         Reviewed by Eric Seidel.
912
913         GitTest.test_create_binary_patch fails if /tmp is symlink
914         https://bugs.webkit.org/show_bug.cgi?id=31536
915
916         * Scripts/modules/scm_unittest.py:
917
918 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
919
920         Reviewed by Darin Adler.
921
922         Configuration for Chromium Build Slaves.
923
924         https://bugs.webkit.org/show_bug.cgi?id=31442
925
926         * BuildSlaveSupport/build.webkit.org-config/config.json:
927         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
928
929 2009-11-18  Eric Seidel  <eric@webkit.org>
930
931         Reviewed by Darin Adler.
932
933         workqueue.py results in totally broken commit-queue UI
934         https://bugs.webkit.org/show_bug.cgi?id=31645
935
936         * Scripts/bugzilla-tool:
937          - Remove unneeded use of PatchCollection.
938          - Grab a new copy of the cq'd patches every run of the queue.
939
940 2009-11-18  Sam Weinig  <sam@webkit.org>
941
942         Reviewed by Anders Carlsson.
943
944         Make the Mac Geolocation API async.
945
946         Update DRT to use the new async Mac Geolocation API.
947
948         * DumpRenderTree/mac/UIDelegate.mm:
949         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
950
951 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
952
953         Reviewed by Kenneth Rohde Christiansen.
954
955         Add and option to toggle HTML5 datalist support to build-webkit
956         https://bugs.webkit.org/show_bug.cgi?id=31599
957
958         * Scripts/build-webkit:
959
960 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
961
962         Reviewed by Kevin Ollivier.
963
964         Enable wx plugin support using the Windows implementation as a base.
965         
966         https://bugs.webkit.org/show_bug.cgi?id=31636
967
968         * wx/build/settings.py:
969
970 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
971
972         Reviewed by Simon Hausmann.
973
974         Change the initialization order so that the controllers
975         will be created before exporting them to the JS DOM window.
976
977         * DumpRenderTree/qt/DumpRenderTree.cpp:
978         (WebCore::DumpRenderTree::DumpRenderTree):
979
980 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
981
982         Reviewed by Simon Hausmann.
983
984         Fix a code copy and paste error. m_page should be page.
985
986         * DumpRenderTree/qt/DumpRenderTree.cpp:
987         (WebCore::DumpRenderTree::createWindow):
988
989 2009-11-17  Mark Rowe  <mrowe@apple.com>
990
991         Reviewed by Alexey Proskuryakov.
992
993         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
994
995         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
996         This prevents symlinks from confusing the descendant check.
997
998 2009-11-17  Mark Rowe  <mrowe@apple.com>
999
1000         Reviewed by Alexey Proskuryakov.
1001
1002         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
1003
1004         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
1005         server to be up rather than having run-webkit-tests abort immediately.
1006
1007         * Scripts/run-webkit-tests:
1008
1009 2009-11-17  Eric Seidel  <eric@webkit.org>
1010
1011         Reviewed by Darin Adler.
1012
1013         commit-queue is failing to set reviewer in ChangeLogs
1014         https://bugs.webkit.org/show_bug.cgi?id=31592
1015
1016         * Scripts/bugzilla-tool: Clarify the "applying" log message.
1017         * Scripts/modules/bugzilla.py:
1018          - Add a new _validate_committer_and_reviewer function as a
1019            temporary solution until we can make a real Attachment object
1020            which knows how to fill in its committer/reviewer fields automatically.
1021
1022 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1023
1024         Unreviewed buildbot fix.
1025
1026         Revert part of earlier patch and add comment, as it
1027         was causing timeouts on the buildbot.
1028
1029         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1030         (LayoutTestController::notifyDone):
1031
1032 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1033
1034         Reviewed by Oliver Hunt.
1035
1036         Make the timeout 15 sec as for the other DRT's and make
1037         it print out the same output when a test timeout.
1038
1039         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1040         (LayoutTestController::waitUntilDone):
1041         (LayoutTestController::notifyDone):
1042         (LayoutTestController::timerEvent):
1043
1044 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
1045
1046         Reviewed by Timothy Hatcher.
1047
1048         Fixed typos in comments.
1049
1050         * Scripts/modules/committers.py:
1051
1052 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
1053
1054         Reviewed by Timothy Hatcher.
1055
1056         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1057         - Updated DRT to show/close inspector for all tests under /inspector
1058         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1059           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1060         - Removed reload on each inspector test
1061         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1062         inspector for those.
1063         - Reimplemented timeline tests in order to get rid of reload there.
1064         - Moved tests that don't require harness into the fast group.
1065
1066         https://bugs.webkit.org/show_bug.cgi?id=31472
1067
1068         * DumpRenderTree/LayoutTestController.cpp:
1069         (setTimelineProfilingEnabledCallback):
1070         (closeWebInspectorCallback):
1071         (LayoutTestController::staticFunctions):
1072         * DumpRenderTree/LayoutTestController.h:
1073         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1074         (shouldOpenWebInspector):
1075         (runTest):
1076         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1077         (LayoutTestController::setTimelineProfilingEnabled):
1078         * DumpRenderTree/mac/DumpRenderTree.mm:
1079         (shouldOpenWebInspector):
1080         (runTest):
1081         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1082         (LayoutTestController::setTimelineProfilingEnabled):
1083         * DumpRenderTree/win/DumpRenderTree.cpp:
1084         (shouldOpenWebInspector):
1085         (runTest):
1086         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1087         (LayoutTestController::setTimelineProfilingEnabled):
1088
1089 2009-11-17  Oliver Hunt  <oliver@apple.com>
1090
1091         Reviewed by Maciej Stachowiak.
1092
1093         Incorrect use of JavaScriptCore API in DumpRenderTree
1094         https://bugs.webkit.org/show_bug.cgi?id=31577
1095
1096         Return undefined rather than a literal null.
1097
1098         * DumpRenderTree/AccessibilityUIElement.cpp:
1099         (setSelectedTextRangeCallback):
1100         (incrementCallback):
1101         (decrementCallback):
1102         (showMenuCallback):
1103
1104 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1105
1106         Reviewed by Beth Dakin.
1107
1108         AX: aria-labelledby duplicates some of its WAI-ARIA label
1109         https://bugs.webkit.org/show_bug.cgi?id=31565
1110
1111         * DumpRenderTree/AccessibilityUIElement.cpp:
1112         (titleUIElementCallback):
1113         (getIsValidCallback):
1114         (AccessibilityUIElement::getJSClass):
1115
1116 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1117
1118         Reviewed by Simon Hausmann.
1119
1120         r50942 broke output from created windows. Make the
1121         m_enableTextOutput a member of the DRT and not the
1122         WebPage.
1123
1124         * DumpRenderTree/qt/DumpRenderTree.cpp:
1125         (WebCore::WebPage::WebPage):
1126         (WebCore::WebPage::javaScriptAlert):
1127         (WebCore::WebPage::javaScriptConsoleMessage):
1128         (WebCore::WebPage::javaScriptConfirm):
1129         (WebCore::WebPage::javaScriptPrompt):
1130         (WebCore::WebPage::acceptNavigationRequest):
1131         (WebCore::DumpRenderTree::DumpRenderTree):
1132         (WebCore::DumpRenderTree::open):
1133         (WebCore::DumpRenderTree::createWindow):
1134         * DumpRenderTree/qt/DumpRenderTree.h:
1135         (WebCore::DumpRenderTree::setTextOutputEnabled):
1136         (WebCore::DumpRenderTree::isTextOutputEnabled):
1137         (WebCore::WebPage::shouldInterruptJavaScript):
1138         (WebCore::WebPage::isTextOutputEnabled):
1139         (WebCore::WebPage::setViewGeometry):
1140
1141 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1142
1143         Reviewed by Gustavo Noronha Silva.
1144
1145         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
1146         as the implementation is being used by at least Qt and Gtk+.
1147
1148         Update buildsystems as well.
1149
1150         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1151         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1152         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1153         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1154         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1155         * GNUmakefile.am:
1156
1157 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
1158
1159         Reviewed by Alexey Proskuryakov.
1160
1161         Disable wss until all platforms support pyOpenSSL
1162
1163         https://bugs.webkit.org/show_bug.cgi?id=31479
1164
1165         * Scripts/run-webkit-tests:
1166
1167 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1168
1169         Reviewed by Kenneth Christiansen.
1170
1171         [Qt] Implement load error pages support for Qt's DRT.
1172         https://bugs.webkit.org/show_bug.cgi?id=31509
1173
1174         For now, it will not be a default feature, and layout tests
1175         that want to make use of this have to explicitily call
1176         'handleErrorPages();' for the test source.
1177
1178         Any of the other DumpRenderTree's (mac, win and gtk)
1179         support handling error pages. Qt's will be the first.
1180
1181         * DumpRenderTree/qt/DumpRenderTree.cpp:
1182         (WebCore::WebPage::supportsExtension):
1183         (WebCore::WebPage::extension):
1184         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1185         (LayoutTestController::reset):
1186         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1187         (LayoutTestController::shouldHandleErrorPages):
1188         (LayoutTestController::handleErrorPages):
1189
1190 2009-11-16  Eric Seidel  <eric@webkit.org>
1191
1192         Reviewed by Adam Barth.
1193
1194         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1195         https://bugs.webkit.org/show_bug.cgi?id=31549
1196
1197         Renamed --commit-queue to --non-interactive in most places
1198         and remove the code in land-patches which is no longer needed.
1199
1200         * Scripts/bugzilla-tool:
1201
1202 2009-11-16  Eric Seidel  <eric@webkit.org>
1203
1204         Reviewed by Adam Barth.
1205
1206         The commit-queue should use land-attachment
1207         https://bugs.webkit.org/show_bug.cgi?id=31548
1208
1209         * Scripts/bugzilla-tool:
1210
1211 2009-11-16  Adam Barth  <abarth@webkit.org>
1212
1213         Reviewed by Eric Seidel.
1214
1215         Convert CommitQueue over to PatchCollection
1216         https://bugs.webkit.org/show_bug.cgi?id=31547
1217
1218         Also fixes a bug in workqueue and adds a test!
1219
1220         * Scripts/bugzilla-tool:
1221         * Scripts/modules/workqueue.py:
1222         * Scripts/modules/workqueue_unittest.py:
1223
1224 2009-11-16  Adam Barth  <abarth@webkit.org>
1225
1226         Reviewed by Eric Seidel.
1227
1228         Move StyleQueue over to using PatchCollection
1229         https://bugs.webkit.org/show_bug.cgi?id=31544
1230
1231         That's what the class it's for.
1232
1233         * Scripts/bugzilla-tool:
1234         * Scripts/modules/patchcollection.py:
1235         * Scripts/modules/patchcollection_unittest.py:
1236
1237 2009-11-16  Eric Seidel  <eric@webkit.org>
1238
1239         Reviewed by Adam Barth.
1240
1241         bugzilla-tool needs a land-attachment command
1242         https://bugs.webkit.org/show_bug.cgi?id=31546
1243
1244         * Scripts/bugzilla-tool:
1245          - Move all the logic into AbstractLandingCommand and
1246            add a new LandAttachment command subclass.
1247          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1248
1249 2009-11-16  Eric Seidel  <eric@webkit.org>
1250
1251         Reviewed by Adam Barth.
1252
1253         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1254         https://bugs.webkit.org/show_bug.cgi?id=31543
1255
1256         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1257
1258         * Scripts/bugzilla-tool:
1259
1260 2009-11-16  Eric Seidel  <eric@webkit.org>
1261
1262         Reviewed by Adam Barth.
1263
1264         Disable the style queue from posting to the commit queue status page.
1265
1266         * Scripts/bugzilla-tool:
1267
1268 2009-11-16  Adam Barth  <abarth@webkit.org>
1269
1270         Reviewed by Eric Seidel.
1271
1272         Implement PatchCollection
1273         https://bugs.webkit.org/show_bug.cgi?id=31541
1274
1275         This class holds a set of patches and lets clients iterate through
1276         them.  Optionally, clients can install a filter.
1277
1278         * Scripts/modules/patchcollection.py: Added.
1279         * Scripts/modules/patchcollection_unittest.py: Added.
1280         * Scripts/run-webkit-unittests:
1281
1282 2009-11-16  Eric Seidel  <eric@webkit.org>
1283
1284         Reviewed by Adam Barth.
1285
1286         bugzilla-tool land-patches will close bugs with patches r=?
1287         https://bugs.webkit.org/show_bug.cgi?id=28230
1288
1289         The commit-queue shouldn't close patches with outstanding reviews on them,
1290         even if many reviewers seem to be against multi-patch bugs.
1291
1292         * Scripts/bugzilla-tool:
1293
1294 2009-11-16  Eric Seidel  <eric@webkit.org>
1295
1296         Reviewed by Adam Barth.
1297
1298         bugzilla-tool check-style should work with attachment ids instead of bug ids
1299         https://bugs.webkit.org/show_bug.cgi?id=31540
1300
1301         * Scripts/bugzilla-tool:
1302
1303 2009-11-16  Eric Seidel  <eric@webkit.org>
1304
1305         Reviewed by Adam Barth.
1306
1307         WorkQueue is the only place that should know about special exit codes
1308         https://bugs.webkit.org/show_bug.cgi?id=31534
1309
1310         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1311         and add tests for handling exit codes.
1312         I also cleaned up workqueue_unittest.py more.
1313
1314         * Scripts/bugzilla-tool:
1315         * Scripts/modules/workqueue.py:
1316         * Scripts/modules/workqueue_unittest.py:
1317
1318 2009-11-16  Eric Seidel  <eric@webkit.org>
1319
1320         Reviewed by Adam Barth.
1321
1322         Re-factor workqueue_unittest to allow for more than one test.
1323         https://bugs.webkit.org/show_bug.cgi?id=31535
1324
1325         * Scripts/modules/workqueue_unittest.py:
1326
1327 2009-11-16  Eric Seidel  <eric@webkit.org>
1328
1329         Reviewed by Adam Barth.
1330
1331         land-patches needs to be re-factored into smaller chunks
1332         https://bugs.webkit.org/show_bug.cgi?id=31532
1333
1334         * Scripts/bugzilla-tool: fix a couple obvious typos.
1335
1336 2009-11-16  Eric Seidel  <eric@webkit.org>
1337
1338         Reviewed by Adam Barth.
1339
1340         land-patches needs to be re-factored into smaller chunks
1341         https://bugs.webkit.org/show_bug.cgi?id=31532
1342
1343         The next patch will move these methods into WebKitLandingScripts.
1344
1345         * Scripts/bugzilla-tool:
1346          - Split out _land_patch and _close_bug_if_no_active_patches.
1347
1348 2009-11-16  Adam Barth  <abarth@webkit.org>
1349
1350         Reviewed by Eric Seidel.
1351
1352         Fix silly copy-and-paste code.  I am a terrible coder.
1353
1354         * Scripts/modules/bugzilla.py:
1355
1356 2009-11-16  Adam Barth  <abarth@webkit.org>
1357
1358         Reviewed by Eric Seidel.
1359
1360         Implement a StyleQueue
1361         https://bugs.webkit.org/show_bug.cgi?id=31537
1362
1363         The first iteration of the style queue only produces output locally.
1364         There is also a limit of 10 patches because it's not that useful to
1365         iterate through the entire review queue at this point.  We can remove
1366         the limit later.
1367
1368         * Scripts/bugzilla-tool:
1369         * Scripts/modules/bugzilla.py:
1370
1371 2009-11-16  Adam Barth  <abarth@webkit.org>
1372
1373         Reviewed by Eric Seidel.
1374
1375         Unit test WorkQueue
1376         https://bugs.webkit.org/show_bug.cgi?id=31531
1377
1378         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1379
1380         * Scripts/bugzilla-tool:
1381         * Scripts/modules/statusbot.py:
1382         * Scripts/modules/workqueue.py:
1383         * Scripts/modules/workqueue_unittest.py: Added.
1384         * Scripts/run-webkit-unittests:
1385
1386 2009-11-16  Eric Seidel  <eric@webkit.org>
1387
1388         Reviewed by Adam Barth.
1389
1390         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1391         https://bugs.webkit.org/show_bug.cgi?id=31530
1392
1393         * Scripts/bugzilla-tool:
1394
1395 2009-11-16  Eric Seidel  <eric@webkit.org>
1396
1397         Reviewed by Adam Barth.
1398
1399         bugzilla-tool needs apply-attachment
1400         https://bugs.webkit.org/show_bug.cgi?id=31528
1401
1402         * Scripts/bugzilla-tool:
1403          - Add ApplyAttachment command.
1404          - Abstract applying code into WebKitApplyingScripts.
1405          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1406         * Scripts/modules/bugzilla.py:
1407          - Add fetch_attachment and bug_id_for_attachment_id.
1408         * Scripts/modules/bugzilla_unittest.py:
1409          - Add test for new parsing.
1410          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1411
1412 2009-11-16  Eric Seidel  <eric@webkit.org>
1413
1414         Reviewed by Adam Barth.
1415
1416         Document check-style's use of force_clean.
1417
1418         * Scripts/bugzilla-tool:
1419         * Scripts/modules/scm.py:
1420
1421 2009-11-16  Adam Barth  <abarth@webkit.org>
1422
1423         Reviewed by Eric Seidel.
1424
1425         Move WorkQueue to its own file
1426         https://bugs.webkit.org/show_bug.cgi?id=31529
1427
1428         WorkQueue and WorkQueueDelegate are separate concerns from
1429         bugzilla-tool.  Also added a missing include to logging.py.
1430
1431         * Scripts/bugzilla-tool:
1432         * Scripts/modules/logging.py:
1433         * Scripts/modules/workqueue.py:
1434
1435 2009-11-16  Adam Barth  <abarth@webkit.org>
1436
1437         Reviewed by Eric Seidel.
1438
1439         Move OutputTee to logging.py.
1440
1441         * Scripts/bugzilla-tool:
1442         * Scripts/modules/logging.py:
1443
1444 2009-11-15  Adam Barth  <abarth@webkit.org>
1445
1446         Reviewed by Eric Seidel.
1447
1448         Refactor bugzilla-tool to allow for multiple queues
1449         https://bugs.webkit.org/show_bug.cgi?id=31513
1450
1451         Divide the commit queue class into three class to make creating
1452         additional queues easier.
1453
1454         * Scripts/bugzilla-tool:
1455
1456 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1457
1458         Reviewed by Eric Seidel.
1459
1460         svn-apply may not handle git patches created by bugzilla-tool
1461         https://bugs.webkit.org/show_bug.cgi?id=31457
1462
1463         * Scripts/modules/scm.py:
1464         * Scripts/modules/scm_unittest.py:
1465
1466 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1467
1468         Reviewed by Eric Seidel.
1469
1470         bugzilla-tool should post git binary diff
1471         https://bugs.webkit.org/show_bug.cgi?id=31458
1472
1473         Add --binary option to Git.create_patch.
1474
1475         * Scripts/modules/scm.py:
1476         * Scripts/modules/scm_unittest.py:
1477
1478 2009-11-15  Adam Barth  <abarth@webkit.org>
1479
1480         Reviewed by Darin Adler.
1481
1482         Add bugzilla-tool check-style
1483         https://bugs.webkit.org/show_bug.cgi?id=31515
1484
1485         * Scripts/bugzilla-tool:
1486         * Scripts/modules/bugzilla.py:
1487
1488 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1489
1490         Reviewed by Simon Hausmann.
1491
1492         Make the Qt Linux only --valgrind feature, suppress errors
1493         defined in the SuppressedValgrindErrors file.
1494
1495         * Scripts/run-webkit-tests:
1496
1497 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1498
1499         Reviewed by Simon Hausmann.
1500
1501         Set the locale to C and not to the current one in use on the system.
1502
1503         * DumpRenderTree/qt/DumpRenderTree.cpp:
1504         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1505
1506 2009-11-13  Adam Roben  <aroben@apple.com>
1507
1508         Add support for
1509         http/tests/security/isolatedWorld/didClearWindowObject.html
1510
1511         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1512         window objects in isolated worlds are cleared
1513
1514         Reviewed by Dave Hyatt.
1515
1516         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1517
1518         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1519         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1520         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1521         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1522         Added. Sets a __worldID property on the global object whose value is
1523         the ID of this world.
1524         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1525         Respond to this new delegate callback by calling through to one of the
1526         above new methods.
1527         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1528         (worldMap): Added. Returns a HashMap containing all the worlds we've
1529         created.
1530         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1531         haven't kept track of this world.
1532         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1533         instead of declaring our own.
1534
1535         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1536
1537         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1538         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1539         didClearWindowObjectForFrameInStandardWorld.
1540         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1541         Respond to this new delegate callback by calling through to one of the
1542         below new methods.
1543         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1544         Added. Sets a __worldID property on the gobal object whose value is
1545         the ID of this world.
1546         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1547         Added. Moved code here from didClearWindowObject.
1548
1549         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1550         didClearWindowObjectForFrame* functions.
1551
1552         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1553         (worldMap): Added. Returns a HashMap containing all the worlds we've
1554         created.
1555         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1556         haven't kept track of this world.
1557         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1558         instead of declaring our own.
1559
1560 2009-11-13  Adam Roben  <aroben@apple.com>
1561
1562         Finish replacing worldIDs with world objects
1563
1564         The only remaining use of worldIDs was in a method only used by DRT
1565         for the isolated worlds tests.
1566
1567         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1568
1569         Reviewed by Mark Rowe.
1570
1571         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1572         (LayoutTestController::evaluateScriptInIsolatedWorld):
1573         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1574         (LayoutTestController::evaluateScriptInIsolatedWorld):
1575         Updated for changes to WebFrame. Now holds the map of worldID -> world
1576         at this level instead of making WebKit do it.
1577
1578 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1579
1580         Reviewed by Simon Hausmann.
1581
1582         [Qt] Ensure the DRT does not output anything until first test is run
1583
1584         * DumpRenderTree/qt/DumpRenderTree.cpp:
1585         * DumpRenderTree/qt/DumpRenderTree.h:
1586
1587 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1588
1589         Reviewed by Tor Arne Vestbø.
1590
1591         Clear the undo stack in before each new test run.
1592
1593         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1594
1595         * DumpRenderTree/qt/DumpRenderTree.cpp:
1596         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1597
1598 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1599
1600         Reviewed by Kenneth Rohde Christiansen.
1601
1602         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1603
1604         * DumpRenderTree/qt/DumpRenderTree.cpp:
1605         (WebCore::WebPage::resetSettings):
1606         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1607         (LayoutTestController::overridePreference):
1608
1609 2009-11-13  Eric Seidel  <eric@webkit.org>
1610
1611         Reviewed by Adam Barth.
1612
1613         Update committers.py based on svn records
1614         https://bugs.webkit.org/show_bug.cgi?id=31366
1615
1616         This list was generated using validate-committer-lists from
1617         https://bugs.webkit.org/show_bug.cgi?id=30970
1618         and makes committers.py current for committers who have
1619         committed in the last 3 years.
1620
1621         * Scripts/modules/committers.py:
1622
1623 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1624
1625         Reviewed by Adam Barth.
1626
1627         The document-open.html test was flaky at times. The test invokes the layout test plugin
1628         which in its destroy stream handler opens a new document. This basically tears down the
1629         stream and the associated plugin instance. The pluginLog function in the layout test
1630         plugin attempts to retrieve the window script object on a torn down plugin instance
1631         which crashed consistently on windows in the debugger. The functions which issue
1632         these logs already have a valid window script object. We now have variants of the pluginLog
1633         function which take in a window script object with and without variable arguments. 
1634
1635         https://bugs.webkit.org/show_bug.cgi?id=31067
1636
1637         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1638         (pluginLogWithWindowObject):
1639         (pluginLogWithWindowObjectVariableArgs):
1640         (pluginLog):
1641         (notifyTestCompletion):
1642         (testDocumentOpen):
1643         (testWindowOpen):
1644
1645 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1646
1647         Reviewed by Gustavo Noronha Silva.
1648
1649         https://bugs.webkit.org/show_bug.cgi?id=30997
1650         [Gtk] Implemment AtkDocument
1651
1652         Added testing support.
1653
1654         * DumpRenderTree/AccessibilityUIElement.cpp:
1655         * DumpRenderTree/AccessibilityUIElement.h:
1656         (getDocumentEncodingCallback):
1657         (getDocumentURICallback):
1658         (AccessibilityUIElement::getJSClass):
1659         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1660         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1661         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1662         (AccessibilityUIElement::documentEncoding):
1663         (AccessibilityUIElement::documentURI):
1664
1665 2009-11-12  Adam Roben  <aroben@apple.com>
1666
1667         Replace worldIDs with world objects
1668
1669         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1670         user scripts/stylesheets and isolated worlds
1671
1672         Reviewed by Sam Weinig.
1673
1674         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1675         (LayoutTestController::addUserScript):
1676         (LayoutTestController::addUserStyleSheet):
1677         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1678         (LayoutTestController::addUserScript):
1679         (LayoutTestController::addUserStyleSheet):
1680         Changed these functions to create a new WebJSWorld each time they're
1681         called and to pass that world to WebKit.
1682
1683 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1684
1685         Reviewed by Oliver Hunt.
1686
1687         need to implement aria tree roles
1688         https://bugs.webkit.org/show_bug.cgi?id=31284
1689
1690         * DumpRenderTree/AccessibilityUIElement.cpp:
1691         (disclosedRowAtIndexCallback):
1692         (selectedRowAtIndexCallback):
1693         (isEqualCallback):
1694         (isAttributeSettableCallback):
1695         (isActionSupportedCallback):
1696         (disclosedByRowCallback):
1697         (hierarchicalLevelCallback):
1698         (AccessibilityUIElement::getJSClass):
1699         * DumpRenderTree/AccessibilityUIElement.h:
1700         (AccessibilityUIElement::isEqual):
1701         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1702         (AccessibilityUIElement::hierarchicalLevel):
1703         (AccessibilityUIElement::disclosedRowAtIndex):
1704         (AccessibilityUIElement::selectedRowAtIndex):
1705         (AccessibilityUIElement::disclosedByRow):
1706         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1707         (AccessibilityUIElement::getChildAtIndex):
1708         (AccessibilityUIElement::disclosedRowAtIndex):
1709         (AccessibilityUIElement::selectedRowAtIndex):
1710         (AccessibilityUIElement::titleUIElement):
1711         (AccessibilityUIElement::parentElement):
1712         (AccessibilityUIElement::disclosedByRow):
1713         (AccessibilityUIElement::hierarchicalLevel):
1714         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1715         (AccessibilityUIElement::hierarchicalLevel):
1716         (AccessibilityUIElement::disclosedRowAtIndex):
1717         (AccessibilityUIElement::selectedRowAtIndex):
1718         (AccessibilityUIElement::disclosedByRow):
1719
1720 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1721
1722         Reviewed by Darin Adler.
1723
1724         svn-apply can not handle git binary diffs
1725         https://bugs.webkit.org/show_bug.cgi?id=26830
1726
1727         Support "literal" type git binary diffs.
1728
1729         * Scripts/VCSUtils.pm:
1730         * Scripts/modules/scm_unittest.py:
1731         * Scripts/svn-apply:
1732
1733 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1734
1735         Not reviewed, removing duplicate entry for myself in committers.py.
1736
1737         * Scripts/modules/committers.py:
1738
1739 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1740
1741         Reviewed by Darin Adler and Mark Rowe.
1742
1743         https://bugs.webkit.org/show_bug.cgi?id=31200
1744         Tests in http/tests/security/mixedContent start to fail when new tests are added
1745
1746         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1747
1748 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1749
1750         Reviewed by Jan Alonzo.
1751
1752         Create, and display a window for the inspector, for inspector
1753         tests.
1754
1755         Need to also show/hide the inspector window to avoid having
1756         problems with code assuming it is realized
1757         https://bugs.webkit.org/show_bug.cgi?id=31347
1758
1759         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1760         (webInspectorShowWindow):
1761         (webInspectorCloseWindow):
1762         (webInspectorInspectWebView):
1763         (createWebView):
1764
1765 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1766
1767         Unreviewed Qt buildbot fix.
1768
1769         My previous fix was wrong, so revert that change and fix it by
1770         returning when the document of the frame has no document element.
1771         Idea is borrowed from mac and win DRT.
1772
1773         * DumpRenderTree/qt/DumpRenderTree.cpp:
1774         (WebCore::DumpRenderTree::dumpFramesAsText):
1775
1776 2009-11-11  Eric Seidel  <eric@webkit.org>
1777
1778         Reviewed byg Kenneth Rohde Christiansen.
1779
1780         Update Kenneth's committer record to include the email he
1781         uses on lists.webkit.org.
1782
1783         * Scripts/modules/committers.py:
1784
1785 2009-11-11  Eric Seidel  <eric@webkit.org>
1786
1787         Reviewed by Gustavo Noronha Silva.
1788
1789         Several committers use separate email addresses for bugzilla and svn.webkit.org
1790         https://bugs.webkit.org/show_bug.cgi?id=31364
1791
1792         Update records for existing committers to include email addresses
1793         used in svn.webkit.org and lists.webkit.org.
1794         Most committers use the same email address in all 3 places, but some use
1795         separate addresses.  committers.py needs record of each of these addresses.
1796
1797         * Scripts/modules/committers.py:
1798
1799 2009-11-11  Eric Seidel  <eric@webkit.org>
1800
1801         No review, adding second email address for an existing committer.
1802
1803         Add Yong Li's second bugzilla account to his committer record.
1804         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1805
1806         * Scripts/modules/committers.py:
1807
1808 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1809
1810         Reviewed by Simon Hausmann.
1811
1812         If the frame has no innerText don't append it, and
1813         do not add a newline which breaks some cross platform
1814         results.
1815
1816         * DumpRenderTree/qt/DumpRenderTree.cpp:
1817         (WebCore::DumpRenderTree::dumpFramesAsText):
1818
1819 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1820
1821         Reviewed by Simon Hausmann.
1822
1823         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1824
1825         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1826         (webkit_test_plugin_new_instance):
1827         (webkit_test_plugin_destroy_instance):
1828         (webkit_test_plugin_destroy_stream):
1829
1830 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1831
1832         Reviewed by Mark Rowe.
1833
1834         Implement the functionality needed by plugins/window-open.html
1835
1836         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1837         (webkit_test_plugin_new_instance):
1838         (webkit_test_plugin_set_window):
1839
1840 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1841
1842         Reviewed by Simon Hausmann.
1843
1844         [Qt] Force -graphicssystem raster and -style windows when running DRT
1845
1846         * DumpRenderTree/qt/main.cpp:
1847         * Scripts/run-webkit-tests:
1848
1849 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1850
1851         Reviewed by Simon Hausmann.
1852
1853         Compute correct library paths for Qt
1854
1855         * Scripts/webkitdirs.pm:
1856
1857 2009-11-10  Mark Rowe  <mrowe@apple.com>
1858
1859         Reviewed by Sam Weinig.
1860
1861         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1862
1863         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1864         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1865         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1866         that had enabled frame load delegate logging this would result in extra log messages being generated,
1867         causing the test to fail.
1868
1869         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1870         tests.
1871
1872         * DumpRenderTree/mac/DumpRenderTree.mm:
1873         (dumpRenderTree):
1874         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1875         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1876
1877 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1878
1879         Reviewed by Kenneth Rohde Christiansen.
1880
1881         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1882
1883         * DumpRenderTree/qt/DumpRenderTree.cpp:
1884         (WebCore::DumpRenderTree::DumpRenderTree):
1885
1886 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1887
1888         Reviewed by Jan Alonzo.
1889
1890         [GTK] Remove WebSocket configuration from WebKitWebSettings
1891         https://bugs.webkit.org/show_bug.cgi?id=31244
1892
1893         Follow-up of r50724. Don't set the enable-web-socket property
1894         anymore.
1895
1896         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1897         (resetDefaultsToConsistentValues):
1898
1899 2009-11-10  Oliver Hunt  <oliver@apple.com>
1900
1901         Reviewed by Maciej Stachowiak.
1902
1903         Rename 3D Canvas related classes to use WebGL prefix
1904         https://bugs.webkit.org/show_bug.cgi?id=29095
1905
1906         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1907         and upate webkitdirs script to new method of testing for WebGL.
1908
1909         * Scripts/do-webcore-rename:
1910         * Scripts/webkitdirs.pm:
1911
1912 2009-11-09  Oliver Hunt  <oliver@apple.com>
1913
1914         Reviewed by Geoff Garen.
1915
1916         Make do-webcore-rename work with git.
1917
1918         * Scripts/do-webcore-rename:
1919
1920 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1921
1922         Adding Kenneth to the reviewers list.
1923
1924         * Scripts/modules/committers.py:
1925
1926 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1927
1928         Reviewed by Jan Alonzo.
1929
1930         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1931         https://bugs.webkit.org/show_bug.cgi?id=30482
1932
1933         LayoutTestControllerGtk now uses the exposed
1934         Page::tabKeyCyclesThroughElements API
1935
1936         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1937         (LayoutTestController::setTabKeyCyclesThroughElements):
1938
1939 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1940
1941         Reviewed by Holger Freyther.
1942
1943         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1944         This helps to pass the test case below. Also replaced hardcoded
1945         code numbers with defined constants.
1946         https://bugs.webkit.org/show_bug.cgi?id=31185
1947         
1948         Test: editing/undo/undo-deleteWord.html
1949
1950         * DumpRenderTree/qt/EventSenderQt.cpp:
1951         (EventSender::keyDown):
1952
1953 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1954
1955         Reviewed by Holger Freyther.
1956
1957         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1958         https://bugs.webkit.org/show_bug.cgi?id=31164
1959
1960         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1961
1962         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1963         (LayoutTestController::processWork):
1964
1965 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1966
1967         Reviewed by Holger Freyther.
1968
1969         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1970         https://bugs.webkit.org/show_bug.cgi?id=31158
1971
1972         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1973         always, which from WorkQueue prospective means that a load has been started
1974         and the queue processing should stop and wait for the load to finish.
1975         Spinning it off into a loading and a non-loading variants was the solution
1976         adopted by Mac's DRT to work around this problem. The former keeps returning
1977         'true' while the later executes the script synchronously and returns 'false'
1978         making it possible to the WorkQueue to proceed right away.
1979
1980         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1981         (LayoutTestController::processWork):
1982         (LayoutTestController::queueLoadingScript):
1983         (LayoutTestController::queueNonLoadingScript):
1984         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1985         * DumpRenderTree/qt/WorkQueueItem.h:
1986         (LoadingScriptItem::LoadingScriptItem):
1987         (LoadingScriptItem::invoke):
1988         (NonLoadingScriptItem::NonLoadingScriptItem):
1989         (NonLoadingScriptItem::invoke):
1990
1991 2009-11-07  Mark Rowe  <mrowe@apple.com>
1992
1993         Rubber-stamped by Cameron Zwarich.
1994
1995         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1996
1997         * Scripts/commit-log-editor:
1998
1999 2009-11-07  Mark Rowe  <mrowe@apple.com>
2000
2001         Reviewed by Darin Adler.
2002
2003         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
2004         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
2005
2006         Move logic for determining the name and email address to use in a ChangeLog entry from
2007         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
2008         whether the author of the patch matches committer, and therefore needs access to the
2009         email address that would be used in a ChangeLog entry.
2010
2011         Based on a patch by Pierre d'Herbemont.
2012
2013         * Scripts/VCSUtils.pm:
2014         * Scripts/commit-log-editor:
2015         * Scripts/prepare-ChangeLog:
2016         * Scripts/webkitdirs.pm:
2017
2018 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2019
2020         Reviewed by Adam Barth.
2021
2022         Added functionality to the layout test plugin to invoke document.open and
2023         window.open with default arguments. The associated webkit bug is
2024         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
2025         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
2026         work in Chromium (V8) if there is no calling javascript context. To achieve this
2027         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
2028         for the window.open test case and in NPP_DestroyStream for the document.open test case.
2029
2030         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2031         (testDocumentOpen):
2032         (testWindowOpen):
2033         (pluginAllocate):
2034         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2035         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2036         (NPP_New):
2037         (NPP_SetWindow):
2038         (NPP_DestroyStream):
2039         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2040         (NPP_New):
2041         (NPP_SetWindow):
2042         (NPP_NewStream):
2043         (NPP_DestroyStream):
2044
2045 2009-11-06  Eric Seidel  <eric@webkit.org>
2046
2047         Reviewed by Adam Barth.
2048
2049         bugzilla-tool crashed with exception
2050         https://bugs.webkit.org/show_bug.cgi?id=31092
2051
2052         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
2053
2054 2009-11-04  Eric Seidel  <eric@webkit.org>
2055
2056         No review, just add a line which got left out of the patch uploaded for commit.
2057
2058         commit-queue is crashing when trying to reject patches after unknown failures
2059         https://bugs.webkit.org/show_bug.cgi?id=31091
2060
2061         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
2062
2063 2009-11-04  Adam Roben  <aroben@apple.com>
2064
2065         Remove bogus else clause in bugzilla-tool
2066
2067         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
2068         create-bug raises exception after entering bug description
2069
2070         Reviewed by David Kilzer.
2071
2072         * Scripts/bugzilla-tool:
2073         (CreateBug): else clauses are only hit if no exception is raised, so
2074         it makes no sense to try to re-raise the exception in an else clause.
2075         The exception will automatically be re-raised if it doesn't match any
2076         of the except clauses, so we don't have to do anything special here at
2077         all to get the desired behavior.
2078
2079 2009-11-04  Eric Seidel  <eric@webkit.org>
2080
2081         Reviewed by David Kilzer.
2082
2083         svn-apply's fixChangeLogPatch function seems broken
2084         https://bugs.webkit.org/show_bug.cgi?id=30683
2085
2086         Update fixChangeLogPatch to be able to handle patches which
2087         don't start at line 1.
2088         Add unit tests for svn-apply to scm_unittest.py.
2089
2090         * Scripts/VCSUtils.pm:
2091         * Scripts/modules/scm_unittest.py:
2092
2093 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
2094
2095         Reviewed by Beth Dakin.
2096
2097         Need to implement ARIA role="combobox"
2098         https://bugs.webkit.org/show_bug.cgi?id=31096
2099
2100         * DumpRenderTree/AccessibilityUIElement.cpp:
2101         (showMenuCallback):
2102         (getIsExpandedCallback):
2103         (AccessibilityUIElement::getJSClass):
2104         * DumpRenderTree/AccessibilityUIElement.h:
2105         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2106         (AccessibilityUIElement::isExpanded):
2107         (AccessibilityUIElement::showMenu):
2108         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2109         (AccessibilityUIElement::isExpanded):
2110         (AccessibilityUIElement::showMenu):
2111         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2112         (AccessibilityUIElement::isSelected):
2113         (AccessibilityUIElement::isExpanded):
2114         (AccessibilityUIElement::showMenu):
2115
2116 2009-11-04  Eric Seidel  <eric@webkit.org>
2117
2118         Reviewed by Adam Barth.
2119
2120         commit-queue is crashing when trying to reject patches after unknown failures
2121         https://bugs.webkit.org/show_bug.cgi?id=31091
2122
2123         * Scripts/bugzilla-tool:
2124          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
2125            so we have to find out what the current patch is by asking bugzilla again.
2126          - Discovered that this code was also leaking file descriptors, so fixed that.
2127
2128 2009-11-04  Adam Roben  <aroben@apple.com>
2129
2130         Make run-webkit-tests work for the Debug_Internal Windows
2131         configuration
2132
2133         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2134         suffix.
2135
2136         Fixes <http://webkit.org/b/31123>.
2137
2138         Reviewed by Sam Weinig.
2139
2140         * Scripts/run-webkit-tests: Don't add the _debug suffix in
2141         Debug_Internal, either.
2142
2143 2009-11-04  Eric Seidel  <eric@webkit.org>
2144
2145         Reviewed by Adam Barth.
2146
2147         committers.py needs a way to store non-bugzilla email addresses
2148         https://bugs.webkit.org/show_bug.cgi?id=31037
2149
2150         Make Committer and Reviewer constructors take a single email or a list of emails.
2151         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2152         Expose reviewers(), used by validate-committer-lists on bug 30970.
2153
2154         * Scripts/modules/committers.py:
2155         * Scripts/modules/committers_unittest.py: Added tests for the new code.
2156
2157 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2158
2159         Reviewed by David Levin.
2160
2161         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2162         https://bugs.webkit.org/show_bug.cgi?id=27491
2163
2164         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2165         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2166
2167         Functions to start or stop Web Socket servers are added.
2168
2169         * Scripts/run-webkit-tests:
2170
2171 2009-11-03  Eric Seidel  <eric@webkit.org>
2172
2173         No review, just changing wording of log message.
2174
2175         Change log string to say "failed" instead of "rejected"
2176         when a commit fails due to an out of date checkout.
2177         This makes grepping the commit-queue log for rejected patches easier.
2178
2179         * Scripts/bugzilla-tool:
2180
2181 2009-11-03  Eric Seidel  <eric@webkit.org>
2182
2183         No review, adding commonly known committers missing from the file.
2184
2185         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2186
2187 2009-11-03  Eric Seidel  <eric@webkit.org>
2188
2189         No review, just sort-order cleanup.
2190
2191         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2192
2193 2009-11-03  Stephen White  <senorblanco@chromium.org>
2194
2195         (Unreviewed).
2196
2197         Add myself to committers.py.
2198
2199         * Scripts/modules/committers.py:
2200
2201 2009-11-03  Robin Dunn  <robin@alldunn.com>
2202
2203         Reviewed by Kevin Ollviier.
2204
2205         Add packaging scripts for Debian-based Linux distros.
2206         
2207         https://bugs.webkit.org/show_bug.cgi?id=31075
2208
2209         * wx/packaging/build-debian-installer.py: Added.
2210         * wx/packaging/debian: Added.
2211
2212 2009-11-03  Dan Bernstein  <mitz@apple.com>
2213
2214         Reviewed by Anders Carlsson and Beth Dakin.
2215
2216         https://bugs.webkit.org/show_bug.cgi?id=31070
2217
2218         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2219         destroyed, it executes the value of the 'ondestroy' parameter as a
2220         script.
2221
2222         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2223         (pluginAllocate): Initialize onDestroy.
2224         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2225         onDestroy.
2226         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2227         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2228         specified.
2229         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2230
2231 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2232
2233         Reviewed by Xan Lopez.
2234
2235         https://bugs.webkit.org/show_bug.cgi?id=31035
2236         [GTK] some accessibility tests hitting assertion in debug builds
2237
2238         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2239
2240         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2241         (AccessibilityController::rootElement):
2242
2243 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2244
2245         Reviewed by Beth Dakin.
2246
2247         Support ARIA "tab" roles
2248         https://bugs.webkit.org/show_bug.cgi?id=30842
2249
2250         * DumpRenderTree/AccessibilityUIElement.cpp:
2251         * DumpRenderTree/AccessibilityUIElement.h:
2252         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2253         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2254         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2255
2256 2009-11-01  Eric Seidel  <eric@webkit.org>
2257
2258         Reviewed by David Levin.
2259
2260         buildbots should use --exit-after-N-failures
2261         https://bugs.webkit.org/show_bug.cgi?id=30809
2262
2263         Make the bots exit after 20 failures to prevent never-ending
2264         test runs where every test spends a minute crashing.
2265
2266         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2267
2268 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2269
2270         Reviewed by Eric Seidel.
2271
2272         Turn on warnings for QtWebKit for gcc
2273         https://bugs.webkit.org/show_bug.cgi?id=30958
2274
2275         * DumpRenderTree/qt/main.cpp: 
2276         (crashHandler): Mark function NO_RETURN
2277
2278 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2279
2280         Adding myself to the committers list.
2281
2282         * Scripts/modules/committers.py:
2283
2284 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2285
2286         Fix an issue that Adam noticed in DRT.
2287
2288         Reviewed by Darin Adler.
2289
2290         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2291         (AccessibilityUIElement::role):
2292         Get the length of the role text, and create a buffer dynamically.
2293
2294 2009-10-30  Eric Seidel  <eric@webkit.org>
2295
2296         No review, rolling out r50105.
2297         http://trac.webkit.org/changeset/50105
2298
2299         This commit was causing:
2300         https://bugs.webkit.org/show_bug.cgi?id=30869
2301         We'll re-implement the feature a different way.
2302
2303         * Scripts/bugzilla-tool:
2304
2305 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2306
2307         Test for MSAA: Accessibility of headings is not correct
2308
2309         https://bugs.webkit.org/show_bug.cgi?id=30937
2310
2311         Reviewed by Adam Roben.
2312
2313         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2314         (AccessibilityUIElement::role):
2315         Allow the role returned to be a BSTR.
2316         (AccessibilityUIElement::description):
2317         Fix a copy/paste error.
2318
2319 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2320
2321         Test for MSAA: Accessibility of links is wrong
2322
2323         https://bugs.webkit.org/show_bug.cgi?id=30928
2324
2325         Reviewed by Darin Adler.
2326
2327         * DumpRenderTree/AccessibilityUIElement.cpp:
2328         (getAccessibilityValueCallback):
2329         Return the accessibility value.
2330         (AccessibilityUIElement::getJSClass):
2331         Added "accessibilityValue" value.
2332
2333         * DumpRenderTree/AccessibilityUIElement.h:
2334
2335         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2336         (AccessibilityUIElement::accessibilityValue):
2337         Stubbed.
2338
2339         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2340         (AccessibilityUIElement::accessibilityValue):
2341         Stubbed.
2342
2343         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2344         (AccessibilityUIElement::accessibilityValue):
2345         Get the object's value, and return it as a JS string.
2346
2347 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2348
2349         Fix typo in command name used by wx build system.
2350
2351         * wx/build/build_utils.py:
2352
2353 2009-10-30  Adam Barth  <abarth@webkit.org>
2354
2355         Reviewed by Darin Adler.
2356
2357         Patch v1 is a dumb default name for patches
2358         https://bugs.webkit.org/show_bug.cgi?id=30952
2359
2360         Let's use "Patch" instead.
2361
2362         * Scripts/bugzilla-tool:
2363
2364 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2365
2366         Unreviewed trivial buildfix.
2367
2368         [Qt] Buildfix for r50333.
2369
2370         * DumpRenderTree/qt/DumpRenderTree.pro:
2371
2372 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2373
2374         Reviewed by Holger Freyther.
2375
2376         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2377         https://bugs.webkit.org/show_bug.cgi?id=30953
2378
2379         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2380         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2381         makes qt DRT to share this implementation (as gtk and mac ports do).
2382
2383         * DumpRenderTree/qt/DumpRenderTree.pro:
2384         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2385         * DumpRenderTree/qt/WorkQueue.h: Removed.
2386
2387 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2388
2389         Unreviewed potential buildbot fix.
2390
2391         Second try: Reset page history before running each test.
2392
2393         Apparently the QWebHistory::clear() keeps the current page
2394         in history which is not what we want, so we not additionally
2395         sets the history capacity to 0 (forces removing everything)
2396         and then sets it back to its original value.
2397
2398         * DumpRenderTree/qt/DumpRenderTree.cpp:
2399         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2400
2401 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2402
2403         Unreviewed potential buildbot fix.
2404
2405         Reset page history before running each test.
2406
2407         * DumpRenderTree/qt/DumpRenderTree.cpp:
2408         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2409
2410 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2411
2412         Reviewed by Eric Seidel.
2413
2414         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2415
2416         Bug 28420 -  Implement HTML5 <ruby> rendering
2417         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2418
2419         No new tests (no functional change).
2420
2421         * Scripts/build-webkit:
2422
2423 2009-10-29  Dan Bernstein  <mitz@apple.com>
2424
2425         Reviewed by Mark Rowe.
2426
2427         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2428         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2429         define it.
2430
2431         * Scripts/VCSUtils.pm:
2432         * Scripts/svn-apply:
2433         * Scripts/svn-unapply:
2434
2435 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2436
2437         Reviewed by Gustavo Noronha.
2438
2439         Use the GTK+ main loop instead of rolling our own mini-version of
2440         it.
2441
2442         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2443         (dump):
2444         (runTest):
2445         (webViewLoadFinished):
2446
2447 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2448
2449         Reviewed by Oliver Hunt.
2450
2451         Implement the Qt version of DRT dumpBackForwardList().
2452
2453         * DumpRenderTree/qt/DumpRenderTree.cpp:
2454         (WebCore::dumpHistoryItem):
2455         (WebCore::DumpRenderTree::dumpBackForwardList):
2456
2457 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2458
2459         Reviewed by Adam Roben.
2460
2461         Implement DRT functionality for Qt introduced in
2462         r28690 and r28705.
2463
2464         - Implemented pathToLocalResource which exposes the functionality of
2465         converting a given unix path to the correct location on Windows.
2466         - Implemented a way to remove machine-dependent information from paths
2467         in layout test results.
2468
2469         * DumpRenderTree/qt/DumpRenderTree.cpp:
2470         (WebCore::urlSuitableForTestResult):
2471         (WebCore::WebPage::javaScriptConsoleMessage):
2472         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2473         (LayoutTestController::pathToLocalResource):
2474         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2475
2476 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2477
2478         Adding myself to the committers list.
2479
2480         * Scripts/modules/committers.py:
2481
2482 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2483
2484         Adding myself to the committers list.
2485
2486         * Scripts/modules/committers.py:
2487
2488 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2489
2490         Reviewed by Jan Alonzo.
2491
2492         [GTK] API to start inspector for a WebView
2493         https://bugs.webkit.org/show_bug.cgi?id=22551
2494
2495         Use the new inspector API to implement the LayoutTestController
2496         interfaces used to test the inspector.
2497
2498         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2499         (webInspectorInspectWebView):
2500         (createWebView):
2501         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2502         (LayoutTestController::showWebInspector):
2503         (LayoutTestController::closeWebInspector):
2504         (LayoutTestController::evaluateInWebInspector):
2505
2506 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2507
2508         Reviewed by Eric Seidel.
2509
2510         [Qt] WebFrame::counterValueForElementById must not be exposed
2511         https://bugs.webkit.org/show_bug.cgi?id=30882
2512
2513         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2514         (LayoutTestController::counterValueForElementById):
2515
2516 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2517
2518         Rubberstamped by Oliver Hunt.
2519
2520         Fix the warning:
2521
2522         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2523         declared with attribute warn_unused_result".
2524
2525         by actually checking the result. In the case it is null, an
2526         error has occoured, so treat it as the other fatal errors.
2527
2528         * DumpRenderTree/qt/DumpRenderTree.cpp:
2529         (WebCore::DumpRenderTree::initializeFonts):
2530
2531 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2532
2533         Reviewed by Darin Adler.
2534
2535         Provide a way to get counter values with layoutTestContoller
2536         https://bugs.webkit.org/show_bug.cgi?id=30555
2537
2538         Define layoutTestContoller.counterValueForElementById.
2539
2540         * DumpRenderTree/LayoutTestController.cpp:
2541         (counterValueForElementByIdCallback):
2542         (LayoutTestController::staticFunctions):
2543         * DumpRenderTree/LayoutTestController.h:
2544         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2545         (LayoutTestController::counterValueForElementById):
2546
2547 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2548
2549         Rubberstamped by Oliver Hunt.
2550
2551         Change two methods to be internal for DRT use only.
2552
2553         Part of [Qt] Review all new API in Qt 4.6
2554         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2555
2556         * DumpRenderTree/qt/DumpRenderTree.cpp:
2557         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2558         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2559         (LayoutTestController::whiteListAccessFromOrigin):
2560
2561 2009-10-27  Eric Seidel  <eric@webkit.org>
2562
2563         Reviewed by Adam Barth.
2564
2565         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2566         https://bugs.webkit.org/show_bug.cgi?id=30826
2567
2568         * Scripts/svn-apply:
2569          - Add () around all system() calls.
2570          - Use the correct system() == 0 or die instead of system() or die
2571          - Add descriptive messages to all die statements.
2572
2573 2009-10-27  Steve Block  <steveblock@google.com>
2574
2575         Reviewed by NOBODY.
2576
2577         Adds steveblock@google.com to list of committers.
2578
2579         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2580
2581 2009-10-27  Eric Seidel  <eric@webkit.org>
2582
2583         Reviewed by Adam Barth.
2584
2585         svn-apply can exit(0) even on patch failure
2586         https://bugs.webkit.org/show_bug.cgi?id=29622
2587
2588         * Scripts/svn-apply:
2589          - Add a bunch of "or die" statements, hopefully catching all
2590            possible cases where failure could still exit(0).
2591
2592 2009-10-27  Eric Seidel  <eric@webkit.org>
2593
2594         Reviewed by Adam Barth.
2595
2596         svn-* scripts should share code through VCSUtils.pm
2597         https://bugs.webkit.org/show_bug.cgi?id=30791
2598
2599         Just moving code into a shared location.
2600
2601         * Scripts/VCSUtils.pm:
2602         * Scripts/prepare-ChangeLog:
2603         * Scripts/resolve-ChangeLogs:
2604         * Scripts/svn-apply:
2605         * Scripts/svn-create-patch:
2606         * Scripts/svn-unapply:
2607         * Scripts/update-webkit:
2608
2609 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2610
2611         Suppress a huge number of MSVC warnings when building wxWebKit.
2612
2613         * wx/build/settings.py:
2614
2615 2009-10-26  Eric Seidel  <eric@webkit.org>
2616
2617         No review, just adding Mike Belshe to the committers list.
2618
2619         * Scripts/modules/committers.py:
2620
2621 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2622
2623         Reviewed by Darin Adler.
2624
2625         Make .rc files compile on Windows without depending on MFC headers
2626         https://bugs.webkit.org/show_bug.cgi?id=30750
2627
2628         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2629         windows.h instead of afxres.h because it exists even when MFC is not 
2630         installed, and is all that's needed here.
2631
2632         * FindSafari/FindSafari.rc: Ditto
2633
2634 2009-10-24  Eric Seidel  <eric@webkit.org>
2635
2636         Reviewed by Adam Barth.
2637
2638         bugzilla-tool post-diff should know how to mark commit-queue=?
2639         https://bugs.webkit.org/show_bug.cgi?id=29202
2640
2641         * Scripts/bugzilla-tool:
2642          - Add --commit-queue option to post-diff, post-commits and create-bug.
2643         * Scripts/modules/bugzilla.py:
2644          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2645          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2646
2647 2009-10-23  Eric Seidel  <eric@webkit.org>
2648
2649         Reviewed by Adam Barth.
2650
2651         bugzilla-tool commit-queue does not notice modifications to committers.py
2652         https://bugs.webkit.org/show_bug.cgi?id=30084
2653
2654         * Scripts/bugzilla-tool:
2655          - Make commit-queue re-exec itself instead of using while(1).
2656          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2657          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2658
2659 2009-10-22  Eric Seidel  <eric@webkit.org>
2660
2661         Reviewed by Adam Barth.
2662
2663         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2664         https://bugs.webkit.org/show_bug.cgi?id=30634
2665
2666         * Scripts/bugzilla-tool:
2667          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2668          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2669
2670 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2671
2672         Reviewed by Eric Seidel.
2673
2674         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2675
2676         https://bugs.webkit.org/show_bug.cgi?id=30763
2677
2678         * pywebsocket/mod_pywebsocket/__init__.py:
2679         * pywebsocket/mod_pywebsocket/dispatch.py:
2680         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2681         * pywebsocket/mod_pywebsocket/standalone.py:
2682         * pywebsocket/setup.py:
2683         * pywebsocket/test/test_dispatch.py:
2684
2685 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2686
2687         Reviewed by David Levin.
2688
2689         REGRESSION: 2 failures in run-webkit-unittests
2690         https://bugs.webkit.org/show_bug.cgi?id=30645
2691
2692         * Scripts/modules/cpp_style_unittest.py:
2693         Fixed a few test scenarios which apparently lost some spaces from 
2694         text literals.
2695
2696 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2697
2698         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2699
2700         * Scripts/webkitdirs.pm:
2701
2702 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2703
2704         Reviewed by Darin Adler.
2705
2706         Unification of using null device in perl scripts.
2707         https://bugs.webkit.org/show_bug.cgi?id=30572
2708
2709         * Scripts/VCSUtils.pm:
2710         * Scripts/bisect-builds:
2711         * Scripts/resolve-ChangeLogs:
2712         * Scripts/run-iexploder-tests:
2713         * Scripts/run-jsc:
2714         * Scripts/run-mangleme-tests:
2715         * Scripts/run-webkit-tests:
2716         * Scripts/webkitdirs.pm:
2717         Using File::Spec->devnull() instead of hard coded /dev/null.
2718
2719 2009-10-26  Eric Seidel  <eric@webkit.org>
2720
2721         Reviewed by Holger Freyther.
2722
2723         Reviewers are missing from committers.py
2724         https://bugs.webkit.org/show_bug.cgi?id=30733
2725
2726         * Scripts/modules/committers.py:
2727
2728 2009-10-23  Eric Seidel  <eric@webkit.org>
2729
2730         No review, only adding Alice to the list of reviewers.
2731
2732         * Scripts/modules/committers.py:
2733
2734 2009-10-23  Eric Seidel  <eric@webkit.org>
2735
2736         Reviewed by Eric Carlson.
2737
2738         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2739         https://bugs.webkit.org/show_bug.cgi?id=30700
2740
2741         * DumpRenderTree/mac/DumpRenderTree.mm:
2742         (resetDefaultsToConsistentValues): Update QuickTime version check.
2743
2744 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2745
2746         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2747         character measurement APIs that are private on Tiger.
2748
2749         * wx/build/settings.py:
2750
2751 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2752
2753         Reviewed by NOBODY (build fix).
2754         Build fix following bug #30696.
2755
2756         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2757         (LayoutTestController::evaluateScriptInIsolatedWorld):
2758
2759 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2760
2761         Reviewed by Sam Weinig & Geoff Garen.
2762
2763         https://bugs.webkit.org/show_bug.cgi?id=30696
2764         Enable isolated-worlds tests on mac.
2765
2766         Add private interface for DRT to invoke execution in a given world.
2767
2768         * DumpRenderTree/LayoutTestController.cpp:
2769         (evaluateScriptInIsolatedWorldCallback):
2770         (LayoutTestController::staticFunctions):
2771         * DumpRenderTree/LayoutTestController.h:
2772         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2773         (LayoutTestController::evaluateScriptInIsolatedWorld):
2774         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2775         (LayoutTestController::evaluateScriptInIsolatedWorld):
2776
2777 2009-10-21  Eric Seidel  <eric@webkit.org>
2778
2779         Reviewed by Adam Barth.
2780
2781         bugzilla-tool's "patch failed to download an apply" error should give more information
2782         https://bugs.webkit.org/show_bug.cgi?id=30632
2783
2784         * Scripts/modules/scm.py:
2785          - Use the common run_command method instead of custom POpen code.
2786          - Make run_command know how to take pipes as input.
2787         * Scripts/modules/scm_unittest.py:
2788          - Add new tests to cover change.
2789          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2790
2791 2009-10-21  Kent Tamura  <tkent@chromium.org>
2792
2793         Unreviewed.  Adding myself to the committers list.
2794
2795         * Scripts/modules/committers.py:
2796
2797 2009-10-21  Robin Dunn  <robin@alldunn.com>
2798
2799         Reviewed by Kevin Ollivier.
2800
2801         Update the Windows installer builder to work with Vista / Win 7 and with git.
2802         
2803         https://bugs.webkit.org/show_bug.cgi?id=30649
2804
2805         * wx/build/build_utils.py:
2806         * wx/packaging/build-mac-installer.py:
2807         * wx/packaging/build-win-installer.py:
2808         * wx/packaging/wxWebKitInstaller.iss.in:
2809
2810 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2811
2812         Reviewed by Gustavo Noronha.
2813
2814         [GTK] Added conditional code to avoid using
2815         gdk_window_get_root_coords if we do not have a gtk+ release newer
2816         than 2.17.3.
2817         https://bugs.webkit.org/show_bug.cgi?id=30636
2818
2819         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2820
2821 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2822
2823         Reviewed by Eric Seidel.
2824
2825         [Qt] Added dummy implementation for keepWebHistory()
2826         https://bugs.webkit.org/show_bug.cgi?id=30592
2827
2828         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2829         (LayoutTestController::keepWebHistory):
2830         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2831
2832 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2833
2834         Reviewed by Xan Lopez.
2835
2836         [GTK] Fixed the double click condition, it is not double click if
2837         we move in just in one direction.
2838         https://bugs.webkit.org/show_bug.cgi?id=30636
2839
2840         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2841
2842 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2843
2844         Reviewed by Xan Lopez.
2845
2846         [GTK] Initialize the events completly before emitting them.
2847         https://bugs.webkit.org/show_bug.cgi?id=30633
2848
2849         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2850
2851 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2852
2853         wx build fix. Fix for when linking using --as-needed with gcc.
2854
2855         * wx/browser/wscript:
2856
2857 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2858
2859         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2860         to support all the features used by CURL backend.
2861         
2862         * wx/build/settings.py:
2863         * wx/install-unix-extras:
2864
2865 2009-10-20  Anton Muhin  <antonm@chromium.org>
2866
2867         Reviewed by Adam Barth.
2868
2869         Add {ager,antonm,yurys}@chromium.org into committers.py
2870         https://bugs.webkit.org/show_bug.cgi?id=30560
2871
2872         * Scripts/modules/committers.py:
2873
2874 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2875
2876         Reviewed by Tor Arne Vestbø.
2877
2878         Make the Netscape Test plugin available to the Qt launcher.
2879
2880         * Scripts/run-launcher:
2881
2882 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2883
2884         Reviewed by David Levin.
2885
2886         Removed WebSocket runtime settings.
2887         https://bugs.webkit.org/show_bug.cgi?id=29896
2888
2889         WebSocket runtime configuration is supported by chromium/v8 only.
2890
2891         * DumpRenderTree/mac/DumpRenderTree.mm:
2892         (resetDefaultsToConsistentValues):
2893         * DumpRenderTree/win/DumpRenderTree.cpp:
2894         (resetDefaultsToConsistentValues):
2895
2896 2009-10-19  Nate Chapin  <japhet@chromium.org>
2897
2898         Reviewed by Adam Barth.
2899
2900         Add testFail() to test plugin so we can test our handling of a
2901         plugin invoke call returning false.
2902
2903         https://bugs.webkit.org/show_bug.cgi?id=30239
2904
2905         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2906         (pluginInvoke):
2907         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2908
2909 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2910
2911         Reviewed by Gustavo Noronha.
2912
2913         Enable DOM pasting when running layout tests.
2914
2915         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2916         (resetDefaultsToConsistentValues):
2917
2918 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2919
2920         Reviewed by Simon Hausmann.
2921
2922         Use the setPreferredContentsSize method instead
2923         of setFixedContentsSize, as the method has been renamed.
2924
2925         * DumpRenderTree/qt/DumpRenderTree.cpp:
2926         (WebCore::DumpRenderTree::open):
2927         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2928         (LayoutTestController::setFixedContentsSize):
2929
2930 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2931
2932         Reviewed by Dan Bernstein.
2933
2934         https://bugs.webkit.org/show_bug.cgi?id=30456
2935         Fixes for new Debug_All Windows build configuration.
2936
2937         * DumpRenderTree/win/DumpRenderTree.cpp:
2938         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2939         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2940
2941 2009-10-16  Eric Seidel  <eric@webkit.org>
2942
2943         Reviewed by Adam Barth.
2944
2945         commit-queue status bot should list which buildbot is blocking the queue
2946         https://bugs.webkit.org/show_bug.cgi?id=30452
2947
2948         Add new methods and testing.
2949
2950         * Scripts/bugzilla-tool:
2951         * Scripts/modules/buildbot.py:
2952         * Scripts/modules/buildbot_unittest.py:
2953
2954 2009-10-16  Eric Seidel  <eric@webkit.org>
2955
2956         Reviewed by Adam Barth.
2957
2958         run-webkit-tests fails when CWD is not inside a WebKit checkout
2959         https://bugs.webkit.org/show_bug.cgi?id=30451
2960
2961         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2962         * Scripts/modules/scm_unittest.py:
2963           - Remove use of original_path (we don't need to restore the CWD).
2964           - Don't use '.' to find the webkit checkout, use __file__ instead.
2965
2966 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2967
2968         Reviewed by Adam Roben.
2969
2970         Add a Debug_All configuration to build entire stack as debug.
2971         Change Debug_Internal to:
2972         - stop using _debug suffix for all WebKit/Safari binaries
2973         - not use _debug as a DLL naming suffix
2974         - use non-debug C runtime lib.
2975
2976         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2977         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2978         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2979         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2980         Add missing debug.vsprops inherited property sheet.
2981         Add Debug_All configuration.
2982         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2983         * WinLauncher/WinLauncher.vcproj:
2984         Removed extraneous definitions inherited from vsprops.
2985         Add Debug_All configuration.
2986
2987 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2988
2989         Reviewed by David Levin.
2990
2991         check-webkit-style is wrong about indent checking in namespaces
2992         in header files and a few other things
2993         https://bugs.webkit.org/show_bug.cgi?id=30362
2994
2995         The few other things include:
2996         + check-webkit-style does not require spaces around the equal sign
2997           inside 'if' statements and around binary operators that take 
2998           numeric literals.
2999         + check-webkit-style reports false errors for the / operator
3000           when part of a filename in the #include directive.
3001
3002         * Scripts/modules/cpp_style.py:
3003         Improved indentation checking and space checking around
3004         binary operators. While the checks are still not perfect,
3005         they are clearly better than before.
3006         * Scripts/modules/cpp_style_unittest.py:
3007         Added test cases for the newly supported checks and modified old
3008         test cases to match the new guidelines
3009
3010 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
3011
3012         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
3013
3014         * wx/build/settings.py:
3015
3016 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
3017
3018         Reviewed by David Levin.
3019
3020         Add mod_pywebsocket to test Web Sockets.
3021         http://code.google.com/p/pywebsocket/
3022         https://bugs.webkit.org/show_bug.cgi?id=27490
3023
3024         * pywebsocket/COPYING: Added.
3025         * pywebsocket/MANIFEST.in: Added.
3026         * pywebsocket/README: Added.
3027         * pywebsocket/example/echo_client.py: Added.
3028         * pywebsocket/example/echo_wsh.py: Added.
3029         * pywebsocket/mod_pywebsocket/__init__.py: Added.
3030         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
3031         * pywebsocket/mod_pywebsocket/handshake.py: Added.
3032         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
3033         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
3034         * pywebsocket/mod_pywebsocket/standalone.py: Added.
3035         * pywebsocket/mod_pywebsocket/util.py: Added.
3036         * pywebsocket/setup.py: Added.
3037         * pywebsocket/test/config.py: Added.
3038         * pywebsocket/test/mock.py: Added.
3039         * pywebsocket/test/run_all.py: Added.
3040         * pywebsocket/test/test_dispatch.py: Added.
3041         * pywebsocket/test/test_handshake.py: Added.
3042         * pywebsocket/test/test_mock.py: Added.
3043         * pywebsocket/test/test_msgutil.py: Added.
3044         * pywebsocket/test/test_util.py: Added.
3045         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
3046         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
3047         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
3048         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
3049         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
3050         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
3051         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
3052         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
3053
3054 2009-10-15  James Robinson  <jamesr@google.com>
3055
3056         Reviewed by David Levin.
3057
3058         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
3059
3060         https://bugs.webkit.org/show_bug.cgi?id=30426
3061
3062         * Scripts/modules/cpp_style.py:
3063         * Scripts/modules/cpp_style_unittest.py:
3064
3065 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
3066
3067         Reviewed by Adam Roben.
3068
3069         Fixes <http://webkit.org/b/30411>.
3070         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
3071         
3072         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
3073         building Chromium.
3074
3075         * Scripts/pdevenv:
3076
3077 2009-10-15  Robin Dunn  <robin@alldunn.com>
3078
3079         Reviewed by Kevin Ollivier.
3080
3081         Add Mac package building scripts for wx.
3082         
3083         https://bugs.webkit.org/show_bug.cgi?id=30405
3084
3085         * wx/build/build_utils.py:
3086         * wx/build/settings.py:
3087         * wx/packaging/build-mac-installer.py: Added.
3088
3089 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
3090
3091         Reviewed by Gustavo Noronha.
3092
3093         Enable Web Sockets support when running layout tests.
3094
3095         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3096         (resetDefaultsToConsistentValues):
3097
3098 2009-10-15  Xan Lopez  <xlopez@igalia.com>
3099
3100         Reviewed by Gustavo Noronha.
3101
3102         Need to initialize event.button.button, since in most cases a
3103         button number is not passed as an argument.
3104
3105         * DumpRenderTree/gtk/EventSender.cpp:
3106         (mouseDownCallback):
3107         (mouseUpCallback):
3108
3109 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
3110
3111         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3112         the OS if none was explicitly set.
3113
3114         * wx/build/settings.py:
3115
3116 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
3117
3118         Reviewed by Timothy Hatcher.
3119
3120         Web Inspector: enable developers extras within inspector layout tests.
3121
3122         https://bugs.webkit.org/show_bug.cgi?id=30014
3123
3124         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3125         (LayoutTestController::showWebInspector):
3126         (LayoutTestController::closeWebInspector):
3127         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3128         (LayoutTestController::showWebInspector):
3129         (LayoutTestController::closeWebInspector):
3130
3131 2009-10-14  José Millán Soto  <jmillan@igalia.com>
3132
3133         Reviewed by Jan Alonzo.
3134
3135         GtkLauncher is using a deprecated signal
3136         https://bugs.webkit.org/show_bug.cgi?id=30364
3137
3138         Modified GtkLauncher to use notify::title signal instead of
3139         deprecated title-changed signal
3140
3141         * GtkLauncher/main.c:
3142         (notify_title_cb):
3143         (create_browser):
3144
3145 2009-10-14  Brady Eidson  <beidson@apple.com>
3146
3147         Reviewed by Sam Weinig.
3148
3149         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
3150         1 - Disables WebHistory
3151         2 - Doesn't make sense in that context anyway.
3152
3153         * DumpRenderTree/win/DumpRenderTree.cpp:
3154         (createWebViewAndOffscreenWindow):
3155
3156 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
3157
3158         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3159         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3160
3161         * wx/build/settings.py:
3162         * wx/install-unix-extras:
3163
3164 2009-10-14  Brady Eidson  <beidson@apple.com>
3165
3166         Reviewed by Sam Weinig.
3167
3168         WebKit Win API should provide a delegate interface for global history.
3169         https://bugs.webkit.org/show_bug.cgi?id=29905
3170
3171         * DumpRenderTree/LayoutTestController.cpp:
3172         (LayoutTestController::LayoutTestController):
3173         * DumpRenderTree/LayoutTestController.h:
3174         (LayoutTestController::dumpHistoryDelegateCallbacks):
3175         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3176                 
3177         * DumpRenderTree/win/DumpRenderTree.cpp:
3178         (shouldLogHistoryDelegates):
3179         (runTest):
3180         (createWebViewAndOffscreenWindow):
3181         (main):
3182         * DumpRenderTree/win/DumpRenderTree.vcproj:
3183         
3184         Add the IWebHistoryDelegate to DRT Windows:
3185         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3186         (wstringFromBSTR):
3187         (HistoryDelegate::HistoryDelegate):
3188         (HistoryDelegate::~HistoryDelegate):
3189         (HistoryDelegate::QueryInterface):
3190         (HistoryDelegate::AddRef):
3191         (HistoryDelegate::Release):
3192         (HistoryDelegate::didNavigateWithNavigationData):
3193         (HistoryDelegate::didPerformClientRedirectFromURL):
3194         (HistoryDelegate::didPerformServerRedirectFromURL):
3195         (HistoryDelegate::updateHistoryTitle):
3196         (HistoryDelegate::populateVisitedLinksForWebView):
3197         * DumpRenderTree/win/HistoryDelegate.h: Added.
3198
3199         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3200         (LayoutTestController::removeAllVisitedLinks):
3201
3202 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3203
3204         Reviewed by Simon Hausmann.
3205
3206         [Qt] Implement support for setPOSIXLocale on Qt.
3207         https://bugs.webkit.org/show_bug.cgi?id=30268 
3208  
3209         * DumpRenderTree/qt/DumpRenderTree.cpp:
3210         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3211         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3212         (LayoutTestController::setPOSIXLocale):
3213         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3214
3215 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3216
3217         Unreviewed, adding myself to reviewers list.
3218
3219         * Scripts/modules/committers.py:
3220
3221 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3222
3223         Reviewed by Mark Rowe.
3224
3225         Fix null assignment so root tests work again.
3226
3227         * Scripts/webkitdirs.pm:
3228
3229 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3230
3231         Reviewed by Simon Hausmann.
3232
3233         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3234         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3235         This is done in preparation of implementing missing features in DRT.
3236         No functionality changes made yet.
3237
3238         * DumpRenderTree/qt/DumpRenderTree.cpp:
3239         * DumpRenderTree/qt/DumpRenderTree.pro:
3240         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3241         (EventSender::EventSender):
3242         (EventSender::mouseDown):
3243         (EventSender::mouseUp):
3244         (EventSender::mouseMoveTo):
3245         (EventSender::leapForward):
3246         (EventSender::keyDown):
3247         (EventSender::contextClick):
3248         (EventSender::scheduleAsynchronousClick):
3249         (EventSender::frameUnderMouse):
3250         * DumpRenderTree/qt/EventSenderQt.h: Added.
3251         (EventSender::clearKillRing):
3252         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3253         (LayoutTestController::LayoutTestController):
3254         (LayoutTestController::reset):
3255         (LayoutTestController::processWork):
3256         (LayoutTestController::maybeDump):
3257         (LayoutTestController::waitUntilDone):
3258         (LayoutTestController::notifyDone):
3259         (LayoutTestController::windowCount):
3260         (LayoutTestController::clearBackForwardList):
3261         (LayoutTestController::dumpEditingCallbacks):
3262         (LayoutTestController::dumpResourceLoadCallbacks):
3263         (LayoutTestController::queueBackNavigation):
3264         (LayoutTestController::queueForwardNavigation):
3265         (LayoutTestController::queueLoad):
3266         (LayoutTestController::queueReload):
3267         (LayoutTestController::queueScript):
3268         (LayoutTestController::provisionalLoad):
3269         (LayoutTestController::timerEvent):
3270         (LayoutTestController::encodeHostName):
3271         (LayoutTestController::decodeHostName):
3272         (LayoutTestController::setJavaScriptProfilingEnabled):
3273         (LayoutTestController::setFixedContentsSize):
3274         (LayoutTestController::setPrivateBrowsingEnabled):
3275         (LayoutTestController::setPopupBlockingEnabled):
3276         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3277         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3278         (LayoutTestController::numberOfActiveAnimations):
3279         (LayoutTestController::disableImageLoading):
3280         (LayoutTestController::dispatchPendingLoadRequests):
3281         (LayoutTestController::setDatabaseQuota):
3282         (LayoutTestController::clearAllDatabases):
3283         (LayoutTestController::whiteListAccessFromOrigin):
3284         (LayoutTestController::waitForPolicyDelegate):
3285         (LayoutTestController::overridePreference):
3286         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3287         (LayoutTestController::isLoading):
3288         (LayoutTestController::setLoading):
3289         (LayoutTestController::shouldDumpAsText):
3290         (LayoutTestController::shouldDumpBackForwardList):
3291         (LayoutTestController::shouldDumpChildrenAsText):
3292         (LayoutTestController::shouldDumpDatabaseCallbacks):
3293         (LayoutTestController::shouldDumpStatusCallbacks):
3294         (LayoutTestController::shouldWaitUntilDone):
3295         (LayoutTestController::canOpenWindows):
3296         (LayoutTestController::shouldDumpTitleChanges):
3297         (LayoutTestController::waitForPolicy):
3298         (LayoutTestController::dumpAsText):
3299         (LayoutTestController::dumpChildFramesAsText):
3300         (LayoutTestController::dumpDatabaseCallbacks):
3301         (LayoutTestController::dumpStatusCallbacks):
3302         (LayoutTestController::setCanOpenWindows):
3303         (LayoutTestController::dumpBackForwardList):
3304         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3305         (LayoutTestController::display):
3306         (LayoutTestController::dumpTitleChanges):
3307         (LayoutTestController::dumpSelectionRect):
3308         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3309         (TextInputController::TextInputController):
3310         (TextInputController::doCommand):
3311         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3312         * DumpRenderTree/qt/WorkQueue.cpp:
3313         * DumpRenderTree/qt/WorkQueue.h:
3314         * DumpRenderTree/qt/WorkQueueItem.h:
3315         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3316         (findFrameNamed):
3317         (LoadItem::invoke):
3318         (ReloadItem::invoke):
3319         (ScriptItem::invoke):
3320         (BackForwardItem::invoke):
3321         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3322         * DumpRenderTree/qt/jsobjects.h:
3323
3324 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3325
3326         Not reviewed, adding myself to the list of reviewers.
3327
3328         * Scripts/modules/committers.py:
3329
3330 2009-10-13  Anders Carlsson  <andersca@apple.com>
3331
3332         Reviewed by Sam Weinig.
3333
3334         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3335
3336         Make the private browsing mode testable by the test plug-in.
3337         
3338         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3339         (pluginGetProperty):
3340         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3341         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3342         (NPP_New):
3343         (NPP_SetValue):
3344
3345 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3346
3347         No review, just adding self to the list of reviewers.
3348
3349         * Scripts/modules/committers.py:
3350
3351 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3352
3353         Reviewed by Adam Roben.
3354
3355         Web Inspector: Use proper web view in inspector layout
3356         tests for windows.
3357
3358         https://bugs.webkit.org/show_bug.cgi?id=30298
3359
3360         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3361         (LayoutTestController::showWebInspector):
3362         (LayoutTestController::closeWebInspector):
3363         (LayoutTestController::evaluateInWebInspector):
3364
3365 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3366
3367         Reviewed by Sam Weinig.
3368
3369         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3370         https://bugs.webkit.org/show_bug.cgi?id=29841
3371
3372         * DumpRenderTree/mac/DumpRenderTree.mm:
3373         (resetDefaultsToConsistentValues):
3374         * DumpRenderTree/win/DumpRenderTree.cpp:
3375         (resetDefaultsToConsistentValues):
3376
3377 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3378
3379         Reviewed by Dimitri Glazkov.
3380
3381         Chromium Port - Windows
3382         https://bugs.webkit.org/show_bug.cgi?id=29969
3383
3384         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3385         * Scripts/webkitdirs.pm:
3386
3387 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3388
3389         Reviewed by Darin Adler.
3390
3391         jsc scripts cleanup and Qt/GTK fix
3392         https://bugs.webkit.org/show_bug.cgi?id=30288
3393
3394         Duplicated jscPath() moved to webkitdirs.pm.
3395         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3396         Configuration added (release/debug) to path for Qt-port on Windows.
3397
3398         * Scripts/run-javascriptcore-tests:
3399         * Scripts/run-jsc:
3400         * Scripts/run-sunspider:
3401         * Scripts/sunspider-compare-results:
3402         * Scripts/webkitdirs.pm:
3403
3404 2009-10-11  Adam Barth  <abarth@webkit.org>
3405
3406         Unreviewed.  Add Collin to committers.py.
3407
3408         * Scripts/modules/committers.py:
3409
3410 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3411
3412         wx build fix, add bindings to source/include dirs now that there are sources there.
3413
3414         * wx/build/settings.py:
3415
3416 2009-10-09  Mark Rowe  <mrowe@apple.com>
3417
3418         Reviewed by Brady Eidson.
3419
3420         Enable plug-in halting in DumpRenderTree.
3421
3422         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3423         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3424
3425         * DumpRenderTree/mac/DumpRenderTree.mm:
3426         (resetDefaultsToConsistentValues):
3427         * DumpRenderTree/mac/UIDelegate.mm:
3428         (-[UIDelegate webView:shouldHaltPlugin:]):
3429
3430 2009-10-08  Brady Eidson  <beidson@apple.com>
3431
3432         Reviewed by Dan Bernstein.
3433
3434         Ask the History Delegate to populate the visited links hash.
3435         <rdar://problem/7285293> and https://webkit.org/b/29904
3436
3437         Add the ability for LayoutTestController to clear all visited links.
3438         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3439
3440         * DumpRenderTree/LayoutTestController.cpp:
3441         (LayoutTestController::LayoutTestController):
3442         (removeAllVisitedLinksCallback):
3443         (LayoutTestController::staticFunctions):
3444         * DumpRenderTree/LayoutTestController.h:
3445         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3446         (LayoutTestController::removeAllVisitedLinks):
3447
3448         * DumpRenderTree/mac/HistoryDelegate.mm:
3449         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3450
3451         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3452         (LayoutTestController::removeAllVisitedLinks):
3453         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3454         (LayoutTestController::removeAllVisitedLinks):
3455         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3456         (LayoutTestController::removeAllVisitedLinks):
3457
3458
3459 2009-10-08  Daniel Bates  <dbates@webkit.org>
3460
3461         Reviewed by Adam Roben.
3462
3463         https://bugs.webkit.org/show_bug.cgi?id=30175
3464         
3465         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3466         the OLE drag-and-drop return value like the function it emulates. Currently, 
3467         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
3468         whether the drag-and-drop operation was successful or was cancelled.
3469         
3470         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
3471         return value according to whether the drop operation was successful or not.
3472
3473         * DumpRenderTree/win/EventSender.cpp:
3474         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3475         (replaySavedEvents): Ditto.
3476         * DumpRenderTree/win/EventSender.h:
3477         * DumpRenderTree/win/UIDelegate.cpp:
3478         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3479
3480 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3481
3482         Reviewed by Xan Lopez.
3483
3484         [GTK] Added support for a parameter setting the button that was
3485         pressed in the mouseDown function.
3486         https://bugs.webkit.org/show_bug.cgi?id=30220
3487
3488         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3489
3490 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3491
3492         Reviewed by Xan Lopez.
3493
3494         [GTK] Added a line to the bottom of the expected result to match
3495         the output of the test.
3496         https://bugs.webkit.org/show_bug.cgi?id=30220
3497
3498         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3499         expected.txt:
3500
3501 2009-10-08  Adam Roben  <aroben@apple.com>
3502
3503         Use QueryInterface to get IWebInspectorPrivate
3504
3505         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3506         accessed in a more standard way
3507
3508         Reviewed by John Sullivan and Tim Hatcher.
3509
3510         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3511         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3512         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3513         to the IWebInspectorPrivate interface.
3514
3515 2009-10-07  Adam Roben  <aroben@apple.com>
3516
3517         Implement DRT support for origin whitelisting
3518
3519         Fixes <http://webkit.org/b/30185>.
3520
3521         Reviewed by Eric Seidel.
3522
3523         * DumpRenderTree/win/DumpRenderTree.cpp:
3524         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3525         whitelist, to match Mac DRT.
3526         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3527         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3528         IWebViewPrivate::whiteListAccessFromOrigin.
3529
3530 2009-10-07  Brady Eidson  <beidson@apple.com>
3531
3532         Reviewed by Darin Adler.
3533
3534         Send title changes to the global history delegate.
3535         <rdar://problem/7285293> and https://webkit.org/b/29904
3536
3537         * DumpRenderTree/mac/HistoryDelegate.mm:
3538         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3539
3540 2009-10-07  Adam Barth  <abarth@webkit.org>
3541
3542         Unreviewed.  Remove some folks from committers.py who were listed on
3543         the WebKit Team wiki page but who weren't actually listed as commit+.
3544         At some point, we should coorelate this list with the committers
3545         mailing list.
3546
3547         * Scripts/modules/committers.py:
3548
3549 2009-10-07  Adam Barth  <abarth@webkit.org>
3550
3551         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3552         the wiki into committers.py.
3553
3554         * Scripts/modules/committers.py:
3555
3556 2009-10-07  Adam Barth  <abarth@webkit.org>
3557
3558         Unreviewed.  Added Aaron Boodman to committers.py.
3559
3560         * Scripts/modules/committers.py:
3561
3562 2009-10-07  Evan Martin  <evan@chromium.org>
3563
3564         Reviewed by Darin Adler.
3565
3566         Add API to LayoutTestController for re/setting the system locale.
3567         https://bugs.webkit.org/show_bug.cgi?id=18994
3568
3569         * DumpRenderTree/LayoutTestController.cpp:
3570         (setLocaleCallback):
3571         (LayoutTestController::staticFunctions):
3572         (LayoutTestController::setLocale):
3573         * DumpRenderTree/LayoutTestController.h:
3574
3575 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3576
3577         Reviewed by Jan Alonzo.
3578
3579         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3580         https://bugs.webkit.org/show_bug.cgi?id=29689
3581
3582         Build fix by adding -lfontconfig for DumpRenderTree.
3583
3584         * GNUmakefile.am:
3585
3586 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3587
3588         Reviewed by Simon Hausmann.
3589
3590         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3591
3592         * Scripts/run-webkit-tests:
3593
3594 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3595
3596         Reviewed by Gustavo Noronha.
3597
3598         "delete" in EventSender is the backspace key, not the delete one.
3599
3600         * DumpRenderTree/gtk/EventSender.cpp:
3601         (keyDownCallback):
3602
3603 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3604
3605         Reviewed by Gustavo Noronha.
3606
3607         getChildrenWithRange expects as last parameter the end index, not
3608         the length of the range. Correct this and clarify the variable
3609         names to reflect how the code works.
3610
3611         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3612         (AccessibilityUIElement::getChildrenWithRange):
3613         (AccessibilityUIElement::getChildAtIndex):
3614
3615 2009-10-06  Mark Rowe  <mrowe@apple.com>
3616
3617         Reviewed by Simon Fraser.
3618
3619         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3620
3621         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3622         the fact we have already changed the working directory to the top of the open source tree.
3623
3624 2009-10-06  Julie Parent  <jparent@chromium.org>
3625
3626         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3627         rather than my committer email.
3628
3629         * Scripts/modules/committers.py:
3630
3631 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3632
3633         Reviewed by Eric Seidel.
3634
3635         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3636
3637         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3638         it after each layout test as it should do, making the DRT dump additional output
3639         for all of the subsequent layout tests.
3640
3641         * DumpRenderTree/qt/jsobjects.cpp:
3642         (LayoutTestController::reset):
3643
3644 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3645
3646         Reviewed by Simon Hausmann.
3647
3648         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3649         fast/dom/assign-to-window-status.html test, which is passing as a result.
3650
3651         https://bugs.webkit.org/show_bug.cgi?id=30127
3652
3653         * DumpRenderTree/qt/DumpRenderTree.cpp:
3654         (WebCore::DumpRenderTree::DumpRenderTree):
3655         (WebCore::DumpRenderTree::statusBarMessage):
3656         * DumpRenderTree/qt/DumpRenderTree.h:
3657         * DumpRenderTree/qt/jsobjects.h:
3658         (LayoutTestController::shouldDumpStatusCallbacks):
3659         (LayoutTestController::dumpStatusCallbacks):
3660
3661 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3662
3663         Reviewed by Simon Hausmann.
3664
3665         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3666         ignores the argument indicating which mouse button to trigger.
3667         https://bugs.webkit.org/show_bug.cgi?id=30048
3668
3669         This affects the fast/events/mouse-click-events.html layout test.
3670
3671         * DumpRenderTree/qt/jsobjects.cpp:
3672         (EventSender::mouseDown):
3673         (EventSender::mouseUp):
3674         * DumpRenderTree/qt/jsobjects.h:
3675
3676 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3677
3678         Reviewed by Simon Hausmann.
3679
3680         [Qt] Fix the EventSender::keyDown() implementation
3681         https://bugs.webkit.org/show_bug.cgi?id=30043
3682
3683         It should post both a key press event and a key release event,
3684         just like other ports do.
3685
3686         * DumpRenderTree/qt/jsobjects.cpp:
3687         (EventSender::keyDown):
3688