7f64fc86d0721a5e06769ace3a1472462eb84857
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-01-18  Beth Dakin  <bdakin@apple.com>
2
3         Reviewed by Oliver.
4
5         Update build-webkit to account for foreign-object being disabled by 
6         default.
7
8         * Scripts/build-webkit:
9
10 2008-01-18  Adam Roben  <aroben@apple.com>
11
12         Updated for method renames
13
14         Reviewed by Adele.
15
16         * DumpRenderTree/mac/FrameLoadDelegate.mm:
17         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
18         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
19         (LayoutTestController::setMainFrameIsFirstResponder):
20         (LayoutTestController::setWindowIsKey):
21         * DumpRenderTree/mac/UIDelegate.mm:
22         (-[UIDelegate webViewFocus:]):
23         * DumpRenderTree/win/FrameLoadDelegate.cpp:
24         (FrameLoadDelegate::didCommitLoadForFrame):
25
26 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
27
28         Reviewed by Adam Roben.
29
30         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
31         between DRT and TestNetscapePlugin.
32
33         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
34         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
35
36 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
37
38         Reviewed by Holger.
39
40         Fix fast/dom/Window/window-resize.html
41         
42         In DRT connect the page's geometryChangeRequest signal to a slot that
43         sets the geometry of the view widget.
44         
45
46         * DumpRenderTree/qt/DumpRenderTree.cpp:
47         (WebCore::WebPage::setViewGeometry):
48         (WebCore::WebPage::WebPage):
49
50 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
51
52         Build fix.
53
54         * Drosera/DroseraWin.make:
55
56 2008-01-17  Darin Adler  <darin@apple.com>
57
58         * Scripts/run-webkit-tests: Fixed a bug number.
59
60 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
61
62         Reviewed by Adam Roben.
63
64         http://bugs.webkit.org/show_bug.cgi?id=16908
65         run-webkit-tests complains about missing FindSafari.exe
66
67         * Scripts/webkitdirs.pm: Append _debug as appropriate.
68
69 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
70
71         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
72         
73         Rubber-stamped by Jon Honeycutt.
74
75         * DumpRenderTree/win/DumpRenderTree.vcproj:
76
77 2008-01-16  Alp Toker  <alp@atoker.com>
78
79         Reviewed by Mark Rowe.
80
81         http://bugs.webkit.org/show_bug.cgi?id=16218
82         [GTK] API: Should this entry point be called go_back rather than go_backward?
83
84         Track back/forward API changes in the tools.
85
86         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
87         (BackForwardItem::invoke):
88         * GtkLauncher/main.c:
89         (go_back_cb):
90
91 2008-01-16  Adam Roben  <aroben@apple.com>
92
93         Windows build fix after r29488
94
95         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
96         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
97         expects to find the plugin.
98
99 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
100
101         Reviewed by Sam Weinig.
102         
103         Fixed the waitUntilDone watchdog timer -- the old code never added the
104         timer to the run loop, so it didn't do anything.
105
106         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
107         (LayoutTestController::setWaitToDump):
108         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
109         (LayoutTestController::setWaitToDump):
110
111 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
112
113         Use shared vsprops for most vcproj properties.
114         
115         Reviewed by Darin.
116
117         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
118         * DumpRenderTree/win/DumpRenderTree.vcproj:
119         * DumpRenderTree/win/ImageDiff.vcproj:
120         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
121         * FindSafari/FindSafari.vcproj:
122
123 2008-01-14  Stephanie  <slewis@apple.com>
124
125        Reviewed by NOBODY.
126   
127        revert accidental character.
128
129        * Scripts/run-webkit-tests:
130
131 2008-01-14  Stephanie  <slewis@apple.com>
132
133         RS=Oliver
134
135         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
136
137         * Scripts/run-webkit-tests:
138
139 2008-01-14  Darin Adler  <darin@apple.com>
140
141         * Scripts/do-webcore-rename: Queue up another rename.
142
143 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
144
145         Reviewed by Darin.
146
147         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
148         the tests were ran.
149         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
150
151         * Scripts/run-webkit-tests:
152
153 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
154
155         Reviewed by Darin.
156
157         * Randomize tests array to spot test cases where the results depends on the order
158         the tests are ran.
159         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
160
161         * Scripts/run-webkit-tests:
162
163 2008-01-14  Darin Adler  <darin@apple.com>
164
165         * Scripts/run-webkit-tests: More ignore list tweaking.
166
167 2008-01-14  Darin Adler  <darin@apple.com>
168
169         * Scripts/run-webkit-tests: Add another leak to the ignore list.
170
171 2008-01-14  Dan Bernstein  <mitz@apple.com>
172
173         Reviewed by Adam Roben.
174
175         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
176           build bots
177
178         * DumpRenderTree/win/DumpRenderTree.cpp:
179         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
180
181 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
182
183         Share common files across projects.
184         
185         Unify vsprops files
186         Debug:          common.vsprops, debug.vsprops
187         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
188         Release:        common.vsprops, release.vsprops
189         
190         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
191         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
192
193         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
194
195         Reviewed by Adam Roben.
196
197         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
198         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
199         * Drosera/win/Drosera.vcproj/VERSION: Removed.
200         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
201         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
202         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
203         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
204         * DumpRenderTree/win/DumpRenderTree.vcproj:
205         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
206         * DumpRenderTree/win/debug.vsprops: Removed.
207         * DumpRenderTree/win/debug_internal.vsprops: Removed.
208         * DumpRenderTree/win/release.vsprops: Removed.
209
210 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
211
212         Reviewed by Maciej.
213
214         - http://bugs.webkit.org/show_bug.cgi?id=16314
215           Script to launch Drosera
216
217         * Scripts/gdb-drosera: Added.
218         * Scripts/run-drosera: Added.
219         * Scripts/run-drosera-nightly.cmd: Added.
220         * Scripts/webkitdirs.pm: Added runDrosera function.
221
222 2008-01-13  Dan Bernstein  <mitz@apple.com>
223
224         - fix breakage due to last-minute change
225
226         * DumpRenderTree/win/DumpRenderTree.cpp:
227         (runTest): Declare the loop variable.
228
229 2008-01-13  Dan Bernstein  <mitz@apple.com>
230
231         Reviewed by Adam Roben.
232
233         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
234
235         * DumpRenderTree/win/DumpRenderTree.cpp:
236         (DumpRenderTreeWndProc):
237         (initialize):
238         (dumpBackForwardList):
239         (dumpBackForwardListForAllWindows):
240         (dump):
241         (resetWebViewToConsistentStateBeforeTesting): Factored out of
242         runTest().
243         (runTest):
244         (allWindows): Added. Returns a vector of all open windows.
245         (windowToWebViewMap): Added. Returns a map from open windows to their
246         WebViews.
247         (createWebViewAndOffscreenWindow): Factored out of main() to be
248         reusable for creating extra windows.
249         (main):
250         * DumpRenderTree/win/DumpRenderTreeWin.h:
251         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
252         (LayoutTestController::windowCount): Implemented.
253         * DumpRenderTree/win/UIDelegate.cpp:
254         (UIDelegate::createWebViewWithRequest): Implemented.
255         (UIDelegate::webViewClose): Implemented.
256         * DumpRenderTree/win/UIDelegate.h:
257
258 2008-01-12  Alp Toker  <alp@atoker.com>
259
260         Reviewed by Mark Rowe.
261
262         Hide non-public symbols in GTK+/autotools release builds.
263
264         * GNUmakefile.am:
265
266 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
267
268         Reviewed by Ap.
269
270         * Make launching of the WebKit httpd work on GNU/Debian/Linux
271         
272         The configuration of Apache2 and installation does not depend on
273         the kernel but on the distribution policy. Make launching of httpd
274         work for Debian derived distributions.
275
276         * Scripts/run-webkit-httpd:
277         * Scripts/run-webkit-tests:
278         * Scripts/webkitdirs.pm:
279
280 2008-01-12  Mark Rowe  <mrowe@apple.com>
281
282         Reviewed by Maciej Stachowiak.
283
284         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
285
286         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
287         match the callers expectations that it can take ownership of the string.
288
289 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
290
291         Reviewed by Adam Roben.
292
293         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
294
295         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
296         as these are only posted because the test window is not a normal visible one, and
297         they confuse drag&drop machinery.
298
299 2008-01-11  Adam Roben  <aroben@apple.com>
300
301         Fix a crash when pathToLocalResource fails and a leak
302
303         Reviewed by Darin.
304
305         * DumpRenderTree/LayoutTestController.cpp:
306         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
307         sure not to pass null to JSValueMakeString.
308         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
309         (LayoutTestController::pathToLocalResource): Print an error message if
310         the conversion fails so it's clear what happened.
311
312 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
313
314         Reviewed by John Sullivan.
315
316         * DumpRenderTree/mac/GCControllerMac.mm:
317         (GCController::collectOnAlternateThread): Updated for name change.
318
319 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
320
321         wx build fix. Don't build dftables any longer since it's now a Perl
322         script.
323
324         * wx/build-wxwebkit:
325
326 2008-01-10  Sam Weinig  <sam@webkit.org>
327
328         Reviewed by Anders Carlsson.
329
330         Make DRT track open windows instead of allocated windows so that
331         we can avoid ASSERTION due to late deallocs out of our control.
332
333         * DumpRenderTree/mac/DumpRenderTree.mm:
334         (dumpBackForwardListForAllWindows):
335         (runTest):
336         * DumpRenderTree/mac/DumpRenderTreeMac.h:
337         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
338         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
339         (+[DumpRenderTreeWindow openWindows]):
340         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
341         (-[DumpRenderTreeWindow close]):
342         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
343         (LayoutTestController::windowCount):
344
345 2008-01-10  Ada Chan  <adachan@apple.com>
346
347         Meta key is not the same as Alt key on windows.
348
349         Reviewed by Darin.
350
351         * DumpRenderTree/win/EventSender.cpp:
352         (keyDownCallback):
353
354 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
355
356         Reviewed by Darin, Sam and Adam.
357
358         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
359         link in gmail message displays JavaScript alert falsely complaining
360         about pop-up blocking.
361         - Added the ability to enable the pop-up blocker via the
362         LayoutTestController.
363
364         * DumpRenderTree/LayoutTestController.cpp:
365         (setPopupBlockingEnabledCallback):
366         (LayoutTestController::staticFunctions):
367         * DumpRenderTree/LayoutTestController.h:
368         * DumpRenderTree/mac/DumpRenderTree.mm:
369         (setDefaultsToConsistentValuesForTesting):
370         (resetWebViewToConsistentStateBeforeTesting):
371         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
372         (LayoutTestController::setPopupBlockingEnabled):
373
374 2008-01-10  Lars Knoll  <lars@trolltech.com>
375
376         Reviewed by Simon.
377
378         rename QWebPageHistory to QWebHistory.
379         
380
381         * DumpRenderTree/qt/jsobjects.cpp:
382
383 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
384
385         Reviewed by Darin.
386         
387         - add some more renames, adjust some
388
389         * Scripts/do-webcore-rename:
390
391 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
392
393         Reviewed by Oliver.
394
395         Enable SVG Fonts support by default.
396
397         * Scripts/build-webkit:
398
399 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
400
401         Reviewed by Adam.
402
403         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
404         DRT doesn't handle platform specific pixel test results correctly.
405
406         <test>-expected.txt files and <test>-expected.png files may now live
407         in different directories (ie. a cross-platform <test>-expected.txt file
408         and a platform-specific <test>-expected.png file).
409
410         * Scripts/run-webkit-tests:
411
412 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
413
414         Reviewed by Darin.
415
416         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
417         DRT did not correctly handle printing the '\0' char.  Now it does.
418
419         * DumpRenderTree/win/DumpRenderTree.cpp:
420         (dumpFramesAsText):
421         (dump):
422
423 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
424
425         Reviewed by Lars.
426
427         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
428         
429
430         * DumpRenderTree/qt/main.cpp:
431         * DumpRenderTree/qt/testplugin.cpp:
432         * DumpRenderTree/qt/testplugin.h:
433
434 2008-01-05  Mark Rowe  <mrowe@apple.com>
435
436         Reviewed by Alp Toker.
437
438         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
439
440         * DumpRenderTree/gtk/DumpRenderTree.cpp:
441         (processWork): Process pending work.
442         (webViewLoadFinished): Schedule processing of pending work.
443         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
444
445 2008-01-05  Darin Adler  <darin@apple.com>
446
447         * Scripts/do-webcore-rename: Some more renaming plans.
448
449 2008-01-04  Alice Liu  <alice.liu@apple.com>
450
451         Reviewed by Alexey and Darin.
452
453         Adding "home" and "end" to DRT's keydown since
454         DOM key events can't handle keyIdentifiers at this point. 
455
456         * DumpRenderTree/mac/EventSendingController.mm:
457         (-[EventSendingController keyDown:withModifiers:]):
458         * DumpRenderTree/win/EventSender.cpp:
459         (keyDownCallback):
460
461 2008-01-04  Lars Knoll  <lars@trolltech.com>
462
463         Reviewed by Simon.
464
465         fix DRT after the changes to QWebPage.
466         
467         The great thing is that we actually don't have
468         any regressions from the QWebPage change :)
469         
470
471         * DumpRenderTree/qt/DumpRenderTree.cpp:
472         (WebCore::DumpRenderTree::DumpRenderTree):
473
474 2008-01-04  Lars Knoll  <lars@trolltech.com>
475
476         Reviewed by Simon.
477
478         make QWebPage a QObject and get things to compile.
479         
480         Nothing works currently though.
481         
482
483         * DumpRenderTree/qt/DumpRenderTree.cpp:
484         (WebCore::DumpRenderTree::DumpRenderTree):
485
486 2008-01-04  Lars Knoll  <lars@trolltech.com>
487
488         Reviewed by Simon.
489
490         take a QString as identifier in QWebFrame::addToJSWindowObject.
491
492         * DumpRenderTree/qt/DumpRenderTree.cpp:
493         (WebCore::DumpRenderTree::initJSObjects):
494
495 2008-01-04  Alp Toker  <alp@atoker.com>
496
497         GTK+ DRT build fix for breakage introduced in r29149.
498
499         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
500         (LayoutTestController::execCommand):
501
502 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
503
504         Reviewed by Darin.
505
506         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
507
508         Added layoutTestController.execCommand to access editor commands that are not available
509         via document.execCommand.
510
511         * DumpRenderTree/LayoutTestController.cpp:
512         (execCommandCallback):
513         (LayoutTestController::staticFunctions):
514         * DumpRenderTree/LayoutTestController.h:
515         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
516         (LayoutTestController::execCommand):
517         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
518         (LayoutTestController::queueLoad):
519         (LayoutTestController::execCommand):
520
521 2008-01-03  Alice Liu  <alice.liu@apple.com>
522
523         Reviewed by Darin, Mitz.
524
525         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
526
527         the clickcount should not increase if the last click was at a different location.  it's a new click.
528
529         * DumpRenderTree/mac/DumpRenderTree.mm:
530         (runTest):
531         * DumpRenderTree/mac/EventSendingController.h:
532         * DumpRenderTree/mac/EventSendingController.mm:
533         (-[EventSendingController mouseDown]):
534         (-[EventSendingController mouseUp]):
535
536 2008-01-03  Darin Adler  <darin@apple.com>
537
538         Reviewed by Adam.
539
540         * Scripts/update-webkit: Make this work a little better for the people at Apple
541         who have a directory named Internal.
542
543 2008-01-03  Adam Roben  <aroben@apple.com>
544
545         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
546
547         Rubberstamped by Mark.
548
549         * Scripts/update-webkit-auxiliary-libs:
550
551 2008-01-03  Adam Roben  <aroben@apple.com>
552
553         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
554
555         http://bugs.webkit.org/show_bug.cgi?id=15663
556
557         Added a fuzz factor into the Last-Modified comparison for downloading
558         WebKitAuxiliaryLibrary.zip.
559
560         The zip file is served from a set of mirrors who give Last-Modified
561         times that are off by 1-3 seconds from each other. This was causing
562         the build bots to redownload WebKitAuxiliaryLibrary for every build,
563         which would then cause all of WebCore to rebuild each time.
564
565         Reviewed by Mark.
566
567         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
568         at least 30 seconds newer than the old one -- otherwise we assume that
569         the difference in time is due to the mirrors being slightly offset
570         from each other.
571         (sub lastModifiedToUnixTime): Added.
572
573 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
574
575         Windows build fix.
576
577         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
578
579 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
580
581         Reviewed by Lars.
582
583         Moved QWebPage::open to QWebFrame::load and added setHtml.
584         
585
586         * DumpRenderTree/qt/DumpRenderTree.cpp:
587         (WebCore::DumpRenderTree::open):
588
589 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
590
591         Reviewed by Lars.
592
593         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
594         
595
596         * DumpRenderTree/qt/DumpRenderTree.cpp:
597         (WebCore::DumpRenderTree::DumpRenderTree):
598
599 2008-01-02  Sam Weinig  <sam@webkit.org>
600
601         * Scripts/do-webcore-rename: Yet more renaming ideas.
602
603 2008-01-02  Darin Adler  <darin@apple.com>
604
605         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
606
607 2008-01-02  Alice Liu  <alice.liu@apple.com>
608
609         Reviewed by Sam Weinig.
610
611         fixing assertion hit with editing/selection/move-begin-end.html
612
613         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
614         * DumpRenderTree/win/DumpRenderTree.vcproj:
615         * DumpRenderTree/win/EventSender.cpp:
616         (keyDownCallback):
617         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
618
619 2008-01-02  Darin Adler  <darin@apple.com>
620
621         * Scripts/do-webcore-rename: Some more name change plans.
622
623 2008-01-02  Alice Liu  <alice.liu@apple.com>
624
625         Reviewed by Maciej.
626
627         Added handling for page up and page down in EventSender
628
629         * DumpRenderTree/mac/EventSendingController.mm:
630         (-[EventSendingController keyDown:withModifiers:]):
631         * DumpRenderTree/win/EventSender.cpp:
632         (keyDownCallback):
633
634 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
635
636         Reviewed by Darin.
637
638         Fix fast/events/arrow-keys-on-body.html for real.
639
640         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
641
642 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
643
644         Reviewed by Darin.
645
646         http://bugs.webkit.org/show_bug.cgi?id=16674
647         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
648
649         * Scripts/run-launcher:
650
651 2007-12-31  Darin Adler  <darin@apple.com>
652
653         Suggested by Antti.
654
655         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
656         we get it installed on the build bots.
657
658 2007-12-30  Eric Seidel  <eric@webkit.org>
659
660         Reviewed by Sam.
661
662         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
663
664 2007-12-29  Darin Adler  <darin@apple.com>
665
666         Reviewed by Oliver.
667
668         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
669           leak bot shows createCStringFromNPVariant result leaking
670
671         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
672         (pluginInvoke): Added a missing free.
673
674 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
675
676         Reviewed by Alp Toker.
677
678         http://bugs.webkit.org/show_bug.cgi?id=16390
679         Use autotools or GNU make as the build system for the GTK port
680
681         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
682         * GNUmakefile.am: Added.
683
684 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
685
686         Reviewed by Oliver.
687
688         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
689
690         * DumpRenderTree/win/EventSender.cpp:
691         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
692         of 1, even though WebKit currently ignores it.
693
694 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
695
696         wx buildbot fix. Update libpng dl script to the latest version.
697
698         * wx/install-unix-extras:
699
700 2007-12-22  Antti Koivisto  <antti@apple.com>
701
702         Fix a typo.
703
704         * Scripts/webkitdirs.pm:
705
706 2007-12-21  Sam Weinig  <sam@webkit.org>
707
708         Reviewed by Mark Rowe.
709
710         - Disable the back/forward cache using the new WebPreferences API
711           instead of through the BackForwardList.  This makes us match what
712           we do on Windows.
713
714         * DumpRenderTree/mac/DumpRenderTree.mm:
715         (createWebViewAndOffscreenWindow):
716         (setDefaultsToConsistentValuesForTesting):
717
718 2007-12-21  Dan Bernstein  <mitz@apple.com>
719
720         Reviewed by Mark Rowe.
721
722         - disable the back/forward cache in Windows DumpRenderTree. It is
723           already disabled in Mac DumpRenderTree.
724
725         * DumpRenderTree/win/DumpRenderTree.cpp:
726         (initializePreferences):
727
728 2007-12-13  Antti Koivisto  <antti@apple.com>
729
730         Reviewed by Darin and Steve.
731         
732         - check for QuickTime SDK on Windows.
733         - build media support on Windows by default
734
735         * Scripts/build-webkit:
736         * Scripts/webkitdirs.pm:
737
738 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
739
740         Build script fix for buildbot.
741
742         * wx/build-wxwebkit:
743
744 2007-12-20  Eric Seidel  <eric@webkit.org>
745
746         Reviewed by mjs.
747
748         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
749
750 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
751
752         Reviewed by Steve.
753
754         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
755         WebKit.
756
757         - Drosera and Safari need to use the same ProgIDs in order for
758         CoCreateInstance to work properly.  The most robust way to do this is
759         for WebKit to dynamically publish those ProgIDs.
760
761         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
762         (DebuggerClient::createWebViewWithRequest):
763         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
764         statics.
765         (Drosera::initUI):
766         (Drosera::attach):
767         (Drosera::attemptToCreateServerConnection):
768         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
769         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
770         make use of the published ProgIDs.
771         (ServerConnection::attemptToCreateServerConnection):
772
773 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
774
775         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
776         - Build bot and leak fix.
777
778         * DumpRenderTree/LayoutTestController.cpp:
779         (pathToLocalResourceCallback):
780
781 2007-12-19  David Kilzer  <ddkilzer@apple.com>
782
783         Make svn-apply/svn-unapply work with patches from git-format-patch.
784
785         Reviewed by Darin.
786
787         * Scripts/svn-apply:
788         (patch): If 'Index:' can't be found in the text passed in, print it
789         out with a warning and return early.
790         * Scripts/svn-unapply:
791         (patch): Ditto.
792
793 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
794
795         Reviewed by Alp Toker.
796
797         Build related fixes.
798
799         * wx/build-wxwebkit:
800         - Check to make sure the user is running a supported wx port
801         - More robust checks for Cygwin
802         - Only run install-unix-extras on Mac, it's not the right solution
803           for Linux distros.
804         - Remove outdated Linux instructions after successful build
805         - Clean Bakefile-generated files during a clean operation
806
807 2007-12-18  Darin Adler  <darin@apple.com>
808
809         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
810
811 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
812
813         Add script to run Drosera as part of the nightly.
814         
815         Reviewed by Kevin M.
816
817         * Scripts/run-drosera.cmd: Added.
818
819 2007-12-18  Darin Adler  <darin@apple.com>
820
821         * Scripts/do-webcore-rename: Remove a stray K.
822
823 2007-12-18  Darin Adler  <darin@apple.com>
824
825         * Scripts/do-webcore-rename: Plan more renaming.
826
827 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
828
829         Reviewed by Alp Toker.
830
831         http://bugs.webkit.org/show_bug.cgi?id=16042
832         [GTK] Eliminate webkit_init()
833
834         Moving webkit initialization to WebView class init.
835
836         * DumpRenderTree/gtk/DumpRenderTree.cpp:
837         (main):
838         * GtkLauncher/main.c:
839         (main):
840
841 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
842
843         Reviewed by Alp Toker.
844
845         http://bugs.webkit.org/show_bug.cgi?id=13542
846         gdklauncher doesnt change URL in adress GTKEntry.
847
848         * GtkLauncher/main.c:
849         (load_commit_cb): added
850         (title_change_cb):
851         (create_browser):
852
853 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
854
855         Reviewed by Adam Roben.
856
857         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
858
859         * FindSafari/FindSafari.cpp:
860         (_tmain):
861
862 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
863
864         Reviewed by Adam Roben.
865
866         http://bugs.webkit.org/show_bug.cgi?id=16315
867         FindSafari needs a path-only option.
868
869         * FindSafari/FindSafari.cpp:
870         (_tmain):
871
872 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
873
874         Reviewed by Darin.
875
876         http://bugs.webkit.org/show_bug.cgi?id=16462
877         REGRESSION: access keys broken on Windows
878
879         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
880         if Alt is pressed.
881
882 2007-12-15  Sam Weinig  <sam@webkit.org>
883
884         Reviewed by Mark Rowe.
885
886         Fix urlSuitableForTestResult to correctly identify wstring::npos as
887         the case when wstring.find doesn't find anything.
888
889         * DumpRenderTree/win/DumpRenderTree.cpp:
890         (urlSuitableForTestResult):
891
892 2007-12-15  Alp Toker  <alp@atoker.com>
893
894         GTK+ DRT build fix for GLib < 2.14.
895
896         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
897         (LayoutTestController::setWaitToDump):
898
899 2007-12-05  Mark Rowe  <mrowe@apple.com>
900
901         Reviewed by Alp Toker.
902
903         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
904         many layout tests from hanging while waiting on user responses to dialogs.
905
906         * DumpRenderTree/gtk/DumpRenderTree.cpp:
907         (invalidateAnyPreviousWaitToDumpWatchdog):
908         (webViewScriptAlert):
909         (webViewScriptPrompt):
910         (webViewScriptConfirm):
911         (main):
912         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
913         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
914         (waitToDumpWatchdogFired):
915         (LayoutTestController::setWaitToDump):
916
917 2007-12-05  Mark Rowe  <mrowe@apple.com>
918
919         Reviewed by Alp Toker.
920
921         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
922
923         * DumpRenderTree/gtk/DumpRenderTree.cpp:
924         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
925         (dump):
926         (runTest):
927         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
928         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
929         work queue is empty.
930         (webViewWindowObjectCleared): Set up window.layoutTestController.
931         (webViewConsoleMessage): Match the console message format expected by the layout test results.
932         (main): Hook up the new signals.
933         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
934         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
935         dumping multiple times.
936         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
937         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
938
939 2007-12-14  Anders Carlsson  <andersca@apple.com>
940
941         Reviewed by Brady.
942
943         Assert that a web frame that's loading a resource always has either a data source or 
944         a provisional data source.
945         
946         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
947         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
948
949 2007-12-14  Darin Adler  <darin@apple.com>
950
951         - fix mistake causing nearly all tests to fail on Windows
952
953         * DumpRenderTree/win/UIDelegate.cpp:
954         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
955         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
956
957         * DumpRenderTree/mac/UIDelegate.mm:
958         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
959         than passing the entire message.
960
961 2007-12-14  Darin Adler  <darin@apple.com>
962
963         - fix Tiger build
964
965         * DumpRenderTree/mac/UIDelegate.mm:
966         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
967         new-to-Leopard methods.
968
969 2007-12-14  Darin Adler  <darin@apple.com>
970
971         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
972         since it now triggers unwanted icon loading. We only had it because we implemented "all"
973         delegate methods here.
974
975 2007-12-14  Anders Carlsson  <andersca@apple.com>
976
977         Reviewed by Darin and Geoff.
978
979         <rdar://problem/5619295> 
980         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
981         
982         Add property getting methods to the plug-in.
983         
984         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
985         (pluginInvoke):
986
987 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
988
989         Reviewed by Darin.
990
991         - Layout test fix for mac. When dumped to the console local file paths
992         now only show the name of the resource not the whole path.  This is to
993         make the results machine and OS independent.
994
995         * DumpRenderTree/mac/UIDelegate.mm:
996         (-[UIDelegate webView:addMessageToConsole:]):
997
998 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
999
1000         Reviewed by Adam.
1001
1002         - Layout tests fix.  We need a way to remove machine-dependent
1003         information from paths in layout test results. The UIDelegate now does
1004         this.
1005
1006         * DumpRenderTree/DumpRenderTree.h:
1007         * DumpRenderTree/win/DumpRenderTree.cpp:
1008         (urlSuitableForTestResult):
1009         * DumpRenderTree/win/DumpRenderTreeWin.h:
1010         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1011         * DumpRenderTree/win/UIDelegate.cpp:
1012         (UIDelegate::webViewAddMessageToConsole):
1013
1014 2007-12-13  Alp Toker  <alp@atoker.com>
1015
1016         Build fix for DRT breakage introduced in r28690.
1017
1018         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1019         (LayoutTestController::pathToLocalResource):
1020
1021 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
1022
1023         Reviewed by Alice and Sam.
1024
1025         - <rdar://5621435> Need a way to specify local resources (being loaded
1026         from HTTP tests) on Windows.
1027         - Implemented pathToLocalResource which exposes the functionality of
1028         converting a given unix path to the correct location on Windows.
1029
1030         * DumpRenderTree/LayoutTestController.cpp:
1031         (pathToLocalResourceCallback):
1032         (LayoutTestController::staticFunctions):
1033         * DumpRenderTree/LayoutTestController.h:
1034         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1035         (LayoutTestController::pathToLocalResource):
1036         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1037         (LayoutTestController::pathToLocalResource):
1038
1039 2007-12-12  Anders Carlsson  <andersca@apple.com>
1040
1041         Reviewed by Sam.
1042
1043         <rdar://problem/5132003>
1044         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
1045
1046         * DumpRenderTree/win/DumpRenderTree.cpp:
1047         (main):
1048         Set the resource load delegate.
1049         
1050         * DumpRenderTree/win/DumpRenderTree.vcproj:
1051         
1052         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
1053         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
1054
1055 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
1056
1057         Reviewed by Adam Roben.
1058
1059         Fix conversion from double to LPARAM in dispatchMessage().
1060
1061         * DumpRenderTree/win/EventSender.cpp:
1062         (dispatchMessageCallback):
1063
1064 2007-12-11  Dan Bernstein  <mitz@apple.com>
1065
1066         Reviewed by Mark Rowe and Sam Weinig too!
1067
1068         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
1069           fonts DumpRenderTree registers.
1070
1071         * DumpRenderTree/win/DumpRenderTree.cpp:
1072         (initialize):
1073
1074 2007-12-11  Brady Eidson  <beidson@apple.com>
1075
1076         Reviewed by Anders
1077
1078         Make DumpRenderTree on mac use its own path for Databases testing
1079
1080         * DumpRenderTree/mac/DumpRenderTree.mm:
1081         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
1082           for future DRT-only use, then use it to construct the Databases path and set that default
1083
1084 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
1085
1086         Reviewed by Darin.
1087
1088         <rdar://problem/5535636>
1089         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1090
1091         http://bugs.webkit.org/show_bug.cgi?id=13916
1092         JavaScript detects Tab as a character input on a textfield validation
1093
1094         * DumpRenderTree/mac/EventSendingController.mm:
1095         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
1096         Dispatch a keyup to better match what happens when a key is physically pressed.
1097
1098         * DumpRenderTree/win/EventSender.cpp:
1099         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
1100         returning from keyDown().
1101         (getConstantCallback): Fixed a couple copy/paste mistakes.
1102
1103 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
1104
1105         Reviewed by Oliver.
1106
1107         - <rdar://5599845> Drosera: Does not show loal files in the file list
1108         on the left side.
1109
1110         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
1111         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
1112         so the open source community can build.
1113
1114 2007-12-10  Brady Eidson  <beidson@apple.com>
1115
1116         Rubberstamped by Sam Weinig
1117
1118         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
1119
1120         * DumpRenderTree/mac/UIDelegate.mm:
1121         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1122         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1123
1124 2007-12-08  Oliver Hunt  <oliver@apple.com>
1125
1126         Reviewed by Sam W.
1127
1128         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1129         
1130         Fixes <rdar://problem/5620249> Must disable SVG animation
1131         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1132         
1133         In order to allow finer grained control over the set of SVG features
1134         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
1135         distinct flags:
1136         ENABLE_SVG_ANIMATION
1137         ENABLE_SVG_FILTERS
1138         ENABLE_SVG_FONTS
1139         ENABLE_SVG_AS_IMAGE
1140         ENABLE_SVG_USE
1141         
1142         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
1143         
1144         Script handles all the new build flags, and allows --svg-experimental
1145         to automatically enable all features.
1146
1147         * Scripts/build-webkit:
1148
1149 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1150
1151         Fix version parsing.
1152
1153         Rubber-stamped by Oliver.
1154
1155         * Drosera/win/Drosera.vcproj/auto-version.sh:
1156
1157 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1158
1159         Build modifications for Drosera.
1160
1161         Reviewed by Adam.
1162
1163         * Drosera/DroseraWin.make: Added.
1164         * Drosera/win/Drosera.vcproj/Drosera.rc:
1165         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1166         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
1167         * Drosera/win/Drosera.vcproj/VERSION: Added.
1168         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
1169
1170 2007-12-06  Adam Roben  <aroben@apple.com>
1171
1172         Explicitly turn on the Mac font ascent hack on Windows
1173
1174         This keeps our font metrics matching those from Mac.
1175
1176         Reviewed by Hyatt.
1177
1178         * DumpRenderTree/win/DumpRenderTree.cpp:
1179         (main):
1180
1181 2007-12-06  Anders Carlsson  <andersca@apple.com>
1182
1183         Rename main.c to main.cpp here too.
1184         
1185         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
1186
1187 2007-12-06  Sam Weinig  <sam@webkit.org>
1188
1189         Rubber stamped by Geoff.
1190
1191         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
1192
1193 2007-12-06  Darin Adler  <darin@apple.com>
1194
1195         * Scripts/do-webcore-rename: Some more renaming plans.
1196
1197 2007-12-06  Anders Carlsson  <andersca@apple.com>
1198
1199         Restore implementation of testGetIntIdentifier that was accidentally
1200         removed somehow (possibly when I made PluginObject be a cpp file).
1201         
1202         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1203         (pluginInvoke):
1204
1205 2007-12-05  Anders Carlsson  <andersca@apple.com>
1206
1207         Make the entry points extern "C".
1208         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1209         
1210 2007-12-05  Anders Carlsson  <andersca@apple.com>
1211
1212         C++ warning fixes.
1213         
1214         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1215         (NPP_New):
1216         (NPP_Destroy):
1217         (NPP_SetWindow):
1218         (NPP_NewStream):
1219         (NPP_HandleEvent):
1220         (NPP_URLNotify):
1221         (NPP_GetValue):
1222
1223 2007-12-05  Anders Carlsson  <andersca@apple.com>
1224
1225         Add the .cpp files to the TestNetscapePlugIn target.
1226
1227         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1228
1229 2007-12-05  Anders Carlsson  <andersca@apple.com>
1230
1231         Reviewed by Geoff.
1232         
1233         Rename the TestNetscapePlugIn .c files to be .cpp.
1234
1235         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1236         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
1237         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
1238         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
1239         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
1240         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
1241         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
1242         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1243
1244 2007-12-05  Adam Roben  <aroben@apple.com>
1245
1246         Fix case of keypresses from the Windows implementation of eventSender.keyDown
1247
1248         This fixes several regression tests.
1249
1250         Reviewed by Alice.
1251
1252         * DumpRenderTree/win/EventSender.cpp:
1253         (keyDownCallback): Virtual keycodes for ASCII characters are always
1254         uppercase, so we need to check the case of the original character
1255         passed in to eventSender.keyDown.
1256
1257 2007-12-05  Adam Roben  <aroben@apple.com>
1258
1259         Learn from Tim's mistakes
1260
1261         * DumpRenderTree/win/DumpRenderTree.cpp:
1262         (runTest): Reset the authorAndUserStylesEnabled preference for each
1263         test.
1264
1265 2007-12-05  Alp Toker  <alp@atoker.com>
1266
1267         Reviewed by Mark Rowe.
1268
1269         Initialize GTK+ and WebKit so the tests can run.
1270
1271         Reorganize the headers a little.
1272
1273         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1274         (main):
1275
1276 2007-12-04  Anders Carlsson  <andersca@apple.com>
1277
1278         Remove IWebScriptScope include.
1279         
1280         * Drosera/win/DebuggerDocumentPlatform.cpp:
1281
1282 2007-12-04  Sam Weinig  <sam@webkit.org>
1283
1284         Rubber stamped by Mark Rowe.
1285
1286         Define CF as platform for mac and revert r28409
1287
1288         * DumpRenderTree/DumpRenderTree.h:
1289         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1290
1291 2007-12-04  Sam Weinig  <sam@webkit.org>
1292
1293         Define CF as platform for windows.
1294
1295         Reviewed by Adam Roben.
1296
1297         * DumpRenderTree/win/DumpRenderTreeWin.h:
1298
1299 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
1300
1301         Reviewed by Adam and Darin.
1302
1303         - Removed a needless BSTR cleanup.
1304
1305         * Drosera/win/DebuggerDocumentPlatform.cpp:
1306         (DebuggerDocument::getPlatformCurrentFunctionStack):
1307
1308 2007-11-27  Adam Roben  <aroben@apple.com>
1309
1310         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
1311
1312         Reviewed by Maciej.
1313
1314         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1315         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
1316
1317 2007-12-04  Alp Toker  <alp@atoker.com>
1318
1319         Prospective Win DRT build fix.
1320
1321         * DumpRenderTree/DumpRenderTree.h:
1322
1323 2007-12-04  Alp Toker  <alp@atoker.com>
1324
1325         Fix a clobbered copyright header.
1326
1327         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1328
1329 2007-12-04  Xan Lopez  <xan@gnome.org>
1330
1331         Reviewed by Alp Toker.
1332
1333         http://bugs.webkit.org/show_bug.cgi?id=15561
1334         GTK port needs DumpRenderTree implementation
1335
1336         Start work on the GTK+ DRT.
1337
1338         This does not work yet, and there are a few lingering style issues
1339         (nothing major) but this patch has been stuck in the bug tracker for
1340         too long already.
1341
1342         * DumpRenderTree/DumpRenderTree.h:
1343         * DumpRenderTree/gtk: Added.
1344         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
1345         (autocorrectURL):
1346         (shouldLogFrameLoadDelegates):
1347         (dumpFrameScrollPosition):
1348         (displayWebView):
1349         (appendString):
1350         (dumpFramesAsText):
1351         (dumpRenderTreeAsText):
1352         (dump):
1353         (runTest):
1354         (main):
1355         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
1356         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
1357         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
1358         (GCController::collect):
1359         (GCController::collectOnAlternateThread):
1360         (GCController::getJSObjectCount):
1361         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
1362         (LayoutTestController::~LayoutTestController):
1363         (LayoutTestController::addDisallowedURL):
1364         (LayoutTestController::clearBackForwardList):
1365         (LayoutTestController::copyDecodedHostName):
1366         (LayoutTestController::copyEncodedHostName):
1367         (LayoutTestController::display):
1368         (LayoutTestController::keepWebHistory):
1369         (LayoutTestController::notifyDone):
1370         (LayoutTestController::queueBackNavigation):
1371         (LayoutTestController::queueForwardNavigation):
1372         (LayoutTestController::queueLoad):
1373         (LayoutTestController::queueReload):
1374         (LayoutTestController::queueScript):
1375         (LayoutTestController::setAcceptsEditing):
1376         (LayoutTestController::setCustomPolicyDelegate):
1377         (LayoutTestController::setMainFrameIsFirstResponder):
1378         (LayoutTestController::setTabKeyCyclesThroughElements):
1379         (LayoutTestController::setUseDashboardCompatibilityMode):
1380         (LayoutTestController::setUserStyleSheetEnabled):
1381         (LayoutTestController::setUserStyleSheetLocation):
1382         (LayoutTestController::setWindowIsKey):
1383         (LayoutTestController::setWaitToDump):
1384         (LayoutTestController::windowCount):
1385         (LayoutTestController::setPrivateBrowsingEnabled):
1386         (LayoutTestController::setAuthorAndUserStylesEnabled):
1387         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
1388         (JSStringCopyUTF8CString):
1389         (LoadItem::invoke):
1390         (ReloadItem::invoke):
1391         (ScriptItem::invoke):
1392         (BackForwardItem::invoke):
1393
1394 2007-12-03  Sam Weinig  <sam@webkit.org>
1395
1396         Move JavaScriptCore thread testing code to pthread specific directory
1397         and remove the dependance on CoreFoundation by using WTF::HashSet.
1398
1399         Reviewed by Geoff and Oliver.
1400
1401         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1402         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
1403         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
1404         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
1405         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
1406         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
1407         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
1408         * DumpRenderTree/pthreads: Added.
1409         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
1410         (javaScriptThreads):
1411         (runJavaScriptThread):
1412         (startJavaScriptThreads):
1413         (stopJavaScriptThreads):
1414
1415 2007-12-03  Andrew Bonventre  <andybons@google.com>
1416
1417         Reviewed by Darin Adler.
1418
1419         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
1420         Symbol lookup menu broken in debugger view
1421
1422         * Drosera/debugger.js: Fixed javascript error where document property
1423         should have been used instead of contentDocument in switchFunction that
1424         was breaking the select symbol dropdown menu.  This is because
1425         window.frames will return a Window object and not a frame object like
1426         the author was originally expecting.
1427
1428 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
1429
1430         Reviewed by Adam.
1431
1432         - <rdar://5618942> Drosera: Console window does not process everything
1433         correctly.
1434         - <rdar://5619005> Drosera: could be sped up by moving the 
1435         WebScriptScope stuff into the WebScriptCallFrame.
1436         - Now the console can correctly process objects and does not receive
1437         notifications from JavaScriptCore about the JavaScript in Drosera's
1438         own process.
1439
1440         * Drosera/win/DebuggerDocumentPlatform.cpp:
1441         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1442         (DebuggerDocument::platformValueForScopeVariableNamed):
1443
1444 2007-12-03  Stephanie  <slewis@apple.com>
1445
1446         Reviewed by Darin.
1447
1448         Check to see if we are building a debug root
1449
1450         * Scripts/check-for-global-initializers: 
1451
1452 2007-12-03  Dan Bernstein  <mitz@apple.com>
1453
1454         Reviewed by Darin Adler.
1455
1456         - added a testGetIntIdentifier() method to TestNetscapePlugIn
1457
1458         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1459         (pluginInvoke):
1460
1461 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
1462
1463         Reviewed by Oliver.
1464
1465         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
1466         in a more fine-grained manner than eventSender.keyDown().
1467
1468         * DumpRenderTree/win/EventSender.cpp:
1469         (getConstantCallback):
1470         (dispatchMessageCallback):
1471
1472 2007-12-02  Darin Adler  <darin@apple.com>
1473
1474         * Scripts/do-webcore-rename: More planned renaming.
1475
1476 2007-12-02  Sam Weinig  <sam@webkit.org>
1477
1478         Rubber stamped by Anders.
1479
1480         Use [NSURL absoluteString] instead of [NSURL description] in order to get
1481         more uniform results cross platform.
1482
1483         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1484         (-[NSURL _drt_descriptionSuitableForTestResult]):
1485
1486 2007-12-02  Sam Weinig  <sam@webkit.org>
1487
1488         Rubber stamped by Niko.
1489
1490         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
1491
1492         * DumpRenderTree/win/DumpRenderTree.cpp:
1493         * DumpRenderTree/win/DumpRenderTree.vcproj:
1494         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
1495         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
1496         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
1497         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
1498
1499 2007-12-01  Alp Toker  <alp@atoker.com>
1500
1501         Reviewed by Adam Roben.
1502
1503         Make use of the newly introduced webkit.h convenience header.
1504
1505         * GtkLauncher/main.c:
1506
1507 2007-12-01  Adam Treat  <treat@kde.org>
1508
1509         Reviewed by Simon.
1510
1511         * Check to see if the directory exists and exit if not.
1512
1513         * DumpRenderTree/qt/main.cpp:
1514         (main):
1515
1516 2007-12-01  Adam Treat  <treat@kde.org>
1517
1518         Reviewed by Simon.
1519
1520         * Don't hide symbols when in Debug mode
1521         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
1522
1523
1524         * DumpRenderTree/qt/main.cpp:
1525         (messageHandler):
1526
1527 2007-11-30  Alp Toker  <alp@atoker.com>
1528
1529         Reviewed by Adam Roben.
1530
1531         http://bugs.webkit.org/show_bug.cgi?id=15691
1532         [GTK] Public API does not follow GTK+ conventions
1533
1534         Refactor the WebKit/GTK+ public API. Changes:
1535           WebKitPage -> WebKitWebView
1536           WebKitFrame -> WebKitWebFrame
1537
1538         Public API source and header names have been updated to mirror the API
1539         changes.
1540
1541         The API is now kept in WebKit/gtk/WebView to match other ports in the
1542         same class such as Mac and Win.
1543
1544         * GtkLauncher/main.c:
1545         (activate_uri_entry_cb):
1546         (link_hover_cb):
1547         (title_change_cb):
1548         (progress_change_cb):
1549         (go_back_cb):
1550         (go_forward_cb):
1551         (create_browser):
1552         (main):
1553
1554 2007-11-30  Adam Roben  <aroben@apple.com>
1555
1556         Hopefully the final build fix
1557
1558         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
1559         pull in WTF's assertion/logging functions.
1560
1561 2007-11-30  Adam Roben  <aroben@apple.com>
1562
1563         Another build fix
1564
1565         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
1566         WebKit.lib.
1567
1568 2007-11-30  Adam Roben  <aroben@apple.com>
1569
1570         Debug build fix
1571
1572         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
1573         configuration.
1574         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
1575         projects.
1576         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
1577         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
1578         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
1579
1580 2007-11-30  Sam Weinig  <sam@webkit.org>
1581
1582         Reviewed by Adam Roben.
1583
1584         Fix drawSelectionRect to actually draw the selection rect.
1585
1586         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1587         (drawSelectionRect):
1588
1589 2007-11-30  Darin Adler  <darin@apple.com>
1590
1591         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
1592
1593 2007-11-30  Darin Adler  <darin@apple.com>
1594
1595         * Scripts/do-webcore-rename: Get ready for some future renaming.
1596
1597 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1598
1599         Reviewed by Adam.
1600
1601         - Removed some unnecessary functions and changed an unused return type. 
1602
1603         * Drosera/win/DebuggerClient.cpp:
1604         (registerConsoleClass):
1605         * Drosera/win/DebuggerClient.h:
1606         * Drosera/win/Drosera.cpp:
1607         (registerDroseraClass):
1608
1609 2007-11-28  Alp Toker  <alp@atoker.com>
1610
1611         Reviewed by Timothy Hatcher.
1612
1613         http://bugs.webkit.org/show_bug.cgi?id=16174
1614         [GTK] Use "URI" not "URL" in public API
1615
1616         Replace use of the term "URL" with "URI" in public headers,
1617         documentation and some internal code to match GLib/GTK+ convention.
1618
1619         This is now mentioned in the API guidelines:
1620           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
1621
1622         * GtkLauncher/main.c:
1623         (activate_uri_entry_cb):
1624         (title_change_cb):
1625         (create_toolbar):
1626         (main):
1627
1628 2007-11-29  Anders Carlsson  <andersca@apple.com>
1629
1630         Reviewed by Sam.
1631
1632         <rdar://problem/5230478>
1633         FrameLoadDelegate callbacks are not dumped in DRT.
1634         
1635         * DumpRenderTree/win/DumpRenderTree.cpp:
1636         (shouldLogFrameLoadDelegates):
1637         (runTest):
1638         (main):
1639         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1640         (BSTRtoString):
1641         (descriptionSuitableForTestResult):
1642         (FrameLoadDelegate::QueryInterface):
1643         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1644         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1645         (FrameLoadDelegate::didCommitLoadForFrame):
1646         (FrameLoadDelegate::didFinishLoadForFrame):
1647         (FrameLoadDelegate::willCloseFrame):
1648         (FrameLoadDelegate::didClearWindowObject):
1649         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1650         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1651         * DumpRenderTree/win/FrameLoaderDelegate.h:
1652         (FrameLoadDelegate::windowScriptObjectAvailable):
1653         (FrameLoadDelegate::didFirstLayoutInFrame):
1654
1655 2007-11-29  Sam Weinig  <sam@webkit.org>
1656
1657         Reviewed by Anders.
1658
1659         Add database quota UIDelegates methods to DRT UIDelegate.
1660
1661         * DumpRenderTree/mac/UIDelegate.mm:
1662         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1663         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
1664
1665 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1666
1667         Reviewed by Sam.
1668
1669         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
1670         dying and vice versa.
1671         - This fix will allow Drosera and Safari to reconnect if either of them
1672         closes correctly, but does not fix the case where one of them dies
1673         silently.
1674
1675         * Drosera/win/ServerConnection.cpp:
1676         (ServerConnection::attemptToCreateServerConnection): Added a safety
1677         check, because it's possilbe to try to connect to a server that's dying.
1678         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
1679         the server has died.
1680         * Drosera/win/ServerConnection.h: Added the new function and removed
1681         an unnecessary member.
1682
1683 2007-11-29  Anders Carlsson  <andersca@apple.com>
1684
1685         * DumpRenderTree/win/DumpRenderTree.vcproj:
1686         Add shlwapi.lib to all configurations.
1687
1688 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1689
1690         - Build fix.  Added additional includes for VS Express to the Release
1691         project.
1692
1693         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1694
1695 2007-11-29  Anders Carlsson  <andersca@apple.com>
1696
1697         Reviewed by Adam.
1698
1699         <rdar://problem/5132005>
1700         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
1701         
1702         * DumpRenderTree/win/DumpRenderTree.vcproj:
1703         Add shlwapi.lib
1704         
1705         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1706         (LayoutTestController::setUserStyleSheetEnabled):
1707         Implement this.
1708         
1709         (appendComponentToPath):
1710         New method which wraps the Win32 API PathAppend.
1711         
1712         (followShortcuts):
1713         New method which checks if a file points to a shortcut and
1714         follows the shortcut.
1715         
1716         (resolveCygwinPath):
1717         New method that takes a cygwin unix-style path and returns the Win32 path.
1718         
1719         (cfStringRefToWString):
1720         
1721         (LayoutTestController::setUserStyleSheetLocation):
1722         Implement this.
1723
1724 2007-11-29  Alice Liu  <alice.liu@apple.com>
1725
1726         Reviewed by Adam.
1727
1728         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
1729
1730         * DumpRenderTree/win/EventSender.cpp:
1731         (keyDownCallback):
1732         uppercase letters were being sent as lowercase letters without the shift key down.
1733
1734 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1735
1736         - Windows build fix. VS express needs some love.
1737
1738         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1739
1740 2007-11-28  Darin Adler  <darin@apple.com>
1741
1742         Reviewed by Adam Roben.
1743
1744         * DumpRenderTree/mac/EventSendingController.mm:
1745         (-[EventSendingController keyDown:withModifiers:]):
1746         Send capital letters through as lowercase letters with the shift key down
1747         rather than sending them as if they were highly unusual "capital letter keys".
1748
1749         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1750         where you need to update results and more tests are failing than before.
1751
1752 2007-11-28  Anders Carlsson  <andersca@apple.com>
1753
1754         Reviewed by Darin.
1755
1756         <rdar://problem/5132001>
1757         contextClick is not implemented in DRT on Windows.
1758         
1759         * DumpRenderTree/win/EventSender.cpp:
1760         (contextClickCallback):
1761         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1762         by a WM_RBUTTONUP message.
1763         
1764         * DumpRenderTree/win/UIDelegate.cpp:
1765         (UIDelegate::hasCustomMenuImplementation):
1766         (UIDelegate::trackCustomPopupMenu):
1767         * DumpRenderTree/win/UIDelegate.h:
1768         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1769         menu from being shown (and causing the DRT to hang).
1770
1771 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1772
1773         Reviewed by Darin.
1774
1775         Fix DumpRenderTree ObjC bug comparing strings.
1776
1777         * DumpRenderTree/mac/ObjCController.m:
1778         (-[ObjCController identityIsEqual::]): Compare strings with string
1779         equality instead of identiy equality.
1780
1781 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1782
1783         Reviewed by Sam.
1784
1785         Reset the authorAndUserStylesEnabled preference
1786         back to YES for each test. Fixes the broken tests.
1787
1788         * DumpRenderTree/mac/DumpRenderTree.mm:
1789         (resetWebViewToConsistentStateBeforeTesting):
1790
1791 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1792
1793         Reviewed by Adam.
1794
1795         - Drosera now displays the console window, although it cannot currently
1796         process JavaScript.
1797
1798         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1799         (registerConsoleClass): Implemented.
1800         (consoleWndProc): Implemented.
1801         (DebuggerClient::onSize): Implemented.
1802         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1803         new window.
1804         * Drosera/win/DebuggerClient.h: Added needed method and members for 
1805         creating and maintaining a new window.
1806         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1807         lines of code to more appropriate places.
1808         (Drosera::handleCommand):
1809         (Drosera::initUI):
1810         (Drosera::onSize):
1811         (Drosera::attach):
1812
1813 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1814
1815         Reviewed by Dave Hyatt.
1816
1817         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1818         
1819         Add support for disabling author and user styles for testing.
1820
1821         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1822         * DumpRenderTree/LayoutTestController.cpp:
1823         (setAuthorAndUserStylesEnabledCallback):
1824         (LayoutTestController::staticFunctions):
1825         * DumpRenderTree/LayoutTestController.h:
1826         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1827         (LayoutTestController::setAuthorAndUserStylesEnabled):
1828         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1829         (LayoutTestController::setAuthorAndUserStylesEnabled):
1830
1831 2007-11-26  Dan Bernstein  <mitz@apple.com>
1832
1833         - Tiger build fix.
1834
1835         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1836
1837 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1838
1839         Reviewed by Maciej.
1840
1841         - Implemented displaying variables for Drosera on Win.
1842
1843         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1844         that retrieve variables to not hold onto the return value since it's
1845         not returned.  Also changed to use the new signatures of the retrieval
1846         functions.
1847         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1848         (DebuggerDocument::platformValueForScopeVariableNamed):
1849         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1850         (droseraWndProc):
1851
1852 2007-11-26  Sam Weinig  <sam@webkit.org>
1853
1854         Cleanup names of painting and repainting functions.
1855
1856         Reviewed by Adam Roben.
1857
1858         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1859         (drawSelectionRect): was drawSelectionRectIntoContext.
1860         (dumpWebViewAsPixelsAndCompareWithExpected):
1861         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1862         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1863         (paintWebView): was drawWebViewIntoContext.
1864         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1865
1866 2007-11-26  Sam Weinig  <sam@webkit.org>
1867
1868         Reviewed by Dan Bernstein.
1869
1870         - Leopard build fix
1871
1872         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1873
1874 2007-11-26  Sam Weinig  <sam@webkit.org>
1875
1876         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1877         Use shared PixelDumpSupport for Mac DRT
1878
1879         Reviewed by Adam Roben.
1880
1881         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1882         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1883         * DumpRenderTree/cg/ImageDiffCG.cpp:
1884         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1885         (drawSelectionRectIntoContext):
1886         (dumpWebViewAsPixelsAndCompareWithExpected):
1887         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1888         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1889         * DumpRenderTree/mac/DumpRenderTree.mm:
1890         (dump):
1891         * DumpRenderTree/mac/ImageDiff.m: Removed.
1892         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1893         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1894         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1895         (setDefaultColorProfileToRGB):
1896         (getBitmapContextFromWebView):
1897         (drawWebViewIntoContext):
1898         (repaintWithVerticalSweep):
1899         (repaintWithHorizontalSweep):
1900         (getSelectionRect):
1901         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1902
1903 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1904
1905         Bug 16052: prepare-ChangeLog doesn't report deleted files
1906         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1907
1908         Reviewed by Sam.
1909
1910         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1911
1912 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1913
1914         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1915         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1916
1917         Reviewed by Adam.
1918
1919         Roll functionality of merge-changelog into resolve-ChangeLogs
1920         script.  The script now checks for ChangeLog.rej and
1921         ChangeLog.orig files first.  If it finds them, it uses the
1922         ChangeLog.rej file as a patch (in old contextual diff format) to
1923         apply with --fuzz=3.
1924
1925         * Scripts/merge-changelog: Removed.
1926         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1927
1928 2007-11-25  Sam Weinig  <sam@webkit.org>
1929
1930         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1931
1932         Reviewed by Mark Rowe.
1933
1934         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1935         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1936         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1937         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1938         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1939
1940 2007-11-25  Sam Weinig  <sam@webkit.org>
1941
1942         Convert DumpRenderTree to ues .xcconfig files.
1943
1944         Reviewed by Mark Rowe.
1945
1946         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1947         * DumpRenderTree/mac/Configurations: Added.
1948         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1949         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1950         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1951
1952 2007-11-25  Sam Weinig  <sam@webkit.org>
1953
1954         Add ForwardingHeaders to wtf for DumpRenderTree.
1955
1956         Reviewed by Mark Rowe.
1957
1958         * DumpRenderTree/DumpRenderTree.h:
1959         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1960         * DumpRenderTree/ForwardingHeaders: Added.
1961         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1962         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1963         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1964         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1965         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1966         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1967         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1968         * DumpRenderTree/LayoutTestController.cpp:
1969         * DumpRenderTree/WorkQueue.cpp:
1970         * DumpRenderTree/mac/DumpRenderTree.mm:
1971         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1972         * DumpRenderTree/mac/JavaScriptThreading.cpp:
1973         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1974         * DumpRenderTree/mac/ObjCController.m:
1975         * DumpRenderTree/mac/UIDelegate.mm:
1976         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1977
1978 2007-11-25  Adam Roben  <aroben@apple.com>
1979
1980         Fix some test failures caused by r28019
1981
1982         Now that stdout is in binary mode, we need to always use printf
1983         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1984         the output.
1985
1986         Reviewed by Sam.
1987
1988         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1989         printf.
1990         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1991         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1992         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1993         (UIDelegate::webViewAddMessageToConsole):
1994
1995 2007-11-25  Adam Roben  <aroben@apple.com>
1996
1997         Set the font smoothing preference in DRT
1998
1999         This makes the pixel results on Windows closer to the Mac results.
2000
2001         Reviewed by Mitz.
2002
2003         * DumpRenderTree/win/DumpRenderTree.cpp:
2004         (initializePreferences):
2005
2006 2007-11-25  Adam Roben  <aroben@apple.com>
2007
2008         Port ImageDiff to CG and C++
2009
2010         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
2011         <rdar://5071708>
2012
2013         Reviewed by Sam.
2014
2015         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
2016         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
2017         (main):
2018         (createImageFromStdin):
2019         (compareImages):
2020         (getDifferenceBitmap):
2021         (computePercentageDifferent):
2022         * DumpRenderTree/win/ImageDiff.vcproj: Added.
2023
2024 2007-11-25  Adam Roben  <aroben@apple.com>
2025
2026         Fix image diff link generation on Windows
2027
2028         Reviewed by Sam.
2029
2030         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
2031         to toURL.
2032
2033 2007-11-25  Adam Roben  <aroben@apple.com>
2034
2035         Implement pixel dumping in Windows DRT
2036
2037         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
2038         <rdar://5071708>
2039
2040         Reviewed by Sam.
2041
2042         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
2043         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
2044         Content-Length header.
2045         (getMD5HashStringForBitmap):
2046         (dumpWebViewAsPixelsAndCompareWithExpected):
2047         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
2048         * DumpRenderTree/win/DumpRenderTree.cpp:
2049         (dump): Do a pixel dump if requested.
2050         (main): Parse pixel test options.
2051         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
2052         the cg/ subdirectory to the include path.
2053         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
2054         available in a header or import library, so we have to go through this
2055         LoadLibrary/GetProcAddress dance to use them.
2056         (cryptDLL):
2057         (init):
2058         (update):
2059         (final):
2060         (MD5_Init):
2061         (MD5_Update):
2062         (MD5_Final):
2063         * DumpRenderTree/win/MD5.h: Added.
2064         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
2065         moved up to the top level to share it with Mac eventually.
2066         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
2067         (getBitmapContextFromWebView): Forces the WebView to paint using a
2068         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
2069
2070 2007-11-25  Adam Roben  <aroben@apple.com>
2071
2072         Clean up Windows DRT's option parsing a little bit
2073
2074         Reviewed by Sam.
2075
2076         * DumpRenderTree/win/DumpRenderTree.cpp:
2077         (main): Put non-option arguments into a Vector.
2078
2079 2007-11-25  Adam Roben  <aroben@apple.com>
2080
2081         Make Windows DRT stop changing LF into CRLF
2082
2083         Reviewed by Sam.
2084
2085         * DumpRenderTree/win/DumpRenderTree.cpp:
2086         (main): Put stdout in binary mode.
2087         * Scripts/run-webkit-tests: Remove the CRLF hack.
2088
2089 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
2090
2091         Removed empty directory.
2092
2093         * Scripts/resources: Removed.
2094
2095 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
2096
2097         Fix bisect-builds to work with recent WebKit nightly builds.
2098
2099         Reviewed by Dan.
2100
2101         * Scripts/bisect-builds: Check for the 
2102         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
2103         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
2104         to WebKit.app/Contents/Resources.
2105
2106 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
2107
2108         Reviewed by Maciej.
2109
2110         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
2111         not closed (affects digg.com)
2112
2113         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
2114         one after finishing with a test to avoid having its delayed onload handler firing when
2115         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
2116         but it helps somewhat.
2117
2118 2007-11-22  Mark Rowe  <mrowe@apple.com>
2119
2120         Reviewed by Alp Toker.
2121
2122         Fix build-webkit to propagate make's exit status if it fails.
2123
2124         * Scripts/webkitdirs.pm:
2125
2126 2007-11-22  Dan Bernstein  <mitz@apple.com>
2127
2128         Reviewed by Mark Rowe.
2129
2130         - fix crash when running pixel tests
2131
2132         * DumpRenderTree/mac/DumpRenderTree.mm:
2133         (dumpRenderTree): Parse the command line options before setting up the
2134         environment so that we know if we need to set up the pixel dump
2135         machinery.
2136
2137 2007-11-21  Eric Seidel  <eric@webkit.org>
2138
2139         Speculative build fix for Tiger.
2140
2141         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
2142
2143 2007-11-21  Eric Seidel  <eric@webkit.org>
2144
2145         Reviewed by Tim Hatcher.
2146
2147         Break out more of DumpRenderTree.mm into individual files
2148
2149         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2150         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
2151         (checkedMalloc):
2152         (checkedRealloc):
2153         (makeLargeMallocFailSilently):
2154         * DumpRenderTree/mac/CheckedMalloc.h: Added.
2155         * DumpRenderTree/mac/DumpRenderTree.mm:
2156         (crashHandler):
2157         (dump):
2158         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2159         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2160         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2161         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2162         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2163         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
2164         (javaScriptThreads):
2165         (runJavaScriptThread):
2166         (startJavaScriptThreads):
2167         (stopJavaScriptThreads):
2168         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
2169         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
2170         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
2171         (restoreColorSpace):
2172         (setDefaultColorProfileToRGB):
2173         (initializeColorSpaceAndScreeBufferForPixelTests):
2174         (md5HashStringForBitmap):
2175         (dumpWebViewAsPixelsAndCompareWithExpected):
2176
2177 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
2178
2179         Move install-unix-extras to wx directory as it seems only to be used by that 
2180         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
2181         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
2182         have install-unix-extras install into WebKitLibraries as per
2183         convention.
2184         
2185         Reviewed by Mark Rowe.
2186
2187         * Scripts/install-unix-extras: Removed.
2188         * wx/build-wxwebkit:
2189         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
2190
2191 2007-11-21  Eric Seidel  <eric@webkit.org>
2192
2193         Reviewed by Adam.
2194
2195         More refactoring for greater code readability
2196
2197         * DumpRenderTree/mac/DumpRenderTree.mm:
2198         (initializeGlobalsFromCommandLineOptions):
2199         (initializeColorSpaceAndScreeBufferForPixelTests):
2200         (addTestPluginsToPluginSearchPath):
2201         (useLongRunningServerMode):
2202         (runTestingServerLoop):
2203         (prepareConsistentTestingEnvironment):
2204         (dumpRenderTree):
2205         (main):
2206         (dumpFramesAsText):
2207         (dumpBackForwardListForWebView):
2208         (sizeWebViewForCurrentTest):
2209         (methodNameStringForFailedTest):
2210         (dumpBackForwardListForAllWindows):
2211         (dumpWebViewAsPixelsAndCompareWithExpected):
2212         (invalidateAnyPreviousWaitToDumpWatchdog):
2213         (dump):
2214         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2215         * DumpRenderTree/mac/UIDelegate.mm:
2216         (-[UIDelegate webView:createWebViewWithRequest:]):
2217
2218 2007-11-21  Eric Seidel  <eric@webkit.org>
2219
2220         Reviewed by Tim Hatcher.
2221
2222         Abstract more of DRT into static methods
2223
2224         * DumpRenderTree/mac/DumpRenderTree.mm:
2225         (setDefaultsToConsistentValuesForTesting):
2226         (setupSignalHandlers):
2227         (allocateGlobalControllers):
2228         (releaseAndZero):
2229         (releaseGlobalControllers):
2230         (dumpRenderTree):
2231         (shouldLogFrameLoadDelegates):
2232         (createCFURLFromPathOrURL):
2233         (resetWebViewToConsistentStateBeforeTesting):
2234         (runTest):
2235
2236 2007-11-21  Eric Seidel  <eric@webkit.org>
2237
2238         Reviewed by Tim Hatcher.
2239
2240         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
2241
2242         * DumpRenderTree/DumpRenderTree.h:
2243         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2244         * DumpRenderTree/mac/DumpRenderTree.mm:
2245         (dumpRenderTree):
2246         (dump):
2247         (runTest):
2248         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
2249         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
2250         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
2251         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
2252         (-[DumpRenderTreePasteboard declareType:owner:]):
2253         (+[LocalPasteboard alloc]):
2254         (-[LocalPasteboard init]):
2255         (-[LocalPasteboard dealloc]):
2256         (-[LocalPasteboard name]):
2257         (-[LocalPasteboard releaseGlobally]):
2258         (-[LocalPasteboard declareTypes:owner:]):
2259         (-[LocalPasteboard addTypes:owner:]):
2260         (-[LocalPasteboard changeCount]):
2261         (-[LocalPasteboard types]):
2262         (-[LocalPasteboard availableTypeFromArray:]):
2263         (-[LocalPasteboard setData:forType:]):
2264         (-[LocalPasteboard dataForType:]):
2265         (-[LocalPasteboard setPropertyList:forType:]):
2266         (-[LocalPasteboard setString:forType:]):
2267         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
2268         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
2269         (+[DumpRenderTreeWindow allWindows]):
2270         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2271         (-[DumpRenderTreeWindow dealloc]):
2272         (-[DumpRenderTreeWindow isKeyWindow]):
2273         (-[DumpRenderTreeWindow keyDown:]):
2274
2275 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
2276
2277         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
2278         it indiscriminately copies any headers inside JavaScriptCore,
2279         which includes Tiger ICU headers. 
2280
2281         * wx/build-wxwebkit:
2282         Don't run WebCore/move-js-headers.sh any longer.
2283
2284 2007-11-20  Adam Treat  <treat@kde.org>
2285
2286         Reviewed by David Kilzer.
2287
2288         * Prepend git branch name to $baseProductDir
2289
2290         * Scripts/VCSUtils.pm:
2291         * Scripts/webkitdirs.pm:
2292
2293 2007-11-20  Mark Rowe  <mrowe@apple.com>
2294
2295         Reviewed by Simon Hausmann.
2296
2297         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
2298         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
2299         Have it trigger a "make distclean" rather than "make clean" to ensure that the
2300         built product and generated Makefile's are removed.
2301
2302 2007-11-19  Alp Toker  <alp@atoker.com>
2303
2304         Reviewed by Mark Rowe.
2305
2306         http://bugs.webkit.org/show_bug.cgi?id=16040
2307         [GTK] GtkLauncher should be written in C
2308
2309         Port GtkLauncher to plain C.
2310
2311         Use a more conventional GTK+ coding style.
2312
2313         Use a toolbar instead of menus.
2314
2315         Various signature fixes and cleanups.
2316
2317         Add a license header. Assume all previous modifications were copyright
2318         assigned to Apple Inc. by default.
2319
2320         * GtkLauncher/GtkLauncher.pro:
2321         * GtkLauncher/main.c: Added.
2322         (activate_url_entry_cb):
2323         (update_title):
2324         (link_hover_cb):
2325         (title_change_cb):
2326         (progress_change_cb):
2327         (destroy_cb):
2328         (go_back_cb):
2329         (go_forward_cb):
2330         (create_browser):
2331         (create_statusbar):
2332         (create_toolbar):
2333         (create_window):
2334         (main):
2335         * GtkLauncher/main.cpp: Removed.
2336
2337 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
2338
2339         Build script fixes to ensure they do the right thing for the 
2340         wx port, and update build-wxwebkit to reflect the way the
2341         build scripts now work.
2342
2343         Reviewed by Adam.
2344
2345         * Scripts/build-testkjs:
2346         * Scripts/build-webkit:
2347         * Scripts/run-javascriptcore-tests:
2348         * Scripts/webkitdirs.pm:
2349         * wx/build-wxwebkit:
2350
2351 2007-11-18  Eric Seidel  <eric@webkit.org>
2352
2353         Reviewed by Anders.
2354
2355         Make run-javascriptcore-tests report failures on exit (to support git bisect)
2356
2357         * Scripts/run-javascriptcore-tests:
2358
2359 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
2360
2361         Reviewed by Adam Roben.
2362
2363         Make run-webkit-tests work with Windows debug build.
2364
2365         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
2366         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
2367         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
2368         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
2369         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
2370
2371 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
2372
2373         Add wxWebKit sample and build script, and integrate it with 
2374         build-webkit. Also make build-webkit --clean work for all
2375         ports.
2376
2377         Reviewed by Darin Adler.
2378
2379         * Scripts/build-webkit:
2380         * Scripts/webkitdirs.pm:
2381         * wx: Added.
2382         * wx/browser: Added.
2383         * wx/browser/browser.bkl: Added.
2384         * wx/browser/browser.cpp: Added.
2385         * wx/build-wxwebkit: Added.
2386
2387 2007-11-17  Adam Roben  <aroben@apple.com>
2388
2389         Make it easy to run Safari in the debugger on Windows
2390
2391         I've added a new script, debug-safari, which launches Safari in the
2392         debugger. On OS X it just calls gdb-safari.
2393
2394         Reviewed by Mark Rowe.
2395
2396         * FindSafari/FindSafari.cpp:
2397         (_tmain): Added a /debugger flag, which in combination with
2398         /printSafariLauncher will print a script that launches Safari in the
2399         debugger.
2400         * Scripts/debug-safari: Added.
2401         * Scripts/run-safari: Changed to call runSafari().
2402         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
2403         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
2404         first argument along to FindSafari.
2405         * Scripts/webkitdirs.pm:
2406         (sub runSafari): Added.
2407
2408 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
2409
2410         Reviewed by Adam Roben.
2411
2412         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
2413
2414 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
2415
2416         Reviewed by David Kilzer.
2417
2418         The git config command was renamed to repo-config at some point. This
2419         change tries git config and then git repo-config if the first fails.
2420
2421         * Scripts/prepare-ChangeLog:
2422         (gitConfig):
2423
2424 2007-11-16  Dan Bernstein  <mitz@apple.com>
2425
2426         Reviewed by Darin Adler and Sam Weinig.
2427
2428         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
2429
2430         * DumpRenderTree/win/EventSender.cpp:
2431         (keyDownCallback): For characters that cannot be entered on the active
2432         keyboard layout, send a WM_CHAR message with the character along with
2433         a WM_KEYDOWN message with a virtual key code of 255.
2434
2435 2007-11-16  Mark Rowe  <mrowe@apple.com>
2436
2437         Reviewed by Tim Hatcher.
2438
2439         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
2440
2441         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2442         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2443
2444 2007-11-15  Adam Roben  <aroben@apple.com>
2445
2446         Make run-safari actually work on Windows
2447
2448         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
2449         chdir call.
2450
2451 2007-11-14  Adam Roben  <aroben@apple.com>
2452
2453         Updates to Safari launching now that 3.0.4 is released
2454
2455         Reviewed by Sam.
2456
2457         * FindSafari/FindSafari.cpp:
2458         (getWebViewCLSID): Use version-independent ProgID.
2459         * Scripts/run-safari: Use run-webkit-nightly.cmd.
2460
2461 2007-11-14  Anders Carlsson  <andersca@apple.com>
2462
2463         Reviewed by Adam.
2464
2465         <rdar://problem/5309081>
2466         In DRT, "plugin.logDestroy = true" not working on Windows.
2467         
2468         * DumpRenderTree/win/TestNetscapePlugin/main.c:
2469         (NPP_Destroy):
2470
2471 2007-11-14  Eric Seidel  <eric@webkit.org>
2472
2473         Reviewed by Sam.
2474
2475         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
2476
2477 2007-11-14  Anders Carlsson  <andersca@apple.com>
2478
2479         Reviewed by Adam.
2480
2481         <rdar://problem/5141186>
2482         window.layoutTestController.setWindowIsKey is not implemented in DRT.
2483         
2484         Implement setWindowIsKey.
2485         
2486         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2487         (LayoutTestController::setWindowIsKey):
2488
2489 2007-11-13  Sam Weinig  <sam@webkit.org>
2490
2491         Reviewed by Adam Roben.
2492
2493         Fix for <rdar://problem/5382579>
2494         http/tests/security/cross-frame-access-put.html reports large 
2495         negative numbers for screenLeft and screenTop (Mac reports "0")
2496
2497         * DumpRenderTree/win/UIDelegate.cpp:
2498         (UIDelegate::UIDelegate): Initialize the RECT.
2499         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
2500         (UIDelegate::webViewFrame): ditto.
2501         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
2502
2503 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
2504
2505         Reviewed by Adam.
2506
2507         - Make Drosera show source, source URLs, and function stack on Windows,
2508         and some minor fixes.
2509
2510         * Drosera/DebuggerDocument.cpp: Force source to always update display.
2511         (DebuggerDocument::updateFileSource):
2512         * Drosera/debugger.js: Force source to always update display.
2513         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
2514         menu controls.
2515         (DebuggerClient::resume):
2516         (DebuggerClient::pause):
2517         (DebuggerClient::stepInto):
2518         (DebuggerClient::stepOver):
2519         (DebuggerClient::stepOut):
2520         (DebuggerClient::showConsole):
2521         (DebuggerClient::closeCurrentFile):
2522         * Drosera/win/DebuggerClient.h: Ditto.
2523         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
2524         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
2525         removed two bugs.  1) caller could be in a bad state when asked to
2526         assign into it. 2) BSTRs were not created correctly.
2527         (DebuggerDocument::getPlatformCurrentFunctionStack):
2528         * Drosera/win/Drosera.cpp: Hook up the menu controls.
2529         (droseraWndProc):
2530         (handleCommand):
2531         (Drosera::resume):
2532         (Drosera::pause):
2533         (Drosera::stepInto):
2534         (Drosera::stepOver):
2535         (Drosera::stepOut):
2536         (Drosera::showConsole):
2537         (Drosera::closeCurrentFile):
2538         * Drosera/win/Drosera.h: Hook up the menu controls.
2539         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
2540         functions, added a null check, and fixed another bug where caller could
2541         be in a bad state when asked to assign into it.
2542         (ServerConnection::didLoadMainResourceForDataSource):
2543         (ServerConnection::getCallerFrame):
2544         * Drosera/win/ServerConnection.h: Safety first.
2545
2546 2007-11-13  Dan Bernstein  <mitz@apple.com>
2547
2548         Reviewed by Darin Adler.
2549
2550         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
2551           DumpRenderTree --pixel-tests renders each test twice
2552
2553         * DumpRenderTree/mac/DumpRenderTree.mm:
2554         (dumpRenderTree): Removed the --paint option because the painting code
2555         is always exercised as a result of
2556         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
2557         calling -displayIfNeeded.
2558         (dump): Changed to always grab the image from the window since the view
2559         is always displayed.
2560         (runTest):
2561         (displayWebView):
2562         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
2563         because it always paints.
2564
2565 2007-11-12  Antti Koivisto  <antti@apple.com>
2566
2567         Reviewed by Adele.
2568         
2569         Add support for http media tests
2570
2571         * Scripts/run-webkit-tests:
2572
2573 2007-11-12  Sam Weinig  <sam@webkit.org>
2574
2575         Reviewed by Adam Roben.
2576
2577         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
2578
2579         * DumpRenderTree/win/DumpRenderTree.cpp:
2580         (runTest):
2581         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2582         (LayoutTestController::setPrivateBrowsingEnabled):
2583
2584 2007-11-12  Adam Roben  <aroben@apple.com>
2585
2586         * Scripts/update-webkit-localizable-strings: Changed to only scan the
2587         mac and win subdirectories.
2588
2589 2007-11-11  Adam Roben  <aroben@apple.com>
2590
2591         Fix <rdar://5133816> keepWebHistory is not implemented
2592
2593         Fixes fast/history/clicked-link-is-visited.html.
2594
2595         Reviewed by Darin.
2596
2597         * DumpRenderTree/win/DumpRenderTree.cpp:
2598         (runTest): Clear the optionalSharedHistory.
2599         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2600         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
2601
2602 2007-11-10  Sam Weinig  <sam@webkit.org>
2603
2604         Reviewed by Tim Hatcher.
2605
2606         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
2607         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
2608         is turned on)
2609
2610         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
2611
2612         Added test: http/tests/security/cross-frame-access-private-browsing.html
2613
2614         * DumpRenderTree/LayoutTestController.cpp:
2615         (setPrivateBrowsingEnabledCallback):
2616         (LayoutTestController::staticFunctions):
2617         * DumpRenderTree/LayoutTestController.h:
2618         * DumpRenderTree/mac/DumpRenderTree.mm:
2619         (runTest): Default to private browsing disabled.
2620         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2621         (LayoutTestController::setPrivateBrowsingEnabled):
2622         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2623         (LayoutTestController::setPrivateBrowsingEnabled):
2624
2625 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2626
2627         Reviewed by Adam.
2628
2629         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
2630         WebCore's!
2631
2632         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2633         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
2634         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2635         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2636         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
2637         * Drosera/win/Drosera.cpp:
2638         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2639
2640 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2641
2642         Reviewed by Sam.
2643
2644         - Use the new IWebFrame [local] function signature and get the shared
2645         server correctly.
2646
2647         * Drosera/win/DebuggerClient.cpp:
2648         (DebuggerClient::didFinishLoadForFrame):
2649         * Drosera/win/ServerConnection.cpp:
2650         (ServerConnection::attemptToCreateServerConnection):
2651
2652 2007-11-07  Dan Bernstein  <mitz@apple.com>
2653
2654         Reviewed by Darin Adler.
2655
2656         - add an option to run-webkit-tests to ignore pixel test failures where
2657           all pixels differ by no more than a specified threshold
2658
2659         * DumpRenderTree/mac/ImageDiff.m:
2660         (main):
2661         (compareImages):
2662         (computePercentageDifferent):
2663         * Scripts/run-webkit-tests:
2664
2665 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2666
2667         Reviewed by Lars.
2668
2669         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
2670
2671         * DumpRenderTree/qt/DumpRenderTree.cpp:
2672
2673 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2674
2675         Reviewed by Lars.
2676
2677         Reworked the QWebSettings API.
2678         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
2679
2680         * DumpRenderTree/qt/DumpRenderTree.cpp:
2681
2682 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2683
2684         Reviewed by Lars.
2685
2686         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
2687
2688         * DumpRenderTree/qt/jsobjects.cpp:
2689
2690 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2691
2692         Reviewed by Lars Knoll <lars@trolltech.com>.
2693
2694         Add a QWebPage::frameCreated() signal and fix DRT
2695         
2696         The removal of createFrame in QWebPage broke the re-implementation
2697         in DumpRenderTree. Instead emit a frameCreated() signal and
2698         connect to it in DumpRenderTree.
2699         
2700
2701         * DumpRenderTree/qt/DumpRenderTree.cpp:
2702         (WebCore::WebPage::WebPage):
2703         (WebCore::DumpRenderTree::dump):
2704         (WebCore::DumpRenderTree::connectFrame):
2705         * DumpRenderTree/qt/DumpRenderTree.h:
2706
2707 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2708
2709         Reviewed by Lars Knoll <lars@trolltech.com>.
2710
2711         Moved all the event handlers from QWebFrame into QWebPage.
2712         
2713         This cleans up the public API and allows us to remove the
2714         HackWebFrame hack in DumpRenderTree.
2715         
2716
2717         * DumpRenderTree/qt/jsobjects.cpp:
2718         (EventSender::mouseDown):
2719         (EventSender::mouseUp):
2720         (EventSender::mouseMoveTo):
2721
2722 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2723
2724         Reviewed by Mark.
2725
2726         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
2727         to prevent the default implementation from popping up messageboxes.
2728
2729         * DumpRenderTree/qt/DumpRenderTree.cpp:
2730         (WebCore::WebPage::javaScriptConfirm):
2731         (WebCore::WebPage::javaScriptPrompt):
2732
2733 2007-11-06  Eric Seidel  <eric@webkit.org>
2734
2735         * Scripts/build-testkjs: build fix... too many $$
2736
2737 2007-11-06  Eric Seidel  <eric@webkit.org>
2738
2739         Reviewed by Mark Rowe.
2740
2741         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
2742
2743 2007-11-05  Adam Roben  <aroben@apple.com>
2744
2745         Add support on Windows for WEBKIT_TESTFONTS
2746
2747         This environment variable lets you specify where the fonts to be used
2748         by DumpRenderTree reside. The Qt port is already using this, so I'm
2749         just following their lead.
2750
2751         Reviewed by Darin.
2752
2753         * DumpRenderTree/win/DumpRenderTree.cpp:
2754         (exePath): Refactored code out of initialize().
2755         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2756         DumpRenderTree.resources.
2757         (initialize): Use the new fontsPath function.
2758         (main): Use the new exePath function.
2759         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2760         variable to DRT, like Qt does.
2761
2762 2007-11-05  Mark Rowe  <mrowe@apple.com>
2763
2764         Rubber-stamped by Alp Toker.
2765
2766         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2767
2768         * GtkLauncher/main.cpp:
2769         (goToURLBarText):
2770         (main):
2771
2772 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2773
2774         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2775         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2776
2777         Reviewed by Timothy.
2778
2779         Restrict the range of nightly builds used by the bisect-builds script
2780         based on the version of Safari and the version of Mac OS X being used.
2781
2782         Mac OS X 10.4: Safari 2.0: r11976 or newer
2783         Mac OS X 10.4: Safari 3.0: r19992 or newer
2784
2785         Mac OS X 10.5: Safari 2.0: r19594 or newer
2786         Mac OS X 10.5: Safari 3.0: r25124 or newer
2787
2788         * Scripts/bisect-builds:
2789         (findMacOSXVersion): Added.
2790         (makeNightlyList): Added argument to provide version of Mac OS X.
2791         Restrict range of nightly builds based on Safari and Mac OS X versions.
2792
2793 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2794
2795         Reviewed by Maciej.
2796
2797         - This patch involves several changes, all of them were noticed that
2798         they were needed by the work being done in WebKit to get Drosera and
2799         WebKit working together on Windows.
2800         - The changes are:
2801         1) Added a debugger console for output messages.
2802         2) Drosera now listens for the WebKit server (before, the server would
2803         have to be running before Drosera was started.)
2804         3) Fixed a bug where the WebView started out as 0x0 pixels.
2805         4) Fixed a bug when there is no scope.
2806         5) Added the HTML, JS, and CSS to the project file to make them easy to
2807         find.
2808         6) Made the ServerConnection functions virtual.
2809
2810         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2811         for the WebKit server.
2812         (DebuggerClient::DebuggerClient):
2813         (DebuggerClient::~DebuggerClient):
2814         (DebuggerClient::didFinishLoadForFrame):
2815         (DebuggerClient::serverConnected):
2816         (DebuggerClient::attemptToCreateServerConnection):
2817         * Drosera/win/DebuggerClient.h: Ditto.
2818         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2819         scope.
2820         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2821         (DebuggerDocument::platformValueForScopeVariableNamed):
2822         * Drosera/win/Drosera.cpp:
2823         (_tWinMain): Added a console in debug for output messages.
2824         (Drosera::Drosera): Listen for server.
2825         (Drosera::initUI): The server now Initializes COM.
2826         (Drosera::serverConnected): Part of the listening for the server.
2827         (Drosera::attemptToCreateServerConnection): Ditto.
2828         * Drosera/win/Drosera.h: New interface for listening for the server.
2829         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2830         files to the VS project.
2831         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2832         connection.
2833         (ServerConnection::ServerConnection):
2834         (ServerConnection::attemptToCreateServerConnection):
2835         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2836         methods.
2837         (ServerConnection::serverConnected):
2838
2839 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2840
2841         Reviewed by Maciej.
2842
2843         http://bugs.webkit.org/show_bug.cgi?id=15832
2844         fast/dom/gc-10.html crashes when run alone
2845
2846         Check for !done before using objects that can be already deallocated.
2847
2848         * DumpRenderTree/mac/EditingDelegate.mm:
2849         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2850         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2851         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2852         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2853         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2854         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2855         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2856         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2857         (-[EditingDelegate webViewDidBeginEditing:]):
2858         (-[EditingDelegate webViewDidChange:]):
2859         (-[EditingDelegate webViewDidEndEditing:]):
2860         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2861         (-[EditingDelegate webViewDidChangeSelection:]):
2862         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2863         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2864         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2865         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2866         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2867         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2868         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2869         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2870         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2871         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2872         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2873         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2874         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2875         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2876         (-[FrameLoadDelegate webView:willCloseFrame:]):
2877         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2878         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2879         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2880         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2881         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2882         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2883         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2884         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2885         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2886
2887 2007-11-04  Mark Rowe  <mrowe@apple.com>
2888
2889         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2890         warnings that would otherwise be suppressed due to it being a system header.
2891
2892         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2893
2894 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2895
2896         Rubber stamped by Adam.
2897         
2898         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2899
2900         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2901
2902 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2903
2904         Sort files(...); sections of Xcode project files.
2905
2906         Rubber-stamped by Darin.
2907
2908         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2909         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2910         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2911         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2912
2913 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2914
2915         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2916
2917         Reviewed by Darin.
2918
2919         * Scripts/sort-Xcode-project-file: Added.
2920
2921 2007-11-02  Darin Adler  <darin@apple.com>
2922
2923         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2924
2925 2007-11-02  Darin Adler  <darin@apple.com>
2926
2927         Reviewed by Maciej.
2928
2929         * Scripts/run-sunspider: Pass the "--base" option through.
2930
2931         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2932         the real script do that. Default configuration to Release to match run-sunspider
2933         so we don't end up building Debug just to compare results.
2934
2935 2007-11-01  Adam Roben  <aroben@apple.com>
2936
2937         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2938
2939         Reviewed by Sam.
2940
2941         * Scripts/commit-log-editor: Show all the directories beneath the
2942         source root, instead of just the last one.
2943
2944 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2945
2946         Reviewed by Adam Roben.
2947
2948         Print out an error message when the Windows build fails
2949         and provide guidance on how to find out what went wrong.
2950
2951         * Scripts/build-webkit:
2952         * Scripts/webkitdirs.pm:
2953
2954 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2955
2956         Rubber-stamped by Adam Roben.
2957
2958         Rolled out r27326 - debug CRT seems to cause no problems after all.
2959
2960         * DumpRenderTree/win/DumpRenderTree.vcproj:
2961
2962 2007-10-31  Adam Roben  <aroben@apple.com>
2963
2964         Switch the Debug configuration to using the non-debug CRT
2965
2966         This matches WebKit.
2967
2968         Reviewed by Steve.
2969
2970         * DumpRenderTree/win/DumpRenderTree.vcproj:
2971
2972 2007-10-31  Antti Koivisto  <antti@apple.com>
2973
2974         Reviewed by bdash.
2975         
2976         Disable media tests when doing leak checking on Tiger.
2977         They crash in QuickTime (rdar://problem/5537157).
2978
2979         * Scripts/run-webkit-tests:
2980
2981 2007-10-29  Antti Koivisto  <antti@apple.com>
2982
2983         Reviewed by Maciej.
2984         
2985         Build media support by default on OSX only.
2986
2987         * Scripts/build-webkit:
2988
2989 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2990
2991         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2992         get caught by the pre-commit hooks.
2993
2994 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2995
2996         Reviewed by Adam.
2997
2998         - This is a collection of relatively unrelated changes and cleanups
2999         to Drosera to prepare it for interacting with WebKit.  A lot of these
3000         changes are just correcting mistakes, for example removing included
3001         headers that are no longer needed.
3002
3003         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
3004         this will be needed by the DebuggerClient.
3005         (DebuggerDocument::server):
3006         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
3007         * Drosera/win/DebuggerClient.cpp: 
3008         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
3009         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
3010         (DebuggerClient::createWebViewWithRequest): Added comment about its
3011         purpose. 
3012         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
3013         declarations.
3014         (DebuggerClient::webViewLoaded): Moved.
3015         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
3016         file, since this was the only place it was used.
3017         (cfStringToBSTR):
3018         * Drosera/win/Drosera.h: Cleaned up the includes.
3019         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
3020         * Drosera/win/HelperFunctions.h: Removed.
3021
3022 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3023
3024         Reviewed by Adam.
3025
3026         - Small cleanup in the ServerConnection class.
3027
3028         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
3029         and added an include.
3030         (ServerConnection::currentFrame):
3031         (ServerConnection::getCallerFrame):
3032         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
3033         made a pointer into a COMPtr, and cleaned up the includes.
3034
3035 2007-10-29  Timothy Hatcher  <timothy@apple.com>
3036
3037         Reviewed by John Sullivan.
3038         
3039         - Place the Localizable.strings file in mac or win directories
3040           if that location exists.
3041         - Also look for UI_STRING in .c files.
3042
3043         * Scripts/extract-localizable-strings:
3044
3045 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3046
3047         Reviewed by Adam.
3048
3049         - Set the eol-style to native and made all the line endings the same
3050         so that I avoid messy diffs that show eol changes.
3051
3052         * Drosera/win/ServerConnection.cpp:
3053         (ServerConnection::didParseSource):
3054         (ServerConnection::didEnterCallFrame):
3055         (ServerConnection::willExecuteStatement):
3056         (ServerConnection::willLeaveCallFrame):
3057         (ServerConnection::exceptionWasRaised):
3058
3059 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3060
3061         Reviewed by Adam.
3062
3063         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
3064         functionality that could not have existed previously without the new
3065         interfaces.
3066         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
3067         from a BSTR to a JSValueRef.
3068         (DebuggerDocument::platformEvaluateScript): Implemented.
3069         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
3070         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3071         Implemented.
3072         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
3073         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
3074         * Drosera/win/ServerConnection.cpp: Added a helper function.
3075         (ServerConnection::getCallerFrame):
3076         * Drosera/win/ServerConnection.h: Added a helper function.
3077
3078 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3079
3080         updated reviewers for my previous changelog.
3081
3082 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3083         Reviewed by Maciej and Adam and Geoff.
3084
3085         - Minor mac-side improvements including moving a function to a more
3086         appropriate location, fixing a warning, and correctly checking
3087         exceptions.
3088
3089         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
3090         (DebuggerDocument::willExecuteStatement):
3091         (DebuggerDocument::didEnterCallFrame):
3092         (DebuggerDocument::willLeaveCallFrame):
3093         (DebuggerDocument::windowScriptObjectAvailable):
3094         (DebuggerDocument::callFunctionOnObject):
3095         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
3096         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
3097         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
3098         because it doesn't require the ServerConnection at all.
3099         (NSStringCreateWithJSStringRef): Made an argument const.
3100         (JSValueRefCreateWithNSString): Made an argument const.
3101         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
3102         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3103         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
3104         * Drosera/mac/ServerConnection.mm: Ditto.
3105         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3106
3107 2007-10-29  Sam Weinig  <sam@webkit.org>
3108
3109         Reviewed by Adam Roben.
3110
3111         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
3112
3113         * DumpRenderTree/LayoutTestController.cpp:
3114         (LayoutTestController::LayoutTestController):
3115         (getGlobalFlagCallback):
3116         (setGlobalFlagCallback):
3117         (LayoutTestController::getJSClass):
3118         (LayoutTestController::staticValues):
3119         * DumpRenderTree/LayoutTestController.h:
3120         (LayoutTestController::globalFlag):
3121         (LayoutTestController::setGlobalFlag):
3122
3123 2007-10-29  Darin Adler  <darin@apple.com>
3124
3125         Reviewed by Maciej.
3126
3127         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
3128         resolution instead of its default.
3129
3130 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
3131
3132         Fixed showStatus() to print status for successfully resolved conflicts when using git.
3133
3134         Reviewed by Mark Rowe.
3135
3136         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
3137         was successfully resolved, but this would not show any status because the change had
3138         already been cached in the index using "git add".  The solution is to add an optional
3139         second argument to showStatus() which adds the "--cached" switch to the command.
3140
3141         * Scripts/resolve-ChangeLogs:
3142         (showStatus):
3143
3144 2007-10-28  Eric Seidel  <eric@webkit.org>
3145
3146         Reviewed by Maciej and Geoff, in unison.
3147
3148         * Scripts/run-webkit-tests: remove broken --svg option
3149
3150 2007-10-28  Darin Adler  <darin@apple.com>
3151
3152         Reviewed by Adam.
3153
3154         * Scripts/run-sunspider: Default to "Release" configuration rather than
3155         defaulting to the last configuration used as other scripts do. This can
3156         still be overriden on the command line with "--debug" if there's some
3157         reason to do so. Also fix a typo.
3158
3159         * Scripts/sunspider-compare-results: Fix a typo.
3160
3161 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
3162
3163         Reviewed by Adam.
3164
3165         - Implemented the WebScriptDebugListener functions now that the
3166         WebScriptDebugServer exists
3167
3168         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
3169         functions.
3170         (ServerConnection::currentFrame):
3171         (ServerConnection::didLoadMainResourceForDataSource):
3172         (ServerConnection::didParseSource):
3173         (ServerConnection::failedToParseSource):
3174         (ServerConnection::didEnterCallFrame):
3175         (ServerConnection::willExecuteStatement):
3176         (ServerConnection::willLeaveCallFrame):
3177         (ServerConnection::exceptionWasRaised):
3178         * Drosera/win/ServerConnection.h: Removed unused arguments from the
3179         members arguments list.
3180
3181 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
3182
3183         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
3184         <http://bugs.webkit.org/show_bug.cgi?id=15600>
3185
3186         Reviewed by Darin.
3187
3188         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
3189         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
3190         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
3191         file.  Note that it may also be used as a stand-alone script.
3192
3193         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
3194         * Scripts/resolve-ChangeLogs: Added.
3195         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
3196
3197 2007-10-26  Mark Rowe  <mrowe@apple.com>
3198
3199         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
3200         to the Qt port on the assumption that it was an implementation of the cross-platform
3201         LayoutTestController class.  It is not, so it did not need to be changed.
3202
3203         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
3204
3205 2007-10-25  Mark Rowe  <mrowe@apple.com>
3206
3207         Reviewed by Maciej.
3208
3209         Fix builds with code coverage enabled.
3210
3211         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
3212
3213 2007-10-25  Darin Adler  <darin@apple.com>
3214
3215         Reviewed by Mark Rowe.
3216
3217         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
3218         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
3219
3220 2007-10-25  Stephanie  <slewis@apple.com>
3221
3222         build Fix
3223
3224         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3225
3226 2007-10-25  Stephanie  <slewis@apple.com>
3227
3228         Reviewed by Mark Rowe, Adam Roben.
3229
3230         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
3231
3232         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
3233
3234 2007-10-25  Alice Liu  <alice.liu@apple.com>
3235
3236         Reviewed by Adam.
3237
3238         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
3239
3240         Moving destructor into platform-specific files
3241         * DumpRenderTree/LayoutTestController.cpp:
3242         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3243         (LayoutTestController::~LayoutTestController):
3244         * DumpRenderTree/qt/jsobjects.cpp:
3245         (LayoutTestController::~LayoutTestController):
3246
3247         LayoutTestController wasn't being destroyed
3248         * DumpRenderTree/win/DumpRenderTree.cpp:
3249         (runTest):
3250
3251         Added declspec
3252         * DumpRenderTree/win/EditingDelegate.h:
3253
3254         Reset certain values on the webview (or related delegate) that might 
3255         have changed while running a test
3256         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3257         (LayoutTestController::~LayoutTestController):
3258
3259 2007-10-25  Adam Roben  <aroben@apple.com>
3260
3261         Make sunspider-compare-results work with relative paths
3262
3263         Reviewed by Sam.
3264
3265         * Scripts/sunspider-compare-results: Convert arguments to absolute
3266         paths before we chdir.
3267
3268 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
3269
3270         Reviewed by Sam.
3271
3272         - Implemented server calls now the WebScriptDebugServer exists.
3273         - Also removed no longer needed call to initialize CG.
3274
3275         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
3276         automatically now.
3277         (_tWinMain):
3278         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
3279         (ServerConnection::ServerConnection):
3280         (ServerConnection::~ServerConnection):
3281         (ServerConnection::pause):
3282         (ServerConnection::resume):
3283         (ServerConnection::stepInto):
3284         (ServerConnection::applicationTerminating):
3285         (ServerConnection::serverConnectionDidDie):
3286         * Drosera/win/ServerConnection.h: Now uses the COM class.
3287
3288 2007-10-24  George Staikos  <staikos@kde.org>
3289
3290         Unbreak Qt build.
3291
3292         * Scripts/build-webkit:
3293
3294 2007-10-24  Adam Roben  <aroben@apple.com>
3295
3296         Remove now-unnecessary call to InitializeCoreGraphics
3297
3298         WebKit takes care of this now.
3299
3300         Reviewed by Ada.
3301
3302         * DumpRenderTree/win/DumpRenderTree.cpp:
3303         (initialize):
3304
3305 2007-10-24  Adam Roben  <aroben@apple.com>
3306
3307         Use WebTextRenderer in DRT
3308
3309         Reviewed by Ada.
3310
3311         * DumpRenderTree/win/DumpRenderTree.cpp:
3312         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
3313
3314 2007-10-24  Sven Herzberg  <sven@imendio.com>
3315
3316         Reviewed by Mark Rowe.
3317
3318         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
3319         Bug 15614: [GTK] qmake based backends don't build on OS X
3320
3321         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
3322         GTK backend on a Mac
3323         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
3324         isDarwin() to make it reusable in other places (like the workaround-
3325         for-prebuilt-qmake in build-webkit)
3326
3327 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3328
3329         Refurbish update-webkit script.
3330
3331         Reviewed by Adam.
3332
3333         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
3334         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
3335         multi-argument version of system() for flexibility and security.  Check for existence
3336         of Internal directory using -d test instead of -x.
3337
3338 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3339
3340         Minor clean-up of prepare-ChangeLog script.
3341
3342         Reviewed by Adam.
3343
3344         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
3345         of a string.  Use multi-argument versions of open() and system() for flexibility and
3346         security.
3347
3348 2007-10-24  Alice Liu  <alice.liu@apple.com>
3349
3350         Reviewed by Oliver.
3351
3352         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
3353
3354         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
3355         replay the saved events when we're still processing the mousedown that starts the drag
3356         * DumpRenderTree/win/EventSender.cpp:
3357         (doMouseMove):
3358         * DumpRenderTree/win/UIDelegate.cpp:
3359         (UIDelegate::doDragDrop):
3360
3361 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
3362
3363         Reviewed by Sam, Steve and Darin.
3364
3365         - Stubbed out the WebScriptDebugListener functionality in the Server
3366         Connection class to prepare it for receiving those callbacks.
3367         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
3368         and the ServerConnection to not need to be initialized with a server
3369         name, since that is not the way we connect to the WebKit server. 
3370
3371         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
3372         no exception.  Now it only loggs when there is an exception
3373         (DebuggerDocument::willExecuteStatement):
3374         (DebuggerDocument::didEnterCallFrame):
3375         (DebuggerDocument::willLeaveCallFrame):
3376         (DebuggerDocument::windowScriptObjectAvailable):
3377         (DebuggerDocument::callFunctionOnObject):
3378         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
3379         to be instantiated with a server's name.
3380         (DebuggerClient::DebuggerClient):
3381         (DebuggerClient::didFinishLoadForFrame):
3382         * Drosera/win/DebuggerClient.h: Removed unsued variable.
3383         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
3384         a server name.
3385         (Drosera::init):
3386         (Drosera::initServer):
3387         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
3388         instantiated with a server's name.
3389         * Drosera/win/ServerConnection.cpp: 
3390         (ServerConnection::ServerConnection): No longer needs a server name
3391         (ServerConnection::~ServerConnection): Only release the global context
3392         if there is one.
3393         (ServerConnection::serverConnectionDidDie): Stub for
3394         IWebScriptDebugListener
3395         (ServerConnection::QueryInterface): ditto
3396         (ServerConnection::AddRef): ditto
3397         (ServerConnection::Release): ditto
3398         (ServerConnection::didLoadMainResourceForDataSource): ditto
3399         (ServerConnection::didParseSource): ditto
3400         (ServerConnection::failedToParseSource): ditto
3401         (ServerConnection::didEnterCallFrame): ditto
3402         (ServerConnection::willExecuteStatement): ditto
3403         (ServerConnection::willLeaveCallFrame): ditto
3404         (ServerConnection::exceptionWasRaised): ditto
3405         * Drosera/win/ServerConnection.h: Stubbed out the
3406         IWebScriptDebugListener functions, and this class no longer needs to be
3407         instantiated with a server name.
3408
3409 2007-10-24  Lars Knoll  <lars@trolltech.com>
3410
3411         Reviewed by Simon.
3412
3413         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
3414
3415         * DumpRenderTree/qt/jsobjects.h:
3416
3417 2007-10-24  Lars Knoll  <lars@trolltech.com>
3418
3419         Reviewed by Simon.
3420
3421         add another command.
3422
3423         * DumpRenderTree/qt/jsobjects.cpp:
3424         (TextInputController::doCommand):
3425
3426 2007-10-24  Lars Knoll  <lars@trolltech.com>
3427
3428         Reviewed by Simon.
3429
3430         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
3431
3432         * DumpRenderTree/qt/jsobjects.cpp:
3433         (EventSender::keyDown):
3434         * DumpRenderTree/qt/jsobjects.h:
3435
3436 2007-10-24  Lars Knoll  <lars@trolltech.com>
3437
3438         Reviewed by Simon.
3439
3440         implement eventSender.keyDown().
3441
3442         * DumpRenderTree/qt/jsobjects.cpp:
3443         (EventSender::keyDown):
3444
3445 2007-10-24  Lars Knoll  <lars@trolltech.com>
3446
3447         Reviewed by Simon.
3448
3449         some smaller fixes to the editing support in DRT. Makes another few tests pass.
3450
3451         * DumpRenderTree/qt/DumpRenderTree.cpp:
3452         (WebCore::DumpRenderTree::DumpRenderTree):
3453         (WebCore::DumpRenderTree::initJSObjects):
3454         * DumpRenderTree/qt/jsobjects.cpp:
3455         (TextInputController::doCommand):
3456
3457 2007-10-24  Lars Knoll  <lars@trolltech.com>
3458
3459         Reviewed by Simon.
3460
3461         first bit of implementation for the textinputcontroller.
3462
3463         * DumpRenderTree/qt/DumpRenderTree.cpp:
3464         (WebCore::DumpRenderTree::DumpRenderTree):
3465         * DumpRenderTree/qt/DumpRenderTree.h:
3466         * DumpRenderTree/qt/jsobjects.cpp:
3467         (TextInputController::TextInputController):
3468         (TextInputController::doCommand):
3469         * DumpRenderTree/qt/jsobjects.h:
3470
3471 2007-10-24  Lars Knoll  <lars@trolltech.com>
3472
3473         Reviewed by Simon.
3474
3475         make the man webpage believe it has focus, so the editing tests work correctly.
3476
3477         * DumpRenderTree/qt/DumpRenderTree.cpp:
3478         (WebCore::DumpRenderTree::DumpRenderTree):
3479
3480 2007-10-24  Lars Knoll  <lars@trolltech.com>
3481
3482         Reviewed by Simon.
3483
3484         implement layoutTestController.dumpEditingCallbacks() correctly.
3485
3486         * DumpRenderTree/qt/DumpRenderTree.cpp:
3487         (WebCore::DumpRenderTree::DumpRenderTree):
3488         * DumpRenderTree/qt/jsobjects.cpp:
3489         (LayoutTestController::reset):
3490         (LayoutTestController::dumpEditingCallbacks):
3491
3492 2007-10-24  Lars Knoll  <lars@trolltech.com>
3493
3494         Reviewed by Simon.
3495
3496         Implement support for testing editing.
3497
3498         * DumpRenderTree/qt/DumpRenderTree.cpp:
3499         (WebCore::DumpRenderTree::DumpRenderTree):
3500
3501 2007-10-23  Sam Weinig  <sam@webkit.org>
3502
3503         Check for null BSTR that can be passed to the UIDelegate methods
3504         from javascript null and undefined.  Fixes a failing test case on
3505         Windows (fast/dom/Window/alert-undefined.html)
3506
3507         Reviewed by Eric Seidel.
3508
3509         * DumpRenderTree/win/UIDelegate.cpp:
3510         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3511         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3512         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3513         (UIDelegate::webViewAddMessageToConsole):
3514
3515 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3516
3517         Reviewed by Darin.
3518         
3519         Don't print a massive pile of setenvs from tools that automatically build testkjs.
3520
3521         * Scripts/build-testkjs:
3522
3523 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3524
3525         Reviewed by Darin.
3526
3527         - add wrapper that finds the right copy of testkjs
3528         
3529         * Scripts/sunspider-compare-results: Added.
3530
3531 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
3532
3533         Reviewed by Sam.
3534
3535         - After talking with Steve I now see that the WebKit server must be
3536         running for DCOM to create the distributed objects, which makes sense
3537         and currently WebKit only allows one instance to be running at a time
3538         which avoids accidentally connecting to the wrong server
3539         - In light of this I have removed the code for the attach box and
3540         NotificationServer and known server names, since they are all extranious
3541         now.
3542
3543         * Drosera/win/Drosera.cpp: Removed notification classes and known server
3544         names.
3545         (_tWinMain): Uses init instead of initUI.
3546         (droseraWndProc): No longer creats an attach dialog box.
3547         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
3548         it's not manditory to call init before doing COM stuff.
3549         (Drosera::init): calls initUI and will call attach when the
3550         functionality exists. 
3551         (Drosera::initUI): Has changed very little.
3552         (Drosera::attach): Changed the signature to reflect that we no longer
3553         need the dictionary of known server names.
3554         * Drosera/win/Drosera.h: Removed notification classes and known server
3555         names.  Also renamed and moved some functions.
3556         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
3557         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
3558         headers to the resources folder. 
3559         * Drosera/win/resource.h: Removed the Attach box.
3560
3561 2007-10-22  Adam Roben  <aroben@apple.com>
3562
3563         Windows build fix
3564
3565         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
3566
3567 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
3568
3569         - Removed a leak that was fixed.
3570
3571         * Scripts/run-webkit-tests:
3572
3573 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3574
3575         Reviewed by Darin.
3576
3577         - Changed the Client so that the DebuggerDocument now own the
3578         ServerConnection.  This simplifies ownership and cleanup. 
3579
3580         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
3581         ServerConnection.
3582         (DebuggerClient::initWithServerName):
3583         (DebuggerClient::didFinishLoadForFrame):
3584         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
3585         ServerConnection.
3586         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
3587         until after we have a server which we are attached to.
3588         (Drosera::initUI):
3589         (Drosera::attach):
3590         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
3591         out previously.
3592
3593 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3594
3595         Reviewed by Nikolas.
3596
3597         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
3598
3599         * Scripts/run-javascriptcore-tests:
3600
3601 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3602
3603         Reviewed by Nikolas.
3604
3605         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
3606
3607         * Scripts/build-drosera:
3608         * Scripts/build-dumprendertree:
3609         * Scripts/build-testkjs:
3610         * Scripts/build-webkit:
3611         * Scripts/run-javascriptcore-tests:
3612         * Scripts/run-sunspider:
3613         * Scripts/run-webkit-tests:
3614         * Scripts/webkitdirs.pm:
3615
3616 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
3617
3618         Reviewed by Mark Rowe.
3619         
3620         Fix for local database support after r26879
3621         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
3622
3623         * Scripts/build-webkit:
3624
3625 2007-10-22  Holger Freyther  <zecke@selfish.org>
3626
3627         Reviewed by Simon Hausmann <hausmann@kde.org>.
3628
3629         - Do not build testkjs as an application bundle. This is
3630         needed for run-javascriptcore-tests on OSX.
3631         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
3632         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
3633         as we do not have -rpath on OSX.
3634
3635         * DumpRenderTree/qt/DumpRenderTree.pro:
3636         * Scripts/run-webkit-tests:
3637
3638 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3639
3640         Reviewed by aroben.
3641
3642         Fix support for Signed-off-by detection in prepare-ChangeLog
3643         --git-commit. The Signed-off-by tag does not appear in the header
3644         but usually at the end.
3645
3646         * Scripts/prepare-ChangeLog:
3647
3648 2007-10-21  Mark Rowe  <mrowe@apple.com>
3649
3650         Reviewed by Eric.
3651
3652         Fix run-javascriptcore-tests for Gtk.
3653
3654         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
3655
3656 2007-10-20  Eric Seidel  <eric@webkit.org>
3657
3658         Reviewed by aroben.
3659
3660         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
3661
3662 2007-10-20  Eric Seidel  <eric@webkit.org>
3663
3664         Reviewed by darin.
3665         
3666         Add improved argument handling to run-sunspider, including
3667         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
3668         Also re-factor code into subroutines
3669
3670         * Scripts/build-dumprendertree: removed bogus comments
3671         * Scripts/build-testkjs: Added.
3672         * Scripts/run-javascriptcore-tests: use build-testkjs
3673         * Scripts/run-sunspider: improved argument handling, abstraction
3674         * Scripts/run-webkit-tests: improved abstraction
3675
3676 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
3677
3678         Not reviewed, Windows build fix.
3679
3680         * DumpRenderTree/win/EventSender.cpp:
3681         (keyDownCallback):
3682
3683 2007-10-20  Darin Adler  <darin@apple.com>
3684
3685         Reviewed by Tim Hatcher.
3686
3687         - http://bugs.webkit.org/show_bug.cgi?id=15544
3688           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
3689           not rely on Apple-specific key codes
3690
3691         * DumpRenderTree/mac/EventSendingController.mm:
3692         (-[EventSendingController keyDown:withModifiers:]):
3693         Added named key "rightArrow". Later we could have a whole table of these.
3694         Also tweaked modifiers code a little.
3695
3696         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
3697
3698 2007-10-19  Darin Adler  <darin@apple.com>
3699
3700         Reviewed by Eric.
3701
3702         - http://bugs.webkit.org/show_bug.cgi?id=15566
3703           possible fix for leak seen in DumpRenderTree
3704
3705         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
3706         Delete the item if it's not put on the queue, since the caller has
3707         no way of knowing that. Would be better to have the parameter type
3708         be auto_ptr to express the fact that we take ownership.
3709
3710         - unrelated change
3711
3712         * Drosera/mac/main.m: Add missing include.
3713
3714 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3715
3716         Reviewed by Adam.
3717
3718         - This change should be identical but for some reason was not working
3719         on my machine.
3720
3721         * Scripts/prepare-ChangeLog:
3722
3723 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3724
3725         Reviewed by Oliver and Tim.
3726
3727         - Made use of RetainPtr to avoid retain and release issues and moved the
3728         log function to DebuggerDocumentPlatform, which seems to be a more
3729         logical place for it to live.
3730         - Also moved knownServers from the ServerConnection to
3731         DebuggerApplication to match the Windows code and because it makes sense
3732         that a connection knows its own server but not all of them.
3733
3734         * Drosera/mac/DebuggerClient.h: Moved the log function to
3735           DebuggerDocumentPlatform.
3736         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
3737           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
3738           call for the server name up from the ServerConnection class.
3739         (-[DebuggerClient dealloc]):
3740         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
3741           for the server name up from the ServerConnection.
3742         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
3743         (DebuggerDocument::platformPause):
3744         (DebuggerDocument::platformResume):
3745         (DebuggerDocument::platformStepInto):
3746         (DebuggerDocument::platformEvaluateScript):
3747         (DebuggerDocument::getPlatformCurrentFunctionStack):
3748         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3749         (DebuggerDocument::platformValueForScopeVariableNamed):
3750         (DebuggerDocument::platformLog): Log directly from here. No need to call
3751           DebuggerClient.
3752         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
3753           way I see it, a ServerConnection should only know about its connection
3754           and the group of all possible servers should be kept by the
3755           application.
3756         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
3757           currentServerName, it makes sense that the connection should know that
3758           name.
3759         (-[ServerConnection currentServerName]):
3760
3761 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3762
3763         Reviewed by Adam.
3764
3765         - Integrated changes from mac drosera.  Recently I've encapsulated
3766         out the server connection object from the rest of Drosera because
3767         it is very platform dependent right now and RPC is not implemented on
3768         windows.  This functionality, of communicating with the WebKit server
3769         is the next area I will be focusing on in Windows.
3770
3771         - Other changes and cleanup were made to organize the code and add notes
3772         on which parts still need work.  Also some mac code is added and
3773         commented out, to act as pseudocode for the logic of those parts.
3774
3775         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
3776           pointer.
3777         * Drosera/config.h: Added whitespace.
3778         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
3779           these files got moved into Drosera.h/cpp
3780         * Drosera/win/DebuggerApplication.h: Removed.
3781         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
3782           happened here to better match the logic flow of the same code on the 
3783           mac side and to use the new ServerConnection class.
3784         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
3785         (DebuggerClient::initWithServerName): Initializer that will set up the
3786           class to use a ServerConnection object.  This was necessary so I could
3787           create a DebuggerClient without having to initilaize it at
3788           construction.
3789         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
3790           will be the UIDelegate and FrameLoadDelegate.
3791         (DebuggerClient::AddRef): For IUnknown.
3792         (DebuggerClient::Release): For IUnknown.
3793         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
3794           this still needs to set the global context of the server, but
3795           IWebFrame does not have an accessor for the global context yet. 
3796         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
3797           this is a pass through for the same function in the document.
3798         (DebuggerClient::didReceiveTitle): Unimplemented part of
3799           FrameLoadDelegate this would change the title of the window.
3800         (DebuggerClient::createWebViewWithRequest): Part of the
3801           FrameLoadDelegate.  This is about new windows via Window.open() and
3802           how their delegates are set.
3803         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
3804           UIDelegate.  Just a debug function for printing messages.
3805         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
3806           because the Client should be the UIDelegate and FrameLoadDelegate
3807           to match the delegates on mac.
3808         (DebuggerClient::webViewLoaded): Added accessor method.
3809         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
3810           forgotten to add this file before.  This is where the platform
3811           dependent versions of the Documents functions live. Most of these are
3812           unimplemented because some piece of functionality does not exist on
3813           Windows yet.
3814         (DebuggerDocument::platformPause):
3815         (DebuggerDocument::platformResume):
3816         (DebuggerDocument::platformStepInto):
3817         (DebuggerDocument::platformEvaluateScript):
3818         (DebuggerDocument::getPlatformCurrentFunctionStack):
3819         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3820         (DebuggerDocument::platformValueForScopeVariableNamed):
3821         (DebuggerDocument::platformLog):
3822         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
3823           responsibilities becaue they belong in the Client. Also I laid the
3824           groundwork for attaching Drosera to a WebKit process
3825         (attachWndProc): Now if a server is selected the Client becomes it's
3826           delegate.
3827         (Drosera::Drosera): Added the construction of the Client and dictionary
3828           of server names. 
3829         (Drosera::initUI): This is no longer the delegates, the Client is.
3830         (Drosera::webViewLoaded): Now asks the Client instead of holding local
3831           state. 
3832         (Drosera::applicationDidFinishLaunching): Placeholder for needed
3833           notification registration when it's possible to implement.
3834         (Drosera::serverLoaded): Ditto
3835         (Drosera::serverUnloaded): Ditto
3836         (Drosera::attach): Attach Drosera to the WebKit server.
3837         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
3838         (Drosera::getInst): 
3839         (Drosera::setInst):
3840         (Drosera::knownServers):
3841         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
3842           and added the ServerConnection.
3843         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
3844         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
3845           Most of the functions are completely unimlemented because they cannot
3846           connect with the WebKit server, because one does not exist on Windows
3847           yet.
3848         (ServerConnection::initWithServerName): 
3849         (ServerConnection::~ServerConnection):
3850         (ServerConnection::setGlobalContext):
3851         (ServerConnection::pause):
3852         (ServerConnection::resume):
3853         (ServerConnection::stepInto):
3854         (ServerConnection::switchToServerNamed):
3855         (ServerConnection::applicationTerminating):
3856         (ServerConnection::serverConnectionDidDie):
3857         (ServerConnection::currentFrame):
3858         * Drosera/win/ServerConnection.h: Added. Ditto.
3859         (ServerConnection::ServerConnection):
3860
3861 2007-10-19  Alice Liu  <alice.liu@apple.com>
3862
3863         Reviewed by Darin.
3864
3865         Fix for these broken layout tests on Windows:
3866         
3867         fast/forms/focus-selection-input.html
3868         fast/forms/focus-selection-textarea.html
3869         fast/forms/select-accesskey.html
3870         
3871         * DumpRenderTree/win/EventSender.cpp:
3872         (keyDownCallback):
3873         correct the VK code for alt key.
3874         
3875 2007-10-19  Eric Seidel  <eric@webkit.org>
3876
3877         Reviewed by Mark Rowe.
3878         
3879         Make the GtkLauncher code slightly more readable.
3880
3881         * GtkLauncher/main.cpp:
3882         (setupMainMenu): Added.
3883         (setupMainWindowUI): Added.
3884         (main):
3885
3886 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
3887
3888         Rubber stamped by Adam.
3889         
3890         - don't delay-load WebKit in DumpRenderTree.
3891
3892         * DumpRenderTree/win/DumpRenderTree.vcproj:
3893
3894 2007-10-18  Dan Bernstein  <mitz@apple.com>
3895
3896         Reviewed by Adam Roben.
3897
3898         - fix <rdar://problem/5313523>
3899         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
3900
3901         * DumpRenderTree/mac/DumpRenderTree.mm:
3902         (dump): Changed to use _responseMIMEType.
3903
3904 2007-10-17  Adam Roben  <aroben@apple.com>
3905
3906         Make it possible to have Windows-specific tests and results
3907
3908         When searching for tests to run and the Skipped file, we will only
3909         look in platform/win and the cross-platform directory. When looking
3910         for expected results, we will look in platform/win, then
3911         platform/mac-leopard, then platform/mac, then finally the
3912         cross-platform directory.
3913
3914         Reviewed by Sam.
3915
3916         * Scripts/run-webkit-tests:
3917         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
3918         searching in the cross-platform directory.
3919         (sub buildPlatformHierarchy): Removed some unneeded calls to
3920         dirname/basename.
3921
3922 2007-10-17  Adam Roben  <aroben@apple.com>
3923
3924         Add back the call to register WebKit that we had before WebKitInitializer existed
3925
3926         This is needed to ensure that the right WebKit is used when
3927         instantiating COM objects.
3928
3929         Reviewed by Oliver.
3930
3931         * DumpRenderTree/win/debug_internal.vsprops: Define
3932         DEBUG_WEBKIT_HAS_SUFFIX.
3933         * DumpRenderTree/win/DumpRenderTree.cpp:
3934         (initialize):
3935
3936 2007-10-17  Adam Roben  <aroben@apple.com>
3937
3938         Import File::Basename in webkitdirs since we use it
3939
3940         * Scripts/webkitdirs.pm:
3941
3942 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
3943
3944         - Updated the tiger leaks list to make the internal bots green.
3945
3946         * Scripts/run-webkit-tests:
3947
3948 2007-10-17  Adam Roben  <aroben@apple.com>
3949
3950         Build fix for VC++ Express
3951
3952         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
3953         and ole32.lib.
3954
3955 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3956
3957         Reviewed by Sam.
3958
3959         - Minor mac improvements based on observations I made while implementing the
3960         Windows code.
3961
3962         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
3963         then hand it to the Client who will retain it, it should just be the client who
3964         creates and owns the server.
3965         (-[DebuggerApplication attach:]):
3966         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
3967         * Drosera/mac/DebuggerClient.mm: Creates the server.
3968         (-[DebuggerClient initWithServerName:]):
3969         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
3970         can instead forward declare what it needs.
3971
3972 2007-10-16  Darin Adler  <darin@apple.com>
3973
3974         Reviewed by Geoff Garen.
3975
3976         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
3977         want to turn failing tests into platform-specific test results. Also did a
3978         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
3979         would take the type of results into account only some of the time.
3980
3981 2007-10-16  Adam Roben  <aroben@apple.com>
3982
3983         Add a new nightly launcher script for Windows
3984
3985         This new script is for versions of Safari that don't delay-load
3986         WebKit. I had to make FindSafari be able to print out the nightly
3987         launcher script on stdout because Windows shell scripts can't capture
3988         the output from a command into an environment variable.
3989
3990         Reviewed by Steve.
3991
3992         * FindSafari/FindSafari.cpp:
3993         (_tmain): Added /printSafariLauncher option.
3994         * Scripts/run-webkit-nightly.cmd: Added.
3995
3996 2007-10-16  Adam Roben  <aroben@apple.com>
3997
3998         Replace WebKitInitializer with FindSafari
3999
4000         We now rely on setting the PATH environment variable to tell Windows
4001         where to find WebKit and its dependencies (similar to
4002         DYLD_FRAMEWORK_PATH on Mac).
4003
4004         This change also make DumpRenderTree no longer delay-load WebKit.
4005
4006         Reviewed by Sam.
4007
4008         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
4009         FindSafari.
4010         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
4011         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
4012         WebKitInitializer, don't delay-load WebKit.
4013         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
4014         * Scripts/run-webkit-tests: Ditto.
4015         * Scripts/webkitdirs.pm:
4016         (sub setPathForRunningWebKitApp): Added.
4017         * WebKitInitializer/WebKitInitializer.cpp: Removed.
4018         * WebKitInitializer/WebKitInitializer.h: Removed.
4019         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
4020         * WebKitInitializer/debug.vsprops: Removed.
4021         * WebKitInitializer/debug_internal.vsprops: Removed.
4022         * WebKitInitializer/release.vsprops: Removed.
4023
4024 2007-10-16  Adam Roben  <aroben@apple.com>
4025
4026         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
4027
4028         http://bugs.webkit.org/show_bug.cgi?id=15532
4029
4030         FindSafari simply prints the location of an installed Safari.exe on
4031         stdout.
4032
4033         Reviewed by Darin.
4034
4035         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
4036         (getStringValue):
4037         (getWebViewCLSID):
4038         (getInstalledWebKitDirectory):
4039         (_tmain):
4040         * FindSafari/FindSafari.vcproj: Added.
4041         * Scripts/webkitdirs.pm:
4042         (sub installedSafariPath): Added. Calls FindSafari on Windows.
4043
4044 2007-10-16  Adam Roben  <aroben@apple.com>
4045
4046         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
4047
4048         Reviewed by Kevin McCullough.
4049
4050         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
4051         when referring to WebKit.dll.
4052         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
4053         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
4054         * DumpRenderTree/win/release.vsprops: Ditto.
4055         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
4056         never have a _debug suffix on WebKit.dll.
4057         * WebKitInitializer/WebKitInitializer.cpp:
4058         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
4059         specified.
4060         * WebKitInitializer/debug_internal.vsprops: Added
4061         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
4062
4063 2007-10-16  Darin Adler  <darin@apple.com>
4064
4065         Reviewed by Adele.
4066
4067         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
4068         Remove now-unneeded control/alt key hack; the tests have been updated.
4069
4070 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
4071
4072         - Updated leaks list because our internal bot upgraded it's version of leopard and 
4073         one of the leaks was fixed between that revision and the bot's previous version of
4074         leopard.
4075
4076         * Scripts/run-webkit-tests:
4077
4078 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
4079
4080         Reviewed by Tim.
4081
4082         - I encapsulated out the server connecton functionality because it is a specific part
4083         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
4084         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
4085         Windows.  So the majority of this patch is moving preexisting functionality.
4086
4087         - Also I removed the prefix header and changed to use config.h because it is more
4088         standard on how we use config.h in windows and it didn't make much sense to keep
4089         the prefix header and the config.h
4090
4091         * Drosera/DebuggerDocument.cpp:
4092         (DebuggerDocument::DebuggerDocument):
4093         * Drosera/DebuggerDocument.h:
4094         * Drosera/config.h:
4095         * Drosera/mac/DebuggerApplication.mm:
4096         (-[DebuggerApplication attach:]):
4097         * Drosera/mac/DebuggerClient.h:
4098         * Drosera/mac/DebuggerClient.mm:
4099         (-[DebuggerClient initWithServerConnection:]):
4100         (-[DebuggerClient dealloc]):
4101         (-[DebuggerClient windowDidLoad]):
4102         (-[DebuggerClient windowWillClose:]):
4103         (-[DebuggerClient webView:didFinishLoadForFrame:]):
4104         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
4105         * Drosera/mac/DebuggerDocumentPlatform.mm:
4106         (DebuggerDocument::platformPause):
4107         (DebuggerDocument::platformResume):
4108         (DebuggerDocument::platformStepInto):
4109         (DebuggerDocument::platformEvaluateScript):
4110         (DebuggerDocument::getPlatformCurrentFunctionStack):
4111         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
4112         (DebuggerDocument::platformValueForScopeVariableNamed):
4113         (DebuggerDocument::platformLog):
4114         * Drosera/mac/Drosera.pch: Removed.
4115         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
4116         * Drosera/mac/ServerConnection.h: Added.
4117         * Drosera/mac/ServerConnection.mm: Added.
4118         (-[ServerConnection initWithServerName:]):
4119         (-[ServerConnection dealloc]):
4120         (-[ServerConnection setGlobalContext:]):
4121         (-[ServerConnection pause]):
4122         (-[ServerConnection resume]):
4123         (-[ServerConnection stepInto]):
4124         (-[ServerConnection switchToServerNamed:]):
4125         (-[ServerConnection applicationTerminating:]):
4126         (-[ServerConnection serverConnectionDidDie:]):
4127         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
4128         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
4129         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
4130         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
4131         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
4132         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
4133         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
4134         (-[ServerConnection currentFrame]):
4135         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
4136         (-[ServerConnection knownServers]):
4137
4138 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
4139
4140         Reviewed by Eric.
4141
4142         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
4143           Script to automatically search nightly builds for regressions (bisect-builds)
4144
4145         * Scripts/bisect-builds: Added.
4146
4147 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
4148
4149         Reviewed by Darin.
4150
4151         - New JavaScript benchmark
4152         http://bugs.webkit.org/show_bug.cgi?id=15515
4153
4154         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
4155         current development or release build of JavaScriptCore.
4156
4157 2007-10-15  Mark Rowe  <mrowe@apple.com>
4158
4159         Reviewed by Sam.
4160
4161         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
4162
4163         * Scripts/webkitdirs.pm:
4164         - Change checkArgv to remove the options from @ARGV to prevent
4165         them from interfering with further option processing.
4166         - Fix logic error in determineIsQt that would prevent it from bailing out early.
4167         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
4168         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
4169         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
4170
4171 2007-10-15  Darin Adler  <darin@apple.com>
4172
4173         Reviewed by Sam.
4174
4175         - added logging of window.prompt and window.confirm
4176
4177         * DumpRenderTree/mac/UIDelegate.mm:
4178         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
4179         Implement the recommended delegate rather than the deprecated one.
4180         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
4181         Added.
4182         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
4183         Added.
4184
4185         * DumpRenderTree/win/UIDelegate.h:
4186         * DumpRenderTree/win/UIDelegate.cpp:
4187         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
4188         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
4189         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
4190         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
4191
4192 2007-10-15  Alice Liu  <alice.liu@apple.com>
4193
4194         Reviewed by Sam Weinig.
4195
4196         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
4197
4198         * DumpRenderTree/win/DumpRenderTree.cpp:
4199         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
4200         (main): allocate the global policy delegate for DRT's custom use
4201         * DumpRenderTree/win/DumpRenderTree.vcproj:
4202         Adding files to project
4203         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
4204         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4205         (LayoutTestController::setCustomPolicyDelegate):
4206         set the webview's policy delegate to DRT's custom one if the test requests it.
4207         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
4208         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
4209         (PolicyDelegate::PolicyDelegate):
4210         (PolicyDelegate::QueryInterface):
4211         (PolicyDelegate::AddRef):
4212         (PolicyDelegate::Release):
4213         (PolicyDelegate::decidePolicyForNavigationAction):
4214         * DumpRenderTree/win/PolicyDelegate.h: Added.
4215         (PolicyDelegate::decidePolicyForNewWindowAction):
4216         (PolicyDelegate::decidePolicyForMIMEType):
4217         (PolicyDelegate::unableToImplementPolicyWithError):
4218
4219 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
4220
4221         Reviewed by Mark.
4222
4223         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
4224         when querying for QMAKE_MKSPECS.
4225
4226 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
4227
4228         Reviewed by Adam Roben.
4229         
4230         Fix run-webkit-tests is too greedy calculating platform hierarchy
4231         http://bugs.webkit.org/show_bug.cgi?id=15465
4232         
4233         Fix run-webkit-tests being too greedy in trying to split the platform name up
4234         causing it to try and find tests in every directory above the first "-" in the
4235         path to the LayoutTests
4236
4237         * Scripts/run-webkit-tests:
4238
4239 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
4240
4241         Reviewed by Darin.
4242
4243         http://bugs.webkit.org/show_bug.cgi?id=15006
4244         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
4245         to reduce code duplication.
4246
4247         * Scripts/build-webkit:
4248         * Scripts/webkitdirs.pm:
4249         buildQMakeProject() renamed to buildQMakeQtProject().
4250         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
4251         unused $colorize has been removed.
4252
4253 === Start merge of feature-branch 2007-10-12 ===
4254
4255 2007-10-08  Eric Seidel  <eric@webkit.org>
4256
4257         Reviewed by Mark Rowe.
4258
4259         * Scripts/build-webkit: add --help, remove unused --color
4260
4261 2007-10-07  Eric Seidel  <eric@webkit.org>
4262
4263         Reviewed by darin.
4264
4265         * Drosera/mac/DebuggerDocumentPlatform.mm:
4266         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
4267
4268 2007-10-03  Rob Buis  <buis@kde.org>
4269
4270         Reviewed by Olliej.
4271
4272         Adapt to changed location of Ahem font.
4273
4274         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4275
4276 2007-10-02  Eric Seidel  <eric@webkit.org>
4277
4278         Reviewed by Adam Roben.
4279         
4280         Make pixel tests more useful!
4281         Finally fix the image diff 0.00% mystery problem
4282         Highlight any image differences in the image diff.
4283         Add a link from image diffs back to original test file.
4284
4285         * DumpRenderTree/mac/ImageDiff.m:
4286         (compareImages): highlight any differences
4287         (computePercentageDifferent): round to two decimal places
4288         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
4289
4290 2007-10-02  Eric Seidel  <eric@webkit.org>
4291
4292         Reviewed by Alexey Proskuryakov.
4293
4294         * Scripts/run-webkit-tests: print the % image difference on main results page