WebKitTools/ChangeLog

   1 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
   2
   3         updated reviewers for my previous changelog.
   4
   5 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
   6         Reviewed by Maciej and Adam and Geoff.
   7
   8         - Minor mac-side improvements including moving a function to a more
   9         appropriate location, fixing a warning, and correctly checking
  10         exceptions.
  11
  12         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
  13         (DebuggerDocument::willExecuteStatement):
  14         (DebuggerDocument::didEnterCallFrame):
  15         (DebuggerDocument::willLeaveCallFrame):
  16         (DebuggerDocument::windowScriptObjectAvailable):
  17         (DebuggerDocument::callFunctionOnObject):
  18         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
  19         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
  20         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
  21         because it doesn't require the ServerConnection at all.
  22         (NSStringCreateWithJSStringRef): Made an argument const.
  23         (JSValueRefCreateWithNSString): Made an argument const.
  24         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
  25         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
  26         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
  27         * Drosera/mac/ServerConnection.mm: Ditto.
  28         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
  29
  30 2007-10-29  Sam Weinig  <sam@webkit.org>
  31
  32         Reviewed by Adam Roben.
  33
  34         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
  35
  36         * DumpRenderTree/LayoutTestController.cpp:
  37         (LayoutTestController::LayoutTestController):
  38         (getGlobalFlagCallback):
  39         (setGlobalFlagCallback):
  40         (LayoutTestController::getJSClass):
  41         (LayoutTestController::staticValues):
  42         * DumpRenderTree/LayoutTestController.h:
  43         (LayoutTestController::globalFlag):
  44         (LayoutTestController::setGlobalFlag):
  45
  46 2007-10-29  Darin Adler  <darin@apple.com>
  47
  48         Reviewed by Maciej.
  49
  50         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
  51         resolution instead of its default.
  52
  53 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
  54
  55         Fixed showStatus() to print status for successfully resolved conflicts when using git.
  56
  57         Reviewed by Mark Rowe.
  58
  59         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
  60         was successfully resolved, but this would not show any status because the change had
  61         already been cached in the index using "git add".  The solution is to add an optional
  62         second argument to showStatus() which adds the "--cached" switch to the command.
  63
  64         * Scripts/resolve-ChangeLogs:
  65         (showStatus):
  66
  67 2007-10-28  Eric Seidel  <eric@webkit.org>
  68
  69         Reviewed by Maciej and Geoff, in unison.
  70
  71         * Scripts/run-webkit-tests: remove broken --svg option
  72
  73 2007-10-28  Darin Adler  <darin@apple.com>
  74
  75         Reviewed by Adam.
  76
  77         * Scripts/run-sunspider: Default to "Release" configuration rather than
  78         defaulting to the last configuration used as other scripts do. This can
  79         still be overriden on the command line with "--debug" if there's some
  80         reason to do so. Also fix a typo.
  81
  82         * Scripts/sunspider-compare-results: Fix a typo.
  83
  84 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
  85
  86         Reviewed by Adam.
  87
  88         - Implemented the WebScriptDebugListener functions now that the
  89         WebScriptDebugServer exists
  90
  91         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
  92         functions.
  93         (ServerConnection::currentFrame):
  94         (ServerConnection::didLoadMainResourceForDataSource):
  95         (ServerConnection::didParseSource):
  96         (ServerConnection::failedToParseSource):
  97         (ServerConnection::didEnterCallFrame):
  98         (ServerConnection::willExecuteStatement):
  99         (ServerConnection::willLeaveCallFrame):
 100         (ServerConnection::exceptionWasRaised):
 101         * Drosera/win/ServerConnection.h: Removed unused arguments from the
 102         members arguments list.
 103
 104 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
 105
 106         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
 107         <http://bugs.webkit.org/show_bug.cgi?id=15600>
 108
 109         Reviewed by Darin.
 110
 111         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
 112         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
 113         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
 114         file.  Note that it may also be used as a stand-alone script.
 115
 116         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
 117         * Scripts/resolve-ChangeLogs: Added.
 118         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
 119
 120 2007-10-26  Mark Rowe  <mrowe@apple.com>
 121
 122         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
 123         to the Qt port on the assumption that it was an implementation of the cross-platform
 124         LayoutTestController class.  It is not, so it did not need to be changed.
 125
 126         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
 127
 128 2007-10-25  Mark Rowe  <mrowe@apple.com>
 129
 130         Reviewed by Maciej.
 131
 132         Fix builds with code coverage enabled.
 133
 134         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
 135
 136 2007-10-25  Darin Adler  <darin@apple.com>
 137
 138         Reviewed by Mark Rowe.
 139
 140         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
 141         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
 142
 143 2007-10-25  Stephanie  <slewis@apple.com>
 144
 145         build Fix
 146
 147         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 148
 149 2007-10-25  Stephanie  <slewis@apple.com>
 150
 151         Reviewed by Mark Rowe, Adam Roben.
 152
 153         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
 154
 155         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 156
 157 2007-10-25  Alice Liu  <alice.liu@apple.com>
 158
 159         Reviewed by Adam.
 160
 161         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
 162
 163         Moving destructor into platform-specific files
 164         * DumpRenderTree/LayoutTestController.cpp:
 165         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 166         (LayoutTestController::~LayoutTestController):
 167         * DumpRenderTree/qt/jsobjects.cpp:
 168         (LayoutTestController::~LayoutTestController):
 169
 170         LayoutTestController wasn't being destroyed
 171         * DumpRenderTree/win/DumpRenderTree.cpp:
 172         (runTest):
 173
 174         Added declspec
 175         * DumpRenderTree/win/EditingDelegate.h:
 176
 177         Reset certain values on the webview (or related delegate) that might
 178         have changed while running a test
 179         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 180         (LayoutTestController::~LayoutTestController):
 181
 182 2007-10-25  Adam Roben  <aroben@apple.com>
 183
 184         Make sunspider-compare-results work with relative paths
 185
 186         Reviewed by Sam.
 187
 188         * Scripts/sunspider-compare-results: Convert arguments to absolute
 189         paths before we chdir.
 190
 191 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
 192
 193         Reviewed by Sam.
 194
 195         - Implemented server calls now the WebScriptDebugServer exists.
 196         - Also removed no longer needed call to initialize CG.
 197
 198         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
 199         automatically now.
 200         (_tWinMain):
 201         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
 202         (ServerConnection::ServerConnection):
 203         (ServerConnection::~ServerConnection):
 204         (ServerConnection::pause):
 205         (ServerConnection::resume):
 206         (ServerConnection::stepInto):
 207         (ServerConnection::applicationTerminating):
 208         (ServerConnection::serverConnectionDidDie):
 209         * Drosera/win/ServerConnection.h: Now uses the COM class.
 210
 211 2007-10-24  George Staikos  <staikos@kde.org>
 212
 213         Unbreak Qt build.
 214
 215         * Scripts/build-webkit:
 216
 217 2007-10-24  Adam Roben  <aroben@apple.com>
 218
 219         Remove now-unnecessary call to InitializeCoreGraphics
 220
 221         WebKit takes care of this now.
 222
 223         Reviewed by Ada.
 224
 225         * DumpRenderTree/win/DumpRenderTree.cpp:
 226         (initialize):
 227
 228 2007-10-24  Adam Roben  <aroben@apple.com>
 229
 230         Use WebTextRenderer in DRT
 231
 232         Reviewed by Ada.
 233
 234         * DumpRenderTree/win/DumpRenderTree.cpp:
 235         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
 236
 237 2007-10-24  Sven Herzberg  <sven@imendio.com>
 238
 239         Reviewed by Mark Rowe.
 240
 241         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
 242         Bug 15614: [GTK] qmake based backends don't build on OS X
 243
 244         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
 245         GTK backend on a Mac
 246         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
 247         isDarwin() to make it reusable in other places (like the workaround-
 248         for-prebuilt-qmake in build-webkit)
 249
 250 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
 251
 252         Refurbish update-webkit script.
 253
 254         Reviewed by Adam.
 255
 256         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
 257         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
 258         multi-argument version of system() for flexibility and security.  Check for existence
 259         of Internal directory using -d test instead of -x.
 260
 261 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
 262
 263         Minor clean-up of prepare-ChangeLog script.
 264
 265         Reviewed by Adam.
 266
 267         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
 268         of a string.  Use multi-argument versions of open() and system() for flexibility and
 269         security.
 270
 271 2007-10-24  Alice Liu  <alice.liu@apple.com>
 272
 273         Reviewed by Oliver.
 274
 275         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
 276
 277         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
 278         replay the saved events when we're still processing the mousedown that starts the drag
 279         * DumpRenderTree/win/EventSender.cpp:
 280         (doMouseMove):
 281         * DumpRenderTree/win/UIDelegate.cpp:
 282         (UIDelegate::doDragDrop):
 283
 284 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
 285
 286         Reviewed by Sam, Steve and Darin.
 287
 288         - Stubbed out the WebScriptDebugListener functionality in the Server
 289         Connection class to prepare it for receiving those callbacks.
 290         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
 291         and the ServerConnection to not need to be initialized with a server
 292         name, since that is not the way we connect to the WebKit server.
 293
 294         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
 295         no exception.  Now it only loggs when there is an exception
 296         (DebuggerDocument::willExecuteStatement):
 297         (DebuggerDocument::didEnterCallFrame):
 298         (DebuggerDocument::willLeaveCallFrame):
 299         (DebuggerDocument::windowScriptObjectAvailable):
 300         (DebuggerDocument::callFunctionOnObject):
 301         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
 302         to be instantiated with a server's name.
 303         (DebuggerClient::DebuggerClient):
 304         (DebuggerClient::didFinishLoadForFrame):
 305         * Drosera/win/DebuggerClient.h: Removed unsued variable.
 306         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
 307         a server name.
 308         (Drosera::init):
 309         (Drosera::initServer):
 310         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
 311         instantiated with a server's name.
 312         * Drosera/win/ServerConnection.cpp:
 313         (ServerConnection::ServerConnection): No longer needs a server name
 314         (ServerConnection::~ServerConnection): Only release the global context
 315         if there is one.
 316         (ServerConnection::serverConnectionDidDie): Stub for
 317         IWebScriptDebugListener
 318         (ServerConnection::QueryInterface): ditto
 319         (ServerConnection::AddRef): ditto
 320         (ServerConnection::Release): ditto
 321         (ServerConnection::didLoadMainResourceForDataSource): ditto
 322         (ServerConnection::didParseSource): ditto
 323         (ServerConnection::failedToParseSource): ditto
 324         (ServerConnection::didEnterCallFrame): ditto
 325         (ServerConnection::willExecuteStatement): ditto
 326         (ServerConnection::willLeaveCallFrame): ditto
 327         (ServerConnection::exceptionWasRaised): ditto
 328         * Drosera/win/ServerConnection.h: Stubbed out the
 329         IWebScriptDebugListener functions, and this class no longer needs to be
 330         instantiated with a server name.
 331
 332 2007-10-24  Lars Knoll  <lars@trolltech.com>
 333
 334         Reviewed by Simon.
 335
 336         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
 337
 338         * DumpRenderTree/qt/jsobjects.h:
 339
 340 2007-10-24  Lars Knoll  <lars@trolltech.com>
 341
 342         Reviewed by Simon.
 343
 344         add another command.
 345
 346         * DumpRenderTree/qt/jsobjects.cpp:
 347         (TextInputController::doCommand):
 348
 349 2007-10-24  Lars Knoll  <lars@trolltech.com>
 350
 351         Reviewed by Simon.
 352
 353         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
 354
 355         * DumpRenderTree/qt/jsobjects.cpp:
 356         (EventSender::keyDown):
 357         * DumpRenderTree/qt/jsobjects.h:
 358
 359 2007-10-24  Lars Knoll  <lars@trolltech.com>
 360
 361         Reviewed by Simon.
 362
 363         implement eventSender.keyDown().
 364
 365         * DumpRenderTree/qt/jsobjects.cpp:
 366         (EventSender::keyDown):
 367
 368 2007-10-24  Lars Knoll  <lars@trolltech.com>
 369
 370         Reviewed by Simon.
 371
 372         some smaller fixes to the editing support in DRT. Makes another few tests pass.
 373
 374         * DumpRenderTree/qt/DumpRenderTree.cpp:
 375         (WebCore::DumpRenderTree::DumpRenderTree):
 376         (WebCore::DumpRenderTree::initJSObjects):
 377         * DumpRenderTree/qt/jsobjects.cpp:
 378         (TextInputController::doCommand):
 379
 380 2007-10-24  Lars Knoll  <lars@trolltech.com>
 381
 382         Reviewed by Simon.
 383
 384         first bit of implementation for the textinputcontroller.
 385
 386         * DumpRenderTree/qt/DumpRenderTree.cpp:
 387         (WebCore::DumpRenderTree::DumpRenderTree):
 388         * DumpRenderTree/qt/DumpRenderTree.h:
 389         * DumpRenderTree/qt/jsobjects.cpp:
 390         (TextInputController::TextInputController):
 391         (TextInputController::doCommand):
 392         * DumpRenderTree/qt/jsobjects.h:
 393
 394 2007-10-24  Lars Knoll  <lars@trolltech.com>
 395
 396         Reviewed by Simon.
 397
 398         make the man webpage believe it has focus, so the editing tests work correctly.
 399
 400         * DumpRenderTree/qt/DumpRenderTree.cpp:
 401         (WebCore::DumpRenderTree::DumpRenderTree):
 402
 403 2007-10-24  Lars Knoll  <lars@trolltech.com>
 404
 405         Reviewed by Simon.
 406
 407         implement layoutTestController.dumpEditingCallbacks() correctly.
 408
 409         * DumpRenderTree/qt/DumpRenderTree.cpp:
 410         (WebCore::DumpRenderTree::DumpRenderTree):
 411         * DumpRenderTree/qt/jsobjects.cpp:
 412         (LayoutTestController::reset):
 413         (LayoutTestController::dumpEditingCallbacks):
 414
 415 2007-10-24  Lars Knoll  <lars@trolltech.com>
 416
 417         Reviewed by Simon.
 418
 419         Implement support for testing editing.
 420
 421         * DumpRenderTree/qt/DumpRenderTree.cpp:
 422         (WebCore::DumpRenderTree::DumpRenderTree):
 423
 424 2007-10-23  Sam Weinig  <sam@webkit.org>
 425
 426         Check for null BSTR that can be passed to the UIDelegate methods
 427         from javascript null and undefined.  Fixes a failing test case on
 428         Windows (fast/dom/Window/alert-undefined.html)
 429
 430         Reviewed by Eric Seidel.
 431
 432         * DumpRenderTree/win/UIDelegate.cpp:
 433         (UIDelegate::runJavaScriptAlertPanelWithMessage):
 434         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
 435         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
 436         (UIDelegate::webViewAddMessageToConsole):
 437
 438 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
 439
 440         Reviewed by Darin.
 441
 442         Don't print a massive pile of setenvs from tools that automatically build testkjs.
 443
 444         * Scripts/build-testkjs:
 445
 446 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
 447
 448         Reviewed by Darin.
 449
 450         - add wrapper that finds the right copy of testkjs
 451
 452         * Scripts/sunspider-compare-results: Added.
 453
 454 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
 455
 456         Reviewed by Sam.
 457
 458         - After talking with Steve I now see that the WebKit server must be
 459         running for DCOM to create the distributed objects, which makes sense
 460         and currently WebKit only allows one instance to be running at a time
 461         which avoids accidentally connecting to the wrong server
 462         - In light of this I have removed the code for the attach box and
 463         NotificationServer and known server names, since they are all extranious
 464         now.
 465
 466         * Drosera/win/Drosera.cpp: Removed notification classes and known server
 467         names.
 468         (_tWinMain): Uses init instead of initUI.
 469         (droseraWndProc): No longer creats an attach dialog box.
 470         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
 471         it's not manditory to call init before doing COM stuff.
 472         (Drosera::init): calls initUI and will call attach when the
 473         functionality exists.
 474         (Drosera::initUI): Has changed very little.
 475         (Drosera::attach): Changed the signature to reflect that we no longer
 476         need the dictionary of known server names.
 477         * Drosera/win/Drosera.h: Removed notification classes and known server
 478         names.  Also renamed and moved some functions.
 479         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
 480         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
 481         headers to the resources folder.
 482         * Drosera/win/resource.h: Removed the Attach box.
 483
 484 2007-10-22  Adam Roben  <aroben@apple.com>
 485
 486         Windows build fix
 487
 488         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
 489
 490 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
 491
 492         - Removed a leak that was fixed.
 493
 494         * Scripts/run-webkit-tests:
 495
 496 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
 497
 498         Reviewed by Darin.
 499
 500         - Changed the Client so that the DebuggerDocument now own the
 501         ServerConnection.  This simplifies ownership and cleanup.
 502
 503         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
 504         ServerConnection.
 505         (DebuggerClient::initWithServerName):
 506         (DebuggerClient::didFinishLoadForFrame):
 507         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the
 508         ServerConnection.
 509         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
 510         until after we have a server which we are attached to.
 511         (Drosera::initUI):
 512         (Drosera::attach):
 513         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
 514         out previously.
 515
 516 2007-10-22  Simon Hausmann  <hausmann@kde.org>
 517
 518         Reviewed by Nikolas.
 519
 520         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
 521
 522         * Scripts/run-javascriptcore-tests:
 523
 524 2007-10-22  Simon Hausmann  <hausmann@kde.org>
 525
 526         Reviewed by Nikolas.
 527
 528         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
 529
 530         * Scripts/build-drosera:
 531         * Scripts/build-dumprendertree:
 532         * Scripts/build-testkjs:
 533         * Scripts/build-webkit:
 534         * Scripts/run-javascriptcore-tests:
 535         * Scripts/run-sunspider:
 536         * Scripts/run-webkit-tests:
 537         * Scripts/webkitdirs.pm:
 538
 539 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
 540
 541         Reviewed by Mark Rowe.
 542
 543         Fix for local database support after r26879
 544         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
 545
 546         * Scripts/build-webkit:
 547
 548 2007-10-22  Holger Freyther  <zecke@selfish.org>
 549
 550         Reviewed by Simon Hausmann <hausmann@kde.org>.
 551
 552         - Do not build testkjs as an application bundle. This is
 553         needed for run-javascriptcore-tests on OSX.
 554         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
 555         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
 556         as we do not have -rpath on OSX.
 557
 558         * DumpRenderTree/qt/DumpRenderTree.pro:
 559         * Scripts/run-webkit-tests:
 560
 561 2007-10-22  Simon Hausmann  <hausmann@kde.org>
 562
 563         Reviewed by aroben.
 564
 565         Fix support for Signed-off-by detection in prepare-ChangeLog
 566         --git-commit. The Signed-off-by tag does not appear in the header
 567         but usually at the end.
 568
 569         * Scripts/prepare-ChangeLog:
 570
 571 2007-10-21  Mark Rowe  <mrowe@apple.com>
 572
 573         Reviewed by Eric.
 574
 575         Fix run-javascriptcore-tests for Gtk.
 576
 577         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
 578
 579 2007-10-20  Eric Seidel  <eric@webkit.org>
 580
 581         Reviewed by aroben.
 582
 583         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
 584
 585 2007-10-20  Eric Seidel  <eric@webkit.org>
 586
 587         Reviewed by darin.
 588
 589         Add improved argument handling to run-sunspider, including
 590         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
 591         Also re-factor code into subroutines
 592
 593         * Scripts/build-dumprendertree: removed bogus comments
 594         * Scripts/build-testkjs: Added.
 595         * Scripts/run-javascriptcore-tests: use build-testkjs
 596         * Scripts/run-sunspider: improved argument handling, abstraction
 597         * Scripts/run-webkit-tests: improved abstraction
 598
 599 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
 600
 601         Not reviewed, Windows build fix.
 602
 603         * DumpRenderTree/win/EventSender.cpp:
 604         (keyDownCallback):
 605
 606 2007-10-20  Darin Adler  <darin@apple.com>
 607
 608         Reviewed by Tim Hatcher.
 609
 610         - http://bugs.webkit.org/show_bug.cgi?id=15544
 611           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
 612           not rely on Apple-specific key codes
 613
 614         * DumpRenderTree/mac/EventSendingController.mm:
 615         (-[EventSendingController keyDown:withModifiers:]):
 616         Added named key "rightArrow". Later we could have a whole table of these.
 617         Also tweaked modifiers code a little.
 618
 619         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
 620
 621 2007-10-19  Darin Adler  <darin@apple.com>
 622
 623         Reviewed by Eric.
 624
 625         - http://bugs.webkit.org/show_bug.cgi?id=15566
 626           possible fix for leak seen in DumpRenderTree
 627
 628         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
 629         Delete the item if it's not put on the queue, since the caller has
 630         no way of knowing that. Would be better to have the parameter type
 631         be auto_ptr to express the fact that we take ownership.
 632
 633         - unrelated change
 634
 635         * Drosera/mac/main.m: Add missing include.
 636
 637 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
 638
 639         Reviewed by Adam.
 640
 641         - This change should be identical but for some reason was not working
 642         on my machine.
 643
 644         * Scripts/prepare-ChangeLog:
 645
 646 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
 647
 648         Reviewed by Oliver and Tim.
 649
 650         - Made use of RetainPtr to avoid retain and release issues and moved the
 651         log function to DebuggerDocumentPlatform, which seems to be a more
 652         logical place for it to live.
 653         - Also moved knownServers from the ServerConnection to
 654         DebuggerApplication to match the Windows code and because it makes sense
 655         that a connection knows its own server but not all of them.
 656
 657         * Drosera/mac/DebuggerClient.h: Moved the log function to
 658           DebuggerDocumentPlatform.
 659         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
 660           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
 661           call for the server name up from the ServerConnection class.
 662         (-[DebuggerClient dealloc]):
 663         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
 664           for the server name up from the ServerConnection.
 665         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
 666         (DebuggerDocument::platformPause):
 667         (DebuggerDocument::platformResume):
 668         (DebuggerDocument::platformStepInto):
 669         (DebuggerDocument::platformEvaluateScript):
 670         (DebuggerDocument::getPlatformCurrentFunctionStack):
 671         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 672         (DebuggerDocument::platformValueForScopeVariableNamed):
 673         (DebuggerDocument::platformLog): Log directly from here. No need to call
 674           DebuggerClient.
 675         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
 676           way I see it, a ServerConnection should only know about its connection
 677           and the group of all possible servers should be kept by the
 678           application.
 679         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
 680           currentServerName, it makes sense that the connection should know that
 681           name.
 682         (-[ServerConnection currentServerName]):
 683
 684 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
 685
 686         Reviewed by Adam.
 687
 688         - Integrated changes from mac drosera.  Recently I've encapsulated
 689         out the server connection object from the rest of Drosera because
 690         it is very platform dependent right now and RPC is not implemented on
 691         windows.  This functionality, of communicating with the WebKit server
 692         is the next area I will be focusing on in Windows.
 693
 694         - Other changes and cleanup were made to organize the code and add notes
 695         on which parts still need work.  Also some mac code is added and
 696         commented out, to act as pseudocode for the logic of those parts.
 697
 698         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
 699           pointer.
 700         * Drosera/config.h: Added whitespace.
 701         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
 702           these files got moved into Drosera.h/cpp
 703         * Drosera/win/DebuggerApplication.h: Removed.
 704         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring
 705           happened here to better match the logic flow of the same code on the
 706           mac side and to use the new ServerConnection class.
 707         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
 708         (DebuggerClient::initWithServerName): Initializer that will set up the
 709           class to use a ServerConnection object.  This was necessary so I could
 710           create a DebuggerClient without having to initilaize it at
 711           construction.
 712         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
 713           will be the UIDelegate and FrameLoadDelegate.
 714         (DebuggerClient::AddRef): For IUnknown.
 715         (DebuggerClient::Release): For IUnknown.
 716         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
 717           this still needs to set the global context of the server, but
 718           IWebFrame does not have an accessor for the global context yet.
 719         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
 720           this is a pass through for the same function in the document.
 721         (DebuggerClient::didReceiveTitle): Unimplemented part of
 722           FrameLoadDelegate this would change the title of the window.
 723         (DebuggerClient::createWebViewWithRequest): Part of the
 724           FrameLoadDelegate.  This is about new windows via Window.open() and
 725           how their delegates are set.
 726         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
 727           UIDelegate.  Just a debug function for printing messages.
 728         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
 729           because the Client should be the UIDelegate and FrameLoadDelegate
 730           to match the delegates on mac.
 731         (DebuggerClient::webViewLoaded): Added accessor method.
 732         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
 733           forgotten to add this file before.  This is where the platform
 734           dependent versions of the Documents functions live. Most of these are
 735           unimplemented because some piece of functionality does not exist on
 736           Windows yet.
 737         (DebuggerDocument::platformPause):
 738         (DebuggerDocument::platformResume):
 739         (DebuggerDocument::platformStepInto):
 740         (DebuggerDocument::platformEvaluateScript):
 741         (DebuggerDocument::getPlatformCurrentFunctionStack):
 742         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 743         (DebuggerDocument::platformValueForScopeVariableNamed):
 744         (DebuggerDocument::platformLog):
 745         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
 746           responsibilities becaue they belong in the Client. Also I laid the
 747           groundwork for attaching Drosera to a WebKit process
 748         (attachWndProc): Now if a server is selected the Client becomes it's
 749           delegate.
 750         (Drosera::Drosera): Added the construction of the Client and dictionary
 751           of server names.
 752         (Drosera::initUI): This is no longer the delegates, the Client is.
 753         (Drosera::webViewLoaded): Now asks the Client instead of holding local
 754           state.
 755         (Drosera::applicationDidFinishLaunching): Placeholder for needed
 756           notification registration when it's possible to implement.
 757         (Drosera::serverLoaded): Ditto
 758         (Drosera::serverUnloaded): Ditto
 759         (Drosera::attach): Attach Drosera to the WebKit server.
 760         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
 761         (Drosera::getInst):
 762         (Drosera::setInst):
 763         (Drosera::knownServers):
 764         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
 765           and added the ServerConnection.
 766         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
 767         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
 768           Most of the functions are completely unimlemented because they cannot
 769           connect with the WebKit server, because one does not exist on Windows
 770           yet.
 771         (ServerConnection::initWithServerName):
 772         (ServerConnection::~ServerConnection):
 773         (ServerConnection::setGlobalContext):
 774         (ServerConnection::pause):
 775         (ServerConnection::resume):
 776         (ServerConnection::stepInto):
 777         (ServerConnection::switchToServerNamed):
 778         (ServerConnection::applicationTerminating):
 779         (ServerConnection::serverConnectionDidDie):
 780         (ServerConnection::currentFrame):
 781         * Drosera/win/ServerConnection.h: Added. Ditto.
 782         (ServerConnection::ServerConnection):
 783
 784 2007-10-19  Alice Liu  <alice.liu@apple.com>
 785
 786         Reviewed by Darin.
 787
 788         Fix for these broken layout tests on Windows:
 789
 790         fast/forms/focus-selection-input.html
 791         fast/forms/focus-selection-textarea.html
 792         fast/forms/select-accesskey.html
 793
 794         * DumpRenderTree/win/EventSender.cpp:
 795         (keyDownCallback):
 796         correct the VK code for alt key.
 797
 798 2007-10-19  Eric Seidel  <eric@webkit.org>
 799
 800         Reviewed by Mark Rowe.
 801
 802         Make the GtkLauncher code slightly more readable.
 803
 804         * GtkLauncher/main.cpp:
 805         (setupMainMenu): Added.
 806         (setupMainWindowUI): Added.
 807         (main):
 808
 809 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
 810
 811         Rubber stamped by Adam.
 812
 813         - don't delay-load WebKit in DumpRenderTree.
 814
 815         * DumpRenderTree/win/DumpRenderTree.vcproj:
 816
 817 2007-10-18  Dan Bernstein  <dan.bernstein@apple.com>
 818
 819         Reviewed by Adam Roben.
 820
 821         - fix <rdar://problem/5313523>
 822         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
 823
 824         * DumpRenderTree/mac/DumpRenderTree.mm:
 825         (dump): Changed to use _responseMIMEType.
 826
 827 2007-10-17  Adam Roben  <aroben@apple.com>
 828
 829         Make it possible to have Windows-specific tests and results
 830
 831         When searching for tests to run and the Skipped file, we will only
 832         look in platform/win and the cross-platform directory. When looking
 833         for expected results, we will look in platform/win, then
 834         platform/mac-leopard, then platform/mac, then finally the
 835         cross-platform directory.
 836
 837         Reviewed by Sam.
 838
 839         * Scripts/run-webkit-tests:
 840         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
 841         searching in the cross-platform directory.
 842         (sub buildPlatformHierarchy): Removed some unneeded calls to
 843         dirname/basename.
 844
 845 2007-10-17  Adam Roben  <aroben@apple.com>
 846
 847         Add back the call to register WebKit that we had before WebKitInitializer existed
 848
 849         This is needed to ensure that the right WebKit is used when
 850         instantiating COM objects.
 851
 852         Reviewed by Oliver.
 853
 854         * DumpRenderTree/win/debug_internal.vsprops: Define
 855         DEBUG_WEBKIT_HAS_SUFFIX.
 856         * DumpRenderTree/win/DumpRenderTree.cpp:
 857         (initialize):
 858
 859 2007-10-17  Adam Roben  <aroben@apple.com>
 860
 861         Import File::Basename in webkitdirs since we use it
 862
 863         * Scripts/webkitdirs.pm:
 864
 865 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
 866
 867         - Updated the tiger leaks list to make the internal bots green.
 868
 869         * Scripts/run-webkit-tests:
 870
 871 2007-10-17  Adam Roben  <aroben@apple.com>
 872
 873         Build fix for VC++ Express
 874
 875         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
 876         and ole32.lib.
 877
 878 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
 879
 880         Reviewed by Sam.
 881
 882         - Minor mac improvements based on observations I made while implementing the
 883         Windows code.
 884
 885         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
 886         then hand it to the Client who will retain it, it should just be the client who
 887         creates and owns the server.
 888         (-[DebuggerApplication attach:]):
 889         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
 890         * Drosera/mac/DebuggerClient.mm: Creates the server.
 891         (-[DebuggerClient initWithServerName:]):
 892         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
 893         can instead forward declare what it needs.
 894
 895 2007-10-16  Darin Adler  <darin@apple.com>
 896
 897         Reviewed by Geoff Garen.
 898
 899         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
 900         want to turn failing tests into platform-specific test results. Also did a
 901         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
 902         would take the type of results into account only some of the time.
 903
 904 2007-10-16  Adam Roben  <aroben@apple.com>
 905
 906         Add a new nightly launcher script for Windows
 907
 908         This new script is for versions of Safari that don't delay-load
 909         WebKit. I had to make FindSafari be able to print out the nightly
 910         launcher script on stdout because Windows shell scripts can't capture
 911         the output from a command into an environment variable.
 912
 913         Reviewed by Steve.
 914
 915         * FindSafari/FindSafari.cpp:
 916         (_tmain): Added /printSafariLauncher option.
 917         * Scripts/run-webkit-nightly.cmd: Added.
 918
 919 2007-10-16  Adam Roben  <aroben@apple.com>
 920
 921         Replace WebKitInitializer with FindSafari
 922
 923         We now rely on setting the PATH environment variable to tell Windows
 924         where to find WebKit and its dependencies (similar to
 925         DYLD_FRAMEWORK_PATH on Mac).
 926
 927         This change also make DumpRenderTree no longer delay-load WebKit.
 928
 929         Reviewed by Sam.
 930
 931         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
 932         FindSafari.
 933         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
 934         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
 935         WebKitInitializer, don't delay-load WebKit.
 936         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
 937         * Scripts/run-webkit-tests: Ditto.
 938         * Scripts/webkitdirs.pm:
 939         (sub setPathForRunningWebKitApp): Added.
 940         * WebKitInitializer/WebKitInitializer.cpp: Removed.
 941         * WebKitInitializer/WebKitInitializer.h: Removed.
 942         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
 943         * WebKitInitializer/debug.vsprops: Removed.
 944         * WebKitInitializer/debug_internal.vsprops: Removed.
 945         * WebKitInitializer/release.vsprops: Removed.
 946
 947 2007-10-16  Adam Roben  <aroben@apple.com>
 948
 949         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
 950
 951         http://bugs.webkit.org/show_bug.cgi?id=15532
 952
 953         FindSafari simply prints the location of an installed Safari.exe on
 954         stdout.
 955
 956         Reviewed by Darin.
 957
 958         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
 959         (getStringValue):
 960         (getWebViewCLSID):
 961         (getInstalledWebKitDirectory):
 962         (_tmain):
 963         * FindSafari/FindSafari.vcproj: Added.
 964         * Scripts/webkitdirs.pm:
 965         (sub installedSafariPath): Added. Calls FindSafari on Windows.
 966
 967 2007-10-16  Adam Roben  <aroben@apple.com>
 968
 969         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
 970
 971         Reviewed by Kevin McCullough.
 972
 973         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
 974         when referring to WebKit.dll.
 975         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
 976         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
 977         * DumpRenderTree/win/release.vsprops: Ditto.
 978         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
 979         never have a _debug suffix on WebKit.dll.
 980         * WebKitInitializer/WebKitInitializer.cpp:
 981         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
 982         specified.
 983         * WebKitInitializer/debug_internal.vsprops: Added
 984         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
 985
 986 2007-10-16  Darin Adler  <darin@apple.com>
 987
 988         Reviewed by Adele.
 989
 990         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
 991         Remove now-unneeded control/alt key hack; the tests have been updated.
 992
 993 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
 994
 995         - Updated leaks list because our internal bot upgraded it's version of leopard and
 996         one of the leaks was fixed between that revision and the bot's previous version of
 997         leopard.
 998
 999         * Scripts/run-webkit-tests:
1000
1001 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
1002
1003         Reviewed by Tim.
1004
1005         - I encapsulated out the server connecton functionality because it is a specific part
1006         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
1007         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
1008         Windows.  So the majority of this patch is moving preexisting functionality.
1009
1010         - Also I removed the prefix header and changed to use config.h because it is more
1011         standard on how we use config.h in windows and it didn't make much sense to keep
1012         the prefix header and the config.h
1013
1014         * Drosera/DebuggerDocument.cpp:
1015         (DebuggerDocument::DebuggerDocument):
1016         * Drosera/DebuggerDocument.h:
1017         * Drosera/config.h:
1018         * Drosera/mac/DebuggerApplication.mm:
1019         (-[DebuggerApplication attach:]):
1020         * Drosera/mac/DebuggerClient.h:
1021         * Drosera/mac/DebuggerClient.mm:
1022         (-[DebuggerClient initWithServerConnection:]):
1023         (-[DebuggerClient dealloc]):
1024         (-[DebuggerClient windowDidLoad]):
1025         (-[DebuggerClient windowWillClose:]):
1026         (-[DebuggerClient webView:didFinishLoadForFrame:]):
1027         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
1028         * Drosera/mac/DebuggerDocumentPlatform.mm:
1029         (DebuggerDocument::platformPause):
1030         (DebuggerDocument::platformResume):
1031         (DebuggerDocument::platformStepInto):
1032         (DebuggerDocument::platformEvaluateScript):
1033         (DebuggerDocument::getPlatformCurrentFunctionStack):
1034         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1035         (DebuggerDocument::platformValueForScopeVariableNamed):
1036         (DebuggerDocument::platformLog):
1037         * Drosera/mac/Drosera.pch: Removed.
1038         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1039         * Drosera/mac/ServerConnection.h: Added.
1040         * Drosera/mac/ServerConnection.mm: Added.
1041         (-[ServerConnection initWithServerName:]):
1042         (-[ServerConnection dealloc]):
1043         (-[ServerConnection setGlobalContext:]):
1044         (-[ServerConnection pause]):
1045         (-[ServerConnection resume]):
1046         (-[ServerConnection stepInto]):
1047         (-[ServerConnection switchToServerNamed:]):
1048         (-[ServerConnection applicationTerminating:]):
1049         (-[ServerConnection serverConnectionDidDie:]):
1050         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1051         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
1052         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
1053         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
1054         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
1055         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
1056         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
1057         (-[ServerConnection currentFrame]):
1058         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
1059         (-[ServerConnection knownServers]):
1060
1061 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
1062
1063         Reviewed by Eric.
1064
1065         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
1066           Script to automatically search nightly builds for regressions (bisect-builds)
1067
1068         * Scripts/bisect-builds: Added.
1069
1070 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
1071
1072         Reviewed by Darin.
1073
1074         - New JavaScript benchmark
1075         http://bugs.webkit.org/show_bug.cgi?id=15515
1076
1077         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
1078         current development or release build of JavaScriptCore.
1079
1080 2007-10-15  Mark Rowe  <mrowe@apple.com>
1081
1082         Reviewed by Sam.
1083
1084         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
1085
1086         * Scripts/webkitdirs.pm:
1087         - Change checkArgv to remove the options from @ARGV to prevent
1088         them from interfering with further option processing.
1089         - Fix logic error in determineIsQt that would prevent it from bailing out early.
1090         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
1091         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
1092         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
1093
1094 2007-10-15  Darin Adler  <darin@apple.com>
1095
1096         Reviewed by Sam.
1097
1098         - added logging of window.prompt and window.confirm
1099
1100         * DumpRenderTree/mac/UIDelegate.mm:
1101         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1102         Implement the recommended delegate rather than the deprecated one.
1103         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
1104         Added.
1105         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1106         Added.
1107
1108         * DumpRenderTree/win/UIDelegate.h:
1109         * DumpRenderTree/win/UIDelegate.cpp:
1110         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
1111         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1112         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
1113         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
1114
1115 2007-10-15  Alice Liu  <alice.liu@apple.com>
1116
1117         Reviewed by Sam Weinig.
1118
1119         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
1120
1121         * DumpRenderTree/win/DumpRenderTree.cpp:
1122         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
1123         (main): allocate the global policy delegate for DRT's custom use
1124         * DumpRenderTree/win/DumpRenderTree.vcproj:
1125         Adding files to project
1126         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
1127         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1128         (LayoutTestController::setCustomPolicyDelegate):
1129         set the webview's policy delegate to DRT's custom one if the test requests it.
1130         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
1131         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
1132         (PolicyDelegate::PolicyDelegate):
1133         (PolicyDelegate::QueryInterface):
1134         (PolicyDelegate::AddRef):
1135         (PolicyDelegate::Release):
1136         (PolicyDelegate::decidePolicyForNavigationAction):
1137         * DumpRenderTree/win/PolicyDelegate.h: Added.
1138         (PolicyDelegate::decidePolicyForNewWindowAction):
1139         (PolicyDelegate::decidePolicyForMIMEType):
1140         (PolicyDelegate::unableToImplementPolicyWithError):
1141
1142 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
1143
1144         Reviewed by Mark.
1145
1146         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
1147         when querying for QMAKE_MKSPECS.
1148
1149 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
1150
1151         Reviewed by Adam Roben.
1152
1153         Fix run-webkit-tests is too greedy calculating platform hierarchy
1154         http://bugs.webkit.org/show_bug.cgi?id=15465
1155
1156         Fix run-webkit-tests being too greedy in trying to split the platform name up
1157         causing it to try and find tests in every directory above the first "-" in the
1158         path to the LayoutTests
1159
1160         * Scripts/run-webkit-tests:
1161
1162 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
1163
1164         Reviewed by Darin.
1165
1166         http://bugs.webkit.org/show_bug.cgi?id=15006
1167         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
1168         to reduce code duplication.
1169
1170         * Scripts/build-webkit:
1171         * Scripts/webkitdirs.pm:
1172         buildQMakeProject() renamed to buildQMakeQtProject().
1173         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
1174         unused $colorize has been removed.
1175
1176 === Start merge of feature-branch 2007-10-12 ===
1177
1178 2007-10-08  Eric Seidel  <eric@webkit.org>
1179
1180         Reviewed by Mark Rowe.
1181
1182         * Scripts/build-webkit: add --help, remove unused --color
1183
1184 2007-10-07  Eric Seidel  <eric@webkit.org>
1185
1186         Reviewed by darin.
1187
1188         * Drosera/mac/DebuggerDocumentPlatform.mm:
1189         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
1190
1191 2007-10-03  Rob Buis  <buis@kde.org>
1192
1193         Reviewed by Olliej.
1194
1195         Adapt to changed location of Ahem font.
1196
1197         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1198
1199 2007-10-02  Eric Seidel  <eric@webkit.org>
1200
1201         Reviewed by Adam Roben.
1202
1203         Make pixel tests more useful!
1204         Finally fix the image diff 0.00% mystery problem
1205         Highlight any image differences in the image diff.
1206         Add a link from image diffs back to original test file.
1207
1208         * DumpRenderTree/mac/ImageDiff.m:
1209         (compareImages): highlight any differences
1210         (computePercentageDifferent): round to two decimal places
1211         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
1212
1213 2007-10-02  Eric Seidel  <eric@webkit.org>
1214
1215         Reviewed by Alexey Proskuryakov.
1216
1217         * Scripts/run-webkit-tests: print the % image difference on main results page
1218
1219 2007-10-02  Mark Rowe  <mrowe@apple.com>
1220
1221         Reviewed by Oliver.
1222
1223         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1224
1225         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1226         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1227
1228 2007-10-01  Mark Rowe  <mrowe@apple.com>
1229
1230         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1231
1232 2007-09-25  Eric Seidel  <eric@webkit.org>
1233
1234         Reviewed by Mark Rowe.
1235
1236         DerivedSources.make was finding "ENABLE_SVG" in the string
1237         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
1238         quite correctly.
1239
1240         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
1241
1242 2007-09-25  Mark Rowe  <mrowe@apple.com>
1243
1244         Rubber-stamped by Eric.
1245
1246         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1247         This makes it possible to automate nightly builds for the feature-branch.
1248
1249 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
1250
1251         Rubber stamped by Mark.
1252
1253         Enable svg experimental features as default here in feature-branch.
1254
1255         * Scripts/build-webkit:
1256
1257 2007-06-29  Antti Koivisto  <antti@apple.com>
1258
1259         Reviewed by Weinig.
1260
1261         Add VIDEO flag for timed media features
1262
1263         * Scripts/build-webkit
1264
1265 === End merge of feature-branch 2007-10-12 ===
1266
1267 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1268
1269         Reviewed by Darin.
1270
1271         - Updated rational for the leaks list to be more clear.
1272
1273         * Scripts/run-webkit-tests:
1274
1275 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1276
1277         Rubber Stamp by Sam.
1278
1279         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
1280         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
1281
1282         * Scripts/run-webkit-tests:
1283
1284 2007-10-10  Simon Hausmann  <hausmann@kde.org>
1285
1286         Reviewed by Lars.
1287
1288         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
1289         includes are needed for INT_MAX, std::auto_ptr and the like.
1290
1291         * DumpRenderTree/qt/main.cpp:
1292
1293 2007-10-09  Lars Knoll  <lars@trolltech.com>
1294
1295         Reviewed by Simon.
1296
1297         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
1298
1299         * DumpRenderTree/qt/jsobjects.cpp:
1300         (LayoutTestController::encodeHostName):
1301         (LayoutTestController::decodeHostName):
1302         * DumpRenderTree/qt/jsobjects.h:
1303
1304 2007-10-09  Lars Knoll  <lars@trolltech.com>
1305
1306         Reviewed by Simon.
1307
1308         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
1309
1310         * DumpRenderTree/qt/DumpRenderTree.cpp:
1311         (WebCore::WebPage::createFrame):
1312         (WebCore::DumpRenderTree::DumpRenderTree):
1313         (WebCore::DumpRenderTree::titleChanged):
1314         * DumpRenderTree/qt/DumpRenderTree.h:
1315         * DumpRenderTree/qt/jsobjects.cpp:
1316         (LayoutTestController::reset):
1317         * DumpRenderTree/qt/jsobjects.h:
1318
1319 2007-10-09  Lars Knoll  <lars@trolltech.com>
1320
1321         Reviewed by Simon.
1322
1323         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
1324
1325         * DumpRenderTree/qt/DumpRenderTree.h:
1326         * DumpRenderTree/qt/jsobjects.cpp:
1327         (LayoutTestController::clearBackForwardList):
1328         * DumpRenderTree/qt/jsobjects.h:
1329
1330 2007-10-09  Lars Knoll  <lars@trolltech.com>
1331
1332         Reviewed by Simon.
1333
1334         make --git-reviewer work again.
1335
1336         * Scripts/prepare-ChangeLog:
1337
1338 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
1339
1340         Rubber stamped by Eric.
1341
1342         Connect to the "hovering-over-link" signal emitted by WebKitPage and
1343         show the current link inside the statusbar.
1344         This shows how to make use of this signal and allows to easily test
1345         http://bugs.webkit.org/show_bug.cgi?id=15299.
1346
1347         * GtkLauncher/main.cpp:
1348         (hoveringOverLink):
1349         (main):
1350
1351 2007-10-05  Lars Knoll  <lars@trolltech.com>
1352
1353         add proper error messages to the FrameLoaderClient.
1354         Implement ChromeClientQt::closeWindowSoon and
1355         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
1356         Some fixes in DRT to make it work correctly with multiple windows.
1357
1358         Reviewed by Maciej.
1359
1360         * DumpRenderTree/qt/DumpRenderTree.cpp:
1361         (WebCore::DumpRenderTree::DumpRenderTree):
1362         (WebCore::DumpRenderTree::createWindow):
1363         (WebCore::DumpRenderTree::windowCount):
1364         * DumpRenderTree/qt/DumpRenderTree.h:
1365         * DumpRenderTree/qt/jsobjects.cpp:
1366         (LayoutTestController::maybeDump):
1367         (LayoutTestController::windowCount):
1368         * DumpRenderTree/qt/jsobjects.h:
1369
1370 2007-10-05  Lars Knoll  <lars@trolltech.com>
1371
1372         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
1373         Add support for layoutTextController.setCanOpenWindows() to DRT
1374         fixing another 2 test cases in fast/dom/Window.
1375
1376         Reviewed by Maciej.
1377
1378         * DumpRenderTree/qt/DumpRenderTree.cpp:
1379         (WebCore::WebPage::WebPage):
1380         (WebCore::WebPage::createWindow):
1381         (WebCore::DumpRenderTree::resetJSObjects):
1382         (WebCore::DumpRenderTree::createWindow):
1383         * DumpRenderTree/qt/DumpRenderTree.h:
1384         * DumpRenderTree/qt/DumpRenderTree.pro:
1385         * DumpRenderTree/qt/jsobjects.cpp:
1386         (LayoutTestController::LayoutTestController):
1387         (LayoutTestController::reset):
1388         * DumpRenderTree/qt/jsobjects.h:
1389         * DumpRenderTree/qt/main.cpp:
1390         * DumpRenderTree/qt/testplugin.cpp: Added.
1391         * DumpRenderTree/qt/testplugin.h: Added.
1392
1393 2007-10-04  Sam Weinig  <sam@webkit.org>
1394
1395         Rubber stamped by Adam.
1396
1397         Remove empty directories.
1398
1399         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
1400         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
1401
1402 2007-10-03  Darin Adler  <darin@apple.com>
1403
1404         Reviewed by Adam.
1405
1406         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
1407         we find the internal libraries in the libraries directory. This
1408         is helpful for Safari team engineers at Apple.
1409
1410 2007-10-03  Adam Roben  <aroben@apple.com>
1411
1412         Update the location of AHEM___.TTF after r25968
1413
1414         Reviewed by Sam.
1415
1416         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1417
1418 2007-10-03  Alp Toker  <alp@atoker.com>
1419
1420         Reviewed by Adam.
1421
1422         http://bugs.webkit.org/show_bug.cgi?id=14726
1423         [gtk] API design. Mapping the WebView delegates to signals.
1424
1425         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
1426
1427         * GtkLauncher/main.cpp:
1428         (goToURLBarText):
1429         (titleChanged):
1430         (progressChanged):
1431         (menuMainBackCallback):
1432         (menuMainForwardCallback):
1433         (main):
1434
1435 2007-10-03  Lars Knoll  <lars@trolltech.com>
1436
1437         Reviewed by Rob.
1438
1439         This fixes --strict mode in run-webkit-tests again after
1440         the platform dependent test results have been moved.
1441
1442         * Scripts/run-webkit-tests:
1443
1444 2007-10-03  Lars Knoll  <lars@trolltech.com>
1445
1446         Reviewed by bdash.
1447
1448         remove the hack in run-webkit-tests that forced text only test
1449         to be taken from the platform independent dir. It was only left
1450         there from early days.
1451
1452         Remove platform dependent results for tests that are text only nowadays,
1453         and add one platform dependent result for a text only test that requires it.
1454
1455         * Scripts/run-webkit-tests:
1456
1457 2007-10-03  Lars Knoll  <lars@trolltech.com>
1458
1459         Reviewed by olliej.
1460
1461         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
1462
1463         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
1464         (WebCore::WebFrame::WebFrame):
1465         (WebCore::WebPage::WebPage):
1466         (WebCore::WebPage::createFrame):
1467         (WebCore::WebPage::javaScriptAlert):
1468         (WebCore::WebPage::javaScriptConsoleMessage):
1469         (WebCore::DumpRenderTree::DumpRenderTree):
1470         (WebCore::DumpRenderTree::~DumpRenderTree):
1471         (WebCore::DumpRenderTree::open):
1472         (WebCore::DumpRenderTree::readStdin):
1473         (WebCore::DumpRenderTree::resetJSObjects):
1474         (WebCore::DumpRenderTree::initJSObjects):
1475         (WebCore::DumpRenderTree::dumpFramesAsText):
1476         (WebCore::DumpRenderTree::dump):
1477         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
1478         (WebCore::DumpRenderTree::layoutTestController):
1479         (WebCore::DumpRenderTree::eventSender):
1480         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
1481         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
1482         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
1483         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
1484         (HackWebFrame::mousePressEvent):
1485         (HackWebFrame::mouseReleaseEvent):
1486         (HackWebFrame::mouseMoveEvent):
1487         (HackWebFrame::HackWebFrame):
1488         (HackWebFrame::~HackWebFrame):
1489         (LayoutTestController::LayoutTestController):
1490         (LayoutTestController::reset):
1491         (LayoutTestController::maybeDump):
1492         (LayoutTestController::waitUntilDone):
1493         (LayoutTestController::notifyDone):
1494         (LayoutTestController::dumpEditingCallbacks):
1495         (LayoutTestController::queueReload):
1496         (LayoutTestController::provisionalLoad):
1497         (LayoutTestController::timerEvent):
1498         (EventSender::EventSender):
1499         (EventSender::mouseDown):
1500         (EventSender::mouseUp):
1501         (EventSender::mouseMoveTo):
1502         (EventSender::leapForward):
1503         (EventSender::keyDown):
1504         (EventSender::frameUnderMouse):
1505         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
1506         (LayoutTestController::isLoading):
1507         (LayoutTestController::setLoading):
1508         (LayoutTestController::shouldDumpAsText):
1509         (LayoutTestController::shouldDumpChildrenAsText):
1510         (LayoutTestController::shouldWaitUntilDone):
1511         (LayoutTestController::dumpAsText):
1512         (LayoutTestController::dumpChildFramesAsText):
1513         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
1514         (messageHandler):
1515         (crashHandler):
1516         (main):
1517         * Scripts/run-webkit-tests:
1518
1519 2007-10-03  Mark Rowe  <mrowe@apple.com>
1520
1521         Reviewed by Alp Toker.
1522
1523         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
1524         should take precedence over QTDIR when determining which port we are working with.
1525
1526         * Scripts/webkitdirs.pm:
1527
1528 2007-10-02  Adam Roben  <aroben@apple.com>
1529
1530         Add keychain to the list of default packages to install
1531
1532         Rubberstamped by Sam.
1533
1534         * CygwinDownloader/cygwin-downloader.py:
1535         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
1536
1537 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
1538
1539         Reviewed by Adam.
1540
1541         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
1542         Also makes WebCore regression test case logic work when using git.
1543
1544         * Scripts/prepare-ChangeLog:
1545         (reviewerAndDescriptionForGitCommit): Added.
1546
1547 2007-10-02  Lars Knoll  <lars@trolltech.com>
1548
1549         Reviewed by bdash.
1550
1551         Add API to retrieve the frame name from QWebFrame.
1552         Implement support for DRT::dumpChildrenAsText.
1553
1554         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1555         (WebCore::DumpRenderTree::dumpFramesAsText):
1556         (WebCore::DumpRenderTree::dump):
1557         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
1558         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1559         (LayoutTestController::LayoutTestController):
1560         (LayoutTestController::reset):
1561         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
1562
1563 2007-10-02  Lars Knoll  <lars@trolltech.com>
1564
1565         Reviewed by bdash.
1566
1567         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
1568
1569         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1570         (WebCore::DumpRenderTree::readStdin):
1571
1572 2007-10-02  Mark Rowe  <mrowe@apple.com>
1573
1574         Reviewed by Oliver.
1575
1576         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1577
1578         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1579         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1580
1581 2007-10-02  Mark Rowe  <mrowe@apple.com>
1582
1583         Rubber-stamped by Maciej.
1584
1585         Configuration changes from build.webkit.org.  The major change is refactoring to work
1586         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
1587         last few weeks.
1588
1589         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1590         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
1591         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
1592         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
1593         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
1594         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
1595         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
1596         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
1597
1598 2007-10-02  Lars Knoll  <lars@trolltech.com>
1599
1600         Reviewed by Maciej.
1601
1602         Add support for eventSender.mouseMove to DRT.
1603         Fixes fast/css/hover-affects-child.html
1604
1605         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1606         (EventSender::mouseMoveTo):
1607
1608 2007-10-01  Mark Rowe  <mrowe@apple.com>
1609
1610         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1611
1612 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
1613
1614         Reviewed by Hyatt.
1615
1616         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
1617
1618         * Scripts/svn-apply:
1619         (gitdiff2svndiff): Ignore lines beginning with "new file".
1620         * Scripts/svn-unapply:
1621         (gitdiff2svndiff): Ditto.
1622
1623 2007-09-30  George Staikos  <staikos@kde.org>
1624
1625         Qt build fix (Mac OS X specific)
1626
1627         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
1628
1629 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
1630
1631         Reviewed by Mark.
1632
1633         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
1634         Remove Bakefiles from svn.
1635
1636         * GtkLauncher/Bakefiles.bkgen: Removed.
1637         * GtkLauncher/ENV: Removed.
1638         * GtkLauncher/gdklauncher.bkl: Removed.
1639         * GtkLauncher/mk: Removed.
1640         * Scripts/regenerate-makefiles: Removed.
1641
1642 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
1643
1644         Reviewed by John.
1645
1646         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
1647
1648         * Scripts/run-webkit-tests:
1649
1650 2007-09-26  Adam Roben  <aroben@apple.com>
1651
1652         Make not finding an installed WebKit non-fatal
1653
1654         What really matters is that we are able to load WebKit and its
1655         dependencies, not whether we think we've found an installed WebKit.
1656
1657         Reviewed by Sam.
1658
1659         * WebKitInitializer/WebKitInitializer.cpp:
1660         (getWebViewCLSID): Use new LOG_WARNING macro.
1661         (getInstalledWebKitDirectory): Ditto.
1662         (initializeWebKit): Don't die if we didn't find an installed WebKit,
1663         and use new macros.
1664         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
1665
1666 2007-09-26  Adam Roben  <aroben@apple.com>
1667
1668         Committed this file before saving it
1669
1670         * WebKitInitializer/debug_internal.vsprops:
1671
1672 2007-09-26  Adam Roben  <aroben@apple.com>
1673
1674         Load WebKit and its dependencies manually so they come from DllDirectory
1675
1676         I had to change WebKitInitializer to use malloc/free instead of
1677         new/delete to avoid pulling in WebKit (and its dependencies) early
1678         through use of fastMalloc.
1679
1680         Reviewed by Oliver.
1681
1682         * WebKitInitializer/WebKitInitializer.cpp:
1683         (getStringValue): Changed to use malloc/free.
1684         (getInstalledWebKitDirectory): Ditto.
1685         (initializeWebKit): Call SetDllDirectory first, then load all of
1686         WebKit's dependencies manually, finally followed by WebKit itself.
1687         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
1688         configuration to match our other projects.
1689         * WebKitInitializer/debug_internal.vsprops: Added.
1690
1691 2007-09-25  Adam Roben  <aroben@apple.com>
1692
1693         Actually define DEBUG/NDEBUG so that we load WebKit correctly
1694
1695         Rubberstamped by Sam.
1696
1697         * WebKitInitializer/WebKitInitializer.vcproj:
1698
1699 2007-09-25  Adam Roben  <aroben@apple.com>
1700
1701         Make DumpRenderTree delay-load its dependencies
1702
1703         This lets WebKitInitializer re-route the dependencies to be loaded out
1704         of the Safari installation directory.
1705
1706         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
1707         same thing), since we can't import the kCFAllocatorDefault symbol when
1708         delay-loading CoreFoundation.dll.
1709
1710         Rubberstamped by Sam.
1711
1712         * DumpRenderTree/win/DumpRenderTree.cpp:
1713         (runTest):
1714         (javaScriptThreads):
1715         * DumpRenderTree/win/DumpRenderTree.vcproj:
1716         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1717         (LayoutTestController::setWaitToDump):
1718
1719 2007-09-25  Adam Roben  <aroben@apple.com>
1720
1721         Pull ole32.lib into WebKitInitializer
1722
1723         Rubberstamped by Sam.
1724
1725         * WebKitInitializer/WebKitInitializer.vcproj:
1726
1727 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
1728
1729         Reviewed by Adam.
1730
1731         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
1732           LGPL'ed files contain incorrect FSF address
1733
1734         * Drosera/config.h:
1735
1736 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
1737
1738         Reviewed by Adam.
1739
1740         Make svn-apply and svn-unapply work with git-diff formatted patches.
1741
1742         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
1743         (gitdiff2svndiff): Added.
1744         * Scripts/svn-unapply: Ditto.
1745         (gitdiff2svndiff): Added.
1746
1747 2007-09-25  Adam Roben  <aroben@apple.com>
1748
1749         Pull advapi32.lib into WebKitInitializer
1750
1751         This is needed to get the registry functions we use.
1752
1753         Rubberstamped by Sam.
1754
1755         * WebKitInitializer/WebKitInitializer.vcproj:
1756
1757 2007-09-25  Adam Roben  <aroben@apple.com>
1758
1759         Add python and rsync to cygwin-downloader
1760
1761         Our build slaves need this, and it can't hurt for everyone else to
1762         have it, too.
1763
1764         Reviewed by Sam.
1765
1766         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
1767         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
1768
1769 2007-09-25  Adam Roben  <aroben@apple.com>
1770
1771         Add WebKitInitializer and use it in DumpRenderTree
1772
1773         WebKitInitializer is a static library that has one function,
1774         initializeWebKit(). This registers WebKit and sets up the DLL search
1775         path so that WebKit's dependencies that are installed with Safari can
1776         be found.
1777
1778         Reviewed by Sam.
1779
1780         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
1781         DumpRenderTree depend on it.
1782         * DumpRenderTree/win/DumpRenderTree.cpp:
1783         (initialize): Call initializeWebKit.
1784         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
1785         WebKitInitializer.lib.
1786         * WebKitInitializer/WebKitInitializer.cpp: Added.
1787         (getStringValue):
1788         (getWebViewCLSID):
1789         (getInstalledWebKitDirectory):
1790         (initializeWebKit):
1791         * WebKitInitializer/WebKitInitializer.h: Added.
1792         * WebKitInitializer/WebKitInitializer.vcproj: Added.
1793         * WebKitInitializer/debug.vsprops: Added.
1794         * WebKitInitializer/release.vsprops: Added.
1795
1796 2007-09-25  Adam Roben  <aroben@apple.com>
1797
1798         Make run-webkit-tests respect set-webkit-configuration
1799
1800         Reviewed by Sam.
1801
1802         * Scripts/run-webkit-tests: Initialize $configuration to whatever
1803         set-webkit-configuration was last set to.
1804
1805 2007-09-25  Mark Rowe  <mrowe@apple.com>
1806
1807         Rubber-stamped by Eric.
1808
1809         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1810         This makes it possible to automate nightly builds for the feature-branch.
1811
1812 2007-09-25  Adam Roben  <aroben@apple.com>
1813
1814         A couple of fixes/enhancements to update-webkit-*-libs
1815
1816         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
1817         to tell update-webkit-support-libraries where it should find the
1818         WebKitSupportLibrary.zip file you downloaded.
1819
1820         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
1821         Windows-style path.
1822
1823         Reviewed by Sam.
1824
1825         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
1826         to $auxiliaryLibsURL and removed an irrelevant comment.
1827         * Scripts/update-webkit-support-libs:
1828
1829 2007-09-25  Adam Treat  <treat@kde.org>
1830
1831         Reviewed by Simon and Lars.
1832
1833         Refactors and cleans up Qt DRT member variable names, member variable
1834         initialization, style fixes and general code cleanup.
1835
1836         Adds queueReload slot to LayoutTestController that some tests require.
1837
1838         Subclasses QWebFrame to make sure that all frames have an associated
1839         LayoutTestController JS window object.
1840
1841         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
1842         aren't dumped twice.
1843
1844         EOF fixes.
1845
1846         Together, this patch fixes some 20+ layout tests in QtWebKit.
1847
1848         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1849         (WebCore::WebFrame::WebFrame):
1850         (WebCore::WebPage::WebPage):
1851         (WebCore::WebPage::createFrame):
1852         (WebCore::DumpRenderTree::DumpRenderTree):
1853         (WebCore::DumpRenderTree::open):
1854         (WebCore::DumpRenderTree::readStdin):
1855         (WebCore::DumpRenderTree::initJSObjects):
1856         (WebCore::DumpRenderTree::dump):
1857         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
1858         (WebCore::DumpRenderTree::layoutTestController):
1859         (WebCore::DumpRenderTree::eventSender):
1860         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1861         (LayoutTestController::LayoutTestController):
1862         (LayoutTestController::reset):
1863         (LayoutTestController::maybeDump):
1864         (LayoutTestController::waitUntilDone):
1865         (LayoutTestController::notifyDone):
1866         (LayoutTestController::queueReload):
1867         (LayoutTestController::provisionalLoad):
1868         (EventSender::EventSender):
1869         (EventSender::mouseDown):
1870         (EventSender::mouseUp):
1871         (EventSender::mouseMoveTo):
1872         (EventSender::frameUnderMouse):
1873         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
1874         (LayoutTestController::isLoading):
1875         (LayoutTestController::setLoading):
1876         (LayoutTestController::dumpAsText):
1877         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
1878         (main):
1879
1880 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
1881
1882
1883         - Reverted an accidentally checked in file.
1884
1885         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
1886
1887 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
1888         Reviewed by Sam.
1889
1890         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
1891
1892         * DumpRenderTree/win/DumpRenderTree.vcproj:
1893         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1894
1895 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
1896
1897         Rubber stamped by Adam.
1898
1899         * GdkLauncher: Removed.
1900         * GdkLauncher/Bakefiles.bkgen: Removed.
1901         * GdkLauncher/ENV: Removed.
1902         * GdkLauncher/GdkLauncher.pro: Removed.
1903         * GdkLauncher/gdklauncher.bkl: Removed.
1904         * GdkLauncher/main.cpp: Removed.
1905         * GdkLauncher/mk: Removed.
1906         * GdkLauncher/simple.svg: Removed.
1907         * GdkLauncher/text.html: Removed.
1908         * GtkLauncher: Added.
1909         * GtkLauncher/GdkLauncher.pro: Removed.
1910         * GtkLauncher/GtkLauncher.pro: Added.
1911         * GtkLauncher/main.cpp:
1912         (updateWindowTitle):
1913         (main):
1914         * Scripts/build-webkit:
1915         * Scripts/regenerate-makefiles:
1916         * Scripts/run-javascriptcore-tests:
1917         * Scripts/run-launcher:
1918         * Scripts/run-webkit-tests:
1919         * Scripts/webkitdirs.pm:
1920
1921 2007-09-21  Timothy Hatcher  <timothy@apple.com>
1922
1923         Reviewed by Darin.
1924
1925         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
1926
1927         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
1928         This is tested by plugins/root-object-premature-delete-crash.html.
1929
1930         * DumpRenderTree/mac/ObjCController.m:
1931         (-[ObjCController accessStoredWebScriptObject]):
1932
1933 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
1934
1935         Reviewed by Oliver.
1936
1937         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
1938
1939         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1940         (FrameLoadDelegate::FrameLoadDelegate):
1941
1942 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
1943
1944         Reviewed by Adam.
1945
1946         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
1947         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
1948
1949         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
1950         Now isQt() and isGdk() use global variables that are only set once.
1951
1952         An array of all the parameters is now given to build-dumprender which includes
1953         the platform on linux.
1954
1955         * Scripts/build-dumprendertree:
1956         * Scripts/run-webkit-tests:
1957         * Scripts/webkitdirs.pm:
1958
1959 2007-09-19  Adam Roben  <aroben@apple.com>
1960
1961         Rubberstamped by Hyatt.
1962
1963         * Spinneret: Removed.
1964
1965 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
1966
1967         Reviewed by David Kilzer.
1968
1969         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
1970
1971 2007-09-18  Sam Weinig  <sam@webkit.org>
1972
1973         Add JSRetainPtr.h #include to fix some builds.
1974
1975         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1976
1977 2007-09-18  Mike Hommey  <glandium@debian.org>
1978
1979         Reviewed by Adam.
1980
1981         * Scripts/prepare-ChangeLog:
1982         - Properly parse GECOS field.
1983         - Use git configuration for user name and email when appropriate.
1984
1985 2007-09-17  Sam Weinig  <sam@webkit.org>
1986
1987         Build fix.
1988
1989         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1990
1991 2007-09-17  Sam Weinig  <sam@webkit.org>
1992
1993         Reviewed by Adam Roben.
1994
1995         Share more code between mac and windows DRT.
1996             - GCController is now shared.
1997             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
1998
1999         * DumpRenderTree/GCController.cpp:
2000         * DumpRenderTree/win/DumpRenderTree.cpp:
2001         * DumpRenderTree/win/DumpRenderTree.vcproj:
2002         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
2003         (FrameLoadDelegate::FrameLoadDelegate):
2004         (FrameLoadDelegate::~FrameLoadDelegate):
2005         (FrameLoadDelegate::windowScriptObjectAvailable):
2006         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
2007         * DumpRenderTree/win/GCController.cpp: Removed.
2008         * DumpRenderTree/win/GCController.h: Removed.
2009         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
2010         (GCController::collect):
2011         (GCController::collectOnAlternateThread):
2012         (GCController::getJSObjectCount):
2013         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
2014         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
2015
2016 2007-09-17  Sam Weinig  <sam@webkit.org>
2017
2018         Reviewed by Adam Roben.
2019
2020         Begin sharing code between mac and windows DRT.
2021             - both now share LayoutTestController.h/cpp and implement platform dependant
2022               operations in LayoutTestControllerMac/Win.
2023             - DumpRenderTree.h is now shared.
2024             - WorkQueue and WorkQueueItem are also shared.
2025
2026         * DumpRenderTree/DumpRenderTree.h:
2027         * DumpRenderTree/LayoutTestController.cpp:
2028         * DumpRenderTree/win/DumpRenderTree.cpp:
2029         (displayWebView):
2030         (dumpFrameScrollPosition):
2031         (dumpFramesAsText):
2032         (dump):
2033         (runTest):
2034         * DumpRenderTree/win/DumpRenderTree.h: Removed.
2035         * DumpRenderTree/win/DumpRenderTree.vcproj:
2036         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
2037         * DumpRenderTree/win/EditingDelegate.cpp:
2038         (EditingDelegate::shouldBeginEditingInDOMRange):
2039         (EditingDelegate::shouldEndEditingInDOMRange):
2040         (EditingDelegate::shouldInsertNode):
2041         (EditingDelegate::shouldInsertText):
2042         (EditingDelegate::shouldDeleteDOMRange):
2043         (EditingDelegate::shouldChangeSelectedDOMRange):
2044         (EditingDelegate::shouldApplyStyle):
2045         (EditingDelegate::shouldChangeTypingStyle):
2046         (EditingDelegate::doPlatformCommand):
2047         (EditingDelegate::webViewDidBeginEditing):
2048         (EditingDelegate::webViewDidChange):
2049         (EditingDelegate::webViewDidEndEditing):
2050         (EditingDelegate::webViewDidChangeTypingStyle):
2051         (EditingDelegate::webViewDidChangeSelection):
2052         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
2053         * DumpRenderTree/win/LayoutTestController.h: Removed.
2054         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
2055         (LayoutTestController::addDisallowedURL):
2056         (LayoutTestController::clearBackForwardList):
2057         (LayoutTestController::copyDecodedHostName):
2058         (LayoutTestController::copyEncodedHostName):
2059         (LayoutTestController::display):
2060         (LayoutTestController::keepWebHistory):
2061         (LayoutTestController::notifyDone):
2062         (LayoutTestController::queueBackNavigation):
2063         (LayoutTestController::queueForwardNavigation):
2064         (jsStringRefToWString):
2065         (LayoutTestController::queueLoad):
2066         (LayoutTestController::queueReload):
2067         (LayoutTestController::queueScript):
2068         (LayoutTestController::setAcceptsEditing):
2069         (LayoutTestController::setCustomPolicyDelegate):
2070         (LayoutTestController::setMainFrameIsFirstResponder):
2071         (LayoutTestController::setTabKeyCyclesThroughElements):
2072         (LayoutTestController::setUseDashboardCompatibilityMode):
2073         (LayoutTestController::setUserStyleSheetEnabled):
2074         (LayoutTestController::setUserStyleSheetLocation):
2075         (LayoutTestController::setWindowIsKey):
2076         (waitUntilDoneWatchdogFired):
2077         (LayoutTestController::setWaitToDump):
2078         (LayoutTestController::windowCount):
2079         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
2080         (FrameLoadDelegate::didReceiveTitle):
2081         (FrameLoadDelegate::processWork):
2082         (FrameLoadDelegate::locationChangeDone):
2083         (FrameLoadDelegate::windowScriptObjectAvailable):
2084         * DumpRenderTree/win/WorkQueue.cpp: Removed.
2085         * DumpRenderTree/win/WorkQueue.h: Removed.
2086         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
2087         * DumpRenderTree/win/WorkQueueItem.h: Removed.
2088         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
2089         (jsStringRefToWString):
2090         (LoadItem::invoke):
2091         (ScriptItem::invoke):
2092
2093 2007-09-17  Sam Weinig  <sam@webkit.org>
2094
2095         Reviewed by Adam Roben.
2096
2097         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
2098
2099         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
2100         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
2101         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
2102         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
2103         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
2104         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
2105         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
2106         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
2107         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
2108         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
2109         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
2110         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
2111         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
2112         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
2113         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
2114         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
2115         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
2116         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
2117         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
2118         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
2119         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
2120         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
2121         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
2122         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
2123         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
2124         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
2125         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
2126         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
2127         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
2128         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
2129         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
2130         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
2131         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
2132         * DumpRenderTree/win: Added.
2133         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
2134         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
2135         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
2136         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
2137         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
2138         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
2139         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
2140         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
2141         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
2142         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
2143         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
2144         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
2145         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
2146         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2147         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
2148         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
2149         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
2150         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
2151         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2152         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2153         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
2154         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2155         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
2156         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
2157         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
2158         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
2159
2160 2007-09-15  Mark Rowe  <mrowe@apple.com>
2161
2162         Build fix for DumpRenderTree.
2163
2164         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
2165
2166 2007-09-14  Sam Weinig  <sam@webkit.org>
2167
2168         Rubber stamped by Adam Roben.
2169
2170         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
2171           - The UIDelegate was put into a new file while the FrameLoadDelegate was
2172             kept in the WaitUntilDoneDelegate file for the time being.
2173
2174         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
2175         (main):
2176         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
2177         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
2178         (UIDelegate::QueryInterface):
2179         (UIDelegate::AddRef):
2180         (UIDelegate::Release):
2181         (UIDelegate::hasCustomMenuImplementation):
2182         (UIDelegate::setFrame):
2183         (UIDelegate::webViewFrame):
2184         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2185         (UIDelegate::webViewAddMessageToConsole):
2186         (UIDelegate::doDragDrop):
2187         (UIDelegate::webViewGetDlgCode):
2188         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
2189         (UIDelegate::UIDelegate):
2190         (UIDelegate::createWebViewWithRequest):
2191         (UIDelegate::webViewShow):
2192         (UIDelegate::webViewClose):
2193         (UIDelegate::webViewFocus):
2194         (UIDelegate::webViewUnfocus):
2195         (UIDelegate::webViewFirstResponder):
2196         (UIDelegate::makeFirstResponder):
2197         (UIDelegate::setStatusText):
2198         (UIDelegate::webViewStatusText):
2199         (UIDelegate::webViewAreToolbarsVisible):
2200         (UIDelegate::setToolbarsVisible):
2201         (UIDelegate::webViewIsStatusBarVisible):
2202         (UIDelegate::setStatusBarVisible):
2203         (UIDelegate::webViewIsResizable):
2204         (UIDelegate::setResizable):
2205         (UIDelegate::setContentRect):
2206         (UIDelegate::webViewContentRect):
2207         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2208         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2209         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2210         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
2211         (UIDelegate::mouseDidMoveOverElement):
2212         (UIDelegate::contextMenuItemsForElement):
2213         (UIDelegate::validateUserInterfaceItem):
2214         (UIDelegate::shouldPerformAction):
2215         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
2216         (UIDelegate::willPerformDragDestinationAction):
2217         (UIDelegate::dragSourceActionMaskForPoint):
2218         (UIDelegate::willPerformDragSourceAction):
2219         (UIDelegate::contextMenuItemSelected):
2220         (UIDelegate::trackCustomPopupMenu):
2221         (UIDelegate::measureCustomMenuItem):
2222         (UIDelegate::drawCustomMenuItem):
2223         (UIDelegate::addCustomMenuDrawingData):
2224         (UIDelegate::cleanUpCustomMenuDrawingData):
2225         (UIDelegate::canTakeFocus):
2226         (UIDelegate::takeFocus):
2227         (UIDelegate::registerUndoWithTarget):
2228         (UIDelegate::removeAllActionsWithTarget):
2229         (UIDelegate::setActionTitle):
2230         (UIDelegate::undo):
2231         (UIDelegate::redo):
2232         (UIDelegate::canUndo):
2233         (UIDelegate::canRedo):
2234         (UIDelegate::webViewResizerRect):
2235         (UIDelegate::webViewDrawResizer):
2236         (UIDelegate::webViewScrolled):
2237         (UIDelegate::webViewShouldInterruptJavaScript):
2238         (UIDelegate::webViewReceivedFocus):
2239         (UIDelegate::webViewLostFocus):
2240         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
2241         (FrameLoadDelegate::QueryInterface):
2242         (FrameLoadDelegate::AddRef):
2243         (FrameLoadDelegate::Release):
2244         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2245         (FrameLoadDelegate::didCommitLoadForFrame):
2246         (FrameLoadDelegate::didReceiveTitle):
2247         (FrameLoadDelegate::processWork):
2248         (processWorkTimer):
2249         (FrameLoadDelegate::locationChangeDone):
2250         (FrameLoadDelegate::didFinishLoadForFrame):
2251         (FrameLoadDelegate::didFailLoadWithError):
2252         (FrameLoadDelegate::windowScriptObjectAvailable):
2253         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
2254         (FrameLoadDelegate::FrameLoadDelegate):
2255
2256 2007-09-14  Sam Weinig  <sam@webkit.org>
2257
2258         Reviewed by Kevin McCullough.
2259
2260         Move mac specific globals in to mac/DumpRenderTreeMac.h
2261
2262         * DumpRenderTree/DumpRenderTree.h:
2263         * DumpRenderTree/DumpRenderTree.mm: Removed.
2264         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2265         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
2266         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
2267
2268 2007-09-14  Brady Eidson  <beidson@apple.com>
2269
2270         Rubberstamped by Weinig
2271
2272         You know, Sam, some of us use case-sensitve filesystems...
2273
2274         * DumpRenderTree/DumpRenderTree.h:
2275         * DumpRenderTree/mac/UIDelegate.mm:
2276
2277 2007-09-14  Sam Weinig  <sam@webkit.org>
2278
2279         Rubber stamped by Adam Roben.
2280
2281         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
2282         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
2283
2284         * DumpRenderTree/AppleScriptController.h: Removed.
2285         * DumpRenderTree/AppleScriptController.m: Removed.
2286         * DumpRenderTree/DumpRenderTree.h:
2287         * DumpRenderTree/DumpRenderTree.mm:
2288         (startJavaScriptThreads):
2289         (stopJavaScriptThreads):
2290         (activateAhemFont):
2291         (setDefaultColorProfileToRGB):
2292         (makeLargeMallocFailSilently):
2293         (dumpFrameScrollPosition):
2294         (dumpFramesAsText):
2295         (dump):
2296         (runTest):
2297         (-[DumpRenderTreeWindow isKeyWindow]):
2298         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2299         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
2300         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
2301         * DumpRenderTree/EditingDelegate.h: Removed.
2302         * DumpRenderTree/EditingDelegate.m: Removed.
2303         * DumpRenderTree/EventSendingController.h: Removed.
2304         * DumpRenderTree/EventSendingController.m: Removed.
2305         * DumpRenderTree/FrameLoadDelegate.h: Removed.
2306         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
2307         * DumpRenderTree/GCController.mm: Removed.
2308         * DumpRenderTree/ImageDiff.m: Removed.
2309         * DumpRenderTree/LayoutTestController.cpp:
2310         (LayoutTestController::LayoutTestController):
2311         (dumpAsTextCallback):
2312         (dumpBackForwardListCallback):
2313         (dumpChildFramesAsTextCallback):
2314         (dumpChildFrameScrollPositionsCallback):
2315         (dumpDOMAsWebArchiveCallback):
2316         (dumpEditingCallbacksCallback):
2317         (dumpFrameLoadCallbacksCallback):
2318         (dumpResourceLoadCallbacksCallback):
2319         (dumpSelectionRectCallback):
2320         (dumpSourceAsWebArchiveCallback):
2321         (dumpTitleChangesCallback):
2322         (repaintSweepHorizontallyCallback):
2323         (setCallCloseOnWebViewsCallback):
2324         (setCanOpenWindowsCallback):
2325         (setCloseRemainingWindowsWhenCompleteCallback):
2326         (testRepaintCallback):
2327         (addFileToPasteboardOnDragCallback):
2328         (waitUntilDoneCallback):
2329         * DumpRenderTree/LayoutTestController.h:
2330         (LayoutTestController::dumpAsText):
2331         (LayoutTestController::setDumpAsText):
2332         (LayoutTestController::dumpBackForwardList):
2333         (LayoutTestController::setDumpBackForwardList):
2334         (LayoutTestController::dumpChildFrameScrollPositions):
2335         (LayoutTestController::setDumpChildFrameScrollPositions):
2336         (LayoutTestController::dumpChildFramesAsText):
2337         (LayoutTestController::setDumpChildFramesAsText):
2338         (LayoutTestController::dumpDOMAsWebArchive):
2339         (LayoutTestController::setDumpDOMAsWebArchive):
2340         (LayoutTestController::dumpSelectionRect):
2341         (LayoutTestController::setDumpSelectionRect):
2342         (LayoutTestController::dumpSourceAsWebArchive):
2343         (LayoutTestController::setDumpSourceAsWebArchive):
2344         (LayoutTestController::dumpTitleChanges):
2345         (LayoutTestController::setDumpTitleChanges):
2346         (LayoutTestController::dumpEditingCallbacks):
2347         (LayoutTestController::setDumpEditingCallbacks):
2348         (LayoutTestController::dumpResourceLoadCallbacks):
2349         (LayoutTestController::setDumpResourceLoadCallbacks):
2350         (LayoutTestController::dumpFrameLoadCallbacks):
2351         (LayoutTestController::setDumpFrameLoadCallbacks):
2352         (LayoutTestController::addFileToPasteboardOnDrag):
2353         (LayoutTestController::setAddFileToPasteboardOnDrag):
2354         (LayoutTestController::callCloseOnWebViews):
2355         (LayoutTestController::setCallCloseOnWebViews):
2356         (LayoutTestController::canOpenWindows):
2357         (LayoutTestController::setCanOpenWindows):
2358         (LayoutTestController::closeRemainingWindowsWhenComplete):
2359         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2360         (LayoutTestController::testRepaint):
2361         (LayoutTestController::setTestRepaint):
2362         (LayoutTestController::testRepaintSweepHorizontally):
2363         (LayoutTestController::setTestRepaintSweepHorizontally):
2364         (LayoutTestController::waitToDump):
2365         (LayoutTestController::windowIsKey):
2366         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
2367         * DumpRenderTree/NavigationController.h: Removed.
2368         * DumpRenderTree/NavigationController.m: Removed.
2369         * DumpRenderTree/ObjCController.h: Removed.
2370         * DumpRenderTree/ObjCController.m: Removed.
2371         * DumpRenderTree/ObjCPlugin.h: Removed.
2372         * DumpRenderTree/ObjCPlugin.m: Removed.
2373         * DumpRenderTree/ObjCPluginFunction.h: Removed.
2374         * DumpRenderTree/ObjCPluginFunction.m: Removed.
2375         * DumpRenderTree/PolicyDelegate.h: Removed.
2376         * DumpRenderTree/PolicyDelegate.m: Removed.
2377         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
2378         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
2379         * DumpRenderTree/TextInputController.h: Removed.
2380         * DumpRenderTree/TextInputController.m: Removed.
2381         * DumpRenderTree/UIDelegate.h: Removed.
2382         * DumpRenderTree/UIDelegate.mm: Removed.
2383         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
2384         * DumpRenderTree/mac: Added.
2385         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
2386         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
2387         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
2388         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
2389         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
2390         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
2391         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2392         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2393         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2394         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2395         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2396         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2397         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2398         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2399         (-[EditingDelegate webViewDidBeginEditing:]):
2400         (-[EditingDelegate webViewDidChange:]):
2401         (-[EditingDelegate webViewDidEndEditing:]):
2402         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2403         (-[EditingDelegate webViewDidChangeSelection:]):
2404         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
2405         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
2406         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
2407         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
2408         (-[FrameLoadDelegate init]):
2409         (-[FrameLoadDelegate dealloc]):
2410         (-[FrameLoadDelegate processWork:]):
2411         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2412         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2413         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2414         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2415         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2416         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2417         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2418         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2419         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2420         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2421         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2422         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2423         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2424         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2425         (-[FrameLoadDelegate webView:willCloseFrame:]):
2426         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2427         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2428         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
2429         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
2430         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
2431         (LayoutTestController::notifyDone):
2432         (LayoutTestController::setWindowIsKey):
2433         (LayoutTestController::setWaitToDump):
2434         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
2435         * DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
2436         * DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
2437         * DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
2438         * DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
2439         * DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
2440         * DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
2441         * DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
2442         * DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
2443         * DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
2444         * DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
2445         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m.
2446         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2447         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2448         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2449         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2450         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2451         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2452         * DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
2453         * DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
2454         * DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
2455         * DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm.
2456         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
2457         (-[UIDelegate webViewFocus:]):
2458         (-[UIDelegate webView:createWebViewWithRequest:]):
2459         (-[UIDelegate webViewClose:]):
2460         * DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.
2461
2462 2007-09-14  Kevin McCullough  <kmccullough@apple.com>
2463
2464         Reviewed by Adam.
2465
2466         - Changing Win version of Drosera work with recent changes.
2467
2468         * Drosera/DebuggerDocument.cpp:
2469         * Drosera/DebuggerDocument.h:
2470         * Drosera/mac/DebuggerDocumentPlatform.mm:
2471         (NSStringCreateWithJSStringRef):
2472         (JSValueRefCreateWithNSString):
2473         * Drosera/win/DebuggerClient.cpp:
2474         (DebuggerClient::stepInto):
2475         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2476
2477 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
2478
2479         Reviewed by Tim.
2480
2481         - Moved isPaused into the JS for efficiency and simplicity.
2482
2483         * Drosera/DebuggerDocument.cpp:
2484         (DebuggerDocument::DebuggerDocument):
2485         (DebuggerDocument::pauseCallback):
2486         (DebuggerDocument::resumeCallback):
2487         (DebuggerDocument::isPaused):
2488         (DebuggerDocument::staticFunctions):
2489         * Drosera/DebuggerDocument.h:
2490         * Drosera/console.js:
2491         * Drosera/debugger.js:
2492         * Drosera/mac/DebuggerClient.mm:
2493         (-[DebuggerClient validateUserInterfaceItem:]):
2494
2495 2007-09-13  Sam Weinig  <sam@webkit.org>
2496
2497         Rubber stamped by Darin.
2498
2499         Make DumpRenderTree more cross platform ready.
2500         - Convert GCController to use the JSCore API instead of the WebScriptObject.
2501         - Use CF types instead of NS objects.
2502         - General cleanup.
2503
2504         * DumpRenderTree/DumpRenderTree.h:
2505         * DumpRenderTree/DumpRenderTree.mm:
2506         (dumpRenderTree):
2507         (dump):
2508         (runTest):
2509         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2510         * DumpRenderTree/EditingDelegate.m:
2511         * DumpRenderTree/FrameLoadDelegate.h:
2512         * DumpRenderTree/FrameLoadDelegate.mm:
2513         (-[FrameLoadDelegate init]):
2514         (-[FrameLoadDelegate dealloc]):
2515         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2516         * DumpRenderTree/GCController.cpp: Added.
2517         (GCController::GCController):
2518         (GCController::~GCController):
2519         (collectCallback):
2520         (collectOnAlternateThreadCallback):
2521         (getJSObjectCountCallback):
2522         (GCController::makeWindowObject):
2523         (GCController::getJSClass):
2524         (GCController::staticFunctions):
2525         * DumpRenderTree/GCController.h:
2526         * DumpRenderTree/GCController.mm:
2527         (GCController::collect):
2528         (GCController::collectOnAlternateThread):
2529         (GCController::getJSObjectCount):
2530         * DumpRenderTree/LayoutTestController.cpp:
2531         (LayoutTestController::makeWindowObject):
2532         (LayoutTestController::getJSClass):
2533         * DumpRenderTree/LayoutTestController.h:
2534         * DumpRenderTree/LayoutTestControllerMac.mm:
2535         (LayoutTestController::addDisallowedURL):
2536         (waitUntilDoneWatchdogFired):
2537         (LayoutTestController::waitUntilDone):
2538         * DumpRenderTree/ResourceLoadDelegate.m:
2539         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2540
2541 2007-09-12  Sam Weinig  <sam@webkit.org>
2542
2543         Reviewed by Stephanie.
2544
2545         Fix leaks in mac DumpRenderTree.
2546
2547         * DumpRenderTree/FrameLoadDelegate.mm:
2548         (-[FrameLoadDelegate init]): Initalize in the correct order.
2549         (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
2550         * DumpRenderTree/LayoutTestController.cpp:
2551         (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released.
2552         (encodeHostNameCallback): ditto.
2553         * DumpRenderTree/LayoutTestController.h:
2554         * DumpRenderTree/LayoutTestControllerMac.mm:
2555         (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule.
2556         (LayoutTestController::copyEncodedHostName): ditto
2557         (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.
2558
2559 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2560
2561         Reviewed by Geof.
2562
2563         - Updated Leopard leak list to include a leak which appears to be fixed in 9A549 but not the version the bot is on.  This will allow us to get the bot green, but later we should remove it.
2564
2565         * Scripts/run-webkit-tests:
2566
2567 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2568
2569         Reviewed by Darin.
2570
2571         - Simplified code paths and extracted out functions to increase encapsulation.
2572
2573         * Drosera/DebuggerDocument.cpp:
2574         (DebuggerDocument::breakpointEditorHTMLCallback):
2575         (DebuggerDocument::isPausedCallback):
2576         (DebuggerDocument::pauseCallback):
2577         (DebuggerDocument::resumeCallback):
2578         (DebuggerDocument::stepIntoCallback):
2579         (DebuggerDocument::evaluateScriptCallback):
2580         (DebuggerDocument::currentFunctionStackCallback):
2581         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
2582         (DebuggerDocument::valueForScopeVariableNamedCallback):
2583         (DebuggerDocument::logCallback):
2584         * Drosera/DebuggerDocument.h:
2585         (DebuggerDocument::getPaused):
2586         * Drosera/mac/DebuggerClient.mm:
2587         (-[DebuggerClient pause:]):
2588         (-[DebuggerClient resume:]):
2589         (-[DebuggerClient stepInto:]):
2590         (-[DebuggerClient stepOver:]):
2591         (-[DebuggerClient stepOut:]):
2592         (-[DebuggerClient showConsole:]):
2593         (-[DebuggerClient closeCurrentFile:]):
2594         (-[DebuggerClient validateUserInterfaceItem:]):
2595         * Drosera/mac/DebuggerDocumentPlatform.mm: Added.
2596         (+[NSString stringOrNilFromWebScriptResult:]):
2597         (DebuggerDocument::platformPause):
2598         (DebuggerDocument::platformResume):
2599         (DebuggerDocument::platformStepInto):
2600         (DebuggerDocument::platformEvaluateScript):
2601         (DebuggerDocument::getPlatformCurrentFunctionStack):
2602         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2603         (DebuggerDocument::platformValueForScopeVariableNamed):
2604         (DebuggerDocument::platformLog):
2605         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2606
2607 2007-09-12  Sam Weinig  <sam@webkit.org>
2608
2609         Build fix for Buildbot.
2610
2611         * DumpRenderTree/DumpRenderTree.mm:
2612         (dump):
2613
2614 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2615
2616         Reviewed by Geoff.
2617
2618         - Updated the leaks list for leopard to help identify regressions.
2619
2620         * Scripts/run-webkit-tests:
2621
2622 2007-09-12  Sam Weinig  <sam@webkit.org>
2623
2624         Rubber stamped by Darin.
2625
2626         Convert the LayoutTestController to use the JSCore API instead of WebScriptObject.
2627
2628         * DumpRenderTree/DumpRenderTree.h: Re-order variables.
2629         * DumpRenderTree/DumpRenderTree.m: Removed.
2630         * DumpRenderTree/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.m.
2631         (stopJavaScriptThreads): Fix initialization.
2632         (setDefaultColorProfileToRGB): Add explicit cast from void*.
2633         (dumpRenderTree): Ditto.
2634         (runTest):
2635         Used the WorkQueue from the windows DRT instead of the old NSMutableArray one.
2636
2637         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2638         * DumpRenderTree/FrameLoadDelegate.h: Add LayoutTestController instance variable.
2639         * DumpRenderTree/FrameLoadDelegate.m: Removed.
2640         * DumpRenderTree/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.m.
2641         (-[FrameLoadDelegate init]):
2642         (-[FrameLoadDelegate dealloc]):
2643         (-[FrameLoadDelegate processWork:]):
2644         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2645         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2646         Convert to use the new JSCore based LayoutTestController and the new WorkQueue.
2647
2648         * DumpRenderTree/LayoutTestController.cpp: Added.
2649         (LayoutTestController::LayoutTestController):
2650         (LayoutTestController::~LayoutTestController):
2651         (dumpAsTextCallback):
2652         (dumpBackForwardListCallback):
2653         (dumpChildFramesAsTextCallback):
2654         (dumpChildFrameScrollPositionsCallback):
2655         (dumpDOMAsWebArchiveCallback):
2656         (dumpEditingCallbacksCallback):
2657         (dumpFrameLoadCallbacksCallback):
2658         (dumpResourceLoadCallbacksCallback):
2659         (dumpSelectionRectCallback):
2660         (dumpSourceAsWebArchiveCallback):
2661         (dumpTitleChangesCallback):
2662         (repaintSweepHorizontallyCallback):
2663         (setCallCloseOnWebViewsCallback):
2664         (setCanOpenWindowsCallback):
2665         (setCloseRemainingWindowsWhenCompleteCallback):
2666         (testRepaintCallback):
2667         (addFileToPasteboardOnDragCallback):
2668         (addDisallowedURLCallback):
2669         (clearBackForwardListCallback):
2670         (decodeHostNameCallback):
2671         (displayCallback):
2672         (encodeHostNameCallback):
2673         (keepWebHistoryCallback):
2674         (notifyDoneCallback):
2675         (queueBackNavigationCallback):
2676         (queueForwardNavigationCallback):
2677         (queueLoadCallback):
2678         (queueReloadCallback):
2679         (queueScriptCallback):
2680         (setAcceptsEditingCallback):
2681         (setCustomPolicyDelegateCallback):
2682         (setMainFrameIsFirstResponderCallback):
2683         (setTabKeyCyclesThroughElementsCallback):
2684         (setUseDashboardCompatibilityModeCallback):
2685         (setUserStyleSheetEnabledCallback):
2686         (setUserStyleSheetLocationCallback):
2687         (setWindowIsKeyCallback):
2688         (waitUntilDoneCallback):
2689         (windowCountCallback):
2690         (LayoutTestController::makeWindowObject):
2691         (LayoutTestController::getLayoutTestControllerJSClass):
2692         (LayoutTestController::staticFunctions):
2693         * DumpRenderTree/LayoutTestController.h: Replaced.
2694         * DumpRenderTree/LayoutTestController.m: Removed.
2695         * DumpRenderTree/LayoutTestControllerMac.mm: Added.
2696         (LayoutTestController::dumpAsText):
2697         (LayoutTestController::dumpBackForwardList):
2698         (LayoutTestController::dumpChildFramesAsText):
2699         (LayoutTestController::dumpChildFrameScrollPositions):
2700         (LayoutTestController::dumpDOMAsWebArchive):
2701         (LayoutTestController::dumpEditingCallbacks):
2702         (LayoutTestController::dumpFrameLoadCallbacks):
2703         (LayoutTestController::dumpResourceLoadCallbacks):
2704         (LayoutTestController::dumpSelectionRect):
2705         (LayoutTestController::dumpSourceAsWebArchive):
2706         (LayoutTestController::dumpTitleChanges):
2707         (LayoutTestController::repaintSweepHorizontally):
2708         (LayoutTestController::setCallCloseOnWebViews):
2709         (LayoutTestController::setCanOpenWindows):
2710         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2711         (LayoutTestController::testRepaint):
2712         (LayoutTestController::addFileToPasteboardOnDrag):
2713         (LayoutTestController::addDisallowedURL):
2714         (LayoutTestController::clearBackForwardList):
2715         (LayoutTestController::decodeHostName):
2716         (LayoutTestController::encodeHostName):
2717         (LayoutTestController::display):
2718         (LayoutTestController::keepWebHistory):
2719         (LayoutTestController::notifyDone):
2720         (LayoutTestController::queueBackNavigation):
2721         (LayoutTestController::queueForwardNavigation):
2722         (LayoutTestController::queueLoad):
2723         (LayoutTestController::queueReload):
2724         (LayoutTestController::queueScript):
2725         (LayoutTestController::setAcceptsEditing):
2726         (LayoutTestController::setCustomPolicyDelegate):
2727         (LayoutTestController::setMainFrameIsFirstResponder):
2728         (LayoutTestController::setTabKeyCyclesThroughElements):
2729         (LayoutTestController::setUseDashboardCompatibilityMode):
2730         (LayoutTestController::setUserStyleSheetEnabled):
2731         (LayoutTestController::setUserStyleSheetLocation):
2732         (LayoutTestController::setWindowIsKey):
2733         (+[WaitToDumpWatchdog waitUntilDoneWatchdogFired]):
2734         (LayoutTestController::waitUntilDone):
2735         (LayoutTestController::windowCount):
2736         Use the JSCore API to implement the LayoutTestController.
2737
2738         * DumpRenderTree/ObjCController.h:
2739         * DumpRenderTree/ObjCController.m:
2740         (+[ObjCController isSelectorExcludedFromWebScript:]):
2741         (+[ObjCController webScriptNameForSelector:]):
2742         (-[ObjCController accessStoredWebScriptObject]):
2743         (-[ObjCController storeWebScriptObject:]):
2744         (-[ObjCController dealloc]):
2745         (-[ObjCController invokeUndefinedMethodFromWebScript:withArguments:]):
2746         Move WebScriptObject tests to ObjCController.
2747
2748         * DumpRenderTree/UIDelegate.m: Removed.
2749         * DumpRenderTree/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.m.
2750
2751         * DumpRenderTree/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2752         * DumpRenderTree/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2753         * DumpRenderTree/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2754         (WorkQueueItem::~WorkQueueItem):
2755         (LoadItem::LoadItem):
2756         (LoadItem::url):
2757         (LoadItem::target):
2758         (ScriptItem::ScriptItem):
2759         (ScriptItem::script):
2760         * DumpRenderTree/WorkQueueItemMac.mm: Added.
2761         (LoadItem::invoke):
2762         (ReloadItem::invoke):
2763         (ScriptItem::invoke):
2764         (BackForwardItem::invoke):
2765         Copy WorkQueue and WorkQueueItem from windows DRT. Changed the WorkQueueItem to use JSStringRefs instead of wstrings
2766         to avoid conversion until the last possible moment.  These changes will be merged with the windows DRT when we start
2767         sharing code.
2768
2769 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
2770
2771         Reviewed by Maciej.
2772
2773         - Updated Win side to take advantage of the platform separating changes.
2774
2775         * Drosera/DebuggerDocument.cpp:
2776         (DebuggerDocument::localScopeVariableNamesForCallFrame):
2777         * Drosera/DebuggerDocument.h:
2778         * Drosera/win/DebuggerClient.cpp:
2779         (DebuggerClient::pause):
2780         (DebuggerClient::resume):
2781         (DebuggerClient::stepInto):
2782         (DebuggerDocument::platformPause):
2783         (DebuggerDocument::platformResume):
2784         (DebuggerDocument::platformStepInto):
2785         (DebuggerDocument::platformEvaluateScript):
2786         (DebuggerDocument::getPlatformCurrentFunctionStack):
2787         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2788         (DebuggerDocument::platformValueForScopeVariableNamed):
2789         (DebuggerDocument::platformLog):
2790         * Drosera/win/DebuggerClient.h:
2791         * Drosera/win/Drosera.cpp:
2792         (Drosera::Drosera):
2793         (Drosera::windowScriptObjectAvailable):
2794         (Drosera::initWithServerName):
2795         (Drosera::switchToServerNamed):
2796         * Drosera/win/Drosera.h:
2797         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2798
2799 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
2800
2801         Reviewed by Adam.
2802
2803         - Just doing the moves in a separate patch so the changes are easier to see.
2804
2805         * Drosera/win/DebuggerClient.cpp: Copied from Drosera/win/DebuggerDocumentWin.cpp.
2806         * Drosera/win/DebuggerClient.h: Copied from Drosera/win/DebuggerDocumentWin.h.
2807         * Drosera/win/DebuggerDocumentWin.cpp: Removed.
2808         * Drosera/win/DebuggerDocumentWin.h: Removed.
2809         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2810
2811 2007-09-11  Sven Herzberg  <sven@imendio.com>
2812
2813         Don't overwrite LD_LIBRARY_PATH, prepend to it. Fixes:
2814         http://bugs.webkit.org/show_bug.cgi?id=15176
2815
2816         * Scripts/run-launcher: don't replace LD_LIBRARY_PATH with
2817         $projectDir, but prepend $projectDir to LD_LIBRARY_PATH (to preserve
2818         other paths eg. from jhbuild)
2819
2820 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
2821
2822         Reviewed by Adam.
2823
2824         - Made an order-of-deletion mistake.
2825
2826         * Drosera/DebuggerDocument.h:
2827         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
2828         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
2829         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
2830         * Drosera/mac/DebuggerClient.mm:
2831         (DebuggerDocument::platformPause):
2832         (DebuggerDocument::platformResume):
2833         (DebuggerDocument::platformStepInto):
2834         (DebuggerDocument::platformEvaluateScript):
2835         (DebuggerDocument::getPlatformCurrentFunctionStack):
2836         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2837         (DebuggerDocument::platformValueForScopeVariableNamed):
2838         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2839
2840 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
2841
2842         Reviewed by Darin.
2843
2844         - Renaming DebuggerDocument[platform] to DebuggerClient to be more clear.
2845
2846         * Drosera/DebuggerDocument.cpp:
2847         (DebuggerDocument::DebuggerDocument):
2848         * Drosera/DebuggerDocument.h:
2849         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2850         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2851         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2852         * Drosera/mac/DebuggerApplication.mm:
2853         (-[DebuggerApplication attach:]):
2854         * Drosera/mac/DebuggerClient.h: Copied from Drosera/mac/DebuggerDocumentMac.h.
2855         * Drosera/mac/DebuggerClient.mm: Copied from Drosera/mac/DebuggerDocumentMac.mm.
2856         (DebuggerDocument::platformPause):
2857         (DebuggerDocument::platformResume):
2858         (DebuggerDocument::platformStepInto):
2859         (DebuggerDocument::platformEvaluateScript):
2860         (DebuggerDocument::getPlatformCurrentFunctionStack):
2861         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2862         (DebuggerDocument::platformValueForScopeVariableNamed):
2863         (DebuggerDocument::platformLog):
2864         * Drosera/mac/DebuggerDocumentMac.h: Removed.
2865         * Drosera/mac/DebuggerDocumentMac.mm: Removed.
2866         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2867
2868 2007-09-09  Sam Weinig  <sam@webkit.org>
2869
2870         Reviewed by Mark Rowe.
2871
2872         Remove 'objC' prefix from methods now in the ObjCController.
2873
2874         * DumpRenderTree/ObjCController.m:
2875         (+[ObjCController isSelectorExcludedFromWebScript:]):
2876         (+[ObjCController webScriptNameForSelector:]):
2877         (-[ObjCController classNameOf:]):
2878         (-[ObjCController objectOfClass:]):
2879         (-[ObjCController identityIsEqual::]):
2880         (-[ObjCController longLongRoundTrip:]):
2881         (-[ObjCController unsignedLongLongRoundTrip:]):
2882
2883 2007-09-09  Sam Weinig  <sam@webkit.org>
2884
2885         Reviewed by Oliver.
2886
2887         Initial refactor of DumpRenderTree in preparation of making it more platform independent.
2888         - Move LayoutTestController into its own file.
2889         - Move Objective-C only functions on LayoutTestController into a new controller called the
2890           ObjCController.
2891
2892         * DumpRenderTree/DumpRenderTree.h:
2893         * DumpRenderTree/DumpRenderTree.m:
2894         (displayWebView):
2895         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2896         * DumpRenderTree/FrameLoadDelegate.m:
2897         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2898         * DumpRenderTree/LayoutTestController.h: Added.
2899         * DumpRenderTree/LayoutTestController.m: Added.
2900         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
2901         (+[LayoutTestController webScriptNameForSelector:]):
2902         (-[LayoutTestController clearBackForwardList]):
2903         (-[LayoutTestController setUseDashboardCompatibilityMode:]):
2904         (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]):
2905         (-[LayoutTestController setCustomPolicyDelegate:]):
2906         (-[LayoutTestController keepWebHistory]):
2907         (-[LayoutTestController setCallCloseOnWebViews:]):
2908         (-[LayoutTestController setCanOpenWindows]):
2909         (-[LayoutTestController waitUntilDone]):
2910         (-[LayoutTestController waitUntilDoneWatchdogFired]):
2911         (-[LayoutTestController notifyDone]):
2912         (-[LayoutTestController dumpAsText]):
2913         (-[LayoutTestController addFileToPasteboardOnDrag]):
2914         (-[LayoutTestController addDisallowedURL:]):
2915         (-[LayoutTestController setUserStyleSheetLocation:]):
2916         (-[LayoutTestController setUserStyleSheetEnabled:]):
2917         (-[LayoutTestController dumpDOMAsWebArchive]):
2918         (-[LayoutTestController dumpSourceAsWebArchive]):
2919         (-[LayoutTestController dumpSelectionRect]):
2920         (-[LayoutTestController dumpTitleChanges]):
2921         (-[LayoutTestController dumpBackForwardList]):
2922         (-[LayoutTestController windowCount]):
2923         (-[LayoutTestController dumpChildFrameScrollPositions]):
2924         (-[LayoutTestController dumpChildFramesAsText]):
2925         (-[LayoutTestController dumpEditingCallbacks]):
2926         (-[LayoutTestController dumpResourceLoadCallbacks]):
2927         (-[LayoutTestController dumpFrameLoadCallbacks]):
2928         (-[LayoutTestController setWindowIsKey:]):
2929         (-[LayoutTestController setMainFrameIsFirstResponder:]):
2930         (-[LayoutTestController display]):
2931         (-[LayoutTestController testRepaint]):
2932         (-[LayoutTestController repaintSweepHorizontally]):
2933         (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]):
2934         (-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]):
2935         (-[LayoutTestController _doLoad:target:]):
2936         (-[LayoutTestController _doBackOrForwardNavigation:]):
2937         (-[LayoutTestController queueBackNavigation:]):
2938         (-[LayoutTestController queueForwardNavigation:]):
2939         (-[LayoutTestController queueReload]):
2940         (-[LayoutTestController queueScript:]):
2941         (-[LayoutTestController queueLoad:target:]):
2942         (-[LayoutTestController setAcceptsEditing:]):
2943         (-[LayoutTestController setTabKeyCyclesThroughElements:]):
2944         (-[LayoutTestController storeWebScriptObject:]):
2945         (-[LayoutTestController accessStoredWebScriptObject]):
2946         (-[LayoutTestController dealloc]):
2947         (-[LayoutTestController decodeHostName:]):
2948         (-[LayoutTestController encodeHostName:]):
2949         * DumpRenderTree/ObjCController.h: Added.
2950         * DumpRenderTree/ObjCController.m: Added.
2951         (+[ObjCController isSelectorExcludedFromWebScript:]):
2952         (+[ObjCController webScriptNameForSelector:]):
2953         (-[ObjCController objCClassNameOf:]):
2954         (-[ObjCController objCObjectOfClass:]):
2955         (-[ObjCController objCIdentityIsEqual::]):
2956         (-[ObjCController objCLongLongRoundTrip:]):
2957         (-[ObjCController objCUnsignedLongLongRoundTrip:]):
2958         (-[ObjCController testWrapperRoundTripping:]):
2959
2960 2007-09-07  Sam Weinig  <sam@webkit.org>
2961
2962         Reviewed by Alice.
2963
2964         Strip trailing and leading space/newline characters from skiplist file names.
2965
2966         * Scripts/run-webkit-tests:
2967
2968 2007-09-06  Kevin McCullough  <kmccullough@apple.com>
2969
2970         Reviewed by Maciej.
2971
2972         - Changed Drosera to take advantage of the JSRetainPtr changes.
2973
2974         * Drosera/DebuggerDocument.cpp:
2975         (DebuggerDocument::breakpointEditorHTML):
2976         (DebuggerDocument::evaluateScript):
2977         (DebuggerDocument::valueForScopeVariableNamed):
2978         (DebuggerDocument::log):
2979         (DebuggerDocument::windowScriptObjectAvailable):
2980         (DebuggerDocument::toJSArray):
2981         (DebuggerDocument::callFunctionOnObject):
2982         (DebuggerDocument::logException):
2983         * Drosera/mac/DebuggerDocumentMac.mm:
2984         (-[DebuggerClientMac webView:didLoadMainResourceForDataSource:]):
2985         (-[DebuggerClientMac webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2986         (DebuggerDocument::platformEvaluateScript):
2987         (DebuggerDocument::getPlatformCurrentFunctionStack):
2988         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2989         (DebuggerDocument::platformValueForScopeVariableNamed):
2990
2991 2007-09-05  Kevin McCullough  <kmccullough@apple.com>
2992
2993         Reviewed by Adam, Sam, Darin.
2994
2995         - Separated what is platform dependant from what is not.  Creating the structure needed for Drosera for Win.
2996
2997         * Drosera/Debugger.h: Added.
2998         * Drosera/DebuggerDocument.cpp:
2999         (DebuggerDocument::breakpointEditorHTMLCallback):
3000         (DebuggerDocument::isPausedCallback):
3001         (DebuggerDocument::pauseCallback):
3002         (DebuggerDocument::resumeCallback):
3003         (DebuggerDocument::stepIntoCallback):
3004         (DebuggerDocument::evaluateScriptCallback):
3005         (DebuggerDocument::currentFunctionStackCallback):
3006         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3007         (DebuggerDocument::valueForScopeVariableNamedCallback):
3008         (DebuggerDocument::logCallback):
3009         (DebuggerDocument::breakpointEditorHTML):
3010         (DebuggerDocument::isPaused):
3011         (DebuggerDocument::pause):
3012         (DebuggerDocument::resume):
3013         (DebuggerDocument::stepInto):
3014         (DebuggerDocument::evaluateScript):
3015         (DebuggerDocument::currentFunctionStack):
3016         (DebuggerDocument::localScopeVariableNamesForCallFrame):
3017         (DebuggerDocument::valueForScopeVariableNamed):
3018         (DebuggerDocument::log):
3019         (DebuggerDocument::toolbarPause):
3020         (DebuggerDocument::toolbarResume):
3021         (DebuggerDocument::toolbarStepInto):
3022         (DebuggerDocument::toolbarStepOver):
3023         (DebuggerDocument::toolbarStepOut):
3024         (DebuggerDocument::toolbarShowConsole):
3025         (DebuggerDocument::toolbarCloseCurrentFile):
3026         (DebuggerDocument::updateFileSource):
3027         (DebuggerDocument::didParseScript):
3028         (DebuggerDocument::willExecuteStatement):
3029         (DebuggerDocument::didEnterCallFrame):
3030         (DebuggerDocument::willLeaveCallFrame):
3031         (DebuggerDocument::exceptionWasRaised):
3032         (DebuggerDocument::windowScriptObjectAvailable):
3033         (DebuggerDocument::toJSArray):
3034         (DebuggerDocument::callGlobalFunction):
3035         (DebuggerDocument::callFunctionOnObject):
3036         (DebuggerDocument::getDroseraJSClass):
3037         (DebuggerDocument::staticFunctions):
3038         (DebuggerDocument::logException):
3039         * Drosera/DebuggerDocument.h:
3040         (DebuggerDocument::DebuggerDocument):
3041         * Drosera/ForwardingHeaders: Added.
3042         * Drosera/ForwardingHeaders/wtf: Added.
3043         * Drosera/ForwardingHeaders/wtf/Platform.h: Added.
3044         * Drosera/config.h:
3045         * Drosera/console.html:
3046         * Drosera/console.js:
3047         * Drosera/debugger.js:
3048         * Drosera/mac/DebuggerApplication.mm:
3049         (-[DebuggerApplication attach:]):
3050         * Drosera/mac/DebuggerDocumentMac.h:
3051         * Drosera/mac/DebuggerDocumentMac.mm:
3052         (+[NSString stringOrNilFromWebScriptResult:]):
3053         (+[DebuggerClientMac log:]):
3054         (-[DebuggerClientMac initWithServerName:]):
3055         (-[DebuggerClientMac dealloc]):
3056         (-[DebuggerClientMac pause]):
3057         (-[DebuggerClientMac resume]):
3058         (-[DebuggerClientMac pause:]):
3059         (-[DebuggerClientMac resume:]):
3060         (-[DebuggerClientMac stepInto:]):
3061         (-[DebuggerClientMac stepOver:]):
3062         (-[DebuggerClientMac stepOut:]):
3063         (-[DebuggerClientMac showConsole:]):
3064         (-[DebuggerClientMac closeCurrentFile:]):
3065         (-[DebuggerClientMac validateUserInterfaceItem:]):
3066         (-[DebuggerClientMac webView:windowScriptObjectAvailable:]):
3067         (-[DebuggerClientMac webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3068         (-[DebuggerClientMac webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3069         (-[DebuggerClientMac webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3070         (-[DebuggerClientMac webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3071         (DebuggerDocument::platformPause):
3072         (DebuggerDocument::platformResume):
3073         (DebuggerDocument::platformStepInto):
3074         (DebuggerDocument::platformEvaluateScript):
3075         (DebuggerDocument::platformCurrentFunctionStack):
3076         (DebuggerDocument::platformLocalScopeVariableNamesForCallFrame):
3077         (DebuggerDocument::platformValueForScopeVariableNamed):
3078         (DebuggerDocument::platformLog):
3079         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3080
3081 2007-09-06  Sam Weinig  <sam@webkit.org>
3082
3083         Reviewed by Adam Roben.
3084
3085         Register the WebKit DLL on initialization of the DumpRenderTree.
3086
3087         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3088         (initialize):
3089
3090 2007-09-05  Sam Weinig  <sam@webkit.org>
3091
3092         Reviewed by Oliver.
3093
3094         Fix many layout test failures caused by r25364.
3095         Set text size to standand size at the begining of each test matching the mac.
3096
3097         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3098         (runTest):
3099
3100 2007-09-04  Sam Weinig  <sam@webkit.org>
3101
3102         Reviewed by Adam.
3103
3104         Fix for <rdar://problem/5382277>
3105         Implement eventSender.textZoomIn and eventSender.textZoomOut for windows DRT.
3106
3107         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp:
3108         (textZoomInCallback):
3109         (textZoomOutCallback):
3110
3111 2007-08-29  David Kilzer  <ddkilzer@apple.com>
3112
3113         Reviewed by Adam.
3114
3115         Added case-insensitivity to checks for adding regression tests.
3116
3117         * Scripts/prepare-ChangeLog:
3118         (generateFileList):
3119
3120 2007-08-28  David Kilzer  <ddkilzer@apple.com>
3121
3122         Reviewed by Maciej.
3123
3124         Ignore files in /resources/ subdirectories when creating a list of added tests.
3125
3126         * Scripts/prepare-ChangeLog:
3127         (generateFileList):
3128
3129 2007-08-27  Kevin McCullough  <kmccullough@apple.com>
3130
3131         Reviewed by John.
3132
3133         - Removed Leopard leaks list since all of those radars were fixed.
3134
3135         * Scripts/run-webkit-tests:
3136
3137 2007-08-27  Adam Roben  <aroben@apple.com>
3138
3139         Rubberstamped by Mark.
3140
3141         * Scripts/pdevenv: Pass arguments along to devenv.com.
3142
3143 2007-08-26  David Kilzer  <ddkilzer@webkit.org>
3144
3145         Reviewed by Mark Rowe.
3146
3147         Update prepare-ChangeLog to generate the datestamp in the correct timezone.
3148
3149         * Scripts/prepare-ChangeLog:
3150         (changeLogDate): Added.
3151
3152 2007-08-24  Sam Weinig  <sam@webkit.org>
3153
3154         Revert r25216 which renamed the COM DOM bindings to use Deprecated prefix.
3155
3156 2007-08-24  Sam Weinig  <sam@webkit.org>
3157
3158         Rubber-stamped by Adam Roben.
3159
3160         <rdar://problem/5434593> Deprecate current manually written COM DOM bindings in anticipation of autogeneration
3161
3162         Rename COM DOM bindings to use Deprecated prefix.
3163
3164         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3165         (dumpFramesAsText):
3166         (dump):
3167         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp:
3168         (dumpPath):
3169         (dump):
3170         (EditingDelegate::shouldBeginEditingInDOMRange):
3171         (EditingDelegate::shouldEndEditingInDOMRange):
3172         (EditingDelegate::shouldInsertNode):
3173         (EditingDelegate::shouldInsertText):
3174         (EditingDelegate::shouldDeleteDOMRange):
3175         (EditingDelegate::shouldChangeSelectedDOMRange):
3176         (EditingDelegate::shouldApplyStyle):
3177         (EditingDelegate::shouldChangeTypingStyle):
3178         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h:
3179
3180 2007-08-24  Oliver Hunt  <oliver@apple.com>
3181
3182         Reviewed by John H.
3183
3184         WebDataSource::response can legitimately have a null response, so we
3185         must check that case.
3186
3187         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
3188         (queueLoadCallback):
3189
3190 2007-08-23  Mitz Pettel  <mitz@webkit.org>
3191
3192         Reviewed by Darin and Adam.
3193
3194         - DumpRenderTree changes to allow testing for
3195           http://bugs.webkit.org/show_bug.cgi?id=11756
3196           REGRESSION: link targeting a frame in another window does not work
3197           <rdar://problem/5286420>
3198
3199         Use a frame group name for all WebViews created by DumpRenderTree to
3200         allow testing of cross-page frame lookup.
3201
3202         * DumpRenderTree/DumpRenderTree.m:
3203         (createWebView): Pass group name to -[WebView initWithFrame:frameName:groupName:].
3204         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3205         (main): Pass group name to WebView::initWithFrame(RECT, BSTR, BSTR).
3206
3207 2007-08-23  David Kilzer  <ddkilzer@webkit.org>
3208
3209         Reviewed by Adam.
3210
3211         Quote the $sslCertificate path in case it contains a space.
3212
3213         * Scripts/run-webkit-httpd:
3214         * Scripts/run-webkit-tests:
3215
3216 2007-08-22  Oliver Hunt  <oliver@apple.com>
3217
3218         Reviewed by John and Adam.
3219
3220         WebDataSource::response can legitimately have a null response, so we
3221         must check that case.
3222
3223         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3224         (dump):
3225
3226 2007-08-21  Kevin McCullough  <kmccullough@apple.com>
3227
3228         Reviewed by Geof.
3229
3230         - Changing the usage to be more clear.
3231
3232         * Scripts/run-testkjs:
3233
3234 2007-08-20  John Sullivan  <sullivan@apple.com>
3235
3236         Reviewed by Adam Roben
3237
3238         * DumpRenderTree/DumpRenderTree.m:
3239         (runTest):
3240         call new +[WebView _setUsesTestModeFocusRingColor:YES] so we get the same focus ring colors
3241         in layout tests on Tiger and Leopard
3242
3243 2007-08-20  Adam Roben  <aroben@apple.com>
3244
3245         Put LayoutTests after all other ChangeLogs in commit logs
3246
3247         We use "~" to sort LayoutTests after all the other ChangeLogs because
3248         "~" is the last ASCII character (other than "DEL").
3249
3250         Reviewed by Sam.
3251
3252         * Scripts/commit-log-editor:
3253
3254 2007-08-20  Adam Roben  <aroben@apple.com>
3255
3256         Detect that DRT crashed even if a crash dialog is running
3257
3258         On Windows, when DRT crashes a crash dialog commonly appears. The DRT
3259         process is still running at this point, so run-webkit-tests wouldn't
3260         detect that DRT had crashed. We now record the crash in our SIGPIPE
3261         handler so that we know if DRT crashed even if the crash dialog is up.
3262
3263         Reviewed by Sam.
3264
3265         * Scripts/run-webkit-tests:
3266         (sub catch_pipe): Set the crashed bit.
3267         (sub openDumpTool): Reset the crashed bit.
3268         (sub dumpToolDidCrash): Check the crashed bit.
3269
3270 2007-08-20  Adam Roben  <aroben@apple.com>
3271
3272         Fix Bug 15026: prepare-ChangeLog should list new tests in WebCore/ChangeLog
3273
3274         http://bugs.webkit.org/show_bug.cgi?id=15026
3275
3276         Reviewed by David Kilzer and Darin Adler.
3277
3278         * Scripts/prepare-ChangeLog:
3279         (sub isModifiedStatus): Split out from isModifiedOrAddedStatus.
3280         (sub isAddedStatus): Ditto.
3281         (sub testListForChangeLog): Added.
3282
3283 2007-08-19  Oleg Sukhodolsky  <son.two@gmail.com>
3284
3285         Reviewed by Mark.
3286
3287         -fixes http://bugs.webkit.org/show_bug.cgi?id=14632
3288
3289         * Scripts/webkitdirs.pm:
3290         qt and gtk ports now explicitly pass debug (or release) mode to qmake.
3291
3292 2007-08-17  Darin Adler  <darin@apple.com>
3293
3294         Reviewed by Oliver Hunt.
3295
3296         - don't look for Apple-style localizable strings in the GTK version of WebKit
3297
3298         * Scripts/extract-localizable-strings: Add a feature where you can pass in the
3299         name of subdirectories to skip.
3300         * Scripts/update-webkit-localizable-strings: Pass WebKit/gtk as a subdirectory
3301         to skip.
3302
3303 2007-08-17  Anders Carlsson  <andersca@apple.com>
3304
3305         Build fix.
3306
3307         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3308         (NPP_SetWindow):
3309
3310 2007-08-17  Anders Carlsson  <andersca@apple.com>
3311
3312         Reviewed by Dave Hyatt.
3313
3314         <rdar://problem/5379040>
3315         REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes
3316
3317         Add a way for the plug-in to dump the width and height when it gets its  NPP_SetWindow call.
3318
3319         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
3320         (pluginAllocate):
3321         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3322         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3323         (NPP_New):
3324         (NPP_SetWindow):
3325
3326 2007-08-16  Alice Liu  <alice.liu@apple.com>
3327
3328         Reviewed by Maciej.
3329
3330         Fix <rdar://problem/5360135> REGRESSION (Leopard only): editing/selection/5354455-1.html is causing subsequent tests to fail
3331
3332         * DumpRenderTree/DumpRenderTree.m:
3333         (createWebView):
3334         Create a DumpRenderTreeWindow instead of a NSWindow, now that a DumpRenderTreeWindow no longer poses as a NSWindow.
3335         (dumpRenderTree):
3336         Don't pose as a NSWindow, since when the spelling panel gets created, it creates an NSWindow which ends up creating a DumpRenderTreeWindow.
3337
3338 2007-08-16  Kevin McCullough  <kmccullough@apple.com>
3339
3340         Reviewed by Adam.
3341
3342         - Added tests for regressions in other components.  In this case we also need to add a skipped list for Tiger since this functionality didn't exist in 10.4.
3343
3344         * Scripts/run-webkit-tests:
3345
3346 2007-08-15  Timothy Hatcher  <timothy@apple.com>
3347
3348         Look for the new Xcode 3 preference key (PBXApplicationwideBuildSettings) for the global build locations.
3349         The value of PBXApplicationwideBuildSettings is a dictionary, so we have to pull the SYMROOT out of it.
3350
3351         Also pass xcodebuild OBJROOT with the same value as SYMROOT if we fallback to the default WebKitBuild,
3352         this prevents making "build" directories in each project folder.
3353
3354         * Scripts/webkitdirs.pm:
3355
3356 2007-08-14  Geoffrey Garen  <ggaren@apple.com>
3357
3358         Reviewed by Kevin Mccullough.
3359
3360         Removed special case that didn't belong. (It would allow a global
3361         initializer to sneak into production builds, which would cause a
3362         system-wide performance regression on Mac OS X.)
3363
3364         * Scripts/check-for-global-initializers:
3365
3366 2007-08-14  Justin Garcia  <justin.garcia@apple.com>
3367
3368         Reviewed by Tim.
3369
3370         <rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element
3371
3372         * DumpRenderTree/EditingDelegate.m:
3373         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Added, return YES
3374         only for elements with the class needsDeletionUI.
3375
3376 2007-08-14  David Kilzer  <ddkilzer@webkit.org>
3377
3378         Reviewed by Darin.
3379
3380         - fix http://bugs.webkit.org/show_bug.cgi?id=14965
3381           svn-create-patch uses deprecated tail switch
3382
3383         * Scripts/svn-create-patch: Use 'tail -n +3' instead of 'tail +3'.
3384
3385 2007-08-13  Sam Weinig  <sam@webkit.org>
3386
3387         Reviewed by Adam Roben.
3388
3389         Use the cygwin specific Apache config file under cygwin.
3390
3391         * Scripts/run-webkit-httpd:
3392
3393 2007-08-12  Adam Roben  <aroben@apple.com>
3394
3395         Generate results for new tests in a more logical location
3396
3397         New platform-specific tests always have their results generated right
3398         next to the test. New cross-platform tests will have their results
3399         generated a) in the cross-platform directory, if they are text-only,
3400         or b) in the least-specific platform directory, if they are render
3401         tree dumps.
3402
3403         Reviewed by Lars.
3404
3405         * Scripts/run-webkit-tests:
3406
3407 2007-08-12  Adam Roben  <aroben@apple.com>
3408
3409         Print the actual directory where new results are generated.
3410
3411         Before, we were printing an unpredictable, context-specific substring
3412         of the directory.
3413
3414         Reviewed by Lars.
3415
3416         * Scripts/run-webkit-tests:
3417
3418 2007-08-12  Adam Roben  <aroben@apple.com>
3419
3420         Factor some common code into a stripExtension() subroutine.
3421
3422         Reviewed by Lars.
3423
3424         * Scripts/run-webkit-tests: Also removed some debugging output.
3425
3426 2007-08-11  Matt Lilek  <pewtermoose@gmail.com>
3427
3428         Reviewed over and over and over by Adam Roben.
3429
3430         Bug 14740: Hierarchical layout tests and platform organization
3431         http://bugs.webkit.org/show_bug.cgi?id=14740
3432
3433         Add support for platform-specific layout tests and results.
3434
3435         * Scripts/run-webkit-tests:
3436
3437 2007-08-11  David Kilzer  <ddkilzer@webkit.org>
3438
3439         Reviewed by Adam.
3440
3441         Refactored svn-create-path to use a hash-of-hashes data structure to keep
3442         track of changed files.  In the top level hash, keys are paths to files and
3443         values are 'fileData' hashes with the following keys and values:
3444
3445         - isBinary: boolean value (set to true for non-text files like images, etc.)
3446         - isTestFile: boolean value (set to true if file exists within a known test
3447           directory)
3448         - modificationType: string equal to one of 'addition', 'additionWithHistory',
3449           'modification' or 'deletion'
3450         - path: string equal to the path to the file (this may seem redundant, but it
3451           is required to use the second-level 'fileData' hash independent of the
3452           top-level hash)
3453         - sourceFile: [optional] string equal to the path of the original file that was
3454           copied or moved
3455         - sourceRevision: [optional] string equal to the revision of the original file
3456           that was copied or moved
3457
3458         * Scripts/svn-create-patch: Moved call to GetOptions() to its own statement
3459         that saves the return value in $result, then checks it before printing help.
3460         Combined sourceFiles, %testFiles, and %binaryFiles into single %diffFiles hash
3461         and eliminated two for() loops.
3462         (binarycmp): Added.  Used with sort() to order non-binary files before binary
3463         files.
3464         (findBaseUrl): Added.  Extracted from findSourceFileAndRevision().
3465         (findMimeType): Added optional second argument that takes a revision number.
3466         (generateDiff): Updated to take one fileData argument instead of three ($file,
3467         $modificationType, $isBinary).
3468         (generateFileList): Updated to take one hash ref argument (%diffFiles)
3469         instead of three (%sourceFiles, %testFiles, %binaryFiles).  Populates
3470         %diffFiles using paths for keys and fileData hashes for values.
3471         (manufacturePatchForAdditionWithHistory): Updated to take one fileData
3472         argument.
3473         (pathcmp): Updated to take two fileData arguments instead of two strings.
3474         (testfilecmp): Added.  Used with sort() to order non-test files before test
3475         files.
3476
3477 2007-08-11  Darin Adler  <darin@apple.com>
3478
3479         * Scripts/run-webkit-tests: Give a different message when only the pixel test failed.
3480
3481 2007-08-06  Nigel Tao  <nigeltao@gnome.org>
3482
3483         Reviewed by David Kilzer.
3484
3485         Fix bug 14745: WebKitTools/Scripts/run-launcher doesn't speak --gdk
3486         http://bugs.webkit.org/show_bug.cgi?id=14745
3487
3488         * Scripts/run-launcher:
3489         Scrub the "--gdk" out of the command line args, if given, so that
3490         GdkLauncher doesn't try to interpret it as a URL.
3491
3492 2007-08-03  Adam Roben  <aroben@apple.com>
3493
3494         Catch SIGPIPE on Windows so that run-webkit-tests doesn't quit when DRT crashes
3495
3496         Reviewed by Sam.
3497
3498         * Scripts/run-webkit-tests: Also close ERROR when we finish running the tests.
3499
3500 2007-08-03  Sam Weinig  <sam@webkit.org>
3501
3502         Reviewed by Darin.
3503
3504         Recursively dump all frames as text using new
3505         layoutTestController.dumpChildFramesAsText() function.
3506
3507         * DumpRenderTree/DumpRenderTree.m:
3508         (dumpFramesAsText):
3509         (dump):
3510         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
3511         (-[LayoutTestController dumpChildFramesAsText]):
3512         (runTest):
3513         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3514         (dumpFramesAsText):
3515         (dump):
3516         (runTest):
3517         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h:
3518         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
3519         (dumpChildFramesAsTextCallback):
3520         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3521
3522 2007-08-02  Adam Roben  <aroben@apple.com>
3523
3524         Fix fast/dom/Window/alert-undefined.html
3525
3526         Reviewed by Sam.
3527
3528         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
3529         (WaitUntilDoneDelegate::runJavaScriptAlertPanelWithMessage): Don't let
3530         Windows translate a null BSTR into "(null)"
3531
3532 2007-08-02  Kevin McCullough  <kmccullough@apple.com>
3533
3534         Reviewed by Tim.
3535
3536         - It would help if I actually called the right function.
3537
3538         * Drosera/DebuggerDocument.cpp:
3539         (DebuggerDocument::showConsole):
3540
3541 2007-08-02  Adam Roben  <aroben@apple.com>
3542
3543         Don't delete the stderr file right after creating it
3544
3545         * Scripts/run-webkit-tests:
3546
3547 2007-08-01