2008-01-04 Alp Toker <alp@atoker.com>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-01-04  Alp Toker  <alp@atoker.com>
2
3         GTK+ DRT build fix for breakage introduced in r29149.
4
5         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
6         (LayoutTestController::execCommand):
7
8 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
9
10         Reviewed by Darin.
11
12         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
13
14         Added layoutTestController.execCommand to access editor commands that are not available
15         via document.execCommand.
16
17         * DumpRenderTree/LayoutTestController.cpp:
18         (execCommandCallback):
19         (LayoutTestController::staticFunctions):
20         * DumpRenderTree/LayoutTestController.h:
21         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
22         (LayoutTestController::execCommand):
23         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
24         (LayoutTestController::queueLoad):
25         (LayoutTestController::execCommand):
26
27 2008-01-03  Alice Liu  <alice.liu@apple.com>
28
29         Reviewed by Darin, Mitz.
30
31         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
32
33         the clickcount should not increase if the last click was at a different location.  it's a new click.
34
35         * DumpRenderTree/mac/DumpRenderTree.mm:
36         (runTest):
37         * DumpRenderTree/mac/EventSendingController.h:
38         * DumpRenderTree/mac/EventSendingController.mm:
39         (-[EventSendingController mouseDown]):
40         (-[EventSendingController mouseUp]):
41
42 2008-01-03  Darin Adler  <darin@apple.com>
43
44         Reviewed by Adam.
45
46         * Scripts/update-webkit: Make this work a little better for the people at Apple
47         who have a directory named Internal.
48
49 2008-01-03  Adam Roben  <aroben@apple.com>
50
51         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
52
53         Rubberstamped by Mark.
54
55         * Scripts/update-webkit-auxiliary-libs:
56
57 2008-01-03  Adam Roben  <aroben@apple.com>
58
59         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
60
61         http://bugs.webkit.org/show_bug.cgi?id=15663
62
63         Added a fuzz factor into the Last-Modified comparison for downloading
64         WebKitAuxiliaryLibrary.zip.
65
66         The zip file is served from a set of mirrors who give Last-Modified
67         times that are off by 1-3 seconds from each other. This was causing
68         the build bots to redownload WebKitAuxiliaryLibrary for every build,
69         which would then cause all of WebCore to rebuild each time.
70
71         Reviewed by Mark.
72
73         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
74         at least 30 seconds newer than the old one -- otherwise we assume that
75         the difference in time is due to the mirrors being slightly offset
76         from each other.
77         (sub lastModifiedToUnixTime): Added.
78
79 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
80
81         Windows build fix.
82
83         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
84
85 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
86
87         Reviewed by Lars.
88
89         Moved QWebPage::open to QWebFrame::load and added setHtml.
90         
91
92         * DumpRenderTree/qt/DumpRenderTree.cpp:
93         (WebCore::DumpRenderTree::open):
94
95 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
96
97         Reviewed by Lars.
98
99         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
100         
101
102         * DumpRenderTree/qt/DumpRenderTree.cpp:
103         (WebCore::DumpRenderTree::DumpRenderTree):
104
105 2008-01-02  Sam Weinig  <sam@webkit.org>
106
107         * Scripts/do-webcore-rename: Yet more renaming ideas.
108
109 2008-01-02  Darin Adler  <darin@apple.com>
110
111         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
112
113 2008-01-02  Alice Liu  <alice.liu@apple.com>
114
115         Reviewed by Sam Weinig.
116
117         fixing assertion hit with editing/selection/move-begin-end.html
118
119         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
120         * DumpRenderTree/win/DumpRenderTree.vcproj:
121         * DumpRenderTree/win/EventSender.cpp:
122         (keyDownCallback):
123         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
124
125 2008-01-02  Darin Adler  <darin@apple.com>
126
127         * Scripts/do-webcore-rename: Some more name change plans.
128
129 2008-01-02  Alice Liu  <alice.liu@apple.com>
130
131         Reviewed by Maciej.
132
133         Added handling for page up and page down in EventSender
134
135         * DumpRenderTree/mac/EventSendingController.mm:
136         (-[EventSendingController keyDown:withModifiers:]):
137         * DumpRenderTree/win/EventSender.cpp:
138         (keyDownCallback):
139
140 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
141
142         Reviewed by Darin.
143
144         Fix fast/events/arrow-keys-on-body.html for real.
145
146         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
147
148 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
149
150         Reviewed by Darin.
151
152         http://bugs.webkit.org/show_bug.cgi?id=16674
153         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
154
155         * Scripts/run-launcher:
156
157 2007-12-31  Darin Adler  <darin@apple.com>
158
159         Suggested by Antti.
160
161         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
162         we get it installed on the build bots.
163
164 2007-12-30  Eric Seidel  <eric@webkit.org>
165
166         Reviewed by Sam.
167
168         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
169
170 2007-12-29  Darin Adler  <darin@apple.com>
171
172         Reviewed by Oliver.
173
174         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
175           leak bot shows createCStringFromNPVariant result leaking
176
177         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
178         (pluginInvoke): Added a missing free.
179
180 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
181
182         Reviewed by Alp Toker.
183
184         http://bugs.webkit.org/show_bug.cgi?id=16390
185         Use autotools or GNU make as the build system for the GTK port
186
187         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
188         * GNUmakefile.am: Added.
189
190 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
191
192         Reviewed by Oliver.
193
194         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
195
196         * DumpRenderTree/win/EventSender.cpp:
197         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
198         of 1, even though WebKit currently ignores it.
199
200 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
201
202         wx buildbot fix. Update libpng dl script to the latest version.
203
204         * wx/install-unix-extras:
205
206 2007-12-22  Antti Koivisto  <antti@apple.com>
207
208         Fix a typo.
209
210         * Scripts/webkitdirs.pm:
211
212 2007-12-21  Sam Weinig  <sam@webkit.org>
213
214         Reviewed by Mark Rowe.
215
216         - Disable the back/forward cache using the new WebPreferences API
217           instead of through the BackForwardList.  This makes us match what
218           we do on Windows.
219
220         * DumpRenderTree/mac/DumpRenderTree.mm:
221         (createWebViewAndOffscreenWindow):
222         (setDefaultsToConsistentValuesForTesting):
223
224 2007-12-21  Dan Bernstein  <mitz@apple.com>
225
226         Reviewed by Mark Rowe.
227
228         - disable the back/forward cache in Windows DumpRenderTree. It is
229           already disabled in Mac DumpRenderTree.
230
231         * DumpRenderTree/win/DumpRenderTree.cpp:
232         (initializePreferences):
233
234 2007-12-13  Antti Koivisto  <antti@apple.com>
235
236         Reviewed by Darin and Steve.
237         
238         - check for QuickTime SDK on Windows.
239         - build media support on Windows by default
240
241         * Scripts/build-webkit:
242         * Scripts/webkitdirs.pm:
243
244 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
245
246         Build script fix for buildbot.
247
248         * wx/build-wxwebkit:
249
250 2007-12-20  Eric Seidel  <eric@webkit.org>
251
252         Reviewed by mjs.
253
254         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
255
256 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
257
258         Reviewed by Steve.
259
260         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
261         WebKit.
262
263         - Drosera and Safari need to use the same ProgIDs in order for
264         CoCreateInstance to work properly.  The most robust way to do this is
265         for WebKit to dynamically publish those ProgIDs.
266
267         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
268         (DebuggerClient::createWebViewWithRequest):
269         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
270         statics.
271         (Drosera::initUI):
272         (Drosera::attach):
273         (Drosera::attemptToCreateServerConnection):
274         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
275         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
276         make use of the published ProgIDs.
277         (ServerConnection::attemptToCreateServerConnection):
278
279 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
280
281         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
282         - Build bot and leak fix.
283
284         * DumpRenderTree/LayoutTestController.cpp:
285         (pathToLocalResourceCallback):
286
287 2007-12-19  David Kilzer  <ddkilzer@apple.com>
288
289         Make svn-apply/svn-unapply work with patches from git-format-patch.
290
291         Reviewed by Darin.
292
293         * Scripts/svn-apply:
294         (patch): If 'Index:' can't be found in the text passed in, print it
295         out with a warning and return early.
296         * Scripts/svn-unapply:
297         (patch): Ditto.
298
299 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
300
301         Reviewed by Alp Toker.
302
303         Build related fixes.
304
305         * wx/build-wxwebkit:
306         - Check to make sure the user is running a supported wx port
307         - More robust checks for Cygwin
308         - Only run install-unix-extras on Mac, it's not the right solution
309           for Linux distros.
310         - Remove outdated Linux instructions after successful build
311         - Clean Bakefile-generated files during a clean operation
312
313 2007-12-18  Darin Adler  <darin@apple.com>
314
315         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
316
317 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
318
319         Add script to run Drosera as part of the nightly.
320         
321         Reviewed by Kevin M.
322
323         * Scripts/run-drosera.cmd: Added.
324
325 2007-12-18  Darin Adler  <darin@apple.com>
326
327         * Scripts/do-webcore-rename: Remove a stray K.
328
329 2007-12-18  Darin Adler  <darin@apple.com>
330
331         * Scripts/do-webcore-rename: Plan more renaming.
332
333 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
334
335         Reviewed by Alp Toker.
336
337         http://bugs.webkit.org/show_bug.cgi?id=16042
338         [GTK] Eliminate webkit_init()
339
340         Moving webkit initialization to WebView class init.
341
342         * DumpRenderTree/gtk/DumpRenderTree.cpp:
343         (main):
344         * GtkLauncher/main.c:
345         (main):
346
347 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
348
349         Reviewed by Alp Toker.
350
351         http://bugs.webkit.org/show_bug.cgi?id=13542
352         gdklauncher doesnt change URL in adress GTKEntry.
353
354         * GtkLauncher/main.c:
355         (load_commit_cb): added
356         (title_change_cb):
357         (create_browser):
358
359 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
360
361         Reviewed by Adam Roben.
362
363         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
364
365         * FindSafari/FindSafari.cpp:
366         (_tmain):
367
368 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
369
370         Reviewed by Adam Roben.
371
372         http://bugs.webkit.org/show_bug.cgi?id=16315
373         FindSafari needs a path-only option.
374
375         * FindSafari/FindSafari.cpp:
376         (_tmain):
377
378 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
379
380         Reviewed by Darin.
381
382         http://bugs.webkit.org/show_bug.cgi?id=16462
383         REGRESSION: access keys broken on Windows
384
385         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
386         if Alt is pressed.
387
388 2007-12-15  Sam Weinig  <sam@webkit.org>
389
390         Reviewed by Mark Rowe.
391
392         Fix urlSuitableForTestResult to correctly identify wstring::npos as
393         the case when wstring.find doesn't find anything.
394
395         * DumpRenderTree/win/DumpRenderTree.cpp:
396         (urlSuitableForTestResult):
397
398 2007-12-15  Alp Toker  <alp@atoker.com>
399
400         GTK+ DRT build fix for GLib < 2.14.
401
402         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
403         (LayoutTestController::setWaitToDump):
404
405 2007-12-05  Mark Rowe  <mrowe@apple.com>
406
407         Reviewed by Alp Toker.
408
409         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
410         many layout tests from hanging while waiting on user responses to dialogs.
411
412         * DumpRenderTree/gtk/DumpRenderTree.cpp:
413         (invalidateAnyPreviousWaitToDumpWatchdog):
414         (webViewScriptAlert):
415         (webViewScriptPrompt):
416         (webViewScriptConfirm):
417         (main):
418         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
419         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
420         (waitToDumpWatchdogFired):
421         (LayoutTestController::setWaitToDump):
422
423 2007-12-05  Mark Rowe  <mrowe@apple.com>
424
425         Reviewed by Alp Toker.
426
427         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
428
429         * DumpRenderTree/gtk/DumpRenderTree.cpp:
430         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
431         (dump):
432         (runTest):
433         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
434         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
435         work queue is empty.
436         (webViewWindowObjectCleared): Set up window.layoutTestController.
437         (webViewConsoleMessage): Match the console message format expected by the layout test results.
438         (main): Hook up the new signals.
439         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
440         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
441         dumping multiple times.
442         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
443         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
444
445 2007-12-14  Anders Carlsson  <andersca@apple.com>
446
447         Reviewed by Brady.
448
449         Assert that a web frame that's loading a resource always has either a data source or 
450         a provisional data source.
451         
452         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
453         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
454
455 2007-12-14  Darin Adler  <darin@apple.com>
456
457         - fix mistake causing nearly all tests to fail on Windows
458
459         * DumpRenderTree/win/UIDelegate.cpp:
460         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
461         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
462
463         * DumpRenderTree/mac/UIDelegate.mm:
464         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
465         than passing the entire message.
466
467 2007-12-14  Darin Adler  <darin@apple.com>
468
469         - fix Tiger build
470
471         * DumpRenderTree/mac/UIDelegate.mm:
472         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
473         new-to-Leopard methods.
474
475 2007-12-14  Darin Adler  <darin@apple.com>
476
477         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
478         since it now triggers unwanted icon loading. We only had it because we implemented "all"
479         delegate methods here.
480
481 2007-12-14  Anders Carlsson  <andersca@apple.com>
482
483         Reviewed by Darin and Geoff.
484
485         <rdar://problem/5619295> 
486         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
487         
488         Add property getting methods to the plug-in.
489         
490         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
491         (pluginInvoke):
492
493 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
494
495         Reviewed by Darin.
496
497         - Layout test fix for mac. When dumped to the console local file paths
498         now only show the name of the resource not the whole path.  This is to
499         make the results machine and OS independent.
500
501         * DumpRenderTree/mac/UIDelegate.mm:
502         (-[UIDelegate webView:addMessageToConsole:]):
503
504 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
505
506         Reviewed by Adam.
507
508         - Layout tests fix.  We need a way to remove machine-dependent
509         information from paths in layout test results. The UIDelegate now does
510         this.
511
512         * DumpRenderTree/DumpRenderTree.h:
513         * DumpRenderTree/win/DumpRenderTree.cpp:
514         (urlSuitableForTestResult):
515         * DumpRenderTree/win/DumpRenderTreeWin.h:
516         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
517         * DumpRenderTree/win/UIDelegate.cpp:
518         (UIDelegate::webViewAddMessageToConsole):
519
520 2007-12-13  Alp Toker  <alp@atoker.com>
521
522         Build fix for DRT breakage introduced in r28690.
523
524         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
525         (LayoutTestController::pathToLocalResource):
526
527 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
528
529         Reviewed by Alice and Sam.
530
531         - <rdar://5621435> Need a way to specify local resources (being loaded
532         from HTTP tests) on Windows.
533         - Implemented pathToLocalResource which exposes the functionality of
534         converting a given unix path to the correct location on Windows.
535
536         * DumpRenderTree/LayoutTestController.cpp:
537         (pathToLocalResourceCallback):
538         (LayoutTestController::staticFunctions):
539         * DumpRenderTree/LayoutTestController.h:
540         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
541         (LayoutTestController::pathToLocalResource):
542         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
543         (LayoutTestController::pathToLocalResource):
544
545 2007-12-12  Anders Carlsson  <andersca@apple.com>
546
547         Reviewed by Sam.
548
549         <rdar://problem/5132003>
550         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
551
552         * DumpRenderTree/win/DumpRenderTree.cpp:
553         (main):
554         Set the resource load delegate.
555         
556         * DumpRenderTree/win/DumpRenderTree.vcproj:
557         
558         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
559         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
560
561 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
562
563         Reviewed by Adam Roben.
564
565         Fix conversion from double to LPARAM in dispatchMessage().
566
567         * DumpRenderTree/win/EventSender.cpp:
568         (dispatchMessageCallback):
569
570 2007-12-11  Dan Bernstein  <mitz@apple.com>
571
572         Reviewed by Mark Rowe and Sam Weinig too!
573
574         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
575           fonts DumpRenderTree registers.
576
577         * DumpRenderTree/win/DumpRenderTree.cpp:
578         (initialize):
579
580 2007-12-11  Brady Eidson  <beidson@apple.com>
581
582         Reviewed by Anders
583
584         Make DumpRenderTree on mac use its own path for Databases testing
585
586         * DumpRenderTree/mac/DumpRenderTree.mm:
587         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
588           for future DRT-only use, then use it to construct the Databases path and set that default
589
590 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
591
592         Reviewed by Darin.
593
594         <rdar://problem/5535636>
595         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
596
597         http://bugs.webkit.org/show_bug.cgi?id=13916
598         JavaScript detects Tab as a character input on a textfield validation
599
600         * DumpRenderTree/mac/EventSendingController.mm:
601         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
602         Dispatch a keyup to better match what happens when a key is physically pressed.
603
604         * DumpRenderTree/win/EventSender.cpp:
605         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
606         returning from keyDown().
607         (getConstantCallback): Fixed a couple copy/paste mistakes.
608
609 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
610
611         Reviewed by Oliver.
612
613         - <rdar://5599845> Drosera: Does not show loal files in the file list
614         on the left side.
615
616         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
617         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
618         so the open source community can build.
619
620 2007-12-10  Brady Eidson  <beidson@apple.com>
621
622         Rubberstamped by Sam Weinig
623
624         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
625
626         * DumpRenderTree/mac/UIDelegate.mm:
627         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
628         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
629
630 2007-12-08  Oliver Hunt  <oliver@apple.com>
631
632         Reviewed by Sam W.
633
634         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
635         
636         Fixes <rdar://problem/5620249> Must disable SVG animation
637         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
638         
639         In order to allow finer grained control over the set of SVG features
640         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
641         distinct flags:
642         ENABLE_SVG_ANIMATION
643         ENABLE_SVG_FILTERS
644         ENABLE_SVG_FONTS
645         ENABLE_SVG_AS_IMAGE
646         ENABLE_SVG_USE
647         
648         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
649         
650         Script handles all the new build flags, and allows --svg-experimental
651         to automatically enable all features.
652
653         * Scripts/build-webkit:
654
655 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
656
657         Fix version parsing.
658
659         Rubber-stamped by Oliver.
660
661         * Drosera/win/Drosera.vcproj/auto-version.sh:
662
663 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
664
665         Build modifications for Drosera.
666
667         Reviewed by Adam.
668
669         * Drosera/DroseraWin.make: Added.
670         * Drosera/win/Drosera.vcproj/Drosera.rc:
671         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
672         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
673         * Drosera/win/Drosera.vcproj/VERSION: Added.
674         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
675
676 2007-12-06  Adam Roben  <aroben@apple.com>
677
678         Explicitly turn on the Mac font ascent hack on Windows
679
680         This keeps our font metrics matching those from Mac.
681
682         Reviewed by Hyatt.
683
684         * DumpRenderTree/win/DumpRenderTree.cpp:
685         (main):
686
687 2007-12-06  Anders Carlsson  <andersca@apple.com>
688
689         Rename main.c to main.cpp here too.
690         
691         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
692
693 2007-12-06  Sam Weinig  <sam@webkit.org>
694
695         Rubber stamped by Geoff.
696
697         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
698
699 2007-12-06  Darin Adler  <darin@apple.com>
700
701         * Scripts/do-webcore-rename: Some more renaming plans.
702
703 2007-12-06  Anders Carlsson  <andersca@apple.com>
704
705         Restore implementation of testGetIntIdentifier that was accidentally
706         removed somehow (possibly when I made PluginObject be a cpp file).
707         
708         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
709         (pluginInvoke):
710
711 2007-12-05  Anders Carlsson  <andersca@apple.com>
712
713         Make the entry points extern "C".
714         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
715         
716 2007-12-05  Anders Carlsson  <andersca@apple.com>
717
718         C++ warning fixes.
719         
720         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
721         (NPP_New):
722         (NPP_Destroy):
723         (NPP_SetWindow):
724         (NPP_NewStream):
725         (NPP_HandleEvent):
726         (NPP_URLNotify):
727         (NPP_GetValue):
728
729 2007-12-05  Anders Carlsson  <andersca@apple.com>
730
731         Add the .cpp files to the TestNetscapePlugIn target.
732
733         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
734
735 2007-12-05  Anders Carlsson  <andersca@apple.com>
736
737         Reviewed by Geoff.
738         
739         Rename the TestNetscapePlugIn .c files to be .cpp.
740
741         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
742         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
743         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
744         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
745         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
746         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
747         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
748         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
749
750 2007-12-05  Adam Roben  <aroben@apple.com>
751
752         Fix case of keypresses from the Windows implementation of eventSender.keyDown
753
754         This fixes several regression tests.
755
756         Reviewed by Alice.
757
758         * DumpRenderTree/win/EventSender.cpp:
759         (keyDownCallback): Virtual keycodes for ASCII characters are always
760         uppercase, so we need to check the case of the original character
761         passed in to eventSender.keyDown.
762
763 2007-12-05  Adam Roben  <aroben@apple.com>
764
765         Learn from Tim's mistakes
766
767         * DumpRenderTree/win/DumpRenderTree.cpp:
768         (runTest): Reset the authorAndUserStylesEnabled preference for each
769         test.
770
771 2007-12-05  Alp Toker  <alp@atoker.com>
772
773         Reviewed by Mark Rowe.
774
775         Initialize GTK+ and WebKit so the tests can run.
776
777         Reorganize the headers a little.
778
779         * DumpRenderTree/gtk/DumpRenderTree.cpp:
780         (main):
781
782 2007-12-04  Anders Carlsson  <andersca@apple.com>
783
784         Remove IWebScriptScope include.
785         
786         * Drosera/win/DebuggerDocumentPlatform.cpp:
787
788 2007-12-04  Sam Weinig  <sam@webkit.org>
789
790         Rubber stamped by Mark Rowe.
791
792         Define CF as platform for mac and revert r28409
793
794         * DumpRenderTree/DumpRenderTree.h:
795         * DumpRenderTree/mac/DumpRenderTreeMac.h:
796
797 2007-12-04  Sam Weinig  <sam@webkit.org>
798
799         Define CF as platform for windows.
800
801         Reviewed by Adam Roben.
802
803         * DumpRenderTree/win/DumpRenderTreeWin.h:
804
805 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
806
807         Reviewed by Adam and Darin.
808
809         - Removed a needless BSTR cleanup.
810
811         * Drosera/win/DebuggerDocumentPlatform.cpp:
812         (DebuggerDocument::getPlatformCurrentFunctionStack):
813
814 2007-11-27  Adam Roben  <aroben@apple.com>
815
816         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
817
818         Reviewed by Maciej.
819
820         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
821         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
822
823 2007-12-04  Alp Toker  <alp@atoker.com>
824
825         Prospective Win DRT build fix.
826
827         * DumpRenderTree/DumpRenderTree.h:
828
829 2007-12-04  Alp Toker  <alp@atoker.com>
830
831         Fix a clobbered copyright header.
832
833         * DumpRenderTree/gtk/DumpRenderTree.cpp:
834
835 2007-12-04  Xan Lopez  <xan@gnome.org>
836
837         Reviewed by Alp Toker.
838
839         http://bugs.webkit.org/show_bug.cgi?id=15561
840         GTK port needs DumpRenderTree implementation
841
842         Start work on the GTK+ DRT.
843
844         This does not work yet, and there are a few lingering style issues
845         (nothing major) but this patch has been stuck in the bug tracker for
846         too long already.
847
848         * DumpRenderTree/DumpRenderTree.h:
849         * DumpRenderTree/gtk: Added.
850         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
851         (autocorrectURL):
852         (shouldLogFrameLoadDelegates):
853         (dumpFrameScrollPosition):
854         (displayWebView):
855         (appendString):
856         (dumpFramesAsText):
857         (dumpRenderTreeAsText):
858         (dump):
859         (runTest):
860         (main):
861         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
862         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
863         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
864         (GCController::collect):
865         (GCController::collectOnAlternateThread):
866         (GCController::getJSObjectCount):
867         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
868         (LayoutTestController::~LayoutTestController):
869         (LayoutTestController::addDisallowedURL):
870         (LayoutTestController::clearBackForwardList):
871         (LayoutTestController::copyDecodedHostName):
872         (LayoutTestController::copyEncodedHostName):
873         (LayoutTestController::display):
874         (LayoutTestController::keepWebHistory):
875         (LayoutTestController::notifyDone):
876         (LayoutTestController::queueBackNavigation):
877         (LayoutTestController::queueForwardNavigation):
878         (LayoutTestController::queueLoad):
879         (LayoutTestController::queueReload):
880         (LayoutTestController::queueScript):
881         (LayoutTestController::setAcceptsEditing):
882         (LayoutTestController::setCustomPolicyDelegate):
883         (LayoutTestController::setMainFrameIsFirstResponder):
884         (LayoutTestController::setTabKeyCyclesThroughElements):
885         (LayoutTestController::setUseDashboardCompatibilityMode):
886         (LayoutTestController::setUserStyleSheetEnabled):
887         (LayoutTestController::setUserStyleSheetLocation):
888         (LayoutTestController::setWindowIsKey):
889         (LayoutTestController::setWaitToDump):
890         (LayoutTestController::windowCount):
891         (LayoutTestController::setPrivateBrowsingEnabled):
892         (LayoutTestController::setAuthorAndUserStylesEnabled):
893         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
894         (JSStringCopyUTF8CString):
895         (LoadItem::invoke):
896         (ReloadItem::invoke):
897         (ScriptItem::invoke):
898         (BackForwardItem::invoke):
899
900 2007-12-03  Sam Weinig  <sam@webkit.org>
901
902         Move JavaScriptCore thread testing code to pthread specific directory
903         and remove the dependance on CoreFoundation by using WTF::HashSet.
904
905         Reviewed by Geoff and Oliver.
906
907         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
908         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
909         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
910         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
911         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
912         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
913         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
914         * DumpRenderTree/pthreads: Added.
915         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
916         (javaScriptThreads):
917         (runJavaScriptThread):
918         (startJavaScriptThreads):
919         (stopJavaScriptThreads):
920
921 2007-12-03  Andrew Bonventre  <andybons@google.com>
922
923         Reviewed by Darin Adler.
924
925         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
926         Symbol lookup menu broken in debugger view
927
928         * Drosera/debugger.js: Fixed javascript error where document property
929         should have been used instead of contentDocument in switchFunction that
930         was breaking the select symbol dropdown menu.  This is because
931         window.frames will return a Window object and not a frame object like
932         the author was originally expecting.
933
934 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
935
936         Reviewed by Adam.
937
938         - <rdar://5618942> Drosera: Console window does not process everything
939         correctly.
940         - <rdar://5619005> Drosera: could be sped up by moving the 
941         WebScriptScope stuff into the WebScriptCallFrame.
942         - Now the console can correctly process objects and does not receive
943         notifications from JavaScriptCore about the JavaScript in Drosera's
944         own process.
945
946         * Drosera/win/DebuggerDocumentPlatform.cpp:
947         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
948         (DebuggerDocument::platformValueForScopeVariableNamed):
949
950 2007-12-03  Stephanie  <slewis@apple.com>
951
952         Reviewed by Darin.
953
954         Check to see if we are building a debug root
955
956         * Scripts/check-for-global-initializers: 
957
958 2007-12-03  Dan Bernstein  <mitz@apple.com>
959
960         Reviewed by Darin Adler.
961
962         - added a testGetIntIdentifier() method to TestNetscapePlugIn
963
964         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
965         (pluginInvoke):
966
967 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
968
969         Reviewed by Oliver.
970
971         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
972         in a more fine-grained manner than eventSender.keyDown().
973
974         * DumpRenderTree/win/EventSender.cpp:
975         (getConstantCallback):
976         (dispatchMessageCallback):
977
978 2007-12-02  Darin Adler  <darin@apple.com>
979
980         * Scripts/do-webcore-rename: More planned renaming.
981
982 2007-12-02  Sam Weinig  <sam@webkit.org>
983
984         Rubber stamped by Anders.
985
986         Use [NSURL absoluteString] instead of [NSURL description] in order to get
987         more uniform results cross platform.
988
989         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
990         (-[NSURL _drt_descriptionSuitableForTestResult]):
991
992 2007-12-02  Sam Weinig  <sam@webkit.org>
993
994         Rubber stamped by Niko.
995
996         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
997
998         * DumpRenderTree/win/DumpRenderTree.cpp:
999         * DumpRenderTree/win/DumpRenderTree.vcproj:
1000         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
1001         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
1002         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
1003         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
1004
1005 2007-12-01  Alp Toker  <alp@atoker.com>
1006
1007         Reviewed by Adam Roben.
1008
1009         Make use of the newly introduced webkit.h convenience header.
1010
1011         * GtkLauncher/main.c:
1012
1013 2007-12-01  Adam Treat  <treat@kde.org>
1014
1015         Reviewed by Simon.
1016
1017         * Check to see if the directory exists and exit if not.
1018
1019         * DumpRenderTree/qt/main.cpp:
1020         (main):
1021
1022 2007-12-01  Adam Treat  <treat@kde.org>
1023
1024         Reviewed by Simon.
1025
1026         * Don't hide symbols when in Debug mode
1027         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
1028
1029
1030         * DumpRenderTree/qt/main.cpp:
1031         (messageHandler):
1032
1033 2007-11-30  Alp Toker  <alp@atoker.com>
1034
1035         Reviewed by Adam Roben.
1036
1037         http://bugs.webkit.org/show_bug.cgi?id=15691
1038         [GTK] Public API does not follow GTK+ conventions
1039
1040         Refactor the WebKit/GTK+ public API. Changes:
1041           WebKitPage -> WebKitWebView
1042           WebKitFrame -> WebKitWebFrame
1043
1044         Public API source and header names have been updated to mirror the API
1045         changes.
1046
1047         The API is now kept in WebKit/gtk/WebView to match other ports in the
1048         same class such as Mac and Win.
1049
1050         * GtkLauncher/main.c:
1051         (activate_uri_entry_cb):
1052         (link_hover_cb):
1053         (title_change_cb):
1054         (progress_change_cb):
1055         (go_back_cb):
1056         (go_forward_cb):
1057         (create_browser):
1058         (main):
1059
1060 2007-11-30  Adam Roben  <aroben@apple.com>
1061
1062         Hopefully the final build fix
1063
1064         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
1065         pull in WTF's assertion/logging functions.
1066
1067 2007-11-30  Adam Roben  <aroben@apple.com>
1068
1069         Another build fix
1070
1071         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
1072         WebKit.lib.
1073
1074 2007-11-30  Adam Roben  <aroben@apple.com>
1075
1076         Debug build fix
1077
1078         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
1079         configuration.
1080         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
1081         projects.
1082         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
1083         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
1084         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
1085
1086 2007-11-30  Sam Weinig  <sam@webkit.org>
1087
1088         Reviewed by Adam Roben.
1089
1090         Fix drawSelectionRect to actually draw the selection rect.
1091
1092         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1093         (drawSelectionRect):
1094
1095 2007-11-30  Darin Adler  <darin@apple.com>
1096
1097         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
1098
1099 2007-11-30  Darin Adler  <darin@apple.com>
1100
1101         * Scripts/do-webcore-rename: Get ready for some future renaming.
1102
1103 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1104
1105         Reviewed by Adam.
1106
1107         - Removed some unnecessary functions and changed an unused return type. 
1108
1109         * Drosera/win/DebuggerClient.cpp:
1110         (registerConsoleClass):
1111         * Drosera/win/DebuggerClient.h:
1112         * Drosera/win/Drosera.cpp:
1113         (registerDroseraClass):
1114
1115 2007-11-28  Alp Toker  <alp@atoker.com>
1116
1117         Reviewed by Timothy Hatcher.
1118
1119         http://bugs.webkit.org/show_bug.cgi?id=16174
1120         [GTK] Use "URI" not "URL" in public API
1121
1122         Replace use of the term "URL" with "URI" in public headers,
1123         documentation and some internal code to match GLib/GTK+ convention.
1124
1125         This is now mentioned in the API guidelines:
1126           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
1127
1128         * GtkLauncher/main.c:
1129         (activate_uri_entry_cb):
1130         (title_change_cb):
1131         (create_toolbar):
1132         (main):
1133
1134 2007-11-29  Anders Carlsson  <andersca@apple.com>
1135
1136         Reviewed by Sam.
1137
1138         <rdar://problem/5230478>
1139         FrameLoadDelegate callbacks are not dumped in DRT.
1140         
1141         * DumpRenderTree/win/DumpRenderTree.cpp:
1142         (shouldLogFrameLoadDelegates):
1143         (runTest):
1144         (main):
1145         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1146         (BSTRtoString):
1147         (descriptionSuitableForTestResult):
1148         (FrameLoadDelegate::QueryInterface):
1149         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1150         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1151         (FrameLoadDelegate::didCommitLoadForFrame):
1152         (FrameLoadDelegate::didFinishLoadForFrame):
1153         (FrameLoadDelegate::willCloseFrame):
1154         (FrameLoadDelegate::didClearWindowObject):
1155         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1156         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1157         * DumpRenderTree/win/FrameLoaderDelegate.h:
1158         (FrameLoadDelegate::windowScriptObjectAvailable):
1159         (FrameLoadDelegate::didFirstLayoutInFrame):
1160
1161 2007-11-29  Sam Weinig  <sam@webkit.org>
1162
1163         Reviewed by Anders.
1164
1165         Add database quota UIDelegates methods to DRT UIDelegate.
1166
1167         * DumpRenderTree/mac/UIDelegate.mm:
1168         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1169         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
1170
1171 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1172
1173         Reviewed by Sam.
1174
1175         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
1176         dying and vice versa.
1177         - This fix will allow Drosera and Safari to reconnect if either of them
1178         closes correctly, but does not fix the case where one of them dies
1179         silently.
1180
1181         * Drosera/win/ServerConnection.cpp:
1182         (ServerConnection::attemptToCreateServerConnection): Added a safety
1183         check, because it's possilbe to try to connect to a server that's dying.
1184         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
1185         the server has died.
1186         * Drosera/win/ServerConnection.h: Added the new function and removed
1187         an unnecessary member.
1188
1189 2007-11-29  Anders Carlsson  <andersca@apple.com>
1190
1191         * DumpRenderTree/win/DumpRenderTree.vcproj:
1192         Add shlwapi.lib to all configurations.
1193
1194 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1195
1196         - Build fix.  Added additional includes for VS Express to the Release
1197         project.
1198
1199         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1200
1201 2007-11-29  Anders Carlsson  <andersca@apple.com>
1202
1203         Reviewed by Adam.
1204
1205         <rdar://problem/5132005>
1206         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
1207         
1208         * DumpRenderTree/win/DumpRenderTree.vcproj:
1209         Add shlwapi.lib
1210         
1211         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1212         (LayoutTestController::setUserStyleSheetEnabled):
1213         Implement this.
1214         
1215         (appendComponentToPath):
1216         New method which wraps the Win32 API PathAppend.
1217         
1218         (followShortcuts):
1219         New method which checks if a file points to a shortcut and
1220         follows the shortcut.
1221         
1222         (resolveCygwinPath):
1223         New method that takes a cygwin unix-style path and returns the Win32 path.
1224         
1225         (cfStringRefToWString):
1226         
1227         (LayoutTestController::setUserStyleSheetLocation):
1228         Implement this.
1229
1230 2007-11-29  Alice Liu  <alice.liu@apple.com>
1231
1232         Reviewed by Adam.
1233
1234         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
1235
1236         * DumpRenderTree/win/EventSender.cpp:
1237         (keyDownCallback):
1238         uppercase letters were being sent as lowercase letters without the shift key down.
1239
1240 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1241
1242         - Windows build fix. VS express needs some love.
1243
1244         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1245
1246 2007-11-28  Darin Adler  <darin@apple.com>
1247
1248         Reviewed by Adam Roben.
1249
1250         * DumpRenderTree/mac/EventSendingController.mm:
1251         (-[EventSendingController keyDown:withModifiers:]):
1252         Send capital letters through as lowercase letters with the shift key down
1253         rather than sending them as if they were highly unusual "capital letter keys".
1254
1255         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1256         where you need to update results and more tests are failing than before.
1257
1258 2007-11-28  Anders Carlsson  <andersca@apple.com>
1259
1260         Reviewed by Darin.
1261
1262         <rdar://problem/5132001>
1263         contextClick is not implemented in DRT on Windows.
1264         
1265         * DumpRenderTree/win/EventSender.cpp:
1266         (contextClickCallback):
1267         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1268         by a WM_RBUTTONUP message.
1269         
1270         * DumpRenderTree/win/UIDelegate.cpp:
1271         (UIDelegate::hasCustomMenuImplementation):
1272         (UIDelegate::trackCustomPopupMenu):
1273         * DumpRenderTree/win/UIDelegate.h:
1274         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1275         menu from being shown (and causing the DRT to hang).
1276
1277 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1278
1279         Reviewed by Darin.
1280
1281         Fix DumpRenderTree ObjC bug comparing strings.
1282
1283         * DumpRenderTree/mac/ObjCController.m:
1284         (-[ObjCController identityIsEqual::]): Compare strings with string
1285         equality instead of identiy equality.
1286
1287 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1288
1289         Reviewed by Sam.
1290
1291         Reset the authorAndUserStylesEnabled preference
1292         back to YES for each test. Fixes the broken tests.
1293
1294         * DumpRenderTree/mac/DumpRenderTree.mm:
1295         (resetWebViewToConsistentStateBeforeTesting):
1296
1297 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1298
1299         Reviewed by Adam.
1300
1301         - Drosera now displays the console window, although it cannot currently
1302         process JavaScript.
1303
1304         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1305         (registerConsoleClass): Implemented.
1306         (consoleWndProc): Implemented.
1307         (DebuggerClient::onSize): Implemented.
1308         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1309         new window.
1310         * Drosera/win/DebuggerClient.h: Added needed method and members for 
1311         creating and maintaining a new window.
1312         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1313         lines of code to more appropriate places.
1314         (Drosera::handleCommand):
1315         (Drosera::initUI):
1316         (Drosera::onSize):
1317         (Drosera::attach):
1318
1319 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1320
1321         Reviewed by Dave Hyatt.
1322
1323         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1324         
1325         Add support for disabling author and user styles for testing.
1326
1327         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1328         * DumpRenderTree/LayoutTestController.cpp:
1329         (setAuthorAndUserStylesEnabledCallback):
1330         (LayoutTestController::staticFunctions):
1331         * DumpRenderTree/LayoutTestController.h:
1332         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1333         (LayoutTestController::setAuthorAndUserStylesEnabled):
1334         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1335         (LayoutTestController::setAuthorAndUserStylesEnabled):
1336
1337 2007-11-26  Dan Bernstein  <mitz@apple.com>
1338
1339         - Tiger build fix.
1340
1341         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1342
1343 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1344
1345         Reviewed by Maciej.
1346
1347         - Implemented displaying variables for Drosera on Win.
1348
1349         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1350         that retrieve variables to not hold onto the return value since it's
1351         not returned.  Also changed to use the new signatures of the retrieval
1352         functions.
1353         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1354         (DebuggerDocument::platformValueForScopeVariableNamed):
1355         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1356         (droseraWndProc):
1357
1358 2007-11-26  Sam Weinig  <sam@webkit.org>
1359
1360         Cleanup names of painting and repainting functions.
1361
1362         Reviewed by Adam Roben.
1363
1364         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1365         (drawSelectionRect): was drawSelectionRectIntoContext.
1366         (dumpWebViewAsPixelsAndCompareWithExpected):
1367         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1368         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1369         (paintWebView): was drawWebViewIntoContext.
1370         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1371
1372 2007-11-26  Sam Weinig  <sam@webkit.org>
1373
1374         Reviewed by Dan Bernstein.
1375
1376         - Leopard build fix
1377
1378         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1379
1380 2007-11-26  Sam Weinig  <sam@webkit.org>
1381
1382         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1383         Use shared PixelDumpSupport for Mac DRT
1384
1385         Reviewed by Adam Roben.
1386
1387         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1388         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1389         * DumpRenderTree/cg/ImageDiffCG.cpp:
1390         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1391         (drawSelectionRectIntoContext):
1392         (dumpWebViewAsPixelsAndCompareWithExpected):
1393         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1394         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1395         * DumpRenderTree/mac/DumpRenderTree.mm:
1396         (dump):
1397         * DumpRenderTree/mac/ImageDiff.m: Removed.
1398         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1399         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1400         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1401         (setDefaultColorProfileToRGB):
1402         (getBitmapContextFromWebView):
1403         (drawWebViewIntoContext):
1404         (repaintWithVerticalSweep):
1405         (repaintWithHorizontalSweep):
1406         (getSelectionRect):
1407         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1408
1409 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1410
1411         Bug 16052: prepare-ChangeLog doesn't report deleted files
1412         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1413
1414         Reviewed by Sam.
1415
1416         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1417
1418 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1419
1420         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1421         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1422
1423         Reviewed by Adam.
1424
1425         Roll functionality of merge-changelog into resolve-ChangeLogs
1426         script.  The script now checks for ChangeLog.rej and
1427         ChangeLog.orig files first.  If it finds them, it uses the
1428         ChangeLog.rej file as a patch (in old contextual diff format) to
1429         apply with --fuzz=3.
1430
1431         * Scripts/merge-changelog: Removed.
1432         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1433
1434 2007-11-25  Sam Weinig  <sam@webkit.org>
1435
1436         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1437
1438         Reviewed by Mark Rowe.
1439
1440         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1441         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1442         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1443         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1444         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1445
1446 2007-11-25  Sam Weinig  <sam@webkit.org>
1447
1448         Convert DumpRenderTree to ues .xcconfig files.
1449
1450         Reviewed by Mark Rowe.
1451
1452         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1453         * DumpRenderTree/mac/Configurations: Added.
1454         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1455         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1456         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1457
1458 2007-11-25  Sam Weinig  <sam@webkit.org>
1459
1460         Add ForwardingHeaders to wtf for DumpRenderTree.
1461
1462         Reviewed by Mark Rowe.
1463
1464         * DumpRenderTree/DumpRenderTree.h:
1465         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1466         * DumpRenderTree/ForwardingHeaders: Added.
1467         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1468         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1469         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1470         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1471         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1472         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1473         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1474         * DumpRenderTree/LayoutTestController.cpp:
1475         * DumpRenderTree/WorkQueue.cpp:
1476         * DumpRenderTree/mac/DumpRenderTree.mm:
1477         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1478         * DumpRenderTree/mac/JavaScriptThreading.cpp:
1479         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1480         * DumpRenderTree/mac/ObjCController.m:
1481         * DumpRenderTree/mac/UIDelegate.mm:
1482         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1483
1484 2007-11-25  Adam Roben  <aroben@apple.com>
1485
1486         Fix some test failures caused by r28019
1487
1488         Now that stdout is in binary mode, we need to always use printf
1489         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1490         the output.
1491
1492         Reviewed by Sam.
1493
1494         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1495         printf.
1496         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1497         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1498         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1499         (UIDelegate::webViewAddMessageToConsole):
1500
1501 2007-11-25  Adam Roben  <aroben@apple.com>
1502
1503         Set the font smoothing preference in DRT
1504
1505         This makes the pixel results on Windows closer to the Mac results.
1506
1507         Reviewed by Mitz.
1508
1509         * DumpRenderTree/win/DumpRenderTree.cpp:
1510         (initializePreferences):
1511
1512 2007-11-25  Adam Roben  <aroben@apple.com>
1513
1514         Port ImageDiff to CG and C++
1515
1516         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1517         <rdar://5071708>
1518
1519         Reviewed by Sam.
1520
1521         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1522         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1523         (main):
1524         (createImageFromStdin):
1525         (compareImages):
1526         (getDifferenceBitmap):
1527         (computePercentageDifferent):
1528         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1529
1530 2007-11-25  Adam Roben  <aroben@apple.com>
1531
1532         Fix image diff link generation on Windows
1533
1534         Reviewed by Sam.
1535
1536         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1537         to toURL.
1538
1539 2007-11-25  Adam Roben  <aroben@apple.com>
1540
1541         Implement pixel dumping in Windows DRT
1542
1543         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1544         <rdar://5071708>
1545
1546         Reviewed by Sam.
1547
1548         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1549         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1550         Content-Length header.
1551         (getMD5HashStringForBitmap):
1552         (dumpWebViewAsPixelsAndCompareWithExpected):
1553         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1554         * DumpRenderTree/win/DumpRenderTree.cpp:
1555         (dump): Do a pixel dump if requested.
1556         (main): Parse pixel test options.
1557         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1558         the cg/ subdirectory to the include path.
1559         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1560         available in a header or import library, so we have to go through this
1561         LoadLibrary/GetProcAddress dance to use them.
1562         (cryptDLL):
1563         (init):
1564         (update):
1565         (final):
1566         (MD5_Init):
1567         (MD5_Update):
1568         (MD5_Final):
1569         * DumpRenderTree/win/MD5.h: Added.
1570         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1571         moved up to the top level to share it with Mac eventually.
1572         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1573         (getBitmapContextFromWebView): Forces the WebView to paint using a
1574         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1575
1576 2007-11-25  Adam Roben  <aroben@apple.com>
1577
1578         Clean up Windows DRT's option parsing a little bit
1579
1580         Reviewed by Sam.
1581
1582         * DumpRenderTree/win/DumpRenderTree.cpp:
1583         (main): Put non-option arguments into a Vector.
1584
1585 2007-11-25  Adam Roben  <aroben@apple.com>
1586
1587         Make Windows DRT stop changing LF into CRLF
1588
1589         Reviewed by Sam.
1590
1591         * DumpRenderTree/win/DumpRenderTree.cpp:
1592         (main): Put stdout in binary mode.
1593         * Scripts/run-webkit-tests: Remove the CRLF hack.
1594
1595 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1596
1597         Removed empty directory.
1598
1599         * Scripts/resources: Removed.
1600
1601 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1602
1603         Fix bisect-builds to work with recent WebKit nightly builds.
1604
1605         Reviewed by Dan.
1606
1607         * Scripts/bisect-builds: Check for the 
1608         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1609         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1610         to WebKit.app/Contents/Resources.
1611
1612 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1613
1614         Reviewed by Maciej.
1615
1616         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1617         not closed (affects digg.com)
1618
1619         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1620         one after finishing with a test to avoid having its delayed onload handler firing when
1621         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1622         but it helps somewhat.
1623
1624 2007-11-22  Mark Rowe  <mrowe@apple.com>
1625
1626         Reviewed by Alp Toker.
1627
1628         Fix build-webkit to propagate make's exit status if it fails.
1629
1630         * Scripts/webkitdirs.pm:
1631
1632 2007-11-22  Dan Bernstein  <mitz@apple.com>
1633
1634         Reviewed by Mark Rowe.
1635
1636         - fix crash when running pixel tests
1637
1638         * DumpRenderTree/mac/DumpRenderTree.mm:
1639         (dumpRenderTree): Parse the command line options before setting up the
1640         environment so that we know if we need to set up the pixel dump
1641         machinery.
1642
1643 2007-11-21  Eric Seidel  <eric@webkit.org>
1644
1645         Speculative build fix for Tiger.
1646
1647         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1648
1649 2007-11-21  Eric Seidel  <eric@webkit.org>
1650
1651         Reviewed by Tim Hatcher.
1652
1653         Break out more of DumpRenderTree.mm into individual files
1654
1655         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1656         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1657         (checkedMalloc):
1658         (checkedRealloc):
1659         (makeLargeMallocFailSilently):
1660         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1661         * DumpRenderTree/mac/DumpRenderTree.mm:
1662         (crashHandler):
1663         (dump):
1664         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1665         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1666         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1667         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1668         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1669         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1670         (javaScriptThreads):
1671         (runJavaScriptThread):
1672         (startJavaScriptThreads):
1673         (stopJavaScriptThreads):
1674         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1675         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1676         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1677         (restoreColorSpace):
1678         (setDefaultColorProfileToRGB):
1679         (initializeColorSpaceAndScreeBufferForPixelTests):
1680         (md5HashStringForBitmap):
1681         (dumpWebViewAsPixelsAndCompareWithExpected):
1682
1683 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1684
1685         Move install-unix-extras to wx directory as it seems only to be used by that 
1686         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
1687         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1688         have install-unix-extras install into WebKitLibraries as per
1689         convention.
1690         
1691         Reviewed by Mark Rowe.
1692
1693         * Scripts/install-unix-extras: Removed.
1694         * wx/build-wxwebkit:
1695         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1696
1697 2007-11-21  Eric Seidel  <eric@webkit.org>
1698
1699         Reviewed by Adam.
1700
1701         More refactoring for greater code readability
1702
1703         * DumpRenderTree/mac/DumpRenderTree.mm:
1704         (initializeGlobalsFromCommandLineOptions):
1705         (initializeColorSpaceAndScreeBufferForPixelTests):
1706         (addTestPluginsToPluginSearchPath):
1707         (useLongRunningServerMode):
1708         (runTestingServerLoop):
1709         (prepareConsistentTestingEnvironment):
1710         (dumpRenderTree):
1711         (main):
1712         (dumpFramesAsText):
1713         (dumpBackForwardListForWebView):
1714         (sizeWebViewForCurrentTest):
1715         (methodNameStringForFailedTest):
1716         (dumpBackForwardListForAllWindows):
1717         (dumpWebViewAsPixelsAndCompareWithExpected):
1718         (invalidateAnyPreviousWaitToDumpWatchdog):
1719         (dump):
1720         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1721         * DumpRenderTree/mac/UIDelegate.mm:
1722         (-[UIDelegate webView:createWebViewWithRequest:]):
1723
1724 2007-11-21  Eric Seidel  <eric@webkit.org>
1725
1726         Reviewed by Tim Hatcher.
1727
1728         Abstract more of DRT into static methods
1729
1730         * DumpRenderTree/mac/DumpRenderTree.mm:
1731         (setDefaultsToConsistentValuesForTesting):
1732         (setupSignalHandlers):
1733         (allocateGlobalControllers):
1734         (releaseAndZero):
1735         (releaseGlobalControllers):
1736         (dumpRenderTree):
1737         (shouldLogFrameLoadDelegates):
1738         (createCFURLFromPathOrURL):
1739         (resetWebViewToConsistentStateBeforeTesting):
1740         (runTest):
1741
1742 2007-11-21  Eric Seidel  <eric@webkit.org>
1743
1744         Reviewed by Tim Hatcher.
1745
1746         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1747
1748         * DumpRenderTree/DumpRenderTree.h:
1749         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1750         * DumpRenderTree/mac/DumpRenderTree.mm:
1751         (dumpRenderTree):
1752         (dump):
1753         (runTest):
1754         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1755         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1756         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1757         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1758         (-[DumpRenderTreePasteboard declareType:owner:]):
1759         (+[LocalPasteboard alloc]):
1760         (-[LocalPasteboard init]):
1761         (-[LocalPasteboard dealloc]):
1762         (-[LocalPasteboard name]):
1763         (-[LocalPasteboard releaseGlobally]):
1764         (-[LocalPasteboard declareTypes:owner:]):
1765         (-[LocalPasteboard addTypes:owner:]):
1766         (-[LocalPasteboard changeCount]):
1767         (-[LocalPasteboard types]):
1768         (-[LocalPasteboard availableTypeFromArray:]):
1769         (-[LocalPasteboard setData:forType:]):
1770         (-[LocalPasteboard dataForType:]):
1771         (-[LocalPasteboard setPropertyList:forType:]):
1772         (-[LocalPasteboard setString:forType:]):
1773         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1774         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1775         (+[DumpRenderTreeWindow allWindows]):
1776         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1777         (-[DumpRenderTreeWindow dealloc]):
1778         (-[DumpRenderTreeWindow isKeyWindow]):
1779         (-[DumpRenderTreeWindow keyDown:]):
1780
1781 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1782
1783         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1784         it indiscriminately copies any headers inside JavaScriptCore,
1785         which includes Tiger ICU headers. 
1786
1787         * wx/build-wxwebkit:
1788         Don't run WebCore/move-js-headers.sh any longer.
1789
1790 2007-11-20  Adam Treat  <treat@kde.org>
1791
1792         Reviewed by David Kilzer.
1793
1794         * Prepend git branch name to $baseProductDir
1795
1796         * Scripts/VCSUtils.pm:
1797         * Scripts/webkitdirs.pm:
1798
1799 2007-11-20  Mark Rowe  <mrowe@apple.com>
1800
1801         Reviewed by Simon Hausmann.
1802
1803         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1804         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1805         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1806         built product and generated Makefile's are removed.
1807
1808 2007-11-19  Alp Toker  <alp@atoker.com>
1809
1810         Reviewed by Mark Rowe.
1811
1812         http://bugs.webkit.org/show_bug.cgi?id=16040
1813         [GTK] GtkLauncher should be written in C
1814
1815         Port GtkLauncher to plain C.
1816
1817         Use a more conventional GTK+ coding style.
1818
1819         Use a toolbar instead of menus.
1820
1821         Various signature fixes and cleanups.
1822
1823         Add a license header. Assume all previous modifications were copyright
1824         assigned to Apple Inc. by default.
1825
1826         * GtkLauncher/GtkLauncher.pro:
1827         * GtkLauncher/main.c: Added.
1828         (activate_url_entry_cb):
1829         (update_title):
1830         (link_hover_cb):
1831         (title_change_cb):
1832         (progress_change_cb):
1833         (destroy_cb):
1834         (go_back_cb):
1835         (go_forward_cb):
1836         (create_browser):
1837         (create_statusbar):
1838         (create_toolbar):
1839         (create_window):
1840         (main):
1841         * GtkLauncher/main.cpp: Removed.
1842
1843 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1844
1845         Build script fixes to ensure they do the right thing for the 
1846         wx port, and update build-wxwebkit to reflect the way the
1847         build scripts now work.
1848
1849         Reviewed by Adam.
1850
1851         * Scripts/build-testkjs:
1852         * Scripts/build-webkit:
1853         * Scripts/run-javascriptcore-tests:
1854         * Scripts/webkitdirs.pm:
1855         * wx/build-wxwebkit:
1856
1857 2007-11-18  Eric Seidel  <eric@webkit.org>
1858
1859         Reviewed by Anders.
1860
1861         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1862
1863         * Scripts/run-javascriptcore-tests:
1864
1865 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1866
1867         Reviewed by Adam Roben.
1868
1869         Make run-webkit-tests work with Windows debug build.
1870
1871         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1872         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1873         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1874         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1875         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1876
1877 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1878
1879         Add wxWebKit sample and build script, and integrate it with 
1880         build-webkit. Also make build-webkit --clean work for all
1881         ports.
1882
1883         Reviewed by Darin Adler.
1884
1885         * Scripts/build-webkit:
1886         * Scripts/webkitdirs.pm:
1887         * wx: Added.
1888         * wx/browser: Added.
1889         * wx/browser/browser.bkl: Added.
1890         * wx/browser/browser.cpp: Added.
1891         * wx/build-wxwebkit: Added.
1892
1893 2007-11-17  Adam Roben  <aroben@apple.com>
1894
1895         Make it easy to run Safari in the debugger on Windows
1896
1897         I've added a new script, debug-safari, which launches Safari in the
1898         debugger. On OS X it just calls gdb-safari.
1899
1900         Reviewed by Mark Rowe.
1901
1902         * FindSafari/FindSafari.cpp:
1903         (_tmain): Added a /debugger flag, which in combination with
1904         /printSafariLauncher will print a script that launches Safari in the
1905         debugger.
1906         * Scripts/debug-safari: Added.
1907         * Scripts/run-safari: Changed to call runSafari().
1908         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1909         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1910         first argument along to FindSafari.
1911         * Scripts/webkitdirs.pm:
1912         (sub runSafari): Added.
1913
1914 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1915
1916         Reviewed by Adam Roben.
1917
1918         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
1919
1920 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1921
1922         Reviewed by David Kilzer.
1923
1924         The git config command was renamed to repo-config at some point. This
1925         change tries git config and then git repo-config if the first fails.
1926
1927         * Scripts/prepare-ChangeLog:
1928         (gitConfig):
1929
1930 2007-11-16  Dan Bernstein  <mitz@apple.com>
1931
1932         Reviewed by Darin Adler and Sam Weinig.
1933
1934         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1935
1936         * DumpRenderTree/win/EventSender.cpp:
1937         (keyDownCallback): For characters that cannot be entered on the active
1938         keyboard layout, send a WM_CHAR message with the character along with
1939         a WM_KEYDOWN message with a virtual key code of 255.
1940
1941 2007-11-16  Mark Rowe  <mrowe@apple.com>
1942
1943         Reviewed by Tim Hatcher.
1944
1945         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1946
1947         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1948         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1949
1950 2007-11-15  Adam Roben  <aroben@apple.com>
1951
1952         Make run-safari actually work on Windows
1953
1954         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1955         chdir call.
1956
1957 2007-11-14  Adam Roben  <aroben@apple.com>
1958
1959         Updates to Safari launching now that 3.0.4 is released
1960
1961         Reviewed by Sam.
1962
1963         * FindSafari/FindSafari.cpp:
1964         (getWebViewCLSID): Use version-independent ProgID.
1965         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1966
1967 2007-11-14  Anders Carlsson  <andersca@apple.com>
1968
1969         Reviewed by Adam.
1970
1971         <rdar://problem/5309081>
1972         In DRT, "plugin.logDestroy = true" not working on Windows.
1973         
1974         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1975         (NPP_Destroy):
1976
1977 2007-11-14  Eric Seidel  <eric@webkit.org>
1978
1979         Reviewed by Sam.
1980
1981         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1982
1983 2007-11-14  Anders Carlsson  <andersca@apple.com>
1984
1985         Reviewed by Adam.
1986
1987         <rdar://problem/5141186>
1988         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1989         
1990         Implement setWindowIsKey.
1991         
1992         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1993         (LayoutTestController::setWindowIsKey):
1994
1995 2007-11-13  Sam Weinig  <sam@webkit.org>
1996
1997         Reviewed by Adam Roben.
1998
1999         Fix for <rdar://problem/5382579>
2000         http/tests/security/cross-frame-access-put.html reports large 
2001         negative numbers for screenLeft and screenTop (Mac reports "0")
2002
2003         * DumpRenderTree/win/UIDelegate.cpp:
2004         (UIDelegate::UIDelegate): Initialize the RECT.
2005         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
2006         (UIDelegate::webViewFrame): ditto.
2007         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
2008
2009 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
2010
2011         Reviewed by Adam.
2012
2013         - Make Drosera show source, source URLs, and function stack on Windows,
2014         and some minor fixes.
2015
2016         * Drosera/DebuggerDocument.cpp: Force source to always update display.
2017         (DebuggerDocument::updateFileSource):
2018         * Drosera/debugger.js: Force source to always update display.
2019         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
2020         menu controls.
2021         (DebuggerClient::resume):
2022         (DebuggerClient::pause):
2023         (DebuggerClient::stepInto):
2024         (DebuggerClient::stepOver):
2025         (DebuggerClient::stepOut):
2026         (DebuggerClient::showConsole):
2027         (DebuggerClient::closeCurrentFile):
2028         * Drosera/win/DebuggerClient.h: Ditto.
2029         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
2030         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
2031         removed two bugs.  1) caller could be in a bad state when asked to
2032         assign into it. 2) BSTRs were not created correctly.
2033         (DebuggerDocument::getPlatformCurrentFunctionStack):
2034         * Drosera/win/Drosera.cpp: Hook up the menu controls.
2035         (droseraWndProc):
2036         (handleCommand):
2037         (Drosera::resume):
2038         (Drosera::pause):
2039         (Drosera::stepInto):
2040         (Drosera::stepOver):
2041         (Drosera::stepOut):
2042         (Drosera::showConsole):
2043         (Drosera::closeCurrentFile):
2044         * Drosera/win/Drosera.h: Hook up the menu controls.
2045         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
2046         functions, added a null check, and fixed another bug where caller could
2047         be in a bad state when asked to assign into it.
2048         (ServerConnection::didLoadMainResourceForDataSource):
2049         (ServerConnection::getCallerFrame):
2050         * Drosera/win/ServerConnection.h: Safety first.
2051
2052 2007-11-13  Dan Bernstein  <mitz@apple.com>
2053
2054         Reviewed by Darin Adler.
2055
2056         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
2057           DumpRenderTree --pixel-tests renders each test twice
2058
2059         * DumpRenderTree/mac/DumpRenderTree.mm:
2060         (dumpRenderTree): Removed the --paint option because the painting code
2061         is always exercised as a result of
2062         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
2063         calling -displayIfNeeded.
2064         (dump): Changed to always grab the image from the window since the view
2065         is always displayed.
2066         (runTest):
2067         (displayWebView):
2068         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
2069         because it always paints.
2070
2071 2007-11-12  Antti Koivisto  <antti@apple.com>
2072
2073         Reviewed by Adele.
2074         
2075         Add support for http media tests
2076
2077         * Scripts/run-webkit-tests:
2078
2079 2007-11-12  Sam Weinig  <sam@webkit.org>
2080
2081         Reviewed by Adam Roben.
2082
2083         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
2084
2085         * DumpRenderTree/win/DumpRenderTree.cpp:
2086         (runTest):
2087         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2088         (LayoutTestController::setPrivateBrowsingEnabled):
2089
2090 2007-11-12  Adam Roben  <aroben@apple.com>
2091
2092         * Scripts/update-webkit-localizable-strings: Changed to only scan the
2093         mac and win subdirectories.
2094
2095 2007-11-11  Adam Roben  <aroben@apple.com>
2096
2097         Fix <rdar://5133816> keepWebHistory is not implemented
2098
2099         Fixes fast/history/clicked-link-is-visited.html.
2100
2101         Reviewed by Darin.
2102
2103         * DumpRenderTree/win/DumpRenderTree.cpp:
2104         (runTest): Clear the optionalSharedHistory.
2105         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2106         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
2107
2108 2007-11-10  Sam Weinig  <sam@webkit.org>
2109
2110         Reviewed by Tim Hatcher.
2111
2112         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
2113         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
2114         is turned on)
2115
2116         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
2117
2118         Added test: http/tests/security/cross-frame-access-private-browsing.html
2119
2120         * DumpRenderTree/LayoutTestController.cpp:
2121         (setPrivateBrowsingEnabledCallback):
2122         (LayoutTestController::staticFunctions):
2123         * DumpRenderTree/LayoutTestController.h:
2124         * DumpRenderTree/mac/DumpRenderTree.mm:
2125         (runTest): Default to private browsing disabled.
2126         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2127         (LayoutTestController::setPrivateBrowsingEnabled):
2128         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2129         (LayoutTestController::setPrivateBrowsingEnabled):
2130
2131 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2132
2133         Reviewed by Adam.
2134
2135         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
2136         WebCore's!
2137
2138         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2139         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
2140         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2141         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2142         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
2143         * Drosera/win/Drosera.cpp:
2144         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2145
2146 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2147
2148         Reviewed by Sam.
2149
2150         - Use the new IWebFrame [local] function signature and get the shared
2151         server correctly.
2152
2153         * Drosera/win/DebuggerClient.cpp:
2154         (DebuggerClient::didFinishLoadForFrame):
2155         * Drosera/win/ServerConnection.cpp:
2156         (ServerConnection::attemptToCreateServerConnection):
2157
2158 2007-11-07  Dan Bernstein  <mitz@apple.com>
2159
2160         Reviewed by Darin Adler.
2161
2162         - add an option to run-webkit-tests to ignore pixel test failures where
2163           all pixels differ by no more than a specified threshold
2164
2165         * DumpRenderTree/mac/ImageDiff.m:
2166         (main):
2167         (compareImages):
2168         (computePercentageDifferent):
2169         * Scripts/run-webkit-tests:
2170
2171 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2172
2173         Reviewed by Lars.
2174
2175         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
2176
2177         * DumpRenderTree/qt/DumpRenderTree.cpp:
2178
2179 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2180
2181         Reviewed by Lars.
2182
2183         Reworked the QWebSettings API.
2184         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
2185
2186         * DumpRenderTree/qt/DumpRenderTree.cpp:
2187
2188 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2189
2190         Reviewed by Lars.
2191
2192         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
2193
2194         * DumpRenderTree/qt/jsobjects.cpp:
2195
2196 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2197
2198         Reviewed by Lars Knoll <lars@trolltech.com>.
2199
2200         Add a QWebPage::frameCreated() signal and fix DRT
2201         
2202         The removal of createFrame in QWebPage broke the re-implementation
2203         in DumpRenderTree. Instead emit a frameCreated() signal and
2204         connect to it in DumpRenderTree.
2205         
2206
2207         * DumpRenderTree/qt/DumpRenderTree.cpp:
2208         (WebCore::WebPage::WebPage):
2209         (WebCore::DumpRenderTree::dump):
2210         (WebCore::DumpRenderTree::connectFrame):
2211         * DumpRenderTree/qt/DumpRenderTree.h:
2212
2213 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2214
2215         Reviewed by Lars Knoll <lars@trolltech.com>.
2216
2217         Moved all the event handlers from QWebFrame into QWebPage.
2218         
2219         This cleans up the public API and allows us to remove the
2220         HackWebFrame hack in DumpRenderTree.
2221         
2222
2223         * DumpRenderTree/qt/jsobjects.cpp:
2224         (EventSender::mouseDown):
2225         (EventSender::mouseUp):
2226         (EventSender::mouseMoveTo):
2227
2228 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2229
2230         Reviewed by Mark.
2231
2232         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
2233         to prevent the default implementation from popping up messageboxes.
2234
2235         * DumpRenderTree/qt/DumpRenderTree.cpp:
2236         (WebCore::WebPage::javaScriptConfirm):
2237         (WebCore::WebPage::javaScriptPrompt):
2238
2239 2007-11-06  Eric Seidel  <eric@webkit.org>
2240
2241         * Scripts/build-testkjs: build fix... too many $$
2242
2243 2007-11-06  Eric Seidel  <eric@webkit.org>
2244
2245         Reviewed by Mark Rowe.
2246
2247         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
2248
2249 2007-11-05  Adam Roben  <aroben@apple.com>
2250
2251         Add support on Windows for WEBKIT_TESTFONTS
2252
2253         This environment variable lets you specify where the fonts to be used
2254         by DumpRenderTree reside. The Qt port is already using this, so I'm
2255         just following their lead.
2256
2257         Reviewed by Darin.
2258
2259         * DumpRenderTree/win/DumpRenderTree.cpp:
2260         (exePath): Refactored code out of initialize().
2261         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2262         DumpRenderTree.resources.
2263         (initialize): Use the new fontsPath function.
2264         (main): Use the new exePath function.
2265         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2266         variable to DRT, like Qt does.
2267
2268 2007-11-05  Mark Rowe  <mrowe@apple.com>
2269
2270         Rubber-stamped by Alp Toker.
2271
2272         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2273
2274         * GtkLauncher/main.cpp:
2275         (goToURLBarText):
2276         (main):
2277
2278 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2279
2280         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2281         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2282
2283         Reviewed by Timothy.
2284
2285         Restrict the range of nightly builds used by the bisect-builds script
2286         based on the version of Safari and the version of Mac OS X being used.
2287
2288         Mac OS X 10.4: Safari 2.0: r11976 or newer
2289         Mac OS X 10.4: Safari 3.0: r19992 or newer
2290
2291         Mac OS X 10.5: Safari 2.0: r19594 or newer
2292         Mac OS X 10.5: Safari 3.0: r25124 or newer
2293
2294         * Scripts/bisect-builds:
2295         (findMacOSXVersion): Added.
2296         (makeNightlyList): Added argument to provide version of Mac OS X.
2297         Restrict range of nightly builds based on Safari and Mac OS X versions.
2298
2299 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2300
2301         Reviewed by Maciej.
2302
2303         - This patch involves several changes, all of them were noticed that
2304         they were needed by the work being done in WebKit to get Drosera and
2305         WebKit working together on Windows.
2306         - The changes are:
2307         1) Added a debugger console for output messages.
2308         2) Drosera now listens for the WebKit server (before, the server would
2309         have to be running before Drosera was started.)
2310         3) Fixed a bug where the WebView started out as 0x0 pixels.
2311         4) Fixed a bug when there is no scope.
2312         5) Added the HTML, JS, and CSS to the project file to make them easy to
2313         find.
2314         6) Made the ServerConnection functions virtual.
2315
2316         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2317         for the WebKit server.
2318         (DebuggerClient::DebuggerClient):
2319         (DebuggerClient::~DebuggerClient):
2320         (DebuggerClient::didFinishLoadForFrame):
2321         (DebuggerClient::serverConnected):
2322         (DebuggerClient::attemptToCreateServerConnection):
2323         * Drosera/win/DebuggerClient.h: Ditto.
2324         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2325         scope.
2326         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2327         (DebuggerDocument::platformValueForScopeVariableNamed):
2328         * Drosera/win/Drosera.cpp:
2329         (_tWinMain): Added a console in debug for output messages.
2330         (Drosera::Drosera): Listen for server.
2331         (Drosera::initUI): The server now Initializes COM.
2332         (Drosera::serverConnected): Part of the listening for the server.
2333         (Drosera::attemptToCreateServerConnection): Ditto.
2334         * Drosera/win/Drosera.h: New interface for listening for the server.
2335         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2336         files to the VS project.
2337         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2338         connection.
2339         (ServerConnection::ServerConnection):
2340         (ServerConnection::attemptToCreateServerConnection):
2341         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2342         methods.
2343         (ServerConnection::serverConnected):
2344
2345 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2346
2347         Reviewed by Maciej.
2348
2349         http://bugs.webkit.org/show_bug.cgi?id=15832
2350         fast/dom/gc-10.html crashes when run alone
2351
2352         Check for !done before using objects that can be already deallocated.
2353
2354         * DumpRenderTree/mac/EditingDelegate.mm:
2355         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2356         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2357         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2358         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2359         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2360         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2361         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2362         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2363         (-[EditingDelegate webViewDidBeginEditing:]):
2364         (-[EditingDelegate webViewDidChange:]):
2365         (-[EditingDelegate webViewDidEndEditing:]):
2366         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2367         (-[EditingDelegate webViewDidChangeSelection:]):
2368         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2369         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2370         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2371         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2372         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2373         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2374         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2375         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2376         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2377         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2378         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2379         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2380         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2381         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2382         (-[FrameLoadDelegate webView:willCloseFrame:]):
2383         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2384         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2385         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2386         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2387         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2388         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2389         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2390         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2391         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2392
2393 2007-11-04  Mark Rowe  <mrowe@apple.com>
2394
2395         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2396         warnings that would otherwise be suppressed due to it being a system header.
2397
2398         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2399
2400 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2401
2402         Rubber stamped by Adam.
2403         
2404         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2405
2406         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2407
2408 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2409
2410         Sort files(...); sections of Xcode project files.
2411
2412         Rubber-stamped by Darin.
2413
2414         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2415         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2416         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2417         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2418
2419 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2420
2421         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2422
2423         Reviewed by Darin.
2424
2425         * Scripts/sort-Xcode-project-file: Added.
2426
2427 2007-11-02  Darin Adler  <darin@apple.com>
2428
2429         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2430
2431 2007-11-02  Darin Adler  <darin@apple.com>
2432
2433         Reviewed by Maciej.
2434
2435         * Scripts/run-sunspider: Pass the "--base" option through.
2436
2437         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2438         the real script do that. Default configuration to Release to match run-sunspider
2439         so we don't end up building Debug just to compare results.
2440
2441 2007-11-01  Adam Roben  <aroben@apple.com>
2442
2443         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2444
2445         Reviewed by Sam.
2446
2447         * Scripts/commit-log-editor: Show all the directories beneath the
2448         source root, instead of just the last one.
2449
2450 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2451
2452         Reviewed by Adam Roben.
2453
2454         Print out an error message when the Windows build fails
2455         and provide guidance on how to find out what went wrong.
2456
2457         * Scripts/build-webkit:
2458         * Scripts/webkitdirs.pm:
2459
2460 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2461
2462         Rubber-stamped by Adam Roben.
2463
2464         Rolled out r27326 - debug CRT seems to cause no problems after all.
2465
2466         * DumpRenderTree/win/DumpRenderTree.vcproj:
2467
2468 2007-10-31  Adam Roben  <aroben@apple.com>
2469
2470         Switch the Debug configuration to using the non-debug CRT
2471
2472         This matches WebKit.
2473
2474         Reviewed by Steve.
2475
2476         * DumpRenderTree/win/DumpRenderTree.vcproj:
2477
2478 2007-10-31  Antti Koivisto  <antti@apple.com>
2479
2480         Reviewed by bdash.
2481         
2482         Disable media tests when doing leak checking on Tiger.
2483         They crash in QuickTime (rdar://problem/5537157).
2484
2485         * Scripts/run-webkit-tests:
2486
2487 2007-10-29  Antti Koivisto  <antti@apple.com>
2488
2489         Reviewed by Maciej.
2490         
2491         Build media support by default on OSX only.
2492
2493         * Scripts/build-webkit:
2494
2495 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2496
2497         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2498         get caught by the pre-commit hooks.
2499
2500 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2501
2502         Reviewed by Adam.
2503
2504         - This is a collection of relatively unrelated changes and cleanups
2505         to Drosera to prepare it for interacting with WebKit.  A lot of these
2506         changes are just correcting mistakes, for example removing included
2507         headers that are no longer needed.
2508
2509         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2510         this will be needed by the DebuggerClient.
2511         (DebuggerDocument::server):
2512         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2513         * Drosera/win/DebuggerClient.cpp: 
2514         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2515         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2516         (DebuggerClient::createWebViewWithRequest): Added comment about its
2517         purpose. 
2518         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2519         declarations.
2520         (DebuggerClient::webViewLoaded): Moved.
2521         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2522         file, since this was the only place it was used.
2523         (cfStringToBSTR):
2524         * Drosera/win/Drosera.h: Cleaned up the includes.
2525         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2526         * Drosera/win/HelperFunctions.h: Removed.
2527
2528 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2529
2530         Reviewed by Adam.
2531
2532         - Small cleanup in the ServerConnection class.
2533
2534         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2535         and added an include.
2536         (ServerConnection::currentFrame):
2537         (ServerConnection::getCallerFrame):
2538         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2539         made a pointer into a COMPtr, and cleaned up the includes.
2540
2541 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2542
2543         Reviewed by John Sullivan.
2544         
2545         - Place the Localizable.strings file in mac or win directories
2546           if that location exists.
2547         - Also look for UI_STRING in .c files.
2548
2549         * Scripts/extract-localizable-strings:
2550
2551 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2552
2553         Reviewed by Adam.
2554
2555         - Set the eol-style to native and made all the line endings the same
2556         so that I avoid messy diffs that show eol changes.
2557
2558         * Drosera/win/ServerConnection.cpp:
2559         (ServerConnection::didParseSource):
2560         (ServerConnection::didEnterCallFrame):
2561         (ServerConnection::willExecuteStatement):
2562         (ServerConnection::willLeaveCallFrame):
2563         (ServerConnection::exceptionWasRaised):
2564
2565 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2566
2567         Reviewed by Adam.
2568
2569         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2570         functionality that could not have existed previously without the new
2571         interfaces.
2572         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2573         from a BSTR to a JSValueRef.
2574         (DebuggerDocument::platformEvaluateScript): Implemented.
2575         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2576         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2577         Implemented.
2578         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2579         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2580         * Drosera/win/ServerConnection.cpp: Added a helper function.
2581         (ServerConnection::getCallerFrame):
2582         * Drosera/win/ServerConnection.h: Added a helper function.
2583
2584 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2585
2586         updated reviewers for my previous changelog.
2587
2588 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2589         Reviewed by Maciej and Adam and Geoff.
2590
2591         - Minor mac-side improvements including moving a function to a more
2592         appropriate location, fixing a warning, and correctly checking
2593         exceptions.
2594
2595         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2596         (DebuggerDocument::willExecuteStatement):
2597         (DebuggerDocument::didEnterCallFrame):
2598         (DebuggerDocument::willLeaveCallFrame):
2599         (DebuggerDocument::windowScriptObjectAvailable):
2600         (DebuggerDocument::callFunctionOnObject):
2601         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2602         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2603         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2604         because it doesn't require the ServerConnection at all.
2605         (NSStringCreateWithJSStringRef): Made an argument const.
2606         (JSValueRefCreateWithNSString): Made an argument const.
2607         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2608         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2609         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2610         * Drosera/mac/ServerConnection.mm: Ditto.
2611         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2612
2613 2007-10-29  Sam Weinig  <sam@webkit.org>
2614
2615         Reviewed by Adam Roben.
2616
2617         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2618
2619         * DumpRenderTree/LayoutTestController.cpp:
2620         (LayoutTestController::LayoutTestController):
2621         (getGlobalFlagCallback):
2622         (setGlobalFlagCallback):
2623         (LayoutTestController::getJSClass):
2624         (LayoutTestController::staticValues):
2625         * DumpRenderTree/LayoutTestController.h:
2626         (LayoutTestController::globalFlag):
2627         (LayoutTestController::setGlobalFlag):
2628
2629 2007-10-29  Darin Adler  <darin@apple.com>
2630
2631         Reviewed by Maciej.
2632
2633         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2634         resolution instead of its default.
2635
2636 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2637
2638         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2639
2640         Reviewed by Mark Rowe.
2641
2642         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2643         was successfully resolved, but this would not show any status because the change had
2644         already been cached in the index using "git add".  The solution is to add an optional
2645         second argument to showStatus() which adds the "--cached" switch to the command.
2646
2647         * Scripts/resolve-ChangeLogs:
2648         (showStatus):
2649
2650 2007-10-28  Eric Seidel  <eric@webkit.org>
2651
2652         Reviewed by Maciej and Geoff, in unison.
2653
2654         * Scripts/run-webkit-tests: remove broken --svg option
2655
2656 2007-10-28  Darin Adler  <darin@apple.com>
2657
2658         Reviewed by Adam.
2659
2660         * Scripts/run-sunspider: Default to "Release" configuration rather than
2661         defaulting to the last configuration used as other scripts do. This can
2662         still be overriden on the command line with "--debug" if there's some
2663         reason to do so. Also fix a typo.
2664
2665         * Scripts/sunspider-compare-results: Fix a typo.
2666
2667 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2668
2669         Reviewed by Adam.
2670
2671         - Implemented the WebScriptDebugListener functions now that the
2672         WebScriptDebugServer exists
2673
2674         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2675         functions.
2676         (ServerConnection::currentFrame):
2677         (ServerConnection::didLoadMainResourceForDataSource):
2678         (ServerConnection::didParseSource):
2679         (ServerConnection::failedToParseSource):
2680         (ServerConnection::didEnterCallFrame):
2681         (ServerConnection::willExecuteStatement):
2682         (ServerConnection::willLeaveCallFrame):
2683         (ServerConnection::exceptionWasRaised):
2684         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2685         members arguments list.
2686
2687 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2688
2689         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2690         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2691
2692         Reviewed by Darin.
2693
2694         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2695         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2696         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2697         file.  Note that it may also be used as a stand-alone script.
2698
2699         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2700         * Scripts/resolve-ChangeLogs: Added.
2701         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2702
2703 2007-10-26  Mark Rowe  <mrowe@apple.com>
2704
2705         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2706         to the Qt port on the assumption that it was an implementation of the cross-platform
2707         LayoutTestController class.  It is not, so it did not need to be changed.
2708
2709         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2710
2711 2007-10-25  Mark Rowe  <mrowe@apple.com>
2712
2713         Reviewed by Maciej.
2714
2715         Fix builds with code coverage enabled.
2716
2717         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2718
2719 2007-10-25  Darin Adler  <darin@apple.com>
2720
2721         Reviewed by Mark Rowe.
2722
2723         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2724         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2725
2726 2007-10-25  Stephanie  <slewis@apple.com>
2727
2728         build Fix
2729
2730         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2731
2732 2007-10-25  Stephanie  <slewis@apple.com>
2733
2734         Reviewed by Mark Rowe, Adam Roben.
2735
2736         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2737
2738         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
2739
2740 2007-10-25  Alice Liu  <alice.liu@apple.com>
2741
2742         Reviewed by Adam.
2743
2744         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2745
2746         Moving destructor into platform-specific files
2747         * DumpRenderTree/LayoutTestController.cpp:
2748         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2749         (LayoutTestController::~LayoutTestController):
2750         * DumpRenderTree/qt/jsobjects.cpp:
2751         (LayoutTestController::~LayoutTestController):
2752
2753         LayoutTestController wasn't being destroyed
2754         * DumpRenderTree/win/DumpRenderTree.cpp:
2755         (runTest):
2756
2757         Added declspec
2758         * DumpRenderTree/win/EditingDelegate.h:
2759
2760         Reset certain values on the webview (or related delegate) that might 
2761         have changed while running a test
2762         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2763         (LayoutTestController::~LayoutTestController):
2764
2765 2007-10-25  Adam Roben  <aroben@apple.com>
2766
2767         Make sunspider-compare-results work with relative paths
2768
2769         Reviewed by Sam.
2770
2771         * Scripts/sunspider-compare-results: Convert arguments to absolute
2772         paths before we chdir.
2773
2774 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2775
2776         Reviewed by Sam.
2777
2778         - Implemented server calls now the WebScriptDebugServer exists.
2779         - Also removed no longer needed call to initialize CG.
2780
2781         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2782         automatically now.
2783         (_tWinMain):
2784         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2785         (ServerConnection::ServerConnection):
2786         (ServerConnection::~ServerConnection):
2787         (ServerConnection::pause):
2788         (ServerConnection::resume):
2789         (ServerConnection::stepInto):
2790         (ServerConnection::applicationTerminating):
2791         (ServerConnection::serverConnectionDidDie):
2792         * Drosera/win/ServerConnection.h: Now uses the COM class.
2793
2794 2007-10-24  George Staikos  <staikos@kde.org>
2795
2796         Unbreak Qt build.
2797
2798         * Scripts/build-webkit:
2799
2800 2007-10-24  Adam Roben  <aroben@apple.com>
2801
2802         Remove now-unnecessary call to InitializeCoreGraphics
2803
2804         WebKit takes care of this now.
2805
2806         Reviewed by Ada.
2807
2808         * DumpRenderTree/win/DumpRenderTree.cpp:
2809         (initialize):
2810
2811 2007-10-24  Adam Roben  <aroben@apple.com>
2812
2813         Use WebTextRenderer in DRT
2814
2815         Reviewed by Ada.
2816
2817         * DumpRenderTree/win/DumpRenderTree.cpp:
2818         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2819
2820 2007-10-24  Sven Herzberg  <sven@imendio.com>
2821
2822         Reviewed by Mark Rowe.
2823
2824         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2825         Bug 15614: [GTK] qmake based backends don't build on OS X
2826
2827         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2828         GTK backend on a Mac
2829         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2830         isDarwin() to make it reusable in other places (like the workaround-
2831         for-prebuilt-qmake in build-webkit)
2832
2833 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2834
2835         Refurbish update-webkit script.
2836
2837         Reviewed by Adam.
2838
2839         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2840         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2841         multi-argument version of system() for flexibility and security.  Check for existence
2842         of Internal directory using -d test instead of -x.
2843
2844 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2845
2846         Minor clean-up of prepare-ChangeLog script.
2847
2848         Reviewed by Adam.
2849
2850         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2851         of a string.  Use multi-argument versions of open() and system() for flexibility and
2852         security.
2853
2854 2007-10-24  Alice Liu  <alice.liu@apple.com>
2855
2856         Reviewed by Oliver.
2857
2858         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2859
2860         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
2861         replay the saved events when we're still processing the mousedown that starts the drag
2862         * DumpRenderTree/win/EventSender.cpp:
2863         (doMouseMove):
2864         * DumpRenderTree/win/UIDelegate.cpp:
2865         (UIDelegate::doDragDrop):
2866
2867 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2868
2869         Reviewed by Sam, Steve and Darin.
2870
2871         - Stubbed out the WebScriptDebugListener functionality in the Server
2872         Connection class to prepare it for receiving those callbacks.
2873         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2874         and the ServerConnection to not need to be initialized with a server
2875         name, since that is not the way we connect to the WebKit server. 
2876
2877         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2878         no exception.  Now it only loggs when there is an exception
2879         (DebuggerDocument::willExecuteStatement):
2880         (DebuggerDocument::didEnterCallFrame):
2881         (DebuggerDocument::willLeaveCallFrame):
2882         (DebuggerDocument::windowScriptObjectAvailable):
2883         (DebuggerDocument::callFunctionOnObject):
2884         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2885         to be instantiated with a server's name.
2886         (DebuggerClient::DebuggerClient):
2887         (DebuggerClient::didFinishLoadForFrame):
2888         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2889         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2890         a server name.
2891         (Drosera::init):
2892         (Drosera::initServer):
2893         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2894         instantiated with a server's name.
2895         * Drosera/win/ServerConnection.cpp: 
2896         (ServerConnection::ServerConnection): No longer needs a server name
2897         (ServerConnection::~ServerConnection): Only release the global context
2898         if there is one.
2899         (ServerConnection::serverConnectionDidDie): Stub for
2900         IWebScriptDebugListener
2901         (ServerConnection::QueryInterface): ditto
2902         (ServerConnection::AddRef): ditto
2903         (ServerConnection::Release): ditto
2904         (ServerConnection::didLoadMainResourceForDataSource): ditto
2905         (ServerConnection::didParseSource): ditto
2906         (ServerConnection::failedToParseSource): ditto
2907         (ServerConnection::didEnterCallFrame): ditto
2908         (ServerConnection::willExecuteStatement): ditto
2909         (ServerConnection::willLeaveCallFrame): ditto
2910         (ServerConnection::exceptionWasRaised): ditto
2911         * Drosera/win/ServerConnection.h: Stubbed out the
2912         IWebScriptDebugListener functions, and this class no longer needs to be
2913         instantiated with a server name.
2914
2915 2007-10-24  Lars Knoll  <lars@trolltech.com>
2916
2917         Reviewed by Simon.
2918
2919         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2920
2921         * DumpRenderTree/qt/jsobjects.h:
2922
2923 2007-10-24  Lars Knoll  <lars@trolltech.com>
2924
2925         Reviewed by Simon.
2926
2927         add another command.
2928
2929         * DumpRenderTree/qt/jsobjects.cpp:
2930         (TextInputController::doCommand):
2931
2932 2007-10-24  Lars Knoll  <lars@trolltech.com>
2933
2934         Reviewed by Simon.
2935
2936         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2937
2938         * DumpRenderTree/qt/jsobjects.cpp:
2939         (EventSender::keyDown):
2940         * DumpRenderTree/qt/jsobjects.h:
2941
2942 2007-10-24  Lars Knoll  <lars@trolltech.com>
2943
2944         Reviewed by Simon.
2945
2946         implement eventSender.keyDown().
2947
2948         * DumpRenderTree/qt/jsobjects.cpp:
2949         (EventSender::keyDown):
2950
2951 2007-10-24  Lars Knoll  <lars@trolltech.com>
2952
2953         Reviewed by Simon.
2954
2955         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2956
2957         * DumpRenderTree/qt/DumpRenderTree.cpp:
2958         (WebCore::DumpRenderTree::DumpRenderTree):
2959         (WebCore::DumpRenderTree::initJSObjects):
2960         * DumpRenderTree/qt/jsobjects.cpp:
2961         (TextInputController::doCommand):
2962
2963 2007-10-24  Lars Knoll  <lars@trolltech.com>
2964
2965         Reviewed by Simon.
2966
2967         first bit of implementation for the textinputcontroller.
2968
2969         * DumpRenderTree/qt/DumpRenderTree.cpp:
2970         (WebCore::DumpRenderTree::DumpRenderTree):
2971         * DumpRenderTree/qt/DumpRenderTree.h:
2972         * DumpRenderTree/qt/jsobjects.cpp:
2973         (TextInputController::TextInputController):
2974         (TextInputController::doCommand):
2975         * DumpRenderTree/qt/jsobjects.h:
2976
2977 2007-10-24  Lars Knoll  <lars@trolltech.com>
2978
2979         Reviewed by Simon.
2980
2981         make the man webpage believe it has focus, so the editing tests work correctly.
2982
2983         * DumpRenderTree/qt/DumpRenderTree.cpp:
2984         (WebCore::DumpRenderTree::DumpRenderTree):
2985
2986 2007-10-24  Lars Knoll  <lars@trolltech.com>
2987
2988         Reviewed by Simon.
2989
2990         implement layoutTestController.dumpEditingCallbacks() correctly.
2991
2992         * DumpRenderTree/qt/DumpRenderTree.cpp:
2993         (WebCore::DumpRenderTree::DumpRenderTree):
2994         * DumpRenderTree/qt/jsobjects.cpp:
2995         (LayoutTestController::reset):
2996         (LayoutTestController::dumpEditingCallbacks):
2997
2998 2007-10-24  Lars Knoll  <lars@trolltech.com>
2999
3000         Reviewed by Simon.
3001
3002         Implement support for testing editing.
3003
3004         * DumpRenderTree/qt/DumpRenderTree.cpp:
3005         (WebCore::DumpRenderTree::DumpRenderTree):
3006
3007 2007-10-23  Sam Weinig  <sam@webkit.org>
3008
3009         Check for null BSTR that can be passed to the UIDelegate methods
3010         from javascript null and undefined.  Fixes a failing test case on
3011         Windows (fast/dom/Window/alert-undefined.html)
3012
3013         Reviewed by Eric Seidel.
3014
3015         * DumpRenderTree/win/UIDelegate.cpp:
3016         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3017         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3018         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3019         (UIDelegate::webViewAddMessageToConsole):
3020
3021 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3022
3023         Reviewed by Darin.
3024         
3025         Don't print a massive pile of setenvs from tools that automatically build testkjs.
3026
3027         * Scripts/build-testkjs:
3028
3029 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3030
3031         Reviewed by Darin.
3032
3033         - add wrapper that finds the right copy of testkjs
3034         
3035         * Scripts/sunspider-compare-results: Added.
3036
3037 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
3038
3039         Reviewed by Sam.
3040
3041         - After talking with Steve I now see that the WebKit server must be
3042         running for DCOM to create the distributed objects, which makes sense
3043         and currently WebKit only allows one instance to be running at a time
3044         which avoids accidentally connecting to the wrong server
3045         - In light of this I have removed the code for the attach box and
3046         NotificationServer and known server names, since they are all extranious
3047         now.
3048
3049         * Drosera/win/Drosera.cpp: Removed notification classes and known server
3050         names.
3051         (_tWinMain): Uses init instead of initUI.
3052         (droseraWndProc): No longer creats an attach dialog box.
3053         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
3054         it's not manditory to call init before doing COM stuff.
3055         (Drosera::init): calls initUI and will call attach when the
3056         functionality exists. 
3057         (Drosera::initUI): Has changed very little.
3058         (Drosera::attach): Changed the signature to reflect that we no longer
3059         need the dictionary of known server names.
3060         * Drosera/win/Drosera.h: Removed notification classes and known server
3061         names.  Also renamed and moved some functions.
3062         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
3063         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
3064         headers to the resources folder. 
3065         * Drosera/win/resource.h: Removed the Attach box.
3066
3067 2007-10-22  Adam Roben  <aroben@apple.com>
3068
3069         Windows build fix
3070
3071         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
3072
3073 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
3074
3075         - Removed a leak that was fixed.
3076
3077         * Scripts/run-webkit-tests:
3078
3079 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3080
3081         Reviewed by Darin.
3082
3083         - Changed the Client so that the DebuggerDocument now own the
3084         ServerConnection.  This simplifies ownership and cleanup. 
3085
3086         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
3087         ServerConnection.
3088         (DebuggerClient::initWithServerName):
3089         (DebuggerClient::didFinishLoadForFrame):
3090         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
3091         ServerConnection.
3092         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
3093         until after we have a server which we are attached to.
3094         (Drosera::initUI):
3095         (Drosera::attach):
3096         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
3097         out previously.
3098
3099 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3100
3101         Reviewed by Nikolas.
3102
3103         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
3104
3105         * Scripts/run-javascriptcore-tests:
3106
3107 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3108
3109         Reviewed by Nikolas.
3110
3111         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
3112
3113         * Scripts/build-drosera:
3114         * Scripts/build-dumprendertree:
3115         * Scripts/build-testkjs:
3116         * Scripts/build-webkit:
3117         * Scripts/run-javascriptcore-tests:
3118         * Scripts/run-sunspider:
3119         * Scripts/run-webkit-tests:
3120         * Scripts/webkitdirs.pm:
3121
3122 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
3123
3124         Reviewed by Mark Rowe.
3125         
3126         Fix for local database support after r26879
3127         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
3128
3129         * Scripts/build-webkit:
3130
3131 2007-10-22  Holger Freyther  <zecke@selfish.org>
3132
3133         Reviewed by Simon Hausmann <hausmann@kde.org>.
3134
3135         - Do not build testkjs as an application bundle. This is
3136         needed for run-javascriptcore-tests on OSX.
3137         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
3138         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
3139         as we do not have -rpath on OSX.
3140
3141         * DumpRenderTree/qt/DumpRenderTree.pro:
3142         * Scripts/run-webkit-tests:
3143
3144 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3145
3146         Reviewed by aroben.
3147
3148         Fix support for Signed-off-by detection in prepare-ChangeLog
3149         --git-commit. The Signed-off-by tag does not appear in the header
3150         but usually at the end.
3151
3152         * Scripts/prepare-ChangeLog:
3153
3154 2007-10-21  Mark Rowe  <mrowe@apple.com>
3155
3156         Reviewed by Eric.
3157
3158         Fix run-javascriptcore-tests for Gtk.
3159
3160         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
3161
3162 2007-10-20  Eric Seidel  <eric@webkit.org>
3163
3164         Reviewed by aroben.
3165
3166         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
3167
3168 2007-10-20  Eric Seidel  <eric@webkit.org>
3169
3170         Reviewed by darin.
3171         
3172         Add improved argument handling to run-sunspider, including
3173         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
3174         Also re-factor code into subroutines
3175
3176         * Scripts/build-dumprendertree: removed bogus comments
3177         * Scripts/build-testkjs: Added.
3178         * Scripts/run-javascriptcore-tests: use build-testkjs
3179         * Scripts/run-sunspider: improved argument handling, abstraction
3180         * Scripts/run-webkit-tests: improved abstraction
3181
3182 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
3183
3184         Not reviewed, Windows build fix.
3185
3186         * DumpRenderTree/win/EventSender.cpp:
3187         (keyDownCallback):
3188
3189 2007-10-20  Darin Adler  <darin@apple.com>
3190
3191         Reviewed by Tim Hatcher.
3192
3193         - http://bugs.webkit.org/show_bug.cgi?id=15544
3194           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
3195           not rely on Apple-specific key codes
3196
3197         * DumpRenderTree/mac/EventSendingController.mm:
3198         (-[EventSendingController keyDown:withModifiers:]):
3199         Added named key "rightArrow". Later we could have a whole table of these.
3200         Also tweaked modifiers code a little.
3201
3202         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
3203
3204 2007-10-19  Darin Adler  <darin@apple.com>
3205
3206         Reviewed by Eric.
3207
3208         - http://bugs.webkit.org/show_bug.cgi?id=15566
3209           possible fix for leak seen in DumpRenderTree
3210
3211         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
3212         Delete the item if it's not put on the queue, since the caller has
3213         no way of knowing that. Would be better to have the parameter type
3214         be auto_ptr to express the fact that we take ownership.
3215
3216         - unrelated change
3217
3218         * Drosera/mac/main.m: Add missing include.
3219
3220 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3221
3222         Reviewed by Adam.
3223
3224         - This change should be identical but for some reason was not working
3225         on my machine.
3226
3227         * Scripts/prepare-ChangeLog:
3228
3229 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3230
3231         Reviewed by Oliver and Tim.
3232
3233         - Made use of RetainPtr to avoid retain and release issues and moved the
3234         log function to DebuggerDocumentPlatform, which seems to be a more
3235         logical place for it to live.
3236         - Also moved knownServers from the ServerConnection to
3237         DebuggerApplication to match the Windows code and because it makes sense
3238         that a connection knows its own server but not all of them.
3239
3240         * Drosera/mac/DebuggerClient.h: Moved the log function to
3241           DebuggerDocumentPlatform.
3242         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
3243           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
3244           call for the server name up from the ServerConnection class.
3245         (-[DebuggerClient dealloc]):
3246         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
3247           for the server name up from the ServerConnection.
3248         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
3249         (DebuggerDocument::platformPause):
3250         (DebuggerDocument::platformResume):
3251         (DebuggerDocument::platformStepInto):
3252         (DebuggerDocument::platformEvaluateScript):
3253         (DebuggerDocument::getPlatformCurrentFunctionStack):
3254         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3255         (DebuggerDocument::platformValueForScopeVariableNamed):
3256         (DebuggerDocument::platformLog): Log directly from here. No need to call
3257           DebuggerClient.
3258         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
3259           way I see it, a ServerConnection should only know about its connection
3260           and the group of all possible servers should be kept by the
3261           application.
3262         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
3263           currentServerName, it makes sense that the connection should know that
3264           name.
3265         (-[ServerConnection currentServerName]):
3266
3267 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3268
3269         Reviewed by Adam.
3270
3271         - Integrated changes from mac drosera.  Recently I've encapsulated
3272         out the server connection object from the rest of Drosera because
3273         it is very platform dependent right now and RPC is not implemented on
3274         windows.  This functionality, of communicating with the WebKit server
3275         is the next area I will be focusing on in Windows.
3276
3277         - Other changes and cleanup were made to organize the code and add notes
3278         on which parts still need work.  Also some mac code is added and
3279         commented out, to act as pseudocode for the logic of those parts.
3280
3281         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
3282           pointer.
3283         * Drosera/config.h: Added whitespace.
3284         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
3285           these files got moved into Drosera.h/cpp
3286         * Drosera/win/DebuggerApplication.h: Removed.
3287         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
3288           happened here to better match the logic flow of the same code on the 
3289           mac side and to use the new ServerConnection class.
3290         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
3291         (DebuggerClient::initWithServerName): Initializer that will set up the
3292           class to use a ServerConnection object.  This was necessary so I could
3293           create a DebuggerClient without having to initilaize it at
3294           construction.
3295         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
3296           will be the UIDelegate and FrameLoadDelegate.
3297         (DebuggerClient::AddRef): For IUnknown.
3298         (DebuggerClient::Release): For IUnknown.
3299         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
3300           this still needs to set the global context of the server, but
3301           IWebFrame does not have an accessor for the global context yet. 
3302         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
3303           this is a pass through for the same function in the document.
3304         (DebuggerClient::didReceiveTitle): Unimplemented part of
3305           FrameLoadDelegate this would change the title of the window.
3306         (DebuggerClient::createWebViewWithRequest): Part of the
3307           FrameLoadDelegate.  This is about new windows via Window.open() and
3308           how their delegates are set.
3309         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
3310           UIDelegate.  Just a debug function for printing messages.
3311         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
3312           because the Client should be the UIDelegate and FrameLoadDelegate
3313           to match the delegates on mac.
3314         (DebuggerClient::webViewLoaded): Added accessor method.
3315         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
3316           forgotten to add this file before.  This is where the platform
3317           dependent versions of the Documents functions live. Most of these are
3318           unimplemented because some piece of functionality does not exist on
3319           Windows yet.
3320         (DebuggerDocument::platformPause):
3321         (DebuggerDocument::platformResume):
3322         (DebuggerDocument::platformStepInto):
3323         (DebuggerDocument::platformEvaluateScript):
3324         (DebuggerDocument::getPlatformCurrentFunctionStack):
3325         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3326         (DebuggerDocument::platformValueForScopeVariableNamed):
3327         (DebuggerDocument::platformLog):
3328         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
3329           responsibilities becaue they belong in the Client. Also I laid the
3330           groundwork for attaching Drosera to a WebKit process
3331         (attachWndProc): Now if a server is selected the Client becomes it's
3332           delegate.
3333         (Drosera::Drosera): Added the construction of the Client and dictionary
3334           of server names. 
3335         (Drosera::initUI): This is no longer the delegates, the Client is.
3336         (Drosera::webViewLoaded): Now asks the Client instead of holding local
3337           state. 
3338         (Drosera::applicationDidFinishLaunching): Placeholder for needed
3339           notification registration when it's possible to implement.
3340         (Drosera::serverLoaded): Ditto
3341         (Drosera::serverUnloaded): Ditto
3342         (Drosera::attach): Attach Drosera to the WebKit server.
3343         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
3344         (Drosera::getInst): 
3345         (Drosera::setInst):
3346         (Drosera::knownServers):
3347         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
3348           and added the ServerConnection.
3349         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
3350         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
3351           Most of the functions are completely unimlemented because they cannot
3352           connect with the WebKit server, because one does not exist on Windows
3353           yet.
3354         (ServerConnection::initWithServerName): 
3355         (ServerConnection::~ServerConnection):
3356         (ServerConnection::setGlobalContext):
3357         (ServerConnection::pause):
3358         (ServerConnection::resume):
3359         (ServerConnection::stepInto):
3360         (ServerConnection::switchToServerNamed):
3361         (ServerConnection::applicationTerminating):
3362         (ServerConnection::serverConnectionDidDie):
3363         (ServerConnection::currentFrame):
3364         * Drosera/win/ServerConnection.h: Added. Ditto.
3365         (ServerConnection::ServerConnection):
3366
3367 2007-10-19  Alice Liu  <alice.liu@apple.com>
3368
3369         Reviewed by Darin.
3370
3371         Fix for these broken layout tests on Windows:
3372         
3373         fast/forms/focus-selection-input.html
3374         fast/forms/focus-selection-textarea.html
3375         fast/forms/select-accesskey.html
3376         
3377         * DumpRenderTree/win/EventSender.cpp:
3378         (keyDownCallback):
3379         correct the VK code for alt key.
3380         
3381 2007-10-19  Eric Seidel  <eric@webkit.org>
3382
3383         Reviewed by Mark Rowe.
3384         
3385         Make the GtkLauncher code slightly more readable.
3386
3387         * GtkLauncher/main.cpp:
3388         (setupMainMenu): Added.
3389         (setupMainWindowUI): Added.
3390         (main):
3391
3392 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
3393
3394         Rubber stamped by Adam.
3395         
3396         - don't delay-load WebKit in DumpRenderTree.
3397
3398         * DumpRenderTree/win/DumpRenderTree.vcproj:
3399
3400 2007-10-18  Dan Bernstein  <mitz@apple.com>
3401
3402         Reviewed by Adam Roben.
3403
3404         - fix <rdar://problem/5313523>
3405         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
3406
3407         * DumpRenderTree/mac/DumpRenderTree.mm:
3408         (dump): Changed to use _responseMIMEType.
3409
3410 2007-10-17  Adam Roben  <aroben@apple.com>
3411
3412         Make it possible to have Windows-specific tests and results
3413
3414         When searching for tests to run and the Skipped file, we will only
3415         look in platform/win and the cross-platform directory. When looking
3416         for expected results, we will look in platform/win, then
3417         platform/mac-leopard, then platform/mac, then finally the
3418         cross-platform directory.
3419
3420         Reviewed by Sam.
3421
3422         * Scripts/run-webkit-tests:
3423         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
3424         searching in the cross-platform directory.
3425         (sub buildPlatformHierarchy): Removed some unneeded calls to
3426         dirname/basename.
3427
3428 2007-10-17  Adam Roben  <aroben@apple.com>
3429
3430         Add back the call to register WebKit that we had before WebKitInitializer existed
3431
3432         This is needed to ensure that the right WebKit is used when
3433         instantiating COM objects.
3434
3435         Reviewed by Oliver.
3436
3437         * DumpRenderTree/win/debug_internal.vsprops: Define
3438         DEBUG_WEBKIT_HAS_SUFFIX.
3439         * DumpRenderTree/win/DumpRenderTree.cpp:
3440         (initialize):
3441
3442 2007-10-17  Adam Roben  <aroben@apple.com>
3443
3444         Import File::Basename in webkitdirs since we use it
3445
3446         * Scripts/webkitdirs.pm:
3447
3448 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
3449
3450         - Updated the tiger leaks list to make the internal bots green.
3451
3452         * Scripts/run-webkit-tests:
3453
3454 2007-10-17  Adam Roben  <aroben@apple.com>
3455
3456         Build fix for VC++ Express
3457
3458         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
3459         and ole32.lib.
3460
3461 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3462
3463         Reviewed by Sam.
3464
3465         - Minor mac improvements based on observations I made while implementing the
3466         Windows code.
3467
3468         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
3469         then hand it to the Client who will retain it, it should just be the client who
3470         creates and owns the server.
3471         (-[DebuggerApplication attach:]):
3472         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
3473         * Drosera/mac/DebuggerClient.mm: Creates the server.
3474         (-[DebuggerClient initWithServerName:]):
3475         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
3476         can instead forward declare what it needs.
3477
3478 2007-10-16  Darin Adler  <darin@apple.com>
3479
3480         Reviewed by Geoff Garen.
3481
3482         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
3483         want to turn failing tests into platform-specific test results. Also did a
3484         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
3485         would take the type of results into account only some of the time.
3486
3487 2007-10-16  Adam Roben  <aroben@apple.com>
3488
3489         Add a new nightly launcher script for Windows
3490
3491         This new script is for versions of Safari that don't delay-load
3492         WebKit. I had to make FindSafari be able to print out the nightly
3493         launcher script on stdout because Windows shell scripts can't capture
3494         the output from a command into an environment variable.
3495
3496         Reviewed by Steve.
3497
3498         * FindSafari/FindSafari.cpp:
3499         (_tmain): Added /printSafariLauncher option.
3500         * Scripts/run-webkit-nightly.cmd: Added.
3501
3502 2007-10-16  Adam Roben  <aroben@apple.com>
3503
3504         Replace WebKitInitializer with FindSafari
3505
3506         We now rely on setting the PATH environment variable to tell Windows
3507         where to find WebKit and its dependencies (similar to
3508         DYLD_FRAMEWORK_PATH on Mac).
3509
3510         This change also make DumpRenderTree no longer delay-load WebKit.
3511
3512         Reviewed by Sam.
3513
3514         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
3515         FindSafari.
3516         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
3517         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
3518         WebKitInitializer, don't delay-load WebKit.
3519         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
3520         * Scripts/run-webkit-tests: Ditto.
3521         * Scripts/webkitdirs.pm:
3522         (sub setPathForRunningWebKitApp): Added.
3523         * WebKitInitializer/WebKitInitializer.cpp: Removed.
3524         * WebKitInitializer/WebKitInitializer.h: Removed.
3525         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
3526         * WebKitInitializer/debug.vsprops: Removed.
3527         * WebKitInitializer/debug_internal.vsprops: Removed.
3528         * WebKitInitializer/release.vsprops: Removed.
3529
3530 2007-10-16  Adam Roben  <aroben@apple.com>
3531
3532         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
3533
3534         http://bugs.webkit.org/show_bug.cgi?id=15532
3535
3536         FindSafari simply prints the location of an installed Safari.exe on
3537         stdout.
3538
3539         Reviewed by Darin.
3540
3541         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
3542         (getStringValue):
3543         (getWebViewCLSID):
3544         (getInstalledWebKitDirectory):
3545         (_tmain):
3546         * FindSafari/FindSafari.vcproj: Added.
3547         * Scripts/webkitdirs.pm:
3548         (sub installedSafariPath): Added. Calls FindSafari on Windows.
3549
3550 2007-10-16  Adam Roben  <aroben@apple.com>
3551
3552         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
3553
3554         Reviewed by Kevin McCullough.
3555
3556         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
3557         when referring to WebKit.dll.
3558         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
3559         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
3560         * DumpRenderTree/win/release.vsprops: Ditto.
3561         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
3562         never have a _debug suffix on WebKit.dll.
3563         * WebKitInitializer/WebKitInitializer.cpp:
3564         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
3565         specified.
3566         * WebKitInitializer/debug_internal.vsprops: Added
3567         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
3568
3569 2007-10-16  Darin Adler  <darin@apple.com>
3570
3571         Reviewed by Adele.
3572
3573         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3574         Remove now-unneeded control/alt key hack; the tests have been updated.
3575
3576 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3577
3578         - Updated leaks list because our internal bot upgraded it's version of leopard and 
3579         one of the leaks was fixed between that revision and the bot's previous version of
3580         leopard.
3581
3582         * Scripts/run-webkit-tests:
3583
3584 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
3585
3586         Reviewed by Tim.
3587
3588         - I encapsulated out the server connecton functionality because it is a specific part
3589         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
3590         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
3591         Windows.  So the majority of this patch is moving preexisting functionality.
3592
3593         - Also I removed the prefix header and changed to use config.h because it is more
3594         standard on how we use config.h in windows and it didn't make much sense to keep
3595         the prefix header and the config.h
3596
3597         * Drosera/DebuggerDocument.cpp:
3598         (DebuggerDocument::DebuggerDocument):
3599         * Drosera/DebuggerDocument.h:
3600         * Drosera/config.h:
3601         * Drosera/mac/DebuggerApplication.mm:
3602         (-[DebuggerApplication attach:]):
3603         * Drosera/mac/DebuggerClient.h:
3604         * Drosera/mac/DebuggerClient.mm:
3605         (-[DebuggerClient initWithServerConnection:]):
3606         (-[DebuggerClient dealloc]):
3607         (-[DebuggerClient windowDidLoad]):
3608         (-[DebuggerClient windowWillClose:]):
3609         (-[DebuggerClient webView:didFinishLoadForFrame:]):
3610         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
3611         * Drosera/mac/DebuggerDocumentPlatform.mm:
3612         (DebuggerDocument::platformPause):
3613         (DebuggerDocument::platformResume):
3614         (DebuggerDocument::platformStepInto):
3615         (DebuggerDocument::platformEvaluateScript):
3616         (DebuggerDocument::getPlatformCurrentFunctionStack):
3617         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3618         (DebuggerDocument::platformValueForScopeVariableNamed):
3619         (DebuggerDocument::platformLog):
3620         * Drosera/mac/Drosera.pch: Removed.
3621         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3622         * Drosera/mac/ServerConnection.h: Added.
3623         * Drosera/mac/ServerConnection.mm: Added.
3624         (-[ServerConnection initWithServerName:]):
3625      &n