Removing <rdar://5507350> from skipped list because it's not failing.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2
3         - Build fix.  Added additional includes for VS Express to the Release
4         project.
5
6         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
7
8 2007-11-29  Anders Carlsson  <andersca@apple.com>
9
10         Reviewed by Adam.
11
12         <rdar://problem/5132005>
13         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
14         
15         * DumpRenderTree/win/DumpRenderTree.vcproj:
16         Add shlwapi.lib
17         
18         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
19         (LayoutTestController::setUserStyleSheetEnabled):
20         Implement this.
21         
22         (appendComponentToPath):
23         New method which wraps the Win32 API PathAppend.
24         
25         (followShortcuts):
26         New method which checks if a file points to a shortcut and
27         follows the shortcut.
28         
29         (resolveCygwinPath):
30         New method that takes a cygwin unix-style path and returns the Win32 path.
31         
32         (cfStringRefToWString):
33         
34         (LayoutTestController::setUserStyleSheetLocation):
35         Implement this.
36
37 2007-11-29  Alice Liu  <alice.liu@apple.com>
38
39         Reviewed by Adam.
40
41         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
42
43         * DumpRenderTree/win/EventSender.cpp:
44         (keyDownCallback):
45         uppercase letters were being sent as lowercase letters without the shift key down.
46
47 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
48
49         - Windows build fix. VS express needs some love.
50
51         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
52
53 2007-11-28  Darin Adler  <darin@apple.com>
54
55         Reviewed by Adam Roben.
56
57         * DumpRenderTree/mac/EventSendingController.mm:
58         (-[EventSendingController keyDown:withModifiers:]):
59         Send capital letters through as lowercase letters with the shift key down
60         rather than sending them as if they were highly unusual "capital letter keys".
61
62         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
63         where you need to update results and more tests are failing than before.
64
65 2007-11-28  Anders Carlsson  <andersca@apple.com>
66
67         Reviewed by Darin.
68
69         <rdar://problem/5132001>
70         contextClick is not implemented in DRT on Windows.
71         
72         * DumpRenderTree/win/EventSender.cpp:
73         (contextClickCallback):
74         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
75         by a WM_RBUTTONUP message.
76         
77         * DumpRenderTree/win/UIDelegate.cpp:
78         (UIDelegate::hasCustomMenuImplementation):
79         (UIDelegate::trackCustomPopupMenu):
80         * DumpRenderTree/win/UIDelegate.h:
81         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
82         menu from being shown (and causing the DRT to hang).
83
84 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
85
86         Reviewed by Darin.
87
88         Fix DumpRenderTree ObjC bug comparing strings.
89
90         * DumpRenderTree/mac/ObjCController.m:
91         (-[ObjCController identityIsEqual::]): Compare strings with string
92         equality instead of identiy equality.
93
94 2007-11-27  Timothy Hatcher  <timothy@apple.com>
95
96         Reviewed by Sam.
97
98         Reset the authorAndUserStylesEnabled preference
99         back to YES for each test. Fixes the broken tests.
100
101         * DumpRenderTree/mac/DumpRenderTree.mm:
102         (resetWebViewToConsistentStateBeforeTesting):
103
104 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
105
106         Reviewed by Adam.
107
108         - Drosera now displays the console window, although it cannot currently
109         process JavaScript.
110
111         * Drosera/win/DebuggerClient.cpp: Shows the console window.
112         (registerConsoleClass): Implemented.
113         (consoleWndProc): Implemented.
114         (DebuggerClient::onSize): Implemented.
115         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
116         new window.
117         * Drosera/win/DebuggerClient.h: Added needed method and members for 
118         creating and maintaining a new window.
119         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
120         lines of code to more appropriate places.
121         (Drosera::handleCommand):
122         (Drosera::initUI):
123         (Drosera::onSize):
124         (Drosera::attach):
125
126 2007-11-27  Timothy Hatcher  <timothy@apple.com>
127
128         Reviewed by Dave Hyatt.
129
130         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
131         
132         Add support for disabling author and user styles for testing.
133
134         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
135         * DumpRenderTree/LayoutTestController.cpp:
136         (setAuthorAndUserStylesEnabledCallback):
137         (LayoutTestController::staticFunctions):
138         * DumpRenderTree/LayoutTestController.h:
139         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
140         (LayoutTestController::setAuthorAndUserStylesEnabled):
141         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
142         (LayoutTestController::setAuthorAndUserStylesEnabled):
143
144 2007-11-26  Dan Bernstein  <mitz@apple.com>
145
146         - Tiger build fix.
147
148         * DumpRenderTree/mac/Configurations/Base.xcconfig:
149
150 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
151
152         Reviewed by Maciej.
153
154         - Implemented displaying variables for Drosera on Win.
155
156         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
157         that retrieve variables to not hold onto the return value since it's
158         not returned.  Also changed to use the new signatures of the retrieval
159         functions.
160         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
161         (DebuggerDocument::platformValueForScopeVariableNamed):
162         * Drosera/win/Drosera.cpp: Removed a needless TODO.
163         (droseraWndProc):
164
165 2007-11-26  Sam Weinig  <sam@webkit.org>
166
167         Cleanup names of painting and repainting functions.
168
169         Reviewed by Adam Roben.
170
171         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
172         (drawSelectionRect): was drawSelectionRectIntoContext.
173         (dumpWebViewAsPixelsAndCompareWithExpected):
174         * DumpRenderTree/cg/PixelDumpSupportCG.h:
175         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
176         (paintWebView): was drawWebViewIntoContext.
177         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
178
179 2007-11-26  Sam Weinig  <sam@webkit.org>
180
181         Reviewed by Dan Bernstein.
182
183         - Leopard build fix
184
185         * DumpRenderTree/mac/Configurations/Base.xcconfig:
186
187 2007-11-26  Sam Weinig  <sam@webkit.org>
188
189         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
190         Use shared PixelDumpSupport for Mac DRT
191
192         Reviewed by Adam Roben.
193
194         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
195         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
196         * DumpRenderTree/cg/ImageDiffCG.cpp:
197         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
198         (drawSelectionRectIntoContext):
199         (dumpWebViewAsPixelsAndCompareWithExpected):
200         * DumpRenderTree/cg/PixelDumpSupportCG.h:
201         * DumpRenderTree/mac/Configurations/Base.xcconfig:
202         * DumpRenderTree/mac/DumpRenderTree.mm:
203         (dump):
204         * DumpRenderTree/mac/ImageDiff.m: Removed.
205         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
206         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
207         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
208         (setDefaultColorProfileToRGB):
209         (getBitmapContextFromWebView):
210         (drawWebViewIntoContext):
211         (repaintWithVerticalSweep):
212         (repaintWithHorizontalSweep):
213         (getSelectionRect):
214         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
215
216 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
217
218         Bug 16052: prepare-ChangeLog doesn't report deleted files
219         <http://bugs.webkit.org/show_bug.cgi?id=16052>
220
221         Reviewed by Sam.
222
223         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
224
225 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
226
227         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
228         <http://bugs.webkit.org/show_bug.cgi?id=15864>
229
230         Reviewed by Adam.
231
232         Roll functionality of merge-changelog into resolve-ChangeLogs
233         script.  The script now checks for ChangeLog.rej and
234         ChangeLog.orig files first.  If it finds them, it uses the
235         ChangeLog.rej file as a patch (in old contextual diff format) to
236         apply with --fuzz=3.
237
238         * Scripts/merge-changelog: Removed.
239         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
240
241 2007-11-25  Sam Weinig  <sam@webkit.org>
242
243         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
244
245         Reviewed by Mark Rowe.
246
247         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
248         * DumpRenderTree/mac/Configurations/Base.xcconfig:
249         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
250         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
251         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
252
253 2007-11-25  Sam Weinig  <sam@webkit.org>
254
255         Convert DumpRenderTree to ues .xcconfig files.
256
257         Reviewed by Mark Rowe.
258
259         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
260         * DumpRenderTree/mac/Configurations: Added.
261         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
262         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
263         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
264
265 2007-11-25  Sam Weinig  <sam@webkit.org>
266
267         Add ForwardingHeaders to wtf for DumpRenderTree.
268
269         Reviewed by Mark Rowe.
270
271         * DumpRenderTree/DumpRenderTree.h:
272         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
273         * DumpRenderTree/ForwardingHeaders: Added.
274         * DumpRenderTree/ForwardingHeaders/wtf: Added.
275         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
276         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
277         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
278         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
279         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
280         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
281         * DumpRenderTree/LayoutTestController.cpp:
282         * DumpRenderTree/WorkQueue.cpp:
283         * DumpRenderTree/mac/DumpRenderTree.mm:
284         * DumpRenderTree/mac/FrameLoadDelegate.mm:
285         * DumpRenderTree/mac/JavaScriptThreading.cpp:
286         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
287         * DumpRenderTree/mac/ObjCController.m:
288         * DumpRenderTree/mac/UIDelegate.mm:
289         * DumpRenderTree/mac/WorkQueueItemMac.mm:
290
291 2007-11-25  Adam Roben  <aroben@apple.com>
292
293         Fix some test failures caused by r28019
294
295         Now that stdout is in binary mode, we need to always use printf
296         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
297         the output.
298
299         Reviewed by Sam.
300
301         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
302         printf.
303         (UIDelegate::runJavaScriptAlertPanelWithMessage):
304         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
305         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
306         (UIDelegate::webViewAddMessageToConsole):
307
308 2007-11-25  Adam Roben  <aroben@apple.com>
309
310         Set the font smoothing preference in DRT
311
312         This makes the pixel results on Windows closer to the Mac results.
313
314         Reviewed by Mitz.
315
316         * DumpRenderTree/win/DumpRenderTree.cpp:
317         (initializePreferences):
318
319 2007-11-25  Adam Roben  <aroben@apple.com>
320
321         Port ImageDiff to CG and C++
322
323         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
324         <rdar://5071708>
325
326         Reviewed by Sam.
327
328         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
329         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
330         (main):
331         (createImageFromStdin):
332         (compareImages):
333         (getDifferenceBitmap):
334         (computePercentageDifferent):
335         * DumpRenderTree/win/ImageDiff.vcproj: Added.
336
337 2007-11-25  Adam Roben  <aroben@apple.com>
338
339         Fix image diff link generation on Windows
340
341         Reviewed by Sam.
342
343         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
344         to toURL.
345
346 2007-11-25  Adam Roben  <aroben@apple.com>
347
348         Implement pixel dumping in Windows DRT
349
350         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
351         <rdar://5071708>
352
353         Reviewed by Sam.
354
355         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
356         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
357         Content-Length header.
358         (getMD5HashStringForBitmap):
359         (dumpWebViewAsPixelsAndCompareWithExpected):
360         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
361         * DumpRenderTree/win/DumpRenderTree.cpp:
362         (dump): Do a pixel dump if requested.
363         (main): Parse pixel test options.
364         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
365         the cg/ subdirectory to the include path.
366         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
367         available in a header or import library, so we have to go through this
368         LoadLibrary/GetProcAddress dance to use them.
369         (cryptDLL):
370         (init):
371         (update):
372         (final):
373         (MD5_Init):
374         (MD5_Update):
375         (MD5_Final):
376         * DumpRenderTree/win/MD5.h: Added.
377         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
378         moved up to the top level to share it with Mac eventually.
379         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
380         (getBitmapContextFromWebView): Forces the WebView to paint using a
381         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
382
383 2007-11-25  Adam Roben  <aroben@apple.com>
384
385         Clean up Windows DRT's option parsing a little bit
386
387         Reviewed by Sam.
388
389         * DumpRenderTree/win/DumpRenderTree.cpp:
390         (main): Put non-option arguments into a Vector.
391
392 2007-11-25  Adam Roben  <aroben@apple.com>
393
394         Make Windows DRT stop changing LF into CRLF
395
396         Reviewed by Sam.
397
398         * DumpRenderTree/win/DumpRenderTree.cpp:
399         (main): Put stdout in binary mode.
400         * Scripts/run-webkit-tests: Remove the CRLF hack.
401
402 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
403
404         Removed empty directory.
405
406         * Scripts/resources: Removed.
407
408 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
409
410         Fix bisect-builds to work with recent WebKit nightly builds.
411
412         Reviewed by Dan.
413
414         * Scripts/bisect-builds: Check for the 
415         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
416         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
417         to WebKit.app/Contents/Resources.
418
419 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
420
421         Reviewed by Maciej.
422
423         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
424         not closed (affects digg.com)
425
426         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
427         one after finishing with a test to avoid having its delayed onload handler firing when
428         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
429         but it helps somewhat.
430
431 2007-11-22  Mark Rowe  <mrowe@apple.com>
432
433         Reviewed by Alp Toker.
434
435         Fix build-webkit to propagate make's exit status if it fails.
436
437         * Scripts/webkitdirs.pm:
438
439 2007-11-22  Dan Bernstein  <mitz@apple.com>
440
441         Reviewed by Mark Rowe.
442
443         - fix crash when running pixel tests
444
445         * DumpRenderTree/mac/DumpRenderTree.mm:
446         (dumpRenderTree): Parse the command line options before setting up the
447         environment so that we know if we need to set up the pixel dump
448         machinery.
449
450 2007-11-21  Eric Seidel  <eric@webkit.org>
451
452         Speculative build fix for Tiger.
453
454         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
455
456 2007-11-21  Eric Seidel  <eric@webkit.org>
457
458         Reviewed by Tim Hatcher.
459
460         Break out more of DumpRenderTree.mm into individual files
461
462         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
463         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
464         (checkedMalloc):
465         (checkedRealloc):
466         (makeLargeMallocFailSilently):
467         * DumpRenderTree/mac/CheckedMalloc.h: Added.
468         * DumpRenderTree/mac/DumpRenderTree.mm:
469         (crashHandler):
470         (dump):
471         * DumpRenderTree/mac/DumpRenderTreeMac.h:
472         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
473         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
474         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
475         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
476         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
477         (javaScriptThreads):
478         (runJavaScriptThread):
479         (startJavaScriptThreads):
480         (stopJavaScriptThreads):
481         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
482         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
483         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
484         (restoreColorSpace):
485         (setDefaultColorProfileToRGB):
486         (initializeColorSpaceAndScreeBufferForPixelTests):
487         (md5HashStringForBitmap):
488         (dumpWebViewAsPixelsAndCompareWithExpected):
489
490 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
491
492         Move install-unix-extras to wx directory as it seems only to be used by that 
493         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
494         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
495         have install-unix-extras install into WebKitLibraries as per
496         convention.
497         
498         Reviewed by Mark Rowe.
499
500         * Scripts/install-unix-extras: Removed.
501         * wx/build-wxwebkit:
502         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
503
504 2007-11-21  Eric Seidel  <eric@webkit.org>
505
506         Reviewed by Adam.
507
508         More refactoring for greater code readability
509
510         * DumpRenderTree/mac/DumpRenderTree.mm:
511         (initializeGlobalsFromCommandLineOptions):
512         (initializeColorSpaceAndScreeBufferForPixelTests):
513         (addTestPluginsToPluginSearchPath):
514         (useLongRunningServerMode):
515         (runTestingServerLoop):
516         (prepareConsistentTestingEnvironment):
517         (dumpRenderTree):
518         (main):
519         (dumpFramesAsText):
520         (dumpBackForwardListForWebView):
521         (sizeWebViewForCurrentTest):
522         (methodNameStringForFailedTest):
523         (dumpBackForwardListForAllWindows):
524         (dumpWebViewAsPixelsAndCompareWithExpected):
525         (invalidateAnyPreviousWaitToDumpWatchdog):
526         (dump):
527         * DumpRenderTree/mac/DumpRenderTreeMac.h:
528         * DumpRenderTree/mac/UIDelegate.mm:
529         (-[UIDelegate webView:createWebViewWithRequest:]):
530
531 2007-11-21  Eric Seidel  <eric@webkit.org>
532
533         Reviewed by Tim Hatcher.
534
535         Abstract more of DRT into static methods
536
537         * DumpRenderTree/mac/DumpRenderTree.mm:
538         (setDefaultsToConsistentValuesForTesting):
539         (setupSignalHandlers):
540         (allocateGlobalControllers):
541         (releaseAndZero):
542         (releaseGlobalControllers):
543         (dumpRenderTree):
544         (shouldLogFrameLoadDelegates):
545         (createCFURLFromPathOrURL):
546         (resetWebViewToConsistentStateBeforeTesting):
547         (runTest):
548
549 2007-11-21  Eric Seidel  <eric@webkit.org>
550
551         Reviewed by Tim Hatcher.
552
553         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
554
555         * DumpRenderTree/DumpRenderTree.h:
556         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
557         * DumpRenderTree/mac/DumpRenderTree.mm:
558         (dumpRenderTree):
559         (dump):
560         (runTest):
561         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
562         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
563         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
564         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
565         (-[DumpRenderTreePasteboard declareType:owner:]):
566         (+[LocalPasteboard alloc]):
567         (-[LocalPasteboard init]):
568         (-[LocalPasteboard dealloc]):
569         (-[LocalPasteboard name]):
570         (-[LocalPasteboard releaseGlobally]):
571         (-[LocalPasteboard declareTypes:owner:]):
572         (-[LocalPasteboard addTypes:owner:]):
573         (-[LocalPasteboard changeCount]):
574         (-[LocalPasteboard types]):
575         (-[LocalPasteboard availableTypeFromArray:]):
576         (-[LocalPasteboard setData:forType:]):
577         (-[LocalPasteboard dataForType:]):
578         (-[LocalPasteboard setPropertyList:forType:]):
579         (-[LocalPasteboard setString:forType:]):
580         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
581         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
582         (+[DumpRenderTreeWindow allWindows]):
583         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
584         (-[DumpRenderTreeWindow dealloc]):
585         (-[DumpRenderTreeWindow isKeyWindow]):
586         (-[DumpRenderTreeWindow keyDown:]):
587
588 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
589
590         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
591         it indiscriminately copies any headers inside JavaScriptCore,
592         which includes Tiger ICU headers. 
593
594         * wx/build-wxwebkit:
595         Don't run WebCore/move-js-headers.sh any longer.
596
597 2007-11-20  Adam Treat  <treat@kde.org>
598
599         Reviewed by David Kilzer.
600
601         * Prepend git branch name to $baseProductDir
602
603         * Scripts/VCSUtils.pm:
604         * Scripts/webkitdirs.pm:
605
606 2007-11-20  Mark Rowe  <mrowe@apple.com>
607
608         Reviewed by Simon Hausmann.
609
610         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
611         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
612         Have it trigger a "make distclean" rather than "make clean" to ensure that the
613         built product and generated Makefile's are removed.
614
615 2007-11-19  Alp Toker  <alp@atoker.com>
616
617         Reviewed by Mark Rowe.
618
619         http://bugs.webkit.org/show_bug.cgi?id=16040
620         [GTK] GtkLauncher should be written in C
621
622         Port GtkLauncher to plain C.
623
624         Use a more conventional GTK+ coding style.
625
626         Use a toolbar instead of menus.
627
628         Various signature fixes and cleanups.
629
630         Add a license header. Assume all previous modifications were copyright
631         assigned to Apple Inc. by default.
632
633         * GtkLauncher/GtkLauncher.pro:
634         * GtkLauncher/main.c: Added.
635         (activate_url_entry_cb):
636         (update_title):
637         (link_hover_cb):
638         (title_change_cb):
639         (progress_change_cb):
640         (destroy_cb):
641         (go_back_cb):
642         (go_forward_cb):
643         (create_browser):
644         (create_statusbar):
645         (create_toolbar):
646         (create_window):
647         (main):
648         * GtkLauncher/main.cpp: Removed.
649
650 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
651
652         Build script fixes to ensure they do the right thing for the 
653         wx port, and update build-wxwebkit to reflect the way the
654         build scripts now work.
655
656         Reviewed by Adam.
657
658         * Scripts/build-testkjs:
659         * Scripts/build-webkit:
660         * Scripts/run-javascriptcore-tests:
661         * Scripts/webkitdirs.pm:
662         * wx/build-wxwebkit:
663
664 2007-11-18  Eric Seidel  <eric@webkit.org>
665
666         Reviewed by Anders.
667
668         Make run-javascriptcore-tests report failures on exit (to support git bisect)
669
670         * Scripts/run-javascriptcore-tests:
671
672 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
673
674         Reviewed by Adam Roben.
675
676         Make run-webkit-tests work with Windows debug build.
677
678         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
679         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
680         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
681         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
682         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
683
684 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
685
686         Add wxWebKit sample and build script, and integrate it with 
687         build-webkit. Also make build-webkit --clean work for all
688         ports.
689
690         Reviewed by Darin Adler.
691
692         * Scripts/build-webkit:
693         * Scripts/webkitdirs.pm:
694         * wx: Added.
695         * wx/browser: Added.
696         * wx/browser/browser.bkl: Added.
697         * wx/browser/browser.cpp: Added.
698         * wx/build-wxwebkit: Added.
699
700 2007-11-17  Adam Roben  <aroben@apple.com>
701
702         Make it easy to run Safari in the debugger on Windows
703
704         I've added a new script, debug-safari, which launches Safari in the
705         debugger. On OS X it just calls gdb-safari.
706
707         Reviewed by Mark Rowe.
708
709         * FindSafari/FindSafari.cpp:
710         (_tmain): Added a /debugger flag, which in combination with
711         /printSafariLauncher will print a script that launches Safari in the
712         debugger.
713         * Scripts/debug-safari: Added.
714         * Scripts/run-safari: Changed to call runSafari().
715         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
716         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
717         first argument along to FindSafari.
718         * Scripts/webkitdirs.pm:
719         (sub runSafari): Added.
720
721 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
722
723         Reviewed by Adam Roben.
724
725         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
726
727 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
728
729         Reviewed by David Kilzer.
730
731         The git config command was renamed to repo-config at some point. This
732         change tries git config and then git repo-config if the first fails.
733
734         * Scripts/prepare-ChangeLog:
735         (gitConfig):
736
737 2007-11-16  Dan Bernstein  <mitz@apple.com>
738
739         Reviewed by Darin Adler and Sam Weinig.
740
741         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
742
743         * DumpRenderTree/win/EventSender.cpp:
744         (keyDownCallback): For characters that cannot be entered on the active
745         keyboard layout, send a WM_CHAR message with the character along with
746         a WM_KEYDOWN message with a virtual key code of 255.
747
748 2007-11-16  Mark Rowe  <mrowe@apple.com>
749
750         Reviewed by Tim Hatcher.
751
752         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
753
754         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
755         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
756
757 2007-11-15  Adam Roben  <aroben@apple.com>
758
759         Make run-safari actually work on Windows
760
761         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
762         chdir call.
763
764 2007-11-14  Adam Roben  <aroben@apple.com>
765
766         Updates to Safari launching now that 3.0.4 is released
767
768         Reviewed by Sam.
769
770         * FindSafari/FindSafari.cpp:
771         (getWebViewCLSID): Use version-independent ProgID.
772         * Scripts/run-safari: Use run-webkit-nightly.cmd.
773
774 2007-11-14  Anders Carlsson  <andersca@apple.com>
775
776         Reviewed by Adam.
777
778         <rdar://problem/5309081>
779         In DRT, "plugin.logDestroy = true" not working on Windows.
780         
781         * DumpRenderTree/win/TestNetscapePlugin/main.c:
782         (NPP_Destroy):
783
784 2007-11-14  Eric Seidel  <eric@webkit.org>
785
786         Reviewed by Sam.
787
788         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
789
790 2007-11-14  Anders Carlsson  <andersca@apple.com>
791
792         Reviewed by Adam.
793
794         <rdar://problem/5141186>
795         window.layoutTestController.setWindowIsKey is not implemented in DRT.
796         
797         Implement setWindowIsKey.
798         
799         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
800         (LayoutTestController::setWindowIsKey):
801
802 2007-11-13  Sam Weinig  <sam@webkit.org>
803
804         Reviewed by Adam Roben.
805
806         Fix for <rdar://problem/5382579>
807         http/tests/security/cross-frame-access-put.html reports large 
808         negative numbers for screenLeft and screenTop (Mac reports "0")
809
810         * DumpRenderTree/win/UIDelegate.cpp:
811         (UIDelegate::UIDelegate): Initialize the RECT.
812         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
813         (UIDelegate::webViewFrame): ditto.
814         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
815
816 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
817
818         Reviewed by Adam.
819
820         - Make Drosera show source, source URLs, and function stack on Windows,
821         and some minor fixes.
822
823         * Drosera/DebuggerDocument.cpp: Force source to always update display.
824         (DebuggerDocument::updateFileSource):
825         * Drosera/debugger.js: Force source to always update display.
826         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
827         menu controls.
828         (DebuggerClient::resume):
829         (DebuggerClient::pause):
830         (DebuggerClient::stepInto):
831         (DebuggerClient::stepOver):
832         (DebuggerClient::stepOut):
833         (DebuggerClient::showConsole):
834         (DebuggerClient::closeCurrentFile):
835         * Drosera/win/DebuggerClient.h: Ditto.
836         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
837         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
838         removed two bugs.  1) caller could be in a bad state when asked to
839         assign into it. 2) BSTRs were not created correctly.
840         (DebuggerDocument::getPlatformCurrentFunctionStack):
841         * Drosera/win/Drosera.cpp: Hook up the menu controls.
842         (droseraWndProc):
843         (handleCommand):
844         (Drosera::resume):
845         (Drosera::pause):
846         (Drosera::stepInto):
847         (Drosera::stepOver):
848         (Drosera::stepOut):
849         (Drosera::showConsole):
850         (Drosera::closeCurrentFile):
851         * Drosera/win/Drosera.h: Hook up the menu controls.
852         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
853         functions, added a null check, and fixed another bug where caller could
854         be in a bad state when asked to assign into it.
855         (ServerConnection::didLoadMainResourceForDataSource):
856         (ServerConnection::getCallerFrame):
857         * Drosera/win/ServerConnection.h: Safety first.
858
859 2007-11-13  Dan Bernstein  <mitz@apple.com>
860
861         Reviewed by Darin Adler.
862
863         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
864           DumpRenderTree --pixel-tests renders each test twice
865
866         * DumpRenderTree/mac/DumpRenderTree.mm:
867         (dumpRenderTree): Removed the --paint option because the painting code
868         is always exercised as a result of
869         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
870         calling -displayIfNeeded.
871         (dump): Changed to always grab the image from the window since the view
872         is always displayed.
873         (runTest):
874         (displayWebView):
875         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
876         because it always paints.
877
878 2007-11-12  Antti Koivisto  <antti@apple.com>
879
880         Reviewed by Adele.
881         
882         Add support for http media tests
883
884         * Scripts/run-webkit-tests:
885
886 2007-11-12  Sam Weinig  <sam@webkit.org>
887
888         Reviewed by Adam Roben.
889
890         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
891
892         * DumpRenderTree/win/DumpRenderTree.cpp:
893         (runTest):
894         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
895         (LayoutTestController::setPrivateBrowsingEnabled):
896
897 2007-11-12  Adam Roben  <aroben@apple.com>
898
899         * Scripts/update-webkit-localizable-strings: Changed to only scan the
900         mac and win subdirectories.
901
902 2007-11-11  Adam Roben  <aroben@apple.com>
903
904         Fix <rdar://5133816> keepWebHistory is not implemented
905
906         Fixes fast/history/clicked-link-is-visited.html.
907
908         Reviewed by Darin.
909
910         * DumpRenderTree/win/DumpRenderTree.cpp:
911         (runTest): Clear the optionalSharedHistory.
912         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
913         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
914
915 2007-11-10  Sam Weinig  <sam@webkit.org>
916
917         Reviewed by Tim Hatcher.
918
919         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
920         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
921         is turned on)
922
923         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
924
925         Added test: http/tests/security/cross-frame-access-private-browsing.html
926
927         * DumpRenderTree/LayoutTestController.cpp:
928         (setPrivateBrowsingEnabledCallback):
929         (LayoutTestController::staticFunctions):
930         * DumpRenderTree/LayoutTestController.h:
931         * DumpRenderTree/mac/DumpRenderTree.mm:
932         (runTest): Default to private browsing disabled.
933         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
934         (LayoutTestController::setPrivateBrowsingEnabled):
935         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
936         (LayoutTestController::setPrivateBrowsingEnabled):
937
938 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
939
940         Reviewed by Adam.
941
942         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
943         WebCore's!
944
945         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
946         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
947         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
948         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
949         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
950         * Drosera/win/Drosera.cpp:
951         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
952
953 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
954
955         Reviewed by Sam.
956
957         - Use the new IWebFrame [local] function signature and get the shared
958         server correctly.
959
960         * Drosera/win/DebuggerClient.cpp:
961         (DebuggerClient::didFinishLoadForFrame):
962         * Drosera/win/ServerConnection.cpp:
963         (ServerConnection::attemptToCreateServerConnection):
964
965 2007-11-07  Dan Bernstein  <mitz@apple.com>
966
967         Reviewed by Darin Adler.
968
969         - add an option to run-webkit-tests to ignore pixel test failures where
970           all pixels differ by no more than a specified threshold
971
972         * DumpRenderTree/mac/ImageDiff.m:
973         (main):
974         (compareImages):
975         (computePercentageDifferent):
976         * Scripts/run-webkit-tests:
977
978 2007-11-07  Simon Hausmann  <hausmann@kde.org>
979
980         Reviewed by Lars.
981
982         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
983
984         * DumpRenderTree/qt/DumpRenderTree.cpp:
985
986 2007-11-07  Simon Hausmann  <hausmann@kde.org>
987
988         Reviewed by Lars.
989
990         Reworked the QWebSettings API.
991         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
992
993         * DumpRenderTree/qt/DumpRenderTree.cpp:
994
995 2007-11-07  Simon Hausmann  <hausmann@kde.org>
996
997         Reviewed by Lars.
998
999         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1000
1001         * DumpRenderTree/qt/jsobjects.cpp:
1002
1003 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1004
1005         Reviewed by Lars Knoll <lars@trolltech.com>.
1006
1007         Add a QWebPage::frameCreated() signal and fix DRT
1008         
1009         The removal of createFrame in QWebPage broke the re-implementation
1010         in DumpRenderTree. Instead emit a frameCreated() signal and
1011         connect to it in DumpRenderTree.
1012         
1013
1014         * DumpRenderTree/qt/DumpRenderTree.cpp:
1015         (WebCore::WebPage::WebPage):
1016         (WebCore::DumpRenderTree::dump):
1017         (WebCore::DumpRenderTree::connectFrame):
1018         * DumpRenderTree/qt/DumpRenderTree.h:
1019
1020 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1021
1022         Reviewed by Lars Knoll <lars@trolltech.com>.
1023
1024         Moved all the event handlers from QWebFrame into QWebPage.
1025         
1026         This cleans up the public API and allows us to remove the
1027         HackWebFrame hack in DumpRenderTree.
1028         
1029
1030         * DumpRenderTree/qt/jsobjects.cpp:
1031         (EventSender::mouseDown):
1032         (EventSender::mouseUp):
1033         (EventSender::mouseMoveTo):
1034
1035 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1036
1037         Reviewed by Mark.
1038
1039         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1040         to prevent the default implementation from popping up messageboxes.
1041
1042         * DumpRenderTree/qt/DumpRenderTree.cpp:
1043         (WebCore::WebPage::javaScriptConfirm):
1044         (WebCore::WebPage::javaScriptPrompt):
1045
1046 2007-11-06  Eric Seidel  <eric@webkit.org>
1047
1048         * Scripts/build-testkjs: build fix... too many $$
1049
1050 2007-11-06  Eric Seidel  <eric@webkit.org>
1051
1052         Reviewed by Mark Rowe.
1053
1054         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1055
1056 2007-11-05  Adam Roben  <aroben@apple.com>
1057
1058         Add support on Windows for WEBKIT_TESTFONTS
1059
1060         This environment variable lets you specify where the fonts to be used
1061         by DumpRenderTree reside. The Qt port is already using this, so I'm
1062         just following their lead.
1063
1064         Reviewed by Darin.
1065
1066         * DumpRenderTree/win/DumpRenderTree.cpp:
1067         (exePath): Refactored code out of initialize().
1068         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1069         DumpRenderTree.resources.
1070         (initialize): Use the new fontsPath function.
1071         (main): Use the new exePath function.
1072         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1073         variable to DRT, like Qt does.
1074
1075 2007-11-05  Mark Rowe  <mrowe@apple.com>
1076
1077         Rubber-stamped by Alp Toker.
1078
1079         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1080
1081         * GtkLauncher/main.cpp:
1082         (goToURLBarText):
1083         (main):
1084
1085 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1086
1087         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1088         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1089
1090         Reviewed by Timothy.
1091
1092         Restrict the range of nightly builds used by the bisect-builds script
1093         based on the version of Safari and the version of Mac OS X being used.
1094
1095         Mac OS X 10.4: Safari 2.0: r11976 or newer
1096         Mac OS X 10.4: Safari 3.0: r19992 or newer
1097
1098         Mac OS X 10.5: Safari 2.0: r19594 or newer
1099         Mac OS X 10.5: Safari 3.0: r25124 or newer
1100
1101         * Scripts/bisect-builds:
1102         (findMacOSXVersion): Added.
1103         (makeNightlyList): Added argument to provide version of Mac OS X.
1104         Restrict range of nightly builds based on Safari and Mac OS X versions.
1105
1106 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1107
1108         Reviewed by Maciej.
1109
1110         - This patch involves several changes, all of them were noticed that
1111         they were needed by the work being done in WebKit to get Drosera and
1112         WebKit working together on Windows.
1113         - The changes are:
1114         1) Added a debugger console for output messages.
1115         2) Drosera now listens for the WebKit server (before, the server would
1116         have to be running before Drosera was started.)
1117         3) Fixed a bug where the WebView started out as 0x0 pixels.
1118         4) Fixed a bug when there is no scope.
1119         5) Added the HTML, JS, and CSS to the project file to make them easy to
1120         find.
1121         6) Made the ServerConnection functions virtual.
1122
1123         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1124         for the WebKit server.
1125         (DebuggerClient::DebuggerClient):
1126         (DebuggerClient::~DebuggerClient):
1127         (DebuggerClient::didFinishLoadForFrame):
1128         (DebuggerClient::serverConnected):
1129         (DebuggerClient::attemptToCreateServerConnection):
1130         * Drosera/win/DebuggerClient.h: Ditto.
1131         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1132         scope.
1133         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1134         (DebuggerDocument::platformValueForScopeVariableNamed):
1135         * Drosera/win/Drosera.cpp:
1136         (_tWinMain): Added a console in debug for output messages.
1137         (Drosera::Drosera): Listen for server.
1138         (Drosera::initUI): The server now Initializes COM.
1139         (Drosera::serverConnected): Part of the listening for the server.
1140         (Drosera::attemptToCreateServerConnection): Ditto.
1141         * Drosera/win/Drosera.h: New interface for listening for the server.
1142         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1143         files to the VS project.
1144         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1145         connection.
1146         (ServerConnection::ServerConnection):
1147         (ServerConnection::attemptToCreateServerConnection):
1148         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1149         methods.
1150         (ServerConnection::serverConnected):
1151
1152 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1153
1154         Reviewed by Maciej.
1155
1156         http://bugs.webkit.org/show_bug.cgi?id=15832
1157         fast/dom/gc-10.html crashes when run alone
1158
1159         Check for !done before using objects that can be already deallocated.
1160
1161         * DumpRenderTree/mac/EditingDelegate.mm:
1162         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1163         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1164         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1165         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1166         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1167         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1168         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1169         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1170         (-[EditingDelegate webViewDidBeginEditing:]):
1171         (-[EditingDelegate webViewDidChange:]):
1172         (-[EditingDelegate webViewDidEndEditing:]):
1173         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1174         (-[EditingDelegate webViewDidChangeSelection:]):
1175         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1176         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1177         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1178         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1179         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1180         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1181         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1182         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1183         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1184         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
1185         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1186         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
1187         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1188         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
1189         (-[FrameLoadDelegate webView:willCloseFrame:]):
1190         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1191         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1192         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1193         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1194         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1195         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1196         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1197         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1198         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1199
1200 2007-11-04  Mark Rowe  <mrowe@apple.com>
1201
1202         Build fix.  Don't use Carbon.h as the prefix header as it triggers
1203         warnings that would otherwise be suppressed due to it being a system header.
1204
1205         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1206
1207 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
1208
1209         Rubber stamped by Adam.
1210         
1211         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
1212
1213         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1214
1215 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1216
1217         Sort files(...); sections of Xcode project files.
1218
1219         Rubber-stamped by Darin.
1220
1221         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1222         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1223         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1224         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1225
1226 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1227
1228         Script to sort "files(...);" sections in Xcode project.pbxproj files.
1229
1230         Reviewed by Darin.
1231
1232         * Scripts/sort-Xcode-project-file: Added.
1233
1234 2007-11-02  Darin Adler  <darin@apple.com>
1235
1236         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
1237
1238 2007-11-02  Darin Adler  <darin@apple.com>
1239
1240         Reviewed by Maciej.
1241
1242         * Scripts/run-sunspider: Pass the "--base" option through.
1243
1244         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
1245         the real script do that. Default configuration to Release to match run-sunspider
1246         so we don't end up building Debug just to compare results.
1247
1248 2007-11-01  Adam Roben  <aroben@apple.com>
1249
1250         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
1251
1252         Reviewed by Sam.
1253
1254         * Scripts/commit-log-editor: Show all the directories beneath the
1255         source root, instead of just the last one.
1256
1257 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
1258
1259         Reviewed by Adam Roben.
1260
1261         Print out an error message when the Windows build fails
1262         and provide guidance on how to find out what went wrong.
1263
1264         * Scripts/build-webkit:
1265         * Scripts/webkitdirs.pm:
1266
1267 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
1268
1269         Rubber-stamped by Adam Roben.
1270
1271         Rolled out r27326 - debug CRT seems to cause no problems after all.
1272
1273         * DumpRenderTree/win/DumpRenderTree.vcproj:
1274
1275 2007-10-31  Adam Roben  <aroben@apple.com>
1276
1277         Switch the Debug configuration to using the non-debug CRT
1278
1279         This matches WebKit.
1280
1281         Reviewed by Steve.
1282
1283         * DumpRenderTree/win/DumpRenderTree.vcproj:
1284
1285 2007-10-31  Antti Koivisto  <antti@apple.com>
1286
1287         Reviewed by bdash.
1288         
1289         Disable media tests when doing leak checking on Tiger.
1290         They crash in QuickTime (rdar://problem/5537157).
1291
1292         * Scripts/run-webkit-tests:
1293
1294 2007-10-29  Antti Koivisto  <antti@apple.com>
1295
1296         Reviewed by Maciej.
1297         
1298         Build media support by default on OSX only.
1299
1300         * Scripts/build-webkit:
1301
1302 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1303
1304         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
1305         get caught by the pre-commit hooks.
1306
1307 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1308
1309         Reviewed by Adam.
1310
1311         - This is a collection of relatively unrelated changes and cleanups
1312         to Drosera to prepare it for interacting with WebKit.  A lot of these
1313         changes are just correcting mistakes, for example removing included
1314         headers that are no longer needed.
1315
1316         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
1317         this will be needed by the DebuggerClient.
1318         (DebuggerDocument::server):
1319         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
1320         * Drosera/win/DebuggerClient.cpp: 
1321         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
1322         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
1323         (DebuggerClient::createWebViewWithRequest): Added comment about its
1324         purpose. 
1325         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
1326         declarations.
1327         (DebuggerClient::webViewLoaded): Moved.
1328         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
1329         file, since this was the only place it was used.
1330         (cfStringToBSTR):
1331         * Drosera/win/Drosera.h: Cleaned up the includes.
1332         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
1333         * Drosera/win/HelperFunctions.h: Removed.
1334
1335 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1336
1337         Reviewed by Adam.
1338
1339         - Small cleanup in the ServerConnection class.
1340
1341         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
1342         and added an include.
1343         (ServerConnection::currentFrame):
1344         (ServerConnection::getCallerFrame):
1345         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
1346         made a pointer into a COMPtr, and cleaned up the includes.
1347
1348 2007-10-29  Timothy Hatcher  <timothy@apple.com>
1349
1350         Reviewed by John Sullivan.
1351         
1352         - Place the Localizable.strings file in mac or win directories
1353           if that location exists.
1354         - Also look for UI_STRING in .c files.
1355
1356         * Scripts/extract-localizable-strings:
1357
1358 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1359
1360         Reviewed by Adam.
1361
1362         - Set the eol-style to native and made all the line endings the same
1363         so that I avoid messy diffs that show eol changes.
1364
1365         * Drosera/win/ServerConnection.cpp:
1366         (ServerConnection::didParseSource):
1367         (ServerConnection::didEnterCallFrame):
1368         (ServerConnection::willExecuteStatement):
1369         (ServerConnection::willLeaveCallFrame):
1370         (ServerConnection::exceptionWasRaised):
1371
1372 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1373
1374         Reviewed by Adam.
1375
1376         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
1377         functionality that could not have existed previously without the new
1378         interfaces.
1379         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
1380         from a BSTR to a JSValueRef.
1381         (DebuggerDocument::platformEvaluateScript): Implemented.
1382         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
1383         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1384         Implemented.
1385         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
1386         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
1387         * Drosera/win/ServerConnection.cpp: Added a helper function.
1388         (ServerConnection::getCallerFrame):
1389         * Drosera/win/ServerConnection.h: Added a helper function.
1390
1391 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1392
1393         updated reviewers for my previous changelog.
1394
1395 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1396         Reviewed by Maciej and Adam and Geoff.
1397
1398         - Minor mac-side improvements including moving a function to a more
1399         appropriate location, fixing a warning, and correctly checking
1400         exceptions.
1401
1402         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
1403         (DebuggerDocument::willExecuteStatement):
1404         (DebuggerDocument::didEnterCallFrame):
1405         (DebuggerDocument::willLeaveCallFrame):
1406         (DebuggerDocument::windowScriptObjectAvailable):
1407         (DebuggerDocument::callFunctionOnObject):
1408         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
1409         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
1410         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
1411         because it doesn't require the ServerConnection at all.
1412         (NSStringCreateWithJSStringRef): Made an argument const.
1413         (JSValueRefCreateWithNSString): Made an argument const.
1414         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
1415         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1416         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
1417         * Drosera/mac/ServerConnection.mm: Ditto.
1418         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1419
1420 2007-10-29  Sam Weinig  <sam@webkit.org>
1421
1422         Reviewed by Adam Roben.
1423
1424         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
1425
1426         * DumpRenderTree/LayoutTestController.cpp:
1427         (LayoutTestController::LayoutTestController):
1428         (getGlobalFlagCallback):
1429         (setGlobalFlagCallback):
1430         (LayoutTestController::getJSClass):
1431         (LayoutTestController::staticValues):
1432         * DumpRenderTree/LayoutTestController.h:
1433         (LayoutTestController::globalFlag):
1434         (LayoutTestController::setGlobalFlag):
1435
1436 2007-10-29  Darin Adler  <darin@apple.com>
1437
1438         Reviewed by Maciej.
1439
1440         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
1441         resolution instead of its default.
1442
1443 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
1444
1445         Fixed showStatus() to print status for successfully resolved conflicts when using git.
1446
1447         Reviewed by Mark Rowe.
1448
1449         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
1450         was successfully resolved, but this would not show any status because the change had
1451         already been cached in the index using "git add".  The solution is to add an optional
1452         second argument to showStatus() which adds the "--cached" switch to the command.
1453
1454         * Scripts/resolve-ChangeLogs:
1455         (showStatus):
1456
1457 2007-10-28  Eric Seidel  <eric@webkit.org>
1458
1459         Reviewed by Maciej and Geoff, in unison.
1460
1461         * Scripts/run-webkit-tests: remove broken --svg option
1462
1463 2007-10-28  Darin Adler  <darin@apple.com>
1464
1465         Reviewed by Adam.
1466
1467         * Scripts/run-sunspider: Default to "Release" configuration rather than
1468         defaulting to the last configuration used as other scripts do. This can
1469         still be overriden on the command line with "--debug" if there's some
1470         reason to do so. Also fix a typo.
1471
1472         * Scripts/sunspider-compare-results: Fix a typo.
1473
1474 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
1475
1476         Reviewed by Adam.
1477
1478         - Implemented the WebScriptDebugListener functions now that the
1479         WebScriptDebugServer exists
1480
1481         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
1482         functions.
1483         (ServerConnection::currentFrame):
1484         (ServerConnection::didLoadMainResourceForDataSource):
1485         (ServerConnection::didParseSource):
1486         (ServerConnection::failedToParseSource):
1487         (ServerConnection::didEnterCallFrame):
1488         (ServerConnection::willExecuteStatement):
1489         (ServerConnection::willLeaveCallFrame):
1490         (ServerConnection::exceptionWasRaised):
1491         * Drosera/win/ServerConnection.h: Removed unused arguments from the
1492         members arguments list.
1493
1494 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
1495
1496         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
1497         <http://bugs.webkit.org/show_bug.cgi?id=15600>
1498
1499         Reviewed by Darin.
1500
1501         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
1502         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
1503         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
1504         file.  Note that it may also be used as a stand-alone script.
1505
1506         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
1507         * Scripts/resolve-ChangeLogs: Added.
1508         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
1509
1510 2007-10-26  Mark Rowe  <mrowe@apple.com>
1511
1512         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
1513         to the Qt port on the assumption that it was an implementation of the cross-platform
1514         LayoutTestController class.  It is not, so it did not need to be changed.
1515
1516         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
1517
1518 2007-10-25  Mark Rowe  <mrowe@apple.com>
1519
1520         Reviewed by Maciej.
1521
1522         Fix builds with code coverage enabled.
1523
1524         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
1525
1526 2007-10-25  Darin Adler  <darin@apple.com>
1527
1528         Reviewed by Mark Rowe.
1529
1530         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
1531         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
1532
1533 2007-10-25  Stephanie  <slewis@apple.com>
1534
1535         build Fix
1536
1537         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1538
1539 2007-10-25  Stephanie  <slewis@apple.com>
1540
1541         Reviewed by Mark Rowe, Adam Roben.
1542
1543         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
1544
1545         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
1546
1547 2007-10-25  Alice Liu  <alice.liu@apple.com>
1548
1549         Reviewed by Adam.
1550
1551         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
1552
1553         Moving destructor into platform-specific files
1554         * DumpRenderTree/LayoutTestController.cpp:
1555         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1556         (LayoutTestController::~LayoutTestController):
1557         * DumpRenderTree/qt/jsobjects.cpp:
1558         (LayoutTestController::~LayoutTestController):
1559
1560         LayoutTestController wasn't being destroyed
1561         * DumpRenderTree/win/DumpRenderTree.cpp:
1562         (runTest):
1563
1564         Added declspec
1565         * DumpRenderTree/win/EditingDelegate.h:
1566
1567         Reset certain values on the webview (or related delegate) that might 
1568         have changed while running a test
1569         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1570         (LayoutTestController::~LayoutTestController):
1571
1572 2007-10-25  Adam Roben  <aroben@apple.com>
1573
1574         Make sunspider-compare-results work with relative paths
1575
1576         Reviewed by Sam.
1577
1578         * Scripts/sunspider-compare-results: Convert arguments to absolute
1579         paths before we chdir.
1580
1581 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
1582
1583         Reviewed by Sam.
1584
1585         - Implemented server calls now the WebScriptDebugServer exists.
1586         - Also removed no longer needed call to initialize CG.
1587
1588         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
1589         automatically now.
1590         (_tWinMain):
1591         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
1592         (ServerConnection::ServerConnection):
1593         (ServerConnection::~ServerConnection):
1594         (ServerConnection::pause):
1595         (ServerConnection::resume):
1596         (ServerConnection::stepInto):
1597         (ServerConnection::applicationTerminating):
1598         (ServerConnection::serverConnectionDidDie):
1599         * Drosera/win/ServerConnection.h: Now uses the COM class.
1600
1601 2007-10-24  George Staikos  <staikos@kde.org>
1602
1603         Unbreak Qt build.
1604
1605         * Scripts/build-webkit:
1606
1607 2007-10-24  Adam Roben  <aroben@apple.com>
1608
1609         Remove now-unnecessary call to InitializeCoreGraphics
1610
1611         WebKit takes care of this now.
1612
1613         Reviewed by Ada.
1614
1615         * DumpRenderTree/win/DumpRenderTree.cpp:
1616         (initialize):
1617
1618 2007-10-24  Adam Roben  <aroben@apple.com>
1619
1620         Use WebTextRenderer in DRT
1621
1622         Reviewed by Ada.
1623
1624         * DumpRenderTree/win/DumpRenderTree.cpp:
1625         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
1626
1627 2007-10-24  Sven Herzberg  <sven@imendio.com>
1628
1629         Reviewed by Mark Rowe.
1630
1631         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
1632         Bug 15614: [GTK] qmake based backends don't build on OS X
1633
1634         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
1635         GTK backend on a Mac
1636         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
1637         isDarwin() to make it reusable in other places (like the workaround-
1638         for-prebuilt-qmake in build-webkit)
1639
1640 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1641
1642         Refurbish update-webkit script.
1643
1644         Reviewed by Adam.
1645
1646         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
1647         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
1648         multi-argument version of system() for flexibility and security.  Check for existence
1649         of Internal directory using -d test instead of -x.
1650
1651 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1652
1653         Minor clean-up of prepare-ChangeLog script.
1654
1655         Reviewed by Adam.
1656
1657         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
1658         of a string.  Use multi-argument versions of open() and system() for flexibility and
1659         security.
1660
1661 2007-10-24  Alice Liu  <alice.liu@apple.com>
1662
1663         Reviewed by Oliver.
1664
1665         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
1666
1667         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
1668         replay the saved events when we're still processing the mousedown that starts the drag
1669         * DumpRenderTree/win/EventSender.cpp:
1670         (doMouseMove):
1671         * DumpRenderTree/win/UIDelegate.cpp:
1672         (UIDelegate::doDragDrop):
1673
1674 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
1675
1676         Reviewed by Sam, Steve and Darin.
1677
1678         - Stubbed out the WebScriptDebugListener functionality in the Server
1679         Connection class to prepare it for receiving those callbacks.
1680         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
1681         and the ServerConnection to not need to be initialized with a server
1682         name, since that is not the way we connect to the WebKit server. 
1683
1684         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
1685         no exception.  Now it only loggs when there is an exception
1686         (DebuggerDocument::willExecuteStatement):
1687         (DebuggerDocument::didEnterCallFrame):
1688         (DebuggerDocument::willLeaveCallFrame):
1689         (DebuggerDocument::windowScriptObjectAvailable):
1690         (DebuggerDocument::callFunctionOnObject):
1691         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
1692         to be instantiated with a server's name.
1693         (DebuggerClient::DebuggerClient):
1694         (DebuggerClient::didFinishLoadForFrame):
1695         * Drosera/win/DebuggerClient.h: Removed unsued variable.
1696         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
1697         a server name.
1698         (Drosera::init):
1699         (Drosera::initServer):
1700         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
1701         instantiated with a server's name.
1702         * Drosera/win/ServerConnection.cpp: 
1703         (ServerConnection::ServerConnection): No longer needs a server name
1704         (ServerConnection::~ServerConnection): Only release the global context
1705         if there is one.
1706         (ServerConnection::serverConnectionDidDie): Stub for
1707         IWebScriptDebugListener
1708         (ServerConnection::QueryInterface): ditto
1709         (ServerConnection::AddRef): ditto
1710         (ServerConnection::Release): ditto
1711         (ServerConnection::didLoadMainResourceForDataSource): ditto
1712         (ServerConnection::didParseSource): ditto
1713         (ServerConnection::failedToParseSource): ditto
1714         (ServerConnection::didEnterCallFrame): ditto
1715         (ServerConnection::willExecuteStatement): ditto
1716         (ServerConnection::willLeaveCallFrame): ditto
1717         (ServerConnection::exceptionWasRaised): ditto
1718         * Drosera/win/ServerConnection.h: Stubbed out the
1719         IWebScriptDebugListener functions, and this class no longer needs to be
1720         instantiated with a server name.
1721
1722 2007-10-24  Lars Knoll  <lars@trolltech.com>
1723
1724         Reviewed by Simon.
1725
1726         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
1727
1728         * DumpRenderTree/qt/jsobjects.h:
1729
1730 2007-10-24  Lars Knoll  <lars@trolltech.com>
1731
1732         Reviewed by Simon.
1733
1734         add another command.
1735
1736         * DumpRenderTree/qt/jsobjects.cpp:
1737         (TextInputController::doCommand):
1738
1739 2007-10-24  Lars Knoll  <lars@trolltech.com>
1740
1741         Reviewed by Simon.
1742
1743         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
1744
1745         * DumpRenderTree/qt/jsobjects.cpp:
1746         (EventSender::keyDown):
1747         * DumpRenderTree/qt/jsobjects.h:
1748
1749 2007-10-24  Lars Knoll  <lars@trolltech.com>
1750
1751         Reviewed by Simon.
1752
1753         implement eventSender.keyDown().
1754
1755         * DumpRenderTree/qt/jsobjects.cpp:
1756         (EventSender::keyDown):
1757
1758 2007-10-24  Lars Knoll  <lars@trolltech.com>
1759
1760         Reviewed by Simon.
1761
1762         some smaller fixes to the editing support in DRT. Makes another few tests pass.
1763
1764         * DumpRenderTree/qt/DumpRenderTree.cpp:
1765         (WebCore::DumpRenderTree::DumpRenderTree):
1766         (WebCore::DumpRenderTree::initJSObjects):
1767         * DumpRenderTree/qt/jsobjects.cpp:
1768         (TextInputController::doCommand):
1769
1770 2007-10-24  Lars Knoll  <lars@trolltech.com>
1771
1772         Reviewed by Simon.
1773
1774         first bit of implementation for the textinputcontroller.
1775
1776         * DumpRenderTree/qt/DumpRenderTree.cpp:
1777         (WebCore::DumpRenderTree::DumpRenderTree):
1778         * DumpRenderTree/qt/DumpRenderTree.h:
1779         * DumpRenderTree/qt/jsobjects.cpp:
1780         (TextInputController::TextInputController):
1781         (TextInputController::doCommand):
1782         * DumpRenderTree/qt/jsobjects.h:
1783
1784 2007-10-24  Lars Knoll  <lars@trolltech.com>
1785
1786         Reviewed by Simon.
1787
1788         make the man webpage believe it has focus, so the editing tests work correctly.
1789
1790         * DumpRenderTree/qt/DumpRenderTree.cpp:
1791         (WebCore::DumpRenderTree::DumpRenderTree):
1792
1793 2007-10-24  Lars Knoll  <lars@trolltech.com>
1794
1795         Reviewed by Simon.
1796
1797         implement layoutTestController.dumpEditingCallbacks() correctly.
1798
1799         * DumpRenderTree/qt/DumpRenderTree.cpp:
1800         (WebCore::DumpRenderTree::DumpRenderTree):
1801         * DumpRenderTree/qt/jsobjects.cpp:
1802         (LayoutTestController::reset):
1803         (LayoutTestController::dumpEditingCallbacks):
1804
1805 2007-10-24  Lars Knoll  <lars@trolltech.com>
1806
1807         Reviewed by Simon.
1808
1809         Implement support for testing editing.
1810
1811         * DumpRenderTree/qt/DumpRenderTree.cpp:
1812         (WebCore::DumpRenderTree::DumpRenderTree):
1813
1814 2007-10-23  Sam Weinig  <sam@webkit.org>
1815
1816         Check for null BSTR that can be passed to the UIDelegate methods
1817         from javascript null and undefined.  Fixes a failing test case on
1818         Windows (fast/dom/Window/alert-undefined.html)
1819
1820         Reviewed by Eric Seidel.
1821
1822         * DumpRenderTree/win/UIDelegate.cpp:
1823         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1824         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1825         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1826         (UIDelegate::webViewAddMessageToConsole):
1827
1828 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1829
1830         Reviewed by Darin.
1831         
1832         Don't print a massive pile of setenvs from tools that automatically build testkjs.
1833
1834         * Scripts/build-testkjs:
1835
1836 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1837
1838         Reviewed by Darin.
1839
1840         - add wrapper that finds the right copy of testkjs
1841         
1842         * Scripts/sunspider-compare-results: Added.
1843
1844 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
1845
1846         Reviewed by Sam.
1847
1848         - After talking with Steve I now see that the WebKit server must be
1849         running for DCOM to create the distributed objects, which makes sense
1850         and currently WebKit only allows one instance to be running at a time
1851         which avoids accidentally connecting to the wrong server
1852         - In light of this I have removed the code for the attach box and
1853         NotificationServer and known server names, since they are all extranious
1854         now.
1855
1856         * Drosera/win/Drosera.cpp: Removed notification classes and known server
1857         names.
1858         (_tWinMain): Uses init instead of initUI.
1859         (droseraWndProc): No longer creats an attach dialog box.
1860         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
1861         it's not manditory to call init before doing COM stuff.
1862         (Drosera::init): calls initUI and will call attach when the
1863         functionality exists. 
1864         (Drosera::initUI): Has changed very little.
1865         (Drosera::attach): Changed the signature to reflect that we no longer
1866         need the dictionary of known server names.
1867         * Drosera/win/Drosera.h: Removed notification classes and known server
1868         names.  Also renamed and moved some functions.
1869         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
1870         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
1871         headers to the resources folder. 
1872         * Drosera/win/resource.h: Removed the Attach box.
1873
1874 2007-10-22  Adam Roben  <aroben@apple.com>
1875
1876         Windows build fix
1877
1878         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
1879
1880 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
1881
1882         - Removed a leak that was fixed.
1883
1884         * Scripts/run-webkit-tests:
1885
1886 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1887
1888         Reviewed by Darin.
1889
1890         - Changed the Client so that the DebuggerDocument now own the
1891         ServerConnection.  This simplifies ownership and cleanup. 
1892
1893         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
1894         ServerConnection.
1895         (DebuggerClient::initWithServerName):
1896         (DebuggerClient::didFinishLoadForFrame):
1897         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
1898         ServerConnection.
1899         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
1900         until after we have a server which we are attached to.
1901         (Drosera::initUI):
1902         (Drosera::attach):
1903         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
1904         out previously.
1905
1906 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1907
1908         Reviewed by Nikolas.
1909
1910         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
1911
1912         * Scripts/run-javascriptcore-tests:
1913
1914 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1915
1916         Reviewed by Nikolas.
1917
1918         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
1919
1920         * Scripts/build-drosera:
1921         * Scripts/build-dumprendertree:
1922         * Scripts/build-testkjs:
1923         * Scripts/build-webkit:
1924         * Scripts/run-javascriptcore-tests:
1925         * Scripts/run-sunspider:
1926         * Scripts/run-webkit-tests:
1927         * Scripts/webkitdirs.pm:
1928
1929 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
1930
1931         Reviewed by Mark Rowe.
1932         
1933         Fix for local database support after r26879
1934         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
1935
1936         * Scripts/build-webkit:
1937
1938 2007-10-22  Holger Freyther  <zecke@selfish.org>
1939
1940         Reviewed by Simon Hausmann <hausmann@kde.org>.
1941
1942         - Do not build testkjs as an application bundle. This is
1943         needed for run-javascriptcore-tests on OSX.
1944         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
1945         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
1946         as we do not have -rpath on OSX.
1947
1948         * DumpRenderTree/qt/DumpRenderTree.pro:
1949         * Scripts/run-webkit-tests:
1950
1951 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1952
1953         Reviewed by aroben.
1954
1955         Fix support for Signed-off-by detection in prepare-ChangeLog
1956         --git-commit. The Signed-off-by tag does not appear in the header
1957         but usually at the end.
1958
1959         * Scripts/prepare-ChangeLog:
1960
1961 2007-10-21  Mark Rowe  <mrowe@apple.com>
1962
1963         Reviewed by Eric.
1964
1965         Fix run-javascriptcore-tests for Gtk.
1966
1967         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
1968
1969 2007-10-20  Eric Seidel  <eric@webkit.org>
1970
1971         Reviewed by aroben.
1972
1973         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
1974
1975 2007-10-20  Eric Seidel  <eric@webkit.org>
1976
1977         Reviewed by darin.
1978         
1979         Add improved argument handling to run-sunspider, including
1980         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
1981         Also re-factor code into subroutines
1982
1983         * Scripts/build-dumprendertree: removed bogus comments
1984         * Scripts/build-testkjs: Added.
1985         * Scripts/run-javascriptcore-tests: use build-testkjs
1986         * Scripts/run-sunspider: improved argument handling, abstraction
1987         * Scripts/run-webkit-tests: improved abstraction
1988
1989 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
1990
1991         Not reviewed, Windows build fix.
1992
1993         * DumpRenderTree/win/EventSender.cpp:
1994         (keyDownCallback):
1995
1996 2007-10-20  Darin Adler  <darin@apple.com>
1997
1998         Reviewed by Tim Hatcher.
1999
2000         - http://bugs.webkit.org/show_bug.cgi?id=15544
2001           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2002           not rely on Apple-specific key codes
2003
2004         * DumpRenderTree/mac/EventSendingController.mm:
2005         (-[EventSendingController keyDown:withModifiers:]):
2006         Added named key "rightArrow". Later we could have a whole table of these.
2007         Also tweaked modifiers code a little.
2008
2009         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2010
2011 2007-10-19  Darin Adler  <darin@apple.com>
2012
2013         Reviewed by Eric.
2014
2015         - http://bugs.webkit.org/show_bug.cgi?id=15566
2016           possible fix for leak seen in DumpRenderTree
2017
2018         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2019         Delete the item if it's not put on the queue, since the caller has
2020         no way of knowing that. Would be better to have the parameter type
2021         be auto_ptr to express the fact that we take ownership.
2022
2023         - unrelated change
2024
2025         * Drosera/mac/main.m: Add missing include.
2026
2027 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2028
2029         Reviewed by Adam.
2030
2031         - This change should be identical but for some reason was not working
2032         on my machine.
2033
2034         * Scripts/prepare-ChangeLog:
2035
2036 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2037
2038         Reviewed by Oliver and Tim.
2039
2040         - Made use of RetainPtr to avoid retain and release issues and moved the
2041         log function to DebuggerDocumentPlatform, which seems to be a more
2042         logical place for it to live.
2043         - Also moved knownServers from the ServerConnection to
2044         DebuggerApplication to match the Windows code and because it makes sense
2045         that a connection knows its own server but not all of them.
2046
2047         * Drosera/mac/DebuggerClient.h: Moved the log function to
2048           DebuggerDocumentPlatform.
2049         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2050           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2051           call for the server name up from the ServerConnection class.
2052         (-[DebuggerClient dealloc]):
2053         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2054           for the server name up from the ServerConnection.
2055         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2056         (DebuggerDocument::platformPause):
2057         (DebuggerDocument::platformResume):
2058         (DebuggerDocument::platformStepInto):
2059         (DebuggerDocument::platformEvaluateScript):
2060         (DebuggerDocument::getPlatformCurrentFunctionStack):
2061         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2062         (DebuggerDocument::platformValueForScopeVariableNamed):
2063         (DebuggerDocument::platformLog): Log directly from here. No need to call
2064           DebuggerClient.
2065         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2066           way I see it, a ServerConnection should only know about its connection
2067           and the group of all possible servers should be kept by the
2068           application.
2069         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2070           currentServerName, it makes sense that the connection should know that
2071           name.
2072         (-[ServerConnection currentServerName]):
2073
2074 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2075
2076         Reviewed by Adam.
2077
2078         - Integrated changes from mac drosera.  Recently I've encapsulated
2079         out the server connection object from the rest of Drosera because
2080         it is very platform dependent right now and RPC is not implemented on
2081         windows.  This functionality, of communicating with the WebKit server
2082         is the next area I will be focusing on in Windows.
2083
2084         - Other changes and cleanup were made to organize the code and add notes
2085         on which parts still need work.  Also some mac code is added and
2086         commented out, to act as pseudocode for the logic of those parts.
2087
2088         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2089           pointer.
2090         * Drosera/config.h: Added whitespace.
2091         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2092           these files got moved into Drosera.h/cpp
2093         * Drosera/win/DebuggerApplication.h: Removed.
2094         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
2095           happened here to better match the logic flow of the same code on the 
2096           mac side and to use the new ServerConnection class.
2097         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2098         (DebuggerClient::initWithServerName): Initializer that will set up the
2099           class to use a ServerConnection object.  This was necessary so I could
2100           create a DebuggerClient without having to initilaize it at
2101           construction.
2102         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2103           will be the UIDelegate and FrameLoadDelegate.
2104         (DebuggerClient::AddRef): For IUnknown.
2105         (DebuggerClient::Release): For IUnknown.
2106         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2107           this still needs to set the global context of the server, but
2108           IWebFrame does not have an accessor for the global context yet. 
2109         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2110           this is a pass through for the same function in the document.
2111         (DebuggerClient::didReceiveTitle): Unimplemented part of
2112           FrameLoadDelegate this would change the title of the window.
2113         (DebuggerClient::createWebViewWithRequest): Part of the
2114           FrameLoadDelegate.  This is about new windows via Window.open() and
2115           how their delegates are set.
2116         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2117           UIDelegate.  Just a debug function for printing messages.
2118         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2119           because the Client should be the UIDelegate and FrameLoadDelegate
2120           to match the delegates on mac.
2121         (DebuggerClient::webViewLoaded): Added accessor method.
2122         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2123           forgotten to add this file before.  This is where the platform
2124           dependent versions of the Documents functions live. Most of these are
2125           unimplemented because some piece of functionality does not exist on
2126           Windows yet.
2127         (DebuggerDocument::platformPause):
2128         (DebuggerDocument::platformResume):
2129         (DebuggerDocument::platformStepInto):
2130         (DebuggerDocument::platformEvaluateScript):
2131         (DebuggerDocument::getPlatformCurrentFunctionStack):
2132         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2133         (DebuggerDocument::platformValueForScopeVariableNamed):
2134         (DebuggerDocument::platformLog):
2135         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2136           responsibilities becaue they belong in the Client. Also I laid the
2137           groundwork for attaching Drosera to a WebKit process
2138         (attachWndProc): Now if a server is selected the Client becomes it's
2139           delegate.
2140         (Drosera::Drosera): Added the construction of the Client and dictionary
2141           of server names. 
2142         (Drosera::initUI): This is no longer the delegates, the Client is.
2143         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2144           state. 
2145         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2146           notification registration when it's possible to implement.
2147         (Drosera::serverLoaded): Ditto
2148         (Drosera::serverUnloaded): Ditto
2149         (Drosera::attach): Attach Drosera to the WebKit server.
2150         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2151         (Drosera::getInst): 
2152         (Drosera::setInst):
2153         (Drosera::knownServers):
2154         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2155           and added the ServerConnection.
2156         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2157         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2158           Most of the functions are completely unimlemented because they cannot
2159           connect with the WebKit server, because one does not exist on Windows
2160           yet.
2161         (ServerConnection::initWithServerName): 
2162         (ServerConnection::~ServerConnection):
2163         (ServerConnection::setGlobalContext):
2164         (ServerConnection::pause):
2165         (ServerConnection::resume):
2166         (ServerConnection::stepInto):
2167         (ServerConnection::switchToServerNamed):
2168         (ServerConnection::applicationTerminating):
2169         (ServerConnection::serverConnectionDidDie):
2170         (ServerConnection::currentFrame):
2171         * Drosera/win/ServerConnection.h: Added. Ditto.
2172         (ServerConnection::ServerConnection):
2173
2174 2007-10-19  Alice Liu  <alice.liu@apple.com>
2175
2176         Reviewed by Darin.
2177
2178         Fix for these broken layout tests on Windows:
2179         
2180         fast/forms/focus-selection-input.html
2181         fast/forms/focus-selection-textarea.html
2182         fast/forms/select-accesskey.html
2183         
2184         * DumpRenderTree/win/EventSender.cpp:
2185         (keyDownCallback):
2186         correct the VK code for alt key.
2187         
2188 2007-10-19  Eric Seidel  <eric@webkit.org>
2189
2190         Reviewed by Mark Rowe.
2191         
2192         Make the GtkLauncher code slightly more readable.
2193
2194         * GtkLauncher/main.cpp:
2195         (setupMainMenu): Added.
2196         (setupMainWindowUI): Added.
2197         (main):
2198
2199 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
2200
2201         Rubber stamped by Adam.
2202         
2203         - don't delay-load WebKit in DumpRenderTree.
2204
2205         * DumpRenderTree/win/DumpRenderTree.vcproj:
2206
2207 2007-10-18  Dan Bernstein  <mitz@apple.com>
2208
2209         Reviewed by Adam Roben.
2210
2211         - fix <rdar://problem/5313523>
2212         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2213
2214         * DumpRenderTree/mac/DumpRenderTree.mm:
2215         (dump): Changed to use _responseMIMEType.
2216
2217 2007-10-17  Adam Roben  <aroben@apple.com>
2218
2219         Make it possible to have Windows-specific tests and results
2220
2221         When searching for tests to run and the Skipped file, we will only
2222         look in platform/win and the cross-platform directory. When looking
2223         for expected results, we will look in platform/win, then
2224         platform/mac-leopard, then platform/mac, then finally the
2225         cross-platform directory.
2226
2227         Reviewed by Sam.
2228
2229         * Scripts/run-webkit-tests:
2230         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
2231         searching in the cross-platform directory.
2232         (sub buildPlatformHierarchy): Removed some unneeded calls to
2233         dirname/basename.
2234
2235 2007-10-17  Adam Roben  <aroben@apple.com>
2236
2237         Add back the call to register WebKit that we had before WebKitInitializer existed
2238
2239         This is needed to ensure that the right WebKit is used when
2240         instantiating COM objects.
2241
2242         Reviewed by Oliver.
2243
2244         * DumpRenderTree/win/debug_internal.vsprops: Define
2245         DEBUG_WEBKIT_HAS_SUFFIX.
2246         * DumpRenderTree/win/DumpRenderTree.cpp:
2247         (initialize):
2248
2249 2007-10-17  Adam Roben  <aroben@apple.com>
2250
2251         Import File::Basename in webkitdirs since we use it
2252
2253         * Scripts/webkitdirs.pm:
2254
2255 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
2256
2257         - Updated the tiger leaks list to make the internal bots green.
2258
2259         * Scripts/run-webkit-tests:
2260
2261 2007-10-17  Adam Roben  <aroben@apple.com>
2262
2263         Build fix for VC++ Express
2264
2265         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
2266         and ole32.lib.
2267
2268 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2269
2270         Reviewed by Sam.
2271
2272         - Minor mac improvements based on observations I made while implementing the
2273         Windows code.
2274
2275         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
2276         then hand it to the Client who will retain it, it should just be the client who
2277         creates and owns the server.
2278         (-[DebuggerApplication attach:]):
2279         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
2280         * Drosera/mac/DebuggerClient.mm: Creates the server.
2281         (-[DebuggerClient initWithServerName:]):
2282         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
2283         can instead forward declare what it needs.
2284
2285 2007-10-16  Darin Adler  <darin@apple.com>
2286
2287         Reviewed by Geoff Garen.
2288
2289         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
2290         want to turn failing tests into platform-specific test results. Also did a
2291         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
2292         would take the type of results into account only some of the time.
2293
2294 2007-10-16  Adam Roben  <aroben@apple.com>
2295
2296         Add a new nightly launcher script for Windows
2297
2298         This new script is for versions of Safari that don't delay-load
2299         WebKit. I had to make FindSafari be able to print out the nightly
2300         launcher script on stdout because Windows shell scripts can't capture
2301         the output from a command into an environment variable.
2302
2303         Reviewed by Steve.
2304
2305         * FindSafari/FindSafari.cpp:
2306         (_tmain): Added /printSafariLauncher option.
2307         * Scripts/run-webkit-nightly.cmd: Added.
2308
2309 2007-10-16  Adam Roben  <aroben@apple.com>
2310
2311         Replace WebKitInitializer with FindSafari
2312
2313         We now rely on setting the PATH environment variable to tell Windows
2314         where to find WebKit and its dependencies (similar to
2315         DYLD_FRAMEWORK_PATH on Mac).
2316
2317         This change also make DumpRenderTree no longer delay-load WebKit.
2318
2319         Reviewed by Sam.
2320
2321         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
2322         FindSafari.
2323         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
2324         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
2325         WebKitInitializer, don't delay-load WebKit.
2326         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
2327         * Scripts/run-webkit-tests: Ditto.
2328         * Scripts/webkitdirs.pm:
2329         (sub setPathForRunningWebKitApp): Added.
2330         * WebKitInitializer/WebKitInitializer.cpp: Removed.
2331         * WebKitInitializer/WebKitInitializer.h: Removed.
2332         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
2333         * WebKitInitializer/debug.vsprops: Removed.
2334         * WebKitInitializer/debug_internal.vsprops: Removed.
2335         * WebKitInitializer/release.vsprops: Removed.
2336
2337 2007-10-16  Adam Roben  <aroben@apple.com>
2338
2339         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
2340
2341         http://bugs.webkit.org/show_bug.cgi?id=15532
2342
2343         FindSafari simply prints the location of an installed Safari.exe on
2344         stdout.
2345
2346         Reviewed by Darin.
2347
2348         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
2349         (getStringValue):
2350         (getWebViewCLSID):
2351         (getInstalledWebKitDirectory):
2352         (_tmain):
2353         * FindSafari/FindSafari.vcproj: Added.
2354         * Scripts/webkitdirs.pm:
2355         (sub installedSafariPath): Added. Calls FindSafari on Windows.
2356
2357 2007-10-16  Adam Roben  <aroben@apple.com>
2358
2359         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
2360
2361         Reviewed by Kevin McCullough.
2362
2363         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
2364         when referring to WebKit.dll.
2365         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
2366         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
2367         * DumpRenderTree/win/release.vsprops: Ditto.
2368         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
2369         never have a _debug suffix on WebKit.dll.
2370         * WebKitInitializer/WebKitInitializer.cpp:
2371         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
2372         specified.
2373         * WebKitInitializer/debug_internal.vsprops: Added
2374         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
2375
2376 2007-10-16  Darin Adler  <darin@apple.com>
2377
2378         Reviewed by Adele.
2379
2380         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2381         Remove now-unneeded control/alt key hack; the tests have been updated.
2382
2383 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2384
2385         - Updated leaks list because our internal bot upgraded it's version of leopard and 
2386         one of the leaks was fixed between that revision and the bot's previous version of
2387         leopard.
2388
2389         * Scripts/run-webkit-tests:
2390
2391 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
2392
2393         Reviewed by Tim.
2394
2395         - I encapsulated out the server connecton functionality because it is a specific part
2396         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
2397         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
2398         Windows.  So the majority of this patch is moving preexisting functionality.
2399
2400         - Also I removed the prefix header and changed to use config.h because it is more
2401         standard on how we use config.h in windows and it didn't make much sense to keep
2402         the prefix header and the config.h
2403
2404         * Drosera/DebuggerDocument.cpp:
2405         (DebuggerDocument::DebuggerDocument):
2406         * Drosera/DebuggerDocument.h:
2407         * Drosera/config.h:
2408         * Drosera/mac/DebuggerApplication.mm:
2409         (-[DebuggerApplication attach:]):
2410         * Drosera/mac/DebuggerClient.h:
2411         * Drosera/mac/DebuggerClient.mm:
2412         (-[DebuggerClient initWithServerConnection:]):
2413         (-[DebuggerClient dealloc]):
2414         (-[DebuggerClient windowDidLoad]):
2415         (-[DebuggerClient windowWillClose:]):
2416         (-[DebuggerClient webView:didFinishLoadForFrame:]):
2417         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
2418         * Drosera/mac/DebuggerDocumentPlatform.mm:
2419         (DebuggerDocument::platformPause):
2420         (DebuggerDocument::platformResume):
2421         (DebuggerDocument::platformStepInto):
2422         (DebuggerDocument::platformEvaluateScript):
2423         (DebuggerDocument::getPlatformCurrentFunctionStack):
2424         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2425         (DebuggerDocument::platformValueForScopeVariableNamed):
2426         (DebuggerDocument::platformLog):
2427         * Drosera/mac/Drosera.pch: Removed.
2428         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2429         * Drosera/mac/ServerConnection.h: Added.
2430         * Drosera/mac/ServerConnection.mm: Added.
2431         (-[ServerConnection initWithServerName:]):
2432         (-[ServerConnection dealloc]):
2433         (-[ServerConnection setGlobalContext:]):
2434         (-[ServerConnection pause]):
2435         (-[ServerConnection resume]):
2436         (-[ServerConnection stepInto]):
2437         (-[ServerConnection switchToServerNamed:]):
2438         (-[ServerConnection applicationTerminating:]):
2439         (-[ServerConnection serverConnectionDidDie:]):
2440         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2441         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2442         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
2443         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
2444         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
2445         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
2446         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2447         (-[ServerConnection currentFrame]):
2448         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
2449         (-[ServerConnection knownServers]):
2450
2451 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
2452
2453         Reviewed by Eric.
2454
2455         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
2456           Script to automatically search nightly builds for regressions (bisect-builds)
2457
2458         * Scripts/bisect-builds: Added.
2459
2460 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
2461
2462         Reviewed by Darin.
2463
2464         - New JavaScript benchmark
2465         http://bugs.webkit.org/show_bug.cgi?id=15515
2466
2467         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
2468         current development or release build of JavaScriptCore.
2469
2470 2007-10-15  Mark Rowe  <mrowe@apple.com>
2471
2472         Reviewed by Sam.
2473
2474         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
2475
2476         * Scripts/webkitdirs.pm:
2477         - Change checkArgv to remove the options from @ARGV to prevent
2478         them from interfering with further option processing.
2479         - Fix logic error in determineIsQt that would prevent it from bailing out early.
2480         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
2481         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
2482         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
2483
2484 2007-10-15  Darin Adler  <darin@apple.com>
2485
2486         Reviewed by Sam.
2487
2488         - added logging of window.prompt and window.confirm
2489
2490         * DumpRenderTree/mac/UIDelegate.mm:
2491         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2492         Implement the recommended delegate rather than the deprecated one.
2493         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
2494         Added.
2495         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2496         Added.
2497
2498         * DumpRenderTree/win/UIDelegate.h:
2499         * DumpRenderTree/win/UIDelegate.cpp:
2500         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
2501         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
2502         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
2503         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
2504
2505 2007-10-15  Alice Liu  <alice.liu@apple.com>
2506
2507         Reviewed by Sam Weinig.
2508
2509         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
2510
2511         * DumpRenderTree/win/DumpRenderTree.cpp:
2512         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
2513         (main): allocate the global policy delegate for DRT's custom use
2514         * DumpRenderTree/win/DumpRenderTree.vcproj:
2515         Adding files to project
2516         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
2517         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2518         (LayoutTestController::setCustomPolicyDelegate):
2519         set the webview's policy delegate to DRT's custom one if the test requests it.
2520         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
2521         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
2522         (PolicyDelegate::PolicyDelegate):
2523         (PolicyDelegate::QueryInterface):
2524         (PolicyDelegate::AddRef):
2525         (PolicyDelegate::Release):
2526         (PolicyDelegate::decidePolicyForNavigationAction):
2527         * DumpRenderTree/win/PolicyDelegate.h: Added.
2528         (PolicyDelegate::decidePolicyForNewWindowAction):
2529         (PolicyDelegate::decidePolicyForMIMEType):
2530         (PolicyDelegate::unableToImplementPolicyWithError):
2531
2532 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
2533
2534         Reviewed by Mark.
2535
2536         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
2537         when querying for QMAKE_MKSPECS.
2538
2539 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
2540
2541         Reviewed by Adam Roben.
2542         
2543         Fix run-webkit-tests is too greedy calculating platform hierarchy
2544         http://bugs.webkit.org/show_bug.cgi?id=15465
2545         
2546         Fix run-webkit-tests being too greedy in trying to split the platform name up
2547         causing it to try and find tests in every directory above the first "-" in the
2548         path to the LayoutTests
2549
2550         * Scripts/run-webkit-tests:
2551
2552 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
2553
2554         Reviewed by Darin.
2555
2556         http://bugs.webkit.org/show_bug.cgi?id=15006
2557         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
2558         to reduce code duplication.
2559
2560         * Scripts/build-webkit:
2561         * Scripts/webkitdirs.pm:
2562         buildQMakeProject() renamed to buildQMakeQtProject().
2563         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
2564         unused $colorize has been removed.
2565
2566 === Start merge of feature-branch 2007-10-12 ===
2567
2568 2007-10-08  Eric Seidel  <eric@webkit.org>
2569
2570         Reviewed by Mark Rowe.
2571
2572         * Scripts/build-webkit: add --help, remove unused --color
2573
2574 2007-10-07  Eric Seidel  <eric@webkit.org>
2575
2576         Reviewed by darin.
2577
2578         * Drosera/mac/DebuggerDocumentPlatform.mm:
2579         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
2580
2581 2007-10-03  Rob Buis  <buis@kde.org>
2582
2583         Reviewed by Olliej.
2584
2585         Adapt to changed location of Ahem font.
2586
2587         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2588
2589 2007-10-02  Eric Seidel  <eric@webkit.org>
2590
2591         Reviewed by Adam Roben.
2592         
2593         Make pixel tests more useful!
2594         Finally fix the image diff 0.00% mystery problem
2595         Highlight any image differences in the image diff.
2596         Add a link from image diffs back to original test file.
2597
2598         * DumpRenderTree/mac/ImageDiff.m:
2599         (compareImages): highlight any differences
2600         (computePercentageDifferent): round to two decimal places
2601         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
2602
2603 2007-10-02  Eric Seidel  <eric@webkit.org>
2604
2605         Reviewed by Alexey Proskuryakov.
2606
2607         * Scripts/run-webkit-tests: print the % image difference on main results page
2608
2609 2007-10-02  Mark Rowe  <mrowe@apple.com>
2610
2611         Reviewed by Oliver.
2612
2613         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2614
2615         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2616         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2617
2618 2007-10-01  Mark Rowe  <mrowe@apple.com>
2619
2620         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2621
2622 2007-09-25  Eric Seidel  <eric@webkit.org>
2623
2624         Reviewed by Mark Rowe.
2625         
2626         DerivedSources.make was finding "ENABLE_SVG" in the string
2627         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
2628         quite correctly.
2629
2630         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
2631
2632 2007-09-25  Mark Rowe  <mrowe@apple.com>
2633
2634         Rubber-stamped by Eric.
2635
2636         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2637         This makes it possible to automate nightly builds for the feature-branch.
2638
2639 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
2640
2641         Rubber stamped by Mark.
2642
2643         Enable svg experimental features as default here in feature-branch.
2644
2645         * Scripts/build-webkit:
2646
2647 2007-06-29  Antti Koivisto  <antti@apple.com>
2648
2649         Reviewed by Weinig.
2650         
2651         Add VIDEO flag for timed media features
2652
2653         * Scripts/build-webkit
2654         
2655 === End merge of feature-branch 2007-10-12 ===
2656
2657 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2658
2659         Reviewed by Darin.
2660
2661         - Updated rational for the leaks list to be more clear.
2662
2663         * Scripts/run-webkit-tests:
2664
2665 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2666
2667         Rubber Stamp by Sam.
2668
2669         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
2670         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
2671
2672         * Scripts/run-webkit-tests:
2673
2674 2007-10-10  Simon Hausmann  <hausmann@kde.org>
2675
2676         Reviewed by Lars.
2677
2678         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
2679         includes are needed for INT_MAX, std::auto_ptr and the like.
2680
2681         * DumpRenderTree/qt/main.cpp:
2682
2683 2007-10-09  Lars Knoll  <lars@trolltech.com>
2684
2685         Reviewed by Simon.
2686
2687         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
2688
2689         * DumpRenderTree/qt/jsobjects.cpp:
2690         (LayoutTestController::encodeHostName):
2691         (LayoutTestController::decodeHostName):
2692         * DumpRenderTree/qt/jsobjects.h:
2693
2694 2007-10-09  Lars Knoll  <lars@trolltech.com>
2695
2696         Reviewed by Simon.
2697
2698         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
2699
2700         * DumpRenderTree/qt/DumpRenderTree.cpp:
2701         (WebCore::WebPage::createFrame):
2702         (WebCore::DumpRenderTree::DumpRenderTree):
2703         (WebCore::DumpRenderTree::titleChanged):
2704         * DumpRenderTree/qt/DumpRenderTree.h:
2705         * DumpRenderTree/qt/jsobjects.cpp:
2706         (LayoutTestController::reset):
2707         * DumpRenderTree/qt/jsobjects.h:
2708
2709 2007-10-09  Lars Knoll  <lars@trolltech.com>
2710
2711         Reviewed by Simon.
2712
2713         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
2714
2715         * DumpRenderTree/qt/DumpRenderTree.h:
2716         * DumpRenderTree/qt/jsobjects.cpp:
2717         (LayoutTestController::clearBackForwardList):
2718         * DumpRenderTree/qt/jsobjects.h:
2719
2720 2007-10-09  Lars Knoll  <lars@trolltech.com>
2721
2722         Reviewed by Simon.
2723
2724         make --git-reviewer work again.
2725
2726         * Scripts/prepare-ChangeLog:
2727
2728 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
2729
2730         Rubber stamped by Eric.
2731
2732         Connect to the "hovering-over-link" signal emitted by WebKitPage and
2733         show the current link inside the statusbar.
2734         This shows how to make use of this signal and allows to easily test
2735         http://bugs.webkit.org/show_bug.cgi?id=15299.
2736
2737         * GtkLauncher/main.cpp:
2738         (hoveringOverLink):
2739         (main):
2740
2741 2007-10-05  Lars Knoll  <lars@trolltech.com>
2742
2743         add proper error messages to the FrameLoaderClient.
2744         Implement ChromeClientQt::closeWindowSoon and
2745         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
2746         Some fixes in DRT to make it work correctly with multiple windows.
2747
2748         Reviewed by Maciej.
2749
2750         * DumpRenderTree/qt/DumpRenderTree.cpp:
2751         (WebCore::DumpRenderTree::DumpRenderTree):
2752         (WebCore::DumpRenderTree::createWindow):
2753         (WebCore::DumpRenderTree::windowCount):
2754         * DumpRenderTree/qt/DumpRenderTree.h:
2755         * DumpRenderTree/qt/jsobjects.cpp:
2756         (LayoutTestController::maybeDump):
2757         (LayoutTestController::windowCount):
2758         * DumpRenderTree/qt/jsobjects.h:
2759
2760 2007-10-05  Lars Knoll  <lars@trolltech.com>
2761
2762         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
2763         Add support for layoutTextController.setCanOpenWindows() to DRT
2764         fixing another 2 test cases in fast/dom/Window.
2765
2766         Reviewed by Maciej.
2767
2768         * DumpRenderTree/qt/DumpRenderTree.cpp:
2769         (WebCore::WebPage::WebPage):
2770         (WebCore::WebPage::createWindow):
2771         (WebCore::DumpRenderTree::resetJSObjects):
2772         (WebCore::DumpRenderTree::createWindow):
2773         * DumpRenderTree/qt/DumpRenderTree.h:
2774         * DumpRenderTree/qt/DumpRenderTree.pro:
2775         * DumpRenderTree/qt/jsobjects.cpp:
2776         (LayoutTestController::LayoutTestController):
2777         (LayoutTestController::reset):
2778         * DumpRenderTree/qt/jsobjects.h:
2779         * DumpRenderTree/qt/main.cpp:
2780         * DumpRenderTree/qt/testplugin.cpp: Added.
2781         * DumpRenderTree/qt/testplugin.h: Added.
2782
2783 2007-10-04  Sam Weinig  <sam@webkit.org>
2784
2785         Rubber stamped by Adam.
2786
2787         Remove empty directories.
2788
2789         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
2790         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
2791
2792 2007-10-03  Darin Adler  <darin@apple.com>
2793
2794         Reviewed by Adam.
2795
2796         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
2797         we find the internal libraries in the libraries directory. This
2798         is helpful for Safari team engineers at Apple.
2799
2800 2007-10-03  Adam Roben  <aroben@apple.com>
2801
2802         Update the location of AHEM___.TTF after r25968
2803
2804         Reviewed by Sam.
2805
2806         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2807
2808 2007-10-03  Alp Toker  <alp@atoker.com>
2809
2810         Reviewed by Adam.
2811
2812         http://bugs.webkit.org/show_bug.cgi?id=14726
2813         [gtk] API design. Mapping the WebView delegates to signals.
2814
2815         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
2816
2817         * GtkLauncher/main.cpp:
2818         (goToURLBarText):
2819         (titleChanged):
2820         (progressChanged):
2821         (menuMainBackCallback):
2822         (menuMainForwardCallback):
2823         (main):
2824
2825 2007-10-03  Lars Knoll  <lars@trolltech.com>
2826
2827         Reviewed by Rob.
2828
2829         This fixes --strict mode in run-webkit-tests again after
2830         the platform dependent test results have been moved.
2831
2832         * Scripts/run-webkit-tests:
2833
2834 2007-10-03  Lars Knoll  <lars@trolltech.com>
2835
2836         Reviewed by bdash.
2837
2838         remove the hack in run-webkit-tests that forced text only test
2839         to be taken from the platform independent dir. It was only left
2840         there from early days.
2841         
2842         Remove platform dependent results for tests that are text only nowadays,
2843         and add one platform dependent result for a text only test that requires it.
2844
2845         * Scripts/run-webkit-tests:
2846
2847 2007-10-03  Lars Knoll  <lars@trolltech.com>
2848
2849         Reviewed by olliej.
2850
2851         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
2852
2853         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
2854         (WebCore::WebFrame::WebFrame):
2855         (WebCore::WebPage::WebPage):
2856         (WebCore::WebPage::createFrame):
2857         (WebCore::WebPage::javaScriptAlert):
2858         (WebCore::WebPage::javaScriptConsoleMessage):
2859         (WebCore::DumpRenderTree::DumpRenderTree):
2860         (WebCore::DumpRenderTree::~DumpRenderTree):
2861         (WebCore::DumpRenderTree::open):
2862         (WebCore::DumpRenderTree::readStdin):
2863         (WebCore::DumpRenderTree::resetJSObjects):
2864         (WebCore::DumpRenderTree::initJSObjects):
2865         (WebCore::DumpRenderTree::dumpFramesAsText):
2866         (WebCore::DumpRenderTree::dump):
2867         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
2868         (WebCore::DumpRenderTree::layoutTestController):
2869         (WebCore::DumpRenderTree::eventSender):
2870         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
2871         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
2872         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
2873         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
2874         (HackWebFrame::mousePressEvent):
2875         (HackWebFrame::mouseReleaseEvent):
2876         (HackWebFrame::mouseMoveEvent):
2877         (HackWebFrame::HackWebFrame):
2878         (HackWebFrame::~HackWebFrame):
2879         (LayoutTestController::LayoutTestController):
2880         (LayoutTestController::reset):
2881         (LayoutTestController::maybeDump):
2882         (LayoutTestController::waitUntilDone):
2883         (LayoutTestController::notifyDone):
2884         (LayoutTestController::dumpEditingCallbacks):
2885         (LayoutTestController::queueReload):
2886         (LayoutTestController::provisionalLoad):
2887         (LayoutTestController::timerEvent):
2888         (EventSender::EventSender):
2889         (EventSender::mouseDown):
2890         (EventSender::mouseUp):
2891         (EventSender::mouseMoveTo):
2892         (EventSender::leapForward):
2893         (EventSender::keyDown):
2894         (EventSender::frameUnderMouse):
2895         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
2896         (LayoutTestController::isLoading):
2897         (LayoutTestController::setLoading):
2898         (LayoutTestController::shouldDumpAsText):
2899         (LayoutTestController::shouldDumpChildrenAsText):
2900         (LayoutTestController::shouldWaitUntilDone):
2901         (LayoutTestController::dumpAsText):
2902         (LayoutTestController::dumpChildFramesAsText):
2903         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
2904         (messageHandler):
2905         (crashHandler):
2906         (main):
2907         * Scripts/run-webkit-tests:
2908
2909 2007-10-03  Mark Rowe  <mrowe@apple.com>
2910
2911         Reviewed by Alp Toker.
2912
2913         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
2914         should take precedence over QTDIR when determining which port we are working with.
2915
2916         * Scripts/webkitdirs.pm: 
2917
2918 2007-10-02  Adam Roben  <aroben@apple.com>
2919
2920         Add keychain to the list of default packages to install
2921
2922         Rubberstamped by Sam.
2923
2924         * CygwinDownloader/cygwin-downloader.py:
2925         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2926
2927 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
2928
2929         Reviewed by Adam.
2930
2931         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
2932         Also makes WebCore regression test case logic work when using git.
2933
2934         * Scripts/prepare-ChangeLog:
2935         (reviewerAndDescriptionForGitCommit): Added.
2936
2937 2007-10-02  Lars Knoll  <lars@trolltech.com>
2938
2939         Reviewed by bdash.
2940
2941         Add API to retrieve the frame name from QWebFrame.
2942         Implement support for DRT::dumpChildrenAsText.
2943
2944         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2945         (WebCore::DumpRenderTree::dumpFramesAsText):
2946         (WebCore::DumpRenderTree::dump):
2947         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2948         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2949         (LayoutTestController::LayoutTestController):
2950         (LayoutTestController::reset):
2951         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2952
2953 2007-10-02  Lars Knoll  <lars@trolltech.com>
2954
2955         Reviewed by bdash.
2956
2957         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
2958
2959         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2960         (WebCore::DumpRenderTree::readStdin):
2961
2962 2007-10-02  Mark Rowe  <mrowe@apple.com>
2963
2964         Reviewed by Oliver.
2965
2966         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2967
2968         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2969         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2970
2971 2007-10-02  Mark Rowe  <mrowe@apple.com>
2972
2973         Rubber-stamped by Maciej.
2974
2975         Configuration changes from build.webkit.org.  The major change is refactoring to work
2976         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
2977         last few weeks.
2978
2979         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2980         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
2981         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
2982         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
2983         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
2984         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
2985         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
2986         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
2987
2988 2007-10-02  Lars Knoll  <lars@trolltech.com>
2989
2990         Reviewed by Maciej.
2991
2992         Add support for eventSender.mouseMove to DRT.
2993         Fixes fast/css/hover-affects-child.html
2994
2995         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2996         (EventSender::mouseMoveTo):
2997
2998 2007-10-01  Mark Rowe  <mrowe@apple.com>
2999
3000         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3001
3002 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
3003
3004         Reviewed by Hyatt.
3005
3006         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
3007
3008         * Scripts/svn-apply:
3009         (gitdiff2svndiff): Ignore lines beginning with "new file".
3010         * Scripts/svn-unapply:
3011         (gitdiff2svndiff): Ditto.
3012
3013 2007-09-30  George Staikos  <staikos@kde.org>
3014
3015         Qt build fix (Mac OS X specific)
3016
3017         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
3018
3019 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
3020
3021         Reviewed by Mark.
3022
3023         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
3024         Remove Bakefiles from svn.
3025
3026         * GtkLauncher/Bakefiles.bkgen: Removed.
3027         * GtkLauncher/ENV: Removed.
3028         * GtkLauncher/gdklauncher.bkl: Removed.
3029         * GtkLauncher/mk: Removed.
3030         * Scripts/regenerate-makefiles: Removed.
3031
3032 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
3033
3034         Reviewed by John.
3035
3036         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
3037
3038         * Scripts/run-webkit-tests:
3039
3040 2007-09-26  Adam Roben  <aroben@apple.com>
3041
3042         Make not finding an installed WebKit non-fatal
3043
3044         What really matters is that we are able to load WebKit and its
3045         dependencies, not whether we think we've found an installed WebKit.
3046
3047         Reviewed by Sam.
3048
3049         * WebKitInitializer/WebKitInitializer.cpp:
3050         (getWebViewCLSID): Use new LOG_WARNING macro.
3051         (getInstalledWebKitDirectory): Ditto.
3052         (initializeWebKit): Don't die if we didn't find an installed WebKit,
3053         and use new macros.
3054         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
3055
3056 2007-09-26  Adam Roben  <aroben@apple.com>
3057
3058         Committed this file before saving it
3059
3060         * WebKitInitializer/debug_internal.vsprops:
3061
3062 2007-09-26  Adam Roben  <aroben@apple.com>
3063
3064         Load WebKit and its dependencies manually so they come from DllDirectory
3065
3066         I had to change WebKitInitializer to use malloc/free instead of
3067         new/delete to avoid pulling in WebKit (and its dependencies) early
3068         through use of fastMalloc.
3069
3070         Reviewed by Oliver.
3071
3072         * WebKitInitializer/WebKitInitializer.cpp:
3073         (getStringValue): Changed to use malloc/free.
3074         (getInstalledWebKitDirectory): Ditto.
3075         (initializeWebKit): Call SetDllDirectory first, then load all of
3076         WebKit's dependencies manually, finally followed by WebKit itself.
3077         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
3078         configuration to match our other projects.
3079         * WebKitInitializer/debug_internal.vsprops: Added.
3080
3081 2007-09-25  Adam Roben  <aroben@apple.com>
3082
3083         Actually define DEBUG/NDEBUG so that we load WebKit correctly
3084
3085         Rubberstamped by Sam.
3086
3087         * WebKitInitializer/WebKitInitializer.vcproj:
3088
3089 2007-09-25  Adam Roben  <aroben@apple.com>
3090
3091         Make DumpRenderTree delay-load its dependencies
3092
3093         This lets WebKitInitializer re-route the dependencies to be loaded out
3094         of the Safari installation directory.
3095
3096         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
3097         same thing), since we can't import the kCFAllocatorDefault symbol when
3098         delay-loading CoreFoundation.dll.
3099
3100         Rubberstamped by Sam.
3101
3102         * DumpRenderTree/win/DumpRenderTree.cpp:
3103         (runTest):
3104         (javaScriptThreads):
3105         * DumpRenderTree/win/DumpRenderTree.vcproj:
3106         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3107         (LayoutTestController::setWaitToDump):
3108
3109 2007-09-25  Adam Roben  <aroben@apple.com>
3110
3111         Pull ole32.lib into WebKitInitializer
3112
3113         Rubberstamped by Sam.
3114
3115         * WebKitInitializer/WebKitInitializer.vcproj:
3116
3117 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3118
3119         Reviewed by Adam.
3120
3121         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
3122           LGPL'ed files contain incorrect FSF address
3123
3124         * Drosera/config.h:
3125
3126 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3127
3128         Reviewed by Adam.
3129
3130         Make svn-apply and svn-unapply work with git-diff formatted patches.
3131
3132         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
3133         (gitdiff2svndiff): Added.
3134         * Scripts/svn-unapply: Ditto.
3135         (gitdiff2svndiff): Added.
3136
3137 2007-09-25  Adam Roben  <aroben@apple.com>
3138
3139         Pull advapi32.lib into WebKitInitializer
3140
3141         This is needed to get the registry functions we use.
3142
3143         Rubberstamped by Sam.
3144
3145         * WebKitInitializer/WebKitInitializer.vcproj:
3146
3147 2007-09-25  Adam Roben  <aroben@apple.com>
3148
3149         Add python and rsync to cygwin-downloader
3150
3151         Our build slaves need this, and it can't hurt for everyone else to
3152         have it, too.
3153
3154         Reviewed by Sam.
3155
3156         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
3157         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3158
3159 2007-09-25  Adam Roben  <aroben@apple.com>
3160
3161         Add WebKitInitializer and use it in DumpRenderTree
3162
3163         WebKitInitializer is a static library that has one function,
3164         initializeWebKit(). This registers WebKit and sets up the DLL search
3165         path so that WebKit's dependencies that are installed with Safari can
3166         be found.
3167
3168         Reviewed by Sam.
3169
3170         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
3171         DumpRenderTree depend on it.
3172         * DumpRenderTree/win/DumpRenderTree.cpp:
3173         (initialize): Call initializeWebKit.
3174         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
3175         WebKitInitializer.lib.
3176         * WebKitInitializer/WebKitInitializer.cpp: Added.
3177         (getStringValue):
3178         (getWebViewCLSID):
3179         (getInstalledWebKitDirectory):
3180         (initializeWebKit):
3181         * WebKitInitializer/WebKitInitializer.h: Added.
3182         * WebKitInitializer/WebKitInitializer.vcproj: Added.
3183         * WebKitInitializer/debug.vsprops: Added.
3184         * WebKitInitializer/release.vsprops: Added.
3185
3186 2007-09-25  Adam Roben  <aroben@apple.com>
3187
3188         Make run-webkit-tests respect set-webkit-configuration
3189
3190         Reviewed by Sam.
3191
3192         * Scripts/run-webkit-tests: Initialize $configuration to whatever
3193         set-webkit-configuration was last set to.
3194
3195 2007-09-25  Mark Rowe  <mrowe@apple.com>
3196
3197         Rubber-stamped by Eric.
3198
3199         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3200         This makes it possible to automate nightly builds for the feature-branch.
3201
3202 2007-09-25  Adam Roben  <aroben@apple.com>
3203
3204         A couple of fixes/enhancements to update-webkit-*-libs
3205
3206         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
3207         to tell update-webkit-support-libraries where it should find the
3208         WebKitSupportLibrary.zip file you downloaded.
3209
3210         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
3211         Windows-style path.
3212
3213         Reviewed by Sam.
3214
3215         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
3216         to $auxiliaryLibsURL and removed an irrelevant comment.
3217         * Scripts/update-webkit-support-libs:
3218
3219 2007-09-25  Adam Treat  <treat@kde.org>
3220
3221         Reviewed by Simon and Lars.
3222
3223         Refactors and cleans up Qt DRT member variable names, member variable
3224         initialization, style fixes and general code cleanup.
3225
3226         Adds queueReload slot to LayoutTestController that some tests require.
3227
3228         Subclasses QWebFrame to make sure that all frames have an associated
3229         LayoutTestController JS window object.
3230
3231         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
3232         aren't dumped twice.
3233
3234         EOF fixes.
3235
3236         Together, this patch fixes some 20+ layout tests in QtWebKit.
3237
3238         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3239         (WebCore::WebFrame::WebFrame):
3240         (WebCore::WebPage::WebPage):
3241         (WebCore::WebPage::createFrame):
3242         (WebCore::DumpRenderTree::DumpRenderTree):
3243         (WebCore::DumpRenderTree::open):
3244         (WebCore::DumpRenderTree::readStdin):
3245         (WebCore::DumpRenderTree::initJSObjects):
3246         (WebCore::DumpRenderTree::dump):
3247         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3248         (WebCore::DumpRenderTree::layoutTestController):
3249         (WebCore::DumpRenderTree::eventSender):
3250         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3251         (LayoutTestController::LayoutTestController):
3252         (LayoutTestController::reset):
3253         (LayoutTestController::maybeDump):
3254         (LayoutTestController::waitUntilDone):
3255         (LayoutTestController::notifyDone):
3256         (LayoutTestController::queueReload):
3257         (LayoutTestController::provisionalLoad):
3258         (EventSender::EventSender):
3259         (EventSender::mouseDown):
3260         (EventSender::mouseUp):
3261         (EventSender::mouseMoveTo):
3262         (EventSender::frameUnderMouse):
3263         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3264         (LayoutTestController::isLoading):
3265         (LayoutTestController::setLoading):
3266         (LayoutTestController::dumpAsText):
3267         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
3268         (main):
3269
3270 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3271
3272
3273         - Reverted an accidentally checked in file.
3274
3275         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
3276
3277 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3278         Reviewed by Sam.
3279
3280         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
3281
3282         * DumpRenderTree/win/DumpRenderTree.vcproj:
3283         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3284
3285 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3286
3287         Rubber stamped by Adam.
3288
3289         * GdkLauncher: Removed.
3290         * GdkLauncher/Bakefiles.bkgen: Removed.
3291         * GdkLauncher/ENV: Removed.
3292         * GdkLauncher/GdkLauncher.pro: Removed.
3293         * GdkLauncher/gdklauncher.bkl: Removed.
3294         * GdkLauncher/main.cpp: Removed.
3295         * GdkLauncher/mk: Removed.
3296         * GdkLauncher/simple.svg: Removed.
3297         * GdkLauncher/text.html: Removed.
3298         * GtkLauncher: Added.
3299         * GtkLauncher/GdkLauncher.pro: Removed.
3300         * GtkLauncher/GtkLauncher.pro: Added.
3301         * GtkLauncher/main.cpp:
3302         (updateWindowTitle):
3303         (main):
3304         * Scripts/build-webkit:
3305         * Scripts/regenerate-makefiles:
3306         * Scripts/run-javascriptcore-tests:
3307         * Scripts/run-launcher:
3308         * Scripts/run-webkit-tests:
3309         * Scripts/webkitdirs.pm:
3310
3311 2007-09-21  Timothy Hatcher  <timothy@apple.com>
3312
3313         Reviewed by Darin.
3314
3315         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
3316
3317         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
3318         This is tested by plugins/root-object-premature-delete-crash.html.
3319
3320         * DumpRenderTree/mac/ObjCController.m:
3321         (-[ObjCController accessStoredWebScriptObject]):
3322
3323 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
3324
3325         Reviewed by Oliver.
3326
3327         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
3328
3329         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
3330         (FrameLoadDelegate::FrameLoadDelegate):
3331
3332 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
3333
3334         Reviewed by Adam.
3335
3336         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
3337         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
3338
3339         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
3340         Now isQt() and isGdk() use global variables that are only set once.
3341
3342         An array of all the parameters is now given to build-dumprender which includes
3343         the platform on linux.
3344
3345         * Scripts/build-dumprendertree:
3346         * Scripts/run-webkit-tests:
3347         * Scripts/webkitdirs.pm:
3348
3349 2007-09-19  Adam Roben  <aroben@apple.com>
3350
3351         Rubberstamped by Hyatt.
3352
3353         * Spinneret: Removed.
3354
3355 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
3356
3357         Reviewed by David Kilzer.
3358
3359         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
3360
3361 2007-09-18  Sam Weinig  <sam@webkit.org>
3362
3363         Add JSRetainPtr.h #include to fix some builds.
3364
3365         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3366
3367 2007-09-18  Mike Hommey  <glandium@debian.org>
3368
3369         Reviewed by Adam.
3370
3371         * Scripts/prepare-ChangeLog:
3372         - Properly parse GECOS field.
3373         - Use git configuration for user name and email when appropriate.
3374
3375 2007-09-17  Sam Weinig  <sam@webkit.org>
3376
3377         Build fix.
3378
3379         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3380
3381 2007-09-17  Sam Weinig  <sam@webkit.org>
3382
3383         Reviewed by Adam Roben.
3384
3385         Share more code between mac and windows DRT.
3386             - GCController is now shared.
3387             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
3388
3389         * DumpRenderTree/GCController.cpp:
3390         * DumpRenderTree/win/DumpRenderTree.cpp:
3391         * DumpRenderTree/win/DumpRenderTree.vcproj:
3392         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
3393         (FrameLoadDelegate::FrameLoadDelegate):
3394         (FrameLoadDelegate::~FrameLoadDelegate):
3395         (FrameLoadDelegate::windowScriptObjectAvailable):
3396         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
3397         * DumpRenderTree/win/GCController.cpp: Removed.
3398         * DumpRenderTree/win/GCController.h: Removed.
3399         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
3400         (GCController::collect):
3401         (GCController::collectOnAlternateThread):
3402         (GCController::getJSObjectCount):
3403         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
3404         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
3405
3406 2007-09-17  Sam Weinig  <sam@webkit.org>
3407
3408         Reviewed by Adam Roben.
3409
3410         Begin sharing code between mac and windows DRT.
3411             - both now share LayoutTestController.h/cpp and implement platform dependant 
3412               operations in LayoutTestControllerMac/Win.
3413             - DumpRenderTree.h is now shared.
3414             - WorkQueue and WorkQueueItem are also shared.
3415
3416         * DumpRenderTree/DumpRenderTree.h:
3417         * DumpRenderTree/LayoutTestController.cpp:
3418         * DumpRenderTree/win/DumpRenderTree.cpp:
3419         (displayWebView):
3420         (dumpFrameScrollPosition):
3421         (dumpFramesAsText):
3422         (dump):
3423         (runTest):
3424         * DumpRenderTree/win/DumpRenderTree.h: Removed.
3425         * DumpRenderTree/win/DumpRenderTree.vcproj:
3426         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
3427         * DumpRenderTree/win/EditingDelegate.cpp:
3428         (EditingDelegate::shouldBeginEditingInDOMRange):
3429         (EditingDelegate::shouldEndEditingInDOMRange):
3430         (EditingDelegate::shouldInsertNode):
3431         (EditingDelegate::shouldInsertText):
3432         (EditingDelegate::shouldDeleteDOMRange):
3433         (EditingDelegate::shouldChangeSelectedDOMRange):
3434         (EditingDelegate::shouldApplyStyle):
3435         (EditingDelegate::shouldChangeTypingStyle):
3436         (EditingDelegate::doPlatformCommand):
3437         (EditingDelegate::webViewDidBeginEditing):
3438         (EditingDelegate::webViewDidChange):
3439         (EditingDelegate::webViewDidEndEditing):
3440         (EditingDelegate::webViewDidChangeTypingStyle):
3441         (EditingDelegate::webViewDidChangeSelection):
3442         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
3443         * DumpRenderTree/win/LayoutTestController.h: Removed.
3444         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
3445         (LayoutTestController::addDisallowedURL):
3446         (LayoutTestController::clearBackForwardList):
3447         (LayoutTestController::copyDecodedHostName):
3448         (LayoutTestController::copyEncodedHostName):
3449         (LayoutTestController::display):
3450         (LayoutTestController::keepWebHistory):
3451         (LayoutTestController::notifyDone):
3452         (LayoutTestController::queueBackNavigation):
3453         (LayoutTestController::queueForwardNavigation):
3454         (jsStringRefToWString):
3455         (LayoutTestController::queueLoad):
3456         (LayoutTestController::queueReload):
3457         (LayoutTestController::queueScript):
3458         (LayoutTestController::setAcceptsEditing):
3459         (LayoutTestController::setCustomPolicyDelegate):
3460         (LayoutTestController::setMainFrameIsFirstResponder):
3461         (LayoutTestController::setTabKeyCyclesThroughElements):
3462         (LayoutTestController::setUseDashboardCompatibilityMode):
3463         (LayoutTestController::setUserStyleSheetEnabled):
3464         (LayoutTestController::setUserStyleSheetLocation):
3465         (LayoutTestController::setWindowIsKey):
3466         (waitUntilDoneWatchdogFired):
3467         (LayoutTestController::setWaitToDump):
3468         (LayoutTestController::windowCount):
3469         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
3470         (FrameLoadDelegate::didReceiveTitle):
3471         (FrameLoadDelegate::processWork):
3472         (FrameLoadDelegate::locationChangeDone):
3473         (FrameLoadDelegate::windowScriptObjectAvailable):
3474         * DumpRenderTree/win/WorkQueue.cpp: Removed.
3475         * DumpRenderTree/win/WorkQueue.h: Removed.
3476         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
3477         * DumpRenderTree/win/WorkQueueItem.h: Removed.
3478         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
3479         (jsStringRefToWString):
3480         (LoadItem::invoke):
3481         (ScriptItem::invoke):
3482
3483 2007-09-17  Sam Weinig  <sam@webkit.org>
3484
3485         Reviewed by Adam Roben.
3486
3487         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
3488
3489         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
3490         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
3491         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
3492         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
3493         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
3494         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
3495         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
3496         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
3497         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
3498         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
3499         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
3500         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
3501         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
3502         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
3503         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
3504         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
3505         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
3506         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
3507         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
3508         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
3509         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
3510         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
3511         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
3512         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
3513         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
3514         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
3515         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
3516         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
3517         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
3518         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
3519         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
3520         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
3521         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
3522         * DumpRenderTree/win: Added.
3523         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
3524         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
3525         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
3526         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
3527         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
3528         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
3529         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
3530         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
3531         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
3532         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
3533         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
3534         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
3535         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
3536         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3537         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
3538         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
3539         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
3540         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
3541         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
3542         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
3543         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
3544         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
3545         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
3546         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
3547         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
3548         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
3549
3550 2007-09-15  Mark Rowe  <mrowe@apple.com>
3551
3552         Build fix for DumpRenderTree.
3553
3554         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
3555
3556 2007-09-14  Sam Weinig  <sam@webkit.org>
3557
3558         Rubber stamped by Adam Roben.
3559
3560         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
3561           - The UIDelegate was put into a new file while the FrameLoadDelegate was
3562             kept in the WaitUntilDoneDelegate file for the time being.
3563
3564         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3565         (main):
3566         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
3567         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
3568         (UIDelegate::QueryInterface):
3569         (UIDelegate::AddRef):
3570         (UIDelegate::Release):
3571         (UIDelegate::hasCustomMenuImplementation):
3572         (UIDelegate::setFrame):
3573         (UIDelegate::webViewFrame):
3574         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3575         (UIDelegate::webViewAddMessageToConsole):
3576         (UIDelegate::doDragDrop):
3577         (UIDelegate::webViewGetDlgCode):
3578         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
3579         (UIDelegate::UIDelegate):
3580         (UIDelegate::createWebViewWithRequest):
3581         (UIDelegate::webViewShow):
3582         (UIDelegate::webViewClose):