Move JavaScriptCore thread testing code to pthread specific directory
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-12-03  Sam Weinig  <sam@webkit.org>
2
3         Move JavaScriptCore thread testing code to pthread specific directory
4         and remove the dependance on CoreFoundation by using WTF::HashSet.
5
6         Reviewed by Geoff and Oliver.
7
8         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
9         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
10         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
11         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
12         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
13         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
14         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
15         * DumpRenderTree/pthreads: Added.
16         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
17         (javaScriptThreads):
18         (runJavaScriptThread):
19         (startJavaScriptThreads):
20         (stopJavaScriptThreads):
21
22 2007-12-03  Andrew Bonventre  <andybons@google.com>
23
24         Reviewed by Darin Adler.
25
26         * Drosera/debugger.js: Fixed javascript error where document property
27         should have been used instead of contentDocument in switchFunction that
28         was breaking the select symbol dropdown menu.  This is because
29         window.frames will return a Window object and not a frame object like
30         the author was originally expecting.
31
32 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
33
34         Reviewed by Adam.
35
36         - <rdar://5618942> Drosera: Console window does not process everything
37         correctly.
38         - <rdar://5619005> Drosera: could be sped up by moving the 
39         WebScriptScope stuff into the WebScriptCallFrame.
40         - Now the console can correctly process objects and does not receive
41         notifications from JavaScriptCore about the JavaScript in Drosera's
42         own process.
43
44         * Drosera/win/DebuggerDocumentPlatform.cpp:
45         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
46         (DebuggerDocument::platformValueForScopeVariableNamed):
47
48 2007-12-03  Stephanie  <slewis@apple.com>
49
50         Reviewed by Darin.
51
52         Check to see if we are building a debug root
53
54         * Scripts/check-for-global-initializers: 
55
56 2007-12-03  Dan Bernstein  <mitz@apple.com>
57
58         Reviewed by Darin Adler.
59
60         - added a testGetIntIdentifier() method to TestNetscapePlugIn
61
62         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
63         (pluginInvoke):
64
65 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
66
67         Reviewed by Oliver.
68
69         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
70         in a more fine-grained manner than eventSender.keyDown().
71
72         * DumpRenderTree/win/EventSender.cpp:
73         (getConstantCallback):
74         (dispatchMessageCallback):
75
76 2007-12-02  Darin Adler  <darin@apple.com>
77
78         * Scripts/do-webcore-rename: More planned renaming.
79
80 2007-12-02  Sam Weinig  <sam@webkit.org>
81
82         Rubber stamped by Anders.
83
84         Use [NSURL absoluteString] instead of [NSURL description] in order to get
85         more uniform results cross platform.
86
87         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
88         (-[NSURL _drt_descriptionSuitableForTestResult]):
89
90 2007-12-02  Sam Weinig  <sam@webkit.org>
91
92         Rubber stamped by Niko.
93
94         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
95
96         * DumpRenderTree/win/DumpRenderTree.cpp:
97         * DumpRenderTree/win/DumpRenderTree.vcproj:
98         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
99         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
100         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
101         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
102
103 2007-12-01  Alp Toker  <alp@atoker.com>
104
105         Reviewed by Adam Roben.
106
107         Make use of the newly introduced webkit.h convenience header.
108
109         * GtkLauncher/main.c:
110
111 2007-12-01  Adam Treat  <treat@kde.org>
112
113         Reviewed by Simon.
114
115         * Check to see if the directory exists and exit if not.
116
117         * DumpRenderTree/qt/main.cpp:
118         (main):
119
120 2007-12-01  Adam Treat  <treat@kde.org>
121
122         Reviewed by Simon.
123
124         * Don't hide symbols when in Debug mode
125         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
126
127
128         * DumpRenderTree/qt/main.cpp:
129         (messageHandler):
130
131 2007-11-30  Alp Toker  <alp@atoker.com>
132
133         Reviewed by Adam Roben.
134
135         http://bugs.webkit.org/show_bug.cgi?id=15691
136         [GTK] Public API does not follow GTK+ conventions
137
138         Refactor the WebKit/GTK+ public API. Changes:
139           WebKitPage -> WebKitWebView
140           WebKitFrame -> WebKitWebFrame
141
142         Public API source and header names have been updated to mirror the API
143         changes.
144
145         The API is now kept in WebKit/gtk/WebView to match other ports in the
146         same class such as Mac and Win.
147
148         * GtkLauncher/main.c:
149         (activate_uri_entry_cb):
150         (link_hover_cb):
151         (title_change_cb):
152         (progress_change_cb):
153         (go_back_cb):
154         (go_forward_cb):
155         (create_browser):
156         (main):
157
158 2007-11-30  Adam Roben  <aroben@apple.com>
159
160         Hopefully the final build fix
161
162         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
163         pull in WTF's assertion/logging functions.
164
165 2007-11-30  Adam Roben  <aroben@apple.com>
166
167         Another build fix
168
169         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
170         WebKit.lib.
171
172 2007-11-30  Adam Roben  <aroben@apple.com>
173
174         Debug build fix
175
176         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
177         configuration.
178         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
179         projects.
180         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
181         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
182         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
183
184 2007-11-30  Sam Weinig  <sam@webkit.org>
185
186         Reviewed by Adam Roben.
187
188         Fix drawSelectionRect to actually draw the selection rect.
189
190         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
191         (drawSelectionRect):
192
193 2007-11-30  Darin Adler  <darin@apple.com>
194
195         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
196
197 2007-11-30  Darin Adler  <darin@apple.com>
198
199         * Scripts/do-webcore-rename: Get ready for some future renaming.
200
201 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
202
203         Reviewed by Adam.
204
205         - Removed some unnecessary functions and changed an unused return type. 
206
207         * Drosera/win/DebuggerClient.cpp:
208         (registerConsoleClass):
209         * Drosera/win/DebuggerClient.h:
210         * Drosera/win/Drosera.cpp:
211         (registerDroseraClass):
212
213 2007-11-28  Alp Toker  <alp@atoker.com>
214
215         Reviewed by Timothy Hatcher.
216
217         http://bugs.webkit.org/show_bug.cgi?id=16174
218         [GTK] Use "URI" not "URL" in public API
219
220         Replace use of the term "URL" with "URI" in public headers,
221         documentation and some internal code to match GLib/GTK+ convention.
222
223         This is now mentioned in the API guidelines:
224           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
225
226         * GtkLauncher/main.c:
227         (activate_uri_entry_cb):
228         (title_change_cb):
229         (create_toolbar):
230         (main):
231
232 2007-11-29  Anders Carlsson  <andersca@apple.com>
233
234         Reviewed by Sam.
235
236         <rdar://problem/5230478>
237         FrameLoadDelegate callbacks are not dumped in DRT.
238         
239         * DumpRenderTree/win/DumpRenderTree.cpp:
240         (shouldLogFrameLoadDelegates):
241         (runTest):
242         (main):
243         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
244         (BSTRtoString):
245         (descriptionSuitableForTestResult):
246         (FrameLoadDelegate::QueryInterface):
247         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
248         (FrameLoadDelegate::didFailProvisionalLoadWithError):
249         (FrameLoadDelegate::didCommitLoadForFrame):
250         (FrameLoadDelegate::didFinishLoadForFrame):
251         (FrameLoadDelegate::willCloseFrame):
252         (FrameLoadDelegate::didClearWindowObject):
253         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
254         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
255         * DumpRenderTree/win/FrameLoaderDelegate.h:
256         (FrameLoadDelegate::windowScriptObjectAvailable):
257         (FrameLoadDelegate::didFirstLayoutInFrame):
258
259 2007-11-29  Sam Weinig  <sam@webkit.org>
260
261         Reviewed by Anders.
262
263         Add database quota UIDelegates methods to DRT UIDelegate.
264
265         * DumpRenderTree/mac/UIDelegate.mm:
266         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
267         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
268
269 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
270
271         Reviewed by Sam.
272
273         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
274         dying and vice versa.
275         - This fix will allow Drosera and Safari to reconnect if either of them
276         closes correctly, but does not fix the case where one of them dies
277         silently.
278
279         * Drosera/win/ServerConnection.cpp:
280         (ServerConnection::attemptToCreateServerConnection): Added a safety
281         check, because it's possilbe to try to connect to a server that's dying.
282         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
283         the server has died.
284         * Drosera/win/ServerConnection.h: Added the new function and removed
285         an unnecessary member.
286
287 2007-11-29  Anders Carlsson  <andersca@apple.com>
288
289         * DumpRenderTree/win/DumpRenderTree.vcproj:
290         Add shlwapi.lib to all configurations.
291
292 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
293
294         - Build fix.  Added additional includes for VS Express to the Release
295         project.
296
297         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
298
299 2007-11-29  Anders Carlsson  <andersca@apple.com>
300
301         Reviewed by Adam.
302
303         <rdar://problem/5132005>
304         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
305         
306         * DumpRenderTree/win/DumpRenderTree.vcproj:
307         Add shlwapi.lib
308         
309         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
310         (LayoutTestController::setUserStyleSheetEnabled):
311         Implement this.
312         
313         (appendComponentToPath):
314         New method which wraps the Win32 API PathAppend.
315         
316         (followShortcuts):
317         New method which checks if a file points to a shortcut and
318         follows the shortcut.
319         
320         (resolveCygwinPath):
321         New method that takes a cygwin unix-style path and returns the Win32 path.
322         
323         (cfStringRefToWString):
324         
325         (LayoutTestController::setUserStyleSheetLocation):
326         Implement this.
327
328 2007-11-29  Alice Liu  <alice.liu@apple.com>
329
330         Reviewed by Adam.
331
332         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
333
334         * DumpRenderTree/win/EventSender.cpp:
335         (keyDownCallback):
336         uppercase letters were being sent as lowercase letters without the shift key down.
337
338 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
339
340         - Windows build fix. VS express needs some love.
341
342         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
343
344 2007-11-28  Darin Adler  <darin@apple.com>
345
346         Reviewed by Adam Roben.
347
348         * DumpRenderTree/mac/EventSendingController.mm:
349         (-[EventSendingController keyDown:withModifiers:]):
350         Send capital letters through as lowercase letters with the shift key down
351         rather than sending them as if they were highly unusual "capital letter keys".
352
353         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
354         where you need to update results and more tests are failing than before.
355
356 2007-11-28  Anders Carlsson  <andersca@apple.com>
357
358         Reviewed by Darin.
359
360         <rdar://problem/5132001>
361         contextClick is not implemented in DRT on Windows.
362         
363         * DumpRenderTree/win/EventSender.cpp:
364         (contextClickCallback):
365         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
366         by a WM_RBUTTONUP message.
367         
368         * DumpRenderTree/win/UIDelegate.cpp:
369         (UIDelegate::hasCustomMenuImplementation):
370         (UIDelegate::trackCustomPopupMenu):
371         * DumpRenderTree/win/UIDelegate.h:
372         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
373         menu from being shown (and causing the DRT to hang).
374
375 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
376
377         Reviewed by Darin.
378
379         Fix DumpRenderTree ObjC bug comparing strings.
380
381         * DumpRenderTree/mac/ObjCController.m:
382         (-[ObjCController identityIsEqual::]): Compare strings with string
383         equality instead of identiy equality.
384
385 2007-11-27  Timothy Hatcher  <timothy@apple.com>
386
387         Reviewed by Sam.
388
389         Reset the authorAndUserStylesEnabled preference
390         back to YES for each test. Fixes the broken tests.
391
392         * DumpRenderTree/mac/DumpRenderTree.mm:
393         (resetWebViewToConsistentStateBeforeTesting):
394
395 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
396
397         Reviewed by Adam.
398
399         - Drosera now displays the console window, although it cannot currently
400         process JavaScript.
401
402         * Drosera/win/DebuggerClient.cpp: Shows the console window.
403         (registerConsoleClass): Implemented.
404         (consoleWndProc): Implemented.
405         (DebuggerClient::onSize): Implemented.
406         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
407         new window.
408         * Drosera/win/DebuggerClient.h: Added needed method and members for 
409         creating and maintaining a new window.
410         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
411         lines of code to more appropriate places.
412         (Drosera::handleCommand):
413         (Drosera::initUI):
414         (Drosera::onSize):
415         (Drosera::attach):
416
417 2007-11-27  Timothy Hatcher  <timothy@apple.com>
418
419         Reviewed by Dave Hyatt.
420
421         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
422         
423         Add support for disabling author and user styles for testing.
424
425         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
426         * DumpRenderTree/LayoutTestController.cpp:
427         (setAuthorAndUserStylesEnabledCallback):
428         (LayoutTestController::staticFunctions):
429         * DumpRenderTree/LayoutTestController.h:
430         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
431         (LayoutTestController::setAuthorAndUserStylesEnabled):
432         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
433         (LayoutTestController::setAuthorAndUserStylesEnabled):
434
435 2007-11-26  Dan Bernstein  <mitz@apple.com>
436
437         - Tiger build fix.
438
439         * DumpRenderTree/mac/Configurations/Base.xcconfig:
440
441 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
442
443         Reviewed by Maciej.
444
445         - Implemented displaying variables for Drosera on Win.
446
447         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
448         that retrieve variables to not hold onto the return value since it's
449         not returned.  Also changed to use the new signatures of the retrieval
450         functions.
451         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
452         (DebuggerDocument::platformValueForScopeVariableNamed):
453         * Drosera/win/Drosera.cpp: Removed a needless TODO.
454         (droseraWndProc):
455
456 2007-11-26  Sam Weinig  <sam@webkit.org>
457
458         Cleanup names of painting and repainting functions.
459
460         Reviewed by Adam Roben.
461
462         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
463         (drawSelectionRect): was drawSelectionRectIntoContext.
464         (dumpWebViewAsPixelsAndCompareWithExpected):
465         * DumpRenderTree/cg/PixelDumpSupportCG.h:
466         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
467         (paintWebView): was drawWebViewIntoContext.
468         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
469
470 2007-11-26  Sam Weinig  <sam@webkit.org>
471
472         Reviewed by Dan Bernstein.
473
474         - Leopard build fix
475
476         * DumpRenderTree/mac/Configurations/Base.xcconfig:
477
478 2007-11-26  Sam Weinig  <sam@webkit.org>
479
480         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
481         Use shared PixelDumpSupport for Mac DRT
482
483         Reviewed by Adam Roben.
484
485         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
486         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
487         * DumpRenderTree/cg/ImageDiffCG.cpp:
488         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
489         (drawSelectionRectIntoContext):
490         (dumpWebViewAsPixelsAndCompareWithExpected):
491         * DumpRenderTree/cg/PixelDumpSupportCG.h:
492         * DumpRenderTree/mac/Configurations/Base.xcconfig:
493         * DumpRenderTree/mac/DumpRenderTree.mm:
494         (dump):
495         * DumpRenderTree/mac/ImageDiff.m: Removed.
496         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
497         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
498         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
499         (setDefaultColorProfileToRGB):
500         (getBitmapContextFromWebView):
501         (drawWebViewIntoContext):
502         (repaintWithVerticalSweep):
503         (repaintWithHorizontalSweep):
504         (getSelectionRect):
505         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
506
507 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
508
509         Bug 16052: prepare-ChangeLog doesn't report deleted files
510         <http://bugs.webkit.org/show_bug.cgi?id=16052>
511
512         Reviewed by Sam.
513
514         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
515
516 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
517
518         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
519         <http://bugs.webkit.org/show_bug.cgi?id=15864>
520
521         Reviewed by Adam.
522
523         Roll functionality of merge-changelog into resolve-ChangeLogs
524         script.  The script now checks for ChangeLog.rej and
525         ChangeLog.orig files first.  If it finds them, it uses the
526         ChangeLog.rej file as a patch (in old contextual diff format) to
527         apply with --fuzz=3.
528
529         * Scripts/merge-changelog: Removed.
530         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
531
532 2007-11-25  Sam Weinig  <sam@webkit.org>
533
534         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
535
536         Reviewed by Mark Rowe.
537
538         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
539         * DumpRenderTree/mac/Configurations/Base.xcconfig:
540         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
541         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
542         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
543
544 2007-11-25  Sam Weinig  <sam@webkit.org>
545
546         Convert DumpRenderTree to ues .xcconfig files.
547
548         Reviewed by Mark Rowe.
549
550         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
551         * DumpRenderTree/mac/Configurations: Added.
552         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
553         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
554         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
555
556 2007-11-25  Sam Weinig  <sam@webkit.org>
557
558         Add ForwardingHeaders to wtf for DumpRenderTree.
559
560         Reviewed by Mark Rowe.
561
562         * DumpRenderTree/DumpRenderTree.h:
563         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
564         * DumpRenderTree/ForwardingHeaders: Added.
565         * DumpRenderTree/ForwardingHeaders/wtf: Added.
566         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
567         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
568         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
569         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
570         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
571         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
572         * DumpRenderTree/LayoutTestController.cpp:
573         * DumpRenderTree/WorkQueue.cpp:
574         * DumpRenderTree/mac/DumpRenderTree.mm:
575         * DumpRenderTree/mac/FrameLoadDelegate.mm:
576         * DumpRenderTree/mac/JavaScriptThreading.cpp:
577         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
578         * DumpRenderTree/mac/ObjCController.m:
579         * DumpRenderTree/mac/UIDelegate.mm:
580         * DumpRenderTree/mac/WorkQueueItemMac.mm:
581
582 2007-11-25  Adam Roben  <aroben@apple.com>
583
584         Fix some test failures caused by r28019
585
586         Now that stdout is in binary mode, we need to always use printf
587         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
588         the output.
589
590         Reviewed by Sam.
591
592         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
593         printf.
594         (UIDelegate::runJavaScriptAlertPanelWithMessage):
595         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
596         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
597         (UIDelegate::webViewAddMessageToConsole):
598
599 2007-11-25  Adam Roben  <aroben@apple.com>
600
601         Set the font smoothing preference in DRT
602
603         This makes the pixel results on Windows closer to the Mac results.
604
605         Reviewed by Mitz.
606
607         * DumpRenderTree/win/DumpRenderTree.cpp:
608         (initializePreferences):
609
610 2007-11-25  Adam Roben  <aroben@apple.com>
611
612         Port ImageDiff to CG and C++
613
614         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
615         <rdar://5071708>
616
617         Reviewed by Sam.
618
619         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
620         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
621         (main):
622         (createImageFromStdin):
623         (compareImages):
624         (getDifferenceBitmap):
625         (computePercentageDifferent):
626         * DumpRenderTree/win/ImageDiff.vcproj: Added.
627
628 2007-11-25  Adam Roben  <aroben@apple.com>
629
630         Fix image diff link generation on Windows
631
632         Reviewed by Sam.
633
634         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
635         to toURL.
636
637 2007-11-25  Adam Roben  <aroben@apple.com>
638
639         Implement pixel dumping in Windows DRT
640
641         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
642         <rdar://5071708>
643
644         Reviewed by Sam.
645
646         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
647         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
648         Content-Length header.
649         (getMD5HashStringForBitmap):
650         (dumpWebViewAsPixelsAndCompareWithExpected):
651         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
652         * DumpRenderTree/win/DumpRenderTree.cpp:
653         (dump): Do a pixel dump if requested.
654         (main): Parse pixel test options.
655         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
656         the cg/ subdirectory to the include path.
657         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
658         available in a header or import library, so we have to go through this
659         LoadLibrary/GetProcAddress dance to use them.
660         (cryptDLL):
661         (init):
662         (update):
663         (final):
664         (MD5_Init):
665         (MD5_Update):
666         (MD5_Final):
667         * DumpRenderTree/win/MD5.h: Added.
668         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
669         moved up to the top level to share it with Mac eventually.
670         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
671         (getBitmapContextFromWebView): Forces the WebView to paint using a
672         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
673
674 2007-11-25  Adam Roben  <aroben@apple.com>
675
676         Clean up Windows DRT's option parsing a little bit
677
678         Reviewed by Sam.
679
680         * DumpRenderTree/win/DumpRenderTree.cpp:
681         (main): Put non-option arguments into a Vector.
682
683 2007-11-25  Adam Roben  <aroben@apple.com>
684
685         Make Windows DRT stop changing LF into CRLF
686
687         Reviewed by Sam.
688
689         * DumpRenderTree/win/DumpRenderTree.cpp:
690         (main): Put stdout in binary mode.
691         * Scripts/run-webkit-tests: Remove the CRLF hack.
692
693 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
694
695         Removed empty directory.
696
697         * Scripts/resources: Removed.
698
699 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
700
701         Fix bisect-builds to work with recent WebKit nightly builds.
702
703         Reviewed by Dan.
704
705         * Scripts/bisect-builds: Check for the 
706         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
707         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
708         to WebKit.app/Contents/Resources.
709
710 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
711
712         Reviewed by Maciej.
713
714         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
715         not closed (affects digg.com)
716
717         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
718         one after finishing with a test to avoid having its delayed onload handler firing when
719         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
720         but it helps somewhat.
721
722 2007-11-22  Mark Rowe  <mrowe@apple.com>
723
724         Reviewed by Alp Toker.
725
726         Fix build-webkit to propagate make's exit status if it fails.
727
728         * Scripts/webkitdirs.pm:
729
730 2007-11-22  Dan Bernstein  <mitz@apple.com>
731
732         Reviewed by Mark Rowe.
733
734         - fix crash when running pixel tests
735
736         * DumpRenderTree/mac/DumpRenderTree.mm:
737         (dumpRenderTree): Parse the command line options before setting up the
738         environment so that we know if we need to set up the pixel dump
739         machinery.
740
741 2007-11-21  Eric Seidel  <eric@webkit.org>
742
743         Speculative build fix for Tiger.
744
745         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
746
747 2007-11-21  Eric Seidel  <eric@webkit.org>
748
749         Reviewed by Tim Hatcher.
750
751         Break out more of DumpRenderTree.mm into individual files
752
753         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
754         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
755         (checkedMalloc):
756         (checkedRealloc):
757         (makeLargeMallocFailSilently):
758         * DumpRenderTree/mac/CheckedMalloc.h: Added.
759         * DumpRenderTree/mac/DumpRenderTree.mm:
760         (crashHandler):
761         (dump):
762         * DumpRenderTree/mac/DumpRenderTreeMac.h:
763         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
764         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
765         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
766         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
767         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
768         (javaScriptThreads):
769         (runJavaScriptThread):
770         (startJavaScriptThreads):
771         (stopJavaScriptThreads):
772         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
773         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
774         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
775         (restoreColorSpace):
776         (setDefaultColorProfileToRGB):
777         (initializeColorSpaceAndScreeBufferForPixelTests):
778         (md5HashStringForBitmap):
779         (dumpWebViewAsPixelsAndCompareWithExpected):
780
781 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
782
783         Move install-unix-extras to wx directory as it seems only to be used by that 
784         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
785         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
786         have install-unix-extras install into WebKitLibraries as per
787         convention.
788         
789         Reviewed by Mark Rowe.
790
791         * Scripts/install-unix-extras: Removed.
792         * wx/build-wxwebkit:
793         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
794
795 2007-11-21  Eric Seidel  <eric@webkit.org>
796
797         Reviewed by Adam.
798
799         More refactoring for greater code readability
800
801         * DumpRenderTree/mac/DumpRenderTree.mm:
802         (initializeGlobalsFromCommandLineOptions):
803         (initializeColorSpaceAndScreeBufferForPixelTests):
804         (addTestPluginsToPluginSearchPath):
805         (useLongRunningServerMode):
806         (runTestingServerLoop):
807         (prepareConsistentTestingEnvironment):
808         (dumpRenderTree):
809         (main):
810         (dumpFramesAsText):
811         (dumpBackForwardListForWebView):
812         (sizeWebViewForCurrentTest):
813         (methodNameStringForFailedTest):
814         (dumpBackForwardListForAllWindows):
815         (dumpWebViewAsPixelsAndCompareWithExpected):
816         (invalidateAnyPreviousWaitToDumpWatchdog):
817         (dump):
818         * DumpRenderTree/mac/DumpRenderTreeMac.h:
819         * DumpRenderTree/mac/UIDelegate.mm:
820         (-[UIDelegate webView:createWebViewWithRequest:]):
821
822 2007-11-21  Eric Seidel  <eric@webkit.org>
823
824         Reviewed by Tim Hatcher.
825
826         Abstract more of DRT into static methods
827
828         * DumpRenderTree/mac/DumpRenderTree.mm:
829         (setDefaultsToConsistentValuesForTesting):
830         (setupSignalHandlers):
831         (allocateGlobalControllers):
832         (releaseAndZero):
833         (releaseGlobalControllers):
834         (dumpRenderTree):
835         (shouldLogFrameLoadDelegates):
836         (createCFURLFromPathOrURL):
837         (resetWebViewToConsistentStateBeforeTesting):
838         (runTest):
839
840 2007-11-21  Eric Seidel  <eric@webkit.org>
841
842         Reviewed by Tim Hatcher.
843
844         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
845
846         * DumpRenderTree/DumpRenderTree.h:
847         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
848         * DumpRenderTree/mac/DumpRenderTree.mm:
849         (dumpRenderTree):
850         (dump):
851         (runTest):
852         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
853         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
854         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
855         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
856         (-[DumpRenderTreePasteboard declareType:owner:]):
857         (+[LocalPasteboard alloc]):
858         (-[LocalPasteboard init]):
859         (-[LocalPasteboard dealloc]):
860         (-[LocalPasteboard name]):
861         (-[LocalPasteboard releaseGlobally]):
862         (-[LocalPasteboard declareTypes:owner:]):
863         (-[LocalPasteboard addTypes:owner:]):
864         (-[LocalPasteboard changeCount]):
865         (-[LocalPasteboard types]):
866         (-[LocalPasteboard availableTypeFromArray:]):
867         (-[LocalPasteboard setData:forType:]):
868         (-[LocalPasteboard dataForType:]):
869         (-[LocalPasteboard setPropertyList:forType:]):
870         (-[LocalPasteboard setString:forType:]):
871         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
872         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
873         (+[DumpRenderTreeWindow allWindows]):
874         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
875         (-[DumpRenderTreeWindow dealloc]):
876         (-[DumpRenderTreeWindow isKeyWindow]):
877         (-[DumpRenderTreeWindow keyDown:]):
878
879 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
880
881         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
882         it indiscriminately copies any headers inside JavaScriptCore,
883         which includes Tiger ICU headers. 
884
885         * wx/build-wxwebkit:
886         Don't run WebCore/move-js-headers.sh any longer.
887
888 2007-11-20  Adam Treat  <treat@kde.org>
889
890         Reviewed by David Kilzer.
891
892         * Prepend git branch name to $baseProductDir
893
894         * Scripts/VCSUtils.pm:
895         * Scripts/webkitdirs.pm:
896
897 2007-11-20  Mark Rowe  <mrowe@apple.com>
898
899         Reviewed by Simon Hausmann.
900
901         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
902         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
903         Have it trigger a "make distclean" rather than "make clean" to ensure that the
904         built product and generated Makefile's are removed.
905
906 2007-11-19  Alp Toker  <alp@atoker.com>
907
908         Reviewed by Mark Rowe.
909
910         http://bugs.webkit.org/show_bug.cgi?id=16040
911         [GTK] GtkLauncher should be written in C
912
913         Port GtkLauncher to plain C.
914
915         Use a more conventional GTK+ coding style.
916
917         Use a toolbar instead of menus.
918
919         Various signature fixes and cleanups.
920
921         Add a license header. Assume all previous modifications were copyright
922         assigned to Apple Inc. by default.
923
924         * GtkLauncher/GtkLauncher.pro:
925         * GtkLauncher/main.c: Added.
926         (activate_url_entry_cb):
927         (update_title):
928         (link_hover_cb):
929         (title_change_cb):
930         (progress_change_cb):
931         (destroy_cb):
932         (go_back_cb):
933         (go_forward_cb):
934         (create_browser):
935         (create_statusbar):
936         (create_toolbar):
937         (create_window):
938         (main):
939         * GtkLauncher/main.cpp: Removed.
940
941 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
942
943         Build script fixes to ensure they do the right thing for the 
944         wx port, and update build-wxwebkit to reflect the way the
945         build scripts now work.
946
947         Reviewed by Adam.
948
949         * Scripts/build-testkjs:
950         * Scripts/build-webkit:
951         * Scripts/run-javascriptcore-tests:
952         * Scripts/webkitdirs.pm:
953         * wx/build-wxwebkit:
954
955 2007-11-18  Eric Seidel  <eric@webkit.org>
956
957         Reviewed by Anders.
958
959         Make run-javascriptcore-tests report failures on exit (to support git bisect)
960
961         * Scripts/run-javascriptcore-tests:
962
963 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
964
965         Reviewed by Adam Roben.
966
967         Make run-webkit-tests work with Windows debug build.
968
969         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
970         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
971         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
972         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
973         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
974
975 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
976
977         Add wxWebKit sample and build script, and integrate it with 
978         build-webkit. Also make build-webkit --clean work for all
979         ports.
980
981         Reviewed by Darin Adler.
982
983         * Scripts/build-webkit:
984         * Scripts/webkitdirs.pm:
985         * wx: Added.
986         * wx/browser: Added.
987         * wx/browser/browser.bkl: Added.
988         * wx/browser/browser.cpp: Added.
989         * wx/build-wxwebkit: Added.
990
991 2007-11-17  Adam Roben  <aroben@apple.com>
992
993         Make it easy to run Safari in the debugger on Windows
994
995         I've added a new script, debug-safari, which launches Safari in the
996         debugger. On OS X it just calls gdb-safari.
997
998         Reviewed by Mark Rowe.
999
1000         * FindSafari/FindSafari.cpp:
1001         (_tmain): Added a /debugger flag, which in combination with
1002         /printSafariLauncher will print a script that launches Safari in the
1003         debugger.
1004         * Scripts/debug-safari: Added.
1005         * Scripts/run-safari: Changed to call runSafari().
1006         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1007         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1008         first argument along to FindSafari.
1009         * Scripts/webkitdirs.pm:
1010         (sub runSafari): Added.
1011
1012 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1013
1014         Reviewed by Adam Roben.
1015
1016         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
1017
1018 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1019
1020         Reviewed by David Kilzer.
1021
1022         The git config command was renamed to repo-config at some point. This
1023         change tries git config and then git repo-config if the first fails.
1024
1025         * Scripts/prepare-ChangeLog:
1026         (gitConfig):
1027
1028 2007-11-16  Dan Bernstein  <mitz@apple.com>
1029
1030         Reviewed by Darin Adler and Sam Weinig.
1031
1032         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1033
1034         * DumpRenderTree/win/EventSender.cpp:
1035         (keyDownCallback): For characters that cannot be entered on the active
1036         keyboard layout, send a WM_CHAR message with the character along with
1037         a WM_KEYDOWN message with a virtual key code of 255.
1038
1039 2007-11-16  Mark Rowe  <mrowe@apple.com>
1040
1041         Reviewed by Tim Hatcher.
1042
1043         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1044
1045         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1046         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1047
1048 2007-11-15  Adam Roben  <aroben@apple.com>
1049
1050         Make run-safari actually work on Windows
1051
1052         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1053         chdir call.
1054
1055 2007-11-14  Adam Roben  <aroben@apple.com>
1056
1057         Updates to Safari launching now that 3.0.4 is released
1058
1059         Reviewed by Sam.
1060
1061         * FindSafari/FindSafari.cpp:
1062         (getWebViewCLSID): Use version-independent ProgID.
1063         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1064
1065 2007-11-14  Anders Carlsson  <andersca@apple.com>
1066
1067         Reviewed by Adam.
1068
1069         <rdar://problem/5309081>
1070         In DRT, "plugin.logDestroy = true" not working on Windows.
1071         
1072         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1073         (NPP_Destroy):
1074
1075 2007-11-14  Eric Seidel  <eric@webkit.org>
1076
1077         Reviewed by Sam.
1078
1079         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1080
1081 2007-11-14  Anders Carlsson  <andersca@apple.com>
1082
1083         Reviewed by Adam.
1084
1085         <rdar://problem/5141186>
1086         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1087         
1088         Implement setWindowIsKey.
1089         
1090         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1091         (LayoutTestController::setWindowIsKey):
1092
1093 2007-11-13  Sam Weinig  <sam@webkit.org>
1094
1095         Reviewed by Adam Roben.
1096
1097         Fix for <rdar://problem/5382579>
1098         http/tests/security/cross-frame-access-put.html reports large 
1099         negative numbers for screenLeft and screenTop (Mac reports "0")
1100
1101         * DumpRenderTree/win/UIDelegate.cpp:
1102         (UIDelegate::UIDelegate): Initialize the RECT.
1103         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1104         (UIDelegate::webViewFrame): ditto.
1105         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1106
1107 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1108
1109         Reviewed by Adam.
1110
1111         - Make Drosera show source, source URLs, and function stack on Windows,
1112         and some minor fixes.
1113
1114         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1115         (DebuggerDocument::updateFileSource):
1116         * Drosera/debugger.js: Force source to always update display.
1117         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1118         menu controls.
1119         (DebuggerClient::resume):
1120         (DebuggerClient::pause):
1121         (DebuggerClient::stepInto):
1122         (DebuggerClient::stepOver):
1123         (DebuggerClient::stepOut):
1124         (DebuggerClient::showConsole):
1125         (DebuggerClient::closeCurrentFile):
1126         * Drosera/win/DebuggerClient.h: Ditto.
1127         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1128         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1129         removed two bugs.  1) caller could be in a bad state when asked to
1130         assign into it. 2) BSTRs were not created correctly.
1131         (DebuggerDocument::getPlatformCurrentFunctionStack):
1132         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1133         (droseraWndProc):
1134         (handleCommand):
1135         (Drosera::resume):
1136         (Drosera::pause):
1137         (Drosera::stepInto):
1138         (Drosera::stepOver):
1139         (Drosera::stepOut):
1140         (Drosera::showConsole):
1141         (Drosera::closeCurrentFile):
1142         * Drosera/win/Drosera.h: Hook up the menu controls.
1143         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1144         functions, added a null check, and fixed another bug where caller could
1145         be in a bad state when asked to assign into it.
1146         (ServerConnection::didLoadMainResourceForDataSource):
1147         (ServerConnection::getCallerFrame):
1148         * Drosera/win/ServerConnection.h: Safety first.
1149
1150 2007-11-13  Dan Bernstein  <mitz@apple.com>
1151
1152         Reviewed by Darin Adler.
1153
1154         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1155           DumpRenderTree --pixel-tests renders each test twice
1156
1157         * DumpRenderTree/mac/DumpRenderTree.mm:
1158         (dumpRenderTree): Removed the --paint option because the painting code
1159         is always exercised as a result of
1160         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1161         calling -displayIfNeeded.
1162         (dump): Changed to always grab the image from the window since the view
1163         is always displayed.
1164         (runTest):
1165         (displayWebView):
1166         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1167         because it always paints.
1168
1169 2007-11-12  Antti Koivisto  <antti@apple.com>
1170
1171         Reviewed by Adele.
1172         
1173         Add support for http media tests
1174
1175         * Scripts/run-webkit-tests:
1176
1177 2007-11-12  Sam Weinig  <sam@webkit.org>
1178
1179         Reviewed by Adam Roben.
1180
1181         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1182
1183         * DumpRenderTree/win/DumpRenderTree.cpp:
1184         (runTest):
1185         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1186         (LayoutTestController::setPrivateBrowsingEnabled):
1187
1188 2007-11-12  Adam Roben  <aroben@apple.com>
1189
1190         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1191         mac and win subdirectories.
1192
1193 2007-11-11  Adam Roben  <aroben@apple.com>
1194
1195         Fix <rdar://5133816> keepWebHistory is not implemented
1196
1197         Fixes fast/history/clicked-link-is-visited.html.
1198
1199         Reviewed by Darin.
1200
1201         * DumpRenderTree/win/DumpRenderTree.cpp:
1202         (runTest): Clear the optionalSharedHistory.
1203         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1204         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1205
1206 2007-11-10  Sam Weinig  <sam@webkit.org>
1207
1208         Reviewed by Tim Hatcher.
1209
1210         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1211         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1212         is turned on)
1213
1214         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1215
1216         Added test: http/tests/security/cross-frame-access-private-browsing.html
1217
1218         * DumpRenderTree/LayoutTestController.cpp:
1219         (setPrivateBrowsingEnabledCallback):
1220         (LayoutTestController::staticFunctions):
1221         * DumpRenderTree/LayoutTestController.h:
1222         * DumpRenderTree/mac/DumpRenderTree.mm:
1223         (runTest): Default to private browsing disabled.
1224         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1225         (LayoutTestController::setPrivateBrowsingEnabled):
1226         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1227         (LayoutTestController::setPrivateBrowsingEnabled):
1228
1229 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1230
1231         Reviewed by Adam.
1232
1233         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1234         WebCore's!
1235
1236         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1237         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1238         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1239         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1240         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1241         * Drosera/win/Drosera.cpp:
1242         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1243
1244 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1245
1246         Reviewed by Sam.
1247
1248         - Use the new IWebFrame [local] function signature and get the shared
1249         server correctly.
1250
1251         * Drosera/win/DebuggerClient.cpp:
1252         (DebuggerClient::didFinishLoadForFrame):
1253         * Drosera/win/ServerConnection.cpp:
1254         (ServerConnection::attemptToCreateServerConnection):
1255
1256 2007-11-07  Dan Bernstein  <mitz@apple.com>
1257
1258         Reviewed by Darin Adler.
1259
1260         - add an option to run-webkit-tests to ignore pixel test failures where
1261           all pixels differ by no more than a specified threshold
1262
1263         * DumpRenderTree/mac/ImageDiff.m:
1264         (main):
1265         (compareImages):
1266         (computePercentageDifferent):
1267         * Scripts/run-webkit-tests:
1268
1269 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1270
1271         Reviewed by Lars.
1272
1273         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1274
1275         * DumpRenderTree/qt/DumpRenderTree.cpp:
1276
1277 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1278
1279         Reviewed by Lars.
1280
1281         Reworked the QWebSettings API.
1282         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1283
1284         * DumpRenderTree/qt/DumpRenderTree.cpp:
1285
1286 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1287
1288         Reviewed by Lars.
1289
1290         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1291
1292         * DumpRenderTree/qt/jsobjects.cpp:
1293
1294 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1295
1296         Reviewed by Lars Knoll <lars@trolltech.com>.
1297
1298         Add a QWebPage::frameCreated() signal and fix DRT
1299         
1300         The removal of createFrame in QWebPage broke the re-implementation
1301         in DumpRenderTree. Instead emit a frameCreated() signal and
1302         connect to it in DumpRenderTree.
1303         
1304
1305         * DumpRenderTree/qt/DumpRenderTree.cpp:
1306         (WebCore::WebPage::WebPage):
1307         (WebCore::DumpRenderTree::dump):
1308         (WebCore::DumpRenderTree::connectFrame):
1309         * DumpRenderTree/qt/DumpRenderTree.h:
1310
1311 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1312
1313         Reviewed by Lars Knoll <lars@trolltech.com>.
1314
1315         Moved all the event handlers from QWebFrame into QWebPage.
1316         
1317         This cleans up the public API and allows us to remove the
1318         HackWebFrame hack in DumpRenderTree.
1319         
1320
1321         * DumpRenderTree/qt/jsobjects.cpp:
1322         (EventSender::mouseDown):
1323         (EventSender::mouseUp):
1324         (EventSender::mouseMoveTo):
1325
1326 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1327
1328         Reviewed by Mark.
1329
1330         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1331         to prevent the default implementation from popping up messageboxes.
1332
1333         * DumpRenderTree/qt/DumpRenderTree.cpp:
1334         (WebCore::WebPage::javaScriptConfirm):
1335         (WebCore::WebPage::javaScriptPrompt):
1336
1337 2007-11-06  Eric Seidel  <eric@webkit.org>
1338
1339         * Scripts/build-testkjs: build fix... too many $$
1340
1341 2007-11-06  Eric Seidel  <eric@webkit.org>
1342
1343         Reviewed by Mark Rowe.
1344
1345         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1346
1347 2007-11-05  Adam Roben  <aroben@apple.com>
1348
1349         Add support on Windows for WEBKIT_TESTFONTS
1350
1351         This environment variable lets you specify where the fonts to be used
1352         by DumpRenderTree reside. The Qt port is already using this, so I'm
1353         just following their lead.
1354
1355         Reviewed by Darin.
1356
1357         * DumpRenderTree/win/DumpRenderTree.cpp:
1358         (exePath): Refactored code out of initialize().
1359         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1360         DumpRenderTree.resources.
1361         (initialize): Use the new fontsPath function.
1362         (main): Use the new exePath function.
1363         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1364         variable to DRT, like Qt does.
1365
1366 2007-11-05  Mark Rowe  <mrowe@apple.com>
1367
1368         Rubber-stamped by Alp Toker.
1369
1370         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1371
1372         * GtkLauncher/main.cpp:
1373         (goToURLBarText):
1374         (main):
1375
1376 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1377
1378         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1379         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1380
1381         Reviewed by Timothy.
1382
1383         Restrict the range of nightly builds used by the bisect-builds script
1384         based on the version of Safari and the version of Mac OS X being used.
1385
1386         Mac OS X 10.4: Safari 2.0: r11976 or newer
1387         Mac OS X 10.4: Safari 3.0: r19992 or newer
1388
1389         Mac OS X 10.5: Safari 2.0: r19594 or newer
1390         Mac OS X 10.5: Safari 3.0: r25124 or newer
1391
1392         * Scripts/bisect-builds:
1393         (findMacOSXVersion): Added.
1394         (makeNightlyList): Added argument to provide version of Mac OS X.
1395         Restrict range of nightly builds based on Safari and Mac OS X versions.
1396
1397 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1398
1399         Reviewed by Maciej.
1400
1401         - This patch involves several changes, all of them were noticed that
1402         they were needed by the work being done in WebKit to get Drosera and
1403         WebKit working together on Windows.
1404         - The changes are:
1405         1) Added a debugger console for output messages.
1406         2) Drosera now listens for the WebKit server (before, the server would
1407         have to be running before Drosera was started.)
1408         3) Fixed a bug where the WebView started out as 0x0 pixels.
1409         4) Fixed a bug when there is no scope.
1410         5) Added the HTML, JS, and CSS to the project file to make them easy to
1411         find.
1412         6) Made the ServerConnection functions virtual.
1413
1414         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1415         for the WebKit server.
1416         (DebuggerClient::DebuggerClient):
1417         (DebuggerClient::~DebuggerClient):
1418         (DebuggerClient::didFinishLoadForFrame):
1419         (DebuggerClient::serverConnected):
1420         (DebuggerClient::attemptToCreateServerConnection):
1421         * Drosera/win/DebuggerClient.h: Ditto.
1422         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1423         scope.
1424         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1425         (DebuggerDocument::platformValueForScopeVariableNamed):
1426         * Drosera/win/Drosera.cpp:
1427         (_tWinMain): Added a console in debug for output messages.
1428         (Drosera::Drosera): Listen for server.
1429         (Drosera::initUI): The server now Initializes COM.
1430         (Drosera::serverConnected): Part of the listening for the server.
1431         (Drosera::attemptToCreateServerConnection): Ditto.
1432         * Drosera/win/Drosera.h: New interface for listening for the server.
1433         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1434         files to the VS project.
1435         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1436         connection.
1437         (ServerConnection::ServerConnection):
1438         (ServerConnection::attemptToCreateServerConnection):
1439         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1440         methods.
1441         (ServerConnection::serverConnected):
1442
1443 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1444
1445         Reviewed by Maciej.
1446
1447         http://bugs.webkit.org/show_bug.cgi?id=15832
1448         fast/dom/gc-10.html crashes when run alone
1449
1450         Check for !done before using objects that can be already deallocated.
1451
1452         * DumpRenderTree/mac/EditingDelegate.mm:
1453         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1454         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1455         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1456         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1457         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1458         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1459         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1460         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1461         (-[EditingDelegate webViewDidBeginEditing:]):
1462         (-[EditingDelegate webViewDidChange:]):
1463         (-[EditingDelegate webViewDidEndEditing:]):
1464         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1465         (-[EditingDelegate webViewDidChangeSelection:]):
1466         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1467         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1468         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1469         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1470         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1471         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1472         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1473         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1474         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1475         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
1476         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1477         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
1478         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1479         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
1480         (-[FrameLoadDelegate webView:willCloseFrame:]):
1481         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1482         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1483         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1484         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1485         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1486         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1487         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1488         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1489         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1490
1491 2007-11-04  Mark Rowe  <mrowe@apple.com>
1492
1493         Build fix.  Don't use Carbon.h as the prefix header as it triggers
1494         warnings that would otherwise be suppressed due to it being a system header.
1495
1496         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1497
1498 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
1499
1500         Rubber stamped by Adam.
1501         
1502         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
1503
1504         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1505
1506 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1507
1508         Sort files(...); sections of Xcode project files.
1509
1510         Rubber-stamped by Darin.
1511
1512         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1513         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1514         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1515         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1516
1517 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1518
1519         Script to sort "files(...);" sections in Xcode project.pbxproj files.
1520
1521         Reviewed by Darin.
1522
1523         * Scripts/sort-Xcode-project-file: Added.
1524
1525 2007-11-02  Darin Adler  <darin@apple.com>
1526
1527         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
1528
1529 2007-11-02  Darin Adler  <darin@apple.com>
1530
1531         Reviewed by Maciej.
1532
1533         * Scripts/run-sunspider: Pass the "--base" option through.
1534
1535         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
1536         the real script do that. Default configuration to Release to match run-sunspider
1537         so we don't end up building Debug just to compare results.
1538
1539 2007-11-01  Adam Roben  <aroben@apple.com>
1540
1541         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
1542
1543         Reviewed by Sam.
1544
1545         * Scripts/commit-log-editor: Show all the directories beneath the
1546         source root, instead of just the last one.
1547
1548 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
1549
1550         Reviewed by Adam Roben.
1551
1552         Print out an error message when the Windows build fails
1553         and provide guidance on how to find out what went wrong.
1554
1555         * Scripts/build-webkit:
1556         * Scripts/webkitdirs.pm:
1557
1558 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
1559
1560         Rubber-stamped by Adam Roben.
1561
1562         Rolled out r27326 - debug CRT seems to cause no problems after all.
1563
1564         * DumpRenderTree/win/DumpRenderTree.vcproj:
1565
1566 2007-10-31  Adam Roben  <aroben@apple.com>
1567
1568         Switch the Debug configuration to using the non-debug CRT
1569
1570         This matches WebKit.
1571
1572         Reviewed by Steve.
1573
1574         * DumpRenderTree/win/DumpRenderTree.vcproj:
1575
1576 2007-10-31  Antti Koivisto  <antti@apple.com>
1577
1578         Reviewed by bdash.
1579         
1580         Disable media tests when doing leak checking on Tiger.
1581         They crash in QuickTime (rdar://problem/5537157).
1582
1583         * Scripts/run-webkit-tests:
1584
1585 2007-10-29  Antti Koivisto  <antti@apple.com>
1586
1587         Reviewed by Maciej.
1588         
1589         Build media support by default on OSX only.
1590
1591         * Scripts/build-webkit:
1592
1593 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1594
1595         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
1596         get caught by the pre-commit hooks.
1597
1598 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1599
1600         Reviewed by Adam.
1601
1602         - This is a collection of relatively unrelated changes and cleanups
1603         to Drosera to prepare it for interacting with WebKit.  A lot of these
1604         changes are just correcting mistakes, for example removing included
1605         headers that are no longer needed.
1606
1607         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
1608         this will be needed by the DebuggerClient.
1609         (DebuggerDocument::server):
1610         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
1611         * Drosera/win/DebuggerClient.cpp: 
1612         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
1613         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
1614         (DebuggerClient::createWebViewWithRequest): Added comment about its
1615         purpose. 
1616         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
1617         declarations.
1618         (DebuggerClient::webViewLoaded): Moved.
1619         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
1620         file, since this was the only place it was used.
1621         (cfStringToBSTR):
1622         * Drosera/win/Drosera.h: Cleaned up the includes.
1623         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
1624         * Drosera/win/HelperFunctions.h: Removed.
1625
1626 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1627
1628         Reviewed by Adam.
1629
1630         - Small cleanup in the ServerConnection class.
1631
1632         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
1633         and added an include.
1634         (ServerConnection::currentFrame):
1635         (ServerConnection::getCallerFrame):
1636         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
1637         made a pointer into a COMPtr, and cleaned up the includes.
1638
1639 2007-10-29  Timothy Hatcher  <timothy@apple.com>
1640
1641         Reviewed by John Sullivan.
1642         
1643         - Place the Localizable.strings file in mac or win directories
1644           if that location exists.
1645         - Also look for UI_STRING in .c files.
1646
1647         * Scripts/extract-localizable-strings:
1648
1649 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1650
1651         Reviewed by Adam.
1652
1653         - Set the eol-style to native and made all the line endings the same
1654         so that I avoid messy diffs that show eol changes.
1655
1656         * Drosera/win/ServerConnection.cpp:
1657         (ServerConnection::didParseSource):
1658         (ServerConnection::didEnterCallFrame):
1659         (ServerConnection::willExecuteStatement):
1660         (ServerConnection::willLeaveCallFrame):
1661         (ServerConnection::exceptionWasRaised):
1662
1663 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1664
1665         Reviewed by Adam.
1666
1667         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
1668         functionality that could not have existed previously without the new
1669         interfaces.
1670         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
1671         from a BSTR to a JSValueRef.
1672         (DebuggerDocument::platformEvaluateScript): Implemented.
1673         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
1674         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1675         Implemented.
1676         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
1677         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
1678         * Drosera/win/ServerConnection.cpp: Added a helper function.
1679         (ServerConnection::getCallerFrame):
1680         * Drosera/win/ServerConnection.h: Added a helper function.
1681
1682 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1683
1684         updated reviewers for my previous changelog.
1685
1686 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1687         Reviewed by Maciej and Adam and Geoff.
1688
1689         - Minor mac-side improvements including moving a function to a more
1690         appropriate location, fixing a warning, and correctly checking
1691         exceptions.
1692
1693         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
1694         (DebuggerDocument::willExecuteStatement):
1695         (DebuggerDocument::didEnterCallFrame):
1696         (DebuggerDocument::willLeaveCallFrame):
1697         (DebuggerDocument::windowScriptObjectAvailable):
1698         (DebuggerDocument::callFunctionOnObject):
1699         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
1700         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
1701         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
1702         because it doesn't require the ServerConnection at all.
1703         (NSStringCreateWithJSStringRef): Made an argument const.
1704         (JSValueRefCreateWithNSString): Made an argument const.
1705         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
1706         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1707         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
1708         * Drosera/mac/ServerConnection.mm: Ditto.
1709         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1710
1711 2007-10-29  Sam Weinig  <sam@webkit.org>
1712
1713         Reviewed by Adam Roben.
1714
1715         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
1716
1717         * DumpRenderTree/LayoutTestController.cpp:
1718         (LayoutTestController::LayoutTestController):
1719         (getGlobalFlagCallback):
1720         (setGlobalFlagCallback):
1721         (LayoutTestController::getJSClass):
1722         (LayoutTestController::staticValues):
1723         * DumpRenderTree/LayoutTestController.h:
1724         (LayoutTestController::globalFlag):
1725         (LayoutTestController::setGlobalFlag):
1726
1727 2007-10-29  Darin Adler  <darin@apple.com>
1728
1729         Reviewed by Maciej.
1730
1731         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
1732         resolution instead of its default.
1733
1734 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
1735
1736         Fixed showStatus() to print status for successfully resolved conflicts when using git.
1737
1738         Reviewed by Mark Rowe.
1739
1740         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
1741         was successfully resolved, but this would not show any status because the change had
1742         already been cached in the index using "git add".  The solution is to add an optional
1743         second argument to showStatus() which adds the "--cached" switch to the command.
1744
1745         * Scripts/resolve-ChangeLogs:
1746         (showStatus):
1747
1748 2007-10-28  Eric Seidel  <eric@webkit.org>
1749
1750         Reviewed by Maciej and Geoff, in unison.
1751
1752         * Scripts/run-webkit-tests: remove broken --svg option
1753
1754 2007-10-28  Darin Adler  <darin@apple.com>
1755
1756         Reviewed by Adam.
1757
1758         * Scripts/run-sunspider: Default to "Release" configuration rather than
1759         defaulting to the last configuration used as other scripts do. This can
1760         still be overriden on the command line with "--debug" if there's some
1761         reason to do so. Also fix a typo.
1762
1763         * Scripts/sunspider-compare-results: Fix a typo.
1764
1765 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
1766
1767         Reviewed by Adam.
1768
1769         - Implemented the WebScriptDebugListener functions now that the
1770         WebScriptDebugServer exists
1771
1772         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
1773         functions.
1774         (ServerConnection::currentFrame):
1775         (ServerConnection::didLoadMainResourceForDataSource):
1776         (ServerConnection::didParseSource):
1777         (ServerConnection::failedToParseSource):
1778         (ServerConnection::didEnterCallFrame):
1779         (ServerConnection::willExecuteStatement):
1780         (ServerConnection::willLeaveCallFrame):
1781         (ServerConnection::exceptionWasRaised):
1782         * Drosera/win/ServerConnection.h: Removed unused arguments from the
1783         members arguments list.
1784
1785 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
1786
1787         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
1788         <http://bugs.webkit.org/show_bug.cgi?id=15600>
1789
1790         Reviewed by Darin.
1791
1792         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
1793         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
1794         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
1795         file.  Note that it may also be used as a stand-alone script.
1796
1797         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
1798         * Scripts/resolve-ChangeLogs: Added.
1799         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
1800
1801 2007-10-26  Mark Rowe  <mrowe@apple.com>
1802
1803         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
1804         to the Qt port on the assumption that it was an implementation of the cross-platform
1805         LayoutTestController class.  It is not, so it did not need to be changed.
1806
1807         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
1808
1809 2007-10-25  Mark Rowe  <mrowe@apple.com>
1810
1811         Reviewed by Maciej.
1812
1813         Fix builds with code coverage enabled.
1814
1815         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
1816
1817 2007-10-25  Darin Adler  <darin@apple.com>
1818
1819         Reviewed by Mark Rowe.
1820
1821         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
1822         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
1823
1824 2007-10-25  Stephanie  <slewis@apple.com>
1825
1826         build Fix
1827
1828         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1829
1830 2007-10-25  Stephanie  <slewis@apple.com>
1831
1832         Reviewed by Mark Rowe, Adam Roben.
1833
1834         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
1835
1836         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
1837
1838 2007-10-25  Alice Liu  <alice.liu@apple.com>
1839
1840         Reviewed by Adam.
1841
1842         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
1843
1844         Moving destructor into platform-specific files
1845         * DumpRenderTree/LayoutTestController.cpp:
1846         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1847         (LayoutTestController::~LayoutTestController):
1848         * DumpRenderTree/qt/jsobjects.cpp:
1849         (LayoutTestController::~LayoutTestController):
1850
1851         LayoutTestController wasn't being destroyed
1852         * DumpRenderTree/win/DumpRenderTree.cpp:
1853         (runTest):
1854
1855         Added declspec
1856         * DumpRenderTree/win/EditingDelegate.h:
1857
1858         Reset certain values on the webview (or related delegate) that might 
1859         have changed while running a test
1860         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1861         (LayoutTestController::~LayoutTestController):
1862
1863 2007-10-25  Adam Roben  <aroben@apple.com>
1864
1865         Make sunspider-compare-results work with relative paths
1866
1867         Reviewed by Sam.
1868
1869         * Scripts/sunspider-compare-results: Convert arguments to absolute
1870         paths before we chdir.
1871
1872 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
1873
1874         Reviewed by Sam.
1875
1876         - Implemented server calls now the WebScriptDebugServer exists.
1877         - Also removed no longer needed call to initialize CG.
1878
1879         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
1880         automatically now.
1881         (_tWinMain):
1882         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
1883         (ServerConnection::ServerConnection):
1884         (ServerConnection::~ServerConnection):
1885         (ServerConnection::pause):
1886         (ServerConnection::resume):
1887         (ServerConnection::stepInto):
1888         (ServerConnection::applicationTerminating):
1889         (ServerConnection::serverConnectionDidDie):
1890         * Drosera/win/ServerConnection.h: Now uses the COM class.
1891
1892 2007-10-24  George Staikos  <staikos@kde.org>
1893
1894         Unbreak Qt build.
1895
1896         * Scripts/build-webkit:
1897
1898 2007-10-24  Adam Roben  <aroben@apple.com>
1899
1900         Remove now-unnecessary call to InitializeCoreGraphics
1901
1902         WebKit takes care of this now.
1903
1904         Reviewed by Ada.
1905
1906         * DumpRenderTree/win/DumpRenderTree.cpp:
1907         (initialize):
1908
1909 2007-10-24  Adam Roben  <aroben@apple.com>
1910
1911         Use WebTextRenderer in DRT
1912
1913         Reviewed by Ada.
1914
1915         * DumpRenderTree/win/DumpRenderTree.cpp:
1916         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
1917
1918 2007-10-24  Sven Herzberg  <sven@imendio.com>
1919
1920         Reviewed by Mark Rowe.
1921
1922         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
1923         Bug 15614: [GTK] qmake based backends don't build on OS X
1924
1925         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
1926         GTK backend on a Mac
1927         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
1928         isDarwin() to make it reusable in other places (like the workaround-
1929         for-prebuilt-qmake in build-webkit)
1930
1931 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1932
1933         Refurbish update-webkit script.
1934
1935         Reviewed by Adam.
1936
1937         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
1938         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
1939         multi-argument version of system() for flexibility and security.  Check for existence
1940         of Internal directory using -d test instead of -x.
1941
1942 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1943
1944         Minor clean-up of prepare-ChangeLog script.
1945
1946         Reviewed by Adam.
1947
1948         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
1949         of a string.  Use multi-argument versions of open() and system() for flexibility and
1950         security.
1951
1952 2007-10-24  Alice Liu  <alice.liu@apple.com>
1953
1954         Reviewed by Oliver.
1955
1956         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
1957
1958         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
1959         replay the saved events when we're still processing the mousedown that starts the drag
1960         * DumpRenderTree/win/EventSender.cpp:
1961         (doMouseMove):
1962         * DumpRenderTree/win/UIDelegate.cpp:
1963         (UIDelegate::doDragDrop):
1964
1965 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
1966
1967         Reviewed by Sam, Steve and Darin.
1968
1969         - Stubbed out the WebScriptDebugListener functionality in the Server
1970         Connection class to prepare it for receiving those callbacks.
1971         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
1972         and the ServerConnection to not need to be initialized with a server
1973         name, since that is not the way we connect to the WebKit server. 
1974
1975         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
1976         no exception.  Now it only loggs when there is an exception
1977         (DebuggerDocument::willExecuteStatement):
1978         (DebuggerDocument::didEnterCallFrame):
1979         (DebuggerDocument::willLeaveCallFrame):
1980         (DebuggerDocument::windowScriptObjectAvailable):
1981         (DebuggerDocument::callFunctionOnObject):
1982         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
1983         to be instantiated with a server's name.
1984         (DebuggerClient::DebuggerClient):
1985         (DebuggerClient::didFinishLoadForFrame):
1986         * Drosera/win/DebuggerClient.h: Removed unsued variable.
1987         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
1988         a server name.
1989         (Drosera::init):
1990         (Drosera::initServer):
1991         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
1992         instantiated with a server's name.
1993         * Drosera/win/ServerConnection.cpp: 
1994         (ServerConnection::ServerConnection): No longer needs a server name
1995         (ServerConnection::~ServerConnection): Only release the global context
1996         if there is one.
1997         (ServerConnection::serverConnectionDidDie): Stub for
1998         IWebScriptDebugListener
1999         (ServerConnection::QueryInterface): ditto
2000         (ServerConnection::AddRef): ditto
2001         (ServerConnection::Release): ditto
2002         (ServerConnection::didLoadMainResourceForDataSource): ditto
2003         (ServerConnection::didParseSource): ditto
2004         (ServerConnection::failedToParseSource): ditto
2005         (ServerConnection::didEnterCallFrame): ditto
2006         (ServerConnection::willExecuteStatement): ditto
2007         (ServerConnection::willLeaveCallFrame): ditto
2008         (ServerConnection::exceptionWasRaised): ditto
2009         * Drosera/win/ServerConnection.h: Stubbed out the
2010         IWebScriptDebugListener functions, and this class no longer needs to be
2011         instantiated with a server name.
2012
2013 2007-10-24  Lars Knoll  <lars@trolltech.com>
2014
2015         Reviewed by Simon.
2016
2017         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2018
2019         * DumpRenderTree/qt/jsobjects.h:
2020
2021 2007-10-24  Lars Knoll  <lars@trolltech.com>
2022
2023         Reviewed by Simon.
2024
2025         add another command.
2026
2027         * DumpRenderTree/qt/jsobjects.cpp:
2028         (TextInputController::doCommand):
2029
2030 2007-10-24  Lars Knoll  <lars@trolltech.com>
2031
2032         Reviewed by Simon.
2033
2034         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2035
2036         * DumpRenderTree/qt/jsobjects.cpp:
2037         (EventSender::keyDown):
2038         * DumpRenderTree/qt/jsobjects.h:
2039
2040 2007-10-24  Lars Knoll  <lars@trolltech.com>
2041
2042         Reviewed by Simon.
2043
2044         implement eventSender.keyDown().
2045
2046         * DumpRenderTree/qt/jsobjects.cpp:
2047         (EventSender::keyDown):
2048
2049 2007-10-24  Lars Knoll  <lars@trolltech.com>
2050
2051         Reviewed by Simon.
2052
2053         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2054
2055         * DumpRenderTree/qt/DumpRenderTree.cpp:
2056         (WebCore::DumpRenderTree::DumpRenderTree):
2057         (WebCore::DumpRenderTree::initJSObjects):
2058         * DumpRenderTree/qt/jsobjects.cpp:
2059         (TextInputController::doCommand):
2060
2061 2007-10-24  Lars Knoll  <lars@trolltech.com>
2062
2063         Reviewed by Simon.
2064
2065         first bit of implementation for the textinputcontroller.
2066
2067         * DumpRenderTree/qt/DumpRenderTree.cpp:
2068         (WebCore::DumpRenderTree::DumpRenderTree):
2069         * DumpRenderTree/qt/DumpRenderTree.h:
2070         * DumpRenderTree/qt/jsobjects.cpp:
2071         (TextInputController::TextInputController):
2072         (TextInputController::doCommand):
2073         * DumpRenderTree/qt/jsobjects.h:
2074
2075 2007-10-24  Lars Knoll  <lars@trolltech.com>
2076
2077         Reviewed by Simon.
2078
2079         make the man webpage believe it has focus, so the editing tests work correctly.
2080
2081         * DumpRenderTree/qt/DumpRenderTree.cpp:
2082         (WebCore::DumpRenderTree::DumpRenderTree):
2083
2084 2007-10-24  Lars Knoll  <lars@trolltech.com>
2085
2086         Reviewed by Simon.
2087
2088         implement layoutTestController.dumpEditingCallbacks() correctly.
2089
2090         * DumpRenderTree/qt/DumpRenderTree.cpp:
2091         (WebCore::DumpRenderTree::DumpRenderTree):
2092         * DumpRenderTree/qt/jsobjects.cpp:
2093         (LayoutTestController::reset):
2094         (LayoutTestController::dumpEditingCallbacks):
2095
2096 2007-10-24  Lars Knoll  <lars@trolltech.com>
2097
2098         Reviewed by Simon.
2099
2100         Implement support for testing editing.
2101
2102         * DumpRenderTree/qt/DumpRenderTree.cpp:
2103         (WebCore::DumpRenderTree::DumpRenderTree):
2104
2105 2007-10-23  Sam Weinig  <sam@webkit.org>
2106
2107         Check for null BSTR that can be passed to the UIDelegate methods
2108         from javascript null and undefined.  Fixes a failing test case on
2109         Windows (fast/dom/Window/alert-undefined.html)
2110
2111         Reviewed by Eric Seidel.
2112
2113         * DumpRenderTree/win/UIDelegate.cpp:
2114         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2115         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2116         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2117         (UIDelegate::webViewAddMessageToConsole):
2118
2119 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2120
2121         Reviewed by Darin.
2122         
2123         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2124
2125         * Scripts/build-testkjs:
2126
2127 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2128
2129         Reviewed by Darin.
2130
2131         - add wrapper that finds the right copy of testkjs
2132         
2133         * Scripts/sunspider-compare-results: Added.
2134
2135 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2136
2137         Reviewed by Sam.
2138
2139         - After talking with Steve I now see that the WebKit server must be
2140         running for DCOM to create the distributed objects, which makes sense
2141         and currently WebKit only allows one instance to be running at a time
2142         which avoids accidentally connecting to the wrong server
2143         - In light of this I have removed the code for the attach box and
2144         NotificationServer and known server names, since they are all extranious
2145         now.
2146
2147         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2148         names.
2149         (_tWinMain): Uses init instead of initUI.
2150         (droseraWndProc): No longer creats an attach dialog box.
2151         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2152         it's not manditory to call init before doing COM stuff.
2153         (Drosera::init): calls initUI and will call attach when the
2154         functionality exists. 
2155         (Drosera::initUI): Has changed very little.
2156         (Drosera::attach): Changed the signature to reflect that we no longer
2157         need the dictionary of known server names.
2158         * Drosera/win/Drosera.h: Removed notification classes and known server
2159         names.  Also renamed and moved some functions.
2160         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2161         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2162         headers to the resources folder. 
2163         * Drosera/win/resource.h: Removed the Attach box.
2164
2165 2007-10-22  Adam Roben  <aroben@apple.com>
2166
2167         Windows build fix
2168
2169         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2170
2171 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2172
2173         - Removed a leak that was fixed.
2174
2175         * Scripts/run-webkit-tests:
2176
2177 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2178
2179         Reviewed by Darin.
2180
2181         - Changed the Client so that the DebuggerDocument now own the
2182         ServerConnection.  This simplifies ownership and cleanup. 
2183
2184         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2185         ServerConnection.
2186         (DebuggerClient::initWithServerName):
2187         (DebuggerClient::didFinishLoadForFrame):
2188         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2189         ServerConnection.
2190         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2191         until after we have a server which we are attached to.
2192         (Drosera::initUI):
2193         (Drosera::attach):
2194         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2195         out previously.
2196
2197 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2198
2199         Reviewed by Nikolas.
2200
2201         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2202
2203         * Scripts/run-javascriptcore-tests:
2204
2205 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2206
2207         Reviewed by Nikolas.
2208
2209         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2210
2211         * Scripts/build-drosera:
2212         * Scripts/build-dumprendertree:
2213         * Scripts/build-testkjs:
2214         * Scripts/build-webkit:
2215         * Scripts/run-javascriptcore-tests:
2216         * Scripts/run-sunspider:
2217         * Scripts/run-webkit-tests:
2218         * Scripts/webkitdirs.pm:
2219
2220 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2221
2222         Reviewed by Mark Rowe.
2223         
2224         Fix for local database support after r26879
2225         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2226
2227         * Scripts/build-webkit:
2228
2229 2007-10-22  Holger Freyther  <zecke@selfish.org>
2230
2231         Reviewed by Simon Hausmann <hausmann@kde.org>.
2232
2233         - Do not build testkjs as an application bundle. This is
2234         needed for run-javascriptcore-tests on OSX.
2235         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2236         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2237         as we do not have -rpath on OSX.
2238
2239         * DumpRenderTree/qt/DumpRenderTree.pro:
2240         * Scripts/run-webkit-tests:
2241
2242 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2243
2244         Reviewed by aroben.
2245
2246         Fix support for Signed-off-by detection in prepare-ChangeLog
2247         --git-commit. The Signed-off-by tag does not appear in the header
2248         but usually at the end.
2249
2250         * Scripts/prepare-ChangeLog:
2251
2252 2007-10-21  Mark Rowe  <mrowe@apple.com>
2253
2254         Reviewed by Eric.
2255
2256         Fix run-javascriptcore-tests for Gtk.
2257
2258         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2259
2260 2007-10-20  Eric Seidel  <eric@webkit.org>
2261
2262         Reviewed by aroben.
2263
2264         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2265
2266 2007-10-20  Eric Seidel  <eric@webkit.org>
2267
2268         Reviewed by darin.
2269         
2270         Add improved argument handling to run-sunspider, including
2271         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2272         Also re-factor code into subroutines
2273
2274         * Scripts/build-dumprendertree: removed bogus comments
2275         * Scripts/build-testkjs: Added.
2276         * Scripts/run-javascriptcore-tests: use build-testkjs
2277         * Scripts/run-sunspider: improved argument handling, abstraction
2278         * Scripts/run-webkit-tests: improved abstraction
2279
2280 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2281
2282         Not reviewed, Windows build fix.
2283
2284         * DumpRenderTree/win/EventSender.cpp:
2285         (keyDownCallback):
2286
2287 2007-10-20  Darin Adler  <darin@apple.com>
2288
2289         Reviewed by Tim Hatcher.
2290
2291         - http://bugs.webkit.org/show_bug.cgi?id=15544
2292           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2293           not rely on Apple-specific key codes
2294
2295         * DumpRenderTree/mac/EventSendingController.mm:
2296         (-[EventSendingController keyDown:withModifiers:]):
2297         Added named key "rightArrow". Later we could have a whole table of these.
2298         Also tweaked modifiers code a little.
2299
2300         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2301
2302 2007-10-19  Darin Adler  <darin@apple.com>
2303
2304         Reviewed by Eric.
2305
2306         - http://bugs.webkit.org/show_bug.cgi?id=15566
2307           possible fix for leak seen in DumpRenderTree
2308
2309         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2310         Delete the item if it's not put on the queue, since the caller has
2311         no way of knowing that. Would be better to have the parameter type
2312         be auto_ptr to express the fact that we take ownership.
2313
2314         - unrelated change
2315
2316         * Drosera/mac/main.m: Add missing include.
2317
2318 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2319
2320         Reviewed by Adam.
2321
2322         - This change should be identical but for some reason was not working
2323         on my machine.
2324
2325         * Scripts/prepare-ChangeLog:
2326
2327 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2328
2329         Reviewed by Oliver and Tim.
2330
2331         - Made use of RetainPtr to avoid retain and release issues and moved the
2332         log function to DebuggerDocumentPlatform, which seems to be a more
2333         logical place for it to live.
2334         - Also moved knownServers from the ServerConnection to
2335         DebuggerApplication to match the Windows code and because it makes sense
2336         that a connection knows its own server but not all of them.
2337
2338         * Drosera/mac/DebuggerClient.h: Moved the log function to
2339           DebuggerDocumentPlatform.
2340         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2341           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2342           call for the server name up from the ServerConnection class.
2343         (-[DebuggerClient dealloc]):
2344         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2345           for the server name up from the ServerConnection.
2346         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2347         (DebuggerDocument::platformPause):
2348         (DebuggerDocument::platformResume):
2349         (DebuggerDocument::platformStepInto):
2350         (DebuggerDocument::platformEvaluateScript):
2351         (DebuggerDocument::getPlatformCurrentFunctionStack):
2352         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2353         (DebuggerDocument::platformValueForScopeVariableNamed):
2354         (DebuggerDocument::platformLog): Log directly from here. No need to call
2355           DebuggerClient.
2356         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2357           way I see it, a ServerConnection should only know about its connection
2358           and the group of all possible servers should be kept by the
2359           application.
2360         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2361           currentServerName, it makes sense that the connection should know that
2362           name.
2363         (-[ServerConnection currentServerName]):
2364
2365 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2366
2367         Reviewed by Adam.
2368
2369         - Integrated changes from mac drosera.  Recently I've encapsulated
2370         out the server connection object from the rest of Drosera because
2371         it is very platform dependent right now and RPC is not implemented on
2372         windows.  This functionality, of communicating with the WebKit server
2373         is the next area I will be focusing on in Windows.
2374
2375         - Other changes and cleanup were made to organize the code and add notes
2376         on which parts still need work.  Also some mac code is added and
2377         commented out, to act as pseudocode for the logic of those parts.
2378
2379         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2380           pointer.
2381         * Drosera/config.h: Added whitespace.
2382         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2383           these files got moved into Drosera.h/cpp
2384         * Drosera/win/DebuggerApplication.h: Removed.
2385         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
2386           happened here to better match the logic flow of the same code on the 
2387           mac side and to use the new ServerConnection class.
2388         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2389         (DebuggerClient::initWithServerName): Initializer that will set up the
2390           class to use a ServerConnection object.  This was necessary so I could
2391           create a DebuggerClient without having to initilaize it at
2392           construction.
2393         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2394           will be the UIDelegate and FrameLoadDelegate.
2395         (DebuggerClient::AddRef): For IUnknown.
2396         (DebuggerClient::Release): For IUnknown.
2397         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2398           this still needs to set the global context of the server, but
2399           IWebFrame does not have an accessor for the global context yet. 
2400         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2401           this is a pass through for the same function in the document.
2402         (DebuggerClient::didReceiveTitle): Unimplemented part of
2403           FrameLoadDelegate this would change the title of the window.
2404         (DebuggerClient::createWebViewWithRequest): Part of the
2405           FrameLoadDelegate.  This is about new windows via Window.open() and
2406           how their delegates are set.
2407         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2408           UIDelegate.  Just a debug function for printing messages.
2409         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2410           because the Client should be the UIDelegate and FrameLoadDelegate
2411           to match the delegates on mac.
2412         (DebuggerClient::webViewLoaded): Added accessor method.
2413         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2414           forgotten to add this file before.  This is where the platform
2415           dependent versions of the Documents functions live. Most of these are
2416           unimplemented because some piece of functionality does not exist on
2417           Windows yet.
2418         (DebuggerDocument::platformPause):
2419         (DebuggerDocument::platformResume):
2420         (DebuggerDocument::platformStepInto):
2421         (DebuggerDocument::platformEvaluateScript):
2422         (DebuggerDocument::getPlatformCurrentFunctionStack):
2423         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2424         (DebuggerDocument::platformValueForScopeVariableNamed):
2425         (DebuggerDocument::platformLog):
2426         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2427           responsibilities becaue they belong in the Client. Also I laid the
2428           groundwork for attaching Drosera to a WebKit process
2429         (attachWndProc): Now if a server is selected the Client becomes it's
2430           delegate.
2431         (Drosera::Drosera): Added the construction of the Client and dictionary
2432           of server names. 
2433         (Drosera::initUI): This is no longer the delegates, the Client is.
2434         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2435           state. 
2436         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2437           notification registration when it's possible to implement.
2438         (Drosera::serverLoaded): Ditto
2439         (Drosera::serverUnloaded): Ditto
2440         (Drosera::attach): Attach Drosera to the WebKit server.
2441         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2442         (Drosera::getInst): 
2443         (Drosera::setInst):
2444         (Drosera::knownServers):
2445         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2446           and added the ServerConnection.
2447         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2448         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2449           Most of the functions are completely unimlemented because they cannot
2450           connect with the WebKit server, because one does not exist on Windows
2451           yet.
2452         (ServerConnection::initWithServerName): 
2453         (ServerConnection::~ServerConnection):
2454         (ServerConnection::setGlobalContext):
2455         (ServerConnection::pause):
2456         (ServerConnection::resume):
2457         (ServerConnection::stepInto):
2458         (ServerConnection::switchToServerNamed):
2459         (ServerConnection::applicationTerminating):
2460         (ServerConnection::serverConnectionDidDie):
2461         (ServerConnection::currentFrame):
2462         * Drosera/win/ServerConnection.h: Added. Ditto.
2463         (ServerConnection::ServerConnection):
2464
2465 2007-10-19  Alice Liu  <alice.liu@apple.com>
2466
2467         Reviewed by Darin.
2468
2469         Fix for these broken layout tests on Windows:
2470         
2471         fast/forms/focus-selection-input.html
2472         fast/forms/focus-selection-textarea.html
2473         fast/forms/select-accesskey.html
2474         
2475         * DumpRenderTree/win/EventSender.cpp:
2476         (keyDownCallback):
2477         correct the VK code for alt key.
2478         
2479 2007-10-19  Eric Seidel  <eric@webkit.org>
2480
2481         Reviewed by Mark Rowe.
2482         
2483         Make the GtkLauncher code slightly more readable.
2484
2485         * GtkLauncher/main.cpp:
2486         (setupMainMenu): Added.
2487         (setupMainWindowUI): Added.
2488         (main):
2489
2490 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
2491
2492         Rubber stamped by Adam.
2493         
2494         - don't delay-load WebKit in DumpRenderTree.
2495
2496         * DumpRenderTree/win/DumpRenderTree.vcproj:
2497
2498 2007-10-18  Dan Bernstein  <mitz@apple.com>
2499
2500         Reviewed by Adam Roben.
2501
2502         - fix <rdar://problem/5313523>
2503         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2504
2505         * DumpRenderTree/mac/DumpRenderTree.mm:
2506         (dump): Changed to use _responseMIMEType.
2507
2508 2007-10-17  Adam Roben  <aroben@apple.com>
2509
2510         Make it possible to have Windows-specific tests and results
2511
2512         When searching for tests to run and the Skipped file, we will only
2513         look in platform/win and the cross-platform directory. When looking
2514         for expected results, we will look in platform/win, then
2515         platform/mac-leopard, then platform/mac, then finally the
2516         cross-platform directory.
2517
2518         Reviewed by Sam.
2519
2520         * Scripts/run-webkit-tests:
2521         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
2522         searching in the cross-platform directory.
2523         (sub buildPlatformHierarchy): Removed some unneeded calls to
2524         dirname/basename.
2525
2526 2007-10-17  Adam Roben  <aroben@apple.com>
2527
2528         Add back the call to register WebKit that we had before WebKitInitializer existed
2529
2530         This is needed to ensure that the right WebKit is used when
2531         instantiating COM objects.
2532
2533         Reviewed by Oliver.
2534
2535         * DumpRenderTree/win/debug_internal.vsprops: Define
2536         DEBUG_WEBKIT_HAS_SUFFIX.
2537         * DumpRenderTree/win/DumpRenderTree.cpp:
2538         (initialize):
2539
2540 2007-10-17  Adam Roben  <aroben@apple.com>
2541
2542         Import File::Basename in webkitdirs since we use it
2543
2544         * Scripts/webkitdirs.pm:
2545
2546 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
2547
2548         - Updated the tiger leaks list to make the internal bots green.
2549
2550         * Scripts/run-webkit-tests:
2551
2552 2007-10-17  Adam Roben  <aroben@apple.com>
2553
2554         Build fix for VC++ Express
2555
2556         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
2557         and ole32.lib.
2558
2559 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2560
2561         Reviewed by Sam.
2562
2563         - Minor mac improvements based on observations I made while implementing the
2564         Windows code.
2565
2566         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
2567         then hand it to the Client who will retain it, it should just be the client who
2568         creates and owns the server.
2569         (-[DebuggerApplication attach:]):
2570         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
2571         * Drosera/mac/DebuggerClient.mm: Creates the server.
2572         (-[DebuggerClient initWithServerName:]):
2573         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
2574         can instead forward declare what it needs.
2575
2576 2007-10-16  Darin Adler  <darin@apple.com>
2577
2578         Reviewed by Geoff Garen.
2579
2580         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
2581         want to turn failing tests into platform-specific test results. Also did a
2582         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
2583         would take the type of results into account only some of the time.
2584
2585 2007-10-16  Adam Roben  <aroben@apple.com>
2586
2587         Add a new nightly launcher script for Windows
2588
2589         This new script is for versions of Safari that don't delay-load
2590         WebKit. I had to make FindSafari be able to print out the nightly
2591         launcher script on stdout because Windows shell scripts can't capture
2592         the output from a command into an environment variable.
2593
2594         Reviewed by Steve.
2595
2596         * FindSafari/FindSafari.cpp:
2597         (_tmain): Added /printSafariLauncher option.
2598         * Scripts/run-webkit-nightly.cmd: Added.
2599
2600 2007-10-16  Adam Roben  <aroben@apple.com>
2601
2602         Replace WebKitInitializer with FindSafari
2603
2604         We now rely on setting the PATH environment variable to tell Windows
2605         where to find WebKit and its dependencies (similar to
2606         DYLD_FRAMEWORK_PATH on Mac).
2607
2608         This change also make DumpRenderTree no longer delay-load WebKit.
2609
2610         Reviewed by Sam.
2611
2612         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
2613         FindSafari.
2614         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
2615         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
2616         WebKitInitializer, don't delay-load WebKit.
2617         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
2618         * Scripts/run-webkit-tests: Ditto.
2619         * Scripts/webkitdirs.pm:
2620         (sub setPathForRunningWebKitApp): Added.
2621         * WebKitInitializer/WebKitInitializer.cpp: Removed.
2622         * WebKitInitializer/WebKitInitializer.h: Removed.
2623         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
2624         * WebKitInitializer/debug.vsprops: Removed.
2625         * WebKitInitializer/debug_internal.vsprops: Removed.
2626         * WebKitInitializer/release.vsprops: Removed.
2627
2628 2007-10-16  Adam Roben  <aroben@apple.com>
2629
2630         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
2631
2632         http://bugs.webkit.org/show_bug.cgi?id=15532
2633
2634         FindSafari simply prints the location of an installed Safari.exe on
2635         stdout.
2636
2637         Reviewed by Darin.
2638
2639         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
2640         (getStringValue):
2641         (getWebViewCLSID):
2642         (getInstalledWebKitDirectory):
2643         (_tmain):
2644         * FindSafari/FindSafari.vcproj: Added.
2645         * Scripts/webkitdirs.pm:
2646         (sub installedSafariPath): Added. Calls FindSafari on Windows.
2647
2648 2007-10-16  Adam Roben  <aroben@apple.com>
2649
2650         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
2651
2652         Reviewed by Kevin McCullough.
2653
2654         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
2655         when referring to WebKit.dll.
2656         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
2657         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
2658         * DumpRenderTree/win/release.vsprops: Ditto.
2659         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
2660         never have a _debug suffix on WebKit.dll.
2661         * WebKitInitializer/WebKitInitializer.cpp:
2662         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
2663         specified.
2664         * WebKitInitializer/debug_internal.vsprops: Added
2665         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
2666
2667 2007-10-16  Darin Adler  <darin@apple.com>
2668
2669         Reviewed by Adele.
2670
2671         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2672         Remove now-unneeded control/alt key hack; the tests have been updated.
2673
2674 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2675
2676         - Updated leaks list because our internal bot upgraded it's version of leopard and 
2677         one of the leaks was fixed between that revision and the bot's previous version of
2678         leopard.
2679
2680         * Scripts/run-webkit-tests:
2681
2682 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
2683
2684         Reviewed by Tim.
2685
2686         - I encapsulated out the server connecton functionality because it is a specific part
2687         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
2688         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
2689         Windows.  So the majority of this patch is moving preexisting functionality.
2690
2691         - Also I removed the prefix header and changed to use config.h because it is more
2692         standard on how we use config.h in windows and it didn't make much sense to keep
2693         the prefix header and the config.h
2694
2695         * Drosera/DebuggerDocument.cpp:
2696         (DebuggerDocument::DebuggerDocument):
2697         * Drosera/DebuggerDocument.h:
2698         * Drosera/config.h:
2699         * Drosera/mac/DebuggerApplication.mm:
2700         (-[DebuggerApplication attach:]):
2701         * Drosera/mac/DebuggerClient.h:
2702         * Drosera/mac/DebuggerClient.mm:
2703         (-[DebuggerClient initWithServerConnection:]):
2704         (-[DebuggerClient dealloc]):
2705         (-[DebuggerClient windowDidLoad]):
2706         (-[DebuggerClient windowWillClose:]):
2707         (-[DebuggerClient webView:didFinishLoadForFrame:]):
2708         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
2709         * Drosera/mac/DebuggerDocumentPlatform.mm:
2710         (DebuggerDocument::platformPause):
2711         (DebuggerDocument::platformResume):
2712         (DebuggerDocument::platformStepInto):
2713         (DebuggerDocument::platformEvaluateScript):
2714         (DebuggerDocument::getPlatformCurrentFunctionStack):
2715         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2716         (DebuggerDocument::platformValueForScopeVariableNamed):
2717         (DebuggerDocument::platformLog):
2718         * Drosera/mac/Drosera.pch: Removed.
2719         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2720         * Drosera/mac/ServerConnection.h: Added.
2721         * Drosera/mac/ServerConnection.mm: Added.
2722         (-[ServerConnection initWithServerName:]):
2723         (-[ServerConnection dealloc]):
2724         (-[ServerConnection setGlobalContext:]):
2725         (-[ServerConnection pause]):
2726         (-[ServerConnection resume]):
2727         (-[ServerConnection stepInto]):
2728         (-[ServerConnection switchToServerNamed:]):
2729         (-[ServerConnection applicationTerminating:]):
2730         (-[ServerConnection serverConnectionDidDie:]):
2731         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2732         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2733         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
2734         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
2735         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
2736         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
2737         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2738         (-[ServerConnection currentFrame]):
2739         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
2740         (-[ServerConnection knownServers]):
2741
2742 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
2743
2744         Reviewed by Eric.
2745
2746         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
2747           Script to automatically search nightly builds for regressions (bisect-builds)
2748
2749         * Scripts/bisect-builds: Added.
2750
2751 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
2752
2753         Reviewed by Darin.
2754
2755         - New JavaScript benchmark
2756         http://bugs.webkit.org/show_bug.cgi?id=15515
2757
2758         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
2759         current development or release build of JavaScriptCore.
2760
2761 2007-10-15  Mark Rowe  <mrowe@apple.com>
2762
2763         Reviewed by Sam.
2764
2765         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
2766
2767         * Scripts/webkitdirs.pm:
2768         - Change checkArgv to remove the options from @ARGV to prevent
2769         them from interfering with further option processing.
2770         - Fix logic error in determineIsQt that would prevent it from bailing out early.
2771         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
2772         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
2773         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
2774
2775 2007-10-15  Darin Adler  <darin@apple.com>
2776
2777         Reviewed by Sam.
2778
2779         - added logging of window.prompt and window.confirm
2780
2781         * DumpRenderTree/mac/UIDelegate.mm:
2782         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2783         Implement the recommended delegate rather than the deprecated one.
2784         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
2785         Added.
2786         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2787         Added.
2788
2789         * DumpRenderTree/win/UIDelegate.h:
2790         * DumpRenderTree/win/UIDelegate.cpp:
2791         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
2792         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
2793         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
2794         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
2795
2796 2007-10-15  Alice Liu  <alice.liu@apple.com>
2797
2798         Reviewed by Sam Weinig.
2799
2800         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
2801
2802         * DumpRenderTree/win/DumpRenderTree.cpp:
2803         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
2804         (main): allocate the global policy delegate for DRT's custom use
2805         * DumpRenderTree/win/DumpRenderTree.vcproj:
2806         Adding files to project
2807         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
2808         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2809         (LayoutTestController::setCustomPolicyDelegate):
2810         set the webview's policy delegate to DRT's custom one if the test requests it.
2811         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
2812         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
2813         (PolicyDelegate::PolicyDelegate):
2814         (PolicyDelegate::QueryInterface):
2815         (PolicyDelegate::AddRef):
2816         (PolicyDelegate::Release):
2817         (PolicyDelegate::decidePolicyForNavigationAction):
2818         * DumpRenderTree/win/PolicyDelegate.h: Added.
2819         (PolicyDelegate::decidePolicyForNewWindowAction):
2820         (PolicyDelegate::decidePolicyForMIMEType):
2821         (PolicyDelegate::unableToImplementPolicyWithError):
2822
2823 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
2824
2825         Reviewed by Mark.
2826
2827         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
2828         when querying for QMAKE_MKSPECS.
2829
2830 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
2831
2832         Reviewed by Adam Roben.
2833         
2834         Fix run-webkit-tests is too greedy calculating platform hierarchy
2835         http://bugs.webkit.org/show_bug.cgi?id=15465
2836         
2837         Fix run-webkit-tests being too greedy in trying to split the platform name up
2838         causing it to try and find tests in every directory above the first "-" in the
2839         path to the LayoutTests
2840
2841         * Scripts/run-webkit-tests:
2842
2843 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
2844
2845         Reviewed by Darin.
2846
2847         http://bugs.webkit.org/show_bug.cgi?id=15006
2848         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
2849         to reduce code duplication.
2850
2851         * Scripts/build-webkit:
2852         * Scripts/webkitdirs.pm:
2853         buildQMakeProject() renamed to buildQMakeQtProject().
2854         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
2855         unused $colorize has been removed.
2856
2857 === Start merge of feature-branch 2007-10-12 ===
2858
2859 2007-10-08  Eric Seidel  <eric@webkit.org>
2860
2861         Reviewed by Mark Rowe.
2862
2863         * Scripts/build-webkit: add --help, remove unused --color
2864
2865 2007-10-07  Eric Seidel  <eric@webkit.org>
2866
2867         Reviewed by darin.
2868
2869         * Drosera/mac/DebuggerDocumentPlatform.mm:
2870         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
2871
2872 2007-10-03  Rob Buis  <buis@kde.org>
2873
2874         Reviewed by Olliej.
2875
2876         Adapt to changed location of Ahem font.
2877
2878         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2879
2880 2007-10-02  Eric Seidel  <eric@webkit.org>
2881
2882         Reviewed by Adam Roben.
2883         
2884         Make pixel tests more useful!
2885         Finally fix the image diff 0.00% mystery problem
2886         Highlight any image differences in the image diff.
2887         Add a link from image diffs back to original test file.
2888
2889         * DumpRenderTree/mac/ImageDiff.m:
2890         (compareImages): highlight any differences
2891         (computePercentageDifferent): round to two decimal places
2892         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
2893
2894 2007-10-02  Eric Seidel  <eric@webkit.org>
2895
2896         Reviewed by Alexey Proskuryakov.
2897
2898         * Scripts/run-webkit-tests: print the % image difference on main results page
2899
2900 2007-10-02  Mark Rowe  <mrowe@apple.com>
2901
2902         Reviewed by Oliver.
2903
2904         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2905
2906         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2907         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2908
2909 2007-10-01  Mark Rowe  <mrowe@apple.com>
2910
2911         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2912
2913 2007-09-25  Eric Seidel  <eric@webkit.org>
2914
2915         Reviewed by Mark Rowe.
2916         
2917         DerivedSources.make was finding "ENABLE_SVG" in the string
2918         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
2919         quite correctly.
2920
2921         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
2922
2923 2007-09-25  Mark Rowe  <mrowe@apple.com>
2924
2925         Rubber-stamped by Eric.
2926
2927         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2928         This makes it possible to automate nightly builds for the feature-branch.
2929
2930 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
2931
2932         Rubber stamped by Mark.
2933
2934         Enable svg experimental features as default here in feature-branch.
2935
2936         * Scripts/build-webkit:
2937
2938 2007-06-29  Antti Koivisto  <antti@apple.com>
2939
2940         Reviewed by Weinig.
2941         
2942         Add VIDEO flag for timed media features
2943
2944         * Scripts/build-webkit
2945         
2946 === End merge of feature-branch 2007-10-12 ===
2947
2948 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2949
2950         Reviewed by Darin.
2951
2952         - Updated rational for the leaks list to be more clear.
2953
2954         * Scripts/run-webkit-tests:
2955
2956 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2957
2958         Rubber Stamp by Sam.
2959
2960         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
2961         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
2962
2963         * Scripts/run-webkit-tests:
2964
2965 2007-10-10  Simon Hausmann  <hausmann@kde.org>
2966
2967         Reviewed by Lars.
2968
2969         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
2970         includes are needed for INT_MAX, std::auto_ptr and the like.
2971
2972         * DumpRenderTree/qt/main.cpp:
2973
2974 2007-10-09  Lars Knoll  <lars@trolltech.com>
2975
2976         Reviewed by Simon.
2977
2978         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
2979
2980         * DumpRenderTree/qt/jsobjects.cpp:
2981         (LayoutTestController::encodeHostName):
2982         (LayoutTestController::decodeHostName):
2983         * DumpRenderTree/qt/jsobjects.h:
2984
2985 2007-10-09  Lars Knoll  <lars@trolltech.com>
2986
2987         Reviewed by Simon.
2988
2989         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
2990
2991         * DumpRenderTree/qt/DumpRenderTree.cpp:
2992         (WebCore::WebPage::createFrame):
2993         (WebCore::DumpRenderTree::DumpRenderTree):
2994         (WebCore::DumpRenderTree::titleChanged):
2995         * DumpRenderTree/qt/DumpRenderTree.h:
2996         * DumpRenderTree/qt/jsobjects.cpp:
2997         (LayoutTestController::reset):
2998         * DumpRenderTree/qt/jsobjects.h:
2999
3000 2007-10-09  Lars Knoll  <lars@trolltech.com>
3001
3002         Reviewed by Simon.
3003
3004         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
3005
3006         * DumpRenderTree/qt/DumpRenderTree.h:
3007         * DumpRenderTree/qt/jsobjects.cpp:
3008         (LayoutTestController::clearBackForwardList):
3009         * DumpRenderTree/qt/jsobjects.h:
3010
3011 2007-10-09  Lars Knoll  <lars@trolltech.com>
3012
3013         Reviewed by Simon.
3014
3015         make --git-reviewer work again.
3016
3017         * Scripts/prepare-ChangeLog:
3018
3019 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
3020
3021         Rubber stamped by Eric.
3022
3023         Connect to the "hovering-over-link" signal emitted by WebKitPage and
3024         show the current link inside the statusbar.
3025         This shows how to make use of this signal and allows to easily test
3026         http://bugs.webkit.org/show_bug.cgi?id=15299.
3027
3028         * GtkLauncher/main.cpp:
3029         (hoveringOverLink):
3030         (main):
3031
3032 2007-10-05  Lars Knoll  <lars@trolltech.com>
3033
3034         add proper error messages to the FrameLoaderClient.
3035         Implement ChromeClientQt::closeWindowSoon and
3036         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
3037         Some fixes in DRT to make it work correctly with multiple windows.
3038
3039         Reviewed by Maciej.
3040
3041         * DumpRenderTree/qt/DumpRenderTree.cpp:
3042         (WebCore::DumpRenderTree::DumpRenderTree):
3043         (WebCore::DumpRenderTree::createWindow):
3044         (WebCore::DumpRenderTree::windowCount):
3045         * DumpRenderTree/qt/DumpRenderTree.h:
3046         * DumpRenderTree/qt/jsobjects.cpp:
3047         (LayoutTestController::maybeDump):
3048         (LayoutTestController::windowCount):
3049         * DumpRenderTree/qt/jsobjects.h:
3050
3051 2007-10-05  Lars Knoll  <lars@trolltech.com>
3052
3053         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
3054         Add support for layoutTextController.setCanOpenWindows() to DRT
3055         fixing another 2 test cases in fast/dom/Window.
3056
3057         Reviewed by Maciej.
3058
3059         * DumpRenderTree/qt/DumpRenderTree.cpp:
3060         (WebCore::WebPage::WebPage):
3061         (WebCore::WebPage::createWindow):
3062         (WebCore::DumpRenderTree::resetJSObjects):
3063         (WebCore::DumpRenderTree::createWindow):
3064         * DumpRenderTree/qt/DumpRenderTree.h:
3065         * DumpRenderTree/qt/DumpRenderTree.pro:
3066         * DumpRenderTree/qt/jsobjects.cpp:
3067         (LayoutTestController::LayoutTestController):
3068         (LayoutTestController::reset):
3069         * DumpRenderTree/qt/jsobjects.h:
3070         * DumpRenderTree/qt/main.cpp:
3071         * DumpRenderTree/qt/testplugin.cpp: Added.
3072         * DumpRenderTree/qt/testplugin.h: Added.
3073
3074 2007-10-04  Sam Weinig  <sam@webkit.org>
3075
3076         Rubber stamped by Adam.
3077
3078         Remove empty directories.
3079
3080         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
3081         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
3082
3083 2007-10-03  Darin Adler  <darin@apple.com>
3084
3085         Reviewed by Adam.
3086
3087         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
3088         we find the internal libraries in the libraries directory. This
3089         is helpful for Safari team engineers at Apple.
3090
3091 2007-10-03  Adam Roben  <aroben@apple.com>
3092
3093         Update the location of AHEM___.TTF after r25968
3094
3095         Reviewed by Sam.
3096
3097         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3098
3099 2007-10-03  Alp Toker  <alp@atoker.com>
3100
3101         Reviewed by Adam.
3102
3103         http://bugs.webkit.org/show_bug.cgi?id=14726
3104         [gtk] API design. Mapping the WebView delegates to signals.
3105
3106         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
3107
3108         * GtkLauncher/main.cpp:
3109         (goToURLBarText):
3110         (titleChanged):
3111         (progressChanged):
3112         (menuMainBackCallback):
3113         (menuMainForwardCallback):
3114         (main):
3115
3116 2007-10-03  Lars Knoll  <lars@trolltech.com>
3117
3118         Reviewed by Rob.
3119
3120         This fixes --strict mode in run-webkit-tests again after
3121         the platform dependent test results have been moved.
3122
3123         * Scripts/run-webkit-tests:
3124
3125 2007-10-03  Lars Knoll  <lars@trolltech.com>
3126
3127         Reviewed by bdash.
3128
3129         remove the hack in run-webkit-tests that forced text only test
3130         to be taken from the platform independent dir. It was only left
3131         there from early days.
3132         
3133         Remove platform dependent results for tests that are text only nowadays,
3134         and add one platform dependent result for a text only test that requires it.
3135
3136         * Scripts/run-webkit-tests:
3137
3138 2007-10-03  Lars Knoll  <lars@trolltech.com>
3139
3140         Reviewed by olliej.
3141
3142         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
3143
3144         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
3145         (WebCore::WebFrame::WebFrame):
3146         (WebCore::WebPage::WebPage):
3147         (WebCore::WebPage::createFrame):
3148         (WebCore::WebPage::javaScriptAlert):
3149         (WebCore::WebPage::javaScriptConsoleMessage):
3150         (WebCore::DumpRenderTree::DumpRenderTree):
3151         (WebCore::DumpRenderTree::~DumpRenderTree):
3152         (WebCore::DumpRenderTree::open):
3153         (WebCore::DumpRenderTree::readStdin):
3154         (WebCore::DumpRenderTree::resetJSObjects):
3155         (WebCore::DumpRenderTree::initJSObjects):
3156         (WebCore::DumpRenderTree::dumpFramesAsText):
3157         (WebCore::DumpRenderTree::dump):
3158         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
3159         (WebCore::DumpRenderTree::layoutTestController):
3160         (WebCore::DumpRenderTree::eventSender):
3161         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
3162         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
3163         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
3164         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
3165         (HackWebFrame::mousePressEvent):
3166         (HackWebFrame::mouseReleaseEvent):
3167         (HackWebFrame::mouseMoveEvent):
3168         (HackWebFrame::HackWebFrame):
3169         (HackWebFrame::~HackWebFrame):
3170         (LayoutTestController::LayoutTestController):
3171         (LayoutTestController::reset):
3172         (LayoutTestController::maybeDump):
3173         (LayoutTestController::waitUntilDone):
3174         (LayoutTestController::notifyDone):
3175         (LayoutTestController::dumpEditingCallbacks):
3176         (LayoutTestController::queueReload):
3177         (LayoutTestController::provisionalLoad):
3178         (LayoutTestController::timerEvent):
3179         (EventSender::EventSender):
3180         (EventSender::mouseDown):
3181         (EventSender::mouseUp):
3182         (EventSender::mouseMoveTo):
3183         (EventSender::leapForward):
3184         (EventSender::keyDown):
3185         (EventSender::frameUnderMouse):
3186         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
3187         (LayoutTestController::isLoading):
3188         (LayoutTestController::setLoading):
3189         (LayoutTestController::shouldDumpAsText):
3190         (LayoutTestController::shouldDumpChildrenAsText):
3191         (LayoutTestController::shouldWaitUntilDone):
3192         (LayoutTestController::dumpAsText):
3193         (LayoutTestController::dumpChildFramesAsText):
3194         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
3195         (messageHandler):
3196         (crashHandler):
3197         (main):
3198         * Scripts/run-webkit-tests:
3199
3200 2007-10-03  Mark Rowe  <mrowe@apple.com>
3201
3202         Reviewed by Alp Toker.
3203
3204         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
3205         should take precedence over QTDIR when determining which port we are working with.
3206
3207         * Scripts/webkitdirs.pm: 
3208
3209 2007-10-02  Adam Roben  <aroben@apple.com>
3210
3211         Add keychain to the list of default packages to install
3212
3213         Rubberstamped by Sam.
3214
3215         * CygwinDownloader/cygwin-downloader.py:
3216         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3217
3218 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
3219
3220         Reviewed by Adam.
3221
3222         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
3223         Also makes WebCore regression test case logic work when using git.
3224
3225         * Scripts/prepare-ChangeLog:
3226         (reviewerAndDescriptionForGitCommit): Added.
3227
3228 2007-10-02  Lars Knoll  <lars@trolltech.com>
3229
3230         Reviewed by bdash.
3231
3232         Add API to retrieve the frame name from QWebFrame.
3233         Implement support for DRT::dumpChildrenAsText.
3234
3235         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3236         (WebCore::DumpRenderTree::dumpFramesAsText):
3237         (WebCore::DumpRenderTree::dump):
3238         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3239         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3240         (LayoutTestController::LayoutTestController):
3241         (LayoutTestController::reset):
3242         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3243
3244 2007-10-02  Lars Knoll  <lars@trolltech.com>
3245
3246         Reviewed by bdash.
3247
3248         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
3249
3250         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3251         (WebCore::DumpRenderTree::readStdin):
3252
3253 2007-10-02  Mark Rowe  <mrowe@apple.com>
3254
3255         Reviewed by Oliver.
3256
3257         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3258
3259         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3260         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3261
3262 2007-10-02  Mark Rowe  <mrowe@apple.com>
3263
3264         Rubber-stamped by Maciej.
3265
3266         Configuration changes from build.webkit.org.  The major change is refactoring to work
3267         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
3268         last few weeks.
3269
3270         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3271         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
3272         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
3273         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
3274         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
3275         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
3276         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
3277         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
3278
3279 2007-10-02  Lars Knoll  <lars@trolltech.com>
3280
3281         Reviewed by Maciej.
3282
3283         Add support for eventSender.mouseMove to DRT.
3284         Fixes fast/css/hover-affects-child.html
3285
3286         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3287         (EventSender::mouseMoveTo):
3288
3289 2007-10-01  Mark Rowe  <mrowe@apple.com>
3290
3291         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3292
3293 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
3294
3295         Reviewed by Hyatt.
3296
3297         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
3298
3299         * Scripts/svn-apply:
3300         (gitdiff2svndiff): Ignore lines beginning with "new file".
3301         * Scripts/svn-unapply:
3302         (gitdiff2svndiff): Ditto.
3303
3304 2007-09-30  George Staikos  <staikos@kde.org>
3305
3306         Qt build fix (Mac OS X specific)
3307
3308         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
3309
3310 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
3311
3312         Reviewed by Mark.
3313
3314         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
3315         Remove Bakefiles from svn.
3316
3317         * GtkLauncher/Bakefiles.bkgen: Removed.
3318         * GtkLauncher/ENV: Removed.
3319         * GtkLauncher/gdklauncher.bkl: Removed.
3320         * GtkLauncher/mk: Removed.
3321         * Scripts/regenerate-makefiles: Removed.
3322
3323 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
3324
3325         Reviewed by John.
3326
3327         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
3328
3329         * Scripts/run-webkit-tests:
3330
3331 2007-09-26  Adam Roben  <aroben@apple.com>
3332
3333         Make not finding an installed WebKit non-fatal
3334
3335         What really matters is that we are able to load WebKit and its
3336         dependencies, not whether we think we've found an installed WebKit.
3337
3338         Reviewed by Sam.
3339
3340         * WebKitInitializer/WebKitInitializer.cpp:
3341         (getWebViewCLSID): Use new LOG_WARNING macro.
3342         (getInstalledWebKitDirectory): Ditto.
3343         (initializeWebKit): Don't die if we didn't find an installed WebKit,
3344         and use new macros.
3345         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
3346
3347 2007-09-26  Adam Roben  <aroben@apple.com>
3348
3349         Committed this file before saving it
3350
3351         * WebKitInitializer/debug_internal.vsprops:
3352
3353 2007-09-26  Adam Roben  <aroben@apple.com>
3354
3355         Load WebKit and its dependencies manually so they come from DllDirectory
3356
3357         I had to change WebKitInitializer to use malloc/free instead of
3358         new/delete to avoid pulling in WebKit (and its dependencies) early
3359         through use of fastMalloc.
3360
3361         Reviewed by Oliver.
3362
3363         * WebKitInitializer/WebKitInitializer.cpp:
3364         (getStringValue): Changed to use malloc/free.
3365         (getInstalledWebKitDirectory): Ditto.
3366         (initializeWebKit): Call SetDllDirectory first, then load all of
3367         WebKit's dependencies manually, finally followed by WebKit itself.
3368         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
3369         configuration to match our other projects.
3370         * WebKitInitializer/debug_internal.vsprops: Added.
3371
3372 2007-09-25  Adam Roben  <aroben@apple.com>
3373
3374         Actually define DEBUG/NDEBUG so that we load WebKit correctly
3375
3376         Rubberstamped by Sam.
3377
3378         * WebKitInitializer/WebKitInitializer.vcproj:
3379
3380 2007-09-25  Adam Roben  <aroben@apple.com>
3381
3382         Make DumpRenderTree delay-load its dependencies
3383
3384         This lets WebKitInitializer re-route the dependencies to be loaded out
3385         of the Safari installation directory.
3386
3387         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
3388         same thing), since we can't import the kCFAllocatorDefault symbol when
3389         delay-loading CoreFoundation.dll.
3390
3391         Rubberstamped by Sam.
3392
3393         * DumpRenderTree/win/DumpRenderTree.cpp:
3394         (runTest):
3395         (javaScriptThreads):
3396         * DumpRenderTree/win/DumpRenderTree.vcproj:
3397         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3398         (LayoutTestController::setWaitToDump):
3399
3400 2007-09-25  Adam Roben  <aroben@apple.com>
3401
3402         Pull ole32.lib into WebKitInitializer
3403
3404         Rubberstamped by Sam.
3405
3406         * WebKitInitializer/WebKitInitializer.vcproj:
3407
3408 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3409
3410         Reviewed by Adam.
3411
3412         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
3413           LGPL'ed files contain incorrect FSF address
3414
3415         * Drosera/config.h:
3416
3417 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3418
3419         Reviewed by Adam.
3420
3421         Make svn-apply and svn-unapply work with git-diff formatted patches.
3422
3423         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
3424         (gitdiff2svndiff): Added.
3425         * Scripts/svn-unapply: Ditto.
3426         (gitdiff2svndiff): Added.
3427
3428 2007-09-25  Adam Roben  <aroben@apple.com>
3429
3430         Pull advapi32.lib into WebKitInitializer
3431
3432         This is needed to get the registry functions we use.
3433
3434         Rubberstamped by Sam.
3435
3436         * WebKitInitializer/WebKitInitializer.vcproj:
3437
3438 2007-09-25  Adam Roben  <aroben@apple.com>
3439
3440         Add python and rsync to cygwin-downloader
3441
3442         Our build slaves need this, and it can't hurt for everyone else to
3443         have it, too.
3444
3445         Reviewed by Sam.
3446
3447         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
3448         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3449
3450 2007-09-25  Adam Roben  <aroben@apple.com>
3451
3452         Add WebKitInitializer and use it in DumpRenderTree
3453
3454         WebKitInitializer is a static library that has one function,
3455         initializeWebKit(). This registers WebKit and sets up the DLL search
3456         path so that WebKit's dependencies that are installed with Safari can
3457         be found.
3458
3459         Reviewed by Sam.
3460
3461         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
3462         DumpRenderTree depend on it.
3463         * DumpRenderTree/win/DumpRenderTree.cpp:
3464         (initialize): Call initializeWebKit.
3465         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
3466         WebKitInitializer.lib.
3467         * WebKitInitializer/WebKitInitializer.cpp: Added.
3468         (getStringValue):
3469         (getWebViewCLSID):
3470         (getInstalledWebKitDirectory):
3471         (initializeWebKit):
3472         * WebKitInitializer/WebKitInitializer.h: Added.
3473         * WebKitInitializer/WebKitInitializer.vcproj: Added.
3474         * WebKitInitializer/debug.vsprops: Added.
3475         * WebKitInitializer/release.vsprops: Added.
3476
3477 2007-09-25  Adam Roben  <aroben@apple.com>
3478
3479         Make run-webkit-tests respect set-webkit-configuration
3480
3481         Reviewed by Sam.
3482
3483         * Scripts/run-webkit-tests: Initialize $configuration to whatever
3484         set-webkit-configuration was last set to.
3485
3486 2007-09-25  Mark Rowe  <mrowe@apple.com>
3487
3488         Rubber-stamped by Eric.
3489
3490         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3491         This makes it possible to automate nightly builds for the feature-branch.
3492
3493 2007-09-25  Adam Roben  <aroben@apple.com>
3494
3495         A couple of fixes/enhancements to update-webkit-*-libs
3496
3497         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
3498         to tell update-webkit-support-libraries where it should find the
3499         WebKitSupportLibrary.zip file you downloaded.
3500
3501         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
3502         Windows-style path.
3503
3504         Reviewed by Sam.
3505
3506         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
3507         to $auxiliaryLibsURL and removed an irrelevant comment.
3508         * Scripts/update-webkit-support-libs:
3509
3510 2007-09-25  Adam Treat  <treat@kde.org>
3511
3512         Reviewed by Simon and Lars.
3513
3514         Refactors and cleans up Qt DRT member variable names, member variable
3515         initialization, style fixes and general code cleanup.
3516
3517         Adds queueReload slot to LayoutTestController that some tests require.
3518
3519         Subclasses QWebFrame to make sure that all frames have an associated
3520         LayoutTestController JS window object.
3521
3522         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
3523         aren't dumped twice.
3524
3525         EOF fixes.
3526
3527         Together, this patch fixes some 20+ layout tests in QtWebKit.
3528
3529         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3530         (WebCore::WebFrame::WebFrame):
3531         (WebCore::WebPage::WebPage):
3532         (WebCore::WebPage::createFrame):
3533         (WebCore::DumpRenderTree::DumpRenderTree):
3534         (WebCore::DumpRenderTree::open):
3535         (WebCore::DumpRenderTree::readStdin):
3536         (WebCore::DumpRenderTree::initJSObjects):
3537         (WebCore::DumpRenderTree::dump):
3538         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3539         (WebCore::DumpRenderTree::layoutTestController):
3540         (WebCore::DumpRenderTree::eventSender):
3541         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3542         (LayoutTestController::LayoutTestController):
3543         (LayoutTestController::reset):
3544         (LayoutTestController::maybeDump):
3545         (LayoutTestController::waitUntilDone):
3546         (LayoutTestController::notifyDone):
3547         (LayoutTestController::queueReload):
3548         (LayoutTestController::provisionalLoad):
3549         (EventSender::EventSender):
3550         (EventSender::mouseDown):
3551         (EventSender::mouseUp):
3552         (EventSender::mouseMoveTo):
3553         (EventSender::frameUnderMouse):
3554         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3555         (LayoutTestController::isLoading):
3556         (LayoutTestController::setLoading):
3557         (LayoutTestController::dumpAsText):
3558         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
3559         (main):
3560
3561 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3562
3563
3564         - Reverted an accidentally checked in file.
3565
3566         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
3567
3568 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3569         Reviewed by Sam.
3570
3571         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
3572
3573         * DumpRenderTree/win/DumpRenderTree.vcproj:
3574         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3575
3576 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3577
3578         Rubber stamped by Adam.
3579
3580         * GdkLauncher: Removed.
3581         * GdkLauncher/Bakefiles.bkgen: Removed.
3582         * GdkLauncher/ENV: Removed.
3583         * GdkLauncher/GdkLauncher.pro: Removed.
3584         * GdkLauncher/gdklauncher.bkl: Removed.
3585         * GdkLauncher/main.cpp: Removed.
3586         * GdkLauncher/mk: Removed.
3587         * GdkLauncher/simple.svg: Removed.
3588         * GdkLauncher/text.html: Removed.
3589         * GtkLauncher: Added.
3590         * GtkLauncher/GdkLauncher.pro: Removed.
3591         * GtkLauncher/GtkLauncher.pro: Added.
3592         * GtkLauncher/main.cpp:
3593         (updateWindowTitle):
3594         (main):
3595         * Scripts/build-webkit:
3596         * Scripts/regenerate-makefiles:
3597         * Scripts/run-javascriptcore-tests:
3598         * Scripts/run-launcher:
3599         * Scripts/run-webkit-tests:
3600         * Scripts/webkitdirs.pm:
3601
3602 2007-09-21  Timothy Hatcher  <timothy@apple.com>
3603
3604         Reviewed by Darin.
3605
3606         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
3607
3608         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
36