2009-11-19 Adam Barth <abarth@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-19  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
6         https://bugs.webkit.org/show_bug.cgi?id=31707
7
8         This is to help when we implement build-attachment.
9
10         * Scripts/bugzilla-tool:
11
12 2009-11-19  Adam Barth  <abarth@webkit.org>
13
14         Reviewed by Eric Seidel.
15
16         Support Qt port in bugzilla-tool
17         https://bugs.webkit.org/show_bug.cgi?id=31701
18
19         Now we support building with Qt!
20
21         * Scripts/bugzilla-tool:
22         * Scripts/modules/webkitport.py: Added.
23         * Scripts/modules/webkitport_unittest.py: Added.
24         * Scripts/run-webkit-unittests:
25
26 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
27
28         Reviewed by Adam Barth.
29
30         Remove inserting stderr into patch in bugzilla-tool
31         https://bugs.webkit.org/show_bug.cgi?id=29914
32
33         Modify SCM python module's run_command function to avoid return of stderr
34         by default, so stderr won't be inserted into the patches.
35         Modify the related unit test.
36
37         * Scripts/modules/scm.py:
38         * Scripts/modules/scm_unittest.py:
39
40 2009-11-19  Eric Seidel  <eric@webkit.org>
41
42         Reviewed by Adam Barth.
43
44         bugzilla-tool needs per-command help
45         https://bugs.webkit.org/show_bug.cgi?id=31697
46
47         Added support for "bugzilla-tool help command-name"
48         and a unit test to make sure it works.
49
50         * Scripts/modules/multicommandtool.py:
51         * Scripts/modules/multicommandtool_unittest.py:
52
53 2009-11-19  Eric Seidel  <eric@webkit.org>
54
55         Reviewed by Adam Barth.
56
57         Move MultiCommandTool and Command into a separate file and add some basic unit tests
58         https://bugs.webkit.org/show_bug.cgi?id=31695
59
60         * Scripts/bugzilla-tool:
61         * Scripts/modules/multicommandtool.py: Added.
62         * Scripts/modules/multicommandtool_unittest.py: Added.
63         * Scripts/run-webkit-unittests:
64
65 2009-11-19  Eric Seidel  <eric@webkit.org>
66
67         No review, just adding a FIXME.
68
69         Split out command parsing and help printing from BugzillaTool
70         https://bugs.webkit.org/show_bug.cgi?id=31688
71
72         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
73
74 2009-11-19  Eric Seidel  <eric@webkit.org>
75
76         Reviewed by Adam Barth.
77
78         Split out command parsing and help printing from BugzillaTool
79         https://bugs.webkit.org/show_bug.cgi?id=31688
80
81         * Scripts/bugzilla-tool:
82          - Add new MultiCommandTool class to contain option parsing and help printing logic.
83          - Rename private methods to use _ pattern.
84          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
85          - 
86
87 2009-11-19  Eric Seidel  <eric@webkit.org>
88
89         Reviewed by Adam Barth.
90
91         Re-factor help printing to use modern python idioms
92         https://bugs.webkit.org/show_bug.cgi?id=31685
93
94         * Scripts/bugzilla-tool:
95
96 2009-11-19  Eric Seidel  <eric@webkit.org>
97
98         Reviewed by Darin Adler.
99
100         commit-queue empty queue logs twice
101         https://bugs.webkit.org/show_bug.cgi?id=31679
102
103         * Scripts/bugzilla-tool:
104
105 2009-11-19  Eric Seidel  <eric@webkit.org>
106
107         Reviewed by Darin Adler.
108
109         bugzilla-tool's reviewer/committer rejection message should be clearer
110         https://bugs.webkit.org/show_bug.cgi?id=31126
111
112         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
113
114         * Scripts/modules/bugzilla.py:
115
116 2009-11-19  Eric Z. Ayers  <zundel@google.com>
117
118         Reviewed by Pavel Feldman.
119
120         Forces a WM_PAINT event on calling layoutTestController.display()
121         in order to enable the timeline-paint.html test on Windows.
122         ::UpdateWindow() does not force an event becaue the window is 
123         not visible.
124
125         https://bugs.webkit.org/show_bug.cgi?id=31402
126
127         * DumpRenderTree/win/DumpRenderTree.cpp:
128         (displayWebView):
129
130 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
131
132         No review needed.
133
134         Added myself to committers list.
135
136         * Scripts/modules/committers.py:
137
138 2009-11-19  Adam Barth  <abarth@webkit.org>
139
140         Reviewed by Eric Seidel.
141
142         Bugzilla-tool command classes should match command names
143         https://bugs.webkit.org/show_bug.cgi?id=31666
144
145         I renamed all the commands except CommitMessageForCurrentDiff because
146         the new name would conflict with an existing class.
147
148         * Scripts/bugzilla-tool:
149
150 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
151
152         Reviewed by Gustavo Noronha Silva.
153
154         Web Inspector: Implement "show inspector" in WebKit GTK
155         API and enable console tests.
156
157         https://bugs.webkit.org/show_bug.cgi?id=31669
158
159         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
160         (LayoutTestController::showWebInspector):
161
162 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
163
164         Reviewed by Simon Hausmann.
165
166         Minor refactoring + more documentation.
167
168         * DumpRenderTree/qt/DumpRenderTree.cpp:
169         (WebCore::clearHistory):
170         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
171
172 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
173
174         Reviewed by Eric Seidel.
175
176         Ignore websocket tests when --no-http is specified.
177         https://bugs.webkit.org/show_bug.cgi?id=31662
178
179         * Scripts/run-webkit-tests:
180
181 2009-11-18  Adam Barth  <abarth@webkit.org>
182
183         Reviewed by Eric Seidel.
184
185         Normalize ' and " in bugzilla-tool
186         https://bugs.webkit.org/show_bug.cgi?id=31655
187
188         We decided " is better than ' and we should be consistent.
189
190         * Scripts/bugzilla-tool:
191
192 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
193
194         Reviewed by Kenneth Rohde Christiansen.
195
196         [Qt] Remove support for Qt v4.3 or older versions
197         https://bugs.webkit.org/show_bug.cgi?id=29469
198
199         * DumpRenderTree/qt/DumpRenderTree.pro:
200         * DumpRenderTree/qt/ImageDiff.pro:
201
202 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
203
204         Reviewed by Eric Seidel.
205
206         GitTest.test_create_binary_patch fails if /tmp is symlink
207         https://bugs.webkit.org/show_bug.cgi?id=31536
208
209         * Scripts/modules/scm_unittest.py:
210
211 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
212
213         Reviewed by Darin Adler.
214
215         Configuration for Chromium Build Slaves.
216
217         https://bugs.webkit.org/show_bug.cgi?id=31442
218
219         * BuildSlaveSupport/build.webkit.org-config/config.json:
220         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
221
222 2009-11-18  Eric Seidel  <eric@webkit.org>
223
224         Reviewed by Darin Adler.
225
226         workqueue.py results in totally broken commit-queue UI
227         https://bugs.webkit.org/show_bug.cgi?id=31645
228
229         * Scripts/bugzilla-tool:
230          - Remove unneeded use of PatchCollection.
231          - Grab a new copy of the cq'd patches every run of the queue.
232
233 2009-11-18  Sam Weinig  <sam@webkit.org>
234
235         Reviewed by Anders Carlsson.
236
237         Make the Mac Geolocation API async.
238
239         Update DRT to use the new async Mac Geolocation API.
240
241         * DumpRenderTree/mac/UIDelegate.mm:
242         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
243
244 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
245
246         Reviewed by Kenneth Rohde Christiansen.
247
248         Add and option to toggle HTML5 datalist support to build-webkit
249         https://bugs.webkit.org/show_bug.cgi?id=31599
250
251         * Scripts/build-webkit:
252
253 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
254
255         Reviewed by Kevin Ollivier.
256
257         Enable wx plugin support using the Windows implementation as a base.
258         
259         https://bugs.webkit.org/show_bug.cgi?id=31636
260
261         * wx/build/settings.py:
262
263 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
264
265         Reviewed by Simon Hausmann.
266
267         Change the initialization order so that the controllers
268         will be created before exporting them to the JS DOM window.
269
270         * DumpRenderTree/qt/DumpRenderTree.cpp:
271         (WebCore::DumpRenderTree::DumpRenderTree):
272
273 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
274
275         Reviewed by Simon Hausmann.
276
277         Fix a code copy and paste error. m_page should be page.
278
279         * DumpRenderTree/qt/DumpRenderTree.cpp:
280         (WebCore::DumpRenderTree::createWindow):
281
282 2009-11-17  Mark Rowe  <mrowe@apple.com>
283
284         Reviewed by Alexey Proskuryakov.
285
286         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
287
288         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
289         This prevents symlinks from confusing the descendant check.
290
291 2009-11-17  Mark Rowe  <mrowe@apple.com>
292
293         Reviewed by Alexey Proskuryakov.
294
295         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
296
297         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
298         server to be up rather than having run-webkit-tests abort immediately.
299
300         * Scripts/run-webkit-tests:
301
302 2009-11-17  Eric Seidel  <eric@webkit.org>
303
304         Reviewed by Darin Adler.
305
306         commit-queue is failing to set reviewer in ChangeLogs
307         https://bugs.webkit.org/show_bug.cgi?id=31592
308
309         * Scripts/bugzilla-tool: Clarify the "applying" log message.
310         * Scripts/modules/bugzilla.py:
311          - Add a new _validate_committer_and_reviewer function as a
312            temporary solution until we can make a real Attachment object
313            which knows how to fill in its committer/reviewer fields automatically.
314
315 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
316
317         Unreviewed buildbot fix.
318
319         Revert part of earlier patch and add comment, as it
320         was causing timeouts on the buildbot.
321
322         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
323         (LayoutTestController::notifyDone):
324
325 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
326
327         Reviewed by Oliver Hunt.
328
329         Make the timeout 15 sec as for the other DRT's and make
330         it print out the same output when a test timeout.
331
332         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
333         (LayoutTestController::waitUntilDone):
334         (LayoutTestController::notifyDone):
335         (LayoutTestController::timerEvent):
336
337 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
338
339         Reviewed by Timothy Hatcher.
340
341         Fixed typos in comments.
342
343         * Scripts/modules/committers.py:
344
345 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
346
347         Reviewed by Timothy Hatcher.
348
349         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
350         - Updated DRT to show/close inspector for all tests under /inspector
351         - Introduced LayoutTestController::setTimelineProfilingEnabled and
352           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
353         - Removed reload on each inspector test
354         - Renamed fast/inspector to fast/inspector-support in order not to trigger
355         inspector for those.
356         - Reimplemented timeline tests in order to get rid of reload there.
357         - Moved tests that don't require harness into the fast group.
358
359         https://bugs.webkit.org/show_bug.cgi?id=31472
360
361         * DumpRenderTree/LayoutTestController.cpp:
362         (setTimelineProfilingEnabledCallback):
363         (closeWebInspectorCallback):
364         (LayoutTestController::staticFunctions):
365         * DumpRenderTree/LayoutTestController.h:
366         * DumpRenderTree/gtk/DumpRenderTree.cpp:
367         (shouldOpenWebInspector):
368         (runTest):
369         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
370         (LayoutTestController::setTimelineProfilingEnabled):
371         * DumpRenderTree/mac/DumpRenderTree.mm:
372         (shouldOpenWebInspector):
373         (runTest):
374         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
375         (LayoutTestController::setTimelineProfilingEnabled):
376         * DumpRenderTree/win/DumpRenderTree.cpp:
377         (shouldOpenWebInspector):
378         (runTest):
379         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
380         (LayoutTestController::setTimelineProfilingEnabled):
381
382 2009-11-17  Oliver Hunt  <oliver@apple.com>
383
384         Reviewed by Maciej Stachowiak.
385
386         Incorrect use of JavaScriptCore API in DumpRenderTree
387         https://bugs.webkit.org/show_bug.cgi?id=31577
388
389         Return undefined rather than a literal null.
390
391         * DumpRenderTree/AccessibilityUIElement.cpp:
392         (setSelectedTextRangeCallback):
393         (incrementCallback):
394         (decrementCallback):
395         (showMenuCallback):
396
397 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
398
399         Reviewed by Beth Dakin.
400
401         AX: aria-labelledby duplicates some of its WAI-ARIA label
402         https://bugs.webkit.org/show_bug.cgi?id=31565
403
404         * DumpRenderTree/AccessibilityUIElement.cpp:
405         (titleUIElementCallback):
406         (getIsValidCallback):
407         (AccessibilityUIElement::getJSClass):
408
409 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
410
411         Reviewed by Simon Hausmann.
412
413         r50942 broke output from created windows. Make the
414         m_enableTextOutput a member of the DRT and not the
415         WebPage.
416
417         * DumpRenderTree/qt/DumpRenderTree.cpp:
418         (WebCore::WebPage::WebPage):
419         (WebCore::WebPage::javaScriptAlert):
420         (WebCore::WebPage::javaScriptConsoleMessage):
421         (WebCore::WebPage::javaScriptConfirm):
422         (WebCore::WebPage::javaScriptPrompt):
423         (WebCore::WebPage::acceptNavigationRequest):
424         (WebCore::DumpRenderTree::DumpRenderTree):
425         (WebCore::DumpRenderTree::open):
426         (WebCore::DumpRenderTree::createWindow):
427         * DumpRenderTree/qt/DumpRenderTree.h:
428         (WebCore::DumpRenderTree::setTextOutputEnabled):
429         (WebCore::DumpRenderTree::isTextOutputEnabled):
430         (WebCore::WebPage::shouldInterruptJavaScript):
431         (WebCore::WebPage::isTextOutputEnabled):
432         (WebCore::WebPage::setViewGeometry):
433
434 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
435
436         Reviewed by Gustavo Noronha Silva.
437
438         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
439         as the implementation is being used by at least Qt and Gtk+.
440
441         Update buildsystems as well.
442
443         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
444         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
445         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
446         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
447         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
448         * GNUmakefile.am:
449
450 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
451
452         Reviewed by Alexey Proskuryakov.
453
454         Disable wss until all platforms support pyOpenSSL
455
456         https://bugs.webkit.org/show_bug.cgi?id=31479
457
458         * Scripts/run-webkit-tests:
459
460 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
461
462         Reviewed by Kenneth Christiansen.
463
464         [Qt] Implement load error pages support for Qt's DRT.
465         https://bugs.webkit.org/show_bug.cgi?id=31509
466
467         For now, it will not be a default feature, and layout tests
468         that want to make use of this have to explicitily call
469         'handleErrorPages();' for the test source.
470
471         Any of the other DumpRenderTree's (mac, win and gtk)
472         support handling error pages. Qt's will be the first.
473
474         * DumpRenderTree/qt/DumpRenderTree.cpp:
475         (WebCore::WebPage::supportsExtension):
476         (WebCore::WebPage::extension):
477         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
478         (LayoutTestController::reset):
479         * DumpRenderTree/qt/LayoutTestControllerQt.h:
480         (LayoutTestController::shouldHandleErrorPages):
481         (LayoutTestController::handleErrorPages):
482
483 2009-11-16  Eric Seidel  <eric@webkit.org>
484
485         Reviewed by Adam Barth.
486
487         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
488         https://bugs.webkit.org/show_bug.cgi?id=31549
489
490         Renamed --commit-queue to --non-interactive in most places
491         and remove the code in land-patches which is no longer needed.
492
493         * Scripts/bugzilla-tool:
494
495 2009-11-16  Eric Seidel  <eric@webkit.org>
496
497         Reviewed by Adam Barth.
498
499         The commit-queue should use land-attachment
500         https://bugs.webkit.org/show_bug.cgi?id=31548
501
502         * Scripts/bugzilla-tool:
503
504 2009-11-16  Adam Barth  <abarth@webkit.org>
505
506         Reviewed by Eric Seidel.
507
508         Convert CommitQueue over to PatchCollection
509         https://bugs.webkit.org/show_bug.cgi?id=31547
510
511         Also fixes a bug in workqueue and adds a test!
512
513         * Scripts/bugzilla-tool:
514         * Scripts/modules/workqueue.py:
515         * Scripts/modules/workqueue_unittest.py:
516
517 2009-11-16  Adam Barth  <abarth@webkit.org>
518
519         Reviewed by Eric Seidel.
520
521         Move StyleQueue over to using PatchCollection
522         https://bugs.webkit.org/show_bug.cgi?id=31544
523
524         That's what the class it's for.
525
526         * Scripts/bugzilla-tool:
527         * Scripts/modules/patchcollection.py:
528         * Scripts/modules/patchcollection_unittest.py:
529
530 2009-11-16  Eric Seidel  <eric@webkit.org>
531
532         Reviewed by Adam Barth.
533
534         bugzilla-tool needs a land-attachment command
535         https://bugs.webkit.org/show_bug.cgi?id=31546
536
537         * Scripts/bugzilla-tool:
538          - Move all the logic into AbstractLandingCommand and
539            add a new LandAttachment command subclass.
540          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
541
542 2009-11-16  Eric Seidel  <eric@webkit.org>
543
544         Reviewed by Adam Barth.
545
546         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
547         https://bugs.webkit.org/show_bug.cgi?id=31543
548
549         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
550
551         * Scripts/bugzilla-tool:
552
553 2009-11-16  Eric Seidel  <eric@webkit.org>
554
555         Reviewed by Adam Barth.
556
557         Disable the style queue from posting to the commit queue status page.
558
559         * Scripts/bugzilla-tool:
560
561 2009-11-16  Adam Barth  <abarth@webkit.org>
562
563         Reviewed by Eric Seidel.
564
565         Implement PatchCollection
566         https://bugs.webkit.org/show_bug.cgi?id=31541
567
568         This class holds a set of patches and lets clients iterate through
569         them.  Optionally, clients can install a filter.
570
571         * Scripts/modules/patchcollection.py: Added.
572         * Scripts/modules/patchcollection_unittest.py: Added.
573         * Scripts/run-webkit-unittests:
574
575 2009-11-16  Eric Seidel  <eric@webkit.org>
576
577         Reviewed by Adam Barth.
578
579         bugzilla-tool land-patches will close bugs with patches r=?
580         https://bugs.webkit.org/show_bug.cgi?id=28230
581
582         The commit-queue shouldn't close patches with outstanding reviews on them,
583         even if many reviewers seem to be against multi-patch bugs.
584
585         * Scripts/bugzilla-tool:
586
587 2009-11-16  Eric Seidel  <eric@webkit.org>
588
589         Reviewed by Adam Barth.
590
591         bugzilla-tool check-style should work with attachment ids instead of bug ids
592         https://bugs.webkit.org/show_bug.cgi?id=31540
593
594         * Scripts/bugzilla-tool:
595
596 2009-11-16  Eric Seidel  <eric@webkit.org>
597
598         Reviewed by Adam Barth.
599
600         WorkQueue is the only place that should know about special exit codes
601         https://bugs.webkit.org/show_bug.cgi?id=31534
602
603         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
604         and add tests for handling exit codes.
605         I also cleaned up workqueue_unittest.py more.
606
607         * Scripts/bugzilla-tool:
608         * Scripts/modules/workqueue.py:
609         * Scripts/modules/workqueue_unittest.py:
610
611 2009-11-16  Eric Seidel  <eric@webkit.org>
612
613         Reviewed by Adam Barth.
614
615         Re-factor workqueue_unittest to allow for more than one test.
616         https://bugs.webkit.org/show_bug.cgi?id=31535
617
618         * Scripts/modules/workqueue_unittest.py:
619
620 2009-11-16  Eric Seidel  <eric@webkit.org>
621
622         Reviewed by Adam Barth.
623
624         land-patches needs to be re-factored into smaller chunks
625         https://bugs.webkit.org/show_bug.cgi?id=31532
626
627         * Scripts/bugzilla-tool: fix a couple obvious typos.
628
629 2009-11-16  Eric Seidel  <eric@webkit.org>
630
631         Reviewed by Adam Barth.
632
633         land-patches needs to be re-factored into smaller chunks
634         https://bugs.webkit.org/show_bug.cgi?id=31532
635
636         The next patch will move these methods into WebKitLandingScripts.
637
638         * Scripts/bugzilla-tool:
639          - Split out _land_patch and _close_bug_if_no_active_patches.
640
641 2009-11-16  Adam Barth  <abarth@webkit.org>
642
643         Reviewed by Eric Seidel.
644
645         Fix silly copy-and-paste code.  I am a terrible coder.
646
647         * Scripts/modules/bugzilla.py:
648
649 2009-11-16  Adam Barth  <abarth@webkit.org>
650
651         Reviewed by Eric Seidel.
652
653         Implement a StyleQueue
654         https://bugs.webkit.org/show_bug.cgi?id=31537
655
656         The first iteration of the style queue only produces output locally.
657         There is also a limit of 10 patches because it's not that useful to
658         iterate through the entire review queue at this point.  We can remove
659         the limit later.
660
661         * Scripts/bugzilla-tool:
662         * Scripts/modules/bugzilla.py:
663
664 2009-11-16  Adam Barth  <abarth@webkit.org>
665
666         Reviewed by Eric Seidel.
667
668         Unit test WorkQueue
669         https://bugs.webkit.org/show_bug.cgi?id=31531
670
671         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
672
673         * Scripts/bugzilla-tool:
674         * Scripts/modules/statusbot.py:
675         * Scripts/modules/workqueue.py:
676         * Scripts/modules/workqueue_unittest.py: Added.
677         * Scripts/run-webkit-unittests:
678
679 2009-11-16  Eric Seidel  <eric@webkit.org>
680
681         Reviewed by Adam Barth.
682
683         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
684         https://bugs.webkit.org/show_bug.cgi?id=31530
685
686         * Scripts/bugzilla-tool:
687
688 2009-11-16  Eric Seidel  <eric@webkit.org>
689
690         Reviewed by Adam Barth.
691
692         bugzilla-tool needs apply-attachment
693         https://bugs.webkit.org/show_bug.cgi?id=31528
694
695         * Scripts/bugzilla-tool:
696          - Add ApplyAttachment command.
697          - Abstract applying code into WebKitApplyingScripts.
698          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
699         * Scripts/modules/bugzilla.py:
700          - Add fetch_attachment and bug_id_for_attachment_id.
701         * Scripts/modules/bugzilla_unittest.py:
702          - Add test for new parsing.
703          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
704
705 2009-11-16  Eric Seidel  <eric@webkit.org>
706
707         Reviewed by Adam Barth.
708
709         Document check-style's use of force_clean.
710
711         * Scripts/bugzilla-tool:
712         * Scripts/modules/scm.py:
713
714 2009-11-16  Adam Barth  <abarth@webkit.org>
715
716         Reviewed by Eric Seidel.
717
718         Move WorkQueue to its own file
719         https://bugs.webkit.org/show_bug.cgi?id=31529
720
721         WorkQueue and WorkQueueDelegate are separate concerns from
722         bugzilla-tool.  Also added a missing include to logging.py.
723
724         * Scripts/bugzilla-tool:
725         * Scripts/modules/logging.py:
726         * Scripts/modules/workqueue.py:
727
728 2009-11-16  Adam Barth  <abarth@webkit.org>
729
730         Reviewed by Eric Seidel.
731
732         Move OutputTee to logging.py.
733
734         * Scripts/bugzilla-tool:
735         * Scripts/modules/logging.py:
736
737 2009-11-15  Adam Barth  <abarth@webkit.org>
738
739         Reviewed by Eric Seidel.
740
741         Refactor bugzilla-tool to allow for multiple queues
742         https://bugs.webkit.org/show_bug.cgi?id=31513
743
744         Divide the commit queue class into three class to make creating
745         additional queues easier.
746
747         * Scripts/bugzilla-tool:
748
749 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
750
751         Reviewed by Eric Seidel.
752
753         svn-apply may not handle git patches created by bugzilla-tool
754         https://bugs.webkit.org/show_bug.cgi?id=31457
755
756         * Scripts/modules/scm.py:
757         * Scripts/modules/scm_unittest.py:
758
759 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
760
761         Reviewed by Eric Seidel.
762
763         bugzilla-tool should post git binary diff
764         https://bugs.webkit.org/show_bug.cgi?id=31458
765
766         Add --binary option to Git.create_patch.
767
768         * Scripts/modules/scm.py:
769         * Scripts/modules/scm_unittest.py:
770
771 2009-11-15  Adam Barth  <abarth@webkit.org>
772
773         Reviewed by Darin Adler.
774
775         Add bugzilla-tool check-style
776         https://bugs.webkit.org/show_bug.cgi?id=31515
777
778         * Scripts/bugzilla-tool:
779         * Scripts/modules/bugzilla.py:
780
781 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
782
783         Reviewed by Simon Hausmann.
784
785         Make the Qt Linux only --valgrind feature, suppress errors
786         defined in the SuppressedValgrindErrors file.
787
788         * Scripts/run-webkit-tests:
789
790 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
791
792         Reviewed by Simon Hausmann.
793
794         Set the locale to C and not to the current one in use on the system.
795
796         * DumpRenderTree/qt/DumpRenderTree.cpp:
797         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
798
799 2009-11-13  Adam Roben  <aroben@apple.com>
800
801         Add support for
802         http/tests/security/isolatedWorld/didClearWindowObject.html
803
804         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
805         window objects in isolated worlds are cleared
806
807         Reviewed by Dave Hyatt.
808
809         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
810
811         * DumpRenderTree/mac/FrameLoadDelegate.mm:
812         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
813         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
814         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
815         Added. Sets a __worldID property on the global object whose value is
816         the ID of this world.
817         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
818         Respond to this new delegate callback by calling through to one of the
819         above new methods.
820         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
821         (worldMap): Added. Returns a HashMap containing all the worlds we've
822         created.
823         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
824         haven't kept track of this world.
825         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
826         instead of declaring our own.
827
828         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
829
830         * DumpRenderTree/win/FrameLoadDelegate.cpp:
831         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
832         didClearWindowObjectForFrameInStandardWorld.
833         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
834         Respond to this new delegate callback by calling through to one of the
835         below new methods.
836         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
837         Added. Sets a __worldID property on the gobal object whose value is
838         the ID of this world.
839         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
840         Added. Moved code here from didClearWindowObject.
841
842         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
843         didClearWindowObjectForFrame* functions.
844
845         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
846         (worldMap): Added. Returns a HashMap containing all the worlds we've
847         created.
848         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
849         haven't kept track of this world.
850         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
851         instead of declaring our own.
852
853 2009-11-13  Adam Roben  <aroben@apple.com>
854
855         Finish replacing worldIDs with world objects
856
857         The only remaining use of worldIDs was in a method only used by DRT
858         for the isolated worlds tests.
859
860         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
861
862         Reviewed by Mark Rowe.
863
864         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
865         (LayoutTestController::evaluateScriptInIsolatedWorld):
866         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
867         (LayoutTestController::evaluateScriptInIsolatedWorld):
868         Updated for changes to WebFrame. Now holds the map of worldID -> world
869         at this level instead of making WebKit do it.
870
871 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
872
873         Reviewed by Simon Hausmann.
874
875         [Qt] Ensure the DRT does not output anything until first test is run
876
877         * DumpRenderTree/qt/DumpRenderTree.cpp:
878         * DumpRenderTree/qt/DumpRenderTree.h:
879
880 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
881
882         Reviewed by Tor Arne Vestbø.
883
884         Clear the undo stack in before each new test run.
885
886         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
887
888         * DumpRenderTree/qt/DumpRenderTree.cpp:
889         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
890
891 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
892
893         Reviewed by Kenneth Rohde Christiansen.
894
895         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
896
897         * DumpRenderTree/qt/DumpRenderTree.cpp:
898         (WebCore::WebPage::resetSettings):
899         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
900         (LayoutTestController::overridePreference):
901
902 2009-11-13  Eric Seidel  <eric@webkit.org>
903
904         Reviewed by Adam Barth.
905
906         Update committers.py based on svn records
907         https://bugs.webkit.org/show_bug.cgi?id=31366
908
909         This list was generated using validate-committer-lists from
910         https://bugs.webkit.org/show_bug.cgi?id=30970
911         and makes committers.py current for committers who have
912         committed in the last 3 years.
913
914         * Scripts/modules/committers.py:
915
916 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
917
918         Reviewed by Adam Barth.
919
920         The document-open.html test was flaky at times. The test invokes the layout test plugin
921         which in its destroy stream handler opens a new document. This basically tears down the
922         stream and the associated plugin instance. The pluginLog function in the layout test
923         plugin attempts to retrieve the window script object on a torn down plugin instance
924         which crashed consistently on windows in the debugger. The functions which issue
925         these logs already have a valid window script object. We now have variants of the pluginLog
926         function which take in a window script object with and without variable arguments. 
927
928         https://bugs.webkit.org/show_bug.cgi?id=31067
929
930         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
931         (pluginLogWithWindowObject):
932         (pluginLogWithWindowObjectVariableArgs):
933         (pluginLog):
934         (notifyTestCompletion):
935         (testDocumentOpen):
936         (testWindowOpen):
937
938 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
939
940         Reviewed by Gustavo Noronha Silva.
941
942         https://bugs.webkit.org/show_bug.cgi?id=30997
943         [Gtk] Implemment AtkDocument
944
945         Added testing support.
946
947         * DumpRenderTree/AccessibilityUIElement.cpp:
948         * DumpRenderTree/AccessibilityUIElement.h:
949         (getDocumentEncodingCallback):
950         (getDocumentURICallback):
951         (AccessibilityUIElement::getJSClass):
952         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
953         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
954         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
955         (AccessibilityUIElement::documentEncoding):
956         (AccessibilityUIElement::documentURI):
957
958 2009-11-12  Adam Roben  <aroben@apple.com>
959
960         Replace worldIDs with world objects
961
962         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
963         user scripts/stylesheets and isolated worlds
964
965         Reviewed by Sam Weinig.
966
967         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
968         (LayoutTestController::addUserScript):
969         (LayoutTestController::addUserStyleSheet):
970         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
971         (LayoutTestController::addUserScript):
972         (LayoutTestController::addUserStyleSheet):
973         Changed these functions to create a new WebJSWorld each time they're
974         called and to pass that world to WebKit.
975
976 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
977
978         Reviewed by Oliver Hunt.
979
980         need to implement aria tree roles
981         https://bugs.webkit.org/show_bug.cgi?id=31284
982
983         * DumpRenderTree/AccessibilityUIElement.cpp:
984         (disclosedRowAtIndexCallback):
985         (selectedRowAtIndexCallback):
986         (isEqualCallback):
987         (isAttributeSettableCallback):
988         (isActionSupportedCallback):
989         (disclosedByRowCallback):
990         (hierarchicalLevelCallback):
991         (AccessibilityUIElement::getJSClass):
992         * DumpRenderTree/AccessibilityUIElement.h:
993         (AccessibilityUIElement::isEqual):
994         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
995         (AccessibilityUIElement::hierarchicalLevel):
996         (AccessibilityUIElement::disclosedRowAtIndex):
997         (AccessibilityUIElement::selectedRowAtIndex):
998         (AccessibilityUIElement::disclosedByRow):
999         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1000         (AccessibilityUIElement::getChildAtIndex):
1001         (AccessibilityUIElement::disclosedRowAtIndex):
1002         (AccessibilityUIElement::selectedRowAtIndex):
1003         (AccessibilityUIElement::titleUIElement):
1004         (AccessibilityUIElement::parentElement):
1005         (AccessibilityUIElement::disclosedByRow):
1006         (AccessibilityUIElement::hierarchicalLevel):
1007         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1008         (AccessibilityUIElement::hierarchicalLevel):
1009         (AccessibilityUIElement::disclosedRowAtIndex):
1010         (AccessibilityUIElement::selectedRowAtIndex):
1011         (AccessibilityUIElement::disclosedByRow):
1012
1013 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1014
1015         Reviewed by Darin Adler.
1016
1017         svn-apply can not handle git binary diffs
1018         https://bugs.webkit.org/show_bug.cgi?id=26830
1019
1020         Support "literal" type git binary diffs.
1021
1022         * Scripts/VCSUtils.pm:
1023         * Scripts/modules/scm_unittest.py:
1024         * Scripts/svn-apply:
1025
1026 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1027
1028         Not reviewed, removing duplicate entry for myself in committers.py.
1029
1030         * Scripts/modules/committers.py:
1031
1032 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1033
1034         Reviewed by Darin Adler and Mark Rowe.
1035
1036         https://bugs.webkit.org/show_bug.cgi?id=31200
1037         Tests in http/tests/security/mixedContent start to fail when new tests are added
1038
1039         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1040
1041 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1042
1043         Reviewed by Jan Alonzo.
1044
1045         Create, and display a window for the inspector, for inspector
1046         tests.
1047
1048         Need to also show/hide the inspector window to avoid having
1049         problems with code assuming it is realized
1050         https://bugs.webkit.org/show_bug.cgi?id=31347
1051
1052         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1053         (webInspectorShowWindow):
1054         (webInspectorCloseWindow):
1055         (webInspectorInspectWebView):
1056         (createWebView):
1057
1058 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1059
1060         Unreviewed Qt buildbot fix.
1061
1062         My previous fix was wrong, so revert that change and fix it by
1063         returning when the document of the frame has no document element.
1064         Idea is borrowed from mac and win DRT.
1065
1066         * DumpRenderTree/qt/DumpRenderTree.cpp:
1067         (WebCore::DumpRenderTree::dumpFramesAsText):
1068
1069 2009-11-11  Eric Seidel  <eric@webkit.org>
1070
1071         Reviewed byg Kenneth Rohde Christiansen.
1072
1073         Update Kenneth's committer record to include the email he
1074         uses on lists.webkit.org.
1075
1076         * Scripts/modules/committers.py:
1077
1078 2009-11-11  Eric Seidel  <eric@webkit.org>
1079
1080         Reviewed by Gustavo Noronha Silva.
1081
1082         Several committers use separate email addresses for bugzilla and svn.webkit.org
1083         https://bugs.webkit.org/show_bug.cgi?id=31364
1084
1085         Update records for existing committers to include email addresses
1086         used in svn.webkit.org and lists.webkit.org.
1087         Most committers use the same email address in all 3 places, but some use
1088         separate addresses.  committers.py needs record of each of these addresses.
1089
1090         * Scripts/modules/committers.py:
1091
1092 2009-11-11  Eric Seidel  <eric@webkit.org>
1093
1094         No review, adding second email address for an existing committer.
1095
1096         Add Yong Li's second bugzilla account to his committer record.
1097         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1098
1099         * Scripts/modules/committers.py:
1100
1101 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1102
1103         Reviewed by Simon Hausmann.
1104
1105         If the frame has no innerText don't append it, and
1106         do not add a newline which breaks some cross platform
1107         results.
1108
1109         * DumpRenderTree/qt/DumpRenderTree.cpp:
1110         (WebCore::DumpRenderTree::dumpFramesAsText):
1111
1112 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1113
1114         Reviewed by Simon Hausmann.
1115
1116         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1117
1118         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1119         (webkit_test_plugin_new_instance):
1120         (webkit_test_plugin_destroy_instance):
1121         (webkit_test_plugin_destroy_stream):
1122
1123 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1124
1125         Reviewed by Mark Rowe.
1126
1127         Implement the functionality needed by plugins/window-open.html
1128
1129         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1130         (webkit_test_plugin_new_instance):
1131         (webkit_test_plugin_set_window):
1132
1133 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1134
1135         Reviewed by Simon Hausmann.
1136
1137         [Qt] Force -graphicssystem raster and -style windows when running DRT
1138
1139         * DumpRenderTree/qt/main.cpp:
1140         * Scripts/run-webkit-tests:
1141
1142 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1143
1144         Reviewed by Simon Hausmann.
1145
1146         Compute correct library paths for Qt
1147
1148         * Scripts/webkitdirs.pm:
1149
1150 2009-11-10  Mark Rowe  <mrowe@apple.com>
1151
1152         Reviewed by Sam Weinig.
1153
1154         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1155
1156         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1157         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1158         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1159         that had enabled frame load delegate logging this would result in extra log messages being generated,
1160         causing the test to fail.
1161
1162         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1163         tests.
1164
1165         * DumpRenderTree/mac/DumpRenderTree.mm:
1166         (dumpRenderTree):
1167         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1168         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1169
1170 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1171
1172         Reviewed by Kenneth Rohde Christiansen.
1173
1174         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1175
1176         * DumpRenderTree/qt/DumpRenderTree.cpp:
1177         (WebCore::DumpRenderTree::DumpRenderTree):
1178
1179 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1180
1181         Reviewed by Jan Alonzo.
1182
1183         [GTK] Remove WebSocket configuration from WebKitWebSettings
1184         https://bugs.webkit.org/show_bug.cgi?id=31244
1185
1186         Follow-up of r50724. Don't set the enable-web-socket property
1187         anymore.
1188
1189         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1190         (resetDefaultsToConsistentValues):
1191
1192 2009-11-10  Oliver Hunt  <oliver@apple.com>
1193
1194         Reviewed by Maciej Stachowiak.
1195
1196         Rename 3D Canvas related classes to use WebGL prefix
1197         https://bugs.webkit.org/show_bug.cgi?id=29095
1198
1199         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1200         and upate webkitdirs script to new method of testing for WebGL.
1201
1202         * Scripts/do-webcore-rename:
1203         * Scripts/webkitdirs.pm:
1204
1205 2009-11-09  Oliver Hunt  <oliver@apple.com>
1206
1207         Reviewed by Geoff Garen.
1208
1209         Make do-webcore-rename work with git.
1210
1211         * Scripts/do-webcore-rename:
1212
1213 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1214
1215         Adding Kenneth to the reviewers list.
1216
1217         * Scripts/modules/committers.py:
1218
1219 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1220
1221         Reviewed by Jan Alonzo.
1222
1223         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1224         https://bugs.webkit.org/show_bug.cgi?id=30482
1225
1226         LayoutTestControllerGtk now uses the exposed
1227         Page::tabKeyCyclesThroughElements API
1228
1229         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1230         (LayoutTestController::setTabKeyCyclesThroughElements):
1231
1232 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1233
1234         Reviewed by Holger Freyther.
1235
1236         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1237         This helps to pass the test case below. Also replaced hardcoded
1238         code numbers with defined constants.
1239         https://bugs.webkit.org/show_bug.cgi?id=31185
1240         
1241         Test: editing/undo/undo-deleteWord.html
1242
1243         * DumpRenderTree/qt/EventSenderQt.cpp:
1244         (EventSender::keyDown):
1245
1246 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1247
1248         Reviewed by Holger Freyther.
1249
1250         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1251         https://bugs.webkit.org/show_bug.cgi?id=31164
1252
1253         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1254
1255         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1256         (LayoutTestController::processWork):
1257
1258 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1259
1260         Reviewed by Holger Freyther.
1261
1262         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1263         https://bugs.webkit.org/show_bug.cgi?id=31158
1264
1265         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1266         always, which from WorkQueue prospective means that a load has been started
1267         and the queue processing should stop and wait for the load to finish.
1268         Spinning it off into a loading and a non-loading variants was the solution
1269         adopted by Mac's DRT to work around this problem. The former keeps returning
1270         'true' while the later executes the script synchronously and returns 'false'
1271         making it possible to the WorkQueue to proceed right away.
1272
1273         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1274         (LayoutTestController::processWork):
1275         (LayoutTestController::queueLoadingScript):
1276         (LayoutTestController::queueNonLoadingScript):
1277         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1278         * DumpRenderTree/qt/WorkQueueItem.h:
1279         (LoadingScriptItem::LoadingScriptItem):
1280         (LoadingScriptItem::invoke):
1281         (NonLoadingScriptItem::NonLoadingScriptItem):
1282         (NonLoadingScriptItem::invoke):
1283
1284 2009-11-07  Mark Rowe  <mrowe@apple.com>
1285
1286         Rubber-stamped by Cameron Zwarich.
1287
1288         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1289
1290         * Scripts/commit-log-editor:
1291
1292 2009-11-07  Mark Rowe  <mrowe@apple.com>
1293
1294         Reviewed by Darin Adler.
1295
1296         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1297         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1298
1299         Move logic for determining the name and email address to use in a ChangeLog entry from
1300         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1301         whether the author of the patch matches committer, and therefore needs access to the
1302         email address that would be used in a ChangeLog entry.
1303
1304         Based on a patch by Pierre d'Herbemont.
1305
1306         * Scripts/VCSUtils.pm:
1307         * Scripts/commit-log-editor:
1308         * Scripts/prepare-ChangeLog:
1309         * Scripts/webkitdirs.pm:
1310
1311 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1312
1313         Reviewed by Adam Barth.
1314
1315         Added functionality to the layout test plugin to invoke document.open and
1316         window.open with default arguments. The associated webkit bug is
1317         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1318         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1319         work in Chromium (V8) if there is no calling javascript context. To achieve this
1320         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1321         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1322
1323         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1324         (testDocumentOpen):
1325         (testWindowOpen):
1326         (pluginAllocate):
1327         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1328         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1329         (NPP_New):
1330         (NPP_SetWindow):
1331         (NPP_DestroyStream):
1332         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1333         (NPP_New):
1334         (NPP_SetWindow):
1335         (NPP_NewStream):
1336         (NPP_DestroyStream):
1337
1338 2009-11-06  Eric Seidel  <eric@webkit.org>
1339
1340         Reviewed by Adam Barth.
1341
1342         bugzilla-tool crashed with exception
1343         https://bugs.webkit.org/show_bug.cgi?id=31092
1344
1345         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1346
1347 2009-11-04  Eric Seidel  <eric@webkit.org>
1348
1349         No review, just add a line which got left out of the patch uploaded for commit.
1350
1351         commit-queue is crashing when trying to reject patches after unknown failures
1352         https://bugs.webkit.org/show_bug.cgi?id=31091
1353
1354         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1355
1356 2009-11-04  Adam Roben  <aroben@apple.com>
1357
1358         Remove bogus else clause in bugzilla-tool
1359
1360         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1361         create-bug raises exception after entering bug description
1362
1363         Reviewed by David Kilzer.
1364
1365         * Scripts/bugzilla-tool:
1366         (CreateBug): else clauses are only hit if no exception is raised, so
1367         it makes no sense to try to re-raise the exception in an else clause.
1368         The exception will automatically be re-raised if it doesn't match any
1369         of the except clauses, so we don't have to do anything special here at
1370         all to get the desired behavior.
1371
1372 2009-11-04  Eric Seidel  <eric@webkit.org>
1373
1374         Reviewed by David Kilzer.
1375
1376         svn-apply's fixChangeLogPatch function seems broken
1377         https://bugs.webkit.org/show_bug.cgi?id=30683
1378
1379         Update fixChangeLogPatch to be able to handle patches which
1380         don't start at line 1.
1381         Add unit tests for svn-apply to scm_unittest.py.
1382
1383         * Scripts/VCSUtils.pm:
1384         * Scripts/modules/scm_unittest.py:
1385
1386 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1387
1388         Reviewed by Beth Dakin.
1389
1390         Need to implement ARIA role="combobox"
1391         https://bugs.webkit.org/show_bug.cgi?id=31096
1392
1393         * DumpRenderTree/AccessibilityUIElement.cpp:
1394         (showMenuCallback):
1395         (getIsExpandedCallback):
1396         (AccessibilityUIElement::getJSClass):
1397         * DumpRenderTree/AccessibilityUIElement.h:
1398         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1399         (AccessibilityUIElement::isExpanded):
1400         (AccessibilityUIElement::showMenu):
1401         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1402         (AccessibilityUIElement::isExpanded):
1403         (AccessibilityUIElement::showMenu):
1404         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1405         (AccessibilityUIElement::isSelected):
1406         (AccessibilityUIElement::isExpanded):
1407         (AccessibilityUIElement::showMenu):
1408
1409 2009-11-04  Eric Seidel  <eric@webkit.org>
1410
1411         Reviewed by Adam Barth.
1412
1413         commit-queue is crashing when trying to reject patches after unknown failures
1414         https://bugs.webkit.org/show_bug.cgi?id=31091
1415
1416         * Scripts/bugzilla-tool:
1417          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
1418            so we have to find out what the current patch is by asking bugzilla again.
1419          - Discovered that this code was also leaking file descriptors, so fixed that.
1420
1421 2009-11-04  Adam Roben  <aroben@apple.com>
1422
1423         Make run-webkit-tests work for the Debug_Internal Windows
1424         configuration
1425
1426         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
1427         suffix.
1428
1429         Fixes <http://webkit.org/b/31123>.
1430
1431         Reviewed by Sam Weinig.
1432
1433         * Scripts/run-webkit-tests: Don't add the _debug suffix in
1434         Debug_Internal, either.
1435
1436 2009-11-04  Eric Seidel  <eric@webkit.org>
1437
1438         Reviewed by Adam Barth.
1439
1440         committers.py needs a way to store non-bugzilla email addresses
1441         https://bugs.webkit.org/show_bug.cgi?id=31037
1442
1443         Make Committer and Reviewer constructors take a single email or a list of emails.
1444         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
1445         Expose reviewers(), used by validate-committer-lists on bug 30970.
1446
1447         * Scripts/modules/committers.py:
1448         * Scripts/modules/committers_unittest.py: Added tests for the new code.
1449
1450 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
1451
1452         Reviewed by David Levin.
1453
1454         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
1455         https://bugs.webkit.org/show_bug.cgi?id=27491
1456
1457         The test path determination logic is changed to handle websocket and websocket/ssl cases.
1458         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
1459
1460         Functions to start or stop Web Socket servers are added.
1461
1462         * Scripts/run-webkit-tests:
1463
1464 2009-11-03  Eric Seidel  <eric@webkit.org>
1465
1466         No review, just changing wording of log message.
1467
1468         Change log string to say "failed" instead of "rejected"
1469         when a commit fails due to an out of date checkout.
1470         This makes grepping the commit-queue log for rejected patches easier.
1471
1472         * Scripts/bugzilla-tool:
1473
1474 2009-11-03  Eric Seidel  <eric@webkit.org>
1475
1476         No review, adding commonly known committers missing from the file.
1477
1478         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
1479
1480 2009-11-03  Eric Seidel  <eric@webkit.org>
1481
1482         No review, just sort-order cleanup.
1483
1484         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
1485
1486 2009-11-03  Stephen White  <senorblanco@chromium.org>
1487
1488         (Unreviewed).
1489
1490         Add myself to committers.py.
1491
1492         * Scripts/modules/committers.py:
1493
1494 2009-11-03  Robin Dunn  <robin@alldunn.com>
1495
1496         Reviewed by Kevin Ollviier.
1497
1498         Add packaging scripts for Debian-based Linux distros.
1499         
1500         https://bugs.webkit.org/show_bug.cgi?id=31075
1501
1502         * wx/packaging/build-debian-installer.py: Added.
1503         * wx/packaging/debian: Added.
1504
1505 2009-11-03  Dan Bernstein  <mitz@apple.com>
1506
1507         Reviewed by Anders Carlsson and Beth Dakin.
1508
1509         https://bugs.webkit.org/show_bug.cgi?id=31070
1510
1511         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
1512         destroyed, it executes the value of the 'ondestroy' parameter as a
1513         script.
1514
1515         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1516         (pluginAllocate): Initialize onDestroy.
1517         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
1518         onDestroy.
1519         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1520         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
1521         specified.
1522         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
1523
1524 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1525
1526         Reviewed by Xan Lopez.
1527
1528         https://bugs.webkit.org/show_bug.cgi?id=31035
1529         [GTK] some accessibility tests hitting assertion in debug builds
1530
1531         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
1532
1533         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1534         (AccessibilityController::rootElement):
1535
1536 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
1537
1538         Reviewed by Beth Dakin.
1539
1540         Support ARIA "tab" roles
1541         https://bugs.webkit.org/show_bug.cgi?id=30842
1542
1543         * DumpRenderTree/AccessibilityUIElement.cpp:
1544         * DumpRenderTree/AccessibilityUIElement.h:
1545         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1546         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1547         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1548
1549 2009-11-01  Eric Seidel  <eric@webkit.org>
1550
1551         Reviewed by David Levin.
1552
1553         buildbots should use --exit-after-N-failures
1554         https://bugs.webkit.org/show_bug.cgi?id=30809
1555
1556         Make the bots exit after 20 failures to prevent never-ending
1557         test runs where every test spends a minute crashing.
1558
1559         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1560
1561 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1562
1563         Reviewed by Eric Seidel.
1564
1565         Turn on warnings for QtWebKit for gcc
1566         https://bugs.webkit.org/show_bug.cgi?id=30958
1567
1568         * DumpRenderTree/qt/main.cpp: 
1569         (crashHandler): Mark function NO_RETURN
1570
1571 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
1572
1573         Adding myself to the committers list.
1574
1575         * Scripts/modules/committers.py:
1576
1577 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
1578
1579         Fix an issue that Adam noticed in DRT.
1580
1581         Reviewed by Darin Adler.
1582
1583         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1584         (AccessibilityUIElement::role):
1585         Get the length of the role text, and create a buffer dynamically.
1586
1587 2009-10-30  Eric Seidel  <eric@webkit.org>
1588
1589         No review, rolling out r50105.
1590         http://trac.webkit.org/changeset/50105
1591
1592         This commit was causing:
1593         https://bugs.webkit.org/show_bug.cgi?id=30869
1594         We'll re-implement the feature a different way.
1595
1596         * Scripts/bugzilla-tool:
1597
1598 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1599
1600         Test for MSAA: Accessibility of headings is not correct
1601
1602         https://bugs.webkit.org/show_bug.cgi?id=30937
1603
1604         Reviewed by Adam Roben.
1605
1606         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1607         (AccessibilityUIElement::role):
1608         Allow the role returned to be a BSTR.
1609         (AccessibilityUIElement::description):
1610         Fix a copy/paste error.
1611
1612 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1613
1614         Test for MSAA: Accessibility of links is wrong
1615
1616         https://bugs.webkit.org/show_bug.cgi?id=30928
1617
1618         Reviewed by Darin Adler.
1619
1620         * DumpRenderTree/AccessibilityUIElement.cpp:
1621         (getAccessibilityValueCallback):
1622         Return the accessibility value.
1623         (AccessibilityUIElement::getJSClass):
1624         Added "accessibilityValue" value.
1625
1626         * DumpRenderTree/AccessibilityUIElement.h:
1627
1628         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1629         (AccessibilityUIElement::accessibilityValue):
1630         Stubbed.
1631
1632         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1633         (AccessibilityUIElement::accessibilityValue):
1634         Stubbed.
1635
1636         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1637         (AccessibilityUIElement::accessibilityValue):
1638         Get the object's value, and return it as a JS string.
1639
1640 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
1641
1642         Fix typo in command name used by wx build system.
1643
1644         * wx/build/build_utils.py:
1645
1646 2009-10-30  Adam Barth  <abarth@webkit.org>
1647
1648         Reviewed by Darin Adler.
1649
1650         Patch v1 is a dumb default name for patches
1651         https://bugs.webkit.org/show_bug.cgi?id=30952
1652
1653         Let's use "Patch" instead.
1654
1655         * Scripts/bugzilla-tool:
1656
1657 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1658
1659         Unreviewed trivial buildfix.
1660
1661         [Qt] Buildfix for r50333.
1662
1663         * DumpRenderTree/qt/DumpRenderTree.pro:
1664
1665 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
1666
1667         Reviewed by Holger Freyther.
1668
1669         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
1670         https://bugs.webkit.org/show_bug.cgi?id=30953
1671
1672         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
1673         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
1674         makes qt DRT to share this implementation (as gtk and mac ports do).
1675
1676         * DumpRenderTree/qt/DumpRenderTree.pro:
1677         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
1678         * DumpRenderTree/qt/WorkQueue.h: Removed.
1679
1680 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1681
1682         Unreviewed potential buildbot fix.
1683
1684         Second try: Reset page history before running each test.
1685
1686         Apparently the QWebHistory::clear() keeps the current page
1687         in history which is not what we want, so we not additionally
1688         sets the history capacity to 0 (forces removing everything)
1689         and then sets it back to its original value.
1690
1691         * DumpRenderTree/qt/DumpRenderTree.cpp:
1692         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1693
1694 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1695
1696         Unreviewed potential buildbot fix.
1697
1698         Reset page history before running each test.
1699
1700         * DumpRenderTree/qt/DumpRenderTree.cpp:
1701         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1702
1703 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
1704
1705         Reviewed by Eric Seidel.
1706
1707         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
1708
1709         Bug 28420 -  Implement HTML5 <ruby> rendering
1710         (https://bugs.webkit.org/show_bug.cgi?id=28420)
1711
1712         No new tests (no functional change).
1713
1714         * Scripts/build-webkit:
1715
1716 2009-10-29  Dan Bernstein  <mitz@apple.com>
1717
1718         Reviewed by Mark Rowe.
1719
1720         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
1721         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
1722         define it.
1723
1724         * Scripts/VCSUtils.pm:
1725         * Scripts/svn-apply:
1726         * Scripts/svn-unapply:
1727
1728 2009-10-29  Xan Lopez  <xlopez@igalia.com>
1729
1730         Reviewed by Gustavo Noronha.
1731
1732         Use the GTK+ main loop instead of rolling our own mini-version of
1733         it.
1734
1735         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1736         (dump):
1737         (runTest):
1738         (webViewLoadFinished):
1739
1740 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1741
1742         Reviewed by Oliver Hunt.
1743
1744         Implement the Qt version of DRT dumpBackForwardList().
1745
1746         * DumpRenderTree/qt/DumpRenderTree.cpp:
1747         (WebCore::dumpHistoryItem):
1748         (WebCore::DumpRenderTree::dumpBackForwardList):
1749
1750 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1751
1752         Reviewed by Adam Roben.
1753
1754         Implement DRT functionality for Qt introduced in
1755         r28690 and r28705.
1756
1757         - Implemented pathToLocalResource which exposes the functionality of
1758         converting a given unix path to the correct location on Windows.
1759         - Implemented a way to remove machine-dependent information from paths
1760         in layout test results.
1761
1762         * DumpRenderTree/qt/DumpRenderTree.cpp:
1763         (WebCore::urlSuitableForTestResult):
1764         (WebCore::WebPage::javaScriptConsoleMessage):
1765         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1766         (LayoutTestController::pathToLocalResource):
1767         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1768
1769 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
1770
1771         Adding myself to the committers list.
1772
1773         * Scripts/modules/committers.py:
1774
1775 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
1776
1777         Adding myself to the committers list.
1778
1779         * Scripts/modules/committers.py:
1780
1781 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1782
1783         Reviewed by Jan Alonzo.
1784
1785         [GTK] API to start inspector for a WebView
1786         https://bugs.webkit.org/show_bug.cgi?id=22551
1787
1788         Use the new inspector API to implement the LayoutTestController
1789         interfaces used to test the inspector.
1790
1791         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1792         (webInspectorInspectWebView):
1793         (createWebView):
1794         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1795         (LayoutTestController::showWebInspector):
1796         (LayoutTestController::closeWebInspector):
1797         (LayoutTestController::evaluateInWebInspector):
1798
1799 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
1800
1801         Reviewed by Eric Seidel.
1802
1803         [Qt] WebFrame::counterValueForElementById must not be exposed
1804         https://bugs.webkit.org/show_bug.cgi?id=30882
1805
1806         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1807         (LayoutTestController::counterValueForElementById):
1808
1809 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1810
1811         Rubberstamped by Oliver Hunt.
1812
1813         Fix the warning:
1814
1815         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
1816         declared with attribute warn_unused_result".
1817
1818         by actually checking the result. In the case it is null, an
1819         error has occoured, so treat it as the other fatal errors.
1820
1821         * DumpRenderTree/qt/DumpRenderTree.cpp:
1822         (WebCore::DumpRenderTree::initializeFonts):
1823
1824 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
1825
1826         Reviewed by Darin Adler.
1827
1828         Provide a way to get counter values with layoutTestContoller
1829         https://bugs.webkit.org/show_bug.cgi?id=30555
1830
1831         Define layoutTestContoller.counterValueForElementById.
1832
1833         * DumpRenderTree/LayoutTestController.cpp:
1834         (counterValueForElementByIdCallback):
1835         (LayoutTestController::staticFunctions):
1836         * DumpRenderTree/LayoutTestController.h:
1837         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1838         (LayoutTestController::counterValueForElementById):
1839
1840 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1841
1842         Rubberstamped by Oliver Hunt.
1843
1844         Change two methods to be internal for DRT use only.
1845
1846         Part of [Qt] Review all new API in Qt 4.6
1847         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
1848
1849         * DumpRenderTree/qt/DumpRenderTree.cpp:
1850         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1851         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1852         (LayoutTestController::whiteListAccessFromOrigin):
1853
1854 2009-10-27  Eric Seidel  <eric@webkit.org>
1855
1856         Reviewed by Adam Barth.
1857
1858         REGRESSION: svn-apply exits(1) when applying a patch with a file add
1859         https://bugs.webkit.org/show_bug.cgi?id=30826
1860
1861         * Scripts/svn-apply:
1862          - Add () around all system() calls.
1863          - Use the correct system() == 0 or die instead of system() or die
1864          - Add descriptive messages to all die statements.
1865
1866 2009-10-27  Steve Block  <steveblock@google.com>
1867
1868         Reviewed by NOBODY.
1869
1870         Adds steveblock@google.com to list of committers.
1871
1872         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
1873
1874 2009-10-27  Eric Seidel  <eric@webkit.org>
1875
1876         Reviewed by Adam Barth.
1877
1878         svn-apply can exit(0) even on patch failure
1879         https://bugs.webkit.org/show_bug.cgi?id=29622
1880
1881         * Scripts/svn-apply:
1882          - Add a bunch of "or die" statements, hopefully catching all
1883            possible cases where failure could still exit(0).
1884
1885 2009-10-27  Eric Seidel  <eric@webkit.org>
1886
1887         Reviewed by Adam Barth.
1888
1889         svn-* scripts should share code through VCSUtils.pm
1890         https://bugs.webkit.org/show_bug.cgi?id=30791
1891
1892         Just moving code into a shared location.
1893
1894         * Scripts/VCSUtils.pm:
1895         * Scripts/prepare-ChangeLog:
1896         * Scripts/resolve-ChangeLogs:
1897         * Scripts/svn-apply:
1898         * Scripts/svn-create-patch:
1899         * Scripts/svn-unapply:
1900         * Scripts/update-webkit:
1901
1902 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
1903
1904         Suppress a huge number of MSVC warnings when building wxWebKit.
1905
1906         * wx/build/settings.py:
1907
1908 2009-10-26  Eric Seidel  <eric@webkit.org>
1909
1910         No review, just adding Mike Belshe to the committers list.
1911
1912         * Scripts/modules/committers.py:
1913
1914 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1915
1916         Reviewed by Darin Adler.
1917
1918         Make .rc files compile on Windows without depending on MFC headers
1919         https://bugs.webkit.org/show_bug.cgi?id=30750
1920
1921         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
1922         windows.h instead of afxres.h because it exists even when MFC is not 
1923         installed, and is all that's needed here.
1924
1925         * FindSafari/FindSafari.rc: Ditto
1926
1927 2009-10-24  Eric Seidel  <eric@webkit.org>
1928
1929         Reviewed by Adam Barth.
1930
1931         bugzilla-tool post-diff should know how to mark commit-queue=?
1932         https://bugs.webkit.org/show_bug.cgi?id=29202
1933
1934         * Scripts/bugzilla-tool:
1935          - Add --commit-queue option to post-diff, post-commits and create-bug.
1936         * Scripts/modules/bugzilla.py:
1937          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
1938          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
1939
1940 2009-10-23  Eric Seidel  <eric@webkit.org>
1941
1942         Reviewed by Adam Barth.
1943
1944         bugzilla-tool commit-queue does not notice modifications to committers.py
1945         https://bugs.webkit.org/show_bug.cgi?id=30084
1946
1947         * Scripts/bugzilla-tool:
1948          - Make commit-queue re-exec itself instead of using while(1).
1949          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
1950          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
1951
1952 2009-10-22  Eric Seidel  <eric@webkit.org>
1953
1954         Reviewed by Adam Barth.
1955
1956         commit-queue will get stuck on patches if land-patches terminates unexpectedly
1957         https://bugs.webkit.org/show_bug.cgi?id=30634
1958
1959         * Scripts/bugzilla-tool:
1960          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
1961          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
1962
1963 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
1964
1965         Reviewed by Eric Seidel.
1966
1967         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
1968
1969         https://bugs.webkit.org/show_bug.cgi?id=30763
1970
1971         * pywebsocket/mod_pywebsocket/__init__.py:
1972         * pywebsocket/mod_pywebsocket/dispatch.py:
1973         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
1974         * pywebsocket/mod_pywebsocket/standalone.py:
1975         * pywebsocket/setup.py:
1976         * pywebsocket/test/test_dispatch.py:
1977
1978 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
1979
1980         Reviewed by David Levin.
1981
1982         REGRESSION: 2 failures in run-webkit-unittests
1983         https://bugs.webkit.org/show_bug.cgi?id=30645
1984
1985         * Scripts/modules/cpp_style_unittest.py:
1986         Fixed a few test scenarios which apparently lost some spaces from 
1987         text literals.
1988
1989 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
1990
1991         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
1992
1993         * Scripts/webkitdirs.pm:
1994
1995 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
1996
1997         Reviewed by Darin Adler.
1998
1999         Unification of using null device in perl scripts.
2000         https://bugs.webkit.org/show_bug.cgi?id=30572
2001
2002         * Scripts/VCSUtils.pm:
2003         * Scripts/bisect-builds:
2004         * Scripts/resolve-ChangeLogs:
2005         * Scripts/run-iexploder-tests:
2006         * Scripts/run-jsc:
2007         * Scripts/run-mangleme-tests:
2008         * Scripts/run-webkit-tests:
2009         * Scripts/webkitdirs.pm:
2010         Using File::Spec->devnull() instead of hard coded /dev/null.
2011
2012 2009-10-26  Eric Seidel  <eric@webkit.org>
2013
2014         Reviewed by Holger Freyther.
2015
2016         Reviewers are missing from committers.py
2017         https://bugs.webkit.org/show_bug.cgi?id=30733
2018
2019         * Scripts/modules/committers.py:
2020
2021 2009-10-23  Eric Seidel  <eric@webkit.org>
2022
2023         No review, only adding Alice to the list of reviewers.
2024
2025         * Scripts/modules/committers.py:
2026
2027 2009-10-23  Eric Seidel  <eric@webkit.org>
2028
2029         Reviewed by Eric Carlson.
2030
2031         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2032         https://bugs.webkit.org/show_bug.cgi?id=30700
2033
2034         * DumpRenderTree/mac/DumpRenderTree.mm:
2035         (resetDefaultsToConsistentValues): Update QuickTime version check.
2036
2037 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2038
2039         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2040         character measurement APIs that are private on Tiger.
2041
2042         * wx/build/settings.py:
2043
2044 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2045
2046         Reviewed by NOBODY (build fix).
2047         Build fix following bug #30696.
2048
2049         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2050         (LayoutTestController::evaluateScriptInIsolatedWorld):
2051
2052 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2053
2054         Reviewed by Sam Weinig & Geoff Garen.
2055
2056         https://bugs.webkit.org/show_bug.cgi?id=30696
2057         Enable isolated-worlds tests on mac.
2058
2059         Add private interface for DRT to invoke execution in a given world.
2060
2061         * DumpRenderTree/LayoutTestController.cpp:
2062         (evaluateScriptInIsolatedWorldCallback):
2063         (LayoutTestController::staticFunctions):
2064         * DumpRenderTree/LayoutTestController.h:
2065         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2066         (LayoutTestController::evaluateScriptInIsolatedWorld):
2067         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2068         (LayoutTestController::evaluateScriptInIsolatedWorld):
2069
2070 2009-10-21  Eric Seidel  <eric@webkit.org>
2071
2072         Reviewed by Adam Barth.
2073
2074         bugzilla-tool's "patch failed to download an apply" error should give more information
2075         https://bugs.webkit.org/show_bug.cgi?id=30632
2076
2077         * Scripts/modules/scm.py:
2078          - Use the common run_command method instead of custom POpen code.
2079          - Make run_command know how to take pipes as input.
2080         * Scripts/modules/scm_unittest.py:
2081          - Add new tests to cover change.
2082          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2083
2084 2009-10-21  Kent Tamura  <tkent@chromium.org>
2085
2086         Unreviewed.  Adding myself to the committers list.
2087
2088         * Scripts/modules/committers.py:
2089
2090 2009-10-21  Robin Dunn  <robin@alldunn.com>
2091
2092         Reviewed by Kevin Ollivier.
2093
2094         Update the Windows installer builder to work with Vista / Win 7 and with git.
2095         
2096         https://bugs.webkit.org/show_bug.cgi?id=30649
2097
2098         * wx/build/build_utils.py:
2099         * wx/packaging/build-mac-installer.py:
2100         * wx/packaging/build-win-installer.py:
2101         * wx/packaging/wxWebKitInstaller.iss.in:
2102
2103 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2104
2105         Reviewed by Gustavo Noronha.
2106
2107         [GTK] Added conditional code to avoid using
2108         gdk_window_get_root_coords if we do not have a gtk+ release newer
2109         than 2.17.3.
2110         https://bugs.webkit.org/show_bug.cgi?id=30636
2111
2112         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2113
2114 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2115
2116         Reviewed by Eric Seidel.
2117
2118         [Qt] Added dummy implementation for keepWebHistory()
2119         https://bugs.webkit.org/show_bug.cgi?id=30592
2120
2121         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2122         (LayoutTestController::keepWebHistory):
2123         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2124
2125 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2126
2127         Reviewed by Xan Lopez.
2128
2129         [GTK] Fixed the double click condition, it is not double click if
2130         we move in just in one direction.
2131         https://bugs.webkit.org/show_bug.cgi?id=30636
2132
2133         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2134
2135 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2136
2137         Reviewed by Xan Lopez.
2138
2139         [GTK] Initialize the events completly before emitting them.
2140         https://bugs.webkit.org/show_bug.cgi?id=30633
2141
2142         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2143
2144 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2145
2146         wx build fix. Fix for when linking using --as-needed with gcc.
2147
2148         * wx/browser/wscript:
2149
2150 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2151
2152         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2153         to support all the features used by CURL backend.
2154         
2155         * wx/build/settings.py:
2156         * wx/install-unix-extras:
2157
2158 2009-10-20  Anton Muhin  <antonm@chromium.org>
2159
2160         Reviewed by Adam Barth.
2161
2162         Add {ager,antonm,yurys}@chromium.org into committers.py
2163         https://bugs.webkit.org/show_bug.cgi?id=30560
2164
2165         * Scripts/modules/committers.py:
2166
2167 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2168
2169         Reviewed by Tor Arne Vestbø.
2170
2171         Make the Netscape Test plugin available to the Qt launcher.
2172
2173         * Scripts/run-launcher:
2174
2175 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2176
2177         Reviewed by David Levin.
2178
2179         Removed WebSocket runtime settings.
2180         https://bugs.webkit.org/show_bug.cgi?id=29896
2181
2182         WebSocket runtime configuration is supported by chromium/v8 only.
2183
2184         * DumpRenderTree/mac/DumpRenderTree.mm:
2185         (resetDefaultsToConsistentValues):
2186         * DumpRenderTree/win/DumpRenderTree.cpp:
2187         (resetDefaultsToConsistentValues):
2188
2189 2009-10-19  Nate Chapin  <japhet@chromium.org>
2190
2191         Reviewed by Adam Barth.
2192
2193         Add testFail() to test plugin so we can test our handling of a
2194         plugin invoke call returning false.
2195
2196         https://bugs.webkit.org/show_bug.cgi?id=30239
2197
2198         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2199         (pluginInvoke):
2200         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2201
2202 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2203
2204         Reviewed by Gustavo Noronha.
2205
2206         Enable DOM pasting when running layout tests.
2207
2208         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2209         (resetDefaultsToConsistentValues):
2210
2211 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2212
2213         Reviewed by Simon Hausmann.
2214
2215         Use the setPreferredContentsSize method instead
2216         of setFixedContentsSize, as the method has been renamed.
2217
2218         * DumpRenderTree/qt/DumpRenderTree.cpp:
2219         (WebCore::DumpRenderTree::open):
2220         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2221         (LayoutTestController::setFixedContentsSize):
2222
2223 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2224
2225         Reviewed by Dan Bernstein.
2226
2227         https://bugs.webkit.org/show_bug.cgi?id=30456
2228         Fixes for new Debug_All Windows build configuration.
2229
2230         * DumpRenderTree/win/DumpRenderTree.cpp:
2231         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2232         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2233
2234 2009-10-16  Eric Seidel  <eric@webkit.org>
2235
2236         Reviewed by Adam Barth.
2237
2238         commit-queue status bot should list which buildbot is blocking the queue
2239         https://bugs.webkit.org/show_bug.cgi?id=30452
2240
2241         Add new methods and testing.
2242
2243         * Scripts/bugzilla-tool:
2244         * Scripts/modules/buildbot.py:
2245         * Scripts/modules/buildbot_unittest.py:
2246
2247 2009-10-16  Eric Seidel  <eric@webkit.org>
2248
2249         Reviewed by Adam Barth.
2250
2251         run-webkit-tests fails when CWD is not inside a WebKit checkout
2252         https://bugs.webkit.org/show_bug.cgi?id=30451
2253
2254         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2255         * Scripts/modules/scm_unittest.py:
2256           - Remove use of original_path (we don't need to restore the CWD).
2257           - Don't use '.' to find the webkit checkout, use __file__ instead.
2258
2259 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2260
2261         Reviewed by Adam Roben.
2262
2263         Add a Debug_All configuration to build entire stack as debug.
2264         Change Debug_Internal to:
2265         - stop using _debug suffix for all WebKit/Safari binaries
2266         - not use _debug as a DLL naming suffix
2267         - use non-debug C runtime lib.
2268
2269         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2270         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2271         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2272         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2273         Add missing debug.vsprops inherited property sheet.
2274         Add Debug_All configuration.
2275         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2276         * WinLauncher/WinLauncher.vcproj:
2277         Removed extraneous definitions inherited from vsprops.
2278         Add Debug_All configuration.
2279
2280 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2281
2282         Reviewed by David Levin.
2283
2284         check-webkit-style is wrong about indent checking in namespaces
2285         in header files and a few other things
2286         https://bugs.webkit.org/show_bug.cgi?id=30362
2287
2288         The few other things include:
2289         + check-webkit-style does not require spaces around the equal sign
2290           inside 'if' statements and around binary operators that take 
2291           numeric literals.
2292         + check-webkit-style reports false errors for the / operator
2293           when part of a filename in the #include directive.
2294
2295         * Scripts/modules/cpp_style.py:
2296         Improved indentation checking and space checking around
2297         binary operators. While the checks are still not perfect,
2298         they are clearly better than before.
2299         * Scripts/modules/cpp_style_unittest.py:
2300         Added test cases for the newly supported checks and modified old
2301         test cases to match the new guidelines
2302
2303 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2304
2305         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2306
2307         * wx/build/settings.py:
2308
2309 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2310
2311         Reviewed by David Levin.
2312
2313         Add mod_pywebsocket to test Web Sockets.
2314         http://code.google.com/p/pywebsocket/
2315         https://bugs.webkit.org/show_bug.cgi?id=27490
2316
2317         * pywebsocket/COPYING: Added.
2318         * pywebsocket/MANIFEST.in: Added.
2319         * pywebsocket/README: Added.
2320         * pywebsocket/example/echo_client.py: Added.
2321         * pywebsocket/example/echo_wsh.py: Added.
2322         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2323         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2324         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2325         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2326         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2327         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2328         * pywebsocket/mod_pywebsocket/util.py: Added.
2329         * pywebsocket/setup.py: Added.
2330         * pywebsocket/test/config.py: Added.
2331         * pywebsocket/test/mock.py: Added.
2332         * pywebsocket/test/run_all.py: Added.
2333         * pywebsocket/test/test_dispatch.py: Added.
2334         * pywebsocket/test/test_handshake.py: Added.
2335         * pywebsocket/test/test_mock.py: Added.
2336         * pywebsocket/test/test_msgutil.py: Added.
2337         * pywebsocket/test/test_util.py: Added.
2338         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2339         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2340         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2341         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2342         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2343         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2344         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2345         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2346
2347 2009-10-15  James Robinson  <jamesr@google.com>
2348
2349         Reviewed by David Levin.
2350
2351         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2352
2353         https://bugs.webkit.org/show_bug.cgi?id=30426
2354
2355         * Scripts/modules/cpp_style.py:
2356         * Scripts/modules/cpp_style_unittest.py:
2357
2358 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2359
2360         Reviewed by Adam Roben.
2361
2362         Fixes <http://webkit.org/b/30411>.
2363         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2364         
2365         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2366         building Chromium.
2367
2368         * Scripts/pdevenv:
2369
2370 2009-10-15  Robin Dunn  <robin@alldunn.com>
2371
2372         Reviewed by Kevin Ollivier.
2373
2374         Add Mac package building scripts for wx.
2375         
2376         https://bugs.webkit.org/show_bug.cgi?id=30405
2377
2378         * wx/build/build_utils.py:
2379         * wx/build/settings.py:
2380         * wx/packaging/build-mac-installer.py: Added.
2381
2382 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2383
2384         Reviewed by Gustavo Noronha.
2385
2386         Enable Web Sockets support when running layout tests.
2387
2388         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2389         (resetDefaultsToConsistentValues):
2390
2391 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2392
2393         Reviewed by Gustavo Noronha.
2394
2395         Need to initialize event.button.button, since in most cases a
2396         button number is not passed as an argument.
2397
2398         * DumpRenderTree/gtk/EventSender.cpp:
2399         (mouseDownCallback):
2400         (mouseUpCallback):
2401
2402 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
2403
2404         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
2405         the OS if none was explicitly set.
2406
2407         * wx/build/settings.py:
2408
2409 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2410
2411         Reviewed by Timothy Hatcher.
2412
2413         Web Inspector: enable developers extras within inspector layout tests.
2414
2415         https://bugs.webkit.org/show_bug.cgi?id=30014
2416
2417         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2418         (LayoutTestController::showWebInspector):
2419         (LayoutTestController::closeWebInspector):
2420         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2421         (LayoutTestController::showWebInspector):
2422         (LayoutTestController::closeWebInspector):
2423
2424 2009-10-14  José Millán Soto  <jmillan@igalia.com>
2425
2426         Reviewed by Jan Alonzo.
2427
2428         GtkLauncher is using a deprecated signal
2429         https://bugs.webkit.org/show_bug.cgi?id=30364
2430
2431         Modified GtkLauncher to use notify::title signal instead of
2432         deprecated title-changed signal
2433
2434         * GtkLauncher/main.c:
2435         (notify_title_cb):
2436         (create_browser):
2437
2438 2009-10-14  Brady Eidson  <beidson@apple.com>
2439
2440         Reviewed by Sam Weinig.
2441
2442         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
2443         1 - Disables WebHistory
2444         2 - Doesn't make sense in that context anyway.
2445
2446         * DumpRenderTree/win/DumpRenderTree.cpp:
2447         (createWebViewAndOffscreenWindow):
2448
2449 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
2450
2451         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
2452         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
2453
2454         * wx/build/settings.py:
2455         * wx/install-unix-extras:
2456
2457 2009-10-14  Brady Eidson  <beidson@apple.com>
2458
2459         Reviewed by Sam Weinig.
2460
2461         WebKit Win API should provide a delegate interface for global history.
2462         https://bugs.webkit.org/show_bug.cgi?id=29905
2463
2464         * DumpRenderTree/LayoutTestController.cpp:
2465         (LayoutTestController::LayoutTestController):
2466         * DumpRenderTree/LayoutTestController.h:
2467         (LayoutTestController::dumpHistoryDelegateCallbacks):
2468         (LayoutTestController::setDumpHistoryDelegateCallbacks):
2469                 
2470         * DumpRenderTree/win/DumpRenderTree.cpp:
2471         (shouldLogHistoryDelegates):
2472         (runTest):
2473         (createWebViewAndOffscreenWindow):
2474         (main):
2475         * DumpRenderTree/win/DumpRenderTree.vcproj:
2476         
2477         Add the IWebHistoryDelegate to DRT Windows:
2478         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
2479         (wstringFromBSTR):
2480         (HistoryDelegate::HistoryDelegate):
2481         (HistoryDelegate::~HistoryDelegate):
2482         (HistoryDelegate::QueryInterface):
2483         (HistoryDelegate::AddRef):
2484         (HistoryDelegate::Release):
2485         (HistoryDelegate::didNavigateWithNavigationData):
2486         (HistoryDelegate::didPerformClientRedirectFromURL):
2487         (HistoryDelegate::didPerformServerRedirectFromURL):
2488         (HistoryDelegate::updateHistoryTitle):
2489         (HistoryDelegate::populateVisitedLinksForWebView):
2490         * DumpRenderTree/win/HistoryDelegate.h: Added.
2491
2492         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2493         (LayoutTestController::removeAllVisitedLinks):
2494
2495 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
2496
2497         Reviewed by Simon Hausmann.
2498
2499         [Qt] Implement support for setPOSIXLocale on Qt.
2500         https://bugs.webkit.org/show_bug.cgi?id=30268 
2501  
2502         * DumpRenderTree/qt/DumpRenderTree.cpp:
2503         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2504         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2505         (LayoutTestController::setPOSIXLocale):
2506         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2507
2508 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2509
2510         Unreviewed, adding myself to reviewers list.
2511
2512         * Scripts/modules/committers.py:
2513
2514 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2515
2516         Reviewed by Mark Rowe.
2517
2518         Fix null assignment so root tests work again.
2519
2520         * Scripts/webkitdirs.pm:
2521
2522 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2523
2524         Reviewed by Simon Hausmann.
2525
2526         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
2527         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
2528         This is done in preparation of implementing missing features in DRT.
2529         No functionality changes made yet.
2530
2531         * DumpRenderTree/qt/DumpRenderTree.cpp:
2532         * DumpRenderTree/qt/DumpRenderTree.pro:
2533         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
2534         (EventSender::EventSender):
2535         (EventSender::mouseDown):
2536         (EventSender::mouseUp):
2537         (EventSender::mouseMoveTo):
2538         (EventSender::leapForward):
2539         (EventSender::keyDown):
2540         (EventSender::contextClick):
2541         (EventSender::scheduleAsynchronousClick):
2542         (EventSender::frameUnderMouse):
2543         * DumpRenderTree/qt/EventSenderQt.h: Added.
2544         (EventSender::clearKillRing):
2545         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
2546         (LayoutTestController::LayoutTestController):
2547         (LayoutTestController::reset):
2548         (LayoutTestController::processWork):
2549         (LayoutTestController::maybeDump):
2550         (LayoutTestController::waitUntilDone):
2551         (LayoutTestController::notifyDone):
2552         (LayoutTestController::windowCount):
2553         (LayoutTestController::clearBackForwardList):
2554         (LayoutTestController::dumpEditingCallbacks):
2555         (LayoutTestController::dumpResourceLoadCallbacks):
2556         (LayoutTestController::queueBackNavigation):
2557         (LayoutTestController::queueForwardNavigation):
2558         (LayoutTestController::queueLoad):
2559         (LayoutTestController::queueReload):
2560         (LayoutTestController::queueScript):
2561         (LayoutTestController::provisionalLoad):
2562         (LayoutTestController::timerEvent):
2563         (LayoutTestController::encodeHostName):
2564         (LayoutTestController::decodeHostName):
2565         (LayoutTestController::setJavaScriptProfilingEnabled):
2566         (LayoutTestController::setFixedContentsSize):
2567         (LayoutTestController::setPrivateBrowsingEnabled):
2568         (LayoutTestController::setPopupBlockingEnabled):
2569         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2570         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2571         (LayoutTestController::numberOfActiveAnimations):
2572         (LayoutTestController::disableImageLoading):
2573         (LayoutTestController::dispatchPendingLoadRequests):
2574         (LayoutTestController::setDatabaseQuota):
2575         (LayoutTestController::clearAllDatabases):
2576         (LayoutTestController::whiteListAccessFromOrigin):
2577         (LayoutTestController::waitForPolicyDelegate):
2578         (LayoutTestController::overridePreference):
2579         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
2580         (LayoutTestController::isLoading):
2581         (LayoutTestController::setLoading):
2582         (LayoutTestController::shouldDumpAsText):
2583         (LayoutTestController::shouldDumpBackForwardList):
2584         (LayoutTestController::shouldDumpChildrenAsText):
2585         (LayoutTestController::shouldDumpDatabaseCallbacks):
2586         (LayoutTestController::shouldDumpStatusCallbacks):
2587         (LayoutTestController::shouldWaitUntilDone):
2588         (LayoutTestController::canOpenWindows):
2589         (LayoutTestController::shouldDumpTitleChanges):
2590         (LayoutTestController::waitForPolicy):
2591         (LayoutTestController::dumpAsText):
2592         (LayoutTestController::dumpChildFramesAsText):
2593         (LayoutTestController::dumpDatabaseCallbacks):
2594         (LayoutTestController::dumpStatusCallbacks):
2595         (LayoutTestController::setCanOpenWindows):
2596         (LayoutTestController::dumpBackForwardList):
2597         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2598         (LayoutTestController::display):
2599         (LayoutTestController::dumpTitleChanges):
2600         (LayoutTestController::dumpSelectionRect):
2601         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
2602         (TextInputController::TextInputController):
2603         (TextInputController::doCommand):
2604         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
2605         * DumpRenderTree/qt/WorkQueue.cpp:
2606         * DumpRenderTree/qt/WorkQueue.h:
2607         * DumpRenderTree/qt/WorkQueueItem.h:
2608         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
2609         (findFrameNamed):
2610         (LoadItem::invoke):
2611         (ReloadItem::invoke):
2612         (ScriptItem::invoke):
2613         (BackForwardItem::invoke):
2614         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
2615         * DumpRenderTree/qt/jsobjects.h:
2616
2617 2009-10-13  Dmitry Titov  <dimich@chromium.org>
2618
2619         Not reviewed, adding myself to the list of reviewers.
2620
2621         * Scripts/modules/committers.py:
2622
2623 2009-10-13  Anders Carlsson  <andersca@apple.com>
2624
2625         Reviewed by Sam Weinig.
2626
2627         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
2628
2629         Make the private browsing mode testable by the test plug-in.
2630         
2631         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2632         (pluginGetProperty):
2633         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2634         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2635         (NPP_New):
2636         (NPP_SetValue):
2637
2638 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
2639
2640         No review, just adding self to the list of reviewers.
2641
2642         * Scripts/modules/committers.py:
2643
2644 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
2645
2646         Reviewed by Adam Roben.
2647
2648         Web Inspector: Use proper web view in inspector layout
2649         tests for windows.
2650
2651         https://bugs.webkit.org/show_bug.cgi?id=30298
2652
2653         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2654         (LayoutTestController::showWebInspector):
2655         (LayoutTestController::closeWebInspector):
2656         (LayoutTestController::evaluateInWebInspector):
2657
2658 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
2659
2660         Reviewed by Sam Weinig.
2661
2662         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
2663         https://bugs.webkit.org/show_bug.cgi?id=29841
2664
2665         * DumpRenderTree/mac/DumpRenderTree.mm:
2666         (resetDefaultsToConsistentValues):
2667         * DumpRenderTree/win/DumpRenderTree.cpp:
2668         (resetDefaultsToConsistentValues):
2669
2670 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
2671
2672         Reviewed by Dimitri Glazkov.
2673
2674         Chromium Port - Windows
2675         https://bugs.webkit.org/show_bug.cgi?id=29969
2676
2677         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
2678         * Scripts/webkitdirs.pm:
2679
2680 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
2681
2682         Reviewed by Darin Adler.
2683
2684         jsc scripts cleanup and Qt/GTK fix
2685         https://bugs.webkit.org/show_bug.cgi?id=30288
2686
2687         Duplicated jscPath() moved to webkitdirs.pm.
2688         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
2689         Configuration added (release/debug) to path for Qt-port on Windows.
2690
2691         * Scripts/run-javascriptcore-tests:
2692         * Scripts/run-jsc:
2693         * Scripts/run-sunspider:
2694         * Scripts/sunspider-compare-results:
2695         * Scripts/webkitdirs.pm:
2696
2697 2009-10-11  Adam Barth  <abarth@webkit.org>
2698
2699         Unreviewed.  Add Collin to committers.py.
2700
2701         * Scripts/modules/committers.py:
2702
2703 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
2704
2705         wx build fix, add bindings to source/include dirs now that there are sources there.
2706
2707         * wx/build/settings.py:
2708
2709 2009-10-09  Mark Rowe  <mrowe@apple.com>
2710
2711         Reviewed by Brady Eidson.
2712
2713         Enable plug-in halting in DumpRenderTree.
2714
2715         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
2716         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
2717
2718         * DumpRenderTree/mac/DumpRenderTree.mm:
2719         (resetDefaultsToConsistentValues):
2720         * DumpRenderTree/mac/UIDelegate.mm:
2721         (-[UIDelegate webView:shouldHaltPlugin:]):
2722
2723 2009-10-08  Brady Eidson  <beidson@apple.com>
2724
2725         Reviewed by Dan Bernstein.
2726
2727         Ask the History Delegate to populate the visited links hash.
2728         <rdar://problem/7285293> and https://webkit.org/b/29904
2729
2730         Add the ability for LayoutTestController to clear all visited links.
2731         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
2732
2733         * DumpRenderTree/LayoutTestController.cpp:
2734         (LayoutTestController::LayoutTestController):
2735         (removeAllVisitedLinksCallback):
2736         (LayoutTestController::staticFunctions):
2737         * DumpRenderTree/LayoutTestController.h:
2738         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2739         (LayoutTestController::removeAllVisitedLinks):
2740
2741         * DumpRenderTree/mac/HistoryDelegate.mm:
2742         (-[HistoryDelegate populateVisitedLinksForWebView:]):
2743
2744         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2745         (LayoutTestController::removeAllVisitedLinks):
2746         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2747         (LayoutTestController::removeAllVisitedLinks):
2748         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2749         (LayoutTestController::removeAllVisitedLinks):
2750
2751
2752 2009-10-08  Daniel Bates  <dbates@webkit.org>
2753
2754         Reviewed by Adam Roben.
2755
2756         https://bugs.webkit.org/show_bug.cgi?id=30175
2757         
2758         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
2759         the OLE drag-and-drop return value like the function it emulates. Currently, 
2760         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
2761         whether the drag-and-drop operation was successful or was cancelled.
2762         
2763         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
2764         return value according to whether the drop operation was successful or not.
2765
2766         * DumpRenderTree/win/EventSender.cpp:
2767         (doMouseUp): Added parameter oleDragAndDropReturnValue.
2768         (replaySavedEvents): Ditto.
2769         * DumpRenderTree/win/EventSender.h:
2770         * DumpRenderTree/win/UIDelegate.cpp:
2771         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
2772
2773 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
2774
2775         Reviewed by Xan Lopez.
2776
2777         [GTK] Added support for a parameter setting the button that was
2778         pressed in the mouseDown function.
2779         https://bugs.webkit.org/show_bug.cgi?id=30220
2780
2781         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2782
2783 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
2784
2785         Reviewed by Xan Lopez.
2786
2787         [GTK] Added a line to the bottom of the expected result to match
2788         the output of the test.
2789         https://bugs.webkit.org/show_bug.cgi?id=30220
2790
2791         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
2792         expected.txt:
2793
2794 2009-10-08  Adam Roben  <aroben@apple.com>
2795
2796         Use QueryInterface to get IWebInspectorPrivate
2797
2798         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
2799         accessed in a more standard way
2800
2801         Reviewed by John Sullivan and Tim Hatcher.
2802
2803         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2804         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
2805         by calling IWebViewPrivate::inspector, then use QueryInterface to get
2806         to the IWebInspectorPrivate interface.
2807
2808 2009-10-07  Adam Roben  <aroben@apple.com>
2809
2810         Implement DRT support for origin whitelisting
2811
2812         Fixes <http://webkit.org/b/30185>.
2813
2814         Reviewed by Eric Seidel.
2815
2816         * DumpRenderTree/win/DumpRenderTree.cpp:
2817         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
2818         whitelist, to match Mac DRT.
2819         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2820         (LayoutTestController::whiteListAccessFromOrigin): Call through to
2821         IWebViewPrivate::whiteListAccessFromOrigin.
2822
2823 2009-10-07  Brady Eidson  <beidson@apple.com>
2824
2825         Reviewed by Darin Adler.
2826
2827         Send title changes to the global history delegate.
2828         <rdar://problem/7285293> and https://webkit.org/b/29904
2829
2830         * DumpRenderTree/mac/HistoryDelegate.mm:
2831         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
2832
2833 2009-10-07  Adam Barth  <abarth@webkit.org>
2834
2835         Unreviewed.  Remove some folks from committers.py who were listed on
2836         the WebKit Team wiki page but who weren't actually listed as commit+.
2837         At some point, we should coorelate this list with the committers
2838         mailing list.
2839
2840         * Scripts/modules/committers.py:
2841
2842 2009-10-07  Adam Barth  <abarth@webkit.org>
2843
2844         Unreviewed.  Import a bunch of committers from the WebKit Team page on
2845         the wiki into committers.py.
2846
2847         * Scripts/modules/committers.py:
2848
2849 2009-10-07  Adam Barth  <abarth@webkit.org>
2850
2851         Unreviewed.  Added Aaron Boodman to committers.py.
2852
2853         * Scripts/modules/committers.py:
2854
2855 2009-10-07  Evan Martin  <evan@chromium.org>
2856
2857         Reviewed by Darin Adler.
2858
2859         Add API to LayoutTestController for re/setting the system locale.
2860         https://bugs.webkit.org/show_bug.cgi?id=18994
2861
2862         * DumpRenderTree/LayoutTestController.cpp:
2863         (setLocaleCallback):
2864         (LayoutTestController::staticFunctions):
2865         (LayoutTestController::setLocale):
2866         * DumpRenderTree/LayoutTestController.h:
2867
2868 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
2869
2870         Reviewed by Jan Alonzo.
2871
2872         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
2873         https://bugs.webkit.org/show_bug.cgi?id=29689
2874
2875         Build fix by adding -lfontconfig for DumpRenderTree.
2876
2877         * GNUmakefile.am:
2878
2879 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2880
2881         Reviewed by Simon Hausmann.
2882
2883         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
2884
2885         * Scripts/run-webkit-tests:
2886
2887 2009-10-07  Xan Lopez  <xlopez@igalia.com>
2888
2889         Reviewed by Gustavo Noronha.
2890
2891         "delete" in EventSender is the backspace key, not the delete one.
2892
2893         * DumpRenderTree/gtk/EventSender.cpp:
2894         (keyDownCallback):
2895
2896 2009-10-07  Xan Lopez  <xlopez@igalia.com>
2897
2898         Reviewed by Gustavo Noronha.
2899
2900         getChildrenWithRange expects as last parameter the end index, not
2901         the length of the range. Correct this and clarify the variable
2902         names to reflect how the code works.
2903
2904         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2905         (AccessibilityUIElement::getChildrenWithRange):
2906         (AccessibilityUIElement::getChildAtIndex):
2907
2908 2009-10-06  Mark Rowe  <mrowe@apple.com>
2909
2910         Reviewed by Simon Fraser.
2911
2912         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
2913
2914         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
2915         the fact we have already changed the working directory to the top of the open source tree.
2916
2917 2009-10-06  Julie Parent  <jparent@chromium.org>
2918
2919         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
2920         rather than my committer email.
2921
2922         * Scripts/modules/committers.py:
2923
2924 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2925
2926         Reviewed by Eric Seidel.
2927
2928         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
2929
2930         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
2931         it after each layout test as it should do, making the DRT dump additional output
2932         for all of the subsequent layout tests.
2933
2934         * DumpRenderTree/qt/jsobjects.cpp:
2935         (LayoutTestController::reset):
2936
2937 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2938
2939         Reviewed by Simon Hausmann.
2940
2941         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
2942         fast/dom/assign-to-window-status.html test, which is passing as a result.
2943
2944         https://bugs.webkit.org/show_bug.cgi?id=30127
2945
2946         * DumpRenderTree/qt/DumpRenderTree.cpp:
2947         (WebCore::DumpRenderTree::DumpRenderTree):
2948         (WebCore::DumpRenderTree::statusBarMessage):
2949         * DumpRenderTree/qt/DumpRenderTree.h:
2950         * DumpRenderTree/qt/jsobjects.h:
2951         (LayoutTestController::shouldDumpStatusCallbacks):
2952         (LayoutTestController::dumpStatusCallbacks):
2953
2954 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2955
2956         Reviewed by Simon Hausmann.
2957
2958         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
2959         ignores the argument indicating which mouse button to trigger.
2960         https://bugs.webkit.org/show_bug.cgi?id=30048
2961
2962         This affects the fast/events/mouse-click-events.html layout test.
2963
2964         * DumpRenderTree/qt/jsobjects.cpp:
2965         (EventSender::mouseDown):
2966         (EventSender::mouseUp):
2967         * DumpRenderTree/qt/jsobjects.h:
2968
2969 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2970
2971         Reviewed by Simon Hausmann.
2972
2973         [Qt] Fix the EventSender::keyDown() implementation
2974         https://bugs.webkit.org/show_bug.cgi?id=30043
2975
2976         It should post both a key press event and a key release event,
2977         just like other ports do.
2978
2979         * DumpRenderTree/qt/jsobjects.cpp:
2980         (EventSender::keyDown):
2981
2982 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
2983
2984         wx build fix. Add jpeg to the list of libs to link against.
2985
2986         * wx/build/settings.py:
2987
2988 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
2989
2990         Reviewed by Simon Hausmann.
2991
2992         [Qt] EventSender::keyDown() cannot send function-key events.
2993         https://bugs.webkit.org/show_bug.cgi?id=30044
2994
2995         This affects the fast/events/keydown-function-keys.html layout test.
2996
2997         * DumpRenderTree/qt/jsobjects.cpp:
2998         (EventSender::keyDown):
2999
3000 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3001
3002         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3003         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3004
3005         * wx/build/settings.py:
3006         * wx/build/wxpresets.py:
3007
3008 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3009
3010         Reviewed by Timothy Hatcher.
3011
3012         Web Inspector: add testing harness for Web Inspector.
3013
3014         https://bugs.webkit.org/show_bug.cgi?id=30010
3015
3016         * DumpRenderTree/LayoutTestController.cpp:
3017         (showWebInspectorCallback):
3018         (closeWebInspectorCallback):
3019         (evaluateInWebInspectorCallback):
3020         (LayoutTestController::staticFunctions):
3021         * DumpRenderTree/LayoutTestController.h:
3022         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3023         (LayoutTestController::showWebInspector):
3024         (LayoutTestController::closeWebInspector):
3025         (LayoutTestController::evaluateInWebInspector):
3026         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3027         (LayoutTestController::showWebInspector):
3028         (LayoutTestController::closeWebInspector):
3029         (LayoutTestController::evaluateInWebInspector):
3030         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3031         (LayoutTestController::showWebInspector):
3032         (LayoutTestController::closeWebInspector):
3033         (LayoutTestController::evaluateInWebInspector):
3034         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3035         (LayoutTestController::showWebInspector):
3036         (LayoutTestController::closeWebInspector):
3037         (LayoutTestController::evaluateInWebInspector):
3038
3039 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3040
3041         Reviewed by Ariyha Hidayat.
3042
3043         Pass arguments to system() as a string instead of array
3044
3045         When passed as an array entries with a space fail to translate
3046         to two arguments to the child process, so instead of manually
3047         splitting all the entries in @buildArgs we pass the whole thing
3048         as a string instead.
3049
3050         * Scripts/webkitdirs.pm:
3051
3052 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3053
3054         Reviewed by David Levin.
3055
3056         check-webkit-style misses whitespace errors for operators:
3057         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3058         https://bugs.webkit.org/show_bug.cgi?id=30021
3059
3060         * Scripts/modules/cpp_style.py:
3061         Added the operators mentioned above to the same list as == and !=.
3062
3063 2009-10-02  Julie Parent  <jparent@chromium.org>
3064
3065         Unreviewed.
3066
3067         Adding myself and Ojan Vafai as committers, because we are committers.
3068
3069         * Scripts/modules/committers.py:
3070
3071 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3072
3073         Reviewed by Adam Roben.
3074
3075         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3076         this will help the patch merging process when TryBots are used.
3077
3078         * Scripts/svn-create-patch:
3079
3080 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
3081
3082         Reviewed by Simon Hausmann.
3083
3084         [Qt] Implement layoutTestController.overridePreference().
3085         https://bugs.webkit.org/show_bug.cgi?id=29970
3086
3087         * DumpRenderTree/qt/DumpRenderTree.cpp:
3088         (WebCore::WebPage::WebPage):
3089         (WebCore::WebPage::resetSettings):
3090         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3091         * DumpRenderTree/qt/jsobjects.cpp:
3092         (LayoutTestController::reset):
3093         (LayoutTestController::setPrivateBrowsingEnabled):
3094         (LayoutTestController::setPopupBlockingEnabled):
3095         (LayoutTestController::overridePreference):
3096         * DumpRenderTree/qt/jsobjects.h:
3097
3098 2009-10-01  Chris Marrin  <cmarrin@apple.com>
3099
3100         Reviewed by Oliver Hunt.
3101
3102         Turn on ENABLE_3D_CANVAS in TOT
3103         https://bugs.webkit.org/show_bug.cgi?id=29906
3104
3105         * Scripts/build-webkit:
3106
3107 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3108
3109         Rubberstamped by Simon Hausmann.
3110
3111         Enable HTTP tests for Qt
3112
3113         * Scripts/run-webkit-tests:
3114
3115 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3116
3117         Reviewed by Dimitri Glazkov.
3118
3119         build-webkit --chromium now also works on cygwin.
3120
3121         https://bugs.webkit.org/show_bug.cgi?id=29973
3122
3123         * Scripts/webkitdirs.pm:
3124
3125 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3126
3127         Reviewed by Simon Hausmann.
3128
3129         [Qt] Don't use TCmalloc in DumpRenderTree
3130         https://bugs.webkit.org/show_bug.cgi?id=27029
3131
3132         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3133
3134         * DumpRenderTree/qt/DumpRenderTree.pro:
3135
3136 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3137
3138         Reviewed by Simon Hausmann.
3139
3140         [Qt] Implement eventSender.scheduleAsynchronousClick().
3141
3142         https://bugs.webkit.org/show_bug.cgi?id=29931
3143
3144         * DumpRenderTree/qt/jsobjects.cpp:
3145         (EventSender::scheduleAsynchronousClick):
3146         * DumpRenderTree/qt/jsobjects.h:
3147
3148 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3149
3150         Reviewed by Simon Hausmann.
3151
3152         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
3153         fast/events/open-window-from-another-frame.html from the Skipped list.
3154
3155         https://bugs.webkit.org/show_bug.cgi?id=29930
3156
3157         * DumpRenderTree/qt/jsobjects.cpp:
3158         (LayoutTestController::setPopupBlockingEnabled):
3159         * DumpRenderTree/qt/jsobjects.h:
3160
3161 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
3162
3163         Unreviewed.
3164
3165         Added myself to the list of committers.
3166
3167         * Scripts/modules/committers.py:
3168
3169 2009-09-30  Eric Seidel  <eric@webkit.org>
3170
3171         No review, just adding Geoff to the list of reviewers.
3172
3173         * Scripts/modules/committers.py:
3174
3175 2009-09-30  Dan Bernstein  <mitz@apple.com>
3176
3177         Reviewed by Sam Weinig.
3178
3179         Added the WebKit Layout Tests fonts that are referenced in
3180         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
3181
3182         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
3183         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
3184
3185 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3186
3187         Reviewed by David Kilzer.
3188
3189         Make sunspider scripts work on Windows platform.
3190         https://bugs.webkit.org/show_bug.cgi?id=29656
3191
3192         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
3193         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
3194         * Scripts/webkitdirs.pm: currentPerlPath() added.
3195
3196 2009-09-29  Brady Eidson  <beidson@apple.com>
3197
3198         Rubberstamped by Dan Bernstein.
3199
3200         Fix license and some sorting in new files.
3201
3202         * DumpRenderTree/mac/HistoryDelegate.h:
3203         * DumpRenderTree/mac/HistoryDelegate.mm:
3204
3205 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
3206
3207         Reviewed by David Kilzer.
3208
3209         Fixed how error codes are handled.
3210         https://bugs.webkit.org/show_bug.cgi?id=29898
3211
3212         * Scripts/update-webkit:
3213         * Scripts/update-webkit-chromium:
3214
3215 2009-09-29  Brady Eidson  <beidson@apple.com>
3216
3217         Reviewed by John Sullivan.
3218
3219         Updated way-out-of-date sorting throughout the dump methods/flags.
3220
3221         * DumpRenderTree/LayoutTestController.cpp:
3222         (LayoutTestController::LayoutTestController):
3223         (dumpAsPDFCallback):
3224         (dumpAsTextCallback):
3225         (dumpFrameLoadCallbacksCallback):
3226         (dumpResourceLoadCallbacksCallback):
3227         (LayoutTestController::staticFunctions):
3228
3229         * DumpRenderTree/LayoutTestController.h:
3230         (LayoutTestController::dumpAsText):
3231         (LayoutTestController::setDumpAsText):
3232         (LayoutTestController::dumpFrameLoadCallbacks):
3233         (LayoutTestController::setDumpFrameLoadCallbacks):
3234         (LayoutTestController::dumpSelectionRect):
3235         (LayoutTestController::setDumpSelectionRect):
3236         (LayoutTestController::dumpSourceAsWebArchive):
3237         (LayoutTestController::setDumpSourceAsWebArchive):
3238         (LayoutTestController::dumpStatusCallbacks):
3239         (LayoutTestController::setDumpStatusCallbacks):
3240         (LayoutTestController::dumpTitleChanges):
3241         (LayoutTestController::setDumpTitleChanges):
3242         (LayoutTestController::dumpWillCacheResponse):
3243         (LayoutTestController::setDumpWillCacheResponse):
3244
3245 2009-09-29  Brady Eidson  <beidson@apple.com>
3246
3247         Reviewed by John Sullivan.
3248
3249         WebKit Mac API should provide a delegate interface for global history.
3250         <rdar://problem/7042773> and https://webkit.org/b/29904
3251
3252         Adding the dumping of global history delegate callbacks.
3253
3254         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3255
3256         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
3257         * DumpRenderTree/mac/DumpRenderTree.mm:
3258         (createWebViewAndOffscreenWindow):
3259         (allocateGlobalControllers):
3260         (shouldLogFrameLoadDelegates):
3261         (shouldLogHistoryDelegates):
3262         (runTest):
3263
3264         Dump history delegate callbacks:
3265         * DumpRenderTree/mac/HistoryDelegate.h: Added.
3266         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
3267         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
3268         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
3269         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
3270
3271 2009-09-29  Daniel Bates  <dbates@webkit.org>
3272
3273         Reviewed by Adam Roben.
3274
3275         https://bugs.webkit.org/show_bug.cgi?id=28902
3276         
3277         Fixes an issue where the drop effect returned by Window Dump Render Tree 
3278         was always DROPEFFECT_NONE (since it was hard coded to do so).
3279         
3280         This patch corrects this issue by determining the actual drop effect 
3281         performed by the corresponding drag-and-drop operation so that we can 
3282         return it.
3283
3284         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
3285         (DraggingInfo::DraggingInfo):
3286         (DraggingInfo::performedDropEffect): Added method.
3287         (DraggingInfo::setPerformedDropEffect): Added method.
3288         * DumpRenderTree/win/EventSender.cpp:
3289         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
3290         Moved delete draggingInfo to UIDelegate::doDragDrop.
3291         * DumpRenderTree/win/UIDelegate.cpp:
3292         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
3293
3294 2009-09-29  Dan Bernstein  <mitz@apple.com>
3295
3296         Reviewed by Adam Roben.
3297
3298         Remove copying of unnecessary or nonexistent files from the ImageDiff
3299         post-build event.
3300
3301         * DumpRenderTree/win/ImageDiff.vcproj:
3302
3303 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3304
3305         Reviewed by David Kilzer.
3306
3307         [Qt] Make build-webkit script work on Windows
3308         https://bugs.webkit.org/show_bug.cgi?id=29802
3309
3310         * Scripts/run-webkit-tests:
3311         * Scripts/webkitdirs.pm:
3312          - Removed unnecessary -p switch for mkdir on Windows.
3313          - Use canonical path, which uses slashes or backslashes depends on platform.
3314          - isWindows() only test for Windows and not for Cyqwin.
3315
3316 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3317
3318         Reviewed by Simon Hausmann.
3319
3320         Fix time measurement in build-webkit after refactoring done in r48853.
3321
3322         * Scripts/build-webkit:
3323
3324 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3325
3326         Reviewed by Tor Arne Vestbø.
3327
3328         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
3329         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
3330
3331         * DumpRenderTree/qt/DumpRenderTree.cpp:
3332         (WebCore::WebPage::WebPage):
3333
3334 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
3335
3336         Reviewed by Simon Hausmann.
3337
3338         [Qt] Implement eventSender.contextClick().
3339         https://bugs.webkit.org/show_bug.cgi?id=29821
3340
3341         * DumpRenderTree/qt/jsobjects.cpp:
3342         (EventSender::contextClick):
3343         * DumpRenderTree/qt/jsobjects.h:
3344
3345 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3346
3347         Reviewed by Eric Seidel.
3348
3349         Add experimentalWebSocketsEnabled in WebPreferences.
3350         https://bugs.webkit.org/show_bug.cgi?id=28941
3351
3352         * DumpRenderTree/mac/DumpRenderTree.mm:
3353         (resetDefaultsToConsistentValues):
3354         * DumpRenderTree/win/DumpRenderTree.cpp:
3355         (resetDefaultsToConsistentValues):
3356
3357 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
3358
3359         Reviewed by David Kilzer.
3360
3361         Integrated chromium port building into webkit tools update-webkit and
3362         build-webkit.
3363
3364         https://bugs.webkit.org/show_bug.cgi?id=29749
3365
3366         * Scripts/build-webkit: When --chromium is specified, will build
3367           the chromium port (currently only Mac is supported).
3368         * Scripts/update-webkit: When --chromium is specified, delegates to
3369           update-webkit-chromium.
3370         * Scripts/webkitdirs.pm: Added chromium specific defs.
3371         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
3372           chromium port's dependencies and update its project files.
3373
3374 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3375
3376         Unreviewed.
3377
3378         Add myself to list of committers.
3379
3380         * Scripts/modules/committers.py:
3381
3382 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3383
3384         Reviewed by Darin Adler.
3385
3386         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
3387         https://bugs.webkit.org/show_bug.cgi?id=29771
3388
3389         * Scripts/run-webkit-tests:
3390
3391 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3392
3393         Reviewed by Simon Hausmann.
3394
3395         [Qt] Implement layoutTestController.waitForPolicyDelegate.
3396         https://bugs.webkit.org/show_bug.cgi?id=25037
3397
3398         * DumpRenderTree/qt/DumpRenderTree.cpp:
3399         (WebCore::WebPage::acceptNavigationRequest):
3400         * DumpRenderTree/qt/DumpRenderTree.pro:
3401         * DumpRenderTree/qt/jsobjects.cpp:
3402         (LayoutTestController::reset):
3403         (LayoutTestController::notifyDone):
3404         (LayoutTestController::waitForPolicyDelegate):
3405         * DumpRenderTree/qt/jsobjects.h:
3406         (LayoutTestController::waitForPolicy):
3407
3408 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3409
3410         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
3411
3412         Reviewed by Eric Seidel.
3413
3414         The -o|--open switch uses the open(1) command on Mac OS X to
3415         open the bug URL in the default web browser.  If there are
3416         similar mechanisms on other platforms, they may be added later.
3417
3418         * Scripts/mark-bug-fixed:
3419         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
3420         options.
3421         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
3422         code into main() and extracted prompting code into
3423         _prompt_user_for_correctness().
3424         (MarkBugFixed._open_bug_in_web_browser): Added.
3425         (MarkBugFixed._prompt_user_for_correctness): Added.
3426         (MarkBugFixed.main): Added logging code from
3427         _determine_bug_id_and_svn_revision().  Added code to call
3428         _open_bug_in_web_browser() if the switch is set.  Added code to
3429         call _prompt_user_for_correctness() when needed.
3430         * Scripts/modules/bugzilla.py:
3431         (Bugzilla.short_bug_url_for_bug_id): Added.
3432
3433 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3434
3435         svn-unapply and svn-apply don't work when used outside multiple svn working directories
3436
3437         <http://webkit.org/b/29744>
3438         <rdar://problem/7252905>
3439
3440         Reviewed by Eric Seidel.
3441
3442         Some users have a workflow where svn-create-patch, svn-apply and
3443         svn-unapply are used outside of multiple svn working
3444         directories.  Instead of aborting the scripts in these cases,
3445         print a warning and assume that Subversion is being used.
3446
3447         * Scripts/VCSUtils.pm:
3448         (determineVCSRoot): Call warn() instead of die() if both isGit()
3449         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
3450         to enforce the assumption about Subversion, then return
3451         determineSVNRoot().
3452         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
3453         VCSUtils.pm.  They both already cache their values and checking
3454         here is redundant since determineVCSRoot() is called later.
3455
3456 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
3457
3458         Reviewed by Gustavo Noronha.
3459
3460         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3461         https://bugs.webkit.org/show_bug.cgi?id=29689
3462
3463         Load test fonts through FontConfig before each test.
3464         This ensures a more proper rendering of the tests.
3465
3466         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3467         (initializeFonts):
3468         (runTest):
3469         (main):
3470         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
3471         * GNUmakefile.am:
3472
3473 2009-09-25  David Kilzer  <ddkilzer@apple.com>
3474
3475         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
3476
3477         Reviewed by Eric Seidel.
3478
3479         * Scripts/mark-bug-fixed:
3480         (MarkBugFixed.__init__): Added -u|--update-only switch to list
3481         of parse options.
3482         (MarkBugFixed.main): When -u|--update-only is specified, add a
3483         comment to the bug without marking it Resolved/Fixed.
3484
3485 2009-09-25  Darin Adler  <darin@apple.com>
3486
3487         Reviewed by Geoffrey Garen.
3488
3489         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
3490         out, just as we do for the resources directory.
3491
3492 2009-09-25  Adam Barth  <abarth@webkit.org>
3493
3494         Unreviewed.  Added Tony to committers.py because he's a
3495         committer now.
3496
3497         * Scripts/modules/committers.py:
3498
3499 2009-09-25  Eric Seidel  <eric@webkit.org>
3500
3501         Reviewed by Simon Fraser.
3502
3503         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
3504         https://bugs.webkit.org/show_bug.cgi?id=28624
3505
3506         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
3507
3508         * DumpRenderTree/mac/DumpRenderTree.mm:
3509         (resetDefaultsToConsistentValues):
3510
3511 2009-09-25  Eric Seidel  <eric@webkit.org>
3512
3513         Reviewed by Adam Barth.
3514
3515         commit-queue should auto-retry patches which fail to commit due to out of date files
3516         https://bugs.webkit.org/show_bug.cgi?id=28316
3517
3518         * Scripts/bugzilla-tool:
3519          - Handle new CheckoutNeedsUpdate exception.
3520         * Scripts/modules/logging_unittest.py:
3521          - Call the ScriptError constructor correctly (this test had regressed).
3522         * Scripts/modules/scm.py:
3523          - Added the ability to define custom error handlers for run_command
3524            and added a commit_error_handler which throws CheckoutNeedsUpdate
3525            instead of ScriptError.
3526          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
3527         * Scripts/modules/scm_unittest.py:
3528          - Added tests of new error handlers.
3529
3530 2009-09-25  Eric Seidel  <eric@webkit.org>
3531
3532         Reviewed by Adam Barth.
3533
3534         commit-queue should give better feedback when failing a patch
3535         https://bugs.webkit.org/show_bug.cgi?id=29316
3536
3537         * Scripts/bugzilla-tool:
3538          - Update ScriptError uses to the new constructor format.
3539          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
3540            so that we can print to both stdout as well as an output buffer for error reporting.
3541          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
3542          - Use e.message_with_output() when failing a patch (this is the real fix here).
3543            I also removed use of "This patch will require manual commit." as that's not always true.
3544          - Add missing word "bug" from log message.
3545         * Scripts/modules/scm.py:
3546          - Make ScriptError save a bunch more data so that error messages can be nicer.
3547          - Update ScriptError callers.
3548
3549 2009-09-24  John Gregg  <johnnyg@google.com>
3550
3551         Reviewed by Eric Seidel.
3552
3553         Enable switch for notifications (experimental) in Page Settings
3554         https://bugs.webkit.org/show_bug.cgi?id=28930
3555
3556         Now that desktop notifications are controlled by run-time switch,
3557         set that switch to true for DumpRenderTree.
3558
3559         * DumpRenderTree/mac/DumpRenderTree.mm:
3560         (resetDefaultsToConsistentValues):
3561         * DumpRenderTree/win/DumpRenderTree.cpp:
3562         (resetDefaultsToConsistentValues):
3563         * DumpRenderTree/win/UIDelegate.cpp:
3564         (UIDelegate::QueryInterface):
3565
3566 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
3567
3568         wx build fix. SnowLeopard fixes for Mac dependencies.
3569
3570         * wx/build/build_utils.py:
3571         * wx/build/settings.py:
3572         * wx/install-unix-extras:
3573
3574 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3575
3576         Reviewed by Oliver Hunt.
3577
3578         Add support for DRT to send mouse wheel events.
3579
3580         https://bugs.webkit.org/show_bug.cgi?id=29348
3581         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
3582
3583         * DumpRenderTree/gtk/EventSender.cpp:
3584         (mouseWheelToCallback):
3585
3586 2009-09-17  Eric Seidel  <eric@webkit.org>
3587
3588         Reviewed by David Levin.
3589
3590         commit-queue needs web-based status reporting
3591         https://bugs.webkit.org/show_bug.cgi?id=29307
3592
3593         Add a first-pass web-based status for the commit-queue.
3594         The bot is currently reachable at:
3595         http://webkit-commit-queue.appspot.com/
3596
3597         * CommitQueueStatus/app.yaml: Added.
3598          - Application description file required by App Engine.
3599         * CommitQueueStatus/filters/__init__.py: Added.
3600          - Required by python to treat 'filters' as a module.
3601         * CommitQueueStatus/filters/webkit_extras.py: Added.
3602          - Support for turning 'bug 123' and 'patch 123' into links.
3603            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
3604         * CommitQueueStatus/index.html: Added.
3605         * CommitQueueStatus/index.yaml: Added.
3606          - Some auto-generated file from app engine.
3607         * CommitQueueStatus/queue_status.py: Added.
3608          - The core logic of this bot.  We could eventually split this file out into pieces.
3609         * CommitQueueStatus/stylesheets/main.css: Added.
3610          - Some basic lame-o CSS to make the page look less awful.
3611         * CommitQueueStatus/update_status.html: Added.
3612          - The form that the commit-queue (or a human) can use to update the status.
3613         * Scripts/bugzilla-tool:
3614          - Add some very basic update_status calls.
3615         * Scripts/modules/statusbot.py: Added.
3616          - Knows how to post to the CommitQueueStatus web application.
3617
3618 2009-09-24  David Kilzer  <ddkilzer@apple.com>
3619
3620         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
3621
3622         Reviewed by Adam Roben.
3623
3624         * Scripts/mark-bug-fixed:
3625         (MarkBugFixed.__init__): Added -m|--comment switch to list of
3626         parse options.
3627         (MarkBugFixed.main): When specified, prepend comment from
3628         -m|--comment command-line switch to the bug comment.
3629
3630 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3631
3632         Reviewed by Jan Alonzo.
3633
3634         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
3635         https://bugs.webkit.org/show_bug.cgi?id=29693
3636
3637         Show the window, to be able to synthesize events correctly.
3638
3639         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3640         (runTest):
3641         (main):
3642
3643 2009-09-24  Oliver Hunt  <oliver@apple.com>
3644
3645         Reviewed by NOBODY(rollout)
3646
3647         Roll out r48712 as it is incorrect.
3648
3649         * DumpRenderTree/mac/ObjCController.m:
3650         (+[ObjCController isSelectorExcludedFromWebScript:]):
3651         (+[ObjCController webScriptNameForSelector:]):
3652
3653 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
3654
3655         Reviewed by Eric Seidel.
3656
3657         https://bugs.webkit.org/show_bug.cgi?id=29005
3658         The indices of RuntimeArray should be enumerated like for a regular array.
3659
3660         * DumpRenderTree/mac/ObjCController.m:
3661         (+[ObjCController isSelectorExcludedFromWebScript:]):
3662         (+[ObjCController webScriptNameForSelector:]):
3663         (-[ObjCController arrayOfString]):
3664
3665 2009-09-23  David Kilzer  <ddkilzer@apple.com>
3666
3667         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
3668
3669         Reviewed by Darin Adler.
3670
3671         Also fixed a bug where specifying a revision on the command-line
3672         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
3673
3674         * Scripts/bugzilla-tool: Updated module import statements.
3675         (parse_bug_id): Removed.  Moved to bugzilla.py.
3676         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
3677         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
3678         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
3679         (BugzillaTool.__init__): Removed mark-fixed subcommand.
3680         * Scripts/mark-bug-fixed: Added.
3681         * Scripts/modules/bugzilla.py:
3682         (parse_bug_id): Added.  Moved from bugzilla-tool.
3683         * Scripts/modules/comments.py: Added.
3684        &n