74bdb20bab58406c0eac056307884d5023f8f5d5
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-12-07  Alexey Proskuryakov  <ap@apple.com>
2
3         * Scripts/run-webkit-websocketserver: Added property svn:executable.
4
5 2009-12-07  Yuzo Fujishima  <yuzo@google.com>
6
7         Reviewed by Alexey Proskuryakov.
8
9         Add run-webkit-websocketserver
10
11         https://bugs.webkit.org/show_bug.cgi?id=31390
12
13         * Scripts/run-webkit-websocketserver: Added.
14
15 2009-12-07  Steve Falkenburg  <sfalken@apple.com>
16
17         Build fix. Be flexible about which version of ICU is used on Windows.
18
19         * DumpRenderTree/win/DumpRenderTree.vcproj: Add optional xcopy commands to copy ICU 4.2.
20
21 2009-12-07  Dirk Schulze  <krit@webkit.org>
22
23         Not reviewed, adding myself to the reviewers list.
24
25         * Scripts/modules/committers.py:
26
27 2009-12-06  Eric Seidel  <eric@webkit.org>
28
29         Reviewed by Adam Barth.
30
31         Add an API for uploading results files to StatusBot
32         https://bugs.webkit.org/show_bug.cgi?id=32210
33
34         Add Content-Type: plain/text which was forgotten
35         from the previous commit when I landed with land-patches
36         instead of land-diff.
37
38         * QueueStatusServer/queue_status.py:
39
40 2009-12-06  Eric Seidel  <eric@webkit.org>
41
42         Reviewed by Adam Barth.
43
44         Status Server needs a way to handle uploaded results
45         https://bugs.webkit.org/show_bug.cgi?id=32209
46
47         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
48         * QueueStatusServer/update_status.html: Add file upload.
49
50 2009-12-06  Eric Seidel  <eric@webkit.org>
51
52         Reviewed by Adam Barth.
53
54         Add an API for uploading results files to StatusBot
55         https://bugs.webkit.org/show_bug.cgi?id=32210
56
57         * Scripts/modules/statusbot.py:
58
59 2009-12-06  Eric Seidel  <eric@webkit.org>
60
61         Reviewed by Adam Barth.
62
63         Status Server needs a way to handle uploaded results
64         https://bugs.webkit.org/show_bug.cgi?id=32209
65
66         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
67         * QueueStatusServer/update_status.html: Add file upload.
68
69 2009-12-06  Adam Barth  <abarth@webkit.org>
70
71         Reviewed by Eric Seidel.
72
73         [bzt] BuildAttachment should not check the builders
74         https://bugs.webkit.org/show_bug.cgi?id=32207
75
76         This is code that got copied here by accident when the class was created.
77
78         * Scripts/modules/commands/download.py:
79
80 2009-12-06  Adam Barth  <abarth@webkit.org>
81
82         Reviewed by Eric Seidel.
83
84         [bzt] Make LandingSequence.update aware of ports
85         https://bugs.webkit.org/show_bug.cgi?id=32208
86
87         This is required to make build work on the Chromium port because
88         Chromium has a custom update-webkit.
89
90         * Scripts/modules/landingsequence.py:
91
92 2009-12-06  Adam Barth  <abarth@webkit.org>
93
94         Reviewed by Eric Seidel.
95
96         Add early warning system commands to bugzilla-tool.
97
98         * Scripts/bugzilla-tool:
99         * Scripts/modules/landingsequence.py:
100         * Scripts/modules/webkitport.py:
101
102 2009-12-06  Adam Barth  <abarth@webkit.org>
103
104         Reviewed by Eric Seidel.
105
106         [bzt] Implement Qt EarlyWarningSystem and Chromium EarlyWarningSystem
107         https://bugs.webkit.org/show_bug.cgi?id=32205
108
109         * Scripts/modules/commands/early_warning_system.py: Added.
110         * Scripts/modules/commands/queues.py:
111
112 2009-12-06  Dan Bernstein  <mitz@apple.com>
113
114         Reviewed by Adele Peterson.
115
116         REGRESSION (r51728): update-webkit fails when the current directory is
117         not inside a Subversion working copy
118         https://bugs.webkit.org/show_bug.cgi?id=32204
119
120         * Scripts/update-webkit: Invoke isSVN() in the correct working
121         directory.
122
123 2009-12-06  Adam Barth  <abarth@webkit.org>
124
125         Reviewed by Eric Seidel.
126
127         [bzt] Rename AbstractTryQueue to AbstractReviewQueue
128         https://bugs.webkit.org/show_bug.cgi?id=32202
129
130         * Scripts/modules/commands/queues.py:
131
132 2009-12-05  Adam Barth  <abarth@webkit.org>
133
134         Reviewed by Eric Seidel.
135
136         [bzt] Implement ChromiumPort
137         https://bugs.webkit.org/show_bug.cgi?id=32182
138
139         * Scripts/modules/webkitport.py:
140         * Scripts/modules/webkitport_unittest.py:
141
142 2009-12-05  Adam Barth  <abarth@webkit.org>
143
144         Reviewed by Eric Seidel.
145
146         Move update-webkit into BuildSteps
147         https://bugs.webkit.org/show_bug.cgi?id=32181
148
149         We need to move update-webkit out of SCM.py because SCM isn't supposed to know
150         that WebKit exists.  The proper place for the knowledge of the existence of
151         update-webkit is in WebKitPort because some ports have specialized update
152         scripts (analogous to build-webkit).
153
154         * Scripts/modules/buildsteps.py:
155         * Scripts/modules/commands/download.py:
156         * Scripts/modules/landingsequence.py:
157         * Scripts/modules/scm.py:
158         * Scripts/modules/webkitport.py:
159
160 2009-12-05  Adam Barth  <abarth@webkit.org>
161
162         Reviewed by Eric Seidel.
163
164         update-webkit should call git svn rebase and resolve-ChangeLogs -f
165         https://bugs.webkit.org/show_bug.cgi?id=27162
166
167         Teach update-webkit about Git.  I didn't add the call to
168         resolve-ChangeLogs -f because sometimes that script goes bananas.  We
169         can iterate from here, however.
170
171         * Scripts/update-webkit:
172
173 2009-12-04  Yael Aharon  <yael.aharon@nokia.com>
174
175         Unreviewed build fix.
176
177         [Qt] build fix after r51634 removed unused QBoxLayout include which included limits.h.
178
179         * DumpRenderTree/qt/DumpRenderTree.cpp:
180
181 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
182
183         Reviewed by Adam Treat.
184
185         Add some missing methods for showing and hiding the
186         Web Inspector.
187
188         * DumpRenderTree/qt/DumpRenderTree.cpp:
189         (WebCore::WebPage::WebPage):
190         (WebCore::WebPage::~WebPage):
191         (WebCore::WebPage::webInspector):
192         * DumpRenderTree/qt/DumpRenderTree.h:
193         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
194         (LayoutTestController::showWebInspector):
195         (LayoutTestController::hideWebInspector):
196         * DumpRenderTree/qt/LayoutTestControllerQt.h:
197
198 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
199
200         Reviewed by Adam Treat.
201
202         Implement the setAllowUniversalAccessFromFileURLs method
203         for the Qt LayoutTestController.
204
205         * DumpRenderTree/qt/DumpRenderTree.cpp:
206         (WebCore::WebPage::resetSettings):
207         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
208         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
209         * DumpRenderTree/qt/LayoutTestControllerQt.h:
210
211 2009-12-04  Chris Fleizach  <cfleizach@apple.com>
212
213         Reviewed by Darin Adler.
214
215         REGRESSION: AX: buttons now extremely repetitive
216         https://bugs.webkit.org/show_bug.cgi?id=32164
217
218         * DumpRenderTree/AccessibilityUIElement.cpp:
219         (isAttributeSupportedCallback):
220         (AccessibilityUIElement::getJSClass):
221         * DumpRenderTree/AccessibilityUIElement.h:
222         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
223         (AccessibilityUIElement::isAttributeSupported):
224         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
225         (AccessibilityUIElement::isAttributeSupported):
226         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
227         (AccessibilityUIElement::isAttributeSupported):
228
229 2009-12-03  Shinichiro Hamaji  <hamaji@chromium.org>
230
231         Reviewed by David Levin.
232
233         check-webkit-style should check for camelCase variable names
234         https://bugs.webkit.org/show_bug.cgi?id=32051
235
236         * Scripts/modules/cpp_style.py:
237         * Scripts/modules/cpp_style_unittest.py:
238
239 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
240
241         Reviewed by Eric Seidel.
242
243         AX: VO just says "term" on many web sites
244         https://bugs.webkit.org/show_bug.cgi?id=32139
245
246         * DumpRenderTree/AccessibilityUIElement.cpp:
247         (getRoleDescriptionCallback):
248         (AccessibilityUIElement::getJSClass):
249         * DumpRenderTree/AccessibilityUIElement.h:
250         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
251         (AccessibilityUIElement::roleDescription):
252         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
253         (AccessibilityUIElement::roleDescription):
254         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
255         (AccessibilityUIElement::roleDescription):
256
257 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
258
259         Reviewed by Beth Dakin.
260
261         Implement WAI-ARIA scrollbar role and related property aria-orientation
262         https://bugs.webkit.org/show_bug.cgi?id=32126
263
264         * DumpRenderTree/AccessibilityUIElement.cpp:
265         (getOrientationCallback):
266         (AccessibilityUIElement::getJSClass):
267         * DumpRenderTree/AccessibilityUIElement.h:
268         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
269         (AccessibilityUIElement::orientation):
270         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
271         (AccessibilityUIElement::orientation):
272         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
273         (AccessibilityUIElement::orientation):
274
275 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
276
277         Reviewed by Adam Roben.
278
279         Minor correction to r51663.
280
281         * DumpRenderTree/win/DumpRenderTree.cpp:
282         (addQTDirToPATH):
283             GetEnvironmentVariable -> GetEnvironmentVariableW.
284
285 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
286
287         Reviewed by Adam Roben.
288
289         ~96 regression tests fail when using QuickTime 7.6 (they pass with QuickTime 7.3)
290         https://bugs.webkit.org/show_bug.cgi?id=30256
291
292         Add the QuickTime dll directory to the PATH environment variable so
293         inialization can succeed.
294
295         * DumpRenderTree/win/DumpRenderTree.cpp:
296         (addQTDirToPATH):
297         (initialize):
298
299 2009-12-03  Shu Chang  <Chang.Shu@nokia.com>
300
301         Reviewed by Kenneth Rohde Christiansen.
302
303         [Qt] After revision 32643, sender() is of type QWebPage instead of QWebFrame.
304
305         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
306         (LayoutTestController::maybeDump):
307
308 2009-12-03  Yuzo Fujishima  <yuzo@google.com>
309
310         Reviewed by Eric Seidel.
311
312         Update pywebsocket to 0.4.3
313         This version logs friendlier and higher-level messages in WARN level, which is used for LayoutTests.
314         Stack trace is logged now in INFO level.
315         https://bugs.webkit.org/show_bug.cgi?id=32097
316
317         * pywebsocket/mod_pywebsocket/dispatch.py:
318         * pywebsocket/mod_pywebsocket/msgutil.py:
319         * pywebsocket/mod_pywebsocket/standalone.py:
320         * pywebsocket/mod_pywebsocket/util.py:
321         * pywebsocket/setup.py:
322         * pywebsocket/test/test_dispatch.py:
323         * pywebsocket/test/test_util.py:
324
325 2009-12-03  Sam Weinig  <sam@webkit.org>
326
327         Reviewed by Gavin Barraclough.
328
329         Fix JSClassRef leak.
330
331         * DumpRenderTree/AccessibilityController.cpp:
332         (AccessibilityController::makeWindowObject):
333         * DumpRenderTree/GCController.cpp:
334         (GCController::makeWindowObject):
335         * DumpRenderTree/LayoutTestController.cpp:
336         (LayoutTestController::makeWindowObject):
337
338 2009-12-03  Brady Eidson  <beidson@apple.com>
339
340         Reviewed by Sam Weinig.
341
342         <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
343
344         Keep DRT-win building...
345
346         * DumpRenderTree/win/FrameLoadDelegate.h:
347         (FrameLoadDelegate::didPushStateWithinPageForFrame):
348         (FrameLoadDelegate::didReplaceStateWithinPageForFrame):
349         (FrameLoadDelegate::didPopStateWithinPageForFrame):
350
351 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
352
353         Unreviewed build fix.
354
355         [Qt] ARM-Linux build fix after r51634 removed unused QBoxLayout include which included limits.h on ARM.
356
357         * DumpRenderTree/qt/DumpRenderTree.cpp:
358
359 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
360
361         Reviewed by Kenneth Rohde Christiansen.
362
363         [Qt] Refactor DRT to not crash on tests which open child windows from javascript.
364         Prevent DRT from showing the main view if these childs get deleted.
365         This fixes https://bugs.webkit.org/show_bug.cgi?id=31591.
366
367         * DumpRenderTree/qt/DumpRenderTree.cpp:
368         (WebCore::WebPage::WebPage):
369         (WebCore::DumpRenderTree::DumpRenderTree):
370         (WebCore::DumpRenderTree::~DumpRenderTree):
371         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
372         (WebCore::DumpRenderTree::open):
373         (WebCore::DumpRenderTree::closeRemainingWindows):
374         (WebCore::DumpRenderTree::createWindow):
375         (WebCore::DumpRenderTree::windowCount):
376         * DumpRenderTree/qt/DumpRenderTree.h:
377
378 2009-12-02  Eric Seidel  <eric@webkit.org>
379
380         Reviewed by Adam Barth.
381
382         REGRESSION(51595): commit-queue is throwing exceptions
383         https://bugs.webkit.org/show_bug.cgi?id=32083
384
385         * Scripts/modules/commands/queues.py:
386          - Don't use default value of [] as it ends up getting shared.
387          - Make log_progress accept arrays of ints as well as strings.
388          - Return an exit code from execute()
389         * Scripts/modules/commands/queues_unittest.py: Added.
390          - Test to make sure log_progress will accept ints.
391          - Test to make sure run_bugzilla_tool will accept ints.
392         * Scripts/modules/workqueue.py:
393          - Print the stack trace on unexpected exceptions for easier debugging.
394         * Scripts/run-webkit-unittests:
395          - Add queues_unittest.
396
397         * Scripts/modules/commands/queues.py:
398         * Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py.
399         * Scripts/modules/mock_bugzillatool.py:
400         * Scripts/modules/workqueue.py:
401         * Scripts/run-webkit-unittests:
402
403 2009-12-02  David Levin  <levin@chromium.org>
404
405         Reviewed by Adam Barth.
406
407         check-webkit-style is too noisy about namespace indenting issues.
408         https://bugs.webkit.org/show_bug.cgi?id=32096
409
410         * Scripts/modules/cpp_style.py:
411         Added a _FileState object to be able to track file level information. In this
412         case, it simply tracks whether the error has already been given, so that it isn't
413         done again.
414         * Scripts/modules/cpp_style_unittest.py:
415         Modified test cases to pass in the _FileState object and fix a test that expected
416         to see the namespace error twice (now it only occurs once). No new tests because
417         existing tests cover the change in functionality.
418
419 2009-12-01  Kevin Ollivier  <kevino@theolliviers.com>
420
421         Reviewed by Eric Seidel.
422
423         [wx] Get DumpRenderTree building after waf switch.
424         
425         https://bugs.webkit.org/show_bug.cgi?id=32041
426
427         * DumpRenderTree/wscript: Added.
428         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
429         (LayoutTestController::setTimelineProfilingEnabled):
430         (LayoutTestController::evaluateScriptInIsolatedWorld):
431         (LayoutTestController::disableImageLoading):
432         (LayoutTestController::whiteListAccessFromOrigin):
433         (LayoutTestController::counterValueForElementById):
434         * Scripts/build-webkit:
435
436 2009-12-02  Adam Barth  <abarth@webkit.org>
437
438         Reviewed by Eric Seidel.
439
440         [bzt] build-attachment shouldn't check whether the builders are red
441         https://bugs.webkit.org/show_bug.cgi?id=32062
442
443         build-attachment doesn't touch the remote repository, so there isn't a
444         need to hold off when the builders are red.
445
446         * Scripts/modules/commands/download.py:
447         * Scripts/modules/landingsequence.py:
448
449 2009-12-02  Eric Seidel  <eric@webkit.org>
450
451         Reviewed by Adam Barth.
452
453         REGRESSION(51590): style-queue and build-queue think their empty when they are not
454         https://bugs.webkit.org/show_bug.cgi?id=32061
455
456         * Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings.
457         * Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints.
458
459 2009-12-02  Eric Seidel  <eric@webkit.org>
460
461         Reviewed by Adam Barth.
462
463         build-queue is throwing exceptions and complaining about
464         lack of --no-update on build-attachment.  Make it stop.
465
466         * Scripts/modules/buildsteps.py:
467         * Scripts/modules/commands/download.py:
468
469 2009-12-02  Adam Barth  <abarth@webkit.org>
470
471         Unreviewed "build" fix.  Forgot to declare my variables.  :(
472
473         * QueueStatusServer/queue_status.py:
474
475 2009-12-02  Adam Barth  <abarth@webkit.org>
476
477         Reviewed by Eric Seidel.
478
479         [bzt] Implement status bubble view
480         https://bugs.webkit.org/show_bug.cgi?id=32057
481
482         The status bubble is a compact representation of the queue status for a
483         given patch.  This will eventually help us reduce the comment spam from
484         the queues.
485
486         * QueueStatusServer/index.html: Added HTML5 doctype for sanity.
487         * QueueStatusServer/queue_status.py:
488         * QueueStatusServer/status_bubble.html: Added.
489
490 2009-12-02  Eric Seidel  <eric@webkit.org>
491
492         Reviewed by Adam Barth.
493
494         trim commands/*.py includes now that commands are unit tested
495         https://bugs.webkit.org/show_bug.cgi?id=32056
496
497         In the course of ensuring that the unit tests still
498         passed after this change, I had to actually make them
499         pass in the first place.
500
501         * Scripts/modules/bugzilla.py:
502          - Fix _parse_attachment_ids_request_query to return ints instead of strings.
503         * Scripts/modules/commands/download.py: Remove unneeded imports.
504         * Scripts/modules/commands/queries.py: Ditto.
505         * Scripts/modules/commands/queues.py: Ditto.
506         * Scripts/modules/commands/upload.py: Ditto.
507         * Scripts/modules/scm_unittest.py:
508          - Fix to expect the \n after the path since echo adds an \n.
509
510 2009-12-01  Yaar Schnitman  <yaar@chromium.org>
511
512         build-webkit: Remove flex,bison,gperf check for chromium
513         https://bugs.webkit.org/show_bug.cgi?id=32043
514
515         * Scripts/webkitdirs.pm:
516
517 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
518
519         Build fixage for Windows/GTK for DumpRenderTree.
520
521         WAI-ARIA: implement support for ARIA drag and drop
522         https://bugs.webkit.org/show_bug.cgi?id=32007
523
524         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
525         (AccessibilityUIElement::ariaIsGrabbed):
526         (AccessibilityUIElement::ariaDropEffects):
527         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
528         (AccessibilityUIElement::ariaIsGrabbed):
529         (AccessibilityUIElement::ariaDropEffects):
530
531 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
532
533         Reviewed by Darin Adler.
534
535         WAI-ARIA: implement support for ARIA drag and drop
536         https://bugs.webkit.org/show_bug.cgi?id=32007
537
538         * DumpRenderTree/AccessibilityUIElement.cpp:
539         (getARIADropEffectsCallback):
540         (getARIAIsGrabbedCallback):
541         (AccessibilityUIElement::getJSClass):
542         * DumpRenderTree/AccessibilityUIElement.h:
543         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
544         (AccessibilityUIElement::ariaIsGrabbed):
545         (AccessibilityUIElement::ariaDropEffects):
546
547 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
548
549         Not reviewed. GTK DRT try 2.
550
551         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
552         (LayoutTestController::sampleSVGAnimationForElementAtTime):
553
554 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
555
556         Not reviewed. Try to fix gtk DRT build.
557
558         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
559
560 2009-12-01  David Levin  <levin@chromium.org>
561
562         Reviewed by Eric Seidel.
563
564         check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
565         https://bugs.webkit.org/show_bug.cgi?id=32033
566
567         * Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find
568                                         instead of startswith.
569         * Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior.
570
571 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
572
573         Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well.
574
575         * DumpRenderTree/qt/LayoutTestControllerQt.h: Update old function signature.
576
577 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
578
579         Reviewed by Simon Fraser.
580
581         Add SVG animation test framework with 'snapshot' functionality
582         https://bugs.webkit.org/show_bug.cgi?id=31897
583
584         Add new 'sampleSVGAnimationForElementAtTime' DRT method,
585         used by the new SVG animation testing framework, implemented
586         for qt/gtk/win/mac.
587
588         * DumpRenderTree/LayoutTestController.cpp:
589         (sampleSVGAnimationForElementAtTimeCallback):
590         (LayoutTestController::staticFunctions):
591         * DumpRenderTree/LayoutTestController.h:
592         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
593         (LayoutTestController::sampleSVGAnimationForElementAtTime):
594         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
595         (LayoutTestController::sampleSVGAnimationForElementAtTime):
596         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
597         (LayoutTestController::sampleSVGAnimationForElementAtTime):
598         * DumpRenderTree/qt/LayoutTestControllerQt.h:
599         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
600         (LayoutTestController::sampleSVGAnimationForElementAtTime):
601         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
602         (LayoutTestController::sampleSVGAnimationForElementAtTime):
603
604 2009-12-01  Adam Roben  <aroben@apple.com>
605
606         Remove user content before running each test on Windows
607
608         Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows
609
610         Reviewed by Alexey Proskuryakov.
611
612         * DumpRenderTree/win/DumpRenderTree.cpp:
613         (resetWebViewToConsistentStateBeforeTesting): Remove all user content
614         before each test, which matches Mac.
615
616 2009-12-01  Yuzo Fujishima  <yuzo@google.com>
617
618         Reviewed by Alexey Proskuryakov.
619
620         Make pywebsocket log errors to a file
621         https://bugs.webkit.org/show_bug.cgi?id=31604
622
623         * Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory
624         (by passing the path to the server via a recently added -l option).
625
626 2009-12-01  Adam Roben  <aroben@apple.com>
627
628         Fix tests that use the TestNetscapePlugin in Debug_Internal builds
629
630         Reviewed by Ada Chan.
631
632         Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
633         TestNetscapePlugin fail in Debug_Internal builds
634
635         * DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin
636         directory in Debug and Debug_All builds, but not in Debug_Internal
637         builds.
638
639 2009-12-01  Adam Roben  <aroben@apple.com>
640
641         Re-enable DRT's watchdog timer on Windows
642
643         It was accidentally disabled in r50907.
644
645         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
646         (LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
647         into an if condition.
648
649 2009-12-01  Adam Barth  <abarth@webkit.org>
650
651         Reviewed by Eric Seidel.
652
653         check-webkit-style complains about #imports with / in them
654         https://bugs.webkit.org/show_bug.cgi?id=32022
655
656         We need to exclude #import directives in addition to #include from the
657         binary operator whitespace checks.
658
659         * Scripts/modules/cpp_style.py:
660         * Scripts/modules/cpp_style_unittest.py:
661
662 2009-11-30  Adam Barth  <abarth@webkit.org>
663
664         Reviewed by Eric Seidel.
665
666         check-webkit-style is slightly too verbose
667         https://bugs.webkit.org/show_bug.cgi?id=32010
668
669         check-webkit-style prints out a bunch of "done" lines that seem redundant,
670         especially for the style-queue.
671
672         * Scripts/modules/cpp_style.py:
673
674 2009-11-30  Alejandro G. Castro  <alex@igalia.com>
675
676         Reviewed by Eric Seidel.
677
678         [GTK] Moved the functions that are closing the result log of the
679         tests to the last line of the runTest function, this avoids
680         reporting crashes in the wrong test if there is a problem when
681         reseting the state after the test.
682
683         * DumpRenderTree/gtk/DumpRenderTree.cpp:
684         (dump):
685         (runTest):
686
687 2009-11-30  Sam Weinig  <sam@webkit.org>
688
689         Reviewed by Geoffrey Garen.
690
691         Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
692         fast/js/date-proto-generic-invocation breaks another test
693
694         Don't cache JSClassRefs, a change to the prototype chain will
695         last between tests.
696
697         * DumpRenderTree/AccessibilityController.cpp:
698         (AccessibilityController::getJSClass):
699         * DumpRenderTree/GCController.cpp:
700         (GCController::getJSClass):
701         * DumpRenderTree/GCController.h:
702         * DumpRenderTree/LayoutTestController.cpp:
703         (LayoutTestController::getJSClass):
704
705 2009-11-30  Yuzo Fujishima  <yuzo@google.com>
706
707         Reviewed by Alexey Proskuryakov.
708
709         Update pywebsocket to 0.4.2.1.
710         This is to fix a bug that some messages are logged to stderr even when the log file is specified.
711         https://bugs.webkit.org/show_bug.cgi?id=31976
712
713         * pywebsocket/mod_pywebsocket/standalone.py:
714         * pywebsocket/setup.py:
715
716 2009-11-30  Adam Barth  <abarth@webkit.org>
717
718         Reviewed by Eric Seidel.
719
720         [bzt] Generate pass messages for style-queue
721         https://bugs.webkit.org/show_bug.cgi?id=31995
722
723         With this change, the style-queue posts "pass" messages to bugs as
724         well.  Also, added more information to the state store w.r.t. passing
725         and failing.
726
727         * Scripts/modules/commands/queues.py:
728         * Scripts/modules/patchcollection.py:
729
730 2009-11-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
731
732         Reviewed by Simon Fraser.
733
734         Check for WEBKIT_TESTFONTS environment variable in
735         run-webkit-tests, for GTK+, to have a more prominent error
736         message.
737
738         * Scripts/run-webkit-tests:
739
740 2009-11-30  Yaar Schnitman  <yaar@chromium.org>
741
742         Reviewed by Dimitri Glazkov.
743
744         update-webkit --chromium forces gclient sync
745
746         https://bugs.webkit.org/show_bug.cgi?id=31967
747
748         * Scripts/update-webkit-chromium:
749
750 2009-11-29  Eric Seidel  <eric@webkit.org>
751
752         Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.
753
754         * Scripts/modules/committers.py:
755
756 2009-11-29  Eric Seidel  <eric@webkit.org>
757
758         No review, just adding missing svn property.
759
760         Set svn:executable property on new scripts.
761         These were added by commit-queue commits, but the executable
762         property was lost due to a bug in svn-apply:
763         https://bugs.webkit.org/show_bug.cgi?id=27204
764
765         * Scripts/update-webkit-chromium: Added property svn:executable.
766         * Scripts/validate-committer-lists: Added property svn:executable.
767
768 2009-11-29  Eric Seidel  <eric@webkit.org>
769
770         Reviewed by Adam Barth.
771
772         Need a way to validate that committers.py includes all committers/reviewers
773         https://bugs.webkit.org/show_bug.cgi?id=30970
774
775         Add a script which knows how to compare our public committer/reviewer
776         lists and show discrepancies between them.
777
778         Validates mailing lists vs. committers.py:
779         - committers.py committers missing from webkit-committers@lists
780         - webkit-committers@lists members missing from committers.py
781         - committers.py reviewers missing from webkit-reviewers@lists
782         - webkit-reviewers@lists members missing from committers.py
783         - webkit-reviewers@lists members missing from committers.py reviewer list
784
785         Validates committers.py vs. trunk/ SVN history:
786         - committers who have not committed in over a year
787         - SVN committers missing from committers.py
788         - committers.py members who have no record in SVN.
789
790         All of these lists still show "false positives" until a few more committers.py updates are made, like:
791         https://bugs.webkit.org/show_bug.cgi?id=31366
792
793         * Scripts/validate-committer-lists: Added.
794
795 2009-11-28  Adam Barth  <abarth@webkit.org>
796
797         Reviewed by Eric Seidel.
798
799         [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
800         https://bugs.webkit.org/show_bug.cgi?id=31950
801
802         Now we cache the last status that we get back from QueueStatusServer.
803         Eventually we'll have to do something more fancy if we want to support
804         a "try again" button on QueueStatusServer, but we can cross that bridge
805         when we come to it.
806
807         * Scripts/modules/patchcollection.py:
808
809 2009-11-28  Adam Barth  <abarth@webkit.org>
810
811         Reviewed by Eric Seidel.
812
813         StyleQueue scans ~100 bug pages every 5 minutes
814         https://bugs.webkit.org/show_bug.cgi?id=31947
815
816         Instead of getting the pending-review attachment ids by scanning each
817         bug (which results in a network request), we should just get them all
818         from webkit.org/pending-review in one shot.
819
820         * Scripts/modules/bugzilla.py:
821         * Scripts/modules/bugzilla_unittest.py:
822         * Scripts/modules/commands/queries.py:
823         * Scripts/modules/commands/queries_unittest.py:
824         * Scripts/modules/commands/queues.py:
825         * Scripts/modules/mock_bugzillatool.py:
826         * Scripts/modules/patchcollection.py:
827
828 2009-11-28  Adam Barth  <abarth@webkit.org>
829
830         Reviewed by Eric Seidel.
831
832         [bzt] CC webkit-bot-watchers whenever the bots touch bugs
833         https://bugs.webkit.org/show_bug.cgi?id=31952
834
835         The mailing list is open for anyone to subscribe.
836
837         * Scripts/modules/bugzilla.py:
838         * Scripts/modules/commands/queues.py:
839
840 2009-11-28  Adam Barth  <abarth@webkit.org>
841
842         Reviewed by Eric Seidel.
843
844         [bzt] style-queue should report style errors to bugzilla
845         https://bugs.webkit.org/show_bug.cgi?id=31945
846
847         Currently, we're just logging the style errors locally.  With this
848         patch we'll actually log the errors to bugzilla.  Note: I plan to run
849         with the "local-only" logging during development.
850
851         * Scripts/modules/commands/queues.py:
852         * Scripts/modules/scm.py:
853
854 2009-11-28  Adam Barth  <abarth@webkit.org>
855
856         Reviewed by Eric Seidel.
857
858         [bzt] style-queue shouldn't reject patches from the commit-queue
859         https://bugs.webkit.org/show_bug.cgi?id=31944
860
861         Currently the style-queue subprocess gets confused and thinks its the
862         commit-queue.  If the patch has an error, it rejects it from the
863         commit-queue.  Instead, we should have style-queue specific logic.
864         This patch doesn't add that logic, but it gives us a callback we can
865         use to add that logic.
866
867         * Scripts/modules/buildsteps.py:
868         * Scripts/modules/commands/queues.py:
869         * Scripts/modules/landingsequence.py:
870
871 2009-11-27  Adam Barth  <abarth@webkit.org>
872
873         Rubber stamped by Eric Seidel.
874
875         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
876
877         * CommitQueueStatus: Removed.
878         * CommitQueueStatus/app.yaml: Removed.
879         * CommitQueueStatus/filters: Removed.
880         * CommitQueueStatus/filters/__init__.py: Removed.
881         * CommitQueueStatus/filters/webkit_extras.py: Removed.
882         * CommitQueueStatus/index.html: Removed.
883         * CommitQueueStatus/index.yaml: Removed.
884         * CommitQueueStatus/queue_status.py: Removed.
885         * CommitQueueStatus/stylesheets: Removed.
886         * CommitQueueStatus/stylesheets/main.css: Removed.
887         * CommitQueueStatus/update_status.html: Removed.
888         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
889
890 2009-11-27  Adam Barth  <abarth@webkit.org>
891
892         Reviewed by Eric Seidel.
893
894         style-queue should only process each patch once
895         https://bugs.webkit.org/show_bug.cgi?id=31939
896
897         Actually address reviewer comments!
898
899         * Scripts/bugzilla-tool:
900
901 2009-11-27  Adam Barth  <abarth@webkit.org>
902
903         Reviewed by Eric Seidel.
904
905         [bzt] style-queue fails to apply a bunch of patches for no reason
906         https://bugs.webkit.org/show_bug.cgi?id=31942
907
908         By passing --non-interactive to check-style, we convince check-style
909         to pass --force to svn-apply, which lets it apply more patches.
910
911         * Scripts/modules/commands/queues.py:
912
913 2009-11-27  Adam Barth  <abarth@webkit.org>
914
915         Reviewed by Eric Seidel.
916
917         [bzt] Support --status-host in style-queue
918         https://bugs.webkit.org/show_bug.cgi?id=31941
919
920         * Scripts/modules/commands/queues.py:
921         * Scripts/modules/statusbot.py:
922
923 2009-11-27  Adam Barth  <abarth@webkit.org>
924
925         Reviewed by Eric Seidel.
926
927         style-queue should only process each patch once
928         https://bugs.webkit.org/show_bug.cgi?id=31939
929
930         Before processing a patch, the try-queues now ask the web service
931         whether they have already processed the patch.  This is an initial cut
932         of this functionality.  I expect we're make it richer over time.
933
934         * Scripts/bugzilla-tool:
935         * Scripts/modules/commands/queues.py:
936         * Scripts/modules/patchcollection.py:
937
938 2009-11-27  Adam Barth  <abarth@webkit.org>
939
940         Reviewed by Eric Seidel.
941
942         PatchStatus does not return status
943         https://bugs.webkit.org/show_bug.cgi?id=31938
944
945         We need to parse attachment_id as an int.  Otherwise, we can't find
946         anything in the datastore.
947
948         * CommitQueueStatus/queue_status.py:
949
950 2009-11-27  Adam Barth  <abarth@webkit.org>
951
952         Reviewed by Eric Seidel.
953
954         Make commit-queue status not throw an exception where there is not
955         status
956         https://bugs.webkit.org/show_bug.cgi?id=31936
957
958         We need to actually fetch the results of the query to see what's in the
959         datastore.
960
961         * CommitQueueStatus/queue_status.py:
962
963 2009-11-27  Adam Barth  <abarth@webkit.org>
964
965         Reviewed by Eric Seidel.
966
967         [bzt] unit test ApplyPatches and ApplyAttachment
968         https://bugs.webkit.org/show_bug.cgi?id=31935
969
970         * Scripts/modules/commands/download.py:
971         * Scripts/modules/commands/download_unittest.py:
972
973 2009-11-27  Adam Barth  <abarth@webkit.org>
974
975         Reviewed by Eric Seidel.
976
977         [bzt] Unit test download commands
978         https://bugs.webkit.org/show_bug.cgi?id=31923
979
980         Adds download_unittest and fixes a bug found while testing.
981
982         * Scripts/modules/commands/commandtest.py:
983         * Scripts/modules/commands/download.py:
984             Fixed a bug where we'd throw an error because [].append returns
985             None.
986         * Scripts/modules/commands/download_unittest.py: Added.
987         * Scripts/modules/mock_bugzillatool.py:
988         * Scripts/run-webkit-unittests:
989
990 2009-11-27  Adam Barth  <abarth@webkit.org>
991
992         Unreviewed "build" fix found while writing unit tests.
993
994         * Scripts/modules/commands/download.py:
995
996 2009-11-27  Adam Barth  <abarth@webkit.org>
997
998         Reviewed by Eric Seidel.
999
1000         [bzt] Kill WebKitLandingScripts
1001         https://bugs.webkit.org/show_bug.cgi?id=31904
1002
1003         Step 6: Kill the rest.
1004
1005         * Scripts/modules/buildsteps.py:
1006         * Scripts/modules/commands/download.py:
1007         * Scripts/modules/commands/queries.py:
1008         * Scripts/modules/commands/upload.py:
1009         * Scripts/modules/landingsequence.py:
1010         * Scripts/modules/scm.py:
1011         * Scripts/modules/webkitlandingscripts.py: Removed.
1012
1013 2009-11-27  Adam Barth  <abarth@webkit.org>
1014
1015         Reviewed by Eric Seidel.
1016
1017         [bzt] Unit test upload commands
1018         https://bugs.webkit.org/show_bug.cgi?id=31903
1019
1020         Adds unit tests for all but two of the upload commands.  The two
1021         remaining ones are more difficult.  I'll return to them later.  The
1022         goal of these tests is just to run the commands.  We can test more
1023         detailed behavior later.
1024
1025         * Scripts/modules/commands/commandtest.py:
1026         * Scripts/modules/commands/upload.py:
1027         * Scripts/modules/commands/upload_unittest.py:
1028         * Scripts/modules/mock.py: Added.
1029         * Scripts/modules/mock_bugzillatool.py:
1030
1031 2009-11-26  Adam Barth  <abarth@webkit.org>
1032
1033         Reviewed by Eric Seidel.
1034
1035         [bzt] Kill WebKitLandingScripts
1036         https://bugs.webkit.org/show_bug.cgi?id=31904
1037
1038         Step 5: Kill run_and_throw_if_fail.
1039
1040         * Scripts/modules/buildsteps.py:
1041         * Scripts/modules/processutils.py: Added.
1042         * Scripts/modules/webkitlandingscripts.py:
1043
1044 2009-11-26  Adam Barth  <abarth@webkit.org>
1045
1046         Reviewed by Eric Seidel.
1047
1048         [bzt] Kill WebKitLandingScripts
1049         https://bugs.webkit.org/show_bug.cgi?id=31904
1050
1051         Step 4: Kill run_webkit_script.
1052
1053         * Scripts/modules/buildsteps.py:
1054         * Scripts/modules/commands/download.py:
1055         * Scripts/modules/webkitlandingscripts.py:
1056
1057 2009-11-26  Adam Barth  <abarth@webkit.org>
1058
1059         Reviewed by Eric Seidel.
1060
1061         [bzt] Kill WebKitLandingScripts
1062         https://bugs.webkit.org/show_bug.cgi?id=31904
1063
1064         Step 3: Kill build_webkit.
1065
1066         * Scripts/modules/buildsteps.py:
1067         * Scripts/modules/landingsequence.py:
1068         * Scripts/modules/webkitlandingscripts.py:
1069
1070 2009-11-26  Adam Barth  <abarth@webkit.org>
1071
1072         Reviewed by Eric Seidel.
1073
1074         [bzt] Kill WebKitLandingScripts
1075         https://bugs.webkit.org/show_bug.cgi?id=31904
1076
1077         Step 2: Kill ensure_builders_are_green.
1078
1079         * Scripts/modules/buildsteps.py:
1080         * Scripts/modules/commands/download.py:
1081         * Scripts/modules/landingsequence.py:
1082         * Scripts/modules/webkitlandingscripts.py:
1083
1084 2009-11-26  Adam Barth  <abarth@webkit.org>
1085
1086         Reviewed by Eric Seidel.
1087
1088         [bzt] Kill WebKitLandingScripts
1089         https://bugs.webkit.org/show_bug.cgi?id=31904
1090
1091         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
1092
1093         * Scripts/bugzilla-tool:
1094         * Scripts/modules/buildsteps.py: Added.
1095         * Scripts/modules/commands/download.py:
1096         * Scripts/modules/landingsequence.py:
1097         * Scripts/modules/webkitlandingscripts.py:
1098
1099 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
1100
1101         Reviewed by Adam Barth.
1102
1103         Remove directory prefixes from linux commands
1104
1105         SCM unittests can cause errors on some systems if we use absolute reference to
1106         the commands, so directory prefixes have been removed.
1107
1108         * Scripts/modules/scm_unittest.py:
1109
1110 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
1111
1112         Reviewed by Kenneth Rohde Christiansen.
1113
1114         Link DumpRenderTree to the Qt Ui Tools
1115         https://bugs.webkit.org/show_bug.cgi?id=31203
1116
1117         Implement QWebPage::createPlugin using the Qt Ui Tools
1118         to be able to create classes like QProgressBar from within
1119         the <object></object> tags This is required for the
1120         new automatic test of Qt Plugins.
1121
1122         * DumpRenderTree/qt/DumpRenderTree.cpp:
1123         (WebCore::WebPage::createPlugin):
1124         * DumpRenderTree/qt/DumpRenderTree.h:
1125         * DumpRenderTree/qt/DumpRenderTree.pro:
1126
1127 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
1128
1129         Reviewed by Eric Seidel.
1130
1131         Update pywebsocket to 0.4.2
1132
1133         Update pywebsocket to 0.4.2
1134         https://bugs.webkit.org/show_bug.cgi?id=31861
1135
1136         * pywebsocket/example/echo_client.py:
1137         * pywebsocket/example/echo_wsh.py:
1138         * pywebsocket/mod_pywebsocket/__init__.py:
1139         * pywebsocket/mod_pywebsocket/dispatch.py:
1140         * pywebsocket/mod_pywebsocket/msgutil.py:
1141         * pywebsocket/mod_pywebsocket/standalone.py:
1142         * pywebsocket/setup.py:
1143         * pywebsocket/test/test_dispatch.py:
1144         * pywebsocket/test/test_msgutil.py:
1145
1146 2009-11-25  Adam Barth  <abarth@webkit.org>
1147
1148         Reviewed by Eric Seidel.
1149
1150         Add unit test for mark-fixed
1151         https://bugs.webkit.org/show_bug.cgi?id=31896
1152
1153         * Scripts/modules/commands/commandtest.py: Added.
1154         * Scripts/modules/commands/queries_unittest.py:
1155         * Scripts/modules/commands/upload_unittest.py: Added.
1156         * Scripts/modules/mock_bugzillatool.py:
1157         * Scripts/run-webkit-unittests:
1158
1159 2009-11-25  Adam Barth  <abarth@webkit.org>
1160
1161         Reviewed by Eric Seidel.
1162
1163         bugzilla-tool should have a mark-fixed command
1164         https://bugs.webkit.org/show_bug.cgi?id=31853
1165
1166         Pretty simple stuff.
1167
1168         * Scripts/modules/commands/upload.py:
1169
1170 2009-11-25  Eric Seidel  <eric@webkit.org>
1171
1172         Reviewed by Adam Barth.
1173
1174         'bugzilla-tool help' should only show common commands like how 'git help' does
1175         https://bugs.webkit.org/show_bug.cgi?id=31772
1176
1177         I also took this opportunity to make 'help' a real Command.
1178         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
1179
1180         * Scripts/bugzilla-tool:
1181          - change should_show_command_help to should_show_in_main_help
1182         * Scripts/modules/commands/download.py:
1183          - Mark commands as being shown in main help or not.
1184          - show_in_main_help = False is not required (default is false),
1185            but it seemed to make the commands more self-documenting.
1186         * Scripts/modules/commands/queries.py: ditto
1187         * Scripts/modules/commands/queues.py: ditto
1188         * Scripts/modules/commands/upload.py: ditto
1189         * Scripts/modules/multicommandtool.py:
1190          - Make Command hold a pointer to tool in self.tool.  Most Command
1191            subclasses do not take advantage of this yet, but it was required
1192            for HelpCommand to be able to reach the tool from _help_epilog().
1193          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
1194          - Move MultiCommandTool._help_epilog to Command._help_epilog
1195          - Move "help" logic into HelpCommand.execute()
1196          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
1197         * Scripts/modules/multicommandtool_unittest.py:
1198          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
1199
1200 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
1201
1202         Reviewed by Dan Bernstein.
1203         
1204         Patch by Mark Rowe.
1205
1206         The buildbots are failing on Windows because when they were upgraded
1207         to 4.0.4, Apple Application Support was not in their path. Add it to
1208         the path to fix the buildots.
1209
1210         * Scripts/webkitdirs.pm:
1211
1212 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
1213
1214         Reviewed by David Kilzer.
1215
1216         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
1217         https://bugs.webkit.org/show_bug.cgi?id=31799
1218
1219         * Scripts/run-webkit-tests: Fixed.
1220
1221 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
1222
1223         Reviewed by Eric Seidel.
1224
1225         Change run_command to give back stderr by default
1226         https://bugs.webkit.org/show_bug.cgi?id=31734
1227
1228         Change run_command to give back stderr by default.
1229         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
1230         Change the related unittest call.
1231
1232         * Scripts/modules/scm.py:
1233         * Scripts/modules/scm_unittest.py:
1234
1235 2009-11-25  Eric Seidel  <eric@webkit.org>
1236
1237         Reviewed by Adam Barth.
1238
1239         Centralize required argument parsing in Command
1240         https://bugs.webkit.org/show_bug.cgi?id=31872
1241
1242         * Scripts/modules/commands/download.py: remove custom required arg message.
1243         * Scripts/modules/commands/upload.py: ditto.
1244         * Scripts/modules/multicommandtool.py:
1245          - Add _parse_required_arguments.
1246          - Pass program name off to OptionParser.
1247          - Add name() for access to tool name.
1248          - Add check_arguments_and_execute and make it return a return code.
1249          - Replace a couple uses of + with %.
1250         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
1251
1252 2009-11-25  Eric Seidel  <eric@webkit.org>
1253
1254         Reviewed by Adam Barth.
1255
1256         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
1257         https://bugs.webkit.org/show_bug.cgi?id=31870
1258
1259         * Scripts/modules/commands/queries_unittest.py: Use the new class.
1260         * Scripts/modules/multicommandtool_unittest.py: Ditto.
1261         * Scripts/modules/outputcapture.py: Added.
1262
1263 2009-11-24  Dmitry Titov  <dimich@chromium.org>
1264
1265         Reviewed by Eric Seidel.
1266
1267         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
1268         https://bugs.webkit.org/show_bug.cgi?id=31444
1269
1270         * Scripts/build-webkit:
1271
1272 2009-11-24  Chris Marrin  <cmarrin@apple.com>
1273
1274         Reviewed by Simon Fraser.
1275
1276         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
1277         https://bugs.webkit.org/show_bug.cgi?id=27314
1278         
1279         Now the script allows the directories with these tests to be included on all
1280         platforms but Mac, where they behave the same as always. For all other platforms
1281         the tests need to be excluded using the Skipped files, which is currently done
1282         for all platforms (including win since we're not turned on yet)
1283
1284         * Scripts/webkitdirs.pm:
1285
1286 2009-11-24  Eric Seidel  <eric@webkit.org>
1287
1288         Reviewed by Adam Barth.
1289
1290         queries_unittest.py should test command output
1291         https://bugs.webkit.org/show_bug.cgi?id=31845
1292
1293         * Scripts/modules/commands/queries_unittest.py:
1294          - Capture stdout and stderr and compare with expected strings.
1295
1296 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
1297
1298         No Review.
1299
1300         Fix spelling error ("depenedencies").
1301
1302         * Scripts/build-webkit:
1303
1304 2009-11-24  Mark Rowe  <mrowe@apple.com>
1305
1306         Land the configuration that includes the two debug GTK Linux builders.
1307
1308         * BuildSlaveSupport/build.webkit.org-config/config.json:
1309
1310 2009-11-24  David Kilzer  <ddkilzer@apple.com>
1311
1312         <http://webkit.org/b/31840> bisect-builds broke after r50080
1313
1314         Reviewed by Dan Bernstein.
1315
1316         * Scripts/bisect-builds:
1317         (mountAndRunNightly): Switched back to using backticks to run
1318         the hdiutil command since exec() will terminate the existing
1319         script, which is not what we want.  Store the output of
1320         File::Spec->devnull() in a variable for use in the hdiutil
1321         detach commands.
1322
1323 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1324
1325         Reviewed by Kenneth Rohde Christiansen.
1326
1327         Include "config.h" to meet Coding Style Guidelines
1328         https://bugs.webkit.org/show_bug.cgi?id=31792
1329
1330         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
1331         * DumpRenderTree/qt/jsobjects.cpp:
1332         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1333
1334 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1335
1336         Reviewed by Oliver Hunt.
1337
1338         Implement new required function to pass test we used to pass. This
1339         change is required since r51294.
1340
1341         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1342         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1343
1344 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
1345
1346         Reviewed by Kenneth Rohde Christiansen.
1347
1348         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
1349         https://bugs.webkit.org/show_bug.cgi?id=31775
1350
1351         LayoutTestController::dumpBackForwardList() should work with local URLs
1352         as well as with normal URLs (in http tests for instance).
1353         Currently it does not output the latter properly.
1354
1355         Unskip a bunch of passing http/navigation tests.
1356
1357         * DumpRenderTree/qt/DumpRenderTree.cpp:
1358         (WebCore::dumpHistoryItem):
1359
1360 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
1361
1362         Reviewed by Oliver Hunt.
1363
1364         ARIA: support aria-flowto
1365         https://bugs.webkit.org/show_bug.cgi?id=31762
1366
1367         * DumpRenderTree/AccessibilityUIElement.cpp:
1368         (ariaFlowToElementAtIndexCallback):
1369         (AccessibilityUIElement::getJSClass):
1370         * DumpRenderTree/AccessibilityUIElement.h:
1371         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1372         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1373         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1374         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1375         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1376         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1377
1378 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
1379
1380         Reviewed by Kenneth Christiansen.
1381
1382         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
1383         https://bugs.webkit.org/show_bug.cgi?id=31638
1384
1385         Unfreeze WorkQueue after each test execution.
1386
1387         * DumpRenderTree/qt/DumpRenderTree.cpp:
1388         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1389
1390 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
1391
1392         Reviewed by Adam Barth.
1393
1394         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
1395         for localhost and 127.0.0.1.
1396         https://bugs.webkit.org/show_bug.cgi?id=31783
1397
1398         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
1399
1400         * DumpRenderTree/qt/DumpRenderTree.cpp:
1401         (WebCore::NetworkAccessManager::NetworkAccessManager):
1402         (WebCore::NetworkAccessManager::sslErrorsEncountered):
1403         (WebCore::WebPage::WebPage):
1404         * DumpRenderTree/qt/DumpRenderTree.h:
1405
1406 2009-11-22  Chris Evans  <cevans@chromium.org>
1407
1408         Reviewed by Adam Barth.
1409
1410         Disable access to file:/// directory listings
1411         https://bugs.webkit.org/show_bug.cgi?id=31329
1412
1413         Implemented setAllowUniversalAccessFromFileURLs to support testing of
1414         file URL security.
1415
1416         * DumpRenderTree/LayoutTestController.cpp:
1417         (setAllowUniversalAccessFromFileURLsCallback):
1418         (LayoutTestController::staticFunctions):
1419         * DumpRenderTree/LayoutTestController.h:
1420         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1421         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1422         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1423         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1424         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1425         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1426         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1427         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1428
1429 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
1430
1431         Reviewed by Kenneth Rohde Christiansen.
1432
1433         [Qt] Fix the timeout of fast/frames/frame-navigation.html
1434         https://bugs.webkit.org/show_bug.cgi?id=31638
1435
1436         The test is timeouting, because it uses the WorkQueue to load a document in one
1437         of the child frames and once the loading is finished, the DRT does not dump the
1438         tree. This is because it waits for the QWebFrame::loadFinished() signal from
1439         the main frame, while it should connect to QWebPage::loadFinished().
1440
1441         * DumpRenderTree/qt/DumpRenderTree.cpp:
1442         (WebCore::DumpRenderTree::DumpRenderTree):
1443
1444 2009-11-21  Eric Seidel  <eric@webkit.org>
1445
1446         Reviewed by Adam Barth.
1447
1448         bugzilla-tool --help spews way too much text
1449         https://bugs.webkit.org/show_bug.cgi?id=31771
1450
1451         * Scripts/bugzilla-tool:
1452          - Remove self.cached_scm initialization hack.
1453         * Scripts/modules/buildbot.py:
1454          - Make default_host accessible to callers.
1455         * Scripts/modules/commands/download.py:
1456          - Phrase help for all commands consistently and remove spurious help text punctuation.
1457         * Scripts/modules/commands/queries.py: Ditto.
1458         * Scripts/modules/commands/queues.py: Ditto.
1459         * Scripts/modules/commands/upload.py: Ditto.
1460         * Scripts/modules/multicommandtool.py:
1461          - Add HelpPrintingOptionParser.format_epilog to replace
1462            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
1463            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
1464          - Make --help only show a list of commands like "svn help" and "git help" do --
1465            previously --help was listing all commands and options.
1466          - Sort list of commands alphabetically.
1467
1468 2009-11-21  Eric Seidel  <eric@webkit.org>
1469
1470         No review.  Fixing a typo from the previous patch for bug 31767.
1471
1472         AbstractQueue.run_bugzilla_tool throws an exception
1473         https://bugs.webkit.org/show_bug.cgi?id=31769
1474
1475         * Scripts/modules/commands/queues.py:
1476
1477 2009-11-21  Eric Seidel  <eric@webkit.org>
1478
1479         Reviewed by Adam Barth.
1480
1481         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
1482         https://bugs.webkit.org/show_bug.cgi?id=31767
1483
1484         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
1485         Since we don't have a good way to test BugzillaTool pieces, I've
1486         left out a test for now.
1487
1488         * Scripts/bugzilla-tool:
1489          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
1490         * Scripts/modules/commands/queues.py:
1491          - Use tool.path() instead of __file__.
1492         * Scripts/modules/multicommandtool.py:
1493          - Add a new path() method to MultiComandTool.
1494         * Scripts/modules/multicommandtool_unittest.py:
1495          - Provide a path() method.  Little point in testing this mock implementation.
1496
1497 2009-11-21  Adam Barth  <abarth@webkit.org>
1498
1499         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
1500         WebKitTools.
1501
1502         * Scripts/modules/commands/download.py:
1503
1504 2009-11-21  Adam Barth  <abarth@webkit.org>
1505
1506         Reviewed by Eric Seidel.
1507
1508         Convert check-style to use LandingSequence
1509         https://bugs.webkit.org/show_bug.cgi?id=31763
1510
1511         Instead of manipulating the working copy by hand, we should use the
1512         LandingSequence in CheckStyle.  This will make this code eaiser to
1513         test.
1514
1515         * Scripts/modules/commands/download.py:
1516
1517 2009-11-20  Adam Barth  <abarth@webkit.org>
1518
1519         Reviewed by Eric Seidel.
1520
1521         Unit test query commands
1522         https://bugs.webkit.org/show_bug.cgi?id=31755
1523
1524         These tests are pretty rough, but hopefully they'll grow.
1525
1526         * Scripts/modules/commands/queries_unittest.py: Added.
1527         * Scripts/modules/mock_bugzillatool.py: Added.
1528         * Scripts/run-webkit-unittests:
1529
1530 2009-11-20  Eric Seidel  <eric@webkit.org>
1531
1532         Reviewed by Adam Barth.
1533
1534         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
1535         https://bugs.webkit.org/show_bug.cgi?id=31758
1536
1537         * Scripts/modules/multicommandtool.py:
1538          - Allow passing of explicit commands to MultiCommandTool.__init__
1539         * Scripts/modules/multicommandtool_unittest.py:
1540          - Use new Command.name naming system.
1541          - Test Command auto-discovery.
1542         * Scripts/modules/workqueue.py:
1543          - bug_id no longer exists, use patch['bug_id'] instead.
1544         * Scripts/modules/workqueue_unittest.py:
1545          - WorkQueues require names now.
1546          - should_proceed_with_work_item must return a patch object.
1547
1548 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
1549
1550         Reviewed by Beth Dakin.
1551
1552         WAI-ARIA: add support for aria-owns
1553         https://bugs.webkit.org/show_bug.cgi?id=31702
1554
1555         * DumpRenderTree/AccessibilityUIElement.cpp:
1556         (ariaOwnsElementAtIndexCallback):
1557         (AccessibilityUIElement::getJSClass):
1558         * DumpRenderTree/AccessibilityUIElement.h:
1559         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1560         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1561         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1562         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1563         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1564         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1565
1566 2009-11-20  Eric Seidel  <eric@webkit.org>
1567
1568         Reviewed by Adam Barth.
1569
1570         Fix exception thrown when running the commit-queue.
1571
1572         * Scripts/modules/statusbot.py: patch is optional.
1573         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
1574
1575 2009-11-20  Eric Seidel  <eric@webkit.org>
1576
1577         Reviewed by Adam Barth.
1578
1579         Teach the StatusBot how to support more than just the commit-queue
1580         https://bugs.webkit.org/show_bug.cgi?id=31754
1581
1582         * Scripts/modules/workqueue.py: Another typo.
1583
1584 2009-11-20  Eric Seidel  <eric@webkit.org>
1585
1586         Reviewed by Adam Barth.
1587
1588         Teach the StatusBot how to support more than just the commit-queue
1589         https://bugs.webkit.org/show_bug.cgi?id=31754
1590
1591         * Scripts/modules/commands/queues.py: Fix silly typo.
1592
1593 2009-11-20  Eric Seidel  <eric@webkit.org>
1594
1595         Reviewed by Adam Barth.
1596
1597         Teach the StatusBot how to support more than just the commit-queue
1598         https://bugs.webkit.org/show_bug.cgi?id=31754
1599
1600         * CommitQueueStatus/index.yaml:
1601          - Add indices required for the new queries.
1602         * CommitQueueStatus/queue_status.py:
1603          - Add a patch-status page and move update_status to update-status.
1604          - Only display "commit-queue" status records for the commit-queue.
1605          - Add support for a queue_name property on status records.
1606          - Fix _int_from_request to actually work.
1607         * CommitQueueStatus/update_status.html:
1608          - Add support for a queue_name on status records.
1609          - Remove unused list of bug ids.
1610          * Scripts/modules/commands/queues.py
1611           - Make the queues pass the patch instead of the bug_id to StatusBot.
1612         * Scripts/modules/statusbot.py:
1613          - Support passing the queue_name to the status updates.
1614          - Support fetching patch status with patch_status().
1615         * Scripts/modules/workqueue.py:
1616          - Pass the patch to the StatusBot instead of the bug_id.
1617          - Let WorkQueues have a name.
1618
1619 2009-11-20  Adam Barth  <abarth@webkit.org>
1620
1621         Reviewed by Eric Seidel.
1622
1623         Move bugzilla-tool commands into their own file
1624         https://bugs.webkit.org/show_bug.cgi?id=31752
1625
1626         This will let us write unit tests.
1627
1628         * Scripts/bugzilla-tool:
1629         * Scripts/modules/commands/__init__.py: Added.
1630         * Scripts/modules/commands/download.py: Added.
1631         * Scripts/modules/commands/queries.py: Added.
1632         * Scripts/modules/commands/queues.py: Added.
1633         * Scripts/modules/commands/upload.py: Added.
1634         * Scripts/modules/grammar.py: Added.
1635
1636 2009-11-20  Adam Barth  <abarth@webkit.org>
1637
1638         Reviewed by Eric Seidel.
1639
1640         BuildQueue should check if the tree is currently buildable
1641         https://bugs.webkit.org/show_bug.cgi?id=31744
1642
1643         * Scripts/bugzilla-tool:
1644         * Scripts/modules/landingsequence.py:
1645         * Scripts/modules/webkitlandingscripts.py:
1646
1647 2009-11-20  Adam Barth  <abarth@webkit.org>
1648
1649         Reviewed by Eric Seidel.
1650
1651         Move prepare_clean_working_directory into the LandingSequence
1652         https://bugs.webkit.org/show_bug.cgi?id=31743
1653
1654         * Scripts/bugzilla-tool:
1655         * Scripts/modules/landingsequence.py:
1656
1657 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
1658
1659         Reviewed by Kenneth Rohde Christiansen.
1660
1661         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
1662         https://bugs.webkit.org/show_bug.cgi?id=30460
1663
1664         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
1665
1666         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1667         (pluginInvoke):
1668
1669 2009-11-20  Adam Barth  <abarth@webkit.org>
1670
1671         Reviewed by Eric Seidel.
1672
1673         Pass the port information to the child process
1674         https://bugs.webkit.org/show_bug.cgi?id=31736
1675
1676         We need to do this so the child process knows what to build!
1677
1678         * Scripts/bugzilla-tool:
1679         * Scripts/modules/landingsequence.py:
1680         * Scripts/modules/webkitport.py:
1681         * Scripts/modules/webkitport_unittest.py:
1682
1683 2009-11-20  Adam Barth  <abarth@webkit.org>
1684
1685         Reviewed by Eric Seidel.
1686
1687         Support Qt port in build-queue
1688         https://bugs.webkit.org/show_bug.cgi?id=31733
1689
1690         * Scripts/bugzilla-tool:
1691
1692 2009-11-20  Adam Barth  <abarth@webkit.org>
1693
1694         Reviewed by Eric Seidel.
1695
1696         Implement a build-queue
1697         https://bugs.webkit.org/show_bug.cgi?id=31725
1698
1699         Currently this just builds the first 10 patches in the review queue.
1700         We'll want to do something smarter soon.
1701
1702         * Scripts/bugzilla-tool:
1703
1704 2009-11-20  Adam Barth  <abarth@webkit.org>
1705
1706         Reviewed by Eric Seidel.
1707
1708         Make commit-queue and style-queue show up in help
1709         https://bugs.webkit.org/show_bug.cgi?id=31724
1710
1711         We need to store their names on their class to make these commands
1712         properly register themselves with MultiCommandTool.
1713
1714         * Scripts/bugzilla-tool:
1715
1716 2009-11-20  Adam Barth  <abarth@webkit.org>
1717
1718         Reviewed by Eric Seidel.
1719
1720         Implement bugzilla-tool build-attachment
1721         https://bugs.webkit.org/show_bug.cgi?id=31722
1722
1723         This command builds an attachment from bugzilla.  It leaves the built
1724         patch in the working copy.
1725
1726         * Scripts/bugzilla-tool:
1727         * Scripts/modules/landingsequence.py:
1728         * Scripts/modules/webkitlandingscripts.py:
1729
1730 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
1731
1732         Reviewed by Xan Lopez.
1733
1734         [GTK] DRT release event does not create the state correctly
1735         https://bugs.webkit.org/show_bug.cgi?id=31717
1736
1737         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1738
1739 2009-11-20  Eric Seidel  <eric@webkit.org>
1740
1741         Reviewed by Adam Barth.
1742
1743         MultiCommandTool should find Command objects automatically instead of with a manual list
1744         https://bugs.webkit.org/show_bug.cgi?id=31710
1745
1746         * Scripts/bugzilla-tool:
1747         * Scripts/modules/multicommandtool.py:
1748          - Use some wild python-fu to crawl all the known subclasses of Command.
1749
1750 2009-11-20  Adam Barth  <abarth@webkit.org>
1751
1752         Unreviewed "build" fix.  Added missing import.
1753
1754         * Scripts/bugzilla-tool:
1755
1756 2009-11-20  Adam Barth  <abarth@webkit.org>
1757
1758         Unreviewed "build" fix.  I failed to update LandingSequence.test
1759         properly.
1760
1761         * Scripts/modules/landingsequence.py:
1762
1763 2009-11-20  Adam Barth  <abarth@webkit.org>
1764
1765         Reviewed by Eric Seidel.
1766
1767         Create LandingSequence as the all-sing, all-dance landing class
1768         https://bugs.webkit.org/show_bug.cgi?id=31709
1769
1770         Client can inherit from this class to carefully control exactly which
1771         steps they wish to have happen in the landing sequence.
1772
1773         * Scripts/bugzilla-tool:
1774         * Scripts/modules/landingsequence.py: Added.
1775         * Scripts/modules/webkitlandingscripts.py: Added.
1776
1777 2009-11-19  Adam Barth  <abarth@webkit.org>
1778
1779         Reviewed by Eric Seidel.
1780
1781         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
1782         https://bugs.webkit.org/show_bug.cgi?id=31707
1783
1784         This is to help when we implement build-attachment.
1785
1786         * Scripts/bugzilla-tool:
1787
1788 2009-11-19  Adam Barth  <abarth@webkit.org>
1789
1790         Reviewed by Eric Seidel.
1791
1792         Support Qt port in bugzilla-tool
1793         https://bugs.webkit.org/show_bug.cgi?id=31701
1794
1795         Now we support building with Qt!
1796
1797         * Scripts/bugzilla-tool:
1798         * Scripts/modules/webkitport.py: Added.
1799         * Scripts/modules/webkitport_unittest.py: Added.
1800         * Scripts/run-webkit-unittests:
1801
1802 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
1803
1804         Reviewed by Adam Barth.
1805
1806         Remove inserting stderr into patch in bugzilla-tool
1807         https://bugs.webkit.org/show_bug.cgi?id=29914
1808
1809         Modify SCM python module's run_command function to avoid return of stderr
1810         by default, so stderr won't be inserted into the patches.
1811         Modify the related unit test.
1812
1813         * Scripts/modules/scm.py:
1814         * Scripts/modules/scm_unittest.py:
1815
1816 2009-11-19  Eric Seidel  <eric@webkit.org>
1817
1818         Reviewed by Adam Barth.
1819
1820         bugzilla-tool needs per-command help
1821         https://bugs.webkit.org/show_bug.cgi?id=31697
1822
1823         Added support for "bugzilla-tool help command-name"
1824         and a unit test to make sure it works.
1825
1826         * Scripts/modules/multicommandtool.py:
1827         * Scripts/modules/multicommandtool_unittest.py:
1828
1829 2009-11-19  Eric Seidel  <eric@webkit.org>
1830
1831         Reviewed by Adam Barth.
1832
1833         Move MultiCommandTool and Command into a separate file and add some basic unit tests
1834         https://bugs.webkit.org/show_bug.cgi?id=31695
1835
1836         * Scripts/bugzilla-tool:
1837         * Scripts/modules/multicommandtool.py: Added.
1838         * Scripts/modules/multicommandtool_unittest.py: Added.
1839         * Scripts/run-webkit-unittests:
1840
1841 2009-11-19  Eric Seidel  <eric@webkit.org>
1842
1843         No review, just adding a FIXME.
1844
1845         Split out command parsing and help printing from BugzillaTool
1846         https://bugs.webkit.org/show_bug.cgi?id=31688
1847
1848         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
1849
1850 2009-11-19  Eric Seidel  <eric@webkit.org>
1851
1852         Reviewed by Adam Barth.
1853
1854         Split out command parsing and help printing from BugzillaTool
1855         https://bugs.webkit.org/show_bug.cgi?id=31688
1856
1857         * Scripts/bugzilla-tool:
1858          - Add new MultiCommandTool class to contain option parsing and help printing logic.
1859          - Rename private methods to use _ pattern.
1860          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
1861          - 
1862
1863 2009-11-19  Eric Seidel  <eric@webkit.org>
1864
1865         Reviewed by Adam Barth.
1866
1867         Re-factor help printing to use modern python idioms
1868         https://bugs.webkit.org/show_bug.cgi?id=31685
1869
1870         * Scripts/bugzilla-tool:
1871
1872 2009-11-19  Eric Seidel  <eric@webkit.org>
1873
1874         Reviewed by Darin Adler.
1875
1876         commit-queue empty queue logs twice
1877         https://bugs.webkit.org/show_bug.cgi?id=31679
1878
1879         * Scripts/bugzilla-tool:
1880
1881 2009-11-19  Eric Seidel  <eric@webkit.org>
1882
1883         Reviewed by Darin Adler.
1884
1885         bugzilla-tool's reviewer/committer rejection message should be clearer
1886         https://bugs.webkit.org/show_bug.cgi?id=31126
1887
1888         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
1889
1890         * Scripts/modules/bugzilla.py:
1891
1892 2009-11-19  Eric Z. Ayers  <zundel@google.com>
1893
1894         Reviewed by Pavel Feldman.
1895
1896         Forces a WM_PAINT event on calling layoutTestController.display()
1897         in order to enable the timeline-paint.html test on Windows.
1898         ::UpdateWindow() does not force an event becaue the window is 
1899         not visible.
1900
1901         https://bugs.webkit.org/show_bug.cgi?id=31402
1902
1903         * DumpRenderTree/win/DumpRenderTree.cpp:
1904         (displayWebView):
1905
1906 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
1907
1908         No review needed.
1909
1910         Added myself to committers list.
1911
1912         * Scripts/modules/committers.py:
1913
1914 2009-11-19  Adam Barth  <abarth@webkit.org>
1915
1916         Reviewed by Eric Seidel.
1917
1918         Bugzilla-tool command classes should match command names
1919         https://bugs.webkit.org/show_bug.cgi?id=31666
1920
1921         I renamed all the commands except CommitMessageForCurrentDiff because
1922         the new name would conflict with an existing class.
1923
1924         * Scripts/bugzilla-tool:
1925
1926 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
1927
1928         Reviewed by Gustavo Noronha Silva.
1929
1930         Web Inspector: Implement "show inspector" in WebKit GTK
1931         API and enable console tests.
1932
1933         https://bugs.webkit.org/show_bug.cgi?id=31669
1934
1935         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1936         (LayoutTestController::showWebInspector):
1937
1938 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1939
1940         Reviewed by Simon Hausmann.
1941
1942         Minor refactoring + more documentation.
1943
1944         * DumpRenderTree/qt/DumpRenderTree.cpp:
1945         (WebCore::clearHistory):
1946         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1947
1948 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
1949
1950         Reviewed by Eric Seidel.
1951
1952         Ignore websocket tests when --no-http is specified.
1953         https://bugs.webkit.org/show_bug.cgi?id=31662
1954
1955         * Scripts/run-webkit-tests:
1956
1957 2009-11-18  Adam Barth  <abarth@webkit.org>
1958
1959         Reviewed by Eric Seidel.
1960
1961         Normalize ' and " in bugzilla-tool
1962         https://bugs.webkit.org/show_bug.cgi?id=31655
1963
1964         We decided " is better than ' and we should be consistent.
1965
1966         * Scripts/bugzilla-tool:
1967
1968 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1969
1970         Reviewed by Kenneth Rohde Christiansen.
1971
1972         [Qt] Remove support for Qt v4.3 or older versions
1973         https://bugs.webkit.org/show_bug.cgi?id=29469
1974
1975         * DumpRenderTree/qt/DumpRenderTree.pro:
1976         * DumpRenderTree/qt/ImageDiff.pro:
1977
1978 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1979
1980         Reviewed by Eric Seidel.
1981
1982         GitTest.test_create_binary_patch fails if /tmp is symlink
1983         https://bugs.webkit.org/show_bug.cgi?id=31536
1984
1985         * Scripts/modules/scm_unittest.py:
1986
1987 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
1988
1989         Reviewed by Darin Adler.
1990
1991         Configuration for Chromium Build Slaves.
1992
1993         https://bugs.webkit.org/show_bug.cgi?id=31442
1994
1995         * BuildSlaveSupport/build.webkit.org-config/config.json:
1996         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1997
1998 2009-11-18  Eric Seidel  <eric@webkit.org>
1999
2000         Reviewed by Darin Adler.
2001
2002         workqueue.py results in totally broken commit-queue UI
2003         https://bugs.webkit.org/show_bug.cgi?id=31645
2004
2005         * Scripts/bugzilla-tool:
2006          - Remove unneeded use of PatchCollection.
2007          - Grab a new copy of the cq'd patches every run of the queue.
2008
2009 2009-11-18  Sam Weinig  <sam@webkit.org>
2010
2011         Reviewed by Anders Carlsson.
2012
2013         Make the Mac Geolocation API async.
2014
2015         Update DRT to use the new async Mac Geolocation API.
2016
2017         * DumpRenderTree/mac/UIDelegate.mm:
2018         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
2019
2020 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2021
2022         Reviewed by Kenneth Rohde Christiansen.
2023
2024         Add and option to toggle HTML5 datalist support to build-webkit
2025         https://bugs.webkit.org/show_bug.cgi?id=31599
2026
2027         * Scripts/build-webkit:
2028
2029 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
2030
2031         Reviewed by Kevin Ollivier.
2032
2033         Enable wx plugin support using the Windows implementation as a base.
2034         
2035         https://bugs.webkit.org/show_bug.cgi?id=31636
2036
2037         * wx/build/settings.py:
2038
2039 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2040
2041         Reviewed by Simon Hausmann.
2042
2043         Change the initialization order so that the controllers
2044         will be created before exporting them to the JS DOM window.
2045
2046         * DumpRenderTree/qt/DumpRenderTree.cpp:
2047         (WebCore::DumpRenderTree::DumpRenderTree):
2048
2049 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2050
2051         Reviewed by Simon Hausmann.
2052
2053         Fix a code copy and paste error. m_page should be page.
2054
2055         * DumpRenderTree/qt/DumpRenderTree.cpp:
2056         (WebCore::DumpRenderTree::createWindow):
2057
2058 2009-11-17  Mark Rowe  <mrowe@apple.com>
2059
2060         Reviewed by Alexey Proskuryakov.
2061
2062         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
2063
2064         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
2065         This prevents symlinks from confusing the descendant check.
2066
2067 2009-11-17  Mark Rowe  <mrowe@apple.com>
2068
2069         Reviewed by Alexey Proskuryakov.
2070
2071         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
2072
2073         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
2074         server to be up rather than having run-webkit-tests abort immediately.
2075
2076         * Scripts/run-webkit-tests:
2077
2078 2009-11-17  Eric Seidel  <eric@webkit.org>
2079
2080         Reviewed by Darin Adler.
2081
2082         commit-queue is failing to set reviewer in ChangeLogs
2083         https://bugs.webkit.org/show_bug.cgi?id=31592
2084
2085         * Scripts/bugzilla-tool: Clarify the "applying" log message.
2086         * Scripts/modules/bugzilla.py:
2087          - Add a new _validate_committer_and_reviewer function as a
2088            temporary solution until we can make a real Attachment object
2089            which knows how to fill in its committer/reviewer fields automatically.
2090
2091 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2092
2093         Unreviewed buildbot fix.
2094
2095         Revert part of earlier patch and add comment, as it
2096         was causing timeouts on the buildbot.
2097
2098         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2099         (LayoutTestController::notifyDone):
2100
2101 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2102
2103         Reviewed by Oliver Hunt.
2104
2105         Make the timeout 15 sec as for the other DRT's and make
2106         it print out the same output when a test timeout.
2107
2108         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2109         (LayoutTestController::waitUntilDone):
2110         (LayoutTestController::notifyDone):
2111         (LayoutTestController::timerEvent):
2112
2113 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
2114
2115         Reviewed by Timothy Hatcher.
2116
2117         Fixed typos in comments.
2118
2119         * Scripts/modules/committers.py:
2120
2121 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
2122
2123         Reviewed by Timothy Hatcher.
2124
2125         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
2126         - Updated DRT to show/close inspector for all tests under /inspector
2127         - Introduced LayoutTestController::setTimelineProfilingEnabled and
2128           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
2129         - Removed reload on each inspector test
2130         - Renamed fast/inspector to fast/inspector-support in order not to trigger
2131         inspector for those.
2132         - Reimplemented timeline tests in order to get rid of reload there.
2133         - Moved tests that don't require harness into the fast group.
2134
2135         https://bugs.webkit.org/show_bug.cgi?id=31472
2136
2137         * DumpRenderTree/LayoutTestController.cpp:
2138         (setTimelineProfilingEnabledCallback):
2139         (closeWebInspectorCallback):
2140         (LayoutTestController::staticFunctions):
2141         * DumpRenderTree/LayoutTestController.h:
2142         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2143         (shouldOpenWebInspector):
2144         (runTest):
2145         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2146         (LayoutTestController::setTimelineProfilingEnabled):
2147         * DumpRenderTree/mac/DumpRenderTree.mm:
2148         (shouldOpenWebInspector):
2149         (runTest):
2150         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2151         (LayoutTestController::setTimelineProfilingEnabled):
2152         * DumpRenderTree/win/DumpRenderTree.cpp:
2153         (shouldOpenWebInspector):
2154         (runTest):
2155         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2156         (LayoutTestController::setTimelineProfilingEnabled):
2157
2158 2009-11-17  Oliver Hunt  <oliver@apple.com>
2159
2160         Reviewed by Maciej Stachowiak.
2161
2162         Incorrect use of JavaScriptCore API in DumpRenderTree
2163         https://bugs.webkit.org/show_bug.cgi?id=31577
2164
2165         Return undefined rather than a literal null.
2166
2167         * DumpRenderTree/AccessibilityUIElement.cpp:
2168         (setSelectedTextRangeCallback):
2169         (incrementCallback):
2170         (decrementCallback):
2171         (showMenuCallback):
2172
2173 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
2174
2175         Reviewed by Beth Dakin.
2176
2177         AX: aria-labelledby duplicates some of its WAI-ARIA label
2178         https://bugs.webkit.org/show_bug.cgi?id=31565
2179
2180         * DumpRenderTree/AccessibilityUIElement.cpp:
2181         (titleUIElementCallback):
2182         (getIsValidCallback):
2183         (AccessibilityUIElement::getJSClass):
2184
2185 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2186
2187         Reviewed by Simon Hausmann.
2188
2189         r50942 broke output from created windows. Make the
2190         m_enableTextOutput a member of the DRT and not the
2191         WebPage.
2192
2193         * DumpRenderTree/qt/DumpRenderTree.cpp:
2194         (WebCore::WebPage::WebPage):
2195         (WebCore::WebPage::javaScriptAlert):
2196         (WebCore::WebPage::javaScriptConsoleMessage):
2197         (WebCore::WebPage::javaScriptConfirm):
2198         (WebCore::WebPage::javaScriptPrompt):
2199         (WebCore::WebPage::acceptNavigationRequest):
2200         (WebCore::DumpRenderTree::DumpRenderTree):
2201         (WebCore::DumpRenderTree::open):
2202         (WebCore::DumpRenderTree::createWindow):
2203         * DumpRenderTree/qt/DumpRenderTree.h:
2204         (WebCore::DumpRenderTree::setTextOutputEnabled):
2205         (WebCore::DumpRenderTree::isTextOutputEnabled):
2206         (WebCore::WebPage::shouldInterruptJavaScript):
2207         (WebCore::WebPage::isTextOutputEnabled):
2208         (WebCore::WebPage::setViewGeometry):
2209
2210 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2211
2212         Reviewed by Gustavo Noronha Silva.
2213
2214         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
2215         as the implementation is being used by at least Qt and Gtk+.
2216
2217         Update buildsystems as well.
2218
2219         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2220         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
2221         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
2222         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
2223         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2224         * GNUmakefile.am:
2225
2226 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
2227
2228         Reviewed by Alexey Proskuryakov.
2229
2230         Disable wss until all platforms support pyOpenSSL
2231
2232         https://bugs.webkit.org/show_bug.cgi?id=31479
2233
2234         * Scripts/run-webkit-tests:
2235
2236 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
2237
2238         Reviewed by Kenneth Christiansen.
2239
2240         [Qt] Implement load error pages support for Qt's DRT.
2241         https://bugs.webkit.org/show_bug.cgi?id=31509
2242
2243         For now, it will not be a default feature, and layout tests
2244         that want to make use of this have to explicitily call
2245         'handleErrorPages();' for the test source.
2246
2247         Any of the other DumpRenderTree's (mac, win and gtk)
2248         support handling error pages. Qt's will be the first.
2249
2250         * DumpRenderTree/qt/DumpRenderTree.cpp:
2251         (WebCore::WebPage::supportsExtension):
2252         (WebCore::WebPage::extension):
2253         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2254         (LayoutTestController::reset):
2255         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2256         (LayoutTestController::shouldHandleErrorPages):
2257         (LayoutTestController::handleErrorPages):
2258
2259 2009-11-16  Eric Seidel  <eric@webkit.org>
2260
2261         Reviewed by Adam Barth.
2262
2263         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
2264         https://bugs.webkit.org/show_bug.cgi?id=31549
2265
2266         Renamed --commit-queue to --non-interactive in most places
2267         and remove the code in land-patches which is no longer needed.
2268
2269         * Scripts/bugzilla-tool:
2270
2271 2009-11-16  Eric Seidel  <eric@webkit.org>
2272
2273         Reviewed by Adam Barth.
2274
2275         The commit-queue should use land-attachment
2276         https://bugs.webkit.org/show_bug.cgi?id=31548
2277
2278         * Scripts/bugzilla-tool:
2279
2280 2009-11-16  Adam Barth  <abarth@webkit.org>
2281
2282         Reviewed by Eric Seidel.
2283
2284         Convert CommitQueue over to PatchCollection
2285         https://bugs.webkit.org/show_bug.cgi?id=31547
2286
2287         Also fixes a bug in workqueue and adds a test!
2288
2289         * Scripts/bugzilla-tool:
2290         * Scripts/modules/workqueue.py:
2291         * Scripts/modules/workqueue_unittest.py:
2292
2293 2009-11-16  Adam Barth  <abarth@webkit.org>
2294
2295         Reviewed by Eric Seidel.
2296
2297         Move StyleQueue over to using PatchCollection
2298         https://bugs.webkit.org/show_bug.cgi?id=31544
2299
2300         That's what the class it's for.
2301
2302         * Scripts/bugzilla-tool:
2303         * Scripts/modules/patchcollection.py:
2304         * Scripts/modules/patchcollection_unittest.py:
2305
2306 2009-11-16  Eric Seidel  <eric@webkit.org>
2307
2308         Reviewed by Adam Barth.
2309
2310         bugzilla-tool needs a land-attachment command
2311         https://bugs.webkit.org/show_bug.cgi?id=31546
2312
2313         * Scripts/bugzilla-tool:
2314          - Move all the logic into AbstractLandingCommand and
2315            add a new LandAttachment command subclass.
2316          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
2317
2318 2009-11-16  Eric Seidel  <eric@webkit.org>
2319
2320         Reviewed by Adam Barth.
2321
2322         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
2323         https://bugs.webkit.org/show_bug.cgi?id=31543
2324
2325         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
2326
2327         * Scripts/bugzilla-tool:
2328
2329 2009-11-16  Eric Seidel  <eric@webkit.org>
2330
2331         Reviewed by Adam Barth.
2332
2333         Disable the style queue from posting to the commit queue status page.
2334
2335         * Scripts/bugzilla-tool:
2336
2337 2009-11-16  Adam Barth  <abarth@webkit.org>
2338
2339         Reviewed by Eric Seidel.
2340
2341         Implement PatchCollection
2342         https://bugs.webkit.org/show_bug.cgi?id=31541
2343
2344         This class holds a set of patches and lets clients iterate through
2345         them.  Optionally, clients can install a filter.
2346
2347         * Scripts/modules/patchcollection.py: Added.
2348         * Scripts/modules/patchcollection_unittest.py: Added.
2349         * Scripts/run-webkit-unittests:
2350
2351 2009-11-16  Eric Seidel  <eric@webkit.org>
2352
2353         Reviewed by Adam Barth.
2354
2355         bugzilla-tool land-patches will close bugs with patches r=?
2356         https://bugs.webkit.org/show_bug.cgi?id=28230
2357
2358         The commit-queue shouldn't close patches with outstanding reviews on them,
2359         even if many reviewers seem to be against multi-patch bugs.
2360
2361         * Scripts/bugzilla-tool:
2362
2363 2009-11-16  Eric Seidel  <eric@webkit.org>
2364
2365         Reviewed by Adam Barth.
2366
2367         bugzilla-tool check-style should work with attachment ids instead of bug ids
2368         https://bugs.webkit.org/show_bug.cgi?id=31540
2369
2370         * Scripts/bugzilla-tool:
2371
2372 2009-11-16  Eric Seidel  <eric@webkit.org>
2373
2374         Reviewed by Adam Barth.
2375
2376         WorkQueue is the only place that should know about special exit codes
2377         https://bugs.webkit.org/show_bug.cgi?id=31534
2378
2379         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
2380         and add tests for handling exit codes.
2381         I also cleaned up workqueue_unittest.py more.
2382
2383         * Scripts/bugzilla-tool:
2384         * Scripts/modules/workqueue.py:
2385         * Scripts/modules/workqueue_unittest.py:
2386
2387 2009-11-16  Eric Seidel  <eric@webkit.org>
2388
2389         Reviewed by Adam Barth.
2390
2391         Re-factor workqueue_unittest to allow for more than one test.
2392         https://bugs.webkit.org/show_bug.cgi?id=31535
2393
2394         * Scripts/modules/workqueue_unittest.py:
2395
2396 2009-11-16  Eric Seidel  <eric@webkit.org>
2397
2398         Reviewed by Adam Barth.
2399
2400         land-patches needs to be re-factored into smaller chunks
2401         https://bugs.webkit.org/show_bug.cgi?id=31532
2402
2403         * Scripts/bugzilla-tool: fix a couple obvious typos.
2404
2405 2009-11-16  Eric Seidel  <eric@webkit.org>
2406
2407         Reviewed by Adam Barth.
2408
2409         land-patches needs to be re-factored into smaller chunks
2410         https://bugs.webkit.org/show_bug.cgi?id=31532
2411
2412         The next patch will move these methods into WebKitLandingScripts.
2413
2414         * Scripts/bugzilla-tool:
2415          - Split out _land_patch and _close_bug_if_no_active_patches.
2416
2417 2009-11-16  Adam Barth  <abarth@webkit.org>
2418
2419         Reviewed by Eric Seidel.
2420
2421         Fix silly copy-and-paste code.  I am a terrible coder.
2422
2423         * Scripts/modules/bugzilla.py:
2424
2425 2009-11-16  Adam Barth  <abarth@webkit.org>
2426
2427         Reviewed by Eric Seidel.
2428
2429         Implement a StyleQueue
2430         https://bugs.webkit.org/show_bug.cgi?id=31537
2431
2432         The first iteration of the style queue only produces output locally.
2433         There is also a limit of 10 patches because it's not that useful to
2434         iterate through the entire review queue at this point.  We can remove
2435         the limit later.
2436
2437         * Scripts/bugzilla-tool:
2438         * Scripts/modules/bugzilla.py:
2439
2440 2009-11-16  Adam Barth  <abarth@webkit.org>
2441
2442         Reviewed by Eric Seidel.
2443
2444         Unit test WorkQueue
2445         https://bugs.webkit.org/show_bug.cgi?id=31531
2446
2447         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
2448
2449         * Scripts/bugzilla-tool:
2450         * Scripts/modules/statusbot.py:
2451         * Scripts/modules/workqueue.py:
2452         * Scripts/modules/workqueue_unittest.py: Added.
2453         * Scripts/run-webkit-unittests:
2454
2455 2009-11-16  Eric Seidel  <eric@webkit.org>
2456
2457         Reviewed by Adam Barth.
2458
2459         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
2460         https://bugs.webkit.org/show_bug.cgi?id=31530
2461
2462         * Scripts/bugzilla-tool:
2463
2464 2009-11-16  Eric Seidel  <eric@webkit.org>
2465
2466         Reviewed by Adam Barth.
2467
2468         bugzilla-tool needs apply-attachment
2469         https://bugs.webkit.org/show_bug.cgi?id=31528
2470
2471         * Scripts/bugzilla-tool:
2472          - Add ApplyAttachment command.
2473          - Abstract applying code into WebKitApplyingScripts.
2474          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
2475         * Scripts/modules/bugzilla.py:
2476          - Add fetch_attachment and bug_id_for_attachment_id.
2477         * Scripts/modules/bugzilla_unittest.py:
2478          - Add test for new parsing.
2479          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
2480
2481 2009-11-16  Eric Seidel  <eric@webkit.org>
2482
2483         Reviewed by Adam Barth.
2484
2485         Document check-style's use of force_clean.
2486
2487         * Scripts/bugzilla-tool:
2488         * Scripts/modules/scm.py:
2489
2490 2009-11-16  Adam Barth  <abarth@webkit.org>
2491
2492         Reviewed by Eric Seidel.
2493
2494         Move WorkQueue to its own file
2495         https://bugs.webkit.org/show_bug.cgi?id=31529
2496
2497         WorkQueue and WorkQueueDelegate are separate concerns from
2498         bugzilla-tool.  Also added a missing include to logging.py.
2499
2500         * Scripts/bugzilla-tool:
2501         * Scripts/modules/logging.py:
2502         * Scripts/modules/workqueue.py:
2503
2504 2009-11-16  Adam Barth  <abarth@webkit.org>
2505
2506         Reviewed by Eric Seidel.
2507
2508         Move OutputTee to logging.py.
2509
2510         * Scripts/bugzilla-tool:
2511         * Scripts/modules/logging.py:
2512
2513 2009-11-15  Adam Barth  <abarth@webkit.org>
2514
2515         Reviewed by Eric Seidel.
2516
2517         Refactor bugzilla-tool to allow for multiple queues
2518         https://bugs.webkit.org/show_bug.cgi?id=31513
2519
2520         Divide the commit queue class into three class to make creating
2521         additional queues easier.
2522
2523         * Scripts/bugzilla-tool:
2524
2525 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
2526
2527         Reviewed by Eric Seidel.
2528
2529         svn-apply may not handle git patches created by bugzilla-tool
2530         https://bugs.webkit.org/show_bug.cgi?id=31457
2531
2532         * Scripts/modules/scm.py:
2533         * Scripts/modules/scm_unittest.py:
2534
2535 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
2536
2537         Reviewed by Eric Seidel.
2538
2539         bugzilla-tool should post git binary diff
2540         https://bugs.webkit.org/show_bug.cgi?id=31458
2541
2542         Add --binary option to Git.create_patch.
2543
2544         * Scripts/modules/scm.py:
2545         * Scripts/modules/scm_unittest.py:
2546
2547 2009-11-15  Adam Barth  <abarth@webkit.org>
2548
2549         Reviewed by Darin Adler.
2550
2551         Add bugzilla-tool check-style
2552         https://bugs.webkit.org/show_bug.cgi?id=31515
2553
2554         * Scripts/bugzilla-tool:
2555         * Scripts/modules/bugzilla.py:
2556
2557 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2558
2559         Reviewed by Simon Hausmann.
2560
2561         Make the Qt Linux only --valgrind feature, suppress errors
2562         defined in the SuppressedValgrindErrors file.
2563
2564         * Scripts/run-webkit-tests:
2565
2566 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2567
2568         Reviewed by Simon Hausmann.
2569
2570         Set the locale to C and not to the current one in use on the system.
2571
2572         * DumpRenderTree/qt/DumpRenderTree.cpp:
2573         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2574
2575 2009-11-13  Adam Roben  <aroben@apple.com>
2576
2577         Add support for
2578         http/tests/security/isolatedWorld/didClearWindowObject.html
2579
2580         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
2581         window objects in isolated worlds are cleared
2582
2583         Reviewed by Dave Hyatt.
2584
2585         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
2586
2587         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2588         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2589         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
2590         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
2591         Added. Sets a __worldID property on the global object whose value is
2592         the ID of this world.
2593         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
2594         Respond to this new delegate callback by calling through to one of the
2595         above new methods.
2596         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2597         (worldMap): Added. Returns a HashMap containing all the worlds we've
2598         created.
2599         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
2600         haven't kept track of this world.
2601         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
2602         instead of declaring our own.
2603
2604         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
2605
2606         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2607         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
2608         didClearWindowObjectForFrameInStandardWorld.
2609         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
2610         Respond to this new delegate callback by calling through to one of the
2611         below new methods.
2612         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
2613         Added. Sets a __worldID property on the gobal object whose value is
2614         the ID of this world.
2615         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
2616         Added. Moved code here from didClearWindowObject.
2617
2618         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
2619         didClearWindowObjectForFrame* functions.
2620
2621         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2622         (worldMap): Added. Returns a HashMap containing all the worlds we've
2623         created.
2624         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
2625         haven't kept track of this world.
2626         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
2627         instead of declaring our own.
2628
2629 2009-11-13  Adam Roben  <aroben@apple.com>
2630
2631         Finish replacing worldIDs with world objects
2632
2633         The only remaining use of worldIDs was in a method only used by DRT
2634         for the isolated worlds tests.
2635
2636         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
2637
2638         Reviewed by Mark Rowe.
2639
2640         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2641         (LayoutTestController::evaluateScriptInIsolatedWorld):
2642         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2643         (LayoutTestController::evaluateScriptInIsolatedWorld):
2644         Updated for changes to WebFrame. Now holds the map of worldID -> world
2645         at this level instead of making WebKit do it.
2646
2647 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2648
2649         Reviewed by Simon Hausmann.
2650
2651         [Qt] Ensure the DRT does not output anything until first test is run
2652
2653         * DumpRenderTree/qt/DumpRenderTree.cpp:
2654         * DumpRenderTree/qt/DumpRenderTree.h:
2655
2656 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2657
2658         Reviewed by Tor Arne Vestbø.
2659
2660         Clear the undo stack in before each new test run.
2661
2662         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
2663
2664         * DumpRenderTree/qt/DumpRenderTree.cpp:
2665         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2666
2667 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2668
2669         Reviewed by Kenneth Rohde Christiansen.
2670
2671         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
2672
2673         * DumpRenderTree/qt/DumpRenderTree.cpp:
2674         (WebCore::WebPage::resetSettings):
2675         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2676         (LayoutTestController::overridePreference):
2677
2678 2009-11-13  Eric Seidel  <eric@webkit.org>
2679
2680         Reviewed by Adam Barth.
2681
2682         Update committers.py based on svn records
2683         https://bugs.webkit.org/show_bug.cgi?id=31366
2684
2685         This list was generated using validate-committer-lists from
2686         https://bugs.webkit.org/show_bug.cgi?id=30970
2687         and makes committers.py current for committers who have
2688         committed in the last 3 years.
2689
2690         * Scripts/modules/committers.py:
2691
2692 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
2693
2694         Reviewed by Adam Barth.
2695
2696         The document-open.html test was flaky at times. The test invokes the layout test plugin
2697         which in its destroy stream handler opens a new document. This basically tears down the
2698         stream and the associated plugin instance. The pluginLog function in the layout test
2699         plugin attempts to retrieve the window script object on a torn down plugin instance
2700         which crashed consistently on windows in the debugger. The functions which issue
2701         these logs already have a valid window script object. We now have variants of the pluginLog
2702         function which take in a window script object with and without variable arguments. 
2703
2704         https://bugs.webkit.org/show_bug.cgi?id=31067
2705
2706         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2707         (pluginLogWithWindowObject):
2708         (pluginLogWithWindowObjectVariableArgs):
2709         (pluginLog):
2710         (notifyTestCompletion):
2711         (testDocumentOpen):
2712         (testWindowOpen):
2713
2714 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2715
2716         Reviewed by Gustavo Noronha Silva.
2717
2718         https://bugs.webkit.org/show_bug.cgi?id=30997
2719         [Gtk] Implemment AtkDocument
2720
2721         Added testing support.
2722
2723         * DumpRenderTree/AccessibilityUIElement.cpp:
2724         * DumpRenderTree/AccessibilityUIElement.h:
2725         (getDocumentEncodingCallback):
2726         (getDocumentURICallback):
2727         (AccessibilityUIElement::getJSClass):
2728         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2729         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2730         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2731         (AccessibilityUIElement::documentEncoding):
2732         (AccessibilityUIElement::documentURI):
2733
2734 2009-11-12  Adam Roben  <aroben@apple.com>
2735
2736         Replace worldIDs with world objects
2737
2738         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
2739         user scripts/stylesheets and isolated worlds
2740
2741         Reviewed by Sam Weinig.
2742
2743         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2744         (LayoutTestController::addUserScript):
2745         (LayoutTestController::addUserStyleSheet):
2746         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2747         (LayoutTestController::addUserScript):
2748         (LayoutTestController::addUserStyleSheet):
2749         Changed these functions to create a new WebJSWorld each time they're
2750         called and to pass that world to WebKit.
2751
2752 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
2753
2754         Reviewed by Oliver Hunt.
2755
2756         need to implement aria tree roles
2757         https://bugs.webkit.org/show_bug.cgi?id=31284
2758
2759         * DumpRenderTree/AccessibilityUIElement.cpp:
2760         (disclosedRowAtIndexCallback):
2761         (selectedRowAtIndexCallback):
2762         (isEqualCallback):
2763         (isAttributeSettableCallback):
2764         (isActionSupportedCallback):
2765         (disclosedByRowCallback):
2766         (hierarchicalLevelCallback):
2767         (AccessibilityUIElement::getJSClass):
2768         * DumpRenderTree/AccessibilityUIElement.h:
2769         (AccessibilityUIElement::isEqual):
2770         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2771         (AccessibilityUIElement::hierarchicalLevel):
2772         (AccessibilityUIElement::disclosedRowAtIndex):
2773         (AccessibilityUIElement::selectedRowAtIndex):
2774         (AccessibilityUIElement::disclosedByRow):
2775         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2776         (AccessibilityUIElement::getChildAtIndex):
2777         (AccessibilityUIElement::disclosedRowAtIndex):
2778         (AccessibilityUIElement::selectedRowAtIndex):
2779         (AccessibilityUIElement::titleUIElement):
2780         (AccessibilityUIElement::parentElement):
2781         (AccessibilityUIElement::disclosedByRow):
2782         (AccessibilityUIElement::hierarchicalLevel):
2783         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2784         (AccessibilityUIElement::hierarchicalLevel):
2785         (AccessibilityUIElement::disclosedRowAtIndex):
2786         (AccessibilityUIElement::selectedRowAtIndex):
2787         (AccessibilityUIElement::disclosedByRow):
2788
2789 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
2790
2791         Reviewed by Darin Adler.
2792
2793         svn-apply can not handle git binary diffs
2794         https://bugs.webkit.org/show_bug.cgi?id=26830
2795
2796         Support "literal" type git binary diffs.
2797
2798         * Scripts/VCSUtils.pm:
2799         * Scripts/modules/scm_unittest.py:
2800         * Scripts/svn-apply:
2801
2802 2009-11-11  Dmitry Titov  <dimich@chromium.org>
2803
2804         Not reviewed, removing duplicate entry for myself in committers.py.
2805
2806         * Scripts/modules/committers.py:
2807
2808 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
2809
2810         Reviewed by Darin Adler and Mark Rowe.
2811
2812         https://bugs.webkit.org/show_bug.cgi?id=31200
2813         Tests in http/tests/security/mixedContent start to fail when new tests are added
2814
2815         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
2816
2817 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2818
2819         Reviewed by Jan Alonzo.
2820
2821         Create, and display a window for the inspector, for inspector
2822         tests.
2823
2824         Need to also show/hide the inspector window to avoid having
2825         problems with code assuming it is realized
2826         https://bugs.webkit.org/show_bug.cgi?id=31347
2827
2828         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2829         (webInspectorShowWindow):
2830         (webInspectorCloseWindow):
2831         (webInspectorInspectWebView):
2832         (createWebView):
2833
2834 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2835
2836         Unreviewed Qt buildbot fix.
2837
2838         My previous fix was wrong, so revert that change and fix it by
2839         returning when the document of the frame has no document element.
2840         Idea is borrowed from mac and win DRT.
2841
2842         * DumpRenderTree/qt/DumpRenderTree.cpp:
2843         (WebCore::DumpRenderTree::dumpFramesAsText):
2844
2845 2009-11-11  Eric Seidel  <eric@webkit.org>
2846
2847         Reviewed byg Kenneth Rohde Christiansen.
2848
2849         Update Kenneth's committer record to include the email he
2850         uses on lists.webkit.org.
2851
2852         * Scripts/modules/committers.py:
2853
2854 2009-11-11  Eric Seidel  <eric@webkit.org>
2855
2856         Reviewed by Gustavo Noronha Silva.
2857
2858         Several committers use separate email addresses for bugzilla and svn.webkit.org
2859         https://bugs.webkit.org/show_bug.cgi?id=31364
2860
2861         Update records for existing committers to include email addresses
2862         used in svn.webkit.org and lists.webkit.org.
2863         Most committers use the same email address in all 3 places, but some use
2864         separate addresses.  committers.py needs record of each of these addresses.
2865
2866         * Scripts/modules/committers.py:
2867
2868 2009-11-11  Eric Seidel  <eric@webkit.org>
2869
2870         No review, adding second email address for an existing committer.
2871
2872         Add Yong Li's second bugzilla account to his committer record.
2873         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
2874
2875         * Scripts/modules/committers.py:
2876
2877 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2878
2879         Reviewed by Simon Hausmann.
2880
2881         If the frame has no innerText don't append it, and
2882         do not add a newline which breaks some cross platform
2883         results.
2884
2885         * DumpRenderTree/qt/DumpRenderTree.cpp:
2886         (WebCore::DumpRenderTree::dumpFramesAsText):
2887
2888 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2889
2890         Reviewed by Simon Hausmann.
2891
2892         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
2893
2894         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2895         (webkit_test_plugin_new_instance):
2896         (webkit_test_plugin_destroy_instance):
2897         (webkit_test_plugin_destroy_stream):
2898
2899 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2900
2901         Reviewed by Mark Rowe.
2902
2903         Implement the functionality needed by plugins/window-open.html
2904
2905         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2906         (webkit_test_plugin_new_instance):
2907         (webkit_test_plugin_set_window):
2908
2909 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2910
2911         Reviewed by Simon Hausmann.
2912
2913         [Qt] Force -graphicssystem raster and -style windows when running DRT
2914
2915         * DumpRenderTree/qt/main.cpp:
2916         * Scripts/run-webkit-tests:
2917
2918 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2919
2920         Reviewed by Simon Hausmann.
2921
2922         Compute correct library paths for Qt
2923
2924         * Scripts/webkitdirs.pm:
2925
2926 2009-11-10  Mark Rowe  <mrowe@apple.com>
2927
2928         Reviewed by Sam Weinig.
2929
2930         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
2931
2932         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
2933         about the validity of the self-signed certificates used in the regression tests.  We would then add the
2934         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
2935         that had enabled frame load delegate logging this would result in extra log messages being generated,
2936         causing the test to fail.
2937
2938         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
2939         tests.
2940
2941         * DumpRenderTree/mac/DumpRenderTree.mm:
2942         (dumpRenderTree):
2943         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2944         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2945
2946 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2947
2948         Reviewed by Kenneth Rohde Christiansen.
2949
2950         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
2951
2952         * DumpRenderTree/qt/DumpRenderTree.cpp:
2953         (WebCore::DumpRenderTree::DumpRenderTree):
2954
2955 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2956
2957         Reviewed by Jan Alonzo.
2958
2959         [GTK] Remove WebSocket configuration from WebKitWebSettings
2960         https://bugs.webkit.org/show_bug.cgi?id=31244
2961
2962         Follow-up of r50724. Don't set the enable-web-socket property
2963         anymore.
2964
2965         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2966         (resetDefaultsToConsistentValues):
2967
2968 2009-11-10  Oliver Hunt  <oliver@apple.com>
2969
2970         Reviewed by Maciej Stachowiak.
2971
2972         Rename 3D Canvas related classes to use WebGL prefix
2973         https://bugs.webkit.org/show_bug.cgi?id=29095
2974
2975         Checkin new version of do-webcore-rename used to do the WebGL type rename,
2976         and upate webkitdirs script to new method of testing for WebGL.
2977
2978         * Scripts/do-webcore-rename:
2979         * Scripts/webkitdirs.pm:
2980
2981 2009-11-09  Oliver Hunt  <oliver@apple.com>
2982
2983         Reviewed by Geoff Garen.
2984
2985         Make do-webcore-rename work with git.
2986
2987         * Scripts/do-webcore-rename:
2988
2989 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2990
2991         Adding Kenneth to the reviewers list.
2992
2993         * Scripts/modules/committers.py:
2994
2995 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2996
2997         Reviewed by Jan Alonzo.
2998
2999         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
3000         https://bugs.webkit.org/show_bug.cgi?id=30482
3001
3002         LayoutTestControllerGtk now uses the exposed
3003         Page::tabKeyCyclesThroughElements API
3004
3005         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3006         (LayoutTestController::setTabKeyCyclesThroughElements):
3007
3008 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
3009
3010         Reviewed by Holger Freyther.
3011
3012         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
3013         This helps to pass the test case below. Also replaced hardcoded
3014         code numbers with defined constants.
3015         https://bugs.webkit.org/show_bug.cgi?id=31185
3016         
3017         Test: editing/undo/undo-deleteWord.html
3018
3019         * DumpRenderTree/qt/EventSenderQt.cpp:
3020         (EventSender::keyDown):
3021
3022 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
3023
3024         Reviewed by Holger Freyther.
3025
3026         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
3027         https://bugs.webkit.org/show_bug.cgi?id=31164
3028
3029         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
3030
3031         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3032         (LayoutTestController::processWork):
3033
3034 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
3035
3036         Reviewed by Holger Freyther.
3037
3038         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
3039         https://bugs.webkit.org/show_bug.cgi?id=31158
3040
3041         By invoking a script queue'd by queueScript(), 'true' was beeing returned
3042         always, which from WorkQueue prospective means that a load has been started
3043         and the queue processing should stop and wait for the load to finish.
3044         Spinning it off into a loading and a non-loading variants was the solution
3045         adopted by Mac's DRT to work around this problem. The former keeps returning
3046         'true' while the later executes the script synchronously and returns 'false'
3047         making it possible to the WorkQueue to proceed right away.
3048
3049         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3050         (LayoutTestController::processWork):
3051         (LayoutTestController::queueLoadingScript):
3052         (LayoutTestController::queueNonLoadingScript):
3053         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3054         * DumpRenderTree/qt/WorkQueueItem.h:
3055         (LoadingScriptItem::LoadingScriptItem):
3056         (LoadingScriptItem::invoke):
3057         (NonLoadingScriptItem::NonLoadingScriptItem):
3058         (NonLoadingScriptItem::invoke):
3059
3060 2009-11-07  Mark Rowe  <mrowe@apple.com>
3061
3062         Rubber-stamped by Cameron Zwarich.
3063
3064         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
3065
3066         * Scripts/commit-log-editor:
3067
3068 2009-11-07  Mark Rowe  <mrowe@apple.com>
3069
3070         Reviewed by Darin Adler.
3071
3072         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
3073         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
3074
3075         Move logic for determining the name and email address to use in a ChangeLog entry from
3076         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
3077         whether the author of the patch matches committer, and therefore needs access to the
3078         email address that would be used in a ChangeLog entry.
3079
3080         Based on a patch by Pierre d'Herbemont.
3081
3082         * Scripts/VCSUtils.pm:
3083         * Scripts/commit-log-editor:
3084         * Scripts/prepare-ChangeLog:
3085         * Scripts/webkitdirs.pm:
3086
3087 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
3088
3089         Reviewed by Adam Barth.
3090
3091         Added functionality to the layout test plugin to invoke document.open and
3092         window.open with default arguments. The associated webkit bug is
3093         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
3094         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
3095         work in Chromium (V8) if there is no calling javascript context. To achieve this
3096         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
3097         for the window.open test case and in NPP_DestroyStream for the document.open test case.
3098
3099         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3100         (testDocumentOpen):
3101         (testWindowOpen):
3102         (pluginAllocate):
3103         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3104         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3105         (NPP_New):
3106         (NPP_SetWindow):
3107         (NPP_DestroyStream):
3108         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
3109         (NPP_New):
3110         (NPP_SetWindow):
3111         (NPP_NewStream):
3112         (NPP_DestroyStream):
3113
3114 2009-11-06  Eric Seidel  <eric@webkit.org>
3115
3116         Reviewed by Adam Barth.
3117
3118         bugzilla-tool crashed with exception
3119         https://bugs.webkit.org/show_bug.cgi?id=31092
3120
3121         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
3122
3123 2009-11-04  Eric Seidel  <eric@webkit.org>
3124
3125         No review, just add a line which got left out of the patch uploaded for commit.
3126
3127         commit-queue is crashing when trying to reject patches after unknown failures
3128         https://bugs.webkit.org/show_bug.cgi?id=31091
3129
3130         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
3131
3132 2009-11-04  Adam Roben  <aroben@apple.com>
3133
3134         Remove bogus else clause in bugzilla-tool
3135
3136         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
3137         create-bug raises exception after entering bug description
3138
3139         Reviewed by David Kilzer.
3140
3141         * Scripts/bugzilla-tool:
3142         (CreateBug): else clauses are only hit if no exception is raised, so
3143         it makes no sense to try to re-raise the exception in an else clause.
3144         The exception will automatically be re-raised if it doesn't match any
3145         of the except clauses, so we don't have to do anything special here at
3146         all to get the desired behavior.
3147
3148 2009-11-04  Eric Seidel  <eric@webkit.org>
3149
3150         Reviewed by David Kilzer.
3151
3152         svn-apply's fixChangeLogPatch function seems broken
3153         https://bugs.webkit.org/show_bug.cgi?id=30683
3154
3155         Update fixChangeLogPatch to be able to handle patches which
3156         don't start at line 1.
3157         Add unit tests for svn-apply to scm_unittest.py.
3158
3159         * Scripts/VCSUtils.pm:
3160         * Scripts/modules/scm_unittest.py:
3161
3162 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
3163
3164         Reviewed by Beth Dakin.
3165
3166         Need to implement ARIA role="combobox"
3167         https://bugs.webkit.org/show_bug.cgi?id=31096
3168
3169         * DumpRenderTree/AccessibilityUIElement.cpp:
3170         (showMenuCallback):
3171         (getIsExpandedCallback):
3172         (AccessibilityUIElement::getJSClass):
3173         * DumpRenderTree/AccessibilityUIElement.h:
3174         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3175         (AccessibilityUIElement::isExpanded):
3176         (AccessibilityUIElement::showMenu):
3177         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3178         (AccessibilityUIElement::isExpanded):
3179         (AccessibilityUIElement::showMenu):
3180         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3181         (AccessibilityUIElement::isSelected):
3182         (AccessibilityUIElement::isExpanded):
3183         (AccessibilityUIElement::showMenu):
3184
3185 2009-11-04  Eric Seidel  <eric@webkit.org>
3186
3187         Reviewed by Adam Barth.
3188
3189         commit-queue is crashing when trying to reject patches after unknown failures
3190         https://bugs.webkit.org/show_bug.cgi?id=31091
3191
3192         * Scripts/bugzilla-tool:
3193          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
3194            so we have to find out what the current patch is by asking bugzilla again.
3195          - Discovered that this code was also leaking file descriptors, so fixed that.
3196
3197 2009-11-04  Adam Roben  <aroben@apple.com>
3198
3199         Make run-webkit-tests work for the Debug_Internal Windows
3200         configuration
3201
3202         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
3203         suffix.
3204
3205         Fixes <http://webkit.org/b/31123>.
3206
3207         Reviewed by Sam Weinig.
3208
3209         * Scripts/run-webkit-tests: Don't add the _debug suffix in
3210         Debug_Internal, either.
3211
3212 2009-11-04  Eric Seidel  <eric@webkit.org>
3213
3214         Reviewed by Adam Barth.
3215
3216         committers.py needs a way to store non-bugzilla email addresses
3217         https://bugs.webkit.org/show_bug.cgi?id=31037
3218
3219         Make Committer and Reviewer constructors take a single email or a list of emails.
3220         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
3221         Expose reviewers(), used by validate-committer-lists on bug 30970.
3222
3223         * Scripts/modules/committers.py:
3224         * Scripts/modules/committers_unittest.py: Added tests for the new code.
3225
3226 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
3227
3228         Reviewed by David Levin.
3229
3230         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
3231         https://bugs.webkit.org/show_bug.cgi?id=27491
3232
3233         The test path determination logic is changed to handle websocket and websocket/ssl cases.
3234         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
3235
3236         Functions to start or stop Web Socket servers are added.
3237
3238         * Scripts/run-webkit-tests:
3239
3240 2009-11-03  Eric Seidel  <eric@webkit.org>
3241
3242         No review, just changing wording of log message.
3243
3244         Change log string to say "failed" instead of "rejected"
3245         when a commit fails due to an out of date checkout.
3246         This makes grepping the commit-queue log for rejected patches easier.
3247
3248         * Scripts/bugzilla-tool:
3249
3250 2009-11-03  Eric Seidel  <eric@webkit.org>
3251
3252         No review, adding commonly known committers missing from the file.
3253
3254         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
3255
3256 2009-11-03  Eric Seidel  <eric@webkit.org>
3257
3258         No review, just sort-order cleanup.
3259
3260         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
3261
3262 2009-11-03  Stephen White  <senorblanco@chromium.org>
3263
3264         (Unreviewed).
3265
3266         Add myself to committers.py.
3267
3268         * Scripts/modules/committers.py:
3269
3270 2009-11-03  Robin Dunn  <robin@alldunn.com>
3271
3272         Reviewed by Kevin Ollviier.
3273
3274         Add packaging scripts for Debian-based Linux distros.
3275         
3276         https://bugs.webkit.org/show_bug.cgi?id=31075
3277
3278         * wx/packaging/build-debian-installer.py: Added.
3279         * wx/packaging/debian: Added.
3280
3281 2009-11-03  Dan Bernstein  <mitz@apple.com>
3282
3283         Reviewed by Anders Carlsson and Beth Dakin.
3284
3285         https://bugs.webkit.org/show_bug.cgi?id=31070
3286
3287         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
3288         destroyed, it executes the value of the 'ondestroy' parameter as a
3289         script.
3290
3291         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3292         (pluginAllocate): Initialize onDestroy.
3293         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
3294         onDestroy.
3295         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3296         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
3297         specified.
3298         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
3299
3300 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3301
3302         Reviewed by Xan Lopez.
3303
3304         https://bugs.webkit.org/show_bug.cgi?id=31035
3305         [GTK] some accessibility tests hitting assertion in debug builds
3306
3307         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
3308
3309         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3310         (AccessibilityController::rootElement):
3311
3312 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
3313
3314         Reviewed by Beth Dakin.
3315
3316         Support ARIA "tab" roles
3317         https://bugs.webkit.org/show_bug.cgi?id=30842
3318
3319         * DumpRenderTree/AccessibilityUIElement.cpp:
3320         * DumpRenderTree/AccessibilityUIElement.h:
3321         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3322         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3323         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3324
3325 2009-11-01  Eric Seidel  <eric@webkit.org>
3326
3327         Reviewed by David Levin.
3328
3329         buildbots should use --exit-after-N-failures
3330         https://bugs.webkit.org/show_bug.cgi?id=30809
3331
3332         Make the bots exit after 20 failures to prevent never-ending
3333         test runs where every test spends a minute crashing.
3334
3335         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3336
3337 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3338
3339         Reviewed by Eric Seidel.
3340
3341         Turn on warnings for QtWebKit for gcc
3342         https://bugs.webkit.org/show_bug.cgi?id=30958
3343
3344         * DumpRenderTree/qt/main.cpp: 
3345         (crashHandler): Mark function NO_RETURN
3346
3347 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
3348
3349         Adding myself to the committers list.
3350
3351         * Scripts/modules/committers.py:
3352
3353 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
3354
3355         Fix an issue that Adam noticed in DRT.
3356
3357         Reviewed by Darin Adler.
3358
3359         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3360         (AccessibilityUIElement::role):
3361         Get the length of the role text, and create a buffer dynamically.
3362
3363 2009-10-30  Eric Seidel  <eric@webkit.org>
3364
3365         No review, rolling out r50105.
3366         http://trac.webkit.org/changeset/50105
3367
3368         This commit was causing:
3369         https://bugs.webkit.org/show_bug.cgi?id=30869
3370         We'll re-implement the feature a different way.
3371
3372         * Scripts/bugzilla-tool:
3373
3374 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
3375
3376         Test for MSAA: Accessibility of headings is not correct
3377
3378         https://bugs.webkit.org/show_bug.cgi?id=30937
3379
3380         Reviewed by Adam Roben.
3381
3382         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3383         (AccessibilityUIElement::role):
3384         Allow the role returned to be a BSTR.
3385         (AccessibilityUIElement::description):
3386         Fix a copy/paste error.
3387
3388 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
3389
3390         Test for MSAA: Accessibility of links is wrong
3391
3392         https://bugs.webkit.org/show_bug.cgi?id=30928
3393
3394         Reviewed by Darin Adler.
3395
3396         * DumpRenderTree/AccessibilityUIElement.cpp:
3397         (getAccessibilityValueCallback):
3398         Return the accessibility value.
3399         (AccessibilityUIElement::getJSClass):
3400         Added "accessibilityValue" value.
3401
3402         * DumpRenderTree/AccessibilityUIElement.h:
3403
3404         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3405         (AccessibilityUIElement::accessibilityValue):
3406         Stubbed.
3407
3408         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3409         (AccessibilityUIElement::accessibilityValue):
3410         Stubbed.
3411
3412         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3413         (AccessibilityUIElement::accessibilityValue):
3414         Get the object's value, and return it as a JS string.
3415
3416 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
3417
3418         Fix typo in command name used by wx build system.
3419
3420         * wx/build/build_utils.py:
3421
3422 2009-10-30  Adam Barth  <abarth@webkit.org>
3423
3424         Reviewed by Darin Adler.
3425
3426         Patch v1 is a dumb default name for patches
3427         https://bugs.webkit.org/show_bug.cgi?id=30952
3428
3429         Let's use "Patch" instead.
3430
3431         * Scripts/bugzilla-tool:
3432
3433 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3434
3435         Unreviewed trivial buildfix.
3436
3437         [Qt] Buildfix for r50333.
3438
3439         * DumpRenderTree/qt/DumpRenderTree.pro:
3440
3441 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
3442
3443         Reviewed by Holger Freyther.
3444
3445         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
3446         https://bugs.webkit.org/show_bug.cgi?id=30953
3447
3448         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
3449         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
3450         makes qt DRT to share this implementation (as gtk and mac ports do).
3451
3452         * DumpRenderTree/qt/DumpRenderTree.pro:
3453         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
3454         * DumpRenderTree/qt/WorkQueue.h: Removed.
3455
3456 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3457
3458         Unreviewed potential buildbot fix.
3459
3460         Second try: Reset page history before running each test.
3461
3462         Apparently the QWebHistory::clear() keeps the current page
3463         in history which is not what we want, so we not additionally
3464         sets the history capacity to 0 (forces removing everything)
3465         and then sets it back to its original value.
3466
3467         * DumpRenderTree/qt/DumpRenderTree.cpp:
3468         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3469
3470 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3471
3472         Unreviewed potential buildbot fix.
3473
3474         Reset page history before running each test.
3475
3476         * DumpRenderTree/qt/DumpRenderTree.cpp:
3477         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3478
3479 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
3480
3481         Reviewed by Eric Seidel.
3482
3483         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
3484
3485         Bug 28420 -  Implement HTML5 <ruby> rendering
3486         (https://bugs.webkit.org/show_bug.cgi?id=28420)
3487
3488         No new tests (no functional change).
3489
3490         * Scripts/build-webkit:
3491
3492 2009-10-29  Dan Bernstein  <mitz@apple.com>
3493
3494         Reviewed by Mark Rowe.
3495
3496         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
3497         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
3498         define it.
3499
3500         * Scripts/VCSUtils.pm:
3501         * Scripts/svn-apply:
3502         * Scripts/svn-unapply:
3503
3504 2009-10-29  Xan Lopez  <xlopez@igalia.com>
3505
3506         Reviewed by Gustavo Noronha.
3507
3508         Use the GTK+ main loop instead of rolling our own mini-version of
3509         it.
3510
3511         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3512         (dump):
3513         (runTest):
3514         (webViewLoadFinished):
3515
3516 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3517
3518         Reviewed by Oliver Hunt.
3519
3520         Implement the Qt version of DRT dumpBackForwardList().
3521
3522         * DumpRenderTree/qt/DumpRenderTree.cpp:
3523         (WebCore::dumpHistoryItem):
3524         (WebCore::DumpRenderTree::dumpBackForwardList):
3525
3526 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3527
3528         Reviewed by Adam Roben.
3529
3530         Implement DRT functionality for Qt introduced in
3531         r28690 and r28705.
3532
3533         - Implemented pathToLocalResource which exposes the functionality of
3534         converting a given unix path to the correct location on Windows.
3535         - Implemented a way to remove machine-dependent information from paths
3536         in layout test results.
3537
3538         * DumpRenderTree/qt/DumpRenderTree.cpp:
3539         (WebCore::urlSuitableForTestResult):
3540         (WebCore::WebPage::javaScriptConsoleMessage):
3541         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3542         (LayoutTestController::pathToLocalResource):
3543         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3544
3545 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
3546
3547         Adding myself to the committers list.
3548
3549         * Scripts/modules/committers.py:
3550
3551 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
3552
3553         Adding myself to the committers list.
3554
3555         * Scripts/modules/committers.py:
3556
3557 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3558
3559         Reviewed by Jan Alonzo.
3560
3561         [GTK] API to start inspector for a WebView
3562         https://bugs.webkit.org/show_bug.cgi?id=22551
3563
3564         Use the new inspector API to implement the LayoutTestController
3565         interfaces used to test the inspector.
3566
3567         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3568         (webInspectorInspectWebView):
3569         (createWebView):
3570         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3571         (LayoutTestController::showWebInspector):
3572         (LayoutTestController::closeWebInspector):
3573         (LayoutTestController::evaluateInWebInspector):
3574
3575 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
3576
3577         Reviewed by Eric Seidel.
3578
3579         [Qt] WebFrame::counterValueForElementById must not be exposed
3580         https://bugs.webkit.org/show_bug.cgi?id=30882
3581
3582         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3583         (LayoutTestController::counterValueForElementById):
3584
3585 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3586
3587         Rubberstamped by Oliver Hunt.
3588
3589         Fix the warning:
3590
3591         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
3592         declared with attribute warn_unused_result".
3593
3594         by actually checking the result. In the case it is null, an
3595         error has occoured, so treat it as the other fatal errors.
3596
3597         * DumpRenderTree/qt/DumpRenderTree.cpp:
3598         (WebCore::DumpRenderTree::initializeFonts):
3599
3600 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
3601
3602         Reviewed by Darin Adler.
3603
3604         Provide a way to get counter values with layoutTestContoller
3605         https://bugs.webkit.org/show_bug.cgi?id=30555
3606
3607         Define layoutTestContoller.counterValueForElementById.
3608
3609         * DumpRenderTree/LayoutTestController.cpp:
3610         (counterValueForElementByIdCallback):
3611         (LayoutTestController::staticFunctions):
3612         * DumpRenderTree/LayoutTestController.h:
3613         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3614         (LayoutTestController::counterValueForElementById):
3615
3616 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3617
3618         Rubberstamped by Oliver Hunt.
3619
3620         Change two methods to be internal for DRT use only.
3621
3622         Part of [Qt] Review all new API in Qt 4.6
3623         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
3624
3625         * DumpRenderTree/qt/DumpRenderTree.cpp:
3626         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3627         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3628         (LayoutTestController::whiteListAccessFromOrigin):
3629
3630 2009-10-27  Eric Seidel  <eric@webkit.org>
3631
3632         Reviewed by Adam Barth.
3633
3634         REGRESSION: svn-apply exits(1) when applying a patch with a file add
3635         https://bugs.webkit.org/show_bug.cgi?id=30826
3636
3637         * Scripts/svn-apply:
3638          - Add () around all system() calls.
3639          - Use the correct system() == 0 or die instead of system() or die
3640          - Add descriptive messages to all die statements.
3641
3642 2009-10-27  Steve Block  <steveblock@google.com>
3643
3644         Reviewed by NOBODY.
3645
3646         Adds steveblock@google.com to list of committers.
3647
3648         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
3649
3650 2009-10-27  Eric Seidel  <eric@webkit.org>
3651
3652         Reviewed by Adam Barth.
3653
3654         svn-apply can exit(0) even on patch failure
3655         https://bugs.webkit.org/show_bug.cgi?id=29622
3656
3657         * Scripts/svn-apply:
3658          - Add a bunch of "or die" statements, hopefully catching all
3659            possible cases where failure could still exit(0).
3660
3661 2009-10-27  Eric Seidel  <eric@webkit.org>
3662
3663         Reviewed by Adam Barth.
3664
3665         svn-* scripts should share code through VCSUtils.pm
3666         https://bugs.webkit.org/show_bug.cgi?id=30791
3667
3668         Just moving code into a shared location.
3669
3670         * Scripts/VCSUtils.pm:
3671         * Scripts/prepare-ChangeLog:
3672         * Scripts/resolve-ChangeLogs:
3673         * Scripts/svn-apply:
3674         * Scripts/svn-create-patch:
3675         * Scripts/svn-unapply:
3676         * Scripts/update-webkit:
3677
3678 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
3679
3680         Suppress a huge number of MSVC warnings when building wxWebKit.
3681
3682         * wx/build/settings.py:
3683
3684 2009-10-26  Eric Seidel  <eric@webkit.org>
3685
3686         No review, just adding Mike Belshe to the committers list.
3687
3688         * Scripts/modules/committers.py:
3689
3690 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3691
3692         Reviewed by Darin Adler.
3693
3694         Make .rc files compile on Windows without depending on MFC headers
3695         https://bugs.webkit.org/show_bug.cgi?id=30750
3696
3697         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
3698         windows.h instead of afxres.h because it exists even when MFC is not 
3699         installed, and is all that's needed here.
3700
3701         * FindSafari/FindSafari.rc: Ditto
3702
3703 2009-10-24  Eric Seidel  <eric@webkit.org>
3704
3705         Reviewed by Adam Barth.
3706
3707         bugzilla-tool post-diff should know how to mark commit-queue=?
3708         https://bugs.webkit.org/show_bug.cgi?id=29202
3709
3710         * Scripts/bugzilla-tool:
3711          - Add --commit-queue option to post-diff, post-commits and create-bug.
3712         * Scripts/modules/bugzilla.py:
3713          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
3714          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
3715
3716 2009-10-23  Eric Seidel  <eric@webkit.org>
3717
3718         Reviewed by Adam Barth.
3719
3720         bugzilla-tool commit-queue does not notice modifications to committers.py
3721         https://bugs.webkit.org/show_bug.cgi?id=30084
3722
3723         * Scripts/bugzilla-tool:
3724          - Make commit-queue re-exec itself instead of using while(1).
3725          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
3726          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
3727
3728 2009-10-22  Eric Seidel  <eric@webkit.org>
3729
3730         Reviewed by Adam Barth.
3731
3732         commit-queue will get stuck on patches if land-patches terminates unexpectedly
3733         https://bugs.webkit.org/show_bug.cgi?id=30634
3734
3735         * Scripts/bugzilla-tool:
3736          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
3737          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
3738
3739 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
3740
3741         Reviewed by Eric Seidel.
3742
3743         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
3744
3745         https://bugs.webkit.org/show_bug.cgi?id=30763
3746
3747         * pywebsocket/mod_pywebsocket/__init__.py:
3748         * pywebsocket/mod_pywebsocket/dispatch.py:
3749         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
3750         * pywebsocket/mod_pywebsocket/standalone.py:
3751         * pywebsocket/setup.py:
3752         * pywebsocket/test/test_dispatch.py:
3753
3754 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
3755
3756         Reviewed by David Levin.
3757
3758         REGRESSION: 2 failures in run-webkit-unittests
3759         https://bugs.webkit.org/show_bug.cgi?id=30645
3760
3761         * Scripts/modules/cpp_style_unittest.py:
3762         Fixed a few test scenarios which apparently lost some spaces from 
3763         text literals.
3764
3765 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
3766
3767         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
3768
3769         * Scripts/webkitdirs.pm:
3770
3771 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
3772
3773         Reviewed by Darin Adler.
3774
3775         Unification of using null device in perl scripts.
3776         https://bugs.webkit.org/show_bug.cgi?id=30572
3777
3778         * Scripts/VCSUtils.pm:
3779         * Scripts/bisect-builds:
3780         * Scripts/resolve-ChangeLogs:
3781         * Scripts/run-iexploder-tests:
3782         * Scripts/run-jsc:
3783         * Scripts/run-mangleme-tests:
3784         * Scripts/run-webkit-tests:
3785         * Scripts/webkitdirs.pm:
3786         Using File::Spec->devnull() instead of hard coded /dev/null.
3787
3788 2009-10-26  Eric Seidel  <eric@webkit.org>
3789
3790         Reviewed by Holger Freyther.
3791
3792         Reviewers are missing from committers.py
3793         https://bugs.webkit.org/show_bug.cgi?id=30733
3794
3795         * Scripts/modules/committers.py:
3796
3797 2009-10-23  Eric Seidel  <eric@webkit.org>
3798
3799         No review, only adding Alice to the list of reviewers.
3800
3801         * Scripts/modules/committers.py:
3802
3803 2009-10-23  Eric Seidel  <eric@webkit.org>
3804
3805         Reviewed by Eric Carlson.
3806
3807         fast/media/mq-transform-02.html failed on Leopard Commit Bot
3808         https://bugs.webkit.org/show_bug.cgi?id=30700
3809
3810         * DumpRenderTree/mac/DumpRenderTree.mm:
3811         (resetDefaultsToConsistentValues): Update QuickTime version check.
3812
3813 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
3814
3815         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
3816         character measurement APIs that are private on Tiger.
3817
3818         * wx/build/settings.py:
3819
3820 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3821
3822         Reviewed by NOBODY (build fix).
3823         Build fix following bug #30696.
3824
3825         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3826         (LayoutTestController::evaluateScriptInIsolatedWorld):
3827
3828 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3829
3830         Reviewed by Sam Weinig & Geoff Garen.
3831
3832         https://bugs.webkit.org/show_bug.cgi?id=30696
3833         Enable isolated-worlds tests on mac.
3834
3835         Add private interface for DRT to invoke execution in a given world.
3836
3837         * DumpRenderTree/LayoutTestController.cpp:
3838         (evaluateScriptInIsolatedWorldCallback):
3839         (LayoutTestController::staticFunctions):
3840         * DumpRenderTree/LayoutTestController.h:
3841         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3842         (LayoutTestController::evaluateScriptInIsolatedWorld):
3843         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3844         (LayoutTestController::evaluateScriptInIsolatedWorld):
3845
3846 2009-10-21  Eric Seidel  <eric@webkit.org>
3847
3848         Reviewed by Adam Barth.
3849
3850         bugzilla-tool's "patch failed to download an apply" error should give more information
3851         https://bugs.webkit.org/show_bug.cgi?id=30632
3852
3853         * Scripts/modules/scm.py:
3854          - Use the common run_command method instead of custom POpen code.
3855          - Make run_command know how to take pipes as input.
3856         * Scripts/modules/scm_unittest.py:
3857          - Add new tests to cover change.
3858          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
3859
3860 2009-10-21  Kent Tamura  <tkent@chromium.org>
3861
3862         Unreviewed.  Adding myself to the committers list.
3863
3864         * Scripts/modules/committers.py:
3865
3866 2009-10-21  Robin Dunn  <robin@alldunn.com>
3867
3868         Reviewed by Kevin Ollivier.
3869
3870         Update the Windows installer builder to work with Vista / Win 7 and with git.
3871         
3872         https://bugs.webkit.org/show_bug.cgi?id=30649
3873
3874         * wx/build/build_utils.py:
3875         * wx/packaging/build-mac-installer.py:
3876         * wx/packaging/build-win-installer.py:
3877         * wx/packaging/wxWebKitInstaller.iss.in:
3878
3879 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3880
3881         Reviewed by Gustavo Noronha.
3882
3883         [GTK] Added conditional code to avoid using
3884         gdk_window_get_root_coords if we do not have a gtk+ release newer
3885         than 2.17.3.
3886         https://bugs.webkit.org/show_bug.cgi?id=30636
3887
3888         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3889
3890 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
3891
3892         Reviewed by Eric Seidel.
3893
3894         [Qt] Added dummy implementation for keepWebHistory()
3895         https://bugs.webkit.org/show_bug.cgi?id=30592
3896
3897         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3898         (LayoutTestController::keepWebHistory):
3899         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3900
3901 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3902
3903         Reviewed by Xan Lopez.
3904
3905         [GTK] Fixed the double click condition, it is not double click if
3906         we move in just in one direction.
3907         https://bugs.webkit.org/show_bug.cgi?id=30636
3908
3909         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3910
3911 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3912
3913         Reviewed by Xan Lopez.
3914
3915         [GTK] Initialize the events completly before emitting them.
3916         https://bugs.webkit.org/show_bug.cgi?id=30633
3917
3918         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3919
3920 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3921
3922         wx build fix. Fix for when linking using --as-needed with gcc.
3923
3924         * wx/browser/wscript:
3925
3926 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3927
3928         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
3929         to support all the features used by CURL backend.
3930         
3931         * wx/build/settings.py:
3932         * wx/install-unix-extras:
3933
3934 2009-10-20  Anton Muhin  <antonm@chromium.org>
3935
3936         Reviewed by Adam Barth.
3937
3938         Add {ager,antonm,yurys}@chromium.org into committers.py
3939         https://bugs.webkit.org/show_bug.cgi?id=30560
3940
3941         * Scripts/modules/committers.py:
3942
3943 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3944
3945         Reviewed by Tor Arne Vestbø.
3946
3947         Make the Netscape Test plugin available to the Qt launcher.
3948
3949         * Scripts/run-launcher:
3950
3951 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
3952
3953         Reviewed by David Levin.
3954
3955         Removed WebSocket runtime settings.
3956         https://bugs.webkit.org/show_bug.cgi?id=29896
3957
3958         WebSocket runtime configuration is supported by chromium/v8 only.
3959
3960         * DumpRenderTree/mac/DumpRenderTree.mm:
3961         (resetDefaultsToConsistentValues):
3962         * DumpRenderTree/win/DumpRenderTree.cpp:
3963         (resetDefaultsToConsistentValues):
3964
3965 2009-10-19  Nate Chapin  <japhet@chromium.org>
3966
3967         Reviewed by Adam Barth.
3968
3969         Add testFail() to test plugin so we can test our handling of a
3970         plugin invoke call returning false.
3971
3972         https://bugs.webkit.org/show_bug.cgi?id=30239
3973
3974         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
3975         (pluginInvoke):
3976         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
3977
3978 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
3979
3980         Reviewed by Gustavo Noronha.
3981
3982         Enable DOM pasting when running layout tests.
3983
3984         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3985         (resetDefaultsToConsistentValues):
3986
3987 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3988
3989         Reviewed by Simon Hausmann.
3990
3991         Use the setPreferredContentsSize method instead
3992         of setFixedContentsSize, as the method has been renamed.
3993
3994         * DumpRenderTree/qt/DumpRenderTree.cpp:
3995         (WebCore::DumpRenderTree::open):
3996         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3997         (LayoutTestController::setFixedContentsSize):
3998
3999 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
4000
4001         Reviewed by Dan Bernstein.
4002
4003         https://bugs.webkit.org/show_bug.cgi?id=30456
4004         Fixes for new Debug_All Windows build configuration.
4005
4006         * DumpRenderTree/win/DumpRenderTree.cpp:
4007         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
4008         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
4009
4010 2009-10-16  Eric Seidel  <eric@webkit.org>
4011
4012         Reviewed by Adam Barth.
4013
4014         commit-queue status bot should list which buildbot is blocking the queue
4015         https://bugs.webkit.org/show_bug.cgi?id=30452
4016
4017         Add new methods and testing.
4018
4019         * Scripts/bugzilla-tool:
4020         * Scripts/modules/buildbot.py:
4021         * Scripts/modules/buildbot_unittest.py:
4022
4023 2009-10-16  Eric Seidel  <eric@webkit.org>
4024
4025         Reviewed by Adam Barth.
4026
4027         run-webkit-tests fails when CWD is not inside a WebKit checkout
4028         https://bugs.webkit.org/show_bug.cgi?id=30451
4029
4030         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
4031         * Scripts/modules/scm_unittest.py:
4032           - Remove use of original_path (we don't need to restore the CWD).
4033           - Don't use '.' to find the webkit checkout, use __file__ instead.
4034
4035 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
4036
4037         Reviewed by Adam Roben.
4038
4039         Add a Debug_All configuration to build entire stack as debug.
4040         Change Debug_Internal to:
4041         - stop using _debug suffix for all WebKit/Safari binaries
4042         - not use _debug as a DLL naming suffix
4043         - use non-debug C runtime lib.
4044
4045         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
4046         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
4047         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
4048         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
4049         Add missing debug.vsprops inherited property sheet.
4050         Add Debug_All configuration.
4051         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
4052         * WinLauncher/WinLauncher.vcproj:
4053         Removed extraneous definitions inherited from vsprops.
4054         Add Debug_All configuration.
4055
4056 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
4057
4058         Reviewed by David Levin.
4059
4060         check-webkit-style is wrong about indent checking in namespaces
4061         in header files and a few other things
4062         https://bugs.webkit.org/show_bug.cgi?id=30362
4063
4064         The few other things include:
4065         + check-webkit-style does not require spaces around the equal sign
4066           inside 'if' statements and around binary operators that take 
4067           numeric literals.
4068         + check-webkit-style reports false errors for the / operator
4069           when part of a filename in the #include directive.
4070
4071         * Scripts/modules/cpp_style.py:
4072         Improved indentation checking and space checking around
4073         binary operators. While the checks are still not perfect,
4074         they are clearly better than before.
4075         * Scripts/modules/cpp_style_unittest.py:
4076         Added test cases for the newly supported checks and modified old
4077         test cases to match the new guidelines
4078
4079 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
4080
4081         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
4082
4083         * wx/build/settings.py:
4084
4085 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
4086
4087         Reviewed by David Levin.
4088
4089         Add mod_pywebsocket to test Web Sockets.
4090         http://code.google.com/p/pywebsocket/
4091         https://bugs.webkit.org/show_bug.cgi?id=27490
4092
4093         * pywebsocket/COPYING: Added.
4094         * pywebsocket/MANIFEST.in: Added.
4095         * pywebsocket/README: Added.
4096         * pywebsocket/example/echo_client.py: Added.
4097         * pywebsocket/example/echo_wsh.py: Added.
4098         * pywebsocket/mod_pywebsocket/__init__.py: Added.
4099         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
4100         * pywebsocket/mod_pywebsocket/handshake.py: Added.
4101         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
4102         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
4103         * pywebsocket/mod_pywebsocket/standalone.py: Added.
4104         * pywebsocket/mod_pywebsocket/util.py: Added.
4105         * pywebsocket/setup.py: Added.
4106         * pywebsocket/test/config.py: Added.
4107         * pywebsocket/test/mock.py: Added.
4108         * pywebsocket/test/run_all.py: Added.
4109         * pywebsocket/test/test_dispatch.py: Added.
4110         * pywebsocket/test/test_handshake.py: Added.
4111         * pywebsocket/test/test_mock.py: Added.
4112         * pywebsocket/test/test_msgutil.py: Added.
4113         * pywebsocket/test/test_util.py: Added.
4114         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
4115         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
4116         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
4117         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
4118         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
4119         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
4120         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
4121         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
4122
4123 2009-10-15  James Robinson  <jamesr@google.com>
4124
4125         Reviewed by David Levin.
4126
4127         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
4128
4129         https://bugs.webkit.org/show_bug.cgi?id=30426
4130
4131         * Scripts/modules/cpp_style.py:
4132         * Scripts/modules/cpp_style_unittest.py:
4133
4134 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
4135
4136         Reviewed by Adam Roben.
4137
4138         Fixes <http://webkit.org/b/30411>.
4139         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
4140         
4141         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
4142         building Chromium.
4143
4144         * Scripts/pdevenv:
4145
4146 2009-10-15  Robin Dunn  <robin@alldunn.com>
4147
4148         Reviewed by Kevin Ollivier.
4149
4150         Add Mac package building scripts for wx.
4151         
4152         https://bugs.webkit.org/show_bug.cgi?id=30405
4153
4154         * wx/build/build_utils.py:
4155         * wx/build/settings.py:
4156         * wx/packaging/build-mac-installer.py: Added.
4157
4158 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
4159
4160         Reviewed by Gustavo Noronha.
4161
4162         Enable Web Sockets support when running layout tests.
4163
4164         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4165         (resetDefaultsToConsistentValues):
4166
4167 2009-10-15  Xan Lopez  <xlopez@igalia.com>
4168
4169         Reviewed by Gustavo Noronha.
4170
4171         Need to initialize event.button.button, since in most cases a
4172         button number is not passed as an argument.
4173
4174         * DumpRenderTree/gtk/EventSender.cpp:
4175         (mouseDownCallback):
4176         (mouseUpCallback):
4177
4178 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
4179
4180         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
4181         the OS if none was explicitly set.
4182
4183         * wx/build/settings.py:
4184
4185 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
4186
4187         Reviewed by Timothy Hatcher.
4188
4189         Web Inspector: enable developers extras within inspector layout tests.
4190
4191         https://bugs.webkit.org/show_bug.cgi?id=30014
4192
4193         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4194         (LayoutTestController::showWebInspector):
4195         (LayoutTestController::closeWebInspector):
4196         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4197         (LayoutTestController::showWebInspector):
4198         (LayoutTestController::closeWebInspector):
4199
4200 2009-10-14  José Millán Soto  <jmillan@igalia.com>
4201
4202         Reviewed by Jan Alonzo.
4203
4204         GtkLauncher is using a deprecated signal
4205         https://bugs.webkit.org/show_bug.cgi?id=30364
4206
4207         Modified GtkLauncher to use notify::title signal instead of
4208         deprecated title-changed signal
4209
4210         * GtkLauncher/main.c:
4211         (notify_title_cb):
4212         (create_browser):
4213
4214 2009-10-14  Brady Eidson  <beidson@apple.com>
4215
4216         Reviewed by Sam Weinig.
4217
4218         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
4219         1 - Disables WebHistory
4220         2 - Doesn't make sense in that context anyway.
4221
4222         * DumpRenderTree/win/DumpRenderTree.cpp:
4223         (createWebViewAndOffscreenWindow):
4224
4225 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
4226
4227         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
4228         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
4229
4230         * wx/build/settings.py:
4231         * wx/install-unix-extras:
4232
4233 2009-10-14  Brady Eidson  <beidson@apple.com>
4234
4235         Reviewed by Sam Weinig.
4236
4237         WebKit Win API should provide a delegate interface for global history.
4238         https://bugs.webkit.org/show_bug.cgi?id=29905
4239
4240         * DumpRenderTree/LayoutTestController.cpp:
4241         (LayoutTestController::LayoutTestController):
4242         * DumpRenderTree/LayoutTestController.h:
4243         (LayoutTestController::dumpHistoryDelegateCallbacks):
4244         (LayoutTestController::setDumpHistoryDelegateCallbacks):
4245                 
4246         * DumpRenderTree/win/DumpRenderTree.cpp:
4247         (shouldLogHistoryDelegates):
4248         (runTest):
4249         (createWebViewAndOffscreenWindow):
4250         (main):
4251         * DumpRenderTree/win/DumpRenderTree.vcproj:
4252         
4253         Add the IWebHistoryDelegate to DRT Windows:
4254         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
4255         (wstringFromBSTR):
4256         (HistoryDelegate::HistoryDelegate):
4257         (HistoryDelegate::~HistoryDelegate):
4258         (HistoryDelegate::QueryInterface):
4259         (HistoryDelegate::AddRef):
4260         (HistoryDelegate::Release):
4261         (HistoryDelegate::didNavigateWithNavigationData):
4262         (HistoryDelegate::didPerformClientRedirectFromURL):
4263         (HistoryDelegate::didPerformServerRedirectFromURL):
4264         (HistoryDelegate::updateHistoryTitle):
4265         (HistoryDelegate::populateVisitedLinksForWebView):
4266         * DumpRenderTree/win/HistoryDelegate.h: Added.
4267
4268         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4269         (LayoutTestController::removeAllVisitedLinks):
4270
4271 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
4272
4273         Reviewed by Simon Hausmann.
4274
4275         [Qt] Implement support for setPOSIXLocale on Qt.
4276         https://bugs.webkit.org/show_bug.cgi?id=30268 
4277  
4278         * DumpRenderTree/qt/DumpRenderTree.cpp:
4279         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4280         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4281         (LayoutTestController::setPOSIXLocale):
4282         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4283
4284 2009-10-13  Stephanie Lewis  <slewis@apple.com>
4285
4286         Unreviewed, adding myself to reviewers list.
4287
4288         * Scripts/modules/committers.py:
4289
4290 2009-10-13  Stephanie Lewis  <slewis@apple.com>
4291
4292         Reviewed by Mark Rowe.
4293
4294         Fix null assignment so root tests work again.
4295
4296         * Scripts/webkitdirs.pm:
4297
4298 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
4299
4300         Reviewed by Simon Hausmann.
4301
4302         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
4303         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
4304         This is done in preparation of implementing missing features in DRT.
4305         No functionality changes made yet.
4306
4307         * DumpRenderTree/qt/DumpRenderTree.cpp:
4308         * DumpRenderTree/qt/DumpRenderTree.pro:
4309         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
4310         (EventSender::EventSender):
4311         (EventSender::mouseDown):
4312         (EventSender::mouseUp):
4313         (EventSender::mouseMoveTo):
4314         (EventSender::leapForward):
4315         (EventSender::keyDown):
4316         (EventSender::contextClick):
4317         (EventSender::scheduleAsynchronousClick):
4318         (EventSender::frameUnderMouse):
4319         * DumpRenderTree/qt/EventSenderQt.h: Added.
4320         (EventSender::clearKillRing):
4321         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
4322         (LayoutTestController::LayoutTestController):
4323         (LayoutTestController::reset):
4324         (LayoutTestController::processWork):
4325         (LayoutTestController::maybeDump):
4326         (LayoutTestController::waitUntilDone):
4327         (LayoutTestController::notifyDone):
4328         (LayoutTestController::windowCount):
4329         (LayoutTestController::clearBackForwardList):
4330         (LayoutTestController::dumpEditingCallbacks):
4331         (LayoutTestController::dumpResourceLoadCallbacks):
4332         (LayoutTestController::queueBackNavigation):
4333         (LayoutTestController::queueForwardNavigation):
4334         (LayoutTestController::queueLoad):
4335         (LayoutTestController::queueReload):
4336         (LayoutTestController::queueScript):
4337         (LayoutTestController::provisionalLoad):
4338         (LayoutTestController::timerEvent):
4339         (LayoutTestController::encodeHostName):
4340         (LayoutTestController::decodeHostName):
4341         (LayoutTestController::setJavaScriptProfilingEnabled):
4342         (LayoutTestController::setFixedContentsSize):
4343         (LayoutTestController::setPrivateBrowsingEnabled):
4344         (LayoutTestController::setPopupBlockingEnabled):
4345         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
4346         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
4347         (LayoutTestController::numberOfActiveAnimations):
4348         (LayoutTestController::disableImageLoading):
4349         (LayoutTestController::dispatchPendingLoadRequests):
4350         (LayoutTestController::setDatabaseQuota):
4351         (LayoutTestController::clearAllDatabases):
4352         (LayoutTestController::whiteListAccessFromOrigin):
4353         (LayoutTestController::waitForPolicyDelegate):
4354         (LayoutTestController::overridePreference):
4355         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
4356         (LayoutTestController::isLoading):
4357         (LayoutTestController::setLoading):
4358         (LayoutTestController::shouldDumpAsText):
4359         (LayoutTestController::shouldDumpBackForwardList):
4360         (LayoutTestController::shouldDumpChildrenAsText):
4361         (LayoutTestController::shouldDumpDatabaseCallbacks):
4362         (LayoutTestController::shouldDumpStatusCallbacks):
4363         (LayoutTestController::shouldWaitUntilDone):
4364         (LayoutTestController::canOpenWindows):
4365         (LayoutTestController::shouldDumpTitleChanges):
4366         (LayoutTestController::waitForPolicy):
4367        &