* Scripts/do-webcore-rename: Yet more renaming ideas.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-01-02  Sam Weinig  <sam@webkit.org>
2
3         * Scripts/do-webcore-rename: Yet more renaming ideas.
4
5 2008-01-02  Darin Adler  <darin@apple.com>
6
7         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
8
9 2008-01-02  Alice Liu  <alice.liu@apple.com>
10
11         Reviewed by Sam Weinig.
12
13         fixing assertion hit with editing/selection/move-begin-end.html
14
15         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
16         * DumpRenderTree/win/DumpRenderTree.vcproj:
17         * DumpRenderTree/win/EventSender.cpp:
18         (keyDownCallback):
19         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
20
21 2008-01-02  Darin Adler  <darin@apple.com>
22
23         * Scripts/do-webcore-rename: Some more name change plans.
24
25 2008-01-02  Alice Liu  <alice.liu@apple.com>
26
27         Reviewed by Maciej.
28
29         Added handling for page up and page down in EventSender
30
31         * DumpRenderTree/mac/EventSendingController.mm:
32         (-[EventSendingController keyDown:withModifiers:]):
33         * DumpRenderTree/win/EventSender.cpp:
34         (keyDownCallback):
35
36 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
37
38         Reviewed by Darin.
39
40         Fix fast/events/arrow-keys-on-body.html for real.
41
42         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
43
44 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
45
46         Reviewed by Darin.
47
48         http://bugs.webkit.org/show_bug.cgi?id=16674
49         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
50
51         * Scripts/run-launcher:
52
53 2007-12-31  Darin Adler  <darin@apple.com>
54
55         Suggested by Antti.
56
57         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
58         we get it installed on the build bots.
59
60 2007-12-30  Eric Seidel  <eric@webkit.org>
61
62         Reviewed by Sam.
63
64         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
65
66 2007-12-29  Darin Adler  <darin@apple.com>
67
68         Reviewed by Oliver.
69
70         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
71           leak bot shows createCStringFromNPVariant result leaking
72
73         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
74         (pluginInvoke): Added a missing free.
75
76 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
77
78         Reviewed by Alp Toker.
79
80         http://bugs.webkit.org/show_bug.cgi?id=16390
81         Use autotools or GNU make as the build system for the GTK port
82
83         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
84         * GNUmakefile.am: Added.
85
86 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
87
88         Reviewed by Oliver.
89
90         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
91
92         * DumpRenderTree/win/EventSender.cpp:
93         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
94         of 1, even though WebKit currently ignores it.
95
96 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
97
98         wx buildbot fix. Update libpng dl script to the latest version.
99
100         * wx/install-unix-extras:
101
102 2007-12-22  Antti Koivisto  <antti@apple.com>
103
104         Fix a typo.
105
106         * Scripts/webkitdirs.pm:
107
108 2007-12-21  Sam Weinig  <sam@webkit.org>
109
110         Reviewed by Mark Rowe.
111
112         - Disable the back/forward cache using the new WebPreferences API
113           instead of through the BackForwardList.  This makes us match what
114           we do on Windows.
115
116         * DumpRenderTree/mac/DumpRenderTree.mm:
117         (createWebViewAndOffscreenWindow):
118         (setDefaultsToConsistentValuesForTesting):
119
120 2007-12-21  Dan Bernstein  <mitz@apple.com>
121
122         Reviewed by Mark Rowe.
123
124         - disable the back/forward cache in Windows DumpRenderTree. It is
125           already disabled in Mac DumpRenderTree.
126
127         * DumpRenderTree/win/DumpRenderTree.cpp:
128         (initializePreferences):
129
130 2007-12-13  Antti Koivisto  <antti@apple.com>
131
132         Reviewed by Darin and Steve.
133         
134         - check for QuickTime SDK on Windows.
135         - build media support on Windows by default
136
137         * Scripts/build-webkit:
138         * Scripts/webkitdirs.pm:
139
140 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
141
142         Build script fix for buildbot.
143
144         * wx/build-wxwebkit:
145
146 2007-12-20  Eric Seidel  <eric@webkit.org>
147
148         Reviewed by mjs.
149
150         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
151
152 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
153
154         Reviewed by Steve.
155
156         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
157         WebKit.
158
159         - Drosera and Safari need to use the same ProgIDs in order for
160         CoCreateInstance to work properly.  The most robust way to do this is
161         for WebKit to dynamically publish those ProgIDs.
162
163         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
164         (DebuggerClient::createWebViewWithRequest):
165         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
166         statics.
167         (Drosera::initUI):
168         (Drosera::attach):
169         (Drosera::attemptToCreateServerConnection):
170         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
171         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
172         make use of the published ProgIDs.
173         (ServerConnection::attemptToCreateServerConnection):
174
175 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
176
177         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
178         - Build bot and leak fix.
179
180         * DumpRenderTree/LayoutTestController.cpp:
181         (pathToLocalResourceCallback):
182
183 2007-12-19  David Kilzer  <ddkilzer@apple.com>
184
185         Make svn-apply/svn-unapply work with patches from git-format-patch.
186
187         Reviewed by Darin.
188
189         * Scripts/svn-apply:
190         (patch): If 'Index:' can't be found in the text passed in, print it
191         out with a warning and return early.
192         * Scripts/svn-unapply:
193         (patch): Ditto.
194
195 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
196
197         Reviewed by Alp Toker.
198
199         Build related fixes.
200
201         * wx/build-wxwebkit:
202         - Check to make sure the user is running a supported wx port
203         - More robust checks for Cygwin
204         - Only run install-unix-extras on Mac, it's not the right solution
205           for Linux distros.
206         - Remove outdated Linux instructions after successful build
207         - Clean Bakefile-generated files during a clean operation
208
209 2007-12-18  Darin Adler  <darin@apple.com>
210
211         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
212
213 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
214
215         Add script to run Drosera as part of the nightly.
216         
217         Reviewed by Kevin M.
218
219         * Scripts/run-drosera.cmd: Added.
220
221 2007-12-18  Darin Adler  <darin@apple.com>
222
223         * Scripts/do-webcore-rename: Remove a stray K.
224
225 2007-12-18  Darin Adler  <darin@apple.com>
226
227         * Scripts/do-webcore-rename: Plan more renaming.
228
229 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
230
231         Reviewed by Alp Toker.
232
233         http://bugs.webkit.org/show_bug.cgi?id=16042
234         [GTK] Eliminate webkit_init()
235
236         Moving webkit initialization to WebView class init.
237
238         * DumpRenderTree/gtk/DumpRenderTree.cpp:
239         (main):
240         * GtkLauncher/main.c:
241         (main):
242
243 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
244
245         Reviewed by Alp Toker.
246
247         http://bugs.webkit.org/show_bug.cgi?id=13542
248         gdklauncher doesnt change URL in adress GTKEntry.
249
250         * GtkLauncher/main.c:
251         (load_commit_cb): added
252         (title_change_cb):
253         (create_browser):
254
255 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
256
257         Reviewed by Adam Roben.
258
259         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
260
261         * FindSafari/FindSafari.cpp:
262         (_tmain):
263
264 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
265
266         Reviewed by Adam Roben.
267
268         http://bugs.webkit.org/show_bug.cgi?id=16315
269         FindSafari needs a path-only option.
270
271         * FindSafari/FindSafari.cpp:
272         (_tmain):
273
274 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
275
276         Reviewed by Darin.
277
278         http://bugs.webkit.org/show_bug.cgi?id=16462
279         REGRESSION: access keys broken on Windows
280
281         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
282         if Alt is pressed.
283
284 2007-12-15  Sam Weinig  <sam@webkit.org>
285
286         Reviewed by Mark Rowe.
287
288         Fix urlSuitableForTestResult to correctly identify wstring::npos as
289         the case when wstring.find doesn't find anything.
290
291         * DumpRenderTree/win/DumpRenderTree.cpp:
292         (urlSuitableForTestResult):
293
294 2007-12-15  Alp Toker  <alp@atoker.com>
295
296         GTK+ DRT build fix for GLib < 2.14.
297
298         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
299         (LayoutTestController::setWaitToDump):
300
301 2007-12-05  Mark Rowe  <mrowe@apple.com>
302
303         Reviewed by Alp Toker.
304
305         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
306         many layout tests from hanging while waiting on user responses to dialogs.
307
308         * DumpRenderTree/gtk/DumpRenderTree.cpp:
309         (invalidateAnyPreviousWaitToDumpWatchdog):
310         (webViewScriptAlert):
311         (webViewScriptPrompt):
312         (webViewScriptConfirm):
313         (main):
314         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
315         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
316         (waitToDumpWatchdogFired):
317         (LayoutTestController::setWaitToDump):
318
319 2007-12-05  Mark Rowe  <mrowe@apple.com>
320
321         Reviewed by Alp Toker.
322
323         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
324
325         * DumpRenderTree/gtk/DumpRenderTree.cpp:
326         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
327         (dump):
328         (runTest):
329         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
330         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
331         work queue is empty.
332         (webViewWindowObjectCleared): Set up window.layoutTestController.
333         (webViewConsoleMessage): Match the console message format expected by the layout test results.
334         (main): Hook up the new signals.
335         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
336         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
337         dumping multiple times.
338         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
339         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
340
341 2007-12-14  Anders Carlsson  <andersca@apple.com>
342
343         Reviewed by Brady.
344
345         Assert that a web frame that's loading a resource always has either a data source or 
346         a provisional data source.
347         
348         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
349         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
350
351 2007-12-14  Darin Adler  <darin@apple.com>
352
353         - fix mistake causing nearly all tests to fail on Windows
354
355         * DumpRenderTree/win/UIDelegate.cpp:
356         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
357         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
358
359         * DumpRenderTree/mac/UIDelegate.mm:
360         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
361         than passing the entire message.
362
363 2007-12-14  Darin Adler  <darin@apple.com>
364
365         - fix Tiger build
366
367         * DumpRenderTree/mac/UIDelegate.mm:
368         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
369         new-to-Leopard methods.
370
371 2007-12-14  Darin Adler  <darin@apple.com>
372
373         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
374         since it now triggers unwanted icon loading. We only had it because we implemented "all"
375         delegate methods here.
376
377 2007-12-14  Anders Carlsson  <andersca@apple.com>
378
379         Reviewed by Darin and Geoff.
380
381         <rdar://problem/5619295> 
382         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
383         
384         Add property getting methods to the plug-in.
385         
386         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
387         (pluginInvoke):
388
389 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
390
391         Reviewed by Darin.
392
393         - Layout test fix for mac. When dumped to the console local file paths
394         now only show the name of the resource not the whole path.  This is to
395         make the results machine and OS independent.
396
397         * DumpRenderTree/mac/UIDelegate.mm:
398         (-[UIDelegate webView:addMessageToConsole:]):
399
400 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
401
402         Reviewed by Adam.
403
404         - Layout tests fix.  We need a way to remove machine-dependent
405         information from paths in layout test results. The UIDelegate now does
406         this.
407
408         * DumpRenderTree/DumpRenderTree.h:
409         * DumpRenderTree/win/DumpRenderTree.cpp:
410         (urlSuitableForTestResult):
411         * DumpRenderTree/win/DumpRenderTreeWin.h:
412         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
413         * DumpRenderTree/win/UIDelegate.cpp:
414         (UIDelegate::webViewAddMessageToConsole):
415
416 2007-12-13  Alp Toker  <alp@atoker.com>
417
418         Build fix for DRT breakage introduced in r28690.
419
420         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
421         (LayoutTestController::pathToLocalResource):
422
423 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
424
425         Reviewed by Alice and Sam.
426
427         - <rdar://5621435> Need a way to specify local resources (being loaded
428         from HTTP tests) on Windows.
429         - Implemented pathToLocalResource which exposes the functionality of
430         converting a given unix path to the correct location on Windows.
431
432         * DumpRenderTree/LayoutTestController.cpp:
433         (pathToLocalResourceCallback):
434         (LayoutTestController::staticFunctions):
435         * DumpRenderTree/LayoutTestController.h:
436         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
437         (LayoutTestController::pathToLocalResource):
438         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
439         (LayoutTestController::pathToLocalResource):
440
441 2007-12-12  Anders Carlsson  <andersca@apple.com>
442
443         Reviewed by Sam.
444
445         <rdar://problem/5132003>
446         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
447
448         * DumpRenderTree/win/DumpRenderTree.cpp:
449         (main):
450         Set the resource load delegate.
451         
452         * DumpRenderTree/win/DumpRenderTree.vcproj:
453         
454         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
455         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
456
457 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
458
459         Reviewed by Adam Roben.
460
461         Fix conversion from double to LPARAM in dispatchMessage().
462
463         * DumpRenderTree/win/EventSender.cpp:
464         (dispatchMessageCallback):
465
466 2007-12-11  Dan Bernstein  <mitz@apple.com>
467
468         Reviewed by Mark Rowe and Sam Weinig too!
469
470         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
471           fonts DumpRenderTree registers.
472
473         * DumpRenderTree/win/DumpRenderTree.cpp:
474         (initialize):
475
476 2007-12-11  Brady Eidson  <beidson@apple.com>
477
478         Reviewed by Anders
479
480         Make DumpRenderTree on mac use its own path for Databases testing
481
482         * DumpRenderTree/mac/DumpRenderTree.mm:
483         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
484           for future DRT-only use, then use it to construct the Databases path and set that default
485
486 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
487
488         Reviewed by Darin.
489
490         <rdar://problem/5535636>
491         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
492
493         http://bugs.webkit.org/show_bug.cgi?id=13916
494         JavaScript detects Tab as a character input on a textfield validation
495
496         * DumpRenderTree/mac/EventSendingController.mm:
497         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
498         Dispatch a keyup to better match what happens when a key is physically pressed.
499
500         * DumpRenderTree/win/EventSender.cpp:
501         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
502         returning from keyDown().
503         (getConstantCallback): Fixed a couple copy/paste mistakes.
504
505 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
506
507         Reviewed by Oliver.
508
509         - <rdar://5599845> Drosera: Does not show loal files in the file list
510         on the left side.
511
512         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
513         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
514         so the open source community can build.
515
516 2007-12-10  Brady Eidson  <beidson@apple.com>
517
518         Rubberstamped by Sam Weinig
519
520         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
521
522         * DumpRenderTree/mac/UIDelegate.mm:
523         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
524         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
525
526 2007-12-08  Oliver Hunt  <oliver@apple.com>
527
528         Reviewed by Sam W.
529
530         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
531         
532         Fixes <rdar://problem/5620249> Must disable SVG animation
533         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
534         
535         In order to allow finer grained control over the set of SVG features
536         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
537         distinct flags:
538         ENABLE_SVG_ANIMATION
539         ENABLE_SVG_FILTERS
540         ENABLE_SVG_FONTS
541         ENABLE_SVG_AS_IMAGE
542         ENABLE_SVG_USE
543         
544         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
545         
546         Script handles all the new build flags, and allows --svg-experimental
547         to automatically enable all features.
548
549         * Scripts/build-webkit:
550
551 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
552
553         Fix version parsing.
554
555         Rubber-stamped by Oliver.
556
557         * Drosera/win/Drosera.vcproj/auto-version.sh:
558
559 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
560
561         Build modifications for Drosera.
562
563         Reviewed by Adam.
564
565         * Drosera/DroseraWin.make: Added.
566         * Drosera/win/Drosera.vcproj/Drosera.rc:
567         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
568         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
569         * Drosera/win/Drosera.vcproj/VERSION: Added.
570         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
571
572 2007-12-06  Adam Roben  <aroben@apple.com>
573
574         Explicitly turn on the Mac font ascent hack on Windows
575
576         This keeps our font metrics matching those from Mac.
577
578         Reviewed by Hyatt.
579
580         * DumpRenderTree/win/DumpRenderTree.cpp:
581         (main):
582
583 2007-12-06  Anders Carlsson  <andersca@apple.com>
584
585         Rename main.c to main.cpp here too.
586         
587         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
588
589 2007-12-06  Sam Weinig  <sam@webkit.org>
590
591         Rubber stamped by Geoff.
592
593         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
594
595 2007-12-06  Darin Adler  <darin@apple.com>
596
597         * Scripts/do-webcore-rename: Some more renaming plans.
598
599 2007-12-06  Anders Carlsson  <andersca@apple.com>
600
601         Restore implementation of testGetIntIdentifier that was accidentally
602         removed somehow (possibly when I made PluginObject be a cpp file).
603         
604         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
605         (pluginInvoke):
606
607 2007-12-05  Anders Carlsson  <andersca@apple.com>
608
609         Make the entry points extern "C".
610         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
611         
612 2007-12-05  Anders Carlsson  <andersca@apple.com>
613
614         C++ warning fixes.
615         
616         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
617         (NPP_New):
618         (NPP_Destroy):
619         (NPP_SetWindow):
620         (NPP_NewStream):
621         (NPP_HandleEvent):
622         (NPP_URLNotify):
623         (NPP_GetValue):
624
625 2007-12-05  Anders Carlsson  <andersca@apple.com>
626
627         Add the .cpp files to the TestNetscapePlugIn target.
628
629         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
630
631 2007-12-05  Anders Carlsson  <andersca@apple.com>
632
633         Reviewed by Geoff.
634         
635         Rename the TestNetscapePlugIn .c files to be .cpp.
636
637         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
638         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
639         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
640         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
641         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
642         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
643         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
644         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
645
646 2007-12-05  Adam Roben  <aroben@apple.com>
647
648         Fix case of keypresses from the Windows implementation of eventSender.keyDown
649
650         This fixes several regression tests.
651
652         Reviewed by Alice.
653
654         * DumpRenderTree/win/EventSender.cpp:
655         (keyDownCallback): Virtual keycodes for ASCII characters are always
656         uppercase, so we need to check the case of the original character
657         passed in to eventSender.keyDown.
658
659 2007-12-05  Adam Roben  <aroben@apple.com>
660
661         Learn from Tim's mistakes
662
663         * DumpRenderTree/win/DumpRenderTree.cpp:
664         (runTest): Reset the authorAndUserStylesEnabled preference for each
665         test.
666
667 2007-12-05  Alp Toker  <alp@atoker.com>
668
669         Reviewed by Mark Rowe.
670
671         Initialize GTK+ and WebKit so the tests can run.
672
673         Reorganize the headers a little.
674
675         * DumpRenderTree/gtk/DumpRenderTree.cpp:
676         (main):
677
678 2007-12-04  Anders Carlsson  <andersca@apple.com>
679
680         Remove IWebScriptScope include.
681         
682         * Drosera/win/DebuggerDocumentPlatform.cpp:
683
684 2007-12-04  Sam Weinig  <sam@webkit.org>
685
686         Rubber stamped by Mark Rowe.
687
688         Define CF as platform for mac and revert r28409
689
690         * DumpRenderTree/DumpRenderTree.h:
691         * DumpRenderTree/mac/DumpRenderTreeMac.h:
692
693 2007-12-04  Sam Weinig  <sam@webkit.org>
694
695         Define CF as platform for windows.
696
697         Reviewed by Adam Roben.
698
699         * DumpRenderTree/win/DumpRenderTreeWin.h:
700
701 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
702
703         Reviewed by Adam and Darin.
704
705         - Removed a needless BSTR cleanup.
706
707         * Drosera/win/DebuggerDocumentPlatform.cpp:
708         (DebuggerDocument::getPlatformCurrentFunctionStack):
709
710 2007-11-27  Adam Roben  <aroben@apple.com>
711
712         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
713
714         Reviewed by Maciej.
715
716         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
717         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
718
719 2007-12-04  Alp Toker  <alp@atoker.com>
720
721         Prospective Win DRT build fix.
722
723         * DumpRenderTree/DumpRenderTree.h:
724
725 2007-12-04  Alp Toker  <alp@atoker.com>
726
727         Fix a clobbered copyright header.
728
729         * DumpRenderTree/gtk/DumpRenderTree.cpp:
730
731 2007-12-04  Xan Lopez  <xan@gnome.org>
732
733         Reviewed by Alp Toker.
734
735         http://bugs.webkit.org/show_bug.cgi?id=15561
736         GTK port needs DumpRenderTree implementation
737
738         Start work on the GTK+ DRT.
739
740         This does not work yet, and there are a few lingering style issues
741         (nothing major) but this patch has been stuck in the bug tracker for
742         too long already.
743
744         * DumpRenderTree/DumpRenderTree.h:
745         * DumpRenderTree/gtk: Added.
746         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
747         (autocorrectURL):
748         (shouldLogFrameLoadDelegates):
749         (dumpFrameScrollPosition):
750         (displayWebView):
751         (appendString):
752         (dumpFramesAsText):
753         (dumpRenderTreeAsText):
754         (dump):
755         (runTest):
756         (main):
757         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
758         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
759         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
760         (GCController::collect):
761         (GCController::collectOnAlternateThread):
762         (GCController::getJSObjectCount):
763         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
764         (LayoutTestController::~LayoutTestController):
765         (LayoutTestController::addDisallowedURL):
766         (LayoutTestController::clearBackForwardList):
767         (LayoutTestController::copyDecodedHostName):
768         (LayoutTestController::copyEncodedHostName):
769         (LayoutTestController::display):
770         (LayoutTestController::keepWebHistory):
771         (LayoutTestController::notifyDone):
772         (LayoutTestController::queueBackNavigation):
773         (LayoutTestController::queueForwardNavigation):
774         (LayoutTestController::queueLoad):
775         (LayoutTestController::queueReload):
776         (LayoutTestController::queueScript):
777         (LayoutTestController::setAcceptsEditing):
778         (LayoutTestController::setCustomPolicyDelegate):
779         (LayoutTestController::setMainFrameIsFirstResponder):
780         (LayoutTestController::setTabKeyCyclesThroughElements):
781         (LayoutTestController::setUseDashboardCompatibilityMode):
782         (LayoutTestController::setUserStyleSheetEnabled):
783         (LayoutTestController::setUserStyleSheetLocation):
784         (LayoutTestController::setWindowIsKey):
785         (LayoutTestController::setWaitToDump):
786         (LayoutTestController::windowCount):
787         (LayoutTestController::setPrivateBrowsingEnabled):
788         (LayoutTestController::setAuthorAndUserStylesEnabled):
789         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
790         (JSStringCopyUTF8CString):
791         (LoadItem::invoke):
792         (ReloadItem::invoke):
793         (ScriptItem::invoke):
794         (BackForwardItem::invoke):
795
796 2007-12-03  Sam Weinig  <sam@webkit.org>
797
798         Move JavaScriptCore thread testing code to pthread specific directory
799         and remove the dependance on CoreFoundation by using WTF::HashSet.
800
801         Reviewed by Geoff and Oliver.
802
803         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
804         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
805         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
806         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
807         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
808         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
809         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
810         * DumpRenderTree/pthreads: Added.
811         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
812         (javaScriptThreads):
813         (runJavaScriptThread):
814         (startJavaScriptThreads):
815         (stopJavaScriptThreads):
816
817 2007-12-03  Andrew Bonventre  <andybons@google.com>
818
819         Reviewed by Darin Adler.
820
821         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
822         Symbol lookup menu broken in debugger view
823
824         * Drosera/debugger.js: Fixed javascript error where document property
825         should have been used instead of contentDocument in switchFunction that
826         was breaking the select symbol dropdown menu.  This is because
827         window.frames will return a Window object and not a frame object like
828         the author was originally expecting.
829
830 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
831
832         Reviewed by Adam.
833
834         - <rdar://5618942> Drosera: Console window does not process everything
835         correctly.
836         - <rdar://5619005> Drosera: could be sped up by moving the 
837         WebScriptScope stuff into the WebScriptCallFrame.
838         - Now the console can correctly process objects and does not receive
839         notifications from JavaScriptCore about the JavaScript in Drosera's
840         own process.
841
842         * Drosera/win/DebuggerDocumentPlatform.cpp:
843         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
844         (DebuggerDocument::platformValueForScopeVariableNamed):
845
846 2007-12-03  Stephanie  <slewis@apple.com>
847
848         Reviewed by Darin.
849
850         Check to see if we are building a debug root
851
852         * Scripts/check-for-global-initializers: 
853
854 2007-12-03  Dan Bernstein  <mitz@apple.com>
855
856         Reviewed by Darin Adler.
857
858         - added a testGetIntIdentifier() method to TestNetscapePlugIn
859
860         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
861         (pluginInvoke):
862
863 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
864
865         Reviewed by Oliver.
866
867         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
868         in a more fine-grained manner than eventSender.keyDown().
869
870         * DumpRenderTree/win/EventSender.cpp:
871         (getConstantCallback):
872         (dispatchMessageCallback):
873
874 2007-12-02  Darin Adler  <darin@apple.com>
875
876         * Scripts/do-webcore-rename: More planned renaming.
877
878 2007-12-02  Sam Weinig  <sam@webkit.org>
879
880         Rubber stamped by Anders.
881
882         Use [NSURL absoluteString] instead of [NSURL description] in order to get
883         more uniform results cross platform.
884
885         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
886         (-[NSURL _drt_descriptionSuitableForTestResult]):
887
888 2007-12-02  Sam Weinig  <sam@webkit.org>
889
890         Rubber stamped by Niko.
891
892         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
893
894         * DumpRenderTree/win/DumpRenderTree.cpp:
895         * DumpRenderTree/win/DumpRenderTree.vcproj:
896         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
897         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
898         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
899         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
900
901 2007-12-01  Alp Toker  <alp@atoker.com>
902
903         Reviewed by Adam Roben.
904
905         Make use of the newly introduced webkit.h convenience header.
906
907         * GtkLauncher/main.c:
908
909 2007-12-01  Adam Treat  <treat@kde.org>
910
911         Reviewed by Simon.
912
913         * Check to see if the directory exists and exit if not.
914
915         * DumpRenderTree/qt/main.cpp:
916         (main):
917
918 2007-12-01  Adam Treat  <treat@kde.org>
919
920         Reviewed by Simon.
921
922         * Don't hide symbols when in Debug mode
923         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
924
925
926         * DumpRenderTree/qt/main.cpp:
927         (messageHandler):
928
929 2007-11-30  Alp Toker  <alp@atoker.com>
930
931         Reviewed by Adam Roben.
932
933         http://bugs.webkit.org/show_bug.cgi?id=15691
934         [GTK] Public API does not follow GTK+ conventions
935
936         Refactor the WebKit/GTK+ public API. Changes:
937           WebKitPage -> WebKitWebView
938           WebKitFrame -> WebKitWebFrame
939
940         Public API source and header names have been updated to mirror the API
941         changes.
942
943         The API is now kept in WebKit/gtk/WebView to match other ports in the
944         same class such as Mac and Win.
945
946         * GtkLauncher/main.c:
947         (activate_uri_entry_cb):
948         (link_hover_cb):
949         (title_change_cb):
950         (progress_change_cb):
951         (go_back_cb):
952         (go_forward_cb):
953         (create_browser):
954         (main):
955
956 2007-11-30  Adam Roben  <aroben@apple.com>
957
958         Hopefully the final build fix
959
960         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
961         pull in WTF's assertion/logging functions.
962
963 2007-11-30  Adam Roben  <aroben@apple.com>
964
965         Another build fix
966
967         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
968         WebKit.lib.
969
970 2007-11-30  Adam Roben  <aroben@apple.com>
971
972         Debug build fix
973
974         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
975         configuration.
976         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
977         projects.
978         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
979         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
980         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
981
982 2007-11-30  Sam Weinig  <sam@webkit.org>
983
984         Reviewed by Adam Roben.
985
986         Fix drawSelectionRect to actually draw the selection rect.
987
988         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
989         (drawSelectionRect):
990
991 2007-11-30  Darin Adler  <darin@apple.com>
992
993         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
994
995 2007-11-30  Darin Adler  <darin@apple.com>
996
997         * Scripts/do-webcore-rename: Get ready for some future renaming.
998
999 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1000
1001         Reviewed by Adam.
1002
1003         - Removed some unnecessary functions and changed an unused return type. 
1004
1005         * Drosera/win/DebuggerClient.cpp:
1006         (registerConsoleClass):
1007         * Drosera/win/DebuggerClient.h:
1008         * Drosera/win/Drosera.cpp:
1009         (registerDroseraClass):
1010
1011 2007-11-28  Alp Toker  <alp@atoker.com>
1012
1013         Reviewed by Timothy Hatcher.
1014
1015         http://bugs.webkit.org/show_bug.cgi?id=16174
1016         [GTK] Use "URI" not "URL" in public API
1017
1018         Replace use of the term "URL" with "URI" in public headers,
1019         documentation and some internal code to match GLib/GTK+ convention.
1020
1021         This is now mentioned in the API guidelines:
1022           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
1023
1024         * GtkLauncher/main.c:
1025         (activate_uri_entry_cb):
1026         (title_change_cb):
1027         (create_toolbar):
1028         (main):
1029
1030 2007-11-29  Anders Carlsson  <andersca@apple.com>
1031
1032         Reviewed by Sam.
1033
1034         <rdar://problem/5230478>
1035         FrameLoadDelegate callbacks are not dumped in DRT.
1036         
1037         * DumpRenderTree/win/DumpRenderTree.cpp:
1038         (shouldLogFrameLoadDelegates):
1039         (runTest):
1040         (main):
1041         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1042         (BSTRtoString):
1043         (descriptionSuitableForTestResult):
1044         (FrameLoadDelegate::QueryInterface):
1045         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1046         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1047         (FrameLoadDelegate::didCommitLoadForFrame):
1048         (FrameLoadDelegate::didFinishLoadForFrame):
1049         (FrameLoadDelegate::willCloseFrame):
1050         (FrameLoadDelegate::didClearWindowObject):
1051         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1052         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1053         * DumpRenderTree/win/FrameLoaderDelegate.h:
1054         (FrameLoadDelegate::windowScriptObjectAvailable):
1055         (FrameLoadDelegate::didFirstLayoutInFrame):
1056
1057 2007-11-29  Sam Weinig  <sam@webkit.org>
1058
1059         Reviewed by Anders.
1060
1061         Add database quota UIDelegates methods to DRT UIDelegate.
1062
1063         * DumpRenderTree/mac/UIDelegate.mm:
1064         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1065         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
1066
1067 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1068
1069         Reviewed by Sam.
1070
1071         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
1072         dying and vice versa.
1073         - This fix will allow Drosera and Safari to reconnect if either of them
1074         closes correctly, but does not fix the case where one of them dies
1075         silently.
1076
1077         * Drosera/win/ServerConnection.cpp:
1078         (ServerConnection::attemptToCreateServerConnection): Added a safety
1079         check, because it's possilbe to try to connect to a server that's dying.
1080         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
1081         the server has died.
1082         * Drosera/win/ServerConnection.h: Added the new function and removed
1083         an unnecessary member.
1084
1085 2007-11-29  Anders Carlsson  <andersca@apple.com>
1086
1087         * DumpRenderTree/win/DumpRenderTree.vcproj:
1088         Add shlwapi.lib to all configurations.
1089
1090 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1091
1092         - Build fix.  Added additional includes for VS Express to the Release
1093         project.
1094
1095         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1096
1097 2007-11-29  Anders Carlsson  <andersca@apple.com>
1098
1099         Reviewed by Adam.
1100
1101         <rdar://problem/5132005>
1102         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
1103         
1104         * DumpRenderTree/win/DumpRenderTree.vcproj:
1105         Add shlwapi.lib
1106         
1107         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1108         (LayoutTestController::setUserStyleSheetEnabled):
1109         Implement this.
1110         
1111         (appendComponentToPath):
1112         New method which wraps the Win32 API PathAppend.
1113         
1114         (followShortcuts):
1115         New method which checks if a file points to a shortcut and
1116         follows the shortcut.
1117         
1118         (resolveCygwinPath):
1119         New method that takes a cygwin unix-style path and returns the Win32 path.
1120         
1121         (cfStringRefToWString):
1122         
1123         (LayoutTestController::setUserStyleSheetLocation):
1124         Implement this.
1125
1126 2007-11-29  Alice Liu  <alice.liu@apple.com>
1127
1128         Reviewed by Adam.
1129
1130         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
1131
1132         * DumpRenderTree/win/EventSender.cpp:
1133         (keyDownCallback):
1134         uppercase letters were being sent as lowercase letters without the shift key down.
1135
1136 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1137
1138         - Windows build fix. VS express needs some love.
1139
1140         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1141
1142 2007-11-28  Darin Adler  <darin@apple.com>
1143
1144         Reviewed by Adam Roben.
1145
1146         * DumpRenderTree/mac/EventSendingController.mm:
1147         (-[EventSendingController keyDown:withModifiers:]):
1148         Send capital letters through as lowercase letters with the shift key down
1149         rather than sending them as if they were highly unusual "capital letter keys".
1150
1151         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1152         where you need to update results and more tests are failing than before.
1153
1154 2007-11-28  Anders Carlsson  <andersca@apple.com>
1155
1156         Reviewed by Darin.
1157
1158         <rdar://problem/5132001>
1159         contextClick is not implemented in DRT on Windows.
1160         
1161         * DumpRenderTree/win/EventSender.cpp:
1162         (contextClickCallback):
1163         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1164         by a WM_RBUTTONUP message.
1165         
1166         * DumpRenderTree/win/UIDelegate.cpp:
1167         (UIDelegate::hasCustomMenuImplementation):
1168         (UIDelegate::trackCustomPopupMenu):
1169         * DumpRenderTree/win/UIDelegate.h:
1170         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1171         menu from being shown (and causing the DRT to hang).
1172
1173 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1174
1175         Reviewed by Darin.
1176
1177         Fix DumpRenderTree ObjC bug comparing strings.
1178
1179         * DumpRenderTree/mac/ObjCController.m:
1180         (-[ObjCController identityIsEqual::]): Compare strings with string
1181         equality instead of identiy equality.
1182
1183 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1184
1185         Reviewed by Sam.
1186
1187         Reset the authorAndUserStylesEnabled preference
1188         back to YES for each test. Fixes the broken tests.
1189
1190         * DumpRenderTree/mac/DumpRenderTree.mm:
1191         (resetWebViewToConsistentStateBeforeTesting):
1192
1193 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1194
1195         Reviewed by Adam.
1196
1197         - Drosera now displays the console window, although it cannot currently
1198         process JavaScript.
1199
1200         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1201         (registerConsoleClass): Implemented.
1202         (consoleWndProc): Implemented.
1203         (DebuggerClient::onSize): Implemented.
1204         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1205         new window.
1206         * Drosera/win/DebuggerClient.h: Added needed method and members for 
1207         creating and maintaining a new window.
1208         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1209         lines of code to more appropriate places.
1210         (Drosera::handleCommand):
1211         (Drosera::initUI):
1212         (Drosera::onSize):
1213         (Drosera::attach):
1214
1215 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1216
1217         Reviewed by Dave Hyatt.
1218
1219         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1220         
1221         Add support for disabling author and user styles for testing.
1222
1223         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1224         * DumpRenderTree/LayoutTestController.cpp:
1225         (setAuthorAndUserStylesEnabledCallback):
1226         (LayoutTestController::staticFunctions):
1227         * DumpRenderTree/LayoutTestController.h:
1228         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1229         (LayoutTestController::setAuthorAndUserStylesEnabled):
1230         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1231         (LayoutTestController::setAuthorAndUserStylesEnabled):
1232
1233 2007-11-26  Dan Bernstein  <mitz@apple.com>
1234
1235         - Tiger build fix.
1236
1237         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1238
1239 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1240
1241         Reviewed by Maciej.
1242
1243         - Implemented displaying variables for Drosera on Win.
1244
1245         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1246         that retrieve variables to not hold onto the return value since it's
1247         not returned.  Also changed to use the new signatures of the retrieval
1248         functions.
1249         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1250         (DebuggerDocument::platformValueForScopeVariableNamed):
1251         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1252         (droseraWndProc):
1253
1254 2007-11-26  Sam Weinig  <sam@webkit.org>
1255
1256         Cleanup names of painting and repainting functions.
1257
1258         Reviewed by Adam Roben.
1259
1260         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1261         (drawSelectionRect): was drawSelectionRectIntoContext.
1262         (dumpWebViewAsPixelsAndCompareWithExpected):
1263         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1264         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1265         (paintWebView): was drawWebViewIntoContext.
1266         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1267
1268 2007-11-26  Sam Weinig  <sam@webkit.org>
1269
1270         Reviewed by Dan Bernstein.
1271
1272         - Leopard build fix
1273
1274         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1275
1276 2007-11-26  Sam Weinig  <sam@webkit.org>
1277
1278         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1279         Use shared PixelDumpSupport for Mac DRT
1280
1281         Reviewed by Adam Roben.
1282
1283         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1284         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1285         * DumpRenderTree/cg/ImageDiffCG.cpp:
1286         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1287         (drawSelectionRectIntoContext):
1288         (dumpWebViewAsPixelsAndCompareWithExpected):
1289         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1290         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1291         * DumpRenderTree/mac/DumpRenderTree.mm:
1292         (dump):
1293         * DumpRenderTree/mac/ImageDiff.m: Removed.
1294         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1295         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1296         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1297         (setDefaultColorProfileToRGB):
1298         (getBitmapContextFromWebView):
1299         (drawWebViewIntoContext):
1300         (repaintWithVerticalSweep):
1301         (repaintWithHorizontalSweep):
1302         (getSelectionRect):
1303         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1304
1305 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1306
1307         Bug 16052: prepare-ChangeLog doesn't report deleted files
1308         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1309
1310         Reviewed by Sam.
1311
1312         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1313
1314 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1315
1316         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1317         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1318
1319         Reviewed by Adam.
1320
1321         Roll functionality of merge-changelog into resolve-ChangeLogs
1322         script.  The script now checks for ChangeLog.rej and
1323         ChangeLog.orig files first.  If it finds them, it uses the
1324         ChangeLog.rej file as a patch (in old contextual diff format) to
1325         apply with --fuzz=3.
1326
1327         * Scripts/merge-changelog: Removed.
1328         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1329
1330 2007-11-25  Sam Weinig  <sam@webkit.org>
1331
1332         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1333
1334         Reviewed by Mark Rowe.
1335
1336         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1337         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1338         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1339         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1340         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1341
1342 2007-11-25  Sam Weinig  <sam@webkit.org>
1343
1344         Convert DumpRenderTree to ues .xcconfig files.
1345
1346         Reviewed by Mark Rowe.
1347
1348         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1349         * DumpRenderTree/mac/Configurations: Added.
1350         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1351         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1352         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1353
1354 2007-11-25  Sam Weinig  <sam@webkit.org>
1355
1356         Add ForwardingHeaders to wtf for DumpRenderTree.
1357
1358         Reviewed by Mark Rowe.
1359
1360         * DumpRenderTree/DumpRenderTree.h:
1361         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1362         * DumpRenderTree/ForwardingHeaders: Added.
1363         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1364         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1365         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1366         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1367         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1368         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1369         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1370         * DumpRenderTree/LayoutTestController.cpp:
1371         * DumpRenderTree/WorkQueue.cpp:
1372         * DumpRenderTree/mac/DumpRenderTree.mm:
1373         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1374         * DumpRenderTree/mac/JavaScriptThreading.cpp:
1375         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1376         * DumpRenderTree/mac/ObjCController.m:
1377         * DumpRenderTree/mac/UIDelegate.mm:
1378         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1379
1380 2007-11-25  Adam Roben  <aroben@apple.com>
1381
1382         Fix some test failures caused by r28019
1383
1384         Now that stdout is in binary mode, we need to always use printf
1385         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1386         the output.
1387
1388         Reviewed by Sam.
1389
1390         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1391         printf.
1392         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1393         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1394         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1395         (UIDelegate::webViewAddMessageToConsole):
1396
1397 2007-11-25  Adam Roben  <aroben@apple.com>
1398
1399         Set the font smoothing preference in DRT
1400
1401         This makes the pixel results on Windows closer to the Mac results.
1402
1403         Reviewed by Mitz.
1404
1405         * DumpRenderTree/win/DumpRenderTree.cpp:
1406         (initializePreferences):
1407
1408 2007-11-25  Adam Roben  <aroben@apple.com>
1409
1410         Port ImageDiff to CG and C++
1411
1412         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1413         <rdar://5071708>
1414
1415         Reviewed by Sam.
1416
1417         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1418         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1419         (main):
1420         (createImageFromStdin):
1421         (compareImages):
1422         (getDifferenceBitmap):
1423         (computePercentageDifferent):
1424         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1425
1426 2007-11-25  Adam Roben  <aroben@apple.com>
1427
1428         Fix image diff link generation on Windows
1429
1430         Reviewed by Sam.
1431
1432         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1433         to toURL.
1434
1435 2007-11-25  Adam Roben  <aroben@apple.com>
1436
1437         Implement pixel dumping in Windows DRT
1438
1439         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1440         <rdar://5071708>
1441
1442         Reviewed by Sam.
1443
1444         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1445         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1446         Content-Length header.
1447         (getMD5HashStringForBitmap):
1448         (dumpWebViewAsPixelsAndCompareWithExpected):
1449         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1450         * DumpRenderTree/win/DumpRenderTree.cpp:
1451         (dump): Do a pixel dump if requested.
1452         (main): Parse pixel test options.
1453         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1454         the cg/ subdirectory to the include path.
1455         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1456         available in a header or import library, so we have to go through this
1457         LoadLibrary/GetProcAddress dance to use them.
1458         (cryptDLL):
1459         (init):
1460         (update):
1461         (final):
1462         (MD5_Init):
1463         (MD5_Update):
1464         (MD5_Final):
1465         * DumpRenderTree/win/MD5.h: Added.
1466         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1467         moved up to the top level to share it with Mac eventually.
1468         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1469         (getBitmapContextFromWebView): Forces the WebView to paint using a
1470         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1471
1472 2007-11-25  Adam Roben  <aroben@apple.com>
1473
1474         Clean up Windows DRT's option parsing a little bit
1475
1476         Reviewed by Sam.
1477
1478         * DumpRenderTree/win/DumpRenderTree.cpp:
1479         (main): Put non-option arguments into a Vector.
1480
1481 2007-11-25  Adam Roben  <aroben@apple.com>
1482
1483         Make Windows DRT stop changing LF into CRLF
1484
1485         Reviewed by Sam.
1486
1487         * DumpRenderTree/win/DumpRenderTree.cpp:
1488         (main): Put stdout in binary mode.
1489         * Scripts/run-webkit-tests: Remove the CRLF hack.
1490
1491 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1492
1493         Removed empty directory.
1494
1495         * Scripts/resources: Removed.
1496
1497 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1498
1499         Fix bisect-builds to work with recent WebKit nightly builds.
1500
1501         Reviewed by Dan.
1502
1503         * Scripts/bisect-builds: Check for the 
1504         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1505         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1506         to WebKit.app/Contents/Resources.
1507
1508 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1509
1510         Reviewed by Maciej.
1511
1512         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1513         not closed (affects digg.com)
1514
1515         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1516         one after finishing with a test to avoid having its delayed onload handler firing when
1517         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1518         but it helps somewhat.
1519
1520 2007-11-22  Mark Rowe  <mrowe@apple.com>
1521
1522         Reviewed by Alp Toker.
1523
1524         Fix build-webkit to propagate make's exit status if it fails.
1525
1526         * Scripts/webkitdirs.pm:
1527
1528 2007-11-22  Dan Bernstein  <mitz@apple.com>
1529
1530         Reviewed by Mark Rowe.
1531
1532         - fix crash when running pixel tests
1533
1534         * DumpRenderTree/mac/DumpRenderTree.mm:
1535         (dumpRenderTree): Parse the command line options before setting up the
1536         environment so that we know if we need to set up the pixel dump
1537         machinery.
1538
1539 2007-11-21  Eric Seidel  <eric@webkit.org>
1540
1541         Speculative build fix for Tiger.
1542
1543         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1544
1545 2007-11-21  Eric Seidel  <eric@webkit.org>
1546
1547         Reviewed by Tim Hatcher.
1548
1549         Break out more of DumpRenderTree.mm into individual files
1550
1551         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1552         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1553         (checkedMalloc):
1554         (checkedRealloc):
1555         (makeLargeMallocFailSilently):
1556         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1557         * DumpRenderTree/mac/DumpRenderTree.mm:
1558         (crashHandler):
1559         (dump):
1560         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1561         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1562         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1563         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1564         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1565         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1566         (javaScriptThreads):
1567         (runJavaScriptThread):
1568         (startJavaScriptThreads):
1569         (stopJavaScriptThreads):
1570         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1571         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1572         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1573         (restoreColorSpace):
1574         (setDefaultColorProfileToRGB):
1575         (initializeColorSpaceAndScreeBufferForPixelTests):
1576         (md5HashStringForBitmap):
1577         (dumpWebViewAsPixelsAndCompareWithExpected):
1578
1579 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1580
1581         Move install-unix-extras to wx directory as it seems only to be used by that 
1582         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
1583         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1584         have install-unix-extras install into WebKitLibraries as per
1585         convention.
1586         
1587         Reviewed by Mark Rowe.
1588
1589         * Scripts/install-unix-extras: Removed.
1590         * wx/build-wxwebkit:
1591         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1592
1593 2007-11-21  Eric Seidel  <eric@webkit.org>
1594
1595         Reviewed by Adam.
1596
1597         More refactoring for greater code readability
1598
1599         * DumpRenderTree/mac/DumpRenderTree.mm:
1600         (initializeGlobalsFromCommandLineOptions):
1601         (initializeColorSpaceAndScreeBufferForPixelTests):
1602         (addTestPluginsToPluginSearchPath):
1603         (useLongRunningServerMode):
1604         (runTestingServerLoop):
1605         (prepareConsistentTestingEnvironment):
1606         (dumpRenderTree):
1607         (main):
1608         (dumpFramesAsText):
1609         (dumpBackForwardListForWebView):
1610         (sizeWebViewForCurrentTest):
1611         (methodNameStringForFailedTest):
1612         (dumpBackForwardListForAllWindows):
1613         (dumpWebViewAsPixelsAndCompareWithExpected):
1614         (invalidateAnyPreviousWaitToDumpWatchdog):
1615         (dump):
1616         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1617         * DumpRenderTree/mac/UIDelegate.mm:
1618         (-[UIDelegate webView:createWebViewWithRequest:]):
1619
1620 2007-11-21  Eric Seidel  <eric@webkit.org>
1621
1622         Reviewed by Tim Hatcher.
1623
1624         Abstract more of DRT into static methods
1625
1626         * DumpRenderTree/mac/DumpRenderTree.mm:
1627         (setDefaultsToConsistentValuesForTesting):
1628         (setupSignalHandlers):
1629         (allocateGlobalControllers):
1630         (releaseAndZero):
1631         (releaseGlobalControllers):
1632         (dumpRenderTree):
1633         (shouldLogFrameLoadDelegates):
1634         (createCFURLFromPathOrURL):
1635         (resetWebViewToConsistentStateBeforeTesting):
1636         (runTest):
1637
1638 2007-11-21  Eric Seidel  <eric@webkit.org>
1639
1640         Reviewed by Tim Hatcher.
1641
1642         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1643
1644         * DumpRenderTree/DumpRenderTree.h:
1645         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1646         * DumpRenderTree/mac/DumpRenderTree.mm:
1647         (dumpRenderTree):
1648         (dump):
1649         (runTest):
1650         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1651         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1652         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1653         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1654         (-[DumpRenderTreePasteboard declareType:owner:]):
1655         (+[LocalPasteboard alloc]):
1656         (-[LocalPasteboard init]):
1657         (-[LocalPasteboard dealloc]):
1658         (-[LocalPasteboard name]):
1659         (-[LocalPasteboard releaseGlobally]):
1660         (-[LocalPasteboard declareTypes:owner:]):
1661         (-[LocalPasteboard addTypes:owner:]):
1662         (-[LocalPasteboard changeCount]):
1663         (-[LocalPasteboard types]):
1664         (-[LocalPasteboard availableTypeFromArray:]):
1665         (-[LocalPasteboard setData:forType:]):
1666         (-[LocalPasteboard dataForType:]):
1667         (-[LocalPasteboard setPropertyList:forType:]):
1668         (-[LocalPasteboard setString:forType:]):
1669         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1670         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1671         (+[DumpRenderTreeWindow allWindows]):
1672         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1673         (-[DumpRenderTreeWindow dealloc]):
1674         (-[DumpRenderTreeWindow isKeyWindow]):
1675         (-[DumpRenderTreeWindow keyDown:]):
1676
1677 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1678
1679         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1680         it indiscriminately copies any headers inside JavaScriptCore,
1681         which includes Tiger ICU headers. 
1682
1683         * wx/build-wxwebkit:
1684         Don't run WebCore/move-js-headers.sh any longer.
1685
1686 2007-11-20  Adam Treat  <treat@kde.org>
1687
1688         Reviewed by David Kilzer.
1689
1690         * Prepend git branch name to $baseProductDir
1691
1692         * Scripts/VCSUtils.pm:
1693         * Scripts/webkitdirs.pm:
1694
1695 2007-11-20  Mark Rowe  <mrowe@apple.com>
1696
1697         Reviewed by Simon Hausmann.
1698
1699         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1700         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1701         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1702         built product and generated Makefile's are removed.
1703
1704 2007-11-19  Alp Toker  <alp@atoker.com>
1705
1706         Reviewed by Mark Rowe.
1707
1708         http://bugs.webkit.org/show_bug.cgi?id=16040
1709         [GTK] GtkLauncher should be written in C
1710
1711         Port GtkLauncher to plain C.
1712
1713         Use a more conventional GTK+ coding style.
1714
1715         Use a toolbar instead of menus.
1716
1717         Various signature fixes and cleanups.
1718
1719         Add a license header. Assume all previous modifications were copyright
1720         assigned to Apple Inc. by default.
1721
1722         * GtkLauncher/GtkLauncher.pro:
1723         * GtkLauncher/main.c: Added.
1724         (activate_url_entry_cb):
1725         (update_title):
1726         (link_hover_cb):
1727         (title_change_cb):
1728         (progress_change_cb):
1729         (destroy_cb):
1730         (go_back_cb):
1731         (go_forward_cb):
1732         (create_browser):
1733         (create_statusbar):
1734         (create_toolbar):
1735         (create_window):
1736         (main):
1737         * GtkLauncher/main.cpp: Removed.
1738
1739 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1740
1741         Build script fixes to ensure they do the right thing for the 
1742         wx port, and update build-wxwebkit to reflect the way the
1743         build scripts now work.
1744
1745         Reviewed by Adam.
1746
1747         * Scripts/build-testkjs:
1748         * Scripts/build-webkit:
1749         * Scripts/run-javascriptcore-tests:
1750         * Scripts/webkitdirs.pm:
1751         * wx/build-wxwebkit:
1752
1753 2007-11-18  Eric Seidel  <eric@webkit.org>
1754
1755         Reviewed by Anders.
1756
1757         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1758
1759         * Scripts/run-javascriptcore-tests:
1760
1761 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1762
1763         Reviewed by Adam Roben.
1764
1765         Make run-webkit-tests work with Windows debug build.
1766
1767         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1768         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1769         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1770         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1771         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1772
1773 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1774
1775         Add wxWebKit sample and build script, and integrate it with 
1776         build-webkit. Also make build-webkit --clean work for all
1777         ports.
1778
1779         Reviewed by Darin Adler.
1780
1781         * Scripts/build-webkit:
1782         * Scripts/webkitdirs.pm:
1783         * wx: Added.
1784         * wx/browser: Added.
1785         * wx/browser/browser.bkl: Added.
1786         * wx/browser/browser.cpp: Added.
1787         * wx/build-wxwebkit: Added.
1788
1789 2007-11-17  Adam Roben  <aroben@apple.com>
1790
1791         Make it easy to run Safari in the debugger on Windows
1792
1793         I've added a new script, debug-safari, which launches Safari in the
1794         debugger. On OS X it just calls gdb-safari.
1795
1796         Reviewed by Mark Rowe.
1797
1798         * FindSafari/FindSafari.cpp:
1799         (_tmain): Added a /debugger flag, which in combination with
1800         /printSafariLauncher will print a script that launches Safari in the
1801         debugger.
1802         * Scripts/debug-safari: Added.
1803         * Scripts/run-safari: Changed to call runSafari().
1804         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1805         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1806         first argument along to FindSafari.
1807         * Scripts/webkitdirs.pm:
1808         (sub runSafari): Added.
1809
1810 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1811
1812         Reviewed by Adam Roben.
1813
1814         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
1815
1816 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1817
1818         Reviewed by David Kilzer.
1819
1820         The git config command was renamed to repo-config at some point. This
1821         change tries git config and then git repo-config if the first fails.
1822
1823         * Scripts/prepare-ChangeLog:
1824         (gitConfig):
1825
1826 2007-11-16  Dan Bernstein  <mitz@apple.com>
1827
1828         Reviewed by Darin Adler and Sam Weinig.
1829
1830         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1831
1832         * DumpRenderTree/win/EventSender.cpp:
1833         (keyDownCallback): For characters that cannot be entered on the active
1834         keyboard layout, send a WM_CHAR message with the character along with
1835         a WM_KEYDOWN message with a virtual key code of 255.
1836
1837 2007-11-16  Mark Rowe  <mrowe@apple.com>
1838
1839         Reviewed by Tim Hatcher.
1840
1841         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1842
1843         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1844         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1845
1846 2007-11-15  Adam Roben  <aroben@apple.com>
1847
1848         Make run-safari actually work on Windows
1849
1850         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1851         chdir call.
1852
1853 2007-11-14  Adam Roben  <aroben@apple.com>
1854
1855         Updates to Safari launching now that 3.0.4 is released
1856
1857         Reviewed by Sam.
1858
1859         * FindSafari/FindSafari.cpp:
1860         (getWebViewCLSID): Use version-independent ProgID.
1861         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1862
1863 2007-11-14  Anders Carlsson  <andersca@apple.com>
1864
1865         Reviewed by Adam.
1866
1867         <rdar://problem/5309081>
1868         In DRT, "plugin.logDestroy = true" not working on Windows.
1869         
1870         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1871         (NPP_Destroy):
1872
1873 2007-11-14  Eric Seidel  <eric@webkit.org>
1874
1875         Reviewed by Sam.
1876
1877         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1878
1879 2007-11-14  Anders Carlsson  <andersca@apple.com>
1880
1881         Reviewed by Adam.
1882
1883         <rdar://problem/5141186>
1884         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1885         
1886         Implement setWindowIsKey.
1887         
1888         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1889         (LayoutTestController::setWindowIsKey):
1890
1891 2007-11-13  Sam Weinig  <sam@webkit.org>
1892
1893         Reviewed by Adam Roben.
1894
1895         Fix for <rdar://problem/5382579>
1896         http/tests/security/cross-frame-access-put.html reports large 
1897         negative numbers for screenLeft and screenTop (Mac reports "0")
1898
1899         * DumpRenderTree/win/UIDelegate.cpp:
1900         (UIDelegate::UIDelegate): Initialize the RECT.
1901         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1902         (UIDelegate::webViewFrame): ditto.
1903         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1904
1905 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1906
1907         Reviewed by Adam.
1908
1909         - Make Drosera show source, source URLs, and function stack on Windows,
1910         and some minor fixes.
1911
1912         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1913         (DebuggerDocument::updateFileSource):
1914         * Drosera/debugger.js: Force source to always update display.
1915         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1916         menu controls.
1917         (DebuggerClient::resume):
1918         (DebuggerClient::pause):
1919         (DebuggerClient::stepInto):
1920         (DebuggerClient::stepOver):
1921         (DebuggerClient::stepOut):
1922         (DebuggerClient::showConsole):
1923         (DebuggerClient::closeCurrentFile):
1924         * Drosera/win/DebuggerClient.h: Ditto.
1925         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1926         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1927         removed two bugs.  1) caller could be in a bad state when asked to
1928         assign into it. 2) BSTRs were not created correctly.
1929         (DebuggerDocument::getPlatformCurrentFunctionStack):
1930         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1931         (droseraWndProc):
1932         (handleCommand):
1933         (Drosera::resume):
1934         (Drosera::pause):
1935         (Drosera::stepInto):
1936         (Drosera::stepOver):
1937         (Drosera::stepOut):
1938         (Drosera::showConsole):
1939         (Drosera::closeCurrentFile):
1940         * Drosera/win/Drosera.h: Hook up the menu controls.
1941         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1942         functions, added a null check, and fixed another bug where caller could
1943         be in a bad state when asked to assign into it.
1944         (ServerConnection::didLoadMainResourceForDataSource):
1945         (ServerConnection::getCallerFrame):
1946         * Drosera/win/ServerConnection.h: Safety first.
1947
1948 2007-11-13  Dan Bernstein  <mitz@apple.com>
1949
1950         Reviewed by Darin Adler.
1951
1952         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1953           DumpRenderTree --pixel-tests renders each test twice
1954
1955         * DumpRenderTree/mac/DumpRenderTree.mm:
1956         (dumpRenderTree): Removed the --paint option because the painting code
1957         is always exercised as a result of
1958         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1959         calling -displayIfNeeded.
1960         (dump): Changed to always grab the image from the window since the view
1961         is always displayed.
1962         (runTest):
1963         (displayWebView):
1964         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1965         because it always paints.
1966
1967 2007-11-12  Antti Koivisto  <antti@apple.com>
1968
1969         Reviewed by Adele.
1970         
1971         Add support for http media tests
1972
1973         * Scripts/run-webkit-tests:
1974
1975 2007-11-12  Sam Weinig  <sam@webkit.org>
1976
1977         Reviewed by Adam Roben.
1978
1979         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1980
1981         * DumpRenderTree/win/DumpRenderTree.cpp:
1982         (runTest):
1983         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1984         (LayoutTestController::setPrivateBrowsingEnabled):
1985
1986 2007-11-12  Adam Roben  <aroben@apple.com>
1987
1988         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1989         mac and win subdirectories.
1990
1991 2007-11-11  Adam Roben  <aroben@apple.com>
1992
1993         Fix <rdar://5133816> keepWebHistory is not implemented
1994
1995         Fixes fast/history/clicked-link-is-visited.html.
1996
1997         Reviewed by Darin.
1998
1999         * DumpRenderTree/win/DumpRenderTree.cpp:
2000         (runTest): Clear the optionalSharedHistory.
2001         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2002         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
2003
2004 2007-11-10  Sam Weinig  <sam@webkit.org>
2005
2006         Reviewed by Tim Hatcher.
2007
2008         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
2009         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
2010         is turned on)
2011
2012         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
2013
2014         Added test: http/tests/security/cross-frame-access-private-browsing.html
2015
2016         * DumpRenderTree/LayoutTestController.cpp:
2017         (setPrivateBrowsingEnabledCallback):
2018         (LayoutTestController::staticFunctions):
2019         * DumpRenderTree/LayoutTestController.h:
2020         * DumpRenderTree/mac/DumpRenderTree.mm:
2021         (runTest): Default to private browsing disabled.
2022         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2023         (LayoutTestController::setPrivateBrowsingEnabled):
2024         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2025         (LayoutTestController::setPrivateBrowsingEnabled):
2026
2027 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2028
2029         Reviewed by Adam.
2030
2031         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
2032         WebCore's!
2033
2034         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2035         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
2036         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2037         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2038         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
2039         * Drosera/win/Drosera.cpp:
2040         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2041
2042 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2043
2044         Reviewed by Sam.
2045
2046         - Use the new IWebFrame [local] function signature and get the shared
2047         server correctly.
2048
2049         * Drosera/win/DebuggerClient.cpp:
2050         (DebuggerClient::didFinishLoadForFrame):
2051         * Drosera/win/ServerConnection.cpp:
2052         (ServerConnection::attemptToCreateServerConnection):
2053
2054 2007-11-07  Dan Bernstein  <mitz@apple.com>
2055
2056         Reviewed by Darin Adler.
2057
2058         - add an option to run-webkit-tests to ignore pixel test failures where
2059           all pixels differ by no more than a specified threshold
2060
2061         * DumpRenderTree/mac/ImageDiff.m:
2062         (main):
2063         (compareImages):
2064         (computePercentageDifferent):
2065         * Scripts/run-webkit-tests:
2066
2067 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2068
2069         Reviewed by Lars.
2070
2071         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
2072
2073         * DumpRenderTree/qt/DumpRenderTree.cpp:
2074
2075 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2076
2077         Reviewed by Lars.
2078
2079         Reworked the QWebSettings API.
2080         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
2081
2082         * DumpRenderTree/qt/DumpRenderTree.cpp:
2083
2084 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2085
2086         Reviewed by Lars.
2087
2088         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
2089
2090         * DumpRenderTree/qt/jsobjects.cpp:
2091
2092 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2093
2094         Reviewed by Lars Knoll <lars@trolltech.com>.
2095
2096         Add a QWebPage::frameCreated() signal and fix DRT
2097         
2098         The removal of createFrame in QWebPage broke the re-implementation
2099         in DumpRenderTree. Instead emit a frameCreated() signal and
2100         connect to it in DumpRenderTree.
2101         
2102
2103         * DumpRenderTree/qt/DumpRenderTree.cpp:
2104         (WebCore::WebPage::WebPage):
2105         (WebCore::DumpRenderTree::dump):
2106         (WebCore::DumpRenderTree::connectFrame):
2107         * DumpRenderTree/qt/DumpRenderTree.h:
2108
2109 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2110
2111         Reviewed by Lars Knoll <lars@trolltech.com>.
2112
2113         Moved all the event handlers from QWebFrame into QWebPage.
2114         
2115         This cleans up the public API and allows us to remove the
2116         HackWebFrame hack in DumpRenderTree.
2117         
2118
2119         * DumpRenderTree/qt/jsobjects.cpp:
2120         (EventSender::mouseDown):
2121         (EventSender::mouseUp):
2122         (EventSender::mouseMoveTo):
2123
2124 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2125
2126         Reviewed by Mark.
2127
2128         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
2129         to prevent the default implementation from popping up messageboxes.
2130
2131         * DumpRenderTree/qt/DumpRenderTree.cpp:
2132         (WebCore::WebPage::javaScriptConfirm):
2133         (WebCore::WebPage::javaScriptPrompt):
2134
2135 2007-11-06  Eric Seidel  <eric@webkit.org>
2136
2137         * Scripts/build-testkjs: build fix... too many $$
2138
2139 2007-11-06  Eric Seidel  <eric@webkit.org>
2140
2141         Reviewed by Mark Rowe.
2142
2143         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
2144
2145 2007-11-05  Adam Roben  <aroben@apple.com>
2146
2147         Add support on Windows for WEBKIT_TESTFONTS
2148
2149         This environment variable lets you specify where the fonts to be used
2150         by DumpRenderTree reside. The Qt port is already using this, so I'm
2151         just following their lead.
2152
2153         Reviewed by Darin.
2154
2155         * DumpRenderTree/win/DumpRenderTree.cpp:
2156         (exePath): Refactored code out of initialize().
2157         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2158         DumpRenderTree.resources.
2159         (initialize): Use the new fontsPath function.
2160         (main): Use the new exePath function.
2161         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2162         variable to DRT, like Qt does.
2163
2164 2007-11-05  Mark Rowe  <mrowe@apple.com>
2165
2166         Rubber-stamped by Alp Toker.
2167
2168         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2169
2170         * GtkLauncher/main.cpp:
2171         (goToURLBarText):
2172         (main):
2173
2174 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2175
2176         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2177         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2178
2179         Reviewed by Timothy.
2180
2181         Restrict the range of nightly builds used by the bisect-builds script
2182         based on the version of Safari and the version of Mac OS X being used.
2183
2184         Mac OS X 10.4: Safari 2.0: r11976 or newer
2185         Mac OS X 10.4: Safari 3.0: r19992 or newer
2186
2187         Mac OS X 10.5: Safari 2.0: r19594 or newer
2188         Mac OS X 10.5: Safari 3.0: r25124 or newer
2189
2190         * Scripts/bisect-builds:
2191         (findMacOSXVersion): Added.
2192         (makeNightlyList): Added argument to provide version of Mac OS X.
2193         Restrict range of nightly builds based on Safari and Mac OS X versions.
2194
2195 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2196
2197         Reviewed by Maciej.
2198
2199         - This patch involves several changes, all of them were noticed that
2200         they were needed by the work being done in WebKit to get Drosera and
2201         WebKit working together on Windows.
2202         - The changes are:
2203         1) Added a debugger console for output messages.
2204         2) Drosera now listens for the WebKit server (before, the server would
2205         have to be running before Drosera was started.)
2206         3) Fixed a bug where the WebView started out as 0x0 pixels.
2207         4) Fixed a bug when there is no scope.
2208         5) Added the HTML, JS, and CSS to the project file to make them easy to
2209         find.
2210         6) Made the ServerConnection functions virtual.
2211
2212         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2213         for the WebKit server.
2214         (DebuggerClient::DebuggerClient):
2215         (DebuggerClient::~DebuggerClient):
2216         (DebuggerClient::didFinishLoadForFrame):
2217         (DebuggerClient::serverConnected):
2218         (DebuggerClient::attemptToCreateServerConnection):
2219         * Drosera/win/DebuggerClient.h: Ditto.
2220         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2221         scope.
2222         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2223         (DebuggerDocument::platformValueForScopeVariableNamed):
2224         * Drosera/win/Drosera.cpp:
2225         (_tWinMain): Added a console in debug for output messages.
2226         (Drosera::Drosera): Listen for server.
2227         (Drosera::initUI): The server now Initializes COM.
2228         (Drosera::serverConnected): Part of the listening for the server.
2229         (Drosera::attemptToCreateServerConnection): Ditto.
2230         * Drosera/win/Drosera.h: New interface for listening for the server.
2231         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2232         files to the VS project.
2233         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2234         connection.
2235         (ServerConnection::ServerConnection):
2236         (ServerConnection::attemptToCreateServerConnection):
2237         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2238         methods.
2239         (ServerConnection::serverConnected):
2240
2241 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2242
2243         Reviewed by Maciej.
2244
2245         http://bugs.webkit.org/show_bug.cgi?id=15832
2246         fast/dom/gc-10.html crashes when run alone
2247
2248         Check for !done before using objects that can be already deallocated.
2249
2250         * DumpRenderTree/mac/EditingDelegate.mm:
2251         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2252         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2253         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2254         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2255         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2256         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2257         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2258         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2259         (-[EditingDelegate webViewDidBeginEditing:]):
2260         (-[EditingDelegate webViewDidChange:]):
2261         (-[EditingDelegate webViewDidEndEditing:]):
2262         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2263         (-[EditingDelegate webViewDidChangeSelection:]):
2264         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2265         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2266         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2267         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2268         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2269         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2270         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2271         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2272         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2273         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2274         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2275         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2276         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2277         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2278         (-[FrameLoadDelegate webView:willCloseFrame:]):
2279         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2280         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2281         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2282         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2283         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2284         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2285         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2286         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2287         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2288
2289 2007-11-04  Mark Rowe  <mrowe@apple.com>
2290
2291         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2292         warnings that would otherwise be suppressed due to it being a system header.
2293
2294         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2295
2296 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2297
2298         Rubber stamped by Adam.
2299         
2300         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2301
2302         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2303
2304 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2305
2306         Sort files(...); sections of Xcode project files.
2307
2308         Rubber-stamped by Darin.
2309
2310         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2311         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2312         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2313         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2314
2315 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2316
2317         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2318
2319         Reviewed by Darin.
2320
2321         * Scripts/sort-Xcode-project-file: Added.
2322
2323 2007-11-02  Darin Adler  <darin@apple.com>
2324
2325         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2326
2327 2007-11-02  Darin Adler  <darin@apple.com>
2328
2329         Reviewed by Maciej.
2330
2331         * Scripts/run-sunspider: Pass the "--base" option through.
2332
2333         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2334         the real script do that. Default configuration to Release to match run-sunspider
2335         so we don't end up building Debug just to compare results.
2336
2337 2007-11-01  Adam Roben  <aroben@apple.com>
2338
2339         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2340
2341         Reviewed by Sam.
2342
2343         * Scripts/commit-log-editor: Show all the directories beneath the
2344         source root, instead of just the last one.
2345
2346 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2347
2348         Reviewed by Adam Roben.
2349
2350         Print out an error message when the Windows build fails
2351         and provide guidance on how to find out what went wrong.
2352
2353         * Scripts/build-webkit:
2354         * Scripts/webkitdirs.pm:
2355
2356 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2357
2358         Rubber-stamped by Adam Roben.
2359
2360         Rolled out r27326 - debug CRT seems to cause no problems after all.
2361
2362         * DumpRenderTree/win/DumpRenderTree.vcproj:
2363
2364 2007-10-31  Adam Roben  <aroben@apple.com>
2365
2366         Switch the Debug configuration to using the non-debug CRT
2367
2368         This matches WebKit.
2369
2370         Reviewed by Steve.
2371
2372         * DumpRenderTree/win/DumpRenderTree.vcproj:
2373
2374 2007-10-31  Antti Koivisto  <antti@apple.com>
2375
2376         Reviewed by bdash.
2377         
2378         Disable media tests when doing leak checking on Tiger.
2379         They crash in QuickTime (rdar://problem/5537157).
2380
2381         * Scripts/run-webkit-tests:
2382
2383 2007-10-29  Antti Koivisto  <antti@apple.com>
2384
2385         Reviewed by Maciej.
2386         
2387         Build media support by default on OSX only.
2388
2389         * Scripts/build-webkit:
2390
2391 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2392
2393         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2394         get caught by the pre-commit hooks.
2395
2396 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2397
2398         Reviewed by Adam.
2399
2400         - This is a collection of relatively unrelated changes and cleanups
2401         to Drosera to prepare it for interacting with WebKit.  A lot of these
2402         changes are just correcting mistakes, for example removing included
2403         headers that are no longer needed.
2404
2405         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2406         this will be needed by the DebuggerClient.
2407         (DebuggerDocument::server):
2408         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2409         * Drosera/win/DebuggerClient.cpp: 
2410         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2411         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2412         (DebuggerClient::createWebViewWithRequest): Added comment about its
2413         purpose. 
2414         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2415         declarations.
2416         (DebuggerClient::webViewLoaded): Moved.
2417         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2418         file, since this was the only place it was used.
2419         (cfStringToBSTR):
2420         * Drosera/win/Drosera.h: Cleaned up the includes.
2421         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2422         * Drosera/win/HelperFunctions.h: Removed.
2423
2424 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2425
2426         Reviewed by Adam.
2427
2428         - Small cleanup in the ServerConnection class.
2429
2430         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2431         and added an include.
2432         (ServerConnection::currentFrame):
2433         (ServerConnection::getCallerFrame):
2434         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2435         made a pointer into a COMPtr, and cleaned up the includes.
2436
2437 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2438
2439         Reviewed by John Sullivan.
2440         
2441         - Place the Localizable.strings file in mac or win directories
2442           if that location exists.
2443         - Also look for UI_STRING in .c files.
2444
2445         * Scripts/extract-localizable-strings:
2446
2447 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2448
2449         Reviewed by Adam.
2450
2451         - Set the eol-style to native and made all the line endings the same
2452         so that I avoid messy diffs that show eol changes.
2453
2454         * Drosera/win/ServerConnection.cpp:
2455         (ServerConnection::didParseSource):
2456         (ServerConnection::didEnterCallFrame):
2457         (ServerConnection::willExecuteStatement):
2458         (ServerConnection::willLeaveCallFrame):
2459         (ServerConnection::exceptionWasRaised):
2460
2461 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2462
2463         Reviewed by Adam.
2464
2465         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2466         functionality that could not have existed previously without the new
2467         interfaces.
2468         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2469         from a BSTR to a JSValueRef.
2470         (DebuggerDocument::platformEvaluateScript): Implemented.
2471         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2472         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2473         Implemented.
2474         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2475         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2476         * Drosera/win/ServerConnection.cpp: Added a helper function.
2477         (ServerConnection::getCallerFrame):
2478         * Drosera/win/ServerConnection.h: Added a helper function.
2479
2480 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2481
2482         updated reviewers for my previous changelog.
2483
2484 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2485         Reviewed by Maciej and Adam and Geoff.
2486
2487         - Minor mac-side improvements including moving a function to a more
2488         appropriate location, fixing a warning, and correctly checking
2489         exceptions.
2490
2491         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2492         (DebuggerDocument::willExecuteStatement):
2493         (DebuggerDocument::didEnterCallFrame):
2494         (DebuggerDocument::willLeaveCallFrame):
2495         (DebuggerDocument::windowScriptObjectAvailable):
2496         (DebuggerDocument::callFunctionOnObject):
2497         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2498         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2499         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2500         because it doesn't require the ServerConnection at all.
2501         (NSStringCreateWithJSStringRef): Made an argument const.
2502         (JSValueRefCreateWithNSString): Made an argument const.
2503         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2504         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2505         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2506         * Drosera/mac/ServerConnection.mm: Ditto.
2507         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2508
2509 2007-10-29  Sam Weinig  <sam@webkit.org>
2510
2511         Reviewed by Adam Roben.
2512
2513         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2514
2515         * DumpRenderTree/LayoutTestController.cpp:
2516         (LayoutTestController::LayoutTestController):
2517         (getGlobalFlagCallback):
2518         (setGlobalFlagCallback):
2519         (LayoutTestController::getJSClass):
2520         (LayoutTestController::staticValues):
2521         * DumpRenderTree/LayoutTestController.h:
2522         (LayoutTestController::globalFlag):
2523         (LayoutTestController::setGlobalFlag):
2524
2525 2007-10-29  Darin Adler  <darin@apple.com>
2526
2527         Reviewed by Maciej.
2528
2529         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2530         resolution instead of its default.
2531
2532 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2533
2534         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2535
2536         Reviewed by Mark Rowe.
2537
2538         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2539         was successfully resolved, but this would not show any status because the change had
2540         already been cached in the index using "git add".  The solution is to add an optional
2541         second argument to showStatus() which adds the "--cached" switch to the command.
2542
2543         * Scripts/resolve-ChangeLogs:
2544         (showStatus):
2545
2546 2007-10-28  Eric Seidel  <eric@webkit.org>
2547
2548         Reviewed by Maciej and Geoff, in unison.
2549
2550         * Scripts/run-webkit-tests: remove broken --svg option
2551
2552 2007-10-28  Darin Adler  <darin@apple.com>
2553
2554         Reviewed by Adam.
2555
2556         * Scripts/run-sunspider: Default to "Release" configuration rather than
2557         defaulting to the last configuration used as other scripts do. This can
2558         still be overriden on the command line with "--debug" if there's some
2559         reason to do so. Also fix a typo.
2560
2561         * Scripts/sunspider-compare-results: Fix a typo.
2562
2563 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2564
2565         Reviewed by Adam.
2566
2567         - Implemented the WebScriptDebugListener functions now that the
2568         WebScriptDebugServer exists
2569
2570         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2571         functions.
2572         (ServerConnection::currentFrame):
2573         (ServerConnection::didLoadMainResourceForDataSource):
2574         (ServerConnection::didParseSource):
2575         (ServerConnection::failedToParseSource):
2576         (ServerConnection::didEnterCallFrame):
2577         (ServerConnection::willExecuteStatement):
2578         (ServerConnection::willLeaveCallFrame):
2579         (ServerConnection::exceptionWasRaised):
2580         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2581         members arguments list.
2582
2583 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2584
2585         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2586         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2587
2588         Reviewed by Darin.
2589
2590         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2591         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2592         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2593         file.  Note that it may also be used as a stand-alone script.
2594
2595         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2596         * Scripts/resolve-ChangeLogs: Added.
2597         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2598
2599 2007-10-26  Mark Rowe  <mrowe@apple.com>
2600
2601         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2602         to the Qt port on the assumption that it was an implementation of the cross-platform
2603         LayoutTestController class.  It is not, so it did not need to be changed.
2604
2605         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2606
2607 2007-10-25  Mark Rowe  <mrowe@apple.com>
2608
2609         Reviewed by Maciej.
2610
2611         Fix builds with code coverage enabled.
2612
2613         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2614
2615 2007-10-25  Darin Adler  <darin@apple.com>
2616
2617         Reviewed by Mark Rowe.
2618
2619         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2620         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2621
2622 2007-10-25  Stephanie  <slewis@apple.com>
2623
2624         build Fix
2625
2626         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2627
2628 2007-10-25  Stephanie  <slewis@apple.com>
2629
2630         Reviewed by Mark Rowe, Adam Roben.
2631
2632         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2633
2634         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
2635
2636 2007-10-25  Alice Liu  <alice.liu@apple.com>
2637
2638         Reviewed by Adam.
2639
2640         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2641
2642         Moving destructor into platform-specific files
2643         * DumpRenderTree/LayoutTestController.cpp:
2644         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2645         (LayoutTestController::~LayoutTestController):
2646         * DumpRenderTree/qt/jsobjects.cpp:
2647         (LayoutTestController::~LayoutTestController):
2648
2649         LayoutTestController wasn't being destroyed
2650         * DumpRenderTree/win/DumpRenderTree.cpp:
2651         (runTest):
2652
2653         Added declspec
2654         * DumpRenderTree/win/EditingDelegate.h:
2655
2656         Reset certain values on the webview (or related delegate) that might 
2657         have changed while running a test
2658         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2659         (LayoutTestController::~LayoutTestController):
2660
2661 2007-10-25  Adam Roben  <aroben@apple.com>
2662
2663         Make sunspider-compare-results work with relative paths
2664
2665         Reviewed by Sam.
2666
2667         * Scripts/sunspider-compare-results: Convert arguments to absolute
2668         paths before we chdir.
2669
2670 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2671
2672         Reviewed by Sam.
2673
2674         - Implemented server calls now the WebScriptDebugServer exists.
2675         - Also removed no longer needed call to initialize CG.
2676
2677         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2678         automatically now.
2679         (_tWinMain):
2680         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2681         (ServerConnection::ServerConnection):
2682         (ServerConnection::~ServerConnection):
2683         (ServerConnection::pause):
2684         (ServerConnection::resume):
2685         (ServerConnection::stepInto):
2686         (ServerConnection::applicationTerminating):
2687         (ServerConnection::serverConnectionDidDie):
2688         * Drosera/win/ServerConnection.h: Now uses the COM class.
2689
2690 2007-10-24  George Staikos  <staikos@kde.org>
2691
2692         Unbreak Qt build.
2693
2694         * Scripts/build-webkit:
2695
2696 2007-10-24  Adam Roben  <aroben@apple.com>
2697
2698         Remove now-unnecessary call to InitializeCoreGraphics
2699
2700         WebKit takes care of this now.
2701
2702         Reviewed by Ada.
2703
2704         * DumpRenderTree/win/DumpRenderTree.cpp:
2705         (initialize):
2706
2707 2007-10-24  Adam Roben  <aroben@apple.com>
2708
2709         Use WebTextRenderer in DRT
2710
2711         Reviewed by Ada.
2712
2713         * DumpRenderTree/win/DumpRenderTree.cpp:
2714         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2715
2716 2007-10-24  Sven Herzberg  <sven@imendio.com>
2717
2718         Reviewed by Mark Rowe.
2719
2720         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2721         Bug 15614: [GTK] qmake based backends don't build on OS X
2722
2723         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2724         GTK backend on a Mac
2725         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2726         isDarwin() to make it reusable in other places (like the workaround-
2727         for-prebuilt-qmake in build-webkit)
2728
2729 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2730
2731         Refurbish update-webkit script.
2732
2733         Reviewed by Adam.
2734
2735         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2736         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2737         multi-argument version of system() for flexibility and security.  Check for existence
2738         of Internal directory using -d test instead of -x.
2739
2740 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2741
2742         Minor clean-up of prepare-ChangeLog script.
2743
2744         Reviewed by Adam.
2745
2746         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2747         of a string.  Use multi-argument versions of open() and system() for flexibility and
2748         security.
2749
2750 2007-10-24  Alice Liu  <alice.liu@apple.com>
2751
2752         Reviewed by Oliver.
2753
2754         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2755
2756         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
2757         replay the saved events when we're still processing the mousedown that starts the drag
2758         * DumpRenderTree/win/EventSender.cpp:
2759         (doMouseMove):
2760         * DumpRenderTree/win/UIDelegate.cpp:
2761         (UIDelegate::doDragDrop):
2762
2763 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2764
2765         Reviewed by Sam, Steve and Darin.
2766
2767         - Stubbed out the WebScriptDebugListener functionality in the Server
2768         Connection class to prepare it for receiving those callbacks.
2769         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2770         and the ServerConnection to not need to be initialized with a server
2771         name, since that is not the way we connect to the WebKit server. 
2772
2773         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2774         no exception.  Now it only loggs when there is an exception
2775         (DebuggerDocument::willExecuteStatement):
2776         (DebuggerDocument::didEnterCallFrame):
2777         (DebuggerDocument::willLeaveCallFrame):
2778         (DebuggerDocument::windowScriptObjectAvailable):
2779         (DebuggerDocument::callFunctionOnObject):
2780         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2781         to be instantiated with a server's name.
2782         (DebuggerClient::DebuggerClient):
2783         (DebuggerClient::didFinishLoadForFrame):
2784         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2785         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2786         a server name.
2787         (Drosera::init):
2788         (Drosera::initServer):
2789         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2790         instantiated with a server's name.
2791         * Drosera/win/ServerConnection.cpp: 
2792         (ServerConnection::ServerConnection): No longer needs a server name
2793         (ServerConnection::~ServerConnection): Only release the global context
2794         if there is one.
2795         (ServerConnection::serverConnectionDidDie): Stub for
2796         IWebScriptDebugListener
2797         (ServerConnection::QueryInterface): ditto
2798         (ServerConnection::AddRef): ditto
2799         (ServerConnection::Release): ditto
2800         (ServerConnection::didLoadMainResourceForDataSource): ditto
2801         (ServerConnection::didParseSource): ditto
2802         (ServerConnection::failedToParseSource): ditto
2803         (ServerConnection::didEnterCallFrame): ditto
2804         (ServerConnection::willExecuteStatement): ditto
2805         (ServerConnection::willLeaveCallFrame): ditto
2806         (ServerConnection::exceptionWasRaised): ditto
2807         * Drosera/win/ServerConnection.h: Stubbed out the
2808         IWebScriptDebugListener functions, and this class no longer needs to be
2809         instantiated with a server name.
2810
2811 2007-10-24  Lars Knoll  <lars@trolltech.com>
2812
2813         Reviewed by Simon.
2814
2815         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2816
2817         * DumpRenderTree/qt/jsobjects.h:
2818
2819 2007-10-24  Lars Knoll  <lars@trolltech.com>
2820
2821         Reviewed by Simon.
2822
2823         add another command.
2824
2825         * DumpRenderTree/qt/jsobjects.cpp:
2826         (TextInputController::doCommand):
2827
2828 2007-10-24  Lars Knoll  <lars@trolltech.com>
2829
2830         Reviewed by Simon.
2831
2832         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2833
2834         * DumpRenderTree/qt/jsobjects.cpp:
2835         (EventSender::keyDown):
2836         * DumpRenderTree/qt/jsobjects.h:
2837
2838 2007-10-24  Lars Knoll  <lars@trolltech.com>
2839
2840         Reviewed by Simon.
2841
2842         implement eventSender.keyDown().
2843
2844         * DumpRenderTree/qt/jsobjects.cpp:
2845         (EventSender::keyDown):
2846
2847 2007-10-24  Lars Knoll  <lars@trolltech.com>
2848
2849         Reviewed by Simon.
2850
2851         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2852
2853         * DumpRenderTree/qt/DumpRenderTree.cpp:
2854         (WebCore::DumpRenderTree::DumpRenderTree):
2855         (WebCore::DumpRenderTree::initJSObjects):
2856         * DumpRenderTree/qt/jsobjects.cpp:
2857         (TextInputController::doCommand):
2858
2859 2007-10-24  Lars Knoll  <lars@trolltech.com>
2860
2861         Reviewed by Simon.
2862
2863         first bit of implementation for the textinputcontroller.
2864
2865         * DumpRenderTree/qt/DumpRenderTree.cpp:
2866         (WebCore::DumpRenderTree::DumpRenderTree):
2867         * DumpRenderTree/qt/DumpRenderTree.h:
2868         * DumpRenderTree/qt/jsobjects.cpp:
2869         (TextInputController::TextInputController):
2870         (TextInputController::doCommand):
2871         * DumpRenderTree/qt/jsobjects.h:
2872
2873 2007-10-24  Lars Knoll  <lars@trolltech.com>
2874
2875         Reviewed by Simon.
2876
2877         make the man webpage believe it has focus, so the editing tests work correctly.
2878
2879         * DumpRenderTree/qt/DumpRenderTree.cpp:
2880         (WebCore::DumpRenderTree::DumpRenderTree):
2881
2882 2007-10-24  Lars Knoll  <lars@trolltech.com>
2883
2884         Reviewed by Simon.
2885
2886         implement layoutTestController.dumpEditingCallbacks() correctly.
2887
2888         * DumpRenderTree/qt/DumpRenderTree.cpp:
2889         (WebCore::DumpRenderTree::DumpRenderTree):
2890         * DumpRenderTree/qt/jsobjects.cpp:
2891         (LayoutTestController::reset):
2892         (LayoutTestController::dumpEditingCallbacks):
2893
2894 2007-10-24  Lars Knoll  <lars@trolltech.com>
2895
2896         Reviewed by Simon.
2897
2898         Implement support for testing editing.
2899
2900         * DumpRenderTree/qt/DumpRenderTree.cpp:
2901         (WebCore::DumpRenderTree::DumpRenderTree):
2902
2903 2007-10-23  Sam Weinig  <sam@webkit.org>
2904
2905         Check for null BSTR that can be passed to the UIDelegate methods
2906         from javascript null and undefined.  Fixes a failing test case on
2907         Windows (fast/dom/Window/alert-undefined.html)
2908
2909         Reviewed by Eric Seidel.
2910
2911         * DumpRenderTree/win/UIDelegate.cpp:
2912         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2913         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2914         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2915         (UIDelegate::webViewAddMessageToConsole):
2916
2917 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2918
2919         Reviewed by Darin.
2920         
2921         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2922
2923         * Scripts/build-testkjs:
2924
2925 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2926
2927         Reviewed by Darin.
2928
2929         - add wrapper that finds the right copy of testkjs
2930         
2931         * Scripts/sunspider-compare-results: Added.
2932
2933 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2934
2935         Reviewed by Sam.
2936
2937         - After talking with Steve I now see that the WebKit server must be
2938         running for DCOM to create the distributed objects, which makes sense
2939         and currently WebKit only allows one instance to be running at a time
2940         which avoids accidentally connecting to the wrong server
2941         - In light of this I have removed the code for the attach box and
2942         NotificationServer and known server names, since they are all extranious
2943         now.
2944
2945         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2946         names.
2947         (_tWinMain): Uses init instead of initUI.
2948         (droseraWndProc): No longer creats an attach dialog box.
2949         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2950         it's not manditory to call init before doing COM stuff.
2951         (Drosera::init): calls initUI and will call attach when the
2952         functionality exists. 
2953         (Drosera::initUI): Has changed very little.
2954         (Drosera::attach): Changed the signature to reflect that we no longer
2955         need the dictionary of known server names.
2956         * Drosera/win/Drosera.h: Removed notification classes and known server
2957         names.  Also renamed and moved some functions.
2958         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2959         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2960         headers to the resources folder. 
2961         * Drosera/win/resource.h: Removed the Attach box.
2962
2963 2007-10-22  Adam Roben  <aroben@apple.com>
2964
2965         Windows build fix
2966
2967         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2968
2969 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2970
2971         - Removed a leak that was fixed.
2972
2973         * Scripts/run-webkit-tests:
2974
2975 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2976
2977         Reviewed by Darin.
2978
2979         - Changed the Client so that the DebuggerDocument now own the
2980         ServerConnection.  This simplifies ownership and cleanup. 
2981
2982         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2983         ServerConnection.
2984         (DebuggerClient::initWithServerName):
2985         (DebuggerClient::didFinishLoadForFrame):
2986         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2987         ServerConnection.
2988         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2989         until after we have a server which we are attached to.
2990         (Drosera::initUI):
2991         (Drosera::attach):
2992         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2993         out previously.
2994
2995 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2996
2997         Reviewed by Nikolas.
2998
2999         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
3000
3001         * Scripts/run-javascriptcore-tests:
3002
3003 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3004
3005         Reviewed by Nikolas.
3006
3007         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
3008
3009         * Scripts/build-drosera:
3010         * Scripts/build-dumprendertree:
3011         * Scripts/build-testkjs:
3012         * Scripts/build-webkit:
3013         * Scripts/run-javascriptcore-tests:
3014         * Scripts/run-sunspider:
3015         * Scripts/run-webkit-tests:
3016         * Scripts/webkitdirs.pm:
3017
3018 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
3019
3020         Reviewed by Mark Rowe.
3021         
3022         Fix for local database support after r26879
3023         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
3024
3025         * Scripts/build-webkit:
3026
3027 2007-10-22  Holger Freyther  <zecke@selfish.org>
3028
3029         Reviewed by Simon Hausmann <hausmann@kde.org>.
3030
3031         - Do not build testkjs as an application bundle. This is
3032         needed for run-javascriptcore-tests on OSX.
3033         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
3034         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
3035         as we do not have -rpath on OSX.
3036
3037         * DumpRenderTree/qt/DumpRenderTree.pro:
3038         * Scripts/run-webkit-tests:
3039
3040 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3041
3042         Reviewed by aroben.
3043
3044         Fix support for Signed-off-by detection in prepare-ChangeLog
3045         --git-commit. The Signed-off-by tag does not appear in the header
3046         but usually at the end.
3047
3048         * Scripts/prepare-ChangeLog:
3049
3050 2007-10-21  Mark Rowe  <mrowe@apple.com>
3051
3052         Reviewed by Eric.
3053
3054         Fix run-javascriptcore-tests for Gtk.
3055
3056         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
3057
3058 2007-10-20  Eric Seidel  <eric@webkit.org>
3059
3060         Reviewed by aroben.
3061
3062         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
3063
3064 2007-10-20  Eric Seidel  <eric@webkit.org>
3065
3066         Reviewed by darin.
3067         
3068         Add improved argument handling to run-sunspider, including
3069         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
3070         Also re-factor code into subroutines
3071
3072         * Scripts/build-dumprendertree: removed bogus comments
3073         * Scripts/build-testkjs: Added.
3074         * Scripts/run-javascriptcore-tests: use build-testkjs
3075         * Scripts/run-sunspider: improved argument handling, abstraction
3076         * Scripts/run-webkit-tests: improved abstraction
3077
3078 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
3079
3080         Not reviewed, Windows build fix.
3081
3082         * DumpRenderTree/win/EventSender.cpp:
3083         (keyDownCallback):
3084
3085 2007-10-20  Darin Adler  <darin@apple.com>
3086
3087         Reviewed by Tim Hatcher.
3088
3089         - http://bugs.webkit.org/show_bug.cgi?id=15544
3090           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
3091           not rely on Apple-specific key codes
3092
3093         * DumpRenderTree/mac/EventSendingController.mm:
3094         (-[EventSendingController keyDown:withModifiers:]):
3095         Added named key "rightArrow". Later we could have a whole table of these.
3096         Also tweaked modifiers code a little.
3097
3098         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
3099
3100 2007-10-19  Darin Adler  <darin@apple.com>
3101
3102         Reviewed by Eric.
3103
3104         - http://bugs.webkit.org/show_bug.cgi?id=15566
3105           possible fix for leak seen in DumpRenderTree
3106
3107         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
3108         Delete the item if it's not put on the queue, since the caller has
3109         no way of knowing that. Would be better to have the parameter type
3110         be auto_ptr to express the fact that we take ownership.
3111
3112         - unrelated change
3113
3114         * Drosera/mac/main.m: Add missing include.
3115
3116 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3117
3118         Reviewed by Adam.
3119
3120         - This change should be identical but for some reason was not working
3121         on my machine.
3122
3123         * Scripts/prepare-ChangeLog:
3124
3125 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3126
3127         Reviewed by Oliver and Tim.
3128
3129         - Made use of RetainPtr to avoid retain and release issues and moved the
3130         log function to DebuggerDocumentPlatform, which seems to be a more
3131         logical place for it to live.
3132         - Also moved knownServers from the ServerConnection to
3133         DebuggerApplication to match the Windows code and because it makes sense
3134         that a connection knows its own server but not all of them.
3135
3136         * Drosera/mac/DebuggerClient.h: Moved the log function to
3137           DebuggerDocumentPlatform.
3138         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
3139           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
3140           call for the server name up from the ServerConnection class.
3141         (-[DebuggerClient dealloc]):
3142         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
3143           for the server name up from the ServerConnection.
3144         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
3145         (DebuggerDocument::platformPause):
3146         (DebuggerDocument::platformResume):
3147         (DebuggerDocument::platformStepInto):
3148         (DebuggerDocument::platformEvaluateScript):
3149         (DebuggerDocument::getPlatformCurrentFunctionStack):
3150         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3151         (DebuggerDocument::platformValueForScopeVariableNamed):
3152         (DebuggerDocument::platformLog): Log directly from here. No need to call
3153           DebuggerClient.
3154         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
3155           way I see it, a ServerConnection should only know about its connection
3156           and the group of all possible servers should be kept by the
3157           application.
3158         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
3159           currentServerName, it makes sense that the connection should know that
3160           name.
3161         (-[ServerConnection currentServerName]):
3162
3163 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3164
3165         Reviewed by Adam.
3166
3167         - Integrated changes from mac drosera.  Recently I've encapsulated
3168         out the server connection object from the rest of Drosera because
3169         it is very platform dependent right now and RPC is not implemented on
3170         windows.  This functionality, of communicating with the WebKit server
3171         is the next area I will be focusing on in Windows.
3172
3173         - Other changes and cleanup were made to organize the code and add notes
3174         on which parts still need work.  Also some mac code is added and
3175         commented out, to act as pseudocode for the logic of those parts.
3176
3177         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
3178           pointer.
3179         * Drosera/config.h: Added whitespace.
3180         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
3181           these files got moved into Drosera.h/cpp
3182         * Drosera/win/DebuggerApplication.h: Removed.
3183         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
3184           happened here to better match the logic flow of the same code on the 
3185           mac side and to use the new ServerConnection class.
3186         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
3187         (DebuggerClient::initWithServerName): Initializer that will set up the
3188           class to use a ServerConnection object.  This was necessary so I could
3189           create a DebuggerClient without having to initilaize it at
3190           construction.
3191         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
3192           will be the UIDelegate and FrameLoadDelegate.
3193         (DebuggerClient::AddRef): For IUnknown.
3194         (DebuggerClient::Release): For IUnknown.
3195         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
3196           this still needs to set the global context of the server, but
3197           IWebFrame does not have an accessor for the global context yet. 
3198         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
3199           this is a pass through for the same function in the document.
3200         (DebuggerClient::didReceiveTitle): Unimplemented part of
3201           FrameLoadDelegate this would change the title of the window.
3202         (DebuggerClient::createWebViewWithRequest): Part of the
3203           FrameLoadDelegate.  This is about new windows via Window.open() and
3204           how their delegates are set.
3205         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
3206           UIDelegate.  Just a debug function for printing messages.
3207         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
3208           because the Client should be the UIDelegate and FrameLoadDelegate
3209           to match the delegates on mac.
3210         (DebuggerClient::webViewLoaded): Added accessor method.
3211         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
3212           forgotten to add this file before.  This is where the platform
3213           dependent versions of the Documents functions live. Most of these are
3214           unimplemented because some piece of functionality does not exist on
3215           Windows yet.
3216         (DebuggerDocument::platformPause):
3217         (DebuggerDocument::platformResume):
3218         (DebuggerDocument::platformStepInto):
3219         (DebuggerDocument::platformEvaluateScript):
3220         (DebuggerDocument::getPlatformCurrentFunctionStack):
3221         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3222         (DebuggerDocument::platformValueForScopeVariableNamed):
3223         (DebuggerDocument::platformLog):
3224         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
3225           responsibilities becaue they belong in the Client. Also I laid the
3226           groundwork for attaching Drosera to a WebKit process
3227         (attachWndProc): Now if a server is selected the Client becomes it's
3228           delegate.
3229         (Drosera::Drosera): Added the construction of the Client and dictionary
3230           of server names. 
3231         (Drosera::initUI): This is no longer the delegates, the Client is.
3232         (Drosera::webViewLoaded): Now asks the Client instead of holding local
3233           state. 
3234         (Drosera::applicationDidFinishLaunching): Placeholder for needed
3235           notification registration when it's possible to implement.
3236         (Drosera::serverLoaded): Ditto
3237         (Drosera::serverUnloaded): Ditto
3238         (Drosera::attach): Attach Drosera to the WebKit server.
3239         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
3240         (Drosera::getInst): 
3241         (Drosera::setInst):
3242         (Drosera::knownServers):
3243         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
3244           and added the ServerConnection.
3245         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
3246         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
3247           Most of the functions are completely unimlemented because they cannot
3248           connect with the WebKit server, because one does not exist on Windows
3249           yet.
3250         (ServerConnection::initWithServerName): 
3251         (ServerConnection::~ServerConnection):
3252         (ServerConnection::setGlobalContext):
3253         (ServerConnection::pause):
3254         (ServerConnection::resume):
3255         (ServerConnection::stepInto):
3256         (ServerConnection::switchToServerNamed):
3257         (ServerConnection::applicationTerminating):
3258         (ServerConnection::serverConnectionDidDie):
3259         (ServerConnection::currentFrame):
3260         * Drosera/win/ServerConnection.h: Added. Ditto.
3261         (ServerConnection::ServerConnection):
3262
3263 2007-10-19  Alice Liu  <alice.liu@apple.com>
3264
3265         Reviewed by Darin.
3266
3267         Fix for these broken layout tests on Windows:
3268         
3269         fast/forms/focus-selection-input.html
3270         fast/forms/focus-selection-textarea.html
3271         fast/forms/select-accesskey.html
3272         
3273         * DumpRenderTree/win/EventSender.cpp:
3274         (keyDownCallback):
3275         correct the VK code for alt key.
3276         
3277 2007-10-19  Eric Seidel  <eric@webkit.org>
3278
3279         Reviewed by Mark Rowe.
3280         
3281         Make the GtkLauncher code slightly more readable.
3282
3283         * GtkLauncher/main.cpp:
3284         (setupMainMenu): Added.
3285         (setupMainWindowUI): Added.
3286         (main):
3287
3288 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
3289
3290         Rubber stamped by Adam.
3291         
3292         - don't delay-load WebKit in DumpRenderTree.
3293
3294         * DumpRenderTree/win/DumpRenderTree.vcproj:
3295
3296 2007-10-18  Dan Bernstein  <mitz@apple.com>
3297
3298         Reviewed by Adam Roben.
3299
3300         - fix <rdar://problem/5313523>
3301         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
3302
3303         * DumpRenderTree/mac/DumpRenderTree.mm:
3304         (dump): Changed to use _responseMIMEType.
3305
3306 2007-10-17  Adam Roben  <aroben@apple.com>
3307
3308         Make it possible to have Windows-specific tests and results
3309
3310         When searching for tests to run and the Skipped file, we will only
3311         look in platform/win and the cross-platform directory. When looking
3312         for expected results, we will look in platform/win, then
3313         platform/mac-leopard, then platform/mac, then finally the
3314         cross-platform directory.
3315
3316         Reviewed by Sam.
3317
3318         * Scripts/run-webkit-tests:
3319         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
3320         searching in the cross-platform directory.
3321         (sub buildPlatformHierarchy): Removed some unneeded calls to
3322         dirname/basename.
3323
3324 2007-10-17  Adam Roben  <aroben@apple.com>
3325
3326         Add back the call to register WebKit that we had before WebKitInitializer existed
3327
3328         This is needed to ensure that the right WebKit is used when
3329         instantiating COM objects.
3330
3331         Reviewed by Oliver.
3332
3333         * DumpRenderTree/win/debug_internal.vsprops: Define
3334         DEBUG_WEBKIT_HAS_SUFFIX.
3335         * DumpRenderTree/win/DumpRenderTree.cpp:
3336         (initialize):
3337
3338 2007-10-17  Adam Roben  <aroben@apple.com>
3339
3340         Import File::Basename in webkitdirs since we use it
3341
3342         * Scripts/webkitdirs.pm:
3343
3344 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
3345
3346         - Updated the tiger leaks list to make the internal bots green.
3347
3348         * Scripts/run-webkit-tests:
3349
3350 2007-10-17  Adam Roben  <aroben@apple.com>
3351
3352         Build fix for VC++ Express
3353
3354         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
3355         and ole32.lib.
3356
3357 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3358
3359         Reviewed by Sam.
3360
3361         - Minor mac improvements based on observations I made while implementing the
3362         Windows code.
3363
3364         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
3365         then hand it to the Client who will retain it, it should just be the client who
3366         creates and owns the server.
3367         (-[DebuggerApplication attach:]):
3368         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
3369         * Drosera/mac/DebuggerClient.mm: Creates the server.
3370         (-[DebuggerClient initWithServerName:]):
3371         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
3372         can instead forward declare what it needs.
3373
3374 2007-10-16  Darin Adler  <darin@apple.com>
3375
3376         Reviewed by Geoff Garen.
3377
3378         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
3379         want to turn failing tests into platform-specific test results. Also did a
3380         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
3381         would take the type of results into account only some of the time.
3382
3383 2007-10-16  Adam Roben  <aroben@apple.com>
3384
3385         Add a new nightly launcher script for Windows
3386
3387         This new script is for versions of Safari that don't delay-load
3388         WebKit. I had to make FindSafari be able to print out the nightly
3389         launcher script on stdout because Windows shell scripts can't capture
3390         the output from a command into an environment variable.
3391
3392         Reviewed by Steve.
3393
3394         * FindSafari/FindSafari.cpp:
3395         (_tmain): Added /printSafariLauncher option.
3396         * Scripts/run-webkit-nightly.cmd: Added.
3397
3398 2007-10-16  Adam Roben  <aroben@apple.com>
3399
3400         Replace WebKitInitializer with FindSafari
3401
3402         We now rely on setting the PATH environment variable to tell Windows
3403         where to find WebKit and its dependencies (similar to
3404         DYLD_FRAMEWORK_PATH on Mac).
3405
3406         This change also make DumpRenderTree no longer delay-load WebKit.
3407
3408         Reviewed by Sam.
3409
3410         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
3411         FindSafari.
3412         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
3413         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
3414         WebKitInitializer, don't delay-load WebKit.
3415         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
3416         * Scripts/run-webkit-tests: Ditto.
3417         * Scripts/webkitdirs.pm:
3418         (sub setPathForRunningWebKitApp): Added.
3419         * WebKitInitializer/WebKitInitializer.cpp: Removed.
3420         * WebKitInitializer/WebKitInitializer.h: Removed.
3421         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
3422         * WebKitInitializer/debug.vsprops: Removed.
3423         * WebKitInitializer/debug_internal.vsprops: Removed.
3424         * WebKitInitializer/release.vsprops: Removed.
3425
3426 2007-10-16  Adam Roben  <aroben@apple.com>
3427
3428         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
3429
3430         http://bugs.webkit.org/show_bug.cgi?id=15532
3431
3432         FindSafari simply prints the location of an installed Safari.exe on
3433         stdout.
3434
3435         Reviewed by Darin.
3436
3437         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
3438         (getStringValue):
3439         (getWebViewCLSID):
3440         (getInstalledWebKitDirectory):
3441         (_tmain):
3442         * FindSafari/FindSafari.vcproj: Added.
3443         * Scripts/webkitdirs.pm:
3444         (sub installedSafariPath): Added. Calls FindSafari on Windows.
3445
3446 2007-10-16  Adam Roben  <aroben@apple.com>
3447
3448         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
3449
3450         Reviewed by Kevin McCullough.
3451
3452         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
3453         when referring to WebKit.dll.
3454         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
3455         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
3456         * DumpRenderTree/win/release.vsprops: Ditto.
3457         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
3458         never have a _debug suffix on WebKit.dll.
3459         * WebKitInitializer/WebKitInitializer.cpp:
3460         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
3461         specified.
3462         * WebKitInitializer/debug_internal.vsprops: Added
3463         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
3464
3465 2007-10-16  Darin Adler  <darin@apple.com>
3466
3467         Reviewed by Adele.
3468
3469         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3470         Remove now-unneeded control/alt key hack; the tests have been updated.
3471
3472 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3473
3474         - Updated leaks list because our internal bot upgraded it's version of leopard and 
3475         one of the leaks was fixed between that revision and the bot's previous version of
3476         leopard.
3477
3478         * Scripts/run-webkit-tests:
3479
3480 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
3481
3482         Reviewed by Tim.
3483
3484         - I encapsulated out the server connecton functionality because it is a specific part
3485         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
3486         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
3487         Windows.  So the majority of this patch is moving preexisting functionality.
3488
3489         - Also I removed the prefix header and changed to use config.h because it is more
3490         standard on how we use config.h in windows and it didn't make much sense to keep
3491         the prefix header and the config.h
3492
3493         * Drosera/DebuggerDocument.cpp:
3494         (DebuggerDocument::DebuggerDocument):
3495         * Drosera/DebuggerDocument.h:
3496         * Drosera/config.h:
3497         * Drosera/mac/DebuggerApplication.mm:
3498         (-[DebuggerApplication attach:]):
3499         * Drosera/mac/DebuggerClient.h:
3500         * Drosera/mac/DebuggerClient.mm:
3501         (-[DebuggerClient initWithServerConnection:]):
3502         (-[DebuggerClient dealloc]):
3503         (-[DebuggerClient windowDidLoad]):
3504         (-[DebuggerClient windowWillClose:]):
3505         (-[DebuggerClient webView:didFinishLoadForFrame:]):
3506         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
3507         * Drosera/mac/DebuggerDocumentPlatform.mm:
3508         (DebuggerDocument::platformPause):
3509         (DebuggerDocument::platformResume):
3510         (DebuggerDocument::platformStepInto):
3511         (DebuggerDocument::platformEvaluateScript):
3512         (DebuggerDocument::getPlatformCurrentFunctionStack):
3513         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3514         (DebuggerDocument::platformValueForScopeVariableNamed):
3515         (DebuggerDocument::platformLog):
3516         * Drosera/mac/Drosera.pch: Removed.
3517         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3518         * Drosera/mac/ServerConnection.h: Added.
3519         * Drosera/mac/ServerConnection.mm: Added.
3520         (-[ServerConnection initWithServerName:]):
3521         (-[ServerConnection dealloc]):
3522         (-[ServerConnection setGlobalContext:]):
3523         (-[ServerConnection pause]):
3524         (-[ServerConnection resume]):
3525         (-[ServerConnection stepInto]):
3526         (-[ServerConnection switchToServerNamed:]):
3527         (-[ServerConnection applicationTerminating:]):
3528         (-[ServerConnection serverConnectionDidDie:]):
3529         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3530         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3531         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
3532         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3533         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3534         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3535         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3536         (-[ServerConnection currentFrame]):
3537         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
3538         (-[ServerConnection knownServers]):
3539
3540 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
3541
3542         Reviewed by Eric.
3543
3544         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
3545           Script to automatically search nightly builds for regressions (bisect-builds)
3546
3547         * Scripts/bisect-builds: Added.
3548
3549 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
3550
3551         Reviewed by Darin.
3552
3553         - New JavaScript benchmark
3554         http://bugs.webkit.org/show_bug.cgi?id=15515
3555
3556         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
3557         current development or release build of JavaScriptCore.
3558
3559 2007-10-15  Mark Rowe  <mrowe@apple.com>
3560
3561         Reviewed by Sam.
3562
3563         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
3564
3565         * Scripts/webkitdirs.pm:
3566         - Change checkArgv to remove the options from @ARGV to prevent
3567         them from interfering with further option processing.
3568         - Fix logic error in determineIsQt that would prevent it from bailing out early.
3569         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
3570         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
3571         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
3572
3573 2007-10-15  Darin Adler  <darin@apple.com>
3574
3575         Reviewed by Sam.
3576
3577         - added logging of window.prompt and window.confirm
3578
3579         * DumpRenderTree/mac/UIDelegate.mm:
3580         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3581         Implement the recommended delegate rather than the deprecated one.
3582         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
3583         Added.
3584         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
3585         Added.
3586
3587         * DumpRenderTree/win/UIDelegate.h:
3588         * DumpRenderTree/win/UIDelegate.cpp:
3589         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
3590         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
3591         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
3592         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
3593
3594 2007-10-15  Alice Liu  <alice.liu@apple.com>
3595
3596         Reviewed by Sam Weinig.
3597
3598         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
3599
3600         * DumpRenderTree/win/DumpRenderTree.cpp:
3601         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
3602         (main): allocate the global policy delegate for DRT's custom use
3603         * DumpRenderTree/win/DumpRenderTree.vcproj:
3604         Adding files to project
3605         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
3606         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3607         (LayoutTestController::setCustomPolicyDelegate):
3608         set the webview's policy delegate to DRT's custom one if the test requests it.
3609         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
3610         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
3611         (PolicyDelegate::PolicyDelegate):
3612         (PolicyDelegate::QueryInterface):
3613         (PolicyDelegate::AddRef):
3614         (PolicyDelegate::Release):
3615         (PolicyDelegate::decidePolicyForNavigationAction):
3616         * DumpRenderTree/win/PolicyDelegate.h: Added.
3617         (PolicyDelegate::decidePolicyForNewWindowAction):