Reviewed by Adam Roben.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-11-30  Sam Weinig  <sam@webkit.org>
2
3         Reviewed by Adam Roben.
4
5         Fix drawSelectionRect to actually draw the selection rect.
6
7         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
8         (drawSelectionRect):
9
10 2007-11-30  Darin Adler  <darin@apple.com>
11
12         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
13
14 2007-11-30  Darin Adler  <darin@apple.com>
15
16         * Scripts/do-webcore-rename: Get ready for some future renaming.
17
18 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
19
20         Reviewed by Adam.
21
22         - Removed some unnecessary functions and changed an unused return type. 
23
24         * Drosera/win/DebuggerClient.cpp:
25         (registerConsoleClass):
26         * Drosera/win/DebuggerClient.h:
27         * Drosera/win/Drosera.cpp:
28         (registerDroseraClass):
29
30 2007-11-28  Alp Toker  <alp@atoker.com>
31
32         Reviewed by Timothy Hatcher.
33
34         http://bugs.webkit.org/show_bug.cgi?id=16174
35         [GTK] Use "URI" not "URL" in public API
36
37         Replace use of the term "URL" with "URI" in public headers,
38         documentation and some internal code to match GLib/GTK+ convention.
39
40         This is now mentioned in the API guidelines:
41           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
42
43         * GtkLauncher/main.c:
44         (activate_uri_entry_cb):
45         (title_change_cb):
46         (create_toolbar):
47         (main):
48
49 2007-11-29  Anders Carlsson  <andersca@apple.com>
50
51         Reviewed by Sam.
52
53         <rdar://problem/5230478>
54         FrameLoadDelegate callbacks are not dumped in DRT.
55         
56         * DumpRenderTree/win/DumpRenderTree.cpp:
57         (shouldLogFrameLoadDelegates):
58         (runTest):
59         (main):
60         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
61         (BSTRtoString):
62         (descriptionSuitableForTestResult):
63         (FrameLoadDelegate::QueryInterface):
64         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
65         (FrameLoadDelegate::didFailProvisionalLoadWithError):
66         (FrameLoadDelegate::didCommitLoadForFrame):
67         (FrameLoadDelegate::didFinishLoadForFrame):
68         (FrameLoadDelegate::willCloseFrame):
69         (FrameLoadDelegate::didClearWindowObject):
70         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
71         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
72         * DumpRenderTree/win/FrameLoaderDelegate.h:
73         (FrameLoadDelegate::windowScriptObjectAvailable):
74         (FrameLoadDelegate::didFirstLayoutInFrame):
75
76 2007-11-29  Sam Weinig  <sam@webkit.org>
77
78         Reviewed by Anders.
79
80         Add database quota UIDelegates methods to DRT UIDelegate.
81
82         * DumpRenderTree/mac/UIDelegate.mm:
83         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
84         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
85
86 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
87
88         Reviewed by Sam.
89
90         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
91         dying and vice versa.
92         - This fix will allow Drosera and Safari to reconnect if either of them
93         closes correctly, but does not fix the case where one of them dies
94         silently.
95
96         * Drosera/win/ServerConnection.cpp:
97         (ServerConnection::attemptToCreateServerConnection): Added a safety
98         check, because it's possilbe to try to connect to a server that's dying.
99         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
100         the server has died.
101         * Drosera/win/ServerConnection.h: Added the new function and removed
102         an unnecessary member.
103
104 2007-11-29  Anders Carlsson  <andersca@apple.com>
105
106         * DumpRenderTree/win/DumpRenderTree.vcproj:
107         Add shlwapi.lib to all configurations.
108
109 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
110
111         - Build fix.  Added additional includes for VS Express to the Release
112         project.
113
114         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
115
116 2007-11-29  Anders Carlsson  <andersca@apple.com>
117
118         Reviewed by Adam.
119
120         <rdar://problem/5132005>
121         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
122         
123         * DumpRenderTree/win/DumpRenderTree.vcproj:
124         Add shlwapi.lib
125         
126         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
127         (LayoutTestController::setUserStyleSheetEnabled):
128         Implement this.
129         
130         (appendComponentToPath):
131         New method which wraps the Win32 API PathAppend.
132         
133         (followShortcuts):
134         New method which checks if a file points to a shortcut and
135         follows the shortcut.
136         
137         (resolveCygwinPath):
138         New method that takes a cygwin unix-style path and returns the Win32 path.
139         
140         (cfStringRefToWString):
141         
142         (LayoutTestController::setUserStyleSheetLocation):
143         Implement this.
144
145 2007-11-29  Alice Liu  <alice.liu@apple.com>
146
147         Reviewed by Adam.
148
149         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
150
151         * DumpRenderTree/win/EventSender.cpp:
152         (keyDownCallback):
153         uppercase letters were being sent as lowercase letters without the shift key down.
154
155 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
156
157         - Windows build fix. VS express needs some love.
158
159         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
160
161 2007-11-28  Darin Adler  <darin@apple.com>
162
163         Reviewed by Adam Roben.
164
165         * DumpRenderTree/mac/EventSendingController.mm:
166         (-[EventSendingController keyDown:withModifiers:]):
167         Send capital letters through as lowercase letters with the shift key down
168         rather than sending them as if they were highly unusual "capital letter keys".
169
170         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
171         where you need to update results and more tests are failing than before.
172
173 2007-11-28  Anders Carlsson  <andersca@apple.com>
174
175         Reviewed by Darin.
176
177         <rdar://problem/5132001>
178         contextClick is not implemented in DRT on Windows.
179         
180         * DumpRenderTree/win/EventSender.cpp:
181         (contextClickCallback):
182         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
183         by a WM_RBUTTONUP message.
184         
185         * DumpRenderTree/win/UIDelegate.cpp:
186         (UIDelegate::hasCustomMenuImplementation):
187         (UIDelegate::trackCustomPopupMenu):
188         * DumpRenderTree/win/UIDelegate.h:
189         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
190         menu from being shown (and causing the DRT to hang).
191
192 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
193
194         Reviewed by Darin.
195
196         Fix DumpRenderTree ObjC bug comparing strings.
197
198         * DumpRenderTree/mac/ObjCController.m:
199         (-[ObjCController identityIsEqual::]): Compare strings with string
200         equality instead of identiy equality.
201
202 2007-11-27  Timothy Hatcher  <timothy@apple.com>
203
204         Reviewed by Sam.
205
206         Reset the authorAndUserStylesEnabled preference
207         back to YES for each test. Fixes the broken tests.
208
209         * DumpRenderTree/mac/DumpRenderTree.mm:
210         (resetWebViewToConsistentStateBeforeTesting):
211
212 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
213
214         Reviewed by Adam.
215
216         - Drosera now displays the console window, although it cannot currently
217         process JavaScript.
218
219         * Drosera/win/DebuggerClient.cpp: Shows the console window.
220         (registerConsoleClass): Implemented.
221         (consoleWndProc): Implemented.
222         (DebuggerClient::onSize): Implemented.
223         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
224         new window.
225         * Drosera/win/DebuggerClient.h: Added needed method and members for 
226         creating and maintaining a new window.
227         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
228         lines of code to more appropriate places.
229         (Drosera::handleCommand):
230         (Drosera::initUI):
231         (Drosera::onSize):
232         (Drosera::attach):
233
234 2007-11-27  Timothy Hatcher  <timothy@apple.com>
235
236         Reviewed by Dave Hyatt.
237
238         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
239         
240         Add support for disabling author and user styles for testing.
241
242         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
243         * DumpRenderTree/LayoutTestController.cpp:
244         (setAuthorAndUserStylesEnabledCallback):
245         (LayoutTestController::staticFunctions):
246         * DumpRenderTree/LayoutTestController.h:
247         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
248         (LayoutTestController::setAuthorAndUserStylesEnabled):
249         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
250         (LayoutTestController::setAuthorAndUserStylesEnabled):
251
252 2007-11-26  Dan Bernstein  <mitz@apple.com>
253
254         - Tiger build fix.
255
256         * DumpRenderTree/mac/Configurations/Base.xcconfig:
257
258 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
259
260         Reviewed by Maciej.
261
262         - Implemented displaying variables for Drosera on Win.
263
264         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
265         that retrieve variables to not hold onto the return value since it's
266         not returned.  Also changed to use the new signatures of the retrieval
267         functions.
268         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
269         (DebuggerDocument::platformValueForScopeVariableNamed):
270         * Drosera/win/Drosera.cpp: Removed a needless TODO.
271         (droseraWndProc):
272
273 2007-11-26  Sam Weinig  <sam@webkit.org>
274
275         Cleanup names of painting and repainting functions.
276
277         Reviewed by Adam Roben.
278
279         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
280         (drawSelectionRect): was drawSelectionRectIntoContext.
281         (dumpWebViewAsPixelsAndCompareWithExpected):
282         * DumpRenderTree/cg/PixelDumpSupportCG.h:
283         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
284         (paintWebView): was drawWebViewIntoContext.
285         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
286
287 2007-11-26  Sam Weinig  <sam@webkit.org>
288
289         Reviewed by Dan Bernstein.
290
291         - Leopard build fix
292
293         * DumpRenderTree/mac/Configurations/Base.xcconfig:
294
295 2007-11-26  Sam Weinig  <sam@webkit.org>
296
297         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
298         Use shared PixelDumpSupport for Mac DRT
299
300         Reviewed by Adam Roben.
301
302         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
303         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
304         * DumpRenderTree/cg/ImageDiffCG.cpp:
305         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
306         (drawSelectionRectIntoContext):
307         (dumpWebViewAsPixelsAndCompareWithExpected):
308         * DumpRenderTree/cg/PixelDumpSupportCG.h:
309         * DumpRenderTree/mac/Configurations/Base.xcconfig:
310         * DumpRenderTree/mac/DumpRenderTree.mm:
311         (dump):
312         * DumpRenderTree/mac/ImageDiff.m: Removed.
313         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
314         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
315         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
316         (setDefaultColorProfileToRGB):
317         (getBitmapContextFromWebView):
318         (drawWebViewIntoContext):
319         (repaintWithVerticalSweep):
320         (repaintWithHorizontalSweep):
321         (getSelectionRect):
322         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
323
324 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
325
326         Bug 16052: prepare-ChangeLog doesn't report deleted files
327         <http://bugs.webkit.org/show_bug.cgi?id=16052>
328
329         Reviewed by Sam.
330
331         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
332
333 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
334
335         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
336         <http://bugs.webkit.org/show_bug.cgi?id=15864>
337
338         Reviewed by Adam.
339
340         Roll functionality of merge-changelog into resolve-ChangeLogs
341         script.  The script now checks for ChangeLog.rej and
342         ChangeLog.orig files first.  If it finds them, it uses the
343         ChangeLog.rej file as a patch (in old contextual diff format) to
344         apply with --fuzz=3.
345
346         * Scripts/merge-changelog: Removed.
347         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
348
349 2007-11-25  Sam Weinig  <sam@webkit.org>
350
351         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
352
353         Reviewed by Mark Rowe.
354
355         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
356         * DumpRenderTree/mac/Configurations/Base.xcconfig:
357         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
358         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
359         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
360
361 2007-11-25  Sam Weinig  <sam@webkit.org>
362
363         Convert DumpRenderTree to ues .xcconfig files.
364
365         Reviewed by Mark Rowe.
366
367         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
368         * DumpRenderTree/mac/Configurations: Added.
369         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
370         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
371         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
372
373 2007-11-25  Sam Weinig  <sam@webkit.org>
374
375         Add ForwardingHeaders to wtf for DumpRenderTree.
376
377         Reviewed by Mark Rowe.
378
379         * DumpRenderTree/DumpRenderTree.h:
380         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
381         * DumpRenderTree/ForwardingHeaders: Added.
382         * DumpRenderTree/ForwardingHeaders/wtf: Added.
383         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
384         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
385         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
386         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
387         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
388         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
389         * DumpRenderTree/LayoutTestController.cpp:
390         * DumpRenderTree/WorkQueue.cpp:
391         * DumpRenderTree/mac/DumpRenderTree.mm:
392         * DumpRenderTree/mac/FrameLoadDelegate.mm:
393         * DumpRenderTree/mac/JavaScriptThreading.cpp:
394         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
395         * DumpRenderTree/mac/ObjCController.m:
396         * DumpRenderTree/mac/UIDelegate.mm:
397         * DumpRenderTree/mac/WorkQueueItemMac.mm:
398
399 2007-11-25  Adam Roben  <aroben@apple.com>
400
401         Fix some test failures caused by r28019
402
403         Now that stdout is in binary mode, we need to always use printf
404         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
405         the output.
406
407         Reviewed by Sam.
408
409         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
410         printf.
411         (UIDelegate::runJavaScriptAlertPanelWithMessage):
412         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
413         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
414         (UIDelegate::webViewAddMessageToConsole):
415
416 2007-11-25  Adam Roben  <aroben@apple.com>
417
418         Set the font smoothing preference in DRT
419
420         This makes the pixel results on Windows closer to the Mac results.
421
422         Reviewed by Mitz.
423
424         * DumpRenderTree/win/DumpRenderTree.cpp:
425         (initializePreferences):
426
427 2007-11-25  Adam Roben  <aroben@apple.com>
428
429         Port ImageDiff to CG and C++
430
431         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
432         <rdar://5071708>
433
434         Reviewed by Sam.
435
436         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
437         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
438         (main):
439         (createImageFromStdin):
440         (compareImages):
441         (getDifferenceBitmap):
442         (computePercentageDifferent):
443         * DumpRenderTree/win/ImageDiff.vcproj: Added.
444
445 2007-11-25  Adam Roben  <aroben@apple.com>
446
447         Fix image diff link generation on Windows
448
449         Reviewed by Sam.
450
451         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
452         to toURL.
453
454 2007-11-25  Adam Roben  <aroben@apple.com>
455
456         Implement pixel dumping in Windows DRT
457
458         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
459         <rdar://5071708>
460
461         Reviewed by Sam.
462
463         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
464         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
465         Content-Length header.
466         (getMD5HashStringForBitmap):
467         (dumpWebViewAsPixelsAndCompareWithExpected):
468         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
469         * DumpRenderTree/win/DumpRenderTree.cpp:
470         (dump): Do a pixel dump if requested.
471         (main): Parse pixel test options.
472         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
473         the cg/ subdirectory to the include path.
474         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
475         available in a header or import library, so we have to go through this
476         LoadLibrary/GetProcAddress dance to use them.
477         (cryptDLL):
478         (init):
479         (update):
480         (final):
481         (MD5_Init):
482         (MD5_Update):
483         (MD5_Final):
484         * DumpRenderTree/win/MD5.h: Added.
485         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
486         moved up to the top level to share it with Mac eventually.
487         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
488         (getBitmapContextFromWebView): Forces the WebView to paint using a
489         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
490
491 2007-11-25  Adam Roben  <aroben@apple.com>
492
493         Clean up Windows DRT's option parsing a little bit
494
495         Reviewed by Sam.
496
497         * DumpRenderTree/win/DumpRenderTree.cpp:
498         (main): Put non-option arguments into a Vector.
499
500 2007-11-25  Adam Roben  <aroben@apple.com>
501
502         Make Windows DRT stop changing LF into CRLF
503
504         Reviewed by Sam.
505
506         * DumpRenderTree/win/DumpRenderTree.cpp:
507         (main): Put stdout in binary mode.
508         * Scripts/run-webkit-tests: Remove the CRLF hack.
509
510 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
511
512         Removed empty directory.
513
514         * Scripts/resources: Removed.
515
516 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
517
518         Fix bisect-builds to work with recent WebKit nightly builds.
519
520         Reviewed by Dan.
521
522         * Scripts/bisect-builds: Check for the 
523         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
524         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
525         to WebKit.app/Contents/Resources.
526
527 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
528
529         Reviewed by Maciej.
530
531         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
532         not closed (affects digg.com)
533
534         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
535         one after finishing with a test to avoid having its delayed onload handler firing when
536         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
537         but it helps somewhat.
538
539 2007-11-22  Mark Rowe  <mrowe@apple.com>
540
541         Reviewed by Alp Toker.
542
543         Fix build-webkit to propagate make's exit status if it fails.
544
545         * Scripts/webkitdirs.pm:
546
547 2007-11-22  Dan Bernstein  <mitz@apple.com>
548
549         Reviewed by Mark Rowe.
550
551         - fix crash when running pixel tests
552
553         * DumpRenderTree/mac/DumpRenderTree.mm:
554         (dumpRenderTree): Parse the command line options before setting up the
555         environment so that we know if we need to set up the pixel dump
556         machinery.
557
558 2007-11-21  Eric Seidel  <eric@webkit.org>
559
560         Speculative build fix for Tiger.
561
562         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
563
564 2007-11-21  Eric Seidel  <eric@webkit.org>
565
566         Reviewed by Tim Hatcher.
567
568         Break out more of DumpRenderTree.mm into individual files
569
570         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
571         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
572         (checkedMalloc):
573         (checkedRealloc):
574         (makeLargeMallocFailSilently):
575         * DumpRenderTree/mac/CheckedMalloc.h: Added.
576         * DumpRenderTree/mac/DumpRenderTree.mm:
577         (crashHandler):
578         (dump):
579         * DumpRenderTree/mac/DumpRenderTreeMac.h:
580         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
581         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
582         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
583         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
584         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
585         (javaScriptThreads):
586         (runJavaScriptThread):
587         (startJavaScriptThreads):
588         (stopJavaScriptThreads):
589         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
590         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
591         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
592         (restoreColorSpace):
593         (setDefaultColorProfileToRGB):
594         (initializeColorSpaceAndScreeBufferForPixelTests):
595         (md5HashStringForBitmap):
596         (dumpWebViewAsPixelsAndCompareWithExpected):
597
598 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
599
600         Move install-unix-extras to wx directory as it seems only to be used by that 
601         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
602         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
603         have install-unix-extras install into WebKitLibraries as per
604         convention.
605         
606         Reviewed by Mark Rowe.
607
608         * Scripts/install-unix-extras: Removed.
609         * wx/build-wxwebkit:
610         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
611
612 2007-11-21  Eric Seidel  <eric@webkit.org>
613
614         Reviewed by Adam.
615
616         More refactoring for greater code readability
617
618         * DumpRenderTree/mac/DumpRenderTree.mm:
619         (initializeGlobalsFromCommandLineOptions):
620         (initializeColorSpaceAndScreeBufferForPixelTests):
621         (addTestPluginsToPluginSearchPath):
622         (useLongRunningServerMode):
623         (runTestingServerLoop):
624         (prepareConsistentTestingEnvironment):
625         (dumpRenderTree):
626         (main):
627         (dumpFramesAsText):
628         (dumpBackForwardListForWebView):
629         (sizeWebViewForCurrentTest):
630         (methodNameStringForFailedTest):
631         (dumpBackForwardListForAllWindows):
632         (dumpWebViewAsPixelsAndCompareWithExpected):
633         (invalidateAnyPreviousWaitToDumpWatchdog):
634         (dump):
635         * DumpRenderTree/mac/DumpRenderTreeMac.h:
636         * DumpRenderTree/mac/UIDelegate.mm:
637         (-[UIDelegate webView:createWebViewWithRequest:]):
638
639 2007-11-21  Eric Seidel  <eric@webkit.org>
640
641         Reviewed by Tim Hatcher.
642
643         Abstract more of DRT into static methods
644
645         * DumpRenderTree/mac/DumpRenderTree.mm:
646         (setDefaultsToConsistentValuesForTesting):
647         (setupSignalHandlers):
648         (allocateGlobalControllers):
649         (releaseAndZero):
650         (releaseGlobalControllers):
651         (dumpRenderTree):
652         (shouldLogFrameLoadDelegates):
653         (createCFURLFromPathOrURL):
654         (resetWebViewToConsistentStateBeforeTesting):
655         (runTest):
656
657 2007-11-21  Eric Seidel  <eric@webkit.org>
658
659         Reviewed by Tim Hatcher.
660
661         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
662
663         * DumpRenderTree/DumpRenderTree.h:
664         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
665         * DumpRenderTree/mac/DumpRenderTree.mm:
666         (dumpRenderTree):
667         (dump):
668         (runTest):
669         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
670         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
671         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
672         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
673         (-[DumpRenderTreePasteboard declareType:owner:]):
674         (+[LocalPasteboard alloc]):
675         (-[LocalPasteboard init]):
676         (-[LocalPasteboard dealloc]):
677         (-[LocalPasteboard name]):
678         (-[LocalPasteboard releaseGlobally]):
679         (-[LocalPasteboard declareTypes:owner:]):
680         (-[LocalPasteboard addTypes:owner:]):
681         (-[LocalPasteboard changeCount]):
682         (-[LocalPasteboard types]):
683         (-[LocalPasteboard availableTypeFromArray:]):
684         (-[LocalPasteboard setData:forType:]):
685         (-[LocalPasteboard dataForType:]):
686         (-[LocalPasteboard setPropertyList:forType:]):
687         (-[LocalPasteboard setString:forType:]):
688         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
689         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
690         (+[DumpRenderTreeWindow allWindows]):
691         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
692         (-[DumpRenderTreeWindow dealloc]):
693         (-[DumpRenderTreeWindow isKeyWindow]):
694         (-[DumpRenderTreeWindow keyDown:]):
695
696 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
697
698         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
699         it indiscriminately copies any headers inside JavaScriptCore,
700         which includes Tiger ICU headers. 
701
702         * wx/build-wxwebkit:
703         Don't run WebCore/move-js-headers.sh any longer.
704
705 2007-11-20  Adam Treat  <treat@kde.org>
706
707         Reviewed by David Kilzer.
708
709         * Prepend git branch name to $baseProductDir
710
711         * Scripts/VCSUtils.pm:
712         * Scripts/webkitdirs.pm:
713
714 2007-11-20  Mark Rowe  <mrowe@apple.com>
715
716         Reviewed by Simon Hausmann.
717
718         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
719         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
720         Have it trigger a "make distclean" rather than "make clean" to ensure that the
721         built product and generated Makefile's are removed.
722
723 2007-11-19  Alp Toker  <alp@atoker.com>
724
725         Reviewed by Mark Rowe.
726
727         http://bugs.webkit.org/show_bug.cgi?id=16040
728         [GTK] GtkLauncher should be written in C
729
730         Port GtkLauncher to plain C.
731
732         Use a more conventional GTK+ coding style.
733
734         Use a toolbar instead of menus.
735
736         Various signature fixes and cleanups.
737
738         Add a license header. Assume all previous modifications were copyright
739         assigned to Apple Inc. by default.
740
741         * GtkLauncher/GtkLauncher.pro:
742         * GtkLauncher/main.c: Added.
743         (activate_url_entry_cb):
744         (update_title):
745         (link_hover_cb):
746         (title_change_cb):
747         (progress_change_cb):
748         (destroy_cb):
749         (go_back_cb):
750         (go_forward_cb):
751         (create_browser):
752         (create_statusbar):
753         (create_toolbar):
754         (create_window):
755         (main):
756         * GtkLauncher/main.cpp: Removed.
757
758 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
759
760         Build script fixes to ensure they do the right thing for the 
761         wx port, and update build-wxwebkit to reflect the way the
762         build scripts now work.
763
764         Reviewed by Adam.
765
766         * Scripts/build-testkjs:
767         * Scripts/build-webkit:
768         * Scripts/run-javascriptcore-tests:
769         * Scripts/webkitdirs.pm:
770         * wx/build-wxwebkit:
771
772 2007-11-18  Eric Seidel  <eric@webkit.org>
773
774         Reviewed by Anders.
775
776         Make run-javascriptcore-tests report failures on exit (to support git bisect)
777
778         * Scripts/run-javascriptcore-tests:
779
780 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
781
782         Reviewed by Adam Roben.
783
784         Make run-webkit-tests work with Windows debug build.
785
786         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
787         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
788         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
789         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
790         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
791
792 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
793
794         Add wxWebKit sample and build script, and integrate it with 
795         build-webkit. Also make build-webkit --clean work for all
796         ports.
797
798         Reviewed by Darin Adler.
799
800         * Scripts/build-webkit:
801         * Scripts/webkitdirs.pm:
802         * wx: Added.
803         * wx/browser: Added.
804         * wx/browser/browser.bkl: Added.
805         * wx/browser/browser.cpp: Added.
806         * wx/build-wxwebkit: Added.
807
808 2007-11-17  Adam Roben  <aroben@apple.com>
809
810         Make it easy to run Safari in the debugger on Windows
811
812         I've added a new script, debug-safari, which launches Safari in the
813         debugger. On OS X it just calls gdb-safari.
814
815         Reviewed by Mark Rowe.
816
817         * FindSafari/FindSafari.cpp:
818         (_tmain): Added a /debugger flag, which in combination with
819         /printSafariLauncher will print a script that launches Safari in the
820         debugger.
821         * Scripts/debug-safari: Added.
822         * Scripts/run-safari: Changed to call runSafari().
823         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
824         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
825         first argument along to FindSafari.
826         * Scripts/webkitdirs.pm:
827         (sub runSafari): Added.
828
829 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
830
831         Reviewed by Adam Roben.
832
833         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
834
835 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
836
837         Reviewed by David Kilzer.
838
839         The git config command was renamed to repo-config at some point. This
840         change tries git config and then git repo-config if the first fails.
841
842         * Scripts/prepare-ChangeLog:
843         (gitConfig):
844
845 2007-11-16  Dan Bernstein  <mitz@apple.com>
846
847         Reviewed by Darin Adler and Sam Weinig.
848
849         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
850
851         * DumpRenderTree/win/EventSender.cpp:
852         (keyDownCallback): For characters that cannot be entered on the active
853         keyboard layout, send a WM_CHAR message with the character along with
854         a WM_KEYDOWN message with a virtual key code of 255.
855
856 2007-11-16  Mark Rowe  <mrowe@apple.com>
857
858         Reviewed by Tim Hatcher.
859
860         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
861
862         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
863         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
864
865 2007-11-15  Adam Roben  <aroben@apple.com>
866
867         Make run-safari actually work on Windows
868
869         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
870         chdir call.
871
872 2007-11-14  Adam Roben  <aroben@apple.com>
873
874         Updates to Safari launching now that 3.0.4 is released
875
876         Reviewed by Sam.
877
878         * FindSafari/FindSafari.cpp:
879         (getWebViewCLSID): Use version-independent ProgID.
880         * Scripts/run-safari: Use run-webkit-nightly.cmd.
881
882 2007-11-14  Anders Carlsson  <andersca@apple.com>
883
884         Reviewed by Adam.
885
886         <rdar://problem/5309081>
887         In DRT, "plugin.logDestroy = true" not working on Windows.
888         
889         * DumpRenderTree/win/TestNetscapePlugin/main.c:
890         (NPP_Destroy):
891
892 2007-11-14  Eric Seidel  <eric@webkit.org>
893
894         Reviewed by Sam.
895
896         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
897
898 2007-11-14  Anders Carlsson  <andersca@apple.com>
899
900         Reviewed by Adam.
901
902         <rdar://problem/5141186>
903         window.layoutTestController.setWindowIsKey is not implemented in DRT.
904         
905         Implement setWindowIsKey.
906         
907         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
908         (LayoutTestController::setWindowIsKey):
909
910 2007-11-13  Sam Weinig  <sam@webkit.org>
911
912         Reviewed by Adam Roben.
913
914         Fix for <rdar://problem/5382579>
915         http/tests/security/cross-frame-access-put.html reports large 
916         negative numbers for screenLeft and screenTop (Mac reports "0")
917
918         * DumpRenderTree/win/UIDelegate.cpp:
919         (UIDelegate::UIDelegate): Initialize the RECT.
920         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
921         (UIDelegate::webViewFrame): ditto.
922         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
923
924 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
925
926         Reviewed by Adam.
927
928         - Make Drosera show source, source URLs, and function stack on Windows,
929         and some minor fixes.
930
931         * Drosera/DebuggerDocument.cpp: Force source to always update display.
932         (DebuggerDocument::updateFileSource):
933         * Drosera/debugger.js: Force source to always update display.
934         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
935         menu controls.
936         (DebuggerClient::resume):
937         (DebuggerClient::pause):
938         (DebuggerClient::stepInto):
939         (DebuggerClient::stepOver):
940         (DebuggerClient::stepOut):
941         (DebuggerClient::showConsole):
942         (DebuggerClient::closeCurrentFile):
943         * Drosera/win/DebuggerClient.h: Ditto.
944         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
945         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
946         removed two bugs.  1) caller could be in a bad state when asked to
947         assign into it. 2) BSTRs were not created correctly.
948         (DebuggerDocument::getPlatformCurrentFunctionStack):
949         * Drosera/win/Drosera.cpp: Hook up the menu controls.
950         (droseraWndProc):
951         (handleCommand):
952         (Drosera::resume):
953         (Drosera::pause):
954         (Drosera::stepInto):
955         (Drosera::stepOver):
956         (Drosera::stepOut):
957         (Drosera::showConsole):
958         (Drosera::closeCurrentFile):
959         * Drosera/win/Drosera.h: Hook up the menu controls.
960         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
961         functions, added a null check, and fixed another bug where caller could
962         be in a bad state when asked to assign into it.
963         (ServerConnection::didLoadMainResourceForDataSource):
964         (ServerConnection::getCallerFrame):
965         * Drosera/win/ServerConnection.h: Safety first.
966
967 2007-11-13  Dan Bernstein  <mitz@apple.com>
968
969         Reviewed by Darin Adler.
970
971         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
972           DumpRenderTree --pixel-tests renders each test twice
973
974         * DumpRenderTree/mac/DumpRenderTree.mm:
975         (dumpRenderTree): Removed the --paint option because the painting code
976         is always exercised as a result of
977         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
978         calling -displayIfNeeded.
979         (dump): Changed to always grab the image from the window since the view
980         is always displayed.
981         (runTest):
982         (displayWebView):
983         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
984         because it always paints.
985
986 2007-11-12  Antti Koivisto  <antti@apple.com>
987
988         Reviewed by Adele.
989         
990         Add support for http media tests
991
992         * Scripts/run-webkit-tests:
993
994 2007-11-12  Sam Weinig  <sam@webkit.org>
995
996         Reviewed by Adam Roben.
997
998         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
999
1000         * DumpRenderTree/win/DumpRenderTree.cpp:
1001         (runTest):
1002         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1003         (LayoutTestController::setPrivateBrowsingEnabled):
1004
1005 2007-11-12  Adam Roben  <aroben@apple.com>
1006
1007         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1008         mac and win subdirectories.
1009
1010 2007-11-11  Adam Roben  <aroben@apple.com>
1011
1012         Fix <rdar://5133816> keepWebHistory is not implemented
1013
1014         Fixes fast/history/clicked-link-is-visited.html.
1015
1016         Reviewed by Darin.
1017
1018         * DumpRenderTree/win/DumpRenderTree.cpp:
1019         (runTest): Clear the optionalSharedHistory.
1020         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1021         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1022
1023 2007-11-10  Sam Weinig  <sam@webkit.org>
1024
1025         Reviewed by Tim Hatcher.
1026
1027         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1028         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1029         is turned on)
1030
1031         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1032
1033         Added test: http/tests/security/cross-frame-access-private-browsing.html
1034
1035         * DumpRenderTree/LayoutTestController.cpp:
1036         (setPrivateBrowsingEnabledCallback):
1037         (LayoutTestController::staticFunctions):
1038         * DumpRenderTree/LayoutTestController.h:
1039         * DumpRenderTree/mac/DumpRenderTree.mm:
1040         (runTest): Default to private browsing disabled.
1041         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1042         (LayoutTestController::setPrivateBrowsingEnabled):
1043         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1044         (LayoutTestController::setPrivateBrowsingEnabled):
1045
1046 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1047
1048         Reviewed by Adam.
1049
1050         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1051         WebCore's!
1052
1053         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1054         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1055         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1056         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1057         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1058         * Drosera/win/Drosera.cpp:
1059         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1060
1061 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1062
1063         Reviewed by Sam.
1064
1065         - Use the new IWebFrame [local] function signature and get the shared
1066         server correctly.
1067
1068         * Drosera/win/DebuggerClient.cpp:
1069         (DebuggerClient::didFinishLoadForFrame):
1070         * Drosera/win/ServerConnection.cpp:
1071         (ServerConnection::attemptToCreateServerConnection):
1072
1073 2007-11-07  Dan Bernstein  <mitz@apple.com>
1074
1075         Reviewed by Darin Adler.
1076
1077         - add an option to run-webkit-tests to ignore pixel test failures where
1078           all pixels differ by no more than a specified threshold
1079
1080         * DumpRenderTree/mac/ImageDiff.m:
1081         (main):
1082         (compareImages):
1083         (computePercentageDifferent):
1084         * Scripts/run-webkit-tests:
1085
1086 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1087
1088         Reviewed by Lars.
1089
1090         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1091
1092         * DumpRenderTree/qt/DumpRenderTree.cpp:
1093
1094 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1095
1096         Reviewed by Lars.
1097
1098         Reworked the QWebSettings API.
1099         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1100
1101         * DumpRenderTree/qt/DumpRenderTree.cpp:
1102
1103 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1104
1105         Reviewed by Lars.
1106
1107         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1108
1109         * DumpRenderTree/qt/jsobjects.cpp:
1110
1111 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1112
1113         Reviewed by Lars Knoll <lars@trolltech.com>.
1114
1115         Add a QWebPage::frameCreated() signal and fix DRT
1116         
1117         The removal of createFrame in QWebPage broke the re-implementation
1118         in DumpRenderTree. Instead emit a frameCreated() signal and
1119         connect to it in DumpRenderTree.
1120         
1121
1122         * DumpRenderTree/qt/DumpRenderTree.cpp:
1123         (WebCore::WebPage::WebPage):
1124         (WebCore::DumpRenderTree::dump):
1125         (WebCore::DumpRenderTree::connectFrame):
1126         * DumpRenderTree/qt/DumpRenderTree.h:
1127
1128 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1129
1130         Reviewed by Lars Knoll <lars@trolltech.com>.
1131
1132         Moved all the event handlers from QWebFrame into QWebPage.
1133         
1134         This cleans up the public API and allows us to remove the
1135         HackWebFrame hack in DumpRenderTree.
1136         
1137
1138         * DumpRenderTree/qt/jsobjects.cpp:
1139         (EventSender::mouseDown):
1140         (EventSender::mouseUp):
1141         (EventSender::mouseMoveTo):
1142
1143 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1144
1145         Reviewed by Mark.
1146
1147         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1148         to prevent the default implementation from popping up messageboxes.
1149
1150         * DumpRenderTree/qt/DumpRenderTree.cpp:
1151         (WebCore::WebPage::javaScriptConfirm):
1152         (WebCore::WebPage::javaScriptPrompt):
1153
1154 2007-11-06  Eric Seidel  <eric@webkit.org>
1155
1156         * Scripts/build-testkjs: build fix... too many $$
1157
1158 2007-11-06  Eric Seidel  <eric@webkit.org>
1159
1160         Reviewed by Mark Rowe.
1161
1162         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1163
1164 2007-11-05  Adam Roben  <aroben@apple.com>
1165
1166         Add support on Windows for WEBKIT_TESTFONTS
1167
1168         This environment variable lets you specify where the fonts to be used
1169         by DumpRenderTree reside. The Qt port is already using this, so I'm
1170         just following their lead.
1171
1172         Reviewed by Darin.
1173
1174         * DumpRenderTree/win/DumpRenderTree.cpp:
1175         (exePath): Refactored code out of initialize().
1176         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1177         DumpRenderTree.resources.
1178         (initialize): Use the new fontsPath function.
1179         (main): Use the new exePath function.
1180         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1181         variable to DRT, like Qt does.
1182
1183 2007-11-05  Mark Rowe  <mrowe@apple.com>
1184
1185         Rubber-stamped by Alp Toker.
1186
1187         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1188
1189         * GtkLauncher/main.cpp:
1190         (goToURLBarText):
1191         (main):
1192
1193 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1194
1195         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1196         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1197
1198         Reviewed by Timothy.
1199
1200         Restrict the range of nightly builds used by the bisect-builds script
1201         based on the version of Safari and the version of Mac OS X being used.
1202
1203         Mac OS X 10.4: Safari 2.0: r11976 or newer
1204         Mac OS X 10.4: Safari 3.0: r19992 or newer
1205
1206         Mac OS X 10.5: Safari 2.0: r19594 or newer
1207         Mac OS X 10.5: Safari 3.0: r25124 or newer
1208
1209         * Scripts/bisect-builds:
1210         (findMacOSXVersion): Added.
1211         (makeNightlyList): Added argument to provide version of Mac OS X.
1212         Restrict range of nightly builds based on Safari and Mac OS X versions.
1213
1214 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1215
1216         Reviewed by Maciej.
1217
1218         - This patch involves several changes, all of them were noticed that
1219         they were needed by the work being done in WebKit to get Drosera and
1220         WebKit working together on Windows.
1221         - The changes are:
1222         1) Added a debugger console for output messages.
1223         2) Drosera now listens for the WebKit server (before, the server would
1224         have to be running before Drosera was started.)
1225         3) Fixed a bug where the WebView started out as 0x0 pixels.
1226         4) Fixed a bug when there is no scope.
1227         5) Added the HTML, JS, and CSS to the project file to make them easy to
1228         find.
1229         6) Made the ServerConnection functions virtual.
1230
1231         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1232         for the WebKit server.
1233         (DebuggerClient::DebuggerClient):
1234         (DebuggerClient::~DebuggerClient):
1235         (DebuggerClient::didFinishLoadForFrame):
1236         (DebuggerClient::serverConnected):
1237         (DebuggerClient::attemptToCreateServerConnection):
1238         * Drosera/win/DebuggerClient.h: Ditto.
1239         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1240         scope.
1241         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1242         (DebuggerDocument::platformValueForScopeVariableNamed):
1243         * Drosera/win/Drosera.cpp:
1244         (_tWinMain): Added a console in debug for output messages.
1245         (Drosera::Drosera): Listen for server.
1246         (Drosera::initUI): The server now Initializes COM.
1247         (Drosera::serverConnected): Part of the listening for the server.
1248         (Drosera::attemptToCreateServerConnection): Ditto.
1249         * Drosera/win/Drosera.h: New interface for listening for the server.
1250         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1251         files to the VS project.
1252         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1253         connection.
1254         (ServerConnection::ServerConnection):
1255         (ServerConnection::attemptToCreateServerConnection):
1256         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1257         methods.
1258         (ServerConnection::serverConnected):
1259
1260 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1261
1262         Reviewed by Maciej.
1263
1264         http://bugs.webkit.org/show_bug.cgi?id=15832
1265         fast/dom/gc-10.html crashes when run alone
1266
1267         Check for !done before using objects that can be already deallocated.
1268
1269         * DumpRenderTree/mac/EditingDelegate.mm:
1270         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1271         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1272         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1273         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1274         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1275         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1276         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1277         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1278         (-[EditingDelegate webViewDidBeginEditing:]):
1279         (-[EditingDelegate webViewDidChange:]):
1280         (-[EditingDelegate webViewDidEndEditing:]):
1281         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1282         (-[EditingDelegate webViewDidChangeSelection:]):
1283         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1284         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1285         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1286         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1287         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1288         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1289         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1290         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1291         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1292         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
1293         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1294         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
1295         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1296         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
1297         (-[FrameLoadDelegate webView:willCloseFrame:]):
1298         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1299         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1300         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1301         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1302         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1303         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1304         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1305         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1306         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1307
1308 2007-11-04  Mark Rowe  <mrowe@apple.com>
1309
1310         Build fix.  Don't use Carbon.h as the prefix header as it triggers
1311         warnings that would otherwise be suppressed due to it being a system header.
1312
1313         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1314
1315 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
1316
1317         Rubber stamped by Adam.
1318         
1319         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
1320
1321         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1322
1323 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1324
1325         Sort files(...); sections of Xcode project files.
1326
1327         Rubber-stamped by Darin.
1328
1329         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1330         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1331         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1332         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1333
1334 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1335
1336         Script to sort "files(...);" sections in Xcode project.pbxproj files.
1337
1338         Reviewed by Darin.
1339
1340         * Scripts/sort-Xcode-project-file: Added.
1341
1342 2007-11-02  Darin Adler  <darin@apple.com>
1343
1344         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
1345
1346 2007-11-02  Darin Adler  <darin@apple.com>
1347
1348         Reviewed by Maciej.
1349
1350         * Scripts/run-sunspider: Pass the "--base" option through.
1351
1352         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
1353         the real script do that. Default configuration to Release to match run-sunspider
1354         so we don't end up building Debug just to compare results.
1355
1356 2007-11-01  Adam Roben  <aroben@apple.com>
1357
1358         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
1359
1360         Reviewed by Sam.
1361
1362         * Scripts/commit-log-editor: Show all the directories beneath the
1363         source root, instead of just the last one.
1364
1365 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
1366
1367         Reviewed by Adam Roben.
1368
1369         Print out an error message when the Windows build fails
1370         and provide guidance on how to find out what went wrong.
1371
1372         * Scripts/build-webkit:
1373         * Scripts/webkitdirs.pm:
1374
1375 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
1376
1377         Rubber-stamped by Adam Roben.
1378
1379         Rolled out r27326 - debug CRT seems to cause no problems after all.
1380
1381         * DumpRenderTree/win/DumpRenderTree.vcproj:
1382
1383 2007-10-31  Adam Roben  <aroben@apple.com>
1384
1385         Switch the Debug configuration to using the non-debug CRT
1386
1387         This matches WebKit.
1388
1389         Reviewed by Steve.
1390
1391         * DumpRenderTree/win/DumpRenderTree.vcproj:
1392
1393 2007-10-31  Antti Koivisto  <antti@apple.com>
1394
1395         Reviewed by bdash.
1396         
1397         Disable media tests when doing leak checking on Tiger.
1398         They crash in QuickTime (rdar://problem/5537157).
1399
1400         * Scripts/run-webkit-tests:
1401
1402 2007-10-29  Antti Koivisto  <antti@apple.com>
1403
1404         Reviewed by Maciej.
1405         
1406         Build media support by default on OSX only.
1407
1408         * Scripts/build-webkit:
1409
1410 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1411
1412         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
1413         get caught by the pre-commit hooks.
1414
1415 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1416
1417         Reviewed by Adam.
1418
1419         - This is a collection of relatively unrelated changes and cleanups
1420         to Drosera to prepare it for interacting with WebKit.  A lot of these
1421         changes are just correcting mistakes, for example removing included
1422         headers that are no longer needed.
1423
1424         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
1425         this will be needed by the DebuggerClient.
1426         (DebuggerDocument::server):
1427         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
1428         * Drosera/win/DebuggerClient.cpp: 
1429         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
1430         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
1431         (DebuggerClient::createWebViewWithRequest): Added comment about its
1432         purpose. 
1433         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
1434         declarations.
1435         (DebuggerClient::webViewLoaded): Moved.
1436         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
1437         file, since this was the only place it was used.
1438         (cfStringToBSTR):
1439         * Drosera/win/Drosera.h: Cleaned up the includes.
1440         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
1441         * Drosera/win/HelperFunctions.h: Removed.
1442
1443 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1444
1445         Reviewed by Adam.
1446
1447         - Small cleanup in the ServerConnection class.
1448
1449         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
1450         and added an include.
1451         (ServerConnection::currentFrame):
1452         (ServerConnection::getCallerFrame):
1453         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
1454         made a pointer into a COMPtr, and cleaned up the includes.
1455
1456 2007-10-29  Timothy Hatcher  <timothy@apple.com>
1457
1458         Reviewed by John Sullivan.
1459         
1460         - Place the Localizable.strings file in mac or win directories
1461           if that location exists.
1462         - Also look for UI_STRING in .c files.
1463
1464         * Scripts/extract-localizable-strings:
1465
1466 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1467
1468         Reviewed by Adam.
1469
1470         - Set the eol-style to native and made all the line endings the same
1471         so that I avoid messy diffs that show eol changes.
1472
1473         * Drosera/win/ServerConnection.cpp:
1474         (ServerConnection::didParseSource):
1475         (ServerConnection::didEnterCallFrame):
1476         (ServerConnection::willExecuteStatement):
1477         (ServerConnection::willLeaveCallFrame):
1478         (ServerConnection::exceptionWasRaised):
1479
1480 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1481
1482         Reviewed by Adam.
1483
1484         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
1485         functionality that could not have existed previously without the new
1486         interfaces.
1487         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
1488         from a BSTR to a JSValueRef.
1489         (DebuggerDocument::platformEvaluateScript): Implemented.
1490         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
1491         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1492         Implemented.
1493         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
1494         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
1495         * Drosera/win/ServerConnection.cpp: Added a helper function.
1496         (ServerConnection::getCallerFrame):
1497         * Drosera/win/ServerConnection.h: Added a helper function.
1498
1499 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1500
1501         updated reviewers for my previous changelog.
1502
1503 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1504         Reviewed by Maciej and Adam and Geoff.
1505
1506         - Minor mac-side improvements including moving a function to a more
1507         appropriate location, fixing a warning, and correctly checking
1508         exceptions.
1509
1510         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
1511         (DebuggerDocument::willExecuteStatement):
1512         (DebuggerDocument::didEnterCallFrame):
1513         (DebuggerDocument::willLeaveCallFrame):
1514         (DebuggerDocument::windowScriptObjectAvailable):
1515         (DebuggerDocument::callFunctionOnObject):
1516         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
1517         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
1518         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
1519         because it doesn't require the ServerConnection at all.
1520         (NSStringCreateWithJSStringRef): Made an argument const.
1521         (JSValueRefCreateWithNSString): Made an argument const.
1522         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
1523         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1524         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
1525         * Drosera/mac/ServerConnection.mm: Ditto.
1526         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1527
1528 2007-10-29  Sam Weinig  <sam@webkit.org>
1529
1530         Reviewed by Adam Roben.
1531
1532         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
1533
1534         * DumpRenderTree/LayoutTestController.cpp:
1535         (LayoutTestController::LayoutTestController):
1536         (getGlobalFlagCallback):
1537         (setGlobalFlagCallback):
1538         (LayoutTestController::getJSClass):
1539         (LayoutTestController::staticValues):
1540         * DumpRenderTree/LayoutTestController.h:
1541         (LayoutTestController::globalFlag):
1542         (LayoutTestController::setGlobalFlag):
1543
1544 2007-10-29  Darin Adler  <darin@apple.com>
1545
1546         Reviewed by Maciej.
1547
1548         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
1549         resolution instead of its default.
1550
1551 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
1552
1553         Fixed showStatus() to print status for successfully resolved conflicts when using git.
1554
1555         Reviewed by Mark Rowe.
1556
1557         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
1558         was successfully resolved, but this would not show any status because the change had
1559         already been cached in the index using "git add".  The solution is to add an optional
1560         second argument to showStatus() which adds the "--cached" switch to the command.
1561
1562         * Scripts/resolve-ChangeLogs:
1563         (showStatus):
1564
1565 2007-10-28  Eric Seidel  <eric@webkit.org>
1566
1567         Reviewed by Maciej and Geoff, in unison.
1568
1569         * Scripts/run-webkit-tests: remove broken --svg option
1570
1571 2007-10-28  Darin Adler  <darin@apple.com>
1572
1573         Reviewed by Adam.
1574
1575         * Scripts/run-sunspider: Default to "Release" configuration rather than
1576         defaulting to the last configuration used as other scripts do. This can
1577         still be overriden on the command line with "--debug" if there's some
1578         reason to do so. Also fix a typo.
1579
1580         * Scripts/sunspider-compare-results: Fix a typo.
1581
1582 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
1583
1584         Reviewed by Adam.
1585
1586         - Implemented the WebScriptDebugListener functions now that the
1587         WebScriptDebugServer exists
1588
1589         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
1590         functions.
1591         (ServerConnection::currentFrame):
1592         (ServerConnection::didLoadMainResourceForDataSource):
1593         (ServerConnection::didParseSource):
1594         (ServerConnection::failedToParseSource):
1595         (ServerConnection::didEnterCallFrame):
1596         (ServerConnection::willExecuteStatement):
1597         (ServerConnection::willLeaveCallFrame):
1598         (ServerConnection::exceptionWasRaised):
1599         * Drosera/win/ServerConnection.h: Removed unused arguments from the
1600         members arguments list.
1601
1602 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
1603
1604         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
1605         <http://bugs.webkit.org/show_bug.cgi?id=15600>
1606
1607         Reviewed by Darin.
1608
1609         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
1610         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
1611         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
1612         file.  Note that it may also be used as a stand-alone script.
1613
1614         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
1615         * Scripts/resolve-ChangeLogs: Added.
1616         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
1617
1618 2007-10-26  Mark Rowe  <mrowe@apple.com>
1619
1620         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
1621         to the Qt port on the assumption that it was an implementation of the cross-platform
1622         LayoutTestController class.  It is not, so it did not need to be changed.
1623
1624         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
1625
1626 2007-10-25  Mark Rowe  <mrowe@apple.com>
1627
1628         Reviewed by Maciej.
1629
1630         Fix builds with code coverage enabled.
1631
1632         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
1633
1634 2007-10-25  Darin Adler  <darin@apple.com>
1635
1636         Reviewed by Mark Rowe.
1637
1638         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
1639         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
1640
1641 2007-10-25  Stephanie  <slewis@apple.com>
1642
1643         build Fix
1644
1645         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1646
1647 2007-10-25  Stephanie  <slewis@apple.com>
1648
1649         Reviewed by Mark Rowe, Adam Roben.
1650
1651         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
1652
1653         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
1654
1655 2007-10-25  Alice Liu  <alice.liu@apple.com>
1656
1657         Reviewed by Adam.
1658
1659         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
1660
1661         Moving destructor into platform-specific files
1662         * DumpRenderTree/LayoutTestController.cpp:
1663         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1664         (LayoutTestController::~LayoutTestController):
1665         * DumpRenderTree/qt/jsobjects.cpp:
1666         (LayoutTestController::~LayoutTestController):
1667
1668         LayoutTestController wasn't being destroyed
1669         * DumpRenderTree/win/DumpRenderTree.cpp:
1670         (runTest):
1671
1672         Added declspec
1673         * DumpRenderTree/win/EditingDelegate.h:
1674
1675         Reset certain values on the webview (or related delegate) that might 
1676         have changed while running a test
1677         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1678         (LayoutTestController::~LayoutTestController):
1679
1680 2007-10-25  Adam Roben  <aroben@apple.com>
1681
1682         Make sunspider-compare-results work with relative paths
1683
1684         Reviewed by Sam.
1685
1686         * Scripts/sunspider-compare-results: Convert arguments to absolute
1687         paths before we chdir.
1688
1689 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
1690
1691         Reviewed by Sam.
1692
1693         - Implemented server calls now the WebScriptDebugServer exists.
1694         - Also removed no longer needed call to initialize CG.
1695
1696         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
1697         automatically now.
1698         (_tWinMain):
1699         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
1700         (ServerConnection::ServerConnection):
1701         (ServerConnection::~ServerConnection):
1702         (ServerConnection::pause):
1703         (ServerConnection::resume):
1704         (ServerConnection::stepInto):
1705         (ServerConnection::applicationTerminating):
1706         (ServerConnection::serverConnectionDidDie):
1707         * Drosera/win/ServerConnection.h: Now uses the COM class.
1708
1709 2007-10-24  George Staikos  <staikos@kde.org>
1710
1711         Unbreak Qt build.
1712
1713         * Scripts/build-webkit:
1714
1715 2007-10-24  Adam Roben  <aroben@apple.com>
1716
1717         Remove now-unnecessary call to InitializeCoreGraphics
1718
1719         WebKit takes care of this now.
1720
1721         Reviewed by Ada.
1722
1723         * DumpRenderTree/win/DumpRenderTree.cpp:
1724         (initialize):
1725
1726 2007-10-24  Adam Roben  <aroben@apple.com>
1727
1728         Use WebTextRenderer in DRT
1729
1730         Reviewed by Ada.
1731
1732         * DumpRenderTree/win/DumpRenderTree.cpp:
1733         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
1734
1735 2007-10-24  Sven Herzberg  <sven@imendio.com>
1736
1737         Reviewed by Mark Rowe.
1738
1739         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
1740         Bug 15614: [GTK] qmake based backends don't build on OS X
1741
1742         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
1743         GTK backend on a Mac
1744         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
1745         isDarwin() to make it reusable in other places (like the workaround-
1746         for-prebuilt-qmake in build-webkit)
1747
1748 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1749
1750         Refurbish update-webkit script.
1751
1752         Reviewed by Adam.
1753
1754         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
1755         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
1756         multi-argument version of system() for flexibility and security.  Check for existence
1757         of Internal directory using -d test instead of -x.
1758
1759 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1760
1761         Minor clean-up of prepare-ChangeLog script.
1762
1763         Reviewed by Adam.
1764
1765         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
1766         of a string.  Use multi-argument versions of open() and system() for flexibility and
1767         security.
1768
1769 2007-10-24  Alice Liu  <alice.liu@apple.com>
1770
1771         Reviewed by Oliver.
1772
1773         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
1774
1775         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
1776         replay the saved events when we're still processing the mousedown that starts the drag
1777         * DumpRenderTree/win/EventSender.cpp:
1778         (doMouseMove):
1779         * DumpRenderTree/win/UIDelegate.cpp:
1780         (UIDelegate::doDragDrop):
1781
1782 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
1783
1784         Reviewed by Sam, Steve and Darin.
1785
1786         - Stubbed out the WebScriptDebugListener functionality in the Server
1787         Connection class to prepare it for receiving those callbacks.
1788         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
1789         and the ServerConnection to not need to be initialized with a server
1790         name, since that is not the way we connect to the WebKit server. 
1791
1792         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
1793         no exception.  Now it only loggs when there is an exception
1794         (DebuggerDocument::willExecuteStatement):
1795         (DebuggerDocument::didEnterCallFrame):
1796         (DebuggerDocument::willLeaveCallFrame):
1797         (DebuggerDocument::windowScriptObjectAvailable):
1798         (DebuggerDocument::callFunctionOnObject):
1799         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
1800         to be instantiated with a server's name.
1801         (DebuggerClient::DebuggerClient):
1802         (DebuggerClient::didFinishLoadForFrame):
1803         * Drosera/win/DebuggerClient.h: Removed unsued variable.
1804         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
1805         a server name.
1806         (Drosera::init):
1807         (Drosera::initServer):
1808         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
1809         instantiated with a server's name.
1810         * Drosera/win/ServerConnection.cpp: 
1811         (ServerConnection::ServerConnection): No longer needs a server name
1812         (ServerConnection::~ServerConnection): Only release the global context
1813         if there is one.
1814         (ServerConnection::serverConnectionDidDie): Stub for
1815         IWebScriptDebugListener
1816         (ServerConnection::QueryInterface): ditto
1817         (ServerConnection::AddRef): ditto
1818         (ServerConnection::Release): ditto
1819         (ServerConnection::didLoadMainResourceForDataSource): ditto
1820         (ServerConnection::didParseSource): ditto
1821         (ServerConnection::failedToParseSource): ditto
1822         (ServerConnection::didEnterCallFrame): ditto
1823         (ServerConnection::willExecuteStatement): ditto
1824         (ServerConnection::willLeaveCallFrame): ditto
1825         (ServerConnection::exceptionWasRaised): ditto
1826         * Drosera/win/ServerConnection.h: Stubbed out the
1827         IWebScriptDebugListener functions, and this class no longer needs to be
1828         instantiated with a server name.
1829
1830 2007-10-24  Lars Knoll  <lars@trolltech.com>
1831
1832         Reviewed by Simon.
1833
1834         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
1835
1836         * DumpRenderTree/qt/jsobjects.h:
1837
1838 2007-10-24  Lars Knoll  <lars@trolltech.com>
1839
1840         Reviewed by Simon.
1841
1842         add another command.
1843
1844         * DumpRenderTree/qt/jsobjects.cpp:
1845         (TextInputController::doCommand):
1846
1847 2007-10-24  Lars Knoll  <lars@trolltech.com>
1848
1849         Reviewed by Simon.
1850
1851         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
1852
1853         * DumpRenderTree/qt/jsobjects.cpp:
1854         (EventSender::keyDown):
1855         * DumpRenderTree/qt/jsobjects.h:
1856
1857 2007-10-24  Lars Knoll  <lars@trolltech.com>
1858
1859         Reviewed by Simon.
1860
1861         implement eventSender.keyDown().
1862
1863         * DumpRenderTree/qt/jsobjects.cpp:
1864         (EventSender::keyDown):
1865
1866 2007-10-24  Lars Knoll  <lars@trolltech.com>
1867
1868         Reviewed by Simon.
1869
1870         some smaller fixes to the editing support in DRT. Makes another few tests pass.
1871
1872         * DumpRenderTree/qt/DumpRenderTree.cpp:
1873         (WebCore::DumpRenderTree::DumpRenderTree):
1874         (WebCore::DumpRenderTree::initJSObjects):
1875         * DumpRenderTree/qt/jsobjects.cpp:
1876         (TextInputController::doCommand):
1877
1878 2007-10-24  Lars Knoll  <lars@trolltech.com>
1879
1880         Reviewed by Simon.
1881
1882         first bit of implementation for the textinputcontroller.
1883
1884         * DumpRenderTree/qt/DumpRenderTree.cpp:
1885         (WebCore::DumpRenderTree::DumpRenderTree):
1886         * DumpRenderTree/qt/DumpRenderTree.h:
1887         * DumpRenderTree/qt/jsobjects.cpp:
1888         (TextInputController::TextInputController):
1889         (TextInputController::doCommand):
1890         * DumpRenderTree/qt/jsobjects.h:
1891
1892 2007-10-24  Lars Knoll  <lars@trolltech.com>
1893
1894         Reviewed by Simon.
1895
1896         make the man webpage believe it has focus, so the editing tests work correctly.
1897
1898         * DumpRenderTree/qt/DumpRenderTree.cpp:
1899         (WebCore::DumpRenderTree::DumpRenderTree):
1900
1901 2007-10-24  Lars Knoll  <lars@trolltech.com>
1902
1903         Reviewed by Simon.
1904
1905         implement layoutTestController.dumpEditingCallbacks() correctly.
1906
1907         * DumpRenderTree/qt/DumpRenderTree.cpp:
1908         (WebCore::DumpRenderTree::DumpRenderTree):
1909         * DumpRenderTree/qt/jsobjects.cpp:
1910         (LayoutTestController::reset):
1911         (LayoutTestController::dumpEditingCallbacks):
1912
1913 2007-10-24  Lars Knoll  <lars@trolltech.com>
1914
1915         Reviewed by Simon.
1916
1917         Implement support for testing editing.
1918
1919         * DumpRenderTree/qt/DumpRenderTree.cpp:
1920         (WebCore::DumpRenderTree::DumpRenderTree):
1921
1922 2007-10-23  Sam Weinig  <sam@webkit.org>
1923
1924         Check for null BSTR that can be passed to the UIDelegate methods
1925         from javascript null and undefined.  Fixes a failing test case on
1926         Windows (fast/dom/Window/alert-undefined.html)
1927
1928         Reviewed by Eric Seidel.
1929
1930         * DumpRenderTree/win/UIDelegate.cpp:
1931         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1932         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1933         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1934         (UIDelegate::webViewAddMessageToConsole):
1935
1936 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1937
1938         Reviewed by Darin.
1939         
1940         Don't print a massive pile of setenvs from tools that automatically build testkjs.
1941
1942         * Scripts/build-testkjs:
1943
1944 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1945
1946         Reviewed by Darin.
1947
1948         - add wrapper that finds the right copy of testkjs
1949         
1950         * Scripts/sunspider-compare-results: Added.
1951
1952 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
1953
1954         Reviewed by Sam.
1955
1956         - After talking with Steve I now see that the WebKit server must be
1957         running for DCOM to create the distributed objects, which makes sense
1958         and currently WebKit only allows one instance to be running at a time
1959         which avoids accidentally connecting to the wrong server
1960         - In light of this I have removed the code for the attach box and
1961         NotificationServer and known server names, since they are all extranious
1962         now.
1963
1964         * Drosera/win/Drosera.cpp: Removed notification classes and known server
1965         names.
1966         (_tWinMain): Uses init instead of initUI.
1967         (droseraWndProc): No longer creats an attach dialog box.
1968         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
1969         it's not manditory to call init before doing COM stuff.
1970         (Drosera::init): calls initUI and will call attach when the
1971         functionality exists. 
1972         (Drosera::initUI): Has changed very little.
1973         (Drosera::attach): Changed the signature to reflect that we no longer
1974         need the dictionary of known server names.
1975         * Drosera/win/Drosera.h: Removed notification classes and known server
1976         names.  Also renamed and moved some functions.
1977         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
1978         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
1979         headers to the resources folder. 
1980         * Drosera/win/resource.h: Removed the Attach box.
1981
1982 2007-10-22  Adam Roben  <aroben@apple.com>
1983
1984         Windows build fix
1985
1986         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
1987
1988 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
1989
1990         - Removed a leak that was fixed.
1991
1992         * Scripts/run-webkit-tests:
1993
1994 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1995
1996         Reviewed by Darin.
1997
1998         - Changed the Client so that the DebuggerDocument now own the
1999         ServerConnection.  This simplifies ownership and cleanup. 
2000
2001         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2002         ServerConnection.
2003         (DebuggerClient::initWithServerName):
2004         (DebuggerClient::didFinishLoadForFrame):
2005         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2006         ServerConnection.
2007         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2008         until after we have a server which we are attached to.
2009         (Drosera::initUI):
2010         (Drosera::attach):
2011         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2012         out previously.
2013
2014 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2015
2016         Reviewed by Nikolas.
2017
2018         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2019
2020         * Scripts/run-javascriptcore-tests:
2021
2022 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2023
2024         Reviewed by Nikolas.
2025
2026         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2027
2028         * Scripts/build-drosera:
2029         * Scripts/build-dumprendertree:
2030         * Scripts/build-testkjs:
2031         * Scripts/build-webkit:
2032         * Scripts/run-javascriptcore-tests:
2033         * Scripts/run-sunspider:
2034         * Scripts/run-webkit-tests:
2035         * Scripts/webkitdirs.pm:
2036
2037 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2038
2039         Reviewed by Mark Rowe.
2040         
2041         Fix for local database support after r26879
2042         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2043
2044         * Scripts/build-webkit:
2045
2046 2007-10-22  Holger Freyther  <zecke@selfish.org>
2047
2048         Reviewed by Simon Hausmann <hausmann@kde.org>.
2049
2050         - Do not build testkjs as an application bundle. This is
2051         needed for run-javascriptcore-tests on OSX.
2052         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2053         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2054         as we do not have -rpath on OSX.
2055
2056         * DumpRenderTree/qt/DumpRenderTree.pro:
2057         * Scripts/run-webkit-tests:
2058
2059 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2060
2061         Reviewed by aroben.
2062
2063         Fix support for Signed-off-by detection in prepare-ChangeLog
2064         --git-commit. The Signed-off-by tag does not appear in the header
2065         but usually at the end.
2066
2067         * Scripts/prepare-ChangeLog:
2068
2069 2007-10-21  Mark Rowe  <mrowe@apple.com>
2070
2071         Reviewed by Eric.
2072
2073         Fix run-javascriptcore-tests for Gtk.
2074
2075         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2076
2077 2007-10-20  Eric Seidel  <eric@webkit.org>
2078
2079         Reviewed by aroben.
2080
2081         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2082
2083 2007-10-20  Eric Seidel  <eric@webkit.org>
2084
2085         Reviewed by darin.
2086         
2087         Add improved argument handling to run-sunspider, including
2088         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2089         Also re-factor code into subroutines
2090
2091         * Scripts/build-dumprendertree: removed bogus comments
2092         * Scripts/build-testkjs: Added.
2093         * Scripts/run-javascriptcore-tests: use build-testkjs
2094         * Scripts/run-sunspider: improved argument handling, abstraction
2095         * Scripts/run-webkit-tests: improved abstraction
2096
2097 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2098
2099         Not reviewed, Windows build fix.
2100
2101         * DumpRenderTree/win/EventSender.cpp:
2102         (keyDownCallback):
2103
2104 2007-10-20  Darin Adler  <darin@apple.com>
2105
2106         Reviewed by Tim Hatcher.
2107
2108         - http://bugs.webkit.org/show_bug.cgi?id=15544
2109           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2110           not rely on Apple-specific key codes
2111
2112         * DumpRenderTree/mac/EventSendingController.mm:
2113         (-[EventSendingController keyDown:withModifiers:]):
2114         Added named key "rightArrow". Later we could have a whole table of these.
2115         Also tweaked modifiers code a little.
2116
2117         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2118
2119 2007-10-19  Darin Adler  <darin@apple.com>
2120
2121         Reviewed by Eric.
2122
2123         - http://bugs.webkit.org/show_bug.cgi?id=15566
2124           possible fix for leak seen in DumpRenderTree
2125
2126         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2127         Delete the item if it's not put on the queue, since the caller has
2128         no way of knowing that. Would be better to have the parameter type
2129         be auto_ptr to express the fact that we take ownership.
2130
2131         - unrelated change
2132
2133         * Drosera/mac/main.m: Add missing include.
2134
2135 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2136
2137         Reviewed by Adam.
2138
2139         - This change should be identical but for some reason was not working
2140         on my machine.
2141
2142         * Scripts/prepare-ChangeLog:
2143
2144 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2145
2146         Reviewed by Oliver and Tim.
2147
2148         - Made use of RetainPtr to avoid retain and release issues and moved the
2149         log function to DebuggerDocumentPlatform, which seems to be a more
2150         logical place for it to live.
2151         - Also moved knownServers from the ServerConnection to
2152         DebuggerApplication to match the Windows code and because it makes sense
2153         that a connection knows its own server but not all of them.
2154
2155         * Drosera/mac/DebuggerClient.h: Moved the log function to
2156           DebuggerDocumentPlatform.
2157         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2158           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2159           call for the server name up from the ServerConnection class.
2160         (-[DebuggerClient dealloc]):
2161         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2162           for the server name up from the ServerConnection.
2163         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2164         (DebuggerDocument::platformPause):
2165         (DebuggerDocument::platformResume):
2166         (DebuggerDocument::platformStepInto):
2167         (DebuggerDocument::platformEvaluateScript):
2168         (DebuggerDocument::getPlatformCurrentFunctionStack):
2169         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2170         (DebuggerDocument::platformValueForScopeVariableNamed):
2171         (DebuggerDocument::platformLog): Log directly from here. No need to call
2172           DebuggerClient.
2173         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2174           way I see it, a ServerConnection should only know about its connection
2175           and the group of all possible servers should be kept by the
2176           application.
2177         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2178           currentServerName, it makes sense that the connection should know that
2179           name.
2180         (-[ServerConnection currentServerName]):
2181
2182 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2183
2184         Reviewed by Adam.
2185
2186         - Integrated changes from mac drosera.  Recently I've encapsulated
2187         out the server connection object from the rest of Drosera because
2188         it is very platform dependent right now and RPC is not implemented on
2189         windows.  This functionality, of communicating with the WebKit server
2190         is the next area I will be focusing on in Windows.
2191
2192         - Other changes and cleanup were made to organize the code and add notes
2193         on which parts still need work.  Also some mac code is added and
2194         commented out, to act as pseudocode for the logic of those parts.
2195
2196         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2197           pointer.
2198         * Drosera/config.h: Added whitespace.
2199         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2200           these files got moved into Drosera.h/cpp
2201         * Drosera/win/DebuggerApplication.h: Removed.
2202         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
2203           happened here to better match the logic flow of the same code on the 
2204           mac side and to use the new ServerConnection class.
2205         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2206         (DebuggerClient::initWithServerName): Initializer that will set up the
2207           class to use a ServerConnection object.  This was necessary so I could
2208           create a DebuggerClient without having to initilaize it at
2209           construction.
2210         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2211           will be the UIDelegate and FrameLoadDelegate.
2212         (DebuggerClient::AddRef): For IUnknown.
2213         (DebuggerClient::Release): For IUnknown.
2214         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2215           this still needs to set the global context of the server, but
2216           IWebFrame does not have an accessor for the global context yet. 
2217         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2218           this is a pass through for the same function in the document.
2219         (DebuggerClient::didReceiveTitle): Unimplemented part of
2220           FrameLoadDelegate this would change the title of the window.
2221         (DebuggerClient::createWebViewWithRequest): Part of the
2222           FrameLoadDelegate.  This is about new windows via Window.open() and
2223           how their delegates are set.
2224         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2225           UIDelegate.  Just a debug function for printing messages.
2226         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2227           because the Client should be the UIDelegate and FrameLoadDelegate
2228           to match the delegates on mac.
2229         (DebuggerClient::webViewLoaded): Added accessor method.
2230         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2231           forgotten to add this file before.  This is where the platform
2232           dependent versions of the Documents functions live. Most of these are
2233           unimplemented because some piece of functionality does not exist on
2234           Windows yet.
2235         (DebuggerDocument::platformPause):
2236         (DebuggerDocument::platformResume):
2237         (DebuggerDocument::platformStepInto):
2238         (DebuggerDocument::platformEvaluateScript):
2239         (DebuggerDocument::getPlatformCurrentFunctionStack):
2240         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2241         (DebuggerDocument::platformValueForScopeVariableNamed):
2242         (DebuggerDocument::platformLog):
2243         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2244           responsibilities becaue they belong in the Client. Also I laid the
2245           groundwork for attaching Drosera to a WebKit process
2246         (attachWndProc): Now if a server is selected the Client becomes it's
2247           delegate.
2248         (Drosera::Drosera): Added the construction of the Client and dictionary
2249           of server names. 
2250         (Drosera::initUI): This is no longer the delegates, the Client is.
2251         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2252           state. 
2253         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2254           notification registration when it's possible to implement.
2255         (Drosera::serverLoaded): Ditto
2256         (Drosera::serverUnloaded): Ditto
2257         (Drosera::attach): Attach Drosera to the WebKit server.
2258         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2259         (Drosera::getInst): 
2260         (Drosera::setInst):
2261         (Drosera::knownServers):
2262         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2263           and added the ServerConnection.
2264         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2265         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2266           Most of the functions are completely unimlemented because they cannot
2267           connect with the WebKit server, because one does not exist on Windows
2268           yet.
2269         (ServerConnection::initWithServerName): 
2270         (ServerConnection::~ServerConnection):
2271         (ServerConnection::setGlobalContext):
2272         (ServerConnection::pause):
2273         (ServerConnection::resume):
2274         (ServerConnection::stepInto):
2275         (ServerConnection::switchToServerNamed):
2276         (ServerConnection::applicationTerminating):
2277         (ServerConnection::serverConnectionDidDie):
2278         (ServerConnection::currentFrame):
2279         * Drosera/win/ServerConnection.h: Added. Ditto.
2280         (ServerConnection::ServerConnection):
2281
2282 2007-10-19  Alice Liu  <alice.liu@apple.com>
2283
2284         Reviewed by Darin.
2285
2286         Fix for these broken layout tests on Windows:
2287         
2288         fast/forms/focus-selection-input.html
2289         fast/forms/focus-selection-textarea.html
2290         fast/forms/select-accesskey.html
2291         
2292         * DumpRenderTree/win/EventSender.cpp:
2293         (keyDownCallback):
2294         correct the VK code for alt key.
2295         
2296 2007-10-19  Eric Seidel  <eric@webkit.org>
2297
2298         Reviewed by Mark Rowe.
2299         
2300         Make the GtkLauncher code slightly more readable.
2301
2302         * GtkLauncher/main.cpp:
2303         (setupMainMenu): Added.
2304         (setupMainWindowUI): Added.
2305         (main):
2306
2307 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
2308
2309         Rubber stamped by Adam.
2310         
2311         - don't delay-load WebKit in DumpRenderTree.
2312
2313         * DumpRenderTree/win/DumpRenderTree.vcproj:
2314
2315 2007-10-18  Dan Bernstein  <mitz@apple.com>
2316
2317         Reviewed by Adam Roben.
2318
2319         - fix <rdar://problem/5313523>
2320         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2321
2322         * DumpRenderTree/mac/DumpRenderTree.mm:
2323         (dump): Changed to use _responseMIMEType.
2324
2325 2007-10-17  Adam Roben  <aroben@apple.com>
2326
2327         Make it possible to have Windows-specific tests and results
2328
2329         When searching for tests to run and the Skipped file, we will only
2330         look in platform/win and the cross-platform directory. When looking
2331         for expected results, we will look in platform/win, then
2332         platform/mac-leopard, then platform/mac, then finally the
2333         cross-platform directory.
2334
2335         Reviewed by Sam.
2336
2337         * Scripts/run-webkit-tests:
2338         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
2339         searching in the cross-platform directory.
2340         (sub buildPlatformHierarchy): Removed some unneeded calls to
2341         dirname/basename.
2342
2343 2007-10-17  Adam Roben  <aroben@apple.com>
2344
2345         Add back the call to register WebKit that we had before WebKitInitializer existed
2346
2347         This is needed to ensure that the right WebKit is used when
2348         instantiating COM objects.
2349
2350         Reviewed by Oliver.
2351
2352         * DumpRenderTree/win/debug_internal.vsprops: Define
2353         DEBUG_WEBKIT_HAS_SUFFIX.
2354         * DumpRenderTree/win/DumpRenderTree.cpp:
2355         (initialize):
2356
2357 2007-10-17  Adam Roben  <aroben@apple.com>
2358
2359         Import File::Basename in webkitdirs since we use it
2360
2361         * Scripts/webkitdirs.pm:
2362
2363 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
2364
2365         - Updated the tiger leaks list to make the internal bots green.
2366
2367         * Scripts/run-webkit-tests:
2368
2369 2007-10-17  Adam Roben  <aroben@apple.com>
2370
2371         Build fix for VC++ Express
2372
2373         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
2374         and ole32.lib.
2375
2376 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2377
2378         Reviewed by Sam.
2379
2380         - Minor mac improvements based on observations I made while implementing the
2381         Windows code.
2382
2383         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
2384         then hand it to the Client who will retain it, it should just be the client who
2385         creates and owns the server.
2386         (-[DebuggerApplication attach:]):
2387         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
2388         * Drosera/mac/DebuggerClient.mm: Creates the server.
2389         (-[DebuggerClient initWithServerName:]):
2390         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
2391         can instead forward declare what it needs.
2392
2393 2007-10-16  Darin Adler  <darin@apple.com>
2394
2395         Reviewed by Geoff Garen.
2396
2397         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
2398         want to turn failing tests into platform-specific test results. Also did a
2399         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
2400         would take the type of results into account only some of the time.
2401
2402 2007-10-16  Adam Roben  <aroben@apple.com>
2403
2404         Add a new nightly launcher script for Windows
2405
2406         This new script is for versions of Safari that don't delay-load
2407         WebKit. I had to make FindSafari be able to print out the nightly
2408         launcher script on stdout because Windows shell scripts can't capture
2409         the output from a command into an environment variable.
2410
2411         Reviewed by Steve.
2412
2413         * FindSafari/FindSafari.cpp:
2414         (_tmain): Added /printSafariLauncher option.
2415         * Scripts/run-webkit-nightly.cmd: Added.
2416
2417 2007-10-16  Adam Roben  <aroben@apple.com>
2418
2419         Replace WebKitInitializer with FindSafari
2420
2421         We now rely on setting the PATH environment variable to tell Windows
2422         where to find WebKit and its dependencies (similar to
2423         DYLD_FRAMEWORK_PATH on Mac).
2424
2425         This change also make DumpRenderTree no longer delay-load WebKit.
2426
2427         Reviewed by Sam.
2428
2429         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
2430         FindSafari.
2431         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
2432         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
2433         WebKitInitializer, don't delay-load WebKit.
2434         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
2435         * Scripts/run-webkit-tests: Ditto.
2436         * Scripts/webkitdirs.pm:
2437         (sub setPathForRunningWebKitApp): Added.
2438         * WebKitInitializer/WebKitInitializer.cpp: Removed.
2439         * WebKitInitializer/WebKitInitializer.h: Removed.
2440         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
2441         * WebKitInitializer/debug.vsprops: Removed.
2442         * WebKitInitializer/debug_internal.vsprops: Removed.
2443         * WebKitInitializer/release.vsprops: Removed.
2444
2445 2007-10-16  Adam Roben  <aroben@apple.com>
2446
2447         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
2448
2449         http://bugs.webkit.org/show_bug.cgi?id=15532
2450
2451         FindSafari simply prints the location of an installed Safari.exe on
2452         stdout.
2453
2454         Reviewed by Darin.
2455
2456         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
2457         (getStringValue):
2458         (getWebViewCLSID):
2459         (getInstalledWebKitDirectory):
2460         (_tmain):
2461         * FindSafari/FindSafari.vcproj: Added.
2462         * Scripts/webkitdirs.pm:
2463         (sub installedSafariPath): Added. Calls FindSafari on Windows.
2464
2465 2007-10-16  Adam Roben  <aroben@apple.com>
2466
2467         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
2468
2469         Reviewed by Kevin McCullough.
2470
2471         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
2472         when referring to WebKit.dll.
2473         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
2474         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
2475         * DumpRenderTree/win/release.vsprops: Ditto.
2476         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
2477         never have a _debug suffix on WebKit.dll.
2478         * WebKitInitializer/WebKitInitializer.cpp:
2479         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
2480         specified.
2481         * WebKitInitializer/debug_internal.vsprops: Added
2482         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
2483
2484 2007-10-16  Darin Adler  <darin@apple.com>
2485
2486         Reviewed by Adele.
2487
2488         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2489         Remove now-unneeded control/alt key hack; the tests have been updated.
2490
2491 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2492
2493         - Updated leaks list because our internal bot upgraded it's version of leopard and 
2494         one of the leaks was fixed between that revision and the bot's previous version of
2495         leopard.
2496
2497         * Scripts/run-webkit-tests:
2498
2499 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
2500
2501         Reviewed by Tim.
2502
2503         - I encapsulated out the server connecton functionality because it is a specific part
2504         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
2505         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
2506         Windows.  So the majority of this patch is moving preexisting functionality.
2507
2508         - Also I removed the prefix header and changed to use config.h because it is more
2509         standard on how we use config.h in windows and it didn't make much sense to keep
2510         the prefix header and the config.h
2511
2512         * Drosera/DebuggerDocument.cpp:
2513         (DebuggerDocument::DebuggerDocument):
2514         * Drosera/DebuggerDocument.h:
2515         * Drosera/config.h:
2516         * Drosera/mac/DebuggerApplication.mm:
2517         (-[DebuggerApplication attach:]):
2518         * Drosera/mac/DebuggerClient.h:
2519         * Drosera/mac/DebuggerClient.mm:
2520         (-[DebuggerClient initWithServerConnection:]):
2521         (-[DebuggerClient dealloc]):
2522         (-[DebuggerClient windowDidLoad]):
2523         (-[DebuggerClient windowWillClose:]):
2524         (-[DebuggerClient webView:didFinishLoadForFrame:]):
2525         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
2526         * Drosera/mac/DebuggerDocumentPlatform.mm:
2527         (DebuggerDocument::platformPause):
2528         (DebuggerDocument::platformResume):
2529         (DebuggerDocument::platformStepInto):
2530         (DebuggerDocument::platformEvaluateScript):
2531         (DebuggerDocument::getPlatformCurrentFunctionStack):
2532         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2533         (DebuggerDocument::platformValueForScopeVariableNamed):
2534         (DebuggerDocument::platformLog):
2535         * Drosera/mac/Drosera.pch: Removed.
2536         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2537         * Drosera/mac/ServerConnection.h: Added.
2538         * Drosera/mac/ServerConnection.mm: Added.
2539         (-[ServerConnection initWithServerName:]):
2540         (-[ServerConnection dealloc]):
2541         (-[ServerConnection setGlobalContext:]):
2542         (-[ServerConnection pause]):
2543         (-[ServerConnection resume]):
2544         (-[ServerConnection stepInto]):
2545         (-[ServerConnection switchToServerNamed:]):
2546         (-[ServerConnection applicationTerminating:]):
2547         (-[ServerConnection serverConnectionDidDie:]):
2548         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2549         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2550         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
2551         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
2552         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
2553         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
2554         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2555         (-[ServerConnection currentFrame]):
2556         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
2557         (-[ServerConnection knownServers]):
2558
2559 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
2560
2561         Reviewed by Eric.
2562
2563         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
2564           Script to automatically search nightly builds for regressions (bisect-builds)
2565
2566         * Scripts/bisect-builds: Added.
2567
2568 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
2569
2570         Reviewed by Darin.
2571
2572         - New JavaScript benchmark
2573         http://bugs.webkit.org/show_bug.cgi?id=15515
2574
2575         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
2576         current development or release build of JavaScriptCore.
2577
2578 2007-10-15  Mark Rowe  <mrowe@apple.com>
2579
2580         Reviewed by Sam.
2581
2582         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
2583
2584         * Scripts/webkitdirs.pm:
2585         - Change checkArgv to remove the options from @ARGV to prevent
2586         them from interfering with further option processing.
2587         - Fix logic error in determineIsQt that would prevent it from bailing out early.
2588         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
2589         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
2590         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
2591
2592 2007-10-15  Darin Adler  <darin@apple.com>
2593
2594         Reviewed by Sam.
2595
2596         - added logging of window.prompt and window.confirm
2597
2598         * DumpRenderTree/mac/UIDelegate.mm:
2599         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2600         Implement the recommended delegate rather than the deprecated one.
2601         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
2602         Added.
2603         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2604         Added.
2605
2606         * DumpRenderTree/win/UIDelegate.h:
2607         * DumpRenderTree/win/UIDelegate.cpp:
2608         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
2609         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
2610         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
2611         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
2612
2613 2007-10-15  Alice Liu  <alice.liu@apple.com>
2614
2615         Reviewed by Sam Weinig.
2616
2617         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
2618
2619         * DumpRenderTree/win/DumpRenderTree.cpp:
2620         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
2621         (main): allocate the global policy delegate for DRT's custom use
2622         * DumpRenderTree/win/DumpRenderTree.vcproj:
2623         Adding files to project
2624         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
2625         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2626         (LayoutTestController::setCustomPolicyDelegate):
2627         set the webview's policy delegate to DRT's custom one if the test requests it.
2628         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
2629         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
2630         (PolicyDelegate::PolicyDelegate):
2631         (PolicyDelegate::QueryInterface):
2632         (PolicyDelegate::AddRef):
2633         (PolicyDelegate::Release):
2634         (PolicyDelegate::decidePolicyForNavigationAction):
2635         * DumpRenderTree/win/PolicyDelegate.h: Added.
2636         (PolicyDelegate::decidePolicyForNewWindowAction):
2637         (PolicyDelegate::decidePolicyForMIMEType):
2638         (PolicyDelegate::unableToImplementPolicyWithError):
2639
2640 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
2641
2642         Reviewed by Mark.
2643
2644         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
2645         when querying for QMAKE_MKSPECS.
2646
2647 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
2648
2649         Reviewed by Adam Roben.
2650         
2651         Fix run-webkit-tests is too greedy calculating platform hierarchy
2652         http://bugs.webkit.org/show_bug.cgi?id=15465
2653         
2654         Fix run-webkit-tests being too greedy in trying to split the platform name up
2655         causing it to try and find tests in every directory above the first "-" in the
2656         path to the LayoutTests
2657
2658         * Scripts/run-webkit-tests:
2659
2660 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
2661
2662         Reviewed by Darin.
2663
2664         http://bugs.webkit.org/show_bug.cgi?id=15006
2665         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
2666         to reduce code duplication.
2667
2668         * Scripts/build-webkit:
2669         * Scripts/webkitdirs.pm:
2670         buildQMakeProject() renamed to buildQMakeQtProject().
2671         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
2672         unused $colorize has been removed.
2673
2674 === Start merge of feature-branch 2007-10-12 ===
2675
2676 2007-10-08  Eric Seidel  <eric@webkit.org>
2677
2678         Reviewed by Mark Rowe.
2679
2680         * Scripts/build-webkit: add --help, remove unused --color
2681
2682 2007-10-07  Eric Seidel  <eric@webkit.org>
2683
2684         Reviewed by darin.
2685
2686         * Drosera/mac/DebuggerDocumentPlatform.mm:
2687         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
2688
2689 2007-10-03  Rob Buis  <buis@kde.org>
2690
2691         Reviewed by Olliej.
2692
2693         Adapt to changed location of Ahem font.
2694
2695         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2696
2697 2007-10-02  Eric Seidel  <eric@webkit.org>
2698
2699         Reviewed by Adam Roben.
2700         
2701         Make pixel tests more useful!
2702         Finally fix the image diff 0.00% mystery problem
2703         Highlight any image differences in the image diff.
2704         Add a link from image diffs back to original test file.
2705
2706         * DumpRenderTree/mac/ImageDiff.m:
2707         (compareImages): highlight any differences
2708         (computePercentageDifferent): round to two decimal places
2709         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
2710
2711 2007-10-02  Eric Seidel  <eric@webkit.org>
2712
2713         Reviewed by Alexey Proskuryakov.
2714
2715         * Scripts/run-webkit-tests: print the % image difference on main results page
2716
2717 2007-10-02  Mark Rowe  <mrowe@apple.com>
2718
2719         Reviewed by Oliver.
2720
2721         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2722
2723         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2724         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2725
2726 2007-10-01  Mark Rowe  <mrowe@apple.com>
2727
2728         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2729
2730 2007-09-25  Eric Seidel  <eric@webkit.org>
2731
2732         Reviewed by Mark Rowe.
2733         
2734         DerivedSources.make was finding "ENABLE_SVG" in the string
2735         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
2736         quite correctly.
2737
2738         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
2739
2740 2007-09-25  Mark Rowe  <mrowe@apple.com>
2741
2742         Rubber-stamped by Eric.
2743
2744         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2745         This makes it possible to automate nightly builds for the feature-branch.
2746
2747 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
2748
2749         Rubber stamped by Mark.
2750
2751         Enable svg experimental features as default here in feature-branch.
2752
2753         * Scripts/build-webkit:
2754
2755 2007-06-29  Antti Koivisto  <antti@apple.com>
2756
2757         Reviewed by Weinig.
2758         
2759         Add VIDEO flag for timed media features
2760
2761         * Scripts/build-webkit
2762         
2763 === End merge of feature-branch 2007-10-12 ===
2764
2765 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2766
2767         Reviewed by Darin.
2768
2769         - Updated rational for the leaks list to be more clear.
2770
2771         * Scripts/run-webkit-tests:
2772
2773 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2774
2775         Rubber Stamp by Sam.
2776
2777         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
2778         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
2779
2780         * Scripts/run-webkit-tests:
2781
2782 2007-10-10  Simon Hausmann  <hausmann@kde.org>
2783
2784         Reviewed by Lars.
2785
2786         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
2787         includes are needed for INT_MAX, std::auto_ptr and the like.
2788
2789         * DumpRenderTree/qt/main.cpp:
2790
2791 2007-10-09  Lars Knoll  <lars@trolltech.com>
2792
2793         Reviewed by Simon.
2794
2795         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
2796
2797         * DumpRenderTree/qt/jsobjects.cpp:
2798         (LayoutTestController::encodeHostName):
2799         (LayoutTestController::decodeHostName):
2800         * DumpRenderTree/qt/jsobjects.h:
2801
2802 2007-10-09  Lars Knoll  <lars@trolltech.com>
2803
2804         Reviewed by Simon.
2805
2806         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
2807
2808         * DumpRenderTree/qt/DumpRenderTree.cpp:
2809         (WebCore::WebPage::createFrame):
2810         (WebCore::DumpRenderTree::DumpRenderTree):
2811         (WebCore::DumpRenderTree::titleChanged):
2812         * DumpRenderTree/qt/DumpRenderTree.h:
2813         * DumpRenderTree/qt/jsobjects.cpp:
2814         (LayoutTestController::reset):
2815         * DumpRenderTree/qt/jsobjects.h:
2816
2817 2007-10-09  Lars Knoll  <lars@trolltech.com>
2818
2819         Reviewed by Simon.
2820
2821         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
2822
2823         * DumpRenderTree/qt/DumpRenderTree.h:
2824         * DumpRenderTree/qt/jsobjects.cpp:
2825         (LayoutTestController::clearBackForwardList):
2826         * DumpRenderTree/qt/jsobjects.h:
2827
2828 2007-10-09  Lars Knoll  <lars@trolltech.com>
2829
2830         Reviewed by Simon.
2831
2832         make --git-reviewer work again.
2833
2834         * Scripts/prepare-ChangeLog:
2835
2836 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
2837
2838         Rubber stamped by Eric.
2839
2840         Connect to the "hovering-over-link" signal emitted by WebKitPage and
2841         show the current link inside the statusbar.
2842         This shows how to make use of this signal and allows to easily test
2843         http://bugs.webkit.org/show_bug.cgi?id=15299.
2844
2845         * GtkLauncher/main.cpp:
2846         (hoveringOverLink):
2847         (main):
2848
2849 2007-10-05  Lars Knoll  <lars@trolltech.com>
2850
2851         add proper error messages to the FrameLoaderClient.
2852         Implement ChromeClientQt::closeWindowSoon and
2853         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
2854         Some fixes in DRT to make it work correctly with multiple windows.
2855
2856         Reviewed by Maciej.
2857
2858         * DumpRenderTree/qt/DumpRenderTree.cpp:
2859         (WebCore::DumpRenderTree::DumpRenderTree):
2860         (WebCore::DumpRenderTree::createWindow):
2861         (WebCore::DumpRenderTree::windowCount):
2862         * DumpRenderTree/qt/DumpRenderTree.h:
2863         * DumpRenderTree/qt/jsobjects.cpp:
2864         (LayoutTestController::maybeDump):
2865         (LayoutTestController::windowCount):
2866         * DumpRenderTree/qt/jsobjects.h:
2867
2868 2007-10-05  Lars Knoll  <lars@trolltech.com>
2869
2870         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
2871         Add support for layoutTextController.setCanOpenWindows() to DRT
2872         fixing another 2 test cases in fast/dom/Window.
2873
2874         Reviewed by Maciej.
2875
2876         * DumpRenderTree/qt/DumpRenderTree.cpp:
2877         (WebCore::WebPage::WebPage):
2878         (WebCore::WebPage::createWindow):
2879         (WebCore::DumpRenderTree::resetJSObjects):
2880         (WebCore::DumpRenderTree::createWindow):
2881         * DumpRenderTree/qt/DumpRenderTree.h:
2882         * DumpRenderTree/qt/DumpRenderTree.pro:
2883         * DumpRenderTree/qt/jsobjects.cpp:
2884         (LayoutTestController::LayoutTestController):
2885         (LayoutTestController::reset):
2886         * DumpRenderTree/qt/jsobjects.h:
2887         * DumpRenderTree/qt/main.cpp:
2888         * DumpRenderTree/qt/testplugin.cpp: Added.
2889         * DumpRenderTree/qt/testplugin.h: Added.
2890
2891 2007-10-04  Sam Weinig  <sam@webkit.org>
2892
2893         Rubber stamped by Adam.
2894
2895         Remove empty directories.
2896
2897         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
2898         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
2899
2900 2007-10-03  Darin Adler  <darin@apple.com>
2901
2902         Reviewed by Adam.
2903
2904         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
2905         we find the internal libraries in the libraries directory. This
2906         is helpful for Safari team engineers at Apple.
2907
2908 2007-10-03  Adam Roben  <aroben@apple.com>
2909
2910         Update the location of AHEM___.TTF after r25968
2911
2912         Reviewed by Sam.
2913
2914         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2915
2916 2007-10-03  Alp Toker  <alp@atoker.com>
2917
2918         Reviewed by Adam.
2919
2920         http://bugs.webkit.org/show_bug.cgi?id=14726
2921         [gtk] API design. Mapping the WebView delegates to signals.
2922
2923         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
2924
2925         * GtkLauncher/main.cpp:
2926         (goToURLBarText):
2927         (titleChanged):
2928         (progressChanged):
2929         (menuMainBackCallback):
2930         (menuMainForwardCallback):
2931         (main):
2932
2933 2007-10-03  Lars Knoll  <lars@trolltech.com>
2934
2935         Reviewed by Rob.
2936
2937         This fixes --strict mode in run-webkit-tests again after
2938         the platform dependent test results have been moved.
2939
2940         * Scripts/run-webkit-tests:
2941
2942 2007-10-03  Lars Knoll  <lars@trolltech.com>
2943
2944         Reviewed by bdash.
2945
2946         remove the hack in run-webkit-tests that forced text only test
2947         to be taken from the platform independent dir. It was only left
2948         there from early days.
2949         
2950         Remove platform dependent results for tests that are text only nowadays,
2951         and add one platform dependent result for a text only test that requires it.
2952
2953         * Scripts/run-webkit-tests:
2954
2955 2007-10-03  Lars Knoll  <lars@trolltech.com>
2956
2957         Reviewed by olliej.
2958
2959         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
2960
2961         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
2962         (WebCore::WebFrame::WebFrame):
2963         (WebCore::WebPage::WebPage):
2964         (WebCore::WebPage::createFrame):
2965         (WebCore::WebPage::javaScriptAlert):
2966         (WebCore::WebPage::javaScriptConsoleMessage):
2967         (WebCore::DumpRenderTree::DumpRenderTree):
2968         (WebCore::DumpRenderTree::~DumpRenderTree):
2969         (WebCore::DumpRenderTree::open):
2970         (WebCore::DumpRenderTree::readStdin):
2971         (WebCore::DumpRenderTree::resetJSObjects):
2972         (WebCore::DumpRenderTree::initJSObjects):
2973         (WebCore::DumpRenderTree::dumpFramesAsText):
2974         (WebCore::DumpRenderTree::dump):
2975         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
2976         (WebCore::DumpRenderTree::layoutTestController):
2977         (WebCore::DumpRenderTree::eventSender):
2978         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
2979         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
2980         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
2981         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
2982         (HackWebFrame::mousePressEvent):
2983         (HackWebFrame::mouseReleaseEvent):
2984         (HackWebFrame::mouseMoveEvent):
2985         (HackWebFrame::HackWebFrame):
2986         (HackWebFrame::~HackWebFrame):
2987         (LayoutTestController::LayoutTestController):
2988         (LayoutTestController::reset):
2989         (LayoutTestController::maybeDump):
2990         (LayoutTestController::waitUntilDone):
2991         (LayoutTestController::notifyDone):
2992         (LayoutTestController::dumpEditingCallbacks):
2993         (LayoutTestController::queueReload):
2994         (LayoutTestController::provisionalLoad):
2995         (LayoutTestController::timerEvent):
2996         (EventSender::EventSender):
2997         (EventSender::mouseDown):
2998         (EventSender::mouseUp):
2999         (EventSender::mouseMoveTo):
3000         (EventSender::leapForward):
3001         (EventSender::keyDown):
3002         (EventSender::frameUnderMouse):
3003         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
3004         (LayoutTestController::isLoading):
3005         (LayoutTestController::setLoading):
3006         (LayoutTestController::shouldDumpAsText):
3007         (LayoutTestController::shouldDumpChildrenAsText):
3008         (LayoutTestController::shouldWaitUntilDone):
3009         (LayoutTestController::dumpAsText):
3010         (LayoutTestController::dumpChildFramesAsText):
3011         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
3012         (messageHandler):
3013         (crashHandler):
3014         (main):
3015         * Scripts/run-webkit-tests:
3016
3017 2007-10-03  Mark Rowe  <mrowe@apple.com>
3018
3019         Reviewed by Alp Toker.
3020
3021         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
3022         should take precedence over QTDIR when determining which port we are working with.
3023
3024         * Scripts/webkitdirs.pm: 
3025
3026 2007-10-02  Adam Roben  <aroben@apple.com>
3027
3028         Add keychain to the list of default packages to install
3029
3030         Rubberstamped by Sam.
3031
3032         * CygwinDownloader/cygwin-downloader.py:
3033         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3034
3035 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
3036
3037         Reviewed by Adam.
3038
3039         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
3040         Also makes WebCore regression test case logic work when using git.
3041
3042         * Scripts/prepare-ChangeLog:
3043         (reviewerAndDescriptionForGitCommit): Added.
3044
3045 2007-10-02  Lars Knoll  <lars@trolltech.com>
3046
3047         Reviewed by bdash.
3048
3049         Add API to retrieve the frame name from QWebFrame.
3050         Implement support for DRT::dumpChildrenAsText.
3051
3052         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3053         (WebCore::DumpRenderTree::dumpFramesAsText):
3054         (WebCore::DumpRenderTree::dump):
3055         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3056         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3057         (LayoutTestController::LayoutTestController):
3058         (LayoutTestController::reset):
3059         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3060
3061 2007-10-02  Lars Knoll  <lars@trolltech.com>
3062
3063         Reviewed by bdash.
3064
3065         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
3066
3067         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3068         (WebCore::DumpRenderTree::readStdin):
3069
3070 2007-10-02  Mark Rowe  <mrowe@apple.com>
3071
3072         Reviewed by Oliver.
3073
3074         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3075
3076         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3077         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3078
3079 2007-10-02  Mark Rowe  <mrowe@apple.com>
3080
3081         Rubber-stamped by Maciej.
3082
3083         Configuration changes from build.webkit.org.  The major change is refactoring to work
3084         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
3085         last few weeks.
3086
3087         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3088         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
3089         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
3090         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
3091         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
3092         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
3093         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
3094         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
3095
3096 2007-10-02  Lars Knoll  <lars@trolltech.com>
3097
3098         Reviewed by Maciej.
3099
3100         Add support for eventSender.mouseMove to DRT.
3101         Fixes fast/css/hover-affects-child.html
3102
3103         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3104         (EventSender::mouseMoveTo):
3105
3106 2007-10-01  Mark Rowe  <mrowe@apple.com>
3107
3108         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3109
3110 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
3111
3112         Reviewed by Hyatt.
3113
3114         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
3115
3116         * Scripts/svn-apply:
3117         (gitdiff2svndiff): Ignore lines beginning with "new file".
3118         * Scripts/svn-unapply:
3119         (gitdiff2svndiff): Ditto.
3120
3121 2007-09-30  George Staikos  <staikos@kde.org>
3122
3123         Qt build fix (Mac OS X specific)
3124
3125         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
3126
3127 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
3128
3129         Reviewed by Mark.
3130
3131         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
3132         Remove Bakefiles from svn.
3133
3134         * GtkLauncher/Bakefiles.bkgen: Removed.
3135         * GtkLauncher/ENV: Removed.
3136         * GtkLauncher/gdklauncher.bkl: Removed.
3137         * GtkLauncher/mk: Removed.
3138         * Scripts/regenerate-makefiles: Removed.
3139
3140 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
3141
3142         Reviewed by John.
3143
3144         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
3145
3146         * Scripts/run-webkit-tests:
3147
3148 2007-09-26  Adam Roben  <aroben@apple.com>
3149
3150         Make not finding an installed WebKit non-fatal
3151
3152         What really matters is that we are able to load WebKit and its
3153         dependencies, not whether we think we've found an installed WebKit.
3154
3155         Reviewed by Sam.
3156
3157         * WebKitInitializer/WebKitInitializer.cpp:
3158         (getWebViewCLSID): Use new LOG_WARNING macro.
3159         (getInstalledWebKitDirectory): Ditto.
3160         (initializeWebKit): Don't die if we didn't find an installed WebKit,
3161         and use new macros.
3162         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
3163
3164 2007-09-26  Adam Roben  <aroben@apple.com>
3165
3166         Committed this file before saving it
3167
3168         * WebKitInitializer/debug_internal.vsprops:
3169
3170 2007-09-26  Adam Roben  <aroben@apple.com>
3171
3172         Load WebKit and its dependencies manually so they come from DllDirectory
3173
3174         I had to change WebKitInitializer to use malloc/free instead of
3175         new/delete to avoid pulling in WebKit (and its dependencies) early
3176         through use of fastMalloc.
3177
3178         Reviewed by Oliver.
3179
3180         * WebKitInitializer/WebKitInitializer.cpp:
3181         (getStringValue): Changed to use malloc/free.
3182         (getInstalledWebKitDirectory): Ditto.
3183         (initializeWebKit): Call SetDllDirectory first, then load all of
3184         WebKit's dependencies manually, finally followed by WebKit itself.
3185         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
3186         configuration to match our other projects.
3187         * WebKitInitializer/debug_internal.vsprops: Added.
3188
3189 2007-09-25  Adam Roben  <aroben@apple.com>
3190
3191         Actually define DEBUG/NDEBUG so that we load WebKit correctly
3192
3193         Rubberstamped by Sam.
3194
3195         * WebKitInitializer/WebKitInitializer.vcproj:
3196
3197 2007-09-25  Adam Roben  <aroben@apple.com>
3198
3199         Make DumpRenderTree delay-load its dependencies
3200
3201         This lets WebKitInitializer re-route the dependencies to be loaded out
3202         of the Safari installation directory.
3203
3204         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
3205         same thing), since we can't import the kCFAllocatorDefault symbol when
3206         delay-loading CoreFoundation.dll.
3207
3208         Rubberstamped by Sam.
3209
3210         * DumpRenderTree/win/DumpRenderTree.cpp:
3211         (runTest):
3212         (javaScriptThreads):
3213         * DumpRenderTree/win/DumpRenderTree.vcproj:
3214         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3215         (LayoutTestController::setWaitToDump):
3216
3217 2007-09-25  Adam Roben  <aroben@apple.com>
3218
3219         Pull ole32.lib into WebKitInitializer
3220
3221         Rubberstamped by Sam.
3222
3223         * WebKitInitializer/WebKitInitializer.vcproj:
3224
3225 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3226
3227         Reviewed by Adam.
3228
3229         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
3230           LGPL'ed files contain incorrect FSF address
3231
3232         * Drosera/config.h:
3233
3234 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3235
3236         Reviewed by Adam.
3237
3238         Make svn-apply and svn-unapply work with git-diff formatted patches.
3239
3240         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
3241         (gitdiff2svndiff): Added.
3242         * Scripts/svn-unapply: Ditto.
3243         (gitdiff2svndiff): Added.
3244
3245 2007-09-25  Adam Roben  <aroben@apple.com>
3246
3247         Pull advapi32.lib into WebKitInitializer
3248
3249         This is needed to get the registry functions we use.
3250
3251         Rubberstamped by Sam.
3252
3253         * WebKitInitializer/WebKitInitializer.vcproj:
3254
3255 2007-09-25  Adam Roben  <aroben@apple.com>
3256
3257         Add python and rsync to cygwin-downloader
3258
3259         Our build slaves need this, and it can't hurt for everyone else to
3260         have it, too.
3261
3262         Reviewed by Sam.
3263
3264         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
3265         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3266
3267 2007-09-25  Adam Roben  <aroben@apple.com>
3268
3269         Add WebKitInitializer and use it in DumpRenderTree
3270
3271         WebKitInitializer is a static library that has one function,
3272         initializeWebKit(). This registers WebKit and sets up the DLL search
3273         path so that WebKit's dependencies that are installed with Safari can
3274         be found.
3275
3276         Reviewed by Sam.
3277
3278         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
3279         DumpRenderTree depend on it.
3280         * DumpRenderTree/win/DumpRenderTree.cpp:
3281         (initialize): Call initializeWebKit.
3282         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
3283         WebKitInitializer.lib.
3284         * WebKitInitializer/WebKitInitializer.cpp: Added.
3285         (getStringValue):
3286         (getWebViewCLSID):
3287         (getInstalledWebKitDirectory):
3288         (initializeWebKit):
3289         * WebKitInitializer/WebKitInitializer.h: Added.
3290         * WebKitInitializer/WebKitInitializer.vcproj: Added.
3291         * WebKitInitializer/debug.vsprops: Added.
3292         * WebKitInitializer/release.vsprops: Added.
3293
3294 2007-09-25  Adam Roben  <aroben@apple.com>
3295
3296         Make run-webkit-tests respect set-webkit-configuration
3297
3298         Reviewed by Sam.
3299
3300         * Scripts/run-webkit-tests: Initialize $configuration to whatever
3301         set-webkit-configuration was last set to.
3302
3303 2007-09-25  Mark Rowe  <mrowe@apple.com>
3304
3305         Rubber-stamped by Eric.
3306
3307         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3308         This makes it possible to automate nightly builds for the feature-branch.
3309
3310 2007-09-25  Adam Roben  <aroben@apple.com>
3311
3312         A couple of fixes/enhancements to update-webkit-*-libs
3313
3314         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
3315         to tell update-webkit-support-libraries where it should find the
3316         WebKitSupportLibrary.zip file you downloaded.
3317
3318         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
3319         Windows-style path.
3320
3321         Reviewed by Sam.
3322
3323         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
3324         to $auxiliaryLibsURL and removed an irrelevant comment.
3325         * Scripts/update-webkit-support-libs:
3326
3327 2007-09-25  Adam Treat  <treat@kde.org>
3328
3329         Reviewed by Simon and Lars.
3330
3331         Refactors and cleans up Qt DRT member variable names, member variable
3332         initialization, style fixes and general code cleanup.
3333
3334         Adds queueReload slot to LayoutTestController that some tests require.
3335
3336         Subclasses QWebFrame to make sure that all frames have an associated
3337         LayoutTestController JS window object.
3338
3339         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
3340         aren't dumped twice.
3341
3342         EOF fixes.
3343
3344         Together, this patch fixes some 20+ layout tests in QtWebKit.
3345
3346         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3347         (WebCore::WebFrame::WebFrame):
3348         (WebCore::WebPage::WebPage):
3349         (WebCore::WebPage::createFrame):
3350         (WebCore::DumpRenderTree::DumpRenderTree):
3351         (WebCore::DumpRenderTree::open):
3352         (WebCore::DumpRenderTree::readStdin):
3353         (WebCore::DumpRenderTree::initJSObjects):
3354         (WebCore::DumpRenderTree::dump):
3355         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3356         (WebCore::DumpRenderTree::layoutTestController):
3357         (WebCore::DumpRenderTree::eventSender):
3358         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3359         (LayoutTestController::LayoutTestController):
3360         (LayoutTestController::reset):
3361         (LayoutTestController::maybeDump):
3362         (LayoutTestController::waitUntilDone):
3363         (LayoutTestController::notifyDone):
3364         (LayoutTestController::queueReload):
3365         (LayoutTestController::provisionalLoad):
3366         (EventSender::EventSender):
3367         (EventSender::mouseDown):
3368         (EventSender::mouseUp):
3369         (EventSender::mouseMoveTo):
3370         (EventSender::frameUnderMouse):
3371         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3372         (LayoutTestController::isLoading):
3373         (LayoutTestController::setLoading):
3374         (LayoutTestController::dumpAsText):
3375         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
3376         (main):
3377
3378 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3379
3380
3381         - Reverted an accidentally checked in file.
3382
3383         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
3384
3385 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3386         Reviewed by Sam.
3387
3388         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
3389
3390         * DumpRenderTree/win/DumpRenderTree.vcproj:
3391         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3392
3393 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3394
3395         Rubber stamped by Adam.
3396
3397         * GdkLauncher: Removed.
3398         * GdkLauncher/Bakefiles.bkgen: Removed.
3399         * GdkLauncher/ENV: Removed.
3400         * GdkLauncher/GdkLauncher.pro: Removed.
3401         * GdkLauncher/gdklauncher.bkl: Removed.
3402         * GdkLauncher/main.cpp: Removed.
3403         * GdkLauncher/mk: Removed.
3404         * GdkLauncher/simple.svg: Removed.
3405         * GdkLauncher/text.html: Removed.
3406         * GtkLauncher: Added.
3407         * GtkLauncher/GdkLauncher.pro: Removed.
3408         * GtkLauncher/GtkLauncher.pro: Added.
3409         * GtkLauncher/main.cpp:
3410         (updateWindowTitle):
3411         (main):
3412         * Scripts/build-webkit:
3413         * Scripts/regenerate-makefiles:
3414         * Scripts/run-javascriptcore-tests:
3415         * Scripts/run-launcher:
3416         * Scripts/run-webkit-tests:
3417         * Scripts/webkitdirs.pm:
3418
3419 2007-09-21  Timothy Hatcher  <timothy@apple.com>
3420
3421         Reviewed by Darin.
3422
3423         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
3424
3425         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
3426         This is tested by plugins/root-object-premature-delete-crash.html.
3427
3428         * DumpRenderTree/mac/ObjCController.m:
3429         (-[ObjCController accessStoredWebScriptObject]):
3430
3431 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
3432
3433         Reviewed by Oliver.
3434
3435         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
3436
3437         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
3438         (FrameLoadDelegate::FrameLoadDelegate):
3439
3440 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
3441
3442         Reviewed by Adam.
3443
3444         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
3445         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
3446
3447         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
3448         Now isQt() and isGdk() use global variables that are only set once.
3449
3450         An array of all the parameters is now given to build-dumprender which includes
3451         the platform on linux.
3452
3453         * Scripts/build-dumprendertree:
3454         * Scripts/run-webkit-tests:
3455         * Scripts/webkitdirs.pm:
3456
3457 2007-09-19  Adam Roben  <aroben@apple.com>
3458
3459         Rubberstamped by Hyatt.
3460
3461         * Spinneret: Removed.
3462
3463 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
3464
3465         Reviewed by David Kilzer.
3466
3467         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
3468
3469 2007-09-18  Sam Weinig  <sam@webkit.org>
3470
3471         Add JSRetainPtr.h #include to fix some builds.
3472
3473         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3474
3475 2007-09-18  Mike Hommey  <glandium@debian.org>
3476
3477         Reviewed by Adam.
3478
3479         * Scripts/prepare-ChangeLog:
3480         - Properly parse GECOS field.
3481         - Use git configuration for user name and email when appropriate.
3482
3483 2007-09-17  Sam Weinig  <sam@webkit.org>
3484
3485         Build fix.
3486
3487         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3488
3489 2007-09-17  Sam Weinig  <sam@webkit.org>
3490
3491         Reviewed by Adam Roben.
3492
3493         Share more code between mac and windows DRT.
3494             - GCController is now shared.
3495             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
3496
3497         * DumpRenderTree/GCController.cpp:
3498         * DumpRenderTree/win/DumpRenderTree.cpp:
3499         * DumpRenderTree/win/DumpRenderTree.vcproj:
3500         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
3501         (FrameLoadDelegate::FrameLoadDelegate):
3502         (FrameLoadDelegate::~FrameLoadDelegate):
3503         (FrameLoadDelegate::windowScriptObjectAvailable):
3504         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
3505         * DumpRenderTree/win/GCController.cpp: Removed.
3506         * DumpRenderTree/win/GCController.h: Removed.
3507         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
3508         (GCController::collect):
3509         (GCController::collectOnAlternateThread):
3510         (GCController::getJSObjectCount):
3511         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
3512         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
3513
3514 2007-09-17  Sam Weinig  <sam@webkit.org>
3515
3516         Reviewed by Adam Roben.
3517
3518         Begin sharing code between mac and windows DRT.
3519             - both now share LayoutTestController.h/cpp and implement platform dependant 
3520               operations in LayoutTestControllerMac/Win.
3521             - DumpRenderTree.h is now shared.
3522             - WorkQueue and WorkQueueItem are also shared.
3523
3524         * DumpRenderTree/DumpRenderTree.h:
3525         * DumpRenderTree/LayoutTestController.cpp:
3526         * DumpRenderTree/win/DumpRenderTree.cpp:
3527         (displayWebView):
3528         (dumpFrameScrollPosition):
3529         (dumpFramesAsText):
3530         (dump):
3531         (runTest):
3532         * DumpRenderTree/win/DumpRenderTree.h: Removed.
3533         * DumpRenderTree/win/DumpRenderTree.vcproj:
3534         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
3535         * DumpRenderTree/win/EditingDelegate.cpp:
3536         (EditingDelegate::shouldBeginEditingInDOMRange):
3537         (EditingDelegate::shouldEndEditingInDOMRange):
3538         (EditingDelegate::shouldInsertNode):
3539         (EditingDelegate::shouldInsertText):
3540         (EditingDelegate::shouldDeleteDOMRange):
3541         (EditingDelegate::shouldChangeSelectedDOMRange):
3542         (EditingDelegate::shouldApplyStyle):
3543         (EditingDelegate::shouldChangeTypingStyle):
3544         (EditingDelegate::doPlatformCommand):
3545         (EditingDelegate::webViewDidBeginEditing):
3546         (EditingDelegate::webViewDidChange):
3547         (EditingDelegate::webViewDidEndEditing):
3548         (EditingDelegate::webViewDidChangeTypingStyle):
3549         (EditingDelegate::webViewDidChangeSelection):
3550         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
3551         * DumpRenderTree/win/LayoutTestController.h: Removed.
3552         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
3553         (LayoutTestController::addDisallowedURL):
3554         (LayoutTestController::clearBackForwardList):
3555         (LayoutTestController::copyDecodedHostName):
3556         (LayoutTestController::copyEncodedHostName):
3557         (LayoutTestController::display):
3558         (LayoutTestController::keepWebHistory):
3559         (LayoutTestController::notifyDone):
3560         (LayoutTestController::queueBackNavigation):
3561         (LayoutTestController::queueForwardNavigation):
3562         (jsStringRefToWString):
3563         (LayoutTestController::queueLoad):
3564         (LayoutTestController::queueReload):
3565         (LayoutTestController::queueScript):
3566         (LayoutTestController::setAcceptsEditing):
3567         (LayoutTestController::setCustomPolicyDelegate):
3568         (LayoutTestController::setMainFrameIsFirstResponder):
3569         (LayoutTestController::setTabKeyCyclesThroughElements):
3570         (LayoutTestController::setUseDashboardCompatibilityMode):
3571         (LayoutTestController::setUserStyleSheetEnabled):
3572         (LayoutTestController::setUserStyleSheetLocation):
3573         (LayoutTestController::setWindowIsKey):
3574         (waitUntilDoneWatchdogFired):
3575         (LayoutTestController::setWaitToDump):
3576         (LayoutTestController::windowCount):
3577         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
3578         (FrameLoadDelegate::didReceiveTitle):
3579         (FrameLoadDelegate::processWork):
3580         (FrameLoadDelegate::locationChangeDone):
3581         (FrameLoadDelegate::windowScriptObjectAvailable):
3582         * DumpRenderTree/win/WorkQueue.cpp: Removed.
3583         * DumpRenderTree/win/WorkQueue.h: Removed.
3584         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
3585         * DumpRenderTree/win/WorkQueueItem.h: Removed.
3586         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
3587         (jsStringRefToWString):
3588         (LoadItem::invoke):
3589         (ScriptItem::invoke):
3590
3591 2007-09-17  Sam Weinig  <sam@webkit.org>
3592
3593         Reviewed by Adam Roben.
3594
3595         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
3596
3597         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
3598         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
3599         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
3600         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
3601         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.