Rubber stamped by Anders.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-12-02  Sam Weinig  <sam@webkit.org>
2
3         Rubber stamped by Anders.
4
5         Use [NSURL absoluteString] instead of [NSURL description] in order to get
6         more uniform results cross platform.
7
8         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
9         (-[NSURL _drt_descriptionSuitableForTestResult]):
10
11 2007-12-02  Sam Weinig  <sam@webkit.org>
12
13         Rubber stamped by Niko.
14
15         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
16
17         * DumpRenderTree/win/DumpRenderTree.cpp:
18         * DumpRenderTree/win/DumpRenderTree.vcproj:
19         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
20         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
21         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
22         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
23
24 2007-12-01  Alp Toker  <alp@atoker.com>
25
26         Reviewed by Adam Roben.
27
28         Make use of the newly introduced webkit.h convenience header.
29
30         * GtkLauncher/main.c:
31
32 2007-12-01  Adam Treat  <treat@kde.org>
33
34         Reviewed by Simon.
35
36         * Check to see if the directory exists and exit if not.
37
38         * DumpRenderTree/qt/main.cpp:
39         (main):
40
41 2007-12-01  Adam Treat  <treat@kde.org>
42
43         Reviewed by Simon.
44
45         * Don't hide symbols when in Debug mode
46         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
47
48
49         * DumpRenderTree/qt/main.cpp:
50         (messageHandler):
51
52 2007-11-30  Alp Toker  <alp@atoker.com>
53
54         Reviewed by Adam Roben.
55
56         http://bugs.webkit.org/show_bug.cgi?id=15691
57         [GTK] Public API does not follow GTK+ conventions
58
59         Refactor the WebKit/GTK+ public API. Changes:
60           WebKitPage -> WebKitWebView
61           WebKitFrame -> WebKitWebFrame
62
63         Public API source and header names have been updated to mirror the API
64         changes.
65
66         The API is now kept in WebKit/gtk/WebView to match other ports in the
67         same class such as Mac and Win.
68
69         * GtkLauncher/main.c:
70         (activate_uri_entry_cb):
71         (link_hover_cb):
72         (title_change_cb):
73         (progress_change_cb):
74         (go_back_cb):
75         (go_forward_cb):
76         (create_browser):
77         (main):
78
79 2007-11-30  Adam Roben  <aroben@apple.com>
80
81         Hopefully the final build fix
82
83         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
84         pull in WTF's assertion/logging functions.
85
86 2007-11-30  Adam Roben  <aroben@apple.com>
87
88         Another build fix
89
90         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
91         WebKit.lib.
92
93 2007-11-30  Adam Roben  <aroben@apple.com>
94
95         Debug build fix
96
97         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
98         configuration.
99         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
100         projects.
101         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
102         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
103         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
104
105 2007-11-30  Sam Weinig  <sam@webkit.org>
106
107         Reviewed by Adam Roben.
108
109         Fix drawSelectionRect to actually draw the selection rect.
110
111         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
112         (drawSelectionRect):
113
114 2007-11-30  Darin Adler  <darin@apple.com>
115
116         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
117
118 2007-11-30  Darin Adler  <darin@apple.com>
119
120         * Scripts/do-webcore-rename: Get ready for some future renaming.
121
122 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
123
124         Reviewed by Adam.
125
126         - Removed some unnecessary functions and changed an unused return type. 
127
128         * Drosera/win/DebuggerClient.cpp:
129         (registerConsoleClass):
130         * Drosera/win/DebuggerClient.h:
131         * Drosera/win/Drosera.cpp:
132         (registerDroseraClass):
133
134 2007-11-28  Alp Toker  <alp@atoker.com>
135
136         Reviewed by Timothy Hatcher.
137
138         http://bugs.webkit.org/show_bug.cgi?id=16174
139         [GTK] Use "URI" not "URL" in public API
140
141         Replace use of the term "URL" with "URI" in public headers,
142         documentation and some internal code to match GLib/GTK+ convention.
143
144         This is now mentioned in the API guidelines:
145           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
146
147         * GtkLauncher/main.c:
148         (activate_uri_entry_cb):
149         (title_change_cb):
150         (create_toolbar):
151         (main):
152
153 2007-11-29  Anders Carlsson  <andersca@apple.com>
154
155         Reviewed by Sam.
156
157         <rdar://problem/5230478>
158         FrameLoadDelegate callbacks are not dumped in DRT.
159         
160         * DumpRenderTree/win/DumpRenderTree.cpp:
161         (shouldLogFrameLoadDelegates):
162         (runTest):
163         (main):
164         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
165         (BSTRtoString):
166         (descriptionSuitableForTestResult):
167         (FrameLoadDelegate::QueryInterface):
168         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
169         (FrameLoadDelegate::didFailProvisionalLoadWithError):
170         (FrameLoadDelegate::didCommitLoadForFrame):
171         (FrameLoadDelegate::didFinishLoadForFrame):
172         (FrameLoadDelegate::willCloseFrame):
173         (FrameLoadDelegate::didClearWindowObject):
174         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
175         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
176         * DumpRenderTree/win/FrameLoaderDelegate.h:
177         (FrameLoadDelegate::windowScriptObjectAvailable):
178         (FrameLoadDelegate::didFirstLayoutInFrame):
179
180 2007-11-29  Sam Weinig  <sam@webkit.org>
181
182         Reviewed by Anders.
183
184         Add database quota UIDelegates methods to DRT UIDelegate.
185
186         * DumpRenderTree/mac/UIDelegate.mm:
187         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
188         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
189
190 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
191
192         Reviewed by Sam.
193
194         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
195         dying and vice versa.
196         - This fix will allow Drosera and Safari to reconnect if either of them
197         closes correctly, but does not fix the case where one of them dies
198         silently.
199
200         * Drosera/win/ServerConnection.cpp:
201         (ServerConnection::attemptToCreateServerConnection): Added a safety
202         check, because it's possilbe to try to connect to a server that's dying.
203         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
204         the server has died.
205         * Drosera/win/ServerConnection.h: Added the new function and removed
206         an unnecessary member.
207
208 2007-11-29  Anders Carlsson  <andersca@apple.com>
209
210         * DumpRenderTree/win/DumpRenderTree.vcproj:
211         Add shlwapi.lib to all configurations.
212
213 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
214
215         - Build fix.  Added additional includes for VS Express to the Release
216         project.
217
218         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
219
220 2007-11-29  Anders Carlsson  <andersca@apple.com>
221
222         Reviewed by Adam.
223
224         <rdar://problem/5132005>
225         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
226         
227         * DumpRenderTree/win/DumpRenderTree.vcproj:
228         Add shlwapi.lib
229         
230         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
231         (LayoutTestController::setUserStyleSheetEnabled):
232         Implement this.
233         
234         (appendComponentToPath):
235         New method which wraps the Win32 API PathAppend.
236         
237         (followShortcuts):
238         New method which checks if a file points to a shortcut and
239         follows the shortcut.
240         
241         (resolveCygwinPath):
242         New method that takes a cygwin unix-style path and returns the Win32 path.
243         
244         (cfStringRefToWString):
245         
246         (LayoutTestController::setUserStyleSheetLocation):
247         Implement this.
248
249 2007-11-29  Alice Liu  <alice.liu@apple.com>
250
251         Reviewed by Adam.
252
253         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
254
255         * DumpRenderTree/win/EventSender.cpp:
256         (keyDownCallback):
257         uppercase letters were being sent as lowercase letters without the shift key down.
258
259 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
260
261         - Windows build fix. VS express needs some love.
262
263         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
264
265 2007-11-28  Darin Adler  <darin@apple.com>
266
267         Reviewed by Adam Roben.
268
269         * DumpRenderTree/mac/EventSendingController.mm:
270         (-[EventSendingController keyDown:withModifiers:]):
271         Send capital letters through as lowercase letters with the shift key down
272         rather than sending them as if they were highly unusual "capital letter keys".
273
274         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
275         where you need to update results and more tests are failing than before.
276
277 2007-11-28  Anders Carlsson  <andersca@apple.com>
278
279         Reviewed by Darin.
280
281         <rdar://problem/5132001>
282         contextClick is not implemented in DRT on Windows.
283         
284         * DumpRenderTree/win/EventSender.cpp:
285         (contextClickCallback):
286         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
287         by a WM_RBUTTONUP message.
288         
289         * DumpRenderTree/win/UIDelegate.cpp:
290         (UIDelegate::hasCustomMenuImplementation):
291         (UIDelegate::trackCustomPopupMenu):
292         * DumpRenderTree/win/UIDelegate.h:
293         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
294         menu from being shown (and causing the DRT to hang).
295
296 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
297
298         Reviewed by Darin.
299
300         Fix DumpRenderTree ObjC bug comparing strings.
301
302         * DumpRenderTree/mac/ObjCController.m:
303         (-[ObjCController identityIsEqual::]): Compare strings with string
304         equality instead of identiy equality.
305
306 2007-11-27  Timothy Hatcher  <timothy@apple.com>
307
308         Reviewed by Sam.
309
310         Reset the authorAndUserStylesEnabled preference
311         back to YES for each test. Fixes the broken tests.
312
313         * DumpRenderTree/mac/DumpRenderTree.mm:
314         (resetWebViewToConsistentStateBeforeTesting):
315
316 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
317
318         Reviewed by Adam.
319
320         - Drosera now displays the console window, although it cannot currently
321         process JavaScript.
322
323         * Drosera/win/DebuggerClient.cpp: Shows the console window.
324         (registerConsoleClass): Implemented.
325         (consoleWndProc): Implemented.
326         (DebuggerClient::onSize): Implemented.
327         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
328         new window.
329         * Drosera/win/DebuggerClient.h: Added needed method and members for 
330         creating and maintaining a new window.
331         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
332         lines of code to more appropriate places.
333         (Drosera::handleCommand):
334         (Drosera::initUI):
335         (Drosera::onSize):
336         (Drosera::attach):
337
338 2007-11-27  Timothy Hatcher  <timothy@apple.com>
339
340         Reviewed by Dave Hyatt.
341
342         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
343         
344         Add support for disabling author and user styles for testing.
345
346         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
347         * DumpRenderTree/LayoutTestController.cpp:
348         (setAuthorAndUserStylesEnabledCallback):
349         (LayoutTestController::staticFunctions):
350         * DumpRenderTree/LayoutTestController.h:
351         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
352         (LayoutTestController::setAuthorAndUserStylesEnabled):
353         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
354         (LayoutTestController::setAuthorAndUserStylesEnabled):
355
356 2007-11-26  Dan Bernstein  <mitz@apple.com>
357
358         - Tiger build fix.
359
360         * DumpRenderTree/mac/Configurations/Base.xcconfig:
361
362 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
363
364         Reviewed by Maciej.
365
366         - Implemented displaying variables for Drosera on Win.
367
368         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
369         that retrieve variables to not hold onto the return value since it's
370         not returned.  Also changed to use the new signatures of the retrieval
371         functions.
372         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
373         (DebuggerDocument::platformValueForScopeVariableNamed):
374         * Drosera/win/Drosera.cpp: Removed a needless TODO.
375         (droseraWndProc):
376
377 2007-11-26  Sam Weinig  <sam@webkit.org>
378
379         Cleanup names of painting and repainting functions.
380
381         Reviewed by Adam Roben.
382
383         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
384         (drawSelectionRect): was drawSelectionRectIntoContext.
385         (dumpWebViewAsPixelsAndCompareWithExpected):
386         * DumpRenderTree/cg/PixelDumpSupportCG.h:
387         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
388         (paintWebView): was drawWebViewIntoContext.
389         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
390
391 2007-11-26  Sam Weinig  <sam@webkit.org>
392
393         Reviewed by Dan Bernstein.
394
395         - Leopard build fix
396
397         * DumpRenderTree/mac/Configurations/Base.xcconfig:
398
399 2007-11-26  Sam Weinig  <sam@webkit.org>
400
401         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
402         Use shared PixelDumpSupport for Mac DRT
403
404         Reviewed by Adam Roben.
405
406         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
407         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
408         * DumpRenderTree/cg/ImageDiffCG.cpp:
409         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
410         (drawSelectionRectIntoContext):
411         (dumpWebViewAsPixelsAndCompareWithExpected):
412         * DumpRenderTree/cg/PixelDumpSupportCG.h:
413         * DumpRenderTree/mac/Configurations/Base.xcconfig:
414         * DumpRenderTree/mac/DumpRenderTree.mm:
415         (dump):
416         * DumpRenderTree/mac/ImageDiff.m: Removed.
417         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
418         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
419         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
420         (setDefaultColorProfileToRGB):
421         (getBitmapContextFromWebView):
422         (drawWebViewIntoContext):
423         (repaintWithVerticalSweep):
424         (repaintWithHorizontalSweep):
425         (getSelectionRect):
426         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
427
428 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
429
430         Bug 16052: prepare-ChangeLog doesn't report deleted files
431         <http://bugs.webkit.org/show_bug.cgi?id=16052>
432
433         Reviewed by Sam.
434
435         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
436
437 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
438
439         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
440         <http://bugs.webkit.org/show_bug.cgi?id=15864>
441
442         Reviewed by Adam.
443
444         Roll functionality of merge-changelog into resolve-ChangeLogs
445         script.  The script now checks for ChangeLog.rej and
446         ChangeLog.orig files first.  If it finds them, it uses the
447         ChangeLog.rej file as a patch (in old contextual diff format) to
448         apply with --fuzz=3.
449
450         * Scripts/merge-changelog: Removed.
451         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
452
453 2007-11-25  Sam Weinig  <sam@webkit.org>
454
455         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
456
457         Reviewed by Mark Rowe.
458
459         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
460         * DumpRenderTree/mac/Configurations/Base.xcconfig:
461         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
462         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
463         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
464
465 2007-11-25  Sam Weinig  <sam@webkit.org>
466
467         Convert DumpRenderTree to ues .xcconfig files.
468
469         Reviewed by Mark Rowe.
470
471         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
472         * DumpRenderTree/mac/Configurations: Added.
473         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
474         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
475         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
476
477 2007-11-25  Sam Weinig  <sam@webkit.org>
478
479         Add ForwardingHeaders to wtf for DumpRenderTree.
480
481         Reviewed by Mark Rowe.
482
483         * DumpRenderTree/DumpRenderTree.h:
484         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
485         * DumpRenderTree/ForwardingHeaders: Added.
486         * DumpRenderTree/ForwardingHeaders/wtf: Added.
487         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
488         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
489         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
490         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
491         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
492         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
493         * DumpRenderTree/LayoutTestController.cpp:
494         * DumpRenderTree/WorkQueue.cpp:
495         * DumpRenderTree/mac/DumpRenderTree.mm:
496         * DumpRenderTree/mac/FrameLoadDelegate.mm:
497         * DumpRenderTree/mac/JavaScriptThreading.cpp:
498         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
499         * DumpRenderTree/mac/ObjCController.m:
500         * DumpRenderTree/mac/UIDelegate.mm:
501         * DumpRenderTree/mac/WorkQueueItemMac.mm:
502
503 2007-11-25  Adam Roben  <aroben@apple.com>
504
505         Fix some test failures caused by r28019
506
507         Now that stdout is in binary mode, we need to always use printf
508         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
509         the output.
510
511         Reviewed by Sam.
512
513         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
514         printf.
515         (UIDelegate::runJavaScriptAlertPanelWithMessage):
516         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
517         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
518         (UIDelegate::webViewAddMessageToConsole):
519
520 2007-11-25  Adam Roben  <aroben@apple.com>
521
522         Set the font smoothing preference in DRT
523
524         This makes the pixel results on Windows closer to the Mac results.
525
526         Reviewed by Mitz.
527
528         * DumpRenderTree/win/DumpRenderTree.cpp:
529         (initializePreferences):
530
531 2007-11-25  Adam Roben  <aroben@apple.com>
532
533         Port ImageDiff to CG and C++
534
535         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
536         <rdar://5071708>
537
538         Reviewed by Sam.
539
540         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
541         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
542         (main):
543         (createImageFromStdin):
544         (compareImages):
545         (getDifferenceBitmap):
546         (computePercentageDifferent):
547         * DumpRenderTree/win/ImageDiff.vcproj: Added.
548
549 2007-11-25  Adam Roben  <aroben@apple.com>
550
551         Fix image diff link generation on Windows
552
553         Reviewed by Sam.
554
555         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
556         to toURL.
557
558 2007-11-25  Adam Roben  <aroben@apple.com>
559
560         Implement pixel dumping in Windows DRT
561
562         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
563         <rdar://5071708>
564
565         Reviewed by Sam.
566
567         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
568         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
569         Content-Length header.
570         (getMD5HashStringForBitmap):
571         (dumpWebViewAsPixelsAndCompareWithExpected):
572         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
573         * DumpRenderTree/win/DumpRenderTree.cpp:
574         (dump): Do a pixel dump if requested.
575         (main): Parse pixel test options.
576         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
577         the cg/ subdirectory to the include path.
578         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
579         available in a header or import library, so we have to go through this
580         LoadLibrary/GetProcAddress dance to use them.
581         (cryptDLL):
582         (init):
583         (update):
584         (final):
585         (MD5_Init):
586         (MD5_Update):
587         (MD5_Final):
588         * DumpRenderTree/win/MD5.h: Added.
589         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
590         moved up to the top level to share it with Mac eventually.
591         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
592         (getBitmapContextFromWebView): Forces the WebView to paint using a
593         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
594
595 2007-11-25  Adam Roben  <aroben@apple.com>
596
597         Clean up Windows DRT's option parsing a little bit
598
599         Reviewed by Sam.
600
601         * DumpRenderTree/win/DumpRenderTree.cpp:
602         (main): Put non-option arguments into a Vector.
603
604 2007-11-25  Adam Roben  <aroben@apple.com>
605
606         Make Windows DRT stop changing LF into CRLF
607
608         Reviewed by Sam.
609
610         * DumpRenderTree/win/DumpRenderTree.cpp:
611         (main): Put stdout in binary mode.
612         * Scripts/run-webkit-tests: Remove the CRLF hack.
613
614 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
615
616         Removed empty directory.
617
618         * Scripts/resources: Removed.
619
620 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
621
622         Fix bisect-builds to work with recent WebKit nightly builds.
623
624         Reviewed by Dan.
625
626         * Scripts/bisect-builds: Check for the 
627         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
628         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
629         to WebKit.app/Contents/Resources.
630
631 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
632
633         Reviewed by Maciej.
634
635         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
636         not closed (affects digg.com)
637
638         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
639         one after finishing with a test to avoid having its delayed onload handler firing when
640         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
641         but it helps somewhat.
642
643 2007-11-22  Mark Rowe  <mrowe@apple.com>
644
645         Reviewed by Alp Toker.
646
647         Fix build-webkit to propagate make's exit status if it fails.
648
649         * Scripts/webkitdirs.pm:
650
651 2007-11-22  Dan Bernstein  <mitz@apple.com>
652
653         Reviewed by Mark Rowe.
654
655         - fix crash when running pixel tests
656
657         * DumpRenderTree/mac/DumpRenderTree.mm:
658         (dumpRenderTree): Parse the command line options before setting up the
659         environment so that we know if we need to set up the pixel dump
660         machinery.
661
662 2007-11-21  Eric Seidel  <eric@webkit.org>
663
664         Speculative build fix for Tiger.
665
666         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
667
668 2007-11-21  Eric Seidel  <eric@webkit.org>
669
670         Reviewed by Tim Hatcher.
671
672         Break out more of DumpRenderTree.mm into individual files
673
674         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
675         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
676         (checkedMalloc):
677         (checkedRealloc):
678         (makeLargeMallocFailSilently):
679         * DumpRenderTree/mac/CheckedMalloc.h: Added.
680         * DumpRenderTree/mac/DumpRenderTree.mm:
681         (crashHandler):
682         (dump):
683         * DumpRenderTree/mac/DumpRenderTreeMac.h:
684         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
685         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
686         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
687         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
688         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
689         (javaScriptThreads):
690         (runJavaScriptThread):
691         (startJavaScriptThreads):
692         (stopJavaScriptThreads):
693         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
694         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
695         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
696         (restoreColorSpace):
697         (setDefaultColorProfileToRGB):
698         (initializeColorSpaceAndScreeBufferForPixelTests):
699         (md5HashStringForBitmap):
700         (dumpWebViewAsPixelsAndCompareWithExpected):
701
702 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
703
704         Move install-unix-extras to wx directory as it seems only to be used by that 
705         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
706         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
707         have install-unix-extras install into WebKitLibraries as per
708         convention.
709         
710         Reviewed by Mark Rowe.
711
712         * Scripts/install-unix-extras: Removed.
713         * wx/build-wxwebkit:
714         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
715
716 2007-11-21  Eric Seidel  <eric@webkit.org>
717
718         Reviewed by Adam.
719
720         More refactoring for greater code readability
721
722         * DumpRenderTree/mac/DumpRenderTree.mm:
723         (initializeGlobalsFromCommandLineOptions):
724         (initializeColorSpaceAndScreeBufferForPixelTests):
725         (addTestPluginsToPluginSearchPath):
726         (useLongRunningServerMode):
727         (runTestingServerLoop):
728         (prepareConsistentTestingEnvironment):
729         (dumpRenderTree):
730         (main):
731         (dumpFramesAsText):
732         (dumpBackForwardListForWebView):
733         (sizeWebViewForCurrentTest):
734         (methodNameStringForFailedTest):
735         (dumpBackForwardListForAllWindows):
736         (dumpWebViewAsPixelsAndCompareWithExpected):
737         (invalidateAnyPreviousWaitToDumpWatchdog):
738         (dump):
739         * DumpRenderTree/mac/DumpRenderTreeMac.h:
740         * DumpRenderTree/mac/UIDelegate.mm:
741         (-[UIDelegate webView:createWebViewWithRequest:]):
742
743 2007-11-21  Eric Seidel  <eric@webkit.org>
744
745         Reviewed by Tim Hatcher.
746
747         Abstract more of DRT into static methods
748
749         * DumpRenderTree/mac/DumpRenderTree.mm:
750         (setDefaultsToConsistentValuesForTesting):
751         (setupSignalHandlers):
752         (allocateGlobalControllers):
753         (releaseAndZero):
754         (releaseGlobalControllers):
755         (dumpRenderTree):
756         (shouldLogFrameLoadDelegates):
757         (createCFURLFromPathOrURL):
758         (resetWebViewToConsistentStateBeforeTesting):
759         (runTest):
760
761 2007-11-21  Eric Seidel  <eric@webkit.org>
762
763         Reviewed by Tim Hatcher.
764
765         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
766
767         * DumpRenderTree/DumpRenderTree.h:
768         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
769         * DumpRenderTree/mac/DumpRenderTree.mm:
770         (dumpRenderTree):
771         (dump):
772         (runTest):
773         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
774         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
775         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
776         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
777         (-[DumpRenderTreePasteboard declareType:owner:]):
778         (+[LocalPasteboard alloc]):
779         (-[LocalPasteboard init]):
780         (-[LocalPasteboard dealloc]):
781         (-[LocalPasteboard name]):
782         (-[LocalPasteboard releaseGlobally]):
783         (-[LocalPasteboard declareTypes:owner:]):
784         (-[LocalPasteboard addTypes:owner:]):
785         (-[LocalPasteboard changeCount]):
786         (-[LocalPasteboard types]):
787         (-[LocalPasteboard availableTypeFromArray:]):
788         (-[LocalPasteboard setData:forType:]):
789         (-[LocalPasteboard dataForType:]):
790         (-[LocalPasteboard setPropertyList:forType:]):
791         (-[LocalPasteboard setString:forType:]):
792         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
793         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
794         (+[DumpRenderTreeWindow allWindows]):
795         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
796         (-[DumpRenderTreeWindow dealloc]):
797         (-[DumpRenderTreeWindow isKeyWindow]):
798         (-[DumpRenderTreeWindow keyDown:]):
799
800 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
801
802         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
803         it indiscriminately copies any headers inside JavaScriptCore,
804         which includes Tiger ICU headers. 
805
806         * wx/build-wxwebkit:
807         Don't run WebCore/move-js-headers.sh any longer.
808
809 2007-11-20  Adam Treat  <treat@kde.org>
810
811         Reviewed by David Kilzer.
812
813         * Prepend git branch name to $baseProductDir
814
815         * Scripts/VCSUtils.pm:
816         * Scripts/webkitdirs.pm:
817
818 2007-11-20  Mark Rowe  <mrowe@apple.com>
819
820         Reviewed by Simon Hausmann.
821
822         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
823         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
824         Have it trigger a "make distclean" rather than "make clean" to ensure that the
825         built product and generated Makefile's are removed.
826
827 2007-11-19  Alp Toker  <alp@atoker.com>
828
829         Reviewed by Mark Rowe.
830
831         http://bugs.webkit.org/show_bug.cgi?id=16040
832         [GTK] GtkLauncher should be written in C
833
834         Port GtkLauncher to plain C.
835
836         Use a more conventional GTK+ coding style.
837
838         Use a toolbar instead of menus.
839
840         Various signature fixes and cleanups.
841
842         Add a license header. Assume all previous modifications were copyright
843         assigned to Apple Inc. by default.
844
845         * GtkLauncher/GtkLauncher.pro:
846         * GtkLauncher/main.c: Added.
847         (activate_url_entry_cb):
848         (update_title):
849         (link_hover_cb):
850         (title_change_cb):
851         (progress_change_cb):
852         (destroy_cb):
853         (go_back_cb):
854         (go_forward_cb):
855         (create_browser):
856         (create_statusbar):
857         (create_toolbar):
858         (create_window):
859         (main):
860         * GtkLauncher/main.cpp: Removed.
861
862 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
863
864         Build script fixes to ensure they do the right thing for the 
865         wx port, and update build-wxwebkit to reflect the way the
866         build scripts now work.
867
868         Reviewed by Adam.
869
870         * Scripts/build-testkjs:
871         * Scripts/build-webkit:
872         * Scripts/run-javascriptcore-tests:
873         * Scripts/webkitdirs.pm:
874         * wx/build-wxwebkit:
875
876 2007-11-18  Eric Seidel  <eric@webkit.org>
877
878         Reviewed by Anders.
879
880         Make run-javascriptcore-tests report failures on exit (to support git bisect)
881
882         * Scripts/run-javascriptcore-tests:
883
884 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
885
886         Reviewed by Adam Roben.
887
888         Make run-webkit-tests work with Windows debug build.
889
890         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
891         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
892         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
893         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
894         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
895
896 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
897
898         Add wxWebKit sample and build script, and integrate it with 
899         build-webkit. Also make build-webkit --clean work for all
900         ports.
901
902         Reviewed by Darin Adler.
903
904         * Scripts/build-webkit:
905         * Scripts/webkitdirs.pm:
906         * wx: Added.
907         * wx/browser: Added.
908         * wx/browser/browser.bkl: Added.
909         * wx/browser/browser.cpp: Added.
910         * wx/build-wxwebkit: Added.
911
912 2007-11-17  Adam Roben  <aroben@apple.com>
913
914         Make it easy to run Safari in the debugger on Windows
915
916         I've added a new script, debug-safari, which launches Safari in the
917         debugger. On OS X it just calls gdb-safari.
918
919         Reviewed by Mark Rowe.
920
921         * FindSafari/FindSafari.cpp:
922         (_tmain): Added a /debugger flag, which in combination with
923         /printSafariLauncher will print a script that launches Safari in the
924         debugger.
925         * Scripts/debug-safari: Added.
926         * Scripts/run-safari: Changed to call runSafari().
927         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
928         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
929         first argument along to FindSafari.
930         * Scripts/webkitdirs.pm:
931         (sub runSafari): Added.
932
933 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
934
935         Reviewed by Adam Roben.
936
937         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
938
939 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
940
941         Reviewed by David Kilzer.
942
943         The git config command was renamed to repo-config at some point. This
944         change tries git config and then git repo-config if the first fails.
945
946         * Scripts/prepare-ChangeLog:
947         (gitConfig):
948
949 2007-11-16  Dan Bernstein  <mitz@apple.com>
950
951         Reviewed by Darin Adler and Sam Weinig.
952
953         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
954
955         * DumpRenderTree/win/EventSender.cpp:
956         (keyDownCallback): For characters that cannot be entered on the active
957         keyboard layout, send a WM_CHAR message with the character along with
958         a WM_KEYDOWN message with a virtual key code of 255.
959
960 2007-11-16  Mark Rowe  <mrowe@apple.com>
961
962         Reviewed by Tim Hatcher.
963
964         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
965
966         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
967         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
968
969 2007-11-15  Adam Roben  <aroben@apple.com>
970
971         Make run-safari actually work on Windows
972
973         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
974         chdir call.
975
976 2007-11-14  Adam Roben  <aroben@apple.com>
977
978         Updates to Safari launching now that 3.0.4 is released
979
980         Reviewed by Sam.
981
982         * FindSafari/FindSafari.cpp:
983         (getWebViewCLSID): Use version-independent ProgID.
984         * Scripts/run-safari: Use run-webkit-nightly.cmd.
985
986 2007-11-14  Anders Carlsson  <andersca@apple.com>
987
988         Reviewed by Adam.
989
990         <rdar://problem/5309081>
991         In DRT, "plugin.logDestroy = true" not working on Windows.
992         
993         * DumpRenderTree/win/TestNetscapePlugin/main.c:
994         (NPP_Destroy):
995
996 2007-11-14  Eric Seidel  <eric@webkit.org>
997
998         Reviewed by Sam.
999
1000         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1001
1002 2007-11-14  Anders Carlsson  <andersca@apple.com>
1003
1004         Reviewed by Adam.
1005
1006         <rdar://problem/5141186>
1007         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1008         
1009         Implement setWindowIsKey.
1010         
1011         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1012         (LayoutTestController::setWindowIsKey):
1013
1014 2007-11-13  Sam Weinig  <sam@webkit.org>
1015
1016         Reviewed by Adam Roben.
1017
1018         Fix for <rdar://problem/5382579>
1019         http/tests/security/cross-frame-access-put.html reports large 
1020         negative numbers for screenLeft and screenTop (Mac reports "0")
1021
1022         * DumpRenderTree/win/UIDelegate.cpp:
1023         (UIDelegate::UIDelegate): Initialize the RECT.
1024         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1025         (UIDelegate::webViewFrame): ditto.
1026         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1027
1028 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1029
1030         Reviewed by Adam.
1031
1032         - Make Drosera show source, source URLs, and function stack on Windows,
1033         and some minor fixes.
1034
1035         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1036         (DebuggerDocument::updateFileSource):
1037         * Drosera/debugger.js: Force source to always update display.
1038         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1039         menu controls.
1040         (DebuggerClient::resume):
1041         (DebuggerClient::pause):
1042         (DebuggerClient::stepInto):
1043         (DebuggerClient::stepOver):
1044         (DebuggerClient::stepOut):
1045         (DebuggerClient::showConsole):
1046         (DebuggerClient::closeCurrentFile):
1047         * Drosera/win/DebuggerClient.h: Ditto.
1048         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1049         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1050         removed two bugs.  1) caller could be in a bad state when asked to
1051         assign into it. 2) BSTRs were not created correctly.
1052         (DebuggerDocument::getPlatformCurrentFunctionStack):
1053         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1054         (droseraWndProc):
1055         (handleCommand):
1056         (Drosera::resume):
1057         (Drosera::pause):
1058         (Drosera::stepInto):
1059         (Drosera::stepOver):
1060         (Drosera::stepOut):
1061         (Drosera::showConsole):
1062         (Drosera::closeCurrentFile):
1063         * Drosera/win/Drosera.h: Hook up the menu controls.
1064         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1065         functions, added a null check, and fixed another bug where caller could
1066         be in a bad state when asked to assign into it.
1067         (ServerConnection::didLoadMainResourceForDataSource):
1068         (ServerConnection::getCallerFrame):
1069         * Drosera/win/ServerConnection.h: Safety first.
1070
1071 2007-11-13  Dan Bernstein  <mitz@apple.com>
1072
1073         Reviewed by Darin Adler.
1074
1075         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1076           DumpRenderTree --pixel-tests renders each test twice
1077
1078         * DumpRenderTree/mac/DumpRenderTree.mm:
1079         (dumpRenderTree): Removed the --paint option because the painting code
1080         is always exercised as a result of
1081         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1082         calling -displayIfNeeded.
1083         (dump): Changed to always grab the image from the window since the view
1084         is always displayed.
1085         (runTest):
1086         (displayWebView):
1087         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1088         because it always paints.
1089
1090 2007-11-12  Antti Koivisto  <antti@apple.com>
1091
1092         Reviewed by Adele.
1093         
1094         Add support for http media tests
1095
1096         * Scripts/run-webkit-tests:
1097
1098 2007-11-12  Sam Weinig  <sam@webkit.org>
1099
1100         Reviewed by Adam Roben.
1101
1102         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1103
1104         * DumpRenderTree/win/DumpRenderTree.cpp:
1105         (runTest):
1106         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1107         (LayoutTestController::setPrivateBrowsingEnabled):
1108
1109 2007-11-12  Adam Roben  <aroben@apple.com>
1110
1111         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1112         mac and win subdirectories.
1113
1114 2007-11-11  Adam Roben  <aroben@apple.com>
1115
1116         Fix <rdar://5133816> keepWebHistory is not implemented
1117
1118         Fixes fast/history/clicked-link-is-visited.html.
1119
1120         Reviewed by Darin.
1121
1122         * DumpRenderTree/win/DumpRenderTree.cpp:
1123         (runTest): Clear the optionalSharedHistory.
1124         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1125         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1126
1127 2007-11-10  Sam Weinig  <sam@webkit.org>
1128
1129         Reviewed by Tim Hatcher.
1130
1131         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
1132         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
1133         is turned on)
1134
1135         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1136
1137         Added test: http/tests/security/cross-frame-access-private-browsing.html
1138
1139         * DumpRenderTree/LayoutTestController.cpp:
1140         (setPrivateBrowsingEnabledCallback):
1141         (LayoutTestController::staticFunctions):
1142         * DumpRenderTree/LayoutTestController.h:
1143         * DumpRenderTree/mac/DumpRenderTree.mm:
1144         (runTest): Default to private browsing disabled.
1145         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1146         (LayoutTestController::setPrivateBrowsingEnabled):
1147         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1148         (LayoutTestController::setPrivateBrowsingEnabled):
1149
1150 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1151
1152         Reviewed by Adam.
1153
1154         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1155         WebCore's!
1156
1157         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1158         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1159         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1160         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1161         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1162         * Drosera/win/Drosera.cpp:
1163         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1164
1165 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1166
1167         Reviewed by Sam.
1168
1169         - Use the new IWebFrame [local] function signature and get the shared
1170         server correctly.
1171
1172         * Drosera/win/DebuggerClient.cpp:
1173         (DebuggerClient::didFinishLoadForFrame):
1174         * Drosera/win/ServerConnection.cpp:
1175         (ServerConnection::attemptToCreateServerConnection):
1176
1177 2007-11-07  Dan Bernstein  <mitz@apple.com>
1178
1179         Reviewed by Darin Adler.
1180
1181         - add an option to run-webkit-tests to ignore pixel test failures where
1182           all pixels differ by no more than a specified threshold
1183
1184         * DumpRenderTree/mac/ImageDiff.m:
1185         (main):
1186         (compareImages):
1187         (computePercentageDifferent):
1188         * Scripts/run-webkit-tests:
1189
1190 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1191
1192         Reviewed by Lars.
1193
1194         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1195
1196         * DumpRenderTree/qt/DumpRenderTree.cpp:
1197
1198 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1199
1200         Reviewed by Lars.
1201
1202         Reworked the QWebSettings API.
1203         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1204
1205         * DumpRenderTree/qt/DumpRenderTree.cpp:
1206
1207 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1208
1209         Reviewed by Lars.
1210
1211         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1212
1213         * DumpRenderTree/qt/jsobjects.cpp:
1214
1215 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1216
1217         Reviewed by Lars Knoll <lars@trolltech.com>.
1218
1219         Add a QWebPage::frameCreated() signal and fix DRT
1220         
1221         The removal of createFrame in QWebPage broke the re-implementation
1222         in DumpRenderTree. Instead emit a frameCreated() signal and
1223         connect to it in DumpRenderTree.
1224         
1225
1226         * DumpRenderTree/qt/DumpRenderTree.cpp:
1227         (WebCore::WebPage::WebPage):
1228         (WebCore::DumpRenderTree::dump):
1229         (WebCore::DumpRenderTree::connectFrame):
1230         * DumpRenderTree/qt/DumpRenderTree.h:
1231
1232 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1233
1234         Reviewed by Lars Knoll <lars@trolltech.com>.
1235
1236         Moved all the event handlers from QWebFrame into QWebPage.
1237         
1238         This cleans up the public API and allows us to remove the
1239         HackWebFrame hack in DumpRenderTree.
1240         
1241
1242         * DumpRenderTree/qt/jsobjects.cpp:
1243         (EventSender::mouseDown):
1244         (EventSender::mouseUp):
1245         (EventSender::mouseMoveTo):
1246
1247 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1248
1249         Reviewed by Mark.
1250
1251         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1252         to prevent the default implementation from popping up messageboxes.
1253
1254         * DumpRenderTree/qt/DumpRenderTree.cpp:
1255         (WebCore::WebPage::javaScriptConfirm):
1256         (WebCore::WebPage::javaScriptPrompt):
1257
1258 2007-11-06  Eric Seidel  <eric@webkit.org>
1259
1260         * Scripts/build-testkjs: build fix... too many $$
1261
1262 2007-11-06  Eric Seidel  <eric@webkit.org>
1263
1264         Reviewed by Mark Rowe.
1265
1266         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1267
1268 2007-11-05  Adam Roben  <aroben@apple.com>
1269
1270         Add support on Windows for WEBKIT_TESTFONTS
1271
1272         This environment variable lets you specify where the fonts to be used
1273         by DumpRenderTree reside. The Qt port is already using this, so I'm
1274         just following their lead.
1275
1276         Reviewed by Darin.
1277
1278         * DumpRenderTree/win/DumpRenderTree.cpp:
1279         (exePath): Refactored code out of initialize().
1280         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1281         DumpRenderTree.resources.
1282         (initialize): Use the new fontsPath function.
1283         (main): Use the new exePath function.
1284         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1285         variable to DRT, like Qt does.
1286
1287 2007-11-05  Mark Rowe  <mrowe@apple.com>
1288
1289         Rubber-stamped by Alp Toker.
1290
1291         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1292
1293         * GtkLauncher/main.cpp:
1294         (goToURLBarText):
1295         (main):
1296
1297 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1298
1299         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1300         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1301
1302         Reviewed by Timothy.
1303
1304         Restrict the range of nightly builds used by the bisect-builds script
1305         based on the version of Safari and the version of Mac OS X being used.
1306
1307         Mac OS X 10.4: Safari 2.0: r11976 or newer
1308         Mac OS X 10.4: Safari 3.0: r19992 or newer
1309
1310         Mac OS X 10.5: Safari 2.0: r19594 or newer
1311         Mac OS X 10.5: Safari 3.0: r25124 or newer
1312
1313         * Scripts/bisect-builds:
1314         (findMacOSXVersion): Added.
1315         (makeNightlyList): Added argument to provide version of Mac OS X.
1316         Restrict range of nightly builds based on Safari and Mac OS X versions.
1317
1318 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1319
1320         Reviewed by Maciej.
1321
1322         - This patch involves several changes, all of them were noticed that
1323         they were needed by the work being done in WebKit to get Drosera and
1324         WebKit working together on Windows.
1325         - The changes are:
1326         1) Added a debugger console for output messages.
1327         2) Drosera now listens for the WebKit server (before, the server would
1328         have to be running before Drosera was started.)
1329         3) Fixed a bug where the WebView started out as 0x0 pixels.
1330         4) Fixed a bug when there is no scope.
1331         5) Added the HTML, JS, and CSS to the project file to make them easy to
1332         find.
1333         6) Made the ServerConnection functions virtual.
1334
1335         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1336         for the WebKit server.
1337         (DebuggerClient::DebuggerClient):
1338         (DebuggerClient::~DebuggerClient):
1339         (DebuggerClient::didFinishLoadForFrame):
1340         (DebuggerClient::serverConnected):
1341         (DebuggerClient::attemptToCreateServerConnection):
1342         * Drosera/win/DebuggerClient.h: Ditto.
1343         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1344         scope.
1345         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1346         (DebuggerDocument::platformValueForScopeVariableNamed):
1347         * Drosera/win/Drosera.cpp:
1348         (_tWinMain): Added a console in debug for output messages.
1349         (Drosera::Drosera): Listen for server.
1350         (Drosera::initUI): The server now Initializes COM.
1351         (Drosera::serverConnected): Part of the listening for the server.
1352         (Drosera::attemptToCreateServerConnection): Ditto.
1353         * Drosera/win/Drosera.h: New interface for listening for the server.
1354         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1355         files to the VS project.
1356         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1357         connection.
1358         (ServerConnection::ServerConnection):
1359         (ServerConnection::attemptToCreateServerConnection):
1360         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1361         methods.
1362         (ServerConnection::serverConnected):
1363
1364 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1365
1366         Reviewed by Maciej.
1367
1368         http://bugs.webkit.org/show_bug.cgi?id=15832
1369         fast/dom/gc-10.html crashes when run alone
1370
1371         Check for !done before using objects that can be already deallocated.
1372
1373         * DumpRenderTree/mac/EditingDelegate.mm:
1374         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1375         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1376         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1377         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1378         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1379         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1380         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1381         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1382         (-[EditingDelegate webViewDidBeginEditing:]):
1383         (-[EditingDelegate webViewDidChange:]):
1384         (-[EditingDelegate webViewDidEndEditing:]):
1385         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1386         (-[EditingDelegate webViewDidChangeSelection:]):
1387         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1388         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1389         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1390         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1391         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1392         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1393         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1394         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1395         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1396         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
1397         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1398         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
1399         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1400         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
1401         (-[FrameLoadDelegate webView:willCloseFrame:]):
1402         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1403         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1404         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1405         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1406         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1407         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1408         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1409         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1410         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1411
1412 2007-11-04  Mark Rowe  <mrowe@apple.com>
1413
1414         Build fix.  Don't use Carbon.h as the prefix header as it triggers
1415         warnings that would otherwise be suppressed due to it being a system header.
1416
1417         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1418
1419 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
1420
1421         Rubber stamped by Adam.
1422         
1423         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
1424
1425         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1426
1427 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1428
1429         Sort files(...); sections of Xcode project files.
1430
1431         Rubber-stamped by Darin.
1432
1433         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1434         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1435         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1436         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1437
1438 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1439
1440         Script to sort "files(...);" sections in Xcode project.pbxproj files.
1441
1442         Reviewed by Darin.
1443
1444         * Scripts/sort-Xcode-project-file: Added.
1445
1446 2007-11-02  Darin Adler  <darin@apple.com>
1447
1448         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
1449
1450 2007-11-02  Darin Adler  <darin@apple.com>
1451
1452         Reviewed by Maciej.
1453
1454         * Scripts/run-sunspider: Pass the "--base" option through.
1455
1456         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
1457         the real script do that. Default configuration to Release to match run-sunspider
1458         so we don't end up building Debug just to compare results.
1459
1460 2007-11-01  Adam Roben  <aroben@apple.com>
1461
1462         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
1463
1464         Reviewed by Sam.
1465
1466         * Scripts/commit-log-editor: Show all the directories beneath the
1467         source root, instead of just the last one.
1468
1469 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
1470
1471         Reviewed by Adam Roben.
1472
1473         Print out an error message when the Windows build fails
1474         and provide guidance on how to find out what went wrong.
1475
1476         * Scripts/build-webkit:
1477         * Scripts/webkitdirs.pm:
1478
1479 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
1480
1481         Rubber-stamped by Adam Roben.
1482
1483         Rolled out r27326 - debug CRT seems to cause no problems after all.
1484
1485         * DumpRenderTree/win/DumpRenderTree.vcproj:
1486
1487 2007-10-31  Adam Roben  <aroben@apple.com>
1488
1489         Switch the Debug configuration to using the non-debug CRT
1490
1491         This matches WebKit.
1492
1493         Reviewed by Steve.
1494
1495         * DumpRenderTree/win/DumpRenderTree.vcproj:
1496
1497 2007-10-31  Antti Koivisto  <antti@apple.com>
1498
1499         Reviewed by bdash.
1500         
1501         Disable media tests when doing leak checking on Tiger.
1502         They crash in QuickTime (rdar://problem/5537157).
1503
1504         * Scripts/run-webkit-tests:
1505
1506 2007-10-29  Antti Koivisto  <antti@apple.com>
1507
1508         Reviewed by Maciej.
1509         
1510         Build media support by default on OSX only.
1511
1512         * Scripts/build-webkit:
1513
1514 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1515
1516         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
1517         get caught by the pre-commit hooks.
1518
1519 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1520
1521         Reviewed by Adam.
1522
1523         - This is a collection of relatively unrelated changes and cleanups
1524         to Drosera to prepare it for interacting with WebKit.  A lot of these
1525         changes are just correcting mistakes, for example removing included
1526         headers that are no longer needed.
1527
1528         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
1529         this will be needed by the DebuggerClient.
1530         (DebuggerDocument::server):
1531         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
1532         * Drosera/win/DebuggerClient.cpp: 
1533         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
1534         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
1535         (DebuggerClient::createWebViewWithRequest): Added comment about its
1536         purpose. 
1537         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
1538         declarations.
1539         (DebuggerClient::webViewLoaded): Moved.
1540         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
1541         file, since this was the only place it was used.
1542         (cfStringToBSTR):
1543         * Drosera/win/Drosera.h: Cleaned up the includes.
1544         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
1545         * Drosera/win/HelperFunctions.h: Removed.
1546
1547 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1548
1549         Reviewed by Adam.
1550
1551         - Small cleanup in the ServerConnection class.
1552
1553         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
1554         and added an include.
1555         (ServerConnection::currentFrame):
1556         (ServerConnection::getCallerFrame):
1557         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
1558         made a pointer into a COMPtr, and cleaned up the includes.
1559
1560 2007-10-29  Timothy Hatcher  <timothy@apple.com>
1561
1562         Reviewed by John Sullivan.
1563         
1564         - Place the Localizable.strings file in mac or win directories
1565           if that location exists.
1566         - Also look for UI_STRING in .c files.
1567
1568         * Scripts/extract-localizable-strings:
1569
1570 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1571
1572         Reviewed by Adam.
1573
1574         - Set the eol-style to native and made all the line endings the same
1575         so that I avoid messy diffs that show eol changes.
1576
1577         * Drosera/win/ServerConnection.cpp:
1578         (ServerConnection::didParseSource):
1579         (ServerConnection::didEnterCallFrame):
1580         (ServerConnection::willExecuteStatement):
1581         (ServerConnection::willLeaveCallFrame):
1582         (ServerConnection::exceptionWasRaised):
1583
1584 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1585
1586         Reviewed by Adam.
1587
1588         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
1589         functionality that could not have existed previously without the new
1590         interfaces.
1591         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
1592         from a BSTR to a JSValueRef.
1593         (DebuggerDocument::platformEvaluateScript): Implemented.
1594         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
1595         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1596         Implemented.
1597         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
1598         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
1599         * Drosera/win/ServerConnection.cpp: Added a helper function.
1600         (ServerConnection::getCallerFrame):
1601         * Drosera/win/ServerConnection.h: Added a helper function.
1602
1603 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1604
1605         updated reviewers for my previous changelog.
1606
1607 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1608         Reviewed by Maciej and Adam and Geoff.
1609
1610         - Minor mac-side improvements including moving a function to a more
1611         appropriate location, fixing a warning, and correctly checking
1612         exceptions.
1613
1614         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
1615         (DebuggerDocument::willExecuteStatement):
1616         (DebuggerDocument::didEnterCallFrame):
1617         (DebuggerDocument::willLeaveCallFrame):
1618         (DebuggerDocument::windowScriptObjectAvailable):
1619         (DebuggerDocument::callFunctionOnObject):
1620         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
1621         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
1622         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
1623         because it doesn't require the ServerConnection at all.
1624         (NSStringCreateWithJSStringRef): Made an argument const.
1625         (JSValueRefCreateWithNSString): Made an argument const.
1626         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
1627         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1628         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
1629         * Drosera/mac/ServerConnection.mm: Ditto.
1630         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1631
1632 2007-10-29  Sam Weinig  <sam@webkit.org>
1633
1634         Reviewed by Adam Roben.
1635
1636         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
1637
1638         * DumpRenderTree/LayoutTestController.cpp:
1639         (LayoutTestController::LayoutTestController):
1640         (getGlobalFlagCallback):
1641         (setGlobalFlagCallback):
1642         (LayoutTestController::getJSClass):
1643         (LayoutTestController::staticValues):
1644         * DumpRenderTree/LayoutTestController.h:
1645         (LayoutTestController::globalFlag):
1646         (LayoutTestController::setGlobalFlag):
1647
1648 2007-10-29  Darin Adler  <darin@apple.com>
1649
1650         Reviewed by Maciej.
1651
1652         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
1653         resolution instead of its default.
1654
1655 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
1656
1657         Fixed showStatus() to print status for successfully resolved conflicts when using git.
1658
1659         Reviewed by Mark Rowe.
1660
1661         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
1662         was successfully resolved, but this would not show any status because the change had
1663         already been cached in the index using "git add".  The solution is to add an optional
1664         second argument to showStatus() which adds the "--cached" switch to the command.
1665
1666         * Scripts/resolve-ChangeLogs:
1667         (showStatus):
1668
1669 2007-10-28  Eric Seidel  <eric@webkit.org>
1670
1671         Reviewed by Maciej and Geoff, in unison.
1672
1673         * Scripts/run-webkit-tests: remove broken --svg option
1674
1675 2007-10-28  Darin Adler  <darin@apple.com>
1676
1677         Reviewed by Adam.
1678
1679         * Scripts/run-sunspider: Default to "Release" configuration rather than
1680         defaulting to the last configuration used as other scripts do. This can
1681         still be overriden on the command line with "--debug" if there's some
1682         reason to do so. Also fix a typo.
1683
1684         * Scripts/sunspider-compare-results: Fix a typo.
1685
1686 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
1687
1688         Reviewed by Adam.
1689
1690         - Implemented the WebScriptDebugListener functions now that the
1691         WebScriptDebugServer exists
1692
1693         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
1694         functions.
1695         (ServerConnection::currentFrame):
1696         (ServerConnection::didLoadMainResourceForDataSource):
1697         (ServerConnection::didParseSource):
1698         (ServerConnection::failedToParseSource):
1699         (ServerConnection::didEnterCallFrame):
1700         (ServerConnection::willExecuteStatement):
1701         (ServerConnection::willLeaveCallFrame):
1702         (ServerConnection::exceptionWasRaised):
1703         * Drosera/win/ServerConnection.h: Removed unused arguments from the
1704         members arguments list.
1705
1706 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
1707
1708         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
1709         <http://bugs.webkit.org/show_bug.cgi?id=15600>
1710
1711         Reviewed by Darin.
1712
1713         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
1714         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
1715         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
1716         file.  Note that it may also be used as a stand-alone script.
1717
1718         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
1719         * Scripts/resolve-ChangeLogs: Added.
1720         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
1721
1722 2007-10-26  Mark Rowe  <mrowe@apple.com>
1723
1724         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
1725         to the Qt port on the assumption that it was an implementation of the cross-platform
1726         LayoutTestController class.  It is not, so it did not need to be changed.
1727
1728         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
1729
1730 2007-10-25  Mark Rowe  <mrowe@apple.com>
1731
1732         Reviewed by Maciej.
1733
1734         Fix builds with code coverage enabled.
1735
1736         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
1737
1738 2007-10-25  Darin Adler  <darin@apple.com>
1739
1740         Reviewed by Mark Rowe.
1741
1742         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
1743         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
1744
1745 2007-10-25  Stephanie  <slewis@apple.com>
1746
1747         build Fix
1748
1749         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1750
1751 2007-10-25  Stephanie  <slewis@apple.com>
1752
1753         Reviewed by Mark Rowe, Adam Roben.
1754
1755         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
1756
1757         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
1758
1759 2007-10-25  Alice Liu  <alice.liu@apple.com>
1760
1761         Reviewed by Adam.
1762
1763         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
1764
1765         Moving destructor into platform-specific files
1766         * DumpRenderTree/LayoutTestController.cpp:
1767         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1768         (LayoutTestController::~LayoutTestController):
1769         * DumpRenderTree/qt/jsobjects.cpp:
1770         (LayoutTestController::~LayoutTestController):
1771
1772         LayoutTestController wasn't being destroyed
1773         * DumpRenderTree/win/DumpRenderTree.cpp:
1774         (runTest):
1775
1776         Added declspec
1777         * DumpRenderTree/win/EditingDelegate.h:
1778
1779         Reset certain values on the webview (or related delegate) that might 
1780         have changed while running a test
1781         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1782         (LayoutTestController::~LayoutTestController):
1783
1784 2007-10-25  Adam Roben  <aroben@apple.com>
1785
1786         Make sunspider-compare-results work with relative paths
1787
1788         Reviewed by Sam.
1789
1790         * Scripts/sunspider-compare-results: Convert arguments to absolute
1791         paths before we chdir.
1792
1793 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
1794
1795         Reviewed by Sam.
1796
1797         - Implemented server calls now the WebScriptDebugServer exists.
1798         - Also removed no longer needed call to initialize CG.
1799
1800         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
1801         automatically now.
1802         (_tWinMain):
1803         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
1804         (ServerConnection::ServerConnection):
1805         (ServerConnection::~ServerConnection):
1806         (ServerConnection::pause):
1807         (ServerConnection::resume):
1808         (ServerConnection::stepInto):
1809         (ServerConnection::applicationTerminating):
1810         (ServerConnection::serverConnectionDidDie):
1811         * Drosera/win/ServerConnection.h: Now uses the COM class.
1812
1813 2007-10-24  George Staikos  <staikos@kde.org>
1814
1815         Unbreak Qt build.
1816
1817         * Scripts/build-webkit:
1818
1819 2007-10-24  Adam Roben  <aroben@apple.com>
1820
1821         Remove now-unnecessary call to InitializeCoreGraphics
1822
1823         WebKit takes care of this now.
1824
1825         Reviewed by Ada.
1826
1827         * DumpRenderTree/win/DumpRenderTree.cpp:
1828         (initialize):
1829
1830 2007-10-24  Adam Roben  <aroben@apple.com>
1831
1832         Use WebTextRenderer in DRT
1833
1834         Reviewed by Ada.
1835
1836         * DumpRenderTree/win/DumpRenderTree.cpp:
1837         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
1838
1839 2007-10-24  Sven Herzberg  <sven@imendio.com>
1840
1841         Reviewed by Mark Rowe.
1842
1843         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
1844         Bug 15614: [GTK] qmake based backends don't build on OS X
1845
1846         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
1847         GTK backend on a Mac
1848         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
1849         isDarwin() to make it reusable in other places (like the workaround-
1850         for-prebuilt-qmake in build-webkit)
1851
1852 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1853
1854         Refurbish update-webkit script.
1855
1856         Reviewed by Adam.
1857
1858         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
1859         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
1860         multi-argument version of system() for flexibility and security.  Check for existence
1861         of Internal directory using -d test instead of -x.
1862
1863 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1864
1865         Minor clean-up of prepare-ChangeLog script.
1866
1867         Reviewed by Adam.
1868
1869         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
1870         of a string.  Use multi-argument versions of open() and system() for flexibility and
1871         security.
1872
1873 2007-10-24  Alice Liu  <alice.liu@apple.com>
1874
1875         Reviewed by Oliver.
1876
1877         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
1878
1879         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
1880         replay the saved events when we're still processing the mousedown that starts the drag
1881         * DumpRenderTree/win/EventSender.cpp:
1882         (doMouseMove):
1883         * DumpRenderTree/win/UIDelegate.cpp:
1884         (UIDelegate::doDragDrop):
1885
1886 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
1887
1888         Reviewed by Sam, Steve and Darin.
1889
1890         - Stubbed out the WebScriptDebugListener functionality in the Server
1891         Connection class to prepare it for receiving those callbacks.
1892         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
1893         and the ServerConnection to not need to be initialized with a server
1894         name, since that is not the way we connect to the WebKit server. 
1895
1896         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
1897         no exception.  Now it only loggs when there is an exception
1898         (DebuggerDocument::willExecuteStatement):
1899         (DebuggerDocument::didEnterCallFrame):
1900         (DebuggerDocument::willLeaveCallFrame):
1901         (DebuggerDocument::windowScriptObjectAvailable):
1902         (DebuggerDocument::callFunctionOnObject):
1903         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
1904         to be instantiated with a server's name.
1905         (DebuggerClient::DebuggerClient):
1906         (DebuggerClient::didFinishLoadForFrame):
1907         * Drosera/win/DebuggerClient.h: Removed unsued variable.
1908         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
1909         a server name.
1910         (Drosera::init):
1911         (Drosera::initServer):
1912         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
1913         instantiated with a server's name.
1914         * Drosera/win/ServerConnection.cpp: 
1915         (ServerConnection::ServerConnection): No longer needs a server name
1916         (ServerConnection::~ServerConnection): Only release the global context
1917         if there is one.
1918         (ServerConnection::serverConnectionDidDie): Stub for
1919         IWebScriptDebugListener
1920         (ServerConnection::QueryInterface): ditto
1921         (ServerConnection::AddRef): ditto
1922         (ServerConnection::Release): ditto
1923         (ServerConnection::didLoadMainResourceForDataSource): ditto
1924         (ServerConnection::didParseSource): ditto
1925         (ServerConnection::failedToParseSource): ditto
1926         (ServerConnection::didEnterCallFrame): ditto
1927         (ServerConnection::willExecuteStatement): ditto
1928         (ServerConnection::willLeaveCallFrame): ditto
1929         (ServerConnection::exceptionWasRaised): ditto
1930         * Drosera/win/ServerConnection.h: Stubbed out the
1931         IWebScriptDebugListener functions, and this class no longer needs to be
1932         instantiated with a server name.
1933
1934 2007-10-24  Lars Knoll  <lars@trolltech.com>
1935
1936         Reviewed by Simon.
1937
1938         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
1939
1940         * DumpRenderTree/qt/jsobjects.h:
1941
1942 2007-10-24  Lars Knoll  <lars@trolltech.com>
1943
1944         Reviewed by Simon.
1945
1946         add another command.
1947
1948         * DumpRenderTree/qt/jsobjects.cpp:
1949         (TextInputController::doCommand):
1950
1951 2007-10-24  Lars Knoll  <lars@trolltech.com>
1952
1953         Reviewed by Simon.
1954
1955         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
1956
1957         * DumpRenderTree/qt/jsobjects.cpp:
1958         (EventSender::keyDown):
1959         * DumpRenderTree/qt/jsobjects.h:
1960
1961 2007-10-24  Lars Knoll  <lars@trolltech.com>
1962
1963         Reviewed by Simon.
1964
1965         implement eventSender.keyDown().
1966
1967         * DumpRenderTree/qt/jsobjects.cpp:
1968         (EventSender::keyDown):
1969
1970 2007-10-24  Lars Knoll  <lars@trolltech.com>
1971
1972         Reviewed by Simon.
1973
1974         some smaller fixes to the editing support in DRT. Makes another few tests pass.
1975
1976         * DumpRenderTree/qt/DumpRenderTree.cpp:
1977         (WebCore::DumpRenderTree::DumpRenderTree):
1978         (WebCore::DumpRenderTree::initJSObjects):
1979         * DumpRenderTree/qt/jsobjects.cpp:
1980         (TextInputController::doCommand):
1981
1982 2007-10-24  Lars Knoll  <lars@trolltech.com>
1983
1984         Reviewed by Simon.
1985
1986         first bit of implementation for the textinputcontroller.
1987
1988         * DumpRenderTree/qt/DumpRenderTree.cpp:
1989         (WebCore::DumpRenderTree::DumpRenderTree):
1990         * DumpRenderTree/qt/DumpRenderTree.h:
1991         * DumpRenderTree/qt/jsobjects.cpp:
1992         (TextInputController::TextInputController):
1993         (TextInputController::doCommand):
1994         * DumpRenderTree/qt/jsobjects.h:
1995
1996 2007-10-24  Lars Knoll  <lars@trolltech.com>
1997
1998         Reviewed by Simon.
1999
2000         make the man webpage believe it has focus, so the editing tests work correctly.
2001
2002         * DumpRenderTree/qt/DumpRenderTree.cpp:
2003         (WebCore::DumpRenderTree::DumpRenderTree):
2004
2005 2007-10-24  Lars Knoll  <lars@trolltech.com>
2006
2007         Reviewed by Simon.
2008
2009         implement layoutTestController.dumpEditingCallbacks() correctly.
2010
2011         * DumpRenderTree/qt/DumpRenderTree.cpp:
2012         (WebCore::DumpRenderTree::DumpRenderTree):
2013         * DumpRenderTree/qt/jsobjects.cpp:
2014         (LayoutTestController::reset):
2015         (LayoutTestController::dumpEditingCallbacks):
2016
2017 2007-10-24  Lars Knoll  <lars@trolltech.com>
2018
2019         Reviewed by Simon.
2020
2021         Implement support for testing editing.
2022
2023         * DumpRenderTree/qt/DumpRenderTree.cpp:
2024         (WebCore::DumpRenderTree::DumpRenderTree):
2025
2026 2007-10-23  Sam Weinig  <sam@webkit.org>
2027
2028         Check for null BSTR that can be passed to the UIDelegate methods
2029         from javascript null and undefined.  Fixes a failing test case on
2030         Windows (fast/dom/Window/alert-undefined.html)
2031
2032         Reviewed by Eric Seidel.
2033
2034         * DumpRenderTree/win/UIDelegate.cpp:
2035         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2036         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2037         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2038         (UIDelegate::webViewAddMessageToConsole):
2039
2040 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2041
2042         Reviewed by Darin.
2043         
2044         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2045
2046         * Scripts/build-testkjs:
2047
2048 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2049
2050         Reviewed by Darin.
2051
2052         - add wrapper that finds the right copy of testkjs
2053         
2054         * Scripts/sunspider-compare-results: Added.
2055
2056 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2057
2058         Reviewed by Sam.
2059
2060         - After talking with Steve I now see that the WebKit server must be
2061         running for DCOM to create the distributed objects, which makes sense
2062         and currently WebKit only allows one instance to be running at a time
2063         which avoids accidentally connecting to the wrong server
2064         - In light of this I have removed the code for the attach box and
2065         NotificationServer and known server names, since they are all extranious
2066         now.
2067
2068         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2069         names.
2070         (_tWinMain): Uses init instead of initUI.
2071         (droseraWndProc): No longer creats an attach dialog box.
2072         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2073         it's not manditory to call init before doing COM stuff.
2074         (Drosera::init): calls initUI and will call attach when the
2075         functionality exists. 
2076         (Drosera::initUI): Has changed very little.
2077         (Drosera::attach): Changed the signature to reflect that we no longer
2078         need the dictionary of known server names.
2079         * Drosera/win/Drosera.h: Removed notification classes and known server
2080         names.  Also renamed and moved some functions.
2081         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2082         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2083         headers to the resources folder. 
2084         * Drosera/win/resource.h: Removed the Attach box.
2085
2086 2007-10-22  Adam Roben  <aroben@apple.com>
2087
2088         Windows build fix
2089
2090         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2091
2092 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2093
2094         - Removed a leak that was fixed.
2095
2096         * Scripts/run-webkit-tests:
2097
2098 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2099
2100         Reviewed by Darin.
2101
2102         - Changed the Client so that the DebuggerDocument now own the
2103         ServerConnection.  This simplifies ownership and cleanup. 
2104
2105         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2106         ServerConnection.
2107         (DebuggerClient::initWithServerName):
2108         (DebuggerClient::didFinishLoadForFrame):
2109         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
2110         ServerConnection.
2111         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2112         until after we have a server which we are attached to.
2113         (Drosera::initUI):
2114         (Drosera::attach):
2115         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2116         out previously.
2117
2118 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2119
2120         Reviewed by Nikolas.
2121
2122         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2123
2124         * Scripts/run-javascriptcore-tests:
2125
2126 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2127
2128         Reviewed by Nikolas.
2129
2130         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2131
2132         * Scripts/build-drosera:
2133         * Scripts/build-dumprendertree:
2134         * Scripts/build-testkjs:
2135         * Scripts/build-webkit:
2136         * Scripts/run-javascriptcore-tests:
2137         * Scripts/run-sunspider:
2138         * Scripts/run-webkit-tests:
2139         * Scripts/webkitdirs.pm:
2140
2141 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2142
2143         Reviewed by Mark Rowe.
2144         
2145         Fix for local database support after r26879
2146         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2147
2148         * Scripts/build-webkit:
2149
2150 2007-10-22  Holger Freyther  <zecke@selfish.org>
2151
2152         Reviewed by Simon Hausmann <hausmann@kde.org>.
2153
2154         - Do not build testkjs as an application bundle. This is
2155         needed for run-javascriptcore-tests on OSX.
2156         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2157         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2158         as we do not have -rpath on OSX.
2159
2160         * DumpRenderTree/qt/DumpRenderTree.pro:
2161         * Scripts/run-webkit-tests:
2162
2163 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2164
2165         Reviewed by aroben.
2166
2167         Fix support for Signed-off-by detection in prepare-ChangeLog
2168         --git-commit. The Signed-off-by tag does not appear in the header
2169         but usually at the end.
2170
2171         * Scripts/prepare-ChangeLog:
2172
2173 2007-10-21  Mark Rowe  <mrowe@apple.com>
2174
2175         Reviewed by Eric.
2176
2177         Fix run-javascriptcore-tests for Gtk.
2178
2179         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2180
2181 2007-10-20  Eric Seidel  <eric@webkit.org>
2182
2183         Reviewed by aroben.
2184
2185         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2186
2187 2007-10-20  Eric Seidel  <eric@webkit.org>
2188
2189         Reviewed by darin.
2190         
2191         Add improved argument handling to run-sunspider, including
2192         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2193         Also re-factor code into subroutines
2194
2195         * Scripts/build-dumprendertree: removed bogus comments
2196         * Scripts/build-testkjs: Added.
2197         * Scripts/run-javascriptcore-tests: use build-testkjs
2198         * Scripts/run-sunspider: improved argument handling, abstraction
2199         * Scripts/run-webkit-tests: improved abstraction
2200
2201 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2202
2203         Not reviewed, Windows build fix.
2204
2205         * DumpRenderTree/win/EventSender.cpp:
2206         (keyDownCallback):
2207
2208 2007-10-20  Darin Adler  <darin@apple.com>
2209
2210         Reviewed by Tim Hatcher.
2211
2212         - http://bugs.webkit.org/show_bug.cgi?id=15544
2213           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2214           not rely on Apple-specific key codes
2215
2216         * DumpRenderTree/mac/EventSendingController.mm:
2217         (-[EventSendingController keyDown:withModifiers:]):
2218         Added named key "rightArrow". Later we could have a whole table of these.
2219         Also tweaked modifiers code a little.
2220
2221         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2222
2223 2007-10-19  Darin Adler  <darin@apple.com>
2224
2225         Reviewed by Eric.
2226
2227         - http://bugs.webkit.org/show_bug.cgi?id=15566
2228           possible fix for leak seen in DumpRenderTree
2229
2230         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2231         Delete the item if it's not put on the queue, since the caller has
2232         no way of knowing that. Would be better to have the parameter type
2233         be auto_ptr to express the fact that we take ownership.
2234
2235         - unrelated change
2236
2237         * Drosera/mac/main.m: Add missing include.
2238
2239 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2240
2241         Reviewed by Adam.
2242
2243         - This change should be identical but for some reason was not working
2244         on my machine.
2245
2246         * Scripts/prepare-ChangeLog:
2247
2248 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2249
2250         Reviewed by Oliver and Tim.
2251
2252         - Made use of RetainPtr to avoid retain and release issues and moved the
2253         log function to DebuggerDocumentPlatform, which seems to be a more
2254         logical place for it to live.
2255         - Also moved knownServers from the ServerConnection to
2256         DebuggerApplication to match the Windows code and because it makes sense
2257         that a connection knows its own server but not all of them.
2258
2259         * Drosera/mac/DebuggerClient.h: Moved the log function to
2260           DebuggerDocumentPlatform.
2261         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2262           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2263           call for the server name up from the ServerConnection class.
2264         (-[DebuggerClient dealloc]):
2265         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2266           for the server name up from the ServerConnection.
2267         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2268         (DebuggerDocument::platformPause):
2269         (DebuggerDocument::platformResume):
2270         (DebuggerDocument::platformStepInto):
2271         (DebuggerDocument::platformEvaluateScript):
2272         (DebuggerDocument::getPlatformCurrentFunctionStack):
2273         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2274         (DebuggerDocument::platformValueForScopeVariableNamed):
2275         (DebuggerDocument::platformLog): Log directly from here. No need to call
2276           DebuggerClient.
2277         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2278           way I see it, a ServerConnection should only know about its connection
2279           and the group of all possible servers should be kept by the
2280           application.
2281         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2282           currentServerName, it makes sense that the connection should know that
2283           name.
2284         (-[ServerConnection currentServerName]):
2285
2286 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2287
2288         Reviewed by Adam.
2289
2290         - Integrated changes from mac drosera.  Recently I've encapsulated
2291         out the server connection object from the rest of Drosera because
2292         it is very platform dependent right now and RPC is not implemented on
2293         windows.  This functionality, of communicating with the WebKit server
2294         is the next area I will be focusing on in Windows.
2295
2296         - Other changes and cleanup were made to organize the code and add notes
2297         on which parts still need work.  Also some mac code is added and
2298         commented out, to act as pseudocode for the logic of those parts.
2299
2300         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2301           pointer.
2302         * Drosera/config.h: Added whitespace.
2303         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2304           these files got moved into Drosera.h/cpp
2305         * Drosera/win/DebuggerApplication.h: Removed.
2306         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
2307           happened here to better match the logic flow of the same code on the 
2308           mac side and to use the new ServerConnection class.
2309         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2310         (DebuggerClient::initWithServerName): Initializer that will set up the
2311           class to use a ServerConnection object.  This was necessary so I could
2312           create a DebuggerClient without having to initilaize it at
2313           construction.
2314         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2315           will be the UIDelegate and FrameLoadDelegate.
2316         (DebuggerClient::AddRef): For IUnknown.
2317         (DebuggerClient::Release): For IUnknown.
2318         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2319           this still needs to set the global context of the server, but
2320           IWebFrame does not have an accessor for the global context yet. 
2321         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2322           this is a pass through for the same function in the document.
2323         (DebuggerClient::didReceiveTitle): Unimplemented part of
2324           FrameLoadDelegate this would change the title of the window.
2325         (DebuggerClient::createWebViewWithRequest): Part of the
2326           FrameLoadDelegate.  This is about new windows via Window.open() and
2327           how their delegates are set.
2328         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2329           UIDelegate.  Just a debug function for printing messages.
2330         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2331           because the Client should be the UIDelegate and FrameLoadDelegate
2332           to match the delegates on mac.
2333         (DebuggerClient::webViewLoaded): Added accessor method.
2334         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2335           forgotten to add this file before.  This is where the platform
2336           dependent versions of the Documents functions live. Most of these are
2337           unimplemented because some piece of functionality does not exist on
2338           Windows yet.
2339         (DebuggerDocument::platformPause):
2340         (DebuggerDocument::platformResume):
2341         (DebuggerDocument::platformStepInto):
2342         (DebuggerDocument::platformEvaluateScript):
2343         (DebuggerDocument::getPlatformCurrentFunctionStack):
2344         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2345         (DebuggerDocument::platformValueForScopeVariableNamed):
2346         (DebuggerDocument::platformLog):
2347         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2348           responsibilities becaue they belong in the Client. Also I laid the
2349           groundwork for attaching Drosera to a WebKit process
2350         (attachWndProc): Now if a server is selected the Client becomes it's
2351           delegate.
2352         (Drosera::Drosera): Added the construction of the Client and dictionary
2353           of server names. 
2354         (Drosera::initUI): This is no longer the delegates, the Client is.
2355         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2356           state. 
2357         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2358           notification registration when it's possible to implement.
2359         (Drosera::serverLoaded): Ditto
2360         (Drosera::serverUnloaded): Ditto
2361         (Drosera::attach): Attach Drosera to the WebKit server.
2362         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2363         (Drosera::getInst): 
2364         (Drosera::setInst):
2365         (Drosera::knownServers):
2366         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2367           and added the ServerConnection.
2368         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2369         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2370           Most of the functions are completely unimlemented because they cannot
2371           connect with the WebKit server, because one does not exist on Windows
2372           yet.
2373         (ServerConnection::initWithServerName): 
2374         (ServerConnection::~ServerConnection):
2375         (ServerConnection::setGlobalContext):
2376         (ServerConnection::pause):
2377         (ServerConnection::resume):
2378         (ServerConnection::stepInto):
2379         (ServerConnection::switchToServerNamed):
2380         (ServerConnection::applicationTerminating):
2381         (ServerConnection::serverConnectionDidDie):
2382         (ServerConnection::currentFrame):
2383         * Drosera/win/ServerConnection.h: Added. Ditto.
2384         (ServerConnection::ServerConnection):
2385
2386 2007-10-19  Alice Liu  <alice.liu@apple.com>
2387
2388         Reviewed by Darin.
2389
2390         Fix for these broken layout tests on Windows:
2391         
2392         fast/forms/focus-selection-input.html
2393         fast/forms/focus-selection-textarea.html
2394         fast/forms/select-accesskey.html
2395         
2396         * DumpRenderTree/win/EventSender.cpp:
2397         (keyDownCallback):
2398         correct the VK code for alt key.
2399         
2400 2007-10-19  Eric Seidel  <eric@webkit.org>
2401
2402         Reviewed by Mark Rowe.
2403         
2404         Make the GtkLauncher code slightly more readable.
2405
2406         * GtkLauncher/main.cpp:
2407         (setupMainMenu): Added.
2408         (setupMainWindowUI): Added.
2409         (main):
2410
2411 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
2412
2413         Rubber stamped by Adam.
2414         
2415         - don't delay-load WebKit in DumpRenderTree.
2416
2417         * DumpRenderTree/win/DumpRenderTree.vcproj:
2418
2419 2007-10-18  Dan Bernstein  <mitz@apple.com>
2420
2421         Reviewed by Adam Roben.
2422
2423         - fix <rdar://problem/5313523>
2424         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2425
2426         * DumpRenderTree/mac/DumpRenderTree.mm:
2427         (dump): Changed to use _responseMIMEType.
2428
2429 2007-10-17  Adam Roben  <aroben@apple.com>
2430
2431         Make it possible to have Windows-specific tests and results
2432
2433         When searching for tests to run and the Skipped file, we will only
2434         look in platform/win and the cross-platform directory. When looking
2435         for expected results, we will look in platform/win, then
2436         platform/mac-leopard, then platform/mac, then finally the
2437         cross-platform directory.
2438
2439         Reviewed by Sam.
2440
2441         * Scripts/run-webkit-tests:
2442         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
2443         searching in the cross-platform directory.
2444         (sub buildPlatformHierarchy): Removed some unneeded calls to
2445         dirname/basename.
2446
2447 2007-10-17  Adam Roben  <aroben@apple.com>
2448
2449         Add back the call to register WebKit that we had before WebKitInitializer existed
2450
2451         This is needed to ensure that the right WebKit is used when
2452         instantiating COM objects.
2453
2454         Reviewed by Oliver.
2455
2456         * DumpRenderTree/win/debug_internal.vsprops: Define
2457         DEBUG_WEBKIT_HAS_SUFFIX.
2458         * DumpRenderTree/win/DumpRenderTree.cpp:
2459         (initialize):
2460
2461 2007-10-17  Adam Roben  <aroben@apple.com>
2462
2463         Import File::Basename in webkitdirs since we use it
2464
2465         * Scripts/webkitdirs.pm:
2466
2467 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
2468
2469         - Updated the tiger leaks list to make the internal bots green.
2470
2471         * Scripts/run-webkit-tests:
2472
2473 2007-10-17  Adam Roben  <aroben@apple.com>
2474
2475         Build fix for VC++ Express
2476
2477         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
2478         and ole32.lib.
2479
2480 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2481
2482         Reviewed by Sam.
2483
2484         - Minor mac improvements based on observations I made while implementing the
2485         Windows code.
2486
2487         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
2488         then hand it to the Client who will retain it, it should just be the client who
2489         creates and owns the server.
2490         (-[DebuggerApplication attach:]):
2491         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
2492         * Drosera/mac/DebuggerClient.mm: Creates the server.
2493         (-[DebuggerClient initWithServerName:]):
2494         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
2495         can instead forward declare what it needs.
2496
2497 2007-10-16  Darin Adler  <darin@apple.com>
2498
2499         Reviewed by Geoff Garen.
2500
2501         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
2502         want to turn failing tests into platform-specific test results. Also did a
2503         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
2504         would take the type of results into account only some of the time.
2505
2506 2007-10-16  Adam Roben  <aroben@apple.com>
2507
2508         Add a new nightly launcher script for Windows
2509
2510         This new script is for versions of Safari that don't delay-load
2511         WebKit. I had to make FindSafari be able to print out the nightly
2512         launcher script on stdout because Windows shell scripts can't capture
2513         the output from a command into an environment variable.
2514
2515         Reviewed by Steve.
2516
2517         * FindSafari/FindSafari.cpp:
2518         (_tmain): Added /printSafariLauncher option.
2519         * Scripts/run-webkit-nightly.cmd: Added.
2520
2521 2007-10-16  Adam Roben  <aroben@apple.com>
2522
2523         Replace WebKitInitializer with FindSafari
2524
2525         We now rely on setting the PATH environment variable to tell Windows
2526         where to find WebKit and its dependencies (similar to
2527         DYLD_FRAMEWORK_PATH on Mac).
2528
2529         This change also make DumpRenderTree no longer delay-load WebKit.
2530
2531         Reviewed by Sam.
2532
2533         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
2534         FindSafari.
2535         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
2536         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
2537         WebKitInitializer, don't delay-load WebKit.
2538         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
2539         * Scripts/run-webkit-tests: Ditto.
2540         * Scripts/webkitdirs.pm:
2541         (sub setPathForRunningWebKitApp): Added.
2542         * WebKitInitializer/WebKitInitializer.cpp: Removed.
2543         * WebKitInitializer/WebKitInitializer.h: Removed.
2544         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
2545         * WebKitInitializer/debug.vsprops: Removed.
2546         * WebKitInitializer/debug_internal.vsprops: Removed.
2547         * WebKitInitializer/release.vsprops: Removed.
2548
2549 2007-10-16  Adam Roben  <aroben@apple.com>
2550
2551         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
2552
2553         http://bugs.webkit.org/show_bug.cgi?id=15532
2554
2555         FindSafari simply prints the location of an installed Safari.exe on
2556         stdout.
2557
2558         Reviewed by Darin.
2559
2560         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
2561         (getStringValue):
2562         (getWebViewCLSID):
2563         (getInstalledWebKitDirectory):
2564         (_tmain):
2565         * FindSafari/FindSafari.vcproj: Added.
2566         * Scripts/webkitdirs.pm:
2567         (sub installedSafariPath): Added. Calls FindSafari on Windows.
2568
2569 2007-10-16  Adam Roben  <aroben@apple.com>
2570
2571         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
2572
2573         Reviewed by Kevin McCullough.
2574
2575         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
2576         when referring to WebKit.dll.
2577         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
2578         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
2579         * DumpRenderTree/win/release.vsprops: Ditto.
2580         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
2581         never have a _debug suffix on WebKit.dll.
2582         * WebKitInitializer/WebKitInitializer.cpp:
2583         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
2584         specified.
2585         * WebKitInitializer/debug_internal.vsprops: Added
2586         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
2587
2588 2007-10-16  Darin Adler  <darin@apple.com>
2589
2590         Reviewed by Adele.
2591
2592         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2593         Remove now-unneeded control/alt key hack; the tests have been updated.
2594
2595 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2596
2597         - Updated leaks list because our internal bot upgraded it's version of leopard and 
2598         one of the leaks was fixed between that revision and the bot's previous version of
2599         leopard.
2600
2601         * Scripts/run-webkit-tests:
2602
2603 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
2604
2605         Reviewed by Tim.
2606
2607         - I encapsulated out the server connecton functionality because it is a specific part
2608         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
2609         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
2610         Windows.  So the majority of this patch is moving preexisting functionality.
2611
2612         - Also I removed the prefix header and changed to use config.h because it is more
2613         standard on how we use config.h in windows and it didn't make much sense to keep
2614         the prefix header and the config.h
2615
2616         * Drosera/DebuggerDocument.cpp:
2617         (DebuggerDocument::DebuggerDocument):
2618         * Drosera/DebuggerDocument.h:
2619         * Drosera/config.h:
2620         * Drosera/mac/DebuggerApplication.mm:
2621         (-[DebuggerApplication attach:]):
2622         * Drosera/mac/DebuggerClient.h:
2623         * Drosera/mac/DebuggerClient.mm:
2624         (-[DebuggerClient initWithServerConnection:]):
2625         (-[DebuggerClient dealloc]):
2626         (-[DebuggerClient windowDidLoad]):
2627         (-[DebuggerClient windowWillClose:]):
2628         (-[DebuggerClient webView:didFinishLoadForFrame:]):
2629         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
2630         * Drosera/mac/DebuggerDocumentPlatform.mm:
2631         (DebuggerDocument::platformPause):
2632         (DebuggerDocument::platformResume):
2633         (DebuggerDocument::platformStepInto):
2634         (DebuggerDocument::platformEvaluateScript):
2635         (DebuggerDocument::getPlatformCurrentFunctionStack):
2636         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2637         (DebuggerDocument::platformValueForScopeVariableNamed):
2638         (DebuggerDocument::platformLog):
2639         * Drosera/mac/Drosera.pch: Removed.
2640         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2641         * Drosera/mac/ServerConnection.h: Added.
2642         * Drosera/mac/ServerConnection.mm: Added.
2643         (-[ServerConnection initWithServerName:]):
2644         (-[ServerConnection dealloc]):
2645         (-[ServerConnection setGlobalContext:]):
2646         (-[ServerConnection pause]):
2647         (-[ServerConnection resume]):
2648         (-[ServerConnection stepInto]):
2649         (-[ServerConnection switchToServerNamed:]):
2650         (-[ServerConnection applicationTerminating:]):
2651         (-[ServerConnection serverConnectionDidDie:]):
2652         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2653         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2654         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
2655         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
2656         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
2657         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
2658         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2659         (-[ServerConnection currentFrame]):
2660         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
2661         (-[ServerConnection knownServers]):
2662
2663 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
2664
2665         Reviewed by Eric.
2666
2667         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
2668           Script to automatically search nightly builds for regressions (bisect-builds)
2669
2670         * Scripts/bisect-builds: Added.
2671
2672 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
2673
2674         Reviewed by Darin.
2675
2676         - New JavaScript benchmark
2677         http://bugs.webkit.org/show_bug.cgi?id=15515
2678
2679         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
2680         current development or release build of JavaScriptCore.
2681
2682 2007-10-15  Mark Rowe  <mrowe@apple.com>
2683
2684         Reviewed by Sam.
2685
2686         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
2687
2688         * Scripts/webkitdirs.pm:
2689         - Change checkArgv to remove the options from @ARGV to prevent
2690         them from interfering with further option processing.
2691         - Fix logic error in determineIsQt that would prevent it from bailing out early.
2692         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
2693         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
2694         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
2695
2696 2007-10-15  Darin Adler  <darin@apple.com>
2697
2698         Reviewed by Sam.
2699
2700         - added logging of window.prompt and window.confirm
2701
2702         * DumpRenderTree/mac/UIDelegate.mm:
2703         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2704         Implement the recommended delegate rather than the deprecated one.
2705         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
2706         Added.
2707         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2708         Added.
2709
2710         * DumpRenderTree/win/UIDelegate.h:
2711         * DumpRenderTree/win/UIDelegate.cpp:
2712         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
2713         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
2714         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
2715         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
2716
2717 2007-10-15  Alice Liu  <alice.liu@apple.com>
2718
2719         Reviewed by Sam Weinig.
2720
2721         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
2722
2723         * DumpRenderTree/win/DumpRenderTree.cpp:
2724         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
2725         (main): allocate the global policy delegate for DRT's custom use
2726         * DumpRenderTree/win/DumpRenderTree.vcproj:
2727         Adding files to project
2728         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
2729         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2730         (LayoutTestController::setCustomPolicyDelegate):
2731         set the webview's policy delegate to DRT's custom one if the test requests it.
2732         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
2733         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
2734         (PolicyDelegate::PolicyDelegate):
2735         (PolicyDelegate::QueryInterface):
2736         (PolicyDelegate::AddRef):
2737         (PolicyDelegate::Release):
2738         (PolicyDelegate::decidePolicyForNavigationAction):
2739         * DumpRenderTree/win/PolicyDelegate.h: Added.
2740         (PolicyDelegate::decidePolicyForNewWindowAction):
2741         (PolicyDelegate::decidePolicyForMIMEType):
2742         (PolicyDelegate::unableToImplementPolicyWithError):
2743
2744 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
2745
2746         Reviewed by Mark.
2747
2748         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
2749         when querying for QMAKE_MKSPECS.
2750
2751 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
2752
2753         Reviewed by Adam Roben.
2754         
2755         Fix run-webkit-tests is too greedy calculating platform hierarchy
2756         http://bugs.webkit.org/show_bug.cgi?id=15465
2757         
2758         Fix run-webkit-tests being too greedy in trying to split the platform name up
2759         causing it to try and find tests in every directory above the first "-" in the
2760         path to the LayoutTests
2761
2762         * Scripts/run-webkit-tests:
2763
2764 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
2765
2766         Reviewed by Darin.
2767
2768         http://bugs.webkit.org/show_bug.cgi?id=15006
2769         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
2770         to reduce code duplication.
2771
2772         * Scripts/build-webkit:
2773         * Scripts/webkitdirs.pm:
2774         buildQMakeProject() renamed to buildQMakeQtProject().
2775         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
2776         unused $colorize has been removed.
2777
2778 === Start merge of feature-branch 2007-10-12 ===
2779
2780 2007-10-08  Eric Seidel  <eric@webkit.org>
2781
2782         Reviewed by Mark Rowe.
2783
2784         * Scripts/build-webkit: add --help, remove unused --color
2785
2786 2007-10-07  Eric Seidel  <eric@webkit.org>
2787
2788         Reviewed by darin.
2789
2790         * Drosera/mac/DebuggerDocumentPlatform.mm:
2791         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
2792
2793 2007-10-03  Rob Buis  <buis@kde.org>
2794
2795         Reviewed by Olliej.
2796
2797         Adapt to changed location of Ahem font.
2798
2799         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2800
2801 2007-10-02  Eric Seidel  <eric@webkit.org>
2802
2803         Reviewed by Adam Roben.
2804         
2805         Make pixel tests more useful!
2806         Finally fix the image diff 0.00% mystery problem
2807         Highlight any image differences in the image diff.
2808         Add a link from image diffs back to original test file.
2809
2810         * DumpRenderTree/mac/ImageDiff.m:
2811         (compareImages): highlight any differences
2812         (computePercentageDifferent): round to two decimal places
2813         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
2814
2815 2007-10-02  Eric Seidel  <eric@webkit.org>
2816
2817         Reviewed by Alexey Proskuryakov.
2818
2819         * Scripts/run-webkit-tests: print the % image difference on main results page
2820
2821 2007-10-02  Mark Rowe  <mrowe@apple.com>
2822
2823         Reviewed by Oliver.
2824
2825         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2826
2827         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2828         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2829
2830 2007-10-01  Mark Rowe  <mrowe@apple.com>
2831
2832         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2833
2834 2007-09-25  Eric Seidel  <eric@webkit.org>
2835
2836         Reviewed by Mark Rowe.
2837         
2838         DerivedSources.make was finding "ENABLE_SVG" in the string
2839         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
2840         quite correctly.
2841
2842         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
2843
2844 2007-09-25  Mark Rowe  <mrowe@apple.com>
2845
2846         Rubber-stamped by Eric.
2847
2848         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2849         This makes it possible to automate nightly builds for the feature-branch.
2850
2851 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
2852
2853         Rubber stamped by Mark.
2854
2855         Enable svg experimental features as default here in feature-branch.
2856
2857         * Scripts/build-webkit:
2858
2859 2007-06-29  Antti Koivisto  <antti@apple.com>
2860
2861         Reviewed by Weinig.
2862         
2863         Add VIDEO flag for timed media features
2864
2865         * Scripts/build-webkit
2866         
2867 === End merge of feature-branch 2007-10-12 ===
2868
2869 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2870
2871         Reviewed by Darin.
2872
2873         - Updated rational for the leaks list to be more clear.
2874
2875         * Scripts/run-webkit-tests:
2876
2877 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2878
2879         Rubber Stamp by Sam.
2880
2881         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
2882         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
2883
2884         * Scripts/run-webkit-tests:
2885
2886 2007-10-10  Simon Hausmann  <hausmann@kde.org>
2887
2888         Reviewed by Lars.
2889
2890         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
2891         includes are needed for INT_MAX, std::auto_ptr and the like.
2892
2893         * DumpRenderTree/qt/main.cpp:
2894
2895 2007-10-09  Lars Knoll  <lars@trolltech.com>
2896
2897         Reviewed by Simon.
2898
2899         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
2900
2901         * DumpRenderTree/qt/jsobjects.cpp:
2902         (LayoutTestController::encodeHostName):
2903         (LayoutTestController::decodeHostName):
2904         * DumpRenderTree/qt/jsobjects.h:
2905
2906 2007-10-09  Lars Knoll  <lars@trolltech.com>
2907
2908         Reviewed by Simon.
2909
2910         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
2911
2912         * DumpRenderTree/qt/DumpRenderTree.cpp:
2913         (WebCore::WebPage::createFrame):
2914         (WebCore::DumpRenderTree::DumpRenderTree):
2915         (WebCore::DumpRenderTree::titleChanged):
2916         * DumpRenderTree/qt/DumpRenderTree.h:
2917         * DumpRenderTree/qt/jsobjects.cpp:
2918         (LayoutTestController::reset):
2919         * DumpRenderTree/qt/jsobjects.h:
2920
2921 2007-10-09  Lars Knoll  <lars@trolltech.com>
2922
2923         Reviewed by Simon.
2924
2925         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
2926
2927         * DumpRenderTree/qt/DumpRenderTree.h:
2928         * DumpRenderTree/qt/jsobjects.cpp:
2929         (LayoutTestController::clearBackForwardList):
2930         * DumpRenderTree/qt/jsobjects.h:
2931
2932 2007-10-09  Lars Knoll  <lars@trolltech.com>
2933
2934         Reviewed by Simon.
2935
2936         make --git-reviewer work again.
2937
2938         * Scripts/prepare-ChangeLog:
2939
2940 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
2941
2942         Rubber stamped by Eric.
2943
2944         Connect to the "hovering-over-link" signal emitted by WebKitPage and
2945         show the current link inside the statusbar.
2946         This shows how to make use of this signal and allows to easily test
2947         http://bugs.webkit.org/show_bug.cgi?id=15299.
2948
2949         * GtkLauncher/main.cpp:
2950         (hoveringOverLink):
2951         (main):
2952
2953 2007-10-05  Lars Knoll  <lars@trolltech.com>
2954
2955         add proper error messages to the FrameLoaderClient.
2956         Implement ChromeClientQt::closeWindowSoon and
2957         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
2958         Some fixes in DRT to make it work correctly with multiple windows.
2959
2960         Reviewed by Maciej.
2961
2962         * DumpRenderTree/qt/DumpRenderTree.cpp:
2963         (WebCore::DumpRenderTree::DumpRenderTree):
2964         (WebCore::DumpRenderTree::createWindow):
2965         (WebCore::DumpRenderTree::windowCount):
2966         * DumpRenderTree/qt/DumpRenderTree.h:
2967         * DumpRenderTree/qt/jsobjects.cpp:
2968         (LayoutTestController::maybeDump):
2969         (LayoutTestController::windowCount):
2970         * DumpRenderTree/qt/jsobjects.h:
2971
2972 2007-10-05  Lars Knoll  <lars@trolltech.com>
2973
2974         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
2975         Add support for layoutTextController.setCanOpenWindows() to DRT
2976         fixing another 2 test cases in fast/dom/Window.
2977
2978         Reviewed by Maciej.
2979
2980         * DumpRenderTree/qt/DumpRenderTree.cpp:
2981         (WebCore::WebPage::WebPage):
2982         (WebCore::WebPage::createWindow):
2983         (WebCore::DumpRenderTree::resetJSObjects):
2984         (WebCore::DumpRenderTree::createWindow):
2985         * DumpRenderTree/qt/DumpRenderTree.h:
2986         * DumpRenderTree/qt/DumpRenderTree.pro:
2987         * DumpRenderTree/qt/jsobjects.cpp:
2988         (LayoutTestController::LayoutTestController):
2989         (LayoutTestController::reset):
2990         * DumpRenderTree/qt/jsobjects.h:
2991         * DumpRenderTree/qt/main.cpp:
2992         * DumpRenderTree/qt/testplugin.cpp: Added.
2993         * DumpRenderTree/qt/testplugin.h: Added.
2994
2995 2007-10-04  Sam Weinig  <sam@webkit.org>
2996
2997         Rubber stamped by Adam.
2998
2999         Remove empty directories.
3000
3001         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
3002         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
3003
3004 2007-10-03  Darin Adler  <darin@apple.com>
3005
3006         Reviewed by Adam.
3007
3008         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
3009         we find the internal libraries in the libraries directory. This
3010         is helpful for Safari team engineers at Apple.
3011
3012 2007-10-03  Adam Roben  <aroben@apple.com>
3013
3014         Update the location of AHEM___.TTF after r25968
3015
3016         Reviewed by Sam.
3017
3018         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3019
3020 2007-10-03  Alp Toker  <alp@atoker.com>
3021
3022         Reviewed by Adam.
3023
3024         http://bugs.webkit.org/show_bug.cgi?id=14726
3025         [gtk] API design. Mapping the WebView delegates to signals.
3026
3027         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
3028
3029         * GtkLauncher/main.cpp:
3030         (goToURLBarText):
3031         (titleChanged):
3032         (progressChanged):
3033         (menuMainBackCallback):
3034         (menuMainForwardCallback):
3035         (main):
3036
3037 2007-10-03  Lars Knoll  <lars@trolltech.com>
3038
3039         Reviewed by Rob.
3040
3041         This fixes --strict mode in run-webkit-tests again after
3042         the platform dependent test results have been moved.
3043
3044         * Scripts/run-webkit-tests:
3045
3046 2007-10-03  Lars Knoll  <lars@trolltech.com>
3047
3048         Reviewed by bdash.
3049
3050         remove the hack in run-webkit-tests that forced text only test
3051         to be taken from the platform independent dir. It was only left
3052         there from early days.
3053         
3054         Remove platform dependent results for tests that are text only nowadays,
3055         and add one platform dependent result for a text only test that requires it.
3056
3057         * Scripts/run-webkit-tests:
3058
3059 2007-10-03  Lars Knoll  <lars@trolltech.com>
3060
3061         Reviewed by olliej.
3062
3063         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
3064
3065         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
3066         (WebCore::WebFrame::WebFrame):
3067         (WebCore::WebPage::WebPage):
3068         (WebCore::WebPage::createFrame):
3069         (WebCore::WebPage::javaScriptAlert):
3070         (WebCore::WebPage::javaScriptConsoleMessage):
3071         (WebCore::DumpRenderTree::DumpRenderTree):
3072         (WebCore::DumpRenderTree::~DumpRenderTree):
3073         (WebCore::DumpRenderTree::open):
3074         (WebCore::DumpRenderTree::readStdin):
3075         (WebCore::DumpRenderTree::resetJSObjects):
3076         (WebCore::DumpRenderTree::initJSObjects):
3077         (WebCore::DumpRenderTree::dumpFramesAsText):
3078         (WebCore::DumpRenderTree::dump):
3079         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
3080         (WebCore::DumpRenderTree::layoutTestController):
3081         (WebCore::DumpRenderTree::eventSender):
3082         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
3083         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
3084         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
3085         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
3086         (HackWebFrame::mousePressEvent):
3087         (HackWebFrame::mouseReleaseEvent):
3088         (HackWebFrame::mouseMoveEvent):
3089         (HackWebFrame::HackWebFrame):
3090         (HackWebFrame::~HackWebFrame):
3091         (LayoutTestController::LayoutTestController):
3092         (LayoutTestController::reset):
3093         (LayoutTestController::maybeDump):
3094         (LayoutTestController::waitUntilDone):
3095         (LayoutTestController::notifyDone):
3096         (LayoutTestController::dumpEditingCallbacks):
3097         (LayoutTestController::queueReload):
3098         (LayoutTestController::provisionalLoad):
3099         (LayoutTestController::timerEvent):
3100         (EventSender::EventSender):
3101         (EventSender::mouseDown):
3102         (EventSender::mouseUp):
3103         (EventSender::mouseMoveTo):
3104         (EventSender::leapForward):
3105         (EventSender::keyDown):
3106         (EventSender::frameUnderMouse):
3107         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
3108         (LayoutTestController::isLoading):
3109         (LayoutTestController::setLoading):
3110         (LayoutTestController::shouldDumpAsText):
3111         (LayoutTestController::shouldDumpChildrenAsText):
3112         (LayoutTestController::shouldWaitUntilDone):
3113         (LayoutTestController::dumpAsText):
3114         (LayoutTestController::dumpChildFramesAsText):
3115         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
3116         (messageHandler):
3117         (crashHandler):
3118         (main):
3119         * Scripts/run-webkit-tests:
3120
3121 2007-10-03  Mark Rowe  <mrowe@apple.com>
3122
3123         Reviewed by Alp Toker.
3124
3125         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
3126         should take precedence over QTDIR when determining which port we are working with.
3127
3128         * Scripts/webkitdirs.pm: 
3129
3130 2007-10-02  Adam Roben  <aroben@apple.com>
3131
3132         Add keychain to the list of default packages to install
3133
3134         Rubberstamped by Sam.
3135
3136         * CygwinDownloader/cygwin-downloader.py:
3137         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3138
3139 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
3140
3141         Reviewed by Adam.
3142
3143         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
3144         Also makes WebCore regression test case logic work when using git.
3145
3146         * Scripts/prepare-ChangeLog:
3147         (reviewerAndDescriptionForGitCommit): Added.
3148
3149 2007-10-02  Lars Knoll  <lars@trolltech.com>
3150
3151         Reviewed by bdash.
3152
3153         Add API to retrieve the frame name from QWebFrame.
3154         Implement support for DRT::dumpChildrenAsText.
3155
3156         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3157         (WebCore::DumpRenderTree::dumpFramesAsText):
3158         (WebCore::DumpRenderTree::dump):
3159         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3160         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3161         (LayoutTestController::LayoutTestController):
3162         (LayoutTestController::reset):
3163         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3164
3165 2007-10-02  Lars Knoll  <lars@trolltech.com>
3166
3167         Reviewed by bdash.
3168
3169         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
3170
3171         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3172         (WebCore::DumpRenderTree::readStdin):
3173
3174 2007-10-02  Mark Rowe  <mrowe@apple.com>
3175
3176         Reviewed by Oliver.
3177
3178         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3179
3180         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3181         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3182
3183 2007-10-02  Mark Rowe  <mrowe@apple.com>
3184
3185         Rubber-stamped by Maciej.
3186
3187         Configuration changes from build.webkit.org.  The major change is refactoring to work
3188         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
3189         last few weeks.
3190
3191         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3192         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
3193         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
3194         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
3195         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
3196         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
3197         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
3198         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
3199
3200 2007-10-02  Lars Knoll  <lars@trolltech.com>
3201
3202         Reviewed by Maciej.
3203
3204         Add support for eventSender.mouseMove to DRT.
3205         Fixes fast/css/hover-affects-child.html
3206
3207         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3208         (EventSender::mouseMoveTo):
3209
3210 2007-10-01  Mark Rowe  <mrowe@apple.com>
3211
3212         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3213
3214 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
3215
3216         Reviewed by Hyatt.
3217
3218         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
3219
3220         * Scripts/svn-apply:
3221         (gitdiff2svndiff): Ignore lines beginning with "new file".
3222         * Scripts/svn-unapply:
3223         (gitdiff2svndiff): Ditto.
3224
3225 2007-09-30  George Staikos  <staikos@kde.org>
3226
3227         Qt build fix (Mac OS X specific)
3228
3229         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
3230
3231 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
3232
3233         Reviewed by Mark.
3234
3235         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
3236         Remove Bakefiles from svn.
3237
3238         * GtkLauncher/Bakefiles.bkgen: Removed.
3239         * GtkLauncher/ENV: Removed.
3240         * GtkLauncher/gdklauncher.bkl: Removed.
3241         * GtkLauncher/mk: Removed.
3242         * Scripts/regenerate-makefiles: Removed.
3243
3244 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
3245
3246         Reviewed by John.
3247
3248         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
3249
3250         * Scripts/run-webkit-tests:
3251
3252 2007-09-26  Adam Roben  <aroben@apple.com>
3253
3254         Make not finding an installed WebKit non-fatal
3255
3256         What really matters is that we are able to load WebKit and its
3257         dependencies, not whether we think we've found an installed WebKit.
3258
3259         Reviewed by Sam.
3260
3261         * WebKitInitializer/WebKitInitializer.cpp:
3262         (getWebViewCLSID): Use new LOG_WARNING macro.
3263         (getInstalledWebKitDirectory): Ditto.
3264         (initializeWebKit): Don't die if we didn't find an installed WebKit,
3265         and use new macros.
3266         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
3267
3268 2007-09-26  Adam Roben  <aroben@apple.com>
3269
3270         Committed this file before saving it
3271
3272         * WebKitInitializer/debug_internal.vsprops:
3273
3274 2007-09-26  Adam Roben  <aroben@apple.com>
3275
3276         Load WebKit and its dependencies manually so they come from DllDirectory
3277
3278         I had to change WebKitInitializer to use malloc/free instead of
3279         new/delete to avoid pulling in WebKit (and its dependencies) early
3280         through use of fastMalloc.
3281
3282         Reviewed by Oliver.
3283
3284         * WebKitInitializer/WebKitInitializer.cpp:
3285         (getStringValue): Changed to use malloc/free.
3286         (getInstalledWebKitDirectory): Ditto.
3287         (initializeWebKit): Call SetDllDirectory first, then load all of
3288         WebKit's dependencies manually, finally followed by WebKit itself.
3289         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
3290         configuration to match our other projects.
3291         * WebKitInitializer/debug_internal.vsprops: Added.
3292
3293 2007-09-25  Adam Roben  <aroben@apple.com>
3294
3295         Actually define DEBUG/NDEBUG so that we load WebKit correctly
3296
3297         Rubberstamped by Sam.
3298
3299         * WebKitInitializer/WebKitInitializer.vcproj:
3300
3301 2007-09-25  Adam Roben  <aroben@apple.com>
3302
3303         Make DumpRenderTree delay-load its dependencies
3304
3305         This lets WebKitInitializer re-route the dependencies to be loaded out
3306         of the Safari installation directory.
3307
3308         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
3309         same thing), since we can't import the kCFAllocatorDefault symbol when
3310         delay-loading CoreFoundation.dll.
3311
3312         Rubberstamped by Sam.
3313
3314         * DumpRenderTree/win/DumpRenderTree.cpp:
3315         (runTest):
3316         (javaScriptThreads):
3317         * DumpRenderTree/win/DumpRenderTree.vcproj:
3318         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3319         (LayoutTestController::setWaitToDump):
3320
3321 2007-09-25  Adam Roben  <aroben@apple.com>
3322
3323         Pull ole32.lib into WebKitInitializer
3324
3325         Rubberstamped by Sam.
3326
3327         * WebKitInitializer/WebKitInitializer.vcproj:
3328
3329 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3330
3331         Reviewed by Adam.
3332
3333         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
3334           LGPL'ed files contain incorrect FSF address
3335
3336         * Drosera/config.h:
3337
3338 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
3339
3340         Reviewed by Adam.
3341
3342         Make svn-apply and svn-unapply work with git-diff formatted patches.
3343
3344         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
3345         (gitdiff2svndiff): Added.
3346         * Scripts/svn-unapply: Ditto.
3347         (gitdiff2svndiff): Added.
3348
3349 2007-09-25  Adam Roben  <aroben@apple.com>
3350
3351         Pull advapi32.lib into WebKitInitializer
3352
3353         This is needed to get the registry functions we use.
3354
3355         Rubberstamped by Sam.
3356
3357         * WebKitInitializer/WebKitInitializer.vcproj:
3358
3359 2007-09-25  Adam Roben  <aroben@apple.com>
3360
3361         Add python and rsync to cygwin-downloader
3362
3363         Our build slaves need this, and it can't hurt for everyone else to
3364         have it, too.
3365
3366         Reviewed by Sam.
3367
3368         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
3369         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
3370
3371 2007-09-25  Adam Roben  <aroben@apple.com>
3372
3373         Add WebKitInitializer and use it in DumpRenderTree
3374
3375         WebKitInitializer is a static library that has one function,
3376         initializeWebKit(). This registers WebKit and sets up the DLL search
3377         path so that WebKit's dependencies that are installed with Safari can
3378         be found.
3379
3380         Reviewed by Sam.
3381
3382         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
3383         DumpRenderTree depend on it.
3384         * DumpRenderTree/win/DumpRenderTree.cpp:
3385         (initialize): Call initializeWebKit.
3386         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
3387         WebKitInitializer.lib.
3388         * WebKitInitializer/WebKitInitializer.cpp: Added.
3389         (getStringValue):
3390         (getWebViewCLSID):
3391         (getInstalledWebKitDirectory):
3392         (initializeWebKit):
3393         * WebKitInitializer/WebKitInitializer.h: Added.
3394         * WebKitInitializer/WebKitInitializer.vcproj: Added.
3395         * WebKitInitializer/debug.vsprops: Added.
3396         * WebKitInitializer/release.vsprops: Added.
3397
3398 2007-09-25  Adam Roben  <aroben@apple.com>
3399
3400         Make run-webkit-tests respect set-webkit-configuration
3401
3402         Reviewed by Sam.
3403
3404         * Scripts/run-webkit-tests: Initialize $configuration to whatever
3405         set-webkit-configuration was last set to.
3406
3407 2007-09-25  Mark Rowe  <mrowe@apple.com>
3408
3409         Rubber-stamped by Eric.
3410
3411         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3412         This makes it possible to automate nightly builds for the feature-branch.
3413
3414 2007-09-25  Adam Roben  <aroben@apple.com>
3415
3416         A couple of fixes/enhancements to update-webkit-*-libs
3417
3418         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
3419         to tell update-webkit-support-libraries where it should find the
3420         WebKitSupportLibrary.zip file you downloaded.
3421
3422         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
3423         Windows-style path.
3424
3425         Reviewed by Sam.
3426
3427         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
3428         to $auxiliaryLibsURL and removed an irrelevant comment.
3429         * Scripts/update-webkit-support-libs:
3430
3431 2007-09-25  Adam Treat  <treat@kde.org>
3432
3433         Reviewed by Simon and Lars.
3434
3435         Refactors and cleans up Qt DRT member variable names, member variable
3436         initialization, style fixes and general code cleanup.
3437
3438         Adds queueReload slot to LayoutTestController that some tests require.
3439
3440         Subclasses QWebFrame to make sure that all frames have an associated
3441         LayoutTestController JS window object.
3442
3443         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
3444         aren't dumped twice.
3445
3446         EOF fixes.
3447
3448         Together, this patch fixes some 20+ layout tests in QtWebKit.
3449
3450         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
3451         (WebCore::WebFrame::WebFrame):
3452         (WebCore::WebPage::WebPage):
3453         (WebCore::WebPage::createFrame):
3454         (WebCore::DumpRenderTree::DumpRenderTree):
3455         (WebCore::DumpRenderTree::open):
3456         (WebCore::DumpRenderTree::readStdin):
3457         (WebCore::DumpRenderTree::initJSObjects):
3458         (WebCore::DumpRenderTree::dump):
3459         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3460         (WebCore::DumpRenderTree::layoutTestController):
3461         (WebCore::DumpRenderTree::eventSender):
3462         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3463         (LayoutTestController::LayoutTestController):
3464         (LayoutTestController::reset):
3465         (LayoutTestController::maybeDump):
3466         (LayoutTestController::waitUntilDone):
3467         (LayoutTestController::notifyDone):
3468         (LayoutTestController::queueReload):
3469         (LayoutTestController::provisionalLoad):
3470         (EventSender::EventSender):
3471         (EventSender::mouseDown):
3472         (EventSender::mouseUp):
3473         (EventSender::mouseMoveTo):
3474         (EventSender::frameUnderMouse):
3475         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3476         (LayoutTestController::isLoading):
3477         (LayoutTestController::setLoading):
3478         (LayoutTestController::dumpAsText):
3479         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
3480         (main):
3481
3482 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3483
3484
3485         - Reverted an accidentally checked in file.
3486
3487         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
3488
3489 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3490         Reviewed by Sam.
3491
3492         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
3493
3494         * DumpRenderTree/win/DumpRenderTree.vcproj:
3495         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3496
3497 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3498
3499         Rubber stamped by Adam.
3500
3501         * GdkLauncher: Removed.
3502         * GdkLauncher/Bakefiles.bkgen: Removed.
3503         * GdkLauncher/ENV: Removed.
3504         * GdkLauncher/GdkLauncher.pro: Removed.
3505         * GdkLauncher/gdklauncher.bkl: Removed.
3506         * GdkLauncher/main.cpp: Removed.
3507         * GdkLauncher/mk: Removed.
3508         * GdkLauncher/simple.svg: Removed.
3509         * GdkLauncher/text.html: Removed.
3510         * GtkLauncher: Added.
3511         * GtkLauncher/GdkLauncher.pro: Removed.
3512         * GtkLauncher/GtkLauncher.pro: Added.
3513         * GtkLauncher/main.cpp:
3514         (updateWindowTitle):
3515         (main):
3516         * Scripts/build-webkit:
3517         * Scripts/regenerate-makefiles:
3518         * Scripts/run-javascriptcore-tests:
3519         * Scripts/run-launcher:
3520         * Scripts/run-webkit-tests:
3521         * Scripts/webkitdirs.pm:
3522
3523 2007-09-21  Timothy Hatcher  <timothy@apple.com>
3524
3525         Reviewed by Darin.
3526
3527         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
3528
3529         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
3530         This is tested by plugins/root-object-premature-delete-crash.html.
3531
3532         * DumpRenderTree/mac/ObjCController.m:
3533         (-[ObjCController accessStoredWebScriptObject]):
3534
3535 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
3536
3537         Reviewed by Oliver.
3538
3539         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
3540
3541         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
3542         (FrameLoadDelegate::FrameLoadDelegate):
3543
3544 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
3545
3546         Reviewed by Adam.
3547
3548         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
3549         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
3550
3551         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
3552         Now isQt() and isGdk() use global variables that are only set once.
3553
3554         An array of all the parameters is now given to build-dumprender which includes
3555         the platform on linux.
3556
3557         * Scripts/build-dumprendertree:
3558         * Scripts/run-webkit-tests:
3559         * Scripts/webkitdirs.pm:
3560
3561 2007-09-19  Adam Roben  <aroben@apple.com>
3562
3563         Rubberstamped by Hyatt.
3564
3565         * Spinneret: Removed.
3566
3567 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
3568
3569         Reviewed by David Kilzer.
3570
3571         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
3572
3573 2007-09-18  Sam Weinig  <sam@webkit.org>
3574
3575         Add JSRetainPtr.h #include to fix some builds.
3576
3577         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3578
3579 2007-09-18  Mike Hommey  <glandium@debian.org>
3580
3581         Reviewed by Adam.
3582
3583         * Scripts/prepare-ChangeLog:
3584         - Properly parse GECOS field.
3585         - Use git configuration for user name and email when appropriate.
3586
3587 2007-09-17  Sam Weinig  <sam@webkit.org>
3588
3589         Build fix.
3590
3591         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3592
3593 2007-09-17  Sam Weinig  <sam@webkit.org>
3594
3595         Reviewed by Adam Roben.
3596
3597         Share more code between mac and windows DRT.
3598             - GCController is now shared.
3599             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
3600
3601         * DumpRenderTree/GCController.cpp:
3602         * DumpRenderTree/win/DumpRenderTree.cpp:
3603         * DumpRenderTree/win/DumpRenderTree.vcproj:
3604         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
3605         (FrameLoadDelegate::FrameLoadDelegate):
3606         (FrameLoadDelegate::~FrameLoadDelegate):
3607         (FrameLoadDelegate::windowScriptObjectAvailable):
3608         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
3609         * DumpRenderTree/win/GCController.cpp: Removed.
3610         * DumpRenderTree/win/GCController.h: Removed.
36