2009-11-27 Adam Barth <abarth@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-27  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         style-queue should only process each patch once
6         https://bugs.webkit.org/show_bug.cgi?id=31939
7
8         Actually address reviewer comments!
9
10         * Scripts/bugzilla-tool:
11
12 2009-11-27  Adam Barth  <abarth@webkit.org>
13
14         Reviewed by Eric Seidel.
15
16         [bzt] style-queue fails to apply a bunch of patches for no reason
17         https://bugs.webkit.org/show_bug.cgi?id=31942
18
19         By passing --non-interactive to check-style, we convince check-style
20         to pass --force to svn-apply, which lets it apply more patches.
21
22         * Scripts/modules/commands/queues.py:
23
24 2009-11-27  Adam Barth  <abarth@webkit.org>
25
26         Reviewed by Eric Seidel.
27
28         [bzt] Support --status-host in style-queue
29         https://bugs.webkit.org/show_bug.cgi?id=31941
30
31         * Scripts/modules/commands/queues.py:
32         * Scripts/modules/statusbot.py:
33
34 2009-11-27  Adam Barth  <abarth@webkit.org>
35
36         Reviewed by Eric Seidel.
37
38         style-queue should only process each patch once
39         https://bugs.webkit.org/show_bug.cgi?id=31939
40
41         Before processing a patch, the try-queues now ask the web service
42         whether they have already processed the patch.  This is an initial cut
43         of this functionality.  I expect we're make it richer over time.
44
45         * Scripts/bugzilla-tool:
46         * Scripts/modules/commands/queues.py:
47         * Scripts/modules/patchcollection.py:
48
49 2009-11-27  Adam Barth  <abarth@webkit.org>
50
51         Reviewed by Eric Seidel.
52
53         PatchStatus does not return status
54         https://bugs.webkit.org/show_bug.cgi?id=31938
55
56         We need to parse attachment_id as an int.  Otherwise, we can't find
57         anything in the datastore.
58
59         * CommitQueueStatus/queue_status.py:
60
61 2009-11-27  Adam Barth  <abarth@webkit.org>
62
63         Reviewed by Eric Seidel.
64
65         Make commit-queue status not throw an exception where there is not
66         status
67         https://bugs.webkit.org/show_bug.cgi?id=31936
68
69         We need to actually fetch the results of the query to see what's in the
70         datastore.
71
72         * CommitQueueStatus/queue_status.py:
73
74 2009-11-27  Adam Barth  <abarth@webkit.org>
75
76         Reviewed by Eric Seidel.
77
78         [bzt] unit test ApplyPatches and ApplyAttachment
79         https://bugs.webkit.org/show_bug.cgi?id=31935
80
81         * Scripts/modules/commands/download.py:
82         * Scripts/modules/commands/download_unittest.py:
83
84 2009-11-27  Adam Barth  <abarth@webkit.org>
85
86         Reviewed by Eric Seidel.
87
88         [bzt] Unit test download commands
89         https://bugs.webkit.org/show_bug.cgi?id=31923
90
91         Adds download_unittest and fixes a bug found while testing.
92
93         * Scripts/modules/commands/commandtest.py:
94         * Scripts/modules/commands/download.py:
95             Fixed a bug where we'd throw an error because [].append returns
96             None.
97         * Scripts/modules/commands/download_unittest.py: Added.
98         * Scripts/modules/mock_bugzillatool.py:
99         * Scripts/run-webkit-unittests:
100
101 2009-11-27  Adam Barth  <abarth@webkit.org>
102
103         Unreviewed "build" fix found while writing unit tests.
104
105         * Scripts/modules/commands/download.py:
106
107 2009-11-27  Adam Barth  <abarth@webkit.org>
108
109         Reviewed by Eric Seidel.
110
111         [bzt] Kill WebKitLandingScripts
112         https://bugs.webkit.org/show_bug.cgi?id=31904
113
114         Step 6: Kill the rest.
115
116         * Scripts/modules/buildsteps.py:
117         * Scripts/modules/commands/download.py:
118         * Scripts/modules/commands/queries.py:
119         * Scripts/modules/commands/upload.py:
120         * Scripts/modules/landingsequence.py:
121         * Scripts/modules/scm.py:
122         * Scripts/modules/webkitlandingscripts.py: Removed.
123
124 2009-11-27  Adam Barth  <abarth@webkit.org>
125
126         Reviewed by Eric Seidel.
127
128         [bzt] Unit test upload commands
129         https://bugs.webkit.org/show_bug.cgi?id=31903
130
131         Adds unit tests for all but two of the upload commands.  The two
132         remaining ones are more difficult.  I'll return to them later.  The
133         goal of these tests is just to run the commands.  We can test more
134         detailed behavior later.
135
136         * Scripts/modules/commands/commandtest.py:
137         * Scripts/modules/commands/upload.py:
138         * Scripts/modules/commands/upload_unittest.py:
139         * Scripts/modules/mock.py: Added.
140         * Scripts/modules/mock_bugzillatool.py:
141
142 2009-11-26  Adam Barth  <abarth@webkit.org>
143
144         Reviewed by Eric Seidel.
145
146         [bzt] Kill WebKitLandingScripts
147         https://bugs.webkit.org/show_bug.cgi?id=31904
148
149         Step 5: Kill run_and_throw_if_fail.
150
151         * Scripts/modules/buildsteps.py:
152         * Scripts/modules/processutils.py: Added.
153         * Scripts/modules/webkitlandingscripts.py:
154
155 2009-11-26  Adam Barth  <abarth@webkit.org>
156
157         Reviewed by Eric Seidel.
158
159         [bzt] Kill WebKitLandingScripts
160         https://bugs.webkit.org/show_bug.cgi?id=31904
161
162         Step 4: Kill run_webkit_script.
163
164         * Scripts/modules/buildsteps.py:
165         * Scripts/modules/commands/download.py:
166         * Scripts/modules/webkitlandingscripts.py:
167
168 2009-11-26  Adam Barth  <abarth@webkit.org>
169
170         Reviewed by Eric Seidel.
171
172         [bzt] Kill WebKitLandingScripts
173         https://bugs.webkit.org/show_bug.cgi?id=31904
174
175         Step 3: Kill build_webkit.
176
177         * Scripts/modules/buildsteps.py:
178         * Scripts/modules/landingsequence.py:
179         * Scripts/modules/webkitlandingscripts.py:
180
181 2009-11-26  Adam Barth  <abarth@webkit.org>
182
183         Reviewed by Eric Seidel.
184
185         [bzt] Kill WebKitLandingScripts
186         https://bugs.webkit.org/show_bug.cgi?id=31904
187
188         Step 2: Kill ensure_builders_are_green.
189
190         * Scripts/modules/buildsteps.py:
191         * Scripts/modules/commands/download.py:
192         * Scripts/modules/landingsequence.py:
193         * Scripts/modules/webkitlandingscripts.py:
194
195 2009-11-26  Adam Barth  <abarth@webkit.org>
196
197         Reviewed by Eric Seidel.
198
199         [bzt] Kill WebKitLandingScripts
200         https://bugs.webkit.org/show_bug.cgi?id=31904
201
202         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
203
204         * Scripts/bugzilla-tool:
205         * Scripts/modules/buildsteps.py: Added.
206         * Scripts/modules/commands/download.py:
207         * Scripts/modules/landingsequence.py:
208         * Scripts/modules/webkitlandingscripts.py:
209
210 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
211
212         Reviewed by Adam Barth.
213
214         Remove directory prefixes from linux commands
215
216         SCM unittests can cause errors on some systems if we use absolute reference to
217         the commands, so directory prefixes have been removed.
218
219         * Scripts/modules/scm_unittest.py:
220
221 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
222
223         Reviewed by Kenneth Rohde Christiansen.
224
225         Link DumpRenderTree to the Qt Ui Tools
226         https://bugs.webkit.org/show_bug.cgi?id=31203
227
228         Implement QWebPage::createPlugin using the Qt Ui Tools
229         to be able to create classes like QProgressBar from within
230         the <object></object> tags This is required for the
231         new automatic test of Qt Plugins.
232
233         * DumpRenderTree/qt/DumpRenderTree.cpp:
234         (WebCore::WebPage::createPlugin):
235         * DumpRenderTree/qt/DumpRenderTree.h:
236         * DumpRenderTree/qt/DumpRenderTree.pro:
237
238 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
239
240         Reviewed by Eric Seidel.
241
242         Update pywebsocket to 0.4.2
243
244         Update pywebsocket to 0.4.2
245         https://bugs.webkit.org/show_bug.cgi?id=31861
246
247         * pywebsocket/example/echo_client.py:
248         * pywebsocket/example/echo_wsh.py:
249         * pywebsocket/mod_pywebsocket/__init__.py:
250         * pywebsocket/mod_pywebsocket/dispatch.py:
251         * pywebsocket/mod_pywebsocket/msgutil.py:
252         * pywebsocket/mod_pywebsocket/standalone.py:
253         * pywebsocket/setup.py:
254         * pywebsocket/test/test_dispatch.py:
255         * pywebsocket/test/test_msgutil.py:
256
257 2009-11-25  Adam Barth  <abarth@webkit.org>
258
259         Reviewed by Eric Seidel.
260
261         Add unit test for mark-fixed
262         https://bugs.webkit.org/show_bug.cgi?id=31896
263
264         * Scripts/modules/commands/commandtest.py: Added.
265         * Scripts/modules/commands/queries_unittest.py:
266         * Scripts/modules/commands/upload_unittest.py: Added.
267         * Scripts/modules/mock_bugzillatool.py:
268         * Scripts/run-webkit-unittests:
269
270 2009-11-25  Adam Barth  <abarth@webkit.org>
271
272         Reviewed by Eric Seidel.
273
274         bugzilla-tool should have a mark-fixed command
275         https://bugs.webkit.org/show_bug.cgi?id=31853
276
277         Pretty simple stuff.
278
279         * Scripts/modules/commands/upload.py:
280
281 2009-11-25  Eric Seidel  <eric@webkit.org>
282
283         Reviewed by Adam Barth.
284
285         'bugzilla-tool help' should only show common commands like how 'git help' does
286         https://bugs.webkit.org/show_bug.cgi?id=31772
287
288         I also took this opportunity to make 'help' a real Command.
289         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
290
291         * Scripts/bugzilla-tool:
292          - change should_show_command_help to should_show_in_main_help
293         * Scripts/modules/commands/download.py:
294          - Mark commands as being shown in main help or not.
295          - show_in_main_help = False is not required (default is false),
296            but it seemed to make the commands more self-documenting.
297         * Scripts/modules/commands/queries.py: ditto
298         * Scripts/modules/commands/queues.py: ditto
299         * Scripts/modules/commands/upload.py: ditto
300         * Scripts/modules/multicommandtool.py:
301          - Make Command hold a pointer to tool in self.tool.  Most Command
302            subclasses do not take advantage of this yet, but it was required
303            for HelpCommand to be able to reach the tool from _help_epilog().
304          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
305          - Move MultiCommandTool._help_epilog to Command._help_epilog
306          - Move "help" logic into HelpCommand.execute()
307          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
308         * Scripts/modules/multicommandtool_unittest.py:
309          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
310
311 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
312
313         Reviewed by Dan Bernstein.
314         
315         Patch by Mark Rowe.
316
317         The buildbots are failing on Windows because when they were upgraded
318         to 4.0.4, Apple Application Support was not in their path. Add it to
319         the path to fix the buildots.
320
321         * Scripts/webkitdirs.pm:
322
323 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
324
325         Reviewed by David Kilzer.
326
327         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
328         https://bugs.webkit.org/show_bug.cgi?id=31799
329
330         * Scripts/run-webkit-tests: Fixed.
331
332 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
333
334         Reviewed by Eric Seidel.
335
336         Change run_command to give back stderr by default
337         https://bugs.webkit.org/show_bug.cgi?id=31734
338
339         Change run_command to give back stderr by default.
340         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
341         Change the related unittest call.
342
343         * Scripts/modules/scm.py:
344         * Scripts/modules/scm_unittest.py:
345
346 2009-11-25  Eric Seidel  <eric@webkit.org>
347
348         Reviewed by Adam Barth.
349
350         Centralize required argument parsing in Command
351         https://bugs.webkit.org/show_bug.cgi?id=31872
352
353         * Scripts/modules/commands/download.py: remove custom required arg message.
354         * Scripts/modules/commands/upload.py: ditto.
355         * Scripts/modules/multicommandtool.py:
356          - Add _parse_required_arguments.
357          - Pass program name off to OptionParser.
358          - Add name() for access to tool name.
359          - Add check_arguments_and_execute and make it return a return code.
360          - Replace a couple uses of + with %.
361         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
362
363 2009-11-25  Eric Seidel  <eric@webkit.org>
364
365         Reviewed by Adam Barth.
366
367         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
368         https://bugs.webkit.org/show_bug.cgi?id=31870
369
370         * Scripts/modules/commands/queries_unittest.py: Use the new class.
371         * Scripts/modules/multicommandtool_unittest.py: Ditto.
372         * Scripts/modules/outputcapture.py: Added.
373
374 2009-11-24  Dmitry Titov  <dimich@chromium.org>
375
376         Reviewed by Eric Seidel.
377
378         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
379         https://bugs.webkit.org/show_bug.cgi?id=31444
380
381         * Scripts/build-webkit:
382
383 2009-11-24  Chris Marrin  <cmarrin@apple.com>
384
385         Reviewed by Simon Fraser.
386
387         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
388         https://bugs.webkit.org/show_bug.cgi?id=27314
389         
390         Now the script allows the directories with these tests to be included on all
391         platforms but Mac, where they behave the same as always. For all other platforms
392         the tests need to be excluded using the Skipped files, which is currently done
393         for all platforms (including win since we're not turned on yet)
394
395         * Scripts/webkitdirs.pm:
396
397 2009-11-24  Eric Seidel  <eric@webkit.org>
398
399         Reviewed by Adam Barth.
400
401         queries_unittest.py should test command output
402         https://bugs.webkit.org/show_bug.cgi?id=31845
403
404         * Scripts/modules/commands/queries_unittest.py:
405          - Capture stdout and stderr and compare with expected strings.
406
407 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
408
409         No Review.
410
411         Fix spelling error ("depenedencies").
412
413         * Scripts/build-webkit:
414
415 2009-11-24  Mark Rowe  <mrowe@apple.com>
416
417         Land the configuration that includes the two debug GTK Linux builders.
418
419         * BuildSlaveSupport/build.webkit.org-config/config.json:
420
421 2009-11-24  David Kilzer  <ddkilzer@apple.com>
422
423         <http://webkit.org/b/31840> bisect-builds broke after r50080
424
425         Reviewed by Dan Bernstein.
426
427         * Scripts/bisect-builds:
428         (mountAndRunNightly): Switched back to using backticks to run
429         the hdiutil command since exec() will terminate the existing
430         script, which is not what we want.  Store the output of
431         File::Spec->devnull() in a variable for use in the hdiutil
432         detach commands.
433
434 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
435
436         Reviewed by Kenneth Rohde Christiansen.
437
438         Include "config.h" to meet Coding Style Guidelines
439         https://bugs.webkit.org/show_bug.cgi?id=31792
440
441         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
442         * DumpRenderTree/qt/jsobjects.cpp:
443         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
444
445 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
446
447         Reviewed by Oliver Hunt.
448
449         Implement new required function to pass test we used to pass. This
450         change is required since r51294.
451
452         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
453         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
454
455 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
456
457         Reviewed by Kenneth Rohde Christiansen.
458
459         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
460         https://bugs.webkit.org/show_bug.cgi?id=31775
461
462         LayoutTestController::dumpBackForwardList() should work with local URLs
463         as well as with normal URLs (in http tests for instance).
464         Currently it does not output the latter properly.
465
466         Unskip a bunch of passing http/navigation tests.
467
468         * DumpRenderTree/qt/DumpRenderTree.cpp:
469         (WebCore::dumpHistoryItem):
470
471 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
472
473         Reviewed by Oliver Hunt.
474
475         ARIA: support aria-flowto
476         https://bugs.webkit.org/show_bug.cgi?id=31762
477
478         * DumpRenderTree/AccessibilityUIElement.cpp:
479         (ariaFlowToElementAtIndexCallback):
480         (AccessibilityUIElement::getJSClass):
481         * DumpRenderTree/AccessibilityUIElement.h:
482         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
483         (AccessibilityUIElement::ariaFlowToElementAtIndex):
484         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
485         (AccessibilityUIElement::ariaFlowToElementAtIndex):
486         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
487         (AccessibilityUIElement::ariaFlowToElementAtIndex):
488
489 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
490
491         Reviewed by Kenneth Christiansen.
492
493         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
494         https://bugs.webkit.org/show_bug.cgi?id=31638
495
496         Unfreeze WorkQueue after each test execution.
497
498         * DumpRenderTree/qt/DumpRenderTree.cpp:
499         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
500
501 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
502
503         Reviewed by Adam Barth.
504
505         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
506         for localhost and 127.0.0.1.
507         https://bugs.webkit.org/show_bug.cgi?id=31783
508
509         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
510
511         * DumpRenderTree/qt/DumpRenderTree.cpp:
512         (WebCore::NetworkAccessManager::NetworkAccessManager):
513         (WebCore::NetworkAccessManager::sslErrorsEncountered):
514         (WebCore::WebPage::WebPage):
515         * DumpRenderTree/qt/DumpRenderTree.h:
516
517 2009-11-22  Chris Evans  <cevans@chromium.org>
518
519         Reviewed by Adam Barth.
520
521         Disable access to file:/// directory listings
522         https://bugs.webkit.org/show_bug.cgi?id=31329
523
524         Implemented setAllowUniversalAccessFromFileURLs to support testing of
525         file URL security.
526
527         * DumpRenderTree/LayoutTestController.cpp:
528         (setAllowUniversalAccessFromFileURLsCallback):
529         (LayoutTestController::staticFunctions):
530         * DumpRenderTree/LayoutTestController.h:
531         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
532         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
533         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
534         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
535         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
536         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
537         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
538         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
539
540 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
541
542         Reviewed by Kenneth Rohde Christiansen.
543
544         [Qt] Fix the timeout of fast/frames/frame-navigation.html
545         https://bugs.webkit.org/show_bug.cgi?id=31638
546
547         The test is timeouting, because it uses the WorkQueue to load a document in one
548         of the child frames and once the loading is finished, the DRT does not dump the
549         tree. This is because it waits for the QWebFrame::loadFinished() signal from
550         the main frame, while it should connect to QWebPage::loadFinished().
551
552         * DumpRenderTree/qt/DumpRenderTree.cpp:
553         (WebCore::DumpRenderTree::DumpRenderTree):
554
555 2009-11-21  Eric Seidel  <eric@webkit.org>
556
557         Reviewed by Adam Barth.
558
559         bugzilla-tool --help spews way too much text
560         https://bugs.webkit.org/show_bug.cgi?id=31771
561
562         * Scripts/bugzilla-tool:
563          - Remove self.cached_scm initialization hack.
564         * Scripts/modules/buildbot.py:
565          - Make default_host accessible to callers.
566         * Scripts/modules/commands/download.py:
567          - Phrase help for all commands consistently and remove spurious help text punctuation.
568         * Scripts/modules/commands/queries.py: Ditto.
569         * Scripts/modules/commands/queues.py: Ditto.
570         * Scripts/modules/commands/upload.py: Ditto.
571         * Scripts/modules/multicommandtool.py:
572          - Add HelpPrintingOptionParser.format_epilog to replace
573            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
574            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
575          - Make --help only show a list of commands like "svn help" and "git help" do --
576            previously --help was listing all commands and options.
577          - Sort list of commands alphabetically.
578
579 2009-11-21  Eric Seidel  <eric@webkit.org>
580
581         No review.  Fixing a typo from the previous patch for bug 31767.
582
583         AbstractQueue.run_bugzilla_tool throws an exception
584         https://bugs.webkit.org/show_bug.cgi?id=31769
585
586         * Scripts/modules/commands/queues.py:
587
588 2009-11-21  Eric Seidel  <eric@webkit.org>
589
590         Reviewed by Adam Barth.
591
592         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
593         https://bugs.webkit.org/show_bug.cgi?id=31767
594
595         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
596         Since we don't have a good way to test BugzillaTool pieces, I've
597         left out a test for now.
598
599         * Scripts/bugzilla-tool:
600          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
601         * Scripts/modules/commands/queues.py:
602          - Use tool.path() instead of __file__.
603         * Scripts/modules/multicommandtool.py:
604          - Add a new path() method to MultiComandTool.
605         * Scripts/modules/multicommandtool_unittest.py:
606          - Provide a path() method.  Little point in testing this mock implementation.
607
608 2009-11-21  Adam Barth  <abarth@webkit.org>
609
610         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
611         WebKitTools.
612
613         * Scripts/modules/commands/download.py:
614
615 2009-11-21  Adam Barth  <abarth@webkit.org>
616
617         Reviewed by Eric Seidel.
618
619         Convert check-style to use LandingSequence
620         https://bugs.webkit.org/show_bug.cgi?id=31763
621
622         Instead of manipulating the working copy by hand, we should use the
623         LandingSequence in CheckStyle.  This will make this code eaiser to
624         test.
625
626         * Scripts/modules/commands/download.py:
627
628 2009-11-20  Adam Barth  <abarth@webkit.org>
629
630         Reviewed by Eric Seidel.
631
632         Unit test query commands
633         https://bugs.webkit.org/show_bug.cgi?id=31755
634
635         These tests are pretty rough, but hopefully they'll grow.
636
637         * Scripts/modules/commands/queries_unittest.py: Added.
638         * Scripts/modules/mock_bugzillatool.py: Added.
639         * Scripts/run-webkit-unittests:
640
641 2009-11-20  Eric Seidel  <eric@webkit.org>
642
643         Reviewed by Adam Barth.
644
645         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
646         https://bugs.webkit.org/show_bug.cgi?id=31758
647
648         * Scripts/modules/multicommandtool.py:
649          - Allow passing of explicit commands to MultiCommandTool.__init__
650         * Scripts/modules/multicommandtool_unittest.py:
651          - Use new Command.name naming system.
652          - Test Command auto-discovery.
653         * Scripts/modules/workqueue.py:
654          - bug_id no longer exists, use patch['bug_id'] instead.
655         * Scripts/modules/workqueue_unittest.py:
656          - WorkQueues require names now.
657          - should_proceed_with_work_item must return a patch object.
658
659 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
660
661         Reviewed by Beth Dakin.
662
663         WAI-ARIA: add support for aria-owns
664         https://bugs.webkit.org/show_bug.cgi?id=31702
665
666         * DumpRenderTree/AccessibilityUIElement.cpp:
667         (ariaOwnsElementAtIndexCallback):
668         (AccessibilityUIElement::getJSClass):
669         * DumpRenderTree/AccessibilityUIElement.h:
670         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
671         (AccessibilityUIElement::ariaOwnsElementAtIndex):
672         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
673         (AccessibilityUIElement::ariaOwnsElementAtIndex):
674         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
675         (AccessibilityUIElement::ariaOwnsElementAtIndex):
676
677 2009-11-20  Eric Seidel  <eric@webkit.org>
678
679         Reviewed by Adam Barth.
680
681         Fix exception thrown when running the commit-queue.
682
683         * Scripts/modules/statusbot.py: patch is optional.
684         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
685
686 2009-11-20  Eric Seidel  <eric@webkit.org>
687
688         Reviewed by Adam Barth.
689
690         Teach the StatusBot how to support more than just the commit-queue
691         https://bugs.webkit.org/show_bug.cgi?id=31754
692
693         * Scripts/modules/workqueue.py: Another typo.
694
695 2009-11-20  Eric Seidel  <eric@webkit.org>
696
697         Reviewed by Adam Barth.
698
699         Teach the StatusBot how to support more than just the commit-queue
700         https://bugs.webkit.org/show_bug.cgi?id=31754
701
702         * Scripts/modules/commands/queues.py: Fix silly typo.
703
704 2009-11-20  Eric Seidel  <eric@webkit.org>
705
706         Reviewed by Adam Barth.
707
708         Teach the StatusBot how to support more than just the commit-queue
709         https://bugs.webkit.org/show_bug.cgi?id=31754
710
711         * CommitQueueStatus/index.yaml:
712          - Add indices required for the new queries.
713         * CommitQueueStatus/queue_status.py:
714          - Add a patch-status page and move update_status to update-status.
715          - Only display "commit-queue" status records for the commit-queue.
716          - Add support for a queue_name property on status records.
717          - Fix _int_from_request to actually work.
718         * CommitQueueStatus/update_status.html:
719          - Add support for a queue_name on status records.
720          - Remove unused list of bug ids.
721          * Scripts/modules/commands/queues.py
722           - Make the queues pass the patch instead of the bug_id to StatusBot.
723         * Scripts/modules/statusbot.py:
724          - Support passing the queue_name to the status updates.
725          - Support fetching patch status with patch_status().
726         * Scripts/modules/workqueue.py:
727          - Pass the patch to the StatusBot instead of the bug_id.
728          - Let WorkQueues have a name.
729
730 2009-11-20  Adam Barth  <abarth@webkit.org>
731
732         Reviewed by Eric Seidel.
733
734         Move bugzilla-tool commands into their own file
735         https://bugs.webkit.org/show_bug.cgi?id=31752
736
737         This will let us write unit tests.
738
739         * Scripts/bugzilla-tool:
740         * Scripts/modules/commands/__init__.py: Added.
741         * Scripts/modules/commands/download.py: Added.
742         * Scripts/modules/commands/queries.py: Added.
743         * Scripts/modules/commands/queues.py: Added.
744         * Scripts/modules/commands/upload.py: Added.
745         * Scripts/modules/grammar.py: Added.
746
747 2009-11-20  Adam Barth  <abarth@webkit.org>
748
749         Reviewed by Eric Seidel.
750
751         BuildQueue should check if the tree is currently buildable
752         https://bugs.webkit.org/show_bug.cgi?id=31744
753
754         * Scripts/bugzilla-tool:
755         * Scripts/modules/landingsequence.py:
756         * Scripts/modules/webkitlandingscripts.py:
757
758 2009-11-20  Adam Barth  <abarth@webkit.org>
759
760         Reviewed by Eric Seidel.
761
762         Move prepare_clean_working_directory into the LandingSequence
763         https://bugs.webkit.org/show_bug.cgi?id=31743
764
765         * Scripts/bugzilla-tool:
766         * Scripts/modules/landingsequence.py:
767
768 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
769
770         Reviewed by Kenneth Rohde Christiansen.
771
772         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
773         https://bugs.webkit.org/show_bug.cgi?id=30460
774
775         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
776
777         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
778         (pluginInvoke):
779
780 2009-11-20  Adam Barth  <abarth@webkit.org>
781
782         Reviewed by Eric Seidel.
783
784         Pass the port information to the child process
785         https://bugs.webkit.org/show_bug.cgi?id=31736
786
787         We need to do this so the child process knows what to build!
788
789         * Scripts/bugzilla-tool:
790         * Scripts/modules/landingsequence.py:
791         * Scripts/modules/webkitport.py:
792         * Scripts/modules/webkitport_unittest.py:
793
794 2009-11-20  Adam Barth  <abarth@webkit.org>
795
796         Reviewed by Eric Seidel.
797
798         Support Qt port in build-queue
799         https://bugs.webkit.org/show_bug.cgi?id=31733
800
801         * Scripts/bugzilla-tool:
802
803 2009-11-20  Adam Barth  <abarth@webkit.org>
804
805         Reviewed by Eric Seidel.
806
807         Implement a build-queue
808         https://bugs.webkit.org/show_bug.cgi?id=31725
809
810         Currently this just builds the first 10 patches in the review queue.
811         We'll want to do something smarter soon.
812
813         * Scripts/bugzilla-tool:
814
815 2009-11-20  Adam Barth  <abarth@webkit.org>
816
817         Reviewed by Eric Seidel.
818
819         Make commit-queue and style-queue show up in help
820         https://bugs.webkit.org/show_bug.cgi?id=31724
821
822         We need to store their names on their class to make these commands
823         properly register themselves with MultiCommandTool.
824
825         * Scripts/bugzilla-tool:
826
827 2009-11-20  Adam Barth  <abarth@webkit.org>
828
829         Reviewed by Eric Seidel.
830
831         Implement bugzilla-tool build-attachment
832         https://bugs.webkit.org/show_bug.cgi?id=31722
833
834         This command builds an attachment from bugzilla.  It leaves the built
835         patch in the working copy.
836
837         * Scripts/bugzilla-tool:
838         * Scripts/modules/landingsequence.py:
839         * Scripts/modules/webkitlandingscripts.py:
840
841 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
842
843         Reviewed by Xan Lopez.
844
845         [GTK] DRT release event does not create the state correctly
846         https://bugs.webkit.org/show_bug.cgi?id=31717
847
848         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
849
850 2009-11-20  Eric Seidel  <eric@webkit.org>
851
852         Reviewed by Adam Barth.
853
854         MultiCommandTool should find Command objects automatically instead of with a manual list
855         https://bugs.webkit.org/show_bug.cgi?id=31710
856
857         * Scripts/bugzilla-tool:
858         * Scripts/modules/multicommandtool.py:
859          - Use some wild python-fu to crawl all the known subclasses of Command.
860
861 2009-11-20  Adam Barth  <abarth@webkit.org>
862
863         Unreviewed "build" fix.  Added missing import.
864
865         * Scripts/bugzilla-tool:
866
867 2009-11-20  Adam Barth  <abarth@webkit.org>
868
869         Unreviewed "build" fix.  I failed to update LandingSequence.test
870         properly.
871
872         * Scripts/modules/landingsequence.py:
873
874 2009-11-20  Adam Barth  <abarth@webkit.org>
875
876         Reviewed by Eric Seidel.
877
878         Create LandingSequence as the all-sing, all-dance landing class
879         https://bugs.webkit.org/show_bug.cgi?id=31709
880
881         Client can inherit from this class to carefully control exactly which
882         steps they wish to have happen in the landing sequence.
883
884         * Scripts/bugzilla-tool:
885         * Scripts/modules/landingsequence.py: Added.
886         * Scripts/modules/webkitlandingscripts.py: Added.
887
888 2009-11-19  Adam Barth  <abarth@webkit.org>
889
890         Reviewed by Eric Seidel.
891
892         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
893         https://bugs.webkit.org/show_bug.cgi?id=31707
894
895         This is to help when we implement build-attachment.
896
897         * Scripts/bugzilla-tool:
898
899 2009-11-19  Adam Barth  <abarth@webkit.org>
900
901         Reviewed by Eric Seidel.
902
903         Support Qt port in bugzilla-tool
904         https://bugs.webkit.org/show_bug.cgi?id=31701
905
906         Now we support building with Qt!
907
908         * Scripts/bugzilla-tool:
909         * Scripts/modules/webkitport.py: Added.
910         * Scripts/modules/webkitport_unittest.py: Added.
911         * Scripts/run-webkit-unittests:
912
913 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
914
915         Reviewed by Adam Barth.
916
917         Remove inserting stderr into patch in bugzilla-tool
918         https://bugs.webkit.org/show_bug.cgi?id=29914
919
920         Modify SCM python module's run_command function to avoid return of stderr
921         by default, so stderr won't be inserted into the patches.
922         Modify the related unit test.
923
924         * Scripts/modules/scm.py:
925         * Scripts/modules/scm_unittest.py:
926
927 2009-11-19  Eric Seidel  <eric@webkit.org>
928
929         Reviewed by Adam Barth.
930
931         bugzilla-tool needs per-command help
932         https://bugs.webkit.org/show_bug.cgi?id=31697
933
934         Added support for "bugzilla-tool help command-name"
935         and a unit test to make sure it works.
936
937         * Scripts/modules/multicommandtool.py:
938         * Scripts/modules/multicommandtool_unittest.py:
939
940 2009-11-19  Eric Seidel  <eric@webkit.org>
941
942         Reviewed by Adam Barth.
943
944         Move MultiCommandTool and Command into a separate file and add some basic unit tests
945         https://bugs.webkit.org/show_bug.cgi?id=31695
946
947         * Scripts/bugzilla-tool:
948         * Scripts/modules/multicommandtool.py: Added.
949         * Scripts/modules/multicommandtool_unittest.py: Added.
950         * Scripts/run-webkit-unittests:
951
952 2009-11-19  Eric Seidel  <eric@webkit.org>
953
954         No review, just adding a FIXME.
955
956         Split out command parsing and help printing from BugzillaTool
957         https://bugs.webkit.org/show_bug.cgi?id=31688
958
959         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
960
961 2009-11-19  Eric Seidel  <eric@webkit.org>
962
963         Reviewed by Adam Barth.
964
965         Split out command parsing and help printing from BugzillaTool
966         https://bugs.webkit.org/show_bug.cgi?id=31688
967
968         * Scripts/bugzilla-tool:
969          - Add new MultiCommandTool class to contain option parsing and help printing logic.
970          - Rename private methods to use _ pattern.
971          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
972          - 
973
974 2009-11-19  Eric Seidel  <eric@webkit.org>
975
976         Reviewed by Adam Barth.
977
978         Re-factor help printing to use modern python idioms
979         https://bugs.webkit.org/show_bug.cgi?id=31685
980
981         * Scripts/bugzilla-tool:
982
983 2009-11-19  Eric Seidel  <eric@webkit.org>
984
985         Reviewed by Darin Adler.
986
987         commit-queue empty queue logs twice
988         https://bugs.webkit.org/show_bug.cgi?id=31679
989
990         * Scripts/bugzilla-tool:
991
992 2009-11-19  Eric Seidel  <eric@webkit.org>
993
994         Reviewed by Darin Adler.
995
996         bugzilla-tool's reviewer/committer rejection message should be clearer
997         https://bugs.webkit.org/show_bug.cgi?id=31126
998
999         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
1000
1001         * Scripts/modules/bugzilla.py:
1002
1003 2009-11-19  Eric Z. Ayers  <zundel@google.com>
1004
1005         Reviewed by Pavel Feldman.
1006
1007         Forces a WM_PAINT event on calling layoutTestController.display()
1008         in order to enable the timeline-paint.html test on Windows.
1009         ::UpdateWindow() does not force an event becaue the window is 
1010         not visible.
1011
1012         https://bugs.webkit.org/show_bug.cgi?id=31402
1013
1014         * DumpRenderTree/win/DumpRenderTree.cpp:
1015         (displayWebView):
1016
1017 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
1018
1019         No review needed.
1020
1021         Added myself to committers list.
1022
1023         * Scripts/modules/committers.py:
1024
1025 2009-11-19  Adam Barth  <abarth@webkit.org>
1026
1027         Reviewed by Eric Seidel.
1028
1029         Bugzilla-tool command classes should match command names
1030         https://bugs.webkit.org/show_bug.cgi?id=31666
1031
1032         I renamed all the commands except CommitMessageForCurrentDiff because
1033         the new name would conflict with an existing class.
1034
1035         * Scripts/bugzilla-tool:
1036
1037 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
1038
1039         Reviewed by Gustavo Noronha Silva.
1040
1041         Web Inspector: Implement "show inspector" in WebKit GTK
1042         API and enable console tests.
1043
1044         https://bugs.webkit.org/show_bug.cgi?id=31669
1045
1046         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1047         (LayoutTestController::showWebInspector):
1048
1049 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1050
1051         Reviewed by Simon Hausmann.
1052
1053         Minor refactoring + more documentation.
1054
1055         * DumpRenderTree/qt/DumpRenderTree.cpp:
1056         (WebCore::clearHistory):
1057         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1058
1059 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
1060
1061         Reviewed by Eric Seidel.
1062
1063         Ignore websocket tests when --no-http is specified.
1064         https://bugs.webkit.org/show_bug.cgi?id=31662
1065
1066         * Scripts/run-webkit-tests:
1067
1068 2009-11-18  Adam Barth  <abarth@webkit.org>
1069
1070         Reviewed by Eric Seidel.
1071
1072         Normalize ' and " in bugzilla-tool
1073         https://bugs.webkit.org/show_bug.cgi?id=31655
1074
1075         We decided " is better than ' and we should be consistent.
1076
1077         * Scripts/bugzilla-tool:
1078
1079 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1080
1081         Reviewed by Kenneth Rohde Christiansen.
1082
1083         [Qt] Remove support for Qt v4.3 or older versions
1084         https://bugs.webkit.org/show_bug.cgi?id=29469
1085
1086         * DumpRenderTree/qt/DumpRenderTree.pro:
1087         * DumpRenderTree/qt/ImageDiff.pro:
1088
1089 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1090
1091         Reviewed by Eric Seidel.
1092
1093         GitTest.test_create_binary_patch fails if /tmp is symlink
1094         https://bugs.webkit.org/show_bug.cgi?id=31536
1095
1096         * Scripts/modules/scm_unittest.py:
1097
1098 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
1099
1100         Reviewed by Darin Adler.
1101
1102         Configuration for Chromium Build Slaves.
1103
1104         https://bugs.webkit.org/show_bug.cgi?id=31442
1105
1106         * BuildSlaveSupport/build.webkit.org-config/config.json:
1107         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1108
1109 2009-11-18  Eric Seidel  <eric@webkit.org>
1110
1111         Reviewed by Darin Adler.
1112
1113         workqueue.py results in totally broken commit-queue UI
1114         https://bugs.webkit.org/show_bug.cgi?id=31645
1115
1116         * Scripts/bugzilla-tool:
1117          - Remove unneeded use of PatchCollection.
1118          - Grab a new copy of the cq'd patches every run of the queue.
1119
1120 2009-11-18  Sam Weinig  <sam@webkit.org>
1121
1122         Reviewed by Anders Carlsson.
1123
1124         Make the Mac Geolocation API async.
1125
1126         Update DRT to use the new async Mac Geolocation API.
1127
1128         * DumpRenderTree/mac/UIDelegate.mm:
1129         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1130
1131 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1132
1133         Reviewed by Kenneth Rohde Christiansen.
1134
1135         Add and option to toggle HTML5 datalist support to build-webkit
1136         https://bugs.webkit.org/show_bug.cgi?id=31599
1137
1138         * Scripts/build-webkit:
1139
1140 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1141
1142         Reviewed by Kevin Ollivier.
1143
1144         Enable wx plugin support using the Windows implementation as a base.
1145         
1146         https://bugs.webkit.org/show_bug.cgi?id=31636
1147
1148         * wx/build/settings.py:
1149
1150 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1151
1152         Reviewed by Simon Hausmann.
1153
1154         Change the initialization order so that the controllers
1155         will be created before exporting them to the JS DOM window.
1156
1157         * DumpRenderTree/qt/DumpRenderTree.cpp:
1158         (WebCore::DumpRenderTree::DumpRenderTree):
1159
1160 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1161
1162         Reviewed by Simon Hausmann.
1163
1164         Fix a code copy and paste error. m_page should be page.
1165
1166         * DumpRenderTree/qt/DumpRenderTree.cpp:
1167         (WebCore::DumpRenderTree::createWindow):
1168
1169 2009-11-17  Mark Rowe  <mrowe@apple.com>
1170
1171         Reviewed by Alexey Proskuryakov.
1172
1173         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
1174
1175         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
1176         This prevents symlinks from confusing the descendant check.
1177
1178 2009-11-17  Mark Rowe  <mrowe@apple.com>
1179
1180         Reviewed by Alexey Proskuryakov.
1181
1182         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
1183
1184         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
1185         server to be up rather than having run-webkit-tests abort immediately.
1186
1187         * Scripts/run-webkit-tests:
1188
1189 2009-11-17  Eric Seidel  <eric@webkit.org>
1190
1191         Reviewed by Darin Adler.
1192
1193         commit-queue is failing to set reviewer in ChangeLogs
1194         https://bugs.webkit.org/show_bug.cgi?id=31592
1195
1196         * Scripts/bugzilla-tool: Clarify the "applying" log message.
1197         * Scripts/modules/bugzilla.py:
1198          - Add a new _validate_committer_and_reviewer function as a
1199            temporary solution until we can make a real Attachment object
1200            which knows how to fill in its committer/reviewer fields automatically.
1201
1202 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1203
1204         Unreviewed buildbot fix.
1205
1206         Revert part of earlier patch and add comment, as it
1207         was causing timeouts on the buildbot.
1208
1209         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1210         (LayoutTestController::notifyDone):
1211
1212 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1213
1214         Reviewed by Oliver Hunt.
1215
1216         Make the timeout 15 sec as for the other DRT's and make
1217         it print out the same output when a test timeout.
1218
1219         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1220         (LayoutTestController::waitUntilDone):
1221         (LayoutTestController::notifyDone):
1222         (LayoutTestController::timerEvent):
1223
1224 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
1225
1226         Reviewed by Timothy Hatcher.
1227
1228         Fixed typos in comments.
1229
1230         * Scripts/modules/committers.py:
1231
1232 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
1233
1234         Reviewed by Timothy Hatcher.
1235
1236         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1237         - Updated DRT to show/close inspector for all tests under /inspector
1238         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1239           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1240         - Removed reload on each inspector test
1241         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1242         inspector for those.
1243         - Reimplemented timeline tests in order to get rid of reload there.
1244         - Moved tests that don't require harness into the fast group.
1245
1246         https://bugs.webkit.org/show_bug.cgi?id=31472
1247
1248         * DumpRenderTree/LayoutTestController.cpp:
1249         (setTimelineProfilingEnabledCallback):
1250         (closeWebInspectorCallback):
1251         (LayoutTestController::staticFunctions):
1252         * DumpRenderTree/LayoutTestController.h:
1253         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1254         (shouldOpenWebInspector):
1255         (runTest):
1256         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1257         (LayoutTestController::setTimelineProfilingEnabled):
1258         * DumpRenderTree/mac/DumpRenderTree.mm:
1259         (shouldOpenWebInspector):
1260         (runTest):
1261         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1262         (LayoutTestController::setTimelineProfilingEnabled):
1263         * DumpRenderTree/win/DumpRenderTree.cpp:
1264         (shouldOpenWebInspector):
1265         (runTest):
1266         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1267         (LayoutTestController::setTimelineProfilingEnabled):
1268
1269 2009-11-17  Oliver Hunt  <oliver@apple.com>
1270
1271         Reviewed by Maciej Stachowiak.
1272
1273         Incorrect use of JavaScriptCore API in DumpRenderTree
1274         https://bugs.webkit.org/show_bug.cgi?id=31577
1275
1276         Return undefined rather than a literal null.
1277
1278         * DumpRenderTree/AccessibilityUIElement.cpp:
1279         (setSelectedTextRangeCallback):
1280         (incrementCallback):
1281         (decrementCallback):
1282         (showMenuCallback):
1283
1284 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1285
1286         Reviewed by Beth Dakin.
1287
1288         AX: aria-labelledby duplicates some of its WAI-ARIA label
1289         https://bugs.webkit.org/show_bug.cgi?id=31565
1290
1291         * DumpRenderTree/AccessibilityUIElement.cpp:
1292         (titleUIElementCallback):
1293         (getIsValidCallback):
1294         (AccessibilityUIElement::getJSClass):
1295
1296 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1297
1298         Reviewed by Simon Hausmann.
1299
1300         r50942 broke output from created windows. Make the
1301         m_enableTextOutput a member of the DRT and not the
1302         WebPage.
1303
1304         * DumpRenderTree/qt/DumpRenderTree.cpp:
1305         (WebCore::WebPage::WebPage):
1306         (WebCore::WebPage::javaScriptAlert):
1307         (WebCore::WebPage::javaScriptConsoleMessage):
1308         (WebCore::WebPage::javaScriptConfirm):
1309         (WebCore::WebPage::javaScriptPrompt):
1310         (WebCore::WebPage::acceptNavigationRequest):
1311         (WebCore::DumpRenderTree::DumpRenderTree):
1312         (WebCore::DumpRenderTree::open):
1313         (WebCore::DumpRenderTree::createWindow):
1314         * DumpRenderTree/qt/DumpRenderTree.h:
1315         (WebCore::DumpRenderTree::setTextOutputEnabled):
1316         (WebCore::DumpRenderTree::isTextOutputEnabled):
1317         (WebCore::WebPage::shouldInterruptJavaScript):
1318         (WebCore::WebPage::isTextOutputEnabled):
1319         (WebCore::WebPage::setViewGeometry):
1320
1321 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1322
1323         Reviewed by Gustavo Noronha Silva.
1324
1325         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
1326         as the implementation is being used by at least Qt and Gtk+.
1327
1328         Update buildsystems as well.
1329
1330         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1331         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1332         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1333         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1334         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1335         * GNUmakefile.am:
1336
1337 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
1338
1339         Reviewed by Alexey Proskuryakov.
1340
1341         Disable wss until all platforms support pyOpenSSL
1342
1343         https://bugs.webkit.org/show_bug.cgi?id=31479
1344
1345         * Scripts/run-webkit-tests:
1346
1347 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1348
1349         Reviewed by Kenneth Christiansen.
1350
1351         [Qt] Implement load error pages support for Qt's DRT.
1352         https://bugs.webkit.org/show_bug.cgi?id=31509
1353
1354         For now, it will not be a default feature, and layout tests
1355         that want to make use of this have to explicitily call
1356         'handleErrorPages();' for the test source.
1357
1358         Any of the other DumpRenderTree's (mac, win and gtk)
1359         support handling error pages. Qt's will be the first.
1360
1361         * DumpRenderTree/qt/DumpRenderTree.cpp:
1362         (WebCore::WebPage::supportsExtension):
1363         (WebCore::WebPage::extension):
1364         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1365         (LayoutTestController::reset):
1366         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1367         (LayoutTestController::shouldHandleErrorPages):
1368         (LayoutTestController::handleErrorPages):
1369
1370 2009-11-16  Eric Seidel  <eric@webkit.org>
1371
1372         Reviewed by Adam Barth.
1373
1374         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1375         https://bugs.webkit.org/show_bug.cgi?id=31549
1376
1377         Renamed --commit-queue to --non-interactive in most places
1378         and remove the code in land-patches which is no longer needed.
1379
1380         * Scripts/bugzilla-tool:
1381
1382 2009-11-16  Eric Seidel  <eric@webkit.org>
1383
1384         Reviewed by Adam Barth.
1385
1386         The commit-queue should use land-attachment
1387         https://bugs.webkit.org/show_bug.cgi?id=31548
1388
1389         * Scripts/bugzilla-tool:
1390
1391 2009-11-16  Adam Barth  <abarth@webkit.org>
1392
1393         Reviewed by Eric Seidel.
1394
1395         Convert CommitQueue over to PatchCollection
1396         https://bugs.webkit.org/show_bug.cgi?id=31547
1397
1398         Also fixes a bug in workqueue and adds a test!
1399
1400         * Scripts/bugzilla-tool:
1401         * Scripts/modules/workqueue.py:
1402         * Scripts/modules/workqueue_unittest.py:
1403
1404 2009-11-16  Adam Barth  <abarth@webkit.org>
1405
1406         Reviewed by Eric Seidel.
1407
1408         Move StyleQueue over to using PatchCollection
1409         https://bugs.webkit.org/show_bug.cgi?id=31544
1410
1411         That's what the class it's for.
1412
1413         * Scripts/bugzilla-tool:
1414         * Scripts/modules/patchcollection.py:
1415         * Scripts/modules/patchcollection_unittest.py:
1416
1417 2009-11-16  Eric Seidel  <eric@webkit.org>
1418
1419         Reviewed by Adam Barth.
1420
1421         bugzilla-tool needs a land-attachment command
1422         https://bugs.webkit.org/show_bug.cgi?id=31546
1423
1424         * Scripts/bugzilla-tool:
1425          - Move all the logic into AbstractLandingCommand and
1426            add a new LandAttachment command subclass.
1427          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1428
1429 2009-11-16  Eric Seidel  <eric@webkit.org>
1430
1431         Reviewed by Adam Barth.
1432
1433         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1434         https://bugs.webkit.org/show_bug.cgi?id=31543
1435
1436         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1437
1438         * Scripts/bugzilla-tool:
1439
1440 2009-11-16  Eric Seidel  <eric@webkit.org>
1441
1442         Reviewed by Adam Barth.
1443
1444         Disable the style queue from posting to the commit queue status page.
1445
1446         * Scripts/bugzilla-tool:
1447
1448 2009-11-16  Adam Barth  <abarth@webkit.org>
1449
1450         Reviewed by Eric Seidel.
1451
1452         Implement PatchCollection
1453         https://bugs.webkit.org/show_bug.cgi?id=31541
1454
1455         This class holds a set of patches and lets clients iterate through
1456         them.  Optionally, clients can install a filter.
1457
1458         * Scripts/modules/patchcollection.py: Added.
1459         * Scripts/modules/patchcollection_unittest.py: Added.
1460         * Scripts/run-webkit-unittests:
1461
1462 2009-11-16  Eric Seidel  <eric@webkit.org>
1463
1464         Reviewed by Adam Barth.
1465
1466         bugzilla-tool land-patches will close bugs with patches r=?
1467         https://bugs.webkit.org/show_bug.cgi?id=28230
1468
1469         The commit-queue shouldn't close patches with outstanding reviews on them,
1470         even if many reviewers seem to be against multi-patch bugs.
1471
1472         * Scripts/bugzilla-tool:
1473
1474 2009-11-16  Eric Seidel  <eric@webkit.org>
1475
1476         Reviewed by Adam Barth.
1477
1478         bugzilla-tool check-style should work with attachment ids instead of bug ids
1479         https://bugs.webkit.org/show_bug.cgi?id=31540
1480
1481         * Scripts/bugzilla-tool:
1482
1483 2009-11-16  Eric Seidel  <eric@webkit.org>
1484
1485         Reviewed by Adam Barth.
1486
1487         WorkQueue is the only place that should know about special exit codes
1488         https://bugs.webkit.org/show_bug.cgi?id=31534
1489
1490         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1491         and add tests for handling exit codes.
1492         I also cleaned up workqueue_unittest.py more.
1493
1494         * Scripts/bugzilla-tool:
1495         * Scripts/modules/workqueue.py:
1496         * Scripts/modules/workqueue_unittest.py:
1497
1498 2009-11-16  Eric Seidel  <eric@webkit.org>
1499
1500         Reviewed by Adam Barth.
1501
1502         Re-factor workqueue_unittest to allow for more than one test.
1503         https://bugs.webkit.org/show_bug.cgi?id=31535
1504
1505         * Scripts/modules/workqueue_unittest.py:
1506
1507 2009-11-16  Eric Seidel  <eric@webkit.org>
1508
1509         Reviewed by Adam Barth.
1510
1511         land-patches needs to be re-factored into smaller chunks
1512         https://bugs.webkit.org/show_bug.cgi?id=31532
1513
1514         * Scripts/bugzilla-tool: fix a couple obvious typos.
1515
1516 2009-11-16  Eric Seidel  <eric@webkit.org>
1517
1518         Reviewed by Adam Barth.
1519
1520         land-patches needs to be re-factored into smaller chunks
1521         https://bugs.webkit.org/show_bug.cgi?id=31532
1522
1523         The next patch will move these methods into WebKitLandingScripts.
1524
1525         * Scripts/bugzilla-tool:
1526          - Split out _land_patch and _close_bug_if_no_active_patches.
1527
1528 2009-11-16  Adam Barth  <abarth@webkit.org>
1529
1530         Reviewed by Eric Seidel.
1531
1532         Fix silly copy-and-paste code.  I am a terrible coder.
1533
1534         * Scripts/modules/bugzilla.py:
1535
1536 2009-11-16  Adam Barth  <abarth@webkit.org>
1537
1538         Reviewed by Eric Seidel.
1539
1540         Implement a StyleQueue
1541         https://bugs.webkit.org/show_bug.cgi?id=31537
1542
1543         The first iteration of the style queue only produces output locally.
1544         There is also a limit of 10 patches because it's not that useful to
1545         iterate through the entire review queue at this point.  We can remove
1546         the limit later.
1547
1548         * Scripts/bugzilla-tool:
1549         * Scripts/modules/bugzilla.py:
1550
1551 2009-11-16  Adam Barth  <abarth@webkit.org>
1552
1553         Reviewed by Eric Seidel.
1554
1555         Unit test WorkQueue
1556         https://bugs.webkit.org/show_bug.cgi?id=31531
1557
1558         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1559
1560         * Scripts/bugzilla-tool:
1561         * Scripts/modules/statusbot.py:
1562         * Scripts/modules/workqueue.py:
1563         * Scripts/modules/workqueue_unittest.py: Added.
1564         * Scripts/run-webkit-unittests:
1565
1566 2009-11-16  Eric Seidel  <eric@webkit.org>
1567
1568         Reviewed by Adam Barth.
1569
1570         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1571         https://bugs.webkit.org/show_bug.cgi?id=31530
1572
1573         * Scripts/bugzilla-tool:
1574
1575 2009-11-16  Eric Seidel  <eric@webkit.org>
1576
1577         Reviewed by Adam Barth.
1578
1579         bugzilla-tool needs apply-attachment
1580         https://bugs.webkit.org/show_bug.cgi?id=31528
1581
1582         * Scripts/bugzilla-tool:
1583          - Add ApplyAttachment command.
1584          - Abstract applying code into WebKitApplyingScripts.
1585          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1586         * Scripts/modules/bugzilla.py:
1587          - Add fetch_attachment and bug_id_for_attachment_id.
1588         * Scripts/modules/bugzilla_unittest.py:
1589          - Add test for new parsing.
1590          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1591
1592 2009-11-16  Eric Seidel  <eric@webkit.org>
1593
1594         Reviewed by Adam Barth.
1595
1596         Document check-style's use of force_clean.
1597
1598         * Scripts/bugzilla-tool:
1599         * Scripts/modules/scm.py:
1600
1601 2009-11-16  Adam Barth  <abarth@webkit.org>
1602
1603         Reviewed by Eric Seidel.
1604
1605         Move WorkQueue to its own file
1606         https://bugs.webkit.org/show_bug.cgi?id=31529
1607
1608         WorkQueue and WorkQueueDelegate are separate concerns from
1609         bugzilla-tool.  Also added a missing include to logging.py.
1610
1611         * Scripts/bugzilla-tool:
1612         * Scripts/modules/logging.py:
1613         * Scripts/modules/workqueue.py:
1614
1615 2009-11-16  Adam Barth  <abarth@webkit.org>
1616
1617         Reviewed by Eric Seidel.
1618
1619         Move OutputTee to logging.py.
1620
1621         * Scripts/bugzilla-tool:
1622         * Scripts/modules/logging.py:
1623
1624 2009-11-15  Adam Barth  <abarth@webkit.org>
1625
1626         Reviewed by Eric Seidel.
1627
1628         Refactor bugzilla-tool to allow for multiple queues
1629         https://bugs.webkit.org/show_bug.cgi?id=31513
1630
1631         Divide the commit queue class into three class to make creating
1632         additional queues easier.
1633
1634         * Scripts/bugzilla-tool:
1635
1636 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1637
1638         Reviewed by Eric Seidel.
1639
1640         svn-apply may not handle git patches created by bugzilla-tool
1641         https://bugs.webkit.org/show_bug.cgi?id=31457
1642
1643         * Scripts/modules/scm.py:
1644         * Scripts/modules/scm_unittest.py:
1645
1646 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1647
1648         Reviewed by Eric Seidel.
1649
1650         bugzilla-tool should post git binary diff
1651         https://bugs.webkit.org/show_bug.cgi?id=31458
1652
1653         Add --binary option to Git.create_patch.
1654
1655         * Scripts/modules/scm.py:
1656         * Scripts/modules/scm_unittest.py:
1657
1658 2009-11-15  Adam Barth  <abarth@webkit.org>
1659
1660         Reviewed by Darin Adler.
1661
1662         Add bugzilla-tool check-style
1663         https://bugs.webkit.org/show_bug.cgi?id=31515
1664
1665         * Scripts/bugzilla-tool:
1666         * Scripts/modules/bugzilla.py:
1667
1668 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1669
1670         Reviewed by Simon Hausmann.
1671
1672         Make the Qt Linux only --valgrind feature, suppress errors
1673         defined in the SuppressedValgrindErrors file.
1674
1675         * Scripts/run-webkit-tests:
1676
1677 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1678
1679         Reviewed by Simon Hausmann.
1680
1681         Set the locale to C and not to the current one in use on the system.
1682
1683         * DumpRenderTree/qt/DumpRenderTree.cpp:
1684         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1685
1686 2009-11-13  Adam Roben  <aroben@apple.com>
1687
1688         Add support for
1689         http/tests/security/isolatedWorld/didClearWindowObject.html
1690
1691         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1692         window objects in isolated worlds are cleared
1693
1694         Reviewed by Dave Hyatt.
1695
1696         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1697
1698         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1699         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1700         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1701         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1702         Added. Sets a __worldID property on the global object whose value is
1703         the ID of this world.
1704         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1705         Respond to this new delegate callback by calling through to one of the
1706         above new methods.
1707         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1708         (worldMap): Added. Returns a HashMap containing all the worlds we've
1709         created.
1710         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1711         haven't kept track of this world.
1712         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1713         instead of declaring our own.
1714
1715         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1716
1717         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1718         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1719         didClearWindowObjectForFrameInStandardWorld.
1720         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1721         Respond to this new delegate callback by calling through to one of the
1722         below new methods.
1723         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1724         Added. Sets a __worldID property on the gobal object whose value is
1725         the ID of this world.
1726         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1727         Added. Moved code here from didClearWindowObject.
1728
1729         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1730         didClearWindowObjectForFrame* functions.
1731
1732         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1733         (worldMap): Added. Returns a HashMap containing all the worlds we've
1734         created.
1735         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1736         haven't kept track of this world.
1737         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1738         instead of declaring our own.
1739
1740 2009-11-13  Adam Roben  <aroben@apple.com>
1741
1742         Finish replacing worldIDs with world objects
1743
1744         The only remaining use of worldIDs was in a method only used by DRT
1745         for the isolated worlds tests.
1746
1747         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1748
1749         Reviewed by Mark Rowe.
1750
1751         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1752         (LayoutTestController::evaluateScriptInIsolatedWorld):
1753         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1754         (LayoutTestController::evaluateScriptInIsolatedWorld):
1755         Updated for changes to WebFrame. Now holds the map of worldID -> world
1756         at this level instead of making WebKit do it.
1757
1758 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1759
1760         Reviewed by Simon Hausmann.
1761
1762         [Qt] Ensure the DRT does not output anything until first test is run
1763
1764         * DumpRenderTree/qt/DumpRenderTree.cpp:
1765         * DumpRenderTree/qt/DumpRenderTree.h:
1766
1767 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1768
1769         Reviewed by Tor Arne Vestbø.
1770
1771         Clear the undo stack in before each new test run.
1772
1773         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1774
1775         * DumpRenderTree/qt/DumpRenderTree.cpp:
1776         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1777
1778 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1779
1780         Reviewed by Kenneth Rohde Christiansen.
1781
1782         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1783
1784         * DumpRenderTree/qt/DumpRenderTree.cpp:
1785         (WebCore::WebPage::resetSettings):
1786         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1787         (LayoutTestController::overridePreference):
1788
1789 2009-11-13  Eric Seidel  <eric@webkit.org>
1790
1791         Reviewed by Adam Barth.
1792
1793         Update committers.py based on svn records
1794         https://bugs.webkit.org/show_bug.cgi?id=31366
1795
1796         This list was generated using validate-committer-lists from
1797         https://bugs.webkit.org/show_bug.cgi?id=30970
1798         and makes committers.py current for committers who have
1799         committed in the last 3 years.
1800
1801         * Scripts/modules/committers.py:
1802
1803 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1804
1805         Reviewed by Adam Barth.
1806
1807         The document-open.html test was flaky at times. The test invokes the layout test plugin
1808         which in its destroy stream handler opens a new document. This basically tears down the
1809         stream and the associated plugin instance. The pluginLog function in the layout test
1810         plugin attempts to retrieve the window script object on a torn down plugin instance
1811         which crashed consistently on windows in the debugger. The functions which issue
1812         these logs already have a valid window script object. We now have variants of the pluginLog
1813         function which take in a window script object with and without variable arguments. 
1814
1815         https://bugs.webkit.org/show_bug.cgi?id=31067
1816
1817         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1818         (pluginLogWithWindowObject):
1819         (pluginLogWithWindowObjectVariableArgs):
1820         (pluginLog):
1821         (notifyTestCompletion):
1822         (testDocumentOpen):
1823         (testWindowOpen):
1824
1825 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1826
1827         Reviewed by Gustavo Noronha Silva.
1828
1829         https://bugs.webkit.org/show_bug.cgi?id=30997
1830         [Gtk] Implemment AtkDocument
1831
1832         Added testing support.
1833
1834         * DumpRenderTree/AccessibilityUIElement.cpp:
1835         * DumpRenderTree/AccessibilityUIElement.h:
1836         (getDocumentEncodingCallback):
1837         (getDocumentURICallback):
1838         (AccessibilityUIElement::getJSClass):
1839         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1840         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1841         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1842         (AccessibilityUIElement::documentEncoding):
1843         (AccessibilityUIElement::documentURI):
1844
1845 2009-11-12  Adam Roben  <aroben@apple.com>
1846
1847         Replace worldIDs with world objects
1848
1849         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1850         user scripts/stylesheets and isolated worlds
1851
1852         Reviewed by Sam Weinig.
1853
1854         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1855         (LayoutTestController::addUserScript):
1856         (LayoutTestController::addUserStyleSheet):
1857         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1858         (LayoutTestController::addUserScript):
1859         (LayoutTestController::addUserStyleSheet):
1860         Changed these functions to create a new WebJSWorld each time they're
1861         called and to pass that world to WebKit.
1862
1863 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1864
1865         Reviewed by Oliver Hunt.
1866
1867         need to implement aria tree roles
1868         https://bugs.webkit.org/show_bug.cgi?id=31284
1869
1870         * DumpRenderTree/AccessibilityUIElement.cpp:
1871         (disclosedRowAtIndexCallback):
1872         (selectedRowAtIndexCallback):
1873         (isEqualCallback):
1874         (isAttributeSettableCallback):
1875         (isActionSupportedCallback):
1876         (disclosedByRowCallback):
1877         (hierarchicalLevelCallback):
1878         (AccessibilityUIElement::getJSClass):
1879         * DumpRenderTree/AccessibilityUIElement.h:
1880         (AccessibilityUIElement::isEqual):
1881         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1882         (AccessibilityUIElement::hierarchicalLevel):
1883         (AccessibilityUIElement::disclosedRowAtIndex):
1884         (AccessibilityUIElement::selectedRowAtIndex):
1885         (AccessibilityUIElement::disclosedByRow):
1886         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1887         (AccessibilityUIElement::getChildAtIndex):
1888         (AccessibilityUIElement::disclosedRowAtIndex):
1889         (AccessibilityUIElement::selectedRowAtIndex):
1890         (AccessibilityUIElement::titleUIElement):
1891         (AccessibilityUIElement::parentElement):
1892         (AccessibilityUIElement::disclosedByRow):
1893         (AccessibilityUIElement::hierarchicalLevel):
1894         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1895         (AccessibilityUIElement::hierarchicalLevel):
1896         (AccessibilityUIElement::disclosedRowAtIndex):
1897         (AccessibilityUIElement::selectedRowAtIndex):
1898         (AccessibilityUIElement::disclosedByRow):
1899
1900 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1901
1902         Reviewed by Darin Adler.
1903
1904         svn-apply can not handle git binary diffs
1905         https://bugs.webkit.org/show_bug.cgi?id=26830
1906
1907         Support "literal" type git binary diffs.
1908
1909         * Scripts/VCSUtils.pm:
1910         * Scripts/modules/scm_unittest.py:
1911         * Scripts/svn-apply:
1912
1913 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1914
1915         Not reviewed, removing duplicate entry for myself in committers.py.
1916
1917         * Scripts/modules/committers.py:
1918
1919 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1920
1921         Reviewed by Darin Adler and Mark Rowe.
1922
1923         https://bugs.webkit.org/show_bug.cgi?id=31200
1924         Tests in http/tests/security/mixedContent start to fail when new tests are added
1925
1926         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1927
1928 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1929
1930         Reviewed by Jan Alonzo.
1931
1932         Create, and display a window for the inspector, for inspector
1933         tests.
1934
1935         Need to also show/hide the inspector window to avoid having
1936         problems with code assuming it is realized
1937         https://bugs.webkit.org/show_bug.cgi?id=31347
1938
1939         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1940         (webInspectorShowWindow):
1941         (webInspectorCloseWindow):
1942         (webInspectorInspectWebView):
1943         (createWebView):
1944
1945 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1946
1947         Unreviewed Qt buildbot fix.
1948
1949         My previous fix was wrong, so revert that change and fix it by
1950         returning when the document of the frame has no document element.
1951         Idea is borrowed from mac and win DRT.
1952
1953         * DumpRenderTree/qt/DumpRenderTree.cpp:
1954         (WebCore::DumpRenderTree::dumpFramesAsText):
1955
1956 2009-11-11  Eric Seidel  <eric@webkit.org>
1957
1958         Reviewed byg Kenneth Rohde Christiansen.
1959
1960         Update Kenneth's committer record to include the email he
1961         uses on lists.webkit.org.
1962
1963         * Scripts/modules/committers.py:
1964
1965 2009-11-11  Eric Seidel  <eric@webkit.org>
1966
1967         Reviewed by Gustavo Noronha Silva.
1968
1969         Several committers use separate email addresses for bugzilla and svn.webkit.org
1970         https://bugs.webkit.org/show_bug.cgi?id=31364
1971
1972         Update records for existing committers to include email addresses
1973         used in svn.webkit.org and lists.webkit.org.
1974         Most committers use the same email address in all 3 places, but some use
1975         separate addresses.  committers.py needs record of each of these addresses.
1976
1977         * Scripts/modules/committers.py:
1978
1979 2009-11-11  Eric Seidel  <eric@webkit.org>
1980
1981         No review, adding second email address for an existing committer.
1982
1983         Add Yong Li's second bugzilla account to his committer record.
1984         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1985
1986         * Scripts/modules/committers.py:
1987
1988 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1989
1990         Reviewed by Simon Hausmann.
1991
1992         If the frame has no innerText don't append it, and
1993         do not add a newline which breaks some cross platform
1994         results.
1995
1996         * DumpRenderTree/qt/DumpRenderTree.cpp:
1997         (WebCore::DumpRenderTree::dumpFramesAsText):
1998
1999 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2000
2001         Reviewed by Simon Hausmann.
2002
2003         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
2004
2005         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2006         (webkit_test_plugin_new_instance):
2007         (webkit_test_plugin_destroy_instance):
2008         (webkit_test_plugin_destroy_stream):
2009
2010 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2011
2012         Reviewed by Mark Rowe.
2013
2014         Implement the functionality needed by plugins/window-open.html
2015
2016         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2017         (webkit_test_plugin_new_instance):
2018         (webkit_test_plugin_set_window):
2019
2020 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2021
2022         Reviewed by Simon Hausmann.
2023
2024         [Qt] Force -graphicssystem raster and -style windows when running DRT
2025
2026         * DumpRenderTree/qt/main.cpp:
2027         * Scripts/run-webkit-tests:
2028
2029 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2030
2031         Reviewed by Simon Hausmann.
2032
2033         Compute correct library paths for Qt
2034
2035         * Scripts/webkitdirs.pm:
2036
2037 2009-11-10  Mark Rowe  <mrowe@apple.com>
2038
2039         Reviewed by Sam Weinig.
2040
2041         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
2042
2043         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
2044         about the validity of the self-signed certificates used in the regression tests.  We would then add the
2045         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
2046         that had enabled frame load delegate logging this would result in extra log messages being generated,
2047         causing the test to fail.
2048
2049         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
2050         tests.
2051
2052         * DumpRenderTree/mac/DumpRenderTree.mm:
2053         (dumpRenderTree):
2054         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2055         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2056
2057 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2058
2059         Reviewed by Kenneth Rohde Christiansen.
2060
2061         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
2062
2063         * DumpRenderTree/qt/DumpRenderTree.cpp:
2064         (WebCore::DumpRenderTree::DumpRenderTree):
2065
2066 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2067
2068         Reviewed by Jan Alonzo.
2069
2070         [GTK] Remove WebSocket configuration from WebKitWebSettings
2071         https://bugs.webkit.org/show_bug.cgi?id=31244
2072
2073         Follow-up of r50724. Don't set the enable-web-socket property
2074         anymore.
2075
2076         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2077         (resetDefaultsToConsistentValues):
2078
2079 2009-11-10  Oliver Hunt  <oliver@apple.com>
2080
2081         Reviewed by Maciej Stachowiak.
2082
2083         Rename 3D Canvas related classes to use WebGL prefix
2084         https://bugs.webkit.org/show_bug.cgi?id=29095
2085
2086         Checkin new version of do-webcore-rename used to do the WebGL type rename,
2087         and upate webkitdirs script to new method of testing for WebGL.
2088
2089         * Scripts/do-webcore-rename:
2090         * Scripts/webkitdirs.pm:
2091
2092 2009-11-09  Oliver Hunt  <oliver@apple.com>
2093
2094         Reviewed by Geoff Garen.
2095
2096         Make do-webcore-rename work with git.
2097
2098         * Scripts/do-webcore-rename:
2099
2100 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2101
2102         Adding Kenneth to the reviewers list.
2103
2104         * Scripts/modules/committers.py:
2105
2106 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2107
2108         Reviewed by Jan Alonzo.
2109
2110         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2111         https://bugs.webkit.org/show_bug.cgi?id=30482
2112
2113         LayoutTestControllerGtk now uses the exposed
2114         Page::tabKeyCyclesThroughElements API
2115
2116         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2117         (LayoutTestController::setTabKeyCyclesThroughElements):
2118
2119 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
2120
2121         Reviewed by Holger Freyther.
2122
2123         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
2124         This helps to pass the test case below. Also replaced hardcoded
2125         code numbers with defined constants.
2126         https://bugs.webkit.org/show_bug.cgi?id=31185
2127         
2128         Test: editing/undo/undo-deleteWord.html
2129
2130         * DumpRenderTree/qt/EventSenderQt.cpp:
2131         (EventSender::keyDown):
2132
2133 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
2134
2135         Reviewed by Holger Freyther.
2136
2137         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
2138         https://bugs.webkit.org/show_bug.cgi?id=31164
2139
2140         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
2141
2142         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2143         (LayoutTestController::processWork):
2144
2145 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
2146
2147         Reviewed by Holger Freyther.
2148
2149         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
2150         https://bugs.webkit.org/show_bug.cgi?id=31158
2151
2152         By invoking a script queue'd by queueScript(), 'true' was beeing returned
2153         always, which from WorkQueue prospective means that a load has been started
2154         and the queue processing should stop and wait for the load to finish.
2155         Spinning it off into a loading and a non-loading variants was the solution
2156         adopted by Mac's DRT to work around this problem. The former keeps returning
2157         'true' while the later executes the script synchronously and returns 'false'
2158         making it possible to the WorkQueue to proceed right away.
2159
2160         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2161         (LayoutTestController::processWork):
2162         (LayoutTestController::queueLoadingScript):
2163         (LayoutTestController::queueNonLoadingScript):
2164         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2165         * DumpRenderTree/qt/WorkQueueItem.h:
2166         (LoadingScriptItem::LoadingScriptItem):
2167         (LoadingScriptItem::invoke):
2168         (NonLoadingScriptItem::NonLoadingScriptItem):
2169         (NonLoadingScriptItem::invoke):
2170
2171 2009-11-07  Mark Rowe  <mrowe@apple.com>
2172
2173         Rubber-stamped by Cameron Zwarich.
2174
2175         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
2176
2177         * Scripts/commit-log-editor:
2178
2179 2009-11-07  Mark Rowe  <mrowe@apple.com>
2180
2181         Reviewed by Darin Adler.
2182
2183         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
2184         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
2185
2186         Move logic for determining the name and email address to use in a ChangeLog entry from
2187         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
2188         whether the author of the patch matches committer, and therefore needs access to the
2189         email address that would be used in a ChangeLog entry.
2190
2191         Based on a patch by Pierre d'Herbemont.
2192
2193         * Scripts/VCSUtils.pm:
2194         * Scripts/commit-log-editor:
2195         * Scripts/prepare-ChangeLog:
2196         * Scripts/webkitdirs.pm:
2197
2198 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2199
2200         Reviewed by Adam Barth.
2201
2202         Added functionality to the layout test plugin to invoke document.open and
2203         window.open with default arguments. The associated webkit bug is
2204         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
2205         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
2206         work in Chromium (V8) if there is no calling javascript context. To achieve this
2207         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
2208         for the window.open test case and in NPP_DestroyStream for the document.open test case.
2209
2210         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2211         (testDocumentOpen):
2212         (testWindowOpen):
2213         (pluginAllocate):
2214         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2215         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2216         (NPP_New):
2217         (NPP_SetWindow):
2218         (NPP_DestroyStream):
2219         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2220         (NPP_New):
2221         (NPP_SetWindow):
2222         (NPP_NewStream):
2223         (NPP_DestroyStream):
2224
2225 2009-11-06  Eric Seidel  <eric@webkit.org>
2226
2227         Reviewed by Adam Barth.
2228
2229         bugzilla-tool crashed with exception
2230         https://bugs.webkit.org/show_bug.cgi?id=31092
2231
2232         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
2233
2234 2009-11-04  Eric Seidel  <eric@webkit.org>
2235
2236         No review, just add a line which got left out of the patch uploaded for commit.
2237
2238         commit-queue is crashing when trying to reject patches after unknown failures
2239         https://bugs.webkit.org/show_bug.cgi?id=31091
2240
2241         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
2242
2243 2009-11-04  Adam Roben  <aroben@apple.com>
2244
2245         Remove bogus else clause in bugzilla-tool
2246
2247         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
2248         create-bug raises exception after entering bug description
2249
2250         Reviewed by David Kilzer.
2251
2252         * Scripts/bugzilla-tool:
2253         (CreateBug): else clauses are only hit if no exception is raised, so
2254         it makes no sense to try to re-raise the exception in an else clause.
2255         The exception will automatically be re-raised if it doesn't match any
2256         of the except clauses, so we don't have to do anything special here at
2257         all to get the desired behavior.
2258
2259 2009-11-04  Eric Seidel  <eric@webkit.org>
2260
2261         Reviewed by David Kilzer.
2262
2263         svn-apply's fixChangeLogPatch function seems broken
2264         https://bugs.webkit.org/show_bug.cgi?id=30683
2265
2266         Update fixChangeLogPatch to be able to handle patches which
2267         don't start at line 1.
2268         Add unit tests for svn-apply to scm_unittest.py.
2269
2270         * Scripts/VCSUtils.pm:
2271         * Scripts/modules/scm_unittest.py:
2272
2273 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
2274
2275         Reviewed by Beth Dakin.
2276
2277         Need to implement ARIA role="combobox"
2278         https://bugs.webkit.org/show_bug.cgi?id=31096
2279
2280         * DumpRenderTree/AccessibilityUIElement.cpp:
2281         (showMenuCallback):
2282         (getIsExpandedCallback):
2283         (AccessibilityUIElement::getJSClass):
2284         * DumpRenderTree/AccessibilityUIElement.h:
2285         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2286         (AccessibilityUIElement::isExpanded):
2287         (AccessibilityUIElement::showMenu):
2288         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2289         (AccessibilityUIElement::isExpanded):
2290         (AccessibilityUIElement::showMenu):
2291         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2292         (AccessibilityUIElement::isSelected):
2293         (AccessibilityUIElement::isExpanded):
2294         (AccessibilityUIElement::showMenu):
2295
2296 2009-11-04  Eric Seidel  <eric@webkit.org>
2297
2298         Reviewed by Adam Barth.
2299
2300         commit-queue is crashing when trying to reject patches after unknown failures
2301         https://bugs.webkit.org/show_bug.cgi?id=31091
2302
2303         * Scripts/bugzilla-tool:
2304          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
2305            so we have to find out what the current patch is by asking bugzilla again.
2306          - Discovered that this code was also leaking file descriptors, so fixed that.
2307
2308 2009-11-04  Adam Roben  <aroben@apple.com>
2309
2310         Make run-webkit-tests work for the Debug_Internal Windows
2311         configuration
2312
2313         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2314         suffix.
2315
2316         Fixes <http://webkit.org/b/31123>.
2317
2318         Reviewed by Sam Weinig.
2319
2320         * Scripts/run-webkit-tests: Don't add the _debug suffix in
2321         Debug_Internal, either.
2322
2323 2009-11-04  Eric Seidel  <eric@webkit.org>
2324
2325         Reviewed by Adam Barth.
2326
2327         committers.py needs a way to store non-bugzilla email addresses
2328         https://bugs.webkit.org/show_bug.cgi?id=31037
2329
2330         Make Committer and Reviewer constructors take a single email or a list of emails.
2331         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2332         Expose reviewers(), used by validate-committer-lists on bug 30970.
2333
2334         * Scripts/modules/committers.py:
2335         * Scripts/modules/committers_unittest.py: Added tests for the new code.
2336
2337 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2338
2339         Reviewed by David Levin.
2340
2341         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2342         https://bugs.webkit.org/show_bug.cgi?id=27491
2343
2344         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2345         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2346
2347         Functions to start or stop Web Socket servers are added.
2348
2349         * Scripts/run-webkit-tests:
2350
2351 2009-11-03  Eric Seidel  <eric@webkit.org>
2352
2353         No review, just changing wording of log message.
2354
2355         Change log string to say "failed" instead of "rejected"
2356         when a commit fails due to an out of date checkout.
2357         This makes grepping the commit-queue log for rejected patches easier.
2358
2359         * Scripts/bugzilla-tool:
2360
2361 2009-11-03  Eric Seidel  <eric@webkit.org>
2362
2363         No review, adding commonly known committers missing from the file.
2364
2365         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2366
2367 2009-11-03  Eric Seidel  <eric@webkit.org>
2368
2369         No review, just sort-order cleanup.
2370
2371         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2372
2373 2009-11-03  Stephen White  <senorblanco@chromium.org>
2374
2375         (Unreviewed).
2376
2377         Add myself to committers.py.
2378
2379         * Scripts/modules/committers.py:
2380
2381 2009-11-03  Robin Dunn  <robin@alldunn.com>
2382
2383         Reviewed by Kevin Ollviier.
2384
2385         Add packaging scripts for Debian-based Linux distros.
2386         
2387         https://bugs.webkit.org/show_bug.cgi?id=31075
2388
2389         * wx/packaging/build-debian-installer.py: Added.
2390         * wx/packaging/debian: Added.
2391
2392 2009-11-03  Dan Bernstein  <mitz@apple.com>
2393
2394         Reviewed by Anders Carlsson and Beth Dakin.
2395
2396         https://bugs.webkit.org/show_bug.cgi?id=31070
2397
2398         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2399         destroyed, it executes the value of the 'ondestroy' parameter as a
2400         script.
2401
2402         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2403         (pluginAllocate): Initialize onDestroy.
2404         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2405         onDestroy.
2406         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2407         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2408         specified.
2409         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2410
2411 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2412
2413         Reviewed by Xan Lopez.
2414
2415         https://bugs.webkit.org/show_bug.cgi?id=31035
2416         [GTK] some accessibility tests hitting assertion in debug builds
2417
2418         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2419
2420         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2421         (AccessibilityController::rootElement):
2422
2423 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2424
2425         Reviewed by Beth Dakin.
2426
2427         Support ARIA "tab" roles
2428         https://bugs.webkit.org/show_bug.cgi?id=30842
2429
2430         * DumpRenderTree/AccessibilityUIElement.cpp:
2431         * DumpRenderTree/AccessibilityUIElement.h:
2432         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2433         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2434         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2435
2436 2009-11-01  Eric Seidel  <eric@webkit.org>
2437
2438         Reviewed by David Levin.
2439
2440         buildbots should use --exit-after-N-failures
2441         https://bugs.webkit.org/show_bug.cgi?id=30809
2442
2443         Make the bots exit after 20 failures to prevent never-ending
2444         test runs where every test spends a minute crashing.
2445
2446         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2447
2448 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2449
2450         Reviewed by Eric Seidel.
2451
2452         Turn on warnings for QtWebKit for gcc
2453         https://bugs.webkit.org/show_bug.cgi?id=30958
2454
2455         * DumpRenderTree/qt/main.cpp: 
2456         (crashHandler): Mark function NO_RETURN
2457
2458 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2459
2460         Adding myself to the committers list.
2461
2462         * Scripts/modules/committers.py:
2463
2464 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2465
2466         Fix an issue that Adam noticed in DRT.
2467
2468         Reviewed by Darin Adler.
2469
2470         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2471         (AccessibilityUIElement::role):
2472         Get the length of the role text, and create a buffer dynamically.
2473
2474 2009-10-30  Eric Seidel  <eric@webkit.org>
2475
2476         No review, rolling out r50105.
2477         http://trac.webkit.org/changeset/50105
2478
2479         This commit was causing:
2480         https://bugs.webkit.org/show_bug.cgi?id=30869
2481         We'll re-implement the feature a different way.
2482
2483         * Scripts/bugzilla-tool:
2484
2485 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2486
2487         Test for MSAA: Accessibility of headings is not correct
2488
2489         https://bugs.webkit.org/show_bug.cgi?id=30937
2490
2491         Reviewed by Adam Roben.
2492
2493         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2494         (AccessibilityUIElement::role):
2495         Allow the role returned to be a BSTR.
2496         (AccessibilityUIElement::description):
2497         Fix a copy/paste error.
2498
2499 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2500
2501         Test for MSAA: Accessibility of links is wrong
2502
2503         https://bugs.webkit.org/show_bug.cgi?id=30928
2504
2505         Reviewed by Darin Adler.
2506
2507         * DumpRenderTree/AccessibilityUIElement.cpp:
2508         (getAccessibilityValueCallback):
2509         Return the accessibility value.
2510         (AccessibilityUIElement::getJSClass):
2511         Added "accessibilityValue" value.
2512
2513         * DumpRenderTree/AccessibilityUIElement.h:
2514
2515         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2516         (AccessibilityUIElement::accessibilityValue):
2517         Stubbed.
2518
2519         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2520         (AccessibilityUIElement::accessibilityValue):
2521         Stubbed.
2522
2523         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2524         (AccessibilityUIElement::accessibilityValue):
2525         Get the object's value, and return it as a JS string.
2526
2527 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2528
2529         Fix typo in command name used by wx build system.
2530
2531         * wx/build/build_utils.py:
2532
2533 2009-10-30  Adam Barth  <abarth@webkit.org>
2534
2535         Reviewed by Darin Adler.
2536
2537         Patch v1 is a dumb default name for patches
2538         https://bugs.webkit.org/show_bug.cgi?id=30952
2539
2540         Let's use "Patch" instead.
2541
2542         * Scripts/bugzilla-tool:
2543
2544 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2545
2546         Unreviewed trivial buildfix.
2547
2548         [Qt] Buildfix for r50333.
2549
2550         * DumpRenderTree/qt/DumpRenderTree.pro:
2551
2552 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2553
2554         Reviewed by Holger Freyther.
2555
2556         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2557         https://bugs.webkit.org/show_bug.cgi?id=30953
2558
2559         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2560         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2561         makes qt DRT to share this implementation (as gtk and mac ports do).
2562
2563         * DumpRenderTree/qt/DumpRenderTree.pro:
2564         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2565         * DumpRenderTree/qt/WorkQueue.h: Removed.
2566
2567 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2568
2569         Unreviewed potential buildbot fix.
2570
2571         Second try: Reset page history before running each test.
2572
2573         Apparently the QWebHistory::clear() keeps the current page
2574         in history which is not what we want, so we not additionally
2575         sets the history capacity to 0 (forces removing everything)
2576         and then sets it back to its original value.
2577
2578         * DumpRenderTree/qt/DumpRenderTree.cpp:
2579         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2580
2581 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2582
2583         Unreviewed potential buildbot fix.
2584
2585         Reset page history before running each test.
2586
2587         * DumpRenderTree/qt/DumpRenderTree.cpp:
2588         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2589
2590 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2591
2592         Reviewed by Eric Seidel.
2593
2594         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2595
2596         Bug 28420 -  Implement HTML5 <ruby> rendering
2597         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2598
2599         No new tests (no functional change).
2600
2601         * Scripts/build-webkit:
2602
2603 2009-10-29  Dan Bernstein  <mitz@apple.com>
2604
2605         Reviewed by Mark Rowe.
2606
2607         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2608         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2609         define it.
2610
2611         * Scripts/VCSUtils.pm:
2612         * Scripts/svn-apply:
2613         * Scripts/svn-unapply:
2614
2615 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2616
2617         Reviewed by Gustavo Noronha.
2618
2619         Use the GTK+ main loop instead of rolling our own mini-version of
2620         it.
2621
2622         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2623         (dump):
2624         (runTest):
2625         (webViewLoadFinished):
2626
2627 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2628
2629         Reviewed by Oliver Hunt.
2630
2631         Implement the Qt version of DRT dumpBackForwardList().
2632
2633         * DumpRenderTree/qt/DumpRenderTree.cpp:
2634         (WebCore::dumpHistoryItem):
2635         (WebCore::DumpRenderTree::dumpBackForwardList):
2636
2637 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2638
2639         Reviewed by Adam Roben.
2640
2641         Implement DRT functionality for Qt introduced in
2642         r28690 and r28705.
2643
2644         - Implemented pathToLocalResource which exposes the functionality of
2645         converting a given unix path to the correct location on Windows.
2646         - Implemented a way to remove machine-dependent information from paths
2647         in layout test results.
2648
2649         * DumpRenderTree/qt/DumpRenderTree.cpp:
2650         (WebCore::urlSuitableForTestResult):
2651         (WebCore::WebPage::javaScriptConsoleMessage):
2652         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2653         (LayoutTestController::pathToLocalResource):
2654         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2655
2656 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2657
2658         Adding myself to the committers list.
2659
2660         * Scripts/modules/committers.py:
2661
2662 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2663
2664         Adding myself to the committers list.
2665
2666         * Scripts/modules/committers.py:
2667
2668 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2669
2670         Reviewed by Jan Alonzo.
2671
2672         [GTK] API to start inspector for a WebView
2673         https://bugs.webkit.org/show_bug.cgi?id=22551
2674
2675         Use the new inspector API to implement the LayoutTestController
2676         interfaces used to test the inspector.
2677
2678         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2679         (webInspectorInspectWebView):
2680         (createWebView):
2681         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2682         (LayoutTestController::showWebInspector):
2683         (LayoutTestController::closeWebInspector):
2684         (LayoutTestController::evaluateInWebInspector):
2685
2686 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2687
2688         Reviewed by Eric Seidel.
2689
2690         [Qt] WebFrame::counterValueForElementById must not be exposed
2691         https://bugs.webkit.org/show_bug.cgi?id=30882
2692
2693         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2694         (LayoutTestController::counterValueForElementById):
2695
2696 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2697
2698         Rubberstamped by Oliver Hunt.
2699
2700         Fix the warning:
2701
2702         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2703         declared with attribute warn_unused_result".
2704
2705         by actually checking the result. In the case it is null, an
2706         error has occoured, so treat it as the other fatal errors.
2707
2708         * DumpRenderTree/qt/DumpRenderTree.cpp:
2709         (WebCore::DumpRenderTree::initializeFonts):
2710
2711 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2712
2713         Reviewed by Darin Adler.
2714
2715         Provide a way to get counter values with layoutTestContoller
2716         https://bugs.webkit.org/show_bug.cgi?id=30555
2717
2718         Define layoutTestContoller.counterValueForElementById.
2719
2720         * DumpRenderTree/LayoutTestController.cpp:
2721         (counterValueForElementByIdCallback):
2722         (LayoutTestController::staticFunctions):
2723         * DumpRenderTree/LayoutTestController.h:
2724         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2725         (LayoutTestController::counterValueForElementById):
2726
2727 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2728
2729         Rubberstamped by Oliver Hunt.
2730
2731         Change two methods to be internal for DRT use only.
2732
2733         Part of [Qt] Review all new API in Qt 4.6
2734         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2735
2736         * DumpRenderTree/qt/DumpRenderTree.cpp:
2737         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2738         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2739         (LayoutTestController::whiteListAccessFromOrigin):
2740
2741 2009-10-27  Eric Seidel  <eric@webkit.org>
2742
2743         Reviewed by Adam Barth.
2744
2745         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2746         https://bugs.webkit.org/show_bug.cgi?id=30826
2747
2748         * Scripts/svn-apply:
2749          - Add () around all system() calls.
2750          - Use the correct system() == 0 or die instead of system() or die
2751          - Add descriptive messages to all die statements.
2752
2753 2009-10-27  Steve Block  <steveblock@google.com>
2754
2755         Reviewed by NOBODY.
2756
2757         Adds steveblock@google.com to list of committers.
2758
2759         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2760
2761 2009-10-27  Eric Seidel  <eric@webkit.org>
2762
2763         Reviewed by Adam Barth.
2764
2765         svn-apply can exit(0) even on patch failure
2766         https://bugs.webkit.org/show_bug.cgi?id=29622
2767
2768         * Scripts/svn-apply:
2769          - Add a bunch of "or die" statements, hopefully catching all
2770            possible cases where failure could still exit(0).
2771
2772 2009-10-27  Eric Seidel  <eric@webkit.org>
2773
2774         Reviewed by Adam Barth.
2775
2776         svn-* scripts should share code through VCSUtils.pm
2777         https://bugs.webkit.org/show_bug.cgi?id=30791
2778
2779         Just moving code into a shared location.
2780
2781         * Scripts/VCSUtils.pm:
2782         * Scripts/prepare-ChangeLog:
2783         * Scripts/resolve-ChangeLogs:
2784         * Scripts/svn-apply:
2785         * Scripts/svn-create-patch:
2786         * Scripts/svn-unapply:
2787         * Scripts/update-webkit:
2788
2789 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2790
2791         Suppress a huge number of MSVC warnings when building wxWebKit.
2792
2793         * wx/build/settings.py:
2794
2795 2009-10-26  Eric Seidel  <eric@webkit.org>
2796
2797         No review, just adding Mike Belshe to the committers list.
2798
2799         * Scripts/modules/committers.py:
2800
2801 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2802
2803         Reviewed by Darin Adler.
2804
2805         Make .rc files compile on Windows without depending on MFC headers
2806         https://bugs.webkit.org/show_bug.cgi?id=30750
2807
2808         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2809         windows.h instead of afxres.h because it exists even when MFC is not 
2810         installed, and is all that's needed here.
2811
2812         * FindSafari/FindSafari.rc: Ditto
2813
2814 2009-10-24  Eric Seidel  <eric@webkit.org>
2815
2816         Reviewed by Adam Barth.
2817
2818         bugzilla-tool post-diff should know how to mark commit-queue=?
2819         https://bugs.webkit.org/show_bug.cgi?id=29202
2820
2821         * Scripts/bugzilla-tool:
2822          - Add --commit-queue option to post-diff, post-commits and create-bug.
2823         * Scripts/modules/bugzilla.py:
2824          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2825          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2826
2827 2009-10-23  Eric Seidel  <eric@webkit.org>
2828
2829         Reviewed by Adam Barth.
2830
2831         bugzilla-tool commit-queue does not notice modifications to committers.py
2832         https://bugs.webkit.org/show_bug.cgi?id=30084
2833
2834         * Scripts/bugzilla-tool:
2835          - Make commit-queue re-exec itself instead of using while(1).
2836          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2837          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2838
2839 2009-10-22  Eric Seidel  <eric@webkit.org>
2840
2841         Reviewed by Adam Barth.
2842
2843         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2844         https://bugs.webkit.org/show_bug.cgi?id=30634
2845
2846         * Scripts/bugzilla-tool:
2847          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2848          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2849
2850 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2851
2852         Reviewed by Eric Seidel.
2853
2854         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2855
2856         https://bugs.webkit.org/show_bug.cgi?id=30763
2857
2858         * pywebsocket/mod_pywebsocket/__init__.py:
2859         * pywebsocket/mod_pywebsocket/dispatch.py:
2860         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2861         * pywebsocket/mod_pywebsocket/standalone.py:
2862         * pywebsocket/setup.py:
2863         * pywebsocket/test/test_dispatch.py:
2864
2865 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2866
2867         Reviewed by David Levin.
2868
2869         REGRESSION: 2 failures in run-webkit-unittests
2870         https://bugs.webkit.org/show_bug.cgi?id=30645
2871
2872         * Scripts/modules/cpp_style_unittest.py:
2873         Fixed a few test scenarios which apparently lost some spaces from 
2874         text literals.
2875
2876 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2877
2878         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2879
2880         * Scripts/webkitdirs.pm:
2881
2882 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2883
2884         Reviewed by Darin Adler.
2885
2886         Unification of using null device in perl scripts.
2887         https://bugs.webkit.org/show_bug.cgi?id=30572
2888
2889         * Scripts/VCSUtils.pm:
2890         * Scripts/bisect-builds:
2891         * Scripts/resolve-ChangeLogs:
2892         * Scripts/run-iexploder-tests:
2893         * Scripts/run-jsc:
2894         * Scripts/run-mangleme-tests:
2895         * Scripts/run-webkit-tests:
2896         * Scripts/webkitdirs.pm:
2897         Using File::Spec->devnull() instead of hard coded /dev/null.
2898
2899 2009-10-26  Eric Seidel  <eric@webkit.org>
2900
2901         Reviewed by Holger Freyther.
2902
2903         Reviewers are missing from committers.py
2904         https://bugs.webkit.org/show_bug.cgi?id=30733
2905
2906         * Scripts/modules/committers.py:
2907
2908 2009-10-23  Eric Seidel  <eric@webkit.org>
2909
2910         No review, only adding Alice to the list of reviewers.
2911
2912         * Scripts/modules/committers.py:
2913
2914 2009-10-23  Eric Seidel  <eric@webkit.org>
2915
2916         Reviewed by Eric Carlson.
2917
2918         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2919         https://bugs.webkit.org/show_bug.cgi?id=30700
2920
2921         * DumpRenderTree/mac/DumpRenderTree.mm:
2922         (resetDefaultsToConsistentValues): Update QuickTime version check.
2923
2924 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2925
2926         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2927         character measurement APIs that are private on Tiger.
2928
2929         * wx/build/settings.py:
2930
2931 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2932
2933         Reviewed by NOBODY (build fix).
2934         Build fix following bug #30696.
2935
2936         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2937         (LayoutTestController::evaluateScriptInIsolatedWorld):
2938
2939 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2940
2941         Reviewed by Sam Weinig & Geoff Garen.
2942
2943         https://bugs.webkit.org/show_bug.cgi?id=30696
2944         Enable isolated-worlds tests on mac.
2945
2946         Add private interface for DRT to invoke execution in a given world.
2947
2948         * DumpRenderTree/LayoutTestController.cpp:
2949         (evaluateScriptInIsolatedWorldCallback):
2950         (LayoutTestController::staticFunctions):
2951         * DumpRenderTree/LayoutTestController.h:
2952         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2953         (LayoutTestController::evaluateScriptInIsolatedWorld):
2954         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2955         (LayoutTestController::evaluateScriptInIsolatedWorld):
2956
2957 2009-10-21  Eric Seidel  <eric@webkit.org>
2958
2959         Reviewed by Adam Barth.
2960
2961         bugzilla-tool's "patch failed to download an apply" error should give more information
2962         https://bugs.webkit.org/show_bug.cgi?id=30632
2963
2964         * Scripts/modules/scm.py:
2965          - Use the common run_command method instead of custom POpen code.
2966          - Make run_command know how to take pipes as input.
2967         * Scripts/modules/scm_unittest.py:
2968          - Add new tests to cover change.
2969          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2970
2971 2009-10-21  Kent Tamura  <tkent@chromium.org>
2972
2973         Unreviewed.  Adding myself to the committers list.
2974
2975         * Scripts/modules/committers.py:
2976
2977 2009-10-21  Robin Dunn  <robin@alldunn.com>
2978
2979         Reviewed by Kevin Ollivier.
2980
2981         Update the Windows installer builder to work with Vista / Win 7 and with git.
2982         
2983         https://bugs.webkit.org/show_bug.cgi?id=30649
2984
2985         * wx/build/build_utils.py:
2986         * wx/packaging/build-mac-installer.py:
2987         * wx/packaging/build-win-installer.py:
2988         * wx/packaging/wxWebKitInstaller.iss.in:
2989
2990 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2991
2992         Reviewed by Gustavo Noronha.
2993
2994         [GTK] Added conditional code to avoid using
2995         gdk_window_get_root_coords if we do not have a gtk+ release newer
2996         than 2.17.3.
2997         https://bugs.webkit.org/show_bug.cgi?id=30636
2998
2999         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3000
3001 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
3002
3003         Reviewed by Eric Seidel.
3004
3005         [Qt] Added dummy implementation for keepWebHistory()
3006         https://bugs.webkit.org/show_bug.cgi?id=30592
3007
3008         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3009         (LayoutTestController::keepWebHistory):
3010         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3011
3012 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3013
3014         Reviewed by Xan Lopez.
3015
3016         [GTK] Fixed the double click condition, it is not double click if
3017         we move in just in one direction.
3018         https://bugs.webkit.org/show_bug.cgi?id=30636
3019
3020         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3021
3022 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3023
3024         Reviewed by Xan Lopez.
3025
3026         [GTK] Initialize the events completly before emitting them.
3027         https://bugs.webkit.org/show_bug.cgi?id=30633
3028
3029         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3030
3031 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3032
3033         wx build fix. Fix for when linking using --as-needed with gcc.
3034
3035         * wx/browser/wscript:
3036
3037 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3038
3039         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
3040         to support all the features used by CURL backend.
3041         
3042         * wx/build/settings.py:
3043         * wx/install-unix-extras:
3044
3045 2009-10-20  Anton Muhin  <antonm@chromium.org>
3046
3047         Reviewed by Adam Barth.
3048
3049         Add {ager,antonm,yurys}@chromium.org into committers.py
3050         https://bugs.webkit.org/show_bug.cgi?id=30560
3051
3052         * Scripts/modules/committers.py:
3053
3054 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3055
3056         Reviewed by Tor Arne Vestbø.
3057
3058         Make the Netscape Test plugin available to the Qt launcher.
3059
3060         * Scripts/run-launcher:
3061
3062 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
3063
3064         Reviewed by David Levin.
3065
3066         Removed WebSocket runtime settings.
3067         https://bugs.webkit.org/show_bug.cgi?id=29896
3068
3069         WebSocket runtime configuration is supported by chromium/v8 only.
3070
3071         * DumpRenderTree/mac/DumpRenderTree.mm:
3072         (resetDefaultsToConsistentValues):
3073         * DumpRenderTree/win/DumpRenderTree.cpp:
3074         (resetDefaultsToConsistentValues):
3075
3076 2009-10-19  Nate Chapin  <japhet@chromium.org>
3077
3078         Reviewed by Adam Barth.
3079
3080         Add testFail() to test plugin so we can test our handling of a
3081         plugin invoke call returning false.
3082
3083         https://bugs.webkit.org/show_bug.cgi?id=30239
3084
3085         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
3086         (pluginInvoke):
3087         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
3088
3089 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
3090
3091         Reviewed by Gustavo Noronha.
3092
3093         Enable DOM pasting when running layout tests.
3094
3095         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3096         (resetDefaultsToConsistentValues):
3097
3098 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3099
3100         Reviewed by Simon Hausmann.
3101
3102         Use the setPreferredContentsSize method instead
3103         of setFixedContentsSize, as the method has been renamed.
3104
3105         * DumpRenderTree/qt/DumpRenderTree.cpp:
3106         (WebCore::DumpRenderTree::open):
3107         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3108         (LayoutTestController::setFixedContentsSize):
3109
3110 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3111
3112         Reviewed by Dan Bernstein.
3113
3114         https://bugs.webkit.org/show_bug.cgi?id=30456
3115         Fixes for new Debug_All Windows build configuration.
3116
3117         * DumpRenderTree/win/DumpRenderTree.cpp:
3118         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
3119         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
3120
3121 2009-10-16  Eric Seidel  <eric@webkit.org>
3122
3123         Reviewed by Adam Barth.
3124
3125         commit-queue status bot should list which buildbot is blocking the queue
3126         https://bugs.webkit.org/show_bug.cgi?id=30452
3127
3128         Add new methods and testing.
3129
3130         * Scripts/bugzilla-tool:
3131         * Scripts/modules/buildbot.py:
3132         * Scripts/modules/buildbot_unittest.py:
3133
3134 2009-10-16  Eric Seidel  <eric@webkit.org>
3135
3136         Reviewed by Adam Barth.
3137
3138         run-webkit-tests fails when CWD is not inside a WebKit checkout
3139         https://bugs.webkit.org/show_bug.cgi?id=30451
3140
3141         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
3142         * Scripts/modules/scm_unittest.py:
3143           - Remove use of original_path (we don't need to restore the CWD).
3144           - Don't use '.' to find the webkit checkout, use __file__ instead.
3145
3146 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3147
3148         Reviewed by Adam Roben.
3149
3150         Add a Debug_All configuration to build entire stack as debug.
3151         Change Debug_Internal to:
3152         - stop using _debug suffix for all WebKit/Safari binaries
3153         - not use _debug as a DLL naming suffix
3154         - use non-debug C runtime lib.
3155
3156         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
3157         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
3158         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
3159         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3160         Add missing debug.vsprops inherited property sheet.
3161         Add Debug_All configuration.
3162         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
3163         * WinLauncher/WinLauncher.vcproj:
3164         Removed extraneous definitions inherited from vsprops.
3165         Add Debug_All configuration.
3166
3167 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
3168
3169         Reviewed by David Levin.
3170
3171         check-webkit-style is wrong about indent checking in namespaces
3172         in header files and a few other things
3173         https://bugs.webkit.org/show_bug.cgi?id=30362
3174
3175         The few other things include:
3176         + check-webkit-style does not require spaces around the equal sign
3177           inside 'if' statements and around binary operators that take 
3178           numeric literals.
3179         + check-webkit-style reports false errors for the / operator
3180           when part of a filename in the #include directive.
3181
3182         * Scripts/modules/cpp_style.py:
3183         Improved indentation checking and space checking around
3184         binary operators. While the checks are still not perfect,
3185         they are clearly better than before.
3186         * Scripts/modules/cpp_style_unittest.py:
3187         Added test cases for the newly supported checks and modified old
3188         test cases to match the new guidelines
3189
3190 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
3191
3192         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
3193
3194         * wx/build/settings.py:
3195
3196 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
3197
3198         Reviewed by David Levin.
3199
3200         Add mod_pywebsocket to test Web Sockets.
3201         http://code.google.com/p/pywebsocket/
3202         https://bugs.webkit.org/show_bug.cgi?id=27490
3203
3204         * pywebsocket/COPYING: Added.
3205         * pywebsocket/MANIFEST.in: Added.
3206         * pywebsocket/README: Added.
3207         * pywebsocket/example/echo_client.py: Added.
3208         * pywebsocket/example/echo_wsh.py: Added.
3209         * pywebsocket/mod_pywebsocket/__init__.py: Added.
3210         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
3211         * pywebsocket/mod_pywebsocket/handshake.py: Added.
3212         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
3213         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
3214         * pywebsocket/mod_pywebsocket/standalone.py: Added.
3215         * pywebsocket/mod_pywebsocket/util.py: Added.
3216         * pywebsocket/setup.py: Added.
3217         * pywebsocket/test/config.py: Added.
3218         * pywebsocket/test/mock.py: Added.
3219         * pywebsocket/test/run_all.py: Added.
3220         * pywebsocket/test/test_dispatch.py: Added.
3221         * pywebsocket/test/test_handshake.py: Added.
3222         * pywebsocket/test/test_mock.py: Added.
3223         * pywebsocket/test/test_msgutil.py: Added.
3224         * pywebsocket/test/test_util.py: Added.
3225         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
3226         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
3227         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
3228         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
3229         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
3230         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
3231         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
3232         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
3233
3234 2009-10-15  James Robinson  <jamesr@google.com>
3235
3236         Reviewed by David Levin.
3237
3238         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
3239
3240         https://bugs.webkit.org/show_bug.cgi?id=30426
3241
3242         * Scripts/modules/cpp_style.py:
3243         * Scripts/modules/cpp_style_unittest.py:
3244
3245 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
3246
3247         Reviewed by Adam Roben.
3248
3249         Fixes <http://webkit.org/b/30411>.
3250         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
3251         
3252         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
3253         building Chromium.
3254
3255         * Scripts/pdevenv:
3256
3257 2009-10-15  Robin Dunn  <robin@alldunn.com>
3258
3259         Reviewed by Kevin Ollivier.
3260
3261         Add Mac package building scripts for wx.
3262         
3263         https://bugs.webkit.org/show_bug.cgi?id=30405
3264
3265         * wx/build/build_utils.py:
3266         * wx/build/settings.py:
3267         * wx/packaging/build-mac-installer.py: Added.
3268
3269 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
3270
3271         Reviewed by Gustavo Noronha.
3272
3273         Enable Web Sockets support when running layout tests.
3274
3275         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3276         (resetDefaultsToConsistentValues):
3277
3278 2009-10-15  Xan Lopez  <xlopez@igalia.com>
3279
3280         Reviewed by Gustavo Noronha.
3281
3282         Need to initialize event.button.button, since in most cases a
3283         button number is not passed as an argument.
3284
3285         * DumpRenderTree/gtk/EventSender.cpp:
3286         (mouseDownCallback):
3287         (mouseUpCallback):
3288
3289 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
3290
3291         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3292         the OS if none was explicitly set.
3293
3294         * wx/build/settings.py:
3295
3296 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
3297
3298         Reviewed by Timothy Hatcher.
3299
3300         Web Inspector: enable developers extras within inspector layout tests.
3301
3302         https://bugs.webkit.org/show_bug.cgi?id=30014
3303
3304         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3305         (LayoutTestController::showWebInspector):
3306         (LayoutTestController::closeWebInspector):
3307         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3308         (LayoutTestController::showWebInspector):
3309         (LayoutTestController::closeWebInspector):
3310
3311 2009-10-14  José Millán Soto  <jmillan@igalia.com>
3312
3313         Reviewed by Jan Alonzo.
3314
3315         GtkLauncher is using a deprecated signal
3316         https://bugs.webkit.org/show_bug.cgi?id=30364
3317
3318         Modified GtkLauncher to use notify::title signal instead of
3319         deprecated title-changed signal
3320
3321         * GtkLauncher/main.c:
3322         (notify_title_cb):
3323         (create_browser):
3324
3325 2009-10-14  Brady Eidson  <beidson@apple.com>
3326
3327         Reviewed by Sam Weinig.
3328
3329         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
3330         1 - Disables WebHistory
3331         2 - Doesn't make sense in that context anyway.
3332
3333         * DumpRenderTree/win/DumpRenderTree.cpp:
3334         (createWebViewAndOffscreenWindow):
3335
3336 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
3337
3338         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3339         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3340
3341         * wx/build/settings.py:
3342         * wx/install-unix-extras:
3343
3344 2009-10-14  Brady Eidson  <beidson@apple.com>
3345
3346         Reviewed by Sam Weinig.
3347
3348         WebKit Win API should provide a delegate interface for global history.
3349         https://bugs.webkit.org/show_bug.cgi?id=29905
3350
3351         * DumpRenderTree/LayoutTestController.cpp:
3352         (LayoutTestController::LayoutTestController):
3353         * DumpRenderTree/LayoutTestController.h:
3354         (LayoutTestController::dumpHistoryDelegateCallbacks):
3355         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3356                 
3357         * DumpRenderTree/win/DumpRenderTree.cpp:
3358         (shouldLogHistoryDelegates):
3359         (runTest):
3360         (createWebViewAndOffscreenWindow):
3361         (main):
3362         * DumpRenderTree/win/DumpRenderTree.vcproj:
3363         
3364         Add the IWebHistoryDelegate to DRT Windows:
3365         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3366         (wstringFromBSTR):
3367         (HistoryDelegate::HistoryDelegate):
3368         (HistoryDelegate::~HistoryDelegate):
3369         (HistoryDelegate::QueryInterface):
3370         (HistoryDelegate::AddRef):
3371         (HistoryDelegate::Release):
3372         (HistoryDelegate::didNavigateWithNavigationData):
3373         (HistoryDelegate::didPerformClientRedirectFromURL):
3374         (HistoryDelegate::didPerformServerRedirectFromURL):
3375         (HistoryDelegate::updateHistoryTitle):
3376         (HistoryDelegate::populateVisitedLinksForWebView):
3377         * DumpRenderTree/win/HistoryDelegate.h: Added.
3378
3379         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3380         (LayoutTestController::removeAllVisitedLinks):
3381
3382 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3383
3384         Reviewed by Simon Hausmann.
3385
3386         [Qt] Implement support for setPOSIXLocale on Qt.
3387         https://bugs.webkit.org/show_bug.cgi?id=30268 
3388  
3389         * DumpRenderTree/qt/DumpRenderTree.cpp:
3390         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3391         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3392         (LayoutTestController::setPOSIXLocale):
3393         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3394
3395 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3396
3397         Unreviewed, adding myself to reviewers list.
3398
3399         * Scripts/modules/committers.py:
3400
3401 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3402
3403         Reviewed by Mark Rowe.
3404
3405         Fix null assignment so root tests work again.
3406
3407         * Scripts/webkitdirs.pm:
3408
3409 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3410
3411         Reviewed by Simon Hausmann.
3412
3413         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3414         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3415         This is done in preparation of implementing missing features in DRT.
3416         No functionality changes made yet.
3417
3418         * DumpRenderTree/qt/DumpRenderTree.cpp:
3419         * DumpRenderTree/qt/DumpRenderTree.pro:
3420         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3421         (EventSender::EventSender):
3422         (EventSender::mouseDown):
3423         (EventSender::mouseUp):
3424         (EventSender::mouseMoveTo):
3425         (EventSender::leapForward):
3426         (EventSender::keyDown):
3427         (EventSender::contextClick):
3428         (EventSender::scheduleAsynchronousClick):
3429         (EventSender::frameUnderMouse):
3430         * DumpRenderTree/qt/EventSenderQt.h: Added.
3431         (EventSender::clearKillRing):
3432         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3433         (LayoutTestController::LayoutTestController):
3434         (LayoutTestController::reset):
3435         (LayoutTestController::processWork):
3436         (LayoutTestController::maybeDump):
3437         (LayoutTestController::waitUntilDone):
3438         (LayoutTestController::notifyDone):
3439         (LayoutTestController::windowCount):
3440         (LayoutTestController::clearBackForwardList):
3441         (LayoutTestController::dumpEditingCallbacks):
3442         (LayoutTestController::dumpResourceLoadCallbacks):
3443         (LayoutTestController::queueBackNavigation):
3444         (LayoutTestController::queueForwardNavigation):
3445         (LayoutTestController::queueLoad):
3446         (LayoutTestController::queueReload):
3447         (LayoutTestController::queueScript):
3448         (LayoutTestController::provisionalLoad):
3449         (LayoutTestController::timerEvent):
3450         (LayoutTestController::encodeHostName):
3451         (LayoutTestController::decodeHostName):
3452         (LayoutTestController::setJavaScriptProfilingEnabled):
3453         (LayoutTestController::setFixedContentsSize):
3454         (LayoutTestController::setPrivateBrowsingEnabled):
3455         (LayoutTestController::setPopupBlockingEnabled):
3456         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3457         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3458         (LayoutTestController::numberOfActiveAnimations):
3459         (LayoutTestController::disableImageLoading):
3460         (LayoutTestController::dispatchPendingLoadRequests):
3461         (LayoutTestController::setDatabaseQuota):
3462         (LayoutTestController::clearAllDatabases):
3463         (LayoutTestController::whiteListAccessFromOrigin):
3464         (LayoutTestController::waitForPolicyDelegate):
3465         (LayoutTestController::overridePreference):
3466         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3467         (LayoutTestController::isLoading):
3468         (LayoutTestController::setLoading):
3469         (LayoutTestController::shouldDumpAsText):
3470         (LayoutTestController::shouldDumpBackForwardList):
3471         (LayoutTestController::shouldDumpChildrenAsText):
3472         (LayoutTestController::shouldDumpDatabaseCallbacks):
3473         (LayoutTestController::shouldDumpStatusCallbacks):
3474         (LayoutTestController::shouldWaitUntilDone):
3475         (LayoutTestController::canOpenWindows):
3476         (LayoutTestController::shouldDumpTitleChanges):
3477         (LayoutTestController::waitForPolicy):
3478         (LayoutTestController::dumpAsText):
3479         (LayoutTestController::dumpChildFramesAsText):
3480         (LayoutTestController::dumpDatabaseCallbacks):
3481         (LayoutTestController::dumpStatusCallbacks):
3482         (LayoutTestController::setCanOpenWindows):
3483         (LayoutTestController::dumpBackForwardList):
3484         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3485         (LayoutTestController::display):
3486         (LayoutTestController::dumpTitleChanges):
3487         (LayoutTestController::dumpSelectionRect):
3488         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3489         (TextInputController::TextInputController):
3490         (TextInputController::doCommand):
3491         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3492         * DumpRenderTree/qt/WorkQueue.cpp:
3493         * DumpRenderTree/qt/WorkQueue.h:
3494         * DumpRenderTree/qt/WorkQueueItem.h:
3495         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3496         (findFrameNamed):
3497         (LoadItem::invoke):
3498         (ReloadItem::invoke):
3499         (ScriptItem::invoke):
3500         (BackForwardItem::invoke):
3501         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3502         * DumpRenderTree/qt/jsobjects.h:
3503
3504 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3505
3506         Not reviewed, adding myself to the list of reviewers.
3507
3508         * Scripts/modules/committers.py:
3509
3510 2009-10-13  Anders Carlsson  <andersca@apple.com>
3511
3512         Reviewed by Sam Weinig.
3513
3514         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3515
3516         Make the private browsing mode testable by the test plug-in.
3517         
3518         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3519         (pluginGetProperty):
3520         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3521         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3522         (NPP_New):
3523         (NPP_SetValue):
3524
3525 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3526
3527         No review, just adding self to the list of reviewers.
3528
3529         * Scripts/modules/committers.py:
3530
3531 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3532
3533         Reviewed by Adam Roben.
3534
3535         Web Inspector: Use proper web view in inspector layout
3536         tests for windows.
3537
3538         https://bugs.webkit.org/show_bug.cgi?id=30298
3539
3540         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3541         (LayoutTestController::showWebInspector):
3542         (LayoutTestController::closeWebInspector):
3543         (LayoutTestController::evaluateInWebInspector):
3544
3545 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3546
3547         Reviewed by Sam Weinig.
3548
3549         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3550         https://bugs.webkit.org/show_bug.cgi?id=29841
3551
3552         * DumpRenderTree/mac/DumpRenderTree.mm:
3553         (resetDefaultsToConsistentValues):
3554         * DumpRenderTree/win/DumpRenderTree.cpp:
3555         (resetDefaultsToConsistentValues):
3556
3557 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3558
3559         Reviewed by Dimitri Glazkov.
3560
3561         Chromium Port - Windows
3562         https://bugs.webkit.org/show_bug.cgi?id=29969
3563
3564         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3565         * Scripts/webkitdirs.pm:
3566
3567 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3568
3569         Reviewed by Darin Adler.
3570
3571         jsc scripts cleanup and Qt/GTK fix
3572         https://bugs.webkit.org/show_bug.cgi?id=30288
3573
3574         Duplicated jscPath() moved to webkitdirs.pm.
3575         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3576         Configuration added (release/debug) to path for Qt-port on Windows.
3577
3578         * Scripts/run-javascriptcore-tests:
3579         * Scripts/run-jsc:
3580         * Scripts/run-sunspider:
3581         * Scripts/sunspider-compare-results:
3582         * Scripts/webkitdirs.pm:
3583
3584 2009-10-11  Adam Barth  <abarth@webkit.org>
3585
3586         Unreviewed.  Add Collin to committers.py.
3587
3588         * Scripts/modules/committers.py:
3589
3590 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3591
3592         wx build fix, add bindings to source/include dirs now that there are sources there.
3593
3594         * wx/build/settings.py:
3595
3596 2009-10-09  Mark Rowe  <mrowe@apple.com>
3597
3598         Reviewed by Brady Eidson.
3599
3600         Enable plug-in halting in DumpRenderTree.
3601
3602         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3603         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3604
3605         * DumpRenderTree/mac/DumpRenderTree.mm:
3606         (resetDefaultsToConsistentValues):
3607         * DumpRenderTree/mac/UIDelegate.mm:
3608         (-[UIDelegate webView:shouldHaltPlugin:]):
3609
3610 2009-10-08  Brady Eidson  <beidson@apple.com>
3611
3612         Reviewed by Dan Bernstein.
3613
3614         Ask the History Delegate to populate the visited links hash.
3615         <rdar://problem/7285293> and https://webkit.org/b/29904
3616
3617         Add the ability for LayoutTestController to clear all visited links.
3618         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3619
3620         * DumpRenderTree/LayoutTestController.cpp:
3621         (LayoutTestController::LayoutTestController):
3622         (removeAllVisitedLinksCallback):
3623         (LayoutTestController::staticFunctions):
3624         * DumpRenderTree/LayoutTestController.h:
3625         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3626         (LayoutTestController::removeAllVisitedLinks):
3627
3628         * DumpRenderTree/mac/HistoryDelegate.mm:
3629         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3630
3631         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3632         (LayoutTestController::removeAllVisitedLinks):
3633         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3634         (LayoutTestController::removeAllVisitedLinks):
3635         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3636         (LayoutTestController::removeAllVisitedLinks):
3637
3638
3639 2009-10-08  Daniel Bates  <dbates@webkit.org>
3640
3641         Reviewed by Adam Roben.
3642
3643         https://bugs.webkit.org/show_bug.cgi?id=30175
3644         
3645         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3646         the OLE drag-and-drop return value like the function it emulates. Currently, 
3647         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
3648         whether the drag-and-drop operation was successful or was cancelled.
3649         
3650         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
3651         return value according to whether the drop operation was successful or not.
3652
3653         * DumpRenderTree/win/EventSender.cpp:
3654         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3655         (replaySavedEvents): Ditto.
3656         * DumpRenderTree/win/EventSender.h:
3657         * DumpRenderTree/win/UIDelegate.cpp:
3658         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3659
3660 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3661
3662         Reviewed by Xan Lopez.
3663
3664         [GTK] Added support for a parameter setting the button that was
3665         pressed in the mouseDown function.
3666         https://bugs.webkit.org/show_bug.cgi?id=30220
3667
3668         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3669
3670 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3671
3672         Reviewed by Xan Lopez.
3673
3674         [GTK] Added a line to the bottom of the expected result to match
3675         the output of the test.
3676         https://bugs.webkit.org/show_bug.cgi?id=30220
3677
3678         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3679         expected.txt:
3680
3681 2009-10-08  Adam Roben  <aroben@apple.com>
3682
3683         Use QueryInterface to get IWebInspectorPrivate
3684
3685         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3686         accessed in a more standard way
3687