Unreviewed trivial warning fix.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-02-09  Andras Becsi  <abecsi@webkit.org>
2
3         Unreviewed trivial warning fix.
4
5         * Scripts/build-webkit:
6
7 2010-02-09 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
8
9         Reviewed by Tor Arne Vestbø.
10
11         Add possibility of passing parameters to build-webkit by environment variable,
12         because the buildbot slaves can't control the arguments.
13
14         * Scripts/build-webkit:
15
16 2010-02-09  Chang Shu  <Chang.Shu@nokia.com>
17
18         Reviewed by Laszlo Gombos.
19
20         [Qt] Enable appcache feature.
21         https://bugs.webkit.org/show_bug.cgi?id=34713
22
23
24         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
25         (WebCore::WebPage::WebPage):
26         * DumpRenderTree/qt/main.cpp:
27         (main):
28
29 2010-02-09  Shinichiro Hamaji  <hamaji@chromium.org>
30
31         Reviewed by Darin Adler.
32
33         Provide a way to get total number of pages to be printed
34         https://bugs.webkit.org/show_bug.cgi?id=34699
35
36         * DumpRenderTree/LayoutTestController.cpp:
37         (parsePageParameters):
38         (pageNumberForElementByIdCallback):
39         (numberOfPagesCallback):
40         (LayoutTestController::staticFunctions):
41         * DumpRenderTree/LayoutTestController.h:
42         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
43         (LayoutTestController::numberOfPages):
44         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
45         (LayoutTestController::numberOfPages):
46         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
47         (LayoutTestController::numberOfPages):
48
49 2010-02-08  Alexey Proskuryakov  <ap@apple.com>
50
51         Reviewed by Darin Adler.
52
53         https://bugs.webkit.org/show_bug.cgi?id=34727
54         Assertion crashes and freezes when plug-in property access results in an exception
55
56         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
57         (pluginGetProperty): Raise an exception when accessing a particular property.
58         (pluginSetProperty): Ditto.
59         (pluginInvoke): Added methods to get and set host object properties.
60
61 2010-02-08  Kenneth Rohde Christiansen  <kenneth@webkit.org>
62
63         Reviewed by Ariya Hidayat.
64
65         [Qt] Backport No'am Rosenthal's frame rate measurement
66
67         * QtLauncher/main.cpp:
68         (LauncherWindow::LauncherWindow):
69         (LauncherApplication::handleUserOptions):
70         * QtLauncher/webview.cpp:
71         (WebViewGraphicsBased::WebViewGraphicsBased):
72         (WebViewGraphicsBased::enableFrameRateMeasurement):
73         (WebViewGraphicsBased::updateFrameRate):
74         (WebViewGraphicsBased::paintEvent):
75         * QtLauncher/webview.h:
76
77 2010-02-08  Kenneth Rohde Christiansen  <kenneth@webkit.org>
78
79         Reviewed by Tor Arne Vestbø.
80
81         [Qt] Make overridePreference complain when it does not
82         support the preference given.
83
84         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
85         (LayoutTestController::overridePreference):
86
87 2010-02-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
88
89         Reviewed by Kenneth Rohde Christiansen.
90
91         [Qt] Set stdout/stderr to binary mode for DRT on Windows
92
93         This makes sure we don't end up with lots of CRLFs in the
94         DRT output, which breaks tons of results. Matches what
95         the Windows DRT does.
96
97         * DumpRenderTree/qt/main.cpp:
98
99 2010-02-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
100
101         Reviewed by Kenneth Rohde Christiansen.
102
103         Build fix for Qt on Windows.
104
105         Don't use noreturn directly since it's a gcc attribute.
106         Instead use the NO_RETURN macro from AlwaysInline.h
107
108         * QtLauncher/QtLauncher.pro:
109         * QtLauncher/utils.h:
110
111 2010-02-05  Chris Jerdonek  <cjerdonek@webkit.org>
112
113         Reviewed by Shinichiro Hamaji.
114
115         Suppressed check-webkit-style's underscore check in Qt's autotests.
116         Also made the path-specific filter check case-insensitive.
117
118         https://bugs.webkit.org/show_bug.cgi?id=34574
119
120         * Scripts/webkitpy/style/checker.py:
121           - Added a list element to _PATH_RULES_SPECIFIER for
122             directories that should be excluded from the
123             "readability/naming" category (the category that relates to
124             underscores in identifiers, for example).
125
126         * Scripts/webkitpy/style/checker_unittest.py:
127           - Added an "end-to-end" test for "WebKit/qt/tests/".
128
129         * Scripts/webkitpy/style/filter.py:
130           - Altered FilterConfiguration's should_check() method to
131             check for path substring matches case-insensitively.
132
133         * Scripts/webkitpy/style/filter_unittest.py:
134           - Added a test to check case-insensitive path substring matching.
135
136         * Scripts/webkitpy/style/processors/cpp.py:
137           - Removed the hard-coded "WebKit/gtk/webkit/" path reference
138             since this is now taken care of by the _PATH_RULES_SPECIFIER
139             configuration variable.
140
141         * Scripts/webkitpy/style/processors/cpp_unittest.py:
142           - Removed the unit test for the GTK directory since this
143             is now taken care of by the checker._PATH_RULES_SPECIFIER
144             end-to-end tests.
145
146 2010-02-08  Leith Bade  <leith@leithalweapon.geek.nz>
147
148         Reviewed by Darin Adler.
149
150         Fixes: https://bugs.webkit.org/show_bug.cgi?id=34637
151         Corrects the newline inserted into WebKitOutputDir, and WebKitLibrariesDir Windows
152         environemnt variables when there is a space in the user's /home path.
153
154         * Scripts/webkitdirs.pm:
155          - Added missing quotes around $sourceDir in argument list of cygpath in determineWindowsSourceDir().
156
157 2010-02-05  Alexey Proskuryakov  <ap@apple.com>
158
159         Reviewed by Oliver Hunt.
160
161         https://bugs.webkit.org/show_bug.cgi?id=34670
162         TestNetscapePlugin should work with Firefox
163
164         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Default to Carbon if
165         browser doesn't tell what it supports.
166
167 2010-02-05  Shinichiro Hamaji  <hamaji@chromium.org>
168
169         Reviewed by Gustavo Noronha Silva.
170
171         [Gtk] Implement layoutTestController.pageNumberForElementById
172         https://bugs.webkit.org/show_bug.cgi?id=34572
173
174         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
175         (LayoutTestController::pageNumberForElementById):
176
177 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
178
179         Reviewed by Eric Seidel.
180
181         Add a simple test implementation and the WebKit Mac implementation
182         for the layout_tests/port package. Also add a simple test driver of
183         that interface.
184
185         https://bugs.webkit.org/show_bug.cgi?id=34511
186
187         * Scripts/webkitpy/layout_tests/driver_test.py: Added.
188         * Scripts/webkitpy/layout_tests/port/__init__.py:
189         * Scripts/webkitpy/layout_tests/port/mac.py: Added.
190         * Scripts/webkitpy/layout_tests/port/test.py: Added.
191
192 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
193
194         Reviewed by Eric Siedel.
195
196         Refactor the port package into an object-oriented style and merge
197         path_utils into it. We add a 'base' and a 'chromium' object to the
198         port package; this will allow us to easily add new ports (like
199         WebKit Mac).
200
201         https://bugs.webkit.org/show_bug.cgi?id=34511
202
203         * Scripts/rebaseline-chromium-webkit-tests:
204         * Scripts/run-chromium-webkit-tests:
205         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
206         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
207         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
208         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
209         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
210         * Scripts/webkitpy/layout_tests/port/__init__.py:
211         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
212         * Scripts/webkitpy/layout_tests/port/base.py: Added.
213         * Scripts/webkitpy/layout_tests/port/chromium.py: Added.
214         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
215         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
216         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
217         * Scripts/webkitpy/layout_tests/port/http_server.py:
218         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
219         * Scripts/webkitpy/layout_tests/port/path_utils.py: Removed.
220         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
221         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
222         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
223         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
224         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
225         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
226         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
227
228 2010-01-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
229
230         Reviewed by Dave Hyatt.
231
232         Implement flattening of framesets
233         https://bugs.webkit.org/show_bug.cgi?id=32717
234
235         Add support for testing frame flattening with the Qt DRT
236
237         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
238         (LayoutTestController::setFrameSetFlatteningEnabled):
239         * DumpRenderTree/qt/LayoutTestControllerQt.h:
240
241 2010-02-03  Chris Jerdonek  <cjerdonek@webkit.org>
242
243         Reviewed by Shinichiro Hamaji.
244
245         Provided a way in check-webkit-style to specify filter rules
246         on a per file or folder basis, via a configuration variable.
247
248         https://bugs.webkit.org/show_bug.cgi?id=33684
249
250         * Scripts/webkitpy/style/checker.py:
251           - Added _PATH_RULES_SPECIFIER configuration variable.
252           - In ProcessorOptions class--
253             - Changed the CategoryFilter attribute to FilterConfiguration.
254             - Added path parameter to is_reportable().
255           - Renamed ArgumentDefaults filter_rules attribute to
256             base_filter_rules.
257           - Updated ArgumentPrinter class.
258           - Added filter rule validation to ArgumentParser (instead of
259             in CategoryFilter constructor).
260
261         * Scripts/webkitpy/style/checker_unittest.py:
262           - Updated unit tests as necessary.
263           - Added unit tests for PATH_RULES_SPECIFIER.
264
265         * Scripts/webkitpy/style/error_handlers.py:
266           - Updated DefaultStyleErrorHandler to use file path when
267             calling is_reportable().
268
269         * Scripts/webkitpy/style/error_handlers_unittest.py:
270           - Updated unit tests as necessary.
271
272         * Scripts/webkitpy/style/filter.py:
273           - Marked CategoryFilter internal with an underscore.
274           - Removed argument validation from CategoryFilter.
275           - Added FilterConfiguration class.
276
277         * Scripts/webkitpy/style/filter_unittest.py:
278           - Updated CategoryFilterTest class.
279           - Added FilterConfigurationTest unit tests.
280
281         * Scripts/webkitpy/style/processors/cpp.py:
282           - Removed _is_test_filename() code.
283           - Removed hard-coded path checks from check_include_line().
284
285         * Scripts/webkitpy/style/processors/cpp_unittest.py:
286           - Removed three unit tests related to exempted files.
287
288 2010-02-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
289
290         Reviewed by Ariya Hidayat.
291
292         [Qt] Apply the command line options as settings to the
293         graphics system.
294
295         * QtLauncher/main.cpp:
296         (LauncherWindow::LauncherWindow):
297         (requiresGraphicsView):
298         (LauncherApplication::handleUserOptions):
299         * QtLauncher/webview.h:
300         (WebViewGraphicsBased::setItemCacheMode):
301
302 2010-02-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
303
304         Reviewed by Simon Hausmann.
305
306         Notify user that run-webkit-tests has to be run under Cygwin
307
308         The script will bail out if run under Windows shell or Msys.
309
310         * Scripts/run-webkit-tests:
311         * Scripts/webkitdirs.pm:
312
313 2010-02-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
314
315         Reviewed by Simon Hausmann.
316
317         [Qt] Generate convenience headers (QWebView, etc) using qmake
318
319         In Qt this is done using syncqt, but we use a pro-file instead
320         that generates makefile-rules for each of the extra headers.
321
322         These extra headers are installed alongside the normal headers.
323
324         * Scripts/webkitdirs.pm: Run qmake and make on new API-DerivedSources
325
326 2010-02-05  Andras Becsi  <abecsi@webkit.org>
327
328         Unreviewed typo fix.
329
330         Fix wrong whitespace alignment introduced in r54342.
331
332         * Scripts/run-webkit-tests:
333
334 2010-02-04  Mark Rowe  <mrowe@apple.com>
335
336         Reviewed by Timothy Hatcher.
337
338         Build fix.  Remove a symbol corresponding to an inline function from the linker export
339         file to prevent a weak external failure.
340
341         * Scripts/check-for-weak-vtables-and-externals: Renamed from WebKitTools/Scripts/check-for-weak-vtables.
342         Teach the script how to detect weak external symbols so that these errors can be caught immediately
343         in the future.
344
345 2010-02-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
346
347         Rubberstamped by Oliver Hunt.
348
349         [Qt] Make it possible to choose whether the launcher should
350         use the traditional QWidget based QWebView or the newer
351         QGraphics based QGraphicsWebView on a QGraphicsView.
352
353         * QtLauncher/main.cpp:
354         (LauncherWindow::LauncherWindow):
355         (LauncherWindow::eventFilter):
356         (LauncherWindow::loadStarted):
357         (LauncherWindow::print):
358         (LauncherWindow::screenshot):
359         (LauncherWindow::setEditable):
360         (LauncherWindow::setupUI):
361         (main):
362         * QtLauncher/webview.cpp:
363         (WebViewGraphicsBased::WebViewGraphicsBased):
364         (WebViewGraphicsBased::resizeEvent):
365         (GraphicsWebView::mousePressEvent):
366         (GraphicsWebView::contextMenuEvent):
367         * QtLauncher/webview.h:
368         (WebViewTraditional::WebViewTraditional):
369         (GraphicsWebView::GraphicsWebView):
370         (WebViewGraphicsBased::setPage):
371
372 2010-02-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
373
374         Rubberstamped by Oliver Hunt.
375
376         [Qt] QtLauncher cleanup.
377
378         Refactor option handling out in utility functions and make the
379         arguments more Qt compatible.
380
381         * QtLauncher/main.cpp:
382         (requiresGraphicsView):
383         (LauncherApplication::handleUserOptions):
384         * QtLauncher/utils.cpp:
385         (takeOptionValue):
386         (formatKeys):
387         (enumToKeys):
388         (appQuit):
389         * QtLauncher/utils.h:
390
391 2010-02-04  Andras Becsi  <abecsi@inf.u-szeged.hu>
392
393         Reviewed by Tor Arne Vestbø.
394
395         Implement a locking and scheduling mechanism for http testing sessions to be able
396         to run multiple instances of run-webkit-tests parallel on the same machine.
397         If a test session wants to run http tests and this feature is enabled, the pending
398         sessions create lockfiles with sequential lock numbers. These locks are used to schedule
399         the running test sessions in first come first served order. An exclusive lock ensures
400         that the lock numbers are sequential to avoid deadlocks and starvation.
401         Because the buildbot master specifies the flags used by slaves we need an environment
402         variable too to be able to use the feature per-slave.
403         Exporting WEBKIT_WAIT_FOR_HTTPD=1 before testing or using the --wait-for-httpd
404         flag enables this feature, otherwise this patch has no effect on the testing whatsoever.
405
406         https://bugs.webkit.org/show_bug.cgi?id=33153
407
408         * Scripts/run-webkit-tests:
409         * Scripts/webkitperl/httpd.pm:
410
411 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
412
413         Reviewed by Simon Hausmann.
414
415         Make run-webkit-tests work under Cygwin for the Qt port
416
417         setPathForRunningWebKitApp() is implemented for the Qt port
418         by using qmake to query for the location of the Qt libraries.
419
420         This requires the original environment (%ENV) to be untouched,
421         so launchWithCurrentEnv() was refactored to launchWithEnv(),
422         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
423         instead. This has the added benefit of getting rid of the temp
424         variables used for storing the current env.
425
426         openDumpTool() is also refactored a bit into platform-spesific,
427         port-spesific, and generic environment variables.
428
429         Checks for undef was added a few places to fix Perl concat
430         warnings when run-webkit-tests is aborted.
431
432         https://bugs.webkit.org/show_bug.cgi?id=33895
433
434         * Scripts/run-webkit-tests:
435         * Scripts/webkitdirs.pm:
436
437 2010-02-04  Yuzo Fujishima  <yuzo@google.com>
438
439         Unreviewed.
440
441         Add Yuzo to the committers list.
442
443         * Scripts/webkitpy/committers.py:
444
445 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
446
447         Rubber-stamped by Eric Seidel.
448
449         Change "the Chromium name" to "the name of Google Inc." in the licenses
450
451         https://bugs.webkit.org/show_bug.cgi?id=34511
452
453         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
454         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
455         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
456         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
457         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
458         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
459         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
460         * Scripts/webkitpy/layout_tests/port/__init__.py:
461         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
462         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
463         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
464         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
465         * Scripts/webkitpy/layout_tests/port/http_server.py:
466         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
467         * Scripts/webkitpy/layout_tests/port/path_utils.py:
468         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
469         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
470         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
471         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
472         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
473         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
474         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
475
476 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
477
478         Rubber-stamped by Eric Siedel.
479
480         Rename files as part of refactoring the layout_tests package. All
481         the platform_utils* module, the path_utils.py module, and
482         the http server and web socket server modules are moved into a new
483         port/ package.
484
485         https://bugs.webkit.org/show_bug.cgi?id=34511
486
487         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Removed.
488         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Removed.
489         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Removed.
490         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Removed.
491         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
492         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
493         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Removed.
494         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Removed.
495         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Removed.
496         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Removed.
497         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Removed.
498         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Removed.
499         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
500         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
501         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
502         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Removed.
503         * Scripts/webkitpy/layout_tests/port: Added.
504         * Scripts/webkitpy/layout_tests/port/__init__.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils.py.
505         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py.
506         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py.
507         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py.
508         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py.
509         * Scripts/webkitpy/layout_tests/port/http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server.py.
510         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server_base.py.
511         * Scripts/webkitpy/layout_tests/port/httpd2.pem: Copied from Scripts/webkitpy/layout_tests/layout_package/httpd2.pem.
512         * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Copied from Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf.
513         * Scripts/webkitpy/layout_tests/port/path_utils.py: Copied from Scripts/webkitpy/layout_tests/layout_package/path_utils.py.
514         * Scripts/webkitpy/layout_tests/port/websocket_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/websocket_server.py.
515         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
516         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
517         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
518         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
519         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
520         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
521
522
523 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
524
525         Rubber-stamped by Eric Seidel.
526
527         Roll back r53559 and r54084 again, because roll out didn't solve flakeyness on the Windows Test bots
528         https://bugs.webkit.org/show_bug.cgi?id=34399
529
530         * Scripts/run-iexploder-tests:
531         * Scripts/run-webkit-httpd:
532         * Scripts/run-webkit-tests:
533         * Scripts/webkitperl/httpd.pm: Added.
534
535 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
536
537         Rubber-stamped by Eric Seidel.
538
539         Roll out r53559 and r54084, because it might caused flakeyness on the Windows Test bots
540
541         * Scripts/run-iexploder-tests:
542         * Scripts/run-webkit-httpd:
543         * Scripts/run-webkit-tests:
544         * Scripts/webkitperl/httpd.pm: Removed.
545
546 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
547
548         Rubber-stamped by Ariya Hidayat.
549
550         Roll back r53889 again, because roll out didn't solve flakeyness on the Windows Test bots
551         https://bugs.webkit.org/show_bug.cgi?id=34399
552
553         * DumpRenderTree/win/EventSender.cpp:
554         (buildModifierFlags):
555         (mouseDownCallback):
556         (mouseUpCallback):
557         (keyDownCallback):
558
559 2010-02-03  Eric Seidel  <eric@webkit.org>
560
561         No review, just fixing copyrights.
562
563         Concerns were expressed about "The Chromium Authors" being
564         a valid legal entity for copyright assignment in the WebKit repository,
565         so this change removes all "The Chromium Authors".
566
567         I looked at the svn logs in src.chromium.org and failed to find any
568         non-google contributions to these files, so they are all now
569         marked as copyright "Google Inc" as all Google contributers assign
570         copyright to "Google Inc" as part of their employment agreement.
571
572         * Scripts/rebaseline-chromium-webkit-tests:
573         * Scripts/run-chromium-webkit-tests:
574         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py:
575         * Scripts/webkitpy/layout_tests/layout_package/http_server.py:
576         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py:
577         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
578         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
579         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
580         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py:
581         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py:
582         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py:
583         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py:
584         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py:
585         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
586         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
587         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
588         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
589         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py:
590         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
591         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
592         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
593         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
594         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
595         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
596
597 2010-02-03  Kenneth Rohde Christiansen  <kenneth@webkit.org>
598
599         Reviewed by Ariya Hidayat.
600
601         [Qt] QtLauncher, refactor argument handling in preparation of merge
602         with QGVLauncher
603
604         * QtLauncher/main.cpp:
605         (LauncherApplication::urls):
606         (LauncherApplication::isRobotized):
607         (LauncherApplication::applyDefaultSettings):
608         (LauncherApplication::LauncherApplication):
609         (LauncherApplication::formatKeys):
610         (LauncherApplication::enumToKeys):
611         (fail):
612         (LauncherApplication::handleUserOptions):
613         (main):
614
615 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
616
617         Rubber-stamped by Ariya Hidayat.
618
619         Rolling out r53889, because it might caused flakeyness on the Windows Test bots
620         https://bugs.webkit.org/show_bug.cgi?id=34399
621
622         * DumpRenderTree/win/EventSender.cpp:
623         (mouseDownCallback):
624         (mouseUpCallback):
625         (keyDownCallback):
626
627 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
628
629         Reviewed by Ariya Hidayat.
630
631         [Qt] Fix pixel tests support.
632         https://bugs.webkit.org/show_bug.cgi?id=27813
633
634         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
635         (WebCore::DumpRenderTree::open):
636         (WebCore::DumpRenderTree::processLine):
637          - Hash processing mechanism moved from DumpRenderTree::open to DumpRenderTree::processLine.
638         (WebCore::DumpRenderTree::dump): Fixed and renamed variables.
639
640 2010-02-03  Kevin Watters  <kevinwatters@gmail.com>
641
642         Reviewed by Kevin Ollivier.
643
644         [wx] Enable JIT compilation for wx.
645         
646         https://bugs.webkit.org/show_bug.cgi?id=34536
647
648         * wx/build/settings.py:
649
650 2010-02-02  Kevin Ollivier  <kevino@theolliviers.com>
651
652         [wx] Build fix after introduction of pageNumberForElementById.
653
654         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
655         (LayoutTestController::pageNumberForElementById):
656
657 2010-02-02  Shu Chang  <Chang.Shu@nokia.com>
658
659         Unreviewed.
660
661         Add myself to list of committers.
662
663         * Scripts/webkitpy/committers.py:
664
665 2010-02-02  Chris Jerdonek  <cjerdonek@webkit.org>
666
667         Reviewed by Shinichiro Hamaji.
668
669         Moved filter-related check-webkit-style code into a separate
670         filter module.
671
672         https://bugs.webkit.org/show_bug.cgi?id=34408
673
674         This is preparatory refactoring for Bug 33684, which will allow
675         file and folder-specific filter rules.
676
677         * Scripts/webkitpy/style/checker.py:
678           - Removed CategoryFilter class (moved to filter.py).
679
680         * Scripts/webkitpy/style/checker_unittest.py:
681           - Removed CategoryFilter unit tests (moved to filter_unittest.py).
682
683         * Scripts/webkitpy/style/filter.py: Added.
684           - Added CategoryFilter class (moved from checker.py).
685
686         * Scripts/webkitpy/style/filter_unittest.py: Added.
687           - Added CategoryFilter unit tests (moved from checker_unittest.py).
688
689         * Scripts/webkitpy/style/unittests.py:
690           - Added reference to filter_unittest.py.
691
692 2010-02-01  Chris Jerdonek  <cjerdonek@webkit.org>
693
694         Reviewed by Shinichiro Hamaji.
695
696         Addressed FIXME in check-webkit-style so that the carriage-return
697         check will work for patches.
698
699         https://bugs.webkit.org/show_bug.cgi?id=34260
700
701         Also added support for limiting the number of errors reported
702         per category, per file.
703
704         * Scripts/webkitpy/style/checker.py:
705           - Added new "whitespace/carriage_return" category from common.py.
706           - Added MAX_REPORTS_PER_CATEGORY dictionary.
707           - Added max_reports_per_category attribute to ProcessorOptions class.
708           - Refactored StyleChecker._process_file().
709
710         * Scripts/webkitpy/style/checker_unittest.py:
711           - Updated ProcessorOptionsTest tests.
712           - Added test to check MAX_REPORTS_PER_CATEGORY.
713
714         * Scripts/webkitpy/style/error_handlers.py:
715           - Added support for suppressing the display of errors after
716             reaching a per-category maximum (from max_reports_per_category).
717
718         * Scripts/webkitpy/style/error_handlers_unittest.py:
719           - Added test for suppressing error display.
720
721         * Scripts/webkitpy/style/processors/common.py: Added.
722           - Moved carriage-return check to new file.
723
724         * Scripts/webkitpy/style/processors/common_unittest.py: Added.
725           - Added unit tests for carriage-return check.
726
727         * Scripts/webkitpy/style/unittests.py:
728           - Added reference to common_unittest.py.
729
730 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
731
732         Reviewed by Eric Seidel.
733
734         Provide a way to get page number with layoutTestController
735         https://bugs.webkit.org/show_bug.cgi?id=33840
736
737         * DumpRenderTree/LayoutTestController.cpp:
738         (pageNumberForElementByIdCallback):
739         (LayoutTestController::staticFunctions):
740         * DumpRenderTree/LayoutTestController.h:
741         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
742         (LayoutTestController::pageNumberForElementById):
743         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
744         (LayoutTestController::pageNumberForElementById):
745         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
746         (LayoutTestController::pageNumberForElementById):
747
748 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
749
750         Unreviewed fix for an invalid function call.
751
752         check-webkit-style: Remove filename parameter from all functions where no longer used
753         https://bugs.webkit.org/show_bug.cgi?id=34249
754
755         * Scripts/webkitpy/style/checker.py:
756
757 2010-02-01  Diego Gonzalez  <diego.gonzalez@openbossa.org>
758
759         Reviewed by Kenneth Rohde Christiansen.
760
761         [Qt] DRT Provide global flag ability
762         https://bugs.webkit.org/show_bug.cgi?id=34418
763
764         Add the globalFlag property to the Qt LayoutTestController to allow
765         cross-domain indications.
766
767         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
768         (LayoutTestController::reset):
769         * DumpRenderTree/qt/LayoutTestControllerQt.h:
770         (LayoutTestController::globalFlag):
771         (LayoutTestController::setGlobalFlag):
772
773 2010-02-01  Brady Eidson  <beidson@apple.com>
774
775         Reviewed by Adele Peterson.
776
777         Crash in Safari opening new tabs to "same page"
778         <rdar://problem/7593857> and https://bugs.webkit.org/show_bug.cgi?id=34444
779
780         Add a mode (Mac-only for now) that exercises the WebView SPI _loadBackForwardListFromOtherView:
781
782         * DumpRenderTree/LayoutTestController.cpp:
783         (LayoutTestController::LayoutTestController):
784         (setNewWindowsCopyBackForwardListCallback):
785         (LayoutTestController::staticFunctions):
786
787         * DumpRenderTree/LayoutTestController.h:
788         (LayoutTestController::newWindowsCopyBackForwardList):
789         (LayoutTestController::setNewWindowsCopyBackForwardList):
790
791         * DumpRenderTree/mac/UIDelegate.mm:
792         (-[UIDelegate webView:createWebViewWithRequest:]):
793
794 2010-02-01  Carol Szabo  <carol.szabo@nokia.com>
795
796         Unreviewed.
797
798         Add myself to list of committers.
799
800         * Scripts/webkitpy/committers.py:
801
802 2010-02-01  Nate Chapin  <japhet@chromium.org>
803
804         Rubber-stamped by David Levin.
805
806         Add myself to reviewer list.
807
808         * Scripts/webkitpy/committers.py:
809
810 2010-01-31  Chris Jerdonek  <cjerdonek@webkit.org>
811
812         Reviewed by Shinichiro Hamaji.
813
814         Moved style error handler code to their own classes, and
815         related refactoring. Increased unit test code coverage of
816         style error handling.
817
818         https://bugs.webkit.org/show_bug.cgi?id=34379
819
820         * Scripts/check-webkit-style:
821           - Minor change: added error_count variable.
822
823         * Scripts/webkitpy/style/checker.py:
824           - Renamed ProcessorOptions.should_report_error() to is_reportable().
825           - In the StyleChecker class--
826             - Removed _default_style_error_handler().
827             - Added _increment_error_count().
828             - Refactored to use DefaultStyleErrorHandler and
829               PatchStyleErrorHandler constructors.
830
831         * Scripts/webkitpy/style/checker_unittest.py:
832           - In the StyleStyleCheckerTest class--
833             - Removed write_sample_error().
834             - Removed test_default_style_error_handler().
835
836         * Scripts/webkitpy/style/error_handlers.py: Added.
837           - Added DefaultStyleErrorHandler class.
838           - Added PatchStyleErrorHandler class.
839
840         * Scripts/webkitpy/style/error_handlers_unittest.py: Added.
841           - Added unit tests for DefaultStyleErrorHandler and
842             PatchStyleErrorHandler.
843
844         * Scripts/webkitpy/style/unittests.py:
845           - Added error_handlers unit tests.
846
847 2010-01-29  Mark Rowe  <mrowe@apple.com>
848
849         Rubber-stamped by Stephanie Lewis.
850
851         Fix run-leaks with newer versions of the leaks tool.
852
853         * Scripts/run-leaks:
854
855 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
856
857         Reviewed by Eric Siedel.
858
859         Top-level test drivers for running the Chromium port of run-webkit-tests
860         and being able to rebaseline test results from the test bots.  The
861         files in the Scripts directory are simply wrappers around the files
862         in webkitpy/layout_tests for convenience.
863  
864         https://bugs.webkit.org/show_bug.cgi?id=31498
865
866         * Scripts/rebaseline-chromium-webkit-tests: Added.
867         * Scripts/run-chromium-webkit-tests: Added.
868         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Added.
869         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: Added.
870
871 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
872
873         Reviewed by Eric Siedel.
874
875         Add in the second block of python code for the Chromium port
876         of run-webkit-tests. These files execute different diffs to classify
877         the various types of failures from a test.
878
879         * Scripts/webkitpy/layout_tests/test_types: Added.
880         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Added.
881         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Added.
882         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Added.
883         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Added.
884         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Added.
885
886 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
887
888         Reviewed by Eric Siedel.
889
890         Check in the first part of the Chromium Python port of the 
891         run-webkit-tests test driver. The files under 
892         layout_tests/layout_layout constitute most of the implementation;
893         they can be roughly divided into code that parses the 
894         "test_expectations.txt" file that describes how we expect tests to
895         pass or fail, platform-specific hooks for the different Chromium 
896         ports (in platform_utils*), code for parsing the output of the
897         tests and generating results files and HTML and JSON for the
898         dashboards, auxiliary scripts for starting and stopping HTTP and
899         Web Socket servers, and then one of the actual driver files 
900         (test_shell_thread). Code for actually parsing test output for 
901         failures and the top-level driver scripts will follow shortly.
902
903         https://bugs.webkit.org/show_bug.cgi?id=31498
904
905         * Scripts/webkitpy/layout_tests: Added.
906         * Scripts/webkitpy/layout_tests/layout_package: Added.
907         * Scripts/webkitpy/layout_tests/layout_package/__init__.py: Added.
908         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Added.
909         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Added.
910         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Added.
911         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Added.
912           - scripts to start and stop apache. Note that the apache file
913             generates a conf file dynamically, and we should switch to 
914             using the same static conf file that the regular run-webkit-tests
915             uses, and we can also use the same httpd2.pem file.
916
917         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Added.
918         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Added.
919           - scripts to generate the JSON layout test dashboard and the
920             flakiness dashboard
921         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Added.
922           - default configuration for LigHTTPd (used on Windows)
923         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Added.
924           - utility class that implements progress bars on the console to
925             be displayed while the tests are running
926         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Added.
927           - various routines for manipulating paths and URIs
928         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Added.
929         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Added.
930         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Added.
931         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Added.
932           - platform-specific aspects of the drivers (binary names, paths,
933             process control, etc.)
934         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Added.
935           - code for parsing the 'test_expectations.txt' file to determine
936             which tests are expected to fail (and how) on which platforms
937         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Added.
938           - code for handling different kinds of failures (generating output
939             in the results, etc.)
940         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Added.
941           - code to gather the lists of tests
942         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Added.
943           - code to actually execute tests via TestShell and process
944             the output
945         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Added.
946           - scripts to start and stop the pywebsocket server
947
948 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
949
950         Reviewed by Eric Seidel.
951
952         Check in a copy of the simplejson library; it will be used by
953         the Chromium port of run-webkit-tests.
954         
955         https://bugs.webkit.org/show_bug.cgi?id=31498
956
957         * simplejson: Added.
958         * simplejson/LICENSE.txt: Added.
959         * simplejson/README.txt: Added.
960         * simplejson/__init__.py: Added.
961         * simplejson/_speedups.c: Added.
962         (ascii_escape_char):
963         (ascii_escape_unicode):
964         (ascii_escape_str):
965         (py_encode_basestring_ascii):
966         (init_speedups):
967         * simplejson/decoder.py: Added.
968         * simplejson/encoder.py: Added.
969         * simplejson/jsonfilter.py: Added.
970         * simplejson/scanner.py: Added.
971
972 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
973
974         No review
975
976         Add myself to the committers list
977
978         * Scripts/webkitpy/committers.py:
979
980 2010-01-29  Jeremy Orlow  <jorlow@chromium.org>
981
982         Reviewed by Dimitri Glazkov.
983
984         A first step towards the Indexed Database API
985         https://bugs.webkit.org/show_bug.cgi?id=34342
986
987         Add indexed database API.
988
989         * Scripts/build-webkit:
990
991 2010-01-29  Andras Becsi  <abecsi@webkit.org>
992
993         Reviewed by Alexey Proskuryakov.
994
995         Correct openHTTPD() to print requests to stdout if run-webkit-httpd is used.
996         This fixes a regression introduced in r53559.
997
998         https://bugs.webkit.org/show_bug.cgi?id=34336
999
1000         * Scripts/webkitperl/httpd.pm:
1001
1002 2010-01-28  Jon Honeycutt  <jhoneycutt@apple.com>
1003
1004         MSAA: Crash when posting a notification for a detached object
1005
1006         https://bugs.webkit.org/show_bug.cgi?id=34309
1007         <rdar://problem/7409759>
1008
1009         Reviewed by Darin Adler.
1010
1011         * DumpRenderTree/AccessibilityController.h:
1012         Declare new functions. Add new members to store the event hook and the
1013         mapping of accessibility elements to their JS callbacks.
1014
1015         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1016         (AccessibilityController::notificationReceived):
1017         Stubbed.
1018         (AccessibilityController::addNotificationListener):
1019         Stubbed.
1020
1021         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1022         (AccessibilityController::notificationReceived):
1023         Stubbed.
1024         (AccessibilityController::addNotificationListener):
1025         Stubbed.
1026
1027         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1028         (AccessibilityController::AccessibilityController):
1029         Initialize the event hook.
1030         (AccessibilityController::~AccessibilityController):
1031         Remove the event hook. Unprotect all of the JS functions that are stored
1032         in the map.
1033         (logEventProc):
1034         Clean-up a variable.
1035         (stringEvent):
1036         Return a string description of the MSAA event code.
1037         (notificationListenerProc):
1038         Get the accessible object from the event, and query it for IAccessible.
1039         Call the AccessibilityController's notificationReceived().
1040         (comparableObject):
1041         Use QueryService to obtain the IAccessibleComparable for the
1042         IServiceProvider.
1043         (AccessibilityController::notificationReceived):
1044         Iterate the map of objects that have registered for notification
1045         callbacks. Query each for IServiceProvider, then use comparableObject()
1046         to get an IAccessibleComparable. If we find an object matching the
1047         notified object, call its callback, passing the event that was received.
1048         (AccessibilityController::addNotificationListener):
1049         If we have not created the event hook, create it. Protect the JS
1050         callback function object, and add the object and its callback to our
1051         map.
1052
1053         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1054         (AccessibilityUIElement::addNotificationListener):
1055         Call through to the AccessibilityController's addNotificationListener().
1056
1057         * DumpRenderTree/win/DumpRenderTreeWin.h:
1058         Add an extern declaration for the shared FrameLoadDelegate extern, so we
1059         can access it from AccessibilityController.
1060
1061         * DumpRenderTree/win/FrameLoadDelegate.h:
1062         (FrameLoadDelegate::accessibilityController):
1063         Return the AccessibilityController.
1064
1065 2010-01-29  Shinichiro Hamaji  <hamaji@chromium.org>
1066
1067         Reviewed by Darin Adler.
1068
1069         prepare-ChangeLog outputs useless messages for a nonexistent bug ID
1070         https://bugs.webkit.org/show_bug.cgi?id=34313
1071
1072         * Scripts/prepare-ChangeLog:
1073
1074 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1075
1076         Rubberstamped by Simon Hausmann.
1077
1078         [Qt] Separate implementation from class definition.
1079
1080         * QtLauncher/main.cpp:
1081         (LauncherWindow::webView):
1082         (LauncherWindow::LauncherWindow):
1083         (LauncherWindow::~LauncherWindow):
1084         (LauncherWindow::keyPressEvent):
1085         (LauncherWindow::grabZoomKeys):
1086         (LauncherWindow::sendTouchEvent):
1087         (LauncherWindow::eventFilter):
1088         (LauncherWindow::loadStarted):
1089         (LauncherWindow::loadFinished):
1090         (LauncherWindow::showLinkHover):
1091         (LauncherWindow::zoomIn):
1092         (LauncherWindow::zoomOut):
1093         (LauncherWindow::resetZoom):
1094         (LauncherWindow::toggleZoomTextOnly):
1095         (LauncherWindow::print):
1096         (LauncherWindow::screenshot):
1097         (LauncherWindow::setEditable):
1098         (LauncherWindow::dumpHtml):
1099         (LauncherWindow::selectElements):
1100         (LauncherWindow::setTouchMocking):
1101         (LauncherWindow::newWindow):
1102         (LauncherWindow::setupUI):
1103
1104 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1105
1106         Reviewed by Ariya Hidayat.
1107
1108         [Qt] On Maemo5, a click/touch in the location bar (when unfocused)
1109         should result in all text selected.
1110
1111         * QtLauncher/locationedit.cpp:
1112         (LocationEdit::focusInEvent):
1113         * QtLauncher/locationedit.h:
1114
1115 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1116
1117         Reviewed by Ariya Hidayat.
1118
1119         [Qt] Show progress reaching 100% for loads.
1120
1121         * QtLauncher/locationedit.cpp:
1122         (LocationEdit::LocationEdit):
1123         (LocationEdit::setProgress):
1124         (LocationEdit::reset):
1125         (LocationEdit::paintEvent):
1126         * QtLauncher/locationedit.h:
1127
1128 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
1129
1130         Reviewed by Kenneth Rohde Christiansen.
1131
1132         [Qt] Disable the QtLauncher statusbar on Maemo
1133
1134         https://bugs.webkit.org/show_bug.cgi?id=34330
1135
1136         * QtLauncher/main.cpp:
1137         (LauncherWindow::showLinkHover):
1138         (LauncherWindow::selectElements):
1139
1140 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
1141
1142         Reviewed by Kenneth Rohde Christiansen.
1143
1144         [Qt] Display page loading progress inside the QtLauncher location bar
1145
1146         https://bugs.webkit.org/show_bug.cgi?id=34210
1147
1148         * QtLauncher/QtLauncher.pro:
1149         * QtLauncher/locationedit.cpp: Added.
1150         (LocationEdit::LocationEdit):
1151         (LocationEdit::setProgress):
1152         (LocationEdit::paintEvent):
1153         * QtLauncher/locationedit.h: Added.
1154         * QtLauncher/mainwindow.cpp:
1155         (MainWindow::buildUI):
1156         * QtLauncher/mainwindow.h:
1157
1158 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
1159
1160         Reviewed by Kenneth Rohde Christiansen.
1161
1162         [Qt] Add support for Maemo zoom keys in QtLauncher
1163
1164         https://bugs.webkit.org/show_bug.cgi?id=34160
1165
1166         * QtLauncher/main.cpp:
1167         (LauncherWindow::LauncherWindow):
1168         (LauncherWindow::~LauncherWindow):
1169         (LauncherWindow::keyPressEvent):
1170         (LauncherWindow::grabZoomKeys):
1171
1172 2010-01-29  Benjamin Poulain  <benjamin.poulain@nokia.com>
1173
1174         Reviewed by Kenneth Rohde Christiansen.
1175
1176         [Qt] Implement the display() method of the layout test controller
1177         https://bugs.webkit.org/show_bug.cgi?id=34258
1178
1179         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1180         (WebCore::DumpRenderTree::DumpRenderTree):
1181         (WebCore::DumpRenderTree::showPage):
1182         (WebCore::DumpRenderTree::hidePage):
1183         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1184         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1185         (LayoutTestController::reset):
1186         (LayoutTestController::display):
1187         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1188
1189 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
1190
1191         [wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation
1192         implements pthread_t in a way that makes it impossible to check its validity,
1193         which is needed by ThreadingPthreads.cpp.
1194
1195         * DumpRenderTree/wscript:
1196         * wx/build/settings.py:
1197
1198 2010-01-28  Andras Becsi  <abecsi@webkit.org>
1199
1200         Adding myself to the committer list. No review needed.
1201
1202         * Scripts/webkitpy/committers.py:
1203
1204 2010-01-28  Hayato Ito  <hayato@chromium.org>
1205
1206         Reviewed by David Levin.
1207
1208         Remove NULL char from input JS file because 'grep' fails if the file contains NULL char.
1209
1210         https://bugs.webkit.org/show_bug.cgi?id=34252
1211
1212         * Scripts/make-script-test-wrappers:
1213
1214 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
1215
1216         [wx] Build fix after removal of the zlib image decoder.
1217
1218         * wx/build/settings.py:
1219
1220 2010-01-28  Csaba Osztrogonác  <ossy@webkit.org>
1221
1222         [Qt] Unreviewed, roll out r54000.
1223
1224         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1225         (WebCore::DumpRenderTree::DumpRenderTree):
1226         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1227         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1228         (LayoutTestController::reset):
1229         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1230         (LayoutTestController::display):
1231
1232 2010-01-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1233
1234         Reviewed by Kenneth Rohde Christiansen.
1235
1236         [Qt] Implement the display() method of the layout test controller
1237         https://bugs.webkit.org/show_bug.cgi?id=34258
1238
1239         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1240         (WebCore::DumpRenderTree::DumpRenderTree):
1241         (WebCore::DumpRenderTree::showPage):
1242         (WebCore::DumpRenderTree::hidePage):
1243         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1244         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1245         (LayoutTestController::reset):
1246         (LayoutTestController::display):
1247         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1248
1249 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
1250
1251         Reviewed by Shinichiro Hamaji.
1252
1253         Eliminated the filename parameter from functions in
1254         check-webkit-style's cpp.py where it is no longer used.
1255
1256         https://bugs.webkit.org/show_bug.cgi?id=34249
1257
1258         * Scripts/webkitpy/style/processors/cpp.py:
1259           - Reduced number of occurrences of "filename" variable from
1260             approximately 200 to 120.
1261
1262         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1263           - Refactored unit tests as necessary to accommodate changes to cpp.py.
1264           - Fixed bug in CppStyleTestBase.perform_include_what_you_use()
1265             where the incorrect file extension was getting passed to
1266             cpp_style.check_language().
1267
1268 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
1269
1270         Reviewed by Shinichiro Hamaji.
1271
1272         In check-webkit-style, eliminated the dependency of
1273         processors/cpp_unittest.py on checker.py.
1274
1275         https://bugs.webkit.org/show_bug.cgi?id=34205
1276
1277         * Scripts/webkitpy/style/checker.py:
1278           - Addressed FIXME by removing STYLE_CATEGORIES data.
1279           - Added style_categories().
1280
1281         * Scripts/webkitpy/style/checker_unittest.py:
1282           - Minor changes.
1283
1284         * Scripts/webkitpy/style/processors/cpp.py:
1285           - Added categories attribute to CppProcessor class (data
1286             was originally checker.STYLE_CATEGORIES).
1287
1288         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1289           - Addressed FIXME by eliminating "import" from checker.py.
1290
1291 2010-01-28  Anton Muhin  <antonm@chromium.org>
1292
1293         Reviewed by Shinichiro Hamaji.
1294
1295         Improve treatment of conditions and rest of the line for if, else, switch and alikes
1296         https://bugs.webkit.org/show_bug.cgi?id=34173
1297
1298         * Scripts/webkitpy/style/cpp_style.py:
1299         * Scripts/webkitpy/style/cpp_style_unittest.py:
1300
1301 2010-01-28  Joe Mason  <jmason@rim.com>
1302
1303         Reviewed by Adam Barth.
1304
1305         Limit login retries to 5
1306         https://bugs.webkit.org/show_bug.cgi?id=34193
1307
1308         * Scripts/webkitpy/bugzilla.py:
1309
1310 2010-01-27  Martin Robinson  <mrobinson@webkit.org>
1311
1312         Adding myself to the committer list. No review necessary.
1313
1314         * Scripts/webkitpy/committers.py:
1315
1316 2010-01-27  George Wright  <gwright@rim.com>
1317
1318         Reviewed by Adam Treat.
1319
1320         https://bugs.webkit.org/show_bug.cgi?id=34216
1321
1322         Add missing include for wtf/Platform.h
1323
1324         * DumpRenderTree/AccessibilityController.h:
1325
1326 2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1327
1328         Reviewed by Kenneth Rohde Christiansen.
1329
1330         [Qt] DRT Provide worker thread ability to track counters
1331         https://bugs.webkit.org/show_bug.cgi?id=34221
1332
1333         Implement workerThreadCount() in LayoutTestController of Qt DRT
1334
1335         Tests:
1336         fast/workers/dedicated-worker-lifecycle.html
1337         fast/workers/shared-worker-frame-lifecycle.html
1338         fast/workers/shared-worker-lifecycle.html
1339         fast/workers/worker-lifecycle.html
1340
1341         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1342         (LayoutTestController::workerThreadCount):
1343         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1344
1345 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1346
1347         Rubberstamped by Simon Hausmann.
1348
1349         [Qt] QtLauncher refactoring:
1350
1351         Make the LauncherWindow depend less on the view, so that more
1352         code can be shared in near future.
1353
1354         * QtLauncher/main.cpp:
1355         (LauncherWindow::sendTouchEvent):
1356         (LauncherWindow::loadFinished):
1357         (LauncherWindow::zoomIn):
1358         (LauncherWindow::zoomOut):
1359         (LauncherWindow::resetZoom):
1360         (LauncherWindow::toggleZoomTextOnly):
1361         (LauncherWindow::dumpHtml):
1362         (LauncherWindow::selectElements):
1363         (LauncherWindow::setupUI):
1364
1365 2010-01-27  Kinuko Yasuda  <kinuko@chromium.org>
1366
1367         Reviewed by Eric Seidel.
1368
1369         Correctly handle the KeyLocation argument that has been introduced
1370         recently to test location-dependent key events in EventSender.keyDown.
1371         http://bugs.webkit.org/show_bug.cgi?id=28247
1372
1373         Test: fast/events/keydown-numpad-keys.html
1374
1375         * DumpRenderTree/gtk/EventSender.cpp:
1376         (keyDownCallback):
1377
1378 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1379
1380         Rubberstamped by Simon Hausmann.
1381
1382         [Qt] QtLauncher refactoring:
1383
1384         Move out code from the MainWindow (renamed to LauncherWindow)
1385         that is not depending on the view, and add it to a new class
1386         called MainWindow.
1387
1388         * QtLauncher/QtLauncher.pro:
1389         * QtLauncher/main.cpp:
1390         (LauncherWindow::LauncherWindow):
1391         (LauncherWindow::eventFilter):
1392         (LauncherWindow::loadStarted):
1393         (LauncherWindow::loadFinished):
1394         (LauncherWindow::newWindow):
1395         (LauncherWindow::setupUI):
1396         (WebPage::createWindow):
1397         (main):
1398         * QtLauncher/mainwindow.cpp: Added.
1399         (MainWindow::MainWindow):
1400         (MainWindow::buildUI):
1401         (MainWindow::page):
1402         (MainWindow::setAddressUrl):
1403         (MainWindow::addCompleterEntry):
1404         (MainWindow::load):
1405         (MainWindow::changeLocation):
1406         (MainWindow::openFile):
1407         * QtLauncher/mainwindow.h: Added.
1408
1409 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1410
1411         Rubberstamped by Simon Hausmann.
1412
1413         [Qt] QtLauncher, coding style fixes.
1414
1415         * QtLauncher/main.cpp:
1416         (MainWindow::MainWindow):
1417         (MainWindow::sendTouchEvent):
1418         (MainWindow::eventFilter):
1419         (MainWindow::loadURL):
1420         (MainWindow::setupUI):
1421         (WebPage::createPlugin):
1422
1423 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1424
1425         Rubberstamped by Simon Hausmann.
1426
1427         [Qt] QtLauncher refactoring, separating the webview and
1428         adding a QGraphicsWebView based version.
1429
1430         * QtLauncher/QtLauncher.pro:
1431         * QtLauncher/main.cpp:
1432         (MainWindow::MainWindow):
1433         * QtLauncher/webpage.h:
1434         * QtLauncher/webview.cpp: Added.
1435         (createContextMenu):
1436         (WebViewGraphicsBased::mousePressEvent):
1437         (WebViewTraditional::mousePressEvent):
1438         (WebViewGraphicsBased::contextMenuEvent):
1439         (WebViewTraditional::contextMenuEvent):
1440         * QtLauncher/webview.h: Added.
1441         (WebViewGraphicsBased::WebViewGraphicsBased):
1442         (WebViewTraditional::WebViewTraditional):
1443
1444 2010-01-27  Alexander Pavlov  <apavlov@chromium.org>
1445
1446         Adding myself as committer. No review necessary.
1447
1448         * Scripts/webkitpy/committers.py:
1449
1450 2010-01-27  Eric Seidel  <eric@webkit.org>
1451
1452         Reviewed by Darin Adler.
1453
1454         webkit-patch needs an open-bugs command
1455         https://bugs.webkit.org/show_bug.cgi?id=30793
1456
1457         * Scripts/test-webkitpy: import OpenBugsTest
1458         * Scripts/webkit-patch: import OpenBugs
1459         * Scripts/webkitpy/commands/download_unittest.py: don't import unittest
1460         * Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto
1461         * Scripts/webkitpy/commands/queries_unittest.py: ditto
1462         * Scripts/webkitpy/commands/queues_unittest.py: ditto
1463         * Scripts/webkitpy/commands/upload_unittest.py: ditto
1464         * Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called.
1465
1466 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1467
1468         Rubberstamped by Simon Hausmann
1469
1470         [Qt] QtLauncher refactoring, separating utility methods.
1471
1472         * QtLauncher/QtLauncher.pro:
1473         * QtLauncher/main.cpp:
1474         * QtLauncher/utils.cpp: Added.
1475         (urlFromUserInput):
1476         * QtLauncher/utils.h: Added.
1477
1478 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1479
1480         Rubberstamped by Simon Hausmann
1481
1482         [Qt] Refactor the code in the QtLauncher dealing with HTTP proxy.
1483
1484         * QtLauncher/main.cpp:
1485         (MainWindow::MainWindow):
1486         * QtLauncher/webpage.cpp:
1487         (WebPage::WebPage):
1488         (WebPage::applyProxy):
1489         * QtLauncher/webpage.h:
1490
1491 2010-01-26  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1492
1493         Reviewed by Tor Arne Vestbø.
1494
1495         [Qt] Corrects debug build of DumpRenderTree on Windows.
1496
1497         * DumpRenderTree/qt/DumpRenderTree.pro:
1498
1499 2010-01-26  Daniel Bates  <dbates@webkit.org>
1500
1501         Reviewed by Adam Barth.
1502
1503         https://bugs.webkit.org/show_bug.cgi?id=34070
1504
1505         Moves the try/catch for OSError exceptions in Executive.run_command
1506         to Credentials.read_credentials() so that the unit test
1507         webkitpy.scm_unittest.SCMClassTests.test_error_handlers can
1508         assert that Executive.run_command throws an OSError exception.
1509
1510         * Scripts/webkitpy/credentials.py:
1511         * Scripts/webkitpy/executive.py: Moved try/catch for OSError to
1512         method Credentials.read_credentials().
1513         * Scripts/webkitpy/executive_unittest.py: Removed tests that no longer
1514         apply: test_run_command_with_bad_command_check_return_code and
1515         test_run_command_with_bad_command_check_calls_error_handler. Added new
1516         test to assert that run_command throws OSError exceptions.
1517
1518 2010-01-26  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1519
1520         Reviewed by Kenneth Rohde Christiansen.
1521
1522         [Qt] DRT WebHistory support
1523         https://bugs.webkit.org/show_bug.cgi?id=34167
1524
1525         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1526         (LayoutTestController::reset):
1527         (LayoutTestController::webHistoryItemCount):
1528         (LayoutTestController::keepWebHistory):
1529         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1530
1531 2010-01-26  Kent Tamura  <tkent@chromium.org>
1532
1533         Reviewed by Eric Seidel.
1534
1535         [Win] Add modifiers parameter support to Windows DumpRenderTree
1536         https://bugs.webkit.org/show_bug.cgi?id=34068
1537
1538         Add support for functional name modifiers; "addSelectionKey" and
1539         "rangeSelectionKey", and modifiers parameter to eventSender.mouseDown()
1540         and eventSender.mouseUp().
1541         This change is similar to r53498 for Mac.
1542         
1543         * DumpRenderTree/win/EventSender.cpp:
1544         (buildModifierFlags): New function to set MK_CONTROL or MK_SHIFT to WPARAM.
1545         (mouseDownCallback): Call buidlModifiersFlags().
1546         (mouseUpCallback): ditto.
1547         (keyDownCallback): Add support for "addSelectionkey" and "rangeSelectionKey".
1548
1549 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
1550
1551         Reviewed by Eric Seidel.
1552
1553         The Python autoinstall cache directory now only gets created
1554         in the directory containing autoinstall.py.
1555
1556         https://bugs.webkit.org/show_bug.cgi?id=33365
1557
1558         * Scripts/webkitpy/autoinstall.py:
1559           - Also added a README file to the cache directory saying
1560             where it came from.
1561
1562 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
1563
1564         Reviewed by Eric Seidel.
1565
1566         Moved the check-webkit-style processors into a new
1567         webkitpy/style/processors directory.
1568
1569         https://bugs.webkit.org/show_bug.cgi?id=34060
1570
1571         * Scripts/webkitpy/style/checker.py:
1572         * Scripts/webkitpy/style/checker_unittest.py:
1573         * Scripts/webkitpy/style/cpp_style.py: Removed.
1574         * Scripts/webkitpy/style/cpp_style_unittest.py: Removed.
1575         * Scripts/webkitpy/style/processors: Added.
1576         * Scripts/webkitpy/style/processors/__init__.py: Added.
1577         * Scripts/webkitpy/style/processors/cpp.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style.py.
1578         * Scripts/webkitpy/style/processors/cpp_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py.
1579         * Scripts/webkitpy/style/processors/text.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style.py.
1580         * Scripts/webkitpy/style/processors/text_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style_unittest.py.
1581         * Scripts/webkitpy/style/text_style.py: Removed.
1582         * Scripts/webkitpy/style/text_style_unittest.py: Removed.
1583         * Scripts/webkitpy/style/unittests.py:
1584
1585 2010-01-26  Kevin Ollivier  <kevino@theolliviers.com>
1586
1587         [wx] Build fix, make sure stub function returns a value.
1588
1589         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1590         (LayoutTestController::counterValueForElementById):
1591
1592 2010-01-26  Steve Falkenburg  <sfalken@apple.com>
1593
1594         Reviewed by Oliver Hunt.
1595
1596         Windows build references non-existent include paths
1597         https://bugs.webkit.org/show_bug.cgi?id=34175
1598
1599         * DumpRenderTree/win/DumpRenderTree.vcproj:
1600         * DumpRenderTree/win/ImageDiff.vcproj:
1601         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1602
1603 2010-01-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1604
1605         Reviewed by Ariya Hidayat.
1606
1607         [Qt] Separating out the UrlLoader from the QtLauncher in it's
1608         own implementation and header file.
1609
1610         * QtLauncher/main.cpp:
1611         (main):
1612         * QtLauncher/urlloader.cpp: Added.
1613         (UrlLoader::UrlLoader):
1614         (UrlLoader::loadNext):
1615         (UrlLoader::init):
1616         (UrlLoader::getUrl):
1617         * QtLauncher/urlloader.h: Added.
1618
1619 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
1620
1621         Reviewed by Shinichiro Hamaji.
1622
1623         Refactored check-webkit-style by removing the file path
1624         parameter from the style error handler functions.
1625
1626         https://bugs.webkit.org/show_bug.cgi?id=34031
1627
1628         * Scripts/webkitpy/style/checker.py:
1629           - Added _default_style_error_handler() to StyleChecker class.
1630           - Moved handle_style_error() to inside _default_style_error_handler().
1631
1632         * Scripts/webkitpy/style/checker_unittest.py:
1633           - Removed file path from calls to error handler.
1634
1635         * Scripts/webkitpy/style/cpp_style.py:
1636           - Removed file path from calls to error handler.
1637
1638         * Scripts/webkitpy/style/cpp_style_unittest.py:
1639           - Removed file path from calls to error handler.
1640
1641         * Scripts/webkitpy/style/text_style.py:
1642           - Removed file path from calls to error handler.
1643
1644         * Scripts/webkitpy/style/text_style_unittest.py:
1645           - Removed file path from calls to error handler.
1646
1647 2010-01-25  Jeremy Orlow  <jorlow@chromium.org>
1648
1649         Adding myself as reviewer.  No review necessary.
1650
1651         * Scripts/webkitpy/committers.py:
1652
1653 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
1654
1655         Reviewed by Adam Barth.
1656
1657         Improved prepare-ChangeLog so that it preserves the relative
1658         indentation of a git commit message.
1659
1660         https://bugs.webkit.org/show_bug.cgi?id=34058
1661
1662         * Scripts/prepare-ChangeLog:
1663           - Also adjusted the script so that it does not add white
1664             space characters to empty lines.
1665
1666 2010-01-24  Eric Seidel  <eric@webkit.org>
1667
1668         No review, rolling out r53763.
1669         http://trac.webkit.org/changeset/53763
1670         https://bugs.webkit.org/show_bug.cgi?id=33895
1671
1672         Broke 20+ tests on Windows.
1673
1674         * Scripts/run-webkit-tests:
1675         * Scripts/webkitdirs.pm:
1676
1677 2010-01-24  Adam Barth  <abarth@webkit.org>
1678
1679         Rubber stamped by Eric Seidel.
1680
1681         More pep8 compliance.
1682
1683         * Scripts/webkitpy/mock_bugzillatool.py:
1684
1685 2010-01-24  Adam Barth  <abarth@webkit.org>
1686
1687         Rubber stamped by Eric Seidel.
1688
1689         More pep8 compliance.
1690
1691         * Scripts/webkitpy/executive.py:
1692         * Scripts/webkitpy/grammar.py:
1693
1694 2010-01-24  Adam Barth  <abarth@webkit.org>
1695
1696         Rubber stamped by Eric Seidel.
1697
1698         More pep8 compliance.
1699
1700         * Scripts/webkitpy/comments.py:
1701         * Scripts/webkitpy/committers.py:
1702         * Scripts/webkitpy/credentials.py:
1703
1704 2010-01-24  Adam Barth  <abarth@webkit.org>
1705
1706         Rubber stamped by Eric Seidel.
1707
1708         Make changelogs.py pass pep8.
1709
1710         * Scripts/webkitpy/changelogs.py:
1711
1712 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1713
1714         [Qt] Unreviewed build fix
1715
1716         * QtLauncher/QtLauncher.pro:
1717         * QtLauncher/webinspector.h:
1718
1719 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1720
1721         Rubberstamped by Simon Hausmann.
1722
1723         [Qt] Move the WebInspector class to it's own header file.
1724
1725         * QtLauncher/main.cpp:
1726         * QtLauncher/webinspector.h: Added.
1727         (WebInspector::WebInspector):
1728         (WebInspector::showEvent):
1729         (WebInspector::hideEvent):
1730
1731 2010-01-23  Robert Hogan  <robert@roberthogan.net>
1732
1733         Reviewed by Kenneth Rohde Christiansen.
1734
1735         Qt DRT: respect window.close() and window.closed()
1736         
1737         Qt DRT needs to maintain a correct count of open windows
1738         for windowCount(). It also needs to delete windows that
1739         have been closed by window.close().
1740         
1741         This fixes the following tests:
1742         
1743         plugins/destroy-during-npp-new.html
1744         fast/dom/Document/early-document-access.html
1745         fast/dom/Window/window-early-properties.html
1746         fast/events/open-window-from-another-frame.html
1747         fast/events/popup-blocking-click-in-iframe.html
1748         
1749         https://bugs.webkit.org/show_bug.cgi?id=32953
1750
1751         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1752         (WebCore::DumpRenderTree::DumpRenderTree):
1753         (WebCore::DumpRenderTree::createWindow):
1754         (WebCore::DumpRenderTree::windowCloseRequested):
1755         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1756         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1757         (LayoutTestController::maybeDump):
1758
1759 2010-01-23  Dan Bernstein  <mitz@apple.com>
1760
1761         Reviewed by Mark Rowe.
1762
1763         Added a user default for specifying a fallback frameworks path in case
1764         the bundle does not contain frameworks for the current Mac OS X version.
1765
1766         * WebKitLauncher/main.m:
1767         (fallbackMacOSXVersion): Added. Looks up the fallback version in a dictionary
1768         keyed by the FallbackSystemVersions user default and returns it.
1769         (main): If a frameworks directory for the current system version is not found,
1770         try the fallback.
1771
1772 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1773
1774         Reviewed by Simon Hausmann.
1775
1776         Make run-webkit-tests work under Cygwin for the Qt port
1777
1778         setPathForRunningWebKitApp() is implemented for the Qt port
1779         by using qmake to query for the location of the Qt libraries.
1780
1781         This requires the original environment (%ENV) to be untouched,
1782         so launchWithCurrentEnv() was refactored to launchWithEnv(),
1783         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
1784         instead. This has the added benefit of getting rid of the temp
1785         variables used for storing the current env.
1786
1787         openDumpTool() is also refactored a bit into platform-spesific,
1788         port-spesific, and generic environment variables.
1789
1790         Checks for undef was added a few places to fix Perl concat
1791         warnings when run-webkit-tests is aborted.
1792
1793         https://bugs.webkit.org/show_bug.cgi?id=33895
1794
1795         * Scripts/run-webkit-tests:
1796         * Scripts/webkitdirs.pm:
1797
1798 2010-01-22  Kevin Watters  <kevinwatters@gmail.com>
1799
1800         Reviewed by Kevin Ollivier.
1801
1802         [wx] Remove the Bakefile build system, which is no longer being used.
1803         
1804         https://bugs.webkit.org/show_bug.cgi?id=34022
1805
1806         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
1807         * wx/browser/browser.bkl: Removed.
1808         * wx/build-wxwebkit: Removed.
1809
1810 2010-01-22  Gustavo Noronha Silva  <gns@gnome.org>
1811
1812         Reviewed by Simon Fraser.
1813
1814         Reset zoom level to 1.0 when resetting view state. This is causing
1815         many tests to fail after svg/custom/text-zoom.xhtml changes the
1816         zoom level.
1817
1818         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1819         (resetDefaultsToConsistentValues):
1820
1821 2010-01-22  Steve Falkenburg  <sfalken@apple.com>
1822
1823         Reviewed by Darin Adler.
1824
1825         https://bugs.webkit.org/show_bug.cgi?id=34025
1826         Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.
1827
1828         * Scripts/build-webkit:
1829
1830 2010-01-22  Adam Barth  <abarth@webkit.org>
1831
1832         Unreviewed.  Arg.  Someone renamed limit to output_limit on me.
1833
1834         * Scripts/webkitpy/commands/queues.py:
1835
1836 2010-01-22  Adam Barth  <abarth@webkit.org>
1837
1838         Rubber stamped by Eric Seidel.
1839
1840         Make __init__.py and buildbot.py pass pep8 style checker.
1841
1842         * Scripts/webkitpy/__init__.py:
1843         * Scripts/webkitpy/buildbot.py:
1844
1845 2010-01-21  Joe Mason  <jmason@rim.com>
1846
1847         Reviewed by Adam Barth.
1848
1849         webkit-patch should retry on invalid password
1850         https://bugs.webkit.org/show_bug.cgi?id=33955
1851
1852         Ask for bugs.webkit.org authentication in a loop.
1853
1854         * Scripts/webkitpy/bugzilla.py:
1855
1856 2010-01-22  Adam Barth  <abarth@webkit.org>
1857
1858         Unreviewed.  Don't call seek on a NoneType.
1859
1860         * Scripts/webkitpy/statusserver.py:
1861
1862 2010-01-22  Petri Latvala  <petri.latvala@nomovok.com>
1863
1864         Reviewed by David Levin.
1865
1866         check-webkit-style breaks on files with unknown types
1867         https://bugs.webkit.org/show_bug.cgi?id=34001
1868
1869         For files with type FileType.NONE, dispatch_processor returns None.
1870
1871         * Scripts/webkitpy/style/checker.py: Don't call process_file with a processor of value None.
1872
1873 2010-01-22  Adam Barth  <abarth@webkit.org>
1874
1875         Reviewed by Eric Seidel.
1876
1877         Make bugzilla.py and webkitport.py conform to pep8
1878         https://bugs.webkit.org/show_bug.cgi?id=34015
1879
1880         This patch makes webkitport.py and bugzilla.py mostly conform to PEP8
1881         style as enforced by pep8.py.  I wasn't able to get rid of all the
1882         errors because I'm not sure how to wrap some lines properly.  Also,
1883         there are a few deprication errors that I couldn't resolve easily.
1884         However, this is a massive improvement in compliance.
1885
1886         * Scripts/webkitpy/bugzilla.py:
1887         * Scripts/webkitpy/webkitport.py:
1888
1889 2010-01-22  Adam Barth  <abarth@webkit.org>
1890
1891         Reviewed by Darin Adler.
1892
1893         Limit length of EWS results to 5MB
1894         https://bugs.webkit.org/show_bug.cgi?id=34016
1895
1896         Hopefully this will fix the bug where the results link doesn't appear.
1897         Our current theory is that the results blob is too big and the server
1898         is rejecting the request with a 500 error.  That causes us to re-try
1899         the post, but when we re-try the StringIO buffer has its seek pointer
1900         at the end.
1901
1902         * Scripts/webkitpy/commands/queues.py:
1903         * Scripts/webkitpy/statusserver.py:
1904
1905 2010-01-22  Chris Jerdonek  <cjerdonek@webkit.org>
1906
1907         Reviewed by Adam Barth.
1908
1909         Made check-webkit-style able to check patches when script not
1910         run from source root. Also consolidated external references
1911         to a single file.
1912
1913         https://bugs.webkit.org/show_bug.cgi?id=33791
1914
1915         * Scripts/check-webkit-style:
1916           - Changed to import style_references.py.
1917
1918         * Scripts/webkitpy/style/__init__.py:
1919           - Removed __path__ hack that allowed searching Scripts/ directory.
1920
1921         * Scripts/webkitpy/style/checker.py:
1922           - Changed to import style_references.py.
1923
1924         * Scripts/webkitpy/style_references.py: Added.
1925
1926 2010-01-22  Dmitry Titov  <dimich@chromium.org>
1927
1928         Reviewed by Maciej Stachowiak.
1929
1930         Fix the leak of ThreadIdentifiers in threadMap across threads.
1931         https://bugs.webkit.org/show_bug.cgi?id=32689
1932
1933         Add a new test to verify the ThreadIdentifiers are not reused across threads.
1934         The test runs in the beginning of DumpRenderTree and spawns 2 non-WTF treads sequentially,
1935         waiting for the previous thread to terminate before starting the next.
1936         The treads use WTF::currentThread() in their thread function. Without a fix, this
1937         causes both threads to have the same ThreadIdentifier which triggers ASSERT in thread function.
1938         It also starts another thread using WTF. Without the fix, this finds pthread handle from previous
1939         threads in the WTF threadMap and asserts in WTF::establishIdentifierForPthreadHandle().
1940         The test practically does not affect the DRT run time because the threads end immediately.
1941
1942         * DumpRenderTree/mac/DumpRenderTree.mm:
1943         (runThread): Test thread function.
1944         (testThreadIdentifierMap):
1945         (dumpRenderTree):
1946
1947 2010-01-22  Kent Tamura  <tkent@chromium.org>
1948
1949         Reviewed by Maciej Stachowiak.
1950
1951         Fix a bug that mouseDown:withModifiers: is never called.
1952         https://bugs.webkit.org/show_bug.cgi?id=33989
1953
1954         * DumpRenderTree/mac/EventSendingController.mm:
1955         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1956         (+[EventSendingController webScriptNameForSelector:]):
1957
1958 2010-01-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1959
1960         Rubberstamped by Antti Koivisto.
1961
1962         [Qt] Separate out the WebPage class into it's own
1963         cpp/header files. Also, removed the assumption that
1964         the view is a QWebView, in preparation of a merger
1965         of the two Qt WebKit launchers.
1966
1967         * QtLauncher/QtLauncher.pro:
1968         * QtLauncher/main.cpp:
1969         (WebView::mousePressEvent):
1970         * QtLauncher/webpage.cpp: Added.
1971         (WebPage::supportsExtension):
1972         (WebPage::extension):
1973         (WebPage::acceptNavigationRequest):
1974         (WebPage::openUrlInDefaultBrowser):
1975         * QtLauncher/webpage.h: Added.
1976         (WebPage::WebPage):
1977
1978 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
1979
1980         Reviewed by Shinichiro Hamaji.
1981
1982         Refactored to move file name and file-reading related code
1983         from cpp_style.py and text_style.py to checker.py.
1984
1985         https://bugs.webkit.org/show_bug.cgi?id=33775
1986
1987         * Scripts/check-webkit-style:
1988           - Updates caused by changes to checker.py.
1989
1990         * Scripts/webkitpy/style/checker.py:
1991           - Added SKIPPED_FILES_WITH_WARNING list.
1992           - Added SKIPPED_FILES_WITHOUT_WARNING list.
1993           - Added FileType class.
1994           - Added ProcessorDispatcher class.
1995           - In StyleChecker class:
1996             - Renamed process_patch() to check_patch().
1997             - Renamed process_file() to check_file().
1998             - Added _process_file().
1999             - Related refactoring.
2000             - Addressed check_patch() FIXME to share code with process_file().
2001
2002         * Scripts/webkitpy/style/checker_unittest.py:
2003           - Added ProcessorDispatcherSkipTest class.
2004           - Added ProcessorDispatcherDispatchTest class.
2005           - Added StyleCheckerCheckFileTest class.
2006
2007         * Scripts/webkitpy/style/cpp_style.py:
2008           - Renamed process_file_data() to _process_lines.
2009           - Removed process_file() (moved logic to checker.py).
2010           - Removed can_handle() (moved logic to checker.py).
2011           - Added CppProcessor class.
2012           - Removed is_exempt() (moved logic to checker.py).
2013           - Added process_file_data() back as a wrapper function.
2014
2015         * Scripts/webkitpy/style/cpp_style_unittest.py:
2016           - Removed test_can_handle().
2017           - Removed test_is_exempt().
2018           - Added CppProcessorTest class.
2019
2020         * Scripts/webkitpy/style/text_style.py:
2021           - Added TextProcessor class.
2022           - Removed process_file().
2023           - Removed can_handle().
2024
2025         * Scripts/webkitpy/style/text_style_unittest.py:
2026           - Removed test_can_handle().
2027           - Added TextProcessorTest class.
2028
2029 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
2030
2031         Reviewed by David Kilzer.
2032
2033         Create a unit-tested subroutine to parse patch files created
2034         by svn-create-patch.
2035
2036         https://bugs.webkit.org/show_bug.cgi?id=33475
2037
2038         * Scripts/VCSUtils.pm:
2039           - Added parseDiff().
2040           - Added parsePatch().
2041
2042         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Added.
2043           - Added unit tests for parseDiff().
2044
2045         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
2046           - Total number of tests now computed dynamically.
2047
2048         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl: Added.
2049           - Added unit tests for parsePatch().
2050
2051 2010-01-21  Kevin Ollivier  <kevino@theolliviers.com>
2052
2053         [wx] Build fix, add new directory to dir list.
2054
2055         * wx/build/settings.py:
2056
2057 2010-01-21  Adam Barth  <abarth@webkit.org>
2058
2059         Reviewed by Eric Seidel.
2060
2061         Make the EWS transactional
2062         https://bugs.webkit.org/show_bug.cgi?id=33978
2063
2064         Now if the EWS gets interrupted in the middle of processing a patch,
2065         the bots will re-process the patch.
2066
2067         * Scripts/test-webkitpy:
2068         * Scripts/webkitpy/commands/queues.py:
2069         * Scripts/webkitpy/commands/queues_unittest.py:
2070         * Scripts/webkitpy/patchcollection.py:
2071         * Scripts/webkitpy/patchcollection_unittest.py: Added.
2072
2073 2010-01-21  Adam Barth  <abarth@webkit.org>
2074
2075         Unreviewed.  Add missing "ago" for style in the status bubble.
2076
2077         * QueueStatusServer/templates/statusbubble.html:
2078
2079 2010-01-21  Adam Barth  <abarth@webkit.org>
2080
2081         Reviewed by David Levin.
2082
2083         [style-queue] should not complain about identifier names with underscores under WebKit/gtk/webkit/
2084         https://bugs.webkit.org/show_bug.cgi?id=33356
2085
2086         White list unix_hacker_style names in WebKit/gtk/webkit because these
2087         are used in the GTK+ API.
2088
2089         * Scripts/webkitpy/style/cpp_style.py:
2090         * Scripts/webkitpy/style/cpp_style_unittest.py:
2091
2092 2010-01-21  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2093
2094         Reviewed by Kenneth Rohde Christiansen.
2095
2096         [Qt] add setDomainRelaxationForbiddenForURLScheme in Qt DRT
2097         https://bugs.webkit.org/show_bug.cgi?id=33945
2098
2099         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2100         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2101         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2102
2103 2010-01-21  Simon Hausmann  <simon.hausmann@nokia.com>
2104
2105         No review, rolling out 53615 as it causes two
2106         crashes on the bot.
2107
2108         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2109         (WebCore::DumpRenderTree::DumpRenderTree):
2110         (WebCore::DumpRenderTree::createWindow):
2111         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2112         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2113         (LayoutTestController::maybeDump):
2114
2115 2010-01-21  Robert Hogan  <robert@roberthogan.net>
2116
2117         Reviewed by Simon Hausmann.
2118
2119         Qt DRT: respect window.close() and window.closed()
2120
2121         Qt DRT needs to maintain a correct count of open windows
2122         for windowCount(). It also needs to delete windows that
2123         have been closed by window.close().
2124
2125         This fixes the following tests:
2126
2127         plugins/destroy-during-npp-new.html
2128         fast/dom/Document/early-document-access.html
2129         fast/dom/Window/window-early-properties.html
2130         fast/events/open-window-from-another-frame.html
2131         fast/events/popup-blocking-click-in-iframe.html
2132
2133         https://bugs.webkit.org/show_bug.cgi?id=32953
2134
2135         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2136         (WebCore::DumpRenderTree::DumpRenderTree):
2137         (WebCore::DumpRenderTree::createWindow):
2138         (WebCore::DumpRenderTree::windowCloseRequested):
2139         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2140         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2141         (LayoutTestController::maybeDump):
2142
2143 2010-01-20  Eric Seidel  <eric@webkit.org>
2144
2145         No review, rolling out r53593.
2146         http://trac.webkit.org/changeset/53593
2147         https://bugs.webkit.org/show_bug.cgi?id=33496
2148
2149         Re-rollout this patch, the commit-queue should not have landed
2150         it again, but it did due to land-diff and rollout both not
2151         clearing flags.
2152
2153         * Scripts/webkitpy/commands/early_warning_system.py:
2154         * Scripts/webkitpy/commands/queues.py:
2155         * Scripts/webkitpy/queueengine.py:
2156         * Scripts/webkitpy/scm.py:
2157         * Scripts/webkitpy/scm_unittest.py:
2158
2159 2010-01-20  Eric Seidel  <eric@webkit.org>
2160
2161         Reviewed by Adam Barth.
2162
2163         webkit-commit-queue status page is confusing
2164         https://bugs.webkit.org/show_bug.cgi?id=33496
2165
2166         This should improve the status page by removing more Fail messages.
2167         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
2168         to behave more like one another.  This meant moving where the failure reporting was done.
2169         Previously the AbstractReviewQueue always used the parent process to report the error,
2170         while CommitQueue used the subprocess when possible, and the parent only reported errors
2171         that we didn't know how to handle (bugs in the commit-queue itself).
2172         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
2173         in both implementations and required teaching handle_script_error in each to post Fail messages
2174         to the status server instead of calling exit(1).
2175
2176         This will also make the style-queue share more bug posting logic with other queues:
2177         https://bugs.webkit.org/show_bug.cgi?id=33871
2178
2179         * Scripts/webkitpy/commands/early_warning_system.py:
2180          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
2181            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
2182            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
2183            _update_status_for_script_error knows how to post the Fail message to the status server.
2184          - Teach _update_status_for_script_error how to post Fail messages to the status server.
2185         * Scripts/webkitpy/commands/queues.py:
2186          - Remove the try block from process_work_item since the caller already has one.
2187          - Only CC watchers on failure to cut down on commit-queue generated mail.
2188          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
2189          - Abstract _format_script_error_output_for_bug to share code between all queues.
2190          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
2191          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
2192          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
2193          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
2194         * Scripts/webkitpy/queueengine.py:
2195          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
2196         * Scripts/webkitpy/scm.py:
2197          - Add new checkout_revision function.
2198         * Scripts/webkitpy/scm_unittest.py:
2199          - Test our new checkout_revision function.
2200
2201 2010-01-20  Fumitoshi Ukai  <ukai@chromium.org>
2202
2203         Reviewed by Alexey Proskuryakov.
2204
2205         WebSocket: Missing Request-URI, when no tralling slash in host
2206         https://bugs.webkit.org/show_bug.cgi?id=33689
2207
2208         Update pywebsocket to 0.4.7.1, which supports alias for resource
2209         name, so that we could test for ws://127.0.0.1:8880
2210
2211         * Scripts/run-webkit-tests:
2212         * Scripts/run-webkit-websocketserver:
2213         * pywebsocket/mod_pywebsocket/dispatch.py:
2214         * pywebsocket/mod_pywebsocket/handshake.py:
2215         * pywebsocket/mod_pywebsocket/standalone.py:
2216         * pywebsocket/setup.py:
2217         * pywebsocket/test/test_dispatch.py:
2218         * pywebsocket/test/test_handshake.py:
2219
2220 2010-01-20  Eric Seidel  <eric@webkit.org>
2221
2222         No review, rolling out r53537.
2223         http://trac.webkit.org/changeset/53537
2224         https://bugs.webkit.org/show_bug.cgi?id=33496
2225
2226         Added a failure condition to the commit-queue and looks to
2227         have broken the EWS bots
2228
2229         * Scripts/webkitpy/commands/early_warning_system.py:
2230         * Scripts/webkitpy/commands/queues.py:
2231         * Scripts/webkitpy/queueengine.py:
2232         * Scripts/webkitpy/scm.py:
2233         * Scripts/webkitpy/scm_unittest.py:
2234
2235 2010-01-20  Jon Honeycutt  <jhoneycutt@apple.com>
2236
2237         MSAA: accSelect() is not implemented
2238
2239         https://bugs.webkit.org/show_bug.cgi?id=33918
2240         <rdar://problem/7436861>
2241
2242         Reviewed by Darin Adler.
2243
2244         * DumpRenderTree/AccessibilityUIElement.cpp:
2245         (takeFocusCallback):
2246         Call the object's takeFocus() function.
2247         (takeSelectionCallback):
2248         Call its takeSelection() function.
2249         (addSelectionCallback):
2250         Call its addSelection() function.
2251         (removeSelectionCallback):
2252         Call its removeSelection() function.
2253         (AccessibilityUIElement::getJSClass):
2254         Add new functions to the JS class definition.
2255
2256         * DumpRenderTree/AccessibilityUIElement.h:
2257         Declare new functions.
2258
2259         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2260         (AccessibilityUIElement::takeFocus):
2261         Stubbed.
2262         (AccessibilityUIElement::takeSelection):
2263         Stubbed.
2264         (AccessibilityUIElement::addSelection):
2265         Stubbed.
2266         (AccessibilityUIElement::removeSelection):
2267         Stubbed.
2268
2269         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2270         (AccessibilityUIElement::takeFocus):
2271         Stubbed.
2272         (AccessibilityUIElement::takeSelection):
2273         Stubbed.
2274         (AccessibilityUIElement::addSelection):
2275         Stubbed.
2276         (AccessibilityUIElement::removeSelection):
2277         Stubbed.
2278
2279         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2280         (AccessibilityUIElement::takeFocus):
2281         Call the object's accSelect() function, passing the appropriate flag.
2282         (AccessibilityUIElement::takeSelection):
2283         Ditto.
2284         (AccessibilityUIElement::addSelection):
2285         Ditto.
2286         (AccessibilityUIElement::removeSelection):
2287         Ditto.
2288
2289 2010-01-20  Andras Becsi  <abecsi@inf.u-szeged.hu>
2290
2291         Reviewed by Alexey Proskuryakov.
2292
2293         Extract Apache handling to httpd.pm module and use the provided functionality
2294         in scripts where Apache is needed.
2295         The module httpd.pm stores the PID of Apache in a variable and cleans up
2296         the PID directory after Apache properly shut down. Catching INT and TERM
2297         signals allows the scripts to close Apache and clean up its PID directory
2298         even if the testing was interrupted.
2299
2300         https://bugs.webkit.org/show_bug.cgi?id=33153
2301
2302         * Scripts/webkitperl/httpd.pm: Added.
2303         * Scripts/run-iexploder-tests:
2304         * Scripts/run-webkit-httpd:
2305         * Scripts/run-webkit-tests:
2306
2307 2010-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2308
2309         Reviewed by Simon Hausmann.
2310
2311         [Qt] Make DumpRenderTree build on Windows
2312
2313         * DumpRenderTree/qt/DumpRenderTree.pro:
2314         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2315         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2316         * DumpRenderTree/qt/main.cpp:
2317
2318 2010-01-20  Steve Block  <steveblock@google.com>
2319
2320         Reviewed by Eric Seidel.
2321
2322         Fix commit bot to land patches in order of the bug last modification date.
2323         https://bugs.webkit.org/show_bug.cgi?id=33395
2324
2325         * Scripts/webkitpy/bugzilla.py: Modified. Added 'order=Last+Changed' to bugzilla commit queue URL.
2326
2327 2010-01-20  Adam Barth  <abarth@webkit.org>
2328
2329         Reviewed by Eric Seidel.
2330
2331         Teach check-webkit-style about WebKit/gtk/tests
2332         https://bugs.webkit.org/show_bug.cgi?id=33892
2333
2334         Removes false positives found in
2335         https://bugs.webkit.org/show_bug.cgi?id=30883
2336
2337         * Scripts/webkitpy/style/cpp_style.py:
2338         * Scripts/webkitpy/style/cpp_style_unittest.py:
2339
2340 2010-01-20  Adam Barth  <abarth@webkit.org>
2341
2342         Reviewed by Eric Seidel.
2343
2344         Teach check-webkit-style about QGVLauncher
2345         https://bugs.webkit.org/show_bug.cgi?id=33890
2346
2347         Remove false positives found in
2348         https://bugs.webkit.org/show_bug.cgi?id=33708
2349
2350         * Scripts/webkitpy/style/cpp_style.py:
2351         * Scripts/webkitpy/style/cpp_style_unittest.py:
2352
2353 2010-01-20  Eric Seidel  <eric@webkit.org>
2354
2355         Reviewed by Adam Barth.
2356
2357         webkit-commit-queue status page is confusing
2358         https://bugs.webkit.org/show_bug.cgi?id=33496
2359
2360         This should improve the status page by removing more Fail messages.
2361         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
2362         to behave more like one another.  This meant moving where the failure reporting was done.
2363         Previously the AbstractReviewQueue always used the parent process to report the error,
2364         while CommitQueue used the subprocess when possible, and the parent only reported errors
2365         that we didn't know how to handle (bugs in the commit-queue itself).
2366         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
2367         in both implementations and required teaching handle_script_error in each to post Fail messages
2368         to the status server instead of calling exit(1).
2369
2370         This will also make the style-queue share more bug posting logic with other queues:
2371         https://bugs.webkit.org/show_bug.cgi?id=33871
2372
2373         * Scripts/webkitpy/commands/early_warning_system.py:
2374          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
2375            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
2376            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
2377            _update_status_for_script_error knows how to post the Fail message to the status server.
2378          - Teach _update_status_for_script_error how to post Fail messages to the status server.
2379         * Scripts/webkitpy/commands/queues.py:
2380          - Remove the try block from process_work_item since the caller already has one.
2381          - Only CC watchers on failure to cut down on commit-queue generated mail.
2382          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
2383          - Abstract _format_script_error_output_for_bug to share code between all queues.
2384          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
2385          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
2386          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
2387          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
2388         * Scripts/webkitpy/queueengine.py:
2389          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
2390         * Scripts/webkitpy/scm.py:
2391          - Add new checkout_revision function.
2392         * Scripts/webkitpy/scm_unittest.py:
2393          - Test our new checkout_revision function.
2394
2395 2010-01-20  Adam Barth  <abarth@webkit.org>
2396
2397         Reviewed by Darin Adler.
2398
2399         Exempt JavaScriptCore/qt/api from style checks
2400         https://bugs.webkit.org/show_bug.cgi?id=33879
2401
2402         Apparently there is a JavaScriptCore API for Qt as well as a WebKit
2403         API.
2404
2405         * Scripts/webkitpy/style/cpp_style.py:
2406         * Scripts/webkitpy/style/cpp_style_unittest.py:
2407
2408 2010-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2409
2410         Reviewed by Simon Hausmann.
2411
2412         [Qt] Don't use QSocketNotifier in the DRT for reading stdin
2413
2414         QSocketNotifier is not available on Windows. Instead we read
2415         stdin synchronously after each test using signals and slots.
2416
2417         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2418         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2419         * DumpRenderTree/qt/main.cpp:
2420
2421 2010-01-19  Adam Barth  <abarth@webkit.org>
2422
2423         Rubber stamped by Eric Seidel.
2424
2425         Move chromium-ews back to building release only to make the EWS faster.
2426
2427         * Scripts/webkitpy/commands/early_warning_system.py:
2428
2429 2010-01-17  Jon Honeycutt  <jhoneycutt@apple.com>
2430
2431         MSAA: The child <option> elements of a non-multiple <select> are not
2432         exposed
2433
2434         https://bugs.webkit.org/show_bug.cgi?id=33773
2435         <rdar://problem/7550556>
2436
2437         Reviewed by Alice Liu.
2438
2439         * DumpRenderTree/AccessibilityUIElement.cpp:
2440         (getIsVisibleCallback):
2441         Call the object's isVisible() function.
2442         (getIsOffScreenCallback):
2443         Ditto, for isOffScreen().
2444         (getIsCollapsedCallback):
2445         Ditto, for isCollapsed().
2446         (getHasPopupCallback):
2447         Ditto, for hasPopup().
2448         (AccessibilityUIElement::getJSClass):
2449         Add isVisible and isOffScreen attributes.
2450
2451         * DumpRenderTree/AccessibilityUIElement.h:
2452         Declare new functions.
2453
2454         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2455         (AccessibilityUIElement::isVisible):
2456         Stubbed.
2457         (AccessibilityUIElement::isOffScreen):
2458         Stubbed.
2459         (AccessibilityUIElement::isCollapsed):
2460         Stubbed.
2461         (AccessibilityUIElement::hasPopup):
2462         Stubbed.
2463
2464         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2465         (AccessibilityUIElement::isVisible):
2466         Stubbed.
2467         (AccessibilityUIElement::isOffScreen):
2468         Stubbed.
2469         (AccessibilityUIElement::isCollapsed):
2470         Stubbed.
2471         (AccessibilityUIElement::hasPopup):
2472         Stubbed.
2473
2474         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2475         (AccessibilityUIElement::showMenu):
2476         Call the object's accDoDefaultAction() to show its popup menu.
2477         (AccessibilityUIElement::isEnabled):
2478         Check that the object does not have the "unavailable" state.
2479         (AccessibilityUIElement::isVisible):
2480         Check that the object does not have the "invisible" state.
2481         (AccessibilityUIElement::isOffScreen):
2482         Check whether the object has the "offscreen" state.
2483         (AccessibilityUIElement::isCollapsed):
2484         Check whether the object has the "collapsed" state.
2485         (AccessibilityUIElement::hasPopup):
2486         Check whether the object has the "has popup" state.
2487
2488 2010-01-19  Victor Wang  <victorw@chromium.org>
2489
2490         Reviewed by Eric Seidel.
2491
2492         Correct committer name.
2493         https://bugs.webkit.org/show_bug.cgi?id=33868
2494
2495         * Scripts/webkitpy/committers.py:
2496
2497 2010-01-19  Kent Tamura  <tkent@chromium.org>
2498
2499         Reviewed by Darin Adler.
2500
2501         [DRT][Mac] Add modifiers parameter to eventSender.mouseDown() and eventSender.mouseUp()
2502         https://bugs.webkit.org/show_bug.cgi?id=33783
2503
2504         Some listbox tests check selection behavior by click events with
2505         "meta" or "shift" keys. Behaviors for such modifier keys are
2506         platform-dependent. The new parameter of mouseDown() and mouseUp()
2507         allows to specify not only concrete modifier keys such as
2508         "shiftKey" "metaKey", but also functional names like
2509         "addSelectionKey" "rangeSelectionKey".
2510
2511         * DumpRenderTree/mac/EventSendingController.mm:
2512         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2513         (+[EventSendingController webScriptNameForSelector:]):
2514         (buildModifierFlags):
2515         (-[EventSendingController mouseDown:withModifiers:]):
2516         (-[EventSendingController mouseDown:]):
2517         (-[EventSendingController mouseUp:withModifiers:]):
2518         (-[EventSendingController mouseUp:]):
2519         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2520
2521 2010-01-19  Adam Barth  <abarth@webkit.org>
2522
2523         Reviewed by Eric Seidel.
2524
2525         Unbreak --request-commit
2526         https://bugs.webkit.org/show_bug.cgi?id=33832
2527
2528         * Scripts/webkitpy/bugzilla.py:
2529
2530 2010-01-19  Eric Seidel  <eric@webkit.org>
2531
2532         Reviewed by Adam Barth.
2533
2534         validate-committer-lists throws exception and committers.py needs a refresh
2535         https://bugs.webkit.org/show_bug.cgi?id=33831
2536
2537         * Scripts/validate-committer-lists: use webkit_logging
2538         * Scripts/webkitpy/committers.py: Add recently minted committers.  Fix Simon Hausmanns email address list to include his webkit-committers@lists address.
2539
2540 2010-01-18  Adam Roben  <aroben@apple.com>
2541
2542         Add LayoutTestController support for calling new WebKit SPI to
2543         disallow setting document.domain
2544
2545         DRT part of fixing <http://webkit.org/b/33806>
2546         <rdar://problem/7552837> Would like API to disallow setting of
2547         document.domain for pages with certain URL schemes
2548
2549         Reviewed by Sam Weinig.
2550
2551         * DumpRenderTree/LayoutTestController.cpp:
2552         (setDomainRelaxationForbiddenForURLSchemeCallback): Added. Calls
2553         through to LayoutTestController.
2554         (LayoutTestController::staticFunctions): Added
2555         setDomainRelaxationForbiddenForURLScheme.
2556
2557         * DumpRenderTree/LayoutTestController.h: Added
2558         setDomainRelaxationForbiddenForURLScheme.
2559
2560         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2561         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2562         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2563         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2564         Added. Calls through to WebKit.
2565
2566         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2567         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2568         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2569         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2570         Stubbed out.
2571
2572 2010-01-18  Adam Barth  <abarth@webkit.org>
2573
2574         Reviewed by Adam Roben.
2575
2576         Rename patches-to-commit to patches-in-commit-queue
2577         https://bugs.webkit.org/show_bug.cgi?id=33789
2578
2579         The command really lists the patches in the commit-queue not all the
2580         patches that are pending-commit (as the FIXME commands).
2581
2582         * Scripts/webkitpy/commands/queries.py:
2583         * Scripts/webkitpy/commands/queries_unittest.py:
2584
2585 2010-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2586
2587         Reviewed by Simon Hausmann.
2588
2589         [Qt] Force qmake to generate a single makefile for DerivedSources.pro
2590
2591         * Scripts/webkitdirs.pm:
2592
2593 2010-01-18  Adam Roben  <aroben@apple.com>
2594
2595         Clean up use of /useenv when invoking Visual C++
2596
2597         This change reverts things to their pre-r49485 state. That revision
2598         (and, subsequently, r49664 and r51788) started passing /useenv to
2599         Visual C++, even in cases where we don't want to do so (such as when
2600         invoking Visual C++ Express), in the name of making the Chromium build
2601         work. Now that Chromium isn't using buildVisualStudioProject or
2602         pdevenv, we can put things back they way they were.
2603
2604         Fixes <http://webkit.org/b/33797> build-webkit fails with VC++ Express
2605         (due to /useenv flag)
2606
2607         Reviewed by Sam Weinig.
2608
2609         * Scripts/pdevenv: Always pass /useenv. Chromium doesn't use this
2610         script anymore.
2611         * Scripts/webkitdirs.pm:
2612         (buildVisualStudioProject): Never pass /useenv anymore. pdevenv takes
2613         care of this itself, and we don't want to pass /useenv when not using
2614         pdevenv (e.g., when using VC++ Express, because that will cause it to
2615         ignore the Platform SDK).
2616
2617 2010-01-18  Adam Barth  <abarth@webkit.org>
2618
2619         Reviewed by Eric Seidel.
2620
2621         webkit-patch land-safely should obsolete old patches
2622         https://bugs.webkit.org/show_bug.cgi?id=33788
2623
2624         When posting a commit-queue+ patch with land-safely, we should
2625         obsolete the old patches on the bug.  They're really confusing
2626         because the main use case is to address reviewer feedback on a
2627         previous patch.
2628
2629         * Scripts/webkitpy/commands/upload.py:
2630         * Scripts/webkitpy/commands/upload_unittest.py:
2631
2632 2010-01-18  Adam Barth  <abarth@webkit.org>
2633
2634         Reviewed by David Levin.
2635
2636         webkit-patch should authenticate more often
2637         https://bugs.webkit.org/show_bug.cgi?id=33701
2638
2639         This makes it easier to work with security patches.
2640
2641         * Scripts/webkitpy/bugzilla.py:
2642
2643 2010-01-18  Adam Barth  <abarth@webkit.org>
2644
2645         Reviewed by Darin Adler.
2646
2647         style checker needs to know about GObject-specific requirements
2648         inside WebCore/bindings/gobject/
2649         https://bugs.webkit.org/show_bug.cgi?id=33606
2650
2651         Add an exception to the underscore rule for certain
2652         GObject-specific names.
2653
2654         * Scripts/webkitpy/style/cpp_style.py:
2655         * Scripts/webkitpy/style/cpp_style_unittest.py:
2656
2657 2010-01-18  Adam Barth  <abarth@webkit.org>
2658
2659         Reviewed by Shinichiro Hamaji.
2660
2661         [check-webkit-style] does understand ResourceHandleWin.h
2662         https://bugs.webkit.org/show_bug.cgi?id=32975
2663
2664         I'm not 100% convinced this fix is correct, but without more examples,
2665         it's hard to generalize.  We can always generalize the fix in the
2666         future.
2667
2668         * Scripts/webkitpy/style/cpp_style.py:
2669         * Scripts/webkitpy/style/cpp_style_unittest.py:
2670
2671 2010-01-18  Adam Barth  <abarth@webkit.org>
2672
2673         Unreviewed "build" fix.
2674
2675         * Scripts/webkitpy/bugzilla.py:
2676
2677 2010-01-18  Adam Barth  <abarth@webkit.org>
2678
2679         Unreviewed.  Actually make land-safely mark commit-queue+ as
2680         discussed with Eric.
2681
2682         * Scripts/webkitpy/bugzilla.py:
2683         * Scripts/webkitpy/steps/postdiffforcommit.py:
2684
2685 2010-01-17  Adam Barth  <abarth@webkit.org>
2686
2687         Reviewed by Darin Adler.
2688
2689         style-queue complains about one-line macros that include multiple statements
2690         https://bugs.webkit.org/show_bug.cgi?id=33173
2691
2692         Add an exception for multiple statements on a line that starts a macro.
2693
2694         * Scripts/webkitpy/style/cpp_style.py:
2695         * Scripts/webkitpy/style/cpp_style_unittest.py:
2696
2697 2010-01-17  Adam Barth  <abarth@webkit.org>
2698
2699         Reviewed by Darin Adler.
2700
2701         [check-webkit-style] qt unit testing false positives
2702         https://bugs.webkit.org/show_bug.cgi?id=32833
2703
2704         Exempt the Qt API and unit tests from the style checker.
2705
2706         * Scripts/webkitpy/style/cpp_style.py:
2707         * Scripts/webkitpy/style/cpp_style_unittest.py:
2708
2709 2010-01-17  Adam Barth  <abarth@webkit.org>
2710
2711         Reviewed by Darin Adler.
2712
2713         style-check script reports loads of errors on gtk2drawing.c
2714         https://bugs.webkit.org/show_bug.cgi?id=33771
2715
2716         Exempt WebCore/platform/gtk/gtk2drawing.c and
2717         WebCore/platform/gtk/gtk2drawing.h from style checks.
2718
2719         * Scripts/webkitpy/style/cpp_style.py:
2720         * Scripts/webkitpy/style/cpp_style_unittest.py:
2721
2722 2010-01-17  Chris Jerdonek  <cjerdonek@webkit.org>
2723
2724         Reviewed by Shinichiro Hamaji.
2725
2726         Finished eliminating _cpp_style_state global state variable from
2727         check-webkit-style code and eliminating _CppStyleState class.
2728
2729         https://bugs.webkit.org/show_bug.cgi?id=33764
2730
2731         * Scripts/webkitpy/style/checker.py:
2732           - Minor updates caused by changes to cpp_style.py.
2733
2734         * Scripts/webkitpy/style/cpp_style.py:
2735           - Removed _CppStyleState class.
2736           - Removed verbose_level functions.
2737           - Added verbosity as a parameter to _FunctionState constructor.
2738           - Added verbosity as a parameter to process_file().
2739           - Added verbosity as a parameter to process_file_data().
2740
2741         * Scripts/webkitpy/style/cpp_style_unittest.py:
2742           - Added helper functions to set verbosity while running tests.
2743
2744 2010-01-17  Adam Barth  <abarth@webkit.org>
2745
2746         Reviewed by Shinichiro Hamaji.
2747
2748         check-webkit-style underscore check should be disabled for Qt methods starting with qt_
2749         https://bugs.webkit.org/show_bug.cgi?id=33663
2750
2751         * Scripts/webkitpy/style/cpp_style.py:
2752         * Scripts/webkitpy/style/cpp_style_unittest.py:
2753
2754 2010-01-17  Adam Barth  <abarth@webkit.org>
2755
2756         Reviewed by Eric Seidel.
2757
2758         style-queue complains about missing #include of config.h for non-WebCore projects
2759         https://bugs.webkit.org/show_bug.cgi?id=33170
2760
2761         WebKitAPITests are consumers of the WebKit API and therefore do not
2762         need to follow the same include discipline as the rest of WebKit.  This
2763         patch exempts them from the include checks.
2764
2765         * Scripts/webkitpy/style/cpp_style.py:
2766         * Scripts/webkitpy/style/cpp_style_unittest.py:
2767
2768 2010-01-17  Adam Barth  <abarth@webkit.org>
2769
2770         Reviewed by Eric Seidel.
2771
2772         EWS (Early Warning Systems) should build both debug and release
2773         https://bugs.webkit.org/show_bug.cgi?id=33681
2774
2775         Build both debug and release for chromium-ews.
2776
2777         * Scripts/webkitpy/commands/early_warning_system.py:
2778
2779 2010-01-17  Adam Barth  <abarth@webkit.org>
2780
2781         Reviewed by Darin Adler.
2782
2783         style-queue should include instructions for how to file bugs against check-webkit-style
2784         https://bugs.webkit.org/show_bug.cgi?id=32345
2785
2786         Added some text to the error message asking folks to file bugs against
2787         false positives.
2788
2789         * Scripts/webkitpy/commands/queues.py:
2790
2791 2010-01-17  Chris Jerdonek  <cjerdonek@webkit.org>
2792
2793         Reviewed by Adam Barth.
2794
2795         Eliminated the error_count global variable and related
2796         check-webkit-style refactoring.
2797
2798         https://bugs.webkit.org/show_bug.cgi?id=33678
2799
2800         * Scripts/check-webkit-style:
2801           - Updated to use webkit_argument_defaults().
2802           - Renamed styleChecker to style_checker.
2803
2804         * Scripts/webkitpy/style/checker.py:
2805           - Prefixed the three default arguments with WEBKIT_DEFAULT.
2806           - Added webkit_argument_defaults().
2807           - Added default filter_rules parameter to CategoryFilter constructor.
2808           - Added __ne__() to CategoryFilter class.
2809           - Added __eq__() and __ne__() to ProcessorOptions class.
2810           - Added error_count and _write_error attributes to StyleChecker class.
2811           - Made StyleChecker._handle_error() increment the error count.
2812
2813         * Scripts/webkitpy/style/checker_unittest.py:
2814           - Improved CategoryFilterTest.test_eq().
2815           - Added CategoryFilterTest.test_ne().
2816           - Added test_eq() and test_ne() to ProcessorOptionsTest class.
2817           - Updated unit tests to use webkit_argument_defaults().
2818           - Added StyleCheckerTest class.
2819
2820         * Scripts/webkitpy/style/cpp_style.py:
2821           - Removed references to global error_count.
2822
2823         * Scripts/webkitpy/style/cpp_style_unittest.py:
2824           - Removed CppStyleStateTest class.
2825
2826 2010-01-15  Jon Honeycutt  <jhoneycutt@apple.com>
2827
2828         get_accParent should try to retrieve parent AccessibilityObject, before
2829         calling upon window
2830
2831         https://bugs.webkit.org/show_bug.cgi?id=22893
2832
2833         Reviewed by Darin Adler.
2834
2835         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2836         (AccessibilityUIElement::parentElement):
2837         Get the object's parent. Query it for IAccessible, and return it.
2838
2839 2010-01-16  Dan Bernstein  <mitz@apple.com>
2840
2841         Reviewed by Mark Rowe.
2842
2843         <rdar://problem/7529519> DumpRenderTree crashes in makeLargeMallocFailSilently()
2844
2845         * DumpRenderTree/mac/CheckedMalloc.cpp:
2846         (makeLargeMallocFailSilently): Temporarily allow writing to the default
2847         malloc zone structure while modifying it.
2848
2849 2010-01-16  David Kilzer  <ddkilzer@apple.com>
2850
2851         Added back removed properties to iExploder input files
2852
2853         While the update-iexploder-cssproperties script works great to
2854         add new properties, it has the side-effect of removing old
2855         properties that once were parsed.
2856
2857         * iExploder/htdocs/cssproperties.in: Added back removed
2858         properties into their own section.
2859         * iExploder/htdocs/htmlattrs.in: Ditto.
2860
2861 2010-01-16  Holger Hans Peter Freyther  <zecke@selfish.org>
2862
2863         Reviewed by David Kilzer.
2864
2865         Update iExploder/htdocs/*.in by running update-iexploder-cssproperties 
2866         https://bugs.webkit.org/show_bug.cgi?id=33756
2867
2868         * iExploder/htdocs/cssproperties.in: New CSS attributes
2869         * iExploder/htdocs/htmlattrs.in: New HTML attributes
2870         * iExploder/htdocs/htmltags.in: New HTML tags
2871
2872 2010-01-15  Chris Jerdonek  <chris.jerdonek@gmail.com>
2873
2874         Reviewed by David Kilzer.
2875
2876         Altered parseDiffHeader() to skip unrecognized lines and
2877         other minor clean-ups.
2878
2879         https://bugs.webkit.org/show_bug.cgi?id=33476
2880
2881         * Scripts/VCSUtils.pm:
2882           - Changed parseDiffHeader() as follows:
2883             - Skips over unrecognized lines.
2884             - Addressed FIXME to remove substitution for "diff" line.
2885             - Renamed "version" header hash key to "sourceRevision".
2886             - Eliminated "copiedFromVersion" header hash key.
2887             - Included "sourceRevision" also for copied files.
2888             - Checks that copy revision number matches "sourceRevision".
2889             - No longer returns $foundHeaderEnding.
2890             - Dies if header ending not found.
2891             - Diff header dividing line now always added.
2892
2893         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
2894           - Made necessary changes in parseDiffHeader() unit tests.
2895           - Shortened the file paths in some test cases.
2896
2897 2010-01-14  Yuzo Fujishima  <yuzo@google.com>
2898
2899         Reviewed by Alexey Proskuryakov.
2900
2901         Update pywebsocket to 0.4.6
2902         https://bugs.webkit.org/show_bug.cgi?id=32299
2903         The newer pywebsocket can handle more simultaneous connections.
2904
2905         * pywebsocket/mod_pywebsocket/handshake.py:
2906         * pywebsocket/mod_pywebsocket/standalone.py:
2907         * pywebsocket/setup.py:
2908         * pywebsocket/test/test_handshake.py:
2909
2910 2010-01-14  Eric Seidel  <eric@webkit.org>
2911
2912         Reviewed by Adam Barth.
2913
2914         REGRESSION(53133): commit-queue no longer rejects patches with invalid committers, instead it hangs
2915         https://bugs.webkit.org/show_bug.cgi?id=33638
2916
2917         * Scripts/webkitpy/bugzilla.py:
2918          - Add Bug.id() to match Attachment.id()
2919          - Give Bug.reviewed_patches and commit_queued_patches the option to return patches with invalid committers/reviewers.
2920          - Add back a missing variable to _validate_setter_email found by the new unit tests!
2921         * Scripts/webkitpy/commands/queries.py:
2922          - Add FIXMEs about the commands being confusingly named.
2923         * Scripts/webkitpy/commands/queries_unittest.py:
2924          - Update results to reflect the newly restructured mock bug cache.
2925         * Scripts/webkitpy/commands/queues.py:
2926          - Add a new _validate_patches_in_commit_queue method (this is what fixes the regression).
2927          - Add a FIXME about eventually sorting the patches into some order.
2928         * Scripts/webkitpy/commands/queues_unittest.py:
2929          - Update results now that with the newly restructure mock bug cache we're testing cq+'d patches with an invalid committer.
2930         * Scripts/webkitpy/commands/upload_unittest.py:
2931          - Update results to match the newly restructured mock bug cache.
2932         * Scripts/webkitpy/mock_bugzillatool.py:
2933          - Restructure fetch_ methods to not use a manual list of ids, but rather use Bug and Attachment classes to make real queries from all of the Bugs.
2934          - Add a few more attachments and bug dictionaries for use by the tests.
2935
2936 2010-01-13  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2937
2938         Reviewed by Kenneth Christiansen.
2939
2940         [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
2941         https://bugs.webkit.org/show_bug.cgi?id=33617
2942
2943         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2944         (WebCore::WebPage::resetSettings):
2945         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2946         (LayoutTestController::setUserStyleSheetLocation):
2947         (LayoutTestController::setUserStyleSheetEnabled):
2948         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2949
2950 2010-01-14  Adam Roben  <aroben@apple.com>
2951
2952         Add LayoutTestController API to force
2953         -webView:resource:willSendRequest:: to return null
2954
2955         Enables tests for <rdar://problem/7533333> <http://webkit.org/b/33533>
2956         window.onload never fires if page contains an <iframe> with a bad
2957         scheme or whose load is cancelled by returning null from resource load
2958         delegate's willSendRequest
2959
2960         Reviewed by Brady Eidson.
2961
2962         * DumpRenderTree/LayoutTestController.cpp:
2963         (LayoutTestController::LayoutTestController): Initialize new member.
2964         (setWillSendRequestReturnsNullCallback): Call through to
2965         LayoutTestController.
2966         (LayoutTestController::staticFunctions): Added new function.
2967
2968         * DumpRenderTree/LayoutTestController.h: Added
2969         m_willSendRequestReturnsNull.
2970         (LayoutTestController::willSendRequestReturnsNull):
2971         (LayoutTestController::setWillSendRequestReturnsNull):
2972         Added standard accessors.
2973
2974         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2975         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2976         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2977         (ResourceLoadDelegate::willSendRequest):
2978         Return null if LayoutTestController says to.
2979
2980 2010-01-14  Kevin Ollivier  <kevino@theolliviers.com>
2981
2982         [wx] Build fix after removal of XBM support.
2983
2984         * wx/build/settings.py:
2985
2986 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2987
2988         Reviewed by Simon Hausmann.
2989
2990         Add support for partial building on Symbian.
2991
2992         The build happens in the source directory as out of source builds are
2993         not supported by qmake for Symbian.
2994
2995         Also the actual build isn't started but it is left to the developer
2996         to choose the architecture/configuration.
2997
2998         * Scripts/webkitdirs.pm:
2999
3000 2010-01-14  Simon Hausmann  <simon.hausmann@nokia.com>
3001
3002         Reviewed by Kenneth Rohde Christiansen.
3003
3004         Add support for "detecting" Symbian environments by either
3005         looking for the EPOCROOT environment variable or via --symbian
3006         being passed on the commandline.
3007
3008         * Scripts/webkitdirs.pm:
3009
3010 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3011
3012         Unreviewed.
3013
3014         [Qt] Use a different Makefile names for sources generation and compilation.
3015         This prevents Makefile overwriting when running build-webkit twice.
3016
3017         * Scripts/webkitdirs.pm:
3018
3019 2010-01-14  Andreas Kling  <andreas.kling@nokia.com>
3020
3021         Reviewed by Kenneth Rohde Christiansen.
3022
3023         [Qt] Add an "alien_QLabel" classId for manual testing of alien widgets.
3024
3025         https://bugs.webkit.org/show_bug.cgi?id=33373
3026
3027         * QtLauncher/main.cpp:
3028         (WebPage::createPlugin):
3029
3030 2010-01-14  Eric Seidel  <eric@webkit.org>
3031
3032         No review, rolling out r53249.
3033         http://trac.webkit.org/changeset/53249
3034         https://bugs.webkit.org/show_bug.cgi?id=33617
3035
3036         This caused http/tests/security/local-user-CSS-from-
3037         remote.html to fail on the Qt Release Build Bot.
3038
3039         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3040         (WebCore::WebPage::resetSettings):
3041         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3042         (LayoutTestController::overridePreference):
3043         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3044
3045 2010-01-14  Chris Jerdonek  <chris.jerdonek@gmail.com>
3046
3047         Reviewed by Shinichiro Hamaji.
3048
3049         Moved error() from cpp_style.py to checker.py.
3050
3051         https://bugs.webkit.org/show_bug.cgi?id=33620
3052
3053         * Scripts/check-webkit-style:
3054           - Addressed FIXME to not set global state.
3055
3056         * Scripts/webkitpy/style/checker.py:
3057           - Added argument validation to ProcessorOptions constructor.
3058           - Added should_report_error() to ProcessorOptions class.
3059           - Removed set_options().
3060           - Added StyleChecker class.
3061
3062         * Scripts/webkitpy/style/checker_unittest.py:
3063           - Added unit test class for ProcessorOptions class.
3064           - Added unit test to check that parse() strips white space.
3065
3066         * Scripts/webkitpy/style/cpp_style.py:
3067           - Removed "filter" and "output_format" methods.
3068           - Removed should_print_error() and error() functions.
3069           - Removed default parameter value from process_file().
3070
3071         * Scripts/webkitpy/style/cpp_style_unittest.py:
3072           - Removed call to cpp_style._should_print_error().
3073           - Removed test_filter() and test_filter_appending().
3074
3075         * Scripts/webkitpy/style/text_style.py:
3076           - Removed default parameter value from process_file().
3077
3078 2010-01-14  Diego Gonzalez  <diego.gonzalez@openbossa.org>
3079
3080         Reviewed by Kenneth Rohde Christiansen.
3081
3082         [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
3083         https://bugs.webkit.org/show_bug.cgi?id=33617
3084
3085         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3086         (WebCore::WebPage::resetSettings):
3087         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3088         (LayoutTestController::setUserStyleSheetLocation):
3089         (LayoutTestController::setUserStyleSheetEnabled):
3090         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3091
3092 2010-01-13  Adam Barth  <abarth@webkit.org>
3093
3094         Reviewed by Eric Seidel.
3095
3096         Fix CloseBugForLandDiff unittest to actually run
3097         https://bugs.webkit.org/show_bug.cgi?id=33640
3098
3099         * Scripts/webkitpy/mock_bugzillatool.py:
3100         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
3101
3102 2010-01-12  Jon Honeycutt  <jhoneycutt@apple.com>
3103
3104         MSAA: selected, selectable, extended selectable, and multiple
3105         selectable states are not reported
3106
3107         https://bugs.webkit.org/show_bug.cgi?id=33574
3108         <rdar://problem/7536826>
3109
3110         Reviewed by Darin Adler.
3111
3112         * DumpRenderTree/AccessibilityUIElement.cpp:
3113         (getIsSelectableCallback):
3114         Return the result of calling isSelectable().
3115         (getIsMultiSelectableCallback):
3116         Return the result of calling isMultiSelectable().
3117         (AccessibilityUIElement::getJSClass):
3118         Add isSelected and isMultiSelectable properties to the JSClass
3119         definition.
3120
3121         * DumpRenderTree/AccessibilityUIElement.h:
3122         Declare isSelectable() and isMultiSelectable().
3123
3124         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3125         (AccessibilityUIElement::isSelectable):
3126         Stubbed.
3127         (AccessibilityUIElement::isMultiSelectable):
3128         Stubbed.
3129
3130         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3131         (AccessibilityUIElement::isSelectable):
3132         Stubbed.
3133         (AccessibilityUIElement::isMultiSelectable):
3134         Stubbed.
3135
3136         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3137         (accessibilityState):
3138         Get the object's state, and return it.
3139         (AccessibilityUIElement::isSelected):
3140         Check the object's selected state.
3141         (AccessibilityUIElement::isSelectable):
3142         Check the object's selectable state.
3143         (AccessibilityUIElement::isMultiSelectable):
3144         Check the object's extended/multiple selectable state.
3145
3146 2010-01-13  Adam Barth  <abarth@webkit.org>
3147
3148         Unreviewed.  Repeat the below for CloseBugForLandDiff.
3149
3150         * Scripts/test-webkitpy:
3151         * Scripts/webkitpy/steps/closebugforlanddiff.py:
3152         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Added.
3153
3154 2010-01-13  Adam Barth  <abarth@webkit.org>
3155
3156         Unreviewed.  Turn the mac-ews status bubbles back on now that this bot
3157         is running again.
3158
3159         * QueueStatusServer/templates/statusbubble.html:
3160
3161 2010-01-13  Adam Barth  <abarth@webkit.org>
3162
3163         Reviewed by Darin Adler.
3164
3165         REGRESSION(53133): webkit-patch land dies if it can't find a bug id.
3166         https://bugs.webkit.org/show_bug.cgi?id=33634
3167
3168         Deal with the case of no bug patch object in the state.
3169
3170         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
3171         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py:
3172
3173 2010-01-13  Kenneth Russell  <kbr@google.com>
3174
3175         Unreviewed; added myself to the committers list.
3176
3177         * Scripts/webkitpy/committers.py:
3178
3179 2010-01-13  Darin Adler  <darin@apple.com>
3180
3181         Ignore compiled Python in more of webkitpy.
3182
3183         * Scripts/webkitpy/commands: Added property svn:ignore.
3184         * Scripts/webkitpy/steps: Added property svn:ignore.
3185         * Scripts/webkitpy/style: Added property svn:ignore.
3186
3187 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3188
3189         Reviewed by Simon Hausmann.
3190
3191         [Qt] Fix build problem related to the pushd command
3192
3193         * Scripts/webkitdirs.pm:
3194
3195 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3196
3197         Reviewed by Simon Hausmann.
3198
3199         [Qt] Split the build process in two different .pro files.
3200         This allows qmake to be run once all source files are available.
3201
3202         * Scripts/webkitdirs.pm: Add calls to make DerivedSources.pro in JSC and WC.
3203
3204 2010-01-13  Shinichiro Hamaji  <hamaji@chromium.org>
3205
3206         Unreviewed tiny typo fix in docstrings.
3207
3208         * Scripts/webkitpy/style/checker_unittest.py:
3209
3210 2010-01-13  Chris Jerdonek  <chris.jerdonek@gmail.com>
3211
3212         Reviewed by Shinichiro Hamaji.
3213
3214         Created a CategoryFilter class to encapsulate the logic of
3215         filter rules.
3216
3217         https://bugs.webkit.org/show_bug.cgi?id=33454
3218
3219         * Scripts/webkitpy/style/checker.py:
3220           - Added CategoryFilter class.
3221
3222         * Scripts/webkitpy/style/checker_unittest.py:
3223           - Added CategoryFilter unit tests.
3224
3225         * Scripts/webkitpy/style/cpp_style.py:
3226           - Updated filter methods to use CategoryFilter.
3227
3228         * Scripts/webkitpy/style/cpp_style_unittest.py:
3229           - Updated references to filters.
3230
3231 2010-01-12  Shinichiro Hamaji  <hamaji@chromium.org>
3232
3233         Unreviewed. Now I can review :)
3234
3235         * Scripts/webkitpy/committers.py:
3236
3237 2010-01-12  Brent Fulgham  <bfulgham@webkit.org>
3238
3239         Reviewed by Darin Adler.
3240
3241         Extend WinLauncher example with better printing features.
3242
3243         * WinLauncher/PrintWebUIDelegate.cpp:
3244         (PrintWebUIDelegate::webViewPrintingMarginRect): Provide slightly
3245          larger margins.
3246         (PrintWebUIDelegate::webViewHeaderHeight): Compute header height based
3247          on text metrics.
3248         (PrintWebUIDelegate::webViewFooterHeight): Compute footer height based
3249          on text metrics.
3250         (PrintWebUIDelegate::drawHeaderInRect): Write useful header, along
3251          with separating line.
3252         (PrintWebUIDelegate::drawFooterInRect):
3253         * WinLauncher/PrintWebUIDelegate.h: Remove stubs.
3254         * WinLauncher/WinLauncher.cpp:
3255         (PrintView): Correct loop used to print individual pages.
3256          Previously it started at 0, which is a wild-card to print all
3257          pages at once.
3258
3259 2010-01-12  Alexey Proskuryakov  <ap@apple.com>
3260
3261         Reviewed by Darin Adler.
3262
3263         https://bugs.webkit.org/show_bug.cgi?id=33540
3264         Make it possible to build in debug mode with assertions disabled
3265
3266         * DumpRenderTree/mac/ObjCController.m: (-[ObjCController accessStoredWebScriptObject]):
3267
3268 2010-01-11  Darin Fisher  <darin@chromium.org>
3269
3270         Reviewed by Dimitri Glazkov.
3271
3272         [Chromium] "build-webkit --chromium" should run "make all" on Linux
3273         https://bugs.webkit.org/show_bug.cgi?id=33500
3274
3275         * Scripts/webkitdirs.pm:
3276
3277 2010-01-12  Eric Seidel  <eric@webkit.org>
3278
3279         Reviewed by Adam Barth.
3280
3281         AssignToCommitter does not need to fetch bugs twice
3282         https://bugs.webkit.org/show_bug.cgi?id=33530
3283
3284         This is a no-brainer patch now that we've added Bug.reviewed_patches
3285
3286         * Scripts/webkitpy/commands/upload.py:
3287
3288 2010-01-12  Eric Seidel  <eric@webkit.org>
3289
3290         Reviewed by Adam Barth.
3291
3292         bugzilla.py should have an Attachment object instead of passing around dictionaries
3293         https://bugs.webkit.org/show_bug.cgi?id=31594
3294
3295         * Scripts/webkitpy/bugzilla.py:
3296          - Add a new Attachment class, with accessor methods for all the necessary properties.
3297          - Update Bug to carry a pointer back to bugzilla (attachments need to access Bugzilla for committer validation and url())
3298          - Move reviewed_patches and commit_queued_patches out of Bugzilla custom methods and onto Bug
3299          - Move committer validation logic into its own class.
3300          - Committer rejection is only used in one place.  Make the new Bug reviewed_patches and commit_queued_patches
3301            handle the common case (of returning "reviewer" or "committer" as None), and let CommitterValidation handle
3302            the case where we want to reject patches in bugzilla.
3303          - Simplify fetch_patches_from_commit_queue now that committer validation is simpler.
3304          - Make all self.bugzilla.fetch_bug access go through BugzillaQueries._fetch_bug.
3305          - Mark set_flag_on_attachment as non-private to denote that CommitterValidation depends on it.
3306          - Move fetch_reviewed_patches_from_bug and fetch_commit_queue_patches_from_bug logic onto the Bug class.
3307         * Scripts/webkitpy/bugzilla_unittest.py:
3308          - Move test_flag_permission_rejection_message into a new CommitterValidationTest class.
3309         * Scripts/webkitpy/commands/download.py:
3310          - Store "bug_id" in state instead of making a fake patch object.
3311          - Update to use Attachment and Bug objects.
3312         * Scripts/webkitpy/commands/download_unittest.py:
3313          - Update expected results now that our testing framework covers more code.
3314         * Scripts/webkitpy/commands/early_warning_system.py: Update to use new Attachment class.
3315         * Scripts/webkitpy/commands/queries.py: Remove unused ReviewedPatches class.
3316         * Scripts/webkitpy/commands/queries_unittest.py: ditto.
3317         * Scripts/webkitpy/commands/queues.py: Update to use new Attachment and CommitterValidator classes.
3318         * Scripts/webkitpy/commands/queuestest.py: ditto.
3319         * Scripts/webkitpy/commands/upload.py: ditto.
3320         * Scripts/webkitpy/mock_bugzillatool.py:
3321          - Now that more logic has moved into Attachment and Bug, we have to actually
3322            provide real reviewer emails as well as real reviewer flags.
3323          - Update mock methods to return Attachment objects.
3324         * Scripts/webkitpy/scm.py: Update to use Attachment class.
3325         * Scripts/webkitpy/scm_unittest.py: Update to use Attachment class.
3326         * Scripts/webkitpy/statusserver.py: ditto.
3327         * Scripts/webkitpy/steps/applypatch.py: ditto.
3328         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: ditto.
3329         * Scripts/webkitpy/steps/closebug.py: ditto.
3330         * Scripts/webkitpy/steps/closebugforlanddiff.py: Handle either state["bug_id"] or state["patch"].bug_id()
3331         * Scripts/webkitpy/steps/closepatch.py: Update to use Attachment class.
3332         * Scripts/webkitpy/steps/obsoletepatches.py: ditto.
3333         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: ditto.
3334
3335 2010-01-12  Adam Barth  <abarth@webkit.org>
3336
3337         Unreviewed typo fix.  :(
3338
3339         * Scripts/webkitpy/commands/early_warning_system.py:
3340         * Scripts/webkitpy/commands/queues.py:
3341
3342 2010-01-12  Adam Barth  <abarth@webkit.org>
3343
3344         Unreviewed.  Add "error" to the right part of the message.
3345
3346         * Scripts/webkitpy/commands/queues.py:
3347
3348 2010-01-12  Adam Barth  <abarth@webkit.org>
3349
3350         Reviewed by Eric Seidel.
3351
3352         EWS should show purple when svn-apply fails
3353         https://bugs.webkit.org/show_bug.cgi?id=33527
3354
3355         * Scripts/webkitpy/commands/early_warning_system.py:
3356         * Scripts/webkitpy/commands/queues.py:
3357
3358 2010-01-12  Adam Barth  <abarth@webkit.org>
3359
3360         Reviewed by Eric Seidel.
3361
3362         Remove copy/paste code from subclasses of AbstractReviewQueue
3363         https://bugs.webkit.org/show_bug.cgi?id=33525
3364
3365         * Scripts/webkitpy/commands/early_warning_system.py:
3366         * Scripts/webkitpy/commands/queues.py:
3367
3368 2010-01-12  Adam Barth  <abarth@webkit.org>
3369
3370         Reviewed by Eric Seidel.
3371
3372         Add Gustavo and Xan as gtk-ews watchers
3373         https://bugs.webkit.org/show_bug.cgi?id=33519
3374
3375         * Scripts/webkitpy/commands/early_warning_system.py:
3376
3377 2010-01-12  Adam Barth  <abarth@webkit.org>
3378
3379         Reviewed by Eric Seidel.
3380
3381         webkit-patch shouldn't waste my time for with a component prompt
3382         https://bugs.webkit.org/show_bug.cgi?id=33521
3383
3384         The component field isn't very useful for bugs created with
3385         webkit-patch because they're likely to be resolved quickly.  Instead of
3386         always prompting for a component, we should just default to the "New
3387         Bugs" component.  If the bug stays around for more than five minutes,
3388         we can assign it a proper component.
3389
3390         * Scripts/webkitpy/bugzilla.py:
3391
3392 2010-01-12  Adam Barth  <abarth@webkit.org>
3393
3394         Reviewed by Eric Seidel.
3395
3396         Add experimental "land-safely" command to webkit-patch
3397         https://bugs.webkit.org/show_bug.cgi?id=33518
3398
3399         * Scripts/webkitpy/commands/upload.py:
3400         * Scripts/webkitpy/commands/upload_unittest.py:
3401         * Scripts/webkitpy/steps/__init__.py:
3402         * Scripts/webkitpy/steps/postdiffforcommit.py: Added.
3403
3404 2010-01-11  Kevin Ollivier  <kevino@theolliviers.com>
3405
3406         [wx] Build fix after introduction of JS_NO_EXPORT
3407         
3408         * wx/build/settings.py:
3409
3410 2010-01-11  Eric Seidel  <eric@webkit.org>
3411
3412         No review, rolling out r53079.
3413         http://trac.webkit.org/changeset/53079
3414         https://bugs.webkit.org/show_bug.cgi?id=33197
3415
3416         Adam doens't think this actually works, and believe it caused
3417         a regression https://bugs.webkit.org/show_bug.cgi?id=33488 so
3418         rolling this out.
3419
3420         * Scripts/test-webkitpy:
3421         * Scripts/webkitpy/commands/abstractdiffcommand.py: Removed.
3422         * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Removed.
3423         * Scripts/webkitpy/commands/download.py:
3424         * Scripts/webkitpy/commands/upload.py:
3425         * Scripts/webkitpy/mock_bugzillatool.py:
3426
3427 2010-01-10  Adam Barth  <abarth@webkit.org>
3428
3429         Reviewed by David Kilzer.
3430
3431         bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
3432         https://bugs.webkit.org/show_bug.cgi?id=33197
3433
3434         We should just search for bug numbers in the ChangeLogs instead of in
3435         the whole diff.
3436  
3437         * Scripts/test-webkitpy:
3438         * Scripts/webkitpy/commands/abstractdiffcommand.py: Added.
3439         * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Added.
3440         * Scripts/webkitpy/commands/download.py:
3441         * Scripts/webkitpy/commands/upload.py:
3442         * Scripts/webkitpy/mock_bugzillatool.py:
3443
3444 2010-01-11  Chris Jerdonek  <chris.jerdonek@gmail.com>
3445
3446         Reviewed by David Kilzer.
3447
3448         Created a unit-tested function to parse the header block of
3449         a Git or SVN diff -- for future refactoring of svn-apply and
3450         svn-unapply.
3451
3452         https://bugs.webkit.org/show_bug.cgi?id=33447
3453
3454         * Scripts/VCSUtils.pm:
3455           - Added parseDiffHeader().
3456           - Removed irrelevant comment from gitdiff2svndiff().
3457
3458         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: Added.
3459           - Added 48 unit tests for parseDiffHeader().
3460
3461 2010-01-10  Adam Barth  <abarth@webkit.org>
3462
3463         Rubber stamped by David Kilzer.
3464
3465         bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
3466         https://bugs.webkit.org/show_bug.cgi?id=33197
3467
3468         Fix a typo: Commmand -> Command.
3469
3470         * Scripts/webkitpy/commands/abstractsequencedcommand.py:
3471         * Scripts/webkitpy/commands/download.py:
3472         * Scripts/webkitpy/commands/queries.py:
3473         * Scripts/webkitpy/commands/upload.py:
3474         * Scripts/webkitpy/multicommandtool.py:
3475
3476 2010-01-10  Adam Barth  <abarth@webkit.org>
3477
3478         Reviewed by Darin Adler.
3479
3480         Let webkit-patch work with options in $EDITOR
3481         https://bugs.webkit.org/show_bug.cgi?id=33414
3482
3483         The $EDITOR evironment variable might have command line options like
3484         bbedit -w.  This patch lets us run those $EDITORs.
3485
3486         * Scripts/webkitpy/user.py:
3487
3488 2010-01-10  Robert Hogan  <robert@roberthogan.net>
3489
3490         Reviewed by Adam Barth.
3491
3492         [Qt] Add enableXSSAuditor support to QWebSettings and DRT.
3493
3494         https://bugs.webkit.org/show_bug.cgi?id=33419
3495
3496         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3497         (WebCore::WebPage::WebPage):
3498         (WebCore::WebPage::resetSettings):
3499         (WebCore::DumpRenderTree::createWindow):
3500         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3501         (LayoutTestController::setXSSAuditorEnabled):
3502         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3503
3504 2010-01-10  Adam Barth  <abarth@webkit.org>
3505
3506         Unreviewed cosmetic change.  Remove the status bubble for mac-ews
3507         because we don't have hardware for it at the moment.
3508
3509         * QueueStatusServer/templates/statusbubble.html:
3510
3511 2010-01-09  Daniel Bates  <dbates@webkit.org>
3512
3513         No review, rolling out r53044.
3514         http://trac.webkit.org/changeset/53044
3515         https://bugs.webkit.org/show_bug.cgi?id=33419
3516         
3517         We need to look into this some more because the Qt
3518         bot is failing the XSSAuditor tests. See bug #33419
3519         for more details.
3520
3521         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3522         (WebCore::WebPage::WebPage):
3523         (WebCore::WebPage::resetSettings):
3524         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3525         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3526
3527 2010-01-09  Daniel Bates  <dbates@webkit.org>
3528
3529         Reviewed by Adam Barth.
3530
3531         https://bugs.webkit.org/show_bug.cgi?id=33419
3532
3533         Adds support for the XSSAuditor to the Qt DRT.
3534
3535         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3536         (WebCore::WebPage::WebPage):
3537         (WebCore::WebPage::resetSettings):
3538         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3539         (LayoutTestController::setXSSAuditorEnabled):
3540         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3541
3542 2010-01-09  Adam Barth  <abarth@webkit.org>
3543
3544         Reviewed by Eric Seidel.
3545
3546         Retry writes to QueueStatusServer when we get 500 errors
3547         https://bugs.webkit.org/show_bug.cgi?id=33412
3548
3549         This prevents the queues from failing to mark a patch as "pass" or
3550         "fail" when AppEngine throws 500 errors.
3551
3552         * Scripts/test-webkitpy:
3553         * Scripts/webkitpy/networktransaction.py: Added.
3554         * Scripts/webkitpy/networktransaction_unittest.py: Added.
3555         * Scripts/webkitpy/statusserver.py:
3556         * Scripts/webkitpy/steps/closebugformarkbugfixed.py: Added.
3557         * Scripts/webkitpy/steps/closebugregardlessofpatches.py: Added.
3558         * Scripts/webkitpy/steps/findbugidfromsvnrevision.py: Added.
3559
3560 2010-01-09  David Kilzer  <ddkilzer@apple.com>
3561
3562         <http://webkit.org/b/33430> Fix rounded borders in queue status on older Firefox and Safari browsers
3563
3564         Reviewed by Eric Seidel.
3565
3566         * QueueStatusServer/templates/statusbubble.html: Added
3567         -moz-border-radius and -webkit-border-radius to provide rounded
3568         borders in older Firefox and Safari browsers.
3569
3570 2010-01-09  Chris Jerdonek  <chris.jerdonek@gmail.com>
3571
3572         Reviewed by David Kilzer.
3573
3574         Modified VCSUtils::gitdiff2svndiff() to accept strings that
3575         end in vertical white space.
3576
3577         https://bugs.webkit.org/show_bug.cgi?id=33415
3578
3579         * Scripts/VCSUtils.pm:
3580         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
3581
3582 2010-01-08  Eric Seidel  <eric@webkit.org>
3583
3584         Reviewed by Adam Barth.
3585
3586         run-javascriptcore-tests needs a --quiet flag
3587         https://bugs.webkit.org/show_bug.cgi?id=33399
3588
3589         Until run-javascriptcore-tests has a --quiet flag, lets just stiffle the output in webkit-patch.
3590
3591         * Scripts/webkitpy/steps/runtests.py:
3592
3593 2010-01-08  Andras Becsi  <abecsi@inf.u-szeged.hu>
3594
3595         Reviewed by Alexey Proskuryakov.
3596
3597         Only run http and websocket tests as last if no argument is given to be able to explicitly control the test order.
3598
3599         To be able to run multiple instances of run-webkit-tests besides each other on the same machine we need to minimize
3600         the time when Apache and WebSocketServer is locked by tests.
3601         Because closeHTTPD() and closeWebSocketServer() is only called at the end of the testing,