WebKitTools/ChangeLog

   1 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
   2
   3         Sort files(...); sections of Xcode project files.
   4
   5         Rubber-stamped by Darin.
   6
   7         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
   8         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
   9         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  10         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
  11
  12 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
  13
  14         Script to sort "files(...);" sections in Xcode project.pbxproj files.
  15
  16         Reviewed by Darin.
  17
  18         * Scripts/sort-Xcode-project-file: Added.
  19
  20 2007-11-02  Darin Adler  <darin@apple.com>
  21
  22         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
  23
  24 2007-11-02  Darin Adler  <darin@apple.com>
  25
  26         Reviewed by Maciej.
  27
  28         * Scripts/run-sunspider: Pass the "--base" option through.
  29
  30         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
  31         the real script do that. Default configuration to Release to match run-sunspider
  32         so we don't end up building Debug just to compare results.
  33
  34 2007-11-01  Adam Roben  <aroben@apple.com>
  35
  36         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
  37
  38         Reviewed by Sam.
  39
  40         * Scripts/commit-log-editor: Show all the directories beneath the
  41         source root, instead of just the last one.
  42
  43 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
  44
  45         Reviewed by Adam Roben.
  46
  47         Print out an error message when the Windows build fails
  48         and provide guidance on how to find out what went wrong.
  49
  50         * Scripts/build-webkit:
  51         * Scripts/webkitdirs.pm:
  52
  53 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
  54
  55         Rubber-stamped by Adam Roben.
  56
  57         Rolled out r27326 - debug CRT seems to cause no problems after all.
  58
  59         * DumpRenderTree/win/DumpRenderTree.vcproj:
  60
  61 2007-10-31  Adam Roben  <aroben@apple.com>
  62
  63         Switch the Debug configuration to using the non-debug CRT
  64
  65         This matches WebKit.
  66
  67         Reviewed by Steve.
  68
  69         * DumpRenderTree/win/DumpRenderTree.vcproj:
  70
  71 2007-10-31  Antti Koivisto  <antti@apple.com>
  72
  73         Reviewed by bdash.
  74
  75         Disable media tests when doing leak checking on Tiger.
  76         They crash in QuickTime (rdar://problem/5537157).
  77
  78         * Scripts/run-webkit-tests:
  79
  80 2007-10-29  Antti Koivisto  <antti@apple.com>
  81
  82         Reviewed by Maciej.
  83
  84         Build media support by default on OSX only.
  85
  86         * Scripts/build-webkit:
  87
  88 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
  89
  90         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
  91         get caught by the pre-commit hooks.
  92
  93 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
  94
  95         Reviewed by Adam.
  96
  97         - This is a collection of relatively unrelated changes and cleanups
  98         to Drosera to prepare it for interacting with WebKit.  A lot of these
  99         changes are just correcting mistakes, for example removing included
 100         headers that are no longer needed.
 101
 102         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
 103         this will be needed by the DebuggerClient.
 104         (DebuggerDocument::server):
 105         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
 106         * Drosera/win/DebuggerClient.cpp:
 107         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
 108         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
 109         (DebuggerClient::createWebViewWithRequest): Added comment about its
 110         purpose.
 111         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
 112         declarations.
 113         (DebuggerClient::webViewLoaded): Moved.
 114         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
 115         file, since this was the only place it was used.
 116         (cfStringToBSTR):
 117         * Drosera/win/Drosera.h: Cleaned up the includes.
 118         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
 119         * Drosera/win/HelperFunctions.h: Removed.
 120
 121 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
 122
 123         Reviewed by Adam.
 124
 125         - Small cleanup in the ServerConnection class.
 126
 127         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
 128         and added an include.
 129         (ServerConnection::currentFrame):
 130         (ServerConnection::getCallerFrame):
 131         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
 132         made a pointer into a COMPtr, and cleaned up the includes.
 133
 134 2007-10-29  Timothy Hatcher  <timothy@apple.com>
 135
 136         Reviewed by John Sullivan.
 137
 138         - Place the Localizable.strings file in mac or win directories
 139           if that location exists.
 140         - Also look for UI_STRING in .c files.
 141
 142         * Scripts/extract-localizable-strings:
 143
 144 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
 145
 146         Reviewed by Adam.
 147
 148         - Set the eol-style to native and made all the line endings the same
 149         so that I avoid messy diffs that show eol changes.
 150
 151         * Drosera/win/ServerConnection.cpp:
 152         (ServerConnection::didParseSource):
 153         (ServerConnection::didEnterCallFrame):
 154         (ServerConnection::willExecuteStatement):
 155         (ServerConnection::willLeaveCallFrame):
 156         (ServerConnection::exceptionWasRaised):
 157
 158 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
 159
 160         Reviewed by Adam.
 161
 162         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
 163         functionality that could not have existed previously without the new
 164         interfaces.
 165         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
 166         from a BSTR to a JSValueRef.
 167         (DebuggerDocument::platformEvaluateScript): Implemented.
 168         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
 169         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 170         Implemented.
 171         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
 172         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
 173         * Drosera/win/ServerConnection.cpp: Added a helper function.
 174         (ServerConnection::getCallerFrame):
 175         * Drosera/win/ServerConnection.h: Added a helper function.
 176
 177 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
 178
 179         updated reviewers for my previous changelog.
 180
 181 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
 182         Reviewed by Maciej and Adam and Geoff.
 183
 184         - Minor mac-side improvements including moving a function to a more
 185         appropriate location, fixing a warning, and correctly checking
 186         exceptions.
 187
 188         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
 189         (DebuggerDocument::willExecuteStatement):
 190         (DebuggerDocument::didEnterCallFrame):
 191         (DebuggerDocument::willLeaveCallFrame):
 192         (DebuggerDocument::windowScriptObjectAvailable):
 193         (DebuggerDocument::callFunctionOnObject):
 194         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
 195         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
 196         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
 197         because it doesn't require the ServerConnection at all.
 198         (NSStringCreateWithJSStringRef): Made an argument const.
 199         (JSValueRefCreateWithNSString): Made an argument const.
 200         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
 201         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 202         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
 203         * Drosera/mac/ServerConnection.mm: Ditto.
 204         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
 205
 206 2007-10-29  Sam Weinig  <sam@webkit.org>
 207
 208         Reviewed by Adam Roben.
 209
 210         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
 211
 212         * DumpRenderTree/LayoutTestController.cpp:
 213         (LayoutTestController::LayoutTestController):
 214         (getGlobalFlagCallback):
 215         (setGlobalFlagCallback):
 216         (LayoutTestController::getJSClass):
 217         (LayoutTestController::staticValues):
 218         * DumpRenderTree/LayoutTestController.h:
 219         (LayoutTestController::globalFlag):
 220         (LayoutTestController::setGlobalFlag):
 221
 222 2007-10-29  Darin Adler  <darin@apple.com>
 223
 224         Reviewed by Maciej.
 225
 226         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
 227         resolution instead of its default.
 228
 229 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
 230
 231         Fixed showStatus() to print status for successfully resolved conflicts when using git.
 232
 233         Reviewed by Mark Rowe.
 234
 235         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
 236         was successfully resolved, but this would not show any status because the change had
 237         already been cached in the index using "git add".  The solution is to add an optional
 238         second argument to showStatus() which adds the "--cached" switch to the command.
 239
 240         * Scripts/resolve-ChangeLogs:
 241         (showStatus):
 242
 243 2007-10-28  Eric Seidel  <eric@webkit.org>
 244
 245         Reviewed by Maciej and Geoff, in unison.
 246
 247         * Scripts/run-webkit-tests: remove broken --svg option
 248
 249 2007-10-28  Darin Adler  <darin@apple.com>
 250
 251         Reviewed by Adam.
 252
 253         * Scripts/run-sunspider: Default to "Release" configuration rather than
 254         defaulting to the last configuration used as other scripts do. This can
 255         still be overriden on the command line with "--debug" if there's some
 256         reason to do so. Also fix a typo.
 257
 258         * Scripts/sunspider-compare-results: Fix a typo.
 259
 260 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
 261
 262         Reviewed by Adam.
 263
 264         - Implemented the WebScriptDebugListener functions now that the
 265         WebScriptDebugServer exists
 266
 267         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
 268         functions.
 269         (ServerConnection::currentFrame):
 270         (ServerConnection::didLoadMainResourceForDataSource):
 271         (ServerConnection::didParseSource):
 272         (ServerConnection::failedToParseSource):
 273         (ServerConnection::didEnterCallFrame):
 274         (ServerConnection::willExecuteStatement):
 275         (ServerConnection::willLeaveCallFrame):
 276         (ServerConnection::exceptionWasRaised):
 277         * Drosera/win/ServerConnection.h: Removed unused arguments from the
 278         members arguments list.
 279
 280 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
 281
 282         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
 283         <http://bugs.webkit.org/show_bug.cgi?id=15600>
 284
 285         Reviewed by Darin.
 286
 287         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
 288         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
 289         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
 290         file.  Note that it may also be used as a stand-alone script.
 291
 292         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
 293         * Scripts/resolve-ChangeLogs: Added.
 294         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
 295
 296 2007-10-26  Mark Rowe  <mrowe@apple.com>
 297
 298         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
 299         to the Qt port on the assumption that it was an implementation of the cross-platform
 300         LayoutTestController class.  It is not, so it did not need to be changed.
 301
 302         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
 303
 304 2007-10-25  Mark Rowe  <mrowe@apple.com>
 305
 306         Reviewed by Maciej.
 307
 308         Fix builds with code coverage enabled.
 309
 310         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
 311
 312 2007-10-25  Darin Adler  <darin@apple.com>
 313
 314         Reviewed by Mark Rowe.
 315
 316         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
 317         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
 318
 319 2007-10-25  Stephanie  <slewis@apple.com>
 320
 321         build Fix
 322
 323         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 324
 325 2007-10-25  Stephanie  <slewis@apple.com>
 326
 327         Reviewed by Mark Rowe, Adam Roben.
 328
 329         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
 330
 331         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 332
 333 2007-10-25  Alice Liu  <alice.liu@apple.com>
 334
 335         Reviewed by Adam.
 336
 337         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
 338
 339         Moving destructor into platform-specific files
 340         * DumpRenderTree/LayoutTestController.cpp:
 341         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 342         (LayoutTestController::~LayoutTestController):
 343         * DumpRenderTree/qt/jsobjects.cpp:
 344         (LayoutTestController::~LayoutTestController):
 345
 346         LayoutTestController wasn't being destroyed
 347         * DumpRenderTree/win/DumpRenderTree.cpp:
 348         (runTest):
 349
 350         Added declspec
 351         * DumpRenderTree/win/EditingDelegate.h:
 352
 353         Reset certain values on the webview (or related delegate) that might
 354         have changed while running a test
 355         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 356         (LayoutTestController::~LayoutTestController):
 357
 358 2007-10-25  Adam Roben  <aroben@apple.com>
 359
 360         Make sunspider-compare-results work with relative paths
 361
 362         Reviewed by Sam.
 363
 364         * Scripts/sunspider-compare-results: Convert arguments to absolute
 365         paths before we chdir.
 366
 367 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
 368
 369         Reviewed by Sam.
 370
 371         - Implemented server calls now the WebScriptDebugServer exists.
 372         - Also removed no longer needed call to initialize CG.
 373
 374         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
 375         automatically now.
 376         (_tWinMain):
 377         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
 378         (ServerConnection::ServerConnection):
 379         (ServerConnection::~ServerConnection):
 380         (ServerConnection::pause):
 381         (ServerConnection::resume):
 382         (ServerConnection::stepInto):
 383         (ServerConnection::applicationTerminating):
 384         (ServerConnection::serverConnectionDidDie):
 385         * Drosera/win/ServerConnection.h: Now uses the COM class.
 386
 387 2007-10-24  George Staikos  <staikos@kde.org>
 388
 389         Unbreak Qt build.
 390
 391         * Scripts/build-webkit:
 392
 393 2007-10-24  Adam Roben  <aroben@apple.com>
 394
 395         Remove now-unnecessary call to InitializeCoreGraphics
 396
 397         WebKit takes care of this now.
 398
 399         Reviewed by Ada.
 400
 401         * DumpRenderTree/win/DumpRenderTree.cpp:
 402         (initialize):
 403
 404 2007-10-24  Adam Roben  <aroben@apple.com>
 405
 406         Use WebTextRenderer in DRT
 407
 408         Reviewed by Ada.
 409
 410         * DumpRenderTree/win/DumpRenderTree.cpp:
 411         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
 412
 413 2007-10-24  Sven Herzberg  <sven@imendio.com>
 414
 415         Reviewed by Mark Rowe.
 416
 417         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
 418         Bug 15614: [GTK] qmake based backends don't build on OS X
 419
 420         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
 421         GTK backend on a Mac
 422         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
 423         isDarwin() to make it reusable in other places (like the workaround-
 424         for-prebuilt-qmake in build-webkit)
 425
 426 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
 427
 428         Refurbish update-webkit script.
 429
 430         Reviewed by Adam.
 431
 432         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
 433         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
 434         multi-argument version of system() for flexibility and security.  Check for existence
 435         of Internal directory using -d test instead of -x.
 436
 437 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
 438
 439         Minor clean-up of prepare-ChangeLog script.
 440
 441         Reviewed by Adam.
 442
 443         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
 444         of a string.  Use multi-argument versions of open() and system() for flexibility and
 445         security.
 446
 447 2007-10-24  Alice Liu  <alice.liu@apple.com>
 448
 449         Reviewed by Oliver.
 450
 451         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
 452
 453         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
 454         replay the saved events when we're still processing the mousedown that starts the drag
 455         * DumpRenderTree/win/EventSender.cpp:
 456         (doMouseMove):
 457         * DumpRenderTree/win/UIDelegate.cpp:
 458         (UIDelegate::doDragDrop):
 459
 460 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
 461
 462         Reviewed by Sam, Steve and Darin.
 463
 464         - Stubbed out the WebScriptDebugListener functionality in the Server
 465         Connection class to prepare it for receiving those callbacks.
 466         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
 467         and the ServerConnection to not need to be initialized with a server
 468         name, since that is not the way we connect to the WebKit server.
 469
 470         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
 471         no exception.  Now it only loggs when there is an exception
 472         (DebuggerDocument::willExecuteStatement):
 473         (DebuggerDocument::didEnterCallFrame):
 474         (DebuggerDocument::willLeaveCallFrame):
 475         (DebuggerDocument::windowScriptObjectAvailable):
 476         (DebuggerDocument::callFunctionOnObject):
 477         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
 478         to be instantiated with a server's name.
 479         (DebuggerClient::DebuggerClient):
 480         (DebuggerClient::didFinishLoadForFrame):
 481         * Drosera/win/DebuggerClient.h: Removed unsued variable.
 482         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
 483         a server name.
 484         (Drosera::init):
 485         (Drosera::initServer):
 486         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
 487         instantiated with a server's name.
 488         * Drosera/win/ServerConnection.cpp:
 489         (ServerConnection::ServerConnection): No longer needs a server name
 490         (ServerConnection::~ServerConnection): Only release the global context
 491         if there is one.
 492         (ServerConnection::serverConnectionDidDie): Stub for
 493         IWebScriptDebugListener
 494         (ServerConnection::QueryInterface): ditto
 495         (ServerConnection::AddRef): ditto
 496         (ServerConnection::Release): ditto
 497         (ServerConnection::didLoadMainResourceForDataSource): ditto
 498         (ServerConnection::didParseSource): ditto
 499         (ServerConnection::failedToParseSource): ditto
 500         (ServerConnection::didEnterCallFrame): ditto
 501         (ServerConnection::willExecuteStatement): ditto
 502         (ServerConnection::willLeaveCallFrame): ditto
 503         (ServerConnection::exceptionWasRaised): ditto
 504         * Drosera/win/ServerConnection.h: Stubbed out the
 505         IWebScriptDebugListener functions, and this class no longer needs to be
 506         instantiated with a server name.
 507
 508 2007-10-24  Lars Knoll  <lars@trolltech.com>
 509
 510         Reviewed by Simon.
 511
 512         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
 513
 514         * DumpRenderTree/qt/jsobjects.h:
 515
 516 2007-10-24  Lars Knoll  <lars@trolltech.com>
 517
 518         Reviewed by Simon.
 519
 520         add another command.
 521
 522         * DumpRenderTree/qt/jsobjects.cpp:
 523         (TextInputController::doCommand):
 524
 525 2007-10-24  Lars Knoll  <lars@trolltech.com>
 526
 527         Reviewed by Simon.
 528
 529         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
 530
 531         * DumpRenderTree/qt/jsobjects.cpp:
 532         (EventSender::keyDown):
 533         * DumpRenderTree/qt/jsobjects.h:
 534
 535 2007-10-24  Lars Knoll  <lars@trolltech.com>
 536
 537         Reviewed by Simon.
 538
 539         implement eventSender.keyDown().
 540
 541         * DumpRenderTree/qt/jsobjects.cpp:
 542         (EventSender::keyDown):
 543
 544 2007-10-24  Lars Knoll  <lars@trolltech.com>
 545
 546         Reviewed by Simon.
 547
 548         some smaller fixes to the editing support in DRT. Makes another few tests pass.
 549
 550         * DumpRenderTree/qt/DumpRenderTree.cpp:
 551         (WebCore::DumpRenderTree::DumpRenderTree):
 552         (WebCore::DumpRenderTree::initJSObjects):
 553         * DumpRenderTree/qt/jsobjects.cpp:
 554         (TextInputController::doCommand):
 555
 556 2007-10-24  Lars Knoll  <lars@trolltech.com>
 557
 558         Reviewed by Simon.
 559
 560         first bit of implementation for the textinputcontroller.
 561
 562         * DumpRenderTree/qt/DumpRenderTree.cpp:
 563         (WebCore::DumpRenderTree::DumpRenderTree):
 564         * DumpRenderTree/qt/DumpRenderTree.h:
 565         * DumpRenderTree/qt/jsobjects.cpp:
 566         (TextInputController::TextInputController):
 567         (TextInputController::doCommand):
 568         * DumpRenderTree/qt/jsobjects.h:
 569
 570 2007-10-24  Lars Knoll  <lars@trolltech.com>
 571
 572         Reviewed by Simon.
 573
 574         make the man webpage believe it has focus, so the editing tests work correctly.
 575
 576         * DumpRenderTree/qt/DumpRenderTree.cpp:
 577         (WebCore::DumpRenderTree::DumpRenderTree):
 578
 579 2007-10-24  Lars Knoll  <lars@trolltech.com>
 580
 581         Reviewed by Simon.
 582
 583         implement layoutTestController.dumpEditingCallbacks() correctly.
 584
 585         * DumpRenderTree/qt/DumpRenderTree.cpp:
 586         (WebCore::DumpRenderTree::DumpRenderTree):
 587         * DumpRenderTree/qt/jsobjects.cpp:
 588         (LayoutTestController::reset):
 589         (LayoutTestController::dumpEditingCallbacks):
 590
 591 2007-10-24  Lars Knoll  <lars@trolltech.com>
 592
 593         Reviewed by Simon.
 594
 595         Implement support for testing editing.
 596
 597         * DumpRenderTree/qt/DumpRenderTree.cpp:
 598         (WebCore::DumpRenderTree::DumpRenderTree):
 599
 600 2007-10-23  Sam Weinig  <sam@webkit.org>
 601
 602         Check for null BSTR that can be passed to the UIDelegate methods
 603         from javascript null and undefined.  Fixes a failing test case on
 604         Windows (fast/dom/Window/alert-undefined.html)
 605
 606         Reviewed by Eric Seidel.
 607
 608         * DumpRenderTree/win/UIDelegate.cpp:
 609         (UIDelegate::runJavaScriptAlertPanelWithMessage):
 610         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
 611         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
 612         (UIDelegate::webViewAddMessageToConsole):
 613
 614 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
 615
 616         Reviewed by Darin.
 617
 618         Don't print a massive pile of setenvs from tools that automatically build testkjs.
 619
 620         * Scripts/build-testkjs:
 621
 622 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
 623
 624         Reviewed by Darin.
 625
 626         - add wrapper that finds the right copy of testkjs
 627
 628         * Scripts/sunspider-compare-results: Added.
 629
 630 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
 631
 632         Reviewed by Sam.
 633
 634         - After talking with Steve I now see that the WebKit server must be
 635         running for DCOM to create the distributed objects, which makes sense
 636         and currently WebKit only allows one instance to be running at a time
 637         which avoids accidentally connecting to the wrong server
 638         - In light of this I have removed the code for the attach box and
 639         NotificationServer and known server names, since they are all extranious
 640         now.
 641
 642         * Drosera/win/Drosera.cpp: Removed notification classes and known server
 643         names.
 644         (_tWinMain): Uses init instead of initUI.
 645         (droseraWndProc): No longer creats an attach dialog box.
 646         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
 647         it's not manditory to call init before doing COM stuff.
 648         (Drosera::init): calls initUI and will call attach when the
 649         functionality exists.
 650         (Drosera::initUI): Has changed very little.
 651         (Drosera::attach): Changed the signature to reflect that we no longer
 652         need the dictionary of known server names.
 653         * Drosera/win/Drosera.h: Removed notification classes and known server
 654         names.  Also renamed and moved some functions.
 655         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
 656         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
 657         headers to the resources folder.
 658         * Drosera/win/resource.h: Removed the Attach box.
 659
 660 2007-10-22  Adam Roben  <aroben@apple.com>
 661
 662         Windows build fix
 663
 664         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
 665
 666 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
 667
 668         - Removed a leak that was fixed.
 669
 670         * Scripts/run-webkit-tests:
 671
 672 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
 673
 674         Reviewed by Darin.
 675
 676         - Changed the Client so that the DebuggerDocument now own the
 677         ServerConnection.  This simplifies ownership and cleanup.
 678
 679         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
 680         ServerConnection.
 681         (DebuggerClient::initWithServerName):
 682         (DebuggerClient::didFinishLoadForFrame):
 683         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the
 684         ServerConnection.
 685         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
 686         until after we have a server which we are attached to.
 687         (Drosera::initUI):
 688         (Drosera::attach):
 689         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
 690         out previously.
 691
 692 2007-10-22  Simon Hausmann  <hausmann@kde.org>
 693
 694         Reviewed by Nikolas.
 695
 696         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
 697
 698         * Scripts/run-javascriptcore-tests:
 699
 700 2007-10-22  Simon Hausmann  <hausmann@kde.org>
 701
 702         Reviewed by Nikolas.
 703
 704         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
 705
 706         * Scripts/build-drosera:
 707         * Scripts/build-dumprendertree:
 708         * Scripts/build-testkjs:
 709         * Scripts/build-webkit:
 710         * Scripts/run-javascriptcore-tests:
 711         * Scripts/run-sunspider:
 712         * Scripts/run-webkit-tests:
 713         * Scripts/webkitdirs.pm:
 714
 715 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
 716
 717         Reviewed by Mark Rowe.
 718
 719         Fix for local database support after r26879
 720         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
 721
 722         * Scripts/build-webkit:
 723
 724 2007-10-22  Holger Freyther  <zecke@selfish.org>
 725
 726         Reviewed by Simon Hausmann <hausmann@kde.org>.
 727
 728         - Do not build testkjs as an application bundle. This is
 729         needed for run-javascriptcore-tests on OSX.
 730         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
 731         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
 732         as we do not have -rpath on OSX.
 733
 734         * DumpRenderTree/qt/DumpRenderTree.pro:
 735         * Scripts/run-webkit-tests:
 736
 737 2007-10-22  Simon Hausmann  <hausmann@kde.org>
 738
 739         Reviewed by aroben.
 740
 741         Fix support for Signed-off-by detection in prepare-ChangeLog
 742         --git-commit. The Signed-off-by tag does not appear in the header
 743         but usually at the end.
 744
 745         * Scripts/prepare-ChangeLog:
 746
 747 2007-10-21  Mark Rowe  <mrowe@apple.com>
 748
 749         Reviewed by Eric.
 750
 751         Fix run-javascriptcore-tests for Gtk.
 752
 753         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
 754
 755 2007-10-20  Eric Seidel  <eric@webkit.org>
 756
 757         Reviewed by aroben.
 758
 759         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
 760
 761 2007-10-20  Eric Seidel  <eric@webkit.org>
 762
 763         Reviewed by darin.
 764
 765         Add improved argument handling to run-sunspider, including
 766         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
 767         Also re-factor code into subroutines
 768
 769         * Scripts/build-dumprendertree: removed bogus comments
 770         * Scripts/build-testkjs: Added.
 771         * Scripts/run-javascriptcore-tests: use build-testkjs
 772         * Scripts/run-sunspider: improved argument handling, abstraction
 773         * Scripts/run-webkit-tests: improved abstraction
 774
 775 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
 776
 777         Not reviewed, Windows build fix.
 778
 779         * DumpRenderTree/win/EventSender.cpp:
 780         (keyDownCallback):
 781
 782 2007-10-20  Darin Adler  <darin@apple.com>
 783
 784         Reviewed by Tim Hatcher.
 785
 786         - http://bugs.webkit.org/show_bug.cgi?id=15544
 787           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
 788           not rely on Apple-specific key codes
 789
 790         * DumpRenderTree/mac/EventSendingController.mm:
 791         (-[EventSendingController keyDown:withModifiers:]):
 792         Added named key "rightArrow". Later we could have a whole table of these.
 793         Also tweaked modifiers code a little.
 794
 795         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
 796
 797 2007-10-19  Darin Adler  <darin@apple.com>
 798
 799         Reviewed by Eric.
 800
 801         - http://bugs.webkit.org/show_bug.cgi?id=15566
 802           possible fix for leak seen in DumpRenderTree
 803
 804         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
 805         Delete the item if it's not put on the queue, since the caller has
 806         no way of knowing that. Would be better to have the parameter type
 807         be auto_ptr to express the fact that we take ownership.
 808
 809         - unrelated change
 810
 811         * Drosera/mac/main.m: Add missing include.
 812
 813 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
 814
 815         Reviewed by Adam.
 816
 817         - This change should be identical but for some reason was not working
 818         on my machine.
 819
 820         * Scripts/prepare-ChangeLog:
 821
 822 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
 823
 824         Reviewed by Oliver and Tim.
 825
 826         - Made use of RetainPtr to avoid retain and release issues and moved the
 827         log function to DebuggerDocumentPlatform, which seems to be a more
 828         logical place for it to live.
 829         - Also moved knownServers from the ServerConnection to
 830         DebuggerApplication to match the Windows code and because it makes sense
 831         that a connection knows its own server but not all of them.
 832
 833         * Drosera/mac/DebuggerClient.h: Moved the log function to
 834           DebuggerDocumentPlatform.
 835         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
 836           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
 837           call for the server name up from the ServerConnection class.
 838         (-[DebuggerClient dealloc]):
 839         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
 840           for the server name up from the ServerConnection.
 841         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
 842         (DebuggerDocument::platformPause):
 843         (DebuggerDocument::platformResume):
 844         (DebuggerDocument::platformStepInto):
 845         (DebuggerDocument::platformEvaluateScript):
 846         (DebuggerDocument::getPlatformCurrentFunctionStack):
 847         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 848         (DebuggerDocument::platformValueForScopeVariableNamed):
 849         (DebuggerDocument::platformLog): Log directly from here. No need to call
 850           DebuggerClient.
 851         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
 852           way I see it, a ServerConnection should only know about its connection
 853           and the group of all possible servers should be kept by the
 854           application.
 855         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
 856           currentServerName, it makes sense that the connection should know that
 857           name.
 858         (-[ServerConnection currentServerName]):
 859
 860 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
 861
 862         Reviewed by Adam.
 863
 864         - Integrated changes from mac drosera.  Recently I've encapsulated
 865         out the server connection object from the rest of Drosera because
 866         it is very platform dependent right now and RPC is not implemented on
 867         windows.  This functionality, of communicating with the WebKit server
 868         is the next area I will be focusing on in Windows.
 869
 870         - Other changes and cleanup were made to organize the code and add notes
 871         on which parts still need work.  Also some mac code is added and
 872         commented out, to act as pseudocode for the logic of those parts.
 873
 874         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
 875           pointer.
 876         * Drosera/config.h: Added whitespace.
 877         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
 878           these files got moved into Drosera.h/cpp
 879         * Drosera/win/DebuggerApplication.h: Removed.
 880         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring
 881           happened here to better match the logic flow of the same code on the
 882           mac side and to use the new ServerConnection class.
 883         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
 884         (DebuggerClient::initWithServerName): Initializer that will set up the
 885           class to use a ServerConnection object.  This was necessary so I could
 886           create a DebuggerClient without having to initilaize it at
 887           construction.
 888         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
 889           will be the UIDelegate and FrameLoadDelegate.
 890         (DebuggerClient::AddRef): For IUnknown.
 891         (DebuggerClient::Release): For IUnknown.
 892         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
 893           this still needs to set the global context of the server, but
 894           IWebFrame does not have an accessor for the global context yet.
 895         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
 896           this is a pass through for the same function in the document.
 897         (DebuggerClient::didReceiveTitle): Unimplemented part of
 898           FrameLoadDelegate this would change the title of the window.
 899         (DebuggerClient::createWebViewWithRequest): Part of the
 900           FrameLoadDelegate.  This is about new windows via Window.open() and
 901           how their delegates are set.
 902         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
 903           UIDelegate.  Just a debug function for printing messages.
 904         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
 905           because the Client should be the UIDelegate and FrameLoadDelegate
 906           to match the delegates on mac.
 907         (DebuggerClient::webViewLoaded): Added accessor method.
 908         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
 909           forgotten to add this file before.  This is where the platform
 910           dependent versions of the Documents functions live. Most of these are
 911           unimplemented because some piece of functionality does not exist on
 912           Windows yet.
 913         (DebuggerDocument::platformPause):
 914         (DebuggerDocument::platformResume):
 915         (DebuggerDocument::platformStepInto):
 916         (DebuggerDocument::platformEvaluateScript):
 917         (DebuggerDocument::getPlatformCurrentFunctionStack):
 918         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 919         (DebuggerDocument::platformValueForScopeVariableNamed):
 920         (DebuggerDocument::platformLog):
 921         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
 922           responsibilities becaue they belong in the Client. Also I laid the
 923           groundwork for attaching Drosera to a WebKit process
 924         (attachWndProc): Now if a server is selected the Client becomes it's
 925           delegate.
 926         (Drosera::Drosera): Added the construction of the Client and dictionary
 927           of server names.
 928         (Drosera::initUI): This is no longer the delegates, the Client is.
 929         (Drosera::webViewLoaded): Now asks the Client instead of holding local
 930           state.
 931         (Drosera::applicationDidFinishLaunching): Placeholder for needed
 932           notification registration when it's possible to implement.
 933         (Drosera::serverLoaded): Ditto
 934         (Drosera::serverUnloaded): Ditto
 935         (Drosera::attach): Attach Drosera to the WebKit server.
 936         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
 937         (Drosera::getInst):
 938         (Drosera::setInst):
 939         (Drosera::knownServers):
 940         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
 941           and added the ServerConnection.
 942         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
 943         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
 944           Most of the functions are completely unimlemented because they cannot
 945           connect with the WebKit server, because one does not exist on Windows
 946           yet.
 947         (ServerConnection::initWithServerName):
 948         (ServerConnection::~ServerConnection):
 949         (ServerConnection::setGlobalContext):
 950         (ServerConnection::pause):
 951         (ServerConnection::resume):
 952         (ServerConnection::stepInto):
 953         (ServerConnection::switchToServerNamed):
 954         (ServerConnection::applicationTerminating):
 955         (ServerConnection::serverConnectionDidDie):
 956         (ServerConnection::currentFrame):
 957         * Drosera/win/ServerConnection.h: Added. Ditto.
 958         (ServerConnection::ServerConnection):
 959
 960 2007-10-19  Alice Liu  <alice.liu@apple.com>
 961
 962         Reviewed by Darin.
 963
 964         Fix for these broken layout tests on Windows:
 965
 966         fast/forms/focus-selection-input.html
 967         fast/forms/focus-selection-textarea.html
 968         fast/forms/select-accesskey.html
 969
 970         * DumpRenderTree/win/EventSender.cpp:
 971         (keyDownCallback):
 972         correct the VK code for alt key.
 973
 974 2007-10-19  Eric Seidel  <eric@webkit.org>
 975
 976         Reviewed by Mark Rowe.
 977
 978         Make the GtkLauncher code slightly more readable.
 979
 980         * GtkLauncher/main.cpp:
 981         (setupMainMenu): Added.
 982         (setupMainWindowUI): Added.
 983         (main):
 984
 985 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
 986
 987         Rubber stamped by Adam.
 988
 989         - don't delay-load WebKit in DumpRenderTree.
 990
 991         * DumpRenderTree/win/DumpRenderTree.vcproj:
 992
 993 2007-10-18  Dan Bernstein  <dan.bernstein@apple.com>
 994
 995         Reviewed by Adam Roben.
 996
 997         - fix <rdar://problem/5313523>
 998         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
 999
1000         * DumpRenderTree/mac/DumpRenderTree.mm:
1001         (dump): Changed to use _responseMIMEType.
1002
1003 2007-10-17  Adam Roben  <aroben@apple.com>
1004
1005         Make it possible to have Windows-specific tests and results
1006
1007         When searching for tests to run and the Skipped file, we will only
1008         look in platform/win and the cross-platform directory. When looking
1009         for expected results, we will look in platform/win, then
1010         platform/mac-leopard, then platform/mac, then finally the
1011         cross-platform directory.
1012
1013         Reviewed by Sam.
1014
1015         * Scripts/run-webkit-tests:
1016         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
1017         searching in the cross-platform directory.
1018         (sub buildPlatformHierarchy): Removed some unneeded calls to
1019         dirname/basename.
1020
1021 2007-10-17  Adam Roben  <aroben@apple.com>
1022
1023         Add back the call to register WebKit that we had before WebKitInitializer existed
1024
1025         This is needed to ensure that the right WebKit is used when
1026         instantiating COM objects.
1027
1028         Reviewed by Oliver.
1029
1030         * DumpRenderTree/win/debug_internal.vsprops: Define
1031         DEBUG_WEBKIT_HAS_SUFFIX.
1032         * DumpRenderTree/win/DumpRenderTree.cpp:
1033         (initialize):
1034
1035 2007-10-17  Adam Roben  <aroben@apple.com>
1036
1037         Import File::Basename in webkitdirs since we use it
1038
1039         * Scripts/webkitdirs.pm:
1040
1041 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
1042
1043         - Updated the tiger leaks list to make the internal bots green.
1044
1045         * Scripts/run-webkit-tests:
1046
1047 2007-10-17  Adam Roben  <aroben@apple.com>
1048
1049         Build fix for VC++ Express
1050
1051         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
1052         and ole32.lib.
1053
1054 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1055
1056         Reviewed by Sam.
1057
1058         - Minor mac improvements based on observations I made while implementing the
1059         Windows code.
1060
1061         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
1062         then hand it to the Client who will retain it, it should just be the client who
1063         creates and owns the server.
1064         (-[DebuggerApplication attach:]):
1065         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
1066         * Drosera/mac/DebuggerClient.mm: Creates the server.
1067         (-[DebuggerClient initWithServerName:]):
1068         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
1069         can instead forward declare what it needs.
1070
1071 2007-10-16  Darin Adler  <darin@apple.com>
1072
1073         Reviewed by Geoff Garen.
1074
1075         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
1076         want to turn failing tests into platform-specific test results. Also did a
1077         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
1078         would take the type of results into account only some of the time.
1079
1080 2007-10-16  Adam Roben  <aroben@apple.com>
1081
1082         Add a new nightly launcher script for Windows
1083
1084         This new script is for versions of Safari that don't delay-load
1085         WebKit. I had to make FindSafari be able to print out the nightly
1086         launcher script on stdout because Windows shell scripts can't capture
1087         the output from a command into an environment variable.
1088
1089         Reviewed by Steve.
1090
1091         * FindSafari/FindSafari.cpp:
1092         (_tmain): Added /printSafariLauncher option.
1093         * Scripts/run-webkit-nightly.cmd: Added.
1094
1095 2007-10-16  Adam Roben  <aroben@apple.com>
1096
1097         Replace WebKitInitializer with FindSafari
1098
1099         We now rely on setting the PATH environment variable to tell Windows
1100         where to find WebKit and its dependencies (similar to
1101         DYLD_FRAMEWORK_PATH on Mac).
1102
1103         This change also make DumpRenderTree no longer delay-load WebKit.
1104
1105         Reviewed by Sam.
1106
1107         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
1108         FindSafari.
1109         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
1110         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
1111         WebKitInitializer, don't delay-load WebKit.
1112         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
1113         * Scripts/run-webkit-tests: Ditto.
1114         * Scripts/webkitdirs.pm:
1115         (sub setPathForRunningWebKitApp): Added.
1116         * WebKitInitializer/WebKitInitializer.cpp: Removed.
1117         * WebKitInitializer/WebKitInitializer.h: Removed.
1118         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
1119         * WebKitInitializer/debug.vsprops: Removed.
1120         * WebKitInitializer/debug_internal.vsprops: Removed.
1121         * WebKitInitializer/release.vsprops: Removed.
1122
1123 2007-10-16  Adam Roben  <aroben@apple.com>
1124
1125         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
1126
1127         http://bugs.webkit.org/show_bug.cgi?id=15532
1128
1129         FindSafari simply prints the location of an installed Safari.exe on
1130         stdout.
1131
1132         Reviewed by Darin.
1133
1134         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
1135         (getStringValue):
1136         (getWebViewCLSID):
1137         (getInstalledWebKitDirectory):
1138         (_tmain):
1139         * FindSafari/FindSafari.vcproj: Added.
1140         * Scripts/webkitdirs.pm:
1141         (sub installedSafariPath): Added. Calls FindSafari on Windows.
1142
1143 2007-10-16  Adam Roben  <aroben@apple.com>
1144
1145         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
1146
1147         Reviewed by Kevin McCullough.
1148
1149         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
1150         when referring to WebKit.dll.
1151         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
1152         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
1153         * DumpRenderTree/win/release.vsprops: Ditto.
1154         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
1155         never have a _debug suffix on WebKit.dll.
1156         * WebKitInitializer/WebKitInitializer.cpp:
1157         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
1158         specified.
1159         * WebKitInitializer/debug_internal.vsprops: Added
1160         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
1161
1162 2007-10-16  Darin Adler  <darin@apple.com>
1163
1164         Reviewed by Adele.
1165
1166         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
1167         Remove now-unneeded control/alt key hack; the tests have been updated.
1168
1169 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1170
1171         - Updated leaks list because our internal bot upgraded it's version of leopard and
1172         one of the leaks was fixed between that revision and the bot's previous version of
1173         leopard.
1174
1175         * Scripts/run-webkit-tests:
1176
1177 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
1178
1179         Reviewed by Tim.
1180
1181         - I encapsulated out the server connecton functionality because it is a specific part
1182         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
1183         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
1184         Windows.  So the majority of this patch is moving preexisting functionality.
1185
1186         - Also I removed the prefix header and changed to use config.h because it is more
1187         standard on how we use config.h in windows and it didn't make much sense to keep
1188         the prefix header and the config.h
1189
1190         * Drosera/DebuggerDocument.cpp:
1191         (DebuggerDocument::DebuggerDocument):
1192         * Drosera/DebuggerDocument.h:
1193         * Drosera/config.h:
1194         * Drosera/mac/DebuggerApplication.mm:
1195         (-[DebuggerApplication attach:]):
1196         * Drosera/mac/DebuggerClient.h:
1197         * Drosera/mac/DebuggerClient.mm:
1198         (-[DebuggerClient initWithServerConnection:]):
1199         (-[DebuggerClient dealloc]):
1200         (-[DebuggerClient windowDidLoad]):
1201         (-[DebuggerClient windowWillClose:]):
1202         (-[DebuggerClient webView:didFinishLoadForFrame:]):
1203         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
1204         * Drosera/mac/DebuggerDocumentPlatform.mm:
1205         (DebuggerDocument::platformPause):
1206         (DebuggerDocument::platformResume):
1207         (DebuggerDocument::platformStepInto):
1208         (DebuggerDocument::platformEvaluateScript):
1209         (DebuggerDocument::getPlatformCurrentFunctionStack):
1210         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1211         (DebuggerDocument::platformValueForScopeVariableNamed):
1212         (DebuggerDocument::platformLog):
1213         * Drosera/mac/Drosera.pch: Removed.
1214         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1215         * Drosera/mac/ServerConnection.h: Added.
1216         * Drosera/mac/ServerConnection.mm: Added.
1217         (-[ServerConnection initWithServerName:]):
1218         (-[ServerConnection dealloc]):
1219         (-[ServerConnection setGlobalContext:]):
1220         (-[ServerConnection pause]):
1221         (-[ServerConnection resume]):
1222         (-[ServerConnection stepInto]):
1223         (-[ServerConnection switchToServerNamed:]):
1224         (-[ServerConnection applicationTerminating:]):
1225         (-[ServerConnection serverConnectionDidDie:]):
1226         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1227         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
1228         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
1229         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
1230         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
1231         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
1232         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
1233         (-[ServerConnection currentFrame]):
1234         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
1235         (-[ServerConnection knownServers]):
1236
1237 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
1238
1239         Reviewed by Eric.
1240
1241         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
1242           Script to automatically search nightly builds for regressions (bisect-builds)
1243
1244         * Scripts/bisect-builds: Added.
1245
1246 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
1247
1248         Reviewed by Darin.
1249
1250         - New JavaScript benchmark
1251         http://bugs.webkit.org/show_bug.cgi?id=15515
1252
1253         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
1254         current development or release build of JavaScriptCore.
1255
1256 2007-10-15  Mark Rowe  <mrowe@apple.com>
1257
1258         Reviewed by Sam.
1259
1260         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
1261
1262         * Scripts/webkitdirs.pm:
1263         - Change checkArgv to remove the options from @ARGV to prevent
1264         them from interfering with further option processing.
1265         - Fix logic error in determineIsQt that would prevent it from bailing out early.
1266         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
1267         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
1268         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
1269
1270 2007-10-15  Darin Adler  <darin@apple.com>
1271
1272         Reviewed by Sam.
1273
1274         - added logging of window.prompt and window.confirm
1275
1276         * DumpRenderTree/mac/UIDelegate.mm:
1277         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1278         Implement the recommended delegate rather than the deprecated one.
1279         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
1280         Added.
1281         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1282         Added.
1283
1284         * DumpRenderTree/win/UIDelegate.h:
1285         * DumpRenderTree/win/UIDelegate.cpp:
1286         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
1287         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1288         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
1289         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
1290
1291 2007-10-15  Alice Liu  <alice.liu@apple.com>
1292
1293         Reviewed by Sam Weinig.
1294
1295         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
1296
1297         * DumpRenderTree/win/DumpRenderTree.cpp:
1298         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
1299         (main): allocate the global policy delegate for DRT's custom use
1300         * DumpRenderTree/win/DumpRenderTree.vcproj:
1301         Adding files to project
1302         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
1303         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1304         (LayoutTestController::setCustomPolicyDelegate):
1305         set the webview's policy delegate to DRT's custom one if the test requests it.
1306         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
1307         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
1308         (PolicyDelegate::PolicyDelegate):
1309         (PolicyDelegate::QueryInterface):
1310         (PolicyDelegate::AddRef):
1311         (PolicyDelegate::Release):
1312         (PolicyDelegate::decidePolicyForNavigationAction):
1313         * DumpRenderTree/win/PolicyDelegate.h: Added.
1314         (PolicyDelegate::decidePolicyForNewWindowAction):
1315         (PolicyDelegate::decidePolicyForMIMEType):
1316         (PolicyDelegate::unableToImplementPolicyWithError):
1317
1318 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
1319
1320         Reviewed by Mark.
1321
1322         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
1323         when querying for QMAKE_MKSPECS.
1324
1325 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
1326
1327         Reviewed by Adam Roben.
1328
1329         Fix run-webkit-tests is too greedy calculating platform hierarchy
1330         http://bugs.webkit.org/show_bug.cgi?id=15465
1331
1332         Fix run-webkit-tests being too greedy in trying to split the platform name up
1333         causing it to try and find tests in every directory above the first "-" in the
1334         path to the LayoutTests
1335
1336         * Scripts/run-webkit-tests:
1337
1338 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
1339
1340         Reviewed by Darin.
1341
1342         http://bugs.webkit.org/show_bug.cgi?id=15006
1343         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
1344         to reduce code duplication.
1345
1346         * Scripts/build-webkit:
1347         * Scripts/webkitdirs.pm:
1348         buildQMakeProject() renamed to buildQMakeQtProject().
1349         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
1350         unused $colorize has been removed.
1351
1352 === Start merge of feature-branch 2007-10-12 ===
1353
1354 2007-10-08  Eric Seidel  <eric@webkit.org>
1355
1356         Reviewed by Mark Rowe.
1357
1358         * Scripts/build-webkit: add --help, remove unused --color
1359
1360 2007-10-07  Eric Seidel  <eric@webkit.org>
1361
1362         Reviewed by darin.
1363
1364         * Drosera/mac/DebuggerDocumentPlatform.mm:
1365         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
1366
1367 2007-10-03  Rob Buis  <buis@kde.org>
1368
1369         Reviewed by Olliej.
1370
1371         Adapt to changed location of Ahem font.
1372
1373         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1374
1375 2007-10-02  Eric Seidel  <eric@webkit.org>
1376
1377         Reviewed by Adam Roben.
1378
1379         Make pixel tests more useful!
1380         Finally fix the image diff 0.00% mystery problem
1381         Highlight any image differences in the image diff.
1382         Add a link from image diffs back to original test file.
1383
1384         * DumpRenderTree/mac/ImageDiff.m:
1385         (compareImages): highlight any differences
1386         (computePercentageDifferent): round to two decimal places
1387         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
1388
1389 2007-10-02  Eric Seidel  <eric@webkit.org>
1390
1391         Reviewed by Alexey Proskuryakov.
1392
1393         * Scripts/run-webkit-tests: print the % image difference on main results page
1394
1395 2007-10-02  Mark Rowe  <mrowe@apple.com>
1396
1397         Reviewed by Oliver.
1398
1399         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1400
1401         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1402         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1403
1404 2007-10-01  Mark Rowe  <mrowe@apple.com>
1405
1406         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1407
1408 2007-09-25  Eric Seidel  <eric@webkit.org>
1409
1410         Reviewed by Mark Rowe.
1411
1412         DerivedSources.make was finding "ENABLE_SVG" in the string
1413         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
1414         quite correctly.
1415
1416         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
1417
1418 2007-09-25  Mark Rowe  <mrowe@apple.com>
1419
1420         Rubber-stamped by Eric.
1421
1422         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1423         This makes it possible to automate nightly builds for the feature-branch.
1424
1425 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
1426
1427         Rubber stamped by Mark.
1428
1429         Enable svg experimental features as default here in feature-branch.
1430
1431         * Scripts/build-webkit:
1432
1433 2007-06-29  Antti Koivisto  <antti@apple.com>
1434
1435         Reviewed by Weinig.
1436
1437         Add VIDEO flag for timed media features
1438
1439         * Scripts/build-webkit
1440
1441 === End merge of feature-branch 2007-10-12 ===
1442
1443 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1444
1445         Reviewed by Darin.
1446
1447         - Updated rational for the leaks list to be more clear.
1448
1449         * Scripts/run-webkit-tests:
1450
1451 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1452
1453         Rubber Stamp by Sam.
1454
1455         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
1456         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
1457
1458         * Scripts/run-webkit-tests:
1459
1460 2007-10-10  Simon Hausmann  <hausmann@kde.org>
1461
1462         Reviewed by Lars.
1463
1464         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
1465         includes are needed for INT_MAX, std::auto_ptr and the like.
1466
1467         * DumpRenderTree/qt/main.cpp:
1468
1469 2007-10-09  Lars Knoll  <lars@trolltech.com>
1470
1471         Reviewed by Simon.
1472
1473         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
1474
1475         * DumpRenderTree/qt/jsobjects.cpp:
1476         (LayoutTestController::encodeHostName):
1477         (LayoutTestController::decodeHostName):
1478         * DumpRenderTree/qt/jsobjects.h:
1479
1480 2007-10-09  Lars Knoll  <lars@trolltech.com>
1481
1482         Reviewed by Simon.
1483
1484         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
1485
1486         * DumpRenderTree/qt/DumpRenderTree.cpp:
1487         (WebCore::WebPage::createFrame):
1488         (WebCore::DumpRenderTree::DumpRenderTree):
1489         (WebCore::DumpRenderTree::titleChanged):
1490         * DumpRenderTree/qt/DumpRenderTree.h:
1491         * DumpRenderTree/qt/jsobjects.cpp:
1492         (LayoutTestController::reset):
1493         * DumpRenderTree/qt/jsobjects.h:
1494
1495 2007-10-09  Lars Knoll  <lars@trolltech.com>
1496
1497         Reviewed by Simon.
1498
1499         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
1500
1501         * DumpRenderTree/qt/DumpRenderTree.h:
1502         * DumpRenderTree/qt/jsobjects.cpp:
1503         (LayoutTestController::clearBackForwardList):
1504         * DumpRenderTree/qt/jsobjects.h:
1505
1506 2007-10-09  Lars Knoll  <lars@trolltech.com>
1507
1508         Reviewed by Simon.
1509
1510         make --git-reviewer work again.
1511
1512         * Scripts/prepare-ChangeLog:
1513
1514 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
1515
1516         Rubber stamped by Eric.
1517
1518         Connect to the "hovering-over-link" signal emitted by WebKitPage and
1519         show the current link inside the statusbar.
1520         This shows how to make use of this signal and allows to easily test
1521         http://bugs.webkit.org/show_bug.cgi?id=15299.
1522
1523         * GtkLauncher/main.cpp:
1524         (hoveringOverLink):
1525         (main):
1526
1527 2007-10-05  Lars Knoll  <lars@trolltech.com>
1528
1529         add proper error messages to the FrameLoaderClient.
1530         Implement ChromeClientQt::closeWindowSoon and
1531         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
1532         Some fixes in DRT to make it work correctly with multiple windows.
1533
1534         Reviewed by Maciej.
1535
1536         * DumpRenderTree/qt/DumpRenderTree.cpp:
1537         (WebCore::DumpRenderTree::DumpRenderTree):
1538         (WebCore::DumpRenderTree::createWindow):
1539         (WebCore::DumpRenderTree::windowCount):
1540         * DumpRenderTree/qt/DumpRenderTree.h:
1541         * DumpRenderTree/qt/jsobjects.cpp:
1542         (LayoutTestController::maybeDump):
1543         (LayoutTestController::windowCount):
1544         * DumpRenderTree/qt/jsobjects.h:
1545
1546 2007-10-05  Lars Knoll  <lars@trolltech.com>
1547
1548         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
1549         Add support for layoutTextController.setCanOpenWindows() to DRT
1550         fixing another 2 test cases in fast/dom/Window.
1551
1552         Reviewed by Maciej.
1553
1554         * DumpRenderTree/qt/DumpRenderTree.cpp:
1555         (WebCore::WebPage::WebPage):
1556         (WebCore::WebPage::createWindow):
1557         (WebCore::DumpRenderTree::resetJSObjects):
1558         (WebCore::DumpRenderTree::createWindow):
1559         * DumpRenderTree/qt/DumpRenderTree.h:
1560         * DumpRenderTree/qt/DumpRenderTree.pro:
1561         * DumpRenderTree/qt/jsobjects.cpp:
1562         (LayoutTestController::LayoutTestController):
1563         (LayoutTestController::reset):
1564         * DumpRenderTree/qt/jsobjects.h:
1565         * DumpRenderTree/qt/main.cpp:
1566         * DumpRenderTree/qt/testplugin.cpp: Added.
1567         * DumpRenderTree/qt/testplugin.h: Added.
1568
1569 2007-10-04  Sam Weinig  <sam@webkit.org>
1570
1571         Rubber stamped by Adam.
1572
1573         Remove empty directories.
1574
1575         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
1576         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
1577
1578 2007-10-03  Darin Adler  <darin@apple.com>
1579
1580         Reviewed by Adam.
1581
1582         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
1583         we find the internal libraries in the libraries directory. This
1584         is helpful for Safari team engineers at Apple.
1585
1586 2007-10-03  Adam Roben  <aroben@apple.com>
1587
1588         Update the location of AHEM___.TTF after r25968
1589
1590         Reviewed by Sam.
1591
1592         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1593
1594 2007-10-03  Alp Toker  <alp@atoker.com>
1595
1596         Reviewed by Adam.
1597
1598         http://bugs.webkit.org/show_bug.cgi?id=14726
1599         [gtk] API design. Mapping the WebView delegates to signals.
1600
1601         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
1602
1603         * GtkLauncher/main.cpp:
1604         (goToURLBarText):
1605         (titleChanged):
1606         (progressChanged):
1607         (menuMainBackCallback):
1608         (menuMainForwardCallback):
1609         (main):
1610
1611 2007-10-03  Lars Knoll  <lars@trolltech.com>
1612
1613         Reviewed by Rob.
1614
1615         This fixes --strict mode in run-webkit-tests again after
1616         the platform dependent test results have been moved.
1617
1618         * Scripts/run-webkit-tests:
1619
1620 2007-10-03  Lars Knoll  <lars@trolltech.com>
1621
1622         Reviewed by bdash.
1623
1624         remove the hack in run-webkit-tests that forced text only test
1625         to be taken from the platform independent dir. It was only left
1626         there from early days.
1627
1628         Remove platform dependent results for tests that are text only nowadays,
1629         and add one platform dependent result for a text only test that requires it.
1630
1631         * Scripts/run-webkit-tests:
1632
1633 2007-10-03  Lars Knoll  <lars@trolltech.com>
1634
1635         Reviewed by olliej.
1636
1637         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
1638
1639         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
1640         (WebCore::WebFrame::WebFrame):
1641         (WebCore::WebPage::WebPage):
1642         (WebCore::WebPage::createFrame):
1643         (WebCore::WebPage::javaScriptAlert):
1644         (WebCore::WebPage::javaScriptConsoleMessage):
1645         (WebCore::DumpRenderTree::DumpRenderTree):
1646         (WebCore::DumpRenderTree::~DumpRenderTree):
1647         (WebCore::DumpRenderTree::open):
1648         (WebCore::DumpRenderTree::readStdin):
1649         (WebCore::DumpRenderTree::resetJSObjects):
1650         (WebCore::DumpRenderTree::initJSObjects):
1651         (WebCore::DumpRenderTree::dumpFramesAsText):
1652         (WebCore::DumpRenderTree::dump):
1653         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
1654         (WebCore::DumpRenderTree::layoutTestController):
1655         (WebCore::DumpRenderTree::eventSender):
1656         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
1657         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
1658         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
1659         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
1660         (HackWebFrame::mousePressEvent):
1661         (HackWebFrame::mouseReleaseEvent):
1662         (HackWebFrame::mouseMoveEvent):
1663         (HackWebFrame::HackWebFrame):
1664         (HackWebFrame::~HackWebFrame):
1665         (LayoutTestController::LayoutTestController):
1666         (LayoutTestController::reset):
1667         (LayoutTestController::maybeDump):
1668         (LayoutTestController::waitUntilDone):
1669         (LayoutTestController::notifyDone):
1670         (LayoutTestController::dumpEditingCallbacks):
1671         (LayoutTestController::queueReload):
1672         (LayoutTestController::provisionalLoad):
1673         (LayoutTestController::timerEvent):
1674         (EventSender::EventSender):
1675         (EventSender::mouseDown):
1676         (EventSender::mouseUp):
1677         (EventSender::mouseMoveTo):
1678         (EventSender::leapForward):
1679         (EventSender::keyDown):
1680         (EventSender::frameUnderMouse):
1681         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
1682         (LayoutTestController::isLoading):
1683         (LayoutTestController::setLoading):
1684         (LayoutTestController::shouldDumpAsText):
1685         (LayoutTestController::shouldDumpChildrenAsText):
1686         (LayoutTestController::shouldWaitUntilDone):
1687         (LayoutTestController::dumpAsText):
1688         (LayoutTestController::dumpChildFramesAsText):
1689         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
1690         (messageHandler):
1691         (crashHandler):
1692         (main):
1693         * Scripts/run-webkit-tests:
1694
1695 2007-10-03  Mark Rowe  <mrowe@apple.com>
1696
1697         Reviewed by Alp Toker.
1698
1699         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
1700         should take precedence over QTDIR when determining which port we are working with.
1701
1702         * Scripts/webkitdirs.pm:
1703
1704 2007-10-02  Adam Roben  <aroben@apple.com>
1705
1706         Add keychain to the list of default packages to install
1707
1708         Rubberstamped by Sam.
1709
1710         * CygwinDownloader/cygwin-downloader.py:
1711         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
1712
1713 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
1714
1715         Reviewed by Adam.
1716
1717         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
1718         Also makes WebCore regression test case logic work when using git.
1719
1720         * Scripts/prepare-ChangeLog:
1721         (reviewerAndDescriptionForGitCommit): Added.
1722
1723 2007-10-02  Lars Knoll  <lars@trolltech.com>
1724
1725         Reviewed by bdash.
1726
1727         Add API to retrieve the frame name from QWebFrame.
1728         Implement support for DRT::dumpChildrenAsText.
1729
1730         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1731         (WebCore::DumpRenderTree::dumpFramesAsText):
1732         (WebCore::DumpRenderTree::dump):
1733         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
1734         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1735         (LayoutTestController::LayoutTestController):
1736         (LayoutTestController::reset):
1737         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
1738
1739 2007-10-02  Lars Knoll  <lars@trolltech.com>
1740
1741         Reviewed by bdash.
1742
1743         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
1744
1745         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1746         (WebCore::DumpRenderTree::readStdin):
1747
1748 2007-10-02  Mark Rowe  <mrowe@apple.com>
1749
1750         Reviewed by Oliver.
1751
1752         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1753
1754         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1755         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1756
1757 2007-10-02  Mark Rowe  <mrowe@apple.com>
1758
1759         Rubber-stamped by Maciej.
1760
1761         Configuration changes from build.webkit.org.  The major change is refactoring to work
1762         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
1763         last few weeks.
1764
1765         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1766         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
1767         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
1768         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
1769         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
1770         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
1771         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
1772         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
1773
1774 2007-10-02  Lars Knoll  <lars@trolltech.com>
1775
1776         Reviewed by Maciej.
1777
1778         Add support for eventSender.mouseMove to DRT.
1779         Fixes fast/css/hover-affects-child.html
1780
1781         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1782         (EventSender::mouseMoveTo):
1783
1784 2007-10-01  Mark Rowe  <mrowe@apple.com>
1785
1786         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1787
1788 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
1789
1790         Reviewed by Hyatt.
1791
1792         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
1793
1794         * Scripts/svn-apply:
1795         (gitdiff2svndiff): Ignore lines beginning with "new file".
1796         * Scripts/svn-unapply:
1797         (gitdiff2svndiff): Ditto.
1798
1799 2007-09-30  George Staikos  <staikos@kde.org>
1800
1801         Qt build fix (Mac OS X specific)
1802
1803         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
1804
1805 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
1806
1807         Reviewed by Mark.
1808
1809         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
1810         Remove Bakefiles from svn.
1811
1812         * GtkLauncher/Bakefiles.bkgen: Removed.
1813         * GtkLauncher/ENV: Removed.
1814         * GtkLauncher/gdklauncher.bkl: Removed.
1815         * GtkLauncher/mk: Removed.
1816         * Scripts/regenerate-makefiles: Removed.
1817
1818 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
1819
1820         Reviewed by John.
1821
1822         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
1823
1824         * Scripts/run-webkit-tests:
1825
1826 2007-09-26  Adam Roben  <aroben@apple.com>
1827
1828         Make not finding an installed WebKit non-fatal
1829
1830         What really matters is that we are able to load WebKit and its
1831         dependencies, not whether we think we've found an installed WebKit.
1832
1833         Reviewed by Sam.
1834
1835         * WebKitInitializer/WebKitInitializer.cpp:
1836         (getWebViewCLSID): Use new LOG_WARNING macro.
1837         (getInstalledWebKitDirectory): Ditto.
1838         (initializeWebKit): Don't die if we didn't find an installed WebKit,
1839         and use new macros.
1840         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
1841
1842 2007-09-26  Adam Roben  <aroben@apple.com>
1843
1844         Committed this file before saving it
1845
1846         * WebKitInitializer/debug_internal.vsprops:
1847
1848 2007-09-26  Adam Roben  <aroben@apple.com>
1849
1850         Load WebKit and its dependencies manually so they come from DllDirectory
1851
1852         I had to change WebKitInitializer to use malloc/free instead of
1853         new/delete to avoid pulling in WebKit (and its dependencies) early
1854         through use of fastMalloc.
1855
1856         Reviewed by Oliver.
1857
1858         * WebKitInitializer/WebKitInitializer.cpp:
1859         (getStringValue): Changed to use malloc/free.
1860         (getInstalledWebKitDirectory): Ditto.
1861         (initializeWebKit): Call SetDllDirectory first, then load all of
1862         WebKit's dependencies manually, finally followed by WebKit itself.
1863         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
1864         configuration to match our other projects.
1865         * WebKitInitializer/debug_internal.vsprops: Added.
1866
1867 2007-09-25  Adam Roben  <aroben@apple.com>
1868
1869         Actually define DEBUG/NDEBUG so that we load WebKit correctly
1870
1871         Rubberstamped by Sam.
1872
1873         * WebKitInitializer/WebKitInitializer.vcproj:
1874
1875 2007-09-25  Adam Roben  <aroben@apple.com>
1876
1877         Make DumpRenderTree delay-load its dependencies
1878
1879         This lets WebKitInitializer re-route the dependencies to be loaded out
1880         of the Safari installation directory.
1881
1882         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
1883         same thing), since we can't import the kCFAllocatorDefault symbol when
1884         delay-loading CoreFoundation.dll.
1885
1886         Rubberstamped by Sam.
1887
1888         * DumpRenderTree/win/DumpRenderTree.cpp:
1889         (runTest):
1890         (javaScriptThreads):
1891         * DumpRenderTree/win/DumpRenderTree.vcproj:
1892         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1893         (LayoutTestController::setWaitToDump):
1894
1895 2007-09-25  Adam Roben  <aroben@apple.com>
1896
1897         Pull ole32.lib into WebKitInitializer
1898
1899         Rubberstamped by Sam.
1900
1901         * WebKitInitializer/WebKitInitializer.vcproj:
1902
1903 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
1904
1905         Reviewed by Adam.
1906
1907         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
1908           LGPL'ed files contain incorrect FSF address
1909
1910         * Drosera/config.h:
1911
1912 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
1913
1914         Reviewed by Adam.
1915
1916         Make svn-apply and svn-unapply work with git-diff formatted patches.
1917
1918         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
1919         (gitdiff2svndiff): Added.
1920         * Scripts/svn-unapply: Ditto.
1921         (gitdiff2svndiff): Added.
1922
1923 2007-09-25  Adam Roben  <aroben@apple.com>
1924
1925         Pull advapi32.lib into WebKitInitializer
1926
1927         This is needed to get the registry functions we use.
1928
1929         Rubberstamped by Sam.
1930
1931         * WebKitInitializer/WebKitInitializer.vcproj:
1932
1933 2007-09-25  Adam Roben  <aroben@apple.com>
1934
1935         Add python and rsync to cygwin-downloader
1936
1937         Our build slaves need this, and it can't hurt for everyone else to
1938         have it, too.
1939
1940         Reviewed by Sam.
1941
1942         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
1943         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
1944
1945 2007-09-25  Adam Roben  <aroben@apple.com>
1946
1947         Add WebKitInitializer and use it in DumpRenderTree
1948
1949         WebKitInitializer is a static library that has one function,
1950         initializeWebKit(). This registers WebKit and sets up the DLL search
1951         path so that WebKit's dependencies that are installed with Safari can
1952         be found.
1953
1954         Reviewed by Sam.
1955
1956         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
1957         DumpRenderTree depend on it.
1958         * DumpRenderTree/win/DumpRenderTree.cpp:
1959         (initialize): Call initializeWebKit.
1960         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
1961         WebKitInitializer.lib.
1962         * WebKitInitializer/WebKitInitializer.cpp: Added.
1963         (getStringValue):
1964         (getWebViewCLSID):
1965         (getInstalledWebKitDirectory):
1966         (initializeWebKit):
1967         * WebKitInitializer/WebKitInitializer.h: Added.
1968         * WebKitInitializer/WebKitInitializer.vcproj: Added.
1969         * WebKitInitializer/debug.vsprops: Added.
1970         * WebKitInitializer/release.vsprops: Added.
1971
1972 2007-09-25  Adam Roben  <aroben@apple.com>
1973
1974         Make run-webkit-tests respect set-webkit-configuration
1975
1976         Reviewed by Sam.
1977
1978         * Scripts/run-webkit-tests: Initialize $configuration to whatever
1979         set-webkit-configuration was last set to.
1980
1981 2007-09-25  Mark Rowe  <mrowe@apple.com>
1982
1983         Rubber-stamped by Eric.
1984
1985         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1986         This makes it possible to automate nightly builds for the feature-branch.
1987
1988 2007-09-25  Adam Roben  <aroben@apple.com>
1989
1990         A couple of fixes/enhancements to update-webkit-*-libs
1991
1992         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
1993         to tell update-webkit-support-libraries where it should find the
1994         WebKitSupportLibrary.zip file you downloaded.
1995
1996         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
1997         Windows-style path.
1998
1999         Reviewed by Sam.
2000
2001         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
2002         to $auxiliaryLibsURL and removed an irrelevant comment.
2003         * Scripts/update-webkit-support-libs:
2004
2005 2007-09-25  Adam Treat  <treat@kde.org>
2006
2007         Reviewed by Simon and Lars.
2008
2009         Refactors and cleans up Qt DRT member variable names, member variable
2010         initialization, style fixes and general code cleanup.
2011
2012         Adds queueReload slot to LayoutTestController that some tests require.
2013
2014         Subclasses QWebFrame to make sure that all frames have an associated
2015         LayoutTestController JS window object.
2016
2017         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
2018         aren't dumped twice.
2019
2020         EOF fixes.
2021
2022         Together, this patch fixes some 20+ layout tests in QtWebKit.
2023
2024         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2025         (WebCore::WebFrame::WebFrame):
2026         (WebCore::WebPage::WebPage):
2027         (WebCore::WebPage::createFrame):
2028         (WebCore::DumpRenderTree::DumpRenderTree):
2029         (WebCore::DumpRenderTree::open):
2030         (WebCore::DumpRenderTree::readStdin):
2031         (WebCore::DumpRenderTree::initJSObjects):
2032         (WebCore::DumpRenderTree::dump):
2033         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2034         (WebCore::DumpRenderTree::layoutTestController):
2035         (WebCore::DumpRenderTree::eventSender):
2036         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2037         (LayoutTestController::LayoutTestController):
2038         (LayoutTestController::reset):
2039         (LayoutTestController::maybeDump):
2040         (LayoutTestController::waitUntilDone):
2041         (LayoutTestController::notifyDone):
2042         (LayoutTestController::queueReload):
2043         (LayoutTestController::provisionalLoad):
2044         (EventSender::EventSender):
2045         (EventSender::mouseDown):
2046         (EventSender::mouseUp):
2047         (EventSender::mouseMoveTo):
2048         (EventSender::frameUnderMouse):
2049         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2050         (LayoutTestController::isLoading):
2051         (LayoutTestController::setLoading):
2052         (LayoutTestController::dumpAsText):
2053         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
2054         (main):
2055
2056 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2057
2058
2059         - Reverted an accidentally checked in file.
2060
2061         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
2062
2063 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2064         Reviewed by Sam.
2065
2066         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
2067
2068         * DumpRenderTree/win/DumpRenderTree.vcproj:
2069         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2070
2071 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
2072
2073         Rubber stamped by Adam.
2074
2075         * GdkLauncher: Removed.
2076         * GdkLauncher/Bakefiles.bkgen: Removed.
2077         * GdkLauncher/ENV: Removed.
2078         * GdkLauncher/GdkLauncher.pro: Removed.
2079         * GdkLauncher/gdklauncher.bkl: Removed.
2080         * GdkLauncher/main.cpp: Removed.
2081         * GdkLauncher/mk: Removed.
2082         * GdkLauncher/simple.svg: Removed.
2083         * GdkLauncher/text.html: Removed.
2084         * GtkLauncher: Added.
2085         * GtkLauncher/GdkLauncher.pro: Removed.
2086         * GtkLauncher/GtkLauncher.pro: Added.
2087         * GtkLauncher/main.cpp:
2088         (updateWindowTitle):
2089         (main):
2090         * Scripts/build-webkit:
2091         * Scripts/regenerate-makefiles:
2092         * Scripts/run-javascriptcore-tests:
2093         * Scripts/run-launcher:
2094         * Scripts/run-webkit-tests:
2095         * Scripts/webkitdirs.pm:
2096
2097 2007-09-21  Timothy Hatcher  <timothy@apple.com>
2098
2099         Reviewed by Darin.
2100
2101         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
2102
2103         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
2104         This is tested by plugins/root-object-premature-delete-crash.html.
2105
2106         * DumpRenderTree/mac/ObjCController.m:
2107         (-[ObjCController accessStoredWebScriptObject]):
2108
2109 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
2110
2111         Reviewed by Oliver.
2112
2113         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
2114
2115         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2116         (FrameLoadDelegate::FrameLoadDelegate):
2117
2118 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
2119
2120         Reviewed by Adam.
2121
2122         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
2123         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
2124
2125         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
2126         Now isQt() and isGdk() use global variables that are only set once.
2127
2128         An array of all the parameters is now given to build-dumprender which includes
2129         the platform on linux.
2130
2131         * Scripts/build-dumprendertree:
2132         * Scripts/run-webkit-tests:
2133         * Scripts/webkitdirs.pm:
2134
2135 2007-09-19  Adam Roben  <aroben@apple.com>
2136
2137         Rubberstamped by Hyatt.
2138
2139         * Spinneret: Removed.
2140
2141 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
2142
2143         Reviewed by David Kilzer.
2144
2145         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
2146
2147 2007-09-18  Sam Weinig  <sam@webkit.org>
2148
2149         Add JSRetainPtr.h #include to fix some builds.
2150
2151         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2152
2153 2007-09-18  Mike Hommey  <glandium@debian.org>
2154
2155         Reviewed by Adam.
2156
2157         * Scripts/prepare-ChangeLog:
2158         - Properly parse GECOS field.
2159         - Use git configuration for user name and email when appropriate.
2160
2161 2007-09-17  Sam Weinig  <sam@webkit.org>
2162
2163         Build fix.
2164
2165         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2166
2167 2007-09-17  Sam Weinig  <sam@webkit.org>
2168
2169         Reviewed by Adam Roben.
2170
2171         Share more code between mac and windows DRT.
2172             - GCController is now shared.
2173             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
2174
2175         * DumpRenderTree/GCController.cpp:
2176         * DumpRenderTree/win/DumpRenderTree.cpp:
2177         * DumpRenderTree/win/DumpRenderTree.vcproj:
2178         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
2179         (FrameLoadDelegate::FrameLoadDelegate):
2180         (FrameLoadDelegate::~FrameLoadDelegate):
2181         (FrameLoadDelegate::windowScriptObjectAvailable):
2182         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
2183         * DumpRenderTree/win/GCController.cpp: Removed.
2184         * DumpRenderTree/win/GCController.h: Removed.
2185         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
2186         (GCController::collect):
2187         (GCController::collectOnAlternateThread):
2188         (GCController::getJSObjectCount):
2189         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
2190         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
2191
2192 2007-09-17  Sam Weinig  <sam@webkit.org>
2193
2194         Reviewed by Adam Roben.
2195
2196         Begin sharing code between mac and windows DRT.
2197             - both now share LayoutTestController.h/cpp and implement platform dependant
2198               operations in LayoutTestControllerMac/Win.
2199             - DumpRenderTree.h is now shared.
2200             - WorkQueue and WorkQueueItem are also shared.
2201
2202         * DumpRenderTree/DumpRenderTree.h:
2203         * DumpRenderTree/LayoutTestController.cpp:
2204         * DumpRenderTree/win/DumpRenderTree.cpp:
2205         (displayWebView):
2206         (dumpFrameScrollPosition):
2207         (dumpFramesAsText):
2208         (dump):
2209         (runTest):
2210         * DumpRenderTree/win/DumpRenderTree.h: Removed.
2211         * DumpRenderTree/win/DumpRenderTree.vcproj:
2212         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
2213         * DumpRenderTree/win/EditingDelegate.cpp:
2214         (EditingDelegate::shouldBeginEditingInDOMRange):
2215         (EditingDelegate::shouldEndEditingInDOMRange):
2216         (EditingDelegate::shouldInsertNode):
2217         (EditingDelegate::shouldInsertText):
2218         (EditingDelegate::shouldDeleteDOMRange):
2219         (EditingDelegate::shouldChangeSelectedDOMRange):
2220         (EditingDelegate::shouldApplyStyle):
2221         (EditingDelegate::shouldChangeTypingStyle):
2222         (EditingDelegate::doPlatformCommand):
2223         (EditingDelegate::webViewDidBeginEditing):
2224         (EditingDelegate::webViewDidChange):
2225         (EditingDelegate::webViewDidEndEditing):
2226         (EditingDelegate::webViewDidChangeTypingStyle):
2227         (EditingDelegate::webViewDidChangeSelection):
2228         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
2229         * DumpRenderTree/win/LayoutTestController.h: Removed.
2230         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
2231         (LayoutTestController::addDisallowedURL):
2232         (LayoutTestController::clearBackForwardList):
2233         (LayoutTestController::copyDecodedHostName):
2234         (LayoutTestController::copyEncodedHostName):
2235         (LayoutTestController::display):
2236         (LayoutTestController::keepWebHistory):
2237         (LayoutTestController::notifyDone):
2238         (LayoutTestController::queueBackNavigation):
2239         (LayoutTestController::queueForwardNavigation):
2240         (jsStringRefToWString):
2241         (LayoutTestController::queueLoad):
2242         (LayoutTestController::queueReload):
2243         (LayoutTestController::queueScript):
2244         (LayoutTestController::setAcceptsEditing):
2245         (LayoutTestController::setCustomPolicyDelegate):
2246         (LayoutTestController::setMainFrameIsFirstResponder):
2247         (LayoutTestController::setTabKeyCyclesThroughElements):
2248         (LayoutTestController::setUseDashboardCompatibilityMode):
2249         (LayoutTestController::setUserStyleSheetEnabled):
2250         (LayoutTestController::setUserStyleSheetLocation):
2251         (LayoutTestController::setWindowIsKey):
2252         (waitUntilDoneWatchdogFired):
2253         (LayoutTestController::setWaitToDump):
2254         (LayoutTestController::windowCount):
2255         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
2256         (FrameLoadDelegate::didReceiveTitle):
2257         (FrameLoadDelegate::processWork):
2258         (FrameLoadDelegate::locationChangeDone):
2259         (FrameLoadDelegate::windowScriptObjectAvailable):
2260         * DumpRenderTree/win/WorkQueue.cpp: Removed.
2261         * DumpRenderTree/win/WorkQueue.h: Removed.
2262         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
2263         * DumpRenderTree/win/WorkQueueItem.h: Removed.
2264         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
2265         (jsStringRefToWString):
2266         (LoadItem::invoke):
2267         (ScriptItem::invoke):
2268
2269 2007-09-17  Sam Weinig  <sam@webkit.org>
2270
2271         Reviewed by Adam Roben.
2272
2273         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
2274
2275         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
2276         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
2277         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
2278         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
2279         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
2280         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
2281         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
2282         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
2283         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
2284         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
2285         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
2286         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
2287         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
2288         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
2289         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
2290         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
2291         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
2292         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
2293         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
2294         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
2295         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
2296         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
2297         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
2298         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
2299         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
2300         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
2301         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
2302         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
2303         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
2304         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
2305         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
2306         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
2307         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
2308         * DumpRenderTree/win: Added.
2309         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
2310         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
2311         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
2312         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
2313         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
2314         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
2315         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
2316         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
2317         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
2318         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
2319         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
2320         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
2321         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
2322         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2323         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
2324         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
2325         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
2326         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
2327         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2328         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2329         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
2330         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2331         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
2332         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
2333         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
2334         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
2335
2336 2007-09-15  Mark Rowe  <mrowe@apple.com>
2337
2338         Build fix for DumpRenderTree.
2339
2340         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
2341
2342 2007-09-14  Sam Weinig  <sam@webkit.org>
2343
2344         Rubber stamped by Adam Roben.
2345
2346         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
2347           - The UIDelegate was put into a new file while the FrameLoadDelegate was
2348             kept in the WaitUntilDoneDelegate file for the time being.
2349
2350         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
2351         (main):
2352         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
2353         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
2354         (UIDelegate::QueryInterface):
2355         (UIDelegate::AddRef):
2356         (UIDelegate::Release):
2357         (UIDelegate::hasCustomMenuImplementation):
2358         (UIDelegate::setFrame):
2359         (UIDelegate::webViewFrame):
2360         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2361         (UIDelegate::webViewAddMessageToConsole):
2362         (UIDelegate::doDragDrop):
2363         (UIDelegate::webViewGetDlgCode):
2364         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
2365         (UIDelegate::UIDelegate):
2366         (UIDelegate::createWebViewWithRequest):
2367         (UIDelegate::webViewShow):
2368         (UIDelegate::webViewClose):
2369         (UIDelegate::webViewFocus):
2370         (UIDelegate::webViewUnfocus):
2371         (UIDelegate::webViewFirstResponder):
2372         (UIDelegate::makeFirstResponder):
2373         (UIDelegate::setStatusText):
2374         (UIDelegate::webViewStatusText):
2375         (UIDelegate::webViewAreToolbarsVisible):
2376         (UIDelegate::setToolbarsVisible):
2377         (UIDelegate::webViewIsStatusBarVisible):
2378         (UIDelegate::setStatusBarVisible):
2379         (UIDelegate::webViewIsResizable):
2380         (UIDelegate::setResizable):
2381         (UIDelegate::setContentRect):
2382         (UIDelegate::webViewContentRect):
2383         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2384         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2385         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2386         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
2387         (UIDelegate::mouseDidMoveOverElement):
2388         (UIDelegate::contextMenuItemsForElement):
2389         (UIDelegate::validateUserInterfaceItem):
2390         (UIDelegate::shouldPerformAction):
2391         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
2392         (UIDelegate::willPerformDragDestinationAction):
2393         (UIDelegate::dragSourceActionMaskForPoint):
2394         (UIDelegate::willPerformDragSourceAction):
2395         (UIDelegate::contextMenuItemSelected):
2396         (UIDelegate::trackCustomPopupMenu):
2397         (UIDelegate::measureCustomMenuItem):
2398         (UIDelegate::drawCustomMenuItem):
2399         (UIDelegate::addCustomMenuDrawingData):
2400         (UIDelegate::cleanUpCustomMenuDrawingData):
2401         (UIDelegate::canTakeFocus):
2402         (UIDelegate::takeFocus):
2403         (UIDelegate::registerUndoWithTarget):
2404         (UIDelegate::removeAllActionsWithTarget):
2405         (UIDelegate::setActionTitle):
2406         (UIDelegate::undo):
2407         (UIDelegate::redo):
2408         (UIDelegate::canUndo):
2409         (UIDelegate::canRedo):
2410         (UIDelegate::webViewResizerRect):
2411         (UIDelegate::webViewDrawResizer):
2412         (UIDelegate::webViewScrolled):
2413         (UIDelegate::webViewShouldInterruptJavaScript):
2414         (UIDelegate::webViewReceivedFocus):
2415         (UIDelegate::webViewLostFocus):
2416         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
2417         (FrameLoadDelegate::QueryInterface):
2418         (FrameLoadDelegate::AddRef):
2419         (FrameLoadDelegate::Release):
2420         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2421         (FrameLoadDelegate::didCommitLoadForFrame):
2422         (FrameLoadDelegate::didReceiveTitle):
2423         (FrameLoadDelegate::processWork):
2424         (processWorkTimer):
2425         (FrameLoadDelegate::locationChangeDone):
2426         (FrameLoadDelegate::didFinishLoadForFrame):
2427         (FrameLoadDelegate::didFailLoadWithError):
2428         (FrameLoadDelegate::windowScriptObjectAvailable):
2429         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
2430         (FrameLoadDelegate::FrameLoadDelegate):
2431
2432 2007-09-14  Sam Weinig  <sam@webkit.org>
2433
2434         Reviewed by Kevin McCullough.
2435
2436         Move mac specific globals in to mac/DumpRenderTreeMac.h
2437
2438         * DumpRenderTree/DumpRenderTree.h:
2439         * DumpRenderTree/DumpRenderTree.mm: Removed.
2440         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2441         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
2442         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
2443
2444 2007-09-14  Brady Eidson  <beidson@apple.com>
2445
2446         Rubberstamped by Weinig
2447
2448         You know, Sam, some of us use case-sensitve filesystems...
2449
2450         * DumpRenderTree/DumpRenderTree.h:
2451         * DumpRenderTree/mac/UIDelegate.mm:
2452
2453 2007-09-14  Sam Weinig  <sam@webkit.org>
2454
2455         Rubber stamped by Adam Roben.
2456
2457         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
2458         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
2459
2460         * DumpRenderTree/AppleScriptController.h: Removed.
2461         * DumpRenderTree/AppleScriptController.m: Removed.
2462         * DumpRenderTree/DumpRenderTree.h:
2463         * DumpRenderTree/DumpRenderTree.mm:
2464         (startJavaScriptThreads):
2465         (stopJavaScriptThreads):
2466         (activateAhemFont):
2467         (setDefaultColorProfileToRGB):
2468         (makeLargeMallocFailSilently):
2469         (dumpFrameScrollPosition):
2470         (dumpFramesAsText):
2471         (dump):
2472         (runTest):
2473         (-[DumpRenderTreeWindow isKeyWindow]):
2474         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2475         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
2476         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
2477         * DumpRenderTree/EditingDelegate.h: Removed.
2478         * DumpRenderTree/EditingDelegate.m: Removed.
2479         * DumpRenderTree/EventSendingController.h: Removed.
2480         * DumpRenderTree/EventSendingController.m: Removed.
2481         * DumpRenderTree/FrameLoadDelegate.h: Removed.
2482         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
2483         * DumpRenderTree/GCController.mm: Removed.
2484         * DumpRenderTree/ImageDiff.m: Removed.
2485         * DumpRenderTree/LayoutTestController.cpp:
2486         (LayoutTestController::LayoutTestController):
2487         (dumpAsTextCallback):
2488         (dumpBackForwardListCallback):
2489         (dumpChildFramesAsTextCallback):
2490         (dumpChildFrameScrollPositionsCallback):
2491         (dumpDOMAsWebArchiveCallback):
2492         (dumpEditingCallbacksCallback):
2493         (dumpFrameLoadCallbacksCallback):
2494         (dumpResourceLoadCallbacksCallback):
2495         (dumpSelectionRectCallback):
2496         (dumpSourceAsWebArchiveCallback):
2497         (dumpTitleChangesCallback):
2498         (repaintSweepHorizontallyCallback):
2499         (setCallCloseOnWebViewsCallback):
2500         (setCanOpenWindowsCallback):
2501         (setCloseRemainingWindowsWhenCompleteCallback):
2502         (testRepaintCallback):
2503         (addFileToPasteboardOnDragCallback):
2504         (waitUntilDoneCallback):
2505         * DumpRenderTree/LayoutTestController.h:
2506         (LayoutTestController::dumpAsText):
2507         (LayoutTestController::setDumpAsText):
2508         (LayoutTestController::dumpBackForwardList):
2509         (LayoutTestController::setDumpBackForwardList):
2510         (LayoutTestController::dumpChildFrameScrollPositions):
2511         (LayoutTestController::setDumpChildFrameScrollPositions):
2512         (LayoutTestController::dumpChildFramesAsText):
2513         (LayoutTestController::setDumpChildFramesAsText):
2514         (LayoutTestController::dumpDOMAsWebArchive):
2515         (LayoutTestController::setDumpDOMAsWebArchive):
2516         (LayoutTestController::dumpSelectionRect):
2517         (LayoutTestController::setDumpSelectionRect):
2518         (LayoutTestController::dumpSourceAsWebArchive):
2519         (LayoutTestController::setDumpSourceAsWebArchive):
2520         (LayoutTestController::dumpTitleChanges):
2521         (LayoutTestController::setDumpTitleChanges):
2522         (LayoutTestController::dumpEditingCallbacks):
2523         (LayoutTestController::setDumpEditingCallbacks):
2524         (LayoutTestController::dumpResourceLoadCallbacks):
2525         (LayoutTestController::setDumpResourceLoadCallbacks):
2526         (LayoutTestController::dumpFrameLoadCallbacks):
2527         (LayoutTestController::setDumpFrameLoadCallbacks):
2528         (LayoutTestController::addFileToPasteboardOnDrag):
2529         (LayoutTestController::setAddFileToPasteboardOnDrag):
2530         (LayoutTestController::callCloseOnWebViews):
2531         (LayoutTestController::setCallCloseOnWebViews):
2532         (LayoutTestController::canOpenWindows):
2533         (LayoutTestController::setCanOpenWindows):
2534         (LayoutTestController::closeRemainingWindowsWhenComplete):
2535         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2536         (LayoutTestController::testRepaint):
2537         (LayoutTestController::setTestRepaint):
2538         (LayoutTestController::testRepaintSweepHorizontally):
2539         (LayoutTestController::setTestRepaintSweepHorizontally):
2540         (LayoutTestController::waitToDump):
2541         (LayoutTestController::windowIsKey):
2542         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
2543         * DumpRenderTree/NavigationController.h: Removed.
2544         * DumpRenderTree/NavigationController.m: Removed.
2545         * DumpRenderTree/ObjCController.h: Removed.
2546         * DumpRenderTree/ObjCController.m: Removed.
2547         * DumpRenderTree/ObjCPlugin.h: Removed.
2548         * DumpRenderTree/ObjCPlugin.m: Removed.
2549         * DumpRenderTree/ObjCPluginFunction.h: Removed.
2550         * DumpRenderTree/ObjCPluginFunction.m: Removed.
2551         * DumpRenderTree/PolicyDelegate.h: Removed.
2552         * DumpRenderTree/PolicyDelegate.m: Removed.
2553         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
2554         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
2555         * DumpRenderTree/TextInputController.h: Removed.
2556         * DumpRenderTree/TextInputController.m: Removed.
2557         * DumpRenderTree/UIDelegate.h: Removed.
2558         * DumpRenderTree/UIDelegate.mm: Removed.
2559         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
2560         * DumpRenderTree/mac: Added.
2561         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
2562         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
2563         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
2564         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
2565         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
2566         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
2567         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2568         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2569         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2570         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2571         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2572         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2573         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2574         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2575         (-[EditingDelegate webViewDidBeginEditing:]):
2576         (-[EditingDelegate webViewDidChange:]):
2577         (-[EditingDelegate webViewDidEndEditing:]):
2578         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2579         (-[EditingDelegate webViewDidChangeSelection:]):
2580         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
2581         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
2582         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
2583         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
2584         (-[FrameLoadDelegate init]):
2585         (-[FrameLoadDelegate dealloc]):
2586         (-[FrameLoadDelegate processWork:]):
2587         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2588         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2589         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2590         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2591         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2592         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2593         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2594         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2595         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2596         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2597         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2598         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2599         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2600         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2601         (-[FrameLoadDelegate webView:willCloseFrame:]):
2602         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2603         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2604         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
2605         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
2606         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
2607         (LayoutTestController::notifyDone):
2608         (LayoutTestController::setWindowIsKey):
2609         (LayoutTestController::setWaitToDump):
2610         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
2611         * DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
2612         * DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
2613         * DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
2614         * DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
2615         * DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
2616         * DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
2617         * DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
2618         * DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
2619         * DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
2620         * DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
2621         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m.
2622         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2623         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2624         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2625         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2626         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2627         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2628         * DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
2629         * DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
2630         * DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
2631         * DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm.
2632         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
2633         (-[UIDelegate webViewFocus:]):
2634         (-[UIDelegate webView:createWebViewWithRequest:]):
2635         (-[UIDelegate webViewClose:]):
2636         * DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.
2637
2638 2007-09-14  Kevin McCullough  <kmccullough@apple.com>
2639
2640         Reviewed by Adam.
2641
2642         - Changing Win version of Drosera work with recent changes.
2643
2644         * Drosera/DebuggerDocument.cpp:
2645         * Drosera/DebuggerDocument.h:
2646         * Drosera/mac/DebuggerDocumentPlatform.mm:
2647         (NSStringCreateWithJSStringRef):
2648         (JSValueRefCreateWithNSString):
2649         * Drosera/win/DebuggerClient.cpp:
2650         (DebuggerClient::stepInto):
2651         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2652
2653 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
2654
2655         Reviewed by Tim.
2656
2657         - Moved isPaused into the JS for efficiency and simplicity.
2658
2659         * Drosera/DebuggerDocument.cpp:
2660         (DebuggerDocument::DebuggerDocument):
2661         (DebuggerDocument::pauseCallback):
2662         (DebuggerDocument::resumeCallback):
2663         (DebuggerDocument::isPaused):
2664         (DebuggerDocument::staticFunctions):
2665         * Drosera/DebuggerDocument.h:
2666         * Drosera/console.js:
2667         * Drosera/debugger.js:
2668         * Drosera/mac/DebuggerClient.mm:
2669         (-[DebuggerClient validateUserInterfaceItem:]):
2670
2671 2007-09-13  Sam Weinig  <sam@webkit.org>
2672
2673         Rubber stamped by Darin.
2674
2675         Make DumpRenderTree more cross platform ready.
2676         - Convert GCController to use the JSCore API instead of the WebScriptObject.
2677         - Use CF types instead of NS objects.
2678         - General cleanup.
2679
2680         * DumpRenderTree/DumpRenderTree.h:
2681         * DumpRenderTree/DumpRenderTree.mm:
2682         (dumpRenderTree):
2683         (dump):
2684         (runTest):
2685         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2686         * DumpRenderTree/EditingDelegate.m:
2687         * DumpRenderTree/FrameLoadDelegate.h:
2688         * DumpRenderTree/FrameLoadDelegate.mm:
2689         (-[FrameLoadDelegate init]):
2690         (-[FrameLoadDelegate dealloc]):
2691         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2692         * DumpRenderTree/GCController.cpp: Added.
2693         (GCController::GCController):
2694         (GCController::~GCController):
2695         (collectCallback):
2696         (collectOnAlternateThreadCallback):
2697         (getJSObjectCountCallback):
2698         (GCController::makeWindowObject):
2699         (GCController::getJSClass):
2700         (GCController::staticFunctions):
2701         * DumpRenderTree/GCController.h:
2702         * DumpRenderTree/GCController.mm:
2703         (GCController::collect):
2704         (GCController::collectOnAlternateThread):
2705         (GCController::getJSObjectCount):
2706         * DumpRenderTree/LayoutTestController.cpp:
2707         (LayoutTestController::makeWindowObject):
2708         (LayoutTestController::getJSClass):
2709         * DumpRenderTree/LayoutTestController.h:
2710         * DumpRenderTree/LayoutTestControllerMac.mm:
2711         (LayoutTestController::addDisallowedURL):
2712         (waitUntilDoneWatchdogFired):
2713         (LayoutTestController::waitUntilDone):
2714         * DumpRenderTree/ResourceLoadDelegate.m:
2715         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2716
2717 2007-09-12  Sam Weinig  <sam@webkit.org>
2718
2719         Reviewed by Stephanie.
2720
2721         Fix leaks in mac DumpRenderTree.
2722
2723         * DumpRenderTree/FrameLoadDelegate.mm:
2724         (-[FrameLoadDelegate init]): Initalize in the correct order.
2725         (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
2726         * DumpRenderTree/LayoutTestController.cpp:
2727         (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released.
2728         (encodeHostNameCallback): ditto.
2729         * DumpRenderTree/LayoutTestController.h:
2730         * DumpRenderTree/LayoutTestControllerMac.mm:
2731         (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule.
2732         (LayoutTestController::copyEncodedHostName): ditto
2733         (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.
2734
2735 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2736
2737         Reviewed by Geof.
2738
2739         - Updated Leopard leak list to include a leak which appears to be fixed in 9A549 but not the version the bot is on.  This will allow us to get the bot green, but later we should remove it.
2740
2741         * Scripts/run-webkit-tests:
2742
2743 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2744
2745         Reviewed by Darin.
2746
2747         - Simplified code paths and extracted out functions to increase encapsulation.
2748
2749         * Drosera/DebuggerDocument.cpp:
2750         (DebuggerDocument::breakpointEditorHTMLCallback):
2751         (DebuggerDocument::isPausedCallback):
2752         (DebuggerDocument::pauseCallback):
2753         (DebuggerDocument::resumeCallback):
2754         (DebuggerDocument::stepIntoCallback):
2755         (DebuggerDocument::evaluateScriptCallback):
2756         (DebuggerDocument::currentFunctionStackCallback):
2757         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
2758         (DebuggerDocument::valueForScopeVariableNamedCallback):
2759         (DebuggerDocument::logCallback):
2760         * Drosera/DebuggerDocument.h:
2761         (DebuggerDocument::getPaused):
2762         * Drosera/mac/DebuggerClient.mm:
2763         (-[DebuggerClient pause:]):
2764         (-[DebuggerClient resume:]):
2765         (-[DebuggerClient stepInto:]):
2766         (-[DebuggerClient stepOver:]):
2767         (-[DebuggerClient stepOut:]):
2768         (-[DebuggerClient showConsole:]):
2769         (-[DebuggerClient closeCurrentFile:]):
2770         (-[DebuggerClient validateUserInterfaceItem:]):
2771         * Drosera/mac/DebuggerDocumentPlatform.mm: Added.
2772         (+[NSString stringOrNilFromWebScriptResult:]):
2773         (DebuggerDocument::platformPause):
2774         (DebuggerDocument::platformResume):
2775         (DebuggerDocument::platformStepInto):
2776         (DebuggerDocument::platformEvaluateScript):
2777         (DebuggerDocument::getPlatformCurrentFunctionStack):
2778         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2779         (DebuggerDocument::platformValueForScopeVariableNamed):
2780         (DebuggerDocument::platformLog):
2781         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2782
2783 2007-09-12  Sam Weinig  <sam@webkit.org>
2784
2785         Build fix for Buildbot.
2786
2787         * DumpRenderTree/DumpRenderTree.mm:
2788         (dump):
2789
2790 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2791
2792         Reviewed by Geoff.
2793
2794         - Updated the leaks list for leopard to help identify regressions.
2795
2796         * Scripts/run-webkit-tests:
2797
2798 2007-09-12  Sam Weinig  <sam@webkit.org>
2799
2800         Rubber stamped by Darin.
2801
2802         Convert the LayoutTestController to use the JSCore API instead of WebScriptObject.
2803
2804         * DumpRenderTree/DumpRenderTree.h: Re-order variables.
2805         * DumpRenderTree/DumpRenderTree.m: Removed.
2806         * DumpRenderTree/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.m.
2807         (stopJavaScriptThreads): Fix initialization.
2808         (setDefaultColorProfileToRGB): Add explicit cast from void*.
2809         (dumpRenderTree): Ditto.
2810         (runTest):
2811         Used the WorkQueue from the windows DRT instead of the old NSMutableArray one.
2812
2813         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2814         * DumpRenderTree/FrameLoadDelegate.h: Add LayoutTestController instance variable.
2815         * DumpRenderTree/FrameLoadDelegate.m: Removed.
2816         * DumpRenderTree/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.m.
2817         (-[FrameLoadDelegate init]):
2818         (-[FrameLoadDelegate dealloc]):
2819         (-[FrameLoadDelegate processWork:]):
2820         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2821         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2822         Convert to use the new JSCore based LayoutTestController and the new WorkQueue.
2823
2824         * DumpRenderTree/LayoutTestController.cpp: Added.
2825         (LayoutTestController::LayoutTestController):
2826         (LayoutTestController::~LayoutTestController):
2827         (dumpAsTextCallback):
2828         (dumpBackForwardListCallback):
2829         (dumpChildFramesAsTextCallback):
2830         (dumpChildFrameScrollPositionsCallback):
2831         (dumpDOMAsWebArchiveCallback):
2832         (dumpEditingCallbacksCallback):
2833         (dumpFrameLoadCallbacksCallback):
2834         (dumpResourceLoadCallbacksCallback):
2835         (dumpSelectionRectCallback):
2836         (dumpSourceAsWebArchiveCallback):
2837         (dumpTitleChangesCallback):
2838         (repaintSweepHorizontallyCallback):
2839         (setCallCloseOnWebViewsCallback):
2840         (setCanOpenWindowsCallback):
2841         (setCloseRemainingWindowsWhenCompleteCallback):
2842         (testRepaintCallback):
2843         (addFileToPasteboardOnDragCallback):
2844         (addDisallowedURLCallback):
2845         (clearBackForwardListCallback):
2846         (decodeHostNameCallback):
2847         (displayCallback):
2848         (encodeHostNameCallback):
2849         (keepWebHistoryCallback):
2850         (notifyDoneCallback):
2851         (queueBackNavigationCallback):
2852         (queueForwardNavigationCallback):
2853         (queueLoadCallback):
2854         (queueReloadCallback):
2855         (queueScriptCallback):
2856         (setAcceptsEditingCallback):
2857         (setCustomPolicyDelegateCallback):
2858         (setMainFrameIsFirstResponderCallback):
2859         (setTabKeyCyclesThroughElementsCallback):
2860         (setUseDashboardCompatibilityModeCallback):
2861         (setUserStyleSheetEnabledCallback):
2862         (setUserStyleSheetLocationCallback):
2863         (setWindowIsKeyCallback):
2864         (waitUntilDoneCallback):
2865         (windowCountCallback):
2866         (LayoutTestController::makeWindowObject):
2867         (LayoutTestController::getLayoutTestControllerJSClass):
2868         (LayoutTestController::staticFunctions):
2869         * DumpRenderTree/LayoutTestController.h: Replaced.
2870         * DumpRenderTree/LayoutTestController.m: Removed.
2871         * DumpRenderTree/LayoutTestControllerMac.mm: Added.
2872         (LayoutTestController::dumpAsText):
2873         (LayoutTestController::dumpBackForwardList):
2874         (LayoutTestController::dumpChildFramesAsText):
2875         (LayoutTestController::dumpChildFrameScrollPositions):
2876         (LayoutTestController::dumpDOMAsWebArchive):
2877         (LayoutTestController::dumpEditingCallbacks):
2878         (LayoutTestController::dumpFrameLoadCallbacks):
2879         (LayoutTestController::dumpResourceLoadCallbacks):
2880         (LayoutTestController::dumpSelectionRect):
2881         (LayoutTestController::dumpSourceAsWebArchive):
2882         (LayoutTestController::dumpTitleChanges):
2883         (LayoutTestController::repaintSweepHorizontally):
2884         (LayoutTestController::setCallCloseOnWebViews):
2885         (LayoutTestController::setCanOpenWindows):
2886         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2887         (LayoutTestController::testRepaint):
2888         (LayoutTestController::addFileToPasteboardOnDrag):
2889         (LayoutTestController::addDisallowedURL):
2890         (LayoutTestController::clearBackForwardList):
2891         (LayoutTestController::decodeHostName):
2892         (LayoutTestController::encodeHostName):
2893         (LayoutTestController::display):
2894         (LayoutTestController::keepWebHistory):
2895         (LayoutTestController::notifyDone):
2896         (LayoutTestController::queueBackNavigation):
2897         (LayoutTestController::queueForwardNavigation):
2898         (LayoutTestController::queueLoad):
2899         (LayoutTestController::queueReload):
2900         (LayoutTestController::queueScript):
2901         (LayoutTestController::setAcceptsEditing):
2902         (LayoutTestController::setCustomPolicyDelegate):
2903         (LayoutTestController::setMainFrameIsFirstResponder):
2904         (LayoutTestController::setTabKeyCyclesThroughElements):
2905         (LayoutTestController::setUseDashboardCompatibilityMode):
2906         (LayoutTestController::setUserStyleSheetEnabled):
2907         (LayoutTestController::setUserStyleSheetLocation):
2908         (LayoutTestController::setWindowIsKey):
2909         (+[WaitToDumpWatchdog waitUntilDoneWatchdogFired]):
2910         (LayoutTestController::waitUntilDone):
2911         (LayoutTestController::windowCount):
2912         Use the JSCore API to implement the LayoutTestController.
2913
2914         * DumpRenderTree/ObjCController.h:
2915         * DumpRenderTree/ObjCController.m:
2916         (+[ObjCController isSelectorExcludedFromWebScript:]):
2917         (+[ObjCController webScriptNameForSelector:]):
2918         (-[ObjCController accessStoredWebScriptObject]):
2919         (-[ObjCController storeWebScriptObject:]):
2920         (-[ObjCController dealloc]):
2921         (-[ObjCController invokeUndefinedMethodFromWebScript:withArguments:]):
2922         Move WebScriptObject tests to ObjCController.
2923
2924         * DumpRenderTree/UIDelegate.m: Removed.
2925         * DumpRenderTree/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.m.
2926
2927         * DumpRenderTree/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2928         * DumpRenderTree/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2929         * DumpRenderTree/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2930         (WorkQueueItem::~WorkQueueItem):
2931         (LoadItem::LoadItem):
2932         (LoadItem::url):
2933         (LoadItem::target):
2934         (ScriptItem::ScriptItem):
2935         (ScriptItem::script):
2936         * DumpRenderTree/WorkQueueItemMac.mm: Added.
2937         (LoadItem::invoke):
2938         (ReloadItem::invoke):
2939         (ScriptItem::invoke):
2940         (BackForwardItem::invoke):
2941         Copy WorkQueue and WorkQueueItem from windows DRT. Changed the WorkQueueItem to use JSStringRefs instead of wstrings
2942         to avoid conversion until the last possible moment.  These changes will be merged with the windows DRT when we start
2943         sharing code.
2944
2945 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
2946
2947         Reviewed by Maciej.
2948
2949         - Updated Win side to take advantage of the platform separating changes.
2950
2951         * Drosera/DebuggerDocument.cpp:
2952         (DebuggerDocument::localScopeVariableNamesForCallFrame):
2953         * Drosera/DebuggerDocument.h:
2954         * Drosera/win/DebuggerClient.cpp:
2955         (DebuggerClient::pause):
2956         (DebuggerClient::resume):
2957         (DebuggerClient::stepInto):
2958         (DebuggerDocument::platformPause):
2959         (DebuggerDocument::platformResume):
2960         (DebuggerDocument::platformStepInto):
2961         (DebuggerDocument::platformEvaluateScript):
2962         (DebuggerDocument::getPlatformCurrentFunctionStack):
2963         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2964         (DebuggerDocument::platformValueForScopeVariableNamed):
2965         (DebuggerDocument::platformLog):
2966         * Drosera/win/DebuggerClient.h:
2967         * Drosera/win/Drosera.cpp:
2968         (Drosera::Drosera):
2969         (Drosera::windowScriptObjectAvailable):
2970         (Drosera::initWithServerName):
2971         (Drosera::switchToServerNamed):
2972         * Drosera/win/Drosera.h:
2973         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2974
2975 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
2976
2977         Reviewed by Adam.
2978
2979         - Just doing the moves in a separate patch so the changes are easier to see.
2980
2981         * Drosera/win/DebuggerClient.cpp: Copied from Drosera/win/DebuggerDocumentWin.cpp.
2982         * Drosera/win/DebuggerClient.h: Copied from Drosera/win/DebuggerDocumentWin.h.
2983         * Drosera/win/DebuggerDocumentWin.cpp: Removed.
2984         * Drosera/win/DebuggerDocumentWin.h: Removed.
2985         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2986
2987 2007-09-11  Sven Herzberg  <sven@imendio.com>
2988
2989         Don't overwrite LD_LIBRARY_PATH, prepend to it. Fixes:
2990         http://bugs.webkit.org/show_bug.cgi?id=15176
2991
2992         * Scripts/run-launcher: don't replace LD_LIBRARY_PATH with
2993         $projectDir, but prepend $projectDir to LD_LIBRARY_PATH (to preserve
2994         other paths eg. from jhbuild)
2995
2996 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
2997
2998         Reviewed by Adam.
2999
3000         - Made an order-of-deletion mistake.
3001
3002         * Drosera/DebuggerDocument.h:
3003         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
3004         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
3005         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
3006         * Drosera/mac/DebuggerClient.mm:
3007         (DebuggerDocument::platformPause):
3008         (DebuggerDocument::platformResume):
3009         (DebuggerDocument::platformStepInto):
3010         (DebuggerDocument::platformEvaluateScript):
3011         (DebuggerDocument::getPlatformCurrentFunctionStack):
3012         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3013         (DebuggerDocument::platformValueForScopeVariableNamed):
3014         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3015
3016 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
3017
3018         Reviewed by Darin.
3019
3020         - Renaming DebuggerDocument[platform] to DebuggerClient to be more clear.
3021
3022         * Drosera/DebuggerDocument.cpp:
3023         (DebuggerDocument::DebuggerDocument):
3024         * Drosera/DebuggerDocument.h:
3025         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
3026         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
3027         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
3028         * Drosera/mac/DebuggerApplication.mm:
3029         (-[DebuggerApplication attach:]):
3030         * Drosera/mac/DebuggerClient.h: Copied from Drosera/mac/DebuggerDocumentMac.h.
3031         * Drosera/mac/DebuggerClient.mm: Copied from Drosera/mac/DebuggerDocumentMac.mm.
3032         (DebuggerDocument::platformPause):
3033         (DebuggerDocument::platformResume):
3034         (DebuggerDocument::platformStepInto):
3035         (DebuggerDocument::platformEvaluateScript):
3036         (DebuggerDocument::getPlatformCurrentFunctionStack):
3037         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3038         (DebuggerDocument::platformValueForScopeVariableNamed):
3039         (DebuggerDocument::platformLog):
3040         * Drosera/mac/DebuggerDocumentMac.h: Removed.
3041         * Drosera/mac/DebuggerDocumentMac.mm: Removed.
3042         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3043
3044 2007-09-09  Sam Weinig  <sam@webkit.org>
3045
3046         Reviewed by Mark Rowe.
3047
3048         Remove 'objC' prefix from methods now in the ObjCController.
3049
3050         * DumpRenderTree/ObjCController.m:
3051         (+[ObjCController isSelectorExcludedFromWebScript:]):
3052         (+[ObjCController webScriptNameForSelector:]):
3053         (-[ObjCController classNameOf:]):
3054         (-[ObjCController objectOfClass:]):
3055         (-[ObjCController identityIsEqual::]):
3056         (-[ObjCController longLongRoundTrip:]):
3057         (-[ObjCController unsignedLongLongRoundTrip:]):
3058
3059 2007-09-09  Sam Weinig  <sam@webkit.org>
3060
3061         Reviewed by Oliver.
3062
3063         Initial refactor of DumpRenderTree in preparation of making it more platform independent.
3064         - Move LayoutTestController into its own file.
3065         - Move Objective-C only functions on LayoutTestController into a new controller called the
3066           ObjCController.
3067
3068         * DumpRenderTree/DumpRenderTree.h:
3069         * DumpRenderTree/DumpRenderTree.m:
3070         (displayWebView):
3071         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3072         * DumpRenderTree/FrameLoadDelegate.m:
3073         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3074         * DumpRenderTree/LayoutTestController.h: Added.
3075         * DumpRenderTree/LayoutTestController.m: Added.
3076         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
3077         (+[LayoutTestController webScriptNameForSelector:]):
3078         (-[LayoutTestController clearBackForwardList]):
3079         (-[LayoutTestController setUseDashboardCompatibilityMode:]):
3080         (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]):
3081         (-[LayoutTestController setCustomPolicyDelegate:]):
3082         (-[LayoutTestController keepWebHistory]):
3083         (-[LayoutTestController setCallCloseOnWebViews:]):
3084         (-[LayoutTestController setCanOpenWindows]):
3085         (-[LayoutTestController waitUntilDone]):
3086         (-[LayoutTestController waitUntilDoneWatchdogFired]):
3087         (-[LayoutTestController notifyDone]):
3088         (-[LayoutTestController dumpAsText]):
3089         (-[LayoutTestController addFileToPasteboardOnDrag]):
3090         (-[LayoutTestController addDisallowedURL:]):
3091         (-[LayoutTestController setUserStyleSheetLocation:]):
3092         (-[LayoutTestController setUserStyleSheetEnabled:]):
3093         (-[LayoutTestController dumpDOMAsWebArchive]):
3094         (-[LayoutTestController dumpSourceAsWebArchive]):
3095         (-[LayoutTestController dumpSelectionRect]):
3096         (-[LayoutTestController dumpTitleChanges]):
3097         (-[LayoutTestController dumpBackForwardList]):
3098         (-[LayoutTestController windowCount]):
3099         (-[LayoutTestController dumpChildFrameScrollPositions]):
3100         (-[LayoutTestController dumpChildFramesAsText]):
3101         (-[LayoutTestController dumpEditingCallbacks]):
3102         (-[LayoutTestController dumpResourceLoadCallbacks]):
3103         (-[LayoutTestController dumpFrameLoadCallbacks]):
3104         (-[LayoutTestController setWindowIsKey:]):
3105         (-[LayoutTestController setMainFrameIsFirstResponder:]):
3106         (-[LayoutTestController display]):
3107         (-[LayoutTestController testRepaint]):
3108         (-[LayoutTestController repaintSweepHorizontally]):
3109         (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]):
3110         (-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]):
3111         (-[LayoutTestController _doLoad:target:]):
3112         (-[LayoutTestController _doBackOrForwardNavigation:]):
3113         (-[LayoutTestController queueBackNavigation:]):
3114         (-[LayoutTestController queueForwardNavigation:]):
3115         (-[LayoutTestController queueReload]):
3116         (-[LayoutTestController queueScript:]):
3117         (-[LayoutTestController queueLoad:target:]):
3118         (-[LayoutTestController setAcceptsEditing:]):
3119         (-[LayoutTestController setTabKeyCyclesThroughElements:]):
3120         (-[LayoutTestController storeWebScriptObject:]):
3121         (-[LayoutTestController accessStoredWebScriptObject]):
3122         (-[LayoutTestController dealloc]):
3123         (-[LayoutTestController decodeHostName:]):
3124         (-[LayoutTestController encodeHostName:]):
3125         * DumpRenderTree/ObjCController.h: Added.
3126         * DumpRenderTree/ObjCController.m: Added.
3127         (+[ObjCController isSelectorExcludedFromWebScript:]):
3128         (+[ObjCController webScriptNameForSelector:]):
3129         (-[ObjCController objCClassNameOf:]):
3130         (-[ObjCController objCObjectOfClass:]):
3131         (-[ObjCController objCIdentityIsEqual::]):
3132         (-[ObjCController objCLongLongRoundTrip:]):
3133         (-[ObjCController objCUnsignedLongLongRoundTrip:]):
3134         (-[ObjCController testWrapperRoundTripping:]):
3135
3136 2007-09-07  Sam Weinig  <sam@webkit.org>
3137
3138         Reviewed by Alice.
3139
3140         Strip trailing and leading space/newline characters from skiplist file names.
3141
3142         * Scripts/run-webkit-tests:
3143
3144 2007-09-06  Kevin McCullough  <kmccullough@apple.com>
3145
3146         Reviewed by Maciej.
3147
3148         - Changed Drosera to take advantage of the JSRetainPtr changes.
3149
3150         * Drosera/DebuggerDocument.cpp:
3151         (DebuggerDocument::breakpointEditorHTML):
3152         (DebuggerDocument::evaluateScript):
3153         (DebuggerDocument::valueForScopeVariableNamed):
3154         (DebuggerDocument::log):
3155         (DebuggerDocument::windowScriptObjectAvailable):
3156         (DebuggerDocument::toJSArray):
3157         (DebuggerDocument::callFunctionOnObject):
3158         (DebuggerDocument::logException):
3159         * Drosera/mac/DebuggerDocumentMac.mm:
3160         (-[DebuggerClientMac webView:didLoadMainResourceForDataSource:]):
3161         (-[DebuggerClientMac webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3162         (DebuggerDocument::platformEvaluateScript):
3163         (DebuggerDocument::getPlatformCurrentFunctionStack):
3164         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3165         (DebuggerDocument::platformValueForScopeVariableNamed):
3166
3167 2007-09-05  Kevin McCullough  <kmccullough@apple.com>
3168
3169         Reviewed by Adam, Sam, Darin.
3170
3171         - Separated what is platform dependant from what is not.  Creating the structure needed for Drosera for Win.
3172
3173         * Drosera/Debugger.h: Added.
3174         * Drosera/DebuggerDocument.cpp:
3175         (DebuggerDocument::breakpointEditorHTMLCallback):
3176         (DebuggerDocument::isPausedCallback):
3177         (DebuggerDocument::pauseCallback):
3178         (DebuggerDocument::resumeCallback):
3179         (DebuggerDocument::stepIntoCallback):
3180         (DebuggerDocument::evaluateScriptCallback):
3181         (DebuggerDocument::currentFunctionStackCallback):
3182         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3183         (DebuggerDocument::valueForScopeVariableNamedCallback):
3184         (DebuggerDocument::logCallback):
3185         (DebuggerDocument::breakpointEditorHTML):
3186         (DebuggerDocument::isPaused):
3187         (DebuggerDocument::pause):
3188         (DebuggerDocument::resume):
3189         (DebuggerDocument::stepInto):
3190         (DebuggerDocument::evaluateScript):
3191         (DebuggerDocument::currentFunctionStack):
3192         (DebuggerDocument::localScopeVariableNamesForCallFrame):
3193         (DebuggerDocument::valueForScopeVariableNamed):
3194         (DebuggerDocument::log):
3195         (DebuggerDocument::toolbarPause):
3196         (DebuggerDocument::toolbarResume):
3197         (DebuggerDocument::toolbarStepInto):
3198         (DebuggerDocument::toolbarStepOver):
3199         (DebuggerDocument::toolbarStepOut):
3200         (DebuggerDocument::toolbarShowConsole):
3201         (DebuggerDocument::toolbarCloseCurrentFile):
3202         (DebuggerDocument::updateFileSource):
3203         (DebuggerDocument::didParseScript):
3204         (DebuggerDocument::willExecuteStatement):
3205         (DebuggerDocument::didEnterCallFrame):
3206         (DebuggerDocument::willLeaveCallFrame):
3207         (DebuggerDocument::exceptionWasRaised):
3208         (DebuggerDocument::windowScriptObjectAvailable):
3209         (DebuggerDocument::toJSArray):
3210         (DebuggerDocument::callGlobalFunction):
3211         (DebuggerDocument::callFunctionOnObject):
3212         (DebuggerDocument::getDroseraJSClass):
3213         (DebuggerDocument::staticFunctions):
3214         (DebuggerDocument::logException):
3215         * Drosera/DebuggerDocument.h:
3216         (DebuggerDocument::DebuggerDocument):
3217         * Drosera/ForwardingHeaders: Added.
3218         * Drosera/ForwardingHeaders/wtf: Added.
3219         * Drosera/ForwardingHeaders/wtf/Platform.h: Added.
3220         * Drosera/config.h:
3221         * Drosera/console.html:
3222         * Drosera/console.js:
3223         * Drosera/debugger.js:
3224         * Drosera/mac/DebuggerApplication.mm:
3225         (-[DebuggerApplication attach:]):
3226         * Drosera/mac/DebuggerDocumentMac.h:
3227         * Drosera/mac/DebuggerDocumentMac.mm:
3228         (+[NSString stringOrNilFromWebScriptResult:]):
3229         (+[DebuggerClientMac log:]):
3230         (-[DebuggerClientMac initWithServerName:]):
3231         (-[DebuggerClientMac dealloc]):
3232         (-[DebuggerClientMac pause]):
3233         (-[DebuggerClientMac resume]):
3234         (-[DebuggerClientMac pause:]):
3235         (-[DebuggerClientMac resume:]):
3236         (-[DebuggerClientMac stepInto:]):
3237         (-[DebuggerClientMac stepOver:]):
3238         (-[DebuggerClientMac stepOut:]):
3239         (-[DebuggerClientMac showConsole:]):
3240         (-[DebuggerClientMac closeCurrentFile:]):
3241         (-[DebuggerClientMac validateUserInterfaceItem:]):
3242         (-[DebuggerClientMac webView:windowScriptObjectAvailable:]):
3243         (-[DebuggerClientMac webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3244         (-[DebuggerClientMac webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3245         (-[DebuggerClientMac webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3246         (-[DebuggerClientMac webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3247         (DebuggerDocument::platformPause):
3248         (DebuggerDocument::platformResume):
3249         (DebuggerDocument::platformStepInto):
3250         (DebuggerDocument::platformEvaluateScript):
3251         (DebuggerDocument::platformCurrentFunctionStack):
3252         (DebuggerDocument::platformLocalScopeVariableNamesForCallFrame):
3253         (DebuggerDocument::platformValueForScopeVariableNamed):
3254         (DebuggerDocument::platformLog):
3255         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3256
3257 2007-09-06  Sam Weinig  <sam@webkit.org>
3258
3259         Reviewed by Adam Roben.
3260
3261         Register the WebKit DLL on initialization of the DumpRenderTree.
3262
3263         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3264         (initialize):
3265
3266 2007-09-05  Sam Weinig  <sam@webkit.org>
3267
3268         Reviewed by Oliver.
3269
3270         Fix many layout test failures caused by r25364.
3271         Set text size to standand size at the begining of each test matching the mac.
3272
3273         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3274         (runTest):
3275
3276 2007-09-04  Sam Weinig  <sam@webkit.org>
3277
3278         Reviewed by Adam.
3279
3280         Fix for <rdar://problem/5382277>
3281         Implement eventSender.textZoomIn and eventSender.textZoomOut for windows DRT.
3282
3283         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp:
3284         (textZoomInCallback):
3285         (textZoomOutCallback):
3286
3287 2007-08-29  David Kilzer  <ddkilzer@apple.com>
3288
3289         Reviewed by Adam.
3290
3291         Added case-insensitivity to checks for adding regression tests.
3292
3293         * Scripts/prepare-ChangeLog:
3294         (generateFileList):
3295
3296 2007-08-28  David Kilzer  <ddkilzer@apple.com>
3297
3298         Reviewed by Maciej.
3299
3300         Ignore files in /resources/ subdirectories when creating a list of added tests.
3301
3302         * Scripts/prepare-ChangeLog:
3303         (generateFileList):
3304
3305 2007-08-27  Kevin McCullough  <kmccullough@apple.com>
3306
3307         Reviewed by John.
3308
3309         - Removed Leopard leaks list since all of those radars were fixed.
3310
3311         * Scripts/run-webkit-tests:
3312
3313 2007-08-27  Adam Roben  <aroben@apple.com>
3314
3315         Rubberstamped by Mark.
3316
3317         * Scripts/pdevenv: Pass arguments along to devenv.com.
3318
3319 2007-08-26  David Kilzer  <ddkilzer@webkit.org>
3320
3321         Reviewed by Mark Rowe.
3322
3323         Update prepare-ChangeLog to generate the datestamp in the correct timezone.
3324
3325         * Scripts/prepare-ChangeLog:
3326         (changeLogDate): Added.
3327
3328 2007-08-24  Sam Weinig  <sam@webkit.org>
3329
3330         Revert r25216 which renamed the COM DOM bindings to use Deprecated prefix.
3331
3332 2007-08-24  Sam Weinig  <sam@webkit.org>
3333
3334         Rubber-stamped by Adam Roben.
3335
3336         <rdar://problem/5434593> Deprecate current manually written COM DOM bindings in anticipation of autogeneration
3337
3338         Rename COM DOM bindings to use Deprecated prefix.
3339
3340         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3341         (dumpFramesAsText):
3342         (dump):
3343         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp:
3344         (dumpPath):
3345         (dump):
3346         (EditingDelegate::shouldBeginEditingInDOMRange):
3347         (EditingDelegate::shouldEndEditingInDOMRange):
3348         (EditingDelegate::shouldInsertNode):
3349         (EditingDelegate::shouldInsertText):
3350         (EditingDelegate::shouldDeleteDOMRange):
3351         (EditingDelegate::shouldChangeSelectedDOMRange):
3352         (EditingDelegate::shouldApplyStyle):
3353         (EditingDelegate::shouldChangeTypingStyle):
3354         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h:
3355
3356 2007-08-24  Oliver Hunt  <oliver@apple.com>
3357
3358         Reviewed by John H.
3359
3360         WebDataSource::response can legitimately have a null response, so we
3361         must check that case.
3362
3363         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
3364         (queueLoadCallback):
3365
3366 2007-08-23  Mitz Pettel  <mitz@webkit.org>
3367
3368         Reviewed by Darin and Adam.
3369
3370         - DumpRenderTree changes to allow testing for
3371           http://bugs.webkit.org/show_bug.cgi?id=11756
3372           REGRESSION: link targeting a frame in another window does not work
3373           <rdar://problem/5286420>
3374
3375         Use a frame group name for all WebViews created by DumpRenderTree to
3376         allow testing of cross-page frame lookup.
3377
3378         * DumpRenderTree/DumpRenderTree.m:
3379         (createWebView): Pass group name to -[WebView initWithFrame:frameName:groupName:].
3380         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3381         (main): Pass group name to WebView::initWithFrame(RECT, BSTR, BSTR).
3382
3383 2007-08-23  David Kilzer  <ddkilzer@webkit.org>
3384
3385         Reviewed by Adam.
3386
3387         Quote the $sslCertificate path in case it contains a space.
3388
3389         * Scripts/run-webkit-httpd:
3390         * Scripts/run-webkit-tests:
3391
3392 2007-08-22  Oliver Hunt  <oliver@apple.com>
3393
3394         Reviewed by John and Adam.
3395
3396         WebDataSource::response can legitimately have a null response, so we
3397         must check that case.
3398
3399         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3400         (dump):
3401
3402 2007-08-21  Kevin McCullough  <kmccullough@apple.com>
3403
3404         Reviewed by Geof.
3405
3406         - Changing the usage to be more clear.
3407
3408         * Scripts/run-testkjs:
3409
3410 2007-08-20  John Sullivan  <sullivan@apple.com>
3411
3412         Reviewed by Adam Roben
3413
3414         * DumpRenderTree/DumpRenderTree.m:
3415         (runTest):
3416         call new +[WebView _setUsesTestModeFocusRingColor:YES] so we get the same focus ring colors
3417         in layout tests on Tiger and Leopard
3418
3419 2007-08-20  Adam Roben  <aroben@apple.com>
3420
3421         Put LayoutTests after all other ChangeLogs in commit logs
3422
3423         We use "~" to sort LayoutTests after all the other ChangeLogs because
3424         "~" is the last ASCII character (other than "DEL").
3425
3426         Reviewed by Sam.
3427
3428         * Scripts/commit-log-editor:
3429
3430 2007-08-20  Adam Roben  <aroben@apple.com>
3431
3432         Detect that DRT crashed even if a crash dialog is running
3433
3434         On Windows, when DRT crashes a crash dialog commonly appears. The DRT
3435         process is still running at this point, so run-webkit-tests wouldn't
3436         detect that DRT had crashed. We now record the crash in our SIGPIPE
3437         handler so that we know if DRT crashed even if the crash dialog is up.
3438
3439         Reviewed by Sam.
3440
3441         * Scripts/run-webkit-tests:
3442         (sub catch_pipe): Set the crashed bit.
3443         (sub openDumpTool): Reset the crashed bit.
3444         (sub dumpToolDidCrash): Check the crashed bit.
3445
3446 2007-08-20  Adam Roben  <aroben@apple.com>
3447
3448         Fix Bug 15026: prepare-ChangeLog should list new tests in WebCore/ChangeLog
3449
3450         http://bugs.webkit.org/show_bug.cgi?id=15026
3451
3452         Reviewed by David Kilzer and Darin Adler.
3453
3454         * Scripts/prepare-ChangeLog:
3455         (sub isModifiedStatus): Split out from isModifiedOrAddedStatus.
3456         (sub isAddedStatus): Ditto.
3457         (sub testListForChangeLog): Added.
3458
3459 2007-08-19  Oleg Sukhodolsky  <son.two@gmail.com>
3460
3461         Reviewed by Mark.
3462
3463         -fixes http://bugs.webkit.org/show_bug.cgi?id=14632
3464
3465         * Scripts/webkitdirs.pm:
3466         qt and gtk ports now explicitly pass debug (or release) mode to qmake.
3467
3468 2007-08-17  Darin Adler  <darin@apple.com>
3469
3470         Reviewed by Oliver Hunt.
3471
3472         - don't look for Apple-style localizable strings in the GTK version of WebKit
3473
3474         * Scripts/extract-localizable-strings: Add a feature where you can pass in the
3475         name of subdirectories to skip.
3476         * Scripts/update-webkit-localizable-strings: Pass WebKit/gtk as a subdirectory
3477         to skip.
3478
3479 2007-08-17  Anders Carlsson  <andersca@apple.com>
3480
3481         Build fix.
3482
3483         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3484         (NPP_SetWindow):
3485
3486 2007-08-17  Anders Carlsson  <andersca@apple.com>
3487
3488         Reviewed by Dave Hyatt.
3489
3490         <rdar://problem/5379040>
3491         REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes
3492
3493         Add a way for the plug-in to dump the width and height when it gets its  NPP_SetWindow call.
3494
3495         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
3496         (pluginAllocate):
3497         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3498         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3499         (NPP_New):
3500         (NPP_SetWindow):
3501
3502 2007-08-16  Alice Liu  <alice.liu@apple.com>
3503
3504         Reviewed by Maciej.
3505
3506         Fix <rdar://problem/5360135> REGRESSION (Leopard only): editing/selection/5354455-1.html is causing subsequent tests to fail
3507
3508         * DumpRenderTree/DumpRenderTree.m:
3509         (createWebView):
3510         Create a DumpRenderTreeWindow instead of a NSWindow, now that a DumpRenderTreeWindow no longer poses as a NSWindow.
3511         (dumpRenderTree):
3512         Don't pose as a NSWindow, since when the spelling panel gets created, it creates an NSWindow which ends up creating a DumpRenderTreeWindow.
3513
3514 2007-08-16  Kevin McCullough  <kmccullough@apple.com>
3515
3516         Reviewed by Adam.
3517
3518         - Added tests for regressions in other components.  In this case we also need to add a skipped list for Tiger since this functionality didn't exist in 10.4.
3519
3520         * Scripts/run-webkit-tests:
3521
3522 2007-08-15  Timothy Hatcher  <timothy@apple.com>
3523
3524         Look for the new Xcode 3 preference key (PBXApplicationwideBuildSettings) for the global build locations.
3525         The value of PBXApplicationwideBuildSettings is a dictionary, so we have to pull the SYMROOT out of it.
3526
3527         Also pass xcodebuild OBJROOT with the same value as SYMROOT if we fallback to the default WebKitBuild,
3528         this prevents making "build" directories in each project folder.
3529
3530         * Scripts/webkitdirs.pm:
3531
3532 2007-08-14  Geoffrey Garen  <ggaren@apple.com>
3533
3534         Reviewed by Kevin Mccullough.
3535
3536         Removed special case that didn't belong. (It would allow a global
3537         initializer to sneak into production builds, which would cause a
3538         system-wide performance regression on Mac OS X.)
3539
3540         * Scripts/check-for-global-initializers:
3541
3542 2007-08-14  Justin Garcia  <justin.garcia@apple.com>
3543
3544         Reviewed by Tim.
3545
3546         <rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element
3547
3548         * DumpRenderTree/EditingDelegate.m:
3549         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Added, return YES