WebKitTools/ChangeLog

   1 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
   2
   3         Reviewed by Adam Roben.
   4
   5         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined.
   6
   7 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
   8
   9         Reviewed by David Kilzer.
  10
  11         The git config command was renamed to repo-config at some point. This
  12         change tries git config and then git repo-config if the first fails.
  13
  14         * Scripts/prepare-ChangeLog:
  15         (gitConfig):
  16
  17 2007-11-16  Dan Bernstein  <mitz@apple.com>
  18
  19         Reviewed by Darin Adler and Sam Weinig.
  20
  21         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
  22
  23         * DumpRenderTree/win/EventSender.cpp:
  24         (keyDownCallback): For characters that cannot be entered on the active
  25         keyboard layout, send a WM_CHAR message with the character along with
  26         a WM_KEYDOWN message with a virtual key code of 255.
  27
  28 2007-11-16  Mark Rowe  <mrowe@apple.com>
  29
  30         Reviewed by Tim Hatcher.
  31
  32         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
  33
  34         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
  35         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  36
  37 2007-11-15  Adam Roben  <aroben@apple.com>
  38
  39         Make run-safari actually work on Windows
  40
  41         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
  42         chdir call.
  43
  44 2007-11-14  Adam Roben  <aroben@apple.com>
  45
  46         Updates to Safari launching now that 3.0.4 is released
  47
  48         Reviewed by Sam.
  49
  50         * FindSafari/FindSafari.cpp:
  51         (getWebViewCLSID): Use version-independent ProgID.
  52         * Scripts/run-safari: Use run-webkit-nightly.cmd.
  53
  54 2007-11-14  Anders Carlsson  <andersca@apple.com>
  55
  56         Reviewed by Adam.
  57
  58         <rdar://problem/5309081>
  59         In DRT, "plugin.logDestroy = true" not working on Windows.
  60
  61         * DumpRenderTree/win/TestNetscapePlugin/main.c:
  62         (NPP_Destroy):
  63
  64 2007-11-14  Eric Seidel  <eric@webkit.org>
  65
  66         Reviewed by Sam.
  67
  68         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
  69
  70 2007-11-14  Anders Carlsson  <andersca@apple.com>
  71
  72         Reviewed by Adam.
  73
  74         <rdar://problem/5141186>
  75         window.layoutTestController.setWindowIsKey is not implemented in DRT.
  76
  77         Implement setWindowIsKey.
  78
  79         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  80         (LayoutTestController::setWindowIsKey):
  81
  82 2007-11-13  Sam Weinig  <sam@webkit.org>
  83
  84         Reviewed by Adam Roben.
  85
  86         Fix for <rdar://problem/5382579>
  87         http/tests/security/cross-frame-access-put.html reports large
  88         negative numbers for screenLeft and screenTop (Mac reports "0")
  89
  90         * DumpRenderTree/win/UIDelegate.cpp:
  91         (UIDelegate::UIDelegate): Initialize the RECT.
  92         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
  93         (UIDelegate::webViewFrame): ditto.
  94         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
  95
  96 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
  97
  98         Reviewed by Adam.
  99
 100         - Make Drosera show source, source URLs, and function stack on Windows,
 101         and some minor fixes.
 102
 103         * Drosera/DebuggerDocument.cpp: Force source to always update display.
 104         (DebuggerDocument::updateFileSource):
 105         * Drosera/debugger.js: Force source to always update display.
 106         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
 107         menu controls.
 108         (DebuggerClient::resume):
 109         (DebuggerClient::pause):
 110         (DebuggerClient::stepInto):
 111         (DebuggerClient::stepOver):
 112         (DebuggerClient::stepOut):
 113         (DebuggerClient::showConsole):
 114         (DebuggerClient::closeCurrentFile):
 115         * Drosera/win/DebuggerClient.h: Ditto.
 116         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
 117         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
 118         removed two bugs.  1) caller could be in a bad state when asked to
 119         assign into it. 2) BSTRs were not created correctly.
 120         (DebuggerDocument::getPlatformCurrentFunctionStack):
 121         * Drosera/win/Drosera.cpp: Hook up the menu controls.
 122         (droseraWndProc):
 123         (handleCommand):
 124         (Drosera::resume):
 125         (Drosera::pause):
 126         (Drosera::stepInto):
 127         (Drosera::stepOver):
 128         (Drosera::stepOut):
 129         (Drosera::showConsole):
 130         (Drosera::closeCurrentFile):
 131         * Drosera/win/Drosera.h: Hook up the menu controls.
 132         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
 133         functions, added a null check, and fixed another bug where caller could
 134         be in a bad state when asked to assign into it.
 135         (ServerConnection::didLoadMainResourceForDataSource):
 136         (ServerConnection::getCallerFrame):
 137         * Drosera/win/ServerConnection.h: Safety first.
 138
 139 2007-11-13  Dan Bernstein  <mitz@apple.com>
 140
 141         Reviewed by Darin Adler.
 142
 143         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
 144           DumpRenderTree --pixel-tests renders each test twice
 145
 146         * DumpRenderTree/mac/DumpRenderTree.mm:
 147         (dumpRenderTree): Removed the --paint option because the painting code
 148         is always exercised as a result of
 149         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
 150         calling -displayIfNeeded.
 151         (dump): Changed to always grab the image from the window since the view
 152         is always displayed.
 153         (runTest):
 154         (displayWebView):
 155         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
 156         because it always paints.
 157
 158 2007-11-12  Antti Koivisto  <antti@apple.com>
 159
 160         Reviewed by Adele.
 161
 162         Add support for http media tests
 163
 164         * Scripts/run-webkit-tests:
 165
 166 2007-11-12  Sam Weinig  <sam@webkit.org>
 167
 168         Reviewed by Adam Roben.
 169
 170         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
 171
 172         * DumpRenderTree/win/DumpRenderTree.cpp:
 173         (runTest):
 174         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 175         (LayoutTestController::setPrivateBrowsingEnabled):
 176
 177 2007-11-12  Adam Roben  <aroben@apple.com>
 178
 179         * Scripts/update-webkit-localizable-strings: Changed to only scan the
 180         mac and win subdirectories.
 181
 182 2007-11-11  Adam Roben  <aroben@apple.com>
 183
 184         Fix <rdar://5133816> keepWebHistory is not implemented
 185
 186         Fixes fast/history/clicked-link-is-visited.html.
 187
 188         Reviewed by Darin.
 189
 190         * DumpRenderTree/win/DumpRenderTree.cpp:
 191         (runTest): Clear the optionalSharedHistory.
 192         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 193         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
 194
 195 2007-11-10  Sam Weinig  <sam@webkit.org>
 196
 197         Reviewed by Tim Hatcher.
 198
 199         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript
 200         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions
 201         is turned on)
 202
 203         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
 204
 205         Added test: http/tests/security/cross-frame-access-private-browsing.html
 206
 207         * DumpRenderTree/LayoutTestController.cpp:
 208         (setPrivateBrowsingEnabledCallback):
 209         (LayoutTestController::staticFunctions):
 210         * DumpRenderTree/LayoutTestController.h:
 211         * DumpRenderTree/mac/DumpRenderTree.mm:
 212         (runTest): Default to private browsing disabled.
 213         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 214         (LayoutTestController::setPrivateBrowsingEnabled):
 215         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 216         (LayoutTestController::setPrivateBrowsingEnabled):
 217
 218 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
 219
 220         Reviewed by Adam.
 221
 222         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
 223         WebCore's!
 224
 225         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
 226         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
 227         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
 228         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
 229         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
 230         * Drosera/win/Drosera.cpp:
 231         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 232
 233 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
 234
 235         Reviewed by Sam.
 236
 237         - Use the new IWebFrame [local] function signature and get the shared
 238         server correctly.
 239
 240         * Drosera/win/DebuggerClient.cpp:
 241         (DebuggerClient::didFinishLoadForFrame):
 242         * Drosera/win/ServerConnection.cpp:
 243         (ServerConnection::attemptToCreateServerConnection):
 244
 245 2007-11-07  Dan Bernstein  <mitz@apple.com>
 246
 247         Reviewed by Darin Adler.
 248
 249         - add an option to run-webkit-tests to ignore pixel test failures where
 250           all pixels differ by no more than a specified threshold
 251
 252         * DumpRenderTree/mac/ImageDiff.m:
 253         (main):
 254         (compareImages):
 255         (computePercentageDifferent):
 256         * Scripts/run-webkit-tests:
 257
 258 2007-11-07  Simon Hausmann  <hausmann@kde.org>
 259
 260         Reviewed by Lars.
 261
 262         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
 263
 264         * DumpRenderTree/qt/DumpRenderTree.cpp:
 265
 266 2007-11-07  Simon Hausmann  <hausmann@kde.org>
 267
 268         Reviewed by Lars.
 269
 270         Reworked the QWebSettings API.
 271         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
 272
 273         * DumpRenderTree/qt/DumpRenderTree.cpp:
 274
 275 2007-11-07  Simon Hausmann  <hausmann@kde.org>
 276
 277         Reviewed by Lars.
 278
 279         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
 280
 281         * DumpRenderTree/qt/jsobjects.cpp:
 282
 283 2007-11-07  Simon Hausmann  <hausmann@kde.org>
 284
 285         Reviewed by Lars Knoll <lars@trolltech.com>.
 286
 287         Add a QWebPage::frameCreated() signal and fix DRT
 288
 289         The removal of createFrame in QWebPage broke the re-implementation
 290         in DumpRenderTree. Instead emit a frameCreated() signal and
 291         connect to it in DumpRenderTree.
 292
 293
 294         * DumpRenderTree/qt/DumpRenderTree.cpp:
 295         (WebCore::WebPage::WebPage):
 296         (WebCore::DumpRenderTree::dump):
 297         (WebCore::DumpRenderTree::connectFrame):
 298         * DumpRenderTree/qt/DumpRenderTree.h:
 299
 300 2007-11-07  Simon Hausmann  <hausmann@kde.org>
 301
 302         Reviewed by Lars Knoll <lars@trolltech.com>.
 303
 304         Moved all the event handlers from QWebFrame into QWebPage.
 305
 306         This cleans up the public API and allows us to remove the
 307         HackWebFrame hack in DumpRenderTree.
 308
 309
 310         * DumpRenderTree/qt/jsobjects.cpp:
 311         (EventSender::mouseDown):
 312         (EventSender::mouseUp):
 313         (EventSender::mouseMoveTo):
 314
 315 2007-11-07  Simon Hausmann  <hausmann@kde.org>
 316
 317         Reviewed by Mark.
 318
 319         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
 320         to prevent the default implementation from popping up messageboxes.
 321
 322         * DumpRenderTree/qt/DumpRenderTree.cpp:
 323         (WebCore::WebPage::javaScriptConfirm):
 324         (WebCore::WebPage::javaScriptPrompt):
 325
 326 2007-11-06  Eric Seidel  <eric@webkit.org>
 327
 328         * Scripts/build-testkjs: build fix... too many $$
 329
 330 2007-11-06  Eric Seidel  <eric@webkit.org>
 331
 332         Reviewed by Mark Rowe.
 333
 334         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
 335
 336 2007-11-05  Adam Roben  <aroben@apple.com>
 337
 338         Add support on Windows for WEBKIT_TESTFONTS
 339
 340         This environment variable lets you specify where the fonts to be used
 341         by DumpRenderTree reside. The Qt port is already using this, so I'm
 342         just following their lead.
 343
 344         Reviewed by Darin.
 345
 346         * DumpRenderTree/win/DumpRenderTree.cpp:
 347         (exePath): Refactored code out of initialize().
 348         (fontsPath): Returns either $WEBKIT_TESTFONTS or
 349         DumpRenderTree.resources.
 350         (initialize): Use the new fontsPath function.
 351         (main): Use the new exePath function.
 352         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
 353         variable to DRT, like Qt does.
 354
 355 2007-11-05  Mark Rowe  <mrowe@apple.com>
 356
 357         Rubber-stamped by Alp Toker.
 358
 359         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
 360
 361         * GtkLauncher/main.cpp:
 362         (goToURLBarText):
 363         (main):
 364
 365 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
 366
 367         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
 368         <http://bugs.webkit.org/show_bug.cgi?id=15830>
 369
 370         Reviewed by Timothy.
 371
 372         Restrict the range of nightly builds used by the bisect-builds script
 373         based on the version of Safari and the version of Mac OS X being used.
 374
 375         Mac OS X 10.4: Safari 2.0: r11976 or newer
 376         Mac OS X 10.4: Safari 3.0: r19992 or newer
 377
 378         Mac OS X 10.5: Safari 2.0: r19594 or newer
 379         Mac OS X 10.5: Safari 3.0: r25124 or newer
 380
 381         * Scripts/bisect-builds:
 382         (findMacOSXVersion): Added.
 383         (makeNightlyList): Added argument to provide version of Mac OS X.
 384         Restrict range of nightly builds based on Safari and Mac OS X versions.
 385
 386 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
 387
 388         Reviewed by Maciej.
 389
 390         - This patch involves several changes, all of them were noticed that
 391         they were needed by the work being done in WebKit to get Drosera and
 392         WebKit working together on Windows.
 393         - The changes are:
 394         1) Added a debugger console for output messages.
 395         2) Drosera now listens for the WebKit server (before, the server would
 396         have to be running before Drosera was started.)
 397         3) Fixed a bug where the WebView started out as 0x0 pixels.
 398         4) Fixed a bug when there is no scope.
 399         5) Added the HTML, JS, and CSS to the project file to make them easy to
 400         find.
 401         6) Made the ServerConnection functions virtual.
 402
 403         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
 404         for the WebKit server.
 405         (DebuggerClient::DebuggerClient):
 406         (DebuggerClient::~DebuggerClient):
 407         (DebuggerClient::didFinishLoadForFrame):
 408         (DebuggerClient::serverConnected):
 409         (DebuggerClient::attemptToCreateServerConnection):
 410         * Drosera/win/DebuggerClient.h: Ditto.
 411         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
 412         scope.
 413         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 414         (DebuggerDocument::platformValueForScopeVariableNamed):
 415         * Drosera/win/Drosera.cpp:
 416         (_tWinMain): Added a console in debug for output messages.
 417         (Drosera::Drosera): Listen for server.
 418         (Drosera::initUI): The server now Initializes COM.
 419         (Drosera::serverConnected): Part of the listening for the server.
 420         (Drosera::attemptToCreateServerConnection): Ditto.
 421         * Drosera/win/Drosera.h: New interface for listening for the server.
 422         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
 423         files to the VS project.
 424         * Drosera/win/ServerConnection.cpp: Part of listening for the server
 425         connection.
 426         (ServerConnection::ServerConnection):
 427         (ServerConnection::attemptToCreateServerConnection):
 428         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
 429         methods.
 430         (ServerConnection::serverConnected):
 431
 432 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
 433
 434         Reviewed by Maciej.
 435
 436         http://bugs.webkit.org/show_bug.cgi?id=15832
 437         fast/dom/gc-10.html crashes when run alone
 438
 439         Check for !done before using objects that can be already deallocated.
 440
 441         * DumpRenderTree/mac/EditingDelegate.mm:
 442         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
 443         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
 444         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
 445         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
 446         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
 447         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
 448         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
 449         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
 450         (-[EditingDelegate webViewDidBeginEditing:]):
 451         (-[EditingDelegate webViewDidChange:]):
 452         (-[EditingDelegate webViewDidEndEditing:]):
 453         (-[EditingDelegate webViewDidChangeTypingStyle:]):
 454         (-[EditingDelegate webViewDidChangeSelection:]):
 455         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 456         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
 457         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
 458         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
 459         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
 460         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
 461         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
 462         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
 463         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
 464         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
 465         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
 466         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
 467         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
 468         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
 469         (-[FrameLoadDelegate webView:willCloseFrame:]):
 470         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
 471         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
 472         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
 473         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
 474         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
 475         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
 476         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
 477         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
 478         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
 479
 480 2007-11-04  Mark Rowe  <mrowe@apple.com>
 481
 482         Build fix.  Don't use Carbon.h as the prefix header as it triggers
 483         warnings that would otherwise be suppressed due to it being a system header.
 484
 485         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 486
 487 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
 488
 489         Rubber stamped by Adam.
 490
 491         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
 492
 493         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 494
 495 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
 496
 497         Sort files(...); sections of Xcode project files.
 498
 499         Rubber-stamped by Darin.
 500
 501         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
 502         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
 503         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 504         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
 505
 506 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
 507
 508         Script to sort "files(...);" sections in Xcode project.pbxproj files.
 509
 510         Reviewed by Darin.
 511
 512         * Scripts/sort-Xcode-project-file: Added.
 513
 514 2007-11-02  Darin Adler  <darin@apple.com>
 515
 516         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
 517
 518 2007-11-02  Darin Adler  <darin@apple.com>
 519
 520         Reviewed by Maciej.
 521
 522         * Scripts/run-sunspider: Pass the "--base" option through.
 523
 524         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
 525         the real script do that. Default configuration to Release to match run-sunspider
 526         so we don't end up building Debug just to compare results.
 527
 528 2007-11-01  Adam Roben  <aroben@apple.com>
 529
 530         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
 531
 532         Reviewed by Sam.
 533
 534         * Scripts/commit-log-editor: Show all the directories beneath the
 535         source root, instead of just the last one.
 536
 537 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
 538
 539         Reviewed by Adam Roben.
 540
 541         Print out an error message when the Windows build fails
 542         and provide guidance on how to find out what went wrong.
 543
 544         * Scripts/build-webkit:
 545         * Scripts/webkitdirs.pm:
 546
 547 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
 548
 549         Rubber-stamped by Adam Roben.
 550
 551         Rolled out r27326 - debug CRT seems to cause no problems after all.
 552
 553         * DumpRenderTree/win/DumpRenderTree.vcproj:
 554
 555 2007-10-31  Adam Roben  <aroben@apple.com>
 556
 557         Switch the Debug configuration to using the non-debug CRT
 558
 559         This matches WebKit.
 560
 561         Reviewed by Steve.
 562
 563         * DumpRenderTree/win/DumpRenderTree.vcproj:
 564
 565 2007-10-31  Antti Koivisto  <antti@apple.com>
 566
 567         Reviewed by bdash.
 568
 569         Disable media tests when doing leak checking on Tiger.
 570         They crash in QuickTime (rdar://problem/5537157).
 571
 572         * Scripts/run-webkit-tests:
 573
 574 2007-10-29  Antti Koivisto  <antti@apple.com>
 575
 576         Reviewed by Maciej.
 577
 578         Build media support by default on OSX only.
 579
 580         * Scripts/build-webkit:
 581
 582 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
 583
 584         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
 585         get caught by the pre-commit hooks.
 586
 587 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
 588
 589         Reviewed by Adam.
 590
 591         - This is a collection of relatively unrelated changes and cleanups
 592         to Drosera to prepare it for interacting with WebKit.  A lot of these
 593         changes are just correcting mistakes, for example removing included
 594         headers that are no longer needed.
 595
 596         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
 597         this will be needed by the DebuggerClient.
 598         (DebuggerDocument::server):
 599         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
 600         * Drosera/win/DebuggerClient.cpp:
 601         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
 602         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
 603         (DebuggerClient::createWebViewWithRequest): Added comment about its
 604         purpose.
 605         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
 606         declarations.
 607         (DebuggerClient::webViewLoaded): Moved.
 608         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
 609         file, since this was the only place it was used.
 610         (cfStringToBSTR):
 611         * Drosera/win/Drosera.h: Cleaned up the includes.
 612         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
 613         * Drosera/win/HelperFunctions.h: Removed.
 614
 615 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
 616
 617         Reviewed by Adam.
 618
 619         - Small cleanup in the ServerConnection class.
 620
 621         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
 622         and added an include.
 623         (ServerConnection::currentFrame):
 624         (ServerConnection::getCallerFrame):
 625         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
 626         made a pointer into a COMPtr, and cleaned up the includes.
 627
 628 2007-10-29  Timothy Hatcher  <timothy@apple.com>
 629
 630         Reviewed by John Sullivan.
 631
 632         - Place the Localizable.strings file in mac or win directories
 633           if that location exists.
 634         - Also look for UI_STRING in .c files.
 635
 636         * Scripts/extract-localizable-strings:
 637
 638 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
 639
 640         Reviewed by Adam.
 641
 642         - Set the eol-style to native and made all the line endings the same
 643         so that I avoid messy diffs that show eol changes.
 644
 645         * Drosera/win/ServerConnection.cpp:
 646         (ServerConnection::didParseSource):
 647         (ServerConnection::didEnterCallFrame):
 648         (ServerConnection::willExecuteStatement):
 649         (ServerConnection::willLeaveCallFrame):
 650         (ServerConnection::exceptionWasRaised):
 651
 652 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
 653
 654         Reviewed by Adam.
 655
 656         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
 657         functionality that could not have existed previously without the new
 658         interfaces.
 659         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
 660         from a BSTR to a JSValueRef.
 661         (DebuggerDocument::platformEvaluateScript): Implemented.
 662         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
 663         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 664         Implemented.
 665         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
 666         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
 667         * Drosera/win/ServerConnection.cpp: Added a helper function.
 668         (ServerConnection::getCallerFrame):
 669         * Drosera/win/ServerConnection.h: Added a helper function.
 670
 671 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
 672
 673         updated reviewers for my previous changelog.
 674
 675 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
 676         Reviewed by Maciej and Adam and Geoff.
 677
 678         - Minor mac-side improvements including moving a function to a more
 679         appropriate location, fixing a warning, and correctly checking
 680         exceptions.
 681
 682         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
 683         (DebuggerDocument::willExecuteStatement):
 684         (DebuggerDocument::didEnterCallFrame):
 685         (DebuggerDocument::willLeaveCallFrame):
 686         (DebuggerDocument::windowScriptObjectAvailable):
 687         (DebuggerDocument::callFunctionOnObject):
 688         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
 689         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
 690         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
 691         because it doesn't require the ServerConnection at all.
 692         (NSStringCreateWithJSStringRef): Made an argument const.
 693         (JSValueRefCreateWithNSString): Made an argument const.
 694         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
 695         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 696         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
 697         * Drosera/mac/ServerConnection.mm: Ditto.
 698         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
 699
 700 2007-10-29  Sam Weinig  <sam@webkit.org>
 701
 702         Reviewed by Adam Roben.
 703
 704         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
 705
 706         * DumpRenderTree/LayoutTestController.cpp:
 707         (LayoutTestController::LayoutTestController):
 708         (getGlobalFlagCallback):
 709         (setGlobalFlagCallback):
 710         (LayoutTestController::getJSClass):
 711         (LayoutTestController::staticValues):
 712         * DumpRenderTree/LayoutTestController.h:
 713         (LayoutTestController::globalFlag):
 714         (LayoutTestController::setGlobalFlag):
 715
 716 2007-10-29  Darin Adler  <darin@apple.com>
 717
 718         Reviewed by Maciej.
 719
 720         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
 721         resolution instead of its default.
 722
 723 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
 724
 725         Fixed showStatus() to print status for successfully resolved conflicts when using git.
 726
 727         Reviewed by Mark Rowe.
 728
 729         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
 730         was successfully resolved, but this would not show any status because the change had
 731         already been cached in the index using "git add".  The solution is to add an optional
 732         second argument to showStatus() which adds the "--cached" switch to the command.
 733
 734         * Scripts/resolve-ChangeLogs:
 735         (showStatus):
 736
 737 2007-10-28  Eric Seidel  <eric@webkit.org>
 738
 739         Reviewed by Maciej and Geoff, in unison.
 740
 741         * Scripts/run-webkit-tests: remove broken --svg option
 742
 743 2007-10-28  Darin Adler  <darin@apple.com>
 744
 745         Reviewed by Adam.
 746
 747         * Scripts/run-sunspider: Default to "Release" configuration rather than
 748         defaulting to the last configuration used as other scripts do. This can
 749         still be overriden on the command line with "--debug" if there's some
 750         reason to do so. Also fix a typo.
 751
 752         * Scripts/sunspider-compare-results: Fix a typo.
 753
 754 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
 755
 756         Reviewed by Adam.
 757
 758         - Implemented the WebScriptDebugListener functions now that the
 759         WebScriptDebugServer exists
 760
 761         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
 762         functions.
 763         (ServerConnection::currentFrame):
 764         (ServerConnection::didLoadMainResourceForDataSource):
 765         (ServerConnection::didParseSource):
 766         (ServerConnection::failedToParseSource):
 767         (ServerConnection::didEnterCallFrame):
 768         (ServerConnection::willExecuteStatement):
 769         (ServerConnection::willLeaveCallFrame):
 770         (ServerConnection::exceptionWasRaised):
 771         * Drosera/win/ServerConnection.h: Removed unused arguments from the
 772         members arguments list.
 773
 774 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
 775
 776         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
 777         <http://bugs.webkit.org/show_bug.cgi?id=15600>
 778
 779         Reviewed by Darin.
 780
 781         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
 782         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
 783         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
 784         file.  Note that it may also be used as a stand-alone script.
 785
 786         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
 787         * Scripts/resolve-ChangeLogs: Added.
 788         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
 789
 790 2007-10-26  Mark Rowe  <mrowe@apple.com>
 791
 792         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
 793         to the Qt port on the assumption that it was an implementation of the cross-platform
 794         LayoutTestController class.  It is not, so it did not need to be changed.
 795
 796         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
 797
 798 2007-10-25  Mark Rowe  <mrowe@apple.com>
 799
 800         Reviewed by Maciej.
 801
 802         Fix builds with code coverage enabled.
 803
 804         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
 805
 806 2007-10-25  Darin Adler  <darin@apple.com>
 807
 808         Reviewed by Mark Rowe.
 809
 810         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
 811         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
 812
 813 2007-10-25  Stephanie  <slewis@apple.com>
 814
 815         build Fix
 816
 817         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 818
 819 2007-10-25  Stephanie  <slewis@apple.com>
 820
 821         Reviewed by Mark Rowe, Adam Roben.
 822
 823         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
 824
 825         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 826
 827 2007-10-25  Alice Liu  <alice.liu@apple.com>
 828
 829         Reviewed by Adam.
 830
 831         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
 832
 833         Moving destructor into platform-specific files
 834         * DumpRenderTree/LayoutTestController.cpp:
 835         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 836         (LayoutTestController::~LayoutTestController):
 837         * DumpRenderTree/qt/jsobjects.cpp:
 838         (LayoutTestController::~LayoutTestController):
 839
 840         LayoutTestController wasn't being destroyed
 841         * DumpRenderTree/win/DumpRenderTree.cpp:
 842         (runTest):
 843
 844         Added declspec
 845         * DumpRenderTree/win/EditingDelegate.h:
 846
 847         Reset certain values on the webview (or related delegate) that might
 848         have changed while running a test
 849         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 850         (LayoutTestController::~LayoutTestController):
 851
 852 2007-10-25  Adam Roben  <aroben@apple.com>
 853
 854         Make sunspider-compare-results work with relative paths
 855
 856         Reviewed by Sam.
 857
 858         * Scripts/sunspider-compare-results: Convert arguments to absolute
 859         paths before we chdir.
 860
 861 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
 862
 863         Reviewed by Sam.
 864
 865         - Implemented server calls now the WebScriptDebugServer exists.
 866         - Also removed no longer needed call to initialize CG.
 867
 868         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
 869         automatically now.
 870         (_tWinMain):
 871         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
 872         (ServerConnection::ServerConnection):
 873         (ServerConnection::~ServerConnection):
 874         (ServerConnection::pause):
 875         (ServerConnection::resume):
 876         (ServerConnection::stepInto):
 877         (ServerConnection::applicationTerminating):
 878         (ServerConnection::serverConnectionDidDie):
 879         * Drosera/win/ServerConnection.h: Now uses the COM class.
 880
 881 2007-10-24  George Staikos  <staikos@kde.org>
 882
 883         Unbreak Qt build.
 884
 885         * Scripts/build-webkit:
 886
 887 2007-10-24  Adam Roben  <aroben@apple.com>
 888
 889         Remove now-unnecessary call to InitializeCoreGraphics
 890
 891         WebKit takes care of this now.
 892
 893         Reviewed by Ada.
 894
 895         * DumpRenderTree/win/DumpRenderTree.cpp:
 896         (initialize):
 897
 898 2007-10-24  Adam Roben  <aroben@apple.com>
 899
 900         Use WebTextRenderer in DRT
 901
 902         Reviewed by Ada.
 903
 904         * DumpRenderTree/win/DumpRenderTree.cpp:
 905         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
 906
 907 2007-10-24  Sven Herzberg  <sven@imendio.com>
 908
 909         Reviewed by Mark Rowe.
 910
 911         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
 912         Bug 15614: [GTK] qmake based backends don't build on OS X
 913
 914         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
 915         GTK backend on a Mac
 916         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
 917         isDarwin() to make it reusable in other places (like the workaround-
 918         for-prebuilt-qmake in build-webkit)
 919
 920 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
 921
 922         Refurbish update-webkit script.
 923
 924         Reviewed by Adam.
 925
 926         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
 927         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
 928         multi-argument version of system() for flexibility and security.  Check for existence
 929         of Internal directory using -d test instead of -x.
 930
 931 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
 932
 933         Minor clean-up of prepare-ChangeLog script.
 934
 935         Reviewed by Adam.
 936
 937         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
 938         of a string.  Use multi-argument versions of open() and system() for flexibility and
 939         security.
 940
 941 2007-10-24  Alice Liu  <alice.liu@apple.com>
 942
 943         Reviewed by Oliver.
 944
 945         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
 946
 947         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
 948         replay the saved events when we're still processing the mousedown that starts the drag
 949         * DumpRenderTree/win/EventSender.cpp:
 950         (doMouseMove):
 951         * DumpRenderTree/win/UIDelegate.cpp:
 952         (UIDelegate::doDragDrop):
 953
 954 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
 955
 956         Reviewed by Sam, Steve and Darin.
 957
 958         - Stubbed out the WebScriptDebugListener functionality in the Server
 959         Connection class to prepare it for receiving those callbacks.
 960         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
 961         and the ServerConnection to not need to be initialized with a server
 962         name, since that is not the way we connect to the WebKit server.
 963
 964         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
 965         no exception.  Now it only loggs when there is an exception
 966         (DebuggerDocument::willExecuteStatement):
 967         (DebuggerDocument::didEnterCallFrame):
 968         (DebuggerDocument::willLeaveCallFrame):
 969         (DebuggerDocument::windowScriptObjectAvailable):
 970         (DebuggerDocument::callFunctionOnObject):
 971         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
 972         to be instantiated with a server's name.
 973         (DebuggerClient::DebuggerClient):
 974         (DebuggerClient::didFinishLoadForFrame):
 975         * Drosera/win/DebuggerClient.h: Removed unsued variable.
 976         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
 977         a server name.
 978         (Drosera::init):
 979         (Drosera::initServer):
 980         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
 981         instantiated with a server's name.
 982         * Drosera/win/ServerConnection.cpp:
 983         (ServerConnection::ServerConnection): No longer needs a server name
 984         (ServerConnection::~ServerConnection): Only release the global context
 985         if there is one.
 986         (ServerConnection::serverConnectionDidDie): Stub for
 987         IWebScriptDebugListener
 988         (ServerConnection::QueryInterface): ditto
 989         (ServerConnection::AddRef): ditto
 990         (ServerConnection::Release): ditto
 991         (ServerConnection::didLoadMainResourceForDataSource): ditto
 992         (ServerConnection::didParseSource): ditto
 993         (ServerConnection::failedToParseSource): ditto
 994         (ServerConnection::didEnterCallFrame): ditto
 995         (ServerConnection::willExecuteStatement): ditto
 996         (ServerConnection::willLeaveCallFrame): ditto
 997         (ServerConnection::exceptionWasRaised): ditto
 998         * Drosera/win/ServerConnection.h: Stubbed out the
 999         IWebScriptDebugListener functions, and this class no longer needs to be
1000         instantiated with a server name.
1001
1002 2007-10-24  Lars Knoll  <lars@trolltech.com>
1003
1004         Reviewed by Simon.
1005
1006         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
1007
1008         * DumpRenderTree/qt/jsobjects.h:
1009
1010 2007-10-24  Lars Knoll  <lars@trolltech.com>
1011
1012         Reviewed by Simon.
1013
1014         add another command.
1015
1016         * DumpRenderTree/qt/jsobjects.cpp:
1017         (TextInputController::doCommand):
1018
1019 2007-10-24  Lars Knoll  <lars@trolltech.com>
1020
1021         Reviewed by Simon.
1022
1023         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
1024
1025         * DumpRenderTree/qt/jsobjects.cpp:
1026         (EventSender::keyDown):
1027         * DumpRenderTree/qt/jsobjects.h:
1028
1029 2007-10-24  Lars Knoll  <lars@trolltech.com>
1030
1031         Reviewed by Simon.
1032
1033         implement eventSender.keyDown().
1034
1035         * DumpRenderTree/qt/jsobjects.cpp:
1036         (EventSender::keyDown):
1037
1038 2007-10-24  Lars Knoll  <lars@trolltech.com>
1039
1040         Reviewed by Simon.
1041
1042         some smaller fixes to the editing support in DRT. Makes another few tests pass.
1043
1044         * DumpRenderTree/qt/DumpRenderTree.cpp:
1045         (WebCore::DumpRenderTree::DumpRenderTree):
1046         (WebCore::DumpRenderTree::initJSObjects):
1047         * DumpRenderTree/qt/jsobjects.cpp:
1048         (TextInputController::doCommand):
1049
1050 2007-10-24  Lars Knoll  <lars@trolltech.com>
1051
1052         Reviewed by Simon.
1053
1054         first bit of implementation for the textinputcontroller.
1055
1056         * DumpRenderTree/qt/DumpRenderTree.cpp:
1057         (WebCore::DumpRenderTree::DumpRenderTree):
1058         * DumpRenderTree/qt/DumpRenderTree.h:
1059         * DumpRenderTree/qt/jsobjects.cpp:
1060         (TextInputController::TextInputController):
1061         (TextInputController::doCommand):
1062         * DumpRenderTree/qt/jsobjects.h:
1063
1064 2007-10-24  Lars Knoll  <lars@trolltech.com>
1065
1066         Reviewed by Simon.
1067
1068         make the man webpage believe it has focus, so the editing tests work correctly.
1069
1070         * DumpRenderTree/qt/DumpRenderTree.cpp:
1071         (WebCore::DumpRenderTree::DumpRenderTree):
1072
1073 2007-10-24  Lars Knoll  <lars@trolltech.com>
1074
1075         Reviewed by Simon.
1076
1077         implement layoutTestController.dumpEditingCallbacks() correctly.
1078
1079         * DumpRenderTree/qt/DumpRenderTree.cpp:
1080         (WebCore::DumpRenderTree::DumpRenderTree):
1081         * DumpRenderTree/qt/jsobjects.cpp:
1082         (LayoutTestController::reset):
1083         (LayoutTestController::dumpEditingCallbacks):
1084
1085 2007-10-24  Lars Knoll  <lars@trolltech.com>
1086
1087         Reviewed by Simon.
1088
1089         Implement support for testing editing.
1090
1091         * DumpRenderTree/qt/DumpRenderTree.cpp:
1092         (WebCore::DumpRenderTree::DumpRenderTree):
1093
1094 2007-10-23  Sam Weinig  <sam@webkit.org>
1095
1096         Check for null BSTR that can be passed to the UIDelegate methods
1097         from javascript null and undefined.  Fixes a failing test case on
1098         Windows (fast/dom/Window/alert-undefined.html)
1099
1100         Reviewed by Eric Seidel.
1101
1102         * DumpRenderTree/win/UIDelegate.cpp:
1103         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1104         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1105         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1106         (UIDelegate::webViewAddMessageToConsole):
1107
1108 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1109
1110         Reviewed by Darin.
1111
1112         Don't print a massive pile of setenvs from tools that automatically build testkjs.
1113
1114         * Scripts/build-testkjs:
1115
1116 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1117
1118         Reviewed by Darin.
1119
1120         - add wrapper that finds the right copy of testkjs
1121
1122         * Scripts/sunspider-compare-results: Added.
1123
1124 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
1125
1126         Reviewed by Sam.
1127
1128         - After talking with Steve I now see that the WebKit server must be
1129         running for DCOM to create the distributed objects, which makes sense
1130         and currently WebKit only allows one instance to be running at a time
1131         which avoids accidentally connecting to the wrong server
1132         - In light of this I have removed the code for the attach box and
1133         NotificationServer and known server names, since they are all extranious
1134         now.
1135
1136         * Drosera/win/Drosera.cpp: Removed notification classes and known server
1137         names.
1138         (_tWinMain): Uses init instead of initUI.
1139         (droseraWndProc): No longer creats an attach dialog box.
1140         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
1141         it's not manditory to call init before doing COM stuff.
1142         (Drosera::init): calls initUI and will call attach when the
1143         functionality exists.
1144         (Drosera::initUI): Has changed very little.
1145         (Drosera::attach): Changed the signature to reflect that we no longer
1146         need the dictionary of known server names.
1147         * Drosera/win/Drosera.h: Removed notification classes and known server
1148         names.  Also renamed and moved some functions.
1149         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
1150         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
1151         headers to the resources folder.
1152         * Drosera/win/resource.h: Removed the Attach box.
1153
1154 2007-10-22  Adam Roben  <aroben@apple.com>
1155
1156         Windows build fix
1157
1158         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
1159
1160 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
1161
1162         - Removed a leak that was fixed.
1163
1164         * Scripts/run-webkit-tests:
1165
1166 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1167
1168         Reviewed by Darin.
1169
1170         - Changed the Client so that the DebuggerDocument now own the
1171         ServerConnection.  This simplifies ownership and cleanup.
1172
1173         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
1174         ServerConnection.
1175         (DebuggerClient::initWithServerName):
1176         (DebuggerClient::didFinishLoadForFrame):
1177         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the
1178         ServerConnection.
1179         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
1180         until after we have a server which we are attached to.
1181         (Drosera::initUI):
1182         (Drosera::attach):
1183         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
1184         out previously.
1185
1186 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1187
1188         Reviewed by Nikolas.
1189
1190         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
1191
1192         * Scripts/run-javascriptcore-tests:
1193
1194 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1195
1196         Reviewed by Nikolas.
1197
1198         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
1199
1200         * Scripts/build-drosera:
1201         * Scripts/build-dumprendertree:
1202         * Scripts/build-testkjs:
1203         * Scripts/build-webkit:
1204         * Scripts/run-javascriptcore-tests:
1205         * Scripts/run-sunspider:
1206         * Scripts/run-webkit-tests:
1207         * Scripts/webkitdirs.pm:
1208
1209 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
1210
1211         Reviewed by Mark Rowe.
1212
1213         Fix for local database support after r26879
1214         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
1215
1216         * Scripts/build-webkit:
1217
1218 2007-10-22  Holger Freyther  <zecke@selfish.org>
1219
1220         Reviewed by Simon Hausmann <hausmann@kde.org>.
1221
1222         - Do not build testkjs as an application bundle. This is
1223         needed for run-javascriptcore-tests on OSX.
1224         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
1225         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
1226         as we do not have -rpath on OSX.
1227
1228         * DumpRenderTree/qt/DumpRenderTree.pro:
1229         * Scripts/run-webkit-tests:
1230
1231 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1232
1233         Reviewed by aroben.
1234
1235         Fix support for Signed-off-by detection in prepare-ChangeLog
1236         --git-commit. The Signed-off-by tag does not appear in the header
1237         but usually at the end.
1238
1239         * Scripts/prepare-ChangeLog:
1240
1241 2007-10-21  Mark Rowe  <mrowe@apple.com>
1242
1243         Reviewed by Eric.
1244
1245         Fix run-javascriptcore-tests for Gtk.
1246
1247         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
1248
1249 2007-10-20  Eric Seidel  <eric@webkit.org>
1250
1251         Reviewed by aroben.
1252
1253         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
1254
1255 2007-10-20  Eric Seidel  <eric@webkit.org>
1256
1257         Reviewed by darin.
1258
1259         Add improved argument handling to run-sunspider, including
1260         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
1261         Also re-factor code into subroutines
1262
1263         * Scripts/build-dumprendertree: removed bogus comments
1264         * Scripts/build-testkjs: Added.
1265         * Scripts/run-javascriptcore-tests: use build-testkjs
1266         * Scripts/run-sunspider: improved argument handling, abstraction
1267         * Scripts/run-webkit-tests: improved abstraction
1268
1269 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
1270
1271         Not reviewed, Windows build fix.
1272
1273         * DumpRenderTree/win/EventSender.cpp:
1274         (keyDownCallback):
1275
1276 2007-10-20  Darin Adler  <darin@apple.com>
1277
1278         Reviewed by Tim Hatcher.
1279
1280         - http://bugs.webkit.org/show_bug.cgi?id=15544
1281           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
1282           not rely on Apple-specific key codes
1283
1284         * DumpRenderTree/mac/EventSendingController.mm:
1285         (-[EventSendingController keyDown:withModifiers:]):
1286         Added named key "rightArrow". Later we could have a whole table of these.
1287         Also tweaked modifiers code a little.
1288
1289         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
1290
1291 2007-10-19  Darin Adler  <darin@apple.com>
1292
1293         Reviewed by Eric.
1294
1295         - http://bugs.webkit.org/show_bug.cgi?id=15566
1296           possible fix for leak seen in DumpRenderTree
1297
1298         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
1299         Delete the item if it's not put on the queue, since the caller has
1300         no way of knowing that. Would be better to have the parameter type
1301         be auto_ptr to express the fact that we take ownership.
1302
1303         - unrelated change
1304
1305         * Drosera/mac/main.m: Add missing include.
1306
1307 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1308
1309         Reviewed by Adam.
1310
1311         - This change should be identical but for some reason was not working
1312         on my machine.
1313
1314         * Scripts/prepare-ChangeLog:
1315
1316 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1317
1318         Reviewed by Oliver and Tim.
1319
1320         - Made use of RetainPtr to avoid retain and release issues and moved the
1321         log function to DebuggerDocumentPlatform, which seems to be a more
1322         logical place for it to live.
1323         - Also moved knownServers from the ServerConnection to
1324         DebuggerApplication to match the Windows code and because it makes sense
1325         that a connection knows its own server but not all of them.
1326
1327         * Drosera/mac/DebuggerClient.h: Moved the log function to
1328           DebuggerDocumentPlatform.
1329         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
1330           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
1331           call for the server name up from the ServerConnection class.
1332         (-[DebuggerClient dealloc]):
1333         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
1334           for the server name up from the ServerConnection.
1335         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
1336         (DebuggerDocument::platformPause):
1337         (DebuggerDocument::platformResume):
1338         (DebuggerDocument::platformStepInto):
1339         (DebuggerDocument::platformEvaluateScript):
1340         (DebuggerDocument::getPlatformCurrentFunctionStack):
1341         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1342         (DebuggerDocument::platformValueForScopeVariableNamed):
1343         (DebuggerDocument::platformLog): Log directly from here. No need to call
1344           DebuggerClient.
1345         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
1346           way I see it, a ServerConnection should only know about its connection
1347           and the group of all possible servers should be kept by the
1348           application.
1349         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
1350           currentServerName, it makes sense that the connection should know that
1351           name.
1352         (-[ServerConnection currentServerName]):
1353
1354 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1355
1356         Reviewed by Adam.
1357
1358         - Integrated changes from mac drosera.  Recently I've encapsulated
1359         out the server connection object from the rest of Drosera because
1360         it is very platform dependent right now and RPC is not implemented on
1361         windows.  This functionality, of communicating with the WebKit server
1362         is the next area I will be focusing on in Windows.
1363
1364         - Other changes and cleanup were made to organize the code and add notes
1365         on which parts still need work.  Also some mac code is added and
1366         commented out, to act as pseudocode for the logic of those parts.
1367
1368         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
1369           pointer.
1370         * Drosera/config.h: Added whitespace.
1371         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
1372           these files got moved into Drosera.h/cpp
1373         * Drosera/win/DebuggerApplication.h: Removed.
1374         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring
1375           happened here to better match the logic flow of the same code on the
1376           mac side and to use the new ServerConnection class.
1377         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
1378         (DebuggerClient::initWithServerName): Initializer that will set up the
1379           class to use a ServerConnection object.  This was necessary so I could
1380           create a DebuggerClient without having to initilaize it at
1381           construction.
1382         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
1383           will be the UIDelegate and FrameLoadDelegate.
1384         (DebuggerClient::AddRef): For IUnknown.
1385         (DebuggerClient::Release): For IUnknown.
1386         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
1387           this still needs to set the global context of the server, but
1388           IWebFrame does not have an accessor for the global context yet.
1389         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
1390           this is a pass through for the same function in the document.
1391         (DebuggerClient::didReceiveTitle): Unimplemented part of
1392           FrameLoadDelegate this would change the title of the window.
1393         (DebuggerClient::createWebViewWithRequest): Part of the
1394           FrameLoadDelegate.  This is about new windows via Window.open() and
1395           how their delegates are set.
1396         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
1397           UIDelegate.  Just a debug function for printing messages.
1398         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
1399           because the Client should be the UIDelegate and FrameLoadDelegate
1400           to match the delegates on mac.
1401         (DebuggerClient::webViewLoaded): Added accessor method.
1402         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
1403           forgotten to add this file before.  This is where the platform
1404           dependent versions of the Documents functions live. Most of these are
1405           unimplemented because some piece of functionality does not exist on
1406           Windows yet.
1407         (DebuggerDocument::platformPause):
1408         (DebuggerDocument::platformResume):
1409         (DebuggerDocument::platformStepInto):
1410         (DebuggerDocument::platformEvaluateScript):
1411         (DebuggerDocument::getPlatformCurrentFunctionStack):
1412         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1413         (DebuggerDocument::platformValueForScopeVariableNamed):
1414         (DebuggerDocument::platformLog):
1415         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
1416           responsibilities becaue they belong in the Client. Also I laid the
1417           groundwork for attaching Drosera to a WebKit process
1418         (attachWndProc): Now if a server is selected the Client becomes it's
1419           delegate.
1420         (Drosera::Drosera): Added the construction of the Client and dictionary
1421           of server names.
1422         (Drosera::initUI): This is no longer the delegates, the Client is.
1423         (Drosera::webViewLoaded): Now asks the Client instead of holding local
1424           state.
1425         (Drosera::applicationDidFinishLaunching): Placeholder for needed
1426           notification registration when it's possible to implement.
1427         (Drosera::serverLoaded): Ditto
1428         (Drosera::serverUnloaded): Ditto
1429         (Drosera::attach): Attach Drosera to the WebKit server.
1430         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
1431         (Drosera::getInst):
1432         (Drosera::setInst):
1433         (Drosera::knownServers):
1434         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
1435           and added the ServerConnection.
1436         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
1437         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
1438           Most of the functions are completely unimlemented because they cannot
1439           connect with the WebKit server, because one does not exist on Windows
1440           yet.
1441         (ServerConnection::initWithServerName):
1442         (ServerConnection::~ServerConnection):
1443         (ServerConnection::setGlobalContext):
1444         (ServerConnection::pause):
1445         (ServerConnection::resume):
1446         (ServerConnection::stepInto):
1447         (ServerConnection::switchToServerNamed):
1448         (ServerConnection::applicationTerminating):
1449         (ServerConnection::serverConnectionDidDie):
1450         (ServerConnection::currentFrame):
1451         * Drosera/win/ServerConnection.h: Added. Ditto.
1452         (ServerConnection::ServerConnection):
1453
1454 2007-10-19  Alice Liu  <alice.liu@apple.com>
1455
1456         Reviewed by Darin.
1457
1458         Fix for these broken layout tests on Windows:
1459
1460         fast/forms/focus-selection-input.html
1461         fast/forms/focus-selection-textarea.html
1462         fast/forms/select-accesskey.html
1463
1464         * DumpRenderTree/win/EventSender.cpp:
1465         (keyDownCallback):
1466         correct the VK code for alt key.
1467
1468 2007-10-19  Eric Seidel  <eric@webkit.org>
1469
1470         Reviewed by Mark Rowe.
1471
1472         Make the GtkLauncher code slightly more readable.
1473
1474         * GtkLauncher/main.cpp:
1475         (setupMainMenu): Added.
1476         (setupMainWindowUI): Added.
1477         (main):
1478
1479 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
1480
1481         Rubber stamped by Adam.
1482
1483         - don't delay-load WebKit in DumpRenderTree.
1484
1485         * DumpRenderTree/win/DumpRenderTree.vcproj:
1486
1487 2007-10-18  Dan Bernstein  <mitz@apple.com>
1488
1489         Reviewed by Adam Roben.
1490
1491         - fix <rdar://problem/5313523>
1492         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
1493
1494         * DumpRenderTree/mac/DumpRenderTree.mm:
1495         (dump): Changed to use _responseMIMEType.
1496
1497 2007-10-17  Adam Roben  <aroben@apple.com>
1498
1499         Make it possible to have Windows-specific tests and results
1500
1501         When searching for tests to run and the Skipped file, we will only
1502         look in platform/win and the cross-platform directory. When looking
1503         for expected results, we will look in platform/win, then
1504         platform/mac-leopard, then platform/mac, then finally the
1505         cross-platform directory.
1506
1507         Reviewed by Sam.
1508
1509         * Scripts/run-webkit-tests:
1510         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
1511         searching in the cross-platform directory.
1512         (sub buildPlatformHierarchy): Removed some unneeded calls to
1513         dirname/basename.
1514
1515 2007-10-17  Adam Roben  <aroben@apple.com>
1516
1517         Add back the call to register WebKit that we had before WebKitInitializer existed
1518
1519         This is needed to ensure that the right WebKit is used when
1520         instantiating COM objects.
1521
1522         Reviewed by Oliver.
1523
1524         * DumpRenderTree/win/debug_internal.vsprops: Define
1525         DEBUG_WEBKIT_HAS_SUFFIX.
1526         * DumpRenderTree/win/DumpRenderTree.cpp:
1527         (initialize):
1528
1529 2007-10-17  Adam Roben  <aroben@apple.com>
1530
1531         Import File::Basename in webkitdirs since we use it
1532
1533         * Scripts/webkitdirs.pm:
1534
1535 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
1536
1537         - Updated the tiger leaks list to make the internal bots green.
1538
1539         * Scripts/run-webkit-tests:
1540
1541 2007-10-17  Adam Roben  <aroben@apple.com>
1542
1543         Build fix for VC++ Express
1544
1545         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
1546         and ole32.lib.
1547
1548 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1549
1550         Reviewed by Sam.
1551
1552         - Minor mac improvements based on observations I made while implementing the
1553         Windows code.
1554
1555         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
1556         then hand it to the Client who will retain it, it should just be the client who
1557         creates and owns the server.
1558         (-[DebuggerApplication attach:]):
1559         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
1560         * Drosera/mac/DebuggerClient.mm: Creates the server.
1561         (-[DebuggerClient initWithServerName:]):
1562         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
1563         can instead forward declare what it needs.
1564
1565 2007-10-16  Darin Adler  <darin@apple.com>
1566
1567         Reviewed by Geoff Garen.
1568
1569         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
1570         want to turn failing tests into platform-specific test results. Also did a
1571         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
1572         would take the type of results into account only some of the time.
1573
1574 2007-10-16  Adam Roben  <aroben@apple.com>
1575
1576         Add a new nightly launcher script for Windows
1577
1578         This new script is for versions of Safari that don't delay-load
1579         WebKit. I had to make FindSafari be able to print out the nightly
1580         launcher script on stdout because Windows shell scripts can't capture
1581         the output from a command into an environment variable.
1582
1583         Reviewed by Steve.
1584
1585         * FindSafari/FindSafari.cpp:
1586         (_tmain): Added /printSafariLauncher option.
1587         * Scripts/run-webkit-nightly.cmd: Added.
1588
1589 2007-10-16  Adam Roben  <aroben@apple.com>
1590
1591         Replace WebKitInitializer with FindSafari
1592
1593         We now rely on setting the PATH environment variable to tell Windows
1594         where to find WebKit and its dependencies (similar to
1595         DYLD_FRAMEWORK_PATH on Mac).
1596
1597         This change also make DumpRenderTree no longer delay-load WebKit.
1598
1599         Reviewed by Sam.
1600
1601         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
1602         FindSafari.
1603         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
1604         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
1605         WebKitInitializer, don't delay-load WebKit.
1606         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
1607         * Scripts/run-webkit-tests: Ditto.
1608         * Scripts/webkitdirs.pm:
1609         (sub setPathForRunningWebKitApp): Added.
1610         * WebKitInitializer/WebKitInitializer.cpp: Removed.
1611         * WebKitInitializer/WebKitInitializer.h: Removed.
1612         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
1613         * WebKitInitializer/debug.vsprops: Removed.
1614         * WebKitInitializer/debug_internal.vsprops: Removed.
1615         * WebKitInitializer/release.vsprops: Removed.
1616
1617 2007-10-16  Adam Roben  <aroben@apple.com>
1618
1619         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
1620
1621         http://bugs.webkit.org/show_bug.cgi?id=15532
1622
1623         FindSafari simply prints the location of an installed Safari.exe on
1624         stdout.
1625
1626         Reviewed by Darin.
1627
1628         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
1629         (getStringValue):
1630         (getWebViewCLSID):
1631         (getInstalledWebKitDirectory):
1632         (_tmain):
1633         * FindSafari/FindSafari.vcproj: Added.
1634         * Scripts/webkitdirs.pm:
1635         (sub installedSafariPath): Added. Calls FindSafari on Windows.
1636
1637 2007-10-16  Adam Roben  <aroben@apple.com>
1638
1639         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
1640
1641         Reviewed by Kevin McCullough.
1642
1643         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
1644         when referring to WebKit.dll.
1645         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
1646         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
1647         * DumpRenderTree/win/release.vsprops: Ditto.
1648         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
1649         never have a _debug suffix on WebKit.dll.
1650         * WebKitInitializer/WebKitInitializer.cpp:
1651         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
1652         specified.
1653         * WebKitInitializer/debug_internal.vsprops: Added
1654         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
1655
1656 2007-10-16  Darin Adler  <darin@apple.com>
1657
1658         Reviewed by Adele.
1659
1660         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
1661         Remove now-unneeded control/alt key hack; the tests have been updated.
1662
1663 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1664
1665         - Updated leaks list because our internal bot upgraded it's version of leopard and
1666         one of the leaks was fixed between that revision and the bot's previous version of
1667         leopard.
1668
1669         * Scripts/run-webkit-tests:
1670
1671 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
1672
1673         Reviewed by Tim.
1674
1675         - I encapsulated out the server connecton functionality because it is a specific part
1676         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
1677         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
1678         Windows.  So the majority of this patch is moving preexisting functionality.
1679
1680         - Also I removed the prefix header and changed to use config.h because it is more
1681         standard on how we use config.h in windows and it didn't make much sense to keep
1682         the prefix header and the config.h
1683
1684         * Drosera/DebuggerDocument.cpp:
1685         (DebuggerDocument::DebuggerDocument):
1686         * Drosera/DebuggerDocument.h:
1687         * Drosera/config.h:
1688         * Drosera/mac/DebuggerApplication.mm:
1689         (-[DebuggerApplication attach:]):
1690         * Drosera/mac/DebuggerClient.h:
1691         * Drosera/mac/DebuggerClient.mm:
1692         (-[DebuggerClient initWithServerConnection:]):
1693         (-[DebuggerClient dealloc]):
1694         (-[DebuggerClient windowDidLoad]):
1695         (-[DebuggerClient windowWillClose:]):
1696         (-[DebuggerClient webView:didFinishLoadForFrame:]):
1697         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
1698         * Drosera/mac/DebuggerDocumentPlatform.mm:
1699         (DebuggerDocument::platformPause):
1700         (DebuggerDocument::platformResume):
1701         (DebuggerDocument::platformStepInto):
1702         (DebuggerDocument::platformEvaluateScript):
1703         (DebuggerDocument::getPlatformCurrentFunctionStack):
1704         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1705         (DebuggerDocument::platformValueForScopeVariableNamed):
1706         (DebuggerDocument::platformLog):
1707         * Drosera/mac/Drosera.pch: Removed.
1708         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1709         * Drosera/mac/ServerConnection.h: Added.
1710         * Drosera/mac/ServerConnection.mm: Added.
1711         (-[ServerConnection initWithServerName:]):
1712         (-[ServerConnection dealloc]):
1713         (-[ServerConnection setGlobalContext:]):
1714         (-[ServerConnection pause]):
1715         (-[ServerConnection resume]):
1716         (-[ServerConnection stepInto]):
1717         (-[ServerConnection switchToServerNamed:]):
1718         (-[ServerConnection applicationTerminating:]):
1719         (-[ServerConnection serverConnectionDidDie:]):
1720         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1721         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
1722         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
1723         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
1724         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
1725         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
1726         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
1727         (-[ServerConnection currentFrame]):
1728         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
1729         (-[ServerConnection knownServers]):
1730
1731 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
1732
1733         Reviewed by Eric.
1734
1735         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
1736           Script to automatically search nightly builds for regressions (bisect-builds)
1737
1738         * Scripts/bisect-builds: Added.
1739
1740 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
1741
1742         Reviewed by Darin.
1743
1744         - New JavaScript benchmark
1745         http://bugs.webkit.org/show_bug.cgi?id=15515
1746
1747         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
1748         current development or release build of JavaScriptCore.
1749
1750 2007-10-15  Mark Rowe  <mrowe@apple.com>
1751
1752         Reviewed by Sam.
1753
1754         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
1755
1756         * Scripts/webkitdirs.pm:
1757         - Change checkArgv to remove the options from @ARGV to prevent
1758         them from interfering with further option processing.
1759         - Fix logic error in determineIsQt that would prevent it from bailing out early.
1760         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
1761         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
1762         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
1763
1764 2007-10-15  Darin Adler  <darin@apple.com>
1765
1766         Reviewed by Sam.
1767
1768         - added logging of window.prompt and window.confirm
1769
1770         * DumpRenderTree/mac/UIDelegate.mm:
1771         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1772         Implement the recommended delegate rather than the deprecated one.
1773         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
1774         Added.
1775         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1776         Added.
1777
1778         * DumpRenderTree/win/UIDelegate.h:
1779         * DumpRenderTree/win/UIDelegate.cpp:
1780         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
1781         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1782         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
1783         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
1784
1785 2007-10-15  Alice Liu  <alice.liu@apple.com>
1786
1787         Reviewed by Sam Weinig.
1788
1789         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
1790
1791         * DumpRenderTree/win/DumpRenderTree.cpp:
1792         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
1793         (main): allocate the global policy delegate for DRT's custom use
1794         * DumpRenderTree/win/DumpRenderTree.vcproj:
1795         Adding files to project
1796         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
1797         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1798         (LayoutTestController::setCustomPolicyDelegate):
1799         set the webview's policy delegate to DRT's custom one if the test requests it.
1800         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
1801         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
1802         (PolicyDelegate::PolicyDelegate):
1803         (PolicyDelegate::QueryInterface):
1804         (PolicyDelegate::AddRef):
1805         (PolicyDelegate::Release):
1806         (PolicyDelegate::decidePolicyForNavigationAction):
1807         * DumpRenderTree/win/PolicyDelegate.h: Added.
1808         (PolicyDelegate::decidePolicyForNewWindowAction):
1809         (PolicyDelegate::decidePolicyForMIMEType):
1810         (PolicyDelegate::unableToImplementPolicyWithError):
1811
1812 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
1813
1814         Reviewed by Mark.
1815
1816         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
1817         when querying for QMAKE_MKSPECS.
1818
1819 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
1820
1821         Reviewed by Adam Roben.
1822
1823         Fix run-webkit-tests is too greedy calculating platform hierarchy
1824         http://bugs.webkit.org/show_bug.cgi?id=15465
1825
1826         Fix run-webkit-tests being too greedy in trying to split the platform name up
1827         causing it to try and find tests in every directory above the first "-" in the
1828         path to the LayoutTests
1829
1830         * Scripts/run-webkit-tests:
1831
1832 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
1833
1834         Reviewed by Darin.
1835
1836         http://bugs.webkit.org/show_bug.cgi?id=15006
1837         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
1838         to reduce code duplication.
1839
1840         * Scripts/build-webkit:
1841         * Scripts/webkitdirs.pm:
1842         buildQMakeProject() renamed to buildQMakeQtProject().
1843         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
1844         unused $colorize has been removed.
1845
1846 === Start merge of feature-branch 2007-10-12 ===
1847
1848 2007-10-08  Eric Seidel  <eric@webkit.org>
1849
1850         Reviewed by Mark Rowe.
1851
1852         * Scripts/build-webkit: add --help, remove unused --color
1853
1854 2007-10-07  Eric Seidel  <eric@webkit.org>
1855
1856         Reviewed by darin.
1857
1858         * Drosera/mac/DebuggerDocumentPlatform.mm:
1859         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
1860
1861 2007-10-03  Rob Buis  <buis@kde.org>
1862
1863         Reviewed by Olliej.
1864
1865         Adapt to changed location of Ahem font.
1866
1867         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1868
1869 2007-10-02  Eric Seidel  <eric@webkit.org>
1870
1871         Reviewed by Adam Roben.
1872
1873         Make pixel tests more useful!
1874         Finally fix the image diff 0.00% mystery problem
1875         Highlight any image differences in the image diff.
1876         Add a link from image diffs back to original test file.
1877
1878         * DumpRenderTree/mac/ImageDiff.m:
1879         (compareImages): highlight any differences
1880         (computePercentageDifferent): round to two decimal places
1881         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
1882
1883 2007-10-02  Eric Seidel  <eric@webkit.org>
1884
1885         Reviewed by Alexey Proskuryakov.
1886
1887         * Scripts/run-webkit-tests: print the % image difference on main results page
1888
1889 2007-10-02  Mark Rowe  <mrowe@apple.com>
1890
1891         Reviewed by Oliver.
1892
1893         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1894
1895         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1896         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1897
1898 2007-10-01  Mark Rowe  <mrowe@apple.com>
1899
1900         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1901
1902 2007-09-25  Eric Seidel  <eric@webkit.org>
1903
1904         Reviewed by Mark Rowe.
1905
1906         DerivedSources.make was finding "ENABLE_SVG" in the string
1907         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
1908         quite correctly.
1909
1910         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
1911
1912 2007-09-25  Mark Rowe  <mrowe@apple.com>
1913
1914         Rubber-stamped by Eric.
1915
1916         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1917         This makes it possible to automate nightly builds for the feature-branch.
1918
1919 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
1920
1921         Rubber stamped by Mark.
1922
1923         Enable svg experimental features as default here in feature-branch.
1924
1925         * Scripts/build-webkit:
1926
1927 2007-06-29  Antti Koivisto  <antti@apple.com>
1928
1929         Reviewed by Weinig.
1930
1931         Add VIDEO flag for timed media features
1932
1933         * Scripts/build-webkit
1934
1935 === End merge of feature-branch 2007-10-12 ===
1936
1937 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1938
1939         Reviewed by Darin.
1940
1941         - Updated rational for the leaks list to be more clear.
1942
1943         * Scripts/run-webkit-tests:
1944
1945 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1946
1947         Rubber Stamp by Sam.
1948
1949         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
1950         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
1951
1952         * Scripts/run-webkit-tests:
1953
1954 2007-10-10  Simon Hausmann  <hausmann@kde.org>
1955
1956         Reviewed by Lars.
1957
1958         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
1959         includes are needed for INT_MAX, std::auto_ptr and the like.
1960
1961         * DumpRenderTree/qt/main.cpp:
1962
1963 2007-10-09  Lars Knoll  <lars@trolltech.com>
1964
1965         Reviewed by Simon.
1966
1967         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
1968
1969         * DumpRenderTree/qt/jsobjects.cpp:
1970         (LayoutTestController::encodeHostName):
1971         (LayoutTestController::decodeHostName):
1972         * DumpRenderTree/qt/jsobjects.h:
1973
1974 2007-10-09  Lars Knoll  <lars@trolltech.com>
1975
1976         Reviewed by Simon.
1977
1978         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
1979
1980         * DumpRenderTree/qt/DumpRenderTree.cpp:
1981         (WebCore::WebPage::createFrame):
1982         (WebCore::DumpRenderTree::DumpRenderTree):
1983         (WebCore::DumpRenderTree::titleChanged):
1984         * DumpRenderTree/qt/DumpRenderTree.h:
1985         * DumpRenderTree/qt/jsobjects.cpp:
1986         (LayoutTestController::reset):
1987         * DumpRenderTree/qt/jsobjects.h:
1988
1989 2007-10-09  Lars Knoll  <lars@trolltech.com>
1990
1991         Reviewed by Simon.
1992
1993         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
1994
1995         * DumpRenderTree/qt/DumpRenderTree.h:
1996         * DumpRenderTree/qt/jsobjects.cpp:
1997         (LayoutTestController::clearBackForwardList):
1998         * DumpRenderTree/qt/jsobjects.h:
1999
2000 2007-10-09  Lars Knoll  <lars@trolltech.com>
2001
2002         Reviewed by Simon.
2003
2004         make --git-reviewer work again.
2005
2006         * Scripts/prepare-ChangeLog:
2007
2008 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
2009
2010         Rubber stamped by Eric.
2011
2012         Connect to the "hovering-over-link" signal emitted by WebKitPage and
2013         show the current link inside the statusbar.
2014         This shows how to make use of this signal and allows to easily test
2015         http://bugs.webkit.org/show_bug.cgi?id=15299.
2016
2017         * GtkLauncher/main.cpp:
2018         (hoveringOverLink):
2019         (main):
2020
2021 2007-10-05  Lars Knoll  <lars@trolltech.com>
2022
2023         add proper error messages to the FrameLoaderClient.
2024         Implement ChromeClientQt::closeWindowSoon and
2025         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
2026         Some fixes in DRT to make it work correctly with multiple windows.
2027
2028         Reviewed by Maciej.
2029
2030         * DumpRenderTree/qt/DumpRenderTree.cpp:
2031         (WebCore::DumpRenderTree::DumpRenderTree):
2032         (WebCore::DumpRenderTree::createWindow):
2033         (WebCore::DumpRenderTree::windowCount):
2034         * DumpRenderTree/qt/DumpRenderTree.h:
2035         * DumpRenderTree/qt/jsobjects.cpp:
2036         (LayoutTestController::maybeDump):
2037         (LayoutTestController::windowCount):
2038         * DumpRenderTree/qt/jsobjects.h:
2039
2040 2007-10-05  Lars Knoll  <lars@trolltech.com>
2041
2042         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
2043         Add support for layoutTextController.setCanOpenWindows() to DRT
2044         fixing another 2 test cases in fast/dom/Window.
2045
2046         Reviewed by Maciej.
2047
2048         * DumpRenderTree/qt/DumpRenderTree.cpp:
2049         (WebCore::WebPage::WebPage):
2050         (WebCore::WebPage::createWindow):
2051         (WebCore::DumpRenderTree::resetJSObjects):
2052         (WebCore::DumpRenderTree::createWindow):
2053         * DumpRenderTree/qt/DumpRenderTree.h:
2054         * DumpRenderTree/qt/DumpRenderTree.pro:
2055         * DumpRenderTree/qt/jsobjects.cpp:
2056         (LayoutTestController::LayoutTestController):
2057         (LayoutTestController::reset):
2058         * DumpRenderTree/qt/jsobjects.h:
2059         * DumpRenderTree/qt/main.cpp:
2060         * DumpRenderTree/qt/testplugin.cpp: Added.
2061         * DumpRenderTree/qt/testplugin.h: Added.
2062
2063 2007-10-04  Sam Weinig  <sam@webkit.org>
2064
2065         Rubber stamped by Adam.
2066
2067         Remove empty directories.
2068
2069         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
2070         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
2071
2072 2007-10-03  Darin Adler  <darin@apple.com>
2073
2074         Reviewed by Adam.
2075
2076         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
2077         we find the internal libraries in the libraries directory. This
2078         is helpful for Safari team engineers at Apple.
2079
2080 2007-10-03  Adam Roben  <aroben@apple.com>
2081
2082         Update the location of AHEM___.TTF after r25968
2083
2084         Reviewed by Sam.
2085
2086         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2087
2088 2007-10-03  Alp Toker  <alp@atoker.com>
2089
2090         Reviewed by Adam.
2091
2092         http://bugs.webkit.org/show_bug.cgi?id=14726
2093         [gtk] API design. Mapping the WebView delegates to signals.
2094
2095         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
2096
2097         * GtkLauncher/main.cpp:
2098         (goToURLBarText):
2099         (titleChanged):
2100         (progressChanged):
2101         (menuMainBackCallback):
2102         (menuMainForwardCallback):
2103         (main):
2104
2105 2007-10-03  Lars Knoll  <lars@trolltech.com>
2106
2107         Reviewed by Rob.
2108
2109         This fixes --strict mode in run-webkit-tests again after
2110         the platform dependent test results have been moved.
2111
2112         * Scripts/run-webkit-tests:
2113
2114 2007-10-03  Lars Knoll  <lars@trolltech.com>
2115
2116         Reviewed by bdash.
2117
2118         remove the hack in run-webkit-tests that forced text only test
2119         to be taken from the platform independent dir. It was only left
2120         there from early days.
2121
2122         Remove platform dependent results for tests that are text only nowadays,
2123         and add one platform dependent result for a text only test that requires it.
2124
2125         * Scripts/run-webkit-tests:
2126
2127 2007-10-03  Lars Knoll  <lars@trolltech.com>
2128
2129         Reviewed by olliej.
2130
2131         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
2132
2133         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
2134         (WebCore::WebFrame::WebFrame):
2135         (WebCore::WebPage::WebPage):
2136         (WebCore::WebPage::createFrame):
2137         (WebCore::WebPage::javaScriptAlert):
2138         (WebCore::WebPage::javaScriptConsoleMessage):
2139         (WebCore::DumpRenderTree::DumpRenderTree):
2140         (WebCore::DumpRenderTree::~DumpRenderTree):
2141         (WebCore::DumpRenderTree::open):
2142         (WebCore::DumpRenderTree::readStdin):
2143         (WebCore::DumpRenderTree::resetJSObjects):
2144         (WebCore::DumpRenderTree::initJSObjects):
2145         (WebCore::DumpRenderTree::dumpFramesAsText):
2146         (WebCore::DumpRenderTree::dump):
2147         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
2148         (WebCore::DumpRenderTree::layoutTestController):
2149         (WebCore::DumpRenderTree::eventSender):
2150         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
2151         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
2152         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
2153         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
2154         (HackWebFrame::mousePressEvent):
2155         (HackWebFrame::mouseReleaseEvent):
2156         (HackWebFrame::mouseMoveEvent):
2157         (HackWebFrame::HackWebFrame):
2158         (HackWebFrame::~HackWebFrame):
2159         (LayoutTestController::LayoutTestController):
2160         (LayoutTestController::reset):
2161         (LayoutTestController::maybeDump):
2162         (LayoutTestController::waitUntilDone):
2163         (LayoutTestController::notifyDone):
2164         (LayoutTestController::dumpEditingCallbacks):
2165         (LayoutTestController::queueReload):
2166         (LayoutTestController::provisionalLoad):
2167         (LayoutTestController::timerEvent):
2168         (EventSender::EventSender):
2169         (EventSender::mouseDown):
2170         (EventSender::mouseUp):
2171         (EventSender::mouseMoveTo):
2172         (EventSender::leapForward):
2173         (EventSender::keyDown):
2174         (EventSender::frameUnderMouse):
2175         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
2176         (LayoutTestController::isLoading):
2177         (LayoutTestController::setLoading):
2178         (LayoutTestController::shouldDumpAsText):
2179         (LayoutTestController::shouldDumpChildrenAsText):
2180         (LayoutTestController::shouldWaitUntilDone):
2181         (LayoutTestController::dumpAsText):
2182         (LayoutTestController::dumpChildFramesAsText):
2183         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
2184         (messageHandler):
2185         (crashHandler):
2186         (main):
2187         * Scripts/run-webkit-tests:
2188
2189 2007-10-03  Mark Rowe  <mrowe@apple.com>
2190
2191         Reviewed by Alp Toker.
2192
2193         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
2194         should take precedence over QTDIR when determining which port we are working with.
2195
2196         * Scripts/webkitdirs.pm:
2197
2198 2007-10-02  Adam Roben  <aroben@apple.com>
2199
2200         Add keychain to the list of default packages to install
2201
2202         Rubberstamped by Sam.
2203
2204         * CygwinDownloader/cygwin-downloader.py:
2205         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2206
2207 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
2208
2209         Reviewed by Adam.
2210
2211         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
2212         Also makes WebCore regression test case logic work when using git.
2213
2214         * Scripts/prepare-ChangeLog:
2215         (reviewerAndDescriptionForGitCommit): Added.
2216
2217 2007-10-02  Lars Knoll  <lars@trolltech.com>
2218
2219         Reviewed by bdash.
2220
2221         Add API to retrieve the frame name from QWebFrame.
2222         Implement support for DRT::dumpChildrenAsText.
2223
2224         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2225         (WebCore::DumpRenderTree::dumpFramesAsText):
2226         (WebCore::DumpRenderTree::dump):
2227         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2228         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2229         (LayoutTestController::LayoutTestController):
2230         (LayoutTestController::reset):
2231         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2232
2233 2007-10-02  Lars Knoll  <lars@trolltech.com>
2234
2235         Reviewed by bdash.
2236
2237         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
2238
2239         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2240         (WebCore::DumpRenderTree::readStdin):
2241
2242 2007-10-02  Mark Rowe  <mrowe@apple.com>
2243
2244         Reviewed by Oliver.
2245
2246         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2247
2248         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2249         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2250
2251 2007-10-02  Mark Rowe  <mrowe@apple.com>
2252
2253         Rubber-stamped by Maciej.
2254
2255         Configuration changes from build.webkit.org.  The major change is refactoring to work
2256         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
2257         last few weeks.
2258
2259         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2260         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
2261         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
2262         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
2263         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
2264         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
2265         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
2266         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
2267
2268 2007-10-02  Lars Knoll  <lars@trolltech.com>
2269
2270         Reviewed by Maciej.
2271
2272         Add support for eventSender.mouseMove to DRT.
2273         Fixes fast/css/hover-affects-child.html
2274
2275         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2276         (EventSender::mouseMoveTo):
2277
2278 2007-10-01  Mark Rowe  <mrowe@apple.com>
2279
2280         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2281
2282 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
2283
2284         Reviewed by Hyatt.
2285
2286         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
2287
2288         * Scripts/svn-apply:
2289         (gitdiff2svndiff): Ignore lines beginning with "new file".
2290         * Scripts/svn-unapply:
2291         (gitdiff2svndiff): Ditto.
2292
2293 2007-09-30  George Staikos  <staikos@kde.org>
2294
2295         Qt build fix (Mac OS X specific)
2296
2297         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
2298
2299 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
2300
2301         Reviewed by Mark.
2302
2303         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
2304         Remove Bakefiles from svn.
2305
2306         * GtkLauncher/Bakefiles.bkgen: Removed.
2307         * GtkLauncher/ENV: Removed.
2308         * GtkLauncher/gdklauncher.bkl: Removed.
2309         * GtkLauncher/mk: Removed.
2310         * Scripts/regenerate-makefiles: Removed.
2311
2312 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
2313
2314         Reviewed by John.
2315
2316         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
2317
2318         * Scripts/run-webkit-tests:
2319
2320 2007-09-26  Adam Roben  <aroben@apple.com>
2321
2322         Make not finding an installed WebKit non-fatal
2323
2324         What really matters is that we are able to load WebKit and its
2325         dependencies, not whether we think we've found an installed WebKit.
2326
2327         Reviewed by Sam.
2328
2329         * WebKitInitializer/WebKitInitializer.cpp:
2330         (getWebViewCLSID): Use new LOG_WARNING macro.
2331         (getInstalledWebKitDirectory): Ditto.
2332         (initializeWebKit): Don't die if we didn't find an installed WebKit,
2333         and use new macros.
2334         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
2335
2336 2007-09-26  Adam Roben  <aroben@apple.com>
2337
2338         Committed this file before saving it
2339
2340         * WebKitInitializer/debug_internal.vsprops:
2341
2342 2007-09-26  Adam Roben  <aroben@apple.com>
2343
2344         Load WebKit and its dependencies manually so they come from DllDirectory
2345
2346         I had to change WebKitInitializer to use malloc/free instead of
2347         new/delete to avoid pulling in WebKit (and its dependencies) early
2348         through use of fastMalloc.
2349
2350         Reviewed by Oliver.
2351
2352         * WebKitInitializer/WebKitInitializer.cpp:
2353         (getStringValue): Changed to use malloc/free.
2354         (getInstalledWebKitDirectory): Ditto.
2355         (initializeWebKit): Call SetDllDirectory first, then load all of
2356         WebKit's dependencies manually, finally followed by WebKit itself.
2357         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
2358         configuration to match our other projects.
2359         * WebKitInitializer/debug_internal.vsprops: Added.
2360
2361 2007-09-25  Adam Roben  <aroben@apple.com>
2362
2363         Actually define DEBUG/NDEBUG so that we load WebKit correctly
2364
2365         Rubberstamped by Sam.
2366
2367         * WebKitInitializer/WebKitInitializer.vcproj:
2368
2369 2007-09-25  Adam Roben  <aroben@apple.com>
2370
2371         Make DumpRenderTree delay-load its dependencies
2372
2373         This lets WebKitInitializer re-route the dependencies to be loaded out
2374         of the Safari installation directory.
2375
2376         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
2377         same thing), since we can't import the kCFAllocatorDefault symbol when
2378         delay-loading CoreFoundation.dll.
2379
2380         Rubberstamped by Sam.
2381
2382         * DumpRenderTree/win/DumpRenderTree.cpp:
2383         (runTest):
2384         (javaScriptThreads):
2385         * DumpRenderTree/win/DumpRenderTree.vcproj:
2386         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2387         (LayoutTestController::setWaitToDump):
2388
2389 2007-09-25  Adam Roben  <aroben@apple.com>
2390
2391         Pull ole32.lib into WebKitInitializer
2392
2393         Rubberstamped by Sam.
2394
2395         * WebKitInitializer/WebKitInitializer.vcproj:
2396
2397 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2398
2399         Reviewed by Adam.
2400
2401         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
2402           LGPL'ed files contain incorrect FSF address
2403
2404         * Drosera/config.h:
2405
2406 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2407
2408         Reviewed by Adam.
2409
2410         Make svn-apply and svn-unapply work with git-diff formatted patches.
2411
2412         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
2413         (gitdiff2svndiff): Added.
2414         * Scripts/svn-unapply: Ditto.
2415         (gitdiff2svndiff): Added.
2416
2417 2007-09-25  Adam Roben  <aroben@apple.com>
2418
2419         Pull advapi32.lib into WebKitInitializer
2420
2421         This is needed to get the registry functions we use.
2422
2423         Rubberstamped by Sam.
2424
2425         * WebKitInitializer/WebKitInitializer.vcproj:
2426
2427 2007-09-25  Adam Roben  <aroben@apple.com>
2428
2429         Add python and rsync to cygwin-downloader
2430
2431         Our build slaves need this, and it can't hurt for everyone else to
2432         have it, too.
2433
2434         Reviewed by Sam.
2435
2436         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
2437         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2438
2439 2007-09-25  Adam Roben  <aroben@apple.com>
2440
2441         Add WebKitInitializer and use it in DumpRenderTree
2442
2443         WebKitInitializer is a static library that has one function,
2444         initializeWebKit(). This registers WebKit and sets up the DLL search
2445         path so that WebKit's dependencies that are installed with Safari can
2446         be found.
2447
2448         Reviewed by Sam.
2449
2450         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
2451         DumpRenderTree depend on it.
2452         * DumpRenderTree/win/DumpRenderTree.cpp:
2453         (initialize): Call initializeWebKit.
2454         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
2455         WebKitInitializer.lib.
2456         * WebKitInitializer/WebKitInitializer.cpp: Added.
2457         (getStringValue):
2458         (getWebViewCLSID):
2459         (getInstalledWebKitDirectory):
2460         (initializeWebKit):
2461         * WebKitInitializer/WebKitInitializer.h: Added.
2462         * WebKitInitializer/WebKitInitializer.vcproj: Added.
2463         * WebKitInitializer/debug.vsprops: Added.
2464         * WebKitInitializer/release.vsprops: Added.
2465
2466 2007-09-25  Adam Roben  <aroben@apple.com>
2467
2468         Make run-webkit-tests respect set-webkit-configuration
2469
2470         Reviewed by Sam.
2471
2472         * Scripts/run-webkit-tests: Initialize $configuration to whatever
2473         set-webkit-configuration was last set to.
2474
2475 2007-09-25  Mark Rowe  <mrowe@apple.com>
2476
2477         Rubber-stamped by Eric.
2478
2479         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2480         This makes it possible to automate nightly builds for the feature-branch.
2481
2482 2007-09-25  Adam Roben  <aroben@apple.com>
2483
2484         A couple of fixes/enhancements to update-webkit-*-libs
2485
2486         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
2487         to tell update-webkit-support-libraries where it should find the
2488         WebKitSupportLibrary.zip file you downloaded.
2489
2490         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
2491         Windows-style path.
2492
2493         Reviewed by Sam.
2494
2495         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
2496         to $auxiliaryLibsURL and removed an irrelevant comment.
2497         * Scripts/update-webkit-support-libs:
2498
2499 2007-09-25  Adam Treat  <treat@kde.org>
2500
2501         Reviewed by Simon and Lars.
2502
2503         Refactors and cleans up Qt DRT member variable names, member variable
2504         initialization, style fixes and general code cleanup.
2505
2506         Adds queueReload slot to LayoutTestController that some tests require.
2507
2508         Subclasses QWebFrame to make sure that all frames have an associated
2509         LayoutTestController JS window object.
2510
2511         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
2512         aren't dumped twice.
2513
2514         EOF fixes.
2515
2516         Together, this patch fixes some 20+ layout tests in QtWebKit.
2517
2518         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2519         (WebCore::WebFrame::WebFrame):
2520         (WebCore::WebPage::WebPage):
2521         (WebCore::WebPage::createFrame):
2522         (WebCore::DumpRenderTree::DumpRenderTree):
2523         (WebCore::DumpRenderTree::open):
2524         (WebCore::DumpRenderTree::readStdin):
2525         (WebCore::DumpRenderTree::initJSObjects):
2526         (WebCore::DumpRenderTree::dump):
2527         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2528         (WebCore::DumpRenderTree::layoutTestController):
2529         (WebCore::DumpRenderTree::eventSender):
2530         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2531         (LayoutTestController::LayoutTestController):
2532         (LayoutTestController::reset):
2533         (LayoutTestController::maybeDump):
2534         (LayoutTestController::waitUntilDone):
2535         (LayoutTestController::notifyDone):
2536         (LayoutTestController::queueReload):
2537         (LayoutTestController::provisionalLoad):
2538         (EventSender::EventSender):
2539         (EventSender::mouseDown):
2540         (EventSender::mouseUp):
2541         (EventSender::mouseMoveTo):
2542         (EventSender::frameUnderMouse):
2543         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2544         (LayoutTestController::isLoading):
2545         (LayoutTestController::setLoading):
2546         (LayoutTestController::dumpAsText):
2547         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
2548         (main):
2549
2550 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2551
2552
2553         - Reverted an accidentally checked in file.
2554
2555         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
2556
2557 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2558         Reviewed by Sam.
2559
2560         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
2561
2562         * DumpRenderTree/win/DumpRenderTree.vcproj:
2563         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2564
2565 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
2566
2567         Rubber stamped by Adam.
2568
2569         * GdkLauncher: Removed.
2570         * GdkLauncher/Bakefiles.bkgen: Removed.
2571         * GdkLauncher/ENV: Removed.
2572         * GdkLauncher/GdkLauncher.pro: Removed.
2573         * GdkLauncher/gdklauncher.bkl: Removed.
2574         * GdkLauncher/main.cpp: Removed.
2575         * GdkLauncher/mk: Removed.
2576         * GdkLauncher/simple.svg: Removed.
2577         * GdkLauncher/text.html: Removed.
2578         * GtkLauncher: Added.
2579         * GtkLauncher/GdkLauncher.pro: Removed.
2580         * GtkLauncher/GtkLauncher.pro: Added.
2581         * GtkLauncher/main.cpp:
2582         (updateWindowTitle):
2583         (main):
2584         * Scripts/build-webkit:
2585         * Scripts/regenerate-makefiles:
2586         * Scripts/run-javascriptcore-tests:
2587         * Scripts/run-launcher:
2588         * Scripts/run-webkit-tests:
2589         * Scripts/webkitdirs.pm:
2590
2591 2007-09-21  Timothy Hatcher  <timothy@apple.com>
2592
2593         Reviewed by Darin.
2594
2595         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
2596
2597         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
2598         This is tested by plugins/root-object-premature-delete-crash.html.
2599
2600         * DumpRenderTree/mac/ObjCController.m:
2601         (-[ObjCController accessStoredWebScriptObject]):
2602
2603 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
2604
2605         Reviewed by Oliver.
2606
2607         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
2608
2609         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2610         (FrameLoadDelegate::FrameLoadDelegate):
2611
2612 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
2613
2614         Reviewed by Adam.
2615
2616         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
2617         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
2618
2619         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
2620         Now isQt() and isGdk() use global variables that are only set once.
2621
2622         An array of all the parameters is now given to build-dumprender which includes
2623         the platform on linux.
2624
2625         * Scripts/build-dumprendertree:
2626         * Scripts/run-webkit-tests:
2627         * Scripts/webkitdirs.pm:
2628
2629 2007-09-19  Adam Roben  <aroben@apple.com>
2630
2631         Rubberstamped by Hyatt.
2632
2633         * Spinneret: Removed.
2634
2635 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
2636
2637         Reviewed by David Kilzer.
2638
2639         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
2640
2641 2007-09-18  Sam Weinig  <sam@webkit.org>
2642
2643         Add JSRetainPtr.h #include to fix some builds.
2644
2645         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2646
2647 2007-09-18  Mike Hommey  <glandium@debian.org>
2648
2649         Reviewed by Adam.
2650
2651         * Scripts/prepare-ChangeLog:
2652         - Properly parse GECOS field.
2653         - Use git configuration for user name and email when appropriate.
2654
2655 2007-09-17  Sam Weinig  <sam@webkit.org>
2656
2657         Build fix.
2658
2659         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2660
2661 2007-09-17  Sam Weinig  <sam@webkit.org>
2662
2663         Reviewed by Adam Roben.
2664
2665         Share more code between mac and windows DRT.
2666             - GCController is now shared.
2667             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
2668
2669         * DumpRenderTree/GCController.cpp:
2670         * DumpRenderTree/win/DumpRenderTree.cpp:
2671         * DumpRenderTree/win/DumpRenderTree.vcproj:
2672         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
2673         (FrameLoadDelegate::FrameLoadDelegate):
2674         (FrameLoadDelegate::~FrameLoadDelegate):
2675         (FrameLoadDelegate::windowScriptObjectAvailable):
2676         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
2677         * DumpRenderTree/win/GCController.cpp: Removed.
2678         * DumpRenderTree/win/GCController.h: Removed.
2679         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
2680         (GCController::collect):
2681         (GCController::collectOnAlternateThread):
2682         (GCController::getJSObjectCount):
2683         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
2684         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
2685
2686 2007-09-17  Sam Weinig  <sam@webkit.org>
2687
2688         Reviewed by Adam Roben.
2689
2690         Begin sharing code between mac and windows DRT.
2691             - both now share LayoutTestController.h/cpp and implement platform dependant
2692               operations in LayoutTestControllerMac/Win.
2693             - DumpRenderTree.h is now shared.
2694             - WorkQueue and WorkQueueItem are also shared.
2695
2696         * DumpRenderTree/DumpRenderTree.h:
2697         * DumpRenderTree/LayoutTestController.cpp:
2698         * DumpRenderTree/win/DumpRenderTree.cpp:
2699         (displayWebView):
2700         (dumpFrameScrollPosition):
2701         (dumpFramesAsText):
2702         (dump):
2703         (runTest):
2704         * DumpRenderTree/win/DumpRenderTree.h: Removed.
2705         * DumpRenderTree/win/DumpRenderTree.vcproj:
2706         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
2707         * DumpRenderTree/win/EditingDelegate.cpp:
2708         (EditingDelegate::shouldBeginEditingInDOMRange):
2709         (EditingDelegate::shouldEndEditingInDOMRange):
2710         (EditingDelegate::shouldInsertNode):
2711         (EditingDelegate::shouldInsertText):
2712         (EditingDelegate::shouldDeleteDOMRange):
2713         (EditingDelegate::shouldChangeSelectedDOMRange):
2714         (EditingDelegate::shouldApplyStyle):
2715         (EditingDelegate::shouldChangeTypingStyle):
2716         (EditingDelegate::doPlatformCommand):
2717         (EditingDelegate::webViewDidBeginEditing):
2718         (EditingDelegate::webViewDidChange):
2719         (EditingDelegate::webViewDidEndEditing):
2720         (EditingDelegate::webViewDidChangeTypingStyle):
2721         (EditingDelegate::webViewDidChangeSelection):
2722         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
2723         * DumpRenderTree/win/LayoutTestController.h: Removed.
2724         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
2725         (LayoutTestController::addDisallowedURL):
2726         (LayoutTestController::clearBackForwardList):
2727         (LayoutTestController::copyDecodedHostName):
2728         (LayoutTestController::copyEncodedHostName):
2729         (LayoutTestController::display):
2730         (LayoutTestController::keepWebHistory):
2731         (LayoutTestController::notifyDone):
2732         (LayoutTestController::queueBackNavigation):
2733         (LayoutTestController::queueForwardNavigation):
2734         (jsStringRefToWString):
2735         (LayoutTestController::queueLoad):
2736         (LayoutTestController::queueReload):
2737         (LayoutTestController::queueScript):
2738         (LayoutTestController::setAcceptsEditing):
2739         (LayoutTestController::setCustomPolicyDelegate):
2740         (LayoutTestController::setMainFrameIsFirstResponder):
2741         (LayoutTestController::setTabKeyCyclesThroughElements):
2742         (LayoutTestController::setUseDashboardCompatibilityMode):
2743         (LayoutTestController::setUserStyleSheetEnabled):
2744         (LayoutTestController::setUserStyleSheetLocation):
2745         (LayoutTestController::setWindowIsKey):
2746         (waitUntilDoneWatchdogFired):
2747         (LayoutTestController::setWaitToDump):
2748         (LayoutTestController::windowCount):
2749         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
2750         (FrameLoadDelegate::didReceiveTitle):
2751         (FrameLoadDelegate::processWork):
2752         (FrameLoadDelegate::locationChangeDone):
2753         (FrameLoadDelegate::windowScriptObjectAvailable):
2754         * DumpRenderTree/win/WorkQueue.cpp: Removed.
2755         * DumpRenderTree/win/WorkQueue.h: Removed.
2756         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
2757         * DumpRenderTree/win/WorkQueueItem.h: Removed.
2758         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
2759         (jsStringRefToWString):
2760         (LoadItem::invoke):
2761         (ScriptItem::invoke):
2762
2763 2007-09-17  Sam Weinig  <sam@webkit.org>
2764
2765         Reviewed by Adam Roben.
2766
2767         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
2768
2769         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
2770         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
2771         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
2772         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
2773         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
2774         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
2775         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
2776         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
2777         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
2778         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
2779         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
2780         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
2781         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
2782         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
2783         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
2784         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
2785         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
2786         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
2787         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
2788         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
2789         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
2790         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
2791         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
2792         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
2793         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
2794         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
2795         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
2796         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
2797         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
2798         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
2799         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
2800         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
2801         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
2802         * DumpRenderTree/win: Added.
2803         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
2804         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
2805         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
2806         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
2807         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
2808         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
2809         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
2810         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
2811         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
2812         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
2813         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
2814         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
2815         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
2816         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2817         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
2818         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
2819         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
2820         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
2821         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2822         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2823         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
2824         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2825         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
2826         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
2827         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
2828         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
2829
2830 2007-09-15  Mark Rowe  <mrowe@apple.com>
2831
2832         Build fix for DumpRenderTree.
2833
2834         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
2835
2836 2007-09-14  Sam Weinig  <sam@webkit.org>
2837
2838         Rubber stamped by Adam Roben.
2839
2840         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
2841           - The UIDelegate was put into a new file while the FrameLoadDelegate was
2842             kept in the WaitUntilDoneDelegate file for the time being.
2843
2844         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
2845         (main):
2846         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
2847         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
2848         (UIDelegate::QueryInterface):
2849         (UIDelegate::AddRef):
2850         (UIDelegate::Release):
2851         (UIDelegate::hasCustomMenuImplementation):
2852         (UIDelegate::setFrame):
2853         (UIDelegate::webViewFrame):
2854         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2855         (UIDelegate::webViewAddMessageToConsole):
2856         (UIDelegate::doDragDrop):
2857         (UIDelegate::webViewGetDlgCode):
2858         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
2859         (UIDelegate::UIDelegate):
2860         (UIDelegate::createWebViewWithRequest):
2861         (UIDelegate::webViewShow):
2862         (UIDelegate::webViewClose):
2863         (UIDelegate::webViewFocus):
2864         (UIDelegate::webViewUnfocus):
2865         (UIDelegate::webViewFirstResponder):
2866         (UIDelegate::makeFirstResponder):
2867         (UIDelegate::setStatusText):
2868         (UIDelegate::webViewStatusText):
2869         (UIDelegate::webViewAreToolbarsVisible):
2870         (UIDelegate::setToolbarsVisible):
2871         (UIDelegate::webViewIsStatusBarVisible):
2872         (UIDelegate::setStatusBarVisible):
2873         (UIDelegate::webViewIsResizable):
2874         (UIDelegate::setResizable):
2875         (UIDelegate::setContentRect):
2876         (UIDelegate::webViewContentRect):
2877         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2878         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2879         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2880         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
2881         (UIDelegate::mouseDidMoveOverElement):
2882         (UIDelegate::contextMenuItemsForElement):
2883         (UIDelegate::validateUserInterfaceItem):
2884         (UIDelegate::shouldPerformAction):
2885         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
2886         (UIDelegate::willPerformDragDestinationAction):
2887         (UIDelegate::dragSourceActionMaskForPoint):
2888         (UIDelegate::willPerformDragSourceAction):
2889         (UIDelegate::contextMenuItemSelected):
2890         (UIDelegate::trackCustomPopupMenu):
2891         (UIDelegate::measureCustomMenuItem):
2892         (UIDelegate::drawCustomMenuItem):
2893         (UIDelegate::addCustomMenuDrawingData):
2894         (UIDelegate::cleanUpCustomMenuDrawingData):
2895         (UIDelegate::canTakeFocus):
2896         (UIDelegate::takeFocus):
2897         (UIDelegate::registerUndoWithTarget):
2898         (UIDelegate::removeAllActionsWithTarget):
2899         (UIDelegate::setActionTitle):
2900         (UIDelegate::undo):
2901         (UIDelegate::redo):
2902         (UIDelegate::canUndo):
2903         (UIDelegate::canRedo):
2904         (UIDelegate::webViewResizerRect):
2905         (UIDelegate::webViewDrawResizer):
2906         (UIDelegate::webViewScrolled):
2907         (UIDelegate::webViewShouldInterruptJavaScript):
2908         (UIDelegate::webViewReceivedFocus):
2909         (UIDelegate::webViewLostFocus):
2910         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
2911         (FrameLoadDelegate::QueryInterface):
2912         (FrameLoadDelegate::AddRef):
2913         (FrameLoadDelegate::Release):
2914         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2915         (FrameLoadDelegate::didCommitLoadForFrame):
2916         (FrameLoadDelegate::didReceiveTitle):
2917         (FrameLoadDelegate::processWork):
2918         (processWorkTimer):
2919         (FrameLoadDelegate::locationChangeDone):
2920         (FrameLoadDelegate::didFinishLoadForFrame):
2921         (FrameLoadDelegate::didFailLoadWithError):
2922         (FrameLoadDelegate::windowScriptObjectAvailable):
2923         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
2924         (FrameLoadDelegate::FrameLoadDelegate):
2925
2926 2007-09-14  Sam Weinig  <sam@webkit.org>
2927
2928         Reviewed by Kevin McCullough.
2929
2930         Move mac specific globals in to mac/DumpRenderTreeMac.h
2931
2932         * DumpRenderTree/DumpRenderTree.h:
2933         * DumpRenderTree/DumpRenderTree.mm: Removed.
2934         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2935         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
2936         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
2937
2938 2007-09-14  Brady Eidson  <beidson@apple.com>
2939
2940         Rubberstamped by Weinig
2941
2942         You know, Sam, some of us use case-sensitve filesystems...
2943
2944         * DumpRenderTree/DumpRenderTree.h:
2945         * DumpRenderTree/mac/UIDelegate.mm:
2946
2947 2007-09-14  Sam Weinig  <sam@webkit.org>
2948
2949         Rubber stamped by Adam Roben.
2950
2951         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
2952         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
2953
2954         * DumpRenderTree/AppleScriptController.h: Removed.
2955         * DumpRenderTree/AppleScriptController.m: Removed.
2956         * DumpRenderTree/DumpRenderTree.h:
2957         * DumpRenderTree/DumpRenderTree.mm:
2958         (startJavaScriptThreads):
2959         (stopJavaScriptThreads):
2960         (activateAhemFont):
2961         (setDefaultColorProfileToRGB):
2962         (makeLargeMallocFailSilently):
2963         (dumpFrameScrollPosition):
2964         (dumpFramesAsText):
2965         (dump):
2966         (runTest):
2967         (-[DumpRenderTreeWindow isKeyWindow]):
2968         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2969         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
2970         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
2971         * DumpRenderTree/EditingDelegate.h: Removed.
2972         * DumpRenderTree/EditingDelegate.m: Removed.
2973         * DumpRenderTree/EventSendingController.h: Removed.
2974         * DumpRenderTree/EventSendingController.m: Removed.
2975         * DumpRenderTree/FrameLoadDelegate.h: Removed.
2976         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
2977         * DumpRenderTree/GCController.mm: Removed.
2978         * DumpRenderTree/ImageDiff.m: Removed.
2979         * DumpRenderTree/LayoutTestController.cpp:
2980         (LayoutTestController::LayoutTestController):
2981         (dumpAsTextCallback):
2982         (dumpBackForwardListCallback):
2983         (dumpChildFramesAsTextCallback):
2984         (dumpChildFrameScrollPositionsCallback):
2985         (dumpDOMAsWebArchiveCallback):
2986         (dumpEditingCallbacksCallback):
2987         (dumpFrameLoadCallbacksCallback):
2988         (dumpResourceLoadCallbacksCallback):
2989         (dumpSelectionRectCallback):
2990         (dumpSourceAsWebArchiveCallback):
2991         (dumpTitleChangesCallback):
2992         (repaintSweepHorizontallyCallback):
2993         (setCallCloseOnWebViewsCallback):
2994         (setCanOpenWindowsCallback):
2995         (setCloseRemainingWindowsWhenCompleteCallback):
2996         (testRepaintCallback):
2997         (addFileToPasteboardOnDragCallback):
2998         (waitUntilDoneCallback):
2999         * DumpRenderTree/LayoutTestController.h:
3000         (LayoutTestController::dumpAsText):
3001         (LayoutTestController::setDumpAsText):
3002         (LayoutTestController::dumpBackForwardList):
3003         (LayoutTestController::setDumpBackForwardList):
3004         (LayoutTestController::dumpChildFrameScrollPositions):
3005         (LayoutTestController::setDumpChildFrameScrollPositions):
3006         (LayoutTestController::dumpChildFramesAsText):
3007         (LayoutTestController::setDumpChildFramesAsText):
3008         (LayoutTestController::dumpDOMAsWebArchive):
3009         (LayoutTestController::setDumpDOMAsWebArchive):
3010         (LayoutTestController::dumpSelectionRect):
3011         (LayoutTestController::setDumpSelectionRect):
3012         (LayoutTestController::dumpSourceAsWebArchive):
3013         (LayoutTestController::setDumpSourceAsWebArchive):
3014         (LayoutTestController::dumpTitleChanges):
3015         (LayoutTestController::setDumpTitleChanges):
3016         (LayoutTestController::dumpEditingCallbacks):
3017         (LayoutTestController::setDumpEditingCallbacks):
3018         (LayoutTestController::dumpResourceLoadCallbacks):
3019         (LayoutTestController::setDumpResourceLoadCallbacks):
3020         (LayoutTestController::dumpFrameLoadCallbacks):
3021         (LayoutTestController::setDumpFrameLoadCallbacks):
3022         (LayoutTestController::addFileToPasteboardOnDrag):
3023         (LayoutTestController::setAddFileToPasteboardOnDrag):
3024         (LayoutTestController::callCloseOnWebViews):
3025         (LayoutTestController::setCallCloseOnWebViews):
3026         (LayoutTestController::canOpenWindows):
3027         (LayoutTestController::setCanOpenWindows):
3028         (LayoutTestController::closeRemainingWindowsWhenComplete):
3029         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3030         (LayoutTestController::testRepaint):
3031         (LayoutTestController::setTestRepaint):
3032         (LayoutTestController::testRepaintSweepHorizontally):
3033         (LayoutTestController::setTestRepaintSweepHorizontally):
3034         (LayoutTestController::waitToDump):
3035         (LayoutTestController::windowIsKey):
3036         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
3037         * DumpRenderTree/NavigationController.h: Removed.
3038         * DumpRenderTree/NavigationController.m: Removed.
3039         * DumpRenderTree/ObjCController.h: Removed.
3040         * DumpRenderTree/ObjCController.m: Removed.
3041         * DumpRenderTree/ObjCPlugin.h: Removed.
3042         * DumpRenderTree/ObjCPlugin.m: Removed.
3043         * DumpRenderTree/ObjCPluginFunction.h: Removed.
3044         * DumpRenderTree/ObjCPluginFunction.m: Removed.
3045         * DumpRenderTree/PolicyDelegate.h: Removed.
3046         * DumpRenderTree/PolicyDelegate.m: Removed.
3047         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
3048         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
3049         * DumpRenderTree/TextInputController.h: Removed.
3050         * DumpRenderTree/TextInputController.m: Removed.
3051         * DumpRenderTree/UIDelegate.h: Removed.
3052         * DumpRenderTree/UIDelegate.mm: Removed.
3053         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
3054         * DumpRenderTree/mac: Added.
3055         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
3056         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
3057         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
3058         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
3059         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
3060         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
3061         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3062         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3063         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3064         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3065         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3066         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3067         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3068         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3069         (-[EditingDelegate webViewDidBeginEditing:]):
3070         (-[EditingDelegate webViewDidChange:]):
3071         (-[EditingDelegate webViewDidEndEditing:]):
3072         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3073         (-[EditingDelegate webViewDidChangeSelection:]):
3074         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
3075         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
3076         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
3077         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
3078         (-[FrameLoadDelegate init]):
3079         (-[FrameLoadDelegate dealloc]):
3080         (-[FrameLoadDelegate processWork:]):
3081         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3082         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3083         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3084         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3085         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3086         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3087         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3088         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3089         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3090         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
3091         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3092         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
3093         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3094         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3095         (-[FrameLoadDelegate webView:willCloseFrame:]):
3096         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3097         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3098         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
3099         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
3100         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
3101         (LayoutTestController::notifyDone):
3102         (LayoutTestController::setWindowIsKey):
3103         (LayoutTestController::setWaitToDump):
3104         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
3105         * DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
3106         * DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
3107         * DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
3108         * DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
3109         * DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
3110         * DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
3111         * DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
3112         * DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
3113         * DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
3114         * DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
3115         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m.
3116         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3117         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3118         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3119         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3120         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3121         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3122         * DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
3123         * DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
3124         * DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
3125         * DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm.
3126         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
3127         (-[UIDelegate webViewFocus:]):
3128         (-[UIDelegate webView:createWebViewWithRequest:]):
3129         (-[UIDelegate webViewClose:]):
3130         * DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.
3131
3132 2007-09-14  Kevin McCullough  <kmccullough@apple.com>
3133
3134         Reviewed by Adam.
3135
3136         - Changing Win version of Drosera work with recent changes.
3137
3138         * Drosera/DebuggerDocument.cpp:
3139         * Drosera/DebuggerDocument.h:
3140         * Drosera/mac/DebuggerDocumentPlatform.mm:
3141         (NSStringCreateWithJSStringRef):
3142         (JSValueRefCreateWithNSString):
3143         * Drosera/win/DebuggerClient.cpp:
3144         (DebuggerClient::stepInto):
3145         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3146
3147 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
3148
3149         Reviewed by Tim.
3150
3151         - Moved isPaused into the JS for efficiency and simplicity.
3152
3153         * Drosera/DebuggerDocument.cpp:
3154         (DebuggerDocument::DebuggerDocument):
3155         (DebuggerDocument::pauseCallback):
3156         (DebuggerDocument::resumeCallback):
3157         (DebuggerDocument::isPaused):
3158         (DebuggerDocument::staticFunctions):
3159         * Drosera/DebuggerDocument.h:
3160         * Drosera/console.js:
3161         * Drosera/debugger.js:
3162         * Drosera/mac/DebuggerClient.mm:
3163         (-[DebuggerClient validateUserInterfaceItem:]):
3164
3165 2007-09-13  Sam Weinig  <sam@webkit.org>
3166
3167         Rubber stamped by Darin.
3168
3169         Make DumpRenderTree more cross platform ready.
3170         - Convert GCController to use the JSCore API instead of the WebScriptObject.
3171         - Use CF types instead of NS objects.
3172         - General cleanup.
3173
3174         * DumpRenderTree/DumpRenderTree.h:
3175         * DumpRenderTree/DumpRenderTree.mm:
3176         (dumpRenderTree):
3177         (dump):
3178         (runTest):
3179         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3180         * DumpRenderTree/EditingDelegate.m:
3181         * DumpRenderTree/FrameLoadDelegate.h:
3182         * DumpRenderTree/FrameLoadDelegate.mm:
3183         (-[FrameLoadDelegate init]):
3184         (-[FrameLoadDelegate dealloc]):
3185         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3186         * DumpRenderTree/GCController.cpp: Added.
3187         (GCController::GCController):
3188         (GCController::~GCController):
3189         (collectCallback):
3190         (collectOnAlternateThreadCallback):
3191         (getJSObjectCountCallback):
3192         (GCController::makeWindowObject):
3193         (GCController::getJSClass):
3194         (GCController::staticFunctions):
3195         * DumpRenderTree/GCController.h:
3196         * DumpRenderTree/GCController.mm:
3197         (GCController::collect):
3198         (GCController::collectOnAlternateThread):
3199         (GCController::getJSObjectCount):
3200         * DumpRenderTree/LayoutTestController.cpp:
3201         (LayoutTestController::makeWindowObject):
3202         (LayoutTestController::getJSClass):
3203         * DumpRenderTree/LayoutTestController.h:
3204         * DumpRenderTree/LayoutTestControllerMac.mm:
3205         (LayoutTestController::addDisallowedURL):
3206         (waitUntilDoneWatchdogFired):
3207         (LayoutTestController::waitUntilDone):
3208         * DumpRenderTree/ResourceLoadDelegate.m:
3209         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3210
3211 2007-09-12  Sam Weinig  <sam@webkit.org>
3212
3213         Reviewed by Stephanie.
3214
3215         Fix leaks in mac DumpRenderTree.
3216
3217         * DumpRenderTree/FrameLoadDelegate.mm:
3218         (-[FrameLoadDelegate init]): Initalize in the correct order.
3219         (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
3220         * DumpRenderTree/LayoutTestController.cpp:
3221         (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released.
3222         (encodeHostNameCallback): ditto.
3223         * DumpRenderTree/LayoutTestController.h:
3224         * DumpRenderTree/LayoutTestControllerMac.mm:
3225         (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule.
3226         (LayoutTestController::copyEncodedHostName): ditto
3227         (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.
3228
3229 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3230
3231         Reviewed by Geof.
3232
3233         - Updated Leopard leak list to include a leak which appears to be fixed in 9A549 but not the version the bot is on.  This will allow us to get the bot green, but later we should remove it.
3234
3235         * Scripts/run-webkit-tests:
3236
3237 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3238
3239         Reviewed by Darin.
3240
3241         - Simplified code paths and extracted out functions to increase encapsulation.
3242
3243         * Drosera/DebuggerDocument.cpp:
3244         (DebuggerDocument::breakpointEditorHTMLCallback):
3245         (DebuggerDocument::isPausedCallback):
3246         (DebuggerDocument::pauseCallback):
3247         (DebuggerDocument::resumeCallback):
3248         (DebuggerDocument::stepIntoCallback):
3249         (DebuggerDocument::evaluateScriptCallback):
3250         (DebuggerDocument::currentFunctionStackCallback):
3251         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3252         (DebuggerDocument::valueForScopeVariableNamedCallback):
3253         (DebuggerDocument::logCallback):
3254         * Drosera/DebuggerDocument.h:
3255         (DebuggerDocument::getPaused):
3256         * Drosera/mac/DebuggerClient.mm:
3257         (-[DebuggerClient pause:]):
3258         (-[DebuggerClient resume:]):
3259         (-[DebuggerClient stepInto:]):
3260         (-[DebuggerClient stepOver:]):
3261         (-[DebuggerClient stepOut:]):
3262         (-[DebuggerClient showConsole:]):
3263         (-[DebuggerClient closeCurrentFile:]):
3264         (-[DebuggerClient validateUserInterfaceItem:]):
3265         * Drosera/mac/DebuggerDocumentPlatform.mm: Added.
3266         (+[NSString stringOrNilFromWebScriptResult:]):
3267         (DebuggerDocument::platformPause):
3268         (DebuggerDocument::platformResume):
3269         (DebuggerDocument::platformStepInto):
3270         (DebuggerDocument::platformEvaluateScript):
3271         (DebuggerDocument::getPlatformCurrentFunctionStack):
3272         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3273         (DebuggerDocument::platformValueForScopeVariableNamed):
3274         (DebuggerDocument::platformLog):
3275         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3276
3277 2007-09-12  Sam Weinig  <sam@webkit.org>
3278
3279         Build fix for Buildbot.
3280
3281         * DumpRenderTree/DumpRenderTree.mm:
3282         (dump):
3283
3284 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
3285
3286         Reviewed by Geoff.
3287
3288         - Updated the leaks list for leopard to help identify regressions.
3289
3290         * Scripts/run-webkit-tests:
3291
3292 2007-09-12  Sam Weinig  <sam@webkit.org>
3293
3294         Rubber stamped by Darin.
3295
3296         Convert the LayoutTestController to use the JSCore API instead of WebScriptObject.
3297
3298         * DumpRenderTree/DumpRenderTree.h: Re-order variables.
3299         * DumpRenderTree/DumpRenderTree.m: Removed.
3300         * DumpRenderTree/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.m.
3301         (stopJavaScriptThreads): Fix initialization.
3302         (setDefaultColorProfileToRGB): Add explicit cast from void*.
3303         (dumpRenderTree): Ditto.
3304         (runTest):
3305         Used the WorkQueue from the windows DRT instead of the old NSMutableArray one.
3306
3307         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3308         * DumpRenderTree/FrameLoadDelegate.h: Add LayoutTestController instance variable.
3309         * DumpRenderTree/FrameLoadDelegate.m: Removed.
3310         * DumpRenderTree/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.m.
3311         (-[FrameLoadDelegate init]):
3312         (-[FrameLoadDelegate dealloc]):
3313         (-[FrameLoadDelegate processWork:]):
3314         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3315         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3316         Convert to use the new JSCore based LayoutTestController and the new WorkQueue.
3317
3318         * DumpRenderTree/LayoutTestController.cpp: Added.
3319         (LayoutTestController::LayoutTestController):
3320         (LayoutTestController::~LayoutTestController):
3321         (dumpAsTextCallback):
3322         (dumpBackForwardListCallback):
3323         (dumpChildFramesAsTextCallback):
3324         (dumpChildFrameScrollPositionsCallback):
3325         (dumpDOMAsWebArchiveCallback):
3326         (dumpEditingCallbacksCallback):
3327         (dumpFrameLoadCallbacksCallback):
3328         (dumpResourceLoadCallbacksCallback):
3329         (dumpSelectionRectCallback):
3330         (dumpSourceAsWebArchiveCallback):
3331         (dumpTitleChangesCallback):
3332         (repaintSweepHorizontallyCallback):
3333         (setCallCloseOnWebViewsCallback):
3334         (setCanOpenWindowsCallback):
3335         (setCloseRemainingWindowsWhenCompleteCallback):
3336         (testRepaintCallback):
3337         (addFileToPasteboardOnDragCallback):
3338         (addDisallowedURLCallback):
3339         (clearBackForwardListCallback):
3340         (decodeHostNameCallback):
3341         (displayCallback):
3342         (encodeHostNameCallback):
3343         (keepWebHistoryCallback):
3344         (notifyDoneCallback):
3345         (queueBackNavigationCallback):
3346         (queueForwardNavigationCallback):
3347         (queueLoadCallback):
3348         (queueReloadCallback):
3349         (queueScriptCallback):
3350         (setAcceptsEditingCallback):
3351         (setCustomPolicyDelegateCallback):
3352         (setMainFrameIsFirstResponderCallback):
3353         (setTabKeyCyclesThroughElementsCallback):
3354         (setUseDashboardCompatibilityModeCallback):
3355         (setUserStyleSheetEnabledCallback):
3356         (setUserStyleSheetLocationCallback):
3357         (setWindowIsKeyCallback):
3358         (waitUntilDoneCallback):
3359         (windowCountCallback):
3360         (LayoutTestController::makeWindowObject):
3361         (LayoutTestController::getLayoutTestControllerJSClass):
3362         (LayoutTestController::staticFunctions):
3363         * DumpRenderTree/LayoutTestController.h: Replaced.
3364         * DumpRenderTree/LayoutTestController.m: Removed.
3365         * DumpRenderTree/LayoutTestControllerMac.mm: Added.
3366         (LayoutTestController::dumpAsText):
3367         (LayoutTestController::dumpBackForwardList):
3368         (LayoutTestController::dumpChildFramesAsText):
3369         (LayoutTestController::dumpChildFrameScrollPositions):
3370         (LayoutTestController::dumpDOMAsWebArchive):
3371         (LayoutTestController::dumpEditingCallbacks):
3372         (LayoutTestController::dumpFrameLoadCallbacks):
3373         (LayoutTestController::dumpResourceLoadCallbacks):
3374         (LayoutTestController::dumpSelectionRect):
3375         (LayoutTestController::dumpSourceAsWebArchive):
3376         (LayoutTestController::dumpTitleChanges):
3377         (LayoutTestController::repaintSweepHorizontally):
3378         (LayoutTestController::setCallCloseOnWebViews):
3379         (LayoutTestController::setCanOpenWindows):
3380         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3381         (LayoutTestController::testRepaint):
3382         (LayoutTestController::addFileToPasteboardOnDrag):
3383         (LayoutTestController::addDisallowedURL):
3384         (LayoutTestController::clearBackForwardList):
3385         (LayoutTestController::decodeHostName):
3386         (LayoutTestController::encodeHostName):
3387         (LayoutTestController::display):
3388         (LayoutTestController::keepWebHistory):
3389         (LayoutTestController::notifyDone):
3390         (LayoutTestController::queueBackNavigation):
3391         (LayoutTestController::queueForwardNavigation):
3392         (LayoutTestController::queueLoad):
3393         (LayoutTestController::queueReload):
3394         (LayoutTestController::queueScript):
3395         (LayoutTestController::setAcceptsEditing):
3396         (LayoutTestController::setCustomPolicyDelegate):
3397         (LayoutTestController::setMainFrameIsFirstResponder):
3398         (LayoutTestController::setTabKeyCyclesThroughElements):
3399         (LayoutTestController::setUseDashboardCompatibilityMode):
3400         (LayoutTestController::setUserStyleSheetEnabled):
3401         (LayoutTestController::setUserStyleSheetLocation):
3402         (LayoutTestController::setWindowIsKey):
3403         (+[WaitToDumpWatchdog waitUntilDoneWatchdogFired]):
3404         (LayoutTestController::waitUntilDone):
3405         (LayoutTestController::windowCount):
3406         Use the JSCore API to implement the LayoutTestController.
3407
3408         * DumpRenderTree/ObjCController.h:
3409         * DumpRenderTree/ObjCController.m:
3410         (+[ObjCController isSelectorExcludedFromWebScript:]):
3411         (+[ObjCController webScriptNameForSelector:]):
3412         (-[ObjCController accessStoredWebScriptObject]):
3413         (-[ObjCController storeWebScriptObject:]):
3414         (-[ObjCController dealloc]):
3415         (-[ObjCController invokeUndefinedMethodFromWebScript:withArguments:]):
3416         Move WebScriptObject tests to ObjCController.
3417
3418         * DumpRenderTree/UIDelegate.m: Removed.
3419         * DumpRenderTree/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.m.
3420
3421         * DumpRenderTree/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
3422         * DumpRenderTree/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
3423         * DumpRenderTree/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
3424         (WorkQueueItem::~WorkQueueItem):
3425         (LoadItem::LoadItem):
3426         (LoadItem::url):
3427         (LoadItem::target):
3428         (ScriptItem::ScriptItem):
3429         (ScriptItem::script):
3430         * DumpRenderTree/WorkQueueItemMac.mm: Added.
3431         (LoadItem::invoke):
3432         (ReloadItem::invoke):
3433         (ScriptItem::invoke):
3434         (BackForwardItem::invoke):
3435         Copy WorkQueue and WorkQueueItem from windows DRT. Changed the WorkQueueItem to use JSStringRefs instead of wstrings
3436         to avoid conversion until the last possible moment.  These changes will be merged with the windows DRT when we start
3437         sharing code.
3438
3439 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
3440
3441         Reviewed by Maciej.
3442
3443         - Updated Win side to take advantage of the platform separating changes.
3444
3445         * Drosera/DebuggerDocument.cpp:
3446         (DebuggerDocument::localScopeVariableNamesForCallFrame):
3447         * Drosera/DebuggerDocument.h:
3448         * Drosera/win/DebuggerClient.cpp:
3449         (DebuggerClient::pause):
3450         (DebuggerClient::resume):
3451         (DebuggerClient::stepInto):
3452         (DebuggerDocument::platformPause):
3453         (DebuggerDocument::platformResume):
3454         (DebuggerDocument::platformStepInto):
3455         (DebuggerDocument::platformEvaluateScript):
3456         (DebuggerDocument::getPlatformCurrentFunctionStack):
3457         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3458         (DebuggerDocument::platformValueForScopeVariableNamed):
3459         (DebuggerDocument::platformLog):
3460         * Drosera/win/DebuggerClient.h:
3461         * Drosera/win/Drosera.cpp:
3462         (Drosera::Drosera):
3463         (Drosera::windowScriptObjectAvailable):
3464         (Drosera::initWithServerName):
3465         (Drosera::switchToServerNamed):
3466         * Drosera/win/Drosera.h:
3467         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3468
3469 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
3470
3471         Reviewed by Adam.
3472
3473         - Just doing the moves in a separate patch so the changes are easier to see.
3474
3475         * Drosera/win/DebuggerClient.cpp: Copied from Drosera/win/DebuggerDocumentWin.cpp.
3476         * Drosera/win/DebuggerClient.h: Copied from Drosera/win/DebuggerDocumentWin.h.
3477         * Drosera/win/DebuggerDocumentWin.cpp: Removed.
3478         * Drosera/win/DebuggerDocumentWin.h: Removed.
3479         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3480
3481 2007-09-11  Sven Herzberg  <sven@imendio.com>
3482
3483         Don't overwrite LD_LIBRARY_PATH, prepend to it. Fixes:
3484         http://bugs.webkit.org/show_bug.cgi?id=15176
3485
3486         * Scripts/run-launcher: don't replace LD_LIBRARY_PATH with
3487         $projectDir, but prepend $projectDir to LD_LIBRARY_PATH (to preserve
3488         other paths eg. from jhbuild)
3489
3490 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
3491
3492         Reviewed by Adam.
3493
3494         - Made an order-of-deletion mistake.
3495
3496         * Drosera/DebuggerDocument.h:
3497         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
3498         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
3499         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
3500         * Drosera/mac/DebuggerClient.mm:
3501         (DebuggerDocument::platformPause):
3502         (DebuggerDocument::platformResume):
3503         (DebuggerDocument::platformStepInto):
3504         (DebuggerDocument::platformEvaluateScript):
3505         (DebuggerDocument::getPlatformCurrentFunctionStack):
3506         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3507         (DebuggerDocument::platformValueForScopeVariableNamed):
3508         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3509
3510 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
3511
3512         Reviewed by Darin.
3513
3514         - Renaming DebuggerDocument[platform] to DebuggerClient to be more clear.
3515
3516         * Drosera/DebuggerDocument.cpp:
3517         (DebuggerDocument::DebuggerDocument):
3518         * Drosera/DebuggerDocument.h:
3519         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
3520         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
3521         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
3522         * Drosera/mac/DebuggerApplication.mm:
3523         (-[DebuggerApplication attach:]):
3524         * Drosera/mac/DebuggerClient.h: Copied from Drosera/mac/DebuggerDocumentMac.h.
3525         * Drosera/mac/DebuggerClient.mm: Copied from Drosera/mac/DebuggerDocumentMac.mm.
3526         (DebuggerDocument::platformPause):
3527         (DebuggerDocument::platformResume):
3528         (DebuggerDocument::platformStepInto):
3529         (DebuggerDocument::platformEvaluateScript):
3530         (DebuggerDocument::getPlatformCurrentFunctionStack):
3531         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3532         (DebuggerDocument::platformValueForScopeVariableNamed):
3533         (DebuggerDocument::platformLog):
3534         * Drosera/mac/DebuggerDocumentMac.h: Removed.
3535         * Drosera/mac/DebuggerDocumentMac.mm: Removed.
3536         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3537
3538 2007-09-09  Sam Weinig  <sam@webkit.org>
3539
3540         Reviewed by Mark Rowe.
3541
3542         Remove 'objC' prefix from methods now in the ObjCController.
3543
3544         * DumpRenderTree/ObjCController.m:
3545         (+[ObjCController isSelectorExcludedFromWebScript:]):
3546         (+[ObjCController webScriptNameForSelector:]):
3547         (-[ObjCController classNameOf:]):
3548         (-[ObjCController objectOfClass:]):
3549         (-[ObjCController identityIsEqual::]):
3550         (-[ObjCController longLongRoundTrip:]):
3551         (-[ObjCController unsignedLongLongRoundTrip:]):
3552
3553 2007-09-09  Sam Weinig  <sam@webkit.org>
3554
3555         Reviewed by Oliver.
3556
3557         Initial refactor of DumpRenderTree in preparation of making it more platform independent.
3558         - Move LayoutTestController into its own file.
3559         - Move Objective-C only functions on LayoutTestController into a new controller called the
3560           ObjCController.
3561
3562         * DumpRenderTree/DumpRenderTree.h:
3563         * DumpRenderTree/DumpRenderTree.m:
3564         (displayWebView):
3565         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3566         * DumpRenderTree/FrameLoadDelegate.m:
3567         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3568         * DumpRenderTree/LayoutTestController.h: Added.
3569         * DumpRenderTree/LayoutTestController.m: Added.
3570         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
3571         (+[LayoutTestController webScriptNameForSelector:]):
3572         (-[LayoutTestController clearBackForwardList]):
3573         (-[LayoutTestController setUseDashboardCompatibilityMode:]):
3574         (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]):
3575         (-[LayoutTestController setCustomPolicyDelegate:]):
3576         (-[LayoutTestController keepWebHistory]):
3577         (-[LayoutTestController setCallCloseOnWebViews:]):
3578         (-[LayoutTestController setCanOpenWindows]):
3579         (-[LayoutTestController waitUntilDone]):
3580         (-[LayoutTestController waitUntilDoneWatchdogFired]):
3581         (-[LayoutTestController notifyDone]):
3582         (-[LayoutTestController dumpAsText]):
3583         (-[LayoutTestController addFileToPasteboardOnDrag]):
3584         (-[LayoutTestController addDisallowedURL:]):
3585         (-[LayoutTestController setUserStyleSheetLocation:]):
3586         (-[LayoutTestController setUserStyleSheetEnabled:]):
3587         (-[LayoutTestController dumpDOMAsWebArchive]):
3588         (-[LayoutTestController dumpSourceAsWebArchive]):
3589         (-[LayoutTestController dumpSelectionRect]):
3590         (-[LayoutTestController dumpTitleChanges]):
3591         (-[LayoutTestController dumpBackForwardList]):
3592         (-[LayoutTestController windowCount]):
3593         (-[LayoutTestController dumpChildFrameScrollPositions]):
3594         (-[LayoutTestController dumpChildFramesAsText]):
3595         (-[LayoutTestController dumpEditingCallbacks]):
3596         (-[LayoutTestController dumpResourceLoadCallbacks]):
3597         (-[LayoutTestController dumpFrameLoadCallbacks]):
3598         (-[LayoutTestController setWindowIsKey:]):
3599         (-[LayoutTestController setMainFrameIsFirstResponder:]):
3600         (-[LayoutTestController display]):
3601         (-[LayoutTestController testRepaint]):
3602         (-[LayoutTestController repaintSweepHorizontally]):
3603         (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]):
3604         (-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]):
3605         (-[LayoutTestController _doLoad:target:]):
3606         (-[LayoutTestController _doBackOrForwardNavigation:]):
3607         (-[LayoutTestController queueBackNavigation:]):
3608         (-[LayoutTestController queueForwardNavigation:]):
3609         (-[LayoutTestController queueReload]):
3610         (-[LayoutTestController queueScript:]):
3611         (-[LayoutTestController queueLoad:target:]):
3612         (-[LayoutTestController setAcceptsEditing:]):
3613         (-[LayoutTestController setTabKeyCyclesThroughElements:]):
3614         (-[LayoutTestController storeWebScriptObject:]):
3615         (-[LayoutTestController accessStoredWebScriptObject]):
3616         (-[LayoutTestController dealloc]):
3617         (-[LayoutTestController decodeHostName:]):
3618         (-[LayoutTestController encodeHostName:]):
3619         * DumpRenderTree/ObjCController.h: Added.
3620         * DumpRenderTree/ObjCController.m: Added.
3621         (+[ObjCController isSelectorExcludedFromWebScript:]):
3622         (+[ObjCController webScriptNameForSelector:]):
3623         (-[ObjCController objCClassNameOf:]):
3624         (-[ObjCController objCObjectOfClass:]):
3625         (-[ObjCController objCIdentityIsEqual::]):
3626         (-[ObjCController objCLongLongRoundTrip:]):
3627         (-[ObjCController objCUnsignedLongLongRoundTrip:]):
3628         (-[ObjCController testWrapperRoundTripping:]):
3629
3630 2007-09-07  Sam Weinig  <sam@webkit.org>
3631
3632         Reviewed by Alice.
3633
3634         Strip trailing and leading space/newline characters from skiplist file names.
3635
3636         * Scripts/run-webkit-tests:
3637
3638 2007-09-06  Kevin McCullough  <kmccullough@apple.com>
3639
3640         Reviewed by Maciej.
3641
3642         - Changed Drosera to take advantage of the JSRetainPtr changes.
3643
3644         * Drosera/DebuggerDocument.cpp:
3645         (DebuggerDocument::breakpointEditorHTML):
3646         (DebuggerDocument::evaluateScript):
3647         (DebuggerDocument::valueForScopeVariableNamed):
3648         (DebuggerDocument::log):
3649         (DebuggerDocument::windowScriptObjectAvailable):
3650         (DebuggerDocument::toJSArray):
3651         (DebuggerDocument::callFunctionOnObject):
3652         (DebuggerDocument::logException):
3653         * Drosera/mac/DebuggerDocumentMac.mm:
3654         (-[DebuggerClientMac webView:didLoadMainResourceForDataSource:]):
3655         (-[DebuggerClientMac webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3656         (DebuggerDocument::platformEvaluateScript):
3657         (DebuggerDocument::getPlatformCurrentFunctionStack):
3658         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3659         (DebuggerDocument::platformValueForScopeVariableNamed):
3660
3661 2007-09-05  Kevin McCullough  <kmccullough@apple.com>
3662
3663         Reviewed by Adam, Sam, Darin.
3664
3665         - Separated what is platform dependant from what is not.  Creating the structure needed for Drosera for Win.
3666
3667         * Drosera/Debugger.h: Added.
3668         * Drosera/DebuggerDocument.cpp:
3669         (DebuggerDocument::breakpointEditorHTMLCallback):
3670         (DebuggerDocument::isPausedCallback):
3671         (DebuggerDocument::pauseCallback):
3672         (DebuggerDocument::resumeCallback):
3673         (DebuggerDocument::stepIntoCallback):
3674         (DebuggerDocument::evaluateScriptCallback):
3675         (DebuggerDocument::currentFunctionStackCallback):
3676         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3677         (DebuggerDocument::valueForScopeVariableNamedCallback):
3678         (DebuggerDocument::logCallback):
3679         (DebuggerDocument::breakpointEditorHTML):
3680         (DebuggerDocument::isPaused):
3681         (DebuggerDocument::pause):
3682         (DebuggerDocument::resume):
3683         (DebuggerDocument::stepInto):
3684         (DebuggerDocument::evaluateScript):
3685         (DebuggerDocument::currentFunctionStack):
3686         (DebuggerDocument::localScopeVariableNamesForCallFrame):
3687         (DebuggerDocument::valueForScopeVariableNamed):
3688         (DebuggerDocument::log):
3689         (DebuggerDocument::toolbarPause):
3690         (DebuggerDocument::toolbarResume):
3691         (DebuggerDocument::toolbarStepInto):
3692         (DebuggerDocument::toolbarStepOver):
3693         (DebuggerDocument::toolbarStepOut):
3694         (DebuggerDocument::toolbarShowConsole):
3695         (DebuggerDocument::toolbarCloseCurrentFile):
3696         (DebuggerDocument::updateFileSource):
3697         (DebuggerDocument::didParseScript):
3698         (DebuggerDocument::willExecuteStatement):
3699         (DebuggerDocument::didEnterCallFrame):
3700         (DebuggerDocument::willLeaveCallFrame):
3701         (DebuggerDocument::exceptionWasRaised):
3702         (DebuggerDocument::windowScriptObjectAvailable):
3703         (DebuggerDocument::toJSArray):
3704         (DebuggerDocument::callGlobalFunction):
3705         (DebuggerDocument::callFunctionOnObject):
3706         (DebuggerDocument::getDroseraJSClass):
3707         (DebuggerDocument::staticFunctions):
3708         (DebuggerDocument::logException):
3709         * Drosera/DebuggerDocument.h:
3710         (DebuggerDocument::DebuggerDocument):
3711         * Drosera/ForwardingHeaders: Added.
3712         * Drosera/ForwardingHeaders/wtf: Added.
3713         * Drosera/ForwardingHeaders/wtf/Platform.h: Added.
3714         * Drosera/config.h:
3715         * Drosera/console.html:
3716         * Drosera/console.js:
3717         * Drosera/debugger.js:
3718         * Drosera/mac/DebuggerApplication.mm:
3719         (-[DebuggerApplication attach:]):
3720         * Drosera/mac/DebuggerDocumentMac.h:
3721         * Drosera/mac/DebuggerDocumentMac.mm:
3722         (+[NSString stringOrNilFromWebScriptResult:]):
3723         (+[DebuggerClientMac log:]):
3724         (-[DebuggerClientMac initWithServerName:]):
3725         (-[DebuggerClientMac dealloc]):
3726         (-[DebuggerClientMac pause]):
3727         (-[DebuggerClientMac resume]):
3728         (-[DebuggerClientMac pause:]):
3729         (-[DebuggerClientMac resume:]):
3730         (-[DebuggerClientMac stepInto:]):
3731         (-[DebuggerClientMac stepOver:]):
3732         (-[DebuggerClientMac stepOut:]):
3733         (-[DebuggerClientMac showConsole:]):
3734         (-[DebuggerClientMac closeCurrentFile:]):
3735         (-[DebuggerClientMac validateUserInterfaceItem:]):
3736         (-[DebuggerClientMac webView:windowScriptObjectAvailable:]):
3737         (-[DebuggerClientMac webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3738         (-[DebuggerClientMac webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3739         (-[DebuggerClientMac webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3740         (-[DebuggerClientMac webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3741         (DebuggerDocument::platformPause):
3742         (DebuggerDocument::platformResume):
3743         (DebuggerDocument::platformStepInto):
3744         (DebuggerDocument::platformEvaluateScript):
3745         (DebuggerDocument::platformCurrentFunctionStack):
3746         (DebuggerDocument::platformLocalScopeVariableNamesForCallFrame):
3747         (DebuggerDocument::platformValueForScopeVariableNamed):
3748         (DebuggerDocument::platformLog):
3749         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3750
3751 2007-09-06  Sam Weinig  <sam@webkit.org>
3752
3753         Reviewed by Adam Roben.
3754
3755         Register the WebKit DLL on initialization of the DumpRenderTree.
3756
3757         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3758         (initialize):
3759
3760 2007-09-05  Sam Weinig  <sam@webkit.org>
3761
3762         Reviewed by Oliver.
3763
3764         Fix many layout test failures caused by r25364.
3765         Set text size to standand size at the begining of each test matching the mac.
3766
3767         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3768         (runTest):
3769
3770 2007-09-04  Sam Weinig  <sam@webkit.org>
3771
3772         Reviewed by Adam.
3773
3774         Fix for <rdar://problem/5382277>
3775         Implement eventSender.textZoomIn and eventSender.textZoomOut for windows DRT.
3776
3777         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp:
3778         (textZoomInCallback):
3779         (textZoomOutCallback):
3780
3781 2007-08-29  David Kilzer  <ddkilzer@apple.com>
3782
3783         Reviewed by Adam.
3784
3785         Added case-insensitivity to checks for adding regression tests.
3786
3787         * Scripts/prepare-ChangeLog:
3788         (generateFileList):
3789
3790 2007-08-28  David Kilzer  <ddkilzer@apple.com>
3791
3792         Reviewed by Maciej.
3793
3794         Ignore files in /resources/ subdirectories when creating a list of added tests.
3795
3796         * Scripts/prepare-ChangeLog:
3797         (generateFileList):
3798
3799 2007-08-27  Kevin McCullough  <kmccullough@apple.com>
3800
3801         Reviewed by John.
3802
3803         - Removed Leopard leaks list since all of those radars were fixed.
3804
3805         * Scripts/run-webkit-tests:
3806
3807 2007-08-27  Adam Roben  <aroben@apple.com>
3808
3809         Rubberstamped by Mark.
3810
3811         * Scripts/pdevenv: Pass arguments along to devenv.com.
3812
3813 2007-08-26  David Kilzer  <ddkilzer@webkit.org>
3814
3815         Reviewed by Mark Rowe.
3816
3817         Update prepare-ChangeLog to generate the datestamp in the correct timezone.
3818
3819         * Scripts/prepare-ChangeLog:
3820         (changeLogDate): Added.
3821
3822 2007-08-24  Sam Weinig  <sam@webkit.org>
3823
3824         Revert r25216 which renamed the COM DOM bindings to use Deprecated prefix.
3825
3826 2007-08-24  Sam Weinig  <sam@webkit.org>
3827
3828         Rubber-stamped by Adam Roben.
3829
3830         <rdar://problem/5434593> Deprecate current manually written COM DOM bindings in anticipation of autogeneration
3831
3832         Rename COM DOM bindings to use Deprecated prefix.
3833
3834         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3835         (dumpFramesAsText):
3836         (dump):
3837         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp:
3838         (dumpPath):
3839         (dump):
3840         (EditingDelegate::shouldBeginEditingInDOMRange):
3841         (EditingDelegate::shouldEndEditingInDOMRange):
3842         (EditingDelegate::shouldInsertNode):
3843         (EditingDelegate::shouldInsertText):
3844         (EditingDelegate::shouldDeleteDOMRange):
3845         (EditingDelegate::shouldChangeSelectedDOMRange):
3846         (EditingDelegate::shouldApplyStyle):
3847         (EditingDelegate::shouldChangeTypingStyle):
3848         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h:
3849
3850 2007-08-24  Oliver Hunt  <oliver@apple.com>
3851
3852         Reviewed by John H.
3853
3854         WebDataSource::response can legitimately have a null response, so we
3855         must check that case.
3856
3857         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
3858         (queueLoadCallback):
3859
3860 2007-08-23  Mitz Pettel  <mitz@webkit.org>
3861
3862         Reviewed by Darin and Adam.
3863
3864         - DumpRenderTree changes to allow testing for
3865           http://bugs.webkit.org/show_bug.cgi?id=11756
3866           REGRESSION: link targeting a frame in another window does not work
3867           <rdar://problem/5286420>
3868
3869         Use a frame group name for all WebViews created by DumpRenderTree to
3870         allow testing of cross-page frame lookup.
3871
3872         * DumpRenderTree/DumpRenderTree.m:
3873         (createWebView): Pass group name to -[WebView initWithFrame:frameName:groupName:].
3874         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3875         (main): Pass group name to WebView::initWithFrame(RECT, BSTR, BSTR).
3876
3877 2007-08-23  David Kilzer  <ddkilzer@webkit.org>
3878
3879         Reviewed by Adam.
3880
3881         Quote the $sslCertificate path in case it contains a space.
3882
3883         * Scripts/run-webkit-httpd:
3884         * Scripts/run-webkit-tests:
3885
3886 2007-08-22  Oliver Hunt  <oliver@apple.com>
3887
3888         Reviewed by John and Adam.
3889
3890         WebDataSource::response can legitimately have a null response, so we
3891         must check that case.
3892
3893         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3894         (dump):
3895
3896 2007-08-21  Kevin McCullough  <kmccullough@apple.com>
3897
3898         Reviewed by Geof.
3899
3900         - Changing the usage to be more clear.
3901
3902         * Scripts/run-testkjs:
3903
3904 2007-08-20  John Sullivan  <sullivan@apple.com>
3905
3906         Reviewed by Adam Roben
3907
3908         * DumpRenderTree/DumpRenderTree.m:
3909         (runTest):
3910         call new +[WebView _setUsesTestModeFocusRingColor:YES] so we get the same focus ring colors
3911         in layout tests on Tiger and Leopard
3912
3913 2007-08-20  Adam Roben  <aroben@apple.com>
3914
3915         Put LayoutTests after all other ChangeLogs in commit logs
3916
3917         We use "~" to sort LayoutTests after all the other ChangeLogs because
3918         "~" is the last ASCII character (other than "DEL").
3919
3920         Reviewed by Sam.
3921
3922         * Scripts/commit-log-editor:
3923
3924 2007-08-20  Adam Roben  <aroben@apple.com>
3925
3926         Detect that DRT crashed even if a crash dialog is running
3927
3928         On Windows, when DRT crashes a crash dialog commonly appears. The DRT
3929         process is still running at this point, so run-webkit-tests wouldn't
3930         detect that DRT had crashed. We now record the crash in our SIGPIPE
3931         handler so that we know if DRT crashed even if the crash dialog is up.
3932
3933         Reviewed by Sam.
3934
3935         * Scripts/run-webkit-tests:
3936         (sub catch_pipe): Set the crashed bit.
3937         (sub openDumpTool): Reset the crashed bit.
3938         (sub dumpToolDidCrash): Check the crashed bit.
3939
3940 2007-08-20  Adam Roben  <aroben@apple.com>
3941
3942         Fix Bug 15026: prepare-ChangeLog should list new tests in WebCore/ChangeLog
3943
3944         http://bugs.webkit.org/show_bug.cgi?id=15026
3945
3946         Reviewed by David Kilzer and Darin Adler.
3947
3948         * Scripts/prepare-ChangeLog:
3949         (sub isModifiedStatus): Split out from isModifiedOrAddedStatus.
3950         (sub isAddedStatus): Ditto.
3951         (sub testListForChangeLog): Added.
3952
3953 2007-08-19  Oleg Sukhodolsky  <son.two@gmail.com>
3954
3955         Reviewed by Mark.
3956
3957         -fixes http://bugs.webkit.org/show_bug.cgi?id=14632
3958
3959         * Scripts/webkitdirs.pm:
3960         qt and gtk ports now explicitly pass debug (or release) mode to qmake.
3961
3962 2007-08-17  Darin Adler  <darin@apple.com>
3963
3964         Reviewed by Oliver Hunt.
3965
3966         - don't look for Apple-style localizable strings in the GTK version of WebKit
3967
3968         * Scripts/extract-localizable-strings: Add a feature where you can pass in the
3969         name of subdirectories to skip.
3970         * Scripts/update-webkit-localizable-strings: Pass WebKit/gtk as a subdirectory
3971         to skip.
3972
3973 2007-08-17  Anders Carlsson  <andersca@apple.com>
3974
3975         Build fix.
3976
3977         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3978         (NPP_SetWindow):
3979
3980 2007-08-17  Anders Carlsson  <andersca@apple.com>
3981
3982         Reviewed by Dave Hyatt.
3983
3984         <rdar://problem/5379040>
3985         REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes
3986
3987         Add a way for the plug-in to dump the width and height when it gets its  NPP_SetWindow call.
3988
3989         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
3990         (pluginAllocate):
3991         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3992         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3993         (NPP_New):
3994         (NPP_SetWindow):
3995
3996 2007-08-16  Alice Liu  <alice.liu@apple.com>
3997
3998         Reviewed by Maciej.
3999
4000         Fix <rdar://problem/5360135> REGRESSION (Leopard only): editing/selection/5354455-1.html is causing subsequent tests to fail
4001
4002         * DumpRenderTree/DumpRenderTree.m:
4003         (createWebView):
4004         Create a DumpRenderTreeWindow instead of a NSWindow, now that a DumpRenderTreeWindow no longer poses as a NSWindow.
4005         (dumpRenderTree):
4006         Don't pose as a NSWindow, since when the spelling panel gets created, it creates an NSWindow which ends up creating a DumpRenderTreeWindow.
4007
4008 2007-08-16  Kevin McCullough  <kmccullough@apple.com>
4009
4010         Reviewed by Adam.
4011
4012         - Added tests for regressions in other components.  In this case we also need to add a skipped list for Tiger since this functionality didn't exist in 10.4.
4013
4014         * Scripts/run-webkit-tests:
4015
4016 2007-08-15  Timothy Hatcher  <timothy@apple.com>
4017
4018         Look for the new Xcode 3 preference key (PBXApplicationwideBuildSettings) for the global build locations.
4019         The value of PBXApplicationwideBuildSettings is a dictionary, so we have to pull the SYMROOT out of it.
4020
4021         Also pass xcodebuild OBJROOT with the same value as SYMROOT if we fallback to the default WebKitBuild,
4022         this prevents making "build" directories in each project folder.
4023
4024         * Scripts/webkitdirs.pm:
4025
4026 2007-08-14  Geoffrey Garen  <ggaren@apple.com>
4027
4028         Reviewed by Kevin Mccullough.
4029
4030         Removed special case that didn't belong. (It would allow a global
4031         initializer to sneak into production builds, which would cause a
4032         system-wide performance regression on Mac OS X.)
4033
4034         * Scripts/check-for-global-initializers:
4035
4036 2007-08-14  Justin Garcia  <justin.garcia@apple.com>
4037
4038         Reviewed by Tim.
4039
4040         <rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element
4041
4042         * DumpRenderTree/EditingDelegate.m:
4043         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Added, return YES
4044         only for elements with the class needsDeletionUI.
4045
4046 2007-08-14  David Kilzer  <ddkilzer@webkit.org>
4047
4048         Reviewed by Darin.
4049
4050         - fix http://bugs.webkit.org/show_bug.cgi?id=14965
4051           svn-create-patch uses deprecated tail switch
4052
4053         * Scripts/svn-create-patch: Use 'tail -n +3' instead of 'tail +3'.
4054
4055 2007-08-13  Sam Weinig  <sam@webkit.org>
4056
4057         Reviewed by Adam Roben.
4058
4059         Use the cygwin specific Apache config file under cygwin.
4060
4061         * Scripts/run-webkit-httpd:
4062
4063 2007-08-12  Adam Roben  <aroben@apple.com>
4064
4065         Generate results for new tests in a more logical location
4066
4067         New platform-specific tests always have their results generated right
4068         next to the test. New cross-platform tests will have their results
4069         generated a) in the cross-platform directory, if they are text-only,
4070         or b) in the least-specific platform directory, if they are render
4071         tree dumps.
4072
4073         Reviewed by Lars.
4074
4075         * Scripts/run-webkit-tests:
4076
4077 2007-08-12  Adam Roben  <aroben@apple.com>
4078
4079         Print the actual directory where new results are generated.
4080
4081         Before, we were printing an unpredictable, context-specific substring
4082         of the directory.
4083
4084         Reviewed by Lars.
4085
4086         * Scripts/run-webkit-tests:
4087
4088 2007-08-12  Adam Roben  <aroben@apple.com>
4089
4090         Factor some common code into a stripExtension() subroutine.
4091
4092         Reviewed by Lars.
4093
4094         * Scripts/run-webkit-tests: Also removed some debugging output.
4095
4096 2007-08-11  Matt Lilek  <pewtermoose@gmail.com>
4097
4098         Reviewed over and over and over by Adam Roben.
4099
4100         Bug 14740: Hierarchical layout tests and platform organization
4101         http://bugs.webkit.org/show_bug.cgi?id=14740
4102
4103         Add support for platform-specific layout tests and results.
4104
4105         * Scripts/run-webkit-tests:
4106
4107 2007-08-11  David Kilzer  <ddkilzer@webkit.org>
4108
4109         Reviewed by Adam.
4110
4111         Refactored svn-create-path to use a hash-of-hashes data structure to keep
4112         track of changed files.  In the top level hash, keys are paths to files and
4113         values are 'fileData' hashes with the following keys and values:
4114
4115         - isBinary: boolean value (set to true for non-text files like images, etc.)
4116         - isTestFile: boolean value (set to true if file exists within a known test
4117           directory)
4118         - modificationType: string equal to one of 'addition', 'additionWithHistory',
4119           'modification' or 'deletion'
4120         - path: string equal to the path to the file (this may seem redundant, but it
4121           is required to use the second-level 'fileData' hash independent of the
4122           top-level hash)
4123         - sourceFile: [optional] string equal to the path of the original file that was
4124           copied or moved
4125         - sourceRevision: [optional] string equal to the revision of the original file
4126           that was copied or moved
4127
4128         * Scripts/svn-create-patch: Moved call to GetOptions() to its own statement
4129         that saves the return value in $result, then checks it before printing help.
4130         Combined sourceFiles, %testFiles, and %binaryFiles into single %diffFiles hash
4131         and eliminated two for() loops.
4132         (binarycmp): Added.  Used with sort() to order non-binary files before binary
4133         files.
4134         (findBaseUrl): Added.  Extracted from findSourceFileAndRevision().
4135         (findMimeType): Added optional second argument that takes a revision number.
4136         (generateDiff): Updated to take one fileData argument instead of three ($file,
4137         $modificationType, $isBinary).
4138         (generateFileList): Updated to take one hash ref argument (%diffFiles)
4139         instead of three (%sourceFiles, %testFiles, %binaryFiles).  Populates
4140         %diffFiles using paths for keys and fileData hashes for values.
4141         (manufacturePatchForAdditionWithHistory): Updated to take one fileData
4142         argument.
4143         (pathcmp): Updated to take two fileData arguments instead of two strings.
4144         (testfilecmp): Added.  Used with sort() to order non-test files before test
4145         files.
4146
4147 2007-08-11  Darin Adler  <darin@apple.com>
4148
4149         * Scripts/run-webkit-tests: Give a different message when only the pixel test failed.
4150
4151 2007-08-06  Nigel Tao  <nigeltao@gnome.org>
4152
4153         Reviewed by David Kilzer.
4154
4155         Fix bug 14745: WebKitTools/Scripts/run-launcher doesn't speak --gdk
4156         http://bugs.webkit.org/show_bug.cgi?id=14745
4157
4158         * Scripts/run-launcher:
4159         Scrub the "--gdk" out of the command line args, if given, so that
4160         GdkLauncher doesn't try to interpret it as a URL.
4161
4162 2007-08-03  Adam Roben  <aroben@apple.com>
4163
4164         Catch SIGPIPE on Windows so that run-webkit-tests doesn't quit when DRT crashes
4165
4166         Reviewed by Sam.
4167
4168         * Scripts/run-webkit-tests: Also close ERROR when we finish running the tests.
4169
4170 2007-08-03  Sam Weinig  <sam@webkit.org>
4171
4172         Reviewed by Darin.
4173
4174         Recursively dump all frames as text using new
4175         layoutTestController.dumpChildFramesAsText() function.
4176
4177         * DumpRenderTree/DumpRenderTree.m:
4178         (dumpFramesAsText):
4179         (dump):
4180         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
4181         (-[LayoutTestController dumpChildFramesAsText]):
4182         (runTest):