678058ab30f629925e5761b6e0c15cc70131c25f
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-12-09  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
2
3         Reviewed by Alexey Proskuryakov.
4
5         Ignore WML tests, if no WML support available.
6
7         * Scripts/run-webkit-tests:
8
9 2008-12-08  Geoffrey Garen  <ggaren@apple.com>
10
11         Reviewed by Oliver Hunt.
12         
13         Added a shortcut for --jsDriver-args, which I use a lot.
14
15         * Scripts/run-javascriptcore-tests:
16
17 2008-12-08  Stephanie Lewis  <slewis@apple.com>
18
19         Fix Tiger build.
20
21         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
22
23 2008-12-08  Darin Adler  <darin@apple.com>
24
25         Reviewed by John Sullivan.
26
27         - test machinery for https://bugs.webkit.org/show_bug.cgi?id=22409
28           REGRESSION: cmd-shift-left/right don't switch tabs, instead select text
29
30         * DumpRenderTree/LayoutTestController.cpp:
31         (isCommandEnabledCallback): Added.
32         (LayoutTestController::staticFunctions): Added "isCommandEnabled".
33         * DumpRenderTree/LayoutTestController.h: Ditto.
34         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
35         (LayoutTestController::isCommandEnabled): Ditto.
36         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
37         (-[CommandValidationTarget initWithAction:]): Added. Used to get the
38         command validation system to tell us if a comment is enabled.
39         (-[CommandValidationTarget action]): Ditto.
40         (-[CommandValidationTarget tag]): Ditto.
41         (LayoutTestController::isCommandEnabled): Ditto.
42         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
43         (LayoutTestController::isCommandEnabled): Ditto.
44
45 2008-12-08  David Kilzer  <ddkilzer@apple.com>
46
47         Bug 22555: Sort "children" sections in Xcode project files
48
49         <https://bugs.webkit.org/show_bug.cgi?id=22555>
50
51         Reviewed by Eric Seidel.
52
53         * DrawTest/DrawTest.xcodeproj/project.pbxproj: Sorted.
54         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Sorted.
55         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Sorted.
56
57 2008-12-08  David Kilzer  <ddkilzer@apple.com>
58
59         Bug 22555: Sort "children" sections in Xcode project files
60
61         <https://bugs.webkit.org/show_bug.cgi?id=22555>
62
63         Reviewed by Timothy Hatcher.
64
65         * Scripts/sort-Xcode-project-file: By popular request, don't sort
66         the mainGroup in the project (the list of items below the top-level
67         project file).
68
69 2008-12-05  David Kilzer  <ddkilzer@apple.com>
70
71         Bug 22555: Sort "children" sections in Xcode project files
72
73         <https://bugs.webkit.org/show_bug.cgi?id=22555>
74
75         Reviewed by Darin Adler.
76
77         Sort "children" sections alphabetically, moving groups (folders) to
78         the top of each of the lists.  Files are assumed to have extensions,
79         so %isFile is used to override this behavior.
80
81         * Scripts/sort-Xcode-project-file:
82         (sortChildrenByFileName): Added.
83         (sortFilesByFileName): Renamed from sortByFileName().
84
85 2008-12-05  Eric Seidel  <eric@webkit.org>
86
87         Reviewed by Geoff Garen.
88         
89         https://bugs.webkit.org/show_bug.cgi?id=22683
90         Fix gtk and qt builds which depend on --qt and --gtk being removed from ARGV
91         Add a new argumentsForConfiguration() function and clean up some old code to use it.
92         Rename checkArgV to checkForArgumentAndRemoveFromARGV to be more self-documenting.
93
94         * Scripts/run-javascriptcore-tests:
95         * Scripts/run-launcher:
96         * Scripts/run-webkit-tests:
97         * Scripts/webkitdirs.pm:
98
99 2008-12-03  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
100
101         Reviewed by Cameron Zwarich.
102
103         Further preparations for WML layout tests.
104         Ignore WMLTestCase.js, that's going to be in trunk soon.
105
106         * Scripts/make-js-test-wrappers:
107
108 2008-12-03  Eric Seidel  <eric@webkit.org>
109
110         Build fix for --gtk and --chromium, no review.
111
112         Fix run-javascriptcore-tests to pass --gtk, --qt, --chromium, etc.
113         through to build-jsc.
114
115         * Scripts/build-jsc:
116         * Scripts/webkitdirs.pm:
117
118 2008-12-03  Eric Seidel  <eric@webkit.org>
119
120         Build fix only, no review.
121         
122         Remove support for build-webkit --svg-experimental.
123         All of the "experimental" svg features have their own toggles anyway.
124         I broke --svg-experimental in my last commit (which then broke clean builds)
125         I can't find any use of --svg-experimental in our source tree, so removing it.
126
127         * Scripts/build-webkit:
128
129 2008-12-02  Eric Seidel  <eric@webkit.org>
130
131         Reviewed by David Hyatt (and Mark Rowe).
132         
133         Move --coverage support from build-webkit to webkitdirs.pm to share it with build-jsc
134         Move --coverage support out of run-javascriptcore-tests and into build-jsc
135         
136         Finally add a buildXCodeProject function to webkitdirs.pm and move --clean support
137         there from build-webkit (to allow future sharing with other build-* scripts)
138         
139         Change run-javascriptcore-tests to expect a --jsDriver-args= argument instead of
140         picking through ARGV with a blacklist of what arguments weren't jsDriver args
141         this makes run-javascriptcore-tests transparently support all arguments which
142         webkitdirs.pm gives it support for.
143         
144         Make run-javascriptcore-tests actually print what commands it's running before running them.
145         
146         Add --help support to build-jsc and run-javascriptcore-tests!
147         
148         Make code to support --svg-experimental defaults take up half as many lines.
149
150         * Scripts/build-jsc:
151         * Scripts/build-webkit:
152         * Scripts/run-javascriptcore-tests:
153         * Scripts/webkitdirs.pm:
154
155 2008-12-03  Adam Roben  <aroben@apple.com>
156
157         Fix a leak in WinLauncher shutdown
158
159         Reviewed by Sam Weinig.
160
161         * WinLauncher/WinLauncher.cpp:
162         (_tWinMain): Replaced a delete with a Release. We can't delete the
163         WebView properly since we only have a pointer to one of its
164         interfaces. We also shouldn't be deleting COM objects directly anyway,
165         for a number of reasons.
166
167 2008-12-03  Adam Roben  <aroben@apple.com>
168
169         Fix a crash on exit in WinLauncher
170
171         Reviewed by Sam Weinig.
172
173         * WinLauncher/WinLauncher.cpp:
174         (_tWinMain): Call shutDownWebKit before exiting.
175
176 2008-12-03  Adam Roben  <aroben@apple.com>
177
178         Add a Debug_Internal configuration to WinLauncher
179
180         This matches our other projects.
181
182         Reviewed by Sam Weinig.
183
184         * WinLauncher/WinLauncher.vcproj: Added a Debug_Internal
185         configuration, which is identical to Debug except that it also
186         references debug_internal.vsprops. Also removed some settings that we
187         should be picking up from the .vsprops files.
188
189 2008-12-02  Eric Seidel  <eric@webkit.org>
190
191         Reviewed by David Kilzer.
192
193         Hack build-webkit --chromium to use Win32 python instead
194         of using the default cygwin python.  Scons + CYGWIN tries
195         to build with GCC by default, we force MSVC in our file
196         but that just results in errors from Scons.  Until we can fix
197         this latest round of errors, at least make build-webkit --chromium
198         actually "work" under CYGWIN instead of forcing users to use
199         a cmd shell directly.
200         
201         This is working around a Scons bug:
202         http://scons.tigris.org/issues/show_bug.cgi?id=2266
203
204         * Scripts/webkitdirs.pm:
205
206 2008-12-01  David Kilzer  <ddkilzer@apple.com>
207
208         Bug 22466: REGRESSION (35867): Many resources missing when saving webarchive of webkit.org
209
210         <https://bugs.webkit.org/show_bug.cgi?id=22466>
211         <rdar://problem/6403593>
212
213         Reviewed by Brady Eidson.
214
215         * DumpRenderTree/mac/DumpRenderTree.mm:
216         (normalizeHTTPResponseHeaderFields): Added.  Normalizes Date, Etag,
217         Keep-Alive, Last-Modified and Server header fields to prevent false
218         positive test failures.
219         (convertWebResourceResponseToDictionary): Call
220         normalizeHTTPResponseHeaderFields() to noramlize HTTP response
221         header fields.
222
223 2008-12-01  David D. Kilzer  <ddkilzer@webkit.org>
224
225         Bug 22559: Report builds left to test in bisect-builds (like git-bisect)
226
227         <https://bugs.webkit.org/show_bug.cgi?id=22559>
228
229         Reviewed by Adam Roben.
230
231         * Scripts/bisect-builds: Updated status message to report the
232         maximum number of builds left to test after the current one.
233         (max): Added.
234
235 2008-11-27  Alp Toker  <alp@nuanti.com>
236
237         Build GtkLauncher and minidom with the '-ansi' compiler flag to detect
238         API header breakage at build time.
239
240         * GNUmakefile.am:
241
242 2008-11-26  Eric Seidel  <eric@webkit.org>
243
244         Reviewed by Nikolas Zimmermann and Mark Rowe.
245         
246         Add support for build-webkit --chromium
247         https://bugs.webkit.org/show_bug.cgi?id=22515
248         More cleanups changing isCygwin calls to isAppleWinWebKit and deploying isAppleWebKit where necessary.
249
250         * Scripts/build-dumprendertree:
251         * Scripts/build-jsc:
252         * Scripts/build-webkit:
253         * Scripts/gdb-safari:
254         * Scripts/run-webkit-tests:
255         * Scripts/webkitdirs.pm:
256
257 2008-11-26  Eric Seidel  <eric@webkit.org>
258
259         Reviewed by Nikolas Zimmermann.
260
261         Add support for build-webkit --chromium (tested on mac)
262         https://bugs.webkit.org/show_bug.cgi?id=22515
263         Also simplified some code using checkArgv
264
265         * Scripts/build-webkit:
266         * Scripts/webkitdirs.pm:
267
268 2008-11-26  Eric Seidel  <eric@webkit.org>
269
270         Reviewed by Nikolas Zimmermann.
271
272         More pre-work for adding a build-webkit --chromium which works on Mac and Windows
273         https://bugs.webkit.org/show_bug.cgi?id=22515
274         Change a few calls to isCygwin to isAppleWinWebKit and a few calls to isAppleMacWebKit to isDarwin
275         in preparation for having a chromium cygwin and chromium mac build
276
277         * Scripts/build-webkit:
278         * Scripts/webkitdirs.pm:
279
280 2008-11-26  Eric Seidel  <eric@webkit.org>
281
282         Reviewed by Nikolas Zimmermann.
283
284         Pre-work for getting build-webkit --chromium to work
285         https://bugs.webkit.org/show_bug.cgi?id=22515
286         Rename isOSX to isAppleMacWebKit to match what the code does, and add isChromium()
287
288         * Scripts/build-dumprendertree:
289         * Scripts/build-jsc:
290         * Scripts/build-webkit:
291         * Scripts/gdb-safari:
292         * Scripts/run-javascriptcore-tests:
293         * Scripts/run-webkit-tests:
294         * Scripts/webkitdirs.pm:
295
296 2008-11-26  David Kilzer  <ddkilzer@apple.com>
297
298         Bug 22488: Make DRT smarter about charset encoding when post-processing webarchive content
299
300         <https://bugs.webkit.org/show_bug.cgi?id=22488>
301
302         Reviewed by Brady Eidson.
303
304         * DumpRenderTree/mac/DumpRenderTree.mm:
305         (convertWebResourceDataToString): If an IANA charset encoding string
306         is provided, convert it to a CFStringEncoding value and then to an
307         NSStringEncoding value, else fall back to NSUTF8StringEncoding.  We
308         also nil-check dataAsString, so the worst-case scenario is that the
309         data won't be decoded to a string (versus crashing DumpRenderTree).
310
311 2008-11-26  Jan Michael Alonzo  <jmalonzo@webkit.org>
312
313         Reviewed by Holger Freyther.
314
315         [Gtk] add/remove tests from Skipped and fix netscape plugin test
316         https://bugs.webkit.org/show_bug.cgi?id=22484
317
318         Remove print'ing to stderr
319
320         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
321         (NP_Initialize):
322         (NP_Shutdown):
323
324 2008-11-25  Steve Falkenburg  <sfalken@apple.com>
325
326         Windows build fix.
327
328         * DumpRenderTree/cg/PixelDumpSupportCG.h:
329
330 2008-11-25  Steve Falkenburg  <sfalken@apple.com>
331
332         Windows build fix.
333
334         * DumpRenderTree/cg/ImageDiffCG.cpp:
335
336 2008-11-24  Darin Fisher  <darin@chromium.org>
337
338         Fix bustage.
339
340         https://bugs.webkit.org/show_bug.cgi?id=15643
341
342         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
343         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
344
345 2008-11-24  Glenn Wilson  <gwilson@chromium.org>
346
347         Reviewed by Alexey Proskuryakov.
348
349         http://bugs.webkit.org/show_bug.cgi?id=15643
350
351         Added support for changing the "trailing whitespace" work-around
352         in LayoutTestController (so layout tests can verify this functionality)
353
354         * DumpRenderTree/LayoutTestController.cpp:
355         (setSelectTrailingWhitespaceEnabledCallback):
356         (LayoutTestController::staticFunctions):
357         * DumpRenderTree/LayoutTestController.h:
358         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
359         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
360         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
361         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
362
363 2008-11-24  Simon Fraser  <simon.fraser@apple.com>
364
365         Reviewed by Darin Adler
366
367         https://bugs.webkit.org/show_bug.cgi?id=22433
368         
369         Add script that attempts to detect virtual methods
370         whose signatures differ only by constness (which can
371         indicate a programming error).
372         
373         * Scripts/detect-mismatched-virtual-const: Added.
374
375 2008-11-24  Zan Dobersek  <zandobersek@gmail.com>
376
377         Reviewed by Holger Freyther.
378
379         https://bugs.webkit.org/show_bug.cgi?id=22039
380
381         [Gtk+] Implement TestNetscapePlugin for Gtk+ port and add it to the
382         build.
383
384         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
385         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
386         * DumpRenderTree/gtk/DumpRenderTree.cpp:
387         (setDefaultsToConsistentStateValuesForTesting):
388         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h: Added.
389         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h: Added.
390         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h: Added.
391         * GNUmakefile.am:
392
393 2008-11-24  Holger Hans Peter Freyther  <zecke@selfish.org>
394
395         Reviewed by Mark Rowe.
396
397         [Gtk+] Add configure option to enable Web Workers and enable it by default
398
399         Add --enable-workers to the buildsystem (used by build-webkit) add
400         the to be build files to the GNUmakefile.am and change build-webkit
401         to enable Web Workers by default.
402
403         * Scripts/build-webkit:
404
405 2008-11-24  Mark Rowe  <mrowe@apple.com>
406
407         Reviewed by Alexey Proskuryakov.
408
409         Let gdb-safari accept the --debug and --release options once more.
410
411         * Scripts/gdb-safari:
412
413 2008-11-23  Zan Dobersek  <zandobersek@gmail.com>
414
415         Reviewed by Holger Freyther. Landed by Jan Alonzo.
416
417         Get SVG tests tested on GTK port.
418
419         * Scripts/webkitdirs.pm:
420
421 2008-11-19  Greg Bolsinga  <bolsinga@apple.com>
422
423         Reviewed by Darin Adler.
424
425         https://bugs.webkit.org/show_bug.cgi?id=21810
426         Remove use of static C++ objects that are destroyed at exit time (destructors)
427
428         All static C++ objects that create atexit calls are gone. Update script
429         to indicate how to fix the problem should a new one appear.
430         
431         * Scripts/check-for-exit-time-destructors:
432
433 2008-11-18  Alexey Proskuryakov  <ap@webkit.org>
434
435         Reviewed by Darin Adler.
436
437         https://bugs.webkit.org/show_bug.cgi?id=22337
438         Enable workers by default
439
440         * Scripts/build-webkit: Changed the default to enabled.
441
442 2008-11-18  Alexey Proskuryakov  <ap@webkit.org>
443
444         Rubber-stamped by Darin Adler.
445
446         https://bugs.webkit.org/show_bug.cgi?id=22306
447         Disable channel messaging support
448
449         * Scripts/build-webkit: Add an option to enable channel messaging.
450
451 2008-11-17  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
452
453         Reviewed by George Staikos.
454
455         Add --(no-)wml build flags.
456
457         * Scripts/build-webkit:
458         * Scripts/run-webkit-tests:
459         * Scripts/webkitdirs.pm:
460
461 2008-11-17  Geoffrey Garen  <ggaren@apple.com>
462
463         Not reviewed.
464         
465         Try to fix gtk build.
466
467         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
468         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
469         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
470
471 2008-11-17  Pierre-Olivier Latour  <pol@apple.com>
472
473         Reviewed by Maciej.
474
475         Pixel tests should use a default tolerance of 0.1% on Leopard and 1.0%
476         on Tiger.
477
478         https://bugs.webkit.org/show_bug.cgi?id=22271
479
480         * Scripts/run-webkit-tests:
481
482 2008-11-17  Pierre-Olivier Latour  <pol@apple.com>
483
484         Reviewed by Sam Weinig.
485
486         Added new JavaScript API on LayoutController to pause a running
487         CSS transition or animation at a given time.
488
489         https://bugs.webkit.org/show_bug.cgi?id=21261
490
491         * DumpRenderTree/LayoutTestController.cpp:
492         (pauseAnimationAtTimeOnElementWithIdCallback):
493         (pauseTransitionAtTimeOnElementWithIdCallback):
494         (LayoutTestController::staticFunctions):
495         * DumpRenderTree/LayoutTestController.h:
496         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
497         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
498         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
499         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
500         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
501         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
502
503 2008-11-17  Gabor Loki  <loki@inf.u-szeged.hu>
504
505         Reviewed by Darin Adler.
506
507         <https://bugs.webkit.org/show_bug.cgi?id=22309>
508         Pass the remaining options to build system on Qt-port
509
510         * Scripts/build-webkit:
511         * Scripts/webkitdirs.pm:
512
513 2008-11-16  Greg Bolsinga  <bolsinga@apple.com>
514
515         Reviewed by Darin Adler.
516
517         https://bugs.webkit.org/show_bug.cgi?id=21810
518         Remove use of static C++ objects that are destroyed at exit time (destructors)
519
520         Remove .o files from the exclude list that have had their exit-time destructors removed.
521         Handle case when there is no current symbol.
522         
523         * Scripts/check-for-exit-time-destructors:
524
525 2008-11-16  Sam Weinig  <sam@webkit.org>
526
527         * Scripts/do-webcore-rename: Remove now fixed renames.
528
529 2008-11-16  Darin Adler  <darin@apple.com>
530
531         * Scripts/do-webcore-rename: Plan some future renames.
532
533 2008-11-15  Darin Adler  <darin@apple.com>
534
535         Rubber stamped by Geoff Garen.
536
537         - do the long-planned StructureID -> Structure rename
538
539         * Scripts/check-for-global-initializers: Update name of StructureID.o.
540         * Scripts/do-webcore-rename: Renaming script that I used.
541
542 2008-11-15  Greg Bolsinga  <bolsinga@apple.com>
543
544         Reviewed by Darin Adler.
545
546         https://bugs.webkit.org/show_bug.cgi?id=21810
547         Remove use of static C++ objects that are destroyed at exit time (destructors)
548
549         Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid 
550         exit-time destructor. Update code that was changed to fix this issue that ran 
551         into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference 
552         in gcc build 5465). Also typdefs for template types needed to be added in some 
553         cases so the type could make it through the macro successfully.
554
555         Basically code of the form:
556         static T m;
557         becomes:
558         DEFINE_STATIC_LOCAL(T, m, ());
559
560         Also any code of the form:
561         static T& m = *new T;
562         also becomes:
563         DEFINE_STATIC_LOCAL(T, m, ());
564
565         Remove .o files from the exclude list that have had their exit-time destructors removed.
566         
567         * Scripts/check-for-exit-time-destructors:
568
569 2008-11-14  Kevin Ollivier  <kevino@theolliviers.com>
570
571         wx mac buildbot fix. Also, make sure we don't keep hitting this problem.
572
573         * wx/install-unix-extras:
574
575 2008-11-14  Alp Toker  <alp@nuanti.com>
576
577         GTK DRT build fix for gcc 4.4 snapshot. Add missing stdio include.
578
579         Fixes Debian bug #505723
580         http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505723
581
582         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
583
584 2008-11-14  Krishna <krishnamurty.podipireddy@nokia.com>
585
586         Reviewed by Simon Hausmann.
587
588         Fix hanging DRT with Qt.
589
590         https://bugs.webkit.org/show_bug.cgi?id=22209
591
592         * DumpRenderTree/qt/DumpRenderTree.cpp:
593         (WebCore::DumpRenderTree::dump):
594         Send empty pixel test data 'block', which is now
595         expected by run-layout-tests.
596
597 2008-11-12  Dmitry Titov  <dimich@chromium.org>
598
599         Reviewed by Alexey Proskuryakov.
600
601         https://bugs.webkit.org/show_bug.cgi?id=22216
602
603         * Scripts/build-webkit:
604         Addes ENABLE_WORKERS to build-webkit so it's possible to build with workers enabled.
605
606 2008-11-06  David Kilzer  <ddkilzer@apple.com>
607
608         BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.
609
610         Apparently older versions of gcc have issues with this patch.
611         Backing out a second time until the issues are resolved.
612
613 2008-11-06  David Kilzer  <ddkilzer@apple.com>
614
615         BUILD WAS NOT BROKEN: Rolling r38189 back in.
616
617         Please perform a clean build if you see crashes.
618
619 2008-11-06  David Kilzer  <ddkilzer@apple.com>
620
621         BUILD FIX: Backed out r38189 since it apparently broke the world.
622
623 2008-11-06  Chris Fleizach  <cfleizach@apple.com>
624
625         Reviewed by Beth Dakin.
626
627         Add ability to query an attribute's settable status and the
628         ability to retrieve a single attribute from an AXObject
629
630         * DumpRenderTree/AccessibilityUIElement.cpp:
631         (isAttributeSettableCallback):
632         (attributeValueCallback):
633         (AccessibilityUIElement::getJSClass):
634         * DumpRenderTree/AccessibilityUIElement.h:
635         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
636         (+[NSString stringWithJSStringRef:]):
637         (AccessibilityUIElement::attributeValue):
638         (AccessibilityUIElement::isAttributeSettable):
639         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
640         (AccessibilityUIElement::attributeValue):
641         (AccessibilityUIElement::isAttributeSettable):
642
643 2008-11-06  Greg Bolsinga  <bolsinga@apple.com>
644
645         Reviewed by Darin Adler.
646         
647         Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
648         https://bugs.webkit.org/show_bug.cgi?id=21810
649         
650         Remove .o files from the exclude list that have had their exit-time destructors removed.
651
652         * Scripts/check-for-exit-time-destructors:
653
654 2008-11-05  Alp Toker  <alp@nuanti.com>
655
656         GTK build script tweak.
657
658         Make the path relative since it will appear in all -I compiler flags.
659         Long argument lists cause bizarre slowdowns in libtool and result
660         in huge build logs.
661
662         * Scripts/webkitdirs.pm:
663
664 2008-11-05  Anders Carlsson  <andersca@apple.com>
665
666         Fix 64-bit build.
667
668         * DumpRenderTree/mac/DumpRenderTree.mm:
669         (setDefaultsToConsistentValuesForTesting):
670
671 2008-11-04  Simon Fraser  <simon.fraser@apple.com>
672
673         Add AccessibilityObject.o to the exclude list for the
674         check for global destructors.
675         
676         * Scripts/check-for-exit-time-destructors:
677
678 2008-11-04  Darin Adler  <darin@apple.com>
679
680         * Scripts/check-for-exit-time-destructors: Fix failures seen on the
681         bot, but for some reason not on my computer.
682
683 2008-11-03  Darin Adler  <darin@apple.com>
684
685         Reviewed by Tim Hatcher.
686
687         - https://bugs.webkit.org/show_bug.cgi?id=22061
688           create script to check for exit-time destructors
689
690         * Scripts/check-for-exit-time-destructors: Added.
691         Started as a copy of check-for-global-initializers.
692
693         * Scripts/check-for-global-initializers: Added code to make
694         this script rerun any time it's modified, and also to properly
695         run again after the first time it reports an error.
696
697 2008-11-03  Pierre-Olivier Latour  <pol@apple.com>
698
699         Reviewed by Dan Bernstein.
700
701         Fixed the override of the "AppleScrollBarVariant" system setting to also work with HIToolbox.
702
703         https://bugs.webkit.org/show_bug.cgi?id=22054
704
705         * DumpRenderTree/mac/DumpRenderTree.mm:
706         (setDefaultsToConsistentValuesForTesting):
707
708 2008-10-31  Cameron Zwarich  <zwarich@apple.com>
709
710         Not reviewed.
711
712         * Scripts/do-webcore-rename:
713
714         Add some renames to contemplate for the future.
715
716 2008-10-31  Darin Adler  <darin@apple.com>
717
718         Requested by Mark Rowe.
719
720         * Scripts/check-for-global-initializers: s/Web Kit/WebKit/.
721
722 2008-10-31  David Kilzer  <ddkilzer@apple.com>
723
724         Bug 21997: prepare-ChangeLog should filter out ChangeLog files
725
726         <https://bugs.webkit.org/show_bug.cgi?id=21997>
727
728         Reviewed by Darin Adler.
729
730         * Scripts/prepare-ChangeLog:
731         (generateFileList): Don't add ChangeLog files to %{$functionLists}.
732         This prevents them from showing up in the new ChangeLog entry.  They
733         were already excluded from @{$changedFiles}.
734
735 2008-10-30  Mark Rowe  <mrowe@apple.com>
736
737         Reviewed by Jon Homeycutt.
738
739         Explicitly default to building for only the native architecture in debug and release builds.
740
741         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
742
743 2008-10-30  Pierre-Olivier Latour  <pol@apple.com>
744
745         Reviewed by Dan Bernstein.
746
747         Fixed 64 bit build failure.
748
749         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
750         (setupMainDisplayColorProfile):
751         (createBitmapContextFromWebView):
752
753 2008-10-28  Alp Toker  <alp@nuanti.com>
754
755         Fix GTK DRT following build breakage in r37928.
756
757         * DumpRenderTree/gtk/DumpRenderTree.cpp:
758         (dump):
759         (runTest):
760         (main):
761
762 2008-10-28  Alp Toker  <alp@nuanti.com>
763
764         Reviewed by Mark Rowe.
765
766         Fix recently introduced double-free crashes in GTK DRT.
767
768         LayoutTestController was made ref-counted in r36606 and Mac/Win DRT
769         were updated to call ->deref() but GTK DRT was still deleting
770         gLayoutTestController manually. This patch updates GTK to match the
771         other ports and resolves the memory allocation issues.
772
773         * DumpRenderTree/gtk/DumpRenderTree.cpp:
774         (runTest):
775
776 2008-10-28  Alp Toker  <alp@nuanti.com>
777
778         Reviewed by Mark Rowe.
779
780         Fix GTK DRT hang when running the tests.
781
782         Update output from the DRT tool to print an additional '#EOF' to match
783         breaking changes that were made in r37434.
784
785         * DumpRenderTree/gtk/DumpRenderTree.cpp:
786         (dump):
787
788 2008-10-28  Adele Peterson  <adele@apple.com>
789
790         Reviewed by Sam Weinig. 
791
792         Specify which Localizable.strings to update since we don't always want to update the file in the same
793         directory where we're searching for the strings to localize.
794         
795         * Scripts/extract-localizable-strings:
796         * Scripts/update-webkit-localizable-strings:
797
798 2008-10-28  Timothy Hatcher  <timothy@apple.com>
799
800         Add support for enabling the profiler, so the profiling tests can continue
801         work now that the profiler is not always enabled.
802
803         https://bugs.webkit.org/show_bug.cgi?id=21927
804
805         <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
806         not slow down JavaScript all the time
807
808         Reviewed by Darin Adler and Kevin McCullough.
809
810         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Make the editor use spaces.
811         * DumpRenderTree/LayoutTestController.cpp:
812         (setJavaScriptProfilingEnabledCallback): Added. Calls LayoutTestController::setJavaScriptProfilingEnabled.
813         (LayoutTestController::staticFunctions): Added setJavaScriptProfilingEnabled to the script class.
814         * DumpRenderTree/LayoutTestController.h:
815         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
816         (LayoutTestController::setJavaScriptProfilingEnabled): Stubbed out with a FIXME.
817         * DumpRenderTree/mac/DumpRenderTree.mm:
818         (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
819         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
820         (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
821         * DumpRenderTree/win/DumpRenderTree.cpp:
822         (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
823         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
824         (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
825
826 2008-10-28  Pierre-Olivier Latour  <pol@apple.com>
827
828         Reviewed by Dan Bernstein
829
830         Primary changes in DumpRenderTree:
831         - Ensure font smoothing is disabled (this is also called LCD anti-aliasing and
832         is different from regular font CG anti-aliasing) as font-smoothing settings
833         depends on the display and can also be changed by the user
834         - Use a new cleared buffer for each test instead of the reusing same one to
835         avoid potential result corruption across tests
836         - Can now receive the expected pixel hash as a suffix to the test path or
837         url as "path'hash"
838         - Make sure hash is computed in a endian-independent way
839         - Improve the code that sets/restores the screen color profile
840         - Make the code more cross-platformy with std::string goodness
841         - Added an "on-screen" mode where the snapshot will take into account surfaces
842         on the window (like OpenGL content): this uses the new CG APIs on 10.5 or
843         reading from the display framebuffer on 10.4. This mode is not active by
844         default for performance reason, but must be explicitly activated from the test
845         file using the new "testOnscreen()" JS API.
846
847         Primary changes in ImageDiff:
848         - Provide a new comparison algorithm that is more tolerant to "acceptable"
849         failures (i.e. very small differences in font rendering, which --threshold is
850         not really good at handling)
851         - Generate normalized intensity-only diff images
852
853         Primary changes in run-webkit-tests:
854         - Take advantage of hashes for pixel tests which makes them much faster by
855         minimizing image comparisons
856         - Removed repaint options as these should be set from within test files using
857         JS API
858         - Replaced "threshold" option in  by "tolerance" expressed in percents
859         - Added more logging when in "verbose" mode
860
861         https://bugs.webkit.org/show_bug.cgi?id=21322
862         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
863         * DumpRenderTree/ForwardingHeaders/wtf/PassRefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/PassRefPtr.h.
864         * DumpRenderTree/ForwardingHeaders/wtf/RefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefPtr.h.
865         * DumpRenderTree/LayoutTestController.cpp:
866         (LayoutTestController::LayoutTestController):
867         (testOnscreenCallback):
868         (LayoutTestController::staticFunctions):
869         * DumpRenderTree/LayoutTestController.h:
870         (LayoutTestController::testOnscreen):
871         (LayoutTestController::setTestOnscreen):
872         (LayoutTestController::testPathOrURL):
873         (LayoutTestController::expectedPixelHash):
874         * DumpRenderTree/PixelDumpSupport.h:
875         * DumpRenderTree/cg/ImageDiffCG.cpp:
876         (strtof):
877         (releaseMallocBuffer):
878         (createDifferenceImage):
879         (imageHasAlpha):
880         (main):
881         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
882         (computeMD5HashStringForBitmapContext):
883         (dumpWebViewAsPixelsAndCompareWithExpected):
884         * DumpRenderTree/cg/PixelDumpSupportCG.h:
885         (BitmapContext::createByAdoptingBitmapAndContext):
886         (BitmapContext::~BitmapContext):
887         (BitmapContext::cgContext):
888         (BitmapContext::BitmapContext):
889         * DumpRenderTree/mac/DumpRenderTree.mm:
890         (shouldIgnoreWebCoreNodeLeaks):
891         (setDefaultsToConsistentValuesForTesting):
892         (crashHandler):
893         (initializeGlobalsFromCommandLineOptions):
894         (prepareConsistentTestingEnvironment):
895         (dumpRenderTree):
896         (sizeWebViewForCurrentTest):
897         (dump):
898         (runTest):
899         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
900         (restoreMainDisplayColorProfile):
901         (setupMainDisplayColorProfile):
902         (createBitmapContextFromWebView):
903         * DumpRenderTree/win/DumpRenderTree.cpp:
904         (dump):
905         (runTest):
906         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
907         (getBitmapContextFromWebView):
908         * Scripts/run-webkit-tests:
909
910 2008-10-27  Kevin Ollivier  <kevino@theolliviers.com>
911
912         wx build fix on Linux/GTK. Enable support for #include <JavaScriptCore/XYZ.h> style includes.
913
914         * wx/build-wxwebkit:
915
916 2008-10-24  Anders Carlsson  <andersca@apple.com>
917
918         Try fixing the 64-bit build.
919         
920         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
921         (testGetProperty):
922
923 2008-10-24  Anders Carlsson  <andersca@apple.com>
924
925         Reviewed by Sam Weinig.
926         
927         <rdar://problem/5440917> Support NPN_Construct
928         
929         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
930         (testCallback):
931         Fix a memory leak.
932         
933         (testConstruct):
934         New test method that treats it first argument as a constructor and invokes it with the rest of the arguments.
935         
936         (pluginInvoke):
937         Handle testConstruct.
938         
939         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
940         (testGetProperty):
941         Add objectPointer property.
942         
943         (testEnumerate):
944         Only enumerate the two first properties.
945         
946         (testConstruct):
947         Add a simple construct implementation that just returns the test object.
948
949 2008-10-24  David Kilzer  <ddkilzer@apple.com>
950
951         Bug 21850: svn-apply and svn-unapply should preserve patch line endings
952
953         <https://bugs.webkit.org/show_bug.cgi?id=21850>
954
955         Reviewed by Adam Roben.
956
957         * Scripts/svn-apply: Save end-of-line characters when stripping them
958         off each line of a patch so that they may be restored after
959         processing the line.
960         * Scripts/svn-unapply: Ditto.
961
962 2008-10-23  David Kilzer  <ddkilzer@apple.com>
963
964         Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10
965
966         <https://bugs.webkit.org/show_bug.cgi?id=21832>
967
968         Reviewed by Sam Weinig.
969
970         * Scripts/bisect-builds: Use imported tempfile() from File::Temp
971         instead of 'new File::Temp' to make the script work with Perl 5.10.
972         * Scripts/sort-Xcode-project-file: Ditto.
973
974 2008-10-22  Brady Eidson  <beidson@apple.com>
975
976         Reviewed by Adam Roben
977         
978         <rdar://6261773> - autocomplete="off" doesn't work on Windows
979
980         Implement LayoutTestController::elementDoesAutoCompleteForElementWithId() on Windows
981         
982         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
983
984 2008-10-22  Darin Adler  <darin@apple.com>
985
986         * Scripts/do-webcore-rename: More renaming plans.
987
988 2008-10-21  Steve Falkenburg  <sfalken@apple.com>
989
990         Exclude strings marked with UNLOCALIZED_STRING or UNLOCALIZED_LPCTSTR.
991
992         * Scripts/extract-localizable-strings:
993
994 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
995
996         Reviewed by Mark Rowe.
997         
998         - default to 1000 tests per dump tool instance again, now that CTI no longer causes
999         excess different stack logs.
1000         
1001         (Also fix a small bug in my last change.)
1002
1003         * Scripts/run-webkit-tests:
1004
1005 2008-10-17  Stephanie Lewis  <slewis@apple.com>
1006
1007         Reviewed by Mark Rowe.
1008
1009         Fix layout tests that use prologues and epilogues.
1010
1011         * Scripts/run-webkit-tests:
1012
1013 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
1014
1015         Reviewed by Mark Rowe.
1016         
1017         - make sure MallocStackLogging is only on for tools we want to
1018         leak check, not other random stuff as well.
1019
1020         * Scripts/run-webkit-tests:
1021
1022 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
1023
1024         Reviewed by Stephanie Lewis.
1025         
1026         - make run-webkit-tests --leaks default to 100 tests per run instead of 1000
1027         
1028         This should reduce or eliminate crashes on the buildbot due to
1029         running out of memory while stack logging.
1030
1031         * Scripts/run-webkit-tests:
1032
1033 2008-10-16  Jan Michael Alonzo  <jmalonzo@webkit.org>
1034
1035         Gtk build fix. Not reviewed.
1036
1037         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1038         (LayoutTestController::setSmartInsertDeleteEnabled):
1039
1040 2008-10-15  Glenn Wilson  <gwilson@google.com>
1041
1042         Added new method to allow tests to disable smart editing in the course of a test.
1043         This is a possible solution to bug .20655
1044
1045         Reviewed by Tim Hatcher.
1046
1047         * DumpRenderTree/LayoutTestController.cpp:
1048         (setSmartInsertDeleteEnabledCallback): new method
1049         (LayoutTestController::staticFunctions): added new method to static list of callbacks
1050         * DumpRenderTree/LayoutTestController.h: added signature of new method
1051         * DumpRenderTree/mac/DumpRenderTree.mm:
1052         (resetWebViewToConsistentStateBeforeTesting): added state resetting
1053         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1054         (LayoutTestController::setSmartInsertDeleteEnabled): added new method
1055         * DumpRenderTree/win/DumpRenderTree.cpp:
1056         (resetWebViewToConsistentStateBeforeTesting): added state resetting
1057         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1058         (LayoutTestController::setSmartInsertDeleteEnabled): added new method
1059
1060 2008-10-14  Ada Chan  <adachan@apple.com>
1061
1062         Fix windows build.
1063
1064         Reviewed by Sam Weinig.
1065
1066         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1067         * DumpRenderTree/config.h:
1068         * DumpRenderTree/win/DumpRenderTreeWin.h:
1069         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1070         * DumpRenderTree/win/UIDelegate.cpp:
1071
1072 2008-10-13  Timothy Hatcher  <timothy@apple.com>
1073
1074         Make prepare-ChangeLog populate the changed functions for JavaScript files.
1075
1076         https://bugs.webkit.org/show_bug.cgi?id=21567
1077
1078         Reviewed by David Kilzer.
1079
1080         * Scripts/prepare-ChangeLog:
1081         (get_function_line_ranges): Call get_function_line_ranges_for_javascript for
1082         files that end with ".js".
1083         (get_function_line_ranges_for_javascript): Find functions, anonymous functions
1084         and getters/setters.
1085
1086 2008-10-14  Alp Toker  <alp@nuanti.com>
1087
1088         Reviewed by Sam Weinig.
1089
1090         https://bugs.webkit.org/show_bug.cgi?id=16299
1091         Add a config.h file to DRT
1092
1093         Add a config.h to DumpRenderTree and reduce use of DumpRenderTree.h as
1094         an ad-hoc config header.
1095
1096         * DumpRenderTree/AccessibilityController.cpp:
1097         * DumpRenderTree/AccessibilityUIElement.cpp:
1098         * DumpRenderTree/AccessibilityUIElement.h:
1099         * DumpRenderTree/DumpRenderTree.h:
1100         * DumpRenderTree/GCController.cpp:
1101         * DumpRenderTree/LayoutTestController.cpp:
1102         * DumpRenderTree/WorkQueue.cpp:
1103         * DumpRenderTree/config.h: Added.
1104         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1105         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1106         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1107         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1108         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1109         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1110         * DumpRenderTree/win/DumpRenderTree.cpp:
1111         * DumpRenderTree/win/DumpRenderTreeWin.h:
1112         * DumpRenderTree/win/EditingDelegate.cpp:
1113         * DumpRenderTree/win/EventSender.cpp:
1114         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1115         * DumpRenderTree/win/GCControllerWin.cpp:
1116         * DumpRenderTree/win/MD5.cpp:
1117         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1118         * DumpRenderTree/win/PolicyDelegate.cpp:
1119         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1120         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1121         * GNUmakefile.am:
1122
1123 2008-10-13  Chris Fleizach  <cfleizach@apple.com>
1124
1125         Reviewed by Beth Dakin.
1126
1127         Added a method to get the links in a webpage
1128
1129         * DumpRenderTree/AccessibilityUIElement.cpp:
1130         (attributesOfDocumentLinksCallback):
1131         (AccessibilityUIElement::getJSClass):
1132         * DumpRenderTree/AccessibilityUIElement.h:
1133         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1134         (AccessibilityUIElement::getDocumentLinks):
1135         (AccessibilityUIElement::attributesOfDocumentLinks):
1136         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1137         (AccessibilityUIElement::getDocumentLinks):
1138         (AccessibilityUIElement::attributesOfDocumentLinks):
1139
1140 2008-10-13  David Kilzer  <ddkilzer@apple.com>
1141
1142         Bug 21457: resolve-ChangeLogs should be able to operate on a git revision range
1143
1144         <https://bugs.webkit.org/show_bug.cgi?id=21457>
1145
1146         Reviewed by Adam.
1147
1148         * Scripts/resolve-ChangeLogs: Added optional parameter to
1149         -f|--fix-merged switch to run the script on a revision range.
1150         Updated command-line validation checks.
1151         (findChangeLog): Fixed long-standing bug that should have used
1152         $_[0] instead of $_.
1153         (fixMergedChangeLog): Renamed to fixOneMergedChangeLog($).  Updated
1154         to work when called from git filter-branch.  It always restores a
1155         copy of the previous revision before reapplying the patch.
1156         (fixMergedChangeLogs): Added.  Calls itself through git filter-branch
1157         to re-merge ChangeLog files across a revision range.  Removes
1158         .git/refs/original directory on success.
1159         (parseFixMerged): Added.  Custom method to parse the -f|--fix-merged
1160         switch.
1161         (removeChangeLogArguments): Added.  Removes items from @ARGV when
1162         they are ChangeLog paths, and return a list of paths.  This makes it
1163         easier to validate the command-line.
1164         (resolveChangeLog): Added.  Extracted from main code block.  Runs
1165         the traditional single-file merge algorithm.
1166         (usageAndExit): Added.  Extracted from main code block.  Prints
1167         usage statement and exits with error status.
1168
1169 2008-10-12  Darin Adler  <darin@apple.com>
1170
1171         * Scripts/make-js-test-wrappers: Update exceptions list so the script
1172         won't overwrite files and mangle tests.
1173
1174 2008-10-11  Dan Bernstein  <mitz@apple.com>
1175
1176         Reviewed by Sam Weinig and Anders Carlsson.
1177
1178         - update Mac DumpRenderTree to use the new WebView SPI for forcing the
1179           complex text code path
1180         - add --complex-text support to Windows DumpRenderTree
1181
1182         * DumpRenderTree/mac/DumpRenderTree.mm:
1183         (dumpRenderTree):
1184         * DumpRenderTree/win/DumpRenderTree.cpp:
1185         (createWebViewAndOffscreenWindow):
1186         (main):
1187         * Scripts/run-webkit-tests:
1188
1189 2008-10-09  Eric Seidel  <eric@webkit.org>
1190
1191         Reviewed by Oliver Hunt.
1192
1193         https://bugs.webkit.org/show_bug.cgi?id=21498
1194
1195         * Scripts/make-js-test-wrappers: ignore resources/shadow-offset.js
1196
1197 2008-10-09  Cameron Zwarich  <zwarich@apple.com>
1198
1199         Not reviewed.
1200
1201         Add StructureID.o to the exclusion list in the global initializers
1202         script to fix the Debug build.
1203
1204         * Scripts/check-for-global-initializers:
1205
1206 2008-10-08  Mark Rowe  <mrowe@apple.com>
1207
1208         Fix the Windows build after r37434.
1209
1210         * DumpRenderTree/win/DumpRenderTree.cpp:
1211         (dump): Update code to approximate valid C++ syntax.
1212
1213 2008-10-08  Timothy Hatcher  <timothy@apple.com>
1214
1215         Add SVGElementInstance to the list of exceptions that have
1216         global initializers in debug builds.
1217
1218         Rubber-stamped by Mark Rowe.
1219
1220         * Scripts/check-for-global-initializers: Add SVGElementInstance.o.
1221
1222 2008-10-08  Simon Fraser  <simon.fraser@apple.com>
1223
1224         Reviewed by Dan Bernstein
1225
1226         Avoid disconnect between DRT and run-webkit-tests
1227         about whether to expect PNG dumps by having DRT always
1228         print two blocks terminated by #EOF, the second of which
1229         may be empty.
1230         
1231         https://bugs.webkit.org/show_bug.cgi?id=21483
1232         
1233         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1234         (printPNG):
1235         (dumpWebViewAsPixelsAndCompareWithExpected):
1236         * DumpRenderTree/mac/DumpRenderTree.mm:
1237         (dump):
1238         * DumpRenderTree/win/DumpRenderTree.cpp:
1239         (dump):
1240         * Scripts/run-webkit-tests:
1241
1242 2008-10-07  Adam Roben  <aroben@apple.com>
1243
1244         Make sure short functions get included in ChangeLog output for git
1245         repositories
1246
1247         Reviewed by Dave Kilzer.
1248
1249         * Scripts/prepare-ChangeLog:
1250         (sub diffCommand): Pass -U0 to git diff so that each contiguous change
1251         will get its own chunk without any surrounding context.
1252         (sub extractLineRange): Use the line numbers from the chunk header
1253         without modifying them now that they're accurate.
1254
1255 2008-10-04  Mark Rowe  <mrowe@apple.com>
1256
1257         Reviewed by Tim Hatcher.
1258
1259         Update check-for-weak-vtables to check only the final linked image for weak vtables.
1260         This gives more useful results than checking each object file independently.
1261
1262         * Scripts/check-for-weak-vtables:
1263
1264 2008-10-03  Pierre-Olivier Latour <pol@apple.com>
1265
1266         Reviewed by Darin Adler
1267
1268         Render images to RGBA8 bitmaps independently of platform endianness.
1269
1270         Create image difference bitmap in reference image colorspace instead of device colorspace
1271         (which depends on the main display profile), so that no color matching happens.
1272
1273         https://bugs.webkit.org/show_bug.cgi?id=21336
1274
1275         * DumpRenderTree/cg/ImageDiffCG.cpp:
1276         (createDifferenceBitmap):
1277         (computePercentageDifferent):
1278         (compareImages):
1279
1280 2008-10-02  Simon Fraser  <simon.fraser@apple.com>
1281
1282         Reviewed by Darin Adler
1283
1284         Fix hang when running with --pixel --reset, which occurs
1285         because DRT spews PNG data when the script does not expect it.
1286         
1287         https://bugs.webkit.org/show_bug.cgi?id=21323
1288         
1289         * Scripts/run-webkit-tests:
1290
1291 2008-09-30  Mark Rowe  <mrowe@apple.com>
1292
1293         Reviewed by Dan Bernstein.
1294
1295         Add a leak counter for CachedResources since we've had two recent leaks involving them.
1296
1297         * Scripts/check-for-global-initializers:
1298
1299 2008-09-30  Mark Rowe  <mrowe@apple.com>
1300
1301         Rubber-stamped by Dan Bernstein.
1302
1303         Fix many leaks seen on fast/backgrounds/svg-as-background-1.html.
1304
1305         JavaScript wrappers were keeping DOM objects alive, which was leading to the SVG background image
1306         being kept alive in the memory cache past our last attempt to empty the cache prior to quitting.
1307         We need to empty the memory cache after forcing a JavaScript garbage collection to ensure that
1308         any live JavaScript wrappers are collected and their corresponding DOM objects have a chance to be
1309         torn down before we exit.
1310
1311         * DumpRenderTree/mac/DumpRenderTree.mm:
1312         (dumpRenderTree):
1313         (main):
1314
1315 2008-09-30  Simon Fraser  <simon.fraser@apple.com>
1316
1317         Reviewed by Dan Bernstein
1318
1319         Don't run pixel comparison for text-only tests.
1320         https://bugs.webkit.org/show_bug.cgi?id=21124
1321         
1322         * DumpRenderTree/mac/DumpRenderTree.mm:
1323         (dump):
1324         * Scripts/run-webkit-tests:
1325
1326 2008-09-29  Thiago Macieira  <thiago.macieira@nokia.com>
1327
1328         Reviewed by Simon.
1329
1330         Changed copyright from Trolltech ASA to Nokia.
1331         
1332         Nokia acquired Trolltech ASA, assets were transferred on September 26th 2008.
1333         
1334
1335         * DumpRenderTree/qt/DumpRenderTree.cpp:
1336         * DumpRenderTree/qt/jsobjects.cpp:
1337         * DumpRenderTree/qt/jsobjects.h:
1338         * DumpRenderTree/qt/main.cpp:
1339         * DumpRenderTree/qt/testplugin.cpp:
1340         * DumpRenderTree/qt/testplugin.h:
1341
1342 2008-09-28  David Kilzer  <ddkilzer@apple.com>
1343
1344         Bug 21185: resolve-ChangeLogs should be able to fix poorly merged ChangeLog entries after a git svn rebase
1345
1346         <https://bugs.webkit.org/show_bug.cgi?id=21185>
1347
1348         Reviewed by Adam.
1349
1350         * Scripts/resolve-ChangeLogs: Added new -f|--fix-merge switch that
1351         will attempt to reapply the last commit to a ChangeLog file such
1352         that the ChangeLog entry appears at the top of the file.
1353         (findChangeLog): Added prototype and moved method below the exit
1354         statement.
1355         (fixMergedChangeLog): Added.  Method to fix incorrectly merged
1356         ChangeLog entries.
1357
1358 2008-09-27  Anders Carlsson  <andersca@apple.com>
1359
1360         Reviewed by Sam Weinig.
1361         
1362         https://bugs.webkit.org/show_bug.cgi?id=21178
1363         <rdar://problem/6248651>
1364         
1365         Return the result value from getURL.
1366         
1367         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1368         (getURL):
1369
1370 2008-09-26  Matt Lilek  <webkit@mattlilek.com>
1371
1372         Reviewed by Tim Hatcher.
1373
1374         Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.
1375
1376         * Scripts/build-webkit:
1377
1378 2008-09-26  Alice Liu  <alice.liu@apple.com>
1379
1380         Remove usage of atlstr.h and CString for VCExpress compatibility
1381
1382         Reviewed by Stephanie Lewis.
1383
1384         * record-memory-win/main.cpp:
1385         (ProcessArgs):
1386         (UseImage):
1387         (QueryContinuously):
1388         (OneQuery):
1389         (OneQueryMP):
1390
1391 2008-09-26  Kevin Ollivier  <kevino@theolliviers.com>
1392
1393         wx build fix. Update the version of libpng.
1394
1395         * wx/install-unix-extras:
1396
1397 2008-09-24  Sam Weinig  <sam@webkit.org>
1398
1399         Reviewed by Darin Adler.
1400
1401         Fix for https://bugs.webkit.org/show_bug.cgi?id=21080
1402         <rdar://problem/6243534>
1403         Crash below Function.apply when using a runtime array as the argument list
1404
1405         Add method to ObjCController to return a runtime array.
1406
1407         * DumpRenderTree/mac/ObjCController.m:
1408         (+[ObjCController isSelectorExcludedFromWebScript:]):
1409         (+[ObjCController webScriptNameForSelector:]):
1410         (-[ObjCController testArray]):
1411
1412 2008-09-24  Beth Dakin  <bdakin@apple.com>
1413
1414         Reviewed by Sam Weinig.
1415
1416         Speculative build fix. 
1417
1418         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1419         (AccessibilityUIElement::supportsPressAction):
1420
1421 2008-09-23  Beth Dakin  <bdakin@apple.com>
1422
1423         Reviewed by Sam Weinig.
1424
1425         This patch extends DumpRenderTree's AccessibilityController to ask 
1426         if the focused element supports the press action.
1427
1428         * DumpRenderTree/AccessibilityUIElement.cpp:
1429         (getSupportsPressActionCallback):
1430         (AccessibilityUIElement::getJSClass):
1431         * DumpRenderTree/AccessibilityUIElement.h:
1432         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1433         (AccessibilityUIElement::supportsPressAction):
1434
1435 2008-09-22  Alice Liu  <alice.liu@apple.com>
1436
1437         Adding a stand-alone Windows console application to record a process's memory usage
1438
1439         Reviewed by Steve Falkenburg.
1440
1441         * record-memory-win: Added.
1442         * record-memory-win/main.cpp: Added.
1443         * record-memory-win/record-memory-win.vcproj: Added.
1444
1445 2008-09-22  Chris Fleizach  <cfleizach@apple.com>
1446
1447         Reviewed by Darin Adler.
1448
1449         Support ability to get/set selected text ranges for text controls through AX.
1450
1451         * DumpRenderTree/AccessibilityUIElement.cpp:
1452         (setSelectedTextRangeCallback):
1453         (getSelectedTextRangeCallback):
1454         (AccessibilityUIElement::getJSClass):
1455         * DumpRenderTree/AccessibilityUIElement.h:
1456         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1457         (AccessibilityUIElement::attributesOfRowHeaders):
1458         (AccessibilityUIElement::attributesOfVisibleCells):
1459         (AccessibilityUIElement::rowIndexRange):
1460         (AccessibilityUIElement::columnIndexRange):
1461         (AccessibilityUIElement::cellForColumnAndRow):
1462         (AccessibilityUIElement::selectedTextRange):
1463         (AccessibilityUIElement::setSelectedTextRange):
1464         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1465         (AccessibilityUIElement::selectedTextRange):
1466         (AccessibilityUIElement::setSelectedTextRange):
1467
1468 2008-09-20  Darin Adler  <darin@apple.com>
1469
1470         * DumpRenderTree/mac/DumpRenderTree.mm:
1471         (convertMIMEType): Turn on Stephanie's workaround for Tiger too.
1472
1473 2008-09-19  Alp Toker  <alp@nuanti.com>
1474
1475         Build fix for the 'gold' linker and recent binutils. New behaviour
1476         requires that we link to used libraries explicitly.
1477
1478         * GNUmakefile.am:
1479
1480 2008-09-19  Stephanie Lewis  <slewis@apple.com>
1481
1482         Reviewed by Oliver Hunt.
1483
1484         Implement a workaround for an incorrect mime-type on machines with 
1485         Dashcode 2.0.1.  Dashcode is overriding the UTI type for .js files.
1486         See radar <rdar://problem/6234318>.     
1487
1488         * DumpRenderTree/mac/DumpRenderTree.mm:
1489         (convertMIMEType):
1490
1491 2008-09-19  Chris Fleizach  <cfleizach@apple.com>
1492
1493         Fixed Windows bustage
1494
1495         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1496         (AccessibilityUIElement::titleUIElement):
1497
1498 2008-09-18  Chris Fleizach  <cfleizach@apple.com>
1499
1500         Reviewed by Darin Adler.
1501
1502         Expose titleUIElement call for DumpRenderTree
1503
1504         * ChangeLog:
1505         * DumpRenderTree/AccessibilityUIElement.cpp:
1506         (titleUIElementCallback):
1507         (AccessibilityUIElement::getJSClass):
1508         * DumpRenderTree/AccessibilityUIElement.h:
1509         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1510         (AccessibilityUIElement::titleUIElement):
1511
1512 2008-09-18  Darin Adler  <darin@apple.com>
1513
1514         * Scripts/do-webcore-rename: More renaming plans.
1515
1516 2008-09-18  Mark Rowe  <mrowe@apple.com>
1517
1518         Reviewed by Dan Bernstein.
1519
1520         Clear the main frame's name between tests to get more consistent test results
1521         when running the WebKit tests with --nthly.
1522
1523         * DumpRenderTree/mac/DumpRenderTree.mm:
1524         (resetWebViewToConsistentStateBeforeTesting):
1525         * DumpRenderTree/win/DumpRenderTree.cpp:
1526         (resetWebViewToConsistentStateBeforeTesting):
1527
1528 2008-09-18  Stephanie Lewis  <slewis@apple.com>
1529
1530         Really fix tiger jsc tests.
1531
1532         * Scripts/run-javascriptcore-tests:
1533
1534 2008-09-18  Stephanie Lewis  <slewis@apple.com>
1535
1536         Reviewed by Maciej Stachowiak.
1537
1538         Fix jsc tests on Tiger.  Make jsc tests smarter about when to use the arch flag.
1539
1540         * Scripts/run-javascriptcore-tests:
1541         * Scripts/webkitdirs.pm:
1542
1543 2008-09-18  Mark Rowe  <mrowe@apple.com>
1544
1545         Rubber-stamped by Sam Weinig.
1546
1547         Print warning to stdout rather than stderr when a test attempts to access a remote resource.
1548         This should make it more obvious when a test does this, as stderr output tends to be obscured
1549         by noise in the test results.
1550
1551         Also fixes some coding style issues in ResourceLoadDelegate.mm.
1552
1553         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1554         (-[NSError _drt_descriptionSuitableForTestResult]):
1555         (-[NSURL _drt_descriptionSuitableForTestResult]):
1556         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1557         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1558         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1559         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1560         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1561         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1562
1563 2008-09-18  Stephanie Lewis  <slewis@apple.com>
1564
1565         Reviewed by Mark Rowe and Maciej Stachowiak..
1566
1567         add a --64-bit option and specify which architecture to run on Mac.
1568
1569         * Scripts/run-javascriptcore-tests:
1570
1571 2008-09-17  Mark Rowe  <mrowe@apple.com>
1572
1573         Reviewed by Sam Weinig.
1574
1575         Fix a crash seen running DumpRenderTree on fast/dom/null-document-window-open-crash.html under guard malloc.
1576
1577         The JS wrapper for LayoutTestController could outlive the wrapped instance, and would crash when
1578         attempting to access the wrapped instance within layoutTestControllerObjectFinalize. We fix this by making
1579         LayoutTestController ref-counted to ensure that it is not outlived by the JS wrapper.
1580
1581         * DumpRenderTree/ForwardingHeaders/wtf/RefCounted.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefCounted.h.
1582         * DumpRenderTree/LayoutTestController.cpp:
1583         (LayoutTestController::LayoutTestController):
1584         (notifyDoneCallback): Remove code that is no longer needed now that we must always have a wrapped instance.
1585         (layoutTestControllerObjectFinalize): Deref the wrapped object.
1586         (LayoutTestController::makeWindowObject): Ref the wrapped object.
1587         * DumpRenderTree/LayoutTestController.h: Make LayoutTestController RefCounted.
1588         * DumpRenderTree/mac/DumpRenderTree.mm:
1589         (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
1590         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Remove code that is no longer needed.
1591         * DumpRenderTree/win/DumpRenderTree.cpp:
1592         (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
1593
1594 2008-09-16  Sam Weinig  <sam@webkit.org>
1595
1596         Reviewed by Mark Rowe.
1597
1598         Add flag to disable running sample on tests that timeout.
1599
1600         * Scripts/run-webkit-tests:
1601
1602 2008-09-16  Adam Roben  <aroben@apple.com>
1603
1604         Windows build fix after r36511
1605
1606         Update for rename of layoutTestController to gLayoutTestController.
1607
1608         * DumpRenderTree/LayoutTestController.cpp:
1609         * DumpRenderTree/win/EditingDelegate.cpp:
1610         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1611         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1612         * DumpRenderTree/win/UIDelegate.cpp:
1613
1614 2008-09-16  Adam Roben  <aroben@apple.com>
1615
1616         Add a script to print out the dependency tree of a Visual Studio
1617         solution file
1618
1619         * Scripts/print-msvc-project-dependencies: Added.
1620
1621 2008-09-16  Mark Rowe  <mrowe@apple.com>
1622
1623         Fix the build.
1624
1625         * DumpRenderTree/LayoutTestController.cpp:
1626         (notifyDoneCallback): Call fprintf in a safer manner.
1627
1628 2008-09-16  Simon Fraser  <simon.fraser@apple.com>
1629
1630         Reviewed by Eric Seidel
1631         
1632         Protect against tests that call layoutTestController.notifyDone() 
1633         more than once, which would lead to memory corruption, by nulling
1634         out the LayoutTestController on the JSObjectRef on destruction. Also
1635         add a finalize callback on the class so that if the LTC outlives
1636         the JSObjectRef, the JSObjectRef backpointer on the LTC can be
1637         nulled out.
1638         
1639         https://bugs.webkit.org/show_bug.cgi?id=20875
1640
1641         * DumpRenderTree/LayoutTestController.cpp:
1642         (LayoutTestController::LayoutTestController):
1643         (notifyDoneCallback):
1644         (layoutTestControllerObjectFinalize):
1645         (LayoutTestController::makeWindowObject):
1646         (LayoutTestController::getJSClass):
1647         * DumpRenderTree/LayoutTestController.h:
1648         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1649         (LayoutTestController::~LayoutTestController):
1650
1651 2008-09-16  Simon Fraser  <simon.fraser@apple.com>
1652
1653         Reviewed by Eric Seidel
1654
1655         Step 1 patch: rename global variable for clarity.
1656         https://bugs.webkit.org/show_bug.cgi?id=20875
1657
1658         * DumpRenderTree/DumpRenderTree.h:
1659         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1660         (dumpWebViewAsPixelsAndCompareWithExpected):
1661         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1662         (dumpFramesAsText):
1663         (dump):
1664         (runTest):
1665         (processWork):
1666         (webViewLoadFinished):
1667         (webViewWindowObjectCleared):
1668         * DumpRenderTree/mac/DumpRenderTree.mm:
1669         (allocateGlobalControllers):
1670         (dumpFrameScrollPosition):
1671         (dumpFramesAsText):
1672         (methodNameStringForFailedTest):
1673         (dump):
1674         (runTest):
1675         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1676         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1677         * DumpRenderTree/mac/EditingDelegate.mm:
1678         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1679         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1680         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1681         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1682         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1683         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1684         (-[EditingDelegate webViewDidBeginEditing:]):
1685         (-[EditingDelegate webViewDidChange:]):
1686         (-[EditingDelegate webViewDidEndEditing:]):
1687         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1688         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1689         (-[FrameLoadDelegate processWork:]):
1690         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
1691         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1692         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1693         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1694         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1695         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1696         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1697         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1698         * DumpRenderTree/mac/UIDelegate.mm:
1699         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
1700         (-[UIDelegate webViewFocus:]):
1701         (-[UIDelegate webViewUnfocus:]):
1702         (-[UIDelegate webView:createWebViewWithRequest:]):
1703         (-[UIDelegate webViewClose:]):
1704         * DumpRenderTree/win/DumpRenderTree.cpp:
1705         (dumpFrameScrollPosition):
1706         (dumpFramesAsText):
1707         (dump):
1708         (runTest):
1709
1710 2008-09-15  Alice Liu  <alice.liu@apple.com>
1711
1712         A change needed to make PPC bots pass accessibility/table-cell-spans.html layout test
1713
1714         Reviewed by Stephanie Lewis.
1715
1716         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1717         Calling -[NSValue rangeValue] on nil object was returning bogus results on PPC, 
1718         but not Intel.  Add a check for nil before calling. 
1719         (AccessibilityUIElement::rowIndexRange):
1720         (AccessibilityUIElement::columnIndexRange):
1721
1722 2008-09-14  Mark Rowe  <mrowe@apple.com>
1723
1724         Build fix.
1725
1726         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1727         (waitUntilDoneWatchdogFired):
1728         * DumpRenderTree/mac/ObjCPlugin.m:
1729
1730 2008-09-08  Dan Bernstein  <mitz@apple.com>
1731
1732         Reviewed by Mark Rowe.
1733
1734         - add an option to run-webkit-tests to always use the complex text code path
1735
1736         * DumpRenderTree/mac/DumpRenderTree.mm:
1737         (initializeGlobalsFromCommandLineOptions):
1738         (dumpRenderTree):
1739         * Scripts/run-webkit-tests:
1740
1741 2008-09-08  Steve Falkenburg  <sfalken@apple.com>
1742
1743         Another Windows nightly build fix.
1744
1745         Reviewed by Sam Weinig.
1746
1747         * FindSafari/FindSafari.cpp:
1748         (_tmain): Delete existing WebKitNightly directory in temp.
1749         * FindSafari/Safari.exe.manifest: Add PROGIDs for each COM class. Remove non-production classes.
1750
1751 2008-09-07  Stephanie Lewis  <slewis@apple.com>
1752
1753         Reviewed by Mark Rowe.
1754
1755         Fix DRT build 
1756
1757         * DumpRenderTree/DumpRenderTreePrefix.h:
1758         * DumpRenderTree/win/DumpRenderTree.vcproj:
1759
1760 2008-09-06  Steve Falkenburg  <sfalken@apple.com>
1761
1762         Fix Windows nightlies.
1763         
1764         Copy WebKit.dll alongside application so registry-free COM can find it.
1765         Update embedded manifest to force use registry-free COM.
1766
1767         Reviewed by Dave Hyatt.
1768
1769         * FindSafari/FindSafari.cpp:
1770         (copyManifest):
1771         (replaceManifest):
1772         (_tmain):
1773         * FindSafari/FindSafari.rc: Added.
1774         * FindSafari/FindSafari.vcproj:
1775         * FindSafari/Safari.exe.manifest: Added.
1776         * FindSafari/resource.h: Added.
1777
1778 === End merge of squirrelfish-extreme ===
1779
1780 2008-08-31  Mark Rowe  <mrowe@apple.com>
1781
1782         Reviewed by Maciej Stachowiak.
1783
1784         Add a --profile flag to run-sunspider.
1785
1786         * Scripts/webkitdirs.pm: Detect --profile or --profiling passed as a command-line argument
1787         to build scripts as indicating that we should use the "Profiling" configuration.  At present
1788         this is only supported by JavaScriptCore, so using this argument to build any other project
1789         will likely result in unexpected behaviour.
1790
1791 2008-08-27  Mark Rowe  <mrowe@apple.com>
1792
1793         Reviewed by Oliver Hunt.
1794
1795         Fix run-webkit-tests to handle DRT exiting early.
1796
1797         * Scripts/run-webkit-tests: Initialize $expectedResultPaths{$base} before it will be used.
1798
1799 === Start merge of squirrelfish-extreme ===
1800
1801 2008-09-04  Mark Rowe  <mrowe@apple.com>
1802
1803         Reviewed by Eric Seidel.
1804
1805         Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
1806         Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
1807
1808         * Scripts/build-webkit: Remove ENABLE_DASHBOARD_SUPPORT-related code.
1809
1810 2008-09-04  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
1811
1812         Reviewed by Oliver Hunt.
1813
1814         Bug 20616: Incorporate V8 benchmarks in testing
1815         <https://bugs.webkit.org/show_bug.cgi?id=20616>
1816
1817         Add support for the --v8 option to run-sunspider.
1818
1819         * Scripts/run-sunspider:
1820
1821 2008-09-04  Kevin Ollivier  <kevino@theolliviers.com>
1822
1823         wx buildbot fix. More robust handling of clean when makefiles are not built or 
1824         are not completely made.
1825
1826         * wx/build-wxwebkit:
1827
1828 2008-09-03  Mark Rowe  <mrowe@apple.com>
1829
1830         More Mac build fixes.
1831
1832         Set ENABLE_DASHBOARD_SUPPORT when building for Mac via build-webkit.
1833         Also set ENABLE_CROSS_DOCUMENT_MESSAGING in order to match the
1834         default configuration specified in the .xcconfig files.
1835
1836         * Scripts/build-webkit:
1837
1838 2008-09-03  Mark Rowe  <mrowe@apple.com>
1839
1840         Mac build fix.  Ensure that dashboard support is enabled.
1841
1842         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1843
1844 2008-08-25  Steve Falkenburg  <sfalken@apple.com>
1845
1846         Build fix. Copy correct version of ICU.
1847
1848         * DumpRenderTree/win/DumpRenderTree.vcproj:
1849
1850 2008-08-25  Holger Hans Peter Freyther  <zecke@selfish.org>
1851
1852         Reviewed by Simon.
1853
1854         [run-webkit-tests] Use QtLauncher to show the results of the tests
1855         konqueror might not be installed, xdg-open might not be installed but the
1856         QtLauncher should be present.
1857
1858         * Scripts/run-webkit-tests:
1859
1860 2008-08-24  Jon Honeycutt  <jhoneycutt@apple.com>
1861
1862         Initial support for accessibility layout tests on Windows.
1863         https://bugs.webkit.org/show_bug.cgi?id=20497
1864
1865         Reviewed by Sam Weinig.
1866
1867         * DumpRenderTree/AccessibilityController.h: Fix typos.
1868         * DumpRenderTree/AccessibilityUIElement.cpp: Change #import to #include.
1869         * DumpRenderTree/AccessibilityUIElement.h: Define _WINSOCKAPI_ to
1870         prevent oleacc.h, which includes windows.h, from including winsock.h.
1871         Fixed typos.
1872         * DumpRenderTree/win/AccessibilityControllerWin.cpp: Added.
1873         (AccessibilityController::AccessibilityController):
1874         (AccessibilityController::~AccessibilityController):
1875         (AccessibilityController::focusedElement): Get the root element, and
1876         request its focused object.
1877         (AccessibilityController::rootElement): Query Windows for the 
1878         accessible client object for the WebView's window.
1879         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added.
1880         (AccessibilityUIElement::AccessibilityUIElement):
1881         (AccessibilityUIElement::~AccessibilityUIElement):
1882         (AccessibilityUIElement::getLinkedUIElements): Not implemented.
1883         (AccessibilityUIElement::getChildren): Get the child count, and append
1884         each child.
1885         (AccessibilityUIElement::getChildAtIndex): Get the child at the given
1886         index offset by 1. In MSAA, child 0 is the object itself.
1887         (AccessibilityUIElement::allAttributes): Not implemented.
1888         (AccessibilityUIElement::attributesOfLinkedUIElements): Same.
1889         (AccessibilityUIElement::attributesOfChildren): Same.
1890         (AccessibilityUIElement::parameterizedAttributeNames): Same.
1891         (self): Return a VARIANT representing the "self" object. This is used
1892         when calling methods that require a child variant.
1893         (AccessibilityUIElement::role): Get the MSAA role, a long value, and
1894         convert it into a string with GetRoleText().
1895         (AccessibilityUIElement::title): Get the element's title, and convert
1896         it to a JS String.
1897         (AccessibilityUIElement::description): Same, for description.
1898         (AccessibilityUIElement::width):
1899         (AccessibilityUIElement::height):
1900         (AccessibilityUIElement::intValue): Get the object's value as a string,
1901         and convert the string to a double.
1902         (AccessibilityUIElement::minValue): Not implemented.
1903         (AccessibilityUIElement::maxValue): Same.
1904         (AccessibilityUIElement::insertionPointLineNumber): Same.
1905         (AccessibilityUIElement::attributesOfColumnHeaders): Same.
1906         (AccessibilityUIElement::attributesOfRowHeaders): Same.
1907         (AccessibilityUIElement::attributesOfColumns): Same.
1908         (AccessibilityUIElement::attributesOfRows): Same.
1909         (AccessibilityUIElement::attributesOfVisibleCells): Same.
1910         (AccessibilityUIElement::attributesOfHeader): Same.
1911         (AccessibilityUIElement::indexInTable): Same.
1912         (AccessibilityUIElement::rowIndexRange): Same.
1913         (AccessibilityUIElement::columnIndexRange): Same.
1914         (AccessibilityUIElement::lineForIndex): Same.
1915         (AccessibilityUIElement::boundsForRange): Same.
1916         (AccessibilityUIElement::cellForColumnAndRow): Same.
1917         * DumpRenderTree/win/DumpRenderTree.vcproj: Add accessibility files to
1918         project.  Link to oleacc.lib, the MSAA library.
1919         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1920         (FrameLoadDelegate::FrameLoadDelegate): Initialize the accessibility
1921         controller.
1922         (FrameLoadDelegate::didClearWindowObject): Create a new window object
1923         for the accessibility controller.
1924         * DumpRenderTree/win/FrameLoadDelegate.h:
1925
1926 2008-08-21  Simon Fraser  <simon.fraser@apple.com>
1927
1928         Reviewed by Mark Rowe
1929         
1930         Make build-launcher-app work when run from a git repository.
1931         https://bugs.webkit.org/show_bug.cgi?id=20478
1932
1933         * BuildSlaveSupport/build-launcher-app:
1934
1935 2008-08-20  Maxime Britto  <britto@apple.com>
1936
1937         Reviewed by Ada Chan.
1938
1939          rdar://5259746
1940         Mouse events are sent to page while resizing window (affects Gmail)
1941
1942         * DumpRenderTree/win/UIDelegate.h:
1943         (UIDelegate::webViewSendResizeMessage): Add the new interface method, not implemented.
1944
1945 2008-08-19  Chris Fleizach  <cfleizach@apple.com>
1946
1947         Reviewed by Beth Dakin.
1948
1949         Add snowleopard platform in layout tests
1950
1951         Added support for accessing the attributes of
1952         accessibility tables through the accessibility controller
1953         in DumpRenderTree
1954
1955         * DumpRenderTree/AccessibilityUIElement.cpp:
1956         (attributesOfColumnHeadersCallback):
1957         (attributesOfRowHeadersCallback):
1958         (attributesOfColumnsCallback):
1959         (attributesOfRowsCallback):
1960         (attributesOfVisibleCellsCallback):
1961         (attributesOfHeaderCallback):
1962         (indexInTableCallback):
1963         (rowIndexRangeCallback):
1964         (columnIndexRangeCallback):
1965         (childAtIndexCallback):
1966         (cellForColumnAndRowCallback):
1967         (AccessibilityUIElement::getJSClass):
1968         * DumpRenderTree/AccessibilityUIElement.h:
1969         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1970         (convertNSArrayToVector):
1971         (descriptionOfElements):
1972         (AccessibilityUIElement::getLinkedUIElements):
1973         (AccessibilityUIElement::getChildren):
1974         (AccessibilityUIElement::attributesOfLinkedUIElements):
1975         (AccessibilityUIElement::attributesOfChildren):
1976         (AccessibilityUIElement::attributesOfColumnHeaders):
1977         (AccessibilityUIElement::attributesOfRowHeaders):
1978         (AccessibilityUIElement::attributesOfColumns):
1979         (AccessibilityUIElement::attributesOfRows):
1980         (AccessibilityUIElement::attributesOfVisibleCells):
1981         (AccessibilityUIElement::attributesOfHeader):
1982         (AccessibilityUIElement::indexInTable):
1983         (AccessibilityUIElement::rowIndexRange):
1984         (AccessibilityUIElement::columnIndexRange):
1985         (AccessibilityUIElement::cellForColumnAndRow):
1986         * Scripts/run-webkit-tests:
1987
1988 2008-08-19  Alexey Proskuryakov  <ap@webkit.org>
1989
1990         Reviewed by Darin Adler.
1991
1992         Fix run-webkit-tests misreporting crashed tests as timed out ones because DumpRenderTree
1993         is waiting for crash reporter to let it exit.
1994
1995         The fix does not work on Tiger, because the state of the process is indistinguishable from
1996         other waiting processes, at least not with this technique.
1997
1998         * Scripts/run-webkit-tests:
1999
2000 2008-08-18  Alp Toker  <alp@nuanti.com>
2001
2002         Reviewed by Holger Freyther.
2003
2004         https://bugs.webkit.org/show_bug.cgi?id=20350
2005         [GTK] Get DumpRenderTree working
2006
2007         Fixes and enhancements to DumpRenderTree. With these changes, the test
2008         suite can now complete a run producing text and render tree dumps.
2009
2010         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2011         (dumpFramesAsText):
2012         (dump):
2013         (runTest):
2014         (webViewLoadFinished):
2015         (webViewWindowObjectCleared):
2016         (webViewConsoleMessage):
2017         (webViewScriptAlert):
2018         (webViewScriptPrompt):
2019         (webViewScriptConfirm):
2020         (webViewTitleChanged):
2021         (main):
2022         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
2023         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2024         (LayoutTestController::clearBackForwardList):
2025         (LayoutTestController::pathToLocalResource):
2026         (LayoutTestController::setAcceptsEditing):
2027         (LayoutTestController::setUserStyleSheetEnabled):
2028         (LayoutTestController::setUserStyleSheetLocation):
2029         (waitToDumpWatchdogFired):
2030         (LayoutTestController::windowCount):
2031         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2032         (JSStringCopyUTF8CString):
2033         (ScriptItem::invoke):
2034
2035 2008-08-17  Geoffrey Garen  <ggaren@apple.com>
2036
2037         Reviewed by Cameron Zwarich.
2038         
2039         Updated project files to XCode 3.1.
2040
2041         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2042         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2043
2044 2008-08-15  Mark Rowe  <mrowe@apple.com>
2045
2046         Rubber-stamped by Geoff Garen.
2047
2048         <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
2049
2050         * Scripts/check-for-global-initializers: Ignore initializers when building the debug variant.
2051
2052 2008-08-13  Simon Hausmann  <hausmann@webkit.org>
2053
2054         Rubber-stamped by Holger.
2055
2056         Revert r31585 and disable http tests for the Qt build again unless
2057         explicitly enabled.
2058
2059         Running the http tests unfortunately currently still triggers
2060         failures in non-http tests due to side-effects. Disable them by default for
2061         now, for more reliable results.
2062
2063         * Scripts/run-webkit-tests:
2064
2065 2008-08-10  Jan Michael Alonzo  <jmalonzo@webkit.org>
2066
2067         Reviewed (and updated) by Alp Toker.
2068
2069         https://bugs.webkit.org/show_bug.cgi?id=16620
2070         [GTK] Autotools make dist and make check support
2071
2072         Get make dist working.
2073
2074         Note that not all possible configurations have been tested yet.
2075
2076         * GNUmakefile.am:
2077
2078 2008-08-10  Alp Toker  <alp@nuanti.com>
2079
2080         Remove leftover qmake/GTK+ build files.
2081
2082         * DumpRenderTree/gtk/DumpRenderTree.pro: Removed.
2083         * GtkLauncher/GtkLauncher.pro: Removed.
2084
2085 2008-08-06  Chris Fleizach  <cfleizach@apple.com>
2086
2087         Reviewed by Beth Dakin
2088
2089         AX functions shouldn't return position information because it changes
2090         based on the platform
2091
2092         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2093         (AccessibilityUIElement::boundsForRange):
2094
2095 2008-08-06  Eric Seidel  <eric@webkit.org>
2096
2097         Reviewed by darin.
2098         
2099         Fix leaks seen on build-bot by fixing memory management of AccessibilityUIElement.
2100         <https://bugs.webkit.org/show_bug.cgi?id=20297>
2101         <rdar://problem/6093153>
2102         
2103         I've made AccessibilityUIElement a stack object for now.  It could be
2104         made RefCounted, but I figured that might be overkill for the moment.
2105         Essentially it's just a RefPtr itself. :)
2106         
2107         I also fixed a few typos, such as AccessibilityUIElement() instead of ~AccessibilityUIElement()
2108         which was causing additional leaks. :)
2109         
2110         I added toAXElement to remove a bunch of copy/paste code.
2111
2112         * DumpRenderTree/AccessibilityController.h:
2113         * DumpRenderTree/AccessibilityUIElement.cpp:
2114         (toAXElement):
2115         (allAttributesCallback):
2116         (attributesOfLinkedUIElementsCallback):
2117         (attributesOfChildrenCallback):
2118         (lineForIndexCallback):
2119         (boundsForRangeCallback):
2120         (childAtIndexCallback):
2121         (getRoleCallback):
2122         (getTitleCallback):
2123         (getDescriptionCallback):
2124         (getWidthCallback):
2125         (getHeightCallback):
2126         (getIntValueCallback):
2127         (getMinValueCallback):
2128         (getMaxValueCallback):
2129         (getInsertionPointLineNumberCallback):
2130         (finalize):
2131         * DumpRenderTree/AccessibilityUIElement.h:
2132         (AccessibilityUIElement::platformUIElement):
2133         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2134         (AccessibilityController::focusedElement):
2135         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2136         (AccessibilityUIElement::AccessibilityUIElement):
2137         (AccessibilityUIElement::getLinkedUIElements):
2138         (AccessibilityUIElement::getChildren):
2139         (AccessibilityUIElement::getChildAtIndex):
2140         (AccessibilityUIElement::attributesOfLinkedUIElements):
2141         (AccessibilityUIElement::attributesOfChildren):
2142
2143 2008-08-06  Eric Seidel  <eric@webkit.org>
2144
2145         Reviewed by Cameron Zwarich.
2146
2147         Speculative fix for an error I keep seeing in my Cygwin build
2148
2149         * Scripts/webkitdirs.pm: make determineConfigurationProductDir() always call determineConfiguration() even on cygwin
2150
2151 2008-08-02  Kevin Ollivier  <kevino@theolliviers.com>
2152
2153         Forgot to commit licensing correction in last commit.
2154
2155         * wx/packaging/wxWebKitInstaller.iss.in:
2156
2157 2008-08-02  Kevin Ollivier  <kevino@theolliviers.com>
2158
2159         Reviewed by Eric Seidel.
2160         
2161         Scripts for building a wxWebKit installer for wxPython on Win, eventually will
2162         be used for nightlies.
2163         
2164         https://bugs.webkit.org/show_bug.cgi?id=20036
2165
2166         * wx/packaging: Added.
2167         * wx/packaging/build-win-installer.py: Added.
2168         * wx/packaging/wxWebKitInstaller.iss.in: Added.
2169
2170 2008-07-31  Adam Roben  <aroben@apple.com>
2171
2172         Follow-up to r35500
2173
2174         * WinLauncher/WinLauncher.vcproj: Set the manifest properties for the
2175         Release configuration, too.
2176
2177 2008-07-31  Stefan Landvogt <stefan.landvogt@gmail.com>
2178
2179         Fix Bug 20245: WinLauncher does not start in WebKit-debug right out of
2180         the box
2181
2182         <https://bugs.webkit.org/show_bug.cgi?id=20245>
2183
2184         Reviewed by Adam Roben.
2185
2186         * WinLauncher/WinLauncher.vcproj: adding the following properties to
2187         WinLauncher > Properties > Manifest Tool > Isolated COM
2188         Type Library File: $(WebKitOutputDir)\lib\WebKit.tlb
2189         Component File Name: WebKit$(WebKitDLLConfigSuffix)
2190         Doing the change on "All Configurations"
2191
2192 2008-07-31  Adam Roben  <aroben@apple.com>
2193
2194         Windows build bot fix
2195
2196         * DumpRenderTree/win/ImageDiff.vcproj: Don't fail if files that only
2197         exist for people at Apple can't be found. Also updated the ICU version
2198         to 3.8.
2199
2200 2008-07-31  David Kilzer  <ddkilzer@apple.com>
2201
2202         Fix layout test results for webarchive/test-xml-stylesheet.xml
2203
2204         Reviewed by Darin Adler.
2205
2206         * DumpRenderTree/mac/DumpRenderTree.mm:
2207         (convertMIMEType): Work around the "text/xml" local file type
2208         regression in Leopard using the BUILDING_ON_LEOPARD macro.  Also
2209         stop mangling "application/x-javascript" into "text/javascript".
2210         (convertWebResourceDataToString): When checking whether to dump a
2211         resource as text, also check to see if the MIME type is in the
2212         -[WebHTMLRepresentation supportedNonImageMIMETypes] array.
2213         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added BUILDING_ON_LEOPARD
2214         macro.
2215
2216 2008-07-31  Chris Fleizach  <cfleizach@apple.com>
2217
2218         Reviewed by Alice Liu
2219
2220         Add AX support to get the bounds for a range of text
2221         Add AX support to get the child of an element
2222         Add AX support to get all the parameterized attribute names of an element
2223
2224         * DumpRenderTree/AccessibilityUIElement.cpp:
2225         (parameterizedAttributeNamesCallback):
2226         (boundsForRangeCallback):
2227         (childAtIndexCallback):
2228         (AccessibilityUIElement::getJSClass):
2229         * DumpRenderTree/AccessibilityUIElement.h:
2230         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2231         (AccessibilityUIElement::getChildAtIndex):
2232         (AccessibilityUIElement::parameterizedAttributeNames):
2233         (AccessibilityUIElement::boundsForRange):
2234
2235 2008-07-31  Erik Bunce  <elbunce@thehive.com>
2236
2237         Reviewed by Simon.
2238
2239         Make run-launcher set DYLD_LIBRARY_PATH to make things work on Mac OS X.
2240
2241         * Scripts/run-launcher:
2242
2243 2008-07-30  Jessica Kahn  <jess@apple.com>
2244
2245         Reviewed by Adam Roben.
2246
2247         Slightly stricter checking for previous change, suggested by Adam.
2248         
2249         * Scripts/extract-localizable-strings:
2250
2251 2008-07-30  Jessica Kahn  <jess@apple.com>
2252
2253         Reviewed by Darin Adler.
2254
2255         Added support for UI_STRING and UI_STRING_KEY macros with flexible prefixes.
2256         
2257         * Scripts/extract-localizable-strings:
2258
2259 2008-07-30  Anders Carlsson  <andersca@apple.com>
2260
2261         Reviewed by Adam.
2262
2263         Copy icu38* files instead of icu36* files.
2264         
2265         * DumpRenderTree/win/DumpRenderTree.vcproj:
2266
2267 2008-07-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
2268
2269         DRT/Gtk build fix for r35362
2270
2271         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2272         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2273
2274 2008-07-25  Brady Eidson  <beidson@apple.com>
2275
2276         Reviewed by Sam
2277
2278         Add the ability to dump whether-or-not an element should have autocomplete enabled, 
2279         from the perspective of the WebKit API
2280
2281         * DumpRenderTree/LayoutTestController.cpp:
2282         (elementDoesAutoCompleteForElementWithIdCallback):
2283         (LayoutTestController::staticFunctions):
2284
2285         * DumpRenderTree/LayoutTestController.h:
2286         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2287         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2288         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2289         (LayoutTestController::elementDoesAutoCompleteForElementWithId): Stub for now until I can get on Windows
2290
2291 2008-07-25  Chris Fleizach  <cfleizach@apple.com>
2292
2293         Reviewed by Beth Dakin
2294
2295         Add support for AXLineForIndex and AXInsertionPointIndex through the 
2296         accessibility controller
2297
2298         * DumpRenderTree/AccessibilityUIElement.cpp:
2299         (lineForIndexCallback):
2300         (getInsertionPointLineNumberCallback):
2301         (AccessibilityUIElement::getJSClass):
2302         * DumpRenderTree/AccessibilityUIElement.h:
2303         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2304         (AccessibilityUIElement::insertionPointLineNumber):
2305         (AccessibilityUIElement::lineForIndex):
2306
2307 2008-07-25  Adam Roben  <aroben@apple.com>
2308
2309         Try to fix the Windows build bot
2310
2311         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't try to copy files
2312         that don't exist for people outside of Apple.
2313
2314 2008-07-18  Landry Breuil  <landry@openbsd.org>
2315
2316         Bug 19975: [OpenBSD] Patches to enable build of WebKit
2317
2318         <https://bugs.webkit.org/show_bug.cgi?id=19975>
2319
2320         Reviewed by David Kilzer.
2321
2322         * DumpRenderTree/DumpRenderTree.h: OpenBSD doesn't support wide characters.
2323
2324 2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>
2325
2326         CygwinDownloader fails to install necessary packages
2327         https://bugs.webkit.org/show_bug.cgi?id=20075
2328
2329         Reviewed by Mark Rowe.
2330
2331         * CygwinDownloader/cygwin-downloader.zip: Rebuilt after two broken
2332         mirrors removed in r34116. Set MIME type to application/octet-stream.
2333
2334 2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>
2335
2336         CygwinDownloader's make-zip.sh script fails
2337         https://bugs.webkit.org/show_bug.cgi?id=20074
2338
2339         Reviewed by Mark Rowe.
2340
2341         * CygwinDownloader/cygwin-downloader.py:
2342
2343 2008-07-15  Sam Weinig  <sam@webkit.org>
2344
2345         Reviewed by Anders Carlsson.
2346
2347         Refactor accessibility testing code.
2348
2349         We now have:
2350         - AccessibilityController
2351           Controller which has access to the WebView and can provide the focused element, root element
2352           and in the future, elementAtPoint.
2353
2354         - AccessibilityUIElement
2355           Object which provides access to the data provided by the Accessibility APIs.
2356
2357         * DumpRenderTree/AccessibilityController.cpp:
2358         (getFocusedElementCallback):
2359         (getRootElementCallback):
2360         (AccessibilityController::getJSClass):
2361         * DumpRenderTree/AccessibilityController.h:
2362         * DumpRenderTree/AccessibilityUIElement.cpp: Added.
2363         (allAttributesCallback):
2364         (attributesOfLinkedUIElementsCallback):
2365         (attributesOfChildrenCallback):
2366         (getRoleCallback):
2367         (getTitleCallback):
2368         (getDescriptionCallback):
2369         (getWidthCallback):
2370         (getHeightCallback):
2371         (getIntValueCallback):
2372         (getMinValueCallback):
2373         (getMaxValueCallback):
2374         (finalize):
2375         (AccessibilityUIElement::makeJSAccessibilityUIElement):
2376         (AccessibilityUIElement::getJSClass):
2377         * DumpRenderTree/AccessibilityUIElement.h: Added.
2378         (AccessibilityUIElement::platformUIElement):
2379         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2380         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2381         (AccessibilityController::AccessibilityController):
2382         (AccessibilityController::~AccessibilityController):
2383         (AccessibilityController::focusedElement):
2384         (AccessibilityController::rootElement):
2385         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added.
2386         (AccessibilityUIElement::AccessibilityUIElement):
2387         (descriptionOfValue):
2388         (attributesOfElement):
2389         (nsStringToJSStringRef):
2390         (concatenateAttributeAndValue):
2391         (AccessibilityUIElement::getLinkedUIElements):
2392         (AccessibilityUIElement::getChildren):
2393         (AccessibilityUIElement::attributesOfLinkedUIElements):
2394         (AccessibilityUIElement::attributesOfChildren):
2395         (AccessibilityUIElement::allAttributes):
2396         (AccessibilityUIElement::role):
2397         (AccessibilityUIElement::title):
2398         (AccessibilityUIElement::description):
2399         (AccessibilityUIElement::width):
2400         (AccessibilityUIElement::height):
2401         (AccessibilityUIElement::intValue):
2402         (AccessibilityUIElement::minValue):
2403         (AccessibilityUIElement::maxValue):
2404
2405 2008-07-14  Chris Fleizach  <cfleizach@apple.com>
2406
2407         Reviewed by Beth Dakin
2408
2409         Add support to get attributes of the AXChildren of an objecty
2410
2411         * DumpRenderTree/AccessibilityController.cpp:
2412         (attributesOfChildrenForFocusedElementCallback):
2413         (AccessibilityController::staticFunctions):
2414         * DumpRenderTree/AccessibilityController.h:
2415         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2416         (descriptionOfValue):
2417         (AccessibilityController::attributesOfChildrenForFocusedElement):
2418
2419 2008-07-14  Steve Falkenburg  <sfalken@apple.com>
2420
2421         Build fix.
2422
2423         * DumpRenderTree/win/DumpRenderTree.vcproj:
2424
2425 2008-07-14  Adam Roben  <aroben@apple.com>
2426
2427         Attempted Windows build fix
2428
2429         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Add
2430         CoreFoundation/OSXCompatibilityHeaders[/GNUCompatibility] to the
2431         include path.
2432
2433 2008-07-14  Alexey Proskuryakov  <ap@webkit.org>
2434
2435         Reviewed by Geoff Garen.
2436
2437         Eliminate per-thread JavaScript global data instance support and make arbitrary
2438         global data/global object combinations possible.
2439
2440         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
2441         (runJavaScriptThread): Don't pass a released context reference to JSGarbageCollect.
2442         In this scenario, it was causing crashes after each 10-20 tests, because there was a large
2443         chance for a different thread to cause GC after the context was released.
2444
2445 2008-07-11  Stephanie Lewis  <slewis@apple.com>
2446
2447         Reviewed by Darin Adler.
2448
2449         Make sure we read WebCore Leak messages.  Force full document teardown for DumpRenderTree.
2450
2451         Up timeout limit, some slower machines were timing out before crashtracer finished writing out to disk and quitting DRT.
2452
2453         * DumpRenderTree/mac/DumpRenderTree.mm:
2454         (setDefaultsToConsistentValuesForTesting):
2455         (resetWebViewToConsistentStateBeforeTesting):
2456         * Scripts/run-webkit-tests:
2457
2458 2008-07-10  Steve Falkenburg  <sfalken@apple.com>
2459
2460         Build fix.
2461
2462         * DumpRenderTree/win/DumpRenderTree.vcproj:
2463
2464 2008-07-09  Eric Seidel  <eric@webkit.org>
2465
2466         Reviewed by Mark Rowe.
2467         
2468         Print <div> backgrounds when printing from DRT.
2469
2470         * DumpRenderTree/mac/DumpRenderTree.mm:
2471         (setDefaultsToConsistentValuesForTesting):
2472
2473 2008-07-09  Eric Seidel  <eric@webkit.org>
2474
2475         Reviewed by Mark Rowe.
2476
2477         Fix copying of expected results to correct location
2478
2479         * Scripts/run-webkit-tests:
2480
2481 2008-07-09  Eric Seidel  <eric@webkit.org>
2482
2483         Reviewed by aroben.
2484
2485         * DumpRenderTree/LayoutTestController.cpp:
2486         (LayoutTestController::LayoutTestController):
2487         (dumpAsPDFCallback):
2488         (LayoutTestController::staticFunctions):
2489         * DumpRenderTree/LayoutTestController.h:
2490         (LayoutTestController::dumpAsPDF):
2491         (LayoutTestController::setDumpAsPDF):
2492         * DumpRenderTree/mac/DumpRenderTree.mm:
2493         (dumpFrameAsPDF):
2494         (dump):
2495
2496 2008-07-09  Eric Seidel  <eric@webkit.org>
2497
2498         Reviewed by weinig.
2499
2500         Add Content-Type support to DumpRenderTree and run-webkit-tests
2501         and move expected.txt files to expected.webarchive
2502         
2503         https://bugs.webkit.org/show_bug.cgi?id=15565
2504
2505         * DumpRenderTree/cg/ImageDiffCG.cpp:
2506         (compareImages):
2507         (main):
2508         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2509         (printPNG):
2510         * DumpRenderTree/mac/DumpRenderTree.mm:
2511         (dump):
2512         * Scripts/run-webkit-tests:
2513
2514 2008-07-08  Jon Honeycutt  <jhoneycutt@apple.com>
2515
2516         Reviewed by Anders.
2517
2518         Port r34988 to Mac: allow tests to define JavaScript to execute when
2519         NPP_DestroyStream or NPP_URLNotify is called.
2520
2521         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2522         (NPP_New): Remove initialization that happens in pluginAllocate. Look
2523         for new arguments onStreamDestroy and onURLNotify.
2524         (NPP_Destroy): Free onStreamDestroy and onURLNotify.
2525         (executeScript): Code moved from onStreamLoad.
2526         (NPP_NewStream): Call executeScript.
2527         (NPP_DestroyStream): Same.
2528         (NPP_URLNotify): Same.
2529
2530 2008-07-07  Beth Dakin  <bdakin@apple.com>
2531
2532         Reviewed by Anders.
2533
2534         This patch extends DRT accessibility tests to add the ability to 
2535         query the intValue, minValue, and maxValue of the focused element.
2536
2537         * DumpRenderTree/AccessibilityController.cpp:
2538         (intValueOfFocusedElementCallback):
2539         (minValueOfFocusedElementCallback):
2540         (maxValueOfFocusedElementCallback):
2541         (AccessibilityController::staticFunctions):
2542         * DumpRenderTree/AccessibilityController.h:
2543         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2544         (AccessibilityController::intValueOfFocusedElement):
2545         (AccessibilityController::minValueOfFocusedElement):
2546         (AccessibilityController::maxValueOfFocusedElement):
2547
2548 2008-07-07  Steve Falkenburg  <sfalken@apple.com>
2549
2550         Fix build.
2551
2552         * DumpRenderTree/win/ImageDiff.vcproj:
2553
2554 2008-07-02  Jon Honeycutt  <jhoneycutt@apple.com>
2555
2556         Allow tests to define JavaScript to execute when NPP_DestroyStream or
2557         NPP_URLNotify is called.
2558
2559         Reviewed by Anders.
2560
2561         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add a new
2562         property, "returnErrorFromNewStream." This is to support the test for
2563         <rdar://5983747> Safari crashes trying to load the SilverLight plugin,
2564         caused by WebKit calling NPP_DestroyStream after a plug-in returns an
2565         error from NPP_NewStream.
2566         (pluginGetProperty): 
2567         (pluginSetProperty):
2568         (pluginAllocate):
2569         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Added new
2570         members, onStreamDestroy and onURLNotify.
2571         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2572         (NPP_New): Remove initialization of onStreamLoad; this was moved to
2573         pluginAllocate. Look for new arguments onStreamDestroy and
2574         onURLNotify, and store their values.
2575         (NPP_Destroy): Free new members.
2576         (executeScript): Code moved from onStreamLoad
2577         (NPP_NewStream): If returnErrorFromNewStream has been set to true,
2578         return a generic error code. If onStreamLoad is set, execute it as
2579         JavaScript.
2580         (NPP_DestroyStream): If onStreamDestroy is set, execute it as JS.
2581         (NPP_URLNotify): Same, for onURLNotify.
2582
2583 2008-07-02  Brady Eidson  <beidson@apple.com>
2584
2585         Reviewed by Mitz Pettel and John Sullivan
2586
2587         Add the ability to tell DRT to call stopLoading on a WebFrame inside of a didStartProvisionalLoadForFrame
2588         load delegate.
2589
2590         Required to add a layout test for the fix for <rdar://problem/5549871>
2591
2592         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2593         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): If stopProvisionalFrameLoads is set, call
2594           [WebFrame stopLoading] to test for the crash reflected in 5549871
2595
2596         All of the following are infrastructure to add the layoutTestController.setStopProvisionalFrameLoads() call:
2597         * DumpRenderTree/LayoutTestController.cpp:
2598         (LayoutTestController::LayoutTestController):
2599         (setStopProvisionalFrameLoadsCallback):
2600         (LayoutTestController::staticFunctions):
2601         * DumpRenderTree/LayoutTestController.h:
2602         (LayoutTestController::stopProvisionalFrameLoads):
2603         (LayoutTestController::setStopProvisionalFrameLoads):
2604
2605 2008-07-01  Chris Fleizach  <cfleizach@apple.com>
2606
2607         Reviewed by Beth Dakin
2608
2609         Support ability to get width and height of an element through accessibility
2610
2611         * DumpRenderTree/AccessibilityController.cpp:
2612         (widthOfFocusedElementCallback):
2613         (heightOfFocusedElementCallback):
2614         (AccessibilityController::staticFunctions):
2615         * DumpRenderTree/AccessibilityController.h:
2616         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2617         (AccessibilityController::widthOfFocusedElement):
2618         (AccessibilityController::heightOfFocusedElement):
2619
2620 2008-06-30  Chris Fleizach  <cfleizach@apple.com>
2621
2622         Reviewed by Beth Dakin
2623
2624         Support the ability to get the linked ui elements of an object
2625
2626         * DumpRenderTree/AccessibilityController.cpp:
2627         (attributesOfLinkedUIElementsForFocusedElementCallback):
2628         (AccessibilityController::staticFunctions):
2629         * DumpRenderTree/AccessibilityController.h:
2630         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2631         (AccessibilityController::attributesOfLinkedUIElementsForFocusedElement):
2632         (AccessibilityController::allAttributesOfFocusedElement):
2633         (attributesOfElement):
2634         (nsStringToJSStringRef):
2635
2636 2008-06-29  Sam Weinig  <sam@webkit.org>
2637
2638         Fix Tiger build.
2639
2640         * DumpRenderTree/mac/EventSendingController.mm:
2641         (eventTypeForMouseButtonAndAction):
2642
2643 2008-06-27  Eric Seidel  <eric@webkit.org>
2644
2645         Reviewed by darin.
2646
2647         Add multi-button mouseevent support to DRT
2648         https://bugs.webkit.org/show_bug.cgi?id=15173
2649         
2650         It's now possible to specify the mouse button with:
2651         eventSender.mouseDown(1); eventSender.mouseUp(1); etc.
2652
2653         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2654         * DumpRenderTree/mac/EventSendingController.h:
2655         * DumpRenderTree/mac/EventSendingController.mm:
2656         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2657         (+[EventSendingController webScriptNameForSelector:]):
2658         (eventTypeForMouseButtonAndAction):
2659         (-[EventSendingController updateClickCountForButton:]):
2660         (-[EventSendingController mouseDown:]):
2661         (-[EventSendingController mouseUp:]):
2662         (-[EventSendingController mouseMoveToX:Y:]):
2663         (-[EventSendingController contextClick]):
2664
2665 2008-06-28  Nikolas Zimmermann  <zimmermann@kde.org>
2666
2667         Reviewed by Oliver.
2668
2669         Copy <test>-expected.png from the right location to /tmp/layout-test-results.
2670         Use $expectedPixelDir instead of $expectedDir. Allows using SVG pixel tests again.
2671
2672         * Scripts/run-webkit-tests:
2673
2674 2008-06-27  Jan Michael Alonzo  <jmalonzo@webkit.org>
2675
2676         Reviewed by Christian Dywan.
2677
2678         [Gtk] Initialize webview settings before running DRT tests
2679         http://bugs.webkit.org/show_bug.cgi?id=19778
2680
2681         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2682         (setDefaultsToConsistentStateValuesForTesting):
2683         (main):
2684
2685 2008-06-26  Darin Adler  <darin@apple.com>
2686
2687         * Scripts/check-for-weak-vtables: Fixed comment.
2688
2689 2008-06-26  Darin Adler  <darin@apple.com>
2690
2691         * Scripts/check-for-weak-vtables: Added.
2692
2693 2008-06-26  Beth Dakin  <bdakin@apple.com>
2694
2695         Reviewed by Sam.
2696
2697         Do not include AXPosition in the dump of all of the accessibility 
2698         attributes since it is screen-specific.
2699
2700         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2701         (AccessibilityController::allAttributesOfFocusedElement):
2702
2703 2008-06-26  Beth Dakin  <bdakin@apple.com>
2704
2705         Reviewed by Anders.
2706
2707         This is a speculative fix for the failing layout test on the build 
2708         bot. It seems that the problem that the Build Bot is having is 
2709         Tiger-specific. On Tiger, [NSValue description] was not very smart. 
2710         So I replaced our call to description with a hand-rolled equivalent 
2711         that will match on both platforms. 
2712
2713         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2714         (descriptionOfValue):
2715
2716 2008-06-25  Beth Dakin  <bdakin@apple.com>
2717
2718         Reviewed by Sam Weinig.
2719
2720         This patch adds support to the AccessibilityController to query the 
2721         following attributes specifically, without a full attribute dump: 
2722         AXRole, AXTitle, and AXDescription.
2723
2724         * DumpRenderTree/AccessibilityController.cpp:
2725         (allAttributesForFocusedElementCallback):
2726         (roleOfFocusedElementCallback):
2727         (titleOfFocusedElementCallback):
2728         (descriptionOfFocusedElementCallback):
2729         (AccessibilityController::staticFunctions):
2730         * DumpRenderTree/AccessibilityController.h:
2731         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2732         (AccessibilityController::allAttributesForFocusedElement):
2733         (concatenateAttributeAndValue):
2734         (AccessibilityController::roleOfFocusedElement):
2735         (AccessibilityController::titleOfFocusedElement):
2736         (AccessibilityController::descriptionOfFocusedElement):
2737
2738 2008-06-24  Dan Bernstein  <mitz@apple.com>
2739
2740         Reviewed by Stephanie Lewis.
2741
2742         - move the linker flags from the debug configuration in the project
2743           to the shared configuration
2744
2745         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2746         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2747
2748 2008-06-24  Dan Bernstein  <mitz@apple.com>
2749
2750         - try to fix the Tiger build
2751
2752         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2753
2754 2008-06-24  Sam Weinig and Beth Dakin  <bdakin@apple.com and sam@webkit.org>
2755
2756         Reviewed by Darin Adler.
2757
2758         Fix for <rdar://problem/5884881> Make DumpRenderTree support 
2759         accessibility tests
2760
2761         This patch adds some basic support for accessibility layout tests 
2762         on the Mac.
2763
2764         * DumpRenderTree/AccessibilityController.cpp: Added.
2765         (AccessibilityController::AccessibilityController):
2766         (AccessibilityController::~AccessibilityController):
2767         (dumpCurrentAttributesCallback):
2768         (AccessibilityController::makeWindowObject):
2769         (AccessibilityController::getJSClass):
2770         (AccessibilityController::staticFunctions):
2771         * DumpRenderTree/AccessibilityController.h: Added.
2772         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2773         * DumpRenderTree/mac/AccessibilityControllerMac.mm: Added.
2774         (descriptionOfValue):
2775         (AccessibilityController::dumpCurrentAttributes):
2776         * DumpRenderTree/mac/DumpRenderTree.mm:
2777         * DumpRenderTree/mac/FrameLoadDelegate.h:
2778         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2779         (-[FrameLoadDelegate init]):
2780         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2781
2782 2008-06-24  John Sullivan  <sullivan@apple.com>
2783
2784         Reviewed by Dan Bernstein
2785
2786         * Scripts/extract-localizable-strings:
2787         add UI_STRING_LOCALIZE_LATER, LPCTSTR_UI_STRING_LOCALIZE_LATER, and LOG_WARNING to the 
2788         list of debugging macros, to avoid noise when keeping the list of localized string 
2789         exceptions up to date
2790
2791 2008-06-24  Dan Bernstein  <mitz@apple.com>
2792
2793         Rubber-stamped by Darin Adler.
2794
2795         - add a font family for testing font-weight
2796
2797         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linker
2798         flags to create data sections for the WeightWatcher fonts.
2799         * DumpRenderTree/fonts: Added.
2800         * DumpRenderTree/fonts/WebKitWeightWatcher100.ttf: Added.
2801         * DumpRenderTree/fonts/WebKitWeightWatcher200.ttf: Added.
2802         * DumpRenderTree/fonts/WebKitWeightWatcher300.ttf: Added.
2803         * DumpRenderTree/fonts/WebKitWeightWatcher400.ttf: Added.
2804         * DumpRenderTree/fonts/WebKitWeightWatcher500.ttf: Added.
2805         * DumpRenderTree/fonts/WebKitWeightWatcher600.ttf: Added.
2806         * DumpRenderTree/fonts/WebKitWeightWatcher700.ttf: Added.
2807         * DumpRenderTree/fonts/WebKitWeightWatcher800.ttf: Added.
2808         * DumpRenderTree/fonts/WebKitWeightWatcher900.ttf: Added.
2809         * DumpRenderTree/mac/DumpRenderTree.mm:
2810         (activateFonts): Renamed activateAhemFont to this and made it activate
2811         the WeightWatcher fonts in addition to Ahem.
2812         (prepareConsistentTestingEnvironment): Adjusted for the name change.
2813         * DumpRenderTree/win/DumpRenderTree.cpp:
2814         (initialize): Added the WeightWatcher fonts.
2815
2816 2008-06-20  Brent Fulgham  <bfulgham@gmail.com>
2817
2818         Reviewed by Darin Adler.
2819
2820         Extend the build-webkit (and set-webkit-configuration) script to
2821         support Cairo-based webkit builds.  (see http://bugs.webkit.org/show_bug.cgi?17952)
2822
2823         * Scripts/build-webkit:  Add --cairo-win32 to the help message
2824         * Scripts/webkitdirs.pm:  Extend the 'determinePassedConfiguration
2825           subroutine to recognize the --cairo-win32 flag.  When present,
2826           the build configuration is changed from Debug/Release to
2827           Debug_Cairo/Release_Cairo.  This flag is only active when the
2828           isCygwin() test is true.
2829
2830 2008-06-17  Dan Bernstein  <mitz@apple.com>
2831
2832         Reviewed by Justin Garcia.
2833
2834         - prefer Leopard results when running on Snow Leopard.
2835
2836         * Scripts/run-webkit-tests: Added a mapping of Snow Leopard to
2837           mac-leopard.
2838         * Scripts/webkitdirs.pm: Added isSnowLeopard().
2839
2840 2008-06-15  Darin Adler  <darin@apple.com>
2841
2842         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2843
2844 2008-06-15  Darin Adler  <darin@apple.com>
2845
2846         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2847
2848 2008-06-15  Darin Adler  <darin@apple.com>
2849
2850         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2851
2852 2008-06-15  Darin Adler  <darin@apple.com>
2853
2854         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2855
2856 2008-06-15  Darin Adler  <darin@apple.com>
2857
2858         * Scripts/do-file-rename: Updated.
2859         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2860
2861 2008-06-15  Darin Adler  <darin@apple.com>
2862
2863         * Scripts/do-file-rename: Updated for the latest round of renaming.
2864         * Scripts/do-webcore-rename: Tweaked and reorganized a bit.
2865
2866 2008-06-15  Darin Adler  <darin@apple.com>
2867
2868         * Scripts/create-exports: Added.
2869         * Scripts/do-file-rename: Added some planned renames.
2870         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2871
2872 2008-06-15  Darin Adler  <darin@apple.com>
2873
2874         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
2875
2876 2008-06-15  Maciej Stachowiak  <mjs@apple.com>
2877
2878         Reviewed by Oliver.
2879         
2880         - rename testkjs to jsc
2881
2882         * Scripts/build-jsc: Copied from Scripts/build-testkjs.
2883         * Scripts/build-testkjs: Removed.
2884         * Scripts/run-javascriptcore-tests:
2885         * Scripts/run-jsc: Copied from Scripts/run-testkjs.
2886         * Scripts/run-sunspider:
2887         * Scripts/run-testkjs: Removed.
2888         * Scripts/sunspider-compare-results:
2889
2890 2008-06-14  Darin Adler  <darin@apple.com>
2891
2892         * Scripts/do-webcore-rename: Moved planned renames into a separate hash
2893         from the actual renames. Removed many renames that are either done or
2894         no longer planned.
2895
2896 2008-06-14  Darin Adler  <darin@apple.com>
2897
2898         * Scripts/do-webcore-rename: Fixed obvious typo.
2899
2900 2008-06-13  Darin Adler  <darin@apple.com>
2901
2902         * Scripts/make-js-test-wrappers: Added three more exceptions.
2903
2904 2008-06-10  Joerg Bornemann  <joerg.bornemann@trolltech.com>
2905
2906         Reviewed by Simon.
2907
2908         For the qmake based build make it possible to build against makespecs where
2909         QMAKE_CC is defined in a configuration file included from qmake.conf.
2910
2911         * Scripts/webkitdirs.pm: Added support for include() statements in
2912         qmake.conf.
2913
2914 2008-06-09  Alp Toker  <alp@nuanti.com>
2915
2916         gcc3/autotools build fix. Add explicit -O2 -fno-strict-aliasing to
2917         each of the tools since these are no longer set globally.
2918
2919         * GNUmakefile.am:
2920
2921 2008-06-08  Darin Adler  <darin@apple.com>
2922
2923         * Scripts/make-js-test-wrappers: Added another exception.
2924
2925 2008-06-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
2926
2927         Reviewed by Timothy.
2928
2929         Remove the --squirrelfish option from SunSpider, as it is no longer needed.
2930
2931         * Scripts/run-sunspider:
2932
2933 2008-06-05  Alp Toker  <alp@nuanti.com>
2934
2935         Build fix for r34387.
2936
2937         * GNUmakefile.am:
2938
2939 2008-06-04  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
2940
2941         Reviewed by Oliver.
2942
2943         Add an exception for Opcode.o to the global initializers check so that
2944         we can dump instruction statistics in the JavaScript virtual machine.
2945
2946         * Scripts/check-for-global-initializers:
2947
2948 2008-05-30  Steve Falkenburg  <sfalken@apple.com>
2949
2950         Generate an isolated COM manifest for registry free COM.
2951         
2952         * DumpRenderTree/win/DumpRenderTree.vcproj:
2953
2954 2008-06-02  Anders Carlsson  <andersca@apple.com>
2955
2956         Reviewed by David Hyatt and Mitz.
2957
2958         <rdar://problem/5704119> 
2959         repro crash in WebCore::RenderPart::setWidget (plugin-related?)
2960         
2961         Call -[WebView display] in the "plug-in" failed delegate method, simulating
2962         the sheet that Safari puts up.
2963         
2964         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2965         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
2966
2967 2008-05-30  Timothy Hatcher  <timothy@apple.com>
2968
2969         Made the starting line number of scripts be 1-based throughout the engine.
2970         This cleans up script line numbers so they are all consistent now.
2971
2972         Reviewed by Oliver Hunt.
2973
2974         * DumpRenderTree/mac/ObjCController.m:
2975         (runJavaScriptThread): Pass a line number of 1 instead of 0 to JSEvaluateScript.
2976         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
2977         (runJavaScriptThread): Ditto.
2978         * DumpRenderTree/win/DumpRenderTree.cpp:
2979         (runJavaScriptThread): Ditto.
2980
2981 2008-05-29  Geoffrey Garen  <ggaren@apple.com>
2982
2983         Reviewed by Adam Roben.
2984
2985         Fixed VCSUtils.pm to work with git repositories inside symlinks.
2986
2987         * Scripts/VCSUtils.pm: Compute a relative path from the git repository
2988         root, instead of the root of the filesystem, to work around a bug in
2989         abs2rel when traversing symlinked home directories.
2990
2991 2008-05-29  Kevin Ollivier  <kevino@theolliviers.com>
2992
2993         Reviewed by Darin Adler.
2994         
2995         Restore original behavior of isOSX() referring to the Mac port, not the OS itself.
2996         
2997         https://bugs.webkit.org/show_bug.cgi?id=19311
2998
2999         * Scripts/webkitdirs.pm:
3000
3001 2008-05-29  Alexey Proskuryakov  <ap@webkit.org>
3002
3003         Reviewed by Adam Roben.
3004
3005         Fix run-iexploder-tests and run-mangleme-tests to work with updated shared scripts and
3006         configuration files.
3007
3008         * Scripts/run-iexploder-tests:
3009         * Scripts/run-mangleme-tests:
3010         Renamed runSafari to not conflict with the one in webkitdirs.
3011         Added SSLCertificateFile option for httpd, as now needed.
3012
3013 2008-05-27  Kevin Ollivier  <kevino@theolliviers.com>
3014
3015         wx build fix. Update the sample app after wxWebFrame->wxWebBrowserShell rename.
3016
3017         * wx/browser/browser.cpp:
3018         (MyApp::OnInit):
3019
3020 2008-05-24  Andreia Gaita  <shana@isninja.com>
3021
3022         Reviewed by Alp Toker.
3023
3024         cygwin-downloader.py fixes.
3025
3026         Remove two non-working mirrors. Add a check for missing dependency
3027         packages to avoid bailing out on an inconsistent Cygwin package list.
3028
3029         * CygwinDownloader/cygwin-downloader.py:
3030
3031 2008-05-24  Jan Michael Alonzo  <jmalonzo@webkit.org>
3032
3033         Reviewed by Darin Adler.
3034
3035         Remove useQmake usage. QMake build doesn't support Gtk port
3036         anymore.
3037
3038         Also fix 2 occurences of "Web Kit". Should be WebKit.
3039
3040         * Scripts/build-webkit:
3041         * Scripts/run-javascriptcore-tests:
3042         * Scripts/run-launcher:
3043         * Scripts/run-webkit-tests:
3044         * Scripts/webkitdirs.pm:
3045
3046 2008-05-22  Stephanie Lewis  <slewis@apple.com>
3047
3048         Reviewed by Dan.
3049
3050         implement the beforeUnload UI delegate so that DRT will dispatch beforeunload events.
3051
3052         * DumpRenderTree/mac/UIDelegate.mm:
3053         (-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]):
3054         * DumpRenderTree/win/UIDelegate.cpp:
3055         (SearchableWebViewHost::runBeforeUnloadConfirmPanelWithMessage):
3056
3057 2008-05-21  Adele Peterson  <adele@apple.com>
3058
3059         Reviewed by Adam.
3060
3061         DumpRenderTree support for <rdar://problem/5787733> fast/dom/HTMLDocument/hasFocus.html fails on Windows
3062
3063         * DumpRenderTree/win/UIDelegate.cpp:
3064         (UIDelegate::webViewFocus): Added.
3065         (UIDelegate::webViewUnfocus): Added.
3066         * DumpRenderTree/win/UIDelegate.h:
3067
3068 2008-05-21  Mark Rowe  <mrowe@apple.com>
3069
3070         Rubber-stamped by Stephanie Lewis.
3071
3072         Set the pass_through flag on Getopt so that extra arguments can be passed through to Safari,
3073         rather than trigger an unknown argument message.  This allows run-webkit-tests to display results
3074         once more.
3075
3076         * Scripts/run-safari:
3077
3078 2008-05-21  Stephanie Lewis  <slewis@apple.com>
3079
3080         Reviewed by Maciej, Mark.
3081   
3082         arch doesn't take arguments on tiger.  expand DRT timeout for guardMalloc.
3083
3084         * Scripts/run-webkit-tests:
3085         * Scripts/webkitdirs.pm:
3086
3087 2008-05-20  Mark Rowe  <mrowe@apple.com>
3088
3089         Reviewed by Stephanie Lewis.
3090
3091         Improve the behavior of run-webkit-tests with 64-bit WebKit by automatically inferring whether to run 64-bit.
3092
3093         If --64-bit is not passed to run-webkit-tests, attempt to guess whether we should run 64-bit.
3094         This decision is made based on the 64-bitness of the built WebKit framework if it exists, and
3095         can be manually overridden by passing --64-bit or --no-64-bit.  This removes the need to always
3096         pass an argument to run-webkit-tests after having built with "make x86_64".
3097
3098         * Scripts/gdb-safari:
3099         * Scripts/run-safari:
3100         * Scripts/run-webkit-tests:
3101         * Scripts/webkitdirs.pm: Split the setting of the 64-bit flag, the determination of the
3102         preferred architecture, and exporting of the environment variables for 'arch' out into
3103         separate subroutines.
3104
3105 2008-05-20  Mark Rowe  <mrowe@apple.com>
3106
3107         Fix "make x86_64" by adding x86_64 target to WebKitTools Makefile.
3108
3109         * Makefile:
3110
3111 === End merge of squirrelfish ===
3112
3113 2008-04-14  Maciej Stachowiak  <mjs@apple.com>
3114
3115         Reviewed by Oliver.
3116         
3117         - added support for --ubench mode
3118
3119         * Scripts/run-sunspider:
3120
3121 2008-03-26  Geoffrey Garen  <ggaren@apple.com>
3122
3123         Reviewed by Oliver Hunt.
3124
3125         --squirrelfish mode: pared down tests for squirrelfish to chew on.
3126
3127         * Scripts/run-sunspider:
3128
3129 === Start merge of squirrelfish ===
3130
3131 2008-05-21  Darin Adler  <darin@apple.com>
3132
3133         * Scripts/make-js-test-wrappers: Added another exception.
3134
3135 2008-05-19  Stephanie Lewis  <slewis@apple.com>
3136
3137         Reviewed by Adam.
3138
3139         Explicitly set run mode to 32bit unless overridden to avoid
3140         confusion when running tests
3141
3142         * Scripts/build-dumprendertree:
3143         * Scripts/gdb-safari:
3144         * Scripts/run-webkit-tests:
3145         * Scripts/webkitdirs.pm:
3146
3147 2008-05-16  Stephanie Lewis  <slewis@apple.com>
3148
3149         Reviewed by Steve.
3150
3151         Print out pending unload event count. Also print out main frame name to match Mac.         
3152
3153         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3154         (descriptionSuitableForTestResult):
3155         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
3156
3157 2008-05-16  Timothy Hatcher  <timothy@apple.com>
3158
3159         Remove the Drosera project, code and resources since it has been
3160         replaced with the Web Inspector's debugger. Removes references to
3161         Drosera in various scripts and makefiles.
3162
3163         Rubber-stamped by Mark Rowe.
3164
3165         * BuildSlaveSupport/build-launcher-app:
3166         * Drosera/DebuggerDocument.cpp: Removed.
3167         * Drosera/DebuggerDocument.h: Removed.
3168         * Drosera/Drosera.icns: Removed.
3169         * Drosera/DroseraWin.make: Removed.
3170         * Drosera/English.lproj/Debugger.nib/classes.nib: Removed.
3171         * Drosera/English.lproj/Debugger.nib/info.nib: Removed.
3172         * Drosera/English.lproj/Debugger.nib/keyedobjects.nib: Removed.
3173         * Drosera/English.lproj/MainMenu.nib/classes.nib: Removed.
3174         * Drosera/English.lproj/MainMenu.nib/info.nib: Removed.
3175         * Drosera/English.lproj/MainMenu.nib/keyedobjects.nib: Removed.
3176         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
3177         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Removed.
3178         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
3179         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
3180         * Drosera/ForwardingHeaders/wtf/Platform.h: Removed.
3181         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Removed.
3182         * Drosera/Images/Drosera.ico: Removed.
3183         * Drosera/Images/SourceArrow.png: Removed.
3184         * Drosera/Images/SourceArrowBlank.png: Removed.
3185         * Drosera/Images/SourceArrowOpen.png: Removed.
3186         * Drosera/Images/background_stripe.png: Removed.
3187         * Drosera/Images/breakPoint.tif: Removed.
3188         * Drosera/Images/breakPointDisabled.tif: Removed.
3189         * Drosera/Images/breakpointeditor.png: Removed.
3190         * Drosera/Images/close.tif: Removed.
3191         * Drosera/Images/close_active.tif: Removed.
3192         * Drosera/Images/close_hover.tif: Removed.
3193         * Drosera/Images/console.png: Removed.
3194         * Drosera/Images/continue.tif: Removed.
3195         * Drosera/Images/fileIcon.jpg: Removed.
3196         * Drosera/Images/finishFunction.tif: Removed.
3197         * Drosera/Images/glossyFooterFill.tif: Removed.
3198         * Drosera/Images/glossyHeader.png: Removed.
3199         * Drosera/Images/glossyHeaderPressed.png: Removed.
3200         * Drosera/Images/gradientBackground.png: Removed.
3201         * Drosera/Images/gutter.png: Removed.
3202         * Drosera/Images/navLeftDisabled.png: Removed.
3203         * Drosera/Images/navLeftNormal.png: Removed.
3204         * Drosera/Images/navLeftPressed.png: Removed.
3205         * Drosera/Images/navRightDisabled.png: Removed.
3206         * Drosera/Images/navRightNormal.png: Removed.
3207         * Drosera/Images/navRightPressed.png: Removed.
3208         * Drosera/Images/pause.tif: Removed.
3209         * Drosera/Images/popUpArrows.png: Removed.
3210         * Drosera/Images/programCounter.tif: Removed.
3211         * Drosera/Images/programCounterBreakPoint.tif: Removed.
3212         * Drosera/Images/programCounterBreakPointDisabled.tif: Removed.
3213         * Drosera/Images/run.tif: Removed.
3214         * Drosera/Images/siteCollapsed.tif: Removed.
3215         * Drosera/Images/siteExpanded.tif: Removed.
3216         * Drosera/Images/siteIcon.tif: Removed.
3217         * Drosera/Images/small.ico: Removed.
3218         * Drosera/Images/splitterBar.tif: Removed.
3219         * Drosera/Images/splitterDimple.tif: Removed.
3220         * Drosera/Images/step.tif: Removed.
3221         * Drosera/Images/stepOut.tif: Removed.
3222         * Drosera/Images/stepOver.tif: Removed.
3223         * Drosera/Images/stop.tif: Removed.
3224         * Drosera/Images/toolbarBackground.png: Removed.
3225         * Drosera/Images/verticalSplitterBar.tiff: Removed.
3226         * Drosera/Images/verticalSplitterDimple.tiff: Removed.
3227         * Drosera/Makefile: Removed.
3228         * Drosera/breakpointEditor.html: Removed.
3229         * Drosera/config.h: Removed.
3230         * Drosera/console.css: Removed.
3231         * Drosera/console.html: Removed.
3232         * Drosera/console.js: Removed.
3233         * Drosera/debugger.css: Removed.
3234         * Drosera/debugger.html: Removed.
3235         * Drosera/debugger.js: Removed.
3236         * Drosera/mac/DebuggerApplication.h: Removed.
3237         * Drosera/mac/DebuggerApplication.mm: Removed.
3238         * Drosera/mac/DebuggerClient.h: Removed.
3239         * Drosera/mac/DebuggerClient.mm: Removed.
3240         * Drosera/mac/DebuggerDocumentPlatform.mm: Removed.
3241         * Drosera/mac/Drosera.xcodeproj/project.pbxproj: Removed.
3242         * Drosera/mac/Info.plist: Removed.
3243         * Drosera/mac/LauncherInfo.plist: Removed.
3244         * Drosera/mac/Makefile: Removed.
3245         * Drosera/mac/ServerConnection.h: Removed.
3246         * Drosera/mac/ServerConnection.mm: Removed.
3247         * Drosera/mac/launcher.m: Removed.
3248         * Drosera/mac/main.m: Removed.
3249         * Drosera/viewer.css: Removed.
3250         * Drosera/viewer.html: Removed.
3251         * Drosera/win/BaseDelegate.h: Removed.
3252         * Drosera/win/DebuggerClient.cpp: Removed.
3253         * Drosera/win/DebuggerClient.h: Removed.
3254         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
3255         * Drosera/win/Drosera.cpp: Removed.
3256         * Drosera/win/Drosera.h: Removed.
3257         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed.
3258         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed.
3259         * Drosera/win/DroseraPrefix.cpp: Removed.
3260         * Drosera/win/DroseraPrefix.h: Removed.
3261         * Drosera/win/Info.plist: Removed.
3262         * Drosera/win/ServerConnection.cpp: Removed.
3263         * Drosera/win/ServerConnection.h: Removed.
3264         * Drosera/win/resource.h: Removed.
3265         * Makefile:
3266         * Scripts/build-drosera: Removed.
3267         * Scripts/gdb-drosera: Removed.
3268         * Scripts/run-drosera: Removed.
3269         * Scripts/run-drosera-nightly.cmd: Removed.
3270         * Scripts/run-drosera.cmd: Removed.
3271         * Scripts/webkitdirs.pm:
3272
3273 2008-05-15  Stephanie Lewis  <slewis@apple.com>
3274
3275         Reviewed by Anders.
3276
3277         Dump the unload count for a frame after parsing is finished.
3278
3279         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3280         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3281
3282 2008-05-15  Alexey Proskuryakov  <ap@webkit.org>
3283
3284         Reviewed by Dan Bernstein.
3285
3286         https://bugs.webkit.org/show_bug.cgi?id=10707
3287         DumpRenderTree should not be able to access non-local resources
3288
3289         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3290         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3291         Block them, and complain.
3292
3293 2008-05-15  Kevin Ollivier  <kevino@theolliviers.com>
3294
3295         wx build fix. Update the version of libpng to download and instsall.
3296
3297         * wx/install-unix-extras:
3298
3299 2008-05-14  Julien Chaffraix  <jchaffraix@webkit.org>
3300
3301         Reviewed by Eric.
3302
3303         - isDarwin() and isCygwin() returned an empty string if the platform equality check fails.
3304           We now force the return value to be numeric.
3305
3306         - Removed platform checks as it was a work around the previous issue.
3307
3308         - Replaced isDarwin() by isOSX() as they have now the same behaviour.
3309
3310         * Scripts/build-webkit:
3311         * Scripts/webkitdirs.pm:
3312
3313 2008-05-12  Adam Roben  <aroben@apple.com>
3314
3315         Support for testing NPN_PostURL
3316
3317         Reviewed by Anders Carlsson.
3318
3319         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3320         (toCString): Added this helper function.
3321         (testPostURLFile): Added. Writes the passed-in content to the
3322         passed-in file and calls NPN_PostURL with the passed-in URL and
3323         target.
3324         (pluginInvoke): Added a case for testPostURLFile.
3325         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3326         (followShortcuts): Changed to allow paths that don't yet exist.
3327
3328 2008-05-12  Mark Rowe  <mrowe@apple.com>
3329
3330         Reviewed by Sam Weinig.
3331
3332         Minor cleanup of the DRT Xcode project.
3333
3334         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Use GCC_OPTIMIZATION_LEVEL rather than
3335         OPTIMIZATION_CFLAGS.  Don't include Info.plist in the "Copy Bundle Resources" build phase as it does
3336         not need to be there.
3337
3338 2008-05-12  Anders Carlsson  <andersca@apple.com>
3339
3340         Reviewed by Adam.
3341
3342         Add support for testing application caches.
3343         
3344         * DumpRenderTree/mac/DumpRenderTree.mm:
3345         (dumpRenderTree):
3346         Empty the cache.
3347         
3348         (resetWebViewToConsistentStateBeforeTesting):
3349         Turn on support for the application cache.
3350
3351 2008-05-09  Mark Rowe  <mrowe@apple.com>
3352
3353         Reviewed by Anders Carlsson.
3354
3355         Update TestNetscapePlugIn to build 64-bit using the Cocoa event model.
3356
3357         It currently does not attempt to print events which means that plugins/mouse-events.html
3358         will fail when run 64-bit.  All other tests that use this plugin pass.
3359
3360         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3361         (testGetIntIdentifier):
3362         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3363         (NPP_New):
3364         (NPP_HandleEvent):
3365
3366 2008-05-09  Brady Eidson  <beidson@apple.com>
3367
3368         Reviewed by Adam Roben
3369
3370         Explicitly call shutDownWebKit() before quitting.
3371
3372         * Drosera/win/Drosera.cpp:
3373         (_tWinMain):
3374
3375         * DumpRenderTree/win/DumpRenderTree.cpp:
3376         (main):
3377
3378 2008-05-09  Mark Rowe  <mrowe@apple.com>
3379
3380         Fix the Tiger build of Drosera.
3381
3382         * Drosera/config.h: Define BUILDING_ON_TIGER when building on Tiger.
3383
3384 2008-05-09  Sam Weinig  <sam@webkit.org>
3385
3386         Rubber-stamped by Mark Rowe.
3387
3388         Remove the ENABLE_CROSS_DOCUMENT_MESSAGING #ifdefs.
3389
3390         * Scripts/build-webkit:
3391
3392 2008-05-08  Mark Rowe  <mrowe@apple.com>
3393
3394         Another attempt at a Tiger build fix.
3395
3396         Use DumpRenderTreeMac.h rather than DumpRenderTree.h as DumpRenderTreePasteboard is not an Obj-C++ file.
3397
3398         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3399
3400 2008-05-08  Mark Rowe  <mrowe@apple.com>
3401
3402         Tiger build fix.  Include DumpRenderTree.h so that BUILDING_ON_TIGER will be defined.
3403
3404         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3405
3406 2008-05-08  Mark Rowe  <mrowe@apple.com>
3407
3408         Reviewed by Oliver Hunt and Dan Bernstein.
3409
3410         Update DumpRenderTree to build 64-bit.
3411
3412         The three major changes here are:
3413         1) Use NSInteger in the appropriate places.
3414         2) Use ColorSync API that is available in 64-bit to switch display profiles.
3415         3) Use method-swizzling to achieve similar results to class posing when using the Obj-C 2.0 runtime.
3416
3417         The build of DumpRenderTree will still fail in 64-bit for now as the TestNetscapePlugIn target also
3418         needs updated to successfully build.
3419
3420         * DumpRenderTree/mac/Configurations/Base.xcconfig: Don't prevent Xcode from building 64-bit.
3421         * DumpRenderTree/mac/DumpRenderTree.mm:
3422         (swizzleAllMethods):
3423         (poseAsClass):
3424         (prepareConsistentTestingEnvironment):
3425         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3426         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3427         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3428         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3429         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3430         (restoreColorSpace):
3431         (failedGettingCurrentProfile):
3432         (setDefaultColorProfileToRGB):
3433
3434 2008-05-08  Mark Rowe  <mrowe@apple.com>
3435
3436         Reviewed by Darin Adler.
3437
3438         Clean up Drosera so that it will build 64-bit.
3439
3440         * Drosera/mac/DebuggerApplication.mm:
3441         (-[DebuggerApplication numberOfRowsInTableView:]): Use NSInteger rather than int.
3442         (-[DebuggerApplication tableView:objectValueForTableColumn:row:]): Ditto.
3443         * Drosera/mac/Drosera.xcodeproj/project.pbxproj: Use the default value for VALID_ARCHS.
3444
3445 2008-05-07  David Kilzer  <ddkilzer@apple.com>
3446
3447         Use File::Find and Getopt::Long in make-js-test-wrappers
3448
3449         Reviewed by Darin Adler.
3450
3451         * Scripts/make-js-test-wrappers:
3452         - Updated Apple copyright statement.
3453         - Added command-line switch parsing and -h|--help switch.
3454         - Allowed user to pass list of files/directories on which to do
3455           a restricted search for TEMPLATE.html files.  The default
3456           behavior is still to search the entire LayoutTests directory.
3457         - Removed duplicate 'use strict' statement.
3458         - Replaced use of `find` statements with File::Find::find().
3459         - Remove unneeded chomp() calls now that we use File::Find.
3460         (directoryFilter): Added.  Filters .svn directories when used
3461         with File::Find::find().
3462         (findTemplateFiles): Added.  Returns a list of TEMPLATE.html
3463         files found.
3464
3465 2008-05-05  Steve Falkenburg  <sfalken@apple.com>
3466
3467         Copy dependencies of ImageDiff, DumpRenderTree in post-build step.
3468
3469         * DumpRenderTree/win/DumpRenderTree.vcproj:
3470         * DumpRenderTree/win/ImageDiff.vcproj:
3471
3472 2008-05-05  Adele Peterson  <adele@apple.com>
3473
3474         Reviewed by Adam.
3475
3476         Look for the right ImageDiff executable for debug builds.
3477
3478         * Scripts/run-webkit-tests:
3479
3480 2008-05-05  Darin Adler  <darin@apple.com>
3481
3482         * Scripts/run-webkit-tests: Ignore a Java leak showing up in the WebKit
3483         leak tests.
3484
3485 2008-05-05  Ariya Hidayat  <ariya.hidayat@trolltech.com>
3486
3487         Reviewed by Simon.
3488
3489         In the Qt's DumpRenderTree, adjust the web view properly (because W3C SVG 
3490         tests expect to be 480x360)
3491
3492         * DumpRenderTree/qt/DumpRenderTree.cpp:
3493         (WebCore::DumpRenderTree::open):
3494
3495 2008-05-02  Dan Bernstein  <mitz@apple.com>
3496
3497         Reviewed by Adam Roben.
3498
3499         - add an option to svn-apply to set the reviewer name in change logs
3500
3501         * Scripts/svn-apply: Added a [-r|--reviewer name] option.
3502
3503 2008-05-01  David Kilzer  <ddkilzer@apple.com>
3504
3505         Clean up configuration usage in run-webkit-tests
3506
3507         Reviewed by Adam.
3508
3509         * Scripts/run-webkit-tests: Parse configuration switches using
3510         passedConfiguration() from webkitdirs.pm like every other script.
3511         Note that we must still call setConfiguration() afterwards in
3512         case the --configuration switch was used.  Use $configurationOption
3513         when running build-dumprendertree instead of recreating the switch.
3514
3515 2008-04-29  Adam Roben  <aroben@apple.com>
3516
3517         Restore the beloved COMPtr::operator&
3518
3519 2008-04-29  Adam Roben  <aroben@apple.com>
3520
3521         Windows build fixes
3522
3523         Replace COMPtr::operator& with COMPtr::adoptionPointer.
3524
3525 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
3526
3527         Reviewed by Darin Adler.
3528
3529         Fix run-webkit-tests --threading
3530         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
3531         Proxy server issue in Sunday's Nightly
3532
3533         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
3534         (runJavaScriptThread):
3535         (startJavaScriptThreads):
3536         (stopJavaScriptThreads):
3537         Spawned threads were immediately detached, unlike the original ones, so joining them
3538         made no sense. Now, all threads are created detached, and stopJavaScriptThreads() just
3539         waits for them all to exit.
3540
3541 2008-04-28  Holger Hans Peter Freyther  <zecke@selfish.org>
3542
3543         Reviewed by Simon.
3544
3545         Reset dumping resource load callbacks to false for the next test
3546         
3547
3548         * DumpRenderTree/qt/jsobjects.cpp:
3549         (LayoutTestController::reset):
3550
3551 2008-04-28  Tor Arne Vestbø  <tavestbo@trolltech.com>
3552
3553         Reviewed by Simon.
3554
3555         Adapt to the latest API changes in WebKit/qt/Api.
3556
3557         * DumpRenderTree/qt/DumpRenderTree.cpp:
3558         (WebCore::DumpRenderTree::DumpRenderTree):
3559         * DumpRenderTree/qt/jsobjects.cpp:
3560
3561 2008-04-26  Robin Dunn  <robin@alldunn.com>
3562
3563         Reviewed by Kevin Ollivier.
3564         
3565         Delete the DerivedSources after make clean has been done so that the DerivedSources
3566         don't get re-created. Also, use the proper extension for the Win wxPython extension.
3567         
3568         https://bugs.webkit.org/show_bug.cgi?id=18756
3569
3570         * wx/build-wxwebkit:
3571
3572 2008-04-26  Adam Barth <hk9565@gmail.com>
3573
3574         Reviewed by Adam Roben and Sam Weinig.
3575
3576         Updates LayoutTestController to use host instead of domain.
3577
3578         Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
3579
3580         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3581         (LayoutTestController::setDatabaseQuota):
3582         * DumpRenderTree/mac/UIDelegate.mm:
3583         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
3584
3585 2008-04-26  Kevin Ollivier  <kevino@theolliviers.com>
3586
3587         wx build fix. Need the latest libpng. (Somehow my initial test passed without it.)
3588
3589         * wx/install-unix-extras:
3590
3591 2008-04-26  Robin Dunn  <robin@alldunn.com>
3592
3593         Reviewed by Kevin Ollivier.
3594         
3595         Allow the user to set the path to SWIG using an environment variable.
3596         
3597         https://bugs.webkit.org/show_bug.cgi?id=18660
3598
3599         * wx/build-wxwebkit:
3600
3601 2008-04-26  Kevin Ollivier  <kevino@theolliviers.com>
3602
3603         wx build fix. Download the latest libpng version for building the
3604         dependencies.
3605
3606         * wx/install-unix-extras:
3607
3608 2008-04-25  Holger Hans Peter Freyther  <zecke@selfish.org>
3609
3610         Reviewed by Simon.
3611
3612         Implement dumping of resource load callbacks to pass http/tests/xmlhttprequest/abort-should-cancel-load.html
3613         
3614         Similar to Editing and Frameloading we do the dumping within WebCore
3615         
3616
3617         * DumpRenderTree/qt/jsobjects.cpp:
3618         (LayoutTestController::dumpResourceLoadCallbacks):
3619         * DumpRenderTree/qt/jsobjects.h:
3620
3621 2008-04-24  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
3622
3623         Reviewed by Maciej Stachowiak.
3624
3625         http://bugs.webkit.org/show_bug.cgi?id=18485
3626         Typo and documentation fix for build-webkit
3627
3628         * Scripts/build-webkit:
3629
3630 2008-04-24  Anders Carlsson  <andersca@apple.com>
3631
3632         Reviewed by Sam.
3633
3634         Don't call fprintf from the signal handler.
3635         
3636         * DumpRenderTree/mac/DumpRenderTree.mm:
3637         (crashHandler):
3638
3639 2008-04-23  Adam Roben  <aroben@apple.com>
3640
3641         Make crashes be reported as crashes, not hangs
3642
3643         Reviewed by David Kilzer.
3644
3645         * Scripts/run-webkit-tests:
3646         (top level): Use the new status field of the output from
3647         readFromDumpToolWithTimer to determine if the test crashed or hung.
3648         (sub readFromDumpToolWithTimer):
3649           - If we fail to read a line and $! is not EAGAIN, then we've crashed
3650             and should not try to read any more.
3651           - Changed the timedout field to a more general status field.
3652
3653 2008-04-22  David Kilzer  <ddkilzer@apple.com>
3654
3655         Bug 18683: update-webkit returns 0 even if it fails
3656
3657         <https://bugs.webkit.org/show_bug.cgi?id=18683>
3658
3659         Reviewed by Mitz Pettel.
3660
3661         * Scripts/update-webkit:
3662         (runSvnUpdate): Die if close() fails.
3663
3664 2008-04-21  Adam Roben  <aroben@apple.com>
3665
3666         Flush stdout/stderr after printing every #EOF separator
3667
3668         This fixes a hang when running the pixel tests on Windows
3669
3670         Reviewed by Mitz Pettel.
3671
3672         * DumpRenderTree/win/DumpRenderTree.cpp:
3673         (dump):
3674         (main): We don't have to flush stdout/stderr in the arguments loop
3675         anymore, as runTest flushes for us.
3676
3677 2008-04-21  Adam Roben  <aroben@apple.com>
3678
3679         Fix pixel tests
3680
3681         * Scripts/run-webkit-tests:
3682         (sub readFromDumpToolWithTimer): Use readline instead of read to
3683         ensure that we don't read past the #EOF marker.
3684
3685 2008-04-21  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
3686
3687         Reviewed by Simon.
3688
3689         Build fix for Qt 4.3
3690
3691         * When building WebCore/internal make sure the QT_[BEGIN,END]_NAMESPACE is
3692         always defined. Do this by adding defines to the compiler line
3693
3694         * DumpRenderTree/qt/DumpRenderTree.pro:
3695
3696 2008-04-19  Mike Hommey  <glandium@debian.org>
3697
3698         Reviewed by Alp Toker.
3699
3700         Don't build GtkLauncher and DumpRenderTree with rpath.
3701
3702         * GNUmakefile.am:
3703
3704 2008-04-18  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
3705
3706         Reviewed by Alp Toker.
3707
3708         http://bugs.webkit.org/show_bug.cgi?id=16620
3709         [GTK] Autotools make dist and make check support
3710
3711         Cleanups.
3712
3713         * GNUmakefile.am:
3714
3715 2008-04-18  Adam Roben  <aroben@apple.com>
3716
3717         Drop the hang timer to 30 seconds
3718
3719         This matches what DRT/mac was using.
3720
3721         Reviewed by Mitz Pettel.
3722
3723         * Scripts/run-webkit-tests:
3724
3725 2008-04-18  Adam Roben  <aroben@apple.com>
3726
3727         Get rid of DRT's Watchdog
3728
3729         run-webkit-tests now detects hangs and samples DRT as needed.
3730
3731         Reviewed by Mitz Pettel.
3732
3733         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Removed
3734         Watchdog* files from the project.
3735         * DumpRenderTree/Watchdog.cpp: Removed.
3736         * DumpRenderTree/Watchdog.h: Removed.
3737         * DumpRenderTree/mac/DumpRenderTree.mm: Removed uses of Watchdog
3738         (dumpRenderTree):
3739         (runTest):
3740         * DumpRenderTree/mac/WatchdogMac.h: Removed.
3741         * DumpRenderTree/mac/WatchdogMac.mm: Removed.
3742         * Scripts/run-webkit-tests:
3743         (sub testCrashedOrTimedOut): Call sampleDumpTool() if we timed out.
3744         (sub sampleDumpTool): Added. Writes a sample report to
3745         ~/Library/Logs/DumpRenderTree/HangReport.txt.
3746
3747 2008-04-18  Simon Hausmann  <hausmann@webkit.org>
3748
3749         Reviewed by Holger.
3750
3751         Adapt to the API changes in WebKit/qt
3752
3753         * DumpRenderTree/qt/DumpRenderTree.cpp:
3754         (WebCore::WebPage::WebPage):
3755         (WebCore::DumpRenderTree::DumpRenderTree):
3756         (WebCore::DumpRenderTree::initJSObjects):
3757         (WebCore::DumpRenderTree::dumpFramesAsText):
3758         (WebCore::DumpRenderTree::dump):
3759
3760 2008-04-17  Adam Roben  <aroben@apple.com>
3761
3762         Fix many tests on Windows
3763
3764         * Scripts/run-webkit-tests:
3765         (readFromDumpToolWithTimer):
3766          - Use read instead of sysread to ensure that we don't interfere with
3767            other uses of buffered IO in this script.
3768         (setFileHandleNonBlocking): Actually set the filehandle to blocking
3769         when specified.
3770
3771 2008-04-17  Adam Roben  <aroben@apple.com>
3772
3773         Fix ~10 tests
3774
3775         * Scripts/run-webkit-tests: Only remove the newline after #EOF, not
3776         whatever newline happens to be at the end of what we've read.
3777
3778 2008-04-17  Adam Roben  <aroben@apple.com>
3779
3780         Remove DRT/win's hang timer
3781
3782         run-webkit-tests takes care of this for us now
3783
3784         Reviewed by Anders Carlsson.
3785
3786         * DumpRenderTree/win/DumpRenderTree.cpp:
3787
3788 2008-04-17  Adam Roben  <aroben@apple.com>
3789
3790         Don't wait for the hang timer twice in the case of a hang
3791
3792         Previously we'd wait for a hang while reading both stdout and stderr
3793         from DRT. Now we'll only wait for one or the other.
3794
3795         Reviewed by Anders Carlsson.
3796
3797         * Scripts/run-webkit-tests:
3798         (top level): Don't wait for stderr to time out if stdout already timed
3799         out.
3800         (readFromDumpToolWithTimer): If $dontWaitForTimeOut is true, quit
3801         after the first read that returns no data.
3802
3803 2008-04-17  Adam Roben  <aroben@apple.com>
3804
3805         Don't throw away the output from timed out tests
3806
3807         Reviewed by Anders Carlsson.
3808
3809         * Scripts/run-webkit-tests:
3810         (top level): Updated for changes to readFromDumpToolWithTimer.
3811         (readFromDumpToolWithTimer): Return a hash that contains both the
3812         output and whether or not the test timed out.
3813
3814 2008-04-17  Adam Roben  <aroben@apple.com>
3815
3816         Make the hang timer 60 seconds
3817
3818         * Scripts/run-webkit-tests:
3819
3820 2008-04-17  Adam Roben  <aroben@apple.com>
3821
3822         Get rid of carriage returns in DRT/win's stderr
3823
3824         Reviewed by Eric Seidel.
3825
3826         * DumpRenderTree/win/DumpRenderTree.cpp:
3827         (main): Mark stderr as binary like we already do for stdout.
3828
3829 2008-04-17  Adam Roben  <aroben@apple.com>
3830
3831         Fix Bug 17678: run-webkit-tests should have a watchdog timer (and
3832         timeout long tests)
3833
3834         <https://bugs.webkit.org/show_bug.cgi?id=17678>
3835
3836         We now abort tests that take longer than 60 seconds to produce output.
3837         This matches the watchdog timer in DRT/mac and DRT/win (which we can
3838         now remove).
3839
3840         Reviewed by Eric Seidel.
3841
3842         * Scripts/run-webkit-tests:
3843         (top level): Read DRT's output using the new readFromDumpToolWithTimer
3844         subroutine. If readFromDumpToolWithTimer returns undefined it means
3845         the test timed out, so we register the test as a hang and move on.
3846         (sub testCrashedOrTimedOut): Renamed from testCrashed. Now handles
3847         both crashed and timed out tests. If the test timed out, we kill DRT
3848         before returning.
3849         (sub linksForTimedOutTest): Added. We don't have any output to link to for
3850         tests that timed out.
3851         (sub recordActualResultsAndDiff): Don't call length on undefined.
3852         (sub readFromDumpToolWithTimer): Added. Performs non-blocking reads
3853         from a filehandle until an #EOF is reached or
3854         $maximumSecondsWithoutOutput have elapsed.
3855         (sub setFileHandleNonBlocking): Marks a filehandle as blocking or
3856         non-blocking.
3857
3858 2008-04-17  Adam Roben  <aroben@apple.com>
3859
3860         Refactor test results page generation
3861
3862         Reviewed by Eric Seidel.
3863
3864         * Scripts/run-webkit-tests:
3865         (sub htmlForResultsSection): Added. Takes a set of tests, a
3866         description, and a subroutine to generate the links for each test, and
3867         creates a HTML string containing a table of the tests and their
3868         links.
3869         (sub linksForExpectedAndActualResults): Added. Replaces the
3870         htmlForExpectedAndActualResults subroutine.
3871         (sub linksForMismatchTest): Added.
3872         (sub linksForCrashOrErrorTest): Added.
3873         (sub linksForNewTest): Added.
3874
3875 2008-04-17  Adam Roben  <aroben@apple.com>
3876
3877         Print the extension for all tests in the test results page
3878
3879         Reviewed by Eric Seidel.
3880
3881         * Scripts/run-webkit-tests:
3882
3883 2008-04-17  Adam Roben  <aroben@apple.com>
3884
3885         Move code that counts finished tests into a subroutine
3886
3887         Reviewed by Eric Seidel.
3888
3889         * Scripts/run-webkit-tests:
3890         (sub countFinishedTest): Added.
3891
3892 2008-04-17  Adam Roben  <aroben@apple.com>
3893
3894         Move code that handles a crash into a subroutine
3895
3896         Reviewed by Eric Seidel.
3897
3898         * Scripts/run-webkit-tests:
3899         (sub testCrashed): Added.
3900
3901 2008-04-17  Eric Seidel  <eric@webkit.org>
3902
3903         Reviewed by hyatt.
3904         
3905         Rename RenderView to RenderViewport in the next rename patch.
3906
3907         * Scripts/do-webcore-rename:
3908
3909 2008-04-17  Mario Bensi  <mbensi@pleyo.com>
3910
3911         Reviewed by Alp Toker.
3912
3913         http://bugs.webkit.org/show_bug.cgi?id=18543
3914         DumpRenderTree gtk freeze
3915
3916         fix DumpRenderTree gtk freeze 
3917
3918         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3919         (dump):
3920
3921 2008-04-15  Anders Carlsson  <andersca@apple.com>
3922
3923         Add missing ;
3924         
3925         * Scripts/build-webkit:
3926         
3927 2008-04-15  Anders Carlsson  <andersca@apple.com>
3928
3929         Reviewed by Adam.
3930
3931         Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
3932
3933         * Scripts/build-webkit:
3934
3935 2008-04-15  Andre Poenitz  <andre.poenitz@trolltech.com>
3936
3937         Reviewed by Simon.
3938
3939         Fix compilation with Qt namespaces
3940
3941         Qt can be configured to have all of its classes inside a specified namespaces.
3942         This is for example used in plugin/component environments like Eclipse.
3943
3944         This change makes it possible to let the Qt port compile against a namespaced
3945         Qt by the use of macros Qt provides to properly forward declare Qt classes in
3946         the namespace.
3947
3948         * DumpRenderTree/qt/DumpRenderTree.h:
3949
3950 2008-04-08  Kevin Ollivier  <kevino@theolliviers.com>
3951
3952         Reviewed by Darin Adler.
3953
3954         Add a script that propagates any file changes made to the Bakefiles
3955         over to GTK and Qt build systems. Still needs to be wired into
3956         those ports though.
3957
3958         * Scripts/update-sources-list.py: Added.
3959
3960 2008-04-08  Mark Rowe  <mrowe@apple.com>
3961
3962         Clean up after Brady.
3963
3964         * DumpRenderTree/mac/DumpRenderTree.mm: Add an include so that NSInteger can be found.
3965
3966 2008-04-08  Brady Eidson  <beidson@apple.com>
3967
3968         Reviewed by Mitzpettel
3969
3970         Fixed http://bugs.webkit.org/show_bug.cgi?id=18302
3971         -WebArchive subresources dump in random order, intermittent failures
3972
3973         * DumpRenderTree/mac/DumpRenderTree.mm:
3974         (compareResourceURLs): Sorting function based on the resource URLs
3975         (serializeWebArchiveToXML): Sort the subresource array
3976
3977 2008-04-07  Brady Eidson  <beidson@apple.com>
3978
3979         OMG, BUILD - please!
3980
3981         * Scripts/build-webkit:
3982
3983 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
3984
3985         Reviewed by Simon.
3986
3987         * Enable running http tests for Qt again. Failing tests can be put into the skipped list.
3988         * Running these tests on windows and other platforms might need some work.
3989
3990         * Scripts/run-webkit-tests:
3991
3992 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
3993
3994         Reviewed by Simon.
3995
3996         * For the http tests we need the output of the FrameLoaderClient. The QtWebKit API
3997         is not exporting enough to create the output in DRT itself. Settle with the approach
3998         Lars has taken for the Editing support and add branches to our FrameLoaderClient code.
3999         * run-webkit-tests http/tests(/loading) can now be executed.
4000         * For tests in loading/ directories we are going to throw away the dirty
4001         QWebPage to start with something clean.
4002         
4003
4004         * DumpRenderTree/qt/DumpRenderTree.cpp:
4005
4006 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
4007
4008         Reviewed by Simon.
4009
4010         * Treat http and https as special URLs as well. Change the main.cpp and
4011         DumpRenderTree.cpp to handle http and https URIs as input.
4012         * I'm not doing the clean up and merging of these two checks now.
4013         
4014
4015         * DumpRenderTree/qt/DumpRenderTree.cpp:
4016         (WebCore::DumpRenderTree::readStdin):
4017         * DumpRenderTree/qt/main.cpp:
4018         (main):
4019
4020 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
4021
4022         Reviewed by Simon.
4023
4024         * Remove dumpFrameLoadCallbacks from simple-subframe.html because it is
4025         located in a directory with the name "loading". And this will autoamtically
4026         enable dumping.
4027         * Remove this method from the LayoutTestController as it is unused now and this
4028         avoids adding it to the DRT of the Qt port.
4029         
4030
4031         * DumpRenderTree/LayoutTestController.cpp:
4032         (setPrivateBrowsingEnabledCallback):
4033
4034 2008-04-01  Christian Dywan  <christian@imendio.com>
4035
4036         Build fix for GCC 4.3.
4037
4038         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: include string.h
4039
4040 2008-04-01  Simon Hausmann  <hausmann@webkit.org>
4041
4042         Reviewed by Holger.
4043
4044         Fix Qt DRT run by also printing EOF on stderr, as expected by
4045         run-webkit-tests.
4046
4047         * DumpRenderTree/qt/DumpRenderTree.cpp:
4048         (WebCore::DumpRenderTree::dump):
4049
4050 2008-03-31  Julien Chaffraix  <julien.chaffraix@gmail.com>
4051
4052         Reviewed by Darin Adler.
4053
4054         Bug 17665: determineSourceDir() dies if $sourceDir has a trailing backslash
4055
4056         Remove trailing '/' in $sourceDir in determineSourceDir().
4057
4058         Fix suggested by Dmitriy Kazachkov.
4059
4060         * Scripts/webkitdirs.pm:
4061
4062 2008-03-29  Adam Roben  <aroben@apple.com>
4063
4064         Update for rename of an IWebViewPrivate method
4065
4066         Reviewed by Mitz Pettel.
4067
4068         * DumpRenderTree/win/DumpRenderTree.cpp:
4069         (createWebViewAndOffscreenWindow):
4070
4071 2008-03-26  Antti Koivisto  <antti@apple.com>
4072
4073         Reviewed by Anders.
4074         
4075         Enable SVG animation support by default.
4076
4077         * Scripts/build-webkit:
4078
4079 2008-03-25  Adam Roben  <aroben@apple.com>
4080
4081         Windows build fix
4082
4083         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
4084         Add $(WebKitLibrariesDir)\include to the include path so we can find
4085         stdint.h there.
4086
4087 2008-03-24  Eric Seidel  <eric@webkit.org>
4088
4089         Reviewed by Mark.
4090
4091         Clean up SVG features message to be less confusing.
4092
4093         * Scripts/build-webkit:
4094
4095 2008-03-24  Sam Weinig  <sam@webkit.org>
4096
4097         Reviewed by Dave Hyatt.
4098
4099         Add EventSender.zoomPageIn/zoomPageOut support to DRT.
4100
4101         * DumpRenderTree/mac/DumpRenderTree.mm:
4102         (resetWebViewToConsistentStateBeforeTesting):
4103         * DumpRenderTree/mac/EventSendingController.mm:
4104         (+[EventSendingController isSelectorExcludedFromWebScript:]):
4105         (-[EventSendingController zoomPageIn]):
4106         (-[EventSendingController zoomPageOut]):
4107         * DumpRenderTree/win/DumpRenderTree.cpp:
4108         (resetWebViewToConsistentStateBeforeTesting):
4109         * DumpRenderTree/win/EventSender.cpp:
4110         (textZoomInCallback):
4111         (textZoomOutCallback):
4112         (zoomPageInCallback):
4113         (zoomPageOutCallback):
4114
4115 2008-03-24  Dan Bernstein  <mitz@apple.com>
4116
4117         Reviewed by Mark Rowe.
4118
4119         - update bisect-builds for Safari 3.1
4120
4121         * Scripts/bisect-builds: Added Safari 3.1 and the corresponding minimal
4122         revision, r29711.
4123
4124 2008-03-21  Rodney Dawes  <dobey@wayofthemonkey.com>
4125
4126         Reviewed by Holger.
4127
4128         http://bugs.webkit.org/show_bug.cgi?id=17981
4129
4130         Add webcore and javascriptcore cppflags to programs' _CPPFLAGS.
4131
4132         * GNUmakefile.am:
4133
4134 2008-03-21  Adam Roben  <aroben@apple.com>
4135
4136         Remove a non-working mirror from cygwin-downloader and add the ruby package
4137
4138         * CygwinDownloader/cygwin-downloader.py:
4139         * CygwinDownloader/cygwin-downloader.zip: Updated.
4140
4141 2008-03-20  Mark Rowe  <mrowe@apple.com>
4142
4143         Reviewed by Sam Weinig.
4144
4145         Ensure that the defines generated for FEATURE_DEFINES are sorted so that they will match the default settings of each project.
4146         This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
4147         command-line.
4148
4149         * Scripts/build-webkit:
4150
4151 2008-03-17  Eric Seidel  <eric@webkit.org>
4152
4153         Reviewed by Dan Bernstein.
4154
4155         Fix bogus argCount check breaking plugin test.
4156
4157         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
4158
4159 2008-03-17  Eric Seidel  <eric@webkit.org>
4160
4161         Reviewed by darin.
4162
4163         Cleanup PluginObject.cpp and add support for testing
4164         converting from int -> identifier -> string
4165         and from string -> identifier -> int
4166         as well as round-tripping ints and stings through identifiers
4167
4168         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
4169         (pluginGetProperty):
4170         (pluginSetProperty):
4171         (testDOMAccess):
4172         (stringVariantToIdentifier):
4173         (int32VariantToIdentifier):
4174         (doubleVariantToIdentifier):
4175         (variantToIdentifier):
4176         (testIdentifierToString):
4177         (testIdentifierToInt):
4178         (testCallback):
4179         (getURL):
4180         (removeDefaultMethod):
4181         (getURLNotify):
4182         (testInvokeDefault):
4183         (destroyStream):
4184         (testEnumerate):
4185         (testGetIntIdentifier):
4186         (testGetProperty):
4187         (testEvaluate):
4188         (testGetPropertyReturnValue):
4189         (pluginInvoke):
4190         (pluginInvokeDefault):
4191         (pluginInvalidate):
4192         (pluginAllocate):
4193         (pluginDeallocate):
4194         (handleCallback):
4195
4196 2008-03-16  Kevin Ollivier  <kevino@theolliviers.com>
4197
4198         Rubber stamped by Darin Adler.
4199
4200         Add set-webkit-configuration support for wx port, and centralize
4201         build dir location setting.
4202
4203         http://bugs.webkit.org/show_bug.cgi?id=17790
4204
4205         * wx/browser/browser.bkl:
4206         * wx/build-wxwebkit:
4207
4208 2008-03-15  Darin Adler  <darin@apple.com>
4209
4210         * Scripts/commit-log-editor: Include the name line of the change log entry.
4211         A long time ago I designed this script to not include the name because I
4212         thought it was redundant (same as the name of the person checking in), but
4213         nowadays it's more common for someone to check something in done by someone
4214         else.
4215
4216         * Scripts/do-webcore-rename: Added some more planned renames and removed
4217         some that were already done "by hand".
4218
4219 2008-03-13  Brent Fulgham  <bfulgham@gmail.com>
4220
4221         Reviewed by Darin Adler.
4222
4223         Correct paths to vsprops files so they use the environment
4224         variable, rather than hard-coded path.
4225         http://bugs.webkit.org/show_bug.cgi?id=17797.
4226
4227         * WinLauncher/WinLauncher.vcproj:  Correct paths to vsprops.
4228
4229 2008-03-12  Steve Falkenburg  <sfalken@apple.com>
4230
4231         VSExpress build fix
4232
4233         * WinLauncher/WinLauncher.vcproj:
4234
4235 2008-03-12  Holger Hans Peter Freyther  <zecke@selfish.org>
4236
4237         Reviewed by Alp Toker.
4238
4239         Run testkjs in the correct productsDir in the GTK+ port.
4240
4241         * Scripts/run-javascriptcore-tests:
4242
4243 2008-03-11  Brent Fulgham  <bfulgham@gmail.com>
4244
4245         Reviewed by Adam Roben.
4246
4247         Enabled WinLauncher as part of normal Windows build.
4248         http://bugs.webkit.org/show_bug.cgi?id=17715.
4249
4250         * WinLauncher/WinLauncher.vcproj: Update to use vsprops so that
4251           it can find the proper libraries to link against.
4252
4253 2008-03-10  Julien Chaffraix  <julien.chaffraix@gmail.com>
4254
4255         Reviewed and landed by Darin Adler.
4256
4257         http://bugs.webkit.org/show_bug.cgi?id=17581
4258         Bug 17581: Use of uninitialized value in string ne at WebKitTools/Scripts/run-webkit-tests line 1576.
4259
4260         Remove the previous warning which occurs when the --random option is used.
4261
4262         * Scripts/run-webkit-tests: verify that $component[0] is defined before checking for
4263         its inequality
4264
4265 2008-03-07  Simon Hausmann  <hausmann@webkit.org>
4266
4267         Reviewed by Darin Adler.
4268
4269         Done with Lars.
4270
4271         Ported the netscape test plugin to QWebPluginFactory.
4272
4273         * DumpRenderTree/qt/DumpRenderTree.cpp:
4274         (WebCore::WebPage::WebPage):
4275         * DumpRenderTree/qt/main.cpp:
4276         * DumpRenderTree/qt/testplugin.cpp:
4277         (TestPlugin::plugins):
4278         (TestPlugin::create):
4279         * DumpRenderTree/qt/testplugin.h:
4280
4281 2008-03-09  Steve Falkenburg  <sfalken@apple.com>
4282
4283         Stop Windows build if an error occurs in a prior project.
4284
4285         Rubber stamped by Darin Adler.
4286
4287         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
4288         * DumpRenderTree/win/DumpRenderTree.vcproj:
4289         * DumpRenderTree/win/ImageDiff.vcproj:
4290         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
4291
4292 2008-03-08  Julien Chaffraix  <julien.chaffraix@gmail.com>
4293
4294         Reviewed by Mark Rowe.
4295
4296         DRT build fix for Tiger.
4297
4298         * DumpRenderTree/mac/DumpRenderTreeMac.h: Define BUILDING_ON_TIGER.
4299
4300 2008-03-07  Mark Rowe  <mrowe@apple.com>
4301
4302         Reviewed by Oliver Hunt.
4303
4304         Fix WebKit build with GCC 4.2.
4305
4306         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Use correct argument type in method signature.
4307
4308 2008-03-07  Stephanie Lewis <slewis@apple.com>
4309
4310         Reviewed by Oliver.
4311
4312         Add Windows part of <rdar://problem/5693690> 
4313
4314         * DumpRenderTree/win/DumpRenderTree.cpp:
4315         (dump):
4316         (main):
4317
4318 2008-03-07  Alp Toker  <alp@atoker.com>
4319
4320         Back out the r30818, r30819 build fix attempts now the GTK+ build
4321         server has been upgraded.
4322
4323         * Scripts/webkitdirs.pm:
4324
4325 2008-03-07  Stephanie Lewis <slewis@apple.com>
4326
4327         Reviewed by Geoff.
4328
4329         <rdar://problem/5693690> run-webkit-tests swallows STDERR output, including WebCore LEAK messages
4330