2010-01-04 Adam Barth <abarth@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-01-04  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         [bzt] Move AbstractSequencedCommand to a more general location
6         https://bugs.webkit.org/show_bug.cgi?id=33137
7
8         I do what the FIXME tell me to do.
9
10         * Scripts/webkitpy/commands/abstractsequencedcommand.py: Added.
11         * Scripts/webkitpy/commands/download.py:
12         * Scripts/webkitpy/commands/upload.py:
13
14 2010-01-04  Adam Barth  <abarth@webkit.org>
15
16         Reviewed by Eric Seidel.
17
18         Rename StatusBot to StatusServer
19         https://bugs.webkit.org/show_bug.cgi?id=33139
20
21         It's not a bot.  It's a server.
22
23         * Scripts/bugzilla-tool:
24         * Scripts/webkitpy/bugzilla.py:
25         * Scripts/webkitpy/commands/early_warning_system.py:
26         * Scripts/webkitpy/commands/queues.py:
27         * Scripts/webkitpy/mock_bugzillatool.py:
28         * Scripts/webkitpy/queueengine.py:
29         * Scripts/webkitpy/statusbot.py: Removed.
30
31 2010-01-04  Adam Barth  <abarth@webkit.org>
32
33         Reviewed by Eric Seidel.
34
35         [bzt] submit-pach should have a -o/--open option to open the bug after submit
36         https://bugs.webkit.org/show_bug.cgi?id=33136
37
38         Python makes this very easy.
39
40         * Scripts/webkitpy/mock_bugzillatool.py:
41         * Scripts/webkitpy/steps/options.py:
42         * Scripts/webkitpy/steps/postdiff.py:
43         * Scripts/webkitpy/user.py:
44
45 2010-01-04  Adam Barth  <abarth@webkit.org>
46
47         Reviewed by Eric Seidel.
48
49         [bzt] Move steps to a submodule
50         https://bugs.webkit.org/show_bug.cgi?id=33135
51
52         For great victory.  This will probably introduce some regressions
53         because our test coverage isn't perfect, but I've tried to be careful.
54
55         * Scripts/test-webkitpy:
56         * Scripts/webkitpy/buildsteps.py: Removed.
57         * Scripts/webkitpy/buildsteps_unittest.py: Removed.
58         * Scripts/webkitpy/commands/download.py:
59         * Scripts/webkitpy/commands/upload.py:
60         * Scripts/webkitpy/steps/__init__.py: Added.
61         * Scripts/webkitpy/steps/abstractstep.py: Added.
62         * Scripts/webkitpy/steps/applypatch.py: Added.
63         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: Added.
64         * Scripts/webkitpy/steps/build.py: Added.
65         * Scripts/webkitpy/steps/checkstyle.py: Added.
66         * Scripts/webkitpy/steps/cleanworkingdirectory.py: Added.
67         * Scripts/webkitpy/steps/cleanworkingdirectorywithlocalcommits.py: Added.
68         * Scripts/webkitpy/steps/closebug.py: Added.
69         * Scripts/webkitpy/steps/closebugforlanddiff.py: Added.
70         * Scripts/webkitpy/steps/closepatch.py: Added.
71         * Scripts/webkitpy/steps/commit.py: Added.
72         * Scripts/webkitpy/steps/completerollout.py: Added.
73         * Scripts/webkitpy/steps/confirmdiff.py: Added.
74         * Scripts/webkitpy/steps/createbug.py: Added.
75         * Scripts/webkitpy/steps/editchangelog.py: Added.
76         * Scripts/webkitpy/steps/ensurebuildersaregreen.py: Added.
77         * Scripts/webkitpy/steps/ensurelocalcommitifneeded.py: Added.
78         * Scripts/webkitpy/steps/metastep.py: Added.
79         * Scripts/webkitpy/steps/obsoletepatches.py: Added.
80         * Scripts/webkitpy/steps/options.py: Added.
81         * Scripts/webkitpy/steps/postdiff.py: Added.
82         * Scripts/webkitpy/steps/preparechangelog.py: Added.
83         * Scripts/webkitpy/steps/preparechangelogforrevert.py: Added.
84         * Scripts/webkitpy/steps/promptforbugortitle.py: Added.
85         * Scripts/webkitpy/steps/revertrevision.py: Added.
86         * Scripts/webkitpy/steps/runtests.py: Added.
87         * Scripts/webkitpy/steps/steps_unittest.py: Added.
88         * Scripts/webkitpy/steps/update.py: Added.
89         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py: Added.
90         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: Added.
91         * Scripts/webkitpy/stepsequence.py:
92
93 2010-01-04  Daniel Bates  <dbates@webkit.org>
94
95         Reviewed by Eric Seidel.
96
97         https://bugs.webkit.org/show_bug.cgi?id=33097
98
99         Cleans up the File menu to better conform to the File menu in Safari
100         both in terms of options and keyboard shortcuts. Adds a "Quit" menu
101         options to close all open windows. Also, renames the Tools menu to
102         Develop.
103
104         * QtLauncher/main.cpp:
105         (MainWindow::setupUI):
106
107 2010-01-04  Daniel Bates  <dbates@webkit.org>
108
109         https://bugs.webkit.org/show_bug.cgi?id=33039
110         
111         Unreviewed fix.
112
113         * Scripts/webkitpy/credentials.py:
114         * Scripts/webkitpy/credentials_unittest.py:
115
116 2010-01-04  Daniel Bates  <dbates@webkit.org>
117
118         Reviewed by Eric Seidel.
119
120         https://bugs.webkit.org/show_bug.cgi?id=33039
121
122         [bzt] Second attempt to fix an issue where bugzilla-tool dies
123         when the keychain lookup fails to find an entry for bugs.webkit.org.
124
125         * Scripts/webkitpy/credentials.py:
126         * Scripts/webkitpy/credentials_unittest.py:
127
128 2010-01-04  Eric Seidel  <eric@webkit.org>
129
130         Reviewed by Adam Barth.
131
132         Make Rollout an AbstractSequencedCommmand
133         https://bugs.webkit.org/show_bug.cgi?id=33133
134
135         As suggested by Adam in:
136         https://bugs.webkit.org/show_bug.cgi?id=33131#c2
137
138         * Scripts/webkitpy/commands/download.py:
139
140 2010-01-04  Eric Seidel  <eric@webkit.org>
141
142         Reviewed by Adam Barth.
143
144         Make all commands AbstractDeclarativeCommmands instead of direct Command subclasses
145         https://bugs.webkit.org/show_bug.cgi?id=33131
146
147         Evenetually we'll probably roll AbstractDeclarativeCommmand directly into Command
148         but for now we just deploy it everywhere and don't try to fix up the few valid uses
149         of Command.
150
151         * Scripts/webkitpy/commands/download.py:
152         * Scripts/webkitpy/commands/queries.py:
153         * Scripts/webkitpy/commands/upload.py:
154         * Scripts/webkitpy/multicommandtool.py:
155
156 2010-01-03  Adam Barth  <abarth@webkit.org>
157
158         Unreviewed "build" fix.  Need to import ScriptError.
159
160         * Scripts/webkitpy/buildsteps.py:
161
162 2010-01-03  Adam Barth  <abarth@webkit.org>
163
164         Reviewed by Eric Seidel.
165
166         [bzt] Make it easier to run submit-patch when previous run cancelled
167         https://bugs.webkit.org/show_bug.cgi?id=33070
168
169         This patch renames create-review to submit-patch (as requested by
170         Maciej).
171
172         This patch makes it easier to run submit-patch after the user has
173         already cancelled a previous run of submit-patch by detecting when we
174         already have ChangeLogs and reading the bug number from them (and not
175         attempting to recreate them).  Aside from performance and the extra
176         edit step, this command should not subsume post-dif.
177
178         Also, added a --email command line argument so that the output of
179         prepare-ChangeLog makes sense when it can't find the user's email
180         address.
181
182         * Scripts/webkitpy/bugzilla.py:
183         * Scripts/webkitpy/buildsteps.py:
184         * Scripts/webkitpy/commands/upload.py:
185         * Scripts/webkitpy/commands/upload_unittest.py:
186         * Scripts/webkitpy/mock_bugzillatool.py:
187         * Scripts/webkitpy/user.py:
188
189 2010-01-03  Eric Seidel  <eric@webkit.org>
190
191         Reviewed by Adam Barth.
192
193         Rename Scripts/modules to Scripts/webkitpy
194         https://bugs.webkit.org/show_bug.cgi?id=33128
195
196         Just search-replace and svn mv commands.
197
198         * Scripts/bugzilla-tool:
199         * Scripts/check-webkit-style:
200         * Scripts/modules: Removed.
201         * Scripts/modules/BeautifulSoup.py: Removed.
202         * Scripts/modules/__init__.py: Removed.
203         * Scripts/modules/bugzilla.py: Removed.
204         * Scripts/modules/bugzilla_unittest.py: Removed.
205         * Scripts/modules/buildbot.py: Removed.
206         * Scripts/modules/buildbot_unittest.py: Removed.
207         * Scripts/modules/buildsteps.py: Removed.
208         * Scripts/modules/buildsteps_unittest.py: Removed.
209         * Scripts/modules/changelogs.py: Removed.
210         * Scripts/modules/changelogs_unittest.py: Removed.
211         * Scripts/modules/commands: Removed.
212         * Scripts/modules/commands/__init__.py: Removed.
213         * Scripts/modules/commands/commandtest.py: Removed.
214         * Scripts/modules/commands/download.py: Removed.
215         * Scripts/modules/commands/download_unittest.py: Removed.
216         * Scripts/modules/commands/early_warning_system.py: Removed.
217         * Scripts/modules/commands/early_warning_system_unittest.py: Removed.
218         * Scripts/modules/commands/queries.py: Removed.
219         * Scripts/modules/commands/queries_unittest.py: Removed.
220         * Scripts/modules/commands/queues.py: Removed.
221         * Scripts/modules/commands/queues_unittest.py: Removed.
222         * Scripts/modules/commands/queuestest.py: Removed.
223         * Scripts/modules/commands/upload.py: Removed.
224         * Scripts/modules/commands/upload_unittest.py: Removed.
225         * Scripts/modules/comments.py: Removed.
226         * Scripts/modules/committers.py: Removed.
227         * Scripts/modules/committers_unittest.py: Removed.
228         * Scripts/modules/cpp_style.py: Removed.
229         * Scripts/modules/cpp_style_unittest.py: Removed.
230         * Scripts/modules/credentials.py: Removed.
231         * Scripts/modules/credentials_unittest.py: Removed.
232         * Scripts/modules/diff_parser.py: Removed.
233         * Scripts/modules/diff_parser_unittest.py: Removed.
234         * Scripts/modules/executive.py: Removed.
235         * Scripts/modules/executive_unittest.py: Removed.
236         * Scripts/modules/grammar.py: Removed.
237         * Scripts/modules/mock.py: Removed.
238         * Scripts/modules/mock_bugzillatool.py: Removed.
239         * Scripts/modules/multicommandtool.py: Removed.
240         * Scripts/modules/multicommandtool_unittest.py: Removed.
241         * Scripts/modules/outputcapture.py: Removed.
242         * Scripts/modules/patchcollection.py: Removed.
243         * Scripts/modules/queueengine.py: Removed.
244         * Scripts/modules/queueengine_unittest.py: Removed.
245         * Scripts/modules/scm.py: Removed.
246         * Scripts/modules/scm_unittest.py: Removed.
247         * Scripts/modules/statusbot.py: Removed.
248         * Scripts/modules/stepsequence.py: Removed.
249         * Scripts/modules/style: Removed.
250         * Scripts/modules/style.py: Removed.
251         * Scripts/modules/style_unittest.py: Removed.
252         * Scripts/modules/text_style.py: Removed.
253         * Scripts/modules/text_style_unittest.py: Removed.
254         * Scripts/modules/user.py: Removed.
255         * Scripts/modules/webkit_logging.py: Removed.
256         * Scripts/modules/webkit_logging_unittest.py: Removed.
257         * Scripts/modules/webkit_mechanize.py: Removed.
258         * Scripts/modules/webkitport.py: Removed.
259         * Scripts/modules/webkitport_unittest.py: Removed.
260         * Scripts/test-webkit-python: Removed.
261         * Scripts/test-webkitpy: Copied from WebKitTools/Scripts/test-webkit-python.
262         * Scripts/validate-committer-lists:
263         * Scripts/webkitpy: Copied from WebKitTools/Scripts/modules.
264         * Scripts/webkitpy/bugzilla.py:
265         * Scripts/webkitpy/bugzilla_unittest.py:
266         * Scripts/webkitpy/buildbot.py:
267         * Scripts/webkitpy/buildbot_unittest.py:
268         * Scripts/webkitpy/buildsteps.py:
269         * Scripts/webkitpy/buildsteps_unittest.py:
270         * Scripts/webkitpy/commands/commandtest.py:
271         * Scripts/webkitpy/commands/download.py:
272         * Scripts/webkitpy/commands/download_unittest.py:
273         * Scripts/webkitpy/commands/early_warning_system.py:
274         * Scripts/webkitpy/commands/early_warning_system_unittest.py:
275         * Scripts/webkitpy/commands/queries.py:
276         * Scripts/webkitpy/commands/queries_unittest.py:
277         * Scripts/webkitpy/commands/queues.py:
278         * Scripts/webkitpy/commands/queues_unittest.py:
279         * Scripts/webkitpy/commands/queuestest.py:
280         * Scripts/webkitpy/commands/upload.py:
281         * Scripts/webkitpy/commands/upload_unittest.py:
282         * Scripts/webkitpy/comments.py:
283         * Scripts/webkitpy/credentials.py:
284         * Scripts/webkitpy/credentials_unittest.py:
285         * Scripts/webkitpy/executive.py:
286         * Scripts/webkitpy/executive_unittest.py:
287         * Scripts/webkitpy/mock_bugzillatool.py:
288         * Scripts/webkitpy/multicommandtool.py:
289         * Scripts/webkitpy/multicommandtool_unittest.py:
290         * Scripts/webkitpy/queueengine.py:
291         * Scripts/webkitpy/queueengine_unittest.py:
292         * Scripts/webkitpy/scm.py:
293         * Scripts/webkitpy/scm_unittest.py:
294         * Scripts/webkitpy/statusbot.py:
295         * Scripts/webkitpy/stepsequence.py:
296         * Scripts/webkitpy/webkit_logging_unittest.py:
297         * Scripts/webkitpy/webkitport_unittest.py:
298
299 2010-01-03  Chris Jerdonek  <chris.jerdonek@gmail.com>
300
301         Reviewed by Eric Seidel.
302
303         Added script to test both Perl and Python, and renamed
304         run-webkit-unittests to test-webkit-python.
305
306         https://bugs.webkit.org/show_bug.cgi?id=33045
307
308         * Scripts/VCSUtils_unittest.pl:
309           - Tweaked so it can be run from outside Scripts directory.
310
311         * Scripts/run-webkit-unittests: Removed.
312           - Renamed to test-webkit-python.
313
314         * Scripts/test-webkit-perl:
315           - Tweaked so it can be run from outside Scripts directory.
316
317         * Scripts/test-webkit-python: Copied from Scripts/run-webkit-unittests.
318
319         * Scripts/test-webkit-scripts: Added.
320           - Runs both test-webkit-perl and test-webkit-python.
321
322 2010-01-03  Adam Barth  <abarth@webkit.org>
323
324         Reviewed by Eric Seidel.
325
326         commit-queue/bugzilla-tool should build both Debug and Release
327         https://bugs.webkit.org/show_bug.cgi?id=28450
328
329         Add a --build-style command that lets the master process tell the child
330         process to build both debug and release.  Eventually we want to teach
331         the test step to understand this option too, but that's a patch for
332         another day.
333
334         * Scripts/modules/buildsteps.py:
335         * Scripts/modules/commands/queues.py:
336         * Scripts/modules/webkitport.py:
337         * Scripts/modules/webkitport_unittest.py:
338
339 2010-01-03  Jakub Wieczorek  <faw217@gmail.com>
340
341         Reviewed by Eric Seidel.
342
343         [Qt] EventSender: add support for Enter key events
344         https://bugs.webkit.org/show_bug.cgi?id=33064
345
346         Unskip 5 tests that are fixed now.
347
348         * DumpRenderTree/qt/EventSenderQt.cpp:
349         (EventSender::keyDown):
350
351 2010-01-03  Adam Barth  <abarth@webkit.org>
352
353         Reviewed by Eric Seidel.
354
355         [bzt] Add test for previous typo fix
356         https://bugs.webkit.org/show_bug.cgi?id=33083
357
358         A trivial test for a trivial fix, as requested by Eric.
359
360         * Scripts/modules/bugzilla_unittest.py:
361
362 2010-01-03  Adam Barth  <abarth@webkit.org>
363
364         Reviewed by Eric Seidel.
365
366         Implement mac-ews
367         https://bugs.webkit.org/show_bug.cgi?id=33072
368
369         The mac-ews is slightly different than the other early warning systems
370         because we can't run Mac OS X inside a VM.  For that reason, we only
371         process patches that were uploaded by committers.  This isn't as much
372         coverage as the other EWS bots, but it's better than nothing.
373
374         * Scripts/modules/commands/early_warning_system.py:
375         * Scripts/modules/commands/early_warning_system_unittest.py:
376         * Scripts/modules/commands/queues.py:
377         * Scripts/modules/commands/queuestest.py:
378         * Scripts/modules/mock_bugzillatool.py:
379
380 2010-01-03  Chris Jerdonek  <chris.jerdonek@gmail.com>
381
382         Reviewed by David Kilzer.
383
384         Refactored svn-apply and svn-unapply to use a common "patch"
385         command method, and added unit tests for this new method.
386
387         https://bugs.webkit.org/show_bug.cgi?id=33098
388
389         * Scripts/VCSUtils.pm:
390           - Added generateRunPatchCommand().
391           - Added runPatchCommand().
392           - Added exitStatus() from webkitdirs.pm to address FIXME.
393
394         * Scripts/VCSUtils_unittest.pl:
395           - Added 10 unit tests for generateRunPatchCommand().
396           - Added 4 unit tests for runPatchCommand().
397           - Added callSilently() method.
398
399         * Scripts/svn-apply:
400           - Refactored applyPatch().
401           - Removed $pathScriptWasRunFrom global variable.
402           - Addressed issue where "--force" option was getting added twice.
403
404         * Scripts/svn-unapply:
405           - Refactored applyPatch().
406           - Removed $pathScriptWasRunFrom global variable.
407           - Added support for --force option.
408           - Enhanced to return meaningful exit status.
409
410         * Scripts/webkitdirs.pm:
411           - Moved exitStatus() implementation to VCSUtils.pm.
412
413 2009-12-31  Adam Barth  <abarth@webkit.org>
414
415         Reviewed by Eric Seidel.
416
417         [bzt] Implement build-and-test
418         https://bugs.webkit.org/show_bug.cgi?id=33073
419
420         Some of the early warning system bots want to use build-and-test so
421         they can cover LayoutTests in addition to just compilation.
422
423         * Scripts/modules/commands/download.py:
424         * Scripts/modules/commands/download_unittest.py:
425
426 2009-12-31  Adam Barth  <abarth@webkit.org>
427
428         Reviewed by Eric Seidel.
429
430         Show mac-ews status on QueueStatusServer
431         https://bugs.webkit.org/show_bug.cgi?id=33076
432
433         Also make error status purple.
434
435         * QueueStatusServer/model/attachment.py:
436         * QueueStatusServer/model/queues.py:
437         * QueueStatusServer/templates/dashboard.html:
438         * QueueStatusServer/templates/statusbubble.html:
439
440 2009-12-31  Adam Barth  <abarth@webkit.org>
441
442         Unreviewed.
443
444         [bzt] REGRESSION: Bugzila is a typo
445         https://bugs.webkit.org/show_bug.cgi?id=33074
446
447         Eric should test his code before landing!  :)
448
449         * Scripts/modules/bugzilla.py:
450
451 2009-12-31  Adam Barth  <abarth@webkit.org>
452
453         Unreviewed.  Fix the unit tests!
454
455         * Scripts/run-webkit-unittests:
456
457 2009-12-30  Kevin Watters  <kevinwatters@gmail.com>
458
459         Reviewed by Kevin Ollivier.
460
461         [wx] Alter a couple of default settings in the test app.
462         
463         https://bugs.webkit.org/show_bug.cgi?id=32956
464
465         * wx/browser/browser.cpp:
466         (MyApp::OnInit):
467
468 2009-12-30  Eric Seidel  <eric@webkit.org>
469
470         Reviewed by Adam Barth.
471
472         logging.py should be renamed to webkit_logging.py and eventually die
473         https://bugs.webkit.org/show_bug.cgi?id=33058
474
475         Change all imports of "logging" to webkit_logging,
476         except the ones which came from Google's cpp_lint.py and diff_parser.py
477         which clearly are assuming python's logging.py.
478
479         * Scripts/modules/bugzilla.py:
480         * Scripts/modules/buildbot.py:
481         * Scripts/modules/buildsteps.py:
482         * Scripts/modules/commands/download.py:
483         * Scripts/modules/commands/queries.py:
484         * Scripts/modules/commands/queues.py:
485         * Scripts/modules/commands/upload.py:
486         * Scripts/modules/credentials.py:
487         * Scripts/modules/executive.py:
488         * Scripts/modules/multicommandtool.py:
489         * Scripts/modules/queueengine.py:
490         * Scripts/modules/scm.py:
491         * Scripts/modules/statusbot.py:
492         * Scripts/modules/stepsequence.py:
493         * Scripts/modules/webkit_logging.py: Renamed from WebKitTools/Scripts/modules/logging.py.
494         * Scripts/modules/webkit_logging_unittest.py: Renamed from WebKitTools/Scripts/modules/logging_unittest.py.
495
496 2009-12-30  Jakub Wieczorek  <faw217@gmail.com>
497
498         Reviewed by Simon Hausmann.
499
500         [Qt] layoutTestController.pathToLocalResource() should return a path, not an URL
501         https://bugs.webkit.org/show_bug.cgi?id=33051
502
503         Moreover, its primary function is to normalize the path in regard of platform
504         specific directory separators. Therefore, it can simply make use of the
505         QDir::toNativeSeparators function.
506
507         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
508         (LayoutTestController::pathToLocalResource):
509
510 2009-12-30  David D. Kilzer  <ddkilzer@webkit.org>
511
512         Fix executable bits for r52646
513
514         * Scripts/VCSUtils_unittest.pl: Added property svn:executable.
515         * Scripts/test-webkit-perl: Ditto.
516
517 2009-12-29  Chris Jerdonek  <chris.jerdonek@gmail.com>
518
519         Reviewed by David Kilzer.
520
521         Fixed a bug in fixChangeLogPatch, made it work correctly in
522         more circumstances, and added unit tests.
523
524         https://bugs.webkit.org/show_bug.cgi?id=32919
525
526         * Scripts/VCSUtils.pm:
527           Rewrote fixChangeLogPatch.
528           
529         * Scripts/VCSUtils_unittest.pl: Added.
530           Added 7 unit tests for fixChangeLogPatch.
531
532         * Scripts/test-webkit-perl: Added.
533           Added test harness for unit tests of Perl code.
534
535 2009-12-29  Eric Seidel  <eric@webkit.org>
536
537         Reviewed by Adam Barth.
538
539         Split out BugzillaQueries class from Bugzilla
540         https://bugs.webkit.org/show_bug.cgi?id=33042
541
542         * Scripts/modules/bugzilla.py:
543          - Split out BugzillaQueries from Bugzilla.
544          - Try to isolate self.bugzilla usage into helper functions whenever possible.
545          - Add a bunch of FIXMEs.
546          - Rename fetch_bug_ids_from_needs_commit_list to fetch_bug_ids_from_pending_commit_list
547         * Scripts/modules/bugzilla_unittest.py:
548          - Create a new BugzillaQueriesTest testcase and move logic there.
549         * Scripts/modules/buildsteps_unittest.py:
550          - Use Bug 75 instead of 1 since bug 1 doesn't actually exist.
551         * Scripts/modules/commands/queries.py:
552          - Update to use bugzilla.queries
553         * Scripts/modules/commands/queues.py:
554          - Ditto.
555         * Scripts/modules/commands/upload.py:
556          - Ditto.
557         * Scripts/modules/mock_bugzillatool.py:
558          - Add a MockBugzillaQueries.
559          - Make patches and bugs global privates.
560          - Let _id_to_object_dictionary take a variable argument list instead of an array.
561
562 2009-12-29  Daniel Bates  <dbates@webkit.org>
563
564         Reviewed by Eric Seidel.
565
566         https://bugs.webkit.org/show_bug.cgi?id=33041
567
568         Speed up the test method test_read_credentials_with_SVN by not actually
569         creating an SVN repository to test against (by default). Instead, it is
570         sufficient to create a temporary directory that does not contain a Git
571         repository.
572
573         Also, renamed method test_read_credentials_with_SVN to
574         test_read_credentials_without_git_repo, to better reflect what it is
575         testing.
576
577         * Scripts/modules/credentials_unittest.py:
578
579 2009-12-29  Daniel Bates  <dbates@webkit.org>
580
581         Reviewed by Adam Barth.
582
583         https://bugs.webkit.org/show_bug.cgi?id=33039
584
585         [bzt] Fixes an issue where bugzilla-tool dies when the keychain lookup
586         fails to find an entry for bugs.webkit.org.
587         
588         Under Mac OS X, bugzilla-tool tries to query the keychain and Security
589         framework (via /usr/sbin/security) for an internet-password entry for
590         bugs.webkit.org so that it can use it to login to bugs.webkit.org.
591         However, if no such entry exists then bugzilla-tool dies with an error.
592
593         * Scripts/modules/credentials.py: Modified method _parse_security_tool_output to return
594         [None, None] if /usr/sbin/security cannot find keychain entry for bugs.webkit.org.
595         * Scripts/modules/credentials_unittest.py: Added method test_security_output_parse_entry_not_found.
596
597 2009-12-29  Eric Seidel  <eric@webkit.org>
598
599         Rubber-stamped by Adam Barth.
600
601         Remove unused BugzillaException.
602
603         * Scripts/modules/bugzilla.py:
604
605 2009-12-29  Eric Seidel  <eric@webkit.org>
606
607         Reviewed by Adam Barth.
608
609         Need a script to assign bugs with r+ patches to committers for landing
610         https://bugs.webkit.org/show_bug.cgi?id=33009
611
612         This is just one more small tool to help in the fight against our
613         ever-growing list of to-be-committed patches.
614
615         * Scripts/modules/bugzilla.py:
616          - Rename assign_to_email to assigned_to_email (typo).
617          - Add assigned_to_email() method on Bug.
618          - Add reassign_bug method.
619          - Add Bugzilla.unassigned_email, eventually should move to some webkit_config.py module.
620         * Scripts/modules/bugzilla_unittest.py:
621          - Update test after assigned_to_email rename.
622         * Scripts/modules/commands/commandtest.py:
623          - Call bind_to_tool to that self.tool works in Command testing.
624         * Scripts/modules/commands/download.py:
625          - Move AbstractDeclarativeCommmand multicommandtool.py, it should be part of Command.
626         * Scripts/modules/commands/queries_unittest.py:
627          - One of the test patches is now posted by "eric@webkit.org" which is a committer.
628          - Eventually we'll mock out CommitterList and be able to better control what's a committer and what's not.
629         * Scripts/modules/commands/upload.py:
630          - Add new assign-to-committer command.
631         * Scripts/modules/commands/upload_unittest.py:
632          - Add basic assign-to-committer test.
633         * Scripts/modules/committers.py:
634          - Add bugzilla_email() accessor.
635         * Scripts/modules/committers_unittest.py:
636          - Test our assumption that bugzilla_email is the first email.
637         * Scripts/modules/mock_bugzillatool.py:
638          - Add _id_to_object_dictionary for generating bug_cache from list of bugs.
639          - Remove unused fetch_attachments_from_bug.
640          - Add fetch_bug support and a bug_cache.
641         * Scripts/modules/multicommandtool.py:
642          - Move AbstractDeclarativeCommmand here from download.py
643
644 2009-12-29  Adam Barth  <abarth@webkit.org>
645
646         Reviewed by Eric Seidel.
647
648         [bzt] Don't crash if user types a number during PromptForBugOrTitleStep
649         https://bugs.webkit.org/show_bug.cgi?id=33038
650
651         Simple fix with test.
652
653         * Scripts/modules/buildsteps.py:
654         * Scripts/modules/buildsteps_unittest.py:
655
656 2009-12-29  Adam Barth  <abarth@webkit.org>
657
658         Reviewed by Eric Seidel.
659
660         [bzt] post-diff requires reading to the end
661         https://bugs.webkit.org/show_bug.cgi?id=33036
662
663         Catch the IOError caused by not reading to the end of the diff.  We
664         don't have a good way to test this currently.
665
666         * Scripts/modules/user.py:
667
668 2009-12-29  Chang Shu  <Chang.Shu@nokia.com>
669
670         Reviewed by Adam Barth.
671
672         [Qt] Move logic that handles Qt headers before primary headers
673         so that Qt headers won't be treated as primary headers by mistake.
674         https://bugs.webkit.org/show_bug.cgi?id=32991
675
676         * Scripts/modules/cpp_style.py:
677         * Scripts/modules/cpp_style_unittest.py:
678
679 2009-12-29  Eric Seidel  <eric@webkit.org>
680
681         Reviewed by Adam Barth.
682
683         Add the start of a Bug object for bugzilla.py
684         https://bugs.webkit.org/show_bug.cgi?id=32995
685
686         This allowed us to get rid of some duplicated "is_obsolete" checks.
687
688         * Scripts/modules/bugzilla.py:
689          - Add a new Bug class, and move patches/unreviewed_patches filtering logic there.
690          - Add _fetch_bug_page for possible future mocking.
691            (I did not try to test fetch_*_from_bug now due to difficulties with our current validate_reviewer logic.)
692          - Rename fetch_bug to fetch_bug_dictionary and add a new fetch_bug which returns a Bug object.
693          - Use fetch_bug and attachments(), patches(), etc. instead of custom fetch_*_from_bug methods.
694          - Reduce code in fetch_patches_from_pending_commit_list and fetch_patches_from_review_queue
695            using list comprehensions. Use a sum(list, []) trick to flatten a list of lists into a single list.
696         * Scripts/modules/bugzilla_unittest.py:
697          - Remove an unneeded unicode string marker.
698         * Scripts/modules/buildsteps.py:
699          - define __all__ to include just the BuildSteps
700         * Scripts/modules/commands/download.py:
701          - import * now that we have an __all__ defined.
702         * Scripts/modules/commands/upload.py:
703          - Use fetch_bug_dictionary instead of fetch_bug.
704
705 2009-12-29  Daniel Bates  <dbates@webkit.org>
706
707         Reviewed by Ariya Hidayat.
708
709         https://bugs.webkit.org/show_bug.cgi?id=32925
710
711         Adds an Open File dialog to make it convenient to open a file
712         to view in the browser.
713
714         Currently a person must either specify the path to a file as a
715         command-line argument or type a file URL. Instead, we should
716         have a file dialog to allow a person to open a file without
717         memorizing its path.
718
719         * QtLauncher/main.cpp:
720         (MainWindow::MainWindow): Changed urlEdit->setText(qurl.toEncoded())
721         to urlEdit->setText(qurl.toString()). 
722         (MainWindow::openFile): Added.
723         (MainWindow::changeLocation): Moved code to load URL into method
724         MainWindow::loadURL.
725         (MainWindow::loadURL): Added.
726         (MainWindow::setupUI): Added menu item Open File.
727
728 2009-12-29  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
729
730         Reviewed by Holger Freyther.
731
732         [GTK] fails fast/harness/use-page-cache.html
733         https://bugs.webkit.org/show_bug.cgi?id=33013
734
735         Make sure settings are forwarded to child WebViews.
736
737         * DumpRenderTree/gtk/DumpRenderTree.cpp:
738         (createWebView):
739
740 2009-12-29  Daniel Bates  <dbates@webkit.org>
741
742         Reviewed by Eric Seidel.
743
744         https://bugs.webkit.org/show_bug.cgi?id=32778
745
746         Changes $diffPercentage to be a number to resolve Perl
747         warning about comparing a string to a number.
748
749         * Scripts/run-webkit-tests:
750
751 2009-12-29  Jakub Wieczorek  <faw217@gmail.com>
752
753         Reviewed by Eric Seidel.
754
755         [Qt] DRT: Frame loader callbacks differ from the Mac port
756         https://bugs.webkit.org/show_bug.cgi?id=32989
757
758         Remove messages from the callbacks that should not dump them to match
759         the expected results for the http/loading tests.
760
761         Unskip some http/loading tests which succeed now.
762
763         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
764         (WebCore::DumpRenderTree::dump):
765
766 2009-12-29  Robert Hogan  <robert@roberthogan.net>
767
768         Reviewed by Eric Seidel.
769
770         [Qt] fix fast/dom/Window/window-onFocus.html
771         
772         Add support for layouttestcontroller.windowIsKey to Qt DRT and fix issue where
773         window.onblur was getting dispatched twice from QtWebKit.
774         
775         https://bugs.webkit.org/show_bug.cgi?id=32990
776
777         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
778         (WebCore::DumpRenderTree::DumpRenderTree):
779         (WebCore::DumpRenderTree::switchFocus):
780         * DumpRenderTree/qt/DumpRenderTreeQt.h:
781         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
782         (LayoutTestController::setWindowIsKey):
783         (LayoutTestController::setMainFrameIsFirstResponder):
784         * DumpRenderTree/qt/LayoutTestControllerQt.h:
785
786 2009-12-28  Kinuko Yasuda  <kinuko@chromium.org>
787
788         Reviewed by Maciej Stachowiak.
789
790         Extended EventSender.keyDown method to take another (3rd) argument
791         for indicating the keyLocation to make numeric pad key events testable.
792         Expected values for the argument is one of the KeyLocationCode
793         specified in DOM Level 3
794         (http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents).
795         https://bugs.webkit.org/show_bug.cgi?id=28247
796
797         Test: fast/events/keydown-numpad-keys.html
798
799         * DumpRenderTree/mac/EventSendingController.mm:
800         (+[EventSendingController isSelectorExcludedFromWebScript:]):
801         (+[EventSendingController webScriptNameForSelector:]):
802         (-[EventSendingController keyDown:withModifiers:withLocation:]):
803
804 2009-12-28  Ariya Hidayat  <ariya.hidayat@gmail.com>
805
806         Unreviewed, update my email address.
807
808         * Scripts/modules/committers.py:
809
810 2009-12-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
811
812         Reviewed by Adam Barth.
813
814         [Qt] Fix build break for Qt 4.4
815         https://bugs.webkit.org/show_bug.cgi?id=30327
816
817         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Include QLocale
818         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Ditto.
819         * QtLauncher/main.cpp:
820         (MainWindow::MainWindow): Qt::WA_TranslucentBackground was
821         introduced in Qt version 4.5
822
823 2009-12-28  Adam Barth  <abarth@webkit.org>
824
825         Reviewed by Eric Seidel.
826
827         [bzt] Add an edit-changelog command
828         https://bugs.webkit.org/show_bug.cgi?id=32986
829
830         This command makes it easier to edit ChangeLogs.  It's similar to
831         prepare-ChangeLog -o, except it works with already existing ChangeLogs.
832
833         * Scripts/modules/commands/upload.py:
834         * Scripts/modules/commands/upload_unittest.py:
835
836 2009-12-28  Adam Barth  <abarth@webkit.org>
837
838         Reviewed by Eric Seidel.
839
840         [bzt] Create an ASAD command for uploading a patch
841         https://bugs.webkit.org/show_bug.cgi?id=32979
842
843         The create-review command goes through the whole process of preparing a
844         code review, including creating a bug, editing the ChangeLogs, and
845         uploading the patch.  It is indeed the All Sing, All Dance upload
846         command.
847
848         * Scripts/modules/buildsteps.py:
849         * Scripts/modules/commands/upload.py:
850         * Scripts/modules/commands/upload_unittest.py:
851         * Scripts/modules/mock_bugzillatool.py:
852         * Scripts/modules/user.py:
853
854 2009-12-28  Adam Barth  <abarth@webkit.org>
855
856         Unreviewed "build" fix (with test!).
857
858         * Scripts/modules/bugzilla.py:
859         * Scripts/modules/bugzilla_unittest.py:
860
861 2009-12-27  Eric Seidel  <eric@webkit.org>
862
863         Reviewed by Adam Barth.
864
865         Add more awesome bug-parsing logic to bugzilla.py in preparation for assign-to-committer command
866         https://bugs.webkit.org/show_bug.cgi?id=32980
867
868         * Scripts/modules/bugzilla.py:
869          - Add a new _parse_bug_page function and use it in fetch_attachments_from_bug
870          - Replace fetch_title_from_bug with a new fetch_bug call instead.
871          - Use list comprehensions where possible to reduce code duplication.
872         * Scripts/modules/bugzilla_unittest.py:
873          - Add a minimal bug parsing test.
874          - Share code between bug parsing and attachment parsing tests with _assert_dictionaries_equal
875         * Scripts/modules/commands/upload.py:
876          - Use fetch_bug(bug_id)["title"] instead of fetch_title_from_bug
877
878 2009-12-27  Adam Barth  <abarth@webkit.org>
879
880         Reviewed by Eric Seidel.
881
882         Status bubble shouldn't be transparent for bots that haven't run yet
883         https://bugs.webkit.org/show_bug.cgi?id=32977
884
885         * QueueStatusServer/templates/statusbubble.html:
886
887 2009-12-27  Adam Barth  <abarth@webkit.org>
888
889         Reviewed by Eric Seidel.
890
891         [QueueStatusServer] Run gc cron job less often
892         https://bugs.webkit.org/show_bug.cgi?id=32958
893
894         Now that we've cleaned out the backlog of idle messages, we don't need
895         to run the gc job every half hour.  We could also stop logging the idle
896         messages, but this seems easier for the time being.
897
898         * QueueStatusServer/cron.yaml:
899
900 2009-12-27  Daniel Bates  <dbates@webkit.org>
901
902         Reviewed by Adam Barth.
903
904         https://bugs.webkit.org/show_bug.cgi?id=32896
905
906         Fixes an issue where bugzilla-tool tries to read the username and password from
907         Git regardless of whether Git is installed. In particular, if Git is not
908         installed then bugzilla-tool dies (with a trace) when it attempts to query Git
909         for the authentication credentials to log into bugs.webkit.org.
910
911         Moreover, modifies Executive.run_command to catch and pass OSError exceptions to
912         the specified error handler. For instance, the specified error handler will now
913         be called when the command does not exist (i.e. OSError errno 2).
914
915         * Scripts/modules/credentials.py: Added check for Git.
916         * Scripts/modules/credentials_unittest.py: Added test method
917         test_read_credentials_with_SVN.
918         * Scripts/modules/executive.py: Modified method run_command to catch
919         OSError exceptions (i.e [Errno 2] No such file or directory) and call
920         the specified error handler.
921         * Scripts/modules/executive_unittest.py: Added.
922         * Scripts/run-webkit-unittests: Added import executive_unittest.py.
923
924 2009-12-27  Daniel Bates  <dbates@webkit.org>
925
926         Unreviewed. Added missing file style_unittest.py that wasn't committed
927         in change set 52541 (http://trac.webkit.org/changeset/52541) as part of
928         the patch for bug #32592.
929
930         * Scripts/modules/style_unittest.py: Added.
931
932 2009-12-27  Daniel Bates  <dbates@webkit.org>
933
934         Reviewed by Eric Seidel.
935
936         https://bugs.webkit.org/show_bug.cgi?id=32964
937
938         [bzt] Updated the unit test based on the change made in bug #32951.
939
940         The change made in bug #32951 added the command-line argument:
941         --makeargs="-j8" to the build-webkit command. However, the associated
942         unit test was not updated.
943
944         * Scripts/modules/webkitport_unittest.py:
945
946 2009-12-27  Yael Aharon  <yael.aharon@nokia.com>
947
948         Reviewed by Darin Adler.
949
950         check-webkit-style should not mark moc files inclusion as errors
951         https://bugs.webkit.org/show_bug.cgi?id=32669
952
953         Add a new header type for moc files, and skip them when checking the order of header files.
954
955         * Scripts/modules/cpp_style.py:
956
957 2009-12-26  Adam Barth  <abarth@webkit.org>
958
959         Reviewed by Eric Seidel.
960
961         [bzt] Make the qt build go fast
962         https://bugs.webkit.org/show_bug.cgi?id=32951
963
964         Make use of multiple cores, if available.
965
966         * Scripts/modules/webkitport.py:
967
968 2009-12-25  Daniel Bates  <dbates@rim.com>
969
970         Reviewed by Eric Seidel.
971
972         https://bugs.webkit.org/show_bug.cgi?id=32682
973
974         Fixes an issue where checkFrameworks always dies with an error under Windows
975         since the clause "unless (-x $path)" is always satisfied because files under
976         Windows do not have an explict executable bit.
977
978         * Scripts/webkitdirs.pm:
979
980 2009-12-23  Eric Seidel  <eric@webkit.org>
981
982         Reviewed by Adam Barth.
983
984         bugzilla-tool should accept global options anywhere
985         https://bugs.webkit.org/show_bug.cgi?id=26912
986
987         * Scripts/bugzilla-tool:
988          - Use the new global_options class property.
989          - Add a handle_global_options callback to avoid needing callbacks for each global option.
990         * Scripts/modules/multicommandtool.py:
991          - Make the code use one combined option parser.
992            This allows us to accept global options anywhere and
993            individual command options before commands.
994          - Add a handle_global_options callback to avoid needing callbacks for each global option.
995          - Make the Command hold the option parser, but allow the tool to override it.
996          - The default option parser is used for help printing and when Commands are run stand alone,
997            but are otherwise not used.
998          - Add Command.main to codify the idea that Commands should support being run stand-alone.
999          - Change _split_args to _split_command_name_from_args now that args are unified.
1000         * Scripts/modules/multicommandtool_unittest.py:
1001          - Test that "tool" and "tool help" show the same help.
1002          - Test that args are accepted before commands
1003
1004 2009-12-20  Chris Jerdonek  <chris.jerdonek@gmail.com>
1005
1006         Reviewed by David Levin.
1007
1008         Moved some sections of code in preparation to refactor
1009         check-webkit-style's argument parser to avoid setting
1010         global variables.
1011
1012         https://bugs.webkit.org/show_bug.cgi?id=32592
1013
1014         * Scripts/check-webkit-style:
1015           - Moved _USAGE string to style.py.
1016           - Addressed FIXME by eliminating dependencies on cpp_style.py.
1017
1018         * Scripts/modules/cpp_style.py:
1019           - Moved default arguments and style categories to style.py.
1020           - Moved exit_with_usage(), exit_with_categories(), and
1021             parse_arguments() to style.py.
1022           - Removed references in _CppStyleState to the global
1023             variables now in style.py.
1024
1025         * Scripts/modules/cpp_style_unittest.py:
1026           - Moved parse_arguments() unit tests to style_unittest.py.
1027
1028         * Scripts/modules/style.py:
1029           - Added _USAGE string from check-webkit-style.
1030           - Added default arguments and style categories from cpp_style.py.
1031           - Added exit_with_usage(), exit_with_categories(), and
1032             parse_arguments() from cpp_sstyle.py.
1033
1034         * Scripts/modules/style_unittest.py: Added.
1035           - Added parse_arguments() unit tests from cpp_style_unittest.py.
1036
1037         * Scripts/run-webkit-unittests:
1038           - Added unit tests from style_unittest.py.
1039
1040 2009-12-23  Eric Seidel  <eric@webkit.org>
1041
1042         Reviewed by Adam Barth.
1043
1044         commit-queue should mention bug 30084 when rejecting patches until it can be fixed
1045         https://bugs.webkit.org/show_bug.cgi?id=32911
1046
1047         * Scripts/modules/bugzilla.py: Make the message even more fancy.
1048         * Scripts/modules/bugzilla_unittest.py: Test our new fancy message.
1049
1050 2009-12-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1051
1052         Not reviewed, adding myself to the reviewers list.
1053
1054         * Scripts/modules/committers.py:
1055
1056 2009-12-23  Adam Barth  <abarth@webkit.org>
1057
1058         Reviewed by Eric Seidel.
1059
1060         [bzt] Create a prepare-diff command that creates a bug and a ChangeLog
1061         https://bugs.webkit.org/show_bug.cgi?id=32895
1062
1063         The workflow Maciej and I discussed is as follows:
1064
1065         1) Write code.
1066         2) bugzilla-tool prepare-diff
1067         3) Edit ChangeLogs
1068         4) bugzilla-tool post-diff
1069
1070         We might want to experimenting with combining 2-4 into a single
1071         command, but that might be stressful to edit the ChangeLogs modally.
1072
1073         Removed submit-patch since it has the modal ChangeLog editing but none
1074         oof the bug creating fun.
1075
1076         * Scripts/modules/bugzilla.py:
1077         * Scripts/modules/buildsteps.py:
1078         * Scripts/modules/commands/upload.py:
1079         * Scripts/modules/commands/upload_unittest.py:
1080
1081 2009-12-23  Gabor Loki  <loki@webkit.org>
1082
1083         Unreviewed; added myself to the committers list.
1084
1085         * Scripts/modules/committers.py:
1086
1087 2009-12-22  Adam Barth  <abarth@webkit.org>
1088
1089         Reviewed by Maciej Stachowiak.
1090
1091         [bzt] Don't call create-patch twice during post-diff
1092         https://bugs.webkit.org/show_bug.cgi?id=32893
1093
1094         If we call create-patch to get the bug number, cache the diff in the
1095         state so we don't need to call it again.
1096
1097         * Scripts/modules/buildsteps.py:
1098         * Scripts/modules/commands/upload.py:
1099
1100 2009-12-22  Daniel Bates  <dbates@rim.com>
1101
1102         Reviewed by Eric Seidel.
1103
1104         https://bugs.webkit.org/show_bug.cgi?id=32680
1105
1106         Fixes an issue in builtDylibPathForName so that it returns the correct
1107         path to the built QtWebKit library on the Qt Windows port. Currently,
1108         it returns the path to the file named QtWebKit.dll but this file does
1109         not exist on the Qt Windows build. Instead, the file is named
1110         QtWebKit4.dll.
1111
1112         * Scripts/webkitdirs.pm:
1113
1114 2009-12-22  Marc-Antoine Ruel  <maruel@chromium.org>
1115
1116         Reviewed by Adam Roben.
1117
1118         Remove the only dependency on perl-libwin32 in cygwin
1119
1120         * Scripts/num-cpus:
1121
1122 2009-12-22  Darin Adler  <darin@apple.com>
1123
1124         * pywebsocket/mod_pywebsocket: Added property svn:ignore to ignore
1125         generated ".pyc" files.
1126
1127 2009-12-22  Darin Adler  <darin@apple.com>
1128
1129         Reviewed by Mark Rowe.
1130
1131         Turn off datagrid by default, at least for all platforms Apple ships.
1132         The datagrid implementation isn't ready for general web use yet.
1133
1134         * Scripts/build-webkit: Turn off datagrid by default.
1135
1136 2009-12-22  Eric Seidel  <eric@webkit.org>
1137
1138         Reviewed by Darin Adler.
1139
1140         validate-committer-lists fails when run from an SVN checkout
1141         https://bugs.webkit.org/show_bug.cgi?id=31974
1142
1143         * Scripts/validate-committer-lists:
1144          - Make it print a warning message instead of throwing
1145            an exception when running from an SVN checkout.
1146
1147 2009-12-22  Philippe Normand  <pnormand@igalia.com>
1148
1149         Reviewed by Adam Barth.
1150
1151         check-webkit-style should not warn about NULL usage in g_object_{get,set}
1152         https://bugs.webkit.org/show_bug.cgi?id=32858
1153
1154         * Scripts/modules/cpp_style.py:
1155         * Scripts/modules/cpp_style_unittest.py:
1156
1157 2009-12-22  Simon Hausmann  <simon.hausmann@nokia.com>
1158
1159         Rubber-stamped by Holger Freyther.
1160
1161         Moved QtLauncher from WebKit/qt.
1162
1163         * QtLauncher: Copied from WebKit/qt/QtLauncher.
1164         * QtLauncher/QtLauncher.pro:
1165
1166 2009-12-21  Adam Barth  <abarth@webkit.org>
1167
1168         Reviewed by Eric Seidel.
1169
1170         [bzt] Automate the process of calling prepare-ChangeLog
1171         https://bugs.webkit.org/show_bug.cgi?id=32816
1172
1173         This patch automates the process of creating a bug and patch and
1174         uploading it to bugzilla.  The first cut just calls
1175         prepare-ChangeLog.
1176
1177         This patch required some refactoring of upload.py to the Step
1178         model, but that's worth doing anyway.
1179
1180         * Scripts/bugzilla-tool:
1181         * Scripts/modules/buildsteps.py:
1182         * Scripts/modules/commands/download.py:
1183         * Scripts/modules/commands/upload.py:
1184         * Scripts/modules/commands/upload_unittest.py:
1185         * Scripts/modules/mock_bugzillatool.py:
1186
1187 2009-12-21  Darin Adler  <darin@apple.com>
1188
1189         * Scripts/do-webcore-rename: Did a rename, so checking in the
1190         version of the script I used.
1191
1192 2009-12-21  Adam Barth  <abarth@webkit.org>
1193
1194         Reviewed by Eric Seidel.
1195
1196         Update status-bubble to show all the queues
1197         https://bugs.webkit.org/show_bug.cgi?id=32838
1198
1199         Also, move statusbubble over to use memcache.
1200
1201         * QueueStatusServer/handlers/statusbubble.py:
1202         * QueueStatusServer/templates/statusbubble.html:
1203
1204 2009-12-21  Adam Barth  <abarth@webkit.org>
1205
1206         Reviewed by Eric Seidel.
1207
1208         Delete the boring "Empty queue" status messages in QueueStatusServer
1209         https://bugs.webkit.org/show_bug.cgi?id=32818
1210
1211         * QueueStatusServer/app.yaml:
1212         * QueueStatusServer/cron.yaml:
1213         * QueueStatusServer/handlers/gc.py:
1214         * QueueStatusServer/main.py:
1215
1216 2009-12-21  Adam Barth  <abarth@webkit.org>
1217
1218         Reviewed by Eric Seidel.
1219
1220         Exception on queue status server
1221         https://bugs.webkit.org/show_bug.cgi?id=32812
1222
1223         Turns out we need to pass the id to the filter.
1224
1225         * QueueStatusServer/filters/webkit_extras.py:
1226         * QueueStatusServer/templates/patch.html:
1227         * QueueStatusServer/templates/recentstatus.html:
1228
1229 2009-12-20  Chris Jerdonek  <chris.jerdonek@gmail.com>
1230
1231         Reviewed by Eric Seidel.
1232
1233         Created "style" folder for code supporting check-webkit-style.
1234
1235         * Scripts/modules/style: Added.
1236
1237 2009-12-20  Adam Barth  <abarth@webkit.org>
1238
1239         Reviewed by Eric Seidel.
1240
1241         REGRESSION: error when running commit-queue
1242         https://bugs.webkit.org/show_bug.cgi?id=32806
1243
1244         Fix typo and add test!
1245
1246         * Scripts/modules/bugzilla.py:
1247         * Scripts/modules/bugzilla_unittest.py:
1248
1249 2009-12-20  Adam Barth  <abarth@webkit.org>
1250
1251         [bzt] Optimize status updates for new dashboard
1252         https://bugs.webkit.org/show_bug.cgi?id=32797
1253
1254         This patch makes the queues slightly more chatty with the web service.
1255         Also, this patch introduces some testing for the queues!
1256
1257         * Scripts/modules/commands/early_warning_system.py:
1258         * Scripts/modules/commands/early_warning_system_unittest.py: Added.
1259         * Scripts/modules/commands/queues.py:
1260         * Scripts/modules/commands/queues_unittest.py:
1261         * Scripts/modules/commands/queuestest.py: Added.
1262         * Scripts/modules/mock_bugzillatool.py:
1263         * Scripts/modules/patchcollection.py:
1264         * Scripts/modules/queueengine.py:
1265         * Scripts/run-webkit-unittests:
1266
1267 2009-12-20  Adam Barth  <abarth@webkit.org>
1268
1269         Reviewed by Eric Seidel.
1270
1271         Prepare QueueStatusServer for new status messages
1272         https://bugs.webkit.org/show_bug.cgi?id=32805
1273
1274         * QueueStatusServer/handlers/recentstatus.py:
1275         * QueueStatusServer/index.html: Removed.
1276         * QueueStatusServer/model/attachment.py:
1277         * QueueStatusServer/model/queues.py: Added.
1278         * QueueStatusServer/templates/recentstatus.html: Added.
1279
1280 2009-12-20  Shinichiro Hamaji  <hamaji@chromium.org>
1281
1282         Reviewed by Adam Barth.
1283
1284         [check-webkit-style] static_cast is not misnamed!
1285         https://bugs.webkit.org/show_bug.cgi?id=32796
1286
1287         * Scripts/modules/cpp_style.py:
1288         * Scripts/modules/cpp_style_unittest.py:
1289
1290 2009-12-20  Alejandro G. Castro  <alex@igalia.com>
1291
1292         Reviewed by Gustavo Noronha Silva.
1293
1294         [GTK] Failing test platform/gtk/editing/pasteboard/middle-button-paste.html
1295         https://bugs.webkit.org/show_bug.cgi?id=32788
1296
1297         Do not increase the click count if we are using a different button.
1298
1299         * DumpRenderTree/gtk/EventSender.cpp:
1300
1301 2009-12-20  Adam Barth  <abarth@webkit.org>
1302
1303         Reviewed by Eric Seidel.
1304
1305         [QueueStatusServer] Add a per-patch details page
1306         https://bugs.webkit.org/show_bug.cgi?id=32784
1307
1308         This is a first cut at a per-patch details page.  I'm sure we'll have
1309         to iterate.
1310
1311         * QueueStatusServer/filters/webkit_extras.py:
1312         * QueueStatusServer/handlers/patch.py: Added.
1313         * QueueStatusServer/index.yaml:
1314         * QueueStatusServer/main.py:
1315         * QueueStatusServer/model/attachment.py:
1316         * QueueStatusServer/stylesheets/dashboard.css:
1317         * QueueStatusServer/templates/dashboard.html:
1318         * QueueStatusServer/templates/patch.html: Added.
1319
1320 2009-12-20  Adam Barth  <abarth@webkit.org>
1321
1322         Reviewed by Eric Seidel.
1323
1324         Use memcache to make dashboard to fast
1325         https://bugs.webkit.org/show_bug.cgi?id=32780
1326
1327         * QueueStatusServer/app.yaml:
1328         * QueueStatusServer/handlers/dashboard.py:
1329         * QueueStatusServer/handlers/updatestatus.py:
1330         * QueueStatusServer/model/attachment.py: Added.
1331
1332 2009-12-19  Brent Fulgham  <bfulgham@webkit.org>
1333
1334         Reviewed by Adam Roben.
1335
1336         Provide an example implementation for printing under Windows.
1337         http://bugs.webkit.org/show_bug.cgi?id=32504.`
1338
1339         * WinLauncher/PrintWebUIDelegate.cpp: Added.
1340         (PrintWebUIDelegate::QueryInterface):
1341         (PrintWebUIDelegate::AddRef):
1342         (PrintWebUIDelegate::Release):
1343         (PrintWebUIDelegate::webViewPrintingMarginRect):
1344         * WinLauncher/PrintWebUIDelegate.h: Added.
1345         (PrintWebUIDelegate::PrintWebUIDelegate):
1346         (PrintWebUIDelegate::createWebViewWithRequest):
1347         (PrintWebUIDelegate::webViewShow):
1348         (PrintWebUIDelegate::webViewClose):
1349         (PrintWebUIDelegate::webViewFocus):
1350         (PrintWebUIDelegate::webViewUnfocus):
1351         (PrintWebUIDelegate::webViewFirstResponder):
1352         (PrintWebUIDelegate::makeFirstResponder):
1353         (PrintWebUIDelegate::setStatusText):
1354         (PrintWebUIDelegate::webViewStatusText):
1355         (PrintWebUIDelegate::webViewAreToolbarsVisible):
1356         (PrintWebUIDelegate::setToolbarsVisible):
1357         (PrintWebUIDelegate::webViewIsStatusBarVisible):
1358         (PrintWebUIDelegate::setStatusBarVisible):
1359         (PrintWebUIDelegate::webViewIsResizable):
1360         (PrintWebUIDelegate::setResizable):
1361         (PrintWebUIDelegate::setFrame):
1362         (PrintWebUIDelegate::webViewFrame):
1363         (PrintWebUIDelegate::setContentRect):
1364         (PrintWebUIDelegate::webViewContentRect):
1365         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage):
1366         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage):
1367         (PrintWebUIDelegate::runJavaScriptTextInputPanelWithPrompt):
1368         (PrintWebUIDelegate::runBeforeUnloadConfirmPanelWithMessage):
1369         (PrintWebUIDelegate::runOpenPanelForFileButtonWithResultListener):
1370         (PrintWebUIDelegate::mouseDidMoveOverElement):
1371         (PrintWebUIDelegate::contextMenuItemsForElement):
1372         (PrintWebUIDelegate::validateUserInterfaceItem):
1373         (PrintWebUIDelegate::shouldPerformAction):
1374         (PrintWebUIDelegate::dragDestinationActionMaskForDraggingInfo):
1375         (PrintWebUIDelegate::willPerformDragDestinationAction):
1376         (PrintWebUIDelegate::dragSourceActionMaskForPoint):
1377         (PrintWebUIDelegate::willPerformDragSourceAction):
1378         (PrintWebUIDelegate::contextMenuItemSelected):
1379         (PrintWebUIDelegate::hasCustomMenuImplementation):
1380         (PrintWebUIDelegate::trackCustomPopupMenu):
1381         (PrintWebUIDelegate::measureCustomMenuItem):
1382         (PrintWebUIDelegate::drawCustomMenuItem):
1383         (PrintWebUIDelegate::addCustomMenuDrawingData):
1384         (PrintWebUIDelegate::cleanUpCustomMenuDrawingData):
1385         (PrintWebUIDelegate::canTakeFocus):
1386         (PrintWebUIDelegate::takeFocus):
1387         (PrintWebUIDelegate::registerUndoWithTarget):
1388         (PrintWebUIDelegate::removeAllActionsWithTarget):
1389         (PrintWebUIDelegate::setActionTitle):
1390         (PrintWebUIDelegate::undo):
1391         (PrintWebUIDelegate::redo):
1392         (PrintWebUIDelegate::canUndo):
1393         (PrintWebUIDelegate::canRedo):
1394         (PrintWebUIDelegate::printFrame):
1395         (PrintWebUIDelegate::ftpDirectoryTemplatePath):
1396         (PrintWebUIDelegate::webViewHeaderHeight):
1397         (PrintWebUIDelegate::webViewFooterHeight):
1398         (PrintWebUIDelegate::drawHeaderInRect):
1399         (PrintWebUIDelegate::drawFooterInRect):
1400         (PrintWebUIDelegate::canRunModal):
1401         (PrintWebUIDelegate::createModalDialog):
1402         (PrintWebUIDelegate::runModal):
1403         (PrintWebUIDelegate::isMenuBarVisible):
1404         (PrintWebUIDelegate::setMenuBarVisible):
1405         (PrintWebUIDelegate::runDatabaseSizeLimitPrompt):
1406         (PrintWebUIDelegate::paintCustomScrollbar):
1407         (PrintWebUIDelegate::paintCustomScrollCorner):
1408         * WinLauncher/WinLauncher.cpp: Add new UI delegate for print support.
1409         (WinLauncherWebHost::updateAddressBar): check-webkit-style fixes.
1410         (WinLauncherWebHost::QueryInterface): check-webkit-style fixes.
1411         (WinLauncherWebHost::AddRef): check-webkit-style fixes.
1412         (WinLauncherWebHost::Release): check-webkit-style fixes.
1413         (resizeSubViews): check-webkit-style fixes.
1414         (_tWinMain): check-webkit-style fixes.
1415         (MyRegisterClass): check-webkit-style fixes.
1416         (InitInstance): check-webkit-style fixes.
1417         (AbortProc): New print support function.
1418         (getPrinterDC): New print support function.
1419         (initDocStruct): New print support function.
1420         (PrintView): New printing implementation.
1421         (WndProc): Add support for printing.
1422         (MyEditProc): check-webkit-style fixes.
1423         (About): check-webkit-style fixes.
1424         (loadURL): check-webkit-style fixes.
1425         * WinLauncher/WinLauncher.h:
1426         (WinLauncherWebHost::WinLauncherWebHost):
1427         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
1428         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
1429         (WinLauncherWebHost::didFailProvisionalLoadWithError):
1430         (WinLauncherWebHost::didCommitLoadForFrame):
1431         (WinLauncherWebHost::didReceiveTitle):
1432         (WinLauncherWebHost::didReceiveIcon):
1433         (WinLauncherWebHost::didFinishLoadForFrame):
1434         (WinLauncherWebHost::didFailLoadWithError):
1435         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
1436         (WinLauncherWebHost::willPerformClientRedirectToURL):
1437         (WinLauncherWebHost::didCancelClientRedirectForFrame):
1438         (WinLauncherWebHost::willCloseFrame):
1439         (WinLauncherWebHost::windowScriptObjectAvailable):
1440         * WinLauncher/WinLauncher.rc: Add menu entry for printing.
1441         * WinLauncher/WinLauncher.vcproj: Add new files.
1442         * WinLauncher/resource.h: Add menu entry for printing.
1443
1444 2009-12-19  Adam Barth  <abarth@webkit.org>
1445
1446         Unreviewed.  Tweak the CSS to make the dashboard prettier.
1447
1448         * QueueStatusServer/stylesheets/dashboard.css:
1449         * QueueStatusServer/templates/dashboard.html:
1450
1451 2009-12-19  Adam Barth  <abarth@webkit.org>
1452
1453         Reviewed by Eric Seidel.
1454
1455         QueueStatusServer needs a human readable dashboard
1456         https://bugs.webkit.org/show_bug.cgi?id=32769
1457
1458         Here is a first cut at the dashboard.  There's a lot left to do.
1459
1460         * QueueStatusServer/filters/webkit_extras.py:
1461         * QueueStatusServer/handlers/dashboard.py: Added.
1462         * QueueStatusServer/handlers/patchstatus.py:
1463         * QueueStatusServer/handlers/recentstatus.py:
1464         * QueueStatusServer/handlers/showresults.py:
1465         * QueueStatusServer/handlers/statusbubble.py:
1466         * QueueStatusServer/handlers/updatestatus.py:
1467         * QueueStatusServer/main.py:
1468         * QueueStatusServer/model/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
1469         * QueueStatusServer/model/queuestatus.py: Renamed from WebKitTools/QueueStatusServer/model.py.
1470         * QueueStatusServer/stylesheets/dashboard.css: Added.
1471         * QueueStatusServer/templates/dashboard.html: Added.
1472         * QueueStatusServer/templates/statusbubble.html: Renamed from WebKitTools/QueueStatusServer/status_bubble.html.
1473         * QueueStatusServer/templates/updatestatus.html: Renamed from WebKitTools/QueueStatusServer/update_status.html.
1474
1475 2009-12-19  Daniel Bates  <dbates@webkit.org>
1476
1477         Reviewed by Timothy Hatcher.
1478
1479         https://bugs.webkit.org/show_bug.cgi?id=32462
1480
1481         Added --inspector-frontend flag to build-webkit to copy any changes
1482         to the inspector front-end files to the built WebCore framework. This
1483         will make inspector development more consistent with the rest of
1484         WebKit development.
1485
1486         * Scripts/build-webkit:
1487         * Scripts/webkitdirs.pm:
1488
1489 2009-12-19  Adam Barth  <abarth@webkit.org>
1490
1491         Unreviewed fixes for me being terrible at python.
1492
1493         * Scripts/modules/bugzilla.py:
1494         * Scripts/run-webkit-unittests:
1495
1496 2009-12-18  Adam Barth  <abarth@webkit.org>
1497
1498         Reviewed by Eric Seidel.
1499
1500         Split QueueStatus server into modules
1501         https://bugs.webkit.org/show_bug.cgi?id=32768
1502
1503         One monolithic file is no good.
1504
1505         * QueueStatusServer/app.yaml:
1506         * QueueStatusServer/handlers/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
1507         * QueueStatusServer/handlers/patchstatus.py: Added.
1508         * QueueStatusServer/handlers/recentstatus.py: Added.
1509         * QueueStatusServer/handlers/showresults.py: Added.
1510         * QueueStatusServer/handlers/statusbubble.py: Added.
1511         * QueueStatusServer/handlers/updatestatus.py: Added.
1512         * QueueStatusServer/main.py: Added.
1513         * QueueStatusServer/model.py: Added.
1514         * QueueStatusServer/queue_status.py: Removed.
1515
1516 2009-12-18  Adam Barth  <abarth@webkit.org>
1517
1518         Rubber stamped by Eric Seidel.
1519
1520         Renamed WorkQueue to QueueEngine.  WorkQueue is not a queue.
1521
1522         * Scripts/modules/commands/queues.py:
1523         * Scripts/modules/queueengine.py: Added.
1524         * Scripts/modules/queueengine_unittest.py: Added.
1525         * Scripts/modules/stepsequence.py:
1526         * Scripts/modules/workqueue.py: Removed.
1527         * Scripts/modules/workqueue_unittest.py: Removed.
1528
1529 2009-12-18  Adam Barth  <abarth@webkit.org>
1530
1531         Reviewed by Eric Seidel.
1532
1533         Add watches for EWS
1534         https://bugs.webkit.org/show_bug.cgi?id=32767
1535
1536         dglazkov wanted to be added.
1537
1538         * Scripts/modules/bugzilla.py:
1539         * Scripts/modules/commands/early_warning_system.py:
1540         * Scripts/modules/commands/queues.py:
1541
1542 2009-12-18  Eric Seidel  <eric@webkit.org>
1543
1544         Reviewed by David Levin.
1545
1546         move bugzilla.py off of urllib2
1547         https://bugs.webkit.org/show_bug.cgi?id=32729
1548
1549         * Scripts/modules/bugzilla.py: use mechanize for all url fetching.
1550
1551 2009-12-18  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1552
1553         Rubber-stamped by Xan Lopez.
1554
1555         [GTK] New events (pageshow and pagehide) tests failing
1556         https://bugs.webkit.org/show_bug.cgi?id=28823
1557
1558         Original patch by Jan Michael Alonzo.
1559
1560         Disable page cache for tests.
1561
1562         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1563         (resetDefaultsToConsistentValues):
1564         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1565         (copyWebSettingKey):
1566         (LayoutTestController::overridePreference):
1567
1568 2009-12-18  Fumitoshi Ukai  <ukai@chromium.org>
1569
1570         Reviewed by David Levin.
1571
1572         Check one space before end of line comments.
1573         https://bugs.webkit.org/show_bug.cgi?id=32597
1574         
1575         Fix to check one space before end of line comments in whitespace and build/header_guard.
1576         Also fix build/header_guard to use WebKit header guard defines.
1577
1578         * Scripts/modules/cpp_style.py:
1579         * Scripts/modules/cpp_style_unittest.py:
1580
1581 2009-12-17  Sam Weinig  <sam@webkit.org>
1582
1583         Reviewed by Mark Rowe.
1584
1585         Add BUILDING_ON_SNOW_LEOPARD #define.
1586
1587         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1588
1589 2009-12-17  Yuzo Fujishima  <yuzo@google.com>
1590
1591         Reviewed by Alexey Proskuryakov.
1592
1593         Update pywebsocket to 0.4.5 and make handshake checking stricter
1594         https://bugs.webkit.org/show_bug.cgi?id=32249
1595
1596         * Scripts/run-webkit-tests:
1597         * pywebsocket/mod_pywebsocket/handshake.py:
1598         * pywebsocket/mod_pywebsocket/memorizingfile.py: Added.
1599         * pywebsocket/mod_pywebsocket/standalone.py:
1600         * pywebsocket/setup.py:
1601         * pywebsocket/test/test_handshake.py:
1602         * pywebsocket/test/test_memorizingfile.py: Added.
1603
1604 2009-12-17  Eric Seidel  <eric@webkit.org>
1605
1606         Reviewed by Adam Barth.
1607
1608         Command.show_in_main_help should default to False
1609         https://bugs.webkit.org/show_bug.cgi?id=32686
1610
1611         * Scripts/modules/commands/download.py:
1612         * Scripts/modules/commands/queries.py:
1613         * Scripts/modules/commands/queues.py:
1614         * Scripts/modules/commands/upload.py:
1615         * Scripts/modules/multicommandtool.py:
1616
1617 2009-12-17  Alejandro G. Castro  <alex@igalia.com>
1618
1619         Reviewed by Eric Seidel.
1620
1621         Added the key WebKitEnableCaretBrowsing to the
1622         layoutTestController.overridePreference in order to activate caret
1623         browsing.
1624         https://bugs.webkit.org/show_bug.cgi?id=32612
1625
1626         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added the reset value of
1627         the setting.
1628         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Inserted the new
1629         key in the keytable.
1630
1631 2009-12-17  Chris Fleizach  <cfleizach@apple.com>
1632
1633         Reviewed by David Kilzer.
1634
1635         AX: DRT needs to support URL for accessibility
1636         https://bugs.webkit.org/show_bug.cgi?id=32666
1637
1638         * DumpRenderTree/AccessibilityUIElement.cpp:
1639         (getURLCallback):
1640         (AccessibilityUIElement::getJSClass):
1641         * DumpRenderTree/AccessibilityUIElement.h:
1642         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1643         (AccessibilityUIElement::url):
1644         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1645         (AccessibilityUIElement::url):
1646         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1647         (AccessibilityUIElement::url):
1648
1649 2009-12-17  Philippe Normand  <pnormand@igalia.com>
1650
1651         Unreviewed; added myself to committers
1652
1653         * Scripts/modules/committers.py:
1654
1655 2009-12-17  Benjamin Otte  <otte@gnome.org>
1656
1657         Unreviewed; added myself to committers
1658
1659         * Scripts/modules/committers.py:
1660
1661 2009-12-17  Adam Barth  <abarth@webkit.org>
1662
1663         Rubber stamp by Seidel.
1664
1665         Clean up exception handling in WorkQueue.  Basically, a bunch of the
1666         delegate messages can throw exceptions because of network errors.  We
1667         want the queues to keep on ticking instead of erroring out.  That means
1668         we want to catch generic exceptions and continue looping.
1669
1670         Also, cleaned up the exception handling in the EWS to properly log
1671         failures.
1672
1673         * Scripts/modules/commands/early_warning_system.py:
1674         * Scripts/modules/commands/queues.py:
1675         * Scripts/modules/workqueue.py:
1676
1677 2009-12-16  Adam Barth  <abarth@webkit.org>
1678
1679         Reviewed by Eric Seidel.
1680
1681         [bzt] Make UpdateStep quiet
1682         https://bugs.webkit.org/show_bug.cgi?id=32599
1683
1684         * Scripts/modules/buildsteps.py:
1685         * Scripts/modules/buildsteps_unittest.py:
1686
1687 2009-12-16  Evan Martin  <evan@chromium.org>
1688
1689         Reviewed by Adam Barth.
1690
1691         Add Gtk to the early warning system WebKit port list.
1692
1693         https://bugs.webkit.org/show_bug.cgi?id=32629
1694
1695         * Scripts/modules/commands/early_warning_system.py:
1696         * Scripts/modules/webkitport.py:
1697         * Scripts/modules/webkitport_unittest.py:
1698
1699 2009-12-16  Eric Seidel  <eric@webkit.org>
1700
1701         Reviewed by Adam Barth.
1702
1703         post-diff is failing with exception under guess_reviewer_from_bug
1704         https://bugs.webkit.org/show_bug.cgi?id=32642
1705
1706         Also refactor output capturing code into
1707         OutputCapture.assert_outputs to share more code between tests.
1708
1709         * Scripts/modules/buildsteps.py:
1710          - Add the missing include.
1711          - Give guess_reviewer_from_bug a private underscore.
1712         * Scripts/modules/buildsteps_unittest.py: Added.
1713          - Test to make sure _guess_reviewer_from_bug works as expected.
1714         * Scripts/modules/commands/commandtest.py:
1715          - Custom code is now obsoleted by OutputCapture.assert_outputs
1716         * Scripts/modules/commands/queues_unittest.py:
1717          - ditto
1718         * Scripts/modules/credentials_unittest.py:
1719          - ditto
1720         * Scripts/modules/mock_bugzillatool.py:
1721          - fetch_reviewed_patches_from_bug can never return None
1722         * Scripts/modules/multicommandtool_unittest.py:
1723          - Custom code is now obsoleted by OutputCapture.assert_outputs
1724         * Scripts/modules/outputcapture.py:
1725          - Add assert_outputs to share more code between tests.
1726         * Scripts/run-webkit-unittests:
1727          - Add buildsteps_unittest.py
1728
1729 2009-12-16  Adam Barth  <abarth@webkit.org>
1730
1731         Unreviewed.  Added a default argument to _update_status so that callers
1732         don't have to explictly pass None when they don't have a patch object.
1733
1734         * Scripts/modules/commands/queues.py:
1735
1736 2009-12-16  Kent Tamura  <tkent@chromium.org>
1737
1738         Reviewed by David Levin.
1739
1740         check-webkit-style supports for TAB check against text files.
1741         https://bugs.webkit.org/show_bug.cgi?id=32538
1742
1743         * Scripts/check-webkit-style:
1744           Move process_patch() to style.py.
1745         * Scripts/modules/cpp_style.py:
1746           Add can_handle().
1747         * Scripts/modules/cpp_style_unittest.py:
1748           Add tests for can_handle().
1749         * Scripts/modules/style.py:
1750           Added. This is a front-end of cpp_style and text_style. It dispatches
1751           files to an appropriate linter.
1752         * Scripts/modules/text_style.py:
1753           Added. This is a linter module for generic text files. It supports
1754           only for TAB checking at this moment.
1755         * Scripts/modules/text_style_unittest.py:
1756           Added. Tests for text_style.py.
1757         * Scripts/run-webkit-unittests:
1758           Add text_style_unittest.
1759
1760 2009-12-16  Eric Seidel  <eric@webkit.org>
1761
1762         Reviewed by David Levin.
1763
1764         bugzilla-tool should not require users to install mechanize
1765         https://bugs.webkit.org/show_bug.cgi?id=32635
1766
1767         Centralize our import logic.
1768
1769         * Scripts/modules/bugzilla.py: use webkit_mechanize
1770         * Scripts/modules/statusbot.py: use webkit_mechanize
1771         * Scripts/modules/webkit_mechanize.py: Added.
1772
1773 2009-12-16  Eric Seidel  <eric@webkit.org>
1774
1775         Reviewed by Adam Barth.
1776
1777         Generalize commit-queue recent status page for all queues
1778         https://bugs.webkit.org/show_bug.cgi?id=32633
1779
1780         * QueueStatusServer/index.html:
1781          - Generalize to support other queues.
1782         * QueueStatusServer/queue_status.py:
1783          - Generalize MainPage to support other queues.
1784
1785 2009-12-16  Evan Martin  <evan@chromium.org>
1786
1787         Reviewed by Adam Barth.
1788
1789         Early warning system server should display output as UTF-8.
1790
1791         https://bugs.webkit.org/show_bug.cgi?id=32625
1792
1793         * QueueStatusServer/queue_status.py:
1794
1795 2009-12-16  Adam Barth  <abarth@webkit.org>
1796
1797         Reviewed by Eric Seidel.
1798
1799         [bzt] Add error handling to the early warning system
1800         https://bugs.webkit.org/show_bug.cgi?id=32594
1801
1802         This should be the last step in making the EWS operational.  When we
1803         have a build error, we post the log to QueueStatusServer and add a link
1804         to the bug.
1805
1806         * Scripts/modules/commands/early_warning_system.py:
1807         * Scripts/modules/commands/queues.py:
1808         * Scripts/modules/executive.py:
1809
1810 2009-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
1811
1812         Reviewed by Holger Freyther.
1813
1814         Fix crash with tests that use custom font faces.
1815
1816         https://bugs.webkit.org/show_bug.cgi?id=32600
1817
1818         In the DRT we call QApplication::removeAllApplicationFonts(), to make sure
1819         that custom font faces between tests don't influence each other. Calling this
1820         function in Qt however also invalidates all existing handles with QFontDatabase.
1821
1822         In order to make sure that WebCore also drops these handles we call QWebSettings::clearMemoryCaches(),
1823         which implies a call to WebCore::FontCache::fontCache()->invalidate().
1824
1825         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1826         (WebCore::DumpRenderTree::open):
1827
1828 2009-12-16  Andreas Kling  <andreas.kling@nokia.com>
1829
1830         Reviewed by Simon Hausmann.
1831
1832         [Qt] Maintain button state between mouse events.
1833
1834         This allows eventSender to generate drag events.
1835
1836         https://bugs.webkit.org/show_bug.cgi?id=32601
1837
1838         * DumpRenderTree/qt/EventSenderQt.cpp:
1839         (EventSender::mouseDown):
1840         (EventSender::mouseUp):
1841         (EventSender::mouseMoveTo):
1842         * DumpRenderTree/qt/EventSenderQt.h:
1843
1844 2009-12-15  Chris Jerdonek  <chris.jerdonek@gmail.com>
1845
1846         Reviewed by David Levin.
1847
1848         Code clean-up in check-webkit-style as described below.
1849         The only functional changes are minor improvements to the
1850         script's help output.
1851         
1852         https://bugs.webkit.org/show_bug.cgi?id=32487
1853
1854         * Scripts/check-webkit-style:
1855           - Added the module docstring from cpp_style.py.
1856           - Improved wording of the --help output and added some of the
1857             default values as substitution strings.
1858           - Called cpp_style.exit_with_usage instead of sys.stderr.write
1859             in main function.
1860           - Made changes caused by changes to cpp_style.py.
1861
1862         * Scripts/modules/cpp_style.py:
1863           - Removed module docstring, as well as redundant _USAGE string
1864             and main() function obsoleted by check-webkit-style.
1865           - Moved specification of default script values from within a
1866             function definition to global variables.
1867           - Moved the default webkit filter rules to be near the other
1868             global variables.
1869           - Renamed "FILTER" global variables to "FILTER_RULES" to
1870             establish unambiguous terminology.
1871           - Renamed _ERROR_CATEGORIES to _STYLE_CATEGORIES.
1872           - Changed _STYLE_CATEGORIES from a string to a list.
1873           - Added default webkit filter rules to --filter= output.
1874           - Renamed "print_" methods to "exit_with_" since they exist
1875             and added a temporary display_help parameter.
1876           - Added a temporary display_help parameter to parse_arguments.
1877
1878         * Scripts/modules/cpp_style_unittest.py:
1879           - Made changes caused by changes to cpp_style.py.
1880           - Lower-cased ErrorCollector's ERROR_CATEGORIES instance 
1881             variables since they are not global.
1882
1883 2009-12-15  Adam Barth  <abarth@webkit.org>
1884
1885         Unreviewed fix for the style-queue.
1886         Typo: _updates_status -> _update_status
1887
1888         We need to improve our testing infrastructure for the queues.
1889
1890         * Scripts/modules/commands/queues.py:
1891
1892 2009-12-15  Adam Barth  <abarth@webkit.org>
1893
1894         Unreviewed fix for the style-queue.  I suspect this is a recent
1895         regression from Eric's change below.
1896
1897         * Scripts/modules/commands/queues.py:
1898
1899 2009-12-15  Yaar Schnitman  <yaar@chromium.org>
1900
1901         Reviewed by Darin Fisher.
1902
1903         update-webkit-chromium to auto-install gclient
1904
1905         https://bugs.webkit.org/show_bug.cgi?id=32587
1906
1907         * Scripts/update-webkit-chromium:
1908
1909 2009-12-15  Eric Seidel  <eric@webkit.org>
1910
1911         Reviewed by Adam Barth.
1912
1913         bugzilla-tool / commit-queue should add results links to bugs when more results are available on the status bot
1914         https://bugs.webkit.org/show_bug.cgi?id=32546
1915
1916         You can see an example of this working in:
1917         https://bugs.webkit.org/show_bug.cgi?id=32585#c3
1918
1919         * QueueStatusServer/queue_status.py:
1920          - Output the id of the newly created status.
1921         * Scripts/modules/commands/queues.py:
1922          - Tweak the commit-queue logging to include a full status link.
1923         * Scripts/modules/statusbot.py:
1924          - update_status should return the newly created status id.
1925
1926 2009-12-15  Andras Becsi  <abecsi@inf.u-szeged.hu>
1927
1928         Reviewed by Tor Arne Vestbø.
1929
1930         [Qt] Rename Qt DRT components to match other ports' naming convention and to be more understandable.
1931
1932         * DumpRenderTree/qt/DumpRenderTree.cpp: Removed.
1933         * DumpRenderTree/qt/DumpRenderTree.h: Removed.
1934         * DumpRenderTree/qt/DumpRenderTree.pro: Updated.
1935         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.cpp.
1936         * DumpRenderTree/qt/DumpRenderTreeQt.h: Copied from WebKitTools/DumpRenderTree/qt/DumpRenderTree.h.
1937         * DumpRenderTree/qt/GCControllerQt.cpp: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.cpp.
1938         (GCController::GCController):
1939         * DumpRenderTree/qt/GCControllerQt.h: Copied from WebKitTools/DumpRenderTree/qt/jsobjects.h.
1940         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1941         * DumpRenderTree/qt/WorkQueueItem.h: Removed.
1942         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Updated includes.
1943         * DumpRenderTree/qt/WorkQueueItemQt.h: Copied from WebKitTools/DumpRenderTree/qt/WorkQueueItem.h.
1944         * DumpRenderTree/qt/jsobjects.cpp: Removed.
1945         * DumpRenderTree/qt/jsobjects.h: Removed.
1946         * DumpRenderTree/qt/main.cpp: Updated includes.
1947
1948 2009-12-15  Adam Barth  <abarth@webkit.org>
1949
1950         Reviewed by Eric Seidel.
1951
1952         We have two mark-fixed commands
1953         https://bugs.webkit.org/show_bug.cgi?id=32073
1954
1955         * Scripts/mark-bug-fixed: Removed.
1956         * Scripts/modules/commands/upload.py:
1957         * Scripts/modules/commands/upload_unittest.py:
1958
1959 2009-12-15  Eric Seidel  <eric@webkit.org>
1960
1961         Reviewed by Adam Barth.
1962
1963         bugzilla-tool/commit-queue needs to upload failure logs when patches are rejected
1964         https://bugs.webkit.org/show_bug.cgi?id=28286
1965
1966         * QueueStatusServer/index.html:
1967          - Show [results] links if a results log was uploaded.
1968         * QueueStatusServer/queue_status.py:
1969          - Empty file uploads appear as u"" and Blob does not handle unicode, so convert to str().
1970         * Scripts/modules/commands/queues.py:
1971          - Post to the status bot when a patch fails and include the failure log as a results file.
1972
1973 2009-12-15  Eric Seidel  <eric@webkit.org>
1974
1975         Reviewed by Adam Barth.
1976
1977         queue sub-commands need --status-host so they can report status
1978         https://bugs.webkit.org/show_bug.cgi?id=32313
1979
1980         Make --status-bot a global option and make
1981         run_bugzilla_tool pass --status-bot to sub-commands.
1982
1983         * Scripts/bugzilla-tool:
1984          - Rename _status to status_bot and make it non-lazy.
1985         * Scripts/modules/commands/queues.py:
1986          - Move status updates out of WorkQueue and into individual queues.
1987         * Scripts/modules/commands/queues_unittest.py:
1988          - Test that --status-host is passed to bugzilla-tool when run as subcommand.
1989         * Scripts/modules/mock_bugzillatool.py:
1990          - Add a MockStatusBot
1991         * Scripts/modules/workqueue.py:
1992          - Remove status_host and work_work_logs_directory callbacks.
1993          - Add new work_item_log_path callback so that WorkQueue doesn't need to know about patches!
1994         * Scripts/modules/workqueue_unittest.py:
1995          - Update unit tests to reflect new callbacks.
1996
1997 2009-12-15  Adam Barth  <abarth@webkit.org>
1998
1999         Reviewed by Eric Seidel.
2000
2001         scm_unittest.py is too slow
2002         https://bugs.webkit.org/show_bug.cgi?id=31818
2003
2004         Now we don't run the SCM unit tests unless we get the --all flag on the
2005         command line.  Eric and I were commenting out this test because it was
2006         too painful to run.
2007
2008         * Scripts/run-webkit-unittests:
2009
2010 2009-12-14  Adam Barth  <abarth@webkit.org>
2011
2012         Unreviewed.  Fix failing unittest.
2013
2014         * Scripts/modules/bugzilla_unittest.py:
2015
2016 2009-12-14  Eric Seidel  <eric@webkit.org>
2017
2018         Reviewed by Adam Barth.
2019
2020         Move Credential handling out into a separate module
2021         https://bugs.webkit.org/show_bug.cgi?id=32531
2022
2023         * Scripts/modules/bugzilla.py:
2024         * Scripts/modules/credentials.py: Added.
2025         * Scripts/modules/credentials_unittest.py: Added.
2026         * Scripts/run-webkit-unittests:
2027
2028 2009-12-14  Adam Barth  <abarth@webkit.org>
2029
2030         Reviewed by Eric Seidel.
2031
2032         Kill _create_step_sequence
2033         https://bugs.webkit.org/show_bug.cgi?id=32539
2034
2035         It's cleaner to represent not having these sequences as an empty
2036         sequence instead of None.
2037
2038         * Scripts/modules/commands/download.py:
2039         * Scripts/modules/stepsequence.py:
2040
2041 2009-12-14  Adam Barth  <abarth@webkit.org>
2042
2043         Unreviewed.  Address reviewer comments from an earlier patch.  I didn't
2044         do this earlier because I was worried about conflicts in dependent
2045         patches.
2046
2047         * Scripts/modules/commands/download.py:
2048
2049 2009-12-14  Adam Barth  <abarth@webkit.org>
2050
2051         Reviewed by Eric Seidel.
2052
2053         [bzt] Make download commands declarative
2054         https://bugs.webkit.org/show_bug.cgi?id=32469
2055
2056         This patch "properly" factors most of the download commands.  These
2057         commands are now largely declarative, which is the final step of this
2058         grand refactoring.
2059
2060         * Scripts/modules/buildsteps.py:
2061         * Scripts/modules/commands/download.py:
2062
2063 2009-12-14  Adam Barth  <abarth@webkit.org>
2064
2065         Reviewed by Eric Seidel.
2066
2067         [bzt] Add AbstractPatchSequencingCommand to remove redundant code
2068         https://bugs.webkit.org/show_bug.cgi?id=32468
2069
2070         Redundant code is bad.  This patch moves us towards more declarative
2071         commands.
2072
2073         * Scripts/modules/commands/download.py:
2074
2075 2009-12-14  Adam Barth  <abarth@webkit.org>
2076
2077         Reviewed by Eric Seidel.
2078
2079         [bzt] Kill WebKitApplyingScripts
2080         https://bugs.webkit.org/show_bug.cgi?id=32467
2081
2082         Ah!  I've been wanting to do this for a long time.  This patch brings
2083         the applying commands into the patch processing fold.
2084
2085         * Scripts/bugzilla-tool:
2086         * Scripts/modules/buildsteps.py:
2087         * Scripts/modules/commands/download.py:
2088         * Scripts/modules/commands/download_unittest.py:
2089         * Scripts/modules/mock_bugzillatool.py:
2090
2091 2009-12-14  Adam Barth  <abarth@webkit.org>
2092
2093         Reviewed by Eric Seidel.
2094
2095         [bzt] Convert rollout to StepSequence
2096         https://bugs.webkit.org/show_bug.cgi?id=32406
2097
2098         * Scripts/modules/buildsteps.py:
2099         * Scripts/modules/commands/download.py:
2100         * Scripts/modules/commands/download_unittest.py:
2101         * Scripts/modules/mock_bugzillatool.py:
2102
2103 2009-12-14  Adam Barth  <abarth@webkit.org>
2104
2105         Reviewed by Eric Seidel.
2106
2107         [bzt] Kill LandingSequence
2108         https://bugs.webkit.org/show_bug.cgi?id=32464
2109
2110         Removes LandingSequence in favor of StepSequence.  This required
2111         changing the Step API slightly to carry a general notion of state
2112         instead of carrying patches specifically.
2113
2114         * Scripts/modules/buildsteps.py:
2115         * Scripts/modules/commands/download.py:
2116         * Scripts/modules/commands/queues.py:
2117         * Scripts/modules/landingsequence.py: Removed.
2118         * Scripts/modules/stepsequence.py:
2119
2120 2009-12-14  Robert Hogan  <robert@roberthogan.net>
2121
2122         Reviewed by Eric Seidel.
2123
2124         [Qt] Fix https://bugs.webkit.org/show_bug.cgi?id=32437
2125         
2126         Amend the behaviour of DRT::notifyDone to dump only when
2127         the page has finished loading.
2128         
2129         This fix permits removal of the following tests from the Qt skipped list:
2130         fast/forms/textarea-linewrap-dynamic.html
2131         fast/forms/textarea-setvalue-submit.html
2132         fast/forms/textarea-hard-linewrap-empty.html
2133         fast/forms/submit-to-url-fragment.html
2134         http/tests/misc/percent-sign-in-form-field-name.html
2135         http/tests/security/escape-form-data-field-names.html
2136         
2137         However it also requires the following two to be added to the skipped list:
2138         
2139         http/tests/xmlhttprequest/access-control-basic-denied-preflight-cache.html
2140         svg/custom/use-instanceRoot-as-event-target.xhtml
2141         
2142         It appears the behaviour of notifyDone was masking problems with these two
2143         tests.
2144
2145         * DumpRenderTree/qt/DumpRenderTree.cpp:
2146         (WebCore::DumpRenderTree::DumpRenderTree):
2147         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2148         (LayoutTestController::reset):
2149         (LayoutTestController::processWork):
2150         (LayoutTestController::maybeDump):
2151         (LayoutTestController::notifyDone):
2152         (LayoutTestController::provisionalLoad):
2153         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2154         (LayoutTestController::resetLoadFinished):
2155
2156 2009-12-14  Simon Hausmann  <hausmann@webkit.org>
2157
2158         Reviewed by Holger Freyther.
2159
2160         [Qt] Add support for keyboard modifiers to Qt DRT's EventSender for touch events
2161
2162         https://bugs.webkit.org/show_bug.cgi?id=32482
2163
2164         * DumpRenderTree/qt/EventSenderQt.cpp:
2165         (EventSender::setTouchModifier):
2166         (EventSender::clearTouchPoints):
2167         (EventSender::sendTouchEvent):
2168         * DumpRenderTree/qt/EventSenderQt.h:
2169
2170 2009-12-13  Maciej Stachowiak  <mjs@apple.com>
2171
2172         Reviewed by Gavin Barraclaugh.
2173
2174         Fix minor problem in sunspider-compare-results which left it broken.
2175
2176         * Scripts/sunspider-compare-results: Declare $parseonly
2177
2178 2009-12-12  Maciej Stachowiak  <mjs@apple.com>
2179
2180         Reviewed by Oliver Hunt.
2181
2182         Give command-line sunspider the ability to handle multiple suites and versions
2183         https://bugs.webkit.org/show_bug.cgi?id=32477
2184
2185         * Scripts/run-sunspider: Updated for changes to command-line parameters.
2186         * Scripts/sunspider-compare-results: ditto
2187
2188 2009-12-12  Maciej Stachowiak  <mjs@apple.com>
2189
2190         Not reviewed, fixing previous comment.
2191
2192         Remove accidental change to sunspider-compare-results
2193
2194         * Scripts/sunspider-compare-results:
2195
2196 2009-12-11  Yael Aharon  <yael.aharon@nokia.com>
2197
2198         Unreviewed build fix for Qt versions < 4.6. 
2199         Guard every slot individually with #ifdef.
2200
2201         * DumpRenderTree/qt/EventSenderQt.cpp:
2202         (EventSender::addTouchPoint):
2203         (EventSender::updateTouchPoint):
2204         (EventSender::touchStart):
2205         (EventSender::touchMove):
2206         (EventSender::touchEnd):
2207         (EventSender::clearTouchPoints):
2208         (EventSender::releaseTouchPoint):
2209         (EventSender::sendTouchEvent):
2210         * DumpRenderTree/qt/EventSenderQt.h:
2211
2212 2009-12-11  Eric Seidel  <eric@webkit.org>
2213
2214         Reviewed by Adam Barth.
2215
2216         CommandsTest.assert_execute_outputs doesn't check stderr
2217         https://bugs.webkit.org/show_bug.cgi?id=32352
2218
2219         Fix assert_execute_outputs to check stderr
2220         and then fix all the unit tests which needed to
2221         pass stderr output.
2222
2223         * Scripts/modules/commands/commandtest.py:
2224         * Scripts/modules/commands/download_unittest.py:
2225         * Scripts/modules/commands/upload_unittest.py:
2226
2227 2009-12-11  Adam Barth  <abarth@webkit.org>
2228
2229         Reviewed by Eric Seidel.
2230
2231         [check-webkit-style] False positive for tst_QWebFrame
2232         https://bugs.webkit.org/show_bug.cgi?id=32436
2233
2234         Add an exception for function names that start with "tst_".  These are
2235         used by the Qt unit testing framework.
2236
2237         * Scripts/modules/cpp_style.py:
2238         * Scripts/modules/cpp_style_unittest.py:
2239
2240 2009-12-11  Simon Hausmann  <hausmann@webkit.org>, Kim Grönholm  <kim.gronholm@nomovok.com>
2241
2242         Reviewed by Antti Koivisto.
2243
2244         Added support for creating synthetic touch events with EventSender
2245         in Qt's DumpRenderTree.
2246
2247         https://bugs.webkit.org/show_bug.cgi?id=32114
2248
2249         * DumpRenderTree/qt/EventSenderQt.cpp:
2250         (EventSender::addTouchPoint):
2251         (EventSender::updateTouchPoint):
2252         (EventSender::touchStart):
2253         (EventSender::touchMove):
2254         (EventSender::touchEnd):
2255         (EventSender::clearTouchPoints):
2256         (EventSender::releaseTouchPoint):
2257         (EventSender::sendTouchEvent):
2258         * DumpRenderTree/qt/EventSenderQt.h:
2259
2260 2009-12-11  Benjamin Poulain  <benjamin.poulain@nokia.com>
2261
2262         Reviewed by Darin Adler.
2263
2264         The values of RuntimeArray are not enumerable
2265         https://bugs.webkit.org/show_bug.cgi?id=29005
2266
2267         * DumpRenderTree/mac/ObjCController.m:
2268         (+[ObjCController isSelectorExcludedFromWebScript:]):
2269         (+[ObjCController webScriptNameForSelector:]):
2270         (-[ObjCController arrayOfString]):
2271
2272 2009-12-10  Eric Seidel  <eric@webkit.org>
2273
2274         No review, just updating unit tests to match recent checkins.
2275
2276         * Scripts/modules/mock_bugzillatool.py:
2277          - Add missing red_core_builders_names method causing exception.
2278         * Scripts/modules/workqueue_unittest.py:
2279          - processutils is dead, use executive.py instead.
2280
2281 2009-12-10  Eric Seidel  <eric@webkit.org>
2282
2283         Reviewed by Adam Barth.
2284
2285         Move run_command onto Executive to make code which uses run_command testable
2286         https://bugs.webkit.org/show_bug.cgi?id=32396
2287
2288         * Scripts/modules/executive.py:
2289          - Move run_command and error handlers onto Executive.
2290         * Scripts/modules/scm.py:
2291         * Scripts/modules/scm_unittest.py:
2292
2293 2009-12-09  Eric Seidel  <eric@webkit.org>
2294
2295         Reviewed by Adam Barth.
2296
2297         bugzilla-tool needs a command to list patches needing cq+
2298         https://bugs.webkit.org/show_bug.cgi?id=32351
2299
2300         * Scripts/modules/bugzilla.py:
2301          - Parse attacher_email from attachment xml.
2302         * Scripts/modules/bugzilla_unittest.py:
2303          - Test new attacher_email parsing.
2304         * Scripts/modules/commands/queries.py:
2305          - Add PatchesToCommitQueue
2306         * Scripts/modules/commands/queries_unittest.py:
2307          - Tests for PatchesToCommitQueue
2308         * Scripts/modules/mock_bugzillatool.py:
2309          - Add necessary mock methods for running PatchesToCommitQueue
2310
2311 2009-12-10  Adam Barth  <abarth@webkit.org>
2312
2313         Unreviewed.  Turns out every StepSequence command needs a --quiet
2314         option.
2315
2316         * Scripts/modules/stepsequence.py:
2317
2318 2009-12-10  Eric Z. Ayers  <zundel@google.com>
2319
2320         Reviewed by Pavel Feldman.
2321
2322         Implements displayWebView() to force an invalidation and repaint.
2323         This fixes a problem running the timeline-paint.html unit test.
2324
2325         https://bugs.webkit.org/show_bug.cgi?id=31729
2326
2327         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2328         (displayWebView):
2329
2330 2009-12-10  Adam Barth  <abarth@webkit.org>
2331
2332         Reviewed by Eric Seidel.
2333
2334         [bzt] Convert more commands to StepSequences
2335         https://bugs.webkit.org/show_bug.cgi?id=32362
2336
2337         We should eventually convert all the commands, but I'm starting with
2338         the easy ones.
2339
2340         * Scripts/modules/commands/download.py:
2341
2342 2009-12-10  Xan Lopez  <xlopez@igalia.com>
2343
2344         Reviewed by Jan Alonzo.
2345
2346         [GTK] editing/selection/shrink-selection-after-shift-pagedown.html failing
2347         https://bugs.webkit.org/show_bug.cgi?id=31103
2348
2349         Give focus to the webviews when we create them, since some tests expect this.
2350
2351         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2352         (main):
2353
2354 2009-12-10  Eric Seidel  <eric@webkit.org>
2355
2356         Reviewed by Adam Barth.
2357
2358         bugzilla-tool "builders are red" error should tell you which builders
2359         https://bugs.webkit.org/show_bug.cgi?id=32211
2360
2361         * Scripts/modules/buildsteps.py:
2362
2363 2009-12-09  Marwan Al Jubeh  <marwan.aljubeh@gmail.com>
2364
2365         Reviewed by Adam Roben.
2366
2367         Fixes: https://bugs.webkit.org/show_bug.cgi?id=31228
2368         Set the WebKitOutputDir, WebKitLibrariesDir and Cygwin environment variables automatically
2369         in Windows as part of running update_webkit.
2370
2371         * Scripts/update-webkit:
2372          - Run setupAppleWinEnv() on Apple's Windows port.
2373         * Scripts/webkitdirs.pm:
2374          - Added functions that return the source directory, libraries directory and default build directory on Windows.
2375          - Added isWindowsNT() which tests if the current Windows version is from the Windows NT family.
2376          - Implemented setupAppleWinEnv() which sets the environment variables WebKitOutputDir, WebKitLibrariesDir
2377            and Cygwin to their desired values.
2378
2379 2009-12-09  Adam Barth  <abarth@webkit.org>
2380
2381         Reviewed by Eric Seidel.
2382
2383         exception thrown when running apply-patches
2384         https://bugs.webkit.org/show_bug.cgi?id=32344
2385
2386         The update step now takes a port option.  Once we finish the Steps
2387         refactoring, we won't have to worry about this kind of bug again.
2388
2389         * Scripts/modules/commands/download.py:
2390
2391 2009-12-09  Adam Barth  <abarth@webkit.org>
2392
2393         Unreviewed.  Fix ScriptError includes.  I don't understand why these
2394         didn't throw during unit testing...
2395
2396         * Scripts/modules/commands/download.py:
2397         * Scripts/modules/logging_unittest.py:
2398         * Scripts/modules/workqueue.py:
2399
2400 2009-12-09  Adam Barth  <abarth@webkit.org>
2401
2402         Reviewed by Eric Seidel.
2403
2404         [bzt] Remove unused PatchCollection class
2405         https://bugs.webkit.org/show_bug.cgi?id=32312
2406
2407         It's dead code.
2408
2409         * Scripts/modules/patchcollection.py:
2410         * Scripts/modules/patchcollection_unittest.py: Removed.
2411
2412 2009-12-09  Adam Barth  <abarth@webkit.org>
2413
2414         Unreviewed "build" fix.  CheckStyle needs a --no-upate option.
2415
2416         * Scripts/modules/commands/download.py:
2417
2418 2009-12-09  Adam Barth  <abarth@webkit.org>
2419
2420         Reviewed by Eric Seidel.
2421
2422         [bzt] Convert Build to use Sequence
2423         https://bugs.webkit.org/show_bug.cgi?id=32310
2424
2425         So much prettier.
2426
2427         * Scripts/modules/buildsteps.py:
2428         * Scripts/modules/commands/download.py:
2429         * Scripts/modules/landingsequence.py:
2430         * Scripts/modules/stepsequence.py: Added.
2431
2432 2009-12-09  Adam Barth  <abarth@webkit.org>
2433
2434         Add missing file.
2435
2436         * Scripts/modules/executive.py: Added.
2437
2438 2009-12-09  Adam Barth  <abarth@webkit.org>
2439
2440         Unreviewed "build" fix.
2441
2442         * Scripts/modules/landingsequence.py:
2443
2444 2009-12-09  Adam Barth  <abarth@webkit.org>
2445
2446         Reviewed by Eric Seidel.
2447
2448         [bzt] Implement abstract Steps
2449         https://bugs.webkit.org/show_bug.cgi?id=32212
2450
2451         This is a fairly disruptive change that refactors how we build
2452         commands.  Instead of using a landing sequence, we can now assemble a
2453         sequence of steps directly.  We still use the landing sequence in the
2454         interim, but this will be removed soon.
2455
2456         * Scripts/bugzilla-tool:
2457         * Scripts/modules/buildsteps.py:
2458         * Scripts/modules/commands/download.py:
2459         * Scripts/modules/commands/early_warning_system.py:
2460         * Scripts/modules/commands/queues.py:
2461         * Scripts/modules/commands/queues_unittest.py:
2462         * Scripts/modules/landingsequence.py:
2463         * Scripts/modules/mock_bugzillatool.py:
2464         * Scripts/modules/processutils.py: Removed.
2465         * Scripts/modules/scm.py:
2466         * Scripts/modules/scm_unittest.py:
2467         * Scripts/modules/webkitport.py:
2468
2469 2009-12-08  Eric Seidel  <eric@webkit.org>
2470
2471         Reviewed by Adam Barth.
2472
2473         run_command and ScriptError should move into processutils.py
2474         https://bugs.webkit.org/show_bug.cgi?id=32305
2475
2476         Turns out there are a zillion callers to run_command.
2477
2478         * Scripts/modules/commands/download.py:
2479         * Scripts/modules/commands/early_warning_system.py:
2480         * Scripts/modules/commands/queues.py:
2481         * Scripts/modules/landingsequence.py:
2482         * Scripts/modules/logging_unittest.py:
2483         * Scripts/modules/processutils.py:
2484         * Scripts/modules/scm.py:
2485         * Scripts/modules/scm_unittest.py:
2486         * Scripts/modules/workqueue.py:
2487         * Scripts/modules/workqueue_unittest.py:
2488
2489 2009-12-08  Kevin Watters  <kevinwatters@gmail.com>
2490
2491         Reviewed by Kevin Ollivier.
2492
2493         [wx] Mac plugins support.
2494         
2495         https://bugs.webkit.org/show_bug.cgi?id=32236
2496
2497         * wx/browser/wscript:
2498
2499 2009-12-08  David Levin  <levin@chromium.org>
2500
2501         Reviewed by Adam Barth.
2502
2503         [check-webkit-style] False positive for DEFINE_OPCODE(op_jtrue) {
2504         https://bugs.webkit.org/show_bug.cgi?id=32193
2505
2506         * Scripts/modules/cpp_style.py: For the function { rule, if there is space
2507           at the beginning of line, ignore lines which then have a macro.
2508         * Scripts/modules/cpp_style_unittest.py: Add tests to verify the
2509           new behavior.
2510
2511 2009-12-08  Dmitry Titov  <dimich@chromium.org>
2512
2513         Rubber-stamped by David Levin.
2514
2515         Revert and reopen "Add asserts to RefCounted to make sure ref/deref happens on the right thread."
2516         It may have caused massive increase of reported leaks on the bots.
2517         https://bugs.webkit.org/show_bug.cgi?id=31639
2518
2519         * DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Removed.
2520
2521 2009-12-08  Dmitry Titov  <dimich@chromium.org>
2522
2523         Reviewed by Darin Adler.
2524
2525         Add asserts to RefCounted to make sure ref/deref happens on the right thread.
2526         https://bugs.webkit.org/show_bug.cgi?id=31639
2527
2528         * DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Added.
2529
2530 2009-12-08  David Levin  <levin@chromium.org>
2531
2532         Reviewed by Adam Barth.
2533
2534         [check-webkit-style] False positive for camel case of JSC op codes
2535         https://bugs.webkit.org/show_bug.cgi?id=32192
2536
2537         * Scripts/modules/cpp_style.py: Added an exception for the JSC op
2538           code functions and const_iterator as well since I noticed a false
2539           positive there when testing the fix.
2540         * Scripts/modules/cpp_style_unittest.py: Added tests for these
2541           changes.
2542
2543 2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>
2544
2545         Rubber-stamped by Maciej Stachowiak.
2546
2547         Turn on (SVG) Filters for Win.
2548         https://bugs.webkit.org/show_bug.cgi?id=32224
2549
2550         * Scripts/webkitdirs.pm:
2551
2552 2009-12-08  Nikolas Zimmermann  <nzimmermann@rim.com>
2553
2554         Rubber-stamped by Maciej Stachowiak.
2555
2556         Turn on (SVG) Filters for Gtk.
2557         https://bugs.webkit.org/show_bug.cgi?id=32224
2558
2559         * Scripts/build-webkit:
2560
2561 2009-12-07  Shinichiro Hamaji  <hamaji@chromium.org>
2562
2563         Reviewed by David Levin.
2564
2565         [check-webkit-style] S_OK is a fine identifier
2566         https://bugs.webkit.org/show_bug.cgi?id=32225
2567
2568         * Scripts/modules/cpp_style.py:
2569         * Scripts/modules/cpp_style_unittest.py:
2570
2571 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
2572
2573         Rubber-stamped by Maciej Stachowiak.
2574
2575         Turn on (SVG) Filters for Qt.
2576         https://bugs.webkit.org/show_bug.cgi?id=32224
2577
2578         * Scripts/build-webkit:
2579
2580 2009-12-07  Yuzo Fujishima  <yuzo@google.com>
2581
2582         Reviewed by Alexey Proskuryakov.
2583
2584         Make run-webkit-websocketserver log to stderr rather than to a file.
2585         https://bugs.webkit.org/show_bug.cgi?id=32234
2586
2587         * Scripts/run-webkit-websocketserver:
2588
2589 2009-12-07  Dmitry Titov  <dimich@chromium.org>
2590
2591         Rubber-stamped by Darin Adler.
2592
2593         Remove ENABLE_SHARED_SCRIPT flags
2594         https://bugs.webkit.org/show_bug.cgi?id=32245
2595         This patch was obtained by "git revert" command and then un-reverting of ChangeLog files.
2596
2597         * Scripts/build-webkit:
2598
2599 2009-12-07  Simon Fraser  <simon.fraser@apple.com>
2600
2601         Reviewed by Darin Adler.
2602
2603         <rdar://problem/7450481> One compositing test keeps DRT in "compositing mode", breaks repaint tests
2604
2605         The counter that WebView used to keep track of the number of enclosed WebHTMLViews using
2606         accelerated compositing was hard to manage, and maintained incorrectly in a number of cases.
2607         This caused one compositing test make DumpRenderTree think that all subsequent tests
2608         were compositing too.
2609
2610         Replace this counter with notifications, which are only fired if a client (DRT) requests them. The
2611         notification informs the client that a WebHTMLView entered compositing mode (or an already-
2612         compositing WebHTML was added); it does not say when a view becomes uncomposited, or all
2613         compositing subviews were removed, since this is tricky to get right.
2614         
2615         DumpRenderTreeWindow listens for this notification, and uses it to turn on window
2616         autodisplay, which is necessary to kick-start Core Animation rendering and animations.
2617         We ensure that window autodisplay is turned off before every test.
2618
2619         * DumpRenderTree/mac/DumpRenderTree.mm:
2620         (createWebViewAndOffscreenWindow):
2621         (resetWebViewToConsistentStateBeforeTesting):
2622         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2623         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2624         (-[DumpRenderTreeWindow close]):
2625         (-[DumpRenderTreeWindow startListeningForAcceleratedCompositingChanges]):
2626         (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
2627
2628 2009-12-07  Nikolas Zimmermann  <nzimmermann@rim.com>
2629
2630         Reviewed by Holger Hans Peter Freyther.
2631
2632         Turn on (SVG) Filters support, by default.
2633         https://bugs.webkit.org/show_bug.cgi?id=32224
2634
2635         For now only enable FILTERS build flag on WebKit/mac. Other platforms will follow soon.
2636
2637         * Scripts/build-webkit:
2638
2639 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
2640
2641         Reviewed by Darin Fisher.
2642
2643         Chromium buildbots are not red when they fail
2644         https://bugs.webkit.org/show_bug.cgi?id=32235
2645
2646         * Scripts/build-webkit:
2647
2648 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
2649
2650         Reviewed by Darin Fisher.
2651
2652         Typo in chromium linux builder
2653         https://bugs.webkit.org/show_bug.cgi?id=32238
2654
2655         * Scripts/webkitdirs.pm:
2656
2657 2009-12-07  Yaar Schnitman  <yaar@chromium.org>
2658
2659         Reviewed by Darin Fisher.
2660
2661         fixes to build-webkit --chromium
2662         https://bugs.webkit.org/show_bug.cgi?id=32179
2663
2664         * Scripts/webkitdirs.pm:
2665
2666 2009-12-07  Eric Seidel  <eric@webkit.org>
2667
2668         No review, just adding two recently approved committers.
2669
2670         * Scripts/modules/committers.py:
2671
2672 2009-12-07  Alexey Proskuryakov  <ap@apple.com>
2673
2674         * Scripts/run-webkit-websocketserver: Added property svn:executable.
2675
2676 2009-12-07  Yuzo Fujishima  <yuzo@google.com>
2677
2678         Reviewed by Alexey Proskuryakov.
2679
2680         Add run-webkit-websocketserver
2681
2682         https://bugs.webkit.org/show_bug.cgi?id=31390
2683
2684         * Scripts/run-webkit-websocketserver: Added.
2685
2686 2009-12-07  Steve Falkenburg  <sfalken@apple.com>
2687
2688         Build fix. Be flexible about which version of ICU is used on Windows.
2689
2690         * DumpRenderTree/win/DumpRenderTree.vcproj: Add optional xcopy commands to copy ICU 4.2.
2691
2692 2009-12-07  Dirk Schulze  <krit@webkit.org>
2693
2694         Not reviewed, adding myself to the reviewers list.
2695
2696         * Scripts/modules/committers.py:
2697
2698 2009-12-06  Eric Seidel  <eric@webkit.org>
2699
2700         Reviewed by Adam Barth.
2701
2702         Add an API for uploading results files to StatusBot
2703         https://bugs.webkit.org/show_bug.cgi?id=32210
2704
2705         Add Content-Type: plain/text which was forgotten
2706         from the previous commit when I landed with land-patches
2707         instead of land-diff.
2708
2709         * QueueStatusServer/queue_status.py:
2710
2711 2009-12-06  Eric Seidel  <eric@webkit.org>
2712
2713         Reviewed by Adam Barth.
2714
2715         Status Server needs a way to handle uploaded results
2716         https://bugs.webkit.org/show_bug.cgi?id=32209
2717
2718         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
2719         * QueueStatusServer/update_status.html: Add file upload.
2720
2721 2009-12-06  Eric Seidel  <eric@webkit.org>
2722
2723         Reviewed by Adam Barth.
2724
2725         Add an API for uploading results files to StatusBot
2726         https://bugs.webkit.org/show_bug.cgi?id=32210
2727
2728         * Scripts/modules/statusbot.py:
2729
2730 2009-12-06  Eric Seidel  <eric@webkit.org>
2731
2732         Reviewed by Adam Barth.
2733
2734         Status Server needs a way to handle uploaded results
2735         https://bugs.webkit.org/show_bug.cgi?id=32209
2736
2737         * QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
2738         * QueueStatusServer/update_status.html: Add file upload.
2739
2740 2009-12-06  Adam Barth  <abarth@webkit.org>
2741
2742         Reviewed by Eric Seidel.
2743
2744         [bzt] BuildAttachment should not check the builders
2745         https://bugs.webkit.org/show_bug.cgi?id=32207
2746
2747         This is code that got copied here by accident when the class was created.
2748
2749         * Scripts/modules/commands/download.py:
2750
2751 2009-12-06  Adam Barth  <abarth@webkit.org>
2752
2753         Reviewed by Eric Seidel.
2754
2755         [bzt] Make LandingSequence.update aware of ports
2756         https://bugs.webkit.org/show_bug.cgi?id=32208
2757
2758         This is required to make build work on the Chromium port because
2759         Chromium has a custom update-webkit.
2760
2761         * Scripts/modules/landingsequence.py:
2762
2763 2009-12-06  Adam Barth  <abarth@webkit.org>
2764
2765         Reviewed by Eric Seidel.
2766
2767         Add early warning system commands to bugzilla-tool.
2768
2769         * Scripts/bugzilla-tool:
2770         * Scripts/modules/landingsequence.py:
2771         * Scripts/modules/webkitport.py:
2772
2773 2009-12-06  Adam Barth  <abarth@webkit.org>
2774
2775         Reviewed by Eric Seidel.
2776
2777         [bzt] Implement Qt EarlyWarningSystem and Chromium EarlyWarningSystem
2778         https://bugs.webkit.org/show_bug.cgi?id=32205
2779
2780         * Scripts/modules/commands/early_warning_system.py: Added.
2781         * Scripts/modules/commands/queues.py:
2782
2783 2009-12-06  Dan Bernstein  <mitz@apple.com>
2784
2785         Reviewed by Adele Peterson.
2786
2787         REGRESSION (r51728): update-webkit fails when the current directory is
2788         not inside a Subversion working copy
2789         https://bugs.webkit.org/show_bug.cgi?id=32204
2790
2791         * Scripts/update-webkit: Invoke isSVN() in the correct working
2792         directory.
2793
2794 2009-12-06  Adam Barth  <abarth@webkit.org>
2795
2796         Reviewed by Eric Seidel.
2797
2798         [bzt] Rename AbstractTryQueue to AbstractReviewQueue
2799         https://bugs.webkit.org/show_bug.cgi?id=32202
2800
2801         * Scripts/modules/commands/queues.py:
2802
2803 2009-12-05  Adam Barth  <abarth@webkit.org>
2804
2805         Reviewed by Eric Seidel.
2806
2807         [bzt] Implement ChromiumPort
2808         https://bugs.webkit.org/show_bug.cgi?id=32182
2809
2810         * Scripts/modules/webkitport.py:
2811         * Scripts/modules/webkitport_unittest.py:
2812
2813 2009-12-05  Adam Barth  <abarth@webkit.org>
2814
2815         Reviewed by Eric Seidel.
2816
2817         Move update-webkit into BuildSteps
2818         https://bugs.webkit.org/show_bug.cgi?id=32181
2819
2820         We need to move update-webkit out of SCM.py because SCM isn't supposed to know
2821         that WebKit exists.  The proper place for the knowledge of the existence of
2822         update-webkit is in WebKitPort because some ports have specialized update
2823         scripts (analogous to build-webkit).
2824
2825         * Scripts/modules/buildsteps.py:
2826         * Scripts/modules/commands/download.py:
2827         * Scripts/modules/landingsequence.py:
2828         * Scripts/modules/scm.py:
2829         * Scripts/modules/webkitport.py:
2830
2831 2009-12-05  Adam Barth  <abarth@webkit.org>
2832
2833         Reviewed by Eric Seidel.
2834
2835         update-webkit should call git svn rebase and resolve-ChangeLogs -f
2836         https://bugs.webkit.org/show_bug.cgi?id=27162
2837
2838         Teach update-webkit about Git.  I didn't add the call to
2839         resolve-ChangeLogs -f because sometimes that script goes bananas.  We
2840         can iterate from here, however.
2841
2842         * Scripts/update-webkit:
2843
2844 2009-12-04  Yael Aharon  <yael.aharon@nokia.com>
2845
2846         Unreviewed build fix.
2847
2848         [Qt] build fix after r51634 removed unused QBoxLayout include which included limits.h.
2849
2850         * DumpRenderTree/qt/DumpRenderTree.cpp:
2851
2852 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2853
2854         Reviewed by Adam Treat.
2855
2856         Add some missing methods for showing and hiding the
2857         Web Inspector.
2858
2859         * DumpRenderTree/qt/DumpRenderTree.cpp:
2860         (WebCore::WebPage::WebPage):
2861         (WebCore::WebPage::~WebPage):
2862         (WebCore::WebPage::webInspector):
2863         * DumpRenderTree/qt/DumpRenderTree.h:
2864         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2865         (LayoutTestController::showWebInspector):
2866         (LayoutTestController::hideWebInspector):
2867         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2868
2869 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2870
2871         Reviewed by Adam Treat.
2872
2873         Implement the setAllowUniversalAccessFromFileURLs method
2874         for the Qt LayoutTestController.
2875
2876         * DumpRenderTree/qt/DumpRenderTree.cpp:
2877         (WebCore::WebPage::resetSettings):
2878         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2879         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
2880         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2881
2882 2009-12-04  Chris Fleizach  <cfleizach@apple.com>
2883
2884         Reviewed by Darin Adler.
2885
2886         REGRESSION: AX: buttons now extremely repetitive
2887         https://bugs.webkit.org/show_bug.cgi?id=32164
2888
2889         * DumpRenderTree/AccessibilityUIElement.cpp:
2890         (isAttributeSupportedCallback):
2891         (AccessibilityUIElement::getJSClass):
2892         * DumpRenderTree/AccessibilityUIElement.h:
2893         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2894         (AccessibilityUIElement::isAttributeSupported):
2895         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2896         (AccessibilityUIElement::isAttributeSupported):
2897         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2898         (AccessibilityUIElement::isAttributeSupported):
2899
2900 2009-12-03  Shinichiro Hamaji  <hamaji@chromium.org>
2901
2902         Reviewed by David Levin.
2903
2904         check-webkit-style should check for camelCase variable names
2905         https://bugs.webkit.org/show_bug.cgi?id=32051
2906
2907         * Scripts/modules/cpp_style.py:
2908         * Scripts/modules/cpp_style_unittest.py:
2909
2910 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
2911
2912         Reviewed by Eric Seidel.
2913
2914         AX: VO just says "term" on many web sites
2915         https://bugs.webkit.org/show_bug.cgi?id=32139
2916
2917         * DumpRenderTree/AccessibilityUIElement.cpp:
2918         (getRoleDescriptionCallback):
2919         (AccessibilityUIElement::getJSClass):
2920         * DumpRenderTree/AccessibilityUIElement.h:
2921         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2922         (AccessibilityUIElement::roleDescription):
2923         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2924         (AccessibilityUIElement::roleDescription):
2925         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2926         (AccessibilityUIElement::roleDescription):
2927
2928 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
2929
2930         Reviewed by Beth Dakin.
2931
2932         Implement WAI-ARIA scrollbar role and related property aria-orientation
2933         https://bugs.webkit.org/show_bug.cgi?id=32126
2934
2935         * DumpRenderTree/AccessibilityUIElement.cpp:
2936         (getOrientationCallback):
2937         (AccessibilityUIElement::getJSClass):
2938         * DumpRenderTree/AccessibilityUIElement.h:
2939         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2940         (AccessibilityUIElement::orientation):
2941         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2942         (AccessibilityUIElement::orientation):
2943         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2944         (AccessibilityUIElement::orientation):
2945
2946 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
2947
2948         Reviewed by Adam Roben.
2949
2950         Minor correction to r51663.
2951
2952         * DumpRenderTree/win/DumpRenderTree.cpp:
2953         (addQTDirToPATH):
2954             GetEnvironmentVariable -> GetEnvironmentVariableW.
2955
2956 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
2957
2958         Reviewed by Adam Roben.
2959
2960         ~96 regression tests fail when using QuickTime 7.6 (they pass with QuickTime 7.3)
2961         https://bugs.webkit.org/show_bug.cgi?id=30256
2962
2963         Add the QuickTime dll directory to the PATH environment variable so
2964         inialization can succeed.
2965
2966         * DumpRenderTree/win/DumpRenderTree.cpp:
2967         (addQTDirToPATH):
2968         (initialize):
2969
2970 2009-12-03  Shu Chang  <Chang.Shu@nokia.com>
2971
2972         Reviewed by Kenneth Rohde Christiansen.
2973
2974         [Qt] After revision 32643, sender() is of type QWebPage instead of QWebFrame.
2975
2976         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2977         (LayoutTestController::maybeDump):
2978
2979 2009-12-03  Yuzo Fujishima  <yuzo@google.com>
2980
2981         Reviewed by Eric Seidel.
2982
2983         Update pywebsocket to 0.4.3
2984         This version logs friendlier and higher-level messages in WARN level, which is used for LayoutTests.
2985         Stack trace is logged now in INFO level.
2986         https://bugs.webkit.org/show_bug.cgi?id=32097
2987
2988         * pywebsocket/mod_pywebsocket/dispatch.py:
2989         * pywebsocket/mod_pywebsocket/msgutil.py:
2990         * pywebsocket/mod_pywebsocket/standalone.py:
2991         * pywebsocket/mod_pywebsocket/util.py:
2992         * pywebsocket/setup.py:
2993         * pywebsocket/test/test_dispatch.py:
2994         * pywebsocket/test/test_util.py:
2995
2996 2009-12-03  Sam Weinig  <sam@webkit.org>
2997
2998         Reviewed by Gavin Barraclough.
2999
3000         Fix JSClassRef leak.
3001
3002         * DumpRenderTree/AccessibilityController.cpp:
3003         (AccessibilityController::makeWindowObject):
3004         * DumpRenderTree/GCController.cpp:
3005         (GCController::makeWindowObject):
3006         * DumpRenderTree/LayoutTestController.cpp:
3007         (LayoutTestController::makeWindowObject):
3008
3009 2009-12-03  Brady Eidson  <beidson@apple.com>
3010
3011         Reviewed by Sam Weinig.
3012
3013         <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
3014
3015         Keep DRT-win building...
3016
3017         * DumpRenderTree/win/FrameLoadDelegate.h:
3018         (FrameLoadDelegate::didPushStateWithinPageForFrame):
3019         (FrameLoadDelegate::didReplaceStateWithinPageForFrame):
3020         (FrameLoadDelegate::didPopStateWithinPageForFrame):
3021
3022 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
3023
3024         Unreviewed build fix.
3025
3026         [Qt] ARM-Linux build fix after r51634 removed unused QBoxLayout include which included limits.h on ARM.
3027
3028         * DumpRenderTree/qt/DumpRenderTree.cpp:
3029
3030 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
3031
3032         Reviewed by Kenneth Rohde Christiansen.
3033
3034         [Qt] Refactor DRT to not crash on tests which open child windows from javascript.
3035         Prevent DRT from showing the main view if these childs get deleted.
3036         This fixes https://bugs.webkit.org/show_bug.cgi?id=31591.
3037
3038         * DumpRenderTree/qt/DumpRenderTree.cpp:
3039         (WebCore::WebPage::WebPage):
3040         (WebCore::DumpRenderTree::DumpRenderTree):
3041         (WebCore::DumpRenderTree::~DumpRenderTree):
3042         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3043         (WebCore::DumpRenderTree::open):
3044         (WebCore::DumpRenderTree::closeRemainingWindows):
3045         (WebCore::DumpRenderTree::createWindow):
3046         (WebCore::DumpRenderTree::windowCount):
3047         * DumpRenderTree/qt/DumpRenderTree.h:
3048
3049 2009-12-02  Eric Seidel  <eric@webkit.org>
3050
3051         Reviewed by Adam Barth.
3052
3053         REGRESSION(51595): commit-queue is throwing exceptions
3054         https://bugs.webkit.org/show_bug.cgi?id=32083
3055
3056         * Scripts/modules/commands/queues.py:
3057          - Don't use default value of [] as it ends up getting shared.
3058          - Make log_progress accept arrays of ints as well as strings.
3059          - Return an exit code from execute()
3060         * Scripts/modules/commands/queues_unittest.py: Added.
3061          - Test to make sure log_progress will accept ints.
3062          - Test to make sure run_bugzilla_tool will accept ints.
3063         * Scripts/modules/workqueue.py:
3064          - Print the stack trace on unexpected exceptions for easier debugging.
3065         * Scripts/run-webkit-unittests:
3066          - Add queues_unittest.
3067
3068         * Scripts/modules/commands/queues.py:
3069         * Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py.
3070         * Scripts/modules/mock_bugzillatool.py:
3071         * Scripts/modules/workqueue.py:
3072         * Scripts/run-webkit-unittests:
3073
3074 2009-12-02  David Levin  <levin@chromium.org>
3075
3076         Reviewed by Adam Barth.
3077
3078         check-webkit-style is too noisy about namespace indenting issues.
3079         https://bugs.webkit.org/show_bug.cgi?id=32096
3080
3081         * Scripts/modules/cpp_style.py:
3082         Added a _FileState object to be able to track file level information. In this
3083         case, it simply tracks whether the error has already been given, so that it isn't
3084         done again.
3085         * Scripts/modules/cpp_style_unittest.py:
3086         Modified test cases to pass in the _FileState object and fix a test that expected
3087         to see the namespace error twice (now it only occurs once). No new tests because
3088         existing tests cover the change in functionality.
3089
3090 2009-12-01  Kevin Ollivier  <kevino@theolliviers.com>
3091
3092         Reviewed by Eric Seidel.
3093
3094         [wx] Get DumpRenderTree building after waf switch.
3095         
3096         https://bugs.webkit.org/show_bug.cgi?id=32041
3097
3098         * DumpRenderTree/wscript: Added.
3099         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3100         (LayoutTestController::setTimelineProfilingEnabled):
3101         (LayoutTestController::evaluateScriptInIsolatedWorld):
3102         (LayoutTestController::disableImageLoading):
3103         (LayoutTestController::whiteListAccessFromOrigin):
3104         (LayoutTestController::counterValueForElementById):
3105         * Scripts/build-webkit:
3106
3107 2009-12-02  Adam Barth  <abarth@webkit.org>
3108
3109         Reviewed by Eric Seidel.
3110
3111         [bzt] build-attachment shouldn't check whether the builders are red
3112         https://bugs.webkit.org/show_bug.cgi?id=32062
3113
3114         build-attachment doesn't touch the remote repository, so there isn't a
3115         need to hold off when the builders are red.
3116
3117         * Scripts/modules/commands/download.py:
3118         * Scripts/modules/landingsequence.py:
3119
3120 2009-12-02  Eric Seidel  <eric@webkit.org>
3121
3122         Reviewed by Adam Barth.
3123
3124         REGRESSION(51590): style-queue and build-queue think their empty when they are not
3125         https://bugs.webkit.org/show_bug.cgi?id=32061
3126
3127         * Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings.
3128         * Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints.
3129
3130 2009-12-02  Eric Seidel  <eric@webkit.org>
3131
3132         Reviewed by Adam Barth.
3133
3134         build-queue is throwing exceptions and complaining about
3135         lack of --no-update on build-attachment.  Make it stop.
3136
3137         * Scripts/modules/buildsteps.py:
3138         * Scripts/modules/commands/download.py:
3139
3140 2009-12-02  Adam Barth  <abarth@webkit.org>
3141
3142         Unreviewed "build" fix.  Forgot to declare my variables.  :(
3143
3144         * QueueStatusServer/queue_status.py:
3145
3146 2009-12-02  Adam Barth  <abarth@webkit.org>
3147
3148         Reviewed by Eric Seidel.
3149
3150         [bzt] Implement status bubble view
3151         https://bugs.webkit.org/show_bug.cgi?id=32057
3152
3153         The status bubble is a compact representation of the queue status for a
3154         given patch.  This will eventually help us reduce the comment spam from
3155         the queues.
3156
3157         * QueueStatusServer/index.html: Added HTML5 doctype for sanity.
3158         * QueueStatusServer/queue_status.py:
3159         * QueueStatusServer/status_bubble.html: Added.
3160
3161 2009-12-02  Eric Seidel  <eric@webkit.org>
3162
3163         Reviewed by Adam Barth.
3164
3165         trim commands/*.py includes now that commands are unit tested
3166         https://bugs.webkit.org/show_bug.cgi?id=32056
3167
3168         In the course of ensuring that the unit tests still
3169         passed after this change, I had to actually make them
3170         pass in the first place.
3171
3172         * Scripts/modules/bugzilla.py:
3173          - Fix _parse_attachment_ids_request_query to return ints instead of strings.
3174         * Scripts/modules/commands/download.py: Remove unneeded imports.
3175         * Scripts/modules/commands/queries.py: Ditto.
3176         * Scripts/modules/commands/queues.py: Ditto.
3177         * Scripts/modules/commands/upload.py: Ditto.
3178         * Scripts/modules/scm_unittest.py:
3179          - Fix to expect the \n after the path since echo adds an \n.
3180
3181 2009-12-01  Yaar Schnitman  <yaar@chromium.org>
3182
3183         build-webkit: Remove flex,bison,gperf check for chromium
3184         https://bugs.webkit.org/show_bug.cgi?id=32043
3185
3186         * Scripts/webkitdirs.pm:
3187
3188 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
3189
3190         Build fixage for Windows/GTK for DumpRenderTree.
3191
3192         WAI-ARIA: implement support for ARIA drag and drop
3193         https://bugs.webkit.org/show_bug.cgi?id=32007
3194
3195         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3196         (AccessibilityUIElement::ariaIsGrabbed):
3197         (AccessibilityUIElement::ariaDropEffects):
3198         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3199         (AccessibilityUIElement::ariaIsGrabbed):
3200         (AccessibilityUIElement::ariaDropEffects):
3201
3202 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
3203
3204         Reviewed by Darin Adler.
3205
3206         WAI-ARIA: implement support for ARIA drag and drop
3207         https://bugs.webkit.org/show_bug.cgi?id=32007
3208
3209         * DumpRenderTree/AccessibilityUIElement.cpp:
3210         (getARIADropEffectsCallback):
3211         (getARIAIsGrabbedCallback):
3212         (AccessibilityUIElement::getJSClass):
3213         * DumpRenderTree/AccessibilityUIElement.h:
3214         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3215         (AccessibilityUIElement::ariaIsGrabbed):
3216         (AccessibilityUIElement::ariaDropEffects):
3217
3218 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
3219
3220         Not reviewed. GTK DRT try 2.
3221
3222         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3223         (LayoutTestController::sampleSVGAnimationForElementAtTime):
3224
3225 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
3226
3227         Not reviewed. Try to fix gtk DRT build.
3228
3229         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3230
3231 2009-12-01  David Levin  <levin@chromium.org>
3232
3233         Reviewed by Eric Seidel.
3234
3235         check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
3236         https://bugs.webkit.org/show_bug.cgi?id=32033
3237
3238         * Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find
3239                                         instead of startswith.
3240         * Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior.
3241
3242 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
3243
3244         Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well.
3245
3246         * DumpRenderTree/qt/LayoutTestControllerQt.h: Update old function signature.
3247
3248 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
3249
3250         Reviewed by Simon Fraser.
3251
3252         Add SVG animation test framework with 'snapshot' functionality
3253         https://bugs.webkit.org/show_bug.cgi?id=31897
3254
3255         Add new 'sampleSVGAnimationForElementAtTime' DRT method,
3256         used by the new SVG animation testing framework, implemented
3257         for qt/gtk/win/mac.
3258
3259         * DumpRenderTree/LayoutTestController.cpp:
3260         (sampleSVGAnimationForElementAtTimeCallback):
3261         (LayoutTestController::staticFunctions):
3262         * DumpRenderTree/LayoutTestController.h:
3263         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3264         (LayoutTestController::sampleSVGAnimationForElementAtTime):
3265         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3266         (LayoutTestController::sampleSVGAnimationForElementAtTime):
3267         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3268         (LayoutTestController::sampleSVGAnimationForElementAtTime):
3269         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3270         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3271         (LayoutTestController::sampleSVGAnimationForElementAtTime):
3272         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3273         (LayoutTestController::sampleSVGAnimationForElementAtTime):
3274
3275 2009-12-01  Adam Roben  <aroben@apple.com>
3276
3277         Remove user content before running each test on Windows
3278
3279         Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows
3280
3281         Reviewed by Alexey Proskuryakov.
3282
3283         * DumpRenderTree/win/DumpRenderTree.cpp:
3284         (resetWebViewToConsistentStateBeforeTesting): Remove all user content
3285         before each test, which matches Mac.
3286
3287 2009-12-01  Yuzo Fujishima  <yuzo@google.com>
3288
3289         Reviewed by Alexey Proskuryakov.
3290
3291         Make pywebsocket log errors to a file
3292         https://bugs.webkit.org/show_bug.cgi?id=31604
3293
3294         * Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory
3295         (by passing the path to the server via a recently added -l option).
3296
3297 2009-12-01  Adam Roben  <aroben@apple.com>
3298
3299         Fix tests that use the TestNetscapePlugin in Debug_Internal builds
3300
3301         Reviewed by Ada Chan.
3302
3303         Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
3304         TestNetscapePlugin fail in Debug_Internal builds
3305
3306         * DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin
3307         directory in Debug and Debug_All builds, but not in Debug_Internal
3308         builds.
3309
3310 2009-12-01  Adam Roben  <aroben@apple.com>
3311
3312         Re-enable DRT's watchdog timer on Windows
3313
3314         It was accidentally disabled in r50907.
3315
3316         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3317         (LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
3318         into an if condition.
3319
3320 2009-12-01  Adam Barth  <abarth@webkit.org>
3321
3322         Reviewed by Eric Seidel.
3323
3324         check-webkit-style complains about #imports with / in them
3325         https://bugs.webkit.org/show_bug.cgi?id=32022
3326
3327         We need to exclude #import directives in addition to #include from the
3328         binary operator whitespace checks.
3329
3330         * Scripts/modules/cpp_style.py:
3331         * Scripts/modules/cpp_style_unittest.py:
3332
3333 2009-11-30  Adam Barth  <abarth@webkit.org>
3334
3335         Reviewed by Eric Seidel.
3336
3337         check-webkit-style is slightly too verbose
3338         https://bugs.webkit.org/show_bug.cgi?id=32010
3339
3340         check-webkit-style prints out a bunch of "done" lines that seem redundant,
3341         especially for the style-queue.
3342
3343         * Scripts/modules/cpp_style.py:
3344
3345 2009-11-30  Alejandro G. Castro  <alex@igalia.com>
3346
3347         Reviewed by Eric Seidel.
3348
3349         [GTK] Moved the functions that are closing the result log of the
3350         tests to the last line of the runTest function, this avoids
3351         reporting crashes in the wrong test if there is a problem when
3352         reseting the state after the test.
3353
3354         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3355         (dump):
3356         (runTest):
3357
3358 2009-11-30  Sam Weinig  <sam@webkit.org>
3359
3360         Reviewed by Geoffrey Garen.
3361
3362         Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
3363         fast/js/date-proto-generic-invocation breaks another test
3364
3365         Don't cache JSClassRefs, a change to the prototype chain will
3366         last between tests.
3367
3368         * DumpRenderTree/AccessibilityController.cpp:
3369         (AccessibilityController::getJSClass):
3370         * DumpRenderTree/GCController.cpp:
3371         (GCController::getJSClass):
3372         * DumpRenderTree/GCController.h:
3373         * DumpRenderTree/LayoutTestController.cpp:
3374         (LayoutTestController::getJSClass):
3375
3376 2009-11-30  Yuzo Fujishima  <yuzo@google.com>
3377
3378         Reviewed by Alexey Proskuryakov.
3379
3380         Update pywebsocket to 0.4.2.1.
3381         This is to fix a bug that some messages are logged to stderr even when the log file is specified.
3382         https://bugs.webkit.org/show_bug.cgi?id=31976
3383
3384         * pywebsocket/mod_pywebsocket/standalone.py:
3385         * pywebsocket/setup.py:
3386
3387 2009-11-30  Adam Barth  <abarth@webkit.org>
3388
3389         Reviewed by Eric Seidel.
3390
3391         [bzt] Generate pass messages for style-queue
3392         https://bugs.webkit.org/show_bug.cgi?id=31995
3393
3394         With this change, the style-queue posts "pass" messages to bugs as
3395         well.  Also, added more information to the state store w.r.t. passing
3396         and failing.
3397
3398         * Scripts/modules/commands/queues.py:
3399         * Scripts/modules/patchcollection.py:
3400
3401 2009-11-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3402
3403         Reviewed by Simon Fraser.
3404
3405         Check for WEBKIT_TESTFONTS environment variable in
3406         run-webkit-tests, for GTK+, to have a more prominent error
3407         message.
3408
3409         * Scripts/run-webkit-tests:
3410
3411 2009-11-30  Yaar Schnitman  <yaar@chromium.org>
3412
3413         Reviewed by Dimitri Glazkov.
3414
3415         update-webkit --chromium forces gclient sync
3416
3417         https://bugs.webkit.org/show_bug.cgi?id=31967
3418
3419         * Scripts/update-webkit-chromium:
3420
3421 2009-11-29  Eric Seidel  <eric@webkit.org>
3422
3423         Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.
3424
3425         * Scripts/modules/committers.py:
3426
3427 2009-11-29  Eric Seidel  <eric@webkit.org>
3428
3429         No review, just adding missing svn property.
3430
3431         Set svn:executable property on new scripts.
3432         These were added by commit-queue commits, but the executable
3433         property was lost due to a bug in svn-apply:
3434         https://bugs.webkit.org/show_bug.cgi?id=27204
3435
3436         * Scripts/update-webkit-chromium: Added property svn:executable.
3437         * Scripts/validate-committer-lists: Added property svn:executable.
3438
3439 2009-11-29  Eric Seidel  <eric@webkit.org>
3440
3441         Reviewed by Adam Barth.
3442
3443         Need a way to validate that committers.py includes all committers/reviewers
3444         https://bugs.webkit.org/show_bug.cgi?id=30970
3445
3446         Add a script which knows how to compare our public committer/reviewer
3447         lists and show discrepancies between them.
3448
3449         Validates mailing lists vs. committers.py:
3450         - committers.py committers missing from webkit-committers@lists
3451         - webkit-committers@lists members missing from committers.py
3452         - committers.py reviewers missing from webkit-reviewers@lists
3453         - webkit-reviewers@lists members missing from committers.py
3454         - webkit-reviewers@lists members missing from committers.py reviewer list
3455
3456         Validates committers.py vs. trunk/ SVN history:
3457         - committers who have not committed in over a year
3458         - SVN committers missing from committers.py
3459         - committers.py members who have no record in SVN.
3460
3461         All of these lists still show "false positives" until a few more committers.py updates are made, like:
3462         https://bugs.webkit.org/show_bug.cgi?id=31366
3463
3464         * Scripts/validate-committer-lists: Added.
3465
3466 2009-11-28  Adam Barth  <abarth@webkit.org>
3467
3468         Reviewed by Eric Seidel.
3469
3470         [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
3471         https://bugs.webkit.org/show_bug.cgi?id=31950
3472
3473         Now we cache the last status that we get back from QueueStatusServer.
3474         Eventually we'll have to do something more fancy if we want to support
3475         a "try again" button on QueueStatusServer, but we can cross that bridge
3476         when we come to it.
3477
3478         * Scripts/modules/patchcollection.py:
3479
3480 2009-11-28  Adam Barth  <abarth@webkit.org>
3481
3482         Reviewed by Eric Seidel.
3483
3484         StyleQueue scans ~100 bug pages every 5 minutes
3485         https://bugs.webkit.org/show_bug.cgi?id=31947
3486
3487         Instead of getting the pending-review attachment ids by scanning each
3488         bug (which results in a network request), we should just get them all
3489         from webkit.org/pending-review in one shot.
3490
3491         * Scripts/modules/bugzilla.py:
3492         * Scripts/modules/bugzilla_unittest.py:
3493         * Scripts/modules/commands/queries.py:
3494         * Scripts/modules/commands/queries_unittest.py:
3495         * Scripts/modules/commands/queues.py:
3496         * Scripts/modules/mock_bugzillatool.py:
3497         * Scripts/modules/patchcollection.py:
3498
3499 2009-11-28  Adam Barth  <abarth@webkit.org>
3500
3501         Reviewed by Eric Seidel.
3502
3503         [bzt] CC webkit-bot-watchers whenever the bots touch bugs
3504         https://bugs.webkit.org/show_bug.cgi?id=31952
3505
3506         The mailing list is open for anyone to subscribe.
3507
3508         * Scripts/modules/bugzilla.py:
3509         * Scripts/modules/commands/queues.py:
3510
3511 2009-11-28  Adam Barth  <abarth@webkit.org>
3512
3513         Reviewed by Eric Seidel.
3514
3515         [bzt] style-queue should report style errors to bugzilla
3516         https://bugs.webkit.org/show_bug.cgi?id=31945
3517
3518         Currently, we're just logging the style errors locally.  With this
3519         patch we'll actually log the errors to bugzilla.  Note: I plan to run
3520         with the "local-only" logging during development.
3521
3522         * Scripts/modules/commands/queues.py:
3523         * Scripts/modules/scm.py:
3524
3525 2009-11-28  Adam Barth  <abarth@webkit.org>
3526
3527         Reviewed by Eric Seidel.
3528
3529         [bzt] style-queue shouldn't reject patches from the commit-queue
3530         https://bugs.webkit.org/show_bug.cgi?id=31944
3531
3532         Currently the style-queue subprocess gets confused and thinks its the
3533         commit-queue.  If the patch has an error, it rejects it from the
3534         commit-queue.  Instead, we should have style-queue specific logic.
3535         This patch doesn't add that logic, but it gives us a callback we can
3536         use to add that logic.
3537
3538         * Scripts/modules/buildsteps.py:
3539         * Scripts/modules/commands/queues.py:
3540         * Scripts/modules/landingsequence.py:
3541
3542 2009-11-27  Adam Barth  <abarth@webkit.org>
3543
3544         Rubber stamped by Eric Seidel.
3545
3546         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
3547
3548         * CommitQueueStatus: Removed.
3549         * CommitQueueStatus/app.yaml: Removed.
3550         * CommitQueueStatus/filters: Removed.
3551         * CommitQueueStatus/filters/__init__.py: Removed.
3552         * CommitQueueStatus/filters/webkit_extras.py: Removed.
3553         * CommitQueueStatus/index.html: Removed.
3554         * CommitQueueStatus/index.yaml: Removed.
3555         * CommitQueueStatus/queue_status.py: Removed.
3556         * CommitQueueStatus/stylesheets: Removed.
3557         * CommitQueueStatus/stylesheets/main.css: Removed.
3558         * CommitQueueStatus/update_status.html: Removed.
3559         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
3560
3561 2009-11-27  Adam Barth  <abarth@webkit.org>
3562
3563         Reviewed by Eric Seidel.
3564
3565         style-queue should only process each patch once
3566         https://bugs.webkit.org/show_bug.cgi?id=31939
3567
3568         Actually address reviewer comments!
3569
3570         * Scripts/bugzilla-tool:
3571
3572 2009-11-27  Adam Barth  <abarth@webkit.org>
3573
3574         Reviewed by Eric Seidel.
3575
3576         [bzt] style-queue fails to apply a bunch of patches for no reason
3577         https://bugs.webkit.org/show_bug.cgi?id=31942
3578
3579         By passing --non-interactive to check-style, we convince check-style
3580         to pass --force to svn-apply, which lets it apply more patches.
3581
3582         * Scripts/modules/commands/queues.py:
3583
3584 2009-11-27  Adam Barth  <abarth@webkit.org>
3585
3586         Reviewed by Eric Seidel.
3587
3588         [bzt] Support --status-host in style-queue
3589         https://bugs.webkit.org/show_bug.cgi?id=31941
3590
3591         * Scripts/modules/commands/queues.py:
3592         * Scripts/modules/statusbot.py:
3593
3594 2009-11-27  Adam Barth  <abarth@webkit.org>
3595
3596         Reviewed by Eric Seidel.
3597
3598         style-queue should only process each patch once
3599         https://bugs.webkit.org/show_bug.cgi?id=31939
3600
3601         Before processing a patch, the try-queues now ask the web service
3602         whether they have already processed the patch.  This is an initial cut
3603         of this functionality.  I expect we're make it richer over time.
3604
3605         * Scripts/bugzilla-tool:
3606         * Scripts/modules/commands/queues.py:
3607         * Scripts/modules/patchcollection.py:
3608
3609 2009-11-27  Adam Barth  <abarth@webkit.org>
3610
3611         Reviewed by Eric Seidel.
3612
3613         PatchStatus does not return status
3614         https://bugs.webkit.org/show_bug.cgi?id=31938
3615
3616         We need to parse attachment_id as an int.  Otherwise, we can't find
3617         anything in the datastore.
3618
3619         * CommitQueueStatus/queue_status.py:
3620
3621 2009-11-27  Adam Barth  <abarth@webkit.org>
3622
3623         Reviewed by Eric Seidel.
3624
3625         Make commit-queue status not throw an exception where there is not
3626         status
3627         https://bugs.webkit.org/show_bug.cgi?id=31936
3628
3629         We need to actually fetch the results of the query to see what's in the
3630         datastore.
3631
3632         * CommitQueueStatus/queue_status.py:
3633
3634 2009-11-27  Adam Barth  <abarth@webkit.org>
3635
3636         Reviewed by Eric Seidel.
3637
3638         [bzt] unit test ApplyPatches and ApplyAttachment
3639         https://bugs.webkit.org/show_bug.cgi?id=31935
3640