WebKitTools/ChangeLog

   1 2009-11-30  Adam Barth  <abarth@webkit.org>
   2
   3         Reviewed by Eric Seidel.
   4
   5         check-webkit-style is slightly too verbose
   6         https://bugs.webkit.org/show_bug.cgi?id=32010
   7
   8         check-webkit-style prints out a bunch of "done" lines that seem redundant,
   9         especially for the style-queue.
  10
  11         * Scripts/modules/cpp_style.py:
  12
  13 2009-11-30  Alejandro G. Castro  <alex@igalia.com>
  14
  15         Reviewed by Eric Seidel.
  16
  17         [GTK] Moved the functions that are closing the result log of the
  18         tests to the last line of the runTest function, this avoids
  19         reporting crashes in the wrong test if there is a problem when
  20         reseting the state after the test.
  21
  22         * DumpRenderTree/gtk/DumpRenderTree.cpp:
  23         (dump):
  24         (runTest):
  25
  26 2009-11-30  Sam Weinig  <sam@webkit.org>
  27
  28         Reviewed by Geoffrey Garen.
  29
  30         Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
  31         fast/js/date-proto-generic-invocation breaks another test
  32
  33         Don't cache JSClassRefs, a change to the prototype chain will
  34         last between tests.
  35
  36         * DumpRenderTree/AccessibilityController.cpp:
  37         (AccessibilityController::getJSClass):
  38         * DumpRenderTree/GCController.cpp:
  39         (GCController::getJSClass):
  40         * DumpRenderTree/GCController.h:
  41         * DumpRenderTree/LayoutTestController.cpp:
  42         (LayoutTestController::getJSClass):
  43
  44 2009-11-30  Yuzo Fujishima  <yuzo@google.com>
  45
  46         Reviewed by Alexey Proskuryakov.
  47
  48         Update pywebsocket to 0.4.2.1.
  49         This is to fix a bug that some messages are logged to stderr even when the log file is specified.
  50         https://bugs.webkit.org/show_bug.cgi?id=31976
  51
  52         * pywebsocket/mod_pywebsocket/standalone.py:
  53         * pywebsocket/setup.py:
  54
  55 2009-11-30  Adam Barth  <abarth@webkit.org>
  56
  57         Reviewed by Eric Seidel.
  58
  59         [bzt] Generate pass messages for style-queue
  60         https://bugs.webkit.org/show_bug.cgi?id=31995
  61
  62         With this change, the style-queue posts "pass" messages to bugs as
  63         well.  Also, added more information to the state store w.r.t. passing
  64         and failing.
  65
  66         * Scripts/modules/commands/queues.py:
  67         * Scripts/modules/patchcollection.py:
  68
  69 2009-11-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
  70
  71         Reviewed by Simon Fraser.
  72
  73         Check for WEBKIT_TESTFONTS environment variable in
  74         run-webkit-tests, for GTK+, to have a more prominent error
  75         message.
  76
  77         * Scripts/run-webkit-tests:
  78
  79 2009-11-30  Yaar Schnitman  <yaar@chromium.org>
  80
  81         Reviewed by Dimitri Glazkov.
  82
  83         update-webkit --chromium forces gclient sync
  84
  85         https://bugs.webkit.org/show_bug.cgi?id=31967
  86
  87         * Scripts/update-webkit-chromium:
  88
  89 2009-11-29  Eric Seidel  <eric@webkit.org>
  90
  91         Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.
  92
  93         * Scripts/modules/committers.py:
  94
  95 2009-11-29  Eric Seidel  <eric@webkit.org>
  96
  97         No review, just adding missing svn property.
  98
  99         Set svn:executable property on new scripts.
 100         These were added by commit-queue commits, but the executable
 101         property was lost due to a bug in svn-apply:
 102         https://bugs.webkit.org/show_bug.cgi?id=27204
 103
 104         * Scripts/update-webkit-chromium: Added property svn:executable.
 105         * Scripts/validate-committer-lists: Added property svn:executable.
 106
 107 2009-11-29  Eric Seidel  <eric@webkit.org>
 108
 109         Reviewed by Adam Barth.
 110
 111         Need a way to validate that committers.py includes all committers/reviewers
 112         https://bugs.webkit.org/show_bug.cgi?id=30970
 113
 114         Add a script which knows how to compare our public committer/reviewer
 115         lists and show discrepancies between them.
 116
 117         Validates mailing lists vs. committers.py:
 118         - committers.py committers missing from webkit-committers@lists
 119         - webkit-committers@lists members missing from committers.py
 120         - committers.py reviewers missing from webkit-reviewers@lists
 121         - webkit-reviewers@lists members missing from committers.py
 122         - webkit-reviewers@lists members missing from committers.py reviewer list
 123
 124         Validates committers.py vs. trunk/ SVN history:
 125         - committers who have not committed in over a year
 126         - SVN committers missing from committers.py
 127         - committers.py members who have no record in SVN.
 128
 129         All of these lists still show "false positives" until a few more committers.py updates are made, like:
 130         https://bugs.webkit.org/show_bug.cgi?id=31366
 131
 132         * Scripts/validate-committer-lists: Added.
 133
 134 2009-11-28  Adam Barth  <abarth@webkit.org>
 135
 136         Reviewed by Eric Seidel.
 137
 138         [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
 139         https://bugs.webkit.org/show_bug.cgi?id=31950
 140
 141         Now we cache the last status that we get back from QueueStatusServer.
 142         Eventually we'll have to do something more fancy if we want to support
 143         a "try again" button on QueueStatusServer, but we can cross that bridge
 144         when we come to it.
 145
 146         * Scripts/modules/patchcollection.py:
 147
 148 2009-11-28  Adam Barth  <abarth@webkit.org>
 149
 150         Reviewed by Eric Seidel.
 151
 152         StyleQueue scans ~100 bug pages every 5 minutes
 153         https://bugs.webkit.org/show_bug.cgi?id=31947
 154
 155         Instead of getting the pending-review attachment ids by scanning each
 156         bug (which results in a network request), we should just get them all
 157         from webkit.org/pending-review in one shot.
 158
 159         * Scripts/modules/bugzilla.py:
 160         * Scripts/modules/bugzilla_unittest.py:
 161         * Scripts/modules/commands/queries.py:
 162         * Scripts/modules/commands/queries_unittest.py:
 163         * Scripts/modules/commands/queues.py:
 164         * Scripts/modules/mock_bugzillatool.py:
 165         * Scripts/modules/patchcollection.py:
 166
 167 2009-11-28  Adam Barth  <abarth@webkit.org>
 168
 169         Reviewed by Eric Seidel.
 170
 171         [bzt] CC webkit-bot-watchers whenever the bots touch bugs
 172         https://bugs.webkit.org/show_bug.cgi?id=31952
 173
 174         The mailing list is open for anyone to subscribe.
 175
 176         * Scripts/modules/bugzilla.py:
 177         * Scripts/modules/commands/queues.py:
 178
 179 2009-11-28  Adam Barth  <abarth@webkit.org>
 180
 181         Reviewed by Eric Seidel.
 182
 183         [bzt] style-queue should report style errors to bugzilla
 184         https://bugs.webkit.org/show_bug.cgi?id=31945
 185
 186         Currently, we're just logging the style errors locally.  With this
 187         patch we'll actually log the errors to bugzilla.  Note: I plan to run
 188         with the "local-only" logging during development.
 189
 190         * Scripts/modules/commands/queues.py:
 191         * Scripts/modules/scm.py:
 192
 193 2009-11-28  Adam Barth  <abarth@webkit.org>
 194
 195         Reviewed by Eric Seidel.
 196
 197         [bzt] style-queue shouldn't reject patches from the commit-queue
 198         https://bugs.webkit.org/show_bug.cgi?id=31944
 199
 200         Currently the style-queue subprocess gets confused and thinks its the
 201         commit-queue.  If the patch has an error, it rejects it from the
 202         commit-queue.  Instead, we should have style-queue specific logic.
 203         This patch doesn't add that logic, but it gives us a callback we can
 204         use to add that logic.
 205
 206         * Scripts/modules/buildsteps.py:
 207         * Scripts/modules/commands/queues.py:
 208         * Scripts/modules/landingsequence.py:
 209
 210 2009-11-27  Adam Barth  <abarth@webkit.org>
 211
 212         Rubber stamped by Eric Seidel.
 213
 214         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
 215
 216         * CommitQueueStatus: Removed.
 217         * CommitQueueStatus/app.yaml: Removed.
 218         * CommitQueueStatus/filters: Removed.
 219         * CommitQueueStatus/filters/__init__.py: Removed.
 220         * CommitQueueStatus/filters/webkit_extras.py: Removed.
 221         * CommitQueueStatus/index.html: Removed.
 222         * CommitQueueStatus/index.yaml: Removed.
 223         * CommitQueueStatus/queue_status.py: Removed.
 224         * CommitQueueStatus/stylesheets: Removed.
 225         * CommitQueueStatus/stylesheets/main.css: Removed.
 226         * CommitQueueStatus/update_status.html: Removed.
 227         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
 228
 229 2009-11-27  Adam Barth  <abarth@webkit.org>
 230
 231         Reviewed by Eric Seidel.
 232
 233         style-queue should only process each patch once
 234         https://bugs.webkit.org/show_bug.cgi?id=31939
 235
 236         Actually address reviewer comments!
 237
 238         * Scripts/bugzilla-tool:
 239
 240 2009-11-27  Adam Barth  <abarth@webkit.org>
 241
 242         Reviewed by Eric Seidel.
 243
 244         [bzt] style-queue fails to apply a bunch of patches for no reason
 245         https://bugs.webkit.org/show_bug.cgi?id=31942
 246
 247         By passing --non-interactive to check-style, we convince check-style
 248         to pass --force to svn-apply, which lets it apply more patches.
 249
 250         * Scripts/modules/commands/queues.py:
 251
 252 2009-11-27  Adam Barth  <abarth@webkit.org>
 253
 254         Reviewed by Eric Seidel.
 255
 256         [bzt] Support --status-host in style-queue
 257         https://bugs.webkit.org/show_bug.cgi?id=31941
 258
 259         * Scripts/modules/commands/queues.py:
 260         * Scripts/modules/statusbot.py:
 261
 262 2009-11-27  Adam Barth  <abarth@webkit.org>
 263
 264         Reviewed by Eric Seidel.
 265
 266         style-queue should only process each patch once
 267         https://bugs.webkit.org/show_bug.cgi?id=31939
 268
 269         Before processing a patch, the try-queues now ask the web service
 270         whether they have already processed the patch.  This is an initial cut
 271         of this functionality.  I expect we're make it richer over time.
 272
 273         * Scripts/bugzilla-tool:
 274         * Scripts/modules/commands/queues.py:
 275         * Scripts/modules/patchcollection.py:
 276
 277 2009-11-27  Adam Barth  <abarth@webkit.org>
 278
 279         Reviewed by Eric Seidel.
 280
 281         PatchStatus does not return status
 282         https://bugs.webkit.org/show_bug.cgi?id=31938
 283
 284         We need to parse attachment_id as an int.  Otherwise, we can't find
 285         anything in the datastore.
 286
 287         * CommitQueueStatus/queue_status.py:
 288
 289 2009-11-27  Adam Barth  <abarth@webkit.org>
 290
 291         Reviewed by Eric Seidel.
 292
 293         Make commit-queue status not throw an exception where there is not
 294         status
 295         https://bugs.webkit.org/show_bug.cgi?id=31936
 296
 297         We need to actually fetch the results of the query to see what's in the
 298         datastore.
 299
 300         * CommitQueueStatus/queue_status.py:
 301
 302 2009-11-27  Adam Barth  <abarth@webkit.org>
 303
 304         Reviewed by Eric Seidel.
 305
 306         [bzt] unit test ApplyPatches and ApplyAttachment
 307         https://bugs.webkit.org/show_bug.cgi?id=31935
 308
 309         * Scripts/modules/commands/download.py:
 310         * Scripts/modules/commands/download_unittest.py:
 311
 312 2009-11-27  Adam Barth  <abarth@webkit.org>
 313
 314         Reviewed by Eric Seidel.
 315
 316         [bzt] Unit test download commands
 317         https://bugs.webkit.org/show_bug.cgi?id=31923
 318
 319         Adds download_unittest and fixes a bug found while testing.
 320
 321         * Scripts/modules/commands/commandtest.py:
 322         * Scripts/modules/commands/download.py:
 323             Fixed a bug where we'd throw an error because [].append returns
 324             None.
 325         * Scripts/modules/commands/download_unittest.py: Added.
 326         * Scripts/modules/mock_bugzillatool.py:
 327         * Scripts/run-webkit-unittests:
 328
 329 2009-11-27  Adam Barth  <abarth@webkit.org>
 330
 331         Unreviewed "build" fix found while writing unit tests.
 332
 333         * Scripts/modules/commands/download.py:
 334
 335 2009-11-27  Adam Barth  <abarth@webkit.org>
 336
 337         Reviewed by Eric Seidel.
 338
 339         [bzt] Kill WebKitLandingScripts
 340         https://bugs.webkit.org/show_bug.cgi?id=31904
 341
 342         Step 6: Kill the rest.
 343
 344         * Scripts/modules/buildsteps.py:
 345         * Scripts/modules/commands/download.py:
 346         * Scripts/modules/commands/queries.py:
 347         * Scripts/modules/commands/upload.py:
 348         * Scripts/modules/landingsequence.py:
 349         * Scripts/modules/scm.py:
 350         * Scripts/modules/webkitlandingscripts.py: Removed.
 351
 352 2009-11-27  Adam Barth  <abarth@webkit.org>
 353
 354         Reviewed by Eric Seidel.
 355
 356         [bzt] Unit test upload commands
 357         https://bugs.webkit.org/show_bug.cgi?id=31903
 358
 359         Adds unit tests for all but two of the upload commands.  The two
 360         remaining ones are more difficult.  I'll return to them later.  The
 361         goal of these tests is just to run the commands.  We can test more
 362         detailed behavior later.
 363
 364         * Scripts/modules/commands/commandtest.py:
 365         * Scripts/modules/commands/upload.py:
 366         * Scripts/modules/commands/upload_unittest.py:
 367         * Scripts/modules/mock.py: Added.
 368         * Scripts/modules/mock_bugzillatool.py:
 369
 370 2009-11-26  Adam Barth  <abarth@webkit.org>
 371
 372         Reviewed by Eric Seidel.
 373
 374         [bzt] Kill WebKitLandingScripts
 375         https://bugs.webkit.org/show_bug.cgi?id=31904
 376
 377         Step 5: Kill run_and_throw_if_fail.
 378
 379         * Scripts/modules/buildsteps.py:
 380         * Scripts/modules/processutils.py: Added.
 381         * Scripts/modules/webkitlandingscripts.py:
 382
 383 2009-11-26  Adam Barth  <abarth@webkit.org>
 384
 385         Reviewed by Eric Seidel.
 386
 387         [bzt] Kill WebKitLandingScripts
 388         https://bugs.webkit.org/show_bug.cgi?id=31904
 389
 390         Step 4: Kill run_webkit_script.
 391
 392         * Scripts/modules/buildsteps.py:
 393         * Scripts/modules/commands/download.py:
 394         * Scripts/modules/webkitlandingscripts.py:
 395
 396 2009-11-26  Adam Barth  <abarth@webkit.org>
 397
 398         Reviewed by Eric Seidel.
 399
 400         [bzt] Kill WebKitLandingScripts
 401         https://bugs.webkit.org/show_bug.cgi?id=31904
 402
 403         Step 3: Kill build_webkit.
 404
 405         * Scripts/modules/buildsteps.py:
 406         * Scripts/modules/landingsequence.py:
 407         * Scripts/modules/webkitlandingscripts.py:
 408
 409 2009-11-26  Adam Barth  <abarth@webkit.org>
 410
 411         Reviewed by Eric Seidel.
 412
 413         [bzt] Kill WebKitLandingScripts
 414         https://bugs.webkit.org/show_bug.cgi?id=31904
 415
 416         Step 2: Kill ensure_builders_are_green.
 417
 418         * Scripts/modules/buildsteps.py:
 419         * Scripts/modules/commands/download.py:
 420         * Scripts/modules/landingsequence.py:
 421         * Scripts/modules/webkitlandingscripts.py:
 422
 423 2009-11-26  Adam Barth  <abarth@webkit.org>
 424
 425         Reviewed by Eric Seidel.
 426
 427         [bzt] Kill WebKitLandingScripts
 428         https://bugs.webkit.org/show_bug.cgi?id=31904
 429
 430         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
 431
 432         * Scripts/bugzilla-tool:
 433         * Scripts/modules/buildsteps.py: Added.
 434         * Scripts/modules/commands/download.py:
 435         * Scripts/modules/landingsequence.py:
 436         * Scripts/modules/webkitlandingscripts.py:
 437
 438 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
 439
 440         Reviewed by Adam Barth.
 441
 442         Remove directory prefixes from linux commands
 443
 444         SCM unittests can cause errors on some systems if we use absolute reference to
 445         the commands, so directory prefixes have been removed.
 446
 447         * Scripts/modules/scm_unittest.py:
 448
 449 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
 450
 451         Reviewed by Kenneth Rohde Christiansen.
 452
 453         Link DumpRenderTree to the Qt Ui Tools
 454         https://bugs.webkit.org/show_bug.cgi?id=31203
 455
 456         Implement QWebPage::createPlugin using the Qt Ui Tools
 457         to be able to create classes like QProgressBar from within
 458         the <object></object> tags This is required for the
 459         new automatic test of Qt Plugins.
 460
 461         * DumpRenderTree/qt/DumpRenderTree.cpp:
 462         (WebCore::WebPage::createPlugin):
 463         * DumpRenderTree/qt/DumpRenderTree.h:
 464         * DumpRenderTree/qt/DumpRenderTree.pro:
 465
 466 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
 467
 468         Reviewed by Eric Seidel.
 469
 470         Update pywebsocket to 0.4.2
 471
 472         Update pywebsocket to 0.4.2
 473         https://bugs.webkit.org/show_bug.cgi?id=31861
 474
 475         * pywebsocket/example/echo_client.py:
 476         * pywebsocket/example/echo_wsh.py:
 477         * pywebsocket/mod_pywebsocket/__init__.py:
 478         * pywebsocket/mod_pywebsocket/dispatch.py:
 479         * pywebsocket/mod_pywebsocket/msgutil.py:
 480         * pywebsocket/mod_pywebsocket/standalone.py:
 481         * pywebsocket/setup.py:
 482         * pywebsocket/test/test_dispatch.py:
 483         * pywebsocket/test/test_msgutil.py:
 484
 485 2009-11-25  Adam Barth  <abarth@webkit.org>
 486
 487         Reviewed by Eric Seidel.
 488
 489         Add unit test for mark-fixed
 490         https://bugs.webkit.org/show_bug.cgi?id=31896
 491
 492         * Scripts/modules/commands/commandtest.py: Added.
 493         * Scripts/modules/commands/queries_unittest.py:
 494         * Scripts/modules/commands/upload_unittest.py: Added.
 495         * Scripts/modules/mock_bugzillatool.py:
 496         * Scripts/run-webkit-unittests:
 497
 498 2009-11-25  Adam Barth  <abarth@webkit.org>
 499
 500         Reviewed by Eric Seidel.
 501
 502         bugzilla-tool should have a mark-fixed command
 503         https://bugs.webkit.org/show_bug.cgi?id=31853
 504
 505         Pretty simple stuff.
 506
 507         * Scripts/modules/commands/upload.py:
 508
 509 2009-11-25  Eric Seidel  <eric@webkit.org>
 510
 511         Reviewed by Adam Barth.
 512
 513         'bugzilla-tool help' should only show common commands like how 'git help' does
 514         https://bugs.webkit.org/show_bug.cgi?id=31772
 515
 516         I also took this opportunity to make 'help' a real Command.
 517         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
 518
 519         * Scripts/bugzilla-tool:
 520          - change should_show_command_help to should_show_in_main_help
 521         * Scripts/modules/commands/download.py:
 522          - Mark commands as being shown in main help or not.
 523          - show_in_main_help = False is not required (default is false),
 524            but it seemed to make the commands more self-documenting.
 525         * Scripts/modules/commands/queries.py: ditto
 526         * Scripts/modules/commands/queues.py: ditto
 527         * Scripts/modules/commands/upload.py: ditto
 528         * Scripts/modules/multicommandtool.py:
 529          - Make Command hold a pointer to tool in self.tool.  Most Command
 530            subclasses do not take advantage of this yet, but it was required
 531            for HelpCommand to be able to reach the tool from _help_epilog().
 532          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
 533          - Move MultiCommandTool._help_epilog to Command._help_epilog
 534          - Move "help" logic into HelpCommand.execute()
 535          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
 536         * Scripts/modules/multicommandtool_unittest.py:
 537          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
 538
 539 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
 540
 541         Reviewed by Dan Bernstein.
 542
 543         Patch by Mark Rowe.
 544
 545         The buildbots are failing on Windows because when they were upgraded
 546         to 4.0.4, Apple Application Support was not in their path. Add it to
 547         the path to fix the buildots.
 548
 549         * Scripts/webkitdirs.pm:
 550
 551 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
 552
 553         Reviewed by David Kilzer.
 554
 555         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
 556         https://bugs.webkit.org/show_bug.cgi?id=31799
 557
 558         * Scripts/run-webkit-tests: Fixed.
 559
 560 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
 561
 562         Reviewed by Eric Seidel.
 563
 564         Change run_command to give back stderr by default
 565         https://bugs.webkit.org/show_bug.cgi?id=31734
 566
 567         Change run_command to give back stderr by default.
 568         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
 569         Change the related unittest call.
 570
 571         * Scripts/modules/scm.py:
 572         * Scripts/modules/scm_unittest.py:
 573
 574 2009-11-25  Eric Seidel  <eric@webkit.org>
 575
 576         Reviewed by Adam Barth.
 577
 578         Centralize required argument parsing in Command
 579         https://bugs.webkit.org/show_bug.cgi?id=31872
 580
 581         * Scripts/modules/commands/download.py: remove custom required arg message.
 582         * Scripts/modules/commands/upload.py: ditto.
 583         * Scripts/modules/multicommandtool.py:
 584          - Add _parse_required_arguments.
 585          - Pass program name off to OptionParser.
 586          - Add name() for access to tool name.
 587          - Add check_arguments_and_execute and make it return a return code.
 588          - Replace a couple uses of + with %.
 589         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
 590
 591 2009-11-25  Eric Seidel  <eric@webkit.org>
 592
 593         Reviewed by Adam Barth.
 594
 595         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
 596         https://bugs.webkit.org/show_bug.cgi?id=31870
 597
 598         * Scripts/modules/commands/queries_unittest.py: Use the new class.
 599         * Scripts/modules/multicommandtool_unittest.py: Ditto.
 600         * Scripts/modules/outputcapture.py: Added.
 601
 602 2009-11-24  Dmitry Titov  <dimich@chromium.org>
 603
 604         Reviewed by Eric Seidel.
 605
 606         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
 607         https://bugs.webkit.org/show_bug.cgi?id=31444
 608
 609         * Scripts/build-webkit:
 610
 611 2009-11-24  Chris Marrin  <cmarrin@apple.com>
 612
 613         Reviewed by Simon Fraser.
 614
 615         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
 616         https://bugs.webkit.org/show_bug.cgi?id=27314
 617
 618         Now the script allows the directories with these tests to be included on all
 619         platforms but Mac, where they behave the same as always. For all other platforms
 620         the tests need to be excluded using the Skipped files, which is currently done
 621         for all platforms (including win since we're not turned on yet)
 622
 623         * Scripts/webkitdirs.pm:
 624
 625 2009-11-24  Eric Seidel  <eric@webkit.org>
 626
 627         Reviewed by Adam Barth.
 628
 629         queries_unittest.py should test command output
 630         https://bugs.webkit.org/show_bug.cgi?id=31845
 631
 632         * Scripts/modules/commands/queries_unittest.py:
 633          - Capture stdout and stderr and compare with expected strings.
 634
 635 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
 636
 637         No Review.
 638
 639         Fix spelling error ("depenedencies").
 640
 641         * Scripts/build-webkit:
 642
 643 2009-11-24  Mark Rowe  <mrowe@apple.com>
 644
 645         Land the configuration that includes the two debug GTK Linux builders.
 646
 647         * BuildSlaveSupport/build.webkit.org-config/config.json:
 648
 649 2009-11-24  David Kilzer  <ddkilzer@apple.com>
 650
 651         <http://webkit.org/b/31840> bisect-builds broke after r50080
 652
 653         Reviewed by Dan Bernstein.
 654
 655         * Scripts/bisect-builds:
 656         (mountAndRunNightly): Switched back to using backticks to run
 657         the hdiutil command since exec() will terminate the existing
 658         script, which is not what we want.  Store the output of
 659         File::Spec->devnull() in a variable for use in the hdiutil
 660         detach commands.
 661
 662 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 663
 664         Reviewed by Kenneth Rohde Christiansen.
 665
 666         Include "config.h" to meet Coding Style Guidelines
 667         https://bugs.webkit.org/show_bug.cgi?id=31792
 668
 669         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
 670         * DumpRenderTree/qt/jsobjects.cpp:
 671         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
 672
 673 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 674
 675         Reviewed by Oliver Hunt.
 676
 677         Implement new required function to pass test we used to pass. This
 678         change is required since r51294.
 679
 680         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 681         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 682
 683 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
 684
 685         Reviewed by Kenneth Rohde Christiansen.
 686
 687         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
 688         https://bugs.webkit.org/show_bug.cgi?id=31775
 689
 690         LayoutTestController::dumpBackForwardList() should work with local URLs
 691         as well as with normal URLs (in http tests for instance).
 692         Currently it does not output the latter properly.
 693
 694         Unskip a bunch of passing http/navigation tests.
 695
 696         * DumpRenderTree/qt/DumpRenderTree.cpp:
 697         (WebCore::dumpHistoryItem):
 698
 699 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
 700
 701         Reviewed by Oliver Hunt.
 702
 703         ARIA: support aria-flowto
 704         https://bugs.webkit.org/show_bug.cgi?id=31762
 705
 706         * DumpRenderTree/AccessibilityUIElement.cpp:
 707         (ariaFlowToElementAtIndexCallback):
 708         (AccessibilityUIElement::getJSClass):
 709         * DumpRenderTree/AccessibilityUIElement.h:
 710         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 711         (AccessibilityUIElement::ariaFlowToElementAtIndex):
 712         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 713         (AccessibilityUIElement::ariaFlowToElementAtIndex):
 714         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 715         (AccessibilityUIElement::ariaFlowToElementAtIndex):
 716
 717 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
 718
 719         Reviewed by Kenneth Christiansen.
 720
 721         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
 722         https://bugs.webkit.org/show_bug.cgi?id=31638
 723
 724         Unfreeze WorkQueue after each test execution.
 725
 726         * DumpRenderTree/qt/DumpRenderTree.cpp:
 727         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 728
 729 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
 730
 731         Reviewed by Adam Barth.
 732
 733         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
 734         for localhost and 127.0.0.1.
 735         https://bugs.webkit.org/show_bug.cgi?id=31783
 736
 737         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
 738
 739         * DumpRenderTree/qt/DumpRenderTree.cpp:
 740         (WebCore::NetworkAccessManager::NetworkAccessManager):
 741         (WebCore::NetworkAccessManager::sslErrorsEncountered):
 742         (WebCore::WebPage::WebPage):
 743         * DumpRenderTree/qt/DumpRenderTree.h:
 744
 745 2009-11-22  Chris Evans  <cevans@chromium.org>
 746
 747         Reviewed by Adam Barth.
 748
 749         Disable access to file:/// directory listings
 750         https://bugs.webkit.org/show_bug.cgi?id=31329
 751
 752         Implemented setAllowUniversalAccessFromFileURLs to support testing of
 753         file URL security.
 754
 755         * DumpRenderTree/LayoutTestController.cpp:
 756         (setAllowUniversalAccessFromFileURLsCallback):
 757         (LayoutTestController::staticFunctions):
 758         * DumpRenderTree/LayoutTestController.h:
 759         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 760         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 761         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 762         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 763         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 764         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 765         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 766         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 767
 768 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
 769
 770         Reviewed by Kenneth Rohde Christiansen.
 771
 772         [Qt] Fix the timeout of fast/frames/frame-navigation.html
 773         https://bugs.webkit.org/show_bug.cgi?id=31638
 774
 775         The test is timeouting, because it uses the WorkQueue to load a document in one
 776         of the child frames and once the loading is finished, the DRT does not dump the
 777         tree. This is because it waits for the QWebFrame::loadFinished() signal from
 778         the main frame, while it should connect to QWebPage::loadFinished().
 779
 780         * DumpRenderTree/qt/DumpRenderTree.cpp:
 781         (WebCore::DumpRenderTree::DumpRenderTree):
 782
 783 2009-11-21  Eric Seidel  <eric@webkit.org>
 784
 785         Reviewed by Adam Barth.
 786
 787         bugzilla-tool --help spews way too much text
 788         https://bugs.webkit.org/show_bug.cgi?id=31771
 789
 790         * Scripts/bugzilla-tool:
 791          - Remove self.cached_scm initialization hack.
 792         * Scripts/modules/buildbot.py:
 793          - Make default_host accessible to callers.
 794         * Scripts/modules/commands/download.py:
 795          - Phrase help for all commands consistently and remove spurious help text punctuation.
 796         * Scripts/modules/commands/queries.py: Ditto.
 797         * Scripts/modules/commands/queues.py: Ditto.
 798         * Scripts/modules/commands/upload.py: Ditto.
 799         * Scripts/modules/multicommandtool.py:
 800          - Add HelpPrintingOptionParser.format_epilog to replace
 801            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
 802            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
 803          - Make --help only show a list of commands like "svn help" and "git help" do --
 804            previously --help was listing all commands and options.
 805          - Sort list of commands alphabetically.
 806
 807 2009-11-21  Eric Seidel  <eric@webkit.org>
 808
 809         No review.  Fixing a typo from the previous patch for bug 31767.
 810
 811         AbstractQueue.run_bugzilla_tool throws an exception
 812         https://bugs.webkit.org/show_bug.cgi?id=31769
 813
 814         * Scripts/modules/commands/queues.py:
 815
 816 2009-11-21  Eric Seidel  <eric@webkit.org>
 817
 818         Reviewed by Adam Barth.
 819
 820         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
 821         https://bugs.webkit.org/show_bug.cgi?id=31767
 822
 823         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
 824         Since we don't have a good way to test BugzillaTool pieces, I've
 825         left out a test for now.
 826
 827         * Scripts/bugzilla-tool:
 828          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
 829         * Scripts/modules/commands/queues.py:
 830          - Use tool.path() instead of __file__.
 831         * Scripts/modules/multicommandtool.py:
 832          - Add a new path() method to MultiComandTool.
 833         * Scripts/modules/multicommandtool_unittest.py:
 834          - Provide a path() method.  Little point in testing this mock implementation.
 835
 836 2009-11-21  Adam Barth  <abarth@webkit.org>
 837
 838         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
 839         WebKitTools.
 840
 841         * Scripts/modules/commands/download.py:
 842
 843 2009-11-21  Adam Barth  <abarth@webkit.org>
 844
 845         Reviewed by Eric Seidel.
 846
 847         Convert check-style to use LandingSequence
 848         https://bugs.webkit.org/show_bug.cgi?id=31763
 849
 850         Instead of manipulating the working copy by hand, we should use the
 851         LandingSequence in CheckStyle.  This will make this code eaiser to
 852         test.
 853
 854         * Scripts/modules/commands/download.py:
 855
 856 2009-11-20  Adam Barth  <abarth@webkit.org>
 857
 858         Reviewed by Eric Seidel.
 859
 860         Unit test query commands
 861         https://bugs.webkit.org/show_bug.cgi?id=31755
 862
 863         These tests are pretty rough, but hopefully they'll grow.
 864
 865         * Scripts/modules/commands/queries_unittest.py: Added.
 866         * Scripts/modules/mock_bugzillatool.py: Added.
 867         * Scripts/run-webkit-unittests:
 868
 869 2009-11-20  Eric Seidel  <eric@webkit.org>
 870
 871         Reviewed by Adam Barth.
 872
 873         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
 874         https://bugs.webkit.org/show_bug.cgi?id=31758
 875
 876         * Scripts/modules/multicommandtool.py:
 877          - Allow passing of explicit commands to MultiCommandTool.__init__
 878         * Scripts/modules/multicommandtool_unittest.py:
 879          - Use new Command.name naming system.
 880          - Test Command auto-discovery.
 881         * Scripts/modules/workqueue.py:
 882          - bug_id no longer exists, use patch['bug_id'] instead.
 883         * Scripts/modules/workqueue_unittest.py:
 884          - WorkQueues require names now.
 885          - should_proceed_with_work_item must return a patch object.
 886
 887 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
 888
 889         Reviewed by Beth Dakin.
 890
 891         WAI-ARIA: add support for aria-owns
 892         https://bugs.webkit.org/show_bug.cgi?id=31702
 893
 894         * DumpRenderTree/AccessibilityUIElement.cpp:
 895         (ariaOwnsElementAtIndexCallback):
 896         (AccessibilityUIElement::getJSClass):
 897         * DumpRenderTree/AccessibilityUIElement.h:
 898         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 899         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 900         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 901         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 902         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 903         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 904
 905 2009-11-20  Eric Seidel  <eric@webkit.org>
 906
 907         Reviewed by Adam Barth.
 908
 909         Fix exception thrown when running the commit-queue.
 910
 911         * Scripts/modules/statusbot.py: patch is optional.
 912         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
 913
 914 2009-11-20  Eric Seidel  <eric@webkit.org>
 915
 916         Reviewed by Adam Barth.
 917
 918         Teach the StatusBot how to support more than just the commit-queue
 919         https://bugs.webkit.org/show_bug.cgi?id=31754
 920
 921         * Scripts/modules/workqueue.py: Another typo.
 922
 923 2009-11-20  Eric Seidel  <eric@webkit.org>
 924
 925         Reviewed by Adam Barth.
 926
 927         Teach the StatusBot how to support more than just the commit-queue
 928         https://bugs.webkit.org/show_bug.cgi?id=31754
 929
 930         * Scripts/modules/commands/queues.py: Fix silly typo.
 931
 932 2009-11-20  Eric Seidel  <eric@webkit.org>
 933
 934         Reviewed by Adam Barth.
 935
 936         Teach the StatusBot how to support more than just the commit-queue
 937         https://bugs.webkit.org/show_bug.cgi?id=31754
 938
 939         * CommitQueueStatus/index.yaml:
 940          - Add indices required for the new queries.
 941         * CommitQueueStatus/queue_status.py:
 942          - Add a patch-status page and move update_status to update-status.
 943          - Only display "commit-queue" status records for the commit-queue.
 944          - Add support for a queue_name property on status records.
 945          - Fix _int_from_request to actually work.
 946         * CommitQueueStatus/update_status.html:
 947          - Add support for a queue_name on status records.
 948          - Remove unused list of bug ids.
 949          * Scripts/modules/commands/queues.py
 950           - Make the queues pass the patch instead of the bug_id to StatusBot.
 951         * Scripts/modules/statusbot.py:
 952          - Support passing the queue_name to the status updates.
 953          - Support fetching patch status with patch_status().
 954         * Scripts/modules/workqueue.py:
 955          - Pass the patch to the StatusBot instead of the bug_id.
 956          - Let WorkQueues have a name.
 957
 958 2009-11-20  Adam Barth  <abarth@webkit.org>
 959
 960         Reviewed by Eric Seidel.
 961
 962         Move bugzilla-tool commands into their own file
 963         https://bugs.webkit.org/show_bug.cgi?id=31752
 964
 965         This will let us write unit tests.
 966
 967         * Scripts/bugzilla-tool:
 968         * Scripts/modules/commands/__init__.py: Added.
 969         * Scripts/modules/commands/download.py: Added.
 970         * Scripts/modules/commands/queries.py: Added.
 971         * Scripts/modules/commands/queues.py: Added.
 972         * Scripts/modules/commands/upload.py: Added.
 973         * Scripts/modules/grammar.py: Added.
 974
 975 2009-11-20  Adam Barth  <abarth@webkit.org>
 976
 977         Reviewed by Eric Seidel.
 978
 979         BuildQueue should check if the tree is currently buildable
 980         https://bugs.webkit.org/show_bug.cgi?id=31744
 981
 982         * Scripts/bugzilla-tool:
 983         * Scripts/modules/landingsequence.py:
 984         * Scripts/modules/webkitlandingscripts.py:
 985
 986 2009-11-20  Adam Barth  <abarth@webkit.org>
 987
 988         Reviewed by Eric Seidel.
 989
 990         Move prepare_clean_working_directory into the LandingSequence
 991         https://bugs.webkit.org/show_bug.cgi?id=31743
 992
 993         * Scripts/bugzilla-tool:
 994         * Scripts/modules/landingsequence.py:
 995
 996 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
 997
 998         Reviewed by Kenneth Rohde Christiansen.
 999
1000         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
1001         https://bugs.webkit.org/show_bug.cgi?id=30460
1002
1003         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
1004
1005         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1006         (pluginInvoke):
1007
1008 2009-11-20  Adam Barth  <abarth@webkit.org>
1009
1010         Reviewed by Eric Seidel.
1011
1012         Pass the port information to the child process
1013         https://bugs.webkit.org/show_bug.cgi?id=31736
1014
1015         We need to do this so the child process knows what to build!
1016
1017         * Scripts/bugzilla-tool:
1018         * Scripts/modules/landingsequence.py:
1019         * Scripts/modules/webkitport.py:
1020         * Scripts/modules/webkitport_unittest.py:
1021
1022 2009-11-20  Adam Barth  <abarth@webkit.org>
1023
1024         Reviewed by Eric Seidel.
1025
1026         Support Qt port in build-queue
1027         https://bugs.webkit.org/show_bug.cgi?id=31733
1028
1029         * Scripts/bugzilla-tool:
1030
1031 2009-11-20  Adam Barth  <abarth@webkit.org>
1032
1033         Reviewed by Eric Seidel.
1034
1035         Implement a build-queue
1036         https://bugs.webkit.org/show_bug.cgi?id=31725
1037
1038         Currently this just builds the first 10 patches in the review queue.
1039         We'll want to do something smarter soon.
1040
1041         * Scripts/bugzilla-tool:
1042
1043 2009-11-20  Adam Barth  <abarth@webkit.org>
1044
1045         Reviewed by Eric Seidel.
1046
1047         Make commit-queue and style-queue show up in help
1048         https://bugs.webkit.org/show_bug.cgi?id=31724
1049
1050         We need to store their names on their class to make these commands
1051         properly register themselves with MultiCommandTool.
1052
1053         * Scripts/bugzilla-tool:
1054
1055 2009-11-20  Adam Barth  <abarth@webkit.org>
1056
1057         Reviewed by Eric Seidel.
1058
1059         Implement bugzilla-tool build-attachment
1060         https://bugs.webkit.org/show_bug.cgi?id=31722
1061
1062         This command builds an attachment from bugzilla.  It leaves the built
1063         patch in the working copy.
1064
1065         * Scripts/bugzilla-tool:
1066         * Scripts/modules/landingsequence.py:
1067         * Scripts/modules/webkitlandingscripts.py:
1068
1069 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
1070
1071         Reviewed by Xan Lopez.
1072
1073         [GTK] DRT release event does not create the state correctly
1074         https://bugs.webkit.org/show_bug.cgi?id=31717
1075
1076         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1077
1078 2009-11-20  Eric Seidel  <eric@webkit.org>
1079
1080         Reviewed by Adam Barth.
1081
1082         MultiCommandTool should find Command objects automatically instead of with a manual list
1083         https://bugs.webkit.org/show_bug.cgi?id=31710
1084
1085         * Scripts/bugzilla-tool:
1086         * Scripts/modules/multicommandtool.py:
1087          - Use some wild python-fu to crawl all the known subclasses of Command.
1088
1089 2009-11-20  Adam Barth  <abarth@webkit.org>
1090
1091         Unreviewed "build" fix.  Added missing import.
1092
1093         * Scripts/bugzilla-tool:
1094
1095 2009-11-20  Adam Barth  <abarth@webkit.org>
1096
1097         Unreviewed "build" fix.  I failed to update LandingSequence.test
1098         properly.
1099
1100         * Scripts/modules/landingsequence.py:
1101
1102 2009-11-20  Adam Barth  <abarth@webkit.org>
1103
1104         Reviewed by Eric Seidel.
1105
1106         Create LandingSequence as the all-sing, all-dance landing class
1107         https://bugs.webkit.org/show_bug.cgi?id=31709
1108
1109         Client can inherit from this class to carefully control exactly which
1110         steps they wish to have happen in the landing sequence.
1111
1112         * Scripts/bugzilla-tool:
1113         * Scripts/modules/landingsequence.py: Added.
1114         * Scripts/modules/webkitlandingscripts.py: Added.
1115
1116 2009-11-19  Adam Barth  <abarth@webkit.org>
1117
1118         Reviewed by Eric Seidel.
1119
1120         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
1121         https://bugs.webkit.org/show_bug.cgi?id=31707
1122
1123         This is to help when we implement build-attachment.
1124
1125         * Scripts/bugzilla-tool:
1126
1127 2009-11-19  Adam Barth  <abarth@webkit.org>
1128
1129         Reviewed by Eric Seidel.
1130
1131         Support Qt port in bugzilla-tool
1132         https://bugs.webkit.org/show_bug.cgi?id=31701
1133
1134         Now we support building with Qt!
1135
1136         * Scripts/bugzilla-tool:
1137         * Scripts/modules/webkitport.py: Added.
1138         * Scripts/modules/webkitport_unittest.py: Added.
1139         * Scripts/run-webkit-unittests:
1140
1141 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
1142
1143         Reviewed by Adam Barth.
1144
1145         Remove inserting stderr into patch in bugzilla-tool
1146         https://bugs.webkit.org/show_bug.cgi?id=29914
1147
1148         Modify SCM python module's run_command function to avoid return of stderr
1149         by default, so stderr won't be inserted into the patches.
1150         Modify the related unit test.
1151
1152         * Scripts/modules/scm.py:
1153         * Scripts/modules/scm_unittest.py:
1154
1155 2009-11-19  Eric Seidel  <eric@webkit.org>
1156
1157         Reviewed by Adam Barth.
1158
1159         bugzilla-tool needs per-command help
1160         https://bugs.webkit.org/show_bug.cgi?id=31697
1161
1162         Added support for "bugzilla-tool help command-name"
1163         and a unit test to make sure it works.
1164
1165         * Scripts/modules/multicommandtool.py:
1166         * Scripts/modules/multicommandtool_unittest.py:
1167
1168 2009-11-19  Eric Seidel  <eric@webkit.org>
1169
1170         Reviewed by Adam Barth.
1171
1172         Move MultiCommandTool and Command into a separate file and add some basic unit tests
1173         https://bugs.webkit.org/show_bug.cgi?id=31695
1174
1175         * Scripts/bugzilla-tool:
1176         * Scripts/modules/multicommandtool.py: Added.
1177         * Scripts/modules/multicommandtool_unittest.py: Added.
1178         * Scripts/run-webkit-unittests:
1179
1180 2009-11-19  Eric Seidel  <eric@webkit.org>
1181
1182         No review, just adding a FIXME.
1183
1184         Split out command parsing and help printing from BugzillaTool
1185         https://bugs.webkit.org/show_bug.cgi?id=31688
1186
1187         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
1188
1189 2009-11-19  Eric Seidel  <eric@webkit.org>
1190
1191         Reviewed by Adam Barth.
1192
1193         Split out command parsing and help printing from BugzillaTool
1194         https://bugs.webkit.org/show_bug.cgi?id=31688
1195
1196         * Scripts/bugzilla-tool:
1197          - Add new MultiCommandTool class to contain option parsing and help printing logic.
1198          - Rename private methods to use _ pattern.
1199          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
1200          -
1201
1202 2009-11-19  Eric Seidel  <eric@webkit.org>
1203
1204         Reviewed by Adam Barth.
1205
1206         Re-factor help printing to use modern python idioms
1207         https://bugs.webkit.org/show_bug.cgi?id=31685
1208
1209         * Scripts/bugzilla-tool:
1210
1211 2009-11-19  Eric Seidel  <eric@webkit.org>
1212
1213         Reviewed by Darin Adler.
1214
1215         commit-queue empty queue logs twice
1216         https://bugs.webkit.org/show_bug.cgi?id=31679
1217
1218         * Scripts/bugzilla-tool:
1219
1220 2009-11-19  Eric Seidel  <eric@webkit.org>
1221
1222         Reviewed by Darin Adler.
1223
1224         bugzilla-tool's reviewer/committer rejection message should be clearer
1225         https://bugs.webkit.org/show_bug.cgi?id=31126
1226
1227         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
1228
1229         * Scripts/modules/bugzilla.py:
1230
1231 2009-11-19  Eric Z. Ayers  <zundel@google.com>
1232
1233         Reviewed by Pavel Feldman.
1234
1235         Forces a WM_PAINT event on calling layoutTestController.display()
1236         in order to enable the timeline-paint.html test on Windows.
1237         ::UpdateWindow() does not force an event becaue the window is
1238         not visible.
1239
1240         https://bugs.webkit.org/show_bug.cgi?id=31402
1241
1242         * DumpRenderTree/win/DumpRenderTree.cpp:
1243         (displayWebView):
1244
1245 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
1246
1247         No review needed.
1248
1249         Added myself to committers list.
1250
1251         * Scripts/modules/committers.py:
1252
1253 2009-11-19  Adam Barth  <abarth@webkit.org>
1254
1255         Reviewed by Eric Seidel.
1256
1257         Bugzilla-tool command classes should match command names
1258         https://bugs.webkit.org/show_bug.cgi?id=31666
1259
1260         I renamed all the commands except CommitMessageForCurrentDiff because
1261         the new name would conflict with an existing class.
1262
1263         * Scripts/bugzilla-tool:
1264
1265 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
1266
1267         Reviewed by Gustavo Noronha Silva.
1268
1269         Web Inspector: Implement "show inspector" in WebKit GTK
1270         API and enable console tests.
1271
1272         https://bugs.webkit.org/show_bug.cgi?id=31669
1273
1274         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1275         (LayoutTestController::showWebInspector):
1276
1277 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1278
1279         Reviewed by Simon Hausmann.
1280
1281         Minor refactoring + more documentation.
1282
1283         * DumpRenderTree/qt/DumpRenderTree.cpp:
1284         (WebCore::clearHistory):
1285         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1286
1287 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
1288
1289         Reviewed by Eric Seidel.
1290
1291         Ignore websocket tests when --no-http is specified.
1292         https://bugs.webkit.org/show_bug.cgi?id=31662
1293
1294         * Scripts/run-webkit-tests:
1295
1296 2009-11-18  Adam Barth  <abarth@webkit.org>
1297
1298         Reviewed by Eric Seidel.
1299
1300         Normalize ' and " in bugzilla-tool
1301         https://bugs.webkit.org/show_bug.cgi?id=31655
1302
1303         We decided " is better than ' and we should be consistent.
1304
1305         * Scripts/bugzilla-tool:
1306
1307 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1308
1309         Reviewed by Kenneth Rohde Christiansen.
1310
1311         [Qt] Remove support for Qt v4.3 or older versions
1312         https://bugs.webkit.org/show_bug.cgi?id=29469
1313
1314         * DumpRenderTree/qt/DumpRenderTree.pro:
1315         * DumpRenderTree/qt/ImageDiff.pro:
1316
1317 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1318
1319         Reviewed by Eric Seidel.
1320
1321         GitTest.test_create_binary_patch fails if /tmp is symlink
1322         https://bugs.webkit.org/show_bug.cgi?id=31536
1323
1324         * Scripts/modules/scm_unittest.py:
1325
1326 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
1327
1328         Reviewed by Darin Adler.
1329
1330         Configuration for Chromium Build Slaves.
1331
1332         https://bugs.webkit.org/show_bug.cgi?id=31442
1333
1334         * BuildSlaveSupport/build.webkit.org-config/config.json:
1335         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1336
1337 2009-11-18  Eric Seidel  <eric@webkit.org>
1338
1339         Reviewed by Darin Adler.
1340
1341         workqueue.py results in totally broken commit-queue UI
1342         https://bugs.webkit.org/show_bug.cgi?id=31645
1343
1344         * Scripts/bugzilla-tool:
1345          - Remove unneeded use of PatchCollection.
1346          - Grab a new copy of the cq'd patches every run of the queue.
1347
1348 2009-11-18  Sam Weinig  <sam@webkit.org>
1349
1350         Reviewed by Anders Carlsson.
1351
1352         Make the Mac Geolocation API async.
1353
1354         Update DRT to use the new async Mac Geolocation API.
1355
1356         * DumpRenderTree/mac/UIDelegate.mm:
1357         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1358
1359 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1360
1361         Reviewed by Kenneth Rohde Christiansen.
1362
1363         Add and option to toggle HTML5 datalist support to build-webkit
1364         https://bugs.webkit.org/show_bug.cgi?id=31599
1365
1366         * Scripts/build-webkit:
1367
1368 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1369
1370         Reviewed by Kevin Ollivier.
1371
1372         Enable wx plugin support using the Windows implementation as a base.
1373
1374         https://bugs.webkit.org/show_bug.cgi?id=31636
1375
1376         * wx/build/settings.py:
1377
1378 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1379
1380         Reviewed by Simon Hausmann.
1381
1382         Change the initialization order so that the controllers
1383         will be created before exporting them to the JS DOM window.
1384
1385         * DumpRenderTree/qt/DumpRenderTree.cpp:
1386         (WebCore::DumpRenderTree::DumpRenderTree):
1387
1388 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1389
1390         Reviewed by Simon Hausmann.
1391
1392         Fix a code copy and paste error. m_page should be page.
1393
1394         * DumpRenderTree/qt/DumpRenderTree.cpp:
1395         (WebCore::DumpRenderTree::createWindow):
1396
1397 2009-11-17  Mark Rowe  <mrowe@apple.com>
1398
1399         Reviewed by Alexey Proskuryakov.
1400
1401         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
1402
1403         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
1404         This prevents symlinks from confusing the descendant check.
1405
1406 2009-11-17  Mark Rowe  <mrowe@apple.com>
1407
1408         Reviewed by Alexey Proskuryakov.
1409
1410         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
1411
1412         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
1413         server to be up rather than having run-webkit-tests abort immediately.
1414
1415         * Scripts/run-webkit-tests:
1416
1417 2009-11-17  Eric Seidel  <eric@webkit.org>
1418
1419         Reviewed by Darin Adler.
1420
1421         commit-queue is failing to set reviewer in ChangeLogs
1422         https://bugs.webkit.org/show_bug.cgi?id=31592
1423
1424         * Scripts/bugzilla-tool: Clarify the "applying" log message.
1425         * Scripts/modules/bugzilla.py:
1426          - Add a new _validate_committer_and_reviewer function as a
1427            temporary solution until we can make a real Attachment object
1428            which knows how to fill in its committer/reviewer fields automatically.
1429
1430 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1431
1432         Unreviewed buildbot fix.
1433
1434         Revert part of earlier patch and add comment, as it
1435         was causing timeouts on the buildbot.
1436
1437         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1438         (LayoutTestController::notifyDone):
1439
1440 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1441
1442         Reviewed by Oliver Hunt.
1443
1444         Make the timeout 15 sec as for the other DRT's and make
1445         it print out the same output when a test timeout.
1446
1447         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1448         (LayoutTestController::waitUntilDone):
1449         (LayoutTestController::notifyDone):
1450         (LayoutTestController::timerEvent):
1451
1452 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
1453
1454         Reviewed by Timothy Hatcher.
1455
1456         Fixed typos in comments.
1457
1458         * Scripts/modules/committers.py:
1459
1460 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
1461
1462         Reviewed by Timothy Hatcher.
1463
1464         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1465         - Updated DRT to show/close inspector for all tests under /inspector
1466         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1467           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1468         - Removed reload on each inspector test
1469         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1470         inspector for those.
1471         - Reimplemented timeline tests in order to get rid of reload there.
1472         - Moved tests that don't require harness into the fast group.
1473
1474         https://bugs.webkit.org/show_bug.cgi?id=31472
1475
1476         * DumpRenderTree/LayoutTestController.cpp:
1477         (setTimelineProfilingEnabledCallback):
1478         (closeWebInspectorCallback):
1479         (LayoutTestController::staticFunctions):
1480         * DumpRenderTree/LayoutTestController.h:
1481         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1482         (shouldOpenWebInspector):
1483         (runTest):
1484         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1485         (LayoutTestController::setTimelineProfilingEnabled):
1486         * DumpRenderTree/mac/DumpRenderTree.mm:
1487         (shouldOpenWebInspector):
1488         (runTest):
1489         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1490         (LayoutTestController::setTimelineProfilingEnabled):
1491         * DumpRenderTree/win/DumpRenderTree.cpp:
1492         (shouldOpenWebInspector):
1493         (runTest):
1494         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1495         (LayoutTestController::setTimelineProfilingEnabled):
1496
1497 2009-11-17  Oliver Hunt  <oliver@apple.com>
1498
1499         Reviewed by Maciej Stachowiak.
1500
1501         Incorrect use of JavaScriptCore API in DumpRenderTree
1502         https://bugs.webkit.org/show_bug.cgi?id=31577
1503
1504         Return undefined rather than a literal null.
1505
1506         * DumpRenderTree/AccessibilityUIElement.cpp:
1507         (setSelectedTextRangeCallback):
1508         (incrementCallback):
1509         (decrementCallback):
1510         (showMenuCallback):
1511
1512 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1513
1514         Reviewed by Beth Dakin.
1515
1516         AX: aria-labelledby duplicates some of its WAI-ARIA label
1517         https://bugs.webkit.org/show_bug.cgi?id=31565
1518
1519         * DumpRenderTree/AccessibilityUIElement.cpp:
1520         (titleUIElementCallback):
1521         (getIsValidCallback):
1522         (AccessibilityUIElement::getJSClass):
1523
1524 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1525
1526         Reviewed by Simon Hausmann.
1527
1528         r50942 broke output from created windows. Make the
1529         m_enableTextOutput a member of the DRT and not the
1530         WebPage.
1531
1532         * DumpRenderTree/qt/DumpRenderTree.cpp:
1533         (WebCore::WebPage::WebPage):
1534         (WebCore::WebPage::javaScriptAlert):
1535         (WebCore::WebPage::javaScriptConsoleMessage):
1536         (WebCore::WebPage::javaScriptConfirm):
1537         (WebCore::WebPage::javaScriptPrompt):
1538         (WebCore::WebPage::acceptNavigationRequest):
1539         (WebCore::DumpRenderTree::DumpRenderTree):
1540         (WebCore::DumpRenderTree::open):
1541         (WebCore::DumpRenderTree::createWindow):
1542         * DumpRenderTree/qt/DumpRenderTree.h:
1543         (WebCore::DumpRenderTree::setTextOutputEnabled):
1544         (WebCore::DumpRenderTree::isTextOutputEnabled):
1545         (WebCore::WebPage::shouldInterruptJavaScript):
1546         (WebCore::WebPage::isTextOutputEnabled):
1547         (WebCore::WebPage::setViewGeometry):
1548
1549 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1550
1551         Reviewed by Gustavo Noronha Silva.
1552
1553         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
1554         as the implementation is being used by at least Qt and Gtk+.
1555
1556         Update buildsystems as well.
1557
1558         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1559         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1560         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1561         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1562         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1563         * GNUmakefile.am:
1564
1565 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
1566
1567         Reviewed by Alexey Proskuryakov.
1568
1569         Disable wss until all platforms support pyOpenSSL
1570
1571         https://bugs.webkit.org/show_bug.cgi?id=31479
1572
1573         * Scripts/run-webkit-tests:
1574
1575 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1576
1577         Reviewed by Kenneth Christiansen.
1578
1579         [Qt] Implement load error pages support for Qt's DRT.
1580         https://bugs.webkit.org/show_bug.cgi?id=31509
1581
1582         For now, it will not be a default feature, and layout tests
1583         that want to make use of this have to explicitily call
1584         'handleErrorPages();' for the test source.
1585
1586         Any of the other DumpRenderTree's (mac, win and gtk)
1587         support handling error pages. Qt's will be the first.
1588
1589         * DumpRenderTree/qt/DumpRenderTree.cpp:
1590         (WebCore::WebPage::supportsExtension):
1591         (WebCore::WebPage::extension):
1592         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1593         (LayoutTestController::reset):
1594         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1595         (LayoutTestController::shouldHandleErrorPages):
1596         (LayoutTestController::handleErrorPages):
1597
1598 2009-11-16  Eric Seidel  <eric@webkit.org>
1599
1600         Reviewed by Adam Barth.
1601
1602         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1603         https://bugs.webkit.org/show_bug.cgi?id=31549
1604
1605         Renamed --commit-queue to --non-interactive in most places
1606         and remove the code in land-patches which is no longer needed.
1607
1608         * Scripts/bugzilla-tool:
1609
1610 2009-11-16  Eric Seidel  <eric@webkit.org>
1611
1612         Reviewed by Adam Barth.
1613
1614         The commit-queue should use land-attachment
1615         https://bugs.webkit.org/show_bug.cgi?id=31548
1616
1617         * Scripts/bugzilla-tool:
1618
1619 2009-11-16  Adam Barth  <abarth@webkit.org>
1620
1621         Reviewed by Eric Seidel.
1622
1623         Convert CommitQueue over to PatchCollection
1624         https://bugs.webkit.org/show_bug.cgi?id=31547
1625
1626         Also fixes a bug in workqueue and adds a test!
1627
1628         * Scripts/bugzilla-tool:
1629         * Scripts/modules/workqueue.py:
1630         * Scripts/modules/workqueue_unittest.py:
1631
1632 2009-11-16  Adam Barth  <abarth@webkit.org>
1633
1634         Reviewed by Eric Seidel.
1635
1636         Move StyleQueue over to using PatchCollection
1637         https://bugs.webkit.org/show_bug.cgi?id=31544
1638
1639         That's what the class it's for.
1640
1641         * Scripts/bugzilla-tool:
1642         * Scripts/modules/patchcollection.py:
1643         * Scripts/modules/patchcollection_unittest.py:
1644
1645 2009-11-16  Eric Seidel  <eric@webkit.org>
1646
1647         Reviewed by Adam Barth.
1648
1649         bugzilla-tool needs a land-attachment command
1650         https://bugs.webkit.org/show_bug.cgi?id=31546
1651
1652         * Scripts/bugzilla-tool:
1653          - Move all the logic into AbstractLandingCommand and
1654            add a new LandAttachment command subclass.
1655          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1656
1657 2009-11-16  Eric Seidel  <eric@webkit.org>
1658
1659         Reviewed by Adam Barth.
1660
1661         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1662         https://bugs.webkit.org/show_bug.cgi?id=31543
1663
1664         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1665
1666         * Scripts/bugzilla-tool:
1667
1668 2009-11-16  Eric Seidel  <eric@webkit.org>
1669
1670         Reviewed by Adam Barth.
1671
1672         Disable the style queue from posting to the commit queue status page.
1673
1674         * Scripts/bugzilla-tool:
1675
1676 2009-11-16  Adam Barth  <abarth@webkit.org>
1677
1678         Reviewed by Eric Seidel.
1679
1680         Implement PatchCollection
1681         https://bugs.webkit.org/show_bug.cgi?id=31541
1682
1683         This class holds a set of patches and lets clients iterate through
1684         them.  Optionally, clients can install a filter.
1685
1686         * Scripts/modules/patchcollection.py: Added.
1687         * Scripts/modules/patchcollection_unittest.py: Added.
1688         * Scripts/run-webkit-unittests:
1689
1690 2009-11-16  Eric Seidel  <eric@webkit.org>
1691
1692         Reviewed by Adam Barth.
1693
1694         bugzilla-tool land-patches will close bugs with patches r=?
1695         https://bugs.webkit.org/show_bug.cgi?id=28230
1696
1697         The commit-queue shouldn't close patches with outstanding reviews on them,
1698         even if many reviewers seem to be against multi-patch bugs.
1699
1700         * Scripts/bugzilla-tool:
1701
1702 2009-11-16  Eric Seidel  <eric@webkit.org>
1703
1704         Reviewed by Adam Barth.
1705
1706         bugzilla-tool check-style should work with attachment ids instead of bug ids
1707         https://bugs.webkit.org/show_bug.cgi?id=31540
1708
1709         * Scripts/bugzilla-tool:
1710
1711 2009-11-16  Eric Seidel  <eric@webkit.org>
1712
1713         Reviewed by Adam Barth.
1714
1715         WorkQueue is the only place that should know about special exit codes
1716         https://bugs.webkit.org/show_bug.cgi?id=31534
1717
1718         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1719         and add tests for handling exit codes.
1720         I also cleaned up workqueue_unittest.py more.
1721
1722         * Scripts/bugzilla-tool:
1723         * Scripts/modules/workqueue.py:
1724         * Scripts/modules/workqueue_unittest.py:
1725
1726 2009-11-16  Eric Seidel  <eric@webkit.org>
1727
1728         Reviewed by Adam Barth.
1729
1730         Re-factor workqueue_unittest to allow for more than one test.
1731         https://bugs.webkit.org/show_bug.cgi?id=31535
1732
1733         * Scripts/modules/workqueue_unittest.py:
1734
1735 2009-11-16  Eric Seidel  <eric@webkit.org>
1736
1737         Reviewed by Adam Barth.
1738
1739         land-patches needs to be re-factored into smaller chunks
1740         https://bugs.webkit.org/show_bug.cgi?id=31532
1741
1742         * Scripts/bugzilla-tool: fix a couple obvious typos.
1743
1744 2009-11-16  Eric Seidel  <eric@webkit.org>
1745
1746         Reviewed by Adam Barth.
1747
1748         land-patches needs to be re-factored into smaller chunks
1749         https://bugs.webkit.org/show_bug.cgi?id=31532
1750
1751         The next patch will move these methods into WebKitLandingScripts.
1752
1753         * Scripts/bugzilla-tool:
1754          - Split out _land_patch and _close_bug_if_no_active_patches.
1755
1756 2009-11-16  Adam Barth  <abarth@webkit.org>
1757
1758         Reviewed by Eric Seidel.
1759
1760         Fix silly copy-and-paste code.  I am a terrible coder.
1761
1762         * Scripts/modules/bugzilla.py:
1763
1764 2009-11-16  Adam Barth  <abarth@webkit.org>
1765
1766         Reviewed by Eric Seidel.
1767
1768         Implement a StyleQueue
1769         https://bugs.webkit.org/show_bug.cgi?id=31537
1770
1771         The first iteration of the style queue only produces output locally.
1772         There is also a limit of 10 patches because it's not that useful to
1773         iterate through the entire review queue at this point.  We can remove
1774         the limit later.
1775
1776         * Scripts/bugzilla-tool:
1777         * Scripts/modules/bugzilla.py:
1778
1779 2009-11-16  Adam Barth  <abarth@webkit.org>
1780
1781         Reviewed by Eric Seidel.
1782
1783         Unit test WorkQueue
1784         https://bugs.webkit.org/show_bug.cgi?id=31531
1785
1786         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1787
1788         * Scripts/bugzilla-tool:
1789         * Scripts/modules/statusbot.py:
1790         * Scripts/modules/workqueue.py:
1791         * Scripts/modules/workqueue_unittest.py: Added.
1792         * Scripts/run-webkit-unittests:
1793
1794 2009-11-16  Eric Seidel  <eric@webkit.org>
1795
1796         Reviewed by Adam Barth.
1797
1798         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1799         https://bugs.webkit.org/show_bug.cgi?id=31530
1800
1801         * Scripts/bugzilla-tool:
1802
1803 2009-11-16  Eric Seidel  <eric@webkit.org>
1804
1805         Reviewed by Adam Barth.
1806
1807         bugzilla-tool needs apply-attachment
1808         https://bugs.webkit.org/show_bug.cgi?id=31528
1809
1810         * Scripts/bugzilla-tool:
1811          - Add ApplyAttachment command.
1812          - Abstract applying code into WebKitApplyingScripts.
1813          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1814         * Scripts/modules/bugzilla.py:
1815          - Add fetch_attachment and bug_id_for_attachment_id.
1816         * Scripts/modules/bugzilla_unittest.py:
1817          - Add test for new parsing.
1818          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1819
1820 2009-11-16  Eric Seidel  <eric@webkit.org>
1821
1822         Reviewed by Adam Barth.
1823
1824         Document check-style's use of force_clean.
1825
1826         * Scripts/bugzilla-tool:
1827         * Scripts/modules/scm.py:
1828
1829 2009-11-16  Adam Barth  <abarth@webkit.org>
1830
1831         Reviewed by Eric Seidel.
1832
1833         Move WorkQueue to its own file
1834         https://bugs.webkit.org/show_bug.cgi?id=31529
1835
1836         WorkQueue and WorkQueueDelegate are separate concerns from
1837         bugzilla-tool.  Also added a missing include to logging.py.
1838
1839         * Scripts/bugzilla-tool:
1840         * Scripts/modules/logging.py:
1841         * Scripts/modules/workqueue.py:
1842
1843 2009-11-16  Adam Barth  <abarth@webkit.org>
1844
1845         Reviewed by Eric Seidel.
1846
1847         Move OutputTee to logging.py.
1848
1849         * Scripts/bugzilla-tool:
1850         * Scripts/modules/logging.py:
1851
1852 2009-11-15  Adam Barth  <abarth@webkit.org>
1853
1854         Reviewed by Eric Seidel.
1855
1856         Refactor bugzilla-tool to allow for multiple queues
1857         https://bugs.webkit.org/show_bug.cgi?id=31513
1858
1859         Divide the commit queue class into three class to make creating
1860         additional queues easier.
1861
1862         * Scripts/bugzilla-tool:
1863
1864 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1865
1866         Reviewed by Eric Seidel.
1867
1868         svn-apply may not handle git patches created by bugzilla-tool
1869         https://bugs.webkit.org/show_bug.cgi?id=31457
1870
1871         * Scripts/modules/scm.py:
1872         * Scripts/modules/scm_unittest.py:
1873
1874 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1875
1876         Reviewed by Eric Seidel.
1877
1878         bugzilla-tool should post git binary diff
1879         https://bugs.webkit.org/show_bug.cgi?id=31458
1880
1881         Add --binary option to Git.create_patch.
1882
1883         * Scripts/modules/scm.py:
1884         * Scripts/modules/scm_unittest.py:
1885
1886 2009-11-15  Adam Barth  <abarth@webkit.org>
1887
1888         Reviewed by Darin Adler.
1889
1890         Add bugzilla-tool check-style
1891         https://bugs.webkit.org/show_bug.cgi?id=31515
1892
1893         * Scripts/bugzilla-tool:
1894         * Scripts/modules/bugzilla.py:
1895
1896 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1897
1898         Reviewed by Simon Hausmann.
1899
1900         Make the Qt Linux only --valgrind feature, suppress errors
1901         defined in the SuppressedValgrindErrors file.
1902
1903         * Scripts/run-webkit-tests:
1904
1905 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1906
1907         Reviewed by Simon Hausmann.
1908
1909         Set the locale to C and not to the current one in use on the system.
1910
1911         * DumpRenderTree/qt/DumpRenderTree.cpp:
1912         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1913
1914 2009-11-13  Adam Roben  <aroben@apple.com>
1915
1916         Add support for
1917         http/tests/security/isolatedWorld/didClearWindowObject.html
1918
1919         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1920         window objects in isolated worlds are cleared
1921
1922         Reviewed by Dave Hyatt.
1923
1924         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1925
1926         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1927         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1928         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1929         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1930         Added. Sets a __worldID property on the global object whose value is
1931         the ID of this world.
1932         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1933         Respond to this new delegate callback by calling through to one of the
1934         above new methods.
1935         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1936         (worldMap): Added. Returns a HashMap containing all the worlds we've
1937         created.
1938         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1939         haven't kept track of this world.
1940         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1941         instead of declaring our own.
1942
1943         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1944
1945         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1946         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1947         didClearWindowObjectForFrameInStandardWorld.
1948         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1949         Respond to this new delegate callback by calling through to one of the
1950         below new methods.
1951         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1952         Added. Sets a __worldID property on the gobal object whose value is
1953         the ID of this world.
1954         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1955         Added. Moved code here from didClearWindowObject.
1956
1957         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1958         didClearWindowObjectForFrame* functions.
1959
1960         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1961         (worldMap): Added. Returns a HashMap containing all the worlds we've
1962         created.
1963         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1964         haven't kept track of this world.
1965         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1966         instead of declaring our own.
1967
1968 2009-11-13  Adam Roben  <aroben@apple.com>
1969
1970         Finish replacing worldIDs with world objects
1971
1972         The only remaining use of worldIDs was in a method only used by DRT
1973         for the isolated worlds tests.
1974
1975         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1976
1977         Reviewed by Mark Rowe.
1978
1979         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1980         (LayoutTestController::evaluateScriptInIsolatedWorld):
1981         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1982         (LayoutTestController::evaluateScriptInIsolatedWorld):
1983         Updated for changes to WebFrame. Now holds the map of worldID -> world
1984         at this level instead of making WebKit do it.
1985
1986 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1987
1988         Reviewed by Simon Hausmann.
1989
1990         [Qt] Ensure the DRT does not output anything until first test is run
1991
1992         * DumpRenderTree/qt/DumpRenderTree.cpp:
1993         * DumpRenderTree/qt/DumpRenderTree.h:
1994
1995 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1996
1997         Reviewed by Tor Arne Vestbø.
1998
1999         Clear the undo stack in before each new test run.
2000
2001         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
2002
2003         * DumpRenderTree/qt/DumpRenderTree.cpp:
2004         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2005
2006 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2007
2008         Reviewed by Kenneth Rohde Christiansen.
2009
2010         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
2011
2012         * DumpRenderTree/qt/DumpRenderTree.cpp:
2013         (WebCore::WebPage::resetSettings):
2014         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2015         (LayoutTestController::overridePreference):
2016
2017 2009-11-13  Eric Seidel  <eric@webkit.org>
2018
2019         Reviewed by Adam Barth.
2020
2021         Update committers.py based on svn records
2022         https://bugs.webkit.org/show_bug.cgi?id=31366
2023
2024         This list was generated using validate-committer-lists from
2025         https://bugs.webkit.org/show_bug.cgi?id=30970
2026         and makes committers.py current for committers who have
2027         committed in the last 3 years.
2028
2029         * Scripts/modules/committers.py:
2030
2031 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
2032
2033         Reviewed by Adam Barth.
2034
2035         The document-open.html test was flaky at times. The test invokes the layout test plugin
2036         which in its destroy stream handler opens a new document. This basically tears down the
2037         stream and the associated plugin instance. The pluginLog function in the layout test
2038         plugin attempts to retrieve the window script object on a torn down plugin instance
2039         which crashed consistently on windows in the debugger. The functions which issue
2040         these logs already have a valid window script object. We now have variants of the pluginLog
2041         function which take in a window script object with and without variable arguments.
2042
2043         https://bugs.webkit.org/show_bug.cgi?id=31067
2044
2045         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2046         (pluginLogWithWindowObject):
2047         (pluginLogWithWindowObjectVariableArgs):
2048         (pluginLog):
2049         (notifyTestCompletion):
2050         (testDocumentOpen):
2051         (testWindowOpen):
2052
2053 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2054
2055         Reviewed by Gustavo Noronha Silva.
2056
2057         https://bugs.webkit.org/show_bug.cgi?id=30997
2058         [Gtk] Implemment AtkDocument
2059
2060         Added testing support.
2061
2062         * DumpRenderTree/AccessibilityUIElement.cpp:
2063         * DumpRenderTree/AccessibilityUIElement.h:
2064         (getDocumentEncodingCallback):
2065         (getDocumentURICallback):
2066         (AccessibilityUIElement::getJSClass):
2067         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2068         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2069         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2070         (AccessibilityUIElement::documentEncoding):
2071         (AccessibilityUIElement::documentURI):
2072
2073 2009-11-12  Adam Roben  <aroben@apple.com>
2074
2075         Replace worldIDs with world objects
2076
2077         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
2078         user scripts/stylesheets and isolated worlds
2079
2080         Reviewed by Sam Weinig.
2081
2082         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2083         (LayoutTestController::addUserScript):
2084         (LayoutTestController::addUserStyleSheet):
2085         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2086         (LayoutTestController::addUserScript):
2087         (LayoutTestController::addUserStyleSheet):
2088         Changed these functions to create a new WebJSWorld each time they're
2089         called and to pass that world to WebKit.
2090
2091 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
2092
2093         Reviewed by Oliver Hunt.
2094
2095         need to implement aria tree roles
2096         https://bugs.webkit.org/show_bug.cgi?id=31284
2097
2098         * DumpRenderTree/AccessibilityUIElement.cpp:
2099         (disclosedRowAtIndexCallback):
2100         (selectedRowAtIndexCallback):
2101         (isEqualCallback):
2102         (isAttributeSettableCallback):
2103         (isActionSupportedCallback):
2104         (disclosedByRowCallback):
2105         (hierarchicalLevelCallback):
2106         (AccessibilityUIElement::getJSClass):
2107         * DumpRenderTree/AccessibilityUIElement.h:
2108         (AccessibilityUIElement::isEqual):
2109         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2110         (AccessibilityUIElement::hierarchicalLevel):
2111         (AccessibilityUIElement::disclosedRowAtIndex):
2112         (AccessibilityUIElement::selectedRowAtIndex):
2113         (AccessibilityUIElement::disclosedByRow):
2114         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2115         (AccessibilityUIElement::getChildAtIndex):
2116         (AccessibilityUIElement::disclosedRowAtIndex):
2117         (AccessibilityUIElement::selectedRowAtIndex):
2118         (AccessibilityUIElement::titleUIElement):
2119         (AccessibilityUIElement::parentElement):
2120         (AccessibilityUIElement::disclosedByRow):
2121         (AccessibilityUIElement::hierarchicalLevel):
2122         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2123         (AccessibilityUIElement::hierarchicalLevel):
2124         (AccessibilityUIElement::disclosedRowAtIndex):
2125         (AccessibilityUIElement::selectedRowAtIndex):
2126         (AccessibilityUIElement::disclosedByRow):
2127
2128 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
2129
2130         Reviewed by Darin Adler.
2131
2132         svn-apply can not handle git binary diffs
2133         https://bugs.webkit.org/show_bug.cgi?id=26830
2134
2135         Support "literal" type git binary diffs.
2136
2137         * Scripts/VCSUtils.pm:
2138         * Scripts/modules/scm_unittest.py:
2139         * Scripts/svn-apply:
2140
2141 2009-11-11  Dmitry Titov  <dimich@chromium.org>
2142
2143         Not reviewed, removing duplicate entry for myself in committers.py.
2144
2145         * Scripts/modules/committers.py:
2146
2147 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
2148
2149         Reviewed by Darin Adler and Mark Rowe.
2150
2151         https://bugs.webkit.org/show_bug.cgi?id=31200
2152         Tests in http/tests/security/mixedContent start to fail when new tests are added
2153
2154         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
2155
2156 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2157
2158         Reviewed by Jan Alonzo.
2159
2160         Create, and display a window for the inspector, for inspector
2161         tests.
2162
2163         Need to also show/hide the inspector window to avoid having
2164         problems with code assuming it is realized
2165         https://bugs.webkit.org/show_bug.cgi?id=31347
2166
2167         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2168         (webInspectorShowWindow):
2169         (webInspectorCloseWindow):
2170         (webInspectorInspectWebView):
2171         (createWebView):
2172
2173 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2174
2175         Unreviewed Qt buildbot fix.
2176
2177         My previous fix was wrong, so revert that change and fix it by
2178         returning when the document of the frame has no document element.
2179         Idea is borrowed from mac and win DRT.
2180
2181         * DumpRenderTree/qt/DumpRenderTree.cpp:
2182         (WebCore::DumpRenderTree::dumpFramesAsText):
2183
2184 2009-11-11  Eric Seidel  <eric@webkit.org>
2185
2186         Reviewed byg Kenneth Rohde Christiansen.
2187
2188         Update Kenneth's committer record to include the email he
2189         uses on lists.webkit.org.
2190
2191         * Scripts/modules/committers.py:
2192
2193 2009-11-11  Eric Seidel  <eric@webkit.org>
2194
2195         Reviewed by Gustavo Noronha Silva.
2196
2197         Several committers use separate email addresses for bugzilla and svn.webkit.org
2198         https://bugs.webkit.org/show_bug.cgi?id=31364
2199
2200         Update records for existing committers to include email addresses
2201         used in svn.webkit.org and lists.webkit.org.
2202         Most committers use the same email address in all 3 places, but some use
2203         separate addresses.  committers.py needs record of each of these addresses.
2204
2205         * Scripts/modules/committers.py:
2206
2207 2009-11-11  Eric Seidel  <eric@webkit.org>
2208
2209         No review, adding second email address for an existing committer.
2210
2211         Add Yong Li's second bugzilla account to his committer record.
2212         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
2213
2214         * Scripts/modules/committers.py:
2215
2216 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2217
2218         Reviewed by Simon Hausmann.
2219
2220         If the frame has no innerText don't append it, and
2221         do not add a newline which breaks some cross platform
2222         results.
2223
2224         * DumpRenderTree/qt/DumpRenderTree.cpp:
2225         (WebCore::DumpRenderTree::dumpFramesAsText):
2226
2227 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2228
2229         Reviewed by Simon Hausmann.
2230
2231         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
2232
2233         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2234         (webkit_test_plugin_new_instance):
2235         (webkit_test_plugin_destroy_instance):
2236         (webkit_test_plugin_destroy_stream):
2237
2238 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2239
2240         Reviewed by Mark Rowe.
2241
2242         Implement the functionality needed by plugins/window-open.html
2243
2244         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2245         (webkit_test_plugin_new_instance):
2246         (webkit_test_plugin_set_window):
2247
2248 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2249
2250         Reviewed by Simon Hausmann.
2251
2252         [Qt] Force -graphicssystem raster and -style windows when running DRT
2253
2254         * DumpRenderTree/qt/main.cpp:
2255         * Scripts/run-webkit-tests:
2256
2257 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2258
2259         Reviewed by Simon Hausmann.
2260
2261         Compute correct library paths for Qt
2262
2263         * Scripts/webkitdirs.pm:
2264
2265 2009-11-10  Mark Rowe  <mrowe@apple.com>
2266
2267         Reviewed by Sam Weinig.
2268
2269         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
2270
2271         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
2272         about the validity of the self-signed certificates used in the regression tests.  We would then add the
2273         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
2274         that had enabled frame load delegate logging this would result in extra log messages being generated,
2275         causing the test to fail.
2276
2277         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
2278         tests.
2279
2280         * DumpRenderTree/mac/DumpRenderTree.mm:
2281         (dumpRenderTree):
2282         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2283         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2284
2285 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2286
2287         Reviewed by Kenneth Rohde Christiansen.
2288
2289         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
2290
2291         * DumpRenderTree/qt/DumpRenderTree.cpp:
2292         (WebCore::DumpRenderTree::DumpRenderTree):
2293
2294 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2295
2296         Reviewed by Jan Alonzo.
2297
2298         [GTK] Remove WebSocket configuration from WebKitWebSettings
2299         https://bugs.webkit.org/show_bug.cgi?id=31244
2300
2301         Follow-up of r50724. Don't set the enable-web-socket property
2302         anymore.
2303
2304         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2305         (resetDefaultsToConsistentValues):
2306
2307 2009-11-10  Oliver Hunt  <oliver@apple.com>
2308
2309         Reviewed by Maciej Stachowiak.
2310
2311         Rename 3D Canvas related classes to use WebGL prefix
2312         https://bugs.webkit.org/show_bug.cgi?id=29095
2313
2314         Checkin new version of do-webcore-rename used to do the WebGL type rename,
2315         and upate webkitdirs script to new method of testing for WebGL.
2316
2317         * Scripts/do-webcore-rename:
2318         * Scripts/webkitdirs.pm:
2319
2320 2009-11-09  Oliver Hunt  <oliver@apple.com>
2321
2322         Reviewed by Geoff Garen.
2323
2324         Make do-webcore-rename work with git.
2325
2326         * Scripts/do-webcore-rename:
2327
2328 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2329
2330         Adding Kenneth to the reviewers list.
2331
2332         * Scripts/modules/committers.py:
2333
2334 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2335
2336         Reviewed by Jan Alonzo.
2337
2338         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2339         https://bugs.webkit.org/show_bug.cgi?id=30482
2340
2341         LayoutTestControllerGtk now uses the exposed
2342         Page::tabKeyCyclesThroughElements API
2343
2344         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2345         (LayoutTestController::setTabKeyCyclesThroughElements):
2346
2347 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
2348
2349         Reviewed by Holger Freyther.
2350
2351         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
2352         This helps to pass the test case below. Also replaced hardcoded
2353         code numbers with defined constants.
2354         https://bugs.webkit.org/show_bug.cgi?id=31185
2355
2356         Test: editing/undo/undo-deleteWord.html
2357
2358         * DumpRenderTree/qt/EventSenderQt.cpp:
2359         (EventSender::keyDown):
2360
2361 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
2362
2363         Reviewed by Holger Freyther.
2364
2365         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
2366         https://bugs.webkit.org/show_bug.cgi?id=31164
2367
2368         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
2369
2370         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2371         (LayoutTestController::processWork):
2372
2373 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
2374
2375         Reviewed by Holger Freyther.
2376
2377         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
2378         https://bugs.webkit.org/show_bug.cgi?id=31158
2379
2380         By invoking a script queue'd by queueScript(), 'true' was beeing returned
2381         always, which from WorkQueue prospective means that a load has been started
2382         and the queue processing should stop and wait for the load to finish.
2383         Spinning it off into a loading and a non-loading variants was the solution
2384         adopted by Mac's DRT to work around this problem. The former keeps returning
2385         'true' while the later executes the script synchronously and returns 'false'
2386         making it possible to the WorkQueue to proceed right away.
2387
2388         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2389         (LayoutTestController::processWork):
2390         (LayoutTestController::queueLoadingScript):
2391         (LayoutTestController::queueNonLoadingScript):
2392         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2393         * DumpRenderTree/qt/WorkQueueItem.h:
2394         (LoadingScriptItem::LoadingScriptItem):
2395         (LoadingScriptItem::invoke):
2396         (NonLoadingScriptItem::NonLoadingScriptItem):
2397         (NonLoadingScriptItem::invoke):
2398
2399 2009-11-07  Mark Rowe  <mrowe@apple.com>
2400
2401         Rubber-stamped by Cameron Zwarich.
2402
2403         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
2404
2405         * Scripts/commit-log-editor:
2406
2407 2009-11-07  Mark Rowe  <mrowe@apple.com>
2408
2409         Reviewed by Darin Adler.
2410
2411         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
2412         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
2413
2414         Move logic for determining the name and email address to use in a ChangeLog entry from
2415         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
2416         whether the author of the patch matches committer, and therefore needs access to the
2417         email address that would be used in a ChangeLog entry.
2418
2419         Based on a patch by Pierre d'Herbemont.
2420
2421         * Scripts/VCSUtils.pm:
2422         * Scripts/commit-log-editor:
2423         * Scripts/prepare-ChangeLog:
2424         * Scripts/webkitdirs.pm:
2425
2426 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2427
2428         Reviewed by Adam Barth.
2429
2430         Added functionality to the layout test plugin to invoke document.open and
2431         window.open with default arguments. The associated webkit bug is
2432         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
2433         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
2434         work in Chromium (V8) if there is no calling javascript context. To achieve this
2435         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
2436         for the window.open test case and in NPP_DestroyStream for the document.open test case.
2437
2438         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2439         (testDocumentOpen):
2440         (testWindowOpen):
2441         (pluginAllocate):
2442         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2443         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2444         (NPP_New):
2445         (NPP_SetWindow):
2446         (NPP_DestroyStream):
2447         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2448         (NPP_New):
2449         (NPP_SetWindow):
2450         (NPP_NewStream):
2451         (NPP_DestroyStream):
2452
2453 2009-11-06  Eric Seidel  <eric@webkit.org>
2454
2455         Reviewed by Adam Barth.
2456
2457         bugzilla-tool crashed with exception
2458         https://bugs.webkit.org/show_bug.cgi?id=31092
2459
2460         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
2461
2462 2009-11-04  Eric Seidel  <eric@webkit.org>
2463
2464         No review, just add a line which got left out of the patch uploaded for commit.
2465
2466         commit-queue is crashing when trying to reject patches after unknown failures
2467         https://bugs.webkit.org/show_bug.cgi?id=31091
2468
2469         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
2470
2471 2009-11-04  Adam Roben  <aroben@apple.com>
2472
2473         Remove bogus else clause in bugzilla-tool
2474
2475         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
2476         create-bug raises exception after entering bug description
2477
2478         Reviewed by David Kilzer.
2479
2480         * Scripts/bugzilla-tool:
2481         (CreateBug): else clauses are only hit if no exception is raised, so
2482         it makes no sense to try to re-raise the exception in an else clause.
2483         The exception will automatically be re-raised if it doesn't match any
2484         of the except clauses, so we don't have to do anything special here at
2485         all to get the desired behavior.
2486
2487 2009-11-04  Eric Seidel  <eric@webkit.org>
2488
2489         Reviewed by David Kilzer.
2490
2491         svn-apply's fixChangeLogPatch function seems broken
2492         https://bugs.webkit.org/show_bug.cgi?id=30683
2493
2494         Update fixChangeLogPatch to be able to handle patches which
2495         don't start at line 1.
2496         Add unit tests for svn-apply to scm_unittest.py.
2497
2498         * Scripts/VCSUtils.pm:
2499         * Scripts/modules/scm_unittest.py:
2500
2501 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
2502
2503         Reviewed by Beth Dakin.
2504
2505         Need to implement ARIA role="combobox"
2506         https://bugs.webkit.org/show_bug.cgi?id=31096
2507
2508         * DumpRenderTree/AccessibilityUIElement.cpp:
2509         (showMenuCallback):
2510         (getIsExpandedCallback):
2511         (AccessibilityUIElement::getJSClass):
2512         * DumpRenderTree/AccessibilityUIElement.h:
2513         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2514         (AccessibilityUIElement::isExpanded):
2515         (AccessibilityUIElement::showMenu):
2516         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2517         (AccessibilityUIElement::isExpanded):
2518         (AccessibilityUIElement::showMenu):
2519         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2520         (AccessibilityUIElement::isSelected):
2521         (AccessibilityUIElement::isExpanded):
2522         (AccessibilityUIElement::showMenu):
2523
2524 2009-11-04  Eric Seidel  <eric@webkit.org>
2525
2526         Reviewed by Adam Barth.
2527
2528         commit-queue is crashing when trying to reject patches after unknown failures
2529         https://bugs.webkit.org/show_bug.cgi?id=31091
2530
2531         * Scripts/bugzilla-tool:
2532          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
2533            so we have to find out what the current patch is by asking bugzilla again.
2534          - Discovered that this code was also leaking file descriptors, so fixed that.
2535
2536 2009-11-04  Adam Roben  <aroben@apple.com>
2537
2538         Make run-webkit-tests work for the Debug_Internal Windows
2539         configuration
2540
2541         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2542         suffix.
2543
2544         Fixes <http://webkit.org/b/31123>.
2545
2546         Reviewed by Sam Weinig.
2547
2548         * Scripts/run-webkit-tests: Don't add the _debug suffix in
2549         Debug_Internal, either.
2550
2551 2009-11-04  Eric Seidel  <eric@webkit.org>
2552
2553         Reviewed by Adam Barth.
2554
2555         committers.py needs a way to store non-bugzilla email addresses
2556         https://bugs.webkit.org/show_bug.cgi?id=31037
2557
2558         Make Committer and Reviewer constructors take a single email or a list of emails.
2559         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2560         Expose reviewers(), used by validate-committer-lists on bug 30970.
2561
2562         * Scripts/modules/committers.py:
2563         * Scripts/modules/committers_unittest.py: Added tests for the new code.
2564
2565 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2566
2567         Reviewed by David Levin.
2568
2569         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2570         https://bugs.webkit.org/show_bug.cgi?id=27491
2571
2572         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2573         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2574
2575         Functions to start or stop Web Socket servers are added.
2576
2577         * Scripts/run-webkit-tests:
2578
2579 2009-11-03  Eric Seidel  <eric@webkit.org>
2580
2581         No review, just changing wording of log message.
2582
2583         Change log string to say "failed" instead of "rejected"
2584         when a commit fails due to an out of date checkout.
2585         This makes grepping the commit-queue log for rejected patches easier.
2586
2587         * Scripts/bugzilla-tool:
2588
2589 2009-11-03  Eric Seidel  <eric@webkit.org>
2590
2591         No review, adding commonly known committers missing from the file.
2592
2593         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2594
2595 2009-11-03  Eric Seidel  <eric@webkit.org>
2596
2597         No review, just sort-order cleanup.
2598
2599         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2600
2601 2009-11-03  Stephen White  <senorblanco@chromium.org>
2602
2603         (Unreviewed).
2604
2605         Add myself to committers.py.
2606
2607         * Scripts/modules/committers.py:
2608
2609 2009-11-03  Robin Dunn  <robin@alldunn.com>
2610
2611         Reviewed by Kevin Ollviier.
2612
2613         Add packaging scripts for Debian-based Linux distros.
2614
2615         https://bugs.webkit.org/show_bug.cgi?id=31075
2616
2617         * wx/packaging/build-debian-installer.py: Added.
2618         * wx/packaging/debian: Added.
2619
2620 2009-11-03  Dan Bernstein  <mitz@apple.com>
2621
2622         Reviewed by Anders Carlsson and Beth Dakin.
2623
2624         https://bugs.webkit.org/show_bug.cgi?id=31070
2625
2626         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2627         destroyed, it executes the value of the 'ondestroy' parameter as a
2628         script.
2629
2630         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2631         (pluginAllocate): Initialize onDestroy.
2632         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2633         onDestroy.
2634         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2635         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2636         specified.
2637         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2638
2639 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2640
2641         Reviewed by Xan Lopez.
2642
2643         https://bugs.webkit.org/show_bug.cgi?id=31035
2644         [GTK] some accessibility tests hitting assertion in debug builds
2645
2646         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2647
2648         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2649         (AccessibilityController::rootElement):
2650
2651 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2652
2653         Reviewed by Beth Dakin.
2654
2655         Support ARIA "tab" roles
2656         https://bugs.webkit.org/show_bug.cgi?id=30842
2657
2658         * DumpRenderTree/AccessibilityUIElement.cpp:
2659         * DumpRenderTree/AccessibilityUIElement.h:
2660         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2661         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2662         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2663
2664 2009-11-01  Eric Seidel  <eric@webkit.org>
2665
2666         Reviewed by David Levin.
2667
2668         buildbots should use --exit-after-N-failures
2669         https://bugs.webkit.org/show_bug.cgi?id=30809
2670
2671         Make the bots exit after 20 failures to prevent never-ending
2672         test runs where every test spends a minute crashing.
2673
2674         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2675
2676 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2677
2678         Reviewed by Eric Seidel.
2679
2680         Turn on warnings for QtWebKit for gcc
2681         https://bugs.webkit.org/show_bug.cgi?id=30958
2682
2683         * DumpRenderTree/qt/main.cpp:
2684         (crashHandler): Mark function NO_RETURN
2685
2686 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2687
2688         Adding myself to the committers list.
2689
2690         * Scripts/modules/committers.py:
2691
2692 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2693
2694         Fix an issue that Adam noticed in DRT.
2695
2696         Reviewed by Darin Adler.
2697
2698         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2699         (AccessibilityUIElement::role):
2700         Get the length of the role text, and create a buffer dynamically.
2701
2702 2009-10-30  Eric Seidel  <eric@webkit.org>
2703
2704         No review, rolling out r50105.
2705         http://trac.webkit.org/changeset/50105
2706
2707         This commit was causing:
2708         https://bugs.webkit.org/show_bug.cgi?id=30869
2709         We'll re-implement the feature a different way.
2710
2711         * Scripts/bugzilla-tool:
2712
2713 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2714
2715         Test for MSAA: Accessibility of headings is not correct
2716
2717         https://bugs.webkit.org/show_bug.cgi?id=30937
2718
2719         Reviewed by Adam Roben.
2720
2721         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2722         (AccessibilityUIElement::role):
2723         Allow the role returned to be a BSTR.
2724         (AccessibilityUIElement::description):
2725         Fix a copy/paste error.
2726
2727 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2728
2729         Test for MSAA: Accessibility of links is wrong
2730
2731         https://bugs.webkit.org/show_bug.cgi?id=30928
2732
2733         Reviewed by Darin Adler.
2734
2735         * DumpRenderTree/AccessibilityUIElement.cpp:
2736         (getAccessibilityValueCallback):
2737         Return the accessibility value.
2738         (AccessibilityUIElement::getJSClass):
2739         Added "accessibilityValue" value.
2740
2741         * DumpRenderTree/AccessibilityUIElement.h:
2742
2743         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2744         (AccessibilityUIElement::accessibilityValue):
2745         Stubbed.
2746
2747         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2748         (AccessibilityUIElement::accessibilityValue):
2749         Stubbed.
2750
2751         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2752         (AccessibilityUIElement::accessibilityValue):
2753         Get the object's value, and return it as a JS string.
2754
2755 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2756
2757         Fix typo in command name used by wx build system.
2758
2759         * wx/build/build_utils.py:
2760
2761 2009-10-30  Adam Barth  <abarth@webkit.org>
2762
2763         Reviewed by Darin Adler.
2764
2765         Patch v1 is a dumb default name for patches
2766         https://bugs.webkit.org/show_bug.cgi?id=30952
2767
2768         Let's use "Patch" instead.
2769
2770         * Scripts/bugzilla-tool:
2771
2772 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2773
2774         Unreviewed trivial buildfix.
2775
2776         [Qt] Buildfix for r50333.
2777
2778         * DumpRenderTree/qt/DumpRenderTree.pro:
2779
2780 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2781
2782         Reviewed by Holger Freyther.
2783
2784         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2785         https://bugs.webkit.org/show_bug.cgi?id=30953
2786
2787         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2788         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2789         makes qt DRT to share this implementation (as gtk and mac ports do).
2790
2791         * DumpRenderTree/qt/DumpRenderTree.pro:
2792         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2793         * DumpRenderTree/qt/WorkQueue.h: Removed.
2794
2795 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2796
2797         Unreviewed potential buildbot fix.
2798
2799         Second try: Reset page history before running each test.
2800
2801         Apparently the QWebHistory::clear() keeps the current page
2802         in history which is not what we want, so we not additionally
2803         sets the history capacity to 0 (forces removing everything)
2804         and then sets it back to its original value.
2805
2806         * DumpRenderTree/qt/DumpRenderTree.cpp:
2807         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2808
2809 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2810
2811         Unreviewed potential buildbot fix.
2812
2813         Reset page history before running each test.
2814
2815         * DumpRenderTree/qt/DumpRenderTree.cpp:
2816         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2817
2818 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2819
2820         Reviewed by Eric Seidel.
2821
2822         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2823
2824         Bug 28420 -  Implement HTML5 <ruby> rendering
2825         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2826
2827         No new tests (no functional change).
2828
2829         * Scripts/build-webkit:
2830
2831 2009-10-29  Dan Bernstein  <mitz@apple.com>
2832
2833         Reviewed by Mark Rowe.
2834
2835         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2836         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2837         define it.
2838
2839         * Scripts/VCSUtils.pm:
2840         * Scripts/svn-apply:
2841         * Scripts/svn-unapply:
2842
2843 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2844
2845         Reviewed by Gustavo Noronha.
2846
2847         Use the GTK+ main loop instead of rolling our own mini-version of
2848         it.
2849
2850         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2851         (dump):
2852         (runTest):
2853         (webViewLoadFinished):
2854
2855 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2856
2857         Reviewed by Oliver Hunt.
2858
2859         Implement the Qt version of DRT dumpBackForwardList().
2860
2861         * DumpRenderTree/qt/DumpRenderTree.cpp:
2862         (WebCore::dumpHistoryItem):
2863         (WebCore::DumpRenderTree::dumpBackForwardList):
2864
2865 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2866
2867         Reviewed by Adam Roben.
2868
2869         Implement DRT functionality for Qt introduced in
2870         r28690 and r28705.
2871
2872         - Implemented pathToLocalResource which exposes the functionality of
2873         converting a given unix path to the correct location on Windows.
2874         - Implemented a way to remove machine-dependent information from paths
2875         in layout test results.
2876
2877         * DumpRenderTree/qt/DumpRenderTree.cpp:
2878         (WebCore::urlSuitableForTestResult):
2879         (WebCore::WebPage::javaScriptConsoleMessage):
2880         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2881         (LayoutTestController::pathToLocalResource):
2882         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2883
2884 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2885
2886         Adding myself to the committers list.
2887
2888         * Scripts/modules/committers.py:
2889
2890 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2891
2892         Adding myself to the committers list.
2893
2894         * Scripts/modules/committers.py:
2895
2896 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2897
2898         Reviewed by Jan Alonzo.
2899
2900         [GTK] API to start inspector for a WebView
2901         https://bugs.webkit.org/show_bug.cgi?id=22551
2902
2903         Use the new inspector API to implement the LayoutTestController
2904         interfaces used to test the inspector.
2905
2906         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2907         (webInspectorInspectWebView):
2908         (createWebView):
2909         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2910         (LayoutTestController::showWebInspector):
2911         (LayoutTestController::closeWebInspector):
2912         (LayoutTestController::evaluateInWebInspector):
2913
2914 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2915
2916         Reviewed by Eric Seidel.
2917
2918         [Qt] WebFrame::counterValueForElementById must not be exposed
2919         https://bugs.webkit.org/show_bug.cgi?id=30882
2920
2921         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2922         (LayoutTestController::counterValueForElementById):
2923
2924 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2925
2926         Rubberstamped by Oliver Hunt.
2927
2928         Fix the warning:
2929
2930         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2931         declared with attribute warn_unused_result".
2932
2933         by actually checking the result. In the case it is null, an
2934         error has occoured, so treat it as the other fatal errors.
2935
2936         * DumpRenderTree/qt/DumpRenderTree.cpp:
2937         (WebCore::DumpRenderTree::initializeFonts):
2938
2939 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2940
2941         Reviewed by Darin Adler.
2942
2943         Provide a way to get counter values with layoutTestContoller
2944         https://bugs.webkit.org/show_bug.cgi?id=30555
2945
2946         Define layoutTestContoller.counterValueForElementById.
2947
2948         * DumpRenderTree/LayoutTestController.cpp:
2949         (counterValueForElementByIdCallback):
2950         (LayoutTestController::staticFunctions):
2951         * DumpRenderTree/LayoutTestController.h:
2952         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2953         (LayoutTestController::counterValueForElementById):
2954
2955 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2956
2957         Rubberstamped by Oliver Hunt.
2958
2959         Change two methods to be internal for DRT use only.
2960
2961         Part of [Qt] Review all new API in Qt 4.6
2962         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2963
2964         * DumpRenderTree/qt/DumpRenderTree.cpp:
2965         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2966         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2967         (LayoutTestController::whiteListAccessFromOrigin):
2968
2969 2009-10-27  Eric Seidel  <eric@webkit.org>
2970
2971         Reviewed by Adam Barth.
2972
2973         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2974         https://bugs.webkit.org/show_bug.cgi?id=30826
2975
2976         * Scripts/svn-apply:
2977          - Add () around all system() calls.
2978          - Use the correct system() == 0 or die instead of system() or die
2979          - Add descriptive messages to all die statements.
2980
2981 2009-10-27  Steve Block  <steveblock@google.com>
2982
2983         Reviewed by NOBODY.
2984
2985         Adds steveblock@google.com to list of committers.
2986
2987         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2988
2989 2009-10-27  Eric Seidel  <eric@webkit.org>
2990
2991         Reviewed by Adam Barth.
2992
2993         svn-apply can exit(0) even on patch failure
2994         https://bugs.webkit.org/show_bug.cgi?id=29622
2995
2996         * Scripts/svn-apply:
2997          - Add a bunch of "or die" statements, hopefully catching all
2998            possible cases where failure could still exit(0).
2999
3000 2009-10-27  Eric Seidel  <eric@webkit.org>
3001
3002         Reviewed by Adam Barth.
3003
3004         svn-* scripts should share code through VCSUtils.pm
3005         https://bugs.webkit.org/show_bug.cgi?id=30791
3006
3007         Just moving code into a shared location.
3008
3009         * Scripts/VCSUtils.pm:
3010         * Scripts/prepare-ChangeLog:
3011         * Scripts/resolve-ChangeLogs:
3012         * Scripts/svn-apply:
3013         * Scripts/svn-create-patch:
3014         * Scripts/svn-unapply:
3015         * Scripts/update-webkit:
3016
3017 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
3018
3019         Suppress a huge number of MSVC warnings when building wxWebKit.
3020
3021         * wx/build/settings.py:
3022
3023 2009-10-26  Eric Seidel  <eric@webkit.org>
3024
3025         No review, just adding Mike Belshe to the committers list.
3026
3027         * Scripts/modules/committers.py:
3028
3029 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3030
3031         Reviewed by Darin Adler.
3032
3033         Make .rc files compile on Windows without depending on MFC headers
3034         https://bugs.webkit.org/show_bug.cgi?id=30750
3035
3036         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
3037         windows.h instead of afxres.h because it exists even when MFC is not
3038         installed, and is all that's needed here.
3039
3040         * FindSafari/FindSafari.rc: Ditto
3041
3042 2009-10-24  Eric Seidel  <eric@webkit.org>
3043
3044         Reviewed by Adam Barth.
3045
3046         bugzilla-tool post-diff should know how to mark commit-queue=?
3047         https://bugs.webkit.org/show_bug.cgi?id=29202
3048
3049         * Scripts/bugzilla-tool:
3050          - Add --commit-queue option to post-diff, post-commits and create-bug.
3051         * Scripts/modules/bugzilla.py:
3052          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
3053          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
3054
3055 2009-10-23  Eric Seidel  <eric@webkit.org>
3056
3057         Reviewed by Adam Barth.
3058
3059         bugzilla-tool commit-queue does not notice modifications to committers.py
3060         https://bugs.webkit.org/show_bug.cgi?id=30084
3061
3062         * Scripts/bugzilla-tool:
3063          - Make commit-queue re-exec itself instead of using while(1).
3064          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
3065          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
3066
3067 2009-10-22  Eric Seidel  <eric@webkit.org>
3068
3069         Reviewed by Adam Barth.
3070
3071         commit-queue will get stuck on patches if land-patches terminates unexpectedly
3072         https://bugs.webkit.org/show_bug.cgi?id=30634
3073
3074         * Scripts/bugzilla-tool:
3075          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
3076          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
3077
3078 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
3079
3080         Reviewed by Eric Seidel.
3081
3082         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
3083
3084         https://bugs.webkit.org/show_bug.cgi?id=30763
3085
3086         * pywebsocket/mod_pywebsocket/__init__.py:
3087         * pywebsocket/mod_pywebsocket/dispatch.py:
3088         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
3089         * pywebsocket/mod_pywebsocket/standalone.py:
3090         * pywebsocket/setup.py:
3091         * pywebsocket/test/test_dispatch.py:
3092
3093 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
3094
3095         Reviewed by David Levin.
3096
3097         REGRESSION: 2 failures in run-webkit-unittests
3098         https://bugs.webkit.org/show_bug.cgi?id=30645
3099
3100         * Scripts/modules/cpp_style_unittest.py:
3101         Fixed a few test scenarios which apparently lost some spaces from
3102         text literals.
3103
3104 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
3105
3106         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
3107
3108         * Scripts/webkitdirs.pm:
3109
3110 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
3111
3112         Reviewed by Darin Adler.
3113
3114         Unification of using null device in perl scripts.
3115         https://bugs.webkit.org/show_bug.cgi?id=30572
3116
3117         * Scripts/VCSUtils.pm:
3118         * Scripts/bisect-builds:
3119         * Scripts/resolve-ChangeLogs:
3120         * Scripts/run-iexploder-tests:
3121         * Scripts/run-jsc:
3122         * Scripts/run-mangleme-tests:
3123         * Scripts/run-webkit-tests:
3124         * Scripts/webkitdirs.pm:
3125         Using File::Spec->devnull() instead of hard coded /dev/null.
3126
3127 2009-10-26  Eric Seidel  <eric@webkit.org>
3128
3129         Reviewed by Holger Freyther.
3130
3131         Reviewers are missing from committers.py
3132         https://bugs.webkit.org/show_bug.cgi?id=30733
3133
3134         * Scripts/modules/committers.py:
3135
3136 2009-10-23  Eric Seidel  <eric@webkit.org>
3137
3138         No review, only adding Alice to the list of reviewers.
3139
3140         * Scripts/modules/committers.py:
3141
3142 2009-10-23  Eric Seidel  <eric@webkit.org>
3143
3144         Reviewed by Eric Carlson.
3145
3146         fast/media/mq-transform-02.html failed on Leopard Commit Bot
3147         https://bugs.webkit.org/show_bug.cgi?id=30700
3148
3149         * DumpRenderTree/mac/DumpRenderTree.mm:
3150         (resetDefaultsToConsistentValues): Update QuickTime version check.
3151
3152 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
3153
3154         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
3155         character measurement APIs that are private on Tiger.
3156
3157         * wx/build/settings.py:
3158
3159 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3160
3161         Reviewed by NOBODY (build fix).
3162         Build fix following bug #30696.
3163
3164         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3165         (LayoutTestController::evaluateScriptInIsolatedWorld):
3166
3167 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3168
3169         Reviewed by Sam Weinig & Geoff Garen.
3170
3171         https://bugs.webkit.org/show_bug.cgi?id=30696
3172         Enable isolated-worlds tests on mac.
3173
3174         Add private interface for DRT to invoke execution in a given world.
3175
3176         * DumpRenderTree/LayoutTestController.cpp:
3177         (evaluateScriptInIsolatedWorldCallback):
3178         (LayoutTestController::staticFunctions):
3179         * DumpRenderTree/LayoutTestController.h:
3180         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3181         (LayoutTestController::evaluateScriptInIsolatedWorld):
3182         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3183         (LayoutTestController::evaluateScriptInIsolatedWorld):
3184
3185 2009-10-21  Eric Seidel  <eric@webkit.org>
3186
3187         Reviewed by Adam Barth.
3188
3189         bugzilla-tool's "patch failed to download an apply" error should give more information
3190         https://bugs.webkit.org/show_bug.cgi?id=30632
3191
3192         * Scripts/modules/scm.py:
3193          - Use the common run_command method instead of custom POpen code.
3194          - Make run_command know how to take pipes as input.
3195         * Scripts/modules/scm_unittest.py:
3196          - Add new tests to cover change.
3197          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
3198
3199 2009-10-21  Kent Tamura  <tkent@chromium.org>
3200
3201         Unreviewed.  Adding myself to the committers list.
3202
3203         * Scripts/modules/committers.py:
3204
3205 2009-10-21  Robin Dunn  <robin@alldunn.com>
3206
3207         Reviewed by Kevin Ollivier.
3208
3209         Update the Windows installer builder to work with Vista / Win 7 and with git.
3210
3211         https://bugs.webkit.org/show_bug.cgi?id=30649
3212
3213         * wx/build/build_utils.py:
3214         * wx/packaging/build-mac-installer.py:
3215         * wx/packaging/build-win-installer.py:
3216         * wx/packaging/wxWebKitInstaller.iss.in:
3217
3218 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3219
3220         Reviewed by Gustavo Noronha.
3221
3222         [GTK] Added conditional code to avoid using
3223         gdk_window_get_root_coords if we do not have a gtk+ release newer
3224         than 2.17.3.
3225         https://bugs.webkit.org/show_bug.cgi?id=30636
3226
3227         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3228
3229 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
3230
3231         Reviewed by Eric Seidel.
3232
3233         [Qt] Added dummy implementation for keepWebHistory()
3234         https://bugs.webkit.org/show_bug.cgi?id=30592
3235
3236         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3237         (LayoutTestController::keepWebHistory):
3238         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3239
3240 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3241
3242         Reviewed by Xan Lopez.
3243
3244         [GTK] Fixed the double click condition, it is not double click if
3245         we move in just in one direction.
3246         https://bugs.webkit.org/show_bug.cgi?id=30636
3247
3248         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3249
3250 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3251
3252         Reviewed by Xan Lopez.
3253
3254         [GTK] Initialize the events completly before emitting them.
3255         https://bugs.webkit.org/show_bug.cgi?id=30633
3256
3257         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3258
3259 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3260
3261         wx build fix. Fix for when linking using --as-needed with gcc.
3262
3263         * wx/browser/wscript:
3264
3265 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3266
3267         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
3268         to support all the features used by CURL backend.
3269
3270         * wx/build/settings.py:
3271         * wx/install-unix-extras:
3272
3273 2009-10-20  Anton Muhin  <antonm@chromium.org>
3274
3275         Reviewed by Adam Barth.
3276
3277         Add {ager,antonm,yurys}@chromium.org into committers.py
3278         https://bugs.webkit.org/show_bug.cgi?id=30560
3279
3280         * Scripts/modules/committers.py:
3281
3282 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3283
3284         Reviewed by Tor Arne Vestbø.
3285
3286         Make the Netscape Test plugin available to the Qt launcher.
3287
3288         * Scripts/run-launcher:
3289
3290 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
3291
3292         Reviewed by David Levin.
3293
3294         Removed WebSocket runtime settings.
3295         https://bugs.webkit.org/show_bug.cgi?id=29896
3296
3297         WebSocket runtime configuration is supported by chromium/v8 only.
3298
3299         * DumpRenderTree/mac/DumpRenderTree.mm:
3300         (resetDefaultsToConsistentValues):
3301         * DumpRenderTree/win/DumpRenderTree.cpp:
3302         (resetDefaultsToConsistentValues):
3303
3304 2009-10-19  Nate Chapin  <japhet@chromium.org>
3305
3306         Reviewed by Adam Barth.
3307
3308         Add testFail() to test plugin so we can test our handling of a
3309         plugin invoke call returning false.
3310
3311         https://bugs.webkit.org/show_bug.cgi?id=30239
3312
3313         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
3314         (pluginInvoke):
3315         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
3316
3317 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
3318
3319         Reviewed by Gustavo Noronha.
3320
3321         Enable DOM pasting when running layout tests.
3322
3323         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3324         (resetDefaultsToConsistentValues):
3325
3326 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3327
3328         Reviewed by Simon Hausmann.
3329
3330         Use the setPreferredContentsSize method instead
3331         of setFixedContentsSize, as the method has been renamed.
3332
3333         * DumpRenderTree/qt/DumpRenderTree.cpp:
3334         (WebCore::DumpRenderTree::open):
3335         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3336         (LayoutTestController::setFixedContentsSize):
3337
3338 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3339
3340         Reviewed by Dan Bernstein.
3341
3342         https://bugs.webkit.org/show_bug.cgi?id=30456
3343         Fixes for new Debug_All Windows build configuration.
3344
3345         * DumpRenderTree/win/DumpRenderTree.cpp:
3346         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
3347         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
3348
3349 2009-10-16  Eric Seidel  <eric@webkit.org>
3350
3351         Reviewed by Adam Barth.
3352
3353         commit-queue status bot should list which buildbot is blocking the queue
3354         https://bugs.webkit.org/show_bug.cgi?id=30452
3355
3356         Add new methods and testing.
3357
3358         * Scripts/bugzilla-tool:
3359         * Scripts/modules/buildbot.py:
3360         * Scripts/modules/buildbot_unittest.py:
3361
3362 2009-10-16  Eric Seidel  <eric@webkit.org>
3363
3364         Reviewed by Adam Barth.
3365
3366         run-webkit-tests fails when CWD is not inside a WebKit checkout
3367         https://bugs.webkit.org/show_bug.cgi?id=30451
3368
3369         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
3370         * Scripts/modules/scm_unittest.py:
3371           - Remove use of original_path (we don't need to restore the CWD).
3372           - Don't use '.' to find the webkit checkout, use __file__ instead.
3373
3374 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3375
3376         Reviewed by Adam Roben.
3377
3378         Add a Debug_All configuration to build entire stack as debug.
3379         Change Debug_Internal to:
3380         - stop using _debug suffix for all WebKit/Safari binaries
3381         - not use _debug as a DLL naming suffix
3382         - use non-debug C runtime lib.
3383
3384         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
3385         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
3386         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
3387         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3388         Add missing debug.vsprops inherited property sheet.
3389         Add Debug_All configuration.
3390         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
3391         * WinLauncher/WinLauncher.vcproj:
3392         Removed extraneous definitions inherited from vsprops.
3393         Add Debug_All configuration.
3394
3395 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
3396
3397         Reviewed by David Levin.
3398
3399         check-webkit-style is wrong about indent checking in namespaces
3400         in header files and a few other things
3401         https://bugs.webkit.org/show_bug.cgi?id=30362
3402
3403         The few other things include:
3404         + check-webkit-style does not require spaces around the equal sign
3405           inside 'if' statements and around binary operators that take
3406           numeric literals.
3407         + check-webkit-style reports false errors for the / operator
3408           when part of a filename in the #include directive.
3409
3410         * Scripts/modules/cpp_style.py:
3411         Improved indentation checking and space checking around
3412         binary operators. While the checks are still not perfect,
3413         they are clearly better than before.
3414         * Scripts/modules/cpp_style_unittest.py:
3415         Added test cases for the newly supported checks and modified old
3416         test cases to match the new guidelines
3417
3418 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
3419
3420         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
3421
3422         * wx/build/settings.py:
3423
3424 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
3425
3426         Reviewed by David Levin.
3427
3428         Add mod_pywebsocket to test Web Sockets.
3429         http://code.google.com/p/pywebsocket/
3430         https://bugs.webkit.org/show_bug.cgi?id=27490
3431
3432         * pywebsocket/COPYING: Added.
3433         * pywebsocket/MANIFEST.in: Added.
3434         * pywebsocket/README: Added.
3435         * pywebsocket/example/echo_client.py: Added.
3436         * pywebsocket/example/echo_wsh.py: Added.
3437         * pywebsocket/mod_pywebsocket/__init__.py: Added.
3438         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
3439         * pywebsocket/mod_pywebsocket/handshake.py: Added.
3440         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
3441         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
3442         * pywebsocket/mod_pywebsocket/standalone.py: Added.
3443         * pywebsocket/mod_pywebsocket/util.py: Added.
3444         * pywebsocket/setup.py: Added.
3445         * pywebsocket/test/config.py: Added.
3446         * pywebsocket/test/mock.py: Added.
3447         * pywebsocket/test/run_all.py: Added.
3448         * pywebsocket/test/test_dispatch.py: Added.
3449         * pywebsocket/test/test_handshake.py: Added.
3450         * pywebsocket/test/test_mock.py: Added.
3451         * pywebsocket/test/test_msgutil.py: Added.
3452         * pywebsocket/test/test_util.py: Added.
3453         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
3454         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
3455         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
3456         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
3457         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
3458         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
3459         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
3460         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
3461
3462 2009-10-15  James Robinson  <jamesr@google.com>
3463
3464         Reviewed by David Levin.
3465
3466         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
3467
3468         https://bugs.webkit.org/show_bug.cgi?id=30426
3469
3470         * Scripts/modules/cpp_style.py:
3471         * Scripts/modules/cpp_style_unittest.py:
3472
3473 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
3474
3475         Reviewed by Adam Roben.
3476
3477         Fixes <http://webkit.org/b/30411>.
3478         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
3479
3480         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
3481         building Chromium.
3482
3483         * Scripts/pdevenv:
3484
3485 2009-10-15  Robin Dunn  <robin@alldunn.com>
3486
3487         Reviewed by Kevin Ollivier.
3488
3489         Add Mac package building scripts for wx.
3490
3491         https://bugs.webkit.org/show_bug.cgi?id=30405
3492
3493         * wx/build/build_utils.py:
3494         * wx/build/settings.py:
3495         * wx/packaging/build-mac-installer.py: Added.
3496
3497 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
3498
3499         Reviewed by Gustavo Noronha.
3500
3501         Enable Web Sockets support when running layout tests.
3502
3503         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3504         (resetDefaultsToConsistentValues):
3505
3506 2009-10-15  Xan Lopez  <xlopez@igalia.com>
3507
3508         Reviewed by Gustavo Noronha.
3509
3510         Need to initialize event.button.button, since in most cases a
3511         button number is not passed as an argument.
3512
3513         * DumpRenderTree/gtk/EventSender.cpp:
3514         (mouseDownCallback):
3515         (mouseUpCallback):
3516
3517 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
3518
3519         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3520         the OS if none was explicitly set.
3521
3522         * wx/build/settings.py:
3523
3524 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
3525
3526         Reviewed by Timothy Hatcher.
3527
3528         Web Inspector: enable developers extras within inspector layout tests.
3529
3530         https://bugs.webkit.org/show_bug.cgi?id=30014
3531
3532         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3533         (LayoutTestController::showWebInspector):
3534         (LayoutTestController::closeWebInspector):
3535         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3536         (LayoutTestController::showWebInspector):
3537         (LayoutTestController::closeWebInspector):
3538
3539 2009-10-14  José Millán Soto  <jmillan@igalia.com>
3540
3541         Reviewed by Jan Alonzo.
3542
3543         GtkLauncher is using a deprecated signal
3544         https://bugs.webkit.org/show_bug.cgi?id=30364
3545
3546         Modified GtkLauncher to use notify::title signal instead of
3547         deprecated title-changed signal
3548
3549         * GtkLauncher/main.c:
3550         (notify_title_cb):
3551         (create_browser):
3552
3553 2009-10-14  Brady Eidson  <beidson@apple.com>
3554
3555         Reviewed by Sam Weinig.
3556
3557         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
3558         1 - Disables WebHistory
3559         2 - Doesn't make sense in that context anyway.
3560
3561         * DumpRenderTree/win/DumpRenderTree.cpp:
3562         (createWebViewAndOffscreenWindow):
3563
3564 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
3565
3566         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3567         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3568
3569         * wx/build/settings.py:
3570         * wx/install-unix-extras:
3571
3572 2009-10-14  Brady Eidson  <beidson@apple.com>
3573
3574         Reviewed by Sam Weinig.
3575
3576         WebKit Win API should provide a delegate interface for global history.
3577         https://bugs.webkit.org/show_bug.cgi?id=29905
3578
3579         * DumpRenderTree/LayoutTestController.cpp:
3580         (LayoutTestController::LayoutTestController):
3581         * DumpRenderTree/LayoutTestController.h:
3582         (LayoutTestController::dumpHistoryDelegateCallbacks):
3583         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3584
3585         * DumpRenderTree/win/DumpRenderTree.cpp:
3586         (shouldLogHistoryDelegates):
3587         (runTest):
3588         (createWebViewAndOffscreenWindow):
3589         (main):
3590         * DumpRenderTree/win/DumpRenderTree.vcproj:
3591
3592         Add the IWebHistoryDelegate to DRT Windows:
3593         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3594         (wstringFromBSTR):
3595         (HistoryDelegate::HistoryDelegate):
3596         (HistoryDelegate::~HistoryDelegate):
3597         (HistoryDelegate::QueryInterface):
3598         (HistoryDelegate::AddRef):
3599         (HistoryDelegate::Release):
3600         (HistoryDelegate::didNavigateWithNavigationData):
3601         (HistoryDelegate::didPerformClientRedirectFromURL):
3602         (HistoryDelegate::didPerformServerRedirectFromURL):
3603         (HistoryDelegate::updateHistoryTitle):
3604         (HistoryDelegate::populateVisitedLinksForWebView):
3605         * DumpRenderTree/win/HistoryDelegate.h: Added.
3606
3607         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3608         (LayoutTestController::removeAllVisitedLinks):
3609
3610 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3611
3612         Reviewed by Simon Hausmann.
3613
3614         [Qt] Implement support for setPOSIXLocale on Qt.
3615         https://bugs.webkit.org/show_bug.cgi?id=30268
3616
3617         * DumpRenderTree/qt/DumpRenderTree.cpp:
3618         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3619         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3620         (LayoutTestController::setPOSIXLocale):
3621         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3622
3623 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3624
3625         Unreviewed, adding myself to reviewers list.
3626
3627         * Scripts/modules/committers.py:
3628
3629 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3630
3631         Reviewed by Mark Rowe.
3632
3633         Fix null assignment so root tests work again.
3634
3635         * Scripts/webkitdirs.pm:
3636
3637 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3638
3639         Reviewed by Simon Hausmann.
3640
3641         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3642         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3643         This is done in preparation of implementing missing features in DRT.
3644         No functionality changes made yet.
3645
3646         * DumpRenderTree/qt/DumpRenderTree.cpp:
3647         * DumpRenderTree/qt/DumpRenderTree.pro:
3648         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3649         (EventSender::EventSender):
3650         (EventSender::mouseDown):
3651         (EventSender::mouseUp):
3652         (EventSender::mouseMoveTo):
3653         (EventSender::leapForward):
3654         (EventSender::keyDown):
3655         (EventSender::contextClick):
3656         (EventSender::scheduleAsynchronousClick):
3657         (EventSender::frameUnderMouse):
3658         * DumpRenderTree/qt/EventSenderQt.h: Added.
3659         (EventSender::clearKillRing):
3660         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3661         (LayoutTestController::LayoutTestController):
3662         (LayoutTestController::reset):
3663         (LayoutTestController::processWork):
3664         (LayoutTestController::maybeDump):
3665         (LayoutTestController::waitUntilDone):
3666         (LayoutTestController::notifyDone):
3667         (LayoutTestController::windowCount):
3668         (LayoutTestController::clearBackForwardList):
3669         (LayoutTestController::dumpEditingCallbacks):
3670         (LayoutTestController::dumpResourceLoadCallbacks):
3671         (LayoutTestController::queueBackNavigation):
3672         (LayoutTestController::queueForwardNavigation):
3673         (LayoutTestController::queueLoad):
3674         (LayoutTestController::queueReload):
3675         (LayoutTestController::queueScript):
3676         (LayoutTestController::provisionalLoad):
3677         (LayoutTestController::timerEvent):
3678         (LayoutTestController::encodeHostName):
3679         (LayoutTestController::decodeHostName):
3680         (LayoutTestController::setJavaScriptProfilingEnabled):
3681         (LayoutTestController::setFixedContentsSize):
3682         (LayoutTestController::setPrivateBrowsingEnabled):
3683         (LayoutTestController::setPopupBlockingEnabled):
3684         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3685         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3686         (LayoutTestController::numberOfActiveAnimations):
3687         (LayoutTestController::disableImageLoading):
3688         (LayoutTestController::dispatchPendingLoadRequests):
3689         (LayoutTestController::setDatabaseQuota):
3690         (LayoutTestController::clearAllDatabases):
3691         (LayoutTestController::whiteListAccessFromOrigin):
3692         (LayoutTestController::waitForPolicyDelegate):
3693         (LayoutTestController::overridePreference):
3694         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3695         (LayoutTestController::isLoading):
3696         (LayoutTestController::setLoading):
3697         (LayoutTestController::shouldDumpAsText):
3698         (LayoutTestController::shouldDumpBackForwardList):
3699         (LayoutTestController::shouldDumpChildrenAsText):
3700         (LayoutTestController::shouldDumpDatabaseCallbacks):
3701         (LayoutTestController::shouldDumpStatusCallbacks):
3702         (LayoutTestController::shouldWaitUntilDone):
3703         (LayoutTestController::canOpenWindows):
3704         (LayoutTestController::shouldDumpTitleChanges):
3705         (LayoutTestController::waitForPolicy):
3706         (LayoutTestController::dumpAsText):
3707         (LayoutTestController::dumpChildFramesAsText):
3708         (LayoutTestController::dumpDatabaseCallbacks):
3709         (LayoutTestController::dumpStatusCallbacks):
3710         (LayoutTestController::setCanOpenWindows):
3711         (LayoutTestController::dumpBackForwardList):
3712         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3713         (LayoutTestController::display):
3714         (LayoutTestController::dumpTitleChanges):
3715         (LayoutTestController::dumpSelectionRect):
3716         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3717         (TextInputController::TextInputController):
3718         (TextInputController::doCommand):
3719         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3720         * DumpRenderTree/qt/WorkQueue.cpp:
3721         * DumpRenderTree/qt/WorkQueue.h:
3722         * DumpRenderTree/qt/WorkQueueItem.h:
3723         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3724         (findFrameNamed):
3725         (LoadItem::invoke):
3726         (ReloadItem::invoke):
3727         (ScriptItem::invoke):
3728         (BackForwardItem::invoke):
3729         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3730         * DumpRenderTree/qt/jsobjects.h:
3731
3732 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3733
3734         Not reviewed, adding myself to the list of reviewers.
3735
3736         * Scripts/modules/committers.py:
3737
3738 2009-10-13  Anders Carlsson  <andersca@apple.com>
3739
3740         Reviewed by Sam Weinig.
3741
3742         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3743
3744         Make the private browsing mode testable by the test plug-in.
3745
3746         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3747         (pluginGetProperty):
3748         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3749         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3750         (NPP_New):
3751         (NPP_SetValue):
3752
3753 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3754
3755         No review, just adding self to the list of reviewers.
3756
3757         * Scripts/modules/committers.py:
3758
3759 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3760
3761         Reviewed by Adam Roben.
3762
3763         Web Inspector: Use proper web view in inspector layout
3764         tests for windows.
3765
3766         https://bugs.webkit.org/show_bug.cgi?id=30298
3767
3768         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3769         (LayoutTestController::showWebInspector):
3770         (LayoutTestController::closeWebInspector):
3771         (LayoutTestController::evaluateInWebInspector):
3772
3773 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3774
3775         Reviewed by Sam Weinig.
3776
3777         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3778         https://bugs.webkit.org/show_bug.cgi?id=29841
3779
3780         * DumpRenderTree/mac/DumpRenderTree.mm:
3781         (resetDefaultsToConsistentValues):
3782         * DumpRenderTree/win/DumpRenderTree.cpp:
3783         (resetDefaultsToConsistentValues):
3784
3785 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3786
3787         Reviewed by Dimitri Glazkov.
3788
3789         Chromium Port - Windows
3790         https://bugs.webkit.org/show_bug.cgi?id=29969
3791
3792         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3793         * Scripts/webkitdirs.pm:
3794
3795 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3796
3797         Reviewed by Darin Adler.
3798
3799         jsc scripts cleanup and Qt/GTK fix
3800         https://bugs.webkit.org/show_bug.cgi?id=30288
3801
3802         Duplicated jscPath() moved to webkitdirs.pm.
3803         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3804         Configuration added (release/debug) to path for Qt-port on Windows.
3805
3806         * Scripts/run-javascriptcore-tests:
3807         * Scripts/run-jsc:
3808         * Scripts/run-sunspider:
3809         * Scripts/sunspider-compare-results:
3810         * Scripts/webkitdirs.pm:
3811
3812 2009-10-11  Adam Barth  <abarth@webkit.org>
3813
3814         Unreviewed.  Add Collin to committers.py.
3815
3816         * Scripts/modules/committers.py:
3817
3818 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3819
3820         wx build fix, add bindings to source/include dirs now that there are sources there.
3821
3822         * wx/build/settings.py:
3823
3824 2009-10-09  Mark Rowe  <mrowe@apple.com>
3825
3826         Reviewed by Brady Eidson.
3827
3828         Enable plug-in halting in DumpRenderTree.
3829
3830         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3831         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3832
3833         * DumpRenderTree/mac/DumpRenderTree.mm:
3834         (resetDefaultsToConsistentValues):
3835         * DumpRenderTree/mac/UIDelegate.mm:
3836         (-[UIDelegate webView:shouldHaltPlugin:]):
3837
3838 2009-10-08  Brady Eidson  <beidson@apple.com>
3839
3840         Reviewed by Dan Bernstein.
3841
3842         Ask the History Delegate to populate the visited links hash.
3843         <rdar://problem/7285293> and https://webkit.org/b/29904
3844
3845         Add the ability for LayoutTestController to clear all visited links.
3846         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3847
3848         * DumpRenderTree/LayoutTestController.cpp:
3849         (LayoutTestController::LayoutTestController):
3850         (removeAllVisitedLinksCallback):
3851         (LayoutTestController::staticFunctions):
3852         * DumpRenderTree/LayoutTestController.h:
3853         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3854         (LayoutTestController::removeAllVisitedLinks):
3855
3856         * DumpRenderTree/mac/HistoryDelegate.mm:
3857         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3858
3859         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3860         (LayoutTestController::removeAllVisitedLinks):
3861         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3862         (LayoutTestController::removeAllVisitedLinks):
3863         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3864         (LayoutTestController::removeAllVisitedLinks):
3865
3866
3867 2009-10-08  Daniel Bates  <dbates@webkit.org>
3868
3869         Reviewed by Adam Roben.
3870
3871         https://bugs.webkit.org/show_bug.cgi?id=30175
3872
3873         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3874         the OLE drag-and-drop return value like the function it emulates. Currently,
3875         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine
3876         whether the drag-and-drop operation was successful or was cancelled.
3877
3878         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop
3879         return value according to whether the drop operation was successful or not.
3880
3881         * DumpRenderTree/win/EventSender.cpp:
3882         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3883         (replaySavedEvents): Ditto.
3884         * DumpRenderTree/win/EventSender.h:
3885         * DumpRenderTree/win/UIDelegate.cpp:
3886         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3887
3888 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3889
3890         Reviewed by Xan Lopez.
3891
3892         [GTK] Added support for a parameter setting the button that was
3893         pressed in the mouseDown function.
3894         https://bugs.webkit.org/show_bug.cgi?id=30220
3895
3896         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3897
3898 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3899
3900         Reviewed by Xan Lopez.
3901
3902         [GTK] Added a line to the bottom of the expected result to match
3903         the output of the test.
3904         https://bugs.webkit.org/show_bug.cgi?id=30220
3905
3906         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3907         expected.txt:
3908
3909 2009-10-08  Adam Roben  <aroben@apple.com>
3910
3911         Use QueryInterface to get IWebInspectorPrivate
3912
3913         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3914         accessed in a more standard way
3915
3916         Reviewed by John Sullivan and Tim Hatcher.
3917
3918         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3919         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3920         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3921         to the IWebInspectorPrivate interface.
3922
3923 2009-10-07  Adam Roben  <aroben@apple.com>
3924
3925         Implement DRT support for origin whitelisting
3926
3927         Fixes <http://webkit.org/b/30185>.
3928
3929         Reviewed by Eric Seidel.
3930
3931         * DumpRenderTree/win/DumpRenderTree.cpp:
3932         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3933         whitelist, to match Mac DRT.
3934         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3935         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3936         IWebViewPrivate::whiteListAccessFromOrigin.
3937
3938 2009-10-07  Brady Eidson  <beidson@apple.com>
3939
3940         Reviewed by Darin Adler.
3941
3942         Send title changes to the global history delegate.
3943         <rdar://problem/7285293> and https://webkit.org/b/29904
3944
3945         * DumpRenderTree/mac/HistoryDelegate.mm:
3946         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3947
3948 2009-10-07  Adam Barth  <abarth@webkit.org>
3949
3950         Unreviewed.  Remove some folks from committers.py who were listed on
3951         the WebKit Team wiki page but who weren't actually listed as commit+.
3952         At some point, we should coorelate this list with the committers
3953         mailing list.
3954
3955         * Scripts/modules/committers.py:
3956
3957 2009-10-07  Adam Barth  <abarth@webkit.org>
3958
3959         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3960         the wiki into committers.py.
3961
3962         * Scripts/modules/committers.py:
3963
3964 2009-10-07  Adam Barth  <abarth@webkit.org>
3965
3966         Unreviewed.  Added Aaron Boodman to committers.py.
3967
3968         * Scripts/modules/committers.py:
3969
3970 2009-10-07  Evan Martin  <evan@chromium.org>
3971
3972         Reviewed by Darin Adler.
3973
3974         Add API to LayoutTestController for re/setting the system locale.
3975         https://bugs.webkit.org/show_bug.cgi?id=18994
3976
3977         * DumpRenderTree/LayoutTestController.cpp:
3978         (setLocaleCallback):
3979         (LayoutTestController::staticFunctions):
3980         (LayoutTestController::setLocale):
3981         * DumpRenderTree/LayoutTestController.h:
3982
3983 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3984
3985         Reviewed by Jan Alonzo.
3986
3987         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3988         https://bugs.webkit.org/show_bug.cgi?id=29689
3989
3990         Build fix by adding -lfontconfig for DumpRenderTree.
3991
3992         * GNUmakefile.am:
3993
3994 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3995
3996         Reviewed by Simon Hausmann.
3997
3998         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3999
4000         * Scripts/run-webkit-tests:
4001
4002 2009-10-07  Xan Lopez  <xlopez@igalia.com>
4003
4004         Reviewed by Gustavo Noronha.
4005
4006         "delete" in EventSender is the backspace key, not the delete one.
4007
4008         * DumpRenderTree/gtk/EventSender.cpp:
4009         (keyDownCallback):
4010
4011 2009-10-07  Xan Lopez  <xlopez@igalia.com>
4012
4013         Reviewed by Gustavo Noronha.
4014
4015         getChildrenWithRange expects as last parameter the end index, not
4016         the length of the range. Correct this and clarify the variable
4017         names to reflect how the code works.
4018
4019         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4020         (AccessibilityUIElement::getChildrenWithRange):
4021         (AccessibilityUIElement::getChildAtIndex):
4022
4023 2009-10-06  Mark Rowe  <mrowe@apple.com>
4024
4025         Reviewed by Simon Fraser.
4026
4027         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
4028
4029         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
4030         the fact we have already changed the working directory to the top of the open source tree.
4031
4032 2009-10-06  Julie Parent  <jparent@chromium.org>
4033
4034         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
4035         rather than my committer email.
4036
4037         * Scripts/modules/committers.py:
4038
4039 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
4040
4041         Reviewed by Eric Seidel.
4042
4043         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
4044
4045         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
4046         it after each layout test as it should do, making the DRT dump additional output
4047         for all of the subsequent layout tests.
4048
4049         * DumpRenderTree/qt/jsobjects.cpp:
4050         (LayoutTestController::reset):
4051
4052 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
4053
4054         Reviewed by Simon Hausmann.
4055
4056         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
4057         fast/dom/assign-to-window-status.html test, which is passing as a result.
4058
4059         https://bugs.webkit.org/show_bug.cgi?id=30127
4060
4061         * DumpRenderTree/qt/DumpRenderTree.cpp:
4062         (WebCore::DumpRenderTree::DumpRenderTree):
4063         (WebCore::DumpRenderTree::statusBarMessage):
4064         * DumpRenderTree/qt/DumpRenderTree.h:
4065         * DumpRenderTree/qt/jsobjects.h:
4066         (LayoutTestController::shouldDumpStatusCallbacks):
4067         (LayoutTestController::dumpStatusCallbacks):
4068
4069 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
4070
4071         Reviewed by Simon Hausmann.
4072
4073         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
4074         ignores the argument indicating which mouse button to trigger.
4075         https://bugs.webkit.org/show_bug.cgi?id=30048
4076
4077         This affects the fast/events/mouse-click-events.html layout test.
4078
4079         * DumpRenderTree/qt/jsobjects.cpp:
4080         (EventSender::mouseDown):
4081         (EventSender::mouseUp):
4082         * DumpRenderTree/qt/jsobjects.h:
4083
4084 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
4085
4086         Reviewed by Simon Hausmann.
4087
4088         [Qt] Fix the EventSender::keyDown() implementation
4089         https://bugs.webkit.org/show_bug.cgi?id=30043
4090
4091         It should post both a key press event and a key release event,
4092         just like other ports do.
4093
4094         * DumpRenderTree/qt/jsobjects.cpp:
4095         (EventSender::keyDown):
4096
4097 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
4098
4099         wx build fix. Add jpeg to the list of libs to link against.
4100
4101         * wx/build/settings.py:
4102
4103 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
4104
4105         Reviewed by Simon Hausmann.
4106
4107         [Qt] EventSender::keyDown() cannot send function-key events.
4108         https://bugs.webkit.org/show_bug.cgi?id=30044
4109
4110         This affects the fast/events/keydown-function-keys.html layout test.
4111
4112         * DumpRenderTree/qt/jsobjects.cpp:
4113         (EventSender::keyDown):
4114
4115 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
4116
4117         Added --wx-compiler-prefix waf option to allow building wxWebKit with
4118         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
4119
4120         * wx/build/settings.py:
4121         * wx/build/wxpresets.py:
4122
4123 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
4124
4125         Reviewed by Timothy Hatcher.
4126
4127         Web Inspector: add testing harness for Web Inspector.
4128
4129         https://bugs.webkit.org/show_bug.cgi?id=30010
4130
4131         * DumpRenderTree/LayoutTestController.cpp:
4132         (showWebInspectorCallback):
4133         (closeWebInspectorCallback):
4134         (evaluateInWebInspectorCallback):
4135         (LayoutTestController::staticFunctions):
4136         * DumpRenderTree/LayoutTestController.h:
4137         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4138         (LayoutTestController::showWebInspector):
4139         (LayoutTestController::closeWebInspector):
4140         (LayoutTestController::evaluateInWebInspector):
4141         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4142         (LayoutTestController::showWebInspector):
4143         (LayoutTestController::closeWebInspector):
4144         (LayoutTestController::evaluateInWebInspector):
4145         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4146         (LayoutTestController::showWebInspector):
4147         (LayoutTestController::closeWebInspector):
4148         (LayoutTestController::evaluateInWebInspector):
4149         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4150         (LayoutTestController::showWebInspector):
4151         (LayoutTestController::closeWebInspector):
4152         (LayoutTestController::evaluateInWebInspector):
4153
4154 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4155
4156         Reviewed by Ariyha Hidayat.
4157
4158         Pass arguments to system() as a string instead of array
4159
4160         When passed as an array entries with a space fail to translate
4161         to two arguments to the child process, so instead of manually
4162         splitting all the entries in @buildArgs we pass the whole thing
4163         as a string instead.
4164
4165         * Scripts/webkitdirs.pm:
4166
4167 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
4168
4169         Reviewed by David Levin.
4170
4171         check-webkit-style misses whitespace errors for operators:
4172         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
4173         https://bugs.webkit.org/show_bug.cgi?id=30021
4174
4175         * Scripts/modules/cpp_style.py:
4176         Added the operators mentioned above to the same list as == and !=.
4177
4178 2009-10-02  Julie Parent  <jparent@chromium.org>
4179
4180         Unreviewed.
4181
4182         Adding myself and Ojan Vafai as committers, because we are committers.
4183
4184         * Scripts/modules/committers.py:
4185
4186 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
4187
4188         Reviewed by Adam Roben.
4189
4190         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
4191         this will help the patch merging process when TryBots are used.
4192
4193         * Scripts/svn-create-patch:
4194
4195 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
4196
4197         Reviewed by Simon Hausmann.
4198
4199         [Qt] Implement layoutTestController.overridePreference().
4200         https://bugs.webkit.org/show_bug.cgi?id=29970
4201
4202         * DumpRenderTree/qt/DumpRenderTree.cpp:
4203         (WebCore::WebPage::WebPage):
4204         (WebCore::WebPage::resetSettings):
4205         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4206         * DumpRenderTree/qt/jsobjects.cpp:
4207         (LayoutTestController::reset):
4208         (LayoutTestController::setPrivateBrowsingEnabled):
4209         (LayoutTestController::setPopupBlockingEnabled):
4210         (LayoutTestController::overridePreference):
4211         * DumpRenderTree/qt/jsobjects.h:
4212
4213 2009-10-01  Chris Marrin  <cmarrin@apple.com>
4214
4215         Reviewed by Oliver Hunt.
4216
4217         Turn on ENABLE_3D_CANVAS in TOT
4218         https://bugs.webkit.org/show_bug.cgi?id=29906
4219
4220         * Scripts/build-webkit:
4221
4222 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4223
4224         Rubberstamped by Simon Hausmann.
4225
4226         Enable HTTP tests for Qt
4227
4228         * Scripts/run-webkit-tests:
4229
4230 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
4231
4232         Reviewed by Dimitri Glazkov.
4233
4234         build-webkit --chromium now also works on cygwin.
4235
4236         https://bugs.webkit.org/show_bug.cgi?id=29973
4237
4238         * Scripts/webkitdirs.pm:
4239
4240 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
4241
4242         Reviewed by Simon Hausmann.
4243
4244         [Qt] Don't use TCmalloc in DumpRenderTree
4245         https://bugs.webkit.org/show_bug.cgi?id=27029
4246
4247         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
4248
4249         * DumpRenderTree/qt/DumpRenderTree.pro:
4250
4251 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
4252
4253         Reviewed by Simon Hausmann.
4254
4255         [Qt] Implement eventSender.scheduleAsynchronousClick().
4256
4257         https://bugs.webkit.org/show_bug.cgi?id=29931
4258
4259         * DumpRenderTree/qt/jsobjects.cpp:
4260         (EventSender::scheduleAsynchronousClick):
4261         * DumpRenderTree/qt/jsobjects.h:
4262
4263 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
4264
4265         Reviewed by Simon Hausmann.
4266
4267         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
4268         fast/events/open-window-from-another-frame.html from the Skipped list.
4269
4270         https://bugs.webkit.org/show_bug.cgi?id=29930
4271
4272         * DumpRenderTree/qt/jsobjects.cpp:
4273         (LayoutTestController::setPopupBlockingEnabled):
4274         * DumpRenderTree/qt/jsobjects.h:
4275
4276 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
4277
4278         Unreviewed.
4279
4280         Added myself to the list of committers.
4281
4282         * Scripts/modules/committers.py:
4283
4284 2009-09-30  Eric Seidel  <eric@webkit.org>
4285
4286         No review, just adding Geoff to the list of reviewers.
4287
4288         * Scripts/modules/committers.py:
4289
4290 2009-09-30  Dan Bernstein  <mitz@apple.com>
4291
4292         Reviewed by Sam Weinig.
4293
4294         Added the WebKit Layout Tests fonts that are referenced in
4295         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
4296
4297         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
4298         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
4299
4300 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
4301
4302         Reviewed by David Kilzer.
4303
4304         Make sunspider scripts work on Windows platform.
4305         https://bugs.webkit.org/show_bug.cgi?id=29656
4306
4307         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
4308         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
4309         * Scripts/webkitdirs.pm: currentPerlPath() added.
4310
4311 2009-09-29  Brady Eidson  <beidson@apple.com>
4312
4313         Rubberstamped by Dan Bernstein.
4314
4315         Fix license and some sorting in new files.
4316
4317         * DumpRenderTree/mac/HistoryDelegate.h:
4318         * DumpRenderTree/mac/HistoryDelegate.mm:
4319
4320 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
4321
4322         Reviewed by David Kilzer.
4323
4324         Fixed how error codes are handled.
4325         https://bugs.webkit.org/show_bug.cgi?id=29898
4326
4327         * Scripts/update-webkit:
4328         * Scripts/update-webkit-chromium:
4329
4330 2009-09-29  Brady Eidson  <beidson@apple.com>
4331
4332         Reviewed by John Sullivan.
4333
4334         Updated way-out-of-date sorting throughout the dump methods/flags.
4335
4336         * DumpRenderTree/LayoutTestController.cpp:
4337         (LayoutTestController::LayoutTestController):
4338         (dumpAsPDFCallback):
4339         (dumpAsTextCallback):
4340         (dumpFrameLoadCallbacksCallback):
4341         (dumpResourceLoadCallbacksCallback):
4342         (LayoutTestController::staticFunctions):
4343
4344         * DumpRenderTree/LayoutTestController.h:
4345         (LayoutTestController::dumpAsText):
4346         (LayoutTestController::setDumpAsText):
4347         (LayoutTestController::dumpFrameLoadCallbacks):
4348         (LayoutTestController::setDumpFrameLoadCallbacks):
4349         (LayoutTestController::dumpSelectionRect):
4350         (LayoutTestController::setDumpSelectionRect):
4351         (LayoutTestController::dumpSourceAsWebArchive):
4352         (LayoutTestController::setDumpSourceAsWebArchive):
4353         (LayoutTestController::dumpStatusCallbacks):
4354         (LayoutTestController::setDumpStatusCallbacks):
4355         (LayoutTestController::dumpTitleChanges):
4356         (LayoutTestController::setDumpTitleChanges):
4357         (LayoutTestController::dumpWillCacheResponse):
4358         (LayoutTestController::setDumpWillCacheResponse):
4359
4360 2009-09-29  Brady Eidson  <beidson@apple.com>
4361
4362         Reviewed by John Sullivan.
4363
4364         WebKit Mac API should provide a delegate interface for global history.
4365         <rdar://problem/7042773> and https://webkit.org/b/29904
4366
4367         Adding the dumping of global history delegate callbacks.
4368
4369         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4370
4371         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
4372         * DumpRenderTree/mac/DumpRenderTree.mm:
4373         (createWebViewAndOff