Reviewed by Mark Rowe.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-01-25  Alexey Proskuryakov  <ap@webkit.org>
2
3         Reviewed by Mark Rowe.
4
5         <rdar://problem/5699933> http/tests/security/cross-frame-access-get.html is still failing
6
7         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Clear HTTP cache to ensure consistent test environment
8         (matching Mac DRT).
9         * DumpRenderTree/win/DumpRenderTree.vcproj: Link to CFNetwork.
10
11 2008-01-24  Sam Weinig  <sam@webkit.org>
12
13         Reviewed by Ada Chan.
14
15         Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo
16
17         - Adds simplified UndoManager to windows DRT to allow testing the
18           undo/redo code paths in WebCore and WebKit.  This is a temporary
19           solution to an issue that should eventually be solved by having a
20           shared UndoManager in WebKit.
21
22         * DumpRenderTree/win/DumpRenderTree.cpp:
23         (runTest):
24         * DumpRenderTree/win/UIDelegate.cpp:
25         (DRTUndoObject::DRTUndoObject):
26         (DRTUndoObject::invoke):
27         (DRTUndoStack::~DRTUndoStack):
28         (DRTUndoStack::isEmpty):
29         (DRTUndoStack::clear):
30         (DRTUndoStack::push):
31         (DRTUndoStack::pop):
32         (DRTUndoManager::canRedo):
33         (DRTUndoManager::canUndo):
34         (DRTUndoManager::DRTUndoManager):
35         (DRTUndoManager::removeAllActions):
36         (DRTUndoManager::registerUndoWithTarget):
37         (DRTUndoManager::redo):
38         (DRTUndoManager::undo):
39         (UIDelegate::UIDelegate):
40         (UIDelegate::resetUndoManager):
41         (UIDelegate::registerUndoWithTarget):
42         (UIDelegate::removeAllActionsWithTarget):
43         (UIDelegate::setActionTitle):
44         (UIDelegate::undo):
45         (UIDelegate::redo):
46         (UIDelegate::canUndo):
47         (UIDelegate::canRedo):
48         * DumpRenderTree/win/UIDelegate.h:
49
50 2008-01-23  Adam Roben  <aroben@apple.com>
51
52         Allow directories containing ChangeLogs to be passed to
53         resolve-ChangeLogs
54
55         Reviewed by David Kilzer.
56
57         * Scripts/resolve-ChangeLogs:
58         (sub findChangeLog): Return a ChangeLog contained within the specified
59         directory if one exists.
60
61 2008-01-23  Steve Falkenburg  <sfalken@apple.com>
62
63         <rdar://problem/5698732> Copyright strings should include 2008
64
65         Reviewed by Sam.
66
67         * Drosera/win/Drosera.vcproj/Drosera.rc:
68         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
69
70 2008-01-23  Alp Toker  <alp@atoker.com>
71
72         Rubber-stamped by Mark Rowe.
73
74         Remove whitespace after -I in automake include lists.
75
76         * GNUmakefile.am:
77
78 2008-01-23  Michael Goddard <michael.goddard@trolltech.com>
79
80         Reviewed by Lars Knoll <lars@trolltech.com>.
81
82         Reworked the JavaScriptCore Qt bindings:
83         
84         * Update JS DRT controller for Qt JS binding changes.
85         There were two functions that needed some changes
86         so that the layout tests would work, so this makes
87         a few tests pass again.
88         
89         * Bump the timeout for layout tests up to 11s.
90         At least some tests have an internal timeout of
91         10 seconds, so make the waitUntilDone approach
92         wait at least 11s.  fast/dom/open-and-close-by-DOM.html
93         is one of these - now the failure message is more
94         accurate.
95         
96
97         * DumpRenderTree/qt/jsobjects.cpp:
98         (LayoutTestController::waitUntilDone):
99         * DumpRenderTree/qt/jsobjects.h:
100
101 2008-01-22  Anders Carlsson  <andersca@apple.com>
102
103         Reviewed by Darin and Adam.
104
105         <rdar://problem/5688975>
106         div element on microsoft site has wrong left offset.
107         
108         Add new method for testing the return vale of NPN_GetProperty.
109         
110         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
111         (pluginInvoke):
112
113 2008-01-22  Alexey Proskuryakov  <ap@webkit.org>
114
115         Reviewed by Adam Roben.
116
117         <rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail
118
119         * DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.
120
121 2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
122
123         Reviewed by Alp Toker.
124
125         http://bugs.webkit.org/show_bug.cgi?id=16955
126         Get errors when cross-compile webkit-gtk
127
128         * GNUmakefile.am: Removed ICU_CFLAGS 
129
130 2008-01-21  Darin Adler  <darin@apple.com>
131
132         Reviewed by Mitz and Adam.
133
134         * Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the
135         sorting speed by doing all sort criteria in a single pass instead of three sorts.
136
137 2008-01-21  Simon Hausmann  <hausmann@webkit.org>
138
139         Reviewed by Holger.
140
141         Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
142         
143         * Fix GraphicsContext::drawFocusRing to also draw single focus rects.
144         * Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
145         and make the return value depend on whether we successfully determined a focusable
146         node or not.
147         * Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
148         if we could not handle the focus chain ourselves.
149         * Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
150         * Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
151         used to control the situation of stepping out of the focus chain inside the page.
152         * Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
153         The layout tests expect this to be disabled but for the user it seems sensible to have it
154         on by default, hence the default in qwebsettings.cpp
155         
156
157         * DumpRenderTree/qt/DumpRenderTree.cpp:
158         (WebCore::WebPage::WebPage):
159
160 2008-01-19  Mark Rowe  <mrowe@apple.com>
161
162         Reviewed by Alp Toker.
163
164         Allow the --http flag to run-webkit-tests to override
165         the default behaviour of disabling HTTP tests for Qt,
166         Gtk and Wx.
167
168         * Scripts/run-webkit-tests:
169
170 2008-01-19  David Kilzer  <ddkilzer@apple.com>
171
172         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
173
174         Reviewed by Darin.
175
176         We now touch a check-for-global-initializers.timestamp file in
177         the TARGET_TEMP_DIR directory to determine when new object files
178         have been compiled and thus need to be checked.  If the timestamp
179         file doesn't exist, all object files will be checked.
180
181         Previously the modification time of the "executable" (the
182         framework binary, e.g., WebKit.framework/WebKit) was used, but
183         since this was the last file modified at the end of the compile
184         phase, no object files would ever get checked!
185
186         Also added JSCustomSQLTransactionCallback.o to the list of files
187         since it has static initializers in Debug builds of WebCore.
188
189         * Scripts/check-for-global-initializers:
190
191 2008-01-18  Adam Roben  <aroben@apple.com>
192
193         Build fix
194
195         * Scripts/build-webkit:
196
197 2008-01-18  Beth Dakin  <bdakin@apple.com>
198
199         Reviewed by Oliver.
200
201         Update build-webkit to account for foreign-object being disabled by 
202         default.
203
204         * Scripts/build-webkit:
205
206 2008-01-18  Adam Roben  <aroben@apple.com>
207
208         Updated for method renames
209
210         Reviewed by Adele.
211
212         * DumpRenderTree/mac/FrameLoadDelegate.mm:
213         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
214         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
215         (LayoutTestController::setMainFrameIsFirstResponder):
216         (LayoutTestController::setWindowIsKey):
217         * DumpRenderTree/mac/UIDelegate.mm:
218         (-[UIDelegate webViewFocus:]):
219         * DumpRenderTree/win/FrameLoadDelegate.cpp:
220         (FrameLoadDelegate::didCommitLoadForFrame):
221
222 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
223
224         Reviewed by Adam Roben.
225
226         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
227         between DRT and TestNetscapePlugin.
228
229         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
230         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
231
232 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
233
234         Reviewed by Holger.
235
236         Fix fast/dom/Window/window-resize.html
237         
238         In DRT connect the page's geometryChangeRequest signal to a slot that
239         sets the geometry of the view widget.
240         
241
242         * DumpRenderTree/qt/DumpRenderTree.cpp:
243         (WebCore::WebPage::setViewGeometry):
244         (WebCore::WebPage::WebPage):
245
246 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
247
248         Build fix.
249
250         * Drosera/DroseraWin.make:
251
252 2008-01-17  Darin Adler  <darin@apple.com>
253
254         * Scripts/run-webkit-tests: Fixed a bug number.
255
256 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
257
258         Reviewed by Adam Roben.
259
260         http://bugs.webkit.org/show_bug.cgi?id=16908
261         run-webkit-tests complains about missing FindSafari.exe
262
263         * Scripts/webkitdirs.pm: Append _debug as appropriate.
264
265 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
266
267         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
268         
269         Rubber-stamped by Jon Honeycutt.
270
271         * DumpRenderTree/win/DumpRenderTree.vcproj:
272
273 2008-01-16  Alp Toker  <alp@atoker.com>
274
275         Reviewed by Mark Rowe.
276
277         http://bugs.webkit.org/show_bug.cgi?id=16218
278         [GTK] API: Should this entry point be called go_back rather than go_backward?
279
280         Track back/forward API changes in the tools.
281
282         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
283         (BackForwardItem::invoke):
284         * GtkLauncher/main.c:
285         (go_back_cb):
286
287 2008-01-16  Adam Roben  <aroben@apple.com>
288
289         Windows build fix after r29488
290
291         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
292         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
293         expects to find the plugin.
294
295 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
296
297         Reviewed by Sam Weinig.
298         
299         Fixed the waitUntilDone watchdog timer -- the old code never added the
300         timer to the run loop, so it didn't do anything.
301
302         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
303         (LayoutTestController::setWaitToDump):
304         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
305         (LayoutTestController::setWaitToDump):
306
307 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
308
309         Use shared vsprops for most vcproj properties.
310         
311         Reviewed by Darin.
312
313         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
314         * DumpRenderTree/win/DumpRenderTree.vcproj:
315         * DumpRenderTree/win/ImageDiff.vcproj:
316         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
317         * FindSafari/FindSafari.vcproj:
318
319 2008-01-14  Stephanie  <slewis@apple.com>
320
321        Reviewed by NOBODY.
322   
323        revert accidental character.
324
325        * Scripts/run-webkit-tests:
326
327 2008-01-14  Stephanie  <slewis@apple.com>
328
329         RS=Oliver
330
331         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
332
333         * Scripts/run-webkit-tests:
334
335 2008-01-14  Darin Adler  <darin@apple.com>
336
337         * Scripts/do-webcore-rename: Queue up another rename.
338
339 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
340
341         Reviewed by Darin.
342
343         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
344         the tests were ran.
345         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
346
347         * Scripts/run-webkit-tests:
348
349 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
350
351         Reviewed by Darin.
352
353         * Randomize tests array to spot test cases where the results depends on the order
354         the tests are ran.
355         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
356
357         * Scripts/run-webkit-tests:
358
359 2008-01-14  Darin Adler  <darin@apple.com>
360
361         * Scripts/run-webkit-tests: More ignore list tweaking.
362
363 2008-01-14  Darin Adler  <darin@apple.com>
364
365         * Scripts/run-webkit-tests: Add another leak to the ignore list.
366
367 2008-01-14  Dan Bernstein  <mitz@apple.com>
368
369         Reviewed by Adam Roben.
370
371         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
372           build bots
373
374         * DumpRenderTree/win/DumpRenderTree.cpp:
375         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
376
377 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
378
379         Share common files across projects.
380         
381         Unify vsprops files
382         Debug:          common.vsprops, debug.vsprops
383         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
384         Release:        common.vsprops, release.vsprops
385         
386         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
387         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
388
389         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
390
391         Reviewed by Adam Roben.
392
393         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
394         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
395         * Drosera/win/Drosera.vcproj/VERSION: Removed.
396         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
397         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
398         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
399         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
400         * DumpRenderTree/win/DumpRenderTree.vcproj:
401         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
402         * DumpRenderTree/win/debug.vsprops: Removed.
403         * DumpRenderTree/win/debug_internal.vsprops: Removed.
404         * DumpRenderTree/win/release.vsprops: Removed.
405
406 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
407
408         Reviewed by Maciej.
409
410         - http://bugs.webkit.org/show_bug.cgi?id=16314
411           Script to launch Drosera
412
413         * Scripts/gdb-drosera: Added.
414         * Scripts/run-drosera: Added.
415         * Scripts/run-drosera-nightly.cmd: Added.
416         * Scripts/webkitdirs.pm: Added runDrosera function.
417
418 2008-01-13  Dan Bernstein  <mitz@apple.com>
419
420         - fix breakage due to last-minute change
421
422         * DumpRenderTree/win/DumpRenderTree.cpp:
423         (runTest): Declare the loop variable.
424
425 2008-01-13  Dan Bernstein  <mitz@apple.com>
426
427         Reviewed by Adam Roben.
428
429         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
430
431         * DumpRenderTree/win/DumpRenderTree.cpp:
432         (DumpRenderTreeWndProc):
433         (initialize):
434         (dumpBackForwardList):
435         (dumpBackForwardListForAllWindows):
436         (dump):
437         (resetWebViewToConsistentStateBeforeTesting): Factored out of
438         runTest().
439         (runTest):
440         (allWindows): Added. Returns a vector of all open windows.
441         (windowToWebViewMap): Added. Returns a map from open windows to their
442         WebViews.
443         (createWebViewAndOffscreenWindow): Factored out of main() to be
444         reusable for creating extra windows.
445         (main):
446         * DumpRenderTree/win/DumpRenderTreeWin.h:
447         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
448         (LayoutTestController::windowCount): Implemented.
449         * DumpRenderTree/win/UIDelegate.cpp:
450         (UIDelegate::createWebViewWithRequest): Implemented.
451         (UIDelegate::webViewClose): Implemented.
452         * DumpRenderTree/win/UIDelegate.h:
453
454 2008-01-12  Alp Toker  <alp@atoker.com>
455
456         Reviewed by Mark Rowe.
457
458         Hide non-public symbols in GTK+/autotools release builds.
459
460         * GNUmakefile.am:
461
462 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
463
464         Reviewed by Ap.
465
466         * Make launching of the WebKit httpd work on GNU/Debian/Linux
467         
468         The configuration of Apache2 and installation does not depend on
469         the kernel but on the distribution policy. Make launching of httpd
470         work for Debian derived distributions.
471
472         * Scripts/run-webkit-httpd:
473         * Scripts/run-webkit-tests:
474         * Scripts/webkitdirs.pm:
475
476 2008-01-12  Mark Rowe  <mrowe@apple.com>
477
478         Reviewed by Maciej Stachowiak.
479
480         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
481
482         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
483         match the callers expectations that it can take ownership of the string.
484
485 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
486
487         Reviewed by Adam Roben.
488
489         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
490
491         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
492         as these are only posted because the test window is not a normal visible one, and
493         they confuse drag&drop machinery.
494
495 2008-01-11  Adam Roben  <aroben@apple.com>
496
497         Fix a crash when pathToLocalResource fails and a leak
498
499         Reviewed by Darin.
500
501         * DumpRenderTree/LayoutTestController.cpp:
502         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
503         sure not to pass null to JSValueMakeString.
504         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
505         (LayoutTestController::pathToLocalResource): Print an error message if
506         the conversion fails so it's clear what happened.
507
508 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
509
510         Reviewed by John Sullivan.
511
512         * DumpRenderTree/mac/GCControllerMac.mm:
513         (GCController::collectOnAlternateThread): Updated for name change.
514
515 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
516
517         wx build fix. Don't build dftables any longer since it's now a Perl
518         script.
519
520         * wx/build-wxwebkit:
521
522 2008-01-10  Sam Weinig  <sam@webkit.org>
523
524         Reviewed by Anders Carlsson.
525
526         Make DRT track open windows instead of allocated windows so that
527         we can avoid ASSERTION due to late deallocs out of our control.
528
529         * DumpRenderTree/mac/DumpRenderTree.mm:
530         (dumpBackForwardListForAllWindows):
531         (runTest):
532         * DumpRenderTree/mac/DumpRenderTreeMac.h:
533         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
534         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
535         (+[DumpRenderTreeWindow openWindows]):
536         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
537         (-[DumpRenderTreeWindow close]):
538         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
539         (LayoutTestController::windowCount):
540
541 2008-01-10  Ada Chan  <adachan@apple.com>
542
543         Meta key is not the same as Alt key on windows.
544
545         Reviewed by Darin.
546
547         * DumpRenderTree/win/EventSender.cpp:
548         (keyDownCallback):
549
550 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
551
552         Reviewed by Darin, Sam and Adam.
553
554         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
555         link in gmail message displays JavaScript alert falsely complaining
556         about pop-up blocking.
557         - Added the ability to enable the pop-up blocker via the
558         LayoutTestController.
559
560         * DumpRenderTree/LayoutTestController.cpp:
561         (setPopupBlockingEnabledCallback):
562         (LayoutTestController::staticFunctions):
563         * DumpRenderTree/LayoutTestController.h:
564         * DumpRenderTree/mac/DumpRenderTree.mm:
565         (setDefaultsToConsistentValuesForTesting):
566         (resetWebViewToConsistentStateBeforeTesting):
567         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
568         (LayoutTestController::setPopupBlockingEnabled):
569
570 2008-01-10  Lars Knoll  <lars@trolltech.com>
571
572         Reviewed by Simon.
573
574         rename QWebPageHistory to QWebHistory.
575         
576
577         * DumpRenderTree/qt/jsobjects.cpp:
578
579 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
580
581         Reviewed by Darin.
582         
583         - add some more renames, adjust some
584
585         * Scripts/do-webcore-rename:
586
587 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
588
589         Reviewed by Oliver.
590
591         Enable SVG Fonts support by default.
592
593         * Scripts/build-webkit:
594
595 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
596
597         Reviewed by Adam.
598
599         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
600         DRT doesn't handle platform specific pixel test results correctly.
601
602         <test>-expected.txt files and <test>-expected.png files may now live
603         in different directories (ie. a cross-platform <test>-expected.txt file
604         and a platform-specific <test>-expected.png file).
605
606         * Scripts/run-webkit-tests:
607
608 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
609
610         Reviewed by Darin.
611
612         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
613         DRT did not correctly handle printing the '\0' char.  Now it does.
614
615         * DumpRenderTree/win/DumpRenderTree.cpp:
616         (dumpFramesAsText):
617         (dump):
618
619 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
620
621         Reviewed by Lars.
622
623         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
624         
625
626         * DumpRenderTree/qt/main.cpp:
627         * DumpRenderTree/qt/testplugin.cpp:
628         * DumpRenderTree/qt/testplugin.h:
629
630 2008-01-05  Mark Rowe  <mrowe@apple.com>
631
632         Reviewed by Alp Toker.
633
634         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
635
636         * DumpRenderTree/gtk/DumpRenderTree.cpp:
637         (processWork): Process pending work.
638         (webViewLoadFinished): Schedule processing of pending work.
639         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
640
641 2008-01-05  Darin Adler  <darin@apple.com>
642
643         * Scripts/do-webcore-rename: Some more renaming plans.
644
645 2008-01-04  Alice Liu  <alice.liu@apple.com>
646
647         Reviewed by Alexey and Darin.
648
649         Adding "home" and "end" to DRT's keydown since
650         DOM key events can't handle keyIdentifiers at this point. 
651
652         * DumpRenderTree/mac/EventSendingController.mm:
653         (-[EventSendingController keyDown:withModifiers:]):
654         * DumpRenderTree/win/EventSender.cpp:
655         (keyDownCallback):
656
657 2008-01-04  Lars Knoll  <lars@trolltech.com>
658
659         Reviewed by Simon.
660
661         fix DRT after the changes to QWebPage.
662         
663         The great thing is that we actually don't have
664         any regressions from the QWebPage change :)
665         
666
667         * DumpRenderTree/qt/DumpRenderTree.cpp:
668         (WebCore::DumpRenderTree::DumpRenderTree):
669
670 2008-01-04  Lars Knoll  <lars@trolltech.com>
671
672         Reviewed by Simon.
673
674         make QWebPage a QObject and get things to compile.
675         
676         Nothing works currently though.
677         
678
679         * DumpRenderTree/qt/DumpRenderTree.cpp:
680         (WebCore::DumpRenderTree::DumpRenderTree):
681
682 2008-01-04  Lars Knoll  <lars@trolltech.com>
683
684         Reviewed by Simon.
685
686         take a QString as identifier in QWebFrame::addToJSWindowObject.
687
688         * DumpRenderTree/qt/DumpRenderTree.cpp:
689         (WebCore::DumpRenderTree::initJSObjects):
690
691 2008-01-04  Alp Toker  <alp@atoker.com>
692
693         GTK+ DRT build fix for breakage introduced in r29149.
694
695         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
696         (LayoutTestController::execCommand):
697
698 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
699
700         Reviewed by Darin.
701
702         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
703
704         Added layoutTestController.execCommand to access editor commands that are not available
705         via document.execCommand.
706
707         * DumpRenderTree/LayoutTestController.cpp:
708         (execCommandCallback):
709         (LayoutTestController::staticFunctions):
710         * DumpRenderTree/LayoutTestController.h:
711         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
712         (LayoutTestController::execCommand):
713         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
714         (LayoutTestController::queueLoad):
715         (LayoutTestController::execCommand):
716
717 2008-01-03  Alice Liu  <alice.liu@apple.com>
718
719         Reviewed by Darin, Mitz.
720
721         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
722
723         the clickcount should not increase if the last click was at a different location.  it's a new click.
724
725         * DumpRenderTree/mac/DumpRenderTree.mm:
726         (runTest):
727         * DumpRenderTree/mac/EventSendingController.h:
728         * DumpRenderTree/mac/EventSendingController.mm:
729         (-[EventSendingController mouseDown]):
730         (-[EventSendingController mouseUp]):
731
732 2008-01-03  Darin Adler  <darin@apple.com>
733
734         Reviewed by Adam.
735
736         * Scripts/update-webkit: Make this work a little better for the people at Apple
737         who have a directory named Internal.
738
739 2008-01-03  Adam Roben  <aroben@apple.com>
740
741         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
742
743         Rubberstamped by Mark.
744
745         * Scripts/update-webkit-auxiliary-libs:
746
747 2008-01-03  Adam Roben  <aroben@apple.com>
748
749         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
750
751         http://bugs.webkit.org/show_bug.cgi?id=15663
752
753         Added a fuzz factor into the Last-Modified comparison for downloading
754         WebKitAuxiliaryLibrary.zip.
755
756         The zip file is served from a set of mirrors who give Last-Modified
757         times that are off by 1-3 seconds from each other. This was causing
758         the build bots to redownload WebKitAuxiliaryLibrary for every build,
759         which would then cause all of WebCore to rebuild each time.
760
761         Reviewed by Mark.
762
763         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
764         at least 30 seconds newer than the old one -- otherwise we assume that
765         the difference in time is due to the mirrors being slightly offset
766         from each other.
767         (sub lastModifiedToUnixTime): Added.
768
769 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
770
771         Windows build fix.
772
773         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
774
775 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
776
777         Reviewed by Lars.
778
779         Moved QWebPage::open to QWebFrame::load and added setHtml.
780         
781
782         * DumpRenderTree/qt/DumpRenderTree.cpp:
783         (WebCore::DumpRenderTree::open):
784
785 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
786
787         Reviewed by Lars.
788
789         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
790         
791
792         * DumpRenderTree/qt/DumpRenderTree.cpp:
793         (WebCore::DumpRenderTree::DumpRenderTree):
794
795 2008-01-02  Sam Weinig  <sam@webkit.org>
796
797         * Scripts/do-webcore-rename: Yet more renaming ideas.
798
799 2008-01-02  Darin Adler  <darin@apple.com>
800
801         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
802
803 2008-01-02  Alice Liu  <alice.liu@apple.com>
804
805         Reviewed by Sam Weinig.
806
807         fixing assertion hit with editing/selection/move-begin-end.html
808
809         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
810         * DumpRenderTree/win/DumpRenderTree.vcproj:
811         * DumpRenderTree/win/EventSender.cpp:
812         (keyDownCallback):
813         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
814
815 2008-01-02  Darin Adler  <darin@apple.com>
816
817         * Scripts/do-webcore-rename: Some more name change plans.
818
819 2008-01-02  Alice Liu  <alice.liu@apple.com>
820
821         Reviewed by Maciej.
822
823         Added handling for page up and page down in EventSender
824
825         * DumpRenderTree/mac/EventSendingController.mm:
826         (-[EventSendingController keyDown:withModifiers:]):
827         * DumpRenderTree/win/EventSender.cpp:
828         (keyDownCallback):
829
830 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
831
832         Reviewed by Darin.
833
834         Fix fast/events/arrow-keys-on-body.html for real.
835
836         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
837
838 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
839
840         Reviewed by Darin.
841
842         http://bugs.webkit.org/show_bug.cgi?id=16674
843         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
844
845         * Scripts/run-launcher:
846
847 2007-12-31  Darin Adler  <darin@apple.com>
848
849         Suggested by Antti.
850
851         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
852         we get it installed on the build bots.
853
854 2007-12-30  Eric Seidel  <eric@webkit.org>
855
856         Reviewed by Sam.
857
858         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
859
860 2007-12-29  Darin Adler  <darin@apple.com>
861
862         Reviewed by Oliver.
863
864         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
865           leak bot shows createCStringFromNPVariant result leaking
866
867         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
868         (pluginInvoke): Added a missing free.
869
870 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
871
872         Reviewed by Alp Toker.
873
874         http://bugs.webkit.org/show_bug.cgi?id=16390
875         Use autotools or GNU make as the build system for the GTK port
876
877         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
878         * GNUmakefile.am: Added.
879
880 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
881
882         Reviewed by Oliver.
883
884         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
885
886         * DumpRenderTree/win/EventSender.cpp:
887         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
888         of 1, even though WebKit currently ignores it.
889
890 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
891
892         wx buildbot fix. Update libpng dl script to the latest version.
893
894         * wx/install-unix-extras:
895
896 2007-12-22  Antti Koivisto  <antti@apple.com>
897
898         Fix a typo.
899
900         * Scripts/webkitdirs.pm:
901
902 2007-12-21  Sam Weinig  <sam@webkit.org>
903
904         Reviewed by Mark Rowe.
905
906         - Disable the back/forward cache using the new WebPreferences API
907           instead of through the BackForwardList.  This makes us match what
908           we do on Windows.
909
910         * DumpRenderTree/mac/DumpRenderTree.mm:
911         (createWebViewAndOffscreenWindow):
912         (setDefaultsToConsistentValuesForTesting):
913
914 2007-12-21  Dan Bernstein  <mitz@apple.com>
915
916         Reviewed by Mark Rowe.
917
918         - disable the back/forward cache in Windows DumpRenderTree. It is
919           already disabled in Mac DumpRenderTree.
920
921         * DumpRenderTree/win/DumpRenderTree.cpp:
922         (initializePreferences):
923
924 2007-12-13  Antti Koivisto  <antti@apple.com>
925
926         Reviewed by Darin and Steve.
927         
928         - check for QuickTime SDK on Windows.
929         - build media support on Windows by default
930
931         * Scripts/build-webkit:
932         * Scripts/webkitdirs.pm:
933
934 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
935
936         Build script fix for buildbot.
937
938         * wx/build-wxwebkit:
939
940 2007-12-20  Eric Seidel  <eric@webkit.org>
941
942         Reviewed by mjs.
943
944         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
945
946 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
947
948         Reviewed by Steve.
949
950         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
951         WebKit.
952
953         - Drosera and Safari need to use the same ProgIDs in order for
954         CoCreateInstance to work properly.  The most robust way to do this is
955         for WebKit to dynamically publish those ProgIDs.
956
957         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
958         (DebuggerClient::createWebViewWithRequest):
959         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
960         statics.
961         (Drosera::initUI):
962         (Drosera::attach):
963         (Drosera::attemptToCreateServerConnection):
964         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
965         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
966         make use of the published ProgIDs.
967         (ServerConnection::attemptToCreateServerConnection):
968
969 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
970
971         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
972         - Build bot and leak fix.
973
974         * DumpRenderTree/LayoutTestController.cpp:
975         (pathToLocalResourceCallback):
976
977 2007-12-19  David Kilzer  <ddkilzer@apple.com>
978
979         Make svn-apply/svn-unapply work with patches from git-format-patch.
980
981         Reviewed by Darin.
982
983         * Scripts/svn-apply:
984         (patch): If 'Index:' can't be found in the text passed in, print it
985         out with a warning and return early.
986         * Scripts/svn-unapply:
987         (patch): Ditto.
988
989 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
990
991         Reviewed by Alp Toker.
992
993         Build related fixes.
994
995         * wx/build-wxwebkit:
996         - Check to make sure the user is running a supported wx port
997         - More robust checks for Cygwin
998         - Only run install-unix-extras on Mac, it's not the right solution
999           for Linux distros.
1000         - Remove outdated Linux instructions after successful build
1001         - Clean Bakefile-generated files during a clean operation
1002
1003 2007-12-18  Darin Adler  <darin@apple.com>
1004
1005         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
1006
1007 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
1008
1009         Add script to run Drosera as part of the nightly.
1010         
1011         Reviewed by Kevin M.
1012
1013         * Scripts/run-drosera.cmd: Added.
1014
1015 2007-12-18  Darin Adler  <darin@apple.com>
1016
1017         * Scripts/do-webcore-rename: Remove a stray K.
1018
1019 2007-12-18  Darin Adler  <darin@apple.com>
1020
1021         * Scripts/do-webcore-rename: Plan more renaming.
1022
1023 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
1024
1025         Reviewed by Alp Toker.
1026
1027         http://bugs.webkit.org/show_bug.cgi?id=16042
1028         [GTK] Eliminate webkit_init()
1029
1030         Moving webkit initialization to WebView class init.
1031
1032         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1033         (main):
1034         * GtkLauncher/main.c:
1035         (main):
1036
1037 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
1038
1039         Reviewed by Alp Toker.
1040
1041         http://bugs.webkit.org/show_bug.cgi?id=13542
1042         gdklauncher doesnt change URL in adress GTKEntry.
1043
1044         * GtkLauncher/main.c:
1045         (load_commit_cb): added
1046         (title_change_cb):
1047         (create_browser):
1048
1049 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
1050
1051         Reviewed by Adam Roben.
1052
1053         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
1054
1055         * FindSafari/FindSafari.cpp:
1056         (_tmain):
1057
1058 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
1059
1060         Reviewed by Adam Roben.
1061
1062         http://bugs.webkit.org/show_bug.cgi?id=16315
1063         FindSafari needs a path-only option.
1064
1065         * FindSafari/FindSafari.cpp:
1066         (_tmain):
1067
1068 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
1069
1070         Reviewed by Darin.
1071
1072         http://bugs.webkit.org/show_bug.cgi?id=16462
1073         REGRESSION: access keys broken on Windows
1074
1075         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
1076         if Alt is pressed.
1077
1078 2007-12-15  Sam Weinig  <sam@webkit.org>
1079
1080         Reviewed by Mark Rowe.
1081
1082         Fix urlSuitableForTestResult to correctly identify wstring::npos as
1083         the case when wstring.find doesn't find anything.
1084
1085         * DumpRenderTree/win/DumpRenderTree.cpp:
1086         (urlSuitableForTestResult):
1087
1088 2007-12-15  Alp Toker  <alp@atoker.com>
1089
1090         GTK+ DRT build fix for GLib < 2.14.
1091
1092         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1093         (LayoutTestController::setWaitToDump):
1094
1095 2007-12-05  Mark Rowe  <mrowe@apple.com>
1096
1097         Reviewed by Alp Toker.
1098
1099         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
1100         many layout tests from hanging while waiting on user responses to dialogs.
1101
1102         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1103         (invalidateAnyPreviousWaitToDumpWatchdog):
1104         (webViewScriptAlert):
1105         (webViewScriptPrompt):
1106         (webViewScriptConfirm):
1107         (main):
1108         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1109         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1110         (waitToDumpWatchdogFired):
1111         (LayoutTestController::setWaitToDump):
1112
1113 2007-12-05  Mark Rowe  <mrowe@apple.com>
1114
1115         Reviewed by Alp Toker.
1116
1117         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
1118
1119         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1120         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
1121         (dump):
1122         (runTest):
1123         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
1124         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
1125         work queue is empty.
1126         (webViewWindowObjectCleared): Set up window.layoutTestController.
1127         (webViewConsoleMessage): Match the console message format expected by the layout test results.
1128         (main): Hook up the new signals.
1129         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1130         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
1131         dumping multiple times.
1132         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
1133         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
1134
1135 2007-12-14  Anders Carlsson  <andersca@apple.com>
1136
1137         Reviewed by Brady.
1138
1139         Assert that a web frame that's loading a resource always has either a data source or 
1140         a provisional data source.
1141         
1142         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1143         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1144
1145 2007-12-14  Darin Adler  <darin@apple.com>
1146
1147         - fix mistake causing nearly all tests to fail on Windows
1148
1149         * DumpRenderTree/win/UIDelegate.cpp:
1150         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
1151         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
1152
1153         * DumpRenderTree/mac/UIDelegate.mm:
1154         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
1155         than passing the entire message.
1156
1157 2007-12-14  Darin Adler  <darin@apple.com>
1158
1159         - fix Tiger build
1160
1161         * DumpRenderTree/mac/UIDelegate.mm:
1162         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
1163         new-to-Leopard methods.
1164
1165 2007-12-14  Darin Adler  <darin@apple.com>
1166
1167         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
1168         since it now triggers unwanted icon loading. We only had it because we implemented "all"
1169         delegate methods here.
1170
1171 2007-12-14  Anders Carlsson  <andersca@apple.com>
1172
1173         Reviewed by Darin and Geoff.
1174
1175         <rdar://problem/5619295> 
1176         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
1177         
1178         Add property getting methods to the plug-in.
1179         
1180         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1181         (pluginInvoke):
1182
1183 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
1184
1185         Reviewed by Darin.
1186
1187         - Layout test fix for mac. When dumped to the console local file paths
1188         now only show the name of the resource not the whole path.  This is to
1189         make the results machine and OS independent.
1190
1191         * DumpRenderTree/mac/UIDelegate.mm:
1192         (-[UIDelegate webView:addMessageToConsole:]):
1193
1194 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
1195
1196         Reviewed by Adam.
1197
1198         - Layout tests fix.  We need a way to remove machine-dependent
1199         information from paths in layout test results. The UIDelegate now does
1200         this.
1201
1202         * DumpRenderTree/DumpRenderTree.h:
1203         * DumpRenderTree/win/DumpRenderTree.cpp:
1204         (urlSuitableForTestResult):
1205         * DumpRenderTree/win/DumpRenderTreeWin.h:
1206         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1207         * DumpRenderTree/win/UIDelegate.cpp:
1208         (UIDelegate::webViewAddMessageToConsole):
1209
1210 2007-12-13  Alp Toker  <alp@atoker.com>
1211
1212         Build fix for DRT breakage introduced in r28690.
1213
1214         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1215         (LayoutTestController::pathToLocalResource):
1216
1217 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
1218
1219         Reviewed by Alice and Sam.
1220
1221         - <rdar://5621435> Need a way to specify local resources (being loaded
1222         from HTTP tests) on Windows.
1223         - Implemented pathToLocalResource which exposes the functionality of
1224         converting a given unix path to the correct location on Windows.
1225
1226         * DumpRenderTree/LayoutTestController.cpp:
1227         (pathToLocalResourceCallback):
1228         (LayoutTestController::staticFunctions):
1229         * DumpRenderTree/LayoutTestController.h:
1230         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1231         (LayoutTestController::pathToLocalResource):
1232         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1233         (LayoutTestController::pathToLocalResource):
1234
1235 2007-12-12  Anders Carlsson  <andersca@apple.com>
1236
1237         Reviewed by Sam.
1238
1239         <rdar://problem/5132003>
1240         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
1241
1242         * DumpRenderTree/win/DumpRenderTree.cpp:
1243         (main):
1244         Set the resource load delegate.
1245         
1246         * DumpRenderTree/win/DumpRenderTree.vcproj:
1247         
1248         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
1249         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
1250
1251 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
1252
1253         Reviewed by Adam Roben.
1254
1255         Fix conversion from double to LPARAM in dispatchMessage().
1256
1257         * DumpRenderTree/win/EventSender.cpp:
1258         (dispatchMessageCallback):
1259
1260 2007-12-11  Dan Bernstein  <mitz@apple.com>
1261
1262         Reviewed by Mark Rowe and Sam Weinig too!
1263
1264         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
1265           fonts DumpRenderTree registers.
1266
1267         * DumpRenderTree/win/DumpRenderTree.cpp:
1268         (initialize):
1269
1270 2007-12-11  Brady Eidson  <beidson@apple.com>
1271
1272         Reviewed by Anders
1273
1274         Make DumpRenderTree on mac use its own path for Databases testing
1275
1276         * DumpRenderTree/mac/DumpRenderTree.mm:
1277         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
1278           for future DRT-only use, then use it to construct the Databases path and set that default
1279
1280 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
1281
1282         Reviewed by Darin.
1283
1284         <rdar://problem/5535636>
1285         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1286
1287         http://bugs.webkit.org/show_bug.cgi?id=13916
1288         JavaScript detects Tab as a character input on a textfield validation
1289
1290         * DumpRenderTree/mac/EventSendingController.mm:
1291         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
1292         Dispatch a keyup to better match what happens when a key is physically pressed.
1293
1294         * DumpRenderTree/win/EventSender.cpp:
1295         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
1296         returning from keyDown().
1297         (getConstantCallback): Fixed a couple copy/paste mistakes.
1298
1299 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
1300
1301         Reviewed by Oliver.
1302
1303         - <rdar://5599845> Drosera: Does not show loal files in the file list
1304         on the left side.
1305
1306         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
1307         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
1308         so the open source community can build.
1309
1310 2007-12-10  Brady Eidson  <beidson@apple.com>
1311
1312         Rubberstamped by Sam Weinig
1313
1314         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
1315
1316         * DumpRenderTree/mac/UIDelegate.mm:
1317         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1318         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1319
1320 2007-12-08  Oliver Hunt  <oliver@apple.com>
1321
1322         Reviewed by Sam W.
1323
1324         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1325         
1326         Fixes <rdar://problem/5620249> Must disable SVG animation
1327         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1328         
1329         In order to allow finer grained control over the set of SVG features
1330         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
1331         distinct flags:
1332         ENABLE_SVG_ANIMATION
1333         ENABLE_SVG_FILTERS
1334         ENABLE_SVG_FONTS
1335         ENABLE_SVG_AS_IMAGE
1336         ENABLE_SVG_USE
1337         
1338         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
1339         
1340         Script handles all the new build flags, and allows --svg-experimental
1341         to automatically enable all features.
1342
1343         * Scripts/build-webkit:
1344
1345 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1346
1347         Fix version parsing.
1348
1349         Rubber-stamped by Oliver.
1350
1351         * Drosera/win/Drosera.vcproj/auto-version.sh:
1352
1353 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1354
1355         Build modifications for Drosera.
1356
1357         Reviewed by Adam.
1358
1359         * Drosera/DroseraWin.make: Added.
1360         * Drosera/win/Drosera.vcproj/Drosera.rc:
1361         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1362         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
1363         * Drosera/win/Drosera.vcproj/VERSION: Added.
1364         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
1365
1366 2007-12-06  Adam Roben  <aroben@apple.com>
1367
1368         Explicitly turn on the Mac font ascent hack on Windows
1369
1370         This keeps our font metrics matching those from Mac.
1371
1372         Reviewed by Hyatt.
1373
1374         * DumpRenderTree/win/DumpRenderTree.cpp:
1375         (main):
1376
1377 2007-12-06  Anders Carlsson  <andersca@apple.com>
1378
1379         Rename main.c to main.cpp here too.
1380         
1381         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
1382
1383 2007-12-06  Sam Weinig  <sam@webkit.org>
1384
1385         Rubber stamped by Geoff.
1386
1387         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
1388
1389 2007-12-06  Darin Adler  <darin@apple.com>
1390
1391         * Scripts/do-webcore-rename: Some more renaming plans.
1392
1393 2007-12-06  Anders Carlsson  <andersca@apple.com>
1394
1395         Restore implementation of testGetIntIdentifier that was accidentally
1396         removed somehow (possibly when I made PluginObject be a cpp file).
1397         
1398         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1399         (pluginInvoke):
1400
1401 2007-12-05  Anders Carlsson  <andersca@apple.com>
1402
1403         Make the entry points extern "C".
1404         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1405         
1406 2007-12-05  Anders Carlsson  <andersca@apple.com>
1407
1408         C++ warning fixes.
1409         
1410         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1411         (NPP_New):
1412         (NPP_Destroy):
1413         (NPP_SetWindow):
1414         (NPP_NewStream):
1415         (NPP_HandleEvent):
1416         (NPP_URLNotify):
1417         (NPP_GetValue):
1418
1419 2007-12-05  Anders Carlsson  <andersca@apple.com>
1420
1421         Add the .cpp files to the TestNetscapePlugIn target.
1422
1423         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1424
1425 2007-12-05  Anders Carlsson  <andersca@apple.com>
1426
1427         Reviewed by Geoff.
1428         
1429         Rename the TestNetscapePlugIn .c files to be .cpp.
1430
1431         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1432         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
1433         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
1434         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
1435         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
1436         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
1437         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
1438         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1439
1440 2007-12-05  Adam Roben  <aroben@apple.com>
1441
1442         Fix case of keypresses from the Windows implementation of eventSender.keyDown
1443
1444         This fixes several regression tests.
1445
1446         Reviewed by Alice.
1447
1448         * DumpRenderTree/win/EventSender.cpp:
1449         (keyDownCallback): Virtual keycodes for ASCII characters are always
1450         uppercase, so we need to check the case of the original character
1451         passed in to eventSender.keyDown.
1452
1453 2007-12-05  Adam Roben  <aroben@apple.com>
1454
1455         Learn from Tim's mistakes
1456
1457         * DumpRenderTree/win/DumpRenderTree.cpp:
1458         (runTest): Reset the authorAndUserStylesEnabled preference for each
1459         test.
1460
1461 2007-12-05  Alp Toker  <alp@atoker.com>
1462
1463         Reviewed by Mark Rowe.
1464
1465         Initialize GTK+ and WebKit so the tests can run.
1466
1467         Reorganize the headers a little.
1468
1469         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1470         (main):
1471
1472 2007-12-04  Anders Carlsson  <andersca@apple.com>
1473
1474         Remove IWebScriptScope include.
1475         
1476         * Drosera/win/DebuggerDocumentPlatform.cpp:
1477
1478 2007-12-04  Sam Weinig  <sam@webkit.org>
1479
1480         Rubber stamped by Mark Rowe.
1481
1482         Define CF as platform for mac and revert r28409
1483
1484         * DumpRenderTree/DumpRenderTree.h:
1485         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1486
1487 2007-12-04  Sam Weinig  <sam@webkit.org>
1488
1489         Define CF as platform for windows.
1490
1491         Reviewed by Adam Roben.
1492
1493         * DumpRenderTree/win/DumpRenderTreeWin.h:
1494
1495 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
1496
1497         Reviewed by Adam and Darin.
1498
1499         - Removed a needless BSTR cleanup.
1500
1501         * Drosera/win/DebuggerDocumentPlatform.cpp:
1502         (DebuggerDocument::getPlatformCurrentFunctionStack):
1503
1504 2007-11-27  Adam Roben  <aroben@apple.com>
1505
1506         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
1507
1508         Reviewed by Maciej.
1509
1510         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1511         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
1512
1513 2007-12-04  Alp Toker  <alp@atoker.com>
1514
1515         Prospective Win DRT build fix.
1516
1517         * DumpRenderTree/DumpRenderTree.h:
1518
1519 2007-12-04  Alp Toker  <alp@atoker.com>
1520
1521         Fix a clobbered copyright header.
1522
1523         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1524
1525 2007-12-04  Xan Lopez  <xan@gnome.org>
1526
1527         Reviewed by Alp Toker.
1528
1529         http://bugs.webkit.org/show_bug.cgi?id=15561
1530         GTK port needs DumpRenderTree implementation
1531
1532         Start work on the GTK+ DRT.
1533
1534         This does not work yet, and there are a few lingering style issues
1535         (nothing major) but this patch has been stuck in the bug tracker for
1536         too long already.
1537
1538         * DumpRenderTree/DumpRenderTree.h:
1539         * DumpRenderTree/gtk: Added.
1540         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
1541         (autocorrectURL):
1542         (shouldLogFrameLoadDelegates):
1543         (dumpFrameScrollPosition):
1544         (displayWebView):
1545         (appendString):
1546         (dumpFramesAsText):
1547         (dumpRenderTreeAsText):
1548         (dump):
1549         (runTest):
1550         (main):
1551         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
1552         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
1553         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
1554         (GCController::collect):
1555         (GCController::collectOnAlternateThread):
1556         (GCController::getJSObjectCount):
1557         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
1558         (LayoutTestController::~LayoutTestController):
1559         (LayoutTestController::addDisallowedURL):
1560         (LayoutTestController::clearBackForwardList):
1561         (LayoutTestController::copyDecodedHostName):
1562         (LayoutTestController::copyEncodedHostName):
1563         (LayoutTestController::display):
1564         (LayoutTestController::keepWebHistory):
1565         (LayoutTestController::notifyDone):
1566         (LayoutTestController::queueBackNavigation):
1567         (LayoutTestController::queueForwardNavigation):
1568         (LayoutTestController::queueLoad):
1569         (LayoutTestController::queueReload):
1570         (LayoutTestController::queueScript):
1571         (LayoutTestController::setAcceptsEditing):
1572         (LayoutTestController::setCustomPolicyDelegate):
1573         (LayoutTestController::setMainFrameIsFirstResponder):
1574         (LayoutTestController::setTabKeyCyclesThroughElements):
1575         (LayoutTestController::setUseDashboardCompatibilityMode):
1576         (LayoutTestController::setUserStyleSheetEnabled):
1577         (LayoutTestController::setUserStyleSheetLocation):
1578         (LayoutTestController::setWindowIsKey):
1579         (LayoutTestController::setWaitToDump):
1580         (LayoutTestController::windowCount):
1581         (LayoutTestController::setPrivateBrowsingEnabled):
1582         (LayoutTestController::setAuthorAndUserStylesEnabled):
1583         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
1584         (JSStringCopyUTF8CString):
1585         (LoadItem::invoke):
1586         (ReloadItem::invoke):
1587         (ScriptItem::invoke):
1588         (BackForwardItem::invoke):
1589
1590 2007-12-03  Sam Weinig  <sam@webkit.org>
1591
1592         Move JavaScriptCore thread testing code to pthread specific directory
1593         and remove the dependance on CoreFoundation by using WTF::HashSet.
1594
1595         Reviewed by Geoff and Oliver.
1596
1597         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1598         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
1599         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
1600         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
1601         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
1602         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
1603         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
1604         * DumpRenderTree/pthreads: Added.
1605         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
1606         (javaScriptThreads):
1607         (runJavaScriptThread):
1608         (startJavaScriptThreads):
1609         (stopJavaScriptThreads):
1610
1611 2007-12-03  Andrew Bonventre  <andybons@google.com>
1612
1613         Reviewed by Darin Adler.
1614
1615         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
1616         Symbol lookup menu broken in debugger view
1617
1618         * Drosera/debugger.js: Fixed javascript error where document property
1619         should have been used instead of contentDocument in switchFunction that
1620         was breaking the select symbol dropdown menu.  This is because
1621         window.frames will return a Window object and not a frame object like
1622         the author was originally expecting.
1623
1624 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
1625
1626         Reviewed by Adam.
1627
1628         - <rdar://5618942> Drosera: Console window does not process everything
1629         correctly.
1630         - <rdar://5619005> Drosera: could be sped up by moving the 
1631         WebScriptScope stuff into the WebScriptCallFrame.
1632         - Now the console can correctly process objects and does not receive
1633         notifications from JavaScriptCore about the JavaScript in Drosera's
1634         own process.
1635
1636         * Drosera/win/DebuggerDocumentPlatform.cpp:
1637         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1638         (DebuggerDocument::platformValueForScopeVariableNamed):
1639
1640 2007-12-03  Stephanie  <slewis@apple.com>
1641
1642         Reviewed by Darin.
1643
1644         Check to see if we are building a debug root
1645
1646         * Scripts/check-for-global-initializers: 
1647
1648 2007-12-03  Dan Bernstein  <mitz@apple.com>
1649
1650         Reviewed by Darin Adler.
1651
1652         - added a testGetIntIdentifier() method to TestNetscapePlugIn
1653
1654         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1655         (pluginInvoke):
1656
1657 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
1658
1659         Reviewed by Oliver.
1660
1661         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
1662         in a more fine-grained manner than eventSender.keyDown().
1663
1664         * DumpRenderTree/win/EventSender.cpp:
1665         (getConstantCallback):
1666         (dispatchMessageCallback):
1667
1668 2007-12-02  Darin Adler  <darin@apple.com>
1669
1670         * Scripts/do-webcore-rename: More planned renaming.
1671
1672 2007-12-02  Sam Weinig  <sam@webkit.org>
1673
1674         Rubber stamped by Anders.
1675
1676         Use [NSURL absoluteString] instead of [NSURL description] in order to get
1677         more uniform results cross platform.
1678
1679         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1680         (-[NSURL _drt_descriptionSuitableForTestResult]):
1681
1682 2007-12-02  Sam Weinig  <sam@webkit.org>
1683
1684         Rubber stamped by Niko.
1685
1686         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
1687
1688         * DumpRenderTree/win/DumpRenderTree.cpp:
1689         * DumpRenderTree/win/DumpRenderTree.vcproj:
1690         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
1691         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
1692         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
1693         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
1694
1695 2007-12-01  Alp Toker  <alp@atoker.com>
1696
1697         Reviewed by Adam Roben.
1698
1699         Make use of the newly introduced webkit.h convenience header.
1700
1701         * GtkLauncher/main.c:
1702
1703 2007-12-01  Adam Treat  <treat@kde.org>
1704
1705         Reviewed by Simon.
1706
1707         * Check to see if the directory exists and exit if not.
1708
1709         * DumpRenderTree/qt/main.cpp:
1710         (main):
1711
1712 2007-12-01  Adam Treat  <treat@kde.org>
1713
1714         Reviewed by Simon.
1715
1716         * Don't hide symbols when in Debug mode
1717         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
1718
1719
1720         * DumpRenderTree/qt/main.cpp:
1721         (messageHandler):
1722
1723 2007-11-30  Alp Toker  <alp@atoker.com>
1724
1725         Reviewed by Adam Roben.
1726
1727         http://bugs.webkit.org/show_bug.cgi?id=15691
1728         [GTK] Public API does not follow GTK+ conventions
1729
1730         Refactor the WebKit/GTK+ public API. Changes:
1731           WebKitPage -> WebKitWebView
1732           WebKitFrame -> WebKitWebFrame
1733
1734         Public API source and header names have been updated to mirror the API
1735         changes.
1736
1737         The API is now kept in WebKit/gtk/WebView to match other ports in the
1738         same class such as Mac and Win.
1739
1740         * GtkLauncher/main.c:
1741         (activate_uri_entry_cb):
1742         (link_hover_cb):
1743         (title_change_cb):
1744         (progress_change_cb):
1745         (go_back_cb):
1746         (go_forward_cb):
1747         (create_browser):
1748         (main):
1749
1750 2007-11-30  Adam Roben  <aroben@apple.com>
1751
1752         Hopefully the final build fix
1753
1754         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
1755         pull in WTF's assertion/logging functions.
1756
1757 2007-11-30  Adam Roben  <aroben@apple.com>
1758
1759         Another build fix
1760
1761         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
1762         WebKit.lib.
1763
1764 2007-11-30  Adam Roben  <aroben@apple.com>
1765
1766         Debug build fix
1767
1768         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
1769         configuration.
1770         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
1771         projects.
1772         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
1773         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
1774         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
1775
1776 2007-11-30  Sam Weinig  <sam@webkit.org>
1777
1778         Reviewed by Adam Roben.
1779
1780         Fix drawSelectionRect to actually draw the selection rect.
1781
1782         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1783         (drawSelectionRect):
1784
1785 2007-11-30  Darin Adler  <darin@apple.com>
1786
1787         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
1788
1789 2007-11-30  Darin Adler  <darin@apple.com>
1790
1791         * Scripts/do-webcore-rename: Get ready for some future renaming.
1792
1793 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1794
1795         Reviewed by Adam.
1796
1797         - Removed some unnecessary functions and changed an unused return type. 
1798
1799         * Drosera/win/DebuggerClient.cpp:
1800         (registerConsoleClass):
1801         * Drosera/win/DebuggerClient.h:
1802         * Drosera/win/Drosera.cpp:
1803         (registerDroseraClass):
1804
1805 2007-11-28  Alp Toker  <alp@atoker.com>
1806
1807         Reviewed by Timothy Hatcher.
1808
1809         http://bugs.webkit.org/show_bug.cgi?id=16174
1810         [GTK] Use "URI" not "URL" in public API
1811
1812         Replace use of the term "URL" with "URI" in public headers,
1813         documentation and some internal code to match GLib/GTK+ convention.
1814
1815         This is now mentioned in the API guidelines:
1816           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
1817
1818         * GtkLauncher/main.c:
1819         (activate_uri_entry_cb):
1820         (title_change_cb):
1821         (create_toolbar):
1822         (main):
1823
1824 2007-11-29  Anders Carlsson  <andersca@apple.com>
1825
1826         Reviewed by Sam.
1827
1828         <rdar://problem/5230478>
1829         FrameLoadDelegate callbacks are not dumped in DRT.
1830         
1831         * DumpRenderTree/win/DumpRenderTree.cpp:
1832         (shouldLogFrameLoadDelegates):
1833         (runTest):
1834         (main):
1835         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1836         (BSTRtoString):
1837         (descriptionSuitableForTestResult):
1838         (FrameLoadDelegate::QueryInterface):
1839         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1840         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1841         (FrameLoadDelegate::didCommitLoadForFrame):
1842         (FrameLoadDelegate::didFinishLoadForFrame):
1843         (FrameLoadDelegate::willCloseFrame):
1844         (FrameLoadDelegate::didClearWindowObject):
1845         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1846         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1847         * DumpRenderTree/win/FrameLoaderDelegate.h:
1848         (FrameLoadDelegate::windowScriptObjectAvailable):
1849         (FrameLoadDelegate::didFirstLayoutInFrame):
1850
1851 2007-11-29  Sam Weinig  <sam@webkit.org>
1852
1853         Reviewed by Anders.
1854
1855         Add database quota UIDelegates methods to DRT UIDelegate.
1856
1857         * DumpRenderTree/mac/UIDelegate.mm:
1858         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1859         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
1860
1861 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1862
1863         Reviewed by Sam.
1864
1865         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
1866         dying and vice versa.
1867         - This fix will allow Drosera and Safari to reconnect if either of them
1868         closes correctly, but does not fix the case where one of them dies
1869         silently.
1870
1871         * Drosera/win/ServerConnection.cpp:
1872         (ServerConnection::attemptToCreateServerConnection): Added a safety
1873         check, because it's possilbe to try to connect to a server that's dying.
1874         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
1875         the server has died.
1876         * Drosera/win/ServerConnection.h: Added the new function and removed
1877         an unnecessary member.
1878
1879 2007-11-29  Anders Carlsson  <andersca@apple.com>
1880
1881         * DumpRenderTree/win/DumpRenderTree.vcproj:
1882         Add shlwapi.lib to all configurations.
1883
1884 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1885
1886         - Build fix.  Added additional includes for VS Express to the Release
1887         project.
1888
1889         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1890
1891 2007-11-29  Anders Carlsson  <andersca@apple.com>
1892
1893         Reviewed by Adam.
1894
1895         <rdar://problem/5132005>
1896         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
1897         
1898         * DumpRenderTree/win/DumpRenderTree.vcproj:
1899         Add shlwapi.lib
1900         
1901         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1902         (LayoutTestController::setUserStyleSheetEnabled):
1903         Implement this.
1904         
1905         (appendComponentToPath):
1906         New method which wraps the Win32 API PathAppend.
1907         
1908         (followShortcuts):
1909         New method which checks if a file points to a shortcut and
1910         follows the shortcut.
1911         
1912         (resolveCygwinPath):
1913         New method that takes a cygwin unix-style path and returns the Win32 path.
1914         
1915         (cfStringRefToWString):
1916         
1917         (LayoutTestController::setUserStyleSheetLocation):
1918         Implement this.
1919
1920 2007-11-29  Alice Liu  <alice.liu@apple.com>
1921
1922         Reviewed by Adam.
1923
1924         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
1925
1926         * DumpRenderTree/win/EventSender.cpp:
1927         (keyDownCallback):
1928         uppercase letters were being sent as lowercase letters without the shift key down.
1929
1930 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1931
1932         - Windows build fix. VS express needs some love.
1933
1934         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1935
1936 2007-11-28  Darin Adler  <darin@apple.com>
1937
1938         Reviewed by Adam Roben.
1939
1940         * DumpRenderTree/mac/EventSendingController.mm:
1941         (-[EventSendingController keyDown:withModifiers:]):
1942         Send capital letters through as lowercase letters with the shift key down
1943         rather than sending them as if they were highly unusual "capital letter keys".
1944
1945         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1946         where you need to update results and more tests are failing than before.
1947
1948 2007-11-28  Anders Carlsson  <andersca@apple.com>
1949
1950         Reviewed by Darin.
1951
1952         <rdar://problem/5132001>
1953         contextClick is not implemented in DRT on Windows.
1954         
1955         * DumpRenderTree/win/EventSender.cpp:
1956         (contextClickCallback):
1957         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1958         by a WM_RBUTTONUP message.
1959         
1960         * DumpRenderTree/win/UIDelegate.cpp:
1961         (UIDelegate::hasCustomMenuImplementation):
1962         (UIDelegate::trackCustomPopupMenu):
1963         * DumpRenderTree/win/UIDelegate.h:
1964         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1965         menu from being shown (and causing the DRT to hang).
1966
1967 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1968
1969         Reviewed by Darin.
1970
1971         Fix DumpRenderTree ObjC bug comparing strings.
1972
1973         * DumpRenderTree/mac/ObjCController.m:
1974         (-[ObjCController identityIsEqual::]): Compare strings with string
1975         equality instead of identiy equality.
1976
1977 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1978
1979         Reviewed by Sam.
1980
1981         Reset the authorAndUserStylesEnabled preference
1982         back to YES for each test. Fixes the broken tests.
1983
1984         * DumpRenderTree/mac/DumpRenderTree.mm:
1985         (resetWebViewToConsistentStateBeforeTesting):
1986
1987 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1988
1989         Reviewed by Adam.
1990
1991         - Drosera now displays the console window, although it cannot currently
1992         process JavaScript.
1993
1994         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1995         (registerConsoleClass): Implemented.
1996         (consoleWndProc): Implemented.
1997         (DebuggerClient::onSize): Implemented.
1998         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1999         new window.
2000         * Drosera/win/DebuggerClient.h: Added needed method and members for 
2001         creating and maintaining a new window.
2002         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
2003         lines of code to more appropriate places.
2004         (Drosera::handleCommand):
2005         (Drosera::initUI):
2006         (Drosera::onSize):
2007         (Drosera::attach):
2008
2009 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2010
2011         Reviewed by Dave Hyatt.
2012
2013         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
2014         
2015         Add support for disabling author and user styles for testing.
2016
2017         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2018         * DumpRenderTree/LayoutTestController.cpp:
2019         (setAuthorAndUserStylesEnabledCallback):
2020         (LayoutTestController::staticFunctions):
2021         * DumpRenderTree/LayoutTestController.h:
2022         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2023         (LayoutTestController::setAuthorAndUserStylesEnabled):
2024         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2025         (LayoutTestController::setAuthorAndUserStylesEnabled):
2026
2027 2007-11-26  Dan Bernstein  <mitz@apple.com>
2028
2029         - Tiger build fix.
2030
2031         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2032
2033 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
2034
2035         Reviewed by Maciej.
2036
2037         - Implemented displaying variables for Drosera on Win.
2038
2039         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
2040         that retrieve variables to not hold onto the return value since it's
2041         not returned.  Also changed to use the new signatures of the retrieval
2042         functions.
2043         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2044         (DebuggerDocument::platformValueForScopeVariableNamed):
2045         * Drosera/win/Drosera.cpp: Removed a needless TODO.
2046         (droseraWndProc):
2047
2048 2007-11-26  Sam Weinig  <sam@webkit.org>
2049
2050         Cleanup names of painting and repainting functions.
2051
2052         Reviewed by Adam Roben.
2053
2054         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2055         (drawSelectionRect): was drawSelectionRectIntoContext.
2056         (dumpWebViewAsPixelsAndCompareWithExpected):
2057         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2058         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2059         (paintWebView): was drawWebViewIntoContext.
2060         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
2061
2062 2007-11-26  Sam Weinig  <sam@webkit.org>
2063
2064         Reviewed by Dan Bernstein.
2065
2066         - Leopard build fix
2067
2068         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2069
2070 2007-11-26  Sam Weinig  <sam@webkit.org>
2071
2072         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
2073         Use shared PixelDumpSupport for Mac DRT
2074
2075         Reviewed by Adam Roben.
2076
2077         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2078         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
2079         * DumpRenderTree/cg/ImageDiffCG.cpp:
2080         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2081         (drawSelectionRectIntoContext):
2082         (dumpWebViewAsPixelsAndCompareWithExpected):
2083         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2084         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2085         * DumpRenderTree/mac/DumpRenderTree.mm:
2086         (dump):
2087         * DumpRenderTree/mac/ImageDiff.m: Removed.
2088         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
2089         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
2090         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
2091         (setDefaultColorProfileToRGB):
2092         (getBitmapContextFromWebView):
2093         (drawWebViewIntoContext):
2094         (repaintWithVerticalSweep):
2095         (repaintWithHorizontalSweep):
2096         (getSelectionRect):
2097         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
2098
2099 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
2100
2101         Bug 16052: prepare-ChangeLog doesn't report deleted files
2102         <http://bugs.webkit.org/show_bug.cgi?id=16052>
2103
2104         Reviewed by Sam.
2105
2106         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
2107
2108 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
2109
2110         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
2111         <http://bugs.webkit.org/show_bug.cgi?id=15864>
2112
2113         Reviewed by Adam.
2114
2115         Roll functionality of merge-changelog into resolve-ChangeLogs
2116         script.  The script now checks for ChangeLog.rej and
2117         ChangeLog.orig files first.  If it finds them, it uses the
2118         ChangeLog.rej file as a patch (in old contextual diff format) to
2119         apply with --fuzz=3.
2120
2121         * Scripts/merge-changelog: Removed.
2122         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
2123
2124 2007-11-25  Sam Weinig  <sam@webkit.org>
2125
2126         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
2127
2128         Reviewed by Mark Rowe.
2129
2130         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2131         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2132         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2133         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
2134         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
2135
2136 2007-11-25  Sam Weinig  <sam@webkit.org>
2137
2138         Convert DumpRenderTree to ues .xcconfig files.
2139
2140         Reviewed by Mark Rowe.
2141
2142         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2143         * DumpRenderTree/mac/Configurations: Added.
2144         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
2145         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
2146         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
2147
2148 2007-11-25  Sam Weinig  <sam@webkit.org>
2149
2150         Add ForwardingHeaders to wtf for DumpRenderTree.
2151
2152         Reviewed by Mark Rowe.
2153
2154         * DumpRenderTree/DumpRenderTree.h:
2155         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2156         * DumpRenderTree/ForwardingHeaders: Added.
2157         * DumpRenderTree/ForwardingHeaders/wtf: Added.
2158         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
2159         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
2160         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
2161         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
2162         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
2163         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
2164         * DumpRenderTree/LayoutTestController.cpp:
2165         * DumpRenderTree/WorkQueue.cpp:
2166         * DumpRenderTree/mac/DumpRenderTree.mm:
2167         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2168         * DumpRenderTree/mac/JavaScriptThreading.cpp:
2169         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2170         * DumpRenderTree/mac/ObjCController.m:
2171         * DumpRenderTree/mac/UIDelegate.mm:
2172         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2173
2174 2007-11-25  Adam Roben  <aroben@apple.com>
2175
2176         Fix some test failures caused by r28019
2177
2178         Now that stdout is in binary mode, we need to always use printf
2179         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
2180         the output.
2181
2182         Reviewed by Sam.
2183
2184         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
2185         printf.
2186         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2187         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2188         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2189         (UIDelegate::webViewAddMessageToConsole):
2190
2191 2007-11-25  Adam Roben  <aroben@apple.com>
2192
2193         Set the font smoothing preference in DRT
2194
2195         This makes the pixel results on Windows closer to the Mac results.
2196
2197         Reviewed by Mitz.
2198
2199         * DumpRenderTree/win/DumpRenderTree.cpp:
2200         (initializePreferences):
2201
2202 2007-11-25  Adam Roben  <aroben@apple.com>
2203
2204         Port ImageDiff to CG and C++
2205
2206         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
2207         <rdar://5071708>
2208
2209         Reviewed by Sam.
2210
2211         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
2212         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
2213         (main):
2214         (createImageFromStdin):
2215         (compareImages):
2216         (getDifferenceBitmap):
2217         (computePercentageDifferent):
2218         * DumpRenderTree/win/ImageDiff.vcproj: Added.
2219
2220 2007-11-25  Adam Roben  <aroben@apple.com>
2221
2222         Fix image diff link generation on Windows
2223
2224         Reviewed by Sam.
2225
2226         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
2227         to toURL.
2228
2229 2007-11-25  Adam Roben  <aroben@apple.com>
2230
2231         Implement pixel dumping in Windows DRT
2232
2233         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
2234         <rdar://5071708>
2235
2236         Reviewed by Sam.
2237
2238         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
2239         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
2240         Content-Length header.
2241         (getMD5HashStringForBitmap):
2242         (dumpWebViewAsPixelsAndCompareWithExpected):
2243         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
2244         * DumpRenderTree/win/DumpRenderTree.cpp:
2245         (dump): Do a pixel dump if requested.
2246         (main): Parse pixel test options.
2247         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
2248         the cg/ subdirectory to the include path.
2249         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
2250         available in a header or import library, so we have to go through this
2251         LoadLibrary/GetProcAddress dance to use them.
2252         (cryptDLL):
2253         (init):
2254         (update):
2255         (final):
2256         (MD5_Init):
2257         (MD5_Update):
2258         (MD5_Final):
2259         * DumpRenderTree/win/MD5.h: Added.
2260         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
2261         moved up to the top level to share it with Mac eventually.
2262         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
2263         (getBitmapContextFromWebView): Forces the WebView to paint using a
2264         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
2265
2266 2007-11-25  Adam Roben  <aroben@apple.com>
2267
2268         Clean up Windows DRT's option parsing a little bit
2269
2270         Reviewed by Sam.
2271
2272         * DumpRenderTree/win/DumpRenderTree.cpp:
2273         (main): Put non-option arguments into a Vector.
2274
2275 2007-11-25  Adam Roben  <aroben@apple.com>
2276
2277         Make Windows DRT stop changing LF into CRLF
2278
2279         Reviewed by Sam.
2280
2281         * DumpRenderTree/win/DumpRenderTree.cpp:
2282         (main): Put stdout in binary mode.
2283         * Scripts/run-webkit-tests: Remove the CRLF hack.
2284
2285 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
2286
2287         Removed empty directory.
2288
2289         * Scripts/resources: Removed.
2290
2291 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
2292
2293         Fix bisect-builds to work with recent WebKit nightly builds.
2294
2295         Reviewed by Dan.
2296
2297         * Scripts/bisect-builds: Check for the 
2298         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
2299         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
2300         to WebKit.app/Contents/Resources.
2301
2302 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
2303
2304         Reviewed by Maciej.
2305
2306         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
2307         not closed (affects digg.com)
2308
2309         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
2310         one after finishing with a test to avoid having its delayed onload handler firing when
2311         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
2312         but it helps somewhat.
2313
2314 2007-11-22  Mark Rowe  <mrowe@apple.com>
2315
2316         Reviewed by Alp Toker.
2317
2318         Fix build-webkit to propagate make's exit status if it fails.
2319
2320         * Scripts/webkitdirs.pm:
2321
2322 2007-11-22  Dan Bernstein  <mitz@apple.com>
2323
2324         Reviewed by Mark Rowe.
2325
2326         - fix crash when running pixel tests
2327
2328         * DumpRenderTree/mac/DumpRenderTree.mm:
2329         (dumpRenderTree): Parse the command line options before setting up the
2330         environment so that we know if we need to set up the pixel dump
2331         machinery.
2332
2333 2007-11-21  Eric Seidel  <eric@webkit.org>
2334
2335         Speculative build fix for Tiger.
2336
2337         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
2338
2339 2007-11-21  Eric Seidel  <eric@webkit.org>
2340
2341         Reviewed by Tim Hatcher.
2342
2343         Break out more of DumpRenderTree.mm into individual files
2344
2345         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2346         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
2347         (checkedMalloc):
2348         (checkedRealloc):
2349         (makeLargeMallocFailSilently):
2350         * DumpRenderTree/mac/CheckedMalloc.h: Added.
2351         * DumpRenderTree/mac/DumpRenderTree.mm:
2352         (crashHandler):
2353         (dump):
2354         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2355         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2356         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2357         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2358         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2359         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
2360         (javaScriptThreads):
2361         (runJavaScriptThread):
2362         (startJavaScriptThreads):
2363         (stopJavaScriptThreads):
2364         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
2365         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
2366         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
2367         (restoreColorSpace):
2368         (setDefaultColorProfileToRGB):
2369         (initializeColorSpaceAndScreeBufferForPixelTests):
2370         (md5HashStringForBitmap):
2371         (dumpWebViewAsPixelsAndCompareWithExpected):
2372
2373 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
2374
2375         Move install-unix-extras to wx directory as it seems only to be used by that 
2376         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
2377         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
2378         have install-unix-extras install into WebKitLibraries as per
2379         convention.
2380         
2381         Reviewed by Mark Rowe.
2382
2383         * Scripts/install-unix-extras: Removed.
2384         * wx/build-wxwebkit:
2385         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
2386
2387 2007-11-21  Eric Seidel  <eric@webkit.org>
2388
2389         Reviewed by Adam.
2390
2391         More refactoring for greater code readability
2392
2393         * DumpRenderTree/mac/DumpRenderTree.mm:
2394         (initializeGlobalsFromCommandLineOptions):
2395         (initializeColorSpaceAndScreeBufferForPixelTests):
2396         (addTestPluginsToPluginSearchPath):
2397         (useLongRunningServerMode):
2398         (runTestingServerLoop):
2399         (prepareConsistentTestingEnvironment):
2400         (dumpRenderTree):
2401         (main):
2402         (dumpFramesAsText):
2403         (dumpBackForwardListForWebView):
2404         (sizeWebViewForCurrentTest):
2405         (methodNameStringForFailedTest):
2406         (dumpBackForwardListForAllWindows):
2407         (dumpWebViewAsPixelsAndCompareWithExpected):
2408         (invalidateAnyPreviousWaitToDumpWatchdog):
2409         (dump):
2410         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2411         * DumpRenderTree/mac/UIDelegate.mm:
2412         (-[UIDelegate webView:createWebViewWithRequest:]):
2413
2414 2007-11-21  Eric Seidel  <eric@webkit.org>
2415
2416         Reviewed by Tim Hatcher.
2417
2418         Abstract more of DRT into static methods
2419
2420         * DumpRenderTree/mac/DumpRenderTree.mm:
2421         (setDefaultsToConsistentValuesForTesting):
2422         (setupSignalHandlers):
2423         (allocateGlobalControllers):
2424         (releaseAndZero):
2425         (releaseGlobalControllers):
2426         (dumpRenderTree):
2427         (shouldLogFrameLoadDelegates):
2428         (createCFURLFromPathOrURL):
2429         (resetWebViewToConsistentStateBeforeTesting):
2430         (runTest):
2431
2432 2007-11-21  Eric Seidel  <eric@webkit.org>
2433
2434         Reviewed by Tim Hatcher.
2435
2436         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
2437
2438         * DumpRenderTree/DumpRenderTree.h:
2439         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2440         * DumpRenderTree/mac/DumpRenderTree.mm:
2441         (dumpRenderTree):
2442         (dump):
2443         (runTest):
2444         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
2445         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
2446         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
2447         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
2448         (-[DumpRenderTreePasteboard declareType:owner:]):
2449         (+[LocalPasteboard alloc]):
2450         (-[LocalPasteboard init]):
2451         (-[LocalPasteboard dealloc]):
2452         (-[LocalPasteboard name]):
2453         (-[LocalPasteboard releaseGlobally]):
2454         (-[LocalPasteboard declareTypes:owner:]):
2455         (-[LocalPasteboard addTypes:owner:]):
2456         (-[LocalPasteboard changeCount]):
2457         (-[LocalPasteboard types]):
2458         (-[LocalPasteboard availableTypeFromArray:]):
2459         (-[LocalPasteboard setData:forType:]):
2460         (-[LocalPasteboard dataForType:]):
2461         (-[LocalPasteboard setPropertyList:forType:]):
2462         (-[LocalPasteboard setString:forType:]):
2463         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
2464         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
2465         (+[DumpRenderTreeWindow allWindows]):
2466         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2467         (-[DumpRenderTreeWindow dealloc]):
2468         (-[DumpRenderTreeWindow isKeyWindow]):
2469         (-[DumpRenderTreeWindow keyDown:]):
2470
2471 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
2472
2473         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
2474         it indiscriminately copies any headers inside JavaScriptCore,
2475         which includes Tiger ICU headers. 
2476
2477         * wx/build-wxwebkit:
2478         Don't run WebCore/move-js-headers.sh any longer.
2479
2480 2007-11-20  Adam Treat  <treat@kde.org>
2481
2482         Reviewed by David Kilzer.
2483
2484         * Prepend git branch name to $baseProductDir
2485
2486         * Scripts/VCSUtils.pm:
2487         * Scripts/webkitdirs.pm:
2488
2489 2007-11-20  Mark Rowe  <mrowe@apple.com>
2490
2491         Reviewed by Simon Hausmann.
2492
2493         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
2494         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
2495         Have it trigger a "make distclean" rather than "make clean" to ensure that the
2496         built product and generated Makefile's are removed.
2497
2498 2007-11-19  Alp Toker  <alp@atoker.com>
2499
2500         Reviewed by Mark Rowe.
2501
2502         http://bugs.webkit.org/show_bug.cgi?id=16040
2503         [GTK] GtkLauncher should be written in C
2504
2505         Port GtkLauncher to plain C.
2506
2507         Use a more conventional GTK+ coding style.
2508
2509         Use a toolbar instead of menus.
2510
2511         Various signature fixes and cleanups.
2512
2513         Add a license header. Assume all previous modifications were copyright
2514         assigned to Apple Inc. by default.
2515
2516         * GtkLauncher/GtkLauncher.pro:
2517         * GtkLauncher/main.c: Added.
2518         (activate_url_entry_cb):
2519         (update_title):
2520         (link_hover_cb):
2521         (title_change_cb):
2522         (progress_change_cb):
2523         (destroy_cb):
2524         (go_back_cb):
2525         (go_forward_cb):
2526         (create_browser):
2527         (create_statusbar):
2528         (create_toolbar):
2529         (create_window):
2530         (main):
2531         * GtkLauncher/main.cpp: Removed.
2532
2533 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
2534
2535         Build script fixes to ensure they do the right thing for the 
2536         wx port, and update build-wxwebkit to reflect the way the
2537         build scripts now work.
2538
2539         Reviewed by Adam.
2540
2541         * Scripts/build-testkjs:
2542         * Scripts/build-webkit:
2543         * Scripts/run-javascriptcore-tests:
2544         * Scripts/webkitdirs.pm:
2545         * wx/build-wxwebkit:
2546
2547 2007-11-18  Eric Seidel  <eric@webkit.org>
2548
2549         Reviewed by Anders.
2550
2551         Make run-javascriptcore-tests report failures on exit (to support git bisect)
2552
2553         * Scripts/run-javascriptcore-tests:
2554
2555 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
2556
2557         Reviewed by Adam Roben.
2558
2559         Make run-webkit-tests work with Windows debug build.
2560
2561         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
2562         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
2563         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
2564         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
2565         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
2566
2567 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
2568
2569         Add wxWebKit sample and build script, and integrate it with 
2570         build-webkit. Also make build-webkit --clean work for all
2571         ports.
2572
2573         Reviewed by Darin Adler.
2574
2575         * Scripts/build-webkit:
2576         * Scripts/webkitdirs.pm:
2577         * wx: Added.
2578         * wx/browser: Added.
2579         * wx/browser/browser.bkl: Added.
2580         * wx/browser/browser.cpp: Added.
2581         * wx/build-wxwebkit: Added.
2582
2583 2007-11-17  Adam Roben  <aroben@apple.com>
2584
2585         Make it easy to run Safari in the debugger on Windows
2586
2587         I've added a new script, debug-safari, which launches Safari in the
2588         debugger. On OS X it just calls gdb-safari.
2589
2590         Reviewed by Mark Rowe.
2591
2592         * FindSafari/FindSafari.cpp:
2593         (_tmain): Added a /debugger flag, which in combination with
2594         /printSafariLauncher will print a script that launches Safari in the
2595         debugger.
2596         * Scripts/debug-safari: Added.
2597         * Scripts/run-safari: Changed to call runSafari().
2598         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
2599         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
2600         first argument along to FindSafari.
2601         * Scripts/webkitdirs.pm:
2602         (sub runSafari): Added.
2603
2604 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
2605
2606         Reviewed by Adam Roben.
2607
2608         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
2609
2610 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
2611
2612         Reviewed by David Kilzer.
2613
2614         The git config command was renamed to repo-config at some point. This
2615         change tries git config and then git repo-config if the first fails.
2616
2617         * Scripts/prepare-ChangeLog:
2618         (gitConfig):
2619
2620 2007-11-16  Dan Bernstein  <mitz@apple.com>
2621
2622         Reviewed by Darin Adler and Sam Weinig.
2623
2624         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
2625
2626         * DumpRenderTree/win/EventSender.cpp:
2627         (keyDownCallback): For characters that cannot be entered on the active
2628         keyboard layout, send a WM_CHAR message with the character along with
2629         a WM_KEYDOWN message with a virtual key code of 255.
2630
2631 2007-11-16  Mark Rowe  <mrowe@apple.com>
2632
2633         Reviewed by Tim Hatcher.
2634
2635         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
2636
2637         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2638         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2639
2640 2007-11-15  Adam Roben  <aroben@apple.com>
2641
2642         Make run-safari actually work on Windows
2643
2644         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
2645         chdir call.
2646
2647 2007-11-14  Adam Roben  <aroben@apple.com>
2648
2649         Updates to Safari launching now that 3.0.4 is released
2650
2651         Reviewed by Sam.
2652
2653         * FindSafari/FindSafari.cpp:
2654         (getWebViewCLSID): Use version-independent ProgID.
2655         * Scripts/run-safari: Use run-webkit-nightly.cmd.
2656
2657 2007-11-14  Anders Carlsson  <andersca@apple.com>
2658
2659         Reviewed by Adam.
2660
2661         <rdar://problem/5309081>
2662         In DRT, "plugin.logDestroy = true" not working on Windows.
2663         
2664         * DumpRenderTree/win/TestNetscapePlugin/main.c:
2665         (NPP_Destroy):
2666
2667 2007-11-14  Eric Seidel  <eric@webkit.org>
2668
2669         Reviewed by Sam.
2670
2671         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
2672
2673 2007-11-14  Anders Carlsson  <andersca@apple.com>
2674
2675         Reviewed by Adam.
2676
2677         <rdar://problem/5141186>
2678         window.layoutTestController.setWindowIsKey is not implemented in DRT.
2679         
2680         Implement setWindowIsKey.
2681         
2682         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2683         (LayoutTestController::setWindowIsKey):
2684
2685 2007-11-13  Sam Weinig  <sam@webkit.org>
2686
2687         Reviewed by Adam Roben.
2688
2689         Fix for <rdar://problem/5382579>
2690         http/tests/security/cross-frame-access-put.html reports large 
2691         negative numbers for screenLeft and screenTop (Mac reports "0")
2692
2693         * DumpRenderTree/win/UIDelegate.cpp:
2694         (UIDelegate::UIDelegate): Initialize the RECT.
2695         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
2696         (UIDelegate::webViewFrame): ditto.
2697         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
2698
2699 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
2700
2701         Reviewed by Adam.
2702
2703         - Make Drosera show source, source URLs, and function stack on Windows,
2704         and some minor fixes.
2705
2706         * Drosera/DebuggerDocument.cpp: Force source to always update display.
2707         (DebuggerDocument::updateFileSource):
2708         * Drosera/debugger.js: Force source to always update display.
2709         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
2710         menu controls.
2711         (DebuggerClient::resume):
2712         (DebuggerClient::pause):
2713         (DebuggerClient::stepInto):
2714         (DebuggerClient::stepOver):
2715         (DebuggerClient::stepOut):
2716         (DebuggerClient::showConsole):
2717         (DebuggerClient::closeCurrentFile):
2718         * Drosera/win/DebuggerClient.h: Ditto.
2719         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
2720         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
2721         removed two bugs.  1) caller could be in a bad state when asked to
2722         assign into it. 2) BSTRs were not created correctly.
2723         (DebuggerDocument::getPlatformCurrentFunctionStack):
2724         * Drosera/win/Drosera.cpp: Hook up the menu controls.
2725         (droseraWndProc):
2726         (handleCommand):
2727         (Drosera::resume):
2728         (Drosera::pause):
2729         (Drosera::stepInto):
2730         (Drosera::stepOver):
2731         (Drosera::stepOut):
2732         (Drosera::showConsole):
2733         (Drosera::closeCurrentFile):
2734         * Drosera/win/Drosera.h: Hook up the menu controls.
2735         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
2736         functions, added a null check, and fixed another bug where caller could
2737         be in a bad state when asked to assign into it.
2738         (ServerConnection::didLoadMainResourceForDataSource):
2739         (ServerConnection::getCallerFrame):
2740         * Drosera/win/ServerConnection.h: Safety first.
2741
2742 2007-11-13  Dan Bernstein  <mitz@apple.com>
2743
2744         Reviewed by Darin Adler.
2745
2746         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
2747           DumpRenderTree --pixel-tests renders each test twice
2748
2749         * DumpRenderTree/mac/DumpRenderTree.mm:
2750         (dumpRenderTree): Removed the --paint option because the painting code
2751         is always exercised as a result of
2752         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
2753         calling -displayIfNeeded.
2754         (dump): Changed to always grab the image from the window since the view
2755         is always displayed.
2756         (runTest):
2757         (displayWebView):
2758         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
2759         because it always paints.
2760
2761 2007-11-12  Antti Koivisto  <antti@apple.com>
2762
2763         Reviewed by Adele.
2764         
2765         Add support for http media tests
2766
2767         * Scripts/run-webkit-tests:
2768
2769 2007-11-12  Sam Weinig  <sam@webkit.org>
2770
2771         Reviewed by Adam Roben.
2772
2773         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
2774
2775         * DumpRenderTree/win/DumpRenderTree.cpp:
2776         (runTest):
2777         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2778         (LayoutTestController::setPrivateBrowsingEnabled):
2779
2780 2007-11-12  Adam Roben  <aroben@apple.com>
2781
2782         * Scripts/update-webkit-localizable-strings: Changed to only scan the
2783         mac and win subdirectories.
2784
2785 2007-11-11  Adam Roben  <aroben@apple.com>
2786
2787         Fix <rdar://5133816> keepWebHistory is not implemented
2788
2789         Fixes fast/history/clicked-link-is-visited.html.
2790
2791         Reviewed by Darin.
2792
2793         * DumpRenderTree/win/DumpRenderTree.cpp:
2794         (runTest): Clear the optionalSharedHistory.
2795         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2796         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
2797
2798 2007-11-10  Sam Weinig  <sam@webkit.org>
2799
2800         Reviewed by Tim Hatcher.
2801
2802         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
2803         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
2804         is turned on)
2805
2806         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
2807
2808         Added test: http/tests/security/cross-frame-access-private-browsing.html
2809
2810         * DumpRenderTree/LayoutTestController.cpp:
2811         (setPrivateBrowsingEnabledCallback):
2812         (LayoutTestController::staticFunctions):
2813         * DumpRenderTree/LayoutTestController.h:
2814         * DumpRenderTree/mac/DumpRenderTree.mm:
2815         (runTest): Default to private browsing disabled.
2816         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2817         (LayoutTestController::setPrivateBrowsingEnabled):
2818         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2819         (LayoutTestController::setPrivateBrowsingEnabled):
2820
2821 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2822
2823         Reviewed by Adam.
2824
2825         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
2826         WebCore's!
2827
2828         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2829         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
2830         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2831         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2832         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
2833         * Drosera/win/Drosera.cpp:
2834         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2835
2836 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2837
2838         Reviewed by Sam.
2839
2840         - Use the new IWebFrame [local] function signature and get the shared
2841         server correctly.
2842
2843         * Drosera/win/DebuggerClient.cpp:
2844         (DebuggerClient::didFinishLoadForFrame):
2845         * Drosera/win/ServerConnection.cpp:
2846         (ServerConnection::attemptToCreateServerConnection):
2847
2848 2007-11-07  Dan Bernstein  <mitz@apple.com>
2849
2850         Reviewed by Darin Adler.
2851
2852         - add an option to run-webkit-tests to ignore pixel test failures where
2853           all pixels differ by no more than a specified threshold
2854
2855         * DumpRenderTree/mac/ImageDiff.m:
2856         (main):
2857         (compareImages):
2858         (computePercentageDifferent):
2859         * Scripts/run-webkit-tests:
2860
2861 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2862
2863         Reviewed by Lars.
2864
2865         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
2866
2867         * DumpRenderTree/qt/DumpRenderTree.cpp:
2868
2869 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2870
2871         Reviewed by Lars.
2872
2873         Reworked the QWebSettings API.
2874         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
2875
2876         * DumpRenderTree/qt/DumpRenderTree.cpp:
2877
2878 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2879
2880         Reviewed by Lars.
2881
2882         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
2883
2884         * DumpRenderTree/qt/jsobjects.cpp:
2885
2886 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2887
2888         Reviewed by Lars Knoll <lars@trolltech.com>.
2889
2890         Add a QWebPage::frameCreated() signal and fix DRT
2891         
2892         The removal of createFrame in QWebPage broke the re-implementation
2893         in DumpRenderTree. Instead emit a frameCreated() signal and
2894         connect to it in DumpRenderTree.
2895         
2896
2897         * DumpRenderTree/qt/DumpRenderTree.cpp:
2898         (WebCore::WebPage::WebPage):
2899         (WebCore::DumpRenderTree::dump):
2900         (WebCore::DumpRenderTree::connectFrame):
2901         * DumpRenderTree/qt/DumpRenderTree.h:
2902
2903 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2904
2905         Reviewed by Lars Knoll <lars@trolltech.com>.
2906
2907         Moved all the event handlers from QWebFrame into QWebPage.
2908         
2909         This cleans up the public API and allows us to remove the
2910         HackWebFrame hack in DumpRenderTree.
2911         
2912
2913         * DumpRenderTree/qt/jsobjects.cpp:
2914         (EventSender::mouseDown):
2915         (EventSender::mouseUp):
2916         (EventSender::mouseMoveTo):
2917
2918 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2919
2920         Reviewed by Mark.
2921
2922         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
2923         to prevent the default implementation from popping up messageboxes.
2924
2925         * DumpRenderTree/qt/DumpRenderTree.cpp:
2926         (WebCore::WebPage::javaScriptConfirm):
2927         (WebCore::WebPage::javaScriptPrompt):
2928
2929 2007-11-06  Eric Seidel  <eric@webkit.org>
2930
2931         * Scripts/build-testkjs: build fix... too many $$
2932
2933 2007-11-06  Eric Seidel  <eric@webkit.org>
2934
2935         Reviewed by Mark Rowe.
2936
2937         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
2938
2939 2007-11-05  Adam Roben  <aroben@apple.com>
2940
2941         Add support on Windows for WEBKIT_TESTFONTS
2942
2943         This environment variable lets you specify where the fonts to be used
2944         by DumpRenderTree reside. The Qt port is already using this, so I'm
2945         just following their lead.
2946
2947         Reviewed by Darin.
2948
2949         * DumpRenderTree/win/DumpRenderTree.cpp:
2950         (exePath): Refactored code out of initialize().
2951         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2952         DumpRenderTree.resources.
2953         (initialize): Use the new fontsPath function.
2954         (main): Use the new exePath function.
2955         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2956         variable to DRT, like Qt does.
2957
2958 2007-11-05  Mark Rowe  <mrowe@apple.com>
2959
2960         Rubber-stamped by Alp Toker.
2961
2962         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2963
2964         * GtkLauncher/main.cpp:
2965         (goToURLBarText):
2966         (main):
2967
2968 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2969
2970         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2971         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2972
2973         Reviewed by Timothy.
2974
2975         Restrict the range of nightly builds used by the bisect-builds script
2976         based on the version of Safari and the version of Mac OS X being used.
2977
2978         Mac OS X 10.4: Safari 2.0: r11976 or newer
2979         Mac OS X 10.4: Safari 3.0: r19992 or newer
2980
2981         Mac OS X 10.5: Safari 2.0: r19594 or newer
2982         Mac OS X 10.5: Safari 3.0: r25124 or newer
2983
2984         * Scripts/bisect-builds:
2985         (findMacOSXVersion): Added.
2986         (makeNightlyList): Added argument to provide version of Mac OS X.
2987         Restrict range of nightly builds based on Safari and Mac OS X versions.
2988
2989 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2990
2991         Reviewed by Maciej.
2992
2993         - This patch involves several changes, all of them were noticed that
2994         they were needed by the work being done in WebKit to get Drosera and
2995         WebKit working together on Windows.
2996         - The changes are:
2997         1) Added a debugger console for output messages.
2998         2) Drosera now listens for the WebKit server (before, the server would
2999         have to be running before Drosera was started.)
3000         3) Fixed a bug where the WebView started out as 0x0 pixels.
3001         4) Fixed a bug when there is no scope.
3002         5) Added the HTML, JS, and CSS to the project file to make them easy to
3003         find.
3004         6) Made the ServerConnection functions virtual.
3005
3006         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
3007         for the WebKit server.
3008         (DebuggerClient::DebuggerClient):
3009         (DebuggerClient::~DebuggerClient):
3010         (DebuggerClient::didFinishLoadForFrame):
3011         (DebuggerClient::serverConnected):
3012         (DebuggerClient::attemptToCreateServerConnection):
3013         * Drosera/win/DebuggerClient.h: Ditto.
3014         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
3015         scope.
3016         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3017         (DebuggerDocument::platformValueForScopeVariableNamed):
3018         * Drosera/win/Drosera.cpp:
3019         (_tWinMain): Added a console in debug for output messages.
3020         (Drosera::Drosera): Listen for server.
3021         (Drosera::initUI): The server now Initializes COM.
3022         (Drosera::serverConnected): Part of the listening for the server.
3023         (Drosera::attemptToCreateServerConnection): Ditto.
3024         * Drosera/win/Drosera.h: New interface for listening for the server.
3025         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
3026         files to the VS project.
3027         * Drosera/win/ServerConnection.cpp: Part of listening for the server
3028         connection.
3029         (ServerConnection::ServerConnection):
3030         (ServerConnection::attemptToCreateServerConnection):
3031         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
3032         methods.
3033         (ServerConnection::serverConnected):
3034
3035 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
3036
3037         Reviewed by Maciej.
3038
3039         http://bugs.webkit.org/show_bug.cgi?id=15832
3040         fast/dom/gc-10.html crashes when run alone
3041
3042         Check for !done before using objects that can be already deallocated.
3043
3044         * DumpRenderTree/mac/EditingDelegate.mm:
3045         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3046         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3047         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3048         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3049         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3050         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3051         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3052         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3053         (-[EditingDelegate webViewDidBeginEditing:]):
3054         (-[EditingDelegate webViewDidChange:]):
3055         (-[EditingDelegate webViewDidEndEditing:]):
3056         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3057         (-[EditingDelegate webViewDidChangeSelection:]):
3058         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3059         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3060         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3061         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3062         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3063         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3064         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3065         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3066         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3067         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
3068         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3069         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
3070         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3071         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3072         (-[FrameLoadDelegate webView:willCloseFrame:]):
3073         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3074         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3075         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3076         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3077         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3078         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3079         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3080         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3081         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3082
3083 2007-11-04  Mark Rowe  <mrowe@apple.com>
3084
3085         Build fix.  Don't use Carbon.h as the prefix header as it triggers
3086         warnings that would otherwise be suppressed due to it being a system header.
3087
3088         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3089
3090 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
3091
3092         Rubber stamped by Adam.
3093         
3094         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
3095
3096         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3097
3098 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3099
3100         Sort files(...); sections of Xcode project files.
3101
3102         Rubber-stamped by Darin.
3103
3104         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
3105         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3106         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3107         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3108
3109 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3110
3111         Script to sort "files(...);" sections in Xcode project.pbxproj files.
3112
3113         Reviewed by Darin.
3114
3115         * Scripts/sort-Xcode-project-file: Added.
3116
3117 2007-11-02  Darin Adler  <darin@apple.com>
3118
3119         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
3120
3121 2007-11-02  Darin Adler  <darin@apple.com>
3122
3123         Reviewed by Maciej.
3124
3125         * Scripts/run-sunspider: Pass the "--base" option through.
3126
3127         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
3128         the real script do that. Default configuration to Release to match run-sunspider
3129         so we don't end up building Debug just to compare results.
3130
3131 2007-11-01  Adam Roben  <aroben@apple.com>
3132
3133         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
3134
3135         Reviewed by Sam.
3136
3137         * Scripts/commit-log-editor: Show all the directories beneath the
3138         source root, instead of just the last one.
3139
3140 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
3141
3142         Reviewed by Adam Roben.
3143
3144         Print out an error message when the Windows build fails
3145         and provide guidance on how to find out what went wrong.
3146
3147         * Scripts/build-webkit:
3148         * Scripts/webkitdirs.pm:
3149
3150 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
3151
3152         Rubber-stamped by Adam Roben.
3153
3154         Rolled out r27326 - debug CRT seems to cause no problems after all.
3155
3156         * DumpRenderTree/win/DumpRenderTree.vcproj:
3157
3158 2007-10-31  Adam Roben  <aroben@apple.com>
3159
3160         Switch the Debug configuration to using the non-debug CRT
3161
3162         This matches WebKit.
3163
3164         Reviewed by Steve.
3165
3166         * DumpRenderTree/win/DumpRenderTree.vcproj:
3167
3168 2007-10-31  Antti Koivisto  <antti@apple.com>
3169
3170         Reviewed by bdash.
3171         
3172         Disable media tests when doing leak checking on Tiger.
3173         They crash in QuickTime (rdar://problem/5537157).
3174
3175         * Scripts/run-webkit-tests:
3176
3177 2007-10-29  Antti Koivisto  <antti@apple.com>
3178
3179         Reviewed by Maciej.
3180         
3181         Build media support by default on OSX only.
3182
3183         * Scripts/build-webkit:
3184
3185 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3186
3187         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
3188         get caught by the pre-commit hooks.
3189
3190 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3191
3192         Reviewed by Adam.
3193
3194         - This is a collection of relatively unrelated changes and cleanups
3195         to Drosera to prepare it for interacting with WebKit.  A lot of these
3196         changes are just correcting mistakes, for example removing included
3197         headers that are no longer needed.
3198
3199         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
3200         this will be needed by the DebuggerClient.
3201         (DebuggerDocument::server):
3202         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
3203         * Drosera/win/DebuggerClient.cpp: 
3204         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
3205         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
3206         (DebuggerClient::createWebViewWithRequest): Added comment about its
3207         purpose. 
3208         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
3209         declarations.
3210         (DebuggerClient::webViewLoaded): Moved.
3211         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
3212         file, since this was the only place it was used.
3213         (cfStringToBSTR):
3214         * Drosera/win/Drosera.h: Cleaned up the includes.
3215         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
3216         * Drosera/win/HelperFunctions.h: Removed.
3217
3218 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3219
3220         Reviewed by Adam.
3221
3222         - Small cleanup in the ServerConnection class.
3223
3224         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
3225         and added an include.
3226         (ServerConnection::currentFrame):
3227         (ServerConnection::getCallerFrame):
3228         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
3229         made a pointer into a COMPtr, and cleaned up the includes.
3230
3231 2007-10-29  Timothy Hatcher  <timothy@apple.com>
3232
3233         Reviewed by John Sullivan.
3234         
3235         - Place the Localizable.strings file in mac or win directories
3236           if that location exists.
3237         - Also look for UI_STRING in .c files.
3238
3239         * Scripts/extract-localizable-strings:
3240
3241 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3242
3243         Reviewed by Adam.
3244
3245         - Set the eol-style to native and made all the line endings the same
3246         so that I avoid messy diffs that show eol changes.
3247
3248         * Drosera/win/ServerConnection.cpp:
3249         (ServerConnection::didParseSource):
3250         (ServerConnection::didEnterCallFrame):
3251         (ServerConnection::willExecuteStatement):
3252         (ServerConnection::willLeaveCallFrame):
3253         (ServerConnection::exceptionWasRaised):
3254
3255 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3256
3257         Reviewed by Adam.
3258
3259         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
3260         functionality that could not have existed previously without the new
3261         interfaces.
3262         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
3263         from a BSTR to a JSValueRef.
3264         (DebuggerDocument::platformEvaluateScript): Implemented.
3265         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
3266         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3267         Implemented.
3268         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
3269         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
3270         * Drosera/win/ServerConnection.cpp: Added a helper function.
3271         (ServerConnection::getCallerFrame):
3272         * Drosera/win/ServerConnection.h: Added a helper function.
3273
3274 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3275
3276         updated reviewers for my previous changelog.
3277
3278 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3279         Reviewed by Maciej and Adam and Geoff.
3280
3281         - Minor mac-side improvements including moving a function to a more
3282         appropriate location, fixing a warning, and correctly checking
3283         exceptions.
3284
3285         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
3286         (DebuggerDocument::willExecuteStatement):
3287         (DebuggerDocument::didEnterCallFrame):
3288         (DebuggerDocument::willLeaveCallFrame):
3289         (DebuggerDocument::windowScriptObjectAvailable):
3290         (DebuggerDocument::callFunctionOnObject):
3291         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
3292         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
3293         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
3294         because it doesn't require the ServerConnection at all.
3295         (NSStringCreateWithJSStringRef): Made an argument const.
3296         (JSValueRefCreateWithNSString): Made an argument const.
3297         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
3298         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3299         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
3300         * Drosera/mac/ServerConnection.mm: Ditto.
3301         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3302
3303 2007-10-29  Sam Weinig  <sam@webkit.org>
3304
3305         Reviewed by Adam Roben.
3306
3307         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
3308
3309         * DumpRenderTree/LayoutTestController.cpp:
3310         (LayoutTestController::LayoutTestController):
3311         (getGlobalFlagCallback):
3312         (setGlobalFlagCallback):
3313         (LayoutTestController::getJSClass):
3314         (LayoutTestController::staticValues):
3315         * DumpRenderTree/LayoutTestController.h:
3316         (LayoutTestController::globalFlag):
3317         (LayoutTestController::setGlobalFlag):
3318
3319 2007-10-29  Darin Adler  <darin@apple.com>
3320
3321         Reviewed by Maciej.
3322
3323         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
3324         resolution instead of its default.
3325
3326 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
3327
3328         Fixed showStatus() to print status for successfully resolved conflicts when using git.
3329
3330         Reviewed by Mark Rowe.
3331
3332         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
3333         was successfully resolved, but this would not show any status because the change had
3334         already been cached in the index using "git add".  The solution is to add an optional
3335         second argument to showStatus() which adds the "--cached" switch to the command.
3336
3337         * Scripts/resolve-ChangeLogs:
3338         (showStatus):
3339
3340 2007-10-28  Eric Seidel  <eric@webkit.org>
3341
3342         Reviewed by Maciej and Geoff, in unison.
3343
3344         * Scripts/run-webkit-tests: remove broken --svg option
3345
3346 2007-10-28  Darin Adler  <darin@apple.com>
3347
3348         Reviewed by Adam.
3349
3350         * Scripts/run-sunspider: Default to "Release" configuration rather than
3351         defaulting to the last configuration used as other scripts do. This can
3352         still be overriden on the command line with "--debug" if there's some
3353         reason to do so. Also fix a typo.
3354
3355         * Scripts/sunspider-compare-results: Fix a typo.
3356
3357 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
3358
3359         Reviewed by Adam.
3360
3361         - Implemented the WebScriptDebugListener functions now that the
3362         WebScriptDebugServer exists
3363
3364         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
3365         functions.
3366         (ServerConnection::currentFrame):
3367         (ServerConnection::didLoadMainResourceForDataSource):
3368         (ServerConnection::didParseSource):
3369         (ServerConnection::failedToParseSource):
3370         (ServerConnection::didEnterCallFrame):
3371         (ServerConnection::willExecuteStatement):
3372         (ServerConnection::willLeaveCallFrame):
3373         (ServerConnection::exceptionWasRaised):
3374         * Drosera/win/ServerConnection.h: Removed unused arguments from the
3375         members arguments list.
3376
3377 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
3378
3379         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
3380         <http://bugs.webkit.org/show_bug.cgi?id=15600>
3381
3382         Reviewed by Darin.
3383
3384         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
3385         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
3386         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
3387         file.  Note that it may also be used as a stand-alone script.
3388
3389         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
3390         * Scripts/resolve-ChangeLogs: Added.
3391         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
3392
3393 2007-10-26  Mark Rowe  <mrowe@apple.com>
3394
3395         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
3396         to the Qt port on the assumption that it was an implementation of the cross-platform
3397         LayoutTestController class.  It is not, so it did not need to be changed.
3398
3399         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
3400
3401 2007-10-25  Mark Rowe  <mrowe@apple.com>
3402
3403         Reviewed by Maciej.
3404
3405         Fix builds with code coverage enabled.
3406
3407         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
3408
3409 2007-10-25  Darin Adler  <darin@apple.com>
3410
3411         Reviewed by Mark Rowe.
3412
3413         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
3414         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
3415
3416 2007-10-25  Stephanie  <slewis@apple.com>
3417
3418         build Fix
3419
3420         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3421
3422 2007-10-25  Stephanie  <slewis@apple.com>
3423
3424         Reviewed by Mark Rowe, Adam Roben.
3425
3426         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
3427
3428         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
3429
3430 2007-10-25  Alice Liu  <alice.liu@apple.com>
3431
3432         Reviewed by Adam.
3433
3434         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
3435
3436         Moving destructor into platform-specific files
3437         * DumpRenderTree/LayoutTestController.cpp:
3438         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3439         (LayoutTestController::~LayoutTestController):
3440         * DumpRenderTree/qt/jsobjects.cpp:
3441         (LayoutTestController::~LayoutTestController):
3442
3443         LayoutTestController wasn't being destroyed
3444         * DumpRenderTree/win/DumpRenderTree.cpp:
3445         (runTest):
3446
3447         Added declspec
3448         * DumpRenderTree/win/EditingDelegate.h:
3449
3450         Reset certain values on the webview (or related delegate) that might 
3451         have changed while running a test
3452         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3453         (LayoutTestController::~LayoutTestController):
3454
3455 2007-10-25  Adam Roben  <aroben@apple.com>
3456
3457         Make sunspider-compare-results work with relative paths
3458
3459         Reviewed by Sam.
3460
3461         * Scripts/sunspider-compare-results: Convert arguments to absolute
3462         paths before we chdir.
3463
3464 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
3465
3466         Reviewed by Sam.
3467
3468         - Implemented server calls now the WebScriptDebugServer exists.
3469         - Also removed no longer needed call to initialize CG.
3470
3471         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
3472         automatically now.
3473         (_tWinMain):
3474         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
3475         (ServerConnection::ServerConnection):
3476         (ServerConnection::~ServerConnection):
3477         (ServerConnection::pause):
3478         (ServerConnection::resume):
3479         (ServerConnection::stepInto):
3480         (ServerConnection::applicationTerminating):
3481         (ServerConnection::serverConnectionDidDie):
3482         * Drosera/win/ServerConnection.h: Now uses the COM class.
3483
3484 2007-10-24  George Staikos  <staikos@kde.org>
3485
3486         Unbreak Qt build.
3487
3488         * Scripts/build-webkit:
3489
3490 2007-10-24  Adam Roben  <aroben@apple.com>
3491
3492         Remove now-unnecessary call to InitializeCoreGraphics
3493
3494         WebKit takes care of this now.
3495
3496         Reviewed by Ada.
3497
3498         * DumpRenderTree/win/DumpRenderTree.cpp:
3499         (initialize):
3500
3501 2007-10-24  Adam Roben  <aroben@apple.com>
3502
3503         Use WebTextRenderer in DRT
3504
3505         Reviewed by Ada.
3506
3507         * DumpRenderTree/win/DumpRenderTree.cpp:
3508         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
3509
3510 2007-10-24  Sven Herzberg  <sven@imendio.com>
3511
3512         Reviewed by Mark Rowe.
3513
3514         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
3515         Bug 15614: [GTK] qmake based backends don't build on OS X
3516
3517         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
3518         GTK backend on a Mac
3519         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
3520         isDarwin() to make it reusable in other places (like the workaround-
3521         for-prebuilt-qmake in build-webkit)
3522
3523 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3524
3525         Refurbish update-webkit script.
3526
3527         Reviewed by Adam.
3528
3529         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
3530         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
3531         multi-argument version of system() for flexibility and security.  Check for existence
3532         of Internal directory using -d test instead of -x.
3533
3534 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3535
3536         Minor clean-up of prepare-ChangeLog script.
3537
3538         Reviewed by Adam.
3539
3540         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
3541         of a string.  Use multi-argument versions of open() and system() for flexibility and
3542         security.
3543
3544 2007-10-24  Alice Liu  <alice.liu@apple.com>
3545
3546         Reviewed by Oliver.
3547
3548         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
3549
3550         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
3551         replay the saved events when we're still processing the mousedown that starts the drag
3552         * DumpRenderTree/win/EventSender.cpp:
3553         (doMouseMove):
3554         * DumpRenderTree/win/UIDelegate.cpp:
3555         (UIDelegate::doDragDrop):
3556
3557 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
3558
3559         Reviewed by Sam, Steve and Darin.
3560
3561         - Stubbed out the WebScriptDebugListener functionality in the Server
3562         Connection class to prepare it for receiving those callbacks.
3563         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
3564         and the ServerConnection to not need to be initialized with a server
3565         name, since that is not the way we connect to the WebKit server. 
3566
3567         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
3568         no exception.  Now it only loggs when there is an exception
3569         (DebuggerDocument::willExecuteStatement):
3570         (DebuggerDocument::didEnterCallFrame):
3571         (DebuggerDocument::willLeaveCallFrame):
3572         (DebuggerDocument::windowScriptObjectAvailable):
3573         (DebuggerDocument::callFunctionOnObject):
3574         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
3575         to be instantiated with a server's name.
3576         (DebuggerClient::DebuggerClient):
3577         (DebuggerClient::didFinishLoadForFrame):
3578         * Drosera/win/DebuggerClient.h: Removed unsued variable.
3579         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
3580         a server name.
3581         (Drosera::init):
3582         (Drosera::initServer):
3583         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
3584         instantiated with a server's name.
3585         * Drosera/win/ServerConnection.cpp: 
3586         (ServerConnection::ServerConnection): No longer needs a server name
3587         (ServerConnection::~ServerConnection): Only release the global context
3588         if there is one.
3589         (ServerConnection::serverConnectionDidDie): Stub for
3590         IWebScriptDebugListener
3591         (ServerConnection::QueryInterface): ditto
3592         (ServerConnection::AddRef): ditto
3593         (ServerConnection::Release): ditto
3594         (ServerConnection::didLoadMainResourceForDataSource): ditto
3595         (ServerConnection::didParseSource): ditto
3596         (ServerConnection::failedToParseSource): ditto
3597         (ServerConnection::didEnterCallFrame): ditto
3598         (ServerConnection::willExecuteStatement): ditto
3599         (ServerConnection::willLeaveCallFrame): ditto
3600         (ServerConnection::exceptionWasRaised): ditto
3601         * Drosera/win/ServerConnection.h: Stubbed out the
3602         IWebScriptDebugListener functions, and this class no longer needs to be
3603         instantiated with a server name.
3604
3605 2007-10-24  Lars Knoll  <lars@trolltech.com>
3606
3607         Reviewed by Simon.
3608
3609         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
3610
3611         * DumpRenderTree/qt/jsobjects.h:
3612
3613 2007-10-24  Lars Knoll  <lars@trolltech.com>
3614
3615         Reviewed by Simon.
3616
3617         add another command.
3618
3619         * DumpRenderTree/qt/jsobjects.cpp:
3620         (TextInputController::doCommand):
3621
3622 2007-10-24  Lars Knoll  <lars@trolltech.com>
3623
3624         Reviewed by Simon.
3625
3626         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
3627
3628         * DumpRenderTree/qt/jsobjects.cpp:
3629         (EventSender::keyDown):
3630         * DumpRenderTree/qt/jsobjects.h:
3631
3632 2007-10-24  Lars Knoll  <lars@trolltech.com>
3633
3634         Reviewed by Simon.
3635
3636         implement eventSender.keyDown().
3637
3638         * DumpRenderTree/qt/jsobjects.cpp:
3639         (EventSender::keyDown):
3640
3641 2007-10-24  Lars Knoll  <lars@trolltech.com>
3642
3643         Reviewed by Simon.
3644
3645         some smaller fixes to the editing support in DRT. Makes another few tests pass.
3646
3647         * DumpRenderTree/qt/DumpRenderTree.cpp:
3648         (WebCore::DumpRenderTree::DumpRenderTree):
3649         (WebCore::DumpRenderTree::initJSObjects):
3650         * DumpRenderTree/qt/jsobjects.cpp:
3651         (TextInputController::doCommand):
3652
3653 2007-10-24  Lars Knoll  <lars@trolltech.com>
3654
3655         Reviewed by Simon.
3656
3657         first bit of implementation for the textinputcontroller.
3658
3659         * DumpRenderTree/qt/DumpRenderTree.cpp:
3660         (WebCore::DumpRenderTree::DumpRenderTree):
3661         * Dum