2009-11-25 Eric Seidel <eric@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-25  Eric Seidel  <eric@webkit.org>
2
3         Reviewed by Adam Barth.
4
5         'bugzilla-tool help' should only show common commands like how 'git help' does
6         https://bugs.webkit.org/show_bug.cgi?id=31772
7
8         I also took this opportunity to make 'help' a real Command.
9         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
10
11         * Scripts/bugzilla-tool:
12          - change should_show_command_help to should_show_in_main_help
13         * Scripts/modules/commands/download.py:
14          - Mark commands as being shown in main help or not.
15          - show_in_main_help = False is not required (default is false),
16            but it seemed to make the commands more self-documenting.
17         * Scripts/modules/commands/queries.py: ditto
18         * Scripts/modules/commands/queues.py: ditto
19         * Scripts/modules/commands/upload.py: ditto
20         * Scripts/modules/multicommandtool.py:
21          - Make Command hold a pointer to tool in self.tool.  Most Command
22            subclasses do not take advantage of this yet, but it was required
23            for HelpCommand to be able to reach the tool from _help_epilog().
24          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
25          - Move MultiCommandTool._help_epilog to Command._help_epilog
26          - Move "help" logic into HelpCommand.execute()
27          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
28         * Scripts/modules/multicommandtool_unittest.py:
29          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
30
31 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
32
33         Reviewed by Dan Bernstein.
34         
35         Patch by Mark Rowe.
36
37         The buildbots are failing on Windows because when they were upgraded
38         to 4.0.4, Apple Application Support was not in their path. Add it to
39         the path to fix the buildots.
40
41         * Scripts/webkitdirs.pm:
42
43 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
44
45         Reviewed by David Kilzer.
46
47         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
48         https://bugs.webkit.org/show_bug.cgi?id=31799
49
50         * Scripts/run-webkit-tests: Fixed.
51
52 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
53
54         Reviewed by Eric Seidel.
55
56         Change run_command to give back stderr by default
57         https://bugs.webkit.org/show_bug.cgi?id=31734
58
59         Change run_command to give back stderr by default.
60         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
61         Change the related unittest call.
62
63         * Scripts/modules/scm.py:
64         * Scripts/modules/scm_unittest.py:
65
66 2009-11-25  Eric Seidel  <eric@webkit.org>
67
68         Reviewed by Adam Barth.
69
70         Centralize required argument parsing in Command
71         https://bugs.webkit.org/show_bug.cgi?id=31872
72
73         * Scripts/modules/commands/download.py: remove custom required arg message.
74         * Scripts/modules/commands/upload.py: ditto.
75         * Scripts/modules/multicommandtool.py:
76          - Add _parse_required_arguments.
77          - Pass program name off to OptionParser.
78          - Add name() for access to tool name.
79          - Add check_arguments_and_execute and make it return a return code.
80          - Replace a couple uses of + with %.
81         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
82
83 2009-11-25  Eric Seidel  <eric@webkit.org>
84
85         Reviewed by Adam Barth.
86
87         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
88         https://bugs.webkit.org/show_bug.cgi?id=31870
89
90         * Scripts/modules/commands/queries_unittest.py: Use the new class.
91         * Scripts/modules/multicommandtool_unittest.py: Ditto.
92         * Scripts/modules/outputcapture.py: Added.
93
94 2009-11-24  Dmitry Titov  <dimich@chromium.org>
95
96         Reviewed by Eric Seidel.
97
98         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
99         https://bugs.webkit.org/show_bug.cgi?id=31444
100
101         * Scripts/build-webkit:
102
103 2009-11-24  Chris Marrin  <cmarrin@apple.com>
104
105         Reviewed by Simon Fraser.
106
107         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
108         https://bugs.webkit.org/show_bug.cgi?id=27314
109         
110         Now the script allows the directories with these tests to be included on all
111         platforms but Mac, where they behave the same as always. For all other platforms
112         the tests need to be excluded using the Skipped files, which is currently done
113         for all platforms (including win since we're not turned on yet)
114
115         * Scripts/webkitdirs.pm:
116
117 2009-11-24  Eric Seidel  <eric@webkit.org>
118
119         Reviewed by Adam Barth.
120
121         queries_unittest.py should test command output
122         https://bugs.webkit.org/show_bug.cgi?id=31845
123
124         * Scripts/modules/commands/queries_unittest.py:
125          - Capture stdout and stderr and compare with expected strings.
126
127 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
128
129         No Review.
130
131         Fix spelling error ("depenedencies").
132
133         * Scripts/build-webkit:
134
135 2009-11-24  Mark Rowe  <mrowe@apple.com>
136
137         Land the configuration that includes the two debug GTK Linux builders.
138
139         * BuildSlaveSupport/build.webkit.org-config/config.json:
140
141 2009-11-24  David Kilzer  <ddkilzer@apple.com>
142
143         <http://webkit.org/b/31840> bisect-builds broke after r50080
144
145         Reviewed by Dan Bernstein.
146
147         * Scripts/bisect-builds:
148         (mountAndRunNightly): Switched back to using backticks to run
149         the hdiutil command since exec() will terminate the existing
150         script, which is not what we want.  Store the output of
151         File::Spec->devnull() in a variable for use in the hdiutil
152         detach commands.
153
154 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
155
156         Reviewed by Kenneth Rohde Christiansen.
157
158         Include "config.h" to meet Coding Style Guidelines
159         https://bugs.webkit.org/show_bug.cgi?id=31792
160
161         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
162         * DumpRenderTree/qt/jsobjects.cpp:
163         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
164
165 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
166
167         Reviewed by Oliver Hunt.
168
169         Implement new required function to pass test we used to pass. This
170         change is required since r51294.
171
172         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
173         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
174
175 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
176
177         Reviewed by Kenneth Rohde Christiansen.
178
179         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
180         https://bugs.webkit.org/show_bug.cgi?id=31775
181
182         LayoutTestController::dumpBackForwardList() should work with local URLs
183         as well as with normal URLs (in http tests for instance).
184         Currently it does not output the latter properly.
185
186         Unskip a bunch of passing http/navigation tests.
187
188         * DumpRenderTree/qt/DumpRenderTree.cpp:
189         (WebCore::dumpHistoryItem):
190
191 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
192
193         Reviewed by Oliver Hunt.
194
195         ARIA: support aria-flowto
196         https://bugs.webkit.org/show_bug.cgi?id=31762
197
198         * DumpRenderTree/AccessibilityUIElement.cpp:
199         (ariaFlowToElementAtIndexCallback):
200         (AccessibilityUIElement::getJSClass):
201         * DumpRenderTree/AccessibilityUIElement.h:
202         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
203         (AccessibilityUIElement::ariaFlowToElementAtIndex):
204         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
205         (AccessibilityUIElement::ariaFlowToElementAtIndex):
206         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
207         (AccessibilityUIElement::ariaFlowToElementAtIndex):
208
209 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
210
211         Reviewed by Kenneth Christiansen.
212
213         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
214         https://bugs.webkit.org/show_bug.cgi?id=31638
215
216         Unfreeze WorkQueue after each test execution.
217
218         * DumpRenderTree/qt/DumpRenderTree.cpp:
219         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
220
221 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
222
223         Reviewed by Adam Barth.
224
225         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
226         for localhost and 127.0.0.1.
227         https://bugs.webkit.org/show_bug.cgi?id=31783
228
229         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
230
231         * DumpRenderTree/qt/DumpRenderTree.cpp:
232         (WebCore::NetworkAccessManager::NetworkAccessManager):
233         (WebCore::NetworkAccessManager::sslErrorsEncountered):
234         (WebCore::WebPage::WebPage):
235         * DumpRenderTree/qt/DumpRenderTree.h:
236
237 2009-11-22  Chris Evans  <cevans@chromium.org>
238
239         Reviewed by Adam Barth.
240
241         Disable access to file:/// directory listings
242         https://bugs.webkit.org/show_bug.cgi?id=31329
243
244         Implemented setAllowUniversalAccessFromFileURLs to support testing of
245         file URL security.
246
247         * DumpRenderTree/LayoutTestController.cpp:
248         (setAllowUniversalAccessFromFileURLsCallback):
249         (LayoutTestController::staticFunctions):
250         * DumpRenderTree/LayoutTestController.h:
251         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
252         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
253         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
254         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
255         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
256         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
257         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
258         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
259
260 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
261
262         Reviewed by Kenneth Rohde Christiansen.
263
264         [Qt] Fix the timeout of fast/frames/frame-navigation.html
265         https://bugs.webkit.org/show_bug.cgi?id=31638
266
267         The test is timeouting, because it uses the WorkQueue to load a document in one
268         of the child frames and once the loading is finished, the DRT does not dump the
269         tree. This is because it waits for the QWebFrame::loadFinished() signal from
270         the main frame, while it should connect to QWebPage::loadFinished().
271
272         * DumpRenderTree/qt/DumpRenderTree.cpp:
273         (WebCore::DumpRenderTree::DumpRenderTree):
274
275 2009-11-21  Eric Seidel  <eric@webkit.org>
276
277         Reviewed by Adam Barth.
278
279         bugzilla-tool --help spews way too much text
280         https://bugs.webkit.org/show_bug.cgi?id=31771
281
282         * Scripts/bugzilla-tool:
283          - Remove self.cached_scm initialization hack.
284         * Scripts/modules/buildbot.py:
285          - Make default_host accessible to callers.
286         * Scripts/modules/commands/download.py:
287          - Phrase help for all commands consistently and remove spurious help text punctuation.
288         * Scripts/modules/commands/queries.py: Ditto.
289         * Scripts/modules/commands/queues.py: Ditto.
290         * Scripts/modules/commands/upload.py: Ditto.
291         * Scripts/modules/multicommandtool.py:
292          - Add HelpPrintingOptionParser.format_epilog to replace
293            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
294            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
295          - Make --help only show a list of commands like "svn help" and "git help" do --
296            previously --help was listing all commands and options.
297          - Sort list of commands alphabetically.
298
299 2009-11-21  Eric Seidel  <eric@webkit.org>
300
301         No review.  Fixing a typo from the previous patch for bug 31767.
302
303         AbstractQueue.run_bugzilla_tool throws an exception
304         https://bugs.webkit.org/show_bug.cgi?id=31769
305
306         * Scripts/modules/commands/queues.py:
307
308 2009-11-21  Eric Seidel  <eric@webkit.org>
309
310         Reviewed by Adam Barth.
311
312         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
313         https://bugs.webkit.org/show_bug.cgi?id=31767
314
315         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
316         Since we don't have a good way to test BugzillaTool pieces, I've
317         left out a test for now.
318
319         * Scripts/bugzilla-tool:
320          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
321         * Scripts/modules/commands/queues.py:
322          - Use tool.path() instead of __file__.
323         * Scripts/modules/multicommandtool.py:
324          - Add a new path() method to MultiComandTool.
325         * Scripts/modules/multicommandtool_unittest.py:
326          - Provide a path() method.  Little point in testing this mock implementation.
327
328 2009-11-21  Adam Barth  <abarth@webkit.org>
329
330         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
331         WebKitTools.
332
333         * Scripts/modules/commands/download.py:
334
335 2009-11-21  Adam Barth  <abarth@webkit.org>
336
337         Reviewed by Eric Seidel.
338
339         Convert check-style to use LandingSequence
340         https://bugs.webkit.org/show_bug.cgi?id=31763
341
342         Instead of manipulating the working copy by hand, we should use the
343         LandingSequence in CheckStyle.  This will make this code eaiser to
344         test.
345
346         * Scripts/modules/commands/download.py:
347
348 2009-11-20  Adam Barth  <abarth@webkit.org>
349
350         Reviewed by Eric Seidel.
351
352         Unit test query commands
353         https://bugs.webkit.org/show_bug.cgi?id=31755
354
355         These tests are pretty rough, but hopefully they'll grow.
356
357         * Scripts/modules/commands/queries_unittest.py: Added.
358         * Scripts/modules/mock_bugzillatool.py: Added.
359         * Scripts/run-webkit-unittests:
360
361 2009-11-20  Eric Seidel  <eric@webkit.org>
362
363         Reviewed by Adam Barth.
364
365         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
366         https://bugs.webkit.org/show_bug.cgi?id=31758
367
368         * Scripts/modules/multicommandtool.py:
369          - Allow passing of explicit commands to MultiCommandTool.__init__
370         * Scripts/modules/multicommandtool_unittest.py:
371          - Use new Command.name naming system.
372          - Test Command auto-discovery.
373         * Scripts/modules/workqueue.py:
374          - bug_id no longer exists, use patch['bug_id'] instead.
375         * Scripts/modules/workqueue_unittest.py:
376          - WorkQueues require names now.
377          - should_proceed_with_work_item must return a patch object.
378
379 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
380
381         Reviewed by Beth Dakin.
382
383         WAI-ARIA: add support for aria-owns
384         https://bugs.webkit.org/show_bug.cgi?id=31702
385
386         * DumpRenderTree/AccessibilityUIElement.cpp:
387         (ariaOwnsElementAtIndexCallback):
388         (AccessibilityUIElement::getJSClass):
389         * DumpRenderTree/AccessibilityUIElement.h:
390         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
391         (AccessibilityUIElement::ariaOwnsElementAtIndex):
392         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
393         (AccessibilityUIElement::ariaOwnsElementAtIndex):
394         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
395         (AccessibilityUIElement::ariaOwnsElementAtIndex):
396
397 2009-11-20  Eric Seidel  <eric@webkit.org>
398
399         Reviewed by Adam Barth.
400
401         Fix exception thrown when running the commit-queue.
402
403         * Scripts/modules/statusbot.py: patch is optional.
404         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
405
406 2009-11-20  Eric Seidel  <eric@webkit.org>
407
408         Reviewed by Adam Barth.
409
410         Teach the StatusBot how to support more than just the commit-queue
411         https://bugs.webkit.org/show_bug.cgi?id=31754
412
413         * Scripts/modules/workqueue.py: Another typo.
414
415 2009-11-20  Eric Seidel  <eric@webkit.org>
416
417         Reviewed by Adam Barth.
418
419         Teach the StatusBot how to support more than just the commit-queue
420         https://bugs.webkit.org/show_bug.cgi?id=31754
421
422         * Scripts/modules/commands/queues.py: Fix silly typo.
423
424 2009-11-20  Eric Seidel  <eric@webkit.org>
425
426         Reviewed by Adam Barth.
427
428         Teach the StatusBot how to support more than just the commit-queue
429         https://bugs.webkit.org/show_bug.cgi?id=31754
430
431         * CommitQueueStatus/index.yaml:
432          - Add indices required for the new queries.
433         * CommitQueueStatus/queue_status.py:
434          - Add a patch-status page and move update_status to update-status.
435          - Only display "commit-queue" status records for the commit-queue.
436          - Add support for a queue_name property on status records.
437          - Fix _int_from_request to actually work.
438         * CommitQueueStatus/update_status.html:
439          - Add support for a queue_name on status records.
440          - Remove unused list of bug ids.
441          * Scripts/modules/commands/queues.py
442           - Make the queues pass the patch instead of the bug_id to StatusBot.
443         * Scripts/modules/statusbot.py:
444          - Support passing the queue_name to the status updates.
445          - Support fetching patch status with patch_status().
446         * Scripts/modules/workqueue.py:
447          - Pass the patch to the StatusBot instead of the bug_id.
448          - Let WorkQueues have a name.
449
450 2009-11-20  Adam Barth  <abarth@webkit.org>
451
452         Reviewed by Eric Seidel.
453
454         Move bugzilla-tool commands into their own file
455         https://bugs.webkit.org/show_bug.cgi?id=31752
456
457         This will let us write unit tests.
458
459         * Scripts/bugzilla-tool:
460         * Scripts/modules/commands/__init__.py: Added.
461         * Scripts/modules/commands/download.py: Added.
462         * Scripts/modules/commands/queries.py: Added.
463         * Scripts/modules/commands/queues.py: Added.
464         * Scripts/modules/commands/upload.py: Added.
465         * Scripts/modules/grammar.py: Added.
466
467 2009-11-20  Adam Barth  <abarth@webkit.org>
468
469         Reviewed by Eric Seidel.
470
471         BuildQueue should check if the tree is currently buildable
472         https://bugs.webkit.org/show_bug.cgi?id=31744
473
474         * Scripts/bugzilla-tool:
475         * Scripts/modules/landingsequence.py:
476         * Scripts/modules/webkitlandingscripts.py:
477
478 2009-11-20  Adam Barth  <abarth@webkit.org>
479
480         Reviewed by Eric Seidel.
481
482         Move prepare_clean_working_directory into the LandingSequence
483         https://bugs.webkit.org/show_bug.cgi?id=31743
484
485         * Scripts/bugzilla-tool:
486         * Scripts/modules/landingsequence.py:
487
488 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
489
490         Reviewed by Kenneth Rohde Christiansen.
491
492         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
493         https://bugs.webkit.org/show_bug.cgi?id=30460
494
495         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
496
497         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
498         (pluginInvoke):
499
500 2009-11-20  Adam Barth  <abarth@webkit.org>
501
502         Reviewed by Eric Seidel.
503
504         Pass the port information to the child process
505         https://bugs.webkit.org/show_bug.cgi?id=31736
506
507         We need to do this so the child process knows what to build!
508
509         * Scripts/bugzilla-tool:
510         * Scripts/modules/landingsequence.py:
511         * Scripts/modules/webkitport.py:
512         * Scripts/modules/webkitport_unittest.py:
513
514 2009-11-20  Adam Barth  <abarth@webkit.org>
515
516         Reviewed by Eric Seidel.
517
518         Support Qt port in build-queue
519         https://bugs.webkit.org/show_bug.cgi?id=31733
520
521         * Scripts/bugzilla-tool:
522
523 2009-11-20  Adam Barth  <abarth@webkit.org>
524
525         Reviewed by Eric Seidel.
526
527         Implement a build-queue
528         https://bugs.webkit.org/show_bug.cgi?id=31725
529
530         Currently this just builds the first 10 patches in the review queue.
531         We'll want to do something smarter soon.
532
533         * Scripts/bugzilla-tool:
534
535 2009-11-20  Adam Barth  <abarth@webkit.org>
536
537         Reviewed by Eric Seidel.
538
539         Make commit-queue and style-queue show up in help
540         https://bugs.webkit.org/show_bug.cgi?id=31724
541
542         We need to store their names on their class to make these commands
543         properly register themselves with MultiCommandTool.
544
545         * Scripts/bugzilla-tool:
546
547 2009-11-20  Adam Barth  <abarth@webkit.org>
548
549         Reviewed by Eric Seidel.
550
551         Implement bugzilla-tool build-attachment
552         https://bugs.webkit.org/show_bug.cgi?id=31722
553
554         This command builds an attachment from bugzilla.  It leaves the built
555         patch in the working copy.
556
557         * Scripts/bugzilla-tool:
558         * Scripts/modules/landingsequence.py:
559         * Scripts/modules/webkitlandingscripts.py:
560
561 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
562
563         Reviewed by Xan Lopez.
564
565         [GTK] DRT release event does not create the state correctly
566         https://bugs.webkit.org/show_bug.cgi?id=31717
567
568         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
569
570 2009-11-20  Eric Seidel  <eric@webkit.org>
571
572         Reviewed by Adam Barth.
573
574         MultiCommandTool should find Command objects automatically instead of with a manual list
575         https://bugs.webkit.org/show_bug.cgi?id=31710
576
577         * Scripts/bugzilla-tool:
578         * Scripts/modules/multicommandtool.py:
579          - Use some wild python-fu to crawl all the known subclasses of Command.
580
581 2009-11-20  Adam Barth  <abarth@webkit.org>
582
583         Unreviewed "build" fix.  Added missing import.
584
585         * Scripts/bugzilla-tool:
586
587 2009-11-20  Adam Barth  <abarth@webkit.org>
588
589         Unreviewed "build" fix.  I failed to update LandingSequence.test
590         properly.
591
592         * Scripts/modules/landingsequence.py:
593
594 2009-11-20  Adam Barth  <abarth@webkit.org>
595
596         Reviewed by Eric Seidel.
597
598         Create LandingSequence as the all-sing, all-dance landing class
599         https://bugs.webkit.org/show_bug.cgi?id=31709
600
601         Client can inherit from this class to carefully control exactly which
602         steps they wish to have happen in the landing sequence.
603
604         * Scripts/bugzilla-tool:
605         * Scripts/modules/landingsequence.py: Added.
606         * Scripts/modules/webkitlandingscripts.py: Added.
607
608 2009-11-19  Adam Barth  <abarth@webkit.org>
609
610         Reviewed by Eric Seidel.
611
612         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
613         https://bugs.webkit.org/show_bug.cgi?id=31707
614
615         This is to help when we implement build-attachment.
616
617         * Scripts/bugzilla-tool:
618
619 2009-11-19  Adam Barth  <abarth@webkit.org>
620
621         Reviewed by Eric Seidel.
622
623         Support Qt port in bugzilla-tool
624         https://bugs.webkit.org/show_bug.cgi?id=31701
625
626         Now we support building with Qt!
627
628         * Scripts/bugzilla-tool:
629         * Scripts/modules/webkitport.py: Added.
630         * Scripts/modules/webkitport_unittest.py: Added.
631         * Scripts/run-webkit-unittests:
632
633 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
634
635         Reviewed by Adam Barth.
636
637         Remove inserting stderr into patch in bugzilla-tool
638         https://bugs.webkit.org/show_bug.cgi?id=29914
639
640         Modify SCM python module's run_command function to avoid return of stderr
641         by default, so stderr won't be inserted into the patches.
642         Modify the related unit test.
643
644         * Scripts/modules/scm.py:
645         * Scripts/modules/scm_unittest.py:
646
647 2009-11-19  Eric Seidel  <eric@webkit.org>
648
649         Reviewed by Adam Barth.
650
651         bugzilla-tool needs per-command help
652         https://bugs.webkit.org/show_bug.cgi?id=31697
653
654         Added support for "bugzilla-tool help command-name"
655         and a unit test to make sure it works.
656
657         * Scripts/modules/multicommandtool.py:
658         * Scripts/modules/multicommandtool_unittest.py:
659
660 2009-11-19  Eric Seidel  <eric@webkit.org>
661
662         Reviewed by Adam Barth.
663
664         Move MultiCommandTool and Command into a separate file and add some basic unit tests
665         https://bugs.webkit.org/show_bug.cgi?id=31695
666
667         * Scripts/bugzilla-tool:
668         * Scripts/modules/multicommandtool.py: Added.
669         * Scripts/modules/multicommandtool_unittest.py: Added.
670         * Scripts/run-webkit-unittests:
671
672 2009-11-19  Eric Seidel  <eric@webkit.org>
673
674         No review, just adding a FIXME.
675
676         Split out command parsing and help printing from BugzillaTool
677         https://bugs.webkit.org/show_bug.cgi?id=31688
678
679         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
680
681 2009-11-19  Eric Seidel  <eric@webkit.org>
682
683         Reviewed by Adam Barth.
684
685         Split out command parsing and help printing from BugzillaTool
686         https://bugs.webkit.org/show_bug.cgi?id=31688
687
688         * Scripts/bugzilla-tool:
689          - Add new MultiCommandTool class to contain option parsing and help printing logic.
690          - Rename private methods to use _ pattern.
691          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
692          - 
693
694 2009-11-19  Eric Seidel  <eric@webkit.org>
695
696         Reviewed by Adam Barth.
697
698         Re-factor help printing to use modern python idioms
699         https://bugs.webkit.org/show_bug.cgi?id=31685
700
701         * Scripts/bugzilla-tool:
702
703 2009-11-19  Eric Seidel  <eric@webkit.org>
704
705         Reviewed by Darin Adler.
706
707         commit-queue empty queue logs twice
708         https://bugs.webkit.org/show_bug.cgi?id=31679
709
710         * Scripts/bugzilla-tool:
711
712 2009-11-19  Eric Seidel  <eric@webkit.org>
713
714         Reviewed by Darin Adler.
715
716         bugzilla-tool's reviewer/committer rejection message should be clearer
717         https://bugs.webkit.org/show_bug.cgi?id=31126
718
719         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
720
721         * Scripts/modules/bugzilla.py:
722
723 2009-11-19  Eric Z. Ayers  <zundel@google.com>
724
725         Reviewed by Pavel Feldman.
726
727         Forces a WM_PAINT event on calling layoutTestController.display()
728         in order to enable the timeline-paint.html test on Windows.
729         ::UpdateWindow() does not force an event becaue the window is 
730         not visible.
731
732         https://bugs.webkit.org/show_bug.cgi?id=31402
733
734         * DumpRenderTree/win/DumpRenderTree.cpp:
735         (displayWebView):
736
737 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
738
739         No review needed.
740
741         Added myself to committers list.
742
743         * Scripts/modules/committers.py:
744
745 2009-11-19  Adam Barth  <abarth@webkit.org>
746
747         Reviewed by Eric Seidel.
748
749         Bugzilla-tool command classes should match command names
750         https://bugs.webkit.org/show_bug.cgi?id=31666
751
752         I renamed all the commands except CommitMessageForCurrentDiff because
753         the new name would conflict with an existing class.
754
755         * Scripts/bugzilla-tool:
756
757 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
758
759         Reviewed by Gustavo Noronha Silva.
760
761         Web Inspector: Implement "show inspector" in WebKit GTK
762         API and enable console tests.
763
764         https://bugs.webkit.org/show_bug.cgi?id=31669
765
766         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
767         (LayoutTestController::showWebInspector):
768
769 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
770
771         Reviewed by Simon Hausmann.
772
773         Minor refactoring + more documentation.
774
775         * DumpRenderTree/qt/DumpRenderTree.cpp:
776         (WebCore::clearHistory):
777         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
778
779 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
780
781         Reviewed by Eric Seidel.
782
783         Ignore websocket tests when --no-http is specified.
784         https://bugs.webkit.org/show_bug.cgi?id=31662
785
786         * Scripts/run-webkit-tests:
787
788 2009-11-18  Adam Barth  <abarth@webkit.org>
789
790         Reviewed by Eric Seidel.
791
792         Normalize ' and " in bugzilla-tool
793         https://bugs.webkit.org/show_bug.cgi?id=31655
794
795         We decided " is better than ' and we should be consistent.
796
797         * Scripts/bugzilla-tool:
798
799 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
800
801         Reviewed by Kenneth Rohde Christiansen.
802
803         [Qt] Remove support for Qt v4.3 or older versions
804         https://bugs.webkit.org/show_bug.cgi?id=29469
805
806         * DumpRenderTree/qt/DumpRenderTree.pro:
807         * DumpRenderTree/qt/ImageDiff.pro:
808
809 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
810
811         Reviewed by Eric Seidel.
812
813         GitTest.test_create_binary_patch fails if /tmp is symlink
814         https://bugs.webkit.org/show_bug.cgi?id=31536
815
816         * Scripts/modules/scm_unittest.py:
817
818 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
819
820         Reviewed by Darin Adler.
821
822         Configuration for Chromium Build Slaves.
823
824         https://bugs.webkit.org/show_bug.cgi?id=31442
825
826         * BuildSlaveSupport/build.webkit.org-config/config.json:
827         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
828
829 2009-11-18  Eric Seidel  <eric@webkit.org>
830
831         Reviewed by Darin Adler.
832
833         workqueue.py results in totally broken commit-queue UI
834         https://bugs.webkit.org/show_bug.cgi?id=31645
835
836         * Scripts/bugzilla-tool:
837          - Remove unneeded use of PatchCollection.
838          - Grab a new copy of the cq'd patches every run of the queue.
839
840 2009-11-18  Sam Weinig  <sam@webkit.org>
841
842         Reviewed by Anders Carlsson.
843
844         Make the Mac Geolocation API async.
845
846         Update DRT to use the new async Mac Geolocation API.
847
848         * DumpRenderTree/mac/UIDelegate.mm:
849         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
850
851 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
852
853         Reviewed by Kenneth Rohde Christiansen.
854
855         Add and option to toggle HTML5 datalist support to build-webkit
856         https://bugs.webkit.org/show_bug.cgi?id=31599
857
858         * Scripts/build-webkit:
859
860 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
861
862         Reviewed by Kevin Ollivier.
863
864         Enable wx plugin support using the Windows implementation as a base.
865         
866         https://bugs.webkit.org/show_bug.cgi?id=31636
867
868         * wx/build/settings.py:
869
870 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
871
872         Reviewed by Simon Hausmann.
873
874         Change the initialization order so that the controllers
875         will be created before exporting them to the JS DOM window.
876
877         * DumpRenderTree/qt/DumpRenderTree.cpp:
878         (WebCore::DumpRenderTree::DumpRenderTree):
879
880 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
881
882         Reviewed by Simon Hausmann.
883
884         Fix a code copy and paste error. m_page should be page.
885
886         * DumpRenderTree/qt/DumpRenderTree.cpp:
887         (WebCore::DumpRenderTree::createWindow):
888
889 2009-11-17  Mark Rowe  <mrowe@apple.com>
890
891         Reviewed by Alexey Proskuryakov.
892
893         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
894
895         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
896         This prevents symlinks from confusing the descendant check.
897
898 2009-11-17  Mark Rowe  <mrowe@apple.com>
899
900         Reviewed by Alexey Proskuryakov.
901
902         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
903
904         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
905         server to be up rather than having run-webkit-tests abort immediately.
906
907         * Scripts/run-webkit-tests:
908
909 2009-11-17  Eric Seidel  <eric@webkit.org>
910
911         Reviewed by Darin Adler.
912
913         commit-queue is failing to set reviewer in ChangeLogs
914         https://bugs.webkit.org/show_bug.cgi?id=31592
915
916         * Scripts/bugzilla-tool: Clarify the "applying" log message.
917         * Scripts/modules/bugzilla.py:
918          - Add a new _validate_committer_and_reviewer function as a
919            temporary solution until we can make a real Attachment object
920            which knows how to fill in its committer/reviewer fields automatically.
921
922 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
923
924         Unreviewed buildbot fix.
925
926         Revert part of earlier patch and add comment, as it
927         was causing timeouts on the buildbot.
928
929         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
930         (LayoutTestController::notifyDone):
931
932 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
933
934         Reviewed by Oliver Hunt.
935
936         Make the timeout 15 sec as for the other DRT's and make
937         it print out the same output when a test timeout.
938
939         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
940         (LayoutTestController::waitUntilDone):
941         (LayoutTestController::notifyDone):
942         (LayoutTestController::timerEvent):
943
944 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
945
946         Reviewed by Timothy Hatcher.
947
948         Fixed typos in comments.
949
950         * Scripts/modules/committers.py:
951
952 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
953
954         Reviewed by Timothy Hatcher.
955
956         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
957         - Updated DRT to show/close inspector for all tests under /inspector
958         - Introduced LayoutTestController::setTimelineProfilingEnabled and
959           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
960         - Removed reload on each inspector test
961         - Renamed fast/inspector to fast/inspector-support in order not to trigger
962         inspector for those.
963         - Reimplemented timeline tests in order to get rid of reload there.
964         - Moved tests that don't require harness into the fast group.
965
966         https://bugs.webkit.org/show_bug.cgi?id=31472
967
968         * DumpRenderTree/LayoutTestController.cpp:
969         (setTimelineProfilingEnabledCallback):
970         (closeWebInspectorCallback):
971         (LayoutTestController::staticFunctions):
972         * DumpRenderTree/LayoutTestController.h:
973         * DumpRenderTree/gtk/DumpRenderTree.cpp:
974         (shouldOpenWebInspector):
975         (runTest):
976         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
977         (LayoutTestController::setTimelineProfilingEnabled):
978         * DumpRenderTree/mac/DumpRenderTree.mm:
979         (shouldOpenWebInspector):
980         (runTest):
981         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
982         (LayoutTestController::setTimelineProfilingEnabled):
983         * DumpRenderTree/win/DumpRenderTree.cpp:
984         (shouldOpenWebInspector):
985         (runTest):
986         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
987         (LayoutTestController::setTimelineProfilingEnabled):
988
989 2009-11-17  Oliver Hunt  <oliver@apple.com>
990
991         Reviewed by Maciej Stachowiak.
992
993         Incorrect use of JavaScriptCore API in DumpRenderTree
994         https://bugs.webkit.org/show_bug.cgi?id=31577
995
996         Return undefined rather than a literal null.
997
998         * DumpRenderTree/AccessibilityUIElement.cpp:
999         (setSelectedTextRangeCallback):
1000         (incrementCallback):
1001         (decrementCallback):
1002         (showMenuCallback):
1003
1004 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1005
1006         Reviewed by Beth Dakin.
1007
1008         AX: aria-labelledby duplicates some of its WAI-ARIA label
1009         https://bugs.webkit.org/show_bug.cgi?id=31565
1010
1011         * DumpRenderTree/AccessibilityUIElement.cpp:
1012         (titleUIElementCallback):
1013         (getIsValidCallback):
1014         (AccessibilityUIElement::getJSClass):
1015
1016 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1017
1018         Reviewed by Simon Hausmann.
1019
1020         r50942 broke output from created windows. Make the
1021         m_enableTextOutput a member of the DRT and not the
1022         WebPage.
1023
1024         * DumpRenderTree/qt/DumpRenderTree.cpp:
1025         (WebCore::WebPage::WebPage):
1026         (WebCore::WebPage::javaScriptAlert):
1027         (WebCore::WebPage::javaScriptConsoleMessage):
1028         (WebCore::WebPage::javaScriptConfirm):
1029         (WebCore::WebPage::javaScriptPrompt):
1030         (WebCore::WebPage::acceptNavigationRequest):
1031         (WebCore::DumpRenderTree::DumpRenderTree):
1032         (WebCore::DumpRenderTree::open):
1033         (WebCore::DumpRenderTree::createWindow):
1034         * DumpRenderTree/qt/DumpRenderTree.h:
1035         (WebCore::DumpRenderTree::setTextOutputEnabled):
1036         (WebCore::DumpRenderTree::isTextOutputEnabled):
1037         (WebCore::WebPage::shouldInterruptJavaScript):
1038         (WebCore::WebPage::isTextOutputEnabled):
1039         (WebCore::WebPage::setViewGeometry):
1040
1041 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1042
1043         Reviewed by Gustavo Noronha Silva.
1044
1045         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
1046         as the implementation is being used by at least Qt and Gtk+.
1047
1048         Update buildsystems as well.
1049
1050         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1051         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1052         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1053         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1054         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1055         * GNUmakefile.am:
1056
1057 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
1058
1059         Reviewed by Alexey Proskuryakov.
1060
1061         Disable wss until all platforms support pyOpenSSL
1062
1063         https://bugs.webkit.org/show_bug.cgi?id=31479
1064
1065         * Scripts/run-webkit-tests:
1066
1067 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1068
1069         Reviewed by Kenneth Christiansen.
1070
1071         [Qt] Implement load error pages support for Qt's DRT.
1072         https://bugs.webkit.org/show_bug.cgi?id=31509
1073
1074         For now, it will not be a default feature, and layout tests
1075         that want to make use of this have to explicitily call
1076         'handleErrorPages();' for the test source.
1077
1078         Any of the other DumpRenderTree's (mac, win and gtk)
1079         support handling error pages. Qt's will be the first.
1080
1081         * DumpRenderTree/qt/DumpRenderTree.cpp:
1082         (WebCore::WebPage::supportsExtension):
1083         (WebCore::WebPage::extension):
1084         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1085         (LayoutTestController::reset):
1086         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1087         (LayoutTestController::shouldHandleErrorPages):
1088         (LayoutTestController::handleErrorPages):
1089
1090 2009-11-16  Eric Seidel  <eric@webkit.org>
1091
1092         Reviewed by Adam Barth.
1093
1094         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1095         https://bugs.webkit.org/show_bug.cgi?id=31549
1096
1097         Renamed --commit-queue to --non-interactive in most places
1098         and remove the code in land-patches which is no longer needed.
1099
1100         * Scripts/bugzilla-tool:
1101
1102 2009-11-16  Eric Seidel  <eric@webkit.org>
1103
1104         Reviewed by Adam Barth.
1105
1106         The commit-queue should use land-attachment
1107         https://bugs.webkit.org/show_bug.cgi?id=31548
1108
1109         * Scripts/bugzilla-tool:
1110
1111 2009-11-16  Adam Barth  <abarth@webkit.org>
1112
1113         Reviewed by Eric Seidel.
1114
1115         Convert CommitQueue over to PatchCollection
1116         https://bugs.webkit.org/show_bug.cgi?id=31547
1117
1118         Also fixes a bug in workqueue and adds a test!
1119
1120         * Scripts/bugzilla-tool:
1121         * Scripts/modules/workqueue.py:
1122         * Scripts/modules/workqueue_unittest.py:
1123
1124 2009-11-16  Adam Barth  <abarth@webkit.org>
1125
1126         Reviewed by Eric Seidel.
1127
1128         Move StyleQueue over to using PatchCollection
1129         https://bugs.webkit.org/show_bug.cgi?id=31544
1130
1131         That's what the class it's for.
1132
1133         * Scripts/bugzilla-tool:
1134         * Scripts/modules/patchcollection.py:
1135         * Scripts/modules/patchcollection_unittest.py:
1136
1137 2009-11-16  Eric Seidel  <eric@webkit.org>
1138
1139         Reviewed by Adam Barth.
1140
1141         bugzilla-tool needs a land-attachment command
1142         https://bugs.webkit.org/show_bug.cgi?id=31546
1143
1144         * Scripts/bugzilla-tool:
1145          - Move all the logic into AbstractLandingCommand and
1146            add a new LandAttachment command subclass.
1147          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1148
1149 2009-11-16  Eric Seidel  <eric@webkit.org>
1150
1151         Reviewed by Adam Barth.
1152
1153         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1154         https://bugs.webkit.org/show_bug.cgi?id=31543
1155
1156         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1157
1158         * Scripts/bugzilla-tool:
1159
1160 2009-11-16  Eric Seidel  <eric@webkit.org>
1161
1162         Reviewed by Adam Barth.
1163
1164         Disable the style queue from posting to the commit queue status page.
1165
1166         * Scripts/bugzilla-tool:
1167
1168 2009-11-16  Adam Barth  <abarth@webkit.org>
1169
1170         Reviewed by Eric Seidel.
1171
1172         Implement PatchCollection
1173         https://bugs.webkit.org/show_bug.cgi?id=31541
1174
1175         This class holds a set of patches and lets clients iterate through
1176         them.  Optionally, clients can install a filter.
1177
1178         * Scripts/modules/patchcollection.py: Added.
1179         * Scripts/modules/patchcollection_unittest.py: Added.
1180         * Scripts/run-webkit-unittests:
1181
1182 2009-11-16  Eric Seidel  <eric@webkit.org>
1183
1184         Reviewed by Adam Barth.
1185
1186         bugzilla-tool land-patches will close bugs with patches r=?
1187         https://bugs.webkit.org/show_bug.cgi?id=28230
1188
1189         The commit-queue shouldn't close patches with outstanding reviews on them,
1190         even if many reviewers seem to be against multi-patch bugs.
1191
1192         * Scripts/bugzilla-tool:
1193
1194 2009-11-16  Eric Seidel  <eric@webkit.org>
1195
1196         Reviewed by Adam Barth.
1197
1198         bugzilla-tool check-style should work with attachment ids instead of bug ids
1199         https://bugs.webkit.org/show_bug.cgi?id=31540
1200
1201         * Scripts/bugzilla-tool:
1202
1203 2009-11-16  Eric Seidel  <eric@webkit.org>
1204
1205         Reviewed by Adam Barth.
1206
1207         WorkQueue is the only place that should know about special exit codes
1208         https://bugs.webkit.org/show_bug.cgi?id=31534
1209
1210         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1211         and add tests for handling exit codes.
1212         I also cleaned up workqueue_unittest.py more.
1213
1214         * Scripts/bugzilla-tool:
1215         * Scripts/modules/workqueue.py:
1216         * Scripts/modules/workqueue_unittest.py:
1217
1218 2009-11-16  Eric Seidel  <eric@webkit.org>
1219
1220         Reviewed by Adam Barth.
1221
1222         Re-factor workqueue_unittest to allow for more than one test.
1223         https://bugs.webkit.org/show_bug.cgi?id=31535
1224
1225         * Scripts/modules/workqueue_unittest.py:
1226
1227 2009-11-16  Eric Seidel  <eric@webkit.org>
1228
1229         Reviewed by Adam Barth.
1230
1231         land-patches needs to be re-factored into smaller chunks
1232         https://bugs.webkit.org/show_bug.cgi?id=31532
1233
1234         * Scripts/bugzilla-tool: fix a couple obvious typos.
1235
1236 2009-11-16  Eric Seidel  <eric@webkit.org>
1237
1238         Reviewed by Adam Barth.
1239
1240         land-patches needs to be re-factored into smaller chunks
1241         https://bugs.webkit.org/show_bug.cgi?id=31532
1242
1243         The next patch will move these methods into WebKitLandingScripts.
1244
1245         * Scripts/bugzilla-tool:
1246          - Split out _land_patch and _close_bug_if_no_active_patches.
1247
1248 2009-11-16  Adam Barth  <abarth@webkit.org>
1249
1250         Reviewed by Eric Seidel.
1251
1252         Fix silly copy-and-paste code.  I am a terrible coder.
1253
1254         * Scripts/modules/bugzilla.py:
1255
1256 2009-11-16  Adam Barth  <abarth@webkit.org>
1257
1258         Reviewed by Eric Seidel.
1259
1260         Implement a StyleQueue
1261         https://bugs.webkit.org/show_bug.cgi?id=31537
1262
1263         The first iteration of the style queue only produces output locally.
1264         There is also a limit of 10 patches because it's not that useful to
1265         iterate through the entire review queue at this point.  We can remove
1266         the limit later.
1267
1268         * Scripts/bugzilla-tool:
1269         * Scripts/modules/bugzilla.py:
1270
1271 2009-11-16  Adam Barth  <abarth@webkit.org>
1272
1273         Reviewed by Eric Seidel.
1274
1275         Unit test WorkQueue
1276         https://bugs.webkit.org/show_bug.cgi?id=31531
1277
1278         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1279
1280         * Scripts/bugzilla-tool:
1281         * Scripts/modules/statusbot.py:
1282         * Scripts/modules/workqueue.py:
1283         * Scripts/modules/workqueue_unittest.py: Added.
1284         * Scripts/run-webkit-unittests:
1285
1286 2009-11-16  Eric Seidel  <eric@webkit.org>
1287
1288         Reviewed by Adam Barth.
1289
1290         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1291         https://bugs.webkit.org/show_bug.cgi?id=31530
1292
1293         * Scripts/bugzilla-tool:
1294
1295 2009-11-16  Eric Seidel  <eric@webkit.org>
1296
1297         Reviewed by Adam Barth.
1298
1299         bugzilla-tool needs apply-attachment
1300         https://bugs.webkit.org/show_bug.cgi?id=31528
1301
1302         * Scripts/bugzilla-tool:
1303          - Add ApplyAttachment command.
1304          - Abstract applying code into WebKitApplyingScripts.
1305          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1306         * Scripts/modules/bugzilla.py:
1307          - Add fetch_attachment and bug_id_for_attachment_id.
1308         * Scripts/modules/bugzilla_unittest.py:
1309          - Add test for new parsing.
1310          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1311
1312 2009-11-16  Eric Seidel  <eric@webkit.org>
1313
1314         Reviewed by Adam Barth.
1315
1316         Document check-style's use of force_clean.
1317
1318         * Scripts/bugzilla-tool:
1319         * Scripts/modules/scm.py:
1320
1321 2009-11-16  Adam Barth  <abarth@webkit.org>
1322
1323         Reviewed by Eric Seidel.
1324
1325         Move WorkQueue to its own file
1326         https://bugs.webkit.org/show_bug.cgi?id=31529
1327
1328         WorkQueue and WorkQueueDelegate are separate concerns from
1329         bugzilla-tool.  Also added a missing include to logging.py.
1330
1331         * Scripts/bugzilla-tool:
1332         * Scripts/modules/logging.py:
1333         * Scripts/modules/workqueue.py:
1334
1335 2009-11-16  Adam Barth  <abarth@webkit.org>
1336
1337         Reviewed by Eric Seidel.
1338
1339         Move OutputTee to logging.py.
1340
1341         * Scripts/bugzilla-tool:
1342         * Scripts/modules/logging.py:
1343
1344 2009-11-15  Adam Barth  <abarth@webkit.org>
1345
1346         Reviewed by Eric Seidel.
1347
1348         Refactor bugzilla-tool to allow for multiple queues
1349         https://bugs.webkit.org/show_bug.cgi?id=31513
1350
1351         Divide the commit queue class into three class to make creating
1352         additional queues easier.
1353
1354         * Scripts/bugzilla-tool:
1355
1356 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1357
1358         Reviewed by Eric Seidel.
1359
1360         svn-apply may not handle git patches created by bugzilla-tool
1361         https://bugs.webkit.org/show_bug.cgi?id=31457
1362
1363         * Scripts/modules/scm.py:
1364         * Scripts/modules/scm_unittest.py:
1365
1366 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1367
1368         Reviewed by Eric Seidel.
1369
1370         bugzilla-tool should post git binary diff
1371         https://bugs.webkit.org/show_bug.cgi?id=31458
1372
1373         Add --binary option to Git.create_patch.
1374
1375         * Scripts/modules/scm.py:
1376         * Scripts/modules/scm_unittest.py:
1377
1378 2009-11-15  Adam Barth  <abarth@webkit.org>
1379
1380         Reviewed by Darin Adler.
1381
1382         Add bugzilla-tool check-style
1383         https://bugs.webkit.org/show_bug.cgi?id=31515
1384
1385         * Scripts/bugzilla-tool:
1386         * Scripts/modules/bugzilla.py:
1387
1388 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1389
1390         Reviewed by Simon Hausmann.
1391
1392         Make the Qt Linux only --valgrind feature, suppress errors
1393         defined in the SuppressedValgrindErrors file.
1394
1395         * Scripts/run-webkit-tests:
1396
1397 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1398
1399         Reviewed by Simon Hausmann.
1400
1401         Set the locale to C and not to the current one in use on the system.
1402
1403         * DumpRenderTree/qt/DumpRenderTree.cpp:
1404         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1405
1406 2009-11-13  Adam Roben  <aroben@apple.com>
1407
1408         Add support for
1409         http/tests/security/isolatedWorld/didClearWindowObject.html
1410
1411         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1412         window objects in isolated worlds are cleared
1413
1414         Reviewed by Dave Hyatt.
1415
1416         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1417
1418         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1419         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1420         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1421         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1422         Added. Sets a __worldID property on the global object whose value is
1423         the ID of this world.
1424         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1425         Respond to this new delegate callback by calling through to one of the
1426         above new methods.
1427         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1428         (worldMap): Added. Returns a HashMap containing all the worlds we've
1429         created.
1430         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1431         haven't kept track of this world.
1432         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1433         instead of declaring our own.
1434
1435         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1436
1437         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1438         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1439         didClearWindowObjectForFrameInStandardWorld.
1440         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1441         Respond to this new delegate callback by calling through to one of the
1442         below new methods.
1443         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1444         Added. Sets a __worldID property on the gobal object whose value is
1445         the ID of this world.
1446         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1447         Added. Moved code here from didClearWindowObject.
1448
1449         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1450         didClearWindowObjectForFrame* functions.
1451
1452         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1453         (worldMap): Added. Returns a HashMap containing all the worlds we've
1454         created.
1455         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1456         haven't kept track of this world.
1457         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1458         instead of declaring our own.
1459
1460 2009-11-13  Adam Roben  <aroben@apple.com>
1461
1462         Finish replacing worldIDs with world objects
1463
1464         The only remaining use of worldIDs was in a method only used by DRT
1465         for the isolated worlds tests.
1466
1467         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1468
1469         Reviewed by Mark Rowe.
1470
1471         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1472         (LayoutTestController::evaluateScriptInIsolatedWorld):
1473         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1474         (LayoutTestController::evaluateScriptInIsolatedWorld):
1475         Updated for changes to WebFrame. Now holds the map of worldID -> world
1476         at this level instead of making WebKit do it.
1477
1478 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1479
1480         Reviewed by Simon Hausmann.
1481
1482         [Qt] Ensure the DRT does not output anything until first test is run
1483
1484         * DumpRenderTree/qt/DumpRenderTree.cpp:
1485         * DumpRenderTree/qt/DumpRenderTree.h:
1486
1487 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1488
1489         Reviewed by Tor Arne Vestbø.
1490
1491         Clear the undo stack in before each new test run.
1492
1493         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1494
1495         * DumpRenderTree/qt/DumpRenderTree.cpp:
1496         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1497
1498 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1499
1500         Reviewed by Kenneth Rohde Christiansen.
1501
1502         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1503
1504         * DumpRenderTree/qt/DumpRenderTree.cpp:
1505         (WebCore::WebPage::resetSettings):
1506         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1507         (LayoutTestController::overridePreference):
1508
1509 2009-11-13  Eric Seidel  <eric@webkit.org>
1510
1511         Reviewed by Adam Barth.
1512
1513         Update committers.py based on svn records
1514         https://bugs.webkit.org/show_bug.cgi?id=31366
1515
1516         This list was generated using validate-committer-lists from
1517         https://bugs.webkit.org/show_bug.cgi?id=30970
1518         and makes committers.py current for committers who have
1519         committed in the last 3 years.
1520
1521         * Scripts/modules/committers.py:
1522
1523 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1524
1525         Reviewed by Adam Barth.
1526
1527         The document-open.html test was flaky at times. The test invokes the layout test plugin
1528         which in its destroy stream handler opens a new document. This basically tears down the
1529         stream and the associated plugin instance. The pluginLog function in the layout test
1530         plugin attempts to retrieve the window script object on a torn down plugin instance
1531         which crashed consistently on windows in the debugger. The functions which issue
1532         these logs already have a valid window script object. We now have variants of the pluginLog
1533         function which take in a window script object with and without variable arguments. 
1534
1535         https://bugs.webkit.org/show_bug.cgi?id=31067
1536
1537         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1538         (pluginLogWithWindowObject):
1539         (pluginLogWithWindowObjectVariableArgs):
1540         (pluginLog):
1541         (notifyTestCompletion):
1542         (testDocumentOpen):
1543         (testWindowOpen):
1544
1545 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1546
1547         Reviewed by Gustavo Noronha Silva.
1548
1549         https://bugs.webkit.org/show_bug.cgi?id=30997
1550         [Gtk] Implemment AtkDocument
1551
1552         Added testing support.
1553
1554         * DumpRenderTree/AccessibilityUIElement.cpp:
1555         * DumpRenderTree/AccessibilityUIElement.h:
1556         (getDocumentEncodingCallback):
1557         (getDocumentURICallback):
1558         (AccessibilityUIElement::getJSClass):
1559         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1560         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1561         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1562         (AccessibilityUIElement::documentEncoding):
1563         (AccessibilityUIElement::documentURI):
1564
1565 2009-11-12  Adam Roben  <aroben@apple.com>
1566
1567         Replace worldIDs with world objects
1568
1569         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1570         user scripts/stylesheets and isolated worlds
1571
1572         Reviewed by Sam Weinig.
1573
1574         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1575         (LayoutTestController::addUserScript):
1576         (LayoutTestController::addUserStyleSheet):
1577         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1578         (LayoutTestController::addUserScript):
1579         (LayoutTestController::addUserStyleSheet):
1580         Changed these functions to create a new WebJSWorld each time they're
1581         called and to pass that world to WebKit.
1582
1583 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1584
1585         Reviewed by Oliver Hunt.
1586
1587         need to implement aria tree roles
1588         https://bugs.webkit.org/show_bug.cgi?id=31284
1589
1590         * DumpRenderTree/AccessibilityUIElement.cpp:
1591         (disclosedRowAtIndexCallback):
1592         (selectedRowAtIndexCallback):
1593         (isEqualCallback):
1594         (isAttributeSettableCallback):
1595         (isActionSupportedCallback):
1596         (disclosedByRowCallback):
1597         (hierarchicalLevelCallback):
1598         (AccessibilityUIElement::getJSClass):
1599         * DumpRenderTree/AccessibilityUIElement.h:
1600         (AccessibilityUIElement::isEqual):
1601         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1602         (AccessibilityUIElement::hierarchicalLevel):
1603         (AccessibilityUIElement::disclosedRowAtIndex):
1604         (AccessibilityUIElement::selectedRowAtIndex):
1605         (AccessibilityUIElement::disclosedByRow):
1606         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1607         (AccessibilityUIElement::getChildAtIndex):
1608         (AccessibilityUIElement::disclosedRowAtIndex):
1609         (AccessibilityUIElement::selectedRowAtIndex):
1610         (AccessibilityUIElement::titleUIElement):
1611         (AccessibilityUIElement::parentElement):
1612         (AccessibilityUIElement::disclosedByRow):
1613         (AccessibilityUIElement::hierarchicalLevel):
1614         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1615         (AccessibilityUIElement::hierarchicalLevel):
1616         (AccessibilityUIElement::disclosedRowAtIndex):
1617         (AccessibilityUIElement::selectedRowAtIndex):
1618         (AccessibilityUIElement::disclosedByRow):
1619
1620 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1621
1622         Reviewed by Darin Adler.
1623
1624         svn-apply can not handle git binary diffs
1625         https://bugs.webkit.org/show_bug.cgi?id=26830
1626
1627         Support "literal" type git binary diffs.
1628
1629         * Scripts/VCSUtils.pm:
1630         * Scripts/modules/scm_unittest.py:
1631         * Scripts/svn-apply:
1632
1633 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1634
1635         Not reviewed, removing duplicate entry for myself in committers.py.
1636
1637         * Scripts/modules/committers.py:
1638
1639 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1640
1641         Reviewed by Darin Adler and Mark Rowe.
1642
1643         https://bugs.webkit.org/show_bug.cgi?id=31200
1644         Tests in http/tests/security/mixedContent start to fail when new tests are added
1645
1646         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1647
1648 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1649
1650         Reviewed by Jan Alonzo.
1651
1652         Create, and display a window for the inspector, for inspector
1653         tests.
1654
1655         Need to also show/hide the inspector window to avoid having
1656         problems with code assuming it is realized
1657         https://bugs.webkit.org/show_bug.cgi?id=31347
1658
1659         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1660         (webInspectorShowWindow):
1661         (webInspectorCloseWindow):
1662         (webInspectorInspectWebView):
1663         (createWebView):
1664
1665 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1666
1667         Unreviewed Qt buildbot fix.
1668
1669         My previous fix was wrong, so revert that change and fix it by
1670         returning when the document of the frame has no document element.
1671         Idea is borrowed from mac and win DRT.
1672
1673         * DumpRenderTree/qt/DumpRenderTree.cpp:
1674         (WebCore::DumpRenderTree::dumpFramesAsText):
1675
1676 2009-11-11  Eric Seidel  <eric@webkit.org>
1677
1678         Reviewed byg Kenneth Rohde Christiansen.
1679
1680         Update Kenneth's committer record to include the email he
1681         uses on lists.webkit.org.
1682
1683         * Scripts/modules/committers.py:
1684
1685 2009-11-11  Eric Seidel  <eric@webkit.org>
1686
1687         Reviewed by Gustavo Noronha Silva.
1688
1689         Several committers use separate email addresses for bugzilla and svn.webkit.org
1690         https://bugs.webkit.org/show_bug.cgi?id=31364
1691
1692         Update records for existing committers to include email addresses
1693         used in svn.webkit.org and lists.webkit.org.
1694         Most committers use the same email address in all 3 places, but some use
1695         separate addresses.  committers.py needs record of each of these addresses.
1696
1697         * Scripts/modules/committers.py:
1698
1699 2009-11-11  Eric Seidel  <eric@webkit.org>
1700
1701         No review, adding second email address for an existing committer.
1702
1703         Add Yong Li's second bugzilla account to his committer record.
1704         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1705
1706         * Scripts/modules/committers.py:
1707
1708 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1709
1710         Reviewed by Simon Hausmann.
1711
1712         If the frame has no innerText don't append it, and
1713         do not add a newline which breaks some cross platform
1714         results.
1715
1716         * DumpRenderTree/qt/DumpRenderTree.cpp:
1717         (WebCore::DumpRenderTree::dumpFramesAsText):
1718
1719 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1720
1721         Reviewed by Simon Hausmann.
1722
1723         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1724
1725         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1726         (webkit_test_plugin_new_instance):
1727         (webkit_test_plugin_destroy_instance):
1728         (webkit_test_plugin_destroy_stream):
1729
1730 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1731
1732         Reviewed by Mark Rowe.
1733
1734         Implement the functionality needed by plugins/window-open.html
1735
1736         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1737         (webkit_test_plugin_new_instance):
1738         (webkit_test_plugin_set_window):
1739
1740 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1741
1742         Reviewed by Simon Hausmann.
1743
1744         [Qt] Force -graphicssystem raster and -style windows when running DRT
1745
1746         * DumpRenderTree/qt/main.cpp:
1747         * Scripts/run-webkit-tests:
1748
1749 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1750
1751         Reviewed by Simon Hausmann.
1752
1753         Compute correct library paths for Qt
1754
1755         * Scripts/webkitdirs.pm:
1756
1757 2009-11-10  Mark Rowe  <mrowe@apple.com>
1758
1759         Reviewed by Sam Weinig.
1760
1761         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1762
1763         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1764         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1765         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1766         that had enabled frame load delegate logging this would result in extra log messages being generated,
1767         causing the test to fail.
1768
1769         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1770         tests.
1771
1772         * DumpRenderTree/mac/DumpRenderTree.mm:
1773         (dumpRenderTree):
1774         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1775         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1776
1777 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1778
1779         Reviewed by Kenneth Rohde Christiansen.
1780
1781         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1782
1783         * DumpRenderTree/qt/DumpRenderTree.cpp:
1784         (WebCore::DumpRenderTree::DumpRenderTree):
1785
1786 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1787
1788         Reviewed by Jan Alonzo.
1789
1790         [GTK] Remove WebSocket configuration from WebKitWebSettings
1791         https://bugs.webkit.org/show_bug.cgi?id=31244
1792
1793         Follow-up of r50724. Don't set the enable-web-socket property
1794         anymore.
1795
1796         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1797         (resetDefaultsToConsistentValues):
1798
1799 2009-11-10  Oliver Hunt  <oliver@apple.com>
1800
1801         Reviewed by Maciej Stachowiak.
1802
1803         Rename 3D Canvas related classes to use WebGL prefix
1804         https://bugs.webkit.org/show_bug.cgi?id=29095
1805
1806         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1807         and upate webkitdirs script to new method of testing for WebGL.
1808
1809         * Scripts/do-webcore-rename:
1810         * Scripts/webkitdirs.pm:
1811
1812 2009-11-09  Oliver Hunt  <oliver@apple.com>
1813
1814         Reviewed by Geoff Garen.
1815
1816         Make do-webcore-rename work with git.
1817
1818         * Scripts/do-webcore-rename:
1819
1820 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1821
1822         Adding Kenneth to the reviewers list.
1823
1824         * Scripts/modules/committers.py:
1825
1826 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1827
1828         Reviewed by Jan Alonzo.
1829
1830         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1831         https://bugs.webkit.org/show_bug.cgi?id=30482
1832
1833         LayoutTestControllerGtk now uses the exposed
1834         Page::tabKeyCyclesThroughElements API
1835
1836         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1837         (LayoutTestController::setTabKeyCyclesThroughElements):
1838
1839 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1840
1841         Reviewed by Holger Freyther.
1842
1843         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1844         This helps to pass the test case below. Also replaced hardcoded
1845         code numbers with defined constants.
1846         https://bugs.webkit.org/show_bug.cgi?id=31185
1847         
1848         Test: editing/undo/undo-deleteWord.html
1849
1850         * DumpRenderTree/qt/EventSenderQt.cpp:
1851         (EventSender::keyDown):
1852
1853 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1854
1855         Reviewed by Holger Freyther.
1856
1857         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1858         https://bugs.webkit.org/show_bug.cgi?id=31164
1859
1860         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1861
1862         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1863         (LayoutTestController::processWork):
1864
1865 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1866
1867         Reviewed by Holger Freyther.
1868
1869         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1870         https://bugs.webkit.org/show_bug.cgi?id=31158
1871
1872         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1873         always, which from WorkQueue prospective means that a load has been started
1874         and the queue processing should stop and wait for the load to finish.
1875         Spinning it off into a loading and a non-loading variants was the solution
1876         adopted by Mac's DRT to work around this problem. The former keeps returning
1877         'true' while the later executes the script synchronously and returns 'false'
1878         making it possible to the WorkQueue to proceed right away.
1879
1880         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1881         (LayoutTestController::processWork):
1882         (LayoutTestController::queueLoadingScript):
1883         (LayoutTestController::queueNonLoadingScript):
1884         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1885         * DumpRenderTree/qt/WorkQueueItem.h:
1886         (LoadingScriptItem::LoadingScriptItem):
1887         (LoadingScriptItem::invoke):
1888         (NonLoadingScriptItem::NonLoadingScriptItem):
1889         (NonLoadingScriptItem::invoke):
1890
1891 2009-11-07  Mark Rowe  <mrowe@apple.com>
1892
1893         Rubber-stamped by Cameron Zwarich.
1894
1895         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1896
1897         * Scripts/commit-log-editor:
1898
1899 2009-11-07  Mark Rowe  <mrowe@apple.com>
1900
1901         Reviewed by Darin Adler.
1902
1903         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1904         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1905
1906         Move logic for determining the name and email address to use in a ChangeLog entry from
1907         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1908         whether the author of the patch matches committer, and therefore needs access to the
1909         email address that would be used in a ChangeLog entry.
1910
1911         Based on a patch by Pierre d'Herbemont.
1912
1913         * Scripts/VCSUtils.pm:
1914         * Scripts/commit-log-editor:
1915         * Scripts/prepare-ChangeLog:
1916         * Scripts/webkitdirs.pm:
1917
1918 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1919
1920         Reviewed by Adam Barth.
1921
1922         Added functionality to the layout test plugin to invoke document.open and
1923         window.open with default arguments. The associated webkit bug is
1924         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1925         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1926         work in Chromium (V8) if there is no calling javascript context. To achieve this
1927         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1928         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1929
1930         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1931         (testDocumentOpen):
1932         (testWindowOpen):
1933         (pluginAllocate):
1934         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1935         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1936         (NPP_New):
1937         (NPP_SetWindow):
1938         (NPP_DestroyStream):
1939         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1940         (NPP_New):
1941         (NPP_SetWindow):
1942         (NPP_NewStream):
1943         (NPP_DestroyStream):
1944
1945 2009-11-06  Eric Seidel  <eric@webkit.org>
1946
1947         Reviewed by Adam Barth.
1948
1949         bugzilla-tool crashed with exception
1950         https://bugs.webkit.org/show_bug.cgi?id=31092
1951
1952         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1953
1954 2009-11-04  Eric Seidel  <eric@webkit.org>
1955
1956         No review, just add a line which got left out of the patch uploaded for commit.
1957
1958         commit-queue is crashing when trying to reject patches after unknown failures
1959         https://bugs.webkit.org/show_bug.cgi?id=31091
1960
1961         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1962
1963 2009-11-04  Adam Roben  <aroben@apple.com>
1964
1965         Remove bogus else clause in bugzilla-tool
1966
1967         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1968         create-bug raises exception after entering bug description
1969
1970         Reviewed by David Kilzer.
1971
1972         * Scripts/bugzilla-tool:
1973         (CreateBug): else clauses are only hit if no exception is raised, so
1974         it makes no sense to try to re-raise the exception in an else clause.
1975         The exception will automatically be re-raised if it doesn't match any
1976         of the except clauses, so we don't have to do anything special here at
1977         all to get the desired behavior.
1978
1979 2009-11-04  Eric Seidel  <eric@webkit.org>
1980
1981         Reviewed by David Kilzer.
1982
1983         svn-apply's fixChangeLogPatch function seems broken
1984         https://bugs.webkit.org/show_bug.cgi?id=30683
1985
1986         Update fixChangeLogPatch to be able to handle patches which
1987         don't start at line 1.
1988         Add unit tests for svn-apply to scm_unittest.py.
1989
1990         * Scripts/VCSUtils.pm:
1991         * Scripts/modules/scm_unittest.py:
1992
1993 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1994
1995         Reviewed by Beth Dakin.
1996
1997         Need to implement ARIA role="combobox"
1998         https://bugs.webkit.org/show_bug.cgi?id=31096
1999
2000         * DumpRenderTree/AccessibilityUIElement.cpp:
2001         (showMenuCallback):
2002         (getIsExpandedCallback):
2003         (AccessibilityUIElement::getJSClass):
2004         * DumpRenderTree/AccessibilityUIElement.h:
2005         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2006         (AccessibilityUIElement::isExpanded):
2007         (AccessibilityUIElement::showMenu):
2008         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2009         (AccessibilityUIElement::isExpanded):
2010         (AccessibilityUIElement::showMenu):
2011         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2012         (AccessibilityUIElement::isSelected):
2013         (AccessibilityUIElement::isExpanded):
2014         (AccessibilityUIElement::showMenu):
2015
2016 2009-11-04  Eric Seidel  <eric@webkit.org>
2017
2018         Reviewed by Adam Barth.
2019
2020         commit-queue is crashing when trying to reject patches after unknown failures
2021         https://bugs.webkit.org/show_bug.cgi?id=31091
2022
2023         * Scripts/bugzilla-tool:
2024          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
2025            so we have to find out what the current patch is by asking bugzilla again.
2026          - Discovered that this code was also leaking file descriptors, so fixed that.
2027
2028 2009-11-04  Adam Roben  <aroben@apple.com>
2029
2030         Make run-webkit-tests work for the Debug_Internal Windows
2031         configuration
2032
2033         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2034         suffix.
2035
2036         Fixes <http://webkit.org/b/31123>.
2037
2038         Reviewed by Sam Weinig.
2039
2040         * Scripts/run-webkit-tests: Don't add the _debug suffix in
2041         Debug_Internal, either.
2042
2043 2009-11-04  Eric Seidel  <eric@webkit.org>
2044
2045         Reviewed by Adam Barth.
2046
2047         committers.py needs a way to store non-bugzilla email addresses
2048         https://bugs.webkit.org/show_bug.cgi?id=31037
2049
2050         Make Committer and Reviewer constructors take a single email or a list of emails.
2051         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2052         Expose reviewers(), used by validate-committer-lists on bug 30970.
2053
2054         * Scripts/modules/committers.py:
2055         * Scripts/modules/committers_unittest.py: Added tests for the new code.
2056
2057 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2058
2059         Reviewed by David Levin.
2060
2061         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2062         https://bugs.webkit.org/show_bug.cgi?id=27491
2063
2064         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2065         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2066
2067         Functions to start or stop Web Socket servers are added.
2068
2069         * Scripts/run-webkit-tests:
2070
2071 2009-11-03  Eric Seidel  <eric@webkit.org>
2072
2073         No review, just changing wording of log message.
2074
2075         Change log string to say "failed" instead of "rejected"
2076         when a commit fails due to an out of date checkout.
2077         This makes grepping the commit-queue log for rejected patches easier.
2078
2079         * Scripts/bugzilla-tool:
2080
2081 2009-11-03  Eric Seidel  <eric@webkit.org>
2082
2083         No review, adding commonly known committers missing from the file.
2084
2085         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2086
2087 2009-11-03  Eric Seidel  <eric@webkit.org>
2088
2089         No review, just sort-order cleanup.
2090
2091         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2092
2093 2009-11-03  Stephen White  <senorblanco@chromium.org>
2094
2095         (Unreviewed).
2096
2097         Add myself to committers.py.
2098
2099         * Scripts/modules/committers.py:
2100
2101 2009-11-03  Robin Dunn  <robin@alldunn.com>
2102
2103         Reviewed by Kevin Ollviier.
2104
2105         Add packaging scripts for Debian-based Linux distros.
2106         
2107         https://bugs.webkit.org/show_bug.cgi?id=31075
2108
2109         * wx/packaging/build-debian-installer.py: Added.
2110         * wx/packaging/debian: Added.
2111
2112 2009-11-03  Dan Bernstein  <mitz@apple.com>
2113
2114         Reviewed by Anders Carlsson and Beth Dakin.
2115
2116         https://bugs.webkit.org/show_bug.cgi?id=31070
2117
2118         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2119         destroyed, it executes the value of the 'ondestroy' parameter as a
2120         script.
2121
2122         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2123         (pluginAllocate): Initialize onDestroy.
2124         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2125         onDestroy.
2126         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2127         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2128         specified.
2129         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2130
2131 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2132
2133         Reviewed by Xan Lopez.
2134
2135         https://bugs.webkit.org/show_bug.cgi?id=31035
2136         [GTK] some accessibility tests hitting assertion in debug builds
2137
2138         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2139
2140         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2141         (AccessibilityController::rootElement):
2142
2143 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2144
2145         Reviewed by Beth Dakin.
2146
2147         Support ARIA "tab" roles
2148         https://bugs.webkit.org/show_bug.cgi?id=30842
2149
2150         * DumpRenderTree/AccessibilityUIElement.cpp:
2151         * DumpRenderTree/AccessibilityUIElement.h:
2152         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2153         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2154         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2155
2156 2009-11-01  Eric Seidel  <eric@webkit.org>
2157
2158         Reviewed by David Levin.
2159
2160         buildbots should use --exit-after-N-failures
2161         https://bugs.webkit.org/show_bug.cgi?id=30809
2162
2163         Make the bots exit after 20 failures to prevent never-ending
2164         test runs where every test spends a minute crashing.
2165
2166         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2167
2168 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2169
2170         Reviewed by Eric Seidel.
2171
2172         Turn on warnings for QtWebKit for gcc
2173         https://bugs.webkit.org/show_bug.cgi?id=30958
2174
2175         * DumpRenderTree/qt/main.cpp: 
2176         (crashHandler): Mark function NO_RETURN
2177
2178 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2179
2180         Adding myself to the committers list.
2181
2182         * Scripts/modules/committers.py:
2183
2184 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2185
2186         Fix an issue that Adam noticed in DRT.
2187
2188         Reviewed by Darin Adler.
2189
2190         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2191         (AccessibilityUIElement::role):
2192         Get the length of the role text, and create a buffer dynamically.
2193
2194 2009-10-30  Eric Seidel  <eric@webkit.org>
2195
2196         No review, rolling out r50105.
2197         http://trac.webkit.org/changeset/50105
2198
2199         This commit was causing:
2200         https://bugs.webkit.org/show_bug.cgi?id=30869
2201         We'll re-implement the feature a different way.
2202
2203         * Scripts/bugzilla-tool:
2204
2205 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2206
2207         Test for MSAA: Accessibility of headings is not correct
2208
2209         https://bugs.webkit.org/show_bug.cgi?id=30937
2210
2211         Reviewed by Adam Roben.
2212
2213         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2214         (AccessibilityUIElement::role):
2215         Allow the role returned to be a BSTR.
2216         (AccessibilityUIElement::description):
2217         Fix a copy/paste error.
2218
2219 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2220
2221         Test for MSAA: Accessibility of links is wrong
2222
2223         https://bugs.webkit.org/show_bug.cgi?id=30928
2224
2225         Reviewed by Darin Adler.
2226
2227         * DumpRenderTree/AccessibilityUIElement.cpp:
2228         (getAccessibilityValueCallback):
2229         Return the accessibility value.
2230         (AccessibilityUIElement::getJSClass):
2231         Added "accessibilityValue" value.
2232
2233         * DumpRenderTree/AccessibilityUIElement.h:
2234
2235         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2236         (AccessibilityUIElement::accessibilityValue):
2237         Stubbed.
2238
2239         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2240         (AccessibilityUIElement::accessibilityValue):
2241         Stubbed.
2242
2243         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2244         (AccessibilityUIElement::accessibilityValue):
2245         Get the object's value, and return it as a JS string.
2246
2247 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2248
2249         Fix typo in command name used by wx build system.
2250
2251         * wx/build/build_utils.py:
2252
2253 2009-10-30  Adam Barth  <abarth@webkit.org>
2254
2255         Reviewed by Darin Adler.
2256
2257         Patch v1 is a dumb default name for patches
2258         https://bugs.webkit.org/show_bug.cgi?id=30952
2259
2260         Let's use "Patch" instead.
2261
2262         * Scripts/bugzilla-tool:
2263
2264 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2265
2266         Unreviewed trivial buildfix.
2267
2268         [Qt] Buildfix for r50333.
2269
2270         * DumpRenderTree/qt/DumpRenderTree.pro:
2271
2272 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2273
2274         Reviewed by Holger Freyther.
2275
2276         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2277         https://bugs.webkit.org/show_bug.cgi?id=30953
2278
2279         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2280         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2281         makes qt DRT to share this implementation (as gtk and mac ports do).
2282
2283         * DumpRenderTree/qt/DumpRenderTree.pro:
2284         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2285         * DumpRenderTree/qt/WorkQueue.h: Removed.
2286
2287 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2288
2289         Unreviewed potential buildbot fix.
2290
2291         Second try: Reset page history before running each test.
2292
2293         Apparently the QWebHistory::clear() keeps the current page
2294         in history which is not what we want, so we not additionally
2295         sets the history capacity to 0 (forces removing everything)
2296         and then sets it back to its original value.
2297
2298         * DumpRenderTree/qt/DumpRenderTree.cpp:
2299         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2300
2301 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2302
2303         Unreviewed potential buildbot fix.
2304
2305         Reset page history before running each test.
2306
2307         * DumpRenderTree/qt/DumpRenderTree.cpp:
2308         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2309
2310 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2311
2312         Reviewed by Eric Seidel.
2313
2314         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2315
2316         Bug 28420 -  Implement HTML5 <ruby> rendering
2317         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2318
2319         No new tests (no functional change).
2320
2321         * Scripts/build-webkit:
2322
2323 2009-10-29  Dan Bernstein  <mitz@apple.com>
2324
2325         Reviewed by Mark Rowe.
2326
2327         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2328         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2329         define it.
2330
2331         * Scripts/VCSUtils.pm:
2332         * Scripts/svn-apply:
2333         * Scripts/svn-unapply:
2334
2335 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2336
2337         Reviewed by Gustavo Noronha.
2338
2339         Use the GTK+ main loop instead of rolling our own mini-version of
2340         it.
2341
2342         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2343         (dump):
2344         (runTest):
2345         (webViewLoadFinished):
2346
2347 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2348
2349         Reviewed by Oliver Hunt.
2350
2351         Implement the Qt version of DRT dumpBackForwardList().
2352
2353         * DumpRenderTree/qt/DumpRenderTree.cpp:
2354         (WebCore::dumpHistoryItem):
2355         (WebCore::DumpRenderTree::dumpBackForwardList):
2356
2357 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2358
2359         Reviewed by Adam Roben.
2360
2361         Implement DRT functionality for Qt introduced in
2362         r28690 and r28705.
2363
2364         - Implemented pathToLocalResource which exposes the functionality of
2365         converting a given unix path to the correct location on Windows.
2366         - Implemented a way to remove machine-dependent information from paths
2367         in layout test results.
2368
2369         * DumpRenderTree/qt/DumpRenderTree.cpp:
2370         (WebCore::urlSuitableForTestResult):
2371         (WebCore::WebPage::javaScriptConsoleMessage):
2372         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2373         (LayoutTestController::pathToLocalResource):
2374         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2375
2376 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2377
2378         Adding myself to the committers list.
2379
2380         * Scripts/modules/committers.py:
2381
2382 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2383
2384         Adding myself to the committers list.
2385
2386         * Scripts/modules/committers.py:
2387
2388 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2389
2390         Reviewed by Jan Alonzo.
2391
2392         [GTK] API to start inspector for a WebView
2393         https://bugs.webkit.org/show_bug.cgi?id=22551
2394
2395         Use the new inspector API to implement the LayoutTestController
2396         interfaces used to test the inspector.
2397
2398         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2399         (webInspectorInspectWebView):
2400         (createWebView):
2401         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2402         (LayoutTestController::showWebInspector):
2403         (LayoutTestController::closeWebInspector):
2404         (LayoutTestController::evaluateInWebInspector):
2405
2406 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2407
2408         Reviewed by Eric Seidel.
2409
2410         [Qt] WebFrame::counterValueForElementById must not be exposed
2411         https://bugs.webkit.org/show_bug.cgi?id=30882
2412
2413         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2414         (LayoutTestController::counterValueForElementById):
2415
2416 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2417
2418         Rubberstamped by Oliver Hunt.
2419
2420         Fix the warning:
2421
2422         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2423         declared with attribute warn_unused_result".
2424
2425         by actually checking the result. In the case it is null, an
2426         error has occoured, so treat it as the other fatal errors.
2427
2428         * DumpRenderTree/qt/DumpRenderTree.cpp:
2429         (WebCore::DumpRenderTree::initializeFonts):
2430
2431 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2432
2433         Reviewed by Darin Adler.
2434
2435         Provide a way to get counter values with layoutTestContoller
2436         https://bugs.webkit.org/show_bug.cgi?id=30555
2437
2438         Define layoutTestContoller.counterValueForElementById.
2439
2440         * DumpRenderTree/LayoutTestController.cpp:
2441         (counterValueForElementByIdCallback):
2442         (LayoutTestController::staticFunctions):
2443         * DumpRenderTree/LayoutTestController.h:
2444         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2445         (LayoutTestController::counterValueForElementById):
2446
2447 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2448
2449         Rubberstamped by Oliver Hunt.
2450
2451         Change two methods to be internal for DRT use only.
2452
2453         Part of [Qt] Review all new API in Qt 4.6
2454         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2455
2456         * DumpRenderTree/qt/DumpRenderTree.cpp:
2457         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2458         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2459         (LayoutTestController::whiteListAccessFromOrigin):
2460
2461 2009-10-27  Eric Seidel  <eric@webkit.org>
2462
2463         Reviewed by Adam Barth.
2464
2465         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2466         https://bugs.webkit.org/show_bug.cgi?id=30826
2467
2468         * Scripts/svn-apply:
2469          - Add () around all system() calls.
2470          - Use the correct system() == 0 or die instead of system() or die
2471          - Add descriptive messages to all die statements.
2472
2473 2009-10-27  Steve Block  <steveblock@google.com>
2474
2475         Reviewed by NOBODY.
2476
2477         Adds steveblock@google.com to list of committers.
2478
2479         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2480
2481 2009-10-27  Eric Seidel  <eric@webkit.org>
2482
2483         Reviewed by Adam Barth.
2484
2485         svn-apply can exit(0) even on patch failure
2486         https://bugs.webkit.org/show_bug.cgi?id=29622
2487
2488         * Scripts/svn-apply:
2489          - Add a bunch of "or die" statements, hopefully catching all
2490            possible cases where failure could still exit(0).
2491
2492 2009-10-27  Eric Seidel  <eric@webkit.org>
2493
2494         Reviewed by Adam Barth.
2495
2496         svn-* scripts should share code through VCSUtils.pm
2497         https://bugs.webkit.org/show_bug.cgi?id=30791
2498
2499         Just moving code into a shared location.
2500
2501         * Scripts/VCSUtils.pm:
2502         * Scripts/prepare-ChangeLog:
2503         * Scripts/resolve-ChangeLogs:
2504         * Scripts/svn-apply:
2505         * Scripts/svn-create-patch:
2506         * Scripts/svn-unapply:
2507         * Scripts/update-webkit:
2508
2509 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2510
2511         Suppress a huge number of MSVC warnings when building wxWebKit.
2512
2513         * wx/build/settings.py:
2514
2515 2009-10-26  Eric Seidel  <eric@webkit.org>
2516
2517         No review, just adding Mike Belshe to the committers list.
2518
2519         * Scripts/modules/committers.py:
2520
2521 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2522
2523         Reviewed by Darin Adler.
2524
2525         Make .rc files compile on Windows without depending on MFC headers
2526         https://bugs.webkit.org/show_bug.cgi?id=30750
2527
2528         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2529         windows.h instead of afxres.h because it exists even when MFC is not 
2530         installed, and is all that's needed here.
2531
2532         * FindSafari/FindSafari.rc: Ditto
2533
2534 2009-10-24  Eric Seidel  <eric@webkit.org>
2535
2536         Reviewed by Adam Barth.
2537
2538         bugzilla-tool post-diff should know how to mark commit-queue=?
2539         https://bugs.webkit.org/show_bug.cgi?id=29202
2540
2541         * Scripts/bugzilla-tool:
2542          - Add --commit-queue option to post-diff, post-commits and create-bug.
2543         * Scripts/modules/bugzilla.py:
2544          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2545          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2546
2547 2009-10-23  Eric Seidel  <eric@webkit.org>
2548
2549         Reviewed by Adam Barth.
2550
2551         bugzilla-tool commit-queue does not notice modifications to committers.py
2552         https://bugs.webkit.org/show_bug.cgi?id=30084
2553
2554         * Scripts/bugzilla-tool:
2555          - Make commit-queue re-exec itself instead of using while(1).
2556          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2557          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2558
2559 2009-10-22  Eric Seidel  <eric@webkit.org>
2560
2561         Reviewed by Adam Barth.
2562
2563         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2564         https://bugs.webkit.org/show_bug.cgi?id=30634
2565
2566         * Scripts/bugzilla-tool:
2567          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2568          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2569
2570 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2571
2572         Reviewed by Eric Seidel.
2573
2574         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2575
2576         https://bugs.webkit.org/show_bug.cgi?id=30763
2577
2578         * pywebsocket/mod_pywebsocket/__init__.py:
2579         * pywebsocket/mod_pywebsocket/dispatch.py:
2580         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2581         * pywebsocket/mod_pywebsocket/standalone.py:
2582         * pywebsocket/setup.py:
2583         * pywebsocket/test/test_dispatch.py:
2584
2585 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2586
2587         Reviewed by David Levin.
2588
2589         REGRESSION: 2 failures in run-webkit-unittests
2590         https://bugs.webkit.org/show_bug.cgi?id=30645
2591
2592         * Scripts/modules/cpp_style_unittest.py:
2593         Fixed a few test scenarios which apparently lost some spaces from 
2594         text literals.
2595
2596 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2597
2598         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2599
2600         * Scripts/webkitdirs.pm:
2601
2602 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2603
2604         Reviewed by Darin Adler.
2605
2606         Unification of using null device in perl scripts.
2607         https://bugs.webkit.org/show_bug.cgi?id=30572
2608
2609         * Scripts/VCSUtils.pm:
2610         * Scripts/bisect-builds:
2611         * Scripts/resolve-ChangeLogs:
2612         * Scripts/run-iexploder-tests:
2613         * Scripts/run-jsc:
2614         * Scripts/run-mangleme-tests:
2615         * Scripts/run-webkit-tests:
2616         * Scripts/webkitdirs.pm:
2617         Using File::Spec->devnull() instead of hard coded /dev/null.
2618
2619 2009-10-26  Eric Seidel  <eric@webkit.org>
2620
2621         Reviewed by Holger Freyther.
2622
2623         Reviewers are missing from committers.py
2624         https://bugs.webkit.org/show_bug.cgi?id=30733
2625
2626         * Scripts/modules/committers.py:
2627
2628 2009-10-23  Eric Seidel  <eric@webkit.org>
2629
2630         No review, only adding Alice to the list of reviewers.
2631
2632         * Scripts/modules/committers.py:
2633
2634 2009-10-23  Eric Seidel  <eric@webkit.org>
2635
2636         Reviewed by Eric Carlson.
2637
2638         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2639         https://bugs.webkit.org/show_bug.cgi?id=30700
2640
2641         * DumpRenderTree/mac/DumpRenderTree.mm:
2642         (resetDefaultsToConsistentValues): Update QuickTime version check.
2643
2644 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2645
2646         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2647         character measurement APIs that are private on Tiger.
2648
2649         * wx/build/settings.py:
2650
2651 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2652
2653         Reviewed by NOBODY (build fix).
2654         Build fix following bug #30696.
2655
2656         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2657         (LayoutTestController::evaluateScriptInIsolatedWorld):
2658
2659 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2660
2661         Reviewed by Sam Weinig & Geoff Garen.
2662
2663         https://bugs.webkit.org/show_bug.cgi?id=30696
2664         Enable isolated-worlds tests on mac.
2665
2666         Add private interface for DRT to invoke execution in a given world.
2667
2668         * DumpRenderTree/LayoutTestController.cpp:
2669         (evaluateScriptInIsolatedWorldCallback):
2670         (LayoutTestController::staticFunctions):
2671         * DumpRenderTree/LayoutTestController.h:
2672         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2673         (LayoutTestController::evaluateScriptInIsolatedWorld):
2674         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2675         (LayoutTestController::evaluateScriptInIsolatedWorld):
2676
2677 2009-10-21  Eric Seidel  <eric@webkit.org>
2678
2679         Reviewed by Adam Barth.
2680
2681         bugzilla-tool's "patch failed to download an apply" error should give more information
2682         https://bugs.webkit.org/show_bug.cgi?id=30632
2683
2684         * Scripts/modules/scm.py:
2685          - Use the common run_command method instead of custom POpen code.
2686          - Make run_command know how to take pipes as input.
2687         * Scripts/modules/scm_unittest.py:
2688          - Add new tests to cover change.
2689          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2690
2691 2009-10-21  Kent Tamura  <tkent@chromium.org>
2692
2693         Unreviewed.  Adding myself to the committers list.
2694
2695         * Scripts/modules/committers.py:
2696
2697 2009-10-21  Robin Dunn  <robin@alldunn.com>
2698
2699         Reviewed by Kevin Ollivier.
2700
2701         Update the Windows installer builder to work with Vista / Win 7 and with git.
2702         
2703         https://bugs.webkit.org/show_bug.cgi?id=30649
2704
2705         * wx/build/build_utils.py:
2706         * wx/packaging/build-mac-installer.py:
2707         * wx/packaging/build-win-installer.py:
2708         * wx/packaging/wxWebKitInstaller.iss.in:
2709
2710 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2711
2712         Reviewed by Gustavo Noronha.
2713
2714         [GTK] Added conditional code to avoid using
2715         gdk_window_get_root_coords if we do not have a gtk+ release newer
2716         than 2.17.3.
2717         https://bugs.webkit.org/show_bug.cgi?id=30636
2718
2719         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2720
2721 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2722
2723         Reviewed by Eric Seidel.
2724
2725         [Qt] Added dummy implementation for keepWebHistory()
2726         https://bugs.webkit.org/show_bug.cgi?id=30592
2727
2728         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2729         (LayoutTestController::keepWebHistory):
2730         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2731
2732 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2733
2734         Reviewed by Xan Lopez.
2735
2736         [GTK] Fixed the double click condition, it is not double click if
2737         we move in just in one direction.
2738         https://bugs.webkit.org/show_bug.cgi?id=30636
2739
2740         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2741
2742 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2743
2744         Reviewed by Xan Lopez.
2745
2746         [GTK] Initialize the events completly before emitting them.
2747         https://bugs.webkit.org/show_bug.cgi?id=30633
2748
2749         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2750
2751 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2752
2753         wx build fix. Fix for when linking using --as-needed with gcc.
2754
2755         * wx/browser/wscript:
2756
2757 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2758
2759         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2760         to support all the features used by CURL backend.
2761         
2762         * wx/build/settings.py:
2763         * wx/install-unix-extras:
2764
2765 2009-10-20  Anton Muhin  <antonm@chromium.org>
2766
2767         Reviewed by Adam Barth.
2768
2769         Add {ager,antonm,yurys}@chromium.org into committers.py
2770         https://bugs.webkit.org/show_bug.cgi?id=30560
2771
2772         * Scripts/modules/committers.py:
2773
2774 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2775
2776         Reviewed by Tor Arne Vestbø.
2777
2778         Make the Netscape Test plugin available to the Qt launcher.
2779
2780         * Scripts/run-launcher:
2781
2782 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2783
2784         Reviewed by David Levin.
2785
2786         Removed WebSocket runtime settings.
2787         https://bugs.webkit.org/show_bug.cgi?id=29896
2788
2789         WebSocket runtime configuration is supported by chromium/v8 only.
2790
2791         * DumpRenderTree/mac/DumpRenderTree.mm:
2792         (resetDefaultsToConsistentValues):
2793         * DumpRenderTree/win/DumpRenderTree.cpp:
2794         (resetDefaultsToConsistentValues):
2795
2796 2009-10-19  Nate Chapin  <japhet@chromium.org>
2797
2798         Reviewed by Adam Barth.
2799
2800         Add testFail() to test plugin so we can test our handling of a
2801         plugin invoke call returning false.
2802
2803         https://bugs.webkit.org/show_bug.cgi?id=30239
2804
2805         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2806         (pluginInvoke):
2807         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2808
2809 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2810
2811         Reviewed by Gustavo Noronha.
2812
2813         Enable DOM pasting when running layout tests.
2814
2815         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2816         (resetDefaultsToConsistentValues):
2817
2818 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2819
2820         Reviewed by Simon Hausmann.
2821
2822         Use the setPreferredContentsSize method instead
2823         of setFixedContentsSize, as the method has been renamed.
2824
2825         * DumpRenderTree/qt/DumpRenderTree.cpp:
2826         (WebCore::DumpRenderTree::open):
2827         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2828         (LayoutTestController::setFixedContentsSize):
2829
2830 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2831
2832         Reviewed by Dan Bernstein.
2833
2834         https://bugs.webkit.org/show_bug.cgi?id=30456
2835         Fixes for new Debug_All Windows build configuration.
2836
2837         * DumpRenderTree/win/DumpRenderTree.cpp:
2838         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2839         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2840
2841 2009-10-16  Eric Seidel  <eric@webkit.org>
2842
2843         Reviewed by Adam Barth.
2844
2845         commit-queue status bot should list which buildbot is blocking the queue
2846         https://bugs.webkit.org/show_bug.cgi?id=30452
2847
2848         Add new methods and testing.
2849
2850         * Scripts/bugzilla-tool:
2851         * Scripts/modules/buildbot.py:
2852         * Scripts/modules/buildbot_unittest.py:
2853
2854 2009-10-16  Eric Seidel  <eric@webkit.org>
2855
2856         Reviewed by Adam Barth.
2857
2858         run-webkit-tests fails when CWD is not inside a WebKit checkout
2859         https://bugs.webkit.org/show_bug.cgi?id=30451
2860
2861         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2862         * Scripts/modules/scm_unittest.py:
2863           - Remove use of original_path (we don't need to restore the CWD).
2864           - Don't use '.' to find the webkit checkout, use __file__ instead.
2865
2866 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2867
2868         Reviewed by Adam Roben.
2869
2870         Add a Debug_All configuration to build entire stack as debug.
2871         Change Debug_Internal to:
2872         - stop using _debug suffix for all WebKit/Safari binaries
2873         - not use _debug as a DLL naming suffix
2874         - use non-debug C runtime lib.
2875
2876         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2877         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2878         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2879         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2880         Add missing debug.vsprops inherited property sheet.
2881         Add Debug_All configuration.
2882         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2883         * WinLauncher/WinLauncher.vcproj:
2884         Removed extraneous definitions inherited from vsprops.
2885         Add Debug_All configuration.
2886
2887 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2888
2889         Reviewed by David Levin.
2890
2891         check-webkit-style is wrong about indent checking in namespaces
2892         in header files and a few other things
2893         https://bugs.webkit.org/show_bug.cgi?id=30362
2894
2895         The few other things include:
2896         + check-webkit-style does not require spaces around the equal sign
2897           inside 'if' statements and around binary operators that take 
2898           numeric literals.
2899         + check-webkit-style reports false errors for the / operator
2900           when part of a filename in the #include directive.
2901
2902         * Scripts/modules/cpp_style.py:
2903         Improved indentation checking and space checking around
2904         binary operators. While the checks are still not perfect,
2905         they are clearly better than before.
2906         * Scripts/modules/cpp_style_unittest.py:
2907         Added test cases for the newly supported checks and modified old
2908         test cases to match the new guidelines
2909
2910 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2911
2912         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2913
2914         * wx/build/settings.py:
2915
2916 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2917
2918         Reviewed by David Levin.
2919
2920         Add mod_pywebsocket to test Web Sockets.
2921         http://code.google.com/p/pywebsocket/
2922         https://bugs.webkit.org/show_bug.cgi?id=27490
2923
2924         * pywebsocket/COPYING: Added.
2925         * pywebsocket/MANIFEST.in: Added.
2926         * pywebsocket/README: Added.
2927         * pywebsocket/example/echo_client.py: Added.
2928         * pywebsocket/example/echo_wsh.py: Added.
2929         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2930         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2931         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2932         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2933         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2934         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2935         * pywebsocket/mod_pywebsocket/util.py: Added.
2936         * pywebsocket/setup.py: Added.
2937         * pywebsocket/test/config.py: Added.
2938         * pywebsocket/test/mock.py: Added.
2939         * pywebsocket/test/run_all.py: Added.
2940         * pywebsocket/test/test_dispatch.py: Added.
2941         * pywebsocket/test/test_handshake.py: Added.
2942         * pywebsocket/test/test_mock.py: Added.
2943         * pywebsocket/test/test_msgutil.py: Added.
2944         * pywebsocket/test/test_util.py: Added.
2945         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2946         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2947         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2948         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2949         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2950         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2951         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2952         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2953
2954 2009-10-15  James Robinson  <jamesr@google.com>
2955
2956         Reviewed by David Levin.
2957
2958         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2959
2960         https://bugs.webkit.org/show_bug.cgi?id=30426
2961
2962         * Scripts/modules/cpp_style.py:
2963         * Scripts/modules/cpp_style_unittest.py:
2964
2965 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2966
2967         Reviewed by Adam Roben.
2968
2969         Fixes <http://webkit.org/b/30411>.
2970         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2971         
2972         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2973         building Chromium.
2974
2975         * Scripts/pdevenv:
2976
2977 2009-10-15  Robin Dunn  <robin@alldunn.com>
2978
2979         Reviewed by Kevin Ollivier.
2980
2981         Add Mac package building scripts for wx.
2982         
2983         https://bugs.webkit.org/show_bug.cgi?id=30405
2984
2985         * wx/build/build_utils.py:
2986         * wx/build/settings.py:
2987         * wx/packaging/build-mac-installer.py: Added.
2988
2989 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2990
2991         Reviewed by Gustavo Noronha.
2992
2993         Enable Web Sockets support when running layout tests.
2994
2995         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2996         (resetDefaultsToConsistentValues):
2997
2998 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2999
3000         Reviewed by Gustavo Noronha.
3001
3002         Need to initialize event.button.button, since in most cases a
3003         button number is not passed as an argument.
3004
3005         * DumpRenderTree/gtk/EventSender.cpp:
3006         (mouseDownCallback):
3007         (mouseUpCallback):
3008
3009 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
3010
3011         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3012         the OS if none was explicitly set.
3013
3014         * wx/build/settings.py:
3015
3016 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
3017
3018         Reviewed by Timothy Hatcher.
3019
3020         Web Inspector: enable developers extras within inspector layout tests.
3021
3022         https://bugs.webkit.org/show_bug.cgi?id=30014
3023
3024         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3025         (LayoutTestController::showWebInspector):
3026         (LayoutTestController::closeWebInspector):
3027         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3028         (LayoutTestController::showWebInspector):
3029         (LayoutTestController::closeWebInspector):
3030
3031 2009-10-14  José Millán Soto  <jmillan@igalia.com>
3032
3033         Reviewed by Jan Alonzo.
3034
3035         GtkLauncher is using a deprecated signal
3036         https://bugs.webkit.org/show_bug.cgi?id=30364
3037
3038         Modified GtkLauncher to use notify::title signal instead of
3039         deprecated title-changed signal
3040
3041         * GtkLauncher/main.c:
3042         (notify_title_cb):
3043         (create_browser):
3044
3045 2009-10-14  Brady Eidson  <beidson@apple.com>
3046
3047         Reviewed by Sam Weinig.
3048
3049         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
3050         1 - Disables WebHistory
3051         2 - Doesn't make sense in that context anyway.
3052
3053         * DumpRenderTree/win/DumpRenderTree.cpp:
3054         (createWebViewAndOffscreenWindow):
3055
3056 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
3057
3058         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3059         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3060
3061         * wx/build/settings.py:
3062         * wx/install-unix-extras:
3063
3064 2009-10-14  Brady Eidson  <beidson@apple.com>
3065
3066         Reviewed by Sam Weinig.
3067
3068         WebKit Win API should provide a delegate interface for global history.
3069         https://bugs.webkit.org/show_bug.cgi?id=29905
3070
3071         * DumpRenderTree/LayoutTestController.cpp:
3072         (LayoutTestController::LayoutTestController):
3073         * DumpRenderTree/LayoutTestController.h:
3074         (LayoutTestController::dumpHistoryDelegateCallbacks):
3075         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3076                 
3077         * DumpRenderTree/win/DumpRenderTree.cpp:
3078         (shouldLogHistoryDelegates):
3079         (runTest):
3080         (createWebViewAndOffscreenWindow):
3081         (main):
3082         * DumpRenderTree/win/DumpRenderTree.vcproj:
3083         
3084         Add the IWebHistoryDelegate to DRT Windows:
3085         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3086         (wstringFromBSTR):
3087         (HistoryDelegate::HistoryDelegate):
3088         (HistoryDelegate::~HistoryDelegate):
3089         (HistoryDelegate::QueryInterface):
3090         (HistoryDelegate::AddRef):
3091         (HistoryDelegate::Release):
3092         (HistoryDelegate::didNavigateWithNavigationData):
3093         (HistoryDelegate::didPerformClientRedirectFromURL):
3094         (HistoryDelegate::didPerformServerRedirectFromURL):
3095         (HistoryDelegate::updateHistoryTitle):
3096         (HistoryDelegate::populateVisitedLinksForWebView):
3097         * DumpRenderTree/win/HistoryDelegate.h: Added.
3098
3099         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3100         (LayoutTestController::removeAllVisitedLinks):
3101
3102 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3103
3104         Reviewed by Simon Hausmann.
3105
3106         [Qt] Implement support for setPOSIXLocale on Qt.
3107         https://bugs.webkit.org/show_bug.cgi?id=30268 
3108  
3109         * DumpRenderTree/qt/DumpRenderTree.cpp:
3110         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3111         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3112         (LayoutTestController::setPOSIXLocale):
3113         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3114
3115 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3116
3117         Unreviewed, adding myself to reviewers list.
3118
3119         * Scripts/modules/committers.py:
3120
3121 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3122
3123         Reviewed by Mark Rowe.
3124
3125         Fix null assignment so root tests work again.
3126
3127         * Scripts/webkitdirs.pm:
3128
3129 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3130
3131         Reviewed by Simon Hausmann.
3132
3133         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3134         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3135         This is done in preparation of implementing missing features in DRT.
3136         No functionality changes made yet.
3137
3138         * DumpRenderTree/qt/DumpRenderTree.cpp:
3139         * DumpRenderTree/qt/DumpRenderTree.pro:
3140         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3141         (EventSender::EventSender):
3142         (EventSender::mouseDown):
3143         (EventSender::mouseUp):
3144         (EventSender::mouseMoveTo):
3145         (EventSender::leapForward):
3146         (EventSender::keyDown):
3147         (EventSender::contextClick):
3148         (EventSender::scheduleAsynchronousClick):
3149         (EventSender::frameUnderMouse):
3150         * DumpRenderTree/qt/EventSenderQt.h: Added.
3151         (EventSender::clearKillRing):
3152         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3153         (LayoutTestController::LayoutTestController):
3154         (LayoutTestController::reset):
3155         (LayoutTestController::processWork):
3156         (LayoutTestController::maybeDump):
3157         (LayoutTestController::waitUntilDone):
3158         (LayoutTestController::notifyDone):
3159         (LayoutTestController::windowCount):
3160         (LayoutTestController::clearBackForwardList):
3161         (LayoutTestController::dumpEditingCallbacks):
3162         (LayoutTestController::dumpResourceLoadCallbacks):
3163         (LayoutTestController::queueBackNavigation):
3164         (LayoutTestController::queueForwardNavigation):
3165         (LayoutTestController::queueLoad):
3166         (LayoutTestController::queueReload):
3167         (LayoutTestController::queueScript):
3168         (LayoutTestController::provisionalLoad):
3169         (LayoutTestController::timerEvent):
3170         (LayoutTestController::encodeHostName):
3171         (LayoutTestController::decodeHostName):
3172         (LayoutTestController::setJavaScriptProfilingEnabled):
3173         (LayoutTestController::setFixedContentsSize):
3174         (LayoutTestController::setPrivateBrowsingEnabled):
3175         (LayoutTestController::setPopupBlockingEnabled):
3176         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3177         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3178         (LayoutTestController::numberOfActiveAnimations):
3179         (LayoutTestController::disableImageLoading):
3180         (LayoutTestController::dispatchPendingLoadRequests):
3181         (LayoutTestController::setDatabaseQuota):
3182         (LayoutTestController::clearAllDatabases):
3183         (LayoutTestController::whiteListAccessFromOrigin):
3184         (LayoutTestController::waitForPolicyDelegate):
3185         (LayoutTestController::overridePreference):
3186         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3187         (LayoutTestController::isLoading):
3188         (LayoutTestController::setLoading):
3189         (LayoutTestController::shouldDumpAsText):
3190         (LayoutTestController::shouldDumpBackForwardList):
3191         (LayoutTestController::shouldDumpChildrenAsText):
3192         (LayoutTestController::shouldDumpDatabaseCallbacks):
3193         (LayoutTestController::shouldDumpStatusCallbacks):
3194         (LayoutTestController::shouldWaitUntilDone):
3195         (LayoutTestController::canOpenWindows):
3196         (LayoutTestController::shouldDumpTitleChanges):
3197         (LayoutTestController::waitForPolicy):
3198         (LayoutTestController::dumpAsText):
3199         (LayoutTestController::dumpChildFramesAsText):
3200         (LayoutTestController::dumpDatabaseCallbacks):
3201         (LayoutTestController::dumpStatusCallbacks):
3202         (LayoutTestController::setCanOpenWindows):
3203         (LayoutTestController::dumpBackForwardList):
3204         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3205         (LayoutTestController::display):
3206         (LayoutTestController::dumpTitleChanges):
3207         (LayoutTestController::dumpSelectionRect):
3208         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3209         (TextInputController::TextInputController):
3210         (TextInputController::doCommand):
3211         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3212         * DumpRenderTree/qt/WorkQueue.cpp:
3213         * DumpRenderTree/qt/WorkQueue.h:
3214         * DumpRenderTree/qt/WorkQueueItem.h:
3215         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3216         (findFrameNamed):
3217         (LoadItem::invoke):
3218         (ReloadItem::invoke):
3219         (ScriptItem::invoke):
3220         (BackForwardItem::invoke):
3221         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3222         * DumpRenderTree/qt/jsobjects.h:
3223
3224 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3225
3226         Not reviewed, adding myself to the list of reviewers.
3227
3228         * Scripts/modules/committers.py:
3229
3230 2009-10-13  Anders Carlsson  <andersca@apple.com>
3231
3232         Reviewed by Sam Weinig.
3233
3234         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3235
3236         Make the private browsing mode testable by the test plug-in.
3237         
3238         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3239         (pluginGetProperty):
3240         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3241         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3242         (NPP_New):
3243         (NPP_SetValue):
3244
3245 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3246
3247         No review, just adding self to the list of reviewers.
3248
3249         * Scripts/modules/committers.py:
3250
3251 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3252
3253         Reviewed by Adam Roben.
3254
3255         Web Inspector: Use proper web view in inspector layout
3256         tests for windows.
3257
3258         https://bugs.webkit.org/show_bug.cgi?id=30298
3259
3260         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3261         (LayoutTestController::showWebInspector):
3262         (LayoutTestController::closeWebInspector):
3263         (LayoutTestController::evaluateInWebInspector):
3264
3265 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3266
3267         Reviewed by Sam Weinig.
3268
3269         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3270         https://bugs.webkit.org/show_bug.cgi?id=29841
3271
3272         * DumpRenderTree/mac/DumpRenderTree.mm:
3273         (resetDefaultsToConsistentValues):
3274         * DumpRenderTree/win/DumpRenderTree.cpp:
3275         (resetDefaultsToConsistentValues):
3276
3277 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3278
3279         Reviewed by Dimitri Glazkov.
3280
3281         Chromium Port - Windows
3282         https://bugs.webkit.org/show_bug.cgi?id=29969
3283
3284         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3285         * Scripts/webkitdirs.pm:
3286
3287 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3288
3289         Reviewed by Darin Adler.
3290
3291         jsc scripts cleanup and Qt/GTK fix
3292         https://bugs.webkit.org/show_bug.cgi?id=30288
3293
3294         Duplicated jscPath() moved to webkitdirs.pm.
3295         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3296         Configuration added (release/debug) to path for Qt-port on Windows.
3297
3298         * Scripts/run-javascriptcore-tests:
3299         * Scripts/run-jsc:
3300         * Scripts/run-sunspider:
3301         * Scripts/sunspider-compare-results:
3302         * Scripts/webkitdirs.pm:
3303
3304 2009-10-11  Adam Barth  <abarth@webkit.org>
3305
3306         Unreviewed.  Add Collin to committers.py.
3307
3308         * Scripts/modules/committers.py:
3309
3310 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3311
3312         wx build fix, add bindings to source/include dirs now that there are sources there.
3313
3314         * wx/build/settings.py:
3315
3316 2009-10-09  Mark Rowe  <mrowe@apple.com>
3317
3318         Reviewed by Brady Eidson.
3319
3320         Enable plug-in halting in DumpRenderTree.
3321
3322         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3323         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3324
3325         * DumpRenderTree/mac/DumpRenderTree.mm:
3326         (resetDefaultsToConsistentValues):
3327         * DumpRenderTree/mac/UIDelegate.mm:
3328         (-[UIDelegate webView:shouldHaltPlugin:]):
3329
3330 2009-10-08  Brady Eidson  <beidson@apple.com>
3331
3332         Reviewed by Dan Bernstein.
3333
3334         Ask the History Delegate to populate the visited links hash.
3335         <rdar://problem/7285293> and https://webkit.org/b/29904
3336
3337         Add the ability for LayoutTestController to clear all visited links.
3338         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3339
3340         * DumpRenderTree/LayoutTestController.cpp:
3341         (LayoutTestController::LayoutTestController):
3342         (removeAllVisitedLinksCallback):
3343         (LayoutTestController::staticFunctions):
3344         * DumpRenderTree/LayoutTestController.h:
3345         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3346         (LayoutTestController::removeAllVisitedLinks):
3347
3348         * DumpRenderTree/mac/HistoryDelegate.mm:
3349         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3350
3351         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3352         (LayoutTestController::removeAllVisitedLinks):
3353         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3354         (LayoutTestController::removeAllVisitedLinks):
3355         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3356         (LayoutTestController::removeAllVisitedLinks):
3357
3358
3359 2009-10-08  Daniel Bates  <dbates@webkit.org>
3360
3361         Reviewed by Adam Roben.
3362
3363         https://bugs.webkit.org/show_bug.cgi?id=30175
3364         
3365         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3366         the OLE drag-and-drop return value like the function it emulates. Currently, 
3367         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
3368         whether the drag-and-drop operation was successful or was cancelled.
3369         
3370         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
3371         return value according to whether the drop operation was successful or not.
3372
3373         * DumpRenderTree/win/EventSender.cpp:
3374         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3375         (replaySavedEvents): Ditto.
3376         * DumpRenderTree/win/EventSender.h:
3377         * DumpRenderTree/win/UIDelegate.cpp:
3378         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3379
3380 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3381
3382         Reviewed by Xan Lopez.
3383
3384         [GTK] Added support for a parameter setting the button that was
3385         pressed in the mouseDown function.
3386         https://bugs.webkit.org/show_bug.cgi?id=30220
3387
3388         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3389
3390 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3391
3392         Reviewed by Xan Lopez.
3393
3394         [GTK] Added a line to the bottom of the expected result to match
3395         the output of the test.
3396         https://bugs.webkit.org/show_bug.cgi?id=30220
3397
3398         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3399         expected.txt:
3400
3401 2009-10-08  Adam Roben  <aroben@apple.com>
3402
3403         Use QueryInterface to get IWebInspectorPrivate
3404
3405         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3406         accessed in a more standard way
3407
3408         Reviewed by John Sullivan and Tim Hatcher.
3409
3410         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3411         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3412         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3413         to the IWebInspectorPrivate interface.
3414
3415 2009-10-07  Adam Roben  <aroben@apple.com>
3416
3417         Implement DRT support for origin whitelisting
3418
3419         Fixes <http://webkit.org/b/30185>.
3420
3421         Reviewed by Eric Seidel.
3422
3423         * DumpRenderTree/win/DumpRenderTree.cpp:
3424         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3425         whitelist, to match Mac DRT.
3426         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3427         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3428         IWebViewPrivate::whiteListAccessFromOrigin.
3429
3430 2009-10-07  Brady Eidson  <beidson@apple.com>
3431
3432         Reviewed by Darin Adler.
3433
3434         Send title changes to the global history delegate.
3435         <rdar://problem/7285293> and https://webkit.org/b/29904
3436
3437         * DumpRenderTree/mac/HistoryDelegate.mm:
3438         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3439
3440 2009-10-07  Adam Barth  <abarth@webkit.org>
3441
3442         Unreviewed.  Remove some folks from committers.py who were listed on
3443         the WebKit Team wiki page but who weren't actually listed as commit+.
3444         At some point, we should coorelate this list with the committers
3445         mailing list.
3446
3447         * Scripts/modules/committers.py:
3448
3449 2009-10-07  Adam Barth  <abarth@webkit.org>
3450
3451         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3452         the wiki into committers.py.
3453
3454         * Scripts/modules/committers.py:
3455
3456 2009-10-07  Adam Barth  <abarth@webkit.org>
3457
3458         Unreviewed.  Added Aaron Boodman to committers.py.
3459
3460         * Scripts/modules/committers.py:
3461
3462 2009-10-07  Evan Martin  <evan@chromium.org>
3463
3464         Reviewed by Darin Adler.
3465
3466         Add API to LayoutTestController for re/setting the system locale.
3467         https://bugs.webkit.org/show_bug.cgi?id=18994
3468
3469         * DumpRenderTree/LayoutTestController.cpp:
3470         (setLocaleCallback):
3471         (LayoutTestController::staticFunctions):
3472         (LayoutTestController::setLocale):
3473         * DumpRenderTree/LayoutTestController.h:
3474
3475 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3476
3477         Reviewed by Jan Alonzo.
3478
3479         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3480         https://bugs.webkit.org/show_bug.cgi?id=29689
3481
3482         Build fix by adding -lfontconfig for DumpRenderTree.
3483
3484         * GNUmakefile.am:
3485
3486 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3487
3488         Reviewed by Simon Hausmann.
3489
3490         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3491
3492         * Scripts/run-webkit-tests:
3493
3494 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3495
3496         Reviewed by Gustavo Noronha.
3497
3498         "delete" in EventSender is the backspace key, not the delete one.
3499
3500         * DumpRenderTree/gtk/EventSender.cpp:
3501         (keyDownCallback):
3502
3503 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3504
3505         Reviewed by Gustavo Noronha.
3506
3507         getChildrenWithRange expects as last parameter the end index, not
3508         the length of the range. Correct this and clarify the variable
3509         names to reflect how the code works.
3510
3511         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3512         (AccessibilityUIElement::getChildrenWithRange):
3513         (AccessibilityUIElement::getChildAtIndex):
3514
3515 2009-10-06  Mark Rowe  <mrowe@apple.com>
3516
3517         Reviewed by Simon Fraser.
3518
3519         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3520
3521         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3522         the fact we have already changed the working directory to the top of the open source tree.
3523
3524 2009-10-06  Julie Parent  <jparent@chromium.org>
3525
3526         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3527         rather than my committer email.
3528
3529         * Scripts/modules/committers.py:
3530
3531 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3532
3533         Reviewed by Eric Seidel.
3534
3535         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3536
3537         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3538         it after each layout test as it should do, making the DRT dump additional output
3539         for all of the subsequent layout tests.
3540
3541         * DumpRenderTree/qt/jsobjects.cpp:
3542         (LayoutTestController::reset):
3543
3544 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3545
3546         Reviewed by Simon Hausmann.
3547
3548         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3549         fast/dom/assign-to-window-status.html test, which is passing as a result.
3550
3551         https://bugs.webkit.org/show_bug.cgi?id=30127
3552
3553         * DumpRenderTree/qt/DumpRenderTree.cpp:
3554         (WebCore::DumpRenderTree::DumpRenderTree):
3555         (WebCore::DumpRenderTree::statusBarMessage):
3556         * DumpRenderTree/qt/DumpRenderTree.h:
3557         * DumpRenderTree/qt/jsobjects.h:
3558         (LayoutTestController::shouldDumpStatusCallbacks):
3559         (LayoutTestController::dumpStatusCallbacks):
3560
3561 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3562
3563         Reviewed by Simon Hausmann.
3564
3565         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3566         ignores the argument indicating which mouse button to trigger.
3567         https://bugs.webkit.org/show_bug.cgi?id=30048
3568
3569         This affects the fast/events/mouse-click-events.html layout test.
3570
3571         * DumpRenderTree/qt/jsobjects.cpp:
3572         (EventSender::mouseDown):
3573         (EventSender::mouseUp):
3574         * DumpRenderTree/qt/jsobjects.h:
3575
3576 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3577
3578         Reviewed by Simon Hausmann.
3579
3580         [Qt] Fix the EventSender::keyDown() implementation
3581         https://bugs.webkit.org/show_bug.cgi?id=30043
3582
3583         It should post both a key press event and a key release event,
3584         just like other ports do.
3585
3586         * DumpRenderTree/qt/jsobjects.cpp:
3587         (EventSender::keyDown):
3588
3589 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
3590
3591         wx build fix. Add jpeg to the list of libs to link against.
3592
3593         * wx/build/settings.py:
3594
3595 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3596
3597         Reviewed by Simon Hausmann.
3598
3599         [Qt] EventSender::keyDown() cannot send function-key events.
3600         https://bugs.webkit.org/show_bug.cgi?id=30044
3601
3602         This affects the fast/events/keydown-function-keys.html layout test.
3603
3604         * DumpRenderTree/qt/jsobjects.cpp:
3605         (EventSender::keyDown):
3606
3607 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3608
3609         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3610         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3611
3612         * wx/build/settings.py:
3613         * wx/build/wxpresets.py:
3614
3615 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3616
3617         Reviewed by Timothy Hatcher.
3618
3619         Web Inspector: add testing harness for Web Inspector.
3620
3621         https://bugs.webkit.org/show_bug.cgi?id=30010
3622
3623         * DumpRenderTree/LayoutTestController.cpp:
3624         (showWebInspectorCallback):
3625         (closeWebInspectorCallback):
3626         (evaluateInWebInspectorCallback):
3627         (LayoutTestController::staticFunctions):
3628         * DumpRenderTree/LayoutTestController.h:
3629         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3630         (LayoutTestController::showWebInspector):
3631         (LayoutTestController::closeWebInspector):
3632         (LayoutTestController::evaluateInWebInspector):
3633         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3634         (LayoutTestController::showWebInspector):
3635         (LayoutTestController::closeWebInspector):
3636         (LayoutTestController::evaluateInWebInspector):
3637         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3638         (LayoutTestController::showWebInspector):
3639         (LayoutTestController::closeWebInspector):
3640         (LayoutTestController::evaluateInWebInspector):
3641         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3642         (LayoutTestController::showWebInspector):
3643         (LayoutTestController::closeWebInspector):
3644         (LayoutTestController::evaluateInWebInspector):
3645
3646 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3647
3648         Reviewed by Ariyha Hidayat.
3649
3650         Pass arguments to system() as a string instead of array
3651
3652         When passed as an array entries with a space fail to translate
3653         to two arguments to the child process, so instead of manually
3654         splitting all the entries in @buildArgs we pass the whole thing
3655         as a string instead.
3656
3657         * Scripts/webkitdirs.pm:
3658
3659 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3660
3661         Reviewed by David Levin.
3662
3663         check-webkit-style misses whitespace errors for operators:
3664         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3665         https://bugs.webkit.org/show_bug.cgi?id=30021
3666
3667         * Scripts/modules/cpp_style.py:
3668         Added the operators mentioned above to the same list as == and !=.
3669
3670 2009-10-02  Julie Parent  <jparent@chromium.org>
3671
3672         Unreviewed.
3673
3674         Adding myself and Ojan Vafai as committers, because we are committers.
3675
3676         * Scripts/modules/committers.py:
3677
3678 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3679
3680         Reviewed by Adam Roben.
3681
3682         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3683       &nbs