5b633aa25e46f107338b27fd79026f44751318f9
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-12-04  Chris Fleizach  <cfleizach@apple.com>
2
3         Reviewed by Darin Adler.
4
5         REGRESSION: AX: buttons now extremely repetitive
6         https://bugs.webkit.org/show_bug.cgi?id=32164
7
8         * DumpRenderTree/AccessibilityUIElement.cpp:
9         (isAttributeSupportedCallback):
10         (AccessibilityUIElement::getJSClass):
11         * DumpRenderTree/AccessibilityUIElement.h:
12         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
13         (AccessibilityUIElement::isAttributeSupported):
14         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
15         (AccessibilityUIElement::isAttributeSupported):
16         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
17         (AccessibilityUIElement::isAttributeSupported):
18
19 2009-12-03  Shinichiro Hamaji  <hamaji@chromium.org>
20
21         Reviewed by David Levin.
22
23         check-webkit-style should check for camelCase variable names
24         https://bugs.webkit.org/show_bug.cgi?id=32051
25
26         * Scripts/modules/cpp_style.py:
27         * Scripts/modules/cpp_style_unittest.py:
28
29 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
30
31         Reviewed by Eric Seidel.
32
33         AX: VO just says "term" on many web sites
34         https://bugs.webkit.org/show_bug.cgi?id=32139
35
36         * DumpRenderTree/AccessibilityUIElement.cpp:
37         (getRoleDescriptionCallback):
38         (AccessibilityUIElement::getJSClass):
39         * DumpRenderTree/AccessibilityUIElement.h:
40         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
41         (AccessibilityUIElement::roleDescription):
42         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
43         (AccessibilityUIElement::roleDescription):
44         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
45         (AccessibilityUIElement::roleDescription):
46
47 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
48
49         Reviewed by Beth Dakin.
50
51         Implement WAI-ARIA scrollbar role and related property aria-orientation
52         https://bugs.webkit.org/show_bug.cgi?id=32126
53
54         * DumpRenderTree/AccessibilityUIElement.cpp:
55         (getOrientationCallback):
56         (AccessibilityUIElement::getJSClass):
57         * DumpRenderTree/AccessibilityUIElement.h:
58         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
59         (AccessibilityUIElement::orientation):
60         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
61         (AccessibilityUIElement::orientation):
62         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
63         (AccessibilityUIElement::orientation):
64
65 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
66
67         Reviewed by Adam Roben.
68
69         Minor correction to r51663.
70
71         * DumpRenderTree/win/DumpRenderTree.cpp:
72         (addQTDirToPATH):
73             GetEnvironmentVariable -> GetEnvironmentVariableW.
74
75 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
76
77         Reviewed by Adam Roben.
78
79         ~96 regression tests fail when using QuickTime 7.6 (they pass with QuickTime 7.3)
80         https://bugs.webkit.org/show_bug.cgi?id=30256
81
82         Add the QuickTime dll directory to the PATH environment variable so
83         inialization can succeed.
84
85         * DumpRenderTree/win/DumpRenderTree.cpp:
86         (addQTDirToPATH):
87         (initialize):
88
89 2009-12-03  Shu Chang  <Chang.Shu@nokia.com>
90
91         Reviewed by Kenneth Rohde Christiansen.
92
93         [Qt] After revision 32643, sender() is of type QWebPage instead of QWebFrame.
94
95         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
96         (LayoutTestController::maybeDump):
97
98 2009-12-03  Yuzo Fujishima  <yuzo@google.com>
99
100         Reviewed by Eric Seidel.
101
102         Update pywebsocket to 0.4.3
103         This version logs friendlier and higher-level messages in WARN level, which is used for LayoutTests.
104         Stack trace is logged now in INFO level.
105         https://bugs.webkit.org/show_bug.cgi?id=32097
106
107         * pywebsocket/mod_pywebsocket/dispatch.py:
108         * pywebsocket/mod_pywebsocket/msgutil.py:
109         * pywebsocket/mod_pywebsocket/standalone.py:
110         * pywebsocket/mod_pywebsocket/util.py:
111         * pywebsocket/setup.py:
112         * pywebsocket/test/test_dispatch.py:
113         * pywebsocket/test/test_util.py:
114
115 2009-12-03  Sam Weinig  <sam@webkit.org>
116
117         Reviewed by Gavin Barraclough.
118
119         Fix JSClassRef leak.
120
121         * DumpRenderTree/AccessibilityController.cpp:
122         (AccessibilityController::makeWindowObject):
123         * DumpRenderTree/GCController.cpp:
124         (GCController::makeWindowObject):
125         * DumpRenderTree/LayoutTestController.cpp:
126         (LayoutTestController::makeWindowObject):
127
128 2009-12-03  Brady Eidson  <beidson@apple.com>
129
130         Reviewed by Sam Weinig.
131
132         <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
133
134         Keep DRT-win building...
135
136         * DumpRenderTree/win/FrameLoadDelegate.h:
137         (FrameLoadDelegate::didPushStateWithinPageForFrame):
138         (FrameLoadDelegate::didReplaceStateWithinPageForFrame):
139         (FrameLoadDelegate::didPopStateWithinPageForFrame):
140
141 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
142
143         Unreviewed build fix.
144
145         [Qt] ARM-Linux build fix after r51634 removed unused QBoxLayout include which included limits.h on ARM.
146
147         * DumpRenderTree/qt/DumpRenderTree.cpp:
148
149 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
150
151         Reviewed by Kenneth Rohde Christiansen.
152
153         [Qt] Refactor DRT to not crash on tests which open child windows from javascript.
154         Prevent DRT from showing the main view if these childs get deleted.
155         This fixes https://bugs.webkit.org/show_bug.cgi?id=31591.
156
157         * DumpRenderTree/qt/DumpRenderTree.cpp:
158         (WebCore::WebPage::WebPage):
159         (WebCore::DumpRenderTree::DumpRenderTree):
160         (WebCore::DumpRenderTree::~DumpRenderTree):
161         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
162         (WebCore::DumpRenderTree::open):
163         (WebCore::DumpRenderTree::closeRemainingWindows):
164         (WebCore::DumpRenderTree::createWindow):
165         (WebCore::DumpRenderTree::windowCount):
166         * DumpRenderTree/qt/DumpRenderTree.h:
167
168 2009-12-02  Eric Seidel  <eric@webkit.org>
169
170         Reviewed by Adam Barth.
171
172         REGRESSION(51595): commit-queue is throwing exceptions
173         https://bugs.webkit.org/show_bug.cgi?id=32083
174
175         * Scripts/modules/commands/queues.py:
176          - Don't use default value of [] as it ends up getting shared.
177          - Make log_progress accept arrays of ints as well as strings.
178          - Return an exit code from execute()
179         * Scripts/modules/commands/queues_unittest.py: Added.
180          - Test to make sure log_progress will accept ints.
181          - Test to make sure run_bugzilla_tool will accept ints.
182         * Scripts/modules/workqueue.py:
183          - Print the stack trace on unexpected exceptions for easier debugging.
184         * Scripts/run-webkit-unittests:
185          - Add queues_unittest.
186
187         * Scripts/modules/commands/queues.py:
188         * Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py.
189         * Scripts/modules/mock_bugzillatool.py:
190         * Scripts/modules/workqueue.py:
191         * Scripts/run-webkit-unittests:
192
193 2009-12-02  David Levin  <levin@chromium.org>
194
195         Reviewed by Adam Barth.
196
197         check-webkit-style is too noisy about namespace indenting issues.
198         https://bugs.webkit.org/show_bug.cgi?id=32096
199
200         * Scripts/modules/cpp_style.py:
201         Added a _FileState object to be able to track file level information. In this
202         case, it simply tracks whether the error has already been given, so that it isn't
203         done again.
204         * Scripts/modules/cpp_style_unittest.py:
205         Modified test cases to pass in the _FileState object and fix a test that expected
206         to see the namespace error twice (now it only occurs once). No new tests because
207         existing tests cover the change in functionality.
208
209 2009-12-01  Kevin Ollivier  <kevino@theolliviers.com>
210
211         Reviewed by Eric Seidel.
212
213         [wx] Get DumpRenderTree building after waf switch.
214         
215         https://bugs.webkit.org/show_bug.cgi?id=32041
216
217         * DumpRenderTree/wscript: Added.
218         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
219         (LayoutTestController::setTimelineProfilingEnabled):
220         (LayoutTestController::evaluateScriptInIsolatedWorld):
221         (LayoutTestController::disableImageLoading):
222         (LayoutTestController::whiteListAccessFromOrigin):
223         (LayoutTestController::counterValueForElementById):
224         * Scripts/build-webkit:
225
226 2009-12-02  Adam Barth  <abarth@webkit.org>
227
228         Reviewed by Eric Seidel.
229
230         [bzt] build-attachment shouldn't check whether the builders are red
231         https://bugs.webkit.org/show_bug.cgi?id=32062
232
233         build-attachment doesn't touch the remote repository, so there isn't a
234         need to hold off when the builders are red.
235
236         * Scripts/modules/commands/download.py:
237         * Scripts/modules/landingsequence.py:
238
239 2009-12-02  Eric Seidel  <eric@webkit.org>
240
241         Reviewed by Adam Barth.
242
243         REGRESSION(51590): style-queue and build-queue think their empty when they are not
244         https://bugs.webkit.org/show_bug.cgi?id=32061
245
246         * Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings.
247         * Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints.
248
249 2009-12-02  Eric Seidel  <eric@webkit.org>
250
251         Reviewed by Adam Barth.
252
253         build-queue is throwing exceptions and complaining about
254         lack of --no-update on build-attachment.  Make it stop.
255
256         * Scripts/modules/buildsteps.py:
257         * Scripts/modules/commands/download.py:
258
259 2009-12-02  Adam Barth  <abarth@webkit.org>
260
261         Unreviewed "build" fix.  Forgot to declare my variables.  :(
262
263         * QueueStatusServer/queue_status.py:
264
265 2009-12-02  Adam Barth  <abarth@webkit.org>
266
267         Reviewed by Eric Seidel.
268
269         [bzt] Implement status bubble view
270         https://bugs.webkit.org/show_bug.cgi?id=32057
271
272         The status bubble is a compact representation of the queue status for a
273         given patch.  This will eventually help us reduce the comment spam from
274         the queues.
275
276         * QueueStatusServer/index.html: Added HTML5 doctype for sanity.
277         * QueueStatusServer/queue_status.py:
278         * QueueStatusServer/status_bubble.html: Added.
279
280 2009-12-02  Eric Seidel  <eric@webkit.org>
281
282         Reviewed by Adam Barth.
283
284         trim commands/*.py includes now that commands are unit tested
285         https://bugs.webkit.org/show_bug.cgi?id=32056
286
287         In the course of ensuring that the unit tests still
288         passed after this change, I had to actually make them
289         pass in the first place.
290
291         * Scripts/modules/bugzilla.py:
292          - Fix _parse_attachment_ids_request_query to return ints instead of strings.
293         * Scripts/modules/commands/download.py: Remove unneeded imports.
294         * Scripts/modules/commands/queries.py: Ditto.
295         * Scripts/modules/commands/queues.py: Ditto.
296         * Scripts/modules/commands/upload.py: Ditto.
297         * Scripts/modules/scm_unittest.py:
298          - Fix to expect the \n after the path since echo adds an \n.
299
300 2009-12-01  Yaar Schnitman  <yaar@chromium.org>
301
302         build-webkit: Remove flex,bison,gperf check for chromium
303         https://bugs.webkit.org/show_bug.cgi?id=32043
304
305         * Scripts/webkitdirs.pm:
306
307 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
308
309         Build fixage for Windows/GTK for DumpRenderTree.
310
311         WAI-ARIA: implement support for ARIA drag and drop
312         https://bugs.webkit.org/show_bug.cgi?id=32007
313
314         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
315         (AccessibilityUIElement::ariaIsGrabbed):
316         (AccessibilityUIElement::ariaDropEffects):
317         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
318         (AccessibilityUIElement::ariaIsGrabbed):
319         (AccessibilityUIElement::ariaDropEffects):
320
321 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
322
323         Reviewed by Darin Adler.
324
325         WAI-ARIA: implement support for ARIA drag and drop
326         https://bugs.webkit.org/show_bug.cgi?id=32007
327
328         * DumpRenderTree/AccessibilityUIElement.cpp:
329         (getARIADropEffectsCallback):
330         (getARIAIsGrabbedCallback):
331         (AccessibilityUIElement::getJSClass):
332         * DumpRenderTree/AccessibilityUIElement.h:
333         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
334         (AccessibilityUIElement::ariaIsGrabbed):
335         (AccessibilityUIElement::ariaDropEffects):
336
337 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
338
339         Not reviewed. GTK DRT try 2.
340
341         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
342         (LayoutTestController::sampleSVGAnimationForElementAtTime):
343
344 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
345
346         Not reviewed. Try to fix gtk DRT build.
347
348         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
349
350 2009-12-01  David Levin  <levin@chromium.org>
351
352         Reviewed by Eric Seidel.
353
354         check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
355         https://bugs.webkit.org/show_bug.cgi?id=32033
356
357         * Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find
358                                         instead of startswith.
359         * Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior.
360
361 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
362
363         Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well.
364
365         * DumpRenderTree/qt/LayoutTestControllerQt.h: Update old function signature.
366
367 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
368
369         Reviewed by Simon Fraser.
370
371         Add SVG animation test framework with 'snapshot' functionality
372         https://bugs.webkit.org/show_bug.cgi?id=31897
373
374         Add new 'sampleSVGAnimationForElementAtTime' DRT method,
375         used by the new SVG animation testing framework, implemented
376         for qt/gtk/win/mac.
377
378         * DumpRenderTree/LayoutTestController.cpp:
379         (sampleSVGAnimationForElementAtTimeCallback):
380         (LayoutTestController::staticFunctions):
381         * DumpRenderTree/LayoutTestController.h:
382         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
383         (LayoutTestController::sampleSVGAnimationForElementAtTime):
384         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
385         (LayoutTestController::sampleSVGAnimationForElementAtTime):
386         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
387         (LayoutTestController::sampleSVGAnimationForElementAtTime):
388         * DumpRenderTree/qt/LayoutTestControllerQt.h:
389         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
390         (LayoutTestController::sampleSVGAnimationForElementAtTime):
391         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
392         (LayoutTestController::sampleSVGAnimationForElementAtTime):
393
394 2009-12-01  Adam Roben  <aroben@apple.com>
395
396         Remove user content before running each test on Windows
397
398         Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows
399
400         Reviewed by Alexey Proskuryakov.
401
402         * DumpRenderTree/win/DumpRenderTree.cpp:
403         (resetWebViewToConsistentStateBeforeTesting): Remove all user content
404         before each test, which matches Mac.
405
406 2009-12-01  Yuzo Fujishima  <yuzo@google.com>
407
408         Reviewed by Alexey Proskuryakov.
409
410         Make pywebsocket log errors to a file
411         https://bugs.webkit.org/show_bug.cgi?id=31604
412
413         * Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory
414         (by passing the path to the server via a recently added -l option).
415
416 2009-12-01  Adam Roben  <aroben@apple.com>
417
418         Fix tests that use the TestNetscapePlugin in Debug_Internal builds
419
420         Reviewed by Ada Chan.
421
422         Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
423         TestNetscapePlugin fail in Debug_Internal builds
424
425         * DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin
426         directory in Debug and Debug_All builds, but not in Debug_Internal
427         builds.
428
429 2009-12-01  Adam Roben  <aroben@apple.com>
430
431         Re-enable DRT's watchdog timer on Windows
432
433         It was accidentally disabled in r50907.
434
435         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
436         (LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
437         into an if condition.
438
439 2009-12-01  Adam Barth  <abarth@webkit.org>
440
441         Reviewed by Eric Seidel.
442
443         check-webkit-style complains about #imports with / in them
444         https://bugs.webkit.org/show_bug.cgi?id=32022
445
446         We need to exclude #import directives in addition to #include from the
447         binary operator whitespace checks.
448
449         * Scripts/modules/cpp_style.py:
450         * Scripts/modules/cpp_style_unittest.py:
451
452 2009-11-30  Adam Barth  <abarth@webkit.org>
453
454         Reviewed by Eric Seidel.
455
456         check-webkit-style is slightly too verbose
457         https://bugs.webkit.org/show_bug.cgi?id=32010
458
459         check-webkit-style prints out a bunch of "done" lines that seem redundant,
460         especially for the style-queue.
461
462         * Scripts/modules/cpp_style.py:
463
464 2009-11-30  Alejandro G. Castro  <alex@igalia.com>
465
466         Reviewed by Eric Seidel.
467
468         [GTK] Moved the functions that are closing the result log of the
469         tests to the last line of the runTest function, this avoids
470         reporting crashes in the wrong test if there is a problem when
471         reseting the state after the test.
472
473         * DumpRenderTree/gtk/DumpRenderTree.cpp:
474         (dump):
475         (runTest):
476
477 2009-11-30  Sam Weinig  <sam@webkit.org>
478
479         Reviewed by Geoffrey Garen.
480
481         Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
482         fast/js/date-proto-generic-invocation breaks another test
483
484         Don't cache JSClassRefs, a change to the prototype chain will
485         last between tests.
486
487         * DumpRenderTree/AccessibilityController.cpp:
488         (AccessibilityController::getJSClass):
489         * DumpRenderTree/GCController.cpp:
490         (GCController::getJSClass):
491         * DumpRenderTree/GCController.h:
492         * DumpRenderTree/LayoutTestController.cpp:
493         (LayoutTestController::getJSClass):
494
495 2009-11-30  Yuzo Fujishima  <yuzo@google.com>
496
497         Reviewed by Alexey Proskuryakov.
498
499         Update pywebsocket to 0.4.2.1.
500         This is to fix a bug that some messages are logged to stderr even when the log file is specified.
501         https://bugs.webkit.org/show_bug.cgi?id=31976
502
503         * pywebsocket/mod_pywebsocket/standalone.py:
504         * pywebsocket/setup.py:
505
506 2009-11-30  Adam Barth  <abarth@webkit.org>
507
508         Reviewed by Eric Seidel.
509
510         [bzt] Generate pass messages for style-queue
511         https://bugs.webkit.org/show_bug.cgi?id=31995
512
513         With this change, the style-queue posts "pass" messages to bugs as
514         well.  Also, added more information to the state store w.r.t. passing
515         and failing.
516
517         * Scripts/modules/commands/queues.py:
518         * Scripts/modules/patchcollection.py:
519
520 2009-11-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
521
522         Reviewed by Simon Fraser.
523
524         Check for WEBKIT_TESTFONTS environment variable in
525         run-webkit-tests, for GTK+, to have a more prominent error
526         message.
527
528         * Scripts/run-webkit-tests:
529
530 2009-11-30  Yaar Schnitman  <yaar@chromium.org>
531
532         Reviewed by Dimitri Glazkov.
533
534         update-webkit --chromium forces gclient sync
535
536         https://bugs.webkit.org/show_bug.cgi?id=31967
537
538         * Scripts/update-webkit-chromium:
539
540 2009-11-29  Eric Seidel  <eric@webkit.org>
541
542         Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.
543
544         * Scripts/modules/committers.py:
545
546 2009-11-29  Eric Seidel  <eric@webkit.org>
547
548         No review, just adding missing svn property.
549
550         Set svn:executable property on new scripts.
551         These were added by commit-queue commits, but the executable
552         property was lost due to a bug in svn-apply:
553         https://bugs.webkit.org/show_bug.cgi?id=27204
554
555         * Scripts/update-webkit-chromium: Added property svn:executable.
556         * Scripts/validate-committer-lists: Added property svn:executable.
557
558 2009-11-29  Eric Seidel  <eric@webkit.org>
559
560         Reviewed by Adam Barth.
561
562         Need a way to validate that committers.py includes all committers/reviewers
563         https://bugs.webkit.org/show_bug.cgi?id=30970
564
565         Add a script which knows how to compare our public committer/reviewer
566         lists and show discrepancies between them.
567
568         Validates mailing lists vs. committers.py:
569         - committers.py committers missing from webkit-committers@lists
570         - webkit-committers@lists members missing from committers.py
571         - committers.py reviewers missing from webkit-reviewers@lists
572         - webkit-reviewers@lists members missing from committers.py
573         - webkit-reviewers@lists members missing from committers.py reviewer list
574
575         Validates committers.py vs. trunk/ SVN history:
576         - committers who have not committed in over a year
577         - SVN committers missing from committers.py
578         - committers.py members who have no record in SVN.
579
580         All of these lists still show "false positives" until a few more committers.py updates are made, like:
581         https://bugs.webkit.org/show_bug.cgi?id=31366
582
583         * Scripts/validate-committer-lists: Added.
584
585 2009-11-28  Adam Barth  <abarth@webkit.org>
586
587         Reviewed by Eric Seidel.
588
589         [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
590         https://bugs.webkit.org/show_bug.cgi?id=31950
591
592         Now we cache the last status that we get back from QueueStatusServer.
593         Eventually we'll have to do something more fancy if we want to support
594         a "try again" button on QueueStatusServer, but we can cross that bridge
595         when we come to it.
596
597         * Scripts/modules/patchcollection.py:
598
599 2009-11-28  Adam Barth  <abarth@webkit.org>
600
601         Reviewed by Eric Seidel.
602
603         StyleQueue scans ~100 bug pages every 5 minutes
604         https://bugs.webkit.org/show_bug.cgi?id=31947
605
606         Instead of getting the pending-review attachment ids by scanning each
607         bug (which results in a network request), we should just get them all
608         from webkit.org/pending-review in one shot.
609
610         * Scripts/modules/bugzilla.py:
611         * Scripts/modules/bugzilla_unittest.py:
612         * Scripts/modules/commands/queries.py:
613         * Scripts/modules/commands/queries_unittest.py:
614         * Scripts/modules/commands/queues.py:
615         * Scripts/modules/mock_bugzillatool.py:
616         * Scripts/modules/patchcollection.py:
617
618 2009-11-28  Adam Barth  <abarth@webkit.org>
619
620         Reviewed by Eric Seidel.
621
622         [bzt] CC webkit-bot-watchers whenever the bots touch bugs
623         https://bugs.webkit.org/show_bug.cgi?id=31952
624
625         The mailing list is open for anyone to subscribe.
626
627         * Scripts/modules/bugzilla.py:
628         * Scripts/modules/commands/queues.py:
629
630 2009-11-28  Adam Barth  <abarth@webkit.org>
631
632         Reviewed by Eric Seidel.
633
634         [bzt] style-queue should report style errors to bugzilla
635         https://bugs.webkit.org/show_bug.cgi?id=31945
636
637         Currently, we're just logging the style errors locally.  With this
638         patch we'll actually log the errors to bugzilla.  Note: I plan to run
639         with the "local-only" logging during development.
640
641         * Scripts/modules/commands/queues.py:
642         * Scripts/modules/scm.py:
643
644 2009-11-28  Adam Barth  <abarth@webkit.org>
645
646         Reviewed by Eric Seidel.
647
648         [bzt] style-queue shouldn't reject patches from the commit-queue
649         https://bugs.webkit.org/show_bug.cgi?id=31944
650
651         Currently the style-queue subprocess gets confused and thinks its the
652         commit-queue.  If the patch has an error, it rejects it from the
653         commit-queue.  Instead, we should have style-queue specific logic.
654         This patch doesn't add that logic, but it gives us a callback we can
655         use to add that logic.
656
657         * Scripts/modules/buildsteps.py:
658         * Scripts/modules/commands/queues.py:
659         * Scripts/modules/landingsequence.py:
660
661 2009-11-27  Adam Barth  <abarth@webkit.org>
662
663         Rubber stamped by Eric Seidel.
664
665         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
666
667         * CommitQueueStatus: Removed.
668         * CommitQueueStatus/app.yaml: Removed.
669         * CommitQueueStatus/filters: Removed.
670         * CommitQueueStatus/filters/__init__.py: Removed.
671         * CommitQueueStatus/filters/webkit_extras.py: Removed.
672         * CommitQueueStatus/index.html: Removed.
673         * CommitQueueStatus/index.yaml: Removed.
674         * CommitQueueStatus/queue_status.py: Removed.
675         * CommitQueueStatus/stylesheets: Removed.
676         * CommitQueueStatus/stylesheets/main.css: Removed.
677         * CommitQueueStatus/update_status.html: Removed.
678         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
679
680 2009-11-27  Adam Barth  <abarth@webkit.org>
681
682         Reviewed by Eric Seidel.
683
684         style-queue should only process each patch once
685         https://bugs.webkit.org/show_bug.cgi?id=31939
686
687         Actually address reviewer comments!
688
689         * Scripts/bugzilla-tool:
690
691 2009-11-27  Adam Barth  <abarth@webkit.org>
692
693         Reviewed by Eric Seidel.
694
695         [bzt] style-queue fails to apply a bunch of patches for no reason
696         https://bugs.webkit.org/show_bug.cgi?id=31942
697
698         By passing --non-interactive to check-style, we convince check-style
699         to pass --force to svn-apply, which lets it apply more patches.
700
701         * Scripts/modules/commands/queues.py:
702
703 2009-11-27  Adam Barth  <abarth@webkit.org>
704
705         Reviewed by Eric Seidel.
706
707         [bzt] Support --status-host in style-queue
708         https://bugs.webkit.org/show_bug.cgi?id=31941
709
710         * Scripts/modules/commands/queues.py:
711         * Scripts/modules/statusbot.py:
712
713 2009-11-27  Adam Barth  <abarth@webkit.org>
714
715         Reviewed by Eric Seidel.
716
717         style-queue should only process each patch once
718         https://bugs.webkit.org/show_bug.cgi?id=31939
719
720         Before processing a patch, the try-queues now ask the web service
721         whether they have already processed the patch.  This is an initial cut
722         of this functionality.  I expect we're make it richer over time.
723
724         * Scripts/bugzilla-tool:
725         * Scripts/modules/commands/queues.py:
726         * Scripts/modules/patchcollection.py:
727
728 2009-11-27  Adam Barth  <abarth@webkit.org>
729
730         Reviewed by Eric Seidel.
731
732         PatchStatus does not return status
733         https://bugs.webkit.org/show_bug.cgi?id=31938
734
735         We need to parse attachment_id as an int.  Otherwise, we can't find
736         anything in the datastore.
737
738         * CommitQueueStatus/queue_status.py:
739
740 2009-11-27  Adam Barth  <abarth@webkit.org>
741
742         Reviewed by Eric Seidel.
743
744         Make commit-queue status not throw an exception where there is not
745         status
746         https://bugs.webkit.org/show_bug.cgi?id=31936
747
748         We need to actually fetch the results of the query to see what's in the
749         datastore.
750
751         * CommitQueueStatus/queue_status.py:
752
753 2009-11-27  Adam Barth  <abarth@webkit.org>
754
755         Reviewed by Eric Seidel.
756
757         [bzt] unit test ApplyPatches and ApplyAttachment
758         https://bugs.webkit.org/show_bug.cgi?id=31935
759
760         * Scripts/modules/commands/download.py:
761         * Scripts/modules/commands/download_unittest.py:
762
763 2009-11-27  Adam Barth  <abarth@webkit.org>
764
765         Reviewed by Eric Seidel.
766
767         [bzt] Unit test download commands
768         https://bugs.webkit.org/show_bug.cgi?id=31923
769
770         Adds download_unittest and fixes a bug found while testing.
771
772         * Scripts/modules/commands/commandtest.py:
773         * Scripts/modules/commands/download.py:
774             Fixed a bug where we'd throw an error because [].append returns
775             None.
776         * Scripts/modules/commands/download_unittest.py: Added.
777         * Scripts/modules/mock_bugzillatool.py:
778         * Scripts/run-webkit-unittests:
779
780 2009-11-27  Adam Barth  <abarth@webkit.org>
781
782         Unreviewed "build" fix found while writing unit tests.
783
784         * Scripts/modules/commands/download.py:
785
786 2009-11-27  Adam Barth  <abarth@webkit.org>
787
788         Reviewed by Eric Seidel.
789
790         [bzt] Kill WebKitLandingScripts
791         https://bugs.webkit.org/show_bug.cgi?id=31904
792
793         Step 6: Kill the rest.
794
795         * Scripts/modules/buildsteps.py:
796         * Scripts/modules/commands/download.py:
797         * Scripts/modules/commands/queries.py:
798         * Scripts/modules/commands/upload.py:
799         * Scripts/modules/landingsequence.py:
800         * Scripts/modules/scm.py:
801         * Scripts/modules/webkitlandingscripts.py: Removed.
802
803 2009-11-27  Adam Barth  <abarth@webkit.org>
804
805         Reviewed by Eric Seidel.
806
807         [bzt] Unit test upload commands
808         https://bugs.webkit.org/show_bug.cgi?id=31903
809
810         Adds unit tests for all but two of the upload commands.  The two
811         remaining ones are more difficult.  I'll return to them later.  The
812         goal of these tests is just to run the commands.  We can test more
813         detailed behavior later.
814
815         * Scripts/modules/commands/commandtest.py:
816         * Scripts/modules/commands/upload.py:
817         * Scripts/modules/commands/upload_unittest.py:
818         * Scripts/modules/mock.py: Added.
819         * Scripts/modules/mock_bugzillatool.py:
820
821 2009-11-26  Adam Barth  <abarth@webkit.org>
822
823         Reviewed by Eric Seidel.
824
825         [bzt] Kill WebKitLandingScripts
826         https://bugs.webkit.org/show_bug.cgi?id=31904
827
828         Step 5: Kill run_and_throw_if_fail.
829
830         * Scripts/modules/buildsteps.py:
831         * Scripts/modules/processutils.py: Added.
832         * Scripts/modules/webkitlandingscripts.py:
833
834 2009-11-26  Adam Barth  <abarth@webkit.org>
835
836         Reviewed by Eric Seidel.
837
838         [bzt] Kill WebKitLandingScripts
839         https://bugs.webkit.org/show_bug.cgi?id=31904
840
841         Step 4: Kill run_webkit_script.
842
843         * Scripts/modules/buildsteps.py:
844         * Scripts/modules/commands/download.py:
845         * Scripts/modules/webkitlandingscripts.py:
846
847 2009-11-26  Adam Barth  <abarth@webkit.org>
848
849         Reviewed by Eric Seidel.
850
851         [bzt] Kill WebKitLandingScripts
852         https://bugs.webkit.org/show_bug.cgi?id=31904
853
854         Step 3: Kill build_webkit.
855
856         * Scripts/modules/buildsteps.py:
857         * Scripts/modules/landingsequence.py:
858         * Scripts/modules/webkitlandingscripts.py:
859
860 2009-11-26  Adam Barth  <abarth@webkit.org>
861
862         Reviewed by Eric Seidel.
863
864         [bzt] Kill WebKitLandingScripts
865         https://bugs.webkit.org/show_bug.cgi?id=31904
866
867         Step 2: Kill ensure_builders_are_green.
868
869         * Scripts/modules/buildsteps.py:
870         * Scripts/modules/commands/download.py:
871         * Scripts/modules/landingsequence.py:
872         * Scripts/modules/webkitlandingscripts.py:
873
874 2009-11-26  Adam Barth  <abarth@webkit.org>
875
876         Reviewed by Eric Seidel.
877
878         [bzt] Kill WebKitLandingScripts
879         https://bugs.webkit.org/show_bug.cgi?id=31904
880
881         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
882
883         * Scripts/bugzilla-tool:
884         * Scripts/modules/buildsteps.py: Added.
885         * Scripts/modules/commands/download.py:
886         * Scripts/modules/landingsequence.py:
887         * Scripts/modules/webkitlandingscripts.py:
888
889 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
890
891         Reviewed by Adam Barth.
892
893         Remove directory prefixes from linux commands
894
895         SCM unittests can cause errors on some systems if we use absolute reference to
896         the commands, so directory prefixes have been removed.
897
898         * Scripts/modules/scm_unittest.py:
899
900 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
901
902         Reviewed by Kenneth Rohde Christiansen.
903
904         Link DumpRenderTree to the Qt Ui Tools
905         https://bugs.webkit.org/show_bug.cgi?id=31203
906
907         Implement QWebPage::createPlugin using the Qt Ui Tools
908         to be able to create classes like QProgressBar from within
909         the <object></object> tags This is required for the
910         new automatic test of Qt Plugins.
911
912         * DumpRenderTree/qt/DumpRenderTree.cpp:
913         (WebCore::WebPage::createPlugin):
914         * DumpRenderTree/qt/DumpRenderTree.h:
915         * DumpRenderTree/qt/DumpRenderTree.pro:
916
917 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
918
919         Reviewed by Eric Seidel.
920
921         Update pywebsocket to 0.4.2
922
923         Update pywebsocket to 0.4.2
924         https://bugs.webkit.org/show_bug.cgi?id=31861
925
926         * pywebsocket/example/echo_client.py:
927         * pywebsocket/example/echo_wsh.py:
928         * pywebsocket/mod_pywebsocket/__init__.py:
929         * pywebsocket/mod_pywebsocket/dispatch.py:
930         * pywebsocket/mod_pywebsocket/msgutil.py:
931         * pywebsocket/mod_pywebsocket/standalone.py:
932         * pywebsocket/setup.py:
933         * pywebsocket/test/test_dispatch.py:
934         * pywebsocket/test/test_msgutil.py:
935
936 2009-11-25  Adam Barth  <abarth@webkit.org>
937
938         Reviewed by Eric Seidel.
939
940         Add unit test for mark-fixed
941         https://bugs.webkit.org/show_bug.cgi?id=31896
942
943         * Scripts/modules/commands/commandtest.py: Added.
944         * Scripts/modules/commands/queries_unittest.py:
945         * Scripts/modules/commands/upload_unittest.py: Added.
946         * Scripts/modules/mock_bugzillatool.py:
947         * Scripts/run-webkit-unittests:
948
949 2009-11-25  Adam Barth  <abarth@webkit.org>
950
951         Reviewed by Eric Seidel.
952
953         bugzilla-tool should have a mark-fixed command
954         https://bugs.webkit.org/show_bug.cgi?id=31853
955
956         Pretty simple stuff.
957
958         * Scripts/modules/commands/upload.py:
959
960 2009-11-25  Eric Seidel  <eric@webkit.org>
961
962         Reviewed by Adam Barth.
963
964         'bugzilla-tool help' should only show common commands like how 'git help' does
965         https://bugs.webkit.org/show_bug.cgi?id=31772
966
967         I also took this opportunity to make 'help' a real Command.
968         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
969
970         * Scripts/bugzilla-tool:
971          - change should_show_command_help to should_show_in_main_help
972         * Scripts/modules/commands/download.py:
973          - Mark commands as being shown in main help or not.
974          - show_in_main_help = False is not required (default is false),
975            but it seemed to make the commands more self-documenting.
976         * Scripts/modules/commands/queries.py: ditto
977         * Scripts/modules/commands/queues.py: ditto
978         * Scripts/modules/commands/upload.py: ditto
979         * Scripts/modules/multicommandtool.py:
980          - Make Command hold a pointer to tool in self.tool.  Most Command
981            subclasses do not take advantage of this yet, but it was required
982            for HelpCommand to be able to reach the tool from _help_epilog().
983          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
984          - Move MultiCommandTool._help_epilog to Command._help_epilog
985          - Move "help" logic into HelpCommand.execute()
986          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
987         * Scripts/modules/multicommandtool_unittest.py:
988          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
989
990 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
991
992         Reviewed by Dan Bernstein.
993         
994         Patch by Mark Rowe.
995
996         The buildbots are failing on Windows because when they were upgraded
997         to 4.0.4, Apple Application Support was not in their path. Add it to
998         the path to fix the buildots.
999
1000         * Scripts/webkitdirs.pm:
1001
1002 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
1003
1004         Reviewed by David Kilzer.
1005
1006         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
1007         https://bugs.webkit.org/show_bug.cgi?id=31799
1008
1009         * Scripts/run-webkit-tests: Fixed.
1010
1011 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
1012
1013         Reviewed by Eric Seidel.
1014
1015         Change run_command to give back stderr by default
1016         https://bugs.webkit.org/show_bug.cgi?id=31734
1017
1018         Change run_command to give back stderr by default.
1019         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
1020         Change the related unittest call.
1021
1022         * Scripts/modules/scm.py:
1023         * Scripts/modules/scm_unittest.py:
1024
1025 2009-11-25  Eric Seidel  <eric@webkit.org>
1026
1027         Reviewed by Adam Barth.
1028
1029         Centralize required argument parsing in Command
1030         https://bugs.webkit.org/show_bug.cgi?id=31872
1031
1032         * Scripts/modules/commands/download.py: remove custom required arg message.
1033         * Scripts/modules/commands/upload.py: ditto.
1034         * Scripts/modules/multicommandtool.py:
1035          - Add _parse_required_arguments.
1036          - Pass program name off to OptionParser.
1037          - Add name() for access to tool name.
1038          - Add check_arguments_and_execute and make it return a return code.
1039          - Replace a couple uses of + with %.
1040         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
1041
1042 2009-11-25  Eric Seidel  <eric@webkit.org>
1043
1044         Reviewed by Adam Barth.
1045
1046         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
1047         https://bugs.webkit.org/show_bug.cgi?id=31870
1048
1049         * Scripts/modules/commands/queries_unittest.py: Use the new class.
1050         * Scripts/modules/multicommandtool_unittest.py: Ditto.
1051         * Scripts/modules/outputcapture.py: Added.
1052
1053 2009-11-24  Dmitry Titov  <dimich@chromium.org>
1054
1055         Reviewed by Eric Seidel.
1056
1057         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
1058         https://bugs.webkit.org/show_bug.cgi?id=31444
1059
1060         * Scripts/build-webkit:
1061
1062 2009-11-24  Chris Marrin  <cmarrin@apple.com>
1063
1064         Reviewed by Simon Fraser.
1065
1066         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
1067         https://bugs.webkit.org/show_bug.cgi?id=27314
1068         
1069         Now the script allows the directories with these tests to be included on all
1070         platforms but Mac, where they behave the same as always. For all other platforms
1071         the tests need to be excluded using the Skipped files, which is currently done
1072         for all platforms (including win since we're not turned on yet)
1073
1074         * Scripts/webkitdirs.pm:
1075
1076 2009-11-24  Eric Seidel  <eric@webkit.org>
1077
1078         Reviewed by Adam Barth.
1079
1080         queries_unittest.py should test command output
1081         https://bugs.webkit.org/show_bug.cgi?id=31845
1082
1083         * Scripts/modules/commands/queries_unittest.py:
1084          - Capture stdout and stderr and compare with expected strings.
1085
1086 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
1087
1088         No Review.
1089
1090         Fix spelling error ("depenedencies").
1091
1092         * Scripts/build-webkit:
1093
1094 2009-11-24  Mark Rowe  <mrowe@apple.com>
1095
1096         Land the configuration that includes the two debug GTK Linux builders.
1097
1098         * BuildSlaveSupport/build.webkit.org-config/config.json:
1099
1100 2009-11-24  David Kilzer  <ddkilzer@apple.com>
1101
1102         <http://webkit.org/b/31840> bisect-builds broke after r50080
1103
1104         Reviewed by Dan Bernstein.
1105
1106         * Scripts/bisect-builds:
1107         (mountAndRunNightly): Switched back to using backticks to run
1108         the hdiutil command since exec() will terminate the existing
1109         script, which is not what we want.  Store the output of
1110         File::Spec->devnull() in a variable for use in the hdiutil
1111         detach commands.
1112
1113 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1114
1115         Reviewed by Kenneth Rohde Christiansen.
1116
1117         Include "config.h" to meet Coding Style Guidelines
1118         https://bugs.webkit.org/show_bug.cgi?id=31792
1119
1120         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
1121         * DumpRenderTree/qt/jsobjects.cpp:
1122         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1123
1124 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1125
1126         Reviewed by Oliver Hunt.
1127
1128         Implement new required function to pass test we used to pass. This
1129         change is required since r51294.
1130
1131         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1132         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1133
1134 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
1135
1136         Reviewed by Kenneth Rohde Christiansen.
1137
1138         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
1139         https://bugs.webkit.org/show_bug.cgi?id=31775
1140
1141         LayoutTestController::dumpBackForwardList() should work with local URLs
1142         as well as with normal URLs (in http tests for instance).
1143         Currently it does not output the latter properly.
1144
1145         Unskip a bunch of passing http/navigation tests.
1146
1147         * DumpRenderTree/qt/DumpRenderTree.cpp:
1148         (WebCore::dumpHistoryItem):
1149
1150 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
1151
1152         Reviewed by Oliver Hunt.
1153
1154         ARIA: support aria-flowto
1155         https://bugs.webkit.org/show_bug.cgi?id=31762
1156
1157         * DumpRenderTree/AccessibilityUIElement.cpp:
1158         (ariaFlowToElementAtIndexCallback):
1159         (AccessibilityUIElement::getJSClass):
1160         * DumpRenderTree/AccessibilityUIElement.h:
1161         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1162         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1163         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1164         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1165         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1166         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1167
1168 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
1169
1170         Reviewed by Kenneth Christiansen.
1171
1172         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
1173         https://bugs.webkit.org/show_bug.cgi?id=31638
1174
1175         Unfreeze WorkQueue after each test execution.
1176
1177         * DumpRenderTree/qt/DumpRenderTree.cpp:
1178         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1179
1180 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
1181
1182         Reviewed by Adam Barth.
1183
1184         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
1185         for localhost and 127.0.0.1.
1186         https://bugs.webkit.org/show_bug.cgi?id=31783
1187
1188         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
1189
1190         * DumpRenderTree/qt/DumpRenderTree.cpp:
1191         (WebCore::NetworkAccessManager::NetworkAccessManager):
1192         (WebCore::NetworkAccessManager::sslErrorsEncountered):
1193         (WebCore::WebPage::WebPage):
1194         * DumpRenderTree/qt/DumpRenderTree.h:
1195
1196 2009-11-22  Chris Evans  <cevans@chromium.org>
1197
1198         Reviewed by Adam Barth.
1199
1200         Disable access to file:/// directory listings
1201         https://bugs.webkit.org/show_bug.cgi?id=31329
1202
1203         Implemented setAllowUniversalAccessFromFileURLs to support testing of
1204         file URL security.
1205
1206         * DumpRenderTree/LayoutTestController.cpp:
1207         (setAllowUniversalAccessFromFileURLsCallback):
1208         (LayoutTestController::staticFunctions):
1209         * DumpRenderTree/LayoutTestController.h:
1210         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1211         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1212         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1213         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1214         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1215         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1216         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1217         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1218
1219 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
1220
1221         Reviewed by Kenneth Rohde Christiansen.
1222
1223         [Qt] Fix the timeout of fast/frames/frame-navigation.html
1224         https://bugs.webkit.org/show_bug.cgi?id=31638
1225
1226         The test is timeouting, because it uses the WorkQueue to load a document in one
1227         of the child frames and once the loading is finished, the DRT does not dump the
1228         tree. This is because it waits for the QWebFrame::loadFinished() signal from
1229         the main frame, while it should connect to QWebPage::loadFinished().
1230
1231         * DumpRenderTree/qt/DumpRenderTree.cpp:
1232         (WebCore::DumpRenderTree::DumpRenderTree):
1233
1234 2009-11-21  Eric Seidel  <eric@webkit.org>
1235
1236         Reviewed by Adam Barth.
1237
1238         bugzilla-tool --help spews way too much text
1239         https://bugs.webkit.org/show_bug.cgi?id=31771
1240
1241         * Scripts/bugzilla-tool:
1242          - Remove self.cached_scm initialization hack.
1243         * Scripts/modules/buildbot.py:
1244          - Make default_host accessible to callers.
1245         * Scripts/modules/commands/download.py:
1246          - Phrase help for all commands consistently and remove spurious help text punctuation.
1247         * Scripts/modules/commands/queries.py: Ditto.
1248         * Scripts/modules/commands/queues.py: Ditto.
1249         * Scripts/modules/commands/upload.py: Ditto.
1250         * Scripts/modules/multicommandtool.py:
1251          - Add HelpPrintingOptionParser.format_epilog to replace
1252            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
1253            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
1254          - Make --help only show a list of commands like "svn help" and "git help" do --
1255            previously --help was listing all commands and options.
1256          - Sort list of commands alphabetically.
1257
1258 2009-11-21  Eric Seidel  <eric@webkit.org>
1259
1260         No review.  Fixing a typo from the previous patch for bug 31767.
1261
1262         AbstractQueue.run_bugzilla_tool throws an exception
1263         https://bugs.webkit.org/show_bug.cgi?id=31769
1264
1265         * Scripts/modules/commands/queues.py:
1266
1267 2009-11-21  Eric Seidel  <eric@webkit.org>
1268
1269         Reviewed by Adam Barth.
1270
1271         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
1272         https://bugs.webkit.org/show_bug.cgi?id=31767
1273
1274         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
1275         Since we don't have a good way to test BugzillaTool pieces, I've
1276         left out a test for now.
1277
1278         * Scripts/bugzilla-tool:
1279          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
1280         * Scripts/modules/commands/queues.py:
1281          - Use tool.path() instead of __file__.
1282         * Scripts/modules/multicommandtool.py:
1283          - Add a new path() method to MultiComandTool.
1284         * Scripts/modules/multicommandtool_unittest.py:
1285          - Provide a path() method.  Little point in testing this mock implementation.
1286
1287 2009-11-21  Adam Barth  <abarth@webkit.org>
1288
1289         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
1290         WebKitTools.
1291
1292         * Scripts/modules/commands/download.py:
1293
1294 2009-11-21  Adam Barth  <abarth@webkit.org>
1295
1296         Reviewed by Eric Seidel.
1297
1298         Convert check-style to use LandingSequence
1299         https://bugs.webkit.org/show_bug.cgi?id=31763
1300
1301         Instead of manipulating the working copy by hand, we should use the
1302         LandingSequence in CheckStyle.  This will make this code eaiser to
1303         test.
1304
1305         * Scripts/modules/commands/download.py:
1306
1307 2009-11-20  Adam Barth  <abarth@webkit.org>
1308
1309         Reviewed by Eric Seidel.
1310
1311         Unit test query commands
1312         https://bugs.webkit.org/show_bug.cgi?id=31755
1313
1314         These tests are pretty rough, but hopefully they'll grow.
1315
1316         * Scripts/modules/commands/queries_unittest.py: Added.
1317         * Scripts/modules/mock_bugzillatool.py: Added.
1318         * Scripts/run-webkit-unittests:
1319
1320 2009-11-20  Eric Seidel  <eric@webkit.org>
1321
1322         Reviewed by Adam Barth.
1323
1324         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
1325         https://bugs.webkit.org/show_bug.cgi?id=31758
1326
1327         * Scripts/modules/multicommandtool.py:
1328          - Allow passing of explicit commands to MultiCommandTool.__init__
1329         * Scripts/modules/multicommandtool_unittest.py:
1330          - Use new Command.name naming system.
1331          - Test Command auto-discovery.
1332         * Scripts/modules/workqueue.py:
1333          - bug_id no longer exists, use patch['bug_id'] instead.
1334         * Scripts/modules/workqueue_unittest.py:
1335          - WorkQueues require names now.
1336          - should_proceed_with_work_item must return a patch object.
1337
1338 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
1339
1340         Reviewed by Beth Dakin.
1341
1342         WAI-ARIA: add support for aria-owns
1343         https://bugs.webkit.org/show_bug.cgi?id=31702
1344
1345         * DumpRenderTree/AccessibilityUIElement.cpp:
1346         (ariaOwnsElementAtIndexCallback):
1347         (AccessibilityUIElement::getJSClass):
1348         * DumpRenderTree/AccessibilityUIElement.h:
1349         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1350         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1351         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1352         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1353         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1354         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1355
1356 2009-11-20  Eric Seidel  <eric@webkit.org>
1357
1358         Reviewed by Adam Barth.
1359
1360         Fix exception thrown when running the commit-queue.
1361
1362         * Scripts/modules/statusbot.py: patch is optional.
1363         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
1364
1365 2009-11-20  Eric Seidel  <eric@webkit.org>
1366
1367         Reviewed by Adam Barth.
1368
1369         Teach the StatusBot how to support more than just the commit-queue
1370         https://bugs.webkit.org/show_bug.cgi?id=31754
1371
1372         * Scripts/modules/workqueue.py: Another typo.
1373
1374 2009-11-20  Eric Seidel  <eric@webkit.org>
1375
1376         Reviewed by Adam Barth.
1377
1378         Teach the StatusBot how to support more than just the commit-queue
1379         https://bugs.webkit.org/show_bug.cgi?id=31754
1380
1381         * Scripts/modules/commands/queues.py: Fix silly typo.
1382
1383 2009-11-20  Eric Seidel  <eric@webkit.org>
1384
1385         Reviewed by Adam Barth.
1386
1387         Teach the StatusBot how to support more than just the commit-queue
1388         https://bugs.webkit.org/show_bug.cgi?id=31754
1389
1390         * CommitQueueStatus/index.yaml:
1391          - Add indices required for the new queries.
1392         * CommitQueueStatus/queue_status.py:
1393          - Add a patch-status page and move update_status to update-status.
1394          - Only display "commit-queue" status records for the commit-queue.
1395          - Add support for a queue_name property on status records.
1396          - Fix _int_from_request to actually work.
1397         * CommitQueueStatus/update_status.html:
1398          - Add support for a queue_name on status records.
1399          - Remove unused list of bug ids.
1400          * Scripts/modules/commands/queues.py
1401           - Make the queues pass the patch instead of the bug_id to StatusBot.
1402         * Scripts/modules/statusbot.py:
1403          - Support passing the queue_name to the status updates.
1404          - Support fetching patch status with patch_status().
1405         * Scripts/modules/workqueue.py:
1406          - Pass the patch to the StatusBot instead of the bug_id.
1407          - Let WorkQueues have a name.
1408
1409 2009-11-20  Adam Barth  <abarth@webkit.org>
1410
1411         Reviewed by Eric Seidel.
1412
1413         Move bugzilla-tool commands into their own file
1414         https://bugs.webkit.org/show_bug.cgi?id=31752
1415
1416         This will let us write unit tests.
1417
1418         * Scripts/bugzilla-tool:
1419         * Scripts/modules/commands/__init__.py: Added.
1420         * Scripts/modules/commands/download.py: Added.
1421         * Scripts/modules/commands/queries.py: Added.
1422         * Scripts/modules/commands/queues.py: Added.
1423         * Scripts/modules/commands/upload.py: Added.
1424         * Scripts/modules/grammar.py: Added.
1425
1426 2009-11-20  Adam Barth  <abarth@webkit.org>
1427
1428         Reviewed by Eric Seidel.
1429
1430         BuildQueue should check if the tree is currently buildable
1431         https://bugs.webkit.org/show_bug.cgi?id=31744
1432
1433         * Scripts/bugzilla-tool:
1434         * Scripts/modules/landingsequence.py:
1435         * Scripts/modules/webkitlandingscripts.py:
1436
1437 2009-11-20  Adam Barth  <abarth@webkit.org>
1438
1439         Reviewed by Eric Seidel.
1440
1441         Move prepare_clean_working_directory into the LandingSequence
1442         https://bugs.webkit.org/show_bug.cgi?id=31743
1443
1444         * Scripts/bugzilla-tool:
1445         * Scripts/modules/landingsequence.py:
1446
1447 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
1448
1449         Reviewed by Kenneth Rohde Christiansen.
1450
1451         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
1452         https://bugs.webkit.org/show_bug.cgi?id=30460
1453
1454         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
1455
1456         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1457         (pluginInvoke):
1458
1459 2009-11-20  Adam Barth  <abarth@webkit.org>
1460
1461         Reviewed by Eric Seidel.
1462
1463         Pass the port information to the child process
1464         https://bugs.webkit.org/show_bug.cgi?id=31736
1465
1466         We need to do this so the child process knows what to build!
1467
1468         * Scripts/bugzilla-tool:
1469         * Scripts/modules/landingsequence.py:
1470         * Scripts/modules/webkitport.py:
1471         * Scripts/modules/webkitport_unittest.py:
1472
1473 2009-11-20  Adam Barth  <abarth@webkit.org>
1474
1475         Reviewed by Eric Seidel.
1476
1477         Support Qt port in build-queue
1478         https://bugs.webkit.org/show_bug.cgi?id=31733
1479
1480         * Scripts/bugzilla-tool:
1481
1482 2009-11-20  Adam Barth  <abarth@webkit.org>
1483
1484         Reviewed by Eric Seidel.
1485
1486         Implement a build-queue
1487         https://bugs.webkit.org/show_bug.cgi?id=31725
1488
1489         Currently this just builds the first 10 patches in the review queue.
1490         We'll want to do something smarter soon.
1491
1492         * Scripts/bugzilla-tool:
1493
1494 2009-11-20  Adam Barth  <abarth@webkit.org>
1495
1496         Reviewed by Eric Seidel.
1497
1498         Make commit-queue and style-queue show up in help
1499         https://bugs.webkit.org/show_bug.cgi?id=31724
1500
1501         We need to store their names on their class to make these commands
1502         properly register themselves with MultiCommandTool.
1503
1504         * Scripts/bugzilla-tool:
1505
1506 2009-11-20  Adam Barth  <abarth@webkit.org>
1507
1508         Reviewed by Eric Seidel.
1509
1510         Implement bugzilla-tool build-attachment
1511         https://bugs.webkit.org/show_bug.cgi?id=31722
1512
1513         This command builds an attachment from bugzilla.  It leaves the built
1514         patch in the working copy.
1515
1516         * Scripts/bugzilla-tool:
1517         * Scripts/modules/landingsequence.py:
1518         * Scripts/modules/webkitlandingscripts.py:
1519
1520 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
1521
1522         Reviewed by Xan Lopez.
1523
1524         [GTK] DRT release event does not create the state correctly
1525         https://bugs.webkit.org/show_bug.cgi?id=31717
1526
1527         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1528
1529 2009-11-20  Eric Seidel  <eric@webkit.org>
1530
1531         Reviewed by Adam Barth.
1532
1533         MultiCommandTool should find Command objects automatically instead of with a manual list
1534         https://bugs.webkit.org/show_bug.cgi?id=31710
1535
1536         * Scripts/bugzilla-tool:
1537         * Scripts/modules/multicommandtool.py:
1538          - Use some wild python-fu to crawl all the known subclasses of Command.
1539
1540 2009-11-20  Adam Barth  <abarth@webkit.org>
1541
1542         Unreviewed "build" fix.  Added missing import.
1543
1544         * Scripts/bugzilla-tool:
1545
1546 2009-11-20  Adam Barth  <abarth@webkit.org>
1547
1548         Unreviewed "build" fix.  I failed to update LandingSequence.test
1549         properly.
1550
1551         * Scripts/modules/landingsequence.py:
1552
1553 2009-11-20  Adam Barth  <abarth@webkit.org>
1554
1555         Reviewed by Eric Seidel.
1556
1557         Create LandingSequence as the all-sing, all-dance landing class
1558         https://bugs.webkit.org/show_bug.cgi?id=31709
1559
1560         Client can inherit from this class to carefully control exactly which
1561         steps they wish to have happen in the landing sequence.
1562
1563         * Scripts/bugzilla-tool:
1564         * Scripts/modules/landingsequence.py: Added.
1565         * Scripts/modules/webkitlandingscripts.py: Added.
1566
1567 2009-11-19  Adam Barth  <abarth@webkit.org>
1568
1569         Reviewed by Eric Seidel.
1570
1571         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
1572         https://bugs.webkit.org/show_bug.cgi?id=31707
1573
1574         This is to help when we implement build-attachment.
1575
1576         * Scripts/bugzilla-tool:
1577
1578 2009-11-19  Adam Barth  <abarth@webkit.org>
1579
1580         Reviewed by Eric Seidel.
1581
1582         Support Qt port in bugzilla-tool
1583         https://bugs.webkit.org/show_bug.cgi?id=31701
1584
1585         Now we support building with Qt!
1586
1587         * Scripts/bugzilla-tool:
1588         * Scripts/modules/webkitport.py: Added.
1589         * Scripts/modules/webkitport_unittest.py: Added.
1590         * Scripts/run-webkit-unittests:
1591
1592 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
1593
1594         Reviewed by Adam Barth.
1595
1596         Remove inserting stderr into patch in bugzilla-tool
1597         https://bugs.webkit.org/show_bug.cgi?id=29914
1598
1599         Modify SCM python module's run_command function to avoid return of stderr
1600         by default, so stderr won't be inserted into the patches.
1601         Modify the related unit test.
1602
1603         * Scripts/modules/scm.py:
1604         * Scripts/modules/scm_unittest.py:
1605
1606 2009-11-19  Eric Seidel  <eric@webkit.org>
1607
1608         Reviewed by Adam Barth.
1609
1610         bugzilla-tool needs per-command help
1611         https://bugs.webkit.org/show_bug.cgi?id=31697
1612
1613         Added support for "bugzilla-tool help command-name"
1614         and a unit test to make sure it works.
1615
1616         * Scripts/modules/multicommandtool.py:
1617         * Scripts/modules/multicommandtool_unittest.py:
1618
1619 2009-11-19  Eric Seidel  <eric@webkit.org>
1620
1621         Reviewed by Adam Barth.
1622
1623         Move MultiCommandTool and Command into a separate file and add some basic unit tests
1624         https://bugs.webkit.org/show_bug.cgi?id=31695
1625
1626         * Scripts/bugzilla-tool:
1627         * Scripts/modules/multicommandtool.py: Added.
1628         * Scripts/modules/multicommandtool_unittest.py: Added.
1629         * Scripts/run-webkit-unittests:
1630
1631 2009-11-19  Eric Seidel  <eric@webkit.org>
1632
1633         No review, just adding a FIXME.
1634
1635         Split out command parsing and help printing from BugzillaTool
1636         https://bugs.webkit.org/show_bug.cgi?id=31688
1637
1638         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
1639
1640 2009-11-19  Eric Seidel  <eric@webkit.org>
1641
1642         Reviewed by Adam Barth.
1643
1644         Split out command parsing and help printing from BugzillaTool
1645         https://bugs.webkit.org/show_bug.cgi?id=31688
1646
1647         * Scripts/bugzilla-tool:
1648          - Add new MultiCommandTool class to contain option parsing and help printing logic.
1649          - Rename private methods to use _ pattern.
1650          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
1651          - 
1652
1653 2009-11-19  Eric Seidel  <eric@webkit.org>
1654
1655         Reviewed by Adam Barth.
1656
1657         Re-factor help printing to use modern python idioms
1658         https://bugs.webkit.org/show_bug.cgi?id=31685
1659
1660         * Scripts/bugzilla-tool:
1661
1662 2009-11-19  Eric Seidel  <eric@webkit.org>
1663
1664         Reviewed by Darin Adler.
1665
1666         commit-queue empty queue logs twice
1667         https://bugs.webkit.org/show_bug.cgi?id=31679
1668
1669         * Scripts/bugzilla-tool:
1670
1671 2009-11-19  Eric Seidel  <eric@webkit.org>
1672
1673         Reviewed by Darin Adler.
1674
1675         bugzilla-tool's reviewer/committer rejection message should be clearer
1676         https://bugs.webkit.org/show_bug.cgi?id=31126
1677
1678         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
1679
1680         * Scripts/modules/bugzilla.py:
1681
1682 2009-11-19  Eric Z. Ayers  <zundel@google.com>
1683
1684         Reviewed by Pavel Feldman.
1685
1686         Forces a WM_PAINT event on calling layoutTestController.display()
1687         in order to enable the timeline-paint.html test on Windows.
1688         ::UpdateWindow() does not force an event becaue the window is 
1689         not visible.
1690
1691         https://bugs.webkit.org/show_bug.cgi?id=31402
1692
1693         * DumpRenderTree/win/DumpRenderTree.cpp:
1694         (displayWebView):
1695
1696 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
1697
1698         No review needed.
1699
1700         Added myself to committers list.
1701
1702         * Scripts/modules/committers.py:
1703
1704 2009-11-19  Adam Barth  <abarth@webkit.org>
1705
1706         Reviewed by Eric Seidel.
1707
1708         Bugzilla-tool command classes should match command names
1709         https://bugs.webkit.org/show_bug.cgi?id=31666
1710
1711         I renamed all the commands except CommitMessageForCurrentDiff because
1712         the new name would conflict with an existing class.
1713
1714         * Scripts/bugzilla-tool:
1715
1716 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
1717
1718         Reviewed by Gustavo Noronha Silva.
1719
1720         Web Inspector: Implement "show inspector" in WebKit GTK
1721         API and enable console tests.
1722
1723         https://bugs.webkit.org/show_bug.cgi?id=31669
1724
1725         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1726         (LayoutTestController::showWebInspector):
1727
1728 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1729
1730         Reviewed by Simon Hausmann.
1731
1732         Minor refactoring + more documentation.
1733
1734         * DumpRenderTree/qt/DumpRenderTree.cpp:
1735         (WebCore::clearHistory):
1736         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1737
1738 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
1739
1740         Reviewed by Eric Seidel.
1741
1742         Ignore websocket tests when --no-http is specified.
1743         https://bugs.webkit.org/show_bug.cgi?id=31662
1744
1745         * Scripts/run-webkit-tests:
1746
1747 2009-11-18  Adam Barth  <abarth@webkit.org>
1748
1749         Reviewed by Eric Seidel.
1750
1751         Normalize ' and " in bugzilla-tool
1752         https://bugs.webkit.org/show_bug.cgi?id=31655
1753
1754         We decided " is better than ' and we should be consistent.
1755
1756         * Scripts/bugzilla-tool:
1757
1758 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1759
1760         Reviewed by Kenneth Rohde Christiansen.
1761
1762         [Qt] Remove support for Qt v4.3 or older versions
1763         https://bugs.webkit.org/show_bug.cgi?id=29469
1764
1765         * DumpRenderTree/qt/DumpRenderTree.pro:
1766         * DumpRenderTree/qt/ImageDiff.pro:
1767
1768 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1769
1770         Reviewed by Eric Seidel.
1771
1772         GitTest.test_create_binary_patch fails if /tmp is symlink
1773         https://bugs.webkit.org/show_bug.cgi?id=31536
1774
1775         * Scripts/modules/scm_unittest.py:
1776
1777 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
1778
1779         Reviewed by Darin Adler.
1780
1781         Configuration for Chromium Build Slaves.
1782
1783         https://bugs.webkit.org/show_bug.cgi?id=31442
1784
1785         * BuildSlaveSupport/build.webkit.org-config/config.json:
1786         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1787
1788 2009-11-18  Eric Seidel  <eric@webkit.org>
1789
1790         Reviewed by Darin Adler.
1791
1792         workqueue.py results in totally broken commit-queue UI
1793         https://bugs.webkit.org/show_bug.cgi?id=31645
1794
1795         * Scripts/bugzilla-tool:
1796          - Remove unneeded use of PatchCollection.
1797          - Grab a new copy of the cq'd patches every run of the queue.
1798
1799 2009-11-18  Sam Weinig  <sam@webkit.org>
1800
1801         Reviewed by Anders Carlsson.
1802
1803         Make the Mac Geolocation API async.
1804
1805         Update DRT to use the new async Mac Geolocation API.
1806
1807         * DumpRenderTree/mac/UIDelegate.mm:
1808         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1809
1810 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1811
1812         Reviewed by Kenneth Rohde Christiansen.
1813
1814         Add and option to toggle HTML5 datalist support to build-webkit
1815         https://bugs.webkit.org/show_bug.cgi?id=31599
1816
1817         * Scripts/build-webkit:
1818
1819 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1820
1821         Reviewed by Kevin Ollivier.
1822
1823         Enable wx plugin support using the Windows implementation as a base.
1824         
1825         https://bugs.webkit.org/show_bug.cgi?id=31636
1826
1827         * wx/build/settings.py:
1828
1829 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1830
1831         Reviewed by Simon Hausmann.
1832
1833         Change the initialization order so that the controllers
1834         will be created before exporting them to the JS DOM window.
1835
1836         * DumpRenderTree/qt/DumpRenderTree.cpp:
1837         (WebCore::DumpRenderTree::DumpRenderTree):
1838
1839 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1840
1841         Reviewed by Simon Hausmann.
1842
1843         Fix a code copy and paste error. m_page should be page.
1844
1845         * DumpRenderTree/qt/DumpRenderTree.cpp:
1846         (WebCore::DumpRenderTree::createWindow):
1847
1848 2009-11-17  Mark Rowe  <mrowe@apple.com>
1849
1850         Reviewed by Alexey Proskuryakov.
1851
1852         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
1853
1854         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
1855         This prevents symlinks from confusing the descendant check.
1856
1857 2009-11-17  Mark Rowe  <mrowe@apple.com>
1858
1859         Reviewed by Alexey Proskuryakov.
1860
1861         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
1862
1863         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
1864         server to be up rather than having run-webkit-tests abort immediately.
1865
1866         * Scripts/run-webkit-tests:
1867
1868 2009-11-17  Eric Seidel  <eric@webkit.org>
1869
1870         Reviewed by Darin Adler.
1871
1872         commit-queue is failing to set reviewer in ChangeLogs
1873         https://bugs.webkit.org/show_bug.cgi?id=31592
1874
1875         * Scripts/bugzilla-tool: Clarify the "applying" log message.
1876         * Scripts/modules/bugzilla.py:
1877          - Add a new _validate_committer_and_reviewer function as a
1878            temporary solution until we can make a real Attachment object
1879            which knows how to fill in its committer/reviewer fields automatically.
1880
1881 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1882
1883         Unreviewed buildbot fix.
1884
1885         Revert part of earlier patch and add comment, as it
1886         was causing timeouts on the buildbot.
1887
1888         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1889         (LayoutTestController::notifyDone):
1890
1891 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1892
1893         Reviewed by Oliver Hunt.
1894
1895         Make the timeout 15 sec as for the other DRT's and make
1896         it print out the same output when a test timeout.
1897
1898         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1899         (LayoutTestController::waitUntilDone):
1900         (LayoutTestController::notifyDone):
1901         (LayoutTestController::timerEvent):
1902
1903 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
1904
1905         Reviewed by Timothy Hatcher.
1906
1907         Fixed typos in comments.
1908
1909         * Scripts/modules/committers.py:
1910
1911 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
1912
1913         Reviewed by Timothy Hatcher.
1914
1915         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1916         - Updated DRT to show/close inspector for all tests under /inspector
1917         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1918           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1919         - Removed reload on each inspector test
1920         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1921         inspector for those.
1922         - Reimplemented timeline tests in order to get rid of reload there.
1923         - Moved tests that don't require harness into the fast group.
1924
1925         https://bugs.webkit.org/show_bug.cgi?id=31472
1926
1927         * DumpRenderTree/LayoutTestController.cpp:
1928         (setTimelineProfilingEnabledCallback):
1929         (closeWebInspectorCallback):
1930         (LayoutTestController::staticFunctions):
1931         * DumpRenderTree/LayoutTestController.h:
1932         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1933         (shouldOpenWebInspector):
1934         (runTest):
1935         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1936         (LayoutTestController::setTimelineProfilingEnabled):
1937         * DumpRenderTree/mac/DumpRenderTree.mm:
1938         (shouldOpenWebInspector):
1939         (runTest):
1940         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1941         (LayoutTestController::setTimelineProfilingEnabled):
1942         * DumpRenderTree/win/DumpRenderTree.cpp:
1943         (shouldOpenWebInspector):
1944         (runTest):
1945         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1946         (LayoutTestController::setTimelineProfilingEnabled):
1947
1948 2009-11-17  Oliver Hunt  <oliver@apple.com>
1949
1950         Reviewed by Maciej Stachowiak.
1951
1952         Incorrect use of JavaScriptCore API in DumpRenderTree
1953         https://bugs.webkit.org/show_bug.cgi?id=31577
1954
1955         Return undefined rather than a literal null.
1956
1957         * DumpRenderTree/AccessibilityUIElement.cpp:
1958         (setSelectedTextRangeCallback):
1959         (incrementCallback):
1960         (decrementCallback):
1961         (showMenuCallback):
1962
1963 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1964
1965         Reviewed by Beth Dakin.
1966
1967         AX: aria-labelledby duplicates some of its WAI-ARIA label
1968         https://bugs.webkit.org/show_bug.cgi?id=31565
1969
1970         * DumpRenderTree/AccessibilityUIElement.cpp:
1971         (titleUIElementCallback):
1972         (getIsValidCallback):
1973         (AccessibilityUIElement::getJSClass):
1974
1975 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1976
1977         Reviewed by Simon Hausmann.
1978
1979         r50942 broke output from created windows. Make the
1980         m_enableTextOutput a member of the DRT and not the
1981         WebPage.
1982
1983         * DumpRenderTree/qt/DumpRenderTree.cpp:
1984         (WebCore::WebPage::WebPage):
1985         (WebCore::WebPage::javaScriptAlert):
1986         (WebCore::WebPage::javaScriptConsoleMessage):
1987         (WebCore::WebPage::javaScriptConfirm):
1988         (WebCore::WebPage::javaScriptPrompt):
1989         (WebCore::WebPage::acceptNavigationRequest):
1990         (WebCore::DumpRenderTree::DumpRenderTree):
1991         (WebCore::DumpRenderTree::open):
1992         (WebCore::DumpRenderTree::createWindow):
1993         * DumpRenderTree/qt/DumpRenderTree.h:
1994         (WebCore::DumpRenderTree::setTextOutputEnabled):
1995         (WebCore::DumpRenderTree::isTextOutputEnabled):
1996         (WebCore::WebPage::shouldInterruptJavaScript):
1997         (WebCore::WebPage::isTextOutputEnabled):
1998         (WebCore::WebPage::setViewGeometry):
1999
2000 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2001
2002         Reviewed by Gustavo Noronha Silva.
2003
2004         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
2005         as the implementation is being used by at least Qt and Gtk+.
2006
2007         Update buildsystems as well.
2008
2009         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2010         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
2011         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
2012         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
2013         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2014         * GNUmakefile.am:
2015
2016 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
2017
2018         Reviewed by Alexey Proskuryakov.
2019
2020         Disable wss until all platforms support pyOpenSSL
2021
2022         https://bugs.webkit.org/show_bug.cgi?id=31479
2023
2024         * Scripts/run-webkit-tests:
2025
2026 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
2027
2028         Reviewed by Kenneth Christiansen.
2029
2030         [Qt] Implement load error pages support for Qt's DRT.
2031         https://bugs.webkit.org/show_bug.cgi?id=31509
2032
2033         For now, it will not be a default feature, and layout tests
2034         that want to make use of this have to explicitily call
2035         'handleErrorPages();' for the test source.
2036
2037         Any of the other DumpRenderTree's (mac, win and gtk)
2038         support handling error pages. Qt's will be the first.
2039
2040         * DumpRenderTree/qt/DumpRenderTree.cpp:
2041         (WebCore::WebPage::supportsExtension):
2042         (WebCore::WebPage::extension):
2043         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2044         (LayoutTestController::reset):
2045         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2046         (LayoutTestController::shouldHandleErrorPages):
2047         (LayoutTestController::handleErrorPages):
2048
2049 2009-11-16  Eric Seidel  <eric@webkit.org>
2050
2051         Reviewed by Adam Barth.
2052
2053         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
2054         https://bugs.webkit.org/show_bug.cgi?id=31549
2055
2056         Renamed --commit-queue to --non-interactive in most places
2057         and remove the code in land-patches which is no longer needed.
2058
2059         * Scripts/bugzilla-tool:
2060
2061 2009-11-16  Eric Seidel  <eric@webkit.org>
2062
2063         Reviewed by Adam Barth.
2064
2065         The commit-queue should use land-attachment
2066         https://bugs.webkit.org/show_bug.cgi?id=31548
2067
2068         * Scripts/bugzilla-tool:
2069
2070 2009-11-16  Adam Barth  <abarth@webkit.org>
2071
2072         Reviewed by Eric Seidel.
2073
2074         Convert CommitQueue over to PatchCollection
2075         https://bugs.webkit.org/show_bug.cgi?id=31547
2076
2077         Also fixes a bug in workqueue and adds a test!
2078
2079         * Scripts/bugzilla-tool:
2080         * Scripts/modules/workqueue.py:
2081         * Scripts/modules/workqueue_unittest.py:
2082
2083 2009-11-16  Adam Barth  <abarth@webkit.org>
2084
2085         Reviewed by Eric Seidel.
2086
2087         Move StyleQueue over to using PatchCollection
2088         https://bugs.webkit.org/show_bug.cgi?id=31544
2089
2090         That's what the class it's for.
2091
2092         * Scripts/bugzilla-tool:
2093         * Scripts/modules/patchcollection.py:
2094         * Scripts/modules/patchcollection_unittest.py:
2095
2096 2009-11-16  Eric Seidel  <eric@webkit.org>
2097
2098         Reviewed by Adam Barth.
2099
2100         bugzilla-tool needs a land-attachment command
2101         https://bugs.webkit.org/show_bug.cgi?id=31546
2102
2103         * Scripts/bugzilla-tool:
2104          - Move all the logic into AbstractLandingCommand and
2105            add a new LandAttachment command subclass.
2106          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
2107
2108 2009-11-16  Eric Seidel  <eric@webkit.org>
2109
2110         Reviewed by Adam Barth.
2111
2112         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
2113         https://bugs.webkit.org/show_bug.cgi?id=31543
2114
2115         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
2116
2117         * Scripts/bugzilla-tool:
2118
2119 2009-11-16  Eric Seidel  <eric@webkit.org>
2120
2121         Reviewed by Adam Barth.
2122
2123         Disable the style queue from posting to the commit queue status page.
2124
2125         * Scripts/bugzilla-tool:
2126
2127 2009-11-16  Adam Barth  <abarth@webkit.org>
2128
2129         Reviewed by Eric Seidel.
2130
2131         Implement PatchCollection
2132         https://bugs.webkit.org/show_bug.cgi?id=31541
2133
2134         This class holds a set of patches and lets clients iterate through
2135         them.  Optionally, clients can install a filter.
2136
2137         * Scripts/modules/patchcollection.py: Added.
2138         * Scripts/modules/patchcollection_unittest.py: Added.
2139         * Scripts/run-webkit-unittests:
2140
2141 2009-11-16  Eric Seidel  <eric@webkit.org>
2142
2143         Reviewed by Adam Barth.
2144
2145         bugzilla-tool land-patches will close bugs with patches r=?
2146         https://bugs.webkit.org/show_bug.cgi?id=28230
2147
2148         The commit-queue shouldn't close patches with outstanding reviews on them,
2149         even if many reviewers seem to be against multi-patch bugs.
2150
2151         * Scripts/bugzilla-tool:
2152
2153 2009-11-16  Eric Seidel  <eric@webkit.org>
2154
2155         Reviewed by Adam Barth.
2156
2157         bugzilla-tool check-style should work with attachment ids instead of bug ids
2158         https://bugs.webkit.org/show_bug.cgi?id=31540
2159
2160         * Scripts/bugzilla-tool:
2161
2162 2009-11-16  Eric Seidel  <eric@webkit.org>
2163
2164         Reviewed by Adam Barth.
2165
2166         WorkQueue is the only place that should know about special exit codes
2167         https://bugs.webkit.org/show_bug.cgi?id=31534
2168
2169         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
2170         and add tests for handling exit codes.
2171         I also cleaned up workqueue_unittest.py more.
2172
2173         * Scripts/bugzilla-tool:
2174         * Scripts/modules/workqueue.py:
2175         * Scripts/modules/workqueue_unittest.py:
2176
2177 2009-11-16  Eric Seidel  <eric@webkit.org>
2178
2179         Reviewed by Adam Barth.
2180
2181         Re-factor workqueue_unittest to allow for more than one test.
2182         https://bugs.webkit.org/show_bug.cgi?id=31535
2183
2184         * Scripts/modules/workqueue_unittest.py:
2185
2186 2009-11-16  Eric Seidel  <eric@webkit.org>
2187
2188         Reviewed by Adam Barth.
2189
2190         land-patches needs to be re-factored into smaller chunks
2191         https://bugs.webkit.org/show_bug.cgi?id=31532
2192
2193         * Scripts/bugzilla-tool: fix a couple obvious typos.
2194
2195 2009-11-16  Eric Seidel  <eric@webkit.org>
2196
2197         Reviewed by Adam Barth.
2198
2199         land-patches needs to be re-factored into smaller chunks
2200         https://bugs.webkit.org/show_bug.cgi?id=31532
2201
2202         The next patch will move these methods into WebKitLandingScripts.
2203
2204         * Scripts/bugzilla-tool:
2205          - Split out _land_patch and _close_bug_if_no_active_patches.
2206
2207 2009-11-16  Adam Barth  <abarth@webkit.org>
2208
2209         Reviewed by Eric Seidel.
2210
2211         Fix silly copy-and-paste code.  I am a terrible coder.
2212
2213         * Scripts/modules/bugzilla.py:
2214
2215 2009-11-16  Adam Barth  <abarth@webkit.org>
2216
2217         Reviewed by Eric Seidel.
2218
2219         Implement a StyleQueue
2220         https://bugs.webkit.org/show_bug.cgi?id=31537
2221
2222         The first iteration of the style queue only produces output locally.
2223         There is also a limit of 10 patches because it's not that useful to
2224         iterate through the entire review queue at this point.  We can remove
2225         the limit later.
2226
2227         * Scripts/bugzilla-tool:
2228         * Scripts/modules/bugzilla.py:
2229
2230 2009-11-16  Adam Barth  <abarth@webkit.org>
2231
2232         Reviewed by Eric Seidel.
2233
2234         Unit test WorkQueue
2235         https://bugs.webkit.org/show_bug.cgi?id=31531
2236
2237         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
2238
2239         * Scripts/bugzilla-tool:
2240         * Scripts/modules/statusbot.py:
2241         * Scripts/modules/workqueue.py:
2242         * Scripts/modules/workqueue_unittest.py: Added.
2243         * Scripts/run-webkit-unittests:
2244
2245 2009-11-16  Eric Seidel  <eric@webkit.org>
2246
2247         Reviewed by Adam Barth.
2248
2249         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
2250         https://bugs.webkit.org/show_bug.cgi?id=31530
2251
2252         * Scripts/bugzilla-tool:
2253
2254 2009-11-16  Eric Seidel  <eric@webkit.org>
2255
2256         Reviewed by Adam Barth.
2257
2258         bugzilla-tool needs apply-attachment
2259         https://bugs.webkit.org/show_bug.cgi?id=31528
2260
2261         * Scripts/bugzilla-tool:
2262          - Add ApplyAttachment command.
2263          - Abstract applying code into WebKitApplyingScripts.
2264          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
2265         * Scripts/modules/bugzilla.py:
2266          - Add fetch_attachment and bug_id_for_attachment_id.
2267         * Scripts/modules/bugzilla_unittest.py:
2268          - Add test for new parsing.
2269          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
2270
2271 2009-11-16  Eric Seidel  <eric@webkit.org>
2272
2273         Reviewed by Adam Barth.
2274
2275         Document check-style's use of force_clean.
2276
2277         * Scripts/bugzilla-tool:
2278         * Scripts/modules/scm.py:
2279
2280 2009-11-16  Adam Barth  <abarth@webkit.org>
2281
2282         Reviewed by Eric Seidel.
2283
2284         Move WorkQueue to its own file
2285         https://bugs.webkit.org/show_bug.cgi?id=31529
2286
2287         WorkQueue and WorkQueueDelegate are separate concerns from
2288         bugzilla-tool.  Also added a missing include to logging.py.
2289
2290         * Scripts/bugzilla-tool:
2291         * Scripts/modules/logging.py:
2292         * Scripts/modules/workqueue.py:
2293
2294 2009-11-16  Adam Barth  <abarth@webkit.org>
2295
2296         Reviewed by Eric Seidel.
2297
2298         Move OutputTee to logging.py.
2299
2300         * Scripts/bugzilla-tool:
2301         * Scripts/modules/logging.py:
2302
2303 2009-11-15  Adam Barth  <abarth@webkit.org>
2304
2305         Reviewed by Eric Seidel.
2306
2307         Refactor bugzilla-tool to allow for multiple queues
2308         https://bugs.webkit.org/show_bug.cgi?id=31513
2309
2310         Divide the commit queue class into three class to make creating
2311         additional queues easier.
2312
2313         * Scripts/bugzilla-tool:
2314
2315 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
2316
2317         Reviewed by Eric Seidel.
2318
2319         svn-apply may not handle git patches created by bugzilla-tool
2320         https://bugs.webkit.org/show_bug.cgi?id=31457
2321
2322         * Scripts/modules/scm.py:
2323         * Scripts/modules/scm_unittest.py:
2324
2325 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
2326
2327         Reviewed by Eric Seidel.
2328
2329         bugzilla-tool should post git binary diff
2330         https://bugs.webkit.org/show_bug.cgi?id=31458
2331
2332         Add --binary option to Git.create_patch.
2333
2334         * Scripts/modules/scm.py:
2335         * Scripts/modules/scm_unittest.py:
2336
2337 2009-11-15  Adam Barth  <abarth@webkit.org>
2338
2339         Reviewed by Darin Adler.
2340
2341         Add bugzilla-tool check-style
2342         https://bugs.webkit.org/show_bug.cgi?id=31515
2343
2344         * Scripts/bugzilla-tool:
2345         * Scripts/modules/bugzilla.py:
2346
2347 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2348
2349         Reviewed by Simon Hausmann.
2350
2351         Make the Qt Linux only --valgrind feature, suppress errors
2352         defined in the SuppressedValgrindErrors file.
2353
2354         * Scripts/run-webkit-tests:
2355
2356 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2357
2358         Reviewed by Simon Hausmann.
2359
2360         Set the locale to C and not to the current one in use on the system.
2361
2362         * DumpRenderTree/qt/DumpRenderTree.cpp:
2363         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2364
2365 2009-11-13  Adam Roben  <aroben@apple.com>
2366
2367         Add support for
2368         http/tests/security/isolatedWorld/didClearWindowObject.html
2369
2370         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
2371         window objects in isolated worlds are cleared
2372
2373         Reviewed by Dave Hyatt.
2374
2375         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
2376
2377         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2378         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2379         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
2380         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
2381         Added. Sets a __worldID property on the global object whose value is
2382         the ID of this world.
2383         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
2384         Respond to this new delegate callback by calling through to one of the
2385         above new methods.
2386         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2387         (worldMap): Added. Returns a HashMap containing all the worlds we've
2388         created.
2389         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
2390         haven't kept track of this world.
2391         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
2392         instead of declaring our own.
2393
2394         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
2395
2396         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2397         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
2398         didClearWindowObjectForFrameInStandardWorld.
2399         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
2400         Respond to this new delegate callback by calling through to one of the
2401         below new methods.
2402         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
2403         Added. Sets a __worldID property on the gobal object whose value is
2404         the ID of this world.
2405         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
2406         Added. Moved code here from didClearWindowObject.
2407
2408         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
2409         didClearWindowObjectForFrame* functions.
2410
2411         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2412         (worldMap): Added. Returns a HashMap containing all the worlds we've
2413         created.
2414         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
2415         haven't kept track of this world.
2416         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
2417         instead of declaring our own.
2418
2419 2009-11-13  Adam Roben  <aroben@apple.com>
2420
2421         Finish replacing worldIDs with world objects
2422
2423         The only remaining use of worldIDs was in a method only used by DRT
2424         for the isolated worlds tests.
2425
2426         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
2427
2428         Reviewed by Mark Rowe.
2429
2430         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2431         (LayoutTestController::evaluateScriptInIsolatedWorld):
2432         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2433         (LayoutTestController::evaluateScriptInIsolatedWorld):
2434         Updated for changes to WebFrame. Now holds the map of worldID -> world
2435         at this level instead of making WebKit do it.
2436
2437 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2438
2439         Reviewed by Simon Hausmann.
2440
2441         [Qt] Ensure the DRT does not output anything until first test is run
2442
2443         * DumpRenderTree/qt/DumpRenderTree.cpp:
2444         * DumpRenderTree/qt/DumpRenderTree.h:
2445
2446 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2447
2448         Reviewed by Tor Arne Vestbø.
2449
2450         Clear the undo stack in before each new test run.
2451
2452         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
2453
2454         * DumpRenderTree/qt/DumpRenderTree.cpp:
2455         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2456
2457 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2458
2459         Reviewed by Kenneth Rohde Christiansen.
2460
2461         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
2462
2463         * DumpRenderTree/qt/DumpRenderTree.cpp:
2464         (WebCore::WebPage::resetSettings):
2465         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2466         (LayoutTestController::overridePreference):
2467
2468 2009-11-13  Eric Seidel  <eric@webkit.org>
2469
2470         Reviewed by Adam Barth.
2471
2472         Update committers.py based on svn records
2473         https://bugs.webkit.org/show_bug.cgi?id=31366
2474
2475         This list was generated using validate-committer-lists from
2476         https://bugs.webkit.org/show_bug.cgi?id=30970
2477         and makes committers.py current for committers who have
2478         committed in the last 3 years.
2479
2480         * Scripts/modules/committers.py:
2481
2482 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
2483
2484         Reviewed by Adam Barth.
2485
2486         The document-open.html test was flaky at times. The test invokes the layout test plugin
2487         which in its destroy stream handler opens a new document. This basically tears down the
2488         stream and the associated plugin instance. The pluginLog function in the layout test
2489         plugin attempts to retrieve the window script object on a torn down plugin instance
2490         which crashed consistently on windows in the debugger. The functions which issue
2491         these logs already have a valid window script object. We now have variants of the pluginLog
2492         function which take in a window script object with and without variable arguments. 
2493
2494         https://bugs.webkit.org/show_bug.cgi?id=31067
2495
2496         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2497         (pluginLogWithWindowObject):
2498         (pluginLogWithWindowObjectVariableArgs):
2499         (pluginLog):
2500         (notifyTestCompletion):
2501         (testDocumentOpen):
2502         (testWindowOpen):
2503
2504 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2505
2506         Reviewed by Gustavo Noronha Silva.
2507
2508         https://bugs.webkit.org/show_bug.cgi?id=30997
2509         [Gtk] Implemment AtkDocument
2510
2511         Added testing support.
2512
2513         * DumpRenderTree/AccessibilityUIElement.cpp:
2514         * DumpRenderTree/AccessibilityUIElement.h:
2515         (getDocumentEncodingCallback):
2516         (getDocumentURICallback):
2517         (AccessibilityUIElement::getJSClass):
2518         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2519         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2520         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2521         (AccessibilityUIElement::documentEncoding):
2522         (AccessibilityUIElement::documentURI):
2523
2524 2009-11-12  Adam Roben  <aroben@apple.com>
2525
2526         Replace worldIDs with world objects
2527
2528         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
2529         user scripts/stylesheets and isolated worlds
2530
2531         Reviewed by Sam Weinig.
2532
2533         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2534         (LayoutTestController::addUserScript):
2535         (LayoutTestController::addUserStyleSheet):
2536         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2537         (LayoutTestController::addUserScript):
2538         (LayoutTestController::addUserStyleSheet):
2539         Changed these functions to create a new WebJSWorld each time they're
2540         called and to pass that world to WebKit.
2541
2542 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
2543
2544         Reviewed by Oliver Hunt.
2545
2546         need to implement aria tree roles
2547         https://bugs.webkit.org/show_bug.cgi?id=31284
2548
2549         * DumpRenderTree/AccessibilityUIElement.cpp:
2550         (disclosedRowAtIndexCallback):
2551         (selectedRowAtIndexCallback):
2552         (isEqualCallback):
2553         (isAttributeSettableCallback):
2554         (isActionSupportedCallback):
2555         (disclosedByRowCallback):
2556         (hierarchicalLevelCallback):
2557         (AccessibilityUIElement::getJSClass):
2558         * DumpRenderTree/AccessibilityUIElement.h:
2559         (AccessibilityUIElement::isEqual):
2560         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2561         (AccessibilityUIElement::hierarchicalLevel):
2562         (AccessibilityUIElement::disclosedRowAtIndex):
2563         (AccessibilityUIElement::selectedRowAtIndex):
2564         (AccessibilityUIElement::disclosedByRow):
2565         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2566         (AccessibilityUIElement::getChildAtIndex):
2567         (AccessibilityUIElement::disclosedRowAtIndex):
2568         (AccessibilityUIElement::selectedRowAtIndex):
2569         (AccessibilityUIElement::titleUIElement):
2570         (AccessibilityUIElement::parentElement):
2571         (AccessibilityUIElement::disclosedByRow):
2572         (AccessibilityUIElement::hierarchicalLevel):
2573         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2574         (AccessibilityUIElement::hierarchicalLevel):
2575         (AccessibilityUIElement::disclosedRowAtIndex):
2576         (AccessibilityUIElement::selectedRowAtIndex):
2577         (AccessibilityUIElement::disclosedByRow):
2578
2579 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
2580
2581         Reviewed by Darin Adler.
2582
2583         svn-apply can not handle git binary diffs
2584         https://bugs.webkit.org/show_bug.cgi?id=26830
2585
2586         Support "literal" type git binary diffs.
2587
2588         * Scripts/VCSUtils.pm:
2589         * Scripts/modules/scm_unittest.py:
2590         * Scripts/svn-apply:
2591
2592 2009-11-11  Dmitry Titov  <dimich@chromium.org>
2593
2594         Not reviewed, removing duplicate entry for myself in committers.py.
2595
2596         * Scripts/modules/committers.py:
2597
2598 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
2599
2600         Reviewed by Darin Adler and Mark Rowe.
2601
2602         https://bugs.webkit.org/show_bug.cgi?id=31200
2603         Tests in http/tests/security/mixedContent start to fail when new tests are added
2604
2605         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
2606
2607 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2608
2609         Reviewed by Jan Alonzo.
2610
2611         Create, and display a window for the inspector, for inspector
2612         tests.
2613
2614         Need to also show/hide the inspector window to avoid having
2615         problems with code assuming it is realized
2616         https://bugs.webkit.org/show_bug.cgi?id=31347
2617
2618         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2619         (webInspectorShowWindow):
2620         (webInspectorCloseWindow):
2621         (webInspectorInspectWebView):
2622         (createWebView):
2623
2624 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2625
2626         Unreviewed Qt buildbot fix.
2627
2628         My previous fix was wrong, so revert that change and fix it by
2629         returning when the document of the frame has no document element.
2630         Idea is borrowed from mac and win DRT.
2631
2632         * DumpRenderTree/qt/DumpRenderTree.cpp:
2633         (WebCore::DumpRenderTree::dumpFramesAsText):
2634
2635 2009-11-11  Eric Seidel  <eric@webkit.org>
2636
2637         Reviewed byg Kenneth Rohde Christiansen.
2638
2639         Update Kenneth's committer record to include the email he
2640         uses on lists.webkit.org.
2641
2642         * Scripts/modules/committers.py:
2643
2644 2009-11-11  Eric Seidel  <eric@webkit.org>
2645
2646         Reviewed by Gustavo Noronha Silva.
2647
2648         Several committers use separate email addresses for bugzilla and svn.webkit.org
2649         https://bugs.webkit.org/show_bug.cgi?id=31364
2650
2651         Update records for existing committers to include email addresses
2652         used in svn.webkit.org and lists.webkit.org.
2653         Most committers use the same email address in all 3 places, but some use
2654         separate addresses.  committers.py needs record of each of these addresses.
2655
2656         * Scripts/modules/committers.py:
2657
2658 2009-11-11  Eric Seidel  <eric@webkit.org>
2659
2660         No review, adding second email address for an existing committer.
2661
2662         Add Yong Li's second bugzilla account to his committer record.
2663         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
2664
2665         * Scripts/modules/committers.py:
2666
2667 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2668
2669         Reviewed by Simon Hausmann.
2670
2671         If the frame has no innerText don't append it, and
2672         do not add a newline which breaks some cross platform
2673         results.
2674
2675         * DumpRenderTree/qt/DumpRenderTree.cpp:
2676         (WebCore::DumpRenderTree::dumpFramesAsText):
2677
2678 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2679
2680         Reviewed by Simon Hausmann.
2681
2682         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
2683
2684         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2685         (webkit_test_plugin_new_instance):
2686         (webkit_test_plugin_destroy_instance):
2687         (webkit_test_plugin_destroy_stream):
2688
2689 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2690
2691         Reviewed by Mark Rowe.
2692
2693         Implement the functionality needed by plugins/window-open.html
2694
2695         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2696         (webkit_test_plugin_new_instance):
2697         (webkit_test_plugin_set_window):
2698
2699 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2700
2701         Reviewed by Simon Hausmann.
2702
2703         [Qt] Force -graphicssystem raster and -style windows when running DRT
2704
2705         * DumpRenderTree/qt/main.cpp:
2706         * Scripts/run-webkit-tests:
2707
2708 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2709
2710         Reviewed by Simon Hausmann.
2711
2712         Compute correct library paths for Qt
2713
2714         * Scripts/webkitdirs.pm:
2715
2716 2009-11-10  Mark Rowe  <mrowe@apple.com>
2717
2718         Reviewed by Sam Weinig.
2719
2720         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
2721
2722         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
2723         about the validity of the self-signed certificates used in the regression tests.  We would then add the
2724         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
2725         that had enabled frame load delegate logging this would result in extra log messages being generated,
2726         causing the test to fail.
2727
2728         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
2729         tests.
2730
2731         * DumpRenderTree/mac/DumpRenderTree.mm:
2732         (dumpRenderTree):
2733         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2734         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2735
2736 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2737
2738         Reviewed by Kenneth Rohde Christiansen.
2739
2740         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
2741
2742         * DumpRenderTree/qt/DumpRenderTree.cpp:
2743         (WebCore::DumpRenderTree::DumpRenderTree):
2744
2745 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2746
2747         Reviewed by Jan Alonzo.
2748
2749         [GTK] Remove WebSocket configuration from WebKitWebSettings
2750         https://bugs.webkit.org/show_bug.cgi?id=31244
2751
2752         Follow-up of r50724. Don't set the enable-web-socket property
2753         anymore.
2754
2755         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2756         (resetDefaultsToConsistentValues):
2757
2758 2009-11-10  Oliver Hunt  <oliver@apple.com>
2759
2760         Reviewed by Maciej Stachowiak.
2761
2762         Rename 3D Canvas related classes to use WebGL prefix
2763         https://bugs.webkit.org/show_bug.cgi?id=29095
2764
2765         Checkin new version of do-webcore-rename used to do the WebGL type rename,
2766         and upate webkitdirs script to new method of testing for WebGL.
2767
2768         * Scripts/do-webcore-rename:
2769         * Scripts/webkitdirs.pm:
2770
2771 2009-11-09  Oliver Hunt  <oliver@apple.com>
2772
2773         Reviewed by Geoff Garen.
2774
2775         Make do-webcore-rename work with git.
2776
2777         * Scripts/do-webcore-rename:
2778
2779 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2780
2781         Adding Kenneth to the reviewers list.
2782
2783         * Scripts/modules/committers.py:
2784
2785 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2786
2787         Reviewed by Jan Alonzo.
2788
2789         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2790         https://bugs.webkit.org/show_bug.cgi?id=30482
2791
2792         LayoutTestControllerGtk now uses the exposed
2793         Page::tabKeyCyclesThroughElements API
2794
2795         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2796         (LayoutTestController::setTabKeyCyclesThroughElements):
2797
2798 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
2799
2800         Reviewed by Holger Freyther.
2801
2802         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
2803         This helps to pass the test case below. Also replaced hardcoded
2804         code numbers with defined constants.
2805         https://bugs.webkit.org/show_bug.cgi?id=31185
2806         
2807         Test: editing/undo/undo-deleteWord.html
2808
2809         * DumpRenderTree/qt/EventSenderQt.cpp:
2810         (EventSender::keyDown):
2811
2812 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
2813
2814         Reviewed by Holger Freyther.
2815
2816         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
2817         https://bugs.webkit.org/show_bug.cgi?id=31164
2818
2819         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
2820
2821         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2822         (LayoutTestController::processWork):
2823
2824 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
2825
2826         Reviewed by Holger Freyther.
2827
2828         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
2829         https://bugs.webkit.org/show_bug.cgi?id=31158
2830
2831         By invoking a script queue'd by queueScript(), 'true' was beeing returned
2832         always, which from WorkQueue prospective means that a load has been started
2833         and the queue processing should stop and wait for the load to finish.
2834         Spinning it off into a loading and a non-loading variants was the solution
2835         adopted by Mac's DRT to work around this problem. The former keeps returning
2836         'true' while the later executes the script synchronously and returns 'false'
2837         making it possible to the WorkQueue to proceed right away.
2838
2839         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2840         (LayoutTestController::processWork):
2841         (LayoutTestController::queueLoadingScript):
2842         (LayoutTestController::queueNonLoadingScript):
2843         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2844         * DumpRenderTree/qt/WorkQueueItem.h:
2845         (LoadingScriptItem::LoadingScriptItem):
2846         (LoadingScriptItem::invoke):
2847         (NonLoadingScriptItem::NonLoadingScriptItem):
2848         (NonLoadingScriptItem::invoke):
2849
2850 2009-11-07  Mark Rowe  <mrowe@apple.com>
2851
2852         Rubber-stamped by Cameron Zwarich.
2853
2854         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
2855
2856         * Scripts/commit-log-editor:
2857
2858 2009-11-07  Mark Rowe  <mrowe@apple.com>
2859
2860         Reviewed by Darin Adler.
2861
2862         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
2863         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
2864
2865         Move logic for determining the name and email address to use in a ChangeLog entry from
2866         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
2867         whether the author of the patch matches committer, and therefore needs access to the
2868         email address that would be used in a ChangeLog entry.
2869
2870         Based on a patch by Pierre d'Herbemont.
2871
2872         * Scripts/VCSUtils.pm:
2873         * Scripts/commit-log-editor:
2874         * Scripts/prepare-ChangeLog:
2875         * Scripts/webkitdirs.pm:
2876
2877 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2878
2879         Reviewed by Adam Barth.
2880
2881         Added functionality to the layout test plugin to invoke document.open and
2882         window.open with default arguments. The associated webkit bug is
2883         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
2884         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
2885         work in Chromium (V8) if there is no calling javascript context. To achieve this
2886         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
2887         for the window.open test case and in NPP_DestroyStream for the document.open test case.
2888
2889         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2890         (testDocumentOpen):
2891         (testWindowOpen):
2892         (pluginAllocate):
2893         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2894         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2895         (NPP_New):
2896         (NPP_SetWindow):
2897         (NPP_DestroyStream):
2898         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2899         (NPP_New):
2900         (NPP_SetWindow):
2901         (NPP_NewStream):
2902         (NPP_DestroyStream):
2903
2904 2009-11-06  Eric Seidel  <eric@webkit.org>
2905
2906         Reviewed by Adam Barth.
2907
2908         bugzilla-tool crashed with exception
2909         https://bugs.webkit.org/show_bug.cgi?id=31092
2910
2911         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
2912
2913 2009-11-04  Eric Seidel  <eric@webkit.org>
2914
2915         No review, just add a line which got left out of the patch uploaded for commit.
2916
2917         commit-queue is crashing when trying to reject patches after unknown failures
2918         https://bugs.webkit.org/show_bug.cgi?id=31091
2919
2920         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
2921
2922 2009-11-04  Adam Roben  <aroben@apple.com>
2923
2924         Remove bogus else clause in bugzilla-tool
2925
2926         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
2927         create-bug raises exception after entering bug description
2928
2929         Reviewed by David Kilzer.
2930
2931         * Scripts/bugzilla-tool:
2932         (CreateBug): else clauses are only hit if no exception is raised, so
2933         it makes no sense to try to re-raise the exception in an else clause.
2934         The exception will automatically be re-raised if it doesn't match any
2935         of the except clauses, so we don't have to do anything special here at
2936         all to get the desired behavior.
2937
2938 2009-11-04  Eric Seidel  <eric@webkit.org>
2939
2940         Reviewed by David Kilzer.
2941
2942         svn-apply's fixChangeLogPatch function seems broken
2943         https://bugs.webkit.org/show_bug.cgi?id=30683
2944
2945         Update fixChangeLogPatch to be able to handle patches which
2946         don't start at line 1.
2947         Add unit tests for svn-apply to scm_unittest.py.
2948
2949         * Scripts/VCSUtils.pm:
2950         * Scripts/modules/scm_unittest.py:
2951
2952 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
2953
2954         Reviewed by Beth Dakin.
2955
2956         Need to implement ARIA role="combobox"
2957         https://bugs.webkit.org/show_bug.cgi?id=31096
2958
2959         * DumpRenderTree/AccessibilityUIElement.cpp:
2960         (showMenuCallback):
2961         (getIsExpandedCallback):
2962         (AccessibilityUIElement::getJSClass):
2963         * DumpRenderTree/AccessibilityUIElement.h:
2964         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2965         (AccessibilityUIElement::isExpanded):
2966         (AccessibilityUIElement::showMenu):
2967         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2968         (AccessibilityUIElement::isExpanded):
2969         (AccessibilityUIElement::showMenu):
2970         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2971         (AccessibilityUIElement::isSelected):
2972         (AccessibilityUIElement::isExpanded):
2973         (AccessibilityUIElement::showMenu):
2974
2975 2009-11-04  Eric Seidel  <eric@webkit.org>
2976
2977         Reviewed by Adam Barth.
2978
2979         commit-queue is crashing when trying to reject patches after unknown failures
2980         https://bugs.webkit.org/show_bug.cgi?id=31091
2981
2982         * Scripts/bugzilla-tool:
2983          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
2984            so we have to find out what the current patch is by asking bugzilla again.
2985          - Discovered that this code was also leaking file descriptors, so fixed that.
2986
2987 2009-11-04  Adam Roben  <aroben@apple.com>
2988
2989         Make run-webkit-tests work for the Debug_Internal Windows
2990         configuration
2991
2992         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2993         suffix.
2994
2995         Fixes <http://webkit.org/b/31123>.
2996
2997         Reviewed by Sam Weinig.
2998
2999         * Scripts/run-webkit-tests: Don't add the _debug suffix in
3000         Debug_Internal, either.
3001
3002 2009-11-04  Eric Seidel  <eric@webkit.org>
3003
3004         Reviewed by Adam Barth.
3005
3006         committers.py needs a way to store non-bugzilla email addresses
3007         https://bugs.webkit.org/show_bug.cgi?id=31037
3008
3009         Make Committer and Reviewer constructors take a single email or a list of emails.
3010         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
3011         Expose reviewers(), used by validate-committer-lists on bug 30970.
3012
3013         * Scripts/modules/committers.py:
3014         * Scripts/modules/committers_unittest.py: Added tests for the new code.
3015
3016 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
3017
3018         Reviewed by David Levin.
3019
3020         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
3021         https://bugs.webkit.org/show_bug.cgi?id=27491
3022
3023         The test path determination logic is changed to handle websocket and websocket/ssl cases.
3024         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
3025
3026         Functions to start or stop Web Socket servers are added.
3027
3028         * Scripts/run-webkit-tests:
3029
3030 2009-11-03  Eric Seidel  <eric@webkit.org>
3031
3032         No review, just changing wording of log message.
3033
3034         Change log string to say "failed" instead of "rejected"
3035         when a commit fails due to an out of date checkout.
3036         This makes grepping the commit-queue log for rejected patches easier.
3037
3038         * Scripts/bugzilla-tool:
3039
3040 2009-11-03  Eric Seidel  <eric@webkit.org>
3041
3042         No review, adding commonly known committers missing from the file.
3043
3044         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
3045
3046 2009-11-03  Eric Seidel  <eric@webkit.org>
3047
3048         No review, just sort-order cleanup.
3049
3050         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
3051
3052 2009-11-03  Stephen White  <senorblanco@chromium.org>
3053
3054         (Unreviewed).
3055
3056         Add myself to committers.py.
3057
3058         * Scripts/modules/committers.py:
3059
3060 2009-11-03  Robin Dunn  <robin@alldunn.com>
3061
3062         Reviewed by Kevin Ollviier.
3063
3064         Add packaging scripts for Debian-based Linux distros.
3065         
3066         https://bugs.webkit.org/show_bug.cgi?id=31075
3067
3068         * wx/packaging/build-debian-installer.py: Added.
3069         * wx/packaging/debian: Added.
3070
3071 2009-11-03  Dan Bernstein  <mitz@apple.com>
3072
3073         Reviewed by Anders Carlsson and Beth Dakin.
3074
3075         https://bugs.webkit.org/show_bug.cgi?id=31070
3076
3077         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
3078         destroyed, it executes the value of the 'ondestroy' parameter as a
3079         script.
3080
3081         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3082         (pluginAllocate): Initialize onDestroy.
3083         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
3084         onDestroy.
3085         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3086         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
3087         specified.
3088         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
3089
3090 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3091
3092         Reviewed by Xan Lopez.
3093
3094         https://bugs.webkit.org/show_bug.cgi?id=31035
3095         [GTK] some accessibility tests hitting assertion in debug builds
3096
3097         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
3098
3099         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3100         (AccessibilityController::rootElement):
3101
3102 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
3103
3104         Reviewed by Beth Dakin.
3105
3106         Support ARIA "tab" roles
3107         https://bugs.webkit.org/show_bug.cgi?id=30842
3108
3109         * DumpRenderTree/AccessibilityUIElement.cpp:
3110         * DumpRenderTree/AccessibilityUIElement.h:
3111         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3112         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3113         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3114
3115 2009-11-01  Eric Seidel  <eric@webkit.org>
3116
3117         Reviewed by David Levin.
3118
3119         buildbots should use --exit-after-N-failures
3120         https://bugs.webkit.org/show_bug.cgi?id=30809
3121
3122         Make the bots exit after 20 failures to prevent never-ending
3123         test runs where every test spends a minute crashing.
3124
3125         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3126
3127 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3128
3129         Reviewed by Eric Seidel.
3130
3131         Turn on warnings for QtWebKit for gcc
3132         https://bugs.webkit.org/show_bug.cgi?id=30958
3133
3134         * DumpRenderTree/qt/main.cpp: 
3135         (crashHandler): Mark function NO_RETURN
3136
3137 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
3138
3139         Adding myself to the committers list.
3140
3141         * Scripts/modules/committers.py:
3142
3143 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
3144
3145         Fix an issue that Adam noticed in DRT.
3146
3147         Reviewed by Darin Adler.
3148
3149         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3150         (AccessibilityUIElement::role):
3151         Get the length of the role text, and create a buffer dynamically.
3152
3153 2009-10-30  Eric Seidel  <eric@webkit.org>
3154
3155         No review, rolling out r50105.
3156         http://trac.webkit.org/changeset/50105
3157
3158         This commit was causing:
3159         https://bugs.webkit.org/show_bug.cgi?id=30869
3160         We'll re-implement the feature a different way.
3161
3162         * Scripts/bugzilla-tool:
3163
3164 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
3165
3166         Test for MSAA: Accessibility of headings is not correct
3167
3168         https://bugs.webkit.org/show_bug.cgi?id=30937
3169
3170         Reviewed by Adam Roben.
3171
3172         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3173         (AccessibilityUIElement::role):
3174         Allow the role returned to be a BSTR.
3175         (AccessibilityUIElement::description):
3176         Fix a copy/paste error.
3177
3178 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
3179
3180         Test for MSAA: Accessibility of links is wrong
3181
3182         https://bugs.webkit.org/show_bug.cgi?id=30928
3183
3184         Reviewed by Darin Adler.
3185
3186         * DumpRenderTree/AccessibilityUIElement.cpp:
3187         (getAccessibilityValueCallback):
3188         Return the accessibility value.
3189         (AccessibilityUIElement::getJSClass):
3190         Added "accessibilityValue" value.
3191
3192         * DumpRenderTree/AccessibilityUIElement.h:
3193
3194         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3195         (AccessibilityUIElement::accessibilityValue):
3196         Stubbed.
3197
3198         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3199         (AccessibilityUIElement::accessibilityValue):
3200         Stubbed.
3201
3202         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3203         (AccessibilityUIElement::accessibilityValue):
3204         Get the object's value, and return it as a JS string.
3205
3206 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
3207
3208         Fix typo in command name used by wx build system.
3209
3210         * wx/build/build_utils.py:
3211
3212 2009-10-30  Adam Barth  <abarth@webkit.org>
3213
3214         Reviewed by Darin Adler.
3215
3216         Patch v1 is a dumb default name for patches
3217         https://bugs.webkit.org/show_bug.cgi?id=30952
3218
3219         Let's use "Patch" instead.
3220
3221         * Scripts/bugzilla-tool:
3222
3223 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3224
3225         Unreviewed trivial buildfix.
3226
3227         [Qt] Buildfix for r50333.
3228
3229         * DumpRenderTree/qt/DumpRenderTree.pro:
3230
3231 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
3232
3233         Reviewed by Holger Freyther.
3234
3235         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
3236         https://bugs.webkit.org/show_bug.cgi?id=30953
3237
3238         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
3239         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
3240         makes qt DRT to share this implementation (as gtk and mac ports do).
3241
3242         * DumpRenderTree/qt/DumpRenderTree.pro:
3243         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
3244         * DumpRenderTree/qt/WorkQueue.h: Removed.
3245
3246 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3247
3248         Unreviewed potential buildbot fix.
3249
3250         Second try: Reset page history before running each test.
3251
3252         Apparently the QWebHistory::clear() keeps the current page
3253         in history which is not what we want, so we not additionally
3254         sets the history capacity to 0 (forces removing everything)
3255         and then sets it back to its original value.
3256
3257         * DumpRenderTree/qt/DumpRenderTree.cpp:
3258         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3259
3260 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3261
3262         Unreviewed potential buildbot fix.
3263
3264         Reset page history before running each test.
3265
3266         * DumpRenderTree/qt/DumpRenderTree.cpp:
3267         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3268
3269 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
3270
3271         Reviewed by Eric Seidel.
3272
3273         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
3274
3275         Bug 28420 -  Implement HTML5 <ruby> rendering
3276         (https://bugs.webkit.org/show_bug.cgi?id=28420)
3277
3278         No new tests (no functional change).
3279
3280         * Scripts/build-webkit:
3281
3282 2009-10-29  Dan Bernstein  <mitz@apple.com>
3283
3284         Reviewed by Mark Rowe.
3285
3286         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
3287         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
3288         define it.
3289
3290         * Scripts/VCSUtils.pm:
3291         * Scripts/svn-apply:
3292         * Scripts/svn-unapply:
3293
3294 2009-10-29  Xan Lopez  <xlopez@igalia.com>
3295
3296         Reviewed by Gustavo Noronha.
3297
3298         Use the GTK+ main loop instead of rolling our own mini-version of
3299         it.
3300
3301         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3302         (dump):
3303         (runTest):
3304         (webViewLoadFinished):
3305
3306 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3307
3308         Reviewed by Oliver Hunt.
3309
3310         Implement the Qt version of DRT dumpBackForwardList().
3311
3312         * DumpRenderTree/qt/DumpRenderTree.cpp:
3313         (WebCore::dumpHistoryItem):
3314         (WebCore::DumpRenderTree::dumpBackForwardList):
3315
3316 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3317
3318         Reviewed by Adam Roben.
3319
3320         Implement DRT functionality for Qt introduced in
3321         r28690 and r28705.
3322
3323         - Implemented pathToLocalResource which exposes the functionality of
3324         converting a given unix path to the correct location on Windows.
3325         - Implemented a way to remove machine-dependent information from paths
3326         in layout test results.
3327
3328         * DumpRenderTree/qt/DumpRenderTree.cpp:
3329         (WebCore::urlSuitableForTestResult):
3330         (WebCore::WebPage::javaScriptConsoleMessage):
3331         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3332         (LayoutTestController::pathToLocalResource):
3333         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3334
3335 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
3336
3337         Adding myself to the committers list.
3338
3339         * Scripts/modules/committers.py:
3340
3341 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
3342
3343         Adding myself to the committers list.
3344
3345         * Scripts/modules/committers.py:
3346
3347 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3348
3349         Reviewed by Jan Alonzo.
3350
3351         [GTK] API to start inspector for a WebView
3352         https://bugs.webkit.org/show_bug.cgi?id=22551
3353
3354         Use the new inspector API to implement the LayoutTestController
3355         interfaces used to test the inspector.
3356
3357         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3358         (webInspectorInspectWebView):
3359         (createWebView):
3360         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3361         (LayoutTestController::showWebInspector):
3362         (LayoutTestController::closeWebInspector):
3363         (LayoutTestController::evaluateInWebInspector):
3364
3365 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
3366
3367         Reviewed by Eric Seidel.
3368
3369         [Qt] WebFrame::counterValueForElementById must not be exposed
3370         https://bugs.webkit.org/show_bug.cgi?id=30882
3371
3372         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3373         (LayoutTestController::counterValueForElementById):
3374
3375 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3376
3377         Rubberstamped by Oliver Hunt.
3378
3379         Fix the warning:
3380
3381         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
3382         declared with attribute warn_unused_result".
3383
3384         by actually checking the result. In the case it is null, an
3385         error has occoured, so treat it as the other fatal errors.
3386
3387         * DumpRenderTree/qt/DumpRenderTree.cpp:
3388         (WebCore::DumpRenderTree::initializeFonts):
3389
3390 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
3391
3392         Reviewed by Darin Adler.
3393
3394         Provide a way to get counter values with layoutTestContoller
3395         https://bugs.webkit.org/show_bug.cgi?id=30555
3396
3397         Define layoutTestContoller.counterValueForElementById.
3398
3399         * DumpRenderTree/LayoutTestController.cpp:
3400         (counterValueForElementByIdCallback):
3401         (LayoutTestController::staticFunctions):
3402         * DumpRenderTree/LayoutTestController.h:
3403         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3404         (LayoutTestController::counterValueForElementById):
3405
3406 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3407
3408         Rubberstamped by Oliver Hunt.
3409
3410         Change two methods to be internal for DRT use only.
3411
3412         Part of [Qt] Review all new API in Qt 4.6
3413         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
3414
3415         * DumpRenderTree/qt/DumpRenderTree.cpp:
3416         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3417         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3418         (LayoutTestController::whiteListAccessFromOrigin):
3419
3420 2009-10-27  Eric Seidel  <eric@webkit.org>
3421
3422         Reviewed by Adam Barth.
3423
3424         REGRESSION: svn-apply exits(1) when applying a patch with a file add
3425         https://bugs.webkit.org/show_bug.cgi?id=30826
3426
3427         * Scripts/svn-apply:
3428          - Add () around all system() calls.
3429          - Use the correct system() == 0 or die instead of system() or die
3430          - Add descriptive messages to all die statements.
3431
3432 2009-10-27  Steve Block  <steveblock@google.com>
3433
3434         Reviewed by NOBODY.
3435
3436         Adds steveblock@google.com to list of committers.
3437
3438         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
3439
3440 2009-10-27  Eric Seidel  <eric@webkit.org>
3441
3442         Reviewed by Adam Barth.
3443
3444         svn-apply can exit(0) even on patch failure
3445         https://bugs.webkit.org/show_bug.cgi?id=29622
3446
3447         * Scripts/svn-apply:
3448          - Add a bunch of "or die" statements, hopefully catching all
3449            possible cases where failure could still exit(0).
3450
3451 2009-10-27  Eric Seidel  <eric@webkit.org>
3452
3453         Reviewed by Adam Barth.
3454
3455         svn-* scripts should share code through VCSUtils.pm
3456         https://bugs.webkit.org/show_bug.cgi?id=30791
3457
3458         Just moving code into a shared location.
3459
3460         * Scripts/VCSUtils.pm:
3461         * Scripts/prepare-ChangeLog:
3462         * Scripts/resolve-ChangeLogs:
3463         * Scripts/svn-apply:
3464         * Scripts/svn-create-patch:
3465         * Scripts/svn-unapply:
3466         * Scripts/update-webkit:
3467
3468 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
3469
3470         Suppress a huge number of MSVC warnings when building wxWebKit.
3471
3472         * wx/build/settings.py:
3473
3474 2009-10-26  Eric Seidel  <eric@webkit.org>
3475
3476         No review, just adding Mike Belshe to the committers list.
3477
3478         * Scripts/modules/committers.py:
3479
3480 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3481
3482         Reviewed by Darin Adler.
3483
3484         Make .rc files compile on Windows without depending on MFC headers
3485         https://bugs.webkit.org/show_bug.cgi?id=30750
3486
3487         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
3488         windows.h instead of afxres.h because it exists even when MFC is not 
3489         installed, and is all that's needed here.
3490
3491         * FindSafari/FindSafari.rc: Ditto
3492
3493 2009-10-24  Eric Seidel  <eric@webkit.org>
3494
3495         Reviewed by Adam Barth.
3496
3497         bugzilla-tool post-diff should know how to mark commit-queue=?
3498         https://bugs.webkit.org/show_bug.cgi?id=29202
3499
3500         * Scripts/bugzilla-tool:
3501          - Add --commit-queue option to post-diff, post-commits and create-bug.
3502         * Scripts/modules/bugzilla.py:
3503          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
3504          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
3505
3506 2009-10-23  Eric Seidel  <eric@webkit.org>
3507
3508         Reviewed by Adam Barth.
3509
3510         bugzilla-tool commit-queue does not notice modifications to committers.py
3511         https://bugs.webkit.org/show_bug.cgi?id=30084
3512
3513         * Scripts/bugzilla-tool:
3514          - Make commit-queue re-exec itself instead of using while(1).
3515          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
3516          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
3517
3518 2009-10-22  Eric Seidel  <eric@webkit.org>
3519
3520         Reviewed by Adam Barth.
3521
3522         commit-queue will get stuck on patches if land-patches terminates unexpectedly
3523         https://bugs.webkit.org/show_bug.cgi?id=30634
3524
3525         * Scripts/bugzilla-tool:
3526          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
3527          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
3528
3529 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
3530
3531         Reviewed by Eric Seidel.
3532
3533         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
3534
3535         https://bugs.webkit.org/show_bug.cgi?id=30763
3536
3537         * pywebsocket/mod_pywebsocket/__init__.py:
3538         * pywebsocket/mod_pywebsocket/dispatch.py:
3539         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
3540         * pywebsocket/mod_pywebsocket/standalone.py:
3541         * pywebsocket/setup.py:
3542         * pywebsocket/test/test_dispatch.py:
3543
3544 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
3545
3546         Reviewed by David Levin.
3547
3548         REGRESSION: 2 failures in run-webkit-unittests
3549         https://bugs.webkit.org/show_bug.cgi?id=30645
3550
3551         * Scripts/modules/cpp_style_unittest.py:
3552         Fixed a few test scenarios which apparently lost some spaces from 
3553         text literals.
3554
3555 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
3556
3557         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
3558
3559         * Scripts/webkitdirs.pm:
3560
3561 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
3562
3563         Reviewed by Darin Adler.
3564
3565         Unification of using null device in perl scripts.
3566         https://bugs.webkit.org/show_bug.cgi?id=30572
3567
3568         * Scripts/VCSUtils.pm:
3569         * Scripts/bisect-builds:
3570         * Scripts/resolve-ChangeLogs:
3571         * Scripts/run-iexploder-tests:
3572         * Scripts/run-jsc:
3573         * Scripts/run-mangleme-tests:
3574         * Scripts/run-webkit-tests:
3575         * Scripts/webkitdirs.pm:
3576         Using File::Spec->devnull() instead of hard coded /dev/null.
3577
3578 2009-10-26  Eric Seidel  <eric@webkit.org>
3579
3580         Reviewed by Holger Freyther.
3581
3582         Reviewers are missing from committers.py
3583         https://bugs.webkit.org/show_bug.cgi?id=30733
3584
3585         * Scripts/modules/committers.py:
3586
3587 2009-10-23  Eric Seidel  <eric@webkit.org>
3588
3589         No review, only adding Alice to the list of reviewers.
3590
3591         * Scripts/modules/committers.py:
3592
3593 2009-10-23  Eric Seidel  <eric@webkit.org>
3594
3595         Reviewed by Eric Carlson.
3596
3597         fast/media/mq-transform-02.html failed on Leopard Commit Bot
3598         https://bugs.webkit.org/show_bug.cgi?id=30700
3599
3600         * DumpRenderTree/mac/DumpRenderTree.mm:
3601         (resetDefaultsToConsistentValues): Update QuickTime version check.
3602
3603 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
3604
3605         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
3606         character measurement APIs that are private on Tiger.
3607
3608         * wx/build/settings.py:
3609
3610 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3611
3612         Reviewed by NOBODY (build fix).
3613         Build fix following bug #30696.
3614
3615         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3616         (LayoutTestController::evaluateScriptInIsolatedWorld):
3617
3618 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3619
3620         Reviewed by Sam Weinig & Geoff Garen.
3621
3622         https://bugs.webkit.org/show_bug.cgi?id=30696
3623         Enable isolated-worlds tests on mac.
3624
3625         Add private interface for DRT to invoke execution in a given world.
3626
3627         * DumpRenderTree/LayoutTestController.cpp:
3628         (evaluateScriptInIsolatedWorldCallback):
3629         (LayoutTestController::staticFunctions):
3630         * DumpRenderTree/LayoutTestController.h:
3631         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3632         (LayoutTestController::evaluateScriptInIsolatedWorld):
3633         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3634         (LayoutTestController::evaluateScriptInIsolatedWorld):
3635
3636 2009-10-21  Eric Seidel  <eric@webkit.org>
3637
3638         Reviewed by Adam Barth.
3639
3640         bugzilla-tool's "patch failed to download an apply" error should give more information
3641         https://bugs.webkit.org/show_bug.cgi?id=30632
3642
3643         * Scripts/modules/scm.py:
3644          - Use the common run_command method instead of custom POpen code.
3645          - Make run_command know how to take pipes as input.
3646         * Scripts/modules/scm_unittest.py:
3647          - Add new tests to cover change.
3648          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
3649
3650 2009-10-21  Kent Tamura  <tkent@chromium.org>
3651
3652         Unreviewed.  Adding myself to the committers list.
3653
3654         * Scripts/modules/committers.py:
3655
3656 2009-10-21  Robin Dunn  <robin@alldunn.com>
3657
3658         Reviewed by Kevin Ollivier.
3659
3660         Update the Windows installer builder to work with Vista / Win 7 and with git.
3661         
3662         https://bugs.webkit.org/show_bug.cgi?id=30649
3663
3664         * wx/build/build_utils.py:
3665         * wx/packaging/build-mac-installer.py:
3666         * wx/packaging/build-win-installer.py:
3667         * wx/packaging/wxWebKitInstaller.iss.in:
3668
3669 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3670
3671         Reviewed by Gustavo Noronha.
3672
3673         [GTK] Added conditional code to avoid using
3674         gdk_window_get_root_coords if we do not have a gtk+ release newer
3675         than 2.17.3.
3676         https://bugs.webkit.org/show_bug.cgi?id=30636
3677
3678         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3679
3680 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
3681
3682         Reviewed by Eric Seidel.
3683
3684         [Qt] Added dummy implementation for keepWebHistory()
3685         https://bugs.webkit.org/show_bug.cgi?id=30592
3686
3687         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3688         (LayoutTestController::keepWebHistory):
3689         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3690
3691 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3692
3693         Reviewed by Xan Lopez.
3694
3695         [GTK] Fixed the double click condition, it is not double click if
3696         we move in just in one direction.
3697         https://bugs.webkit.org/show_bug.cgi?id=30636
3698
3699         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3700
3701 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3702
3703         Reviewed by Xan Lopez.
3704
3705         [GTK] Initialize the events completly before emitting them.
3706         https://bugs.webkit.org/show_bug.cgi?id=30633
3707
3708         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3709
3710 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3711
3712         wx build fix. Fix for when linking using --as-needed with gcc.
3713
3714         * wx/browser/wscript:
3715
3716 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3717
3718         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
3719         to support all the features used by CURL backend.
3720         
3721         * wx/build/settings.py:
3722         * wx/install-unix-extras:
3723
3724 2009-10-20  Anton Muhin  <antonm@chromium.org>
3725
3726         Reviewed by Adam Barth.
3727
3728         Add {ager,antonm,yurys}@chromium.org into committers.py
3729         https://bugs.webkit.org/show_bug.cgi?id=30560
3730
3731         * Scripts/modules/committers.py:
3732
3733 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3734
3735         Reviewed by Tor Arne Vestbø.
3736
3737         Make the Netscape Test plugin available to the Qt launcher.
3738
3739         * Scripts/run-launcher:
3740
3741 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
3742
3743         Reviewed by David Levin.
3744
3745         Removed WebSocket runtime settings.
3746         https://bugs.webkit.org/show_bug.cgi?id=29896
3747
3748         WebSocket runtime configuration is supported by chromium/v8 only.
3749
3750         * DumpRenderTree/mac/DumpRenderTree.mm:
3751         (resetDefaultsToConsistentValues):
3752         * DumpRenderTree/win/DumpRenderTree.cpp:
3753         (resetDefaultsToConsistentValues):
3754
3755 2009-10-19  Nate Chapin  <japhet@chromium.org>
3756
3757         Reviewed by Adam Barth.
3758
3759         Add testFail() to test plugin so we can test our handling of a
3760         plugin invoke call returning false.
3761
3762         https://bugs.webkit.org/show_bug.cgi?id=30239
3763
3764         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
3765         (pluginInvoke):
3766         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
3767
3768 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
3769
3770         Reviewed by Gustavo Noronha.
3771
3772         Enable DOM pasting when running layout tests.
3773
3774         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3775         (resetDefaultsToConsistentValues):
3776
3777 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3778
3779         Reviewed by Simon Hausmann.
3780
3781         Use the setPreferredContentsSize method instead
3782         of setFixedContentsSize, as the method has been renamed.
3783
3784         * DumpRenderTree/qt/DumpRenderTree.cpp:
3785         (WebCore::DumpRenderTree::open):
3786         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3787         (LayoutTestController::setFixedContentsSize):
3788
3789 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3790
3791         Reviewed by Dan Bernstein.
3792
3793         https://bugs.webkit.org/show_bug.cgi?id=30456
3794         Fixes for new Debug_All Windows build configuration.
3795
3796         * DumpRenderTree/win/DumpRenderTree.cpp:
3797         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
3798         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
3799
3800 2009-10-16  Eric Seidel  <eric@webkit.org>
3801
3802         Reviewed by Adam Barth.
3803
3804         commit-queue status bot should list which buildbot is blocking the queue
3805         https://bugs.webkit.org/show_bug.cgi?id=30452
3806
3807         Add new methods and testing.
3808
3809         * Scripts/bugzilla-tool:
3810         * Scripts/modules/buildbot.py:
3811         * Scripts/modules/buildbot_unittest.py:
3812
3813 2009-10-16  Eric Seidel  <eric@webkit.org>
3814
3815         Reviewed by Adam Barth.
3816
3817         run-webkit-tests fails when CWD is not inside a WebKit checkout
3818         https://bugs.webkit.org/show_bug.cgi?id=30451
3819
3820         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
3821         * Scripts/modules/scm_unittest.py:
3822           - Remove use of original_path (we don't need to restore the CWD).
3823           - Don't use '.' to find the webkit checkout, use __file__ instead.
3824
3825 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3826
3827         Reviewed by Adam Roben.
3828
3829         Add a Debug_All configuration to build entire stack as debug.
3830         Change Debug_Internal to:
3831         - stop using _debug suffix for all WebKit/Safari binaries
3832         - not use _debug as a DLL naming suffix
3833         - use non-debug C runtime lib.
3834
3835         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
3836         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
3837         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
3838         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3839         Add missing debug.vsprops inherited property sheet.
3840         Add Debug_All configuration.
3841         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
3842         * WinLauncher/WinLauncher.vcproj:
3843         Removed extraneous definitions inherited from vsprops.
3844         Add Debug_All configuration.
3845
3846 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
3847
3848         Reviewed by David Levin.
3849
3850         check-webkit-style is wrong about indent checking in namespaces
3851         in header files and a few other things
3852         https://bugs.webkit.org/show_bug.cgi?id=30362
3853
3854         The few other things include:
3855         + check-webkit-style does not require spaces around the equal sign
3856           inside 'if' statements and around binary operators that take 
3857           numeric literals.
3858         + check-webkit-style reports false errors for the / operator
3859           when part of a filename in the #include directive.
3860
3861         * Scripts/modules/cpp_style.py:
3862         Improved indentation checking and space checking around
3863         binary operators. While the checks are still not perfect,
3864         they are clearly better than before.
3865         * Scripts/modules/cpp_style_unittest.py:
3866         Added test cases for the newly supported checks and modified old
3867         test cases to match the new guidelines
3868
3869 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
3870
3871         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
3872
3873         * wx/build/settings.py:
3874
3875 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
3876
3877         Reviewed by David Levin.
3878
3879         Add mod_pywebsocket to test Web Sockets.
3880         http://code.google.com/p/pywebsocket/
3881         https://bugs.webkit.org/show_bug.cgi?id=27490
3882
3883         * pywebsocket/COPYING: Added.
3884         * pywebsocket/MANIFEST.in: Added.
3885         * pywebsocket/README: Added.
3886         * pywebsocket/example/echo_client.py: Added.
3887         * pywebsocket/example/echo_wsh.py: Added.
3888         * pywebsocket/mod_pywebsocket/__init__.py: Added.
3889         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
3890         * pywebsocket/mod_pywebsocket/handshake.py: Added.
3891         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
3892         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
3893         * pywebsocket/mod_pywebsocket/standalone.py: Added.
3894         * pywebsocket/mod_pywebsocket/util.py: Added.
3895         * pywebsocket/setup.py: Added.
3896         * pywebsocket/test/config.py: Added.
3897         * pywebsocket/test/mock.py: Added.
3898         * pywebsocket/test/run_all.py: Added.
3899         * pywebsocket/test/test_dispatch.py: Added.
3900         * pywebsocket/test/test_handshake.py: Added.
3901         * pywebsocket/test/test_mock.py: Added.
3902         * pywebsocket/test/test_msgutil.py: Added.
3903         * pywebsocket/test/test_util.py: Added.
3904         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
3905         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
3906         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
3907         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
3908         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
3909         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
3910         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
3911         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
3912
3913 2009-10-15  James Robinson  <jamesr@google.com>
3914
3915         Reviewed by David Levin.
3916
3917         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
3918
3919         https://bugs.webkit.org/show_bug.cgi?id=30426
3920
3921         * Scripts/modules/cpp_style.py:
3922         * Scripts/modules/cpp_style_unittest.py:
3923
3924 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
3925
3926         Reviewed by Adam Roben.
3927
3928         Fixes <http://webkit.org/b/30411>.
3929         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
3930         
3931         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
3932         building Chromium.
3933
3934         * Scripts/pdevenv:
3935
3936 2009-10-15  Robin Dunn  <robin@alldunn.com>
3937
3938         Reviewed by Kevin Ollivier.
3939
3940         Add Mac package building scripts for wx.
3941         
3942         https://bugs.webkit.org/show_bug.cgi?id=30405
3943
3944         * wx/build/build_utils.py:
3945         * wx/build/settings.py:
3946         * wx/packaging/build-mac-installer.py: Added.
3947
3948 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
3949
3950         Reviewed by Gustavo Noronha.
3951
3952         Enable Web Sockets support when running layout tests.
3953
3954         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3955         (resetDefaultsToConsistentValues):
3956
3957 2009-10-15  Xan Lopez  <xlopez@igalia.com>
3958
3959         Reviewed by Gustavo Noronha.
3960
3961         Need to initialize event.button.button, since in most cases a
3962         button number is not passed as an argument.
3963
3964         * DumpRenderTree/gtk/EventSender.cpp:
3965         (mouseDownCallback):
3966         (mouseUpCallback):
3967
3968 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
3969
3970         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3971         the OS if none was explicitly set.
3972
3973         * wx/build/settings.py:
3974
3975 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
3976
3977         Reviewed by Timothy Hatcher.
3978
3979         Web Inspector: enable developers extras within inspector layout tests.
3980
3981         https://bugs.webkit.org/show_bug.cgi?id=30014
3982
3983         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3984         (LayoutTestController::showWebInspector):
3985         (LayoutTestController::closeWebInspector):
3986         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3987         (LayoutTestController::showWebInspector):
3988         (LayoutTestController::closeWebInspector):
3989
3990 2009-10-14  José Millán Soto  <jmillan@igalia.com>
3991
3992         Reviewed by Jan Alonzo.
3993
3994         GtkLauncher is using a deprecated signal
3995         https://bugs.webkit.org/show_bug.cgi?id=30364
3996
3997         Modified GtkLauncher to use notify::title signal instead of
3998         deprecated title-changed signal
3999
4000         * GtkLauncher/main.c:
4001         (notify_title_cb):
4002         (create_browser):
4003
4004 2009-10-14  Brady Eidson  <beidson@apple.com>
4005
4006         Reviewed by Sam Weinig.
4007
4008         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
4009         1 - Disables WebHistory
4010         2 - Doesn't make sense in that context anyway.
4011
4012         * DumpRenderTree/win/DumpRenderTree.cpp:
4013         (createWebViewAndOffscreenWindow):
4014
4015 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
4016
4017         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
4018         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
4019
4020         * wx/build/settings.py:
4021         * wx/install-unix-extras:
4022
4023 2009-10-14  Brady Eidson  <beidson@apple.com>
4024
4025         Reviewed by Sam Weinig.
4026
4027         WebKit Win API should provide a delegate interface for global history.
4028         https://bugs.webkit.org/show_bug.cgi?id=29905
4029
4030         * DumpRenderTree/LayoutTestController.cpp:
4031         (LayoutTestController::LayoutTestController):
4032         * DumpRenderTree/LayoutTestController.h:
4033         (LayoutTestController::dumpHistoryDelegateCallbacks):
4034         (LayoutTestController::setDumpHistoryDelegateCallbacks):
4035                 
4036         * DumpRenderTree/win/DumpRenderTree.cpp:
4037         (shouldLogHistoryDelegates):
4038         (runTest):
4039         (createWebViewAndOffscreenWindow):
4040         (main):
4041         * DumpRenderTree/win/DumpRenderTree.vcproj:
4042         
4043         Add the IWebHistoryDelegate to DRT Windows:
4044         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
4045         (wstringFromBSTR):
4046         (HistoryDelegate::HistoryDelegate):
4047         (HistoryDelegate::~HistoryDelegate):
4048         (HistoryDelegate::QueryInterface):
4049         (HistoryDelegate::AddRef):
4050         (HistoryDelegate::Release):
4051         (HistoryDelegate::didNavigateWithNavigationData):
4052         (HistoryDelegate::didPerformClientRedirectFromURL):
4053         (HistoryDelegate::didPerformServerRedirectFromURL):
4054         (HistoryDelegate::updateHistoryTitle):
4055         (HistoryDelegate::populateVisitedLinksForWebView):
4056         * DumpRenderTree/win/HistoryDelegate.h: Added.
4057
4058         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4059         (LayoutTestController::removeAllVisitedLinks):
4060
4061 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
4062
4063         Reviewed by Simon Hausmann.
4064
4065         [Qt] Implement support for setPOSIXLocale on Qt.
4066         https://bugs.webkit.org/show_bug.cgi?id=30268 
4067  
4068         * DumpRenderTree/qt/DumpRenderTree.cpp:
4069         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4070         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4071         (LayoutTestController::setPOSIXLocale):
4072         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4073
4074 2009-10-13  Stephanie Lewis  <slewis@apple.com>
4075
4076         Unreviewed, adding myself to reviewers list.
4077
4078         * Scripts/modules/committers.py:
4079
4080 2009-10-13  Stephanie Lewis  <slewis@apple.com>
4081
4082         Reviewed by Mark Rowe.
4083
4084         Fix null assignment so root tests work again.
4085
4086         * Scripts/webkitdirs.pm:
4087
4088 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
4089
4090         Reviewed by Simon Hausmann.
4091
4092         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
4093         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
4094         This is done in preparation of implementing missing features in DRT.
4095         No functionality changes made yet.
4096
4097         * DumpRenderTree/qt/DumpRenderTree.cpp:
4098         * DumpRenderTree/qt/DumpRenderTree.pro:
4099         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
4100         (EventSender::EventSender):
4101         (EventSender::mouseDown):
4102         (EventSender::mouseUp):
4103         (EventSender::mouseMoveTo):
4104         (EventSender::leapForward):
4105         (EventSender::keyDown):
4106         (EventSender::contextClick):
4107         (EventSender::scheduleAsynchronousClick):
4108         (EventSender::frameUnderMouse):
4109         * DumpRenderTree/qt/EventSenderQt.h: Added.
4110         (EventSender::clearKillRing):
4111         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
4112         (LayoutTestController::LayoutTestController):
4113         (LayoutTestController::reset):
4114         (LayoutTestController::processWork):
4115         (LayoutTestController::maybeDump):
4116         (LayoutTestController::waitUntilDone):
4117         (LayoutTestController::notifyDone):
4118         (LayoutTestController::windowCount):
4119         (LayoutTestController::clearBackForwardList):
4120         (LayoutTestController::dumpEditingCallbacks):
4121         (LayoutTestController::dumpResourceLoadCallbacks):
4122         (LayoutTestController::queueBackNavigation):
4123         (LayoutTestController::queueForwardNavigation):
4124         (LayoutTestController::queueLoad):
4125         (LayoutTestController::queueReload):
4126         (LayoutTestController::queueScript):
4127         (LayoutTestController::provisionalLoad):
4128         (LayoutTestController::timerEvent):
4129         (LayoutTestController::encodeHostName):
4130         (LayoutTestController::decodeHostName):
4131         (LayoutTestController::setJavaScriptProfilingEnabled):
4132         (LayoutTestController::setFixedContentsSize):
4133         (LayoutTestController::setPrivateBrowsingEnabled):
4134         (LayoutTestController::setPopupBlockingEnabled):
4135         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
4136         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
4137         (LayoutTestController::numberOfActiveAnimations):
4138         (LayoutTestController::disableImageLoading):
4139         (LayoutTestController::dispatchPendingLoadRequests):
4140         (LayoutTestController::setDatabaseQuota):
4141         (LayoutTestController::clearAllDatabases):
4142         (LayoutTestController::whiteListAccessFromOrigin):
4143         (LayoutTestController::waitForPolicyDelegate):
4144         (LayoutTestController::overridePreference):
4145         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
4146         (LayoutTestController::isLoading):
4147         (LayoutTestController::setLoading):
4148         (LayoutTestController::shouldDumpAsText):
4149         (LayoutTestController::shouldDumpBackForwardList):
4150         (LayoutTestController::shouldDumpChildrenAsText):
4151         (LayoutTestController::shouldDumpDatabaseCallbacks):
4152         (LayoutTestController::shouldDumpStatusCallbacks):
4153         (LayoutTestController::shouldWaitUntilDone):
4154         (LayoutTestController::canOpenWindows):
4155         (LayoutTestController::shouldDumpTitleChanges):
4156         (LayoutTestController::waitForPolicy):
4157         (LayoutTestController::dumpAsText):
4158         (LayoutTestController::dumpChildFramesAsText):
4159         (LayoutTestController::dumpDatabaseCallbacks):
4160         (LayoutTestController::dumpStatusCallbacks):
4161         (LayoutTestController::setCanOpenWindows):
4162         (LayoutTestController::dumpBackForwardList):
4163         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
4164         (LayoutTestController::display):
4165         (LayoutTestController::dumpTitleChanges):
4166         (LayoutTestController::dumpSelectionRect):
4167         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
4168         (TextInputController::TextInputController):
4169         (TextInputController::doCommand):
4170         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
4171         * DumpRenderTree/qt/WorkQueue.cpp:
4172         * DumpRenderTree/qt/WorkQueue.h:
4173         * DumpRenderTree/qt/WorkQueueItem.h:
4174         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
4175         (findFrameNamed):
4176         (LoadItem::invoke):
4177         (ReloadItem::invoke):
4178         (ScriptItem::invoke):
4179         (BackForwardItem::invoke):
4180         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
4181         * DumpRenderTree/qt/jsobjects.h:
4182
4183 2009-10-13  Dmitry Titov  <dimich@chromium.org>
4184
4185         Not reviewed, adding myself to the list of reviewers.
4186
4187         * Scripts/modules/committers.py:
4188
4189 2009-10-13  Anders Carlsson  <andersca@apple.com>
4190
4191         Reviewed by Sam Weinig.
4192
4193         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
4194
4195         Make the private browsing mode testable by the test plug-in.
4196         
4197         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
4198         (pluginGetProperty):
4199         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
4200         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
4201         (NPP_New):
4202         (NPP_SetValue):
4203
4204 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
4205
4206         No review, just adding self to the list of reviewers.
4207
4208         * Scripts/modules/committers.py:
4209
4210 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
4211
4212         Reviewed by Adam Roben.
4213
4214         Web Inspector: Use proper web view in inspector layout
4215         tests for windows.
4216
4217         https://bugs.webkit.org/show_bug.cgi?id=30298
4218
4219         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4220         (LayoutTestController::showWebInspector):
4221         (LayoutTestController::closeWebInspector):
4222         (LayoutTestController::evaluateInWebInspector):
4223
4224 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
4225
4226         Reviewed by Sam Weinig.
4227
4228         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
4229         https://bugs.webkit.org/show_bug.cgi?id=29841
4230
4231         * DumpRenderTree/mac/DumpRenderTree.mm:
4232         (resetDefaultsToConsistentValues):
4233         * DumpRenderTree/win/DumpRenderTree.cpp:
4234         (resetDefaultsToConsistentValues):
4235
4236 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
4237
4238         Reviewed by Dimitri Glazkov.
4239
4240         Chromium Port - Windows
4241         https://bugs.webkit.org/show_bug.cgi?id=29969
4242
4243         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
4244         * Scripts/webkitdirs.pm:
4245
4246 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
4247
4248         Reviewed by Darin Adler.
4249
4250         jsc scripts cleanup and Qt/GTK fix
4251         https://bugs.webkit.org/show_bug.cgi?id=30288
4252
4253         Duplicated jscPath() moved to webkitdirs.pm.
4254         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
4255         Configuration added (release/debug) to path for Qt-port on Windows.
4256
4257         * Scripts/run-javascriptcore-tests:
4258         * Scripts/run-jsc:
4259         * Scripts/run-sunspider:
4260         * Scripts/sunspider-compare-results:
4261         * Scripts/webkitdirs.pm:
4262
4263 2009-10-11  Adam Barth  <abarth@webkit.org>
4264
4265         Unreviewed.  Add Collin to committers.py.
4266
4267         * Scripts/modules/committers.py:
4268
4269 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
4270
4271         wx build fix, add bindings to source/include dirs now that there are sources there.
4272
4273         * wx/build/settings.py:
4274
4275 2009-10-09  Mark Rowe  <mrowe@apple.com>
4276
4277         Reviewed by Brady Eidson.
4278
4279         Enable plug-in halting in DumpRenderTree.
4280
4281         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
4282         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
4283
4284         * DumpRenderTree/mac/DumpRenderTree.mm:
4285         (resetDefaultsToConsistentValues):
4286         * DumpRenderTree/mac/UIDelegate.mm:
4287         (-[UIDelegate webView:shouldHaltPlugin:]):
4288
4289 2009-10-08  Brady Eidson  <beidson@apple.com>
4290
4291         Reviewed by Dan Bernstein.
4292
4293         Ask the History Delegate to populate the visited links hash.
4294         <rdar://problem/7285293> and https://webkit.org/b/29904
4295
4296         Add the ability for LayoutTestController to clear all visited links.
4297         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
4298
4299         * DumpRenderTree/LayoutTestController.cpp:
4300         (LayoutTestController::LayoutTestController):
4301         (removeAllVisitedLinksCallback):
4302         (LayoutTestController::staticFunctions):
4303         * DumpRenderTree/LayoutTestController.h:
4304         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4305         (LayoutTestController::removeAllVisitedLinks):
4306
4307         * DumpRenderTree/mac/HistoryDelegate.mm:
4308         (-[HistoryDelegate populateVisitedLinksForWebView:]):
4309
4310         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4311         (LayoutTestController::removeAllVisitedLinks):
4312         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4313         (LayoutTestController::removeAllVisitedLinks):
4314         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4315         (LayoutTestController::removeAllVisitedLinks):
4316
4317
4318 2009-10-08  Daniel Bates  <dbates@webkit.org>
4319
4320         Reviewed by Adam Roben.
4321
4322         https://bugs.webkit.org/show_bug.cgi?id=30175
4323         
4324         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
4325         the OLE drag-and-drop return value like the function it emulates. Currently, 
4326         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
4327         whether the drag-and-drop operation was successful or was cancelled.
4328         
4329         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
4330         return value according to whether the drop operation was successful or not.
4331
4332         * DumpRenderTree/win/EventSender.cpp:
4333         (doMouseUp): Added parameter oleDragAndDropReturnValue.
4334         (replaySavedEvents): Ditto.
4335         * DumpRenderTree/win/EventSender.h:
4336         * DumpRenderTree/win/UIDelegate.cpp:
4337         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
4338
4339 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
4340
4341         Reviewed by Xan Lopez.
4342
4343         [GTK] Added support for a parameter setting the button that was
4344         pressed in the mouseDown function.
4345         https://bugs.webkit.org/show_bug.cgi?id=30220
4346
4347         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
4348
4349 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
4350
4351         Reviewed by Xan Lopez.
4352
4353         [GTK] Added a line to the bottom of the expected result to match
4354         the output of the test.
4355         https://bugs.webkit.org/show_bug.cgi?id=30220
4356
4357         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
4358         expected.txt: