[Qt] Build files for the WTR's InjectedBundle
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-10-07  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>, Andras Becsi  <abecsi@webkit.org>, Balazs Kelemen  <kbalazs@webkit.org>
2
3         Reviewed by Kenneth Rohde Christiansen.
4
5         [Qt] Add WTR's InjectedBundle build files.
6         https://bugs.webkit.org/show_bug.cgi?id=47333
7
8         * Scripts/webkitdirs.pm:
9         * WebKitTestRunner/DerivedSources.pro: Added.
10         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Added.
11         * WebKitTestRunner/WebKitTestRunner.pro: Added.
12         * WebKitTestRunner/qt/DerivedSources.pro: Removed.
13         Content merged in ../DerivedSources.pro
14
15 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
16
17         Unreviewed. Do a renaming that was recommended by the reviewer
18         (Kenneth) but I forgot to do before landing (http://trac.webkit.org/changeset/69253)
19
20         * WebKitTestRunner/qt/TestControllerQt.cpp:
21         (WTR::RunUntilConditionLoop::start):
22         (WTR::RunUntilConditionLoop::RunUntilConditionLoop):
23         (WTR::TestController::runUntil):
24
25 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
26
27         Reviewed by Kenneth Rohde Christiansen.
28
29         [Qt] Watchdog timer implementation for WTR
30         https://bugs.webkit.org/show_bug.cgi?id=47337
31
32         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Factor out
33         the definition of the timer type to a typedef.
34         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Added.
35         Timer implementation with QTimer and a helper QObject class.
36         (WTR::WatchdogTimerHelper::instance):
37         (WTR::WatchdogTimerHelper::timerFired):
38         (WTR::WatchdogTimerHelper::WatchdogTimerHelper):
39         (WTR::LayoutTestController::platformInitialize):
40         (WTR::LayoutTestController::invalidateWaitToDumpWatchdogTimer):
41         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
42
43 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
44
45         Unreviewed buildfix for 69297 again
46
47         * WebKitTestRunner/TestController.cpp:
48         (WTR::blankURL):
49
50 2010-10-07  Balazs Kelemen  <Balazs Kelemen>
51
52         Unreviewed trivial build fix for r69297
53
54         * WebKitTestRunner/TestController.cpp:
55         (WTR::blankURL):
56
57 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
58
59         Reviewed by Kenneth Rohde Christiansen.
60
61         WebKitTestRunner should be portable
62         https://bugs.webkit.org/show_bug.cgi?id=45393
63
64         Use only the WebKit API for working with urls.
65         * WebKitTestRunner/StringFunctions.h:
66         (WTR::createWKURL):
67         * WebKitTestRunner/TestController.cpp:
68         (WTR::blankURL):
69         (WTR::TestController::resetStateToConsistentValues):
70         (WTR::TestController::didFinishLoadForFrame):
71
72 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
73
74         Reviewed by Xan Lopez.
75
76         [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
77         https://bugs.webkit.org/show_bug.cgi?id=47332
78
79         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
80         (createBitmapContextFromWebView):
81
82 2010-10-06  Chris Guillory  <chris.guillory@google.com>
83
84         Reviewed by Chris Fleizach.
85
86         Remove unused accessibility functions from webkit.
87         https://bugs.webkit.org/attachment.cgi?bugid=46707
88
89         * DumpRenderTree/chromium/WebViewHost.cpp:
90         (WebViewHost::postAccessibilityNotification):
91         * DumpRenderTree/chromium/WebViewHost.h:
92
93 2010-10-06  Lucas Forschler  <lforschler@apple.com>
94
95         Reviewed by Adam Roben.
96
97         Fix the sunspider-compare-results to actually use the passed in value for $root.
98
99         * Scripts/sunspider-compare-results:
100
101 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
102
103         Reviewed by Kenneth Rohde Christiansen.
104
105         [Qt] Runloop implementation for WTR
106         https://bugs.webkit.org/show_bug.cgi?id=47280
107
108         * WebKitTestRunner/qt/TestControllerQt.cpp:
109         Implemented TestController::runUntil by a timerEvent
110         and a QEventLoop. We step into the event loop from runUntil.
111         While we are waiting in the loop a timerEvent is periodically
112         checking the value of the condition. Once the condition has
113         becoming true the timerEvent wakes us up.
114         (WTR::RunUntilLoop::start):
115         (WTR::RunUntilLoop::RunUntilLoop):
116         (WTR::RunUntilLoop::run):
117         (WTR::RunUntilLoop::timerEvent):
118         (WTR::TestController::platformInitialize):
119         (WTR::TestController::runUntil):
120         * WebKitTestRunner/qt/main.cpp:
121         Start the main event loop first and creating the TestController later.
122         (Launcher::Launcher):
123         (Launcher::~Launcher):
124         (Launcher::launch): Creating the TestController.
125         (main): Setting up a timer for calling Launcher::launch from
126         the main event loop.
127
128 2010-10-06  Dirk Pranke  <dpranke@chromium.org>
129
130         Reviewed by Kenneth Russell.
131
132         new-run-webkit-tests: fix typo in chromium-gpu that was trying to
133         enable 'accelerated-composting' instead of 'accelerated-compositing'.
134
135         https://bugs.webkit.org/show_bug.cgi?id=47312
136
137         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
138         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
139
140 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
141
142         Reviewed by Kenneth Rohde Christiansen.
143
144         [Qt] PlatformWebView implementation for WebKitTestRunner
145         https://bugs.webkit.org/show_bug.cgi?id=47276
146
147         The implementation follows the way how
148         we use the API in MiniBrowser.
149         * WebKitTestRunner/PlatformWebView.h:
150         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
151         (WTR::WebView::wkView):
152         (WTR::WebView::~WebView):
153         (WTR::WebView::WebView):
154         (WTR::PlatformWebView::PlatformWebView):
155         (WTR::PlatformWebView::~PlatformWebView):
156         (WTR::PlatformWebView::resizeTo):
157         (WTR::PlatformWebView::page):
158         (WTR::PlatformWebView::focus):
159         * WebKitTestRunner/qt/WebKitTestRunner.pro:
160
161 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
162
163         Reviewed by Kenneth Rohde Christiansen.
164
165         [Qt] Add WebKitTestRunner's build files
166         https://bugs.webkit.org/show_bug.cgi?id=44155
167
168         Parts was taken by Zoltan Horvath's patch.
169
170         * Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
171         * Scripts/webkitdirs.pm: Make the generated files needed by WTR.
172         * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
173         PlatformWKView and PlatformWindow (void* for now).
174         Buildfix the case when __APPLE__ is not defined.
175         * WebKitTestRunner/qt/DerivedSources.pro: Added.
176         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
177         Empty stub implementation.
178         (WTR::registerWindowClass):
179         (WTR::PlatformWebView::PlatformWebView):
180         (WTR::PlatformWebView::~PlatformWebView):
181         (WTR::PlatformWebView::resizeTo):
182         (WTR::PlatformWebView::page):
183         (WTR::PlatformWebView::focus):
184         * WebKitTestRunner/qt/TestControllerQt.cpp: Added.
185         Empty stub implementation.
186         (WTR::registerWindowClass):
187         (WTR::TestController::runUntil):
188         (WTR::TestController::platformInitialize):
189         (WTR::TestController::initializeInjectedBundlePath):
190         (WTR::TestController::initializeTestPluginDirectory):
191         (WTR::TestController::platformInitializeContext):
192         * WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
193         * WebKitTestRunner/qt/main.cpp: Added.
194         (main):
195
196 2010-10-06  Tony Chang  <tony@chromium.org>
197
198         Unreviewed, rolling out r69202.
199         http://trac.webkit.org/changeset/69202
200         https://bugs.webkit.org/show_bug.cgi?id=46937
201
202         Broke compile of test_shell
203
204         * DumpRenderTree/chromium/EventSender.cpp:
205         (EventSender::beginDragWithFiles):
206         * DumpRenderTree/chromium/WebViewHost.cpp:
207         (addDRTFakeFileToDataObject):
208
209 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
210
211         Reviewed by Tony Chang.
212
213         [chromium] Minor naming cleanup in WebDragData, part 2
214         https://bugs.webkit.org/show_bug.cgi?id=46937
215
216         Update DRT to use the renamed methods.
217
218         * DumpRenderTree/chromium/EventSender.cpp:
219         (EventSender::beginDragWithFiles):
220         * DumpRenderTree/chromium/WebViewHost.cpp:
221         (addDRTFakeFileToDataObject):
222
223 2010-10-06  David Kilzer  <ddkilzer@apple.com>
224
225         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
226
227         Reviewed by Adam Roben.
228
229         This is the first step in making webarchive tests work on
230         Windows.
231
232         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
233         new files to the project.
234         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
235         to WebArchiveDumpSupport.mm.
236         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
237         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
238         (serializeWebArchiveToXML):
239
240 2010-10-05  Daniel Bates  <dbates@rim.com>
241
242         Reviewed by David Kilzer.
243
244         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
245         https://bugs.webkit.org/show_bug.cgi?id=46058
246
247         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
248         structure so as to support returning additional information
249         about a change log diff.
250
251         Currently, VCSUtils::fixChangeLogPatch() returns a string that
252         represents the change log diff. Towards supporting the return
253         of additional information, such as whether the change log diff
254         inserts an entry at the top of the ChangeLog file, we need to
255         make VCSUtils::fixChangeLogPatch() return a reference to hash
256         structure.
257
258         * Scripts/VCSUtils.pm:
259           - Modified fixChangeLogPatch() to return a reference to a
260             hash structure.
261           - Added documentation to fixChangeLogPatch().
262           - Modified call site in mergeChangeLogs() as necessary.
263         * Scripts/svn-apply:
264           - Modified call site in patch() as necessary.
265         * Scripts/svn-create-patch:
266           - Modified call site in generateDiff() as necessary.
267         * Scripts/svn-unapply:
268           - Modified call site in patch() as necessary.
269         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
270           - Modified the unit tests as necessary.
271
272 2010-10-05  Tony Chang  <tony@chromium.org>
273
274         Reviewed by Darin Adler.
275
276         fix the link to the expected image on windows
277         https://bugs.webkit.org/show_bug.cgi?id=47228
278
279         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
280             windows, the file must be opened in binary mode when writing
281             binary data.
282
283 2010-10-05  Adam Barth  <abarth@webkit.org>
284
285         Update expected result of unittest to match Tony's change below.
286
287         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
288
289 2010-10-05  Tony Chang  <tony@chromium.org>
290
291         Reviewed by Ojan Vafai (over the shoulder).
292
293         Paper over errors in image_diff so we don't crash the whole test run.
294
295         * Scripts/webkitpy/layout_tests/port/chromium.py:
296
297 2010-10-05  Tony Chang  <tony@chromium.org>
298
299         Unreviewed, make shutil.rmtree more resiliant to errors
300         since windows was raising WindowsError: The process cannot access the file because it
301         is being used by another process.
302
303         * Scripts/webkitpy/layout_tests/port/chromium.py:
304
305 2010-10-05  Tony Chang  <tony@chromium.org>
306
307         Reviewed by Ojan Vafai.
308
309         [chromium] fix image diffing in NRWT
310         https://bugs.webkit.org/show_bug.cgi?id=47128
311
312         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
313             NamedTemporaryFile since it doesn't work on Windows.
314         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
315
316 2010-10-05  Kenneth Russell  <kbr@google.com>
317
318         Reviewed by Tony Chang.
319
320         [chromium] Implement layerTreeAsText in DumpRenderTree
321         https://bugs.webkit.org/show_bug.cgi?id=47216
322
323         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
324         make it callable from DumpRenderTree.
325
326         No new tests; verified with existing compositor layout tests.
327
328         * DumpRenderTree/chromium/LayoutTestController.cpp:
329         (LayoutTestController::LayoutTestController):
330         (LayoutTestController::layerTreeAsText):
331         * DumpRenderTree/chromium/LayoutTestController.h:
332
333 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
334
335         Unreviewed build correction.
336
337         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
338         property sheet so proper libraries are linked.
339
340 2010-10-05  Robert Hogan  <robert@webkit.org>
341
342         Reviewed by Andreas Kling.
343
344         [Qt] Fix url conversion in QWebHistory
345
346         Converting from KURL to WFT::String to QUrl does not
347         permit proper percent encoding later.
348
349         https://bugs.webkit.org/show_bug.cgi?id=47048
350
351         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
352         (WebCore::dumpHistoryItem):
353
354 2010-10-05  Anders Carlsson  <andersca@apple.com>
355
356         Reviewed by Sam Weinig.
357
358         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
359         https://bugs.webkit.org/show_bug.cgi?id=47188
360         <rdar://problem/8514104>
361
362         When constructing the std::string, use the real string length instead of the maximum buffer size.
363
364         * TestWebKitAPI/PlatformUtilities.h:
365         (TestWebKitAPI::Util::toSTD):
366         * WebKitTestRunner/StringFunctions.h:
367         (WTR::toSTD):
368
369 2010-10-04  Sam Weinig  <sam@webkit.org>
370
371         Reviewed by Mark Rowe.
372
373         Add MIMEType accessor to WKFrame
374         <rdar://problem/8347683>
375         https://bugs.webkit.org/show_bug.cgi?id=47138
376
377         * TestWebKitAPI/PlatformUtilities.h:
378         (TestWebKitAPI::Util::toSTD):
379         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
380         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
381         (TestWebKitAPI::didStartProvisionalLoadForFrame):
382         (TestWebKitAPI::didCommitLoadForFrame):
383         (TestWebKitAPI::didFinishLoadForFrame):
384         (TestWebKitAPI::TEST):
385         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
386         (TestWebKitAPI::didStartProvisionalLoadForFrame):
387         (TestWebKitAPI::didCommitLoadForFrame):
388         (TestWebKitAPI::didFinishLoadForFrame):
389         (TestWebKitAPI::TEST):
390         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
391         (TestWebKitAPI::TEST):
392         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
393         * TestWebKitAPI/Tests/WebKit2/icon.png: Added.
394         * TestWebKitAPI/Tests/WebKit2/simple.html: Added.
395         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
396         (TestWebKitAPI::Util::createURLForResource):
397
398 2010-10-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
399
400         Reviewed by Ojan Vafai.
401
402         [NRWT] Rename current_dir to current_group because it's not a directory
403         https://bugs.webkit.org/show_bug.cgi?id=47169
404
405         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
406         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
407
408 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
409
410         Unreviewed, build fix.
411
412         r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
413         which can't always be done. This test uses tempfile.mkdtemp(), which
414         should be safe.
415
416         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
417
418 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
419
420         Unreviewed, build fix.
421
422         Add missing "from __future__ import with_statement" that was
423         breaking test-webkitpy on the Leopard bots (broke in r69040).
424
425         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
426
427 2010-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
428
429         Unreviewed, rolling out r69066.
430         http://trac.webkit.org/changeset/69066
431         https://bugs.webkit.org/show_bug.cgi?id=47163
432
433         Made NRWT reliability worse. (Requested by tkent on #webkit).
434
435         * Scripts/webkitpy/layout_tests/port/chromium.py:
436         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
437
438 2010-10-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
439
440         Reviewed by Tony Chang.
441
442         [NRWT] Reverse the http tests to alphabetical order.
443         https://bugs.webkit.org/show_bug.cgi?id=47075
444
445         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
446
447 2010-10-04  Robert Hogan  <robert@webkit.org>
448
449         Reviewed by Andreas Kling.
450
451         [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
452
453         We need to queue back and forward navigations in the DRT from the
454         LayoutTestController so that maybeDump() knows about them.
455
456         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
457         (LayoutTestController::queueBackNavigation):
458         (LayoutTestController::queueForwardNavigation):
459
460 2010-10-04  Tony Chang  <tony@chromium.org>
461
462         Reviewed by Kent Tamura.
463
464         [chromium] fix image diffing in NRWT
465         https://bugs.webkit.org/show_bug.cgi?id=47128
466
467         * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
468               temp file and check the image_diff error code more carefully
469         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
470
471 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
472
473         Reviewed by Adam Barth.
474
475         aroben's change in r68792 actually broke new-run-webkit-tests when
476         running the DRT code path. His change was intended to fix the
477         way we were converting windows paths to URIs when running under
478         Cygwin (the paths were getting one too many "/" on the front).
479         However, the change ended up breaking the chromium_win port, which
480         had slightly different logic.
481
482         This patch removes the port-specific code and adds tests to make
483         sure we're getting the behavior we expect. The Port object no longer
484         exposes a get_absolute_path() method that can be used outside of
485         of converting test filenames, because it's unreliable otherwise
486         (we don't have the right context to know which conversion is intended).
487
488         https://bugs.webkit.org/show_bug.cgi?id=47140
489
490         * Scripts/webkitpy/layout_tests/port/base.py:
491         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
492         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
493         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
494         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
495
496 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
497
498         Unreviewed, build fix.
499
500         Handle crash introduced in r69040 if we are not running in a
501         Chromium checkout.
502
503         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
504
505 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
506
507         Reviewed by Tony Chang.
508
509         Add a way for us to have test expectations that are specific to the
510         official builds of Google Chrome (as opposed to Chromium). This change
511         looks for an additional "test_expectations_chrome.txt" file in
512         Chromium's repository (webkit/tools/layout_tests), and uses the
513         concatenation of that file and the regular test_expectations.txt
514         file for test overrides.
515
516         https://bugs.webkit.org/show_bug.cgi?id=46854
517
518         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
519         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
520
521 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
522
523         Color tests in the list based on existing pass/fail result.
524         
525         Fix the summary data to account for htmlOnly and nonHTML tests.
526
527         * CSSTestSuiteHarness/harness/harness.css:
528         (#test-list > option.pass):
529         (#test-list > option.fail):
530         (#test-list > option.skipped):
531         * CSSTestSuiteHarness/harness/harness.js:
532         (Test):
533         (Test.prototype.statusForFormat):
534         (TestSuite.prototype.fillTestList):
535         (TestSuite.prototype.updateTestList):
536         (TestSuite.prototype.recordResult):
537         (TestSuite.prototype.markTestCompleted):
538         (TestSuite.prototype.countTestsWithFlag):
539         (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
540         (TestSuite.prototype.queryDatabaseForSummary):
541
542 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
543
544         Reviewed by Beth Dakin.
545
546         AX: doAXRangeForLine does not work
547         https://bugs.webkit.org/show_bug.cgi?id=47101
548
549         DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
550
551         * DumpRenderTree/AccessibilityUIElement.cpp:
552         (rangeForLineCallback):
553         (AccessibilityUIElement::rangeForLine):
554         (AccessibilityUIElement::getJSClass):
555         * DumpRenderTree/AccessibilityUIElement.h:
556         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
557         (AccessibilityUIElement::rangeForLine):
558
559 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
560
561         Unreviewed. Adding myself to the committers list.
562
563         * Scripts/webkitpy/common/config/committers.py:
564
565 2010-10-04  Sam Weinig  <sam@webkit.org>
566
567         Reviewed by Anders Carlsson.
568
569         Add ability to set the CacheModel in Webkit2
570         https://bugs.webkit.org/show_bug.cgi?id=47066
571
572         * MiniBrowser/mac/AppDelegate.m:
573         (-[BrowserAppDelegate init]): Opt minibrowser into
574         a PrimaryWebBrowser cache model.
575
576 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
577
578         Make sure to enter all tests when creating the database
579         for the first time.
580         
581         When migrating to a new version of the suite, be sure to
582         sync up the database and testinfo.data by removing old
583         tests, and inserting new ones.
584
585         * CSSTestSuiteHarness/harness/harness.js:
586         (TestSuite.prototype.openDatabase.creation):
587         (TestSuite.prototype.databaseCreated):
588         (TestSuite.prototype.populateDatabaseFromTestInfoData):
589         (TestSuite.prototype.insertTest):
590
591 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
592
593         More work on treating HTML4 and XHTML1 independently; when 
594         changing the format, rebuild the test list, and update the 
595         numbers in the chapter popup.
596
597         * CSSTestSuiteHarness/harness/harness.js:
598         (Test):
599         (Test.prototype.runForFormat):
600         (Test.prototype.completedForFormat):
601         (ChapterSection):
602         (ChapterSection.prototype.countTests):
603         (Chapter):
604         (Chapter.prototype.description):
605         (Chapter.prototype.countTests):
606         (Chapter.prototype.testCount):
607         (Chapter.prototype.untestedCount):
608         (TestSuite.prototype.buildChapters):
609         (TestSuite.prototype.loadCurrentTest):
610         (TestSuite.prototype.updateProgressLabel):
611         (TestSuite.prototype.processFlags):
612         (TestSuite.prototype.formatChanged):
613
614 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
615
616         Update test suite version 20101001.
617         
618         Handle database migration, and delete tests from the db that are
619         not present in testinfo.data.
620         
621         Load about:blank into the test frame before the test url, to make
622         missing tests more obvious.
623         
624         * CSSTestSuiteHarness/harness/harness.js:
625         (TestSuite.prototype.loadTest):
626         (TestSuite.prototype.openDatabase.creation):
627         (TestSuite.prototype.openDatabase.migration1_0To1_1):
628         (TestSuite.prototype.openDatabase.if.return):
629         (TestSuite.prototype.databaseReady):
630         (TestSuite.prototype.populateDatabaseFromTestInfoData):
631         (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
632         (TestSuite.prototype.syncDatabaseWithTestInfoData):
633
634 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
635
636         Add the ability to jump to a specific test.
637
638         * CSSTestSuiteHarness/harness/harness.html:
639         * CSSTestSuiteHarness/harness/harness.js:
640         (TestSuite.prototype.goToTestByName):
641         (TestSuite.prototype.switchToFormat):
642
643 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
644
645         For a ref test, load the ref in the same format (HTML4 vs XHTML1)
646         as the test.
647
648         * CSSTestSuiteHarness/harness/harness.js:
649         (TestSuite.prototype.loadRef):
650
651 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
652
653         Update the UI to reflect the fact that each test needs to be tested
654         in both HTML4 and XHTML1 format.
655         
656         * CSSTestSuiteHarness/harness/harness.js:
657         (Test):
658         (Chapter.prototype.description):
659         (Chapter.prototype.untestedCount):
660         (TestSuite.prototype.fillChapterPopup):
661         (TestSuite.prototype.updateChapterPopup):
662         (TestSuite.prototype.fillTestList):
663         (TestSuite.prototype.updateTestList):
664         (TestSuite.prototype.goToNextIncompleteTest):
665         (TestSuite.prototype.firstIncompleteTestIndex):
666         (TestSuite.prototype.recordResult):
667         (TestSuite.prototype.formatChanged):
668         (TestSuite.prototype.markTestCompleted):
669         (TestSuite.prototype.resetTestStatus):
670
671 2010-10-01  Simon Fraser  <simon.fraser@apple.com>
672
673         Add the ability to remove results for re-testing, and
674         to import results.
675
676         * CSSTestSuiteHarness/harness/harness.css:
677         (.custom button):
678         (#overlay):
679         (#overlay.visible):
680         (.overlay-contents):
681         (.overlay-contents textarea):
682         (.overlay-contents .buttons):
683         (.overlay-contents .note):
684         (.overlay-contents .buttons button):
685         * CSSTestSuiteHarness/harness/harness.html:
686         * CSSTestSuiteHarness/harness/harness.js:
687         (TestSuite.prototype.importResults):
688         (TestSuite.prototype.clearResults):
689         (TestSuite.prototype.markTestCompleted):
690         (TestSuite.prototype.resetTestStatus):
691         (TestSuite.prototype.storeTestResult):
692         (TestSuite.prototype.importTestResults):
693         (TestSuite.prototype.clearTestResults):
694
695 2010-10-01  Sam Weinig  <sam@webkit.org>
696
697         Reviewed by Jon Honeycutt.
698
699         Deploy the new WKString functions to remove most uses of CF from
700         the WebKitTestRunner.
701
702         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
703         (WTR::InjectedBundle::didReceiveMessage):
704         (WTR::InjectedBundle::done):
705         * WebKitTestRunner/StringFunctions.h:
706         (WTR::toWK):
707         (WTR::toJS):
708         (WTR::toSTD):
709         (WTR::operator<<):
710         (WTR::copyURLString):
711         * WebKitTestRunner/TestController.cpp:
712         (WTR::TestController::resetStateToConsistentValues):
713         (WTR::TestController::didFinishLoadForFrame):
714         * WebKitTestRunner/TestInvocation.cpp:
715         (WTR::TestInvocation::invoke):
716         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
717
718 2010-10-01  Mihai Parparita  <mihaip@chromium.org>
719
720         Unreviewed TestResultsServer change.
721
722         Add files introduced by http://crrev.com/61273 to the list of dashboard 
723         files to update.
724
725         * TestResultServer/handlers/dashboardhandler.py:
726
727 2010-10-01  Brian Weinstein  <bweinstein@apple.com>
728
729         Build Fix for Windows.
730
731         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
732             WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
733             ForwardingHeaders to the include path.
734
735 2010-10-01  Sam Weinig  <sam@webkit.org>
736
737         Reviewed by Anders Carlsson.
738
739         Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
740
741         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
742         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
743         (TestWebKitAPI::TEST):
744         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
745         (TestWebKitAPI::TEST):
746
747 2010-10-01  Sam Weinig  <sam@webkit.org>
748
749         Reviewed by Kenneth Rohde Christiansen.
750
751         Add additional WKString API
752         https://bugs.webkit.org/show_bug.cgi?id=46958
753
754         Add basic WKStringRef tests.
755
756         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
757         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
758
759 2010-10-01  Sam Weinig  <sam@webkit.org>
760
761         Reviewed by Dan Bernstein.
762
763         Add makefile for TestWebKitAPI and call it from the base makefile.
764
765         * Makefile:
766         * TestWebKitAPI/Makefile: Added.
767
768 2010-10-01  Sam Weinig  <sam@webkit.org>
769
770         Reviewed by Adam Roben.
771
772         Remove unnecessary ForwardingHeaders from test runners.
773         https://bugs.webkit.org/show_bug.cgi?id=47010
774
775         * TestWebKitAPI/Configurations/Base.xcconfig:
776         * TestWebKitAPI/ForwardingHeaders: Removed.
777         * WebKitTestRunner/Configurations/Base.xcconfig:
778         * WebKitTestRunner/ForwardingHeaders: Removed.
779
780 2010-09-30  Adam Barth  <abarth@webkit.org>
781
782         Reviewed by Eric Seidel.
783
784         WebSocket tests are flaky
785         https://bugs.webkit.org/show_bug.cgi?id=46956
786
787         Update these tools to understand how to run the WebSocket tests off the
788         Apache server.
789
790         * Scripts/old-run-webkit-tests:
791         * Scripts/webkitpy/layout_tests/port/base.py:
792         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
793         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
794
795 2010-10-01  Adam Roben  <aroben@apple.com>
796
797         Encode Executive command arguments using UTF-8 on Cygwin
798
799         Cygwin's Python's os.execv doesn't support unicode command arguments.
800         Cygwin's execv expects arguments to be encoded using the current code
801         page. But code pages are limited in what characters they can handle,
802         and our tests include characters that the English code page can't
803         handle.  So for now we'll just encode everything in UTF-8 on Cygwin,
804         which can handle all characters but might confuse some commands, for
805         expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
806         good enough, but we can deal with that when the problem arises.
807
808         Reviewed by Adam Barth.
809
810         Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
811         webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
812         fails on Windows
813
814         * Scripts/webkitpy/common/system/executive.py:
815         (Executive._run_command_with_teed_output):
816         (Executive.run_command):
817         On Cygwin, encode arguments using UTF-8.
818
819 2010-10-01  Sam Weinig  <sam@webkit.org>
820
821         Reviewed by Adam Roben.
822
823         Add simple API tester for WebKit2
824         https://bugs.webkit.org/show_bug.cgi?id=46953
825
826         This adds a very simple testing infrastructure for testing APIs exposed
827         through the WebKit project. It consists of two parts: 1) a project that
828         builds the all the tests 2) a script that searches the tests directory and
829         calls the tester once for each test.
830
831         This adds the infrastructure and two tests:
832         - Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
833         - Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.
834
835         This currently only works on the mac, but is designed to be easily ported 
836         to any platform.
837
838         * Scripts/run-api-tests: Added.
839         * Scripts/build-api-tests: Added.
840         Scripts to build/run the tests.
841
842         * TestWebKitAPI: Added.
843         * TestWebKitAPI/Configurations: Added.
844         * TestWebKitAPI/Configurations/Base.xcconfig: Added.
845         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
846         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
847         * TestWebKitAPI/ForwardingHeaders: Added.
848         * TestWebKitAPI/ForwardingHeaders/wtf: Added.
849         * TestWebKitAPI/PlatformUtilities.h: Added.
850         * TestWebKitAPI/PlatformWebView.h: Added.
851         (TestWebKitAPI::PlatformWebView::platformView):
852         * TestWebKitAPI/StringFunctions.h: Added.
853         * TestWebKitAPI/Test.h: Added.
854         (TestWebKitAPI::Test::~Test):
855         (TestWebKitAPI::Test::name):
856         (TestWebKitAPI::Test::Register::Register):
857         (TestWebKitAPI::Test::Register::create):
858         (TestWebKitAPI::Test::Test):
859         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
860         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
861         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
862         * TestWebKitAPI/TestsController.cpp: Added.
863         (TestWebKitAPI::TestsController::shared):
864         (TestWebKitAPI::TestsController::TestsController):
865         (TestWebKitAPI::TestsController::runTestNamed):
866         (TestWebKitAPI::TestsController::testFailed):
867         (TestWebKitAPI::TestsController::registerCreateTestFunction):
868         * TestWebKitAPI/TestsController.h: Added.
869         * TestWebKitAPI/mac: Added.
870         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
871         (TestWebKitAPI::Util::run):
872         (TestWebKitAPI::Util::createURLForResource):
873         * TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
874         (TestWebKitAPI::PlatformWebView::PlatformWebView):
875         (TestWebKitAPI::PlatformWebView::resizeTo):
876         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
877         (TestWebKitAPI::PlatformWebView::page):
878         (TestWebKitAPI::PlatformWebView::focus):
879         * TestWebKitAPI/mac/main.mm: Added.
880         Infrastructure.
881
882         * TestWebKitAPI/Tests: Added.
883         * TestWebKitAPI/Tests/WTF: Added.
884         * TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
885         * TestWebKitAPI/Tests/WebKit2: Added.
886         * TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
887         (TestWebKitAPI::State::State):
888         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
889         Proof of concept tests.
890
891 2010-10-01  Adam Roben  <aroben@apple.com>
892
893         Don't assume AccessibleObjectFromEvent succeeds
894
895         Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
896         DumpRenderTree!notificationListenerProc when running
897         plugins/access-after-page-destroyed.html
898
899         Reviewed by Sam Weinig.
900
901         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
902         (notificationListenerProc): Check both the return value of
903         AccessibleObjectFromEvent and the object it returns, as MSDN
904         recommends.
905
906 2010-10-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
907
908         Reviewed by Tony Chang.
909
910         [NRWT] Put the http and websocket tests first in the test list.
911         https://bugs.webkit.org/show_bug.cgi?id=46453
912
913         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
914         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
915
916 2010-10-01  Fady Samuel  <fsamuel@chromium.org>
917
918         Unreviewed, adding myself to the committer list.
919
920         * Scripts/webkitpy/common/config/committers.py:
921
922 2010-10-01  Adam Roben  <aroben@apple.com>
923
924         Test NPN_GetValue(NPNVnetscapeWindow)
925
926         Test for <http://webkit.org/b/46726> <rdar://problem/8486319>
927         Right-clicking on windowless Flash plugin in WebKit2 makes a context
928         menu appear in the bottom-right corner of the screen
929
930         Reviewed by Anders Carlsson.
931
932         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
933         (PluginTest::NPN_GetValue): Added. Calls through to the browser.
934
935         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
936
937         * DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
938         (GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
939         (GetValueNetscapeWindow::NPP_SetWindow): Test that
940         NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
941         isn't our HWND.
942
943         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
944         Added GetValueNetscapeWindow.
945
946 2010-10-01  Andreas Kling  <andreas.kling@nokia.com>
947
948         Unreviewed, adding my webkit.org identity to reviewer list.
949
950         * Scripts/webkitpy/common/config/committers.py:
951
952 2010-09-30  Adam Barth  <abarth@webkit.org>
953
954         Reviewed by Eric Seidel.
955
956         The WebSocket server should flush its logs
957         https://bugs.webkit.org/show_bug.cgi?id=46946
958
959         The WebSocket server logs are truncated because the driver just
960         terminates the child.  It should run Python without buffering so we can
961         see the end of the log.
962
963         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
964
965 2010-09-30  Simon Fraser  <simon.fraser@apple.com>
966
967         Add a button to jump to the next untested test.
968         
969         * CSSTestSuiteHarness/harness/harness.css:
970         (.test-type):
971         (.name > button):
972         * CSSTestSuiteHarness/harness/harness.html:
973         * CSSTestSuiteHarness/harness/harness.js:
974         (Chapter.prototype.description):
975         (Chapter.prototype.untestedCount):
976         (TestSuite.prototype.testInfoDataLoaded):
977         (TestSuite.prototype.fillChapterPopup):
978         (TestSuite.prototype.updateChapterPopup):
979         (TestSuite.prototype.buildTestListForChapter):
980         (TestSuite.prototype.goToNextIncompleteTest):
981         (TestSuite.prototype.firstIncompleteTestIndex):
982         (TestSuite.prototype.testCompletionStateChanged):
983
984 2010-09-29  Jon Honeycutt  <jhoneycutt@apple.com>
985
986         WebKit2 on Windows should use Windows fonts for the various standard
987         font families
988         https://bugs.webkit.org/show_bug.cgi?id=43499
989         <rdar://problem/8272758>
990
991         Reviewed by Adam Roben.
992
993         * WebKitTestRunner/TestController.cpp:
994         (WTR::TestController::resetStateToConsistentValues):
995         Use the Mac fonts for running tests. This matches DRT behavior.
996
997 2010-09-30  Adam Barth  <abarth@webkit.org>
998
999         Third attempt.  We need a better integration test environment.
1000
1001         * Scripts/webkitpy/common/net/failuremap.py:
1002         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1003
1004 2010-09-30  Robert Hogan  <robert@webkit.org>
1005
1006         Reviewed by Andreas Kling.
1007
1008         [Qt] Support for PlainTextController
1009
1010         Unskip editing/text-iterator/basic-iteration.html
1011
1012         https://bugs.webkit.org/show_bug.cgi?id=38805
1013
1014         * DumpRenderTree/qt/DumpRenderTree.pro:
1015         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1016         (WebCore::DumpRenderTree::DumpRenderTree):
1017         (WebCore::DumpRenderTree::initJSObjects):
1018         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1019         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Added.
1020         (PlainTextController::PlainTextController):
1021         (PlainTextController::plainText):
1022         * DumpRenderTree/qt/PlainTextControllerQt.h: Added.
1023
1024 2010-09-30  Adam Barth  <abarth@webkit.org>
1025
1026         Unreviewed.  Second attempt to fix sheriffbot.
1027
1028         * Scripts/webkitpy/common/net/buildbot.py:
1029
1030 2010-09-30  Adam Barth  <abarth@webkit.org>
1031
1032         Unreviewed.
1033
1034         This patch should stop the sheriffbot from throwing an exception.
1035
1036         * Scripts/webkitpy/common/net/buildbot.py:
1037
1038 2010-09-30  Brian Weinstein  <bweinstein@apple.com>
1039
1040         Reviewed by Adam Roben.
1041
1042         The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
1043         https://bugs.webkit.org/show_bug.cgi?id=46926
1044
1045         * BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows 
1046             Release Tests, and two bots running Windows Debug Tests, instead of four running both.
1047
1048 2010-09-30  Adam Barth  <abarth@webkit.org>
1049
1050         Reviewed by Eric Seidel.
1051
1052         webkit-patch find-flaky-tests should print results URLs
1053         https://bugs.webkit.org/show_bug.cgi?id=46917
1054
1055         Printing out the results URL makes find-flaky-tests more actionable
1056         because you can see what happens when a test fails.  The output from
1057         the script is still pretty noisy, but it seems useful.
1058
1059         * Scripts/webkitpy/tool/commands/queries.py:
1060
1061 2010-09-30  Chris Marrin  <cmarrin@apple.com>
1062
1063         Reviewed by Simon Fraser.
1064
1065         Make 2D accelerated canvas rendering build on Mac
1066         https://bugs.webkit.org/show_bug.cgi?id=46007
1067         
1068         Added ACCELERATED_2D_CANVAS to build-webkit
1069
1070         * Scripts/build-webkit:
1071
1072 2010-09-29  Kenneth Russell  <kbr@google.com>
1073
1074         Reviewed by Dimitri Glazkov.
1075
1076         [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
1077         https://bugs.webkit.org/show_bug.cgi?id=46849
1078
1079         Added offscreen code path for WebGraphicsContext3DDefaultImpl which
1080         works with the compositor integration in both DumpRenderTree and
1081         test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
1082         and thereby trigger the compositor's readback code path. Added support
1083         for --enable-accelerated-compositing to DumpRenderTree.
1084
1085         Tested in both test_shell and DumpRenderTree on Linux, the latter by
1086         modifying a compositing layout test, dumping the pixels and verifying
1087         that they matched the output when the compositor was active.
1088
1089         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1090         (main):
1091         * DumpRenderTree/chromium/TestShell.cpp:
1092         (TestShell::TestShell):
1093         (TestShell::resetWebSettings):
1094         * DumpRenderTree/chromium/TestShell.h:
1095         (TestShell::setAcceleratedCompositingEnabled):
1096         * DumpRenderTree/chromium/WebPreferences.cpp:
1097         (WebPreferences::reset):
1098         (WebPreferences::applyTo):
1099         * DumpRenderTree/chromium/WebPreferences.h:
1100         * DumpRenderTree/chromium/WebViewHost.cpp:
1101         (WebViewHost::scheduleComposite):
1102         * DumpRenderTree/chromium/WebViewHost.h:
1103
1104 2010-09-30  Adam Roben  <aroben@apple.com>
1105
1106         Ensure that QueueEngine cleans up its log files when its delegate
1107         tells it to stop processing work
1108
1109         Reviewed by Adam Barth.
1110
1111         Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
1112         in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
1113         Windows
1114
1115         * Scripts/webkitpy/tool/bot/queueengine.py:
1116         (QueueEngine.run): Stop ourselves normally (including cleaning up log
1117         files) when the delegate tells us to stop processing work.
1118
1119         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1120         (LoggingDelegate.__init__): Moved code here from
1121         RaisingDelegate.__init__.
1122         (LoggingDelegate.expeced_callbacks): Added the stop_work_queue
1123         callback.
1124         (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
1125         (RaisingDelegate.__init__): Removed code that LoggingDelegate takes
1126         care of for us now.
1127         (QueueEngineTest.test_trivial): Make sure we got the expected stop
1128         message.
1129         (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
1130         remove the callbacks that are related to processing a single work
1131         item, rather than removing all callbacks after a certain point, as
1132         there are now more callbacks we expect to receive at the end.
1133
1134 2010-09-30  Adam Roben  <aroben@apple.com>
1135
1136         Fix path -> URL conversion on Cygwin
1137
1138         Reviewed by Adam Barth.
1139
1140         Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
1141         in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
1142
1143         * Scripts/webkitpy/layout_tests/port/base.py:
1144         (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
1145         assuming paths already have a leading slash.
1146
1147 2010-09-30  Adam Roben  <aroben@apple.com>
1148
1149         Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can
1150         be called more than once
1151
1152         The NPP_SetWindow call made when the plugin is torn down was confusing
1153         us, and was causing us to spew an error into the next test.
1154
1155         Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
1156         (r68520): plugins/access-after-page-destroyed.html failing on Windows
1157
1158         Reviewed by Anders Carlsson.
1159
1160         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
1161         (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
1162         Initialize member.
1163         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
1164         this isn't the first time this is called.
1165
1166 2010-09-30  Eric Seidel  <eric@webkit.org>
1167
1168         Reviewed by Adam Barth.
1169
1170         webkit-patch upload warns that I'm using Xcode when I'm not
1171         https://bugs.webkit.org/show_bug.cgi?id=46869
1172
1173         String.find returns -1 when not found, so switched to "in".
1174
1175         * Scripts/webkitpy/common/system/user.py:
1176         * Scripts/webkitpy/common/system/user_unittest.py:
1177
1178 2010-09-30  Eric Seidel  <eric@webkit.org>
1179
1180         Reviewed by Adam Barth.
1181
1182         webkit-patch failure-reason dies if non-trunk commits are in the blame range
1183         https://bugs.webkit.org/show_bug.cgi?id=46866
1184
1185         I also made failure-reason use RegressionWindow in a cleaner way.
1186
1187         * Scripts/webkitpy/tool/commands/queries.py:
1188
1189 2010-09-29  Adam Barth  <abarth@webkit.org>
1190
1191         Reviewed by Eric Seidel.
1192
1193         webkit-patch find-flaky-tests
1194         https://bugs.webkit.org/show_bug.cgi?id=46876
1195
1196         This command helps us find flaky tests so we can squash them.
1197
1198         * Scripts/webkitpy/tool/commands/queries.py:
1199
1200 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1201
1202         Fix export to use '?' instead of 'null' for
1203         tests with no results.
1204         
1205         * CSSTestSuiteHarness/harness/harness.js:
1206
1207 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1208
1209         Add a warning when a test requires special steps.
1210         Add a Print Preview button for 'paged' tests that
1211         brings up the print dialog, allowing the user to 
1212         judge paged media tests.
1213
1214         * CSSTestSuiteHarness/harness/harness.css:
1215         * CSSTestSuiteHarness/harness/harness.html:
1216         * CSSTestSuiteHarness/harness/harness.js:
1217         (TestSuite.prototype.loadTest):
1218         (TestSuite.prototype.processFlags):
1219
1220 2010-09-29  Adam Barth  <abarth@webkit.org>
1221
1222         Reviewed by Eric Seidel.
1223
1224         Remove revisions_casuing_failures
1225         https://bugs.webkit.org/show_bug.cgi?id=46872
1226
1227         This function exists only to be unit tested.
1228
1229         * Scripts/webkitpy/common/net/failuremap.py:
1230         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1231         * Scripts/webkitpy/tool/mocktool.py:
1232
1233 2010-09-29  Adam Barth  <abarth@webkit.org>
1234
1235         Reviewed by Eric Seidel.
1236
1237         SheriffBot should post the list of failing tests to bugs
1238         https://bugs.webkit.org/show_bug.cgi?id=46871
1239
1240         * Scripts/webkitpy/common/net/buildbot.py:
1241         * Scripts/webkitpy/common/net/failuremap.py:
1242         * Scripts/webkitpy/common/net/regressionwindow.py:
1243         * Scripts/webkitpy/tool/bot/sheriff.py:
1244         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1245         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1246         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1247         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1248         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1249         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1250         * Scripts/webkitpy/tool/mocktool.py:
1251
1252 2010-09-29  Brent Fulgham  <bfulgham@webkit.org>
1253
1254         Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
1255
1256         [WinCairo] Adds a build slave.
1257         https://bugs.webkit.org/show_bug.cgi?id=46360
1258
1259         * BuildSlaveSupport/build.webkit.org-config/config.json: Add
1260         entries for a debug build of the WinCairo port.
1261         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
1262         platform flag to configuration for wincairo (like gtk, chromium, etc.)
1263         * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
1264         * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
1265
1266 2010-09-29  Adam Barth  <abarth@webkit.org>
1267
1268         Reviewed by Eric Seidel.
1269
1270         Move more SheriffBot smarts into FailureMap
1271         https://bugs.webkit.org/show_bug.cgi?id=46703
1272
1273         This patch pushes the FailureMap model object further into the
1274         SheriffBot machine.  In addition, it moves a couple operations on this
1275         object from SheriffBot itself to the model.
1276
1277         Eventually, FailureMap will be the canonical context object for
1278         SheriffBot operations.  FailureMap represents a map of the current
1279         failures on the bots that might require remediation.
1280
1281         * Scripts/webkitpy/common/net/failuremap.py:
1282         * Scripts/webkitpy/common/net/regressionwindow.py:
1283         * Scripts/webkitpy/tool/commands/queries.py:
1284         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1285         * Scripts/webkitpy/tool/mocktool.py:
1286
1287 2010-09-29  Tony Chang  <tony@chromium.org>
1288
1289         Reviewed by James Robinson.
1290
1291         [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
1292         https://bugs.webkit.org/show_bug.cgi?id=46829
1293
1294         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1295         (DRTDevToolsClient::DRTDevToolsClient):
1296         * DumpRenderTree/chromium/TestShell.cpp:
1297         (TestShell::TestShell):
1298         * DumpRenderTree/chromium/WebViewHost.cpp:
1299         (WebViewHost::postAccessibilityNotification):
1300         (WebViewHost::WebViewHost):
1301
1302 2010-09-29  Chris Fleizach  <cfleizach@apple.com>
1303
1304         Reviewed by Darin Adler.
1305
1306         AX: implement CSS3 Speech "speak"
1307         https://bugs.webkit.org/show_bug.cgi?id=46827
1308
1309         * DumpRenderTree/AccessibilityUIElement.cpp:
1310         (speakCallback):
1311         (AccessibilityUIElement::speak):
1312         (AccessibilityUIElement::getJSClass):
1313         * DumpRenderTree/AccessibilityUIElement.h:
1314         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1315         (AccessibilityUIElement::speak):
1316
1317 2010-09-29  Mihai Parparita  <mihaip@chromium.org>
1318
1319         Reviewed by Adam Barth.
1320
1321         Record bot ID when updating queue status
1322         https://bugs.webkit.org/show_bug.cgi?id=46764
1323         
1324         Since we now have multiple bots handling patches from the commit queue,
1325         we need to differentiate status updates from them, so that we can group
1326         the queue status page in a less confusing way.
1327
1328         * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
1329         * QueueStatusServer/model/queuestatus.py: Add bot_id property
1330         * QueueStatusServer/templates/updatestatus.html: Add bot_id input
1331         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
1332         * Scripts/webkitpy/common/net/statusserver.py: Add bot_id
1333         * Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
1334         * Scripts/webkitpy/tool/main.py: Add --bot-id
1335         * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
1336
1337 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1338
1339         No review.
1340         
1341         References always refert to a file in .xht format, even
1342         for HTML tests, so fix their loading.
1343
1344         * CSSTestSuiteHarness/harness/harness.js:
1345         (TestSuite.prototype.loadRef):
1346
1347 2010-09-28  Johnny Ding  <jnd@chromium.org>
1348
1349         Reviewed by Adam Barth.
1350
1351         https://bugs.webkit.org/show_bug.cgi?id=41292
1352         Add a new parameter to the test plugin to allow specifying a script 
1353         and a mouse/keyboard event. The specified script will be evaluated
1354         in the browser when the specified event is received by the plugin.
1355
1356         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1357         (pluginAllocate):
1358         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1359         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1360         (NPP_New):
1361         (handleEventCarbon):
1362         (handleEventCocoa):
1363
1364 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1365
1366         Fix export by adding missing argument.
1367
1368         * CSSTestSuiteHarness/harness/harness.js:
1369         (TestSuite.prototype.showResultsForAllTests):
1370
1371 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1372
1373         [wx] Build fix, add missing import.
1374
1375         * wx/packaging/build-win-installer.py:
1376
1377 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1378
1379         No review
1380         
1381         Show which tests have been run by dimming them out in the test list.
1382         
1383         Adjust some element sizes.
1384         
1385         * CSSTestSuiteHarness/harness/harness.css:
1386         (#test-list > option.untested):
1387         (#test-list > option.completed):
1388         (#output):
1389         (.output-options):
1390         * CSSTestSuiteHarness/harness/harness.js:
1391         (Test):
1392         (TestSuite.prototype.fillTestList):
1393         (TestSuite.prototype.updateTestList):
1394         (TestSuite.prototype.setSelectedChapter):
1395         (TestSuite.prototype.recordResult):
1396         (TestSuite.prototype.markTestCompleted):
1397         (TestSuite.prototype.testCompletionStateChanged):
1398         (TestSuite.prototype.loadTestStatus):
1399
1400 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1401
1402         No review.
1403         
1404         Implement export of various queries on the test database, sharing
1405         code with that which displays results inline.
1406
1407         * CSSTestSuiteHarness/harness/harness.js:
1408         ():
1409         (TestSuite.prototype.exportResultsCompletion.var):
1410         (TestSuite.prototype.exportResultsCompletion):
1411         (TestSuite.prototype.showResultsForCompletedTests):
1412         (TestSuite.prototype.exportResultsForCompletedTests):
1413         (TestSuite.prototype.showResultsForAllTests):
1414         (TestSuite.prototype.exportResultsForAllTests):
1415         (TestSuite.prototype.exportResultsForTestsNotRun):
1416         (TestSuite.prototype.exportResultsForTestsWithStatus):
1417         (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
1418
1419 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1420
1421         No review.
1422
1423         Work around uncertainty about the order of database
1424         transactions when creating the database, so that we don't
1425         try to query the table before it has been created.
1426
1427         * CSSTestSuiteHarness/harness/harness.js:
1428         (TestSuite):
1429         (TestSuite.prototype.databaseCreated):
1430         (TestSuite.prototype.storeTestResult):
1431         (TestSuite.prototype.populateDatabaseFromTestInfoData):
1432         (TestSuite.prototype.queryDatabaseForTestsWithStatus):
1433         (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
1434         (TestSuite.prototype.queryDatabaseForCompletedTests):
1435         (TestSuite.prototype.queryDatabaseForTestsNotRun):
1436
1437 2010-09-28  Tony Chang  <tony@chromium.org>
1438
1439         Reviewed by Eric Seidel.
1440
1441         add python keyring support to webkit-patch
1442         https://bugs.webkit.org/show_bug.cgi?id=41269
1443
1444         * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
1445             the python keyring module
1446         * Scripts/webkitpy/common/net/credentials_unittest.py:
1447         * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
1448         * Scripts/webkitpy/common/system/user_unittest.py:
1449         * Scripts/webkitpy/tool/mocktool.py:
1450
1451 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1452
1453         Reviewed by Gustavo Noronha Silva.
1454
1455         [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
1456         https://bugs.webkit.org/show_bug.cgi?id=46740
1457
1458         * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
1459         fonts which can be used to fully test FontConfig rendering settings.
1460
1461 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1462
1463         Reviewed by Gustavo Noronha Silva.
1464
1465         [gtk] Fedora has a different path for the liberation fonts
1466         https://bugs.webkit.org/show_bug.cgi?id=46709
1467
1468         When searching for DRT fonts, also look in the path where those fonts
1469         are commonly found on Fedora systems.
1470
1471         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1472         (initializeFonts): Include logic for looking for Fedora-style font paths.
1473
1474 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1475
1476         Reviewed by Andreas Kling.
1477
1478         run-webkit-tests needs an updated list of directories with webgl tests
1479         https://bugs.webkit.org/show_bug.cgi?id=46747
1480
1481         Update the list of directories containing WebGL tests and a unit test
1482         which depends on this list.
1483
1484         * Scripts/old-run-webkit-tests: Update the list of directories.
1485         * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
1486         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
1487
1488 2010-09-28  Adam Barth  <abarth@webkit.org>
1489
1490         Reviewed by Eric Seidel.
1491
1492         Introduce FailureMap to summaries the failures status of all the bots
1493         https://bugs.webkit.org/show_bug.cgi?id=46700
1494
1495         This patch gives the SheriffBot a handle on the list of failing tests.
1496
1497         * Scripts/webkitpy/common/net/buildbot.py:
1498         * Scripts/webkitpy/common/net/failuremap.py: Added.
1499         * Scripts/webkitpy/tool/commands/queries.py:
1500         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1501         * Scripts/webkitpy/tool/mocktool.py:
1502
1503 2010-09-28  Adam Roben  <aroben@apple.com>
1504
1505         Update for the addition of WKPageUIClient::didNotHandleKeyEvent
1506
1507         Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
1508         tell a WebKit2 client application that a key event was not handled
1509
1510         Reviewed by Kenneth Rohde Christiansen and Sam Weinig.
1511
1512         * MiniBrowser/mac/BrowserWindowController.m:
1513         (-[BrowserWindowController awakeFromNib]):
1514         * MiniBrowser/win/BrowserView.cpp:
1515         (BrowserView::create):
1516         * WebKitTestRunner/TestController.cpp:
1517         (WTR::createOtherPage):
1518         (WTR::TestController::initialize):
1519
1520 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1521
1522         Unreviewed.
1523
1524         Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
1525         for the test order, but instead use information from testinfo.data.
1526         
1527         * CSSTestSuiteHarness/harness/harness.html:
1528         * CSSTestSuiteHarness/harness/harness.js:
1529
1530 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1531
1532         [wx] Build fix, don't try to get the svn revision from the git repo when packaging,
1533         it causes the process to hang on the gitorious repo.
1534
1535         * wx/packaging/build-mac-installer.py:
1536         * wx/packaging/build-win-installer.py:
1537
1538 2010-09-28  Adam Roben  <aroben@apple.com>
1539
1540         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
1541         called
1542
1543         Reviewed by Anders Carlsson.
1544
1545         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
1546         Full-page Adobe Reader does not paint until window is resized
1547
1548         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1549         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
1550         this level.
1551
1552         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
1553         NPP_SetWindow.
1554
1555         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
1556         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
1557         the plugin's HWND has a non-zero size and that its size/position
1558         matches that specified in the NPWindow.
1559
1560         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1561         (NPP_SetWindow): Call through to the PluginTest.
1562
1563         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1564         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
1565         the files as it saw fit.
1566
1567 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1568
1569         Reviewed by Andreas Kling.
1570
1571         [Qt] Remove support for Qt 4.5
1572         https://bugs.webkit.org/show_bug.cgi?id=46718
1573
1574         Remove the code for versions of Qt prior to 4.6.
1575
1576         * DumpRenderTree/qt/EventSenderQt.cpp:
1577         (EventSender::addTouchPoint):
1578         (EventSender::updateTouchPoint):
1579         (EventSender::setTouchModifier):
1580         (EventSender::touchStart):
1581         (EventSender::touchMove):
1582         (EventSender::touchEnd):
1583         (EventSender::clearTouchPoints):
1584         (EventSender::releaseTouchPoint):
1585         (EventSender::sendTouchEvent):
1586         * DumpRenderTree/qt/EventSenderQt.h:
1587         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1588         (TextInputController::setMarkedText):
1589         * QtTestBrowser/launcherwindow.cpp:
1590         (LauncherWindow::LauncherWindow):
1591         (LauncherWindow::initializeView):
1592         (LauncherWindow::createChrome):
1593         (LauncherWindow::sendTouchEvent):
1594         (LauncherWindow::eventFilter):
1595         (LauncherWindow::applyZoom):
1596         (LauncherWindow::setTouchMocking):
1597         * QtTestBrowser/launcherwindow.h:
1598         * QtTestBrowser/utils.cpp:
1599         (urlFromUserInput):
1600         * QtTestBrowser/webview.cpp:
1601         (WebViewGraphicsBased::animatedFlip):
1602         (WebViewGraphicsBased::animatedYFlip):
1603         * QtTestBrowser/webview.h:
1604         (WebViewGraphicsBased::setYRotation):
1605
1606 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
1607
1608         Reviewed by Andreas Kling.
1609
1610         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
1611         which should point to wcecompat installation. Needs wcecompat
1612         library from http://github.com/mauricek/wcecompat .
1613
1614         * DumpRenderTree/qt/DumpRenderTree.pro:
1615         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1616         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1617
1618 2010-09-28  Daniel Bates  <dbates@rim.com>
1619
1620         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
1621         <https://bugs.webkit.org/show_bug.cgi?id=39136>
1622
1623         Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
1624         In particular, this change caused Sheriffbot to raise an exception when
1625         trying to parse the bug id on a bug page. We need to look into this
1626         some more.
1627
1628         * Scripts/webkitpy/common/net/bugzilla.py:
1629         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1630         * Scripts/webkitpy/tool/bot/sheriff.py:
1631         * Scripts/webkitpy/tool/commands/download.py:
1632         * Scripts/webkitpy/tool/commands/queues.py:
1633         * Scripts/webkitpy/tool/commands/upload.py:
1634         * Scripts/webkitpy/tool/steps/closebug.py:
1635         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1636         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1637         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1638
1639 2010-09-28  Adam Barth  <abarth@webkit.org>
1640
1641         Reviewed by Eric Seidel.
1642
1643         Move RegressionWindow further up the dependency chain
1644         https://bugs.webkit.org/show_bug.cgi?id=46698
1645
1646         Baby steps towards pushing this information into bug posts.
1647
1648         * Scripts/webkitpy/common/net/buildbot.py:
1649         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1650         * Scripts/webkitpy/common/net/regressionwindow.py:
1651         * Scripts/webkitpy/tool/commands/queries.py:
1652
1653 2010-09-27  Daniel Bates  <dbates@rim.com>
1654
1655         Reviewed by Adam Barth.
1656
1657         sheriffbot can't roll out security patches
1658         https://bugs.webkit.org/show_bug.cgi?id=39136
1659
1660         Make SheriffBot determine if it's authorized to view a bug
1661         whose change it wants to rollout before it tries to rollout
1662         the change.
1663
1664         Moreover, make both webkit-patch and Sheriffbot provide human-
1665         readable error messages when they are not authorized to view
1666         a bug and when a bug number is invalid.
1667
1668         Currently, Sheriffbot does not parse Bugzilla bugs for
1669         <bug error="...">, which indicates an error when retrieving
1670         a bug. In particular, error="NotPermitted" if a person (or bot)
1671         is not authorized to view a bug. For such error="NotPermitted" bugs,
1672         Sheriffbot raises an exception when parsing the bug report and
1673         this exception does not explicitly indicate Sheriffbot's lack
1674         of authorization. Instead, Sheriffbot should explicitly check
1675         for the presence <bug error="..."> before operating on a bug
1676         and error with a human-readable message if it's not permitted
1677         to view it.
1678
1679         * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
1680         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1681           - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
1682           - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
1683           - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
1684         * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
1685         * Scripts/webkitpy/tool/commands/download.py: Ditto.
1686         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
1687         * Scripts/webkitpy/tool/commands/upload.py: Ditto.
1688         * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
1689         * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
1690         * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
1691         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
1692
1693 2010-09-27  Adam Barth  <abarth@webkit.org>
1694
1695         Reviewed by Eric Seidel.
1696
1697         Expose more more failure information from Buildbot to SheriffBot
1698         https://bugs.webkit.org/show_bug.cgi?id=46697
1699
1700         This patch moves the information about what tests failured closer to
1701         SheriffBot.  There are still a couple more patches to go before
1702         SheriffBot can post this information to bugs, but this is a step in
1703         that direction.  Yay for unit tests, which caught some bugs in earlier
1704         versions of this patch.
1705
1706         * Scripts/webkitpy/common/net/buildbot.py:
1707         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1708         * Scripts/webkitpy/common/net/regressionwindow.py: Added.
1709         * Scripts/webkitpy/tool/commands/queries.py:
1710
1711 2010-09-27  Eric Seidel  <eric@webkit.org>
1712
1713         Unreviewed.  Fixing 500 error seen in the status server.
1714
1715         It turns out that a = b = []; b.append(1); then a[0] will be 1!
1716         This should have been obvious to me, I guess, but it was not what I was expecting.
1717
1718         * QueueStatusServer/model/activeworkitems.py:
1719
1720 2010-09-27  Adam Barth  <abarth@webkit.org>
1721
1722         Reviewed by Eric Seidel.
1723
1724         commit-queue should reject patches that fail to land
1725         https://bugs.webkit.org/show_bug.cgi?id=46694
1726
1727         This can happen, for example, if there's no reviewer.  Without this
1728         patch, we'll keep retrying the patch.
1729
1730         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1731         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1732
1733 2010-09-27  Simon Fraser  <simon.fraser@apple.com>
1734
1735         Rubber-stamped by Adele Peterson.
1736
1737         Add a harness for running the CSS 2.1 test suite.
1738         
1739         This harness assumes that you've got a local a copy of the suite
1740         adjacent to the 'harness' directory.
1741         
1742         The harness lets you go through the tests in chapter order,
1743         denoting pass/fail/skipped for each test.
1744         
1745         It uses a client-side database to store the results of testing.
1746
1747         * CSSTestSuiteHarness/harness/harness.css: Added.
1748         * CSSTestSuiteHarness/harness/harness.html: Added.
1749         * CSSTestSuiteHarness/harness/harness.js: Added.
1750
1751 2010-09-27  Eric Seidel  <eric@webkit.org>
1752
1753         Reviewed by Adam Barth.
1754
1755         Patch locks should expire if a patch is marked for retry
1756         https://bugs.webkit.org/show_bug.cgi?id=46682
1757
1758         This was part Adam's original CommitQueueTask design,
1759         but support for it was missing from the server.
1760         I added the support, but triggering lock-release based on this
1761         special "retry" status feels a bit strange so I added a FIXME.
1762
1763         I also changed the text in queuestatus.html to say "Lock Acquired"
1764         since "Last Activity" isn't really true.  We only update the lock
1765         date when the patch is started, not on every status update.
1766
1767         I also noticed an exception in next-patch, which I fixed by re-writing
1768         the unzip logic in activeworkitems.py again.
1769
1770         * QueueStatusServer/handlers/updatestatus.py:
1771         * QueueStatusServer/model/activeworkitems.py:
1772         * QueueStatusServer/templates/queuestatus.html:
1773
1774 2010-09-27  Tony Chang  <tony@chromium.org>
1775
1776         Reviewed by David Levin.
1777
1778         [chromium] fix a warning when compiling DRT on 32-bit linux
1779         https://bugs.webkit.org/show_bug.cgi?id=46641
1780
1781         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1782         (DRTPrinter::handleImage):
1783
1784 2010-09-27  Eric Seidel  <eric@webkit.org>
1785
1786         Reviewed by Adam Barth.
1787
1788         queue-status should report when the patch was last locked to a queue
1789         https://bugs.webkit.org/show_bug.cgi?id=46674
1790
1791         This isn't necessarily the best way to expose this information
1792         but having this accessible via the web interface is very
1793         useful until we come up with a nicer way to display this.
1794
1795         I also cleaned up the code in activeworkitems.py a little
1796         to use list comprehensions and to have the code work with
1797         pairs instead of two lists at once.  Eventually I think those
1798         item/time pairs need to be their own little helper class.
1799
1800         * QueueStatusServer/handlers/queuestatus.py:
1801         * QueueStatusServer/model/activeworkitems.py:
1802         * QueueStatusServer/templates/queuestatus.html:
1803
1804 2010-09-27  Tony Chang  <tony@chromium.org>
1805
1806         Reviewed by David Levin.
1807
1808         [chromium] fix detection of missing fonts on DRT
1809         https://bugs.webkit.org/show_bug.cgi?id=46651
1810
1811         * DumpRenderTree/chromium/TestShellGtk.cpp:
1812         (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
1813
1814 2010-09-27  Tony Chang  <tony@chromium.org>
1815
1816         Reviewed by Dimitri Glazkov.
1817
1818         add webkit unit tests to the chromium testers
1819         https://bugs.webkit.org/show_bug.cgi?id=46669
1820
1821         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1822         * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
1823
1824 2010-09-27  Kwang Yul Seo  <skyul@company100.net>
1825
1826         Unreviewed.
1827
1828         Adding myself to the committers list.
1829
1830         * Scripts/webkitpy/common/config/committers.py:
1831
1832 2010-09-27  Mihai Parparita  <mihaip@chromium.org>
1833
1834         Reviewed by Eric Seidel.
1835
1836         webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
1837         https://bugs.webkit.org/show_bug.cgi?id=46634
1838         
1839         Use OutputCapture to prevent console spam (and also check for expected
1840         output).
1841
1842         * Scripts/webkitpy/common/system/user_unittest.py:
1843
1844 2010-09-27  Eric Seidel  <eric@webkit.org>
1845
1846         Reviewed by James Robinson.
1847
1848         start-commit-queue should abort any rebases in progress
1849         https://bugs.webkit.org/show_bug.cgi?id=46640
1850
1851         webkit-patch commit-queue would do this itself, but this just
1852         helps ensure that the commit-queue script is properly updated
1853         before we run it (in the case where a previous rebase is in
1854         progress the git svn rebase would not work before we run the
1855         commit-queue).
1856
1857         * EWSTools/start-commit-queue.sh:
1858
1859 2010-09-18  Martin Robinson  <mrobinson@igalia.com>
1860
1861         Reviewed by Gustavo Noronha Silva.
1862
1863         [GTK] Clean up the DRT fonts.conf and switch to Liberation
1864         https://bugs.webkit.org/show_bug.cgi?id=46038
1865
1866         Switch to Liberation fonts for GTK+ layout tests. This will make our
1867         test results metric-compatible with many Windows/Chromium results. It
1868         also simplifies the fonts.conf that we load and prepares the way for
1869         fixing many font bugs.
1870
1871         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1872         (initializeFonts): Initialize a known list of fonts instead of loading
1873         every font in the WEBKIT_TESTFONTS directory.
1874         * DumpRenderTree/gtk/fonts.conf: Removed.
1875         * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
1876         * DumpRenderTree/gtk/fonts/fonts.conf: Added.
1877         * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
1878         we can load both fonts.conf and AHEM____.TTF from this location.
1879         * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
1880         it is no longer used.
1881
1882 2010-09-26  Mihai Parparita  <mihaip@chromium.org>
1883
1884         Reviewed by Ojan Vafai.
1885
1886         new-run-webkit-httpd fails if Perl is not installed
1887         https://bugs.webkit.org/show_bug.cgi?id=46602
1888         
1889         Make Port._read_configuration catch all exceptions, since trying to run
1890         perl (because of _webkit_build_directory) when it's not installed throws
1891         a WindowsError or OSError, not an IOError (this became an issue after 
1892         r68268, since ChromiumPort ends up calling Port.default_configuration in
1893         its constructor, which means that we're ending up on this codepath in
1894         non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
1895         new-run-webkit-httpd).
1896
1897         * Scripts/webkitpy/layout_tests/port/base.py:
1898         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1899
1900 2010-09-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1901
1902         Reviewed by Antonio Gomes.
1903
1904         [EFL] Add setting API to set a local storage database path.
1905         https://bugs.webkit.org/show_bug.cgi?id=45446
1906
1907         Add a setting API to set local storage database path.
1908
1909         * EWebLauncher/main.c:
1910         (on_key_down):
1911         (browserCreate):
1912         (main):
1913
1914 2010-09-26  Sam Weinig  <sam@webkit.org>
1915
1916         Reviewed by Anders Carlsson.
1917
1918         Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
1919         https://bugs.webkit.org/show_bug.cgi?id=46587
1920
1921         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1922
1923 2010-09-26  Antonio Gomes  <agomes@rim.com>
1924
1925         Reviewed by Kenneth Rohde Christiansen.
1926
1927         DRT/Mac nodesFromRect support
1928
1929         [Mac][DRT] Implement LayoutTestController::nodesFromRect
1930         https://bugs.webkit.org/show_bug.cgi?id=46580
1931
1932         Implements LayoutTestController::nodesFromRect for Mac DRT, and
1933         adding stubs for GTK+ and Windows.
1934
1935         * DumpRenderTree/LayoutTestController.cpp:
1936         (nodesFromRectCallback):
1937         (LayoutTestController::staticFunctions):
1938         * DumpRenderTree/LayoutTestController.h:
1939         (LayoutTestController::LayoutTestController::nodesFromRect):
1940         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1941         (LayoutTestController::nodesFromRect):
1942
1943 2010-09-25  Nicolas Weber  <thakis@chromium.org>
1944
1945         Reviewed by Adam Barth.
1946
1947         https://bugs.webkit.org/show_bug.cgi?id=46555
1948         Fix typo in prepare-ChangeLog's help output.
1949
1950         * Scripts/prepare-ChangeLog:
1951
1952 2010-09-24  Sam Weinig  <sam@webkit.org>
1953
1954         Reviewed by Darin Adler.
1955
1956         Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
1957         <rdar://problem/8359279>
1958         https://bugs.webkit.org/show_bug.cgi?id=46546
1959
1960         * MiniBrowser/mac/BrowserWindowController.m:
1961         (mouseDidMoveOverElement):
1962         (-[BrowserWindowController awakeFromNib]):
1963         * MiniBrowser/win/BrowserView.cpp:
1964         (mouseDidMoveOverElement):
1965         (BrowserView::create):
1966         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1967         (WTR::InjectedBundlePage::InjectedBundlePage):
1968         * WebKitTestRunner/TestController.cpp:
1969         (WTR::createOtherPage):
1970         (WTR::TestController::initialize):
1971
1972 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
1973
1974         Reviewed by Adam Barth.
1975
1976         Allow rebaselines for webkit-patch rebaseline to be chosen
1977         https://bugs.webkit.org/show_bug.cgi?id=46407
1978         
1979         Instead of always rebaselining all failing tests, allow a subset to be
1980         chosen.
1981
1982         * Scripts/webkitpy/common/system/user.py:
1983         * Scripts/webkitpy/tool/commands/rebaseline.py:
1984
1985 2010-09-24  Ryosuke Niwa  <rniwa@webkit.org>
1986
1987         Reviewed by Tony Chang.
1988
1989         [chromium] Implement TextInputController::firstRectForCharacterRange
1990         https://bugs.webkit.org/show_bug.cgi?id=38100
1991
1992         Implemented TextInputController::firstRectForCharacterRange for chromium platform.
1993         No new tests are added since we need to implement the same feature in chromium side
1994         in order to enable any tests that uses this function.
1995
1996         * DumpRenderTree/chromium/TextInputController.cpp:
1997         (TextInputController::firstRectForCharacterRange): Added.
1998
1999 2010-09-24  Adam Barth  <abarth@webkit.org>
2000
2001         Reviewed by Eric Seidel.
2002
2003         commit-queue reports land failures as "PASS"
2004         https://bugs.webkit.org/show_bug.cgi?id=46530
2005
2006         We were ignoring the return value of land instead of passing it back to
2007         CommitQueue.  Of course, this was the one case I forgot to test!
2008
2009         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2010         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2011
2012 2010-09-24  Kenichi Ishibashi  <bashi@google.com>
2013
2014         Reviewed by Eric Seidel.
2015
2016         new-run-webkit-tests prints out nothing when build-dumprendertree fails
2017         https://bugs.webkit.org/show_bug.cgi?id=37563
2018
2019         Print error message when build-dumprendertree fails.
2020
2021         * Scripts/webkitpy/layout_tests/port/webkit.py:
2022         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2023
2024 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
2025
2026         Reviewed by Tony Chang.
2027
2028         NRWT doesn't respect config set with set-webkit-configuration
2029         https://bugs.webkit.org/show_bug.cgi?id=46278
2030         
2031         Use Port.default_configuration() instead of hardcoding Release in
2032         ChromiumPort configuration initialization, so that we still inherit the
2033         configuration set by set-webkit-configuration.
2034
2035         * Scripts/webkitpy/layout_tests/port/chromium.py:
2036         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2037
2038 2010-09-24  Chang Shu  <chang.shu@nokia.com>
2039
2040         Reviewed by Csaba Osztrogonác.
2041
2042         [Qt] Fix the code to check file existence.
2043         https://bugs.webkit.org/show_bug.cgi?id=46465
2044
2045         * QtTestBrowser/main.cpp:
2046         (main):
2047
2048 2010-09-23  Tony Chang  <tony@chromium.org>
2049
2050         Unreviewed, rolling out r68232.
2051         http://trac.webkit.org/changeset/68232
2052
2053         Broken NRWT on the canary bots.
2054
2055         * Scripts/webkitpy/layout_tests/port/chromium.py:
2056
2057 2010-09-23  Dirk Pranke  <dpranke@chromium.org>
2058
2059         Unreviewed, build fix.
2060
2061         r68008 broke new-run-webkit-tests in that the chromium ports no
2062         longer respect set-webkit-configuration. The correct fix for this
2063         is being pursued in bug 46278 (along with a bunch of unit tests),
2064         but in the meantime I'm reverting the particular lines that broke
2065         things. This was tested by hand.
2066
2067         * Scripts/webkitpy/layout_tests/port/chromium.py:
2068
2069 2010-09-23  Sam Weinig  <sam@webkit.org>
2070
2071         Reviewed by Anders Carlsson.
2072
2073         WebKit2 API: Need way to know when a frame is removed from the hierarchy
2074         <rdar://problem/8414062>
2075         https://bugs.webkit.org/show_bug.cgi?id=46432
2076
2077         * MiniBrowser/mac/BrowserWindowController.m:
2078         (didRemoveFrameFromHierarchy):
2079         (-[BrowserWindowController awakeFromNib]):
2080         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2081         (WTR::InjectedBundlePage::InjectedBundlePage):
2082         * WebKitTestRunner/TestController.cpp:
2083         (WTR::TestController::initialize):
2084
2085 2010-09-23  Tony Chang  <tony@chromium.org>
2086
2087         Reviewed by Dimitri Glazkov.
2088
2089         [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
2090         https://bugs.webkit.org/show_bug.cgi?id=46426
2091
2092         * DumpRenderTree/chromium/LayoutTestController.cpp:
2093         (LayoutTestController::LayoutTestController):
2094         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2095         * DumpRenderTree/chromium/LayoutTestController.h:
2096
2097 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2098
2099         Reviewed by Nate Chapin.
2100
2101         [GTK] r68199 introduced two test failures
2102         https://bugs.webkit.org/show_bug.cgi?id=46424
2103
2104         Fix a regression handling preference overrides that are attached to boolean properties.
2105
2106         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2107         (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
2108         so we must check for that when converting a string to a boolean.
2109
2110 2010-09-23  Dimitri Glazkov  <dglazkov@chromium.org>
2111
2112         Reviewed by David Levin.
2113
2114         Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
2115         https://bugs.webkit.org/show_bug.cgi?id=46406
2116
2117         This breaks when the method is called with specified size of data (image data), and the
2118         buffer hasn't yet reached this size.
2119
2120         * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
2121           index larger than 0.
2122
2123 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2124
2125         Reviewed by Nate Chapin.
2126
2127         [GTK] Some tests from r68174 fail on the GTK+ bots
2128         https://bugs.webkit.org/show_bug.cgi?id=46396
2129
2130         Simplify LayoutTestController::overridePreference to make it easier for
2131         people unfamiliar with the code to keep the list of preferences up to date.
2132         Add the conversion for enable-hyperlink-auditing.
2133
2134         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2135         (LayoutTestController::overridePreference): Use a simple if-else block to determine
2136         out the property name for overrridePreference. Also simplify the logic for setting
2137         string properties. Add the conversion for enable-hyperlink-auditing.
2138
2139 2010-09-23  Tony Chang  <tony@chromium.org>
2140
2141         Reviewed by David Levin.
2142
2143         [chromium] add caretBrowsingEnabled to WebSettings and DRT
2144         https://bugs.webkit.org/show_bug.cgi?id=46388
2145
2146         * DumpRenderTree/chromium/LayoutTestController.cpp:
2147         (LayoutTestController::overridePreference):
2148         * DumpRenderTree/chromium/WebPreferences.cpp:
2149         (WebPreferences::reset):
2150         (WebPreferences::applyTo):
2151         * DumpRenderTree/chromium/WebPreferences.h:
2152
2153 2010-09-23  Nate Chapin  <japhet@chromium.org>
2154
2155         Reviewed by Darin Fisher.
2156
2157         Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
2158         https://bugs.webkit.org/show_bug.cgi?id=30458
2159
2160         * DumpRenderTree/chromium/LayoutTestController.cpp:
2161         (LayoutTestController::overridePreference):
2162         * DumpRenderTree/chromium/WebPreferences.cpp:
2163         (WebPreferences::reset):
2164         (WebPreferences::applyTo):
2165         * DumpRenderTree/chromium/WebPreferences.h:
2166         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2167         (resetDefaultsToConsistentValues):
2168         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2169         (LayoutTestController::overridePreference):
2170
2171 2010-09-21  Stephen White  <senorblanco@chromium.org>
2172
2173         Reviewed by David Levin.
2174
2175         Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
2176         https://bugs.webkit.org/show_bug.cgi?id=46208
2177
2178         This flag allows the layout tests to be run with or without accelerated
2179         2D canvas rendering.
2180
2181         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2182         (main):
2183         Declare the new flag string, and check for it on startup.
2184         * DumpRenderTree/chromium/TestShell.cpp:
2185         (TestShell::TestShell):
2186         Add a boolean for the new flag, in order to preserve its value over
2187         preferences reset.
2188         (TestShell::resetWebSettings):
2189         Set the new flag to the stored value on reset.
2190         * DumpRenderTree/chromium/TestShell.h:
2191         (TestShell::setAccelerated2dCanvasEnabled):
2192         Add an accessor for the new flag.
2193         * DumpRenderTree/chromium/WebPreferences.cpp:
2194         (WebPreferences::reset):
2195         Initialize the new flag to false.
2196         (WebPreferences::applyTo):
2197         Copy the flag's value to the WebSettings.
2198         * DumpRenderTree/chromium/WebPreferences.h:
2199         Add the new flag.
2200
2201 2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2202
2203         Reviewed by Simon Hausmann.
2204
2205         [Qt] Refactor QtWebKitPlatformPlugin interface
2206
2207         Make it easier to keep source-compability for the
2208         QtWebKitPlatformPlugin interface, and run qmake
2209         on the example (but not build) for convenience. 
2210
2211         https://bugs.webkit.org/show_bug.cgi?id=46345
2212
2213         * Scripts/webkitdirs.pm:
2214
2215 2010-09-23  Adam Barth  <abarth@webkit.org>
2216
2217         Reviewed by Eric Seidel.
2218
2219         Tweak some status messages that Eric thought were confusing
2220         https://bugs.webkit.org/show_bug.cgi?id=46342
2221
2222         * Scripts/webkitpy/tool/commands/queues.py:
2223         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2224
2225 2010-09-22  Adam Barth  <abarth@webkit.org>
2226
2227         Reviewed by Eric Seidel.
2228
2229         Fix comm-queue typo
2230         https://bugs.webkit.org/show_bug.cgi?id=46339
2231
2232         We were missing a "self".  The real problem is that we didn't have an
2233         integration test for the failure case.
2234
2235         * Scripts/webkitpy/tool/commands/queues.py:
2236         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2237
2238 2010-09-22  Adam Barth  <abarth@webkit.org>
2239
2240         Reviewed by Eric Seidel.
2241
2242         commit-queue should log more detailed messages to the QueueStatusServer
2243         https://bugs.webkit.org/show_bug.cgi?id=46333
2244
2245         When I created CommitQueueTask, I removed most of the previous logging.
2246         This patch adds back more detailed logging so folks can see their patch
2247         progress through the queue.
2248
2249         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2250         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2251         * Scripts/webkitpy/tool/commands/queues.py:
2252         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2253
2254 2010-09-22  Mihai Parparita  <mihaip@chromium.org>
2255
2256         Reviewed by Darin Fisher.
2257
2258         [Chromium] User style layout tests don't pass on Chromium
2259         https://bugs.webkit.org/show_bug.cgi?id=46069
2260
2261         Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
2262         crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
2263         behavior from other ports.
2264
2265         * DumpRenderTree/chromium/LayoutTestController.cpp:
2266         (LayoutTestController::addUserStyleSheet):
2267
2268 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2269
2270         Reviewed by Martin Robinson.
2271
2272         [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
2273         https://bugs.webkit.org/show_bug.cgi?id=46303.
2274
2275         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
2276         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
2277         CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
2278         property sheet.
2279         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
2280         * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
2281         appropriate property sheet for the build types.
2282         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
2283         configuration to use appropriate property sheet for CoreFoundation
2284         and CFLite-style builds.
2285
2286 2010-09-22  Adam Barth  <abarth@webkit.org>
2287
2288         Reviewed by Eric Seidel.
2289
2290         Optimize commit-queue performance for green trees
2291         https://bugs.webkit.org/show_bug.cgi?id=46254
2292
2293         This patch redesigns the controller logic for the commit-queue.  In the
2294         new design, the controller exercises much finer-grained control over
2295         the landing process.  In particular:
2296
2297         - Patches that fail to apply now get rejected almost immediately.
2298         - Patches that fail to build get rejects after two builds (instead of
2299           three builds and one test run).
2300         - Patches that run into a flaky test now get accepted after one build
2301           and two test runs instead of three full build-and-test runs.
2302
2303         The main cost of these optimizations is that we don't find out the tree
2304         has a failing test until the very end of the process, but if the tree
2305         has a busted test, there's not much we can do anyway.  We might as well
2306         burn commit-queue resources spinning optimisticly.
2307
2308         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
2309         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
2310         * Scripts/webkitpy/tool/commands/queues.py:
2311
2312 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2313
2314         Reviewed by Martin Robinson.
2315
2316         [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
2317         https://bugs.webkit.org/show_bug.cgi?id=46303.
2318
2319         * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
2320         for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
2321         WinCairo build.
2322         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
2323         * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
2324         build targets that use the new InjectedBundleCFLite.vsprops file.
2325
2326 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2327
2328         Unreviewed, build fix.
2329
2330         Fix bustage of rebaseline-chromium-webkit-tests resulting from
2331         r67974. Really need better unit tests for this tool :(
2332
2333         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2334
2335 2010-09-22  Adam Roben  <aroben@apple.com>
2336
2337         Unbreak test-webkitpy
2338
2339         * Scripts/webkitpy/test/main.py:
2340         (Tester.run_tests): Add a line that mysteriously got deleted.
2341
2342 2010-09-22  Adam Roben  <aroben@apple.com>
2343
2344         Make test-webkitpy test WebKit2's scripts
2345
2346         These scripts can't be in WebKitTools due to limitations of Apple's
2347         build process. But that doesn't mean we can't test them!
2348
2349         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
2350         WebKit2/Scripts
2351
2352         Reviewed by Adam Barth.
2353
2354         * Scripts/test-webkitpy:
2355         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
2356         Now takes an external_package_paths parameter and cleans both webkitpy
2357         and any external packages.
2358         (init): Added an external_package_paths parameter which we pass along
2359         to _clean_packages_with_test.
2360         (top level): Add WebKit2/Scripts/webkit2 as our only external package
2361         and pass it along to init and Tester.run_tests.
2362
2363         * Scripts/webkitpy/test/main.py:
2364         (Tester.run_tests): Added an optional external_package_paths
2365         parameter. We modify sys.path so that the external packages can be
2366         imported, and search for unittest files inside all external packages
2367         in addition to inside webkitpy.
2368
2369 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2370
2371         Reviewed by Tony Chang.
2372
2373         new-run-webkit-tests: r68063 broke linux python tests
2374
2375         Add a missing "from __future__ import with_statement" to this
2376         new file; the perils of testing only on the Mac and by review :(
2377
2378         https://bugs.webkit.org/show_bug.cgi?id=46293
2379
2380         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2381
2382 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2383
2384         Reviewed by Tony Chang.
2385
2386         Add a 'chromium-gpu' set of ports that will test the accelerated
2387         GPU paths. This patch adds:
2388
2389         - support for the '--accelerated-compositing' and
2390           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
2391           'no-' flags)
2392         - adds a new set of Ports that will look under
2393           platform/chromium-gpu-$OS/ for baselines before looking in the
2394           regular chromium search path
2395         - adds a new test_expectations.txt file in platform/chromium-gpu
2396           that skips all but the tests we actually want to run with
2397           acceleration.
2398
2399         This patch will allow us to run both with and without acceleration
2400         and to change the defaults for both the regular and -gpu options
2401         as the code evolves.
2402
2403         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
2404         each test bot.
2405
2406         https://bugs.webkit.org/show_bug.cgi?id=46225
2407
2408         * Scripts/webkitpy/layout_tests/port/chromium.py:
2409         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2410         * Scripts/webkitpy/layout_tests/port/factory.py:
2411         * Scripts/webkitpy/layout_tests/port/webkit.py:
2412
2413 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
2414
2415         Reviewed by Kenneth Rohde Christiansen.
2416
2417         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
2418         https://bugs.webkit.org/show_bug.cgi?id=43988
2419
2420         Runs a web debug server on port specified by QtTestBrowser
2421         argument -remote-inspector-port. Property
2422         _q_webInspectorServerPort of the QWebPage instance will be set
2423         according to the argument. All pages with that property set will
2424         be remotely inspectable.
2425
2426         URL for remote inspection of first QWebPage is
2427             http://localhost:9222/webkit/inspector/inspector.html?page=1
2428         where 1 is the number of the QWebPage instance.
2429
2430         The base URL yields an index page with links to the individual inspectors:
2431             http://localhost:9222/
2432
2433         * QtTestBrowser/launcherwindow.cpp:
2434         (LauncherWindow::init):
2435         * QtTestBrowser/launcherwindow.h:
2436         * QtTestBrowser/main.cpp:
2437         (LauncherApplication::handleUserOptions):
2438
2439 2010-09-22  Adam Roben  <aroben@apple.com>
2440
2441         Fix webkit-patch failure-reason now that build.webkit.org has been
2442         updated
2443
2444         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
2445         every time
2446
2447         Reviewed by Eric Seidel.
2448
2449         * Scripts/webkitpy/common/net/buildbot.py:
2450         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
2451         looking for an element that contains text, then returns it.
2452         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
2453         text out of the cells. This way it doesn't matter whether the cells
2454         have <b> children (as for cells in directory rows) or not (as for
2455         cells in file rows)
2456         (BuildBot._parse_twisted_directory_listing): Look for rows that have
2457         the "directory" or "file" class, rather than rows with any class,
2458         since header rows now have a class attribute.
2459
2460         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2461         (BuildBotTest._example_directory_listing): Updated to more closely
2462         match the markup that build.webkit.org is producing now.
2463
2464 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2465
2466         Unreviewed, build fix.
2467
2468         new-run-webkit-tests: fix bug introduced in r68008 where if you
2469         specify --chromium and no --platform, and you're running on
2470         windows, you use the 'chromium-win' port by default instead of the
2471         version-specific port. This breaks the buildbots.
2472
2473         It will be good for this refactoring to settle down so I can
2474         rewrite the logic for default ports and the unit tests to be
2475         clearer (and the testing more comprehensive).
2476
2477         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2478
2479 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2480
2481         Reviewed by Adam Barth.
2482
2483         Modify the Port interface to take only a series of keyword arguments
2484         in the constructor, and modify Port/factory.get() to accomodate that,
2485         and to accept user=XXX as an argument so we can pass
2486         webkitpy.common.system.user.User objects in.
2487
2488         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
2489         to use the common routine in webkitpy.common.system.user.open_url()
2490         to display HTML files.
2491
2492         There was a routine in the Port interface to do the same thing,
2493         but I see no need for a port-specific hook for this, since it is
2494         something that will always be executed by the host environment
2495         and displaying web pages has nothing to do with running layout tests.
2496
2497         Note that new-run-webkit-tests used to use test_shell to display
2498         the page; this is potentially useful so that you can actually click
2499         from a result to the broken page; however, since DumpRenderTree
2500         doesn't support this functionality, it will be going away eventually.
2501
2502         https://bugs.webkit.org/show_bug.cgi?id=46128
2503
2504         * Scripts/webkitpy/layout_tests/port/base.py:
2505         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2506         * Scripts/webkitpy/layout_tests/port/chromium.py:
2507         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2508         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2509         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2510         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2511         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2512         * Scripts/webkitpy/layout_tests/port/factory.py:
2513         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2514         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2515         * Scripts/webkitpy/layout_tests/port/gtk.py:
2516         * Scripts/webkitpy/layout_tests/port/mac.py:
2517         * Scripts/webkitpy/layout_tests/port/qt.py:
2518         * Scripts/webkitpy/layout_tests/port/test.py:
2519         * Scripts/webkitpy/layout_tests/port/webkit.py:
2520         * Scripts/webkitpy/layout_tests/port/win.py:
2521         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2522         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2523         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2524
2525 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2526
2527         Reviewed by Kenneth Rohde Christiansen.
2528
2529         [EFL] Get fresh theme when running EWebLauncher
2530         https://bugs.webkit.org/show_bug.cgi?id=46210
2531
2532         If user tried to run EWebLauncher outside of the build tree, it would
2533         not find the theme and fallback to the installed one. However, since
2534         EWebLauncher is not installed, we always want to take the theme from
2535         the just compiled source code. If user had never installed WebKit's
2536         EFL port it could even receive a segv since no theme would be found.
2537
2538         Now EWebLauncher does not fallback to the installed theme and CMake
2539         gives as DATA_DIR the directory of the theme it has just built.
2540
2541         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
2542         EWebLauncher.
2543         * EWebLauncher/main.c: Use only the theme from build director. Do not
2544         fallback to others as this could hide real bugs.
2545         (quit):
2546         (browserCreate):
2547         (findThemePath):
2548         (main):
2549
2550 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2551
2552         Unreviewed, build fix.
2553
2554         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
2555         it just confuses it.
2556
2557         https://bugs.webkit.org/show_bug.cgi?id=46230
2558
2559         * Scripts/webkitpy/layout_tests/port/webkit.py:
2560
2561 2010-09-21  Lucas Forschler  <lforschler@apple.com>
2562
2563         Reviewed by Stephanie Lewis.
2564
2565         Make a new buildbot for Leopard Debug Test
2566
2567         * BuildSlaveSupport/build.webkit.org-config/config.json:
2568
2569 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2570
2571         Unreviewed, build fix.
2572
2573         Fix breakage of Chromium Mac DRT port caused by r67905.
2574
2575         https://bugs.webkit.org/show_bug.cgi?id=46230
2576
2577         * Scripts/webkitpy/layout_tests/port/webkit.py:
2578
2579 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2580
2581         Unreviewed, build fix.
2582
2583         Add missing import of 'tempfile'.
2584
2585         * Scripts/webkitpy/layout_tests/port/chromium.py:
2586
2587 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
2588
2589         Reviewed by Ojan Vafai.
2590
2591         new-run-webkit-tests: pull the list of tests from the Port, and
2592            make it possible to run with no actual test files in the filesystem.
2593
2594         This set of changes allows us to delete the special
2595         webkitpy/layout_tests/data directory and test the generic code without
2596         touching the filesystem (except to write results). This speeds up
2597         test-webkitpy substantially.
2598
2599         This also cleans up and removes several code paths in the generic
2600         code and fixes some minor bugs, notably in the test_expectations
2601         parsing, which was previously fragile if the tests weren't present.
2602
2603         We also change the way we diff image results to be able to do so
2604         in memory, without relying on files. This slows down chromium
2605         test_shell, which always writes images to files, but should speed
2606         up DRT and ImageDiff-based implementations slightly.
2607
2608         Note that pulling the list of tests to run from the Port will allow
2609         ports to specify what tests to run as an inclusive list; previously
2610         you could only do this as an exclusive list by using a 
2611         test_expectations file or Skipped files; nothing actually uses this
2612         feature yet and it's unclear if it should be used.
2613
2614         Note that there are no functional changes -- apart from now 
2615         always printing out the location of the checksum file when we are
2616         tracing test runs -- and the total number of lines of non-test code
2617         actually drops by two.
2618
2619         There is some more cleanup that can be done in the Port/Driver 
2620         interface and in some handling of filenames, but I'll save that
2621         for another change.
2622
2623         https://bugs.webkit.org/show_bug.cgi?id=45801
2624
2625         * Scripts/webkitpy/layout_tests/data/*: Removed.
2626             - no longer need special mock layout_tests_directory in the
2627               repository.
2628         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2629             - add code to display missing text files, checksums when tracing
2630             - update to not look at the filesystem directly.
2631         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2632             - add more unit tests
2633         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2634             - remove tests_are_present flag
2635             - update with changes in Port interface - no longer access
2636               the filesystem directly, although we still use os.path for
2637               filename manipulation.
2638         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2639             - add more unit tests
2640         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
2641             - renamed to port/test_files.py
2642         * Scripts/webkitpy/layout_tests/port/base.py:
2643             - change diff_image() to expect actual image data, not filenames
2644             - add expected_checksum(), expected_image(), expected_text() to
2645               return the content of the files so that we don't need a filesystem
2646             - add path_exists(), path_isdir() for filesystem-like access.
2647             - add test_dirs() to keep clobber-test-results from needing to
2648               actually look at a real layout tests dir
2649             - add tests() to return the list of tests to run on the port
2650               (calls port/test_files to do the work).
2651             - add update_baseline() to be able to save new baselines
2652             - add uri_to_test_name() from port/dryrun.py so we can easily check
2653               filename_to_uri()
2654         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2655             - add more unit tests
2656         * Scripts/webkitpy/layout_tests/port/chromium.py:
2657             - change diff_image() to accept image content, not filenames.
2658               This will be slower for test_shell/image_diff, but faster
2659               for DRT/ImageDiff.
2660         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2661             - add more unit tests
2662         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2663             - simplify greatly
2664         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2665             - add more unit tests
2666         * Scripts/webkitpy/layout_tests/port/test.py:
2667             - massive rewrite to use in-script list of tests and expectations
2668         * Scripts/webkitpy/layout_tests/port/test_files.py:
2669             - rename from layout_package/test_files.
2670         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2671             - add unit tests
2672         * Scripts/webkitpy/layout_tests/port/webkit.py:
2673             - update diff_image() to take image contents, not files. Should
2674               make things slightly faster.
2675         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2676             - update with changes to diff_image()
2677         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2678             - update with changes to diff_image()
2679         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2680             - remove tests_are_present from test_expectations
2681             - pull the list of tests from port.tests() instead
2682               of calling test_files.py directly.
2683         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2684             - update unit tests
2685         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2686             - update with changes to 
2687         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2688             - update with change in Port interface
2689         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2690             - update with change in Port interface
2691         * Scripts/webkitpy/style/checkers/test_expectations.py:
2692             - remove the tests_are_present flag
2693
2694 2010-09-21  Anders Carlsson  <andersca@apple.com>
2695
2696         Disable logging.
2697
2698         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2699
2700 2010-09-21  Tony Chang  <tony@chromium.org>
2701
2702         Reviewed by Kent Tamura.
2703
2704         add a script for running webkit_unit_tests
2705         https://bugs.webkit.org/show_bug.cgi?id=46014
2706
2707         * Scripts/run-chromium-webkit-unit-tests: Added.
2708
2709 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
2710
2711         Reviewed by Martin Robinson.
2712
2713         Fix linking problems on Windows.
2714         https://bugs.webkit.org/show_bug.cgi?id=45844
2715
2716         * GNUmakefile.am: link the executables with winmm.dll
2717
2718 2010-09-21  Adam Barth  <abarth@webkit.org>
2719
2720         Reviewed by Eric Seidel.
2721
2722         feeder-queue svn updates more often than needed
2723         https://bugs.webkit.org/show_bug.cgi?id=46171
2724
2725         We don't need to poll SVN every time we feed the feeders.  Rather, we
2726         can count on the wrapper shell script to auto-update the queue.
2727
2728         * Scripts/webkitpy/tool/commands/queues.py:
2729         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2730
2731 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2732
2733         Reviewed by Andreas Kling.
2734
2735         [Qt] Add robot loader timeout and extra time options.
2736         https://bugs.webkit.org/show_bug.cgi?id=46172
2737
2738         [-robot-timeout <s>]: Load the next page after s seconds if the current
2739         page didn't finish loading.
2740         [-robot-extra-time <s>]: Wait s seconds after the current page finished
2741         loading before loading the next one. This should allow some time for the
2742         page's JavaScript to execute.
2743
2744         * QtTestBrowser/launcherwindow.cpp:
2745         (LauncherWindow::applyPrefs):
2746         * QtTestBrowser/main.cpp:
2747         (LauncherApplication::robotTimeout):
2748         (LauncherApplication::robotExtraTime):
2749         (LauncherApplication::LauncherApplication):
2750         (LauncherApplication::handleUserOptions):
2751         (main):
2752         * QtTestBrowser/urlloader.cpp:
2753         (UrlLoader::UrlLoader):
2754         (UrlLoader::loadNext):
2755         (UrlLoader::loadUrlList):
2756         * QtTestBrowser/urlloader.h:
2757
2758 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
2759
2760         Unreviewed.
2761
2762         Adding myself to the committers list.
2763
2764         * Scripts/webkitpy/common/config/committers.py:
2765
2766 2010-09-20  Philippe Normand  <pnormand@igalia.com>
2767
2768         Reviewed by Eric Carlson.
2769
2770         [GTK] enhanced context menu for media elements
2771         https://bugs.webkit.org/show_bug.cgi?id=45021
2772
2773         EventSender::contextClick() now returns an array of js
2774         objects. Each object has a title property and a click() method.
2775
2776         * DumpRenderTree/gtk/EventSender.cpp:
2777         (getMenuItemTitleCallback):
2778         (setMenuItemTitleCallback):
2779         (menuItemClickCallback):
2780         (getMenuItemClass):
2781         (contextClickCallback):
2782
2783 2010-09-20  Hayato Ito  <hayato@chromium.org>
2784
2785         Unreviewed.
2786         Adding myself to the committers list.
2787
2788         * Scripts/webkitpy/common/config/committers.py:
2789
2790 2010-09-20  Adam Barth  <abarth@webkit.org>
2791
2792         Reviewed by Eric Seidel.
2793
2794         The tool member variable should be called _tool
2795         https://bugs.webkit.org/show_bug.cgi?id=46160
2796
2797         Created by find-and-replace.
2798
2799         * Scripts/webkitpy/tool/commands/download.py:
2800         * Scripts/webkitpy/tool/commands/openbugs.py:
2801         * Scripts/webkitpy/tool/commands/queries.py:
2802         * Scripts/webkitpy/tool/commands/queues.py:
2803         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2804         * Scripts/webkitpy/tool/commands/rebaseline.py:
2805         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2806         * Scripts/webkitpy/tool/commands/upload.py:
2807         * Scripts/webkitpy/tool/multicommandtool.py:
2808
2809 2010-09-20  Adam Barth  <abarth@webkit.org>
2810
2811         I ran the tests before landing but ignored the fact that they failed.  :(
2812
2813         * Scripts/webkitpy/tool/commands/queues.py:
2814
2815 2010-09-20  Adam Barth  <abarth@webkit.org>
2816
2817         Reviewed by Eric Seidel.
2818
2819         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
2820         https://bugs.webkit.org/show_bug.cgi?id=46141
2821
2822         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
2823         list of work items on the status server.  The individual commit-cluster
2824         nodes then grab the patches from the server and process them.
2825
2826         * Scripts/webkitpy/tool/bot/feeders.py: Added.
2827         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
2828         * Scripts/webkitpy/tool/commands/queues.py:
2829         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2830         * Scripts/webkitpy/tool/commands/queuestest.py:
2831
2832 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
2833
2834         Reviewed by Darin Adler.
2835
2836         build-webkit: Add support for CMake build system
2837         https://bugs.webkit.org/show_bug.cgi?id=44979
2838
2839         * Scripts/build-webkit: Add "--efl" command-line option to build the
2840         EFL port of WebKit.
2841         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
2842         buildEflCMakeProject() subroutines.
2843
2844 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
2845
2846         Reviewed by Ojan Vafai.
2847
2848         new-run-webkit-tests: refactor command line args getting passed to DRT
2849
2850         This change cleans up some argument parsing between functions to get
2851         rid of some overlapping data structures. There should be no functional
2852         changes in this patch; it is pure refactoring in preparation for
2853         landing the Chrome GPU port and adding a generic way to pass
2854         args to DRT/TestShell.
2855
2856         https://bugs.webkit.org/show_bug.cgi?id=46135
2857
2858         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2859           - pass the options argument explicitly to the threads and drivers,
2860             also consolidate the passing of options to the driver.
2861           - pass options directly to process_output() to remove a couple
2862             parameters (minor cleanup).
2863         * Scripts/webkitpy/layout_tests/port/base.py:
2864           - pass the options argument to Port.create_driver().
2865         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2866           - update Port.create_driver() test
2867         * Scripts/webkitpy/layout_tests/port/chromium.py:
2868           - pass the options argument to Port.create_driver(), and clean up
2869             building of the cmd line for DRT.
2870         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2871           - pass the options argument to Port.create_driver()
2872         * Scripts/webkitpy/layout_tests/port/test.py:
2873           - pass the options argument to Port.create_driver()
2874         * Scripts/webkitpy/layout_tests/port/webkit.py:
2875           - pass the options argument to Port.create_driver(), and clean up
2876             building of the cmd line for DRT.
2877         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2878           - consolidate args in _get_dump_render_tree_args and rename to
2879             _get_test_args(); move all of the command-line args to the
2880             Port implementations.
2881
2882 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
2883
2884         Revert change which was accidentally committed along with some expectation changes.
2885
2886         * Scripts/webkitpy/layout_tests/port/base.py:
2887
2888 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
2889
2890         Reviewed by Adam Barth.
2891
2892         Add explicit --force-patch flag to webkitpy tools
2893         https://bugs.webkit.org/show_bug.cgi?id=46103
2894         
2895         It wasn't obvious until I read the applypatch.py source code that
2896         --non-interfactive implies passing --force to patch. Add --force-patch
2897         as an alias to the flag, so that this behavior is more discoverable.
2898
2899         * Scripts/webkitpy/tool/steps/applypatch.py:
2900         * Scripts/webkitpy/tool/steps/options.py:
2901
2902 2010-09-20  Eric Seidel  <eric@webkit.org>
2903
2904         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
2905
2906         commit-queue can't land patches
2907         https://bugs.webkit.org/show_bug.cgi?id=46138
2908
2909         Add a line of code I forgot in my last commit.
2910
2911         * Scripts/webkitpy/common/net/bugzilla.py:
2912         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2913
2914 2010-09-20  Adam Barth  <abarth@webkit.org>
2915
2916         Reviewed by Eric Seidel.
2917
2918         The commit-cluster bots still race to lock patch_ids
2919         https://bugs.webkit.org/show_bug.cgi?id=46130
2920
2921         It turns out we need to use a transaction object to make the
2922         read/modify/write lock operation atomic.  From reading the AppEngine
2923         documentation, I think this patch should do what we want.  It's hard to
2924         test locally because the test instance isn't distributed in the same
2925         way the production instance is.
2926
2927         * QueueStatusServer/handlers/nextpatch.py:
2928         * QueueStatusServer/model/activeworkitems.py: Added.
2929
2930 2010-09-20  Andy Estes  <aestes@apple.com>
2931
2932         Reviewed by Adam Barth.
2933
2934         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
2935         https://bugs.webkit.org/show_bug.cgi?id=40961
2936
2937         Implement WebKitUsePreHTML5ParserQuirks preference.
2938
2939         * DumpRenderTree/mac/DumpRenderTree.mm:
2940         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
2941         to false after a test finishes.
2942
2943 2010-09-20  Adam Roben  <aroben@apple.com>
2944
2945         Windows build fix
2946
2947         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
2948         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
2949         we'll pick up the most recent versions of the headers.
2950
2951 2010-09-20  Eric Seidel  <eric@webkit.org>
2952
2953         Reviewed by Adam Barth.
2954
2955         commit-queue should check commit-queue+ again just before committing
2956         https://bugs.webkit.org/show_bug.cgi?id=32679
2957
2958         Added a _revalidate_patch check, right before landing.
2959
2960         Since _revalidate_patch passes the patch_id from the work item
2961         back to bugzilla, I had to fix all of the previous queue tests to
2962         use valid attachment ids (that's the majority of this change).
2963
2964         In order to validate that the bug was still open, I had to teach
2965         bugzilla.Bug about open/closed states.
2966
2967         * Scripts/webkitpy/common/net/bugzilla.py:
2968         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2969         * Scripts/webkitpy/tool/commands/queues.py:
2970         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2971         * Scripts/webkitpy/tool/commands/queuestest.py:
2972         * Scripts/webkitpy/tool/mocktool.py:
2973
2974 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
2975
2976         Unreviewed.
2977
2978         Adding myself as a comitter.
2979
2980         * Scripts/webkitpy/common/config/committers.py:
2981
2982 2010-09-20  Adam Barth  <abarth@webkit.org>
2983
2984         Reviewed by Eric Seidel.
2985
2986         Two instances of commit-queue try to process the same patch
2987         https://bugs.webkit.org/show_bug.cgi?id=46113
2988
2989         This patch makes next-patch atomic so that the server won't vend the
2990         same patch twice in the same hour.
2991
2992         * QueueStatusServer/handlers/nextpatch.py:
2993
2994 2010-09-20  Adam Roben  <aroben@apple.com>
2995
2996         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
2997
2998         We were previously trying to use a CFRunLoopTimer, but since Windows
2999         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
3000         Windows-style timer on Windows.
3001
3002         I also replaced all uses of "watchdog" with "watchdog timer".
3003
3004         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
3005         watchdog timer doesn't work on Windows
3006
3007         Reviewed by Anders Carlsson.
3008
3009         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3010         (WTR::InjectedBundlePage::dump): Updated for rename.
3011
3012         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
3013         platform-specific functions.
3014         (WTR::LayoutTestController::LayoutTestController): Added call to
3015         platformInitialize.
3016         (WTR::LayoutTestController::waitUntilDone): Changed to call
3017         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
3018         right in this function.
3019         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
3020         rename.
3021
3022         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
3023         members needed to support the watchdog timer abstraction. Replaced
3024         some "watchdog"s with "watchdog timer".
3025
3026         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
3027         Added.
3028         (WTR::LayoutTestController::platformInitialize): Does nothing on this
3029         platform.
3030         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
3031         from LayoutTestController.cpp and changed to use an early return.
3032         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
3033         LayoutTestController.cpp.
3034         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3035         Moved code here from LayoutTestController::waitUntilDone and changed
3036         to use an early return.
3037
3038         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
3039         Added.
3040         (WTR::LayoutTestController::platformInitialize): Initialize our
3041         watchdog timer.
3042         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
3043         Kills and clears the watchdog timer.
3044         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
3045         LayoutTestController member function of the same name.
3046         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3047         Added. Sets up the timer if it isn't already set.
3048
3049         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
3050         LayoutTestControllerMac.mm.
3051
3052         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
3053         LayoutTestControllerWin.cpp.
3054
3055 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
3056
3057         Reviewed by Daniel Bates.
3058
3059         [GTK] fast/forms/listbox-selection.html fails
3060         https://bugs.webkit.org/show_bug.cgi?id=45942
3061
3062         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
3063         strings in keyDownCallback.
3064
3065         * DumpRenderTree/gtk/EventSender.cpp:
3066         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 
3067         modifier parsing logic.
3068
3069 2010-09-19  Sam Weinig  <sam@webkit.org>
3070
3071         Reviewed by Anders Carlsson.
3072
3073         WebKit2 decidePolicyForNavigationAction should include mouse button information
3074         <rdar://problem/8413165>
3075         https://bugs.webkit.org/show_bug.cgi?id=46060
3076
3077         * MiniBrowser/mac/BrowserWindowController.m:
3078         (decidePolicyForNavigationAction):
3079         (decidePolicyForNewWindowAction):
3080
3081 2010-09-19  Daniel Bates  <dbates@rim.com>
3082
3083         Reviewed by Martin Robinson.
3084
3085         Add unit tests for diffs that delete or modify a change log entry
3086         or describe changes that are far apart
3087         https://bugs.webkit.org/show_bug.cgi?id=46046
3088
3089         Add additional unit tests to test change log diffs that contain
3090         deletions or changes that are far apart from each other in the
3091         ChangeLog file.
3092
3093         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3094           - Added the following unit tests:
3095           "fixChangeLogPatch: [no change] In-place change."
3096           "fixChangeLogPatch: [no change] Remove first entry."
3097           "fixChangeLogPatch: [no change] Remove entry in the middle."
3098           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
3099
3100 2010-09-19  Sam Weinig  <sam@webkit.org>
3101
3102         Reviewed by Anders Carlsson.
3103
3104         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
3105         https://bugs.webkit.org/show_bug.cgi?id=46054
3106
3107         The new one acts like WKBundleNodeHandleRef and allows for getting a
3108         wrapper in a specific world for the handle.
3109
3110         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3111         (WTR::propertyValue):
3112         (WTR::propertyValueDouble):
3113         (WTR::propertyValueInt):
3114         (WTR::numericWindowPropertyValue):
3115         (WTR::toStr):
3116         (WTR::InjectedBundlePage::shouldBeginEditing):
3117         (WTR::InjectedBundlePage::shouldEndEditing):
3118         (WTR::InjectedBundlePage::shouldInsertNode):
3119         (WTR::InjectedBundlePage::shouldInsertText):
3120         (WTR::InjectedBundlePage::shouldDeleteRange):
3121         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3122         (WTR::InjectedBundlePage::shouldApplyStyle):
3123         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3124
3125 2010-09-19  Kent Tamura  <tkent@chromium.org>
3126
3127         Unreviewed. Fix WebGL test regressions by r67809.
3128
3129         * DumpRenderTree/chromium/WebPreferences.cpp:
3130         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
3131
3132 2010-09-19  Kent Tamura  <tkent@chromium.org>
3133
3134         Reviewed by Adam Barth.
3135
3136         [DRT/Chromium] Fix a WebSettings handling bug
3137         https://bugs.webkit.org/show_bug.cgi?id=45945
3138
3139         Before this change, Chromium DRT reset WebSettings for every new
3140         window. It was wrong.
3141         If new window is not the first one, we have to apply the same
3142         settings as the first window.  So, we introduce WebPreference to
3143         store the current settings, and apply it to new windows. It's same
3144         as test_shell's behavior.
3145
3146         * DumpRenderTree/DumpRenderTree.gypi:
3147         * DumpRenderTree/chromium/LayoutTestController.cpp:
3148           Use WebPreferences instead of WebSettings.
3149         (LayoutTestController::setUserStyleSheetEnabled):
3150         (LayoutTestController::setUserStyleSheetLocation):
3151         (LayoutTestController::setAuthorAndUserStylesEnabled):
3152         (LayoutTestController::setPopupBlockingEnabled):
3153         (LayoutTestController::disableImageLoading):
3154         (LayoutTestController::setJavaScriptCanAccessClipboard):
3155         (LayoutTestController::setXSSAuditorEnabled):
3156         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
3157         (LayoutTestController::setAllowFileAccessFromFileURLs):
3158         (LayoutTestController::overridePreference):
3159         (LayoutTestController::setEditingBehavior):
3160         * DumpRenderTree/chromium/TestShell.cpp:
3161         (TestShell::resetWebSettings): Use WebPreferences.
3162         (TestShell::runFileTest): ditto.
3163         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
3164         * DumpRenderTree/chromium/TestShell.h:
3165         (TestShell::preferences):
3166         (TestShell::applyPreferences):
3167         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
3168         * DumpRenderTree/chromium/WebPreferences.h: Added.
3169
3170 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
3171
3172         Reviewed by David Levin.
3173
3174         update-webkit --chromium spitting out a spurious error
3175         https://bugs.webkit.org/show_bug.cgi?id=45868
3176
3177         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
3178
3179 2010-09-18  Sam Weinig  <sam@webkit.org>
3180
3181         Reviewed by Dan Bernstein.
3182
3183         Improve/unify the PageLoadClient interfaces
3184         https://bugs.webkit.org/show_bug.cgi?id=46043
3185
3186         * MiniBrowser/mac/BrowserWindowController.m:
3187         (didStartProvisionalLoadForFrame):
3188         (didReceiveServerRedirectForProvisionalLoadForFrame):
3189         (didFailProvisionalLoadWithErrorForFrame):
3190         (didCommitLoadForFrame):
3191         (didFinishDocumentLoadForFrame):
3192         (didFinishLoadForFrame):
3193         (didFailLoadWithErrorForFrame):
3194         (didReceiveTitleForFrame):
3195         (didFirstLayoutForFrame):
3196         (didFirstVisuallyNonEmptyLayoutForFrame):
3197         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3198         (WTR::InjectedBundlePage::InjectedBundlePage):
3199         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3200         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3201         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
3202         (WTR::InjectedBundlePage::didCommitLoadForFrame):
3203         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3204         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3205         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3206         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3207         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3208         * WebKitTestRunner/TestController.cpp:
3209         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3210         (WTR::TestController::didFinishLoadForFrame):
3211         * WebKitTestRunner/TestController.h:
3212
3213 2010-09-17  Eric Seidel  <eric@webkit.org>
3214
3215         Unreviewed.  Adding a shell script I use to run the
3216         commit-queue. Now that multiple machines run the cq,
3217         it makes sense to share the script between them.
3218
3219         * EWSTools/start-commit-queue.sh: Added.
3220
3221 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
3222
3223         Reviewed by Jon Honeycutt.
3224
3225         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
3226         slightly harder to read, so this reverts the previous background colors for various
3227         states, making it easier to read.
3228
3229         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3230         (.success):
3231         (.failure):
3232         (.warnings):
3233         (.exception):
3234         (.start,.running,td.building):
3235         (.offline,td.offline):
3236
3237 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3238
3239         Unreviewed, rolling out r67692.
3240         http://trac.webkit.org/changeset/67692
3241         https://bugs.webkit.org/show_bug.cgi?id=46011
3242
3243         broke layout test dashboard (Requested by johnny_g on
3244         #webkit).
3245
3246         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3247         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3248         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3249
3250 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
3251
3252         Reviewed by Oliver Hunt.
3253
3254         Style bot complains about cairo forward declaration naming
3255         https://bugs.webkit.org/show_bug.cgi?id=45867
3256
3257         Exclude Cairo forward declarations from indentifiers with underscores checks.
3258
3259         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
3260         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3261
3262 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
3263
3264         Reviewed by Ojan Vafai.
3265
3266         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
3267         https://bugs.webkit.org/show_bug.cgi?id=45408
3268
3269         This change also tries to remove duplicated upload_results_json methods
3270         in run_webkit_tests.py and json_results_generator.py.
3271
3272         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3273         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3274         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3275
3276 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
3277
3278         Reviewed by Andreas Kling.
3279
3280         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
3281
3282         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
3283         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
3284         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
3285         all page specific stuff to the UI.
3286
3287         * QtTestBrowser/launcherwindow.cpp:
3288         (LauncherWindow::initializeView):
3289         * QtTestBrowser/mainwindow.cpp:
3290         (MainWindow::MainWindow):
3291         (MainWindow::buildUI):
3292         (MainWindow::setPage):
3293         * QtTestBrowser/mainwindow.h:
3294
3295 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3296
3297         Reviewed by Andreas Kling.
3298
3299         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
3300
3301         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
3302         object will move to the qgraphicsscene instead of the qgraphicsview.
3303
3304         * QtTestBrowser/webview.cpp:
3305         (WebViewGraphicsBased::setPage):
3306         (WebViewGraphicsBased::setResizesToContents):
3307         (WebViewGraphicsBased::resizeEvent):
3308         (WebViewGraphicsBased::animatedFlip):
3309         * QtTestBrowser/webview.h:
3310         (WebViewGraphicsBased::setItemCacheMode):
3311         (WebViewGraphicsBased::itemCacheMode):
3312
3313 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3314
3315         Reviewed by Andreas Kling.
3316
3317         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
3318
3319         We usually separate methods whose body are larger than a few lines from the class definition.
3320
3321         * QtTestBrowser/webview.h:
3322         (WebViewGraphicsBased::yRotation):
3323         (WebViewGraphicsBased::setYRotation):
3324
3325 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3326
3327         Reviewed by Andreas Kling.
3328
3329         Make initializeView method of LauncherWindow private.
3330
3331         No one else needs to be able to call it but LauncherWindow.
3332         Also moving the declation of isGraphicsBased method down in the same file, in order
3333         to better group related methods.
3334
3335         * QtTestBrowser/launcherwindow.h:
3336
3337 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3338
3339         Reviewed by Andreas Kling.
3340
3341         Make the getter 'page' method of MainWindow const.
3342
3343         * QtTestBrowser/mainwindow.cpp:
3344         (MainWindow::page):
3345         * QtTestBrowser/mainwindow.h:
3346
3347 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3348
3349         Reviewed by Andreas Kling.
3350
3351         Remove useless parameter from MainWindow class' constructor.
3352
3353         The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
3354         not referred in the constructor body and does not make much sense.
3355
3356         * QtTestBrowser/mainwindow.cpp:
3357         (MainWindow::MainWindow):
3358         * QtTestBrowser/mainwindow.h:
3359
3360 2010-09-15  Tony Chang  <tony@chromium.org>
3361
3362         Reviewed by Kent Tamura.
3363
3364         [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
3365         https://bugs.webkit.org/show_bug.cgi?id=42151
3366
3367         * DumpRenderTree/chromium/LayoutTestController.cpp:
3368         (LayoutTestController::LayoutTestController):
3369         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
3370         (WorkItemLoadHTMLString::run):
3371         (LayoutTestController::queueLoadHTMLString):
3372         (LayoutTestController::reset):
3373         (LayoutTestController::setDeferMainResourceDataLoad):
3374         * DumpRenderTree/chromium/LayoutTestController.h:
3375         (LayoutTestController::deferMainResourceDataLoad):
3376         * DumpRenderTree/chromium/WebViewHost.cpp:
3377         (WebViewHost::didCreateDataSource):
3378
3379 2010-09-16  Adrienne Walker  <enne@google.com>
3380
3381         Reviewed by Kenneth Russell.
3382
3383         Add script to synchronize WebKit and Khronos WebGL tests
3384         https://bugs.webkit.org/show_bug.cgi?id=42336
3385
3386         * Scripts/update-webgl-conformance-tests: Added.
3387         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
3388         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
3389
3390 2010-09-16  Sam Weinig  <sam@webkit.org>
3391
3392         Reviewed by Anders Carlsson.
3393
3394         Add support for sending synchronous messages from the InjectedBundle to the WKContext
3395         <rdar://problem/8365320>
3396         https://bugs.webkit.org/show_bug.cgi?id=44785
3397
3398         * MiniBrowser/mac/AppDelegate.m:
3399         (didReceiveSynchronousMessageFromInjectedBundle):
3400         (-[BrowserAppDelegate init]):
3401         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3402         (didCreatePage):
3403         * WebKitTestRunner/TestController.cpp:
3404         (WTR::TestController::initialize):
3405
3406 2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>
3407
3408         Reviewed by Andreas Kling.
3409
3410         [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
3411         https://bugs.webkit.org/show_bug.cgi?id=45885
3412
3413         Avoid creation of an additional window for screenshot to prevent overlapping with original window.
3414
3415         * QtTestBrowser/launcherwindow.cpp:
3416         (LauncherWindow::screenshot):
3417
3418 2010-09-16  Anders Carlsson  <andersca@apple.com>
3419
3420         Fix clang++ build.
3421
3422         * MiniBrowser/mac/BrowserWindowController.m:
3423         (-[BrowserWindowController zoomIn:]):
3424         (-[BrowserWindowController zoomOut:]):
3425         (-[BrowserWindowController resetZoom:]):
3426         Remove trailing semicolons.
3427
3428 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
3429
3430         Unreviewed, rolling out r67628.
3431         http://trac.webkit.org/changeset/67628
3432         https://bugs.webkit.org/show_bug.cgi?id=45904
3433
3434         broke the build (Requested by eric_carlson on #webkit).
3435
3436         * DumpRenderTree/gtk/EventSender.cpp:
3437         (contextClickCallback):
3438
3439 2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>
3440
3441         Unreviewed.
3442
3443         Adding myself as a comitter.
3444
3445         * Scripts/webkitpy/common/config/committers.py:
3446
3447 2010-09-15  Philippe Normand  <pnormand@igalia.com>
3448
3449         Reviewed by Eric Carlson.
3450
3451         [GTK] enhanced context menu for media elements
3452         https://bugs.webkit.org/show_bug.cgi?id=45021
3453
3454         EventSender::contextClick() now returns an array of js
3455         objects. Each object has a title property and a click() method.
3456
3457         * DumpRenderTree/gtk/EventSender.cpp:
3458         (getMenuItemTitleCallback):
3459         (setMenuItemTitleCallback):
3460         (menuItemClickCallback):
3461         (getMenuItemClass):
3462         (contextClickCallback):
3463
3464 2010-09-14  Philippe Normand  <pnormand@igalia.com>
3465
3466         Reviewed by Eric Carlson and Martin Robinson.
3467
3468         [GTK] eventSender.contextClick() should return the contents of the context menu
3469         https://bugs.webkit.org/show_bug.cgi?id=39102
3470
3471         Make the eventSender use the new private WebKitGtk+ API to
3472         retrieve the context-menu item titles and store them in an array.
3473
3474         * DumpRenderTree/gtk/EventSender.cpp:
3475         (contextClickCallback):
3476
3477 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
3478
3479         Reviewed by Jian Li.
3480
3481         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
3482         https://bugs.webkit.org/show_bug.cgi?id=45798
3483
3484         * Scripts/build-webkit:
3485
3486 2010-09-16  Robert Hogan  <robert@webkit.org>
3487
3488         Reviewed by Antonio Gomes.
3489
3490         [Qt] Support globalhistory tests
3491         https://bugs.webkit.org/show_bug.cgi?id=45774
3492
3493         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3494         (WebCore::isGlobalHistoryTest):
3495         (WebCore::DumpRenderTree::open):
3496         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3497         (LayoutTestController::reset):
3498         (LayoutTestController::dumpHistoryCallbacks):
3499         (LayoutTestController::removeAllVisitedLinks):
3500         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3501
3502 2010-09-10  Tony Chang  <tony@chromium.org>
3503
3504         Reviewed by Eric Seidel.
3505
3506         deduplicate-tests should be runnable from any WebKit directory
3507         https://bugs.webkit.org/show_bug.cgi?id=44709
3508
3509         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3510         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3511
3512 2010-09-15  Tony Chang  <tony@chromium.org>
3513
3514         Reviewed by Kent Tamura.
3515
3516         [chromium] sort testing methods in DRT
3517         https://bugs.webkit.org/show_bug.cgi?id=45850
3518
3519         * DumpRenderTree/chromium/EventSender.cpp:
3520         (EventSender::EventSender):
3521         * DumpRenderTree/chromium/LayoutTestController.cpp:
3522         (LayoutTestController::LayoutTestController):
3523         * DumpRenderTree/chromium/TextInputController.cpp:
3524         (TextInputController::TextInputController):
3525
3526 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
3527
3528         Reviewed by Adam Barth.
3529
3530         CQ status shows items out of order
3531         https://bugs.webkit.org/show_bug.cgi?id=45846
3532         
3533         Only group consecutive status items with the same patch ID into the same
3534         group, so that overall item ordering is preserved.
3535         
3536         Also don't indent status items that only have a single item in their
3537         group.
3538
3539         * QueueStatusServer/handlers/queuestatus.py:
3540         * QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
3541         * QueueStatusServer/templates/queuestatus.html:
3542
3543 2010-09-15  Eric Seidel  <eric@webkit.org>
3544
3545         Reviewed by Adam Barth.
3546
3547         Add queue start/stop messages
3548         https://bugs.webkit.org/show_bug.cgi?id=45853
3549
3550         I ended up needing to clean up a bunch of our unit testing
3551         in order to test this new code path nicely.
3552
3553         There are also a few PEP8 changes needed to pass check-webkit-style.
3554
3555         * Scripts/webkitpy/tool/bot/queueengine.py:
3556         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3557         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3558         * Scripts/webkitpy/tool/commands/queues.py:
3559         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3560         * Scripts/webkitpy/tool/commands/queuestest.py:
3561         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3562
3563 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
3564
3565         https://bugs.webkit.org/show_bug.cgi?id=45849
3566         WKURLCreateWithCFURL crashes with null url
3567         
3568         Fix MiniBrowser crash when the url is not parseable.
3569
3570         * MiniBrowser/mac/BrowserWindowController.m:
3571         (-[BrowserWindowController fetch:]):
3572
3573 2010-09-15  Patrick Gansterer  <paroga@paroga.com>
3574
3575         Unreviewed.
3576
3577         Adding myself to the committers list.
3578
3579         * Scripts/webkitpy/common/config/committers.py:
3580
3581 2010-09-14  Eric Seidel  <eric@webkit.org>
3582
3583         Reviewed by Adam Barth.
3584
3585         Make it possible to run more than one commit-queue instance
3586         https://bugs.webkit.org/show_bug.cgi?id=45786
3587
3588         Mostly we need to make sure the two (or more) instances get
3589         different patches to work on.  To do this, I re-worked
3590         the code responsible for getting the next work item to