WebKitTools/ChangeLog

   1 2008-01-16  Adam Roben  <aroben@apple.com>
   2
   3         Windows build fix after r29488
   4
   5         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
   6         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
   7         expects to find the plugin.
   8
   9 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
  10
  11         Reviewed by Sam Weinig.
  12
  13         Fixed the waitUntilDone watchdog timer -- the old code never added the
  14         timer to the run loop, so it didn't do anything.
  15
  16         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  17         (LayoutTestController::setWaitToDump):
  18         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  19         (LayoutTestController::setWaitToDump):
  20
  21 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
  22
  23         Use shared vsprops for most vcproj properties.
  24
  25         Reviewed by Darin.
  26
  27         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
  28         * DumpRenderTree/win/DumpRenderTree.vcproj:
  29         * DumpRenderTree/win/ImageDiff.vcproj:
  30         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
  31         * FindSafari/FindSafari.vcproj:
  32
  33 2008-01-14  Stephanie  <slewis@apple.com>
  34
  35        Reviewed by NOBODY.
  36
  37        revert accidental character.
  38
  39        * Scripts/run-webkit-tests:
  40
  41 2008-01-14  Stephanie  <slewis@apple.com>
  42
  43         RS=Oliver
  44
  45         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
  46
  47         * Scripts/run-webkit-tests:
  48
  49 2008-01-14  Darin Adler  <darin@apple.com>
  50
  51         * Scripts/do-webcore-rename: Queue up another rename.
  52
  53 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
  54
  55         Reviewed by Darin.
  56
  57         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
  58         the tests were ran.
  59         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
  60
  61         * Scripts/run-webkit-tests:
  62
  63 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
  64
  65         Reviewed by Darin.
  66
  67         * Randomize tests array to spot test cases where the results depends on the order
  68         the tests are ran.
  69         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
  70
  71         * Scripts/run-webkit-tests:
  72
  73 2008-01-14  Darin Adler  <darin@apple.com>
  74
  75         * Scripts/run-webkit-tests: More ignore list tweaking.
  76
  77 2008-01-14  Darin Adler  <darin@apple.com>
  78
  79         * Scripts/run-webkit-tests: Add another leak to the ignore list.
  80
  81 2008-01-14  Dan Bernstein  <mitz@apple.com>
  82
  83         Reviewed by Adam Roben.
  84
  85         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
  86           build bots
  87
  88         * DumpRenderTree/win/DumpRenderTree.cpp:
  89         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
  90
  91 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
  92
  93         Share common files across projects.
  94
  95         Unify vsprops files
  96         Debug:          common.vsprops, debug.vsprops
  97         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
  98         Release:        common.vsprops, release.vsprops
  99
 100         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
 101         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
 102
 103         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
 104
 105         Reviewed by Adam Roben.
 106
 107         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 108         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
 109         * Drosera/win/Drosera.vcproj/VERSION: Removed.
 110         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
 111         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
 112         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
 113         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
 114         * DumpRenderTree/win/DumpRenderTree.vcproj:
 115         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
 116         * DumpRenderTree/win/debug.vsprops: Removed.
 117         * DumpRenderTree/win/debug_internal.vsprops: Removed.
 118         * DumpRenderTree/win/release.vsprops: Removed.
 119
 120 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
 121
 122         Reviewed by Maciej.
 123
 124         - http://bugs.webkit.org/show_bug.cgi?id=16314
 125           Script to launch Drosera
 126
 127         * Scripts/gdb-drosera: Added.
 128         * Scripts/run-drosera: Added.
 129         * Scripts/run-drosera-nightly.cmd: Added.
 130         * Scripts/webkitdirs.pm: Added runDrosera function.
 131
 132 2008-01-13  Dan Bernstein  <mitz@apple.com>
 133
 134         - fix breakage due to last-minute change
 135
 136         * DumpRenderTree/win/DumpRenderTree.cpp:
 137         (runTest): Declare the loop variable.
 138
 139 2008-01-13  Dan Bernstein  <mitz@apple.com>
 140
 141         Reviewed by Adam Roben.
 142
 143         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
 144
 145         * DumpRenderTree/win/DumpRenderTree.cpp:
 146         (DumpRenderTreeWndProc):
 147         (initialize):
 148         (dumpBackForwardList):
 149         (dumpBackForwardListForAllWindows):
 150         (dump):
 151         (resetWebViewToConsistentStateBeforeTesting): Factored out of
 152         runTest().
 153         (runTest):
 154         (allWindows): Added. Returns a vector of all open windows.
 155         (windowToWebViewMap): Added. Returns a map from open windows to their
 156         WebViews.
 157         (createWebViewAndOffscreenWindow): Factored out of main() to be
 158         reusable for creating extra windows.
 159         (main):
 160         * DumpRenderTree/win/DumpRenderTreeWin.h:
 161         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 162         (LayoutTestController::windowCount): Implemented.
 163         * DumpRenderTree/win/UIDelegate.cpp:
 164         (UIDelegate::createWebViewWithRequest): Implemented.
 165         (UIDelegate::webViewClose): Implemented.
 166         * DumpRenderTree/win/UIDelegate.h:
 167
 168 2008-01-12  Alp Toker  <alp@atoker.com>
 169
 170         Reviewed by Mark Rowe.
 171
 172         Hide non-public symbols in GTK+/autotools release builds.
 173
 174         * GNUmakefile.am:
 175
 176 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
 177
 178         Reviewed by Ap.
 179
 180         * Make launching of the WebKit httpd work on GNU/Debian/Linux
 181
 182         The configuration of Apache2 and installation does not depend on
 183         the kernel but on the distribution policy. Make launching of httpd
 184         work for Debian derived distributions.
 185
 186         * Scripts/run-webkit-httpd:
 187         * Scripts/run-webkit-tests:
 188         * Scripts/webkitdirs.pm:
 189
 190 2008-01-12  Mark Rowe  <mrowe@apple.com>
 191
 192         Reviewed by Maciej Stachowiak.
 193
 194         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
 195
 196         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
 197         match the callers expectations that it can take ownership of the string.
 198
 199 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
 200
 201         Reviewed by Adam Roben.
 202
 203         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
 204
 205         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
 206         as these are only posted because the test window is not a normal visible one, and
 207         they confuse drag&drop machinery.
 208
 209 2008-01-11  Adam Roben  <aroben@apple.com>
 210
 211         Fix a crash when pathToLocalResource fails and a leak
 212
 213         Reviewed by Darin.
 214
 215         * DumpRenderTree/LayoutTestController.cpp:
 216         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
 217         sure not to pass null to JSValueMakeString.
 218         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 219         (LayoutTestController::pathToLocalResource): Print an error message if
 220         the conversion fails so it's clear what happened.
 221
 222 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
 223
 224         Reviewed by John Sullivan.
 225
 226         * DumpRenderTree/mac/GCControllerMac.mm:
 227         (GCController::collectOnAlternateThread): Updated for name change.
 228
 229 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
 230
 231         wx build fix. Don't build dftables any longer since it's now a Perl
 232         script.
 233
 234         * wx/build-wxwebkit:
 235
 236 2008-01-10  Sam Weinig  <sam@webkit.org>
 237
 238         Reviewed by Anders Carlsson.
 239
 240         Make DRT track open windows instead of allocated windows so that
 241         we can avoid ASSERTION due to late deallocs out of our control.
 242
 243         * DumpRenderTree/mac/DumpRenderTree.mm:
 244         (dumpBackForwardListForAllWindows):
 245         (runTest):
 246         * DumpRenderTree/mac/DumpRenderTreeMac.h:
 247         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
 248         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
 249         (+[DumpRenderTreeWindow openWindows]):
 250         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
 251         (-[DumpRenderTreeWindow close]):
 252         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 253         (LayoutTestController::windowCount):
 254
 255 2008-01-10  Ada Chan  <adachan@apple.com>
 256
 257         Meta key is not the same as Alt key on windows.
 258
 259         Reviewed by Darin.
 260
 261         * DumpRenderTree/win/EventSender.cpp:
 262         (keyDownCallback):
 263
 264 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
 265
 266         Reviewed by Darin, Sam and Adam.
 267
 268         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
 269         link in gmail message displays JavaScript alert falsely complaining
 270         about pop-up blocking.
 271         - Added the ability to enable the pop-up blocker via the
 272         LayoutTestController.
 273
 274         * DumpRenderTree/LayoutTestController.cpp:
 275         (setPopupBlockingEnabledCallback):
 276         (LayoutTestController::staticFunctions):
 277         * DumpRenderTree/LayoutTestController.h:
 278         * DumpRenderTree/mac/DumpRenderTree.mm:
 279         (setDefaultsToConsistentValuesForTesting):
 280         (resetWebViewToConsistentStateBeforeTesting):
 281         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 282         (LayoutTestController::setPopupBlockingEnabled):
 283
 284 2008-01-10  Lars Knoll  <lars@trolltech.com>
 285
 286         Reviewed by Simon.
 287
 288         rename QWebPageHistory to QWebHistory.
 289
 290
 291         * DumpRenderTree/qt/jsobjects.cpp:
 292
 293 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
 294
 295         Reviewed by Darin.
 296
 297         - add some more renames, adjust some
 298
 299         * Scripts/do-webcore-rename:
 300
 301 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
 302
 303         Reviewed by Oliver.
 304
 305         Enable SVG Fonts support by default.
 306
 307         * Scripts/build-webkit:
 308
 309 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
 310
 311         Reviewed by Adam.
 312
 313         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
 314         DRT doesn't handle platform specific pixel test results correctly.
 315
 316         <test>-expected.txt files and <test>-expected.png files may now live
 317         in different directories (ie. a cross-platform <test>-expected.txt file
 318         and a platform-specific <test>-expected.png file).
 319
 320         * Scripts/run-webkit-tests:
 321
 322 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
 323
 324         Reviewed by Darin.
 325
 326         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
 327         DRT did not correctly handle printing the '\0' char.  Now it does.
 328
 329         * DumpRenderTree/win/DumpRenderTree.cpp:
 330         (dumpFramesAsText):
 331         (dump):
 332
 333 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
 334
 335         Reviewed by Lars.
 336
 337         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
 338
 339
 340         * DumpRenderTree/qt/main.cpp:
 341         * DumpRenderTree/qt/testplugin.cpp:
 342         * DumpRenderTree/qt/testplugin.h:
 343
 344 2008-01-05  Mark Rowe  <mrowe@apple.com>
 345
 346         Reviewed by Alp Toker.
 347
 348         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
 349
 350         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 351         (processWork): Process pending work.
 352         (webViewLoadFinished): Schedule processing of pending work.
 353         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
 354
 355 2008-01-05  Darin Adler  <darin@apple.com>
 356
 357         * Scripts/do-webcore-rename: Some more renaming plans.
 358
 359 2008-01-04  Alice Liu  <alice.liu@apple.com>
 360
 361         Reviewed by Alexey and Darin.
 362
 363         Adding "home" and "end" to DRT's keydown since
 364         DOM key events can't handle keyIdentifiers at this point.
 365
 366         * DumpRenderTree/mac/EventSendingController.mm:
 367         (-[EventSendingController keyDown:withModifiers:]):
 368         * DumpRenderTree/win/EventSender.cpp:
 369         (keyDownCallback):
 370
 371 2008-01-04  Lars Knoll  <lars@trolltech.com>
 372
 373         Reviewed by Simon.
 374
 375         fix DRT after the changes to QWebPage.
 376
 377         The great thing is that we actually don't have
 378         any regressions from the QWebPage change :)
 379
 380
 381         * DumpRenderTree/qt/DumpRenderTree.cpp:
 382         (WebCore::DumpRenderTree::DumpRenderTree):
 383
 384 2008-01-04  Lars Knoll  <lars@trolltech.com>
 385
 386         Reviewed by Simon.
 387
 388         make QWebPage a QObject and get things to compile.
 389
 390         Nothing works currently though.
 391
 392
 393         * DumpRenderTree/qt/DumpRenderTree.cpp:
 394         (WebCore::DumpRenderTree::DumpRenderTree):
 395
 396 2008-01-04  Lars Knoll  <lars@trolltech.com>
 397
 398         Reviewed by Simon.
 399
 400         take a QString as identifier in QWebFrame::addToJSWindowObject.
 401
 402         * DumpRenderTree/qt/DumpRenderTree.cpp:
 403         (WebCore::DumpRenderTree::initJSObjects):
 404
 405 2008-01-04  Alp Toker  <alp@atoker.com>
 406
 407         GTK+ DRT build fix for breakage introduced in r29149.
 408
 409         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 410         (LayoutTestController::execCommand):
 411
 412 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
 413
 414         Reviewed by Darin.
 415
 416         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
 417
 418         Added layoutTestController.execCommand to access editor commands that are not available
 419         via document.execCommand.
 420
 421         * DumpRenderTree/LayoutTestController.cpp:
 422         (execCommandCallback):
 423         (LayoutTestController::staticFunctions):
 424         * DumpRenderTree/LayoutTestController.h:
 425         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 426         (LayoutTestController::execCommand):
 427         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 428         (LayoutTestController::queueLoad):
 429         (LayoutTestController::execCommand):
 430
 431 2008-01-03  Alice Liu  <alice.liu@apple.com>
 432
 433         Reviewed by Darin, Mitz.
 434
 435         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
 436
 437         the clickcount should not increase if the last click was at a different location.  it's a new click.
 438
 439         * DumpRenderTree/mac/DumpRenderTree.mm:
 440         (runTest):
 441         * DumpRenderTree/mac/EventSendingController.h:
 442         * DumpRenderTree/mac/EventSendingController.mm:
 443         (-[EventSendingController mouseDown]):
 444         (-[EventSendingController mouseUp]):
 445
 446 2008-01-03  Darin Adler  <darin@apple.com>
 447
 448         Reviewed by Adam.
 449
 450         * Scripts/update-webkit: Make this work a little better for the people at Apple
 451         who have a directory named Internal.
 452
 453 2008-01-03  Adam Roben  <aroben@apple.com>
 454
 455         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
 456
 457         Rubberstamped by Mark.
 458
 459         * Scripts/update-webkit-auxiliary-libs:
 460
 461 2008-01-03  Adam Roben  <aroben@apple.com>
 462
 463         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
 464
 465         http://bugs.webkit.org/show_bug.cgi?id=15663
 466
 467         Added a fuzz factor into the Last-Modified comparison for downloading
 468         WebKitAuxiliaryLibrary.zip.
 469
 470         The zip file is served from a set of mirrors who give Last-Modified
 471         times that are off by 1-3 seconds from each other. This was causing
 472         the build bots to redownload WebKitAuxiliaryLibrary for every build,
 473         which would then cause all of WebCore to rebuild each time.
 474
 475         Reviewed by Mark.
 476
 477         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
 478         at least 30 seconds newer than the old one -- otherwise we assume that
 479         the difference in time is due to the mirrors being slightly offset
 480         from each other.
 481         (sub lastModifiedToUnixTime): Added.
 482
 483 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
 484
 485         Windows build fix.
 486
 487         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
 488
 489 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
 490
 491         Reviewed by Lars.
 492
 493         Moved QWebPage::open to QWebFrame::load and added setHtml.
 494
 495
 496         * DumpRenderTree/qt/DumpRenderTree.cpp:
 497         (WebCore::DumpRenderTree::open):
 498
 499 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
 500
 501         Reviewed by Lars.
 502
 503         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
 504
 505
 506         * DumpRenderTree/qt/DumpRenderTree.cpp:
 507         (WebCore::DumpRenderTree::DumpRenderTree):
 508
 509 2008-01-02  Sam Weinig  <sam@webkit.org>
 510
 511         * Scripts/do-webcore-rename: Yet more renaming ideas.
 512
 513 2008-01-02  Darin Adler  <darin@apple.com>
 514
 515         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
 516
 517 2008-01-02  Alice Liu  <alice.liu@apple.com>
 518
 519         Reviewed by Sam Weinig.
 520
 521         fixing assertion hit with editing/selection/move-begin-end.html
 522
 523         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
 524         * DumpRenderTree/win/DumpRenderTree.vcproj:
 525         * DumpRenderTree/win/EventSender.cpp:
 526         (keyDownCallback):
 527         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
 528
 529 2008-01-02  Darin Adler  <darin@apple.com>
 530
 531         * Scripts/do-webcore-rename: Some more name change plans.
 532
 533 2008-01-02  Alice Liu  <alice.liu@apple.com>
 534
 535         Reviewed by Maciej.
 536
 537         Added handling for page up and page down in EventSender
 538
 539         * DumpRenderTree/mac/EventSendingController.mm:
 540         (-[EventSendingController keyDown:withModifiers:]):
 541         * DumpRenderTree/win/EventSender.cpp:
 542         (keyDownCallback):
 543
 544 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
 545
 546         Reviewed by Darin.
 547
 548         Fix fast/events/arrow-keys-on-body.html for real.
 549
 550         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
 551
 552 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
 553
 554         Reviewed by Darin.
 555
 556         http://bugs.webkit.org/show_bug.cgi?id=16674
 557         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
 558
 559         * Scripts/run-launcher:
 560
 561 2007-12-31  Darin Adler  <darin@apple.com>
 562
 563         Suggested by Antti.
 564
 565         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
 566         we get it installed on the build bots.
 567
 568 2007-12-30  Eric Seidel  <eric@webkit.org>
 569
 570         Reviewed by Sam.
 571
 572         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
 573
 574 2007-12-29  Darin Adler  <darin@apple.com>
 575
 576         Reviewed by Oliver.
 577
 578         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
 579           leak bot shows createCStringFromNPVariant result leaking
 580
 581         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 582         (pluginInvoke): Added a missing free.
 583
 584 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
 585
 586         Reviewed by Alp Toker.
 587
 588         http://bugs.webkit.org/show_bug.cgi?id=16390
 589         Use autotools or GNU make as the build system for the GTK port
 590
 591         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
 592         * GNUmakefile.am: Added.
 593
 594 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
 595
 596         Reviewed by Oliver.
 597
 598         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
 599
 600         * DumpRenderTree/win/EventSender.cpp:
 601         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
 602         of 1, even though WebKit currently ignores it.
 603
 604 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
 605
 606         wx buildbot fix. Update libpng dl script to the latest version.
 607
 608         * wx/install-unix-extras:
 609
 610 2007-12-22  Antti Koivisto  <antti@apple.com>
 611
 612         Fix a typo.
 613
 614         * Scripts/webkitdirs.pm:
 615
 616 2007-12-21  Sam Weinig  <sam@webkit.org>
 617
 618         Reviewed by Mark Rowe.
 619
 620         - Disable the back/forward cache using the new WebPreferences API
 621           instead of through the BackForwardList.  This makes us match what
 622           we do on Windows.
 623
 624         * DumpRenderTree/mac/DumpRenderTree.mm:
 625         (createWebViewAndOffscreenWindow):
 626         (setDefaultsToConsistentValuesForTesting):
 627
 628 2007-12-21  Dan Bernstein  <mitz@apple.com>
 629
 630         Reviewed by Mark Rowe.
 631
 632         - disable the back/forward cache in Windows DumpRenderTree. It is
 633           already disabled in Mac DumpRenderTree.
 634
 635         * DumpRenderTree/win/DumpRenderTree.cpp:
 636         (initializePreferences):
 637
 638 2007-12-13  Antti Koivisto  <antti@apple.com>
 639
 640         Reviewed by Darin and Steve.
 641
 642         - check for QuickTime SDK on Windows.
 643         - build media support on Windows by default
 644
 645         * Scripts/build-webkit:
 646         * Scripts/webkitdirs.pm:
 647
 648 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
 649
 650         Build script fix for buildbot.
 651
 652         * wx/build-wxwebkit:
 653
 654 2007-12-20  Eric Seidel  <eric@webkit.org>
 655
 656         Reviewed by mjs.
 657
 658         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
 659
 660 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
 661
 662         Reviewed by Steve.
 663
 664         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
 665         WebKit.
 666
 667         - Drosera and Safari need to use the same ProgIDs in order for
 668         CoCreateInstance to work properly.  The most robust way to do this is
 669         for WebKit to dynamically publish those ProgIDs.
 670
 671         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
 672         (DebuggerClient::createWebViewWithRequest):
 673         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
 674         statics.
 675         (Drosera::initUI):
 676         (Drosera::attach):
 677         (Drosera::attemptToCreateServerConnection):
 678         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
 679         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
 680         make use of the published ProgIDs.
 681         (ServerConnection::attemptToCreateServerConnection):
 682
 683 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
 684
 685         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
 686         - Build bot and leak fix.
 687
 688         * DumpRenderTree/LayoutTestController.cpp:
 689         (pathToLocalResourceCallback):
 690
 691 2007-12-19  David Kilzer  <ddkilzer@apple.com>
 692
 693         Make svn-apply/svn-unapply work with patches from git-format-patch.
 694
 695         Reviewed by Darin.
 696
 697         * Scripts/svn-apply:
 698         (patch): If 'Index:' can't be found in the text passed in, print it
 699         out with a warning and return early.
 700         * Scripts/svn-unapply:
 701         (patch): Ditto.
 702
 703 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
 704
 705         Reviewed by Alp Toker.
 706
 707         Build related fixes.
 708
 709         * wx/build-wxwebkit:
 710         - Check to make sure the user is running a supported wx port
 711         - More robust checks for Cygwin
 712         - Only run install-unix-extras on Mac, it's not the right solution
 713           for Linux distros.
 714         - Remove outdated Linux instructions after successful build
 715         - Clean Bakefile-generated files during a clean operation
 716
 717 2007-12-18  Darin Adler  <darin@apple.com>
 718
 719         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
 720
 721 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
 722
 723         Add script to run Drosera as part of the nightly.
 724
 725         Reviewed by Kevin M.
 726
 727         * Scripts/run-drosera.cmd: Added.
 728
 729 2007-12-18  Darin Adler  <darin@apple.com>
 730
 731         * Scripts/do-webcore-rename: Remove a stray K.
 732
 733 2007-12-18  Darin Adler  <darin@apple.com>
 734
 735         * Scripts/do-webcore-rename: Plan more renaming.
 736
 737 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
 738
 739         Reviewed by Alp Toker.
 740
 741         http://bugs.webkit.org/show_bug.cgi?id=16042
 742         [GTK] Eliminate webkit_init()
 743
 744         Moving webkit initialization to WebView class init.
 745
 746         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 747         (main):
 748         * GtkLauncher/main.c:
 749         (main):
 750
 751 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
 752
 753         Reviewed by Alp Toker.
 754
 755         http://bugs.webkit.org/show_bug.cgi?id=13542
 756         gdklauncher doesnt change URL in adress GTKEntry.
 757
 758         * GtkLauncher/main.c:
 759         (load_commit_cb): added
 760         (title_change_cb):
 761         (create_browser):
 762
 763 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
 764
 765         Reviewed by Adam Roben.
 766
 767         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
 768
 769         * FindSafari/FindSafari.cpp:
 770         (_tmain):
 771
 772 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
 773
 774         Reviewed by Adam Roben.
 775
 776         http://bugs.webkit.org/show_bug.cgi?id=16315
 777         FindSafari needs a path-only option.
 778
 779         * FindSafari/FindSafari.cpp:
 780         (_tmain):
 781
 782 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
 783
 784         Reviewed by Darin.
 785
 786         http://bugs.webkit.org/show_bug.cgi?id=16462
 787         REGRESSION: access keys broken on Windows
 788
 789         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
 790         if Alt is pressed.
 791
 792 2007-12-15  Sam Weinig  <sam@webkit.org>
 793
 794         Reviewed by Mark Rowe.
 795
 796         Fix urlSuitableForTestResult to correctly identify wstring::npos as
 797         the case when wstring.find doesn't find anything.
 798
 799         * DumpRenderTree/win/DumpRenderTree.cpp:
 800         (urlSuitableForTestResult):
 801
 802 2007-12-15  Alp Toker  <alp@atoker.com>
 803
 804         GTK+ DRT build fix for GLib < 2.14.
 805
 806         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 807         (LayoutTestController::setWaitToDump):
 808
 809 2007-12-05  Mark Rowe  <mrowe@apple.com>
 810
 811         Reviewed by Alp Toker.
 812
 813         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
 814         many layout tests from hanging while waiting on user responses to dialogs.
 815
 816         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 817         (invalidateAnyPreviousWaitToDumpWatchdog):
 818         (webViewScriptAlert):
 819         (webViewScriptPrompt):
 820         (webViewScriptConfirm):
 821         (main):
 822         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
 823         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 824         (waitToDumpWatchdogFired):
 825         (LayoutTestController::setWaitToDump):
 826
 827 2007-12-05  Mark Rowe  <mrowe@apple.com>
 828
 829         Reviewed by Alp Toker.
 830
 831         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
 832
 833         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 834         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
 835         (dump):
 836         (runTest):
 837         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
 838         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
 839         work queue is empty.
 840         (webViewWindowObjectCleared): Set up window.layoutTestController.
 841         (webViewConsoleMessage): Match the console message format expected by the layout test results.
 842         (main): Hook up the new signals.
 843         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
 844         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
 845         dumping multiple times.
 846         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
 847         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
 848
 849 2007-12-14  Anders Carlsson  <andersca@apple.com>
 850
 851         Reviewed by Brady.
 852
 853         Assert that a web frame that's loading a resource always has either a data source or
 854         a provisional data source.
 855
 856         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
 857         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
 858
 859 2007-12-14  Darin Adler  <darin@apple.com>
 860
 861         - fix mistake causing nearly all tests to fail on Windows
 862
 863         * DumpRenderTree/win/UIDelegate.cpp:
 864         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
 865         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
 866
 867         * DumpRenderTree/mac/UIDelegate.mm:
 868         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
 869         than passing the entire message.
 870
 871 2007-12-14  Darin Adler  <darin@apple.com>
 872
 873         - fix Tiger build
 874
 875         * DumpRenderTree/mac/UIDelegate.mm:
 876         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
 877         new-to-Leopard methods.
 878
 879 2007-12-14  Darin Adler  <darin@apple.com>
 880
 881         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
 882         since it now triggers unwanted icon loading. We only had it because we implemented "all"
 883         delegate methods here.
 884
 885 2007-12-14  Anders Carlsson  <andersca@apple.com>
 886
 887         Reviewed by Darin and Geoff.
 888
 889         <rdar://problem/5619295>
 890         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
 891
 892         Add property getting methods to the plug-in.
 893
 894         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 895         (pluginInvoke):
 896
 897 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
 898
 899         Reviewed by Darin.
 900
 901         - Layout test fix for mac. When dumped to the console local file paths
 902         now only show the name of the resource not the whole path.  This is to
 903         make the results machine and OS independent.
 904
 905         * DumpRenderTree/mac/UIDelegate.mm:
 906         (-[UIDelegate webView:addMessageToConsole:]):
 907
 908 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
 909
 910         Reviewed by Adam.
 911
 912         - Layout tests fix.  We need a way to remove machine-dependent
 913         information from paths in layout test results. The UIDelegate now does
 914         this.
 915
 916         * DumpRenderTree/DumpRenderTree.h:
 917         * DumpRenderTree/win/DumpRenderTree.cpp:
 918         (urlSuitableForTestResult):
 919         * DumpRenderTree/win/DumpRenderTreeWin.h:
 920         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
 921         * DumpRenderTree/win/UIDelegate.cpp:
 922         (UIDelegate::webViewAddMessageToConsole):
 923
 924 2007-12-13  Alp Toker  <alp@atoker.com>
 925
 926         Build fix for DRT breakage introduced in r28690.
 927
 928         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 929         (LayoutTestController::pathToLocalResource):
 930
 931 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
 932
 933         Reviewed by Alice and Sam.
 934
 935         - <rdar://5621435> Need a way to specify local resources (being loaded
 936         from HTTP tests) on Windows.
 937         - Implemented pathToLocalResource which exposes the functionality of
 938         converting a given unix path to the correct location on Windows.
 939
 940         * DumpRenderTree/LayoutTestController.cpp:
 941         (pathToLocalResourceCallback):
 942         (LayoutTestController::staticFunctions):
 943         * DumpRenderTree/LayoutTestController.h:
 944         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 945         (LayoutTestController::pathToLocalResource):
 946         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 947         (LayoutTestController::pathToLocalResource):
 948
 949 2007-12-12  Anders Carlsson  <andersca@apple.com>
 950
 951         Reviewed by Sam.
 952
 953         <rdar://problem/5132003>
 954         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
 955
 956         * DumpRenderTree/win/DumpRenderTree.cpp:
 957         (main):
 958         Set the resource load delegate.
 959
 960         * DumpRenderTree/win/DumpRenderTree.vcproj:
 961
 962         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
 963         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
 964
 965 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
 966
 967         Reviewed by Adam Roben.
 968
 969         Fix conversion from double to LPARAM in dispatchMessage().
 970
 971         * DumpRenderTree/win/EventSender.cpp:
 972         (dispatchMessageCallback):
 973
 974 2007-12-11  Dan Bernstein  <mitz@apple.com>
 975
 976         Reviewed by Mark Rowe and Sam Weinig too!
 977
 978         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
 979           fonts DumpRenderTree registers.
 980
 981         * DumpRenderTree/win/DumpRenderTree.cpp:
 982         (initialize):
 983
 984 2007-12-11  Brady Eidson  <beidson@apple.com>
 985
 986         Reviewed by Anders
 987
 988         Make DumpRenderTree on mac use its own path for Databases testing
 989
 990         * DumpRenderTree/mac/DumpRenderTree.mm:
 991         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree
 992           for future DRT-only use, then use it to construct the Databases path and set that default
 993
 994 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
 995
 996         Reviewed by Darin.
 997
 998         <rdar://problem/5535636>
 999         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1000
1001         http://bugs.webkit.org/show_bug.cgi?id=13916
1002         JavaScript detects Tab as a character input on a textfield validation
1003
1004         * DumpRenderTree/mac/EventSendingController.mm:
1005         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
1006         Dispatch a keyup to better match what happens when a key is physically pressed.
1007
1008         * DumpRenderTree/win/EventSender.cpp:
1009         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
1010         returning from keyDown().
1011         (getConstantCallback): Fixed a couple copy/paste mistakes.
1012
1013 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
1014
1015         Reviewed by Oliver.
1016
1017         - <rdar://5599845> Drosera: Does not show loal files in the file list
1018         on the left side.
1019
1020         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
1021         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
1022         so the open source community can build.
1023
1024 2007-12-10  Brady Eidson  <beidson@apple.com>
1025
1026         Rubberstamped by Sam Weinig
1027
1028         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
1029
1030         * DumpRenderTree/mac/UIDelegate.mm:
1031         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1032         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1033
1034 2007-12-08  Oliver Hunt  <oliver@apple.com>
1035
1036         Reviewed by Sam W.
1037
1038         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1039
1040         Fixes <rdar://problem/5620249> Must disable SVG animation
1041         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1042
1043         In order to allow finer grained control over the set of SVG features
1044         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
1045         distinct flags:
1046         ENABLE_SVG_ANIMATION
1047         ENABLE_SVG_FILTERS
1048         ENABLE_SVG_FONTS
1049         ENABLE_SVG_AS_IMAGE
1050         ENABLE_SVG_USE
1051
1052         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
1053
1054         Script handles all the new build flags, and allows --svg-experimental
1055         to automatically enable all features.
1056
1057         * Scripts/build-webkit:
1058
1059 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1060
1061         Fix version parsing.
1062
1063         Rubber-stamped by Oliver.
1064
1065         * Drosera/win/Drosera.vcproj/auto-version.sh:
1066
1067 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1068
1069         Build modifications for Drosera.
1070
1071         Reviewed by Adam.
1072
1073         * Drosera/DroseraWin.make: Added.
1074         * Drosera/win/Drosera.vcproj/Drosera.rc:
1075         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1076         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
1077         * Drosera/win/Drosera.vcproj/VERSION: Added.
1078         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
1079
1080 2007-12-06  Adam Roben  <aroben@apple.com>
1081
1082         Explicitly turn on the Mac font ascent hack on Windows
1083
1084         This keeps our font metrics matching those from Mac.
1085
1086         Reviewed by Hyatt.
1087
1088         * DumpRenderTree/win/DumpRenderTree.cpp:
1089         (main):
1090
1091 2007-12-06  Anders Carlsson  <andersca@apple.com>
1092
1093         Rename main.c to main.cpp here too.
1094
1095         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
1096
1097 2007-12-06  Sam Weinig  <sam@webkit.org>
1098
1099         Rubber stamped by Geoff.
1100
1101         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
1102
1103 2007-12-06  Darin Adler  <darin@apple.com>
1104
1105         * Scripts/do-webcore-rename: Some more renaming plans.
1106
1107 2007-12-06  Anders Carlsson  <andersca@apple.com>
1108
1109         Restore implementation of testGetIntIdentifier that was accidentally
1110         removed somehow (possibly when I made PluginObject be a cpp file).
1111
1112         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1113         (pluginInvoke):
1114
1115 2007-12-05  Anders Carlsson  <andersca@apple.com>
1116
1117         Make the entry points extern "C".
1118         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1119
1120 2007-12-05  Anders Carlsson  <andersca@apple.com>
1121
1122         C++ warning fixes.
1123
1124         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1125         (NPP_New):
1126         (NPP_Destroy):
1127         (NPP_SetWindow):
1128         (NPP_NewStream):
1129         (NPP_HandleEvent):
1130         (NPP_URLNotify):
1131         (NPP_GetValue):
1132
1133 2007-12-05  Anders Carlsson  <andersca@apple.com>
1134
1135         Add the .cpp files to the TestNetscapePlugIn target.
1136
1137         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1138
1139 2007-12-05  Anders Carlsson  <andersca@apple.com>
1140
1141         Reviewed by Geoff.
1142
1143         Rename the TestNetscapePlugIn .c files to be .cpp.
1144
1145         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1146         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
1147         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
1148         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
1149         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
1150         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
1151         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
1152         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1153
1154 2007-12-05  Adam Roben  <aroben@apple.com>
1155
1156         Fix case of keypresses from the Windows implementation of eventSender.keyDown
1157
1158         This fixes several regression tests.
1159
1160         Reviewed by Alice.
1161
1162         * DumpRenderTree/win/EventSender.cpp:
1163         (keyDownCallback): Virtual keycodes for ASCII characters are always
1164         uppercase, so we need to check the case of the original character
1165         passed in to eventSender.keyDown.
1166
1167 2007-12-05  Adam Roben  <aroben@apple.com>
1168
1169         Learn from Tim's mistakes
1170
1171         * DumpRenderTree/win/DumpRenderTree.cpp:
1172         (runTest): Reset the authorAndUserStylesEnabled preference for each
1173         test.
1174
1175 2007-12-05  Alp Toker  <alp@atoker.com>
1176
1177         Reviewed by Mark Rowe.
1178
1179         Initialize GTK+ and WebKit so the tests can run.
1180
1181         Reorganize the headers a little.
1182
1183         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1184         (main):
1185
1186 2007-12-04  Anders Carlsson  <andersca@apple.com>
1187
1188         Remove IWebScriptScope include.
1189
1190         * Drosera/win/DebuggerDocumentPlatform.cpp:
1191
1192 2007-12-04  Sam Weinig  <sam@webkit.org>
1193
1194         Rubber stamped by Mark Rowe.
1195
1196         Define CF as platform for mac and revert r28409
1197
1198         * DumpRenderTree/DumpRenderTree.h:
1199         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1200
1201 2007-12-04  Sam Weinig  <sam@webkit.org>
1202
1203         Define CF as platform for windows.
1204
1205         Reviewed by Adam Roben.
1206
1207         * DumpRenderTree/win/DumpRenderTreeWin.h:
1208
1209 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
1210
1211         Reviewed by Adam and Darin.
1212
1213         - Removed a needless BSTR cleanup.
1214
1215         * Drosera/win/DebuggerDocumentPlatform.cpp:
1216         (DebuggerDocument::getPlatformCurrentFunctionStack):
1217
1218 2007-11-27  Adam Roben  <aroben@apple.com>
1219
1220         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
1221
1222         Reviewed by Maciej.
1223
1224         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1225         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
1226
1227 2007-12-04  Alp Toker  <alp@atoker.com>
1228
1229         Prospective Win DRT build fix.
1230
1231         * DumpRenderTree/DumpRenderTree.h:
1232
1233 2007-12-04  Alp Toker  <alp@atoker.com>
1234
1235         Fix a clobbered copyright header.
1236
1237         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1238
1239 2007-12-04  Xan Lopez  <xan@gnome.org>
1240
1241         Reviewed by Alp Toker.
1242
1243         http://bugs.webkit.org/show_bug.cgi?id=15561
1244         GTK port needs DumpRenderTree implementation
1245
1246         Start work on the GTK+ DRT.
1247
1248         This does not work yet, and there are a few lingering style issues
1249         (nothing major) but this patch has been stuck in the bug tracker for
1250         too long already.
1251
1252         * DumpRenderTree/DumpRenderTree.h:
1253         * DumpRenderTree/gtk: Added.
1254         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
1255         (autocorrectURL):
1256         (shouldLogFrameLoadDelegates):
1257         (dumpFrameScrollPosition):
1258         (displayWebView):
1259         (appendString):
1260         (dumpFramesAsText):
1261         (dumpRenderTreeAsText):
1262         (dump):
1263         (runTest):
1264         (main):
1265         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
1266         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
1267         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
1268         (GCController::collect):
1269         (GCController::collectOnAlternateThread):
1270         (GCController::getJSObjectCount):
1271         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
1272         (LayoutTestController::~LayoutTestController):
1273         (LayoutTestController::addDisallowedURL):
1274         (LayoutTestController::clearBackForwardList):
1275         (LayoutTestController::copyDecodedHostName):
1276         (LayoutTestController::copyEncodedHostName):
1277         (LayoutTestController::display):
1278         (LayoutTestController::keepWebHistory):
1279         (LayoutTestController::notifyDone):
1280         (LayoutTestController::queueBackNavigation):
1281         (LayoutTestController::queueForwardNavigation):
1282         (LayoutTestController::queueLoad):
1283         (LayoutTestController::queueReload):
1284         (LayoutTestController::queueScript):
1285         (LayoutTestController::setAcceptsEditing):
1286         (LayoutTestController::setCustomPolicyDelegate):
1287         (LayoutTestController::setMainFrameIsFirstResponder):
1288         (LayoutTestController::setTabKeyCyclesThroughElements):
1289         (LayoutTestController::setUseDashboardCompatibilityMode):
1290         (LayoutTestController::setUserStyleSheetEnabled):
1291         (LayoutTestController::setUserStyleSheetLocation):
1292         (LayoutTestController::setWindowIsKey):
1293         (LayoutTestController::setWaitToDump):
1294         (LayoutTestController::windowCount):
1295         (LayoutTestController::setPrivateBrowsingEnabled):
1296         (LayoutTestController::setAuthorAndUserStylesEnabled):
1297         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
1298         (JSStringCopyUTF8CString):
1299         (LoadItem::invoke):
1300         (ReloadItem::invoke):
1301         (ScriptItem::invoke):
1302         (BackForwardItem::invoke):
1303
1304 2007-12-03  Sam Weinig  <sam@webkit.org>
1305
1306         Move JavaScriptCore thread testing code to pthread specific directory
1307         and remove the dependance on CoreFoundation by using WTF::HashSet.
1308
1309         Reviewed by Geoff and Oliver.
1310
1311         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1312         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
1313         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
1314         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
1315         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
1316         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
1317         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
1318         * DumpRenderTree/pthreads: Added.
1319         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
1320         (javaScriptThreads):
1321         (runJavaScriptThread):
1322         (startJavaScriptThreads):
1323         (stopJavaScriptThreads):
1324
1325 2007-12-03  Andrew Bonventre  <andybons@google.com>
1326
1327         Reviewed by Darin Adler.
1328
1329         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
1330         Symbol lookup menu broken in debugger view
1331
1332         * Drosera/debugger.js: Fixed javascript error where document property
1333         should have been used instead of contentDocument in switchFunction that
1334         was breaking the select symbol dropdown menu.  This is because
1335         window.frames will return a Window object and not a frame object like
1336         the author was originally expecting.
1337
1338 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
1339
1340         Reviewed by Adam.
1341
1342         - <rdar://5618942> Drosera: Console window does not process everything
1343         correctly.
1344         - <rdar://5619005> Drosera: could be sped up by moving the
1345         WebScriptScope stuff into the WebScriptCallFrame.
1346         - Now the console can correctly process objects and does not receive
1347         notifications from JavaScriptCore about the JavaScript in Drosera's
1348         own process.
1349
1350         * Drosera/win/DebuggerDocumentPlatform.cpp:
1351         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1352         (DebuggerDocument::platformValueForScopeVariableNamed):
1353
1354 2007-12-03  Stephanie  <slewis@apple.com>
1355
1356         Reviewed by Darin.
1357
1358         Check to see if we are building a debug root
1359
1360         * Scripts/check-for-global-initializers:
1361
1362 2007-12-03  Dan Bernstein  <mitz@apple.com>
1363
1364         Reviewed by Darin Adler.
1365
1366         - added a testGetIntIdentifier() method to TestNetscapePlugIn
1367
1368         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1369         (pluginInvoke):
1370
1371 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
1372
1373         Reviewed by Oliver.
1374
1375         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
1376         in a more fine-grained manner than eventSender.keyDown().
1377
1378         * DumpRenderTree/win/EventSender.cpp:
1379         (getConstantCallback):
1380         (dispatchMessageCallback):
1381
1382 2007-12-02  Darin Adler  <darin@apple.com>
1383
1384         * Scripts/do-webcore-rename: More planned renaming.
1385
1386 2007-12-02  Sam Weinig  <sam@webkit.org>
1387
1388         Rubber stamped by Anders.
1389
1390         Use [NSURL absoluteString] instead of [NSURL description] in order to get
1391         more uniform results cross platform.
1392
1393         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1394         (-[NSURL _drt_descriptionSuitableForTestResult]):
1395
1396 2007-12-02  Sam Weinig  <sam@webkit.org>
1397
1398         Rubber stamped by Niko.
1399
1400         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
1401
1402         * DumpRenderTree/win/DumpRenderTree.cpp:
1403         * DumpRenderTree/win/DumpRenderTree.vcproj:
1404         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
1405         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
1406         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
1407         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
1408
1409 2007-12-01  Alp Toker  <alp@atoker.com>
1410
1411         Reviewed by Adam Roben.
1412
1413         Make use of the newly introduced webkit.h convenience header.
1414
1415         * GtkLauncher/main.c:
1416
1417 2007-12-01  Adam Treat  <treat@kde.org>
1418
1419         Reviewed by Simon.
1420
1421         * Check to see if the directory exists and exit if not.
1422
1423         * DumpRenderTree/qt/main.cpp:
1424         (main):
1425
1426 2007-12-01  Adam Treat  <treat@kde.org>
1427
1428         Reviewed by Simon.
1429
1430         * Don't hide symbols when in Debug mode
1431         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
1432
1433
1434         * DumpRenderTree/qt/main.cpp:
1435         (messageHandler):
1436
1437 2007-11-30  Alp Toker  <alp@atoker.com>
1438
1439         Reviewed by Adam Roben.
1440
1441         http://bugs.webkit.org/show_bug.cgi?id=15691
1442         [GTK] Public API does not follow GTK+ conventions
1443
1444         Refactor the WebKit/GTK+ public API. Changes:
1445           WebKitPage -> WebKitWebView
1446           WebKitFrame -> WebKitWebFrame
1447
1448         Public API source and header names have been updated to mirror the API
1449         changes.
1450
1451         The API is now kept in WebKit/gtk/WebView to match other ports in the
1452         same class such as Mac and Win.
1453
1454         * GtkLauncher/main.c:
1455         (activate_uri_entry_cb):
1456         (link_hover_cb):
1457         (title_change_cb):
1458         (progress_change_cb):
1459         (go_back_cb):
1460         (go_forward_cb):
1461         (create_browser):
1462         (main):
1463
1464 2007-11-30  Adam Roben  <aroben@apple.com>
1465
1466         Hopefully the final build fix
1467
1468         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
1469         pull in WTF's assertion/logging functions.
1470
1471 2007-11-30  Adam Roben  <aroben@apple.com>
1472
1473         Another build fix
1474
1475         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
1476         WebKit.lib.
1477
1478 2007-11-30  Adam Roben  <aroben@apple.com>
1479
1480         Debug build fix
1481
1482         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
1483         configuration.
1484         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
1485         projects.
1486         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
1487         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
1488         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
1489
1490 2007-11-30  Sam Weinig  <sam@webkit.org>
1491
1492         Reviewed by Adam Roben.
1493
1494         Fix drawSelectionRect to actually draw the selection rect.
1495
1496         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1497         (drawSelectionRect):
1498
1499 2007-11-30  Darin Adler  <darin@apple.com>
1500
1501         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
1502
1503 2007-11-30  Darin Adler  <darin@apple.com>
1504
1505         * Scripts/do-webcore-rename: Get ready for some future renaming.
1506
1507 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1508
1509         Reviewed by Adam.
1510
1511         - Removed some unnecessary functions and changed an unused return type.
1512
1513         * Drosera/win/DebuggerClient.cpp:
1514         (registerConsoleClass):
1515         * Drosera/win/DebuggerClient.h:
1516         * Drosera/win/Drosera.cpp:
1517         (registerDroseraClass):
1518
1519 2007-11-28  Alp Toker  <alp@atoker.com>
1520
1521         Reviewed by Timothy Hatcher.
1522
1523         http://bugs.webkit.org/show_bug.cgi?id=16174
1524         [GTK] Use "URI" not "URL" in public API
1525
1526         Replace use of the term "URL" with "URI" in public headers,
1527         documentation and some internal code to match GLib/GTK+ convention.
1528
1529         This is now mentioned in the API guidelines:
1530           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
1531
1532         * GtkLauncher/main.c:
1533         (activate_uri_entry_cb):
1534         (title_change_cb):
1535         (create_toolbar):
1536         (main):
1537
1538 2007-11-29  Anders Carlsson  <andersca@apple.com>
1539
1540         Reviewed by Sam.
1541
1542         <rdar://problem/5230478>
1543         FrameLoadDelegate callbacks are not dumped in DRT.
1544
1545         * DumpRenderTree/win/DumpRenderTree.cpp:
1546         (shouldLogFrameLoadDelegates):
1547         (runTest):
1548         (main):
1549         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1550         (BSTRtoString):
1551         (descriptionSuitableForTestResult):
1552         (FrameLoadDelegate::QueryInterface):
1553         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1554         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1555         (FrameLoadDelegate::didCommitLoadForFrame):
1556         (FrameLoadDelegate::didFinishLoadForFrame):
1557         (FrameLoadDelegate::willCloseFrame):
1558         (FrameLoadDelegate::didClearWindowObject):
1559         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1560         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1561         * DumpRenderTree/win/FrameLoaderDelegate.h:
1562         (FrameLoadDelegate::windowScriptObjectAvailable):
1563         (FrameLoadDelegate::didFirstLayoutInFrame):
1564
1565 2007-11-29  Sam Weinig  <sam@webkit.org>
1566
1567         Reviewed by Anders.
1568
1569         Add database quota UIDelegates methods to DRT UIDelegate.
1570
1571         * DumpRenderTree/mac/UIDelegate.mm:
1572         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1573         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
1574
1575 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1576
1577         Reviewed by Sam.
1578
1579         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
1580         dying and vice versa.
1581         - This fix will allow Drosera and Safari to reconnect if either of them
1582         closes correctly, but does not fix the case where one of them dies
1583         silently.
1584
1585         * Drosera/win/ServerConnection.cpp:
1586         (ServerConnection::attemptToCreateServerConnection): Added a safety
1587         check, because it's possilbe to try to connect to a server that's dying.
1588         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
1589         the server has died.
1590         * Drosera/win/ServerConnection.h: Added the new function and removed
1591         an unnecessary member.
1592
1593 2007-11-29  Anders Carlsson  <andersca@apple.com>
1594
1595         * DumpRenderTree/win/DumpRenderTree.vcproj:
1596         Add shlwapi.lib to all configurations.
1597
1598 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1599
1600         - Build fix.  Added additional includes for VS Express to the Release
1601         project.
1602
1603         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1604
1605 2007-11-29  Anders Carlsson  <andersca@apple.com>
1606
1607         Reviewed by Adam.
1608
1609         <rdar://problem/5132005>
1610         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
1611
1612         * DumpRenderTree/win/DumpRenderTree.vcproj:
1613         Add shlwapi.lib
1614
1615         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1616         (LayoutTestController::setUserStyleSheetEnabled):
1617         Implement this.
1618
1619         (appendComponentToPath):
1620         New method which wraps the Win32 API PathAppend.
1621
1622         (followShortcuts):
1623         New method which checks if a file points to a shortcut and
1624         follows the shortcut.
1625
1626         (resolveCygwinPath):
1627         New method that takes a cygwin unix-style path and returns the Win32 path.
1628
1629         (cfStringRefToWString):
1630
1631         (LayoutTestController::setUserStyleSheetLocation):
1632         Implement this.
1633
1634 2007-11-29  Alice Liu  <alice.liu@apple.com>
1635
1636         Reviewed by Adam.
1637
1638         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
1639
1640         * DumpRenderTree/win/EventSender.cpp:
1641         (keyDownCallback):
1642         uppercase letters were being sent as lowercase letters without the shift key down.
1643
1644 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1645
1646         - Windows build fix. VS express needs some love.
1647
1648         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1649
1650 2007-11-28  Darin Adler  <darin@apple.com>
1651
1652         Reviewed by Adam Roben.
1653
1654         * DumpRenderTree/mac/EventSendingController.mm:
1655         (-[EventSendingController keyDown:withModifiers:]):
1656         Send capital letters through as lowercase letters with the shift key down
1657         rather than sending them as if they were highly unusual "capital letter keys".
1658
1659         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1660         where you need to update results and more tests are failing than before.
1661
1662 2007-11-28  Anders Carlsson  <andersca@apple.com>
1663
1664         Reviewed by Darin.
1665
1666         <rdar://problem/5132001>
1667         contextClick is not implemented in DRT on Windows.
1668
1669         * DumpRenderTree/win/EventSender.cpp:
1670         (contextClickCallback):
1671         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1672         by a WM_RBUTTONUP message.
1673
1674         * DumpRenderTree/win/UIDelegate.cpp:
1675         (UIDelegate::hasCustomMenuImplementation):
1676         (UIDelegate::trackCustomPopupMenu):
1677         * DumpRenderTree/win/UIDelegate.h:
1678         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1679         menu from being shown (and causing the DRT to hang).
1680
1681 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1682
1683         Reviewed by Darin.
1684
1685         Fix DumpRenderTree ObjC bug comparing strings.
1686
1687         * DumpRenderTree/mac/ObjCController.m:
1688         (-[ObjCController identityIsEqual::]): Compare strings with string
1689         equality instead of identiy equality.
1690
1691 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1692
1693         Reviewed by Sam.
1694
1695         Reset the authorAndUserStylesEnabled preference
1696         back to YES for each test. Fixes the broken tests.
1697
1698         * DumpRenderTree/mac/DumpRenderTree.mm:
1699         (resetWebViewToConsistentStateBeforeTesting):
1700
1701 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1702
1703         Reviewed by Adam.
1704
1705         - Drosera now displays the console window, although it cannot currently
1706         process JavaScript.
1707
1708         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1709         (registerConsoleClass): Implemented.
1710         (consoleWndProc): Implemented.
1711         (DebuggerClient::onSize): Implemented.
1712         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1713         new window.
1714         * Drosera/win/DebuggerClient.h: Added needed method and members for
1715         creating and maintaining a new window.
1716         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1717         lines of code to more appropriate places.
1718         (Drosera::handleCommand):
1719         (Drosera::initUI):
1720         (Drosera::onSize):
1721         (Drosera::attach):
1722
1723 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1724
1725         Reviewed by Dave Hyatt.
1726
1727         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1728
1729         Add support for disabling author and user styles for testing.
1730
1731         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1732         * DumpRenderTree/LayoutTestController.cpp:
1733         (setAuthorAndUserStylesEnabledCallback):
1734         (LayoutTestController::staticFunctions):
1735         * DumpRenderTree/LayoutTestController.h:
1736         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1737         (LayoutTestController::setAuthorAndUserStylesEnabled):
1738         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1739         (LayoutTestController::setAuthorAndUserStylesEnabled):
1740
1741 2007-11-26  Dan Bernstein  <mitz@apple.com>
1742
1743         - Tiger build fix.
1744
1745         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1746
1747 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1748
1749         Reviewed by Maciej.
1750
1751         - Implemented displaying variables for Drosera on Win.
1752
1753         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1754         that retrieve variables to not hold onto the return value since it's
1755         not returned.  Also changed to use the new signatures of the retrieval
1756         functions.
1757         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1758         (DebuggerDocument::platformValueForScopeVariableNamed):
1759         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1760         (droseraWndProc):
1761
1762 2007-11-26  Sam Weinig  <sam@webkit.org>
1763
1764         Cleanup names of painting and repainting functions.
1765
1766         Reviewed by Adam Roben.
1767
1768         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1769         (drawSelectionRect): was drawSelectionRectIntoContext.
1770         (dumpWebViewAsPixelsAndCompareWithExpected):
1771         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1772         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1773         (paintWebView): was drawWebViewIntoContext.
1774         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1775
1776 2007-11-26  Sam Weinig  <sam@webkit.org>
1777
1778         Reviewed by Dan Bernstein.
1779
1780         - Leopard build fix
1781
1782         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1783
1784 2007-11-26  Sam Weinig  <sam@webkit.org>
1785
1786         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1787         Use shared PixelDumpSupport for Mac DRT
1788
1789         Reviewed by Adam Roben.
1790
1791         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1792         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1793         * DumpRenderTree/cg/ImageDiffCG.cpp:
1794         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1795         (drawSelectionRectIntoContext):
1796         (dumpWebViewAsPixelsAndCompareWithExpected):
1797         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1798         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1799         * DumpRenderTree/mac/DumpRenderTree.mm:
1800         (dump):
1801         * DumpRenderTree/mac/ImageDiff.m: Removed.
1802         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1803         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1804         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1805         (setDefaultColorProfileToRGB):
1806         (getBitmapContextFromWebView):
1807         (drawWebViewIntoContext):
1808         (repaintWithVerticalSweep):
1809         (repaintWithHorizontalSweep):
1810         (getSelectionRect):
1811         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1812
1813 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1814
1815         Bug 16052: prepare-ChangeLog doesn't report deleted files
1816         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1817
1818         Reviewed by Sam.
1819
1820         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1821
1822 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1823
1824         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1825         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1826
1827         Reviewed by Adam.
1828
1829         Roll functionality of merge-changelog into resolve-ChangeLogs
1830         script.  The script now checks for ChangeLog.rej and
1831         ChangeLog.orig files first.  If it finds them, it uses the
1832         ChangeLog.rej file as a patch (in old contextual diff format) to
1833         apply with --fuzz=3.
1834
1835         * Scripts/merge-changelog: Removed.
1836         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1837
1838 2007-11-25  Sam Weinig  <sam@webkit.org>
1839
1840         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1841
1842         Reviewed by Mark Rowe.
1843
1844         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1845         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1846         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1847         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1848         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1849
1850 2007-11-25  Sam Weinig  <sam@webkit.org>
1851
1852         Convert DumpRenderTree to ues .xcconfig files.
1853
1854         Reviewed by Mark Rowe.
1855
1856         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1857         * DumpRenderTree/mac/Configurations: Added.
1858         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1859         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1860         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1861
1862 2007-11-25  Sam Weinig  <sam@webkit.org>
1863
1864         Add ForwardingHeaders to wtf for DumpRenderTree.
1865
1866         Reviewed by Mark Rowe.
1867
1868         * DumpRenderTree/DumpRenderTree.h:
1869         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1870         * DumpRenderTree/ForwardingHeaders: Added.
1871         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1872         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1873         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1874         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1875         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1876         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1877         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1878         * DumpRenderTree/LayoutTestController.cpp:
1879         * DumpRenderTree/WorkQueue.cpp:
1880         * DumpRenderTree/mac/DumpRenderTree.mm:
1881         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1882         * DumpRenderTree/mac/JavaScriptThreading.cpp:
1883         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1884         * DumpRenderTree/mac/ObjCController.m:
1885         * DumpRenderTree/mac/UIDelegate.mm:
1886         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1887
1888 2007-11-25  Adam Roben  <aroben@apple.com>
1889
1890         Fix some test failures caused by r28019
1891
1892         Now that stdout is in binary mode, we need to always use printf
1893         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1894         the output.
1895
1896         Reviewed by Sam.
1897
1898         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1899         printf.
1900         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1901         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1902         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1903         (UIDelegate::webViewAddMessageToConsole):
1904
1905 2007-11-25  Adam Roben  <aroben@apple.com>
1906
1907         Set the font smoothing preference in DRT
1908
1909         This makes the pixel results on Windows closer to the Mac results.
1910
1911         Reviewed by Mitz.
1912
1913         * DumpRenderTree/win/DumpRenderTree.cpp:
1914         (initializePreferences):
1915
1916 2007-11-25  Adam Roben  <aroben@apple.com>
1917
1918         Port ImageDiff to CG and C++
1919
1920         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1921         <rdar://5071708>
1922
1923         Reviewed by Sam.
1924
1925         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1926         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1927         (main):
1928         (createImageFromStdin):
1929         (compareImages):
1930         (getDifferenceBitmap):
1931         (computePercentageDifferent):
1932         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1933
1934 2007-11-25  Adam Roben  <aroben@apple.com>
1935
1936         Fix image diff link generation on Windows
1937
1938         Reviewed by Sam.
1939
1940         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1941         to toURL.
1942
1943 2007-11-25  Adam Roben  <aroben@apple.com>
1944
1945         Implement pixel dumping in Windows DRT
1946
1947         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1948         <rdar://5071708>
1949
1950         Reviewed by Sam.
1951
1952         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1953         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1954         Content-Length header.
1955         (getMD5HashStringForBitmap):
1956         (dumpWebViewAsPixelsAndCompareWithExpected):
1957         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1958         * DumpRenderTree/win/DumpRenderTree.cpp:
1959         (dump): Do a pixel dump if requested.
1960         (main): Parse pixel test options.
1961         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1962         the cg/ subdirectory to the include path.
1963         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1964         available in a header or import library, so we have to go through this
1965         LoadLibrary/GetProcAddress dance to use them.
1966         (cryptDLL):
1967         (init):
1968         (update):
1969         (final):
1970         (MD5_Init):
1971         (MD5_Update):
1972         (MD5_Final):
1973         * DumpRenderTree/win/MD5.h: Added.
1974         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1975         moved up to the top level to share it with Mac eventually.
1976         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1977         (getBitmapContextFromWebView): Forces the WebView to paint using a
1978         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1979
1980 2007-11-25  Adam Roben  <aroben@apple.com>
1981
1982         Clean up Windows DRT's option parsing a little bit
1983
1984         Reviewed by Sam.
1985
1986         * DumpRenderTree/win/DumpRenderTree.cpp:
1987         (main): Put non-option arguments into a Vector.
1988
1989 2007-11-25  Adam Roben  <aroben@apple.com>
1990
1991         Make Windows DRT stop changing LF into CRLF
1992
1993         Reviewed by Sam.
1994
1995         * DumpRenderTree/win/DumpRenderTree.cpp:
1996         (main): Put stdout in binary mode.
1997         * Scripts/run-webkit-tests: Remove the CRLF hack.
1998
1999 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
2000
2001         Removed empty directory.
2002
2003         * Scripts/resources: Removed.
2004
2005 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
2006
2007         Fix bisect-builds to work with recent WebKit nightly builds.
2008
2009         Reviewed by Dan.
2010
2011         * Scripts/bisect-builds: Check for the
2012         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
2013         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
2014         to WebKit.app/Contents/Resources.
2015
2016 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
2017
2018         Reviewed by Maciej.
2019
2020         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
2021         not closed (affects digg.com)
2022
2023         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
2024         one after finishing with a test to avoid having its delayed onload handler firing when
2025         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
2026         but it helps somewhat.
2027
2028 2007-11-22  Mark Rowe  <mrowe@apple.com>
2029
2030         Reviewed by Alp Toker.
2031
2032         Fix build-webkit to propagate make's exit status if it fails.
2033
2034         * Scripts/webkitdirs.pm:
2035
2036 2007-11-22  Dan Bernstein  <mitz@apple.com>
2037
2038         Reviewed by Mark Rowe.
2039
2040         - fix crash when running pixel tests
2041
2042         * DumpRenderTree/mac/DumpRenderTree.mm:
2043         (dumpRenderTree): Parse the command line options before setting up the
2044         environment so that we know if we need to set up the pixel dump
2045         machinery.
2046
2047 2007-11-21  Eric Seidel  <eric@webkit.org>
2048
2049         Speculative build fix for Tiger.
2050
2051         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
2052
2053 2007-11-21  Eric Seidel  <eric@webkit.org>
2054
2055         Reviewed by Tim Hatcher.
2056
2057         Break out more of DumpRenderTree.mm into individual files
2058
2059         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2060         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
2061         (checkedMalloc):
2062         (checkedRealloc):
2063         (makeLargeMallocFailSilently):
2064         * DumpRenderTree/mac/CheckedMalloc.h: Added.
2065         * DumpRenderTree/mac/DumpRenderTree.mm:
2066         (crashHandler):
2067         (dump):
2068         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2069         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2070         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2071         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2072         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2073         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
2074         (javaScriptThreads):
2075         (runJavaScriptThread):
2076         (startJavaScriptThreads):
2077         (stopJavaScriptThreads):
2078         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
2079         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
2080         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
2081         (restoreColorSpace):
2082         (setDefaultColorProfileToRGB):
2083         (initializeColorSpaceAndScreeBufferForPixelTests):
2084         (md5HashStringForBitmap):
2085         (dumpWebViewAsPixelsAndCompareWithExpected):
2086
2087 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
2088
2089         Move install-unix-extras to wx directory as it seems only to be used by that
2090         port now. It now supports universal binaries on Mac and adds libpng and libjpeg.
2091         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
2092         have install-unix-extras install into WebKitLibraries as per
2093         convention.
2094
2095         Reviewed by Mark Rowe.
2096
2097         * Scripts/install-unix-extras: Removed.
2098         * wx/build-wxwebkit:
2099         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
2100
2101 2007-11-21  Eric Seidel  <eric@webkit.org>
2102
2103         Reviewed by Adam.
2104
2105         More refactoring for greater code readability
2106
2107         * DumpRenderTree/mac/DumpRenderTree.mm:
2108         (initializeGlobalsFromCommandLineOptions):
2109         (initializeColorSpaceAndScreeBufferForPixelTests):
2110         (addTestPluginsToPluginSearchPath):
2111         (useLongRunningServerMode):
2112         (runTestingServerLoop):
2113         (prepareConsistentTestingEnvironment):
2114         (dumpRenderTree):
2115         (main):
2116         (dumpFramesAsText):
2117         (dumpBackForwardListForWebView):
2118         (sizeWebViewForCurrentTest):
2119         (methodNameStringForFailedTest):
2120         (dumpBackForwardListForAllWindows):
2121         (dumpWebViewAsPixelsAndCompareWithExpected):
2122         (invalidateAnyPreviousWaitToDumpWatchdog):
2123         (dump):
2124         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2125         * DumpRenderTree/mac/UIDelegate.mm:
2126         (-[UIDelegate webView:createWebViewWithRequest:]):
2127
2128 2007-11-21  Eric Seidel  <eric@webkit.org>
2129
2130         Reviewed by Tim Hatcher.
2131
2132         Abstract more of DRT into static methods
2133
2134         * DumpRenderTree/mac/DumpRenderTree.mm:
2135         (setDefaultsToConsistentValuesForTesting):
2136         (setupSignalHandlers):
2137         (allocateGlobalControllers):
2138         (releaseAndZero):
2139         (releaseGlobalControllers):
2140         (dumpRenderTree):
2141         (shouldLogFrameLoadDelegates):
2142         (createCFURLFromPathOrURL):
2143         (resetWebViewToConsistentStateBeforeTesting):
2144         (runTest):
2145
2146 2007-11-21  Eric Seidel  <eric@webkit.org>
2147
2148         Reviewed by Tim Hatcher.
2149
2150         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
2151
2152         * DumpRenderTree/DumpRenderTree.h:
2153         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2154         * DumpRenderTree/mac/DumpRenderTree.mm:
2155         (dumpRenderTree):
2156         (dump):
2157         (runTest):
2158         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
2159         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
2160         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
2161         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
2162         (-[DumpRenderTreePasteboard declareType:owner:]):
2163         (+[LocalPasteboard alloc]):
2164         (-[LocalPasteboard init]):
2165         (-[LocalPasteboard dealloc]):
2166         (-[LocalPasteboard name]):
2167         (-[LocalPasteboard releaseGlobally]):
2168         (-[LocalPasteboard declareTypes:owner:]):
2169         (-[LocalPasteboard addTypes:owner:]):
2170         (-[LocalPasteboard changeCount]):
2171         (-[LocalPasteboard types]):
2172         (-[LocalPasteboard availableTypeFromArray:]):
2173         (-[LocalPasteboard setData:forType:]):
2174         (-[LocalPasteboard dataForType:]):
2175         (-[LocalPasteboard setPropertyList:forType:]):
2176         (-[LocalPasteboard setString:forType:]):
2177         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
2178         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
2179         (+[DumpRenderTreeWindow allWindows]):
2180         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2181         (-[DumpRenderTreeWindow dealloc]):
2182         (-[DumpRenderTreeWindow isKeyWindow]):
2183         (-[DumpRenderTreeWindow keyDown:]):
2184
2185 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
2186
2187         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
2188         it indiscriminately copies any headers inside JavaScriptCore,
2189         which includes Tiger ICU headers.
2190
2191         * wx/build-wxwebkit:
2192         Don't run WebCore/move-js-headers.sh any longer.
2193
2194 2007-11-20  Adam Treat  <treat@kde.org>
2195
2196         Reviewed by David Kilzer.
2197
2198         * Prepend git branch name to $baseProductDir
2199
2200         * Scripts/VCSUtils.pm:
2201         * Scripts/webkitdirs.pm:
2202
2203 2007-11-20  Mark Rowe  <mrowe@apple.com>
2204
2205         Reviewed by Simon Hausmann.
2206
2207         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
2208         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
2209         Have it trigger a "make distclean" rather than "make clean" to ensure that the
2210         built product and generated Makefile's are removed.
2211
2212 2007-11-19  Alp Toker  <alp@atoker.com>
2213
2214         Reviewed by Mark Rowe.
2215
2216         http://bugs.webkit.org/show_bug.cgi?id=16040
2217         [GTK] GtkLauncher should be written in C
2218
2219         Port GtkLauncher to plain C.
2220
2221         Use a more conventional GTK+ coding style.
2222
2223         Use a toolbar instead of menus.
2224
2225         Various signature fixes and cleanups.
2226
2227         Add a license header. Assume all previous modifications were copyright
2228         assigned to Apple Inc. by default.
2229
2230         * GtkLauncher/GtkLauncher.pro:
2231         * GtkLauncher/main.c: Added.
2232         (activate_url_entry_cb):
2233         (update_title):
2234         (link_hover_cb):
2235         (title_change_cb):
2236         (progress_change_cb):
2237         (destroy_cb):
2238         (go_back_cb):
2239         (go_forward_cb):
2240         (create_browser):
2241         (create_statusbar):
2242         (create_toolbar):
2243         (create_window):
2244         (main):
2245         * GtkLauncher/main.cpp: Removed.
2246
2247 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
2248
2249         Build script fixes to ensure they do the right thing for the
2250         wx port, and update build-wxwebkit to reflect the way the
2251         build scripts now work.
2252
2253         Reviewed by Adam.
2254
2255         * Scripts/build-testkjs:
2256         * Scripts/build-webkit:
2257         * Scripts/run-javascriptcore-tests:
2258         * Scripts/webkitdirs.pm:
2259         * wx/build-wxwebkit:
2260
2261 2007-11-18  Eric Seidel  <eric@webkit.org>
2262
2263         Reviewed by Anders.
2264
2265         Make run-javascriptcore-tests report failures on exit (to support git bisect)
2266
2267         * Scripts/run-javascriptcore-tests:
2268
2269 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
2270
2271         Reviewed by Adam Roben.
2272
2273         Make run-webkit-tests work with Windows debug build.
2274
2275         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
2276         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
2277         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
2278         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
2279         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
2280
2281 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
2282
2283         Add wxWebKit sample and build script, and integrate it with
2284         build-webkit. Also make build-webkit --clean work for all
2285         ports.
2286
2287         Reviewed by Darin Adler.
2288
2289         * Scripts/build-webkit:
2290         * Scripts/webkitdirs.pm:
2291         * wx: Added.
2292         * wx/browser: Added.
2293         * wx/browser/browser.bkl: Added.
2294         * wx/browser/browser.cpp: Added.
2295         * wx/build-wxwebkit: Added.
2296
2297 2007-11-17  Adam Roben  <aroben@apple.com>
2298
2299         Make it easy to run Safari in the debugger on Windows
2300
2301         I've added a new script, debug-safari, which launches Safari in the
2302         debugger. On OS X it just calls gdb-safari.
2303
2304         Reviewed by Mark Rowe.
2305
2306         * FindSafari/FindSafari.cpp:
2307         (_tmain): Added a /debugger flag, which in combination with
2308         /printSafariLauncher will print a script that launches Safari in the
2309         debugger.
2310         * Scripts/debug-safari: Added.
2311         * Scripts/run-safari: Changed to call runSafari().
2312         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
2313         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
2314         first argument along to FindSafari.
2315         * Scripts/webkitdirs.pm:
2316         (sub runSafari): Added.
2317
2318 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
2319
2320         Reviewed by Adam Roben.
2321
2322         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined.
2323
2324 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
2325
2326         Reviewed by David Kilzer.
2327
2328         The git config command was renamed to repo-config at some point. This
2329         change tries git config and then git repo-config if the first fails.
2330
2331         * Scripts/prepare-ChangeLog:
2332         (gitConfig):
2333
2334 2007-11-16  Dan Bernstein  <mitz@apple.com>
2335
2336         Reviewed by Darin Adler and Sam Weinig.
2337
2338         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
2339
2340         * DumpRenderTree/win/EventSender.cpp:
2341         (keyDownCallback): For characters that cannot be entered on the active
2342         keyboard layout, send a WM_CHAR message with the character along with
2343         a WM_KEYDOWN message with a virtual key code of 255.
2344
2345 2007-11-16  Mark Rowe  <mrowe@apple.com>
2346
2347         Reviewed by Tim Hatcher.
2348
2349         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
2350
2351         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2352         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2353
2354 2007-11-15  Adam Roben  <aroben@apple.com>
2355
2356         Make run-safari actually work on Windows
2357
2358         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
2359         chdir call.
2360
2361 2007-11-14  Adam Roben  <aroben@apple.com>
2362
2363         Updates to Safari launching now that 3.0.4 is released
2364
2365         Reviewed by Sam.
2366
2367         * FindSafari/FindSafari.cpp:
2368         (getWebViewCLSID): Use version-independent ProgID.
2369         * Scripts/run-safari: Use run-webkit-nightly.cmd.
2370
2371 2007-11-14  Anders Carlsson  <andersca@apple.com>
2372
2373         Reviewed by Adam.
2374
2375         <rdar://problem/5309081>
2376         In DRT, "plugin.logDestroy = true" not working on Windows.
2377
2378         * DumpRenderTree/win/TestNetscapePlugin/main.c:
2379         (NPP_Destroy):
2380
2381 2007-11-14  Eric Seidel  <eric@webkit.org>
2382
2383         Reviewed by Sam.
2384
2385         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
2386
2387 2007-11-14  Anders Carlsson  <andersca@apple.com>
2388
2389         Reviewed by Adam.
2390
2391         <rdar://problem/5141186>
2392         window.layoutTestController.setWindowIsKey is not implemented in DRT.
2393
2394         Implement setWindowIsKey.
2395
2396         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2397         (LayoutTestController::setWindowIsKey):
2398
2399 2007-11-13  Sam Weinig  <sam@webkit.org>
2400
2401         Reviewed by Adam Roben.
2402
2403         Fix for <rdar://problem/5382579>
2404         http/tests/security/cross-frame-access-put.html reports large
2405         negative numbers for screenLeft and screenTop (Mac reports "0")
2406
2407         * DumpRenderTree/win/UIDelegate.cpp:
2408         (UIDelegate::UIDelegate): Initialize the RECT.
2409         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
2410         (UIDelegate::webViewFrame): ditto.
2411         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
2412
2413 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
2414
2415         Reviewed by Adam.
2416
2417         - Make Drosera show source, source URLs, and function stack on Windows,
2418         and some minor fixes.
2419
2420         * Drosera/DebuggerDocument.cpp: Force source to always update display.
2421         (DebuggerDocument::updateFileSource):
2422         * Drosera/debugger.js: Force source to always update display.
2423         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
2424         menu controls.
2425         (DebuggerClient::resume):
2426         (DebuggerClient::pause):
2427         (DebuggerClient::stepInto):
2428         (DebuggerClient::stepOver):
2429         (DebuggerClient::stepOut):
2430         (DebuggerClient::showConsole):
2431         (DebuggerClient::closeCurrentFile):
2432         * Drosera/win/DebuggerClient.h: Ditto.
2433         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
2434         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
2435         removed two bugs.  1) caller could be in a bad state when asked to
2436         assign into it. 2) BSTRs were not created correctly.
2437         (DebuggerDocument::getPlatformCurrentFunctionStack):
2438         * Drosera/win/Drosera.cpp: Hook up the menu controls.
2439         (droseraWndProc):
2440         (handleCommand):
2441         (Drosera::resume):
2442         (Drosera::pause):
2443         (Drosera::stepInto):
2444         (Drosera::stepOver):
2445         (Drosera::stepOut):
2446         (Drosera::showConsole):
2447         (Drosera::closeCurrentFile):
2448         * Drosera/win/Drosera.h: Hook up the menu controls.
2449         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
2450         functions, added a null check, and fixed another bug where caller could
2451         be in a bad state when asked to assign into it.
2452         (ServerConnection::didLoadMainResourceForDataSource):
2453         (ServerConnection::getCallerFrame):
2454         * Drosera/win/ServerConnection.h: Safety first.
2455
2456 2007-11-13  Dan Bernstein  <mitz@apple.com>
2457
2458         Reviewed by Darin Adler.
2459
2460         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
2461           DumpRenderTree --pixel-tests renders each test twice
2462
2463         * DumpRenderTree/mac/DumpRenderTree.mm:
2464         (dumpRenderTree): Removed the --paint option because the painting code
2465         is always exercised as a result of
2466         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
2467         calling -displayIfNeeded.
2468         (dump): Changed to always grab the image from the window since the view
2469         is always displayed.
2470         (runTest):
2471         (displayWebView):
2472         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
2473         because it always paints.
2474
2475 2007-11-12  Antti Koivisto  <antti@apple.com>
2476
2477         Reviewed by Adele.
2478
2479         Add support for http media tests
2480
2481         * Scripts/run-webkit-tests:
2482
2483 2007-11-12  Sam Weinig  <sam@webkit.org>
2484
2485         Reviewed by Adam Roben.
2486
2487         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
2488
2489         * DumpRenderTree/win/DumpRenderTree.cpp:
2490         (runTest):
2491         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2492         (LayoutTestController::setPrivateBrowsingEnabled):
2493
2494 2007-11-12  Adam Roben  <aroben@apple.com>
2495
2496         * Scripts/update-webkit-localizable-strings: Changed to only scan the
2497         mac and win subdirectories.
2498
2499 2007-11-11  Adam Roben  <aroben@apple.com>
2500
2501         Fix <rdar://5133816> keepWebHistory is not implemented
2502
2503         Fixes fast/history/clicked-link-is-visited.html.
2504
2505         Reviewed by Darin.
2506
2507         * DumpRenderTree/win/DumpRenderTree.cpp:
2508         (runTest): Clear the optionalSharedHistory.
2509         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2510         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
2511
2512 2007-11-10  Sam Weinig  <sam@webkit.org>
2513
2514         Reviewed by Tim Hatcher.
2515
2516         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript
2517         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions
2518         is turned on)
2519
2520         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
2521
2522         Added test: http/tests/security/cross-frame-access-private-browsing.html
2523
2524         * DumpRenderTree/LayoutTestController.cpp:
2525         (setPrivateBrowsingEnabledCallback):
2526         (LayoutTestController::staticFunctions):
2527         * DumpRenderTree/LayoutTestController.h:
2528         * DumpRenderTree/mac/DumpRenderTree.mm:
2529         (runTest): Default to private browsing disabled.
2530         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2531         (LayoutTestController::setPrivateBrowsingEnabled):
2532         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2533         (LayoutTestController::setPrivateBrowsingEnabled):
2534
2535 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2536
2537         Reviewed by Adam.
2538
2539         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
2540         WebCore's!
2541
2542         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2543         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
2544         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2545         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2546         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
2547         * Drosera/win/Drosera.cpp:
2548         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2549
2550 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2551
2552         Reviewed by Sam.
2553
2554         - Use the new IWebFrame [local] function signature and get the shared
2555         server correctly.
2556
2557         * Drosera/win/DebuggerClient.cpp:
2558         (DebuggerClient::didFinishLoadForFrame):
2559         * Drosera/win/ServerConnection.cpp:
2560         (ServerConnection::attemptToCreateServerConnection):
2561
2562 2007-11-07  Dan Bernstein  <mitz@apple.com>
2563
2564         Reviewed by Darin Adler.
2565
2566         - add an option to run-webkit-tests to ignore pixel test failures where
2567           all pixels differ by no more than a specified threshold
2568
2569         * DumpRenderTree/mac/ImageDiff.m:
2570         (main):
2571         (compareImages):
2572         (computePercentageDifferent):
2573         * Scripts/run-webkit-tests:
2574
2575 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2576
2577         Reviewed by Lars.
2578
2579         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
2580
2581         * DumpRenderTree/qt/DumpRenderTree.cpp:
2582
2583 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2584
2585         Reviewed by Lars.
2586
2587         Reworked the QWebSettings API.
2588         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
2589
2590         * DumpRenderTree/qt/DumpRenderTree.cpp:
2591
2592 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2593
2594         Reviewed by Lars.
2595
2596         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
2597
2598         * DumpRenderTree/qt/jsobjects.cpp:
2599
2600 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2601
2602         Reviewed by Lars Knoll <lars@trolltech.com>.
2603
2604         Add a QWebPage::frameCreated() signal and fix DRT
2605
2606         The removal of createFrame in QWebPage broke the re-implementation
2607         in DumpRenderTree. Instead emit a frameCreated() signal and
2608         connect to it in DumpRenderTree.
2609
2610
2611         * DumpRenderTree/qt/DumpRenderTree.cpp:
2612         (WebCore::WebPage::WebPage):
2613         (WebCore::DumpRenderTree::dump):
2614         (WebCore::DumpRenderTree::connectFrame):
2615         * DumpRenderTree/qt/DumpRenderTree.h:
2616
2617 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2618
2619         Reviewed by Lars Knoll <lars@trolltech.com>.
2620
2621         Moved all the event handlers from QWebFrame into QWebPage.
2622
2623         This cleans up the public API and allows us to remove the
2624         HackWebFrame hack in DumpRenderTree.
2625
2626
2627         * DumpRenderTree/qt/jsobjects.cpp:
2628         (EventSender::mouseDown):
2629         (EventSender::mouseUp):
2630         (EventSender::mouseMoveTo):
2631
2632 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2633
2634         Reviewed by Mark.
2635
2636         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
2637         to prevent the default implementation from popping up messageboxes.
2638
2639         * DumpRenderTree/qt/DumpRenderTree.cpp:
2640         (WebCore::WebPage::javaScriptConfirm):
2641         (WebCore::WebPage::javaScriptPrompt):
2642
2643 2007-11-06  Eric Seidel  <eric@webkit.org>
2644
2645         * Scripts/build-testkjs: build fix... too many $$
2646
2647 2007-11-06  Eric Seidel  <eric@webkit.org>
2648
2649         Reviewed by Mark Rowe.
2650
2651         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
2652
2653 2007-11-05  Adam Roben  <aroben@apple.com>
2654
2655         Add support on Windows for WEBKIT_TESTFONTS
2656
2657         This environment variable lets you specify where the fonts to be used
2658         by DumpRenderTree reside. The Qt port is already using this, so I'm
2659         just following their lead.
2660
2661         Reviewed by Darin.
2662
2663         * DumpRenderTree/win/DumpRenderTree.cpp:
2664         (exePath): Refactored code out of initialize().
2665         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2666         DumpRenderTree.resources.
2667         (initialize): Use the new fontsPath function.
2668         (main): Use the new exePath function.
2669         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2670         variable to DRT, like Qt does.
2671
2672 2007-11-05  Mark Rowe  <mrowe@apple.com>
2673
2674         Rubber-stamped by Alp Toker.
2675
2676         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2677
2678         * GtkLauncher/main.cpp:
2679         (goToURLBarText):
2680         (main):
2681
2682 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2683
2684         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2685         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2686
2687         Reviewed by Timothy.
2688
2689         Restrict the range of nightly builds used by the bisect-builds script
2690         based on the version of Safari and the version of Mac OS X being used.
2691
2692         Mac OS X 10.4: Safari 2.0: r11976 or newer
2693         Mac OS X 10.4: Safari 3.0: r19992 or newer
2694
2695         Mac OS X 10.5: Safari 2.0: r19594 or newer
2696         Mac OS X 10.5: Safari 3.0: r25124 or newer
2697
2698         * Scripts/bisect-builds:
2699         (findMacOSXVersion): Added.
2700         (makeNightlyList): Added argument to provide version of Mac OS X.
2701         Restrict range of nightly builds based on Safari and Mac OS X versions.
2702
2703 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2704
2705         Reviewed by Maciej.
2706
2707         - This patch involves several changes, all of them were noticed that
2708         they were needed by the work being done in WebKit to get Drosera and
2709         WebKit working together on Windows.
2710         - The changes are:
2711         1) Added a debugger console for output messages.
2712         2) Drosera now listens for the WebKit server (before, the server would
2713         have to be running before Drosera was started.)
2714         3) Fixed a bug where the WebView started out as 0x0 pixels.
2715         4) Fixed a bug when there is no scope.
2716         5) Added the HTML, JS, and CSS to the project file to make them easy to
2717         find.
2718         6) Made the ServerConnection functions virtual.
2719
2720         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2721         for the WebKit server.
2722         (DebuggerClient::DebuggerClient):
2723         (DebuggerClient::~DebuggerClient):
2724         (DebuggerClient::didFinishLoadForFrame):
2725         (DebuggerClient::serverConnected):
2726         (DebuggerClient::attemptToCreateServerConnection):
2727         * Drosera/win/DebuggerClient.h: Ditto.
2728         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2729         scope.
2730         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2731         (DebuggerDocument::platformValueForScopeVariableNamed):
2732         * Drosera/win/Drosera.cpp:
2733         (_tWinMain): Added a console in debug for output messages.
2734         (Drosera::Drosera): Listen for server.
2735         (Drosera::initUI): The server now Initializes COM.
2736         (Drosera::serverConnected): Part of the listening for the server.
2737         (Drosera::attemptToCreateServerConnection): Ditto.
2738         * Drosera/win/Drosera.h: New interface for listening for the server.
2739         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2740         files to the VS project.
2741         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2742         connection.
2743         (ServerConnection::ServerConnection):
2744         (ServerConnection::attemptToCreateServerConnection):
2745         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2746         methods.
2747         (ServerConnection::serverConnected):
2748
2749 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2750
2751         Reviewed by Maciej.
2752
2753         http://bugs.webkit.org/show_bug.cgi?id=15832
2754         fast/dom/gc-10.html crashes when run alone
2755
2756         Check for !done before using objects that can be already deallocated.
2757
2758         * DumpRenderTree/mac/EditingDelegate.mm:
2759         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2760         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2761         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2762         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2763         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2764         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2765         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2766         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2767         (-[EditingDelegate webViewDidBeginEditing:]):
2768         (-[EditingDelegate webViewDidChange:]):
2769         (-[EditingDelegate webViewDidEndEditing:]):
2770         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2771         (-[EditingDelegate webViewDidChangeSelection:]):
2772         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2773         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2774         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2775         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2776         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2777         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2778         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2779         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2780         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2781         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2782         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2783         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2784         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2785         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2786         (-[FrameLoadDelegate webView:willCloseFrame:]):
2787         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2788         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2789         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2790         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2791         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2792         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2793         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2794         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2795         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2796
2797 2007-11-04  Mark Rowe  <mrowe@apple.com>
2798
2799         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2800         warnings that would otherwise be suppressed due to it being a system header.
2801
2802         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2803
2804 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2805
2806         Rubber stamped by Adam.
2807
2808         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2809
2810         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2811
2812 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2813
2814         Sort files(...); sections of Xcode project files.
2815
2816         Rubber-stamped by Darin.
2817
2818         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2819         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2820         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2821         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2822
2823 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2824
2825         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2826
2827         Reviewed by Darin.
2828
2829         * Scripts/sort-Xcode-project-file: Added.
2830
2831 2007-11-02  Darin Adler  <darin@apple.com>
2832
2833         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2834
2835 2007-11-02  Darin Adler  <darin@apple.com>
2836
2837         Reviewed by Maciej.
2838
2839         * Scripts/run-sunspider: Pass the "--base" option through.
2840
2841         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2842         the real script do that. Default configuration to Release to match run-sunspider
2843         so we don't end up building Debug just to compare results.
2844
2845 2007-11-01  Adam Roben  <aroben@apple.com>
2846
2847         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2848
2849         Reviewed by Sam.
2850
2851         * Scripts/commit-log-editor: Show all the directories beneath the
2852         source root, instead of just the last one.
2853
2854 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2855
2856         Reviewed by Adam Roben.
2857
2858         Print out an error message when the Windows build fails
2859         and provide guidance on how to find out what went wrong.
2860
2861         * Scripts/build-webkit:
2862         * Scripts/webkitdirs.pm:
2863
2864 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2865
2866         Rubber-stamped by Adam Roben.
2867
2868         Rolled out r27326 - debug CRT seems to cause no problems after all.
2869
2870         * DumpRenderTree/win/DumpRenderTree.vcproj:
2871
2872 2007-10-31  Adam Roben  <aroben@apple.com>
2873
2874         Switch the Debug configuration to using the non-debug CRT
2875
2876         This matches WebKit.
2877
2878         Reviewed by Steve.
2879
2880         * DumpRenderTree/win/DumpRenderTree.vcproj:
2881
2882 2007-10-31  Antti Koivisto  <antti@apple.com>
2883
2884         Reviewed by bdash.
2885
2886         Disable media tests when doing leak checking on Tiger.
2887         They crash in QuickTime (rdar://problem/5537157).
2888
2889         * Scripts/run-webkit-tests:
2890
2891 2007-10-29  Antti Koivisto  <antti@apple.com>
2892
2893         Reviewed by Maciej.
2894
2895         Build media support by default on OSX only.
2896
2897         * Scripts/build-webkit:
2898
2899 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2900
2901         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2902         get caught by the pre-commit hooks.
2903
2904 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2905
2906         Reviewed by Adam.
2907
2908         - This is a collection of relatively unrelated changes and cleanups
2909         to Drosera to prepare it for interacting with WebKit.  A lot of these
2910         changes are just correcting mistakes, for example removing included
2911         headers that are no longer needed.
2912
2913         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2914         this will be needed by the DebuggerClient.
2915         (DebuggerDocument::server):
2916         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2917         * Drosera/win/DebuggerClient.cpp:
2918         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2919         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2920         (DebuggerClient::createWebViewWithRequest): Added comment about its
2921         purpose.
2922         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2923         declarations.
2924         (DebuggerClient::webViewLoaded): Moved.
2925         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2926         file, since this was the only place it was used.
2927         (cfStringToBSTR):
2928         * Drosera/win/Drosera.h: Cleaned up the includes.
2929         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2930         * Drosera/win/HelperFunctions.h: Removed.
2931
2932 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2933
2934         Reviewed by Adam.
2935
2936         - Small cleanup in the ServerConnection class.
2937
2938         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2939         and added an include.
2940         (ServerConnection::currentFrame):
2941         (ServerConnection::getCallerFrame):
2942         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2943         made a pointer into a COMPtr, and cleaned up the includes.
2944
2945 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2946
2947         Reviewed by John Sullivan.
2948
2949         - Place the Localizable.strings file in mac or win directories
2950           if that location exists.
2951         - Also look for UI_STRING in .c files.
2952
2953         * Scripts/extract-localizable-strings:
2954
2955 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2956
2957         Reviewed by Adam.
2958
2959         - Set the eol-style to native and made all the line endings the same
2960         so that I avoid messy diffs that show eol changes.
2961
2962         * Drosera/win/ServerConnection.cpp:
2963         (ServerConnection::didParseSource):
2964         (ServerConnection::didEnterCallFrame):
2965         (ServerConnection::willExecuteStatement):
2966         (ServerConnection::willLeaveCallFrame):
2967         (ServerConnection::exceptionWasRaised):
2968
2969 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2970
2971         Reviewed by Adam.
2972
2973         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2974         functionality that could not have existed previously without the new
2975         interfaces.
2976         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2977         from a BSTR to a JSValueRef.
2978         (DebuggerDocument::platformEvaluateScript): Implemented.
2979         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2980         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2981         Implemented.
2982         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2983         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2984         * Drosera/win/ServerConnection.cpp: Added a helper function.
2985         (ServerConnection::getCallerFrame):
2986         * Drosera/win/ServerConnection.h: Added a helper function.
2987
2988 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2989
2990         updated reviewers for my previous changelog.
2991
2992 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2993         Reviewed by Maciej and Adam and Geoff.
2994
2995         - Minor mac-side improvements including moving a function to a more
2996         appropriate location, fixing a warning, and correctly checking
2997         exceptions.
2998
2999         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
3000         (DebuggerDocument::willExecuteStatement):
3001         (DebuggerDocument::didEnterCallFrame):
3002         (DebuggerDocument::willLeaveCallFrame):
3003         (DebuggerDocument::windowScriptObjectAvailable):
3004         (DebuggerDocument::callFunctionOnObject):
3005         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
3006         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
3007         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
3008         because it doesn't require the ServerConnection at all.
3009         (NSStringCreateWithJSStringRef): Made an argument const.
3010         (JSValueRefCreateWithNSString): Made an argument const.
3011         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
3012         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3013         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
3014         * Drosera/mac/ServerConnection.mm: Ditto.
3015         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3016
3017 2007-10-29  Sam Weinig  <sam@webkit.org>
3018
3019         Reviewed by Adam Roben.
3020
3021         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
3022
3023         * DumpRenderTree/LayoutTestController.cpp:
3024         (LayoutTestController::LayoutTestController):
3025         (getGlobalFlagCallback):
3026         (setGlobalFlagCallback):
3027         (LayoutTestController::getJSClass):
3028         (LayoutTestController::staticValues):
3029         * DumpRenderTree/LayoutTestController.h:
3030         (LayoutTestController::globalFlag):
3031         (LayoutTestController::setGlobalFlag):
3032
3033 2007-10-29  Darin Adler  <darin@apple.com>
3034
3035         Reviewed by Maciej.
3036
3037         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
3038         resolution instead of its default.
3039
3040 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
3041
3042         Fixed showStatus() to print status for successfully resolved conflicts when using git.
3043
3044         Reviewed by Mark Rowe.
3045
3046         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
3047         was successfully resolved, but this would not show any status because the change had
3048         already been cached in the index using "git add".  The solution is to add an optional
3049         second argument to showStatus() which adds the "--cached" switch to the command.
3050
3051         * Scripts/resolve-ChangeLogs:
3052         (showStatus):
3053
3054 2007-10-28  Eric Seidel  <eric@webkit.org>
3055
3056         Reviewed by Maciej and Geoff, in unison.
3057
3058         * Scripts/run-webkit-tests: remove broken --svg option
3059
3060 2007-10-28  Darin Adler  <darin@apple.com>
3061
3062         Reviewed by Adam.
3063
3064         * Scripts/run-sunspider: Default to "Release" configuration rather than
3065         defaulting to the last configuration used as other scripts do. This can
3066         still be overriden on the command line with "--debug" if there's some
3067         reason to do so. Also fix a typo.
3068
3069         * Scripts/sunspider-compare-results: Fix a typo.
3070
3071 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
3072
3073         Reviewed by Adam.
3074
3075         - Implemented the WebScriptDebugListener functions now that the
3076         WebScriptDebugServer exists
3077
3078         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
3079         functions.
3080         (ServerConnection::currentFrame):
3081         (ServerConnection::didLoadMainResourceForDataSource):
3082         (ServerConnection::didParseSource):
3083         (ServerConnection::failedToParseSource):
3084         (ServerConnection::didEnterCallFrame):
3085         (ServerConnection::willExecuteStatement):
3086         (ServerConnection::willLeaveCallFrame):
3087         (ServerConnection::exceptionWasRaised):
3088         * Drosera/win/ServerConnection.h: Removed unused arguments from the
3089         members arguments list.
3090
3091 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
3092
3093         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
3094         <http://bugs.webkit.org/show_bug.cgi?id=15600>
3095
3096         Reviewed by Darin.
3097
3098         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
3099         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
3100         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
3101         file.  Note that it may also be used as a stand-alone script.
3102
3103         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
3104         * Scripts/resolve-ChangeLogs: Added.
3105         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
3106
3107 2007-10-26  Mark Rowe  <mrowe@apple.com>
3108
3109         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
3110         to the Qt port on the assumption that it was an implementation of the cross-platform
3111         LayoutTestController class.  It is not, so it did not need to be changed.
3112
3113         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
3114
3115 2007-10-25  Mark Rowe  <mrowe@apple.com>
3116
3117         Reviewed by Maciej.
3118
3119         Fix builds with code coverage enabled.
3120
3121         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
3122
3123 2007-10-25  Darin Adler  <darin@apple.com>
3124
3125         Reviewed by Mark Rowe.
3126
3127         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
3128         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
3129
3130 2007-10-25  Stephanie  <slewis@apple.com>
3131
3132         build Fix
3133
3134         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3135
3136 2007-10-25  Stephanie  <slewis@apple.com>
3137
3138         Reviewed by Mark Rowe, Adam Roben.
3139
3140         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
3141
3142         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3143
3144 2007-10-25  Alice Liu  <alice.liu@apple.com>
3145
3146         Reviewed by Adam.
3147
3148         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
3149
3150         Moving destructor into platform-specific files
3151         * DumpRenderTree/LayoutTestController.cpp:
3152         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3153         (LayoutTestController::~LayoutTestController):
3154         * DumpRenderTree/qt/jsobjects.cpp:
3155         (LayoutTestController::~LayoutTestController):
3156
3157         LayoutTestController wasn't being destroyed
3158         * DumpRenderTree/win/DumpRenderTree.cpp:
3159         (runTest):
3160
3161         Added declspec
3162         * DumpRenderTree/win/EditingDelegate.h:
3163
3164         Reset certain values on the webview (or related delegate) that might
3165         have changed while running a test
3166         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3167         (LayoutTestController::~LayoutTestController):
3168
3169 2007-10-25  Adam Roben  <aroben@apple.com>
3170
3171         Make sunspider-compare-results work with relative paths
3172
3173         Reviewed by Sam.
3174
3175         * Scripts/sunspider-compare-results: Convert arguments to absolute
3176         paths before we chdir.
3177
3178 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
3179
3180         Reviewed by Sam.
3181
3182         - Implemented server calls now the WebScriptDebugServer exists.
3183         - Also removed no longer needed call to initialize CG.
3184
3185         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
3186         automatically now.
3187         (_tWinMain):
3188         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
3189         (ServerConnection::ServerConnection):
3190         (ServerConnection::~ServerConnection):
3191         (ServerConnection::pause):
3192         (ServerConnection::resume):
3193         (ServerConnection::stepInto):
3194         (ServerConnection::applicationTerminating):
3195         (ServerConnection::serverConnectionDidDie):
3196         * Drosera/win/ServerConnection.h: Now uses the COM class.
3197
3198 2007-10-24  George Staikos  <staikos@kde.org>
3199
3200         Unbreak Qt build.
3201
3202         * Scripts/build-webkit:
3203
3204 2007-10-24  Adam Roben  <aroben@apple.com>
3205
3206         Remove now-unnecessary call to InitializeCoreGraphics
3207
3208         WebKit takes care of this now.
3209
3210         Reviewed by Ada.
3211
3212         * DumpRenderTree/win/DumpRenderTree.cpp:
3213         (initialize):
3214
3215 2007-10-24  Adam Roben  <aroben@apple.com>
3216
3217         Use WebTextRenderer in DRT
3218
3219         Reviewed by Ada.
3220
3221         * DumpRenderTree/win/DumpRenderTree.cpp:
3222         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
3223
3224 2007-10-24  Sven Herzberg  <sven@imendio.com>
3225
3226         Reviewed by Mark Rowe.
3227
3228         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
3229         Bug 15614: [GTK] qmake based backends don't build on OS X
3230
3231         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
3232         GTK backend on a Mac
3233         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
3234         isDarwin() to make it reusable in other places (like the workaround-
3235         for-prebuilt-qmake in build-webkit)
3236
3237 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3238
3239         Refurbish update-webkit script.
3240
3241         Reviewed by Adam.
3242
3243         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
3244         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
3245         multi-argument version of system() for flexibility and security.  Check for existence
3246         of Internal directory using -d test instead of -x.
3247
3248 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
3249
3250         Minor clean-up of prepare-ChangeLog script.
3251
3252         Reviewed by Adam.
3253
3254         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
3255         of a string.  Use multi-argument versions of open() and system() for flexibility and
3256         security.
3257
3258 2007-10-24  Alice Liu  <alice.liu@apple.com>
3259
3260         Reviewed by Oliver.
3261
3262         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
3263
3264         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
3265         replay the saved events when we're still processing the mousedown that starts the drag
3266         * DumpRenderTree/win/EventSender.cpp:
3267         (doMouseMove):
3268         * DumpRenderTree/win/UIDelegate.cpp:
3269         (UIDelegate::doDragDrop):
3270
3271 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
3272
3273         Reviewed by Sam, Steve and Darin.
3274
3275         - Stubbed out the WebScriptDebugListener functionality in the Server
3276         Connection class to prepare it for receiving those callbacks.
3277         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
3278         and the ServerConnection to not need to be initialized with a server
3279         name, since that is not the way we connect to the WebKit server.
3280
3281         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
3282         no exception.  Now it only loggs when there is an exception
3283         (DebuggerDocument::willExecuteStatement):
3284         (DebuggerDocument::didEnterCallFrame):
3285         (DebuggerDocument::willLeaveCallFrame):
3286         (DebuggerDocument::windowScriptObjectAvailable):
3287         (DebuggerDocument::callFunctionOnObject):
3288         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
3289         to be instantiated with a server's name.
3290         (DebuggerClient::DebuggerClient):
3291         (DebuggerClient::didFinishLoadForFrame):
3292         * Drosera/win/DebuggerClient.h: Removed unsued variable.
3293         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
3294         a server name.
3295         (Drosera::init):
3296         (Drosera::initServer):
3297         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
3298         instantiated with a server's name.
3299         * Drosera/win/ServerConnection.cpp:
3300         (ServerConnection::ServerConnection): No longer needs a server name
3301         (ServerConnection::~ServerConnection): Only release the global context
3302         if there is one.
3303         (ServerConnection::serverConnectionDidDie): Stub for
3304         IWebScriptDebugListener
3305         (ServerConnection::QueryInterface): ditto
3306         (ServerConnection::AddRef): ditto
3307         (ServerConnection::Release): ditto
3308         (ServerConnection::didLoadMainResourceForDataSource): ditto
3309         (ServerConnection::didParseSource): ditto
3310         (ServerConnection::failedToParseSource): ditto
3311         (ServerConnection::didEnterCallFrame): ditto
3312         (ServerConnection::willExecuteStatement): ditto
3313         (ServerConnection::willLeaveCallFrame): ditto
3314         (ServerConnection::exceptionWasRaised): ditto
3315         * Drosera/win/ServerConnection.h: Stubbed out the
3316         IWebScriptDebugListener functions, and this class no longer needs to be
3317         instantiated with a server name.
3318
3319 2007-10-24  Lars Knoll  <lars@trolltech.com>
3320
3321         Reviewed by Simon.
3322
3323         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
3324
3325         * DumpRenderTree/qt/jsobjects.h:
3326
3327 2007-10-24  Lars Knoll  <lars@trolltech.com>
3328
3329         Reviewed by Simon.
3330
3331         add another command.
3332
3333         * DumpRenderTree/qt/jsobjects.cpp:
3334         (TextInputController::doCommand):
3335
3336 2007-10-24  Lars Knoll  <lars@trolltech.com>
3337
3338         Reviewed by Simon.
3339
3340         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
3341
3342         * DumpRenderTree/qt/jsobjects.cpp:
3343         (EventSender::keyDown):
3344         * DumpRenderTree/qt/jsobjects.h:
3345
3346 2007-10-24  Lars Knoll  <lars@trolltech.com>
3347
3348         Reviewed by Simon.
3349
3350         implement eventSender.keyDown().
3351
3352         * DumpRenderTree/qt/jsobjects.cpp:
3353         (EventSender::keyDown):
3354
3355 2007-10-24  Lars Knoll  <lars@trolltech.com>
3356
3357         Reviewed by Simon.
3358
3359         some smaller fixes to the editing support in DRT. Makes another few tests pass.
3360
3361         * DumpRenderTree/qt/DumpRenderTree.cpp:
3362         (WebCore::DumpRenderTree::DumpRenderTree):
3363         (WebCore::DumpRenderTree::initJSObjects):
3364         * DumpRenderTree/qt/jsobjects.cpp:
3365         (TextInputController::doCommand):
3366
3367 2007-10-24  Lars Knoll  <lars@trolltech.com>
3368
3369         Reviewed by Simon.
3370
3371         first bit of implementation for the textinputcontroller.
3372
3373         * DumpRenderTree/qt/DumpRenderTree.cpp:
3374         (WebCore::DumpRenderTree::DumpRenderTree):
3375         * DumpRenderTree/qt/DumpRenderTree.h:
3376         * DumpRenderTree/qt/jsobjects.cpp:
3377         (TextInputController::TextInputController):
3378         (TextInputController::doCommand):
3379         * DumpRenderTree/qt/jsobjects.h:
3380
3381 2007-10-24  Lars Knoll  <lars@trolltech.com>
3382
3383         Reviewed by Simon.
3384
3385         make the man webpage believe it has focus, so the editing tests work correctly.
3386
3387         * DumpRenderTree/qt/DumpRenderTree.cpp:
3388         (WebCore::DumpRenderTree::DumpRenderTree):
3389
3390 2007-10-24  Lars Knoll  <lars@trolltech.com>
3391
3392         Reviewed by Simon.
3393
3394         implement layoutTestController.dumpEditingCallbacks() correctly.
3395
3396         * DumpRenderTree/qt/DumpRenderTree.cpp:
3397         (WebCore::DumpRenderTree::DumpRenderTree):
3398         * DumpRenderTree/qt/jsobjects.cpp:
3399         (LayoutTestController::reset):
3400         (LayoutTestController::dumpEditingCallbacks):
3401
3402 2007-10-24  Lars Knoll  <lars@trolltech.com>
3403
3404         Reviewed by Simon.
3405
3406         Implement support for testing editing.
3407
3408         * DumpRenderTree/qt/DumpRenderTree.cpp:
3409         (WebCore::DumpRenderTree::DumpRenderTree):
3410
3411 2007-10-23  Sam Weinig  <sam@webkit.org>
3412
3413         Check for null BSTR that can be passed to the UIDelegate methods
3414         from javascript null and undefined.  Fixes a failing test case on
3415         Windows (fast/dom/Window/alert-undefined.html)
3416
3417         Reviewed by Eric Seidel.
3418
3419         * DumpRenderTree/win/UIDelegate.cpp:
3420         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3421         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3422         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3423         (UIDelegate::webViewAddMessageToConsole):
3424
3425 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3426
3427         Reviewed by Darin.
3428
3429         Don't print a massive pile of setenvs from tools that automatically build testkjs.
3430
3431         * Scripts/build-testkjs:
3432
3433 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3434
3435         Reviewed by Darin.
3436
3437         - add wrapper that finds the right copy of testkjs
3438
3439         * Scripts/sunspider-compare-results: Added.
3440
3441 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
3442
3443         Reviewed by Sam.
3444
3445         - After talking with Steve I now see that the WebKit server must be
3446         running for DCOM to create the distributed objects, which makes sense
3447         and currently WebKit only allows one instance to be running at a time
3448         which avoids accidentally connecting to the wrong server
3449         - In light of this I have removed the code for the attach box and
3450         NotificationServer and known server names, since they are all extranious
3451         now.
3452
3453         * Drosera/win/Drosera.cpp: Removed notification classes and known server
3454         names.
3455         (_tWinMain): Uses init instead of initUI.
3456         (droseraWndProc): No longer creats an attach dialog box.
3457         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
3458         it's not manditory to call init before doing COM stuff.
3459         (Drosera::init): calls initUI and will call attach when the
3460         functionality exists.
3461         (Drosera::initUI): Has changed very little.
3462         (Drosera::attach): Changed the signature to reflect that we no longer
3463         need the dictionary of known server names.
3464         * Drosera/win/Drosera.h: Removed notification classes and known server
3465         names.  Also renamed and moved some functions.
3466         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
3467         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
3468         headers to the resources folder.
3469         * Drosera/win/resource.h: Removed the Attach box.
3470
3471 2007-10-22  Adam Roben  <aroben@apple.com>
3472
3473         Windows build fix
3474
3475         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
3476
3477 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
3478
3479         - Removed a leak that was fixed.
3480
3481         * Scripts/run-webkit-tests:
3482
3483 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3484
3485         Reviewed by Darin.
3486
3487         - Changed the Client so that the DebuggerDocument now own the
3488         ServerConnection.  This simplifies ownership and cleanup.
3489
3490         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
3491         ServerConnection.
3492         (DebuggerClient::initWithServerName):
3493         (DebuggerClient::didFinishLoadForFrame):
3494         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the
3495         ServerConnection.
3496         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
3497         until after we have a server which we are attached to.
3498         (Drosera::initUI):
3499         (Drosera::attach):
3500         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
3501         out previously.
3502
3503 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3504
3505         Reviewed by Nikolas.
3506
3507         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
3508
3509         * Scripts/run-javascriptcore-tests:
3510
3511 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3512
3513         Reviewed by Nikolas.
3514
3515         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
3516
3517         * Scripts/build-drosera:
3518         * Scripts/build-dumprendertree:
3519         * Scripts/build-testkjs:
3520         * Scripts/build-webkit:
3521         * Scripts/run-javascriptcore-tests:
3522         * Scripts/run-sunspider:
3523         * Scripts/run-webkit-tests:
3524         * Scripts/webkitdirs.pm:
3525
3526 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
3527
3528         Reviewed by Mark Rowe.
3529
3530         Fix for local database support after r26879
3531         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
3532
3533         * Scripts/build-webkit:
3534
3535 2007-10-22  Holger Freyther  <zecke@selfish.org>
3536
3537         Reviewed by Simon Hausmann <hausmann@kde.org>.
3538
3539         - Do not build testkjs as an application bundle. This is
3540         needed for run-javascriptcore-tests on OSX.
3541         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
3542         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
3543         as we do not have -rpath on OSX.
3544
3545         * DumpRenderTree/qt/DumpRenderTree.pro:
3546         * Scripts/run-webkit-tests:
3547
3548 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3549
3550         Reviewed by aroben.
3551
3552         Fix support for Signed-off-by detection in prepare-ChangeLog
3553         --git-commit. The Signed-off-by tag does not appear in the header
3554         but usually at the end.
3555
3556         * Scripts/prepare-ChangeLog:
3557
3558 2007-10-21  Mark Rowe  <mrowe@apple.com>
3559
3560         Reviewed by Eric.
3561
3562         Fix run-javascriptcore-tests for Gtk.
3563
3564         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
3565
3566 2007-10-20  Eric Seidel  <eric@webkit.org>
3567
3568         Reviewed by aroben.
3569
3570         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
3571
3572 2007-10-20  Eric Seidel  <eric@webkit.org>
3573
3574         Reviewed by darin.
3575
3576         Add improved argument handling to run-sunspider, including
3577         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
3578         Also re-factor code into subroutines
3579
3580         * Scripts/build-dumprendertree: removed bogus comments
3581         * Scripts/build-testkjs: Added.
3582         * Scripts/run-javascriptcore-tests: use build-testkjs
3583         * Scripts/run-sunspider: improved argument handling, abstraction
3584         * Scripts/run-webkit-tests: improved abstraction
3585
3586 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
3587
3588         Not reviewed, Windows build fix.
3589
3590         * DumpRenderTree/win/EventSender.cpp:
3591         (keyDownCallback):
3592
3593 2007-10-20  Darin Adler  <darin@apple.com>
3594
3595         Reviewed by Tim Hatcher.
3596
3597         - http://bugs.webkit.org/show_bug.cgi?id=15544
3598           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
3599           not rely on Apple-specific key codes
3600
3601         * DumpRenderTree/mac/EventSendingController.mm:
3602         (-[EventSendingController keyDown:withModifiers:]):
3603         Added named key "rightArrow". Later we could have a whole table of these.
3604         Also tweaked modifiers code a little.
3605
3606         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
3607
3608 2007-10-19  Darin Adler  <darin@apple.com>
3609
3610         Reviewed by Eric.
3611
3612         - http://bugs.webkit.org/show_bug.cgi?id=15566
3613           possible fix for leak seen in DumpRenderTree
3614
3615         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
3616         Delete the item if it's not put on the queue, since the caller has
3617         no way of knowing that. Would be better to have the parameter type
3618         be auto_ptr to express the fact that we take ownership.
3619
3620         - unrelated change
3621
3622         * Drosera/mac/main.m: Add missing include.
3623
3624 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3625
3626         Reviewed by Adam.
3627
3628         - This change should be identical but for some reason was not working
3629         on my machine.
3630
3631         * Scripts/prepare-ChangeLog:
3632
3633 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3634
3635         Reviewed by Oliver and Tim.
3636
3637         - Made use of RetainPtr to avoid retain and release issues and moved the
3638         log function to DebuggerDocumentPlatform, which seems to be a more
3639         logical place for it to live.
3640         - Also moved knownServers from the ServerConnection to
3641         DebuggerApplication to match the Windows code and because it makes sense
3642         that a connection knows its own server but not all of them.
3643
3644         * Drosera/mac/DebuggerClient.h: Moved the log function to
3645           DebuggerDocumentPlatform.
3646         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
3647           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
3648           call for the server name up from the ServerConnection class.
3649         (-[DebuggerClient dealloc]):
3650         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
3651           for the server name up from the ServerConnection.
3652         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
3653         (DebuggerDocument::platformPause):
3654         (DebuggerDocument::platformResume):
3655         (DebuggerDocument::platformStepInto):
3656         (DebuggerDocument::platformEvaluateScript):