WebKitTools/ChangeLog

   1 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
   2
   3         Rubber-stamped by Adam Roben.
   4
   5         Rolled out r27326 - debug CRT seems to cause no problems after all.
   6
   7         * DumpRenderTree/win/DumpRenderTree.vcproj:
   8
   9 2007-10-31  Adam Roben  <aroben@apple.com>
  10
  11         Switch the Debug configuration to using the non-debug CRT
  12
  13         This matches WebKit.
  14
  15         Reviewed by Steve.
  16
  17         * DumpRenderTree/win/DumpRenderTree.vcproj:
  18
  19 2007-10-31  Antti Koivisto  <antti@apple.com>
  20
  21         Reviewed by bdash.
  22
  23         Disable media tests when doing leak checking on Tiger.
  24         They crash in QuickTime (rdar://problem/5537157).
  25
  26         * Scripts/run-webkit-tests:
  27
  28 2007-10-29  Antti Koivisto  <antti@apple.com>
  29
  30         Reviewed by Maciej.
  31
  32         Build media support by default on OSX only.
  33
  34         * Scripts/build-webkit:
  35
  36 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
  37
  38         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
  39         get caught by the pre-commit hooks.
  40
  41 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
  42
  43         Reviewed by Adam.
  44
  45         - This is a collection of relatively unrelated changes and cleanups
  46         to Drosera to prepare it for interacting with WebKit.  A lot of these
  47         changes are just correcting mistakes, for example removing included
  48         headers that are no longer needed.
  49
  50         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
  51         this will be needed by the DebuggerClient.
  52         (DebuggerDocument::server):
  53         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
  54         * Drosera/win/DebuggerClient.cpp:
  55         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
  56         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
  57         (DebuggerClient::createWebViewWithRequest): Added comment about its
  58         purpose.
  59         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
  60         declarations.
  61         (DebuggerClient::webViewLoaded): Moved.
  62         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
  63         file, since this was the only place it was used.
  64         (cfStringToBSTR):
  65         * Drosera/win/Drosera.h: Cleaned up the includes.
  66         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
  67         * Drosera/win/HelperFunctions.h: Removed.
  68
  69 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
  70
  71         Reviewed by Adam.
  72
  73         - Small cleanup in the ServerConnection class.
  74
  75         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
  76         and added an include.
  77         (ServerConnection::currentFrame):
  78         (ServerConnection::getCallerFrame):
  79         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
  80         made a pointer into a COMPtr, and cleaned up the includes.
  81
  82 2007-10-29  Timothy Hatcher  <timothy@apple.com>
  83
  84         Reviewed by John Sullivan.
  85
  86         - Place the Localizable.strings file in mac or win directories
  87           if that location exists.
  88         - Also look for UI_STRING in .c files.
  89
  90         * Scripts/extract-localizable-strings:
  91
  92 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
  93
  94         Reviewed by Adam.
  95
  96         - Set the eol-style to native and made all the line endings the same
  97         so that I avoid messy diffs that show eol changes.
  98
  99         * Drosera/win/ServerConnection.cpp:
 100         (ServerConnection::didParseSource):
 101         (ServerConnection::didEnterCallFrame):
 102         (ServerConnection::willExecuteStatement):
 103         (ServerConnection::willLeaveCallFrame):
 104         (ServerConnection::exceptionWasRaised):
 105
 106 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
 107
 108         Reviewed by Adam.
 109
 110         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
 111         functionality that could not have existed previously without the new
 112         interfaces.
 113         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
 114         from a BSTR to a JSValueRef.
 115         (DebuggerDocument::platformEvaluateScript): Implemented.
 116         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
 117         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 118         Implemented.
 119         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
 120         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
 121         * Drosera/win/ServerConnection.cpp: Added a helper function.
 122         (ServerConnection::getCallerFrame):
 123         * Drosera/win/ServerConnection.h: Added a helper function.
 124
 125 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
 126
 127         updated reviewers for my previous changelog.
 128
 129 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
 130         Reviewed by Maciej and Adam and Geoff.
 131
 132         - Minor mac-side improvements including moving a function to a more
 133         appropriate location, fixing a warning, and correctly checking
 134         exceptions.
 135
 136         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
 137         (DebuggerDocument::willExecuteStatement):
 138         (DebuggerDocument::didEnterCallFrame):
 139         (DebuggerDocument::willLeaveCallFrame):
 140         (DebuggerDocument::windowScriptObjectAvailable):
 141         (DebuggerDocument::callFunctionOnObject):
 142         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
 143         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
 144         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
 145         because it doesn't require the ServerConnection at all.
 146         (NSStringCreateWithJSStringRef): Made an argument const.
 147         (JSValueRefCreateWithNSString): Made an argument const.
 148         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
 149         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 150         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
 151         * Drosera/mac/ServerConnection.mm: Ditto.
 152         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
 153
 154 2007-10-29  Sam Weinig  <sam@webkit.org>
 155
 156         Reviewed by Adam Roben.
 157
 158         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
 159
 160         * DumpRenderTree/LayoutTestController.cpp:
 161         (LayoutTestController::LayoutTestController):
 162         (getGlobalFlagCallback):
 163         (setGlobalFlagCallback):
 164         (LayoutTestController::getJSClass):
 165         (LayoutTestController::staticValues):
 166         * DumpRenderTree/LayoutTestController.h:
 167         (LayoutTestController::globalFlag):
 168         (LayoutTestController::setGlobalFlag):
 169
 170 2007-10-29  Darin Adler  <darin@apple.com>
 171
 172         Reviewed by Maciej.
 173
 174         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
 175         resolution instead of its default.
 176
 177 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
 178
 179         Fixed showStatus() to print status for successfully resolved conflicts when using git.
 180
 181         Reviewed by Mark Rowe.
 182
 183         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
 184         was successfully resolved, but this would not show any status because the change had
 185         already been cached in the index using "git add".  The solution is to add an optional
 186         second argument to showStatus() which adds the "--cached" switch to the command.
 187
 188         * Scripts/resolve-ChangeLogs:
 189         (showStatus):
 190
 191 2007-10-28  Eric Seidel  <eric@webkit.org>
 192
 193         Reviewed by Maciej and Geoff, in unison.
 194
 195         * Scripts/run-webkit-tests: remove broken --svg option
 196
 197 2007-10-28  Darin Adler  <darin@apple.com>
 198
 199         Reviewed by Adam.
 200
 201         * Scripts/run-sunspider: Default to "Release" configuration rather than
 202         defaulting to the last configuration used as other scripts do. This can
 203         still be overriden on the command line with "--debug" if there's some
 204         reason to do so. Also fix a typo.
 205
 206         * Scripts/sunspider-compare-results: Fix a typo.
 207
 208 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
 209
 210         Reviewed by Adam.
 211
 212         - Implemented the WebScriptDebugListener functions now that the
 213         WebScriptDebugServer exists
 214
 215         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
 216         functions.
 217         (ServerConnection::currentFrame):
 218         (ServerConnection::didLoadMainResourceForDataSource):
 219         (ServerConnection::didParseSource):
 220         (ServerConnection::failedToParseSource):
 221         (ServerConnection::didEnterCallFrame):
 222         (ServerConnection::willExecuteStatement):
 223         (ServerConnection::willLeaveCallFrame):
 224         (ServerConnection::exceptionWasRaised):
 225         * Drosera/win/ServerConnection.h: Removed unused arguments from the
 226         members arguments list.
 227
 228 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
 229
 230         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
 231         <http://bugs.webkit.org/show_bug.cgi?id=15600>
 232
 233         Reviewed by Darin.
 234
 235         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
 236         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
 237         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
 238         file.  Note that it may also be used as a stand-alone script.
 239
 240         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
 241         * Scripts/resolve-ChangeLogs: Added.
 242         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
 243
 244 2007-10-26  Mark Rowe  <mrowe@apple.com>
 245
 246         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
 247         to the Qt port on the assumption that it was an implementation of the cross-platform
 248         LayoutTestController class.  It is not, so it did not need to be changed.
 249
 250         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
 251
 252 2007-10-25  Mark Rowe  <mrowe@apple.com>
 253
 254         Reviewed by Maciej.
 255
 256         Fix builds with code coverage enabled.
 257
 258         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
 259
 260 2007-10-25  Darin Adler  <darin@apple.com>
 261
 262         Reviewed by Mark Rowe.
 263
 264         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
 265         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
 266
 267 2007-10-25  Stephanie  <slewis@apple.com>
 268
 269         build Fix
 270
 271         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 272
 273 2007-10-25  Stephanie  <slewis@apple.com>
 274
 275         Reviewed by Mark Rowe, Adam Roben.
 276
 277         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
 278
 279         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 280
 281 2007-10-25  Alice Liu  <alice.liu@apple.com>
 282
 283         Reviewed by Adam.
 284
 285         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
 286
 287         Moving destructor into platform-specific files
 288         * DumpRenderTree/LayoutTestController.cpp:
 289         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 290         (LayoutTestController::~LayoutTestController):
 291         * DumpRenderTree/qt/jsobjects.cpp:
 292         (LayoutTestController::~LayoutTestController):
 293
 294         LayoutTestController wasn't being destroyed
 295         * DumpRenderTree/win/DumpRenderTree.cpp:
 296         (runTest):
 297
 298         Added declspec
 299         * DumpRenderTree/win/EditingDelegate.h:
 300
 301         Reset certain values on the webview (or related delegate) that might
 302         have changed while running a test
 303         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 304         (LayoutTestController::~LayoutTestController):
 305
 306 2007-10-25  Adam Roben  <aroben@apple.com>
 307
 308         Make sunspider-compare-results work with relative paths
 309
 310         Reviewed by Sam.
 311
 312         * Scripts/sunspider-compare-results: Convert arguments to absolute
 313         paths before we chdir.
 314
 315 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
 316
 317         Reviewed by Sam.
 318
 319         - Implemented server calls now the WebScriptDebugServer exists.
 320         - Also removed no longer needed call to initialize CG.
 321
 322         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
 323         automatically now.
 324         (_tWinMain):
 325         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
 326         (ServerConnection::ServerConnection):
 327         (ServerConnection::~ServerConnection):
 328         (ServerConnection::pause):
 329         (ServerConnection::resume):
 330         (ServerConnection::stepInto):
 331         (ServerConnection::applicationTerminating):
 332         (ServerConnection::serverConnectionDidDie):
 333         * Drosera/win/ServerConnection.h: Now uses the COM class.
 334
 335 2007-10-24  George Staikos  <staikos@kde.org>
 336
 337         Unbreak Qt build.
 338
 339         * Scripts/build-webkit:
 340
 341 2007-10-24  Adam Roben  <aroben@apple.com>
 342
 343         Remove now-unnecessary call to InitializeCoreGraphics
 344
 345         WebKit takes care of this now.
 346
 347         Reviewed by Ada.
 348
 349         * DumpRenderTree/win/DumpRenderTree.cpp:
 350         (initialize):
 351
 352 2007-10-24  Adam Roben  <aroben@apple.com>
 353
 354         Use WebTextRenderer in DRT
 355
 356         Reviewed by Ada.
 357
 358         * DumpRenderTree/win/DumpRenderTree.cpp:
 359         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
 360
 361 2007-10-24  Sven Herzberg  <sven@imendio.com>
 362
 363         Reviewed by Mark Rowe.
 364
 365         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
 366         Bug 15614: [GTK] qmake based backends don't build on OS X
 367
 368         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
 369         GTK backend on a Mac
 370         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
 371         isDarwin() to make it reusable in other places (like the workaround-
 372         for-prebuilt-qmake in build-webkit)
 373
 374 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
 375
 376         Refurbish update-webkit script.
 377
 378         Reviewed by Adam.
 379
 380         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
 381         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
 382         multi-argument version of system() for flexibility and security.  Check for existence
 383         of Internal directory using -d test instead of -x.
 384
 385 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
 386
 387         Minor clean-up of prepare-ChangeLog script.
 388
 389         Reviewed by Adam.
 390
 391         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
 392         of a string.  Use multi-argument versions of open() and system() for flexibility and
 393         security.
 394
 395 2007-10-24  Alice Liu  <alice.liu@apple.com>
 396
 397         Reviewed by Oliver.
 398
 399         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
 400
 401         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
 402         replay the saved events when we're still processing the mousedown that starts the drag
 403         * DumpRenderTree/win/EventSender.cpp:
 404         (doMouseMove):
 405         * DumpRenderTree/win/UIDelegate.cpp:
 406         (UIDelegate::doDragDrop):
 407
 408 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
 409
 410         Reviewed by Sam, Steve and Darin.
 411
 412         - Stubbed out the WebScriptDebugListener functionality in the Server
 413         Connection class to prepare it for receiving those callbacks.
 414         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
 415         and the ServerConnection to not need to be initialized with a server
 416         name, since that is not the way we connect to the WebKit server.
 417
 418         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
 419         no exception.  Now it only loggs when there is an exception
 420         (DebuggerDocument::willExecuteStatement):
 421         (DebuggerDocument::didEnterCallFrame):
 422         (DebuggerDocument::willLeaveCallFrame):
 423         (DebuggerDocument::windowScriptObjectAvailable):
 424         (DebuggerDocument::callFunctionOnObject):
 425         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
 426         to be instantiated with a server's name.
 427         (DebuggerClient::DebuggerClient):
 428         (DebuggerClient::didFinishLoadForFrame):
 429         * Drosera/win/DebuggerClient.h: Removed unsued variable.
 430         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
 431         a server name.
 432         (Drosera::init):
 433         (Drosera::initServer):
 434         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
 435         instantiated with a server's name.
 436         * Drosera/win/ServerConnection.cpp:
 437         (ServerConnection::ServerConnection): No longer needs a server name
 438         (ServerConnection::~ServerConnection): Only release the global context
 439         if there is one.
 440         (ServerConnection::serverConnectionDidDie): Stub for
 441         IWebScriptDebugListener
 442         (ServerConnection::QueryInterface): ditto
 443         (ServerConnection::AddRef): ditto
 444         (ServerConnection::Release): ditto
 445         (ServerConnection::didLoadMainResourceForDataSource): ditto
 446         (ServerConnection::didParseSource): ditto
 447         (ServerConnection::failedToParseSource): ditto
 448         (ServerConnection::didEnterCallFrame): ditto
 449         (ServerConnection::willExecuteStatement): ditto
 450         (ServerConnection::willLeaveCallFrame): ditto
 451         (ServerConnection::exceptionWasRaised): ditto
 452         * Drosera/win/ServerConnection.h: Stubbed out the
 453         IWebScriptDebugListener functions, and this class no longer needs to be
 454         instantiated with a server name.
 455
 456 2007-10-24  Lars Knoll  <lars@trolltech.com>
 457
 458         Reviewed by Simon.
 459
 460         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
 461
 462         * DumpRenderTree/qt/jsobjects.h:
 463
 464 2007-10-24  Lars Knoll  <lars@trolltech.com>
 465
 466         Reviewed by Simon.
 467
 468         add another command.
 469
 470         * DumpRenderTree/qt/jsobjects.cpp:
 471         (TextInputController::doCommand):
 472
 473 2007-10-24  Lars Knoll  <lars@trolltech.com>
 474
 475         Reviewed by Simon.
 476
 477         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
 478
 479         * DumpRenderTree/qt/jsobjects.cpp:
 480         (EventSender::keyDown):
 481         * DumpRenderTree/qt/jsobjects.h:
 482
 483 2007-10-24  Lars Knoll  <lars@trolltech.com>
 484
 485         Reviewed by Simon.
 486
 487         implement eventSender.keyDown().
 488
 489         * DumpRenderTree/qt/jsobjects.cpp:
 490         (EventSender::keyDown):
 491
 492 2007-10-24  Lars Knoll  <lars@trolltech.com>
 493
 494         Reviewed by Simon.
 495
 496         some smaller fixes to the editing support in DRT. Makes another few tests pass.
 497
 498         * DumpRenderTree/qt/DumpRenderTree.cpp:
 499         (WebCore::DumpRenderTree::DumpRenderTree):
 500         (WebCore::DumpRenderTree::initJSObjects):
 501         * DumpRenderTree/qt/jsobjects.cpp:
 502         (TextInputController::doCommand):
 503
 504 2007-10-24  Lars Knoll  <lars@trolltech.com>
 505
 506         Reviewed by Simon.
 507
 508         first bit of implementation for the textinputcontroller.
 509
 510         * DumpRenderTree/qt/DumpRenderTree.cpp:
 511         (WebCore::DumpRenderTree::DumpRenderTree):
 512         * DumpRenderTree/qt/DumpRenderTree.h:
 513         * DumpRenderTree/qt/jsobjects.cpp:
 514         (TextInputController::TextInputController):
 515         (TextInputController::doCommand):
 516         * DumpRenderTree/qt/jsobjects.h:
 517
 518 2007-10-24  Lars Knoll  <lars@trolltech.com>
 519
 520         Reviewed by Simon.
 521
 522         make the man webpage believe it has focus, so the editing tests work correctly.
 523
 524         * DumpRenderTree/qt/DumpRenderTree.cpp:
 525         (WebCore::DumpRenderTree::DumpRenderTree):
 526
 527 2007-10-24  Lars Knoll  <lars@trolltech.com>
 528
 529         Reviewed by Simon.
 530
 531         implement layoutTestController.dumpEditingCallbacks() correctly.
 532
 533         * DumpRenderTree/qt/DumpRenderTree.cpp:
 534         (WebCore::DumpRenderTree::DumpRenderTree):
 535         * DumpRenderTree/qt/jsobjects.cpp:
 536         (LayoutTestController::reset):
 537         (LayoutTestController::dumpEditingCallbacks):
 538
 539 2007-10-24  Lars Knoll  <lars@trolltech.com>
 540
 541         Reviewed by Simon.
 542
 543         Implement support for testing editing.
 544
 545         * DumpRenderTree/qt/DumpRenderTree.cpp:
 546         (WebCore::DumpRenderTree::DumpRenderTree):
 547
 548 2007-10-23  Sam Weinig  <sam@webkit.org>
 549
 550         Check for null BSTR that can be passed to the UIDelegate methods
 551         from javascript null and undefined.  Fixes a failing test case on
 552         Windows (fast/dom/Window/alert-undefined.html)
 553
 554         Reviewed by Eric Seidel.
 555
 556         * DumpRenderTree/win/UIDelegate.cpp:
 557         (UIDelegate::runJavaScriptAlertPanelWithMessage):
 558         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
 559         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
 560         (UIDelegate::webViewAddMessageToConsole):
 561
 562 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
 563
 564         Reviewed by Darin.
 565
 566         Don't print a massive pile of setenvs from tools that automatically build testkjs.
 567
 568         * Scripts/build-testkjs:
 569
 570 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
 571
 572         Reviewed by Darin.
 573
 574         - add wrapper that finds the right copy of testkjs
 575
 576         * Scripts/sunspider-compare-results: Added.
 577
 578 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
 579
 580         Reviewed by Sam.
 581
 582         - After talking with Steve I now see that the WebKit server must be
 583         running for DCOM to create the distributed objects, which makes sense
 584         and currently WebKit only allows one instance to be running at a time
 585         which avoids accidentally connecting to the wrong server
 586         - In light of this I have removed the code for the attach box and
 587         NotificationServer and known server names, since they are all extranious
 588         now.
 589
 590         * Drosera/win/Drosera.cpp: Removed notification classes and known server
 591         names.
 592         (_tWinMain): Uses init instead of initUI.
 593         (droseraWndProc): No longer creats an attach dialog box.
 594         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
 595         it's not manditory to call init before doing COM stuff.
 596         (Drosera::init): calls initUI and will call attach when the
 597         functionality exists.
 598         (Drosera::initUI): Has changed very little.
 599         (Drosera::attach): Changed the signature to reflect that we no longer
 600         need the dictionary of known server names.
 601         * Drosera/win/Drosera.h: Removed notification classes and known server
 602         names.  Also renamed and moved some functions.
 603         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
 604         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
 605         headers to the resources folder.
 606         * Drosera/win/resource.h: Removed the Attach box.
 607
 608 2007-10-22  Adam Roben  <aroben@apple.com>
 609
 610         Windows build fix
 611
 612         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
 613
 614 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
 615
 616         - Removed a leak that was fixed.
 617
 618         * Scripts/run-webkit-tests:
 619
 620 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
 621
 622         Reviewed by Darin.
 623
 624         - Changed the Client so that the DebuggerDocument now own the
 625         ServerConnection.  This simplifies ownership and cleanup.
 626
 627         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
 628         ServerConnection.
 629         (DebuggerClient::initWithServerName):
 630         (DebuggerClient::didFinishLoadForFrame):
 631         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the
 632         ServerConnection.
 633         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
 634         until after we have a server which we are attached to.
 635         (Drosera::initUI):
 636         (Drosera::attach):
 637         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
 638         out previously.
 639
 640 2007-10-22  Simon Hausmann  <hausmann@kde.org>
 641
 642         Reviewed by Nikolas.
 643
 644         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
 645
 646         * Scripts/run-javascriptcore-tests:
 647
 648 2007-10-22  Simon Hausmann  <hausmann@kde.org>
 649
 650         Reviewed by Nikolas.
 651
 652         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
 653
 654         * Scripts/build-drosera:
 655         * Scripts/build-dumprendertree:
 656         * Scripts/build-testkjs:
 657         * Scripts/build-webkit:
 658         * Scripts/run-javascriptcore-tests:
 659         * Scripts/run-sunspider:
 660         * Scripts/run-webkit-tests:
 661         * Scripts/webkitdirs.pm:
 662
 663 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
 664
 665         Reviewed by Mark Rowe.
 666
 667         Fix for local database support after r26879
 668         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
 669
 670         * Scripts/build-webkit:
 671
 672 2007-10-22  Holger Freyther  <zecke@selfish.org>
 673
 674         Reviewed by Simon Hausmann <hausmann@kde.org>.
 675
 676         - Do not build testkjs as an application bundle. This is
 677         needed for run-javascriptcore-tests on OSX.
 678         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
 679         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
 680         as we do not have -rpath on OSX.
 681
 682         * DumpRenderTree/qt/DumpRenderTree.pro:
 683         * Scripts/run-webkit-tests:
 684
 685 2007-10-22  Simon Hausmann  <hausmann@kde.org>
 686
 687         Reviewed by aroben.
 688
 689         Fix support for Signed-off-by detection in prepare-ChangeLog
 690         --git-commit. The Signed-off-by tag does not appear in the header
 691         but usually at the end.
 692
 693         * Scripts/prepare-ChangeLog:
 694
 695 2007-10-21  Mark Rowe  <mrowe@apple.com>
 696
 697         Reviewed by Eric.
 698
 699         Fix run-javascriptcore-tests for Gtk.
 700
 701         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
 702
 703 2007-10-20  Eric Seidel  <eric@webkit.org>
 704
 705         Reviewed by aroben.
 706
 707         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
 708
 709 2007-10-20  Eric Seidel  <eric@webkit.org>
 710
 711         Reviewed by darin.
 712
 713         Add improved argument handling to run-sunspider, including
 714         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
 715         Also re-factor code into subroutines
 716
 717         * Scripts/build-dumprendertree: removed bogus comments
 718         * Scripts/build-testkjs: Added.
 719         * Scripts/run-javascriptcore-tests: use build-testkjs
 720         * Scripts/run-sunspider: improved argument handling, abstraction
 721         * Scripts/run-webkit-tests: improved abstraction
 722
 723 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
 724
 725         Not reviewed, Windows build fix.
 726
 727         * DumpRenderTree/win/EventSender.cpp:
 728         (keyDownCallback):
 729
 730 2007-10-20  Darin Adler  <darin@apple.com>
 731
 732         Reviewed by Tim Hatcher.
 733
 734         - http://bugs.webkit.org/show_bug.cgi?id=15544
 735           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
 736           not rely on Apple-specific key codes
 737
 738         * DumpRenderTree/mac/EventSendingController.mm:
 739         (-[EventSendingController keyDown:withModifiers:]):
 740         Added named key "rightArrow". Later we could have a whole table of these.
 741         Also tweaked modifiers code a little.
 742
 743         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
 744
 745 2007-10-19  Darin Adler  <darin@apple.com>
 746
 747         Reviewed by Eric.
 748
 749         - http://bugs.webkit.org/show_bug.cgi?id=15566
 750           possible fix for leak seen in DumpRenderTree
 751
 752         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
 753         Delete the item if it's not put on the queue, since the caller has
 754         no way of knowing that. Would be better to have the parameter type
 755         be auto_ptr to express the fact that we take ownership.
 756
 757         - unrelated change
 758
 759         * Drosera/mac/main.m: Add missing include.
 760
 761 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
 762
 763         Reviewed by Adam.
 764
 765         - This change should be identical but for some reason was not working
 766         on my machine.
 767
 768         * Scripts/prepare-ChangeLog:
 769
 770 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
 771
 772         Reviewed by Oliver and Tim.
 773
 774         - Made use of RetainPtr to avoid retain and release issues and moved the
 775         log function to DebuggerDocumentPlatform, which seems to be a more
 776         logical place for it to live.
 777         - Also moved knownServers from the ServerConnection to
 778         DebuggerApplication to match the Windows code and because it makes sense
 779         that a connection knows its own server but not all of them.
 780
 781         * Drosera/mac/DebuggerClient.h: Moved the log function to
 782           DebuggerDocumentPlatform.
 783         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
 784           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
 785           call for the server name up from the ServerConnection class.
 786         (-[DebuggerClient dealloc]):
 787         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
 788           for the server name up from the ServerConnection.
 789         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
 790         (DebuggerDocument::platformPause):
 791         (DebuggerDocument::platformResume):
 792         (DebuggerDocument::platformStepInto):
 793         (DebuggerDocument::platformEvaluateScript):
 794         (DebuggerDocument::getPlatformCurrentFunctionStack):
 795         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 796         (DebuggerDocument::platformValueForScopeVariableNamed):
 797         (DebuggerDocument::platformLog): Log directly from here. No need to call
 798           DebuggerClient.
 799         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
 800           way I see it, a ServerConnection should only know about its connection
 801           and the group of all possible servers should be kept by the
 802           application.
 803         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
 804           currentServerName, it makes sense that the connection should know that
 805           name.
 806         (-[ServerConnection currentServerName]):
 807
 808 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
 809
 810         Reviewed by Adam.
 811
 812         - Integrated changes from mac drosera.  Recently I've encapsulated
 813         out the server connection object from the rest of Drosera because
 814         it is very platform dependent right now and RPC is not implemented on
 815         windows.  This functionality, of communicating with the WebKit server
 816         is the next area I will be focusing on in Windows.
 817
 818         - Other changes and cleanup were made to organize the code and add notes
 819         on which parts still need work.  Also some mac code is added and
 820         commented out, to act as pseudocode for the logic of those parts.
 821
 822         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
 823           pointer.
 824         * Drosera/config.h: Added whitespace.
 825         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
 826           these files got moved into Drosera.h/cpp
 827         * Drosera/win/DebuggerApplication.h: Removed.
 828         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring
 829           happened here to better match the logic flow of the same code on the
 830           mac side and to use the new ServerConnection class.
 831         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
 832         (DebuggerClient::initWithServerName): Initializer that will set up the
 833           class to use a ServerConnection object.  This was necessary so I could
 834           create a DebuggerClient without having to initilaize it at
 835           construction.
 836         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
 837           will be the UIDelegate and FrameLoadDelegate.
 838         (DebuggerClient::AddRef): For IUnknown.
 839         (DebuggerClient::Release): For IUnknown.
 840         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
 841           this still needs to set the global context of the server, but
 842           IWebFrame does not have an accessor for the global context yet.
 843         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
 844           this is a pass through for the same function in the document.
 845         (DebuggerClient::didReceiveTitle): Unimplemented part of
 846           FrameLoadDelegate this would change the title of the window.
 847         (DebuggerClient::createWebViewWithRequest): Part of the
 848           FrameLoadDelegate.  This is about new windows via Window.open() and
 849           how their delegates are set.
 850         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
 851           UIDelegate.  Just a debug function for printing messages.
 852         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
 853           because the Client should be the UIDelegate and FrameLoadDelegate
 854           to match the delegates on mac.
 855         (DebuggerClient::webViewLoaded): Added accessor method.
 856         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
 857           forgotten to add this file before.  This is where the platform
 858           dependent versions of the Documents functions live. Most of these are
 859           unimplemented because some piece of functionality does not exist on
 860           Windows yet.
 861         (DebuggerDocument::platformPause):
 862         (DebuggerDocument::platformResume):
 863         (DebuggerDocument::platformStepInto):
 864         (DebuggerDocument::platformEvaluateScript):
 865         (DebuggerDocument::getPlatformCurrentFunctionStack):
 866         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 867         (DebuggerDocument::platformValueForScopeVariableNamed):
 868         (DebuggerDocument::platformLog):
 869         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
 870           responsibilities becaue they belong in the Client. Also I laid the
 871           groundwork for attaching Drosera to a WebKit process
 872         (attachWndProc): Now if a server is selected the Client becomes it's
 873           delegate.
 874         (Drosera::Drosera): Added the construction of the Client and dictionary
 875           of server names.
 876         (Drosera::initUI): This is no longer the delegates, the Client is.
 877         (Drosera::webViewLoaded): Now asks the Client instead of holding local
 878           state.
 879         (Drosera::applicationDidFinishLaunching): Placeholder for needed
 880           notification registration when it's possible to implement.
 881         (Drosera::serverLoaded): Ditto
 882         (Drosera::serverUnloaded): Ditto
 883         (Drosera::attach): Attach Drosera to the WebKit server.
 884         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
 885         (Drosera::getInst):
 886         (Drosera::setInst):
 887         (Drosera::knownServers):
 888         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
 889           and added the ServerConnection.
 890         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
 891         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
 892           Most of the functions are completely unimlemented because they cannot
 893           connect with the WebKit server, because one does not exist on Windows
 894           yet.
 895         (ServerConnection::initWithServerName):
 896         (ServerConnection::~ServerConnection):
 897         (ServerConnection::setGlobalContext):
 898         (ServerConnection::pause):
 899         (ServerConnection::resume):
 900         (ServerConnection::stepInto):
 901         (ServerConnection::switchToServerNamed):
 902         (ServerConnection::applicationTerminating):
 903         (ServerConnection::serverConnectionDidDie):
 904         (ServerConnection::currentFrame):
 905         * Drosera/win/ServerConnection.h: Added. Ditto.
 906         (ServerConnection::ServerConnection):
 907
 908 2007-10-19  Alice Liu  <alice.liu@apple.com>
 909
 910         Reviewed by Darin.
 911
 912         Fix for these broken layout tests on Windows:
 913
 914         fast/forms/focus-selection-input.html
 915         fast/forms/focus-selection-textarea.html
 916         fast/forms/select-accesskey.html
 917
 918         * DumpRenderTree/win/EventSender.cpp:
 919         (keyDownCallback):
 920         correct the VK code for alt key.
 921
 922 2007-10-19  Eric Seidel  <eric@webkit.org>
 923
 924         Reviewed by Mark Rowe.
 925
 926         Make the GtkLauncher code slightly more readable.
 927
 928         * GtkLauncher/main.cpp:
 929         (setupMainMenu): Added.
 930         (setupMainWindowUI): Added.
 931         (main):
 932
 933 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
 934
 935         Rubber stamped by Adam.
 936
 937         - don't delay-load WebKit in DumpRenderTree.
 938
 939         * DumpRenderTree/win/DumpRenderTree.vcproj:
 940
 941 2007-10-18  Dan Bernstein  <dan.bernstein@apple.com>
 942
 943         Reviewed by Adam Roben.
 944
 945         - fix <rdar://problem/5313523>
 946         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
 947
 948         * DumpRenderTree/mac/DumpRenderTree.mm:
 949         (dump): Changed to use _responseMIMEType.
 950
 951 2007-10-17  Adam Roben  <aroben@apple.com>
 952
 953         Make it possible to have Windows-specific tests and results
 954
 955         When searching for tests to run and the Skipped file, we will only
 956         look in platform/win and the cross-platform directory. When looking
 957         for expected results, we will look in platform/win, then
 958         platform/mac-leopard, then platform/mac, then finally the
 959         cross-platform directory.
 960
 961         Reviewed by Sam.
 962
 963         * Scripts/run-webkit-tests:
 964         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
 965         searching in the cross-platform directory.
 966         (sub buildPlatformHierarchy): Removed some unneeded calls to
 967         dirname/basename.
 968
 969 2007-10-17  Adam Roben  <aroben@apple.com>
 970
 971         Add back the call to register WebKit that we had before WebKitInitializer existed
 972
 973         This is needed to ensure that the right WebKit is used when
 974         instantiating COM objects.
 975
 976         Reviewed by Oliver.
 977
 978         * DumpRenderTree/win/debug_internal.vsprops: Define
 979         DEBUG_WEBKIT_HAS_SUFFIX.
 980         * DumpRenderTree/win/DumpRenderTree.cpp:
 981         (initialize):
 982
 983 2007-10-17  Adam Roben  <aroben@apple.com>
 984
 985         Import File::Basename in webkitdirs since we use it
 986
 987         * Scripts/webkitdirs.pm:
 988
 989 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
 990
 991         - Updated the tiger leaks list to make the internal bots green.
 992
 993         * Scripts/run-webkit-tests:
 994
 995 2007-10-17  Adam Roben  <aroben@apple.com>
 996
 997         Build fix for VC++ Express
 998
 999         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
1000         and ole32.lib.
1001
1002 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1003
1004         Reviewed by Sam.
1005
1006         - Minor mac improvements based on observations I made while implementing the
1007         Windows code.
1008
1009         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
1010         then hand it to the Client who will retain it, it should just be the client who
1011         creates and owns the server.
1012         (-[DebuggerApplication attach:]):
1013         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
1014         * Drosera/mac/DebuggerClient.mm: Creates the server.
1015         (-[DebuggerClient initWithServerName:]):
1016         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
1017         can instead forward declare what it needs.
1018
1019 2007-10-16  Darin Adler  <darin@apple.com>
1020
1021         Reviewed by Geoff Garen.
1022
1023         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
1024         want to turn failing tests into platform-specific test results. Also did a
1025         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
1026         would take the type of results into account only some of the time.
1027
1028 2007-10-16  Adam Roben  <aroben@apple.com>
1029
1030         Add a new nightly launcher script for Windows
1031
1032         This new script is for versions of Safari that don't delay-load
1033         WebKit. I had to make FindSafari be able to print out the nightly
1034         launcher script on stdout because Windows shell scripts can't capture
1035         the output from a command into an environment variable.
1036
1037         Reviewed by Steve.
1038
1039         * FindSafari/FindSafari.cpp:
1040         (_tmain): Added /printSafariLauncher option.
1041         * Scripts/run-webkit-nightly.cmd: Added.
1042
1043 2007-10-16  Adam Roben  <aroben@apple.com>
1044
1045         Replace WebKitInitializer with FindSafari
1046
1047         We now rely on setting the PATH environment variable to tell Windows
1048         where to find WebKit and its dependencies (similar to
1049         DYLD_FRAMEWORK_PATH on Mac).
1050
1051         This change also make DumpRenderTree no longer delay-load WebKit.
1052
1053         Reviewed by Sam.
1054
1055         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
1056         FindSafari.
1057         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
1058         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
1059         WebKitInitializer, don't delay-load WebKit.
1060         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
1061         * Scripts/run-webkit-tests: Ditto.
1062         * Scripts/webkitdirs.pm:
1063         (sub setPathForRunningWebKitApp): Added.
1064         * WebKitInitializer/WebKitInitializer.cpp: Removed.
1065         * WebKitInitializer/WebKitInitializer.h: Removed.
1066         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
1067         * WebKitInitializer/debug.vsprops: Removed.
1068         * WebKitInitializer/debug_internal.vsprops: Removed.
1069         * WebKitInitializer/release.vsprops: Removed.
1070
1071 2007-10-16  Adam Roben  <aroben@apple.com>
1072
1073         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
1074
1075         http://bugs.webkit.org/show_bug.cgi?id=15532
1076
1077         FindSafari simply prints the location of an installed Safari.exe on
1078         stdout.
1079
1080         Reviewed by Darin.
1081
1082         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
1083         (getStringValue):
1084         (getWebViewCLSID):
1085         (getInstalledWebKitDirectory):
1086         (_tmain):
1087         * FindSafari/FindSafari.vcproj: Added.
1088         * Scripts/webkitdirs.pm:
1089         (sub installedSafariPath): Added. Calls FindSafari on Windows.
1090
1091 2007-10-16  Adam Roben  <aroben@apple.com>
1092
1093         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
1094
1095         Reviewed by Kevin McCullough.
1096
1097         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
1098         when referring to WebKit.dll.
1099         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
1100         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
1101         * DumpRenderTree/win/release.vsprops: Ditto.
1102         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
1103         never have a _debug suffix on WebKit.dll.
1104         * WebKitInitializer/WebKitInitializer.cpp:
1105         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
1106         specified.
1107         * WebKitInitializer/debug_internal.vsprops: Added
1108         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
1109
1110 2007-10-16  Darin Adler  <darin@apple.com>
1111
1112         Reviewed by Adele.
1113
1114         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
1115         Remove now-unneeded control/alt key hack; the tests have been updated.
1116
1117 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
1118
1119         - Updated leaks list because our internal bot upgraded it's version of leopard and
1120         one of the leaks was fixed between that revision and the bot's previous version of
1121         leopard.
1122
1123         * Scripts/run-webkit-tests:
1124
1125 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
1126
1127         Reviewed by Tim.
1128
1129         - I encapsulated out the server connecton functionality because it is a specific part
1130         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
1131         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
1132         Windows.  So the majority of this patch is moving preexisting functionality.
1133
1134         - Also I removed the prefix header and changed to use config.h because it is more
1135         standard on how we use config.h in windows and it didn't make much sense to keep
1136         the prefix header and the config.h
1137
1138         * Drosera/DebuggerDocument.cpp:
1139         (DebuggerDocument::DebuggerDocument):
1140         * Drosera/DebuggerDocument.h:
1141         * Drosera/config.h:
1142         * Drosera/mac/DebuggerApplication.mm:
1143         (-[DebuggerApplication attach:]):
1144         * Drosera/mac/DebuggerClient.h:
1145         * Drosera/mac/DebuggerClient.mm:
1146         (-[DebuggerClient initWithServerConnection:]):
1147         (-[DebuggerClient dealloc]):
1148         (-[DebuggerClient windowDidLoad]):
1149         (-[DebuggerClient windowWillClose:]):
1150         (-[DebuggerClient webView:didFinishLoadForFrame:]):
1151         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
1152         * Drosera/mac/DebuggerDocumentPlatform.mm:
1153         (DebuggerDocument::platformPause):
1154         (DebuggerDocument::platformResume):
1155         (DebuggerDocument::platformStepInto):
1156         (DebuggerDocument::platformEvaluateScript):
1157         (DebuggerDocument::getPlatformCurrentFunctionStack):
1158         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1159         (DebuggerDocument::platformValueForScopeVariableNamed):
1160         (DebuggerDocument::platformLog):
1161         * Drosera/mac/Drosera.pch: Removed.
1162         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1163         * Drosera/mac/ServerConnection.h: Added.
1164         * Drosera/mac/ServerConnection.mm: Added.
1165         (-[ServerConnection initWithServerName:]):
1166         (-[ServerConnection dealloc]):
1167         (-[ServerConnection setGlobalContext:]):
1168         (-[ServerConnection pause]):
1169         (-[ServerConnection resume]):
1170         (-[ServerConnection stepInto]):
1171         (-[ServerConnection switchToServerNamed:]):
1172         (-[ServerConnection applicationTerminating:]):
1173         (-[ServerConnection serverConnectionDidDie:]):
1174         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1175         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
1176         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
1177         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
1178         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
1179         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
1180         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
1181         (-[ServerConnection currentFrame]):
1182         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
1183         (-[ServerConnection knownServers]):
1184
1185 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
1186
1187         Reviewed by Eric.
1188
1189         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
1190           Script to automatically search nightly builds for regressions (bisect-builds)
1191
1192         * Scripts/bisect-builds: Added.
1193
1194 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
1195
1196         Reviewed by Darin.
1197
1198         - New JavaScript benchmark
1199         http://bugs.webkit.org/show_bug.cgi?id=15515
1200
1201         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
1202         current development or release build of JavaScriptCore.
1203
1204 2007-10-15  Mark Rowe  <mrowe@apple.com>
1205
1206         Reviewed by Sam.
1207
1208         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
1209
1210         * Scripts/webkitdirs.pm:
1211         - Change checkArgv to remove the options from @ARGV to prevent
1212         them from interfering with further option processing.
1213         - Fix logic error in determineIsQt that would prevent it from bailing out early.
1214         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
1215         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
1216         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
1217
1218 2007-10-15  Darin Adler  <darin@apple.com>
1219
1220         Reviewed by Sam.
1221
1222         - added logging of window.prompt and window.confirm
1223
1224         * DumpRenderTree/mac/UIDelegate.mm:
1225         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1226         Implement the recommended delegate rather than the deprecated one.
1227         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
1228         Added.
1229         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
1230         Added.
1231
1232         * DumpRenderTree/win/UIDelegate.h:
1233         * DumpRenderTree/win/UIDelegate.cpp:
1234         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
1235         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1236         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
1237         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
1238
1239 2007-10-15  Alice Liu  <alice.liu@apple.com>
1240
1241         Reviewed by Sam Weinig.
1242
1243         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
1244
1245         * DumpRenderTree/win/DumpRenderTree.cpp:
1246         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
1247         (main): allocate the global policy delegate for DRT's custom use
1248         * DumpRenderTree/win/DumpRenderTree.vcproj:
1249         Adding files to project
1250         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
1251         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1252         (LayoutTestController::setCustomPolicyDelegate):
1253         set the webview's policy delegate to DRT's custom one if the test requests it.
1254         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
1255         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
1256         (PolicyDelegate::PolicyDelegate):
1257         (PolicyDelegate::QueryInterface):
1258         (PolicyDelegate::AddRef):
1259         (PolicyDelegate::Release):
1260         (PolicyDelegate::decidePolicyForNavigationAction):
1261         * DumpRenderTree/win/PolicyDelegate.h: Added.
1262         (PolicyDelegate::decidePolicyForNewWindowAction):
1263         (PolicyDelegate::decidePolicyForMIMEType):
1264         (PolicyDelegate::unableToImplementPolicyWithError):
1265
1266 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
1267
1268         Reviewed by Mark.
1269
1270         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
1271         when querying for QMAKE_MKSPECS.
1272
1273 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
1274
1275         Reviewed by Adam Roben.
1276
1277         Fix run-webkit-tests is too greedy calculating platform hierarchy
1278         http://bugs.webkit.org/show_bug.cgi?id=15465
1279
1280         Fix run-webkit-tests being too greedy in trying to split the platform name up
1281         causing it to try and find tests in every directory above the first "-" in the
1282         path to the LayoutTests
1283
1284         * Scripts/run-webkit-tests:
1285
1286 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
1287
1288         Reviewed by Darin.
1289
1290         http://bugs.webkit.org/show_bug.cgi?id=15006
1291         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
1292         to reduce code duplication.
1293
1294         * Scripts/build-webkit:
1295         * Scripts/webkitdirs.pm:
1296         buildQMakeProject() renamed to buildQMakeQtProject().
1297         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
1298         unused $colorize has been removed.
1299
1300 === Start merge of feature-branch 2007-10-12 ===
1301
1302 2007-10-08  Eric Seidel  <eric@webkit.org>
1303
1304         Reviewed by Mark Rowe.
1305
1306         * Scripts/build-webkit: add --help, remove unused --color
1307
1308 2007-10-07  Eric Seidel  <eric@webkit.org>
1309
1310         Reviewed by darin.
1311
1312         * Drosera/mac/DebuggerDocumentPlatform.mm:
1313         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
1314
1315 2007-10-03  Rob Buis  <buis@kde.org>
1316
1317         Reviewed by Olliej.
1318
1319         Adapt to changed location of Ahem font.
1320
1321         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1322
1323 2007-10-02  Eric Seidel  <eric@webkit.org>
1324
1325         Reviewed by Adam Roben.
1326
1327         Make pixel tests more useful!
1328         Finally fix the image diff 0.00% mystery problem
1329         Highlight any image differences in the image diff.
1330         Add a link from image diffs back to original test file.
1331
1332         * DumpRenderTree/mac/ImageDiff.m:
1333         (compareImages): highlight any differences
1334         (computePercentageDifferent): round to two decimal places
1335         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
1336
1337 2007-10-02  Eric Seidel  <eric@webkit.org>
1338
1339         Reviewed by Alexey Proskuryakov.
1340
1341         * Scripts/run-webkit-tests: print the % image difference on main results page
1342
1343 2007-10-02  Mark Rowe  <mrowe@apple.com>
1344
1345         Reviewed by Oliver.
1346
1347         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1348
1349         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1350         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1351
1352 2007-10-01  Mark Rowe  <mrowe@apple.com>
1353
1354         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1355
1356 2007-09-25  Eric Seidel  <eric@webkit.org>
1357
1358         Reviewed by Mark Rowe.
1359
1360         DerivedSources.make was finding "ENABLE_SVG" in the string
1361         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
1362         quite correctly.
1363
1364         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
1365
1366 2007-09-25  Mark Rowe  <mrowe@apple.com>
1367
1368         Rubber-stamped by Eric.
1369
1370         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1371         This makes it possible to automate nightly builds for the feature-branch.
1372
1373 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
1374
1375         Rubber stamped by Mark.
1376
1377         Enable svg experimental features as default here in feature-branch.
1378
1379         * Scripts/build-webkit:
1380
1381 2007-06-29  Antti Koivisto  <antti@apple.com>
1382
1383         Reviewed by Weinig.
1384
1385         Add VIDEO flag for timed media features
1386
1387         * Scripts/build-webkit
1388
1389 === End merge of feature-branch 2007-10-12 ===
1390
1391 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1392
1393         Reviewed by Darin.
1394
1395         - Updated rational for the leaks list to be more clear.
1396
1397         * Scripts/run-webkit-tests:
1398
1399 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
1400
1401         Rubber Stamp by Sam.
1402
1403         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
1404         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
1405
1406         * Scripts/run-webkit-tests:
1407
1408 2007-10-10  Simon Hausmann  <hausmann@kde.org>
1409
1410         Reviewed by Lars.
1411
1412         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
1413         includes are needed for INT_MAX, std::auto_ptr and the like.
1414
1415         * DumpRenderTree/qt/main.cpp:
1416
1417 2007-10-09  Lars Knoll  <lars@trolltech.com>
1418
1419         Reviewed by Simon.
1420
1421         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
1422
1423         * DumpRenderTree/qt/jsobjects.cpp:
1424         (LayoutTestController::encodeHostName):
1425         (LayoutTestController::decodeHostName):
1426         * DumpRenderTree/qt/jsobjects.h:
1427
1428 2007-10-09  Lars Knoll  <lars@trolltech.com>
1429
1430         Reviewed by Simon.
1431
1432         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
1433
1434         * DumpRenderTree/qt/DumpRenderTree.cpp:
1435         (WebCore::WebPage::createFrame):
1436         (WebCore::DumpRenderTree::DumpRenderTree):
1437         (WebCore::DumpRenderTree::titleChanged):
1438         * DumpRenderTree/qt/DumpRenderTree.h:
1439         * DumpRenderTree/qt/jsobjects.cpp:
1440         (LayoutTestController::reset):
1441         * DumpRenderTree/qt/jsobjects.h:
1442
1443 2007-10-09  Lars Knoll  <lars@trolltech.com>
1444
1445         Reviewed by Simon.
1446
1447         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
1448
1449         * DumpRenderTree/qt/DumpRenderTree.h:
1450         * DumpRenderTree/qt/jsobjects.cpp:
1451         (LayoutTestController::clearBackForwardList):
1452         * DumpRenderTree/qt/jsobjects.h:
1453
1454 2007-10-09  Lars Knoll  <lars@trolltech.com>
1455
1456         Reviewed by Simon.
1457
1458         make --git-reviewer work again.
1459
1460         * Scripts/prepare-ChangeLog:
1461
1462 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
1463
1464         Rubber stamped by Eric.
1465
1466         Connect to the "hovering-over-link" signal emitted by WebKitPage and
1467         show the current link inside the statusbar.
1468         This shows how to make use of this signal and allows to easily test
1469         http://bugs.webkit.org/show_bug.cgi?id=15299.
1470
1471         * GtkLauncher/main.cpp:
1472         (hoveringOverLink):
1473         (main):
1474
1475 2007-10-05  Lars Knoll  <lars@trolltech.com>
1476
1477         add proper error messages to the FrameLoaderClient.
1478         Implement ChromeClientQt::closeWindowSoon and
1479         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
1480         Some fixes in DRT to make it work correctly with multiple windows.
1481
1482         Reviewed by Maciej.
1483
1484         * DumpRenderTree/qt/DumpRenderTree.cpp:
1485         (WebCore::DumpRenderTree::DumpRenderTree):
1486         (WebCore::DumpRenderTree::createWindow):
1487         (WebCore::DumpRenderTree::windowCount):
1488         * DumpRenderTree/qt/DumpRenderTree.h:
1489         * DumpRenderTree/qt/jsobjects.cpp:
1490         (LayoutTestController::maybeDump):
1491         (LayoutTestController::windowCount):
1492         * DumpRenderTree/qt/jsobjects.h:
1493
1494 2007-10-05  Lars Knoll  <lars@trolltech.com>
1495
1496         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
1497         Add support for layoutTextController.setCanOpenWindows() to DRT
1498         fixing another 2 test cases in fast/dom/Window.
1499
1500         Reviewed by Maciej.
1501
1502         * DumpRenderTree/qt/DumpRenderTree.cpp:
1503         (WebCore::WebPage::WebPage):
1504         (WebCore::WebPage::createWindow):
1505         (WebCore::DumpRenderTree::resetJSObjects):
1506         (WebCore::DumpRenderTree::createWindow):
1507         * DumpRenderTree/qt/DumpRenderTree.h:
1508         * DumpRenderTree/qt/DumpRenderTree.pro:
1509         * DumpRenderTree/qt/jsobjects.cpp:
1510         (LayoutTestController::LayoutTestController):
1511         (LayoutTestController::reset):
1512         * DumpRenderTree/qt/jsobjects.h:
1513         * DumpRenderTree/qt/main.cpp:
1514         * DumpRenderTree/qt/testplugin.cpp: Added.
1515         * DumpRenderTree/qt/testplugin.h: Added.
1516
1517 2007-10-04  Sam Weinig  <sam@webkit.org>
1518
1519         Rubber stamped by Adam.
1520
1521         Remove empty directories.
1522
1523         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
1524         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
1525
1526 2007-10-03  Darin Adler  <darin@apple.com>
1527
1528         Reviewed by Adam.
1529
1530         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
1531         we find the internal libraries in the libraries directory. This
1532         is helpful for Safari team engineers at Apple.
1533
1534 2007-10-03  Adam Roben  <aroben@apple.com>
1535
1536         Update the location of AHEM___.TTF after r25968
1537
1538         Reviewed by Sam.
1539
1540         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1541
1542 2007-10-03  Alp Toker  <alp@atoker.com>
1543
1544         Reviewed by Adam.
1545
1546         http://bugs.webkit.org/show_bug.cgi?id=14726
1547         [gtk] API design. Mapping the WebView delegates to signals.
1548
1549         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
1550
1551         * GtkLauncher/main.cpp:
1552         (goToURLBarText):
1553         (titleChanged):
1554         (progressChanged):
1555         (menuMainBackCallback):
1556         (menuMainForwardCallback):
1557         (main):
1558
1559 2007-10-03  Lars Knoll  <lars@trolltech.com>
1560
1561         Reviewed by Rob.
1562
1563         This fixes --strict mode in run-webkit-tests again after
1564         the platform dependent test results have been moved.
1565
1566         * Scripts/run-webkit-tests:
1567
1568 2007-10-03  Lars Knoll  <lars@trolltech.com>
1569
1570         Reviewed by bdash.
1571
1572         remove the hack in run-webkit-tests that forced text only test
1573         to be taken from the platform independent dir. It was only left
1574         there from early days.
1575
1576         Remove platform dependent results for tests that are text only nowadays,
1577         and add one platform dependent result for a text only test that requires it.
1578
1579         * Scripts/run-webkit-tests:
1580
1581 2007-10-03  Lars Knoll  <lars@trolltech.com>
1582
1583         Reviewed by olliej.
1584
1585         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
1586
1587         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
1588         (WebCore::WebFrame::WebFrame):
1589         (WebCore::WebPage::WebPage):
1590         (WebCore::WebPage::createFrame):
1591         (WebCore::WebPage::javaScriptAlert):
1592         (WebCore::WebPage::javaScriptConsoleMessage):
1593         (WebCore::DumpRenderTree::DumpRenderTree):
1594         (WebCore::DumpRenderTree::~DumpRenderTree):
1595         (WebCore::DumpRenderTree::open):
1596         (WebCore::DumpRenderTree::readStdin):
1597         (WebCore::DumpRenderTree::resetJSObjects):
1598         (WebCore::DumpRenderTree::initJSObjects):
1599         (WebCore::DumpRenderTree::dumpFramesAsText):
1600         (WebCore::DumpRenderTree::dump):
1601         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
1602         (WebCore::DumpRenderTree::layoutTestController):
1603         (WebCore::DumpRenderTree::eventSender):
1604         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
1605         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
1606         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
1607         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
1608         (HackWebFrame::mousePressEvent):
1609         (HackWebFrame::mouseReleaseEvent):
1610         (HackWebFrame::mouseMoveEvent):
1611         (HackWebFrame::HackWebFrame):
1612         (HackWebFrame::~HackWebFrame):
1613         (LayoutTestController::LayoutTestController):
1614         (LayoutTestController::reset):
1615         (LayoutTestController::maybeDump):
1616         (LayoutTestController::waitUntilDone):
1617         (LayoutTestController::notifyDone):
1618         (LayoutTestController::dumpEditingCallbacks):
1619         (LayoutTestController::queueReload):
1620         (LayoutTestController::provisionalLoad):
1621         (LayoutTestController::timerEvent):
1622         (EventSender::EventSender):
1623         (EventSender::mouseDown):
1624         (EventSender::mouseUp):
1625         (EventSender::mouseMoveTo):
1626         (EventSender::leapForward):
1627         (EventSender::keyDown):
1628         (EventSender::frameUnderMouse):
1629         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
1630         (LayoutTestController::isLoading):
1631         (LayoutTestController::setLoading):
1632         (LayoutTestController::shouldDumpAsText):
1633         (LayoutTestController::shouldDumpChildrenAsText):
1634         (LayoutTestController::shouldWaitUntilDone):
1635         (LayoutTestController::dumpAsText):
1636         (LayoutTestController::dumpChildFramesAsText):
1637         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
1638         (messageHandler):
1639         (crashHandler):
1640         (main):
1641         * Scripts/run-webkit-tests:
1642
1643 2007-10-03  Mark Rowe  <mrowe@apple.com>
1644
1645         Reviewed by Alp Toker.
1646
1647         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
1648         should take precedence over QTDIR when determining which port we are working with.
1649
1650         * Scripts/webkitdirs.pm:
1651
1652 2007-10-02  Adam Roben  <aroben@apple.com>
1653
1654         Add keychain to the list of default packages to install
1655
1656         Rubberstamped by Sam.
1657
1658         * CygwinDownloader/cygwin-downloader.py:
1659         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
1660
1661 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
1662
1663         Reviewed by Adam.
1664
1665         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
1666         Also makes WebCore regression test case logic work when using git.
1667
1668         * Scripts/prepare-ChangeLog:
1669         (reviewerAndDescriptionForGitCommit): Added.
1670
1671 2007-10-02  Lars Knoll  <lars@trolltech.com>
1672
1673         Reviewed by bdash.
1674
1675         Add API to retrieve the frame name from QWebFrame.
1676         Implement support for DRT::dumpChildrenAsText.
1677
1678         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1679         (WebCore::DumpRenderTree::dumpFramesAsText):
1680         (WebCore::DumpRenderTree::dump):
1681         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
1682         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1683         (LayoutTestController::LayoutTestController):
1684         (LayoutTestController::reset):
1685         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
1686
1687 2007-10-02  Lars Knoll  <lars@trolltech.com>
1688
1689         Reviewed by bdash.
1690
1691         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
1692
1693         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1694         (WebCore::DumpRenderTree::readStdin):
1695
1696 2007-10-02  Mark Rowe  <mrowe@apple.com>
1697
1698         Reviewed by Oliver.
1699
1700         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
1701
1702         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
1703         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
1704
1705 2007-10-02  Mark Rowe  <mrowe@apple.com>
1706
1707         Rubber-stamped by Maciej.
1708
1709         Configuration changes from build.webkit.org.  The major change is refactoring to work
1710         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
1711         last few weeks.
1712
1713         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1714         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
1715         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
1716         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
1717         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
1718         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
1719         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
1720         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
1721
1722 2007-10-02  Lars Knoll  <lars@trolltech.com>
1723
1724         Reviewed by Maciej.
1725
1726         Add support for eventSender.mouseMove to DRT.
1727         Fixes fast/css/hover-affects-child.html
1728
1729         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1730         (EventSender::mouseMoveTo):
1731
1732 2007-10-01  Mark Rowe  <mrowe@apple.com>
1733
1734         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
1735
1736 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
1737
1738         Reviewed by Hyatt.
1739
1740         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
1741
1742         * Scripts/svn-apply:
1743         (gitdiff2svndiff): Ignore lines beginning with "new file".
1744         * Scripts/svn-unapply:
1745         (gitdiff2svndiff): Ditto.
1746
1747 2007-09-30  George Staikos  <staikos@kde.org>
1748
1749         Qt build fix (Mac OS X specific)
1750
1751         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
1752
1753 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
1754
1755         Reviewed by Mark.
1756
1757         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
1758         Remove Bakefiles from svn.
1759
1760         * GtkLauncher/Bakefiles.bkgen: Removed.
1761         * GtkLauncher/ENV: Removed.
1762         * GtkLauncher/gdklauncher.bkl: Removed.
1763         * GtkLauncher/mk: Removed.
1764         * Scripts/regenerate-makefiles: Removed.
1765
1766 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
1767
1768         Reviewed by John.
1769
1770         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
1771
1772         * Scripts/run-webkit-tests:
1773
1774 2007-09-26  Adam Roben  <aroben@apple.com>
1775
1776         Make not finding an installed WebKit non-fatal
1777
1778         What really matters is that we are able to load WebKit and its
1779         dependencies, not whether we think we've found an installed WebKit.
1780
1781         Reviewed by Sam.
1782
1783         * WebKitInitializer/WebKitInitializer.cpp:
1784         (getWebViewCLSID): Use new LOG_WARNING macro.
1785         (getInstalledWebKitDirectory): Ditto.
1786         (initializeWebKit): Don't die if we didn't find an installed WebKit,
1787         and use new macros.
1788         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
1789
1790 2007-09-26  Adam Roben  <aroben@apple.com>
1791
1792         Committed this file before saving it
1793
1794         * WebKitInitializer/debug_internal.vsprops:
1795
1796 2007-09-26  Adam Roben  <aroben@apple.com>
1797
1798         Load WebKit and its dependencies manually so they come from DllDirectory
1799
1800         I had to change WebKitInitializer to use malloc/free instead of
1801         new/delete to avoid pulling in WebKit (and its dependencies) early
1802         through use of fastMalloc.
1803
1804         Reviewed by Oliver.
1805
1806         * WebKitInitializer/WebKitInitializer.cpp:
1807         (getStringValue): Changed to use malloc/free.
1808         (getInstalledWebKitDirectory): Ditto.
1809         (initializeWebKit): Call SetDllDirectory first, then load all of
1810         WebKit's dependencies manually, finally followed by WebKit itself.
1811         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
1812         configuration to match our other projects.
1813         * WebKitInitializer/debug_internal.vsprops: Added.
1814
1815 2007-09-25  Adam Roben  <aroben@apple.com>
1816
1817         Actually define DEBUG/NDEBUG so that we load WebKit correctly
1818
1819         Rubberstamped by Sam.
1820
1821         * WebKitInitializer/WebKitInitializer.vcproj:
1822
1823 2007-09-25  Adam Roben  <aroben@apple.com>
1824
1825         Make DumpRenderTree delay-load its dependencies
1826
1827         This lets WebKitInitializer re-route the dependencies to be loaded out
1828         of the Safari installation directory.
1829
1830         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
1831         same thing), since we can't import the kCFAllocatorDefault symbol when
1832         delay-loading CoreFoundation.dll.
1833
1834         Rubberstamped by Sam.
1835
1836         * DumpRenderTree/win/DumpRenderTree.cpp:
1837         (runTest):
1838         (javaScriptThreads):
1839         * DumpRenderTree/win/DumpRenderTree.vcproj:
1840         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1841         (LayoutTestController::setWaitToDump):
1842
1843 2007-09-25  Adam Roben  <aroben@apple.com>
1844
1845         Pull ole32.lib into WebKitInitializer
1846
1847         Rubberstamped by Sam.
1848
1849         * WebKitInitializer/WebKitInitializer.vcproj:
1850
1851 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
1852
1853         Reviewed by Adam.
1854
1855         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
1856           LGPL'ed files contain incorrect FSF address
1857
1858         * Drosera/config.h:
1859
1860 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
1861
1862         Reviewed by Adam.
1863
1864         Make svn-apply and svn-unapply work with git-diff formatted patches.
1865
1866         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
1867         (gitdiff2svndiff): Added.
1868         * Scripts/svn-unapply: Ditto.
1869         (gitdiff2svndiff): Added.
1870
1871 2007-09-25  Adam Roben  <aroben@apple.com>
1872
1873         Pull advapi32.lib into WebKitInitializer
1874
1875         This is needed to get the registry functions we use.
1876
1877         Rubberstamped by Sam.
1878
1879         * WebKitInitializer/WebKitInitializer.vcproj:
1880
1881 2007-09-25  Adam Roben  <aroben@apple.com>
1882
1883         Add python and rsync to cygwin-downloader
1884
1885         Our build slaves need this, and it can't hurt for everyone else to
1886         have it, too.
1887
1888         Reviewed by Sam.
1889
1890         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
1891         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
1892
1893 2007-09-25  Adam Roben  <aroben@apple.com>
1894
1895         Add WebKitInitializer and use it in DumpRenderTree
1896
1897         WebKitInitializer is a static library that has one function,
1898         initializeWebKit(). This registers WebKit and sets up the DLL search
1899         path so that WebKit's dependencies that are installed with Safari can
1900         be found.
1901
1902         Reviewed by Sam.
1903
1904         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
1905         DumpRenderTree depend on it.
1906         * DumpRenderTree/win/DumpRenderTree.cpp:
1907         (initialize): Call initializeWebKit.
1908         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
1909         WebKitInitializer.lib.
1910         * WebKitInitializer/WebKitInitializer.cpp: Added.
1911         (getStringValue):
1912         (getWebViewCLSID):
1913         (getInstalledWebKitDirectory):
1914         (initializeWebKit):
1915         * WebKitInitializer/WebKitInitializer.h: Added.
1916         * WebKitInitializer/WebKitInitializer.vcproj: Added.
1917         * WebKitInitializer/debug.vsprops: Added.
1918         * WebKitInitializer/release.vsprops: Added.
1919
1920 2007-09-25  Adam Roben  <aroben@apple.com>
1921
1922         Make run-webkit-tests respect set-webkit-configuration
1923
1924         Reviewed by Sam.
1925
1926         * Scripts/run-webkit-tests: Initialize $configuration to whatever
1927         set-webkit-configuration was last set to.
1928
1929 2007-09-25  Mark Rowe  <mrowe@apple.com>
1930
1931         Rubber-stamped by Eric.
1932
1933         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
1934         This makes it possible to automate nightly builds for the feature-branch.
1935
1936 2007-09-25  Adam Roben  <aroben@apple.com>
1937
1938         A couple of fixes/enhancements to update-webkit-*-libs
1939
1940         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
1941         to tell update-webkit-support-libraries where it should find the
1942         WebKitSupportLibrary.zip file you downloaded.
1943
1944         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
1945         Windows-style path.
1946
1947         Reviewed by Sam.
1948
1949         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
1950         to $auxiliaryLibsURL and removed an irrelevant comment.
1951         * Scripts/update-webkit-support-libs:
1952
1953 2007-09-25  Adam Treat  <treat@kde.org>
1954
1955         Reviewed by Simon and Lars.
1956
1957         Refactors and cleans up Qt DRT member variable names, member variable
1958         initialization, style fixes and general code cleanup.
1959
1960         Adds queueReload slot to LayoutTestController that some tests require.
1961
1962         Subclasses QWebFrame to make sure that all frames have an associated
1963         LayoutTestController JS window object.
1964
1965         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
1966         aren't dumped twice.
1967
1968         EOF fixes.
1969
1970         Together, this patch fixes some 20+ layout tests in QtWebKit.
1971
1972         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
1973         (WebCore::WebFrame::WebFrame):
1974         (WebCore::WebPage::WebPage):
1975         (WebCore::WebPage::createFrame):
1976         (WebCore::DumpRenderTree::DumpRenderTree):
1977         (WebCore::DumpRenderTree::open):
1978         (WebCore::DumpRenderTree::readStdin):
1979         (WebCore::DumpRenderTree::initJSObjects):
1980         (WebCore::DumpRenderTree::dump):
1981         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
1982         (WebCore::DumpRenderTree::layoutTestController):
1983         (WebCore::DumpRenderTree::eventSender):
1984         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
1985         (LayoutTestController::LayoutTestController):
1986         (LayoutTestController::reset):
1987         (LayoutTestController::maybeDump):
1988         (LayoutTestController::waitUntilDone):
1989         (LayoutTestController::notifyDone):
1990         (LayoutTestController::queueReload):
1991         (LayoutTestController::provisionalLoad):
1992         (EventSender::EventSender):
1993         (EventSender::mouseDown):
1994         (EventSender::mouseUp):
1995         (EventSender::mouseMoveTo):
1996         (EventSender::frameUnderMouse):
1997         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
1998         (LayoutTestController::isLoading):
1999         (LayoutTestController::setLoading):
2000         (LayoutTestController::dumpAsText):
2001         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
2002         (main):
2003
2004 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2005
2006
2007         - Reverted an accidentally checked in file.
2008
2009         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
2010
2011 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
2012         Reviewed by Sam.
2013
2014         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
2015
2016         * DumpRenderTree/win/DumpRenderTree.vcproj:
2017         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2018
2019 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
2020
2021         Rubber stamped by Adam.
2022
2023         * GdkLauncher: Removed.
2024         * GdkLauncher/Bakefiles.bkgen: Removed.
2025         * GdkLauncher/ENV: Removed.
2026         * GdkLauncher/GdkLauncher.pro: Removed.
2027         * GdkLauncher/gdklauncher.bkl: Removed.
2028         * GdkLauncher/main.cpp: Removed.
2029         * GdkLauncher/mk: Removed.
2030         * GdkLauncher/simple.svg: Removed.
2031         * GdkLauncher/text.html: Removed.
2032         * GtkLauncher: Added.
2033         * GtkLauncher/GdkLauncher.pro: Removed.
2034         * GtkLauncher/GtkLauncher.pro: Added.
2035         * GtkLauncher/main.cpp:
2036         (updateWindowTitle):
2037         (main):
2038         * Scripts/build-webkit:
2039         * Scripts/regenerate-makefiles:
2040         * Scripts/run-javascriptcore-tests:
2041         * Scripts/run-launcher:
2042         * Scripts/run-webkit-tests:
2043         * Scripts/webkitdirs.pm:
2044
2045 2007-09-21  Timothy Hatcher  <timothy@apple.com>
2046
2047         Reviewed by Darin.
2048
2049         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
2050
2051         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
2052         This is tested by plugins/root-object-premature-delete-crash.html.
2053
2054         * DumpRenderTree/mac/ObjCController.m:
2055         (-[ObjCController accessStoredWebScriptObject]):
2056
2057 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
2058
2059         Reviewed by Oliver.
2060
2061         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
2062
2063         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2064         (FrameLoadDelegate::FrameLoadDelegate):
2065
2066 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
2067
2068         Reviewed by Adam.
2069
2070         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
2071         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
2072
2073         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
2074         Now isQt() and isGdk() use global variables that are only set once.
2075
2076         An array of all the parameters is now given to build-dumprender which includes
2077         the platform on linux.
2078
2079         * Scripts/build-dumprendertree:
2080         * Scripts/run-webkit-tests:
2081         * Scripts/webkitdirs.pm:
2082
2083 2007-09-19  Adam Roben  <aroben@apple.com>
2084
2085         Rubberstamped by Hyatt.
2086
2087         * Spinneret: Removed.
2088
2089 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
2090
2091         Reviewed by David Kilzer.
2092
2093         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
2094
2095 2007-09-18  Sam Weinig  <sam@webkit.org>
2096
2097         Add JSRetainPtr.h #include to fix some builds.
2098
2099         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2100
2101 2007-09-18  Mike Hommey  <glandium@debian.org>
2102
2103         Reviewed by Adam.
2104
2105         * Scripts/prepare-ChangeLog:
2106         - Properly parse GECOS field.
2107         - Use git configuration for user name and email when appropriate.
2108
2109 2007-09-17  Sam Weinig  <sam@webkit.org>
2110
2111         Build fix.
2112
2113         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2114
2115 2007-09-17  Sam Weinig  <sam@webkit.org>
2116
2117         Reviewed by Adam Roben.
2118
2119         Share more code between mac and windows DRT.
2120             - GCController is now shared.
2121             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
2122
2123         * DumpRenderTree/GCController.cpp:
2124         * DumpRenderTree/win/DumpRenderTree.cpp:
2125         * DumpRenderTree/win/DumpRenderTree.vcproj:
2126         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
2127         (FrameLoadDelegate::FrameLoadDelegate):
2128         (FrameLoadDelegate::~FrameLoadDelegate):
2129         (FrameLoadDelegate::windowScriptObjectAvailable):
2130         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
2131         * DumpRenderTree/win/GCController.cpp: Removed.
2132         * DumpRenderTree/win/GCController.h: Removed.
2133         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
2134         (GCController::collect):
2135         (GCController::collectOnAlternateThread):
2136         (GCController::getJSObjectCount):
2137         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
2138         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
2139
2140 2007-09-17  Sam Weinig  <sam@webkit.org>
2141
2142         Reviewed by Adam Roben.
2143
2144         Begin sharing code between mac and windows DRT.
2145             - both now share LayoutTestController.h/cpp and implement platform dependant
2146               operations in LayoutTestControllerMac/Win.
2147             - DumpRenderTree.h is now shared.
2148             - WorkQueue and WorkQueueItem are also shared.
2149
2150         * DumpRenderTree/DumpRenderTree.h:
2151         * DumpRenderTree/LayoutTestController.cpp:
2152         * DumpRenderTree/win/DumpRenderTree.cpp:
2153         (displayWebView):
2154         (dumpFrameScrollPosition):
2155         (dumpFramesAsText):
2156         (dump):
2157         (runTest):
2158         * DumpRenderTree/win/DumpRenderTree.h: Removed.
2159         * DumpRenderTree/win/DumpRenderTree.vcproj:
2160         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
2161         * DumpRenderTree/win/EditingDelegate.cpp:
2162         (EditingDelegate::shouldBeginEditingInDOMRange):
2163         (EditingDelegate::shouldEndEditingInDOMRange):
2164         (EditingDelegate::shouldInsertNode):
2165         (EditingDelegate::shouldInsertText):
2166         (EditingDelegate::shouldDeleteDOMRange):
2167         (EditingDelegate::shouldChangeSelectedDOMRange):
2168         (EditingDelegate::shouldApplyStyle):
2169         (EditingDelegate::shouldChangeTypingStyle):
2170         (EditingDelegate::doPlatformCommand):
2171         (EditingDelegate::webViewDidBeginEditing):
2172         (EditingDelegate::webViewDidChange):
2173         (EditingDelegate::webViewDidEndEditing):
2174         (EditingDelegate::webViewDidChangeTypingStyle):
2175         (EditingDelegate::webViewDidChangeSelection):
2176         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
2177         * DumpRenderTree/win/LayoutTestController.h: Removed.
2178         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
2179         (LayoutTestController::addDisallowedURL):
2180         (LayoutTestController::clearBackForwardList):
2181         (LayoutTestController::copyDecodedHostName):
2182         (LayoutTestController::copyEncodedHostName):
2183         (LayoutTestController::display):
2184         (LayoutTestController::keepWebHistory):
2185         (LayoutTestController::notifyDone):
2186         (LayoutTestController::queueBackNavigation):
2187         (LayoutTestController::queueForwardNavigation):
2188         (jsStringRefToWString):
2189         (LayoutTestController::queueLoad):
2190         (LayoutTestController::queueReload):
2191         (LayoutTestController::queueScript):
2192         (LayoutTestController::setAcceptsEditing):
2193         (LayoutTestController::setCustomPolicyDelegate):
2194         (LayoutTestController::setMainFrameIsFirstResponder):
2195         (LayoutTestController::setTabKeyCyclesThroughElements):
2196         (LayoutTestController::setUseDashboardCompatibilityMode):
2197         (LayoutTestController::setUserStyleSheetEnabled):
2198         (LayoutTestController::setUserStyleSheetLocation):
2199         (LayoutTestController::setWindowIsKey):
2200         (waitUntilDoneWatchdogFired):
2201         (LayoutTestController::setWaitToDump):
2202         (LayoutTestController::windowCount):
2203         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
2204         (FrameLoadDelegate::didReceiveTitle):
2205         (FrameLoadDelegate::processWork):
2206         (FrameLoadDelegate::locationChangeDone):
2207         (FrameLoadDelegate::windowScriptObjectAvailable):
2208         * DumpRenderTree/win/WorkQueue.cpp: Removed.
2209         * DumpRenderTree/win/WorkQueue.h: Removed.
2210         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
2211         * DumpRenderTree/win/WorkQueueItem.h: Removed.
2212         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
2213         (jsStringRefToWString):
2214         (LoadItem::invoke):
2215         (ScriptItem::invoke):
2216
2217 2007-09-17  Sam Weinig  <sam@webkit.org>
2218
2219         Reviewed by Adam Roben.
2220
2221         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
2222
2223         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
2224         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
2225         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
2226         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
2227         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
2228         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
2229         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
2230         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
2231         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
2232         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
2233         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
2234         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
2235         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
2236         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
2237         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
2238         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
2239         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
2240         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
2241         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
2242         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
2243         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
2244         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
2245         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
2246         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
2247         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
2248         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
2249         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
2250         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
2251         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
2252         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
2253         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
2254         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
2255         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
2256         * DumpRenderTree/win: Added.
2257         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
2258         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
2259         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
2260         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
2261         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
2262         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
2263         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
2264         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
2265         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
2266         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
2267         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
2268         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
2269         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
2270         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2271         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
2272         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
2273         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
2274         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
2275         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2276         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2277         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
2278         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2279         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
2280         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
2281         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
2282         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
2283
2284 2007-09-15  Mark Rowe  <mrowe@apple.com>
2285
2286         Build fix for DumpRenderTree.
2287
2288         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
2289
2290 2007-09-14  Sam Weinig  <sam@webkit.org>
2291
2292         Rubber stamped by Adam Roben.
2293
2294         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
2295           - The UIDelegate was put into a new file while the FrameLoadDelegate was
2296             kept in the WaitUntilDoneDelegate file for the time being.
2297
2298         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
2299         (main):
2300         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
2301         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
2302         (UIDelegate::QueryInterface):
2303         (UIDelegate::AddRef):
2304         (UIDelegate::Release):
2305         (UIDelegate::hasCustomMenuImplementation):
2306         (UIDelegate::setFrame):
2307         (UIDelegate::webViewFrame):
2308         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2309         (UIDelegate::webViewAddMessageToConsole):
2310         (UIDelegate::doDragDrop):
2311         (UIDelegate::webViewGetDlgCode):
2312         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
2313         (UIDelegate::UIDelegate):
2314         (UIDelegate::createWebViewWithRequest):
2315         (UIDelegate::webViewShow):
2316         (UIDelegate::webViewClose):
2317         (UIDelegate::webViewFocus):
2318         (UIDelegate::webViewUnfocus):
2319         (UIDelegate::webViewFirstResponder):
2320         (UIDelegate::makeFirstResponder):
2321         (UIDelegate::setStatusText):
2322         (UIDelegate::webViewStatusText):
2323         (UIDelegate::webViewAreToolbarsVisible):
2324         (UIDelegate::setToolbarsVisible):
2325         (UIDelegate::webViewIsStatusBarVisible):
2326         (UIDelegate::setStatusBarVisible):
2327         (UIDelegate::webViewIsResizable):
2328         (UIDelegate::setResizable):
2329         (UIDelegate::setContentRect):
2330         (UIDelegate::webViewContentRect):
2331         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2332         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2333         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2334         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
2335         (UIDelegate::mouseDidMoveOverElement):
2336         (UIDelegate::contextMenuItemsForElement):
2337         (UIDelegate::validateUserInterfaceItem):
2338         (UIDelegate::shouldPerformAction):
2339         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
2340         (UIDelegate::willPerformDragDestinationAction):
2341         (UIDelegate::dragSourceActionMaskForPoint):
2342         (UIDelegate::willPerformDragSourceAction):
2343         (UIDelegate::contextMenuItemSelected):
2344         (UIDelegate::trackCustomPopupMenu):
2345         (UIDelegate::measureCustomMenuItem):
2346         (UIDelegate::drawCustomMenuItem):
2347         (UIDelegate::addCustomMenuDrawingData):
2348         (UIDelegate::cleanUpCustomMenuDrawingData):
2349         (UIDelegate::canTakeFocus):
2350         (UIDelegate::takeFocus):
2351         (UIDelegate::registerUndoWithTarget):
2352         (UIDelegate::removeAllActionsWithTarget):
2353         (UIDelegate::setActionTitle):
2354         (UIDelegate::undo):
2355         (UIDelegate::redo):
2356         (UIDelegate::canUndo):
2357         (UIDelegate::canRedo):
2358         (UIDelegate::webViewResizerRect):
2359         (UIDelegate::webViewDrawResizer):
2360         (UIDelegate::webViewScrolled):
2361         (UIDelegate::webViewShouldInterruptJavaScript):
2362         (UIDelegate::webViewReceivedFocus):
2363         (UIDelegate::webViewLostFocus):
2364         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
2365         (FrameLoadDelegate::QueryInterface):
2366         (FrameLoadDelegate::AddRef):
2367         (FrameLoadDelegate::Release):
2368         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2369         (FrameLoadDelegate::didCommitLoadForFrame):
2370         (FrameLoadDelegate::didReceiveTitle):
2371         (FrameLoadDelegate::processWork):
2372         (processWorkTimer):
2373         (FrameLoadDelegate::locationChangeDone):
2374         (FrameLoadDelegate::didFinishLoadForFrame):
2375         (FrameLoadDelegate::didFailLoadWithError):
2376         (FrameLoadDelegate::windowScriptObjectAvailable):
2377         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
2378         (FrameLoadDelegate::FrameLoadDelegate):
2379
2380 2007-09-14  Sam Weinig  <sam@webkit.org>
2381
2382         Reviewed by Kevin McCullough.
2383
2384         Move mac specific globals in to mac/DumpRenderTreeMac.h
2385
2386         * DumpRenderTree/DumpRenderTree.h:
2387         * DumpRenderTree/DumpRenderTree.mm: Removed.
2388         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2389         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
2390         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
2391
2392 2007-09-14  Brady Eidson  <beidson@apple.com>
2393
2394         Rubberstamped by Weinig
2395
2396         You know, Sam, some of us use case-sensitve filesystems...
2397
2398         * DumpRenderTree/DumpRenderTree.h:
2399         * DumpRenderTree/mac/UIDelegate.mm:
2400
2401 2007-09-14  Sam Weinig  <sam@webkit.org>
2402
2403         Rubber stamped by Adam Roben.
2404
2405         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
2406         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
2407
2408         * DumpRenderTree/AppleScriptController.h: Removed.
2409         * DumpRenderTree/AppleScriptController.m: Removed.
2410         * DumpRenderTree/DumpRenderTree.h:
2411         * DumpRenderTree/DumpRenderTree.mm:
2412         (startJavaScriptThreads):
2413         (stopJavaScriptThreads):
2414         (activateAhemFont):
2415         (setDefaultColorProfileToRGB):
2416         (makeLargeMallocFailSilently):
2417         (dumpFrameScrollPosition):
2418         (dumpFramesAsText):
2419         (dump):
2420         (runTest):
2421         (-[DumpRenderTreeWindow isKeyWindow]):
2422         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2423         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
2424         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
2425         * DumpRenderTree/EditingDelegate.h: Removed.
2426         * DumpRenderTree/EditingDelegate.m: Removed.
2427         * DumpRenderTree/EventSendingController.h: Removed.
2428         * DumpRenderTree/EventSendingController.m: Removed.
2429         * DumpRenderTree/FrameLoadDelegate.h: Removed.
2430         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
2431         * DumpRenderTree/GCController.mm: Removed.
2432         * DumpRenderTree/ImageDiff.m: Removed.
2433         * DumpRenderTree/LayoutTestController.cpp:
2434         (LayoutTestController::LayoutTestController):
2435         (dumpAsTextCallback):
2436         (dumpBackForwardListCallback):
2437         (dumpChildFramesAsTextCallback):
2438         (dumpChildFrameScrollPositionsCallback):
2439         (dumpDOMAsWebArchiveCallback):
2440         (dumpEditingCallbacksCallback):
2441         (dumpFrameLoadCallbacksCallback):
2442         (dumpResourceLoadCallbacksCallback):
2443         (dumpSelectionRectCallback):
2444         (dumpSourceAsWebArchiveCallback):
2445         (dumpTitleChangesCallback):
2446         (repaintSweepHorizontallyCallback):
2447         (setCallCloseOnWebViewsCallback):
2448         (setCanOpenWindowsCallback):
2449         (setCloseRemainingWindowsWhenCompleteCallback):
2450         (testRepaintCallback):
2451         (addFileToPasteboardOnDragCallback):
2452         (waitUntilDoneCallback):
2453         * DumpRenderTree/LayoutTestController.h:
2454         (LayoutTestController::dumpAsText):
2455         (LayoutTestController::setDumpAsText):
2456         (LayoutTestController::dumpBackForwardList):
2457         (LayoutTestController::setDumpBackForwardList):
2458         (LayoutTestController::dumpChildFrameScrollPositions):
2459         (LayoutTestController::setDumpChildFrameScrollPositions):
2460         (LayoutTestController::dumpChildFramesAsText):
2461         (LayoutTestController::setDumpChildFramesAsText):
2462         (LayoutTestController::dumpDOMAsWebArchive):
2463         (LayoutTestController::setDumpDOMAsWebArchive):
2464         (LayoutTestController::dumpSelectionRect):
2465         (LayoutTestController::setDumpSelectionRect):
2466         (LayoutTestController::dumpSourceAsWebArchive):
2467         (LayoutTestController::setDumpSourceAsWebArchive):
2468         (LayoutTestController::dumpTitleChanges):
2469         (LayoutTestController::setDumpTitleChanges):
2470         (LayoutTestController::dumpEditingCallbacks):
2471         (LayoutTestController::setDumpEditingCallbacks):
2472         (LayoutTestController::dumpResourceLoadCallbacks):
2473         (LayoutTestController::setDumpResourceLoadCallbacks):
2474         (LayoutTestController::dumpFrameLoadCallbacks):
2475         (LayoutTestController::setDumpFrameLoadCallbacks):
2476         (LayoutTestController::addFileToPasteboardOnDrag):
2477         (LayoutTestController::setAddFileToPasteboardOnDrag):
2478         (LayoutTestController::callCloseOnWebViews):
2479         (LayoutTestController::setCallCloseOnWebViews):
2480         (LayoutTestController::canOpenWindows):
2481         (LayoutTestController::setCanOpenWindows):
2482         (LayoutTestController::closeRemainingWindowsWhenComplete):
2483         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2484         (LayoutTestController::testRepaint):
2485         (LayoutTestController::setTestRepaint):
2486         (LayoutTestController::testRepaintSweepHorizontally):
2487         (LayoutTestController::setTestRepaintSweepHorizontally):
2488         (LayoutTestController::waitToDump):
2489         (LayoutTestController::windowIsKey):
2490         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
2491         * DumpRenderTree/NavigationController.h: Removed.
2492         * DumpRenderTree/NavigationController.m: Removed.
2493         * DumpRenderTree/ObjCController.h: Removed.
2494         * DumpRenderTree/ObjCController.m: Removed.
2495         * DumpRenderTree/ObjCPlugin.h: Removed.
2496         * DumpRenderTree/ObjCPlugin.m: Removed.
2497         * DumpRenderTree/ObjCPluginFunction.h: Removed.
2498         * DumpRenderTree/ObjCPluginFunction.m: Removed.
2499         * DumpRenderTree/PolicyDelegate.h: Removed.
2500         * DumpRenderTree/PolicyDelegate.m: Removed.
2501         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
2502         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
2503         * DumpRenderTree/TextInputController.h: Removed.
2504         * DumpRenderTree/TextInputController.m: Removed.
2505         * DumpRenderTree/UIDelegate.h: Removed.
2506         * DumpRenderTree/UIDelegate.mm: Removed.
2507         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
2508         * DumpRenderTree/mac: Added.
2509         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
2510         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
2511         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
2512         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
2513         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
2514         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
2515         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2516         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2517         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2518         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2519         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2520         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2521         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2522         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2523         (-[EditingDelegate webViewDidBeginEditing:]):
2524         (-[EditingDelegate webViewDidChange:]):
2525         (-[EditingDelegate webViewDidEndEditing:]):
2526         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2527         (-[EditingDelegate webViewDidChangeSelection:]):
2528         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
2529         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
2530         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
2531         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
2532         (-[FrameLoadDelegate init]):
2533         (-[FrameLoadDelegate dealloc]):
2534         (-[FrameLoadDelegate processWork:]):
2535         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2536         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2537         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2538         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2539         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2540         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2541         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2542         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2543         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2544         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2545         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2546         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2547         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2548         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2549         (-[FrameLoadDelegate webView:willCloseFrame:]):
2550         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2551         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2552         * DumpRenderTree/mac/GCControllerMac.mm: Copied from DumpRenderTree/GCController.mm.
2553         * DumpRenderTree/mac/ImageDiff.m: Copied from DumpRenderTree/ImageDiff.m.
2554         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Copied from DumpRenderTree/LayoutTestControllerMac.mm.
2555         (LayoutTestController::notifyDone):
2556         (LayoutTestController::setWindowIsKey):
2557         (LayoutTestController::setWaitToDump):
2558         * DumpRenderTree/mac/NavigationController.h: Copied from DumpRenderTree/NavigationController.h.
2559         * DumpRenderTree/mac/NavigationController.m: Copied from DumpRenderTree/NavigationController.m.
2560         * DumpRenderTree/mac/ObjCController.h: Copied from DumpRenderTree/ObjCController.h.
2561         * DumpRenderTree/mac/ObjCController.m: Copied from DumpRenderTree/ObjCController.m.
2562         * DumpRenderTree/mac/ObjCPlugin.h: Copied from DumpRenderTree/ObjCPlugin.h.
2563         * DumpRenderTree/mac/ObjCPlugin.m: Copied from DumpRenderTree/ObjCPlugin.m.
2564         * DumpRenderTree/mac/ObjCPluginFunction.h: Copied from DumpRenderTree/ObjCPluginFunction.h.
2565         * DumpRenderTree/mac/ObjCPluginFunction.m: Copied from DumpRenderTree/ObjCPluginFunction.m.
2566         * DumpRenderTree/mac/PolicyDelegate.h: Copied from DumpRenderTree/PolicyDelegate.h.
2567         * DumpRenderTree/mac/PolicyDelegate.mm: Copied from DumpRenderTree/PolicyDelegate.m.
2568         * DumpRenderTree/mac/ResourceLoadDelegate.h: Copied from DumpRenderTree/ResourceLoadDelegate.h.
2569         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Copied from DumpRenderTree/ResourceLoadDelegate.m.
2570         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2571         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2572         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2573         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2574         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2575         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2576         * DumpRenderTree/mac/TextInputController.h: Copied from DumpRenderTree/TextInputController.h.
2577         * DumpRenderTree/mac/TextInputController.m: Copied from DumpRenderTree/TextInputController.m.
2578         * DumpRenderTree/mac/UIDelegate.h: Copied from DumpRenderTree/UIDelegate.h.
2579         * DumpRenderTree/mac/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.mm.
2580         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
2581         (-[UIDelegate webViewFocus:]):
2582         (-[UIDelegate webView:createWebViewWithRequest:]):
2583         (-[UIDelegate webViewClose:]):
2584         * DumpRenderTree/mac/WorkQueueItemMac.mm: Copied from DumpRenderTree/WorkQueueItemMac.mm.
2585
2586 2007-09-14  Kevin McCullough  <kmccullough@apple.com>
2587
2588         Reviewed by Adam.
2589
2590         - Changing Win version of Drosera work with recent changes.
2591
2592         * Drosera/DebuggerDocument.cpp:
2593         * Drosera/DebuggerDocument.h:
2594         * Drosera/mac/DebuggerDocumentPlatform.mm:
2595         (NSStringCreateWithJSStringRef):
2596         (JSValueRefCreateWithNSString):
2597         * Drosera/win/DebuggerClient.cpp:
2598         (DebuggerClient::stepInto):
2599         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2600
2601 2007-09-13  Kevin McCullough  <kmccullough@apple.com>
2602
2603         Reviewed by Tim.
2604
2605         - Moved isPaused into the JS for efficiency and simplicity.
2606
2607         * Drosera/DebuggerDocument.cpp:
2608         (DebuggerDocument::DebuggerDocument):
2609         (DebuggerDocument::pauseCallback):
2610         (DebuggerDocument::resumeCallback):
2611         (DebuggerDocument::isPaused):
2612         (DebuggerDocument::staticFunctions):
2613         * Drosera/DebuggerDocument.h:
2614         * Drosera/console.js:
2615         * Drosera/debugger.js:
2616         * Drosera/mac/DebuggerClient.mm:
2617         (-[DebuggerClient validateUserInterfaceItem:]):
2618
2619 2007-09-13  Sam Weinig  <sam@webkit.org>
2620
2621         Rubber stamped by Darin.
2622
2623         Make DumpRenderTree more cross platform ready.
2624         - Convert GCController to use the JSCore API instead of the WebScriptObject.
2625         - Use CF types instead of NS objects.
2626         - General cleanup.
2627
2628         * DumpRenderTree/DumpRenderTree.h:
2629         * DumpRenderTree/DumpRenderTree.mm:
2630         (dumpRenderTree):
2631         (dump):
2632         (runTest):
2633         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2634         * DumpRenderTree/EditingDelegate.m:
2635         * DumpRenderTree/FrameLoadDelegate.h:
2636         * DumpRenderTree/FrameLoadDelegate.mm:
2637         (-[FrameLoadDelegate init]):
2638         (-[FrameLoadDelegate dealloc]):
2639         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2640         * DumpRenderTree/GCController.cpp: Added.
2641         (GCController::GCController):
2642         (GCController::~GCController):
2643         (collectCallback):
2644         (collectOnAlternateThreadCallback):
2645         (getJSObjectCountCallback):
2646         (GCController::makeWindowObject):
2647         (GCController::getJSClass):
2648         (GCController::staticFunctions):
2649         * DumpRenderTree/GCController.h:
2650         * DumpRenderTree/GCController.mm:
2651         (GCController::collect):
2652         (GCController::collectOnAlternateThread):
2653         (GCController::getJSObjectCount):
2654         * DumpRenderTree/LayoutTestController.cpp:
2655         (LayoutTestController::makeWindowObject):
2656         (LayoutTestController::getJSClass):
2657         * DumpRenderTree/LayoutTestController.h:
2658         * DumpRenderTree/LayoutTestControllerMac.mm:
2659         (LayoutTestController::addDisallowedURL):
2660         (waitUntilDoneWatchdogFired):
2661         (LayoutTestController::waitUntilDone):
2662         * DumpRenderTree/ResourceLoadDelegate.m:
2663         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2664
2665 2007-09-12  Sam Weinig  <sam@webkit.org>
2666
2667         Reviewed by Stephanie.
2668
2669         Fix leaks in mac DumpRenderTree.
2670
2671         * DumpRenderTree/FrameLoadDelegate.mm:
2672         (-[FrameLoadDelegate init]): Initalize in the correct order.
2673         (-[FrameLoadDelegate processWork:]): Delete WorkQueueItem's after dequeueing them.
2674         * DumpRenderTree/LayoutTestController.cpp:
2675         (decodeHostNameCallback): Put return value in a temporary JSRetainPtr to ensure it gets released.
2676         (encodeHostNameCallback): ditto.
2677         * DumpRenderTree/LayoutTestController.h:
2678         * DumpRenderTree/LayoutTestControllerMac.mm:
2679         (LayoutTestController::copyDecodedHostName): Rename function to signal that it follows the Create rule.
2680         (LayoutTestController::copyEncodedHostName): ditto
2681         (LayoutTestController::queueLoad): Use a JSRetainPtr to ensure the url gets released.
2682
2683 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2684
2685         Reviewed by Geof.
2686
2687         - Updated Leopard leak list to include a leak which appears to be fixed in 9A549 but not the version the bot is on.  This will allow us to get the bot green, but later we should remove it.
2688
2689         * Scripts/run-webkit-tests:
2690
2691 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2692
2693         Reviewed by Darin.
2694
2695         - Simplified code paths and extracted out functions to increase encapsulation.
2696
2697         * Drosera/DebuggerDocument.cpp:
2698         (DebuggerDocument::breakpointEditorHTMLCallback):
2699         (DebuggerDocument::isPausedCallback):
2700         (DebuggerDocument::pauseCallback):
2701         (DebuggerDocument::resumeCallback):
2702         (DebuggerDocument::stepIntoCallback):
2703         (DebuggerDocument::evaluateScriptCallback):
2704         (DebuggerDocument::currentFunctionStackCallback):
2705         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
2706         (DebuggerDocument::valueForScopeVariableNamedCallback):
2707         (DebuggerDocument::logCallback):
2708         * Drosera/DebuggerDocument.h:
2709         (DebuggerDocument::getPaused):
2710         * Drosera/mac/DebuggerClient.mm:
2711         (-[DebuggerClient pause:]):
2712         (-[DebuggerClient resume:]):
2713         (-[DebuggerClient stepInto:]):
2714         (-[DebuggerClient stepOver:]):
2715         (-[DebuggerClient stepOut:]):
2716         (-[DebuggerClient showConsole:]):
2717         (-[DebuggerClient closeCurrentFile:]):
2718         (-[DebuggerClient validateUserInterfaceItem:]):
2719         * Drosera/mac/DebuggerDocumentPlatform.mm: Added.
2720         (+[NSString stringOrNilFromWebScriptResult:]):
2721         (DebuggerDocument::platformPause):
2722         (DebuggerDocument::platformResume):
2723         (DebuggerDocument::platformStepInto):
2724         (DebuggerDocument::platformEvaluateScript):
2725         (DebuggerDocument::getPlatformCurrentFunctionStack):
2726         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2727         (DebuggerDocument::platformValueForScopeVariableNamed):
2728         (DebuggerDocument::platformLog):
2729         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2730
2731 2007-09-12  Sam Weinig  <sam@webkit.org>
2732
2733         Build fix for Buildbot.
2734
2735         * DumpRenderTree/DumpRenderTree.mm:
2736         (dump):
2737
2738 2007-09-12  Kevin McCullough  <kmccullough@apple.com>
2739
2740         Reviewed by Geoff.
2741
2742         - Updated the leaks list for leopard to help identify regressions.
2743
2744         * Scripts/run-webkit-tests:
2745
2746 2007-09-12  Sam Weinig  <sam@webkit.org>
2747
2748         Rubber stamped by Darin.
2749
2750         Convert the LayoutTestController to use the JSCore API instead of WebScriptObject.
2751
2752         * DumpRenderTree/DumpRenderTree.h: Re-order variables.
2753         * DumpRenderTree/DumpRenderTree.m: Removed.
2754         * DumpRenderTree/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.m.
2755         (stopJavaScriptThreads): Fix initialization.
2756         (setDefaultColorProfileToRGB): Add explicit cast from void*.
2757         (dumpRenderTree): Ditto.
2758         (runTest):
2759         Used the WorkQueue from the windows DRT instead of the old NSMutableArray one.
2760
2761         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2762         * DumpRenderTree/FrameLoadDelegate.h: Add LayoutTestController instance variable.
2763         * DumpRenderTree/FrameLoadDelegate.m: Removed.
2764         * DumpRenderTree/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.m.
2765         (-[FrameLoadDelegate init]):
2766         (-[FrameLoadDelegate dealloc]):
2767         (-[FrameLoadDelegate processWork:]):
2768         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2769         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2770         Convert to use the new JSCore based LayoutTestController and the new WorkQueue.
2771
2772         * DumpRenderTree/LayoutTestController.cpp: Added.
2773         (LayoutTestController::LayoutTestController):
2774         (LayoutTestController::~LayoutTestController):
2775         (dumpAsTextCallback):
2776         (dumpBackForwardListCallback):
2777         (dumpChildFramesAsTextCallback):
2778         (dumpChildFrameScrollPositionsCallback):
2779         (dumpDOMAsWebArchiveCallback):
2780         (dumpEditingCallbacksCallback):
2781         (dumpFrameLoadCallbacksCallback):
2782         (dumpResourceLoadCallbacksCallback):
2783         (dumpSelectionRectCallback):
2784         (dumpSourceAsWebArchiveCallback):
2785         (dumpTitleChangesCallback):
2786         (repaintSweepHorizontallyCallback):
2787         (setCallCloseOnWebViewsCallback):
2788         (setCanOpenWindowsCallback):
2789         (setCloseRemainingWindowsWhenCompleteCallback):
2790         (testRepaintCallback):
2791         (addFileToPasteboardOnDragCallback):
2792         (addDisallowedURLCallback):
2793         (clearBackForwardListCallback):
2794         (decodeHostNameCallback):
2795         (displayCallback):
2796         (encodeHostNameCallback):
2797         (keepWebHistoryCallback):
2798         (notifyDoneCallback):
2799         (queueBackNavigationCallback):
2800         (queueForwardNavigationCallback):
2801         (queueLoadCallback):
2802         (queueReloadCallback):
2803         (queueScriptCallback):
2804         (setAcceptsEditingCallback):
2805         (setCustomPolicyDelegateCallback):
2806         (setMainFrameIsFirstResponderCallback):
2807         (setTabKeyCyclesThroughElementsCallback):
2808         (setUseDashboardCompatibilityModeCallback):
2809         (setUserStyleSheetEnabledCallback):
2810         (setUserStyleSheetLocationCallback):
2811         (setWindowIsKeyCallback):
2812         (waitUntilDoneCallback):
2813         (windowCountCallback):
2814         (LayoutTestController::makeWindowObject):
2815         (LayoutTestController::getLayoutTestControllerJSClass):
2816         (LayoutTestController::staticFunctions):
2817         * DumpRenderTree/LayoutTestController.h: Replaced.
2818         * DumpRenderTree/LayoutTestController.m: Removed.
2819         * DumpRenderTree/LayoutTestControllerMac.mm: Added.
2820         (LayoutTestController::dumpAsText):
2821         (LayoutTestController::dumpBackForwardList):
2822         (LayoutTestController::dumpChildFramesAsText):
2823         (LayoutTestController::dumpChildFrameScrollPositions):
2824         (LayoutTestController::dumpDOMAsWebArchive):
2825         (LayoutTestController::dumpEditingCallbacks):
2826         (LayoutTestController::dumpFrameLoadCallbacks):
2827         (LayoutTestController::dumpResourceLoadCallbacks):
2828         (LayoutTestController::dumpSelectionRect):
2829         (LayoutTestController::dumpSourceAsWebArchive):
2830         (LayoutTestController::dumpTitleChanges):
2831         (LayoutTestController::repaintSweepHorizontally):
2832         (LayoutTestController::setCallCloseOnWebViews):
2833         (LayoutTestController::setCanOpenWindows):
2834         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2835         (LayoutTestController::testRepaint):
2836         (LayoutTestController::addFileToPasteboardOnDrag):
2837         (LayoutTestController::addDisallowedURL):
2838         (LayoutTestController::clearBackForwardList):
2839         (LayoutTestController::decodeHostName):
2840         (LayoutTestController::encodeHostName):
2841         (LayoutTestController::display):
2842         (LayoutTestController::keepWebHistory):
2843         (LayoutTestController::notifyDone):
2844         (LayoutTestController::queueBackNavigation):
2845         (LayoutTestController::queueForwardNavigation):
2846         (LayoutTestController::queueLoad):
2847         (LayoutTestController::queueReload):
2848         (LayoutTestController::queueScript):
2849         (LayoutTestController::setAcceptsEditing):
2850         (LayoutTestController::setCustomPolicyDelegate):
2851         (LayoutTestController::setMainFrameIsFirstResponder):
2852         (LayoutTestController::setTabKeyCyclesThroughElements):
2853         (LayoutTestController::setUseDashboardCompatibilityMode):
2854         (LayoutTestController::setUserStyleSheetEnabled):
2855         (LayoutTestController::setUserStyleSheetLocation):
2856         (LayoutTestController::setWindowIsKey):
2857         (+[WaitToDumpWatchdog waitUntilDoneWatchdogFired]):
2858         (LayoutTestController::waitUntilDone):
2859         (LayoutTestController::windowCount):
2860         Use the JSCore API to implement the LayoutTestController.
2861
2862         * DumpRenderTree/ObjCController.h:
2863         * DumpRenderTree/ObjCController.m:
2864         (+[ObjCController isSelectorExcludedFromWebScript:]):
2865         (+[ObjCController webScriptNameForSelector:]):
2866         (-[ObjCController accessStoredWebScriptObject]):
2867         (-[ObjCController storeWebScriptObject:]):
2868         (-[ObjCController dealloc]):
2869         (-[ObjCController invokeUndefinedMethodFromWebScript:withArguments:]):
2870         Move WebScriptObject tests to ObjCController.
2871
2872         * DumpRenderTree/UIDelegate.m: Removed.
2873         * DumpRenderTree/UIDelegate.mm: Copied from DumpRenderTree/UIDelegate.m.
2874
2875         * DumpRenderTree/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
2876         * DumpRenderTree/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
2877         * DumpRenderTree/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
2878         (WorkQueueItem::~WorkQueueItem):
2879         (LoadItem::LoadItem):
2880         (LoadItem::url):
2881         (LoadItem::target):
2882         (ScriptItem::ScriptItem):
2883         (ScriptItem::script):
2884         * DumpRenderTree/WorkQueueItemMac.mm: Added.
2885         (LoadItem::invoke):
2886         (ReloadItem::invoke):
2887         (ScriptItem::invoke):
2888         (BackForwardItem::invoke):
2889         Copy WorkQueue and WorkQueueItem from windows DRT. Changed the WorkQueueItem to use JSStringRefs instead of wstrings
2890         to avoid conversion until the last possible moment.  These changes will be merged with the windows DRT when we start
2891         sharing code.
2892
2893 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
2894
2895         Reviewed by Maciej.
2896
2897         - Updated Win side to take advantage of the platform separating changes.
2898
2899         * Drosera/DebuggerDocument.cpp:
2900         (DebuggerDocument::localScopeVariableNamesForCallFrame):
2901         * Drosera/DebuggerDocument.h:
2902         * Drosera/win/DebuggerClient.cpp:
2903         (DebuggerClient::pause):
2904         (DebuggerClient::resume):
2905         (DebuggerClient::stepInto):
2906         (DebuggerDocument::platformPause):
2907         (DebuggerDocument::platformResume):
2908         (DebuggerDocument::platformStepInto):
2909         (DebuggerDocument::platformEvaluateScript):
2910         (DebuggerDocument::getPlatformCurrentFunctionStack):
2911         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2912         (DebuggerDocument::platformValueForScopeVariableNamed):
2913         (DebuggerDocument::platformLog):
2914         * Drosera/win/DebuggerClient.h:
2915         * Drosera/win/Drosera.cpp:
2916         (Drosera::Drosera):
2917         (Drosera::windowScriptObjectAvailable):
2918         (Drosera::initWithServerName):
2919         (Drosera::switchToServerNamed):
2920         * Drosera/win/Drosera.h:
2921         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2922
2923 2007-09-11  Kevin McCullough  <kmccullough@apple.com>
2924
2925         Reviewed by Adam.
2926
2927         - Just doing the moves in a separate patch so the changes are easier to see.
2928
2929         * Drosera/win/DebuggerClient.cpp: Copied from Drosera/win/DebuggerDocumentWin.cpp.
2930         * Drosera/win/DebuggerClient.h: Copied from Drosera/win/DebuggerDocumentWin.h.
2931         * Drosera/win/DebuggerDocumentWin.cpp: Removed.
2932         * Drosera/win/DebuggerDocumentWin.h: Removed.
2933         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2934
2935 2007-09-11  Sven Herzberg  <sven@imendio.com>
2936
2937         Don't overwrite LD_LIBRARY_PATH, prepend to it. Fixes:
2938         http://bugs.webkit.org/show_bug.cgi?id=15176
2939
2940         * Scripts/run-launcher: don't replace LD_LIBRARY_PATH with
2941         $projectDir, but prepend $projectDir to LD_LIBRARY_PATH (to preserve
2942         other paths eg. from jhbuild)
2943
2944 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
2945
2946         Reviewed by Adam.
2947
2948         - Made an order-of-deletion mistake.
2949
2950         * Drosera/DebuggerDocument.h:
2951         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
2952         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
2953         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
2954         * Drosera/mac/DebuggerClient.mm:
2955         (DebuggerDocument::platformPause):
2956         (DebuggerDocument::platformResume):
2957         (DebuggerDocument::platformStepInto):
2958         (DebuggerDocument::platformEvaluateScript):
2959         (DebuggerDocument::getPlatformCurrentFunctionStack):
2960         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2961         (DebuggerDocument::platformValueForScopeVariableNamed):
2962         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2963
2964 2007-09-10  Kevin McCullough  <kmccullough@apple.com>
2965
2966         Reviewed by Darin.
2967
2968         - Renaming DebuggerDocument[platform] to DebuggerClient to be more clear.
2969
2970         * Drosera/DebuggerDocument.cpp:
2971         (DebuggerDocument::DebuggerDocument):
2972         * Drosera/DebuggerDocument.h:
2973         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2974         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2975         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2976         * Drosera/mac/DebuggerApplication.mm:
2977         (-[DebuggerApplication attach:]):
2978         * Drosera/mac/DebuggerClient.h: Copied from Drosera/mac/DebuggerDocumentMac.h.
2979         * Drosera/mac/DebuggerClient.mm: Copied from Drosera/mac/DebuggerDocumentMac.mm.
2980         (DebuggerDocument::platformPause):
2981         (DebuggerDocument::platformResume):
2982         (DebuggerDocument::platformStepInto):
2983         (DebuggerDocument::platformEvaluateScript):
2984         (DebuggerDocument::getPlatformCurrentFunctionStack):
2985         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2986         (DebuggerDocument::platformValueForScopeVariableNamed):
2987         (DebuggerDocument::platformLog):
2988         * Drosera/mac/DebuggerDocumentMac.h: Removed.
2989         * Drosera/mac/DebuggerDocumentMac.mm: Removed.
2990         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2991
2992 2007-09-09  Sam Weinig  <sam@webkit.org>
2993
2994         Reviewed by Mark Rowe.
2995
2996         Remove 'objC' prefix from methods now in the ObjCController.
2997
2998         * DumpRenderTree/ObjCController.m:
2999         (+[ObjCController isSelectorExcludedFromWebScript:]):
3000         (+[ObjCController webScriptNameForSelector:]):
3001         (-[ObjCController classNameOf:]):
3002         (-[ObjCController objectOfClass:]):
3003         (-[ObjCController identityIsEqual::]):
3004         (-[ObjCController longLongRoundTrip:]):
3005         (-[ObjCController unsignedLongLongRoundTrip:]):
3006
3007 2007-09-09  Sam Weinig  <sam@webkit.org>
3008
3009         Reviewed by Oliver.
3010
3011         Initial refactor of DumpRenderTree in preparation of making it more platform independent.
3012         - Move LayoutTestController into its own file.
3013         - Move Objective-C only functions on LayoutTestController into a new controller called the
3014           ObjCController.
3015
3016         * DumpRenderTree/DumpRenderTree.h:
3017         * DumpRenderTree/DumpRenderTree.m:
3018         (displayWebView):
3019         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3020         * DumpRenderTree/FrameLoadDelegate.m:
3021         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3022         * DumpRenderTree/LayoutTestController.h: Added.
3023         * DumpRenderTree/LayoutTestController.m: Added.
3024         (+[LayoutTestController isSelectorExcludedFromWebScript:]):
3025         (+[LayoutTestController webScriptNameForSelector:]):
3026         (-[LayoutTestController clearBackForwardList]):
3027         (-[LayoutTestController setUseDashboardCompatibilityMode:]):
3028         (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]):
3029         (-[LayoutTestController setCustomPolicyDelegate:]):
3030         (-[LayoutTestController keepWebHistory]):
3031         (-[LayoutTestController setCallCloseOnWebViews:]):
3032         (-[LayoutTestController setCanOpenWindows]):
3033         (-[LayoutTestController waitUntilDone]):
3034         (-[LayoutTestController waitUntilDoneWatchdogFired]):
3035         (-[LayoutTestController notifyDone]):
3036         (-[LayoutTestController dumpAsText]):
3037         (-[LayoutTestController addFileToPasteboardOnDrag]):
3038         (-[LayoutTestController addDisallowedURL:]):
3039         (-[LayoutTestController setUserStyleSheetLocation:]):
3040         (-[LayoutTestController setUserStyleSheetEnabled:]):
3041         (-[LayoutTestController dumpDOMAsWebArchive]):
3042         (-[LayoutTestController dumpSourceAsWebArchive]):
3043         (-[LayoutTestController dumpSelectionRect]):
3044         (-[LayoutTestController dumpTitleChanges]):
3045         (-[LayoutTestController dumpBackForwardList]):
3046         (-[LayoutTestController windowCount]):
3047         (-[LayoutTestController dumpChildFrameScrollPositions]):
3048         (-[LayoutTestController dumpChildFramesAsText]):
3049         (-[LayoutTestController dumpEditingCallbacks]):
3050         (-[LayoutTestController dumpResourceLoadCallbacks]):
3051         (-[LayoutTestController dumpFrameLoadCallbacks]):
3052         (-[LayoutTestController setWindowIsKey:]):
3053         (-[LayoutTestController setMainFrameIsFirstResponder:]):
3054         (-[LayoutTestController display]):
3055         (-[LayoutTestController testRepaint]):
3056         (-[LayoutTestController repaintSweepHorizontally]):
3057         (-[LayoutTestController invokeUndefinedMethodFromWebScript:withArguments:]):
3058         (-[LayoutTestController _addWorkForTarget:selector:arg1:arg2:]):
3059         (-[LayoutTestController _doLoad:target:]):
3060         (-[LayoutTestController _doBackOrForwardNavigation:]):
3061         (-[LayoutTestController queueBackNavigation:]):
3062         (-[LayoutTestController queueForwardNavigation:]):
3063         (-[LayoutTestController queueReload]):
3064         (-[LayoutTestController queueScript:]):
3065         (-[LayoutTestController queueLoad:target:]):
3066         (-[LayoutTestController setAcceptsEditing:]):
3067         (-[LayoutTestController setTabKeyCyclesThroughElements:]):
3068         (-[LayoutTestController storeWebScriptObject:]):
3069         (-[LayoutTestController accessStoredWebScriptObject]):
3070         (-[LayoutTestController dealloc]):
3071         (-[LayoutTestController decodeHostName:]):
3072         (-[LayoutTestController encodeHostName:]):
3073         * DumpRenderTree/ObjCController.h: Added.
3074         * DumpRenderTree/ObjCController.m: Added.
3075         (+[ObjCController isSelectorExcludedFromWebScript:]):
3076         (+[ObjCController webScriptNameForSelector:]):
3077         (-[ObjCController objCClassNameOf:]):
3078         (-[ObjCController objCObjectOfClass:]):
3079         (-[ObjCController objCIdentityIsEqual::]):
3080         (-[ObjCController objCLongLongRoundTrip:]):
3081         (-[ObjCController objCUnsignedLongLongRoundTrip:]):
3082         (-[ObjCController testWrapperRoundTripping:]):
3083
3084 2007-09-07  Sam Weinig  <sam@webkit.org>
3085
3086         Reviewed by Alice.
3087
3088         Strip trailing and leading space/newline characters from skiplist file names.
3089
3090         * Scripts/run-webkit-tests:
3091
3092 2007-09-06  Kevin McCullough  <kmccullough@apple.com>
3093
3094         Reviewed by Maciej.
3095
3096         - Changed Drosera to take advantage of the JSRetainPtr changes.
3097
3098         * Drosera/DebuggerDocument.cpp:
3099         (DebuggerDocument::breakpointEditorHTML):
3100         (DebuggerDocument::evaluateScript):
3101         (DebuggerDocument::valueForScopeVariableNamed):
3102         (DebuggerDocument::log):
3103         (DebuggerDocument::windowScriptObjectAvailable):
3104         (DebuggerDocument::toJSArray):
3105         (DebuggerDocument::callFunctionOnObject):
3106         (DebuggerDocument::logException):
3107         * Drosera/mac/DebuggerDocumentMac.mm:
3108         (-[DebuggerClientMac webView:didLoadMainResourceForDataSource:]):
3109         (-[DebuggerClientMac webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3110         (DebuggerDocument::platformEvaluateScript):
3111         (DebuggerDocument::getPlatformCurrentFunctionStack):
3112         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3113         (DebuggerDocument::platformValueForScopeVariableNamed):
3114
3115 2007-09-05  Kevin McCullough  <kmccullough@apple.com>
3116
3117         Reviewed by Adam, Sam, Darin.
3118
3119         - Separated what is platform dependant from what is not.  Creating the structure needed for Drosera for Win.
3120
3121         * Drosera/Debugger.h: Added.
3122         * Drosera/DebuggerDocument.cpp:
3123         (DebuggerDocument::breakpointEditorHTMLCallback):
3124         (DebuggerDocument::isPausedCallback):
3125         (DebuggerDocument::pauseCallback):
3126         (DebuggerDocument::resumeCallback):
3127         (DebuggerDocument::stepIntoCallback):
3128         (DebuggerDocument::evaluateScriptCallback):
3129         (DebuggerDocument::currentFunctionStackCallback):
3130         (DebuggerDocument::localScopeVariableNamesForCallFrameCallback):
3131         (DebuggerDocument::valueForScopeVariableNamedCallback):
3132         (DebuggerDocument::logCallback):
3133         (DebuggerDocument::breakpointEditorHTML):
3134         (DebuggerDocument::isPaused):
3135         (DebuggerDocument::pause):
3136         (DebuggerDocument::resume):
3137         (DebuggerDocument::stepInto):
3138         (DebuggerDocument::evaluateScript):
3139         (DebuggerDocument::currentFunctionStack):
3140         (DebuggerDocument::localScopeVariableNamesForCallFrame):
3141         (DebuggerDocument::valueForScopeVariableNamed):
3142         (DebuggerDocument::log):
3143         (DebuggerDocument::toolbarPause):
3144         (DebuggerDocument::toolbarResume):
3145         (DebuggerDocument::toolbarStepInto):
3146         (DebuggerDocument::toolbarStepOver):
3147         (DebuggerDocument::toolbarStepOut):
3148         (DebuggerDocument::toolbarShowConsole):
3149         (DebuggerDocument::toolbarCloseCurrentFile):
3150         (DebuggerDocument::updateFileSource):
3151         (DebuggerDocument::didParseScript):
3152         (DebuggerDocument::willExecuteStatement):
3153         (DebuggerDocument::didEnterCallFrame):
3154         (DebuggerDocument::willLeaveCallFrame):
3155         (DebuggerDocument::exceptionWasRaised):
3156         (DebuggerDocument::windowScriptObjectAvailable):
3157         (DebuggerDocument::toJSArray):
3158         (DebuggerDocument::callGlobalFunction):
3159         (DebuggerDocument::callFunctionOnObject):
3160         (DebuggerDocument::getDroseraJSClass):
3161         (DebuggerDocument::staticFunctions):
3162         (DebuggerDocument::logException):
3163         * Drosera/DebuggerDocument.h:
3164         (DebuggerDocument::DebuggerDocument):
3165         * Drosera/ForwardingHeaders: Added.
3166         * Drosera/ForwardingHeaders/wtf: Added.
3167         * Drosera/ForwardingHeaders/wtf/Platform.h: Added.
3168         * Drosera/config.h:
3169         * Drosera/console.html:
3170         * Drosera/console.js:
3171         * Drosera/debugger.js:
3172         * Drosera/mac/DebuggerApplication.mm:
3173         (-[DebuggerApplication attach:]):
3174         * Drosera/mac/DebuggerDocumentMac.h:
3175         * Drosera/mac/DebuggerDocumentMac.mm:
3176         (+[NSString stringOrNilFromWebScriptResult:]):
3177         (+[DebuggerClientMac log:]):
3178         (-[DebuggerClientMac initWithServerName:]):
3179         (-[DebuggerClientMac dealloc]):
3180         (-[DebuggerClientMac pause]):
3181         (-[DebuggerClientMac resume]):
3182         (-[DebuggerClientMac pause:]):
3183         (-[DebuggerClientMac resume:]):
3184         (-[DebuggerClientMac stepInto:]):
3185         (-[DebuggerClientMac stepOver:]):
3186         (-[DebuggerClientMac stepOut:]):
3187         (-[DebuggerClientMac showConsole:]):
3188         (-[DebuggerClientMac closeCurrentFile:]):
3189         (-[DebuggerClientMac validateUserInterfaceItem:]):
3190         (-[DebuggerClientMac webView:windowScriptObjectAvailable:]):
3191         (-[DebuggerClientMac webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3192         (-[DebuggerClientMac webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3193         (-[DebuggerClientMac webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3194         (-[DebuggerClientMac webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3195         (DebuggerDocument::platformPause):
3196         (DebuggerDocument::platformResume):
3197         (DebuggerDocument::platformStepInto):
3198         (DebuggerDocument::platformEvaluateScript):
3199         (DebuggerDocument::platformCurrentFunctionStack):
3200         (DebuggerDocument::platformLocalScopeVariableNamesForCallFrame):
3201         (DebuggerDocument::platformValueForScopeVariableNamed):
3202         (DebuggerDocument::platformLog):
3203         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3204
3205 2007-09-06  Sam Weinig  <sam@webkit.org>
3206
3207         Reviewed by Adam Roben.
3208
3209         Register the WebKit DLL on initialization of the DumpRenderTree.
3210
3211         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3212         (initialize):
3213
3214 2007-09-05  Sam Weinig  <sam@webkit.org>
3215
3216         Reviewed by Oliver.
3217
3218         Fix many layout test failures caused by r25364.
3219         Set text size to standand size at the begining of each test matching the mac.
3220
3221         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3222         (runTest):
3223
3224 2007-09-04  Sam Weinig  <sam@webkit.org>
3225
3226         Reviewed by Adam.
3227
3228         Fix for <rdar://problem/5382277>
3229         Implement eventSender.textZoomIn and eventSender.textZoomOut for windows DRT.
3230
3231         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp:
3232         (textZoomInCallback):
3233         (textZoomOutCallback):
3234
3235 2007-08-29  David Kilzer  <ddkilzer@apple.com>
3236
3237         Reviewed by Adam.
3238
3239         Added case-insensitivity to checks for adding regression tests.
3240
3241         * Scripts/prepare-ChangeLog:
3242         (generateFileList):
3243
3244 2007-08-28  David Kilzer  <ddkilzer@apple.com>
3245
3246         Reviewed by Maciej.
3247
3248         Ignore files in /resources/ subdirectories when creating a list of added tests.
3249
3250         * Scripts/prepare-ChangeLog:
3251         (generateFileList):
3252
3253 2007-08-27  Kevin McCullough  <kmccullough@apple.com>
3254
3255         Reviewed by John.
3256
3257         - Removed Leopard leaks list since all of those radars were fixed.
3258
3259         * Scripts/run-webkit-tests:
3260
3261 2007-08-27  Adam Roben  <aroben@apple.com>
3262
3263         Rubberstamped by Mark.
3264
3265         * Scripts/pdevenv: Pass arguments along to devenv.com.
3266
3267 2007-08-26  David Kilzer  <ddkilzer@webkit.org>
3268
3269         Reviewed by Mark Rowe.
3270
3271         Update prepare-ChangeLog to generate the datestamp in the correct timezone.
3272
3273         * Scripts/prepare-ChangeLog:
3274         (changeLogDate): Added.
3275
3276 2007-08-24  Sam Weinig  <sam@webkit.org>
3277
3278         Revert r25216 which renamed the COM DOM bindings to use Deprecated prefix.
3279
3280 2007-08-24  Sam Weinig  <sam@webkit.org>
3281
3282         Rubber-stamped by Adam Roben.
3283
3284         <rdar://problem/5434593> Deprecate current manually written COM DOM bindings in anticipation of autogeneration
3285
3286         Rename COM DOM bindings to use Deprecated prefix.
3287
3288         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3289         (dumpFramesAsText):
3290         (dump):
3291         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp:
3292         (dumpPath):
3293         (dump):
3294         (EditingDelegate::shouldBeginEditingInDOMRange):
3295         (EditingDelegate::shouldEndEditingInDOMRange):
3296         (EditingDelegate::shouldInsertNode):
3297         (EditingDelegate::shouldInsertText):
3298         (EditingDelegate::shouldDeleteDOMRange):
3299         (EditingDelegate::shouldChangeSelectedDOMRange):
3300         (EditingDelegate::shouldApplyStyle):
3301         (EditingDelegate::shouldChangeTypingStyle):
3302         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h:
3303
3304 2007-08-24  Oliver Hunt  <oliver@apple.com>
3305
3306         Reviewed by John H.
3307
3308         WebDataSource::response can legitimately have a null response, so we
3309         must check that case.
3310
3311         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp:
3312         (queueLoadCallback):
3313
3314 2007-08-23  Mitz Pettel  <mitz@webkit.org>
3315
3316         Reviewed by Darin and Adam.
3317
3318         - DumpRenderTree changes to allow testing for
3319           http://bugs.webkit.org/show_bug.cgi?id=11756
3320           REGRESSION: link targeting a frame in another window does not work
3321           <rdar://problem/5286420>
3322
3323         Use a frame group name for all WebViews created by DumpRenderTree to
3324         allow testing of cross-page frame lookup.
3325
3326         * DumpRenderTree/DumpRenderTree.m:
3327         (createWebView): Pass group name to -[WebView initWithFrame:frameName:groupName:].
3328         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3329         (main): Pass group name to WebView::initWithFrame(RECT, BSTR, BSTR).
3330
3331 2007-08-23  David Kilzer  <ddkilzer@webkit.org>
3332
3333         Reviewed by Adam.
3334
3335         Quote the $sslCertificate path in case it contains a space.
3336
3337         * Scripts/run-webkit-httpd:
3338         * Scripts/run-webkit-tests:
3339
3340 2007-08-22  Oliver Hunt  <oliver@apple.com>
3341
3342         Reviewed by John and Adam.
3343
3344         WebDataSource::response can legitimately have a null response, so we
3345         must check that case.
3346
3347         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3348         (dump):
3349
3350 2007-08-21  Kevin McCullough  <kmccullough@apple.com>
3351
3352         Reviewed by Geof.
3353
3354         - Changing the usage to be more clear.
3355
3356         * Scripts/run-testkjs:
3357
3358 2007-08-20  John Sullivan  <sullivan@apple.com>
3359
3360         Reviewed by Adam Roben
3361
3362         * DumpRenderTree/DumpRenderTree.m:
3363         (runTest):
3364         call new +[WebView _setUsesTestModeFocusRingColor:YES] so we get the same focus ring colors
3365         in layout tests on Tiger and Leopard
3366
3367 2007-08-20  Adam Roben  <aroben@apple.com>
3368
3369         Put LayoutTests after all other ChangeLogs in commit logs
3370
3371         We use "~" to sort LayoutTests after all the other ChangeLogs because
3372         "~" is the last ASCII character (other than "DEL").
3373
3374         Reviewed by Sam.
3375
3376         * Scripts/commit-log-editor:
3377
3378 2007-08-20  Adam Roben  <aroben@apple.com>
3379
3380         Detect that DRT crashed even if a crash dialog is running
3381
3382         On Windows, when DRT crashes a crash dialog commonly appears. The DRT
3383         process is still running at this point, so run-webkit-tests wouldn't
3384         detect that DRT had crashed. We now record the crash in our SIGPIPE
3385         handler so that we know if DRT crashed even if the crash dialog is up.
3386
3387         Reviewed by Sam.
3388
3389         * Scripts/run-webkit-tests:
3390         (sub catch_pipe): Set the crashed bit.
3391         (sub openDumpTool): Reset the crashed bit.
3392         (sub dumpToolDidCrash): Check the crashed bit.
3393
3394 2007-08-20  Adam Roben  <aroben@apple.com>
3395
3396         Fix Bug 15026: prepare-ChangeLog should list new tests in WebCore/ChangeLog
3397
3398         http://bugs.webkit.org/show_bug.cgi?id=15026
3399
3400         Reviewed by David Kilzer and Darin Adler.
3401
3402         * Scripts/prepare-ChangeLog:
3403         (sub isModifiedStatus): Split out from isModifiedOrAddedStatus.
3404         (sub isAddedStatus): Ditto.
3405         (sub testListForChangeLog): Added.
3406
3407 2007-08-19  Oleg Sukhodolsky  <son.two@gmail.com>
3408
3409         Reviewed by Mark.
3410
3411         -fixes http://bugs.webkit.org/show_bug.cgi?id=14632
3412
3413         * Scripts/webkitdirs.pm:
3414         qt and gtk ports now explicitly pass debug (or release) mode to qmake.
3415
3416 2007-08-17  Darin Adler  <darin@apple.com>
3417
3418         Reviewed by Oliver Hunt.
3419
3420         - don't look for Apple-style localizable strings in the GTK version of WebKit
3421
3422         * Scripts/extract-localizable-strings: Add a feature where you can pass in the
3423         name of subdirectories to skip.
3424         * Scripts/update-webkit-localizable-strings: Pass WebKit/gtk as a subdirectory
3425         to skip.
3426
3427 2007-08-17  Anders Carlsson  <andersca@apple.com>
3428
3429         Build fix.
3430
3431         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3432         (NPP_SetWindow):
3433
3434 2007-08-17  Anders Carlsson  <andersca@apple.com>
3435
3436         Reviewed by Dave Hyatt.
3437
3438         <rdar://problem/5379040>
3439         REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes
3440
3441         Add a way for the plug-in to dump the width and height when it gets its  NPP_SetWindow call.
3442
3443         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
3444         (pluginAllocate):
3445         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3446         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
3447         (NPP_New):
3448         (NPP_SetWindow):
3449
3450 2007-08-16  Alice Liu  <alice.liu@apple.com>
3451
3452         Reviewed by Maciej.
3453
3454         Fix <rdar://problem/5360135> REGRESSION (Leopard only): editing/selection/5354455-1.html is causing subsequent tests to fail
3455
3456         * DumpRenderTree/DumpRenderTree.m:
3457         (createWebView):
3458         Create a DumpRenderTreeWindow instead of a NSWindow, now that a DumpRenderTreeWindow no longer poses as a NSWindow.
3459         (dumpRenderTree):
3460         Don't pose as a NSWindow, since when the spelling panel gets created, it creates an NSWindow which ends up creating a DumpRenderTreeWindow.
3461
3462 2007-08-16  Kevin McCullough  <kmccullough@apple.com>
3463
3464         Reviewed by Adam.
3465
3466         - Added tests for regressions in other components.  In this case we also need to add a skipped list for Tiger since this functionality didn't exist in 10.4.
3467
3468         * Scripts/run-webkit-tests:
3469
3470 2007-08-15  Timothy Hatcher  <timothy@apple.com>
3471
3472         Look for the new Xcode 3 preference key (PBXApplicationwideBuildSettings) for the global build locations.
3473         The value of PBXApplicationwideBuildSettings is a dictionary, so we have to pull the SYMROOT out of it.
3474
3475         Also pass xcodebuild OBJROOT with the same value as SYMROOT if we fallback to the default WebKitBuild,
3476         this prevents making "build" directories in each project folder.
3477
3478         * Scripts/webkitdirs.pm:
3479
3480 2007-08-14  Geoffrey Garen  <ggaren@apple.com>
3481
3482         Reviewed by Kevin Mccullough.
3483
3484         Removed special case that didn't belong. (It would allow a global
3485         initializer to sneak into production builds, which would cause a
3486         system-wide performance regression on Mac OS X.)
3487
3488         * Scripts/check-for-global-initializers:
3489
3490 2007-08-14  Justin Garcia  <justin.garcia@apple.com>
3491
3492         Reviewed by Tim.
3493
3494         <rdar://problem/5408255> REGRESSION: In Mail, clicking the containing element's UI closebox doesn't delete element
3495
3496         * DumpRenderTree/EditingDelegate.m:
3497         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Added, return YES
3498         only for elements with the class needsDeletionUI.
3499
3500 2007-08-14  David Kilzer  <ddkilzer@webkit.org>
3501
3502         Reviewed by Darin.
3503
3504         - fix http://bugs.webkit.org/show_bug.cgi?id=14965
3505           svn-create-patch uses deprecated tail switch
3506
3507         * Scripts/svn-create-patch: Use 'tail -n +3' instead of 'tail +3'.
3508
3509 2007-08-13  Sam Weinig  <sam@webkit.org>
3510
3511         Reviewed by Adam Roben.
3512
3513         Use the cygwin specific Apache config file under cygwin.
3514
3515         * Scripts/run-webkit-httpd:
3516
3517 2007-08-12  Adam Roben  <aroben@apple.com>
3518
3519         Generate results for new tests in a more logical location
3520
3521         New platform-specific tests always have their results generated right
3522         next to the test. New cross-platform tests will have their results
3523         generated a) in the cross-platform directory, if they are text-only,
3524         or b) in the least-specific platform directory, if they are render
3525         tree dumps.
3526
3527         Reviewed by Lars.
3528
3529         * Scripts/run-webkit-tests:
3530
3531 2007-08-12  Adam Roben  <aroben@apple.com>
3532
3533         Print the actual directory where new results are generated.
3534
3535         Before, we were printing an unpredictable, context-specific substring
3536         of the directory.
3537
3538         Reviewed by Lars.
3539
3540         * Scripts/run-webkit-tests:
3541
3542 2007-08-12  Adam Roben  <aroben@apple.com>
3543
3544         Factor some common code into a stripExtension() subroutine.
3545
3546         Reviewed by Lars.
3547
3548         * Scripts/run-webkit-tests: Also removed some debugging output.
3549
3550 2007-08-11  Matt Lilek  <pewtermoose@gmail.c