WebKitTools/ChangeLog

   1 2007-12-14  Anders Carlsson  <andersca@apple.com>
   2
   3         Reviewed by Darin and Geoff.
   4
   5         <rdar://problem/5619295>
   6         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
   7
   8         Add property getting methods to the plug-in.
   9
  10         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
  11         (pluginInvoke):
  12
  13 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
  14
  15         Reviewed by Darin.
  16
  17         - Layout test fix for mac. When dumped to the console local file paths
  18         now only show the name of the resource not the whole path.  This is to
  19         make the results machine and OS independent.
  20
  21         * DumpRenderTree/mac/UIDelegate.mm:
  22         (-[UIDelegate webView:addMessageToConsole:]):
  23
  24 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
  25
  26         Reviewed by Adam.
  27
  28         - Layout tests fix.  We need a way to remove machine-dependent
  29         information from paths in layout test results. The UIDelegate now does
  30         this.
  31
  32         * DumpRenderTree/DumpRenderTree.h:
  33         * DumpRenderTree/win/DumpRenderTree.cpp:
  34         (urlSuitableForTestResult):
  35         * DumpRenderTree/win/DumpRenderTreeWin.h:
  36         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
  37         * DumpRenderTree/win/UIDelegate.cpp:
  38         (UIDelegate::webViewAddMessageToConsole):
  39
  40 2007-12-13  Alp Toker  <alp@atoker.com>
  41
  42         Build fix for DRT breakage introduced in r28690.
  43
  44         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  45         (LayoutTestController::pathToLocalResource):
  46
  47 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
  48
  49         Reviewed by Alice and Sam.
  50
  51         - <rdar://5621435> Need a way to specify local resources (being loaded
  52         from HTTP tests) on Windows.
  53         - Implemented pathToLocalResource which exposes the functionality of
  54         converting a given unix path to the correct location on Windows.
  55
  56         * DumpRenderTree/LayoutTestController.cpp:
  57         (pathToLocalResourceCallback):
  58         (LayoutTestController::staticFunctions):
  59         * DumpRenderTree/LayoutTestController.h:
  60         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  61         (LayoutTestController::pathToLocalResource):
  62         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  63         (LayoutTestController::pathToLocalResource):
  64
  65 2007-12-12  Anders Carlsson  <andersca@apple.com>
  66
  67         Reviewed by Sam.
  68
  69         <rdar://problem/5132003>
  70         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
  71
  72         * DumpRenderTree/win/DumpRenderTree.cpp:
  73         (main):
  74         Set the resource load delegate.
  75
  76         * DumpRenderTree/win/DumpRenderTree.vcproj:
  77
  78         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
  79         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
  80
  81 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
  82
  83         Reviewed by Adam Roben.
  84
  85         Fix conversion from double to LPARAM in dispatchMessage().
  86
  87         * DumpRenderTree/win/EventSender.cpp:
  88         (dispatchMessageCallback):
  89
  90 2007-12-11  Dan Bernstein  <mitz@apple.com>
  91
  92         Reviewed by Mark Rowe and Sam Weinig too!
  93
  94         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
  95           fonts DumpRenderTree registers.
  96
  97         * DumpRenderTree/win/DumpRenderTree.cpp:
  98         (initialize):
  99
 100 2007-12-11  Brady Eidson  <beidson@apple.com>
 101
 102         Reviewed by Anders
 103
 104         Make DumpRenderTree on mac use its own path for Databases testing
 105
 106         * DumpRenderTree/mac/DumpRenderTree.mm:
 107         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree
 108           for future DRT-only use, then use it to construct the Databases path and set that default
 109
 110 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
 111
 112         Reviewed by Darin.
 113
 114         <rdar://problem/5535636>
 115         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
 116
 117         http://bugs.webkit.org/show_bug.cgi?id=13916
 118         JavaScript detects Tab as a character input on a textfield validation
 119
 120         * DumpRenderTree/mac/EventSendingController.mm:
 121         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
 122         Dispatch a keyup to better match what happens when a key is physically pressed.
 123
 124         * DumpRenderTree/win/EventSender.cpp:
 125         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
 126         returning from keyDown().
 127         (getConstantCallback): Fixed a couple copy/paste mistakes.
 128
 129 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
 130
 131         Reviewed by Oliver.
 132
 133         - <rdar://5599845> Drosera: Does not show loal files in the file list
 134         on the left side.
 135
 136         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
 137         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
 138         so the open source community can build.
 139
 140 2007-12-10  Brady Eidson  <beidson@apple.com>
 141
 142         Rubberstamped by Sam Weinig
 143
 144         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
 145
 146         * DumpRenderTree/mac/UIDelegate.mm:
 147         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
 148         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
 149
 150 2007-12-08  Oliver Hunt  <oliver@apple.com>
 151
 152         Reviewed by Sam W.
 153
 154         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
 155
 156         Fixes <rdar://problem/5620249> Must disable SVG animation
 157         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
 158
 159         In order to allow finer grained control over the set of SVG features
 160         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
 161         distinct flags:
 162         ENABLE_SVG_ANIMATION
 163         ENABLE_SVG_FILTERS
 164         ENABLE_SVG_FONTS
 165         ENABLE_SVG_AS_IMAGE
 166         ENABLE_SVG_USE
 167
 168         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
 169
 170         Script handles all the new build flags, and allows --svg-experimental
 171         to automatically enable all features.
 172
 173         * Scripts/build-webkit:
 174
 175 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
 176
 177         Fix version parsing.
 178
 179         Rubber-stamped by Oliver.
 180
 181         * Drosera/win/Drosera.vcproj/auto-version.sh:
 182
 183 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
 184
 185         Build modifications for Drosera.
 186
 187         Reviewed by Adam.
 188
 189         * Drosera/DroseraWin.make: Added.
 190         * Drosera/win/Drosera.vcproj/Drosera.rc:
 191         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 192         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
 193         * Drosera/win/Drosera.vcproj/VERSION: Added.
 194         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
 195
 196 2007-12-06  Adam Roben  <aroben@apple.com>
 197
 198         Explicitly turn on the Mac font ascent hack on Windows
 199
 200         This keeps our font metrics matching those from Mac.
 201
 202         Reviewed by Hyatt.
 203
 204         * DumpRenderTree/win/DumpRenderTree.cpp:
 205         (main):
 206
 207 2007-12-06  Anders Carlsson  <andersca@apple.com>
 208
 209         Rename main.c to main.cpp here too.
 210
 211         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
 212
 213 2007-12-06  Sam Weinig  <sam@webkit.org>
 214
 215         Rubber stamped by Geoff.
 216
 217         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
 218
 219 2007-12-06  Darin Adler  <darin@apple.com>
 220
 221         * Scripts/do-webcore-rename: Some more renaming plans.
 222
 223 2007-12-06  Anders Carlsson  <andersca@apple.com>
 224
 225         Restore implementation of testGetIntIdentifier that was accidentally
 226         removed somehow (possibly when I made PluginObject be a cpp file).
 227
 228         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 229         (pluginInvoke):
 230
 231 2007-12-05  Anders Carlsson  <andersca@apple.com>
 232
 233         Make the entry points extern "C".
 234         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
 235
 236 2007-12-05  Anders Carlsson  <andersca@apple.com>
 237
 238         C++ warning fixes.
 239
 240         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
 241         (NPP_New):
 242         (NPP_Destroy):
 243         (NPP_SetWindow):
 244         (NPP_NewStream):
 245         (NPP_HandleEvent):
 246         (NPP_URLNotify):
 247         (NPP_GetValue):
 248
 249 2007-12-05  Anders Carlsson  <andersca@apple.com>
 250
 251         Add the .cpp files to the TestNetscapePlugIn target.
 252
 253         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 254
 255 2007-12-05  Anders Carlsson  <andersca@apple.com>
 256
 257         Reviewed by Geoff.
 258
 259         Rename the TestNetscapePlugIn .c files to be .cpp.
 260
 261         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 262         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
 263         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
 264         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
 265         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
 266         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
 267         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
 268         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
 269
 270 2007-12-05  Adam Roben  <aroben@apple.com>
 271
 272         Fix case of keypresses from the Windows implementation of eventSender.keyDown
 273
 274         This fixes several regression tests.
 275
 276         Reviewed by Alice.
 277
 278         * DumpRenderTree/win/EventSender.cpp:
 279         (keyDownCallback): Virtual keycodes for ASCII characters are always
 280         uppercase, so we need to check the case of the original character
 281         passed in to eventSender.keyDown.
 282
 283 2007-12-05  Adam Roben  <aroben@apple.com>
 284
 285         Learn from Tim's mistakes
 286
 287         * DumpRenderTree/win/DumpRenderTree.cpp:
 288         (runTest): Reset the authorAndUserStylesEnabled preference for each
 289         test.
 290
 291 2007-12-05  Alp Toker  <alp@atoker.com>
 292
 293         Reviewed by Mark Rowe.
 294
 295         Initialize GTK+ and WebKit so the tests can run.
 296
 297         Reorganize the headers a little.
 298
 299         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 300         (main):
 301
 302 2007-12-04  Anders Carlsson  <andersca@apple.com>
 303
 304         Remove IWebScriptScope include.
 305
 306         * Drosera/win/DebuggerDocumentPlatform.cpp:
 307
 308 2007-12-04  Sam Weinig  <sam@webkit.org>
 309
 310         Rubber stamped by Mark Rowe.
 311
 312         Define CF as platform for mac and revert r28409
 313
 314         * DumpRenderTree/DumpRenderTree.h:
 315         * DumpRenderTree/mac/DumpRenderTreeMac.h:
 316
 317 2007-12-04  Sam Weinig  <sam@webkit.org>
 318
 319         Define CF as platform for windows.
 320
 321         Reviewed by Adam Roben.
 322
 323         * DumpRenderTree/win/DumpRenderTreeWin.h:
 324
 325 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
 326
 327         Reviewed by Adam and Darin.
 328
 329         - Removed a needless BSTR cleanup.
 330
 331         * Drosera/win/DebuggerDocumentPlatform.cpp:
 332         (DebuggerDocument::getPlatformCurrentFunctionStack):
 333
 334 2007-11-27  Adam Roben  <aroben@apple.com>
 335
 336         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
 337
 338         Reviewed by Maciej.
 339
 340         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 341         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
 342
 343 2007-12-04  Alp Toker  <alp@atoker.com>
 344
 345         Prospective Win DRT build fix.
 346
 347         * DumpRenderTree/DumpRenderTree.h:
 348
 349 2007-12-04  Alp Toker  <alp@atoker.com>
 350
 351         Fix a clobbered copyright header.
 352
 353         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 354
 355 2007-12-04  Xan Lopez  <xan@gnome.org>
 356
 357         Reviewed by Alp Toker.
 358
 359         http://bugs.webkit.org/show_bug.cgi?id=15561
 360         GTK port needs DumpRenderTree implementation
 361
 362         Start work on the GTK+ DRT.
 363
 364         This does not work yet, and there are a few lingering style issues
 365         (nothing major) but this patch has been stuck in the bug tracker for
 366         too long already.
 367
 368         * DumpRenderTree/DumpRenderTree.h:
 369         * DumpRenderTree/gtk: Added.
 370         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
 371         (autocorrectURL):
 372         (shouldLogFrameLoadDelegates):
 373         (dumpFrameScrollPosition):
 374         (displayWebView):
 375         (appendString):
 376         (dumpFramesAsText):
 377         (dumpRenderTreeAsText):
 378         (dump):
 379         (runTest):
 380         (main):
 381         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
 382         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
 383         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
 384         (GCController::collect):
 385         (GCController::collectOnAlternateThread):
 386         (GCController::getJSObjectCount):
 387         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
 388         (LayoutTestController::~LayoutTestController):
 389         (LayoutTestController::addDisallowedURL):
 390         (LayoutTestController::clearBackForwardList):
 391         (LayoutTestController::copyDecodedHostName):
 392         (LayoutTestController::copyEncodedHostName):
 393         (LayoutTestController::display):
 394         (LayoutTestController::keepWebHistory):
 395         (LayoutTestController::notifyDone):
 396         (LayoutTestController::queueBackNavigation):
 397         (LayoutTestController::queueForwardNavigation):
 398         (LayoutTestController::queueLoad):
 399         (LayoutTestController::queueReload):
 400         (LayoutTestController::queueScript):
 401         (LayoutTestController::setAcceptsEditing):
 402         (LayoutTestController::setCustomPolicyDelegate):
 403         (LayoutTestController::setMainFrameIsFirstResponder):
 404         (LayoutTestController::setTabKeyCyclesThroughElements):
 405         (LayoutTestController::setUseDashboardCompatibilityMode):
 406         (LayoutTestController::setUserStyleSheetEnabled):
 407         (LayoutTestController::setUserStyleSheetLocation):
 408         (LayoutTestController::setWindowIsKey):
 409         (LayoutTestController::setWaitToDump):
 410         (LayoutTestController::windowCount):
 411         (LayoutTestController::setPrivateBrowsingEnabled):
 412         (LayoutTestController::setAuthorAndUserStylesEnabled):
 413         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
 414         (JSStringCopyUTF8CString):
 415         (LoadItem::invoke):
 416         (ReloadItem::invoke):
 417         (ScriptItem::invoke):
 418         (BackForwardItem::invoke):
 419
 420 2007-12-03  Sam Weinig  <sam@webkit.org>
 421
 422         Move JavaScriptCore thread testing code to pthread specific directory
 423         and remove the dependance on CoreFoundation by using WTF::HashSet.
 424
 425         Reviewed by Geoff and Oliver.
 426
 427         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 428         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
 429         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
 430         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
 431         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
 432         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
 433         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
 434         * DumpRenderTree/pthreads: Added.
 435         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
 436         (javaScriptThreads):
 437         (runJavaScriptThread):
 438         (startJavaScriptThreads):
 439         (stopJavaScriptThreads):
 440
 441 2007-12-03  Andrew Bonventre  <andybons@google.com>
 442
 443         Reviewed by Darin Adler.
 444
 445         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
 446         Symbol lookup menu broken in debugger view
 447
 448         * Drosera/debugger.js: Fixed javascript error where document property
 449         should have been used instead of contentDocument in switchFunction that
 450         was breaking the select symbol dropdown menu.  This is because
 451         window.frames will return a Window object and not a frame object like
 452         the author was originally expecting.
 453
 454 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
 455
 456         Reviewed by Adam.
 457
 458         - <rdar://5618942> Drosera: Console window does not process everything
 459         correctly.
 460         - <rdar://5619005> Drosera: could be sped up by moving the
 461         WebScriptScope stuff into the WebScriptCallFrame.
 462         - Now the console can correctly process objects and does not receive
 463         notifications from JavaScriptCore about the JavaScript in Drosera's
 464         own process.
 465
 466         * Drosera/win/DebuggerDocumentPlatform.cpp:
 467         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 468         (DebuggerDocument::platformValueForScopeVariableNamed):
 469
 470 2007-12-03  Stephanie  <slewis@apple.com>
 471
 472         Reviewed by Darin.
 473
 474         Check to see if we are building a debug root
 475
 476         * Scripts/check-for-global-initializers:
 477
 478 2007-12-03  Dan Bernstein  <mitz@apple.com>
 479
 480         Reviewed by Darin Adler.
 481
 482         - added a testGetIntIdentifier() method to TestNetscapePlugIn
 483
 484         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
 485         (pluginInvoke):
 486
 487 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
 488
 489         Reviewed by Oliver.
 490
 491         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
 492         in a more fine-grained manner than eventSender.keyDown().
 493
 494         * DumpRenderTree/win/EventSender.cpp:
 495         (getConstantCallback):
 496         (dispatchMessageCallback):
 497
 498 2007-12-02  Darin Adler  <darin@apple.com>
 499
 500         * Scripts/do-webcore-rename: More planned renaming.
 501
 502 2007-12-02  Sam Weinig  <sam@webkit.org>
 503
 504         Rubber stamped by Anders.
 505
 506         Use [NSURL absoluteString] instead of [NSURL description] in order to get
 507         more uniform results cross platform.
 508
 509         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
 510         (-[NSURL _drt_descriptionSuitableForTestResult]):
 511
 512 2007-12-02  Sam Weinig  <sam@webkit.org>
 513
 514         Rubber stamped by Niko.
 515
 516         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
 517
 518         * DumpRenderTree/win/DumpRenderTree.cpp:
 519         * DumpRenderTree/win/DumpRenderTree.vcproj:
 520         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
 521         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
 522         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
 523         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
 524
 525 2007-12-01  Alp Toker  <alp@atoker.com>
 526
 527         Reviewed by Adam Roben.
 528
 529         Make use of the newly introduced webkit.h convenience header.
 530
 531         * GtkLauncher/main.c:
 532
 533 2007-12-01  Adam Treat  <treat@kde.org>
 534
 535         Reviewed by Simon.
 536
 537         * Check to see if the directory exists and exit if not.
 538
 539         * DumpRenderTree/qt/main.cpp:
 540         (main):
 541
 542 2007-12-01  Adam Treat  <treat@kde.org>
 543
 544         Reviewed by Simon.
 545
 546         * Don't hide symbols when in Debug mode
 547         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
 548
 549
 550         * DumpRenderTree/qt/main.cpp:
 551         (messageHandler):
 552
 553 2007-11-30  Alp Toker  <alp@atoker.com>
 554
 555         Reviewed by Adam Roben.
 556
 557         http://bugs.webkit.org/show_bug.cgi?id=15691
 558         [GTK] Public API does not follow GTK+ conventions
 559
 560         Refactor the WebKit/GTK+ public API. Changes:
 561           WebKitPage -> WebKitWebView
 562           WebKitFrame -> WebKitWebFrame
 563
 564         Public API source and header names have been updated to mirror the API
 565         changes.
 566
 567         The API is now kept in WebKit/gtk/WebView to match other ports in the
 568         same class such as Mac and Win.
 569
 570         * GtkLauncher/main.c:
 571         (activate_uri_entry_cb):
 572         (link_hover_cb):
 573         (title_change_cb):
 574         (progress_change_cb):
 575         (go_back_cb):
 576         (go_forward_cb):
 577         (create_browser):
 578         (main):
 579
 580 2007-11-30  Adam Roben  <aroben@apple.com>
 581
 582         Hopefully the final build fix
 583
 584         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
 585         pull in WTF's assertion/logging functions.
 586
 587 2007-11-30  Adam Roben  <aroben@apple.com>
 588
 589         Another build fix
 590
 591         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
 592         WebKit.lib.
 593
 594 2007-11-30  Adam Roben  <aroben@apple.com>
 595
 596         Debug build fix
 597
 598         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
 599         configuration.
 600         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
 601         projects.
 602         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
 603         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
 604         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
 605
 606 2007-11-30  Sam Weinig  <sam@webkit.org>
 607
 608         Reviewed by Adam Roben.
 609
 610         Fix drawSelectionRect to actually draw the selection rect.
 611
 612         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
 613         (drawSelectionRect):
 614
 615 2007-11-30  Darin Adler  <darin@apple.com>
 616
 617         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
 618
 619 2007-11-30  Darin Adler  <darin@apple.com>
 620
 621         * Scripts/do-webcore-rename: Get ready for some future renaming.
 622
 623 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
 624
 625         Reviewed by Adam.
 626
 627         - Removed some unnecessary functions and changed an unused return type.
 628
 629         * Drosera/win/DebuggerClient.cpp:
 630         (registerConsoleClass):
 631         * Drosera/win/DebuggerClient.h:
 632         * Drosera/win/Drosera.cpp:
 633         (registerDroseraClass):
 634
 635 2007-11-28  Alp Toker  <alp@atoker.com>
 636
 637         Reviewed by Timothy Hatcher.
 638
 639         http://bugs.webkit.org/show_bug.cgi?id=16174
 640         [GTK] Use "URI" not "URL" in public API
 641
 642         Replace use of the term "URL" with "URI" in public headers,
 643         documentation and some internal code to match GLib/GTK+ convention.
 644
 645         This is now mentioned in the API guidelines:
 646           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
 647
 648         * GtkLauncher/main.c:
 649         (activate_uri_entry_cb):
 650         (title_change_cb):
 651         (create_toolbar):
 652         (main):
 653
 654 2007-11-29  Anders Carlsson  <andersca@apple.com>
 655
 656         Reviewed by Sam.
 657
 658         <rdar://problem/5230478>
 659         FrameLoadDelegate callbacks are not dumped in DRT.
 660
 661         * DumpRenderTree/win/DumpRenderTree.cpp:
 662         (shouldLogFrameLoadDelegates):
 663         (runTest):
 664         (main):
 665         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
 666         (BSTRtoString):
 667         (descriptionSuitableForTestResult):
 668         (FrameLoadDelegate::QueryInterface):
 669         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
 670         (FrameLoadDelegate::didFailProvisionalLoadWithError):
 671         (FrameLoadDelegate::didCommitLoadForFrame):
 672         (FrameLoadDelegate::didFinishLoadForFrame):
 673         (FrameLoadDelegate::willCloseFrame):
 674         (FrameLoadDelegate::didClearWindowObject):
 675         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
 676         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
 677         * DumpRenderTree/win/FrameLoaderDelegate.h:
 678         (FrameLoadDelegate::windowScriptObjectAvailable):
 679         (FrameLoadDelegate::didFirstLayoutInFrame):
 680
 681 2007-11-29  Sam Weinig  <sam@webkit.org>
 682
 683         Reviewed by Anders.
 684
 685         Add database quota UIDelegates methods to DRT UIDelegate.
 686
 687         * DumpRenderTree/mac/UIDelegate.mm:
 688         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
 689         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
 690
 691 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
 692
 693         Reviewed by Sam.
 694
 695         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
 696         dying and vice versa.
 697         - This fix will allow Drosera and Safari to reconnect if either of them
 698         closes correctly, but does not fix the case where one of them dies
 699         silently.
 700
 701         * Drosera/win/ServerConnection.cpp:
 702         (ServerConnection::attemptToCreateServerConnection): Added a safety
 703         check, because it's possilbe to try to connect to a server that's dying.
 704         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
 705         the server has died.
 706         * Drosera/win/ServerConnection.h: Added the new function and removed
 707         an unnecessary member.
 708
 709 2007-11-29  Anders Carlsson  <andersca@apple.com>
 710
 711         * DumpRenderTree/win/DumpRenderTree.vcproj:
 712         Add shlwapi.lib to all configurations.
 713
 714 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
 715
 716         - Build fix.  Added additional includes for VS Express to the Release
 717         project.
 718
 719         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 720
 721 2007-11-29  Anders Carlsson  <andersca@apple.com>
 722
 723         Reviewed by Adam.
 724
 725         <rdar://problem/5132005>
 726         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
 727
 728         * DumpRenderTree/win/DumpRenderTree.vcproj:
 729         Add shlwapi.lib
 730
 731         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 732         (LayoutTestController::setUserStyleSheetEnabled):
 733         Implement this.
 734
 735         (appendComponentToPath):
 736         New method which wraps the Win32 API PathAppend.
 737
 738         (followShortcuts):
 739         New method which checks if a file points to a shortcut and
 740         follows the shortcut.
 741
 742         (resolveCygwinPath):
 743         New method that takes a cygwin unix-style path and returns the Win32 path.
 744
 745         (cfStringRefToWString):
 746
 747         (LayoutTestController::setUserStyleSheetLocation):
 748         Implement this.
 749
 750 2007-11-29  Alice Liu  <alice.liu@apple.com>
 751
 752         Reviewed by Adam.
 753
 754         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
 755
 756         * DumpRenderTree/win/EventSender.cpp:
 757         (keyDownCallback):
 758         uppercase letters were being sent as lowercase letters without the shift key down.
 759
 760 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
 761
 762         - Windows build fix. VS express needs some love.
 763
 764         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 765
 766 2007-11-28  Darin Adler  <darin@apple.com>
 767
 768         Reviewed by Adam Roben.
 769
 770         * DumpRenderTree/mac/EventSendingController.mm:
 771         (-[EventSendingController keyDown:withModifiers:]):
 772         Send capital letters through as lowercase letters with the shift key down
 773         rather than sending them as if they were highly unusual "capital letter keys".
 774
 775         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
 776         where you need to update results and more tests are failing than before.
 777
 778 2007-11-28  Anders Carlsson  <andersca@apple.com>
 779
 780         Reviewed by Darin.
 781
 782         <rdar://problem/5132001>
 783         contextClick is not implemented in DRT on Windows.
 784
 785         * DumpRenderTree/win/EventSender.cpp:
 786         (contextClickCallback):
 787         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
 788         by a WM_RBUTTONUP message.
 789
 790         * DumpRenderTree/win/UIDelegate.cpp:
 791         (UIDelegate::hasCustomMenuImplementation):
 792         (UIDelegate::trackCustomPopupMenu):
 793         * DumpRenderTree/win/UIDelegate.h:
 794         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
 795         menu from being shown (and causing the DRT to hang).
 796
 797 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
 798
 799         Reviewed by Darin.
 800
 801         Fix DumpRenderTree ObjC bug comparing strings.
 802
 803         * DumpRenderTree/mac/ObjCController.m:
 804         (-[ObjCController identityIsEqual::]): Compare strings with string
 805         equality instead of identiy equality.
 806
 807 2007-11-27  Timothy Hatcher  <timothy@apple.com>
 808
 809         Reviewed by Sam.
 810
 811         Reset the authorAndUserStylesEnabled preference
 812         back to YES for each test. Fixes the broken tests.
 813
 814         * DumpRenderTree/mac/DumpRenderTree.mm:
 815         (resetWebViewToConsistentStateBeforeTesting):
 816
 817 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
 818
 819         Reviewed by Adam.
 820
 821         - Drosera now displays the console window, although it cannot currently
 822         process JavaScript.
 823
 824         * Drosera/win/DebuggerClient.cpp: Shows the console window.
 825         (registerConsoleClass): Implemented.
 826         (consoleWndProc): Implemented.
 827         (DebuggerClient::onSize): Implemented.
 828         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
 829         new window.
 830         * Drosera/win/DebuggerClient.h: Added needed method and members for
 831         creating and maintaining a new window.
 832         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
 833         lines of code to more appropriate places.
 834         (Drosera::handleCommand):
 835         (Drosera::initUI):
 836         (Drosera::onSize):
 837         (Drosera::attach):
 838
 839 2007-11-27  Timothy Hatcher  <timothy@apple.com>
 840
 841         Reviewed by Dave Hyatt.
 842
 843         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
 844
 845         Add support for disabling author and user styles for testing.
 846
 847         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 848         * DumpRenderTree/LayoutTestController.cpp:
 849         (setAuthorAndUserStylesEnabledCallback):
 850         (LayoutTestController::staticFunctions):
 851         * DumpRenderTree/LayoutTestController.h:
 852         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 853         (LayoutTestController::setAuthorAndUserStylesEnabled):
 854         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 855         (LayoutTestController::setAuthorAndUserStylesEnabled):
 856
 857 2007-11-26  Dan Bernstein  <mitz@apple.com>
 858
 859         - Tiger build fix.
 860
 861         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 862
 863 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
 864
 865         Reviewed by Maciej.
 866
 867         - Implemented displaying variables for Drosera on Win.
 868
 869         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
 870         that retrieve variables to not hold onto the return value since it's
 871         not returned.  Also changed to use the new signatures of the retrieval
 872         functions.
 873         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
 874         (DebuggerDocument::platformValueForScopeVariableNamed):
 875         * Drosera/win/Drosera.cpp: Removed a needless TODO.
 876         (droseraWndProc):
 877
 878 2007-11-26  Sam Weinig  <sam@webkit.org>
 879
 880         Cleanup names of painting and repainting functions.
 881
 882         Reviewed by Adam Roben.
 883
 884         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
 885         (drawSelectionRect): was drawSelectionRectIntoContext.
 886         (dumpWebViewAsPixelsAndCompareWithExpected):
 887         * DumpRenderTree/cg/PixelDumpSupportCG.h:
 888         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
 889         (paintWebView): was drawWebViewIntoContext.
 890         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
 891
 892 2007-11-26  Sam Weinig  <sam@webkit.org>
 893
 894         Reviewed by Dan Bernstein.
 895
 896         - Leopard build fix
 897
 898         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 899
 900 2007-11-26  Sam Weinig  <sam@webkit.org>
 901
 902         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
 903         Use shared PixelDumpSupport for Mac DRT
 904
 905         Reviewed by Adam Roben.
 906
 907         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 908         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
 909         * DumpRenderTree/cg/ImageDiffCG.cpp:
 910         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
 911         (drawSelectionRectIntoContext):
 912         (dumpWebViewAsPixelsAndCompareWithExpected):
 913         * DumpRenderTree/cg/PixelDumpSupportCG.h:
 914         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 915         * DumpRenderTree/mac/DumpRenderTree.mm:
 916         (dump):
 917         * DumpRenderTree/mac/ImageDiff.m: Removed.
 918         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
 919         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
 920         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
 921         (setDefaultColorProfileToRGB):
 922         (getBitmapContextFromWebView):
 923         (drawWebViewIntoContext):
 924         (repaintWithVerticalSweep):
 925         (repaintWithHorizontalSweep):
 926         (getSelectionRect):
 927         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
 928
 929 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
 930
 931         Bug 16052: prepare-ChangeLog doesn't report deleted files
 932         <http://bugs.webkit.org/show_bug.cgi?id=16052>
 933
 934         Reviewed by Sam.
 935
 936         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
 937
 938 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
 939
 940         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
 941         <http://bugs.webkit.org/show_bug.cgi?id=15864>
 942
 943         Reviewed by Adam.
 944
 945         Roll functionality of merge-changelog into resolve-ChangeLogs
 946         script.  The script now checks for ChangeLog.rej and
 947         ChangeLog.orig files first.  If it finds them, it uses the
 948         ChangeLog.rej file as a patch (in old contextual diff format) to
 949         apply with --fuzz=3.
 950
 951         * Scripts/merge-changelog: Removed.
 952         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
 953
 954 2007-11-25  Sam Weinig  <sam@webkit.org>
 955
 956         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
 957
 958         Reviewed by Mark Rowe.
 959
 960         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 961         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 962         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
 963         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
 964         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
 965
 966 2007-11-25  Sam Weinig  <sam@webkit.org>
 967
 968         Convert DumpRenderTree to ues .xcconfig files.
 969
 970         Reviewed by Mark Rowe.
 971
 972         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 973         * DumpRenderTree/mac/Configurations: Added.
 974         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
 975         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
 976         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
 977
 978 2007-11-25  Sam Weinig  <sam@webkit.org>
 979
 980         Add ForwardingHeaders to wtf for DumpRenderTree.
 981
 982         Reviewed by Mark Rowe.
 983
 984         * DumpRenderTree/DumpRenderTree.h:
 985         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 986         * DumpRenderTree/ForwardingHeaders: Added.
 987         * DumpRenderTree/ForwardingHeaders/wtf: Added.
 988         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
 989         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
 990         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
 991         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
 992         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
 993         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
 994         * DumpRenderTree/LayoutTestController.cpp:
 995         * DumpRenderTree/WorkQueue.cpp:
 996         * DumpRenderTree/mac/DumpRenderTree.mm:
 997         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 998         * DumpRenderTree/mac/JavaScriptThreading.cpp:
 999         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1000         * DumpRenderTree/mac/ObjCController.m:
1001         * DumpRenderTree/mac/UIDelegate.mm:
1002         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1003
1004 2007-11-25  Adam Roben  <aroben@apple.com>
1005
1006         Fix some test failures caused by r28019
1007
1008         Now that stdout is in binary mode, we need to always use printf
1009         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1010         the output.
1011
1012         Reviewed by Sam.
1013
1014         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1015         printf.
1016         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1017         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1018         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1019         (UIDelegate::webViewAddMessageToConsole):
1020
1021 2007-11-25  Adam Roben  <aroben@apple.com>
1022
1023         Set the font smoothing preference in DRT
1024
1025         This makes the pixel results on Windows closer to the Mac results.
1026
1027         Reviewed by Mitz.
1028
1029         * DumpRenderTree/win/DumpRenderTree.cpp:
1030         (initializePreferences):
1031
1032 2007-11-25  Adam Roben  <aroben@apple.com>
1033
1034         Port ImageDiff to CG and C++
1035
1036         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1037         <rdar://5071708>
1038
1039         Reviewed by Sam.
1040
1041         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1042         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1043         (main):
1044         (createImageFromStdin):
1045         (compareImages):
1046         (getDifferenceBitmap):
1047         (computePercentageDifferent):
1048         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1049
1050 2007-11-25  Adam Roben  <aroben@apple.com>
1051
1052         Fix image diff link generation on Windows
1053
1054         Reviewed by Sam.
1055
1056         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1057         to toURL.
1058
1059 2007-11-25  Adam Roben  <aroben@apple.com>
1060
1061         Implement pixel dumping in Windows DRT
1062
1063         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1064         <rdar://5071708>
1065
1066         Reviewed by Sam.
1067
1068         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1069         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1070         Content-Length header.
1071         (getMD5HashStringForBitmap):
1072         (dumpWebViewAsPixelsAndCompareWithExpected):
1073         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1074         * DumpRenderTree/win/DumpRenderTree.cpp:
1075         (dump): Do a pixel dump if requested.
1076         (main): Parse pixel test options.
1077         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1078         the cg/ subdirectory to the include path.
1079         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1080         available in a header or import library, so we have to go through this
1081         LoadLibrary/GetProcAddress dance to use them.
1082         (cryptDLL):
1083         (init):
1084         (update):
1085         (final):
1086         (MD5_Init):
1087         (MD5_Update):
1088         (MD5_Final):
1089         * DumpRenderTree/win/MD5.h: Added.
1090         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1091         moved up to the top level to share it with Mac eventually.
1092         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1093         (getBitmapContextFromWebView): Forces the WebView to paint using a
1094         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1095
1096 2007-11-25  Adam Roben  <aroben@apple.com>
1097
1098         Clean up Windows DRT's option parsing a little bit
1099
1100         Reviewed by Sam.
1101
1102         * DumpRenderTree/win/DumpRenderTree.cpp:
1103         (main): Put non-option arguments into a Vector.
1104
1105 2007-11-25  Adam Roben  <aroben@apple.com>
1106
1107         Make Windows DRT stop changing LF into CRLF
1108
1109         Reviewed by Sam.
1110
1111         * DumpRenderTree/win/DumpRenderTree.cpp:
1112         (main): Put stdout in binary mode.
1113         * Scripts/run-webkit-tests: Remove the CRLF hack.
1114
1115 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1116
1117         Removed empty directory.
1118
1119         * Scripts/resources: Removed.
1120
1121 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1122
1123         Fix bisect-builds to work with recent WebKit nightly builds.
1124
1125         Reviewed by Dan.
1126
1127         * Scripts/bisect-builds: Check for the
1128         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1129         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1130         to WebKit.app/Contents/Resources.
1131
1132 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1133
1134         Reviewed by Maciej.
1135
1136         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1137         not closed (affects digg.com)
1138
1139         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1140         one after finishing with a test to avoid having its delayed onload handler firing when
1141         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1142         but it helps somewhat.
1143
1144 2007-11-22  Mark Rowe  <mrowe@apple.com>
1145
1146         Reviewed by Alp Toker.
1147
1148         Fix build-webkit to propagate make's exit status if it fails.
1149
1150         * Scripts/webkitdirs.pm:
1151
1152 2007-11-22  Dan Bernstein  <mitz@apple.com>
1153
1154         Reviewed by Mark Rowe.
1155
1156         - fix crash when running pixel tests
1157
1158         * DumpRenderTree/mac/DumpRenderTree.mm:
1159         (dumpRenderTree): Parse the command line options before setting up the
1160         environment so that we know if we need to set up the pixel dump
1161         machinery.
1162
1163 2007-11-21  Eric Seidel  <eric@webkit.org>
1164
1165         Speculative build fix for Tiger.
1166
1167         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1168
1169 2007-11-21  Eric Seidel  <eric@webkit.org>
1170
1171         Reviewed by Tim Hatcher.
1172
1173         Break out more of DumpRenderTree.mm into individual files
1174
1175         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1176         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1177         (checkedMalloc):
1178         (checkedRealloc):
1179         (makeLargeMallocFailSilently):
1180         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1181         * DumpRenderTree/mac/DumpRenderTree.mm:
1182         (crashHandler):
1183         (dump):
1184         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1185         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1186         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1187         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1188         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1189         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1190         (javaScriptThreads):
1191         (runJavaScriptThread):
1192         (startJavaScriptThreads):
1193         (stopJavaScriptThreads):
1194         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1195         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1196         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1197         (restoreColorSpace):
1198         (setDefaultColorProfileToRGB):
1199         (initializeColorSpaceAndScreeBufferForPixelTests):
1200         (md5HashStringForBitmap):
1201         (dumpWebViewAsPixelsAndCompareWithExpected):
1202
1203 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1204
1205         Move install-unix-extras to wx directory as it seems only to be used by that
1206         port now. It now supports universal binaries on Mac and adds libpng and libjpeg.
1207         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1208         have install-unix-extras install into WebKitLibraries as per
1209         convention.
1210
1211         Reviewed by Mark Rowe.
1212
1213         * Scripts/install-unix-extras: Removed.
1214         * wx/build-wxwebkit:
1215         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1216
1217 2007-11-21  Eric Seidel  <eric@webkit.org>
1218
1219         Reviewed by Adam.
1220
1221         More refactoring for greater code readability
1222
1223         * DumpRenderTree/mac/DumpRenderTree.mm:
1224         (initializeGlobalsFromCommandLineOptions):
1225         (initializeColorSpaceAndScreeBufferForPixelTests):
1226         (addTestPluginsToPluginSearchPath):
1227         (useLongRunningServerMode):
1228         (runTestingServerLoop):
1229         (prepareConsistentTestingEnvironment):
1230         (dumpRenderTree):
1231         (main):
1232         (dumpFramesAsText):
1233         (dumpBackForwardListForWebView):
1234         (sizeWebViewForCurrentTest):
1235         (methodNameStringForFailedTest):
1236         (dumpBackForwardListForAllWindows):
1237         (dumpWebViewAsPixelsAndCompareWithExpected):
1238         (invalidateAnyPreviousWaitToDumpWatchdog):
1239         (dump):
1240         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1241         * DumpRenderTree/mac/UIDelegate.mm:
1242         (-[UIDelegate webView:createWebViewWithRequest:]):
1243
1244 2007-11-21  Eric Seidel  <eric@webkit.org>
1245
1246         Reviewed by Tim Hatcher.
1247
1248         Abstract more of DRT into static methods
1249
1250         * DumpRenderTree/mac/DumpRenderTree.mm:
1251         (setDefaultsToConsistentValuesForTesting):
1252         (setupSignalHandlers):
1253         (allocateGlobalControllers):
1254         (releaseAndZero):
1255         (releaseGlobalControllers):
1256         (dumpRenderTree):
1257         (shouldLogFrameLoadDelegates):
1258         (createCFURLFromPathOrURL):
1259         (resetWebViewToConsistentStateBeforeTesting):
1260         (runTest):
1261
1262 2007-11-21  Eric Seidel  <eric@webkit.org>
1263
1264         Reviewed by Tim Hatcher.
1265
1266         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1267
1268         * DumpRenderTree/DumpRenderTree.h:
1269         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1270         * DumpRenderTree/mac/DumpRenderTree.mm:
1271         (dumpRenderTree):
1272         (dump):
1273         (runTest):
1274         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1275         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1276         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1277         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1278         (-[DumpRenderTreePasteboard declareType:owner:]):
1279         (+[LocalPasteboard alloc]):
1280         (-[LocalPasteboard init]):
1281         (-[LocalPasteboard dealloc]):
1282         (-[LocalPasteboard name]):
1283         (-[LocalPasteboard releaseGlobally]):
1284         (-[LocalPasteboard declareTypes:owner:]):
1285         (-[LocalPasteboard addTypes:owner:]):
1286         (-[LocalPasteboard changeCount]):
1287         (-[LocalPasteboard types]):
1288         (-[LocalPasteboard availableTypeFromArray:]):
1289         (-[LocalPasteboard setData:forType:]):
1290         (-[LocalPasteboard dataForType:]):
1291         (-[LocalPasteboard setPropertyList:forType:]):
1292         (-[LocalPasteboard setString:forType:]):
1293         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1294         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1295         (+[DumpRenderTreeWindow allWindows]):
1296         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1297         (-[DumpRenderTreeWindow dealloc]):
1298         (-[DumpRenderTreeWindow isKeyWindow]):
1299         (-[DumpRenderTreeWindow keyDown:]):
1300
1301 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1302
1303         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1304         it indiscriminately copies any headers inside JavaScriptCore,
1305         which includes Tiger ICU headers.
1306
1307         * wx/build-wxwebkit:
1308         Don't run WebCore/move-js-headers.sh any longer.
1309
1310 2007-11-20  Adam Treat  <treat@kde.org>
1311
1312         Reviewed by David Kilzer.
1313
1314         * Prepend git branch name to $baseProductDir
1315
1316         * Scripts/VCSUtils.pm:
1317         * Scripts/webkitdirs.pm:
1318
1319 2007-11-20  Mark Rowe  <mrowe@apple.com>
1320
1321         Reviewed by Simon Hausmann.
1322
1323         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1324         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1325         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1326         built product and generated Makefile's are removed.
1327
1328 2007-11-19  Alp Toker  <alp@atoker.com>
1329
1330         Reviewed by Mark Rowe.
1331
1332         http://bugs.webkit.org/show_bug.cgi?id=16040
1333         [GTK] GtkLauncher should be written in C
1334
1335         Port GtkLauncher to plain C.
1336
1337         Use a more conventional GTK+ coding style.
1338
1339         Use a toolbar instead of menus.
1340
1341         Various signature fixes and cleanups.
1342
1343         Add a license header. Assume all previous modifications were copyright
1344         assigned to Apple Inc. by default.
1345
1346         * GtkLauncher/GtkLauncher.pro:
1347         * GtkLauncher/main.c: Added.
1348         (activate_url_entry_cb):
1349         (update_title):
1350         (link_hover_cb):
1351         (title_change_cb):
1352         (progress_change_cb):
1353         (destroy_cb):
1354         (go_back_cb):
1355         (go_forward_cb):
1356         (create_browser):
1357         (create_statusbar):
1358         (create_toolbar):
1359         (create_window):
1360         (main):
1361         * GtkLauncher/main.cpp: Removed.
1362
1363 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1364
1365         Build script fixes to ensure they do the right thing for the
1366         wx port, and update build-wxwebkit to reflect the way the
1367         build scripts now work.
1368
1369         Reviewed by Adam.
1370
1371         * Scripts/build-testkjs:
1372         * Scripts/build-webkit:
1373         * Scripts/run-javascriptcore-tests:
1374         * Scripts/webkitdirs.pm:
1375         * wx/build-wxwebkit:
1376
1377 2007-11-18  Eric Seidel  <eric@webkit.org>
1378
1379         Reviewed by Anders.
1380
1381         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1382
1383         * Scripts/run-javascriptcore-tests:
1384
1385 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1386
1387         Reviewed by Adam Roben.
1388
1389         Make run-webkit-tests work with Windows debug build.
1390
1391         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1392         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1393         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1394         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1395         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1396
1397 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1398
1399         Add wxWebKit sample and build script, and integrate it with
1400         build-webkit. Also make build-webkit --clean work for all
1401         ports.
1402
1403         Reviewed by Darin Adler.
1404
1405         * Scripts/build-webkit:
1406         * Scripts/webkitdirs.pm:
1407         * wx: Added.
1408         * wx/browser: Added.
1409         * wx/browser/browser.bkl: Added.
1410         * wx/browser/browser.cpp: Added.
1411         * wx/build-wxwebkit: Added.
1412
1413 2007-11-17  Adam Roben  <aroben@apple.com>
1414
1415         Make it easy to run Safari in the debugger on Windows
1416
1417         I've added a new script, debug-safari, which launches Safari in the
1418         debugger. On OS X it just calls gdb-safari.
1419
1420         Reviewed by Mark Rowe.
1421
1422         * FindSafari/FindSafari.cpp:
1423         (_tmain): Added a /debugger flag, which in combination with
1424         /printSafariLauncher will print a script that launches Safari in the
1425         debugger.
1426         * Scripts/debug-safari: Added.
1427         * Scripts/run-safari: Changed to call runSafari().
1428         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
1429         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
1430         first argument along to FindSafari.
1431         * Scripts/webkitdirs.pm:
1432         (sub runSafari): Added.
1433
1434 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
1435
1436         Reviewed by Adam Roben.
1437
1438         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined.
1439
1440 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
1441
1442         Reviewed by David Kilzer.
1443
1444         The git config command was renamed to repo-config at some point. This
1445         change tries git config and then git repo-config if the first fails.
1446
1447         * Scripts/prepare-ChangeLog:
1448         (gitConfig):
1449
1450 2007-11-16  Dan Bernstein  <mitz@apple.com>
1451
1452         Reviewed by Darin Adler and Sam Weinig.
1453
1454         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
1455
1456         * DumpRenderTree/win/EventSender.cpp:
1457         (keyDownCallback): For characters that cannot be entered on the active
1458         keyboard layout, send a WM_CHAR message with the character along with
1459         a WM_KEYDOWN message with a virtual key code of 255.
1460
1461 2007-11-16  Mark Rowe  <mrowe@apple.com>
1462
1463         Reviewed by Tim Hatcher.
1464
1465         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
1466
1467         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1468         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1469
1470 2007-11-15  Adam Roben  <aroben@apple.com>
1471
1472         Make run-safari actually work on Windows
1473
1474         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
1475         chdir call.
1476
1477 2007-11-14  Adam Roben  <aroben@apple.com>
1478
1479         Updates to Safari launching now that 3.0.4 is released
1480
1481         Reviewed by Sam.
1482
1483         * FindSafari/FindSafari.cpp:
1484         (getWebViewCLSID): Use version-independent ProgID.
1485         * Scripts/run-safari: Use run-webkit-nightly.cmd.
1486
1487 2007-11-14  Anders Carlsson  <andersca@apple.com>
1488
1489         Reviewed by Adam.
1490
1491         <rdar://problem/5309081>
1492         In DRT, "plugin.logDestroy = true" not working on Windows.
1493
1494         * DumpRenderTree/win/TestNetscapePlugin/main.c:
1495         (NPP_Destroy):
1496
1497 2007-11-14  Eric Seidel  <eric@webkit.org>
1498
1499         Reviewed by Sam.
1500
1501         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
1502
1503 2007-11-14  Anders Carlsson  <andersca@apple.com>
1504
1505         Reviewed by Adam.
1506
1507         <rdar://problem/5141186>
1508         window.layoutTestController.setWindowIsKey is not implemented in DRT.
1509
1510         Implement setWindowIsKey.
1511
1512         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1513         (LayoutTestController::setWindowIsKey):
1514
1515 2007-11-13  Sam Weinig  <sam@webkit.org>
1516
1517         Reviewed by Adam Roben.
1518
1519         Fix for <rdar://problem/5382579>
1520         http/tests/security/cross-frame-access-put.html reports large
1521         negative numbers for screenLeft and screenTop (Mac reports "0")
1522
1523         * DumpRenderTree/win/UIDelegate.cpp:
1524         (UIDelegate::UIDelegate): Initialize the RECT.
1525         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
1526         (UIDelegate::webViewFrame): ditto.
1527         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
1528
1529 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
1530
1531         Reviewed by Adam.
1532
1533         - Make Drosera show source, source URLs, and function stack on Windows,
1534         and some minor fixes.
1535
1536         * Drosera/DebuggerDocument.cpp: Force source to always update display.
1537         (DebuggerDocument::updateFileSource):
1538         * Drosera/debugger.js: Force source to always update display.
1539         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
1540         menu controls.
1541         (DebuggerClient::resume):
1542         (DebuggerClient::pause):
1543         (DebuggerClient::stepInto):
1544         (DebuggerClient::stepOver):
1545         (DebuggerClient::stepOut):
1546         (DebuggerClient::showConsole):
1547         (DebuggerClient::closeCurrentFile):
1548         * Drosera/win/DebuggerClient.h: Ditto.
1549         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
1550         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
1551         removed two bugs.  1) caller could be in a bad state when asked to
1552         assign into it. 2) BSTRs were not created correctly.
1553         (DebuggerDocument::getPlatformCurrentFunctionStack):
1554         * Drosera/win/Drosera.cpp: Hook up the menu controls.
1555         (droseraWndProc):
1556         (handleCommand):
1557         (Drosera::resume):
1558         (Drosera::pause):
1559         (Drosera::stepInto):
1560         (Drosera::stepOver):
1561         (Drosera::stepOut):
1562         (Drosera::showConsole):
1563         (Drosera::closeCurrentFile):
1564         * Drosera/win/Drosera.h: Hook up the menu controls.
1565         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
1566         functions, added a null check, and fixed another bug where caller could
1567         be in a bad state when asked to assign into it.
1568         (ServerConnection::didLoadMainResourceForDataSource):
1569         (ServerConnection::getCallerFrame):
1570         * Drosera/win/ServerConnection.h: Safety first.
1571
1572 2007-11-13  Dan Bernstein  <mitz@apple.com>
1573
1574         Reviewed by Darin Adler.
1575
1576         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
1577           DumpRenderTree --pixel-tests renders each test twice
1578
1579         * DumpRenderTree/mac/DumpRenderTree.mm:
1580         (dumpRenderTree): Removed the --paint option because the painting code
1581         is always exercised as a result of
1582         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
1583         calling -displayIfNeeded.
1584         (dump): Changed to always grab the image from the window since the view
1585         is always displayed.
1586         (runTest):
1587         (displayWebView):
1588         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
1589         because it always paints.
1590
1591 2007-11-12  Antti Koivisto  <antti@apple.com>
1592
1593         Reviewed by Adele.
1594
1595         Add support for http media tests
1596
1597         * Scripts/run-webkit-tests:
1598
1599 2007-11-12  Sam Weinig  <sam@webkit.org>
1600
1601         Reviewed by Adam Roben.
1602
1603         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
1604
1605         * DumpRenderTree/win/DumpRenderTree.cpp:
1606         (runTest):
1607         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1608         (LayoutTestController::setPrivateBrowsingEnabled):
1609
1610 2007-11-12  Adam Roben  <aroben@apple.com>
1611
1612         * Scripts/update-webkit-localizable-strings: Changed to only scan the
1613         mac and win subdirectories.
1614
1615 2007-11-11  Adam Roben  <aroben@apple.com>
1616
1617         Fix <rdar://5133816> keepWebHistory is not implemented
1618
1619         Fixes fast/history/clicked-link-is-visited.html.
1620
1621         Reviewed by Darin.
1622
1623         * DumpRenderTree/win/DumpRenderTree.cpp:
1624         (runTest): Clear the optionalSharedHistory.
1625         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1626         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
1627
1628 2007-11-10  Sam Weinig  <sam@webkit.org>
1629
1630         Reviewed by Tim Hatcher.
1631
1632         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript
1633         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions
1634         is turned on)
1635
1636         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
1637
1638         Added test: http/tests/security/cross-frame-access-private-browsing.html
1639
1640         * DumpRenderTree/LayoutTestController.cpp:
1641         (setPrivateBrowsingEnabledCallback):
1642         (LayoutTestController::staticFunctions):
1643         * DumpRenderTree/LayoutTestController.h:
1644         * DumpRenderTree/mac/DumpRenderTree.mm:
1645         (runTest): Default to private browsing disabled.
1646         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1647         (LayoutTestController::setPrivateBrowsingEnabled):
1648         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1649         (LayoutTestController::setPrivateBrowsingEnabled):
1650
1651 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1652
1653         Reviewed by Adam.
1654
1655         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
1656         WebCore's!
1657
1658         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
1659         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
1660         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
1661         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
1662         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
1663         * Drosera/win/Drosera.cpp:
1664         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1665
1666 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
1667
1668         Reviewed by Sam.
1669
1670         - Use the new IWebFrame [local] function signature and get the shared
1671         server correctly.
1672
1673         * Drosera/win/DebuggerClient.cpp:
1674         (DebuggerClient::didFinishLoadForFrame):
1675         * Drosera/win/ServerConnection.cpp:
1676         (ServerConnection::attemptToCreateServerConnection):
1677
1678 2007-11-07  Dan Bernstein  <mitz@apple.com>
1679
1680         Reviewed by Darin Adler.
1681
1682         - add an option to run-webkit-tests to ignore pixel test failures where
1683           all pixels differ by no more than a specified threshold
1684
1685         * DumpRenderTree/mac/ImageDiff.m:
1686         (main):
1687         (compareImages):
1688         (computePercentageDifferent):
1689         * Scripts/run-webkit-tests:
1690
1691 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1692
1693         Reviewed by Lars.
1694
1695         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
1696
1697         * DumpRenderTree/qt/DumpRenderTree.cpp:
1698
1699 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1700
1701         Reviewed by Lars.
1702
1703         Reworked the QWebSettings API.
1704         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
1705
1706         * DumpRenderTree/qt/DumpRenderTree.cpp:
1707
1708 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1709
1710         Reviewed by Lars.
1711
1712         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
1713
1714         * DumpRenderTree/qt/jsobjects.cpp:
1715
1716 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1717
1718         Reviewed by Lars Knoll <lars@trolltech.com>.
1719
1720         Add a QWebPage::frameCreated() signal and fix DRT
1721
1722         The removal of createFrame in QWebPage broke the re-implementation
1723         in DumpRenderTree. Instead emit a frameCreated() signal and
1724         connect to it in DumpRenderTree.
1725
1726
1727         * DumpRenderTree/qt/DumpRenderTree.cpp:
1728         (WebCore::WebPage::WebPage):
1729         (WebCore::DumpRenderTree::dump):
1730         (WebCore::DumpRenderTree::connectFrame):
1731         * DumpRenderTree/qt/DumpRenderTree.h:
1732
1733 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1734
1735         Reviewed by Lars Knoll <lars@trolltech.com>.
1736
1737         Moved all the event handlers from QWebFrame into QWebPage.
1738
1739         This cleans up the public API and allows us to remove the
1740         HackWebFrame hack in DumpRenderTree.
1741
1742
1743         * DumpRenderTree/qt/jsobjects.cpp:
1744         (EventSender::mouseDown):
1745         (EventSender::mouseUp):
1746         (EventSender::mouseMoveTo):
1747
1748 2007-11-07  Simon Hausmann  <hausmann@kde.org>
1749
1750         Reviewed by Mark.
1751
1752         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
1753         to prevent the default implementation from popping up messageboxes.
1754
1755         * DumpRenderTree/qt/DumpRenderTree.cpp:
1756         (WebCore::WebPage::javaScriptConfirm):
1757         (WebCore::WebPage::javaScriptPrompt):
1758
1759 2007-11-06  Eric Seidel  <eric@webkit.org>
1760
1761         * Scripts/build-testkjs: build fix... too many $$
1762
1763 2007-11-06  Eric Seidel  <eric@webkit.org>
1764
1765         Reviewed by Mark Rowe.
1766
1767         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
1768
1769 2007-11-05  Adam Roben  <aroben@apple.com>
1770
1771         Add support on Windows for WEBKIT_TESTFONTS
1772
1773         This environment variable lets you specify where the fonts to be used
1774         by DumpRenderTree reside. The Qt port is already using this, so I'm
1775         just following their lead.
1776
1777         Reviewed by Darin.
1778
1779         * DumpRenderTree/win/DumpRenderTree.cpp:
1780         (exePath): Refactored code out of initialize().
1781         (fontsPath): Returns either $WEBKIT_TESTFONTS or
1782         DumpRenderTree.resources.
1783         (initialize): Use the new fontsPath function.
1784         (main): Use the new exePath function.
1785         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
1786         variable to DRT, like Qt does.
1787
1788 2007-11-05  Mark Rowe  <mrowe@apple.com>
1789
1790         Rubber-stamped by Alp Toker.
1791
1792         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
1793
1794         * GtkLauncher/main.cpp:
1795         (goToURLBarText):
1796         (main):
1797
1798 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
1799
1800         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
1801         <http://bugs.webkit.org/show_bug.cgi?id=15830>
1802
1803         Reviewed by Timothy.
1804
1805         Restrict the range of nightly builds used by the bisect-builds script
1806         based on the version of Safari and the version of Mac OS X being used.
1807
1808         Mac OS X 10.4: Safari 2.0: r11976 or newer
1809         Mac OS X 10.4: Safari 3.0: r19992 or newer
1810
1811         Mac OS X 10.5: Safari 2.0: r19594 or newer
1812         Mac OS X 10.5: Safari 3.0: r25124 or newer
1813
1814         * Scripts/bisect-builds:
1815         (findMacOSXVersion): Added.
1816         (makeNightlyList): Added argument to provide version of Mac OS X.
1817         Restrict range of nightly builds based on Safari and Mac OS X versions.
1818
1819 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
1820
1821         Reviewed by Maciej.
1822
1823         - This patch involves several changes, all of them were noticed that
1824         they were needed by the work being done in WebKit to get Drosera and
1825         WebKit working together on Windows.
1826         - The changes are:
1827         1) Added a debugger console for output messages.
1828         2) Drosera now listens for the WebKit server (before, the server would
1829         have to be running before Drosera was started.)
1830         3) Fixed a bug where the WebView started out as 0x0 pixels.
1831         4) Fixed a bug when there is no scope.
1832         5) Added the HTML, JS, and CSS to the project file to make them easy to
1833         find.
1834         6) Made the ServerConnection functions virtual.
1835
1836         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
1837         for the WebKit server.
1838         (DebuggerClient::DebuggerClient):
1839         (DebuggerClient::~DebuggerClient):
1840         (DebuggerClient::didFinishLoadForFrame):
1841         (DebuggerClient::serverConnected):
1842         (DebuggerClient::attemptToCreateServerConnection):
1843         * Drosera/win/DebuggerClient.h: Ditto.
1844         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
1845         scope.
1846         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1847         (DebuggerDocument::platformValueForScopeVariableNamed):
1848         * Drosera/win/Drosera.cpp:
1849         (_tWinMain): Added a console in debug for output messages.
1850         (Drosera::Drosera): Listen for server.
1851         (Drosera::initUI): The server now Initializes COM.
1852         (Drosera::serverConnected): Part of the listening for the server.
1853         (Drosera::attemptToCreateServerConnection): Ditto.
1854         * Drosera/win/Drosera.h: New interface for listening for the server.
1855         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
1856         files to the VS project.
1857         * Drosera/win/ServerConnection.cpp: Part of listening for the server
1858         connection.
1859         (ServerConnection::ServerConnection):
1860         (ServerConnection::attemptToCreateServerConnection):
1861         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
1862         methods.
1863         (ServerConnection::serverConnected):
1864
1865 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
1866
1867         Reviewed by Maciej.
1868
1869         http://bugs.webkit.org/show_bug.cgi?id=15832
1870         fast/dom/gc-10.html crashes when run alone
1871
1872         Check for !done before using objects that can be already deallocated.
1873
1874         * DumpRenderTree/mac/EditingDelegate.mm:
1875         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
1876         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
1877         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
1878         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
1879         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
1880         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
1881         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
1882         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
1883         (-[EditingDelegate webViewDidBeginEditing:]):
1884         (-[EditingDelegate webViewDidChange:]):
1885         (-[EditingDelegate webViewDidEndEditing:]):
1886         (-[EditingDelegate webViewDidChangeTypingStyle:]):
1887         (-[EditingDelegate webViewDidChangeSelection:]):
1888         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1889         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
1890         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1891         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1892         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
1893         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
1894         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
1895         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
1896         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
1897         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
1898         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
1899         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
1900         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
1901         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
1902         (-[FrameLoadDelegate webView:willCloseFrame:]):
1903         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
1904         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
1905         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1906         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1907         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1908         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1909         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1910         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1911         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1912
1913 2007-11-04  Mark Rowe  <mrowe@apple.com>
1914
1915         Build fix.  Don't use Carbon.h as the prefix header as it triggers
1916         warnings that would otherwise be suppressed due to it being a system header.
1917
1918         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1919
1920 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
1921
1922         Rubber stamped by Adam.
1923
1924         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
1925
1926         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1927
1928 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1929
1930         Sort files(...); sections of Xcode project files.
1931
1932         Rubber-stamped by Darin.
1933
1934         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
1935         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
1936         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1937         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1938
1939 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
1940
1941         Script to sort "files(...);" sections in Xcode project.pbxproj files.
1942
1943         Reviewed by Darin.
1944
1945         * Scripts/sort-Xcode-project-file: Added.
1946
1947 2007-11-02  Darin Adler  <darin@apple.com>
1948
1949         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
1950
1951 2007-11-02  Darin Adler  <darin@apple.com>
1952
1953         Reviewed by Maciej.
1954
1955         * Scripts/run-sunspider: Pass the "--base" option through.
1956
1957         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
1958         the real script do that. Default configuration to Release to match run-sunspider
1959         so we don't end up building Debug just to compare results.
1960
1961 2007-11-01  Adam Roben  <aroben@apple.com>
1962
1963         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
1964
1965         Reviewed by Sam.
1966
1967         * Scripts/commit-log-editor: Show all the directories beneath the
1968         source root, instead of just the last one.
1969
1970 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
1971
1972         Reviewed by Adam Roben.
1973
1974         Print out an error message when the Windows build fails
1975         and provide guidance on how to find out what went wrong.
1976
1977         * Scripts/build-webkit:
1978         * Scripts/webkitdirs.pm:
1979
1980 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
1981
1982         Rubber-stamped by Adam Roben.
1983
1984         Rolled out r27326 - debug CRT seems to cause no problems after all.
1985
1986         * DumpRenderTree/win/DumpRenderTree.vcproj:
1987
1988 2007-10-31  Adam Roben  <aroben@apple.com>
1989
1990         Switch the Debug configuration to using the non-debug CRT
1991
1992         This matches WebKit.
1993
1994         Reviewed by Steve.
1995
1996         * DumpRenderTree/win/DumpRenderTree.vcproj:
1997
1998 2007-10-31  Antti Koivisto  <antti@apple.com>
1999
2000         Reviewed by bdash.
2001
2002         Disable media tests when doing leak checking on Tiger.
2003         They crash in QuickTime (rdar://problem/5537157).
2004
2005         * Scripts/run-webkit-tests:
2006
2007 2007-10-29  Antti Koivisto  <antti@apple.com>
2008
2009         Reviewed by Maciej.
2010
2011         Build media support by default on OSX only.
2012
2013         * Scripts/build-webkit:
2014
2015 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2016
2017         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2018         get caught by the pre-commit hooks.
2019
2020 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2021
2022         Reviewed by Adam.
2023
2024         - This is a collection of relatively unrelated changes and cleanups
2025         to Drosera to prepare it for interacting with WebKit.  A lot of these
2026         changes are just correcting mistakes, for example removing included
2027         headers that are no longer needed.
2028
2029         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2030         this will be needed by the DebuggerClient.
2031         (DebuggerDocument::server):
2032         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2033         * Drosera/win/DebuggerClient.cpp:
2034         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2035         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2036         (DebuggerClient::createWebViewWithRequest): Added comment about its
2037         purpose.
2038         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2039         declarations.
2040         (DebuggerClient::webViewLoaded): Moved.
2041         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2042         file, since this was the only place it was used.
2043         (cfStringToBSTR):
2044         * Drosera/win/Drosera.h: Cleaned up the includes.
2045         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2046         * Drosera/win/HelperFunctions.h: Removed.
2047
2048 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2049
2050         Reviewed by Adam.
2051
2052         - Small cleanup in the ServerConnection class.
2053
2054         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2055         and added an include.
2056         (ServerConnection::currentFrame):
2057         (ServerConnection::getCallerFrame):
2058         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2059         made a pointer into a COMPtr, and cleaned up the includes.
2060
2061 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2062
2063         Reviewed by John Sullivan.
2064
2065         - Place the Localizable.strings file in mac or win directories
2066           if that location exists.
2067         - Also look for UI_STRING in .c files.
2068
2069         * Scripts/extract-localizable-strings:
2070
2071 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2072
2073         Reviewed by Adam.
2074
2075         - Set the eol-style to native and made all the line endings the same
2076         so that I avoid messy diffs that show eol changes.
2077
2078         * Drosera/win/ServerConnection.cpp:
2079         (ServerConnection::didParseSource):
2080         (ServerConnection::didEnterCallFrame):
2081         (ServerConnection::willExecuteStatement):
2082         (ServerConnection::willLeaveCallFrame):
2083         (ServerConnection::exceptionWasRaised):
2084
2085 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2086
2087         Reviewed by Adam.
2088
2089         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2090         functionality that could not have existed previously without the new
2091         interfaces.
2092         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2093         from a BSTR to a JSValueRef.
2094         (DebuggerDocument::platformEvaluateScript): Implemented.
2095         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2096         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2097         Implemented.
2098         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2099         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2100         * Drosera/win/ServerConnection.cpp: Added a helper function.
2101         (ServerConnection::getCallerFrame):
2102         * Drosera/win/ServerConnection.h: Added a helper function.
2103
2104 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2105
2106         updated reviewers for my previous changelog.
2107
2108 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2109         Reviewed by Maciej and Adam and Geoff.
2110
2111         - Minor mac-side improvements including moving a function to a more
2112         appropriate location, fixing a warning, and correctly checking
2113         exceptions.
2114
2115         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2116         (DebuggerDocument::willExecuteStatement):
2117         (DebuggerDocument::didEnterCallFrame):
2118         (DebuggerDocument::willLeaveCallFrame):
2119         (DebuggerDocument::windowScriptObjectAvailable):
2120         (DebuggerDocument::callFunctionOnObject):
2121         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2122         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2123         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2124         because it doesn't require the ServerConnection at all.
2125         (NSStringCreateWithJSStringRef): Made an argument const.
2126         (JSValueRefCreateWithNSString): Made an argument const.
2127         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2128         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2129         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2130         * Drosera/mac/ServerConnection.mm: Ditto.
2131         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2132
2133 2007-10-29  Sam Weinig  <sam@webkit.org>
2134
2135         Reviewed by Adam Roben.
2136
2137         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2138
2139         * DumpRenderTree/LayoutTestController.cpp:
2140         (LayoutTestController::LayoutTestController):
2141         (getGlobalFlagCallback):
2142         (setGlobalFlagCallback):
2143         (LayoutTestController::getJSClass):
2144         (LayoutTestController::staticValues):
2145         * DumpRenderTree/LayoutTestController.h:
2146         (LayoutTestController::globalFlag):
2147         (LayoutTestController::setGlobalFlag):
2148
2149 2007-10-29  Darin Adler  <darin@apple.com>
2150
2151         Reviewed by Maciej.
2152
2153         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2154         resolution instead of its default.
2155
2156 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2157
2158         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2159
2160         Reviewed by Mark Rowe.
2161
2162         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2163         was successfully resolved, but this would not show any status because the change had
2164         already been cached in the index using "git add".  The solution is to add an optional
2165         second argument to showStatus() which adds the "--cached" switch to the command.
2166
2167         * Scripts/resolve-ChangeLogs:
2168         (showStatus):
2169
2170 2007-10-28  Eric Seidel  <eric@webkit.org>
2171
2172         Reviewed by Maciej and Geoff, in unison.
2173
2174         * Scripts/run-webkit-tests: remove broken --svg option
2175
2176 2007-10-28  Darin Adler  <darin@apple.com>
2177
2178         Reviewed by Adam.
2179
2180         * Scripts/run-sunspider: Default to "Release" configuration rather than
2181         defaulting to the last configuration used as other scripts do. This can
2182         still be overriden on the command line with "--debug" if there's some
2183         reason to do so. Also fix a typo.
2184
2185         * Scripts/sunspider-compare-results: Fix a typo.
2186
2187 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2188
2189         Reviewed by Adam.
2190
2191         - Implemented the WebScriptDebugListener functions now that the
2192         WebScriptDebugServer exists
2193
2194         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2195         functions.
2196         (ServerConnection::currentFrame):
2197         (ServerConnection::didLoadMainResourceForDataSource):
2198         (ServerConnection::didParseSource):
2199         (ServerConnection::failedToParseSource):
2200         (ServerConnection::didEnterCallFrame):
2201         (ServerConnection::willExecuteStatement):
2202         (ServerConnection::willLeaveCallFrame):
2203         (ServerConnection::exceptionWasRaised):
2204         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2205         members arguments list.
2206
2207 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2208
2209         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2210         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2211
2212         Reviewed by Darin.
2213
2214         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2215         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2216         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2217         file.  Note that it may also be used as a stand-alone script.
2218
2219         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2220         * Scripts/resolve-ChangeLogs: Added.
2221         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2222
2223 2007-10-26  Mark Rowe  <mrowe@apple.com>
2224
2225         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2226         to the Qt port on the assumption that it was an implementation of the cross-platform
2227         LayoutTestController class.  It is not, so it did not need to be changed.
2228
2229         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2230
2231 2007-10-25  Mark Rowe  <mrowe@apple.com>
2232
2233         Reviewed by Maciej.
2234
2235         Fix builds with code coverage enabled.
2236
2237         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2238
2239 2007-10-25  Darin Adler  <darin@apple.com>
2240
2241         Reviewed by Mark Rowe.
2242
2243         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2244         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2245
2246 2007-10-25  Stephanie  <slewis@apple.com>
2247
2248         build Fix
2249
2250         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2251
2252 2007-10-25  Stephanie  <slewis@apple.com>
2253
2254         Reviewed by Mark Rowe, Adam Roben.
2255
2256         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2257
2258         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2259
2260 2007-10-25  Alice Liu  <alice.liu@apple.com>
2261
2262         Reviewed by Adam.
2263
2264         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2265
2266         Moving destructor into platform-specific files
2267         * DumpRenderTree/LayoutTestController.cpp:
2268         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2269         (LayoutTestController::~LayoutTestController):
2270         * DumpRenderTree/qt/jsobjects.cpp:
2271         (LayoutTestController::~LayoutTestController):
2272
2273         LayoutTestController wasn't being destroyed
2274         * DumpRenderTree/win/DumpRenderTree.cpp:
2275         (runTest):
2276
2277         Added declspec
2278         * DumpRenderTree/win/EditingDelegate.h:
2279
2280         Reset certain values on the webview (or related delegate) that might
2281         have changed while running a test
2282         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2283         (LayoutTestController::~LayoutTestController):
2284
2285 2007-10-25  Adam Roben  <aroben@apple.com>
2286
2287         Make sunspider-compare-results work with relative paths
2288
2289         Reviewed by Sam.
2290
2291         * Scripts/sunspider-compare-results: Convert arguments to absolute
2292         paths before we chdir.
2293
2294 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2295
2296         Reviewed by Sam.
2297
2298         - Implemented server calls now the WebScriptDebugServer exists.
2299         - Also removed no longer needed call to initialize CG.
2300
2301         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2302         automatically now.
2303         (_tWinMain):
2304         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2305         (ServerConnection::ServerConnection):
2306         (ServerConnection::~ServerConnection):
2307         (ServerConnection::pause):
2308         (ServerConnection::resume):
2309         (ServerConnection::stepInto):
2310         (ServerConnection::applicationTerminating):
2311         (ServerConnection::serverConnectionDidDie):
2312         * Drosera/win/ServerConnection.h: Now uses the COM class.
2313
2314 2007-10-24  George Staikos  <staikos@kde.org>
2315
2316         Unbreak Qt build.
2317
2318         * Scripts/build-webkit:
2319
2320 2007-10-24  Adam Roben  <aroben@apple.com>
2321
2322         Remove now-unnecessary call to InitializeCoreGraphics
2323
2324         WebKit takes care of this now.
2325
2326         Reviewed by Ada.
2327
2328         * DumpRenderTree/win/DumpRenderTree.cpp:
2329         (initialize):
2330
2331 2007-10-24  Adam Roben  <aroben@apple.com>
2332
2333         Use WebTextRenderer in DRT
2334
2335         Reviewed by Ada.
2336
2337         * DumpRenderTree/win/DumpRenderTree.cpp:
2338         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2339
2340 2007-10-24  Sven Herzberg  <sven@imendio.com>
2341
2342         Reviewed by Mark Rowe.
2343
2344         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2345         Bug 15614: [GTK] qmake based backends don't build on OS X
2346
2347         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2348         GTK backend on a Mac
2349         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2350         isDarwin() to make it reusable in other places (like the workaround-
2351         for-prebuilt-qmake in build-webkit)
2352
2353 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2354
2355         Refurbish update-webkit script.
2356
2357         Reviewed by Adam.
2358
2359         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2360         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2361         multi-argument version of system() for flexibility and security.  Check for existence
2362         of Internal directory using -d test instead of -x.
2363
2364 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2365
2366         Minor clean-up of prepare-ChangeLog script.
2367
2368         Reviewed by Adam.
2369
2370         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2371         of a string.  Use multi-argument versions of open() and system() for flexibility and
2372         security.
2373
2374 2007-10-24  Alice Liu  <alice.liu@apple.com>
2375
2376         Reviewed by Oliver.
2377
2378         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2379
2380         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
2381         replay the saved events when we're still processing the mousedown that starts the drag
2382         * DumpRenderTree/win/EventSender.cpp:
2383         (doMouseMove):
2384         * DumpRenderTree/win/UIDelegate.cpp:
2385         (UIDelegate::doDragDrop):
2386
2387 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2388
2389         Reviewed by Sam, Steve and Darin.
2390
2391         - Stubbed out the WebScriptDebugListener functionality in the Server
2392         Connection class to prepare it for receiving those callbacks.
2393         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2394         and the ServerConnection to not need to be initialized with a server
2395         name, since that is not the way we connect to the WebKit server.
2396
2397         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2398         no exception.  Now it only loggs when there is an exception
2399         (DebuggerDocument::willExecuteStatement):
2400         (DebuggerDocument::didEnterCallFrame):
2401         (DebuggerDocument::willLeaveCallFrame):
2402         (DebuggerDocument::windowScriptObjectAvailable):
2403         (DebuggerDocument::callFunctionOnObject):
2404         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2405         to be instantiated with a server's name.
2406         (DebuggerClient::DebuggerClient):
2407         (DebuggerClient::didFinishLoadForFrame):
2408         * Drosera/win/DebuggerClient.h: Removed unsued variable.
2409         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
2410         a server name.
2411         (Drosera::init):
2412         (Drosera::initServer):
2413         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
2414         instantiated with a server's name.
2415         * Drosera/win/ServerConnection.cpp:
2416         (ServerConnection::ServerConnection): No longer needs a server name
2417         (ServerConnection::~ServerConnection): Only release the global context
2418         if there is one.
2419         (ServerConnection::serverConnectionDidDie): Stub for
2420         IWebScriptDebugListener
2421         (ServerConnection::QueryInterface): ditto
2422         (ServerConnection::AddRef): ditto
2423         (ServerConnection::Release): ditto
2424         (ServerConnection::didLoadMainResourceForDataSource): ditto
2425         (ServerConnection::didParseSource): ditto
2426         (ServerConnection::failedToParseSource): ditto
2427         (ServerConnection::didEnterCallFrame): ditto
2428         (ServerConnection::willExecuteStatement): ditto
2429         (ServerConnection::willLeaveCallFrame): ditto
2430         (ServerConnection::exceptionWasRaised): ditto
2431         * Drosera/win/ServerConnection.h: Stubbed out the
2432         IWebScriptDebugListener functions, and this class no longer needs to be
2433         instantiated with a server name.
2434
2435 2007-10-24  Lars Knoll  <lars@trolltech.com>
2436
2437         Reviewed by Simon.
2438
2439         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
2440
2441         * DumpRenderTree/qt/jsobjects.h:
2442
2443 2007-10-24  Lars Knoll  <lars@trolltech.com>
2444
2445         Reviewed by Simon.
2446
2447         add another command.
2448
2449         * DumpRenderTree/qt/jsobjects.cpp:
2450         (TextInputController::doCommand):
2451
2452 2007-10-24  Lars Knoll  <lars@trolltech.com>
2453
2454         Reviewed by Simon.
2455
2456         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
2457
2458         * DumpRenderTree/qt/jsobjects.cpp:
2459         (EventSender::keyDown):
2460         * DumpRenderTree/qt/jsobjects.h:
2461
2462 2007-10-24  Lars Knoll  <lars@trolltech.com>
2463
2464         Reviewed by Simon.
2465
2466         implement eventSender.keyDown().
2467
2468         * DumpRenderTree/qt/jsobjects.cpp:
2469         (EventSender::keyDown):
2470
2471 2007-10-24  Lars Knoll  <lars@trolltech.com>
2472
2473         Reviewed by Simon.
2474
2475         some smaller fixes to the editing support in DRT. Makes another few tests pass.
2476
2477         * DumpRenderTree/qt/DumpRenderTree.cpp:
2478         (WebCore::DumpRenderTree::DumpRenderTree):
2479         (WebCore::DumpRenderTree::initJSObjects):
2480         * DumpRenderTree/qt/jsobjects.cpp:
2481         (TextInputController::doCommand):
2482
2483 2007-10-24  Lars Knoll  <lars@trolltech.com>
2484
2485         Reviewed by Simon.
2486
2487         first bit of implementation for the textinputcontroller.
2488
2489         * DumpRenderTree/qt/DumpRenderTree.cpp:
2490         (WebCore::DumpRenderTree::DumpRenderTree):
2491         * DumpRenderTree/qt/DumpRenderTree.h:
2492         * DumpRenderTree/qt/jsobjects.cpp:
2493         (TextInputController::TextInputController):
2494         (TextInputController::doCommand):
2495         * DumpRenderTree/qt/jsobjects.h:
2496
2497 2007-10-24  Lars Knoll  <lars@trolltech.com>
2498
2499         Reviewed by Simon.
2500
2501         make the man webpage believe it has focus, so the editing tests work correctly.
2502
2503         * DumpRenderTree/qt/DumpRenderTree.cpp:
2504         (WebCore::DumpRenderTree::DumpRenderTree):
2505
2506 2007-10-24  Lars Knoll  <lars@trolltech.com>
2507
2508         Reviewed by Simon.
2509
2510         implement layoutTestController.dumpEditingCallbacks() correctly.
2511
2512         * DumpRenderTree/qt/DumpRenderTree.cpp:
2513         (WebCore::DumpRenderTree::DumpRenderTree):
2514         * DumpRenderTree/qt/jsobjects.cpp:
2515         (LayoutTestController::reset):
2516         (LayoutTestController::dumpEditingCallbacks):
2517
2518 2007-10-24  Lars Knoll  <lars@trolltech.com>
2519
2520         Reviewed by Simon.
2521
2522         Implement support for testing editing.
2523
2524         * DumpRenderTree/qt/DumpRenderTree.cpp:
2525         (WebCore::DumpRenderTree::DumpRenderTree):
2526
2527 2007-10-23  Sam Weinig  <sam@webkit.org>
2528
2529         Check for null BSTR that can be passed to the UIDelegate methods
2530         from javascript null and undefined.  Fixes a failing test case on
2531         Windows (fast/dom/Window/alert-undefined.html)
2532
2533         Reviewed by Eric Seidel.
2534
2535         * DumpRenderTree/win/UIDelegate.cpp:
2536         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2537         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2538         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2539         (UIDelegate::webViewAddMessageToConsole):
2540
2541 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2542
2543         Reviewed by Darin.
2544
2545         Don't print a massive pile of setenvs from tools that automatically build testkjs.
2546
2547         * Scripts/build-testkjs:
2548
2549 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
2550
2551         Reviewed by Darin.
2552
2553         - add wrapper that finds the right copy of testkjs
2554
2555         * Scripts/sunspider-compare-results: Added.
2556
2557 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
2558
2559         Reviewed by Sam.
2560
2561         - After talking with Steve I now see that the WebKit server must be
2562         running for DCOM to create the distributed objects, which makes sense
2563         and currently WebKit only allows one instance to be running at a time
2564         which avoids accidentally connecting to the wrong server
2565         - In light of this I have removed the code for the attach box and
2566         NotificationServer and known server names, since they are all extranious
2567         now.
2568
2569         * Drosera/win/Drosera.cpp: Removed notification classes and known server
2570         names.
2571         (_tWinMain): Uses init instead of initUI.
2572         (droseraWndProc): No longer creats an attach dialog box.
2573         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
2574         it's not manditory to call init before doing COM stuff.
2575         (Drosera::init): calls initUI and will call attach when the
2576         functionality exists.
2577         (Drosera::initUI): Has changed very little.
2578         (Drosera::attach): Changed the signature to reflect that we no longer
2579         need the dictionary of known server names.
2580         * Drosera/win/Drosera.h: Removed notification classes and known server
2581         names.  Also renamed and moved some functions.
2582         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
2583         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
2584         headers to the resources folder.
2585         * Drosera/win/resource.h: Removed the Attach box.
2586
2587 2007-10-22  Adam Roben  <aroben@apple.com>
2588
2589         Windows build fix
2590
2591         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
2592
2593 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
2594
2595         - Removed a leak that was fixed.
2596
2597         * Scripts/run-webkit-tests:
2598
2599 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2600
2601         Reviewed by Darin.
2602
2603         - Changed the Client so that the DebuggerDocument now own the
2604         ServerConnection.  This simplifies ownership and cleanup.
2605
2606         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
2607         ServerConnection.
2608         (DebuggerClient::initWithServerName):
2609         (DebuggerClient::didFinishLoadForFrame):
2610         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the
2611         ServerConnection.
2612         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
2613         until after we have a server which we are attached to.
2614         (Drosera::initUI):
2615         (Drosera::attach):
2616         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
2617         out previously.
2618
2619 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2620
2621         Reviewed by Nikolas.
2622
2623         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
2624
2625         * Scripts/run-javascriptcore-tests:
2626
2627 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2628
2629         Reviewed by Nikolas.
2630
2631         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
2632
2633         * Scripts/build-drosera:
2634         * Scripts/build-dumprendertree:
2635         * Scripts/build-testkjs:
2636         * Scripts/build-webkit:
2637         * Scripts/run-javascriptcore-tests:
2638         * Scripts/run-sunspider:
2639         * Scripts/run-webkit-tests:
2640         * Scripts/webkitdirs.pm:
2641
2642 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
2643
2644         Reviewed by Mark Rowe.
2645
2646         Fix for local database support after r26879
2647         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
2648
2649         * Scripts/build-webkit:
2650
2651 2007-10-22  Holger Freyther  <zecke@selfish.org>
2652
2653         Reviewed by Simon Hausmann <hausmann@kde.org>.
2654
2655         - Do not build testkjs as an application bundle. This is
2656         needed for run-javascriptcore-tests on OSX.
2657         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
2658         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
2659         as we do not have -rpath on OSX.
2660
2661         * DumpRenderTree/qt/DumpRenderTree.pro:
2662         * Scripts/run-webkit-tests:
2663
2664 2007-10-22  Simon Hausmann  <hausmann@kde.org>
2665
2666         Reviewed by aroben.
2667
2668         Fix support for Signed-off-by detection in prepare-ChangeLog
2669         --git-commit. The Signed-off-by tag does not appear in the header
2670         but usually at the end.
2671
2672         * Scripts/prepare-ChangeLog:
2673
2674 2007-10-21  Mark Rowe  <mrowe@apple.com>
2675
2676         Reviewed by Eric.
2677
2678         Fix run-javascriptcore-tests for Gtk.
2679
2680         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
2681
2682 2007-10-20  Eric Seidel  <eric@webkit.org>
2683
2684         Reviewed by aroben.
2685
2686         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
2687
2688 2007-10-20  Eric Seidel  <eric@webkit.org>
2689
2690         Reviewed by darin.
2691
2692         Add improved argument handling to run-sunspider, including
2693         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
2694         Also re-factor code into subroutines
2695
2696         * Scripts/build-dumprendertree: removed bogus comments
2697         * Scripts/build-testkjs: Added.
2698         * Scripts/run-javascriptcore-tests: use build-testkjs
2699         * Scripts/run-sunspider: improved argument handling, abstraction
2700         * Scripts/run-webkit-tests: improved abstraction
2701
2702 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
2703
2704         Not reviewed, Windows build fix.
2705
2706         * DumpRenderTree/win/EventSender.cpp:
2707         (keyDownCallback):
2708
2709 2007-10-20  Darin Adler  <darin@apple.com>
2710
2711         Reviewed by Tim Hatcher.
2712
2713         - http://bugs.webkit.org/show_bug.cgi?id=15544
2714           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
2715           not rely on Apple-specific key codes
2716
2717         * DumpRenderTree/mac/EventSendingController.mm:
2718         (-[EventSendingController keyDown:withModifiers:]):
2719         Added named key "rightArrow". Later we could have a whole table of these.
2720         Also tweaked modifiers code a little.
2721
2722         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
2723
2724 2007-10-19  Darin Adler  <darin@apple.com>
2725
2726         Reviewed by Eric.
2727
2728         - http://bugs.webkit.org/show_bug.cgi?id=15566
2729           possible fix for leak seen in DumpRenderTree
2730
2731         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
2732         Delete the item if it's not put on the queue, since the caller has
2733         no way of knowing that. Would be better to have the parameter type
2734         be auto_ptr to express the fact that we take ownership.
2735
2736         - unrelated change
2737
2738         * Drosera/mac/main.m: Add missing include.
2739
2740 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2741
2742         Reviewed by Adam.
2743
2744         - This change should be identical but for some reason was not working
2745         on my machine.
2746
2747         * Scripts/prepare-ChangeLog:
2748
2749 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2750
2751         Reviewed by Oliver and Tim.
2752
2753         - Made use of RetainPtr to avoid retain and release issues and moved the
2754         log function to DebuggerDocumentPlatform, which seems to be a more
2755         logical place for it to live.
2756         - Also moved knownServers from the ServerConnection to
2757         DebuggerApplication to match the Windows code and because it makes sense
2758         that a connection knows its own server but not all of them.
2759
2760         * Drosera/mac/DebuggerClient.h: Moved the log function to
2761           DebuggerDocumentPlatform.
2762         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
2763           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
2764           call for the server name up from the ServerConnection class.
2765         (-[DebuggerClient dealloc]):
2766         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
2767           for the server name up from the ServerConnection.
2768         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
2769         (DebuggerDocument::platformPause):
2770         (DebuggerDocument::platformResume):
2771         (DebuggerDocument::platformStepInto):
2772         (DebuggerDocument::platformEvaluateScript):
2773         (DebuggerDocument::getPlatformCurrentFunctionStack):
2774         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2775         (DebuggerDocument::platformValueForScopeVariableNamed):
2776         (DebuggerDocument::platformLog): Log directly from here. No need to call
2777           DebuggerClient.
2778         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
2779           way I see it, a ServerConnection should only know about its connection
2780           and the group of all possible servers should be kept by the
2781           application.
2782         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
2783           currentServerName, it makes sense that the connection should know that
2784           name.
2785         (-[ServerConnection currentServerName]):
2786
2787 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
2788
2789         Reviewed by Adam.
2790
2791         - Integrated changes from mac drosera.  Recently I've encapsulated
2792         out the server connection object from the rest of Drosera because
2793         it is very platform dependent right now and RPC is not implemented on
2794         windows.  This functionality, of communicating with the WebKit server
2795         is the next area I will be focusing on in Windows.
2796
2797         - Other changes and cleanup were made to organize the code and add notes
2798         on which parts still need work.  Also some mac code is added and
2799         commented out, to act as pseudocode for the logic of those parts.
2800
2801         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
2802           pointer.
2803         * Drosera/config.h: Added whitespace.
2804         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
2805           these files got moved into Drosera.h/cpp
2806         * Drosera/win/DebuggerApplication.h: Removed.
2807         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring
2808           happened here to better match the logic flow of the same code on the
2809           mac side and to use the new ServerConnection class.
2810         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
2811         (DebuggerClient::initWithServerName): Initializer that will set up the
2812           class to use a ServerConnection object.  This was necessary so I could
2813           create a DebuggerClient without having to initilaize it at
2814           construction.
2815         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
2816           will be the UIDelegate and FrameLoadDelegate.
2817         (DebuggerClient::AddRef): For IUnknown.
2818         (DebuggerClient::Release): For IUnknown.
2819         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
2820           this still needs to set the global context of the server, but
2821           IWebFrame does not have an accessor for the global context yet.
2822         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
2823           this is a pass through for the same function in the document.
2824         (DebuggerClient::didReceiveTitle): Unimplemented part of
2825           FrameLoadDelegate this would change the title of the window.
2826         (DebuggerClient::createWebViewWithRequest): Part of the
2827           FrameLoadDelegate.  This is about new windows via Window.open() and
2828           how their delegates are set.
2829         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
2830           UIDelegate.  Just a debug function for printing messages.
2831         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
2832           because the Client should be the UIDelegate and FrameLoadDelegate
2833           to match the delegates on mac.
2834         (DebuggerClient::webViewLoaded): Added accessor method.
2835         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
2836           forgotten to add this file before.  This is where the platform
2837           dependent versions of the Documents functions live. Most of these are
2838           unimplemented because some piece of functionality does not exist on
2839           Windows yet.
2840         (DebuggerDocument::platformPause):
2841         (DebuggerDocument::platformResume):
2842         (DebuggerDocument::platformStepInto):
2843         (DebuggerDocument::platformEvaluateScript):
2844         (DebuggerDocument::getPlatformCurrentFunctionStack):
2845         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2846         (DebuggerDocument::platformValueForScopeVariableNamed):
2847         (DebuggerDocument::platformLog):
2848         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
2849           responsibilities becaue they belong in the Client. Also I laid the
2850           groundwork for attaching Drosera to a WebKit process
2851         (attachWndProc): Now if a server is selected the Client becomes it's
2852           delegate.
2853         (Drosera::Drosera): Added the construction of the Client and dictionary
2854           of server names.
2855         (Drosera::initUI): This is no longer the delegates, the Client is.
2856         (Drosera::webViewLoaded): Now asks the Client instead of holding local
2857           state.
2858         (Drosera::applicationDidFinishLaunching): Placeholder for needed
2859           notification registration when it's possible to implement.
2860         (Drosera::serverLoaded): Ditto
2861         (Drosera::serverUnloaded): Ditto
2862         (Drosera::attach): Attach Drosera to the WebKit server.
2863         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
2864         (Drosera::getInst):
2865         (Drosera::setInst):
2866         (Drosera::knownServers):
2867         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
2868           and added the ServerConnection.
2869         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
2870         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
2871           Most of the functions are completely unimlemented because they cannot
2872           connect with the WebKit server, because one does not exist on Windows
2873           yet.
2874         (ServerConnection::initWithServerName):
2875         (ServerConnection::~ServerConnection):
2876         (ServerConnection::setGlobalContext):
2877         (ServerConnection::pause):
2878         (ServerConnection::resume):
2879         (ServerConnection::stepInto):
2880         (ServerConnection::switchToServerNamed):
2881         (ServerConnection::applicationTerminating):
2882         (ServerConnection::serverConnectionDidDie):
2883         (ServerConnection::currentFrame):
2884         * Drosera/win/ServerConnection.h: Added. Ditto.
2885         (ServerConnection::ServerConnection):
2886
2887 2007-10-19  Alice Liu  <alice.liu@apple.com>
2888
2889         Reviewed by Darin.
2890
2891         Fix for these broken layout tests on Windows:
2892
2893         fast/forms/focus-selection-input.html
2894         fast/forms/focus-selection-textarea.html
2895         fast/forms/select-accesskey.html
2896
2897         * DumpRenderTree/win/EventSender.cpp:
2898         (keyDownCallback):
2899         correct the VK code for alt key.
2900
2901 2007-10-19  Eric Seidel  <eric@webkit.org>
2902
2903         Reviewed by Mark Rowe.
2904
2905         Make the GtkLauncher code slightly more readable.
2906
2907         * GtkLauncher/main.cpp:
2908         (setupMainMenu): Added.
2909         (setupMainWindowUI): Added.
2910         (main):
2911
2912 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
2913
2914         Rubber stamped by Adam.
2915
2916         - don't delay-load WebKit in DumpRenderTree.
2917
2918         * DumpRenderTree/win/DumpRenderTree.vcproj:
2919
2920 2007-10-18  Dan Bernstein  <mitz@apple.com>
2921
2922         Reviewed by Adam Roben.
2923
2924         - fix <rdar://problem/5313523>
2925         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
2926
2927         * DumpRenderTree/mac/DumpRenderTree.mm:
2928         (dump): Changed to use _responseMIMEType.
2929
2930 2007-10-17  Adam Roben  <aroben@apple.com>
2931
2932         Make it possible to have Windows-specific tests and results
2933
2934         When searching for tests to run and the Skipped file, we will only
2935         look in platform/win and the cross-platform directory. When looking
2936         for expected results, we will look in platform/win, then
2937         platform/mac-leopard, then platform/mac, then finally the
2938         cross-platform directory.
2939
2940         Reviewed by Sam.
2941
2942         * Scripts/run-webkit-tests:
2943         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
2944         searching in the cross-platform directory.
2945         (sub buildPlatformHierarchy): Removed some unneeded calls to
2946         dirname/basename.
2947
2948 2007-10-17  Adam Roben  <aroben@apple.com>
2949
2950         Add back the call to register WebKit that we had before WebKitInitializer existed
2951
2952         This is needed to ensure that the right WebKit is used when
2953         instantiating COM objects.
2954
2955         Reviewed by Oliver.
2956
2957         * DumpRenderTree/win/debug_internal.vsprops: Define
2958         DEBUG_WEBKIT_HAS_SUFFIX.
2959         * DumpRenderTree/win/DumpRenderTree.cpp:
2960         (initialize):
2961
2962 2007-10-17  Adam Roben  <aroben@apple.com>
2963
2964         Import File::Basename in webkitdirs since we use it
2965
2966         * Scripts/webkitdirs.pm:
2967
2968 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
2969
2970         - Updated the tiger leaks list to make the internal bots green.
2971
2972         * Scripts/run-webkit-tests:
2973
2974 2007-10-17  Adam Roben  <aroben@apple.com>
2975
2976         Build fix for VC++ Express
2977
2978         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
2979         and ole32.lib.
2980
2981 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2982
2983         Reviewed by Sam.
2984
2985         - Minor mac improvements based on observations I made while implementing the
2986         Windows code.
2987
2988         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
2989         then hand it to the Client who will retain it, it should just be the client who
2990         creates and owns the server.
2991         (-[DebuggerApplication attach:]):
2992         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
2993         * Drosera/mac/DebuggerClient.mm: Creates the server.
2994         (-[DebuggerClient initWithServerName:]):
2995         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
2996         can instead forward declare what it needs.
2997
2998 2007-10-16  Darin Adler  <darin@apple.com>
2999
3000         Reviewed by Geoff Garen.
3001
3002         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
3003         want to turn failing tests into platform-specific test results. Also did a
3004         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
3005         would take the type of results into account only some of the time.
3006
3007 2007-10-16  Adam Roben  <aroben@apple.com>
3008
3009         Add a new nightly launcher script for Windows
3010
3011         This new script is for versions of Safari that don't delay-load
3012         WebKit. I had to make FindSafari be able to print out the nightly
3013         launcher script on stdout because Windows shell scripts can't capture
3014         the output from a command into an environment variable.
3015
3016         Reviewed by Steve.
3017
3018         * FindSafari/FindSafari.cpp:
3019         (_tmain): Added /printSafariLauncher option.
3020         * Scripts/run-webkit-nightly.cmd: Added.
3021
3022 2007-10-16  Adam Roben  <aroben@apple.com>
3023
3024         Replace WebKitInitializer with FindSafari
3025
3026         We now rely on setting the PATH environment variable to tell Windows
3027         where to find WebKit and its dependencies (similar to
3028         DYLD_FRAMEWORK_PATH on Mac).
3029
3030         This change also make DumpRenderTree no longer delay-load WebKit.
3031
3032         Reviewed by Sam.
3033
3034         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
3035         FindSafari.
3036         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
3037         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
3038         WebKitInitializer, don't delay-load WebKit.
3039         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
3040         * Scripts/run-webkit-tests: Ditto.
3041         * Scripts/webkitdirs.pm:
3042         (sub setPathForRunningWebKitApp): Added.
3043         * WebKitInitializer/WebKitInitializer.cpp: Removed.
3044         * WebKitInitializer/WebKitInitializer.h: Removed.
3045         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
3046         * WebKitInitializer/debug.vsprops: Removed.
3047         * WebKitInitializer/debug_internal.vsprops: Removed.
3048         * WebKitInitializer/release.vsprops: Removed.
3049
3050 2007-10-16  Adam Roben  <aroben@apple.com>
3051
3052         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
3053
3054         http://bugs.webkit.org/show_bug.cgi?id=15532
3055
3056         FindSafari simply prints the location of an installed Safari.exe on
3057         stdout.
3058
3059         Reviewed by Darin.
3060
3061         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
3062         (getStringValue):
3063         (getWebViewCLSID):
3064         (getInstalledWebKitDirectory):
3065         (_tmain):
3066         * FindSafari/FindSafari.vcproj: Added.
3067         * Scripts/webkitdirs.pm:
3068         (sub installedSafariPath): Added. Calls FindSafari on Windows.
3069
3070 2007-10-16  Adam Roben  <aroben@apple.com>
3071
3072         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
3073
3074         Reviewed by Kevin McCullough.
3075
3076         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
3077         when referring to WebKit.dll.
3078         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
3079         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
3080         * DumpRenderTree/win/release.vsprops: Ditto.
3081         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
3082         never have a _debug suffix on WebKit.dll.
3083         * WebKitInitializer/WebKitInitializer.cpp:
3084         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
3085         specified.
3086         * WebKitInitializer/debug_internal.vsprops: Added
3087         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
3088
3089 2007-10-16  Darin Adler  <darin@apple.com>
3090
3091         Reviewed by Adele.
3092
3093         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
3094         Remove now-unneeded control/alt key hack; the tests have been updated.
3095
3096 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3097
3098         - Updated leaks list because our internal bot upgraded it's version of leopard and
3099         one of the leaks was fixed between that revision and the bot's previous version of
3100         leopard.
3101
3102         * Scripts/run-webkit-tests:
3103
3104 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
3105
3106         Reviewed by Tim.
3107
3108         - I encapsulated out the server connecton functionality because it is a specific part
3109         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
3110         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
3111         Windows.  So the majority of this patch is moving preexisting functionality.
3112
3113         - Also I removed the prefix header and changed to use config.h because it is more
3114         standard on how we use config.h in windows and it didn't make much sense to keep
3115         the prefix header and the config.h
3116
3117         * Drosera/DebuggerDocument.cpp:
3118         (DebuggerDocument::DebuggerDocument):
3119         * Drosera/DebuggerDocument.h:
3120         * Drosera/config.h:
3121         * Drosera/mac/DebuggerApplication.mm:
3122         (-[DebuggerApplication attach:]):
3123         * Drosera/mac/DebuggerClient.h:
3124         * Drosera/mac/DebuggerClient.mm:
3125         (-[DebuggerClient initWithServerConnection:]):
3126         (-[DebuggerClient dealloc]):
3127         (-[DebuggerClient windowDidLoad]):
3128         (-[DebuggerClient windowWillClose:]):
3129         (-[DebuggerClient webView:didFinishLoadForFrame:]):
3130         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
3131         * Drosera/mac/DebuggerDocumentPlatform.mm:
3132         (DebuggerDocument::platformPause):
3133         (DebuggerDocument::platformResume):
3134         (DebuggerDocument::platformStepInto):
3135         (DebuggerDocument::platformEvaluateScript):
3136         (DebuggerDocument::getPlatformCurrentFunctionStack):
3137         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3138         (DebuggerDocument::platformValueForScopeVariableNamed):
3139         (DebuggerDocument::platformLog):
3140         * Drosera/mac/Drosera.pch: Removed.
3141         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3142         * Drosera/mac/ServerConnection.h: Added.
3143         * Drosera/mac/ServerConnection.mm: Added.
3144         (-[ServerConnection initWithServerName:]):
3145         (-[ServerConnection dealloc]):
3146         (-[ServerConnection setGlobalContext:]):
3147         (-[ServerConnection pause]):
3148         (-[ServerConnection resume]):
3149         (-[ServerConnection stepInto]):
3150         (-[ServerConnection switchToServerNamed:]):
3151         (-[ServerConnection applicationTerminating:]):
3152         (-[ServerConnection serverConnectionDidDie:]):
3153         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3154         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
3155         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
3156         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
3157         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
3158         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
3159         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
3160         (-[ServerConnection currentFrame]):
3161         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
3162         (-[ServerConnection knownServers]):
3163
3164 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
3165
3166         Reviewed by Eric.
3167
3168         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
3169           Script to automatically search nightly builds for regressions (bisect-builds)
3170
3171         * Scripts/bisect-builds: Added.
3172
3173 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
3174
3175         Reviewed by Darin.
3176
3177         - New JavaScript benchmark
3178         http://bugs.webkit.org/show_bug.cgi?id=15515
3179
3180         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
3181         current development or release build of JavaScriptCore.
3182
3183 2007-10-15  Mark Rowe  <mrowe@apple.com>
3184
3185         Reviewed by Sam.
3186
3187         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
3188
3189         * Scripts/webkitdirs.pm:
3190         - Change checkArgv to remove the options from @ARGV to prevent
3191         them from interfering with further option processing.
3192         - Fix logic error in determineIsQt that would prevent it from bailing out early.
3193         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
3194         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
3195         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
3196
3197 2007-10-15  Darin Adler  <darin@apple.com>
3198
3199         Reviewed by Sam.
3200
3201         - added logging of window.prompt and window.confirm
3202
3203         * DumpRenderTree/mac/UIDelegate.mm:
3204         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
3205         Implement the recommended delegate rather than the deprecated one.
3206         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
3207         Added.
3208         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
3209         Added.
3210
3211         * DumpRenderTree/win/UIDelegate.h:
3212         * DumpRenderTree/win/UIDelegate.cpp:
3213         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
3214         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
3215         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
3216         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
3217
3218 2007-10-15  Alice Liu  <alice.liu@apple.com>
3219
3220         Reviewed by Sam Weinig.
3221
3222         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
3223
3224         * DumpRenderTree/win/DumpRenderTree.cpp:
3225         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
3226         (main): allocate the global policy delegate for DRT's custom use
3227         * DumpRenderTree/win/DumpRenderTree.vcproj:
3228         Adding files to project
3229         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
3230         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3231         (LayoutTestController::setCustomPolicyDelegate):
3232         set the webview's policy delegate to DRT's custom one if the test requests it.
3233         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
3234         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
3235         (PolicyDelegate::PolicyDelegate):
3236         (PolicyDelegate::QueryInterface):
3237         (PolicyDelegate::AddRef):
3238         (PolicyDelegate::Release):
3239         (PolicyDelegate::decidePolicyForNavigationAction):
3240         * DumpRenderTree/win/PolicyDelegate.h: Added.
3241         (PolicyDelegate::decidePolicyForNewWindowAction):
3242         (PolicyDelegate::decidePolicyForMIMEType):
3243         (PolicyDelegate::unableToImplementPolicyWithError):
3244
3245 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
3246
3247         Reviewed by Mark.
3248
3249         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
3250         when querying for QMAKE_MKSPECS.
3251
3252 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
3253
3254         Reviewed by Adam Roben.
3255
3256         Fix run-webkit-tests is too greedy calculating platform hierarchy
3257         http://bugs.webkit.org/show_bug.cgi?id=15465
3258
3259         Fix run-webkit-tests being too greedy in trying to split the platform name up
3260         causing it to try and find tests in every directory above the first "-" in the
3261         path to the LayoutTests
3262
3263         * Scripts/run-webkit-tests:
3264
3265 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
3266
3267         Reviewed by Darin.
3268
3269         http://bugs.webkit.org/show_bug.cgi?id=15006
3270         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
3271         to reduce code duplication.
3272
3273         * Scripts/build-webkit:
3274         * Scripts/webkitdirs.pm:
3275         buildQMakeProject() renamed to buildQMakeQtProject().
3276         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
3277         unused $colorize has been removed.
3278
3279 === Start merge of feature-branch 2007-10-12 ===
3280
3281 2007-10-08  Eric Seidel  <eric@webkit.org>
3282
3283         Reviewed by Mark Rowe.
3284
3285         * Scripts/build-webkit: add --help, remove unused --color
3286
3287 2007-10-07  Eric Seidel  <eric@webkit.org>
3288
3289         Reviewed by darin.
3290
3291         * Drosera/mac/DebuggerDocumentPlatform.mm:
3292         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
3293
3294 2007-10-03  Rob Buis  <buis@kde.org>
3295
3296         Reviewed by Olliej.
3297
3298         Adapt to changed location of Ahem font.
3299
3300         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3301
3302 2007-10-02  Eric Seidel  <eric@webkit.org>
3303
3304         Reviewed by Adam Roben.
3305
3306         Make pixel tests more useful!
3307         Finally fix the image diff 0.00% mystery problem
3308         Highlight any image differences in the image diff.
3309         Add a link from image diffs back to original test file.
3310
3311         * DumpRenderTree/mac/ImageDiff.m:
3312         (compareImages): highlight any differences
3313         (computePercentageDifferent): round to two decimal places
3314         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
3315
3316 2007-10-02  Eric Seidel  <eric@webkit.org>
3317
3318         Reviewed by Alexey Proskuryakov.
3319
3320         * Scripts/run-webkit-tests: print the % image difference on main results page
3321
3322 2007-10-02  Mark Rowe  <mrowe@apple.com>
3323
3324         Reviewed by Oliver.
3325
3326         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
3327
3328         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
3329         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
3330
3331 2007-10-01  Mark Rowe  <mrowe@apple.com>
3332
3333         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
3334
3335 2007-09-25  Eric Seidel  <eric@webkit.org>
3336
3337         Reviewed by Mark Rowe.
3338
3339         DerivedSources.make was finding "ENABLE_SVG" in the string
3340         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
3341         quite correctly.
3342
3343         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
3344
3345 2007-09-25  Mark Rowe  <mrowe@apple.com>
3346
3347         Rubber-stamped by Eric.
3348
3349         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
3350         This makes it possible to automate nightly builds for the feature-branch.
3351
3352 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
3353
3354         Rubber stamped by Mark.
3355
3356         Enable svg experimental features as default here in feature-branch.
3357
3358         * Scripts/build-webkit:
3359
3360 2007-06-29  Antti Koivisto  <antti@apple.com>
3361
3362         Reviewed by Weinig.
3363
3364         Add VIDEO flag for timed media features
3365
3366         * Scripts/build-webkit
3367
3368 === End merge of feature-branch 2007-10-12 ===
3369
3370 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3371
3372         Reviewed by Darin.
3373
3374         - Updated rational for the leaks list to be more clear.
3375
3376         * Scripts/run-webkit-tests:
3377
3378 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
3379
3380         Rubber Stamp by Sam.
3381
3382         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
3383         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
3384
3385         * Scripts/run-webkit-tests:
3386
3387 2007-10-10  Simon Hausmann  <hausmann@kde.org>
3388
3389         Reviewed by Lars.
3390
3391         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
3392         includes are needed for INT_MAX, std::auto_ptr and the like.
3393
3394         * DumpRenderTree/qt/main.cpp:
3395
3396 2007-10-09  Lars Knoll  <lars@trolltech.com>
3397
3398         Reviewed by Simon.
3399
3400         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
3401
3402         * DumpRenderTree/qt/jsobjects.cpp:
3403         (LayoutTestController::encodeHostName):
3404         (LayoutTestController::decodeHostName):
3405         * DumpRenderTree/qt/jsobjects.h:
3406
3407 2007-10-09  Lars Knoll  <lars@trolltech.com>
3408
3409         Reviewed by Simon.
3410
3411         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
3412
3413         * DumpRenderTree/qt/DumpRenderTree.cpp:
3414         (WebCore::WebPage::createFrame):
3415         (WebCore::DumpRenderTree::DumpRenderTree):
3416         (WebCore::DumpRenderTree::titleChanged):
3417         * DumpRenderTree/qt/DumpRenderTree.h:
3418         * DumpRenderTree/qt/jsobjects.cpp:
3419         (LayoutTestController::reset):
3420         * DumpRenderTree/qt/jsobjects.h:
3421
3422 2007-10-09  Lars Knoll  <lars@trolltech.com>
3423
3424         Reviewed by Simon.
3425
3426         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
3427
3428         * DumpRenderTree/qt/DumpRenderTree.h:
3429         * DumpRenderTree/qt/jsobjects.cpp:
3430         (LayoutTestController::clearBackForwardList):
3431         * DumpRenderTree/qt/jsobjects.h:
3432
3433 2007-10-09  Lars Knoll  <lars@trolltech.com>
3434
3435         Reviewed by Simon.
3436
3437         make --git-reviewer work again.
3438
3439         * Scripts/prepare-ChangeLog:
3440
3441 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
3442
3443         Rubber stamped by Eric.
3444
3445         Connect to the "hovering-over-link" signal emitted by WebKitPage and
3446         show the current link inside the statusbar.
3447         This shows how to make use of this signal and allows to easily test
3448         http://bugs.webkit.org/show_bug.cgi?id=15299.
3449
3450         * GtkLauncher/main.cpp:
3451         (hoveringOverLink):
3452         (main):
3453
3454 2007-10-05  Lars Knoll  <lars@trolltech.com>
3455
3456         add proper error messages to the FrameLoaderClient.
3457         Implement ChromeClientQt::closeWindowSoon and
3458         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
3459         Some fixes in DRT to make it work correctly with multiple windows.
3460
3461         Reviewed by Maciej.
3462
3463         * DumpRenderTree/qt/DumpRenderTree.cpp:
3464         (WebCore::DumpRenderTree::DumpRenderTree):
3465         (WebCore::DumpRenderTree::createWindow):
3466         (WebCore::DumpRenderTree::windowCount):
3467         * DumpRenderTree/qt/DumpRenderTree.h:
3468         * DumpRenderTree/qt/jsobjects.cpp:
3469         (LayoutTestController::maybeDump):
3470         (LayoutTestController::windowCount):
3471         * DumpRenderTree/qt/jsobjects.h:
3472
3473 2007-10-05  Lars Knoll  <lars@trolltech.com>
3474
3475         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
3476         Add support for layoutTextController.setCanOpenWindows() to DRT
3477         fixing another 2 test cases in fast/dom/Window.
3478
3479         Reviewed by Maciej.
3480
3481         * DumpRenderTree/qt/DumpRenderTree.cpp:
3482         (WebCore::WebPage::WebPage):
3483         (WebCore::WebPage::createWindow):
3484         (WebCore::DumpRenderTree::resetJSObjects):
3485         (WebCore::DumpRenderTree::createWindow):
3486         * DumpRenderTree/qt/DumpRenderTree.h:
3487         * DumpRenderTree/qt/DumpRenderTree.pro:
3488         * DumpRenderTree/qt/jsobjects.cpp:
3489         (LayoutTestController::LayoutTestController):
3490         (LayoutTestController::reset):
3491         * DumpRenderTree/qt/jsobjects.h:
3492         * DumpRenderTree/qt/main.cpp:
3493         * DumpRenderTree/qt/testplugin.cpp: Added.
3494         * DumpRenderTree/qt/testplugin.h: Added.
3495
3496 2007-10-04  Sam Weinig  <sam@webkit.org>
3497
3498         Rubber stamped by Adam.
3499
3500         Remove empty directories.
3501
3502         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
3503         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
3504
3505 2007-10-03  Darin Adler  <darin@apple.com>
3506
3507         Reviewed by Adam.
3508
3509         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
3510         we find the internal libraries in the libraries directory. This
3511         is helpful for Safari team engineers at Apple.
3512
3513 2007-10-03  Adam Roben  <aroben@apple.com>
3514
3515         Update the location of AHEM___.TTF after r25968
3516
3517         Reviewed by Sam.
3518
3519         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3520
3521 2007-10-03  Alp Toker  <alp@atoker.com>
3522
3523         Reviewed by Adam.
3524
3525         http://bugs.webkit.org/show_bug.cgi?id=14726
3526         [gtk] API design. Mapping the WebView delegates to signals.
3527
3528         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
3529
3530         * GtkLauncher/main.cpp:
3531         (goToURLBarText):
3532         (titleChanged):
3533         (progressChanged):
3534         (menuMainBackCallback):
3535         (menuMainForwardCallback):
3536         (main):
3537
3538 2007-10-03  Lars Knoll  <lars@trolltech.com>
3539
3540         Reviewed by Rob.
3541
3542         This fixes --strict mode in run-webkit-tests again after
3543         the platform dependent test results have been moved.
3544
3545         * Scripts/run-webkit-tests:
3546
3547 2007-10-03  Lars Knoll  <lars@trolltech.com>
3548
3549         Reviewed by bdash.
3550
3551         remove the hack in run-webkit-tests that forced text only test
3552         to be taken from the platform independent dir. It was only left
3553         there from early days.
3554
3555         Remove platform dependent results for tests that are text only nowadays,
3556         and add one platform dependent result for a text only test that requires it.
3557
3558         * Scripts/run-webkit-tests:
3559
3560 2007-10-03  Lars Knoll  <lars@trolltech.com>
3561
3562         Reviewed by olliej.
3563
3564         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
3565
3566         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
3567         (WebCore::WebFrame::WebFrame):
3568         (WebCore::WebPage::WebPage):
3569         (WebCore::WebPage::createFrame):
3570         (WebCore::WebPage::javaScriptAlert):
3571         (WebCore::WebPage::javaScriptConsoleMessage):
3572         (WebCore::DumpRenderTree::DumpRenderTree):
3573         (WebCore::DumpRenderTree::~DumpRenderTree):
3574         (WebCore::DumpRenderTree::open):
3575         (WebCore::DumpRenderTree::readStdin):
3576         (WebCore::DumpRenderTree::resetJSObjects):
3577         (WebCore::DumpRenderTree::initJSObjects):
3578         (WebCore::DumpRenderTree::dumpFramesAsText):
3579         (WebCore::DumpRenderTree::dump):
3580         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
3581         (WebCore::DumpRenderTree::layoutTestController):
3582         (WebCore::DumpRenderTree::eventSender):
3583         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
3584         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
3585         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
3586         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
3587         (HackWebFrame::mousePressEvent):
3588         (HackWebFrame::mouseReleaseEvent):
3589         (HackWebFrame::mouseMoveEvent):
3590         (HackWebFrame::HackWebFrame):
3591         (HackWebFrame::~HackWebFrame):
3592         (LayoutTestController::LayoutTestController):
3593         (LayoutTestController::reset):
3594         (LayoutTestController::maybeDump):
3595         (LayoutTestController::waitUntilDone):
3596         (LayoutTestController::notifyDone):
3597         (LayoutTestController::dumpEditingCallbacks):
3598         (LayoutTestController::queueReload):
3599         (LayoutTestController::provisionalLoad):
3600         (LayoutTestController::timerEvent):
3601         (EventSender::EventSender):
3602         (EventSender::mouseDown):
3603         (EventSender::mouseUp):
3604         (EventSender::mouseMoveTo):
3605         (EventSender::leapForward):
3606         (EventSender::keyDown):
3607         (EventSender::frameUnderMouse):
3608         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
3609         (LayoutTestController::isLoading):
3610         (LayoutTestController::setLoading):
3611         (LayoutTestController::shouldDumpAsText):