2009-11-28 Adam Barth <abarth@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-28  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         [bzt] style-queue should report style errors to bugzilla
6         https://bugs.webkit.org/show_bug.cgi?id=31945
7
8         Currently, we're just logging the style errors locally.  With this
9         patch we'll actually log the errors to bugzilla.  Note: I plan to run
10         with the "local-only" logging during development.
11
12         * Scripts/modules/commands/queues.py:
13         * Scripts/modules/scm.py:
14
15 2009-11-28  Adam Barth  <abarth@webkit.org>
16
17         Reviewed by Eric Seidel.
18
19         [bzt] style-queue shouldn't reject patches from the commit-queue
20         https://bugs.webkit.org/show_bug.cgi?id=31944
21
22         Currently the style-queue subprocess gets confused and thinks its the
23         commit-queue.  If the patch has an error, it rejects it from the
24         commit-queue.  Instead, we should have style-queue specific logic.
25         This patch doesn't add that logic, but it gives us a callback we can
26         use to add that logic.
27
28         * Scripts/modules/buildsteps.py:
29         * Scripts/modules/commands/queues.py:
30         * Scripts/modules/landingsequence.py:
31
32 2009-11-27  Adam Barth  <abarth@webkit.org>
33
34         Rubber stamped by Eric Seidel.
35
36         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
37
38         * CommitQueueStatus: Removed.
39         * CommitQueueStatus/app.yaml: Removed.
40         * CommitQueueStatus/filters: Removed.
41         * CommitQueueStatus/filters/__init__.py: Removed.
42         * CommitQueueStatus/filters/webkit_extras.py: Removed.
43         * CommitQueueStatus/index.html: Removed.
44         * CommitQueueStatus/index.yaml: Removed.
45         * CommitQueueStatus/queue_status.py: Removed.
46         * CommitQueueStatus/stylesheets: Removed.
47         * CommitQueueStatus/stylesheets/main.css: Removed.
48         * CommitQueueStatus/update_status.html: Removed.
49         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
50
51 2009-11-27  Adam Barth  <abarth@webkit.org>
52
53         Reviewed by Eric Seidel.
54
55         style-queue should only process each patch once
56         https://bugs.webkit.org/show_bug.cgi?id=31939
57
58         Actually address reviewer comments!
59
60         * Scripts/bugzilla-tool:
61
62 2009-11-27  Adam Barth  <abarth@webkit.org>
63
64         Reviewed by Eric Seidel.
65
66         [bzt] style-queue fails to apply a bunch of patches for no reason
67         https://bugs.webkit.org/show_bug.cgi?id=31942
68
69         By passing --non-interactive to check-style, we convince check-style
70         to pass --force to svn-apply, which lets it apply more patches.
71
72         * Scripts/modules/commands/queues.py:
73
74 2009-11-27  Adam Barth  <abarth@webkit.org>
75
76         Reviewed by Eric Seidel.
77
78         [bzt] Support --status-host in style-queue
79         https://bugs.webkit.org/show_bug.cgi?id=31941
80
81         * Scripts/modules/commands/queues.py:
82         * Scripts/modules/statusbot.py:
83
84 2009-11-27  Adam Barth  <abarth@webkit.org>
85
86         Reviewed by Eric Seidel.
87
88         style-queue should only process each patch once
89         https://bugs.webkit.org/show_bug.cgi?id=31939
90
91         Before processing a patch, the try-queues now ask the web service
92         whether they have already processed the patch.  This is an initial cut
93         of this functionality.  I expect we're make it richer over time.
94
95         * Scripts/bugzilla-tool:
96         * Scripts/modules/commands/queues.py:
97         * Scripts/modules/patchcollection.py:
98
99 2009-11-27  Adam Barth  <abarth@webkit.org>
100
101         Reviewed by Eric Seidel.
102
103         PatchStatus does not return status
104         https://bugs.webkit.org/show_bug.cgi?id=31938
105
106         We need to parse attachment_id as an int.  Otherwise, we can't find
107         anything in the datastore.
108
109         * CommitQueueStatus/queue_status.py:
110
111 2009-11-27  Adam Barth  <abarth@webkit.org>
112
113         Reviewed by Eric Seidel.
114
115         Make commit-queue status not throw an exception where there is not
116         status
117         https://bugs.webkit.org/show_bug.cgi?id=31936
118
119         We need to actually fetch the results of the query to see what's in the
120         datastore.
121
122         * CommitQueueStatus/queue_status.py:
123
124 2009-11-27  Adam Barth  <abarth@webkit.org>
125
126         Reviewed by Eric Seidel.
127
128         [bzt] unit test ApplyPatches and ApplyAttachment
129         https://bugs.webkit.org/show_bug.cgi?id=31935
130
131         * Scripts/modules/commands/download.py:
132         * Scripts/modules/commands/download_unittest.py:
133
134 2009-11-27  Adam Barth  <abarth@webkit.org>
135
136         Reviewed by Eric Seidel.
137
138         [bzt] Unit test download commands
139         https://bugs.webkit.org/show_bug.cgi?id=31923
140
141         Adds download_unittest and fixes a bug found while testing.
142
143         * Scripts/modules/commands/commandtest.py:
144         * Scripts/modules/commands/download.py:
145             Fixed a bug where we'd throw an error because [].append returns
146             None.
147         * Scripts/modules/commands/download_unittest.py: Added.
148         * Scripts/modules/mock_bugzillatool.py:
149         * Scripts/run-webkit-unittests:
150
151 2009-11-27  Adam Barth  <abarth@webkit.org>
152
153         Unreviewed "build" fix found while writing unit tests.
154
155         * Scripts/modules/commands/download.py:
156
157 2009-11-27  Adam Barth  <abarth@webkit.org>
158
159         Reviewed by Eric Seidel.
160
161         [bzt] Kill WebKitLandingScripts
162         https://bugs.webkit.org/show_bug.cgi?id=31904
163
164         Step 6: Kill the rest.
165
166         * Scripts/modules/buildsteps.py:
167         * Scripts/modules/commands/download.py:
168         * Scripts/modules/commands/queries.py:
169         * Scripts/modules/commands/upload.py:
170         * Scripts/modules/landingsequence.py:
171         * Scripts/modules/scm.py:
172         * Scripts/modules/webkitlandingscripts.py: Removed.
173
174 2009-11-27  Adam Barth  <abarth@webkit.org>
175
176         Reviewed by Eric Seidel.
177
178         [bzt] Unit test upload commands
179         https://bugs.webkit.org/show_bug.cgi?id=31903
180
181         Adds unit tests for all but two of the upload commands.  The two
182         remaining ones are more difficult.  I'll return to them later.  The
183         goal of these tests is just to run the commands.  We can test more
184         detailed behavior later.
185
186         * Scripts/modules/commands/commandtest.py:
187         * Scripts/modules/commands/upload.py:
188         * Scripts/modules/commands/upload_unittest.py:
189         * Scripts/modules/mock.py: Added.
190         * Scripts/modules/mock_bugzillatool.py:
191
192 2009-11-26  Adam Barth  <abarth@webkit.org>
193
194         Reviewed by Eric Seidel.
195
196         [bzt] Kill WebKitLandingScripts
197         https://bugs.webkit.org/show_bug.cgi?id=31904
198
199         Step 5: Kill run_and_throw_if_fail.
200
201         * Scripts/modules/buildsteps.py:
202         * Scripts/modules/processutils.py: Added.
203         * Scripts/modules/webkitlandingscripts.py:
204
205 2009-11-26  Adam Barth  <abarth@webkit.org>
206
207         Reviewed by Eric Seidel.
208
209         [bzt] Kill WebKitLandingScripts
210         https://bugs.webkit.org/show_bug.cgi?id=31904
211
212         Step 4: Kill run_webkit_script.
213
214         * Scripts/modules/buildsteps.py:
215         * Scripts/modules/commands/download.py:
216         * Scripts/modules/webkitlandingscripts.py:
217
218 2009-11-26  Adam Barth  <abarth@webkit.org>
219
220         Reviewed by Eric Seidel.
221
222         [bzt] Kill WebKitLandingScripts
223         https://bugs.webkit.org/show_bug.cgi?id=31904
224
225         Step 3: Kill build_webkit.
226
227         * Scripts/modules/buildsteps.py:
228         * Scripts/modules/landingsequence.py:
229         * Scripts/modules/webkitlandingscripts.py:
230
231 2009-11-26  Adam Barth  <abarth@webkit.org>
232
233         Reviewed by Eric Seidel.
234
235         [bzt] Kill WebKitLandingScripts
236         https://bugs.webkit.org/show_bug.cgi?id=31904
237
238         Step 2: Kill ensure_builders_are_green.
239
240         * Scripts/modules/buildsteps.py:
241         * Scripts/modules/commands/download.py:
242         * Scripts/modules/landingsequence.py:
243         * Scripts/modules/webkitlandingscripts.py:
244
245 2009-11-26  Adam Barth  <abarth@webkit.org>
246
247         Reviewed by Eric Seidel.
248
249         [bzt] Kill WebKitLandingScripts
250         https://bugs.webkit.org/show_bug.cgi?id=31904
251
252         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
253
254         * Scripts/bugzilla-tool:
255         * Scripts/modules/buildsteps.py: Added.
256         * Scripts/modules/commands/download.py:
257         * Scripts/modules/landingsequence.py:
258         * Scripts/modules/webkitlandingscripts.py:
259
260 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
261
262         Reviewed by Adam Barth.
263
264         Remove directory prefixes from linux commands
265
266         SCM unittests can cause errors on some systems if we use absolute reference to
267         the commands, so directory prefixes have been removed.
268
269         * Scripts/modules/scm_unittest.py:
270
271 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
272
273         Reviewed by Kenneth Rohde Christiansen.
274
275         Link DumpRenderTree to the Qt Ui Tools
276         https://bugs.webkit.org/show_bug.cgi?id=31203
277
278         Implement QWebPage::createPlugin using the Qt Ui Tools
279         to be able to create classes like QProgressBar from within
280         the <object></object> tags This is required for the
281         new automatic test of Qt Plugins.
282
283         * DumpRenderTree/qt/DumpRenderTree.cpp:
284         (WebCore::WebPage::createPlugin):
285         * DumpRenderTree/qt/DumpRenderTree.h:
286         * DumpRenderTree/qt/DumpRenderTree.pro:
287
288 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
289
290         Reviewed by Eric Seidel.
291
292         Update pywebsocket to 0.4.2
293
294         Update pywebsocket to 0.4.2
295         https://bugs.webkit.org/show_bug.cgi?id=31861
296
297         * pywebsocket/example/echo_client.py:
298         * pywebsocket/example/echo_wsh.py:
299         * pywebsocket/mod_pywebsocket/__init__.py:
300         * pywebsocket/mod_pywebsocket/dispatch.py:
301         * pywebsocket/mod_pywebsocket/msgutil.py:
302         * pywebsocket/mod_pywebsocket/standalone.py:
303         * pywebsocket/setup.py:
304         * pywebsocket/test/test_dispatch.py:
305         * pywebsocket/test/test_msgutil.py:
306
307 2009-11-25  Adam Barth  <abarth@webkit.org>
308
309         Reviewed by Eric Seidel.
310
311         Add unit test for mark-fixed
312         https://bugs.webkit.org/show_bug.cgi?id=31896
313
314         * Scripts/modules/commands/commandtest.py: Added.
315         * Scripts/modules/commands/queries_unittest.py:
316         * Scripts/modules/commands/upload_unittest.py: Added.
317         * Scripts/modules/mock_bugzillatool.py:
318         * Scripts/run-webkit-unittests:
319
320 2009-11-25  Adam Barth  <abarth@webkit.org>
321
322         Reviewed by Eric Seidel.
323
324         bugzilla-tool should have a mark-fixed command
325         https://bugs.webkit.org/show_bug.cgi?id=31853
326
327         Pretty simple stuff.
328
329         * Scripts/modules/commands/upload.py:
330
331 2009-11-25  Eric Seidel  <eric@webkit.org>
332
333         Reviewed by Adam Barth.
334
335         'bugzilla-tool help' should only show common commands like how 'git help' does
336         https://bugs.webkit.org/show_bug.cgi?id=31772
337
338         I also took this opportunity to make 'help' a real Command.
339         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
340
341         * Scripts/bugzilla-tool:
342          - change should_show_command_help to should_show_in_main_help
343         * Scripts/modules/commands/download.py:
344          - Mark commands as being shown in main help or not.
345          - show_in_main_help = False is not required (default is false),
346            but it seemed to make the commands more self-documenting.
347         * Scripts/modules/commands/queries.py: ditto
348         * Scripts/modules/commands/queues.py: ditto
349         * Scripts/modules/commands/upload.py: ditto
350         * Scripts/modules/multicommandtool.py:
351          - Make Command hold a pointer to tool in self.tool.  Most Command
352            subclasses do not take advantage of this yet, but it was required
353            for HelpCommand to be able to reach the tool from _help_epilog().
354          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
355          - Move MultiCommandTool._help_epilog to Command._help_epilog
356          - Move "help" logic into HelpCommand.execute()
357          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
358         * Scripts/modules/multicommandtool_unittest.py:
359          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
360
361 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
362
363         Reviewed by Dan Bernstein.
364         
365         Patch by Mark Rowe.
366
367         The buildbots are failing on Windows because when they were upgraded
368         to 4.0.4, Apple Application Support was not in their path. Add it to
369         the path to fix the buildots.
370
371         * Scripts/webkitdirs.pm:
372
373 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
374
375         Reviewed by David Kilzer.
376
377         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
378         https://bugs.webkit.org/show_bug.cgi?id=31799
379
380         * Scripts/run-webkit-tests: Fixed.
381
382 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
383
384         Reviewed by Eric Seidel.
385
386         Change run_command to give back stderr by default
387         https://bugs.webkit.org/show_bug.cgi?id=31734
388
389         Change run_command to give back stderr by default.
390         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
391         Change the related unittest call.
392
393         * Scripts/modules/scm.py:
394         * Scripts/modules/scm_unittest.py:
395
396 2009-11-25  Eric Seidel  <eric@webkit.org>
397
398         Reviewed by Adam Barth.
399
400         Centralize required argument parsing in Command
401         https://bugs.webkit.org/show_bug.cgi?id=31872
402
403         * Scripts/modules/commands/download.py: remove custom required arg message.
404         * Scripts/modules/commands/upload.py: ditto.
405         * Scripts/modules/multicommandtool.py:
406          - Add _parse_required_arguments.
407          - Pass program name off to OptionParser.
408          - Add name() for access to tool name.
409          - Add check_arguments_and_execute and make it return a return code.
410          - Replace a couple uses of + with %.
411         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
412
413 2009-11-25  Eric Seidel  <eric@webkit.org>
414
415         Reviewed by Adam Barth.
416
417         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
418         https://bugs.webkit.org/show_bug.cgi?id=31870
419
420         * Scripts/modules/commands/queries_unittest.py: Use the new class.
421         * Scripts/modules/multicommandtool_unittest.py: Ditto.
422         * Scripts/modules/outputcapture.py: Added.
423
424 2009-11-24  Dmitry Titov  <dimich@chromium.org>
425
426         Reviewed by Eric Seidel.
427
428         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
429         https://bugs.webkit.org/show_bug.cgi?id=31444
430
431         * Scripts/build-webkit:
432
433 2009-11-24  Chris Marrin  <cmarrin@apple.com>
434
435         Reviewed by Simon Fraser.
436
437         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
438         https://bugs.webkit.org/show_bug.cgi?id=27314
439         
440         Now the script allows the directories with these tests to be included on all
441         platforms but Mac, where they behave the same as always. For all other platforms
442         the tests need to be excluded using the Skipped files, which is currently done
443         for all platforms (including win since we're not turned on yet)
444
445         * Scripts/webkitdirs.pm:
446
447 2009-11-24  Eric Seidel  <eric@webkit.org>
448
449         Reviewed by Adam Barth.
450
451         queries_unittest.py should test command output
452         https://bugs.webkit.org/show_bug.cgi?id=31845
453
454         * Scripts/modules/commands/queries_unittest.py:
455          - Capture stdout and stderr and compare with expected strings.
456
457 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
458
459         No Review.
460
461         Fix spelling error ("depenedencies").
462
463         * Scripts/build-webkit:
464
465 2009-11-24  Mark Rowe  <mrowe@apple.com>
466
467         Land the configuration that includes the two debug GTK Linux builders.
468
469         * BuildSlaveSupport/build.webkit.org-config/config.json:
470
471 2009-11-24  David Kilzer  <ddkilzer@apple.com>
472
473         <http://webkit.org/b/31840> bisect-builds broke after r50080
474
475         Reviewed by Dan Bernstein.
476
477         * Scripts/bisect-builds:
478         (mountAndRunNightly): Switched back to using backticks to run
479         the hdiutil command since exec() will terminate the existing
480         script, which is not what we want.  Store the output of
481         File::Spec->devnull() in a variable for use in the hdiutil
482         detach commands.
483
484 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
485
486         Reviewed by Kenneth Rohde Christiansen.
487
488         Include "config.h" to meet Coding Style Guidelines
489         https://bugs.webkit.org/show_bug.cgi?id=31792
490
491         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
492         * DumpRenderTree/qt/jsobjects.cpp:
493         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
494
495 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
496
497         Reviewed by Oliver Hunt.
498
499         Implement new required function to pass test we used to pass. This
500         change is required since r51294.
501
502         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
503         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
504
505 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
506
507         Reviewed by Kenneth Rohde Christiansen.
508
509         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
510         https://bugs.webkit.org/show_bug.cgi?id=31775
511
512         LayoutTestController::dumpBackForwardList() should work with local URLs
513         as well as with normal URLs (in http tests for instance).
514         Currently it does not output the latter properly.
515
516         Unskip a bunch of passing http/navigation tests.
517
518         * DumpRenderTree/qt/DumpRenderTree.cpp:
519         (WebCore::dumpHistoryItem):
520
521 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
522
523         Reviewed by Oliver Hunt.
524
525         ARIA: support aria-flowto
526         https://bugs.webkit.org/show_bug.cgi?id=31762
527
528         * DumpRenderTree/AccessibilityUIElement.cpp:
529         (ariaFlowToElementAtIndexCallback):
530         (AccessibilityUIElement::getJSClass):
531         * DumpRenderTree/AccessibilityUIElement.h:
532         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
533         (AccessibilityUIElement::ariaFlowToElementAtIndex):
534         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
535         (AccessibilityUIElement::ariaFlowToElementAtIndex):
536         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
537         (AccessibilityUIElement::ariaFlowToElementAtIndex):
538
539 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
540
541         Reviewed by Kenneth Christiansen.
542
543         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
544         https://bugs.webkit.org/show_bug.cgi?id=31638
545
546         Unfreeze WorkQueue after each test execution.
547
548         * DumpRenderTree/qt/DumpRenderTree.cpp:
549         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
550
551 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
552
553         Reviewed by Adam Barth.
554
555         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
556         for localhost and 127.0.0.1.
557         https://bugs.webkit.org/show_bug.cgi?id=31783
558
559         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
560
561         * DumpRenderTree/qt/DumpRenderTree.cpp:
562         (WebCore::NetworkAccessManager::NetworkAccessManager):
563         (WebCore::NetworkAccessManager::sslErrorsEncountered):
564         (WebCore::WebPage::WebPage):
565         * DumpRenderTree/qt/DumpRenderTree.h:
566
567 2009-11-22  Chris Evans  <cevans@chromium.org>
568
569         Reviewed by Adam Barth.
570
571         Disable access to file:/// directory listings
572         https://bugs.webkit.org/show_bug.cgi?id=31329
573
574         Implemented setAllowUniversalAccessFromFileURLs to support testing of
575         file URL security.
576
577         * DumpRenderTree/LayoutTestController.cpp:
578         (setAllowUniversalAccessFromFileURLsCallback):
579         (LayoutTestController::staticFunctions):
580         * DumpRenderTree/LayoutTestController.h:
581         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
582         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
583         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
584         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
585         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
586         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
587         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
588         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
589
590 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
591
592         Reviewed by Kenneth Rohde Christiansen.
593
594         [Qt] Fix the timeout of fast/frames/frame-navigation.html
595         https://bugs.webkit.org/show_bug.cgi?id=31638
596
597         The test is timeouting, because it uses the WorkQueue to load a document in one
598         of the child frames and once the loading is finished, the DRT does not dump the
599         tree. This is because it waits for the QWebFrame::loadFinished() signal from
600         the main frame, while it should connect to QWebPage::loadFinished().
601
602         * DumpRenderTree/qt/DumpRenderTree.cpp:
603         (WebCore::DumpRenderTree::DumpRenderTree):
604
605 2009-11-21  Eric Seidel  <eric@webkit.org>
606
607         Reviewed by Adam Barth.
608
609         bugzilla-tool --help spews way too much text
610         https://bugs.webkit.org/show_bug.cgi?id=31771
611
612         * Scripts/bugzilla-tool:
613          - Remove self.cached_scm initialization hack.
614         * Scripts/modules/buildbot.py:
615          - Make default_host accessible to callers.
616         * Scripts/modules/commands/download.py:
617          - Phrase help for all commands consistently and remove spurious help text punctuation.
618         * Scripts/modules/commands/queries.py: Ditto.
619         * Scripts/modules/commands/queues.py: Ditto.
620         * Scripts/modules/commands/upload.py: Ditto.
621         * Scripts/modules/multicommandtool.py:
622          - Add HelpPrintingOptionParser.format_epilog to replace
623            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
624            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
625          - Make --help only show a list of commands like "svn help" and "git help" do --
626            previously --help was listing all commands and options.
627          - Sort list of commands alphabetically.
628
629 2009-11-21  Eric Seidel  <eric@webkit.org>
630
631         No review.  Fixing a typo from the previous patch for bug 31767.
632
633         AbstractQueue.run_bugzilla_tool throws an exception
634         https://bugs.webkit.org/show_bug.cgi?id=31769
635
636         * Scripts/modules/commands/queues.py:
637
638 2009-11-21  Eric Seidel  <eric@webkit.org>
639
640         Reviewed by Adam Barth.
641
642         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
643         https://bugs.webkit.org/show_bug.cgi?id=31767
644
645         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
646         Since we don't have a good way to test BugzillaTool pieces, I've
647         left out a test for now.
648
649         * Scripts/bugzilla-tool:
650          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
651         * Scripts/modules/commands/queues.py:
652          - Use tool.path() instead of __file__.
653         * Scripts/modules/multicommandtool.py:
654          - Add a new path() method to MultiComandTool.
655         * Scripts/modules/multicommandtool_unittest.py:
656          - Provide a path() method.  Little point in testing this mock implementation.
657
658 2009-11-21  Adam Barth  <abarth@webkit.org>
659
660         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
661         WebKitTools.
662
663         * Scripts/modules/commands/download.py:
664
665 2009-11-21  Adam Barth  <abarth@webkit.org>
666
667         Reviewed by Eric Seidel.
668
669         Convert check-style to use LandingSequence
670         https://bugs.webkit.org/show_bug.cgi?id=31763
671
672         Instead of manipulating the working copy by hand, we should use the
673         LandingSequence in CheckStyle.  This will make this code eaiser to
674         test.
675
676         * Scripts/modules/commands/download.py:
677
678 2009-11-20  Adam Barth  <abarth@webkit.org>
679
680         Reviewed by Eric Seidel.
681
682         Unit test query commands
683         https://bugs.webkit.org/show_bug.cgi?id=31755
684
685         These tests are pretty rough, but hopefully they'll grow.
686
687         * Scripts/modules/commands/queries_unittest.py: Added.
688         * Scripts/modules/mock_bugzillatool.py: Added.
689         * Scripts/run-webkit-unittests:
690
691 2009-11-20  Eric Seidel  <eric@webkit.org>
692
693         Reviewed by Adam Barth.
694
695         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
696         https://bugs.webkit.org/show_bug.cgi?id=31758
697
698         * Scripts/modules/multicommandtool.py:
699          - Allow passing of explicit commands to MultiCommandTool.__init__
700         * Scripts/modules/multicommandtool_unittest.py:
701          - Use new Command.name naming system.
702          - Test Command auto-discovery.
703         * Scripts/modules/workqueue.py:
704          - bug_id no longer exists, use patch['bug_id'] instead.
705         * Scripts/modules/workqueue_unittest.py:
706          - WorkQueues require names now.
707          - should_proceed_with_work_item must return a patch object.
708
709 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
710
711         Reviewed by Beth Dakin.
712
713         WAI-ARIA: add support for aria-owns
714         https://bugs.webkit.org/show_bug.cgi?id=31702
715
716         * DumpRenderTree/AccessibilityUIElement.cpp:
717         (ariaOwnsElementAtIndexCallback):
718         (AccessibilityUIElement::getJSClass):
719         * DumpRenderTree/AccessibilityUIElement.h:
720         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
721         (AccessibilityUIElement::ariaOwnsElementAtIndex):
722         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
723         (AccessibilityUIElement::ariaOwnsElementAtIndex):
724         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
725         (AccessibilityUIElement::ariaOwnsElementAtIndex):
726
727 2009-11-20  Eric Seidel  <eric@webkit.org>
728
729         Reviewed by Adam Barth.
730
731         Fix exception thrown when running the commit-queue.
732
733         * Scripts/modules/statusbot.py: patch is optional.
734         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
735
736 2009-11-20  Eric Seidel  <eric@webkit.org>
737
738         Reviewed by Adam Barth.
739
740         Teach the StatusBot how to support more than just the commit-queue
741         https://bugs.webkit.org/show_bug.cgi?id=31754
742
743         * Scripts/modules/workqueue.py: Another typo.
744
745 2009-11-20  Eric Seidel  <eric@webkit.org>
746
747         Reviewed by Adam Barth.
748
749         Teach the StatusBot how to support more than just the commit-queue
750         https://bugs.webkit.org/show_bug.cgi?id=31754
751
752         * Scripts/modules/commands/queues.py: Fix silly typo.
753
754 2009-11-20  Eric Seidel  <eric@webkit.org>
755
756         Reviewed by Adam Barth.
757
758         Teach the StatusBot how to support more than just the commit-queue
759         https://bugs.webkit.org/show_bug.cgi?id=31754
760
761         * CommitQueueStatus/index.yaml:
762          - Add indices required for the new queries.
763         * CommitQueueStatus/queue_status.py:
764          - Add a patch-status page and move update_status to update-status.
765          - Only display "commit-queue" status records for the commit-queue.
766          - Add support for a queue_name property on status records.
767          - Fix _int_from_request to actually work.
768         * CommitQueueStatus/update_status.html:
769          - Add support for a queue_name on status records.
770          - Remove unused list of bug ids.
771          * Scripts/modules/commands/queues.py
772           - Make the queues pass the patch instead of the bug_id to StatusBot.
773         * Scripts/modules/statusbot.py:
774          - Support passing the queue_name to the status updates.
775          - Support fetching patch status with patch_status().
776         * Scripts/modules/workqueue.py:
777          - Pass the patch to the StatusBot instead of the bug_id.
778          - Let WorkQueues have a name.
779
780 2009-11-20  Adam Barth  <abarth@webkit.org>
781
782         Reviewed by Eric Seidel.
783
784         Move bugzilla-tool commands into their own file
785         https://bugs.webkit.org/show_bug.cgi?id=31752
786
787         This will let us write unit tests.
788
789         * Scripts/bugzilla-tool:
790         * Scripts/modules/commands/__init__.py: Added.
791         * Scripts/modules/commands/download.py: Added.
792         * Scripts/modules/commands/queries.py: Added.
793         * Scripts/modules/commands/queues.py: Added.
794         * Scripts/modules/commands/upload.py: Added.
795         * Scripts/modules/grammar.py: Added.
796
797 2009-11-20  Adam Barth  <abarth@webkit.org>
798
799         Reviewed by Eric Seidel.
800
801         BuildQueue should check if the tree is currently buildable
802         https://bugs.webkit.org/show_bug.cgi?id=31744
803
804         * Scripts/bugzilla-tool:
805         * Scripts/modules/landingsequence.py:
806         * Scripts/modules/webkitlandingscripts.py:
807
808 2009-11-20  Adam Barth  <abarth@webkit.org>
809
810         Reviewed by Eric Seidel.
811
812         Move prepare_clean_working_directory into the LandingSequence
813         https://bugs.webkit.org/show_bug.cgi?id=31743
814
815         * Scripts/bugzilla-tool:
816         * Scripts/modules/landingsequence.py:
817
818 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
819
820         Reviewed by Kenneth Rohde Christiansen.
821
822         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
823         https://bugs.webkit.org/show_bug.cgi?id=30460
824
825         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
826
827         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
828         (pluginInvoke):
829
830 2009-11-20  Adam Barth  <abarth@webkit.org>
831
832         Reviewed by Eric Seidel.
833
834         Pass the port information to the child process
835         https://bugs.webkit.org/show_bug.cgi?id=31736
836
837         We need to do this so the child process knows what to build!
838
839         * Scripts/bugzilla-tool:
840         * Scripts/modules/landingsequence.py:
841         * Scripts/modules/webkitport.py:
842         * Scripts/modules/webkitport_unittest.py:
843
844 2009-11-20  Adam Barth  <abarth@webkit.org>
845
846         Reviewed by Eric Seidel.
847
848         Support Qt port in build-queue
849         https://bugs.webkit.org/show_bug.cgi?id=31733
850
851         * Scripts/bugzilla-tool:
852
853 2009-11-20  Adam Barth  <abarth@webkit.org>
854
855         Reviewed by Eric Seidel.
856
857         Implement a build-queue
858         https://bugs.webkit.org/show_bug.cgi?id=31725
859
860         Currently this just builds the first 10 patches in the review queue.
861         We'll want to do something smarter soon.
862
863         * Scripts/bugzilla-tool:
864
865 2009-11-20  Adam Barth  <abarth@webkit.org>
866
867         Reviewed by Eric Seidel.
868
869         Make commit-queue and style-queue show up in help
870         https://bugs.webkit.org/show_bug.cgi?id=31724
871
872         We need to store their names on their class to make these commands
873         properly register themselves with MultiCommandTool.
874
875         * Scripts/bugzilla-tool:
876
877 2009-11-20  Adam Barth  <abarth@webkit.org>
878
879         Reviewed by Eric Seidel.
880
881         Implement bugzilla-tool build-attachment
882         https://bugs.webkit.org/show_bug.cgi?id=31722
883
884         This command builds an attachment from bugzilla.  It leaves the built
885         patch in the working copy.
886
887         * Scripts/bugzilla-tool:
888         * Scripts/modules/landingsequence.py:
889         * Scripts/modules/webkitlandingscripts.py:
890
891 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
892
893         Reviewed by Xan Lopez.
894
895         [GTK] DRT release event does not create the state correctly
896         https://bugs.webkit.org/show_bug.cgi?id=31717
897
898         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
899
900 2009-11-20  Eric Seidel  <eric@webkit.org>
901
902         Reviewed by Adam Barth.
903
904         MultiCommandTool should find Command objects automatically instead of with a manual list
905         https://bugs.webkit.org/show_bug.cgi?id=31710
906
907         * Scripts/bugzilla-tool:
908         * Scripts/modules/multicommandtool.py:
909          - Use some wild python-fu to crawl all the known subclasses of Command.
910
911 2009-11-20  Adam Barth  <abarth@webkit.org>
912
913         Unreviewed "build" fix.  Added missing import.
914
915         * Scripts/bugzilla-tool:
916
917 2009-11-20  Adam Barth  <abarth@webkit.org>
918
919         Unreviewed "build" fix.  I failed to update LandingSequence.test
920         properly.
921
922         * Scripts/modules/landingsequence.py:
923
924 2009-11-20  Adam Barth  <abarth@webkit.org>
925
926         Reviewed by Eric Seidel.
927
928         Create LandingSequence as the all-sing, all-dance landing class
929         https://bugs.webkit.org/show_bug.cgi?id=31709
930
931         Client can inherit from this class to carefully control exactly which
932         steps they wish to have happen in the landing sequence.
933
934         * Scripts/bugzilla-tool:
935         * Scripts/modules/landingsequence.py: Added.
936         * Scripts/modules/webkitlandingscripts.py: Added.
937
938 2009-11-19  Adam Barth  <abarth@webkit.org>
939
940         Reviewed by Eric Seidel.
941
942         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
943         https://bugs.webkit.org/show_bug.cgi?id=31707
944
945         This is to help when we implement build-attachment.
946
947         * Scripts/bugzilla-tool:
948
949 2009-11-19  Adam Barth  <abarth@webkit.org>
950
951         Reviewed by Eric Seidel.
952
953         Support Qt port in bugzilla-tool
954         https://bugs.webkit.org/show_bug.cgi?id=31701
955
956         Now we support building with Qt!
957
958         * Scripts/bugzilla-tool:
959         * Scripts/modules/webkitport.py: Added.
960         * Scripts/modules/webkitport_unittest.py: Added.
961         * Scripts/run-webkit-unittests:
962
963 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
964
965         Reviewed by Adam Barth.
966
967         Remove inserting stderr into patch in bugzilla-tool
968         https://bugs.webkit.org/show_bug.cgi?id=29914
969
970         Modify SCM python module's run_command function to avoid return of stderr
971         by default, so stderr won't be inserted into the patches.
972         Modify the related unit test.
973
974         * Scripts/modules/scm.py:
975         * Scripts/modules/scm_unittest.py:
976
977 2009-11-19  Eric Seidel  <eric@webkit.org>
978
979         Reviewed by Adam Barth.
980
981         bugzilla-tool needs per-command help
982         https://bugs.webkit.org/show_bug.cgi?id=31697
983
984         Added support for "bugzilla-tool help command-name"
985         and a unit test to make sure it works.
986
987         * Scripts/modules/multicommandtool.py:
988         * Scripts/modules/multicommandtool_unittest.py:
989
990 2009-11-19  Eric Seidel  <eric@webkit.org>
991
992         Reviewed by Adam Barth.
993
994         Move MultiCommandTool and Command into a separate file and add some basic unit tests
995         https://bugs.webkit.org/show_bug.cgi?id=31695
996
997         * Scripts/bugzilla-tool:
998         * Scripts/modules/multicommandtool.py: Added.
999         * Scripts/modules/multicommandtool_unittest.py: Added.
1000         * Scripts/run-webkit-unittests:
1001
1002 2009-11-19  Eric Seidel  <eric@webkit.org>
1003
1004         No review, just adding a FIXME.
1005
1006         Split out command parsing and help printing from BugzillaTool
1007         https://bugs.webkit.org/show_bug.cgi?id=31688
1008
1009         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
1010
1011 2009-11-19  Eric Seidel  <eric@webkit.org>
1012
1013         Reviewed by Adam Barth.
1014
1015         Split out command parsing and help printing from BugzillaTool
1016         https://bugs.webkit.org/show_bug.cgi?id=31688
1017
1018         * Scripts/bugzilla-tool:
1019          - Add new MultiCommandTool class to contain option parsing and help printing logic.
1020          - Rename private methods to use _ pattern.
1021          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
1022          - 
1023
1024 2009-11-19  Eric Seidel  <eric@webkit.org>
1025
1026         Reviewed by Adam Barth.
1027
1028         Re-factor help printing to use modern python idioms
1029         https://bugs.webkit.org/show_bug.cgi?id=31685
1030
1031         * Scripts/bugzilla-tool:
1032
1033 2009-11-19  Eric Seidel  <eric@webkit.org>
1034
1035         Reviewed by Darin Adler.
1036
1037         commit-queue empty queue logs twice
1038         https://bugs.webkit.org/show_bug.cgi?id=31679
1039
1040         * Scripts/bugzilla-tool:
1041
1042 2009-11-19  Eric Seidel  <eric@webkit.org>
1043
1044         Reviewed by Darin Adler.
1045
1046         bugzilla-tool's reviewer/committer rejection message should be clearer
1047         https://bugs.webkit.org/show_bug.cgi?id=31126
1048
1049         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
1050
1051         * Scripts/modules/bugzilla.py:
1052
1053 2009-11-19  Eric Z. Ayers  <zundel@google.com>
1054
1055         Reviewed by Pavel Feldman.
1056
1057         Forces a WM_PAINT event on calling layoutTestController.display()
1058         in order to enable the timeline-paint.html test on Windows.
1059         ::UpdateWindow() does not force an event becaue the window is 
1060         not visible.
1061
1062         https://bugs.webkit.org/show_bug.cgi?id=31402
1063
1064         * DumpRenderTree/win/DumpRenderTree.cpp:
1065         (displayWebView):
1066
1067 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
1068
1069         No review needed.
1070
1071         Added myself to committers list.
1072
1073         * Scripts/modules/committers.py:
1074
1075 2009-11-19  Adam Barth  <abarth@webkit.org>
1076
1077         Reviewed by Eric Seidel.
1078
1079         Bugzilla-tool command classes should match command names
1080         https://bugs.webkit.org/show_bug.cgi?id=31666
1081
1082         I renamed all the commands except CommitMessageForCurrentDiff because
1083         the new name would conflict with an existing class.
1084
1085         * Scripts/bugzilla-tool:
1086
1087 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
1088
1089         Reviewed by Gustavo Noronha Silva.
1090
1091         Web Inspector: Implement "show inspector" in WebKit GTK
1092         API and enable console tests.
1093
1094         https://bugs.webkit.org/show_bug.cgi?id=31669
1095
1096         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1097         (LayoutTestController::showWebInspector):
1098
1099 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1100
1101         Reviewed by Simon Hausmann.
1102
1103         Minor refactoring + more documentation.
1104
1105         * DumpRenderTree/qt/DumpRenderTree.cpp:
1106         (WebCore::clearHistory):
1107         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1108
1109 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
1110
1111         Reviewed by Eric Seidel.
1112
1113         Ignore websocket tests when --no-http is specified.
1114         https://bugs.webkit.org/show_bug.cgi?id=31662
1115
1116         * Scripts/run-webkit-tests:
1117
1118 2009-11-18  Adam Barth  <abarth@webkit.org>
1119
1120         Reviewed by Eric Seidel.
1121
1122         Normalize ' and " in bugzilla-tool
1123         https://bugs.webkit.org/show_bug.cgi?id=31655
1124
1125         We decided " is better than ' and we should be consistent.
1126
1127         * Scripts/bugzilla-tool:
1128
1129 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1130
1131         Reviewed by Kenneth Rohde Christiansen.
1132
1133         [Qt] Remove support for Qt v4.3 or older versions
1134         https://bugs.webkit.org/show_bug.cgi?id=29469
1135
1136         * DumpRenderTree/qt/DumpRenderTree.pro:
1137         * DumpRenderTree/qt/ImageDiff.pro:
1138
1139 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1140
1141         Reviewed by Eric Seidel.
1142
1143         GitTest.test_create_binary_patch fails if /tmp is symlink
1144         https://bugs.webkit.org/show_bug.cgi?id=31536
1145
1146         * Scripts/modules/scm_unittest.py:
1147
1148 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
1149
1150         Reviewed by Darin Adler.
1151
1152         Configuration for Chromium Build Slaves.
1153
1154         https://bugs.webkit.org/show_bug.cgi?id=31442
1155
1156         * BuildSlaveSupport/build.webkit.org-config/config.json:
1157         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1158
1159 2009-11-18  Eric Seidel  <eric@webkit.org>
1160
1161         Reviewed by Darin Adler.
1162
1163         workqueue.py results in totally broken commit-queue UI
1164         https://bugs.webkit.org/show_bug.cgi?id=31645
1165
1166         * Scripts/bugzilla-tool:
1167          - Remove unneeded use of PatchCollection.
1168          - Grab a new copy of the cq'd patches every run of the queue.
1169
1170 2009-11-18  Sam Weinig  <sam@webkit.org>
1171
1172         Reviewed by Anders Carlsson.
1173
1174         Make the Mac Geolocation API async.
1175
1176         Update DRT to use the new async Mac Geolocation API.
1177
1178         * DumpRenderTree/mac/UIDelegate.mm:
1179         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1180
1181 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1182
1183         Reviewed by Kenneth Rohde Christiansen.
1184
1185         Add and option to toggle HTML5 datalist support to build-webkit
1186         https://bugs.webkit.org/show_bug.cgi?id=31599
1187
1188         * Scripts/build-webkit:
1189
1190 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1191
1192         Reviewed by Kevin Ollivier.
1193
1194         Enable wx plugin support using the Windows implementation as a base.
1195         
1196         https://bugs.webkit.org/show_bug.cgi?id=31636
1197
1198         * wx/build/settings.py:
1199
1200 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1201
1202         Reviewed by Simon Hausmann.
1203
1204         Change the initialization order so that the controllers
1205         will be created before exporting them to the JS DOM window.
1206
1207         * DumpRenderTree/qt/DumpRenderTree.cpp:
1208         (WebCore::DumpRenderTree::DumpRenderTree):
1209
1210 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1211
1212         Reviewed by Simon Hausmann.
1213
1214         Fix a code copy and paste error. m_page should be page.
1215
1216         * DumpRenderTree/qt/DumpRenderTree.cpp:
1217         (WebCore::DumpRenderTree::createWindow):
1218
1219 2009-11-17  Mark Rowe  <mrowe@apple.com>
1220
1221         Reviewed by Alexey Proskuryakov.
1222
1223         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
1224
1225         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
1226         This prevents symlinks from confusing the descendant check.
1227
1228 2009-11-17  Mark Rowe  <mrowe@apple.com>
1229
1230         Reviewed by Alexey Proskuryakov.
1231
1232         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
1233
1234         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
1235         server to be up rather than having run-webkit-tests abort immediately.
1236
1237         * Scripts/run-webkit-tests:
1238
1239 2009-11-17  Eric Seidel  <eric@webkit.org>
1240
1241         Reviewed by Darin Adler.
1242
1243         commit-queue is failing to set reviewer in ChangeLogs
1244         https://bugs.webkit.org/show_bug.cgi?id=31592
1245
1246         * Scripts/bugzilla-tool: Clarify the "applying" log message.
1247         * Scripts/modules/bugzilla.py:
1248          - Add a new _validate_committer_and_reviewer function as a
1249            temporary solution until we can make a real Attachment object
1250            which knows how to fill in its committer/reviewer fields automatically.
1251
1252 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1253
1254         Unreviewed buildbot fix.
1255
1256         Revert part of earlier patch and add comment, as it
1257         was causing timeouts on the buildbot.
1258
1259         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1260         (LayoutTestController::notifyDone):
1261
1262 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1263
1264         Reviewed by Oliver Hunt.
1265
1266         Make the timeout 15 sec as for the other DRT's and make
1267         it print out the same output when a test timeout.
1268
1269         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1270         (LayoutTestController::waitUntilDone):
1271         (LayoutTestController::notifyDone):
1272         (LayoutTestController::timerEvent):
1273
1274 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
1275
1276         Reviewed by Timothy Hatcher.
1277
1278         Fixed typos in comments.
1279
1280         * Scripts/modules/committers.py:
1281
1282 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
1283
1284         Reviewed by Timothy Hatcher.
1285
1286         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1287         - Updated DRT to show/close inspector for all tests under /inspector
1288         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1289           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1290         - Removed reload on each inspector test
1291         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1292         inspector for those.
1293         - Reimplemented timeline tests in order to get rid of reload there.
1294         - Moved tests that don't require harness into the fast group.
1295
1296         https://bugs.webkit.org/show_bug.cgi?id=31472
1297
1298         * DumpRenderTree/LayoutTestController.cpp:
1299         (setTimelineProfilingEnabledCallback):
1300         (closeWebInspectorCallback):
1301         (LayoutTestController::staticFunctions):
1302         * DumpRenderTree/LayoutTestController.h:
1303         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1304         (shouldOpenWebInspector):
1305         (runTest):
1306         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1307         (LayoutTestController::setTimelineProfilingEnabled):
1308         * DumpRenderTree/mac/DumpRenderTree.mm:
1309         (shouldOpenWebInspector):
1310         (runTest):
1311         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1312         (LayoutTestController::setTimelineProfilingEnabled):
1313         * DumpRenderTree/win/DumpRenderTree.cpp:
1314         (shouldOpenWebInspector):
1315         (runTest):
1316         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1317         (LayoutTestController::setTimelineProfilingEnabled):
1318
1319 2009-11-17  Oliver Hunt  <oliver@apple.com>
1320
1321         Reviewed by Maciej Stachowiak.
1322
1323         Incorrect use of JavaScriptCore API in DumpRenderTree
1324         https://bugs.webkit.org/show_bug.cgi?id=31577
1325
1326         Return undefined rather than a literal null.
1327
1328         * DumpRenderTree/AccessibilityUIElement.cpp:
1329         (setSelectedTextRangeCallback):
1330         (incrementCallback):
1331         (decrementCallback):
1332         (showMenuCallback):
1333
1334 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1335
1336         Reviewed by Beth Dakin.
1337
1338         AX: aria-labelledby duplicates some of its WAI-ARIA label
1339         https://bugs.webkit.org/show_bug.cgi?id=31565
1340
1341         * DumpRenderTree/AccessibilityUIElement.cpp:
1342         (titleUIElementCallback):
1343         (getIsValidCallback):
1344         (AccessibilityUIElement::getJSClass):
1345
1346 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1347
1348         Reviewed by Simon Hausmann.
1349
1350         r50942 broke output from created windows. Make the
1351         m_enableTextOutput a member of the DRT and not the
1352         WebPage.
1353
1354         * DumpRenderTree/qt/DumpRenderTree.cpp:
1355         (WebCore::WebPage::WebPage):
1356         (WebCore::WebPage::javaScriptAlert):
1357         (WebCore::WebPage::javaScriptConsoleMessage):
1358         (WebCore::WebPage::javaScriptConfirm):
1359         (WebCore::WebPage::javaScriptPrompt):
1360         (WebCore::WebPage::acceptNavigationRequest):
1361         (WebCore::DumpRenderTree::DumpRenderTree):
1362         (WebCore::DumpRenderTree::open):
1363         (WebCore::DumpRenderTree::createWindow):
1364         * DumpRenderTree/qt/DumpRenderTree.h:
1365         (WebCore::DumpRenderTree::setTextOutputEnabled):
1366         (WebCore::DumpRenderTree::isTextOutputEnabled):
1367         (WebCore::WebPage::shouldInterruptJavaScript):
1368         (WebCore::WebPage::isTextOutputEnabled):
1369         (WebCore::WebPage::setViewGeometry):
1370
1371 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1372
1373         Reviewed by Gustavo Noronha Silva.
1374
1375         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
1376         as the implementation is being used by at least Qt and Gtk+.
1377
1378         Update buildsystems as well.
1379
1380         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1381         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1382         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1383         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1384         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1385         * GNUmakefile.am:
1386
1387 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
1388
1389         Reviewed by Alexey Proskuryakov.
1390
1391         Disable wss until all platforms support pyOpenSSL
1392
1393         https://bugs.webkit.org/show_bug.cgi?id=31479
1394
1395         * Scripts/run-webkit-tests:
1396
1397 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1398
1399         Reviewed by Kenneth Christiansen.
1400
1401         [Qt] Implement load error pages support for Qt's DRT.
1402         https://bugs.webkit.org/show_bug.cgi?id=31509
1403
1404         For now, it will not be a default feature, and layout tests
1405         that want to make use of this have to explicitily call
1406         'handleErrorPages();' for the test source.
1407
1408         Any of the other DumpRenderTree's (mac, win and gtk)
1409         support handling error pages. Qt's will be the first.
1410
1411         * DumpRenderTree/qt/DumpRenderTree.cpp:
1412         (WebCore::WebPage::supportsExtension):
1413         (WebCore::WebPage::extension):
1414         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1415         (LayoutTestController::reset):
1416         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1417         (LayoutTestController::shouldHandleErrorPages):
1418         (LayoutTestController::handleErrorPages):
1419
1420 2009-11-16  Eric Seidel  <eric@webkit.org>
1421
1422         Reviewed by Adam Barth.
1423
1424         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1425         https://bugs.webkit.org/show_bug.cgi?id=31549
1426
1427         Renamed --commit-queue to --non-interactive in most places
1428         and remove the code in land-patches which is no longer needed.
1429
1430         * Scripts/bugzilla-tool:
1431
1432 2009-11-16  Eric Seidel  <eric@webkit.org>
1433
1434         Reviewed by Adam Barth.
1435
1436         The commit-queue should use land-attachment
1437         https://bugs.webkit.org/show_bug.cgi?id=31548
1438
1439         * Scripts/bugzilla-tool:
1440
1441 2009-11-16  Adam Barth  <abarth@webkit.org>
1442
1443         Reviewed by Eric Seidel.
1444
1445         Convert CommitQueue over to PatchCollection
1446         https://bugs.webkit.org/show_bug.cgi?id=31547
1447
1448         Also fixes a bug in workqueue and adds a test!
1449
1450         * Scripts/bugzilla-tool:
1451         * Scripts/modules/workqueue.py:
1452         * Scripts/modules/workqueue_unittest.py:
1453
1454 2009-11-16  Adam Barth  <abarth@webkit.org>
1455
1456         Reviewed by Eric Seidel.
1457
1458         Move StyleQueue over to using PatchCollection
1459         https://bugs.webkit.org/show_bug.cgi?id=31544
1460
1461         That's what the class it's for.
1462
1463         * Scripts/bugzilla-tool:
1464         * Scripts/modules/patchcollection.py:
1465         * Scripts/modules/patchcollection_unittest.py:
1466
1467 2009-11-16  Eric Seidel  <eric@webkit.org>
1468
1469         Reviewed by Adam Barth.
1470
1471         bugzilla-tool needs a land-attachment command
1472         https://bugs.webkit.org/show_bug.cgi?id=31546
1473
1474         * Scripts/bugzilla-tool:
1475          - Move all the logic into AbstractLandingCommand and
1476            add a new LandAttachment command subclass.
1477          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1478
1479 2009-11-16  Eric Seidel  <eric@webkit.org>
1480
1481         Reviewed by Adam Barth.
1482
1483         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1484         https://bugs.webkit.org/show_bug.cgi?id=31543
1485
1486         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1487
1488         * Scripts/bugzilla-tool:
1489
1490 2009-11-16  Eric Seidel  <eric@webkit.org>
1491
1492         Reviewed by Adam Barth.
1493
1494         Disable the style queue from posting to the commit queue status page.
1495
1496         * Scripts/bugzilla-tool:
1497
1498 2009-11-16  Adam Barth  <abarth@webkit.org>
1499
1500         Reviewed by Eric Seidel.
1501
1502         Implement PatchCollection
1503         https://bugs.webkit.org/show_bug.cgi?id=31541
1504
1505         This class holds a set of patches and lets clients iterate through
1506         them.  Optionally, clients can install a filter.
1507
1508         * Scripts/modules/patchcollection.py: Added.
1509         * Scripts/modules/patchcollection_unittest.py: Added.
1510         * Scripts/run-webkit-unittests:
1511
1512 2009-11-16  Eric Seidel  <eric@webkit.org>
1513
1514         Reviewed by Adam Barth.
1515
1516         bugzilla-tool land-patches will close bugs with patches r=?
1517         https://bugs.webkit.org/show_bug.cgi?id=28230
1518
1519         The commit-queue shouldn't close patches with outstanding reviews on them,
1520         even if many reviewers seem to be against multi-patch bugs.
1521
1522         * Scripts/bugzilla-tool:
1523
1524 2009-11-16  Eric Seidel  <eric@webkit.org>
1525
1526         Reviewed by Adam Barth.
1527
1528         bugzilla-tool check-style should work with attachment ids instead of bug ids
1529         https://bugs.webkit.org/show_bug.cgi?id=31540
1530
1531         * Scripts/bugzilla-tool:
1532
1533 2009-11-16  Eric Seidel  <eric@webkit.org>
1534
1535         Reviewed by Adam Barth.
1536
1537         WorkQueue is the only place that should know about special exit codes
1538         https://bugs.webkit.org/show_bug.cgi?id=31534
1539
1540         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1541         and add tests for handling exit codes.
1542         I also cleaned up workqueue_unittest.py more.
1543
1544         * Scripts/bugzilla-tool:
1545         * Scripts/modules/workqueue.py:
1546         * Scripts/modules/workqueue_unittest.py:
1547
1548 2009-11-16  Eric Seidel  <eric@webkit.org>
1549
1550         Reviewed by Adam Barth.
1551
1552         Re-factor workqueue_unittest to allow for more than one test.
1553         https://bugs.webkit.org/show_bug.cgi?id=31535
1554
1555         * Scripts/modules/workqueue_unittest.py:
1556
1557 2009-11-16  Eric Seidel  <eric@webkit.org>
1558
1559         Reviewed by Adam Barth.
1560
1561         land-patches needs to be re-factored into smaller chunks
1562         https://bugs.webkit.org/show_bug.cgi?id=31532
1563
1564         * Scripts/bugzilla-tool: fix a couple obvious typos.
1565
1566 2009-11-16  Eric Seidel  <eric@webkit.org>
1567
1568         Reviewed by Adam Barth.
1569
1570         land-patches needs to be re-factored into smaller chunks
1571         https://bugs.webkit.org/show_bug.cgi?id=31532
1572
1573         The next patch will move these methods into WebKitLandingScripts.
1574
1575         * Scripts/bugzilla-tool:
1576          - Split out _land_patch and _close_bug_if_no_active_patches.
1577
1578 2009-11-16  Adam Barth  <abarth@webkit.org>
1579
1580         Reviewed by Eric Seidel.
1581
1582         Fix silly copy-and-paste code.  I am a terrible coder.
1583
1584         * Scripts/modules/bugzilla.py:
1585
1586 2009-11-16  Adam Barth  <abarth@webkit.org>
1587
1588         Reviewed by Eric Seidel.
1589
1590         Implement a StyleQueue
1591         https://bugs.webkit.org/show_bug.cgi?id=31537
1592
1593         The first iteration of the style queue only produces output locally.
1594         There is also a limit of 10 patches because it's not that useful to
1595         iterate through the entire review queue at this point.  We can remove
1596         the limit later.
1597
1598         * Scripts/bugzilla-tool:
1599         * Scripts/modules/bugzilla.py:
1600
1601 2009-11-16  Adam Barth  <abarth@webkit.org>
1602
1603         Reviewed by Eric Seidel.
1604
1605         Unit test WorkQueue
1606         https://bugs.webkit.org/show_bug.cgi?id=31531
1607
1608         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1609
1610         * Scripts/bugzilla-tool:
1611         * Scripts/modules/statusbot.py:
1612         * Scripts/modules/workqueue.py:
1613         * Scripts/modules/workqueue_unittest.py: Added.
1614         * Scripts/run-webkit-unittests:
1615
1616 2009-11-16  Eric Seidel  <eric@webkit.org>
1617
1618         Reviewed by Adam Barth.
1619
1620         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1621         https://bugs.webkit.org/show_bug.cgi?id=31530
1622
1623         * Scripts/bugzilla-tool:
1624
1625 2009-11-16  Eric Seidel  <eric@webkit.org>
1626
1627         Reviewed by Adam Barth.
1628
1629         bugzilla-tool needs apply-attachment
1630         https://bugs.webkit.org/show_bug.cgi?id=31528
1631
1632         * Scripts/bugzilla-tool:
1633          - Add ApplyAttachment command.
1634          - Abstract applying code into WebKitApplyingScripts.
1635          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1636         * Scripts/modules/bugzilla.py:
1637          - Add fetch_attachment and bug_id_for_attachment_id.
1638         * Scripts/modules/bugzilla_unittest.py:
1639          - Add test for new parsing.
1640          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1641
1642 2009-11-16  Eric Seidel  <eric@webkit.org>
1643
1644         Reviewed by Adam Barth.
1645
1646         Document check-style's use of force_clean.
1647
1648         * Scripts/bugzilla-tool:
1649         * Scripts/modules/scm.py:
1650
1651 2009-11-16  Adam Barth  <abarth@webkit.org>
1652
1653         Reviewed by Eric Seidel.
1654
1655         Move WorkQueue to its own file
1656         https://bugs.webkit.org/show_bug.cgi?id=31529
1657
1658         WorkQueue and WorkQueueDelegate are separate concerns from
1659         bugzilla-tool.  Also added a missing include to logging.py.
1660
1661         * Scripts/bugzilla-tool:
1662         * Scripts/modules/logging.py:
1663         * Scripts/modules/workqueue.py:
1664
1665 2009-11-16  Adam Barth  <abarth@webkit.org>
1666
1667         Reviewed by Eric Seidel.
1668
1669         Move OutputTee to logging.py.
1670
1671         * Scripts/bugzilla-tool:
1672         * Scripts/modules/logging.py:
1673
1674 2009-11-15  Adam Barth  <abarth@webkit.org>
1675
1676         Reviewed by Eric Seidel.
1677
1678         Refactor bugzilla-tool to allow for multiple queues
1679         https://bugs.webkit.org/show_bug.cgi?id=31513
1680
1681         Divide the commit queue class into three class to make creating
1682         additional queues easier.
1683
1684         * Scripts/bugzilla-tool:
1685
1686 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1687
1688         Reviewed by Eric Seidel.
1689
1690         svn-apply may not handle git patches created by bugzilla-tool
1691         https://bugs.webkit.org/show_bug.cgi?id=31457
1692
1693         * Scripts/modules/scm.py:
1694         * Scripts/modules/scm_unittest.py:
1695
1696 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1697
1698         Reviewed by Eric Seidel.
1699
1700         bugzilla-tool should post git binary diff
1701         https://bugs.webkit.org/show_bug.cgi?id=31458
1702
1703         Add --binary option to Git.create_patch.
1704
1705         * Scripts/modules/scm.py:
1706         * Scripts/modules/scm_unittest.py:
1707
1708 2009-11-15  Adam Barth  <abarth@webkit.org>
1709
1710         Reviewed by Darin Adler.
1711
1712         Add bugzilla-tool check-style
1713         https://bugs.webkit.org/show_bug.cgi?id=31515
1714
1715         * Scripts/bugzilla-tool:
1716         * Scripts/modules/bugzilla.py:
1717
1718 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1719
1720         Reviewed by Simon Hausmann.
1721
1722         Make the Qt Linux only --valgrind feature, suppress errors
1723         defined in the SuppressedValgrindErrors file.
1724
1725         * Scripts/run-webkit-tests:
1726
1727 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1728
1729         Reviewed by Simon Hausmann.
1730
1731         Set the locale to C and not to the current one in use on the system.
1732
1733         * DumpRenderTree/qt/DumpRenderTree.cpp:
1734         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1735
1736 2009-11-13  Adam Roben  <aroben@apple.com>
1737
1738         Add support for
1739         http/tests/security/isolatedWorld/didClearWindowObject.html
1740
1741         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1742         window objects in isolated worlds are cleared
1743
1744         Reviewed by Dave Hyatt.
1745
1746         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1747
1748         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1749         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1750         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1751         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1752         Added. Sets a __worldID property on the global object whose value is
1753         the ID of this world.
1754         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1755         Respond to this new delegate callback by calling through to one of the
1756         above new methods.
1757         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1758         (worldMap): Added. Returns a HashMap containing all the worlds we've
1759         created.
1760         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1761         haven't kept track of this world.
1762         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1763         instead of declaring our own.
1764
1765         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1766
1767         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1768         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1769         didClearWindowObjectForFrameInStandardWorld.
1770         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1771         Respond to this new delegate callback by calling through to one of the
1772         below new methods.
1773         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1774         Added. Sets a __worldID property on the gobal object whose value is
1775         the ID of this world.
1776         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1777         Added. Moved code here from didClearWindowObject.
1778
1779         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1780         didClearWindowObjectForFrame* functions.
1781
1782         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1783         (worldMap): Added. Returns a HashMap containing all the worlds we've
1784         created.
1785         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1786         haven't kept track of this world.
1787         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1788         instead of declaring our own.
1789
1790 2009-11-13  Adam Roben  <aroben@apple.com>
1791
1792         Finish replacing worldIDs with world objects
1793
1794         The only remaining use of worldIDs was in a method only used by DRT
1795         for the isolated worlds tests.
1796
1797         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1798
1799         Reviewed by Mark Rowe.
1800
1801         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1802         (LayoutTestController::evaluateScriptInIsolatedWorld):
1803         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1804         (LayoutTestController::evaluateScriptInIsolatedWorld):
1805         Updated for changes to WebFrame. Now holds the map of worldID -> world
1806         at this level instead of making WebKit do it.
1807
1808 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1809
1810         Reviewed by Simon Hausmann.
1811
1812         [Qt] Ensure the DRT does not output anything until first test is run
1813
1814         * DumpRenderTree/qt/DumpRenderTree.cpp:
1815         * DumpRenderTree/qt/DumpRenderTree.h:
1816
1817 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1818
1819         Reviewed by Tor Arne Vestbø.
1820
1821         Clear the undo stack in before each new test run.
1822
1823         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1824
1825         * DumpRenderTree/qt/DumpRenderTree.cpp:
1826         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1827
1828 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1829
1830         Reviewed by Kenneth Rohde Christiansen.
1831
1832         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1833
1834         * DumpRenderTree/qt/DumpRenderTree.cpp:
1835         (WebCore::WebPage::resetSettings):
1836         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1837         (LayoutTestController::overridePreference):
1838
1839 2009-11-13  Eric Seidel  <eric@webkit.org>
1840
1841         Reviewed by Adam Barth.
1842
1843         Update committers.py based on svn records
1844         https://bugs.webkit.org/show_bug.cgi?id=31366
1845
1846         This list was generated using validate-committer-lists from
1847         https://bugs.webkit.org/show_bug.cgi?id=30970
1848         and makes committers.py current for committers who have
1849         committed in the last 3 years.
1850
1851         * Scripts/modules/committers.py:
1852
1853 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1854
1855         Reviewed by Adam Barth.
1856
1857         The document-open.html test was flaky at times. The test invokes the layout test plugin
1858         which in its destroy stream handler opens a new document. This basically tears down the
1859         stream and the associated plugin instance. The pluginLog function in the layout test
1860         plugin attempts to retrieve the window script object on a torn down plugin instance
1861         which crashed consistently on windows in the debugger. The functions which issue
1862         these logs already have a valid window script object. We now have variants of the pluginLog
1863         function which take in a window script object with and without variable arguments. 
1864
1865         https://bugs.webkit.org/show_bug.cgi?id=31067
1866
1867         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1868         (pluginLogWithWindowObject):
1869         (pluginLogWithWindowObjectVariableArgs):
1870         (pluginLog):
1871         (notifyTestCompletion):
1872         (testDocumentOpen):
1873         (testWindowOpen):
1874
1875 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1876
1877         Reviewed by Gustavo Noronha Silva.
1878
1879         https://bugs.webkit.org/show_bug.cgi?id=30997
1880         [Gtk] Implemment AtkDocument
1881
1882         Added testing support.
1883
1884         * DumpRenderTree/AccessibilityUIElement.cpp:
1885         * DumpRenderTree/AccessibilityUIElement.h:
1886         (getDocumentEncodingCallback):
1887         (getDocumentURICallback):
1888         (AccessibilityUIElement::getJSClass):
1889         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1890         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1891         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1892         (AccessibilityUIElement::documentEncoding):
1893         (AccessibilityUIElement::documentURI):
1894
1895 2009-11-12  Adam Roben  <aroben@apple.com>
1896
1897         Replace worldIDs with world objects
1898
1899         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1900         user scripts/stylesheets and isolated worlds
1901
1902         Reviewed by Sam Weinig.
1903
1904         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1905         (LayoutTestController::addUserScript):
1906         (LayoutTestController::addUserStyleSheet):
1907         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1908         (LayoutTestController::addUserScript):
1909         (LayoutTestController::addUserStyleSheet):
1910         Changed these functions to create a new WebJSWorld each time they're
1911         called and to pass that world to WebKit.
1912
1913 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1914
1915         Reviewed by Oliver Hunt.
1916
1917         need to implement aria tree roles
1918         https://bugs.webkit.org/show_bug.cgi?id=31284
1919
1920         * DumpRenderTree/AccessibilityUIElement.cpp:
1921         (disclosedRowAtIndexCallback):
1922         (selectedRowAtIndexCallback):
1923         (isEqualCallback):
1924         (isAttributeSettableCallback):
1925         (isActionSupportedCallback):
1926         (disclosedByRowCallback):
1927         (hierarchicalLevelCallback):
1928         (AccessibilityUIElement::getJSClass):
1929         * DumpRenderTree/AccessibilityUIElement.h:
1930         (AccessibilityUIElement::isEqual):
1931         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1932         (AccessibilityUIElement::hierarchicalLevel):
1933         (AccessibilityUIElement::disclosedRowAtIndex):
1934         (AccessibilityUIElement::selectedRowAtIndex):
1935         (AccessibilityUIElement::disclosedByRow):
1936         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1937         (AccessibilityUIElement::getChildAtIndex):
1938         (AccessibilityUIElement::disclosedRowAtIndex):
1939         (AccessibilityUIElement::selectedRowAtIndex):
1940         (AccessibilityUIElement::titleUIElement):
1941         (AccessibilityUIElement::parentElement):
1942         (AccessibilityUIElement::disclosedByRow):
1943         (AccessibilityUIElement::hierarchicalLevel):
1944         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1945         (AccessibilityUIElement::hierarchicalLevel):
1946         (AccessibilityUIElement::disclosedRowAtIndex):
1947         (AccessibilityUIElement::selectedRowAtIndex):
1948         (AccessibilityUIElement::disclosedByRow):
1949
1950 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1951
1952         Reviewed by Darin Adler.
1953
1954         svn-apply can not handle git binary diffs
1955         https://bugs.webkit.org/show_bug.cgi?id=26830
1956
1957         Support "literal" type git binary diffs.
1958
1959         * Scripts/VCSUtils.pm:
1960         * Scripts/modules/scm_unittest.py:
1961         * Scripts/svn-apply:
1962
1963 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1964
1965         Not reviewed, removing duplicate entry for myself in committers.py.
1966
1967         * Scripts/modules/committers.py:
1968
1969 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1970
1971         Reviewed by Darin Adler and Mark Rowe.
1972
1973         https://bugs.webkit.org/show_bug.cgi?id=31200
1974         Tests in http/tests/security/mixedContent start to fail when new tests are added
1975
1976         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1977
1978 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1979
1980         Reviewed by Jan Alonzo.
1981
1982         Create, and display a window for the inspector, for inspector
1983         tests.
1984
1985         Need to also show/hide the inspector window to avoid having
1986         problems with code assuming it is realized
1987         https://bugs.webkit.org/show_bug.cgi?id=31347
1988
1989         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1990         (webInspectorShowWindow):
1991         (webInspectorCloseWindow):
1992         (webInspectorInspectWebView):
1993         (createWebView):
1994
1995 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1996
1997         Unreviewed Qt buildbot fix.
1998
1999         My previous fix was wrong, so revert that change and fix it by
2000         returning when the document of the frame has no document element.
2001         Idea is borrowed from mac and win DRT.
2002
2003         * DumpRenderTree/qt/DumpRenderTree.cpp:
2004         (WebCore::DumpRenderTree::dumpFramesAsText):
2005
2006 2009-11-11  Eric Seidel  <eric@webkit.org>
2007
2008         Reviewed byg Kenneth Rohde Christiansen.
2009
2010         Update Kenneth's committer record to include the email he
2011         uses on lists.webkit.org.
2012
2013         * Scripts/modules/committers.py:
2014
2015 2009-11-11  Eric Seidel  <eric@webkit.org>
2016
2017         Reviewed by Gustavo Noronha Silva.
2018
2019         Several committers use separate email addresses for bugzilla and svn.webkit.org
2020         https://bugs.webkit.org/show_bug.cgi?id=31364
2021
2022         Update records for existing committers to include email addresses
2023         used in svn.webkit.org and lists.webkit.org.
2024         Most committers use the same email address in all 3 places, but some use
2025         separate addresses.  committers.py needs record of each of these addresses.
2026
2027         * Scripts/modules/committers.py:
2028
2029 2009-11-11  Eric Seidel  <eric@webkit.org>
2030
2031         No review, adding second email address for an existing committer.
2032
2033         Add Yong Li's second bugzilla account to his committer record.
2034         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
2035
2036         * Scripts/modules/committers.py:
2037
2038 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2039
2040         Reviewed by Simon Hausmann.
2041
2042         If the frame has no innerText don't append it, and
2043         do not add a newline which breaks some cross platform
2044         results.
2045
2046         * DumpRenderTree/qt/DumpRenderTree.cpp:
2047         (WebCore::DumpRenderTree::dumpFramesAsText):
2048
2049 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2050
2051         Reviewed by Simon Hausmann.
2052
2053         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
2054
2055         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2056         (webkit_test_plugin_new_instance):
2057         (webkit_test_plugin_destroy_instance):
2058         (webkit_test_plugin_destroy_stream):
2059
2060 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2061
2062         Reviewed by Mark Rowe.
2063
2064         Implement the functionality needed by plugins/window-open.html
2065
2066         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2067         (webkit_test_plugin_new_instance):
2068         (webkit_test_plugin_set_window):
2069
2070 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2071
2072         Reviewed by Simon Hausmann.
2073
2074         [Qt] Force -graphicssystem raster and -style windows when running DRT
2075
2076         * DumpRenderTree/qt/main.cpp:
2077         * Scripts/run-webkit-tests:
2078
2079 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2080
2081         Reviewed by Simon Hausmann.
2082
2083         Compute correct library paths for Qt
2084
2085         * Scripts/webkitdirs.pm:
2086
2087 2009-11-10  Mark Rowe  <mrowe@apple.com>
2088
2089         Reviewed by Sam Weinig.
2090
2091         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
2092
2093         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
2094         about the validity of the self-signed certificates used in the regression tests.  We would then add the
2095         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
2096         that had enabled frame load delegate logging this would result in extra log messages being generated,
2097         causing the test to fail.
2098
2099         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
2100         tests.
2101
2102         * DumpRenderTree/mac/DumpRenderTree.mm:
2103         (dumpRenderTree):
2104         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2105         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2106
2107 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2108
2109         Reviewed by Kenneth Rohde Christiansen.
2110
2111         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
2112
2113         * DumpRenderTree/qt/DumpRenderTree.cpp:
2114         (WebCore::DumpRenderTree::DumpRenderTree):
2115
2116 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2117
2118         Reviewed by Jan Alonzo.
2119
2120         [GTK] Remove WebSocket configuration from WebKitWebSettings
2121         https://bugs.webkit.org/show_bug.cgi?id=31244
2122
2123         Follow-up of r50724. Don't set the enable-web-socket property
2124         anymore.
2125
2126         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2127         (resetDefaultsToConsistentValues):
2128
2129 2009-11-10  Oliver Hunt  <oliver@apple.com>
2130
2131         Reviewed by Maciej Stachowiak.
2132
2133         Rename 3D Canvas related classes to use WebGL prefix
2134         https://bugs.webkit.org/show_bug.cgi?id=29095
2135
2136         Checkin new version of do-webcore-rename used to do the WebGL type rename,
2137         and upate webkitdirs script to new method of testing for WebGL.
2138
2139         * Scripts/do-webcore-rename:
2140         * Scripts/webkitdirs.pm:
2141
2142 2009-11-09  Oliver Hunt  <oliver@apple.com>
2143
2144         Reviewed by Geoff Garen.
2145
2146         Make do-webcore-rename work with git.
2147
2148         * Scripts/do-webcore-rename:
2149
2150 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2151
2152         Adding Kenneth to the reviewers list.
2153
2154         * Scripts/modules/committers.py:
2155
2156 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2157
2158         Reviewed by Jan Alonzo.
2159
2160         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2161         https://bugs.webkit.org/show_bug.cgi?id=30482
2162
2163         LayoutTestControllerGtk now uses the exposed
2164         Page::tabKeyCyclesThroughElements API
2165
2166         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2167         (LayoutTestController::setTabKeyCyclesThroughElements):
2168
2169 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
2170
2171         Reviewed by Holger Freyther.
2172
2173         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
2174         This helps to pass the test case below. Also replaced hardcoded
2175         code numbers with defined constants.
2176         https://bugs.webkit.org/show_bug.cgi?id=31185
2177         
2178         Test: editing/undo/undo-deleteWord.html
2179
2180         * DumpRenderTree/qt/EventSenderQt.cpp:
2181         (EventSender::keyDown):
2182
2183 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
2184
2185         Reviewed by Holger Freyther.
2186
2187         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
2188         https://bugs.webkit.org/show_bug.cgi?id=31164
2189
2190         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
2191
2192         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2193         (LayoutTestController::processWork):
2194
2195 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
2196
2197         Reviewed by Holger Freyther.
2198
2199         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
2200         https://bugs.webkit.org/show_bug.cgi?id=31158
2201
2202         By invoking a script queue'd by queueScript(), 'true' was beeing returned
2203         always, which from WorkQueue prospective means that a load has been started
2204         and the queue processing should stop and wait for the load to finish.
2205         Spinning it off into a loading and a non-loading variants was the solution
2206         adopted by Mac's DRT to work around this problem. The former keeps returning
2207         'true' while the later executes the script synchronously and returns 'false'
2208         making it possible to the WorkQueue to proceed right away.
2209
2210         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2211         (LayoutTestController::processWork):
2212         (LayoutTestController::queueLoadingScript):
2213         (LayoutTestController::queueNonLoadingScript):
2214         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2215         * DumpRenderTree/qt/WorkQueueItem.h:
2216         (LoadingScriptItem::LoadingScriptItem):
2217         (LoadingScriptItem::invoke):
2218         (NonLoadingScriptItem::NonLoadingScriptItem):
2219         (NonLoadingScriptItem::invoke):
2220
2221 2009-11-07  Mark Rowe  <mrowe@apple.com>
2222
2223         Rubber-stamped by Cameron Zwarich.
2224
2225         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
2226
2227         * Scripts/commit-log-editor:
2228
2229 2009-11-07  Mark Rowe  <mrowe@apple.com>
2230
2231         Reviewed by Darin Adler.
2232
2233         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
2234         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
2235
2236         Move logic for determining the name and email address to use in a ChangeLog entry from
2237         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
2238         whether the author of the patch matches committer, and therefore needs access to the
2239         email address that would be used in a ChangeLog entry.
2240
2241         Based on a patch by Pierre d'Herbemont.
2242
2243         * Scripts/VCSUtils.pm:
2244         * Scripts/commit-log-editor:
2245         * Scripts/prepare-ChangeLog:
2246         * Scripts/webkitdirs.pm:
2247
2248 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2249
2250         Reviewed by Adam Barth.
2251
2252         Added functionality to the layout test plugin to invoke document.open and
2253         window.open with default arguments. The associated webkit bug is
2254         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
2255         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
2256         work in Chromium (V8) if there is no calling javascript context. To achieve this
2257         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
2258         for the window.open test case and in NPP_DestroyStream for the document.open test case.
2259
2260         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2261         (testDocumentOpen):
2262         (testWindowOpen):
2263         (pluginAllocate):
2264         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2265         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2266         (NPP_New):
2267         (NPP_SetWindow):
2268         (NPP_DestroyStream):
2269         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2270         (NPP_New):
2271         (NPP_SetWindow):
2272         (NPP_NewStream):
2273         (NPP_DestroyStream):
2274
2275 2009-11-06  Eric Seidel  <eric@webkit.org>
2276
2277         Reviewed by Adam Barth.
2278
2279         bugzilla-tool crashed with exception
2280         https://bugs.webkit.org/show_bug.cgi?id=31092
2281
2282         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
2283
2284 2009-11-04  Eric Seidel  <eric@webkit.org>
2285
2286         No review, just add a line which got left out of the patch uploaded for commit.
2287
2288         commit-queue is crashing when trying to reject patches after unknown failures
2289         https://bugs.webkit.org/show_bug.cgi?id=31091
2290
2291         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
2292
2293 2009-11-04  Adam Roben  <aroben@apple.com>
2294
2295         Remove bogus else clause in bugzilla-tool
2296
2297         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
2298         create-bug raises exception after entering bug description
2299
2300         Reviewed by David Kilzer.
2301
2302         * Scripts/bugzilla-tool:
2303         (CreateBug): else clauses are only hit if no exception is raised, so
2304         it makes no sense to try to re-raise the exception in an else clause.
2305         The exception will automatically be re-raised if it doesn't match any
2306         of the except clauses, so we don't have to do anything special here at
2307         all to get the desired behavior.
2308
2309 2009-11-04  Eric Seidel  <eric@webkit.org>
2310
2311         Reviewed by David Kilzer.
2312
2313         svn-apply's fixChangeLogPatch function seems broken
2314         https://bugs.webkit.org/show_bug.cgi?id=30683
2315
2316         Update fixChangeLogPatch to be able to handle patches which
2317         don't start at line 1.
2318         Add unit tests for svn-apply to scm_unittest.py.
2319
2320         * Scripts/VCSUtils.pm:
2321         * Scripts/modules/scm_unittest.py:
2322
2323 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
2324
2325         Reviewed by Beth Dakin.
2326
2327         Need to implement ARIA role="combobox"
2328         https://bugs.webkit.org/show_bug.cgi?id=31096
2329
2330         * DumpRenderTree/AccessibilityUIElement.cpp:
2331         (showMenuCallback):
2332         (getIsExpandedCallback):
2333         (AccessibilityUIElement::getJSClass):
2334         * DumpRenderTree/AccessibilityUIElement.h:
2335         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2336         (AccessibilityUIElement::isExpanded):
2337         (AccessibilityUIElement::showMenu):
2338         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2339         (AccessibilityUIElement::isExpanded):
2340         (AccessibilityUIElement::showMenu):
2341         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2342         (AccessibilityUIElement::isSelected):
2343         (AccessibilityUIElement::isExpanded):
2344         (AccessibilityUIElement::showMenu):
2345
2346 2009-11-04  Eric Seidel  <eric@webkit.org>
2347
2348         Reviewed by Adam Barth.
2349
2350         commit-queue is crashing when trying to reject patches after unknown failures
2351         https://bugs.webkit.org/show_bug.cgi?id=31091
2352
2353         * Scripts/bugzilla-tool:
2354          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
2355            so we have to find out what the current patch is by asking bugzilla again.
2356          - Discovered that this code was also leaking file descriptors, so fixed that.
2357
2358 2009-11-04  Adam Roben  <aroben@apple.com>
2359
2360         Make run-webkit-tests work for the Debug_Internal Windows
2361         configuration
2362
2363         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2364         suffix.
2365
2366         Fixes <http://webkit.org/b/31123>.
2367
2368         Reviewed by Sam Weinig.
2369
2370         * Scripts/run-webkit-tests: Don't add the _debug suffix in
2371         Debug_Internal, either.
2372
2373 2009-11-04  Eric Seidel  <eric@webkit.org>
2374
2375         Reviewed by Adam Barth.
2376
2377         committers.py needs a way to store non-bugzilla email addresses
2378         https://bugs.webkit.org/show_bug.cgi?id=31037
2379
2380         Make Committer and Reviewer constructors take a single email or a list of emails.
2381         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2382         Expose reviewers(), used by validate-committer-lists on bug 30970.
2383
2384         * Scripts/modules/committers.py:
2385         * Scripts/modules/committers_unittest.py: Added tests for the new code.
2386
2387 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2388
2389         Reviewed by David Levin.
2390
2391         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2392         https://bugs.webkit.org/show_bug.cgi?id=27491
2393
2394         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2395         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2396
2397         Functions to start or stop Web Socket servers are added.
2398
2399         * Scripts/run-webkit-tests:
2400
2401 2009-11-03  Eric Seidel  <eric@webkit.org>
2402
2403         No review, just changing wording of log message.
2404
2405         Change log string to say "failed" instead of "rejected"
2406         when a commit fails due to an out of date checkout.
2407         This makes grepping the commit-queue log for rejected patches easier.
2408
2409         * Scripts/bugzilla-tool:
2410
2411 2009-11-03  Eric Seidel  <eric@webkit.org>
2412
2413         No review, adding commonly known committers missing from the file.
2414
2415         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2416
2417 2009-11-03  Eric Seidel  <eric@webkit.org>
2418
2419         No review, just sort-order cleanup.
2420
2421         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2422
2423 2009-11-03  Stephen White  <senorblanco@chromium.org>
2424
2425         (Unreviewed).
2426
2427         Add myself to committers.py.
2428
2429         * Scripts/modules/committers.py:
2430
2431 2009-11-03  Robin Dunn  <robin@alldunn.com>
2432
2433         Reviewed by Kevin Ollviier.
2434
2435         Add packaging scripts for Debian-based Linux distros.
2436         
2437         https://bugs.webkit.org/show_bug.cgi?id=31075
2438
2439         * wx/packaging/build-debian-installer.py: Added.
2440         * wx/packaging/debian: Added.
2441
2442 2009-11-03  Dan Bernstein  <mitz@apple.com>
2443
2444         Reviewed by Anders Carlsson and Beth Dakin.
2445
2446         https://bugs.webkit.org/show_bug.cgi?id=31070
2447
2448         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2449         destroyed, it executes the value of the 'ondestroy' parameter as a
2450         script.
2451
2452         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2453         (pluginAllocate): Initialize onDestroy.
2454         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2455         onDestroy.
2456         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2457         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2458         specified.
2459         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2460
2461 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2462
2463         Reviewed by Xan Lopez.
2464
2465         https://bugs.webkit.org/show_bug.cgi?id=31035
2466         [GTK] some accessibility tests hitting assertion in debug builds
2467
2468         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2469
2470         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2471         (AccessibilityController::rootElement):
2472
2473 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2474
2475         Reviewed by Beth Dakin.
2476
2477         Support ARIA "tab" roles
2478         https://bugs.webkit.org/show_bug.cgi?id=30842
2479
2480         * DumpRenderTree/AccessibilityUIElement.cpp:
2481         * DumpRenderTree/AccessibilityUIElement.h:
2482         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2483         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2484         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2485
2486 2009-11-01  Eric Seidel  <eric@webkit.org>
2487
2488         Reviewed by David Levin.
2489
2490         buildbots should use --exit-after-N-failures
2491         https://bugs.webkit.org/show_bug.cgi?id=30809
2492
2493         Make the bots exit after 20 failures to prevent never-ending
2494         test runs where every test spends a minute crashing.
2495
2496         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2497
2498 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2499
2500         Reviewed by Eric Seidel.
2501
2502         Turn on warnings for QtWebKit for gcc
2503         https://bugs.webkit.org/show_bug.cgi?id=30958
2504
2505         * DumpRenderTree/qt/main.cpp: 
2506         (crashHandler): Mark function NO_RETURN
2507
2508 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2509
2510         Adding myself to the committers list.
2511
2512         * Scripts/modules/committers.py:
2513
2514 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2515
2516         Fix an issue that Adam noticed in DRT.
2517
2518         Reviewed by Darin Adler.
2519
2520         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2521         (AccessibilityUIElement::role):
2522         Get the length of the role text, and create a buffer dynamically.
2523
2524 2009-10-30  Eric Seidel  <eric@webkit.org>
2525
2526         No review, rolling out r50105.
2527         http://trac.webkit.org/changeset/50105
2528
2529         This commit was causing:
2530         https://bugs.webkit.org/show_bug.cgi?id=30869
2531         We'll re-implement the feature a different way.
2532
2533         * Scripts/bugzilla-tool:
2534
2535 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2536
2537         Test for MSAA: Accessibility of headings is not correct
2538
2539         https://bugs.webkit.org/show_bug.cgi?id=30937
2540
2541         Reviewed by Adam Roben.
2542
2543         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2544         (AccessibilityUIElement::role):
2545         Allow the role returned to be a BSTR.
2546         (AccessibilityUIElement::description):
2547         Fix a copy/paste error.
2548
2549 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2550
2551         Test for MSAA: Accessibility of links is wrong
2552
2553         https://bugs.webkit.org/show_bug.cgi?id=30928
2554
2555         Reviewed by Darin Adler.
2556
2557         * DumpRenderTree/AccessibilityUIElement.cpp:
2558         (getAccessibilityValueCallback):
2559         Return the accessibility value.
2560         (AccessibilityUIElement::getJSClass):
2561         Added "accessibilityValue" value.
2562
2563         * DumpRenderTree/AccessibilityUIElement.h:
2564
2565         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2566         (AccessibilityUIElement::accessibilityValue):
2567         Stubbed.
2568
2569         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2570         (AccessibilityUIElement::accessibilityValue):
2571         Stubbed.
2572
2573         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2574         (AccessibilityUIElement::accessibilityValue):
2575         Get the object's value, and return it as a JS string.
2576
2577 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2578
2579         Fix typo in command name used by wx build system.
2580
2581         * wx/build/build_utils.py:
2582
2583 2009-10-30  Adam Barth  <abarth@webkit.org>
2584
2585         Reviewed by Darin Adler.
2586
2587         Patch v1 is a dumb default name for patches
2588         https://bugs.webkit.org/show_bug.cgi?id=30952
2589
2590         Let's use "Patch" instead.
2591
2592         * Scripts/bugzilla-tool:
2593
2594 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2595
2596         Unreviewed trivial buildfix.
2597
2598         [Qt] Buildfix for r50333.
2599
2600         * DumpRenderTree/qt/DumpRenderTree.pro:
2601
2602 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2603
2604         Reviewed by Holger Freyther.
2605
2606         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2607         https://bugs.webkit.org/show_bug.cgi?id=30953
2608
2609         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2610         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2611         makes qt DRT to share this implementation (as gtk and mac ports do).
2612
2613         * DumpRenderTree/qt/DumpRenderTree.pro:
2614         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2615         * DumpRenderTree/qt/WorkQueue.h: Removed.
2616
2617 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2618
2619         Unreviewed potential buildbot fix.
2620
2621         Second try: Reset page history before running each test.
2622
2623         Apparently the QWebHistory::clear() keeps the current page
2624         in history which is not what we want, so we not additionally
2625         sets the history capacity to 0 (forces removing everything)
2626         and then sets it back to its original value.
2627
2628         * DumpRenderTree/qt/DumpRenderTree.cpp:
2629         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2630
2631 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2632
2633         Unreviewed potential buildbot fix.
2634
2635         Reset page history before running each test.
2636
2637         * DumpRenderTree/qt/DumpRenderTree.cpp:
2638         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2639
2640 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2641
2642         Reviewed by Eric Seidel.
2643
2644         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2645
2646         Bug 28420 -  Implement HTML5 <ruby> rendering
2647         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2648
2649         No new tests (no functional change).
2650
2651         * Scripts/build-webkit:
2652
2653 2009-10-29  Dan Bernstein  <mitz@apple.com>
2654
2655         Reviewed by Mark Rowe.
2656
2657         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2658         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2659         define it.
2660
2661         * Scripts/VCSUtils.pm:
2662         * Scripts/svn-apply:
2663         * Scripts/svn-unapply:
2664
2665 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2666
2667         Reviewed by Gustavo Noronha.
2668
2669         Use the GTK+ main loop instead of rolling our own mini-version of
2670         it.
2671
2672         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2673         (dump):
2674         (runTest):
2675         (webViewLoadFinished):
2676
2677 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2678
2679         Reviewed by Oliver Hunt.
2680
2681         Implement the Qt version of DRT dumpBackForwardList().
2682
2683         * DumpRenderTree/qt/DumpRenderTree.cpp:
2684         (WebCore::dumpHistoryItem):
2685         (WebCore::DumpRenderTree::dumpBackForwardList):
2686
2687 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2688
2689         Reviewed by Adam Roben.
2690
2691         Implement DRT functionality for Qt introduced in
2692         r28690 and r28705.
2693
2694         - Implemented pathToLocalResource which exposes the functionality of
2695         converting a given unix path to the correct location on Windows.
2696         - Implemented a way to remove machine-dependent information from paths
2697         in layout test results.
2698
2699         * DumpRenderTree/qt/DumpRenderTree.cpp:
2700         (WebCore::urlSuitableForTestResult):
2701         (WebCore::WebPage::javaScriptConsoleMessage):
2702         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2703         (LayoutTestController::pathToLocalResource):
2704         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2705
2706 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2707
2708         Adding myself to the committers list.
2709
2710         * Scripts/modules/committers.py:
2711
2712 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2713
2714         Adding myself to the committers list.
2715
2716         * Scripts/modules/committers.py:
2717
2718 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2719
2720         Reviewed by Jan Alonzo.
2721
2722         [GTK] API to start inspector for a WebView
2723         https://bugs.webkit.org/show_bug.cgi?id=22551
2724
2725         Use the new inspector API to implement the LayoutTestController
2726         interfaces used to test the inspector.
2727
2728         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2729         (webInspectorInspectWebView):
2730         (createWebView):
2731         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2732         (LayoutTestController::showWebInspector):
2733         (LayoutTestController::closeWebInspector):
2734         (LayoutTestController::evaluateInWebInspector):
2735
2736 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2737
2738         Reviewed by Eric Seidel.
2739
2740         [Qt] WebFrame::counterValueForElementById must not be exposed
2741         https://bugs.webkit.org/show_bug.cgi?id=30882
2742
2743         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2744         (LayoutTestController::counterValueForElementById):
2745
2746 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2747
2748         Rubberstamped by Oliver Hunt.
2749
2750         Fix the warning:
2751
2752         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2753         declared with attribute warn_unused_result".
2754
2755         by actually checking the result. In the case it is null, an
2756         error has occoured, so treat it as the other fatal errors.
2757
2758         * DumpRenderTree/qt/DumpRenderTree.cpp:
2759         (WebCore::DumpRenderTree::initializeFonts):
2760
2761 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2762
2763         Reviewed by Darin Adler.
2764
2765         Provide a way to get counter values with layoutTestContoller
2766         https://bugs.webkit.org/show_bug.cgi?id=30555
2767
2768         Define layoutTestContoller.counterValueForElementById.
2769
2770         * DumpRenderTree/LayoutTestController.cpp:
2771         (counterValueForElementByIdCallback):
2772         (LayoutTestController::staticFunctions):
2773         * DumpRenderTree/LayoutTestController.h:
2774         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2775         (LayoutTestController::counterValueForElementById):
2776
2777 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2778
2779         Rubberstamped by Oliver Hunt.
2780
2781         Change two methods to be internal for DRT use only.
2782
2783         Part of [Qt] Review all new API in Qt 4.6
2784         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2785
2786         * DumpRenderTree/qt/DumpRenderTree.cpp:
2787         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2788         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2789         (LayoutTestController::whiteListAccessFromOrigin):
2790
2791 2009-10-27  Eric Seidel  <eric@webkit.org>
2792
2793         Reviewed by Adam Barth.
2794
2795         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2796         https://bugs.webkit.org/show_bug.cgi?id=30826
2797
2798         * Scripts/svn-apply:
2799          - Add () around all system() calls.
2800          - Use the correct system() == 0 or die instead of system() or die
2801          - Add descriptive messages to all die statements.
2802
2803 2009-10-27  Steve Block  <steveblock@google.com>
2804
2805         Reviewed by NOBODY.
2806
2807         Adds steveblock@google.com to list of committers.
2808
2809         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2810
2811 2009-10-27  Eric Seidel  <eric@webkit.org>
2812
2813         Reviewed by Adam Barth.
2814
2815         svn-apply can exit(0) even on patch failure
2816         https://bugs.webkit.org/show_bug.cgi?id=29622
2817
2818         * Scripts/svn-apply:
2819          - Add a bunch of "or die" statements, hopefully catching all
2820            possible cases where failure could still exit(0).
2821
2822 2009-10-27  Eric Seidel  <eric@webkit.org>
2823
2824         Reviewed by Adam Barth.
2825
2826         svn-* scripts should share code through VCSUtils.pm
2827         https://bugs.webkit.org/show_bug.cgi?id=30791
2828
2829         Just moving code into a shared location.
2830
2831         * Scripts/VCSUtils.pm:
2832         * Scripts/prepare-ChangeLog:
2833         * Scripts/resolve-ChangeLogs:
2834         * Scripts/svn-apply:
2835         * Scripts/svn-create-patch:
2836         * Scripts/svn-unapply:
2837         * Scripts/update-webkit:
2838
2839 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2840
2841         Suppress a huge number of MSVC warnings when building wxWebKit.
2842
2843         * wx/build/settings.py:
2844
2845 2009-10-26  Eric Seidel  <eric@webkit.org>
2846
2847         No review, just adding Mike Belshe to the committers list.
2848
2849         * Scripts/modules/committers.py:
2850
2851 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2852
2853         Reviewed by Darin Adler.
2854
2855         Make .rc files compile on Windows without depending on MFC headers
2856         https://bugs.webkit.org/show_bug.cgi?id=30750
2857
2858         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2859         windows.h instead of afxres.h because it exists even when MFC is not 
2860         installed, and is all that's needed here.
2861
2862         * FindSafari/FindSafari.rc: Ditto
2863
2864 2009-10-24  Eric Seidel  <eric@webkit.org>
2865
2866         Reviewed by Adam Barth.
2867
2868         bugzilla-tool post-diff should know how to mark commit-queue=?
2869         https://bugs.webkit.org/show_bug.cgi?id=29202
2870
2871         * Scripts/bugzilla-tool:
2872          - Add --commit-queue option to post-diff, post-commits and create-bug.
2873         * Scripts/modules/bugzilla.py:
2874          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2875          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2876
2877 2009-10-23  Eric Seidel  <eric@webkit.org>
2878
2879         Reviewed by Adam Barth.
2880
2881         bugzilla-tool commit-queue does not notice modifications to committers.py
2882         https://bugs.webkit.org/show_bug.cgi?id=30084
2883
2884         * Scripts/bugzilla-tool:
2885          - Make commit-queue re-exec itself instead of using while(1).
2886          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2887          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2888
2889 2009-10-22  Eric Seidel  <eric@webkit.org>
2890
2891         Reviewed by Adam Barth.
2892
2893         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2894         https://bugs.webkit.org/show_bug.cgi?id=30634
2895
2896         * Scripts/bugzilla-tool:
2897          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2898          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2899
2900 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2901
2902         Reviewed by Eric Seidel.
2903
2904         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2905
2906         https://bugs.webkit.org/show_bug.cgi?id=30763
2907
2908         * pywebsocket/mod_pywebsocket/__init__.py:
2909         * pywebsocket/mod_pywebsocket/dispatch.py:
2910         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2911         * pywebsocket/mod_pywebsocket/standalone.py:
2912         * pywebsocket/setup.py:
2913         * pywebsocket/test/test_dispatch.py:
2914
2915 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2916
2917         Reviewed by David Levin.
2918
2919         REGRESSION: 2 failures in run-webkit-unittests
2920         https://bugs.webkit.org/show_bug.cgi?id=30645
2921
2922         * Scripts/modules/cpp_style_unittest.py:
2923         Fixed a few test scenarios which apparently lost some spaces from 
2924         text literals.
2925
2926 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2927
2928         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2929
2930         * Scripts/webkitdirs.pm:
2931
2932 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2933
2934         Reviewed by Darin Adler.
2935
2936         Unification of using null device in perl scripts.
2937         https://bugs.webkit.org/show_bug.cgi?id=30572
2938
2939         * Scripts/VCSUtils.pm:
2940         * Scripts/bisect-builds:
2941         * Scripts/resolve-ChangeLogs:
2942         * Scripts/run-iexploder-tests:
2943         * Scripts/run-jsc:
2944         * Scripts/run-mangleme-tests:
2945         * Scripts/run-webkit-tests:
2946         * Scripts/webkitdirs.pm:
2947         Using File::Spec->devnull() instead of hard coded /dev/null.
2948
2949 2009-10-26  Eric Seidel  <eric@webkit.org>
2950
2951         Reviewed by Holger Freyther.
2952
2953         Reviewers are missing from committers.py
2954         https://bugs.webkit.org/show_bug.cgi?id=30733
2955
2956         * Scripts/modules/committers.py:
2957
2958 2009-10-23  Eric Seidel  <eric@webkit.org>
2959
2960         No review, only adding Alice to the list of reviewers.
2961
2962         * Scripts/modules/committers.py:
2963
2964 2009-10-23  Eric Seidel  <eric@webkit.org>
2965
2966         Reviewed by Eric Carlson.
2967
2968         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2969         https://bugs.webkit.org/show_bug.cgi?id=30700
2970
2971         * DumpRenderTree/mac/DumpRenderTree.mm:
2972         (resetDefaultsToConsistentValues): Update QuickTime version check.
2973
2974 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2975
2976         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2977         character measurement APIs that are private on Tiger.
2978
2979         * wx/build/settings.py:
2980
2981 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2982
2983         Reviewed by NOBODY (build fix).
2984         Build fix following bug #30696.
2985
2986         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2987         (LayoutTestController::evaluateScriptInIsolatedWorld):
2988
2989 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2990
2991         Reviewed by Sam Weinig & Geoff Garen.
2992
2993         https://bugs.webkit.org/show_bug.cgi?id=30696
2994         Enable isolated-worlds tests on mac.
2995
2996         Add private interface for DRT to invoke execution in a given world.
2997
2998         * DumpRenderTree/LayoutTestController.cpp:
2999         (evaluateScriptInIsolatedWorldCallback):
3000         (LayoutTestController::staticFunctions):
3001         * DumpRenderTree/LayoutTestController.h:
3002         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3003         (LayoutTestController::evaluateScriptInIsolatedWorld):
3004         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3005         (LayoutTestController::evaluateScriptInIsolatedWorld):
3006
3007 2009-10-21  Eric Seidel  <eric@webkit.org>
3008
3009         Reviewed by Adam Barth.
3010
3011         bugzilla-tool's "patch failed to download an apply" error should give more information
3012         https://bugs.webkit.org/show_bug.cgi?id=30632
3013
3014         * Scripts/modules/scm.py:
3015          - Use the common run_command method instead of custom POpen code.
3016          - Make run_command know how to take pipes as input.
3017         * Scripts/modules/scm_unittest.py:
3018          - Add new tests to cover change.
3019          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
3020
3021 2009-10-21  Kent Tamura  <tkent@chromium.org>
3022
3023         Unreviewed.  Adding myself to the committers list.
3024
3025         * Scripts/modules/committers.py:
3026
3027 2009-10-21  Robin Dunn  <robin@alldunn.com>
3028
3029         Reviewed by Kevin Ollivier.
3030
3031         Update the Windows installer builder to work with Vista / Win 7 and with git.
3032         
3033         https://bugs.webkit.org/show_bug.cgi?id=30649
3034
3035         * wx/build/build_utils.py:
3036         * wx/packaging/build-mac-installer.py:
3037         * wx/packaging/build-win-installer.py:
3038         * wx/packaging/wxWebKitInstaller.iss.in:
3039
3040 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3041
3042         Reviewed by Gustavo Noronha.
3043
3044         [GTK] Added conditional code to avoid using
3045         gdk_window_get_root_coords if we do not have a gtk+ release newer
3046         than 2.17.3.
3047         https://bugs.webkit.org/show_bug.cgi?id=30636
3048
3049         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3050
3051 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
3052
3053         Reviewed by Eric Seidel.
3054
3055         [Qt] Added dummy implementation for keepWebHistory()
3056         https://bugs.webkit.org/show_bug.cgi?id=30592
3057
3058         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3059         (LayoutTestController::keepWebHistory):
3060         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3061
3062 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3063
3064         Reviewed by Xan Lopez.
3065
3066         [GTK] Fixed the double click condition, it is not double click if
3067         we move in just in one direction.
3068         https://bugs.webkit.org/show_bug.cgi?id=30636
3069
3070         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3071
3072 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3073
3074         Reviewed by Xan Lopez.
3075
3076         [GTK] Initialize the events completly before emitting them.
3077         https://bugs.webkit.org/show_bug.cgi?id=30633
3078
3079         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3080
3081 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3082
3083         wx build fix. Fix for when linking using --as-needed with gcc.
3084
3085         * wx/browser/wscript:
3086
3087 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3088
3089         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
3090         to support all the features used by CURL backend.
3091         
3092         * wx/build/settings.py:
3093         * wx/install-unix-extras:
3094
3095 2009-10-20  Anton Muhin  <antonm@chromium.org>
3096
3097         Reviewed by Adam Barth.
3098
3099         Add {ager,antonm,yurys}@chromium.org into committers.py
3100         https://bugs.webkit.org/show_bug.cgi?id=30560
3101
3102         * Scripts/modules/committers.py:
3103
3104 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3105
3106         Reviewed by Tor Arne Vestbø.
3107
3108         Make the Netscape Test plugin available to the Qt launcher.
3109
3110         * Scripts/run-launcher:
3111
3112 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
3113
3114         Reviewed by David Levin.
3115
3116         Removed WebSocket runtime settings.
3117         https://bugs.webkit.org/show_bug.cgi?id=29896
3118
3119         WebSocket runtime configuration is supported by chromium/v8 only.
3120
3121         * DumpRenderTree/mac/DumpRenderTree.mm:
3122         (resetDefaultsToConsistentValues):
3123         * DumpRenderTree/win/DumpRenderTree.cpp:
3124         (resetDefaultsToConsistentValues):
3125
3126 2009-10-19  Nate Chapin  <japhet@chromium.org>
3127
3128         Reviewed by Adam Barth.
3129
3130         Add testFail() to test plugin so we can test our handling of a
3131         plugin invoke call returning false.
3132
3133         https://bugs.webkit.org/show_bug.cgi?id=30239
3134
3135         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
3136         (pluginInvoke):
3137         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
3138
3139 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
3140
3141         Reviewed by Gustavo Noronha.
3142
3143         Enable DOM pasting when running layout tests.
3144
3145         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3146         (resetDefaultsToConsistentValues):
3147
3148 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3149
3150         Reviewed by Simon Hausmann.
3151
3152         Use the setPreferredContentsSize method instead
3153         of setFixedContentsSize, as the method has been renamed.
3154
3155         * DumpRenderTree/qt/DumpRenderTree.cpp:
3156         (WebCore::DumpRenderTree::open):
3157         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3158         (LayoutTestController::setFixedContentsSize):
3159
3160 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3161
3162         Reviewed by Dan Bernstein.
3163
3164         https://bugs.webkit.org/show_bug.cgi?id=30456
3165         Fixes for new Debug_All Windows build configuration.
3166
3167         * DumpRenderTree/win/DumpRenderTree.cpp:
3168         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
3169         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
3170
3171 2009-10-16  Eric Seidel  <eric@webkit.org>
3172
3173         Reviewed by Adam Barth.
3174
3175         commit-queue status bot should list which buildbot is blocking the queue
3176         https://bugs.webkit.org/show_bug.cgi?id=30452
3177
3178         Add new methods and testing.
3179
3180         * Scripts/bugzilla-tool:
3181         * Scripts/modules/buildbot.py:
3182         * Scripts/modules/buildbot_unittest.py:
3183
3184 2009-10-16  Eric Seidel  <eric@webkit.org>
3185
3186         Reviewed by Adam Barth.
3187
3188         run-webkit-tests fails when CWD is not inside a WebKit checkout
3189         https://bugs.webkit.org/show_bug.cgi?id=30451
3190
3191         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
3192         * Scripts/modules/scm_unittest.py:
3193           - Remove use of original_path (we don't need to restore the CWD).
3194           - Don't use '.' to find the webkit checkout, use __file__ instead.
3195
3196 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3197
3198         Reviewed by Adam Roben.
3199
3200         Add a Debug_All configuration to build entire stack as debug.
3201         Change Debug_Internal to:
3202         - stop using _debug suffix for all WebKit/Safari binaries
3203         - not use _debug as a DLL naming suffix
3204         - use non-debug C runtime lib.
3205
3206         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
3207         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
3208         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
3209         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3210         Add missing debug.vsprops inherited property sheet.
3211         Add Debug_All configuration.
3212         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
3213         * WinLauncher/WinLauncher.vcproj:
3214         Removed extraneous definitions inherited from vsprops.
3215         Add Debug_All configuration.
3216
3217 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
3218
3219         Reviewed by David Levin.
3220
3221         check-webkit-style is wrong about indent checking in namespaces
3222         in header files and a few other things
3223         https://bugs.webkit.org/show_bug.cgi?id=30362
3224
3225         The few other things include:
3226         + check-webkit-style does not require spaces around the equal sign
3227           inside 'if' statements and around binary operators that take 
3228           numeric literals.
3229         + check-webkit-style reports false errors for the / operator
3230           when part of a filename in the #include directive.
3231
3232         * Scripts/modules/cpp_style.py:
3233         Improved indentation checking and space checking around
3234         binary operators. While the checks are still not perfect,
3235         they are clearly better than before.
3236         * Scripts/modules/cpp_style_unittest.py:
3237         Added test cases for the newly supported checks and modified old
3238         test cases to match the new guidelines
3239
3240 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
3241
3242         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
3243
3244         * wx/build/settings.py:
3245
3246 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
3247
3248         Reviewed by David Levin.
3249
3250         Add mod_pywebsocket to test Web Sockets.
3251         http://code.google.com/p/pywebsocket/
3252         https://bugs.webkit.org/show_bug.cgi?id=27490
3253
3254         * pywebsocket/COPYING: Added.
3255         * pywebsocket/MANIFEST.in: Added.
3256         * pywebsocket/README: Added.
3257         * pywebsocket/example/echo_client.py: Added.
3258         * pywebsocket/example/echo_wsh.py: Added.
3259         * pywebsocket/mod_pywebsocket/__init__.py: Added.
3260         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
3261         * pywebsocket/mod_pywebsocket/handshake.py: Added.
3262         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
3263         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
3264         * pywebsocket/mod_pywebsocket/standalone.py: Added.
3265         * pywebsocket/mod_pywebsocket/util.py: Added.
3266         * pywebsocket/setup.py: Added.
3267         * pywebsocket/test/config.py: Added.
3268         * pywebsocket/test/mock.py: Added.
3269         * pywebsocket/test/run_all.py: Added.
3270         * pywebsocket/test/test_dispatch.py: Added.
3271         * pywebsocket/test/test_handshake.py: Added.
3272         * pywebsocket/test/test_mock.py: Added.
3273         * pywebsocket/test/test_msgutil.py: Added.
3274         * pywebsocket/test/test_util.py: Added.
3275         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
3276         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
3277         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
3278         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
3279         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
3280         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
3281         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
3282         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
3283
3284 2009-10-15  James Robinson  <jamesr@google.com>
3285
3286         Reviewed by David Levin.
3287
3288         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
3289
3290         https://bugs.webkit.org/show_bug.cgi?id=30426
3291
3292         * Scripts/modules/cpp_style.py:
3293         * Scripts/modules/cpp_style_unittest.py:
3294
3295 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
3296
3297         Reviewed by Adam Roben.
3298
3299         Fixes <http://webkit.org/b/30411>.
3300         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
3301         
3302         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
3303         building Chromium.
3304
3305         * Scripts/pdevenv:
3306
3307 2009-10-15  Robin Dunn  <robin@alldunn.com>
3308
3309         Reviewed by Kevin Ollivier.
3310
3311         Add Mac package building scripts for wx.
3312         
3313         https://bugs.webkit.org/show_bug.cgi?id=30405
3314
3315         * wx/build/build_utils.py:
3316         * wx/build/settings.py:
3317         * wx/packaging/build-mac-installer.py: Added.
3318
3319 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
3320
3321         Reviewed by Gustavo Noronha.
3322
3323         Enable Web Sockets support when running layout tests.
3324
3325         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3326         (resetDefaultsToConsistentValues):
3327
3328 2009-10-15  Xan Lopez  <xlopez@igalia.com>
3329
3330         Reviewed by Gustavo Noronha.
3331
3332         Need to initialize event.button.button, since in most cases a
3333         button number is not passed as an argument.
3334
3335         * DumpRenderTree/gtk/EventSender.cpp:
3336         (mouseDownCallback):
3337         (mouseUpCallback):
3338
3339 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
3340
3341         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3342         the OS if none was explicitly set.
3343
3344         * wx/build/settings.py:
3345
3346 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
3347
3348         Reviewed by Timothy Hatcher.
3349
3350         Web Inspector: enable developers extras within inspector layout tests.
3351
3352         https://bugs.webkit.org/show_bug.cgi?id=30014
3353
3354         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3355         (LayoutTestController::showWebInspector):
3356         (LayoutTestController::closeWebInspector):
3357         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3358         (LayoutTestController::showWebInspector):
3359         (LayoutTestController::closeWebInspector):
3360
3361 2009-10-14  José Millán Soto  <jmillan@igalia.com>
3362
3363         Reviewed by Jan Alonzo.
3364
3365         GtkLauncher is using a deprecated signal
3366         https://bugs.webkit.org/show_bug.cgi?id=30364
3367
3368         Modified GtkLauncher to use notify::title signal instead of
3369         deprecated title-changed signal
3370
3371         * GtkLauncher/main.c:
3372         (notify_title_cb):
3373         (create_browser):
3374
3375 2009-10-14  Brady Eidson  <beidson@apple.com>
3376
3377         Reviewed by Sam Weinig.
3378
3379         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
3380         1 - Disables WebHistory
3381         2 - Doesn't make sense in that context anyway.
3382
3383         * DumpRenderTree/win/DumpRenderTree.cpp:
3384         (createWebViewAndOffscreenWindow):
3385
3386 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
3387
3388         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3389         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3390
3391         * wx/build/settings.py:
3392         * wx/install-unix-extras:
3393
3394 2009-10-14  Brady Eidson  <beidson@apple.com>
3395
3396         Reviewed by Sam Weinig.
3397
3398         WebKit Win API should provide a delegate interface for global history.
3399         https://bugs.webkit.org/show_bug.cgi?id=29905
3400
3401         * DumpRenderTree/LayoutTestController.cpp:
3402         (LayoutTestController::LayoutTestController):
3403         * DumpRenderTree/LayoutTestController.h:
3404         (LayoutTestController::dumpHistoryDelegateCallbacks):
3405         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3406                 
3407         * DumpRenderTree/win/DumpRenderTree.cpp:
3408         (shouldLogHistoryDelegates):
3409         (runTest):
3410         (createWebViewAndOffscreenWindow):
3411         (main):
3412         * DumpRenderTree/win/DumpRenderTree.vcproj:
3413         
3414         Add the IWebHistoryDelegate to DRT Windows:
3415         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3416         (wstringFromBSTR):
3417         (HistoryDelegate::HistoryDelegate):
3418         (HistoryDelegate::~HistoryDelegate):
3419         (HistoryDelegate::QueryInterface):
3420         (HistoryDelegate::AddRef):
3421         (HistoryDelegate::Release):
3422         (HistoryDelegate::didNavigateWithNavigationData):
3423         (HistoryDelegate::didPerformClientRedirectFromURL):
3424         (HistoryDelegate::didPerformServerRedirectFromURL):
3425         (HistoryDelegate::updateHistoryTitle):
3426         (HistoryDelegate::populateVisitedLinksForWebView):
3427         * DumpRenderTree/win/HistoryDelegate.h: Added.
3428
3429         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3430         (LayoutTestController::removeAllVisitedLinks):
3431
3432 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3433
3434         Reviewed by Simon Hausmann.
3435
3436         [Qt] Implement support for setPOSIXLocale on Qt.
3437         https://bugs.webkit.org/show_bug.cgi?id=30268 
3438  
3439         * DumpRenderTree/qt/DumpRenderTree.cpp:
3440         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3441         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3442         (LayoutTestController::setPOSIXLocale):
3443         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3444
3445 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3446
3447         Unreviewed, adding myself to reviewers list.
3448
3449         * Scripts/modules/committers.py:
3450
3451 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3452
3453         Reviewed by Mark Rowe.
3454
3455         Fix null assignment so root tests work again.
3456
3457         * Scripts/webkitdirs.pm:
3458
3459 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3460
3461         Reviewed by Simon Hausmann.
3462
3463         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3464         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3465         This is done in preparation of implementing missing features in DRT.
3466         No functionality changes made yet.
3467
3468         * DumpRenderTree/qt/DumpRenderTree.cpp:
3469         * DumpRenderTree/qt/DumpRenderTree.pro:
3470         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3471         (EventSender::EventSender):
3472         (EventSender::mouseDown):
3473         (EventSender::mouseUp):
3474         (EventSender::mouseMoveTo):
3475         (EventSender::leapForward):
3476         (EventSender::keyDown):
3477         (EventSender::contextClick):
3478         (EventSender::scheduleAsynchronousClick):
3479         (EventSender::frameUnderMouse):
3480         * DumpRenderTree/qt/EventSenderQt.h: Added.
3481         (EventSender::clearKillRing):
3482         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3483         (LayoutTestController::LayoutTestController):
3484         (LayoutTestController::reset):
3485         (LayoutTestController::processWork):
3486         (LayoutTestController::maybeDump):
3487         (LayoutTestController::waitUntilDone):
3488         (LayoutTestController::notifyDone):
3489         (LayoutTestController::windowCount):
3490         (LayoutTestController::clearBackForwardList):
3491         (LayoutTestController::dumpEditingCallbacks):
3492         (LayoutTestController::dumpResourceLoadCallbacks):
3493         (LayoutTestController::queueBackNavigation):
3494         (LayoutTestController::queueForwardNavigation):
3495         (LayoutTestController::queueLoad):
3496         (LayoutTestController::queueReload):
3497         (LayoutTestController::queueScript):
3498         (LayoutTestController::provisionalLoad):
3499         (LayoutTestController::timerEvent):
3500         (LayoutTestController::encodeHostName):
3501         (LayoutTestController::decodeHostName):
3502         (LayoutTestController::setJavaScriptProfilingEnabled):
3503         (LayoutTestController::setFixedContentsSize):
3504         (LayoutTestController::setPrivateBrowsingEnabled):
3505         (LayoutTestController::setPopupBlockingEnabled):
3506         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3507         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3508         (LayoutTestController::numberOfActiveAnimations):
3509         (LayoutTestController::disableImageLoading):
3510         (LayoutTestController::dispatchPendingLoadRequests):
3511         (LayoutTestController::setDatabaseQuota):
3512         (LayoutTestController::clearAllDatabases):
3513         (LayoutTestController::whiteListAccessFromOrigin):
3514         (LayoutTestController::waitForPolicyDelegate):
3515         (LayoutTestController::overridePreference):
3516         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3517         (LayoutTestController::isLoading):
3518         (LayoutTestController::setLoading):
3519         (LayoutTestController::shouldDumpAsText):
3520         (LayoutTestController::shouldDumpBackForwardList):
3521         (LayoutTestController::shouldDumpChildrenAsText):
3522         (LayoutTestController::shouldDumpDatabaseCallbacks):
3523         (LayoutTestController::shouldDumpStatusCallbacks):
3524         (LayoutTestController::shouldWaitUntilDone):
3525         (LayoutTestController::canOpenWindows):
3526         (LayoutTestController::shouldDumpTitleChanges):
3527         (LayoutTestController::waitForPolicy):
3528         (LayoutTestController::dumpAsText):
3529         (LayoutTestController::dumpChildFramesAsText):
3530         (LayoutTestController::dumpDatabaseCallbacks):
3531         (LayoutTestController::dumpStatusCallbacks):
3532         (LayoutTestController::setCanOpenWindows):
3533         (LayoutTestController::dumpBackForwardList):
3534         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3535         (LayoutTestController::display):
3536         (LayoutTestController::dumpTitleChanges):
3537         (LayoutTestController::dumpSelectionRect):
3538         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3539         (TextInputController::TextInputController):
3540         (TextInputController::doCommand):
3541         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3542         * DumpRenderTree/qt/WorkQueue.cpp:
3543         * DumpRenderTree/qt/WorkQueue.h:
3544         * DumpRenderTree/qt/WorkQueueItem.h:
3545         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3546         (findFrameNamed):
3547         (LoadItem::invoke):
3548         (ReloadItem::invoke):
3549         (ScriptItem::invoke):
3550         (BackForwardItem::invoke):
3551         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3552         * DumpRenderTree/qt/jsobjects.h:
3553
3554 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3555
3556         Not reviewed, adding myself to the list of reviewers.
3557
3558         * Scripts/modules/committers.py:
3559
3560 2009-10-13  Anders Carlsson  <andersca@apple.com>
3561
3562         Reviewed by Sam Weinig.
3563
3564         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3565
3566         Make the private browsing mode testable by the test plug-in.
3567         
3568         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3569         (pluginGetProperty):
3570         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3571         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3572         (NPP_New):
3573         (NPP_SetValue):
3574
3575 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3576
3577         No review, just adding self to the list of reviewers.
3578
3579         * Scripts/modules/committers.py:
3580
3581 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3582
3583         Reviewed by Adam Roben.
3584
3585         Web Inspector: Use proper web view in inspector layout
3586         tests for windows.
3587
3588         https://bugs.webkit.org/show_bug.cgi?id=30298
3589
3590         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3591         (LayoutTestController::showWebInspector):
3592         (LayoutTestController::closeWebInspector):
3593         (LayoutTestController::evaluateInWebInspector):
3594
3595 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3596
3597         Reviewed by Sam Weinig.
3598
3599         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3600         https://bugs.webkit.org/show_bug.cgi?id=29841
3601
3602         * DumpRenderTree/mac/DumpRenderTree.mm:
3603         (resetDefaultsToConsistentValues):
3604         * DumpRenderTree/win/DumpRenderTree.cpp:
3605         (resetDefaultsToConsistentValues):
3606
3607 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3608
3609         Reviewed by Dimitri Glazkov.
3610
3611         Chromium Port - Windows
3612         https://bugs.webkit.org/show_bug.cgi?id=29969
3613
3614         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3615         * Scripts/webkitdirs.pm:
3616
3617 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3618
3619         Reviewed by Darin Adler.
3620
3621         jsc scripts cleanup and Qt/GTK fix
3622         https://bugs.webkit.org/show_bug.cgi?id=30288
3623
3624         Duplicated jscPath() moved to webkitdirs.pm.
3625         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3626         Configuration added (release/debug) to path for Qt-port on Windows.
3627
3628         * Scripts/run-javascriptcore-tests:
3629         * Scripts/run-jsc:
3630         * Scripts/run-sunspider:
3631         * Scripts/sunspider-compare-results:
3632         * Scripts/webkitdirs.pm:
3633
3634 2009-10-11  Adam Barth  <abarth@webkit.org>
3635
3636         Unreviewed.  Add Collin to committers.py.
3637
3638         * Scripts/modules/committers.py:
3639
3640 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3641
3642         wx build fix, add bindings to source/include dirs now that there are sources there.
3643
3644         * wx/build/settings.py:
3645
3646 2009-10-09  Mark Rowe  <mrowe@apple.com>
3647
3648         Reviewed by Brady Eidson.
3649
3650         Enable plug-in halting in DumpRenderTree.
3651
3652         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3653         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3654
3655         * DumpRenderTree/mac/DumpRenderTree.mm:
3656         (resetDefaultsToConsistentValues):
3657         * DumpRenderTree/mac/UIDelegate.mm:
3658         (-[UIDelegate webView:shouldHaltPlugin:]):
3659
3660 2009-10-08  Brady Eidson  <beidson@apple.com>
3661
3662         Reviewed by Dan Bernstein.
3663
3664         Ask the History Delegate to populate the visited links hash.
3665         <rdar://problem/7285293> and https://webkit.org/b/29904
3666
3667         Add the ability for LayoutTestController to clear all visited links.
3668         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3669
3670         * DumpRenderTree/LayoutTestController.cpp:
3671         (LayoutTestController::LayoutTestController):
3672         (removeAllVisitedLinksCallback):
3673         (LayoutTestController::staticFunctions):
3674         * DumpRenderTree/LayoutTestController.h:
3675         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3676         (LayoutTestController::removeAllVisitedLinks):
3677
3678         * DumpRenderTree/mac/HistoryDelegate.mm:
3679         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3680
3681         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3682         (LayoutTestController::removeAllVisitedLinks):
3683         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3684         (LayoutTestController::removeAllVisitedLinks):
3685         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3686         (LayoutTestController::removeAllVisitedLinks):