2009-11-19 Eric Seidel <eric@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-19  Eric Seidel  <eric@webkit.org>
2
3         Reviewed by Darin Adler.
4
5         bugzilla-tool's reviewer/committer rejection message should be clearer
6         https://bugs.webkit.org/show_bug.cgi?id=31126
7
8         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
9
10         * Scripts/modules/bugzilla.py:
11
12 2009-11-19  Eric Z. Ayers  <zundel@google.com>
13
14         Reviewed by Pavel Feldman.
15
16         Forces a WM_PAINT event on calling layoutTestController.display()
17         in order to enable the timeline-paint.html test on Windows.
18         ::UpdateWindow() does not force an event becaue the window is 
19         not visible.
20
21         https://bugs.webkit.org/show_bug.cgi?id=31402
22
23         * DumpRenderTree/win/DumpRenderTree.cpp:
24         (displayWebView):
25
26 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
27
28         No review needed.
29
30         Added myself to committers list.
31
32         * Scripts/modules/committers.py:
33
34 2009-11-19  Adam Barth  <abarth@webkit.org>
35
36         Reviewed by Eric Seidel.
37
38         Bugzilla-tool command classes should match command names
39         https://bugs.webkit.org/show_bug.cgi?id=31666
40
41         I renamed all the commands except CommitMessageForCurrentDiff because
42         the new name would conflict with an existing class.
43
44         * Scripts/bugzilla-tool:
45
46 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
47
48         Reviewed by Gustavo Noronha Silva.
49
50         Web Inspector: Implement "show inspector" in WebKit GTK
51         API and enable console tests.
52
53         https://bugs.webkit.org/show_bug.cgi?id=31669
54
55         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
56         (LayoutTestController::showWebInspector):
57
58 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
59
60         Reviewed by Simon Hausmann.
61
62         Minor refactoring + more documentation.
63
64         * DumpRenderTree/qt/DumpRenderTree.cpp:
65         (WebCore::clearHistory):
66         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
67
68 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
69
70         Reviewed by Eric Seidel.
71
72         Ignore websocket tests when --no-http is specified.
73         https://bugs.webkit.org/show_bug.cgi?id=31662
74
75         * Scripts/run-webkit-tests:
76
77 2009-11-18  Adam Barth  <abarth@webkit.org>
78
79         Reviewed by Eric Seidel.
80
81         Normalize ' and " in bugzilla-tool
82         https://bugs.webkit.org/show_bug.cgi?id=31655
83
84         We decided " is better than ' and we should be consistent.
85
86         * Scripts/bugzilla-tool:
87
88 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
89
90         Reviewed by Kenneth Rohde Christiansen.
91
92         [Qt] Remove support for Qt v4.3 or older versions
93         https://bugs.webkit.org/show_bug.cgi?id=29469
94
95         * DumpRenderTree/qt/DumpRenderTree.pro:
96         * DumpRenderTree/qt/ImageDiff.pro:
97
98 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
99
100         Reviewed by Eric Seidel.
101
102         GitTest.test_create_binary_patch fails if /tmp is symlink
103         https://bugs.webkit.org/show_bug.cgi?id=31536
104
105         * Scripts/modules/scm_unittest.py:
106
107 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
108
109         Reviewed by Darin Adler.
110
111         Configuration for Chromium Build Slaves.
112
113         https://bugs.webkit.org/show_bug.cgi?id=31442
114
115         * BuildSlaveSupport/build.webkit.org-config/config.json:
116         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
117
118 2009-11-18  Eric Seidel  <eric@webkit.org>
119
120         Reviewed by Darin Adler.
121
122         workqueue.py results in totally broken commit-queue UI
123         https://bugs.webkit.org/show_bug.cgi?id=31645
124
125         * Scripts/bugzilla-tool:
126          - Remove unneeded use of PatchCollection.
127          - Grab a new copy of the cq'd patches every run of the queue.
128
129 2009-11-18  Sam Weinig  <sam@webkit.org>
130
131         Reviewed by Anders Carlsson.
132
133         Make the Mac Geolocation API async.
134
135         Update DRT to use the new async Mac Geolocation API.
136
137         * DumpRenderTree/mac/UIDelegate.mm:
138         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
139
140 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
141
142         Reviewed by Kenneth Rohde Christiansen.
143
144         Add and option to toggle HTML5 datalist support to build-webkit
145         https://bugs.webkit.org/show_bug.cgi?id=31599
146
147         * Scripts/build-webkit:
148
149 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
150
151         Reviewed by Kevin Ollivier.
152
153         Enable wx plugin support using the Windows implementation as a base.
154         
155         https://bugs.webkit.org/show_bug.cgi?id=31636
156
157         * wx/build/settings.py:
158
159 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
160
161         Reviewed by Simon Hausmann.
162
163         Change the initialization order so that the controllers
164         will be created before exporting them to the JS DOM window.
165
166         * DumpRenderTree/qt/DumpRenderTree.cpp:
167         (WebCore::DumpRenderTree::DumpRenderTree):
168
169 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
170
171         Reviewed by Simon Hausmann.
172
173         Fix a code copy and paste error. m_page should be page.
174
175         * DumpRenderTree/qt/DumpRenderTree.cpp:
176         (WebCore::DumpRenderTree::createWindow):
177
178 2009-11-17  Mark Rowe  <mrowe@apple.com>
179
180         Reviewed by Alexey Proskuryakov.
181
182         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
183
184         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
185         This prevents symlinks from confusing the descendant check.
186
187 2009-11-17  Mark Rowe  <mrowe@apple.com>
188
189         Reviewed by Alexey Proskuryakov.
190
191         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
192
193         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
194         server to be up rather than having run-webkit-tests abort immediately.
195
196         * Scripts/run-webkit-tests:
197
198 2009-11-17  Eric Seidel  <eric@webkit.org>
199
200         Reviewed by Darin Adler.
201
202         commit-queue is failing to set reviewer in ChangeLogs
203         https://bugs.webkit.org/show_bug.cgi?id=31592
204
205         * Scripts/bugzilla-tool: Clarify the "applying" log message.
206         * Scripts/modules/bugzilla.py:
207          - Add a new _validate_committer_and_reviewer function as a
208            temporary solution until we can make a real Attachment object
209            which knows how to fill in its committer/reviewer fields automatically.
210
211 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
212
213         Unreviewed buildbot fix.
214
215         Revert part of earlier patch and add comment, as it
216         was causing timeouts on the buildbot.
217
218         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
219         (LayoutTestController::notifyDone):
220
221 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
222
223         Reviewed by Oliver Hunt.
224
225         Make the timeout 15 sec as for the other DRT's and make
226         it print out the same output when a test timeout.
227
228         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
229         (LayoutTestController::waitUntilDone):
230         (LayoutTestController::notifyDone):
231         (LayoutTestController::timerEvent):
232
233 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
234
235         Reviewed by Timothy Hatcher.
236
237         Fixed typos in comments.
238
239         * Scripts/modules/committers.py:
240
241 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
242
243         Reviewed by Timothy Hatcher.
244
245         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
246         - Updated DRT to show/close inspector for all tests under /inspector
247         - Introduced LayoutTestController::setTimelineProfilingEnabled and
248           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
249         - Removed reload on each inspector test
250         - Renamed fast/inspector to fast/inspector-support in order not to trigger
251         inspector for those.
252         - Reimplemented timeline tests in order to get rid of reload there.
253         - Moved tests that don't require harness into the fast group.
254
255         https://bugs.webkit.org/show_bug.cgi?id=31472
256
257         * DumpRenderTree/LayoutTestController.cpp:
258         (setTimelineProfilingEnabledCallback):
259         (closeWebInspectorCallback):
260         (LayoutTestController::staticFunctions):
261         * DumpRenderTree/LayoutTestController.h:
262         * DumpRenderTree/gtk/DumpRenderTree.cpp:
263         (shouldOpenWebInspector):
264         (runTest):
265         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
266         (LayoutTestController::setTimelineProfilingEnabled):
267         * DumpRenderTree/mac/DumpRenderTree.mm:
268         (shouldOpenWebInspector):
269         (runTest):
270         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
271         (LayoutTestController::setTimelineProfilingEnabled):
272         * DumpRenderTree/win/DumpRenderTree.cpp:
273         (shouldOpenWebInspector):
274         (runTest):
275         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
276         (LayoutTestController::setTimelineProfilingEnabled):
277
278 2009-11-17  Oliver Hunt  <oliver@apple.com>
279
280         Reviewed by Maciej Stachowiak.
281
282         Incorrect use of JavaScriptCore API in DumpRenderTree
283         https://bugs.webkit.org/show_bug.cgi?id=31577
284
285         Return undefined rather than a literal null.
286
287         * DumpRenderTree/AccessibilityUIElement.cpp:
288         (setSelectedTextRangeCallback):
289         (incrementCallback):
290         (decrementCallback):
291         (showMenuCallback):
292
293 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
294
295         Reviewed by Beth Dakin.
296
297         AX: aria-labelledby duplicates some of its WAI-ARIA label
298         https://bugs.webkit.org/show_bug.cgi?id=31565
299
300         * DumpRenderTree/AccessibilityUIElement.cpp:
301         (titleUIElementCallback):
302         (getIsValidCallback):
303         (AccessibilityUIElement::getJSClass):
304
305 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
306
307         Reviewed by Simon Hausmann.
308
309         r50942 broke output from created windows. Make the
310         m_enableTextOutput a member of the DRT and not the
311         WebPage.
312
313         * DumpRenderTree/qt/DumpRenderTree.cpp:
314         (WebCore::WebPage::WebPage):
315         (WebCore::WebPage::javaScriptAlert):
316         (WebCore::WebPage::javaScriptConsoleMessage):
317         (WebCore::WebPage::javaScriptConfirm):
318         (WebCore::WebPage::javaScriptPrompt):
319         (WebCore::WebPage::acceptNavigationRequest):
320         (WebCore::DumpRenderTree::DumpRenderTree):
321         (WebCore::DumpRenderTree::open):
322         (WebCore::DumpRenderTree::createWindow):
323         * DumpRenderTree/qt/DumpRenderTree.h:
324         (WebCore::DumpRenderTree::setTextOutputEnabled):
325         (WebCore::DumpRenderTree::isTextOutputEnabled):
326         (WebCore::WebPage::shouldInterruptJavaScript):
327         (WebCore::WebPage::isTextOutputEnabled):
328         (WebCore::WebPage::setViewGeometry):
329
330 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
331
332         Reviewed by Gustavo Noronha Silva.
333
334         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
335         as the implementation is being used by at least Qt and Gtk+.
336
337         Update buildsystems as well.
338
339         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
340         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
341         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
342         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
343         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
344         * GNUmakefile.am:
345
346 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
347
348         Reviewed by Alexey Proskuryakov.
349
350         Disable wss until all platforms support pyOpenSSL
351
352         https://bugs.webkit.org/show_bug.cgi?id=31479
353
354         * Scripts/run-webkit-tests:
355
356 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
357
358         Reviewed by Kenneth Christiansen.
359
360         [Qt] Implement load error pages support for Qt's DRT.
361         https://bugs.webkit.org/show_bug.cgi?id=31509
362
363         For now, it will not be a default feature, and layout tests
364         that want to make use of this have to explicitily call
365         'handleErrorPages();' for the test source.
366
367         Any of the other DumpRenderTree's (mac, win and gtk)
368         support handling error pages. Qt's will be the first.
369
370         * DumpRenderTree/qt/DumpRenderTree.cpp:
371         (WebCore::WebPage::supportsExtension):
372         (WebCore::WebPage::extension):
373         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
374         (LayoutTestController::reset):
375         * DumpRenderTree/qt/LayoutTestControllerQt.h:
376         (LayoutTestController::shouldHandleErrorPages):
377         (LayoutTestController::handleErrorPages):
378
379 2009-11-16  Eric Seidel  <eric@webkit.org>
380
381         Reviewed by Adam Barth.
382
383         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
384         https://bugs.webkit.org/show_bug.cgi?id=31549
385
386         Renamed --commit-queue to --non-interactive in most places
387         and remove the code in land-patches which is no longer needed.
388
389         * Scripts/bugzilla-tool:
390
391 2009-11-16  Eric Seidel  <eric@webkit.org>
392
393         Reviewed by Adam Barth.
394
395         The commit-queue should use land-attachment
396         https://bugs.webkit.org/show_bug.cgi?id=31548
397
398         * Scripts/bugzilla-tool:
399
400 2009-11-16  Adam Barth  <abarth@webkit.org>
401
402         Reviewed by Eric Seidel.
403
404         Convert CommitQueue over to PatchCollection
405         https://bugs.webkit.org/show_bug.cgi?id=31547
406
407         Also fixes a bug in workqueue and adds a test!
408
409         * Scripts/bugzilla-tool:
410         * Scripts/modules/workqueue.py:
411         * Scripts/modules/workqueue_unittest.py:
412
413 2009-11-16  Adam Barth  <abarth@webkit.org>
414
415         Reviewed by Eric Seidel.
416
417         Move StyleQueue over to using PatchCollection
418         https://bugs.webkit.org/show_bug.cgi?id=31544
419
420         That's what the class it's for.
421
422         * Scripts/bugzilla-tool:
423         * Scripts/modules/patchcollection.py:
424         * Scripts/modules/patchcollection_unittest.py:
425
426 2009-11-16  Eric Seidel  <eric@webkit.org>
427
428         Reviewed by Adam Barth.
429
430         bugzilla-tool needs a land-attachment command
431         https://bugs.webkit.org/show_bug.cgi?id=31546
432
433         * Scripts/bugzilla-tool:
434          - Move all the logic into AbstractLandingCommand and
435            add a new LandAttachment command subclass.
436          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
437
438 2009-11-16  Eric Seidel  <eric@webkit.org>
439
440         Reviewed by Adam Barth.
441
442         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
443         https://bugs.webkit.org/show_bug.cgi?id=31543
444
445         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
446
447         * Scripts/bugzilla-tool:
448
449 2009-11-16  Eric Seidel  <eric@webkit.org>
450
451         Reviewed by Adam Barth.
452
453         Disable the style queue from posting to the commit queue status page.
454
455         * Scripts/bugzilla-tool:
456
457 2009-11-16  Adam Barth  <abarth@webkit.org>
458
459         Reviewed by Eric Seidel.
460
461         Implement PatchCollection
462         https://bugs.webkit.org/show_bug.cgi?id=31541
463
464         This class holds a set of patches and lets clients iterate through
465         them.  Optionally, clients can install a filter.
466
467         * Scripts/modules/patchcollection.py: Added.
468         * Scripts/modules/patchcollection_unittest.py: Added.
469         * Scripts/run-webkit-unittests:
470
471 2009-11-16  Eric Seidel  <eric@webkit.org>
472
473         Reviewed by Adam Barth.
474
475         bugzilla-tool land-patches will close bugs with patches r=?
476         https://bugs.webkit.org/show_bug.cgi?id=28230
477
478         The commit-queue shouldn't close patches with outstanding reviews on them,
479         even if many reviewers seem to be against multi-patch bugs.
480
481         * Scripts/bugzilla-tool:
482
483 2009-11-16  Eric Seidel  <eric@webkit.org>
484
485         Reviewed by Adam Barth.
486
487         bugzilla-tool check-style should work with attachment ids instead of bug ids
488         https://bugs.webkit.org/show_bug.cgi?id=31540
489
490         * Scripts/bugzilla-tool:
491
492 2009-11-16  Eric Seidel  <eric@webkit.org>
493
494         Reviewed by Adam Barth.
495
496         WorkQueue is the only place that should know about special exit codes
497         https://bugs.webkit.org/show_bug.cgi?id=31534
498
499         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
500         and add tests for handling exit codes.
501         I also cleaned up workqueue_unittest.py more.
502
503         * Scripts/bugzilla-tool:
504         * Scripts/modules/workqueue.py:
505         * Scripts/modules/workqueue_unittest.py:
506
507 2009-11-16  Eric Seidel  <eric@webkit.org>
508
509         Reviewed by Adam Barth.
510
511         Re-factor workqueue_unittest to allow for more than one test.
512         https://bugs.webkit.org/show_bug.cgi?id=31535
513
514         * Scripts/modules/workqueue_unittest.py:
515
516 2009-11-16  Eric Seidel  <eric@webkit.org>
517
518         Reviewed by Adam Barth.
519
520         land-patches needs to be re-factored into smaller chunks
521         https://bugs.webkit.org/show_bug.cgi?id=31532
522
523         * Scripts/bugzilla-tool: fix a couple obvious typos.
524
525 2009-11-16  Eric Seidel  <eric@webkit.org>
526
527         Reviewed by Adam Barth.
528
529         land-patches needs to be re-factored into smaller chunks
530         https://bugs.webkit.org/show_bug.cgi?id=31532
531
532         The next patch will move these methods into WebKitLandingScripts.
533
534         * Scripts/bugzilla-tool:
535          - Split out _land_patch and _close_bug_if_no_active_patches.
536
537 2009-11-16  Adam Barth  <abarth@webkit.org>
538
539         Reviewed by Eric Seidel.
540
541         Fix silly copy-and-paste code.  I am a terrible coder.
542
543         * Scripts/modules/bugzilla.py:
544
545 2009-11-16  Adam Barth  <abarth@webkit.org>
546
547         Reviewed by Eric Seidel.
548
549         Implement a StyleQueue
550         https://bugs.webkit.org/show_bug.cgi?id=31537
551
552         The first iteration of the style queue only produces output locally.
553         There is also a limit of 10 patches because it's not that useful to
554         iterate through the entire review queue at this point.  We can remove
555         the limit later.
556
557         * Scripts/bugzilla-tool:
558         * Scripts/modules/bugzilla.py:
559
560 2009-11-16  Adam Barth  <abarth@webkit.org>
561
562         Reviewed by Eric Seidel.
563
564         Unit test WorkQueue
565         https://bugs.webkit.org/show_bug.cgi?id=31531
566
567         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
568
569         * Scripts/bugzilla-tool:
570         * Scripts/modules/statusbot.py:
571         * Scripts/modules/workqueue.py:
572         * Scripts/modules/workqueue_unittest.py: Added.
573         * Scripts/run-webkit-unittests:
574
575 2009-11-16  Eric Seidel  <eric@webkit.org>
576
577         Reviewed by Adam Barth.
578
579         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
580         https://bugs.webkit.org/show_bug.cgi?id=31530
581
582         * Scripts/bugzilla-tool:
583
584 2009-11-16  Eric Seidel  <eric@webkit.org>
585
586         Reviewed by Adam Barth.
587
588         bugzilla-tool needs apply-attachment
589         https://bugs.webkit.org/show_bug.cgi?id=31528
590
591         * Scripts/bugzilla-tool:
592          - Add ApplyAttachment command.
593          - Abstract applying code into WebKitApplyingScripts.
594          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
595         * Scripts/modules/bugzilla.py:
596          - Add fetch_attachment and bug_id_for_attachment_id.
597         * Scripts/modules/bugzilla_unittest.py:
598          - Add test for new parsing.
599          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
600
601 2009-11-16  Eric Seidel  <eric@webkit.org>
602
603         Reviewed by Adam Barth.
604
605         Document check-style's use of force_clean.
606
607         * Scripts/bugzilla-tool:
608         * Scripts/modules/scm.py:
609
610 2009-11-16  Adam Barth  <abarth@webkit.org>
611
612         Reviewed by Eric Seidel.
613
614         Move WorkQueue to its own file
615         https://bugs.webkit.org/show_bug.cgi?id=31529
616
617         WorkQueue and WorkQueueDelegate are separate concerns from
618         bugzilla-tool.  Also added a missing include to logging.py.
619
620         * Scripts/bugzilla-tool:
621         * Scripts/modules/logging.py:
622         * Scripts/modules/workqueue.py:
623
624 2009-11-16  Adam Barth  <abarth@webkit.org>
625
626         Reviewed by Eric Seidel.
627
628         Move OutputTee to logging.py.
629
630         * Scripts/bugzilla-tool:
631         * Scripts/modules/logging.py:
632
633 2009-11-15  Adam Barth  <abarth@webkit.org>
634
635         Reviewed by Eric Seidel.
636
637         Refactor bugzilla-tool to allow for multiple queues
638         https://bugs.webkit.org/show_bug.cgi?id=31513
639
640         Divide the commit queue class into three class to make creating
641         additional queues easier.
642
643         * Scripts/bugzilla-tool:
644
645 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
646
647         Reviewed by Eric Seidel.
648
649         svn-apply may not handle git patches created by bugzilla-tool
650         https://bugs.webkit.org/show_bug.cgi?id=31457
651
652         * Scripts/modules/scm.py:
653         * Scripts/modules/scm_unittest.py:
654
655 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
656
657         Reviewed by Eric Seidel.
658
659         bugzilla-tool should post git binary diff
660         https://bugs.webkit.org/show_bug.cgi?id=31458
661
662         Add --binary option to Git.create_patch.
663
664         * Scripts/modules/scm.py:
665         * Scripts/modules/scm_unittest.py:
666
667 2009-11-15  Adam Barth  <abarth@webkit.org>
668
669         Reviewed by Darin Adler.
670
671         Add bugzilla-tool check-style
672         https://bugs.webkit.org/show_bug.cgi?id=31515
673
674         * Scripts/bugzilla-tool:
675         * Scripts/modules/bugzilla.py:
676
677 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
678
679         Reviewed by Simon Hausmann.
680
681         Make the Qt Linux only --valgrind feature, suppress errors
682         defined in the SuppressedValgrindErrors file.
683
684         * Scripts/run-webkit-tests:
685
686 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
687
688         Reviewed by Simon Hausmann.
689
690         Set the locale to C and not to the current one in use on the system.
691
692         * DumpRenderTree/qt/DumpRenderTree.cpp:
693         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
694
695 2009-11-13  Adam Roben  <aroben@apple.com>
696
697         Add support for
698         http/tests/security/isolatedWorld/didClearWindowObject.html
699
700         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
701         window objects in isolated worlds are cleared
702
703         Reviewed by Dave Hyatt.
704
705         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
706
707         * DumpRenderTree/mac/FrameLoadDelegate.mm:
708         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
709         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
710         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
711         Added. Sets a __worldID property on the global object whose value is
712         the ID of this world.
713         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
714         Respond to this new delegate callback by calling through to one of the
715         above new methods.
716         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
717         (worldMap): Added. Returns a HashMap containing all the worlds we've
718         created.
719         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
720         haven't kept track of this world.
721         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
722         instead of declaring our own.
723
724         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
725
726         * DumpRenderTree/win/FrameLoadDelegate.cpp:
727         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
728         didClearWindowObjectForFrameInStandardWorld.
729         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
730         Respond to this new delegate callback by calling through to one of the
731         below new methods.
732         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
733         Added. Sets a __worldID property on the gobal object whose value is
734         the ID of this world.
735         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
736         Added. Moved code here from didClearWindowObject.
737
738         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
739         didClearWindowObjectForFrame* functions.
740
741         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
742         (worldMap): Added. Returns a HashMap containing all the worlds we've
743         created.
744         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
745         haven't kept track of this world.
746         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
747         instead of declaring our own.
748
749 2009-11-13  Adam Roben  <aroben@apple.com>
750
751         Finish replacing worldIDs with world objects
752
753         The only remaining use of worldIDs was in a method only used by DRT
754         for the isolated worlds tests.
755
756         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
757
758         Reviewed by Mark Rowe.
759
760         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
761         (LayoutTestController::evaluateScriptInIsolatedWorld):
762         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
763         (LayoutTestController::evaluateScriptInIsolatedWorld):
764         Updated for changes to WebFrame. Now holds the map of worldID -> world
765         at this level instead of making WebKit do it.
766
767 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
768
769         Reviewed by Simon Hausmann.
770
771         [Qt] Ensure the DRT does not output anything until first test is run
772
773         * DumpRenderTree/qt/DumpRenderTree.cpp:
774         * DumpRenderTree/qt/DumpRenderTree.h:
775
776 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
777
778         Reviewed by Tor Arne Vestbø.
779
780         Clear the undo stack in before each new test run.
781
782         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
783
784         * DumpRenderTree/qt/DumpRenderTree.cpp:
785         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
786
787 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
788
789         Reviewed by Kenneth Rohde Christiansen.
790
791         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
792
793         * DumpRenderTree/qt/DumpRenderTree.cpp:
794         (WebCore::WebPage::resetSettings):
795         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
796         (LayoutTestController::overridePreference):
797
798 2009-11-13  Eric Seidel  <eric@webkit.org>
799
800         Reviewed by Adam Barth.
801
802         Update committers.py based on svn records
803         https://bugs.webkit.org/show_bug.cgi?id=31366
804
805         This list was generated using validate-committer-lists from
806         https://bugs.webkit.org/show_bug.cgi?id=30970
807         and makes committers.py current for committers who have
808         committed in the last 3 years.
809
810         * Scripts/modules/committers.py:
811
812 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
813
814         Reviewed by Adam Barth.
815
816         The document-open.html test was flaky at times. The test invokes the layout test plugin
817         which in its destroy stream handler opens a new document. This basically tears down the
818         stream and the associated plugin instance. The pluginLog function in the layout test
819         plugin attempts to retrieve the window script object on a torn down plugin instance
820         which crashed consistently on windows in the debugger. The functions which issue
821         these logs already have a valid window script object. We now have variants of the pluginLog
822         function which take in a window script object with and without variable arguments. 
823
824         https://bugs.webkit.org/show_bug.cgi?id=31067
825
826         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
827         (pluginLogWithWindowObject):
828         (pluginLogWithWindowObjectVariableArgs):
829         (pluginLog):
830         (notifyTestCompletion):
831         (testDocumentOpen):
832         (testWindowOpen):
833
834 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
835
836         Reviewed by Gustavo Noronha Silva.
837
838         https://bugs.webkit.org/show_bug.cgi?id=30997
839         [Gtk] Implemment AtkDocument
840
841         Added testing support.
842
843         * DumpRenderTree/AccessibilityUIElement.cpp:
844         * DumpRenderTree/AccessibilityUIElement.h:
845         (getDocumentEncodingCallback):
846         (getDocumentURICallback):
847         (AccessibilityUIElement::getJSClass):
848         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
849         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
850         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
851         (AccessibilityUIElement::documentEncoding):
852         (AccessibilityUIElement::documentURI):
853
854 2009-11-12  Adam Roben  <aroben@apple.com>
855
856         Replace worldIDs with world objects
857
858         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
859         user scripts/stylesheets and isolated worlds
860
861         Reviewed by Sam Weinig.
862
863         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
864         (LayoutTestController::addUserScript):
865         (LayoutTestController::addUserStyleSheet):
866         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
867         (LayoutTestController::addUserScript):
868         (LayoutTestController::addUserStyleSheet):
869         Changed these functions to create a new WebJSWorld each time they're
870         called and to pass that world to WebKit.
871
872 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
873
874         Reviewed by Oliver Hunt.
875
876         need to implement aria tree roles
877         https://bugs.webkit.org/show_bug.cgi?id=31284
878
879         * DumpRenderTree/AccessibilityUIElement.cpp:
880         (disclosedRowAtIndexCallback):
881         (selectedRowAtIndexCallback):
882         (isEqualCallback):
883         (isAttributeSettableCallback):
884         (isActionSupportedCallback):
885         (disclosedByRowCallback):
886         (hierarchicalLevelCallback):
887         (AccessibilityUIElement::getJSClass):
888         * DumpRenderTree/AccessibilityUIElement.h:
889         (AccessibilityUIElement::isEqual):
890         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
891         (AccessibilityUIElement::hierarchicalLevel):
892         (AccessibilityUIElement::disclosedRowAtIndex):
893         (AccessibilityUIElement::selectedRowAtIndex):
894         (AccessibilityUIElement::disclosedByRow):
895         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
896         (AccessibilityUIElement::getChildAtIndex):
897         (AccessibilityUIElement::disclosedRowAtIndex):
898         (AccessibilityUIElement::selectedRowAtIndex):
899         (AccessibilityUIElement::titleUIElement):
900         (AccessibilityUIElement::parentElement):
901         (AccessibilityUIElement::disclosedByRow):
902         (AccessibilityUIElement::hierarchicalLevel):
903         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
904         (AccessibilityUIElement::hierarchicalLevel):
905         (AccessibilityUIElement::disclosedRowAtIndex):
906         (AccessibilityUIElement::selectedRowAtIndex):
907         (AccessibilityUIElement::disclosedByRow):
908
909 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
910
911         Reviewed by Darin Adler.
912
913         svn-apply can not handle git binary diffs
914         https://bugs.webkit.org/show_bug.cgi?id=26830
915
916         Support "literal" type git binary diffs.
917
918         * Scripts/VCSUtils.pm:
919         * Scripts/modules/scm_unittest.py:
920         * Scripts/svn-apply:
921
922 2009-11-11  Dmitry Titov  <dimich@chromium.org>
923
924         Not reviewed, removing duplicate entry for myself in committers.py.
925
926         * Scripts/modules/committers.py:
927
928 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
929
930         Reviewed by Darin Adler and Mark Rowe.
931
932         https://bugs.webkit.org/show_bug.cgi?id=31200
933         Tests in http/tests/security/mixedContent start to fail when new tests are added
934
935         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
936
937 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
938
939         Reviewed by Jan Alonzo.
940
941         Create, and display a window for the inspector, for inspector
942         tests.
943
944         Need to also show/hide the inspector window to avoid having
945         problems with code assuming it is realized
946         https://bugs.webkit.org/show_bug.cgi?id=31347
947
948         * DumpRenderTree/gtk/DumpRenderTree.cpp:
949         (webInspectorShowWindow):
950         (webInspectorCloseWindow):
951         (webInspectorInspectWebView):
952         (createWebView):
953
954 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
955
956         Unreviewed Qt buildbot fix.
957
958         My previous fix was wrong, so revert that change and fix it by
959         returning when the document of the frame has no document element.
960         Idea is borrowed from mac and win DRT.
961
962         * DumpRenderTree/qt/DumpRenderTree.cpp:
963         (WebCore::DumpRenderTree::dumpFramesAsText):
964
965 2009-11-11  Eric Seidel  <eric@webkit.org>
966
967         Reviewed byg Kenneth Rohde Christiansen.
968
969         Update Kenneth's committer record to include the email he
970         uses on lists.webkit.org.
971
972         * Scripts/modules/committers.py:
973
974 2009-11-11  Eric Seidel  <eric@webkit.org>
975
976         Reviewed by Gustavo Noronha Silva.
977
978         Several committers use separate email addresses for bugzilla and svn.webkit.org
979         https://bugs.webkit.org/show_bug.cgi?id=31364
980
981         Update records for existing committers to include email addresses
982         used in svn.webkit.org and lists.webkit.org.
983         Most committers use the same email address in all 3 places, but some use
984         separate addresses.  committers.py needs record of each of these addresses.
985
986         * Scripts/modules/committers.py:
987
988 2009-11-11  Eric Seidel  <eric@webkit.org>
989
990         No review, adding second email address for an existing committer.
991
992         Add Yong Li's second bugzilla account to his committer record.
993         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
994
995         * Scripts/modules/committers.py:
996
997 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
998
999         Reviewed by Simon Hausmann.
1000
1001         If the frame has no innerText don't append it, and
1002         do not add a newline which breaks some cross platform
1003         results.
1004
1005         * DumpRenderTree/qt/DumpRenderTree.cpp:
1006         (WebCore::DumpRenderTree::dumpFramesAsText):
1007
1008 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1009
1010         Reviewed by Simon Hausmann.
1011
1012         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1013
1014         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1015         (webkit_test_plugin_new_instance):
1016         (webkit_test_plugin_destroy_instance):
1017         (webkit_test_plugin_destroy_stream):
1018
1019 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1020
1021         Reviewed by Mark Rowe.
1022
1023         Implement the functionality needed by plugins/window-open.html
1024
1025         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1026         (webkit_test_plugin_new_instance):
1027         (webkit_test_plugin_set_window):
1028
1029 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1030
1031         Reviewed by Simon Hausmann.
1032
1033         [Qt] Force -graphicssystem raster and -style windows when running DRT
1034
1035         * DumpRenderTree/qt/main.cpp:
1036         * Scripts/run-webkit-tests:
1037
1038 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1039
1040         Reviewed by Simon Hausmann.
1041
1042         Compute correct library paths for Qt
1043
1044         * Scripts/webkitdirs.pm:
1045
1046 2009-11-10  Mark Rowe  <mrowe@apple.com>
1047
1048         Reviewed by Sam Weinig.
1049
1050         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1051
1052         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1053         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1054         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1055         that had enabled frame load delegate logging this would result in extra log messages being generated,
1056         causing the test to fail.
1057
1058         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1059         tests.
1060
1061         * DumpRenderTree/mac/DumpRenderTree.mm:
1062         (dumpRenderTree):
1063         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1064         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1065
1066 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1067
1068         Reviewed by Kenneth Rohde Christiansen.
1069
1070         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1071
1072         * DumpRenderTree/qt/DumpRenderTree.cpp:
1073         (WebCore::DumpRenderTree::DumpRenderTree):
1074
1075 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1076
1077         Reviewed by Jan Alonzo.
1078
1079         [GTK] Remove WebSocket configuration from WebKitWebSettings
1080         https://bugs.webkit.org/show_bug.cgi?id=31244
1081
1082         Follow-up of r50724. Don't set the enable-web-socket property
1083         anymore.
1084
1085         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1086         (resetDefaultsToConsistentValues):
1087
1088 2009-11-10  Oliver Hunt  <oliver@apple.com>
1089
1090         Reviewed by Maciej Stachowiak.
1091
1092         Rename 3D Canvas related classes to use WebGL prefix
1093         https://bugs.webkit.org/show_bug.cgi?id=29095
1094
1095         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1096         and upate webkitdirs script to new method of testing for WebGL.
1097
1098         * Scripts/do-webcore-rename:
1099         * Scripts/webkitdirs.pm:
1100
1101 2009-11-09  Oliver Hunt  <oliver@apple.com>
1102
1103         Reviewed by Geoff Garen.
1104
1105         Make do-webcore-rename work with git.
1106
1107         * Scripts/do-webcore-rename:
1108
1109 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1110
1111         Adding Kenneth to the reviewers list.
1112
1113         * Scripts/modules/committers.py:
1114
1115 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1116
1117         Reviewed by Jan Alonzo.
1118
1119         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1120         https://bugs.webkit.org/show_bug.cgi?id=30482
1121
1122         LayoutTestControllerGtk now uses the exposed
1123         Page::tabKeyCyclesThroughElements API
1124
1125         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1126         (LayoutTestController::setTabKeyCyclesThroughElements):
1127
1128 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1129
1130         Reviewed by Holger Freyther.
1131
1132         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1133         This helps to pass the test case below. Also replaced hardcoded
1134         code numbers with defined constants.
1135         https://bugs.webkit.org/show_bug.cgi?id=31185
1136         
1137         Test: editing/undo/undo-deleteWord.html
1138
1139         * DumpRenderTree/qt/EventSenderQt.cpp:
1140         (EventSender::keyDown):
1141
1142 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1143
1144         Reviewed by Holger Freyther.
1145
1146         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1147         https://bugs.webkit.org/show_bug.cgi?id=31164
1148
1149         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1150
1151         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1152         (LayoutTestController::processWork):
1153
1154 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1155
1156         Reviewed by Holger Freyther.
1157
1158         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1159         https://bugs.webkit.org/show_bug.cgi?id=31158
1160
1161         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1162         always, which from WorkQueue prospective means that a load has been started
1163         and the queue processing should stop and wait for the load to finish.
1164         Spinning it off into a loading and a non-loading variants was the solution
1165         adopted by Mac's DRT to work around this problem. The former keeps returning
1166         'true' while the later executes the script synchronously and returns 'false'
1167         making it possible to the WorkQueue to proceed right away.
1168
1169         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1170         (LayoutTestController::processWork):
1171         (LayoutTestController::queueLoadingScript):
1172         (LayoutTestController::queueNonLoadingScript):
1173         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1174         * DumpRenderTree/qt/WorkQueueItem.h:
1175         (LoadingScriptItem::LoadingScriptItem):
1176         (LoadingScriptItem::invoke):
1177         (NonLoadingScriptItem::NonLoadingScriptItem):
1178         (NonLoadingScriptItem::invoke):
1179
1180 2009-11-07  Mark Rowe  <mrowe@apple.com>
1181
1182         Rubber-stamped by Cameron Zwarich.
1183
1184         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1185
1186         * Scripts/commit-log-editor:
1187
1188 2009-11-07  Mark Rowe  <mrowe@apple.com>
1189
1190         Reviewed by Darin Adler.
1191
1192         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1193         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1194
1195         Move logic for determining the name and email address to use in a ChangeLog entry from
1196         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1197         whether the author of the patch matches committer, and therefore needs access to the
1198         email address that would be used in a ChangeLog entry.
1199
1200         Based on a patch by Pierre d'Herbemont.
1201
1202         * Scripts/VCSUtils.pm:
1203         * Scripts/commit-log-editor:
1204         * Scripts/prepare-ChangeLog:
1205         * Scripts/webkitdirs.pm:
1206
1207 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1208
1209         Reviewed by Adam Barth.
1210
1211         Added functionality to the layout test plugin to invoke document.open and
1212         window.open with default arguments. The associated webkit bug is
1213         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1214         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1215         work in Chromium (V8) if there is no calling javascript context. To achieve this
1216         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1217         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1218
1219         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1220         (testDocumentOpen):
1221         (testWindowOpen):
1222         (pluginAllocate):
1223         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1224         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1225         (NPP_New):
1226         (NPP_SetWindow):
1227         (NPP_DestroyStream):
1228         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1229         (NPP_New):
1230         (NPP_SetWindow):
1231         (NPP_NewStream):
1232         (NPP_DestroyStream):
1233
1234 2009-11-06  Eric Seidel  <eric@webkit.org>
1235
1236         Reviewed by Adam Barth.
1237
1238         bugzilla-tool crashed with exception
1239         https://bugs.webkit.org/show_bug.cgi?id=31092
1240
1241         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1242
1243 2009-11-04  Eric Seidel  <eric@webkit.org>
1244
1245         No review, just add a line which got left out of the patch uploaded for commit.
1246
1247         commit-queue is crashing when trying to reject patches after unknown failures
1248         https://bugs.webkit.org/show_bug.cgi?id=31091
1249
1250         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1251
1252 2009-11-04  Adam Roben  <aroben@apple.com>
1253
1254         Remove bogus else clause in bugzilla-tool
1255
1256         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1257         create-bug raises exception after entering bug description
1258
1259         Reviewed by David Kilzer.
1260
1261         * Scripts/bugzilla-tool:
1262         (CreateBug): else clauses are only hit if no exception is raised, so
1263         it makes no sense to try to re-raise the exception in an else clause.
1264         The exception will automatically be re-raised if it doesn't match any
1265         of the except clauses, so we don't have to do anything special here at
1266         all to get the desired behavior.
1267
1268 2009-11-04  Eric Seidel  <eric@webkit.org>
1269
1270         Reviewed by David Kilzer.
1271
1272         svn-apply's fixChangeLogPatch function seems broken
1273         https://bugs.webkit.org/show_bug.cgi?id=30683
1274
1275         Update fixChangeLogPatch to be able to handle patches which
1276         don't start at line 1.
1277         Add unit tests for svn-apply to scm_unittest.py.
1278
1279         * Scripts/VCSUtils.pm:
1280         * Scripts/modules/scm_unittest.py:
1281
1282 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1283
1284         Reviewed by Beth Dakin.
1285
1286         Need to implement ARIA role="combobox"
1287         https://bugs.webkit.org/show_bug.cgi?id=31096
1288
1289         * DumpRenderTree/AccessibilityUIElement.cpp:
1290         (showMenuCallback):
1291         (getIsExpandedCallback):
1292         (AccessibilityUIElement::getJSClass):
1293         * DumpRenderTree/AccessibilityUIElement.h:
1294         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1295         (AccessibilityUIElement::isExpanded):
1296         (AccessibilityUIElement::showMenu):
1297         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1298         (AccessibilityUIElement::isExpanded):
1299         (AccessibilityUIElement::showMenu):
1300         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1301         (AccessibilityUIElement::isSelected):
1302         (AccessibilityUIElement::isExpanded):
1303         (AccessibilityUIElement::showMenu):
1304
1305 2009-11-04  Eric Seidel  <eric@webkit.org>
1306
1307         Reviewed by Adam Barth.
1308
1309         commit-queue is crashing when trying to reject patches after unknown failures
1310         https://bugs.webkit.org/show_bug.cgi?id=31091
1311
1312         * Scripts/bugzilla-tool:
1313          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
1314            so we have to find out what the current patch is by asking bugzilla again.
1315          - Discovered that this code was also leaking file descriptors, so fixed that.
1316
1317 2009-11-04  Adam Roben  <aroben@apple.com>
1318
1319         Make run-webkit-tests work for the Debug_Internal Windows
1320         configuration
1321
1322         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
1323         suffix.
1324
1325         Fixes <http://webkit.org/b/31123>.
1326
1327         Reviewed by Sam Weinig.
1328
1329         * Scripts/run-webkit-tests: Don't add the _debug suffix in
1330         Debug_Internal, either.
1331
1332 2009-11-04  Eric Seidel  <eric@webkit.org>
1333
1334         Reviewed by Adam Barth.
1335
1336         committers.py needs a way to store non-bugzilla email addresses
1337         https://bugs.webkit.org/show_bug.cgi?id=31037
1338
1339         Make Committer and Reviewer constructors take a single email or a list of emails.
1340         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
1341         Expose reviewers(), used by validate-committer-lists on bug 30970.
1342
1343         * Scripts/modules/committers.py:
1344         * Scripts/modules/committers_unittest.py: Added tests for the new code.
1345
1346 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
1347
1348         Reviewed by David Levin.
1349
1350         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
1351         https://bugs.webkit.org/show_bug.cgi?id=27491
1352
1353         The test path determination logic is changed to handle websocket and websocket/ssl cases.
1354         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
1355
1356         Functions to start or stop Web Socket servers are added.
1357
1358         * Scripts/run-webkit-tests:
1359
1360 2009-11-03  Eric Seidel  <eric@webkit.org>
1361
1362         No review, just changing wording of log message.
1363
1364         Change log string to say "failed" instead of "rejected"
1365         when a commit fails due to an out of date checkout.
1366         This makes grepping the commit-queue log for rejected patches easier.
1367
1368         * Scripts/bugzilla-tool:
1369
1370 2009-11-03  Eric Seidel  <eric@webkit.org>
1371
1372         No review, adding commonly known committers missing from the file.
1373
1374         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
1375
1376 2009-11-03  Eric Seidel  <eric@webkit.org>
1377
1378         No review, just sort-order cleanup.
1379
1380         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
1381
1382 2009-11-03  Stephen White  <senorblanco@chromium.org>
1383
1384         (Unreviewed).
1385
1386         Add myself to committers.py.
1387
1388         * Scripts/modules/committers.py:
1389
1390 2009-11-03  Robin Dunn  <robin@alldunn.com>
1391
1392         Reviewed by Kevin Ollviier.
1393
1394         Add packaging scripts for Debian-based Linux distros.
1395         
1396         https://bugs.webkit.org/show_bug.cgi?id=31075
1397
1398         * wx/packaging/build-debian-installer.py: Added.
1399         * wx/packaging/debian: Added.
1400
1401 2009-11-03  Dan Bernstein  <mitz@apple.com>
1402
1403         Reviewed by Anders Carlsson and Beth Dakin.
1404
1405         https://bugs.webkit.org/show_bug.cgi?id=31070
1406
1407         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
1408         destroyed, it executes the value of the 'ondestroy' parameter as a
1409         script.
1410
1411         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1412         (pluginAllocate): Initialize onDestroy.
1413         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
1414         onDestroy.
1415         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1416         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
1417         specified.
1418         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
1419
1420 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1421
1422         Reviewed by Xan Lopez.
1423
1424         https://bugs.webkit.org/show_bug.cgi?id=31035
1425         [GTK] some accessibility tests hitting assertion in debug builds
1426
1427         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
1428
1429         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1430         (AccessibilityController::rootElement):
1431
1432 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
1433
1434         Reviewed by Beth Dakin.
1435
1436         Support ARIA "tab" roles
1437         https://bugs.webkit.org/show_bug.cgi?id=30842
1438
1439         * DumpRenderTree/AccessibilityUIElement.cpp:
1440         * DumpRenderTree/AccessibilityUIElement.h:
1441         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1442         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1443         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1444
1445 2009-11-01  Eric Seidel  <eric@webkit.org>
1446
1447         Reviewed by David Levin.
1448
1449         buildbots should use --exit-after-N-failures
1450         https://bugs.webkit.org/show_bug.cgi?id=30809
1451
1452         Make the bots exit after 20 failures to prevent never-ending
1453         test runs where every test spends a minute crashing.
1454
1455         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1456
1457 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1458
1459         Reviewed by Eric Seidel.
1460
1461         Turn on warnings for QtWebKit for gcc
1462         https://bugs.webkit.org/show_bug.cgi?id=30958
1463
1464         * DumpRenderTree/qt/main.cpp: 
1465         (crashHandler): Mark function NO_RETURN
1466
1467 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
1468
1469         Adding myself to the committers list.
1470
1471         * Scripts/modules/committers.py:
1472
1473 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
1474
1475         Fix an issue that Adam noticed in DRT.
1476
1477         Reviewed by Darin Adler.
1478
1479         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1480         (AccessibilityUIElement::role):
1481         Get the length of the role text, and create a buffer dynamically.
1482
1483 2009-10-30  Eric Seidel  <eric@webkit.org>
1484
1485         No review, rolling out r50105.
1486         http://trac.webkit.org/changeset/50105
1487
1488         This commit was causing:
1489         https://bugs.webkit.org/show_bug.cgi?id=30869
1490         We'll re-implement the feature a different way.
1491
1492         * Scripts/bugzilla-tool:
1493
1494 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1495
1496         Test for MSAA: Accessibility of headings is not correct
1497
1498         https://bugs.webkit.org/show_bug.cgi?id=30937
1499
1500         Reviewed by Adam Roben.
1501
1502         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1503         (AccessibilityUIElement::role):
1504         Allow the role returned to be a BSTR.
1505         (AccessibilityUIElement::description):
1506         Fix a copy/paste error.
1507
1508 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1509
1510         Test for MSAA: Accessibility of links is wrong
1511
1512         https://bugs.webkit.org/show_bug.cgi?id=30928
1513
1514         Reviewed by Darin Adler.
1515
1516         * DumpRenderTree/AccessibilityUIElement.cpp:
1517         (getAccessibilityValueCallback):
1518         Return the accessibility value.
1519         (AccessibilityUIElement::getJSClass):
1520         Added "accessibilityValue" value.
1521
1522         * DumpRenderTree/AccessibilityUIElement.h:
1523
1524         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1525         (AccessibilityUIElement::accessibilityValue):
1526         Stubbed.
1527
1528         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1529         (AccessibilityUIElement::accessibilityValue):
1530         Stubbed.
1531
1532         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1533         (AccessibilityUIElement::accessibilityValue):
1534         Get the object's value, and return it as a JS string.
1535
1536 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
1537
1538         Fix typo in command name used by wx build system.
1539
1540         * wx/build/build_utils.py:
1541
1542 2009-10-30  Adam Barth  <abarth@webkit.org>
1543
1544         Reviewed by Darin Adler.
1545
1546         Patch v1 is a dumb default name for patches
1547         https://bugs.webkit.org/show_bug.cgi?id=30952
1548
1549         Let's use "Patch" instead.
1550
1551         * Scripts/bugzilla-tool:
1552
1553 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1554
1555         Unreviewed trivial buildfix.
1556
1557         [Qt] Buildfix for r50333.
1558
1559         * DumpRenderTree/qt/DumpRenderTree.pro:
1560
1561 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
1562
1563         Reviewed by Holger Freyther.
1564
1565         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
1566         https://bugs.webkit.org/show_bug.cgi?id=30953
1567
1568         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
1569         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
1570         makes qt DRT to share this implementation (as gtk and mac ports do).
1571
1572         * DumpRenderTree/qt/DumpRenderTree.pro:
1573         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
1574         * DumpRenderTree/qt/WorkQueue.h: Removed.
1575
1576 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1577
1578         Unreviewed potential buildbot fix.
1579
1580         Second try: Reset page history before running each test.
1581
1582         Apparently the QWebHistory::clear() keeps the current page
1583         in history which is not what we want, so we not additionally
1584         sets the history capacity to 0 (forces removing everything)
1585         and then sets it back to its original value.
1586
1587         * DumpRenderTree/qt/DumpRenderTree.cpp:
1588         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1589
1590 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1591
1592         Unreviewed potential buildbot fix.
1593
1594         Reset page history before running each test.
1595
1596         * DumpRenderTree/qt/DumpRenderTree.cpp:
1597         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1598
1599 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
1600
1601         Reviewed by Eric Seidel.
1602
1603         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
1604
1605         Bug 28420 -  Implement HTML5 <ruby> rendering
1606         (https://bugs.webkit.org/show_bug.cgi?id=28420)
1607
1608         No new tests (no functional change).
1609
1610         * Scripts/build-webkit:
1611
1612 2009-10-29  Dan Bernstein  <mitz@apple.com>
1613
1614         Reviewed by Mark Rowe.
1615
1616         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
1617         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
1618         define it.
1619
1620         * Scripts/VCSUtils.pm:
1621         * Scripts/svn-apply:
1622         * Scripts/svn-unapply:
1623
1624 2009-10-29  Xan Lopez  <xlopez@igalia.com>
1625
1626         Reviewed by Gustavo Noronha.
1627
1628         Use the GTK+ main loop instead of rolling our own mini-version of
1629         it.
1630
1631         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1632         (dump):
1633         (runTest):
1634         (webViewLoadFinished):
1635
1636 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1637
1638         Reviewed by Oliver Hunt.
1639
1640         Implement the Qt version of DRT dumpBackForwardList().
1641
1642         * DumpRenderTree/qt/DumpRenderTree.cpp:
1643         (WebCore::dumpHistoryItem):
1644         (WebCore::DumpRenderTree::dumpBackForwardList):
1645
1646 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1647
1648         Reviewed by Adam Roben.
1649
1650         Implement DRT functionality for Qt introduced in
1651         r28690 and r28705.
1652
1653         - Implemented pathToLocalResource which exposes the functionality of
1654         converting a given unix path to the correct location on Windows.
1655         - Implemented a way to remove machine-dependent information from paths
1656         in layout test results.
1657
1658         * DumpRenderTree/qt/DumpRenderTree.cpp:
1659         (WebCore::urlSuitableForTestResult):
1660         (WebCore::WebPage::javaScriptConsoleMessage):
1661         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1662         (LayoutTestController::pathToLocalResource):
1663         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1664
1665 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
1666
1667         Adding myself to the committers list.
1668
1669         * Scripts/modules/committers.py:
1670
1671 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
1672
1673         Adding myself to the committers list.
1674
1675         * Scripts/modules/committers.py:
1676
1677 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1678
1679         Reviewed by Jan Alonzo.
1680
1681         [GTK] API to start inspector for a WebView
1682         https://bugs.webkit.org/show_bug.cgi?id=22551
1683
1684         Use the new inspector API to implement the LayoutTestController
1685         interfaces used to test the inspector.
1686
1687         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1688         (webInspectorInspectWebView):
1689         (createWebView):
1690         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1691         (LayoutTestController::showWebInspector):
1692         (LayoutTestController::closeWebInspector):
1693         (LayoutTestController::evaluateInWebInspector):
1694
1695 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
1696
1697         Reviewed by Eric Seidel.
1698
1699         [Qt] WebFrame::counterValueForElementById must not be exposed
1700         https://bugs.webkit.org/show_bug.cgi?id=30882
1701
1702         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1703         (LayoutTestController::counterValueForElementById):
1704
1705 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1706
1707         Rubberstamped by Oliver Hunt.
1708
1709         Fix the warning:
1710
1711         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
1712         declared with attribute warn_unused_result".
1713
1714         by actually checking the result. In the case it is null, an
1715         error has occoured, so treat it as the other fatal errors.
1716
1717         * DumpRenderTree/qt/DumpRenderTree.cpp:
1718         (WebCore::DumpRenderTree::initializeFonts):
1719
1720 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
1721
1722         Reviewed by Darin Adler.
1723
1724         Provide a way to get counter values with layoutTestContoller
1725         https://bugs.webkit.org/show_bug.cgi?id=30555
1726
1727         Define layoutTestContoller.counterValueForElementById.
1728
1729         * DumpRenderTree/LayoutTestController.cpp:
1730         (counterValueForElementByIdCallback):
1731         (LayoutTestController::staticFunctions):
1732         * DumpRenderTree/LayoutTestController.h:
1733         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1734         (LayoutTestController::counterValueForElementById):
1735
1736 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1737
1738         Rubberstamped by Oliver Hunt.
1739
1740         Change two methods to be internal for DRT use only.
1741
1742         Part of [Qt] Review all new API in Qt 4.6
1743         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
1744
1745         * DumpRenderTree/qt/DumpRenderTree.cpp:
1746         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1747         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1748         (LayoutTestController::whiteListAccessFromOrigin):
1749
1750 2009-10-27  Eric Seidel  <eric@webkit.org>
1751
1752         Reviewed by Adam Barth.
1753
1754         REGRESSION: svn-apply exits(1) when applying a patch with a file add
1755         https://bugs.webkit.org/show_bug.cgi?id=30826
1756
1757         * Scripts/svn-apply:
1758          - Add () around all system() calls.
1759          - Use the correct system() == 0 or die instead of system() or die
1760          - Add descriptive messages to all die statements.
1761
1762 2009-10-27  Steve Block  <steveblock@google.com>
1763
1764         Reviewed by NOBODY.
1765
1766         Adds steveblock@google.com to list of committers.
1767
1768         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
1769
1770 2009-10-27  Eric Seidel  <eric@webkit.org>
1771
1772         Reviewed by Adam Barth.
1773
1774         svn-apply can exit(0) even on patch failure
1775         https://bugs.webkit.org/show_bug.cgi?id=29622
1776
1777         * Scripts/svn-apply:
1778          - Add a bunch of "or die" statements, hopefully catching all
1779            possible cases where failure could still exit(0).
1780
1781 2009-10-27  Eric Seidel  <eric@webkit.org>
1782
1783         Reviewed by Adam Barth.
1784
1785         svn-* scripts should share code through VCSUtils.pm
1786         https://bugs.webkit.org/show_bug.cgi?id=30791
1787
1788         Just moving code into a shared location.
1789
1790         * Scripts/VCSUtils.pm:
1791         * Scripts/prepare-ChangeLog:
1792         * Scripts/resolve-ChangeLogs:
1793         * Scripts/svn-apply:
1794         * Scripts/svn-create-patch:
1795         * Scripts/svn-unapply:
1796         * Scripts/update-webkit:
1797
1798 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
1799
1800         Suppress a huge number of MSVC warnings when building wxWebKit.
1801
1802         * wx/build/settings.py:
1803
1804 2009-10-26  Eric Seidel  <eric@webkit.org>
1805
1806         No review, just adding Mike Belshe to the committers list.
1807
1808         * Scripts/modules/committers.py:
1809
1810 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1811
1812         Reviewed by Darin Adler.
1813
1814         Make .rc files compile on Windows without depending on MFC headers
1815         https://bugs.webkit.org/show_bug.cgi?id=30750
1816
1817         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
1818         windows.h instead of afxres.h because it exists even when MFC is not 
1819         installed, and is all that's needed here.
1820
1821         * FindSafari/FindSafari.rc: Ditto
1822
1823 2009-10-24  Eric Seidel  <eric@webkit.org>
1824
1825         Reviewed by Adam Barth.
1826
1827         bugzilla-tool post-diff should know how to mark commit-queue=?
1828         https://bugs.webkit.org/show_bug.cgi?id=29202
1829
1830         * Scripts/bugzilla-tool:
1831          - Add --commit-queue option to post-diff, post-commits and create-bug.
1832         * Scripts/modules/bugzilla.py:
1833          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
1834          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
1835
1836 2009-10-23  Eric Seidel  <eric@webkit.org>
1837
1838         Reviewed by Adam Barth.
1839
1840         bugzilla-tool commit-queue does not notice modifications to committers.py
1841         https://bugs.webkit.org/show_bug.cgi?id=30084
1842
1843         * Scripts/bugzilla-tool:
1844          - Make commit-queue re-exec itself instead of using while(1).
1845          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
1846          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
1847
1848 2009-10-22  Eric Seidel  <eric@webkit.org>
1849
1850         Reviewed by Adam Barth.
1851
1852         commit-queue will get stuck on patches if land-patches terminates unexpectedly
1853         https://bugs.webkit.org/show_bug.cgi?id=30634
1854
1855         * Scripts/bugzilla-tool:
1856          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
1857          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
1858
1859 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
1860
1861         Reviewed by Eric Seidel.
1862
1863         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
1864
1865         https://bugs.webkit.org/show_bug.cgi?id=30763
1866
1867         * pywebsocket/mod_pywebsocket/__init__.py:
1868         * pywebsocket/mod_pywebsocket/dispatch.py:
1869         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
1870         * pywebsocket/mod_pywebsocket/standalone.py:
1871         * pywebsocket/setup.py:
1872         * pywebsocket/test/test_dispatch.py:
1873
1874 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
1875
1876         Reviewed by David Levin.
1877
1878         REGRESSION: 2 failures in run-webkit-unittests
1879         https://bugs.webkit.org/show_bug.cgi?id=30645
1880
1881         * Scripts/modules/cpp_style_unittest.py:
1882         Fixed a few test scenarios which apparently lost some spaces from 
1883         text literals.
1884
1885 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
1886
1887         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
1888
1889         * Scripts/webkitdirs.pm:
1890
1891 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
1892
1893         Reviewed by Darin Adler.
1894
1895         Unification of using null device in perl scripts.
1896         https://bugs.webkit.org/show_bug.cgi?id=30572
1897
1898         * Scripts/VCSUtils.pm:
1899         * Scripts/bisect-builds:
1900         * Scripts/resolve-ChangeLogs:
1901         * Scripts/run-iexploder-tests:
1902         * Scripts/run-jsc:
1903         * Scripts/run-mangleme-tests:
1904         * Scripts/run-webkit-tests:
1905         * Scripts/webkitdirs.pm:
1906         Using File::Spec->devnull() instead of hard coded /dev/null.
1907
1908 2009-10-26  Eric Seidel  <eric@webkit.org>
1909
1910         Reviewed by Holger Freyther.
1911
1912         Reviewers are missing from committers.py
1913         https://bugs.webkit.org/show_bug.cgi?id=30733
1914
1915         * Scripts/modules/committers.py:
1916
1917 2009-10-23  Eric Seidel  <eric@webkit.org>
1918
1919         No review, only adding Alice to the list of reviewers.
1920
1921         * Scripts/modules/committers.py:
1922
1923 2009-10-23  Eric Seidel  <eric@webkit.org>
1924
1925         Reviewed by Eric Carlson.
1926
1927         fast/media/mq-transform-02.html failed on Leopard Commit Bot
1928         https://bugs.webkit.org/show_bug.cgi?id=30700
1929
1930         * DumpRenderTree/mac/DumpRenderTree.mm:
1931         (resetDefaultsToConsistentValues): Update QuickTime version check.
1932
1933 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
1934
1935         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
1936         character measurement APIs that are private on Tiger.
1937
1938         * wx/build/settings.py:
1939
1940 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
1941
1942         Reviewed by NOBODY (build fix).
1943         Build fix following bug #30696.
1944
1945         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1946         (LayoutTestController::evaluateScriptInIsolatedWorld):
1947
1948 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
1949
1950         Reviewed by Sam Weinig & Geoff Garen.
1951
1952         https://bugs.webkit.org/show_bug.cgi?id=30696
1953         Enable isolated-worlds tests on mac.
1954
1955         Add private interface for DRT to invoke execution in a given world.
1956
1957         * DumpRenderTree/LayoutTestController.cpp:
1958         (evaluateScriptInIsolatedWorldCallback):
1959         (LayoutTestController::staticFunctions):
1960         * DumpRenderTree/LayoutTestController.h:
1961         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1962         (LayoutTestController::evaluateScriptInIsolatedWorld):
1963         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1964         (LayoutTestController::evaluateScriptInIsolatedWorld):
1965
1966 2009-10-21  Eric Seidel  <eric@webkit.org>
1967
1968         Reviewed by Adam Barth.
1969
1970         bugzilla-tool's "patch failed to download an apply" error should give more information
1971         https://bugs.webkit.org/show_bug.cgi?id=30632
1972
1973         * Scripts/modules/scm.py:
1974          - Use the common run_command method instead of custom POpen code.
1975          - Make run_command know how to take pipes as input.
1976         * Scripts/modules/scm_unittest.py:
1977          - Add new tests to cover change.
1978          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
1979
1980 2009-10-21  Kent Tamura  <tkent@chromium.org>
1981
1982         Unreviewed.  Adding myself to the committers list.
1983
1984         * Scripts/modules/committers.py:
1985
1986 2009-10-21  Robin Dunn  <robin@alldunn.com>
1987
1988         Reviewed by Kevin Ollivier.
1989
1990         Update the Windows installer builder to work with Vista / Win 7 and with git.
1991         
1992         https://bugs.webkit.org/show_bug.cgi?id=30649
1993
1994         * wx/build/build_utils.py:
1995         * wx/packaging/build-mac-installer.py:
1996         * wx/packaging/build-win-installer.py:
1997         * wx/packaging/wxWebKitInstaller.iss.in:
1998
1999 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2000
2001         Reviewed by Gustavo Noronha.
2002
2003         [GTK] Added conditional code to avoid using
2004         gdk_window_get_root_coords if we do not have a gtk+ release newer
2005         than 2.17.3.
2006         https://bugs.webkit.org/show_bug.cgi?id=30636
2007
2008         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2009
2010 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2011
2012         Reviewed by Eric Seidel.
2013
2014         [Qt] Added dummy implementation for keepWebHistory()
2015         https://bugs.webkit.org/show_bug.cgi?id=30592
2016
2017         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2018         (LayoutTestController::keepWebHistory):
2019         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2020
2021 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2022
2023         Reviewed by Xan Lopez.
2024
2025         [GTK] Fixed the double click condition, it is not double click if
2026         we move in just in one direction.
2027         https://bugs.webkit.org/show_bug.cgi?id=30636
2028
2029         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2030
2031 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2032
2033         Reviewed by Xan Lopez.
2034
2035         [GTK] Initialize the events completly before emitting them.
2036         https://bugs.webkit.org/show_bug.cgi?id=30633
2037
2038         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2039
2040 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2041
2042         wx build fix. Fix for when linking using --as-needed with gcc.
2043
2044         * wx/browser/wscript:
2045
2046 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2047
2048         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2049         to support all the features used by CURL backend.
2050         
2051         * wx/build/settings.py:
2052         * wx/install-unix-extras:
2053
2054 2009-10-20  Anton Muhin  <antonm@chromium.org>
2055
2056         Reviewed by Adam Barth.
2057
2058         Add {ager,antonm,yurys}@chromium.org into committers.py
2059         https://bugs.webkit.org/show_bug.cgi?id=30560
2060
2061         * Scripts/modules/committers.py:
2062
2063 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2064
2065         Reviewed by Tor Arne Vestbø.
2066
2067         Make the Netscape Test plugin available to the Qt launcher.
2068
2069         * Scripts/run-launcher:
2070
2071 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2072
2073         Reviewed by David Levin.
2074
2075         Removed WebSocket runtime settings.
2076         https://bugs.webkit.org/show_bug.cgi?id=29896
2077
2078         WebSocket runtime configuration is supported by chromium/v8 only.
2079
2080         * DumpRenderTree/mac/DumpRenderTree.mm:
2081         (resetDefaultsToConsistentValues):
2082         * DumpRenderTree/win/DumpRenderTree.cpp:
2083         (resetDefaultsToConsistentValues):
2084
2085 2009-10-19  Nate Chapin  <japhet@chromium.org>
2086
2087         Reviewed by Adam Barth.
2088
2089         Add testFail() to test plugin so we can test our handling of a
2090         plugin invoke call returning false.
2091
2092         https://bugs.webkit.org/show_bug.cgi?id=30239
2093
2094         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2095         (pluginInvoke):
2096         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2097
2098 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2099
2100         Reviewed by Gustavo Noronha.
2101
2102         Enable DOM pasting when running layout tests.
2103
2104         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2105         (resetDefaultsToConsistentValues):
2106
2107 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2108
2109         Reviewed by Simon Hausmann.
2110
2111         Use the setPreferredContentsSize method instead
2112         of setFixedContentsSize, as the method has been renamed.
2113
2114         * DumpRenderTree/qt/DumpRenderTree.cpp:
2115         (WebCore::DumpRenderTree::open):
2116         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2117         (LayoutTestController::setFixedContentsSize):
2118
2119 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2120
2121         Reviewed by Dan Bernstein.
2122
2123         https://bugs.webkit.org/show_bug.cgi?id=30456
2124         Fixes for new Debug_All Windows build configuration.
2125
2126         * DumpRenderTree/win/DumpRenderTree.cpp:
2127         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2128         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2129
2130 2009-10-16  Eric Seidel  <eric@webkit.org>
2131
2132         Reviewed by Adam Barth.
2133
2134         commit-queue status bot should list which buildbot is blocking the queue
2135         https://bugs.webkit.org/show_bug.cgi?id=30452
2136
2137         Add new methods and testing.
2138
2139         * Scripts/bugzilla-tool:
2140         * Scripts/modules/buildbot.py:
2141         * Scripts/modules/buildbot_unittest.py:
2142
2143 2009-10-16  Eric Seidel  <eric@webkit.org>
2144
2145         Reviewed by Adam Barth.
2146
2147         run-webkit-tests fails when CWD is not inside a WebKit checkout
2148         https://bugs.webkit.org/show_bug.cgi?id=30451
2149
2150         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2151         * Scripts/modules/scm_unittest.py:
2152           - Remove use of original_path (we don't need to restore the CWD).
2153           - Don't use '.' to find the webkit checkout, use __file__ instead.
2154
2155 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2156
2157         Reviewed by Adam Roben.
2158
2159         Add a Debug_All configuration to build entire stack as debug.
2160         Change Debug_Internal to:
2161         - stop using _debug suffix for all WebKit/Safari binaries
2162         - not use _debug as a DLL naming suffix
2163         - use non-debug C runtime lib.
2164
2165         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2166         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2167         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2168         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2169         Add missing debug.vsprops inherited property sheet.
2170         Add Debug_All configuration.
2171         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2172         * WinLauncher/WinLauncher.vcproj:
2173         Removed extraneous definitions inherited from vsprops.
2174         Add Debug_All configuration.
2175
2176 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2177
2178         Reviewed by David Levin.
2179
2180         check-webkit-style is wrong about indent checking in namespaces
2181         in header files and a few other things
2182         https://bugs.webkit.org/show_bug.cgi?id=30362
2183
2184         The few other things include:
2185         + check-webkit-style does not require spaces around the equal sign
2186           inside 'if' statements and around binary operators that take 
2187           numeric literals.
2188         + check-webkit-style reports false errors for the / operator
2189           when part of a filename in the #include directive.
2190
2191         * Scripts/modules/cpp_style.py:
2192         Improved indentation checking and space checking around
2193         binary operators. While the checks are still not perfect,
2194         they are clearly better than before.
2195         * Scripts/modules/cpp_style_unittest.py:
2196         Added test cases for the newly supported checks and modified old
2197         test cases to match the new guidelines
2198
2199 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2200
2201         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2202
2203         * wx/build/settings.py:
2204
2205 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2206
2207         Reviewed by David Levin.
2208
2209         Add mod_pywebsocket to test Web Sockets.
2210         http://code.google.com/p/pywebsocket/
2211         https://bugs.webkit.org/show_bug.cgi?id=27490
2212
2213         * pywebsocket/COPYING: Added.
2214         * pywebsocket/MANIFEST.in: Added.
2215         * pywebsocket/README: Added.
2216         * pywebsocket/example/echo_client.py: Added.
2217         * pywebsocket/example/echo_wsh.py: Added.
2218         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2219         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2220         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2221         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2222         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2223         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2224         * pywebsocket/mod_pywebsocket/util.py: Added.
2225         * pywebsocket/setup.py: Added.
2226         * pywebsocket/test/config.py: Added.
2227         * pywebsocket/test/mock.py: Added.
2228         * pywebsocket/test/run_all.py: Added.
2229         * pywebsocket/test/test_dispatch.py: Added.
2230         * pywebsocket/test/test_handshake.py: Added.
2231         * pywebsocket/test/test_mock.py: Added.
2232         * pywebsocket/test/test_msgutil.py: Added.
2233         * pywebsocket/test/test_util.py: Added.
2234         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2235         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2236         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2237         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2238         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2239         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2240         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2241         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2242
2243 2009-10-15  James Robinson  <jamesr@google.com>
2244
2245         Reviewed by David Levin.
2246
2247         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2248
2249         https://bugs.webkit.org/show_bug.cgi?id=30426
2250
2251         * Scripts/modules/cpp_style.py:
2252         * Scripts/modules/cpp_style_unittest.py:
2253
2254 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2255
2256         Reviewed by Adam Roben.
2257
2258         Fixes <http://webkit.org/b/30411>.
2259         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2260         
2261         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2262         building Chromium.
2263
2264         * Scripts/pdevenv:
2265
2266 2009-10-15  Robin Dunn  <robin@alldunn.com>
2267
2268         Reviewed by Kevin Ollivier.
2269
2270         Add Mac package building scripts for wx.
2271         
2272         https://bugs.webkit.org/show_bug.cgi?id=30405
2273
2274         * wx/build/build_utils.py:
2275         * wx/build/settings.py:
2276         * wx/packaging/build-mac-installer.py: Added.
2277
2278 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2279
2280         Reviewed by Gustavo Noronha.
2281
2282         Enable Web Sockets support when running layout tests.
2283
2284         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2285         (resetDefaultsToConsistentValues):
2286
2287 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2288
2289         Reviewed by Gustavo Noronha.
2290
2291         Need to initialize event.button.button, since in most cases a
2292         button number is not passed as an argument.
2293
2294         * DumpRenderTree/gtk/EventSender.cpp:
2295         (mouseDownCallback):
2296         (mouseUpCallback):
2297
2298 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
2299
2300         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
2301         the OS if none was explicitly set.
2302
2303         * wx/build/settings.py:
2304
2305 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2306
2307         Reviewed by Timothy Hatcher.
2308
2309         Web Inspector: enable developers extras within inspector layout tests.
2310
2311         https://bugs.webkit.org/show_bug.cgi?id=30014
2312
2313         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2314         (LayoutTestController::showWebInspector):
2315         (LayoutTestController::closeWebInspector):
2316         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2317         (LayoutTestController::showWebInspector):
2318         (LayoutTestController::closeWebInspector):
2319
2320 2009-10-14  José Millán Soto  <jmillan@igalia.com>
2321
2322         Reviewed by Jan Alonzo.
2323
2324         GtkLauncher is using a deprecated signal
2325         https://bugs.webkit.org/show_bug.cgi?id=30364
2326
2327         Modified GtkLauncher to use notify::title signal instead of
2328         deprecated title-changed signal
2329
2330         * GtkLauncher/main.c:
2331         (notify_title_cb):
2332         (create_browser):
2333
2334 2009-10-14  Brady Eidson  <beidson@apple.com>
2335
2336         Reviewed by Sam Weinig.
2337
2338         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
2339         1 - Disables WebHistory
2340         2 - Doesn't make sense in that context anyway.
2341
2342         * DumpRenderTree/win/DumpRenderTree.cpp:
2343         (createWebViewAndOffscreenWindow):
2344
2345 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
2346
2347         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
2348         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
2349
2350         * wx/build/settings.py:
2351         * wx/install-unix-extras:
2352
2353 2009-10-14  Brady Eidson  <beidson@apple.com>
2354
2355         Reviewed by Sam Weinig.
2356
2357         WebKit Win API should provide a delegate interface for global history.
2358         https://bugs.webkit.org/show_bug.cgi?id=29905
2359
2360         * DumpRenderTree/LayoutTestController.cpp:
2361         (LayoutTestController::LayoutTestController):
2362         * DumpRenderTree/LayoutTestController.h:
2363         (LayoutTestController::dumpHistoryDelegateCallbacks):
2364         (LayoutTestController::setDumpHistoryDelegateCallbacks):
2365                 
2366         * DumpRenderTree/win/DumpRenderTree.cpp:
2367         (shouldLogHistoryDelegates):
2368         (runTest):
2369         (createWebViewAndOffscreenWindow):
2370         (main):
2371         * DumpRenderTree/win/DumpRenderTree.vcproj:
2372         
2373         Add the IWebHistoryDelegate to DRT Windows:
2374         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
2375         (wstringFromBSTR):
2376         (HistoryDelegate::HistoryDelegate):
2377         (HistoryDelegate::~HistoryDelegate):
2378         (HistoryDelegate::QueryInterface):
2379         (HistoryDelegate::AddRef):
2380         (HistoryDelegate::Release):
2381         (HistoryDelegate::didNavigateWithNavigationData):
2382         (HistoryDelegate::didPerformClientRedirectFromURL):
2383         (HistoryDelegate::didPerformServerRedirectFromURL):
2384         (HistoryDelegate::updateHistoryTitle):
2385         (HistoryDelegate::populateVisitedLinksForWebView):
2386         * DumpRenderTree/win/HistoryDelegate.h: Added.
2387
2388         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2389         (LayoutTestController::removeAllVisitedLinks):
2390
2391 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
2392
2393         Reviewed by Simon Hausmann.
2394
2395         [Qt] Implement support for setPOSIXLocale on Qt.
2396         https://bugs.webkit.org/show_bug.cgi?id=30268 
2397  
2398         * DumpRenderTree/qt/DumpRenderTree.cpp:
2399         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2400         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2401         (LayoutTestController::setPOSIXLocale):
2402         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2403
2404 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2405
2406         Unreviewed, adding myself to reviewers list.
2407
2408         * Scripts/modules/committers.py:
2409
2410 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2411
2412         Reviewed by Mark Rowe.
2413
2414         Fix null assignment so root tests work again.
2415
2416         * Scripts/webkitdirs.pm:
2417
2418 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2419
2420         Reviewed by Simon Hausmann.
2421
2422         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
2423         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
2424         This is done in preparation of implementing missing features in DRT.
2425         No functionality changes made yet.
2426
2427         * DumpRenderTree/qt/DumpRenderTree.cpp:
2428         * DumpRenderTree/qt/DumpRenderTree.pro:
2429         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
2430         (EventSender::EventSender):
2431         (EventSender::mouseDown):
2432         (EventSender::mouseUp):
2433         (EventSender::mouseMoveTo):
2434         (EventSender::leapForward):
2435         (EventSender::keyDown):
2436         (EventSender::contextClick):
2437         (EventSender::scheduleAsynchronousClick):
2438         (EventSender::frameUnderMouse):
2439         * DumpRenderTree/qt/EventSenderQt.h: Added.
2440         (EventSender::clearKillRing):
2441         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
2442         (LayoutTestController::LayoutTestController):
2443         (LayoutTestController::reset):
2444         (LayoutTestController::processWork):
2445         (LayoutTestController::maybeDump):
2446         (LayoutTestController::waitUntilDone):
2447         (LayoutTestController::notifyDone):
2448         (LayoutTestController::windowCount):
2449         (LayoutTestController::clearBackForwardList):
2450         (LayoutTestController::dumpEditingCallbacks):
2451         (LayoutTestController::dumpResourceLoadCallbacks):
2452         (LayoutTestController::queueBackNavigation):
2453         (LayoutTestController::queueForwardNavigation):
2454         (LayoutTestController::queueLoad):
2455         (LayoutTestController::queueReload):
2456         (LayoutTestController::queueScript):
2457         (LayoutTestController::provisionalLoad):
2458         (LayoutTestController::timerEvent):
2459         (LayoutTestController::encodeHostName):
2460         (LayoutTestController::decodeHostName):
2461         (LayoutTestController::setJavaScriptProfilingEnabled):
2462         (LayoutTestController::setFixedContentsSize):
2463         (LayoutTestController::setPrivateBrowsingEnabled):
2464         (LayoutTestController::setPopupBlockingEnabled):
2465         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2466         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2467         (LayoutTestController::numberOfActiveAnimations):
2468         (LayoutTestController::disableImageLoading):
2469         (LayoutTestController::dispatchPendingLoadRequests):
2470         (LayoutTestController::setDatabaseQuota):
2471         (LayoutTestController::clearAllDatabases):
2472         (LayoutTestController::whiteListAccessFromOrigin):
2473         (LayoutTestController::waitForPolicyDelegate):
2474         (LayoutTestController::overridePreference):
2475         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
2476         (LayoutTestController::isLoading):
2477         (LayoutTestController::setLoading):
2478         (LayoutTestController::shouldDumpAsText):
2479         (LayoutTestController::shouldDumpBackForwardList):
2480         (LayoutTestController::shouldDumpChildrenAsText):
2481         (LayoutTestController::shouldDumpDatabaseCallbacks):
2482         (LayoutTestController::shouldDumpStatusCallbacks):
2483         (LayoutTestController::shouldWaitUntilDone):
2484         (LayoutTestController::canOpenWindows):
2485         (LayoutTestController::shouldDumpTitleChanges):
2486         (LayoutTestController::waitForPolicy):
2487         (LayoutTestController::dumpAsText):
2488         (LayoutTestController::dumpChildFramesAsText):
2489         (LayoutTestController::dumpDatabaseCallbacks):
2490         (LayoutTestController::dumpStatusCallbacks):
2491         (LayoutTestController::setCanOpenWindows):
2492         (LayoutTestController::dumpBackForwardList):
2493         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2494         (LayoutTestController::display):
2495         (LayoutTestController::dumpTitleChanges):
2496         (LayoutTestController::dumpSelectionRect):
2497         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
2498         (TextInputController::TextInputController):
2499         (TextInputController::doCommand):
2500         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
2501         * DumpRenderTree/qt/WorkQueue.cpp:
2502         * DumpRenderTree/qt/WorkQueue.h:
2503         * DumpRenderTree/qt/WorkQueueItem.h:
2504         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
2505         (findFrameNamed):
2506         (LoadItem::invoke):
2507         (ReloadItem::invoke):
2508         (ScriptItem::invoke):
2509         (BackForwardItem::invoke):
2510         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
2511         * DumpRenderTree/qt/jsobjects.h:
2512
2513 2009-10-13  Dmitry Titov  <dimich@chromium.org>
2514
2515         Not reviewed, adding myself to the list of reviewers.
2516
2517         * Scripts/modules/committers.py:
2518
2519 2009-10-13  Anders Carlsson  <andersca@apple.com>
2520
2521         Reviewed by Sam Weinig.
2522
2523         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
2524
2525         Make the private browsing mode testable by the test plug-in.
2526         
2527         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2528         (pluginGetProperty):
2529         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2530         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2531         (NPP_New):
2532         (NPP_SetValue):
2533
2534 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
2535
2536         No review, just adding self to the list of reviewers.
2537
2538         * Scripts/modules/committers.py:
2539
2540 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
2541
2542         Reviewed by Adam Roben.
2543
2544         Web Inspector: Use proper web view in inspector layout
2545         tests for windows.
2546
2547         https://bugs.webkit.org/show_bug.cgi?id=30298
2548
2549         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2550         (LayoutTestController::showWebInspector):
2551         (LayoutTestController::closeWebInspector):
2552         (LayoutTestController::evaluateInWebInspector):
2553
2554 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
2555
2556         Reviewed by Sam Weinig.
2557
2558         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
2559         https://bugs.webkit.org/show_bug.cgi?id=29841
2560
2561         * DumpRenderTree/mac/DumpRenderTree.mm:
2562         (resetDefaultsToConsistentValues):
2563         * DumpRenderTree/win/DumpRenderTree.cpp:
2564         (resetDefaultsToConsistentValues):
2565
2566 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
2567
2568         Reviewed by Dimitri Glazkov.
2569
2570         Chromium Port - Windows
2571         https://bugs.webkit.org/show_bug.cgi?id=29969
2572
2573         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
2574         * Scripts/webkitdirs.pm:
2575
2576 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
2577
2578         Reviewed by Darin Adler.
2579
2580         jsc scripts cleanup and Qt/GTK fix
2581         https://bugs.webkit.org/show_bug.cgi?id=30288
2582
2583         Duplicated jscPath() moved to webkitdirs.pm.
2584         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
2585         Configuration added (release/debug) to path for Qt-port on Windows.
2586
2587         * Scripts/run-javascriptcore-tests:
2588         * Scripts/run-jsc:
2589         * Scripts/run-sunspider:
2590         * Scripts/sunspider-compare-results:
2591         * Scripts/webkitdirs.pm:
2592
2593 2009-10-11  Adam Barth  <abarth@webkit.org>
2594
2595         Unreviewed.  Add Collin to committers.py.
2596
2597         * Scripts/modules/committers.py:
2598
2599 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
2600
2601         wx build fix, add bindings to source/include dirs now that there are sources there.
2602
2603         * wx/build/settings.py:
2604
2605 2009-10-09  Mark Rowe  <mrowe@apple.com>
2606
2607         Reviewed by Brady Eidson.
2608
2609         Enable plug-in halting in DumpRenderTree.
2610
2611         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
2612         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
2613
2614         * DumpRenderTree/mac/DumpRenderTree.mm:
2615         (resetDefaultsToConsistentValues):
2616         * DumpRenderTree/mac/UIDelegate.mm:
2617         (-[UIDelegate webView:shouldHaltPlugin:]):
2618
2619 2009-10-08  Brady Eidson  <beidson@apple.com>
2620
2621         Reviewed by Dan Bernstein.
2622
2623         Ask the History Delegate to populate the visited links hash.
2624         <rdar://problem/7285293> and https://webkit.org/b/29904
2625
2626         Add the ability for LayoutTestController to clear all visited links.
2627         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
2628
2629         * DumpRenderTree/LayoutTestController.cpp:
2630         (LayoutTestController::LayoutTestController):
2631         (removeAllVisitedLinksCallback):
2632         (LayoutTestController::staticFunctions):
2633         * DumpRenderTree/LayoutTestController.h:
2634         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2635         (LayoutTestController::removeAllVisitedLinks):
2636
2637         * DumpRenderTree/mac/HistoryDelegate.mm:
2638         (-[HistoryDelegate populateVisitedLinksForWebView:]):
2639
2640         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2641         (LayoutTestController::removeAllVisitedLinks):
2642         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2643         (LayoutTestController::removeAllVisitedLinks):
2644         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2645         (LayoutTestController::removeAllVisitedLinks):
2646
2647
2648 2009-10-08  Daniel Bates  <dbates@webkit.org>
2649
2650         Reviewed by Adam Roben.
2651
2652         https://bugs.webkit.org/show_bug.cgi?id=30175
2653         
2654         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
2655         the OLE drag-and-drop return value like the function it emulates. Currently, 
2656         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
2657         whether the drag-and-drop operation was successful or was cancelled.
2658         
2659         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
2660         return value according to whether the drop operation was successful or not.
2661
2662         * DumpRenderTree/win/EventSender.cpp:
2663         (doMouseUp): Added parameter oleDragAndDropReturnValue.
2664         (replaySavedEvents): Ditto.
2665         * DumpRenderTree/win/EventSender.h:
2666         * DumpRenderTree/win/UIDelegate.cpp:
2667         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
2668
2669 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
2670
2671         Reviewed by Xan Lopez.
2672
2673         [GTK] Added support for a parameter setting the button that was
2674         pressed in the mouseDown function.
2675         https://bugs.webkit.org/show_bug.cgi?id=30220
2676
2677         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2678
2679 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
2680
2681         Reviewed by Xan Lopez.
2682
2683         [GTK] Added a line to the bottom of the expected result to match
2684         the output of the test.
2685         https://bugs.webkit.org/show_bug.cgi?id=30220
2686
2687         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
2688         expected.txt:
2689
2690 2009-10-08  Adam Roben  <aroben@apple.com>
2691
2692         Use QueryInterface to get IWebInspectorPrivate
2693
2694         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
2695         accessed in a more standard way
2696
2697         Reviewed by John Sullivan and Tim Hatcher.
2698
2699         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2700         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
2701         by calling IWebViewPrivate::inspector, then use QueryInterface to get
2702         to the IWebInspectorPrivate interface.
2703
2704 2009-10-07  Adam Roben  <aroben@apple.com>
2705
2706         Implement DRT support for origin whitelisting
2707
2708         Fixes <http://webkit.org/b/30185>.
2709
2710         Reviewed by Eric Seidel.
2711
2712         * DumpRenderTree/win/DumpRenderTree.cpp:
2713         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
2714         whitelist, to match Mac DRT.
2715         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2716         (LayoutTestController::whiteListAccessFromOrigin): Call through to
2717         IWebViewPrivate::whiteListAccessFromOrigin.
2718
2719 2009-10-07  Brady Eidson  <beidson@apple.com>
2720
2721         Reviewed by Darin Adler.
2722
2723         Send title changes to the global history delegate.
2724         <rdar://problem/7285293> and https://webkit.org/b/29904
2725
2726         * DumpRenderTree/mac/HistoryDelegate.mm:
2727         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
2728
2729 2009-10-07  Adam Barth  <abarth@webkit.org>
2730
2731         Unreviewed.  Remove some folks from committers.py who were listed on
2732         the WebKit Team wiki page but who weren't actually listed as commit+.
2733         At some point, we should coorelate this list with the committers
2734         mailing list.
2735
2736         * Scripts/modules/committers.py:
2737
2738 2009-10-07  Adam Barth  <abarth@webkit.org>
2739
2740         Unreviewed.  Import a bunch of committers from the WebKit Team page on
2741         the wiki into committers.py.
2742
2743         * Scripts/modules/committers.py:
2744
2745 2009-10-07  Adam Barth  <abarth@webkit.org>
2746
2747         Unreviewed.  Added Aaron Boodman to committers.py.
2748
2749         * Scripts/modules/committers.py:
2750
2751 2009-10-07  Evan Martin  <evan@chromium.org>
2752
2753         Reviewed by Darin Adler.
2754
2755         Add API to LayoutTestController for re/setting the system locale.
2756         https://bugs.webkit.org/show_bug.cgi?id=18994
2757
2758         * DumpRenderTree/LayoutTestController.cpp:
2759         (setLocaleCallback):
2760         (LayoutTestController::staticFunctions):
2761         (LayoutTestController::setLocale):
2762         * DumpRenderTree/LayoutTestController.h:
2763
2764 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
2765
2766         Reviewed by Jan Alonzo.
2767
2768         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
2769         https://bugs.webkit.org/show_bug.cgi?id=29689
2770
2771         Build fix by adding -lfontconfig for DumpRenderTree.
2772
2773         * GNUmakefile.am:
2774
2775 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2776
2777         Reviewed by Simon Hausmann.
2778
2779         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
2780
2781         * Scripts/run-webkit-tests:
2782
2783 2009-10-07  Xan Lopez  <xlopez@igalia.com>
2784
2785         Reviewed by Gustavo Noronha.
2786
2787         "delete" in EventSender is the backspace key, not the delete one.
2788
2789         * DumpRenderTree/gtk/EventSender.cpp:
2790         (keyDownCallback):
2791
2792 2009-10-07  Xan Lopez  <xlopez@igalia.com>
2793
2794         Reviewed by Gustavo Noronha.
2795
2796         getChildrenWithRange expects as last parameter the end index, not
2797         the length of the range. Correct this and clarify the variable
2798         names to reflect how the code works.
2799
2800         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2801         (AccessibilityUIElement::getChildrenWithRange):
2802         (AccessibilityUIElement::getChildAtIndex):
2803
2804 2009-10-06  Mark Rowe  <mrowe@apple.com>
2805
2806         Reviewed by Simon Fraser.
2807
2808         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
2809
2810         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
2811         the fact we have already changed the working directory to the top of the open source tree.
2812
2813 2009-10-06  Julie Parent  <jparent@chromium.org>
2814
2815         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
2816         rather than my committer email.
2817
2818         * Scripts/modules/committers.py:
2819
2820 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2821
2822         Reviewed by Eric Seidel.
2823
2824         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
2825
2826         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
2827         it after each layout test as it should do, making the DRT dump additional output
2828         for all of the subsequent layout tests.
2829
2830         * DumpRenderTree/qt/jsobjects.cpp:
2831         (LayoutTestController::reset):
2832
2833 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2834
2835         Reviewed by Simon Hausmann.
2836
2837         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
2838         fast/dom/assign-to-window-status.html test, which is passing as a result.
2839
2840         https://bugs.webkit.org/show_bug.cgi?id=30127
2841
2842         * DumpRenderTree/qt/DumpRenderTree.cpp:
2843         (WebCore::DumpRenderTree::DumpRenderTree):
2844         (WebCore::DumpRenderTree::statusBarMessage):
2845         * DumpRenderTree/qt/DumpRenderTree.h:
2846         * DumpRenderTree/qt/jsobjects.h:
2847         (LayoutTestController::shouldDumpStatusCallbacks):
2848         (LayoutTestController::dumpStatusCallbacks):
2849
2850 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2851
2852         Reviewed by Simon Hausmann.
2853
2854         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
2855         ignores the argument indicating which mouse button to trigger.
2856         https://bugs.webkit.org/show_bug.cgi?id=30048
2857
2858         This affects the fast/events/mouse-click-events.html layout test.
2859
2860         * DumpRenderTree/qt/jsobjects.cpp:
2861         (EventSender::mouseDown):
2862         (EventSender::mouseUp):
2863         * DumpRenderTree/qt/jsobjects.h:
2864
2865 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2866
2867         Reviewed by Simon Hausmann.
2868
2869         [Qt] Fix the EventSender::keyDown() implementation
2870         https://bugs.webkit.org/show_bug.cgi?id=30043
2871
2872         It should post both a key press event and a key release event,
2873         just like other ports do.
2874
2875         * DumpRenderTree/qt/jsobjects.cpp:
2876         (EventSender::keyDown):
2877
2878 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
2879
2880         wx build fix. Add jpeg to the list of libs to link against.
2881
2882         * wx/build/settings.py:
2883
2884 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
2885
2886         Reviewed by Simon Hausmann.
2887
2888         [Qt] EventSender::keyDown() cannot send function-key events.
2889         https://bugs.webkit.org/show_bug.cgi?id=30044
2890
2891         This affects the fast/events/keydown-function-keys.html layout test.
2892
2893         * DumpRenderTree/qt/jsobjects.cpp:
2894         (EventSender::keyDown):
2895
2896 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
2897
2898         Added --wx-compiler-prefix waf option to allow building wxWebKit with
2899         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
2900
2901         * wx/build/settings.py:
2902         * wx/build/wxpresets.py:
2903
2904 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
2905
2906         Reviewed by Timothy Hatcher.
2907
2908         Web Inspector: add testing harness for Web Inspector.
2909
2910         https://bugs.webkit.org/show_bug.cgi?id=30010
2911
2912         * DumpRenderTree/LayoutTestController.cpp:
2913         (showWebInspectorCallback):
2914         (closeWebInspectorCallback):
2915         (evaluateInWebInspectorCallback):
2916         (LayoutTestController::staticFunctions):
2917         * DumpRenderTree/LayoutTestController.h:
2918         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2919         (LayoutTestController::showWebInspector):
2920         (LayoutTestController::closeWebInspector):
2921         (LayoutTestController::evaluateInWebInspector):
2922         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2923         (LayoutTestController::showWebInspector):
2924         (LayoutTestController::closeWebInspector):
2925         (LayoutTestController::evaluateInWebInspector):
2926         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2927         (LayoutTestController::showWebInspector):
2928         (LayoutTestController::closeWebInspector):
2929         (LayoutTestController::evaluateInWebInspector):
2930         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2931         (LayoutTestController::showWebInspector):
2932         (LayoutTestController::closeWebInspector):
2933         (LayoutTestController::evaluateInWebInspector):
2934
2935 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2936
2937         Reviewed by Ariyha Hidayat.
2938
2939         Pass arguments to system() as a string instead of array
2940
2941         When passed as an array entries with a space fail to translate
2942         to two arguments to the child process, so instead of manually
2943         splitting all the entries in @buildArgs we pass the whole thing
2944         as a string instead.
2945
2946         * Scripts/webkitdirs.pm:
2947
2948 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
2949
2950         Reviewed by David Levin.
2951
2952         check-webkit-style misses whitespace errors for operators:
2953         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
2954         https://bugs.webkit.org/show_bug.cgi?id=30021
2955
2956         * Scripts/modules/cpp_style.py:
2957         Added the operators mentioned above to the same list as == and !=.
2958
2959 2009-10-02  Julie Parent  <jparent@chromium.org>
2960
2961         Unreviewed.
2962
2963         Adding myself and Ojan Vafai as committers, because we are committers.
2964
2965         * Scripts/modules/committers.py:
2966
2967 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
2968
2969         Reviewed by Adam Roben.
2970
2971         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
2972         this will help the patch merging process when TryBots are used.
2973
2974         * Scripts/svn-create-patch:
2975
2976 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
2977
2978         Reviewed by Simon Hausmann.
2979
2980         [Qt] Implement layoutTestController.overridePreference().
2981         https://bugs.webkit.org/show_bug.cgi?id=29970
2982
2983         * DumpRenderTree/qt/DumpRenderTree.cpp:
2984         (WebCore::WebPage::WebPage):
2985         (WebCore::WebPage::resetSettings):
2986         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2987         * DumpRenderTree/qt/jsobjects.cpp:
2988         (LayoutTestController::reset):
2989         (LayoutTestController::setPrivateBrowsingEnabled):
2990         (LayoutTestController::setPopupBlockingEnabled):
2991         (LayoutTestController::overridePreference):
2992         * DumpRenderTree/qt/jsobjects.h:
2993
2994 2009-10-01  Chris Marrin  <cmarrin@apple.com>
2995
2996         Reviewed by Oliver Hunt.
2997
2998         Turn on ENABLE_3D_CANVAS in TOT
2999         https://bugs.webkit.org/show_bug.cgi?id=29906
3000
3001         * Scripts/build-webkit:
3002
3003 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3004
3005         Rubberstamped by Simon Hausmann.
3006
3007         Enable HTTP tests for Qt
3008
3009         * Scripts/run-webkit-tests:
3010
3011 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3012
3013         Reviewed by Dimitri Glazkov.
3014
3015         build-webkit --chromium now also works on cygwin.
3016
3017         https://bugs.webkit.org/show_bug.cgi?id=29973
3018
3019         * Scripts/webkitdirs.pm:
3020
3021 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3022
3023         Reviewed by Simon Hausmann.
3024
3025         [Qt] Don't use TCmalloc in DumpRenderTree
3026         https://bugs.webkit.org/show_bug.cgi?id=27029
3027
3028         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3029
3030         * DumpRenderTree/qt/DumpRenderTree.pro:
3031
3032 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3033
3034         Reviewed by Simon Hausmann.
3035
3036         [Qt] Implement eventSender.scheduleAsynchronousClick().
3037
3038         https://bugs.webkit.org/show_bug.cgi?id=29931
3039
3040         * DumpRenderTree/qt/jsobjects.cpp:
3041         (EventSender::scheduleAsynchronousClick):
3042         * DumpRenderTree/qt/jsobjects.h:
3043
3044 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3045
3046         Reviewed by Simon Hausmann.
3047
3048         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
3049         fast/events/open-window-from-another-frame.html from the Skipped list.
3050
3051         https://bugs.webkit.org/show_bug.cgi?id=29930
3052
3053         * DumpRenderTree/qt/jsobjects.cpp:
3054         (LayoutTestController::setPopupBlockingEnabled):
3055         * DumpRenderTree/qt/jsobjects.h:
3056
3057 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
3058
3059         Unreviewed.
3060
3061         Added myself to the list of committers.
3062
3063         * Scripts/modules/committers.py:
3064
3065 2009-09-30  Eric Seidel  <eric@webkit.org>
3066
3067         No review, just adding Geoff to the list of reviewers.
3068
3069         * Scripts/modules/committers.py:
3070
3071 2009-09-30  Dan Bernstein  <mitz@apple.com>
3072
3073         Reviewed by Sam Weinig.
3074
3075         Added the WebKit Layout Tests fonts that are referenced in
3076         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
3077
3078         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
3079         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
3080
3081 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3082
3083         Reviewed by David Kilzer.
3084
3085         Make sunspider scripts work on Windows platform.
3086         https://bugs.webkit.org/show_bug.cgi?id=29656
3087
3088         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
3089         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
3090         * Scripts/webkitdirs.pm: currentPerlPath() added.
3091
3092 2009-09-29  Brady Eidson  <beidson@apple.com>
3093
3094         Rubberstamped by Dan Bernstein.
3095
3096         Fix license and some sorting in new files.
3097
3098         * DumpRenderTree/mac/HistoryDelegate.h:
3099         * DumpRenderTree/mac/HistoryDelegate.mm:
3100
3101 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
3102
3103         Reviewed by David Kilzer.
3104
3105         Fixed how error codes are handled.
3106         https://bugs.webkit.org/show_bug.cgi?id=29898
3107
3108         * Scripts/update-webkit:
3109         * Scripts/update-webkit-chromium:
3110
3111 2009-09-29  Brady Eidson  <beidson@apple.com>
3112
3113         Reviewed by John Sullivan.
3114
3115         Updated way-out-of-date sorting throughout the dump methods/flags.
3116
3117         * DumpRenderTree/LayoutTestController.cpp:
3118         (LayoutTestController::LayoutTestController):
3119         (dumpAsPDFCallback):
3120         (dumpAsTextCallback):
3121         (dumpFrameLoadCallbacksCallback):
3122         (dumpResourceLoadCallbacksCallback):
3123         (LayoutTestController::staticFunctions):
3124
3125         * DumpRenderTree/LayoutTestController.h:
3126         (LayoutTestController::dumpAsText):
3127         (LayoutTestController::setDumpAsText):
3128         (LayoutTestController::dumpFrameLoadCallbacks):
3129         (LayoutTestController::setDumpFrameLoadCallbacks):
3130         (LayoutTestController::dumpSelectionRect):
3131         (LayoutTestController::setDumpSelectionRect):
3132         (LayoutTestController::dumpSourceAsWebArchive):
3133         (LayoutTestController::setDumpSourceAsWebArchive):
3134         (LayoutTestController::dumpStatusCallbacks):
3135         (LayoutTestController::setDumpStatusCallbacks):
3136         (LayoutTestController::dumpTitleChanges):
3137         (LayoutTestController::setDumpTitleChanges):
3138         (LayoutTestController::dumpWillCacheResponse):
3139         (LayoutTestController::setDumpWillCacheResponse):
3140
3141 2009-09-29  Brady Eidson  <beidson@apple.com>
3142
3143         Reviewed by John Sullivan.
3144
3145         WebKit Mac API should provide a delegate interface for global history.
3146         <rdar://problem/7042773> and https://webkit.org/b/29904
3147
3148         Adding the dumping of global history delegate callbacks.
3149
3150         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3151
3152         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
3153         * DumpRenderTree/mac/DumpRenderTree.mm:
3154         (createWebViewAndOffscreenWindow):
3155         (allocateGlobalControllers):
3156         (shouldLogFrameLoadDelegates):
3157         (shouldLogHistoryDelegates):
3158         (runTest):
3159
3160         Dump history delegate callbacks:
3161         * DumpRenderTree/mac/HistoryDelegate.h: Added.
3162         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
3163         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
3164         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
3165         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
3166
3167 2009-09-29  Daniel Bates  <dbates@webkit.org>
3168
3169         Reviewed by Adam Roben.
3170
3171         https://bugs.webkit.org/show_bug.cgi?id=28902
3172         
3173         Fixes an issue where the drop effect returned by Window Dump Render Tree 
3174         was always DROPEFFECT_NONE (since it was hard coded to do so).
3175         
3176         This patch corrects this issue by determining the actual drop effect 
3177         performed by the corresponding drag-and-drop operation so that we can 
3178         return it.
3179
3180         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
3181         (DraggingInfo::DraggingInfo):
3182         (DraggingInfo::performedDropEffect): Added method.
3183         (DraggingInfo::setPerformedDropEffect): Added method.
3184         * DumpRenderTree/win/EventSender.cpp:
3185         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
3186         Moved delete draggingInfo to UIDelegate::doDragDrop.
3187         * DumpRenderTree/win/UIDelegate.cpp:
3188         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
3189
3190 2009-09-29  Dan Bernstein  <mitz@apple.com>
3191
3192         Reviewed by Adam Roben.
3193
3194         Remove copying of unnecessary or nonexistent files from the ImageDiff
3195         post-build event.
3196
3197         * DumpRenderTree/win/ImageDiff.vcproj:
3198
3199 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3200
3201         Reviewed by David Kilzer.
3202
3203         [Qt] Make build-webkit script work on Windows
3204         https://bugs.webkit.org/show_bug.cgi?id=29802
3205
3206         * Scripts/run-webkit-tests:
3207         * Scripts/webkitdirs.pm:
3208          - Removed unnecessary -p switch for mkdir on Windows.
3209          - Use canonical path, which uses slashes or backslashes depends on platform.
3210          - isWindows() only test for Windows and not for Cyqwin.
3211
3212 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3213
3214         Reviewed by Simon Hausmann.
3215
3216         Fix time measurement in build-webkit after refactoring done in r48853.
3217
3218         * Scripts/build-webkit:
3219
3220 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3221
3222         Reviewed by Tor Arne Vestbø.
3223
3224         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
3225         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
3226
3227         * DumpRenderTree/qt/DumpRenderTree.cpp:
3228         (WebCore::WebPage::WebPage):
3229
3230 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
3231
3232         Reviewed by Simon Hausmann.
3233
3234         [Qt] Implement eventSender.contextClick().
3235         https://bugs.webkit.org/show_bug.cgi?id=29821
3236
3237         * DumpRenderTree/qt/jsobjects.cpp:
3238         (EventSender::contextClick):
3239         * DumpRenderTree/qt/jsobjects.h:
3240
3241 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3242
3243         Reviewed by Eric Seidel.
3244
3245         Add experimentalWebSocketsEnabled in WebPreferences.
3246         https://bugs.webkit.org/show_bug.cgi?id=28941
3247
3248         * DumpRenderTree/mac/DumpRenderTree.mm:
3249         (resetDefaultsToConsistentValues):
3250         * DumpRenderTree/win/DumpRenderTree.cpp:
3251         (resetDefaultsToConsistentValues):
3252
3253 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
3254
3255         Reviewed by David Kilzer.
3256
3257         Integrated chromium port building into webkit tools update-webkit and
3258         build-webkit.
3259
3260         https://bugs.webkit.org/show_bug.cgi?id=29749
3261
3262         * Scripts/build-webkit: When --chromium is specified, will build
3263           the chromium port (currently only Mac is supported).
3264         * Scripts/update-webkit: When --chromium is specified, delegates to
3265           update-webkit-chromium.
3266         * Scripts/webkitdirs.pm: Added chromium specific defs.
3267         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
3268           chromium port's dependencies and update its project files.
3269
3270 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3271
3272         Unreviewed.
3273
3274         Add myself to list of committers.
3275
3276         * Scripts/modules/committers.py:
3277
3278 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3279
3280         Reviewed by Darin Adler.
3281
3282         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
3283         https://bugs.webkit.org/show_bug.cgi?id=29771
3284
3285         * Scripts/run-webkit-tests:
3286
3287 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3288
3289         Reviewed by Simon Hausmann.
3290
3291         [Qt] Implement layoutTestController.waitForPolicyDelegate.
3292         https://bugs.webkit.org/show_bug.cgi?id=25037
3293
3294         * DumpRenderTree/qt/DumpRenderTree.cpp:
3295         (WebCore::WebPage::acceptNavigationRequest):
3296         * DumpRenderTree/qt/DumpRenderTree.pro:
3297         * DumpRenderTree/qt/jsobjects.cpp:
3298         (LayoutTestController::reset):
3299         (LayoutTestController::notifyDone):
3300         (LayoutTestController::waitForPolicyDelegate):
3301         * DumpRenderTree/qt/jsobjects.h:
3302         (LayoutTestController::waitForPolicy):
3303
3304 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3305
3306         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
3307
3308         Reviewed by Eric Seidel.
3309
3310         The -o|--open switch uses the open(1) command on Mac OS X to
3311         open the bug URL in the default web browser.  If there are
3312         similar mechanisms on other platforms, they may be added later.
3313
3314         * Scripts/mark-bug-fixed:
3315         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
3316         options.
3317         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
3318         code into main() and extracted prompting code into
3319         _prompt_user_for_correctness().
3320         (MarkBugFixed._open_bug_in_web_browser): Added.
3321         (MarkBugFixed._prompt_user_for_correctness): Added.
3322         (MarkBugFixed.main): Added logging code from
3323         _determine_bug_id_and_svn_revision().  Added code to call
3324         _open_bug_in_web_browser() if the switch is set.  Added code to
3325         call _prompt_user_for_correctness() when needed.
3326         * Scripts/modules/bugzilla.py:
3327         (Bugzilla.short_bug_url_for_bug_id): Added.
3328
3329 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3330
3331         svn-unapply and svn-apply don't work when used outside multiple svn working directories
3332
3333         <http://webkit.org/b/29744>
3334         <rdar://problem/7252905>
3335
3336         Reviewed by Eric Seidel.
3337
3338         Some users have a workflow where svn-create-patch, svn-apply and
3339         svn-unapply are used outside of multiple svn working
3340         directories.  Instead of aborting the scripts in these cases,
3341         print a warning and assume that Subversion is being used.
3342
3343         * Scripts/VCSUtils.pm:
3344         (determineVCSRoot): Call warn() instead of die() if both isGit()
3345         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
3346         to enforce the assumption about Subversion, then return
3347         determineSVNRoot().
3348         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
3349         VCSUtils.pm.  They both already cache their values and checking
3350         here is redundant since determineVCSRoot() is called later.
3351
3352 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
3353
3354         Reviewed by Gustavo Noronha.
3355
3356         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3357         https://bugs.webkit.org/show_bug.cgi?id=29689
3358
3359         Load test fonts through FontConfig before each test.
3360         This ensures a more proper rendering of the tests.
3361
3362         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3363         (initializeFonts):
3364         (runTest):
3365         (main):
3366         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
3367         * GNUmakefile.am:
3368
3369 2009-09-25  David Kilzer  <ddkilzer@apple.com>
3370
3371         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
3372
3373         Reviewed by Eric Seidel.
3374
3375         * Scripts/mark-bug-fixed:
3376         (MarkBugFixed.__init__): Added -u|--update-only switch to list
3377         of parse options.
3378         (MarkBugFixed.main): When -u|--update-only is specified, add a
3379         comment to the bug without marking it Resolved/Fixed.
3380
3381 2009-09-25  Darin Adler  <darin@apple.com>
3382
3383         Reviewed by Geoffrey Garen.
3384
3385         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
3386         out, just as we do for the resources directory.
3387
3388 2009-09-25  Adam Barth  <abarth@webkit.org>
3389
3390         Unreviewed.  Added Tony to committers.py because he's a
3391         committer now.
3392
3393         * Scripts/modules/committers.py:
3394
3395 2009-09-25  Eric Seidel  <eric@webkit.org>
3396
3397         Reviewed by Simon Fraser.
3398
3399         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
3400         https://bugs.webkit.org/show_bug.cgi?id=28624
3401
3402         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
3403
3404         * DumpRenderTree/mac/DumpRenderTree.mm:
3405         (resetDefaultsToConsistentValues):
3406
3407 2009-09-25  Eric Seidel  <eric@webkit.org>
3408
3409         Reviewed by Adam Barth.
3410
3411         commit-queue should auto-retry patches which fail to commit due to out of date files
3412         https://bugs.webkit.org/show_bug.cgi?id=28316
3413
3414         * Scripts/bugzilla-tool:
3415          - Handle new CheckoutNeedsUpdate exception.
3416         * Scripts/modules/logging_unittest.py:
3417          - Call the ScriptError constructor correctly (this test had regressed).
3418         * Scripts/modules/scm.py:
3419          - Added the ability to define custom error handlers for run_command
3420            and added a commit_error_handler which throws CheckoutNeedsUpdate
3421            instead of ScriptError.
3422          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
3423         * Scripts/modules/scm_unittest.py:
3424          - Added tests of new error handlers.
3425
3426 2009-09-25  Eric Seidel  <eric@webkit.org>
3427
3428         Reviewed by Adam Barth.
3429
3430         commit-queue should give better feedback when failing a patch
3431         https://bugs.webkit.org/show_bug.cgi?id=29316
3432
3433         * Scripts/bugzilla-tool:
3434          - Update ScriptError uses to the new constructor format.
3435          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
3436            so that we can print to both stdout as well as an output buffer for error reporting.
3437          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
3438          - Use e.message_with_output() when failing a patch (this is the real fix here).
3439            I also removed use of "This patch will require manual commit." as that's not always true.
3440          - Add missing word "bug" from log message.
3441         * Scripts/modules/scm.py:
3442          - Make ScriptError save a bunch more data so that error messages can be nicer.
3443          - Update ScriptError callers.
3444
3445 2009-09-24  John Gregg  <johnnyg@google.com>
3446
3447         Reviewed by Eric Seidel.
3448
3449         Enable switch for notifications (experimental) in Page Settings
3450         https://bugs.webkit.org/show_bug.cgi?id=28930
3451
3452         Now that desktop notifications are controlled by run-time switch,
3453         set that switch to true for DumpRenderTree.
3454
3455         * DumpRenderTree/mac/DumpRenderTree.mm:
3456         (resetDefaultsToConsistentValues):
3457         * DumpRenderTree/win/DumpRenderTree.cpp:
3458         (resetDefaultsToConsistentValues):
3459         * DumpRenderTree/win/UIDelegate.cpp:
3460         (UIDelegate::QueryInterface):
3461
3462 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
3463
3464         wx build fix. SnowLeopard fixes for Mac dependencies.
3465
3466         * wx/build/build_utils.py:
3467         * wx/build/settings.py:
3468         * wx/install-unix-extras:
3469
3470 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3471
3472         Reviewed by Oliver Hunt.
3473
3474         Add support for DRT to send mouse wheel events.
3475
3476         https://bugs.webkit.org/show_bug.cgi?id=29348
3477         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
3478
3479         * DumpRenderTree/gtk/EventSender.cpp:
3480         (mouseWheelToCallback):
3481
3482 2009-09-17  Eric Seidel  <eric@webkit.org>
3483
3484         Reviewed by David Levin.
3485
3486         commit-queue needs web-based status reporting
3487         https://bugs.webkit.org/show_bug.cgi?id=29307
3488
3489         Add a first-pass web-based status for the commit-queue.
3490         The bot is currently reachable at:
3491         http://webkit-commit-queue.appspot.com/
3492
3493         * CommitQueueStatus/app.yaml: Added.
3494          - Application description file required by App Engine.
3495         * CommitQueueStatus/filters/__init__.py: Added.
3496          - Required by python to treat 'filters' as a module.
3497         * CommitQueueStatus/filters/webkit_extras.py: Added.
3498          - Support for turning 'bug 123' and 'patch 123' into links.
3499            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
3500         * CommitQueueStatus/index.html: Added.
3501         * CommitQueueStatus/index.yaml: Added.
3502          - Some auto-generated file from app engine.
3503         * CommitQueueStatus/queue_status.py: Added.
3504          - The core logic of this bot.  We could eventually split this file out into pieces.
3505         * CommitQueueStatus/stylesheets/main.css: Added.
3506          - Some basic lame-o CSS to make the page look less awful.
3507         * CommitQueueStatus/update_status.html: Added.
3508          - The form that the commit-queue (or a human) can use to update the status.
3509         * Scripts/bugzilla-tool:
3510          - Add some very basic update_status calls.
3511         * Scripts/modules/statusbot.py: Added.
3512          - Knows how to post to the CommitQueueStatus web application.
3513
3514 2009-09-24  David Kilzer  <ddkilzer@apple.com>
3515
3516         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
3517
3518         Reviewed by Adam Roben.
3519
3520         * Scripts/mark-bug-fixed:
3521         (MarkBugFixed.__init__): Added -m|--comment switch to list of
3522         parse options.
3523         (MarkBugFixed.main): When specified, prepend comment from
3524         -m|--comment command-line switch to the bug comment.
3525
3526 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3527
3528         Reviewed by Jan Alonzo.
3529
3530         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
3531         https://bugs.webkit.org/show_bug.cgi?id=29693
3532
3533         Show the window, to be able to synthesize events correctly.
3534
3535         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3536         (runTest):
3537         (main):
3538
3539 2009-09-24  Oliver Hunt  <oliver@apple.com>
3540
3541         Reviewed by NOBODY(rollout)
3542
3543         Roll out r48712 as it is incorrect.
3544
3545         * DumpRenderTree/mac/ObjCController.m:
3546         (+[ObjCController isSelectorExcludedFromWebScript:]):
3547         (+[ObjCController webScriptNameForSelector:]):
3548
3549 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
3550
3551         Reviewed by Eric Seidel.
3552
3553         https://bugs.webkit.org/show_bug.cgi?id=29005
3554         The indices of RuntimeArray should be enumerated like for a regular array.
3555
3556         * DumpRenderTree/mac/ObjCController.m:
3557         (+[ObjCController isSelectorExcludedFromWebScript:]):
3558         (+[ObjCController webScriptNameForSelector:]):
3559         (-[ObjCController arrayOfString]):
3560
3561 2009-09-23  David Kilzer  <ddkilzer@apple.com>
3562
3563         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
3564
3565         Reviewed by Darin Adler.
3566
3567         Also fixed a bug where specifying a revision on the command-line
3568         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
3569
3570         * Scripts/bugzilla-tool: Updated module import statements.
3571         (parse_bug_id): Removed.  Moved to bugzilla.py.
3572         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
3573         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
3574         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
3575         (BugzillaTool.__init__): Removed mark-fixed subcommand.
3576         * Scripts/mark-bug-fixed: Added.
3577         * Scripts/modules/bugzilla.py:
3578         (parse_bug_id): Added.  Moved from bugzilla-tool.
3579         * Scripts/modules/comments.py: Added.
3580         (bug_comment_from_svn_revision): Added.  Moved from bugzilla-tool.
3581         (bug_comment_from_commit_text): Added.  Moved from bugzilla-tool.
3582
3583 2009-09-23  Marshall Culpepper  <mculpepper@appcelerator.com>
3584
3585         Reviewed by Eric Seidel.
3586         
3587          jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
3588          "false" in non-implemented stub for setAlwaysAcceptCookies.
3589          https://bugs.webkit.org/show_bug.cgi?id=29661
3590
3591         * DumpRenderTree/win/DumpRenderTree.vcproj:
3592         * DumpRenderTree/win/DumpRenderTree.cpp:
3593
3594 2009-09-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3595
3596         Reviewed by Xan Lopez.
3597
3598         [GTK] need to dump number of pending unload handlers
3599         https://bugs.webkit.org/show_bug.cgi?id=29685
3600
3601         Implement dumping of the number of pending unload handlers.
3602
3603         The following tests will pass:
3604
3605           fast/loader/unload-form-about-blank.html
3606           fast/loader/unload-form-post-about-blank.html
3607           fast/loader/unload-form-post.html
3608           fast/loader/unload-form.html
3609           fast/loader/unload-hyperlink.html
3610           fast/loader/unload-javascript-url.html
3611           fast/loader/unload-reload.html
3612           fast/loader/unload-window-location.html
3613
3614         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3615         (getFrameNameSuitableForTestResult):
3616         (webViewLoadFinished):
3617
3618 2009-09-22  Shinichiro Hamaji  <hamaji@chromium.org>
3619
3620         Reviewed by Eric Seidel.
3621
3622         js tests should move into jstests subdirectory instead of resources/
3623         https://bugs.webkit.org/show_bug.cgi?id=25880
3624
3625         Remove support of resources directory.
3626
3627         * Scripts/make-script-test-wrappers:
3628
3629 2009-09-22  Eric Seidel  <eric@webkit.org>
3630
3631         No review, only fixing typo (missing space character).
3632
3633         Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220
3634
3635         * Scripts/run-webkit-tests:
3636
3637 2009-09-22  Eric Seidel  <eric@webkit.org>
3638
3639         Reviewed by Darin Adler.
3640
3641         run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
3642         https://bugs.webkit.org/show_bug.cgi?id=29220
3643
3644         * Scripts/run-webkit-tests:
3645
3646 2009-09-22  Eric Seidel  <eric@webkit.org>
3647
3648         Reviewed by David Kilzer.
3649
3650         svn-apply can't handle single-line binary file additions
3651         https://bugs.webkit.org/show_bug.cgi?id=29100
3652
3653         Fixed the regexp and added a unit test.
3654
3655         * Scripts/modules/scm_unittest.py:
3656         * Scripts/svn-apply:
3657
3658 2009-09-11  Eric Seidel  <eric@webkit.org>
3659
3660         Reviewed by David Kilzer.
3661
3662         post-diff and post-commits should be able to find bug urls in ChangeLogs.
3663         https://bugs.webkit.org/show_bug.cgi?id=29206
3664
3665         * Scripts/bugzilla-tool:
3666          - Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
3667          - Rename --no-comment to --add-log-as-comment and reverse behavior.
3668            Comments tend to just be noise.  I'll eventually remove this argument if no one uses it.
3669          - Split out code into helper functions to try and make execute() more legible.
3670          - Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
3671          - Fallback to bug urls in commit diffs, instead of just in commit messages,
3672            meaning post-commits will now find bug urls in ChangeLogs.
3673
3674 2009-09-21  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3675
3676         Reviewed by Maciej Stachowiak.
3677
3678         --parse-only parameter wasn't passed to SunSpider/sunspider script.
3679         https://bugs.webkit.org/show_bug.cgi?id=29611
3680
3681