WebKitTools/ChangeLog

   1 2008-02-26  Jessica Kahn  <jess@apple.com>
   2
   3         Reviewed by Darin.
   4
   5         * Scripts/gdb-safari: Set WEBKIT_UNSET_DYLD_FRAMEWORK_PATH in gdb's environment,
   6         so that Safari inherits it when launched. Preexisting code in WebKit checks this
   7         environment variable, and if set, unsets DYLD_FRAMEWORK_PATH, so that applications
   8         launched by Safari continue to use the standard system WebKit.
   9
  10 2008-02-25  Adam Roben  <aroben@apple.com>
  11
  12         Fix run-webkit-tests after r30394
  13
  14         * Scripts/webkitdirs.pm: Never append _debug to FindSafari's
  15         executable name.
  16
  17 2008-02-24  Darin Adler  <darin@apple.com>
  18
  19         * Scripts/do-webcore-rename: Make some updates based on a trial run of
  20         the renaming script.
  21
  22 2008-02-24  Darin Adler  <darin@apple.com>
  23
  24         * Scripts/do-webcore-rename: More renaming plans.
  25
  26 2008-02-23  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
  27
  28         Rubber stamped by Darin.
  29
  30         Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
  31         whitespaces introduced in the previous commit.
  32
  33         * GNUmakefile.am:
  34
  35 2008-02-23  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
  36
  37         Rubber-stamped by Darin.
  38
  39         * GNUmakefile.am: Add both GLOBALDEPS and WEBKITDEPS instead of DEPENDENCIES.
  40
  41 2008-02-23  David Kilzer  <ddkilzer@apple.com>
  42
  43         Please clarify licensing for some files
  44         <http://bugs.webkit.org/show_bug.cgi?id=14970>
  45
  46         Reviewed by Darin.
  47
  48         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Added
  49         copyright statement.  Replaced license with newer Apple BSD-style license.
  50         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Ditto.
  51         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Ditto.
  52         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Ditto.
  53         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Ditto.
  54         * DumpRenderTree/win/TestNetscapePlugin/main.c: Ditto.
  55         * mangleme/LICENSE: Added (LGPL).
  56
  57 2008-02-22  Anders Carlsson  <andersca@apple.com>
  58
  59         Reviewed by Adam.
  60
  61         <rdar://problem/5748781>
  62         https://bugs.webkit.org/show_bug.cgi?id=17413
  63         REGRESSION: Latest Nightly doesn't load Java plugin w/Safari 3.1b
  64
  65         Copy the Java plug-in over to the new location.
  66
  67         * FindSafari/FindSafari.cpp:
  68         (_tmain):
  69
  70 2008-02-22  Anders Carlsson  <andersca@apple.com>
  71
  72         Reviewed by Adam.
  73
  74         <rdar://problem/5747325> REGRESSION: HTTP layout tests hang
  75
  76         * DumpRenderTree/win/DumpRenderTree.cpp:
  77         (runTest):
  78         Init the URL request with the correct timeout.
  79
  80 2008-02-21  Mike Auty  <mike.auty@gmail.com>
  81
  82         Reviewed by Alp Toker.
  83
  84         http://bugs.webkit.org/show_bug.cgi?id=17445
  85         [GTK] WebKit doesn't compile with LDFLAGS="-Wl,--as-needed"
  86
  87         GTK+/autotools build system improvements
  88
  89         The GNUmakefile.am files make use of the LDFLAGS variable to include library
  90         additions such as -ljpeg etc.  Unfortunately, if these inclusions aren't made
  91         in LIBADD/LDADD variables, then they are mis-ordered during the linking.
  92
  93         The as-needed flag discards libraries whose functions have not been needed by
  94         earlier libraries, which therefore makes the ordering important.
  95
  96         This moves all -l library inclusion statements from LDFLAGS variables to
  97         LIBADD/LDADD variables.
  98
  99         * GNUmakefile.am:
 100
 101 2008-02-20  Brent Fulgham  <bfulgham@gmail.com>
 102
 103         Reviewed by Alp.
 104
 105         - http://bugs.webkit.org/show_bug.cgi?id=17428
 106           Reenable a Windows-based launcher
 107
 108         This patch reenables the venerable Spinneret application,
 109         changing its name to match the other lanch applications.
 110
 111         * WinLauncher: Added.
 112         * WinLauncher/WinLauncher.cpp: Added.
 113         (WinLauncherWebHost::updateAddressBar):
 114         (WinLauncherWebHost::QueryInterface):
 115         (WinLauncherWebHost::AddRef):
 116         (WinLauncherWebHost::Release):
 117         (resizeSubViews):
 118         (_tWinMain):
 119         (MyRegisterClass):
 120         (InitInstance):
 121         (WndProc):
 122         (MyEditProc):
 123         (About):
 124         (loadURL):
 125         * WinLauncher/WinLauncher.h: Added.
 126         (WinLauncherWebHost::WinLauncherWebHost):
 127         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
 128         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
 129         (WinLauncherWebHost::didFailProvisionalLoadWithError):
 130         (WinLauncherWebHost::didCommitLoadForFrame):
 131         (WinLauncherWebHost::didReceiveTitle):
 132         (WinLauncherWebHost::didReceiveIcon):
 133         (WinLauncherWebHost::didFinishLoadForFrame):
 134         (WinLauncherWebHost::didFailLoadWithError):
 135         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
 136         (WinLauncherWebHost::willPerformClientRedirectToURL):
 137         (WinLauncherWebHost::didCancelClientRedirectForFrame):
 138         (WinLauncherWebHost::willCloseFrame):
 139         (WinLauncherWebHost::windowScriptObjectAvailable):
 140         * WinLauncher/WinLauncher.ico: Added.
 141         * WinLauncher/WinLauncher.rc: Added.
 142         * WinLauncher/WinLauncher.vcproj: Added.
 143         * WinLauncher/resource.h: Added.
 144         * WinLauncher/small.ico: Added.
 145         * WinLauncher/stdafx.cpp: Added.
 146         * WinLauncher/stdafx.h: Added.
 147
 148 2008-02-19  Brady Eidson  <beidson@apple.com>
 149
 150         Reviewed by Geoff
 151
 152         Fixed a bug in DRT --threaded mode
 153
 154         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
 155         (startJavaScriptThreads): Don't detach the newly created thread.  The later call to stopJavaScriptThreads() tries
 156           to pthread_join() each thread that had been created, but you can't join a detached thread!
 157
 158 2008-02-18  Brady Eidson  <beidson@apple.com>
 159
 160         Changes by Geoff Garen, Reviewed by Darin
 161
 162         Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released
 163
 164         DRT changes for test: platform/mac/plugins/webScriptObject-exception-deadlock.html
 165
 166         [WebScriptObject valueForKey:] might throw an exception, and previously might have "leaked" the global JSLock
 167         This test calls valueForKey, then runs some arbitrary Javascript on a 2ndary thread.  If the lock has leaked,
 168         this series of method calls will deadlock.  If things are good, it will complete successfully.
 169
 170         * DumpRenderTree/mac/ObjCController.m:
 171         (runJavaScriptThread):
 172         (+[ObjCController isSelectorExcludedFromWebScript:]):
 173         (+[ObjCController webScriptNameForSelector:]):
 174         (-[ObjCController testValueForKey]):
 175
 176 2008-02-18  Matt Lilek  <webkit@mattlilek.com>
 177
 178         Reviewed by Adam.
 179
 180         Remove FindSafari's Release configuration.
 181
 182         * FindSafari/FindSafari.vcproj:
 183
 184 2008-02-15  Adam Roben  <aroben@apple.com>
 185
 186         Fix a typo that broke the Mac build
 187
 188         Reviewed by Mark.
 189
 190         * Scripts/build-webkit:
 191
 192 2008-02-14  Adam Roben  <aroben@apple.com>
 193
 194         Turn on cross-document messaging support by default
 195
 196         Reviewed by Darin.
 197
 198         * Scripts/build-webkit:
 199
 200 2008-02-14  Adam Roben  <aroben@apple.com>
 201
 202         Conditionalize cross-document messaging support
 203
 204         The cross-document messaging parts of HTML 5 are in flux and we want
 205         ports to be able to turn off the support as needed.
 206
 207         Note that the support is turned off by default right now. A subsequent
 208         commit will turn it on by default.
 209
 210         Reviewed by Darin.
 211
 212         * Scripts/build-webkit:
 213
 214 2008-02-14  Darin Adler  <darin@apple.com>
 215
 216        - fix Windows build
 217
 218         * DumpRenderTree/win/UIDelegate.cpp:
 219         (UIDelegate::setStatusText): Update parameter types to match declaration.
 220
 221 2008-02-14  Oliver Hunt  <oliver@apple.com>
 222
 223         Reviewed by Geoff G and Weinig.
 224
 225         Add ability for DRT to report tests setting the status text.
 226
 227         * DumpRenderTree/LayoutTestController.cpp:
 228         (LayoutTestController::LayoutTestController):
 229         (dumpStatusCallbacksCallback):
 230         (LayoutTestController::staticFunctions):
 231         * DumpRenderTree/LayoutTestController.h:
 232         * DumpRenderTree/mac/UIDelegate.mm:
 233         (-[UIDelegate webView:setStatusText:]):
 234         * DumpRenderTree/win/UIDelegate.cpp:
 235         * DumpRenderTree/win/UIDelegate.h:
 236
 237 2008-02-13  Adam Roben  <aroben@apple.com>
 238
 239         Windows build fix
 240
 241         * DumpRenderTree/ForwardingHeaders/wtf/MathExtras.h: Added.
 242
 243 2008-02-13  Adam Roben  <aroben@apple.com>
 244
 245         Windows/GTK+ build fix
 246
 247         * DumpRenderTree/LayoutTestController.cpp: #include MathExtras.h to
 248         get isnan.
 249
 250 2008-02-13  Brady Eidson  <beidson@apple.com>
 251
 252         Reviewed by Darin Adler
 253
 254         Add some much needed Database support to DRT
 255
 256         * DumpRenderTree/LayoutTestController.cpp:
 257         (LayoutTestController::LayoutTestController):
 258         (dumpDatabaseCallbacksCallback): Flag to control if the UIDelegate methods related to
 259           databases are called
 260         (clearAllDatabasesCallback): Allow a test to delete all databases
 261         (setDatabaseQuotaCallback): Allow a test to set the quota new origins will get
 262         (LayoutTestController::staticFunctions):
 263
 264         * DumpRenderTree/LayoutTestController.h:
 265         (LayoutTestController::dumpDatabaseCallbacks):
 266         (LayoutTestController::setDumpDatabaseCallbacks):
 267
 268         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 269         (LayoutTestController::clearAllDatabases):
 270         (LayoutTestController::setDatabaseQuota):
 271
 272         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 273         (LayoutTestController::clearAllDatabases): Stubbed out
 274         (LayoutTestController::setDatabaseQuota): Ditto
 275         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 276         (LayoutTestController::clearAllDatabases): Stubbed out with error message
 277         (LayoutTestController::setDatabaseQuota): Ditto
 278
 279         * DumpRenderTree/mac/UIDelegate.mm:
 280         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Print a
 281           message with details about the event then return a 5mb quota like before
 282
 283
 284 2008-02-12  Steve Falkenburg  <sfalken@apple.com>
 285
 286         Changes to support merged MIDL output.
 287
 288         All COM interfaces are now generated to WebKit.h.
 289
 290         Reviewed by Sam, Ada.
 291
 292         * Drosera/win/BaseDelegate.h:
 293         * Drosera/win/DebuggerClient.cpp:
 294         * Drosera/win/DebuggerDocumentPlatform.cpp:
 295         * Drosera/win/Drosera.cpp:
 296         * Drosera/win/ServerConnection.cpp:
 297         * Drosera/win/ServerConnection.h:
 298         * DumpRenderTree/win/DumpRenderTree.cpp:
 299         * DumpRenderTree/win/EditingDelegate.h:
 300         * DumpRenderTree/win/EventSender.cpp:
 301         * DumpRenderTree/win/FrameLoadDelegate.cpp:
 302         * DumpRenderTree/win/FrameLoadDelegate.h:
 303         * DumpRenderTree/win/GCControllerWin.cpp:
 304         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 305         * DumpRenderTree/win/PolicyDelegate.h:
 306         * DumpRenderTree/win/ResourceLoadDelegate.h:
 307         * DumpRenderTree/win/UIDelegate.cpp:
 308         * DumpRenderTree/win/UIDelegate.h:
 309         * DumpRenderTree/win/WorkQueueItemWin.cpp:
 310
 311 2008-02-10  Dan Bernstein  <mitz@apple.com>
 312
 313         Reviewed by Oliver Hunt.
 314
 315         - fix a memory leak
 316
 317         * DumpRenderTree/cg/ImageDiffCG.cpp:
 318         (getDifferenceBitmap): Use a static CFMutableData instead of allocating
 319         and leaking the buffer each time.
 320
 321 2008-02-07  Adam Roben  <aroben@apple.com>
 322
 323         Fix error in bisect-builds when responding "broken" for the first
 324         build
 325
 326         Reviewed by Dave Kilzer.
 327
 328         * Scripts/bisect-builds: Only try to test the build if the nightly
 329         info for the current index has not been deleted.
 330
 331 2008-02-07  Geoffrey Garen  <ggaren@apple.com>
 332
 333         Reviewed by Alexey Proskuryakov.
 334
 335         Fixed two minor typos in the --root option, to get it working.
 336
 337         * Scripts/run-sunspider:
 338             1. Actually assign the function argument to our local variable.
 339             2. Actually set the $root variable, so we don't try to build later.
 340
 341 2008-02-05  Oliver Hunt  <oliver@apple.com>
 342
 343         RS=Eric.
 344
 345         Re-enable foreignObject by default as it is needed for a number of non-fO
 346         related SVG tests and none of the old known crashes occur anymore.
 347
 348         * Scripts/build-webkit:
 349
 350 2008-02-05  Steve Falkenburg  <sfalken@apple.com>
 351
 352         Build fix.  Don't override intermediate directory.
 353
 354         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 355
 356 2008-02-05  Holger Hans Peter Freyther  <zecke@selfish.org>
 357
 358         Build fix for Windows. willCloseFrame is a pure virtual and we are
 359         forced to have an implementation.
 360
 361         This partially reverts r30014.
 362
 363         * DumpRenderTree/win/FrameLoadDelegate.cpp:
 364         (FrameLoadDelegate::willCloseFrame):
 365         * DumpRenderTree/win/FrameLoadDelegate.h:
 366
 367 2008-02-05  Nikolas Zimmermann  <zimmermann@kde.org>
 368
 369         Reviewed by Holger.
 370
 371         Don't build wrapper for SVGTestCase.js (special file for svg/dynamic-updates)
 372
 373         * Scripts/make-js-test-wrappers:
 374
 375 2008-02-05  Holger Freyther  <zecke@selfish.org>
 376
 377         Reviewed by Darin.
 378
 379         In http://bugs.webkit.org/show_bug.cgi?id=16853 it was identified that the
 380         the output of the willCloseFrame and didClearWindowObject FrameLoadDelegate
 381         depends on the order the tests are executed.
 382
 383         Propose to remove willCloseFrame and didlCearWindowObject output from the
 384         FrameLoadDelegate and update the test results. The output of didClearWindowObject
 385         is not interesting for any of the current tests and we have other ways to find
 386         out if a frame was closed or not.
 387
 388         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 389         * DumpRenderTree/win/FrameLoadDelegate.cpp:
 390         (FrameLoadDelegate::didClearWindowObject):
 391         * DumpRenderTree/win/FrameLoadDelegate.h:
 392
 393 2008-02-04  Mark Rowe  <mrowe@apple.com>
 394
 395         Reviewed by Oliver Hunt.
 396
 397         Workaround for http://bugs.webkit.org/show_bug.cgi?id=16842
 398         Bug 16842: Hang in DRT in leaks mode due to signal handler doing unsafe things
 399
 400         Don't install the signal handler unless we are running the pixel tests.
 401         It is currently only used to restore the color profile, but by catching
 402         signals we can trigger a deadlock in DRT while running leak tests.
 403         The deadlock is tracked by http://bugs.webkit.org/show_bug.cgi?id=16842,
 404         and a more complete fix will need to be developed to address this for
 405         pixel tests as well.
 406
 407         * DumpRenderTree/mac/DumpRenderTree.mm:
 408         (dumpRenderTree):
 409
 410 2008-02-04  Mark Rowe  <mrowe@apple.com>
 411
 412        Gtk qmake build fix.
 413
 414         * Scripts/webkitdirs.pm:  Fix perl's complaint about an odd number of elements in anonymous hash.
 415
 416 2008-02-04  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
 417
 418         Reviewed by Alp Toker and Mark Rowe.
 419
 420         http://bugs.webkit.org/show_bug.cgi?id=16618
 421         [GTK] build-webkit and run-webkit-tests autootools support
 422
 423         * Scripts/build-webkit: added --database and --icon-database options
 424         * Scripts/run-launcher:
 425         * Scripts/run-webkit-tests:
 426         * Scripts/webkitdirs.pm:
 427
 428 2008-02-04  Oliver Hunt  <oliver@apple.com>
 429
 430         Reviewed by Steve F.
 431
 432         Partial fix for <rdar://5621244> Drag & Drop doesn't work correctly in DRT
 433
 434         Implement required DRT functionality to allow majority of Drag and Drop testcases to work.
 435         Issues include:
 436           * Uses Sleep() to implement leapForward reliably.
 437           * 3 DND tests still fail for reasons that i have not yet determined
 438           * Has to explicitly ignore an extraneous WM_MOUSELEAVE that i am at a loss to explain
 439
 440         * DumpRenderTree/win/EventSender.cpp:
 441         (leapForwardCallback):
 442         (mouseDownCallback):
 443         (doMouseUp):
 444         (mouseUpCallback):
 445         (doMouseMove):
 446         (mouseMoveToCallback):
 447           Minor updates to these functions to handle the different message queue structure.
 448
 449         (replaySavedEvents):
 450           More complicated now.  Where possible we just use the old while-loop model of execution,
 451           but when leapForward has been used we have to jump through some hoops and set up an
 452           inner event loop so that we can ensure messages get the correct time stamp.
 453
 454         * DumpRenderTree/win/UIDelegate.cpp:
 455         (UIDelegate::doDragDrop):
 456           Call replaySavedEvents directly to force synchronous handling of drag and drop.
 457
 458 2008-02-04  Rodney Dawes  <dobey@wayofthemonkey.com>
 459
 460         Reviewed by Alp Toker and Mark Rowe.
 461
 462         Fix http://bugs.webkit.org/show_bug.cgi?id=17175.
 463         Bug 17175: Use of C++ compiler flags in CFLAGS
 464
 465         * GNUmakefile.am: Use global_cxxflags as well as global_cflags in CXXFLAGS.
 466
 467 2008-02-04  Darin Adler  <darin@apple.com>
 468
 469         Reviewed by Geoff.
 470
 471         * Scripts/make-js-test-wrappers: Look at the whole LayoutTests tree, not just the fast
 472         and svg subdirectories. Added some more exceptions for the benefit of the fast/dom
 473         subdirectory.
 474
 475 2008-02-04  Adam Roben  <aroben@apple.com>
 476
 477         Windows Apple-only build fix
 478
 479         * DumpRenderTree/win/DumpRenderTree.vcproj: Added a new include
 480         directory.
 481
 482 2008-02-04  Alp Toker  <alp@atoker.com>
 483
 484         Rubber-stamped by Mark Rowe.
 485
 486         Remove all trailing whitespace in the GTK+ port and related
 487         components.
 488
 489         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
 490         * DumpRenderTree/gtk/GCControllerGtk.cpp:
 491         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 492         * GNUmakefile.am:
 493
 494 2008-02-01  Eric Seidel  <eric@webkit.org>
 495
 496         Reviewed by Oliver.
 497
 498         Also search LayoutTests/svg for js-based tests.
 499
 500         * Scripts/make-js-test-wrappers:
 501
 502 2008-01-31  Alp Toker  <alp@atoker.com>
 503
 504         Rubber-stamped by Adam Roben.
 505
 506         http://bugs.webkit.org/show_bug.cgi?id=17006
 507         [GTK] Header path should be webkit/webkit.h
 508
 509         Move the GTK+ API sources as needed and update the build systems.
 510
 511         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 512         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
 513         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
 514         * GNUmakefile.am:
 515         * GtkLauncher/main.c:
 516
 517 2008-01-30  Stephanie  <slewis@apple.com>
 518
 519         Reviewed by Geoff.
 520
 521         Add an option to run-webkit-tests to merge leaks results and print the number of unique leaks found under a certain call depth.  This should make it easier for the buildbots to track new leaks.
 522
 523         * Scripts/run-webkit-tests:
 524
 525 2008-01-30  Alexey Proskuryakov  <ap@webkit.org>
 526
 527         Reviewed by Adam Roben.
 528
 529         One more debug (external) fix.
 530
 531         * DumpRenderTree/win/DumpRenderTree.cpp: TestNetscapePlugin is built with a _debug suffix in both DebugInternal
 532         and Debug configurations.
 533
 534 2008-01-29  Geoffrey Garen  <ggaren@apple.com>
 535
 536         Reviewed by Sam Weinig. Sam Weinig.
 537
 538         Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
 539         fails when run after fast/dom/Window/window-property-shadowing.html (16902)
 540
 541         Modified our policy delegates not to output window.name. Since a
 542         previous test may have explicitly set window.name, we can't rely on its
 543         implicit value in test results.
 544
 545         * DumpRenderTree/mac/PolicyDelegate.mm:
 546         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
 547
 548         * DumpRenderTree/win/PolicyDelegate.cpp:
 549         (PolicyDelegate::decidePolicyForNavigationAction):
 550
 551 2008-01-29  Mark Rowe  <mrowe@apple.com>
 552
 553         Reviewed by Tim Hatcher.
 554
 555         <rdar://problem/5600926> WebCore on Tiger must link to its own copy of SQLite 3.4 or newer (so HTML database behavior will be correct).
 556
 557         * Scripts/build-webkit: Copy SQLite static library and headers into the build directory.
 558
 559 2008-01-29  David Kilzer  <ddkilzer@apple.com>
 560
 561         Refactor ChangeLog path code
 562
 563         Reviewed by Adam.
 564
 565         * Scripts/prepare-ChangeLog: Simplify code in one foreach() loop, and extract
 566         duplicate code in another foreach() loop.
 567
 568 2008-01-29  Alexey Proskuryakov  <ap@webkit.org>
 569
 570         Reviewed by Darin.
 571
 572         <rdar://problem/5710692> All storage tests fail/crash
 573
 574         * DumpRenderTree/mac/UIDelegate.mm:
 575         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Set an
 576         arbitrary quota of 5 megabytes.
 577
 578         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
 579         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
 580         Removed unused (I think) code.
 581
 582         * DumpRenderTree/win/UIDelegate.cpp:
 583         (UIDelegate::QueryInterface): IWebUIDelegatePrivate3 is now supported.
 584         (UIDelegate::webViewPainted): A stub implementation.
 585         (UIDelegate::exceededDatabaseQuota): Set an arbitrary quota of 5 megabytes.
 586         * DumpRenderTree/win/UIDelegate.h:
 587
 588 2008-01-27  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
 589
 590         GTK+ DRT build fix for breakage introduced in r29822.
 591
 592         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 593         (LayoutTestController::setPersistentUserStyleSheetLocation):
 594         (LayoutTestController::clearPersistentUserStyleSheet):
 595
 596 2008-01-27  Dan Bernstein  <mitz@apple.com>
 597
 598         Reviewed by Darin Adler.
 599
 600         - add support for directory prologues and epilogues to run-webkit-tests
 601         - allow setting a persistent user style sheet in DumpRenderTree
 602         - activate the WebKit Layout Tests font in Windows DumpRenderTree
 603
 604         * DumpRenderTree/LayoutTestController.cpp:
 605         (clearPersistentUserStyleSheetCallback): Added.
 606         (setPersistentUserStyleSheetLocationCallback): Added.
 607         (LayoutTestController::staticFunctions): Added.
 608         clearPersistentUserStyleSheet and setPersistentUserStyleSheet.
 609         * DumpRenderTree/LayoutTestController.h:
 610         * DumpRenderTree/mac/DumpRenderTree.mm:
 611         (setPersistentUserStyleSheetLocation): Added.
 612         (resetWebViewToConsistentStateBeforeTesting): Added the user style sheet
 613         to the set of things this function resets. Now it either disables the
 614         user style sheet or sets it to the persistent user style sheet and
 615         enables it.
 616         * DumpRenderTree/mac/DumpRenderTreeMac.h:
 617         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 618         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
 619         (LayoutTestController::clearPersistentUserStyleSheet): Added.
 620         * DumpRenderTree/win/DumpRenderTree.cpp:
 621         (setPersistentUserStyleSheetLocation): Added.
 622         (initialize): Added the WebKit Layout Tests font to the set of fonts to
 623         install.
 624         (resetWebViewToConsistentStateBeforeTesting): See DumpRenderTree.mm.
 625         * DumpRenderTree/win/DumpRenderTreeWin.h:
 626         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 627         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
 628         (LayoutTestController::clearPersistentUserStyleSheet): Added.
 629         * Scripts/run-webkit-tests: Changed to look for, and if found process in
 630         DumpRenderTree, files named run-webkit-tests-prologue.html and
 631         run-webkit-tests-epilogue.html in the resources subdirectory of any
 632         test directory and platform test results directory. The prologues are
 633         processed before the first test from the directory (and its
 634         subdirectories) is run, and the epilogues are processed after the last
 635         test from the directory is run. Platform-specific prologues and
 636         epilogues are processed in order of specificity.
 637
 638 2008-01-25  Alexey Proskuryakov  <ap@webkit.org>
 639
 640         Reviewed by Mark Rowe.
 641
 642         <rdar://problem/5699933> http/tests/security/cross-frame-access-get.html is still failing
 643
 644         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Clear HTTP cache to ensure consistent test environment
 645         (matching Mac DRT).
 646         * DumpRenderTree/win/DumpRenderTree.vcproj: Link to CFNetwork.
 647
 648 2008-01-24  Sam Weinig  <sam@webkit.org>
 649
 650         Reviewed by Ada Chan.
 651
 652         Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo
 653
 654         - Adds simplified UndoManager to windows DRT to allow testing the
 655           undo/redo code paths in WebCore and WebKit.  This is a temporary
 656           solution to an issue that should eventually be solved by having a
 657           shared UndoManager in WebKit.
 658
 659         * DumpRenderTree/win/DumpRenderTree.cpp:
 660         (runTest):
 661         * DumpRenderTree/win/UIDelegate.cpp:
 662         (DRTUndoObject::DRTUndoObject):
 663         (DRTUndoObject::invoke):
 664         (DRTUndoStack::~DRTUndoStack):
 665         (DRTUndoStack::isEmpty):
 666         (DRTUndoStack::clear):
 667         (DRTUndoStack::push):
 668         (DRTUndoStack::pop):
 669         (DRTUndoManager::canRedo):
 670         (DRTUndoManager::canUndo):
 671         (DRTUndoManager::DRTUndoManager):
 672         (DRTUndoManager::removeAllActions):
 673         (DRTUndoManager::registerUndoWithTarget):
 674         (DRTUndoManager::redo):
 675         (DRTUndoManager::undo):
 676         (UIDelegate::UIDelegate):
 677         (UIDelegate::resetUndoManager):
 678         (UIDelegate::registerUndoWithTarget):
 679         (UIDelegate::removeAllActionsWithTarget):
 680         (UIDelegate::setActionTitle):
 681         (UIDelegate::undo):
 682         (UIDelegate::redo):
 683         (UIDelegate::canUndo):
 684         (UIDelegate::canRedo):
 685         * DumpRenderTree/win/UIDelegate.h:
 686
 687 2008-01-23  Adam Roben  <aroben@apple.com>
 688
 689         Allow directories containing ChangeLogs to be passed to
 690         resolve-ChangeLogs
 691
 692         Reviewed by David Kilzer.
 693
 694         * Scripts/resolve-ChangeLogs:
 695         (sub findChangeLog): Return a ChangeLog contained within the specified
 696         directory if one exists.
 697
 698 2008-01-23  Steve Falkenburg  <sfalken@apple.com>
 699
 700         <rdar://problem/5698732> Copyright strings should include 2008
 701
 702         Reviewed by Sam.
 703
 704         * Drosera/win/Drosera.vcproj/Drosera.rc:
 705         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
 706
 707 2008-01-23  Alp Toker  <alp@atoker.com>
 708
 709         Rubber-stamped by Mark Rowe.
 710
 711         Remove whitespace after -I in automake include lists.
 712
 713         * GNUmakefile.am:
 714
 715 2008-01-23  Michael Goddard <michael.goddard@trolltech.com>
 716
 717         Reviewed by Lars Knoll <lars@trolltech.com>.
 718
 719         Reworked the JavaScriptCore Qt bindings:
 720
 721         * Update JS DRT controller for Qt JS binding changes.
 722         There were two functions that needed some changes
 723         so that the layout tests would work, so this makes
 724         a few tests pass again.
 725
 726         * Bump the timeout for layout tests up to 11s.
 727         At least some tests have an internal timeout of
 728         10 seconds, so make the waitUntilDone approach
 729         wait at least 11s.  fast/dom/open-and-close-by-DOM.html
 730         is one of these - now the failure message is more
 731         accurate.
 732
 733
 734         * DumpRenderTree/qt/jsobjects.cpp:
 735         (LayoutTestController::waitUntilDone):
 736         * DumpRenderTree/qt/jsobjects.h:
 737
 738 2008-01-22  Anders Carlsson  <andersca@apple.com>
 739
 740         Reviewed by Darin and Adam.
 741
 742         <rdar://problem/5688975>
 743         div element on microsoft site has wrong left offset.
 744
 745         Add new method for testing the return vale of NPN_GetProperty.
 746
 747         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 748         (pluginInvoke):
 749
 750 2008-01-22  Alexey Proskuryakov  <ap@webkit.org>
 751
 752         Reviewed by Adam Roben.
 753
 754         <rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail
 755
 756         * DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.
 757
 758 2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
 759
 760         Reviewed by Alp Toker.
 761
 762         http://bugs.webkit.org/show_bug.cgi?id=16955
 763         Get errors when cross-compile webkit-gtk
 764
 765         * GNUmakefile.am: Removed ICU_CFLAGS
 766
 767 2008-01-21  Darin Adler  <darin@apple.com>
 768
 769         Reviewed by Mitz and Adam.
 770
 771         * Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the
 772         sorting speed by doing all sort criteria in a single pass instead of three sorts.
 773
 774 2008-01-21  Simon Hausmann  <hausmann@webkit.org>
 775
 776         Reviewed by Holger.
 777
 778         Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
 779
 780         * Fix GraphicsContext::drawFocusRing to also draw single focus rects.
 781         * Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
 782         and make the return value depend on whether we successfully determined a focusable
 783         node or not.
 784         * Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
 785         if we could not handle the focus chain ourselves.
 786         * Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
 787         * Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
 788         used to control the situation of stepping out of the focus chain inside the page.
 789         * Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
 790         The layout tests expect this to be disabled but for the user it seems sensible to have it
 791         on by default, hence the default in qwebsettings.cpp
 792
 793
 794         * DumpRenderTree/qt/DumpRenderTree.cpp:
 795         (WebCore::WebPage::WebPage):
 796
 797 2008-01-19  Mark Rowe  <mrowe@apple.com>
 798
 799         Reviewed by Alp Toker.
 800
 801         Allow the --http flag to run-webkit-tests to override
 802         the default behaviour of disabling HTTP tests for Qt,
 803         Gtk and Wx.
 804
 805         * Scripts/run-webkit-tests:
 806
 807 2008-01-19  David Kilzer  <ddkilzer@apple.com>
 808
 809         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
 810
 811         Reviewed by Darin.
 812
 813         We now touch a check-for-global-initializers.timestamp file in
 814         the TARGET_TEMP_DIR directory to determine when new object files
 815         have been compiled and thus need to be checked.  If the timestamp
 816         file doesn't exist, all object files will be checked.
 817
 818         Previously the modification time of the "executable" (the
 819         framework binary, e.g., WebKit.framework/WebKit) was used, but
 820         since this was the last file modified at the end of the compile
 821         phase, no object files would ever get checked!
 822
 823         Also added JSCustomSQLTransactionCallback.o to the list of files
 824         since it has static initializers in Debug builds of WebCore.
 825
 826         * Scripts/check-for-global-initializers:
 827
 828 2008-01-18  Adam Roben  <aroben@apple.com>
 829
 830         Build fix
 831
 832         * Scripts/build-webkit:
 833
 834 2008-01-18  Beth Dakin  <bdakin@apple.com>
 835
 836         Reviewed by Oliver.
 837
 838         Update build-webkit to account for foreign-object being disabled by
 839         default.
 840
 841         * Scripts/build-webkit:
 842
 843 2008-01-18  Adam Roben  <aroben@apple.com>
 844
 845         Updated for method renames
 846
 847         Reviewed by Adele.
 848
 849         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 850         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
 851         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 852         (LayoutTestController::setMainFrameIsFirstResponder):
 853         (LayoutTestController::setWindowIsKey):
 854         * DumpRenderTree/mac/UIDelegate.mm:
 855         (-[UIDelegate webViewFocus:]):
 856         * DumpRenderTree/win/FrameLoadDelegate.cpp:
 857         (FrameLoadDelegate::didCommitLoadForFrame):
 858
 859 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
 860
 861         Reviewed by Adam Roben.
 862
 863         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
 864         between DRT and TestNetscapePlugin.
 865
 866         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
 867         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
 868
 869 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
 870
 871         Reviewed by Holger.
 872
 873         Fix fast/dom/Window/window-resize.html
 874
 875         In DRT connect the page's geometryChangeRequest signal to a slot that
 876         sets the geometry of the view widget.
 877
 878
 879         * DumpRenderTree/qt/DumpRenderTree.cpp:
 880         (WebCore::WebPage::setViewGeometry):
 881         (WebCore::WebPage::WebPage):
 882
 883 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
 884
 885         Build fix.
 886
 887         * Drosera/DroseraWin.make:
 888
 889 2008-01-17  Darin Adler  <darin@apple.com>
 890
 891         * Scripts/run-webkit-tests: Fixed a bug number.
 892
 893 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
 894
 895         Reviewed by Adam Roben.
 896
 897         http://bugs.webkit.org/show_bug.cgi?id=16908
 898         run-webkit-tests complains about missing FindSafari.exe
 899
 900         * Scripts/webkitdirs.pm: Append _debug as appropriate.
 901
 902 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
 903
 904         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
 905
 906         Rubber-stamped by Jon Honeycutt.
 907
 908         * DumpRenderTree/win/DumpRenderTree.vcproj:
 909
 910 2008-01-16  Alp Toker  <alp@atoker.com>
 911
 912         Reviewed by Mark Rowe.
 913
 914         http://bugs.webkit.org/show_bug.cgi?id=16218
 915         [GTK] API: Should this entry point be called go_back rather than go_backward?
 916
 917         Track back/forward API changes in the tools.
 918
 919         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
 920         (BackForwardItem::invoke):
 921         * GtkLauncher/main.c:
 922         (go_back_cb):
 923
 924 2008-01-16  Adam Roben  <aroben@apple.com>
 925
 926         Windows build fix after r29488
 927
 928         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
 929         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
 930         expects to find the plugin.
 931
 932 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
 933
 934         Reviewed by Sam Weinig.
 935
 936         Fixed the waitUntilDone watchdog timer -- the old code never added the
 937         timer to the run loop, so it didn't do anything.
 938
 939         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 940         (LayoutTestController::setWaitToDump):
 941         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 942         (LayoutTestController::setWaitToDump):
 943
 944 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
 945
 946         Use shared vsprops for most vcproj properties.
 947
 948         Reviewed by Darin.
 949
 950         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
 951         * DumpRenderTree/win/DumpRenderTree.vcproj:
 952         * DumpRenderTree/win/ImageDiff.vcproj:
 953         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
 954         * FindSafari/FindSafari.vcproj:
 955
 956 2008-01-14  Stephanie  <slewis@apple.com>
 957
 958        Reviewed by NOBODY.
 959
 960        revert accidental character.
 961
 962        * Scripts/run-webkit-tests:
 963
 964 2008-01-14  Stephanie  <slewis@apple.com>
 965
 966         RS=Oliver
 967
 968         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
 969
 970         * Scripts/run-webkit-tests:
 971
 972 2008-01-14  Darin Adler  <darin@apple.com>
 973
 974         * Scripts/do-webcore-rename: Queue up another rename.
 975
 976 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
 977
 978         Reviewed by Darin.
 979
 980         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
 981         the tests were ran.
 982         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
 983
 984         * Scripts/run-webkit-tests:
 985
 986 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
 987
 988         Reviewed by Darin.
 989
 990         * Randomize tests array to spot test cases where the results depends on the order
 991         the tests are ran.
 992         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
 993
 994         * Scripts/run-webkit-tests:
 995
 996 2008-01-14  Darin Adler  <darin@apple.com>
 997
 998         * Scripts/run-webkit-tests: More ignore list tweaking.
 999
1000 2008-01-14  Darin Adler  <darin@apple.com>
1001
1002         * Scripts/run-webkit-tests: Add another leak to the ignore list.
1003
1004 2008-01-14  Dan Bernstein  <mitz@apple.com>
1005
1006         Reviewed by Adam Roben.
1007
1008         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
1009           build bots
1010
1011         * DumpRenderTree/win/DumpRenderTree.cpp:
1012         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
1013
1014 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
1015
1016         Share common files across projects.
1017
1018         Unify vsprops files
1019         Debug:          common.vsprops, debug.vsprops
1020         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
1021         Release:        common.vsprops, release.vsprops
1022
1023         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
1024         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
1025
1026         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
1027
1028         Reviewed by Adam Roben.
1029
1030         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1031         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
1032         * Drosera/win/Drosera.vcproj/VERSION: Removed.
1033         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
1034         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
1035         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
1036         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
1037         * DumpRenderTree/win/DumpRenderTree.vcproj:
1038         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1039         * DumpRenderTree/win/debug.vsprops: Removed.
1040         * DumpRenderTree/win/debug_internal.vsprops: Removed.
1041         * DumpRenderTree/win/release.vsprops: Removed.
1042
1043 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
1044
1045         Reviewed by Maciej.
1046
1047         - http://bugs.webkit.org/show_bug.cgi?id=16314
1048           Script to launch Drosera
1049
1050         * Scripts/gdb-drosera: Added.
1051         * Scripts/run-drosera: Added.
1052         * Scripts/run-drosera-nightly.cmd: Added.
1053         * Scripts/webkitdirs.pm: Added runDrosera function.
1054
1055 2008-01-13  Dan Bernstein  <mitz@apple.com>
1056
1057         - fix breakage due to last-minute change
1058
1059         * DumpRenderTree/win/DumpRenderTree.cpp:
1060         (runTest): Declare the loop variable.
1061
1062 2008-01-13  Dan Bernstein  <mitz@apple.com>
1063
1064         Reviewed by Adam Roben.
1065
1066         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
1067
1068         * DumpRenderTree/win/DumpRenderTree.cpp:
1069         (DumpRenderTreeWndProc):
1070         (initialize):
1071         (dumpBackForwardList):
1072         (dumpBackForwardListForAllWindows):
1073         (dump):
1074         (resetWebViewToConsistentStateBeforeTesting): Factored out of
1075         runTest().
1076         (runTest):
1077         (allWindows): Added. Returns a vector of all open windows.
1078         (windowToWebViewMap): Added. Returns a map from open windows to their
1079         WebViews.
1080         (createWebViewAndOffscreenWindow): Factored out of main() to be
1081         reusable for creating extra windows.
1082         (main):
1083         * DumpRenderTree/win/DumpRenderTreeWin.h:
1084         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1085         (LayoutTestController::windowCount): Implemented.
1086         * DumpRenderTree/win/UIDelegate.cpp:
1087         (UIDelegate::createWebViewWithRequest): Implemented.
1088         (UIDelegate::webViewClose): Implemented.
1089         * DumpRenderTree/win/UIDelegate.h:
1090
1091 2008-01-12  Alp Toker  <alp@atoker.com>
1092
1093         Reviewed by Mark Rowe.
1094
1095         Hide non-public symbols in GTK+/autotools release builds.
1096
1097         * GNUmakefile.am:
1098
1099 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1100
1101         Reviewed by Ap.
1102
1103         * Make launching of the WebKit httpd work on GNU/Debian/Linux
1104
1105         The configuration of Apache2 and installation does not depend on
1106         the kernel but on the distribution policy. Make launching of httpd
1107         work for Debian derived distributions.
1108
1109         * Scripts/run-webkit-httpd:
1110         * Scripts/run-webkit-tests:
1111         * Scripts/webkitdirs.pm:
1112
1113 2008-01-12  Mark Rowe  <mrowe@apple.com>
1114
1115         Reviewed by Maciej Stachowiak.
1116
1117         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
1118
1119         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
1120         match the callers expectations that it can take ownership of the string.
1121
1122 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
1123
1124         Reviewed by Adam Roben.
1125
1126         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
1127
1128         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
1129         as these are only posted because the test window is not a normal visible one, and
1130         they confuse drag&drop machinery.
1131
1132 2008-01-11  Adam Roben  <aroben@apple.com>
1133
1134         Fix a crash when pathToLocalResource fails and a leak
1135
1136         Reviewed by Darin.
1137
1138         * DumpRenderTree/LayoutTestController.cpp:
1139         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
1140         sure not to pass null to JSValueMakeString.
1141         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1142         (LayoutTestController::pathToLocalResource): Print an error message if
1143         the conversion fails so it's clear what happened.
1144
1145 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
1146
1147         Reviewed by John Sullivan.
1148
1149         * DumpRenderTree/mac/GCControllerMac.mm:
1150         (GCController::collectOnAlternateThread): Updated for name change.
1151
1152 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
1153
1154         wx build fix. Don't build dftables any longer since it's now a Perl
1155         script.
1156
1157         * wx/build-wxwebkit:
1158
1159 2008-01-10  Sam Weinig  <sam@webkit.org>
1160
1161         Reviewed by Anders Carlsson.
1162
1163         Make DRT track open windows instead of allocated windows so that
1164         we can avoid ASSERTION due to late deallocs out of our control.
1165
1166         * DumpRenderTree/mac/DumpRenderTree.mm:
1167         (dumpBackForwardListForAllWindows):
1168         (runTest):
1169         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1170         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1171         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1172         (+[DumpRenderTreeWindow openWindows]):
1173         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1174         (-[DumpRenderTreeWindow close]):
1175         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1176         (LayoutTestController::windowCount):
1177
1178 2008-01-10  Ada Chan  <adachan@apple.com>
1179
1180         Meta key is not the same as Alt key on windows.
1181
1182         Reviewed by Darin.
1183
1184         * DumpRenderTree/win/EventSender.cpp:
1185         (keyDownCallback):
1186
1187 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
1188
1189         Reviewed by Darin, Sam and Adam.
1190
1191         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
1192         link in gmail message displays JavaScript alert falsely complaining
1193         about pop-up blocking.
1194         - Added the ability to enable the pop-up blocker via the
1195         LayoutTestController.
1196
1197         * DumpRenderTree/LayoutTestController.cpp:
1198         (setPopupBlockingEnabledCallback):
1199         (LayoutTestController::staticFunctions):
1200         * DumpRenderTree/LayoutTestController.h:
1201         * DumpRenderTree/mac/DumpRenderTree.mm:
1202         (setDefaultsToConsistentValuesForTesting):
1203         (resetWebViewToConsistentStateBeforeTesting):
1204         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1205         (LayoutTestController::setPopupBlockingEnabled):
1206
1207 2008-01-10  Lars Knoll  <lars@trolltech.com>
1208
1209         Reviewed by Simon.
1210
1211         rename QWebPageHistory to QWebHistory.
1212
1213
1214         * DumpRenderTree/qt/jsobjects.cpp:
1215
1216 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
1217
1218         Reviewed by Darin.
1219
1220         - add some more renames, adjust some
1221
1222         * Scripts/do-webcore-rename:
1223
1224 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
1225
1226         Reviewed by Oliver.
1227
1228         Enable SVG Fonts support by default.
1229
1230         * Scripts/build-webkit:
1231
1232 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
1233
1234         Reviewed by Adam.
1235
1236         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
1237         DRT doesn't handle platform specific pixel test results correctly.
1238
1239         <test>-expected.txt files and <test>-expected.png files may now live
1240         in different directories (ie. a cross-platform <test>-expected.txt file
1241         and a platform-specific <test>-expected.png file).
1242
1243         * Scripts/run-webkit-tests:
1244
1245 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
1246
1247         Reviewed by Darin.
1248
1249         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
1250         DRT did not correctly handle printing the '\0' char.  Now it does.
1251
1252         * DumpRenderTree/win/DumpRenderTree.cpp:
1253         (dumpFramesAsText):
1254         (dump):
1255
1256 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
1257
1258         Reviewed by Lars.
1259
1260         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
1261
1262
1263         * DumpRenderTree/qt/main.cpp:
1264         * DumpRenderTree/qt/testplugin.cpp:
1265         * DumpRenderTree/qt/testplugin.h:
1266
1267 2008-01-05  Mark Rowe  <mrowe@apple.com>
1268
1269         Reviewed by Alp Toker.
1270
1271         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
1272
1273         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1274         (processWork): Process pending work.
1275         (webViewLoadFinished): Schedule processing of pending work.
1276         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
1277
1278 2008-01-05  Darin Adler  <darin@apple.com>
1279
1280         * Scripts/do-webcore-rename: Some more renaming plans.
1281
1282 2008-01-04  Alice Liu  <alice.liu@apple.com>
1283
1284         Reviewed by Alexey and Darin.
1285
1286         Adding "home" and "end" to DRT's keydown since
1287         DOM key events can't handle keyIdentifiers at this point.
1288
1289         * DumpRenderTree/mac/EventSendingController.mm:
1290         (-[EventSendingController keyDown:withModifiers:]):
1291         * DumpRenderTree/win/EventSender.cpp:
1292         (keyDownCallback):
1293
1294 2008-01-04  Lars Knoll  <lars@trolltech.com>
1295
1296         Reviewed by Simon.
1297
1298         fix DRT after the changes to QWebPage.
1299
1300         The great thing is that we actually don't have
1301         any regressions from the QWebPage change :)
1302
1303
1304         * DumpRenderTree/qt/DumpRenderTree.cpp:
1305         (WebCore::DumpRenderTree::DumpRenderTree):
1306
1307 2008-01-04  Lars Knoll  <lars@trolltech.com>
1308
1309         Reviewed by Simon.
1310
1311         make QWebPage a QObject and get things to compile.
1312
1313         Nothing works currently though.
1314
1315
1316         * DumpRenderTree/qt/DumpRenderTree.cpp:
1317         (WebCore::DumpRenderTree::DumpRenderTree):
1318
1319 2008-01-04  Lars Knoll  <lars@trolltech.com>
1320
1321         Reviewed by Simon.
1322
1323         take a QString as identifier in QWebFrame::addToJSWindowObject.
1324
1325         * DumpRenderTree/qt/DumpRenderTree.cpp:
1326         (WebCore::DumpRenderTree::initJSObjects):
1327
1328 2008-01-04  Alp Toker  <alp@atoker.com>
1329
1330         GTK+ DRT build fix for breakage introduced in r29149.
1331
1332         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1333         (LayoutTestController::execCommand):
1334
1335 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
1336
1337         Reviewed by Darin.
1338
1339         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
1340
1341         Added layoutTestController.execCommand to access editor commands that are not available
1342         via document.execCommand.
1343
1344         * DumpRenderTree/LayoutTestController.cpp:
1345         (execCommandCallback):
1346         (LayoutTestController::staticFunctions):
1347         * DumpRenderTree/LayoutTestController.h:
1348         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1349         (LayoutTestController::execCommand):
1350         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1351         (LayoutTestController::queueLoad):
1352         (LayoutTestController::execCommand):
1353
1354 2008-01-03  Alice Liu  <alice.liu@apple.com>
1355
1356         Reviewed by Darin, Mitz.
1357
1358         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
1359
1360         the clickcount should not increase if the last click was at a different location.  it's a new click.
1361
1362         * DumpRenderTree/mac/DumpRenderTree.mm:
1363         (runTest):
1364         * DumpRenderTree/mac/EventSendingController.h:
1365         * DumpRenderTree/mac/EventSendingController.mm:
1366         (-[EventSendingController mouseDown]):
1367         (-[EventSendingController mouseUp]):
1368
1369 2008-01-03  Darin Adler  <darin@apple.com>
1370
1371         Reviewed by Adam.
1372
1373         * Scripts/update-webkit: Make this work a little better for the people at Apple
1374         who have a directory named Internal.
1375
1376 2008-01-03  Adam Roben  <aroben@apple.com>
1377
1378         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
1379
1380         Rubberstamped by Mark.
1381
1382         * Scripts/update-webkit-auxiliary-libs:
1383
1384 2008-01-03  Adam Roben  <aroben@apple.com>
1385
1386         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
1387
1388         http://bugs.webkit.org/show_bug.cgi?id=15663
1389
1390         Added a fuzz factor into the Last-Modified comparison for downloading
1391         WebKitAuxiliaryLibrary.zip.
1392
1393         The zip file is served from a set of mirrors who give Last-Modified
1394         times that are off by 1-3 seconds from each other. This was causing
1395         the build bots to redownload WebKitAuxiliaryLibrary for every build,
1396         which would then cause all of WebCore to rebuild each time.
1397
1398         Reviewed by Mark.
1399
1400         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
1401         at least 30 seconds newer than the old one -- otherwise we assume that
1402         the difference in time is due to the mirrors being slightly offset
1403         from each other.
1404         (sub lastModifiedToUnixTime): Added.
1405
1406 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
1407
1408         Windows build fix.
1409
1410         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
1411
1412 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
1413
1414         Reviewed by Lars.
1415
1416         Moved QWebPage::open to QWebFrame::load and added setHtml.
1417
1418
1419         * DumpRenderTree/qt/DumpRenderTree.cpp:
1420         (WebCore::DumpRenderTree::open):
1421
1422 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
1423
1424         Reviewed by Lars.
1425
1426         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
1427
1428
1429         * DumpRenderTree/qt/DumpRenderTree.cpp:
1430         (WebCore::DumpRenderTree::DumpRenderTree):
1431
1432 2008-01-02  Sam Weinig  <sam@webkit.org>
1433
1434         * Scripts/do-webcore-rename: Yet more renaming ideas.
1435
1436 2008-01-02  Darin Adler  <darin@apple.com>
1437
1438         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
1439
1440 2008-01-02  Alice Liu  <alice.liu@apple.com>
1441
1442         Reviewed by Sam Weinig.
1443
1444         fixing assertion hit with editing/selection/move-begin-end.html
1445
1446         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
1447         * DumpRenderTree/win/DumpRenderTree.vcproj:
1448         * DumpRenderTree/win/EventSender.cpp:
1449         (keyDownCallback):
1450         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
1451
1452 2008-01-02  Darin Adler  <darin@apple.com>
1453
1454         * Scripts/do-webcore-rename: Some more name change plans.
1455
1456 2008-01-02  Alice Liu  <alice.liu@apple.com>
1457
1458         Reviewed by Maciej.
1459
1460         Added handling for page up and page down in EventSender
1461
1462         * DumpRenderTree/mac/EventSendingController.mm:
1463         (-[EventSendingController keyDown:withModifiers:]):
1464         * DumpRenderTree/win/EventSender.cpp:
1465         (keyDownCallback):
1466
1467 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
1468
1469         Reviewed by Darin.
1470
1471         Fix fast/events/arrow-keys-on-body.html for real.
1472
1473         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
1474
1475 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
1476
1477         Reviewed by Darin.
1478
1479         http://bugs.webkit.org/show_bug.cgi?id=16674
1480         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
1481
1482         * Scripts/run-launcher:
1483
1484 2007-12-31  Darin Adler  <darin@apple.com>
1485
1486         Suggested by Antti.
1487
1488         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
1489         we get it installed on the build bots.
1490
1491 2007-12-30  Eric Seidel  <eric@webkit.org>
1492
1493         Reviewed by Sam.
1494
1495         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
1496
1497 2007-12-29  Darin Adler  <darin@apple.com>
1498
1499         Reviewed by Oliver.
1500
1501         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
1502           leak bot shows createCStringFromNPVariant result leaking
1503
1504         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1505         (pluginInvoke): Added a missing free.
1506
1507 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1508
1509         Reviewed by Alp Toker.
1510
1511         http://bugs.webkit.org/show_bug.cgi?id=16390
1512         Use autotools or GNU make as the build system for the GTK port
1513
1514         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
1515         * GNUmakefile.am: Added.
1516
1517 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
1518
1519         Reviewed by Oliver.
1520
1521         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
1522
1523         * DumpRenderTree/win/EventSender.cpp:
1524         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
1525         of 1, even though WebKit currently ignores it.
1526
1527 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
1528
1529         wx buildbot fix. Update libpng dl script to the latest version.
1530
1531         * wx/install-unix-extras:
1532
1533 2007-12-22  Antti Koivisto  <antti@apple.com>
1534
1535         Fix a typo.
1536
1537         * Scripts/webkitdirs.pm:
1538
1539 2007-12-21  Sam Weinig  <sam@webkit.org>
1540
1541         Reviewed by Mark Rowe.
1542
1543         - Disable the back/forward cache using the new WebPreferences API
1544           instead of through the BackForwardList.  This makes us match what
1545           we do on Windows.
1546
1547         * DumpRenderTree/mac/DumpRenderTree.mm:
1548         (createWebViewAndOffscreenWindow):
1549         (setDefaultsToConsistentValuesForTesting):
1550
1551 2007-12-21  Dan Bernstein  <mitz@apple.com>
1552
1553         Reviewed by Mark Rowe.
1554
1555         - disable the back/forward cache in Windows DumpRenderTree. It is
1556           already disabled in Mac DumpRenderTree.
1557
1558         * DumpRenderTree/win/DumpRenderTree.cpp:
1559         (initializePreferences):
1560
1561 2007-12-13  Antti Koivisto  <antti@apple.com>
1562
1563         Reviewed by Darin and Steve.
1564
1565         - check for QuickTime SDK on Windows.
1566         - build media support on Windows by default
1567
1568         * Scripts/build-webkit:
1569         * Scripts/webkitdirs.pm:
1570
1571 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
1572
1573         Build script fix for buildbot.
1574
1575         * wx/build-wxwebkit:
1576
1577 2007-12-20  Eric Seidel  <eric@webkit.org>
1578
1579         Reviewed by mjs.
1580
1581         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
1582
1583 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1584
1585         Reviewed by Steve.
1586
1587         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
1588         WebKit.
1589
1590         - Drosera and Safari need to use the same ProgIDs in order for
1591         CoCreateInstance to work properly.  The most robust way to do this is
1592         for WebKit to dynamically publish those ProgIDs.
1593
1594         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
1595         (DebuggerClient::createWebViewWithRequest):
1596         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
1597         statics.
1598         (Drosera::initUI):
1599         (Drosera::attach):
1600         (Drosera::attemptToCreateServerConnection):
1601         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
1602         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
1603         make use of the published ProgIDs.
1604         (ServerConnection::attemptToCreateServerConnection):
1605
1606 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1607
1608         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
1609         - Build bot and leak fix.
1610
1611         * DumpRenderTree/LayoutTestController.cpp:
1612         (pathToLocalResourceCallback):
1613
1614 2007-12-19  David Kilzer  <ddkilzer@apple.com>
1615
1616         Make svn-apply/svn-unapply work with patches from git-format-patch.
1617
1618         Reviewed by Darin.
1619
1620         * Scripts/svn-apply:
1621         (patch): If 'Index:' can't be found in the text passed in, print it
1622         out with a warning and return early.
1623         * Scripts/svn-unapply:
1624         (patch): Ditto.
1625
1626 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
1627
1628         Reviewed by Alp Toker.
1629
1630         Build related fixes.
1631
1632         * wx/build-wxwebkit:
1633         - Check to make sure the user is running a supported wx port
1634         - More robust checks for Cygwin
1635         - Only run install-unix-extras on Mac, it's not the right solution
1636           for Linux distros.
1637         - Remove outdated Linux instructions after successful build
1638         - Clean Bakefile-generated files during a clean operation
1639
1640 2007-12-18  Darin Adler  <darin@apple.com>
1641
1642         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
1643
1644 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
1645
1646         Add script to run Drosera as part of the nightly.
1647
1648         Reviewed by Kevin M.
1649
1650         * Scripts/run-drosera.cmd: Added.
1651
1652 2007-12-18  Darin Adler  <darin@apple.com>
1653
1654         * Scripts/do-webcore-rename: Remove a stray K.
1655
1656 2007-12-18  Darin Adler  <darin@apple.com>
1657
1658         * Scripts/do-webcore-rename: Plan more renaming.
1659
1660 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
1661
1662         Reviewed by Alp Toker.
1663
1664         http://bugs.webkit.org/show_bug.cgi?id=16042
1665         [GTK] Eliminate webkit_init()
1666
1667         Moving webkit initialization to WebView class init.
1668
1669         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1670         (main):
1671         * GtkLauncher/main.c:
1672         (main):
1673
1674 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
1675
1676         Reviewed by Alp Toker.
1677
1678         http://bugs.webkit.org/show_bug.cgi?id=13542
1679         gdklauncher doesnt change URL in adress GTKEntry.
1680
1681         * GtkLauncher/main.c:
1682         (load_commit_cb): added
1683         (title_change_cb):
1684         (create_browser):
1685
1686 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
1687
1688         Reviewed by Adam Roben.
1689
1690         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
1691
1692         * FindSafari/FindSafari.cpp:
1693         (_tmain):
1694
1695 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
1696
1697         Reviewed by Adam Roben.
1698
1699         http://bugs.webkit.org/show_bug.cgi?id=16315
1700         FindSafari needs a path-only option.
1701
1702         * FindSafari/FindSafari.cpp:
1703         (_tmain):
1704
1705 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
1706
1707         Reviewed by Darin.
1708
1709         http://bugs.webkit.org/show_bug.cgi?id=16462
1710         REGRESSION: access keys broken on Windows
1711
1712         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
1713         if Alt is pressed.
1714
1715 2007-12-15  Sam Weinig  <sam@webkit.org>
1716
1717         Reviewed by Mark Rowe.
1718
1719         Fix urlSuitableForTestResult to correctly identify wstring::npos as
1720         the case when wstring.find doesn't find anything.
1721
1722         * DumpRenderTree/win/DumpRenderTree.cpp:
1723         (urlSuitableForTestResult):
1724
1725 2007-12-15  Alp Toker  <alp@atoker.com>
1726
1727         GTK+ DRT build fix for GLib < 2.14.
1728
1729         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1730         (LayoutTestController::setWaitToDump):
1731
1732 2007-12-05  Mark Rowe  <mrowe@apple.com>
1733
1734         Reviewed by Alp Toker.
1735
1736         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
1737         many layout tests from hanging while waiting on user responses to dialogs.
1738
1739         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1740         (invalidateAnyPreviousWaitToDumpWatchdog):
1741         (webViewScriptAlert):
1742         (webViewScriptPrompt):
1743         (webViewScriptConfirm):
1744         (main):
1745         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1746         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1747         (waitToDumpWatchdogFired):
1748         (LayoutTestController::setWaitToDump):
1749
1750 2007-12-05  Mark Rowe  <mrowe@apple.com>
1751
1752         Reviewed by Alp Toker.
1753
1754         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
1755
1756         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1757         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
1758         (dump):
1759         (runTest):
1760         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
1761         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
1762         work queue is empty.
1763         (webViewWindowObjectCleared): Set up window.layoutTestController.
1764         (webViewConsoleMessage): Match the console message format expected by the layout test results.
1765         (main): Hook up the new signals.
1766         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1767         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
1768         dumping multiple times.
1769         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
1770         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
1771
1772 2007-12-14  Anders Carlsson  <andersca@apple.com>
1773
1774         Reviewed by Brady.
1775
1776         Assert that a web frame that's loading a resource always has either a data source or
1777         a provisional data source.
1778
1779         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1780         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1781
1782 2007-12-14  Darin Adler  <darin@apple.com>
1783
1784         - fix mistake causing nearly all tests to fail on Windows
1785
1786         * DumpRenderTree/win/UIDelegate.cpp:
1787         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
1788         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
1789
1790         * DumpRenderTree/mac/UIDelegate.mm:
1791         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
1792         than passing the entire message.
1793
1794 2007-12-14  Darin Adler  <darin@apple.com>
1795
1796         - fix Tiger build
1797
1798         * DumpRenderTree/mac/UIDelegate.mm:
1799         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
1800         new-to-Leopard methods.
1801
1802 2007-12-14  Darin Adler  <darin@apple.com>
1803
1804         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
1805         since it now triggers unwanted icon loading. We only had it because we implemented "all"
1806         delegate methods here.
1807
1808 2007-12-14  Anders Carlsson  <andersca@apple.com>
1809
1810         Reviewed by Darin and Geoff.
1811
1812         <rdar://problem/5619295>
1813         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
1814
1815         Add property getting methods to the plug-in.
1816
1817         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1818         (pluginInvoke):
1819
1820 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
1821
1822         Reviewed by Darin.
1823
1824         - Layout test fix for mac. When dumped to the console local file paths
1825         now only show the name of the resource not the whole path.  This is to
1826         make the results machine and OS independent.
1827
1828         * DumpRenderTree/mac/UIDelegate.mm:
1829         (-[UIDelegate webView:addMessageToConsole:]):
1830
1831 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
1832
1833         Reviewed by Adam.
1834
1835         - Layout tests fix.  We need a way to remove machine-dependent
1836         information from paths in layout test results. The UIDelegate now does
1837         this.
1838
1839         * DumpRenderTree/DumpRenderTree.h:
1840         * DumpRenderTree/win/DumpRenderTree.cpp:
1841         (urlSuitableForTestResult):
1842         * DumpRenderTree/win/DumpRenderTreeWin.h:
1843         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1844         * DumpRenderTree/win/UIDelegate.cpp:
1845         (UIDelegate::webViewAddMessageToConsole):
1846
1847 2007-12-13  Alp Toker  <alp@atoker.com>
1848
1849         Build fix for DRT breakage introduced in r28690.
1850
1851         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1852         (LayoutTestController::pathToLocalResource):
1853
1854 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
1855
1856         Reviewed by Alice and Sam.
1857
1858         - <rdar://5621435> Need a way to specify local resources (being loaded
1859         from HTTP tests) on Windows.
1860         - Implemented pathToLocalResource which exposes the functionality of
1861         converting a given unix path to the correct location on Windows.
1862
1863         * DumpRenderTree/LayoutTestController.cpp:
1864         (pathToLocalResourceCallback):
1865         (LayoutTestController::staticFunctions):
1866         * DumpRenderTree/LayoutTestController.h:
1867         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1868         (LayoutTestController::pathToLocalResource):
1869         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1870         (LayoutTestController::pathToLocalResource):
1871
1872 2007-12-12  Anders Carlsson  <andersca@apple.com>
1873
1874         Reviewed by Sam.
1875
1876         <rdar://problem/5132003>
1877         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
1878
1879         * DumpRenderTree/win/DumpRenderTree.cpp:
1880         (main):
1881         Set the resource load delegate.
1882
1883         * DumpRenderTree/win/DumpRenderTree.vcproj:
1884
1885         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
1886         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
1887
1888 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
1889
1890         Reviewed by Adam Roben.
1891
1892         Fix conversion from double to LPARAM in dispatchMessage().
1893
1894         * DumpRenderTree/win/EventSender.cpp:
1895         (dispatchMessageCallback):
1896
1897 2007-12-11  Dan Bernstein  <mitz@apple.com>
1898
1899         Reviewed by Mark Rowe and Sam Weinig too!
1900
1901         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
1902           fonts DumpRenderTree registers.
1903
1904         * DumpRenderTree/win/DumpRenderTree.cpp:
1905         (initialize):
1906
1907 2007-12-11  Brady Eidson  <beidson@apple.com>
1908
1909         Reviewed by Anders
1910
1911         Make DumpRenderTree on mac use its own path for Databases testing
1912
1913         * DumpRenderTree/mac/DumpRenderTree.mm:
1914         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree
1915           for future DRT-only use, then use it to construct the Databases path and set that default
1916
1917 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
1918
1919         Reviewed by Darin.
1920
1921         <rdar://problem/5535636>
1922         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
1923
1924         http://bugs.webkit.org/show_bug.cgi?id=13916
1925         JavaScript detects Tab as a character input on a textfield validation
1926
1927         * DumpRenderTree/mac/EventSendingController.mm:
1928         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
1929         Dispatch a keyup to better match what happens when a key is physically pressed.
1930
1931         * DumpRenderTree/win/EventSender.cpp:
1932         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
1933         returning from keyDown().
1934         (getConstantCallback): Fixed a couple copy/paste mistakes.
1935
1936 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
1937
1938         Reviewed by Oliver.
1939
1940         - <rdar://5599845> Drosera: Does not show loal files in the file list
1941         on the left side.
1942
1943         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
1944         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
1945         so the open source community can build.
1946
1947 2007-12-10  Brady Eidson  <beidson@apple.com>
1948
1949         Rubberstamped by Sam Weinig
1950
1951         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
1952
1953         * DumpRenderTree/mac/UIDelegate.mm:
1954         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1955         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1956
1957 2007-12-08  Oliver Hunt  <oliver@apple.com>
1958
1959         Reviewed by Sam W.
1960
1961         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
1962
1963         Fixes <rdar://problem/5620249> Must disable SVG animation
1964         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
1965
1966         In order to allow finer grained control over the set of SVG features
1967         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
1968         distinct flags:
1969         ENABLE_SVG_ANIMATION
1970         ENABLE_SVG_FILTERS
1971         ENABLE_SVG_FONTS
1972         ENABLE_SVG_AS_IMAGE
1973         ENABLE_SVG_USE
1974
1975         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
1976
1977         Script handles all the new build flags, and allows --svg-experimental
1978         to automatically enable all features.
1979
1980         * Scripts/build-webkit:
1981
1982 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1983
1984         Fix version parsing.
1985
1986         Rubber-stamped by Oliver.
1987
1988         * Drosera/win/Drosera.vcproj/auto-version.sh:
1989
1990 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
1991
1992         Build modifications for Drosera.
1993
1994         Reviewed by Adam.
1995
1996         * Drosera/DroseraWin.make: Added.
1997         * Drosera/win/Drosera.vcproj/Drosera.rc:
1998         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1999         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
2000         * Drosera/win/Drosera.vcproj/VERSION: Added.
2001         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
2002
2003 2007-12-06  Adam Roben  <aroben@apple.com>
2004
2005         Explicitly turn on the Mac font ascent hack on Windows
2006
2007         This keeps our font metrics matching those from Mac.
2008
2009         Reviewed by Hyatt.
2010
2011         * DumpRenderTree/win/DumpRenderTree.cpp:
2012         (main):
2013
2014 2007-12-06  Anders Carlsson  <andersca@apple.com>
2015
2016         Rename main.c to main.cpp here too.
2017
2018         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
2019
2020 2007-12-06  Sam Weinig  <sam@webkit.org>
2021
2022         Rubber stamped by Geoff.
2023
2024         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
2025
2026 2007-12-06  Darin Adler  <darin@apple.com>
2027
2028         * Scripts/do-webcore-rename: Some more renaming plans.
2029
2030 2007-12-06  Anders Carlsson  <andersca@apple.com>
2031
2032         Restore implementation of testGetIntIdentifier that was accidentally
2033         removed somehow (possibly when I made PluginObject be a cpp file).
2034
2035         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2036         (pluginInvoke):
2037
2038 2007-12-05  Anders Carlsson  <andersca@apple.com>
2039
2040         Make the entry points extern "C".
2041         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2042
2043 2007-12-05  Anders Carlsson  <andersca@apple.com>
2044
2045         C++ warning fixes.
2046
2047         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2048         (NPP_New):
2049         (NPP_Destroy):
2050         (NPP_SetWindow):
2051         (NPP_NewStream):
2052         (NPP_HandleEvent):
2053         (NPP_URLNotify):
2054         (NPP_GetValue):
2055
2056 2007-12-05  Anders Carlsson  <andersca@apple.com>
2057
2058         Add the .cpp files to the TestNetscapePlugIn target.
2059
2060         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2061
2062 2007-12-05  Anders Carlsson  <andersca@apple.com>
2063
2064         Reviewed by Geoff.
2065
2066         Rename the TestNetscapePlugIn .c files to be .cpp.
2067
2068         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2069         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
2070         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
2071         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
2072         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
2073         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
2074         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
2075         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2076
2077 2007-12-05  Adam Roben  <aroben@apple.com>
2078
2079         Fix case of keypresses from the Windows implementation of eventSender.keyDown
2080
2081         This fixes several regression tests.
2082
2083         Reviewed by Alice.
2084
2085         * DumpRenderTree/win/EventSender.cpp:
2086         (keyDownCallback): Virtual keycodes for ASCII characters are always
2087         uppercase, so we need to check the case of the original character
2088         passed in to eventSender.keyDown.
2089
2090 2007-12-05  Adam Roben  <aroben@apple.com>
2091
2092         Learn from Tim's mistakes
2093
2094         * DumpRenderTree/win/DumpRenderTree.cpp:
2095         (runTest): Reset the authorAndUserStylesEnabled preference for each
2096         test.
2097
2098 2007-12-05  Alp Toker  <alp@atoker.com>
2099
2100         Reviewed by Mark Rowe.
2101
2102         Initialize GTK+ and WebKit so the tests can run.
2103
2104         Reorganize the headers a little.
2105
2106         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2107         (main):
2108
2109 2007-12-04  Anders Carlsson  <andersca@apple.com>
2110
2111         Remove IWebScriptScope include.
2112
2113         * Drosera/win/DebuggerDocumentPlatform.cpp:
2114
2115 2007-12-04  Sam Weinig  <sam@webkit.org>
2116
2117         Rubber stamped by Mark Rowe.
2118
2119         Define CF as platform for mac and revert r28409
2120
2121         * DumpRenderTree/DumpRenderTree.h:
2122         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2123
2124 2007-12-04  Sam Weinig  <sam@webkit.org>
2125
2126         Define CF as platform for windows.
2127
2128         Reviewed by Adam Roben.
2129
2130         * DumpRenderTree/win/DumpRenderTreeWin.h:
2131
2132 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
2133
2134         Reviewed by Adam and Darin.
2135
2136         - Removed a needless BSTR cleanup.
2137
2138         * Drosera/win/DebuggerDocumentPlatform.cpp:
2139         (DebuggerDocument::getPlatformCurrentFunctionStack):
2140
2141 2007-11-27  Adam Roben  <aroben@apple.com>
2142
2143         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
2144
2145         Reviewed by Maciej.
2146
2147         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2148         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
2149
2150 2007-12-04  Alp Toker  <alp@atoker.com>
2151
2152         Prospective Win DRT build fix.
2153
2154         * DumpRenderTree/DumpRenderTree.h:
2155
2156 2007-12-04  Alp Toker  <alp@atoker.com>
2157
2158         Fix a clobbered copyright header.
2159
2160         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2161
2162 2007-12-04  Xan Lopez  <xan@gnome.org>
2163
2164         Reviewed by Alp Toker.
2165
2166         http://bugs.webkit.org/show_bug.cgi?id=15561
2167         GTK port needs DumpRenderTree implementation
2168
2169         Start work on the GTK+ DRT.
2170
2171         This does not work yet, and there are a few lingering style issues
2172         (nothing major) but this patch has been stuck in the bug tracker for
2173         too long already.
2174
2175         * DumpRenderTree/DumpRenderTree.h:
2176         * DumpRenderTree/gtk: Added.
2177         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
2178         (autocorrectURL):
2179         (shouldLogFrameLoadDelegates):
2180         (dumpFrameScrollPosition):
2181         (displayWebView):
2182         (appendString):
2183         (dumpFramesAsText):
2184         (dumpRenderTreeAsText):
2185         (dump):
2186         (runTest):
2187         (main):
2188         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
2189         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
2190         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
2191         (GCController::collect):
2192         (GCController::collectOnAlternateThread):
2193         (GCController::getJSObjectCount):
2194         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
2195         (LayoutTestController::~LayoutTestController):
2196         (LayoutTestController::addDisallowedURL):
2197         (LayoutTestController::clearBackForwardList):
2198         (LayoutTestController::copyDecodedHostName):
2199         (LayoutTestController::copyEncodedHostName):
2200         (LayoutTestController::display):
2201         (LayoutTestController::keepWebHistory):
2202         (LayoutTestController::notifyDone):
2203         (LayoutTestController::queueBackNavigation):
2204         (LayoutTestController::queueForwardNavigation):
2205         (LayoutTestController::queueLoad):
2206         (LayoutTestController::queueReload):
2207         (LayoutTestController::queueScript):
2208         (LayoutTestController::setAcceptsEditing):
2209         (LayoutTestController::setCustomPolicyDelegate):
2210         (LayoutTestController::setMainFrameIsFirstResponder):
2211         (LayoutTestController::setTabKeyCyclesThroughElements):
2212         (LayoutTestController::setUseDashboardCompatibilityMode):
2213         (LayoutTestController::setUserStyleSheetEnabled):
2214         (LayoutTestController::setUserStyleSheetLocation):
2215         (LayoutTestController::setWindowIsKey):
2216         (LayoutTestController::setWaitToDump):
2217         (LayoutTestController::windowCount):
2218         (LayoutTestController::setPrivateBrowsingEnabled):
2219         (LayoutTestController::setAuthorAndUserStylesEnabled):
2220         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
2221         (JSStringCopyUTF8CString):
2222         (LoadItem::invoke):
2223         (ReloadItem::invoke):
2224         (ScriptItem::invoke):
2225         (BackForwardItem::invoke):
2226
2227 2007-12-03  Sam Weinig  <sam@webkit.org>
2228
2229         Move JavaScriptCore thread testing code to pthread specific directory
2230         and remove the dependance on CoreFoundation by using WTF::HashSet.
2231
2232         Reviewed by Geoff and Oliver.
2233
2234         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2235         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
2236         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
2237         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
2238         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
2239         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
2240         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
2241         * DumpRenderTree/pthreads: Added.
2242         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
2243         (javaScriptThreads):
2244         (runJavaScriptThread):
2245         (startJavaScriptThreads):
2246         (stopJavaScriptThreads):
2247
2248 2007-12-03  Andrew Bonventre  <andybons@google.com>
2249
2250         Reviewed by Darin Adler.
2251
2252         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
2253         Symbol lookup menu broken in debugger view
2254
2255         * Drosera/debugger.js: Fixed javascript error where document property
2256         should have been used instead of contentDocument in switchFunction that
2257         was breaking the select symbol dropdown menu.  This is because
2258         window.frames will return a Window object and not a frame object like
2259         the author was originally expecting.
2260
2261 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
2262
2263         Reviewed by Adam.
2264
2265         - <rdar://5618942> Drosera: Console window does not process everything
2266         correctly.
2267         - <rdar://5619005> Drosera: could be sped up by moving the
2268         WebScriptScope stuff into the WebScriptCallFrame.
2269         - Now the console can correctly process objects and does not receive
2270         notifications from JavaScriptCore about the JavaScript in Drosera's
2271         own process.
2272
2273         * Drosera/win/DebuggerDocumentPlatform.cpp:
2274         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2275         (DebuggerDocument::platformValueForScopeVariableNamed):
2276
2277 2007-12-03  Stephanie  <slewis@apple.com>
2278
2279         Reviewed by Darin.
2280
2281         Check to see if we are building a debug root
2282
2283         * Scripts/check-for-global-initializers:
2284
2285 2007-12-03  Dan Bernstein  <mitz@apple.com>
2286
2287         Reviewed by Darin Adler.
2288
2289         - added a testGetIntIdentifier() method to TestNetscapePlugIn
2290
2291         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
2292         (pluginInvoke):
2293
2294 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
2295
2296         Reviewed by Oliver.
2297
2298         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
2299         in a more fine-grained manner than eventSender.keyDown().
2300
2301         * DumpRenderTree/win/EventSender.cpp:
2302         (getConstantCallback):
2303         (dispatchMessageCallback):
2304
2305 2007-12-02  Darin Adler  <darin@apple.com>
2306
2307         * Scripts/do-webcore-rename: More planned renaming.
2308
2309 2007-12-02  Sam Weinig  <sam@webkit.org>
2310
2311         Rubber stamped by Anders.
2312
2313         Use [NSURL absoluteString] instead of [NSURL description] in order to get
2314         more uniform results cross platform.
2315
2316         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2317         (-[NSURL _drt_descriptionSuitableForTestResult]):
2318
2319 2007-12-02  Sam Weinig  <sam@webkit.org>
2320
2321         Rubber stamped by Niko.
2322
2323         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
2324
2325         * DumpRenderTree/win/DumpRenderTree.cpp:
2326         * DumpRenderTree/win/DumpRenderTree.vcproj:
2327         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
2328         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
2329         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
2330         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
2331
2332 2007-12-01  Alp Toker  <alp@atoker.com>
2333
2334         Reviewed by Adam Roben.
2335
2336         Make use of the newly introduced webkit.h convenience header.
2337
2338         * GtkLauncher/main.c:
2339
2340 2007-12-01  Adam Treat  <treat@kde.org>
2341
2342         Reviewed by Simon.
2343
2344         * Check to see if the directory exists and exit if not.
2345
2346         * DumpRenderTree/qt/main.cpp:
2347         (main):
2348
2349 2007-12-01  Adam Treat  <treat@kde.org>
2350
2351         Reviewed by Simon.
2352
2353         * Don't hide symbols when in Debug mode
2354         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
2355
2356
2357         * DumpRenderTree/qt/main.cpp:
2358         (messageHandler):
2359
2360 2007-11-30  Alp Toker  <alp@atoker.com>
2361
2362         Reviewed by Adam Roben.
2363
2364         http://bugs.webkit.org/show_bug.cgi?id=15691
2365         [GTK] Public API does not follow GTK+ conventions
2366
2367         Refactor the WebKit/GTK+ public API. Changes:
2368           WebKitPage -> WebKitWebView
2369           WebKitFrame -> WebKitWebFrame
2370
2371         Public API source and header names have been updated to mirror the API
2372         changes.
2373
2374         The API is now kept in WebKit/gtk/WebView to match other ports in the
2375         same class such as Mac and Win.
2376
2377         * GtkLauncher/main.c:
2378         (activate_uri_entry_cb):
2379         (link_hover_cb):
2380         (title_change_cb):
2381         (progress_change_cb):
2382         (go_back_cb):
2383         (go_forward_cb):
2384         (create_browser):
2385         (main):
2386
2387 2007-11-30  Adam Roben  <aroben@apple.com>
2388
2389         Hopefully the final build fix
2390
2391         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
2392         pull in WTF's assertion/logging functions.
2393
2394 2007-11-30  Adam Roben  <aroben@apple.com>
2395
2396         Another build fix
2397
2398         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
2399         WebKit.lib.
2400
2401 2007-11-30  Adam Roben  <aroben@apple.com>
2402
2403         Debug build fix
2404
2405         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
2406         configuration.
2407         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
2408         projects.
2409         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
2410         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
2411         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
2412
2413 2007-11-30  Sam Weinig  <sam@webkit.org>
2414
2415         Reviewed by Adam Roben.
2416
2417         Fix drawSelectionRect to actually draw the selection rect.
2418
2419         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2420         (drawSelectionRect):
2421
2422 2007-11-30  Darin Adler  <darin@apple.com>
2423
2424         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
2425
2426 2007-11-30  Darin Adler  <darin@apple.com>
2427
2428         * Scripts/do-webcore-rename: Get ready for some future renaming.
2429
2430 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2431
2432         Reviewed by Adam.
2433
2434         - Removed some unnecessary functions and changed an unused return type.
2435
2436         * Drosera/win/DebuggerClient.cpp:
2437         (registerConsoleClass):
2438         * Drosera/win/DebuggerClient.h:
2439         * Drosera/win/Drosera.cpp:
2440         (registerDroseraClass):
2441
2442 2007-11-28  Alp Toker  <alp@atoker.com>
2443
2444         Reviewed by Timothy Hatcher.
2445
2446         http://bugs.webkit.org/show_bug.cgi?id=16174
2447         [GTK] Use "URI" not "URL" in public API
2448
2449         Replace use of the term "URL" with "URI" in public headers,
2450         documentation and some internal code to match GLib/GTK+ convention.
2451
2452         This is now mentioned in the API guidelines:
2453           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
2454
2455         * GtkLauncher/main.c:
2456         (activate_uri_entry_cb):
2457         (title_change_cb):
2458         (create_toolbar):
2459         (main):
2460
2461 2007-11-29  Anders Carlsson  <andersca@apple.com>
2462
2463         Reviewed by Sam.
2464
2465         <rdar://problem/5230478>
2466         FrameLoadDelegate callbacks are not dumped in DRT.
2467
2468         * DumpRenderTree/win/DumpRenderTree.cpp:
2469         (shouldLogFrameLoadDelegates):
2470         (runTest):
2471         (main):
2472         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2473         (BSTRtoString):
2474         (descriptionSuitableForTestResult):
2475         (FrameLoadDelegate::QueryInterface):
2476         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2477         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2478         (FrameLoadDelegate::didCommitLoadForFrame):
2479         (FrameLoadDelegate::didFinishLoadForFrame):
2480         (FrameLoadDelegate::willCloseFrame):
2481         (FrameLoadDelegate::didClearWindowObject):
2482         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2483         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2484         * DumpRenderTree/win/FrameLoaderDelegate.h:
2485         (FrameLoadDelegate::windowScriptObjectAvailable):
2486         (FrameLoadDelegate::didFirstLayoutInFrame):
2487
2488 2007-11-29  Sam Weinig  <sam@webkit.org>
2489
2490         Reviewed by Anders.
2491
2492         Add database quota UIDelegates methods to DRT UIDelegate.
2493
2494         * DumpRenderTree/mac/UIDelegate.mm:
2495         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
2496         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
2497
2498 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2499
2500         Reviewed by Sam.
2501
2502         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
2503         dying and vice versa.
2504         - This fix will allow Drosera and Safari to reconnect if either of them
2505         closes correctly, but does not fix the case where one of them dies
2506         silently.
2507
2508         * Drosera/win/ServerConnection.cpp:
2509         (ServerConnection::attemptToCreateServerConnection): Added a safety
2510         check, because it's possilbe to try to connect to a server that's dying.
2511         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
2512         the server has died.
2513         * Drosera/win/ServerConnection.h: Added the new function and removed
2514         an unnecessary member.
2515
2516 2007-11-29  Anders Carlsson  <andersca@apple.com>
2517
2518         * DumpRenderTree/win/DumpRenderTree.vcproj:
2519         Add shlwapi.lib to all configurations.
2520
2521 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2522
2523         - Build fix.  Added additional includes for VS Express to the Release
2524         project.
2525
2526         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2527
2528 2007-11-29  Anders Carlsson  <andersca@apple.com>
2529
2530         Reviewed by Adam.
2531
2532         <rdar://problem/5132005>
2533         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
2534
2535         * DumpRenderTree/win/DumpRenderTree.vcproj:
2536         Add shlwapi.lib
2537
2538         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2539         (LayoutTestController::setUserStyleSheetEnabled):
2540         Implement this.
2541
2542         (appendComponentToPath):
2543         New method which wraps the Win32 API PathAppend.
2544
2545         (followShortcuts):
2546         New method which checks if a file points to a shortcut and
2547         follows the shortcut.
2548
2549         (resolveCygwinPath):
2550         New method that takes a cygwin unix-style path and returns the Win32 path.
2551
2552         (cfStringRefToWString):
2553
2554         (LayoutTestController::setUserStyleSheetLocation):
2555         Implement this.
2556
2557 2007-11-29  Alice Liu  <alice.liu@apple.com>
2558
2559         Reviewed by Adam.
2560
2561         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
2562
2563         * DumpRenderTree/win/EventSender.cpp:
2564         (keyDownCallback):
2565         uppercase letters were being sent as lowercase letters without the shift key down.
2566
2567 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2568
2569         - Windows build fix. VS express needs some love.
2570
2571         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2572
2573 2007-11-28  Darin Adler  <darin@apple.com>
2574
2575         Reviewed by Adam Roben.
2576
2577         * DumpRenderTree/mac/EventSendingController.mm:
2578         (-[EventSendingController keyDown:withModifiers:]):
2579         Send capital letters through as lowercase letters with the shift key down
2580         rather than sending them as if they were highly unusual "capital letter keys".
2581
2582         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
2583         where you need to update results and more tests are failing than before.
2584
2585 2007-11-28  Anders Carlsson  <andersca@apple.com>
2586
2587         Reviewed by Darin.
2588
2589         <rdar://problem/5132001>
2590         contextClick is not implemented in DRT on Windows.
2591
2592         * DumpRenderTree/win/EventSender.cpp:
2593         (contextClickCallback):
2594         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
2595         by a WM_RBUTTONUP message.
2596
2597         * DumpRenderTree/win/UIDelegate.cpp:
2598         (UIDelegate::hasCustomMenuImplementation):
2599         (UIDelegate::trackCustomPopupMenu):
2600         * DumpRenderTree/win/UIDelegate.h:
2601         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
2602         menu from being shown (and causing the DRT to hang).
2603
2604 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
2605
2606         Reviewed by Darin.
2607
2608         Fix DumpRenderTree ObjC bug comparing strings.
2609
2610         * DumpRenderTree/mac/ObjCController.m:
2611         (-[ObjCController identityIsEqual::]): Compare strings with string
2612         equality instead of identiy equality.
2613
2614 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2615
2616         Reviewed by Sam.
2617
2618         Reset the authorAndUserStylesEnabled preference
2619         back to YES for each test. Fixes the broken tests.
2620
2621         * DumpRenderTree/mac/DumpRenderTree.mm:
2622         (resetWebViewToConsistentStateBeforeTesting):
2623
2624 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
2625
2626         Reviewed by Adam.
2627
2628         - Drosera now displays the console window, although it cannot currently
2629         process JavaScript.
2630
2631         * Drosera/win/DebuggerClient.cpp: Shows the console window.
2632         (registerConsoleClass): Implemented.
2633         (consoleWndProc): Implemented.
2634         (DebuggerClient::onSize): Implemented.
2635         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
2636         new window.
2637         * Drosera/win/DebuggerClient.h: Added needed method and members for
2638         creating and maintaining a new window.
2639         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
2640         lines of code to more appropriate places.
2641         (Drosera::handleCommand):
2642         (Drosera::initUI):
2643         (Drosera::onSize):
2644         (Drosera::attach):
2645
2646 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2647
2648         Reviewed by Dave Hyatt.
2649
2650         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
2651
2652         Add support for disabling author and user styles for testing.
2653
2654         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2655         * DumpRenderTree/LayoutTestController.cpp:
2656         (setAuthorAndUserStylesEnabledCallback):
2657         (LayoutTestController::staticFunctions):
2658         * DumpRenderTree/LayoutTestController.h:
2659         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2660         (LayoutTestController::setAuthorAndUserStylesEnabled):
2661         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2662         (LayoutTestController::setAuthorAndUserStylesEnabled):
2663
2664 2007-11-26  Dan Bernstein  <mitz@apple.com>
2665
2666         - Tiger build fix.
2667
2668         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2669
2670 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
2671
2672         Reviewed by Maciej.
2673
2674         - Implemented displaying variables for Drosera on Win.
2675
2676         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
2677         that retrieve variables to not hold onto the return value since it's
2678         not returned.  Also changed to use the new signatures of the retrieval
2679         functions.
2680         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2681         (DebuggerDocument::platformValueForScopeVariableNamed):
2682         * Drosera/win/Drosera.cpp: Removed a needless TODO.
2683         (droseraWndProc):
2684
2685 2007-11-26  Sam Weinig  <sam@webkit.org>
2686
2687         Cleanup names of painting and repainting functions.
2688
2689         Reviewed by Adam Roben.
2690
2691         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2692         (drawSelectionRect): was drawSelectionRectIntoContext.
2693         (dumpWebViewAsPixelsAndCompareWithExpected):
2694         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2695         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2696         (paintWebView): was drawWebViewIntoContext.
2697         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
2698
2699 2007-11-26  Sam Weinig  <sam@webkit.org>
2700
2701         Reviewed by Dan Bernstein.
2702
2703         - Leopard build fix
2704
2705         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2706
2707 2007-11-26  Sam Weinig  <sam@webkit.org>
2708
2709         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
2710         Use shared PixelDumpSupport for Mac DRT
2711
2712         Reviewed by Adam Roben.
2713
2714         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2715         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
2716         * DumpRenderTree/cg/ImageDiffCG.cpp:
2717         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2718         (drawSelectionRectIntoContext):
2719         (dumpWebViewAsPixelsAndCompareWithExpected):
2720         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2721         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2722         * DumpRenderTree/mac/DumpRenderTree.mm:
2723         (dump):
2724         * DumpRenderTree/mac/ImageDiff.m: Removed.
2725         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
2726         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
2727         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
2728         (setDefaultColorProfileToRGB):
2729         (getBitmapContextFromWebView):
2730         (drawWebViewIntoContext):
2731         (repaintWithVerticalSweep):
2732         (repaintWithHorizontalSweep):
2733         (getSelectionRect):
2734         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
2735
2736 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
2737
2738         Bug 16052: prepare-ChangeLog doesn't report deleted files
2739         <http://bugs.webkit.org/show_bug.cgi?id=16052>
2740
2741         Reviewed by Sam.
2742
2743         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
2744
2745 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
2746
2747         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
2748         <http://bugs.webkit.org/show_bug.cgi?id=15864>
2749
2750         Reviewed by Adam.
2751
2752         Roll functionality of merge-changelog into resolve-ChangeLogs
2753         script.  The script now checks for ChangeLog.rej and
2754         ChangeLog.orig files first.  If it finds them, it uses the
2755         ChangeLog.rej file as a patch (in old contextual diff format) to
2756         apply with --fuzz=3.
2757
2758         * Scripts/merge-changelog: Removed.
2759         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
2760
2761 2007-11-25  Sam Weinig  <sam@webkit.org>
2762
2763         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
2764
2765         Reviewed by Mark Rowe.
2766
2767         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2768         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2769         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2770         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
2771         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
2772
2773 2007-11-25  Sam Weinig  <sam@webkit.org>
2774
2775         Convert DumpRenderTree to ues .xcconfig files.
2776
2777         Reviewed by Mark Rowe.
2778
2779         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2780         * DumpRenderTree/mac/Configurations: Added.
2781         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
2782         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
2783         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
2784
2785 2007-11-25  Sam Weinig  <sam@webkit.org>
2786
2787         Add ForwardingHeaders to wtf for DumpRenderTree.
2788
2789         Reviewed by Mark Rowe.
2790
2791         * DumpRenderTree/DumpRenderTree.h:
2792         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2793         * DumpRenderTree/ForwardingHeaders: Added.
2794         * DumpRenderTree/ForwardingHeaders/wtf: Added.
2795         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
2796         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
2797         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
2798         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
2799         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
2800         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
2801         * DumpRenderTree/LayoutTestController.cpp:
2802         * DumpRenderTree/WorkQueue.cpp:
2803         * DumpRenderTree/mac/DumpRenderTree.mm:
2804         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2805         * DumpRenderTree/mac/JavaScriptThreading.cpp:
2806         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2807         * DumpRenderTree/mac/ObjCController.m:
2808         * DumpRenderTree/mac/UIDelegate.mm:
2809         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2810
2811 2007-11-25  Adam Roben  <aroben@apple.com>
2812
2813         Fix some test failures caused by r28019
2814
2815         Now that stdout is in binary mode, we need to always use printf
2816         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
2817         the output.
2818
2819         Reviewed by Sam.
2820
2821         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
2822         printf.
2823         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2824         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2825         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2826         (UIDelegate::webViewAddMessageToConsole):
2827
2828 2007-11-25  Adam Roben  <aroben@apple.com>
2829
2830         Set the font smoothing preference in DRT
2831
2832         This makes the pixel results on Windows closer to the Mac results.
2833
2834         Reviewed by Mitz.
2835
2836         * DumpRenderTree/win/DumpRenderTree.cpp:
2837         (initializePreferences):
2838
2839 2007-11-25  Adam Roben  <aroben@apple.com>
2840
2841         Port ImageDiff to CG and C++
2842
2843         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
2844         <rdar://5071708>
2845
2846         Reviewed by Sam.
2847
2848         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
2849         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
2850         (main):
2851         (createImageFromStdin):
2852         (compareImages):
2853         (getDifferenceBitmap):
2854         (computePercentageDifferent):
2855         * DumpRenderTree/win/ImageDiff.vcproj: Added.
2856
2857 2007-11-25  Adam Roben  <aroben@apple.com>
2858
2859         Fix image diff link generation on Windows
2860
2861         Reviewed by Sam.
2862
2863         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
2864         to toURL.
2865
2866 2007-11-25  Adam Roben  <aroben@apple.com>
2867
2868         Implement pixel dumping in Windows DRT
2869
2870         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
2871         <rdar://5071708>
2872
2873         Reviewed by Sam.
2874
2875         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
2876         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
2877         Content-Length header.
2878         (getMD5HashStringForBitmap):
2879         (dumpWebViewAsPixelsAndCompareWithExpected):
2880         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
2881         * DumpRenderTree/win/DumpRenderTree.cpp:
2882         (dump): Do a pixel dump if requested.
2883         (main): Parse pixel test options.
2884         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
2885         the cg/ subdirectory to the include path.
2886         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
2887         available in a header or import library, so we have to go through this
2888         LoadLibrary/GetProcAddress dance to use them.
2889         (cryptDLL):
2890         (init):
2891         (update):
2892         (final):
2893         (MD5_Init):
2894         (MD5_Update):
2895         (MD5_Final):
2896         * DumpRenderTree/win/MD5.h: Added.
2897         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
2898         moved up to the top level to share it with Mac eventually.
2899         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
2900         (getBitmapContextFromWebView): Forces the WebView to paint using a
2901         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
2902
2903 2007-11-25  Adam Roben  <aroben@apple.com>
2904
2905         Clean up Windows DRT's option parsing a little bit
2906
2907         Reviewed by Sam.
2908
2909         * DumpRenderTree/win/DumpRenderTree.cpp:
2910         (main): Put non-option arguments into a Vector.
2911
2912 2007-11-25  Adam Roben  <aroben@apple.com>
2913
2914         Make Windows DRT stop changing LF into CRLF
2915
2916         Reviewed by Sam.
2917
2918         * DumpRenderTree/win/DumpRenderTree.cpp:
2919         (main): Put stdout in binary mode.
2920         * Scripts/run-webkit-tests: Remove the CRLF hack.
2921
2922 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
2923
2924         Removed empty directory.
2925
2926         * Scripts/resources: Removed.
2927
2928 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
2929
2930         Fix bisect-builds to work with recent WebKit nightly builds.
2931
2932         Reviewed by Dan.
2933
2934         * Scripts/bisect-builds: Check for the
2935         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
2936         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
2937         to WebKit.app/Contents/Resources.
2938
2939 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
2940
2941         Reviewed by Maciej.
2942
2943         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
2944         not closed (affects digg.com)
2945
2946         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
2947         one after finishing with a test to avoid having its delayed onload handler firing when
2948         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
2949         but it helps somewhat.
2950
2951 2007-11-22  Mark Rowe  <mrowe@apple.com>
2952
2953         Reviewed by Alp Toker.
2954
2955         Fix build-webkit to propagate make's exit status if it fails.
2956
2957         * Scripts/webkitdirs.pm:
2958
2959 2007-11-22  Dan Bernstein  <mitz@apple.com>
2960
2961         Reviewed by Mark Rowe.
2962
2963         - fix crash when running pixel tests
2964
2965         * DumpRenderTree/mac/DumpRenderTree.mm:
2966         (dumpRenderTree): Parse the command line options before setting up the
2967         environment so that we know if we need to set up the pixel dump
2968         machinery.
2969
2970 2007-11-21  Eric Seidel  <eric@webkit.org>
2971
2972         Speculative build fix for Tiger.
2973
2974         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
2975
2976 2007-11-21  Eric Seidel  <eric@webkit.org>
2977
2978         Reviewed by Tim Hatcher.
2979
2980         Break out more of DumpRenderTree.mm into individual files
2981
2982         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2983         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
2984         (checkedMalloc):
2985         (checkedRealloc):
2986         (makeLargeMallocFailSilently):
2987         * DumpRenderTree/mac/CheckedMalloc.h: Added.
2988         * DumpRenderTree/mac/DumpRenderTree.mm:
2989         (crashHandler):
2990         (dump):
2991         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2992         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2993         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2994         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2995         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2996         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
2997         (javaScriptThreads):
2998         (runJavaScriptThread):
2999         (startJavaScriptThreads):
3000         (stopJavaScriptThreads):
3001         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
3002         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
3003         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
3004         (restoreColorSpace):
3005         (setDefaultColorProfileToRGB):
3006         (initializeColorSpaceAndScreeBufferForPixelTests):
3007         (md5HashStringForBitmap):
3008         (dumpWebViewAsPixelsAndCompareWithExpected):
3009
3010 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
3011
3012         Move install-unix-extras to wx directory as it seems only to be used by that
3013         port now. It now supports universal binaries on Mac and adds libpng and libjpeg.
3014         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
3015         have install-unix-extras install into WebKitLibraries as per
3016         convention.
3017
3018         Reviewed by Mark Rowe.
3019
3020         * Scripts/install-unix-extras: Removed.
3021         * wx/build-wxwebkit:
3022         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
3023
3024 2007-11-21  Eric Seidel  <eric@webkit.org>
3025
3026         Reviewed by Adam.
3027
3028         More refactoring for greater code readability
3029
3030         * DumpRenderTree/mac/DumpRenderTree.mm:
3031         (initializeGlobalsFromCommandLineOptions):
3032         (initializeColorSpaceAndScreeBufferForPixelTests):
3033         (addTestPluginsToPluginSearchPath):
3034         (useLongRunningServerMode):
3035         (runTestingServerLoop):
3036         (prepareConsistentTestingEnvironment):
3037         (dumpRenderTree):
3038         (main):
3039         (dumpFramesAsText):
3040         (dumpBackForwardListForWebView):
3041         (sizeWebViewForCurrentTest):
3042         (methodNameStringForFailedTest):
3043         (dumpBackForwardListForAllWindows):
3044         (dumpWebViewAsPixelsAndCompareWithExpected):
3045         (invalidateAnyPreviousWaitToDumpWatchdog):
3046         (dump):
3047         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3048         * DumpRenderTree/mac/UIDelegate.mm:
3049         (-[UIDelegate webView:createWebViewWithRequest:]):
3050
3051 2007-11-21  Eric Seidel  <eric@webkit.org>
3052
3053         Reviewed by Tim Hatcher.
3054
3055         Abstract more of DRT into static methods
3056
3057         * DumpRenderTree/mac/DumpRenderTree.mm:
3058         (setDefaultsToConsistentValuesForTesting):
3059         (setupSignalHandlers):
3060         (allocateGlobalControllers):
3061         (releaseAndZero):
3062         (releaseGlobalControllers):
3063         (dumpRenderTree):
3064         (shouldLogFrameLoadDelegates):
3065         (createCFURLFromPathOrURL):
3066         (resetWebViewToConsistentStateBeforeTesting):
3067         (runTest):
3068
3069 2007-11-21  Eric Seidel  <eric@webkit.org>
3070
3071         Reviewed by Tim Hatcher.
3072
3073         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
3074
3075         * DumpRenderTree/DumpRenderTree.h:
3076         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3077         * DumpRenderTree/mac/DumpRenderTree.mm:
3078         (dumpRenderTree):
3079         (dump):
3080         (runTest):
3081         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
3082         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
3083         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
3084         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
3085         (-[DumpRenderTreePasteboard declareType:owner:]):
3086         (+[LocalPasteboard alloc]):
3087         (-[LocalPasteboard init]):
3088         (-[LocalPasteboard dealloc]):
3089         (-[LocalPasteboard name]):
3090         (-[LocalPasteboard releaseGlobally]):
3091         (-[LocalPasteboard declareTypes:owner:]):
3092         (-[LocalPasteboard addTypes:owner:]):
3093         (-[LocalPasteboard changeCount]):
3094         (-[LocalPasteboard types]):
3095         (-[LocalPasteboard availableTypeFromArray:]):
3096         (-[LocalPasteboard setData:forType:]):
3097         (-[LocalPasteboard dataForType:]):
3098         (-[LocalPasteboard setPropertyList:forType:]):
3099         (-[LocalPasteboard setString:forType:]):
3100         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
3101         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
3102         (+[DumpRenderTreeWindow allWindows]):
3103         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
3104         (-[DumpRenderTreeWindow dealloc]):
3105         (-[DumpRenderTreeWindow isKeyWindow]):
3106         (-[DumpRenderTreeWindow keyDown:]):
3107
3108 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
3109
3110         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
3111         it indiscriminately copies any headers inside JavaScriptCore,
3112         which includes Tiger ICU headers.
3113
3114         * wx/build-wxwebkit:
3115         Don't run WebCore/move-js-headers.sh any longer.
3116
3117 2007-11-20  Adam Treat  <treat@kde.org>
3118
3119         Reviewed by David Kilzer.
3120
3121         * Prepend git branch name to $baseProductDir
3122
3123         * Scripts/VCSUtils.pm:
3124         * Scripts/webkitdirs.pm:
3125
3126 2007-11-20  Mark Rowe  <mrowe@apple.com>
3127
3128         Reviewed by Simon Hausmann.
3129
3130         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
3131         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
3132         Have it trigger a "make distclean" rather than "make clean" to ensure that the
3133         built product and generated Makefile's are removed.
3134
3135 2007-11-19  Alp Toker  <alp@atoker.com>
3136
3137         Reviewed by Mark Rowe.
3138
3139         http://bugs.webkit.org/show_bug.cgi?id=16040
3140         [GTK] GtkLauncher should be written in C
3141
3142         Port GtkLauncher to plain C.
3143
3144         Use a more conventional GTK+ coding style.
3145
3146         Use a toolbar instead of menus.
3147
3148         Various signature fixes and cleanups.
3149
3150         Add a license header. Assume all previous modifications were copyright
3151         assigned to Apple Inc. by default.
3152
3153         * GtkLauncher/GtkLauncher.pro:
3154         * GtkLauncher/main.c: Added.
3155         (activate_url_entry_cb):
3156         (update_title):
3157         (link_hover_cb):
3158         (title_change_cb):
3159         (progress_change_cb):
3160         (destroy_cb):
3161         (go_back_cb):
3162         (go_forward_cb):
3163         (create_browser):
3164         (create_statusbar):
3165         (create_toolbar):
3166         (create_window):
3167         (main):
3168         * GtkLauncher/main.cpp: Removed.
3169
3170 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
3171
3172         Build script fixes to ensure they do the right thing for the
3173         wx port, and update build-wxwebkit to reflect the way the
3174         build scripts now work.
3175
3176         Reviewed by Adam.
3177
3178         * Scripts/build-testkjs:
3179         * Scripts/build-webkit:
3180         * Scripts/run-javascriptcore-tests:
3181         * Scripts/webkitdirs.pm:
3182         * wx/build-wxwebkit:
3183
3184 2007-11-18  Eric Seidel  <eric@webkit.org>
3185
3186         Reviewed by Anders.
3187
3188         Make run-javascriptcore-tests report failures on exit (to support git bisect)
3189
3190         * Scripts/run-javascriptcore-tests:
3191
3192 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
3193
3194         Reviewed by Adam Roben.
3195
3196         Make run-webkit-tests work with Windows debug build.
3197
3198         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
3199         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
3200         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
3201         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
3202         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
3203
3204 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
3205
3206         Add wxWebKit sample and build script, and integrate it with
3207         build-webkit. Also make build-webkit --clean work for all
3208         ports.
3209
3210         Reviewed by Darin Adler.
3211
3212         * Scripts/build-webkit:
3213         * Scripts/webkitdirs.pm:
3214         * wx: Added.
3215         * wx/browser: Added.
3216         * wx/browser/browser.bkl: Added.
3217         * wx/browser/browser.cpp: Added.
3218         * wx/build-wxwebkit: Added.
3219
3220 2007-11-17  Adam Roben  <aroben@apple.com>
3221
3222         Make it easy to run Safari in the debugger on Windows
3223
3224         I've added a new script, debug-safari, which launches Safari in the
3225         debugger. On OS X it just calls gdb-safari.
3226
3227         Reviewed by Mark Rowe.
3228
3229         * FindSafari/FindSafari.cpp:
3230         (_tmain): Added a /debugger flag, which in combination with
3231         /printSafariLauncher will print a script that launches Safari in the
3232         debugger.
3233         * Scripts/debug-safari: Added.
3234         * Scripts/run-safari: Changed to call runSafari().
3235         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
3236         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
3237         first argument along to FindSafari.
3238         * Scripts/webkitdirs.pm:
3239         (sub runSafari): Added.
3240
3241 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
3242
3243         Reviewed by Adam Roben.
3244
3245         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined.
3246
3247 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
3248
3249         Reviewed by David Kilzer.
3250
3251         The git config command was renamed to repo-config at some point. This
3252         change tries git config and then git repo-config if the first fails.
3253
3254         * Scripts/prepare-ChangeLog:
3255         (gitConfig):
3256
3257 2007-11-16  Dan Bernstein  <mitz@apple.com>
3258
3259         Reviewed by Darin Adler and Sam Weinig.
3260
3261         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
3262
3263         * DumpRenderTree/win/EventSender.cpp:
3264         (keyDownCallback): For characters that cannot be entered on the active
3265         keyboard layout, send a WM_CHAR message with the character along with
3266         a WM_KEYDOWN message with a virtual key code of 255.
3267
3268 2007-11-16  Mark Rowe  <mrowe@apple.com>
3269
3270         Reviewed by Tim Hatcher.
3271
3272         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
3273
3274         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3275         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3276
3277 2007-11-15  Adam Roben  <aroben@apple.com>
3278
3279         Make run-safari actually work on Windows
3280
3281         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
3282         chdir call.
3283
3284 2007-11-14  Adam Roben  <aroben@apple.com>
3285
3286         Updates to Safari launching now that 3.0.4 is released
3287
3288         Reviewed by Sam.
3289
3290         * FindSafari/FindSafari.cpp:
3291         (getWebViewCLSID): Use version-independent ProgID.
3292         * Scripts/run-safari: Use run-webkit-nightly.cmd.
3293
3294 2007-11-14  Anders Carlsson  <andersca@apple.com>
3295
3296         Reviewed by Adam.
3297
3298         <rdar://problem/5309081>
3299         In DRT, "plugin.logDestroy = true" not working on Windows.
3300
3301         * DumpRenderTree/win/TestNetscapePlugin/main.c:
3302         (NPP_Destroy):
3303
3304 2007-11-14  Eric Seidel  <eric@webkit.org>
3305
3306         Reviewed by Sam.
3307
3308         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
3309
3310 2007-11-14  Anders Carlsson  <andersca@apple.com>
3311
3312         Reviewed by Adam.
3313
3314         <rdar://problem/5141186>
3315         window.layoutTestController.setWindowIsKey is not implemented in DRT.
3316
3317         Implement setWindowIsKey.
3318
3319         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3320         (LayoutTestController::setWindowIsKey):
3321
3322 2007-11-13  Sam Weinig  <sam@webkit.org>
3323
3324         Reviewed by Adam Roben.
3325
3326         Fix for <rdar://problem/5382579>
3327         http/tests/security/cross-frame-access-put.html reports large
3328         negative numbers for screenLeft and screenTop (Mac reports "0")
3329
3330         * DumpRenderTree/win/UIDelegate.cpp:
3331         (UIDelegate::UIDelegate): Initialize the RECT.
3332         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
3333         (UIDelegate::webViewFrame): ditto.
3334         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
3335
3336 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
3337
3338         Reviewed by Adam.
3339
3340         - Make Drosera show source, source URLs, and function stack on Windows,
3341         and some minor fixes.
3342
3343         * Drosera/DebuggerDocument.cpp: Force source to always update display.
3344         (DebuggerDocument::updateFileSource):
3345         * Drosera/debugger.js: Force source to always update display.
3346         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
3347         menu controls.
3348         (DebuggerClient::resume):
3349         (DebuggerClient::pause):
3350         (DebuggerClient::stepInto):
3351         (DebuggerClient::stepOver):
3352         (DebuggerClient::stepOut):
3353         (DebuggerClient::showConsole):
3354         (DebuggerClient::closeCurrentFile):
3355         * Drosera/win/DebuggerClient.h: Ditto.
3356         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
3357         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
3358         removed two bugs.  1) caller could be in a bad state when asked to
3359         assign into it. 2) BSTRs were not created correctly.
3360         (DebuggerDocument::getPlatformCurrentFunctionStack):
3361         * Drosera/win/Drosera.cpp: Hook up the menu controls.
3362         (droseraWndProc):
3363         (handleCommand):
3364         (Drosera::resume):
3365         (Drosera::pause):
3366         (Drosera::stepInto):
3367         (Drosera::stepOver):
3368         (Drosera::stepOut):
3369         (Drosera::showConsole):
3370         (Drosera::closeCurrentFile):
3371         * Drosera/win/Drosera.h: Hook up the menu controls.
3372         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
3373         functions, added a null check, and fixed another bug where caller could
3374         be in a bad state when asked to assign into it.
3375         (ServerConnection::didLoadMainResourceForDataSource):
3376         (ServerConnection::getCallerFrame):
3377         * Drosera/win/ServerConnection.h: Safety first.
3378
3379 2007-11-13  Dan Bernstein  <mitz@apple.com>
3380
3381         Reviewed by Darin Adler.
3382
3383         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
3384           DumpRenderTree --pixel-tests renders each test twice
3385
3386         * DumpRenderTree/mac/DumpRenderTree.mm:
3387         (dumpRenderTree): Removed the --paint option because the painting code
3388         is always exercised as a result of
3389         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
3390         calling -displayIfNeeded.
3391         (dump): Changed to always grab the image from the window since the view
3392         is always displayed.
3393         (runTest):
3394         (displayWebView):
3395         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
3396         because it always paints.
3397
3398 2007-11-12  Antti Koivisto  <antti@apple.com>
3399
3400         Reviewed by Adele.
3401
3402         Add support for http media tests
3403
3404         * Scripts/run-webkit-tests:
3405
3406 2007-11-12  Sam Weinig  <sam@webkit.org>
3407
3408         Reviewed by Adam Roben.
3409
3410         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
3411
3412         * DumpRenderTree/win/DumpRenderTree.cpp:
3413         (runTest):
3414         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3415         (LayoutTestController::setPrivateBrowsingEnabled):
3416
3417 2007-11-12  Adam Roben  <aroben@apple.com>
3418
3419         * Scripts/update-webkit-localizable-strings: Changed to only scan the
3420         mac and win subdirectories.
3421
3422 2007-11-11  Adam Roben  <aroben@apple.com>
3423
3424         Fix <rdar://5133816> keepWebHistory is not implemented
3425
3426         Fixes fast/history/clicked-link-is-visited.html.
3427
3428         Reviewed by Darin.
3429
3430         * DumpRenderTree/win/DumpRenderTree.cpp:
3431         (runTest): Clear the optionalSharedHistory.
3432         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3433         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
3434
3435 2007-11-10  Sam Weinig  <sam@webkit.org>
3436
3437         Reviewed by Tim Hatcher.
3438
3439         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript
3440         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions
3441         is turned on)
3442
3443         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
3444
3445         Added test: http/tests/security/cross-frame-access-private-browsing.html
3446
3447         * DumpRenderTree/LayoutTestController.cpp:
3448         (setPrivateBrowsingEnabledCallback):
3449         (LayoutTestController::staticFunctions):
3450         * DumpRenderTree/LayoutTestController.h:
3451         * DumpRenderTree/mac/DumpRenderTree.mm:
3452         (runTest): Default to private browsing disabled.
3453         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3454         (LayoutTestController::setPrivateBrowsingEnabled):
3455         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3456         (LayoutTestController::setPrivateBrowsingEnabled):
3457
3458 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
3459
3460         Reviewed by Adam.
3461
3462         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
3463         WebCore's!
3464
3465         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
3466         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
3467         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
3468         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
3469         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
3470         * Drosera/win/Drosera.cpp:
3471         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3472
3473 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
3474
3475         Reviewed by Sam.
3476
3477         - Use the new IWebFrame [local] function signature and get the shared
3478         server correctly.
3479
3480         * Drosera/win/DebuggerClient.cpp:
3481         (DebuggerClient::didFinishLoadForFrame):
3482         * Drosera/win/ServerConnection.cpp:
3483         (ServerConnection::attemptToCreateServerConnection):
3484
3485 2007-11-07  Dan Bernstein  <mitz@apple.com>
3486
3487         Reviewed by Darin Adler.
3488
3489         - add an option to run-webkit-tests to ignore pixel test failures where
3490           all pixels differ by no more than a specified threshold
3491
3492         * DumpRenderTree/mac/ImageDiff.m:
3493         (main):
3494         (compareImages):
3495         (computePercentageDifferent):
3496         * Scripts/run-webkit-tests:
3497
3498 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3499
3500         Reviewed by Lars.
3501
3502         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
3503
3504         * DumpRenderTree/qt/DumpRenderTree.cpp:
3505
3506 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3507
3508         Reviewed by Lars.
3509
3510         Reworked the QWebSettings API.
3511         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
3512
3513         * DumpRenderTree/qt/DumpRenderTree.cpp:
3514
3515 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3516
3517         Reviewed by Lars.
3518
3519         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
3520
3521         * DumpRenderTree/qt/jsobjects.cpp:
3522
3523 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3524
3525         Reviewed by Lars Knoll <lars@trolltech.com>.
3526
3527         Add a QWebPage::frameCreated() signal and fix DRT
3528
3529         The removal of createFrame in QWebPage broke the re-implementation
3530         in DumpRenderTree. Instead emit a frameCreated() signal and
3531         connect to it in DumpRenderTree.
3532
3533
3534         * DumpRenderTree/qt/DumpRenderTree.cpp:
3535         (WebCore::WebPage::WebPage):
3536         (WebCore::DumpRenderTree::dump):
3537         (WebCore::DumpRenderTree::connectFrame):
3538         * DumpRenderTree/qt/DumpRenderTree.h:
3539
3540 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3541
3542         Reviewed by Lars Knoll <lars@trolltech.com>.
3543
3544         Moved all the event handlers from QWebFrame into QWebPage.
3545
3546         This cleans up the public API and allows us to remove the
3547         HackWebFrame hack in DumpRenderTree.
3548
3549
3550         * DumpRenderTree/qt/jsobjects.cpp:
3551         (EventSender::mouseDown):
3552         (EventSender::mouseUp):
3553         (EventSender::mouseMoveTo):
3554
3555 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3556
3557         Reviewed by Mark.
3558
3559         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
3560         to prevent the default implementation from popping up messageboxes.
3561
3562         * DumpRenderTree/qt/DumpRenderTree.cpp:
3563         (WebCore::WebPage::javaScriptConfirm):
3564         (WebCore::WebPage::javaScriptPrompt):
3565
3566 2007-11-06  Eric Seidel  <eric@webkit.org>
3567
3568         * Scripts/build-testkjs: build fix... too many $$
3569
3570 2007-11-06  Eric Seidel  <eric@webkit.org>
3571
3572         Reviewed by Mark Rowe.
3573
3574         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
3575
3576 2007-11-05  Adam Roben  <aroben@apple.com>
3577
3578         Add support on Windows for WEBKIT_TESTFONTS
3579
3580         This environment variable lets you specify where the fonts to be used
3581         by DumpRenderTree reside. The Qt port is already using this, so I'm
3582         just following their lead.
3583
3584         Reviewed by Darin.
3585
3586         * DumpRenderTree/win/DumpRenderTree.cpp:
3587         (exePath): Refactored code out of initialize().
3588         (fontsPath): Returns either $WEBKIT_TESTFONTS or
3589         DumpRenderTree.resources.
3590         (initialize): Use the new fontsPath function.
3591         (main): Use the new exePath function.
3592         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
3593         variable to DRT, like Qt does.
3594
3595 2007-11-05  Mark Rowe  <mrowe@apple.com>
3596
3597         Rubber-stamped by Alp Toker.
3598
3599         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
3600
3601         * GtkLauncher/main.cpp:
3602         (goToURLBarText):
3603         (main):
3604
3605 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
3606
3607         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
3608         <http://bugs.webkit.org/show_bug.cgi?id=15830>
3609
3610         Reviewed by Timothy.
3611
3612         Restrict the range of nightly builds used by the bisect-builds script
3613         based on the version of Safari and the version of Mac OS X being used.
3614
3615         Mac OS X 10.4: Safari 2.0: r11976 or newer
3616         Mac OS X 10.4: Safari 3.0: r19992 or newer
3617
3618         Mac OS X 10.5: Safari 2.0: r19594 or newer
3619         Mac OS X 10.5: Safari 3.0: r25124 or newer
3620
3621         * Scripts/bisect-builds:
3622         (findMacOSXVersion): Added.
3623         (makeNightlyList): Added argument to provide version of Mac OS X.
3624         Restrict range of nightly builds based on Safari and Mac OS X versions.
3625
3626 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
3627
3628         Reviewed by Maciej.
3629
3630         - This patch involves several changes, all of them were noticed that
3631         they were needed by the work being done in WebKit to get Drosera and
3632         WebKit working together on Windows.
3633         - The changes are:
3634         1) Added a debugger console for output messages.
3635         2) Drosera now listens for the WebKit server (before, the server would
3636         have to be running before Drosera was started.)
3637         3) Fixed a bug where the WebView started out as 0x0 pixels.
3638         4) Fixed a bug when there is no scope.
3639         5) Added the HTML, JS, and CSS to the project file to make them easy to
3640         find.
3641         6) Made the ServerConnection functions virtual.
3642
3643         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
3644         for the WebKit server.
3645         (DebuggerClient::DebuggerClient):
3646         (DebuggerClient::~DebuggerClient):
3647         (DebuggerClient::didFinishLoadForFrame):
3648         (DebuggerClient::serverConnected):
3649         (DebuggerClient::attemptToCreateServerConnection):
3650         * Drosera/win/DebuggerClient.h: Ditto.
3651         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
3652         scope.
3653         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3654         (DebuggerDocument::platformValueForScopeVariableNamed):
3655         * Drosera/win/Drosera.cpp:
3656         (_tWinMain): Added a console in debug for output messages.
3657         (Drosera::Drosera): Listen for server.
3658         (Drosera::initUI): The server now Initializes COM.
3659         (Drosera::serverConnected): Part of the listening for the server.
3660         (Drosera::attemptToCreateServerConnection): Ditto.
3661         * Drosera/win/Drosera.h: New interface for listening for the server.
3662         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
3663         files to the VS project.
3664         * Drosera/win/ServerConnection.cpp: Part of listening for the server
3665         connection.
3666         (ServerConnection::ServerConnection):
3667         (ServerConnection::attemptToCreateServerConnection):
3668         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
3669         methods.
3670         (ServerConnection::serverConnected):
3671
3672 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
3673
3674         Reviewed by Maciej.
3675
3676         http://bugs.webkit.org/show_bug.cgi?id=15832
3677         fast/dom/gc-10.html crashes when run alone
3678
3679         Check for !done before using objects that can be already deallocated.
3680
3681         * DumpRenderTree/mac/EditingDelegate.mm:
3682         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3683         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3684         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3685         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3686         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3687         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3688         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3689         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3690         (-[EditingDelegate webViewDidBeginEditing:]):
3691         (-[EditingDelegate webViewDidChange:]):
3692         (-[EditingDelegate webViewDidEndEditing:]):
3693         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3694         (-[EditingDelegate webViewDidChangeSelection:]):
3695         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3696         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3697         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3698         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3699         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3700         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3701         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3702         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3703         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3704         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
3705         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3706         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
3707         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3708         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3709         (-[FrameLoadDelegate webView:willCloseFrame:]):
3710         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3711         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3712         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3713         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3714         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3715         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3716         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3717         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3718         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3719
3720 2007-11-04  Mark Rowe  <mrowe@apple.com>
3721
3722         Build fix.  Don't use Carbon.h as the prefix header as it triggers
3723         warnings that would otherwise be suppressed due to it being a system header.
3724
3725         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3726
3727 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
3728
3729         Rubber stamped by Adam.
3730
3731         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
3732
3733         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3734
3735 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3736
3737         Sort files(...); sections of Xcode project files.
3738
3739         Rubber-stamped by Darin.
3740
3741         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
3742         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3743         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3744         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3745
3746 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3747
3748         Script to sort "files(...);" sections in Xcode project.pbxproj files.
3749
3750         Reviewed by Darin.
3751
3752         * Scripts/sort-Xcode-project-file: Added.
3753
3754 2007-11-02  Darin Adler  <darin@apple.com>
3755
3756         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
3757
3758 2007-11-02  Darin Adler  <darin@apple.com>
3759
3760         Reviewed by Maciej.
3761
3762         * Scripts/run-sunspider: Pass the "--base" option through.
3763
3764         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
3765         the real script do that. Default configuration to Release to match run-sunspider
3766         so we don't end up building Debug just to compare results.
3767
3768 2007-11-01  Adam Roben  <aroben@apple.com>
3769
3770         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
3771
3772         Reviewed by Sam.
3773
3774         * Scripts/commit-log-editor: Show all the directories beneath the
3775         source root, instead of just the last one.
3776
3777 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
3778
3779         Reviewed by Adam Roben.
3780
3781         Print out an error message when the Windows build fails
3782         and provide guidance on how to find out what went wrong.
3783
3784         * Scripts/build-webkit:
3785         * Scripts/webkitdirs.pm:
3786
3787 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
3788
3789         Rubber-stamped by Adam Roben.
3790
3791         Rolled out r27326 - debug CRT seems to cause no problems after all.
3792
3793         * DumpRenderTree/win/DumpRenderTree.vcproj:
3794
3795 2007-10-31  Adam Roben  <aroben@apple.com>
3796
3797         Switch the Debug configuration to using the non-debug CRT
3798
3799         This matches WebKit.
3800
3801         Reviewed by Steve.
3802
3803         * DumpRenderTree/win/DumpRenderTree.vcproj:
3804
3805 2007-10-31  Antti Koivisto  <antti@apple.com>
3806
3807         Reviewed by bdash.
3808
3809         Disable media tests when doing leak checking on Tiger.
3810         They crash in QuickTime (rdar://problem/5537157).
3811
3812         * Scripts/run-webkit-tests:
3813
3814 2007-10-29  Antti Koivisto  <antti@apple.com>
3815
3816         Reviewed by Maciej.
3817
3818         Build media support by default on OSX only.
3819
3820         * Scripts/build-webkit:
3821
3822 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3823
3824         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
3825         get caught by the pre-commit hooks.
3826
3827 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3828
3829         Reviewed by Adam.
3830
3831         - This is a collection of relatively unrelated changes and cleanups
3832         to Drosera to prepare it for interacting with WebKit.  A lot of these
3833         changes are just correcting mistakes, for example removing included
3834         headers that are no longer needed.
3835
3836         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
3837         this will be needed by the DebuggerClient.
3838         (DebuggerDocument::server):
3839         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
3840         * Drosera/win/DebuggerClient.cpp:
3841         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
3842         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
3843         (DebuggerClient::createWebViewWithRequest): Added comment about its
3844         purpose.
3845         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
3846         declarations.
3847         (DebuggerClient::webViewLoaded): Moved.
3848         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
3849         file, since this was the only place it was used.
3850         (cfStringToBSTR):
3851         * Drosera/win/Drosera.h: Cleaned up the includes.
3852         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
3853         * Drosera/win/HelperFunctions.h: Removed.
3854
3855 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3856
3857         Reviewed by Adam.
3858
3859         - Small cleanup in the ServerConnection class.
3860
3861         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
3862         and added an include.
3863         (ServerConnection::currentFrame):
3864         (ServerConnection::getCallerFrame):
3865         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
3866         made a pointer into a COMPtr, and cleaned up the includes.
3867
3868 2007-10-29  Timothy Hatcher  <timothy@apple.com>
3869
3870         Reviewed by John Sullivan.
3871
3872         - Place the Localizable.strings file in mac or win directories
3873           if that location exists.
3874         - Also look for UI_STRING in .c files.
3875
3876         * Scripts/extract-localizable-strings:
3877
3878 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3879
3880         Reviewed by Adam.
3881
3882         - Set the eol-style to native and made all the line endings the same
3883         so that I avoid messy diffs that show eol changes.
3884
3885         * Drosera/win/ServerConnection.cpp:
3886         (ServerConnection::didParseSource):
3887         (ServerConnection::didEnterCallFrame):
3888         (ServerConnection::willExecuteStatement):
3889         (ServerConnection::willLeaveCallFrame):
3890         (ServerConnection::exceptionWasRaised):
3891
3892 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
3893
3894         Reviewed by Adam.
3895
3896         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
3897         functionality that could not have existed previously without the new
3898         interfaces.
3899         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
3900         from a BSTR to a JSValueRef.
3901         (DebuggerDocument::platformEvaluateScript): Implemented.
3902         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
3903         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3904         Implemented.
3905         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
3906         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
3907         * Drosera/win/ServerConnection.cpp: Added a helper function.
3908         (ServerConnection::getCallerFrame):
3909         * Drosera/win/ServerConnection.h: Added a helper function.
3910
3911 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3912
3913         updated reviewers for my previous changelog.
3914
3915 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
3916         Reviewed by Maciej and Adam and Geoff.
3917
3918         - Minor mac-side improvements including moving a function to a more
3919         appropriate location, fixing a warning, and correctly checking
3920         exceptions.
3921
3922         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
3923         (DebuggerDocument::willExecuteStatement):
3924         (DebuggerDocument::didEnterCallFrame):
3925         (DebuggerDocument::willLeaveCallFrame):
3926         (DebuggerDocument::windowScriptObjectAvailable):
3927         (DebuggerDocument::callFunctionOnObject):
3928         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
3929         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
3930         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
3931         because it doesn't require the ServerConnection at all.
3932         (NSStringCreateWithJSStringRef): Made an argument const.
3933         (JSValueRefCreateWithNSString): Made an argument const.
3934         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
3935         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3936         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
3937         * Drosera/mac/ServerConnection.mm: Ditto.
3938         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
3939
3940 2007-10-29  Sam Weinig  <sam@webkit.org>
3941
3942         Reviewed by Adam Roben.
3943
3944         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
3945
3946         * DumpRenderTree/LayoutTestController.cpp:
3947         (LayoutTestController::LayoutTestController):
3948         (getGlobalFlagCallback):
3949         (setGlobalFlagCallback):
3950         (LayoutTestController::getJSClass):
3951         (LayoutTestController::staticValues):
3952         * DumpRenderTree/LayoutTestController.h:
3953         (LayoutTestController::globalFlag):
3954         (LayoutTestController::setGlobalFlag):
3955
3956 2007-10-29  Darin Adler  <darin@apple.com>
3957
3958         Reviewed by Maciej.
3959
3960         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
3961         resolution instead of its default.
3962
3963 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
3964
3965         Fixed showStatus() to print status for successfully resolved conflicts when using git.
3966
3967         Reviewed by Mark Rowe.
3968
3969         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
3970         was successfully resolved, but this would not show any status because the change had
3971         already been cached in the index using "git add".  The solution is to add an optional
3972         second argument to showStatus() which adds the "--cached" switch to the command.
3973
3974         * Scripts/resolve-ChangeLogs:
3975         (showStatus):
3976
3977 2007-10-28  Eric Seidel  <eric@webkit.org>
3978
3979         Reviewed by Maciej and Geoff, in unison.
3980
3981         * Scripts/run-webkit-tests: remove broken --svg option
3982
3983 2007-10-28  Darin Adler  <darin@apple.com>
3984
3985         Reviewed by Adam.
3986
3987         * Scripts/run-sunspider: Default to "Release" configuration rather than
3988         defaulting to the last configuration used as other scripts do. This can
3989         still be overriden on the command line with "--debug" if there's some
3990         reason to do so. Also fix a typo.
3991
3992         * Scripts/sunspider-compare-results: Fix a typo.
3993
3994 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
3995
3996         Reviewed by Adam.
3997
3998         - Implemented the WebScriptDebugListener functions now that the
3999         WebScriptDebugServer exists
4000
4001         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
4002         functions.
4003         (ServerConnection::currentFrame):
4004         (ServerConnection::didLoadMainResourceForDataSource):
4005         (ServerConnection::didParseSource):
4006         (ServerConnection::failedToParseSource):
4007         (ServerConnection::didEnterCallFrame):
4008         (ServerConnection::willExecuteStatement):
4009         (ServerConnection::willLeaveCallFrame):
4010         (ServerConnection::exceptionWasRaised):
4011         * Drosera/win/ServerConnection.h: Removed unused arguments from the
4012         members arguments list.
4013
4014 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
4015
4016         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
4017         <http://bugs.webkit.org/show_bug.cgi?id=15600>
4018
4019         Reviewed by Darin.
4020
4021         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
4022         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
4023         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
4024         file.  Note that it may also be used as a stand-alone script.
4025
4026         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
4027         * Scripts/resolve-ChangeLogs: Added.
4028         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
4029
4030 2007-10-26  Mark Rowe  <mrowe@apple.com>
4031
4032         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
4033         to the Qt port on the assumption that it was an implementation of the cross-platform
4034         LayoutTestController class.  It is not, so it did not need to be changed.
4035
4036         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
4037
4038 2007-10-25  Mark Rowe  <mrowe@apple.com>
4039
4040         Reviewed by Maciej.
4041
4042         Fix builds with code coverage enabled.
4043
4044         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
4045
4046 2007-10-25  Darin Adler  <darin@apple.com>
4047
4048         Reviewed by Mark Rowe.
4049
4050         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
4051         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
4052
4053 2007-10-25  Stephanie  <slewis@apple.com>
4054
4055         build Fix
4056
4057         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4058
4059 2007-10-25  Stephanie  <slewis@apple.com>
4060
4061         Reviewed by Mark Rowe, Adam Roben.
4062
4063         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
4064
4065         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4066
4067 2007-10-25  Alice Liu  <alice.liu@apple.com>
4068
4069         Reviewed by Adam.
4070
4071         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
4072
4073         Moving destructor into platform-specific files
4074         * DumpRenderTree/LayoutTestController.cpp:
4075         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4076         (LayoutTestController::~LayoutTestController):
4077         * DumpRenderTree/qt/jsobjects.cpp:
4078         (LayoutTestController::~LayoutTestController):
4079
4080         LayoutTestController wasn't being destroyed
4081         * DumpRenderTree/win/DumpRenderTree.cpp:
4082         (runTest):
4083
4084         Added declspec
4085         * DumpRenderTree/win/EditingDelegate.h:
4086
4087         Reset certain values on the webview (or related delegate) that might
4088         have changed while running a test
4089         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4090         (LayoutTestController::~LayoutTestController):
4091
4092 2007-10-25  Adam Roben  <aroben@apple.com>
4093
4094         Make sunspider-compare-results work with relative paths
4095
4096         Reviewed by Sam.
4097
4098         * Scripts/sunspider-compare-results: Convert arguments to absolute
4099         paths before we chdir.
4100
4101 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
4102
4103         Reviewed by Sam.
4104
4105         - Implemented server calls now the WebScriptDebugServer exists.
4106         - Also removed no longer needed call to initialize CG.
4107
4108         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
4109         automatically now.
4110         (_tWinMain):
4111         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
4112         (ServerConnection::ServerConnection):
4113         (ServerConnection::~ServerConnection):
4114         (ServerConnection::pause):
4115         (ServerConnection::resume):
4116         (ServerConnection::stepInto):
4117         (ServerConnection::applicationTerminating):
4118         (ServerConnection::serverConnectionDidDie):
4119         * Drosera/win/ServerConnection.h: Now uses the COM class.
4120
4121 2007-10-24  George Staikos  <staikos@kde.org>
4122
4123         Unbreak Qt build.
4124
4125         * Scripts/build-webkit:
4126
4127 2007-10-24  Adam Roben  <aroben@apple.com>
4128
4129         Remove now-unnecessary call to InitializeCoreGraphics
4130
4131         WebKit takes care of this now.
4132
4133         Reviewed by Ada.
4134
4135         * DumpRenderTree/win/DumpRenderTree.cpp:
4136         (initialize):
4137
4138 2007-10-24  Adam Roben  <aroben@apple.com>
4139
4140         Use WebTextRenderer in DRT
4141
4142         Reviewed by Ada.
4143
4144         * DumpRenderTree/win/DumpRenderTree.cpp:
4145         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
4146
4147 2007-10-24  Sven Herzberg  <sven@imendio.com>
4148
4149         Reviewed by Mark Rowe.
4150
4151         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
4152         Bug 15614: [GTK] qmake based backends don't build on OS X
4153
4154         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
4155         GTK backend on a Mac
4156         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
4157         isDarwin() to make it reusable in other places (like the workaround-
4158         for-prebuilt-qmake in build-webkit)
4159
4160 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
4161
4162         Refurbish update-webkit script.
4163
4164         Reviewed by Adam.
4165
4166         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
4167         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
4168         multi-argument version of system() for flexibility and security.  Check for existence
4169         of Internal directory using -d test instead of -x.
4170
4171 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
4172
4173         Minor clean-up of prepare-ChangeLog script.
4174
4175         Reviewed by Adam.
4176
4177         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
4178         of a string.  Use multi-argument versions of open() and system() for flexibility and
4179         security.
4180
4181 2007-10-24  Alice Liu  <alice.liu@apple.com>
4182
4183         Reviewed by Oliver.
4184
4185         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
4186
4187         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to
4188         replay the saved events when we're still processing the mousedown that starts the drag
4189         * DumpRenderTree/win/EventSender.cpp:
4190         (doMouseMove):
4191         * DumpRenderTree/win/UIDelegate.cpp:
4192         (UIDelegate::doDragDrop):
4193
4194 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
4195
4196         Reviewed by Sam, Steve and Darin.
4197
4198         - Stubbed out the WebScriptDebugListener functionality in the Server
4199         Connection class to prepare it for receiving those callbacks.
4200         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
4201         and the ServerConnection to not need to be initialized with a server
4202         name, since that is not the way we connect to the WebKit server.
4203
4204         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
4205         no exception.  Now it only loggs when there is an exception
4206         (DebuggerDocument::willExecuteStatement):
4207         (DebuggerDocument::didEnterCallFrame):
4208         (DebuggerDocument::willLeaveCallFrame):
4209         (DebuggerDocument::windowScriptObjectAvailable):
4210         (DebuggerDocument::callFunctionOnObject):
4211         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
4212         to be instantiated with a server's name.
4213         (DebuggerClient::DebuggerClient):
4214         (DebuggerClient::didFinishLoadForFrame):
4215         * Drosera/win/DebuggerClient.h: Removed unsued variable.
4216         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
4217         a server name.
4218         (Drosera::init):
4219         (Drosera::initServer):
4220         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
4221         instantiated with a server's name.
4222         * Drosera/win/ServerConnection.cpp:
4223         (ServerConnection::ServerConnection): No longer needs a server name
4224         (ServerConnection::~ServerConnection): Only release the global context
4225         if there is one.
4226         (ServerConnection::serverConnectionDidDie): Stub for
4227         IWebScriptDebugListener
4228         (ServerConnection::QueryInterface): ditto
4229         (ServerConnection::AddRef): ditto
4230         (ServerConnection::Release): ditto
4231         (ServerConnection::didLoadMainResourceForDataSource): ditto
4232         (ServerConnection::didParseSource): ditto
4233         (ServerConnection::failedToParseSource): ditto
4234         (ServerConnection::didEnterCallFrame): ditto
4235         (ServerConnection::willExecuteStatement): ditto
4236         (ServerConnection::willLeaveCallFrame): ditto
4237         (ServerConnection::exceptionWasRaised): ditto
4238         * Drosera/win/ServerConnection.h: Stubbed out the
4239         IWebScriptDebugListener functions, and this class no longer needs to be
4240         instantiated with a server name.
4241
4242 2007-10-24  Lars Knoll  <lars@trolltech.com>
4243
4244         Reviewed by Simon.
4245
4246         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
4247
4248         * DumpRenderTree/qt/jsobjects.h:
4249
4250 2007-10-24  Lars Knoll  <lars@trolltech.com>
4251
4252         Reviewed by Simon.
4253
4254         add another command.
4255
4256         * DumpRenderTree/qt/jsobjects.cpp:
4257         (TextInputController::doCommand):
4258
4259 2007-10-24  Lars Knoll  <lars@trolltech.com>
4260
4261         Reviewed by Simon.
4262
4263         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
4264
4265         * DumpRenderTree/qt/jsobjects.cpp:
4266         (EventSender::keyDown):
4267         * DumpRenderTree/qt/jsobjects.h:
4268
4269 2007-10-24  Lars Knoll  <lars@trolltech.com>
4270
4271         Reviewed by Simon.
4272
4273         implement eventSender.keyDown().
4274
4275         * DumpRenderTree/qt/jsobjects.cpp:
4276         (EventSender::keyDown):
4277
4278 2007-10-24  Lars Knoll  <lars@trolltech.com>
4279
4280         Reviewed by Simon.
4281
4282         some smaller fixes to the editing support in DRT. Makes another few tests pass.
4283
4284         * DumpRenderTree/qt/DumpRenderTree.cpp:
4285         (WebCore::DumpRenderTree::DumpRenderTree):
4286         (WebCore::DumpRenderTree::initJSObjects):
4287         * DumpRenderTree/qt/jsobjects.cpp:
4288         (TextInputController::doCommand):
4289
4290 2007-10-24  Lars Knoll  <lars@trolltech.com>
4291
4292         Reviewed by Simon.
4293
4294         first bit of implementation for the textinputcontroller.
4295
4296         * DumpRenderTree/qt/DumpRenderTree.cpp:
4297         (WebCore::DumpRenderTree::DumpRenderTree):
4298         * DumpRenderTree/qt/DumpRenderTree.h:
4299         * DumpRenderTree/qt/jsobjects.cpp:
4300         (TextInputController::TextInputController):
4301         (TextInputController::doCommand):
4302         * DumpRenderTree/qt/jsobjects.h:
4303
4304 2007-10-24  Lars Knoll  <lars@trolltech.com>
4305
4306         Reviewed by Simon.
4307
4308         make the man webpage believe it has focus, so the editing tests work correctly.
4309
4310         * DumpRenderTree/qt/DumpRenderTree.cpp:
4311         (WebCore::DumpRenderTree::DumpRenderTree):
4312
4313 2007-10-24  Lars Knoll  <lars@trolltech.com>
4314
4315         Reviewed by Simon.
4316
4317         implement layoutTestController.dumpEditingCallbacks() correctly.
4318
4319         * DumpRenderTree/qt/DumpRenderTree.cpp:
4320         (WebCore::DumpRenderTree::DumpRenderTree):
4321         * DumpRenderTree/qt/jsobjects.cpp:
4322         (LayoutTestController::reset):
4323         (LayoutTestController::dumpEditingCallbacks):
4324