Unreviewed, build fix.
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-02-26  Dumitru Daniliuc  <dumi@chromium.org>
2
3         Unreviewed, build fix.
4
5         * pywebsocket/mod_pywebsocket/standalone.py:
6
7 2010-02-26  Dumitru Daniliuc  <dumi@chromium.org>
8
9         Reviewed by Dimitri Glazkov.
10
11         Moving the script to the right location.
12
13         * pywebsocket/mod_pywebsocket: Added.
14         * pywebsocket/mod_pywebsocket/standalone.py: Copied from WebKitTools/pywebsocket/standalone.py.
15         * pywebsocket/standalone.py: Removed.
16
17 2010-02-26  Dumitru Daniliuc  <dumi@chromium.org>
18
19         Unreviewed, fixing the license.
20
21         * pywebsocket/standalone.py:
22
23 2010-02-26  Dumitru Daniliuc  <dumi@chromium.org>
24
25         Reviewed by Adam Barth.
26
27         Adding pywebsocket/standalone.py back to fix the Chromium webkit
28         canaries. Once all layout tests pass, we can get in the patch that
29         moves this directorty to WebKitTools/Scripts, update all Chromium
30         scripts, and revert this patch.
31
32         https://bugs.webkit.org/show_bug.cgi?id=35464
33
34         * pywebsocket: Added.
35         * pywebsocket/standalone.py: Added.
36
37 2010-02-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
38
39         Reviewed by Xan Lopez.
40
41         [GTK] Needs proper reporting of frame loader callbacks, in DRT
42         https://bugs.webkit.org/show_bug.cgi?id=32170
43
44         Fix reporting of unload handlers, so that it is emitted where
45         needed, not after it.
46
47         * DumpRenderTree/gtk/DumpRenderTree.cpp:
48         (webViewLoadFinished):
49         (webViewDocumentLoadFinished):
50         (createWebView):
51
52 2010-02-26  Antonio Gomes  <tonikitoo@webkit.org>
53
54         Reviewed by Gustavo Noronha.
55         Patch by Antonio Gomes <tonikitoo@webkit.org>
56
57         [Gtk] Make DRT EventSender::keyDown to consider 'hardware_keycode' field when synthesizing an event.
58         https://bugs.webkit.org/show_bug.cgi?id=35432
59
60         When a directional key-press event (arrow keys, End, Home, PageUp,
61         PageDown, etc) is synthesized by DRT's EventSender and it targets
62         an editor (e.g. <input type=text>, <textare>, etc), event is processed
63         by WebCore::EventHandler. On the other hand, if event target is not
64         an editor, event is bubbled up to Gtk+ for processing. In such cases,
65         if 'hardware_keycode' is not provided at event synthesize time
66         its processing fails (at some point in gtk_bindings_activate_event),
67         and no scroll action is performed.
68
69         Unskip fast/events/node-event-anchor-lock.html
70
71         * DumpRenderTree/win/EventSender.cpp:
72         (keyDownCallback):
73         * platform/gtk/Skipped:
74
75 2010-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
76
77         Reviewed by David Levin.
78
79         new-webkit-run-tests: Extraneous parenthesis in websocket_server.py
80         https://bugs.webkit.org/show_bug.cgi?id=35436
81
82          * Scripts/webkitpy/layout_tests/port/websocket_server.py: Removed extra paren.
83
84 2010-02-26  Chris Jerdonek  <cjerdonek@webkit.org>
85
86         Reviewed by David Levin.
87
88         Moved pywebsocket into the webkitpy/thirdparty directory and added
89         an associated README.webkit file to the pywebsocket directory.
90         This makes pywebsocket more consistent with the other third-party
91         Python code in our repository.
92
93         https://bugs.webkit.org/show_bug.cgi?id=35198
94
95         * Scripts/run-webkit-tests:
96           - Updated paths to pywebsocket.
97
98         * Scripts/run-webkit-websocketserver:
99           - Updated paths to pywebsocket.
100
101         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
102           - Updated paths to pywebsocket.
103
104         * Scripts/webkitpy/thirdparty/pywebsocket: Copied from WebKitTools/pywebsocket.
105         * Scripts/webkitpy/thirdparty/pywebsocket/README.webkit: Added.
106           - Added a file containing information about the contents
107             of the pywebsocket directory. This will make it easier to
108             understand where the third-party code came from and what
109             local changes have been made.
110
111         * pywebsocket: Removed.
112         * pywebsocket/COPYING: Removed.
113         * pywebsocket/MANIFEST.in: Removed.
114         * pywebsocket/README: Removed.
115         * pywebsocket/example: Removed.
116         * pywebsocket/example/echo_client.py: Removed.
117         * pywebsocket/example/echo_wsh.py: Removed.
118         * pywebsocket/mod_pywebsocket: Removed.
119         * pywebsocket/mod_pywebsocket/__init__.py: Removed.
120         * pywebsocket/mod_pywebsocket/dispatch.py: Removed.
121         * pywebsocket/mod_pywebsocket/handshake.py: Removed.
122         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Removed.
123         * pywebsocket/mod_pywebsocket/memorizingfile.py: Removed.
124         * pywebsocket/mod_pywebsocket/msgutil.py: Removed.
125         * pywebsocket/mod_pywebsocket/standalone.py: Removed.
126         * pywebsocket/mod_pywebsocket/util.py: Removed.
127         * pywebsocket/setup.py: Removed.
128         * pywebsocket/test: Removed.
129         * pywebsocket/test/config.py: Removed.
130         * pywebsocket/test/mock.py: Removed.
131         * pywebsocket/test/run_all.py: Removed.
132         * pywebsocket/test/test_dispatch.py: Removed.
133         * pywebsocket/test/test_handshake.py: Removed.
134         * pywebsocket/test/test_memorizingfile.py: Removed.
135         * pywebsocket/test/test_mock.py: Removed.
136         * pywebsocket/test/test_msgutil.py: Removed.
137         * pywebsocket/test/test_util.py: Removed.
138         * pywebsocket/test/testdata: Removed.
139         * pywebsocket/test/testdata/handlers: Removed.
140         * pywebsocket/test/testdata/handlers/blank_wsh.py: Removed.
141         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Removed.
142         * pywebsocket/test/testdata/handlers/sub: Removed.
143         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Removed.
144         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Removed.
145         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Removed.
146         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Removed.
147         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Removed.
148         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Removed.
149
150 2010-02-26  Chris Jerdonek  <cjerdonek@webkit.org>
151
152         Reviewed by Eric Seidel.
153
154         Changed the diff_parser module to log to a module-specific
155         logging.logger rather than the root logger.
156
157         https://bugs.webkit.org/show_bug.cgi?id=35391
158
159         * Scripts/webkitpy/diff_parser.py:
160
161 2010-02-26  Csaba Osztrogonác  <ossy@webkit.org>
162
163         Reviewed by Kenneth Rohde Christiansen.
164
165         [Qt] LayoutTestController.numberOfPages() should have default parameters
166         https://bugs.webkit.org/show_bug.cgi?id=35428
167
168         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: maxViewWidth and maxViewHeight moved to
169         LayoutTestController to converge to platform independent implementation.
170         (WebCore::DumpRenderTree::DumpRenderTree):
171         (WebCore::DumpRenderTree::open):
172         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Initialization of maxViewWidth and maxViewHeight added.
173         * DumpRenderTree/qt/LayoutTestControllerQt.h:
174          - Default parameters for LayoutTestController.numberOfPages() added.
175          - maxViewWidth and maxViewHeight members added.
176
177 2010-02-26  Jamey Hicks  <jamey.hicks@nokia.com>
178
179         Reviewed by Laszlo Gombos.
180
181         [Qt] added QWebSettings::setInspectorUrl() and QWebSettings::inspectorUrl()
182
183         Enables the use of alternate Web Inspector frontends by changing
184         the location of the frontend. The location is specified by providing 
185             -inspector-url url
186         as an argument to QtLauncher.
187
188         This is required so that the Web Inspector may be run from an
189         external process or an external tool such as Eclipse or Aptana may
190         be used instead of the in-process Web Inspector UI.
191         
192         https://bugs.webkit.org/show_bug.cgi?id=35340
193
194         * QtLauncher/main.cpp:
195         (LauncherWindow::init):
196         (LauncherApplication::handleUserOptions):
197
198 2010-02-25  Dirk Pranke  <dpranke@chromium.org>
199
200         Reviewed by Eric Seidel.
201
202         Add a 'passing' port implementation to new-run-webkit-tests that
203         acts as a wrapper around an existing implementation but stubs out
204         the actual test invocations (instead, the expected results are echoed
205         back to the harness). This is useful for coverage and perf testing
206         of the harness (especially perf testing as it essentially provides
207         a lower bound on how fast the harness can run).
208
209         Also added a --nostart-helper flag to new-run-webkit-tests so that
210         you can skip starting the layout_test_helper and actually run the
211         harness even if you don't have a build of that port.
212
213         Also fix a bug in the 'test' port implementation to actually
214         create the results directory under /tmp instead of /.
215
216         https://bugs.webkit.org/show_bug.cgi?id=35370
217
218         * Scripts/webkitpy/layout_tests/port/factory.py: Modified.
219         * Scripts/webkitpy/layout_tests/port/passing.py: Added.
220         * Scripts/webkitpy/layout_tests/port/test.py: Added.
221         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Modified.
222
223 2010-02-25  Eric Seidel  <eric@webkit.org>
224
225         Fix typo in my last change.  No review.
226
227         Rename run-chromium-webkit-tests to new-run-webkit-tests to stop confusion
228         https://bugs.webkit.org/show_bug.cgi?id=35408
229
230         * Scripts/new-run-webkit-tests:
231
232 2010-02-25  Eric Seidel  <eric@webkit.org>
233
234         Reviewed by Adam Barth.
235
236         Rename run-chromium-webkit-tests to new-run-webkit-tests to stop confusion
237         https://bugs.webkit.org/show_bug.cgi?id=35408
238
239         * Scripts/new-run-webkit-tests: Added.
240         * Scripts/run-chromium-webkit-tests: Removed.
241         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py.
242
243 2010-02-25  Adam Barth  <abarth@webkit.org>
244
245         Reviewed by David Levin.
246
247         EWS leaks memory slowly
248         https://bugs.webkit.org/show_bug.cgi?id=35395
249
250         The EWS bots leak memory very slowly.  If you run them for about a
251         month, each one will take up around 1 GB of virutal memory.  If you run
252         several of them on one machine, you'll eventually exhaust all available
253         memory and grind the bots to a halt.
254
255         This patch introduces a --exit-after-iteration option to the queues so
256         that we run them for a finite amount of time.  Once they exit and
257         restart, they'll reclaim the leaked memory.  I'm not sure how many
258         iterations I'll end up running them for.  I'll need to sort that out
259         operationally, but my initial guess is around 1000.
260
261         * Scripts/webkitpy/commands/queues.py:
262         * Scripts/webkitpy/commands/queues_unittest.py:
263
264 2010-02-25  Jarkko Sakkinen  <jarkko.sakkinen@tieto.com>
265
266         Reviewed by Kenneth Rohde Christiansen.
267
268         Qt WebGL support
269
270         Adds toggling of WebGL support to QtLauncher.
271         https://bugs.webkit.org/show_bug.cgi?id=35153
272
273         * QtLauncher/main.cpp:
274         (LauncherWindow::toggleWebGL):
275         (LauncherWindow::setupUI):
276
277 2010-02-25  Ben Murdoch  <benm@google.com>
278
279         Reviewed by Kenneth Rohde Christiansen.
280
281         The target element of a Touch should be the target where that touch originated, not where it is now.
282         https://bugs.webkit.org/show_bug.cgi?id=34585
283
284         * DumpRenderTree/qt/EventSenderQt.cpp:
285         (EventSender::addTouchPoint): Fix a bug where touch points were not being given unique ids.
286
287 2010-02-24  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
288
289         Reviewed by Kenneth Rohde Christiansen.
290
291         [Qt] QtLauncher has a border when running on QGraphicsView mode
292         https://bugs.webkit.org/show_bug.cgi?id=35352
293
294         Fix 2-pixels frame on each border of QtLauncher when running on QGraphicsView mode.
295
296         * QtLauncher/webview.cpp:
297         (WebViewGraphicsBased::WebViewGraphicsBased):
298
299 2010-02-23  Dirk Pranke  <dpranke@chromium.org>
300
301         Reviewed by David Levin.
302
303         When the run-chromium-webkit-tests code was landed and the code was
304         refactored into the 'port' package, I accidentally broke using
305         http_server.py or websocket_server.py as command-line scripts
306         (the constructors needed a port object they weren't getting). This
307         change fixes them so that --server start|stop actually works.
308
309         As a part of this, the two files need to be able to call port.get(),
310         but doing that is awkward from a file inside the package, so I moved
311         get() into factory.py and imported that into __init__.py so that
312         http_server.py and websocket_server.py can just import factory.
313
314         https://bugs.webkit.org/show_bug.cgi?id=35316
315
316         * Scripts/webkitpy/layout_tests/port/__init__.py:
317         * Scripts/webkitpy/layout_tests/port/factory.py:
318         * Scripts/webkitpy/layout_tests/port/http_server.py:
319         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
320
321 2010-02-24  Dirk Pranke  <dpranke@chromium.org>
322
323         Reviewed by David Levin.
324
325         Fix the function signature for check_sys_deps on the mac port, and
326         fix the ordering of port_obj.check_sys_deps() and
327         port_obj.start_helper() (helper needs to be started before we check
328         the system configuration).
329
330         http://bugs.webkit.org/show_bug.cgi?id=35367
331
332         * Scripts/webkitpy/layout_tests/port/mac.py:
333         * Scripts/webkitpy/layout_tests/port/test.py:
334         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
335
336 2010-02-24  James Robinson  <jamesr@chromium.org>
337
338         Reviewed by Eric Seidel.
339
340         Provide default username parameter to SVN.commit_with_message().
341
342         * Scripts/webkitpy/scm.py:
343
344 2010-02-24  Dirk Pranke  <dpranke@chromium.org>
345
346         Reviewed by Eric Siedel.
347
348         Check the proper directory for a WebKit SVN version (Chromium does
349         not check out the entire WebKit tree directly, but rather pulls
350         individual subdirectories. So, checking for the SVN version in
351         WebKit/WebCore rather than just in WebKit works more reliably across
352         different ports).
353
354         http://bugs.webkit.org/show_bug.cgi?id=35321
355
356         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
357
358 2010-02-24  Alexey Proskuryakov  <ap@apple.com>
359
360         Reviewed by Dan Bernstein.
361
362         https://bugs.webkit.org/show_bug.cgi?id=35357
363         Two editing tests fail after DumpRenderTree run loop changes
364
365         AppKit decided that it wanted to group all editing commands for some reason (and thus undo
366         reverted them all at once).
367
368         * DumpRenderTree/mac/DumpRenderTree.mm:
369         (dump): Reverted the change that made DumpRenderTree use -[NSApplication run].
370         (runTest): Ditto.
371         (-[DumpRenderTreeApplication isRunning]): Override isRunning with a function that always
372         returns YES. This is another way to make the Java plug-in work.
373
374 2010-02-23  Adam Roben  <aroben@apple.com>
375
376         Make commit-log-editor find just-added ChangeLog files
377
378         Fixes <http://webkit.org/b/35294> commit-log-editor doesn't find
379         just-added ChangeLog files
380
381         Reviewed by Dave Levin.
382
383         * Scripts/commit-log-editor:
384         (top level): Modified the regular expression that's used to find
385         modified ChangeLog files to also look for just-added ChangeLog files.
386
387 2010-02-24  Shinichiro Hamaji  <hamaji@chromium.org>
388
389         Reviewed by Darin Adler.
390
391         check-webkit-style false positive for WebCore forwarding header
392         https://bugs.webkit.org/show_bug.cgi?id=34604
393
394         * Scripts/webkitpy/style/checker.py:
395         * Scripts/webkitpy/style/checker_unittest.py:
396
397 2010-02-23  Alexey Proskuryakov  <ap@apple.com>
398
399         Reviewed by Mark Rowe.
400
401         https://bugs.webkit.org/show_bug.cgi?id=22602
402         Enable Java in DumpRenderTree (on Mac)
403
404         * DumpRenderTree/mac/DumpRenderTree.mm:
405         (exitApplicationRunLoop):
406         (dump):
407         (runTest):
408         DumpRenderTree now runs an NSApplication, not just an event loop. This way, the Java plug-in
409         can start without freezing.
410
411         * Scripts/run-webkit-tests: Compile java sources in LayputTests/java.
412
413 2010-02-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
414
415         Reviewed by Kenneth Rohde Christiansen.
416
417         [Qt] Need a final integration between QtLauncher and QGVLauncher
418         https://bugs.webkit.org/show_bug.cgi?id=35292
419
420         WebKit coding style fixes.
421
422         * QtLauncher/main.cpp:
423         (LauncherWindow::resetZoom):
424
425 2010-02-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
426
427         Reviewed by Kenneth Rohde Christiansen.
428
429         [Qt] Need a final integration between QtLauncher and QGVLauncher
430         https://bugs.webkit.org/show_bug.cgi?id=35292
431
432         Add cloneWindow feature to QtLauncher, when running on QGraphicsView mode.
433
434         * QtLauncher/main.cpp:
435         (LauncherWindow::LauncherWindow):
436         (LauncherWindow::~LauncherWindow):
437         (LauncherWindow::init):
438         (LauncherWindow::cloneWindow):
439         (LauncherWindow::setupUI):
440
441 2010-02-23  Dirk Pranke  <dpranke@chromium.org>
442
443         Reviewed by Dimitri Glazkov.
444
445         Fix handling of check_wdiff_install when wdiff isn't installed.
446
447         http://bugs.webkit.org/show_bug.cgi?id=35304
448
449         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
450
451 2010-02-23  Leandro Pereira  <leandro@profusion.mobi>
452
453         Reviewed by NOBODY.
454
455         Fix false positives for 'delete *pointer' statements.
456         http://webkit.org/b/35235
457
458         * WebKitTools/Scripts/webkitpy/style/processors/cpp.py:
459
460 2010-02-23  Shinichiro Hamaji  <hamaji@chromium.org>
461
462         Reviewed by Eric Seidel.
463
464         [Gtk] Implement layoutTestController.numberOfPages
465         https://bugs.webkit.org/show_bug.cgi?id=35228
466
467         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
468         (LayoutTestController::numberOfPages):
469
470 2010-02-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
471
472         Reviewed by Kenneth Rohde Christiansen.
473
474         [Qt] QtLauncher should not use internal JavaScriptCore and WebCore interfaces
475         https://bugs.webkit.org/show_bug.cgi?id=35248
476
477         * QtLauncher/QtLauncher.pro:
478         * QtLauncher/utils.h:
479
480 2010-02-23  Daniel Bates  <dbates@rim.com>
481
482         Reviewed by Eric Seidel.
483
484         https://bugs.webkit.org/show_bug.cgi?id=34439
485
486         Prompts a person for their SVN username if not already cached (by Subversion).
487
488         Currently, webkit-patch is unable to commit to the SVN repo. unless the
489         WebKit SVN username is already cached (from of a prior commit by hand)
490         because "svn commit" (called by webkit-patch) defaults to using the system
491         login name unless the username is already cached or specified on the
492         command line.
493
494         * Scripts/webkitpy/scm.py: Added methods SVN.has_authorization_for_realm and
495         modified SVN.commit_with_message to call it. Added optional username parameter
496         to method SVN.commit_with_message.
497         * Scripts/webkitpy/scm_unittest.py: Added unit test methods: SVNTest.test_commit_with_username,
498         SVNTest.test_has_authorization_for_realm, and SVNTest.test_not_have_authorization_for_realm.
499
500 2010-02-22  Dirk Pranke  <dpranke@chromium.org>
501
502         Reviewed by Eric Siedel.
503
504         Add more checking for missing binaries and packages to check_sys_deps()
505
506         https://bugs.webkit.org/show_bug.cgi?id=35062
507
508         * Scripts/webkitpy/layout_tests/port/base.py:
509         * Scripts/webkitpy/layout_tests/port/chromium.py:
510         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
511         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
512         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
513         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
514
515 2010-02-22  Shinichiro Hamaji  <hamaji@chromium.org>
516
517         Reviewed by David Levin.
518
519         [Gtk] check-webkit-style: GTK style should be allowed in WebKitTools/DumpRenderTree/gtk
520         https://bugs.webkit.org/show_bug.cgi?id=35229
521
522         * Scripts/webkitpy/style/checker.py:
523         * Scripts/webkitpy/style/checker_unittest.py:
524
525 2010-02-22  James Robinson  <jamesr@chromium.org>
526
527         Unreviewed. Adding myself to committers list.
528
529         * Scripts/webkitpy/committers.py:
530
531 2010-02-22  Simon Fraser  <simon.fraser@apple.com>
532
533         Reviewed by Darin Adler.
534
535         Remove DRT hack that turns off hardware acceleration with older QuickTimes
536         https://bugs.webkit.org/show_bug.cgi?id=35275
537         
538         Now that WebKit does a version check to avoid a QuickTime-related
539         crash (r55100), DumpRenderTree does not need to.
540
541         * DumpRenderTree/mac/DumpRenderTree.mm:
542         (resetDefaultsToConsistentValues):
543
544 2010-02-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
545
546         Reviewed by Kenneth Rohde Christiansen.
547
548         [Qt] Build the DRT in debug on Mac OS X
549
550         * DumpRenderTree/qt/DumpRenderTree.pro:
551
552 2010-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
553
554         Reviewed by Kenneth Rohde Christiansen.
555
556         [Qt] Add support for layout tests on Symbian
557         https://bugs.webkit.org/show_bug.cgi?id=31589
558
559         * DumpRenderTree/qt/DumpRenderTree.pro:
560         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
561         * DumpRenderTree/qt/main.cpp:
562         (main):
563
564 2010-02-20  Chris Jerdonek  <cjerdonek@webkit.org>
565
566         Reviewed by Adam Barth.
567
568         Moved simplejson into webkitpy/thirdparty directory.
569
570         https://bugs.webkit.org/show_bug.cgi?id=35196
571
572         * Scripts/run-chromium-webkit-tests:
573           - Added webkitpy/thirdparty to the script's search path.
574
575         * Scripts/webkitpy/thirdparty/simplejson: Copied from WebKitTools/simplejson.
576           - Copied simplejson directory.
577
578         * simplejson: Removed.
579         * simplejson/LICENSE.txt: Removed.
580         * simplejson/README.txt: Removed.
581         * simplejson/__init__.py: Removed.
582         * simplejson/_speedups.c: Removed.
583         * simplejson/decoder.py: Removed.
584         * simplejson/encoder.py: Removed.
585         * simplejson/jsonfilter.py: Removed.
586         * simplejson/scanner.py: Removed.
587
588 2010-02-20  Chris Jerdonek  <cjerdonek@webkit.org>
589
590         Reviewed by Adam Barth.
591
592         Moved BeautifulSoup to webkitpy/thirdparty directory.
593
594         https://bugs.webkit.org/show_bug.cgi?id=35195
595
596         * Scripts/webkitpy/BeautifulSoup.py: Removed.
597           - Moved to webkitpy/thirdparty.
598
599         * Scripts/webkitpy/bugzilla.py:
600           - Updated import statement.
601
602         * Scripts/webkitpy/bugzilla_unittest.py:
603           - Updated import statement.
604
605         * Scripts/webkitpy/buildbot.py:
606           - Updated import statement.
607
608         * Scripts/webkitpy/buildbot_unittest.py:
609           - Updated import statement.
610
611         * Scripts/webkitpy/statusserver.py:
612           - Updated import statement.
613
614         * Scripts/webkitpy/thirdparty/BeautifulSoup.py: Copied from WebKitTools/Scripts/webkitpy/BeautifulSoup.py.
615
616 2010-02-20  Chris Jerdonek  <cjerdonek@webkit.org>
617
618         Reviewed by Adam Barth.
619
620         Created a directory for third-party Python code, and moved
621         autoinstall.py into it.
622
623         https://bugs.webkit.org/show_bug.cgi?id=34540
624
625         * Scripts/webkitpy/__init__.py:
626           - Updated "import autoinstall" statement.
627
628         * Scripts/webkitpy/autoinstall.py: Removed.
629           - Moved to thirdparty/autoinstall.py.
630
631         * Scripts/webkitpy/thirdparty: Added.
632         * Scripts/webkitpy/thirdparty/__init__.py: Added.
633         * Scripts/webkitpy/thirdparty/autoinstall.py: Copied from WebKitTools/Scripts/webkitpy/autoinstall.py.
634
635 2010-02-20  Gustavo Noronha Silva  <gns@gnome.org>
636
637         Unreviewed, obvious fix for the python failure in our new buildbot
638         step:
639
640         http://build.webkit.org/builders/GTK Linux 32-bit Release/builds/9075/steps/API tests/logs/err.text
641
642         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
643
644 2010-02-19  Maciej Stachowiak  <mjs@apple.com>
645
646         Reviewed by David Levin.
647
648         Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
649         https://bugs.webkit.org/show_bug.cgi?id=35147
650
651         * Scripts/build-webkit: Handle new flag.
652
653 2010-02-19  Leandro Pereira  <leandro@profusion.mobi>
654
655         Reviewed by Shinichiro Hamaji.
656
657         [style-queue] should not complain about identifier names with underscores under WebKit/efl/ewk/
658         https://bugs.webkit.org/show_bug.cgi?id=35091
659
660         White list unix_hacker_style names in WebKit/efl/ewk because these
661         are used in the EFL API.
662
663         * Scripts/webkitpy/style/checker.py:
664          - Filter out readability/naming on WebKit/efl/ewk.
665
666 2010-02-19  Eric Seidel  <eric@webkit.org>
667
668         Reviewed by Adam Barth.
669
670         Split out "prepare-rollout" from "rollout" and make --complete-rollout default
671         https://bugs.webkit.org/show_bug.cgi?id=33745
672
673         * Scripts/webkitpy/commands/download.py:
674          - Add a new AbstractRolloutPrepCommand to share code between PrepareRollout and Rollout
675          - Add PrepareRollout
676         * Scripts/webkitpy/commands/download_unittest.py: Test PrepareRollout, remove CompleteRollout tests.
677         * Scripts/webkitpy/steps/__init__.py: include ReopenBugAfterRollout step.
678         * Scripts/webkitpy/steps/completerollout.py: Removed.
679         * Scripts/webkitpy/steps/options.py: remove complete_rollout
680         * Scripts/webkitpy/steps/reopenbugafterrollout.py: Added.
681
682 2010-02-19  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
683
684         Reviewed by Kenneth Rohde Christiansen.
685
686         [Qt] Need a final integration between QtLauncher and QGVLauncher
687         https://bugs.webkit.org/show_bug.cgi?id=35161
688
689         Add animated flip support to QtLauncher when running on QGraphicsView mode.
690
691         * QtLauncher/main.cpp:
692         (LauncherWindow::initializeView):
693         (LauncherWindow::setupUI):
694         * QtLauncher/webview.cpp:
695         (WebViewGraphicsBased::WebViewGraphicsBased):
696         (WebViewGraphicsBased::animatedFlip):
697         (WebViewGraphicsBased::animatedYFlip):
698         * QtLauncher/webview.h:
699         (WebViewGraphicsBased::setYRotation):
700         (WebViewGraphicsBased::yRotation):
701
702 2010-02-19  Andras Becsi  <abecsi@webkit.org>
703
704         Reviewed by Kenneth Rohde Christiansen.
705
706         [Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender, add results
707         for passing new tests and unskip the passing ones from the Skipped list.
708         https://bugs.webkit.org/show_bug.cgi?id=35159
709
710         * DumpRenderTree/qt/EventSenderQt.cpp:
711         (EventSender::textZoomIn):
712         (EventSender::textZoomOut):
713         * DumpRenderTree/qt/EventSenderQt.h:
714
715 2010-02-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
716
717         Reviewed by Eric Seidel.
718
719         [Qt] Clean-up the handling of HTML5 persistent data for LayoutTests
720         https://bugs.webkit.org/show_bug.cgi?id=35004
721
722         DumpRenderTreeQt.cpp calls QWebSettings::enablePersistentStorage which sets up 
723         and enables all HTML5 persistent data. All the other calls for setting the 
724         persistent path or enabling the persistent feature are redundant. 
725
726         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
727         (WebCore::WebPage::WebPage): No need to enable AppCache again.
728         * DumpRenderTree/qt/main.cpp:
729         (main): No need to setup and enable HTML5 LocalStorage again.
730
731 2010-02-19  Diego Gonzalez  <diego.gonzalez@openbossa.org>
732
733         Reviewed by Kenneth Rohde Christiansen.
734
735         Send the context menu event from contextClick() of EventSender
736         and do not show context menu in DRT.
737
738         LayoutTests:
739             fast/events/contextmenu-scrolled-page-with-frame.html
740
741         [Qt] DRT: Send context menu event from EventSender
742         https://bugs.webkit.org/show_bug.cgi?id=35131
743
744         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
745         (WebCore::DumpRenderTree::DumpRenderTree):
746         * DumpRenderTree/qt/EventSenderQt.cpp:
747         (EventSender::contextClick):
748
749 2010-02-18  Chris Jerdonek  <cjerdonek@webkit.org>
750
751         Reviewed by Shinichiro Hamaji.
752
753         Moved parsing-related code to a separate file. Also increased
754         the unit test coverage in some affected areas.
755
756         https://bugs.webkit.org/show_bug.cgi?id=34675
757
758         This revision contains no new functionality.
759
760         * Scripts/check-webkit-style:
761           - Adjusted to call check_webkit_style_parser().
762
763         * Scripts/webkitpy/style/checker.py:
764           - Added check_webkit_style_parser() to pass checker.py
765             configuration settings to optparser.py.
766           - Moved _create_usage() and the CommandOptionValues,
767             DefaultCommandOptionValues, ArgumentPrinter, and
768             ArgumentParser classes to optparser.py.
769
770         * Scripts/webkitpy/style/checker_unittest.py:
771           - Moved the ProcessorOptionsTest, ArgumentPrinterTest, and
772             ArgumentParserTest classes to optparser.py.
773           - Added the CheckWebKitStyleFunctionTest class to check
774             the check_webkit_style_configuration() and
775             check_webkit_style_parser() code paths.
776
777         * Scripts/webkitpy/style/optparser.py: Added.
778           - From checker.py, added _create_usage() and the
779             CommandOptionValues, DefaultCommandOptionValues,
780             ArgumentPrinter, and ArgumentParser classes.
781           - In the ArgumentParser constructor--
782             - Added all_categories as a required parameter.
783             - Removed the default value from the default_options parameter.
784
785         * Scripts/webkitpy/style/optparser_unittest.py: Added.
786           - From checker_unittest.py, added the ProcessorOptionsTest,
787             ArgumentPrinterTest, and ArgumentParserTest classes.
788           - Added the CreateUsageTest class to test _create_usage().
789
790         * Scripts/webkitpy/style/unittests.py:
791           - Added optparser_unittest import.
792
793 2010-02-18  Alexey Proskuryakov  <ap@apple.com>
794
795         Reviewed by Dan Bernstein.
796
797         https://bugs.webkit.org/show_bug.cgi?id=35134
798         <rdar://problem/7246280> Crash when a plugin calls NPN_SetStatus(0)
799
800         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
801         (testSetStatus):
802         (pluginInvoke):
803         Added a setStatus() method.
804
805 2010-02-18  Brady Eidson  <beidson@apple.com>
806
807         Reviewed by Sam Weinig.
808
809         Particularly constructed WebFrames can try to access a null HistoryItem
810         <rdar://problem/7638892> and https://bugs.webkit.org/show_bug.cgi?id=35063
811
812         Add the specific ability to test this API pattern. 
813
814         For now only on Mac, perhaps on the main Windows port later, probably not relevant for other ports.
815
816         * DumpRenderTree/LayoutTestController.cpp:
817         (apiTestNewWindowDataLoadBaseURLCallback):
818         (LayoutTestController::staticFunctions):
819         * DumpRenderTree/LayoutTestController.h:
820
821         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
822         (-[APITestDelegate initWithCompletionCondition:]):
823         (-[APITestDelegate webView:didFailLoadWithError:forFrame:]):
824         (-[APITestDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
825         (-[APITestDelegate webView:didFinishLoadForFrame:]):
826         (LayoutTestController::apiTestNewWindowDataLoadBaseURL): Create a WebView, do a loadData: in its
827           mainFrame, and synchronously wait for main load completion.
828
829         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
830         (LayoutTestController::apiTestNewWindowDataLoadBaseURL):
831         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
832         (LayoutTestController::apiTestNewWindowDataLoadBaseURL):
833         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
834         (LayoutTestController::apiTestNewWindowDataLoadBaseURL):
835
836 2010-02-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
837
838         Reviewed by Eric Seidel.
839
840         Teach resolve-ChangeLogs to act as a merge-driver for Git
841
842         https://bugs.webkit.org/show_bug.cgi?id=28721
843
844         To enable automatic merging of ChangeLog files, use the following command:
845
846         git config merge.changelog.driver "resolve-ChangeLogs --merge-driver %O %A %B"
847
848         The driver always works in "downstream" merge mode, meaning
849         it will always put the user's changelog entries on top.
850
851         * Scripts/resolve-ChangeLogs:
852
853 2009-12-05  Gustavo Noronha Silva  <gns@gnome.org>
854
855         Reviewed by Eric Seidel.
856
857         Enable running of GTK+ API tests.
858
859         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
860         * Scripts/run-gtk-tests: Added.
861
862 2010-02-18  Shinichiro Hamaji  <hamaji@chromium.org>
863
864         Reviewed by Adam Barth.
865
866         debug-safari doesn't pass --debug option to gdb-safari on MacOSX
867         https://bugs.webkit.org/show_bug.cgi?id=34411
868
869         * Scripts/webkitdirs.pm:
870
871 2010-02-18  Eric Seidel  <eric@webkit.org>
872
873         Reviewed by Adam Barth.
874
875         run-chromium-webkit-tests --platform=mac-leopard needs to run build-dumprendertree
876         https://bugs.webkit.org/show_bug.cgi?id=35053
877
878         * Scripts/webkitpy/layout_tests/port/base.py: Add script_path() function for finding scripts.
879         * Scripts/webkitpy/layout_tests/port/chromium.py: Remove unused argument.
880         * Scripts/webkitpy/layout_tests/port/mac.py:
881          - Make sure that calling webkit-build-directory works even if Scripts/ is not in the user's path.
882          - Call build-dumprendertree (and make sure it succeeds) before running the tests.
883
884 2010-02-16  Chris Jerdonek  <cjerdonek@webkit.org>
885
886         Reviewed by Shinichiro Hamaji.
887
888         Refactored check-webkit-style's ProcessorOptions class into two
889         classes. This revision contains no new functionality.
890
891         https://bugs.webkit.org/show_bug.cgi?id=34674
892
893         Divided the ProcessorOptions class into a CommandOptionValues
894         class (the result of parsing the command-line options) and
895         a StyleCheckerConfiguration class (which configures the main
896         StyleChecker).
897
898         * Scripts/check-webkit-style:
899           - Updated main() to convert the parsed command option values
900             to a StyleCheckConfiguration instance prior to constructing
901             a StyleChecker.
902
903         * Scripts/webkitpy/style/checker.py:
904           - Added check_webkit_style_configuration() to convert a
905             CommandOptionValues instance into a StyleCheckerConfiguration
906             instance.
907           - Renamed the ProcessorOptions class to CommandOptionValues.
908           - In the CommandOptionValues class--
909             - Replaced the filter_configuration attribute with the
910               simpler filter_rules attribute.
911             - Removed the max_reports_per_error attribute.
912             - Moved the is_reportable() method to the new
913               StyleCheckerConfiguration class.
914           - Removed the base_filter_rules attribute from the
915             DefaultCommandOptionValues class.
916           - In the ArgumentParser class--
917             - Added base_filter_rules to the constructor.
918             - Changed the parse() method to return a CommandOptionValues
919               instance instead of a ProcessorOptions instance.
920           - Created a StyleCheckerConfiguration class.
921             - Added the data attributes max_reports_per_category,
922               stderr_write, and verbosity.
923             - Added is_reportable() (moved from the ProcessorOptions
924               class) and write_style_error() (moved from the
925               DefaultStyleErrorHandler class).
926           - In the StyleChecker class--
927             - Replaced the ProcessorOptions options attribute with the
928               StyleCheckerConfiguration _configuration attribute.
929             - Removed the _stderr_write attribute.
930
931         * Scripts/webkitpy/style/checker_unittest.py:
932           - Updated the existing unit test classes as necessary.
933           - Added a StyleCheckerConfigurationTest class.
934
935         * Scripts/webkitpy/style/error_handlers.py:
936           - Updated the DefaultStyleErrorHandler class to accept a
937             StyleCheckerConfiguration instance instead of a ProcessorOptions
938             instance and an stderr_write method.
939
940         * Scripts/webkitpy/style/error_handlers_unittest.py:
941           - Updated the unit test classes as necessary.
942
943         * Scripts/webkitpy/style/filter.py:
944           - Addressed the FIXME in the FilterConfiguration class to change
945             the user_rules attribute to _user_rules (since it is now
946             accessed only internally).
947
948         * Scripts/webkitpy/style/filter_unittest.py:
949           - Updated to reflect the change from user_rules to _user_rules.
950
951 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
952
953         Reviewed by Eric Seidel.
954
955         Share the DRT values maxViewWidth/Height among ports
956         https://bugs.webkit.org/show_bug.cgi?id=34474
957
958         * DumpRenderTree/LayoutTestController.cpp:
959         (pageNumberForElementByIdCallback):
960         * DumpRenderTree/LayoutTestController.h:
961         (LayoutTestController::maxViewWidth):
962         (LayoutTestController::maxViewHeight):
963         * DumpRenderTree/gtk/DumpRenderTree.cpp:
964         (runTest):
965         * DumpRenderTree/mac/DumpRenderTree.mm:
966         (createWebViewAndOffscreenWindow):
967         (sizeWebViewForCurrentTest):
968         * DumpRenderTree/win/DumpRenderTree.cpp:
969         (dump):
970         (createWebViewAndOffscreenWindow):
971
972 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
973
974         Reviewed by Eric Seidel.
975
976         [Win] Implement test functions for printing
977         https://bugs.webkit.org/show_bug.cgi?id=34570
978
979         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
980         (LayoutTestController::pageNumberForElementById):
981         (LayoutTestController::numberOfPages):
982
983 2010-02-17  Fumitoshi Ukai  <ukai@chromium.org>
984
985         Reviewed by Eric Seidel.
986
987         websocket/tests/cookies/httponly-cookie.pl fails every time under run-chromium-webkit-tests
988         https://bugs.webkit.org/show_bug.cgi?id=35001
989
990         * Scripts/webkitpy/layout_tests/port/websocket_server.py: add -x flag to run pywebsocket.
991
992 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
993
994         Reviewed by Eric Seidel.
995
996         check-webkit-style: Misses variables that contain underscores.
997         https://bugs.webkit.org/show_bug.cgi?id=33724
998
999         - Check identifiers whose types are unsigned.
1000         - Check bitfields properly.
1001
1002         * Scripts/webkitpy/style/processors/cpp.py:
1003         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1004
1005 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
1006
1007         Reviewed by Eric Seidel.
1008
1009         check-webkit-style should report the number of files checked
1010         https://bugs.webkit.org/show_bug.cgi?id=34971
1011
1012         * Scripts/check-webkit-style:
1013         * Scripts/webkitpy/style/checker.py:
1014         * Scripts/webkitpy/style/checker_unittest.py:
1015
1016 2010-02-17  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1017
1018         Reviewed by Ariya Hidayat.
1019
1020         Make possible Qt DRT to get total number of pages to be printed
1021
1022         LayoutTests:
1023             printing/numberOfPages.html
1024
1025         [Qt] DRT: Get total number of pages to be printed
1026         https://bugs.webkit.org/show_bug.cgi?id=34955
1027
1028         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1029         (LayoutTestController::numberOfPages):
1030         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1031
1032 2010-02-17  Xan Lopez  <xlopez@igalia.com>
1033
1034         Reviewed by Gustavo Noronha.
1035
1036         Update to use new property name.
1037
1038         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1039         (resetDefaultsToConsistentValues):
1040
1041 2010-02-17  Julien Chaffraix  <jchaffraix@webkit.org>
1042
1043         Reviewed by Ariya Hidayat.
1044
1045         Remove some warnings seen when building Qt
1046         https://bugs.webkit.org/show_bug.cgi?id=35017
1047
1048         Using a machine without the needed tools to build WebKit leads to
1049         several errors and warnings.
1050
1051         * Scripts/webkitdirs.pm: Refactored the code testing the command's
1052         presence into a commandExists routine. While doing so removed, stderr
1053         output as it usually does not give anything more than our message. Also
1054         added a Qt check for qmake that was missing.
1055
1056 2010-02-17  Xan Lopez  <xlopez@igalia.com>
1057
1058         Rubber-stamped by Gustavo Noronha.
1059
1060         Disable Java by default in DRT.
1061
1062         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1063         (resetDefaultsToConsistentValues):
1064
1065 2010-02-15  Chris Jerdonek  <cjerdonek@webkit.org>
1066
1067         Reviewed by Shinichiro Hamaji.
1068
1069         Some minor check-webkit-style code clean-ups.  This revision
1070         contains no new functionality.
1071
1072         https://bugs.webkit.org/show_bug.cgi?id=34932
1073
1074         * Scripts/check-webkit-style:
1075           - Replaced the call to webkit_argument_defaults() with a
1076             default parameter in the ArgumentParser constructor.
1077
1078         * Scripts/webkitpy/style/checker.py:
1079           - Removed the WEBKIT prefix from the default global variables.
1080           - Prefixed several of the global variables with an underscore
1081             to reflect that they are used internally.
1082           - Renamed _DEFAULT_FILTER_RULES to _BASE_FILTER_RULES.
1083           - Addressed a FIXME by changing the _PATH_RULES_SPECIFIER
1084             configuration from list-tuple pairs to list-list pairs.
1085           - Renamed style_categories() to _all_categories().
1086           - Renamed webkit_argument_defaults() to _check_webkit_style_defaults().
1087           - Renamed the ArgumentDefaults class to DefaultCommandOptionValues.
1088           - In the ArgumentParser class--
1089             - Renamed the doc_print attribute to stderr_write.
1090             - Other minor updates.
1091
1092         * Scripts/webkitpy/style/checker_unittest.py:
1093           - Updated the import statements and unit test classes as necessary.
1094           - Added assertions to test _PATH_RULES_SPECIFIER more fully.
1095
1096         * Scripts/webkitpy/style/error_handlers_unittest.py:
1097           - Updated the unit test classes as necessary.
1098           - Changed StyleErrorHandlerTestBase to store a list of error
1099             messages rather than just the last one.
1100
1101         * Scripts/webkitpy/style/filter.py:
1102           - Altered FilterConfiguration._path_rules_from_path()
1103             to convert the path_rules list to a tuple.
1104
1105         * Scripts/webkitpy/style/filter_unittest.py:
1106           - Updated the unit tests to reflect the change from tuples to
1107             lists in the _PATH_RULES_SPECIFIER configuration variable.
1108
1109 2010-02-16  Mark Rowe  <mrowe@apple.com>
1110
1111         Let's not check garbage in to common build scripts and hose the world now eh guys?
1112
1113         * Scripts/webkitdirs.pm:
1114
1115 2010-02-16  Eric Seidel  <eric@webkit.org>
1116
1117         Reviewed by Adam Barth.
1118
1119         re-factor Skipped list parsing code into multiple functions and unit test it
1120         https://bugs.webkit.org/show_bug.cgi?id=34986
1121
1122         * Scripts/test-webkitpy: Add new unit test.
1123         * Scripts/webkitpy/layout_tests/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
1124         * Scripts/webkitpy/layout_tests/port/mac.py: Split parsing function into multiple functions for testing.
1125         * Scripts/webkitpy/layout_tests/port/mac_unittest.py: Added.
1126
1127 2010-02-16  Xan Lopez  <xlopez@igalia.com>
1128
1129         Reviewed by Gustavo Noronha.
1130
1131         Enable 'auto-resize-window' in our DRT.
1132
1133         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1134         (resetDefaultsToConsistentValues):
1135
1136 2010-02-15  Martin Robinson  <mrobinson@webkit.org>
1137
1138         Reviewed by Darin Adler.
1139
1140         check-webkit-style should not complain about NULL sentinel in calls to g_strconcat and g_strjoin
1141         https://bugs.webkit.org/show_bug.cgi?id=34834
1142
1143         * Scripts/webkitpy/style/processors/cpp.py:
1144         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1145
1146 2010-02-12  Alexey Proskuryakov  <ap@apple.com>
1147
1148         Reviewed by Kevin Decker.
1149
1150         <rdar://problem/7130641> Browser objects identity is not preserved by Safari
1151
1152         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1153         (pluginInvoke): Added methods for checking object identity (via refcount).
1154
1155 2010-02-15  Robert Hogan  <robert@roberthogan.net>
1156
1157         Reviewed by Simon Hausmann.
1158
1159         [Qt] DRT: Support evaluateInWebInspector(), setTimelineProfilingEnabled().
1160
1161         Support LayoutTestController.evaluateInWebInspector(), setTimelineProfilingEnabled() in Qt DRT.
1162
1163         https://bugs.webkit.org/show_bug.cgi?id=33096
1164
1165         This allows the following tests to pass:
1166
1167         inspector/console-format-collections.html
1168         inspector/styles-iframe.html
1169         inspector/syntax-highlight-css.html
1170         inspector/syntax-highlight-javascript.html
1171         inspector/timeline-enum-stability.html
1172         inspector/timeline-layout.html
1173         inspector/timeline-mark-timeline.html
1174         inspector/timeline-paint.html
1175         inspector/timeline-parse-html.html
1176         inspector/timeline-recalculate-styles.html
1177         inspector/timeline-script-tag-1.html
1178         inspector/timeline-script-tag-2.html
1179         inspector/timeline-trivial.html
1180         inspector/cookie-resource-match.html
1181         inspector/elements-img-tooltip.html
1182         inspector/elements-panel-selection-on-refresh.html
1183         inspector/inspected-objects-not-overriden.html
1184         inspector/timeline-event-dispatch.html
1185         inspector/timeline-network-resource.html
1186         inspector/elements-panel-rewrite-href.html
1187         inspector/console-dir.html
1188         inspector/console-dirxml.html
1189         inspector/console-format.html
1190         inspector/console-tests.html
1191         inspector/elements-panel-structure.html
1192         inspector/evaluate-in-frontend.html
1193         inspector/console-clear.html
1194
1195         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1196         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1197         (WebCore::isWebInspectorTest):
1198         (WebCore::DumpRenderTree::open):
1199         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1200         (WebCore::DumpRenderTree::display):
1201         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1202         (LayoutTestController::closeWebInspector):
1203         (LayoutTestController::showWebInspector):
1204         (LayoutTestController::evaluateInWebInspector):
1205         (LayoutTestController::setTimelineProfilingEnabled):
1206         (LayoutTestController::display):
1207         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1208
1209 2010-02-14  Dirk Pranke  <dpranke@chromium.org>
1210
1211         Reviewed by Eric Seidel.
1212
1213         Update rebaseline-chromium-webkit-tests to work with the new code
1214         structure (port objects instead of path_utils and platform_utils).
1215
1216         Added a path_to_test_expectations_file() to the Port interface.
1217   
1218         Fixed a bug in the chromium_* platform implementations where the
1219         'target' option was assumed to be set.
1220
1221         * Scripts/rebaseline-chromium-webkit-tests:
1222         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1223         * Scripts/webkitpy/layout_tests/port/base.py:
1224         * Scripts/webkitpy/layout_tests/port/chromium.py:
1225         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1226         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1227         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1228         * Scripts/webkitpy/layout_tests/port/test.py:
1229         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1230
1231 2010-02-14  Eric Seidel  <eric@webkit.org>
1232
1233         Reviewed by Darin Adler.
1234
1235         webkit-build-directory misuses terms
1236         https://bugs.webkit.org/show_bug.cgi?id=34822
1237
1238         * Scripts/webkit-build-directory:
1239          - Add --top-level and --configuration options and make using one of them required.
1240         * Scripts/webkitpy/layout_tests/port/mac.py:
1241          - Use --top-level instead of --base.
1242
1243 2010-02-14  Chang Shu  <Chang.Shu@nokia.com>
1244
1245         Reviewed by Laszlo Gombos.
1246
1247         [Qt] Enable appcache feature.
1248         https://bugs.webkit.org/show_bug.cgi?id=34713
1249
1250         Re-land r54543 without the change in DumpRenderTree/qt/main.cpp.
1251         Persistent storage for AppCache is already initialized in
1252         DumpRenderTreeQt.cpp.
1253
1254         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1255         (WebCore::WebPage::WebPage):
1256
1257 2010-02-12  Chang Shu  <Chang.Shu@nokia.com>
1258
1259         Not Reviewed.
1260
1261         Change case of my email address as a work-around for the following bug.
1262         https://bugs.webkit.org/show_bug.cgi?id=34717
1263
1264         * Scripts/webkitpy/committers.py:
1265
1266 2010-02-12  Darin Adler  <darin@apple.com>
1267
1268         Ignore compiled Python in more of webkitpy.
1269
1270         * Scripts/webkitpy/style/processors: Added property svn:ignore.
1271
1272 2010-02-12  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1273
1274         Reviewed by Kenneth Rohde Christiansen.
1275
1276         Qt DRT now dump the frame loader callbacks when LayoutTestController()
1277         method is called.
1278
1279         LayoutTests:
1280             http/tests/security/mixedContent/data-url-script-in-iframe.html
1281             http/tests/security/mixedContent/empty-url-plugin-in-frame.html
1282             http/tests/security/mixedContent/insecure-css-in-iframe.html
1283             http/tests/security/mixedContent/insecure-iframe-in-iframe.html
1284             http/tests/security/mixedContent/insecure-image-in-iframe.html
1285             http/tests/security/mixedContent/insecure-plugin-in-iframe.html
1286             http/tests/security/mixedContent/insecure-script-in-iframe.html
1287             http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
1288             http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html
1289
1290         [Qt] Make possible Qt DRT dump frame load callbacks
1291         https://bugs.webkit.org/show_bug.cgi?id=34702
1292
1293         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1294         (LayoutTestController::reset):
1295         (LayoutTestController::dumpFrameLoadCallbacks):
1296         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1297
1298 2010-02-12  Simon Hausmann  <simon.hausmann@nokia.com>
1299
1300         Reviewed by Antti Koivisto.
1301
1302         Make QtLauncher somewhat useable on S60.
1303
1304         Show the window fullscreen to make scrollbars appear, resize
1305         the toolbar buttons to 16x16 to give more screen space to
1306         web content and moved the location lineedit into a separate
1307         line.
1308
1309         * QtLauncher/main.cpp:
1310         (LauncherWindow::LauncherWindow):
1311         * QtLauncher/mainwindow.cpp:
1312         (MainWindow::buildUI):
1313
1314 2010-02-12  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1315
1316         Reviewed by Kenneth Rohde Christiansen.
1317
1318         Support frameset flattening
1319         https://bugs.webkit.org/show_bug.cgi?id=32717
1320
1321         Add FrameSet Flattening support to Mac DRT.
1322
1323         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1324         (LayoutTestController::setFrameSetFlatteningEnabled):
1325         * DumpRenderTree/win/DumpRenderTree.cpp:
1326         (resetDefaultsToConsistentValues):
1327         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1328         (LayoutTestController::setXSSAuditorEnabled):
1329         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1330         (LayoutTestController::setFrameSetFlatteningEnabled):
1331         * DumpRenderTree/LayoutTestController.cpp:
1332         (setFrameSetFlatteningEnabledCallback):
1333         (LayoutTestController::staticFunctions):
1334         * DumpRenderTree/LayoutTestController.h:
1335         * DumpRenderTree/mac/DumpRenderTree.mm:
1336         (resetDefaultsToConsistentValues):
1337         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1338         (LayoutTestController::setFrameSetFlatteningEnabled):
1339
1340 2010-02-12  Dirk Pranke  <dpranke@chromium.org>
1341
1342         Reviewed by Eric Seidel.
1343
1344         Fix typos in driver_test.py 
1345
1346         https://bugs.webkit.org/show_bug.cgi?id=34810
1347
1348         * Scripts/webkitpy/layout_tests/driver_test.py:
1349
1350 2010-02-12  Simon Hausmann  <simon.hausmann@nokia.com>
1351
1352         Reviewed by Kenneth Rohde Christiansen.
1353
1354         [Qt] Make it possible to toggle the use of QGraphicsView in QtLauncher at run-time
1355         https://bugs.webkit.org/show_bug.cgi?id=34844
1356
1357         * QtLauncher/main.cpp:
1358         (LauncherWindow::LauncherWindow):
1359         (LauncherWindow::initializeView):
1360         (LauncherWindow::setupUI):
1361         * QtLauncher/webview.cpp:
1362         (WebViewGraphicsBased::WebViewGraphicsBased):
1363
1364 2010-02-11  Fumitoshi Ukai  <ukai@chromium.org>
1365
1366         Reviewed by Alexey Proskuryakov.
1367
1368         WebSocket ignores HttpOnly cookies, but should use in Handshake.
1369         https://bugs.webkit.org/show_bug.cgi?id=34289
1370
1371         Update pywebsocket to 0.4.8, which supports cgi directories.
1372         run-webkit-tests and run-webkit-websocketserver will run
1373         pywebsocket, specifying /websocket/test/cookies as cgi directory.
1374
1375         * Scripts/run-webkit-tests:
1376         * Scripts/run-webkit-websocketserver:
1377         * pywebsocket/mod_pywebsocket/standalone.py:
1378         * pywebsocket/setup.py:
1379
1380 2010-02-11  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1381
1382         Reviewed by Dan Bernstein.
1383
1384         [Mac] Duplicated setXSSAuditorEnabled preference at Mac DRT
1385         https://bugs.webkit.org/show_bug.cgi?id=34798
1386
1387         Remove duplicated setXSSAuditorEnabled preference at Mac DRT
1388
1389         * DumpRenderTree/mac/DumpRenderTree.mm:
1390         (resetDefaultsToConsistentValues):
1391
1392 2010-02-11  Eric Seidel  <eric@webkit.org>
1393
1394         No review, build fix only.
1395
1396         webkitdirs.pm has a crazy amount of duplicated feature detection code
1397         https://bugs.webkit.org/show_bug.cgi?id=34869
1398
1399         * Scripts/build-webkit: Fix typo which broke bots.
1400
1401 2010-02-11  Eric Seidel  <eric@webkit.org>
1402
1403         Reviewed by Adam Barth.
1404
1405         webkitdirs.pm has a crazy amount of duplicated feature detection code
1406         https://bugs.webkit.org/show_bug.cgi?id=34869
1407
1408         * Scripts/build-webkit: Use the new hotness.
1409         * Scripts/run-webkit-tests: ditto
1410         * Scripts/webkitdirs.pm: Remove a bunch of bad duplicate code.
1411         * Scripts/webkitperl/features.pm: Added.
1412          - Simplified the 10 methods in webkitdirs.pm into 2 exported methods in this new file.
1413
1414 2010-02-11  Daniel Bates  <dbates@rim.com>
1415
1416         Reviewed by Adam Barth.
1417
1418         https://bugs.webkit.org/show_bug.cgi?id=34830
1419
1420         Makes method User.prompt static and adds the parameter repeat
1421         to prompt the user up to repeat times.
1422
1423         * Scripts/test-webkitpy:
1424         * Scripts/webkitpy/bugzilla.py: Substituted method User.prompt for method raw_input.
1425         * Scripts/webkitpy/commands/upload.py: Ditto
1426         * Scripts/webkitpy/credentials.py: Ditto
1427         * Scripts/mock_bugzillatool.py: Updated prototype of MockUser.prompt to match User.prompt.
1428         * Scripts/webkitpy/user.py: Made method prompt static and added parameter repeat.
1429         * Scripts/webkitpy/user_unittest.py: Added.
1430
1431 2010-02-10  Yuzo Fujishima  <yuzo@google.com>
1432
1433         Reviewed by Darin Adler.
1434
1435         Allow underscored identifiers in CSSParser.cpp
1436
1437         Flex (http://flex.sourceforge.net/) uses identifiers named as yy_*.
1438         WebCore/css/CSSParser.cpp needs to handle some such identifiers.
1439         We should relax the style rule for the file to allow underscored identifiers.
1440
1441         https://bugs.webkit.org/show_bug.cgi?id=34787
1442
1443         * Scripts/webkitpy/style/checker.py:
1444
1445 2010-02-11  Eric Seidel  <eric@webkit.org>
1446
1447         Rubber-stamped by Adam Barth.
1448
1449         Remove DrawTest, the application I used when bringing up SVG support on the Mac.
1450         The code hasn't been touched (or used) in years.  No sense in keeping it in trunk.
1451
1452         * Scripts/build-drawtest: Removed.
1453         * Scripts/run-drawtest: Removed.
1454         * DrawTest: Removed.
1455
1456 2010-02-11  Eric Seidel  <eric@webkit.org>
1457
1458         Reviewed by Adam Barth.
1459
1460         Need a command to clear r+ on obsolete patches in the pending-commit queue.
1461         https://bugs.webkit.org/show_bug.cgi?id=34863
1462
1463         Unfortunately our http://webkit.org/pending-commit bugzilla query is not
1464         smart enough to ignore obsolete patches, so bugs show up there which are
1465         still open, but do not have patches ready for landing on them.
1466         This new command "clean-pending-commit" will remove r+ from obsolete patches
1467         in the pending-commit list.
1468
1469         * Scripts/test-webkitpy: Add grammar_unittest
1470         * Scripts/webkitpy/commands/upload.py: Add clean-pending-commit and make assign-to-committer ignore cq+'d patches.
1471         * Scripts/webkitpy/grammar.py: Add join_with_separators
1472         * Scripts/webkitpy/grammar_unittest.py: Added.
1473
1474 2010-02-11  Eric Seidel  <eric@webkit.org>
1475
1476         Reviewed by Adam Barth.
1477
1478         run-chromium-webkit-tests fails random pixel tests on Mac
1479         https://bugs.webkit.org/show_bug.cgi?id=34862
1480
1481         This is due to the fact that the Mac port has an
1482         invalid path to the image diff tool.  Currently it points
1483         to image_diff even though ImageDiff would be correct.  We
1484         can't change it to the right path yet without causing the
1485         script to hang.  ImageDiff expects to be long-running and
1486         be passed image data over stdin.  image_diff (chromium's fork)
1487         expects to be passed command line arguments.
1488         This fix works around the random failures by disabling pixel
1489         tests on mac and logging if the user was trying to run with pixel
1490         tests enabled.
1491
1492         * Scripts/webkitpy/layout_tests/port/mac.py:
1493
1494 2010-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
1495
1496         Reviewed by Adam Roben.
1497         Try to fix build breakage from r54665.
1498         
1499         * Scripts/check-for-global-initializers:
1500
1501 2010-02-11  Simon Hausmann  <simon.hausmann@nokia.com>
1502
1503         Reviewed by Tor Arne Vestbø.
1504
1505         Make it possible to toggle accelerated compositing from the menu
1506         at run-time.
1507
1508         * QtLauncher/main.cpp:
1509         (LauncherWindow::toggleAcceleratedCompositing):
1510         (LauncherWindow::setupUI):
1511
1512 2010-02-08  Maciej Stachowiak  <mjs@apple.com>
1513
1514         Reviewed by Cameron Zwarich.
1515
1516         Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
1517         https://bugs.webkit.org/show_bug.cgi?id=34698
1518
1519         * Scripts/build-webkit:
1520
1521 2010-02-10  Dirk Pranke  <dpranke@chromium.org>
1522
1523         Reviewed by Eric Seidel.
1524
1525         Fix various minor bugs keeping run-chromium-webkit-tests from actually
1526         working on the linux and win ports of Chromium.
1527
1528         https://bugs.webkit.org/show_bug.cgi?id=34739
1529
1530         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
1531         * Scripts/webkitpy/layout_tests/port/__init__.py:
1532         * Scripts/webkitpy/layout_tests/port/base.py:
1533         * Scripts/webkitpy/layout_tests/port/chromium.py:
1534         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1535         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1536         * Scripts/webkitpy/layout_tests/port/http_server.py:
1537         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1538
1539 2010-02-10  Eric Seidel  <eric@webkit.org>
1540
1541         Reviewed by David Levin.
1542
1543         run-chromium-webkit-tests --platform=mac-leopard crashes when using a custom build directory
1544         https://bugs.webkit.org/show_bug.cgi?id=34817
1545
1546         This doesn't fix the root cause of us not
1547         correctly failing when support binaries are missing.
1548         This only causes the DumpRenderTree binary not to be
1549         missing in the custom build directory case.
1550         Later patches will make us correctly fail fast when
1551         support binaries (like DumpRenderTree or ImageDiff) are missing.
1552
1553         * Scripts/webkit-build-directory: Added.
1554          - Need a way to re-use the perl logic for finding build directories in non-perl scripts.
1555         * Scripts/webkitpy/layout_tests/port/base.py: Add a FIXME.
1556         * Scripts/webkitpy/layout_tests/port/mac.py:
1557          - Call webkit-build-directory to find the build directory instead of assuming "WebKitBuild"
1558         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Add FIXMEs.
1559
1560 2010-02-10  Kevin Watters  <kevinwatters@gmail.com>
1561
1562         Reviewed by Kevin Ollivier.
1563
1564         [wx] Add Windows complex text support.
1565         
1566         https://bugs.webkit.org/show_bug.cgi?id=34759
1567
1568         * wx/build/settings.py:
1569
1570 2010-02-10  Kevin Ollivier  <kevino@theolliviers.com>
1571
1572         [wx] Build fix. Add stub for new LayoutTestController method.
1573
1574         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1575         (LayoutTestController::numberOfPages):
1576
1577 2010-02-10  Csaba Osztrogonác  <ossy@webkit.org>
1578
1579         Unreviewed. Roll out r54626, because it broke GTK and Win build.
1580         https://bugs.webkit.org/show_bug.cgi?id=32717
1581
1582         * DumpRenderTree/LayoutTestController.cpp:
1583         (LayoutTestController::staticFunctions):
1584         * DumpRenderTree/LayoutTestController.h:
1585         * DumpRenderTree/mac/DumpRenderTree.mm:
1586         (resetDefaultsToConsistentValues):
1587         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1588
1589 2010-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1590
1591         Reviewed by Kenneth Rohde Christiansen.
1592
1593         Support frameset flattening
1594         https://bugs.webkit.org/show_bug.cgi?id=32717
1595
1596         Add FrameSet Flattening support to Mac DRT.
1597
1598         * DumpRenderTree/LayoutTestController.cpp:
1599         (setFrameSetFlatteningEnabledCallback):
1600         (LayoutTestController::staticFunctions):
1601         * DumpRenderTree/LayoutTestController.h:
1602         * DumpRenderTree/mac/DumpRenderTree.mm:
1603         (resetDefaultsToConsistentValues):
1604         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1605         (LayoutTestController::setFrameSetFlatteningEnabled):
1606
1607 2010-02-08  Jon Honeycutt  <jhoneycutt@apple.com>
1608
1609         <rdar://problem/7436875> Crash in Flash when visiting
1610         http://www.cctv.com/default.shtml (WER ID 819298200) [watson 2502260]
1611
1612         Reviewed by Darin Adler.
1613
1614         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1615         (executeScript):
1616         Moved to an earlier point in the file.
1617         (NPP_New):
1618         If the plug-in has an onDestroy attribute, store its value.
1619         (NPP_Destroy):
1620         If the plug-in has code to run on destruction, run it and free it.
1621
1622 2010-02-10  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1623
1624         Reviewed by Kenneth Rohde Christiansen.
1625
1626         Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
1627         to make Qt DRT able to get page number.
1628
1629         LayoutTests:
1630             printing/page-break-always.html
1631             printing/pageNumerForElementById.html
1632             printing/css2.1/page-break-before-000.html
1633             printing/css2.1/page-break-after-000.html
1634             printing/css2.1/page-break-after-004.html
1635             printing/css2.1/page-break-before-001.html
1636             printing/css2.1/page-break-after-001.html
1637             printing/css2.1/page-break-after-002.html
1638             printing/css2.1/page-break-before-002.html
1639             printing/css2.1/page-break-inside-000.html
1640
1641         [Qt] Make possible Qt DRT get a page number for element by ID
1642         https://bugs.webkit.org/show_bug.cgi?id=34777
1643
1644         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1645         (LayoutTestController::pageNumberForElementById):
1646         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1647
1648 2010-02-10  Andras Becsi  <abecsi@webkit.org>
1649
1650         Reviewed by Adam Barth.
1651
1652         Make run-iexploder-tests work on Linux.
1653         https://bugs.webkit.org/show_bug.cgi?id=34748
1654
1655         Extract the platform dependant Apache configuration checking code in httpd.pm to a separate function
1656         called getHTTPDConfigPathForTestDirectory and use run-launcher instead of run-safari if run on Linux.
1657
1658         * Scripts/run-iexploder-tests:
1659         * Scripts/webkitperl/httpd.pm:
1660
1661 2010-02-09  Csaba Osztrogonác  <ossy@webkit.org>
1662
1663         [Qt] Unreviewed. Roll-out r54543, because layout tests crash in debug mode.
1664         https://bugs.webkit.org/show_bug.cgi?id=34713
1665
1666         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1667         (WebCore::WebPage::WebPage):
1668         * DumpRenderTree/qt/main.cpp:
1669         (main):
1670
1671 2010-02-09  Alejandro G. Castro  <alex@igalia.com>
1672
1673         Unreviewed; added myself to committers
1674
1675         * Scripts/webkitpy/committers.py:
1676
1677 2010-02-09  Yael Aharon  <yael.aharon@nokia.com>
1678
1679         Reviewed by Kenneth Rohde Christiansen.
1680
1681         [Qt] Webkit in Qt does not have window.showModalDialog
1682         https://bugs.webkit.org/show_bug.cgi?id=25585
1683
1684         Set the modality flag when createWindow is called with window type WebWindowDialog.
1685
1686         * QtLauncher/main.cpp:
1687         (WebPage::createWindow):
1688
1689 2010-02-09  Andras Becsi  <abecsi@webkit.org>
1690
1691         Unreviewed trivial warning fix.
1692
1693         * Scripts/build-webkit:
1694
1695 2010-02-09 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
1696
1697         Reviewed by Tor Arne Vestbø.
1698
1699         Add possibility of passing parameters to build-webkit by environment variable,
1700         because the buildbot slaves can't control the arguments.
1701
1702         * Scripts/build-webkit:
1703
1704 2010-02-09  Chang Shu  <Chang.Shu@nokia.com>
1705
1706         Reviewed by Laszlo Gombos.
1707
1708         [Qt] Enable appcache feature.
1709         https://bugs.webkit.org/show_bug.cgi?id=34713
1710
1711
1712         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1713         (WebCore::WebPage::WebPage):
1714         * DumpRenderTree/qt/main.cpp:
1715         (main):
1716
1717 2010-02-09  Shinichiro Hamaji  <hamaji@chromium.org>
1718
1719         Reviewed by Darin Adler.
1720
1721         Provide a way to get total number of pages to be printed
1722         https://bugs.webkit.org/show_bug.cgi?id=34699
1723
1724         * DumpRenderTree/LayoutTestController.cpp:
1725         (parsePageParameters):
1726         (pageNumberForElementByIdCallback):
1727         (numberOfPagesCallback):
1728         (LayoutTestController::staticFunctions):
1729         * DumpRenderTree/LayoutTestController.h:
1730         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1731         (LayoutTestController::numberOfPages):
1732         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1733         (LayoutTestController::numberOfPages):
1734         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1735         (LayoutTestController::numberOfPages):
1736
1737 2010-02-08  Alexey Proskuryakov  <ap@apple.com>
1738
1739         Reviewed by Darin Adler.
1740
1741         https://bugs.webkit.org/show_bug.cgi?id=34727
1742         Assertion crashes and freezes when plug-in property access results in an exception
1743
1744         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1745         (pluginGetProperty): Raise an exception when accessing a particular property.
1746         (pluginSetProperty): Ditto.
1747         (pluginInvoke): Added methods to get and set host object properties.
1748
1749 2010-02-08  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1750
1751         Reviewed by Ariya Hidayat.
1752
1753         [Qt] Backport No'am Rosenthal's frame rate measurement
1754
1755         * QtLauncher/main.cpp:
1756         (LauncherWindow::LauncherWindow):
1757         (LauncherApplication::handleUserOptions):
1758         * QtLauncher/webview.cpp:
1759         (WebViewGraphicsBased::WebViewGraphicsBased):
1760         (WebViewGraphicsBased::enableFrameRateMeasurement):
1761         (WebViewGraphicsBased::updateFrameRate):
1762         (WebViewGraphicsBased::paintEvent):
1763         * QtLauncher/webview.h:
1764
1765 2010-02-08  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1766
1767         Reviewed by Tor Arne Vestbø.
1768
1769         [Qt] Make overridePreference complain when it does not
1770         support the preference given.
1771
1772         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1773         (LayoutTestController::overridePreference):
1774
1775 2010-02-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1776
1777         Reviewed by Kenneth Rohde Christiansen.
1778
1779         [Qt] Set stdout/stderr to binary mode for DRT on Windows
1780
1781         This makes sure we don't end up with lots of CRLFs in the
1782         DRT output, which breaks tons of results. Matches what
1783         the Windows DRT does.
1784
1785         * DumpRenderTree/qt/main.cpp:
1786
1787 2010-02-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1788
1789         Reviewed by Kenneth Rohde Christiansen.
1790
1791         Build fix for Qt on Windows.
1792
1793         Don't use noreturn directly since it's a gcc attribute.
1794         Instead use the NO_RETURN macro from AlwaysInline.h
1795
1796         * QtLauncher/QtLauncher.pro:
1797         * QtLauncher/utils.h:
1798
1799 2010-02-05  Chris Jerdonek  <cjerdonek@webkit.org>
1800
1801         Reviewed by Shinichiro Hamaji.
1802
1803         Suppressed check-webkit-style's underscore check in Qt's autotests.
1804         Also made the path-specific filter check case-insensitive.
1805
1806         https://bugs.webkit.org/show_bug.cgi?id=34574
1807
1808         * Scripts/webkitpy/style/checker.py:
1809           - Added a list element to _PATH_RULES_SPECIFIER for
1810             directories that should be excluded from the
1811             "readability/naming" category (the category that relates to
1812             underscores in identifiers, for example).
1813
1814         * Scripts/webkitpy/style/checker_unittest.py:
1815           - Added an "end-to-end" test for "WebKit/qt/tests/".
1816
1817         * Scripts/webkitpy/style/filter.py:
1818           - Altered FilterConfiguration's should_check() method to
1819             check for path substring matches case-insensitively.
1820
1821         * Scripts/webkitpy/style/filter_unittest.py:
1822           - Added a test to check case-insensitive path substring matching.
1823
1824         * Scripts/webkitpy/style/processors/cpp.py:
1825           - Removed the hard-coded "WebKit/gtk/webkit/" path reference
1826             since this is now taken care of by the _PATH_RULES_SPECIFIER
1827             configuration variable.
1828
1829         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1830           - Removed the unit test for the GTK directory since this
1831             is now taken care of by the checker._PATH_RULES_SPECIFIER
1832             end-to-end tests.
1833
1834 2010-02-08  Leith Bade  <leith@leithalweapon.geek.nz>
1835
1836         Reviewed by Darin Adler.
1837
1838         Fixes: https://bugs.webkit.org/show_bug.cgi?id=34637
1839         Corrects the newline inserted into WebKitOutputDir, and WebKitLibrariesDir Windows
1840         environemnt variables when there is a space in the user's /home path.
1841
1842         * Scripts/webkitdirs.pm:
1843          - Added missing quotes around $sourceDir in argument list of cygpath in determineWindowsSourceDir().
1844
1845 2010-02-05  Alexey Proskuryakov  <ap@apple.com>
1846
1847         Reviewed by Oliver Hunt.
1848
1849         https://bugs.webkit.org/show_bug.cgi?id=34670
1850         TestNetscapePlugin should work with Firefox
1851
1852         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Default to Carbon if
1853         browser doesn't tell what it supports.
1854
1855 2010-02-05  Shinichiro Hamaji  <hamaji@chromium.org>
1856
1857         Reviewed by Gustavo Noronha Silva.
1858
1859         [Gtk] Implement layoutTestController.pageNumberForElementById
1860         https://bugs.webkit.org/show_bug.cgi?id=34572
1861
1862         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1863         (LayoutTestController::pageNumberForElementById):
1864
1865 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
1866
1867         Reviewed by Eric Seidel.
1868
1869         Add a simple test implementation and the WebKit Mac implementation
1870         for the layout_tests/port package. Also add a simple test driver of
1871         that interface.
1872
1873         https://bugs.webkit.org/show_bug.cgi?id=34511
1874
1875         * Scripts/webkitpy/layout_tests/driver_test.py: Added.
1876         * Scripts/webkitpy/layout_tests/port/__init__.py:
1877         * Scripts/webkitpy/layout_tests/port/mac.py: Added.
1878         * Scripts/webkitpy/layout_tests/port/test.py: Added.
1879
1880 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
1881
1882         Reviewed by Eric Siedel.
1883
1884         Refactor the port package into an object-oriented style and merge
1885         path_utils into it. We add a 'base' and a 'chromium' object to the
1886         port package; this will allow us to easily add new ports (like
1887         WebKit Mac).
1888
1889         https://bugs.webkit.org/show_bug.cgi?id=34511
1890
1891         * Scripts/rebaseline-chromium-webkit-tests:
1892         * Scripts/run-chromium-webkit-tests:
1893         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1894         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1895         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1896         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
1897         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
1898         * Scripts/webkitpy/layout_tests/port/__init__.py:
1899         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1900         * Scripts/webkitpy/layout_tests/port/base.py: Added.
1901         * Scripts/webkitpy/layout_tests/port/chromium.py: Added.
1902         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1903         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1904         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1905         * Scripts/webkitpy/layout_tests/port/http_server.py:
1906         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1907         * Scripts/webkitpy/layout_tests/port/path_utils.py: Removed.
1908         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1909         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1910         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
1911         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
1912         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1913         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1914         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1915
1916 2010-01-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1917
1918         Reviewed by Dave Hyatt.
1919
1920         Implement flattening of framesets
1921         https://bugs.webkit.org/show_bug.cgi?id=32717
1922
1923         Add support for testing frame flattening with the Qt DRT
1924
1925         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1926         (LayoutTestController::setFrameSetFlatteningEnabled):
1927         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1928
1929 2010-02-03  Chris Jerdonek  <cjerdonek@webkit.org>
1930
1931         Reviewed by Shinichiro Hamaji.
1932
1933         Provided a way in check-webkit-style to specify filter rules
1934         on a per file or folder basis, via a configuration variable.
1935
1936         https://bugs.webkit.org/show_bug.cgi?id=33684
1937
1938         * Scripts/webkitpy/style/checker.py:
1939           - Added _PATH_RULES_SPECIFIER configuration variable.
1940           - In ProcessorOptions class--
1941             - Changed the CategoryFilter attribute to FilterConfiguration.
1942             - Added path parameter to is_reportable().
1943           - Renamed ArgumentDefaults filter_rules attribute to
1944             base_filter_rules.
1945           - Updated ArgumentPrinter class.
1946           - Added filter rule validation to ArgumentParser (instead of
1947             in CategoryFilter constructor).
1948
1949         * Scripts/webkitpy/style/checker_unittest.py:
1950           - Updated unit tests as necessary.
1951           - Added unit tests for PATH_RULES_SPECIFIER.
1952
1953         * Scripts/webkitpy/style/error_handlers.py:
1954           - Updated DefaultStyleErrorHandler to use file path when
1955             calling is_reportable().
1956
1957         * Scripts/webkitpy/style/error_handlers_unittest.py:
1958           - Updated unit tests as necessary.
1959
1960         * Scripts/webkitpy/style/filter.py:
1961           - Marked CategoryFilter internal with an underscore.
1962           - Removed argument validation from CategoryFilter.
1963           - Added FilterConfiguration class.
1964
1965         * Scripts/webkitpy/style/filter_unittest.py:
1966           - Updated CategoryFilterTest class.
1967           - Added FilterConfigurationTest unit tests.
1968
1969         * Scripts/webkitpy/style/processors/cpp.py:
1970           - Removed _is_test_filename() code.
1971           - Removed hard-coded path checks from check_include_line().
1972
1973         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1974           - Removed three unit tests related to exempted files.
1975
1976 2010-02-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1977
1978         Reviewed by Ariya Hidayat.
1979
1980         [Qt] Apply the command line options as settings to the
1981         graphics system.
1982
1983         * QtLauncher/main.cpp:
1984         (LauncherWindow::LauncherWindow):
1985         (requiresGraphicsView):
1986         (LauncherApplication::handleUserOptions):
1987         * QtLauncher/webview.h:
1988         (WebViewGraphicsBased::setItemCacheMode):
1989
1990 2010-02-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1991
1992         Reviewed by Simon Hausmann.
1993
1994         Notify user that run-webkit-tests has to be run under Cygwin
1995
1996         The script will bail out if run under Windows shell or Msys.
1997
1998         * Scripts/run-webkit-tests:
1999         * Scripts/webkitdirs.pm:
2000
2001 2010-02-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2002
2003         Reviewed by Simon Hausmann.
2004
2005         [Qt] Generate convenience headers (QWebView, etc) using qmake
2006
2007         In Qt this is done using syncqt, but we use a pro-file instead
2008         that generates makefile-rules for each of the extra headers.
2009
2010         These extra headers are installed alongside the normal headers.
2011
2012         * Scripts/webkitdirs.pm: Run qmake and make on new API-DerivedSources
2013
2014 2010-02-05  Andras Becsi  <abecsi@webkit.org>
2015
2016         Unreviewed typo fix.
2017
2018         Fix wrong whitespace alignment introduced in r54342.
2019
2020         * Scripts/run-webkit-tests:
2021
2022 2010-02-04  Mark Rowe  <mrowe@apple.com>
2023
2024         Reviewed by Timothy Hatcher.
2025
2026         Build fix.  Remove a symbol corresponding to an inline function from the linker export
2027         file to prevent a weak external failure.
2028
2029         * Scripts/check-for-weak-vtables-and-externals: Renamed from WebKitTools/Scripts/check-for-weak-vtables.
2030         Teach the script how to detect weak external symbols so that these errors can be caught immediately
2031         in the future.
2032
2033 2010-02-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2034
2035         Rubberstamped by Oliver Hunt.
2036
2037         [Qt] Make it possible to choose whether the launcher should
2038         use the traditional QWidget based QWebView or the newer
2039         QGraphics based QGraphicsWebView on a QGraphicsView.
2040
2041         * QtLauncher/main.cpp:
2042         (LauncherWindow::LauncherWindow):
2043         (LauncherWindow::eventFilter):
2044         (LauncherWindow::loadStarted):
2045         (LauncherWindow::print):
2046         (LauncherWindow::screenshot):
2047         (LauncherWindow::setEditable):
2048         (LauncherWindow::setupUI):
2049         (main):
2050         * QtLauncher/webview.cpp:
2051         (WebViewGraphicsBased::WebViewGraphicsBased):
2052         (WebViewGraphicsBased::resizeEvent):
2053         (GraphicsWebView::mousePressEvent):
2054         (GraphicsWebView::contextMenuEvent):
2055         * QtLauncher/webview.h:
2056         (WebViewTraditional::WebViewTraditional):
2057         (GraphicsWebView::GraphicsWebView):
2058         (WebViewGraphicsBased::setPage):
2059
2060 2010-02-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2061
2062         Rubberstamped by Oliver Hunt.
2063
2064         [Qt] QtLauncher cleanup.
2065
2066         Refactor option handling out in utility functions and make the
2067         arguments more Qt compatible.
2068
2069         * QtLauncher/main.cpp:
2070         (requiresGraphicsView):
2071         (LauncherApplication::handleUserOptions):
2072         * QtLauncher/utils.cpp:
2073         (takeOptionValue):
2074         (formatKeys):
2075         (enumToKeys):
2076         (appQuit):
2077         * QtLauncher/utils.h:
2078
2079 2010-02-04  Andras Becsi  <abecsi@inf.u-szeged.hu>
2080
2081         Reviewed by Tor Arne Vestbø.
2082
2083         Implement a locking and scheduling mechanism for http testing sessions to be able
2084         to run multiple instances of run-webkit-tests parallel on the same machine.
2085         If a test session wants to run http tests and this feature is enabled, the pending
2086         sessions create lockfiles with sequential lock numbers. These locks are used to schedule
2087         the running test sessions in first come first served order. An exclusive lock ensures
2088         that the lock numbers are sequential to avoid deadlocks and starvation.
2089         Because the buildbot master specifies the flags used by slaves we need an environment
2090         variable too to be able to use the feature per-slave.
2091         Exporting WEBKIT_WAIT_FOR_HTTPD=1 before testing or using the --wait-for-httpd
2092         flag enables this feature, otherwise this patch has no effect on the testing whatsoever.
2093
2094         https://bugs.webkit.org/show_bug.cgi?id=33153
2095
2096         * Scripts/run-webkit-tests:
2097         * Scripts/webkitperl/httpd.pm:
2098
2099 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2100
2101         Reviewed by Simon Hausmann.
2102
2103         Make run-webkit-tests work under Cygwin for the Qt port
2104
2105         setPathForRunningWebKitApp() is implemented for the Qt port
2106         by using qmake to query for the location of the Qt libraries.
2107
2108         This requires the original environment (%ENV) to be untouched,
2109         so launchWithCurrentEnv() was refactored to launchWithEnv(),
2110         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
2111         instead. This has the added benefit of getting rid of the temp
2112         variables used for storing the current env.
2113
2114         openDumpTool() is also refactored a bit into platform-spesific,
2115         port-spesific, and generic environment variables.
2116
2117         Checks for undef was added a few places to fix Perl concat
2118         warnings when run-webkit-tests is aborted.
2119
2120         https://bugs.webkit.org/show_bug.cgi?id=33895
2121
2122         * Scripts/run-webkit-tests:
2123         * Scripts/webkitdirs.pm:
2124
2125 2010-02-04  Yuzo Fujishima  <yuzo@google.com>
2126
2127         Unreviewed.
2128
2129         Add Yuzo to the committers list.
2130
2131         * Scripts/webkitpy/committers.py:
2132
2133 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
2134
2135         Rubber-stamped by Eric Seidel.
2136
2137         Change "the Chromium name" to "the name of Google Inc." in the licenses
2138
2139         https://bugs.webkit.org/show_bug.cgi?id=34511
2140
2141         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2142         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2143         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2144         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2145         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2146         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
2147         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
2148         * Scripts/webkitpy/layout_tests/port/__init__.py:
2149         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2150         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2151         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2152         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2153         * Scripts/webkitpy/layout_tests/port/http_server.py:
2154         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2155         * Scripts/webkitpy/layout_tests/port/path_utils.py:
2156         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2157         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2158         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
2159         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
2160         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2161         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2162         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2163
2164 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
2165
2166         Rubber-stamped by Eric Siedel.
2167
2168         Rename files as part of refactoring the layout_tests package. All
2169         the platform_utils* module, the path_utils.py module, and
2170         the http server and web socket server modules are moved into a new
2171         port/ package.
2172
2173         https://bugs.webkit.org/show_bug.cgi?id=34511
2174
2175         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Removed.
2176         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Removed.
2177         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Removed.
2178         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Removed.
2179         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2180         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2181         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Removed.
2182         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Removed.
2183         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Removed.
2184         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Removed.
2185         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Removed.
2186         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Removed.
2187         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2188         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
2189         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
2190         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Removed.
2191         * Scripts/webkitpy/layout_tests/port: Added.
2192         * Scripts/webkitpy/layout_tests/port/__init__.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils.py.
2193         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py.
2194         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py.
2195         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py.
2196         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py.
2197         * Scripts/webkitpy/layout_tests/port/http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server.py.
2198         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server_base.py.
2199         * Scripts/webkitpy/layout_tests/port/httpd2.pem: Copied from Scripts/webkitpy/layout_tests/layout_package/httpd2.pem.
2200         * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Copied from Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf.
2201         * Scripts/webkitpy/layout_tests/port/path_utils.py: Copied from Scripts/webkitpy/layout_tests/layout_package/path_utils.py.
2202         * Scripts/webkitpy/layout_tests/port/websocket_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/websocket_server.py.
2203         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2204         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
2205         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
2206         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2207         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2208         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2209
2210
2211 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
2212
2213         Rubber-stamped by Eric Seidel.
2214
2215         Roll back r53559 and r54084 again, because roll out didn't solve flakeyness on the Windows Test bots
2216         https://bugs.webkit.org/show_bug.cgi?id=34399
2217
2218         * Scripts/run-iexploder-tests:
2219         * Scripts/run-webkit-httpd:
2220         * Scripts/run-webkit-tests:
2221         * Scripts/webkitperl/httpd.pm: Added.
2222
2223 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
2224
2225         Rubber-stamped by Eric Seidel.
2226
2227         Roll out r53559 and r54084, because it might caused flakeyness on the Windows Test bots
2228
2229         * Scripts/run-iexploder-tests:
2230         * Scripts/run-webkit-httpd:
2231         * Scripts/run-webkit-tests:
2232         * Scripts/webkitperl/httpd.pm: Removed.
2233
2234 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
2235
2236         Rubber-stamped by Ariya Hidayat.
2237
2238         Roll back r53889 again, because roll out didn't solve flakeyness on the Windows Test bots
2239         https://bugs.webkit.org/show_bug.cgi?id=34399
2240
2241         * DumpRenderTree/win/EventSender.cpp:
2242         (buildModifierFlags):
2243         (mouseDownCallback):
2244         (mouseUpCallback):
2245         (keyDownCallback):
2246
2247 2010-02-03  Eric Seidel  <eric@webkit.org>
2248
2249         No review, just fixing copyrights.
2250
2251         Concerns were expressed about "The Chromium Authors" being
2252         a valid legal entity for copyright assignment in the WebKit repository,
2253         so this change removes all "The Chromium Authors".
2254
2255         I looked at the svn logs in src.chromium.org and failed to find any
2256         non-google contributions to these files, so they are all now
2257         marked as copyright "Google Inc" as all Google contributers assign
2258         copyright to "Google Inc" as part of their employment agreement.
2259
2260         * Scripts/rebaseline-chromium-webkit-tests:
2261         * Scripts/run-chromium-webkit-tests:
2262         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py:
2263         * Scripts/webkitpy/layout_tests/layout_package/http_server.py:
2264         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py:
2265         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2266         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2267         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2268         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py:
2269         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py:
2270         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py:
2271         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py:
2272         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py:
2273         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2274         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2275         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
2276         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
2277         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py:
2278         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2279         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
2280         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
2281         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2282         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2283         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2284
2285 2010-02-03  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2286
2287         Reviewed by Ariya Hidayat.
2288
2289         [Qt] QtLauncher, refactor argument handling in preparation of merge
2290         with QGVLauncher
2291
2292         * QtLauncher/main.cpp:
2293         (LauncherApplication::urls):
2294         (LauncherApplication::isRobotized):
2295         (LauncherApplication::applyDefaultSettings):
2296         (LauncherApplication::LauncherApplication):
2297         (LauncherApplication::formatKeys):
2298         (LauncherApplication::enumToKeys):
2299         (fail):
2300         (LauncherApplication::handleUserOptions):
2301         (main):
2302
2303 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
2304
2305         Rubber-stamped by Ariya Hidayat.
2306
2307         Rolling out r53889, because it might caused flakeyness on the Windows Test bots
2308         https://bugs.webkit.org/show_bug.cgi?id=34399
2309
2310         * DumpRenderTree/win/EventSender.cpp:
2311         (mouseDownCallback):
2312         (mouseUpCallback):
2313         (keyDownCallback):
2314
2315 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
2316
2317         Reviewed by Ariya Hidayat.
2318
2319         [Qt] Fix pixel tests support.
2320         https://bugs.webkit.org/show_bug.cgi?id=27813
2321
2322         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2323         (WebCore::DumpRenderTree::open):
2324         (WebCore::DumpRenderTree::processLine):
2325          - Hash processing mechanism moved from DumpRenderTree::open to DumpRenderTree::processLine.
2326         (WebCore::DumpRenderTree::dump): Fixed and renamed variables.
2327
2328 2010-02-03  Kevin Watters  <kevinwatters@gmail.com>
2329
2330         Reviewed by Kevin Ollivier.
2331
2332         [wx] Enable JIT compilation for wx.
2333         
2334         https://bugs.webkit.org/show_bug.cgi?id=34536
2335
2336         * wx/build/settings.py:
2337
2338 2010-02-02  Kevin Ollivier  <kevino@theolliviers.com>
2339
2340         [wx] Build fix after introduction of pageNumberForElementById.
2341
2342         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2343         (LayoutTestController::pageNumberForElementById):
2344
2345 2010-02-02  Shu Chang  <Chang.Shu@nokia.com>
2346
2347         Unreviewed.
2348
2349         Add myself to list of committers.
2350
2351         * Scripts/webkitpy/committers.py:
2352
2353 2010-02-02  Chris Jerdonek  <cjerdonek@webkit.org>
2354
2355         Reviewed by Shinichiro Hamaji.
2356
2357         Moved filter-related check-webkit-style code into a separate
2358         filter module.
2359
2360         https://bugs.webkit.org/show_bug.cgi?id=34408
2361
2362         This is preparatory refactoring for Bug 33684, which will allow
2363         file and folder-specific filter rules.
2364
2365         * Scripts/webkitpy/style/checker.py:
2366           - Removed CategoryFilter class (moved to filter.py).
2367
2368         * Scripts/webkitpy/style/checker_unittest.py:
2369           - Removed CategoryFilter unit tests (moved to filter_unittest.py).
2370
2371         * Scripts/webkitpy/style/filter.py: Added.
2372           - Added CategoryFilter class (moved from checker.py).
2373
2374         * Scripts/webkitpy/style/filter_unittest.py: Added.
2375           - Added CategoryFilter unit tests (moved from checker_unittest.py).
2376
2377         * Scripts/webkitpy/style/unittests.py:
2378           - Added reference to filter_unittest.py.
2379
2380 2010-02-01  Chris Jerdonek  <cjerdonek@webkit.org>
2381
2382         Reviewed by Shinichiro Hamaji.
2383
2384         Addressed FIXME in check-webkit-style so that the carriage-return
2385         check will work for patches.
2386
2387         https://bugs.webkit.org/show_bug.cgi?id=34260
2388
2389         Also added support for limiting the number of errors reported
2390         per category, per file.
2391
2392         * Scripts/webkitpy/style/checker.py:
2393           - Added new "whitespace/carriage_return" category from common.py.
2394           - Added MAX_REPORTS_PER_CATEGORY dictionary.
2395           - Added max_reports_per_category attribute to ProcessorOptions class.
2396           - Refactored StyleChecker._process_file().
2397
2398         * Scripts/webkitpy/style/checker_unittest.py:
2399           - Updated ProcessorOptionsTest tests.
2400           - Added test to check MAX_REPORTS_PER_CATEGORY.
2401
2402         * Scripts/webkitpy/style/error_handlers.py:
2403           - Added support for suppressing the display of errors after
2404             reaching a per-category maximum (from max_reports_per_category).
2405
2406         * Scripts/webkitpy/style/error_handlers_unittest.py:
2407           - Added test for suppressing error display.
2408
2409         * Scripts/webkitpy/style/processors/common.py: Added.
2410           - Moved carriage-return check to new file.
2411
2412         * Scripts/webkitpy/style/processors/common_unittest.py: Added.
2413           - Added unit tests for carriage-return check.
2414
2415         * Scripts/webkitpy/style/unittests.py:
2416           - Added reference to common_unittest.py.
2417
2418 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
2419
2420         Reviewed by Eric Seidel.
2421
2422         Provide a way to get page number with layoutTestController
2423         https://bugs.webkit.org/show_bug.cgi?id=33840
2424
2425         * DumpRenderTree/LayoutTestController.cpp:
2426         (pageNumberForElementByIdCallback):
2427         (LayoutTestController::staticFunctions):
2428         * DumpRenderTree/LayoutTestController.h:
2429         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2430         (LayoutTestController::pageNumberForElementById):
2431         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2432         (LayoutTestController::pageNumberForElementById):
2433         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2434         (LayoutTestController::pageNumberForElementById):
2435
2436 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
2437
2438         Unreviewed fix for an invalid function call.
2439
2440         check-webkit-style: Remove filename parameter from all functions where no longer used
2441         https://bugs.webkit.org/show_bug.cgi?id=34249
2442
2443         * Scripts/webkitpy/style/checker.py:
2444
2445 2010-02-01  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2446
2447         Reviewed by Kenneth Rohde Christiansen.
2448
2449         [Qt] DRT Provide global flag ability
2450         https://bugs.webkit.org/show_bug.cgi?id=34418
2451
2452         Add the globalFlag property to the Qt LayoutTestController to allow
2453         cross-domain indications.
2454
2455         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2456         (LayoutTestController::reset):
2457         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2458         (LayoutTestController::globalFlag):
2459         (LayoutTestController::setGlobalFlag):
2460
2461 2010-02-01  Brady Eidson  <beidson@apple.com>
2462
2463         Reviewed by Adele Peterson.
2464
2465         Crash in Safari opening new tabs to "same page"
2466         <rdar://problem/7593857> and https://bugs.webkit.org/show_bug.cgi?id=34444
2467
2468         Add a mode (Mac-only for now) that exercises the WebView SPI _loadBackForwardListFromOtherView:
2469
2470         * DumpRenderTree/LayoutTestController.cpp:
2471         (LayoutTestController::LayoutTestController):
2472         (setNewWindowsCopyBackForwardListCallback):
2473         (LayoutTestController::staticFunctions):
2474
2475         * DumpRenderTree/LayoutTestController.h:
2476         (LayoutTestController::newWindowsCopyBackForwardList):
2477         (LayoutTestController::setNewWindowsCopyBackForwardList):
2478
2479         * DumpRenderTree/mac/UIDelegate.mm:
2480         (-[UIDelegate webView:createWebViewWithRequest:]):
2481
2482 2010-02-01  Carol Szabo  <carol.szabo@nokia.com>
2483
2484         Unreviewed.
2485
2486         Add myself to list of committers.
2487
2488         * Scripts/webkitpy/committers.py:
2489
2490 2010-02-01  Nate Chapin  <japhet@chromium.org>
2491
2492         Rubber-stamped by David Levin.
2493
2494         Add myself to reviewer list.
2495
2496         * Scripts/webkitpy/committers.py:
2497
2498 2010-01-31  Chris Jerdonek  <cjerdonek@webkit.org>
2499
2500         Reviewed by Shinichiro Hamaji.
2501
2502         Moved style error handler code to their own classes, and
2503         related refactoring. Increased unit test code coverage of
2504         style error handling.
2505
2506         https://bugs.webkit.org/show_bug.cgi?id=34379
2507
2508         * Scripts/check-webkit-style:
2509           - Minor change: added error_count variable.
2510
2511         * Scripts/webkitpy/style/checker.py:
2512           - Renamed ProcessorOptions.should_report_error() to is_reportable().
2513           - In the StyleChecker class--
2514             - Removed _default_style_error_handler().
2515             - Added _increment_error_count().
2516             - Refactored to use DefaultStyleErrorHandler and
2517               PatchStyleErrorHandler constructors.
2518
2519         * Scripts/webkitpy/style/checker_unittest.py:
2520           - In the StyleStyleCheckerTest class--
2521             - Removed write_sample_error().
2522             - Removed test_default_style_error_handler().
2523
2524         * Scripts/webkitpy/style/error_handlers.py: Added.
2525           - Added DefaultStyleErrorHandler class.
2526           - Added PatchStyleErrorHandler class.
2527
2528         * Scripts/webkitpy/style/error_handlers_unittest.py: Added.
2529           - Added unit tests for DefaultStyleErrorHandler and
2530             PatchStyleErrorHandler.
2531
2532         * Scripts/webkitpy/style/unittests.py:
2533           - Added error_handlers unit tests.
2534
2535 2010-01-29  Mark Rowe  <mrowe@apple.com>
2536
2537         Rubber-stamped by Stephanie Lewis.
2538
2539         Fix run-leaks with newer versions of the leaks tool.
2540
2541         * Scripts/run-leaks:
2542
2543 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
2544
2545         Reviewed by Eric Siedel.
2546
2547         Top-level test drivers for running the Chromium port of run-webkit-tests
2548         and being able to rebaseline test results from the test bots.  The
2549         files in the Scripts directory are simply wrappers around the files
2550         in webkitpy/layout_tests for convenience.
2551  
2552         https://bugs.webkit.org/show_bug.cgi?id=31498
2553
2554         * Scripts/rebaseline-chromium-webkit-tests: Added.
2555         * Scripts/run-chromium-webkit-tests: Added.
2556         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Added.
2557         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: Added.
2558
2559 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
2560
2561         Reviewed by Eric Siedel.
2562
2563         Add in the second block of python code for the Chromium port
2564         of run-webkit-tests. These files execute different diffs to classify
2565         the various types of failures from a test.
2566
2567         * Scripts/webkitpy/layout_tests/test_types: Added.
2568         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Added.
2569         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Added.
2570         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Added.
2571         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Added.
2572         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Added.
2573
2574 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
2575
2576         Reviewed by Eric Siedel.
2577
2578         Check in the first part of the Chromium Python port of the 
2579         run-webkit-tests test driver. The files under 
2580         layout_tests/layout_layout constitute most of the implementation;
2581         they can be roughly divided into code that parses the 
2582         "test_expectations.txt" file that describes how we expect tests to
2583         pass or fail, platform-specific hooks for the different Chromium 
2584         ports (in platform_utils*), code for parsing the output of the
2585         tests and generating results files and HTML and JSON for the
2586         dashboards, auxiliary scripts for starting and stopping HTTP and
2587         Web Socket servers, and then one of the actual driver files 
2588         (test_shell_thread). Code for actually parsing test output for 
2589         failures and the top-level driver scripts will follow shortly.
2590
2591         https://bugs.webkit.org/show_bug.cgi?id=31498
2592
2593         * Scripts/webkitpy/layout_tests: Added.
2594         * Scripts/webkitpy/layout_tests/layout_package: Added.
2595         * Scripts/webkitpy/layout_tests/layout_package/__init__.py: Added.
2596         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Added.
2597         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Added.
2598         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Added.
2599         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Added.
2600           - scripts to start and stop apache. Note that the apache file
2601             generates a conf file dynamically, and we should switch to 
2602             using the same static conf file that the regular run-webkit-tests
2603             uses, and we can also use the same httpd2.pem file.
2604
2605         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Added.
2606         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Added.
2607           - scripts to generate the JSON layout test dashboard and the
2608             flakiness dashboard
2609         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Added.
2610           - default configuration for LigHTTPd (used on Windows)
2611         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Added.
2612           - utility class that implements progress bars on the console to
2613             be displayed while the tests are running
2614         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Added.
2615           - various routines for manipulating paths and URIs
2616         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Added.
2617         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Added.
2618         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Added.
2619         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Added.
2620           - platform-specific aspects of the drivers (binary names, paths,
2621             process control, etc.)
2622         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Added.
2623           - code for parsing the 'test_expectations.txt' file to determine
2624             which tests are expected to fail (and how) on which platforms
2625         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Added.
2626           - code for handling different kinds of failures (generating output
2627             in the results, etc.)
2628         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Added.
2629           - code to gather the lists of tests
2630         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Added.
2631           - code to actually execute tests via TestShell and process
2632             the output
2633         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Added.
2634           - scripts to start and stop the pywebsocket server
2635
2636 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
2637
2638         Reviewed by Eric Seidel.
2639
2640         Check in a copy of the simplejson library; it will be used by
2641         the Chromium port of run-webkit-tests.
2642         
2643         https://bugs.webkit.org/show_bug.cgi?id=31498
2644
2645         * simplejson: Added.
2646         * simplejson/LICENSE.txt: Added.
2647         * simplejson/README.txt: Added.
2648         * simplejson/__init__.py: Added.
2649         * simplejson/_speedups.c: Added.
2650         (ascii_escape_char):
2651         (ascii_escape_unicode):
2652         (ascii_escape_str):
2653         (py_encode_basestring_ascii):
2654         (init_speedups):
2655         * simplejson/decoder.py: Added.
2656         * simplejson/encoder.py: Added.
2657         * simplejson/jsonfilter.py: Added.
2658         * simplejson/scanner.py: Added.
2659
2660 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
2661
2662         No review
2663
2664         Add myself to the committers list
2665
2666         * Scripts/webkitpy/committers.py:
2667
2668 2010-01-29  Jeremy Orlow  <jorlow@chromium.org>
2669
2670         Reviewed by Dimitri Glazkov.
2671
2672         A first step towards the Indexed Database API
2673         https://bugs.webkit.org/show_bug.cgi?id=34342
2674
2675         Add indexed database API.
2676
2677         * Scripts/build-webkit:
2678
2679 2010-01-29  Andras Becsi  <abecsi@webkit.org>
2680
2681         Reviewed by Alexey Proskuryakov.
2682
2683         Correct openHTTPD() to print requests to stdout if run-webkit-httpd is used.
2684         This fixes a regression introduced in r53559.
2685
2686         https://bugs.webkit.org/show_bug.cgi?id=34336
2687
2688         * Scripts/webkitperl/httpd.pm:
2689
2690 2010-01-28  Jon Honeycutt  <jhoneycutt@apple.com>
2691
2692         MSAA: Crash when posting a notification for a detached object
2693
2694         https://bugs.webkit.org/show_bug.cgi?id=34309
2695         <rdar://problem/7409759>
2696
2697         Reviewed by Darin Adler.
2698
2699         * DumpRenderTree/AccessibilityController.h:
2700         Declare new functions. Add new members to store the event hook and the
2701         mapping of accessibility elements to their JS callbacks.
2702
2703         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2704         (AccessibilityController::notificationReceived):
2705         Stubbed.
2706         (AccessibilityController::addNotificationListener):
2707         Stubbed.
2708
2709         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2710         (AccessibilityController::notificationReceived):
2711         Stubbed.
2712         (AccessibilityController::addNotificationListener):
2713         Stubbed.
2714
2715         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2716         (AccessibilityController::AccessibilityController):
2717         Initialize the event hook.
2718         (AccessibilityController::~AccessibilityController):
2719         Remove the event hook. Unprotect all of the JS functions that are stored
2720         in the map.
2721         (logEventProc):
2722         Clean-up a variable.
2723         (stringEvent):
2724         Return a string description of the MSAA event code.
2725         (notificationListenerProc):
2726         Get the accessible object from the event, and query it for IAccessible.
2727         Call the AccessibilityController's notificationReceived().
2728         (comparableObject):
2729         Use QueryService to obtain the IAccessibleComparable for the
2730         IServiceProvider.
2731         (AccessibilityController::notificationReceived):
2732         Iterate the map of objects that have registered for notification
2733         callbacks. Query each for IServiceProvider, then use comparableObject()
2734         to get an IAccessibleComparable. If we find an object matching the
2735         notified object, call its callback, passing the event that was received.
2736         (AccessibilityController::addNotificationListener):
2737         If we have not created the event hook, create it. Protect the JS
2738         callback function object, and add the object and its callback to our
2739         map.
2740
2741         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2742         (AccessibilityUIElement::addNotificationListener):
2743         Call through to the AccessibilityController's addNotificationListener().
2744
2745         * DumpRenderTree/win/DumpRenderTreeWin.h:
2746         Add an extern declaration for the shared FrameLoadDelegate extern, so we
2747         can access it from AccessibilityController.
2748
2749         * DumpRenderTree/win/FrameLoadDelegate.h:
2750         (FrameLoadDelegate::accessibilityController):
2751         Return the AccessibilityController.
2752
2753 2010-01-29  Shinichiro Hamaji  <hamaji@chromium.org>
2754
2755         Reviewed by Darin Adler.
2756
2757         prepare-ChangeLog outputs useless messages for a nonexistent bug ID
2758         https://bugs.webkit.org/show_bug.cgi?id=34313
2759
2760         * Scripts/prepare-ChangeLog:
2761
2762 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2763
2764         Rubberstamped by Simon Hausmann.
2765
2766         [Qt] Separate implementation from class definition.
2767
2768         * QtLauncher/main.cpp:
2769         (LauncherWindow::webView):
2770         (LauncherWindow::LauncherWindow):
2771         (LauncherWindow::~LauncherWindow):
2772         (LauncherWindow::keyPressEvent):
2773         (LauncherWindow::grabZoomKeys):
2774         (LauncherWindow::sendTouchEvent):
2775         (LauncherWindow::eventFilter):
2776         (LauncherWindow::loadStarted):
2777         (LauncherWindow::loadFinished):
2778         (LauncherWindow::showLinkHover):
2779         (LauncherWindow::zoomIn):
2780         (LauncherWindow::zoomOut):
2781         (LauncherWindow::resetZoom):
2782         (LauncherWindow::toggleZoomTextOnly):
2783         (LauncherWindow::print):
2784         (LauncherWindow::screenshot):
2785         (LauncherWindow::setEditable):
2786         (LauncherWindow::dumpHtml):
2787         (LauncherWindow::selectElements):
2788         (LauncherWindow::setTouchMocking):
2789         (LauncherWindow::newWindow):
2790         (LauncherWindow::setupUI):
2791
2792 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2793
2794         Reviewed by Ariya Hidayat.
2795
2796         [Qt] On Maemo5, a click/touch in the location bar (when unfocused)
2797         should result in all text selected.
2798
2799         * QtLauncher/locationedit.cpp:
2800         (LocationEdit::focusInEvent):
2801         * QtLauncher/locationedit.h:
2802
2803 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2804
2805         Reviewed by Ariya Hidayat.
2806
2807         [Qt] Show progress reaching 100% for loads.
2808
2809         * QtLauncher/locationedit.cpp:
2810         (LocationEdit::LocationEdit):
2811         (LocationEdit::setProgress):
2812         (LocationEdit::reset):
2813         (LocationEdit::paintEvent):
2814         * QtLauncher/locationedit.h:
2815
2816 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
2817
2818         Reviewed by Kenneth Rohde Christiansen.
2819
2820         [Qt] Disable the QtLauncher statusbar on Maemo
2821
2822         https://bugs.webkit.org/show_bug.cgi?id=34330
2823
2824         * QtLauncher/main.cpp:
2825         (LauncherWindow::showLinkHover):
2826         (LauncherWindow::selectElements):
2827
2828 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
2829
2830         Reviewed by Kenneth Rohde Christiansen.
2831
2832         [Qt] Display page loading progress inside the QtLauncher location bar
2833
2834         https://bugs.webkit.org/show_bug.cgi?id=34210
2835
2836         * QtLauncher/QtLauncher.pro:
2837         * QtLauncher/locationedit.cpp: Added.
2838         (LocationEdit::LocationEdit):
2839         (LocationEdit::setProgress):
2840         (LocationEdit::paintEvent):
2841         * QtLauncher/locationedit.h: Added.
2842         * QtLauncher/mainwindow.cpp:
2843         (MainWindow::buildUI):
2844         * QtLauncher/mainwindow.h:
2845
2846 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
2847
2848         Reviewed by Kenneth Rohde Christiansen.
2849
2850         [Qt] Add support for Maemo zoom keys in QtLauncher
2851
2852         https://bugs.webkit.org/show_bug.cgi?id=34160
2853
2854         * QtLauncher/main.cpp:
2855         (LauncherWindow::LauncherWindow):
2856         (LauncherWindow::~LauncherWindow):
2857         (LauncherWindow::keyPressEvent):
2858         (LauncherWindow::grabZoomKeys):
2859
2860 2010-01-29  Benjamin Poulain  <benjamin.poulain@nokia.com>
2861
2862         Reviewed by Kenneth Rohde Christiansen.
2863
2864         [Qt] Implement the display() method of the layout test controller
2865         https://bugs.webkit.org/show_bug.cgi?id=34258
2866
2867         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2868         (WebCore::DumpRenderTree::DumpRenderTree):
2869         (WebCore::DumpRenderTree::showPage):
2870         (WebCore::DumpRenderTree::hidePage):
2871         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2872         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2873         (LayoutTestController::reset):
2874         (LayoutTestController::display):
2875         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2876
2877 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
2878
2879         [wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation
2880         implements pthread_t in a way that makes it impossible to check its validity,
2881         which is needed by ThreadingPthreads.cpp.
2882
2883         * DumpRenderTree/wscript:
2884         * wx/build/settings.py:
2885
2886 2010-01-28  Andras Becsi  <abecsi@webkit.org>
2887
2888         Adding myself to the committer list. No review needed.
2889
2890         * Scripts/webkitpy/committers.py:
2891
2892 2010-01-28  Hayato Ito  <hayato@chromium.org>
2893
2894         Reviewed by David Levin.
2895
2896         Remove NULL char from input JS file because 'grep' fails if the file contains NULL char.
2897
2898         https://bugs.webkit.org/show_bug.cgi?id=34252
2899
2900         * Scripts/make-script-test-wrappers:
2901
2902 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
2903
2904         [wx] Build fix after removal of the zlib image decoder.
2905
2906         * wx/build/settings.py:
2907
2908 2010-01-28  Csaba Osztrogonác  <ossy@webkit.org>
2909
2910         [Qt] Unreviewed, roll out r54000.
2911
2912         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2913         (WebCore::DumpRenderTree::DumpRenderTree):
2914         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2915         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2916         (LayoutTestController::reset):
2917         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2918         (LayoutTestController::display):
2919
2920 2010-01-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
2921
2922         Reviewed by Kenneth Rohde Christiansen.
2923
2924         [Qt] Implement the display() method of the layout test controller
2925         https://bugs.webkit.org/show_bug.cgi?id=34258
2926
2927         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2928         (WebCore::DumpRenderTree::DumpRenderTree):
2929         (WebCore::DumpRenderTree::showPage):
2930         (WebCore::DumpRenderTree::hidePage):
2931         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2932         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2933         (LayoutTestController::reset):
2934         (LayoutTestController::display):
2935         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2936
2937 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
2938
2939         Reviewed by Shinichiro Hamaji.
2940
2941         Eliminated the filename parameter from functions in
2942         check-webkit-style's cpp.py where it is no longer used.
2943
2944         https://bugs.webkit.org/show_bug.cgi?id=34249
2945
2946         * Scripts/webkitpy/style/processors/cpp.py:
2947           - Reduced number of occurrences of "filename" variable from
2948             approximately 200 to 120.
2949
2950         * Scripts/webkitpy/style/processors/cpp_unittest.py:
2951           - Refactored unit tests as necessary to accommodate changes to cpp.py.
2952           - Fixed bug in CppStyleTestBase.perform_include_what_you_use()
2953             where the incorrect file extension was getting passed to
2954             cpp_style.check_language().
2955
2956 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
2957
2958         Reviewed by Shinichiro Hamaji.
2959
2960         In check-webkit-style, eliminated the dependency of
2961         processors/cpp_unittest.py on checker.py.
2962
2963         https://bugs.webkit.org/show_bug.cgi?id=34205
2964
2965         * Scripts/webkitpy/style/checker.py:
2966           - Addressed FIXME by removing STYLE_CATEGORIES data.
2967           - Added style_categories().
2968
2969         * Scripts/webkitpy/style/checker_unittest.py:
2970           - Minor changes.
2971
2972         * Scripts/webkitpy/style/processors/cpp.py:
2973           - Added categories attribute to CppProcessor class (data
2974             was originally checker.STYLE_CATEGORIES).
2975
2976         * Scripts/webkitpy/style/processors/cpp_unittest.py:
2977           - Addressed FIXME by eliminating "import" from checker.py.
2978
2979 2010-01-28  Anton Muhin  <antonm@chromium.org>
2980
2981         Reviewed by Shinichiro Hamaji.
2982
2983         Improve treatment of conditions and rest of the line for if, else, switch and alikes
2984         https://bugs.webkit.org/show_bug.cgi?id=34173
2985
2986         * Scripts/webkitpy/style/cpp_style.py:
2987         * Scripts/webkitpy/style/cpp_style_unittest.py:
2988
2989 2010-01-28  Joe Mason  <jmason@rim.com>
2990
2991         Reviewed by Adam Barth.
2992
2993         Limit login retries to 5
2994         https://bugs.webkit.org/show_bug.cgi?id=34193
2995
2996         * Scripts/webkitpy/bugzilla.py:
2997
2998 2010-01-27  Martin Robinson  <mrobinson@webkit.org>
2999
3000         Adding myself to the committer list. No review necessary.
3001
3002         * Scripts/webkitpy/committers.py:
3003
3004 2010-01-27  George Wright  <gwright@rim.com>
3005
3006         Reviewed by Adam Treat.
3007
3008         https://bugs.webkit.org/show_bug.cgi?id=34216
3009
3010         Add missing include for wtf/Platform.h
3011
3012         * DumpRenderTree/AccessibilityController.h:
3013
3014 2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>
3015
3016         Reviewed by Kenneth Rohde Christiansen.
3017
3018         [Qt] DRT Provide worker thread ability to track counters
3019         https://bugs.webkit.org/show_bug.cgi?id=34221
3020
3021         Implement workerThreadCount() in LayoutTestController of Qt DRT
3022
3023         Tests:
3024         fast/workers/dedicated-worker-lifecycle.html
3025         fast/workers/shared-worker-frame-lifecycle.html
3026         fast/workers/shared-worker-lifecycle.html
3027         fast/workers/worker-lifecycle.html
3028
3029         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3030         (LayoutTestController::workerThreadCount):
3031         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3032
3033 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3034
3035         Rubberstamped by Simon Hausmann.
3036
3037         [Qt] QtLauncher refactoring:
3038
3039         Make the LauncherWindow depend less on the view, so that more
3040         code can be shared in near future.
3041
3042         * QtLauncher/main.cpp:
3043         (LauncherWindow::sendTouchEvent):
3044         (LauncherWindow::loadFinished):
3045         (LauncherWindow::zoomIn):
3046         (LauncherWindow::zoomOut):
3047         (LauncherWindow::resetZoom):
3048         (LauncherWindow::toggleZoomTextOnly):
3049         (LauncherWindow::dumpHtml):
3050         (LauncherWindow::selectElements):
3051         (LauncherWindow::setupUI):
3052
3053 2010-01-27  Kinuko Yasuda  <kinuko@chromium.org>
3054
3055         Reviewed by Eric Seidel.
3056
3057         Correctly handle the KeyLocation argument that has been introduced
3058         recently to test location-dependent key events in EventSender.keyDown.
3059         http://bugs.webkit.org/show_bug.cgi?id=28247
3060
3061         Test: fast/events/keydown-numpad-keys.html
3062
3063         * DumpRenderTree/gtk/EventSender.cpp:
3064         (keyDownCallback):
3065
3066 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3067
3068         Rubberstamped by Simon Hausmann.
3069
3070         [Qt] QtLauncher refactoring:
3071
3072         Move out code from the MainWindow (renamed to LauncherWindow)
3073         that is not depending on the view, and add it to a new class
3074         called MainWindow.
3075
3076         * QtLauncher/QtLauncher.pro:
3077         * QtLauncher/main.cpp:
3078         (LauncherWindow::LauncherWindow):
3079         (LauncherWindow::eventFilter):
3080         (LauncherWindow::loadStarted):
3081         (LauncherWindow::loadFinished):
3082         (LauncherWindow::newWindow):
3083         (LauncherWindow::setupUI):
3084         (WebPage::createWindow):
3085         (main):
3086         * QtLauncher/mainwindow.cpp: Added.
3087         (MainWindow::MainWindow):
3088         (MainWindow::buildUI):
3089         (MainWindow::page):
3090         (MainWindow::setAddressUrl):
3091         (MainWindow::addCompleterEntry):
3092         (MainWindow::load):
3093         (MainWindow::changeLocation):
3094         (MainWindow::openFile):
3095         * QtLauncher/mainwindow.h: Added.
3096
3097 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3098
3099         Rubberstamped by Simon Hausmann.
3100
3101         [Qt] QtLauncher, coding style fixes.
3102
3103         * QtLauncher/main.cpp:
3104         (MainWindow::MainWindow):
3105         (MainWindow::sendTouchEvent):
3106         (MainWindow::eventFilter):
3107         (MainWindow::loadURL):
3108         (MainWindow::setupUI):
3109         (WebPage::createPlugin):
3110
3111 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3112
3113         Rubberstamped by Simon Hausmann.
3114
3115         [Qt] QtLauncher refactoring, separating the webview and
3116         adding a QGraphicsWebView based version.
3117
3118         * QtLauncher/QtLauncher.pro:
3119         * QtLauncher/main.cpp:
3120         (MainWindow::MainWindow):
3121         * QtLauncher/webpage.h:
3122         * QtLauncher/webview.cpp: Added.
3123         (createContextMenu):
3124         (WebViewGraphicsBased::mousePressEvent):
3125         (WebViewTraditional::mousePressEvent):
3126         (WebViewGraphicsBased::contextMenuEvent):
3127         (WebViewTraditional::contextMenuEvent):
3128         * QtLauncher/webview.h: Added.
3129         (WebViewGraphicsBased::WebViewGraphicsBased):
3130         (WebViewTraditional::WebViewTraditional):
3131
3132 2010-01-27  Alexander Pavlov  <apavlov@chromium.org>
3133
3134         Adding myself as committer. No review necessary.
3135
3136         * Scripts/webkitpy/committers.py:
3137
3138 2010-01-27  Eric Seidel  <eric@webkit.org>
3139
3140         Reviewed by Darin Adler.
3141
3142         webkit-patch needs an open-bugs command
3143         https://bugs.webkit.org/show_bug.cgi?id=30793
3144
3145         * Scripts/test-webkitpy: import OpenBugsTest
3146         * Scripts/webkit-patch: import OpenBugs
3147         * Scripts/webkitpy/commands/download_unittest.py: don't import unittest
3148         * Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto
3149         * Scripts/webkitpy/commands/queries_unittest.py: ditto
3150         * Scripts/webkitpy/commands/queues_unittest.py: ditto
3151         * Scripts/webkitpy/commands/upload_unittest.py: ditto
3152         * Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called.
3153
3154 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3155
3156         Rubberstamped by Simon Hausmann
3157
3158         [Qt] QtLauncher refactoring, separating utility methods.
3159
3160         * QtLauncher/QtLauncher.pro:
3161         * QtLauncher/main.cpp:
3162         * QtLauncher/utils.cpp: Added.
3163         (urlFromUserInput):
3164         * QtLauncher/utils.h: Added.
3165
3166 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3167
3168         Rubberstamped by Simon Hausmann
3169
3170         [Qt] Refactor the code in the QtLauncher dealing with HTTP proxy.
3171
3172         * QtLauncher/main.cpp:
3173         (MainWindow::MainWindow):
3174         * QtLauncher/webpage.cpp:
3175         (WebPage::WebPage):
3176         (WebPage::applyProxy):
3177         * QtLauncher/webpage.h:
3178
3179 2010-01-26  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3180
3181         Reviewed by Tor Arne Vestbø.
3182
3183         [Qt] Corrects debug build of DumpRenderTree on Windows.
3184
3185         * DumpRenderTree/qt/DumpRenderTree.pro:
3186
3187 2010-01-26  Daniel Bates  <dbates@webkit.org>
3188
3189         Reviewed by Adam Barth.
3190
3191         https://bugs.webkit.org/show_bug.cgi?id=34070
3192
3193         Moves the try/catch for OSError exceptions in Executive.run_command
3194         to Credentials.read_credentials() so that the unit test
3195         webkitpy.scm_unittest.SCMClassTests.test_error_handlers can
3196         assert that Executive.run_command throws an OSError exception.
3197
3198         * Scripts/webkitpy/credentials.py:
3199         * Scripts/webkitpy/executive.py: Moved try/catch for OSError to
3200         method Credentials.read_credentials().
3201         * Scripts/webkitpy/executive_unittest.py: Removed tests that no longer
3202         apply: test_run_command_with_bad_command_check_return_code and
3203         test_run_command_with_bad_command_check_calls_error_handler. Added new
3204         test to assert that run_command throws OSError exceptions.
3205
3206 2010-01-26  Diego Gonzalez  <diego.gonzalez@openbossa.org>
3207
3208         Reviewed by Kenneth Rohde Christiansen.
3209
3210         [Qt] DRT WebHistory support
3211         https://bugs.webkit.org/show_bug.cgi?id=34167
3212
3213         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3214         (LayoutTestController::reset):
3215         (LayoutTestController::webHistoryItemCount):
3216         (LayoutTestController::keepWebHistory):
3217         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3218
3219 2010-01-26  Kent Tamura  <tkent@chromium.org>
3220
3221         Reviewed by Eric Seidel.
3222
3223         [Win] Add modifiers parameter support to Windows DumpRenderTree
3224         https://bugs.webkit.org/show_bug.cgi?id=34068
3225
3226         Add support for functional name modifiers; "addSelectionKey" and
3227         "rangeSelectionKey", and modifiers parameter to eventSender.mouseDown()
3228         and eventSender.mouseUp().
3229         This change is similar to r53498 for Mac.
3230         
3231         * DumpRenderTree/win/EventSender.cpp:
3232         (buildModifierFlags): New function to set MK_CONTROL or MK_SHIFT to WPARAM.
3233         (mouseDownCallback): Call buidlModifiersFlags().
3234         (mouseUpCallback): ditto.
3235         (keyDownCallback): Add support for "addSelectionkey" and "rangeSelectionKey".
3236
3237 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
3238
3239         Reviewed by Eric Seidel.
3240
3241         The Python autoinstall cache directory now only gets created
3242         in the directory containing autoinstall.py.
3243
3244         https://bugs.webkit.org/show_bug.cgi?id=33365
3245
3246         * Scripts/webkitpy/autoinstall.py:
3247           - Also added a README file to the cache directory saying
3248             where it came from.
3249
3250 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
3251
3252         Reviewed by Eric Seidel.
3253
3254         Moved the check-webkit-style processors into a new
3255         webkitpy/style/processors directory.
3256
3257         https://bugs.webkit.org/show_bug.cgi?id=34060
3258
3259         * Scripts/webkitpy/style/checker.py:
3260         * Scripts/webkitpy/style/checker_unittest.py:
3261         * Scripts/webkitpy/style/cpp_style.py: Removed.
3262         * Scripts/webkitpy/style/cpp_style_unittest.py: Removed.
3263         * Scripts/webkitpy/style/processors: Added.
3264         * Scripts/webkitpy/style/processors/__init__.py: Added.
3265         * Scripts/webkitpy/style/processors/cpp.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style.py.
3266         * Scripts/webkitpy/style/processors/cpp_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py.
3267         * Scripts/webkitpy/style/processors/text.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style.py.
3268         * Scripts/webkitpy/style/processors/text_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style_unittest.py.
3269         * Scripts/webkitpy/style/text_style.py: Removed.
3270         * Scripts/webkitpy/style/text_style_unittest.py: Removed.
3271         * Scripts/webkitpy/style/unittests.py:
3272
3273 2010-01-26  Kevin Ollivier  <kevino@theolliviers.com>
3274
3275         [wx] Build fix, make sure stub function returns a value.
3276
3277         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3278         (LayoutTestController::counterValueForElementById):
3279
3280 2010-01-26  Steve Falkenburg  <sfalken@apple.com>
3281
3282         Reviewed by Oliver Hunt.
3283
3284         Windows build references non-existent include paths
3285         https://bugs.webkit.org/show_bug.cgi?id=34175
3286
3287         * DumpRenderTree/win/DumpRenderTree.vcproj:
3288         * DumpRenderTree/win/ImageDiff.vcproj:
3289         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3290
3291 2010-01-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3292
3293         Reviewed by Ariya Hidayat.
3294
3295         [Qt] Separating out the UrlLoader from the QtLauncher in it's
3296         own implementation and header file.
3297
3298         * QtLauncher/main.cpp:
3299         (main):
3300         * QtLauncher/urlloader.cpp: Added.
3301         (UrlLoader::UrlLoader):
3302         (UrlLoader::loadNext):
3303         (UrlLoader::init):
3304         (UrlLoader::getUrl):
3305         * QtLauncher/urlloader.h: Added.
3306
3307 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
3308
3309         Reviewed by Shinichiro Hamaji.
3310
3311         Refactored check-webkit-style by removing the file path
3312         parameter from the style error handler functions.
3313
3314         https://bugs.webkit.org/show_bug.cgi?id=34031
3315
3316         * Scripts/webkitpy/style/checker.py:
3317           - Added _default_style_error_handler() to StyleChecker class.
3318           - Moved handle_style_error() to inside _default_style_error_handler().
3319
3320         * Scripts/webkitpy/style/checker_unittest.py:
3321           - Removed file path from calls to error handler.
3322
3323         * Scripts/webkitpy/style/cpp_style.py:
3324           - Removed file path from calls to error handler.
3325
3326         * Scripts/webkitpy/style/cpp_style_unittest.py:
3327           - Removed file path from calls to error handler.
3328
3329         * Scripts/webkitpy/style/text_style.py:
3330           - Removed file path from calls to error handler.
3331
3332         * Scripts/webkitpy/style/text_style_unittest.py:
3333           - Removed file path from calls to error handler.
3334
3335 2010-01-25  Jeremy Orlow  <jorlow@chromium.org>
3336
3337         Adding myself as reviewer.  No review necessary.
3338
3339         * Scripts/webkitpy/committers.py:
3340
3341 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
3342
3343         Reviewed by Adam Barth.
3344
3345         Improved prepare-ChangeLog so that it preserves the relative
3346         indentation of a git commit message.
3347
3348         https://bugs.webkit.org/show_bug.cgi?id=34058
3349
3350         * Scripts/prepare-ChangeLog:
3351           - Also adjusted the script so that it does not add white
3352             space characters to empty lines.
3353
3354 2010-01-24  Eric Seidel  <eric@webkit.org>
3355
3356         No review, rolling out r53763.
3357         http://trac.webkit.org/changeset/53763
3358         https://bugs.webkit.org/show_bug.cgi?id=33895
3359
3360         Broke 20+ tests on Windows.
3361
3362         * Scripts/run-webkit-tests:
3363         * Scripts/webkitdirs.pm:
3364
3365 2010-01-24  Adam Barth  <abarth@webkit.org>
3366
3367         Rubber stamped by Eric Seidel.
3368
3369         More pep8 compliance.
3370
3371         * Scripts/webkitpy/mock_bugzillatool.py:
3372
3373 2010-01-24  Adam Barth  <abarth@webkit.org>
3374
3375         Rubber stamped by Eric Seidel.
3376
3377         More pep8 compliance.
3378
3379         * Scripts/webkitpy/executive.py:
3380         * Scripts/webkitpy/grammar.py:
3381
3382 2010-01-24  Adam Barth  <abarth@webkit.org>
3383
3384         Rubber stamped by Eric Seidel.
3385
3386         More pep8 compliance.
3387
3388         * Scripts/webkitpy/comments.py:
3389         * Scripts/webkitpy/committers.py:
3390         * Scripts/webkitpy/credentials.py:
3391
3392 2010-01-24  Adam Barth  <abarth@webkit.org>
3393
3394         Rubber stamped by Eric Seidel.
3395
3396         Make changelogs.py pass pep8.
3397
3398         * Scripts/webkitpy/changelogs.py:
3399
3400 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3401
3402         [Qt] Unreviewed build fix
3403
3404         * QtLauncher/QtLauncher.pro:
3405         * QtLauncher/webinspector.h:
3406
3407 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3408
3409         Rubberstamped by Simon Hausmann.
3410
3411         [Qt] Move the WebInspector class to it's own header file.
3412
3413         * QtLauncher/main.cpp:
3414         * QtLauncher/webinspector.h: Added.
3415         (WebInspector::WebInspector):
3416         (WebInspector::showEvent):
3417         (WebInspector::hideEvent):
3418
3419 2010-01-23  Robert Hogan  <robert@roberthogan.net>
3420
3421         Reviewed by Kenneth Rohde Christiansen.
3422
3423         Qt DRT: respect window.close() and window.closed()
3424         
3425         Qt DRT needs to maintain a correct count of open windows
3426         for windowCount(). It also needs to delete windows that
3427         have been closed by window.close().
3428         
3429         This fixes the following tests:
3430         
3431         plugins/destroy-during-npp-new.html
3432         fast/dom/Document/early-document-access.html
3433         fast/dom/Window/window-early-properties.html
3434         fast/events/open-window-from-another-frame.html
3435         fast/events/popup-blocking-click-in-iframe.html
3436         
3437         https://bugs.webkit.org/show_bug.cgi?id=32953
3438
3439         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3440         (WebCore::DumpRenderTree::DumpRenderTree):
3441         (WebCore::DumpRenderTree::createWindow):
3442         (WebCore::DumpRenderTree::windowCloseRequested):
3443         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3444         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3445         (LayoutTestController::maybeDump):
3446
3447 2010-01-23  Dan Bernstein  <mitz@apple.com>
3448
3449         Reviewed by Mark Rowe.
3450
3451         Added a user default for specifying a fallback frameworks path in case
3452         the bundle does not contain frameworks for the current Mac OS X version.
3453
3454         * WebKitLauncher/main.m:
3455         (fallbackMacOSXVersion): Added. Looks up the fallback version in a dictionary
3456         keyed by the FallbackSystemVersions user default and returns it.
3457         (main): If a frameworks directory for the current system version is not found,
3458         try the fallback.
3459
3460 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3461
3462         Reviewed by Simon Hausmann.
3463
3464         Make run-webkit-tests work under Cygwin for the Qt port
3465
3466         setPathForRunningWebKitApp() is implemented for the Qt port
3467         by using qmake to query for the location of the Qt libraries.
3468
3469         This requires the original environment (%ENV) to be untouched,
3470         so launchWithCurrentEnv() was refactored to launchWithEnv(),
3471         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
3472         instead. This has the added benefit of getting rid of the temp
3473         variables used for storing the current env.
3474
3475         openDumpTool() is also refactored a bit into platform-spesific,
3476         port-spesific, and generic environment variables.
3477
3478         Checks for undef was added a few places to fix Perl concat
3479         warnings when run-webkit-tests is aborted.
3480
3481         https://bugs.webkit.org/show_bug.cgi?id=33895
3482
3483         * Scripts/run-webkit-tests:
3484         * Scripts/webkitdirs.pm:
3485
3486 2010-01-22  Kevin Watters  <kevinwatters@gmail.com>
3487
3488         Reviewed by Kevin Ollivier.
3489
3490         [wx] Remove the Bakefile build system, which is no longer being used.
3491         
3492         https://bugs.webkit.org/show_bug.cgi?id=34022
3493
3494         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
3495         * wx/browser/browser.bkl: Removed.
3496         * wx/build-wxwebkit: Removed.
3497
3498 2010-01-22  Gustavo Noronha Silva  <gns@gnome.org>
3499
3500         Reviewed by Simon Fraser.
3501
3502         Reset zoom level to 1.0 when resetting view state. This is causing
3503         many tests to fail after svg/custom/text-zoom.xhtml changes the
3504         zoom level.
3505
3506         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3507         (resetDefaultsToConsistentValues):
3508
3509 2010-01-22  Steve Falkenburg  <sfalken@apple.com>
3510
3511         Reviewed by Darin Adler.
3512
3513         https://bugs.webkit.org/show_bug.cgi?id=34025
3514         Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.
3515
3516         * Scripts/build-webkit:
3517
3518 2010-01-22  Adam Barth  <abarth@webkit.org>
3519
3520         Unreviewed.  Arg.  Someone renamed limit to output_limit on me.
3521
3522         * Scripts/webkitpy/commands/queues.py:
3523
3524 2010-01-22  Adam Barth  <abarth@webkit.org>
3525
3526         Rubber stamped by Eric Seidel.
3527
3528         Make __init__.py and buildbot.py pass pep8 style checker.
3529
3530         * Scripts/webkitpy/__init__.py:
3531         * Scripts/webkitpy/buildbot.py:
3532
3533 2010-01-21  Joe Mason  <jmason@rim.com>
3534
3535         Reviewed by Adam Barth.
3536
3537         webkit-patch should retry on invalid password
3538         https://bugs.webkit.org/show_bug.cgi?id=33955
3539
3540         Ask for bugs.webkit.org authentication in a loop.
3541
3542         * Scripts/webkitpy/bugzilla.py:
3543
3544 2010-01-22  Adam Barth  <abarth@webkit.org>
3545
3546         Unreviewed.  Don't call seek on a NoneType.
3547
3548         * Scripts/webkitpy/statusserver.py:
3549
3550 2010-01-22  Petri Latvala  <petri.latvala@nomovok.com>
3551
3552         Reviewed by David Levin.
3553
3554         check-webkit-style breaks on files with unknown types
3555         https://bugs.webkit.org/show_bug.cgi?id=34001
3556
3557         For files with type FileType.NONE, dispatch_processor returns None.
3558
3559         * Scripts/webkitpy/style/checker.py: Don't call process_file with a processor of value None.
3560
3561 2010-01-22  Adam Barth  <abarth@webkit.org>
3562
3563         Reviewed by Eric Seidel.
3564
3565         Make bugzilla.py and webkitport.py conform to pep8
3566         https://bugs.webkit.org/show_bug.cgi?id=34015
3567
3568         This patch makes webkitport.py and bugzilla.py mostly conform to PEP8
3569         style as enforced by pep8.py.  I wasn't able to get rid of all the
3570         errors because I'm not sure how to wrap some lines properly.  Also,
3571         there are a few deprication errors that I couldn't resolve easily.
3572         However, this is a massive improvement in compliance.
3573
3574         * Scripts/webkitpy/bugzilla.py:
3575         * Scripts/webkitpy/webkitport.py:
3576
3577 2010-01-22  Adam Barth  <abarth@webkit.org>
3578
3579         Reviewed by Darin Adler.
3580
3581         Limit length of EWS results to 5MB
3582         https://bugs.webkit.org/show_bug.cgi?id=34016
3583
3584         Hopefully this will fix the bug where the results link doesn't appear.
3585         Our current theory is that the results blob is too big and the server
3586         is rejecting the request with a 500 error.  That causes us to re-try
3587         the post, but when we re-try the StringIO buffer has its seek pointer
3588         at the end.
3589
3590         * Scripts/webkitpy/commands/queues.py:
3591         * Scripts/webkitpy/statusserver.py:
3592
3593 2010-01-22  Chris Jerdonek  <cjerdonek@webkit.org>
3594
3595         Reviewed by Adam Barth.
3596
3597         Made check-webkit-style able to check patches when script not
3598         run from source root. Also consolidated external references
3599         to a single file.
3600
3601         https://bugs.webkit.org/show_bug.cgi?id=33791
3602
3603         * Scripts/check-webkit-style:
3604           - Changed to import style_references.py.
3605
3606         * Scripts/webkitpy/style/__init__.py:
3607           - Removed __path__ hack that allowed searching Scripts/ directory.
3608
3609         * Scripts/webkitpy/style/checker.py:
3610           - Changed to import style_references.py.
3611
3612         * Scripts/webkitpy/style_references.py: Added.
3613