WebKitTools/ChangeLog

   1 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
   2
   3         Reviewed by Gustavo Noronha Silva.
   4
   5         https://bugs.webkit.org/show_bug.cgi?id=30997
   6         [Gtk] Implemment AtkDocument
   7
   8         Added testing support.
   9
  10         * DumpRenderTree/AccessibilityUIElement.cpp:
  11         * DumpRenderTree/AccessibilityUIElement.h:
  12         (getDocumentEncodingCallback):
  13         (getDocumentURICallback):
  14         (AccessibilityUIElement::getJSClass):
  15         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  16         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  17         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
  18         (AccessibilityUIElement::documentEncoding):
  19         (AccessibilityUIElement::documentURI):
  20
  21 2009-11-12  Adam Roben  <aroben@apple.com>
  22
  23         Replace worldIDs with world objects
  24
  25         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
  26         user scripts/stylesheets and isolated worlds
  27
  28         Reviewed by Sam Weinig.
  29
  30         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  31         (LayoutTestController::addUserScript):
  32         (LayoutTestController::addUserStyleSheet):
  33         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  34         (LayoutTestController::addUserScript):
  35         (LayoutTestController::addUserStyleSheet):
  36         Changed these functions to create a new WebJSWorld each time they're
  37         called and to pass that world to WebKit.
  38
  39 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
  40
  41         Reviewed by Oliver Hunt.
  42
  43         need to implement aria tree roles
  44         https://bugs.webkit.org/show_bug.cgi?id=31284
  45
  46         * DumpRenderTree/AccessibilityUIElement.cpp:
  47         (disclosedRowAtIndexCallback):
  48         (selectedRowAtIndexCallback):
  49         (isEqualCallback):
  50         (isAttributeSettableCallback):
  51         (isActionSupportedCallback):
  52         (disclosedByRowCallback):
  53         (hierarchicalLevelCallback):
  54         (AccessibilityUIElement::getJSClass):
  55         * DumpRenderTree/AccessibilityUIElement.h:
  56         (AccessibilityUIElement::isEqual):
  57         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  58         (AccessibilityUIElement::hierarchicalLevel):
  59         (AccessibilityUIElement::disclosedRowAtIndex):
  60         (AccessibilityUIElement::selectedRowAtIndex):
  61         (AccessibilityUIElement::disclosedByRow):
  62         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  63         (AccessibilityUIElement::getChildAtIndex):
  64         (AccessibilityUIElement::disclosedRowAtIndex):
  65         (AccessibilityUIElement::selectedRowAtIndex):
  66         (AccessibilityUIElement::titleUIElement):
  67         (AccessibilityUIElement::parentElement):
  68         (AccessibilityUIElement::disclosedByRow):
  69         (AccessibilityUIElement::hierarchicalLevel):
  70         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
  71         (AccessibilityUIElement::hierarchicalLevel):
  72         (AccessibilityUIElement::disclosedRowAtIndex):
  73         (AccessibilityUIElement::selectedRowAtIndex):
  74         (AccessibilityUIElement::disclosedByRow):
  75
  76 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
  77
  78         Reviewed by Darin Adler.
  79
  80         svn-apply can not handle git binary diffs
  81         https://bugs.webkit.org/show_bug.cgi?id=26830
  82
  83         Support "literal" type git binary diffs.
  84
  85         * Scripts/VCSUtils.pm:
  86         * Scripts/modules/scm_unittest.py:
  87         * Scripts/svn-apply:
  88
  89 2009-11-11  Dmitry Titov  <dimich@chromium.org>
  90
  91         Not reviewed, removing duplicate entry for myself in committers.py.
  92
  93         * Scripts/modules/committers.py:
  94
  95 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
  96
  97         Reviewed by Darin Adler and Mark Rowe.
  98
  99         https://bugs.webkit.org/show_bug.cgi?id=31200
 100         Tests in http/tests/security/mixedContent start to fail when new tests are added
 101
 102         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
 103
 104 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 105
 106         Reviewed by Jan Alonzo.
 107
 108         Create, and display a window for the inspector, for inspector
 109         tests.
 110
 111         Need to also show/hide the inspector window to avoid having
 112         problems with code assuming it is realized
 113         https://bugs.webkit.org/show_bug.cgi?id=31347
 114
 115         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 116         (webInspectorShowWindow):
 117         (webInspectorCloseWindow):
 118         (webInspectorInspectWebView):
 119         (createWebView):
 120
 121 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 122
 123         Unreviewed Qt buildbot fix.
 124
 125         My previous fix was wrong, so revert that change and fix it by
 126         returning when the document of the frame has no document element.
 127         Idea is borrowed from mac and win DRT.
 128
 129         * DumpRenderTree/qt/DumpRenderTree.cpp:
 130         (WebCore::DumpRenderTree::dumpFramesAsText):
 131
 132 2009-11-11  Eric Seidel  <eric@webkit.org>
 133
 134         Reviewed byg Kenneth Rohde Christiansen.
 135
 136         Update Kenneth's committer record to include the email he
 137         uses on lists.webkit.org.
 138
 139         * Scripts/modules/committers.py:
 140
 141 2009-11-11  Eric Seidel  <eric@webkit.org>
 142
 143         Reviewed by Gustavo Noronha Silva.
 144
 145         Several committers use separate email addresses for bugzilla and svn.webkit.org
 146         https://bugs.webkit.org/show_bug.cgi?id=31364
 147
 148         Update records for existing committers to include email addresses
 149         used in svn.webkit.org and lists.webkit.org.
 150         Most committers use the same email address in all 3 places, but some use
 151         separate addresses.  committers.py needs record of each of these addresses.
 152
 153         * Scripts/modules/committers.py:
 154
 155 2009-11-11  Eric Seidel  <eric@webkit.org>
 156
 157         No review, adding second email address for an existing committer.
 158
 159         Add Yong Li's second bugzilla account to his committer record.
 160         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
 161
 162         * Scripts/modules/committers.py:
 163
 164 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 165
 166         Reviewed by Simon Hausmann.
 167
 168         If the frame has no innerText don't append it, and
 169         do not add a newline which breaks some cross platform
 170         results.
 171
 172         * DumpRenderTree/qt/DumpRenderTree.cpp:
 173         (WebCore::DumpRenderTree::dumpFramesAsText):
 174
 175 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 176
 177         Reviewed by Simon Hausmann.
 178
 179         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
 180
 181         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
 182         (webkit_test_plugin_new_instance):
 183         (webkit_test_plugin_destroy_instance):
 184         (webkit_test_plugin_destroy_stream):
 185
 186 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 187
 188         Reviewed by Mark Rowe.
 189
 190         Implement the functionality needed by plugins/window-open.html
 191
 192         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
 193         (webkit_test_plugin_new_instance):
 194         (webkit_test_plugin_set_window):
 195
 196 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 197
 198         Reviewed by Simon Hausmann.
 199
 200         [Qt] Force -graphicssystem raster and -style windows when running DRT
 201
 202         * DumpRenderTree/qt/main.cpp:
 203         * Scripts/run-webkit-tests:
 204
 205 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 206
 207         Reviewed by Simon Hausmann.
 208
 209         Compute correct library paths for Qt
 210
 211         * Scripts/webkitdirs.pm:
 212
 213 2009-11-10  Mark Rowe  <mrowe@apple.com>
 214
 215         Reviewed by Sam Weinig.
 216
 217         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
 218
 219         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
 220         about the validity of the self-signed certificates used in the regression tests.  We would then add the
 221         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
 222         that had enabled frame load delegate logging this would result in extra log messages being generated,
 223         causing the test to fail.
 224
 225         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
 226         tests.
 227
 228         * DumpRenderTree/mac/DumpRenderTree.mm:
 229         (dumpRenderTree):
 230         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 231         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
 232
 233 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
 234
 235         Reviewed by Kenneth Rohde Christiansen.
 236
 237         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
 238
 239         * DumpRenderTree/qt/DumpRenderTree.cpp:
 240         (WebCore::DumpRenderTree::DumpRenderTree):
 241
 242 2009-11-10  Philippe Normand  <pnormand@igalia.com>
 243
 244         Reviewed by Jan Alonzo.
 245
 246         [GTK] Remove WebSocket configuration from WebKitWebSettings
 247         https://bugs.webkit.org/show_bug.cgi?id=31244
 248
 249         Follow-up of r50724. Don't set the enable-web-socket property
 250         anymore.
 251
 252         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 253         (resetDefaultsToConsistentValues):
 254
 255 2009-11-10  Oliver Hunt  <oliver@apple.com>
 256
 257         Reviewed by Maciej Stachowiak.
 258
 259         Rename 3D Canvas related classes to use WebGL prefix
 260         https://bugs.webkit.org/show_bug.cgi?id=29095
 261
 262         Checkin new version of do-webcore-rename used to do the WebGL type rename,
 263         and upate webkitdirs script to new method of testing for WebGL.
 264
 265         * Scripts/do-webcore-rename:
 266         * Scripts/webkitdirs.pm:
 267
 268 2009-11-09  Oliver Hunt  <oliver@apple.com>
 269
 270         Reviewed by Geoff Garen.
 271
 272         Make do-webcore-rename work with git.
 273
 274         * Scripts/do-webcore-rename:
 275
 276 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
 277
 278         Adding Kenneth to the reviewers list.
 279
 280         * Scripts/modules/committers.py:
 281
 282 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
 283
 284         Reviewed by Jan Alonzo.
 285
 286         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
 287         https://bugs.webkit.org/show_bug.cgi?id=30482
 288
 289         LayoutTestControllerGtk now uses the exposed
 290         Page::tabKeyCyclesThroughElements API
 291
 292         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 293         (LayoutTestController::setTabKeyCyclesThroughElements):
 294
 295 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
 296
 297         Reviewed by Holger Freyther.
 298
 299         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
 300         This helps to pass the test case below. Also replaced hardcoded
 301         code numbers with defined constants.
 302         https://bugs.webkit.org/show_bug.cgi?id=31185
 303
 304         Test: editing/undo/undo-deleteWord.html
 305
 306         * DumpRenderTree/qt/EventSenderQt.cpp:
 307         (EventSender::keyDown):
 308
 309 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
 310
 311         Reviewed by Holger Freyther.
 312
 313         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
 314         https://bugs.webkit.org/show_bug.cgi?id=31164
 315
 316         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
 317
 318         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 319         (LayoutTestController::processWork):
 320
 321 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
 322
 323         Reviewed by Holger Freyther.
 324
 325         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
 326         https://bugs.webkit.org/show_bug.cgi?id=31158
 327
 328         By invoking a script queue'd by queueScript(), 'true' was beeing returned
 329         always, which from WorkQueue prospective means that a load has been started
 330         and the queue processing should stop and wait for the load to finish.
 331         Spinning it off into a loading and a non-loading variants was the solution
 332         adopted by Mac's DRT to work around this problem. The former keeps returning
 333         'true' while the later executes the script synchronously and returns 'false'
 334         making it possible to the WorkQueue to proceed right away.
 335
 336         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 337         (LayoutTestController::processWork):
 338         (LayoutTestController::queueLoadingScript):
 339         (LayoutTestController::queueNonLoadingScript):
 340         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 341         * DumpRenderTree/qt/WorkQueueItem.h:
 342         (LoadingScriptItem::LoadingScriptItem):
 343         (LoadingScriptItem::invoke):
 344         (NonLoadingScriptItem::NonLoadingScriptItem):
 345         (NonLoadingScriptItem::invoke):
 346
 347 2009-11-07  Mark Rowe  <mrowe@apple.com>
 348
 349         Rubber-stamped by Cameron Zwarich.
 350
 351         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
 352
 353         * Scripts/commit-log-editor:
 354
 355 2009-11-07  Mark Rowe  <mrowe@apple.com>
 356
 357         Reviewed by Darin Adler.
 358
 359         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
 360         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
 361
 362         Move logic for determining the name and email address to use in a ChangeLog entry from
 363         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
 364         whether the author of the patch matches committer, and therefore needs access to the
 365         email address that would be used in a ChangeLog entry.
 366
 367         Based on a patch by Pierre d'Herbemont.
 368
 369         * Scripts/VCSUtils.pm:
 370         * Scripts/commit-log-editor:
 371         * Scripts/prepare-ChangeLog:
 372         * Scripts/webkitdirs.pm:
 373
 374 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
 375
 376         Reviewed by Adam Barth.
 377
 378         Added functionality to the layout test plugin to invoke document.open and
 379         window.open with default arguments. The associated webkit bug is
 380         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
 381         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
 382         work in Chromium (V8) if there is no calling javascript context. To achieve this
 383         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
 384         for the window.open test case and in NPP_DestroyStream for the document.open test case.
 385
 386         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 387         (testDocumentOpen):
 388         (testWindowOpen):
 389         (pluginAllocate):
 390         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
 391         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
 392         (NPP_New):
 393         (NPP_SetWindow):
 394         (NPP_DestroyStream):
 395         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
 396         (NPP_New):
 397         (NPP_SetWindow):
 398         (NPP_NewStream):
 399         (NPP_DestroyStream):
 400
 401 2009-11-06  Eric Seidel  <eric@webkit.org>
 402
 403         Reviewed by Adam Barth.
 404
 405         bugzilla-tool crashed with exception
 406         https://bugs.webkit.org/show_bug.cgi?id=31092
 407
 408         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
 409
 410 2009-11-04  Eric Seidel  <eric@webkit.org>
 411
 412         No review, just add a line which got left out of the patch uploaded for commit.
 413
 414         commit-queue is crashing when trying to reject patches after unknown failures
 415         https://bugs.webkit.org/show_bug.cgi?id=31091
 416
 417         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
 418
 419 2009-11-04  Adam Roben  <aroben@apple.com>
 420
 421         Remove bogus else clause in bugzilla-tool
 422
 423         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
 424         create-bug raises exception after entering bug description
 425
 426         Reviewed by David Kilzer.
 427
 428         * Scripts/bugzilla-tool:
 429         (CreateBug): else clauses are only hit if no exception is raised, so
 430         it makes no sense to try to re-raise the exception in an else clause.
 431         The exception will automatically be re-raised if it doesn't match any
 432         of the except clauses, so we don't have to do anything special here at
 433         all to get the desired behavior.
 434
 435 2009-11-04  Eric Seidel  <eric@webkit.org>
 436
 437         Reviewed by David Kilzer.
 438
 439         svn-apply's fixChangeLogPatch function seems broken
 440         https://bugs.webkit.org/show_bug.cgi?id=30683
 441
 442         Update fixChangeLogPatch to be able to handle patches which
 443         don't start at line 1.
 444         Add unit tests for svn-apply to scm_unittest.py.
 445
 446         * Scripts/VCSUtils.pm:
 447         * Scripts/modules/scm_unittest.py:
 448
 449 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
 450
 451         Reviewed by Beth Dakin.
 452
 453         Need to implement ARIA role="combobox"
 454         https://bugs.webkit.org/show_bug.cgi?id=31096
 455
 456         * DumpRenderTree/AccessibilityUIElement.cpp:
 457         (showMenuCallback):
 458         (getIsExpandedCallback):
 459         (AccessibilityUIElement::getJSClass):
 460         * DumpRenderTree/AccessibilityUIElement.h:
 461         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 462         (AccessibilityUIElement::isExpanded):
 463         (AccessibilityUIElement::showMenu):
 464         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 465         (AccessibilityUIElement::isExpanded):
 466         (AccessibilityUIElement::showMenu):
 467         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 468         (AccessibilityUIElement::isSelected):
 469         (AccessibilityUIElement::isExpanded):
 470         (AccessibilityUIElement::showMenu):
 471
 472 2009-11-04  Eric Seidel  <eric@webkit.org>
 473
 474         Reviewed by Adam Barth.
 475
 476         commit-queue is crashing when trying to reject patches after unknown failures
 477         https://bugs.webkit.org/show_bug.cgi?id=31091
 478
 479         * Scripts/bugzilla-tool:
 480          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
 481            so we have to find out what the current patch is by asking bugzilla again.
 482          - Discovered that this code was also leaking file descriptors, so fixed that.
 483
 484 2009-11-04  Adam Roben  <aroben@apple.com>
 485
 486         Make run-webkit-tests work for the Debug_Internal Windows
 487         configuration
 488
 489         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
 490         suffix.
 491
 492         Fixes <http://webkit.org/b/31123>.
 493
 494         Reviewed by Sam Weinig.
 495
 496         * Scripts/run-webkit-tests: Don't add the _debug suffix in
 497         Debug_Internal, either.
 498
 499 2009-11-04  Eric Seidel  <eric@webkit.org>
 500
 501         Reviewed by Adam Barth.
 502
 503         committers.py needs a way to store non-bugzilla email addresses
 504         https://bugs.webkit.org/show_bug.cgi?id=31037
 505
 506         Make Committer and Reviewer constructors take a single email or a list of emails.
 507         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
 508         Expose reviewers(), used by validate-committer-lists on bug 30970.
 509
 510         * Scripts/modules/committers.py:
 511         * Scripts/modules/committers_unittest.py: Added tests for the new code.
 512
 513 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
 514
 515         Reviewed by David Levin.
 516
 517         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
 518         https://bugs.webkit.org/show_bug.cgi?id=27491
 519
 520         The test path determination logic is changed to handle websocket and websocket/ssl cases.
 521         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
 522
 523         Functions to start or stop Web Socket servers are added.
 524
 525         * Scripts/run-webkit-tests:
 526
 527 2009-11-03  Eric Seidel  <eric@webkit.org>
 528
 529         No review, just changing wording of log message.
 530
 531         Change log string to say "failed" instead of "rejected"
 532         when a commit fails due to an out of date checkout.
 533         This makes grepping the commit-queue log for rejected patches easier.
 534
 535         * Scripts/bugzilla-tool:
 536
 537 2009-11-03  Eric Seidel  <eric@webkit.org>
 538
 539         No review, adding commonly known committers missing from the file.
 540
 541         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
 542
 543 2009-11-03  Eric Seidel  <eric@webkit.org>
 544
 545         No review, just sort-order cleanup.
 546
 547         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
 548
 549 2009-11-03  Stephen White  <senorblanco@chromium.org>
 550
 551         (Unreviewed).
 552
 553         Add myself to committers.py.
 554
 555         * Scripts/modules/committers.py:
 556
 557 2009-11-03  Robin Dunn  <robin@alldunn.com>
 558
 559         Reviewed by Kevin Ollviier.
 560
 561         Add packaging scripts for Debian-based Linux distros.
 562
 563         https://bugs.webkit.org/show_bug.cgi?id=31075
 564
 565         * wx/packaging/build-debian-installer.py: Added.
 566         * wx/packaging/debian: Added.
 567
 568 2009-11-03  Dan Bernstein  <mitz@apple.com>
 569
 570         Reviewed by Anders Carlsson and Beth Dakin.
 571
 572         https://bugs.webkit.org/show_bug.cgi?id=31070
 573
 574         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
 575         destroyed, it executes the value of the 'ondestroy' parameter as a
 576         script.
 577
 578         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 579         (pluginAllocate): Initialize onDestroy.
 580         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
 581         onDestroy.
 582         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
 583         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
 584         specified.
 585         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
 586
 587 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
 588
 589         Reviewed by Xan Lopez.
 590
 591         https://bugs.webkit.org/show_bug.cgi?id=31035
 592         [GTK] some accessibility tests hitting assertion in debug builds
 593
 594         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
 595
 596         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
 597         (AccessibilityController::rootElement):
 598
 599 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
 600
 601         Reviewed by Beth Dakin.
 602
 603         Support ARIA "tab" roles
 604         https://bugs.webkit.org/show_bug.cgi?id=30842
 605
 606         * DumpRenderTree/AccessibilityUIElement.cpp:
 607         * DumpRenderTree/AccessibilityUIElement.h:
 608         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 609         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 610         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 611
 612 2009-11-01  Eric Seidel  <eric@webkit.org>
 613
 614         Reviewed by David Levin.
 615
 616         buildbots should use --exit-after-N-failures
 617         https://bugs.webkit.org/show_bug.cgi?id=30809
 618
 619         Make the bots exit after 20 failures to prevent never-ending
 620         test runs where every test spends a minute crashing.
 621
 622         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 623
 624 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 625
 626         Reviewed by Eric Seidel.
 627
 628         Turn on warnings for QtWebKit for gcc
 629         https://bugs.webkit.org/show_bug.cgi?id=30958
 630
 631         * DumpRenderTree/qt/main.cpp:
 632         (crashHandler): Mark function NO_RETURN
 633
 634 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
 635
 636         Adding myself to the committers list.
 637
 638         * Scripts/modules/committers.py:
 639
 640 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
 641
 642         Fix an issue that Adam noticed in DRT.
 643
 644         Reviewed by Darin Adler.
 645
 646         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 647         (AccessibilityUIElement::role):
 648         Get the length of the role text, and create a buffer dynamically.
 649
 650 2009-10-30  Eric Seidel  <eric@webkit.org>
 651
 652         No review, rolling out r50105.
 653         http://trac.webkit.org/changeset/50105
 654
 655         This commit was causing:
 656         https://bugs.webkit.org/show_bug.cgi?id=30869
 657         We'll re-implement the feature a different way.
 658
 659         * Scripts/bugzilla-tool:
 660
 661 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
 662
 663         Test for MSAA: Accessibility of headings is not correct
 664
 665         https://bugs.webkit.org/show_bug.cgi?id=30937
 666
 667         Reviewed by Adam Roben.
 668
 669         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 670         (AccessibilityUIElement::role):
 671         Allow the role returned to be a BSTR.
 672         (AccessibilityUIElement::description):
 673         Fix a copy/paste error.
 674
 675 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
 676
 677         Test for MSAA: Accessibility of links is wrong
 678
 679         https://bugs.webkit.org/show_bug.cgi?id=30928
 680
 681         Reviewed by Darin Adler.
 682
 683         * DumpRenderTree/AccessibilityUIElement.cpp:
 684         (getAccessibilityValueCallback):
 685         Return the accessibility value.
 686         (AccessibilityUIElement::getJSClass):
 687         Added "accessibilityValue" value.
 688
 689         * DumpRenderTree/AccessibilityUIElement.h:
 690
 691         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 692         (AccessibilityUIElement::accessibilityValue):
 693         Stubbed.
 694
 695         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 696         (AccessibilityUIElement::accessibilityValue):
 697         Stubbed.
 698
 699         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 700         (AccessibilityUIElement::accessibilityValue):
 701         Get the object's value, and return it as a JS string.
 702
 703 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
 704
 705         Fix typo in command name used by wx build system.
 706
 707         * wx/build/build_utils.py:
 708
 709 2009-10-30  Adam Barth  <abarth@webkit.org>
 710
 711         Reviewed by Darin Adler.
 712
 713         Patch v1 is a dumb default name for patches
 714         https://bugs.webkit.org/show_bug.cgi?id=30952
 715
 716         Let's use "Patch" instead.
 717
 718         * Scripts/bugzilla-tool:
 719
 720 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
 721
 722         Unreviewed trivial buildfix.
 723
 724         [Qt] Buildfix for r50333.
 725
 726         * DumpRenderTree/qt/DumpRenderTree.pro:
 727
 728 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
 729
 730         Reviewed by Holger Freyther.
 731
 732         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
 733         https://bugs.webkit.org/show_bug.cgi?id=30953
 734
 735         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
 736         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
 737         makes qt DRT to share this implementation (as gtk and mac ports do).
 738
 739         * DumpRenderTree/qt/DumpRenderTree.pro:
 740         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
 741         * DumpRenderTree/qt/WorkQueue.h: Removed.
 742
 743 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 744
 745         Unreviewed potential buildbot fix.
 746
 747         Second try: Reset page history before running each test.
 748
 749         Apparently the QWebHistory::clear() keeps the current page
 750         in history which is not what we want, so we not additionally
 751         sets the history capacity to 0 (forces removing everything)
 752         and then sets it back to its original value.
 753
 754         * DumpRenderTree/qt/DumpRenderTree.cpp:
 755         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 756
 757 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 758
 759         Unreviewed potential buildbot fix.
 760
 761         Reset page history before running each test.
 762
 763         * DumpRenderTree/qt/DumpRenderTree.cpp:
 764         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 765
 766 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
 767
 768         Reviewed by Eric Seidel.
 769
 770         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
 771
 772         Bug 28420 -  Implement HTML5 <ruby> rendering
 773         (https://bugs.webkit.org/show_bug.cgi?id=28420)
 774
 775         No new tests (no functional change).
 776
 777         * Scripts/build-webkit:
 778
 779 2009-10-29  Dan Bernstein  <mitz@apple.com>
 780
 781         Reviewed by Mark Rowe.
 782
 783         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
 784         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
 785         define it.
 786
 787         * Scripts/VCSUtils.pm:
 788         * Scripts/svn-apply:
 789         * Scripts/svn-unapply:
 790
 791 2009-10-29  Xan Lopez  <xlopez@igalia.com>
 792
 793         Reviewed by Gustavo Noronha.
 794
 795         Use the GTK+ main loop instead of rolling our own mini-version of
 796         it.
 797
 798         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 799         (dump):
 800         (runTest):
 801         (webViewLoadFinished):
 802
 803 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 804
 805         Reviewed by Oliver Hunt.
 806
 807         Implement the Qt version of DRT dumpBackForwardList().
 808
 809         * DumpRenderTree/qt/DumpRenderTree.cpp:
 810         (WebCore::dumpHistoryItem):
 811         (WebCore::DumpRenderTree::dumpBackForwardList):
 812
 813 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 814
 815         Reviewed by Adam Roben.
 816
 817         Implement DRT functionality for Qt introduced in
 818         r28690 and r28705.
 819
 820         - Implemented pathToLocalResource which exposes the functionality of
 821         converting a given unix path to the correct location on Windows.
 822         - Implemented a way to remove machine-dependent information from paths
 823         in layout test results.
 824
 825         * DumpRenderTree/qt/DumpRenderTree.cpp:
 826         (WebCore::urlSuitableForTestResult):
 827         (WebCore::WebPage::javaScriptConsoleMessage):
 828         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 829         (LayoutTestController::pathToLocalResource):
 830         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 831
 832 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
 833
 834         Adding myself to the committers list.
 835
 836         * Scripts/modules/committers.py:
 837
 838 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
 839
 840         Adding myself to the committers list.
 841
 842         * Scripts/modules/committers.py:
 843
 844 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 845
 846         Reviewed by Jan Alonzo.
 847
 848         [GTK] API to start inspector for a WebView
 849         https://bugs.webkit.org/show_bug.cgi?id=22551
 850
 851         Use the new inspector API to implement the LayoutTestController
 852         interfaces used to test the inspector.
 853
 854         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 855         (webInspectorInspectWebView):
 856         (createWebView):
 857         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 858         (LayoutTestController::showWebInspector):
 859         (LayoutTestController::closeWebInspector):
 860         (LayoutTestController::evaluateInWebInspector):
 861
 862 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
 863
 864         Reviewed by Eric Seidel.
 865
 866         [Qt] WebFrame::counterValueForElementById must not be exposed
 867         https://bugs.webkit.org/show_bug.cgi?id=30882
 868
 869         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 870         (LayoutTestController::counterValueForElementById):
 871
 872 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 873
 874         Rubberstamped by Oliver Hunt.
 875
 876         Fix the warning:
 877
 878         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
 879         declared with attribute warn_unused_result".
 880
 881         by actually checking the result. In the case it is null, an
 882         error has occoured, so treat it as the other fatal errors.
 883
 884         * DumpRenderTree/qt/DumpRenderTree.cpp:
 885         (WebCore::DumpRenderTree::initializeFonts):
 886
 887 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
 888
 889         Reviewed by Darin Adler.
 890
 891         Provide a way to get counter values with layoutTestContoller
 892         https://bugs.webkit.org/show_bug.cgi?id=30555
 893
 894         Define layoutTestContoller.counterValueForElementById.
 895
 896         * DumpRenderTree/LayoutTestController.cpp:
 897         (counterValueForElementByIdCallback):
 898         (LayoutTestController::staticFunctions):
 899         * DumpRenderTree/LayoutTestController.h:
 900         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 901         (LayoutTestController::counterValueForElementById):
 902
 903 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 904
 905         Rubberstamped by Oliver Hunt.
 906
 907         Change two methods to be internal for DRT use only.
 908
 909         Part of [Qt] Review all new API in Qt 4.6
 910         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
 911
 912         * DumpRenderTree/qt/DumpRenderTree.cpp:
 913         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 914         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 915         (LayoutTestController::whiteListAccessFromOrigin):
 916
 917 2009-10-27  Eric Seidel  <eric@webkit.org>
 918
 919         Reviewed by Adam Barth.
 920
 921         REGRESSION: svn-apply exits(1) when applying a patch with a file add
 922         https://bugs.webkit.org/show_bug.cgi?id=30826
 923
 924         * Scripts/svn-apply:
 925          - Add () around all system() calls.
 926          - Use the correct system() == 0 or die instead of system() or die
 927          - Add descriptive messages to all die statements.
 928
 929 2009-10-27  Steve Block  <steveblock@google.com>
 930
 931         Reviewed by NOBODY.
 932
 933         Adds steveblock@google.com to list of committers.
 934
 935         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
 936
 937 2009-10-27  Eric Seidel  <eric@webkit.org>
 938
 939         Reviewed by Adam Barth.
 940
 941         svn-apply can exit(0) even on patch failure
 942         https://bugs.webkit.org/show_bug.cgi?id=29622
 943
 944         * Scripts/svn-apply:
 945          - Add a bunch of "or die" statements, hopefully catching all
 946            possible cases where failure could still exit(0).
 947
 948 2009-10-27  Eric Seidel  <eric@webkit.org>
 949
 950         Reviewed by Adam Barth.
 951
 952         svn-* scripts should share code through VCSUtils.pm
 953         https://bugs.webkit.org/show_bug.cgi?id=30791
 954
 955         Just moving code into a shared location.
 956
 957         * Scripts/VCSUtils.pm:
 958         * Scripts/prepare-ChangeLog:
 959         * Scripts/resolve-ChangeLogs:
 960         * Scripts/svn-apply:
 961         * Scripts/svn-create-patch:
 962         * Scripts/svn-unapply:
 963         * Scripts/update-webkit:
 964
 965 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
 966
 967         Suppress a huge number of MSVC warnings when building wxWebKit.
 968
 969         * wx/build/settings.py:
 970
 971 2009-10-26  Eric Seidel  <eric@webkit.org>
 972
 973         No review, just adding Mike Belshe to the committers list.
 974
 975         * Scripts/modules/committers.py:
 976
 977 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 978
 979         Reviewed by Darin Adler.
 980
 981         Make .rc files compile on Windows without depending on MFC headers
 982         https://bugs.webkit.org/show_bug.cgi?id=30750
 983
 984         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
 985         windows.h instead of afxres.h because it exists even when MFC is not
 986         installed, and is all that's needed here.
 987
 988         * FindSafari/FindSafari.rc: Ditto
 989
 990 2009-10-24  Eric Seidel  <eric@webkit.org>
 991
 992         Reviewed by Adam Barth.
 993
 994         bugzilla-tool post-diff should know how to mark commit-queue=?
 995         https://bugs.webkit.org/show_bug.cgi?id=29202
 996
 997         * Scripts/bugzilla-tool:
 998          - Add --commit-queue option to post-diff, post-commits and create-bug.
 999         * Scripts/modules/bugzilla.py:
1000          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
1001          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
1002
1003 2009-10-23  Eric Seidel  <eric@webkit.org>
1004
1005         Reviewed by Adam Barth.
1006
1007         bugzilla-tool commit-queue does not notice modifications to committers.py
1008         https://bugs.webkit.org/show_bug.cgi?id=30084
1009
1010         * Scripts/bugzilla-tool:
1011          - Make commit-queue re-exec itself instead of using while(1).
1012          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
1013          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
1014
1015 2009-10-22  Eric Seidel  <eric@webkit.org>
1016
1017         Reviewed by Adam Barth.
1018
1019         commit-queue will get stuck on patches if land-patches terminates unexpectedly
1020         https://bugs.webkit.org/show_bug.cgi?id=30634
1021
1022         * Scripts/bugzilla-tool:
1023          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
1024          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
1025
1026 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
1027
1028         Reviewed by Eric Seidel.
1029
1030         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
1031
1032         https://bugs.webkit.org/show_bug.cgi?id=30763
1033
1034         * pywebsocket/mod_pywebsocket/__init__.py:
1035         * pywebsocket/mod_pywebsocket/dispatch.py:
1036         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
1037         * pywebsocket/mod_pywebsocket/standalone.py:
1038         * pywebsocket/setup.py:
1039         * pywebsocket/test/test_dispatch.py:
1040
1041 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
1042
1043         Reviewed by David Levin.
1044
1045         REGRESSION: 2 failures in run-webkit-unittests
1046         https://bugs.webkit.org/show_bug.cgi?id=30645
1047
1048         * Scripts/modules/cpp_style_unittest.py:
1049         Fixed a few test scenarios which apparently lost some spaces from
1050         text literals.
1051
1052 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
1053
1054         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
1055
1056         * Scripts/webkitdirs.pm:
1057
1058 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
1059
1060         Reviewed by Darin Adler.
1061
1062         Unification of using null device in perl scripts.
1063         https://bugs.webkit.org/show_bug.cgi?id=30572
1064
1065         * Scripts/VCSUtils.pm:
1066         * Scripts/bisect-builds:
1067         * Scripts/resolve-ChangeLogs:
1068         * Scripts/run-iexploder-tests:
1069         * Scripts/run-jsc:
1070         * Scripts/run-mangleme-tests:
1071         * Scripts/run-webkit-tests:
1072         * Scripts/webkitdirs.pm:
1073         Using File::Spec->devnull() instead of hard coded /dev/null.
1074
1075 2009-10-26  Eric Seidel  <eric@webkit.org>
1076
1077         Reviewed by Holger Freyther.
1078
1079         Reviewers are missing from committers.py
1080         https://bugs.webkit.org/show_bug.cgi?id=30733
1081
1082         * Scripts/modules/committers.py:
1083
1084 2009-10-23  Eric Seidel  <eric@webkit.org>
1085
1086         No review, only adding Alice to the list of reviewers.
1087
1088         * Scripts/modules/committers.py:
1089
1090 2009-10-23  Eric Seidel  <eric@webkit.org>
1091
1092         Reviewed by Eric Carlson.
1093
1094         fast/media/mq-transform-02.html failed on Leopard Commit Bot
1095         https://bugs.webkit.org/show_bug.cgi?id=30700
1096
1097         * DumpRenderTree/mac/DumpRenderTree.mm:
1098         (resetDefaultsToConsistentValues): Update QuickTime version check.
1099
1100 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
1101
1102         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
1103         character measurement APIs that are private on Tiger.
1104
1105         * wx/build/settings.py:
1106
1107 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
1108
1109         Reviewed by NOBODY (build fix).
1110         Build fix following bug #30696.
1111
1112         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1113         (LayoutTestController::evaluateScriptInIsolatedWorld):
1114
1115 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
1116
1117         Reviewed by Sam Weinig & Geoff Garen.
1118
1119         https://bugs.webkit.org/show_bug.cgi?id=30696
1120         Enable isolated-worlds tests on mac.
1121
1122         Add private interface for DRT to invoke execution in a given world.
1123
1124         * DumpRenderTree/LayoutTestController.cpp:
1125         (evaluateScriptInIsolatedWorldCallback):
1126         (LayoutTestController::staticFunctions):
1127         * DumpRenderTree/LayoutTestController.h:
1128         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1129         (LayoutTestController::evaluateScriptInIsolatedWorld):
1130         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1131         (LayoutTestController::evaluateScriptInIsolatedWorld):
1132
1133 2009-10-21  Eric Seidel  <eric@webkit.org>
1134
1135         Reviewed by Adam Barth.
1136
1137         bugzilla-tool's "patch failed to download an apply" error should give more information
1138         https://bugs.webkit.org/show_bug.cgi?id=30632
1139
1140         * Scripts/modules/scm.py:
1141          - Use the common run_command method instead of custom POpen code.
1142          - Make run_command know how to take pipes as input.
1143         * Scripts/modules/scm_unittest.py:
1144          - Add new tests to cover change.
1145          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
1146
1147 2009-10-21  Kent Tamura  <tkent@chromium.org>
1148
1149         Unreviewed.  Adding myself to the committers list.
1150
1151         * Scripts/modules/committers.py:
1152
1153 2009-10-21  Robin Dunn  <robin@alldunn.com>
1154
1155         Reviewed by Kevin Ollivier.
1156
1157         Update the Windows installer builder to work with Vista / Win 7 and with git.
1158
1159         https://bugs.webkit.org/show_bug.cgi?id=30649
1160
1161         * wx/build/build_utils.py:
1162         * wx/packaging/build-mac-installer.py:
1163         * wx/packaging/build-win-installer.py:
1164         * wx/packaging/wxWebKitInstaller.iss.in:
1165
1166 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
1167
1168         Reviewed by Gustavo Noronha.
1169
1170         [GTK] Added conditional code to avoid using
1171         gdk_window_get_root_coords if we do not have a gtk+ release newer
1172         than 2.17.3.
1173         https://bugs.webkit.org/show_bug.cgi?id=30636
1174
1175         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1176
1177 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
1178
1179         Reviewed by Eric Seidel.
1180
1181         [Qt] Added dummy implementation for keepWebHistory()
1182         https://bugs.webkit.org/show_bug.cgi?id=30592
1183
1184         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1185         (LayoutTestController::keepWebHistory):
1186         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1187
1188 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
1189
1190         Reviewed by Xan Lopez.
1191
1192         [GTK] Fixed the double click condition, it is not double click if
1193         we move in just in one direction.
1194         https://bugs.webkit.org/show_bug.cgi?id=30636
1195
1196         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1197
1198 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
1199
1200         Reviewed by Xan Lopez.
1201
1202         [GTK] Initialize the events completly before emitting them.
1203         https://bugs.webkit.org/show_bug.cgi?id=30633
1204
1205         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1206
1207 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
1208
1209         wx build fix. Fix for when linking using --as-needed with gcc.
1210
1211         * wx/browser/wscript:
1212
1213 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
1214
1215         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
1216         to support all the features used by CURL backend.
1217
1218         * wx/build/settings.py:
1219         * wx/install-unix-extras:
1220
1221 2009-10-20  Anton Muhin  <antonm@chromium.org>
1222
1223         Reviewed by Adam Barth.
1224
1225         Add {ager,antonm,yurys}@chromium.org into committers.py
1226         https://bugs.webkit.org/show_bug.cgi?id=30560
1227
1228         * Scripts/modules/committers.py:
1229
1230 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1231
1232         Reviewed by Tor Arne Vestbø.
1233
1234         Make the Netscape Test plugin available to the Qt launcher.
1235
1236         * Scripts/run-launcher:
1237
1238 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
1239
1240         Reviewed by David Levin.
1241
1242         Removed WebSocket runtime settings.
1243         https://bugs.webkit.org/show_bug.cgi?id=29896
1244
1245         WebSocket runtime configuration is supported by chromium/v8 only.
1246
1247         * DumpRenderTree/mac/DumpRenderTree.mm:
1248         (resetDefaultsToConsistentValues):
1249         * DumpRenderTree/win/DumpRenderTree.cpp:
1250         (resetDefaultsToConsistentValues):
1251
1252 2009-10-19  Nate Chapin  <japhet@chromium.org>
1253
1254         Reviewed by Adam Barth.
1255
1256         Add testFail() to test plugin so we can test our handling of a
1257         plugin invoke call returning false.
1258
1259         https://bugs.webkit.org/show_bug.cgi?id=30239
1260
1261         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
1262         (pluginInvoke):
1263         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
1264
1265 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
1266
1267         Reviewed by Gustavo Noronha.
1268
1269         Enable DOM pasting when running layout tests.
1270
1271         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1272         (resetDefaultsToConsistentValues):
1273
1274 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1275
1276         Reviewed by Simon Hausmann.
1277
1278         Use the setPreferredContentsSize method instead
1279         of setFixedContentsSize, as the method has been renamed.
1280
1281         * DumpRenderTree/qt/DumpRenderTree.cpp:
1282         (WebCore::DumpRenderTree::open):
1283         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1284         (LayoutTestController::setFixedContentsSize):
1285
1286 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
1287
1288         Reviewed by Dan Bernstein.
1289
1290         https://bugs.webkit.org/show_bug.cgi?id=30456
1291         Fixes for new Debug_All Windows build configuration.
1292
1293         * DumpRenderTree/win/DumpRenderTree.cpp:
1294         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
1295         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
1296
1297 2009-10-16  Eric Seidel  <eric@webkit.org>
1298
1299         Reviewed by Adam Barth.
1300
1301         commit-queue status bot should list which buildbot is blocking the queue
1302         https://bugs.webkit.org/show_bug.cgi?id=30452
1303
1304         Add new methods and testing.
1305
1306         * Scripts/bugzilla-tool:
1307         * Scripts/modules/buildbot.py:
1308         * Scripts/modules/buildbot_unittest.py:
1309
1310 2009-10-16  Eric Seidel  <eric@webkit.org>
1311
1312         Reviewed by Adam Barth.
1313
1314         run-webkit-tests fails when CWD is not inside a WebKit checkout
1315         https://bugs.webkit.org/show_bug.cgi?id=30451
1316
1317         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
1318         * Scripts/modules/scm_unittest.py:
1319           - Remove use of original_path (we don't need to restore the CWD).
1320           - Don't use '.' to find the webkit checkout, use __file__ instead.
1321
1322 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
1323
1324         Reviewed by Adam Roben.
1325
1326         Add a Debug_All configuration to build entire stack as debug.
1327         Change Debug_Internal to:
1328         - stop using _debug suffix for all WebKit/Safari binaries
1329         - not use _debug as a DLL naming suffix
1330         - use non-debug C runtime lib.
1331
1332         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
1333         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
1334         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
1335         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1336         Add missing debug.vsprops inherited property sheet.
1337         Add Debug_All configuration.
1338         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
1339         * WinLauncher/WinLauncher.vcproj:
1340         Removed extraneous definitions inherited from vsprops.
1341         Add Debug_All configuration.
1342
1343 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
1344
1345         Reviewed by David Levin.
1346
1347         check-webkit-style is wrong about indent checking in namespaces
1348         in header files and a few other things
1349         https://bugs.webkit.org/show_bug.cgi?id=30362
1350
1351         The few other things include:
1352         + check-webkit-style does not require spaces around the equal sign
1353           inside 'if' statements and around binary operators that take
1354           numeric literals.
1355         + check-webkit-style reports false errors for the / operator
1356           when part of a filename in the #include directive.
1357
1358         * Scripts/modules/cpp_style.py:
1359         Improved indentation checking and space checking around
1360         binary operators. While the checks are still not perfect,
1361         they are clearly better than before.
1362         * Scripts/modules/cpp_style_unittest.py:
1363         Added test cases for the newly supported checks and modified old
1364         test cases to match the new guidelines
1365
1366 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
1367
1368         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
1369
1370         * wx/build/settings.py:
1371
1372 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
1373
1374         Reviewed by David Levin.
1375
1376         Add mod_pywebsocket to test Web Sockets.
1377         http://code.google.com/p/pywebsocket/
1378         https://bugs.webkit.org/show_bug.cgi?id=27490
1379
1380         * pywebsocket/COPYING: Added.
1381         * pywebsocket/MANIFEST.in: Added.
1382         * pywebsocket/README: Added.
1383         * pywebsocket/example/echo_client.py: Added.
1384         * pywebsocket/example/echo_wsh.py: Added.
1385         * pywebsocket/mod_pywebsocket/__init__.py: Added.
1386         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
1387         * pywebsocket/mod_pywebsocket/handshake.py: Added.
1388         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
1389         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
1390         * pywebsocket/mod_pywebsocket/standalone.py: Added.
1391         * pywebsocket/mod_pywebsocket/util.py: Added.
1392         * pywebsocket/setup.py: Added.
1393         * pywebsocket/test/config.py: Added.
1394         * pywebsocket/test/mock.py: Added.
1395         * pywebsocket/test/run_all.py: Added.
1396         * pywebsocket/test/test_dispatch.py: Added.
1397         * pywebsocket/test/test_handshake.py: Added.
1398         * pywebsocket/test/test_mock.py: Added.
1399         * pywebsocket/test/test_msgutil.py: Added.
1400         * pywebsocket/test/test_util.py: Added.
1401         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
1402         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
1403         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
1404         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
1405         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
1406         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
1407         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
1408         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
1409
1410 2009-10-15  James Robinson  <jamesr@google.com>
1411
1412         Reviewed by David Levin.
1413
1414         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
1415
1416         https://bugs.webkit.org/show_bug.cgi?id=30426
1417
1418         * Scripts/modules/cpp_style.py:
1419         * Scripts/modules/cpp_style_unittest.py:
1420
1421 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
1422
1423         Reviewed by Adam Roben.
1424
1425         Fixes <http://webkit.org/b/30411>.
1426         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
1427
1428         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
1429         building Chromium.
1430
1431         * Scripts/pdevenv:
1432
1433 2009-10-15  Robin Dunn  <robin@alldunn.com>
1434
1435         Reviewed by Kevin Ollivier.
1436
1437         Add Mac package building scripts for wx.
1438
1439         https://bugs.webkit.org/show_bug.cgi?id=30405
1440
1441         * wx/build/build_utils.py:
1442         * wx/build/settings.py:
1443         * wx/packaging/build-mac-installer.py: Added.
1444
1445 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
1446
1447         Reviewed by Gustavo Noronha.
1448
1449         Enable Web Sockets support when running layout tests.
1450
1451         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1452         (resetDefaultsToConsistentValues):
1453
1454 2009-10-15  Xan Lopez  <xlopez@igalia.com>
1455
1456         Reviewed by Gustavo Noronha.
1457
1458         Need to initialize event.button.button, since in most cases a
1459         button number is not passed as an argument.
1460
1461         * DumpRenderTree/gtk/EventSender.cpp:
1462         (mouseDownCallback):
1463         (mouseUpCallback):
1464
1465 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
1466
1467         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
1468         the OS if none was explicitly set.
1469
1470         * wx/build/settings.py:
1471
1472 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
1473
1474         Reviewed by Timothy Hatcher.
1475
1476         Web Inspector: enable developers extras within inspector layout tests.
1477
1478         https://bugs.webkit.org/show_bug.cgi?id=30014
1479
1480         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1481         (LayoutTestController::showWebInspector):
1482         (LayoutTestController::closeWebInspector):
1483         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1484         (LayoutTestController::showWebInspector):
1485         (LayoutTestController::closeWebInspector):
1486
1487 2009-10-14  José Millán Soto  <jmillan@igalia.com>
1488
1489         Reviewed by Jan Alonzo.
1490
1491         GtkLauncher is using a deprecated signal
1492         https://bugs.webkit.org/show_bug.cgi?id=30364
1493
1494         Modified GtkLauncher to use notify::title signal instead of
1495         deprecated title-changed signal
1496
1497         * GtkLauncher/main.c:
1498         (notify_title_cb):
1499         (create_browser):
1500
1501 2009-10-14  Brady Eidson  <beidson@apple.com>
1502
1503         Reviewed by Sam Weinig.
1504
1505         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
1506         1 - Disables WebHistory
1507         2 - Doesn't make sense in that context anyway.
1508
1509         * DumpRenderTree/win/DumpRenderTree.cpp:
1510         (createWebViewAndOffscreenWindow):
1511
1512 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
1513
1514         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
1515         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
1516
1517         * wx/build/settings.py:
1518         * wx/install-unix-extras:
1519
1520 2009-10-14  Brady Eidson  <beidson@apple.com>
1521
1522         Reviewed by Sam Weinig.
1523
1524         WebKit Win API should provide a delegate interface for global history.
1525         https://bugs.webkit.org/show_bug.cgi?id=29905
1526
1527         * DumpRenderTree/LayoutTestController.cpp:
1528         (LayoutTestController::LayoutTestController):
1529         * DumpRenderTree/LayoutTestController.h:
1530         (LayoutTestController::dumpHistoryDelegateCallbacks):
1531         (LayoutTestController::setDumpHistoryDelegateCallbacks):
1532
1533         * DumpRenderTree/win/DumpRenderTree.cpp:
1534         (shouldLogHistoryDelegates):
1535         (runTest):
1536         (createWebViewAndOffscreenWindow):
1537         (main):
1538         * DumpRenderTree/win/DumpRenderTree.vcproj:
1539
1540         Add the IWebHistoryDelegate to DRT Windows:
1541         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
1542         (wstringFromBSTR):
1543         (HistoryDelegate::HistoryDelegate):
1544         (HistoryDelegate::~HistoryDelegate):
1545         (HistoryDelegate::QueryInterface):
1546         (HistoryDelegate::AddRef):
1547         (HistoryDelegate::Release):
1548         (HistoryDelegate::didNavigateWithNavigationData):
1549         (HistoryDelegate::didPerformClientRedirectFromURL):
1550         (HistoryDelegate::didPerformServerRedirectFromURL):
1551         (HistoryDelegate::updateHistoryTitle):
1552         (HistoryDelegate::populateVisitedLinksForWebView):
1553         * DumpRenderTree/win/HistoryDelegate.h: Added.
1554
1555         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1556         (LayoutTestController::removeAllVisitedLinks):
1557
1558 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
1559
1560         Reviewed by Simon Hausmann.
1561
1562         [Qt] Implement support for setPOSIXLocale on Qt.
1563         https://bugs.webkit.org/show_bug.cgi?id=30268
1564
1565         * DumpRenderTree/qt/DumpRenderTree.cpp:
1566         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1567         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1568         (LayoutTestController::setPOSIXLocale):
1569         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1570
1571 2009-10-13  Stephanie Lewis  <slewis@apple.com>
1572
1573         Unreviewed, adding myself to reviewers list.
1574
1575         * Scripts/modules/committers.py:
1576
1577 2009-10-13  Stephanie Lewis  <slewis@apple.com>
1578
1579         Reviewed by Mark Rowe.
1580
1581         Fix null assignment so root tests work again.
1582
1583         * Scripts/webkitdirs.pm:
1584
1585 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1586
1587         Reviewed by Simon Hausmann.
1588
1589         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
1590         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
1591         This is done in preparation of implementing missing features in DRT.
1592         No functionality changes made yet.
1593
1594         * DumpRenderTree/qt/DumpRenderTree.cpp:
1595         * DumpRenderTree/qt/DumpRenderTree.pro:
1596         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
1597         (EventSender::EventSender):
1598         (EventSender::mouseDown):
1599         (EventSender::mouseUp):
1600         (EventSender::mouseMoveTo):
1601         (EventSender::leapForward):
1602         (EventSender::keyDown):
1603         (EventSender::contextClick):
1604         (EventSender::scheduleAsynchronousClick):
1605         (EventSender::frameUnderMouse):
1606         * DumpRenderTree/qt/EventSenderQt.h: Added.
1607         (EventSender::clearKillRing):
1608         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
1609         (LayoutTestController::LayoutTestController):
1610         (LayoutTestController::reset):
1611         (LayoutTestController::processWork):
1612         (LayoutTestController::maybeDump):
1613         (LayoutTestController::waitUntilDone):
1614         (LayoutTestController::notifyDone):
1615         (LayoutTestController::windowCount):
1616         (LayoutTestController::clearBackForwardList):
1617         (LayoutTestController::dumpEditingCallbacks):
1618         (LayoutTestController::dumpResourceLoadCallbacks):
1619         (LayoutTestController::queueBackNavigation):
1620         (LayoutTestController::queueForwardNavigation):
1621         (LayoutTestController::queueLoad):
1622         (LayoutTestController::queueReload):
1623         (LayoutTestController::queueScript):
1624         (LayoutTestController::provisionalLoad):
1625         (LayoutTestController::timerEvent):
1626         (LayoutTestController::encodeHostName):
1627         (LayoutTestController::decodeHostName):
1628         (LayoutTestController::setJavaScriptProfilingEnabled):
1629         (LayoutTestController::setFixedContentsSize):
1630         (LayoutTestController::setPrivateBrowsingEnabled):
1631         (LayoutTestController::setPopupBlockingEnabled):
1632         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1633         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1634         (LayoutTestController::numberOfActiveAnimations):
1635         (LayoutTestController::disableImageLoading):
1636         (LayoutTestController::dispatchPendingLoadRequests):
1637         (LayoutTestController::setDatabaseQuota):
1638         (LayoutTestController::clearAllDatabases):
1639         (LayoutTestController::whiteListAccessFromOrigin):
1640         (LayoutTestController::waitForPolicyDelegate):
1641         (LayoutTestController::overridePreference):
1642         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
1643         (LayoutTestController::isLoading):
1644         (LayoutTestController::setLoading):
1645         (LayoutTestController::shouldDumpAsText):
1646         (LayoutTestController::shouldDumpBackForwardList):
1647         (LayoutTestController::shouldDumpChildrenAsText):
1648         (LayoutTestController::shouldDumpDatabaseCallbacks):
1649         (LayoutTestController::shouldDumpStatusCallbacks):
1650         (LayoutTestController::shouldWaitUntilDone):
1651         (LayoutTestController::canOpenWindows):
1652         (LayoutTestController::shouldDumpTitleChanges):
1653         (LayoutTestController::waitForPolicy):
1654         (LayoutTestController::dumpAsText):
1655         (LayoutTestController::dumpChildFramesAsText):
1656         (LayoutTestController::dumpDatabaseCallbacks):
1657         (LayoutTestController::dumpStatusCallbacks):
1658         (LayoutTestController::setCanOpenWindows):
1659         (LayoutTestController::dumpBackForwardList):
1660         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
1661         (LayoutTestController::display):
1662         (LayoutTestController::dumpTitleChanges):
1663         (LayoutTestController::dumpSelectionRect):
1664         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
1665         (TextInputController::TextInputController):
1666         (TextInputController::doCommand):
1667         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
1668         * DumpRenderTree/qt/WorkQueue.cpp:
1669         * DumpRenderTree/qt/WorkQueue.h:
1670         * DumpRenderTree/qt/WorkQueueItem.h:
1671         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
1672         (findFrameNamed):
1673         (LoadItem::invoke):
1674         (ReloadItem::invoke):
1675         (ScriptItem::invoke):
1676         (BackForwardItem::invoke):
1677         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
1678         * DumpRenderTree/qt/jsobjects.h:
1679
1680 2009-10-13  Dmitry Titov  <dimich@chromium.org>
1681
1682         Not reviewed, adding myself to the list of reviewers.
1683
1684         * Scripts/modules/committers.py:
1685
1686 2009-10-13  Anders Carlsson  <andersca@apple.com>
1687
1688         Reviewed by Sam Weinig.
1689
1690         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
1691
1692         Make the private browsing mode testable by the test plug-in.
1693
1694         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1695         (pluginGetProperty):
1696         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1697         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1698         (NPP_New):
1699         (NPP_SetValue):
1700
1701 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
1702
1703         No review, just adding self to the list of reviewers.
1704
1705         * Scripts/modules/committers.py:
1706
1707 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
1708
1709         Reviewed by Adam Roben.
1710
1711         Web Inspector: Use proper web view in inspector layout
1712         tests for windows.
1713
1714         https://bugs.webkit.org/show_bug.cgi?id=30298
1715
1716         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1717         (LayoutTestController::showWebInspector):
1718         (LayoutTestController::closeWebInspector):
1719         (LayoutTestController::evaluateInWebInspector):
1720
1721 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
1722
1723         Reviewed by Sam Weinig.
1724
1725         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
1726         https://bugs.webkit.org/show_bug.cgi?id=29841
1727
1728         * DumpRenderTree/mac/DumpRenderTree.mm:
1729         (resetDefaultsToConsistentValues):
1730         * DumpRenderTree/win/DumpRenderTree.cpp:
1731         (resetDefaultsToConsistentValues):
1732
1733 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
1734
1735         Reviewed by Dimitri Glazkov.
1736
1737         Chromium Port - Windows
1738         https://bugs.webkit.org/show_bug.cgi?id=29969
1739
1740         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
1741         * Scripts/webkitdirs.pm:
1742
1743 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
1744
1745         Reviewed by Darin Adler.
1746
1747         jsc scripts cleanup and Qt/GTK fix
1748         https://bugs.webkit.org/show_bug.cgi?id=30288
1749
1750         Duplicated jscPath() moved to webkitdirs.pm.
1751         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
1752         Configuration added (release/debug) to path for Qt-port on Windows.
1753
1754         * Scripts/run-javascriptcore-tests:
1755         * Scripts/run-jsc:
1756         * Scripts/run-sunspider:
1757         * Scripts/sunspider-compare-results:
1758         * Scripts/webkitdirs.pm:
1759
1760 2009-10-11  Adam Barth  <abarth@webkit.org>
1761
1762         Unreviewed.  Add Collin to committers.py.
1763
1764         * Scripts/modules/committers.py:
1765
1766 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
1767
1768         wx build fix, add bindings to source/include dirs now that there are sources there.
1769
1770         * wx/build/settings.py:
1771
1772 2009-10-09  Mark Rowe  <mrowe@apple.com>
1773
1774         Reviewed by Brady Eidson.
1775
1776         Enable plug-in halting in DumpRenderTree.
1777
1778         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
1779         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
1780
1781         * DumpRenderTree/mac/DumpRenderTree.mm:
1782         (resetDefaultsToConsistentValues):
1783         * DumpRenderTree/mac/UIDelegate.mm:
1784         (-[UIDelegate webView:shouldHaltPlugin:]):
1785
1786 2009-10-08  Brady Eidson  <beidson@apple.com>
1787
1788         Reviewed by Dan Bernstein.
1789
1790         Ask the History Delegate to populate the visited links hash.
1791         <rdar://problem/7285293> and https://webkit.org/b/29904
1792
1793         Add the ability for LayoutTestController to clear all visited links.
1794         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
1795
1796         * DumpRenderTree/LayoutTestController.cpp:
1797         (LayoutTestController::LayoutTestController):
1798         (removeAllVisitedLinksCallback):
1799         (LayoutTestController::staticFunctions):
1800         * DumpRenderTree/LayoutTestController.h:
1801         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1802         (LayoutTestController::removeAllVisitedLinks):
1803
1804         * DumpRenderTree/mac/HistoryDelegate.mm:
1805         (-[HistoryDelegate populateVisitedLinksForWebView:]):
1806
1807         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1808         (LayoutTestController::removeAllVisitedLinks):
1809         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1810         (LayoutTestController::removeAllVisitedLinks):
1811         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1812         (LayoutTestController::removeAllVisitedLinks):
1813
1814
1815 2009-10-08  Daniel Bates  <dbates@webkit.org>
1816
1817         Reviewed by Adam Roben.
1818
1819         https://bugs.webkit.org/show_bug.cgi?id=30175
1820
1821         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
1822         the OLE drag-and-drop return value like the function it emulates. Currently,
1823         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine
1824         whether the drag-and-drop operation was successful or was cancelled.
1825
1826         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop
1827         return value according to whether the drop operation was successful or not.
1828
1829         * DumpRenderTree/win/EventSender.cpp:
1830         (doMouseUp): Added parameter oleDragAndDropReturnValue.
1831         (replaySavedEvents): Ditto.
1832         * DumpRenderTree/win/EventSender.h:
1833         * DumpRenderTree/win/UIDelegate.cpp:
1834         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
1835
1836 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
1837
1838         Reviewed by Xan Lopez.
1839
1840         [GTK] Added support for a parameter setting the button that was
1841         pressed in the mouseDown function.
1842         https://bugs.webkit.org/show_bug.cgi?id=30220
1843
1844         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1845
1846 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
1847
1848         Reviewed by Xan Lopez.
1849
1850         [GTK] Added a line to the bottom of the expected result to match
1851         the output of the test.
1852         https://bugs.webkit.org/show_bug.cgi?id=30220
1853
1854         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
1855         expected.txt:
1856
1857 2009-10-08  Adam Roben  <aroben@apple.com>
1858
1859         Use QueryInterface to get IWebInspectorPrivate
1860
1861         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
1862         accessed in a more standard way
1863
1864         Reviewed by John Sullivan and Tim Hatcher.
1865
1866         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1867         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
1868         by calling IWebViewPrivate::inspector, then use QueryInterface to get
1869         to the IWebInspectorPrivate interface.
1870
1871 2009-10-07  Adam Roben  <aroben@apple.com>
1872
1873         Implement DRT support for origin whitelisting
1874
1875         Fixes <http://webkit.org/b/30185>.
1876
1877         Reviewed by Eric Seidel.
1878
1879         * DumpRenderTree/win/DumpRenderTree.cpp:
1880         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
1881         whitelist, to match Mac DRT.
1882         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1883         (LayoutTestController::whiteListAccessFromOrigin): Call through to
1884         IWebViewPrivate::whiteListAccessFromOrigin.
1885
1886 2009-10-07  Brady Eidson  <beidson@apple.com>
1887
1888         Reviewed by Darin Adler.
1889
1890         Send title changes to the global history delegate.
1891         <rdar://problem/7285293> and https://webkit.org/b/29904
1892
1893         * DumpRenderTree/mac/HistoryDelegate.mm:
1894         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
1895
1896 2009-10-07  Adam Barth  <abarth@webkit.org>
1897
1898         Unreviewed.  Remove some folks from committers.py who were listed on
1899         the WebKit Team wiki page but who weren't actually listed as commit+.
1900         At some point, we should coorelate this list with the committers
1901         mailing list.
1902
1903         * Scripts/modules/committers.py:
1904
1905 2009-10-07  Adam Barth  <abarth@webkit.org>
1906
1907         Unreviewed.  Import a bunch of committers from the WebKit Team page on
1908         the wiki into committers.py.
1909
1910         * Scripts/modules/committers.py:
1911
1912 2009-10-07  Adam Barth  <abarth@webkit.org>
1913
1914         Unreviewed.  Added Aaron Boodman to committers.py.
1915
1916         * Scripts/modules/committers.py:
1917
1918 2009-10-07  Evan Martin  <evan@chromium.org>
1919
1920         Reviewed by Darin Adler.
1921
1922         Add API to LayoutTestController for re/setting the system locale.
1923         https://bugs.webkit.org/show_bug.cgi?id=18994
1924
1925         * DumpRenderTree/LayoutTestController.cpp:
1926         (setLocaleCallback):
1927         (LayoutTestController::staticFunctions):
1928         (LayoutTestController::setLocale):
1929         * DumpRenderTree/LayoutTestController.h:
1930
1931 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
1932
1933         Reviewed by Jan Alonzo.
1934
1935         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
1936         https://bugs.webkit.org/show_bug.cgi?id=29689
1937
1938         Build fix by adding -lfontconfig for DumpRenderTree.
1939
1940         * GNUmakefile.am:
1941
1942 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
1943
1944         Reviewed by Simon Hausmann.
1945
1946         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
1947
1948         * Scripts/run-webkit-tests:
1949
1950 2009-10-07  Xan Lopez  <xlopez@igalia.com>
1951
1952         Reviewed by Gustavo Noronha.
1953
1954         "delete" in EventSender is the backspace key, not the delete one.
1955
1956         * DumpRenderTree/gtk/EventSender.cpp:
1957         (keyDownCallback):
1958
1959 2009-10-07  Xan Lopez  <xlopez@igalia.com>
1960
1961         Reviewed by Gustavo Noronha.
1962
1963         getChildrenWithRange expects as last parameter the end index, not
1964         the length of the range. Correct this and clarify the variable
1965         names to reflect how the code works.
1966
1967         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1968         (AccessibilityUIElement::getChildrenWithRange):
1969         (AccessibilityUIElement::getChildAtIndex):
1970
1971 2009-10-06  Mark Rowe  <mrowe@apple.com>
1972
1973         Reviewed by Simon Fraser.
1974
1975         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
1976
1977         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
1978         the fact we have already changed the working directory to the top of the open source tree.
1979
1980 2009-10-06  Julie Parent  <jparent@chromium.org>
1981
1982         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
1983         rather than my committer email.
1984
1985         * Scripts/modules/committers.py:
1986
1987 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
1988
1989         Reviewed by Eric Seidel.
1990
1991         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
1992
1993         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
1994         it after each layout test as it should do, making the DRT dump additional output
1995         for all of the subsequent layout tests.
1996
1997         * DumpRenderTree/qt/jsobjects.cpp:
1998         (LayoutTestController::reset):
1999
2000 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2001
2002         Reviewed by Simon Hausmann.
2003
2004         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
2005         fast/dom/assign-to-window-status.html test, which is passing as a result.
2006
2007         https://bugs.webkit.org/show_bug.cgi?id=30127
2008
2009         * DumpRenderTree/qt/DumpRenderTree.cpp:
2010         (WebCore::DumpRenderTree::DumpRenderTree):
2011         (WebCore::DumpRenderTree::statusBarMessage):
2012         * DumpRenderTree/qt/DumpRenderTree.h:
2013         * DumpRenderTree/qt/jsobjects.h:
2014         (LayoutTestController::shouldDumpStatusCallbacks):
2015         (LayoutTestController::dumpStatusCallbacks):
2016
2017 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2018
2019         Reviewed by Simon Hausmann.
2020
2021         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
2022         ignores the argument indicating which mouse button to trigger.
2023         https://bugs.webkit.org/show_bug.cgi?id=30048
2024
2025         This affects the fast/events/mouse-click-events.html layout test.
2026
2027         * DumpRenderTree/qt/jsobjects.cpp:
2028         (EventSender::mouseDown):
2029         (EventSender::mouseUp):
2030         * DumpRenderTree/qt/jsobjects.h:
2031
2032 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2033
2034         Reviewed by Simon Hausmann.
2035
2036         [Qt] Fix the EventSender::keyDown() implementation
2037         https://bugs.webkit.org/show_bug.cgi?id=30043
2038
2039         It should post both a key press event and a key release event,
2040         just like other ports do.
2041
2042         * DumpRenderTree/qt/jsobjects.cpp:
2043         (EventSender::keyDown):
2044
2045 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
2046
2047         wx build fix. Add jpeg to the list of libs to link against.
2048
2049         * wx/build/settings.py:
2050
2051 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
2052
2053         Reviewed by Simon Hausmann.
2054
2055         [Qt] EventSender::keyDown() cannot send function-key events.
2056         https://bugs.webkit.org/show_bug.cgi?id=30044
2057
2058         This affects the fast/events/keydown-function-keys.html layout test.
2059
2060         * DumpRenderTree/qt/jsobjects.cpp:
2061         (EventSender::keyDown):
2062
2063 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
2064
2065         Added --wx-compiler-prefix waf option to allow building wxWebKit with
2066         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
2067
2068         * wx/build/settings.py:
2069         * wx/build/wxpresets.py:
2070
2071 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
2072
2073         Reviewed by Timothy Hatcher.
2074
2075         Web Inspector: add testing harness for Web Inspector.
2076
2077         https://bugs.webkit.org/show_bug.cgi?id=30010
2078
2079         * DumpRenderTree/LayoutTestController.cpp:
2080         (showWebInspectorCallback):
2081         (closeWebInspectorCallback):
2082         (evaluateInWebInspectorCallback):
2083         (LayoutTestController::staticFunctions):
2084         * DumpRenderTree/LayoutTestController.h:
2085         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2086         (LayoutTestController::showWebInspector):
2087         (LayoutTestController::closeWebInspector):
2088         (LayoutTestController::evaluateInWebInspector):
2089         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2090         (LayoutTestController::showWebInspector):
2091         (LayoutTestController::closeWebInspector):
2092         (LayoutTestController::evaluateInWebInspector):
2093         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2094         (LayoutTestController::showWebInspector):
2095         (LayoutTestController::closeWebInspector):
2096         (LayoutTestController::evaluateInWebInspector):
2097         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2098         (LayoutTestController::showWebInspector):
2099         (LayoutTestController::closeWebInspector):
2100         (LayoutTestController::evaluateInWebInspector):
2101
2102 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2103
2104         Reviewed by Ariyha Hidayat.
2105
2106         Pass arguments to system() as a string instead of array
2107
2108         When passed as an array entries with a space fail to translate
2109         to two arguments to the child process, so instead of manually
2110         splitting all the entries in @buildArgs we pass the whole thing
2111         as a string instead.
2112
2113         * Scripts/webkitdirs.pm:
2114
2115 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
2116
2117         Reviewed by David Levin.
2118
2119         check-webkit-style misses whitespace errors for operators:
2120         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
2121         https://bugs.webkit.org/show_bug.cgi?id=30021
2122
2123         * Scripts/modules/cpp_style.py:
2124         Added the operators mentioned above to the same list as == and !=.
2125
2126 2009-10-02  Julie Parent  <jparent@chromium.org>
2127
2128         Unreviewed.
2129
2130         Adding myself and Ojan Vafai as committers, because we are committers.
2131
2132         * Scripts/modules/committers.py:
2133
2134 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
2135
2136         Reviewed by Adam Roben.
2137
2138         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
2139         this will help the patch merging process when TryBots are used.
2140
2141         * Scripts/svn-create-patch:
2142
2143 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
2144
2145         Reviewed by Simon Hausmann.
2146
2147         [Qt] Implement layoutTestController.overridePreference().
2148         https://bugs.webkit.org/show_bug.cgi?id=29970
2149
2150         * DumpRenderTree/qt/DumpRenderTree.cpp:
2151         (WebCore::WebPage::WebPage):
2152         (WebCore::WebPage::resetSettings):
2153         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2154         * DumpRenderTree/qt/jsobjects.cpp:
2155         (LayoutTestController::reset):
2156         (LayoutTestController::setPrivateBrowsingEnabled):
2157         (LayoutTestController::setPopupBlockingEnabled):
2158         (LayoutTestController::overridePreference):
2159         * DumpRenderTree/qt/jsobjects.h:
2160
2161 2009-10-01  Chris Marrin  <cmarrin@apple.com>
2162
2163         Reviewed by Oliver Hunt.
2164
2165         Turn on ENABLE_3D_CANVAS in TOT
2166         https://bugs.webkit.org/show_bug.cgi?id=29906
2167
2168         * Scripts/build-webkit:
2169
2170 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2171
2172         Rubberstamped by Simon Hausmann.
2173
2174         Enable HTTP tests for Qt
2175
2176         * Scripts/run-webkit-tests:
2177
2178 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
2179
2180         Reviewed by Dimitri Glazkov.
2181
2182         build-webkit --chromium now also works on cygwin.
2183
2184         https://bugs.webkit.org/show_bug.cgi?id=29973
2185
2186         * Scripts/webkitdirs.pm:
2187
2188 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
2189
2190         Reviewed by Simon Hausmann.
2191
2192         [Qt] Don't use TCmalloc in DumpRenderTree
2193         https://bugs.webkit.org/show_bug.cgi?id=27029
2194
2195         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
2196
2197         * DumpRenderTree/qt/DumpRenderTree.pro:
2198
2199 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
2200
2201         Reviewed by Simon Hausmann.
2202
2203         [Qt] Implement eventSender.scheduleAsynchronousClick().
2204
2205         https://bugs.webkit.org/show_bug.cgi?id=29931
2206
2207         * DumpRenderTree/qt/jsobjects.cpp:
2208         (EventSender::scheduleAsynchronousClick):
2209         * DumpRenderTree/qt/jsobjects.h:
2210
2211 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
2212
2213         Reviewed by Simon Hausmann.
2214
2215         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
2216         fast/events/open-window-from-another-frame.html from the Skipped list.
2217
2218         https://bugs.webkit.org/show_bug.cgi?id=29930
2219
2220         * DumpRenderTree/qt/jsobjects.cpp:
2221         (LayoutTestController::setPopupBlockingEnabled):
2222         * DumpRenderTree/qt/jsobjects.h:
2223
2224 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
2225
2226         Unreviewed.
2227
2228         Added myself to the list of committers.
2229
2230         * Scripts/modules/committers.py:
2231
2232 2009-09-30  Eric Seidel  <eric@webkit.org>
2233
2234         No review, just adding Geoff to the list of reviewers.
2235
2236         * Scripts/modules/committers.py:
2237
2238 2009-09-30  Dan Bernstein  <mitz@apple.com>
2239
2240         Reviewed by Sam Weinig.
2241
2242         Added the WebKit Layout Tests fonts that are referenced in
2243         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
2244
2245         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
2246         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
2247
2248 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2249
2250         Reviewed by David Kilzer.
2251
2252         Make sunspider scripts work on Windows platform.
2253         https://bugs.webkit.org/show_bug.cgi?id=29656
2254
2255         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
2256         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
2257         * Scripts/webkitdirs.pm: currentPerlPath() added.
2258
2259 2009-09-29  Brady Eidson  <beidson@apple.com>
2260
2261         Rubberstamped by Dan Bernstein.
2262
2263         Fix license and some sorting in new files.
2264
2265         * DumpRenderTree/mac/HistoryDelegate.h:
2266         * DumpRenderTree/mac/HistoryDelegate.mm:
2267
2268 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
2269
2270         Reviewed by David Kilzer.
2271
2272         Fixed how error codes are handled.
2273         https://bugs.webkit.org/show_bug.cgi?id=29898
2274
2275         * Scripts/update-webkit:
2276         * Scripts/update-webkit-chromium:
2277
2278 2009-09-29  Brady Eidson  <beidson@apple.com>
2279
2280         Reviewed by John Sullivan.
2281
2282         Updated way-out-of-date sorting throughout the dump methods/flags.
2283
2284         * DumpRenderTree/LayoutTestController.cpp:
2285         (LayoutTestController::LayoutTestController):
2286         (dumpAsPDFCallback):
2287         (dumpAsTextCallback):
2288         (dumpFrameLoadCallbacksCallback):
2289         (dumpResourceLoadCallbacksCallback):
2290         (LayoutTestController::staticFunctions):
2291
2292         * DumpRenderTree/LayoutTestController.h:
2293         (LayoutTestController::dumpAsText):
2294         (LayoutTestController::setDumpAsText):
2295         (LayoutTestController::dumpFrameLoadCallbacks):
2296         (LayoutTestController::setDumpFrameLoadCallbacks):
2297         (LayoutTestController::dumpSelectionRect):
2298         (LayoutTestController::setDumpSelectionRect):
2299         (LayoutTestController::dumpSourceAsWebArchive):
2300         (LayoutTestController::setDumpSourceAsWebArchive):
2301         (LayoutTestController::dumpStatusCallbacks):
2302         (LayoutTestController::setDumpStatusCallbacks):
2303         (LayoutTestController::dumpTitleChanges):
2304         (LayoutTestController::setDumpTitleChanges):
2305         (LayoutTestController::dumpWillCacheResponse):
2306         (LayoutTestController::setDumpWillCacheResponse):
2307
2308 2009-09-29  Brady Eidson  <beidson@apple.com>
2309
2310         Reviewed by John Sullivan.
2311
2312         WebKit Mac API should provide a delegate interface for global history.
2313         <rdar://problem/7042773> and https://webkit.org/b/29904
2314
2315         Adding the dumping of global history delegate callbacks.
2316
2317         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2318
2319         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
2320         * DumpRenderTree/mac/DumpRenderTree.mm:
2321         (createWebViewAndOffscreenWindow):
2322         (allocateGlobalControllers):
2323         (shouldLogFrameLoadDelegates):
2324         (shouldLogHistoryDelegates):
2325         (runTest):
2326
2327         Dump history delegate callbacks:
2328         * DumpRenderTree/mac/HistoryDelegate.h: Added.
2329         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
2330         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
2331         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
2332         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
2333
2334 2009-09-29  Daniel Bates  <dbates@webkit.org>
2335
2336         Reviewed by Adam Roben.
2337
2338         https://bugs.webkit.org/show_bug.cgi?id=28902
2339
2340         Fixes an issue where the drop effect returned by Window Dump Render Tree
2341         was always DROPEFFECT_NONE (since it was hard coded to do so).
2342
2343         This patch corrects this issue by determining the actual drop effect
2344         performed by the corresponding drag-and-drop operation so that we can
2345         return it.
2346
2347         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
2348         (DraggingInfo::DraggingInfo):
2349         (DraggingInfo::performedDropEffect): Added method.
2350         (DraggingInfo::setPerformedDropEffect): Added method.
2351         * DumpRenderTree/win/EventSender.cpp:
2352         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
2353         Moved delete draggingInfo to UIDelegate::doDragDrop.
2354         * DumpRenderTree/win/UIDelegate.cpp:
2355         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
2356
2357 2009-09-29  Dan Bernstein  <mitz@apple.com>
2358
2359         Reviewed by Adam Roben.
2360
2361         Remove copying of unnecessary or nonexistent files from the ImageDiff
2362         post-build event.
2363
2364         * DumpRenderTree/win/ImageDiff.vcproj:
2365
2366 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2367
2368         Reviewed by David Kilzer.
2369
2370         [Qt] Make build-webkit script work on Windows
2371         https://bugs.webkit.org/show_bug.cgi?id=29802
2372
2373         * Scripts/run-webkit-tests:
2374         * Scripts/webkitdirs.pm:
2375          - Removed unnecessary -p switch for mkdir on Windows.
2376          - Use canonical path, which uses slashes or backslashes depends on platform.
2377          - isWindows() only test for Windows and not for Cyqwin.
2378
2379 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2380
2381         Reviewed by Simon Hausmann.
2382
2383         Fix time measurement in build-webkit after refactoring done in r48853.
2384
2385         * Scripts/build-webkit:
2386
2387 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2388
2389         Reviewed by Tor Arne Vestbø.
2390
2391         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
2392         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
2393
2394         * DumpRenderTree/qt/DumpRenderTree.cpp:
2395         (WebCore::WebPage::WebPage):
2396
2397 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
2398
2399         Reviewed by Simon Hausmann.
2400
2401         [Qt] Implement eventSender.contextClick().
2402         https://bugs.webkit.org/show_bug.cgi?id=29821
2403
2404         * DumpRenderTree/qt/jsobjects.cpp:
2405         (EventSender::contextClick):
2406         * DumpRenderTree/qt/jsobjects.h:
2407
2408 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
2409
2410         Reviewed by Eric Seidel.
2411
2412         Add experimentalWebSocketsEnabled in WebPreferences.
2413         https://bugs.webkit.org/show_bug.cgi?id=28941
2414
2415         * DumpRenderTree/mac/DumpRenderTree.mm:
2416         (resetDefaultsToConsistentValues):
2417         * DumpRenderTree/win/DumpRenderTree.cpp:
2418         (resetDefaultsToConsistentValues):
2419
2420 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
2421
2422         Reviewed by David Kilzer.
2423
2424         Integrated chromium port building into webkit tools update-webkit and
2425         build-webkit.
2426
2427         https://bugs.webkit.org/show_bug.cgi?id=29749
2428
2429         * Scripts/build-webkit: When --chromium is specified, will build
2430           the chromium port (currently only Mac is supported).
2431         * Scripts/update-webkit: When --chromium is specified, delegates to
2432           update-webkit-chromium.
2433         * Scripts/webkitdirs.pm: Added chromium specific defs.
2434         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
2435           chromium port's dependencies and update its project files.
2436
2437 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
2438
2439         Unreviewed.
2440
2441         Add myself to list of committers.
2442
2443         * Scripts/modules/committers.py:
2444
2445 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
2446
2447         Reviewed by Darin Adler.
2448
2449         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
2450         https://bugs.webkit.org/show_bug.cgi?id=29771
2451
2452         * Scripts/run-webkit-tests:
2453
2454 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
2455
2456         Reviewed by Simon Hausmann.
2457
2458         [Qt] Implement layoutTestController.waitForPolicyDelegate.
2459         https://bugs.webkit.org/show_bug.cgi?id=25037
2460
2461         * DumpRenderTree/qt/DumpRenderTree.cpp:
2462         (WebCore::WebPage::acceptNavigationRequest):
2463         * DumpRenderTree/qt/DumpRenderTree.pro:
2464         * DumpRenderTree/qt/jsobjects.cpp:
2465         (LayoutTestController::reset):
2466         (LayoutTestController::notifyDone):
2467         (LayoutTestController::waitForPolicyDelegate):
2468         * DumpRenderTree/qt/jsobjects.h:
2469         (LayoutTestController::waitForPolicy):
2470
2471 2009-09-26  David Kilzer  <ddkilzer@apple.com>
2472
2473         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
2474
2475         Reviewed by Eric Seidel.
2476
2477         The -o|--open switch uses the open(1) command on Mac OS X to
2478         open the bug URL in the default web browser.  If there are
2479         similar mechanisms on other platforms, they may be added later.
2480
2481         * Scripts/mark-bug-fixed:
2482         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
2483         options.
2484         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
2485         code into main() and extracted prompting code into
2486         _prompt_user_for_correctness().
2487         (MarkBugFixed._open_bug_in_web_browser): Added.
2488         (MarkBugFixed._prompt_user_for_correctness): Added.
2489         (MarkBugFixed.main): Added logging code from
2490         _determine_bug_id_and_svn_revision().  Added code to call
2491         _open_bug_in_web_browser() if the switch is set.  Added code to
2492         call _prompt_user_for_correctness() when needed.
2493         * Scripts/modules/bugzilla.py:
2494         (Bugzilla.short_bug_url_for_bug_id): Added.
2495
2496 2009-09-26  David Kilzer  <ddkilzer@apple.com>
2497
2498         svn-unapply and svn-apply don't work when used outside multiple svn working directories
2499
2500         <http://webkit.org/b/29744>
2501         <rdar://problem/7252905>
2502
2503         Reviewed by Eric Seidel.
2504
2505         Some users have a workflow where svn-create-patch, svn-apply and
2506         svn-unapply are used outside of multiple svn working
2507         directories.  Instead of aborting the scripts in these cases,
2508         print a warning and assume that Subversion is being used.
2509
2510         * Scripts/VCSUtils.pm:
2511         (determineVCSRoot): Call warn() instead of die() if both isGit()
2512         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
2513         to enforce the assumption about Subversion, then return
2514         determineSVNRoot().
2515         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
2516         VCSUtils.pm.  They both already cache their values and checking
2517         here is redundant since determineVCSRoot() is called later.
2518
2519 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
2520
2521         Reviewed by Gustavo Noronha.
2522
2523         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
2524         https://bugs.webkit.org/show_bug.cgi?id=29689
2525
2526         Load test fonts through FontConfig before each test.
2527         This ensures a more proper rendering of the tests.
2528
2529         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2530         (initializeFonts):
2531         (runTest):
2532         (main):
2533         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
2534         * GNUmakefile.am:
2535
2536 2009-09-25  David Kilzer  <ddkilzer@apple.com>
2537
2538         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
2539
2540         Reviewed by Eric Seidel.
2541
2542         * Scripts/mark-bug-fixed:
2543         (MarkBugFixed.__init__): Added -u|--update-only switch to list
2544         of parse options.
2545         (MarkBugFixed.main): When -u|--update-only is specified, add a
2546         comment to the bug without marking it Resolved/Fixed.
2547
2548 2009-09-25  Darin Adler  <darin@apple.com>
2549
2550         Reviewed by Geoffrey Garen.
2551
2552         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
2553         out, just as we do for the resources directory.
2554
2555 2009-09-25  Adam Barth  <abarth@webkit.org>
2556
2557         Unreviewed.  Added Tony to committers.py because he's a
2558         committer now.
2559
2560         * Scripts/modules/committers.py:
2561
2562 2009-09-25  Eric Seidel  <eric@webkit.org>
2563
2564         Reviewed by Simon Fraser.
2565
2566         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
2567         https://bugs.webkit.org/show_bug.cgi?id=28624
2568
2569         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
2570
2571         * DumpRenderTree/mac/DumpRenderTree.mm:
2572         (resetDefaultsToConsistentValues):
2573
2574 2009-09-25  Eric Seidel  <eric@webkit.org>
2575
2576         Reviewed by Adam Barth.
2577
2578         commit-queue should auto-retry patches which fail to commit due to out of date files
2579         https://bugs.webkit.org/show_bug.cgi?id=28316
2580
2581         * Scripts/bugzilla-tool:
2582          - Handle new CheckoutNeedsUpdate exception.
2583         * Scripts/modules/logging_unittest.py:
2584          - Call the ScriptError constructor correctly (this test had regressed).
2585         * Scripts/modules/scm.py:
2586          - Added the ability to define custom error handlers for run_command
2587            and added a commit_error_handler which throws CheckoutNeedsUpdate
2588            instead of ScriptError.
2589          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
2590         * Scripts/modules/scm_unittest.py:
2591          - Added tests of new error handlers.
2592
2593 2009-09-25  Eric Seidel  <eric@webkit.org>
2594
2595         Reviewed by Adam Barth.
2596
2597         commit-queue should give better feedback when failing a patch
2598         https://bugs.webkit.org/show_bug.cgi?id=29316
2599
2600         * Scripts/bugzilla-tool:
2601          - Update ScriptError uses to the new constructor format.
2602          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
2603            so that we can print to both stdout as well as an output buffer for error reporting.
2604          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
2605          - Use e.message_with_output() when failing a patch (this is the real fix here).
2606            I also removed use of "This patch will require manual commit." as that's not always true.
2607          - Add missing word "bug" from log message.
2608         * Scripts/modules/scm.py:
2609          - Make ScriptError save a bunch more data so that error messages can be nicer.
2610          - Update ScriptError callers.
2611
2612 2009-09-24  John Gregg  <johnnyg@google.com>
2613
2614         Reviewed by Eric Seidel.
2615
2616         Enable switch for notifications (experimental) in Page Settings
2617         https://bugs.webkit.org/show_bug.cgi?id=28930
2618
2619         Now that desktop notifications are controlled by run-time switch,
2620         set that switch to true for DumpRenderTree.
2621
2622         * DumpRenderTree/mac/DumpRenderTree.mm:
2623         (resetDefaultsToConsistentValues):
2624         * DumpRenderTree/win/DumpRenderTree.cpp:
2625         (resetDefaultsToConsistentValues):
2626         * DumpRenderTree/win/UIDelegate.cpp:
2627         (UIDelegate::QueryInterface):
2628
2629 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
2630
2631         wx build fix. SnowLeopard fixes for Mac dependencies.
2632
2633         * wx/build/build_utils.py:
2634         * wx/build/settings.py:
2635         * wx/install-unix-extras:
2636
2637 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2638
2639         Reviewed by Oliver Hunt.
2640
2641         Add support for DRT to send mouse wheel events.
2642
2643         https://bugs.webkit.org/show_bug.cgi?id=29348
2644         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
2645
2646         * DumpRenderTree/gtk/EventSender.cpp:
2647         (mouseWheelToCallback):
2648
2649 2009-09-17  Eric Seidel  <eric@webkit.org>
2650
2651         Reviewed by David Levin.
2652
2653         commit-queue needs web-based status reporting
2654         https://bugs.webkit.org/show_bug.cgi?id=29307
2655
2656         Add a first-pass web-based status for the commit-queue.
2657         The bot is currently reachable at:
2658         http://webkit-commit-queue.appspot.com/
2659
2660         * CommitQueueStatus/app.yaml: Added.
2661          - Application description file required by App Engine.
2662         * CommitQueueStatus/filters/__init__.py: Added.
2663          - Required by python to treat 'filters' as a module.
2664         * CommitQueueStatus/filters/webkit_extras.py: Added.
2665          - Support for turning 'bug 123' and 'patch 123' into links.
2666            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
2667         * CommitQueueStatus/index.html: Added.
2668         * CommitQueueStatus/index.yaml: Added.
2669          - Some auto-generated file from app engine.
2670         * CommitQueueStatus/queue_status.py: Added.
2671          - The core logic of this bot.  We could eventually split this file out into pieces.
2672         * CommitQueueStatus/stylesheets/main.css: Added.
2673          - Some basic lame-o CSS to make the page look less awful.
2674         * CommitQueueStatus/update_status.html: Added.
2675          - The form that the commit-queue (or a human) can use to update the status.
2676         * Scripts/bugzilla-tool:
2677          - Add some very basic update_status calls.
2678         * Scripts/modules/statusbot.py: Added.
2679          - Knows how to post to the CommitQueueStatus web application.
2680
2681 2009-09-24  David Kilzer  <ddkilzer@apple.com>
2682
2683         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
2684
2685         Reviewed by Adam Roben.
2686
2687         * Scripts/mark-bug-fixed:
2688         (MarkBugFixed.__init__): Added -m|--comment switch to list of
2689         parse options.
2690         (MarkBugFixed.main): When specified, prepend comment from
2691         -m|--comment command-line switch to the bug comment.
2692
2693 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2694
2695         Reviewed by Jan Alonzo.
2696
2697         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
2698         https://bugs.webkit.org/show_bug.cgi?id=29693
2699
2700         Show the window, to be able to synthesize events correctly.
2701
2702         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2703         (runTest):
2704         (main):
2705
2706 2009-09-24  Oliver Hunt  <oliver@apple.com>
2707
2708         Reviewed by NOBODY(rollout)
2709
2710         Roll out r48712 as it is incorrect.
2711
2712         * DumpRenderTree/mac/ObjCController.m:
2713         (+[ObjCController isSelectorExcludedFromWebScript:]):
2714         (+[ObjCController webScriptNameForSelector:]):
2715
2716 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
2717
2718         Reviewed by Eric Seidel.
2719
2720         https://bugs.webkit.org/show_bug.cgi?id=29005
2721         The indices of RuntimeArray should be enumerated like for a regular array.
2722
2723         * DumpRenderTree/mac/ObjCController.m:
2724         (+[ObjCController isSelectorExcludedFromWebScript:]):
2725         (+[ObjCController webScriptNameForSelector:]):
2726         (-[ObjCController arrayOfString]):
2727
2728 2009-09-23  David Kilzer  <ddkilzer@apple.com>
2729
2730         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
2731
2732         Reviewed by Darin Adler.
2733
2734         Also fixed a bug where specifying a revision on the command-line
2735         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
2736
2737         * Scripts/bugzilla-tool: Updated module import statements.
2738         (parse_bug_id): Removed.  Moved to bugzilla.py.
2739         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
2740         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
2741         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
2742         (BugzillaTool.__init__): Removed mark-fixed subcommand.
2743         * Scripts/mark-bug-fixed: Added.
2744         * Scripts/modules/bugzilla.py:
2745         (parse_bug_id): Added.  Moved from bugzilla-tool.
2746         * Scripts/modules/comments.py: Added.
2747         (bug_comment_from_svn_revision): Added.  Moved from bugzilla-tool.
2748         (bug_comment_from_commit_text): Added.  Moved from bugzilla-tool.
2749
2750 2009-09-23  Marshall Culpepper  <mculpepper@appcelerator.com>
2751
2752         Reviewed by Eric Seidel.
2753
2754          jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
2755          "false" in non-implemented stub for setAlwaysAcceptCookies.
2756          https://bugs.webkit.org/show_bug.cgi?id=29661
2757
2758         * DumpRenderTree/win/DumpRenderTree.vcproj:
2759         * DumpRenderTree/win/DumpRenderTree.cpp:
2760
2761 2009-09-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2762
2763         Reviewed by Xan Lopez.
2764
2765         [GTK] need to dump number of pending unload handlers
2766         https://bugs.webkit.org/show_bug.cgi?id=29685
2767
2768         Implement dumping of the number of pending unload handlers.
2769
2770         The following tests will pass:
2771
2772           fast/loader/unload-form-about-blank.html
2773           fast/loader/unload-form-post-about-blank.html
2774           fast/loader/unload-form-post.html
2775           fast/loader/unload-form.html
2776           fast/loader/unload-hyperlink.html
2777           fast/loader/unload-javascript-url.html
2778           fast/loader/unload-reload.html
2779           fast/loader/unload-window-location.html
2780
2781         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2782         (getFrameNameSuitableForTestResult):
2783         (webViewLoadFinished):
2784
2785 2009-09-22  Shinichiro Hamaji  <hamaji@chromium.org>
2786
2787         Reviewed by Eric Seidel.
2788
2789         js tests should move into jstests subdirectory instead of resources/
2790         https://bugs.webkit.org/show_bug.cgi?id=25880
2791
2792         Remove support of resources directory.
2793
2794         * Scripts/make-script-test-wrappers:
2795
2796 2009-09-22  Eric Seidel  <eric@webkit.org>
2797
2798         No review, only fixing typo (missing space character).
2799
2800         Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220
2801
2802         * Scripts/run-webkit-tests:
2803
2804 2009-09-22  Eric Seidel  <eric@webkit.org>
2805
2806         Reviewed by Darin Adler.
2807
2808         run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
2809         https://bugs.webkit.org/show_bug.cgi?id=29220
2810
2811         * Scripts/run-webkit-tests:
2812
2813 2009-09-22  Eric Seidel  <eric@webkit.org>
2814
2815         Reviewed by David Kilzer.
2816
2817         svn-apply can't handle single-line binary file additions
2818         https://bugs.webkit.org/show_bug.cgi?id=29100
2819
2820         Fixed the regexp and added a unit test.
2821
2822         * Scripts/modules/scm_unittest.py:
2823         * Scripts/svn-apply:
2824
2825 2009-09-11  Eric Seidel  <eric@webkit.org>
2826
2827         Reviewed by David Kilzer.
2828
2829         post-diff and post-commits should be able to find bug urls in ChangeLogs.
2830         https://bugs.webkit.org/show_bug.cgi?id=29206
2831
2832         * Scripts/bugzilla-tool:
2833          - Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
2834          - Rename --no-comment to --add-log-as-comment and reverse behavior.
2835            Comments tend to just be noise.  I'll eventually remove this argument if no one uses it.
2836          - Split out code into helper functions to try and make execute() more legible.
2837          - Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
2838          - Fallback to bug urls in commit diffs, instead of just in commit messages,
2839            meaning post-commits will now find bug urls in ChangeLogs.
2840
2841 2009-09-21  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2842
2843         Reviewed by Maciej Stachowiak.
2844
2845         --parse-only parameter wasn't passed to SunSpider/sunspider script.
2846         https://bugs.webkit.org/show_bug.cgi?id=29611
2847
2848         * Scripts/run-sunspider: Missing parameter passing added.
2849
2850 2009-09-20  David Kilzer  <ddkilzer@apple.com>
2851
2852         <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module
2853
2854         Reviewed by Mark Rowe.
2855
2856         The require statement is like the use statement, except that it
2857         is run during script execution instead of during the 'BEGIN'
2858         phase.  This makes it possible to change @INC before the require
2859         statement is run.  See 'require' and 'use' in the perlfunc(1)
2860         manpage and 'BEGIN' in perlmod(1) manpage.
2861
2862         * Scripts/run-webkit-tests: Replace eval statement with require
2863         statement.
2864
2865 2009-09-18  Kevin Ollivier  <kevino@theolliviers.com>
2866
2867         wx build fixes. Fix the config name under git and allow users to specify
2868         their own waf install for experimenting with new versions.
2869
2870         * Scripts/webkitdirs.pm:
2871         * wx/build/settings.py:
2872
2873 2009-09-18  Alex Milowski  <alex@milowski.com>
2874
2875         Reviewed by Maciej Stachowiak.
2876
2877         Added checkWebCoreMathMLSupport and hasMathMLSupport to support
2878         checking for whether MathML tests should be run
2879
2880         * Scripts/run-webkit-tests:
2881         * Scripts/webkitdirs.pm:
2882
2883 2009-08-28  Darin Adler  <darin@apple.com>
2884
2885         Reviewed by Mark Rowe.
2886
2887         Break more of run-webkit-tests into separate functions
2888         https://bugs.webkit.org/show_bug.cgi?id=29497
2889
2890         Some small steps toward improving run-webkit-tests. My goal is to
2891         refactor much more of the script into functions. Later we can add
2892         parallel test running to the tool. But better structure may help
2893         even if someone decides to translate this into another scripting
2894         language instead.
2895
2896         * Scripts/run-webkit-tests: Break more pieces of the script into
2897         seprate functions. Added readSkippedFiles, findTestsToRun, and
2898         printResults functions. Removed custom code to skip results.html
2899         and instead just put it into the ignoredFiles hash. Fixed some
2900         indentation. Sorted function declarations, global variables,
2901         and options at the top of the file alphabetically so they're not
2902         in a semi-random order.
2903
2904 2009-09-17  Kevin Ollivier  <kevino@theolliviers.com>
2905
2906         wx build fix, add missing dependency.
2907
2908         * wx/browser/wscript:
2909
2910 2009-09-16  Mark Rowe  <mrowe@apple.com>
2911
2912         Split the SnowLeopard build across a few machines.
2913
2914         * BuildSlaveSupport/build.webkit.org-config/config.json:
2915
2916 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
2917
2918         wx build fix to support monolithic builds on Windows.
2919
2920         * wx/build/wxpresets.py:
2921
2922 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
2923
2924         wx build fix, improve debug support and 2.9 support on MSW.
2925
2926         * wx/build/settings.py:
2927         * wx/build/wxpresets.py:
2928
2929 2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2930
2931         Blind try at fixing new test failure on Windows.
2932
2933         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2934         (FrameLoadDelegate::didReceiveTitle):
2935
2936 2009-09-15  Alex Milowski  <alex@milowski.com>
2937
2938         Reviewed by Tor Arne Vestbø.
2939
2940         Added mathml toggle
2941
2942         * Scripts/build-webkit:
2943
2944 2009-09-15  Kevin Ollivier  <kevino@theolliviers.com>
2945
2946         wx build fix. Allow waf build to support Python < 2.6.
2947
2948         * wx/build/waf_extensions.py:
2949
2950 2009-09-14  Chris Marrin  <cmarrin@apple.com>
2951
2952         Reviewed by Oliver Hunt.
2953
2954         Add LayoutTests infrastructure to enable and disable webgl tests.
2955         https://bugs.webkit.org/show_bug.cgi?id=29254
2956
2957         * Scripts/run-webkit-tests:
2958         * Scripts/webkitdirs.pm:
2959
2960 2009-09-14  Simon Fraser  <simon.fraser@apple.com>
2961
2962         Reviewed by Darin Adler.
2963
2964         Add --iterations option to run-webkit-tests to repeat the tests N times
2965         https://bugs.webkit.org/show_bug.cgi?id=29263
2966
2967         When run with --iterations N, run-webkit-tests will repeat the tests N times.
2968
2969         * Scripts/run-webkit-tests:
2970
2971 2009-09-14  Brady Eidson  <beidson@apple.com>
2972
2973         Not reviewed, maybe should've been:
2974
2975         Cleaning up more Windows-specific fallout from the fix for:
2976         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
2977
2978         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2979         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):  Correct printf() formatter,
2980           and call the correct method to get the Sender.
2981
2982 2009-09-14  Jon Honeycutt  <jhoneycutt@apple.com>
2983
2984         GTK build fix.
2985
2986         Unreviewed.
2987
2988         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2989         (AccessibilityController::setLogScrollingStartEvents):
2990
2991 2009-09-11  Jon Honeycutt  <jhoneycutt@apple.com>
2992
2993         DRT/test part of
2994         <rdar://problem/7197644> WebKit should broadcast an MSAA event when
2995         jumping to a named anchor
2996
2997         https://bugs.webkit.org/show_bug.cgi?id=28899
2998
2999         Reviewed by Adam Roben.
3000
3001         * DumpRenderTree/AccessibilityController.cpp:
3002         (logScrollingStartEventsCallback):
3003         Turn on logging of scrolling start events.
3004         (AccessibilityController::getJSClass):
3005         Add a "logScrollingStartEvents" to the AccessibilityController's JS
3006         class definition.
3007         (AccessibilityController::resetToConsistentState):
3008         Turn off logging of scrolling start events.
3009
3010         * DumpRenderTree/AccessibilityController.h:
3011         Declare setLogScrollingStartEvents(). Add a member for the scrolling
3012         start event hook.
3013
3014         * DumpRenderTree/mac/AccessibilityControllerMac.cpp:
3015         (AccessibilityController::setLogScrollingStartEvents):
3016         Stubbed.
3017
3018         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3019         (AccessibilityController::AccessibilityController):
3020         Initialize the handle to 0.
3021         (logEventProc):
3022         Renamed from logFocusEventProc; now logs scrolling start events, too.
3023         Removed the assertion that the event is a focus event. Added a switch
3024         to print a message for focus, scrolling start, and other, unknown
3025         events.
3026         (AccessibilityController::setLogFocusEvents):
3027         Changed to use logEventProc.
3028         (AccessibilityController::setLogScrollingStartEvents):
3029         If turning logging off, unhook the scrolling start event hook, and clear
3030         the member holding the handle. If turning on, query for the root
3031         accessible, so that accessibility is enabled for the WebView, and call
3032         SetWinEventHook to setup an event hook using logEventProc as the
3033         callback function.
3034
3035 2009-09-14  Brady Eidson  <beidson@apple.com>
3036
3037         Windows build fix.
3038
3039         * DumpRenderTree/LayoutTestController.cpp:
3040         (setAuthenticationPasswordCallback):
3041         (setAuthenticationUsernameCallback):
3042
3043         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3044         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3045
3046 2009-09-14  Brady Eidson  <beidson@apple.com>
3047
3048         Reviewed by Alexey Proskuryakov.
3049
3050         Safari 4 cannot be used to update firmware on Linksys routers.
3051         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
3052
3053         Add the ability for DRT to handle authentication challenges.
3054
3055         * DumpRenderTree/LayoutTestController.cpp:
3056         (setAuthenticationPasswordCallback):
3057         (setAuthenticationUsernameCallback):
3058         (setHandlesAuthenticationChallengesCallback):
3059         (LayoutTestController::staticFunctions):
3060
3061         * DumpRenderTree/LayoutTestController.h:
3062         (LayoutTestController::handlesAuthenticationChallenges):
3063         (LayoutTestController::setHandlesAuthenticationChallenges):
3064         (LayoutTestController::authenticationUsername):
3065         (LayoutTestController::setAuthenticationUsername):
3066         (LayoutTestController::authenticationPassword):
3067         (LayoutTestController::setAuthenticationPassword):
3068
3069         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3070         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
3071
3072         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3073         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3074         * DumpRenderTree/win/ResourceLoadDelegate.h:
3075
3076 2009-09-12  Mark Rowe  <mrowe@apple.com>
3077
3078         Reviewed by Dan Bernstein.
3079
3080         Test for <rdar://problem/6954546> and <rdar://problem/7090444>.
3081
3082         Add a flag on the test plug-in that asks it to clear the document during the call to NPP_New.
3083         This is the trigger for both <rdar://problem/6954546> and <rdar://problem/7090444>.
3084
3085         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3086         (NPP_New):
3087
3088 2009-09-14  Kevin Ollivier  <kevino@theolliviers.com>
3089
3090         wx build fix for non-wxPython builds and a fix for errors when updating swig.py.
3091
3092         * wx/build/build_utils.py:
3093         * wx/build/settings.py:
3094
3095 2009-09-14  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3096
3097         Reviewed by Tor Arne Vestbø.
3098
3099         [Qt] Build fix for windows build.
3100
3101         * Scripts/bisect-builds: Add missing paranthesis for tmpdir function.
3102
3103 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
3104
3105         Fix typo accidently landed in last commit.
3106
3107         * wx/build/settings.py:
3108
3109 2009-09-13  Kevin Ollivier  <kevino@theolliviers.com>
3110
3111         wx build fix, error out if using the wrong Python.
3112
3113         * wx/build/settings.py:
3114
3115 2009-09-13  Xan Lopez  <xlopez@igalia.com>
3116
3117         Build fix for GTK+ < 2.14.
3118
3119         Do not use gtk_widget_get_window, access the window directly
3120         through the struct.
3121
3122         * DumpRenderTree/gtk/EventSender.cpp:
3123         (contextClickCallback):
3124         (mouseDownCallback):
3125         (mouseUpCallback):
3126         (mouseMoveToCallback):
3127         (keyDownCallback):
3128
3129 2009-09-13  Martin Robinson  <martin.james.robinson@gmail.com>
3130
3131         Reviewed by Xan Lopez and Jan Alonzo.
3132
3133         [GTK] EventSender does not set 'window' property on synthesized GDK events
3134         https://bugs.webkit.org/show_bug.cgi?id=29169
3135
3136         Set the window property on synthesized GDK events in the GTK+ EventSender.
3137
3138         * DumpRenderTree/gtk/EventSender.cpp:
3139         (contextClickCallback):
3140         (mouseDownCallback):
3141         (mouseUpCallback):
3142         (mouseMoveToCallback):
3143         (keyDownCallback):
3144
3145 2009-09-12  Drew Wilson  <atwilson@google.com>
3146
3147         Reviewed by Mark Rowe.
3148
3149         run-webkit-tests has a timeout value that is too low
3150         https://bugs.webkit.org/show_bug.cgi?id=29223
3151
3152         * Scripts/run-webkit-tests:
3153         Changed timeout value to 20 seconds to avoid timing out too early.
3154
3155 2009-09-11  Kevin Ollivier  <kevino@theolliviers.com>
3156
3157         wx build fix. Mark dependencies as mandatory and declare which MSVC versions and
3158         architectures are supported for building wxWebKit.
3159
3160         * wx/build/settings.py:
3161
3162 2009-09-11  Eric Seidel  <eric@webkit.org>
3163
3164         Reviewed by David Levin.
3165
3166         bugzilla-tool rollout threw exception under svn
3167         https://bugs.webkit.org/show_bug.cgi?id=29211
3168
3169         * Scripts/modules/scm.py: add missing return, and convert number arguments to strings.
3170         * Scripts/modules/scm_unittest.py: add testing for this fix.
3171
3172 2009-09-11  Brian Weinstein  <bweinstein@apple.com>
3173
3174         Add myself to the committers list.
3175
3176         * Scripts/modules/committers.py:
3177
3178 2009-09-11  Eric Seidel  <eric@webkit.org>
3179
3180         Reviewed by Adam Barth.
3181
3182         bugzilla-tool land-patches should only fail-fast in --commit-queue mode
3183         https://bugs.webkit.org/show_bug.cgi?id=29201
3184
3185         * Scripts/bugzilla-tool:
3186
3187 2009-09-11  Adam Roben  <aroben@apple.com>
3188
3189         Make commit-log-editor move common prefixes to the top of the log
3190
3191         Fies <http://webkit.org/b/29190> commit-log-editor should move common
3192         prefixes to the top of the commit log
3193
3194         Reviewed by Darin Adler.
3195
3196         * Scripts/commit-log-editor: Find and remove the longest common prefix
3197         ending in a double newline from each ChangeLog entry, then put that
3198         common prefix at the top of the commit log.
3199         (removeLongestCommonPrefixEndingInDoubleNewline): Added. Finds,
3200         removes, and returns the longest common prefix ending in a double
3201         newline from a hash of strings
3202
3203 2009-09-11  Eric Seidel  <eric@webkit.org>
3204
3205         Fix obvious typo in previous commit, no review.
3206
3207         bugzilla-tool should automate rollouts
3208         https://bugs.webkit.org/show_bug.cgi?id=26715
3209
3210         * Scripts/bugzilla-tool: add back missing "scm" argument.
3211
3212 2009-09-11  Eric Seidel  <eric@webkit.org>
3213
3214         Reviewed by Adam Barth.
3215
3216         bugzilla-tool should automate rollouts
3217         https://bugs.webkit.org/show_bug.cgi?id=26715
3218
3219         bugzilla-tool rollout will do the rollout locally and leave the diff for you to verify and commit.
3220         The --complete-rollout option will automatically land and update the bug.
3221         Eventually --complete-rollout will be default, but that will require more testing.
3222
3223         This first pass is good enough for others to try and file bugs about.
3224
3225         * Scripts/bugzilla-tool:
3226          - Move modified_changelogs into scm.py.
3227          - Move svn_revision_from_commit_text logic into scm.py.
3228          - Add RolloutCommit command.
3229         * Scripts/modules/bugzilla.py:
3230          - Add reopen_bug command used by RolloutCommit.
3231         * Scripts/modules/scm.py:
3232          - Add functions to support RolloutCommit.
3233          - Abstract find_uuid into value_from_svn_info so it can be re-used for _repository_url (needed by svn merge).
3234          - Add a str() call so that svn_commit_log can take a numeric argument.
3235          - Remove a bunch of very slow code from last_svn_commit_log and used the built-in 'BASE' alias instead.
3236          - Made dry_run commits return something that svn_revision_from_commit_text can parse.
3237         * Scripts/modules/scm_unittest.py:
3238          - Add read_from_path for easy file reading.
3239          - Put test4 on a new line to make reverts work w/o conflict.
3240          - Add an "svn update" call so that the checkout revision matches the server revision.
3241          - Add tests for svn_revision_from_commit_text.
3242          - Add a simple test for apply_reverse_diff.
3243          - Add a new self.scm member and use it in the new tests (eventually other tests can use it too).
3244          - Add test for svn_commit_log to make sure my 'BASE' change above worked as expected.
3245
3246 2009-09-11  Adam Roben  <aroben@apple.com>
3247
3248         Get user script/stylesheet tests running on Windows
3249
3250         Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
3251         skipped on Windows
3252
3253         Reviewed by John Sullivan.
3254
3255         * DumpRenderTree/win/DumpRenderTree.vcproj: Link all configurations
3256         against comsuppw.lib so we can use _bstr_t.
3257
3258         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Fixed #include
3259         order, added #include of comutil.h for _bstr_t.
3260
3261         (bstrT): Helper function to convert a JSStringRef to a _bstr_t.
3262         (LayoutTestController::addUserScript):
3263         (LayoutTestController::addUserStyleSheet):
3264         Implemented. Implementations were based on those in
3265         LayoutTestControllerMac.mm.
3266
3267 2009-09-10  David Kilzer  <ddkilzer@apple.com>
3268
3269         <http://webkit.org/b/29147> run-webkit-tests:  make -h show help
3270
3271         Reviewed by Mark Rowe.
3272
3273         * Scripts/run-webkit-tests: Updated to make -h switch show help.
3274
3275 2009-09-10  Fumitoshi Ukai  <ukai@chromium.org>
3276
3277         Reviewed by Alexey Proskuryakov.
3278
3279         Add WebCore/websockets directory in wx build system.
3280         https://bugs.webkit.org/show_bug.cgi?id=28038
3281
3282         * wx/build/settings.py:
3283
3284 2009-09-10  Martin Robinson  <martin.james.robinson@gmail.com>
3285
3286         [GTK] EventSender does not properly convert some keyDown strings
3287         https://bugs.webkit.org/show_bug.cgi?id=29119
3288
3289         Add more keyDown string to character code conversions for GTK+ EventSender.
3290
3291         * DumpRenderTree/gtk/EventSender.cpp:
3292         (keyDownCallback):
3293
3294 2009-09-09  Steve Block  <steveblock@google.com>
3295
3296         Reviewed by Maciej Stachowiak.
3297
3298         Geolocation Coordinates::toString() prints bogus values for unspecified properties.
3299         https://bugs.webkit.org/show_bug.cgi?id=29080
3300
3301         * Scripts/make-script-test-wrappers: Modified. Adds asynchronous Geolocation tests to exclusion list.
3302
3303 2009-09-09  Eric Seidel  <eric@webkit.org>
3304
3305         Reviewed by Eric Carlson.
3306
3307         reviewer/committer lookups are backwards
3308         https://bugs.webkit.org/show_bug.cgi?id=29113
3309
3310         I also moved Eric Carlson from the committer list to the reviewer list now that he is one.
3311
3312         * Scripts/modules/bugzilla.py:
3313         * Scripts/modules/committers.py:
3314
3315 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
3316
3317         Reviewed by Eric Seidel.
3318
3319         svn-unapply doesn't revert directories correctly
3320         https://bugs.webkit.org/show_bug.cgi?id=29065
3321
3322         * Scripts/svn-unapply: Make svnStatus consistently return status
3323         lines including a newline.
3324         * Scripts/svn-apply: Keep svnStatus in sync with the one in
3325         svn-unapply, in lieu of moving it to a common file.
3326
3327 2009-09-09  Cameron McCormack  <cam@mcc.id.au>
3328
3329         Reviewed by Eric Seidel.
3330
3331         svn-apply doesn't handle changes to files copied to new directories properly
3332         https://bugs.webkit.org/show_bug.cgi?id=29059
3333
3334         * Scripts/svn-apply: Don't treat "--- revision 0" patches as being
3335         additions if we know that we've just copied a file to this name.
3336
3337 2009-09-09  Eric Seidel  <eric@webkit.org>
3338
3339         Reviewed by David Levin.
3340
3341         commit-queue hangs if a builder has never built
3342         https://bugs.webkit.org/show_bug.cgi?id=29091
3343
3344         * Scripts/modules/buildbot.py:
3345         * Scripts/modules/buildbot_unittest.py:
3346
3347 2009-09-09  Zan Dobersek  <zandobersek@gmail.com>
3348
3349         Reviewed by Gustavo Noronha.
3350
3351         [GTK] DumpRenderTree needs eventSender object and implementation
3352         https://bugs.webkit.org/show_bug.cgi?id=25990
3353
3354         Implements most of the EventSender object's functionality for
3355         the DumpRenderTree tool. Implementation still lacks support
3356         for drag and drop tests and forward leaps.
3357
3358         Based on work by Holger Hans Peter Freyther.
3359
3360         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3361         (runTest): Focus on the view before loading a new test.
3362         (webViewWindowObjectCleared):
3363         * DumpRenderTree/gtk/EventSender.cpp: Added.
3364         (getDragModeCallback):
3365         (setDragModeCallback):
3366         (leapForwardCallback):
3367         (contextClickCallback):
3368         (updateClickCount):
3369         (mouseDownCallback):
3370         (mouseUpCallback):
3371         (mouseMoveToCallback):
3372         (beginDragWithFilesCallback):
3373         (replaySavedEvents):
3374         (keyDownCallback):
3375         (textZoomInCallback):
3376         (textZoomOutCallback):
3377         (zoomPageInCallback):
3378         (zoomPageOutCallback):
3379         (getClass):
3380         (makeEventSender):
3381         * DumpRenderTree/gtk/EventSender.h: Added.
3382         * GNUmakefile.am: Add build rules for EventSender.
3383
3384 2009-09-09  Daniel Bates  <dbates@webkit.org>
3385
3386         Reviewed by Adam Roben.
3387
3388         https://bugs.webkit.org/show_bug.cgi?id=28953
3389
3390         Added pre- and post- build events so that on build failure, the file
3391         buildfailed is written to the directory $(WebKitOutputDir).
3392
3393         * WinLauncher/WinLauncher.vcproj:
3394
3395 2009-09-09  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3396
3397         Unreviewed.
3398
3399         Add myself to list of committers.
3400
3401         * Scripts/modules/committers.py:
3402
3403 2009-09-08  Eric Seidel  <eric@webkit.org>
3404
3405         Reviewed by David Levin.
3406
3407         commit-queue gets stuck if a non-committer sets commit-queue+ or review+
3408         https://bugs.webkit.org/show_bug.cgi?id=28605
3409         https://bugs.webkit.org/show_bug.cgi?id=28916
3410
3411         * Scripts/bugzilla-tool:
3412          - Fix comment and adjust reject_patch_from_commit_queue call to pass "manual commit"
3413            comment now that it's used for rejecting patches for invalid committers too.
3414          - Pass reject_invalid_patches=True for commit-queue calls, normally we just ignore patches with invalid reviewers, the commit-queue rejects them.
3415          - Make the commit queue print patches count instead of bugs count, this also fixes https://bugs.webkit.org/show_bug.cgi?id=28916.
3416         * Scripts/modules/bugzilla.py:
3417          - Make _parse_attachment_element not validate reviewer/committer.
3418          - Share flag parsing code in _parse_attachment_flag.
3419          - Add _validate* methods for validating reviewers and committers and updating bugs when validation fails.
3420          - Add reject_invalid_patches argument so the commit-queue can update bugs on failed validation and other "read only" commands will not.
3421          - Add reject_patch_from_review_queue using a new _set_flag_on_attachment abstraction.
3422         * Scripts/modules/bugzilla_unittest.py:
3423          - Update this test to no longer expect committer/reviewer validation.
3424         * Scripts/modules/committers.py:
3425          - Return None on failed lookups instead of raising Exceptions.
3426         * Scripts/modules/committers_unittest.py:
3427          - Update tests to expect None returns instead of exceptions.
3428
3429 2009-09-09  David Kilzer  <ddkilzer@apple.com>
3430
3431         <http://webkit.org/b/29061> Fix obvious copy-paste error in AccessibilityUIElement::clickPointY()
3432
3433         Reviewed by Mark Rowe.
3434
3435         No change to layout test results.
3436
3437         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3438         (AccessibilityUIElement::clickPointY): Changed to return y value
3439         instead of x value.
3440
3441 2009-09-08  Dimitri Glazkov  <dglazkov@chromium.org>
3442
3443         Reviewed by Mark Rowe.
3444
3445         Reduce dglazkov's boboiness by properly concatenating revision value.
3446
3447         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Used substitution
3448             rather than "+".
3449
3450 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
3451
3452         wxWebKit Python extension build fix - get swig.py if it doesn't exist.
3453
3454         * wx/build/build_utils.py:
3455
3456 2009-09-08  Mark Rowe  <mrowe@apple.com>
3457
3458         Fix an incorrect variable name in UpdateChromiumSource.
3459
3460         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3461
3462 2009-09-08  Mark Rowe  <mrowe@apple.com>
3463
3464         Don't check for leaks on the release SnowLeopard builder.
3465
3466         * BuildSlaveSupport/build.webkit.org-config/config.json:
3467
3468 2009-09-08  Mark Rowe  <mrowe@apple.com>
3469
3470         Add a SnowLeopard release builder.
3471
3472         * BuildSlaveSupport/build.webkit.org-config/config.json:
3473
3474 2009-09-08  David Levin  <levin@chromium.org>
3475
3476         Reviewed by Darin Adler.
3477
3478         Remove end of line whitespace check from check-webkit-style.
3479         https://bugs.webkit.org/show_bug.cgi?id=29053
3480
3481         * Scripts/modules/cpp_style.py:
3482
3483 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
3484
3485         Reviewed by Darin Adler.
3486
3487         Fix DumpRenderTree build from clean tree on Tiger
3488         https://bugs.webkit.org/show_bug.cgi?id=28927
3489
3490         * DumpRenderTree/mac/PerlSupport/Makefile: Ensure the
3491         DerivedSources/DumpRenderTree directory exists when
3492         building on Tiger.
3493
3494 2009-09-08  Kevin Ollivier  <kevino@theolliviers.com>
3495
3496         wx build fix after introduction of platform/mock directory.
3497
3498         * wx/build/settings.py:
3499
3500 2009-09-08  Yael Aharon  <yael.aharon@nokia.com>
3501
3502         Unreviewed.
3503
3504         Add myself to list of committers.
3505
3506         * Scripts/modules/committers.py:
3507
3508 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3509
3510         Unreviewed.
3511
3512         Add myself to list of committers.
3513
3514         * Scripts/modules/committers.py:
3515
3516 2009-09-08  Cameron McCormack  <cam@mcc.id.au>
3517
3518         Reviewed by Darin Adler.
3519
3520         prepare-ChangeLog too chatty on file additions
3521         https://bugs.webkit.org/show_bug.cgi?id=29019
3522
3523         * Scripts/prepare-ChangeLog: Omit description of added properties
3524         on newly added files.
3525
3526 2009-09-08  Steve Block  <steveblock@google.com>
3527
3528         Reviewed by Adam Barth.
3529
3530         Adds a LayoutTestController method to set the permission state for Geolocation.
3531         This is required to use the mock Geolocation service for testing.
3532         https://bugs.webkit.org/show_bug.cgi?id=29027
3533
3534         * DumpRenderTree/LayoutTestController.cpp: Modified.
3535         (setDatabaseQuotaCallback): Modified. Style fix.
3536         (setGeolocationPermissionCallback): Added. Sets the Geolocation permission state.
3537         (LayoutTestController::staticFunctions): Modified. Registers the above function on the LayoutTestController.
3538         * DumpRenderTree/LayoutTestController.h: Modified.
3539         (LayoutTestController::setGeolocationPermission): Added. Sets the Geolocation permission state.
3540         (LayoutTestController::isGeolocationPermissionSet): Added. Returns whether the Geolocation permission has been set.
3541         (LayoutTestController::geolocationPermission): Added. Returns the Geolocation permission state.
3542         * DumpRenderTree/mac/UIDelegate.mm: Modified.
3543         (-[UIDelegate webView:frame:requestGeolocationPermission:securityOrigin:]): Added. Implement chrome method to respond to request for Geolocation permission state. Response is made using above methods to access permission state.
3544
3545 2009-09-08  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3546
3547         Reviewed by Simon Hausmann.
3548
3549         [Qt] QtWebKit single API to enable persistency
3550         https://bugs.webkit.org/show_bug.cgi?id=28682
3551
3552         Use the new enablePersistentStorage API instead
3553         of enabling all persistent features one-by-one.
3554
3555         * DumpRenderTree/qt/DumpRenderTree.cpp:
3556         (WebCore::WebPage::WebPage):
3557         (WebCore::DumpRenderTree::DumpRenderTree):
3558
3559 2009-09-07  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3560
3561         Reviewed by Tor Arne Vestbø.
3562
3563         Refactor --strict switch to --ignore-metrics and correct the
3564         implementation to make the feature usable on all platforms.
3565         https://bugs.webkit.org/show_bug.cgi?id=28907
3566
3567         run-webkit-tests --ignore-metrics strips the font related metrics from
3568         the actual and expected data before comparing them.
3569         In this way the render trees can be checked for obvious differences but
3570         a successful test implies by no means that the layout is actually correct.
3571
3572         * Scripts/run-webkit-tests:
3573
3574 2009-09-07  Steve Block  <steveblock@google.com>
3575
3576         Reviewed by Adam Barth.
3577
3578         Adds a mock Geolocation service. This will be used to provide predictable behavior of the
3579         Geolocation API for use in LayoutTests. Later changes will integrate the the mock
3580         Geolocation service with DumpRenderTree.
3581         https://bugs.webkit.org/show_bug.cgi?id=28264
3582
3583         * DumpRenderTree/LayoutTestController.cpp: Modified.
3584         (setMockGeolocationPositionCallback): Added. Configures the mock Geolocation service.
3585         (setMockGeolocationErrorCallback): Added. Configures the mock Geolocation service.
3586         (LayoutTestController::staticFunctions): Added. Registers the above functions on the LayoutTestController.
3587         * DumpRenderTree/LayoutTestController.h: Modified.
3588         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Modified.
3589         (LayoutTestController::setMockGeolocationPosition): Added. Configures the mock Geolocation service.
3590         (LayoutTestController::setMockGeolocationError): Added. Configures the mock Geolocation service.
3591
3592 2009-09-07  Drew Wilson  <atwilson@google.com>
3593
3594         Reviewed by David Levin.
3595
3596         Enable SHARED_WORKERS by default
3597         https://bugs.webkit.org/show_bug.cgi?id=28959
3598
3599         * Scripts/build-webkit:
3600
3601 2009-09-07  Kevin Ollivier  <kevino@theolliviers.com>
3602
3603         wx build fixes for wx SVN trunk.
3604
3605         * wx/build/settings.py:
3606
3607 2009-09-04  Kevin Ollivier  <kevino@theolliviers.com>
3608
3609         wx build fix. Switch USE_ defines over to the compiler so that they can be
3610         checked by files not including config.h (like WebCorePrefix.h).
3611
3612         * wx/build/settings.py:
3613
3614 2009-09-04  Adam Barth  <abarth@webkit.org>
3615
3616         Unreviewed build fix.
3617
3618         Update declaration of FrameLoadDelegate to reflect that
3619         IWebFrameLoadDelegatePrivate2 inherits from
3620         IWebFrameLoadDelegatePrivate.
3621
3622         * DumpRenderTree/win/FrameLoadDelegate.h:
3623
3624 2009-09-04  Adam Barth  <abarth@webkit.org>
3625
3626         Reviewed by Eric Seidel.
3627
3628         https://bugs.webkit.org/show_bug.cgi?id=24696
3629
3630         Add testing instrumentation for mixed content.
3631
3632         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3633         (-[FrameLoadDelegate webView:]):
3634         (-[FrameLoadDelegate webView:didRunInsecureContent:]):
3635         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3636         (descriptionSuitableForTestResult):
3637         (FrameLoadDelegate::QueryInterface):
3638         (FrameLoadDelegate::didDisplayInsecureContent):
3639         (FrameLoadDelegate::didRunInsecureContent):
3640         * DumpRenderTree/win/FrameLoadDelegate.h:
3641
3642 2009-09-03  Kevin Watters  <kevinwatters@gmail.com>
3643
3644         Reviewed by Kevin Ollivier.
3645
3646         [wx] Frames support
3647         https://bugs.webkit.org/show_bug.cgi?id=19041
3648
3649         * wx/build-wxwebkit:
3650
3651 2009-09-02  David Kilzer  <ddkilzer@apple.com>
3652
3653         <http://webkit.org/b/28880> svn-apply --force doesn't actually work
3654
3655         Reviewed by Eric Seidel.
3656
3657         This fixes "svn-apply --force" and adds unit tests for the
3658         scm.apply_patch() method which uses this script.
3659
3660         * Scripts/svn-apply: Created $globalExitCode variable that
3661         defaults to 0.  Exit with a value of $globalExitCode when the
3662         script is finished.
3663         (applyPatch): Ignore a non-zero $exitCode if $force is true, but
3664         set $globalExitCode to $exitCode so that svn-apply exits with a
3665         non-zero status if an