2010-09-30 Adam Barth <abarth@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-09-30  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         webkit-patch find-flaky-tests should print results URLs
6         https://bugs.webkit.org/show_bug.cgi?id=46917
7
8         Printing out the results URL makes find-flaky-tests more actionable
9         because you can see what happens when a test fails.  The output from
10         the script is still pretty noisy, but it seems useful.
11
12         * Scripts/webkitpy/tool/commands/queries.py:
13
14 2010-09-30  Chris Marrin  <cmarrin@apple.com>
15
16         Reviewed by Simon Fraser.
17
18         Make 2D accelerated canvas rendering build on Mac
19         https://bugs.webkit.org/show_bug.cgi?id=46007
20         
21         Added ACCELERATED_2D_CANVAS to build-webkit
22
23         * Scripts/build-webkit:
24
25 2010-09-29  Kenneth Russell  <kbr@google.com>
26
27         Reviewed by Dimitri Glazkov.
28
29         [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
30         https://bugs.webkit.org/show_bug.cgi?id=46849
31
32         Added offscreen code path for WebGraphicsContext3DDefaultImpl which
33         works with the compositor integration in both DumpRenderTree and
34         test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
35         and thereby trigger the compositor's readback code path. Added support
36         for --enable-accelerated-compositing to DumpRenderTree.
37
38         Tested in both test_shell and DumpRenderTree on Linux, the latter by
39         modifying a compositing layout test, dumping the pixels and verifying
40         that they matched the output when the compositor was active.
41
42         * DumpRenderTree/chromium/DumpRenderTree.cpp:
43         (main):
44         * DumpRenderTree/chromium/TestShell.cpp:
45         (TestShell::TestShell):
46         (TestShell::resetWebSettings):
47         * DumpRenderTree/chromium/TestShell.h:
48         (TestShell::setAcceleratedCompositingEnabled):
49         * DumpRenderTree/chromium/WebPreferences.cpp:
50         (WebPreferences::reset):
51         (WebPreferences::applyTo):
52         * DumpRenderTree/chromium/WebPreferences.h:
53         * DumpRenderTree/chromium/WebViewHost.cpp:
54         (WebViewHost::scheduleComposite):
55         * DumpRenderTree/chromium/WebViewHost.h:
56
57 2010-09-30  Adam Roben  <aroben@apple.com>
58
59         Ensure that QueueEngine cleans up its log files when its delegate
60         tells it to stop processing work
61
62         Reviewed by Adam Barth.
63
64         Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
65         in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
66         Windows
67
68         * Scripts/webkitpy/tool/bot/queueengine.py:
69         (QueueEngine.run): Stop ourselves normally (including cleaning up log
70         files) when the delegate tells us to stop processing work.
71
72         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
73         (LoggingDelegate.__init__): Moved code here from
74         RaisingDelegate.__init__.
75         (LoggingDelegate.expeced_callbacks): Added the stop_work_queue
76         callback.
77         (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
78         (RaisingDelegate.__init__): Removed code that LoggingDelegate takes
79         care of for us now.
80         (QueueEngineTest.test_trivial): Make sure we got the expected stop
81         message.
82         (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
83         remove the callbacks that are related to processing a single work
84         item, rather than removing all callbacks after a certain point, as
85         there are now more callbacks we expect to receive at the end.
86
87 2010-09-30  Adam Roben  <aroben@apple.com>
88
89         Fix path -> URL conversion on Cygwin
90
91         Reviewed by Adam Barth.
92
93         Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
94         in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
95
96         * Scripts/webkitpy/layout_tests/port/base.py:
97         (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
98         assuming paths already have a leading slash.
99
100 2010-09-30  Adam Roben  <aroben@apple.com>
101
102         Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can
103         be called more than once
104
105         The NPP_SetWindow call made when the plugin is torn down was confusing
106         us, and was causing us to spew an error into the next test.
107
108         Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
109         (r68520): plugins/access-after-page-destroyed.html failing on Windows
110
111         Reviewed by Anders Carlsson.
112
113         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
114         (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
115         Initialize member.
116         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
117         this isn't the first time this is called.
118
119 2010-09-30  Eric Seidel  <eric@webkit.org>
120
121         Reviewed by Adam Barth.
122
123         webkit-patch upload warns that I'm using Xcode when I'm not
124         https://bugs.webkit.org/show_bug.cgi?id=46869
125
126         String.find returns -1 when not found, so switched to "in".
127
128         * Scripts/webkitpy/common/system/user.py:
129         * Scripts/webkitpy/common/system/user_unittest.py:
130
131 2010-09-30  Eric Seidel  <eric@webkit.org>
132
133         Reviewed by Adam Barth.
134
135         webkit-patch failure-reason dies if non-trunk commits are in the blame range
136         https://bugs.webkit.org/show_bug.cgi?id=46866
137
138         I also made failure-reason use RegressionWindow in a cleaner way.
139
140         * Scripts/webkitpy/tool/commands/queries.py:
141
142 2010-09-29  Adam Barth  <abarth@webkit.org>
143
144         Reviewed by Eric Seidel.
145
146         webkit-patch find-flaky-tests
147         https://bugs.webkit.org/show_bug.cgi?id=46876
148
149         This command helps us find flaky tests so we can squash them.
150
151         * Scripts/webkitpy/tool/commands/queries.py:
152
153 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
154
155         Fix export to use '?' instead of 'null' for
156         tests with no results.
157         
158         * CSSTestSuiteHarness/harness/harness.js:
159
160 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
161
162         Add a warning when a test requires special steps.
163         Add a Print Preview button for 'paged' tests that
164         brings up the print dialog, allowing the user to 
165         judge paged media tests.
166
167         * CSSTestSuiteHarness/harness/harness.css:
168         * CSSTestSuiteHarness/harness/harness.html:
169         * CSSTestSuiteHarness/harness/harness.js:
170         (TestSuite.prototype.loadTest):
171         (TestSuite.prototype.processFlags):
172
173 2010-09-29  Adam Barth  <abarth@webkit.org>
174
175         Reviewed by Eric Seidel.
176
177         Remove revisions_casuing_failures
178         https://bugs.webkit.org/show_bug.cgi?id=46872
179
180         This function exists only to be unit tested.
181
182         * Scripts/webkitpy/common/net/failuremap.py:
183         * Scripts/webkitpy/common/net/failuremap_unittest.py:
184         * Scripts/webkitpy/tool/mocktool.py:
185
186 2010-09-29  Adam Barth  <abarth@webkit.org>
187
188         Reviewed by Eric Seidel.
189
190         SheriffBot should post the list of failing tests to bugs
191         https://bugs.webkit.org/show_bug.cgi?id=46871
192
193         * Scripts/webkitpy/common/net/buildbot.py:
194         * Scripts/webkitpy/common/net/failuremap.py:
195         * Scripts/webkitpy/common/net/regressionwindow.py:
196         * Scripts/webkitpy/tool/bot/sheriff.py:
197         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
198         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
199         * Scripts/webkitpy/tool/commands/queues_unittest.py:
200         * Scripts/webkitpy/tool/commands/sheriffbot.py:
201         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
202         * Scripts/webkitpy/tool/commands/upload_unittest.py:
203         * Scripts/webkitpy/tool/mocktool.py:
204
205 2010-09-29  Brent Fulgham  <bfulgham@webkit.org>
206
207         Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
208
209         [WinCairo] Adds a build slave.
210         https://bugs.webkit.org/show_bug.cgi?id=46360
211
212         * BuildSlaveSupport/build.webkit.org-config/config.json: Add
213         entries for a debug build of the WinCairo port.
214         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
215         platform flag to configuration for wincairo (like gtk, chromium, etc.)
216         * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
217         * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
218
219 2010-09-29  Adam Barth  <abarth@webkit.org>
220
221         Reviewed by Eric Seidel.
222
223         Move more SheriffBot smarts into FailureMap
224         https://bugs.webkit.org/show_bug.cgi?id=46703
225
226         This patch pushes the FailureMap model object further into the
227         SheriffBot machine.  In addition, it moves a couple operations on this
228         object from SheriffBot itself to the model.
229
230         Eventually, FailureMap will be the canonical context object for
231         SheriffBot operations.  FailureMap represents a map of the current
232         failures on the bots that might require remediation.
233
234         * Scripts/webkitpy/common/net/failuremap.py:
235         * Scripts/webkitpy/common/net/regressionwindow.py:
236         * Scripts/webkitpy/tool/commands/queries.py:
237         * Scripts/webkitpy/tool/commands/sheriffbot.py:
238         * Scripts/webkitpy/tool/mocktool.py:
239
240 2010-09-29  Tony Chang  <tony@chromium.org>
241
242         Reviewed by James Robinson.
243
244         [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
245         https://bugs.webkit.org/show_bug.cgi?id=46829
246
247         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
248         (DRTDevToolsClient::DRTDevToolsClient):
249         * DumpRenderTree/chromium/TestShell.cpp:
250         (TestShell::TestShell):
251         * DumpRenderTree/chromium/WebViewHost.cpp:
252         (WebViewHost::postAccessibilityNotification):
253         (WebViewHost::WebViewHost):
254
255 2010-09-29  Chris Fleizach  <cfleizach@apple.com>
256
257         Reviewed by Darin Adler.
258
259         AX: implement CSS3 Speech "speak"
260         https://bugs.webkit.org/show_bug.cgi?id=46827
261
262         * DumpRenderTree/AccessibilityUIElement.cpp:
263         (speakCallback):
264         (AccessibilityUIElement::speak):
265         (AccessibilityUIElement::getJSClass):
266         * DumpRenderTree/AccessibilityUIElement.h:
267         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
268         (AccessibilityUIElement::speak):
269
270 2010-09-29  Mihai Parparita  <mihaip@chromium.org>
271
272         Reviewed by Adam Barth.
273
274         Record bot ID when updating queue status
275         https://bugs.webkit.org/show_bug.cgi?id=46764
276         
277         Since we now have multiple bots handling patches from the commit queue,
278         we need to differentiate status updates from them, so that we can group
279         the queue status page in a less confusing way.
280
281         * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
282         * QueueStatusServer/model/queuestatus.py: Add bot_id property
283         * QueueStatusServer/templates/updatestatus.html: Add bot_id input
284         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
285         * Scripts/webkitpy/common/net/statusserver.py: Add bot_id
286         * Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
287         * Scripts/webkitpy/tool/main.py: Add --bot-id
288         * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
289
290 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
291
292         No review.
293         
294         References always refert to a file in .xht format, even
295         for HTML tests, so fix their loading.
296
297         * CSSTestSuiteHarness/harness/harness.js:
298         (TestSuite.prototype.loadRef):
299
300 2010-09-28  Johnny Ding  <jnd@chromium.org>
301
302         Reviewed by Adam Barth.
303
304         https://bugs.webkit.org/show_bug.cgi?id=41292
305         Add a new parameter to the test plugin to allow specifying a script 
306         and a mouse/keyboard event. The specified script will be evaluated
307         in the browser when the specified event is received by the plugin.
308
309         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
310         (pluginAllocate):
311         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
312         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
313         (NPP_New):
314         (handleEventCarbon):
315         (handleEventCocoa):
316
317 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
318
319         Fix export by adding missing argument.
320
321         * CSSTestSuiteHarness/harness/harness.js:
322         (TestSuite.prototype.showResultsForAllTests):
323
324 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
325
326         [wx] Build fix, add missing import.
327
328         * wx/packaging/build-win-installer.py:
329
330 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
331
332         No review
333         
334         Show which tests have been run by dimming them out in the test list.
335         
336         Adjust some element sizes.
337         
338         * CSSTestSuiteHarness/harness/harness.css:
339         (#test-list > option.untested):
340         (#test-list > option.completed):
341         (#output):
342         (.output-options):
343         * CSSTestSuiteHarness/harness/harness.js:
344         (Test):
345         (TestSuite.prototype.fillTestList):
346         (TestSuite.prototype.updateTestList):
347         (TestSuite.prototype.setSelectedChapter):
348         (TestSuite.prototype.recordResult):
349         (TestSuite.prototype.markTestCompleted):
350         (TestSuite.prototype.testCompletionStateChanged):
351         (TestSuite.prototype.loadTestStatus):
352
353 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
354
355         No review.
356         
357         Implement export of various queries on the test database, sharing
358         code with that which displays results inline.
359
360         * CSSTestSuiteHarness/harness/harness.js:
361         ():
362         (TestSuite.prototype.exportResultsCompletion.var):
363         (TestSuite.prototype.exportResultsCompletion):
364         (TestSuite.prototype.showResultsForCompletedTests):
365         (TestSuite.prototype.exportResultsForCompletedTests):
366         (TestSuite.prototype.showResultsForAllTests):
367         (TestSuite.prototype.exportResultsForAllTests):
368         (TestSuite.prototype.exportResultsForTestsNotRun):
369         (TestSuite.prototype.exportResultsForTestsWithStatus):
370         (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
371
372 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
373
374         No review.
375
376         Work around uncertainty about the order of database
377         transactions when creating the database, so that we don't
378         try to query the table before it has been created.
379
380         * CSSTestSuiteHarness/harness/harness.js:
381         (TestSuite):
382         (TestSuite.prototype.databaseCreated):
383         (TestSuite.prototype.storeTestResult):
384         (TestSuite.prototype.populateDatabaseFromTestInfoData):
385         (TestSuite.prototype.queryDatabaseForTestsWithStatus):
386         (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
387         (TestSuite.prototype.queryDatabaseForCompletedTests):
388         (TestSuite.prototype.queryDatabaseForTestsNotRun):
389
390 2010-09-28  Tony Chang  <tony@chromium.org>
391
392         Reviewed by Eric Seidel.
393
394         add python keyring support to webkit-patch
395         https://bugs.webkit.org/show_bug.cgi?id=41269
396
397         * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
398             the python keyring module
399         * Scripts/webkitpy/common/net/credentials_unittest.py:
400         * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
401         * Scripts/webkitpy/common/system/user_unittest.py:
402         * Scripts/webkitpy/tool/mocktool.py:
403
404 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
405
406         Reviewed by Gustavo Noronha Silva.
407
408         [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
409         https://bugs.webkit.org/show_bug.cgi?id=46740
410
411         * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
412         fonts which can be used to fully test FontConfig rendering settings.
413
414 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
415
416         Reviewed by Gustavo Noronha Silva.
417
418         [gtk] Fedora has a different path for the liberation fonts
419         https://bugs.webkit.org/show_bug.cgi?id=46709
420
421         When searching for DRT fonts, also look in the path where those fonts
422         are commonly found on Fedora systems.
423
424         * DumpRenderTree/gtk/DumpRenderTree.cpp:
425         (initializeFonts): Include logic for looking for Fedora-style font paths.
426
427 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
428
429         Reviewed by Andreas Kling.
430
431         run-webkit-tests needs an updated list of directories with webgl tests
432         https://bugs.webkit.org/show_bug.cgi?id=46747
433
434         Update the list of directories containing WebGL tests and a unit test
435         which depends on this list.
436
437         * Scripts/old-run-webkit-tests: Update the list of directories.
438         * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
439         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
440
441 2010-09-28  Adam Barth  <abarth@webkit.org>
442
443         Reviewed by Eric Seidel.
444
445         Introduce FailureMap to summaries the failures status of all the bots
446         https://bugs.webkit.org/show_bug.cgi?id=46700
447
448         This patch gives the SheriffBot a handle on the list of failing tests.
449
450         * Scripts/webkitpy/common/net/buildbot.py:
451         * Scripts/webkitpy/common/net/failuremap.py: Added.
452         * Scripts/webkitpy/tool/commands/queries.py:
453         * Scripts/webkitpy/tool/commands/sheriffbot.py:
454         * Scripts/webkitpy/tool/mocktool.py:
455
456 2010-09-28  Adam Roben  <aroben@apple.com>
457
458         Update for the addition of WKPageUIClient::didNotHandleKeyEvent
459
460         Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
461         tell a WebKit2 client application that a key event was not handled
462
463         Reviewed by Kenneth Rohde Christiansen and Sam Weinig.
464
465         * MiniBrowser/mac/BrowserWindowController.m:
466         (-[BrowserWindowController awakeFromNib]):
467         * MiniBrowser/win/BrowserView.cpp:
468         (BrowserView::create):
469         * WebKitTestRunner/TestController.cpp:
470         (WTR::createOtherPage):
471         (WTR::TestController::initialize):
472
473 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
474
475         Unreviewed.
476
477         Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
478         for the test order, but instead use information from testinfo.data.
479         
480         * CSSTestSuiteHarness/harness/harness.html:
481         * CSSTestSuiteHarness/harness/harness.js:
482
483 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
484
485         [wx] Build fix, don't try to get the svn revision from the git repo when packaging,
486         it causes the process to hang on the gitorious repo.
487
488         * wx/packaging/build-mac-installer.py:
489         * wx/packaging/build-win-installer.py:
490
491 2010-09-28  Adam Roben  <aroben@apple.com>
492
493         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
494         called
495
496         Reviewed by Anders Carlsson.
497
498         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
499         Full-page Adobe Reader does not paint until window is resized
500
501         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
502         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
503         this level.
504
505         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
506         NPP_SetWindow.
507
508         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
509         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
510         the plugin's HWND has a non-zero size and that its size/position
511         matches that specified in the NPWindow.
512
513         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
514         (NPP_SetWindow): Call through to the PluginTest.
515
516         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
517         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
518         the files as it saw fit.
519
520 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
521
522         Reviewed by Andreas Kling.
523
524         [Qt] Remove support for Qt 4.5
525         https://bugs.webkit.org/show_bug.cgi?id=46718
526
527         Remove the code for versions of Qt prior to 4.6.
528
529         * DumpRenderTree/qt/EventSenderQt.cpp:
530         (EventSender::addTouchPoint):
531         (EventSender::updateTouchPoint):
532         (EventSender::setTouchModifier):
533         (EventSender::touchStart):
534         (EventSender::touchMove):
535         (EventSender::touchEnd):
536         (EventSender::clearTouchPoints):
537         (EventSender::releaseTouchPoint):
538         (EventSender::sendTouchEvent):
539         * DumpRenderTree/qt/EventSenderQt.h:
540         * DumpRenderTree/qt/TextInputControllerQt.cpp:
541         (TextInputController::setMarkedText):
542         * QtTestBrowser/launcherwindow.cpp:
543         (LauncherWindow::LauncherWindow):
544         (LauncherWindow::initializeView):
545         (LauncherWindow::createChrome):
546         (LauncherWindow::sendTouchEvent):
547         (LauncherWindow::eventFilter):
548         (LauncherWindow::applyZoom):
549         (LauncherWindow::setTouchMocking):
550         * QtTestBrowser/launcherwindow.h:
551         * QtTestBrowser/utils.cpp:
552         (urlFromUserInput):
553         * QtTestBrowser/webview.cpp:
554         (WebViewGraphicsBased::animatedFlip):
555         (WebViewGraphicsBased::animatedYFlip):
556         * QtTestBrowser/webview.h:
557         (WebViewGraphicsBased::setYRotation):
558
559 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
560
561         Reviewed by Andreas Kling.
562
563         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
564         which should point to wcecompat installation. Needs wcecompat
565         library from http://github.com/mauricek/wcecompat .
566
567         * DumpRenderTree/qt/DumpRenderTree.pro:
568         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
569         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
570
571 2010-09-28  Daniel Bates  <dbates@rim.com>
572
573         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
574         <https://bugs.webkit.org/show_bug.cgi?id=39136>
575
576         Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
577         In particular, this change caused Sheriffbot to raise an exception when
578         trying to parse the bug id on a bug page. We need to look into this
579         some more.
580
581         * Scripts/webkitpy/common/net/bugzilla.py:
582         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
583         * Scripts/webkitpy/tool/bot/sheriff.py:
584         * Scripts/webkitpy/tool/commands/download.py:
585         * Scripts/webkitpy/tool/commands/queues.py:
586         * Scripts/webkitpy/tool/commands/upload.py:
587         * Scripts/webkitpy/tool/steps/closebug.py:
588         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
589         * Scripts/webkitpy/tool/steps/preparechangelog.py:
590         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
591
592 2010-09-28  Adam Barth  <abarth@webkit.org>
593
594         Reviewed by Eric Seidel.
595
596         Move RegressionWindow further up the dependency chain
597         https://bugs.webkit.org/show_bug.cgi?id=46698
598
599         Baby steps towards pushing this information into bug posts.
600
601         * Scripts/webkitpy/common/net/buildbot.py:
602         * Scripts/webkitpy/common/net/buildbot_unittest.py:
603         * Scripts/webkitpy/common/net/regressionwindow.py:
604         * Scripts/webkitpy/tool/commands/queries.py:
605
606 2010-09-27  Daniel Bates  <dbates@rim.com>
607
608         Reviewed by Adam Barth.
609
610         sheriffbot can't roll out security patches
611         https://bugs.webkit.org/show_bug.cgi?id=39136
612
613         Make SheriffBot determine if it's authorized to view a bug
614         whose change it wants to rollout before it tries to rollout
615         the change.
616
617         Moreover, make both webkit-patch and Sheriffbot provide human-
618         readable error messages when they are not authorized to view
619         a bug and when a bug number is invalid.
620
621         Currently, Sheriffbot does not parse Bugzilla bugs for
622         <bug error="...">, which indicates an error when retrieving
623         a bug. In particular, error="NotPermitted" if a person (or bot)
624         is not authorized to view a bug. For such error="NotPermitted" bugs,
625         Sheriffbot raises an exception when parsing the bug report and
626         this exception does not explicitly indicate Sheriffbot's lack
627         of authorization. Instead, Sheriffbot should explicitly check
628         for the presence <bug error="..."> before operating on a bug
629         and error with a human-readable message if it's not permitted
630         to view it.
631
632         * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
633         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
634           - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
635           - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
636           - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
637         * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
638         * Scripts/webkitpy/tool/commands/download.py: Ditto.
639         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
640         * Scripts/webkitpy/tool/commands/upload.py: Ditto.
641         * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
642         * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
643         * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
644         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
645
646 2010-09-27  Adam Barth  <abarth@webkit.org>
647
648         Reviewed by Eric Seidel.
649
650         Expose more more failure information from Buildbot to SheriffBot
651         https://bugs.webkit.org/show_bug.cgi?id=46697
652
653         This patch moves the information about what tests failured closer to
654         SheriffBot.  There are still a couple more patches to go before
655         SheriffBot can post this information to bugs, but this is a step in
656         that direction.  Yay for unit tests, which caught some bugs in earlier
657         versions of this patch.
658
659         * Scripts/webkitpy/common/net/buildbot.py:
660         * Scripts/webkitpy/common/net/buildbot_unittest.py:
661         * Scripts/webkitpy/common/net/regressionwindow.py: Added.
662         * Scripts/webkitpy/tool/commands/queries.py:
663
664 2010-09-27  Eric Seidel  <eric@webkit.org>
665
666         Unreviewed.  Fixing 500 error seen in the status server.
667
668         It turns out that a = b = []; b.append(1); then a[0] will be 1!
669         This should have been obvious to me, I guess, but it was not what I was expecting.
670
671         * QueueStatusServer/model/activeworkitems.py:
672
673 2010-09-27  Adam Barth  <abarth@webkit.org>
674
675         Reviewed by Eric Seidel.
676
677         commit-queue should reject patches that fail to land
678         https://bugs.webkit.org/show_bug.cgi?id=46694
679
680         This can happen, for example, if there's no reviewer.  Without this
681         patch, we'll keep retrying the patch.
682
683         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
684         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
685
686 2010-09-27  Simon Fraser  <simon.fraser@apple.com>
687
688         Rubber-stamped by Adele Peterson.
689
690         Add a harness for running the CSS 2.1 test suite.
691         
692         This harness assumes that you've got a local a copy of the suite
693         adjacent to the 'harness' directory.
694         
695         The harness lets you go through the tests in chapter order,
696         denoting pass/fail/skipped for each test.
697         
698         It uses a client-side database to store the results of testing.
699
700         * CSSTestSuiteHarness/harness/harness.css: Added.
701         * CSSTestSuiteHarness/harness/harness.html: Added.
702         * CSSTestSuiteHarness/harness/harness.js: Added.
703
704 2010-09-27  Eric Seidel  <eric@webkit.org>
705
706         Reviewed by Adam Barth.
707
708         Patch locks should expire if a patch is marked for retry
709         https://bugs.webkit.org/show_bug.cgi?id=46682
710
711         This was part Adam's original CommitQueueTask design,
712         but support for it was missing from the server.
713         I added the support, but triggering lock-release based on this
714         special "retry" status feels a bit strange so I added a FIXME.
715
716         I also changed the text in queuestatus.html to say "Lock Acquired"
717         since "Last Activity" isn't really true.  We only update the lock
718         date when the patch is started, not on every status update.
719
720         I also noticed an exception in next-patch, which I fixed by re-writing
721         the unzip logic in activeworkitems.py again.
722
723         * QueueStatusServer/handlers/updatestatus.py:
724         * QueueStatusServer/model/activeworkitems.py:
725         * QueueStatusServer/templates/queuestatus.html:
726
727 2010-09-27  Tony Chang  <tony@chromium.org>
728
729         Reviewed by David Levin.
730
731         [chromium] fix a warning when compiling DRT on 32-bit linux
732         https://bugs.webkit.org/show_bug.cgi?id=46641
733
734         * DumpRenderTree/chromium/TestEventPrinter.cpp:
735         (DRTPrinter::handleImage):
736
737 2010-09-27  Eric Seidel  <eric@webkit.org>
738
739         Reviewed by Adam Barth.
740
741         queue-status should report when the patch was last locked to a queue
742         https://bugs.webkit.org/show_bug.cgi?id=46674
743
744         This isn't necessarily the best way to expose this information
745         but having this accessible via the web interface is very
746         useful until we come up with a nicer way to display this.
747
748         I also cleaned up the code in activeworkitems.py a little
749         to use list comprehensions and to have the code work with
750         pairs instead of two lists at once.  Eventually I think those
751         item/time pairs need to be their own little helper class.
752
753         * QueueStatusServer/handlers/queuestatus.py:
754         * QueueStatusServer/model/activeworkitems.py:
755         * QueueStatusServer/templates/queuestatus.html:
756
757 2010-09-27  Tony Chang  <tony@chromium.org>
758
759         Reviewed by David Levin.
760
761         [chromium] fix detection of missing fonts on DRT
762         https://bugs.webkit.org/show_bug.cgi?id=46651
763
764         * DumpRenderTree/chromium/TestShellGtk.cpp:
765         (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
766
767 2010-09-27  Tony Chang  <tony@chromium.org>
768
769         Reviewed by Dimitri Glazkov.
770
771         add webkit unit tests to the chromium testers
772         https://bugs.webkit.org/show_bug.cgi?id=46669
773
774         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
775         * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
776
777 2010-09-27  Kwang Yul Seo  <skyul@company100.net>
778
779         Unreviewed.
780
781         Adding myself to the committers list.
782
783         * Scripts/webkitpy/common/config/committers.py:
784
785 2010-09-27  Mihai Parparita  <mihaip@chromium.org>
786
787         Reviewed by Eric Seidel.
788
789         webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
790         https://bugs.webkit.org/show_bug.cgi?id=46634
791         
792         Use OutputCapture to prevent console spam (and also check for expected
793         output).
794
795         * Scripts/webkitpy/common/system/user_unittest.py:
796
797 2010-09-27  Eric Seidel  <eric@webkit.org>
798
799         Reviewed by James Robinson.
800
801         start-commit-queue should abort any rebases in progress
802         https://bugs.webkit.org/show_bug.cgi?id=46640
803
804         webkit-patch commit-queue would do this itself, but this just
805         helps ensure that the commit-queue script is properly updated
806         before we run it (in the case where a previous rebase is in
807         progress the git svn rebase would not work before we run the
808         commit-queue).
809
810         * EWSTools/start-commit-queue.sh:
811
812 2010-09-18  Martin Robinson  <mrobinson@igalia.com>
813
814         Reviewed by Gustavo Noronha Silva.
815
816         [GTK] Clean up the DRT fonts.conf and switch to Liberation
817         https://bugs.webkit.org/show_bug.cgi?id=46038
818
819         Switch to Liberation fonts for GTK+ layout tests. This will make our
820         test results metric-compatible with many Windows/Chromium results. It
821         also simplifies the fonts.conf that we load and prepares the way for
822         fixing many font bugs.
823
824         * DumpRenderTree/gtk/DumpRenderTree.cpp:
825         (initializeFonts): Initialize a known list of fonts instead of loading
826         every font in the WEBKIT_TESTFONTS directory.
827         * DumpRenderTree/gtk/fonts.conf: Removed.
828         * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
829         * DumpRenderTree/gtk/fonts/fonts.conf: Added.
830         * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
831         we can load both fonts.conf and AHEM____.TTF from this location.
832         * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
833         it is no longer used.
834
835 2010-09-26  Mihai Parparita  <mihaip@chromium.org>
836
837         Reviewed by Ojan Vafai.
838
839         new-run-webkit-httpd fails if Perl is not installed
840         https://bugs.webkit.org/show_bug.cgi?id=46602
841         
842         Make Port._read_configuration catch all exceptions, since trying to run
843         perl (because of _webkit_build_directory) when it's not installed throws
844         a WindowsError or OSError, not an IOError (this became an issue after 
845         r68268, since ChromiumPort ends up calling Port.default_configuration in
846         its constructor, which means that we're ending up on this codepath in
847         non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
848         new-run-webkit-httpd).
849
850         * Scripts/webkitpy/layout_tests/port/base.py:
851         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
852
853 2010-09-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
854
855         Reviewed by Antonio Gomes.
856
857         [EFL] Add setting API to set a local storage database path.
858         https://bugs.webkit.org/show_bug.cgi?id=45446
859
860         Add a setting API to set local storage database path.
861
862         * EWebLauncher/main.c:
863         (on_key_down):
864         (browserCreate):
865         (main):
866
867 2010-09-26  Sam Weinig  <sam@webkit.org>
868
869         Reviewed by Anders Carlsson.
870
871         Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
872         https://bugs.webkit.org/show_bug.cgi?id=46587
873
874         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
875
876 2010-09-26  Antonio Gomes  <agomes@rim.com>
877
878         Reviewed by Kenneth Rohde Christiansen.
879
880         DRT/Mac nodesFromRect support
881
882         [Mac][DRT] Implement LayoutTestController::nodesFromRect
883         https://bugs.webkit.org/show_bug.cgi?id=46580
884
885         Implements LayoutTestController::nodesFromRect for Mac DRT, and
886         adding stubs for GTK+ and Windows.
887
888         * DumpRenderTree/LayoutTestController.cpp:
889         (nodesFromRectCallback):
890         (LayoutTestController::staticFunctions):
891         * DumpRenderTree/LayoutTestController.h:
892         (LayoutTestController::LayoutTestController::nodesFromRect):
893         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
894         (LayoutTestController::nodesFromRect):
895
896 2010-09-25  Nicolas Weber  <thakis@chromium.org>
897
898         Reviewed by Adam Barth.
899
900         https://bugs.webkit.org/show_bug.cgi?id=46555
901         Fix typo in prepare-ChangeLog's help output.
902
903         * Scripts/prepare-ChangeLog:
904
905 2010-09-24  Sam Weinig  <sam@webkit.org>
906
907         Reviewed by Darin Adler.
908
909         Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
910         <rdar://problem/8359279>
911         https://bugs.webkit.org/show_bug.cgi?id=46546
912
913         * MiniBrowser/mac/BrowserWindowController.m:
914         (mouseDidMoveOverElement):
915         (-[BrowserWindowController awakeFromNib]):
916         * MiniBrowser/win/BrowserView.cpp:
917         (mouseDidMoveOverElement):
918         (BrowserView::create):
919         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
920         (WTR::InjectedBundlePage::InjectedBundlePage):
921         * WebKitTestRunner/TestController.cpp:
922         (WTR::createOtherPage):
923         (WTR::TestController::initialize):
924
925 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
926
927         Reviewed by Adam Barth.
928
929         Allow rebaselines for webkit-patch rebaseline to be chosen
930         https://bugs.webkit.org/show_bug.cgi?id=46407
931         
932         Instead of always rebaselining all failing tests, allow a subset to be
933         chosen.
934
935         * Scripts/webkitpy/common/system/user.py:
936         * Scripts/webkitpy/tool/commands/rebaseline.py:
937
938 2010-09-24  Ryosuke Niwa  <rniwa@webkit.org>
939
940         Reviewed by Tony Chang.
941
942         [chromium] Implement TextInputController::firstRectForCharacterRange
943         https://bugs.webkit.org/show_bug.cgi?id=38100
944
945         Implemented TextInputController::firstRectForCharacterRange for chromium platform.
946         No new tests are added since we need to implement the same feature in chromium side
947         in order to enable any tests that uses this function.
948
949         * DumpRenderTree/chromium/TextInputController.cpp:
950         (TextInputController::firstRectForCharacterRange): Added.
951
952 2010-09-24  Adam Barth  <abarth@webkit.org>
953
954         Reviewed by Eric Seidel.
955
956         commit-queue reports land failures as "PASS"
957         https://bugs.webkit.org/show_bug.cgi?id=46530
958
959         We were ignoring the return value of land instead of passing it back to
960         CommitQueue.  Of course, this was the one case I forgot to test!
961
962         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
963         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
964
965 2010-09-24  Kenichi Ishibashi  <bashi@google.com>
966
967         Reviewed by Eric Seidel.
968
969         new-run-webkit-tests prints out nothing when build-dumprendertree fails
970         https://bugs.webkit.org/show_bug.cgi?id=37563
971
972         Print error message when build-dumprendertree fails.
973
974         * Scripts/webkitpy/layout_tests/port/webkit.py:
975         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
976
977 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
978
979         Reviewed by Tony Chang.
980
981         NRWT doesn't respect config set with set-webkit-configuration
982         https://bugs.webkit.org/show_bug.cgi?id=46278
983         
984         Use Port.default_configuration() instead of hardcoding Release in
985         ChromiumPort configuration initialization, so that we still inherit the
986         configuration set by set-webkit-configuration.
987
988         * Scripts/webkitpy/layout_tests/port/chromium.py:
989         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
990
991 2010-09-24  Chang Shu  <chang.shu@nokia.com>
992
993         Reviewed by Csaba Osztrogonác.
994
995         [Qt] Fix the code to check file existence.
996         https://bugs.webkit.org/show_bug.cgi?id=46465
997
998         * QtTestBrowser/main.cpp:
999         (main):
1000
1001 2010-09-23  Tony Chang  <tony@chromium.org>
1002
1003         Unreviewed, rolling out r68232.
1004         http://trac.webkit.org/changeset/68232
1005
1006         Broken NRWT on the canary bots.
1007
1008         * Scripts/webkitpy/layout_tests/port/chromium.py:
1009
1010 2010-09-23  Dirk Pranke  <dpranke@chromium.org>
1011
1012         Unreviewed, build fix.
1013
1014         r68008 broke new-run-webkit-tests in that the chromium ports no
1015         longer respect set-webkit-configuration. The correct fix for this
1016         is being pursued in bug 46278 (along with a bunch of unit tests),
1017         but in the meantime I'm reverting the particular lines that broke
1018         things. This was tested by hand.
1019
1020         * Scripts/webkitpy/layout_tests/port/chromium.py:
1021
1022 2010-09-23  Sam Weinig  <sam@webkit.org>
1023
1024         Reviewed by Anders Carlsson.
1025
1026         WebKit2 API: Need way to know when a frame is removed from the hierarchy
1027         <rdar://problem/8414062>
1028         https://bugs.webkit.org/show_bug.cgi?id=46432
1029
1030         * MiniBrowser/mac/BrowserWindowController.m:
1031         (didRemoveFrameFromHierarchy):
1032         (-[BrowserWindowController awakeFromNib]):
1033         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1034         (WTR::InjectedBundlePage::InjectedBundlePage):
1035         * WebKitTestRunner/TestController.cpp:
1036         (WTR::TestController::initialize):
1037
1038 2010-09-23  Tony Chang  <tony@chromium.org>
1039
1040         Reviewed by Dimitri Glazkov.
1041
1042         [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
1043         https://bugs.webkit.org/show_bug.cgi?id=46426
1044
1045         * DumpRenderTree/chromium/LayoutTestController.cpp:
1046         (LayoutTestController::LayoutTestController):
1047         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1048         * DumpRenderTree/chromium/LayoutTestController.h:
1049
1050 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
1051
1052         Reviewed by Nate Chapin.
1053
1054         [GTK] r68199 introduced two test failures
1055         https://bugs.webkit.org/show_bug.cgi?id=46424
1056
1057         Fix a regression handling preference overrides that are attached to boolean properties.
1058
1059         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1060         (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
1061         so we must check for that when converting a string to a boolean.
1062
1063 2010-09-23  Dimitri Glazkov  <dglazkov@chromium.org>
1064
1065         Reviewed by David Levin.
1066
1067         Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
1068         https://bugs.webkit.org/show_bug.cgi?id=46406
1069
1070         This breaks when the method is called with specified size of data (image data), and the
1071         buffer hasn't yet reached this size.
1072
1073         * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
1074           index larger than 0.
1075
1076 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
1077
1078         Reviewed by Nate Chapin.
1079
1080         [GTK] Some tests from r68174 fail on the GTK+ bots
1081         https://bugs.webkit.org/show_bug.cgi?id=46396
1082
1083         Simplify LayoutTestController::overridePreference to make it easier for
1084         people unfamiliar with the code to keep the list of preferences up to date.
1085         Add the conversion for enable-hyperlink-auditing.
1086
1087         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1088         (LayoutTestController::overridePreference): Use a simple if-else block to determine
1089         out the property name for overrridePreference. Also simplify the logic for setting
1090         string properties. Add the conversion for enable-hyperlink-auditing.
1091
1092 2010-09-23  Tony Chang  <tony@chromium.org>
1093
1094         Reviewed by David Levin.
1095
1096         [chromium] add caretBrowsingEnabled to WebSettings and DRT
1097         https://bugs.webkit.org/show_bug.cgi?id=46388
1098
1099         * DumpRenderTree/chromium/LayoutTestController.cpp:
1100         (LayoutTestController::overridePreference):
1101         * DumpRenderTree/chromium/WebPreferences.cpp:
1102         (WebPreferences::reset):
1103         (WebPreferences::applyTo):
1104         * DumpRenderTree/chromium/WebPreferences.h:
1105
1106 2010-09-23  Nate Chapin  <japhet@chromium.org>
1107
1108         Reviewed by Darin Fisher.
1109
1110         Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
1111         https://bugs.webkit.org/show_bug.cgi?id=30458
1112
1113         * DumpRenderTree/chromium/LayoutTestController.cpp:
1114         (LayoutTestController::overridePreference):
1115         * DumpRenderTree/chromium/WebPreferences.cpp:
1116         (WebPreferences::reset):
1117         (WebPreferences::applyTo):
1118         * DumpRenderTree/chromium/WebPreferences.h:
1119         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1120         (resetDefaultsToConsistentValues):
1121         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1122         (LayoutTestController::overridePreference):
1123
1124 2010-09-21  Stephen White  <senorblanco@chromium.org>
1125
1126         Reviewed by David Levin.
1127
1128         Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
1129         https://bugs.webkit.org/show_bug.cgi?id=46208
1130
1131         This flag allows the layout tests to be run with or without accelerated
1132         2D canvas rendering.
1133
1134         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1135         (main):
1136         Declare the new flag string, and check for it on startup.
1137         * DumpRenderTree/chromium/TestShell.cpp:
1138         (TestShell::TestShell):
1139         Add a boolean for the new flag, in order to preserve its value over
1140         preferences reset.
1141         (TestShell::resetWebSettings):
1142         Set the new flag to the stored value on reset.
1143         * DumpRenderTree/chromium/TestShell.h:
1144         (TestShell::setAccelerated2dCanvasEnabled):
1145         Add an accessor for the new flag.
1146         * DumpRenderTree/chromium/WebPreferences.cpp:
1147         (WebPreferences::reset):
1148         Initialize the new flag to false.
1149         (WebPreferences::applyTo):
1150         Copy the flag's value to the WebSettings.
1151         * DumpRenderTree/chromium/WebPreferences.h:
1152         Add the new flag.
1153
1154 2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1155
1156         Reviewed by Simon Hausmann.
1157
1158         [Qt] Refactor QtWebKitPlatformPlugin interface
1159
1160         Make it easier to keep source-compability for the
1161         QtWebKitPlatformPlugin interface, and run qmake
1162         on the example (but not build) for convenience. 
1163
1164         https://bugs.webkit.org/show_bug.cgi?id=46345
1165
1166         * Scripts/webkitdirs.pm:
1167
1168 2010-09-23  Adam Barth  <abarth@webkit.org>
1169
1170         Reviewed by Eric Seidel.
1171
1172         Tweak some status messages that Eric thought were confusing
1173         https://bugs.webkit.org/show_bug.cgi?id=46342
1174
1175         * Scripts/webkitpy/tool/commands/queues.py:
1176         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1177
1178 2010-09-22  Adam Barth  <abarth@webkit.org>
1179
1180         Reviewed by Eric Seidel.
1181
1182         Fix comm-queue typo
1183         https://bugs.webkit.org/show_bug.cgi?id=46339
1184
1185         We were missing a "self".  The real problem is that we didn't have an
1186         integration test for the failure case.
1187
1188         * Scripts/webkitpy/tool/commands/queues.py:
1189         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1190
1191 2010-09-22  Adam Barth  <abarth@webkit.org>
1192
1193         Reviewed by Eric Seidel.
1194
1195         commit-queue should log more detailed messages to the QueueStatusServer
1196         https://bugs.webkit.org/show_bug.cgi?id=46333
1197
1198         When I created CommitQueueTask, I removed most of the previous logging.
1199         This patch adds back more detailed logging so folks can see their patch
1200         progress through the queue.
1201
1202         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1203         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1204         * Scripts/webkitpy/tool/commands/queues.py:
1205         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1206
1207 2010-09-22  Mihai Parparita  <mihaip@chromium.org>
1208
1209         Reviewed by Darin Fisher.
1210
1211         [Chromium] User style layout tests don't pass on Chromium
1212         https://bugs.webkit.org/show_bug.cgi?id=46069
1213
1214         Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
1215         crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
1216         behavior from other ports.
1217
1218         * DumpRenderTree/chromium/LayoutTestController.cpp:
1219         (LayoutTestController::addUserStyleSheet):
1220
1221 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
1222
1223         Reviewed by Martin Robinson.
1224
1225         [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
1226         https://bugs.webkit.org/show_bug.cgi?id=46303.
1227
1228         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
1229         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
1230         CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
1231         property sheet.
1232         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
1233         * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
1234         appropriate property sheet for the build types.
1235         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
1236         configuration to use appropriate property sheet for CoreFoundation
1237         and CFLite-style builds.
1238
1239 2010-09-22  Adam Barth  <abarth@webkit.org>
1240
1241         Reviewed by Eric Seidel.
1242
1243         Optimize commit-queue performance for green trees
1244         https://bugs.webkit.org/show_bug.cgi?id=46254
1245
1246         This patch redesigns the controller logic for the commit-queue.  In the
1247         new design, the controller exercises much finer-grained control over
1248         the landing process.  In particular:
1249
1250         - Patches that fail to apply now get rejected almost immediately.
1251         - Patches that fail to build get rejects after two builds (instead of
1252           three builds and one test run).
1253         - Patches that run into a flaky test now get accepted after one build
1254           and two test runs instead of three full build-and-test runs.
1255
1256         The main cost of these optimizations is that we don't find out the tree
1257         has a failing test until the very end of the process, but if the tree
1258         has a busted test, there's not much we can do anyway.  We might as well
1259         burn commit-queue resources spinning optimisticly.
1260
1261         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
1262         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
1263         * Scripts/webkitpy/tool/commands/queues.py:
1264
1265 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
1266
1267         Reviewed by Martin Robinson.
1268
1269         [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
1270         https://bugs.webkit.org/show_bug.cgi?id=46303.
1271
1272         * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
1273         for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
1274         WinCairo build.
1275         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
1276         * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
1277         build targets that use the new InjectedBundleCFLite.vsprops file.
1278
1279 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
1280
1281         Unreviewed, build fix.
1282
1283         Fix bustage of rebaseline-chromium-webkit-tests resulting from
1284         r67974. Really need better unit tests for this tool :(
1285
1286         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1287
1288 2010-09-22  Adam Roben  <aroben@apple.com>
1289
1290         Unbreak test-webkitpy
1291
1292         * Scripts/webkitpy/test/main.py:
1293         (Tester.run_tests): Add a line that mysteriously got deleted.
1294
1295 2010-09-22  Adam Roben  <aroben@apple.com>
1296
1297         Make test-webkitpy test WebKit2's scripts
1298
1299         These scripts can't be in WebKitTools due to limitations of Apple's
1300         build process. But that doesn't mean we can't test them!
1301
1302         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
1303         WebKit2/Scripts
1304
1305         Reviewed by Adam Barth.
1306
1307         * Scripts/test-webkitpy:
1308         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
1309         Now takes an external_package_paths parameter and cleans both webkitpy
1310         and any external packages.
1311         (init): Added an external_package_paths parameter which we pass along
1312         to _clean_packages_with_test.
1313         (top level): Add WebKit2/Scripts/webkit2 as our only external package
1314         and pass it along to init and Tester.run_tests.
1315
1316         * Scripts/webkitpy/test/main.py:
1317         (Tester.run_tests): Added an optional external_package_paths
1318         parameter. We modify sys.path so that the external packages can be
1319         imported, and search for unittest files inside all external packages
1320         in addition to inside webkitpy.
1321
1322 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
1323
1324         Reviewed by Tony Chang.
1325
1326         new-run-webkit-tests: r68063 broke linux python tests
1327
1328         Add a missing "from __future__ import with_statement" to this
1329         new file; the perils of testing only on the Mac and by review :(
1330
1331         https://bugs.webkit.org/show_bug.cgi?id=46293
1332
1333         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1334
1335 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
1336
1337         Reviewed by Tony Chang.
1338
1339         Add a 'chromium-gpu' set of ports that will test the accelerated
1340         GPU paths. This patch adds:
1341
1342         - support for the '--accelerated-compositing' and
1343           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
1344           'no-' flags)
1345         - adds a new set of Ports that will look under
1346           platform/chromium-gpu-$OS/ for baselines before looking in the
1347           regular chromium search path
1348         - adds a new test_expectations.txt file in platform/chromium-gpu
1349           that skips all but the tests we actually want to run with
1350           acceleration.
1351
1352         This patch will allow us to run both with and without acceleration
1353         and to change the defaults for both the regular and -gpu options
1354         as the code evolves.
1355
1356         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
1357         each test bot.
1358
1359         https://bugs.webkit.org/show_bug.cgi?id=46225
1360
1361         * Scripts/webkitpy/layout_tests/port/chromium.py:
1362         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1363         * Scripts/webkitpy/layout_tests/port/factory.py:
1364         * Scripts/webkitpy/layout_tests/port/webkit.py:
1365
1366 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
1367
1368         Reviewed by Kenneth Rohde Christiansen.
1369
1370         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
1371         https://bugs.webkit.org/show_bug.cgi?id=43988
1372
1373         Runs a web debug server on port specified by QtTestBrowser
1374         argument -remote-inspector-port. Property
1375         _q_webInspectorServerPort of the QWebPage instance will be set
1376         according to the argument. All pages with that property set will
1377         be remotely inspectable.
1378
1379         URL for remote inspection of first QWebPage is
1380             http://localhost:9222/webkit/inspector/inspector.html?page=1
1381         where 1 is the number of the QWebPage instance.
1382
1383         The base URL yields an index page with links to the individual inspectors:
1384             http://localhost:9222/
1385
1386         * QtTestBrowser/launcherwindow.cpp:
1387         (LauncherWindow::init):
1388         * QtTestBrowser/launcherwindow.h:
1389         * QtTestBrowser/main.cpp:
1390         (LauncherApplication::handleUserOptions):
1391
1392 2010-09-22  Adam Roben  <aroben@apple.com>
1393
1394         Fix webkit-patch failure-reason now that build.webkit.org has been
1395         updated
1396
1397         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
1398         every time
1399
1400         Reviewed by Eric Seidel.
1401
1402         * Scripts/webkitpy/common/net/buildbot.py:
1403         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
1404         looking for an element that contains text, then returns it.
1405         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
1406         text out of the cells. This way it doesn't matter whether the cells
1407         have <b> children (as for cells in directory rows) or not (as for
1408         cells in file rows)
1409         (BuildBot._parse_twisted_directory_listing): Look for rows that have
1410         the "directory" or "file" class, rather than rows with any class,
1411         since header rows now have a class attribute.
1412
1413         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1414         (BuildBotTest._example_directory_listing): Updated to more closely
1415         match the markup that build.webkit.org is producing now.
1416
1417 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
1418
1419         Unreviewed, build fix.
1420
1421         new-run-webkit-tests: fix bug introduced in r68008 where if you
1422         specify --chromium and no --platform, and you're running on
1423         windows, you use the 'chromium-win' port by default instead of the
1424         version-specific port. This breaks the buildbots.
1425
1426         It will be good for this refactoring to settle down so I can
1427         rewrite the logic for default ports and the unit tests to be
1428         clearer (and the testing more comprehensive).
1429
1430         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1431
1432 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
1433
1434         Reviewed by Adam Barth.
1435
1436         Modify the Port interface to take only a series of keyword arguments
1437         in the constructor, and modify Port/factory.get() to accomodate that,
1438         and to accept user=XXX as an argument so we can pass
1439         webkitpy.common.system.user.User objects in.
1440
1441         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
1442         to use the common routine in webkitpy.common.system.user.open_url()
1443         to display HTML files.
1444
1445         There was a routine in the Port interface to do the same thing,
1446         but I see no need for a port-specific hook for this, since it is
1447         something that will always be executed by the host environment
1448         and displaying web pages has nothing to do with running layout tests.
1449
1450         Note that new-run-webkit-tests used to use test_shell to display
1451         the page; this is potentially useful so that you can actually click
1452         from a result to the broken page; however, since DumpRenderTree
1453         doesn't support this functionality, it will be going away eventually.
1454
1455         https://bugs.webkit.org/show_bug.cgi?id=46128
1456
1457         * Scripts/webkitpy/layout_tests/port/base.py:
1458         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1459         * Scripts/webkitpy/layout_tests/port/chromium.py:
1460         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1461         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1462         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1463         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1464         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1465         * Scripts/webkitpy/layout_tests/port/factory.py:
1466         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1467         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1468         * Scripts/webkitpy/layout_tests/port/gtk.py:
1469         * Scripts/webkitpy/layout_tests/port/mac.py:
1470         * Scripts/webkitpy/layout_tests/port/qt.py:
1471         * Scripts/webkitpy/layout_tests/port/test.py:
1472         * Scripts/webkitpy/layout_tests/port/webkit.py:
1473         * Scripts/webkitpy/layout_tests/port/win.py:
1474         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1475         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1476         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1477
1478 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1479
1480         Reviewed by Kenneth Rohde Christiansen.
1481
1482         [EFL] Get fresh theme when running EWebLauncher
1483         https://bugs.webkit.org/show_bug.cgi?id=46210
1484
1485         If user tried to run EWebLauncher outside of the build tree, it would
1486         not find the theme and fallback to the installed one. However, since
1487         EWebLauncher is not installed, we always want to take the theme from
1488         the just compiled source code. If user had never installed WebKit's
1489         EFL port it could even receive a segv since no theme would be found.
1490
1491         Now EWebLauncher does not fallback to the installed theme and CMake
1492         gives as DATA_DIR the directory of the theme it has just built.
1493
1494         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
1495         EWebLauncher.
1496         * EWebLauncher/main.c: Use only the theme from build director. Do not
1497         fallback to others as this could hide real bugs.
1498         (quit):
1499         (browserCreate):
1500         (findThemePath):
1501         (main):
1502
1503 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
1504
1505         Unreviewed, build fix.
1506
1507         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
1508         it just confuses it.
1509
1510         https://bugs.webkit.org/show_bug.cgi?id=46230
1511
1512         * Scripts/webkitpy/layout_tests/port/webkit.py:
1513
1514 2010-09-21  Lucas Forschler  <lforschler@apple.com>
1515
1516         Reviewed by Stephanie Lewis.
1517
1518         Make a new buildbot for Leopard Debug Test
1519
1520         * BuildSlaveSupport/build.webkit.org-config/config.json:
1521
1522 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
1523
1524         Unreviewed, build fix.
1525
1526         Fix breakage of Chromium Mac DRT port caused by r67905.
1527
1528         https://bugs.webkit.org/show_bug.cgi?id=46230
1529
1530         * Scripts/webkitpy/layout_tests/port/webkit.py:
1531
1532 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
1533
1534         Unreviewed, build fix.
1535
1536         Add missing import of 'tempfile'.
1537
1538         * Scripts/webkitpy/layout_tests/port/chromium.py:
1539
1540 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
1541
1542         Reviewed by Ojan Vafai.
1543
1544         new-run-webkit-tests: pull the list of tests from the Port, and
1545            make it possible to run with no actual test files in the filesystem.
1546
1547         This set of changes allows us to delete the special
1548         webkitpy/layout_tests/data directory and test the generic code without
1549         touching the filesystem (except to write results). This speeds up
1550         test-webkitpy substantially.
1551
1552         This also cleans up and removes several code paths in the generic
1553         code and fixes some minor bugs, notably in the test_expectations
1554         parsing, which was previously fragile if the tests weren't present.
1555
1556         We also change the way we diff image results to be able to do so
1557         in memory, without relying on files. This slows down chromium
1558         test_shell, which always writes images to files, but should speed
1559         up DRT and ImageDiff-based implementations slightly.
1560
1561         Note that pulling the list of tests to run from the Port will allow
1562         ports to specify what tests to run as an inclusive list; previously
1563         you could only do this as an exclusive list by using a 
1564         test_expectations file or Skipped files; nothing actually uses this
1565         feature yet and it's unclear if it should be used.
1566
1567         Note that there are no functional changes -- apart from now 
1568         always printing out the location of the checksum file when we are
1569         tracing test runs -- and the total number of lines of non-test code
1570         actually drops by two.
1571
1572         There is some more cleanup that can be done in the Port/Driver 
1573         interface and in some handling of filenames, but I'll save that
1574         for another change.
1575
1576         https://bugs.webkit.org/show_bug.cgi?id=45801
1577
1578         * Scripts/webkitpy/layout_tests/data/*: Removed.
1579             - no longer need special mock layout_tests_directory in the
1580               repository.
1581         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1582             - add code to display missing text files, checksums when tracing
1583             - update to not look at the filesystem directly.
1584         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1585             - add more unit tests
1586         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1587             - remove tests_are_present flag
1588             - update with changes in Port interface - no longer access
1589               the filesystem directly, although we still use os.path for
1590               filename manipulation.
1591         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1592             - add more unit tests
1593         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
1594             - renamed to port/test_files.py
1595         * Scripts/webkitpy/layout_tests/port/base.py:
1596             - change diff_image() to expect actual image data, not filenames
1597             - add expected_checksum(), expected_image(), expected_text() to
1598               return the content of the files so that we don't need a filesystem
1599             - add path_exists(), path_isdir() for filesystem-like access.
1600             - add test_dirs() to keep clobber-test-results from needing to
1601               actually look at a real layout tests dir
1602             - add tests() to return the list of tests to run on the port
1603               (calls port/test_files to do the work).
1604             - add update_baseline() to be able to save new baselines
1605             - add uri_to_test_name() from port/dryrun.py so we can easily check
1606               filename_to_uri()
1607         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1608             - add more unit tests
1609         * Scripts/webkitpy/layout_tests/port/chromium.py:
1610             - change diff_image() to accept image content, not filenames.
1611               This will be slower for test_shell/image_diff, but faster
1612               for DRT/ImageDiff.
1613         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1614             - add more unit tests
1615         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1616             - simplify greatly
1617         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1618             - add more unit tests
1619         * Scripts/webkitpy/layout_tests/port/test.py:
1620             - massive rewrite to use in-script list of tests and expectations
1621         * Scripts/webkitpy/layout_tests/port/test_files.py:
1622             - rename from layout_package/test_files.
1623         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1624             - add unit tests
1625         * Scripts/webkitpy/layout_tests/port/webkit.py:
1626             - update diff_image() to take image contents, not files. Should
1627               make things slightly faster.
1628         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1629             - update with changes to diff_image()
1630         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1631             - update with changes to diff_image()
1632         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1633             - remove tests_are_present from test_expectations
1634             - pull the list of tests from port.tests() instead
1635               of calling test_files.py directly.
1636         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1637             - update unit tests
1638         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1639             - update with changes to 
1640         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1641             - update with change in Port interface
1642         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1643             - update with change in Port interface
1644         * Scripts/webkitpy/style/checkers/test_expectations.py:
1645             - remove the tests_are_present flag
1646
1647 2010-09-21  Anders Carlsson  <andersca@apple.com>
1648
1649         Disable logging.
1650
1651         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
1652
1653 2010-09-21  Tony Chang  <tony@chromium.org>
1654
1655         Reviewed by Kent Tamura.
1656
1657         add a script for running webkit_unit_tests
1658         https://bugs.webkit.org/show_bug.cgi?id=46014
1659
1660         * Scripts/run-chromium-webkit-unit-tests: Added.
1661
1662 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
1663
1664         Reviewed by Martin Robinson.
1665
1666         Fix linking problems on Windows.
1667         https://bugs.webkit.org/show_bug.cgi?id=45844
1668
1669         * GNUmakefile.am: link the executables with winmm.dll
1670
1671 2010-09-21  Adam Barth  <abarth@webkit.org>
1672
1673         Reviewed by Eric Seidel.
1674
1675         feeder-queue svn updates more often than needed
1676         https://bugs.webkit.org/show_bug.cgi?id=46171
1677
1678         We don't need to poll SVN every time we feed the feeders.  Rather, we
1679         can count on the wrapper shell script to auto-update the queue.
1680
1681         * Scripts/webkitpy/tool/commands/queues.py:
1682         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1683
1684 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1685
1686         Reviewed by Andreas Kling.
1687
1688         [Qt] Add robot loader timeout and extra time options.
1689         https://bugs.webkit.org/show_bug.cgi?id=46172
1690
1691         [-robot-timeout <s>]: Load the next page after s seconds if the current
1692         page didn't finish loading.
1693         [-robot-extra-time <s>]: Wait s seconds after the current page finished
1694         loading before loading the next one. This should allow some time for the
1695         page's JavaScript to execute.
1696
1697         * QtTestBrowser/launcherwindow.cpp:
1698         (LauncherWindow::applyPrefs):
1699         * QtTestBrowser/main.cpp:
1700         (LauncherApplication::robotTimeout):
1701         (LauncherApplication::robotExtraTime):
1702         (LauncherApplication::LauncherApplication):
1703         (LauncherApplication::handleUserOptions):
1704         (main):
1705         * QtTestBrowser/urlloader.cpp:
1706         (UrlLoader::UrlLoader):
1707         (UrlLoader::loadNext):
1708         (UrlLoader::loadUrlList):
1709         * QtTestBrowser/urlloader.h:
1710
1711 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
1712
1713         Unreviewed.
1714
1715         Adding myself to the committers list.
1716
1717         * Scripts/webkitpy/common/config/committers.py:
1718
1719 2010-09-20  Philippe Normand  <pnormand@igalia.com>
1720
1721         Reviewed by Eric Carlson.
1722
1723         [GTK] enhanced context menu for media elements
1724         https://bugs.webkit.org/show_bug.cgi?id=45021
1725
1726         EventSender::contextClick() now returns an array of js
1727         objects. Each object has a title property and a click() method.
1728
1729         * DumpRenderTree/gtk/EventSender.cpp:
1730         (getMenuItemTitleCallback):
1731         (setMenuItemTitleCallback):
1732         (menuItemClickCallback):
1733         (getMenuItemClass):
1734         (contextClickCallback):
1735
1736 2010-09-20  Hayato Ito  <hayato@chromium.org>
1737
1738         Unreviewed.
1739         Adding myself to the committers list.
1740
1741         * Scripts/webkitpy/common/config/committers.py:
1742
1743 2010-09-20  Adam Barth  <abarth@webkit.org>
1744
1745         Reviewed by Eric Seidel.
1746
1747         The tool member variable should be called _tool
1748         https://bugs.webkit.org/show_bug.cgi?id=46160
1749
1750         Created by find-and-replace.
1751
1752         * Scripts/webkitpy/tool/commands/download.py:
1753         * Scripts/webkitpy/tool/commands/openbugs.py:
1754         * Scripts/webkitpy/tool/commands/queries.py:
1755         * Scripts/webkitpy/tool/commands/queues.py:
1756         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1757         * Scripts/webkitpy/tool/commands/rebaseline.py:
1758         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1759         * Scripts/webkitpy/tool/commands/upload.py:
1760         * Scripts/webkitpy/tool/multicommandtool.py:
1761
1762 2010-09-20  Adam Barth  <abarth@webkit.org>
1763
1764         I ran the tests before landing but ignored the fact that they failed.  :(
1765
1766         * Scripts/webkitpy/tool/commands/queues.py:
1767
1768 2010-09-20  Adam Barth  <abarth@webkit.org>
1769
1770         Reviewed by Eric Seidel.
1771
1772         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
1773         https://bugs.webkit.org/show_bug.cgi?id=46141
1774
1775         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
1776         list of work items on the status server.  The individual commit-cluster
1777         nodes then grab the patches from the server and process them.
1778
1779         * Scripts/webkitpy/tool/bot/feeders.py: Added.
1780         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
1781         * Scripts/webkitpy/tool/commands/queues.py:
1782         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1783         * Scripts/webkitpy/tool/commands/queuestest.py:
1784
1785 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
1786
1787         Reviewed by Darin Adler.
1788
1789         build-webkit: Add support for CMake build system
1790         https://bugs.webkit.org/show_bug.cgi?id=44979
1791
1792         * Scripts/build-webkit: Add "--efl" command-line option to build the
1793         EFL port of WebKit.
1794         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
1795         buildEflCMakeProject() subroutines.
1796
1797 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
1798
1799         Reviewed by Ojan Vafai.
1800
1801         new-run-webkit-tests: refactor command line args getting passed to DRT
1802
1803         This change cleans up some argument parsing between functions to get
1804         rid of some overlapping data structures. There should be no functional
1805         changes in this patch; it is pure refactoring in preparation for
1806         landing the Chrome GPU port and adding a generic way to pass
1807         args to DRT/TestShell.
1808
1809         https://bugs.webkit.org/show_bug.cgi?id=46135
1810
1811         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1812           - pass the options argument explicitly to the threads and drivers,
1813             also consolidate the passing of options to the driver.
1814           - pass options directly to process_output() to remove a couple
1815             parameters (minor cleanup).
1816         * Scripts/webkitpy/layout_tests/port/base.py:
1817           - pass the options argument to Port.create_driver().
1818         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1819           - update Port.create_driver() test
1820         * Scripts/webkitpy/layout_tests/port/chromium.py:
1821           - pass the options argument to Port.create_driver(), and clean up
1822             building of the cmd line for DRT.
1823         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1824           - pass the options argument to Port.create_driver()
1825         * Scripts/webkitpy/layout_tests/port/test.py:
1826           - pass the options argument to Port.create_driver()
1827         * Scripts/webkitpy/layout_tests/port/webkit.py:
1828           - pass the options argument to Port.create_driver(), and clean up
1829             building of the cmd line for DRT.
1830         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1831           - consolidate args in _get_dump_render_tree_args and rename to
1832             _get_test_args(); move all of the command-line args to the
1833             Port implementations.
1834
1835 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
1836
1837         Revert change which was accidentally committed along with some expectation changes.
1838
1839         * Scripts/webkitpy/layout_tests/port/base.py:
1840
1841 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
1842
1843         Reviewed by Adam Barth.
1844
1845         Add explicit --force-patch flag to webkitpy tools
1846         https://bugs.webkit.org/show_bug.cgi?id=46103
1847         
1848         It wasn't obvious until I read the applypatch.py source code that
1849         --non-interfactive implies passing --force to patch. Add --force-patch
1850         as an alias to the flag, so that this behavior is more discoverable.
1851
1852         * Scripts/webkitpy/tool/steps/applypatch.py:
1853         * Scripts/webkitpy/tool/steps/options.py:
1854
1855 2010-09-20  Eric Seidel  <eric@webkit.org>
1856
1857         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
1858
1859         commit-queue can't land patches
1860         https://bugs.webkit.org/show_bug.cgi?id=46138
1861
1862         Add a line of code I forgot in my last commit.
1863
1864         * Scripts/webkitpy/common/net/bugzilla.py:
1865         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1866
1867 2010-09-20  Adam Barth  <abarth@webkit.org>
1868
1869         Reviewed by Eric Seidel.
1870
1871         The commit-cluster bots still race to lock patch_ids
1872         https://bugs.webkit.org/show_bug.cgi?id=46130
1873
1874         It turns out we need to use a transaction object to make the
1875         read/modify/write lock operation atomic.  From reading the AppEngine
1876         documentation, I think this patch should do what we want.  It's hard to
1877         test locally because the test instance isn't distributed in the same
1878         way the production instance is.
1879
1880         * QueueStatusServer/handlers/nextpatch.py:
1881         * QueueStatusServer/model/activeworkitems.py: Added.
1882
1883 2010-09-20  Andy Estes  <aestes@apple.com>
1884
1885         Reviewed by Adam Barth.
1886
1887         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
1888         https://bugs.webkit.org/show_bug.cgi?id=40961
1889
1890         Implement WebKitUsePreHTML5ParserQuirks preference.
1891
1892         * DumpRenderTree/mac/DumpRenderTree.mm:
1893         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
1894         to false after a test finishes.
1895
1896 2010-09-20  Adam Roben  <aroben@apple.com>
1897
1898         Windows build fix
1899
1900         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
1901         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
1902         we'll pick up the most recent versions of the headers.
1903
1904 2010-09-20  Eric Seidel  <eric@webkit.org>
1905
1906         Reviewed by Adam Barth.
1907
1908         commit-queue should check commit-queue+ again just before committing
1909         https://bugs.webkit.org/show_bug.cgi?id=32679
1910
1911         Added a _revalidate_patch check, right before landing.
1912
1913         Since _revalidate_patch passes the patch_id from the work item
1914         back to bugzilla, I had to fix all of the previous queue tests to
1915         use valid attachment ids (that's the majority of this change).
1916
1917         In order to validate that the bug was still open, I had to teach
1918         bugzilla.Bug about open/closed states.
1919
1920         * Scripts/webkitpy/common/net/bugzilla.py:
1921         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1922         * Scripts/webkitpy/tool/commands/queues.py:
1923         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1924         * Scripts/webkitpy/tool/commands/queuestest.py:
1925         * Scripts/webkitpy/tool/mocktool.py:
1926
1927 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
1928
1929         Unreviewed.
1930
1931         Adding myself as a comitter.
1932
1933         * Scripts/webkitpy/common/config/committers.py:
1934
1935 2010-09-20  Adam Barth  <abarth@webkit.org>
1936
1937         Reviewed by Eric Seidel.
1938
1939         Two instances of commit-queue try to process the same patch
1940         https://bugs.webkit.org/show_bug.cgi?id=46113
1941
1942         This patch makes next-patch atomic so that the server won't vend the
1943         same patch twice in the same hour.
1944
1945         * QueueStatusServer/handlers/nextpatch.py:
1946
1947 2010-09-20  Adam Roben  <aroben@apple.com>
1948
1949         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
1950
1951         We were previously trying to use a CFRunLoopTimer, but since Windows
1952         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
1953         Windows-style timer on Windows.
1954
1955         I also replaced all uses of "watchdog" with "watchdog timer".
1956
1957         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
1958         watchdog timer doesn't work on Windows
1959
1960         Reviewed by Anders Carlsson.
1961
1962         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1963         (WTR::InjectedBundlePage::dump): Updated for rename.
1964
1965         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
1966         platform-specific functions.
1967         (WTR::LayoutTestController::LayoutTestController): Added call to
1968         platformInitialize.
1969         (WTR::LayoutTestController::waitUntilDone): Changed to call
1970         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
1971         right in this function.
1972         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
1973         rename.
1974
1975         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
1976         members needed to support the watchdog timer abstraction. Replaced
1977         some "watchdog"s with "watchdog timer".
1978
1979         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
1980         Added.
1981         (WTR::LayoutTestController::platformInitialize): Does nothing on this
1982         platform.
1983         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
1984         from LayoutTestController.cpp and changed to use an early return.
1985         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
1986         LayoutTestController.cpp.
1987         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
1988         Moved code here from LayoutTestController::waitUntilDone and changed
1989         to use an early return.
1990
1991         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1992         Added.
1993         (WTR::LayoutTestController::platformInitialize): Initialize our
1994         watchdog timer.
1995         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
1996         Kills and clears the watchdog timer.
1997         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
1998         LayoutTestController member function of the same name.
1999         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
2000         Added. Sets up the timer if it isn't already set.
2001
2002         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
2003         LayoutTestControllerMac.mm.
2004
2005         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
2006         LayoutTestControllerWin.cpp.
2007
2008 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
2009
2010         Reviewed by Daniel Bates.
2011
2012         [GTK] fast/forms/listbox-selection.html fails
2013         https://bugs.webkit.org/show_bug.cgi?id=45942
2014
2015         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
2016         strings in keyDownCallback.
2017
2018         * DumpRenderTree/gtk/EventSender.cpp:
2019         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 
2020         modifier parsing logic.
2021
2022 2010-09-19  Sam Weinig  <sam@webkit.org>
2023
2024         Reviewed by Anders Carlsson.
2025
2026         WebKit2 decidePolicyForNavigationAction should include mouse button information
2027         <rdar://problem/8413165>
2028         https://bugs.webkit.org/show_bug.cgi?id=46060
2029
2030         * MiniBrowser/mac/BrowserWindowController.m:
2031         (decidePolicyForNavigationAction):
2032         (decidePolicyForNewWindowAction):
2033
2034 2010-09-19  Daniel Bates  <dbates@rim.com>
2035
2036         Reviewed by Martin Robinson.
2037
2038         Add unit tests for diffs that delete or modify a change log entry
2039         or describe changes that are far apart
2040         https://bugs.webkit.org/show_bug.cgi?id=46046
2041
2042         Add additional unit tests to test change log diffs that contain
2043         deletions or changes that are far apart from each other in the
2044         ChangeLog file.
2045
2046         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2047           - Added the following unit tests:
2048           "fixChangeLogPatch: [no change] In-place change."
2049           "fixChangeLogPatch: [no change] Remove first entry."
2050           "fixChangeLogPatch: [no change] Remove entry in the middle."
2051           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
2052
2053 2010-09-19  Sam Weinig  <sam@webkit.org>
2054
2055         Reviewed by Anders Carlsson.
2056
2057         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
2058         https://bugs.webkit.org/show_bug.cgi?id=46054
2059
2060         The new one acts like WKBundleNodeHandleRef and allows for getting a
2061         wrapper in a specific world for the handle.
2062
2063         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2064         (WTR::propertyValue):
2065         (WTR::propertyValueDouble):
2066         (WTR::propertyValueInt):
2067         (WTR::numericWindowPropertyValue):
2068         (WTR::toStr):
2069         (WTR::InjectedBundlePage::shouldBeginEditing):
2070         (WTR::InjectedBundlePage::shouldEndEditing):
2071         (WTR::InjectedBundlePage::shouldInsertNode):
2072         (WTR::InjectedBundlePage::shouldInsertText):
2073         (WTR::InjectedBundlePage::shouldDeleteRange):
2074         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2075         (WTR::InjectedBundlePage::shouldApplyStyle):
2076         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2077
2078 2010-09-19  Kent Tamura  <tkent@chromium.org>
2079
2080         Unreviewed. Fix WebGL test regressions by r67809.
2081
2082         * DumpRenderTree/chromium/WebPreferences.cpp:
2083         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
2084
2085 2010-09-19  Kent Tamura  <tkent@chromium.org>
2086
2087         Reviewed by Adam Barth.
2088
2089         [DRT/Chromium] Fix a WebSettings handling bug
2090         https://bugs.webkit.org/show_bug.cgi?id=45945
2091
2092         Before this change, Chromium DRT reset WebSettings for every new
2093         window. It was wrong.
2094         If new window is not the first one, we have to apply the same
2095         settings as the first window.  So, we introduce WebPreference to
2096         store the current settings, and apply it to new windows. It's same
2097         as test_shell's behavior.
2098
2099         * DumpRenderTree/DumpRenderTree.gypi:
2100         * DumpRenderTree/chromium/LayoutTestController.cpp:
2101           Use WebPreferences instead of WebSettings.
2102         (LayoutTestController::setUserStyleSheetEnabled):
2103         (LayoutTestController::setUserStyleSheetLocation):
2104         (LayoutTestController::setAuthorAndUserStylesEnabled):
2105         (LayoutTestController::setPopupBlockingEnabled):
2106         (LayoutTestController::disableImageLoading):
2107         (LayoutTestController::setJavaScriptCanAccessClipboard):
2108         (LayoutTestController::setXSSAuditorEnabled):
2109         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
2110         (LayoutTestController::setAllowFileAccessFromFileURLs):
2111         (LayoutTestController::overridePreference):
2112         (LayoutTestController::setEditingBehavior):
2113         * DumpRenderTree/chromium/TestShell.cpp:
2114         (TestShell::resetWebSettings): Use WebPreferences.
2115         (TestShell::runFileTest): ditto.
2116         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
2117         * DumpRenderTree/chromium/TestShell.h:
2118         (TestShell::preferences):
2119         (TestShell::applyPreferences):
2120         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
2121         * DumpRenderTree/chromium/WebPreferences.h: Added.
2122
2123 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
2124
2125         Reviewed by David Levin.
2126
2127         update-webkit --chromium spitting out a spurious error
2128         https://bugs.webkit.org/show_bug.cgi?id=45868
2129
2130         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
2131
2132 2010-09-18  Sam Weinig  <sam@webkit.org>
2133
2134         Reviewed by Dan Bernstein.
2135
2136         Improve/unify the PageLoadClient interfaces
2137         https://bugs.webkit.org/show_bug.cgi?id=46043
2138
2139         * MiniBrowser/mac/BrowserWindowController.m:
2140         (didStartProvisionalLoadForFrame):
2141         (didReceiveServerRedirectForProvisionalLoadForFrame):
2142         (didFailProvisionalLoadWithErrorForFrame):
2143         (didCommitLoadForFrame):
2144         (didFinishDocumentLoadForFrame):
2145         (didFinishLoadForFrame):
2146         (didFailLoadWithErrorForFrame):
2147         (didReceiveTitleForFrame):
2148         (didFirstLayoutForFrame):
2149         (didFirstVisuallyNonEmptyLayoutForFrame):
2150         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2151         (WTR::InjectedBundlePage::InjectedBundlePage):
2152         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2153         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
2154         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2155         (WTR::InjectedBundlePage::didCommitLoadForFrame):
2156         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2157         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
2158         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2159         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
2160         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2161         * WebKitTestRunner/TestController.cpp:
2162         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2163         (WTR::TestController::didFinishLoadForFrame):
2164         * WebKitTestRunner/TestController.h:
2165
2166 2010-09-17  Eric Seidel  <eric@webkit.org>
2167
2168         Unreviewed.  Adding a shell script I use to run the
2169         commit-queue. Now that multiple machines run the cq,
2170         it makes sense to share the script between them.
2171
2172         * EWSTools/start-commit-queue.sh: Added.
2173
2174 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
2175
2176         Reviewed by Jon Honeycutt.
2177
2178         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
2179         slightly harder to read, so this reverts the previous background colors for various
2180         states, making it easier to read.
2181
2182         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
2183         (.success):
2184         (.failure):
2185         (.warnings):
2186         (.exception):
2187         (.start,.running,td.building):
2188         (.offline,td.offline):
2189
2190 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
2191
2192         Unreviewed, rolling out r67692.
2193         http://trac.webkit.org/changeset/67692
2194         https://bugs.webkit.org/show_bug.cgi?id=46011
2195
2196         broke layout test dashboard (Requested by johnny_g on
2197         #webkit).
2198
2199         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2200         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2201         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2202
2203 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
2204
2205         Reviewed by Oliver Hunt.
2206
2207         Style bot complains about cairo forward declaration naming
2208         https://bugs.webkit.org/show_bug.cgi?id=45867
2209
2210         Exclude Cairo forward declarations from indentifiers with underscores checks.
2211
2212         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
2213         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2214
2215 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
2216
2217         Reviewed by Ojan Vafai.
2218
2219         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
2220         https://bugs.webkit.org/show_bug.cgi?id=45408
2221
2222         This change also tries to remove duplicated upload_results_json methods
2223         in run_webkit_tests.py and json_results_generator.py.
2224
2225         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2226         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2227         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2228
2229 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
2230
2231         Reviewed by Andreas Kling.
2232
2233         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
2234
2235         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
2236         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
2237         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
2238         all page specific stuff to the UI.
2239
2240         * QtTestBrowser/launcherwindow.cpp:
2241         (LauncherWindow::initializeView):
2242         * QtTestBrowser/mainwindow.cpp:
2243         (MainWindow::MainWindow):
2244         (MainWindow::buildUI):
2245         (MainWindow::setPage):
2246         * QtTestBrowser/mainwindow.h:
2247
2248 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
2249
2250         Reviewed by Andreas Kling.
2251
2252         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
2253
2254         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
2255         object will move to the qgraphicsscene instead of the qgraphicsview.
2256
2257         * QtTestBrowser/webview.cpp:
2258         (WebViewGraphicsBased::setPage):
2259         (WebViewGraphicsBased::setResizesToContents):
2260         (WebViewGraphicsBased::resizeEvent):
2261         (WebViewGraphicsBased::animatedFlip):
2262         * QtTestBrowser/webview.h:
2263         (WebViewGraphicsBased::setItemCacheMode):
2264         (WebViewGraphicsBased::itemCacheMode):
2265
2266 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
2267
2268         Reviewed by Andreas Kling.
2269
2270         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
2271
2272         We usually separate methods whose body are larger than a few lines from the class definition.
2273
2274         * QtTestBrowser/webview.h:
2275         (WebViewGraphicsBased::yRotation):
2276         (WebViewGraphicsBased::setYRotation):
2277
2278 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
2279
2280         Reviewed by Andreas Kling.
2281
2282         Make initializeView method of LauncherWindow private.
2283
2284         No one else needs to be able to call it but LauncherWindow.
2285         Also moving the declation of isGraphicsBased method down in the same file, in order
2286         to better group related methods.
2287
2288         * QtTestBrowser/launcherwindow.h:
2289
2290 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
2291
2292         Reviewed by Andreas Kling.
2293
2294         Make the getter 'page' method of MainWindow const.
2295
2296         * QtTestBrowser/mainwindow.cpp:
2297         (MainWindow::page):
2298         * QtTestBrowser/mainwindow.h:
2299
2300 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
2301
2302         Reviewed by Andreas Kling.
2303
2304         Remove useless parameter from MainWindow class' constructor.
2305
2306         The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
2307         not referred in the constructor body and does not make much sense.
2308
2309         * QtTestBrowser/mainwindow.cpp:
2310         (MainWindow::MainWindow):
2311         * QtTestBrowser/mainwindow.h:
2312
2313 2010-09-15  Tony Chang  <tony@chromium.org>
2314
2315         Reviewed by Kent Tamura.
2316
2317         [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
2318         https://bugs.webkit.org/show_bug.cgi?id=42151
2319
2320         * DumpRenderTree/chromium/LayoutTestController.cpp:
2321         (LayoutTestController::LayoutTestController):
2322         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2323         (WorkItemLoadHTMLString::run):
2324         (LayoutTestController::queueLoadHTMLString):
2325         (LayoutTestController::reset):
2326         (LayoutTestController::setDeferMainResourceDataLoad):
2327         * DumpRenderTree/chromium/LayoutTestController.h:
2328         (LayoutTestController::deferMainResourceDataLoad):
2329         * DumpRenderTree/chromium/WebViewHost.cpp:
2330         (WebViewHost::didCreateDataSource):
2331
2332 2010-09-16  Adrienne Walker  <enne@google.com>
2333
2334         Reviewed by Kenneth Russell.
2335
2336         Add script to synchronize WebKit and Khronos WebGL tests
2337         https://bugs.webkit.org/show_bug.cgi?id=42336
2338
2339         * Scripts/update-webgl-conformance-tests: Added.
2340         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
2341         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
2342
2343 2010-09-16  Sam Weinig  <sam@webkit.org>
2344
2345         Reviewed by Anders Carlsson.
2346
2347         Add support for sending synchronous messages from the InjectedBundle to the WKContext
2348         <rdar://problem/8365320>
2349         https://bugs.webkit.org/show_bug.cgi?id=44785
2350
2351         * MiniBrowser/mac/AppDelegate.m:
2352         (didReceiveSynchronousMessageFromInjectedBundle):
2353         (-[BrowserAppDelegate init]):
2354         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2355         (didCreatePage):
2356         * WebKitTestRunner/TestController.cpp:
2357         (WTR::TestController::initialize):
2358
2359 2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>
2360
2361         Reviewed by Andreas Kling.
2362
2363         [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
2364         https://bugs.webkit.org/show_bug.cgi?id=45885
2365
2366         Avoid creation of an additional window for screenshot to prevent overlapping with original window.
2367
2368         * QtTestBrowser/launcherwindow.cpp:
2369         (LauncherWindow::screenshot):
2370
2371 2010-09-16  Anders Carlsson  <andersca@apple.com>
2372
2373         Fix clang++ build.
2374
2375         * MiniBrowser/mac/BrowserWindowController.m:
2376         (-[BrowserWindowController zoomIn:]):
2377         (-[BrowserWindowController zoomOut:]):
2378         (-[BrowserWindowController resetZoom:]):
2379         Remove trailing semicolons.
2380
2381 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
2382
2383         Unreviewed, rolling out r67628.
2384         http://trac.webkit.org/changeset/67628
2385         https://bugs.webkit.org/show_bug.cgi?id=45904
2386
2387         broke the build (Requested by eric_carlson on #webkit).
2388
2389         * DumpRenderTree/gtk/EventSender.cpp:
2390         (contextClickCallback):
2391
2392 2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>
2393
2394         Unreviewed.
2395
2396         Adding myself as a comitter.
2397
2398         * Scripts/webkitpy/common/config/committers.py:
2399
2400 2010-09-15  Philippe Normand  <pnormand@igalia.com>
2401
2402         Reviewed by Eric Carlson.
2403
2404         [GTK] enhanced context menu for media elements
2405         https://bugs.webkit.org/show_bug.cgi?id=45021
2406
2407         EventSender::contextClick() now returns an array of js
2408         objects. Each object has a title property and a click() method.
2409
2410         * DumpRenderTree/gtk/EventSender.cpp:
2411         (getMenuItemTitleCallback):
2412         (setMenuItemTitleCallback):
2413         (menuItemClickCallback):
2414         (getMenuItemClass):
2415         (contextClickCallback):
2416
2417 2010-09-14  Philippe Normand  <pnormand@igalia.com>
2418
2419         Reviewed by Eric Carlson and Martin Robinson.
2420
2421         [GTK] eventSender.contextClick() should return the contents of the context menu
2422         https://bugs.webkit.org/show_bug.cgi?id=39102
2423
2424         Make the eventSender use the new private WebKitGtk+ API to
2425         retrieve the context-menu item titles and store them in an array.
2426
2427         * DumpRenderTree/gtk/EventSender.cpp:
2428         (contextClickCallback):
2429
2430 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
2431
2432         Reviewed by Jian Li.
2433
2434         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
2435         https://bugs.webkit.org/show_bug.cgi?id=45798
2436
2437         * Scripts/build-webkit:
2438
2439 2010-09-16  Robert Hogan  <robert@webkit.org>
2440
2441         Reviewed by Antonio Gomes.
2442
2443         [Qt] Support globalhistory tests
2444         https://bugs.webkit.org/show_bug.cgi?id=45774
2445
2446         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2447         (WebCore::isGlobalHistoryTest):
2448         (WebCore::DumpRenderTree::open):
2449         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2450         (LayoutTestController::reset):
2451         (LayoutTestController::dumpHistoryCallbacks):
2452         (LayoutTestController::removeAllVisitedLinks):
2453         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2454
2455 2010-09-10  Tony Chang  <tony@chromium.org>
2456
2457         Reviewed by Eric Seidel.
2458
2459         deduplicate-tests should be runnable from any WebKit directory
2460         https://bugs.webkit.org/show_bug.cgi?id=44709
2461
2462         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2463         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2464
2465 2010-09-15  Tony Chang  <tony@chromium.org>
2466
2467         Reviewed by Kent Tamura.
2468
2469         [chromium] sort testing methods in DRT
2470         https://bugs.webkit.org/show_bug.cgi?id=45850
2471
2472         * DumpRenderTree/chromium/EventSender.cpp:
2473         (EventSender::EventSender):
2474         * DumpRenderTree/chromium/LayoutTestController.cpp:
2475         (LayoutTestController::LayoutTestController):
2476         * DumpRenderTree/chromium/TextInputController.cpp:
2477         (TextInputController::TextInputController):
2478
2479 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
2480
2481         Reviewed by Adam Barth.
2482
2483         CQ status shows items out of order
2484         https://bugs.webkit.org/show_bug.cgi?id=45846
2485         
2486         Only group consecutive status items with the same patch ID into the same
2487         group, so that overall item ordering is preserved.
2488         
2489         Also don't indent status items that only have a single item in their
2490         group.
2491
2492         * QueueStatusServer/handlers/queuestatus.py:
2493         * QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
2494         * QueueStatusServer/templates/queuestatus.html:
2495
2496 2010-09-15  Eric Seidel  <eric@webkit.org>
2497
2498         Reviewed by Adam Barth.
2499
2500         Add queue start/stop messages
2501         https://bugs.webkit.org/show_bug.cgi?id=45853
2502
2503         I ended up needing to clean up a bunch of our unit testing
2504         in order to test this new code path nicely.
2505
2506         There are also a few PEP8 changes needed to pass check-webkit-style.
2507
2508         * Scripts/webkitpy/tool/bot/queueengine.py:
2509         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2510         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2511         * Scripts/webkitpy/tool/commands/queues.py:
2512         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2513         * Scripts/webkitpy/tool/commands/queuestest.py:
2514         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2515
2516 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
2517
2518         https://bugs.webkit.org/show_bug.cgi?id=45849
2519         WKURLCreateWithCFURL crashes with null url
2520         
2521         Fix MiniBrowser crash when the url is not parseable.
2522
2523         * MiniBrowser/mac/BrowserWindowController.m:
2524         (-[BrowserWindowController fetch:]):
2525
2526 2010-09-15  Patrick Gansterer  <paroga@paroga.com>
2527
2528         Unreviewed.
2529
2530         Adding myself to the committers list.
2531
2532         * Scripts/webkitpy/common/config/committers.py:
2533
2534 2010-09-14  Eric Seidel  <eric@webkit.org>
2535
2536         Reviewed by Adam Barth.
2537
2538         Make it possible to run more than one commit-queue instance
2539         https://bugs.webkit.org/show_bug.cgi?id=45786
2540
2541         Mostly we need to make sure the two (or more) instances get
2542         different patches to work on.  To do this, I re-worked
2543         the code responsible for getting the next work item to
2544         round trip through the status server.  The status server only
2545         vends patches from the work items list, only if those patches
2546         have not had status reported for them in the last hour.
2547
2548         This is another step towards making all queues go through the
2549         status server, thus making it possible to run more than one
2550         instance of various EWS bots (as requested in bug 44292).
2551
2552         The webkitpy changes are already covered by existing unit tests.
2553         The QueueStatusSever sadly has no testing infrastructure yet. :(
2554
2555         * QueueStatusServer/handlers/nextpatch.py: Added.
2556         * QueueStatusServer/index.yaml:
2557         * QueueStatusServer/main.py:
2558         * Scripts/webkitpy/tool/commands/queues.py:
2559
2560 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
2561
2562         Reviewed by Tony Chang.
2563
2564         NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
2565         https://bugs.webkit.org/show_bug.cgi?id=45791
2566
2567         Force filenames to be raw bytes before running difflib.unified_diff.
2568
2569         * Scripts/webkitpy/layout_tests/port/base.py:
2570         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2571
2572 2010-09-15  Simon Hausmann  <simon.hausmann@nokia.com>
2573
2574         Reviewed by Tor Arne Vestbø.
2575
2576         [Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
2577         https://bugs.webkit.org/show_bug.cgi?id=35247
2578
2579         The main issue when changing the views is that the plugins and any other components that
2580         depend on view specific attributes such as the native window id are not teared down.
2581         Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
2582         switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
2583         we decided to work around this in QtTestBrowser by making toggling between QWebView
2584         and QGraphicsWebView also re-create the page.
2585
2586         * QtTestBrowser/launcherwindow.cpp:
2587         (LauncherWindow::initializeView):
2588         * QtTestBrowser/mainwindow.h:
2589
2590 2010-09-14  Mihai Parparita  <mihaip@chromium.org>
2591
2592         Reviewed by Adam Barth.
2593
2594         Send webkit accessibility notifications to Chromium
2595         https://bugs.webkit.org/show_bug.cgi?id=45156
2596
2597         Move printf inside shouldDumpAccessibilityNotifications check.
2598
2599         * DumpRenderTree/chromium/WebViewHost.cpp:
2600         (WebViewHost::postAccessibilityNotification):
2601
2602 2010-09-14  Tony Chang  <tony@chromium.org>
2603
2604         Reviewed by Kent Tamura.
2605
2606         [chromium] fix http/tests/security/local-user-CSS-from-remote.html
2607         https://bugs.webkit.org/show_bug.cgi?id=45788
2608
2609         * DumpRenderTree/chromium/LayoutTestController.cpp:
2610         (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
2611
2612 2010-09-14  Tony Chang  <tony@chromium.org>
2613
2614         Reviewed by Ojan Vafai.
2615
2616         [chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
2617         https://bugs.webkit.org/show_bug.cgi?id=45768
2618
2619         * DumpRenderTree/chromium/TestShell.cpp:
2620         (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
2621
2622 2010-09-14  Kevin Ollivier  <kevino@theolliviers.com>
2623
2624         [wx] Build fix, add newly added directories to the directory list.
2625
2626         * wx/build/settings.py:
2627
2628 2010-09-14  Sam Weinig  <sam@webkit.org>
2629
2630         Reviewed by Anders Carlsson.
2631
2632         Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
2633         https://bugs.webkit.org/show_bug.cgi?id=45785
2634
2635         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2636         (WTR::propertyValue):
2637         (WTR::numericWindowPropertyValue):
2638         (WTR::dumpPath):
2639         (WTR::toStr):
2640         (WTR::operator<<):
2641         (WTR::InjectedBundlePage::InjectedBundlePage):
2642         (WTR::InjectedBundlePage::shouldInsertNode):
2643         (WTR::InjectedBundlePage::shouldBeginEditing):
2644         (WTR::InjectedBundlePage::shouldEndEditing):
2645         (WTR::InjectedBundlePage::shouldInsertText):
2646         (WTR::InjectedBundlePage::shouldDeleteRange):
2647         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
2648         (WTR::InjectedBundlePage::shouldApplyStyle):
2649         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2650
2651 2010-09-14  Adam Barth  <abarth@webkit.org>
2652
2653         Fix two typos in commit-queue.  The first is harmless.  The second
2654         causes the queue to reject patches when the build is broken.  :(
2655
2656         * Scripts/webkitpy/tool/commands/queues.py:
2657         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2658
2659 2010-09-14  Chris Guillory   <chris.guillory@google.com>
2660
2661         Reviewed by Chris Fleizach.
2662
2663         Send all accessibility notifications to Chromium.
2664         https://bugs.webkit.org/show_bug.cgi?id=45156
2665
2666         * DumpRenderTree/chromium/WebViewHost.cpp:
2667         (WebViewHost::postAccessibilityNotification):
2668         * DumpRenderTree/chromium/WebViewHost.h:
2669
2670 2010-09-14  Adam Barth  <abarth@webkit.org>
2671
2672         Reviewed by Eric Seidel.
2673
2674         commit-queue is slow during the day
2675         https://bugs.webkit.org/show_bug.cgi?id=45780
2676
2677         Thanks to the new logging, we've noticed that checkout-is-out-of-date
2678         errors in the first pass of landing don't retry the land.  Instead,
2679         they're treated as failures and cause the commit-queue to do two more
2680         builds before really trying to land the patch.  Worse, in the second
2681         build, we can get bitten by a flaky test.
2682
2683         This patch takes a slightly different approach to the commit-queue's
2684         main control logic.  We now use a separate subprocess for building and
2685         testing and for landing.  This means we should very rarely see the
2686         checkout-is-out-of-date error, and when we do see it, we should retry
2687         more quickly.  If my understanding is correct, this should be a big
2688         speed win for the commit-queue.
2689
2690         * Scripts/webkitpy/tool/commands/download.py:
2691         * Scripts/webkitpy/tool/commands/queues.py:
2692         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2693
2694 2010-09-14  Tony Chang  <tony@chromium.org>
2695
2696         Reviewed by Dimitri Glazkov.
2697
2698         [chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
2699         https://bugs.webkit.org/show_bug.cgi?id=45762
2700
2701         * DumpRenderTree/chromium/LayoutTestController.cpp:
2702         (LayoutTestController::LayoutTestController):
2703         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2704         * DumpRenderTree/chromium/LayoutTestController.h:
2705
2706 2010-09-14  Csaba Osztrogonác  <ossy@webkit.org>
2707
2708         Adding myself as a reviewer.
2709
2710         * Scripts/webkitpy/common/config/committers.py:
2711
2712 2010-09-14  Zoltan Horvath  <zoltan@webkit.org>
2713
2714         Reviewed by Kenneth Rohde Christiansen.
2715
2716         [Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
2717         https://bugs.webkit.org/show_bug.cgi?id=45736
2718
2719         Build-webkit has showed a warning when WebKitBuild didn't exist, add
2720         an additional condition to avoid it.
2721
2722         * Scripts/build-webkit:
2723
2724 2010-09-13  Eric Seidel  <eric@webkit.org>
2725
2726         Reviewed by Adam Barth.
2727
2728         commit-queue should log when it's retrying due to checkout out of date error
2729         https://bugs.webkit.org/show_bug.cgi?id=45725
2730
2731         This will allow us to better track how often we see these errors
2732         and how long it takes the queue to recover from them.
2733
2734         In order to pass the tests, I had to correct an error
2735         from a previous change.  The UnitTestPort should not have
2736         ever been using the base port method as that will read
2737         a file from disk.  If the unit tests haven't passed the contents
2738         it should raise an IOError as though the file doesn't exist.
2739
2740         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2741         * Scripts/webkitpy/tool/commands/queues.py:
2742         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2743
2744 2010-09-13  Mihai Parparita  <mihaip@chromium.org>
2745
2746         Reviewed by Adam Barth.
2747
2748         Upload results when cq patch landing fails
2749         https://bugs.webkit.org/show_bug.cgi?id=45683
2750         
2751         Include script errors when CommitQueue._land fails.
2752
2753         * Scripts/webkitpy/tool/commands/queues.py:
2754
2755 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
2756
2757         Reviewed by David Kilzer.
2758
2759         AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
2760         https://bugs.webkit.org/show_bug.cgi?id=45548
2761
2762         * DumpRenderTree/AccessibilityUIElement.cpp:
2763         (isIgnoredCallback):
2764         (AccessibilityUIElement::getJSClass):
2765         * DumpRenderTree/AccessibilityUIElement.h:
2766         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2767         (AccessibilityUIElement::isIgnored):
2768         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2769         (AccessibilityUIElement::isIgnored):
2770         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2771         (AccessibilityUIElement::isIgnored):
2772
2773 2010-09-13  Csaba Osztrogonác  <ossy@webkit.org>
2774
2775         Reviewed by Andreas Kling.
2776
2777         jscPath() is incorrect in Windows' cmd.exe shell
2778         https://bugs.webkit.org/show_bug.cgi?id=45651
2779
2780         * Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.
2781
2782 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
2783
2784         Reviewed by Darin Adler.
2785
2786         REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
2787         https://bugs.webkit.org/show_bug.cgi?id=43807
2788
2789         * DumpRenderTree/AccessibilityUIElement.cpp:
2790         (textMarkerForPointCallback):
2791         (AccessibilityUIElement::textMarkerForPoint):
2792         (AccessibilityUIElement::getJSClass):
2793         * DumpRenderTree/AccessibilityUIElement.h:
2794         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2795         (AccessibilityUIElement::textMarkerForPoint):
2796
2797 2010-09-13  Andreas Kling  <andreas.kling@nokia.com>
2798
2799         Reviewed by Kenneth Rohde Christiansen.
2800
2801         [Qt] build-webkit: Add --v8 option to build against V8
2802
2803         Note that V8 is picked up from QtScript, so this currently requires building
2804         against the experimental qt-script-v8 branch.
2805
2806         * Scripts/build-webkit:
2807
2808 2010-09-13  Hans Wennborg  <hans@chromium.org>
2809
2810         Reviewed by Jeremy Orlow.
2811
2812         Add WebDeviceOrientationClientMock::create() and use it from DRT.
2813         https://bugs.webkit.org/show_bug.cgi?id=45650
2814
2815         Do not use the WebDeviceOrientationClientMock constructor directly,
2816         but use the create() member function.
2817
2818         This should fix the linker errors for the multi-DLL Chromium DRT build.
2819
2820         * DumpRenderTree/chromium/LayoutTestController.cpp:
2821         (LayoutTestController::setMockDeviceOrientation):
2822         (LayoutTestController::deviceOrientationClient):
2823
2824 2010-08-27  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
2825
2826         Reviewed by Antti Koivisto.
2827
2828         Add support for testing the viewport meta tag algorithm,
2829         based on the following draft spec:
2830
2831         http://people.opera.com/rune/TR/ED-css-viewport-20100806/
2832
2833         Add common handling of viewport meta tag based on new Opera spec
2834         https://bugs.webkit.org/show_bug.cgi?id=44201
2835
2836         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2837         (LayoutTestController::dumpConfigurationForViewport):
2838         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2839
2840 2010-09-12  Kent Tamura  <tkent@chromium.org>
2841
2842         Reviewed by Tony Chang.
2843
2844         [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
2845         https://bugs.webkit.org/show_bug.cgi?id=45517
2846
2847         Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h
2848
2849         * DumpRenderTree/chromium/ImageDiff.cpp:
2850         (Image::craeteFromStdin):
2851         (Image::createFromFilename):
2852         (diffImages):
2853         * DumpRenderTree/chromium/TestShell.cpp:
2854         (TestShell::dumpImage):
2855
2856 2010-09-10  MORITA Hajime  <morrita@google.com>
2857
2858         Reviewed by Tony Chang.
2859
2860         [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
2861         https://bugs.webkit.org/show_bug.cgi?id=45441
2862
2863         Added TextInputController::hasSpellingMarker().
2864         
2865         * DumpRenderTree/chromium/TextInputController.cpp:
2866         (TextInputController::TextInputController):
2867         (TextInputController::hasSpellingMarker):
2868         * DumpRenderTree/chromium/TextInputController.h:
2869
2870 2010-09-12  Dirk Pranke  <dpranke@chromium.org>
2871
2872         Unreviewed, build fix.
2873
2874         My last change accidentally contained a local change to the
2875         rebaselinig script; webkit-patch land picked it up without telling
2876         me and committed it :(
2877
2878         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2879
2880 2010-09-11  Maciej Stachowiak  <mjs@apple.com>
2881
2882         Reviewed by Anders Carlsson.
2883
2884         Attempt to fix Windows MiniBrowser build (untested)
2885         https://bugs.webkit.org/show_bug.cgi?id=45609
2886
2887         * MiniBrowser/win/BrowserView.cpp:
2888         (runJavaScriptConfirm):
2889         (runJavaScriptPrompt):
2890
2891 2010-09-11  Sam Weinig  <sam@webkit.org>
2892
2893         Reviewed by Maciej Stachowiak.
2894
2895         Fix zoom related tests when testing WebKit2.
2896
2897         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2898         (WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.
2899
2900 2010-09-11  Sam Weinig  <sam@webkit.org>
2901
2902         Reviewed by Dan Bernstein.
2903
2904         Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
2905         <rdar://problem/8359252>
2906         https://bugs.webkit.org/show_bug.cgi?id=45605
2907
2908         * MiniBrowser/mac/BrowserWindowController.m:
2909         (setStatusText):
2910         (contentsSizeChanged):
2911         (-[BrowserWindowController awakeFromNib]):
2912         * MiniBrowser/win/BrowserView.cpp:
2913         (runJavaScriptConfirm):
2914         (runJavaScriptPrompt):
2915         (setStatusText):
2916         (contentsSizeChanged):
2917         (BrowserView::create):
2918         * WebKitTestRunner/TestController.cpp:
2919         (WTR::createOtherPage):
2920         (WTR::TestController::initialize):
2921
2922 2010-09-11  Sam Weinig  <sam@webkit.org>
2923
2924         Reviewed by Dan Bernstein.
2925
2926         Add callback mechanism for the getting the source of a frame
2927         <rdar://problem/8364681>
2928         https://bugs.webkit.org/show_bug.cgi?id=45604
2929
2930         Add ability to dump the main frame's source to the console.
2931
2932         * MiniBrowser/mac/BrowserWindowController.h:
2933         * MiniBrowser/mac/BrowserWindowController.m:
2934         (-[BrowserWindowController dumpSourceToConsole:]):
2935         * MiniBrowser/mac/MainMenu.xib:
2936
2937 2010-09-11  Eric Seidel  <eric@webkit.org>
2938
2939         Reviewed by Adam Barth.
2940
2941         Remove unneeded Empty Queue messages
2942         https://bugs.webkit.org/show_bug.cgi?id=45602
2943
2944         We already have a /gc job to delete these.
2945         recentstatus.py is already smart enough to use the
2946         most recent of the workitems last update or the most recent status,
2947         so removing these should not change the _last_status_date() return
2948         value more than a few milliseconds.
2949
2950         These messages just spam the recent status log.
2951
2952         * Scripts/webkitpy/tool/commands/queues.py:
2953
2954 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
2955
2956         Reviewed by Adam Barth.
2957
2958         Fix Python exception when generating synthetic patch IDs
2959         https://bugs.webkit.org/show_bug.cgi?id=45592
2960
2961         Can't concatenate strings and numbers directly.
2962
2963         * QueueStatusServer/handlers/queuestatus.py:
2964
2965 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
2966
2967         Reviewed by Adam Barth.
2968
2969         Group statuses in queue status by patch ID
2970         https://bugs.webkit.org/show_bug.cgi?id=45588
2971
2972         Group statuses by patch ID so that the status page is easier
2973         to scan.
2974
2975         * QueueStatusServer/handlers/queuestatus.py:
2976         * QueueStatusServer/stylesheets/dashboard.css:
2977         (.status-group):
2978         (.status-bug):
2979         (.status-group ul):
2980         (.status-group ul li):
2981         (.status-group ul li:hover):
2982         (.status-cell):
2983         (.status-cell:hover):
2984         (.status-cell.pass):
2985         (.status-cell.fail):
2986         (.status-cell.pending):
2987         (.status-cell.error):
2988         * QueueStatusServer/templates/dashboard.html:
2989         * QueueStatusServer/templates/queuestatus.html:
2990
2991 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
2992
2993         Reviewed by Tony Chang.
2994
2995         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
2996         https://bugs.webkit.org/show_bug.cgi?id=45479
2997
2998         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
2999         implementation in ResourceLoadDelegate in the Mac port).
3000
3001         * DumpRenderTree/chromium/LayoutTestController.cpp:
3002         (LayoutTestController::LayoutTestController):
3003         (LayoutTestController::dumpResourceResponseMIMETypes):
3004         (LayoutTestController::reset):
3005         * DumpRenderTree/chromium/LayoutTestController.h:
3006         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
3007         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
3008         * DumpRenderTree/chromium/TestShell.h:
3009         (TestShell::shouldDumpResourceResponseMIMETypes):
3010         * DumpRenderTree/chromium/WebViewHost.cpp:
3011         (WebViewHost::didReceiveResponse):
3012
3013 2010-09-11  Eric Seidel  <eric@webkit.org>
3014
3015         Reviewed by Adam Barth.
3016
3017         queues.webkit.org should expose /remote_api for data upload/download
3018         https://bugs.webkit.org/show_bug.cgi?id=45559
3019
3020         * QueueStatusServer/app.yaml:
3021          - /remote_api is a standard app-engine service which allows use of
3022            the bulk uploader for data upload/download.  Exposing this
3023            (for admin access only) allows us to use 
3024
3025 2010-09-10  Sam Weinig  <sam@webkit.org>
3026
3027         Reviewed by Dan Bernstein.
3028
3029         Add zoom support to WebKit2 API
3030         <rdar://problem/7660657>
3031         https://bugs.webkit.org/show_bug.cgi?id=45585
3032
3033         - Add zoom options to MiniBrowser that mimic Safari's options using
3034           the new WebKit2 zoom APIs.
3035         - Switch uses of float for the zoom APIs to use double.
3036
3037         * MiniBrowser/mac/BrowserWindowController.h:
3038         * MiniBrowser/mac/BrowserWindowController.m:
3039         (-[BrowserWindowController initWithPageNamespace:]):
3040         (-[BrowserWindowController validateMenuItem:]):
3041         (-[BrowserWindowController validateUserInterfaceItem:]):
3042         (-[BrowserWindowController currentZoomFactor]):
3043         (-[BrowserWindowController setCurrentZoomFactor:]):
3044         (-[BrowserWindowController canZoomIn]):
3045         (-[BrowserWindowController zoomIn:]):
3046         (-[BrowserWindowController canZoomOut]):
3047         (-[BrowserWindowController zoomOut:]):
3048         (-[BrowserWindowController canResetZoom]):
3049         (-[BrowserWindowController resetZoom:]):
3050         (-[BrowserWindowController toggleZoomMode:]):
3051         * MiniBrowser/mac/MainMenu.xib:
3052         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3053         (WTR::EventSendingController::textZoomIn):
3054         (WTR::EventSendingController::textZoomOut):
3055         (WTR::EventSendingController::zoomPageIn):
3056         (WTR::EventSendingController::zoomPageOut):
3057
3058 2010-09-10  Robert Hogan  <robert@webkit.org>
3059
3060         Reviewed by Andreas Kling.
3061
3062         [Qt] Fix crash in DRT in standalone mode
3063
3064         https://bugs.webkit.org/show_bug.cgi?id=45454
3065
3066         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3067         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
3068
3069 2010-09-10  Sam Weinig  <sam@webkit.org>
3070
3071         Reviewed by Darin Adler.
3072
3073         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
3074         Precursor to <rdar://problem/7660657>
3075         https://bugs.webkit.org/show_bug.cgi?id=45522
3076
3077         Update for changes to the Bundle API to allow separate control of page and text zoom
3078         levels.
3079
3080         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3081         (WTR::EventSendingController::textZoomIn):
3082         (WTR::EventSendingController::textZoomOut):
3083         (WTR::EventSendingController::zoomPageIn):
3084         (WTR::EventSendingController::zoomPageOut):
3085         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3086         (WTR::InjectedBundlePage::reset):
3087
3088 2010-09-10  Yael Aharon  <yael.aharon@nokia.com>
3089
3090         Reviewed by Andreas Kling.
3091
3092         [Qt] Support click event for notifications
3093         https://bugs.webkit.org/show_bug.cgi?id=44836
3094
3095         Add support for simulateDesktopNotificationClick by calling
3096         back to DumpRenderTreeSupportQt.cpp.
3097
3098         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3099         (LayoutTestController::simulateDesktopNotificationClick):
3100         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3101
3102 2010-09-10  Mihai Parparita  <mihaip@chromium.org>
3103
3104         Reviewed by Eric Seidel.
3105
3106         Update queue status when patches fail their first land attempt
3107         https://bugs.webkit.org/show_bug.cgi?id=45583
3108
3109         Add a few more _update_status calls to make it more obvious if a patch is 
3110         being retried because tests failed.
3111
3112         * Scripts/webkitpy/tool/commands/queues.py:
3113
3114 2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>
3115
3116         Reviewed by Andreas Kling.
3117
3118         [Qt] MiniBrowser crashes with multiply windows when closing one of them
3119         https://bugs.webkit.org/show_bug.cgi?id=45536
3120
3121         * MiniBrowser/qt/BrowserView.cpp:
3122         (BrowserView::BrowserView): Reference the context instead of adopting it
3123         because it can be shared across different views.
3124
3125 2010-09-10  Tony Chang  <tony@chromium.org>
3126
3127         Unreviewed, rolling out r67241.
3128         http://trac.webkit.org/changeset/67241
3129         https://bugs.webkit.org/show_bug.cgi?id=44709
3130
3131         Accidentally committed.
3132
3133         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3134         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3135
3136 2010-09-10  Tony Chang  <tony@chromium.org>
3137
3138         Reviewed by Ojan Vafai.
3139
3140         deduplicate-tests should be runnable from any WebKit directory
3141         https://bugs.webkit.org/show_bug.cgi?id=44709
3142
3143         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3144         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3145
3146 2010-09-10  Tony Chang  <tony@chromium.org>
3147
3148         Unreviewed, rolling out r67216.
3149         http://trac.webkit.org/changeset/67216
3150         https://bugs.webkit.org/show_bug.cgi?id=44709
3151
3152         Broke
3153
3154         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3155         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3156
3157 2010-09-10  Tony Chang  <tony@chromium.org>
3158
3159         Reviewed by Ojan Vafai.
3160
3161         deduplicate-tests should be runnable from any WebKit directory
3162         https://bugs.webkit.org/show_bug.cgi?id=44709
3163
3164         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3165         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3166
3167 2010-09-09  Hans Wennborg  <hans@chromium.org>
3168
3169         Reviewed by Jeremy Orlow.
3170
3171         Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.
3172         https://bugs.webkit.org/show_bug.cgi?id=45460
3173
3174         This enables DumpRenderTree to run layout tests for DeviceOrientation.
3175
3176         Also declare the LayoutTestController destructor out-of-line.
3177         Otherwise the implicit destructor would cause compiler errors because
3178         of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member.
3179
3180         * DumpRenderTree/chromium/LayoutTestController.cpp:
3181         (LayoutTestController::~LayoutTestController):
3182         (LayoutTestController::setMockDeviceOrientation):
3183         (LayoutTestController::deviceOrientationClient):
3184         * DumpRenderTree/chromium/LayoutTestController.h:
3185         * DumpRenderTree/chromium/WebViewHost.cpp:
3186         (WebViewHost::deviceOrientationClient):
3187         * DumpRenderTree/chromium/WebViewHost.h:
3188
3189 2010-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3190
3191         Unreviewed, rolling out r67119.
3192         http://trac.webkit.org/changeset/67119
3193         https://bugs.webkit.org/show_bug.cgi?id=45505
3194
3195         Extra newlines in results (Requested by tony^work on #webkit).
3196
3197         * DumpRenderTree/chromium/LayoutTestController.cpp:
3198         (LayoutTestController::LayoutTestController):
3199         (LayoutTestController::reset):
3200         * DumpRenderTree/chromium/LayoutTestController.h:
3201         * DumpRenderTree/chromium/TestShell.h:
3202         * DumpRenderTree/chromium/WebViewHost.cpp:
3203         (printResponseDescription):
3204         (printNodeDescription):
3205         (printRangeDescription):
3206         (WebViewHost::shouldBeginEditing):
3207         (WebViewHost::shouldEndEditing):
3208         (WebViewHost::shouldInsertNode):
3209         (WebViewHost::shouldChangeSelectedRange):
3210         (WebViewHost::shouldDeleteRange):
3211         (WebViewHost::shouldApplyStyle):
3212         (WebViewHost::didBeginEditing):
3213         (WebViewHost::didChangeSelection):
3214         (WebViewHost::didChangeContents):
3215         (WebViewHost::didEndEditing):
3216         (WebViewHost::decidePolicyForNavigation):
3217         (WebViewHost::didCancelClientRedirect):
3218         (WebViewHost::didStartProvisionalLoad):
3219         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
3220         (WebViewHost::didFailProvisionalLoad):
3221         (WebViewHost::didCommitProvisionalLoad):
3222         (WebViewHost::didFinishDocumentLoad):
3223         (WebViewHost::didHandleOnloadEvents):
3224         (WebViewHost::didFailLoad):
3225         (WebViewHost::didFinishLoad):
3226         (WebViewHost::didChangeLocationWithinPage):
3227         (WebViewHost::willSendRequest):
3228         (WebViewHost::didReceiveResponse):
3229         (WebViewHost::didFinishResourceLoad):
3230         (WebViewHost::didFailResourceLoad):
3231         (WebViewHost::didDisplayInsecureContent):
3232         (WebViewHost::didRunInsecureContent):
3233         (WebViewHost::printFrameDescription):
3234
3235 2010-09-09  Michael Saboff  <msaboff@apple.com>
3236
3237         Unreviewed, adding myself to committers list.
3238
3239         * Scripts/webkitpy/common/config/committers.py:
3240
3241 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
3242
3243         Reviewed by Tony Chang.
3244
3245         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
3246         https://bugs.webkit.org/show_bug.cgi?id=45479
3247
3248         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
3249         implementation in ResourceLoadDelegate in the Mac port).
3250
3251         * DumpRenderTree/chromium/LayoutTestController.cpp:
3252         (LayoutTestController::LayoutTestController):
3253         (LayoutTestController::dumpResourceResponseMIMETypes):
3254         (LayoutTestController::reset):
3255         * DumpRenderTree/chromium/LayoutTestController.h:
3256         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
3257         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
3258         * DumpRenderTree/chromium/TestShell.h:
3259         (TestShell::shouldDumpResourceResponseMIMETypes):
3260         * DumpRenderTree/chromium/WebViewHost.cpp:
3261         (WebViewHost::didReceiveResponse):
3262
3263 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
3264
3265         Reviewed by Daniel Bates.
3266
3267         svn-apply tries to delete directories it shouldn't
3268         https://bugs.webkit.org/show_bug.cgi?id=45424
3269
3270         isDirectoryEmptyForRemoval had the wrong check. If an item in the
3271         directory is itself a directory, then the directory is definitely
3272         not empty.
3273
3274         * Scripts/svn-apply:
3275
3276 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
3277
3278         Fixing GTK and windows build failure.
3279
3280         AX: Support AccessibilityTextMarkers in DRT
3281         https://bugs.webkit.org/show_bug.cgi?id=44778
3282
3283         * DumpRenderTree/AccessibilityTextMarker.h:
3284         (AccessibilityTextMarker::platformTextMarker):
3285         (AccessibilityTextMarkerRange::platformTextMarkerRange):
3286         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3287         (AccessibilityTextMarker::platformTextMarker):
3288         (AccessibilityTextMarkerRange::platformTextMarkerRange):
3289
3290 2010-09-09  Chris Fleizach  <cfleizach@apple.com>
3291
3292         Reviewed by David Kilzer.
3293
3294         AX: Support AccessibilityTextMarkers in DRT
3295         https://bugs.webkit.org/show_bug.cgi?id=44778
3296
3297         Add AccessibilityTextMarker and AccessibilityTextMarkerRange which encapsulate the AXTextMarkers 
3298         that WebCore uses when vending information about its VisiblePositions through AX.
3299
3300         There are a few new methods in AccessibilityUIElement to retrieve and use text markers, and some basic
3301         methods for encapsulating and checking equality.
3302
3303         This will allow future bug fixes in the text marker system to be adequately tested.
3304
3305         * DumpRenderTree/AccessibilityTextMarker.cpp: Added.
3306         (toTextMarker):
3307         (isMarkerEqualCallback):
3308         (markerFinalize):
3309         (AccessibilityTextMarker::makeJSAccessibilityTextMarker):
3310         (AccessibilityTextMarker::getJSClass):
3311         (toTextMarkerRange):
3312         (isMarkerRangeEqualCallback):
3313         (markerRangeFinalize):
3314         (AccessibilityTextMarkerRange::makeJSAccessibilityTextMarkerRange):
3315         (AccessibilityTextMarkerRange::getJSClass):
3316         * DumpRenderTree/AccessibilityTextMarker.h: Added.
3317         (AccessibilityTextMarker::platformTextMarker):
3318         (AccessibilityTextMarkerRange::platformTextMarkerRange):
3319         (AccessibilityTextMarker::AccessibilityTextMarker):
3320         (AccessibilityTextMarker::~AccessibilityTextMarker):
3321         (AccessibilityTextMarker::isEqual):
3322         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
3323         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
3324         (AccessibilityTextMarkerRange::isEqual):
3325         * DumpRenderTree/AccessibilityUIElement.cpp:
3326         (textMarkerRangeForElementCallback):
3327         (textMarkerRangeLengthCallback):
3328         (textMarkerRangeForMarkersCallback):
3329         (startTextMarkerForTextMarkerRangeCallback):
3330         (endTextMarkerForTextMarkerRangeCallback):
3331         (accessibilityElementForTextMarkerCallback):
3332         (AccessibilityUIElement::textMarkerRangeForElement):
3333         (AccessibilityUIElement::textMarkerRangeLength):
3334         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
3335         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
3336         (AccessibilityUIElement::accessibilityElementForTextMarker):
3337         (AccessibilityUIElement::getJSClass):
3338         * DumpRenderTree/AccessibilityUIElement.h:
3339         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3340         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm: Added.
3341         (AccessibilityTextMarker::AccessibilityTextMarker):
3342         (AccessibilityTextMarker::~AccessibilityTextMarker):
3343         (AccessibilityTextMarker::isEqual):
3344         (AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
3345         (AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
3346         (AccessibilityTextMarkerRange::isEqual):
3347         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3348         (AccessibilityUIElement::textMarkerRangeForElement):
3349         (AccessibilityUIElement::textMarkerRangeLength):
3350         (AccessibilityUIElement::textMarkerRangeForMarkers):
3351         (AccessibilityUIElement::startTextMarkerForTextMarkerRange):
3352         (AccessibilityUIElement::endTextMarkerForTextMarkerRange):
3353         (AccessibilityUIElement::accessibilityElementForTextMarker):
3354         * DumpRenderTree/win/DumpRenderTree.vcproj:
3355
3356 2010-08-25  Tony Chang  <tony@chromium.org>
3357
3358         Reviewed by Ojan Vafai.
3359
3360         don't delete duplicates needed because of intermediate results
3361         https://bugs.webkit.org/show_bug.cgi?id=44653
3362
3363         Also, output the full path so we can pipe the output to rm.
3364
3365         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3366         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3367
3368 2010-09-09  Balazs Kelemen  <kb@inf.u-szeged.hu>
3369
3370         Reviewed by Andreas Kling.
3371
3372         [Qt] MiniBrowser does not starts properly
3373         https://bugs.webkit.org/show_bug.cgi?id=45459
3374
3375         Do not try set up the first window by calling newWindow on a
3376         newly created BrowserWindow since it creates a new object.
3377         * MiniBrowser/qt/BrowserWindow.cpp:
3378         (BrowserWindow::BrowserWindow):
3379         * MiniBrowser/qt/main.cpp:
3380         (main):
3381
3382 2010-09-09  Martin Robinson  <mrobinson@igalia.com>
3383
3384         Reviewed by Xan Lopez.
3385
3386         [GTK] Get ImageDiff building on Win32
3387         https://bugs.webkit.org/show_bug.cgi?id=45353
3388
3389         * DumpRenderTree/gtk/ImageDiff.cpp:
3390         (main): Switch from using strtok to g_strsplit.
3391
3392 2010-09-09  Zoltan Horvath  <zoltan@webkit.org>
3393
3394         Reviewed by Andreas Kling.
3395
3396         [Qt] Modify load method of MiniBrowser's BrowserView class
3397         https://bugs.webkit.org/show_bug.cgi?id=45442
3398
3399         Modify load method to take a QString as argument, remove unnecessary QT_VERSION_CHECK.
3400
3401         * MiniBrowser/qt/BrowserView.cpp:
3402         (BrowserView::load):
3403         * MiniBrowser/qt/BrowserView.h:
3404         * MiniBrowser/qt/BrowserWindow.cpp:
3405         (BrowserWindow::load):
3406
3407 2010-09-09  Tony Chang  <tony@chromium.org>
3408
3409         Reviewed by Ojan Vafai.
3410
3411         fix show_results in new-run-webkit-tests
3412         https://bugs.webkit.org/show_bug.cgi?id=45413
3413
3414         * Scripts/webkitpy/layout_tests/port/chromium.py:
3415
3416 2010-09-08  Victor Wang  <victorw@chromium.org>
3417
3418         Reviewed by Ojan Vafai.
3419
3420         [Chromium] Fix test results server to make sure
3421         it does not have corrupted data.
3422
3423         results.json file size coulbe be >1M and we split
3424         the data into multiple data store entries in this
3425         case. This patch fixes the issue that the data may
3426         be corrupted if data store error happens in the middle
3427         of saving multiple entries.
3428
3429         https://bugs.webkit.org/show_bug.cgi?id=45063
3430
3431         * TestResultServer/model/datastorefile.py:
3432
3433 2010-09-08  Peter Varga  <pvarga@inf.u-szeged.hu>
3434
3435         Reviewed by Kenneth Rohde Christiansen.
3436
3437         Fix ignoring return value warning in case of gcc 4.4.4
3438         https://bugs.webkit.org/show_bug.cgi?id=45384
3439
3440         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3441         (testPostURLFile):
3442         If fwrite have written zero byte then the testPostURLFile function
3443         returns with false as tempFile can't be opened.
3444         * DumpRenderTree/qt/ImageDiff.cpp:
3445         (main):
3446         Put fwrite function into an if condition without body to avoid
3447         warning. It is safe because this function writes to the stdout.
3448
3449 2010-09-08  Satish Sampath  <satish@chromium.org>
3450
3451         Unreviewed, adding myself to committers list.
3452
3453         * Scripts/webkitpy/common/config/committers.py:
3454
3455 2010-09-08  Hans Wennborg  <hans@chromium.org>
3456
3457         Unreviewed.
3458
3459         Adding myself as a committer in committers.py.
3460
3461         * Scripts/webkitpy/common/config/committers.py:
3462
3463 2010-09-08  Zoltan Horvath  <zoltan@webkit.org>
3464
3465         Reviewed by Simon Hausmann.
3466
3467         [Qt] Refactor MiniBrowser 
3468         https://bugs.webkit.org/show_bug.cgi?id=45173
3469
3470         Split BrowserWindow into two source files and headers. Remove unnecessary header includes.
3471
3472         * MiniBrowser/qt/BrowserView.cpp: Added.
3473         (createNewPage):
3474         (BrowserView::BrowserView):
3475         (BrowserView::resizeEvent):
3476         (BrowserView::load):
3477         (BrowserView::view):
3478         * MiniBrowser/qt/BrowserView.h: Added.
3479         (BrowserView::~BrowserView):
3480         * MiniBrowser/qt/BrowserWindow.cpp:
3481         * MiniBrowser/qt/BrowserWindow.h:
3482         * MiniBrowser/qt/MiniBrowser.pro:
3483
3484 2010-09-08  Adam Barth  <abarth@webkit.org>
3485
3486         Rubber-stamped by Eric Seidel.
3487
3488         Rename DocLoader to CachedResourceLoader because that's what it does.
3489
3490         * Scripts/do-webcore-rename:
3491
3492 2010-09-07  Kinuko Yasuda  <kinuko@chromium.org>
3493
3494         Reviewed by Ojan Vafai.
3495
3496         Enable incremental results.json generation for non-layout tests.
3497         https://bugs.webkit.org/show_bug.cgi?id=45315
3498
3499         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Enable generate_incremental_results=True by default. (This still keeps to generate results.json.)  Also add a code to upload results json files to the app-engine server.  Need a chromium change to actually start the uploading.
3500
3501         * TestResultServer/model/jsonresults.py: Make sure we save the file with test_type for incremental cases too.
3502
3503
3504 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
3505
3506         Unreviewed, build fix
3507
3508         Missed one test in mac_unittest.py in previous change; for some
3509         reason the method is listed twice. I will fix both for now, but will
3510         figure this out in a later, not-time-sensitive patch.
3511
3512         https://bugs.webkit.org/show_bug.cgi?id=45357
3513
3514         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3515
3516 2010-09-07  Kent Tamura  <tkent@chromium.org>
3517
3518         Reviewed by Tony Chang.
3519
3520         test-webkitpy: Fix load error of
3521         webkitpy/layout_tests/port/factory_unittest.py on Win32 Python
3522         https://bugs.webkit.org/show_bug.cgi?id=45356 Need a short
3523
3524         * Scripts/webkitpy/layout_tests/port/server_process.py:
3525           Avoid to import fcntl on win32. Win32 Python doesn't have fcntl
3526           and we don't use server_process.py on Win32 Python. However
3527           unittest.py tries to load everything in a module.
3528
3529 2010-09-07  Dirk Pranke  <dpranke@chromium.org>
3530
3531         Reviewed by Kent Tamura.
3532
3533         Fix regression introduced in previous change to new-run-webkit-tests
3534         (bug 45090) to not try to run unittests for the Mac implementation
3535         of the Port interface if we aren't running on a Mac.
3536
3537         Also fix the overrides implementation mock in the chromium unittests
3538         to fix the case where there are overrides checked in that cause
3539         problems.
3540
3541         https://bugs.webkit.org/show_bug.cgi?id=45357
3542
3543         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3544         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3545         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3546
3547 2010-09-01  Dirk Pranke  <dpranke@chromium.org>
3548
3549         Reviewed by Ojan Vafai.
3550
3551         new-run-webkit-tests: still more unit tests
3552
3553         Clean up and remove unnecessary code. Biggest notable change is
3554         moving the chromium-specific imagediff code from port/base to
3555         port/chromium.
3556
3557         Add more unit tests for run_webkit_tests.py, port/base.py,
3558         port/factory.py, port/dryrun.py, and
3559         layout_package/dump_render_tree_thread.py
3560
3561         This covers almost all of the generic and test code paths except for
3562         a few error paths involving invalid or port-specific command line
3563         arguments, and the code path for uploading results files to the
3564         buildbots.
3565         
3566         https://bugs.webkit.org/show_bug.cgi?id=45090
3567
3568         * Scripts/webkitpy/layout_tests/data/failures/expected/hang.html: Added.
3569         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
3570         * Scripts/webkitpy/layout_tests/data/http/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
3571         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
3572         * Scripts/webkitpy/layout_tests/data/http/tests/ssl/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
3573         * Scripts/webkitpy/layout_tests/data/platform/test/test_expectations.txt:
3574         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text-expected.txt: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text-expected.txt.
3575         * Scripts/webkitpy/layout_tests/data/websocket/tests/passes/text.html: Copied from WebKitTools/Scripts/webkitpy/layout_tests/data/passes/text.html.
3576         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3577         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Added.
3578         * Scripts/webkitpy/layout_tests/port/base.py:
3579         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3580         * Scripts/webkitpy/layout_tests/port/chromium.py:
3581         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3582         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3583         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3584         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added.
3585         * Scripts/webkitpy/layout_tests/port/server_process.py:
3586         * Scripts/webkitpy/layout_tests/port/test.py:
3587         * Scripts/webkitpy/layout_tests/port/webkit.py: