4c1db606d2abdd3fb985e5f516d7e503449e4f20
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-12-06  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         [bzt] Rename AbstractTryQueue to AbstractReviewQueue
6         https://bugs.webkit.org/show_bug.cgi?id=32202
7
8         * Scripts/modules/commands/queues.py:
9
10 2009-12-05  Adam Barth  <abarth@webkit.org>
11
12         Reviewed by Eric Seidel.
13
14         [bzt] Implement ChromiumPort
15         https://bugs.webkit.org/show_bug.cgi?id=32182
16
17         * Scripts/modules/webkitport.py:
18         * Scripts/modules/webkitport_unittest.py:
19
20 2009-12-05  Adam Barth  <abarth@webkit.org>
21
22         Reviewed by Eric Seidel.
23
24         Move update-webkit into BuildSteps
25         https://bugs.webkit.org/show_bug.cgi?id=32181
26
27         We need to move update-webkit out of SCM.py because SCM isn't supposed to know
28         that WebKit exists.  The proper place for the knowledge of the existence of
29         update-webkit is in WebKitPort because some ports have specialized update
30         scripts (analogous to build-webkit).
31
32         * Scripts/modules/buildsteps.py:
33         * Scripts/modules/commands/download.py:
34         * Scripts/modules/landingsequence.py:
35         * Scripts/modules/scm.py:
36         * Scripts/modules/webkitport.py:
37
38 2009-12-05  Adam Barth  <abarth@webkit.org>
39
40         Reviewed by Eric Seidel.
41
42         update-webkit should call git svn rebase and resolve-ChangeLogs -f
43         https://bugs.webkit.org/show_bug.cgi?id=27162
44
45         Teach update-webkit about Git.  I didn't add the call to
46         resolve-ChangeLogs -f because sometimes that script goes bananas.  We
47         can iterate from here, however.
48
49         * Scripts/update-webkit:
50
51 2009-12-04  Yael Aharon  <yael.aharon@nokia.com>
52
53         Unreviewed build fix.
54
55         [Qt] build fix after r51634 removed unused QBoxLayout include which included limits.h.
56
57         * DumpRenderTree/qt/DumpRenderTree.cpp:
58
59 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
60
61         Reviewed by Adam Treat.
62
63         Add some missing methods for showing and hiding the
64         Web Inspector.
65
66         * DumpRenderTree/qt/DumpRenderTree.cpp:
67         (WebCore::WebPage::WebPage):
68         (WebCore::WebPage::~WebPage):
69         (WebCore::WebPage::webInspector):
70         * DumpRenderTree/qt/DumpRenderTree.h:
71         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
72         (LayoutTestController::showWebInspector):
73         (LayoutTestController::hideWebInspector):
74         * DumpRenderTree/qt/LayoutTestControllerQt.h:
75
76 2009-12-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
77
78         Reviewed by Adam Treat.
79
80         Implement the setAllowUniversalAccessFromFileURLs method
81         for the Qt LayoutTestController.
82
83         * DumpRenderTree/qt/DumpRenderTree.cpp:
84         (WebCore::WebPage::resetSettings):
85         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
86         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
87         * DumpRenderTree/qt/LayoutTestControllerQt.h:
88
89 2009-12-04  Chris Fleizach  <cfleizach@apple.com>
90
91         Reviewed by Darin Adler.
92
93         REGRESSION: AX: buttons now extremely repetitive
94         https://bugs.webkit.org/show_bug.cgi?id=32164
95
96         * DumpRenderTree/AccessibilityUIElement.cpp:
97         (isAttributeSupportedCallback):
98         (AccessibilityUIElement::getJSClass):
99         * DumpRenderTree/AccessibilityUIElement.h:
100         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
101         (AccessibilityUIElement::isAttributeSupported):
102         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
103         (AccessibilityUIElement::isAttributeSupported):
104         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
105         (AccessibilityUIElement::isAttributeSupported):
106
107 2009-12-03  Shinichiro Hamaji  <hamaji@chromium.org>
108
109         Reviewed by David Levin.
110
111         check-webkit-style should check for camelCase variable names
112         https://bugs.webkit.org/show_bug.cgi?id=32051
113
114         * Scripts/modules/cpp_style.py:
115         * Scripts/modules/cpp_style_unittest.py:
116
117 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
118
119         Reviewed by Eric Seidel.
120
121         AX: VO just says "term" on many web sites
122         https://bugs.webkit.org/show_bug.cgi?id=32139
123
124         * DumpRenderTree/AccessibilityUIElement.cpp:
125         (getRoleDescriptionCallback):
126         (AccessibilityUIElement::getJSClass):
127         * DumpRenderTree/AccessibilityUIElement.h:
128         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
129         (AccessibilityUIElement::roleDescription):
130         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
131         (AccessibilityUIElement::roleDescription):
132         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
133         (AccessibilityUIElement::roleDescription):
134
135 2009-12-03  Chris Fleizach  <cfleizach@apple.com>
136
137         Reviewed by Beth Dakin.
138
139         Implement WAI-ARIA scrollbar role and related property aria-orientation
140         https://bugs.webkit.org/show_bug.cgi?id=32126
141
142         * DumpRenderTree/AccessibilityUIElement.cpp:
143         (getOrientationCallback):
144         (AccessibilityUIElement::getJSClass):
145         * DumpRenderTree/AccessibilityUIElement.h:
146         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
147         (AccessibilityUIElement::orientation):
148         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
149         (AccessibilityUIElement::orientation):
150         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
151         (AccessibilityUIElement::orientation):
152
153 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
154
155         Reviewed by Adam Roben.
156
157         Minor correction to r51663.
158
159         * DumpRenderTree/win/DumpRenderTree.cpp:
160         (addQTDirToPATH):
161             GetEnvironmentVariable -> GetEnvironmentVariableW.
162
163 2009-12-03  Eric Carlson  <eric.carlson@apple.com>
164
165         Reviewed by Adam Roben.
166
167         ~96 regression tests fail when using QuickTime 7.6 (they pass with QuickTime 7.3)
168         https://bugs.webkit.org/show_bug.cgi?id=30256
169
170         Add the QuickTime dll directory to the PATH environment variable so
171         inialization can succeed.
172
173         * DumpRenderTree/win/DumpRenderTree.cpp:
174         (addQTDirToPATH):
175         (initialize):
176
177 2009-12-03  Shu Chang  <Chang.Shu@nokia.com>
178
179         Reviewed by Kenneth Rohde Christiansen.
180
181         [Qt] After revision 32643, sender() is of type QWebPage instead of QWebFrame.
182
183         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
184         (LayoutTestController::maybeDump):
185
186 2009-12-03  Yuzo Fujishima  <yuzo@google.com>
187
188         Reviewed by Eric Seidel.
189
190         Update pywebsocket to 0.4.3
191         This version logs friendlier and higher-level messages in WARN level, which is used for LayoutTests.
192         Stack trace is logged now in INFO level.
193         https://bugs.webkit.org/show_bug.cgi?id=32097
194
195         * pywebsocket/mod_pywebsocket/dispatch.py:
196         * pywebsocket/mod_pywebsocket/msgutil.py:
197         * pywebsocket/mod_pywebsocket/standalone.py:
198         * pywebsocket/mod_pywebsocket/util.py:
199         * pywebsocket/setup.py:
200         * pywebsocket/test/test_dispatch.py:
201         * pywebsocket/test/test_util.py:
202
203 2009-12-03  Sam Weinig  <sam@webkit.org>
204
205         Reviewed by Gavin Barraclough.
206
207         Fix JSClassRef leak.
208
209         * DumpRenderTree/AccessibilityController.cpp:
210         (AccessibilityController::makeWindowObject):
211         * DumpRenderTree/GCController.cpp:
212         (GCController::makeWindowObject):
213         * DumpRenderTree/LayoutTestController.cpp:
214         (LayoutTestController::makeWindowObject):
215
216 2009-12-03  Brady Eidson  <beidson@apple.com>
217
218         Reviewed by Sam Weinig.
219
220         <rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
221
222         Keep DRT-win building...
223
224         * DumpRenderTree/win/FrameLoadDelegate.h:
225         (FrameLoadDelegate::didPushStateWithinPageForFrame):
226         (FrameLoadDelegate::didReplaceStateWithinPageForFrame):
227         (FrameLoadDelegate::didPopStateWithinPageForFrame):
228
229 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
230
231         Unreviewed build fix.
232
233         [Qt] ARM-Linux build fix after r51634 removed unused QBoxLayout include which included limits.h on ARM.
234
235         * DumpRenderTree/qt/DumpRenderTree.cpp:
236
237 2009-12-03  Andras Becsi  <abecsi@inf.u-szeged.hu>
238
239         Reviewed by Kenneth Rohde Christiansen.
240
241         [Qt] Refactor DRT to not crash on tests which open child windows from javascript.
242         Prevent DRT from showing the main view if these childs get deleted.
243         This fixes https://bugs.webkit.org/show_bug.cgi?id=31591.
244
245         * DumpRenderTree/qt/DumpRenderTree.cpp:
246         (WebCore::WebPage::WebPage):
247         (WebCore::DumpRenderTree::DumpRenderTree):
248         (WebCore::DumpRenderTree::~DumpRenderTree):
249         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
250         (WebCore::DumpRenderTree::open):
251         (WebCore::DumpRenderTree::closeRemainingWindows):
252         (WebCore::DumpRenderTree::createWindow):
253         (WebCore::DumpRenderTree::windowCount):
254         * DumpRenderTree/qt/DumpRenderTree.h:
255
256 2009-12-02  Eric Seidel  <eric@webkit.org>
257
258         Reviewed by Adam Barth.
259
260         REGRESSION(51595): commit-queue is throwing exceptions
261         https://bugs.webkit.org/show_bug.cgi?id=32083
262
263         * Scripts/modules/commands/queues.py:
264          - Don't use default value of [] as it ends up getting shared.
265          - Make log_progress accept arrays of ints as well as strings.
266          - Return an exit code from execute()
267         * Scripts/modules/commands/queues_unittest.py: Added.
268          - Test to make sure log_progress will accept ints.
269          - Test to make sure run_bugzilla_tool will accept ints.
270         * Scripts/modules/workqueue.py:
271          - Print the stack trace on unexpected exceptions for easier debugging.
272         * Scripts/run-webkit-unittests:
273          - Add queues_unittest.
274
275         * Scripts/modules/commands/queues.py:
276         * Scripts/modules/commands/queues_unittest.py: Copied from WebKitTools/Scripts/modules/commands/commandtest.py.
277         * Scripts/modules/mock_bugzillatool.py:
278         * Scripts/modules/workqueue.py:
279         * Scripts/run-webkit-unittests:
280
281 2009-12-02  David Levin  <levin@chromium.org>
282
283         Reviewed by Adam Barth.
284
285         check-webkit-style is too noisy about namespace indenting issues.
286         https://bugs.webkit.org/show_bug.cgi?id=32096
287
288         * Scripts/modules/cpp_style.py:
289         Added a _FileState object to be able to track file level information. In this
290         case, it simply tracks whether the error has already been given, so that it isn't
291         done again.
292         * Scripts/modules/cpp_style_unittest.py:
293         Modified test cases to pass in the _FileState object and fix a test that expected
294         to see the namespace error twice (now it only occurs once). No new tests because
295         existing tests cover the change in functionality.
296
297 2009-12-01  Kevin Ollivier  <kevino@theolliviers.com>
298
299         Reviewed by Eric Seidel.
300
301         [wx] Get DumpRenderTree building after waf switch.
302         
303         https://bugs.webkit.org/show_bug.cgi?id=32041
304
305         * DumpRenderTree/wscript: Added.
306         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
307         (LayoutTestController::setTimelineProfilingEnabled):
308         (LayoutTestController::evaluateScriptInIsolatedWorld):
309         (LayoutTestController::disableImageLoading):
310         (LayoutTestController::whiteListAccessFromOrigin):
311         (LayoutTestController::counterValueForElementById):
312         * Scripts/build-webkit:
313
314 2009-12-02  Adam Barth  <abarth@webkit.org>
315
316         Reviewed by Eric Seidel.
317
318         [bzt] build-attachment shouldn't check whether the builders are red
319         https://bugs.webkit.org/show_bug.cgi?id=32062
320
321         build-attachment doesn't touch the remote repository, so there isn't a
322         need to hold off when the builders are red.
323
324         * Scripts/modules/commands/download.py:
325         * Scripts/modules/landingsequence.py:
326
327 2009-12-02  Eric Seidel  <eric@webkit.org>
328
329         Reviewed by Adam Barth.
330
331         REGRESSION(51590): style-queue and build-queue think their empty when they are not
332         https://bugs.webkit.org/show_bug.cgi?id=32061
333
334         * Scripts/modules/bugzilla.py: make all id lookups return ints instead of strings.
335         * Scripts/modules/bugzilla_unittest.py: Add and update unit tests to use ints.
336
337 2009-12-02  Eric Seidel  <eric@webkit.org>
338
339         Reviewed by Adam Barth.
340
341         build-queue is throwing exceptions and complaining about
342         lack of --no-update on build-attachment.  Make it stop.
343
344         * Scripts/modules/buildsteps.py:
345         * Scripts/modules/commands/download.py:
346
347 2009-12-02  Adam Barth  <abarth@webkit.org>
348
349         Unreviewed "build" fix.  Forgot to declare my variables.  :(
350
351         * QueueStatusServer/queue_status.py:
352
353 2009-12-02  Adam Barth  <abarth@webkit.org>
354
355         Reviewed by Eric Seidel.
356
357         [bzt] Implement status bubble view
358         https://bugs.webkit.org/show_bug.cgi?id=32057
359
360         The status bubble is a compact representation of the queue status for a
361         given patch.  This will eventually help us reduce the comment spam from
362         the queues.
363
364         * QueueStatusServer/index.html: Added HTML5 doctype for sanity.
365         * QueueStatusServer/queue_status.py:
366         * QueueStatusServer/status_bubble.html: Added.
367
368 2009-12-02  Eric Seidel  <eric@webkit.org>
369
370         Reviewed by Adam Barth.
371
372         trim commands/*.py includes now that commands are unit tested
373         https://bugs.webkit.org/show_bug.cgi?id=32056
374
375         In the course of ensuring that the unit tests still
376         passed after this change, I had to actually make them
377         pass in the first place.
378
379         * Scripts/modules/bugzilla.py:
380          - Fix _parse_attachment_ids_request_query to return ints instead of strings.
381         * Scripts/modules/commands/download.py: Remove unneeded imports.
382         * Scripts/modules/commands/queries.py: Ditto.
383         * Scripts/modules/commands/queues.py: Ditto.
384         * Scripts/modules/commands/upload.py: Ditto.
385         * Scripts/modules/scm_unittest.py:
386          - Fix to expect the \n after the path since echo adds an \n.
387
388 2009-12-01  Yaar Schnitman  <yaar@chromium.org>
389
390         build-webkit: Remove flex,bison,gperf check for chromium
391         https://bugs.webkit.org/show_bug.cgi?id=32043
392
393         * Scripts/webkitdirs.pm:
394
395 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
396
397         Build fixage for Windows/GTK for DumpRenderTree.
398
399         WAI-ARIA: implement support for ARIA drag and drop
400         https://bugs.webkit.org/show_bug.cgi?id=32007
401
402         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
403         (AccessibilityUIElement::ariaIsGrabbed):
404         (AccessibilityUIElement::ariaDropEffects):
405         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
406         (AccessibilityUIElement::ariaIsGrabbed):
407         (AccessibilityUIElement::ariaDropEffects):
408
409 2009-12-01  Chris Fleizach  <cfleizach@apple.com>
410
411         Reviewed by Darin Adler.
412
413         WAI-ARIA: implement support for ARIA drag and drop
414         https://bugs.webkit.org/show_bug.cgi?id=32007
415
416         * DumpRenderTree/AccessibilityUIElement.cpp:
417         (getARIADropEffectsCallback):
418         (getARIAIsGrabbedCallback):
419         (AccessibilityUIElement::getJSClass):
420         * DumpRenderTree/AccessibilityUIElement.h:
421         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
422         (AccessibilityUIElement::ariaIsGrabbed):
423         (AccessibilityUIElement::ariaDropEffects):
424
425 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
426
427         Not reviewed. GTK DRT try 2.
428
429         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
430         (LayoutTestController::sampleSVGAnimationForElementAtTime):
431
432 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
433
434         Not reviewed. Try to fix gtk DRT build.
435
436         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
437
438 2009-12-01  David Levin  <levin@chromium.org>
439
440         Reviewed by Eric Seidel.
441
442         check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h
443         https://bugs.webkit.org/show_bug.cgi?id=32033
444
445         * Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find
446                                         instead of startswith.
447         * Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior.
448
449 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
450
451         Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well.
452
453         * DumpRenderTree/qt/LayoutTestControllerQt.h: Update old function signature.
454
455 2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>
456
457         Reviewed by Simon Fraser.
458
459         Add SVG animation test framework with 'snapshot' functionality
460         https://bugs.webkit.org/show_bug.cgi?id=31897
461
462         Add new 'sampleSVGAnimationForElementAtTime' DRT method,
463         used by the new SVG animation testing framework, implemented
464         for qt/gtk/win/mac.
465
466         * DumpRenderTree/LayoutTestController.cpp:
467         (sampleSVGAnimationForElementAtTimeCallback):
468         (LayoutTestController::staticFunctions):
469         * DumpRenderTree/LayoutTestController.h:
470         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
471         (LayoutTestController::sampleSVGAnimationForElementAtTime):
472         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
473         (LayoutTestController::sampleSVGAnimationForElementAtTime):
474         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
475         (LayoutTestController::sampleSVGAnimationForElementAtTime):
476         * DumpRenderTree/qt/LayoutTestControllerQt.h:
477         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
478         (LayoutTestController::sampleSVGAnimationForElementAtTime):
479         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
480         (LayoutTestController::sampleSVGAnimationForElementAtTime):
481
482 2009-12-01  Adam Roben  <aroben@apple.com>
483
484         Remove user content before running each test on Windows
485
486         Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows
487
488         Reviewed by Alexey Proskuryakov.
489
490         * DumpRenderTree/win/DumpRenderTree.cpp:
491         (resetWebViewToConsistentStateBeforeTesting): Remove all user content
492         before each test, which matches Mac.
493
494 2009-12-01  Yuzo Fujishima  <yuzo@google.com>
495
496         Reviewed by Alexey Proskuryakov.
497
498         Make pywebsocket log errors to a file
499         https://bugs.webkit.org/show_bug.cgi?id=31604
500
501         * Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory
502         (by passing the path to the server via a recently added -l option).
503
504 2009-12-01  Adam Roben  <aroben@apple.com>
505
506         Fix tests that use the TestNetscapePlugin in Debug_Internal builds
507
508         Reviewed by Ada Chan.
509
510         Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
511         TestNetscapePlugin fail in Debug_Internal builds
512
513         * DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin
514         directory in Debug and Debug_All builds, but not in Debug_Internal
515         builds.
516
517 2009-12-01  Adam Roben  <aroben@apple.com>
518
519         Re-enable DRT's watchdog timer on Windows
520
521         It was accidentally disabled in r50907.
522
523         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
524         (LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
525         into an if condition.
526
527 2009-12-01  Adam Barth  <abarth@webkit.org>
528
529         Reviewed by Eric Seidel.
530
531         check-webkit-style complains about #imports with / in them
532         https://bugs.webkit.org/show_bug.cgi?id=32022
533
534         We need to exclude #import directives in addition to #include from the
535         binary operator whitespace checks.
536
537         * Scripts/modules/cpp_style.py:
538         * Scripts/modules/cpp_style_unittest.py:
539
540 2009-11-30  Adam Barth  <abarth@webkit.org>
541
542         Reviewed by Eric Seidel.
543
544         check-webkit-style is slightly too verbose
545         https://bugs.webkit.org/show_bug.cgi?id=32010
546
547         check-webkit-style prints out a bunch of "done" lines that seem redundant,
548         especially for the style-queue.
549
550         * Scripts/modules/cpp_style.py:
551
552 2009-11-30  Alejandro G. Castro  <alex@igalia.com>
553
554         Reviewed by Eric Seidel.
555
556         [GTK] Moved the functions that are closing the result log of the
557         tests to the last line of the runTest function, this avoids
558         reporting crashes in the wrong test if there is a problem when
559         reseting the state after the test.
560
561         * DumpRenderTree/gtk/DumpRenderTree.cpp:
562         (dump):
563         (runTest):
564
565 2009-11-30  Sam Weinig  <sam@webkit.org>
566
567         Reviewed by Geoffrey Garen.
568
569         Fix for https://bugs.webkit.org/show_bug.cgi?id=31286
570         fast/js/date-proto-generic-invocation breaks another test
571
572         Don't cache JSClassRefs, a change to the prototype chain will
573         last between tests.
574
575         * DumpRenderTree/AccessibilityController.cpp:
576         (AccessibilityController::getJSClass):
577         * DumpRenderTree/GCController.cpp:
578         (GCController::getJSClass):
579         * DumpRenderTree/GCController.h:
580         * DumpRenderTree/LayoutTestController.cpp:
581         (LayoutTestController::getJSClass):
582
583 2009-11-30  Yuzo Fujishima  <yuzo@google.com>
584
585         Reviewed by Alexey Proskuryakov.
586
587         Update pywebsocket to 0.4.2.1.
588         This is to fix a bug that some messages are logged to stderr even when the log file is specified.
589         https://bugs.webkit.org/show_bug.cgi?id=31976
590
591         * pywebsocket/mod_pywebsocket/standalone.py:
592         * pywebsocket/setup.py:
593
594 2009-11-30  Adam Barth  <abarth@webkit.org>
595
596         Reviewed by Eric Seidel.
597
598         [bzt] Generate pass messages for style-queue
599         https://bugs.webkit.org/show_bug.cgi?id=31995
600
601         With this change, the style-queue posts "pass" messages to bugs as
602         well.  Also, added more information to the state store w.r.t. passing
603         and failing.
604
605         * Scripts/modules/commands/queues.py:
606         * Scripts/modules/patchcollection.py:
607
608 2009-11-30  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
609
610         Reviewed by Simon Fraser.
611
612         Check for WEBKIT_TESTFONTS environment variable in
613         run-webkit-tests, for GTK+, to have a more prominent error
614         message.
615
616         * Scripts/run-webkit-tests:
617
618 2009-11-30  Yaar Schnitman  <yaar@chromium.org>
619
620         Reviewed by Dimitri Glazkov.
621
622         update-webkit --chromium forces gclient sync
623
624         https://bugs.webkit.org/show_bug.cgi?id=31967
625
626         * Scripts/update-webkit-chromium:
627
628 2009-11-29  Eric Seidel  <eric@webkit.org>
629
630         Add Erik Arvidsson to committers.py since by r51326 he clear has commit rights.
631
632         * Scripts/modules/committers.py:
633
634 2009-11-29  Eric Seidel  <eric@webkit.org>
635
636         No review, just adding missing svn property.
637
638         Set svn:executable property on new scripts.
639         These were added by commit-queue commits, but the executable
640         property was lost due to a bug in svn-apply:
641         https://bugs.webkit.org/show_bug.cgi?id=27204
642
643         * Scripts/update-webkit-chromium: Added property svn:executable.
644         * Scripts/validate-committer-lists: Added property svn:executable.
645
646 2009-11-29  Eric Seidel  <eric@webkit.org>
647
648         Reviewed by Adam Barth.
649
650         Need a way to validate that committers.py includes all committers/reviewers
651         https://bugs.webkit.org/show_bug.cgi?id=30970
652
653         Add a script which knows how to compare our public committer/reviewer
654         lists and show discrepancies between them.
655
656         Validates mailing lists vs. committers.py:
657         - committers.py committers missing from webkit-committers@lists
658         - webkit-committers@lists members missing from committers.py
659         - committers.py reviewers missing from webkit-reviewers@lists
660         - webkit-reviewers@lists members missing from committers.py
661         - webkit-reviewers@lists members missing from committers.py reviewer list
662
663         Validates committers.py vs. trunk/ SVN history:
664         - committers who have not committed in over a year
665         - SVN committers missing from committers.py
666         - committers.py members who have no record in SVN.
667
668         All of these lists still show "false positives" until a few more committers.py updates are made, like:
669         https://bugs.webkit.org/show_bug.cgi?id=31366
670
671         * Scripts/validate-committer-lists: Added.
672
673 2009-11-28  Adam Barth  <abarth@webkit.org>
674
675         Reviewed by Eric Seidel.
676
677         [bzt] style-queue sends ~100 requests to QueueStatusServer every 5 minutes
678         https://bugs.webkit.org/show_bug.cgi?id=31950
679
680         Now we cache the last status that we get back from QueueStatusServer.
681         Eventually we'll have to do something more fancy if we want to support
682         a "try again" button on QueueStatusServer, but we can cross that bridge
683         when we come to it.
684
685         * Scripts/modules/patchcollection.py:
686
687 2009-11-28  Adam Barth  <abarth@webkit.org>
688
689         Reviewed by Eric Seidel.
690
691         StyleQueue scans ~100 bug pages every 5 minutes
692         https://bugs.webkit.org/show_bug.cgi?id=31947
693
694         Instead of getting the pending-review attachment ids by scanning each
695         bug (which results in a network request), we should just get them all
696         from webkit.org/pending-review in one shot.
697
698         * Scripts/modules/bugzilla.py:
699         * Scripts/modules/bugzilla_unittest.py:
700         * Scripts/modules/commands/queries.py:
701         * Scripts/modules/commands/queries_unittest.py:
702         * Scripts/modules/commands/queues.py:
703         * Scripts/modules/mock_bugzillatool.py:
704         * Scripts/modules/patchcollection.py:
705
706 2009-11-28  Adam Barth  <abarth@webkit.org>
707
708         Reviewed by Eric Seidel.
709
710         [bzt] CC webkit-bot-watchers whenever the bots touch bugs
711         https://bugs.webkit.org/show_bug.cgi?id=31952
712
713         The mailing list is open for anyone to subscribe.
714
715         * Scripts/modules/bugzilla.py:
716         * Scripts/modules/commands/queues.py:
717
718 2009-11-28  Adam Barth  <abarth@webkit.org>
719
720         Reviewed by Eric Seidel.
721
722         [bzt] style-queue should report style errors to bugzilla
723         https://bugs.webkit.org/show_bug.cgi?id=31945
724
725         Currently, we're just logging the style errors locally.  With this
726         patch we'll actually log the errors to bugzilla.  Note: I plan to run
727         with the "local-only" logging during development.
728
729         * Scripts/modules/commands/queues.py:
730         * Scripts/modules/scm.py:
731
732 2009-11-28  Adam Barth  <abarth@webkit.org>
733
734         Reviewed by Eric Seidel.
735
736         [bzt] style-queue shouldn't reject patches from the commit-queue
737         https://bugs.webkit.org/show_bug.cgi?id=31944
738
739         Currently the style-queue subprocess gets confused and thinks its the
740         commit-queue.  If the patch has an error, it rejects it from the
741         commit-queue.  Instead, we should have style-queue specific logic.
742         This patch doesn't add that logic, but it gives us a callback we can
743         use to add that logic.
744
745         * Scripts/modules/buildsteps.py:
746         * Scripts/modules/commands/queues.py:
747         * Scripts/modules/landingsequence.py:
748
749 2009-11-27  Adam Barth  <abarth@webkit.org>
750
751         Rubber stamped by Eric Seidel.
752
753         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
754
755         * CommitQueueStatus: Removed.
756         * CommitQueueStatus/app.yaml: Removed.
757         * CommitQueueStatus/filters: Removed.
758         * CommitQueueStatus/filters/__init__.py: Removed.
759         * CommitQueueStatus/filters/webkit_extras.py: Removed.
760         * CommitQueueStatus/index.html: Removed.
761         * CommitQueueStatus/index.yaml: Removed.
762         * CommitQueueStatus/queue_status.py: Removed.
763         * CommitQueueStatus/stylesheets: Removed.
764         * CommitQueueStatus/stylesheets/main.css: Removed.
765         * CommitQueueStatus/update_status.html: Removed.
766         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
767
768 2009-11-27  Adam Barth  <abarth@webkit.org>
769
770         Reviewed by Eric Seidel.
771
772         style-queue should only process each patch once
773         https://bugs.webkit.org/show_bug.cgi?id=31939
774
775         Actually address reviewer comments!
776
777         * Scripts/bugzilla-tool:
778
779 2009-11-27  Adam Barth  <abarth@webkit.org>
780
781         Reviewed by Eric Seidel.
782
783         [bzt] style-queue fails to apply a bunch of patches for no reason
784         https://bugs.webkit.org/show_bug.cgi?id=31942
785
786         By passing --non-interactive to check-style, we convince check-style
787         to pass --force to svn-apply, which lets it apply more patches.
788
789         * Scripts/modules/commands/queues.py:
790
791 2009-11-27  Adam Barth  <abarth@webkit.org>
792
793         Reviewed by Eric Seidel.
794
795         [bzt] Support --status-host in style-queue
796         https://bugs.webkit.org/show_bug.cgi?id=31941
797
798         * Scripts/modules/commands/queues.py:
799         * Scripts/modules/statusbot.py:
800
801 2009-11-27  Adam Barth  <abarth@webkit.org>
802
803         Reviewed by Eric Seidel.
804
805         style-queue should only process each patch once
806         https://bugs.webkit.org/show_bug.cgi?id=31939
807
808         Before processing a patch, the try-queues now ask the web service
809         whether they have already processed the patch.  This is an initial cut
810         of this functionality.  I expect we're make it richer over time.
811
812         * Scripts/bugzilla-tool:
813         * Scripts/modules/commands/queues.py:
814         * Scripts/modules/patchcollection.py:
815
816 2009-11-27  Adam Barth  <abarth@webkit.org>
817
818         Reviewed by Eric Seidel.
819
820         PatchStatus does not return status
821         https://bugs.webkit.org/show_bug.cgi?id=31938
822
823         We need to parse attachment_id as an int.  Otherwise, we can't find
824         anything in the datastore.
825
826         * CommitQueueStatus/queue_status.py:
827
828 2009-11-27  Adam Barth  <abarth@webkit.org>
829
830         Reviewed by Eric Seidel.
831
832         Make commit-queue status not throw an exception where there is not
833         status
834         https://bugs.webkit.org/show_bug.cgi?id=31936
835
836         We need to actually fetch the results of the query to see what's in the
837         datastore.
838
839         * CommitQueueStatus/queue_status.py:
840
841 2009-11-27  Adam Barth  <abarth@webkit.org>
842
843         Reviewed by Eric Seidel.
844
845         [bzt] unit test ApplyPatches and ApplyAttachment
846         https://bugs.webkit.org/show_bug.cgi?id=31935
847
848         * Scripts/modules/commands/download.py:
849         * Scripts/modules/commands/download_unittest.py:
850
851 2009-11-27  Adam Barth  <abarth@webkit.org>
852
853         Reviewed by Eric Seidel.
854
855         [bzt] Unit test download commands
856         https://bugs.webkit.org/show_bug.cgi?id=31923
857
858         Adds download_unittest and fixes a bug found while testing.
859
860         * Scripts/modules/commands/commandtest.py:
861         * Scripts/modules/commands/download.py:
862             Fixed a bug where we'd throw an error because [].append returns
863             None.
864         * Scripts/modules/commands/download_unittest.py: Added.
865         * Scripts/modules/mock_bugzillatool.py:
866         * Scripts/run-webkit-unittests:
867
868 2009-11-27  Adam Barth  <abarth@webkit.org>
869
870         Unreviewed "build" fix found while writing unit tests.
871
872         * Scripts/modules/commands/download.py:
873
874 2009-11-27  Adam Barth  <abarth@webkit.org>
875
876         Reviewed by Eric Seidel.
877
878         [bzt] Kill WebKitLandingScripts
879         https://bugs.webkit.org/show_bug.cgi?id=31904
880
881         Step 6: Kill the rest.
882
883         * Scripts/modules/buildsteps.py:
884         * Scripts/modules/commands/download.py:
885         * Scripts/modules/commands/queries.py:
886         * Scripts/modules/commands/upload.py:
887         * Scripts/modules/landingsequence.py:
888         * Scripts/modules/scm.py:
889         * Scripts/modules/webkitlandingscripts.py: Removed.
890
891 2009-11-27  Adam Barth  <abarth@webkit.org>
892
893         Reviewed by Eric Seidel.
894
895         [bzt] Unit test upload commands
896         https://bugs.webkit.org/show_bug.cgi?id=31903
897
898         Adds unit tests for all but two of the upload commands.  The two
899         remaining ones are more difficult.  I'll return to them later.  The
900         goal of these tests is just to run the commands.  We can test more
901         detailed behavior later.
902
903         * Scripts/modules/commands/commandtest.py:
904         * Scripts/modules/commands/upload.py:
905         * Scripts/modules/commands/upload_unittest.py:
906         * Scripts/modules/mock.py: Added.
907         * Scripts/modules/mock_bugzillatool.py:
908
909 2009-11-26  Adam Barth  <abarth@webkit.org>
910
911         Reviewed by Eric Seidel.
912
913         [bzt] Kill WebKitLandingScripts
914         https://bugs.webkit.org/show_bug.cgi?id=31904
915
916         Step 5: Kill run_and_throw_if_fail.
917
918         * Scripts/modules/buildsteps.py:
919         * Scripts/modules/processutils.py: Added.
920         * Scripts/modules/webkitlandingscripts.py:
921
922 2009-11-26  Adam Barth  <abarth@webkit.org>
923
924         Reviewed by Eric Seidel.
925
926         [bzt] Kill WebKitLandingScripts
927         https://bugs.webkit.org/show_bug.cgi?id=31904
928
929         Step 4: Kill run_webkit_script.
930
931         * Scripts/modules/buildsteps.py:
932         * Scripts/modules/commands/download.py:
933         * Scripts/modules/webkitlandingscripts.py:
934
935 2009-11-26  Adam Barth  <abarth@webkit.org>
936
937         Reviewed by Eric Seidel.
938
939         [bzt] Kill WebKitLandingScripts
940         https://bugs.webkit.org/show_bug.cgi?id=31904
941
942         Step 3: Kill build_webkit.
943
944         * Scripts/modules/buildsteps.py:
945         * Scripts/modules/landingsequence.py:
946         * Scripts/modules/webkitlandingscripts.py:
947
948 2009-11-26  Adam Barth  <abarth@webkit.org>
949
950         Reviewed by Eric Seidel.
951
952         [bzt] Kill WebKitLandingScripts
953         https://bugs.webkit.org/show_bug.cgi?id=31904
954
955         Step 2: Kill ensure_builders_are_green.
956
957         * Scripts/modules/buildsteps.py:
958         * Scripts/modules/commands/download.py:
959         * Scripts/modules/landingsequence.py:
960         * Scripts/modules/webkitlandingscripts.py:
961
962 2009-11-26  Adam Barth  <abarth@webkit.org>
963
964         Reviewed by Eric Seidel.
965
966         [bzt] Kill WebKitLandingScripts
967         https://bugs.webkit.org/show_bug.cgi?id=31904
968
969         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
970
971         * Scripts/bugzilla-tool:
972         * Scripts/modules/buildsteps.py: Added.
973         * Scripts/modules/commands/download.py:
974         * Scripts/modules/landingsequence.py:
975         * Scripts/modules/webkitlandingscripts.py:
976
977 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
978
979         Reviewed by Adam Barth.
980
981         Remove directory prefixes from linux commands
982
983         SCM unittests can cause errors on some systems if we use absolute reference to
984         the commands, so directory prefixes have been removed.
985
986         * Scripts/modules/scm_unittest.py:
987
988 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
989
990         Reviewed by Kenneth Rohde Christiansen.
991
992         Link DumpRenderTree to the Qt Ui Tools
993         https://bugs.webkit.org/show_bug.cgi?id=31203
994
995         Implement QWebPage::createPlugin using the Qt Ui Tools
996         to be able to create classes like QProgressBar from within
997         the <object></object> tags This is required for the
998         new automatic test of Qt Plugins.
999
1000         * DumpRenderTree/qt/DumpRenderTree.cpp:
1001         (WebCore::WebPage::createPlugin):
1002         * DumpRenderTree/qt/DumpRenderTree.h:
1003         * DumpRenderTree/qt/DumpRenderTree.pro:
1004
1005 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
1006
1007         Reviewed by Eric Seidel.
1008
1009         Update pywebsocket to 0.4.2
1010
1011         Update pywebsocket to 0.4.2
1012         https://bugs.webkit.org/show_bug.cgi?id=31861
1013
1014         * pywebsocket/example/echo_client.py:
1015         * pywebsocket/example/echo_wsh.py:
1016         * pywebsocket/mod_pywebsocket/__init__.py:
1017         * pywebsocket/mod_pywebsocket/dispatch.py:
1018         * pywebsocket/mod_pywebsocket/msgutil.py:
1019         * pywebsocket/mod_pywebsocket/standalone.py:
1020         * pywebsocket/setup.py:
1021         * pywebsocket/test/test_dispatch.py:
1022         * pywebsocket/test/test_msgutil.py:
1023
1024 2009-11-25  Adam Barth  <abarth@webkit.org>
1025
1026         Reviewed by Eric Seidel.
1027
1028         Add unit test for mark-fixed
1029         https://bugs.webkit.org/show_bug.cgi?id=31896
1030
1031         * Scripts/modules/commands/commandtest.py: Added.
1032         * Scripts/modules/commands/queries_unittest.py:
1033         * Scripts/modules/commands/upload_unittest.py: Added.
1034         * Scripts/modules/mock_bugzillatool.py:
1035         * Scripts/run-webkit-unittests:
1036
1037 2009-11-25  Adam Barth  <abarth@webkit.org>
1038
1039         Reviewed by Eric Seidel.
1040
1041         bugzilla-tool should have a mark-fixed command
1042         https://bugs.webkit.org/show_bug.cgi?id=31853
1043
1044         Pretty simple stuff.
1045
1046         * Scripts/modules/commands/upload.py:
1047
1048 2009-11-25  Eric Seidel  <eric@webkit.org>
1049
1050         Reviewed by Adam Barth.
1051
1052         'bugzilla-tool help' should only show common commands like how 'git help' does
1053         https://bugs.webkit.org/show_bug.cgi?id=31772
1054
1055         I also took this opportunity to make 'help' a real Command.
1056         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
1057
1058         * Scripts/bugzilla-tool:
1059          - change should_show_command_help to should_show_in_main_help
1060         * Scripts/modules/commands/download.py:
1061          - Mark commands as being shown in main help or not.
1062          - show_in_main_help = False is not required (default is false),
1063            but it seemed to make the commands more self-documenting.
1064         * Scripts/modules/commands/queries.py: ditto
1065         * Scripts/modules/commands/queues.py: ditto
1066         * Scripts/modules/commands/upload.py: ditto
1067         * Scripts/modules/multicommandtool.py:
1068          - Make Command hold a pointer to tool in self.tool.  Most Command
1069            subclasses do not take advantage of this yet, but it was required
1070            for HelpCommand to be able to reach the tool from _help_epilog().
1071          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
1072          - Move MultiCommandTool._help_epilog to Command._help_epilog
1073          - Move "help" logic into HelpCommand.execute()
1074          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
1075         * Scripts/modules/multicommandtool_unittest.py:
1076          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
1077
1078 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
1079
1080         Reviewed by Dan Bernstein.
1081         
1082         Patch by Mark Rowe.
1083
1084         The buildbots are failing on Windows because when they were upgraded
1085         to 4.0.4, Apple Application Support was not in their path. Add it to
1086         the path to fix the buildots.
1087
1088         * Scripts/webkitdirs.pm:
1089
1090 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
1091
1092         Reviewed by David Kilzer.
1093
1094         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
1095         https://bugs.webkit.org/show_bug.cgi?id=31799
1096
1097         * Scripts/run-webkit-tests: Fixed.
1098
1099 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
1100
1101         Reviewed by Eric Seidel.
1102
1103         Change run_command to give back stderr by default
1104         https://bugs.webkit.org/show_bug.cgi?id=31734
1105
1106         Change run_command to give back stderr by default.
1107         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
1108         Change the related unittest call.
1109
1110         * Scripts/modules/scm.py:
1111         * Scripts/modules/scm_unittest.py:
1112
1113 2009-11-25  Eric Seidel  <eric@webkit.org>
1114
1115         Reviewed by Adam Barth.
1116
1117         Centralize required argument parsing in Command
1118         https://bugs.webkit.org/show_bug.cgi?id=31872
1119
1120         * Scripts/modules/commands/download.py: remove custom required arg message.
1121         * Scripts/modules/commands/upload.py: ditto.
1122         * Scripts/modules/multicommandtool.py:
1123          - Add _parse_required_arguments.
1124          - Pass program name off to OptionParser.
1125          - Add name() for access to tool name.
1126          - Add check_arguments_and_execute and make it return a return code.
1127          - Replace a couple uses of + with %.
1128         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
1129
1130 2009-11-25  Eric Seidel  <eric@webkit.org>
1131
1132         Reviewed by Adam Barth.
1133
1134         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
1135         https://bugs.webkit.org/show_bug.cgi?id=31870
1136
1137         * Scripts/modules/commands/queries_unittest.py: Use the new class.
1138         * Scripts/modules/multicommandtool_unittest.py: Ditto.
1139         * Scripts/modules/outputcapture.py: Added.
1140
1141 2009-11-24  Dmitry Titov  <dimich@chromium.org>
1142
1143         Reviewed by Eric Seidel.
1144
1145         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
1146         https://bugs.webkit.org/show_bug.cgi?id=31444
1147
1148         * Scripts/build-webkit:
1149
1150 2009-11-24  Chris Marrin  <cmarrin@apple.com>
1151
1152         Reviewed by Simon Fraser.
1153
1154         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
1155         https://bugs.webkit.org/show_bug.cgi?id=27314
1156         
1157         Now the script allows the directories with these tests to be included on all
1158         platforms but Mac, where they behave the same as always. For all other platforms
1159         the tests need to be excluded using the Skipped files, which is currently done
1160         for all platforms (including win since we're not turned on yet)
1161
1162         * Scripts/webkitdirs.pm:
1163
1164 2009-11-24  Eric Seidel  <eric@webkit.org>
1165
1166         Reviewed by Adam Barth.
1167
1168         queries_unittest.py should test command output
1169         https://bugs.webkit.org/show_bug.cgi?id=31845
1170
1171         * Scripts/modules/commands/queries_unittest.py:
1172          - Capture stdout and stderr and compare with expected strings.
1173
1174 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
1175
1176         No Review.
1177
1178         Fix spelling error ("depenedencies").
1179
1180         * Scripts/build-webkit:
1181
1182 2009-11-24  Mark Rowe  <mrowe@apple.com>
1183
1184         Land the configuration that includes the two debug GTK Linux builders.
1185
1186         * BuildSlaveSupport/build.webkit.org-config/config.json:
1187
1188 2009-11-24  David Kilzer  <ddkilzer@apple.com>
1189
1190         <http://webkit.org/b/31840> bisect-builds broke after r50080
1191
1192         Reviewed by Dan Bernstein.
1193
1194         * Scripts/bisect-builds:
1195         (mountAndRunNightly): Switched back to using backticks to run
1196         the hdiutil command since exec() will terminate the existing
1197         script, which is not what we want.  Store the output of
1198         File::Spec->devnull() in a variable for use in the hdiutil
1199         detach commands.
1200
1201 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1202
1203         Reviewed by Kenneth Rohde Christiansen.
1204
1205         Include "config.h" to meet Coding Style Guidelines
1206         https://bugs.webkit.org/show_bug.cgi?id=31792
1207
1208         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
1209         * DumpRenderTree/qt/jsobjects.cpp:
1210         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1211
1212 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1213
1214         Reviewed by Oliver Hunt.
1215
1216         Implement new required function to pass test we used to pass. This
1217         change is required since r51294.
1218
1219         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1220         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1221
1222 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
1223
1224         Reviewed by Kenneth Rohde Christiansen.
1225
1226         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
1227         https://bugs.webkit.org/show_bug.cgi?id=31775
1228
1229         LayoutTestController::dumpBackForwardList() should work with local URLs
1230         as well as with normal URLs (in http tests for instance).
1231         Currently it does not output the latter properly.
1232
1233         Unskip a bunch of passing http/navigation tests.
1234
1235         * DumpRenderTree/qt/DumpRenderTree.cpp:
1236         (WebCore::dumpHistoryItem):
1237
1238 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
1239
1240         Reviewed by Oliver Hunt.
1241
1242         ARIA: support aria-flowto
1243         https://bugs.webkit.org/show_bug.cgi?id=31762
1244
1245         * DumpRenderTree/AccessibilityUIElement.cpp:
1246         (ariaFlowToElementAtIndexCallback):
1247         (AccessibilityUIElement::getJSClass):
1248         * DumpRenderTree/AccessibilityUIElement.h:
1249         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1250         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1251         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1252         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1253         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1254         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1255
1256 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
1257
1258         Reviewed by Kenneth Christiansen.
1259
1260         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
1261         https://bugs.webkit.org/show_bug.cgi?id=31638
1262
1263         Unfreeze WorkQueue after each test execution.
1264
1265         * DumpRenderTree/qt/DumpRenderTree.cpp:
1266         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1267
1268 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
1269
1270         Reviewed by Adam Barth.
1271
1272         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
1273         for localhost and 127.0.0.1.
1274         https://bugs.webkit.org/show_bug.cgi?id=31783
1275
1276         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
1277
1278         * DumpRenderTree/qt/DumpRenderTree.cpp:
1279         (WebCore::NetworkAccessManager::NetworkAccessManager):
1280         (WebCore::NetworkAccessManager::sslErrorsEncountered):
1281         (WebCore::WebPage::WebPage):
1282         * DumpRenderTree/qt/DumpRenderTree.h:
1283
1284 2009-11-22  Chris Evans  <cevans@chromium.org>
1285
1286         Reviewed by Adam Barth.
1287
1288         Disable access to file:/// directory listings
1289         https://bugs.webkit.org/show_bug.cgi?id=31329
1290
1291         Implemented setAllowUniversalAccessFromFileURLs to support testing of
1292         file URL security.
1293
1294         * DumpRenderTree/LayoutTestController.cpp:
1295         (setAllowUniversalAccessFromFileURLsCallback):
1296         (LayoutTestController::staticFunctions):
1297         * DumpRenderTree/LayoutTestController.h:
1298         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1299         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1300         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1301         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1302         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1303         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1304         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1305         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
1306
1307 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
1308
1309         Reviewed by Kenneth Rohde Christiansen.
1310
1311         [Qt] Fix the timeout of fast/frames/frame-navigation.html
1312         https://bugs.webkit.org/show_bug.cgi?id=31638
1313
1314         The test is timeouting, because it uses the WorkQueue to load a document in one
1315         of the child frames and once the loading is finished, the DRT does not dump the
1316         tree. This is because it waits for the QWebFrame::loadFinished() signal from
1317         the main frame, while it should connect to QWebPage::loadFinished().
1318
1319         * DumpRenderTree/qt/DumpRenderTree.cpp:
1320         (WebCore::DumpRenderTree::DumpRenderTree):
1321
1322 2009-11-21  Eric Seidel  <eric@webkit.org>
1323
1324         Reviewed by Adam Barth.
1325
1326         bugzilla-tool --help spews way too much text
1327         https://bugs.webkit.org/show_bug.cgi?id=31771
1328
1329         * Scripts/bugzilla-tool:
1330          - Remove self.cached_scm initialization hack.
1331         * Scripts/modules/buildbot.py:
1332          - Make default_host accessible to callers.
1333         * Scripts/modules/commands/download.py:
1334          - Phrase help for all commands consistently and remove spurious help text punctuation.
1335         * Scripts/modules/commands/queries.py: Ditto.
1336         * Scripts/modules/commands/queues.py: Ditto.
1337         * Scripts/modules/commands/upload.py: Ditto.
1338         * Scripts/modules/multicommandtool.py:
1339          - Add HelpPrintingOptionParser.format_epilog to replace
1340            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
1341            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
1342          - Make --help only show a list of commands like "svn help" and "git help" do --
1343            previously --help was listing all commands and options.
1344          - Sort list of commands alphabetically.
1345
1346 2009-11-21  Eric Seidel  <eric@webkit.org>
1347
1348         No review.  Fixing a typo from the previous patch for bug 31767.
1349
1350         AbstractQueue.run_bugzilla_tool throws an exception
1351         https://bugs.webkit.org/show_bug.cgi?id=31769
1352
1353         * Scripts/modules/commands/queues.py:
1354
1355 2009-11-21  Eric Seidel  <eric@webkit.org>
1356
1357         Reviewed by Adam Barth.
1358
1359         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
1360         https://bugs.webkit.org/show_bug.cgi?id=31767
1361
1362         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
1363         Since we don't have a good way to test BugzillaTool pieces, I've
1364         left out a test for now.
1365
1366         * Scripts/bugzilla-tool:
1367          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
1368         * Scripts/modules/commands/queues.py:
1369          - Use tool.path() instead of __file__.
1370         * Scripts/modules/multicommandtool.py:
1371          - Add a new path() method to MultiComandTool.
1372         * Scripts/modules/multicommandtool_unittest.py:
1373          - Provide a path() method.  Little point in testing this mock implementation.
1374
1375 2009-11-21  Adam Barth  <abarth@webkit.org>
1376
1377         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
1378         WebKitTools.
1379
1380         * Scripts/modules/commands/download.py:
1381
1382 2009-11-21  Adam Barth  <abarth@webkit.org>
1383
1384         Reviewed by Eric Seidel.
1385
1386         Convert check-style to use LandingSequence
1387         https://bugs.webkit.org/show_bug.cgi?id=31763
1388
1389         Instead of manipulating the working copy by hand, we should use the
1390         LandingSequence in CheckStyle.  This will make this code eaiser to
1391         test.
1392
1393         * Scripts/modules/commands/download.py:
1394
1395 2009-11-20  Adam Barth  <abarth@webkit.org>
1396
1397         Reviewed by Eric Seidel.
1398
1399         Unit test query commands
1400         https://bugs.webkit.org/show_bug.cgi?id=31755
1401
1402         These tests are pretty rough, but hopefully they'll grow.
1403
1404         * Scripts/modules/commands/queries_unittest.py: Added.
1405         * Scripts/modules/mock_bugzillatool.py: Added.
1406         * Scripts/run-webkit-unittests:
1407
1408 2009-11-20  Eric Seidel  <eric@webkit.org>
1409
1410         Reviewed by Adam Barth.
1411
1412         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
1413         https://bugs.webkit.org/show_bug.cgi?id=31758
1414
1415         * Scripts/modules/multicommandtool.py:
1416          - Allow passing of explicit commands to MultiCommandTool.__init__
1417         * Scripts/modules/multicommandtool_unittest.py:
1418          - Use new Command.name naming system.
1419          - Test Command auto-discovery.
1420         * Scripts/modules/workqueue.py:
1421          - bug_id no longer exists, use patch['bug_id'] instead.
1422         * Scripts/modules/workqueue_unittest.py:
1423          - WorkQueues require names now.
1424          - should_proceed_with_work_item must return a patch object.
1425
1426 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
1427
1428         Reviewed by Beth Dakin.
1429
1430         WAI-ARIA: add support for aria-owns
1431         https://bugs.webkit.org/show_bug.cgi?id=31702
1432
1433         * DumpRenderTree/AccessibilityUIElement.cpp:
1434         (ariaOwnsElementAtIndexCallback):
1435         (AccessibilityUIElement::getJSClass):
1436         * DumpRenderTree/AccessibilityUIElement.h:
1437         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1438         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1439         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1440         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1441         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1442         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1443
1444 2009-11-20  Eric Seidel  <eric@webkit.org>
1445
1446         Reviewed by Adam Barth.
1447
1448         Fix exception thrown when running the commit-queue.
1449
1450         * Scripts/modules/statusbot.py: patch is optional.
1451         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
1452
1453 2009-11-20  Eric Seidel  <eric@webkit.org>
1454
1455         Reviewed by Adam Barth.
1456
1457         Teach the StatusBot how to support more than just the commit-queue
1458         https://bugs.webkit.org/show_bug.cgi?id=31754
1459
1460         * Scripts/modules/workqueue.py: Another typo.
1461
1462 2009-11-20  Eric Seidel  <eric@webkit.org>
1463
1464         Reviewed by Adam Barth.
1465
1466         Teach the StatusBot how to support more than just the commit-queue
1467         https://bugs.webkit.org/show_bug.cgi?id=31754
1468
1469         * Scripts/modules/commands/queues.py: Fix silly typo.
1470
1471 2009-11-20  Eric Seidel  <eric@webkit.org>
1472
1473         Reviewed by Adam Barth.
1474
1475         Teach the StatusBot how to support more than just the commit-queue
1476         https://bugs.webkit.org/show_bug.cgi?id=31754
1477
1478         * CommitQueueStatus/index.yaml:
1479          - Add indices required for the new queries.
1480         * CommitQueueStatus/queue_status.py:
1481          - Add a patch-status page and move update_status to update-status.
1482          - Only display "commit-queue" status records for the commit-queue.
1483          - Add support for a queue_name property on status records.
1484          - Fix _int_from_request to actually work.
1485         * CommitQueueStatus/update_status.html:
1486          - Add support for a queue_name on status records.
1487          - Remove unused list of bug ids.
1488          * Scripts/modules/commands/queues.py
1489           - Make the queues pass the patch instead of the bug_id to StatusBot.
1490         * Scripts/modules/statusbot.py:
1491          - Support passing the queue_name to the status updates.
1492          - Support fetching patch status with patch_status().
1493         * Scripts/modules/workqueue.py:
1494          - Pass the patch to the StatusBot instead of the bug_id.
1495          - Let WorkQueues have a name.
1496
1497 2009-11-20  Adam Barth  <abarth@webkit.org>
1498
1499         Reviewed by Eric Seidel.
1500
1501         Move bugzilla-tool commands into their own file
1502         https://bugs.webkit.org/show_bug.cgi?id=31752
1503
1504         This will let us write unit tests.
1505
1506         * Scripts/bugzilla-tool:
1507         * Scripts/modules/commands/__init__.py: Added.
1508         * Scripts/modules/commands/download.py: Added.
1509         * Scripts/modules/commands/queries.py: Added.
1510         * Scripts/modules/commands/queues.py: Added.
1511         * Scripts/modules/commands/upload.py: Added.
1512         * Scripts/modules/grammar.py: Added.
1513
1514 2009-11-20  Adam Barth  <abarth@webkit.org>
1515
1516         Reviewed by Eric Seidel.
1517
1518         BuildQueue should check if the tree is currently buildable
1519         https://bugs.webkit.org/show_bug.cgi?id=31744
1520
1521         * Scripts/bugzilla-tool:
1522         * Scripts/modules/landingsequence.py:
1523         * Scripts/modules/webkitlandingscripts.py:
1524
1525 2009-11-20  Adam Barth  <abarth@webkit.org>
1526
1527         Reviewed by Eric Seidel.
1528
1529         Move prepare_clean_working_directory into the LandingSequence
1530         https://bugs.webkit.org/show_bug.cgi?id=31743
1531
1532         * Scripts/bugzilla-tool:
1533         * Scripts/modules/landingsequence.py:
1534
1535 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
1536
1537         Reviewed by Kenneth Rohde Christiansen.
1538
1539         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
1540         https://bugs.webkit.org/show_bug.cgi?id=30460
1541
1542         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
1543
1544         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1545         (pluginInvoke):
1546
1547 2009-11-20  Adam Barth  <abarth@webkit.org>
1548
1549         Reviewed by Eric Seidel.
1550
1551         Pass the port information to the child process
1552         https://bugs.webkit.org/show_bug.cgi?id=31736
1553
1554         We need to do this so the child process knows what to build!
1555
1556         * Scripts/bugzilla-tool:
1557         * Scripts/modules/landingsequence.py:
1558         * Scripts/modules/webkitport.py:
1559         * Scripts/modules/webkitport_unittest.py:
1560
1561 2009-11-20  Adam Barth  <abarth@webkit.org>
1562
1563         Reviewed by Eric Seidel.
1564
1565         Support Qt port in build-queue
1566         https://bugs.webkit.org/show_bug.cgi?id=31733
1567
1568         * Scripts/bugzilla-tool:
1569
1570 2009-11-20  Adam Barth  <abarth@webkit.org>
1571
1572         Reviewed by Eric Seidel.
1573
1574         Implement a build-queue
1575         https://bugs.webkit.org/show_bug.cgi?id=31725
1576
1577         Currently this just builds the first 10 patches in the review queue.
1578         We'll want to do something smarter soon.
1579
1580         * Scripts/bugzilla-tool:
1581
1582 2009-11-20  Adam Barth  <abarth@webkit.org>
1583
1584         Reviewed by Eric Seidel.
1585
1586         Make commit-queue and style-queue show up in help
1587         https://bugs.webkit.org/show_bug.cgi?id=31724
1588
1589         We need to store their names on their class to make these commands
1590         properly register themselves with MultiCommandTool.
1591
1592         * Scripts/bugzilla-tool:
1593
1594 2009-11-20  Adam Barth  <abarth@webkit.org>
1595
1596         Reviewed by Eric Seidel.
1597
1598         Implement bugzilla-tool build-attachment
1599         https://bugs.webkit.org/show_bug.cgi?id=31722
1600
1601         This command builds an attachment from bugzilla.  It leaves the built
1602         patch in the working copy.
1603
1604         * Scripts/bugzilla-tool:
1605         * Scripts/modules/landingsequence.py:
1606         * Scripts/modules/webkitlandingscripts.py:
1607
1608 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
1609
1610         Reviewed by Xan Lopez.
1611
1612         [GTK] DRT release event does not create the state correctly
1613         https://bugs.webkit.org/show_bug.cgi?id=31717
1614
1615         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
1616
1617 2009-11-20  Eric Seidel  <eric@webkit.org>
1618
1619         Reviewed by Adam Barth.
1620
1621         MultiCommandTool should find Command objects automatically instead of with a manual list
1622         https://bugs.webkit.org/show_bug.cgi?id=31710
1623
1624         * Scripts/bugzilla-tool:
1625         * Scripts/modules/multicommandtool.py:
1626          - Use some wild python-fu to crawl all the known subclasses of Command.
1627
1628 2009-11-20  Adam Barth  <abarth@webkit.org>
1629
1630         Unreviewed "build" fix.  Added missing import.
1631
1632         * Scripts/bugzilla-tool:
1633
1634 2009-11-20  Adam Barth  <abarth@webkit.org>
1635
1636         Unreviewed "build" fix.  I failed to update LandingSequence.test
1637         properly.
1638
1639         * Scripts/modules/landingsequence.py:
1640
1641 2009-11-20  Adam Barth  <abarth@webkit.org>
1642
1643         Reviewed by Eric Seidel.
1644
1645         Create LandingSequence as the all-sing, all-dance landing class
1646         https://bugs.webkit.org/show_bug.cgi?id=31709
1647
1648         Client can inherit from this class to carefully control exactly which
1649         steps they wish to have happen in the landing sequence.
1650
1651         * Scripts/bugzilla-tool:
1652         * Scripts/modules/landingsequence.py: Added.
1653         * Scripts/modules/webkitlandingscripts.py: Added.
1654
1655 2009-11-19  Adam Barth  <abarth@webkit.org>
1656
1657         Reviewed by Eric Seidel.
1658
1659         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
1660         https://bugs.webkit.org/show_bug.cgi?id=31707
1661
1662         This is to help when we implement build-attachment.
1663
1664         * Scripts/bugzilla-tool:
1665
1666 2009-11-19  Adam Barth  <abarth@webkit.org>
1667
1668         Reviewed by Eric Seidel.
1669
1670         Support Qt port in bugzilla-tool
1671         https://bugs.webkit.org/show_bug.cgi?id=31701
1672
1673         Now we support building with Qt!
1674
1675         * Scripts/bugzilla-tool:
1676         * Scripts/modules/webkitport.py: Added.
1677         * Scripts/modules/webkitport_unittest.py: Added.
1678         * Scripts/run-webkit-unittests:
1679
1680 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
1681
1682         Reviewed by Adam Barth.
1683
1684         Remove inserting stderr into patch in bugzilla-tool
1685         https://bugs.webkit.org/show_bug.cgi?id=29914
1686
1687         Modify SCM python module's run_command function to avoid return of stderr
1688         by default, so stderr won't be inserted into the patches.
1689         Modify the related unit test.
1690
1691         * Scripts/modules/scm.py:
1692         * Scripts/modules/scm_unittest.py:
1693
1694 2009-11-19  Eric Seidel  <eric@webkit.org>
1695
1696         Reviewed by Adam Barth.
1697
1698         bugzilla-tool needs per-command help
1699         https://bugs.webkit.org/show_bug.cgi?id=31697
1700
1701         Added support for "bugzilla-tool help command-name"
1702         and a unit test to make sure it works.
1703
1704         * Scripts/modules/multicommandtool.py:
1705         * Scripts/modules/multicommandtool_unittest.py:
1706
1707 2009-11-19  Eric Seidel  <eric@webkit.org>
1708
1709         Reviewed by Adam Barth.
1710
1711         Move MultiCommandTool and Command into a separate file and add some basic unit tests
1712         https://bugs.webkit.org/show_bug.cgi?id=31695
1713
1714         * Scripts/bugzilla-tool:
1715         * Scripts/modules/multicommandtool.py: Added.
1716         * Scripts/modules/multicommandtool_unittest.py: Added.
1717         * Scripts/run-webkit-unittests:
1718
1719 2009-11-19  Eric Seidel  <eric@webkit.org>
1720
1721         No review, just adding a FIXME.
1722
1723         Split out command parsing and help printing from BugzillaTool
1724         https://bugs.webkit.org/show_bug.cgi?id=31688
1725
1726         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
1727
1728 2009-11-19  Eric Seidel  <eric@webkit.org>
1729
1730         Reviewed by Adam Barth.
1731
1732         Split out command parsing and help printing from BugzillaTool
1733         https://bugs.webkit.org/show_bug.cgi?id=31688
1734
1735         * Scripts/bugzilla-tool:
1736          - Add new MultiCommandTool class to contain option parsing and help printing logic.
1737          - Rename private methods to use _ pattern.
1738          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
1739          - 
1740
1741 2009-11-19  Eric Seidel  <eric@webkit.org>
1742
1743         Reviewed by Adam Barth.
1744
1745         Re-factor help printing to use modern python idioms
1746         https://bugs.webkit.org/show_bug.cgi?id=31685
1747
1748         * Scripts/bugzilla-tool:
1749
1750 2009-11-19  Eric Seidel  <eric@webkit.org>
1751
1752         Reviewed by Darin Adler.
1753
1754         commit-queue empty queue logs twice
1755         https://bugs.webkit.org/show_bug.cgi?id=31679
1756
1757         * Scripts/bugzilla-tool:
1758
1759 2009-11-19  Eric Seidel  <eric@webkit.org>
1760
1761         Reviewed by Darin Adler.
1762
1763         bugzilla-tool's reviewer/committer rejection message should be clearer
1764         https://bugs.webkit.org/show_bug.cgi?id=31126
1765
1766         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
1767
1768         * Scripts/modules/bugzilla.py:
1769
1770 2009-11-19  Eric Z. Ayers  <zundel@google.com>
1771
1772         Reviewed by Pavel Feldman.
1773
1774         Forces a WM_PAINT event on calling layoutTestController.display()
1775         in order to enable the timeline-paint.html test on Windows.
1776         ::UpdateWindow() does not force an event becaue the window is 
1777         not visible.
1778
1779         https://bugs.webkit.org/show_bug.cgi?id=31402
1780
1781         * DumpRenderTree/win/DumpRenderTree.cpp:
1782         (displayWebView):
1783
1784 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
1785
1786         No review needed.
1787
1788         Added myself to committers list.
1789
1790         * Scripts/modules/committers.py:
1791
1792 2009-11-19  Adam Barth  <abarth@webkit.org>
1793
1794         Reviewed by Eric Seidel.
1795
1796         Bugzilla-tool command classes should match command names
1797         https://bugs.webkit.org/show_bug.cgi?id=31666
1798
1799         I renamed all the commands except CommitMessageForCurrentDiff because
1800         the new name would conflict with an existing class.
1801
1802         * Scripts/bugzilla-tool:
1803
1804 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
1805
1806         Reviewed by Gustavo Noronha Silva.
1807
1808         Web Inspector: Implement "show inspector" in WebKit GTK
1809         API and enable console tests.
1810
1811         https://bugs.webkit.org/show_bug.cgi?id=31669
1812
1813         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1814         (LayoutTestController::showWebInspector):
1815
1816 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1817
1818         Reviewed by Simon Hausmann.
1819
1820         Minor refactoring + more documentation.
1821
1822         * DumpRenderTree/qt/DumpRenderTree.cpp:
1823         (WebCore::clearHistory):
1824         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1825
1826 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
1827
1828         Reviewed by Eric Seidel.
1829
1830         Ignore websocket tests when --no-http is specified.
1831         https://bugs.webkit.org/show_bug.cgi?id=31662
1832
1833         * Scripts/run-webkit-tests:
1834
1835 2009-11-18  Adam Barth  <abarth@webkit.org>
1836
1837         Reviewed by Eric Seidel.
1838
1839         Normalize ' and " in bugzilla-tool
1840         https://bugs.webkit.org/show_bug.cgi?id=31655
1841
1842         We decided " is better than ' and we should be consistent.
1843
1844         * Scripts/bugzilla-tool:
1845
1846 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1847
1848         Reviewed by Kenneth Rohde Christiansen.
1849
1850         [Qt] Remove support for Qt v4.3 or older versions
1851         https://bugs.webkit.org/show_bug.cgi?id=29469
1852
1853         * DumpRenderTree/qt/DumpRenderTree.pro:
1854         * DumpRenderTree/qt/ImageDiff.pro:
1855
1856 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1857
1858         Reviewed by Eric Seidel.
1859
1860         GitTest.test_create_binary_patch fails if /tmp is symlink
1861         https://bugs.webkit.org/show_bug.cgi?id=31536
1862
1863         * Scripts/modules/scm_unittest.py:
1864
1865 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
1866
1867         Reviewed by Darin Adler.
1868
1869         Configuration for Chromium Build Slaves.
1870
1871         https://bugs.webkit.org/show_bug.cgi?id=31442
1872
1873         * BuildSlaveSupport/build.webkit.org-config/config.json:
1874         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1875
1876 2009-11-18  Eric Seidel  <eric@webkit.org>
1877
1878         Reviewed by Darin Adler.
1879
1880         workqueue.py results in totally broken commit-queue UI
1881         https://bugs.webkit.org/show_bug.cgi?id=31645
1882
1883         * Scripts/bugzilla-tool:
1884          - Remove unneeded use of PatchCollection.
1885          - Grab a new copy of the cq'd patches every run of the queue.
1886
1887 2009-11-18  Sam Weinig  <sam@webkit.org>
1888
1889         Reviewed by Anders Carlsson.
1890
1891         Make the Mac Geolocation API async.
1892
1893         Update DRT to use the new async Mac Geolocation API.
1894
1895         * DumpRenderTree/mac/UIDelegate.mm:
1896         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1897
1898 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1899
1900         Reviewed by Kenneth Rohde Christiansen.
1901
1902         Add and option to toggle HTML5 datalist support to build-webkit
1903         https://bugs.webkit.org/show_bug.cgi?id=31599
1904
1905         * Scripts/build-webkit:
1906
1907 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1908
1909         Reviewed by Kevin Ollivier.
1910
1911         Enable wx plugin support using the Windows implementation as a base.
1912         
1913         https://bugs.webkit.org/show_bug.cgi?id=31636
1914
1915         * wx/build/settings.py:
1916
1917 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1918
1919         Reviewed by Simon Hausmann.
1920
1921         Change the initialization order so that the controllers
1922         will be created before exporting them to the JS DOM window.
1923
1924         * DumpRenderTree/qt/DumpRenderTree.cpp:
1925         (WebCore::DumpRenderTree::DumpRenderTree):
1926
1927 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1928
1929         Reviewed by Simon Hausmann.
1930
1931         Fix a code copy and paste error. m_page should be page.
1932
1933         * DumpRenderTree/qt/DumpRenderTree.cpp:
1934         (WebCore::DumpRenderTree::createWindow):
1935
1936 2009-11-17  Mark Rowe  <mrowe@apple.com>
1937
1938         Reviewed by Alexey Proskuryakov.
1939
1940         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
1941
1942         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
1943         This prevents symlinks from confusing the descendant check.
1944
1945 2009-11-17  Mark Rowe  <mrowe@apple.com>
1946
1947         Reviewed by Alexey Proskuryakov.
1948
1949         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
1950
1951         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
1952         server to be up rather than having run-webkit-tests abort immediately.
1953
1954         * Scripts/run-webkit-tests:
1955
1956 2009-11-17  Eric Seidel  <eric@webkit.org>
1957
1958         Reviewed by Darin Adler.
1959
1960         commit-queue is failing to set reviewer in ChangeLogs
1961         https://bugs.webkit.org/show_bug.cgi?id=31592
1962
1963         * Scripts/bugzilla-tool: Clarify the "applying" log message.
1964         * Scripts/modules/bugzilla.py:
1965          - Add a new _validate_committer_and_reviewer function as a
1966            temporary solution until we can make a real Attachment object
1967            which knows how to fill in its committer/reviewer fields automatically.
1968
1969 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1970
1971         Unreviewed buildbot fix.
1972
1973         Revert part of earlier patch and add comment, as it
1974         was causing timeouts on the buildbot.
1975
1976         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1977         (LayoutTestController::notifyDone):
1978
1979 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1980
1981         Reviewed by Oliver Hunt.
1982
1983         Make the timeout 15 sec as for the other DRT's and make
1984         it print out the same output when a test timeout.
1985
1986         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1987         (LayoutTestController::waitUntilDone):
1988         (LayoutTestController::notifyDone):
1989         (LayoutTestController::timerEvent):
1990
1991 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
1992
1993         Reviewed by Timothy Hatcher.
1994
1995         Fixed typos in comments.
1996
1997         * Scripts/modules/committers.py:
1998
1999 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
2000
2001         Reviewed by Timothy Hatcher.
2002
2003         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
2004         - Updated DRT to show/close inspector for all tests under /inspector
2005         - Introduced LayoutTestController::setTimelineProfilingEnabled and
2006           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
2007         - Removed reload on each inspector test
2008         - Renamed fast/inspector to fast/inspector-support in order not to trigger
2009         inspector for those.
2010         - Reimplemented timeline tests in order to get rid of reload there.
2011         - Moved tests that don't require harness into the fast group.
2012
2013         https://bugs.webkit.org/show_bug.cgi?id=31472
2014
2015         * DumpRenderTree/LayoutTestController.cpp:
2016         (setTimelineProfilingEnabledCallback):
2017         (closeWebInspectorCallback):
2018         (LayoutTestController::staticFunctions):
2019         * DumpRenderTree/LayoutTestController.h:
2020         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2021         (shouldOpenWebInspector):
2022         (runTest):
2023         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2024         (LayoutTestController::setTimelineProfilingEnabled):
2025         * DumpRenderTree/mac/DumpRenderTree.mm:
2026         (shouldOpenWebInspector):
2027         (runTest):
2028         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2029         (LayoutTestController::setTimelineProfilingEnabled):
2030         * DumpRenderTree/win/DumpRenderTree.cpp:
2031         (shouldOpenWebInspector):
2032         (runTest):
2033         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2034         (LayoutTestController::setTimelineProfilingEnabled):
2035
2036 2009-11-17  Oliver Hunt  <oliver@apple.com>
2037
2038         Reviewed by Maciej Stachowiak.
2039
2040         Incorrect use of JavaScriptCore API in DumpRenderTree
2041         https://bugs.webkit.org/show_bug.cgi?id=31577
2042
2043         Return undefined rather than a literal null.
2044
2045         * DumpRenderTree/AccessibilityUIElement.cpp:
2046         (setSelectedTextRangeCallback):
2047         (incrementCallback):
2048         (decrementCallback):
2049         (showMenuCallback):
2050
2051 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
2052
2053         Reviewed by Beth Dakin.
2054
2055         AX: aria-labelledby duplicates some of its WAI-ARIA label
2056         https://bugs.webkit.org/show_bug.cgi?id=31565
2057
2058         * DumpRenderTree/AccessibilityUIElement.cpp:
2059         (titleUIElementCallback):
2060         (getIsValidCallback):
2061         (AccessibilityUIElement::getJSClass):
2062
2063 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2064
2065         Reviewed by Simon Hausmann.
2066
2067         r50942 broke output from created windows. Make the
2068         m_enableTextOutput a member of the DRT and not the
2069         WebPage.
2070
2071         * DumpRenderTree/qt/DumpRenderTree.cpp:
2072         (WebCore::WebPage::WebPage):
2073         (WebCore::WebPage::javaScriptAlert):
2074         (WebCore::WebPage::javaScriptConsoleMessage):
2075         (WebCore::WebPage::javaScriptConfirm):
2076         (WebCore::WebPage::javaScriptPrompt):
2077         (WebCore::WebPage::acceptNavigationRequest):
2078         (WebCore::DumpRenderTree::DumpRenderTree):
2079         (WebCore::DumpRenderTree::open):
2080         (WebCore::DumpRenderTree::createWindow):
2081         * DumpRenderTree/qt/DumpRenderTree.h:
2082         (WebCore::DumpRenderTree::setTextOutputEnabled):
2083         (WebCore::DumpRenderTree::isTextOutputEnabled):
2084         (WebCore::WebPage::shouldInterruptJavaScript):
2085         (WebCore::WebPage::isTextOutputEnabled):
2086         (WebCore::WebPage::setViewGeometry):
2087
2088 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2089
2090         Reviewed by Gustavo Noronha Silva.
2091
2092         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
2093         as the implementation is being used by at least Qt and Gtk+.
2094
2095         Update buildsystems as well.
2096
2097         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2098         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
2099         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
2100         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
2101         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2102         * GNUmakefile.am:
2103
2104 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
2105
2106         Reviewed by Alexey Proskuryakov.
2107
2108         Disable wss until all platforms support pyOpenSSL
2109
2110         https://bugs.webkit.org/show_bug.cgi?id=31479
2111
2112         * Scripts/run-webkit-tests:
2113
2114 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
2115
2116         Reviewed by Kenneth Christiansen.
2117
2118         [Qt] Implement load error pages support for Qt's DRT.
2119         https://bugs.webkit.org/show_bug.cgi?id=31509
2120
2121         For now, it will not be a default feature, and layout tests
2122         that want to make use of this have to explicitily call
2123         'handleErrorPages();' for the test source.
2124
2125         Any of the other DumpRenderTree's (mac, win and gtk)
2126         support handling error pages. Qt's will be the first.
2127
2128         * DumpRenderTree/qt/DumpRenderTree.cpp:
2129         (WebCore::WebPage::supportsExtension):
2130         (WebCore::WebPage::extension):
2131         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2132         (LayoutTestController::reset):
2133         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2134         (LayoutTestController::shouldHandleErrorPages):
2135         (LayoutTestController::handleErrorPages):
2136
2137 2009-11-16  Eric Seidel  <eric@webkit.org>
2138
2139         Reviewed by Adam Barth.
2140
2141         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
2142         https://bugs.webkit.org/show_bug.cgi?id=31549
2143
2144         Renamed --commit-queue to --non-interactive in most places
2145         and remove the code in land-patches which is no longer needed.
2146
2147         * Scripts/bugzilla-tool:
2148
2149 2009-11-16  Eric Seidel  <eric@webkit.org>
2150
2151         Reviewed by Adam Barth.
2152
2153         The commit-queue should use land-attachment
2154         https://bugs.webkit.org/show_bug.cgi?id=31548
2155
2156         * Scripts/bugzilla-tool:
2157
2158 2009-11-16  Adam Barth  <abarth@webkit.org>
2159
2160         Reviewed by Eric Seidel.
2161
2162         Convert CommitQueue over to PatchCollection
2163         https://bugs.webkit.org/show_bug.cgi?id=31547
2164
2165         Also fixes a bug in workqueue and adds a test!
2166
2167         * Scripts/bugzilla-tool:
2168         * Scripts/modules/workqueue.py:
2169         * Scripts/modules/workqueue_unittest.py:
2170
2171 2009-11-16  Adam Barth  <abarth@webkit.org>
2172
2173         Reviewed by Eric Seidel.
2174
2175         Move StyleQueue over to using PatchCollection
2176         https://bugs.webkit.org/show_bug.cgi?id=31544
2177
2178         That's what the class it's for.
2179
2180         * Scripts/bugzilla-tool:
2181         * Scripts/modules/patchcollection.py:
2182         * Scripts/modules/patchcollection_unittest.py:
2183
2184 2009-11-16  Eric Seidel  <eric@webkit.org>
2185
2186         Reviewed by Adam Barth.
2187
2188         bugzilla-tool needs a land-attachment command
2189         https://bugs.webkit.org/show_bug.cgi?id=31546
2190
2191         * Scripts/bugzilla-tool:
2192          - Move all the logic into AbstractLandingCommand and
2193            add a new LandAttachment command subclass.
2194          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
2195
2196 2009-11-16  Eric Seidel  <eric@webkit.org>
2197
2198         Reviewed by Adam Barth.
2199
2200         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
2201         https://bugs.webkit.org/show_bug.cgi?id=31543
2202
2203         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
2204
2205         * Scripts/bugzilla-tool:
2206
2207 2009-11-16  Eric Seidel  <eric@webkit.org>
2208
2209         Reviewed by Adam Barth.
2210
2211         Disable the style queue from posting to the commit queue status page.
2212
2213         * Scripts/bugzilla-tool:
2214
2215 2009-11-16  Adam Barth  <abarth@webkit.org>
2216
2217         Reviewed by Eric Seidel.
2218
2219         Implement PatchCollection
2220         https://bugs.webkit.org/show_bug.cgi?id=31541
2221
2222         This class holds a set of patches and lets clients iterate through
2223         them.  Optionally, clients can install a filter.
2224
2225         * Scripts/modules/patchcollection.py: Added.
2226         * Scripts/modules/patchcollection_unittest.py: Added.
2227         * Scripts/run-webkit-unittests:
2228
2229 2009-11-16  Eric Seidel  <eric@webkit.org>
2230
2231         Reviewed by Adam Barth.
2232
2233         bugzilla-tool land-patches will close bugs with patches r=?
2234         https://bugs.webkit.org/show_bug.cgi?id=28230
2235
2236         The commit-queue shouldn't close patches with outstanding reviews on them,
2237         even if many reviewers seem to be against multi-patch bugs.
2238
2239         * Scripts/bugzilla-tool:
2240
2241 2009-11-16  Eric Seidel  <eric@webkit.org>
2242
2243         Reviewed by Adam Barth.
2244
2245         bugzilla-tool check-style should work with attachment ids instead of bug ids
2246         https://bugs.webkit.org/show_bug.cgi?id=31540
2247
2248         * Scripts/bugzilla-tool:
2249
2250 2009-11-16  Eric Seidel  <eric@webkit.org>
2251
2252         Reviewed by Adam Barth.
2253
2254         WorkQueue is the only place that should know about special exit codes
2255         https://bugs.webkit.org/show_bug.cgi?id=31534
2256
2257         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
2258         and add tests for handling exit codes.
2259         I also cleaned up workqueue_unittest.py more.
2260
2261         * Scripts/bugzilla-tool:
2262         * Scripts/modules/workqueue.py:
2263         * Scripts/modules/workqueue_unittest.py:
2264
2265 2009-11-16  Eric Seidel  <eric@webkit.org>
2266
2267         Reviewed by Adam Barth.
2268
2269         Re-factor workqueue_unittest to allow for more than one test.
2270         https://bugs.webkit.org/show_bug.cgi?id=31535
2271
2272         * Scripts/modules/workqueue_unittest.py:
2273
2274 2009-11-16  Eric Seidel  <eric@webkit.org>
2275
2276         Reviewed by Adam Barth.
2277
2278         land-patches needs to be re-factored into smaller chunks
2279         https://bugs.webkit.org/show_bug.cgi?id=31532
2280
2281         * Scripts/bugzilla-tool: fix a couple obvious typos.
2282
2283 2009-11-16  Eric Seidel  <eric@webkit.org>
2284
2285         Reviewed by Adam Barth.
2286
2287         land-patches needs to be re-factored into smaller chunks
2288         https://bugs.webkit.org/show_bug.cgi?id=31532
2289
2290         The next patch will move these methods into WebKitLandingScripts.
2291
2292         * Scripts/bugzilla-tool:
2293          - Split out _land_patch and _close_bug_if_no_active_patches.
2294
2295 2009-11-16  Adam Barth  <abarth@webkit.org>
2296
2297         Reviewed by Eric Seidel.
2298
2299         Fix silly copy-and-paste code.  I am a terrible coder.
2300
2301         * Scripts/modules/bugzilla.py:
2302
2303 2009-11-16  Adam Barth  <abarth@webkit.org>
2304
2305         Reviewed by Eric Seidel.
2306
2307         Implement a StyleQueue
2308         https://bugs.webkit.org/show_bug.cgi?id=31537
2309
2310         The first iteration of the style queue only produces output locally.
2311         There is also a limit of 10 patches because it's not that useful to
2312         iterate through the entire review queue at this point.  We can remove
2313         the limit later.
2314
2315         * Scripts/bugzilla-tool:
2316         * Scripts/modules/bugzilla.py:
2317
2318 2009-11-16  Adam Barth  <abarth@webkit.org>
2319
2320         Reviewed by Eric Seidel.
2321
2322         Unit test WorkQueue
2323         https://bugs.webkit.org/show_bug.cgi?id=31531
2324
2325         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
2326
2327         * Scripts/bugzilla-tool:
2328         * Scripts/modules/statusbot.py:
2329         * Scripts/modules/workqueue.py:
2330         * Scripts/modules/workqueue_unittest.py: Added.
2331         * Scripts/run-webkit-unittests:
2332
2333 2009-11-16  Eric Seidel  <eric@webkit.org>
2334
2335         Reviewed by Adam Barth.
2336
2337         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
2338         https://bugs.webkit.org/show_bug.cgi?id=31530
2339
2340         * Scripts/bugzilla-tool:
2341
2342 2009-11-16  Eric Seidel  <eric@webkit.org>
2343
2344         Reviewed by Adam Barth.
2345
2346         bugzilla-tool needs apply-attachment
2347         https://bugs.webkit.org/show_bug.cgi?id=31528
2348
2349         * Scripts/bugzilla-tool:
2350          - Add ApplyAttachment command.
2351          - Abstract applying code into WebKitApplyingScripts.
2352          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
2353         * Scripts/modules/bugzilla.py:
2354          - Add fetch_attachment and bug_id_for_attachment_id.
2355         * Scripts/modules/bugzilla_unittest.py:
2356          - Add test for new parsing.
2357          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
2358
2359 2009-11-16  Eric Seidel  <eric@webkit.org>
2360
2361         Reviewed by Adam Barth.
2362
2363         Document check-style's use of force_clean.
2364
2365         * Scripts/bugzilla-tool:
2366         * Scripts/modules/scm.py:
2367
2368 2009-11-16  Adam Barth  <abarth@webkit.org>
2369
2370         Reviewed by Eric Seidel.
2371
2372         Move WorkQueue to its own file
2373         https://bugs.webkit.org/show_bug.cgi?id=31529
2374
2375         WorkQueue and WorkQueueDelegate are separate concerns from
2376         bugzilla-tool.  Also added a missing include to logging.py.
2377
2378         * Scripts/bugzilla-tool:
2379         * Scripts/modules/logging.py:
2380         * Scripts/modules/workqueue.py:
2381
2382 2009-11-16  Adam Barth  <abarth@webkit.org>
2383
2384         Reviewed by Eric Seidel.
2385
2386         Move OutputTee to logging.py.
2387
2388         * Scripts/bugzilla-tool:
2389         * Scripts/modules/logging.py:
2390
2391 2009-11-15  Adam Barth  <abarth@webkit.org>
2392
2393         Reviewed by Eric Seidel.
2394
2395         Refactor bugzilla-tool to allow for multiple queues
2396         https://bugs.webkit.org/show_bug.cgi?id=31513
2397
2398         Divide the commit queue class into three class to make creating
2399         additional queues easier.
2400
2401         * Scripts/bugzilla-tool:
2402
2403 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
2404
2405         Reviewed by Eric Seidel.
2406
2407         svn-apply may not handle git patches created by bugzilla-tool
2408         https://bugs.webkit.org/show_bug.cgi?id=31457
2409
2410         * Scripts/modules/scm.py:
2411         * Scripts/modules/scm_unittest.py:
2412
2413 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
2414
2415         Reviewed by Eric Seidel.
2416
2417         bugzilla-tool should post git binary diff
2418         https://bugs.webkit.org/show_bug.cgi?id=31458
2419
2420         Add --binary option to Git.create_patch.
2421
2422         * Scripts/modules/scm.py:
2423         * Scripts/modules/scm_unittest.py:
2424
2425 2009-11-15  Adam Barth  <abarth@webkit.org>
2426
2427         Reviewed by Darin Adler.
2428
2429         Add bugzilla-tool check-style
2430         https://bugs.webkit.org/show_bug.cgi?id=31515
2431
2432         * Scripts/bugzilla-tool:
2433         * Scripts/modules/bugzilla.py:
2434
2435 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2436
2437         Reviewed by Simon Hausmann.
2438
2439         Make the Qt Linux only --valgrind feature, suppress errors
2440         defined in the SuppressedValgrindErrors file.
2441
2442         * Scripts/run-webkit-tests:
2443
2444 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2445
2446         Reviewed by Simon Hausmann.
2447
2448         Set the locale to C and not to the current one in use on the system.
2449
2450         * DumpRenderTree/qt/DumpRenderTree.cpp:
2451         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2452
2453 2009-11-13  Adam Roben  <aroben@apple.com>
2454
2455         Add support for
2456         http/tests/security/isolatedWorld/didClearWindowObject.html
2457
2458         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
2459         window objects in isolated worlds are cleared
2460
2461         Reviewed by Dave Hyatt.
2462
2463         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
2464
2465         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2466         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2467         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
2468         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
2469         Added. Sets a __worldID property on the global object whose value is
2470         the ID of this world.
2471         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
2472         Respond to this new delegate callback by calling through to one of the
2473         above new methods.
2474         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2475         (worldMap): Added. Returns a HashMap containing all the worlds we've
2476         created.
2477         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
2478         haven't kept track of this world.
2479         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
2480         instead of declaring our own.
2481
2482         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
2483
2484         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2485         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
2486         didClearWindowObjectForFrameInStandardWorld.
2487         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
2488         Respond to this new delegate callback by calling through to one of the
2489         below new methods.
2490         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
2491         Added. Sets a __worldID property on the gobal object whose value is
2492         the ID of this world.
2493         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
2494         Added. Moved code here from didClearWindowObject.
2495
2496         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
2497         didClearWindowObjectForFrame* functions.
2498
2499         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2500         (worldMap): Added. Returns a HashMap containing all the worlds we've
2501         created.
2502         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
2503         haven't kept track of this world.
2504         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
2505         instead of declaring our own.
2506
2507 2009-11-13  Adam Roben  <aroben@apple.com>
2508
2509         Finish replacing worldIDs with world objects
2510
2511         The only remaining use of worldIDs was in a method only used by DRT
2512         for the isolated worlds tests.
2513
2514         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
2515
2516         Reviewed by Mark Rowe.
2517
2518         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2519         (LayoutTestController::evaluateScriptInIsolatedWorld):
2520         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2521         (LayoutTestController::evaluateScriptInIsolatedWorld):
2522         Updated for changes to WebFrame. Now holds the map of worldID -> world
2523         at this level instead of making WebKit do it.
2524
2525 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2526
2527         Reviewed by Simon Hausmann.
2528
2529         [Qt] Ensure the DRT does not output anything until first test is run
2530
2531         * DumpRenderTree/qt/DumpRenderTree.cpp:
2532         * DumpRenderTree/qt/DumpRenderTree.h:
2533
2534 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2535
2536         Reviewed by Tor Arne Vestbø.
2537
2538         Clear the undo stack in before each new test run.
2539
2540         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
2541
2542         * DumpRenderTree/qt/DumpRenderTree.cpp:
2543         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2544
2545 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2546
2547         Reviewed by Kenneth Rohde Christiansen.
2548
2549         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
2550
2551         * DumpRenderTree/qt/DumpRenderTree.cpp:
2552         (WebCore::WebPage::resetSettings):
2553         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2554         (LayoutTestController::overridePreference):
2555
2556 2009-11-13  Eric Seidel  <eric@webkit.org>
2557
2558         Reviewed by Adam Barth.
2559
2560         Update committers.py based on svn records
2561         https://bugs.webkit.org/show_bug.cgi?id=31366
2562
2563         This list was generated using validate-committer-lists from
2564         https://bugs.webkit.org/show_bug.cgi?id=30970
2565         and makes committers.py current for committers who have
2566         committed in the last 3 years.
2567
2568         * Scripts/modules/committers.py:
2569
2570 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
2571
2572         Reviewed by Adam Barth.
2573
2574         The document-open.html test was flaky at times. The test invokes the layout test plugin
2575         which in its destroy stream handler opens a new document. This basically tears down the
2576         stream and the associated plugin instance. The pluginLog function in the layout test
2577         plugin attempts to retrieve the window script object on a torn down plugin instance
2578         which crashed consistently on windows in the debugger. The functions which issue
2579         these logs already have a valid window script object. We now have variants of the pluginLog
2580         function which take in a window script object with and without variable arguments. 
2581
2582         https://bugs.webkit.org/show_bug.cgi?id=31067
2583
2584         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2585         (pluginLogWithWindowObject):
2586         (pluginLogWithWindowObjectVariableArgs):
2587         (pluginLog):
2588         (notifyTestCompletion):
2589         (testDocumentOpen):
2590         (testWindowOpen):
2591
2592 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2593
2594         Reviewed by Gustavo Noronha Silva.
2595
2596         https://bugs.webkit.org/show_bug.cgi?id=30997
2597         [Gtk] Implemment AtkDocument
2598
2599         Added testing support.
2600
2601         * DumpRenderTree/AccessibilityUIElement.cpp:
2602         * DumpRenderTree/AccessibilityUIElement.h:
2603         (getDocumentEncodingCallback):
2604         (getDocumentURICallback):
2605         (AccessibilityUIElement::getJSClass):
2606         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2607         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2608         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2609         (AccessibilityUIElement::documentEncoding):
2610         (AccessibilityUIElement::documentURI):
2611
2612 2009-11-12  Adam Roben  <aroben@apple.com>
2613
2614         Replace worldIDs with world objects
2615
2616         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
2617         user scripts/stylesheets and isolated worlds
2618
2619         Reviewed by Sam Weinig.
2620
2621         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2622         (LayoutTestController::addUserScript):
2623         (LayoutTestController::addUserStyleSheet):
2624         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2625         (LayoutTestController::addUserScript):
2626         (LayoutTestController::addUserStyleSheet):
2627         Changed these functions to create a new WebJSWorld each time they're
2628         called and to pass that world to WebKit.
2629
2630 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
2631
2632         Reviewed by Oliver Hunt.
2633
2634         need to implement aria tree roles
2635         https://bugs.webkit.org/show_bug.cgi?id=31284
2636
2637         * DumpRenderTree/AccessibilityUIElement.cpp:
2638         (disclosedRowAtIndexCallback):
2639         (selectedRowAtIndexCallback):
2640         (isEqualCallback):
2641         (isAttributeSettableCallback):
2642         (isActionSupportedCallback):
2643         (disclosedByRowCallback):
2644         (hierarchicalLevelCallback):
2645         (AccessibilityUIElement::getJSClass):
2646         * DumpRenderTree/AccessibilityUIElement.h:
2647         (AccessibilityUIElement::isEqual):
2648         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2649         (AccessibilityUIElement::hierarchicalLevel):
2650         (AccessibilityUIElement::disclosedRowAtIndex):
2651         (AccessibilityUIElement::selectedRowAtIndex):
2652         (AccessibilityUIElement::disclosedByRow):
2653         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2654         (AccessibilityUIElement::getChildAtIndex):
2655         (AccessibilityUIElement::disclosedRowAtIndex):
2656         (AccessibilityUIElement::selectedRowAtIndex):
2657         (AccessibilityUIElement::titleUIElement):
2658         (AccessibilityUIElement::parentElement):
2659         (AccessibilityUIElement::disclosedByRow):
2660         (AccessibilityUIElement::hierarchicalLevel):
2661         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2662         (AccessibilityUIElement::hierarchicalLevel):
2663         (AccessibilityUIElement::disclosedRowAtIndex):
2664         (AccessibilityUIElement::selectedRowAtIndex):
2665         (AccessibilityUIElement::disclosedByRow):
2666
2667 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
2668
2669         Reviewed by Darin Adler.
2670
2671         svn-apply can not handle git binary diffs
2672         https://bugs.webkit.org/show_bug.cgi?id=26830
2673
2674         Support "literal" type git binary diffs.
2675
2676         * Scripts/VCSUtils.pm:
2677         * Scripts/modules/scm_unittest.py:
2678         * Scripts/svn-apply:
2679
2680 2009-11-11  Dmitry Titov  <dimich@chromium.org>
2681
2682         Not reviewed, removing duplicate entry for myself in committers.py.
2683
2684         * Scripts/modules/committers.py:
2685
2686 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
2687
2688         Reviewed by Darin Adler and Mark Rowe.
2689
2690         https://bugs.webkit.org/show_bug.cgi?id=31200
2691         Tests in http/tests/security/mixedContent start to fail when new tests are added
2692
2693         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
2694
2695 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2696
2697         Reviewed by Jan Alonzo.
2698
2699         Create, and display a window for the inspector, for inspector
2700         tests.
2701
2702         Need to also show/hide the inspector window to avoid having
2703         problems with code assuming it is realized
2704         https://bugs.webkit.org/show_bug.cgi?id=31347
2705
2706         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2707         (webInspectorShowWindow):
2708         (webInspectorCloseWindow):
2709         (webInspectorInspectWebView):
2710         (createWebView):
2711
2712 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2713
2714         Unreviewed Qt buildbot fix.
2715
2716         My previous fix was wrong, so revert that change and fix it by
2717         returning when the document of the frame has no document element.
2718         Idea is borrowed from mac and win DRT.
2719
2720         * DumpRenderTree/qt/DumpRenderTree.cpp:
2721         (WebCore::DumpRenderTree::dumpFramesAsText):
2722
2723 2009-11-11  Eric Seidel  <eric@webkit.org>
2724
2725         Reviewed byg Kenneth Rohde Christiansen.
2726
2727         Update Kenneth's committer record to include the email he
2728         uses on lists.webkit.org.
2729
2730         * Scripts/modules/committers.py:
2731
2732 2009-11-11  Eric Seidel  <eric@webkit.org>
2733
2734         Reviewed by Gustavo Noronha Silva.
2735
2736         Several committers use separate email addresses for bugzilla and svn.webkit.org
2737         https://bugs.webkit.org/show_bug.cgi?id=31364
2738
2739         Update records for existing committers to include email addresses
2740         used in svn.webkit.org and lists.webkit.org.
2741         Most committers use the same email address in all 3 places, but some use
2742         separate addresses.  committers.py needs record of each of these addresses.
2743
2744         * Scripts/modules/committers.py:
2745
2746 2009-11-11  Eric Seidel  <eric@webkit.org>
2747
2748         No review, adding second email address for an existing committer.
2749
2750         Add Yong Li's second bugzilla account to his committer record.
2751         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
2752
2753         * Scripts/modules/committers.py:
2754
2755 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2756
2757         Reviewed by Simon Hausmann.
2758
2759         If the frame has no innerText don't append it, and
2760         do not add a newline which breaks some cross platform
2761         results.
2762
2763         * DumpRenderTree/qt/DumpRenderTree.cpp:
2764         (WebCore::DumpRenderTree::dumpFramesAsText):
2765
2766 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2767
2768         Reviewed by Simon Hausmann.
2769
2770         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
2771
2772         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2773         (webkit_test_plugin_new_instance):
2774         (webkit_test_plugin_destroy_instance):
2775         (webkit_test_plugin_destroy_stream):
2776
2777 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2778
2779         Reviewed by Mark Rowe.
2780
2781         Implement the functionality needed by plugins/window-open.html
2782
2783         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2784         (webkit_test_plugin_new_instance):
2785         (webkit_test_plugin_set_window):
2786
2787 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2788
2789         Reviewed by Simon Hausmann.
2790
2791         [Qt] Force -graphicssystem raster and -style windows when running DRT
2792
2793         * DumpRenderTree/qt/main.cpp:
2794         * Scripts/run-webkit-tests:
2795
2796 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2797
2798         Reviewed by Simon Hausmann.
2799
2800         Compute correct library paths for Qt
2801
2802         * Scripts/webkitdirs.pm:
2803
2804 2009-11-10  Mark Rowe  <mrowe@apple.com>
2805
2806         Reviewed by Sam Weinig.
2807
2808         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
2809
2810         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
2811         about the validity of the self-signed certificates used in the regression tests.  We would then add the
2812         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
2813         that had enabled frame load delegate logging this would result in extra log messages being generated,
2814         causing the test to fail.
2815
2816         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
2817         tests.
2818
2819         * DumpRenderTree/mac/DumpRenderTree.mm:
2820         (dumpRenderTree):
2821         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2822         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2823
2824 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2825
2826         Reviewed by Kenneth Rohde Christiansen.
2827
2828         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
2829
2830         * DumpRenderTree/qt/DumpRenderTree.cpp:
2831         (WebCore::DumpRenderTree::DumpRenderTree):
2832
2833 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2834
2835         Reviewed by Jan Alonzo.
2836
2837         [GTK] Remove WebSocket configuration from WebKitWebSettings
2838         https://bugs.webkit.org/show_bug.cgi?id=31244
2839
2840         Follow-up of r50724. Don't set the enable-web-socket property
2841         anymore.
2842
2843         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2844         (resetDefaultsToConsistentValues):
2845
2846 2009-11-10  Oliver Hunt  <oliver@apple.com>
2847
2848         Reviewed by Maciej Stachowiak.
2849
2850         Rename 3D Canvas related classes to use WebGL prefix
2851         https://bugs.webkit.org/show_bug.cgi?id=29095
2852
2853         Checkin new version of do-webcore-rename used to do the WebGL type rename,
2854         and upate webkitdirs script to new method of testing for WebGL.
2855
2856         * Scripts/do-webcore-rename:
2857         * Scripts/webkitdirs.pm:
2858
2859 2009-11-09  Oliver Hunt  <oliver@apple.com>
2860
2861         Reviewed by Geoff Garen.
2862
2863         Make do-webcore-rename work with git.
2864
2865         * Scripts/do-webcore-rename:
2866
2867 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2868
2869         Adding Kenneth to the reviewers list.
2870
2871         * Scripts/modules/committers.py:
2872
2873 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2874
2875         Reviewed by Jan Alonzo.
2876
2877         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2878         https://bugs.webkit.org/show_bug.cgi?id=30482
2879
2880         LayoutTestControllerGtk now uses the exposed
2881         Page::tabKeyCyclesThroughElements API
2882
2883         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2884         (LayoutTestController::setTabKeyCyclesThroughElements):
2885
2886 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
2887
2888         Reviewed by Holger Freyther.
2889
2890         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
2891         This helps to pass the test case below. Also replaced hardcoded
2892         code numbers with defined constants.
2893         https://bugs.webkit.org/show_bug.cgi?id=31185
2894         
2895         Test: editing/undo/undo-deleteWord.html
2896
2897         * DumpRenderTree/qt/EventSenderQt.cpp:
2898         (EventSender::keyDown):
2899
2900 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
2901
2902         Reviewed by Holger Freyther.
2903
2904         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
2905         https://bugs.webkit.org/show_bug.cgi?id=31164
2906
2907         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
2908
2909         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2910         (LayoutTestController::processWork):
2911
2912 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
2913
2914         Reviewed by Holger Freyther.
2915
2916         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
2917         https://bugs.webkit.org/show_bug.cgi?id=31158
2918
2919         By invoking a script queue'd by queueScript(), 'true' was beeing returned
2920         always, which from WorkQueue prospective means that a load has been started
2921         and the queue processing should stop and wait for the load to finish.
2922         Spinning it off into a loading and a non-loading variants was the solution
2923         adopted by Mac's DRT to work around this problem. The former keeps returning
2924         'true' while the later executes the script synchronously and returns 'false'
2925         making it possible to the WorkQueue to proceed right away.
2926
2927         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2928         (LayoutTestController::processWork):
2929         (LayoutTestController::queueLoadingScript):
2930         (LayoutTestController::queueNonLoadingScript):
2931         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2932         * DumpRenderTree/qt/WorkQueueItem.h:
2933         (LoadingScriptItem::LoadingScriptItem):
2934         (LoadingScriptItem::invoke):
2935         (NonLoadingScriptItem::NonLoadingScriptItem):
2936         (NonLoadingScriptItem::invoke):
2937
2938 2009-11-07  Mark Rowe  <mrowe@apple.com>
2939
2940         Rubber-stamped by Cameron Zwarich.
2941
2942         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
2943
2944         * Scripts/commit-log-editor:
2945
2946 2009-11-07  Mark Rowe  <mrowe@apple.com>
2947
2948         Reviewed by Darin Adler.
2949
2950         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
2951         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
2952
2953         Move logic for determining the name and email address to use in a ChangeLog entry from
2954         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
2955         whether the author of the patch matches committer, and therefore needs access to the
2956         email address that would be used in a ChangeLog entry.
2957
2958         Based on a patch by Pierre d'Herbemont.
2959
2960         * Scripts/VCSUtils.pm:
2961         * Scripts/commit-log-editor:
2962         * Scripts/prepare-ChangeLog:
2963         * Scripts/webkitdirs.pm:
2964
2965 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2966
2967         Reviewed by Adam Barth.
2968
2969         Added functionality to the layout test plugin to invoke document.open and
2970         window.open with default arguments. The associated webkit bug is
2971         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
2972         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
2973         work in Chromium (V8) if there is no calling javascript context. To achieve this
2974         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
2975         for the window.open test case and in NPP_DestroyStream for the document.open test case.
2976
2977         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2978         (testDocumentOpen):
2979         (testWindowOpen):
2980         (pluginAllocate):
2981         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2982         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2983         (NPP_New):
2984         (NPP_SetWindow):
2985         (NPP_DestroyStream):
2986         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2987         (NPP_New):
2988         (NPP_SetWindow):
2989         (NPP_NewStream):
2990         (NPP_DestroyStream):
2991
2992 2009-11-06  Eric Seidel  <eric@webkit.org>
2993
2994         Reviewed by Adam Barth.
2995
2996         bugzilla-tool crashed with exception
2997         https://bugs.webkit.org/show_bug.cgi?id=31092
2998
2999         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
3000
3001 2009-11-04  Eric Seidel  <eric@webkit.org>
3002
3003         No review, just add a line which got left out of the patch uploaded for commit.
3004
3005         commit-queue is crashing when trying to reject patches after unknown failures
3006         https://bugs.webkit.org/show_bug.cgi?id=31091
3007
3008         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
3009
3010 2009-11-04  Adam Roben  <aroben@apple.com>
3011
3012         Remove bogus else clause in bugzilla-tool
3013
3014         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
3015         create-bug raises exception after entering bug description
3016
3017         Reviewed by David Kilzer.
3018
3019         * Scripts/bugzilla-tool:
3020         (CreateBug): else clauses are only hit if no exception is raised, so
3021         it makes no sense to try to re-raise the exception in an else clause.
3022         The exception will automatically be re-raised if it doesn't match any
3023         of the except clauses, so we don't have to do anything special here at
3024         all to get the desired behavior.
3025
3026 2009-11-04  Eric Seidel  <eric@webkit.org>
3027
3028         Reviewed by David Kilzer.
3029
3030         svn-apply's fixChangeLogPatch function seems broken
3031         https://bugs.webkit.org/show_bug.cgi?id=30683
3032
3033         Update fixChangeLogPatch to be able to handle patches which
3034         don't start at line 1.
3035         Add unit tests for svn-apply to scm_unittest.py.
3036
3037         * Scripts/VCSUtils.pm:
3038         * Scripts/modules/scm_unittest.py:
3039
3040 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
3041
3042         Reviewed by Beth Dakin.
3043
3044         Need to implement ARIA role="combobox"
3045         https://bugs.webkit.org/show_bug.cgi?id=31096
3046
3047         * DumpRenderTree/AccessibilityUIElement.cpp:
3048         (showMenuCallback):
3049         (getIsExpandedCallback):
3050         (AccessibilityUIElement::getJSClass):
3051         * DumpRenderTree/AccessibilityUIElement.h:
3052         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3053         (AccessibilityUIElement::isExpanded):
3054         (AccessibilityUIElement::showMenu):
3055         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3056         (AccessibilityUIElement::isExpanded):
3057         (AccessibilityUIElement::showMenu):
3058         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3059         (AccessibilityUIElement::isSelected):
3060         (AccessibilityUIElement::isExpanded):
3061         (AccessibilityUIElement::showMenu):
3062
3063 2009-11-04  Eric Seidel  <eric@webkit.org>
3064
3065         Reviewed by Adam Barth.
3066
3067         commit-queue is crashing when trying to reject patches after unknown failures
3068         https://bugs.webkit.org/show_bug.cgi?id=31091
3069
3070         * Scripts/bugzilla-tool:
3071          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
3072            so we have to find out what the current patch is by asking bugzilla again.
3073          - Discovered that this code was also leaking file descriptors, so fixed that.
3074
3075 2009-11-04  Adam Roben  <aroben@apple.com>
3076
3077         Make run-webkit-tests work for the Debug_Internal Windows
3078         configuration
3079
3080         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
3081         suffix.
3082
3083         Fixes <http://webkit.org/b/31123>.
3084
3085         Reviewed by Sam Weinig.
3086
3087         * Scripts/run-webkit-tests: Don't add the _debug suffix in
3088         Debug_Internal, either.
3089
3090 2009-11-04  Eric Seidel  <eric@webkit.org>
3091
3092         Reviewed by Adam Barth.
3093
3094         committers.py needs a way to store non-bugzilla email addresses
3095         https://bugs.webkit.org/show_bug.cgi?id=31037
3096
3097         Make Committer and Reviewer constructors take a single email or a list of emails.
3098         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
3099         Expose reviewers(), used by validate-committer-lists on bug 30970.
3100
3101         * Scripts/modules/committers.py:
3102         * Scripts/modules/committers_unittest.py: Added tests for the new code.
3103
3104 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
3105
3106         Reviewed by David Levin.
3107
3108         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
3109         https://bugs.webkit.org/show_bug.cgi?id=27491
3110
3111         The test path determination logic is changed to handle websocket and websocket/ssl cases.
3112         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
3113
3114         Functions to start or stop Web Socket servers are added.
3115
3116         * Scripts/run-webkit-tests:
3117
3118 2009-11-03  Eric Seidel  <eric@webkit.org>
3119
3120         No review, just changing wording of log message.
3121
3122         Change log string to say "failed" instead of "rejected"
3123         when a commit fails due to an out of date checkout.
3124         This makes grepping the commit-queue log for rejected patches easier.
3125
3126         * Scripts/bugzilla-tool:
3127
3128 2009-11-03  Eric Seidel  <eric@webkit.org>
3129
3130         No review, adding commonly known committers missing from the file.
3131
3132         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
3133
3134 2009-11-03  Eric Seidel  <eric@webkit.org>
3135
3136         No review, just sort-order cleanup.
3137
3138         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
3139
3140 2009-11-03  Stephen White  <senorblanco@chromium.org>
3141
3142         (Unreviewed).
3143
3144         Add myself to committers.py.
3145
3146         * Scripts/modules/committers.py:
3147
3148 2009-11-03  Robin Dunn  <robin@alldunn.com>
3149
3150         Reviewed by Kevin Ollviier.
3151
3152         Add packaging scripts for Debian-based Linux distros.
3153         
3154         https://bugs.webkit.org/show_bug.cgi?id=31075
3155
3156         * wx/packaging/build-debian-installer.py: Added.
3157         * wx/packaging/debian: Added.
3158
3159 2009-11-03  Dan Bernstein  <mitz@apple.com>
3160
3161         Reviewed by Anders Carlsson and Beth Dakin.
3162
3163         https://bugs.webkit.org/show_bug.cgi?id=31070
3164
3165         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
3166         destroyed, it executes the value of the 'ondestroy' parameter as a
3167         script.
3168
3169         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3170         (pluginAllocate): Initialize onDestroy.
3171         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
3172         onDestroy.
3173         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3174         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
3175         specified.
3176         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
3177
3178 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
3179
3180         Reviewed by Xan Lopez.
3181
3182         https://bugs.webkit.org/show_bug.cgi?id=31035
3183         [GTK] some accessibility tests hitting assertion in debug builds
3184
3185         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
3186
3187         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3188         (AccessibilityController::rootElement):
3189
3190 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
3191
3192         Reviewed by Beth Dakin.
3193
3194         Support ARIA "tab" roles
3195         https://bugs.webkit.org/show_bug.cgi?id=30842
3196
3197         * DumpRenderTree/AccessibilityUIElement.cpp:
3198         * DumpRenderTree/AccessibilityUIElement.h:
3199         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3200         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3201         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3202
3203 2009-11-01  Eric Seidel  <eric@webkit.org>
3204
3205         Reviewed by David Levin.
3206
3207         buildbots should use --exit-after-N-failures
3208         https://bugs.webkit.org/show_bug.cgi?id=30809
3209
3210         Make the bots exit after 20 failures to prevent never-ending
3211         test runs where every test spends a minute crashing.
3212
3213         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3214
3215 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3216
3217         Reviewed by Eric Seidel.
3218
3219         Turn on warnings for QtWebKit for gcc
3220         https://bugs.webkit.org/show_bug.cgi?id=30958
3221
3222         * DumpRenderTree/qt/main.cpp: 
3223         (crashHandler): Mark function NO_RETURN
3224
3225 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
3226
3227         Adding myself to the committers list.
3228
3229         * Scripts/modules/committers.py:
3230
3231 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
3232
3233         Fix an issue that Adam noticed in DRT.
3234
3235         Reviewed by Darin Adler.
3236
3237         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3238         (AccessibilityUIElement::role):
3239         Get the length of the role text, and create a buffer dynamically.
3240
3241 2009-10-30  Eric Seidel  <eric@webkit.org>
3242
3243         No review, rolling out r50105.
3244         http://trac.webkit.org/changeset/50105
3245
3246         This commit was causing:
3247         https://bugs.webkit.org/show_bug.cgi?id=30869
3248         We'll re-implement the feature a different way.
3249
3250         * Scripts/bugzilla-tool:
3251
3252 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
3253
3254         Test for MSAA: Accessibility of headings is not correct
3255
3256         https://bugs.webkit.org/show_bug.cgi?id=30937
3257
3258         Reviewed by Adam Roben.
3259
3260         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3261         (AccessibilityUIElement::role):
3262         Allow the role returned to be a BSTR.
3263         (AccessibilityUIElement::description):
3264         Fix a copy/paste error.
3265
3266 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
3267
3268         Test for MSAA: Accessibility of links is wrong
3269
3270         https://bugs.webkit.org/show_bug.cgi?id=30928
3271
3272         Reviewed by Darin Adler.
3273
3274         * DumpRenderTree/AccessibilityUIElement.cpp:
3275         (getAccessibilityValueCallback):
3276         Return the accessibility value.
3277         (AccessibilityUIElement::getJSClass):
3278         Added "accessibilityValue" value.
3279
3280         * DumpRenderTree/AccessibilityUIElement.h:
3281
3282         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3283         (AccessibilityUIElement::accessibilityValue):
3284         Stubbed.
3285
3286         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3287         (AccessibilityUIElement::accessibilityValue):
3288         Stubbed.
3289
3290         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3291         (AccessibilityUIElement::accessibilityValue):
3292         Get the object's value, and return it as a JS string.
3293
3294 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
3295
3296         Fix typo in command name used by wx build system.
3297
3298         * wx/build/build_utils.py:
3299
3300 2009-10-30  Adam Barth  <abarth@webkit.org>
3301
3302         Reviewed by Darin Adler.
3303
3304         Patch v1 is a dumb default name for patches
3305         https://bugs.webkit.org/show_bug.cgi?id=30952
3306
3307         Let's use "Patch" instead.
3308
3309         * Scripts/bugzilla-tool:
3310
3311 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3312
3313         Unreviewed trivial buildfix.
3314
3315         [Qt] Buildfix for r50333.
3316
3317         * DumpRenderTree/qt/DumpRenderTree.pro:
3318
3319 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
3320
3321         Reviewed by Holger Freyther.
3322
3323         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
3324         https://bugs.webkit.org/show_bug.cgi?id=30953
3325
3326         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
3327         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
3328         makes qt DRT to share this implementation (as gtk and mac ports do).
3329
3330         * DumpRenderTree/qt/DumpRenderTree.pro:
3331         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
3332         * DumpRenderTree/qt/WorkQueue.h: Removed.
3333
3334 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3335
3336         Unreviewed potential buildbot fix.
3337
3338         Second try: Reset page history before running each test.
3339
3340         Apparently the QWebHistory::clear() keeps the current page
3341         in history which is not what we want, so we not additionally
3342         sets the history capacity to 0 (forces removing everything)
3343         and then sets it back to its original value.
3344
3345         * DumpRenderTree/qt/DumpRenderTree.cpp:
3346         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3347
3348 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3349
3350         Unreviewed potential buildbot fix.
3351
3352         Reset page history before running each test.
3353
3354         * DumpRenderTree/qt/DumpRenderTree.cpp:
3355         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3356
3357 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
3358
3359         Reviewed by Eric Seidel.
3360
3361         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
3362
3363         Bug 28420 -  Implement HTML5 <ruby> rendering
3364         (https://bugs.webkit.org/show_bug.cgi?id=28420)
3365
3366         No new tests (no functional change).
3367
3368         * Scripts/build-webkit:
3369
3370 2009-10-29  Dan Bernstein  <mitz@apple.com>
3371
3372         Reviewed by Mark Rowe.
3373
3374         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
3375         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
3376         define it.
3377
3378         * Scripts/VCSUtils.pm:
3379         * Scripts/svn-apply:
3380         * Scripts/svn-unapply:
3381
3382 2009-10-29  Xan Lopez  <xlopez@igalia.com>
3383
3384         Reviewed by Gustavo Noronha.
3385
3386         Use the GTK+ main loop instead of rolling our own mini-version of
3387         it.
3388
3389         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3390         (dump):
3391         (runTest):
3392         (webViewLoadFinished):
3393
3394 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3395
3396         Reviewed by Oliver Hunt.
3397
3398         Implement the Qt version of DRT dumpBackForwardList().
3399
3400         * DumpRenderTree/qt/DumpRenderTree.cpp:
3401         (WebCore::dumpHistoryItem):
3402         (WebCore::DumpRenderTree::dumpBackForwardList):
3403
3404 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3405
3406         Reviewed by Adam Roben.
3407
3408         Implement DRT functionality for Qt introduced in
3409         r28690 and r28705.
3410
3411         - Implemented pathToLocalResource which exposes the functionality of
3412         converting a given unix path to the correct location on Windows.
3413         - Implemented a way to remove machine-dependent information from paths
3414         in layout test results.
3415
3416         * DumpRenderTree/qt/DumpRenderTree.cpp:
3417         (WebCore::urlSuitableForTestResult):
3418         (WebCore::WebPage::javaScriptConsoleMessage):
3419         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3420         (LayoutTestController::pathToLocalResource):
3421         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3422
3423 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
3424
3425         Adding myself to the committers list.
3426
3427         * Scripts/modules/committers.py:
3428
3429 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
3430
3431         Adding myself to the committers list.
3432
3433         * Scripts/modules/committers.py:
3434
3435 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3436
3437         Reviewed by Jan Alonzo.
3438
3439         [GTK] API to start inspector for a WebView
3440         https://bugs.webkit.org/show_bug.cgi?id=22551
3441
3442         Use the new inspector API to implement the LayoutTestController
3443         interfaces used to test the inspector.
3444
3445         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3446         (webInspectorInspectWebView):
3447         (createWebView):
3448         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3449         (LayoutTestController::showWebInspector):
3450         (LayoutTestController::closeWebInspector):
3451         (LayoutTestController::evaluateInWebInspector):
3452
3453 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
3454
3455         Reviewed by Eric Seidel.
3456
3457         [Qt] WebFrame::counterValueForElementById must not be exposed
3458         https://bugs.webkit.org/show_bug.cgi?id=30882
3459
3460         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3461         (LayoutTestController::counterValueForElementById):
3462
3463 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3464
3465         Rubberstamped by Oliver Hunt.
3466
3467         Fix the warning:
3468
3469         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
3470         declared with attribute warn_unused_result".
3471
3472         by actually checking the result. In the case it is null, an
3473         error has occoured, so treat it as the other fatal errors.
3474
3475         * DumpRenderTree/qt/DumpRenderTree.cpp:
3476         (WebCore::DumpRenderTree::initializeFonts):
3477
3478 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
3479
3480         Reviewed by Darin Adler.
3481
3482         Provide a way to get counter values with layoutTestContoller
3483         https://bugs.webkit.org/show_bug.cgi?id=30555
3484
3485         Define layoutTestContoller.counterValueForElementById.
3486
3487         * DumpRenderTree/LayoutTestController.cpp:
3488         (counterValueForElementByIdCallback):
3489         (LayoutTestController::staticFunctions):
3490         * DumpRenderTree/LayoutTestController.h:
3491         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3492         (LayoutTestController::counterValueForElementById):
3493
3494 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3495
3496         Rubberstamped by Oliver Hunt.
3497
3498         Change two methods to be internal for DRT use only.
3499
3500         Part of [Qt] Review all new API in Qt 4.6
3501         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
3502
3503         * DumpRenderTree/qt/DumpRenderTree.cpp:
3504         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3505         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3506         (LayoutTestController::whiteListAccessFromOrigin):
3507
3508 2009-10-27  Eric Seidel  <eric@webkit.org>
3509
3510         Reviewed by Adam Barth.
3511
3512         REGRESSION: svn-apply exits(1) when applying a patch with a file add
3513         https://bugs.webkit.org/show_bug.cgi?id=30826
3514
3515         * Scripts/svn-apply:
3516          - Add () around all system() calls.
3517          - Use the correct system() == 0 or die instead of system() or die
3518          - Add descriptive messages to all die statements.
3519
3520 2009-10-27  Steve Block  <steveblock@google.com>
3521
3522         Reviewed by NOBODY.
3523
3524         Adds steveblock@google.com to list of committers.
3525
3526         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
3527
3528 2009-10-27  Eric Seidel  <eric@webkit.org>
3529
3530         Reviewed by Adam Barth.
3531
3532         svn-apply can exit(0) even on patch failure
3533         https://bugs.webkit.org/show_bug.cgi?id=29622
3534
3535         * Scripts/svn-apply:
3536          - Add a bunch of "or die" statements, hopefully catching all
3537            possible cases where failure could still exit(0).
3538
3539 2009-10-27  Eric Seidel  <eric@webkit.org>
3540
3541         Reviewed by Adam Barth.
3542
3543         svn-* scripts should share code through VCSUtils.pm
3544         https://bugs.webkit.org/show_bug.cgi?id=30791
3545
3546         Just moving code into a shared location.
3547
3548         * Scripts/VCSUtils.pm:
3549         * Scripts/prepare-ChangeLog:
3550         * Scripts/resolve-ChangeLogs:
3551         * Scripts/svn-apply:
3552         * Scripts/svn-create-patch:
3553         * Scripts/svn-unapply:
3554         * Scripts/update-webkit:
3555
3556 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
3557
3558         Suppress a huge number of MSVC warnings when building wxWebKit.
3559
3560         * wx/build/settings.py:
3561
3562 2009-10-26  Eric Seidel  <eric@webkit.org>
3563
3564         No review, just adding Mike Belshe to the committers list.
3565
3566         * Scripts/modules/committers.py:
3567
3568 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3569
3570         Reviewed by Darin Adler.
3571
3572         Make .rc files compile on Windows without depending on MFC headers
3573         https://bugs.webkit.org/show_bug.cgi?id=30750
3574
3575         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
3576         windows.h instead of afxres.h because it exists even when MFC is not 
3577         installed, and is all that's needed here.
3578
3579         * FindSafari/FindSafari.rc: Ditto
3580
3581 2009-10-24  Eric Seidel  <eric@webkit.org>
3582
3583         Reviewed by Adam Barth.
3584
3585         bugzilla-tool post-diff should know how to mark commit-queue=?
3586         https://bugs.webkit.org/show_bug.cgi?id=29202
3587
3588         * Scripts/bugzilla-tool:
3589          - Add --commit-queue option to post-diff, post-commits and create-bug.
3590         * Scripts/modules/bugzilla.py:
3591          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
3592          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
3593
3594 2009-10-23  Eric Seidel  <eric@webkit.org>
3595
3596         Reviewed by Adam Barth.
3597
3598         bugzilla-tool commit-queue does not notice modifications to committers.py
3599         https://bugs.webkit.org/show_bug.cgi?id=30084
3600
3601         * Scripts/bugzilla-tool:
3602          - Make commit-queue re-exec itself instead of using while(1).
3603          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
3604          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
3605
3606 2009-10-22  Eric Seidel  <eric@webkit.org>
3607
3608         Reviewed by Adam Barth.
3609
3610         commit-queue will get stuck on patches if land-patches terminates unexpectedly
3611         https://bugs.webkit.org/show_bug.cgi?id=30634
3612
3613         * Scripts/bugzilla-tool:
3614          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
3615          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
3616
3617 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
3618
3619         Reviewed by Eric Seidel.
3620
3621         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
3622
3623         https://bugs.webkit.org/show_bug.cgi?id=30763
3624
3625         * pywebsocket/mod_pywebsocket/__init__.py:
3626         * pywebsocket/mod_pywebsocket/dispatch.py:
3627         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
3628         * pywebsocket/mod_pywebsocket/standalone.py:
3629         * pywebsocket/setup.py:
3630         * pywebsocket/test/test_dispatch.py:
3631
3632 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
3633
3634         Reviewed by David Levin.
3635
3636         REGRESSION: 2 failures in run-webkit-unittests
3637         https://bugs.webkit.org/show_bug.cgi?id=30645
3638
3639         * Scripts/modules/cpp_style_unittest.py:
3640         Fixed a few test scenarios which apparently lost some spaces from 
3641         text literals.
3642
3643 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
3644
3645         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
3646
3647         * Scripts/webkitdirs.pm:
3648
3649 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
3650
3651         Reviewed by Darin Adler.
3652
3653         Unification of using null device in perl scripts.
3654         https://bugs.webkit.org/show_bug.cgi?id=30572
3655
3656         * Scripts/VCSUtils.pm:
3657         * Scripts/bisect-builds:
3658         * Scripts/resolve-ChangeLogs:
3659         * Scripts/run-iexploder-tests:
3660         * Scripts/run-jsc:
3661         * Scripts/run-mangleme-tests:
3662         * Scripts/run-webkit-tests:
3663         * Scripts/webkitdirs.pm:
3664         Using File::Spec->devnull() instead of hard coded /dev/null.
3665
3666 2009-10-26  Eric Seidel  <eric@webkit.org>
3667
3668         Reviewed by Holger Freyther.
3669
3670         Reviewers are missing from committers.py
3671         https://bugs.webkit.org/show_bug.cgi?id=30733
3672
3673         * Scripts/modules/committers.py:
3674
3675 2009-10-23  Eric Seidel  <eric@webkit.org>
3676
3677         No review, only adding Alice to the list of reviewers.
3678
3679         * Scripts/modules/committers.py:
3680
3681 2009-10-23  Eric Seidel  <eric@webkit.org>
3682
3683         Reviewed by Eric Carlson.
3684
3685         fast/media/mq-transform-02.html failed on Leopard Commit Bot
3686         https://bugs.webkit.org/show_bug.cgi?id=30700
3687
3688         * DumpRenderTree/mac/DumpRenderTree.mm:
3689         (resetDefaultsToConsistentValues): Update QuickTime version check.
3690
3691 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
3692
3693         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
3694         character measurement APIs that are private on Tiger.
3695
3696         * wx/build/settings.py:
3697
3698 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3699
3700         Reviewed by NOBODY (build fix).
3701         Build fix following bug #30696.
3702
3703         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3704         (LayoutTestController::evaluateScriptInIsolatedWorld):
3705
3706 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
3707
3708         Reviewed by Sam Weinig & Geoff Garen.
3709
3710         https://bugs.webkit.org/show_bug.cgi?id=30696
3711         Enable isolated-worlds tests on mac.
3712
3713         Add private interface for DRT to invoke execution in a given world.
3714
3715         * DumpRenderTree/LayoutTestController.cpp:
3716         (evaluateScriptInIsolatedWorldCallback):
3717         (LayoutTestController::staticFunctions):
3718         * DumpRenderTree/LayoutTestController.h:
3719         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3720         (LayoutTestController::evaluateScriptInIsolatedWorld):
3721         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3722         (LayoutTestController::evaluateScriptInIsolatedWorld):
3723
3724 2009-10-21  Eric Seidel  <eric@webkit.org>
3725
3726         Reviewed by Adam Barth.
3727
3728         bugzilla-tool's "patch failed to download an apply" error should give more information
3729         https://bugs.webkit.org/show_bug.cgi?id=30632
3730
3731         * Scripts/modules/scm.py:
3732          - Use the common run_command method instead of custom POpen code.
3733          - Make run_command know how to take pipes as input.
3734         * Scripts/modules/scm_unittest.py:
3735          - Add new tests to cover change.
3736          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
3737
3738 2009-10-21  Kent Tamura  <tkent@chromium.org>
3739
3740         Unreviewed.  Adding myself to the committers list.
3741
3742         * Scripts/modules/committers.py:
3743
3744 2009-10-21  Robin Dunn  <robin@alldunn.com>
3745
3746         Reviewed by Kevin Ollivier.
3747
3748         Update the Windows installer builder to work with Vista / Win 7 and with git.
3749         
3750         https://bugs.webkit.org/show_bug.cgi?id=30649
3751
3752         * wx/build/build_utils.py:
3753         * wx/packaging/build-mac-installer.py:
3754         * wx/packaging/build-win-installer.py:
3755         * wx/packaging/wxWebKitInstaller.iss.in:
3756
3757 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3758
3759         Reviewed by Gustavo Noronha.
3760
3761         [GTK] Added conditional code to avoid using
3762         gdk_window_get_root_coords if we do not have a gtk+ release newer
3763         than 2.17.3.
3764         https://bugs.webkit.org/show_bug.cgi?id=30636
3765
3766         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3767
3768 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
3769
3770         Reviewed by Eric Seidel.
3771
3772         [Qt] Added dummy implementation for keepWebHistory()
3773         https://bugs.webkit.org/show_bug.cgi?id=30592
3774
3775         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3776         (LayoutTestController::keepWebHistory):
3777         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3778
3779 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3780
3781         Reviewed by Xan Lopez.
3782
3783         [GTK] Fixed the double click condition, it is not double click if
3784         we move in just in one direction.
3785         https://bugs.webkit.org/show_bug.cgi?id=30636
3786
3787         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3788
3789 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3790
3791         Reviewed by Xan Lopez.
3792
3793         [GTK] Initialize the events completly before emitting them.
3794         https://bugs.webkit.org/show_bug.cgi?id=30633
3795
3796         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3797
3798 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3799
3800         wx build fix. Fix for when linking using --as-needed with gcc.
3801
3802         * wx/browser/wscript:
3803
3804 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3805
3806         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
3807         to support all the features used by CURL backend.
3808         
3809         * wx/build/settings.py:
3810         * wx/install-unix-extras:
3811
3812 2009-10-20  Anton Muhin  <antonm@chromium.org>
3813
3814         Reviewed by Adam Barth.
3815
3816         Add {ager,antonm,yurys}@chromium.org into committers.py
3817         https://bugs.webkit.org/show_bug.cgi?id=30560
3818
3819         * Scripts/modules/committers.py:
3820
3821 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3822
3823         Reviewed by Tor Arne Vestbø.
3824
3825         Make the Netscape Test plugin available to the Qt launcher.
3826
3827         * Scripts/run-launcher:
3828
3829 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
3830
3831         Reviewed by David Levin.
3832
3833         Removed WebSocket runtime settings.
3834         https://bugs.webkit.org/show_bug.cgi?id=29896
3835
3836         WebSocket runtime configuration is supported by chromium/v8 only.
3837
3838         * DumpRenderTree/mac/DumpRenderTree.mm:
3839         (resetDefaultsToConsistentValues):
3840         * DumpRenderTree/win/DumpRenderTree.cpp:
3841         (resetDefaultsToConsistentValues):
3842
3843 2009-10-19  Nate Chapin  <japhet@chromium.org>
3844
3845         Reviewed by Adam Barth.
3846
3847         Add testFail() to test plugin so we can test our handling of a
3848         plugin invoke call returning false.
3849
3850         https://bugs.webkit.org/show_bug.cgi?id=30239
3851
3852         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
3853         (pluginInvoke):
3854         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
3855
3856 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
3857
3858         Reviewed by Gustavo Noronha.
3859
3860         Enable DOM pasting when running layout tests.
3861
3862         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3863         (resetDefaultsToConsistentValues):
3864
3865 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3866
3867         Reviewed by Simon Hausmann.
3868
3869         Use the setPreferredContentsSize method instead
3870         of setFixedContentsSize, as the method has been renamed.
3871
3872         * DumpRenderTree/qt/DumpRenderTree.cpp:
3873         (WebCore::DumpRenderTree::open):
3874         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3875         (LayoutTestController::setFixedContentsSize):
3876
3877 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3878
3879         Reviewed by Dan Bernstein.
3880
3881         https://bugs.webkit.org/show_bug.cgi?id=30456
3882         Fixes for new Debug_All Windows build configuration.
3883
3884         * DumpRenderTree/win/DumpRenderTree.cpp:
3885         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
3886         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
3887
3888 2009-10-16  Eric Seidel  <eric@webkit.org>
3889
3890         Reviewed by Adam Barth.
3891
3892         commit-queue status bot should list which buildbot is blocking the queue
3893         https://bugs.webkit.org/show_bug.cgi?id=30452
3894
3895         Add new methods and testing.
3896
3897         * Scripts/bugzilla-tool:
3898         * Scripts/modules/buildbot.py:
3899         * Scripts/modules/buildbot_unittest.py:
3900
3901 2009-10-16  Eric Seidel  <eric@webkit.org>
3902
3903         Reviewed by Adam Barth.
3904
3905         run-webkit-tests fails when CWD is not inside a WebKit checkout
3906         https://bugs.webkit.org/show_bug.cgi?id=30451
3907
3908         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
3909         * Scripts/modules/scm_unittest.py:
3910           - Remove use of original_path (we don't need to restore the CWD).
3911           - Don't use '.' to find the webkit checkout, use __file__ instead.
3912
3913 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3914
3915         Reviewed by Adam Roben.
3916
3917         Add a Debug_All configuration to build entire stack as debug.
3918         Change Debug_Internal to:
3919         - stop using _debug suffix for all WebKit/Safari binaries
3920         - not use _debug as a DLL naming suffix
3921         - use non-debug C runtime lib.
3922
3923         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
3924         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
3925         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
3926         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3927         Add missing debug.vsprops inherited property sheet.
3928         Add Debug_All configuration.
3929         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
3930         * WinLauncher/WinLauncher.vcproj:
3931         Removed extraneous definitions inherited from vsprops.
3932         Add Debug_All configuration.
3933
3934 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
3935
3936         Reviewed by David Levin.
3937
3938         check-webkit-style is wrong about indent checking in namespaces
3939         in header files and a few other things
3940         https://bugs.webkit.org/show_bug.cgi?id=30362
3941
3942         The few other things include:
3943         + check-webkit-style does not require spaces around the equal sign
3944           inside 'if' statements and around binary operators that take 
3945           numeric literals.
3946         + check-webkit-style reports false errors for the / operator
3947           when part of a filename in the #include directive.
3948
3949         * Scripts/modules/cpp_style.py:
3950         Improved indentation checking and space checking around
3951         binary operators. While the checks are still not perfect,
3952         they are clearly better than before.
3953         * Scripts/modules/cpp_style_unittest.py:
3954         Added test cases for the newly supported checks and modified old
3955         test cases to match the new guidelines
3956
3957 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
3958
3959         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
3960
3961         * wx/build/settings.py:
3962
3963 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
3964
3965         Reviewed by David Levin.
3966
3967         Add mod_pywebsocket to test Web Sockets.
3968         http://code.google.com/p/pywebsocket/
3969         https://bugs.webkit.org/show_bug.cgi?id=27490
3970
3971         * pywebsocket/COPYING: Added.
3972         * pywebsocket/MANIFEST.in: Added.
3973         * pywebsocket/README: Added.
3974         * pywebsocket/example/echo_client.py: Added.
3975         * pywebsocket/example/echo_wsh.py: Added.
3976         * pywebsocket/mod_pywebsocket/__init__.py: Added.
3977         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
3978         * pywebsocket/mod_pywebsocket/handshake.py: Added.
3979         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
3980         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
3981         * pywebsocket/mod_pywebsocket/standalone.py: Added.
3982         * pywebsocket/mod_pywebsocket/util.py: Added.
3983         * pywebsocket/setup.py: Added.
3984         * pywebsocket/test/config.py: Added.
3985         * pywebsocket/test/mock.py: Added.
3986         * pywebsocket/test/run_all.py: Added.
3987         * pywebsocket/test/test_dispatch.py: Added.
3988         * pywebsocket/test/test_handshake.py: Added.
3989         * pywebsocket/test/test_mock.py: Added.
3990         * pywebsocket/test/test_msgutil.py: Added.
3991         * pywebsocket/test/test_util.py: Added.
3992         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
3993         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
3994         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
3995         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
3996         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
3997         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
3998         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
3999         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
4000
4001 2009-10-15  James Robinson  <jamesr@google.com>
4002
4003         Reviewed by David Levin.
4004
4005         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
4006
4007         https://bugs.webkit.org/show_bug.cgi?id=30426
4008
4009         * Scripts/modules/cpp_style.py:
4010         * Scripts/modules/cpp_style_unittest.py:
4011
4012 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
4013
4014         Reviewed by Adam Roben.
4015
4016         Fixes <http://webkit.org/b/30411>.
4017         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
4018         
4019         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
4020         building Chromium.
4021
4022         * Scripts/pdevenv:
4023
4024 2009-10-15  Robin Dunn  <robin@alldunn.com>
4025
4026         Reviewed by Kevin Ollivier.
4027
4028         Add Mac package building scripts for wx.
4029         
4030         https://bugs.webkit.org/show_bug.cgi?id=30405
4031
4032         * wx/build/build_utils.py:
4033         * wx/build/settings.py:
4034         * wx/packaging/build-mac-installer.py: Added.
4035
4036 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
4037
4038         Reviewed by Gustavo Noronha.
4039
4040         Enable Web Sockets support when running layout tests.
4041
4042         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4043         (resetDefaultsToConsistentValues):
4044
4045 2009-10-15  Xan Lopez  <xlopez@igalia.com>
4046
4047         Reviewed by Gustavo Noronha.
4048
4049         Need to initialize event.button.button, since in most cases a
4050         button number is not passed as an argument.
4051
4052         * DumpRenderTree/gtk/EventSender.cpp:
4053         (mouseDownCallback):
4054         (mouseUpCallback):
4055
4056 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
4057
4058         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
4059         the OS if none was explicitly set.
4060
4061         * wx/build/settings.py:
4062
4063 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
4064
4065         Reviewed by Timothy Hatcher.
4066
4067         Web Inspector: enable developers extras within inspector layout tests.
4068
4069         https://bugs.webkit.org/show_bug.cgi?id=30014
4070
4071         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4072         (LayoutTestController::showWebInspector):
4073         (LayoutTestController::closeWebInspector):
4074         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4075         (LayoutTestController::showWebInspector):
4076         (LayoutTestController::closeWebInspector):
4077
4078 2009-10-14  José Millán Soto  <jmillan@igalia.com>
4079
4080         Reviewed by Jan Alonzo.
4081
4082         GtkLauncher is using a deprecated signal
4083         https://bugs.webkit.org/show_bug.cgi?id=30364
4084
4085         Modified GtkLauncher to use notify::title signal instead of
4086         deprecated title-changed signal
4087
4088         * GtkLauncher/main.c:
4089         (notify_title_cb):
4090         (create_browser):
4091
4092 2009-10-14  Brady Eidson  <beidson@apple.com>
4093
4094         Reviewed by Sam Weinig.
4095
4096         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
4097         1 - Disables WebHistory
4098         2 - Doesn't make sense in that context anyway.
4099
4100         * DumpRenderTree/win/DumpRenderTree.cpp:
4101         (createWebViewAndOffscreenWindow):
4102
4103 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
4104
4105         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
4106         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
4107
4108         * wx/build/settings.py:
4109         * wx/install-unix-extras:
4110
4111 2009-10-14  Brady Eidson  <beidson@apple.com>
4112
4113         Reviewed by Sam Weinig.
4114
4115         WebKit Win API should provide a delegate interface for global history.
4116         https://bugs.webkit.org/show_bug.cgi?id=29905
4117
4118         * DumpRenderTree/LayoutTestController.cpp:
4119         (LayoutTestController::LayoutTestController):
4120         * DumpRenderTree/LayoutTestController.h:
4121         (LayoutTestController::dumpHistoryDelegateCallbacks):
4122         (LayoutTestController::setDumpHistoryDelegateCallbacks):
4123                 
4124         * DumpRenderTree/win/DumpRenderTree.cpp:
4125         (shouldLogHistoryDelegates):
4126         (runTest):
4127         (createWebViewAndOffscreenWindow):
4128         (main):
4129         * DumpRenderTree/win/DumpRenderTree.vcproj:
4130         
4131         Add the IWebHistoryDelegate to DRT Windows:
4132         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
4133         (wstringFromBSTR):
4134         (HistoryDelegate::HistoryDelegate):
4135         (HistoryDelegate::~HistoryDelegate):
4136         (HistoryDelegate::QueryInterface):
4137         (HistoryDelegate::AddRef):
4138         (HistoryDelegate::Release):
4139         (HistoryDelegate::didNavigateWithNavigationData):
4140         (HistoryDelegate::didPerformClientRedirectFromURL):
4141         (HistoryDelegate::didPerformServerRedirectFromURL):
4142         (HistoryDelegate::updateHistoryTitle):
4143         (HistoryDelegate::populateVisitedLinksForWebView):
4144         * DumpRenderTree/win/HistoryDelegate.h: Added.
4145
4146         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4147         (LayoutTestController::removeAllVisitedLinks):
4148
4149 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
4150
4151         Reviewed by Simon Hausmann.
4152
4153         [Qt] Implement support for setPOSIXLocale on Qt.
4154         https://bugs.webkit.org/show_bug.cgi?id=30268 
4155  
4156         * DumpRenderTree/qt/DumpRenderTree.cpp:
4157         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4158         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4159         (LayoutTestController::setPOSIXLocale):
4160         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4161
4162 2009-10-13  Stephanie Lewis  <slewis@apple.com>
4163
4164         Unreviewed, adding myself to reviewers list.
4165
4166         * Scripts/modules/committers.py:
4167
4168 2009-10-13  Stephanie Lewis  <slewis@apple.com>
4169
4170         Reviewed by Mark Rowe.
4171
4172         Fix null assignment so root tests work again.
4173
4174         * Scripts/webkitdirs.pm:
4175
4176 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
4177
4178         Reviewed by Simon Hausmann.
4179
4180         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
4181         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
4182         This is done in preparation of implementing missing features in DRT.
4183         No functionality changes made yet.
4184
4185         * DumpRenderTree/qt/DumpRenderTree.cpp:
4186         * DumpRenderTree/qt/DumpRenderTree.pro:
4187         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
4188         (EventSender::EventSender):
4189         (EventSender::mouseDown):
4190         (EventSender::mouseUp):
4191         (EventSender::mouseMoveTo):
4192         (EventSender::leapForward):
4193         (EventSender::keyDown):
4194         (EventSender::contextClick):
4195         (EventSender::scheduleAsynchronousClick):
4196         (EventSender::frameUnderMouse):
4197         * DumpRenderTree/qt/EventSenderQt.h: Added.
4198         (EventSender::clearKillRing):
4199         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
4200         (LayoutTestController::LayoutTestController):
4201         (LayoutTestController::reset):
4202         (LayoutTestController::processWork):
4203         (LayoutTestController::maybeDump):
4204         (LayoutTestController::waitUntilDone):
4205         (LayoutTestController::notifyDone):
4206         (LayoutTestController::windowCount):
4207         (LayoutTestController::clearBackForwardList):
4208         (LayoutTestController::dumpEditingCallbacks):
4209         (LayoutTestController::dumpResourceLoadCallbacks):
4210         (LayoutTestController::queueBackNavigation):
4211         (LayoutTestController::queueForwardNavigation):
4212         (LayoutTestController::queueLoad):
4213         (LayoutTestController::queueReload):
4214         (LayoutTestController::queueScript):
4215         (LayoutTestController::provisionalLoad):
4216         (LayoutTestController::timerEvent):
4217         (LayoutTestController::encodeHostName):
4218         (LayoutTestController::decodeHostName):
4219         (LayoutTestController::setJavaScriptProfilingEnabled):
4220         (LayoutTestController::setFixedContentsSize):
4221         (LayoutTestController::setPrivateBrowsingEnabled):
4222         (LayoutTestController::setPopupBlockingEnabled):
4223         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
4224         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
4225         (LayoutTestController::numberOfActiveAnimations):
4226         (LayoutTestController::disableImageLoading):
4227         (LayoutTestController::dispatchPendingLoadRequests):
4228         (LayoutTestController::setDatabaseQuota):
4229         (LayoutTestController::clearAllDatabases):
4230         (LayoutTestController::whiteListAccessFromOrigin):
4231         (LayoutTestController::waitForPolicyDelegate):
4232         (LayoutTestController::overridePreference):
4233         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
4234         (LayoutTestController::isLoading):
4235         (LayoutTestController::setLoading):
4236         (LayoutTestController::shouldDumpAsText):
4237         (LayoutTestController::shouldDumpBackForwardList):
4238         (LayoutTestController::shouldDumpChildrenAsText):
4239         (LayoutTestController::shouldDumpDatabaseCallbacks):
4240         (LayoutTestController::shouldDumpStatusCallbacks):
4241         (LayoutTestController::shouldWaitUntilDone):
4242         (LayoutTestController::canOpenWindows):
4243         (LayoutTestController::shouldDumpTitleChanges):
4244         (LayoutTestController::waitForPolicy):
4245         (LayoutTestController::dumpAsText):
4246         (LayoutTestController::dumpChildFramesAsText):
4247         (LayoutTestController::dumpDatabaseCallbacks):
4248         (LayoutTestController::dumpStatusCallbacks):
4249         (LayoutTestController::setCanOpenWindows):
4250         (LayoutTestController::dumpBackForwardList):
4251         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
4252         (LayoutTestController::display):
4253         (LayoutTestController::dumpTitleChanges):
4254         (LayoutTestController::dumpSelectionRect):
4255         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
4256         (TextInputController::TextInputController):
4257         (TextInputController::doCommand):
4258         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
4259         * DumpRenderTree/qt/WorkQueue.cpp:
4260         * DumpRenderTree/qt/WorkQueue.h:
4261         * DumpRenderTree/qt/WorkQueueItem.h:
4262         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
4263         (findFrameNamed):
4264         (LoadItem::invoke):
4265         (ReloadItem::invoke):
4266         (ScriptItem::invoke):
4267         (BackForwardItem::invoke):
4268         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
4269         * DumpRenderTree/qt/jsobjects.h:
4270
4271 2009-10-13  Dmitry Titov  <dimich@chromium.org>
4272
4273         Not reviewed, adding myself to the list of reviewers.
4274
4275         * Scripts/modules/committers.py:
4276
4277 2009-10-13  Anders Carlsson  <andersca@apple.com>
4278
4279         Reviewed by Sam Weinig.
4280
4281         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
4282
4283         Make the private browsing mode testable by the test plug-in.
4284         
4285         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
4286         (pluginGetProperty):
4287         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
4288         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
4289         (NPP_New):
4290         (NPP_SetValue):
4291
4292 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
4293
4294         No review, just adding self to the list of reviewers.
4295
4296         * Scripts/modules/committers.py:
4297
4298 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
4299
4300         Reviewed by Adam Roben.
4301
4302         Web Inspector: Use proper web view in inspector layout
4303         tests for windows.
4304
4305         https://bugs.webkit.org/show_bug.cgi?id=30298
4306
4307         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4308         (LayoutTestController::showWebInspector):
4309         (LayoutTestController::closeWebInspector):
4310         (LayoutTestController::evaluateInWebInspector):
4311
4312 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
4313
4314         Reviewed by Sam Weinig.
4315
4316         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
4317         https://bugs.webkit.org/show_bug.cgi?id=29841
4318
4319         * DumpRenderTree/mac/DumpRenderTree.mm:
4320         (resetDefaultsToConsistentValues):
4321         * DumpRenderTree/win/DumpRenderTree.cpp:
4322         (resetDefaultsToConsistentValues):
4323
4324 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
4325
4326         Reviewed by Dimitri Glazkov.
4327
4328         Chromium Port - Windows
4329         https://bugs.webkit.org/show_bug.cgi?id=29969
4330
4331         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
4332         * Scripts/webkitdirs.pm:
4333
4334 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
4335
4336         Reviewed by Darin Adler.
4337
4338         jsc scripts cleanup and Qt/GTK fix
4339         https://bugs.webkit.org/show_bug.cgi?id=30288
4340
4341         Duplicated jscPath() moved to webkitdirs.pm.
4342         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
4343         Configuration added (release/debug) to path for Qt-port on Windows.
4344
4345         * Scripts/run-javascriptcore-tests:
4346         * Scripts/run-jsc:
4347         * Scripts/run-sunspider:
4348         * Scripts/sunspider-compare-results:
4349         * Scripts/webkitdirs.pm:
4350
4351 2009-10-11  Adam Barth  <abarth@webkit.org>
4352
4353         Unreviewed.  Add Collin to committers.py.
4354
4355         * Scripts/modules/committers.py:
4356
4357 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
4358
4359         wx build fix, add bindings to source/include dirs now that there are sources there.
4360
4361         * wx/build/settings.py:
4362
4363 2009-10-09  Mark Rowe  <mrowe@apple.com>