Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the...
[WebKit-https.git] / WebKitTools / ChangeLog
1 2007-11-25  Sam Weinig  <sam@webkit.org>
2
3         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
4
5         Reviewed by Mark Rowe.
6
7         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
8         * DumpRenderTree/mac/Configurations/Base.xcconfig:
9         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
10         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
11         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
12
13 2007-11-25  Sam Weinig  <sam@webkit.org>
14
15         Convert DumpRenderTree to ues .xcconfig files.
16
17         Reviewed by Mark Rowe.
18
19         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
20         * DumpRenderTree/mac/Configurations: Added.
21         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
22         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
23         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
24
25 2007-11-25  Sam Weinig  <sam@webkit.org>
26
27         Add ForwardingHeaders to wtf for DumpRenderTree.
28
29         Reviewed by Mark Rowe.
30
31         * DumpRenderTree/DumpRenderTree.h:
32         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
33         * DumpRenderTree/ForwardingHeaders: Added.
34         * DumpRenderTree/ForwardingHeaders/wtf: Added.
35         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
36         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
37         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
38         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
39         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
40         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
41         * DumpRenderTree/LayoutTestController.cpp:
42         * DumpRenderTree/WorkQueue.cpp:
43         * DumpRenderTree/mac/DumpRenderTree.mm:
44         * DumpRenderTree/mac/FrameLoadDelegate.mm:
45         * DumpRenderTree/mac/JavaScriptThreading.cpp:
46         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
47         * DumpRenderTree/mac/ObjCController.m:
48         * DumpRenderTree/mac/UIDelegate.mm:
49         * DumpRenderTree/mac/WorkQueueItemMac.mm:
50
51 2007-11-25  Adam Roben  <aroben@apple.com>
52
53         Fix some test failures caused by r28019
54
55         Now that stdout is in binary mode, we need to always use printf
56         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
57         the output.
58
59         Reviewed by Sam.
60
61         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
62         printf.
63         (UIDelegate::runJavaScriptAlertPanelWithMessage):
64         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
65         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
66         (UIDelegate::webViewAddMessageToConsole):
67
68 2007-11-25  Adam Roben  <aroben@apple.com>
69
70         Set the font smoothing preference in DRT
71
72         This makes the pixel results on Windows closer to the Mac results.
73
74         Reviewed by Mitz.
75
76         * DumpRenderTree/win/DumpRenderTree.cpp:
77         (initializePreferences):
78
79 2007-11-25  Adam Roben  <aroben@apple.com>
80
81         Port ImageDiff to CG and C++
82
83         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
84         <rdar://5071708>
85
86         Reviewed by Sam.
87
88         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
89         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
90         (main):
91         (createImageFromStdin):
92         (compareImages):
93         (getDifferenceBitmap):
94         (computePercentageDifferent):
95         * DumpRenderTree/win/ImageDiff.vcproj: Added.
96
97 2007-11-25  Adam Roben  <aroben@apple.com>
98
99         Fix image diff link generation on Windows
100
101         Reviewed by Sam.
102
103         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
104         to toURL.
105
106 2007-11-25  Adam Roben  <aroben@apple.com>
107
108         Implement pixel dumping in Windows DRT
109
110         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
111         <rdar://5071708>
112
113         Reviewed by Sam.
114
115         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
116         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
117         Content-Length header.
118         (getMD5HashStringForBitmap):
119         (dumpWebViewAsPixelsAndCompareWithExpected):
120         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
121         * DumpRenderTree/win/DumpRenderTree.cpp:
122         (dump): Do a pixel dump if requested.
123         (main): Parse pixel test options.
124         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
125         the cg/ subdirectory to the include path.
126         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
127         available in a header or import library, so we have to go through this
128         LoadLibrary/GetProcAddress dance to use them.
129         (cryptDLL):
130         (init):
131         (update):
132         (final):
133         (MD5_Init):
134         (MD5_Update):
135         (MD5_Final):
136         * DumpRenderTree/win/MD5.h: Added.
137         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
138         moved up to the top level to share it with Mac eventually.
139         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
140         (getBitmapContextFromWebView): Forces the WebView to paint using a
141         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
142
143 2007-11-25  Adam Roben  <aroben@apple.com>
144
145         Clean up Windows DRT's option parsing a little bit
146
147         Reviewed by Sam.
148
149         * DumpRenderTree/win/DumpRenderTree.cpp:
150         (main): Put non-option arguments into a Vector.
151
152 2007-11-25  Adam Roben  <aroben@apple.com>
153
154         Make Windows DRT stop changing LF into CRLF
155
156         Reviewed by Sam.
157
158         * DumpRenderTree/win/DumpRenderTree.cpp:
159         (main): Put stdout in binary mode.
160         * Scripts/run-webkit-tests: Remove the CRLF hack.
161
162 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
163
164         Removed empty directory.
165
166         * Scripts/resources: Removed.
167
168 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
169
170         Fix bisect-builds to work with recent WebKit nightly builds.
171
172         Reviewed by Dan.
173
174         * Scripts/bisect-builds: Check for the 
175         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
176         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
177         to WebKit.app/Contents/Resources.
178
179 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
180
181         Reviewed by Maciej.
182
183         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
184         not closed (affects digg.com)
185
186         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
187         one after finishing with a test to avoid having its delayed onload handler firing when
188         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
189         but it helps somewhat.
190
191 2007-11-22  Mark Rowe  <mrowe@apple.com>
192
193         Reviewed by Alp Toker.
194
195         Fix build-webkit to propagate make's exit status if it fails.
196
197         * Scripts/webkitdirs.pm:
198
199 2007-11-22  Dan Bernstein  <mitz@apple.com>
200
201         Reviewed by Mark Rowe.
202
203         - fix crash when running pixel tests
204
205         * DumpRenderTree/mac/DumpRenderTree.mm:
206         (dumpRenderTree): Parse the command line options before setting up the
207         environment so that we know if we need to set up the pixel dump
208         machinery.
209
210 2007-11-21  Eric Seidel  <eric@webkit.org>
211
212         Speculative build fix for Tiger.
213
214         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
215
216 2007-11-21  Eric Seidel  <eric@webkit.org>
217
218         Reviewed by Tim Hatcher.
219
220         Break out more of DumpRenderTree.mm into individual files
221
222         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
223         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
224         (checkedMalloc):
225         (checkedRealloc):
226         (makeLargeMallocFailSilently):
227         * DumpRenderTree/mac/CheckedMalloc.h: Added.
228         * DumpRenderTree/mac/DumpRenderTree.mm:
229         (crashHandler):
230         (dump):
231         * DumpRenderTree/mac/DumpRenderTreeMac.h:
232         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
233         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
234         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
235         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
236         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
237         (javaScriptThreads):
238         (runJavaScriptThread):
239         (startJavaScriptThreads):
240         (stopJavaScriptThreads):
241         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
242         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
243         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
244         (restoreColorSpace):
245         (setDefaultColorProfileToRGB):
246         (initializeColorSpaceAndScreeBufferForPixelTests):
247         (md5HashStringForBitmap):
248         (dumpWebViewAsPixelsAndCompareWithExpected):
249
250 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
251
252         Move install-unix-extras to wx directory as it seems only to be used by that 
253         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
254         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
255         have install-unix-extras install into WebKitLibraries as per
256         convention.
257         
258         Reviewed by Mark Rowe.
259
260         * Scripts/install-unix-extras: Removed.
261         * wx/build-wxwebkit:
262         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
263
264 2007-11-21  Eric Seidel  <eric@webkit.org>
265
266         Reviewed by Adam.
267
268         More refactoring for greater code readability
269
270         * DumpRenderTree/mac/DumpRenderTree.mm:
271         (initializeGlobalsFromCommandLineOptions):
272         (initializeColorSpaceAndScreeBufferForPixelTests):
273         (addTestPluginsToPluginSearchPath):
274         (useLongRunningServerMode):
275         (runTestingServerLoop):
276         (prepareConsistentTestingEnvironment):
277         (dumpRenderTree):
278         (main):
279         (dumpFramesAsText):
280         (dumpBackForwardListForWebView):
281         (sizeWebViewForCurrentTest):
282         (methodNameStringForFailedTest):
283         (dumpBackForwardListForAllWindows):
284         (dumpWebViewAsPixelsAndCompareWithExpected):
285         (invalidateAnyPreviousWaitToDumpWatchdog):
286         (dump):
287         * DumpRenderTree/mac/DumpRenderTreeMac.h:
288         * DumpRenderTree/mac/UIDelegate.mm:
289         (-[UIDelegate webView:createWebViewWithRequest:]):
290
291 2007-11-21  Eric Seidel  <eric@webkit.org>
292
293         Reviewed by Tim Hatcher.
294
295         Abstract more of DRT into static methods
296
297         * DumpRenderTree/mac/DumpRenderTree.mm:
298         (setDefaultsToConsistentValuesForTesting):
299         (setupSignalHandlers):
300         (allocateGlobalControllers):
301         (releaseAndZero):
302         (releaseGlobalControllers):
303         (dumpRenderTree):
304         (shouldLogFrameLoadDelegates):
305         (createCFURLFromPathOrURL):
306         (resetWebViewToConsistentStateBeforeTesting):
307         (runTest):
308
309 2007-11-21  Eric Seidel  <eric@webkit.org>
310
311         Reviewed by Tim Hatcher.
312
313         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
314
315         * DumpRenderTree/DumpRenderTree.h:
316         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
317         * DumpRenderTree/mac/DumpRenderTree.mm:
318         (dumpRenderTree):
319         (dump):
320         (runTest):
321         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
322         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
323         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
324         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
325         (-[DumpRenderTreePasteboard declareType:owner:]):
326         (+[LocalPasteboard alloc]):
327         (-[LocalPasteboard init]):
328         (-[LocalPasteboard dealloc]):
329         (-[LocalPasteboard name]):
330         (-[LocalPasteboard releaseGlobally]):
331         (-[LocalPasteboard declareTypes:owner:]):
332         (-[LocalPasteboard addTypes:owner:]):
333         (-[LocalPasteboard changeCount]):
334         (-[LocalPasteboard types]):
335         (-[LocalPasteboard availableTypeFromArray:]):
336         (-[LocalPasteboard setData:forType:]):
337         (-[LocalPasteboard dataForType:]):
338         (-[LocalPasteboard setPropertyList:forType:]):
339         (-[LocalPasteboard setString:forType:]):
340         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
341         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
342         (+[DumpRenderTreeWindow allWindows]):
343         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
344         (-[DumpRenderTreeWindow dealloc]):
345         (-[DumpRenderTreeWindow isKeyWindow]):
346         (-[DumpRenderTreeWindow keyDown:]):
347
348 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
349
350         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
351         it indiscriminately copies any headers inside JavaScriptCore,
352         which includes Tiger ICU headers. 
353
354         * wx/build-wxwebkit:
355         Don't run WebCore/move-js-headers.sh any longer.
356
357 2007-11-20  Adam Treat  <treat@kde.org>
358
359         Reviewed by David Kilzer.
360
361         * Prepend git branch name to $baseProductDir
362
363         * Scripts/VCSUtils.pm:
364         * Scripts/webkitdirs.pm:
365
366 2007-11-20  Mark Rowe  <mrowe@apple.com>
367
368         Reviewed by Simon Hausmann.
369
370         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
371         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
372         Have it trigger a "make distclean" rather than "make clean" to ensure that the
373         built product and generated Makefile's are removed.
374
375 2007-11-19  Alp Toker  <alp@atoker.com>
376
377         Reviewed by Mark Rowe.
378
379         http://bugs.webkit.org/show_bug.cgi?id=16040
380         [GTK] GtkLauncher should be written in C
381
382         Port GtkLauncher to plain C.
383
384         Use a more conventional GTK+ coding style.
385
386         Use a toolbar instead of menus.
387
388         Various signature fixes and cleanups.
389
390         Add a license header. Assume all previous modifications were copyright
391         assigned to Apple Inc. by default.
392
393         * GtkLauncher/GtkLauncher.pro:
394         * GtkLauncher/main.c: Added.
395         (activate_url_entry_cb):
396         (update_title):
397         (link_hover_cb):
398         (title_change_cb):
399         (progress_change_cb):
400         (destroy_cb):
401         (go_back_cb):
402         (go_forward_cb):
403         (create_browser):
404         (create_statusbar):
405         (create_toolbar):
406         (create_window):
407         (main):
408         * GtkLauncher/main.cpp: Removed.
409
410 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
411
412         Build script fixes to ensure they do the right thing for the 
413         wx port, and update build-wxwebkit to reflect the way the
414         build scripts now work.
415
416         Reviewed by Adam.
417
418         * Scripts/build-testkjs:
419         * Scripts/build-webkit:
420         * Scripts/run-javascriptcore-tests:
421         * Scripts/webkitdirs.pm:
422         * wx/build-wxwebkit:
423
424 2007-11-18  Eric Seidel  <eric@webkit.org>
425
426         Reviewed by Anders.
427
428         Make run-javascriptcore-tests report failures on exit (to support git bisect)
429
430         * Scripts/run-javascriptcore-tests:
431
432 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
433
434         Reviewed by Adam Roben.
435
436         Make run-webkit-tests work with Windows debug build.
437
438         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
439         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
440         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
441         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
442         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
443
444 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
445
446         Add wxWebKit sample and build script, and integrate it with 
447         build-webkit. Also make build-webkit --clean work for all
448         ports.
449
450         Reviewed by Darin Adler.
451
452         * Scripts/build-webkit:
453         * Scripts/webkitdirs.pm:
454         * wx: Added.
455         * wx/browser: Added.
456         * wx/browser/browser.bkl: Added.
457         * wx/browser/browser.cpp: Added.
458         * wx/build-wxwebkit: Added.
459
460 2007-11-17  Adam Roben  <aroben@apple.com>
461
462         Make it easy to run Safari in the debugger on Windows
463
464         I've added a new script, debug-safari, which launches Safari in the
465         debugger. On OS X it just calls gdb-safari.
466
467         Reviewed by Mark Rowe.
468
469         * FindSafari/FindSafari.cpp:
470         (_tmain): Added a /debugger flag, which in combination with
471         /printSafariLauncher will print a script that launches Safari in the
472         debugger.
473         * Scripts/debug-safari: Added.
474         * Scripts/run-safari: Changed to call runSafari().
475         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
476         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
477         first argument along to FindSafari.
478         * Scripts/webkitdirs.pm:
479         (sub runSafari): Added.
480
481 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
482
483         Reviewed by Adam Roben.
484
485         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
486
487 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
488
489         Reviewed by David Kilzer.
490
491         The git config command was renamed to repo-config at some point. This
492         change tries git config and then git repo-config if the first fails.
493
494         * Scripts/prepare-ChangeLog:
495         (gitConfig):
496
497 2007-11-16  Dan Bernstein  <mitz@apple.com>
498
499         Reviewed by Darin Adler and Sam Weinig.
500
501         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
502
503         * DumpRenderTree/win/EventSender.cpp:
504         (keyDownCallback): For characters that cannot be entered on the active
505         keyboard layout, send a WM_CHAR message with the character along with
506         a WM_KEYDOWN message with a virtual key code of 255.
507
508 2007-11-16  Mark Rowe  <mrowe@apple.com>
509
510         Reviewed by Tim Hatcher.
511
512         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
513
514         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
515         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
516
517 2007-11-15  Adam Roben  <aroben@apple.com>
518
519         Make run-safari actually work on Windows
520
521         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
522         chdir call.
523
524 2007-11-14  Adam Roben  <aroben@apple.com>
525
526         Updates to Safari launching now that 3.0.4 is released
527
528         Reviewed by Sam.
529
530         * FindSafari/FindSafari.cpp:
531         (getWebViewCLSID): Use version-independent ProgID.
532         * Scripts/run-safari: Use run-webkit-nightly.cmd.
533
534 2007-11-14  Anders Carlsson  <andersca@apple.com>
535
536         Reviewed by Adam.
537
538         <rdar://problem/5309081>
539         In DRT, "plugin.logDestroy = true" not working on Windows.
540         
541         * DumpRenderTree/win/TestNetscapePlugin/main.c:
542         (NPP_Destroy):
543
544 2007-11-14  Eric Seidel  <eric@webkit.org>
545
546         Reviewed by Sam.
547
548         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
549
550 2007-11-14  Anders Carlsson  <andersca@apple.com>
551
552         Reviewed by Adam.
553
554         <rdar://problem/5141186>
555         window.layoutTestController.setWindowIsKey is not implemented in DRT.
556         
557         Implement setWindowIsKey.
558         
559         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
560         (LayoutTestController::setWindowIsKey):
561
562 2007-11-13  Sam Weinig  <sam@webkit.org>
563
564         Reviewed by Adam Roben.
565
566         Fix for <rdar://problem/5382579>
567         http/tests/security/cross-frame-access-put.html reports large 
568         negative numbers for screenLeft and screenTop (Mac reports "0")
569
570         * DumpRenderTree/win/UIDelegate.cpp:
571         (UIDelegate::UIDelegate): Initialize the RECT.
572         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
573         (UIDelegate::webViewFrame): ditto.
574         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
575
576 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
577
578         Reviewed by Adam.
579
580         - Make Drosera show source, source URLs, and function stack on Windows,
581         and some minor fixes.
582
583         * Drosera/DebuggerDocument.cpp: Force source to always update display.
584         (DebuggerDocument::updateFileSource):
585         * Drosera/debugger.js: Force source to always update display.
586         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
587         menu controls.
588         (DebuggerClient::resume):
589         (DebuggerClient::pause):
590         (DebuggerClient::stepInto):
591         (DebuggerClient::stepOver):
592         (DebuggerClient::stepOut):
593         (DebuggerClient::showConsole):
594         (DebuggerClient::closeCurrentFile):
595         * Drosera/win/DebuggerClient.h: Ditto.
596         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
597         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
598         removed two bugs.  1) caller could be in a bad state when asked to
599         assign into it. 2) BSTRs were not created correctly.
600         (DebuggerDocument::getPlatformCurrentFunctionStack):
601         * Drosera/win/Drosera.cpp: Hook up the menu controls.
602         (droseraWndProc):
603         (handleCommand):
604         (Drosera::resume):
605         (Drosera::pause):
606         (Drosera::stepInto):
607         (Drosera::stepOver):
608         (Drosera::stepOut):
609         (Drosera::showConsole):
610         (Drosera::closeCurrentFile):
611         * Drosera/win/Drosera.h: Hook up the menu controls.
612         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
613         functions, added a null check, and fixed another bug where caller could
614         be in a bad state when asked to assign into it.
615         (ServerConnection::didLoadMainResourceForDataSource):
616         (ServerConnection::getCallerFrame):
617         * Drosera/win/ServerConnection.h: Safety first.
618
619 2007-11-13  Dan Bernstein  <mitz@apple.com>
620
621         Reviewed by Darin Adler.
622
623         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
624           DumpRenderTree --pixel-tests renders each test twice
625
626         * DumpRenderTree/mac/DumpRenderTree.mm:
627         (dumpRenderTree): Removed the --paint option because the painting code
628         is always exercised as a result of
629         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
630         calling -displayIfNeeded.
631         (dump): Changed to always grab the image from the window since the view
632         is always displayed.
633         (runTest):
634         (displayWebView):
635         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
636         because it always paints.
637
638 2007-11-12  Antti Koivisto  <antti@apple.com>
639
640         Reviewed by Adele.
641         
642         Add support for http media tests
643
644         * Scripts/run-webkit-tests:
645
646 2007-11-12  Sam Weinig  <sam@webkit.org>
647
648         Reviewed by Adam Roben.
649
650         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
651
652         * DumpRenderTree/win/DumpRenderTree.cpp:
653         (runTest):
654         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
655         (LayoutTestController::setPrivateBrowsingEnabled):
656
657 2007-11-12  Adam Roben  <aroben@apple.com>
658
659         * Scripts/update-webkit-localizable-strings: Changed to only scan the
660         mac and win subdirectories.
661
662 2007-11-11  Adam Roben  <aroben@apple.com>
663
664         Fix <rdar://5133816> keepWebHistory is not implemented
665
666         Fixes fast/history/clicked-link-is-visited.html.
667
668         Reviewed by Darin.
669
670         * DumpRenderTree/win/DumpRenderTree.cpp:
671         (runTest): Clear the optionalSharedHistory.
672         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
673         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
674
675 2007-11-10  Sam Weinig  <sam@webkit.org>
676
677         Reviewed by Tim Hatcher.
678
679         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
680         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
681         is turned on)
682
683         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
684
685         Added test: http/tests/security/cross-frame-access-private-browsing.html
686
687         * DumpRenderTree/LayoutTestController.cpp:
688         (setPrivateBrowsingEnabledCallback):
689         (LayoutTestController::staticFunctions):
690         * DumpRenderTree/LayoutTestController.h:
691         * DumpRenderTree/mac/DumpRenderTree.mm:
692         (runTest): Default to private browsing disabled.
693         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
694         (LayoutTestController::setPrivateBrowsingEnabled):
695         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
696         (LayoutTestController::setPrivateBrowsingEnabled):
697
698 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
699
700         Reviewed by Adam.
701
702         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
703         WebCore's!
704
705         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
706         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
707         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
708         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
709         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
710         * Drosera/win/Drosera.cpp:
711         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
712
713 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
714
715         Reviewed by Sam.
716
717         - Use the new IWebFrame [local] function signature and get the shared
718         server correctly.
719
720         * Drosera/win/DebuggerClient.cpp:
721         (DebuggerClient::didFinishLoadForFrame):
722         * Drosera/win/ServerConnection.cpp:
723         (ServerConnection::attemptToCreateServerConnection):
724
725 2007-11-07  Dan Bernstein  <mitz@apple.com>
726
727         Reviewed by Darin Adler.
728
729         - add an option to run-webkit-tests to ignore pixel test failures where
730           all pixels differ by no more than a specified threshold
731
732         * DumpRenderTree/mac/ImageDiff.m:
733         (main):
734         (compareImages):
735         (computePercentageDifferent):
736         * Scripts/run-webkit-tests:
737
738 2007-11-07  Simon Hausmann  <hausmann@kde.org>
739
740         Reviewed by Lars.
741
742         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
743
744         * DumpRenderTree/qt/DumpRenderTree.cpp:
745
746 2007-11-07  Simon Hausmann  <hausmann@kde.org>
747
748         Reviewed by Lars.
749
750         Reworked the QWebSettings API.
751         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
752
753         * DumpRenderTree/qt/DumpRenderTree.cpp:
754
755 2007-11-07  Simon Hausmann  <hausmann@kde.org>
756
757         Reviewed by Lars.
758
759         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
760
761         * DumpRenderTree/qt/jsobjects.cpp:
762
763 2007-11-07  Simon Hausmann  <hausmann@kde.org>
764
765         Reviewed by Lars Knoll <lars@trolltech.com>.
766
767         Add a QWebPage::frameCreated() signal and fix DRT
768         
769         The removal of createFrame in QWebPage broke the re-implementation
770         in DumpRenderTree. Instead emit a frameCreated() signal and
771         connect to it in DumpRenderTree.
772         
773
774         * DumpRenderTree/qt/DumpRenderTree.cpp:
775         (WebCore::WebPage::WebPage):
776         (WebCore::DumpRenderTree::dump):
777         (WebCore::DumpRenderTree::connectFrame):
778         * DumpRenderTree/qt/DumpRenderTree.h:
779
780 2007-11-07  Simon Hausmann  <hausmann@kde.org>
781
782         Reviewed by Lars Knoll <lars@trolltech.com>.
783
784         Moved all the event handlers from QWebFrame into QWebPage.
785         
786         This cleans up the public API and allows us to remove the
787         HackWebFrame hack in DumpRenderTree.
788         
789
790         * DumpRenderTree/qt/jsobjects.cpp:
791         (EventSender::mouseDown):
792         (EventSender::mouseUp):
793         (EventSender::mouseMoveTo):
794
795 2007-11-07  Simon Hausmann  <hausmann@kde.org>
796
797         Reviewed by Mark.
798
799         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
800         to prevent the default implementation from popping up messageboxes.
801
802         * DumpRenderTree/qt/DumpRenderTree.cpp:
803         (WebCore::WebPage::javaScriptConfirm):
804         (WebCore::WebPage::javaScriptPrompt):
805
806 2007-11-06  Eric Seidel  <eric@webkit.org>
807
808         * Scripts/build-testkjs: build fix... too many $$
809
810 2007-11-06  Eric Seidel  <eric@webkit.org>
811
812         Reviewed by Mark Rowe.
813
814         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
815
816 2007-11-05  Adam Roben  <aroben@apple.com>
817
818         Add support on Windows for WEBKIT_TESTFONTS
819
820         This environment variable lets you specify where the fonts to be used
821         by DumpRenderTree reside. The Qt port is already using this, so I'm
822         just following their lead.
823
824         Reviewed by Darin.
825
826         * DumpRenderTree/win/DumpRenderTree.cpp:
827         (exePath): Refactored code out of initialize().
828         (fontsPath): Returns either $WEBKIT_TESTFONTS or
829         DumpRenderTree.resources.
830         (initialize): Use the new fontsPath function.
831         (main): Use the new exePath function.
832         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
833         variable to DRT, like Qt does.
834
835 2007-11-05  Mark Rowe  <mrowe@apple.com>
836
837         Rubber-stamped by Alp Toker.
838
839         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
840
841         * GtkLauncher/main.cpp:
842         (goToURLBarText):
843         (main):
844
845 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
846
847         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
848         <http://bugs.webkit.org/show_bug.cgi?id=15830>
849
850         Reviewed by Timothy.
851
852         Restrict the range of nightly builds used by the bisect-builds script
853         based on the version of Safari and the version of Mac OS X being used.
854
855         Mac OS X 10.4: Safari 2.0: r11976 or newer
856         Mac OS X 10.4: Safari 3.0: r19992 or newer
857
858         Mac OS X 10.5: Safari 2.0: r19594 or newer
859         Mac OS X 10.5: Safari 3.0: r25124 or newer
860
861         * Scripts/bisect-builds:
862         (findMacOSXVersion): Added.
863         (makeNightlyList): Added argument to provide version of Mac OS X.
864         Restrict range of nightly builds based on Safari and Mac OS X versions.
865
866 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
867
868         Reviewed by Maciej.
869
870         - This patch involves several changes, all of them were noticed that
871         they were needed by the work being done in WebKit to get Drosera and
872         WebKit working together on Windows.
873         - The changes are:
874         1) Added a debugger console for output messages.
875         2) Drosera now listens for the WebKit server (before, the server would
876         have to be running before Drosera was started.)
877         3) Fixed a bug where the WebView started out as 0x0 pixels.
878         4) Fixed a bug when there is no scope.
879         5) Added the HTML, JS, and CSS to the project file to make them easy to
880         find.
881         6) Made the ServerConnection functions virtual.
882
883         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
884         for the WebKit server.
885         (DebuggerClient::DebuggerClient):
886         (DebuggerClient::~DebuggerClient):
887         (DebuggerClient::didFinishLoadForFrame):
888         (DebuggerClient::serverConnected):
889         (DebuggerClient::attemptToCreateServerConnection):
890         * Drosera/win/DebuggerClient.h: Ditto.
891         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
892         scope.
893         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
894         (DebuggerDocument::platformValueForScopeVariableNamed):
895         * Drosera/win/Drosera.cpp:
896         (_tWinMain): Added a console in debug for output messages.
897         (Drosera::Drosera): Listen for server.
898         (Drosera::initUI): The server now Initializes COM.
899         (Drosera::serverConnected): Part of the listening for the server.
900         (Drosera::attemptToCreateServerConnection): Ditto.
901         * Drosera/win/Drosera.h: New interface for listening for the server.
902         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
903         files to the VS project.
904         * Drosera/win/ServerConnection.cpp: Part of listening for the server
905         connection.
906         (ServerConnection::ServerConnection):
907         (ServerConnection::attemptToCreateServerConnection):
908         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
909         methods.
910         (ServerConnection::serverConnected):
911
912 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
913
914         Reviewed by Maciej.
915
916         http://bugs.webkit.org/show_bug.cgi?id=15832
917         fast/dom/gc-10.html crashes when run alone
918
919         Check for !done before using objects that can be already deallocated.
920
921         * DumpRenderTree/mac/EditingDelegate.mm:
922         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
923         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
924         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
925         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
926         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
927         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
928         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
929         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
930         (-[EditingDelegate webViewDidBeginEditing:]):
931         (-[EditingDelegate webViewDidChange:]):
932         (-[EditingDelegate webViewDidEndEditing:]):
933         (-[EditingDelegate webViewDidChangeTypingStyle:]):
934         (-[EditingDelegate webViewDidChangeSelection:]):
935         * DumpRenderTree/mac/FrameLoadDelegate.mm:
936         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
937         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
938         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
939         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
940         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
941         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
942         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
943         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
944         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
945         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
946         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
947         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
948         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
949         (-[FrameLoadDelegate webView:willCloseFrame:]):
950         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
951         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
952         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
953         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
954         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
955         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
956         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
957         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
958         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
959
960 2007-11-04  Mark Rowe  <mrowe@apple.com>
961
962         Build fix.  Don't use Carbon.h as the prefix header as it triggers
963         warnings that would otherwise be suppressed due to it being a system header.
964
965         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
966
967 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
968
969         Rubber stamped by Adam.
970         
971         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
972
973         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
974
975 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
976
977         Sort files(...); sections of Xcode project files.
978
979         Rubber-stamped by Darin.
980
981         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
982         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
983         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
984         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
985
986 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
987
988         Script to sort "files(...);" sections in Xcode project.pbxproj files.
989
990         Reviewed by Darin.
991
992         * Scripts/sort-Xcode-project-file: Added.
993
994 2007-11-02  Darin Adler  <darin@apple.com>
995
996         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
997
998 2007-11-02  Darin Adler  <darin@apple.com>
999
1000         Reviewed by Maciej.
1001
1002         * Scripts/run-sunspider: Pass the "--base" option through.
1003
1004         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
1005         the real script do that. Default configuration to Release to match run-sunspider
1006         so we don't end up building Debug just to compare results.
1007
1008 2007-11-01  Adam Roben  <aroben@apple.com>
1009
1010         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
1011
1012         Reviewed by Sam.
1013
1014         * Scripts/commit-log-editor: Show all the directories beneath the
1015         source root, instead of just the last one.
1016
1017 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
1018
1019         Reviewed by Adam Roben.
1020
1021         Print out an error message when the Windows build fails
1022         and provide guidance on how to find out what went wrong.
1023
1024         * Scripts/build-webkit:
1025         * Scripts/webkitdirs.pm:
1026
1027 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
1028
1029         Rubber-stamped by Adam Roben.
1030
1031         Rolled out r27326 - debug CRT seems to cause no problems after all.
1032
1033         * DumpRenderTree/win/DumpRenderTree.vcproj:
1034
1035 2007-10-31  Adam Roben  <aroben@apple.com>
1036
1037         Switch the Debug configuration to using the non-debug CRT
1038
1039         This matches WebKit.
1040
1041         Reviewed by Steve.
1042
1043         * DumpRenderTree/win/DumpRenderTree.vcproj:
1044
1045 2007-10-31  Antti Koivisto  <antti@apple.com>
1046
1047         Reviewed by bdash.
1048         
1049         Disable media tests when doing leak checking on Tiger.
1050         They crash in QuickTime (rdar://problem/5537157).
1051
1052         * Scripts/run-webkit-tests:
1053
1054 2007-10-29  Antti Koivisto  <antti@apple.com>
1055
1056         Reviewed by Maciej.
1057         
1058         Build media support by default on OSX only.
1059
1060         * Scripts/build-webkit:
1061
1062 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1063
1064         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
1065         get caught by the pre-commit hooks.
1066
1067 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1068
1069         Reviewed by Adam.
1070
1071         - This is a collection of relatively unrelated changes and cleanups
1072         to Drosera to prepare it for interacting with WebKit.  A lot of these
1073         changes are just correcting mistakes, for example removing included
1074         headers that are no longer needed.
1075
1076         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
1077         this will be needed by the DebuggerClient.
1078         (DebuggerDocument::server):
1079         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
1080         * Drosera/win/DebuggerClient.cpp: 
1081         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
1082         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
1083         (DebuggerClient::createWebViewWithRequest): Added comment about its
1084         purpose. 
1085         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
1086         declarations.
1087         (DebuggerClient::webViewLoaded): Moved.
1088         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
1089         file, since this was the only place it was used.
1090         (cfStringToBSTR):
1091         * Drosera/win/Drosera.h: Cleaned up the includes.
1092         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
1093         * Drosera/win/HelperFunctions.h: Removed.
1094
1095 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1096
1097         Reviewed by Adam.
1098
1099         - Small cleanup in the ServerConnection class.
1100
1101         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
1102         and added an include.
1103         (ServerConnection::currentFrame):
1104         (ServerConnection::getCallerFrame):
1105         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
1106         made a pointer into a COMPtr, and cleaned up the includes.
1107
1108 2007-10-29  Timothy Hatcher  <timothy@apple.com>
1109
1110         Reviewed by John Sullivan.
1111         
1112         - Place the Localizable.strings file in mac or win directories
1113           if that location exists.
1114         - Also look for UI_STRING in .c files.
1115
1116         * Scripts/extract-localizable-strings:
1117
1118 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1119
1120         Reviewed by Adam.
1121
1122         - Set the eol-style to native and made all the line endings the same
1123         so that I avoid messy diffs that show eol changes.
1124
1125         * Drosera/win/ServerConnection.cpp:
1126         (ServerConnection::didParseSource):
1127         (ServerConnection::didEnterCallFrame):
1128         (ServerConnection::willExecuteStatement):
1129         (ServerConnection::willLeaveCallFrame):
1130         (ServerConnection::exceptionWasRaised):
1131
1132 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
1133
1134         Reviewed by Adam.
1135
1136         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
1137         functionality that could not have existed previously without the new
1138         interfaces.
1139         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
1140         from a BSTR to a JSValueRef.
1141         (DebuggerDocument::platformEvaluateScript): Implemented.
1142         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
1143         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1144         Implemented.
1145         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
1146         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
1147         * Drosera/win/ServerConnection.cpp: Added a helper function.
1148         (ServerConnection::getCallerFrame):
1149         * Drosera/win/ServerConnection.h: Added a helper function.
1150
1151 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1152
1153         updated reviewers for my previous changelog.
1154
1155 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
1156         Reviewed by Maciej and Adam and Geoff.
1157
1158         - Minor mac-side improvements including moving a function to a more
1159         appropriate location, fixing a warning, and correctly checking
1160         exceptions.
1161
1162         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
1163         (DebuggerDocument::willExecuteStatement):
1164         (DebuggerDocument::didEnterCallFrame):
1165         (DebuggerDocument::willLeaveCallFrame):
1166         (DebuggerDocument::windowScriptObjectAvailable):
1167         (DebuggerDocument::callFunctionOnObject):
1168         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
1169         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
1170         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
1171         because it doesn't require the ServerConnection at all.
1172         (NSStringCreateWithJSStringRef): Made an argument const.
1173         (JSValueRefCreateWithNSString): Made an argument const.
1174         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
1175         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1176         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
1177         * Drosera/mac/ServerConnection.mm: Ditto.
1178         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
1179
1180 2007-10-29  Sam Weinig  <sam@webkit.org>
1181
1182         Reviewed by Adam Roben.
1183
1184         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
1185
1186         * DumpRenderTree/LayoutTestController.cpp:
1187         (LayoutTestController::LayoutTestController):
1188         (getGlobalFlagCallback):
1189         (setGlobalFlagCallback):
1190         (LayoutTestController::getJSClass):
1191         (LayoutTestController::staticValues):
1192         * DumpRenderTree/LayoutTestController.h:
1193         (LayoutTestController::globalFlag):
1194         (LayoutTestController::setGlobalFlag):
1195
1196 2007-10-29  Darin Adler  <darin@apple.com>
1197
1198         Reviewed by Maciej.
1199
1200         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
1201         resolution instead of its default.
1202
1203 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
1204
1205         Fixed showStatus() to print status for successfully resolved conflicts when using git.
1206
1207         Reviewed by Mark Rowe.
1208
1209         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
1210         was successfully resolved, but this would not show any status because the change had
1211         already been cached in the index using "git add".  The solution is to add an optional
1212         second argument to showStatus() which adds the "--cached" switch to the command.
1213
1214         * Scripts/resolve-ChangeLogs:
1215         (showStatus):
1216
1217 2007-10-28  Eric Seidel  <eric@webkit.org>
1218
1219         Reviewed by Maciej and Geoff, in unison.
1220
1221         * Scripts/run-webkit-tests: remove broken --svg option
1222
1223 2007-10-28  Darin Adler  <darin@apple.com>
1224
1225         Reviewed by Adam.
1226
1227         * Scripts/run-sunspider: Default to "Release" configuration rather than
1228         defaulting to the last configuration used as other scripts do. This can
1229         still be overriden on the command line with "--debug" if there's some
1230         reason to do so. Also fix a typo.
1231
1232         * Scripts/sunspider-compare-results: Fix a typo.
1233
1234 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
1235
1236         Reviewed by Adam.
1237
1238         - Implemented the WebScriptDebugListener functions now that the
1239         WebScriptDebugServer exists
1240
1241         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
1242         functions.
1243         (ServerConnection::currentFrame):
1244         (ServerConnection::didLoadMainResourceForDataSource):
1245         (ServerConnection::didParseSource):
1246         (ServerConnection::failedToParseSource):
1247         (ServerConnection::didEnterCallFrame):
1248         (ServerConnection::willExecuteStatement):
1249         (ServerConnection::willLeaveCallFrame):
1250         (ServerConnection::exceptionWasRaised):
1251         * Drosera/win/ServerConnection.h: Removed unused arguments from the
1252         members arguments list.
1253
1254 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
1255
1256         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
1257         <http://bugs.webkit.org/show_bug.cgi?id=15600>
1258
1259         Reviewed by Darin.
1260
1261         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
1262         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
1263         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
1264         file.  Note that it may also be used as a stand-alone script.
1265
1266         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
1267         * Scripts/resolve-ChangeLogs: Added.
1268         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
1269
1270 2007-10-26  Mark Rowe  <mrowe@apple.com>
1271
1272         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
1273         to the Qt port on the assumption that it was an implementation of the cross-platform
1274         LayoutTestController class.  It is not, so it did not need to be changed.
1275
1276         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
1277
1278 2007-10-25  Mark Rowe  <mrowe@apple.com>
1279
1280         Reviewed by Maciej.
1281
1282         Fix builds with code coverage enabled.
1283
1284         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
1285
1286 2007-10-25  Darin Adler  <darin@apple.com>
1287
1288         Reviewed by Mark Rowe.
1289
1290         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
1291         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
1292
1293 2007-10-25  Stephanie  <slewis@apple.com>
1294
1295         build Fix
1296
1297         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1298
1299 2007-10-25  Stephanie  <slewis@apple.com>
1300
1301         Reviewed by Mark Rowe, Adam Roben.
1302
1303         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
1304
1305         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
1306
1307 2007-10-25  Alice Liu  <alice.liu@apple.com>
1308
1309         Reviewed by Adam.
1310
1311         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
1312
1313         Moving destructor into platform-specific files
1314         * DumpRenderTree/LayoutTestController.cpp:
1315         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1316         (LayoutTestController::~LayoutTestController):
1317         * DumpRenderTree/qt/jsobjects.cpp:
1318         (LayoutTestController::~LayoutTestController):
1319
1320         LayoutTestController wasn't being destroyed
1321         * DumpRenderTree/win/DumpRenderTree.cpp:
1322         (runTest):
1323
1324         Added declspec
1325         * DumpRenderTree/win/EditingDelegate.h:
1326
1327         Reset certain values on the webview (or related delegate) that might 
1328         have changed while running a test
1329         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1330         (LayoutTestController::~LayoutTestController):
1331
1332 2007-10-25  Adam Roben  <aroben@apple.com>
1333
1334         Make sunspider-compare-results work with relative paths
1335
1336         Reviewed by Sam.
1337
1338         * Scripts/sunspider-compare-results: Convert arguments to absolute
1339         paths before we chdir.
1340
1341 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
1342
1343         Reviewed by Sam.
1344
1345         - Implemented server calls now the WebScriptDebugServer exists.
1346         - Also removed no longer needed call to initialize CG.
1347
1348         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
1349         automatically now.
1350         (_tWinMain):
1351         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
1352         (ServerConnection::ServerConnection):
1353         (ServerConnection::~ServerConnection):
1354         (ServerConnection::pause):
1355         (ServerConnection::resume):
1356         (ServerConnection::stepInto):
1357         (ServerConnection::applicationTerminating):
1358         (ServerConnection::serverConnectionDidDie):
1359         * Drosera/win/ServerConnection.h: Now uses the COM class.
1360
1361 2007-10-24  George Staikos  <staikos@kde.org>
1362
1363         Unbreak Qt build.
1364
1365         * Scripts/build-webkit:
1366
1367 2007-10-24  Adam Roben  <aroben@apple.com>
1368
1369         Remove now-unnecessary call to InitializeCoreGraphics
1370
1371         WebKit takes care of this now.
1372
1373         Reviewed by Ada.
1374
1375         * DumpRenderTree/win/DumpRenderTree.cpp:
1376         (initialize):
1377
1378 2007-10-24  Adam Roben  <aroben@apple.com>
1379
1380         Use WebTextRenderer in DRT
1381
1382         Reviewed by Ada.
1383
1384         * DumpRenderTree/win/DumpRenderTree.cpp:
1385         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
1386
1387 2007-10-24  Sven Herzberg  <sven@imendio.com>
1388
1389         Reviewed by Mark Rowe.
1390
1391         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
1392         Bug 15614: [GTK] qmake based backends don't build on OS X
1393
1394         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
1395         GTK backend on a Mac
1396         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
1397         isDarwin() to make it reusable in other places (like the workaround-
1398         for-prebuilt-qmake in build-webkit)
1399
1400 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1401
1402         Refurbish update-webkit script.
1403
1404         Reviewed by Adam.
1405
1406         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
1407         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
1408         multi-argument version of system() for flexibility and security.  Check for existence
1409         of Internal directory using -d test instead of -x.
1410
1411 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
1412
1413         Minor clean-up of prepare-ChangeLog script.
1414
1415         Reviewed by Adam.
1416
1417         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
1418         of a string.  Use multi-argument versions of open() and system() for flexibility and
1419         security.
1420
1421 2007-10-24  Alice Liu  <alice.liu@apple.com>
1422
1423         Reviewed by Oliver.
1424
1425         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
1426
1427         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
1428         replay the saved events when we're still processing the mousedown that starts the drag
1429         * DumpRenderTree/win/EventSender.cpp:
1430         (doMouseMove):
1431         * DumpRenderTree/win/UIDelegate.cpp:
1432         (UIDelegate::doDragDrop):
1433
1434 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
1435
1436         Reviewed by Sam, Steve and Darin.
1437
1438         - Stubbed out the WebScriptDebugListener functionality in the Server
1439         Connection class to prepare it for receiving those callbacks.
1440         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
1441         and the ServerConnection to not need to be initialized with a server
1442         name, since that is not the way we connect to the WebKit server. 
1443
1444         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
1445         no exception.  Now it only loggs when there is an exception
1446         (DebuggerDocument::willExecuteStatement):
1447         (DebuggerDocument::didEnterCallFrame):
1448         (DebuggerDocument::willLeaveCallFrame):
1449         (DebuggerDocument::windowScriptObjectAvailable):
1450         (DebuggerDocument::callFunctionOnObject):
1451         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
1452         to be instantiated with a server's name.
1453         (DebuggerClient::DebuggerClient):
1454         (DebuggerClient::didFinishLoadForFrame):
1455         * Drosera/win/DebuggerClient.h: Removed unsued variable.
1456         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
1457         a server name.
1458         (Drosera::init):
1459         (Drosera::initServer):
1460         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
1461         instantiated with a server's name.
1462         * Drosera/win/ServerConnection.cpp: 
1463         (ServerConnection::ServerConnection): No longer needs a server name
1464         (ServerConnection::~ServerConnection): Only release the global context
1465         if there is one.
1466         (ServerConnection::serverConnectionDidDie): Stub for
1467         IWebScriptDebugListener
1468         (ServerConnection::QueryInterface): ditto
1469         (ServerConnection::AddRef): ditto
1470         (ServerConnection::Release): ditto
1471         (ServerConnection::didLoadMainResourceForDataSource): ditto
1472         (ServerConnection::didParseSource): ditto
1473         (ServerConnection::failedToParseSource): ditto
1474         (ServerConnection::didEnterCallFrame): ditto
1475         (ServerConnection::willExecuteStatement): ditto
1476         (ServerConnection::willLeaveCallFrame): ditto
1477         (ServerConnection::exceptionWasRaised): ditto
1478         * Drosera/win/ServerConnection.h: Stubbed out the
1479         IWebScriptDebugListener functions, and this class no longer needs to be
1480         instantiated with a server name.
1481
1482 2007-10-24  Lars Knoll  <lars@trolltech.com>
1483
1484         Reviewed by Simon.
1485
1486         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
1487
1488         * DumpRenderTree/qt/jsobjects.h:
1489
1490 2007-10-24  Lars Knoll  <lars@trolltech.com>
1491
1492         Reviewed by Simon.
1493
1494         add another command.
1495
1496         * DumpRenderTree/qt/jsobjects.cpp:
1497         (TextInputController::doCommand):
1498
1499 2007-10-24  Lars Knoll  <lars@trolltech.com>
1500
1501         Reviewed by Simon.
1502
1503         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
1504
1505         * DumpRenderTree/qt/jsobjects.cpp:
1506         (EventSender::keyDown):
1507         * DumpRenderTree/qt/jsobjects.h:
1508
1509 2007-10-24  Lars Knoll  <lars@trolltech.com>
1510
1511         Reviewed by Simon.
1512
1513         implement eventSender.keyDown().
1514
1515         * DumpRenderTree/qt/jsobjects.cpp:
1516         (EventSender::keyDown):
1517
1518 2007-10-24  Lars Knoll  <lars@trolltech.com>
1519
1520         Reviewed by Simon.
1521
1522         some smaller fixes to the editing support in DRT. Makes another few tests pass.
1523
1524         * DumpRenderTree/qt/DumpRenderTree.cpp:
1525         (WebCore::DumpRenderTree::DumpRenderTree):
1526         (WebCore::DumpRenderTree::initJSObjects):
1527         * DumpRenderTree/qt/jsobjects.cpp:
1528         (TextInputController::doCommand):
1529
1530 2007-10-24  Lars Knoll  <lars@trolltech.com>
1531
1532         Reviewed by Simon.
1533
1534         first bit of implementation for the textinputcontroller.
1535
1536         * DumpRenderTree/qt/DumpRenderTree.cpp:
1537         (WebCore::DumpRenderTree::DumpRenderTree):
1538         * DumpRenderTree/qt/DumpRenderTree.h:
1539         * DumpRenderTree/qt/jsobjects.cpp:
1540         (TextInputController::TextInputController):
1541         (TextInputController::doCommand):
1542         * DumpRenderTree/qt/jsobjects.h:
1543
1544 2007-10-24  Lars Knoll  <lars@trolltech.com>
1545
1546         Reviewed by Simon.
1547
1548         make the man webpage believe it has focus, so the editing tests work correctly.
1549
1550         * DumpRenderTree/qt/DumpRenderTree.cpp:
1551         (WebCore::DumpRenderTree::DumpRenderTree):
1552
1553 2007-10-24  Lars Knoll  <lars@trolltech.com>
1554
1555         Reviewed by Simon.
1556
1557         implement layoutTestController.dumpEditingCallbacks() correctly.
1558
1559         * DumpRenderTree/qt/DumpRenderTree.cpp:
1560         (WebCore::DumpRenderTree::DumpRenderTree):
1561         * DumpRenderTree/qt/jsobjects.cpp:
1562         (LayoutTestController::reset):
1563         (LayoutTestController::dumpEditingCallbacks):
1564
1565 2007-10-24  Lars Knoll  <lars@trolltech.com>
1566
1567         Reviewed by Simon.
1568
1569         Implement support for testing editing.
1570
1571         * DumpRenderTree/qt/DumpRenderTree.cpp:
1572         (WebCore::DumpRenderTree::DumpRenderTree):
1573
1574 2007-10-23  Sam Weinig  <sam@webkit.org>
1575
1576         Check for null BSTR that can be passed to the UIDelegate methods
1577         from javascript null and undefined.  Fixes a failing test case on
1578         Windows (fast/dom/Window/alert-undefined.html)
1579
1580         Reviewed by Eric Seidel.
1581
1582         * DumpRenderTree/win/UIDelegate.cpp:
1583         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1584         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1585         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1586         (UIDelegate::webViewAddMessageToConsole):
1587
1588 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1589
1590         Reviewed by Darin.
1591         
1592         Don't print a massive pile of setenvs from tools that automatically build testkjs.
1593
1594         * Scripts/build-testkjs:
1595
1596 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
1597
1598         Reviewed by Darin.
1599
1600         - add wrapper that finds the right copy of testkjs
1601         
1602         * Scripts/sunspider-compare-results: Added.
1603
1604 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
1605
1606         Reviewed by Sam.
1607
1608         - After talking with Steve I now see that the WebKit server must be
1609         running for DCOM to create the distributed objects, which makes sense
1610         and currently WebKit only allows one instance to be running at a time
1611         which avoids accidentally connecting to the wrong server
1612         - In light of this I have removed the code for the attach box and
1613         NotificationServer and known server names, since they are all extranious
1614         now.
1615
1616         * Drosera/win/Drosera.cpp: Removed notification classes and known server
1617         names.
1618         (_tWinMain): Uses init instead of initUI.
1619         (droseraWndProc): No longer creats an attach dialog box.
1620         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
1621         it's not manditory to call init before doing COM stuff.
1622         (Drosera::init): calls initUI and will call attach when the
1623         functionality exists. 
1624         (Drosera::initUI): Has changed very little.
1625         (Drosera::attach): Changed the signature to reflect that we no longer
1626         need the dictionary of known server names.
1627         * Drosera/win/Drosera.h: Removed notification classes and known server
1628         names.  Also renamed and moved some functions.
1629         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
1630         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
1631         headers to the resources folder. 
1632         * Drosera/win/resource.h: Removed the Attach box.
1633
1634 2007-10-22  Adam Roben  <aroben@apple.com>
1635
1636         Windows build fix
1637
1638         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
1639
1640 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
1641
1642         - Removed a leak that was fixed.
1643
1644         * Scripts/run-webkit-tests:
1645
1646 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1647
1648         Reviewed by Darin.
1649
1650         - Changed the Client so that the DebuggerDocument now own the
1651         ServerConnection.  This simplifies ownership and cleanup. 
1652
1653         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
1654         ServerConnection.
1655         (DebuggerClient::initWithServerName):
1656         (DebuggerClient::didFinishLoadForFrame):
1657         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
1658         ServerConnection.
1659         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
1660         until after we have a server which we are attached to.
1661         (Drosera::initUI):
1662         (Drosera::attach):
1663         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
1664         out previously.
1665
1666 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1667
1668         Reviewed by Nikolas.
1669
1670         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
1671
1672         * Scripts/run-javascriptcore-tests:
1673
1674 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1675
1676         Reviewed by Nikolas.
1677
1678         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
1679
1680         * Scripts/build-drosera:
1681         * Scripts/build-dumprendertree:
1682         * Scripts/build-testkjs:
1683         * Scripts/build-webkit:
1684         * Scripts/run-javascriptcore-tests:
1685         * Scripts/run-sunspider:
1686         * Scripts/run-webkit-tests:
1687         * Scripts/webkitdirs.pm:
1688
1689 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
1690
1691         Reviewed by Mark Rowe.
1692         
1693         Fix for local database support after r26879
1694         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
1695
1696         * Scripts/build-webkit:
1697
1698 2007-10-22  Holger Freyther  <zecke@selfish.org>
1699
1700         Reviewed by Simon Hausmann <hausmann@kde.org>.
1701
1702         - Do not build testkjs as an application bundle. This is
1703         needed for run-javascriptcore-tests on OSX.
1704         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
1705         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
1706         as we do not have -rpath on OSX.
1707
1708         * DumpRenderTree/qt/DumpRenderTree.pro:
1709         * Scripts/run-webkit-tests:
1710
1711 2007-10-22  Simon Hausmann  <hausmann@kde.org>
1712
1713         Reviewed by aroben.
1714
1715         Fix support for Signed-off-by detection in prepare-ChangeLog
1716         --git-commit. The Signed-off-by tag does not appear in the header
1717         but usually at the end.
1718
1719         * Scripts/prepare-ChangeLog:
1720
1721 2007-10-21  Mark Rowe  <mrowe@apple.com>
1722
1723         Reviewed by Eric.
1724
1725         Fix run-javascriptcore-tests for Gtk.
1726
1727         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
1728
1729 2007-10-20  Eric Seidel  <eric@webkit.org>
1730
1731         Reviewed by aroben.
1732
1733         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
1734
1735 2007-10-20  Eric Seidel  <eric@webkit.org>
1736
1737         Reviewed by darin.
1738         
1739         Add improved argument handling to run-sunspider, including
1740         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
1741         Also re-factor code into subroutines
1742
1743         * Scripts/build-dumprendertree: removed bogus comments
1744         * Scripts/build-testkjs: Added.
1745         * Scripts/run-javascriptcore-tests: use build-testkjs
1746         * Scripts/run-sunspider: improved argument handling, abstraction
1747         * Scripts/run-webkit-tests: improved abstraction
1748
1749 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
1750
1751         Not reviewed, Windows build fix.
1752
1753         * DumpRenderTree/win/EventSender.cpp:
1754         (keyDownCallback):
1755
1756 2007-10-20  Darin Adler  <darin@apple.com>
1757
1758         Reviewed by Tim Hatcher.
1759
1760         - http://bugs.webkit.org/show_bug.cgi?id=15544
1761           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
1762           not rely on Apple-specific key codes
1763
1764         * DumpRenderTree/mac/EventSendingController.mm:
1765         (-[EventSendingController keyDown:withModifiers:]):
1766         Added named key "rightArrow". Later we could have a whole table of these.
1767         Also tweaked modifiers code a little.
1768
1769         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
1770
1771 2007-10-19  Darin Adler  <darin@apple.com>
1772
1773         Reviewed by Eric.
1774
1775         - http://bugs.webkit.org/show_bug.cgi?id=15566
1776           possible fix for leak seen in DumpRenderTree
1777
1778         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
1779         Delete the item if it's not put on the queue, since the caller has
1780         no way of knowing that. Would be better to have the parameter type
1781         be auto_ptr to express the fact that we take ownership.
1782
1783         - unrelated change
1784
1785         * Drosera/mac/main.m: Add missing include.
1786
1787 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1788
1789         Reviewed by Adam.
1790
1791         - This change should be identical but for some reason was not working
1792         on my machine.
1793
1794         * Scripts/prepare-ChangeLog:
1795
1796 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1797
1798         Reviewed by Oliver and Tim.
1799
1800         - Made use of RetainPtr to avoid retain and release issues and moved the
1801         log function to DebuggerDocumentPlatform, which seems to be a more
1802         logical place for it to live.
1803         - Also moved knownServers from the ServerConnection to
1804         DebuggerApplication to match the Windows code and because it makes sense
1805         that a connection knows its own server but not all of them.
1806
1807         * Drosera/mac/DebuggerClient.h: Moved the log function to
1808           DebuggerDocumentPlatform.
1809         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
1810           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
1811           call for the server name up from the ServerConnection class.
1812         (-[DebuggerClient dealloc]):
1813         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
1814           for the server name up from the ServerConnection.
1815         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
1816         (DebuggerDocument::platformPause):
1817         (DebuggerDocument::platformResume):
1818         (DebuggerDocument::platformStepInto):
1819         (DebuggerDocument::platformEvaluateScript):
1820         (DebuggerDocument::getPlatformCurrentFunctionStack):
1821         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1822         (DebuggerDocument::platformValueForScopeVariableNamed):
1823         (DebuggerDocument::platformLog): Log directly from here. No need to call
1824           DebuggerClient.
1825         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
1826           way I see it, a ServerConnection should only know about its connection
1827           and the group of all possible servers should be kept by the
1828           application.
1829         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
1830           currentServerName, it makes sense that the connection should know that
1831           name.
1832         (-[ServerConnection currentServerName]):
1833
1834 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
1835
1836         Reviewed by Adam.
1837
1838         - Integrated changes from mac drosera.  Recently I've encapsulated
1839         out the server connection object from the rest of Drosera because
1840         it is very platform dependent right now and RPC is not implemented on
1841         windows.  This functionality, of communicating with the WebKit server
1842         is the next area I will be focusing on in Windows.
1843
1844         - Other changes and cleanup were made to organize the code and add notes
1845         on which parts still need work.  Also some mac code is added and
1846         commented out, to act as pseudocode for the logic of those parts.
1847
1848         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
1849           pointer.
1850         * Drosera/config.h: Added whitespace.
1851         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
1852           these files got moved into Drosera.h/cpp
1853         * Drosera/win/DebuggerApplication.h: Removed.
1854         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
1855           happened here to better match the logic flow of the same code on the 
1856           mac side and to use the new ServerConnection class.
1857         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
1858         (DebuggerClient::initWithServerName): Initializer that will set up the
1859           class to use a ServerConnection object.  This was necessary so I could
1860           create a DebuggerClient without having to initilaize it at
1861           construction.
1862         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
1863           will be the UIDelegate and FrameLoadDelegate.
1864         (DebuggerClient::AddRef): For IUnknown.
1865         (DebuggerClient::Release): For IUnknown.
1866         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
1867           this still needs to set the global context of the server, but
1868           IWebFrame does not have an accessor for the global context yet. 
1869         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
1870           this is a pass through for the same function in the document.
1871         (DebuggerClient::didReceiveTitle): Unimplemented part of
1872           FrameLoadDelegate this would change the title of the window.
1873         (DebuggerClient::createWebViewWithRequest): Part of the
1874           FrameLoadDelegate.  This is about new windows via Window.open() and
1875           how their delegates are set.
1876         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
1877           UIDelegate.  Just a debug function for printing messages.
1878         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
1879           because the Client should be the UIDelegate and FrameLoadDelegate
1880           to match the delegates on mac.
1881         (DebuggerClient::webViewLoaded): Added accessor method.
1882         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
1883           forgotten to add this file before.  This is where the platform
1884           dependent versions of the Documents functions live. Most of these are
1885           unimplemented because some piece of functionality does not exist on
1886           Windows yet.
1887         (DebuggerDocument::platformPause):
1888         (DebuggerDocument::platformResume):
1889         (DebuggerDocument::platformStepInto):
1890         (DebuggerDocument::platformEvaluateScript):
1891         (DebuggerDocument::getPlatformCurrentFunctionStack):
1892         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1893         (DebuggerDocument::platformValueForScopeVariableNamed):
1894         (DebuggerDocument::platformLog):
1895         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
1896           responsibilities becaue they belong in the Client. Also I laid the
1897           groundwork for attaching Drosera to a WebKit process
1898         (attachWndProc): Now if a server is selected the Client becomes it's
1899           delegate.
1900         (Drosera::Drosera): Added the construction of the Client and dictionary
1901           of server names. 
1902         (Drosera::initUI): This is no longer the delegates, the Client is.
1903         (Drosera::webViewLoaded): Now asks the Client instead of holding local
1904           state. 
1905         (Drosera::applicationDidFinishLaunching): Placeholder for needed
1906           notification registration when it's possible to implement.
1907         (Drosera::serverLoaded): Ditto
1908         (Drosera::serverUnloaded): Ditto
1909         (Drosera::attach): Attach Drosera to the WebKit server.
1910         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
1911         (Drosera::getInst): 
1912         (Drosera::setInst):
1913         (Drosera::knownServers):
1914         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
1915           and added the ServerConnection.
1916         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
1917         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
1918           Most of the functions are completely unimlemented because they cannot
1919           connect with the WebKit server, because one does not exist on Windows
1920           yet.
1921         (ServerConnection::initWithServerName): 
1922         (ServerConnection::~ServerConnection):
1923         (ServerConnection::setGlobalContext):
1924         (ServerConnection::pause):
1925         (ServerConnection::resume):
1926         (ServerConnection::stepInto):
1927         (ServerConnection::switchToServerNamed):
1928         (ServerConnection::applicationTerminating):
1929         (ServerConnection::serverConnectionDidDie):
1930         (ServerConnection::currentFrame):
1931         * Drosera/win/ServerConnection.h: Added. Ditto.
1932         (ServerConnection::ServerConnection):
1933
1934 2007-10-19  Alice Liu  <alice.liu@apple.com>
1935
1936         Reviewed by Darin.
1937
1938         Fix for these broken layout tests on Windows:
1939         
1940         fast/forms/focus-selection-input.html
1941         fast/forms/focus-selection-textarea.html
1942         fast/forms/select-accesskey.html
1943         
1944         * DumpRenderTree/win/EventSender.cpp:
1945         (keyDownCallback):
1946         correct the VK code for alt key.
1947         
1948 2007-10-19  Eric Seidel  <eric@webkit.org>
1949
1950         Reviewed by Mark Rowe.
1951         
1952         Make the GtkLauncher code slightly more readable.
1953
1954         * GtkLauncher/main.cpp:
1955         (setupMainMenu): Added.
1956         (setupMainWindowUI): Added.
1957         (main):
1958
1959 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
1960
1961         Rubber stamped by Adam.
1962         
1963         - don't delay-load WebKit in DumpRenderTree.
1964
1965         * DumpRenderTree/win/DumpRenderTree.vcproj:
1966
1967 2007-10-18  Dan Bernstein  <mitz@apple.com>
1968
1969         Reviewed by Adam Roben.
1970
1971         - fix <rdar://problem/5313523>
1972         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
1973
1974         * DumpRenderTree/mac/DumpRenderTree.mm:
1975         (dump): Changed to use _responseMIMEType.
1976
1977 2007-10-17  Adam Roben  <aroben@apple.com>
1978
1979         Make it possible to have Windows-specific tests and results
1980
1981         When searching for tests to run and the Skipped file, we will only
1982         look in platform/win and the cross-platform directory. When looking
1983         for expected results, we will look in platform/win, then
1984         platform/mac-leopard, then platform/mac, then finally the
1985         cross-platform directory.
1986
1987         Reviewed by Sam.
1988
1989         * Scripts/run-webkit-tests:
1990         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
1991         searching in the cross-platform directory.
1992         (sub buildPlatformHierarchy): Removed some unneeded calls to
1993         dirname/basename.
1994
1995 2007-10-17  Adam Roben  <aroben@apple.com>
1996
1997         Add back the call to register WebKit that we had before WebKitInitializer existed
1998
1999         This is needed to ensure that the right WebKit is used when
2000         instantiating COM objects.
2001
2002         Reviewed by Oliver.
2003
2004         * DumpRenderTree/win/debug_internal.vsprops: Define
2005         DEBUG_WEBKIT_HAS_SUFFIX.
2006         * DumpRenderTree/win/DumpRenderTree.cpp:
2007         (initialize):
2008
2009 2007-10-17  Adam Roben  <aroben@apple.com>
2010
2011         Import File::Basename in webkitdirs since we use it
2012
2013         * Scripts/webkitdirs.pm:
2014
2015 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
2016
2017         - Updated the tiger leaks list to make the internal bots green.
2018
2019         * Scripts/run-webkit-tests:
2020
2021 2007-10-17  Adam Roben  <aroben@apple.com>
2022
2023         Build fix for VC++ Express
2024
2025         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
2026         and ole32.lib.
2027
2028 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2029
2030         Reviewed by Sam.
2031
2032         - Minor mac improvements based on observations I made while implementing the
2033         Windows code.
2034
2035         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
2036         then hand it to the Client who will retain it, it should just be the client who
2037         creates and owns the server.
2038         (-[DebuggerApplication attach:]):
2039         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
2040         * Drosera/mac/DebuggerClient.mm: Creates the server.
2041         (-[DebuggerClient initWithServerName:]):
2042         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
2043         can instead forward declare what it needs.
2044
2045 2007-10-16  Darin Adler  <darin@apple.com>
2046
2047         Reviewed by Geoff Garen.
2048
2049         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
2050         want to turn failing tests into platform-specific test results. Also did a
2051         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
2052         would take the type of results into account only some of the time.
2053
2054 2007-10-16  Adam Roben  <aroben@apple.com>
2055
2056         Add a new nightly launcher script for Windows
2057
2058         This new script is for versions of Safari that don't delay-load
2059         WebKit. I had to make FindSafari be able to print out the nightly
2060         launcher script on stdout because Windows shell scripts can't capture
2061         the output from a command into an environment variable.
2062
2063         Reviewed by Steve.
2064
2065         * FindSafari/FindSafari.cpp:
2066         (_tmain): Added /printSafariLauncher option.
2067         * Scripts/run-webkit-nightly.cmd: Added.
2068
2069 2007-10-16  Adam Roben  <aroben@apple.com>
2070
2071         Replace WebKitInitializer with FindSafari
2072
2073         We now rely on setting the PATH environment variable to tell Windows
2074         where to find WebKit and its dependencies (similar to
2075         DYLD_FRAMEWORK_PATH on Mac).
2076
2077         This change also make DumpRenderTree no longer delay-load WebKit.
2078
2079         Reviewed by Sam.
2080
2081         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
2082         FindSafari.
2083         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
2084         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
2085         WebKitInitializer, don't delay-load WebKit.
2086         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
2087         * Scripts/run-webkit-tests: Ditto.
2088         * Scripts/webkitdirs.pm:
2089         (sub setPathForRunningWebKitApp): Added.
2090         * WebKitInitializer/WebKitInitializer.cpp: Removed.
2091         * WebKitInitializer/WebKitInitializer.h: Removed.
2092         * WebKitInitializer/WebKitInitializer.vcproj: Removed.
2093         * WebKitInitializer/debug.vsprops: Removed.
2094         * WebKitInitializer/debug_internal.vsprops: Removed.
2095         * WebKitInitializer/release.vsprops: Removed.
2096
2097 2007-10-16  Adam Roben  <aroben@apple.com>
2098
2099         Fix Bug 15532: run-safari fails if Safari is installed in a non-default location
2100
2101         http://bugs.webkit.org/show_bug.cgi?id=15532
2102
2103         FindSafari simply prints the location of an installed Safari.exe on
2104         stdout.
2105
2106         Reviewed by Darin.
2107
2108         * FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp.
2109         (getStringValue):
2110         (getWebViewCLSID):
2111         (getInstalledWebKitDirectory):
2112         (_tmain):
2113         * FindSafari/FindSafari.vcproj: Added.
2114         * Scripts/webkitdirs.pm:
2115         (sub installedSafariPath): Added. Calls FindSafari on Windows.
2116
2117 2007-10-16  Adam Roben  <aroben@apple.com>
2118
2119         Updated for rename of WebKit_debug.dll to WebKit.dll for the Debug configuration
2120
2121         Reviewed by Kevin McCullough.
2122
2123         * DumpRenderTree/win/DumpRenderTree.vcproj: Use WebKitDLLConfigSuffix
2124         when referring to WebKit.dll.
2125         * DumpRenderTree/win/debug.vsprops: Added WebKitDLLConfigSuffix.
2126         * DumpRenderTree/win/debug_internal.vsprops: Ditto.
2127         * DumpRenderTree/win/release.vsprops: Ditto.
2128         * Scripts/run-safari: Don't pass /debug to Safari anymore because we
2129         never have a _debug suffix on WebKit.dll.
2130         * WebKitInitializer/WebKitInitializer.cpp:
2131         (initializeWebKit): Only use the _debug suffix for WebKit.dll when
2132         specified.
2133         * WebKitInitializer/debug_internal.vsprops: Added
2134         DEBUG_WEBKIT_HAS_SUFFIX preprocessor definition.
2135
2136 2007-10-16  Darin Adler  <darin@apple.com>
2137
2138         Reviewed by Adele.
2139
2140         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback):
2141         Remove now-unneeded control/alt key hack; the tests have been updated.
2142
2143 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
2144
2145         - Updated leaks list because our internal bot upgraded it's version of leopard and 
2146         one of the leaks was fixed between that revision and the bot's previous version of
2147         leopard.
2148
2149         * Scripts/run-webkit-tests:
2150
2151 2007-10-15  Kevin McCullough  <kmccullough@apple.com>
2152
2153         Reviewed by Tim.
2154
2155         - I encapsulated out the server connecton functionality because it is a specific part
2156         of Drosera that will be platform dependant until the WebScriptDebugServer can be moved
2157         into WebCore and C++.  But if it is encapsulated out it can be easily replaced on
2158         Windows.  So the majority of this patch is moving preexisting functionality.
2159
2160         - Also I removed the prefix header and changed to use config.h because it is more
2161         standard on how we use config.h in windows and it didn't make much sense to keep
2162         the prefix header and the config.h
2163
2164         * Drosera/DebuggerDocument.cpp:
2165         (DebuggerDocument::DebuggerDocument):
2166         * Drosera/DebuggerDocument.h:
2167         * Drosera/config.h:
2168         * Drosera/mac/DebuggerApplication.mm:
2169         (-[DebuggerApplication attach:]):
2170         * Drosera/mac/DebuggerClient.h:
2171         * Drosera/mac/DebuggerClient.mm:
2172         (-[DebuggerClient initWithServerConnection:]):
2173         (-[DebuggerClient dealloc]):
2174         (-[DebuggerClient windowDidLoad]):
2175         (-[DebuggerClient windowWillClose:]):
2176         (-[DebuggerClient webView:didFinishLoadForFrame:]):
2177         (-[DebuggerClient webView:didReceiveTitle:forFrame:]):
2178         * Drosera/mac/DebuggerDocumentPlatform.mm:
2179         (DebuggerDocument::platformPause):
2180         (DebuggerDocument::platformResume):
2181         (DebuggerDocument::platformStepInto):
2182         (DebuggerDocument::platformEvaluateScript):
2183         (DebuggerDocument::getPlatformCurrentFunctionStack):
2184         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2185         (DebuggerDocument::platformValueForScopeVariableNamed):
2186         (DebuggerDocument::platformLog):
2187         * Drosera/mac/Drosera.pch: Removed.
2188         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2189         * Drosera/mac/ServerConnection.h: Added.
2190         * Drosera/mac/ServerConnection.mm: Added.
2191         (-[ServerConnection initWithServerName:]):
2192         (-[ServerConnection dealloc]):
2193         (-[ServerConnection setGlobalContext:]):
2194         (-[ServerConnection pause]):
2195         (-[ServerConnection resume]):
2196         (-[ServerConnection stepInto]):
2197         (-[ServerConnection switchToServerNamed:]):
2198         (-[ServerConnection applicationTerminating:]):
2199         (-[ServerConnection serverConnectionDidDie:]):
2200         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2201         (-[ServerConnection webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
2202         (-[ServerConnection webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
2203         (-[ServerConnection webView:didEnterCallFrame:sourceId:line:forWebFrame:]):
2204         (-[ServerConnection webView:willExecuteStatement:sourceId:line:forWebFrame:]):
2205         (-[ServerConnection webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
2206         (-[ServerConnection webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
2207         (-[ServerConnection currentFrame]):
2208         (-[ServerConnection webScriptAttributeKeysForScriptObject:]):
2209         (-[ServerConnection knownServers]):
2210
2211 2007-10-15  David Kilzer  <ddkilzer@webkit.org>
2212
2213         Reviewed by Eric.
2214
2215         - fix http://bugs.webkit.org/show_bug.cgi?id=15002
2216           Script to automatically search nightly builds for regressions (bisect-builds)
2217
2218         * Scripts/bisect-builds: Added.
2219
2220 2007-10-14  Maciej Stachowiak  <mjs@apple.com>
2221
2222         Reviewed by Darin.
2223
2224         - New JavaScript benchmark
2225         http://bugs.webkit.org/show_bug.cgi?id=15515
2226
2227         * Scripts/run-sunspider: Added. Wrapper to run sunspider on the
2228         current development or release build of JavaScriptCore.
2229
2230 2007-10-15  Mark Rowe  <mrowe@apple.com>
2231
2232         Reviewed by Sam.
2233
2234         Fix 'run-webkit-tests --qt' complaining about the --qt argument.
2235
2236         * Scripts/webkitdirs.pm:
2237         - Change checkArgv to remove the options from @ARGV to prevent
2238         them from interfering with further option processing.
2239         - Fix logic error in determineIsQt that would prevent it from bailing out early.
2240         - Change isOSX to mean OS X and not Qt or Gtk.  Most of our uses of isOSX assume that this is the meaning
2241         already, so this change fixes several broken areas of the scripts including 'run-webkit-tests --qt' on a Mac
2242         incorrectly using the Mac results, and 'run-webkit-tests --gtk' attempting to build the Mac DumpRenderTree.
2243
2244 2007-10-15  Darin Adler  <darin@apple.com>
2245
2246         Reviewed by Sam.
2247
2248         - added logging of window.prompt and window.confirm
2249
2250         * DumpRenderTree/mac/UIDelegate.mm:
2251         (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
2252         Implement the recommended delegate rather than the deprecated one.
2253         (-[UIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]):
2254         Added.
2255         (-[UIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:]):
2256         Added.
2257
2258         * DumpRenderTree/win/UIDelegate.h:
2259         * DumpRenderTree/win/UIDelegate.cpp:
2260         (UIDelegate::runJavaScriptAlertPanelWithMessage): Got rid of unnecessary check for null string.
2261         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
2262         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Added.
2263         (UIDelegate::webViewAddMessageToConsole): Got rid of unnecessary check for null string.
2264
2265 2007-10-15  Alice Liu  <alice.liu@apple.com>
2266
2267         Reviewed by Sam Weinig.
2268
2269         Fixed <rdar://5382546> layoutTestController.setCustomPolicyDelegate is unimplemented causing tests to fail
2270
2271         * DumpRenderTree/win/DumpRenderTree.cpp:
2272         (runTest): Like on mac, before running each test, set the webview's policy delegate to null
2273         (main): allocate the global policy delegate for DRT's custom use
2274         * DumpRenderTree/win/DumpRenderTree.vcproj:
2275         Adding files to project
2276         * DumpRenderTree/win/DumpRenderTreeWin.h: declaring global DRT policy delegate
2277         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2278         (LayoutTestController::setCustomPolicyDelegate):
2279         set the webview's policy delegate to DRT's custom one if the test requests it.
2280         * DumpRenderTree/win/PolicyDelegate.cpp: Added.
2281         Implementation is a direct port of DumpRenderTree/mac/PolicyDelegate.mm
2282         (PolicyDelegate::PolicyDelegate):
2283         (PolicyDelegate::QueryInterface):
2284         (PolicyDelegate::AddRef):
2285         (PolicyDelegate::Release):
2286         (PolicyDelegate::decidePolicyForNavigationAction):
2287         * DumpRenderTree/win/PolicyDelegate.h: Added.
2288         (PolicyDelegate::decidePolicyForNewWindowAction):
2289         (PolicyDelegate::decidePolicyForMIMEType):
2290         (PolicyDelegate::unableToImplementPolicyWithError):
2291
2292 2007-10-14  Holger Hans Peter Freyther  <zecke@selfish.org>
2293
2294         Reviewed by Mark.
2295
2296         * Scripts/webkitdirs.pm: Use qmake binary specified via --qmake on command-line
2297         when querying for QMAKE_MKSPECS.
2298
2299 2007-10-14  Andrew Wellington  <proton@wiretapped.net>
2300
2301         Reviewed by Adam Roben.
2302         
2303         Fix run-webkit-tests is too greedy calculating platform hierarchy
2304         http://bugs.webkit.org/show_bug.cgi?id=15465
2305         
2306         Fix run-webkit-tests being too greedy in trying to split the platform name up
2307         causing it to try and find tests in every directory above the first "-" in the
2308         path to the LayoutTests
2309
2310         * Scripts/run-webkit-tests:
2311
2312 2007-10-14  Oleg Sukhodolsky <son.two@gmail.com>
2313
2314         Reviewed by Darin.
2315
2316         http://bugs.webkit.org/show_bug.cgi?id=15006
2317         Refactoring of buildQMakeGdkProject()/buildQMakeQtProject() and isGdk()/isQt()
2318         to reduce code duplication.
2319
2320         * Scripts/build-webkit:
2321         * Scripts/webkitdirs.pm:
2322         buildQMakeProject() renamed to buildQMakeQtProject().
2323         buildQMakeGdkProject()/buildQMakeQtProject() now take just one parameter (directory),
2324         unused $colorize has been removed.
2325
2326 === Start merge of feature-branch 2007-10-12 ===
2327
2328 2007-10-08  Eric Seidel  <eric@webkit.org>
2329
2330         Reviewed by Mark Rowe.
2331
2332         * Scripts/build-webkit: add --help, remove unused --color
2333
2334 2007-10-07  Eric Seidel  <eric@webkit.org>
2335
2336         Reviewed by darin.
2337
2338         * Drosera/mac/DebuggerDocumentPlatform.mm:
2339         (DebuggerDocument::platformEvaluateScript): null check before trying to make a JSString
2340
2341 2007-10-03  Rob Buis  <buis@kde.org>
2342
2343         Reviewed by Olliej.
2344
2345         Adapt to changed location of Ahem font.
2346
2347         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2348
2349 2007-10-02  Eric Seidel  <eric@webkit.org>
2350
2351         Reviewed by Adam Roben.
2352         
2353         Make pixel tests more useful!
2354         Finally fix the image diff 0.00% mystery problem
2355         Highlight any image differences in the image diff.
2356         Add a link from image diffs back to original test file.
2357
2358         * DumpRenderTree/mac/ImageDiff.m:
2359         (compareImages): highlight any differences
2360         (computePercentageDifferent): round to two decimal places
2361         * Scripts/run-webkit-tests: add a few more toURL calls for the windows folks
2362
2363 2007-10-02  Eric Seidel  <eric@webkit.org>
2364
2365         Reviewed by Alexey Proskuryakov.
2366
2367         * Scripts/run-webkit-tests: print the % image difference on main results page
2368
2369 2007-10-02  Mark Rowe  <mrowe@apple.com>
2370
2371         Reviewed by Oliver.
2372
2373         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2374
2375         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2376         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2377
2378 2007-10-01  Mark Rowe  <mrowe@apple.com>
2379
2380         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2381
2382 2007-09-25  Eric Seidel  <eric@webkit.org>
2383
2384         Reviewed by Mark Rowe.
2385         
2386         DerivedSources.make was finding "ENABLE_SVG" in the string
2387         "ENABLE_SVG_EXPERIMENTAL_FEATURES" thus --no-svg wasn't functioning
2388         quite correctly.
2389
2390         * Scripts/build-webkit: make --no-svg imply --no-svg-experimental
2391
2392 2007-09-25  Mark Rowe  <mrowe@apple.com>
2393
2394         Rubber-stamped by Eric.
2395
2396         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2397         This makes it possible to automate nightly builds for the feature-branch.
2398
2399 2007-07-11  Nikolas Zimmermann  <zimmermann@kde.org>
2400
2401         Rubber stamped by Mark.
2402
2403         Enable svg experimental features as default here in feature-branch.
2404
2405         * Scripts/build-webkit:
2406
2407 2007-06-29  Antti Koivisto  <antti@apple.com>
2408
2409         Reviewed by Weinig.
2410         
2411         Add VIDEO flag for timed media features
2412
2413         * Scripts/build-webkit
2414         
2415 === End merge of feature-branch 2007-10-12 ===
2416
2417 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2418
2419         Reviewed by Darin.
2420
2421         - Updated rational for the leaks list to be more clear.
2422
2423         * Scripts/run-webkit-tests:
2424
2425 2007-10-11  Kevin McCullough  <kmccullough@apple.com>
2426
2427         Rubber Stamp by Sam.
2428
2429         Adding a known Leopard leak that is already fixed but the bot is on an old version of Leopard.
2430         I believe there was a radar on this leak, it looks familiar to me, but I could not find it.
2431
2432         * Scripts/run-webkit-tests:
2433
2434 2007-10-10  Simon Hausmann  <hausmann@kde.org>
2435
2436         Reviewed by Lars.
2437
2438         Fix compilation using gcc 4.3. Header files have been reorganized and as a result some extra
2439         includes are needed for INT_MAX, std::auto_ptr and the like.
2440
2441         * DumpRenderTree/qt/main.cpp:
2442
2443 2007-10-09  Lars Knoll  <lars@trolltech.com>
2444
2445         Reviewed by Simon.
2446
2447         implement layoutTestController.encode/decodeHostName. We still don't pass fast/encoding/idn-security.html, since our QUrl::from/toACE is somewhat stricter than ICU.
2448
2449         * DumpRenderTree/qt/jsobjects.cpp:
2450         (LayoutTestController::encodeHostName):
2451         (LayoutTestController::decodeHostName):
2452         * DumpRenderTree/qt/jsobjects.h:
2453
2454 2007-10-09  Lars Knoll  <lars@trolltech.com>
2455
2456         Reviewed by Simon.
2457
2458         Don't set up connections inside QWebPage::createFrame, as users might be reimplementing that method. Make sure we get only one titleChanged() signal per title change, and implement the support for testing this in DRT.
2459
2460         * DumpRenderTree/qt/DumpRenderTree.cpp:
2461         (WebCore::WebPage::createFrame):
2462         (WebCore::DumpRenderTree::DumpRenderTree):
2463         (WebCore::DumpRenderTree::titleChanged):
2464         * DumpRenderTree/qt/DumpRenderTree.h:
2465         * DumpRenderTree/qt/jsobjects.cpp:
2466         (LayoutTestController::reset):
2467         * DumpRenderTree/qt/jsobjects.h:
2468
2469 2007-10-09  Lars Knoll  <lars@trolltech.com>
2470
2471         Reviewed by Simon.
2472
2473         add a dummy implementation for layoutTestController.display() and implement layoutTestController.clearBackForwardList().
2474
2475         * DumpRenderTree/qt/DumpRenderTree.h:
2476         * DumpRenderTree/qt/jsobjects.cpp:
2477         (LayoutTestController::clearBackForwardList):
2478         * DumpRenderTree/qt/jsobjects.h:
2479
2480 2007-10-09  Lars Knoll  <lars@trolltech.com>
2481
2482         Reviewed by Simon.
2483
2484         make --git-reviewer work again.
2485
2486         * Scripts/prepare-ChangeLog:
2487
2488 2007-10-07  Holger Hans Peter Freyther  <zecke@selfish.org>
2489
2490         Rubber stamped by Eric.
2491
2492         Connect to the "hovering-over-link" signal emitted by WebKitPage and
2493         show the current link inside the statusbar.
2494         This shows how to make use of this signal and allows to easily test
2495         http://bugs.webkit.org/show_bug.cgi?id=15299.
2496
2497         * GtkLauncher/main.cpp:
2498         (hoveringOverLink):
2499         (main):
2500
2501 2007-10-05  Lars Knoll  <lars@trolltech.com>
2502
2503         add proper error messages to the FrameLoaderClient.
2504         Implement ChromeClientQt::closeWindowSoon and
2505         FrameLoaderClientQt::dispatchCreatePage (which should go away IMO).
2506         Some fixes in DRT to make it work correctly with multiple windows.
2507
2508         Reviewed by Maciej.
2509
2510         * DumpRenderTree/qt/DumpRenderTree.cpp:
2511         (WebCore::DumpRenderTree::DumpRenderTree):
2512         (WebCore::DumpRenderTree::createWindow):
2513         (WebCore::DumpRenderTree::windowCount):
2514         * DumpRenderTree/qt/DumpRenderTree.h:
2515         * DumpRenderTree/qt/jsobjects.cpp:
2516         (LayoutTestController::maybeDump):
2517         (LayoutTestController::windowCount):
2518         * DumpRenderTree/qt/jsobjects.h:
2519
2520 2007-10-05  Lars Knoll  <lars@trolltech.com>
2521
2522         Add a dummy plugin to DRT  to fix fast/dom/Window/Plug-Ins.html.
2523         Add support for layoutTextController.setCanOpenWindows() to DRT
2524         fixing another 2 test cases in fast/dom/Window.
2525
2526         Reviewed by Maciej.
2527
2528         * DumpRenderTree/qt/DumpRenderTree.cpp:
2529         (WebCore::WebPage::WebPage):
2530         (WebCore::WebPage::createWindow):
2531         (WebCore::DumpRenderTree::resetJSObjects):
2532         (WebCore::DumpRenderTree::createWindow):
2533         * DumpRenderTree/qt/DumpRenderTree.h:
2534         * DumpRenderTree/qt/DumpRenderTree.pro:
2535         * DumpRenderTree/qt/jsobjects.cpp:
2536         (LayoutTestController::LayoutTestController):
2537         (LayoutTestController::reset):
2538         * DumpRenderTree/qt/jsobjects.h:
2539         * DumpRenderTree/qt/main.cpp:
2540         * DumpRenderTree/qt/testplugin.cpp: Added.
2541         * DumpRenderTree/qt/testplugin.h: Added.
2542
2543 2007-10-04  Sam Weinig  <sam@webkit.org>
2544
2545         Rubber stamped by Adam.
2546
2547         Remove empty directories.
2548
2549         * DumpRenderTree/DumpRenderTree.qtproj: Removed.
2550         * DumpRenderTree/DumpRenderTree.qtproj/fonts: Removed.
2551
2552 2007-10-03  Darin Adler  <darin@apple.com>
2553
2554         Reviewed by Adam.
2555
2556         * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
2557         we find the internal libraries in the libraries directory. This
2558         is helpful for Safari team engineers at Apple.
2559
2560 2007-10-03  Adam Roben  <aroben@apple.com>
2561
2562         Update the location of AHEM___.TTF after r25968
2563
2564         Reviewed by Sam.
2565
2566         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2567
2568 2007-10-03  Alp Toker  <alp@atoker.com>
2569
2570         Reviewed by Adam.
2571
2572         http://bugs.webkit.org/show_bug.cgi?id=14726
2573         [gtk] API design. Mapping the WebView delegates to signals.
2574
2575         Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.
2576
2577         * GtkLauncher/main.cpp:
2578         (goToURLBarText):
2579         (titleChanged):
2580         (progressChanged):
2581         (menuMainBackCallback):
2582         (menuMainForwardCallback):
2583         (main):
2584
2585 2007-10-03  Lars Knoll  <lars@trolltech.com>
2586
2587         Reviewed by Rob.
2588
2589         This fixes --strict mode in run-webkit-tests again after
2590         the platform dependent test results have been moved.
2591
2592         * Scripts/run-webkit-tests:
2593
2594 2007-10-03  Lars Knoll  <lars@trolltech.com>
2595
2596         Reviewed by bdash.
2597
2598         remove the hack in run-webkit-tests that forced text only test
2599         to be taken from the platform independent dir. It was only left
2600         there from early days.
2601         
2602         Remove platform dependent results for tests that are text only nowadays,
2603         and add one platform dependent result for a text only test that requires it.
2604
2605         * Scripts/run-webkit-tests:
2606
2607 2007-10-03  Lars Knoll  <lars@trolltech.com>
2608
2609         Reviewed by olliej.
2610
2611         Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.
2612
2613         * DumpRenderTree/qt/DumpRenderTree.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp.
2614         (WebCore::WebFrame::WebFrame):
2615         (WebCore::WebPage::WebPage):
2616         (WebCore::WebPage::createFrame):
2617         (WebCore::WebPage::javaScriptAlert):
2618         (WebCore::WebPage::javaScriptConsoleMessage):
2619         (WebCore::DumpRenderTree::DumpRenderTree):
2620         (WebCore::DumpRenderTree::~DumpRenderTree):
2621         (WebCore::DumpRenderTree::open):
2622         (WebCore::DumpRenderTree::readStdin):
2623         (WebCore::DumpRenderTree::resetJSObjects):
2624         (WebCore::DumpRenderTree::initJSObjects):
2625         (WebCore::DumpRenderTree::dumpFramesAsText):
2626         (WebCore::DumpRenderTree::dump):
2627         * DumpRenderTree/qt/DumpRenderTree.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h.
2628         (WebCore::DumpRenderTree::layoutTestController):
2629         (WebCore::DumpRenderTree::eventSender):
2630         * DumpRenderTree/qt/DumpRenderTree.pro: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro.
2631         * DumpRenderTree/qt/fonts.conf: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts.conf.
2632         * DumpRenderTree/qt/fonts/AHEM____.TTF: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/fonts/AHEM____.TTF.
2633         * DumpRenderTree/qt/jsobjects.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp.
2634         (HackWebFrame::mousePressEvent):
2635         (HackWebFrame::mouseReleaseEvent):
2636         (HackWebFrame::mouseMoveEvent):
2637         (HackWebFrame::HackWebFrame):
2638         (HackWebFrame::~HackWebFrame):
2639         (LayoutTestController::LayoutTestController):
2640         (LayoutTestController::reset):
2641         (LayoutTestController::maybeDump):
2642         (LayoutTestController::waitUntilDone):
2643         (LayoutTestController::notifyDone):
2644         (LayoutTestController::dumpEditingCallbacks):
2645         (LayoutTestController::queueReload):
2646         (LayoutTestController::provisionalLoad):
2647         (LayoutTestController::timerEvent):
2648         (EventSender::EventSender):
2649         (EventSender::mouseDown):
2650         (EventSender::mouseUp):
2651         (EventSender::mouseMoveTo):
2652         (EventSender::leapForward):
2653         (EventSender::keyDown):
2654         (EventSender::frameUnderMouse):
2655         * DumpRenderTree/qt/jsobjects.h: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h.
2656         (LayoutTestController::isLoading):
2657         (LayoutTestController::setLoading):
2658         (LayoutTestController::shouldDumpAsText):
2659         (LayoutTestController::shouldDumpChildrenAsText):
2660         (LayoutTestController::shouldWaitUntilDone):
2661         (LayoutTestController::dumpAsText):
2662         (LayoutTestController::dumpChildFramesAsText):
2663         * DumpRenderTree/qt/main.cpp: Renamed from WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/main.cpp.
2664         (messageHandler):
2665         (crashHandler):
2666         (main):
2667         * Scripts/run-webkit-tests:
2668
2669 2007-10-03  Mark Rowe  <mrowe@apple.com>
2670
2671         Reviewed by Alp Toker.
2672
2673         Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
2674         should take precedence over QTDIR when determining which port we are working with.
2675
2676         * Scripts/webkitdirs.pm: 
2677
2678 2007-10-02  Adam Roben  <aroben@apple.com>
2679
2680         Add keychain to the list of default packages to install
2681
2682         Rubberstamped by Sam.
2683
2684         * CygwinDownloader/cygwin-downloader.py:
2685         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2686
2687 2007-10-02  David Kilzer  <ddkilzer@webkit.org>
2688
2689         Reviewed by Adam.
2690
2691         Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
2692         Also makes WebCore regression test case logic work when using git.
2693
2694         * Scripts/prepare-ChangeLog:
2695         (reviewerAndDescriptionForGitCommit): Added.
2696
2697 2007-10-02  Lars Knoll  <lars@trolltech.com>
2698
2699         Reviewed by bdash.
2700
2701         Add API to retrieve the frame name from QWebFrame.
2702         Implement support for DRT::dumpChildrenAsText.
2703
2704         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2705         (WebCore::DumpRenderTree::dumpFramesAsText):
2706         (WebCore::DumpRenderTree::dump):
2707         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
2708         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2709         (LayoutTestController::LayoutTestController):
2710         (LayoutTestController::reset):
2711         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
2712
2713 2007-10-02  Lars Knoll  <lars@trolltech.com>
2714
2715         Reviewed by bdash.
2716
2717         Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.
2718
2719         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2720         (WebCore::DumpRenderTree::readStdin):
2721
2722 2007-10-02  Mark Rowe  <mrowe@apple.com>
2723
2724         Reviewed by Oliver.
2725
2726         Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.
2727
2728         * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
2729         * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.
2730
2731 2007-10-02  Mark Rowe  <mrowe@apple.com>
2732
2733         Rubber-stamped by Maciej.
2734
2735         Configuration changes from build.webkit.org.  The major change is refactoring to work
2736         with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
2737         last few weeks.
2738
2739         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2740         * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
2741         * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
2742         * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
2743         * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
2744         * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
2745         * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
2746         * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:
2747
2748 2007-10-02  Lars Knoll  <lars@trolltech.com>
2749
2750         Reviewed by Maciej.
2751
2752         Add support for eventSender.mouseMove to DRT.
2753         Fixes fast/css/hover-affects-child.html
2754
2755         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
2756         (EventSender::mouseMoveTo):
2757
2758 2007-10-01  Mark Rowe  <mrowe@apple.com>
2759
2760         * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.
2761
2762 2007-10-01  David Kilzer  <ddkilzer@webkit.org>
2763
2764         Reviewed by Hyatt.
2765
2766         Make svn-apply and svn-unapply work with added files in git-diff formatted patches.
2767
2768         * Scripts/svn-apply:
2769         (gitdiff2svndiff): Ignore lines beginning with "new file".
2770         * Scripts/svn-unapply:
2771         (gitdiff2svndiff): Ditto.
2772
2773 2007-09-30  George Staikos  <staikos@kde.org>
2774
2775         Qt build fix (Mac OS X specific)
2776
2777         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.pro:
2778
2779 2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>
2780
2781         Reviewed by Mark.
2782
2783         -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
2784         Remove Bakefiles from svn.
2785
2786         * GtkLauncher/Bakefiles.bkgen: Removed.
2787         * GtkLauncher/ENV: Removed.
2788         * GtkLauncher/gdklauncher.bkl: Removed.
2789         * GtkLauncher/mk: Removed.
2790         * Scripts/regenerate-makefiles: Removed.
2791
2792 2007-09-25  Kevin McCullough  <kmccullough@apple.com>
2793
2794         Reviewed by John.
2795
2796         - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.
2797
2798         * Scripts/run-webkit-tests:
2799
2800 2007-09-26  Adam Roben  <aroben@apple.com>
2801
2802         Make not finding an installed WebKit non-fatal
2803
2804         What really matters is that we are able to load WebKit and its
2805         dependencies, not whether we think we've found an installed WebKit.
2806
2807         Reviewed by Sam.
2808
2809         * WebKitInitializer/WebKitInitializer.cpp:
2810         (getWebViewCLSID): Use new LOG_WARNING macro.
2811         (getInstalledWebKitDirectory): Ditto.
2812         (initializeWebKit): Don't die if we didn't find an installed WebKit,
2813         and use new macros.
2814         * WebKitInitializer/WebKitInitializer.vcproj: Disabled a warning.
2815
2816 2007-09-26  Adam Roben  <aroben@apple.com>
2817
2818         Committed this file before saving it
2819
2820         * WebKitInitializer/debug_internal.vsprops:
2821
2822 2007-09-26  Adam Roben  <aroben@apple.com>
2823
2824         Load WebKit and its dependencies manually so they come from DllDirectory
2825
2826         I had to change WebKitInitializer to use malloc/free instead of
2827         new/delete to avoid pulling in WebKit (and its dependencies) early
2828         through use of fastMalloc.
2829
2830         Reviewed by Oliver.
2831
2832         * WebKitInitializer/WebKitInitializer.cpp:
2833         (getStringValue): Changed to use malloc/free.
2834         (getInstalledWebKitDirectory): Ditto.
2835         (initializeWebKit): Call SetDllDirectory first, then load all of
2836         WebKit's dependencies manually, finally followed by WebKit itself.
2837         * WebKitInitializer/WebKitInitializer.vcproj: Added a new
2838         configuration to match our other projects.
2839         * WebKitInitializer/debug_internal.vsprops: Added.
2840
2841 2007-09-25  Adam Roben  <aroben@apple.com>
2842
2843         Actually define DEBUG/NDEBUG so that we load WebKit correctly
2844
2845         Rubberstamped by Sam.
2846
2847         * WebKitInitializer/WebKitInitializer.vcproj:
2848
2849 2007-09-25  Adam Roben  <aroben@apple.com>
2850
2851         Make DumpRenderTree delay-load its dependencies
2852
2853         This lets WebKitInitializer re-route the dependencies to be loaded out
2854         of the Safari installation directory.
2855
2856         Also replaced all uses of kCFAllocatorDefault with 0 (which means the
2857         same thing), since we can't import the kCFAllocatorDefault symbol when
2858         delay-loading CoreFoundation.dll.
2859
2860         Rubberstamped by Sam.
2861
2862         * DumpRenderTree/win/DumpRenderTree.cpp:
2863         (runTest):
2864         (javaScriptThreads):
2865         * DumpRenderTree/win/DumpRenderTree.vcproj:
2866         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2867         (LayoutTestController::setWaitToDump):
2868
2869 2007-09-25  Adam Roben  <aroben@apple.com>
2870
2871         Pull ole32.lib into WebKitInitializer
2872
2873         Rubberstamped by Sam.
2874
2875         * WebKitInitializer/WebKitInitializer.vcproj:
2876
2877 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2878
2879         Reviewed by Adam.
2880
2881         - Fix http://bugs.webkit.org/show_bug.cgi?id=14885
2882           LGPL'ed files contain incorrect FSF address
2883
2884         * Drosera/config.h:
2885
2886 2007-09-25  David Kilzer  <ddkilzer@webkit.org>
2887
2888         Reviewed by Adam.
2889
2890         Make svn-apply and svn-unapply work with git-diff formatted patches.
2891
2892         * Scripts/svn-apply: Apply a filter to the input if we find a git-diff marker before a patch.
2893         (gitdiff2svndiff): Added.
2894         * Scripts/svn-unapply: Ditto.
2895         (gitdiff2svndiff): Added.
2896
2897 2007-09-25  Adam Roben  <aroben@apple.com>
2898
2899         Pull advapi32.lib into WebKitInitializer
2900
2901         This is needed to get the registry functions we use.
2902
2903         Rubberstamped by Sam.
2904
2905         * WebKitInitializer/WebKitInitializer.vcproj:
2906
2907 2007-09-25  Adam Roben  <aroben@apple.com>
2908
2909         Add python and rsync to cygwin-downloader
2910
2911         Our build slaves need this, and it can't hurt for everyone else to
2912         have it, too.
2913
2914         Reviewed by Sam.
2915
2916         * CygwinDownloader/cygwin-downloader.py: Added python and rsync.
2917         * CygwinDownloader/cygwin-downloader.zip: Regenerated.
2918
2919 2007-09-25  Adam Roben  <aroben@apple.com>
2920
2921         Add WebKitInitializer and use it in DumpRenderTree
2922
2923         WebKitInitializer is a static library that has one function,
2924         initializeWebKit(). This registers WebKit and sets up the DLL search
2925         path so that WebKit's dependencies that are installed with Safari can
2926         be found.
2927
2928         Reviewed by Sam.
2929
2930         * DumpRenderTree/DumpRenderTree.sln: Added WebKitInitializer and made
2931         DumpRenderTree depend on it.
2932         * DumpRenderTree/win/DumpRenderTree.cpp:
2933         (initialize): Call initializeWebKit.
2934         * DumpRenderTree/win/DumpRenderTree.vcproj: Link against
2935         WebKitInitializer.lib.
2936         * WebKitInitializer/WebKitInitializer.cpp: Added.
2937         (getStringValue):
2938         (getWebViewCLSID):
2939         (getInstalledWebKitDirectory):
2940         (initializeWebKit):
2941         * WebKitInitializer/WebKitInitializer.h: Added.
2942         * WebKitInitializer/WebKitInitializer.vcproj: Added.
2943         * WebKitInitializer/debug.vsprops: Added.
2944         * WebKitInitializer/release.vsprops: Added.
2945
2946 2007-09-25  Adam Roben  <aroben@apple.com>
2947
2948         Make run-webkit-tests respect set-webkit-configuration
2949
2950         Reviewed by Sam.
2951
2952         * Scripts/run-webkit-tests: Initialize $configuration to whatever
2953         set-webkit-configuration was last set to.
2954
2955 2007-09-25  Mark Rowe  <mrowe@apple.com>
2956
2957         Rubber-stamped by Eric.
2958
2959         * BuildSlaveSupport/build-launcher-dmg: Allow the platform tag to be specified on the command line.
2960         This makes it possible to automate nightly builds for the feature-branch.
2961
2962 2007-09-25  Adam Roben  <aroben@apple.com>
2963
2964         A couple of fixes/enhancements to update-webkit-*-libs
2965
2966         You can now specify WEBKITSUPPORTLIBRARIESZIPDIR=C:\my\special\place
2967         to tell update-webkit-support-libraries where it should find the
2968         WebKitSupportLibrary.zip file you downloaded.
2969
2970         These scripts also now correctly interpret WEBKITLIBRARIESDIR as a
2971         Windows-style path.
2972
2973         Reviewed by Sam.
2974
2975         * Scripts/update-webkit-auxiliary-libs: Also renamed $supportLibsURL
2976         to $auxiliaryLibsURL and removed an irrelevant comment.
2977         * Scripts/update-webkit-support-libs:
2978
2979 2007-09-25  Adam Treat  <treat@kde.org>
2980
2981         Reviewed by Simon and Lars.
2982
2983         Refactors and cleans up Qt DRT member variable names, member variable
2984         initialization, style fixes and general code cleanup.
2985
2986         Adds queueReload slot to LayoutTestController that some tests require.
2987
2988         Subclasses QWebFrame to make sure that all frames have an associated
2989         LayoutTestController JS window object.
2990
2991         Takes advantage of new QWebFrame provisionalLoad signal to ensure frames
2992         aren't dumped twice.
2993
2994         EOF fixes.
2995
2996         Together, this patch fixes some 20+ layout tests in QtWebKit.
2997
2998         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
2999         (WebCore::WebFrame::WebFrame):
3000         (WebCore::WebPage::WebPage):
3001         (WebCore::WebPage::createFrame):
3002         (WebCore::DumpRenderTree::DumpRenderTree):
3003         (WebCore::DumpRenderTree::open):
3004         (WebCore::DumpRenderTree::readStdin):
3005         (WebCore::DumpRenderTree::initJSObjects):
3006         (WebCore::DumpRenderTree::dump):
3007         * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
3008         (WebCore::DumpRenderTree::layoutTestController):
3009         (WebCore::DumpRenderTree::eventSender):
3010         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.cpp:
3011         (LayoutTestController::LayoutTestController):
3012         (LayoutTestController::reset):
3013         (LayoutTestController::maybeDump):
3014         (LayoutTestController::waitUntilDone):
3015         (LayoutTestController::notifyDone):
3016         (LayoutTestController::queueReload):
3017         (LayoutTestController::provisionalLoad):
3018         (EventSender::EventSender):
3019         (EventSender::mouseDown):
3020         (EventSender::mouseUp):
3021         (EventSender::mouseMoveTo):
3022         (EventSender::frameUnderMouse):
3023         * DumpRenderTree/DumpRenderTree.qtproj/jsobjects.h:
3024         (LayoutTestController::isLoading):
3025         (LayoutTestController::setLoading):
3026         (LayoutTestController::dumpAsText):
3027         * DumpRenderTree/DumpRenderTree.qtproj/main.cpp:
3028         (main):
3029
3030 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3031
3032
3033         - Reverted an accidentally checked in file.
3034
3035         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
3036
3037 2007-09-24  Kevin McCullough  <kmccullough@apple.com>
3038         Reviewed by Sam.
3039
3040         - Updated project files to not use Edit and Continue for Debug Information since it doesn't work and breaks some functionality.
3041
3042         * DumpRenderTree/win/DumpRenderTree.vcproj:
3043         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3044
3045 2007-09-20  Holger Hans Peter Freyther  <zecke@selfish.org>
3046
3047         Rubber stamped by Adam.
3048
3049         * GdkLauncher: Removed.
3050         * GdkLauncher/Bakefiles.bkgen: Removed.
3051         * GdkLauncher/ENV: Removed.
3052         * GdkLauncher/GdkLauncher.pro: Removed.
3053         * GdkLauncher/gdklauncher.bkl: Removed.
3054         * GdkLauncher/main.cpp: Removed.
3055         * GdkLauncher/mk: Removed.
3056         * GdkLauncher/simple.svg: Removed.
3057         * GdkLauncher/text.html: Removed.
3058         * GtkLauncher: Added.
3059         * GtkLauncher/GdkLauncher.pro: Removed.
3060         * GtkLauncher/GtkLauncher.pro: Added.
3061         * GtkLauncher/main.cpp:
3062         (updateWindowTitle):
3063         (main):
3064         * Scripts/build-webkit:
3065         * Scripts/regenerate-makefiles:
3066         * Scripts/run-javascriptcore-tests:
3067         * Scripts/run-launcher:
3068         * Scripts/run-webkit-tests:
3069         * Scripts/webkitdirs.pm:
3070
3071 2007-09-21  Timothy Hatcher  <timothy@apple.com>
3072
3073         Reviewed by Darin.
3074
3075         <rdar://problem/5491013> REGRESSION: -[WebView windowScriptObject] returns a dummy object or nil if a page hasn't loaded (breaks EA Sports Online)
3076
3077         Assert that the -[WebScriptObject JSObject] return value is only NULL for non-window objects.
3078         This is tested by plugins/root-object-premature-delete-crash.html.
3079
3080         * DumpRenderTree/mac/ObjCController.m:
3081         (-[ObjCController accessStoredWebScriptObject]):
3082
3083 2007-09-21  Kevin McCullough  <kmccullough@apple.com>
3084
3085         Reviewed by Oliver.
3086
3087         - We need to initialize the ref count to 1 at initialization so that objects are not garbage collected. (actual patch written by Oliver)
3088
3089         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
3090         (FrameLoadDelegate::FrameLoadDelegate):
3091
3092 2007-09-20  Julien Chaffraix  <julien.chaffraix@gmail.com>
3093
3094         Reviewed by Adam.
3095
3096         Fix: http://bugs.webkit.org/show_bug.cgi?id=15223
3097         webkitdir.pm::isQt() is not working properly in run-webkit-tests under Linux/Qt
3098
3099         Added determineIsQt() and determineIsGdk() to webkitdirs.pm.
3100         Now isQt() and isGdk() use global variables that are only set once.
3101
3102         An array of all the parameters is now given to build-dumprender which includes
3103         the platform on linux.
3104
3105         * Scripts/build-dumprendertree:
3106         * Scripts/run-webkit-tests:
3107         * Scripts/webkitdirs.pm:
3108
3109 2007-09-19  Adam Roben  <aroben@apple.com>
3110
3111         Rubberstamped by Hyatt.
3112
3113         * Spinneret: Removed.
3114
3115 2007-09-19  Tuukka Hastrup  <Tuukka.Hastrup@iki.fi>
3116
3117         Reviewed by David Kilzer.
3118
3119         * Scripts/webkitdirs.pm: On Gdk and Qt, check that flex, bison, gperf are available.
3120
3121 2007-09-18  Sam Weinig  <sam@webkit.org>
3122
3123         Add JSRetainPtr.h #include to fix some builds.
3124
3125         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3126
3127 2007-09-18  Mike Hommey  <glandium@debian.org>
3128
3129         Reviewed by Adam.
3130
3131         * Scripts/prepare-ChangeLog:
3132         - Properly parse GECOS field.
3133         - Use git configuration for user name and email when appropriate.
3134
3135 2007-09-17  Sam Weinig  <sam@webkit.org>
3136
3137         Build fix.
3138
3139         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3140
3141 2007-09-17  Sam Weinig  <sam@webkit.org>
3142
3143         Reviewed by Adam Roben.
3144
3145         Share more code between mac and windows DRT.
3146             - GCController is now shared.
3147             - Rename WaitUntilDoneDelegate to FrameLoadDelegate for consistency.
3148
3149         * DumpRenderTree/GCController.cpp:
3150         * DumpRenderTree/win/DumpRenderTree.cpp:
3151         * DumpRenderTree/win/DumpRenderTree.vcproj:
3152         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.cpp.
3153         (FrameLoadDelegate::FrameLoadDelegate):
3154         (FrameLoadDelegate::~FrameLoadDelegate):
3155         (FrameLoadDelegate::windowScriptObjectAvailable):
3156         * DumpRenderTree/win/FrameLoaderDelegate.h: Copied from DumpRenderTree/win/WaitUntilDoneDelegate.h.
3157         * DumpRenderTree/win/GCController.cpp: Removed.
3158         * DumpRenderTree/win/GCController.h: Removed.
3159         * DumpRenderTree/win/GCControllerWin.cpp: Copied from DumpRenderTree/win/GCController.cpp.
3160         (GCController::collect):
3161         (GCController::collectOnAlternateThread):
3162         (GCController::getJSObjectCount):
3163         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Removed.
3164         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Removed.
3165
3166 2007-09-17  Sam Weinig  <sam@webkit.org>
3167
3168         Reviewed by Adam Roben.
3169
3170         Begin sharing code between mac and windows DRT.
3171             - both now share LayoutTestController.h/cpp and implement platform dependant 
3172               operations in LayoutTestControllerMac/Win.
3173             - DumpRenderTree.h is now shared.
3174             - WorkQueue and WorkQueueItem are also shared.
3175
3176         * DumpRenderTree/DumpRenderTree.h:
3177         * DumpRenderTree/LayoutTestController.cpp:
3178         * DumpRenderTree/win/DumpRenderTree.cpp:
3179         (displayWebView):
3180         (dumpFrameScrollPosition):
3181         (dumpFramesAsText):
3182         (dump):
3183         (runTest):
3184         * DumpRenderTree/win/DumpRenderTree.h: Removed.
3185         * DumpRenderTree/win/DumpRenderTree.vcproj:
3186         * DumpRenderTree/win/DumpRenderTreeWin.h: Copied from DumpRenderTree/win/DumpRenderTree.h.
3187         * DumpRenderTree/win/EditingDelegate.cpp:
3188         (EditingDelegate::shouldBeginEditingInDOMRange):
3189         (EditingDelegate::shouldEndEditingInDOMRange):
3190         (EditingDelegate::shouldInsertNode):
3191         (EditingDelegate::shouldInsertText):
3192         (EditingDelegate::shouldDeleteDOMRange):
3193         (EditingDelegate::shouldChangeSelectedDOMRange):
3194         (EditingDelegate::shouldApplyStyle):
3195         (EditingDelegate::shouldChangeTypingStyle):
3196         (EditingDelegate::doPlatformCommand):
3197         (EditingDelegate::webViewDidBeginEditing):
3198         (EditingDelegate::webViewDidChange):
3199         (EditingDelegate::webViewDidEndEditing):
3200         (EditingDelegate::webViewDidChangeTypingStyle):
3201         (EditingDelegate::webViewDidChangeSelection):
3202         * DumpRenderTree/win/LayoutTestController.cpp: Removed.
3203         * DumpRenderTree/win/LayoutTestController.h: Removed.
3204         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Copied from DumpRenderTree/win/LayoutTestController.cpp.
3205         (LayoutTestController::addDisallowedURL):
3206         (LayoutTestController::clearBackForwardList):
3207         (LayoutTestController::copyDecodedHostName):
3208         (LayoutTestController::copyEncodedHostName):
3209         (LayoutTestController::display):
3210         (LayoutTestController::keepWebHistory):
3211         (LayoutTestController::notifyDone):
3212         (LayoutTestController::queueBackNavigation):
3213         (LayoutTestController::queueForwardNavigation):
3214         (jsStringRefToWString):
3215         (LayoutTestController::queueLoad):
3216         (LayoutTestController::queueReload):
3217         (LayoutTestController::queueScript):
3218         (LayoutTestController::setAcceptsEditing):
3219         (LayoutTestController::setCustomPolicyDelegate):
3220         (LayoutTestController::setMainFrameIsFirstResponder):
3221         (LayoutTestController::setTabKeyCyclesThroughElements):
3222         (LayoutTestController::setUseDashboardCompatibilityMode):
3223         (LayoutTestController::setUserStyleSheetEnabled):
3224         (LayoutTestController::setUserStyleSheetLocation):
3225         (LayoutTestController::setWindowIsKey):
3226         (waitUntilDoneWatchdogFired):
3227         (LayoutTestController::setWaitToDump):
3228         (LayoutTestController::windowCount):
3229         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp:
3230         (FrameLoadDelegate::didReceiveTitle):
3231         (FrameLoadDelegate::processWork):
3232         (FrameLoadDelegate::locationChangeDone):
3233         (FrameLoadDelegate::windowScriptObjectAvailable):
3234         * DumpRenderTree/win/WorkQueue.cpp: Removed.
3235         * DumpRenderTree/win/WorkQueue.h: Removed.
3236         * DumpRenderTree/win/WorkQueueItem.cpp: Removed.
3237         * DumpRenderTree/win/WorkQueueItem.h: Removed.
3238         * DumpRenderTree/win/WorkQueueItemWin.cpp: Copied from DumpRenderTree/win/WorkQueueItem.cpp.
3239         (jsStringRefToWString):
3240         (LoadItem::invoke):
3241         (ScriptItem::invoke):
3242
3243 2007-09-17  Sam Weinig  <sam@webkit.org>
3244
3245         Reviewed by Adam Roben.
3246
3247         - Move Windows DumpRenderTree and TestNetscapePlugin to WebCoreTools/DumpRenderTree/win
3248
3249         * DumpRenderTree/DumpRenderTree.sln: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln.
3250         * DumpRenderTree/DumpRenderTree.vcproj: Removed.
3251         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Removed.
3252         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Removed.
3253         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h: Removed.
3254         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Removed.
3255         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h: Removed.
3256         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Removed.
3257         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp: Removed.
3258         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h: Removed.
3259         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp: Removed.
3260         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h: Removed.
3261         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp: Removed.
3262         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h: Removed.
3263         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: Removed.
3264         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h: Removed.
3265         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Removed.
3266         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Removed.
3267         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp: Removed.
3268         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Removed.
3269         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp: Removed.
3270         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h: Removed.
3271         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp: Removed.
3272         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h: Removed.
3273         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops: Removed.
3274         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops: Removed.
3275         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops: Removed.
3276         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin: Removed.
3277         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
3278         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
3279         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: Removed.
3280         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/main.c: Removed.
3281         * DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/resource.h: Removed.
3282         * DumpRenderTree/win: Added.
3283         * DumpRenderTree/win/DraggingInfo.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DraggingInfo.h.
3284         * DumpRenderTree/win/DumpRenderTree.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp.
3285         * DumpRenderTree/win/DumpRenderTree.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h.
3286         * DumpRenderTree/win/DumpRenderTree.vcproj: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj.
3287         * DumpRenderTree/win/EditingDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.cpp.
3288         * DumpRenderTree/win/EditingDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EditingDelegate.h.
3289         * DumpRenderTree/win/EventSender.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.cpp.
3290         * DumpRenderTree/win/EventSender.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/EventSender.h.
3291         * DumpRenderTree/win/GCController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.cpp.
3292         * DumpRenderTree/win/GCController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/GCController.h.
3293         * DumpRenderTree/win/LayoutTestController.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp.
3294         * DumpRenderTree/win/LayoutTestController.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h.
3295         * DumpRenderTree/win/TestNetscapePlugin: Copied from DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin.
3296         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3297         * DumpRenderTree/win/UIDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp.
3298         * DumpRenderTree/win/UIDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h.
3299         * DumpRenderTree/win/WaitUntilDoneDelegate.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp.
3300         * DumpRenderTree/win/WaitUntilDoneDelegate.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h.
3301         * DumpRenderTree/win/WorkQueue.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.cpp.
3302         * DumpRenderTree/win/WorkQueue.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueue.h.
3303         * DumpRenderTree/win/WorkQueueItem.cpp: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.cpp.
3304         * DumpRenderTree/win/WorkQueueItem.h: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WorkQueueItem.h.
3305         * DumpRenderTree/win/debug.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug.vsprops.
3306         * DumpRenderTree/win/debug_internal.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/debug_internal.vsprops.
3307         * DumpRenderTree/win/release.vsprops: Copied from DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/release.vsprops.
3308         * Scripts/run-webkit-tests: Update to point to the new location of the sln.
3309
3310 2007-09-15  Mark Rowe  <mrowe@apple.com>
3311
3312         Build fix for DumpRenderTree.
3313
3314         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Reinstate -Wno-deprecated-declarations on DumpRenderTree.mm.
3315
3316 2007-09-14  Sam Weinig  <sam@webkit.org>
3317
3318         Rubber stamped by Adam Roben.
3319
3320         Split the WaitUntilDoneDelegate into a UIDelegate and a FrameLoadDelegate.
3321           - The UIDelegate was put into a new file while the FrameLoadDelegate was
3322             kept in the WaitUntilDoneDelegate file for the time being.
3323
3324         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp:
3325         (main):
3326         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
3327         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.cpp: Added.
3328         (UIDelegate::QueryInterface):
3329         (UIDelegate::AddRef):
3330         (UIDelegate::Release):
3331         (UIDelegate::hasCustomMenuImplementation):
3332         (UIDelegate::setFrame):
3333         (UIDelegate::webViewFrame):
3334         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3335         (UIDelegate::webViewAddMessageToConsole):
3336         (UIDelegate::doDragDrop):
3337         (UIDelegate::webViewGetDlgCode):
3338         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/UIDelegate.h: Added.
3339         (UIDelegate::UIDelegate):
3340         (UIDelegate::createWebViewWithRequest):
3341         (UIDelegate::webViewShow):
3342         (UIDelegate::webViewClose):
3343         (UIDelegate::webViewFocus):
3344         (UIDelegate::webViewUnfocus):
3345         (UIDelegate::webViewFirstResponder):
3346         (UIDelegate::makeFirstResponder):
3347         (UIDelegate::setStatusText):
3348         (UIDelegate::webViewStatusText):
3349         (UIDelegate::webViewAreToolbarsVisible):
3350         (UIDelegate::setToolbarsVisible):
3351         (UIDelegate::webViewIsStatusBarVisible):
3352         (UIDelegate::setStatusBarVisible):
3353         (UIDelegate::webViewIsResizable):
3354         (UIDelegate::setResizable):
3355         (UIDelegate::setContentRect):
3356         (UIDelegate::webViewContentRect):
3357         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3358         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3359         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3360         (UIDelegate::runOpenPanelForFileButtonWithResultListener):
3361         (UIDelegate::mouseDidMoveOverElement):
3362         (UIDelegate::contextMenuItemsForElement):
3363         (UIDelegate::validateUserInterfaceItem):
3364         (UIDelegate::shouldPerformAction):
3365         (UIDelegate::dragDestinationActionMaskForDraggingInfo):
3366         (UIDelegate::willPerformDragDestinationAction):
3367         (UIDelegate::dragSourceActionMaskForPoint):
3368         (UIDelegate::willPerformDragSourceAction):
3369         (UIDelegate::contextMenuItemSelected):
3370         (UIDelegate::trackCustomPopupMenu):
3371         (UIDelegate::measureCustomMenuItem):
3372         (UIDelegate::drawCustomMenuItem):
3373         (UIDelegate::addCustomMenuDrawingData):
3374         (UIDelegate::cleanUpCustomMenuDrawingData):
3375         (UIDelegate::canTakeFocus):
3376         (UIDelegate::takeFocus):
3377         (UIDelegate::registerUndoWithTarget):
3378         (UIDelegate::removeAllActionsWithTarget):
3379         (UIDelegate::setActionTitle):
3380         (UIDelegate::undo):
3381         (UIDelegate::redo):
3382         (UIDelegate::canUndo):
3383         (UIDelegate::canRedo):
3384         (UIDelegate::webViewResizerRect):
3385         (UIDelegate::webViewDrawResizer):
3386         (UIDelegate::webViewScrolled):
3387         (UIDelegate::webViewShouldInterruptJavaScript):
3388         (UIDelegate::webViewReceivedFocus):
3389         (UIDelegate::webViewLostFocus):
3390         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
3391         (FrameLoadDelegate::QueryInterface):
3392         (FrameLoadDelegate::AddRef):
3393         (FrameLoadDelegate::Release):
3394         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
3395         (FrameLoadDelegate::didCommitLoadForFrame):
3396         (FrameLoadDelegate::didReceiveTitle):
3397         (FrameLoadDelegate::processWork):
3398         (processWorkTimer):
3399         (FrameLoadDelegate::locationChangeDone):
3400         (FrameLoadDelegate::didFinishLoadForFrame):
3401         (FrameLoadDelegate::didFailLoadWithError):
3402         (FrameLoadDelegate::windowScriptObjectAvailable):
3403         * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h:
3404         (FrameLoadDelegate::FrameLoadDelegate):
3405
3406 2007-09-14  Sam Weinig  <sam@webkit.org>
3407
3408         Reviewed by Kevin McCullough.
3409
3410         Move mac specific globals in to mac/DumpRenderTreeMac.h
3411
3412         * DumpRenderTree/DumpRenderTree.h:
3413         * DumpRenderTree/DumpRenderTree.mm: Removed.
3414         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3415         * DumpRenderTree/mac/DumpRenderTree.mm: Copied from DumpRenderTree/DumpRenderTree.mm.
3416         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added.
3417
3418 2007-09-14  Brady Eidson  <beidson@apple.com>
3419
3420         Rubberstamped by Weinig
3421
3422         You know, Sam, some of us use case-sensitve filesystems...
3423
3424         * DumpRenderTree/DumpRenderTree.h:
3425         * DumpRenderTree/mac/UIDelegate.mm:
3426
3427 2007-09-14  Sam Weinig  <sam@webkit.org>
3428
3429         Rubber stamped by Adam Roben.
3430
3431         - Move dump state data to LayoutTestContoller and add getter/setters to accommodate.
3432         - Move mac specific DumpRenderTree files to DumpRenderTree/mac
3433
3434         * DumpRenderTree/AppleScriptController.h: Removed.
3435         * DumpRenderTree/AppleScriptController.m: Removed.
3436         * DumpRenderTree/DumpRenderTree.h:
3437         * DumpRenderTree/DumpRenderTree.mm:
3438         (startJavaScriptThreads):
3439         (stopJavaScriptThreads):
3440         (activateAhemFont):
3441         (setDefaultColorProfileToRGB):
3442         (makeLargeMallocFailSilently):
3443         (dumpFrameScrollPosition):
3444         (dumpFramesAsText):
3445         (dump):
3446         (runTest):
3447         (-[DumpRenderTreeWindow isKeyWindow]):
3448         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3449         * DumpRenderTree/DumpRenderTreeDraggingInfo.h: Removed.
3450         * DumpRenderTree/DumpRenderTreeDraggingInfo.m: Removed.
3451         * DumpRenderTree/EditingDelegate.h: Removed.
3452         * DumpRenderTree/EditingDelegate.m: Removed.
3453         * DumpRenderTree/EventSendingController.h: Removed.
3454         * DumpRenderTree/EventSendingController.m: Removed.
3455         * DumpRenderTree/FrameLoadDelegate.h: Removed.
3456         * DumpRenderTree/FrameLoadDelegate.mm: Removed.
3457         * DumpRenderTree/GCController.mm: Removed.
3458         * DumpRenderTree/ImageDiff.m: Removed.
3459         * DumpRenderTree/LayoutTestController.cpp:
3460         (LayoutTestController::LayoutTestController):
3461         (dumpAsTextCallback):
3462         (dumpBackForwardListCallback):
3463         (dumpChildFramesAsTextCallback):
3464         (dumpChildFrameScrollPositionsCallback):
3465         (dumpDOMAsWebArchiveCallback):
3466         (dumpEditingCallbacksCallback):
3467         (dumpFrameLoadCallbacksCallback):
3468         (dumpResourceLoadCallbacksCallback):
3469         (dumpSelectionRectCallback):
3470         (dumpSourceAsWebArchiveCallback):
3471         (dumpTitleChangesCallback):
3472         (repaintSweepHorizontallyCallback):
3473         (setCallCloseOnWebViewsCallback):
3474         (setCanOpenWindowsCallback):
3475         (setCloseRemainingWindowsWhenCompleteCallback):
3476         (testRepaintCallback):
3477         (addFileToPasteboardOnDragCallback):
3478         (waitUntilDoneCallback):
3479         * DumpRenderTree/LayoutTestController.h:
3480         (LayoutTestController::dumpAsText):
3481         (LayoutTestController::setDumpAsText):
3482         (LayoutTestController::dumpBackForwardList):
3483         (LayoutTestController::setDumpBackForwardList):
3484         (LayoutTestController::dumpChildFrameScrollPositions):
3485         (LayoutTestController::setDumpChildFrameScrollPositions):
3486         (LayoutTestController::dumpChildFramesAsText):
3487         (LayoutTestController::setDumpChildFramesAsText):
3488         (LayoutTestController::dumpDOMAsWebArchive):
3489         (LayoutTestController::setDumpDOMAsWebArchive):
3490         (LayoutTestController::dumpSelectionRect):
3491         (LayoutTestController::setDumpSelectionRect):
3492         (LayoutTestController::dumpSourceAsWebArchive):
3493         (LayoutTestController::setDumpSourceAsWebArchive):
3494         (LayoutTestController::dumpTitleChanges):
3495         (LayoutTestController::setDumpTitleChanges):
3496         (LayoutTestController::dumpEditingCallbacks):
3497         (LayoutTestController::setDumpEditingCallbacks):
3498         (LayoutTestController::dumpResourceLoadCallbacks):
3499         (LayoutTestController::setDumpResourceLoadCallbacks):
3500         (LayoutTestController::dumpFrameLoadCallbacks):
3501         (LayoutTestController::setDumpFrameLoadCallbacks):
3502         (LayoutTestController::addFileToPasteboardOnDrag):
3503         (LayoutTestController::setAddFileToPasteboardOnDrag):
3504         (LayoutTestController::callCloseOnWebViews):
3505         (LayoutTestController::setCallCloseOnWebViews):
3506         (LayoutTestController::canOpenWindows):
3507         (LayoutTestController::setCanOpenWindows):
3508         (LayoutTestController::closeRemainingWindowsWhenComplete):
3509         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3510         (LayoutTestController::testRepaint):
3511         (LayoutTestController::setTestRepaint):
3512         (LayoutTestController::testRepaintSweepHorizontally):
3513         (LayoutTestController::setTestRepaintSweepHorizontally):
3514         (LayoutTestController::waitToDump):
3515         (LayoutTestController::windowIsKey):
3516         * DumpRenderTree/LayoutTestControllerMac.mm: Removed.
3517         * DumpRenderTree/NavigationController.h: Removed.
3518         * DumpRenderTree/NavigationController.m: Removed.
3519         * DumpRenderTree/ObjCController.h: Removed.
3520         * DumpRenderTree/ObjCController.m: Removed.
3521         * DumpRenderTree/ObjCPlugin.h: Removed.
3522         * DumpRenderTree/ObjCPlugin.m: Removed.
3523         * DumpRenderTree/ObjCPluginFunction.h: Removed.
3524         * DumpRenderTree/ObjCPluginFunction.m: Removed.
3525         * DumpRenderTree/PolicyDelegate.h: Removed.
3526         * DumpRenderTree/PolicyDelegate.m: Removed.
3527         * DumpRenderTree/ResourceLoadDelegate.h: Removed.
3528         * DumpRenderTree/ResourceLoadDelegate.m: Removed.
3529         * DumpRenderTree/TextInputController.h: Removed.
3530         * DumpRenderTree/TextInputController.m: Removed.
3531         * DumpRenderTree/UIDelegate.h: Removed.
3532         * DumpRenderTree/UIDelegate.mm: Removed.
3533         * DumpRenderTree/WorkQueueItemMac.mm: Removed.
3534         * DumpRenderTree/mac: Added.
3535         * DumpRenderTree/mac/AppleScriptController.h: Copied from DumpRenderTree/AppleScriptController.h.
3536         * DumpRenderTree/mac/AppleScriptController.m: Copied from DumpRenderTree/AppleScriptController.m.
3537         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.h.
3538         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm: Copied from DumpRenderTree/DumpRenderTreeDraggingInfo.m.
3539         * DumpRenderTree/mac/EditingDelegate.h: Copied from DumpRenderTree/EditingDelegate.h.
3540         * DumpRenderTree/mac/EditingDelegate.mm: Copied from DumpRenderTree/EditingDelegate.m.
3541         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3542         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3543         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3544         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3545         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3546         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3547         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3548         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3549         (-[EditingDelegate webViewDidBeginEditing:]):
3550         (-[EditingDelegate webViewDidChange:]):
3551         (-[EditingDelegate webViewDidEndEditing:]):
3552         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3553         (-[EditingDelegate webViewDidChangeSelection:]):
3554         * DumpRenderTree/mac/EventSendingController.h: Copied from DumpRenderTree/EventSendingController.h.
3555         * DumpRenderTree/mac/EventSendingController.mm: Copied from DumpRenderTree/EventSendingController.m.
3556         * DumpRenderTree/mac/FrameLoadDelegate.h: Copied from DumpRenderTree/FrameLoadDelegate.h.
3557         * DumpRenderTree/mac/FrameLoadDelegate.mm: Copied from DumpRenderTree/FrameLoadDelegate.mm.
3558         (-[FrameLoadDelegate init]):
3559         (-[FrameLoadDelegate dealloc]):
3560         (-[FrameLoadDelegate processWork:]):
3561         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
3562         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3563         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3564         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3565         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3566         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3567         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3568         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):