48258d7695a181213c52059490f5f0558976816a
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-01-13  Dmitry Titov  <dimich@chromium.org>
2
3         Reviewed by David Kilzer.
4
5         https://bugs.webkit.org/show_bug.cgi?id=23304
6         Fix svn-apply to match svn-unapply to recognize added files in 'git diff' patches.
7
8         * Scripts/svn-apply: Added a check (similar to svn-unapply) to recognize added files.
9
10 2009-01-14  David Kilzer  <ddkilzer@apple.com>
11
12         BUILD FIX: Implement LayoutTestController::setIconDatabaseEnabled(bool) for GTK
13
14         * DumpRenderTree/gtk/DumpRenderTree.cpp:
15         (runTest): Added call to reset the icon database to match Mac
16         and Windows ports.
17         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
18         (LayoutTestController::setIconDatabaseEnabled): Implemented
19         stub method.
20
21 2009-01-14  David Kilzer  <ddkilzer@apple.com>
22
23         Bug 22795: favicons should be saved to webarchives
24
25         <https://bugs.webkit.org/show_bug.cgi?id=22795>
26
27         Reviewed by Darin Adler.
28
29         * DumpRenderTree/LayoutTestController.cpp:
30         (setIconDatabaseEnabledCallback): Added.
31         (setJavaScriptProfilingEnabledCallback): Realphabetized.
32         (LayoutTestController::staticFunctions): Added entry for calling
33         LayoutTestController.setIconDatabaseEnabled(bool) from JavaScript.
34         * DumpRenderTree/LayoutTestController.h:
35         (setIconDatabaseEnabledCallback): Added declaration.
36         (setJavaScriptProfilingEnabledCallback): Realphabetized.
37
38         * DumpRenderTree/mac/DumpRenderTree.mm:
39         (runTest): Disable the icon database before each test.
40         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
41         (LayoutTestController::setIconDatabaseEnabled): Added.
42         (LayoutTestController::setJavaScriptProfilingEnabled): Realphabetized.
43
44         * DumpRenderTree/win/DumpRenderTree.cpp:
45         (runTest): Disable the icon database before each test.
46         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
47         (LayoutTestController::setIconDatabaseEnabled): Added.
48
49 2009-01-14  Steve Falkenburg  <sfalken@apple.com>
50
51         Update copyright year in version resources.
52
53         Reviewed by Adam Roben.
54
55         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
56
57 2009-01-14  Dan Bernstein  <mitz@apple.com>
58
59         Reviewed by John Sullivan.
60
61         - update copyright
62
63         * DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist:
64         * WebKitLauncher/Info.plist:
65
66 2009-01-13  Anders Carlsson  <andersca@apple.com>
67
68         Reviewed by Sam Weinig.
69
70         Add NPRuntime test.
71
72         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
73         (testNPRuntime):
74         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
75         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
76         (NPP_New):
77         (NPP_GetValue):
78
79 2009-01-12  Mark Rowe  <mrowe@apple.com>
80
81         Use the modern spelling of WebKit.
82
83         * Scripts/find-extra-includes:
84         * Scripts/report-include-statistics:
85         * Scripts/run-webkit-app:
86         * Scripts/svn-unapply:
87         * Scripts/update-webkit:
88
89 2009-01-11  Darin Adler  <darin@apple.com>
90
91         * Scripts/make-js-test-wrappers: Updated so it won't overwrite tests in the svg/dom
92         directory that aren't using standard wrappers.
93
94 2009-01-11  Robert Blaut  <webkit@blaut.biz>
95
96         Reviewed by Eric Seidel.
97         
98         <https://bugs.webkit.org/show_bug.cgi?id=23134>
99         Update bisect-builds for Safari 3.2 to prevent crashes
100
101         * Scripts/bisect-builds: Added Safari 3.2 and the corresponding minimal revision, r37348.
102
103 2009-01-08  Adam Treat  <adam.treat@torchmobile.com>
104
105         Reviewed by Simon Hausmann.
106
107         Explicitly set these so that the layout tests do not break.
108
109         * DumpRenderTree/qt/DumpRenderTree.cpp:
110         (WebCore::WebPage::WebPage):
111
112 2009-01-07  Glenn Wilson  <gwilson@chromium.org>
113
114         Reviewed by Eric Seidel.
115
116         Changed DumpRenderTree to re-enable Javascript in web preferences on every test.
117         This fixes the case when a user mistakenly disables Javascript, and all layout tests crash.
118
119         * DumpRenderTree/mac/DumpRenderTree.mm:
120         (testStringByEvaluatingJavaScriptFromString):
121         (setDefaultsToConsistentValuesForTesting):
122
123 2009-01-07  Holger Hans Peter Freyther  <zecke@selfish.org>
124
125         Reviewed by Maciej Stachowiak.
126
127         Implement numberOfActiveAnimations to fix the build
128
129         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
130         (LayoutTestController::numberOfActiveAnimations):
131
132 2009-01-07  Adam Treat  <adam.treat@torchmobile.com>
133
134         Reviewed by George Staikos.
135
136         Fix unused variable warnings
137
138         * DumpRenderTree/qt/DumpRenderTree.cpp:
139         (WebCore::WebPage::javaScriptAlert):
140         (WebCore::WebPage::javaScriptConfirm):
141         (WebCore::WebPage::javaScriptPrompt):
142         * DumpRenderTree/qt/jsobjects.cpp:
143         (LayoutTestController::maybeDump):
144         * DumpRenderTree/qt/main.cpp:
145         (get_backtrace):
146         * DumpRenderTree/qt/testplugin.cpp:
147         (TestPlugin::create):
148
149 2009-01-06  Pierre-Olivier Latour  <pol@apple.com>
150
151         Reviewed by Darin Adler.
152
153         Added new JS API numberOfActiveAnimations() that returns the number of active CSS transitions & animations.
154         This effectively exposes the new AnimationController::numberOfActiveAnimations() API from WebCore.
155
156         https://bugs.webkit.org/show_bug.cgi?id=23126
157
158         * DumpRenderTree/LayoutTestController.cpp:
159         (numberOfActiveAnimationsCallback):
160         (LayoutTestController::staticFunctions):
161         * DumpRenderTree/LayoutTestController.h:
162         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
163         (LayoutTestController::numberOfActiveAnimations):
164         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
165         (LayoutTestController::numberOfActiveAnimations):
166
167 2009-01-04  David Kilzer  <ddkilzer@apple.com>
168
169         Don't install internal headers in WebKit framework
170
171         Reviewed by Darin Adler.
172
173         Since WebHTMLRepresentationInternal.h and WebTypesInternal.h are
174         no longer installed in WebKit.framework/PrivateHeaders, use the
175         special relationship of DumpRenderTree within the WebKit source
176         tree to include the internal headers through relative paths.
177         Created the concept of mac/InternalHeaders to hide the ugly
178         paths.
179
180         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added
181         mac/InternalHeaders to HEADER_SEARCH_PATHS.
182         * DumpRenderTree/mac/InternalHeaders/WebKit/WebHTMLRepresentationInternal.h: Added.
183         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h: Added.
184
185 2009-01-02  Adam Treat  <treat@kde.org>
186
187         Reviewed by George Staikos.
188
189         Add support for fixedLayoutSize to the qt DRT
190
191         * DumpRenderTree/qt/jsobjects.cpp:
192         (LayoutTestController::setFixedLayoutSize):
193         (LayoutTestController::setUseFixedLayout):
194         * DumpRenderTree/qt/jsobjects.h:
195
196 2009-01-03  David D. Kilzer  <ddkilzer@webkit.org>
197
198         Bug 23091: Some webarchive http tests intermittently fail due to Connection/Keep-Alive header differences
199
200         <https://bugs.webkit.org/show_bug.cgi?id=23091>
201
202         Reviewed by Darin Adler.
203
204         * DumpRenderTree/mac/DumpRenderTree.mm:
205         (normalizeHTTPResponseHeaderFields): Remove Keep-Alive and
206         Connection headers from webarchive results.
207
208 2008-12-31  Zan Dobersek  <zandobersek@gmail.com>
209
210         Reviewed by Holger Freyther.
211
212         https://bugs.webkit.org/show_bug.cgi?id=22812
213
214         Prevent TestNetscapePlugin from installing system-wide.
215
216         * GNUmakefile.am:
217
218 2008-12-31  Zan Dobersek  <zandobersek@gmail.com>
219
220         Reviewed by Holger Freyther.
221
222         https://bugs.webkit.org/show_bug.cgi?id=22842
223
224         Move WebKitWebView's size allocation into a proper place.
225
226         * DumpRenderTree/gtk/DumpRenderTree.cpp:
227         (dump):
228         (runTest):
229
230 2008-12-24  Mark Rowe  <mrowe@apple.com>
231
232         Reviewed by Timothy Hatcher.
233
234         Move the guts of determineCurrentSVNRevision to VCSUtils as svnRevisionForDirectory,
235         and make it work for git too.
236
237         * Scripts/VCSUtils.pm:
238         * Scripts/webkitdirs.pm:
239
240 2008-12-22  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
241
242         Reviewed by George Staikos.
243
244         Ignore http/tests/wml, if no WML support is present.
245         Add http/tests/wml to list of HTTP tests, allowed to access local resources.
246
247         * Scripts/run-webkit-tests:
248
249 2008-12-19  David Levin  <levin@chromium.org>
250
251         Reviewed by Mark Rowe.
252
253         https://bugs.webkit.org/show_bug.cgi?id=22930
254
255         Make the git diff command used for preparing the change log avoid using any external diff tools.
256
257         * Scripts/prepare-ChangeLog:
258
259 2008-12-19  Gustavo Noronha Silva  <gns@gnome.org>
260
261         Reviewed by Holger Freyther.
262
263         https://bugs.webkit.org/show_bug.cgi?id=22686
264
265         Added files which were missing from the TestNetscapePlugin
266         directory to the SOURCES variable, so that they will be
267         distributed in a make dist.
268
269         * GNUMakefile.am:
270
271 2008-12-18  Cameron Zwarich  <zwarich@apple.com>
272
273         Reviewed by Geoff Garen.
274
275         Add tests for bug 21855: REGRESSION (r37323): Gmail complains about popup blocking when opening a link
276         <https://bugs.webkit.org/show_bug.cgi?id=21855>
277         <rdar://problem/6278244>
278
279         Add support for scheduling asynchronous clicks to DumpRenderTree, but
280         only on the Mac.
281
282         * DumpRenderTree/mac/EventSendingController.h:
283         * DumpRenderTree/mac/EventSendingController.mm:
284         (+[EventSendingController isSelectorExcludedFromWebScript:]): Expose
285         scheduleAsynchronousClick to JavaScript.
286         (-[EventSendingController scheduleAsynchronousClick]): Add.
287
288 2008-12-15  Darin Adler  <darin@apple.com>
289
290         * Scripts/make-js-test-wrappers: Added another exception to avoid overwriting
291         a custom-written test.
292
293 2008-12-15  Simon Hausmann  <hausmann@webkit.org>
294
295         Reviewed by Holger Freyther.
296
297         Implement setJavaScriptProfilingEnabled in the Qt DRT to pass fast/profiler.
298
299         * DumpRenderTree/qt/jsobjects.cpp:
300         (LayoutTestController::setJavaScriptProfilingEnabled):
301         * DumpRenderTree/qt/jsobjects.h:
302
303 2008-12-13  Zan Dobersek  <zandobersek@gmail.com>
304
305         Reviewed by Darin Adler.
306
307         https://bugs.webkit.org/show_bug.cgi?id=22039
308
309         Implement animation and transition pausing.
310
311         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
312         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
313         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
314
315 2008-12-12  Brent Fulgham  <bfulgham@gmail.com>
316
317         Reviewed by Adam Roben.
318
319         https://bugs.webkit.org/show_bug.cgi?id=22809
320
321         Increase timeout in call to initWithURL so that people actually see
322         new web pages when they type URLs rather than a blank screen.
323
324         * WinLauncher/WinLauncher.cpp:
325         (loadURL):  Increase timeout in initWithURL from 0 to 60 seconds.
326
327 2008-12-12  Darin Adler  <darin@apple.com>
328
329         * Scripts/do-webcore-rename: Add a renaming idea.
330
331 2008-12-12  Holger Hans Peter Freyther  <zecke@selfish.org>
332
333         Reviewed by Simon Hausmann.
334
335         Update the WebKit.qrc and add a script to automatically generate the file.
336
337         With the way rcc and qmake work this can not be done at build time
338         as the WebKit.qrc must sit inside the directory that contains the files
339         and at build time we may not change the content of the source directory.
340
341         * Scripts/generate-qt-inspector-resource: Added.
342
343 2008-12-11  Cameron Zwarich  <zwarich@apple.com>
344
345         Rubber-stamped by Mark Rowe.
346
347         Roll out r39212 due to assertion failures during layout tests, multiple
348         layout test failures, memory leaks, and obvious incorrectness.
349
350         * DumpRenderTree/LayoutTestController.cpp:
351         (LayoutTestController::staticFunctions):
352         * DumpRenderTree/LayoutTestController.h:
353         * DumpRenderTree/mac/DumpRenderTree.mm:
354         (resetWebViewToConsistentStateBeforeTesting):
355         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
356         * DumpRenderTree/win/DumpRenderTree.cpp:
357         (resetWebViewToConsistentStateBeforeTesting):
358         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
359         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
360
361 2008-12-10  Glenn Wilson  <gwilson@google.com>
362
363         Reviewed by Adam Roben.
364
365         Changed LayoutTestController and DumpRenderTree to allow for manual
366         overriding of default preferences at test time.  Also added support for
367         resetting the preferences after each test.
368         https://bugs.webkit.org/show_bug.cgi?id=20534
369
370         * DumpRenderTree/LayoutTestController.cpp: Added callback method for overriding preferences
371         * DumpRenderTree/LayoutTestController.h: Added signature for callback
372         * DumpRenderTree/win/DumpRenderTree.cpp: Added calls to reset preferences after each test if necessary
373         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added JS override function
374         * DumpRenderTree/mac/DumpRenderTree.mm: Added calls to reset preferences after each test if necessary
375         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Added JS override function
376
377 2008-12-10  Brady Eidson  <beidson@apple.com>
378
379         Reviewed by Darin Adler.
380         
381         Implement the new policy delegate (including navigation type and permissive mode) for DRT/win 
382
383         * DumpRenderTree/win/DumpRenderTree.cpp:
384         * DumpRenderTree/win/DumpRenderTreeWin.h:
385         
386         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
387         (LayoutTestController::setCustomPolicyDelegate):
388         
389         * DumpRenderTree/win/PolicyDelegate.cpp:
390         (PolicyDelegate::PolicyDelegate):
391         (PolicyDelegate::decidePolicyForNavigationAction):
392         * DumpRenderTree/win/PolicyDelegate.h:
393         (PolicyDelegate::setPermissive):
394
395 2008-12-10  Brady Eidson  <beidson@apple.com>
396
397         Reviewed by Darin
398
399         Change the custom policy delegate to actually allow navigation for tests that need it.
400         The new behavior is opt-in and doesn't require any changes in old tests.
401
402         * DumpRenderTree/LayoutTestController.cpp:
403         (setCustomPolicyDelegateCallback):  Allow for a second boolean argument to set the permissive flag on the custom
404           policy delegate, which will be false by default to maintain original behavior.
405         * DumpRenderTree/LayoutTestController.h:
406         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
407         (LayoutTestController::setCustomPolicyDelegate):
408
409         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
410         (LayoutTestController::setCustomPolicyDelegate):  Partially stubbed out for now.
411         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
412         (LayoutTestController::setCustomPolicyDelegate):  Still stubbed out, but with new param.
413
414         * DumpRenderTree/mac/PolicyDelegate.h:
415         * DumpRenderTree/mac/PolicyDelegate.mm:
416         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):  If the permissive flag
417           is set, allow the navigation.
418         (-[PolicyDelegate setPermissive:]):  Change the behavior between "use" and "ignore" - allowing navigation or not.
419
420 2008-12-09  Mark Rowe  <mrowe@apple.com>
421
422         Rubber-stamped by Ada Chan.
423
424         Fix gdb-safari on Tiger.
425
426         gdb on Tiger does not take the -arch flag, so do not pass it.
427
428         * Scripts/gdb-safari:
429
430 2008-12-09  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
431
432         Reviewed by Alexey Proskuryakov.
433
434         Ignore WML tests, if no WML support available.
435
436         * Scripts/run-webkit-tests:
437
438 2008-12-08  Geoffrey Garen  <ggaren@apple.com>
439
440         Reviewed by Oliver Hunt.
441         
442         Added a shortcut for --jsDriver-args, which I use a lot.
443
444         * Scripts/run-javascriptcore-tests:
445
446 2008-12-08  Stephanie Lewis  <slewis@apple.com>
447
448         Fix Tiger build.
449
450         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
451
452 2008-12-08  Darin Adler  <darin@apple.com>
453
454         Reviewed by John Sullivan.
455
456         - test machinery for https://bugs.webkit.org/show_bug.cgi?id=22409
457           REGRESSION: cmd-shift-left/right don't switch tabs, instead select text
458
459         * DumpRenderTree/LayoutTestController.cpp:
460         (isCommandEnabledCallback): Added.
461         (LayoutTestController::staticFunctions): Added "isCommandEnabled".
462         * DumpRenderTree/LayoutTestController.h: Ditto.
463         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
464         (LayoutTestController::isCommandEnabled): Ditto.
465         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
466         (-[CommandValidationTarget initWithAction:]): Added. Used to get the
467         command validation system to tell us if a comment is enabled.
468         (-[CommandValidationTarget action]): Ditto.
469         (-[CommandValidationTarget tag]): Ditto.
470         (LayoutTestController::isCommandEnabled): Ditto.
471         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
472         (LayoutTestController::isCommandEnabled): Ditto.
473
474 2008-12-08  David Kilzer  <ddkilzer@apple.com>
475
476         Bug 22555: Sort "children" sections in Xcode project files
477
478         <https://bugs.webkit.org/show_bug.cgi?id=22555>
479
480         Reviewed by Eric Seidel.
481
482         * DrawTest/DrawTest.xcodeproj/project.pbxproj: Sorted.
483         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Sorted.
484         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Sorted.
485
486 2008-12-08  David Kilzer  <ddkilzer@apple.com>
487
488         Bug 22555: Sort "children" sections in Xcode project files
489
490         <https://bugs.webkit.org/show_bug.cgi?id=22555>
491
492         Reviewed by Timothy Hatcher.
493
494         * Scripts/sort-Xcode-project-file: By popular request, don't sort
495         the mainGroup in the project (the list of items below the top-level
496         project file).
497
498 2008-12-05  David Kilzer  <ddkilzer@apple.com>
499
500         Bug 22555: Sort "children" sections in Xcode project files
501
502         <https://bugs.webkit.org/show_bug.cgi?id=22555>
503
504         Reviewed by Darin Adler.
505
506         Sort "children" sections alphabetically, moving groups (folders) to
507         the top of each of the lists.  Files are assumed to have extensions,
508         so %isFile is used to override this behavior.
509
510         * Scripts/sort-Xcode-project-file:
511         (sortChildrenByFileName): Added.
512         (sortFilesByFileName): Renamed from sortByFileName().
513
514 2008-12-05  Eric Seidel  <eric@webkit.org>
515
516         Reviewed by Geoff Garen.
517         
518         https://bugs.webkit.org/show_bug.cgi?id=22683
519         Fix gtk and qt builds which depend on --qt and --gtk being removed from ARGV
520         Add a new argumentsForConfiguration() function and clean up some old code to use it.
521         Rename checkArgV to checkForArgumentAndRemoveFromARGV to be more self-documenting.
522
523         * Scripts/run-javascriptcore-tests:
524         * Scripts/run-launcher:
525         * Scripts/run-webkit-tests:
526         * Scripts/webkitdirs.pm:
527
528 2008-12-03  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
529
530         Reviewed by Cameron Zwarich.
531
532         Further preparations for WML layout tests.
533         Ignore WMLTestCase.js, that's going to be in trunk soon.
534
535         * Scripts/make-js-test-wrappers:
536
537 2008-12-03  Eric Seidel  <eric@webkit.org>
538
539         Build fix for --gtk and --chromium, no review.
540
541         Fix run-javascriptcore-tests to pass --gtk, --qt, --chromium, etc.
542         through to build-jsc.
543
544         * Scripts/build-jsc:
545         * Scripts/webkitdirs.pm:
546
547 2008-12-03  Eric Seidel  <eric@webkit.org>
548
549         Build fix only, no review.
550         
551         Remove support for build-webkit --svg-experimental.
552         All of the "experimental" svg features have their own toggles anyway.
553         I broke --svg-experimental in my last commit (which then broke clean builds)
554         I can't find any use of --svg-experimental in our source tree, so removing it.
555
556         * Scripts/build-webkit:
557
558 2008-12-02  Eric Seidel  <eric@webkit.org>
559
560         Reviewed by David Hyatt (and Mark Rowe).
561         
562         Move --coverage support from build-webkit to webkitdirs.pm to share it with build-jsc
563         Move --coverage support out of run-javascriptcore-tests and into build-jsc
564         
565         Finally add a buildXCodeProject function to webkitdirs.pm and move --clean support
566         there from build-webkit (to allow future sharing with other build-* scripts)
567         
568         Change run-javascriptcore-tests to expect a --jsDriver-args= argument instead of
569         picking through ARGV with a blacklist of what arguments weren't jsDriver args
570         this makes run-javascriptcore-tests transparently support all arguments which
571         webkitdirs.pm gives it support for.
572         
573         Make run-javascriptcore-tests actually print what commands it's running before running them.
574         
575         Add --help support to build-jsc and run-javascriptcore-tests!
576         
577         Make code to support --svg-experimental defaults take up half as many lines.
578
579         * Scripts/build-jsc:
580         * Scripts/build-webkit:
581         * Scripts/run-javascriptcore-tests:
582         * Scripts/webkitdirs.pm:
583
584 2008-12-03  Adam Roben  <aroben@apple.com>
585
586         Fix a leak in WinLauncher shutdown
587
588         Reviewed by Sam Weinig.
589
590         * WinLauncher/WinLauncher.cpp:
591         (_tWinMain): Replaced a delete with a Release. We can't delete the
592         WebView properly since we only have a pointer to one of its
593         interfaces. We also shouldn't be deleting COM objects directly anyway,
594         for a number of reasons.
595
596 2008-12-03  Adam Roben  <aroben@apple.com>
597
598         Fix a crash on exit in WinLauncher
599
600         Reviewed by Sam Weinig.
601
602         * WinLauncher/WinLauncher.cpp:
603         (_tWinMain): Call shutDownWebKit before exiting.
604
605 2008-12-03  Adam Roben  <aroben@apple.com>
606
607         Add a Debug_Internal configuration to WinLauncher
608
609         This matches our other projects.
610
611         Reviewed by Sam Weinig.
612
613         * WinLauncher/WinLauncher.vcproj: Added a Debug_Internal
614         configuration, which is identical to Debug except that it also
615         references debug_internal.vsprops. Also removed some settings that we
616         should be picking up from the .vsprops files.
617
618 2008-12-02  Eric Seidel  <eric@webkit.org>
619
620         Reviewed by David Kilzer.
621
622         Hack build-webkit --chromium to use Win32 python instead
623         of using the default cygwin python.  Scons + CYGWIN tries
624         to build with GCC by default, we force MSVC in our file
625         but that just results in errors from Scons.  Until we can fix
626         this latest round of errors, at least make build-webkit --chromium
627         actually "work" under CYGWIN instead of forcing users to use
628         a cmd shell directly.
629         
630         This is working around a Scons bug:
631         http://scons.tigris.org/issues/show_bug.cgi?id=2266
632
633         * Scripts/webkitdirs.pm:
634
635 2008-12-01  David Kilzer  <ddkilzer@apple.com>
636
637         Bug 22466: REGRESSION (35867): Many resources missing when saving webarchive of webkit.org
638
639         <https://bugs.webkit.org/show_bug.cgi?id=22466>
640         <rdar://problem/6403593>
641
642         Reviewed by Brady Eidson.
643
644         * DumpRenderTree/mac/DumpRenderTree.mm:
645         (normalizeHTTPResponseHeaderFields): Added.  Normalizes Date, Etag,
646         Keep-Alive, Last-Modified and Server header fields to prevent false
647         positive test failures.
648         (convertWebResourceResponseToDictionary): Call
649         normalizeHTTPResponseHeaderFields() to noramlize HTTP response
650         header fields.
651
652 2008-12-01  David D. Kilzer  <ddkilzer@webkit.org>
653
654         Bug 22559: Report builds left to test in bisect-builds (like git-bisect)
655
656         <https://bugs.webkit.org/show_bug.cgi?id=22559>
657
658         Reviewed by Adam Roben.
659
660         * Scripts/bisect-builds: Updated status message to report the
661         maximum number of builds left to test after the current one.
662         (max): Added.
663
664 2008-11-27  Alp Toker  <alp@nuanti.com>
665
666         Build GtkLauncher and minidom with the '-ansi' compiler flag to detect
667         API header breakage at build time.
668
669         * GNUmakefile.am:
670
671 2008-11-26  Eric Seidel  <eric@webkit.org>
672
673         Reviewed by Nikolas Zimmermann and Mark Rowe.
674         
675         Add support for build-webkit --chromium
676         https://bugs.webkit.org/show_bug.cgi?id=22515
677         More cleanups changing isCygwin calls to isAppleWinWebKit and deploying isAppleWebKit where necessary.
678
679         * Scripts/build-dumprendertree:
680         * Scripts/build-jsc:
681         * Scripts/build-webkit:
682         * Scripts/gdb-safari:
683         * Scripts/run-webkit-tests:
684         * Scripts/webkitdirs.pm:
685
686 2008-11-26  Eric Seidel  <eric@webkit.org>
687
688         Reviewed by Nikolas Zimmermann.
689
690         Add support for build-webkit --chromium (tested on mac)
691         https://bugs.webkit.org/show_bug.cgi?id=22515
692         Also simplified some code using checkArgv
693
694         * Scripts/build-webkit:
695         * Scripts/webkitdirs.pm:
696
697 2008-11-26  Eric Seidel  <eric@webkit.org>
698
699         Reviewed by Nikolas Zimmermann.
700
701         More pre-work for adding a build-webkit --chromium which works on Mac and Windows
702         https://bugs.webkit.org/show_bug.cgi?id=22515
703         Change a few calls to isCygwin to isAppleWinWebKit and a few calls to isAppleMacWebKit to isDarwin
704         in preparation for having a chromium cygwin and chromium mac build
705
706         * Scripts/build-webkit:
707         * Scripts/webkitdirs.pm:
708
709 2008-11-26  Eric Seidel  <eric@webkit.org>
710
711         Reviewed by Nikolas Zimmermann.
712
713         Pre-work for getting build-webkit --chromium to work
714         https://bugs.webkit.org/show_bug.cgi?id=22515
715         Rename isOSX to isAppleMacWebKit to match what the code does, and add isChromium()
716
717         * Scripts/build-dumprendertree:
718         * Scripts/build-jsc:
719         * Scripts/build-webkit:
720         * Scripts/gdb-safari:
721         * Scripts/run-javascriptcore-tests:
722         * Scripts/run-webkit-tests:
723         * Scripts/webkitdirs.pm:
724
725 2008-11-26  David Kilzer  <ddkilzer@apple.com>
726
727         Bug 22488: Make DRT smarter about charset encoding when post-processing webarchive content
728
729         <https://bugs.webkit.org/show_bug.cgi?id=22488>
730
731         Reviewed by Brady Eidson.
732
733         * DumpRenderTree/mac/DumpRenderTree.mm:
734         (convertWebResourceDataToString): If an IANA charset encoding string
735         is provided, convert it to a CFStringEncoding value and then to an
736         NSStringEncoding value, else fall back to NSUTF8StringEncoding.  We
737         also nil-check dataAsString, so the worst-case scenario is that the
738         data won't be decoded to a string (versus crashing DumpRenderTree).
739
740 2008-11-26  Jan Michael Alonzo  <jmalonzo@webkit.org>
741
742         Reviewed by Holger Freyther.
743
744         [Gtk] add/remove tests from Skipped and fix netscape plugin test
745         https://bugs.webkit.org/show_bug.cgi?id=22484
746
747         Remove print'ing to stderr
748
749         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
750         (NP_Initialize):
751         (NP_Shutdown):
752
753 2008-11-25  Steve Falkenburg  <sfalken@apple.com>
754
755         Windows build fix.
756
757         * DumpRenderTree/cg/PixelDumpSupportCG.h:
758
759 2008-11-25  Steve Falkenburg  <sfalken@apple.com>
760
761         Windows build fix.
762
763         * DumpRenderTree/cg/ImageDiffCG.cpp:
764
765 2008-11-24  Darin Fisher  <darin@chromium.org>
766
767         Fix bustage.
768
769         https://bugs.webkit.org/show_bug.cgi?id=15643
770
771         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
772         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
773
774 2008-11-24  Glenn Wilson  <gwilson@chromium.org>
775
776         Reviewed by Alexey Proskuryakov.
777
778         http://bugs.webkit.org/show_bug.cgi?id=15643
779
780         Added support for changing the "trailing whitespace" work-around
781         in LayoutTestController (so layout tests can verify this functionality)
782
783         * DumpRenderTree/LayoutTestController.cpp:
784         (setSelectTrailingWhitespaceEnabledCallback):
785         (LayoutTestController::staticFunctions):
786         * DumpRenderTree/LayoutTestController.h:
787         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
788         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
789         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
790         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
791
792 2008-11-24  Simon Fraser  <simon.fraser@apple.com>
793
794         Reviewed by Darin Adler
795
796         https://bugs.webkit.org/show_bug.cgi?id=22433
797         
798         Add script that attempts to detect virtual methods
799         whose signatures differ only by constness (which can
800         indicate a programming error).
801         
802         * Scripts/detect-mismatched-virtual-const: Added.
803
804 2008-11-24  Zan Dobersek  <zandobersek@gmail.com>
805
806         Reviewed by Holger Freyther.
807
808         https://bugs.webkit.org/show_bug.cgi?id=22039
809
810         [Gtk+] Implement TestNetscapePlugin for Gtk+ port and add it to the
811         build.
812
813         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
814         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
815         * DumpRenderTree/gtk/DumpRenderTree.cpp:
816         (setDefaultsToConsistentStateValuesForTesting):
817         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h: Added.
818         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h: Added.
819         * DumpRenderTree/gtk/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h: Added.
820         * GNUmakefile.am:
821
822 2008-11-24  Holger Hans Peter Freyther  <zecke@selfish.org>
823
824         Reviewed by Mark Rowe.
825
826         [Gtk+] Add configure option to enable Web Workers and enable it by default
827
828         Add --enable-workers to the buildsystem (used by build-webkit) add
829         the to be build files to the GNUmakefile.am and change build-webkit
830         to enable Web Workers by default.
831
832         * Scripts/build-webkit:
833
834 2008-11-24  Mark Rowe  <mrowe@apple.com>
835
836         Reviewed by Alexey Proskuryakov.
837
838         Let gdb-safari accept the --debug and --release options once more.
839
840         * Scripts/gdb-safari:
841
842 2008-11-23  Zan Dobersek  <zandobersek@gmail.com>
843
844         Reviewed by Holger Freyther. Landed by Jan Alonzo.
845
846         Get SVG tests tested on GTK port.
847
848         * Scripts/webkitdirs.pm:
849
850 2008-11-19  Greg Bolsinga  <bolsinga@apple.com>
851
852         Reviewed by Darin Adler.
853
854         https://bugs.webkit.org/show_bug.cgi?id=21810
855         Remove use of static C++ objects that are destroyed at exit time (destructors)
856
857         All static C++ objects that create atexit calls are gone. Update script
858         to indicate how to fix the problem should a new one appear.
859         
860         * Scripts/check-for-exit-time-destructors:
861
862 2008-11-18  Alexey Proskuryakov  <ap@webkit.org>
863
864         Reviewed by Darin Adler.
865
866         https://bugs.webkit.org/show_bug.cgi?id=22337
867         Enable workers by default
868
869         * Scripts/build-webkit: Changed the default to enabled.
870
871 2008-11-18  Alexey Proskuryakov  <ap@webkit.org>
872
873         Rubber-stamped by Darin Adler.
874
875         https://bugs.webkit.org/show_bug.cgi?id=22306
876         Disable channel messaging support
877
878         * Scripts/build-webkit: Add an option to enable channel messaging.
879
880 2008-11-17  Nikolas Zimmermann  <nikolas.zimmermann@torchmobile.com>
881
882         Reviewed by George Staikos.
883
884         Add --(no-)wml build flags.
885
886         * Scripts/build-webkit:
887         * Scripts/run-webkit-tests:
888         * Scripts/webkitdirs.pm:
889
890 2008-11-17  Geoffrey Garen  <ggaren@apple.com>
891
892         Not reviewed.
893         
894         Try to fix gtk build.
895
896         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
897         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
898         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
899
900 2008-11-17  Pierre-Olivier Latour  <pol@apple.com>
901
902         Reviewed by Maciej.
903
904         Pixel tests should use a default tolerance of 0.1% on Leopard and 1.0%
905         on Tiger.
906
907         https://bugs.webkit.org/show_bug.cgi?id=22271
908
909         * Scripts/run-webkit-tests:
910
911 2008-11-17  Pierre-Olivier Latour  <pol@apple.com>
912
913         Reviewed by Sam Weinig.
914
915         Added new JavaScript API on LayoutController to pause a running
916         CSS transition or animation at a given time.
917
918         https://bugs.webkit.org/show_bug.cgi?id=21261
919
920         * DumpRenderTree/LayoutTestController.cpp:
921         (pauseAnimationAtTimeOnElementWithIdCallback):
922         (pauseTransitionAtTimeOnElementWithIdCallback):
923         (LayoutTestController::staticFunctions):
924         * DumpRenderTree/LayoutTestController.h:
925         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
926         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
927         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
928         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
929         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
930         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
931
932 2008-11-17  Gabor Loki  <loki@inf.u-szeged.hu>
933
934         Reviewed by Darin Adler.
935
936         <https://bugs.webkit.org/show_bug.cgi?id=22309>
937         Pass the remaining options to build system on Qt-port
938
939         * Scripts/build-webkit:
940         * Scripts/webkitdirs.pm:
941
942 2008-11-16  Greg Bolsinga  <bolsinga@apple.com>
943
944         Reviewed by Darin Adler.
945
946         https://bugs.webkit.org/show_bug.cgi?id=21810
947         Remove use of static C++ objects that are destroyed at exit time (destructors)
948
949         Remove .o files from the exclude list that have had their exit-time destructors removed.
950         Handle case when there is no current symbol.
951         
952         * Scripts/check-for-exit-time-destructors:
953
954 2008-11-16  Sam Weinig  <sam@webkit.org>
955
956         * Scripts/do-webcore-rename: Remove now fixed renames.
957
958 2008-11-16  Darin Adler  <darin@apple.com>
959
960         * Scripts/do-webcore-rename: Plan some future renames.
961
962 2008-11-15  Darin Adler  <darin@apple.com>
963
964         Rubber stamped by Geoff Garen.
965
966         - do the long-planned StructureID -> Structure rename
967
968         * Scripts/check-for-global-initializers: Update name of StructureID.o.
969         * Scripts/do-webcore-rename: Renaming script that I used.
970
971 2008-11-15  Greg Bolsinga  <bolsinga@apple.com>
972
973         Reviewed by Darin Adler.
974
975         https://bugs.webkit.org/show_bug.cgi?id=21810
976         Remove use of static C++ objects that are destroyed at exit time (destructors)
977
978         Create DEFINE_STATIC_LOCAL macro. Change static local objects to leak to avoid 
979         exit-time destructor. Update code that was changed to fix this issue that ran 
980         into a gcc bug (<rdar://problem/6354696> Codegen issue with C++ static reference 
981         in gcc build 5465). Also typdefs for template types needed to be added in some 
982         cases so the type could make it through the macro successfully.
983
984         Basically code of the form:
985         static T m;
986         becomes:
987         DEFINE_STATIC_LOCAL(T, m, ());
988
989         Also any code of the form:
990         static T& m = *new T;
991         also becomes:
992         DEFINE_STATIC_LOCAL(T, m, ());
993
994         Remove .o files from the exclude list that have had their exit-time destructors removed.
995         
996         * Scripts/check-for-exit-time-destructors:
997
998 2008-11-14  Kevin Ollivier  <kevino@theolliviers.com>
999
1000         wx mac buildbot fix. Also, make sure we don't keep hitting this problem.
1001
1002         * wx/install-unix-extras:
1003
1004 2008-11-14  Alp Toker  <alp@nuanti.com>
1005
1006         GTK DRT build fix for gcc 4.4 snapshot. Add missing stdio include.
1007
1008         Fixes Debian bug #505723
1009         http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=505723
1010
1011         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1012
1013 2008-11-14  Krishna <krishnamurty.podipireddy@nokia.com>
1014
1015         Reviewed by Simon Hausmann.
1016
1017         Fix hanging DRT with Qt.
1018
1019         https://bugs.webkit.org/show_bug.cgi?id=22209
1020
1021         * DumpRenderTree/qt/DumpRenderTree.cpp:
1022         (WebCore::DumpRenderTree::dump):
1023         Send empty pixel test data 'block', which is now
1024         expected by run-layout-tests.
1025
1026 2008-11-12  Dmitry Titov  <dimich@chromium.org>
1027
1028         Reviewed by Alexey Proskuryakov.
1029
1030         https://bugs.webkit.org/show_bug.cgi?id=22216
1031
1032         * Scripts/build-webkit:
1033         Addes ENABLE_WORKERS to build-webkit so it's possible to build with workers enabled.
1034
1035 2008-11-06  David Kilzer  <ddkilzer@apple.com>
1036
1037         BUILD FIX: Backed out r38189 (and r38203) for Xcode 3.0.
1038
1039         Apparently older versions of gcc have issues with this patch.
1040         Backing out a second time until the issues are resolved.
1041
1042 2008-11-06  David Kilzer  <ddkilzer@apple.com>
1043
1044         BUILD WAS NOT BROKEN: Rolling r38189 back in.
1045
1046         Please perform a clean build if you see crashes.
1047
1048 2008-11-06  David Kilzer  <ddkilzer@apple.com>
1049
1050         BUILD FIX: Backed out r38189 since it apparently broke the world.
1051
1052 2008-11-06  Chris Fleizach  <cfleizach@apple.com>
1053
1054         Reviewed by Beth Dakin.
1055
1056         Add ability to query an attribute's settable status and the
1057         ability to retrieve a single attribute from an AXObject
1058
1059         * DumpRenderTree/AccessibilityUIElement.cpp:
1060         (isAttributeSettableCallback):
1061         (attributeValueCallback):
1062         (AccessibilityUIElement::getJSClass):
1063         * DumpRenderTree/AccessibilityUIElement.h:
1064         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1065         (+[NSString stringWithJSStringRef:]):
1066         (AccessibilityUIElement::attributeValue):
1067         (AccessibilityUIElement::isAttributeSettable):
1068         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1069         (AccessibilityUIElement::attributeValue):
1070         (AccessibilityUIElement::isAttributeSettable):
1071
1072 2008-11-06  Greg Bolsinga  <bolsinga@apple.com>
1073
1074         Reviewed by Darin Adler.
1075         
1076         Bug 21810: Remove use of static C++ objects that are destroyed at exit time (destructors)
1077         https://bugs.webkit.org/show_bug.cgi?id=21810
1078         
1079         Remove .o files from the exclude list that have had their exit-time destructors removed.
1080
1081         * Scripts/check-for-exit-time-destructors:
1082
1083 2008-11-05  Alp Toker  <alp@nuanti.com>
1084
1085         GTK build script tweak.
1086
1087         Make the path relative since it will appear in all -I compiler flags.
1088         Long argument lists cause bizarre slowdowns in libtool and result
1089         in huge build logs.
1090
1091         * Scripts/webkitdirs.pm:
1092
1093 2008-11-05  Anders Carlsson  <andersca@apple.com>
1094
1095         Fix 64-bit build.
1096
1097         * DumpRenderTree/mac/DumpRenderTree.mm:
1098         (setDefaultsToConsistentValuesForTesting):
1099
1100 2008-11-04  Simon Fraser  <simon.fraser@apple.com>
1101
1102         Add AccessibilityObject.o to the exclude list for the
1103         check for global destructors.
1104         
1105         * Scripts/check-for-exit-time-destructors:
1106
1107 2008-11-04  Darin Adler  <darin@apple.com>
1108
1109         * Scripts/check-for-exit-time-destructors: Fix failures seen on the
1110         bot, but for some reason not on my computer.
1111
1112 2008-11-03  Darin Adler  <darin@apple.com>
1113
1114         Reviewed by Tim Hatcher.
1115
1116         - https://bugs.webkit.org/show_bug.cgi?id=22061
1117           create script to check for exit-time destructors
1118
1119         * Scripts/check-for-exit-time-destructors: Added.
1120         Started as a copy of check-for-global-initializers.
1121
1122         * Scripts/check-for-global-initializers: Added code to make
1123         this script rerun any time it's modified, and also to properly
1124         run again after the first time it reports an error.
1125
1126 2008-11-03  Pierre-Olivier Latour  <pol@apple.com>
1127
1128         Reviewed by Dan Bernstein.
1129
1130         Fixed the override of the "AppleScrollBarVariant" system setting to also work with HIToolbox.
1131
1132         https://bugs.webkit.org/show_bug.cgi?id=22054
1133
1134         * DumpRenderTree/mac/DumpRenderTree.mm:
1135         (setDefaultsToConsistentValuesForTesting):
1136
1137 2008-10-31  Cameron Zwarich  <zwarich@apple.com>
1138
1139         Not reviewed.
1140
1141         * Scripts/do-webcore-rename:
1142
1143         Add some renames to contemplate for the future.
1144
1145 2008-10-31  Darin Adler  <darin@apple.com>
1146
1147         Requested by Mark Rowe.
1148
1149         * Scripts/check-for-global-initializers: s/Web Kit/WebKit/.
1150
1151 2008-10-31  David Kilzer  <ddkilzer@apple.com>
1152
1153         Bug 21997: prepare-ChangeLog should filter out ChangeLog files
1154
1155         <https://bugs.webkit.org/show_bug.cgi?id=21997>
1156
1157         Reviewed by Darin Adler.
1158
1159         * Scripts/prepare-ChangeLog:
1160         (generateFileList): Don't add ChangeLog files to %{$functionLists}.
1161         This prevents them from showing up in the new ChangeLog entry.  They
1162         were already excluded from @{$changedFiles}.
1163
1164 2008-10-30  Mark Rowe  <mrowe@apple.com>
1165
1166         Reviewed by Jon Homeycutt.
1167
1168         Explicitly default to building for only the native architecture in debug and release builds.
1169
1170         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1171
1172 2008-10-30  Pierre-Olivier Latour  <pol@apple.com>
1173
1174         Reviewed by Dan Bernstein.
1175
1176         Fixed 64 bit build failure.
1177
1178         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1179         (setupMainDisplayColorProfile):
1180         (createBitmapContextFromWebView):
1181
1182 2008-10-28  Alp Toker  <alp@nuanti.com>
1183
1184         Fix GTK DRT following build breakage in r37928.
1185
1186         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1187         (dump):
1188         (runTest):
1189         (main):
1190
1191 2008-10-28  Alp Toker  <alp@nuanti.com>
1192
1193         Reviewed by Mark Rowe.
1194
1195         Fix recently introduced double-free crashes in GTK DRT.
1196
1197         LayoutTestController was made ref-counted in r36606 and Mac/Win DRT
1198         were updated to call ->deref() but GTK DRT was still deleting
1199         gLayoutTestController manually. This patch updates GTK to match the
1200         other ports and resolves the memory allocation issues.
1201
1202         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1203         (runTest):
1204
1205 2008-10-28  Alp Toker  <alp@nuanti.com>
1206
1207         Reviewed by Mark Rowe.
1208
1209         Fix GTK DRT hang when running the tests.
1210
1211         Update output from the DRT tool to print an additional '#EOF' to match
1212         breaking changes that were made in r37434.
1213
1214         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1215         (dump):
1216
1217 2008-10-28  Adele Peterson  <adele@apple.com>
1218
1219         Reviewed by Sam Weinig. 
1220
1221         Specify which Localizable.strings to update since we don't always want to update the file in the same
1222         directory where we're searching for the strings to localize.
1223         
1224         * Scripts/extract-localizable-strings:
1225         * Scripts/update-webkit-localizable-strings:
1226
1227 2008-10-28  Timothy Hatcher  <timothy@apple.com>
1228
1229         Add support for enabling the profiler, so the profiling tests can continue
1230         work now that the profiler is not always enabled.
1231
1232         https://bugs.webkit.org/show_bug.cgi?id=21927
1233
1234         <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
1235         not slow down JavaScript all the time
1236
1237         Reviewed by Darin Adler and Kevin McCullough.
1238
1239         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Make the editor use spaces.
1240         * DumpRenderTree/LayoutTestController.cpp:
1241         (setJavaScriptProfilingEnabledCallback): Added. Calls LayoutTestController::setJavaScriptProfilingEnabled.
1242         (LayoutTestController::staticFunctions): Added setJavaScriptProfilingEnabled to the script class.
1243         * DumpRenderTree/LayoutTestController.h:
1244         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1245         (LayoutTestController::setJavaScriptProfilingEnabled): Stubbed out with a FIXME.
1246         * DumpRenderTree/mac/DumpRenderTree.mm:
1247         (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
1248         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1249         (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
1250         * DumpRenderTree/win/DumpRenderTree.cpp:
1251         (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
1252         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1253         (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
1254
1255 2008-10-28  Pierre-Olivier Latour  <pol@apple.com>
1256
1257         Reviewed by Dan Bernstein
1258
1259         Primary changes in DumpRenderTree:
1260         - Ensure font smoothing is disabled (this is also called LCD anti-aliasing and
1261         is different from regular font CG anti-aliasing) as font-smoothing settings
1262         depends on the display and can also be changed by the user
1263         - Use a new cleared buffer for each test instead of the reusing same one to
1264         avoid potential result corruption across tests
1265         - Can now receive the expected pixel hash as a suffix to the test path or
1266         url as "path'hash"
1267         - Make sure hash is computed in a endian-independent way
1268         - Improve the code that sets/restores the screen color profile
1269         - Make the code more cross-platformy with std::string goodness
1270         - Added an "on-screen" mode where the snapshot will take into account surfaces
1271         on the window (like OpenGL content): this uses the new CG APIs on 10.5 or
1272         reading from the display framebuffer on 10.4. This mode is not active by
1273         default for performance reason, but must be explicitly activated from the test
1274         file using the new "testOnscreen()" JS API.
1275
1276         Primary changes in ImageDiff:
1277         - Provide a new comparison algorithm that is more tolerant to "acceptable"
1278         failures (i.e. very small differences in font rendering, which --threshold is
1279         not really good at handling)
1280         - Generate normalized intensity-only diff images
1281
1282         Primary changes in run-webkit-tests:
1283         - Take advantage of hashes for pixel tests which makes them much faster by
1284         minimizing image comparisons
1285         - Removed repaint options as these should be set from within test files using
1286         JS API
1287         - Replaced "threshold" option in  by "tolerance" expressed in percents
1288         - Added more logging when in "verbose" mode
1289
1290         https://bugs.webkit.org/show_bug.cgi?id=21322
1291         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1292         * DumpRenderTree/ForwardingHeaders/wtf/PassRefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/PassRefPtr.h.
1293         * DumpRenderTree/ForwardingHeaders/wtf/RefPtr.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefPtr.h.
1294         * DumpRenderTree/LayoutTestController.cpp:
1295         (LayoutTestController::LayoutTestController):
1296         (testOnscreenCallback):
1297         (LayoutTestController::staticFunctions):
1298         * DumpRenderTree/LayoutTestController.h:
1299         (LayoutTestController::testOnscreen):
1300         (LayoutTestController::setTestOnscreen):
1301         (LayoutTestController::testPathOrURL):
1302         (LayoutTestController::expectedPixelHash):
1303         * DumpRenderTree/PixelDumpSupport.h:
1304         * DumpRenderTree/cg/ImageDiffCG.cpp:
1305         (strtof):
1306         (releaseMallocBuffer):
1307         (createDifferenceImage):
1308         (imageHasAlpha):
1309         (main):
1310         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1311         (computeMD5HashStringForBitmapContext):
1312         (dumpWebViewAsPixelsAndCompareWithExpected):
1313         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1314         (BitmapContext::createByAdoptingBitmapAndContext):
1315         (BitmapContext::~BitmapContext):
1316         (BitmapContext::cgContext):
1317         (BitmapContext::BitmapContext):
1318         * DumpRenderTree/mac/DumpRenderTree.mm:
1319         (shouldIgnoreWebCoreNodeLeaks):
1320         (setDefaultsToConsistentValuesForTesting):
1321         (crashHandler):
1322         (initializeGlobalsFromCommandLineOptions):
1323         (prepareConsistentTestingEnvironment):
1324         (dumpRenderTree):
1325         (sizeWebViewForCurrentTest):
1326         (dump):
1327         (runTest):
1328         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1329         (restoreMainDisplayColorProfile):
1330         (setupMainDisplayColorProfile):
1331         (createBitmapContextFromWebView):
1332         * DumpRenderTree/win/DumpRenderTree.cpp:
1333         (dump):
1334         (runTest):
1335         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1336         (getBitmapContextFromWebView):
1337         * Scripts/run-webkit-tests:
1338
1339 2008-10-27  Kevin Ollivier  <kevino@theolliviers.com>
1340
1341         wx build fix on Linux/GTK. Enable support for #include <JavaScriptCore/XYZ.h> style includes.
1342
1343         * wx/build-wxwebkit:
1344
1345 2008-10-24  Anders Carlsson  <andersca@apple.com>
1346
1347         Try fixing the 64-bit build.
1348         
1349         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
1350         (testGetProperty):
1351
1352 2008-10-24  Anders Carlsson  <andersca@apple.com>
1353
1354         Reviewed by Sam Weinig.
1355         
1356         <rdar://problem/5440917> Support NPN_Construct
1357         
1358         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1359         (testCallback):
1360         Fix a memory leak.
1361         
1362         (testConstruct):
1363         New test method that treats it first argument as a constructor and invokes it with the rest of the arguments.
1364         
1365         (pluginInvoke):
1366         Handle testConstruct.
1367         
1368         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
1369         (testGetProperty):
1370         Add objectPointer property.
1371         
1372         (testEnumerate):
1373         Only enumerate the two first properties.
1374         
1375         (testConstruct):
1376         Add a simple construct implementation that just returns the test object.
1377
1378 2008-10-24  David Kilzer  <ddkilzer@apple.com>
1379
1380         Bug 21850: svn-apply and svn-unapply should preserve patch line endings
1381
1382         <https://bugs.webkit.org/show_bug.cgi?id=21850>
1383
1384         Reviewed by Adam Roben.
1385
1386         * Scripts/svn-apply: Save end-of-line characters when stripping them
1387         off each line of a patch so that they may be restored after
1388         processing the line.
1389         * Scripts/svn-unapply: Ditto.
1390
1391 2008-10-23  David Kilzer  <ddkilzer@apple.com>
1392
1393         Bug 21832: Fix scripts using 'new File::Temp' for Perl 5.10
1394
1395         <https://bugs.webkit.org/show_bug.cgi?id=21832>
1396
1397         Reviewed by Sam Weinig.
1398
1399         * Scripts/bisect-builds: Use imported tempfile() from File::Temp
1400         instead of 'new File::Temp' to make the script work with Perl 5.10.
1401         * Scripts/sort-Xcode-project-file: Ditto.
1402
1403 2008-10-22  Brady Eidson  <beidson@apple.com>
1404
1405         Reviewed by Adam Roben
1406         
1407         <rdar://6261773> - autocomplete="off" doesn't work on Windows
1408
1409         Implement LayoutTestController::elementDoesAutoCompleteForElementWithId() on Windows
1410         
1411         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1412
1413 2008-10-22  Darin Adler  <darin@apple.com>
1414
1415         * Scripts/do-webcore-rename: More renaming plans.
1416
1417 2008-10-21  Steve Falkenburg  <sfalken@apple.com>
1418
1419         Exclude strings marked with UNLOCALIZED_STRING or UNLOCALIZED_LPCTSTR.
1420
1421         * Scripts/extract-localizable-strings:
1422
1423 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
1424
1425         Reviewed by Mark Rowe.
1426         
1427         - default to 1000 tests per dump tool instance again, now that CTI no longer causes
1428         excess different stack logs.
1429         
1430         (Also fix a small bug in my last change.)
1431
1432         * Scripts/run-webkit-tests:
1433
1434 2008-10-17  Stephanie Lewis  <slewis@apple.com>
1435
1436         Reviewed by Mark Rowe.
1437
1438         Fix layout tests that use prologues and epilogues.
1439
1440         * Scripts/run-webkit-tests:
1441
1442 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
1443
1444         Reviewed by Mark Rowe.
1445         
1446         - make sure MallocStackLogging is only on for tools we want to
1447         leak check, not other random stuff as well.
1448
1449         * Scripts/run-webkit-tests:
1450
1451 2008-10-17  Maciej Stachowiak  <mjs@apple.com>
1452
1453         Reviewed by Stephanie Lewis.
1454         
1455         - make run-webkit-tests --leaks default to 100 tests per run instead of 1000
1456         
1457         This should reduce or eliminate crashes on the buildbot due to
1458         running out of memory while stack logging.
1459
1460         * Scripts/run-webkit-tests:
1461
1462 2008-10-16  Jan Michael Alonzo  <jmalonzo@webkit.org>
1463
1464         Gtk build fix. Not reviewed.
1465
1466         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1467         (LayoutTestController::setSmartInsertDeleteEnabled):
1468
1469 2008-10-15  Glenn Wilson  <gwilson@google.com>
1470
1471         Added new method to allow tests to disable smart editing in the course of a test.
1472         This is a possible solution to bug .20655
1473
1474         Reviewed by Tim Hatcher.
1475
1476         * DumpRenderTree/LayoutTestController.cpp:
1477         (setSmartInsertDeleteEnabledCallback): new method
1478         (LayoutTestController::staticFunctions): added new method to static list of callbacks
1479         * DumpRenderTree/LayoutTestController.h: added signature of new method
1480         * DumpRenderTree/mac/DumpRenderTree.mm:
1481         (resetWebViewToConsistentStateBeforeTesting): added state resetting
1482         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1483         (LayoutTestController::setSmartInsertDeleteEnabled): added new method
1484         * DumpRenderTree/win/DumpRenderTree.cpp:
1485         (resetWebViewToConsistentStateBeforeTesting): added state resetting
1486         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1487         (LayoutTestController::setSmartInsertDeleteEnabled): added new method
1488
1489 2008-10-14  Ada Chan  <adachan@apple.com>
1490
1491         Fix windows build.
1492
1493         Reviewed by Sam Weinig.
1494
1495         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1496         * DumpRenderTree/config.h:
1497         * DumpRenderTree/win/DumpRenderTreeWin.h:
1498         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1499         * DumpRenderTree/win/UIDelegate.cpp:
1500
1501 2008-10-13  Timothy Hatcher  <timothy@apple.com>
1502
1503         Make prepare-ChangeLog populate the changed functions for JavaScript files.
1504
1505         https://bugs.webkit.org/show_bug.cgi?id=21567
1506
1507         Reviewed by David Kilzer.
1508
1509         * Scripts/prepare-ChangeLog:
1510         (get_function_line_ranges): Call get_function_line_ranges_for_javascript for
1511         files that end with ".js".
1512         (get_function_line_ranges_for_javascript): Find functions, anonymous functions
1513         and getters/setters.
1514
1515 2008-10-14  Alp Toker  <alp@nuanti.com>
1516
1517         Reviewed by Sam Weinig.
1518
1519         https://bugs.webkit.org/show_bug.cgi?id=16299
1520         Add a config.h file to DRT
1521
1522         Add a config.h to DumpRenderTree and reduce use of DumpRenderTree.h as
1523         an ad-hoc config header.
1524
1525         * DumpRenderTree/AccessibilityController.cpp:
1526         * DumpRenderTree/AccessibilityUIElement.cpp:
1527         * DumpRenderTree/AccessibilityUIElement.h:
1528         * DumpRenderTree/DumpRenderTree.h:
1529         * DumpRenderTree/GCController.cpp:
1530         * DumpRenderTree/LayoutTestController.cpp:
1531         * DumpRenderTree/WorkQueue.cpp:
1532         * DumpRenderTree/config.h: Added.
1533         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1534         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1535         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1536         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1537         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1538         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1539         * DumpRenderTree/win/DumpRenderTree.cpp:
1540         * DumpRenderTree/win/DumpRenderTreeWin.h:
1541         * DumpRenderTree/win/EditingDelegate.cpp:
1542         * DumpRenderTree/win/EventSender.cpp:
1543         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1544         * DumpRenderTree/win/GCControllerWin.cpp:
1545         * DumpRenderTree/win/MD5.cpp:
1546         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1547         * DumpRenderTree/win/PolicyDelegate.cpp:
1548         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1549         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1550         * GNUmakefile.am:
1551
1552 2008-10-13  Chris Fleizach  <cfleizach@apple.com>
1553
1554         Reviewed by Beth Dakin.
1555
1556         Added a method to get the links in a webpage
1557
1558         * DumpRenderTree/AccessibilityUIElement.cpp:
1559         (attributesOfDocumentLinksCallback):
1560         (AccessibilityUIElement::getJSClass):
1561         * DumpRenderTree/AccessibilityUIElement.h:
1562         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1563         (AccessibilityUIElement::getDocumentLinks):
1564         (AccessibilityUIElement::attributesOfDocumentLinks):
1565         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1566         (AccessibilityUIElement::getDocumentLinks):
1567         (AccessibilityUIElement::attributesOfDocumentLinks):
1568
1569 2008-10-13  David Kilzer  <ddkilzer@apple.com>
1570
1571         Bug 21457: resolve-ChangeLogs should be able to operate on a git revision range
1572
1573         <https://bugs.webkit.org/show_bug.cgi?id=21457>
1574
1575         Reviewed by Adam.
1576
1577         * Scripts/resolve-ChangeLogs: Added optional parameter to
1578         -f|--fix-merged switch to run the script on a revision range.
1579         Updated command-line validation checks.
1580         (findChangeLog): Fixed long-standing bug that should have used
1581         $_[0] instead of $_.
1582         (fixMergedChangeLog): Renamed to fixOneMergedChangeLog($).  Updated
1583         to work when called from git filter-branch.  It always restores a
1584         copy of the previous revision before reapplying the patch.
1585         (fixMergedChangeLogs): Added.  Calls itself through git filter-branch
1586         to re-merge ChangeLog files across a revision range.  Removes
1587         .git/refs/original directory on success.
1588         (parseFixMerged): Added.  Custom method to parse the -f|--fix-merged
1589         switch.
1590         (removeChangeLogArguments): Added.  Removes items from @ARGV when
1591         they are ChangeLog paths, and return a list of paths.  This makes it
1592         easier to validate the command-line.
1593         (resolveChangeLog): Added.  Extracted from main code block.  Runs
1594         the traditional single-file merge algorithm.
1595         (usageAndExit): Added.  Extracted from main code block.  Prints
1596         usage statement and exits with error status.
1597
1598 2008-10-12  Darin Adler  <darin@apple.com>
1599
1600         * Scripts/make-js-test-wrappers: Update exceptions list so the script
1601         won't overwrite files and mangle tests.
1602
1603 2008-10-11  Dan Bernstein  <mitz@apple.com>
1604
1605         Reviewed by Sam Weinig and Anders Carlsson.
1606
1607         - update Mac DumpRenderTree to use the new WebView SPI for forcing the
1608           complex text code path
1609         - add --complex-text support to Windows DumpRenderTree
1610
1611         * DumpRenderTree/mac/DumpRenderTree.mm:
1612         (dumpRenderTree):
1613         * DumpRenderTree/win/DumpRenderTree.cpp:
1614         (createWebViewAndOffscreenWindow):
1615         (main):
1616         * Scripts/run-webkit-tests:
1617
1618 2008-10-09  Eric Seidel  <eric@webkit.org>
1619
1620         Reviewed by Oliver Hunt.
1621
1622         https://bugs.webkit.org/show_bug.cgi?id=21498
1623
1624         * Scripts/make-js-test-wrappers: ignore resources/shadow-offset.js
1625
1626 2008-10-09  Cameron Zwarich  <zwarich@apple.com>
1627
1628         Not reviewed.
1629
1630         Add StructureID.o to the exclusion list in the global initializers
1631         script to fix the Debug build.
1632
1633         * Scripts/check-for-global-initializers:
1634
1635 2008-10-08  Mark Rowe  <mrowe@apple.com>
1636
1637         Fix the Windows build after r37434.
1638
1639         * DumpRenderTree/win/DumpRenderTree.cpp:
1640         (dump): Update code to approximate valid C++ syntax.
1641
1642 2008-10-08  Timothy Hatcher  <timothy@apple.com>
1643
1644         Add SVGElementInstance to the list of exceptions that have
1645         global initializers in debug builds.
1646
1647         Rubber-stamped by Mark Rowe.
1648
1649         * Scripts/check-for-global-initializers: Add SVGElementInstance.o.
1650
1651 2008-10-08  Simon Fraser  <simon.fraser@apple.com>
1652
1653         Reviewed by Dan Bernstein
1654
1655         Avoid disconnect between DRT and run-webkit-tests
1656         about whether to expect PNG dumps by having DRT always
1657         print two blocks terminated by #EOF, the second of which
1658         may be empty.
1659         
1660         https://bugs.webkit.org/show_bug.cgi?id=21483
1661         
1662         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1663         (printPNG):
1664         (dumpWebViewAsPixelsAndCompareWithExpected):
1665         * DumpRenderTree/mac/DumpRenderTree.mm:
1666         (dump):
1667         * DumpRenderTree/win/DumpRenderTree.cpp:
1668         (dump):
1669         * Scripts/run-webkit-tests:
1670
1671 2008-10-07  Adam Roben  <aroben@apple.com>
1672
1673         Make sure short functions get included in ChangeLog output for git
1674         repositories
1675
1676         Reviewed by Dave Kilzer.
1677
1678         * Scripts/prepare-ChangeLog:
1679         (sub diffCommand): Pass -U0 to git diff so that each contiguous change
1680         will get its own chunk without any surrounding context.
1681         (sub extractLineRange): Use the line numbers from the chunk header
1682         without modifying them now that they're accurate.
1683
1684 2008-10-04  Mark Rowe  <mrowe@apple.com>
1685
1686         Reviewed by Tim Hatcher.
1687
1688         Update check-for-weak-vtables to check only the final linked image for weak vtables.
1689         This gives more useful results than checking each object file independently.
1690
1691         * Scripts/check-for-weak-vtables:
1692
1693 2008-10-03  Pierre-Olivier Latour <pol@apple.com>
1694
1695         Reviewed by Darin Adler
1696
1697         Render images to RGBA8 bitmaps independently of platform endianness.
1698
1699         Create image difference bitmap in reference image colorspace instead of device colorspace
1700         (which depends on the main display profile), so that no color matching happens.
1701
1702         https://bugs.webkit.org/show_bug.cgi?id=21336
1703
1704         * DumpRenderTree/cg/ImageDiffCG.cpp:
1705         (createDifferenceBitmap):
1706         (computePercentageDifferent):
1707         (compareImages):
1708
1709 2008-10-02  Simon Fraser  <simon.fraser@apple.com>
1710
1711         Reviewed by Darin Adler
1712
1713         Fix hang when running with --pixel --reset, which occurs
1714         because DRT spews PNG data when the script does not expect it.
1715         
1716         https://bugs.webkit.org/show_bug.cgi?id=21323
1717         
1718         * Scripts/run-webkit-tests:
1719
1720 2008-09-30  Mark Rowe  <mrowe@apple.com>
1721
1722         Reviewed by Dan Bernstein.
1723
1724         Add a leak counter for CachedResources since we've had two recent leaks involving them.
1725
1726         * Scripts/check-for-global-initializers:
1727
1728 2008-09-30  Mark Rowe  <mrowe@apple.com>
1729
1730         Rubber-stamped by Dan Bernstein.
1731
1732         Fix many leaks seen on fast/backgrounds/svg-as-background-1.html.
1733
1734         JavaScript wrappers were keeping DOM objects alive, which was leading to the SVG background image
1735         being kept alive in the memory cache past our last attempt to empty the cache prior to quitting.
1736         We need to empty the memory cache after forcing a JavaScript garbage collection to ensure that
1737         any live JavaScript wrappers are collected and their corresponding DOM objects have a chance to be
1738         torn down before we exit.
1739
1740         * DumpRenderTree/mac/DumpRenderTree.mm:
1741         (dumpRenderTree):
1742         (main):
1743
1744 2008-09-30  Simon Fraser  <simon.fraser@apple.com>
1745
1746         Reviewed by Dan Bernstein
1747
1748         Don't run pixel comparison for text-only tests.
1749         https://bugs.webkit.org/show_bug.cgi?id=21124
1750         
1751         * DumpRenderTree/mac/DumpRenderTree.mm:
1752         (dump):
1753         * Scripts/run-webkit-tests:
1754
1755 2008-09-29  Thiago Macieira  <thiago.macieira@nokia.com>
1756
1757         Reviewed by Simon.
1758
1759         Changed copyright from Trolltech ASA to Nokia.
1760         
1761         Nokia acquired Trolltech ASA, assets were transferred on September 26th 2008.
1762         
1763
1764         * DumpRenderTree/qt/DumpRenderTree.cpp:
1765         * DumpRenderTree/qt/jsobjects.cpp:
1766         * DumpRenderTree/qt/jsobjects.h:
1767         * DumpRenderTree/qt/main.cpp:
1768         * DumpRenderTree/qt/testplugin.cpp:
1769         * DumpRenderTree/qt/testplugin.h:
1770
1771 2008-09-28  David Kilzer  <ddkilzer@apple.com>
1772
1773         Bug 21185: resolve-ChangeLogs should be able to fix poorly merged ChangeLog entries after a git svn rebase
1774
1775         <https://bugs.webkit.org/show_bug.cgi?id=21185>
1776
1777         Reviewed by Adam.
1778
1779         * Scripts/resolve-ChangeLogs: Added new -f|--fix-merge switch that
1780         will attempt to reapply the last commit to a ChangeLog file such
1781         that the ChangeLog entry appears at the top of the file.
1782         (findChangeLog): Added prototype and moved method below the exit
1783         statement.
1784         (fixMergedChangeLog): Added.  Method to fix incorrectly merged
1785         ChangeLog entries.
1786
1787 2008-09-27  Anders Carlsson  <andersca@apple.com>
1788
1789         Reviewed by Sam Weinig.
1790         
1791         https://bugs.webkit.org/show_bug.cgi?id=21178
1792         <rdar://problem/6248651>
1793         
1794         Return the result value from getURL.
1795         
1796         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1797         (getURL):
1798
1799 2008-09-26  Matt Lilek  <webkit@mattlilek.com>
1800
1801         Reviewed by Tim Hatcher.
1802
1803         Update FEATURE_DEFINES after ENABLE_CROSS_DOCUMENT_MESSAGING was removed.
1804
1805         * Scripts/build-webkit:
1806
1807 2008-09-26  Alice Liu  <alice.liu@apple.com>
1808
1809         Remove usage of atlstr.h and CString for VCExpress compatibility
1810
1811         Reviewed by Stephanie Lewis.
1812
1813         * record-memory-win/main.cpp:
1814         (ProcessArgs):
1815         (UseImage):
1816         (QueryContinuously):
1817         (OneQuery):
1818         (OneQueryMP):
1819
1820 2008-09-26  Kevin Ollivier  <kevino@theolliviers.com>
1821
1822         wx build fix. Update the version of libpng.
1823
1824         * wx/install-unix-extras:
1825
1826 2008-09-24  Sam Weinig  <sam@webkit.org>
1827
1828         Reviewed by Darin Adler.
1829
1830         Fix for https://bugs.webkit.org/show_bug.cgi?id=21080
1831         <rdar://problem/6243534>
1832         Crash below Function.apply when using a runtime array as the argument list
1833
1834         Add method to ObjCController to return a runtime array.
1835
1836         * DumpRenderTree/mac/ObjCController.m:
1837         (+[ObjCController isSelectorExcludedFromWebScript:]):
1838         (+[ObjCController webScriptNameForSelector:]):
1839         (-[ObjCController testArray]):
1840
1841 2008-09-24  Beth Dakin  <bdakin@apple.com>
1842
1843         Reviewed by Sam Weinig.
1844
1845         Speculative build fix. 
1846
1847         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1848         (AccessibilityUIElement::supportsPressAction):
1849
1850 2008-09-23  Beth Dakin  <bdakin@apple.com>
1851
1852         Reviewed by Sam Weinig.
1853
1854         This patch extends DumpRenderTree's AccessibilityController to ask 
1855         if the focused element supports the press action.
1856
1857         * DumpRenderTree/AccessibilityUIElement.cpp:
1858         (getSupportsPressActionCallback):
1859         (AccessibilityUIElement::getJSClass):
1860         * DumpRenderTree/AccessibilityUIElement.h:
1861         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1862         (AccessibilityUIElement::supportsPressAction):
1863
1864 2008-09-22  Alice Liu  <alice.liu@apple.com>
1865
1866         Adding a stand-alone Windows console application to record a process's memory usage
1867
1868         Reviewed by Steve Falkenburg.
1869
1870         * record-memory-win: Added.
1871         * record-memory-win/main.cpp: Added.
1872         * record-memory-win/record-memory-win.vcproj: Added.
1873
1874 2008-09-22  Chris Fleizach  <cfleizach@apple.com>
1875
1876         Reviewed by Darin Adler.
1877
1878         Support ability to get/set selected text ranges for text controls through AX.
1879
1880         * DumpRenderTree/AccessibilityUIElement.cpp:
1881         (setSelectedTextRangeCallback):
1882         (getSelectedTextRangeCallback):
1883         (AccessibilityUIElement::getJSClass):
1884         * DumpRenderTree/AccessibilityUIElement.h:
1885         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1886         (AccessibilityUIElement::attributesOfRowHeaders):
1887         (AccessibilityUIElement::attributesOfVisibleCells):
1888         (AccessibilityUIElement::rowIndexRange):
1889         (AccessibilityUIElement::columnIndexRange):
1890         (AccessibilityUIElement::cellForColumnAndRow):
1891         (AccessibilityUIElement::selectedTextRange):
1892         (AccessibilityUIElement::setSelectedTextRange):
1893         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1894         (AccessibilityUIElement::selectedTextRange):
1895         (AccessibilityUIElement::setSelectedTextRange):
1896
1897 2008-09-20  Darin Adler  <darin@apple.com>
1898
1899         * DumpRenderTree/mac/DumpRenderTree.mm:
1900         (convertMIMEType): Turn on Stephanie's workaround for Tiger too.
1901
1902 2008-09-19  Alp Toker  <alp@nuanti.com>
1903
1904         Build fix for the 'gold' linker and recent binutils. New behaviour
1905         requires that we link to used libraries explicitly.
1906
1907         * GNUmakefile.am:
1908
1909 2008-09-19  Stephanie Lewis  <slewis@apple.com>
1910
1911         Reviewed by Oliver Hunt.
1912
1913         Implement a workaround for an incorrect mime-type on machines with 
1914         Dashcode 2.0.1.  Dashcode is overriding the UTI type for .js files.
1915         See radar <rdar://problem/6234318>.     
1916
1917         * DumpRenderTree/mac/DumpRenderTree.mm:
1918         (convertMIMEType):
1919
1920 2008-09-19  Chris Fleizach  <cfleizach@apple.com>
1921
1922         Fixed Windows bustage
1923
1924         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1925         (AccessibilityUIElement::titleUIElement):
1926
1927 2008-09-18  Chris Fleizach  <cfleizach@apple.com>
1928
1929         Reviewed by Darin Adler.
1930
1931         Expose titleUIElement call for DumpRenderTree
1932
1933         * ChangeLog:
1934         * DumpRenderTree/AccessibilityUIElement.cpp:
1935         (titleUIElementCallback):
1936         (AccessibilityUIElement::getJSClass):
1937         * DumpRenderTree/AccessibilityUIElement.h:
1938         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1939         (AccessibilityUIElement::titleUIElement):
1940
1941 2008-09-18  Darin Adler  <darin@apple.com>
1942
1943         * Scripts/do-webcore-rename: More renaming plans.
1944
1945 2008-09-18  Mark Rowe  <mrowe@apple.com>
1946
1947         Reviewed by Dan Bernstein.
1948
1949         Clear the main frame's name between tests to get more consistent test results
1950         when running the WebKit tests with --nthly.
1951
1952         * DumpRenderTree/mac/DumpRenderTree.mm:
1953         (resetWebViewToConsistentStateBeforeTesting):
1954         * DumpRenderTree/win/DumpRenderTree.cpp:
1955         (resetWebViewToConsistentStateBeforeTesting):
1956
1957 2008-09-18  Stephanie Lewis  <slewis@apple.com>
1958
1959         Really fix tiger jsc tests.
1960
1961         * Scripts/run-javascriptcore-tests:
1962
1963 2008-09-18  Stephanie Lewis  <slewis@apple.com>
1964
1965         Reviewed by Maciej Stachowiak.
1966
1967         Fix jsc tests on Tiger.  Make jsc tests smarter about when to use the arch flag.
1968
1969         * Scripts/run-javascriptcore-tests:
1970         * Scripts/webkitdirs.pm:
1971
1972 2008-09-18  Mark Rowe  <mrowe@apple.com>
1973
1974         Rubber-stamped by Sam Weinig.
1975
1976         Print warning to stdout rather than stderr when a test attempts to access a remote resource.
1977         This should make it more obvious when a test does this, as stderr output tends to be obscured
1978         by noise in the test results.
1979
1980         Also fixes some coding style issues in ResourceLoadDelegate.mm.
1981
1982         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1983         (-[NSError _drt_descriptionSuitableForTestResult]):
1984         (-[NSURL _drt_descriptionSuitableForTestResult]):
1985         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1986         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1987         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
1988         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1989         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1990         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
1991
1992 2008-09-18  Stephanie Lewis  <slewis@apple.com>
1993
1994         Reviewed by Mark Rowe and Maciej Stachowiak..
1995
1996         add a --64-bit option and specify which architecture to run on Mac.
1997
1998         * Scripts/run-javascriptcore-tests:
1999
2000 2008-09-17  Mark Rowe  <mrowe@apple.com>
2001
2002         Reviewed by Sam Weinig.
2003
2004         Fix a crash seen running DumpRenderTree on fast/dom/null-document-window-open-crash.html under guard malloc.
2005
2006         The JS wrapper for LayoutTestController could outlive the wrapped instance, and would crash when
2007         attempting to access the wrapped instance within layoutTestControllerObjectFinalize. We fix this by making
2008         LayoutTestController ref-counted to ensure that it is not outlived by the JS wrapper.
2009
2010         * DumpRenderTree/ForwardingHeaders/wtf/RefCounted.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/RefCounted.h.
2011         * DumpRenderTree/LayoutTestController.cpp:
2012         (LayoutTestController::LayoutTestController):
2013         (notifyDoneCallback): Remove code that is no longer needed now that we must always have a wrapped instance.
2014         (layoutTestControllerObjectFinalize): Deref the wrapped object.
2015         (LayoutTestController::makeWindowObject): Ref the wrapped object.
2016         * DumpRenderTree/LayoutTestController.h: Make LayoutTestController RefCounted.
2017         * DumpRenderTree/mac/DumpRenderTree.mm:
2018         (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
2019         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Remove code that is no longer needed.
2020         * DumpRenderTree/win/DumpRenderTree.cpp:
2021         (runTest): Deref the LayoutTestController object rather than explicitly deleting it.
2022
2023 2008-09-16  Sam Weinig  <sam@webkit.org>
2024
2025         Reviewed by Mark Rowe.
2026
2027         Add flag to disable running sample on tests that timeout.
2028
2029         * Scripts/run-webkit-tests:
2030
2031 2008-09-16  Adam Roben  <aroben@apple.com>
2032
2033         Windows build fix after r36511
2034
2035         Update for rename of layoutTestController to gLayoutTestController.
2036
2037         * DumpRenderTree/LayoutTestController.cpp:
2038         * DumpRenderTree/win/EditingDelegate.cpp:
2039         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2040         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2041         * DumpRenderTree/win/UIDelegate.cpp:
2042
2043 2008-09-16  Adam Roben  <aroben@apple.com>
2044
2045         Add a script to print out the dependency tree of a Visual Studio
2046         solution file
2047
2048         * Scripts/print-msvc-project-dependencies: Added.
2049
2050 2008-09-16  Mark Rowe  <mrowe@apple.com>
2051
2052         Fix the build.
2053
2054         * DumpRenderTree/LayoutTestController.cpp:
2055         (notifyDoneCallback): Call fprintf in a safer manner.
2056
2057 2008-09-16  Simon Fraser  <simon.fraser@apple.com>
2058
2059         Reviewed by Eric Seidel
2060         
2061         Protect against tests that call layoutTestController.notifyDone() 
2062         more than once, which would lead to memory corruption, by nulling
2063         out the LayoutTestController on the JSObjectRef on destruction. Also
2064         add a finalize callback on the class so that if the LTC outlives
2065         the JSObjectRef, the JSObjectRef backpointer on the LTC can be
2066         nulled out.
2067         
2068         https://bugs.webkit.org/show_bug.cgi?id=20875
2069
2070         * DumpRenderTree/LayoutTestController.cpp:
2071         (LayoutTestController::LayoutTestController):
2072         (notifyDoneCallback):
2073         (layoutTestControllerObjectFinalize):
2074         (LayoutTestController::makeWindowObject):
2075         (LayoutTestController::getJSClass):
2076         * DumpRenderTree/LayoutTestController.h:
2077         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2078         (LayoutTestController::~LayoutTestController):
2079
2080 2008-09-16  Simon Fraser  <simon.fraser@apple.com>
2081
2082         Reviewed by Eric Seidel
2083
2084         Step 1 patch: rename global variable for clarity.
2085         https://bugs.webkit.org/show_bug.cgi?id=20875
2086
2087         * DumpRenderTree/DumpRenderTree.h:
2088         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2089         (dumpWebViewAsPixelsAndCompareWithExpected):
2090         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2091         (dumpFramesAsText):
2092         (dump):
2093         (runTest):
2094         (processWork):
2095         (webViewLoadFinished):
2096         (webViewWindowObjectCleared):
2097         * DumpRenderTree/mac/DumpRenderTree.mm:
2098         (allocateGlobalControllers):
2099         (dumpFrameScrollPosition):
2100         (dumpFramesAsText):
2101         (methodNameStringForFailedTest):
2102         (dump):
2103         (runTest):
2104         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2105         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2106         * DumpRenderTree/mac/EditingDelegate.mm:
2107         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2108         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2109         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2110         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2111         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2112         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2113         (-[EditingDelegate webViewDidBeginEditing:]):
2114         (-[EditingDelegate webViewDidChange:]):
2115         (-[EditingDelegate webViewDidEndEditing:]):
2116         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2117         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2118         (-[FrameLoadDelegate processWork:]):
2119         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2120         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2121         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2122         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2123         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2124         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2125         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2126         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2127         * DumpRenderTree/mac/UIDelegate.mm:
2128         (-[UIDelegate webView:dragImage:at:offset:event:pasteboard:source:slideBack:forView:]):
2129         (-[UIDelegate webViewFocus:]):
2130         (-[UIDelegate webViewUnfocus:]):
2131         (-[UIDelegate webView:createWebViewWithRequest:]):
2132         (-[UIDelegate webViewClose:]):
2133         * DumpRenderTree/win/DumpRenderTree.cpp:
2134         (dumpFrameScrollPosition):
2135         (dumpFramesAsText):
2136         (dump):
2137         (runTest):
2138
2139 2008-09-15  Alice Liu  <alice.liu@apple.com>
2140
2141         A change needed to make PPC bots pass accessibility/table-cell-spans.html layout test
2142
2143         Reviewed by Stephanie Lewis.
2144
2145         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2146         Calling -[NSValue rangeValue] on nil object was returning bogus results on PPC, 
2147         but not Intel.  Add a check for nil before calling. 
2148         (AccessibilityUIElement::rowIndexRange):
2149         (AccessibilityUIElement::columnIndexRange):
2150
2151 2008-09-14  Mark Rowe  <mrowe@apple.com>
2152
2153         Build fix.
2154
2155         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2156         (waitUntilDoneWatchdogFired):
2157         * DumpRenderTree/mac/ObjCPlugin.m:
2158
2159 2008-09-08  Dan Bernstein  <mitz@apple.com>
2160
2161         Reviewed by Mark Rowe.
2162
2163         - add an option to run-webkit-tests to always use the complex text code path
2164
2165         * DumpRenderTree/mac/DumpRenderTree.mm:
2166         (initializeGlobalsFromCommandLineOptions):
2167         (dumpRenderTree):
2168         * Scripts/run-webkit-tests:
2169
2170 2008-09-08  Steve Falkenburg  <sfalken@apple.com>
2171
2172         Another Windows nightly build fix.
2173
2174         Reviewed by Sam Weinig.
2175
2176         * FindSafari/FindSafari.cpp:
2177         (_tmain): Delete existing WebKitNightly directory in temp.
2178         * FindSafari/Safari.exe.manifest: Add PROGIDs for each COM class. Remove non-production classes.
2179
2180 2008-09-07  Stephanie Lewis  <slewis@apple.com>
2181
2182         Reviewed by Mark Rowe.
2183
2184         Fix DRT build 
2185
2186         * DumpRenderTree/DumpRenderTreePrefix.h:
2187         * DumpRenderTree/win/DumpRenderTree.vcproj:
2188
2189 2008-09-06  Steve Falkenburg  <sfalken@apple.com>
2190
2191         Fix Windows nightlies.
2192         
2193         Copy WebKit.dll alongside application so registry-free COM can find it.
2194         Update embedded manifest to force use registry-free COM.
2195
2196         Reviewed by Dave Hyatt.
2197
2198         * FindSafari/FindSafari.cpp:
2199         (copyManifest):
2200         (replaceManifest):
2201         (_tmain):
2202         * FindSafari/FindSafari.rc: Added.
2203         * FindSafari/FindSafari.vcproj:
2204         * FindSafari/Safari.exe.manifest: Added.
2205         * FindSafari/resource.h: Added.
2206
2207 === End merge of squirrelfish-extreme ===
2208
2209 2008-08-31  Mark Rowe  <mrowe@apple.com>
2210
2211         Reviewed by Maciej Stachowiak.
2212
2213         Add a --profile flag to run-sunspider.
2214
2215         * Scripts/webkitdirs.pm: Detect --profile or --profiling passed as a command-line argument
2216         to build scripts as indicating that we should use the "Profiling" configuration.  At present
2217         this is only supported by JavaScriptCore, so using this argument to build any other project
2218         will likely result in unexpected behaviour.
2219
2220 2008-08-27  Mark Rowe  <mrowe@apple.com>
2221
2222         Reviewed by Oliver Hunt.
2223
2224         Fix run-webkit-tests to handle DRT exiting early.
2225
2226         * Scripts/run-webkit-tests: Initialize $expectedResultPaths{$base} before it will be used.
2227
2228 === Start merge of squirrelfish-extreme ===
2229
2230 2008-09-04  Mark Rowe  <mrowe@apple.com>
2231
2232         Reviewed by Eric Seidel.
2233
2234         Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
2235         Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE
2236
2237         * Scripts/build-webkit: Remove ENABLE_DASHBOARD_SUPPORT-related code.
2238
2239 2008-09-04  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
2240
2241         Reviewed by Oliver Hunt.
2242
2243         Bug 20616: Incorporate V8 benchmarks in testing
2244         <https://bugs.webkit.org/show_bug.cgi?id=20616>
2245
2246         Add support for the --v8 option to run-sunspider.
2247
2248         * Scripts/run-sunspider:
2249
2250 2008-09-04  Kevin Ollivier  <kevino@theolliviers.com>
2251
2252         wx buildbot fix. More robust handling of clean when makefiles are not built or 
2253         are not completely made.
2254
2255         * wx/build-wxwebkit:
2256
2257 2008-09-03  Mark Rowe  <mrowe@apple.com>
2258
2259         More Mac build fixes.
2260
2261         Set ENABLE_DASHBOARD_SUPPORT when building for Mac via build-webkit.
2262         Also set ENABLE_CROSS_DOCUMENT_MESSAGING in order to match the
2263         default configuration specified in the .xcconfig files.
2264
2265         * Scripts/build-webkit:
2266
2267 2008-09-03  Mark Rowe  <mrowe@apple.com>
2268
2269         Mac build fix.  Ensure that dashboard support is enabled.
2270
2271         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2272
2273 2008-08-25  Steve Falkenburg  <sfalken@apple.com>
2274
2275         Build fix. Copy correct version of ICU.
2276
2277         * DumpRenderTree/win/DumpRenderTree.vcproj:
2278
2279 2008-08-25  Holger Hans Peter Freyther  <zecke@selfish.org>
2280
2281         Reviewed by Simon.
2282
2283         [run-webkit-tests] Use QtLauncher to show the results of the tests
2284         konqueror might not be installed, xdg-open might not be installed but the
2285         QtLauncher should be present.
2286
2287         * Scripts/run-webkit-tests:
2288
2289 2008-08-24  Jon Honeycutt  <jhoneycutt@apple.com>
2290
2291         Initial support for accessibility layout tests on Windows.
2292         https://bugs.webkit.org/show_bug.cgi?id=20497
2293
2294         Reviewed by Sam Weinig.
2295
2296         * DumpRenderTree/AccessibilityController.h: Fix typos.
2297         * DumpRenderTree/AccessibilityUIElement.cpp: Change #import to #include.
2298         * DumpRenderTree/AccessibilityUIElement.h: Define _WINSOCKAPI_ to
2299         prevent oleacc.h, which includes windows.h, from including winsock.h.
2300         Fixed typos.
2301         * DumpRenderTree/win/AccessibilityControllerWin.cpp: Added.
2302         (AccessibilityController::AccessibilityController):
2303         (AccessibilityController::~AccessibilityController):
2304         (AccessibilityController::focusedElement): Get the root element, and
2305         request its focused object.
2306         (AccessibilityController::rootElement): Query Windows for the 
2307         accessible client object for the WebView's window.
2308         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added.
2309         (AccessibilityUIElement::AccessibilityUIElement):
2310         (AccessibilityUIElement::~AccessibilityUIElement):
2311         (AccessibilityUIElement::getLinkedUIElements): Not implemented.
2312         (AccessibilityUIElement::getChildren): Get the child count, and append
2313         each child.
2314         (AccessibilityUIElement::getChildAtIndex): Get the child at the given
2315         index offset by 1. In MSAA, child 0 is the object itself.
2316         (AccessibilityUIElement::allAttributes): Not implemented.
2317         (AccessibilityUIElement::attributesOfLinkedUIElements): Same.
2318         (AccessibilityUIElement::attributesOfChildren): Same.
2319         (AccessibilityUIElement::parameterizedAttributeNames): Same.
2320         (self): Return a VARIANT representing the "self" object. This is used
2321         when calling methods that require a child variant.
2322         (AccessibilityUIElement::role): Get the MSAA role, a long value, and
2323         convert it into a string with GetRoleText().
2324         (AccessibilityUIElement::title): Get the element's title, and convert
2325         it to a JS String.
2326         (AccessibilityUIElement::description): Same, for description.
2327         (AccessibilityUIElement::width):
2328         (AccessibilityUIElement::height):
2329         (AccessibilityUIElement::intValue): Get the object's value as a string,
2330         and convert the string to a double.
2331         (AccessibilityUIElement::minValue): Not implemented.
2332         (AccessibilityUIElement::maxValue): Same.
2333         (AccessibilityUIElement::insertionPointLineNumber): Same.
2334         (AccessibilityUIElement::attributesOfColumnHeaders): Same.
2335         (AccessibilityUIElement::attributesOfRowHeaders): Same.
2336         (AccessibilityUIElement::attributesOfColumns): Same.
2337         (AccessibilityUIElement::attributesOfRows): Same.
2338         (AccessibilityUIElement::attributesOfVisibleCells): Same.
2339         (AccessibilityUIElement::attributesOfHeader): Same.
2340         (AccessibilityUIElement::indexInTable): Same.
2341         (AccessibilityUIElement::rowIndexRange): Same.
2342         (AccessibilityUIElement::columnIndexRange): Same.
2343         (AccessibilityUIElement::lineForIndex): Same.
2344         (AccessibilityUIElement::boundsForRange): Same.
2345         (AccessibilityUIElement::cellForColumnAndRow): Same.
2346         * DumpRenderTree/win/DumpRenderTree.vcproj: Add accessibility files to
2347         project.  Link to oleacc.lib, the MSAA library.
2348         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2349         (FrameLoadDelegate::FrameLoadDelegate): Initialize the accessibility
2350         controller.
2351         (FrameLoadDelegate::didClearWindowObject): Create a new window object
2352         for the accessibility controller.
2353         * DumpRenderTree/win/FrameLoadDelegate.h:
2354
2355 2008-08-21  Simon Fraser  <simon.fraser@apple.com>
2356
2357         Reviewed by Mark Rowe
2358         
2359         Make build-launcher-app work when run from a git repository.
2360         https://bugs.webkit.org/show_bug.cgi?id=20478
2361
2362         * BuildSlaveSupport/build-launcher-app:
2363
2364 2008-08-20  Maxime Britto  <britto@apple.com>
2365
2366         Reviewed by Ada Chan.
2367
2368          rdar://5259746
2369         Mouse events are sent to page while resizing window (affects Gmail)
2370
2371         * DumpRenderTree/win/UIDelegate.h:
2372         (UIDelegate::webViewSendResizeMessage): Add the new interface method, not implemented.
2373
2374 2008-08-19  Chris Fleizach  <cfleizach@apple.com>
2375
2376         Reviewed by Beth Dakin.
2377
2378         Add snowleopard platform in layout tests
2379
2380         Added support for accessing the attributes of
2381         accessibility tables through the accessibility controller
2382         in DumpRenderTree
2383
2384         * DumpRenderTree/AccessibilityUIElement.cpp:
2385         (attributesOfColumnHeadersCallback):
2386         (attributesOfRowHeadersCallback):
2387         (attributesOfColumnsCallback):
2388         (attributesOfRowsCallback):
2389         (attributesOfVisibleCellsCallback):
2390         (attributesOfHeaderCallback):
2391         (indexInTableCallback):
2392         (rowIndexRangeCallback):
2393         (columnIndexRangeCallback):
2394         (childAtIndexCallback):
2395         (cellForColumnAndRowCallback):
2396         (AccessibilityUIElement::getJSClass):
2397         * DumpRenderTree/AccessibilityUIElement.h:
2398         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2399         (convertNSArrayToVector):
2400         (descriptionOfElements):
2401         (AccessibilityUIElement::getLinkedUIElements):
2402         (AccessibilityUIElement::getChildren):
2403         (AccessibilityUIElement::attributesOfLinkedUIElements):
2404         (AccessibilityUIElement::attributesOfChildren):
2405         (AccessibilityUIElement::attributesOfColumnHeaders):
2406         (AccessibilityUIElement::attributesOfRowHeaders):
2407         (AccessibilityUIElement::attributesOfColumns):
2408         (AccessibilityUIElement::attributesOfRows):
2409         (AccessibilityUIElement::attributesOfVisibleCells):
2410         (AccessibilityUIElement::attributesOfHeader):
2411         (AccessibilityUIElement::indexInTable):
2412         (AccessibilityUIElement::rowIndexRange):
2413         (AccessibilityUIElement::columnIndexRange):
2414         (AccessibilityUIElement::cellForColumnAndRow):
2415         * Scripts/run-webkit-tests:
2416
2417 2008-08-19  Alexey Proskuryakov  <ap@webkit.org>
2418
2419         Reviewed by Darin Adler.
2420
2421         Fix run-webkit-tests misreporting crashed tests as timed out ones because DumpRenderTree
2422         is waiting for crash reporter to let it exit.
2423
2424         The fix does not work on Tiger, because the state of the process is indistinguishable from
2425         other waiting processes, at least not with this technique.
2426
2427         * Scripts/run-webkit-tests:
2428
2429 2008-08-18  Alp Toker  <alp@nuanti.com>
2430
2431         Reviewed by Holger Freyther.
2432
2433         https://bugs.webkit.org/show_bug.cgi?id=20350
2434         [GTK] Get DumpRenderTree working
2435
2436         Fixes and enhancements to DumpRenderTree. With these changes, the test
2437         suite can now complete a run producing text and render tree dumps.
2438
2439         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2440         (dumpFramesAsText):
2441         (dump):
2442         (runTest):
2443         (webViewLoadFinished):
2444         (webViewWindowObjectCleared):
2445         (webViewConsoleMessage):
2446         (webViewScriptAlert):
2447         (webViewScriptPrompt):
2448         (webViewScriptConfirm):
2449         (webViewTitleChanged):
2450         (main):
2451         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
2452         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2453         (LayoutTestController::clearBackForwardList):
2454         (LayoutTestController::pathToLocalResource):
2455         (LayoutTestController::setAcceptsEditing):
2456         (LayoutTestController::setUserStyleSheetEnabled):
2457         (LayoutTestController::setUserStyleSheetLocation):
2458         (waitToDumpWatchdogFired):
2459         (LayoutTestController::windowCount):
2460         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2461         (JSStringCopyUTF8CString):
2462         (ScriptItem::invoke):
2463
2464 2008-08-17  Geoffrey Garen  <ggaren@apple.com>
2465
2466         Reviewed by Cameron Zwarich.
2467         
2468         Updated project files to XCode 3.1.
2469
2470         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2471         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2472
2473 2008-08-15  Mark Rowe  <mrowe@apple.com>
2474
2475         Rubber-stamped by Geoff Garen.
2476
2477         <rdar://problem/6139914> Please include a _debug version of JavaScriptCore framework
2478
2479         * Scripts/check-for-global-initializers: Ignore initializers when building the debug variant.
2480
2481 2008-08-13  Simon Hausmann  <hausmann@webkit.org>
2482
2483         Rubber-stamped by Holger.
2484
2485         Revert r31585 and disable http tests for the Qt build again unless
2486         explicitly enabled.
2487
2488         Running the http tests unfortunately currently still triggers
2489         failures in non-http tests due to side-effects. Disable them by default for
2490         now, for more reliable results.
2491
2492         * Scripts/run-webkit-tests:
2493
2494 2008-08-10  Jan Michael Alonzo  <jmalonzo@webkit.org>
2495
2496         Reviewed (and updated) by Alp Toker.
2497
2498         https://bugs.webkit.org/show_bug.cgi?id=16620
2499         [GTK] Autotools make dist and make check support
2500
2501         Get make dist working.
2502
2503         Note that not all possible configurations have been tested yet.
2504
2505         * GNUmakefile.am:
2506
2507 2008-08-10  Alp Toker  <alp@nuanti.com>
2508
2509         Remove leftover qmake/GTK+ build files.
2510
2511         * DumpRenderTree/gtk/DumpRenderTree.pro: Removed.
2512         * GtkLauncher/GtkLauncher.pro: Removed.
2513
2514 2008-08-06  Chris Fleizach  <cfleizach@apple.com>
2515
2516         Reviewed by Beth Dakin
2517
2518         AX functions shouldn't return position information because it changes
2519         based on the platform
2520
2521         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2522         (AccessibilityUIElement::boundsForRange):
2523
2524 2008-08-06  Eric Seidel  <eric@webkit.org>
2525
2526         Reviewed by darin.
2527         
2528         Fix leaks seen on build-bot by fixing memory management of AccessibilityUIElement.
2529         <https://bugs.webkit.org/show_bug.cgi?id=20297>
2530         <rdar://problem/6093153>
2531         
2532         I've made AccessibilityUIElement a stack object for now.  It could be
2533         made RefCounted, but I figured that might be overkill for the moment.
2534         Essentially it's just a RefPtr itself. :)
2535         
2536         I also fixed a few typos, such as AccessibilityUIElement() instead of ~AccessibilityUIElement()
2537         which was causing additional leaks. :)
2538         
2539         I added toAXElement to remove a bunch of copy/paste code.
2540
2541         * DumpRenderTree/AccessibilityController.h:
2542         * DumpRenderTree/AccessibilityUIElement.cpp:
2543         (toAXElement):
2544         (allAttributesCallback):
2545         (attributesOfLinkedUIElementsCallback):
2546         (attributesOfChildrenCallback):
2547         (lineForIndexCallback):
2548         (boundsForRangeCallback):
2549         (childAtIndexCallback):
2550         (getRoleCallback):
2551         (getTitleCallback):
2552         (getDescriptionCallback):
2553         (getWidthCallback):
2554         (getHeightCallback):
2555         (getIntValueCallback):
2556         (getMinValueCallback):
2557         (getMaxValueCallback):
2558         (getInsertionPointLineNumberCallback):
2559         (finalize):
2560         * DumpRenderTree/AccessibilityUIElement.h:
2561         (AccessibilityUIElement::platformUIElement):
2562         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2563         (AccessibilityController::focusedElement):
2564         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2565         (AccessibilityUIElement::AccessibilityUIElement):
2566         (AccessibilityUIElement::getLinkedUIElements):
2567         (AccessibilityUIElement::getChildren):
2568         (AccessibilityUIElement::getChildAtIndex):
2569         (AccessibilityUIElement::attributesOfLinkedUIElements):
2570         (AccessibilityUIElement::attributesOfChildren):
2571
2572 2008-08-06  Eric Seidel  <eric@webkit.org>
2573
2574         Reviewed by Cameron Zwarich.
2575
2576         Speculative fix for an error I keep seeing in my Cygwin build
2577
2578         * Scripts/webkitdirs.pm: make determineConfigurationProductDir() always call determineConfiguration() even on cygwin
2579
2580 2008-08-02  Kevin Ollivier  <kevino@theolliviers.com>
2581
2582         Forgot to commit licensing correction in last commit.
2583
2584         * wx/packaging/wxWebKitInstaller.iss.in:
2585
2586 2008-08-02  Kevin Ollivier  <kevino@theolliviers.com>
2587
2588         Reviewed by Eric Seidel.
2589         
2590         Scripts for building a wxWebKit installer for wxPython on Win, eventually will
2591         be used for nightlies.
2592         
2593         https://bugs.webkit.org/show_bug.cgi?id=20036
2594
2595         * wx/packaging: Added.
2596         * wx/packaging/build-win-installer.py: Added.
2597         * wx/packaging/wxWebKitInstaller.iss.in: Added.
2598
2599 2008-07-31  Adam Roben  <aroben@apple.com>
2600
2601         Follow-up to r35500
2602
2603         * WinLauncher/WinLauncher.vcproj: Set the manifest properties for the
2604         Release configuration, too.
2605
2606 2008-07-31  Stefan Landvogt <stefan.landvogt@gmail.com>
2607
2608         Fix Bug 20245: WinLauncher does not start in WebKit-debug right out of
2609         the box
2610
2611         <https://bugs.webkit.org/show_bug.cgi?id=20245>
2612
2613         Reviewed by Adam Roben.
2614
2615         * WinLauncher/WinLauncher.vcproj: adding the following properties to
2616         WinLauncher > Properties > Manifest Tool > Isolated COM
2617         Type Library File: $(WebKitOutputDir)\lib\WebKit.tlb
2618         Component File Name: WebKit$(WebKitDLLConfigSuffix)
2619         Doing the change on "All Configurations"
2620
2621 2008-07-31  Adam Roben  <aroben@apple.com>
2622
2623         Windows build bot fix
2624
2625         * DumpRenderTree/win/ImageDiff.vcproj: Don't fail if files that only
2626         exist for people at Apple can't be found. Also updated the ICU version
2627         to 3.8.
2628
2629 2008-07-31  David Kilzer  <ddkilzer@apple.com>
2630
2631         Fix layout test results for webarchive/test-xml-stylesheet.xml
2632
2633         Reviewed by Darin Adler.
2634
2635         * DumpRenderTree/mac/DumpRenderTree.mm:
2636         (convertMIMEType): Work around the "text/xml" local file type
2637         regression in Leopard using the BUILDING_ON_LEOPARD macro.  Also
2638         stop mangling "application/x-javascript" into "text/javascript".
2639         (convertWebResourceDataToString): When checking whether to dump a
2640         resource as text, also check to see if the MIME type is in the
2641         -[WebHTMLRepresentation supportedNonImageMIMETypes] array.
2642         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added BUILDING_ON_LEOPARD
2643         macro.
2644
2645 2008-07-31  Chris Fleizach  <cfleizach@apple.com>
2646
2647         Reviewed by Alice Liu
2648
2649         Add AX support to get the bounds for a range of text
2650         Add AX support to get the child of an element
2651         Add AX support to get all the parameterized attribute names of an element
2652
2653         * DumpRenderTree/AccessibilityUIElement.cpp:
2654         (parameterizedAttributeNamesCallback):
2655         (boundsForRangeCallback):
2656         (childAtIndexCallback):
2657         (AccessibilityUIElement::getJSClass):
2658         * DumpRenderTree/AccessibilityUIElement.h:
2659         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2660         (AccessibilityUIElement::getChildAtIndex):
2661         (AccessibilityUIElement::parameterizedAttributeNames):
2662         (AccessibilityUIElement::boundsForRange):
2663
2664 2008-07-31  Erik Bunce  <elbunce@thehive.com>
2665
2666         Reviewed by Simon.
2667
2668         Make run-launcher set DYLD_LIBRARY_PATH to make things work on Mac OS X.
2669
2670         * Scripts/run-launcher:
2671
2672 2008-07-30  Jessica Kahn  <jess@apple.com>
2673
2674         Reviewed by Adam Roben.
2675
2676         Slightly stricter checking for previous change, suggested by Adam.
2677         
2678         * Scripts/extract-localizable-strings:
2679
2680 2008-07-30  Jessica Kahn  <jess@apple.com>
2681
2682         Reviewed by Darin Adler.
2683
2684         Added support for UI_STRING and UI_STRING_KEY macros with flexible prefixes.
2685         
2686         * Scripts/extract-localizable-strings:
2687
2688 2008-07-30  Anders Carlsson  <andersca@apple.com>
2689
2690         Reviewed by Adam.
2691
2692         Copy icu38* files instead of icu36* files.
2693         
2694         * DumpRenderTree/win/DumpRenderTree.vcproj:
2695
2696 2008-07-25  Jan Michael Alonzo  <jmalonzo@webkit.org>
2697
2698         DRT/Gtk build fix for r35362
2699
2700         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2701         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2702
2703 2008-07-25  Brady Eidson  <beidson@apple.com>
2704
2705         Reviewed by Sam
2706
2707         Add the ability to dump whether-or-not an element should have autocomplete enabled, 
2708         from the perspective of the WebKit API
2709
2710         * DumpRenderTree/LayoutTestController.cpp:
2711         (elementDoesAutoCompleteForElementWithIdCallback):
2712         (LayoutTestController::staticFunctions):
2713
2714         * DumpRenderTree/LayoutTestController.h:
2715         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2716         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2717         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2718         (LayoutTestController::elementDoesAutoCompleteForElementWithId): Stub for now until I can get on Windows
2719
2720 2008-07-25  Chris Fleizach  <cfleizach@apple.com>
2721
2722         Reviewed by Beth Dakin
2723
2724         Add support for AXLineForIndex and AXInsertionPointIndex through the 
2725         accessibility controller
2726
2727         * DumpRenderTree/AccessibilityUIElement.cpp:
2728         (lineForIndexCallback):
2729         (getInsertionPointLineNumberCallback):
2730         (AccessibilityUIElement::getJSClass):
2731         * DumpRenderTree/AccessibilityUIElement.h:
2732         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2733         (AccessibilityUIElement::insertionPointLineNumber):
2734         (AccessibilityUIElement::lineForIndex):
2735
2736 2008-07-25  Adam Roben  <aroben@apple.com>
2737
2738         Try to fix the Windows build bot
2739
2740         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't try to copy files
2741         that don't exist for people outside of Apple.
2742
2743 2008-07-18  Landry Breuil  <landry@openbsd.org>
2744
2745         Bug 19975: [OpenBSD] Patches to enable build of WebKit
2746
2747         <https://bugs.webkit.org/show_bug.cgi?id=19975>
2748
2749         Reviewed by David Kilzer.
2750
2751         * DumpRenderTree/DumpRenderTree.h: OpenBSD doesn't support wide characters.
2752
2753 2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>
2754
2755         CygwinDownloader fails to install necessary packages
2756         https://bugs.webkit.org/show_bug.cgi?id=20075
2757
2758         Reviewed by Mark Rowe.
2759
2760         * CygwinDownloader/cygwin-downloader.zip: Rebuilt after two broken
2761         mirrors removed in r34116. Set MIME type to application/octet-stream.
2762
2763 2008-07-16  Jon Honeycutt  <jhoneycutt@apple.com>
2764
2765         CygwinDownloader's make-zip.sh script fails
2766         https://bugs.webkit.org/show_bug.cgi?id=20074
2767
2768         Reviewed by Mark Rowe.
2769
2770         * CygwinDownloader/cygwin-downloader.py:
2771
2772 2008-07-15  Sam Weinig  <sam@webkit.org>
2773
2774         Reviewed by Anders Carlsson.
2775
2776         Refactor accessibility testing code.
2777
2778         We now have:
2779         - AccessibilityController
2780           Controller which has access to the WebView and can provide the focused element, root element
2781           and in the future, elementAtPoint.
2782
2783         - AccessibilityUIElement
2784           Object which provides access to the data provided by the Accessibility APIs.
2785
2786         * DumpRenderTree/AccessibilityController.cpp:
2787         (getFocusedElementCallback):
2788         (getRootElementCallback):
2789         (AccessibilityController::getJSClass):
2790         * DumpRenderTree/AccessibilityController.h:
2791         * DumpRenderTree/AccessibilityUIElement.cpp: Added.
2792         (allAttributesCallback):
2793         (attributesOfLinkedUIElementsCallback):
2794         (attributesOfChildrenCallback):
2795         (getRoleCallback):
2796         (getTitleCallback):
2797         (getDescriptionCallback):
2798         (getWidthCallback):
2799         (getHeightCallback):
2800         (getIntValueCallback):
2801         (getMinValueCallback):
2802         (getMaxValueCallback):
2803         (finalize):
2804         (AccessibilityUIElement::makeJSAccessibilityUIElement):
2805         (AccessibilityUIElement::getJSClass):
2806         * DumpRenderTree/AccessibilityUIElement.h: Added.
2807         (AccessibilityUIElement::platformUIElement):
2808         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2809         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2810         (AccessibilityController::AccessibilityController):
2811         (AccessibilityController::~AccessibilityController):
2812         (AccessibilityController::focusedElement):
2813         (AccessibilityController::rootElement):
2814         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added.
2815         (AccessibilityUIElement::AccessibilityUIElement):
2816         (descriptionOfValue):
2817         (attributesOfElement):
2818         (nsStringToJSStringRef):
2819         (concatenateAttributeAndValue):
2820         (AccessibilityUIElement::getLinkedUIElements):
2821         (AccessibilityUIElement::getChildren):
2822         (AccessibilityUIElement::attributesOfLinkedUIElements):
2823         (AccessibilityUIElement::attributesOfChildren):
2824         (AccessibilityUIElement::allAttributes):
2825         (AccessibilityUIElement::role):
2826         (AccessibilityUIElement::title):
2827         (AccessibilityUIElement::description):
2828         (AccessibilityUIElement::width):
2829         (AccessibilityUIElement::height):
2830         (AccessibilityUIElement::intValue):
2831         (AccessibilityUIElement::minValue):
2832         (AccessibilityUIElement::maxValue):
2833
2834 2008-07-14  Chris Fleizach  <cfleizach@apple.com>
2835
2836         Reviewed by Beth Dakin
2837
2838         Add support to get attributes of the AXChildren of an objecty
2839
2840         * DumpRenderTree/AccessibilityController.cpp:
2841         (attributesOfChildrenForFocusedElementCallback):
2842         (AccessibilityController::staticFunctions):
2843         * DumpRenderTree/AccessibilityController.h:
2844         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2845         (descriptionOfValue):
2846         (AccessibilityController::attributesOfChildrenForFocusedElement):
2847
2848 2008-07-14  Steve Falkenburg  <sfalken@apple.com>
2849
2850         Build fix.
2851
2852         * DumpRenderTree/win/DumpRenderTree.vcproj:
2853
2854 2008-07-14  Adam Roben  <aroben@apple.com>
2855
2856         Attempted Windows build fix
2857
2858         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Add
2859         CoreFoundation/OSXCompatibilityHeaders[/GNUCompatibility] to the
2860         include path.
2861
2862 2008-07-14  Alexey Proskuryakov  <ap@webkit.org>
2863
2864         Reviewed by Geoff Garen.
2865
2866         Eliminate per-thread JavaScript global data instance support and make arbitrary
2867         global data/global object combinations possible.
2868
2869         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
2870         (runJavaScriptThread): Don't pass a released context reference to JSGarbageCollect.
2871         In this scenario, it was causing crashes after each 10-20 tests, because there was a large
2872         chance for a different thread to cause GC after the context was released.
2873
2874 2008-07-11  Stephanie Lewis  <slewis@apple.com>
2875
2876         Reviewed by Darin Adler.
2877
2878         Make sure we read WebCore Leak messages.  Force full document teardown for DumpRenderTree.
2879
2880         Up timeout limit, some slower machines were timing out before crashtracer finished writing out to disk and quitting DRT.
2881
2882         * DumpRenderTree/mac/DumpRenderTree.mm:
2883         (setDefaultsToConsistentValuesForTesting):
2884         (resetWebViewToConsistentStateBeforeTesting):
2885         * Scripts/run-webkit-tests:
2886
2887 2008-07-10  Steve Falkenburg  <sfalken@apple.com>
2888
2889         Build fix.
2890
2891         * DumpRenderTree/win/DumpRenderTree.vcproj:
2892
2893 2008-07-09  Eric Seidel  <eric@webkit.org>
2894
2895         Reviewed by Mark Rowe.
2896         
2897         Print <div> backgrounds when printing from DRT.
2898
2899         * DumpRenderTree/mac/DumpRenderTree.mm:
2900         (setDefaultsToConsistentValuesForTesting):
2901
2902 2008-07-09  Eric Seidel  <eric@webkit.org>
2903
2904         Reviewed by Mark Rowe.
2905
2906         Fix copying of expected results to correct location
2907
2908         * Scripts/run-webkit-tests:
2909
2910 2008-07-09  Eric Seidel  <eric@webkit.org>
2911
2912         Reviewed by aroben.
2913
2914         * DumpRenderTree/LayoutTestController.cpp:
2915         (LayoutTestController::LayoutTestController):
2916         (dumpAsPDFCallback):
2917         (LayoutTestController::staticFunctions):
2918         * DumpRenderTree/LayoutTestController.h:
2919         (LayoutTestController::dumpAsPDF):
2920         (LayoutTestController::setDumpAsPDF):
2921         * DumpRenderTree/mac/DumpRenderTree.mm:
2922         (dumpFrameAsPDF):
2923         (dump):
2924
2925 2008-07-09  Eric Seidel  <eric@webkit.org>
2926
2927         Reviewed by weinig.
2928
2929         Add Content-Type support to DumpRenderTree and run-webkit-tests
2930         and move expected.txt files to expected.webarchive
2931         
2932         https://bugs.webkit.org/show_bug.cgi?id=15565
2933
2934         * DumpRenderTree/cg/ImageDiffCG.cpp:
2935         (compareImages):
2936         (main):
2937         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2938         (printPNG):
2939         * DumpRenderTree/mac/DumpRenderTree.mm:
2940         (dump):
2941         * Scripts/run-webkit-tests:
2942
2943 2008-07-08  Jon Honeycutt  <jhoneycutt@apple.com>
2944
2945         Reviewed by Anders.
2946
2947         Port r34988 to Mac: allow tests to define JavaScript to execute when
2948         NPP_DestroyStream or NPP_URLNotify is called.
2949
2950         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2951         (NPP_New): Remove initialization that happens in pluginAllocate. Look
2952         for new arguments onStreamDestroy and onURLNotify.
2953         (NPP_Destroy): Free onStreamDestroy and onURLNotify.
2954         (executeScript): Code moved from onStreamLoad.
2955         (NPP_NewStream): Call executeScript.
2956         (NPP_DestroyStream): Same.
2957         (NPP_URLNotify): Same.
2958
2959 2008-07-07  Beth Dakin  <bdakin@apple.com>
2960
2961         Reviewed by Anders.
2962
2963         This patch extends DRT accessibility tests to add the ability to 
2964         query the intValue, minValue, and maxValue of the focused element.
2965
2966         * DumpRenderTree/AccessibilityController.cpp:
2967         (intValueOfFocusedElementCallback):
2968         (minValueOfFocusedElementCallback):
2969         (maxValueOfFocusedElementCallback):
2970         (AccessibilityController::staticFunctions):
2971         * DumpRenderTree/AccessibilityController.h:
2972         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2973         (AccessibilityController::intValueOfFocusedElement):
2974         (AccessibilityController::minValueOfFocusedElement):
2975         (AccessibilityController::maxValueOfFocusedElement):
2976
2977 2008-07-07  Steve Falkenburg  <sfalken@apple.com>
2978
2979         Fix build.
2980
2981         * DumpRenderTree/win/ImageDiff.vcproj:
2982
2983 2008-07-02  Jon Honeycutt  <jhoneycutt@apple.com>
2984
2985         Allow tests to define JavaScript to execute when NPP_DestroyStream or
2986         NPP_URLNotify is called.
2987
2988         Reviewed by Anders.
2989
2990         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add a new
2991         property, "returnErrorFromNewStream." This is to support the test for
2992         <rdar://5983747> Safari crashes trying to load the SilverLight plugin,
2993         caused by WebKit calling NPP_DestroyStream after a plug-in returns an
2994         error from NPP_NewStream.
2995         (pluginGetProperty): 
2996         (pluginSetProperty):
2997         (pluginAllocate):
2998         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Added new
2999         members, onStreamDestroy and onURLNotify.
3000         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
3001         (NPP_New): Remove initialization of onStreamLoad; this was moved to
3002         pluginAllocate. Look for new arguments onStreamDestroy and
3003         onURLNotify, and store their values.
3004         (NPP_Destroy): Free new members.
3005         (executeScript): Code moved from onStreamLoad
3006         (NPP_NewStream): If returnErrorFromNewStream has been set to true,
3007         return a generic error code. If onStreamLoad is set, execute it as
3008         JavaScript.
3009         (NPP_DestroyStream): If onStreamDestroy is set, execute it as JS.
3010         (NPP_URLNotify): Same, for onURLNotify.
3011
3012 2008-07-02  Brady Eidson  <beidson@apple.com>
3013
3014         Reviewed by Mitz Pettel and John Sullivan
3015
3016         Add the ability to tell DRT to call stopLoading on a WebFrame inside of a didStartProvisionalLoadForFrame
3017         load delegate.
3018
3019         Required to add a layout test for the fix for <rdar://problem/5549871>
3020
3021         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3022         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): If stopProvisionalFrameLoads is set, call
3023           [WebFrame stopLoading] to test for the crash reflected in 5549871
3024
3025         All of the following are infrastructure to add the layoutTestController.setStopProvisionalFrameLoads() call:
3026         * DumpRenderTree/LayoutTestController.cpp:
3027         (LayoutTestController::LayoutTestController):
3028         (setStopProvisionalFrameLoadsCallback):
3029         (LayoutTestController::staticFunctions):
3030         * DumpRenderTree/LayoutTestController.h:
3031         (LayoutTestController::stopProvisionalFrameLoads):
3032         (LayoutTestController::setStopProvisionalFrameLoads):
3033
3034 2008-07-01  Chris Fleizach  <cfleizach@apple.com>
3035
3036         Reviewed by Beth Dakin
3037
3038         Support ability to get width and height of an element through accessibility
3039
3040         * DumpRenderTree/AccessibilityController.cpp:
3041         (widthOfFocusedElementCallback):
3042         (heightOfFocusedElementCallback):
3043         (AccessibilityController::staticFunctions):
3044         * DumpRenderTree/AccessibilityController.h:
3045         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3046         (AccessibilityController::widthOfFocusedElement):
3047         (AccessibilityController::heightOfFocusedElement):
3048
3049 2008-06-30  Chris Fleizach  <cfleizach@apple.com>
3050
3051         Reviewed by Beth Dakin
3052
3053         Support the ability to get the linked ui elements of an object
3054
3055         * DumpRenderTree/AccessibilityController.cpp:
3056         (attributesOfLinkedUIElementsForFocusedElementCallback):
3057         (AccessibilityController::staticFunctions):
3058         * DumpRenderTree/AccessibilityController.h:
3059         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3060         (AccessibilityController::attributesOfLinkedUIElementsForFocusedElement):
3061         (AccessibilityController::allAttributesOfFocusedElement):
3062         (attributesOfElement):
3063         (nsStringToJSStringRef):
3064
3065 2008-06-29  Sam Weinig  <sam@webkit.org>
3066
3067         Fix Tiger build.
3068
3069         * DumpRenderTree/mac/EventSendingController.mm:
3070         (eventTypeForMouseButtonAndAction):
3071
3072 2008-06-27  Eric Seidel  <eric@webkit.org>
3073
3074         Reviewed by darin.
3075
3076         Add multi-button mouseevent support to DRT
3077         https://bugs.webkit.org/show_bug.cgi?id=15173
3078         
3079         It's now possible to specify the mouse button with:
3080         eventSender.mouseDown(1); eventSender.mouseUp(1); etc.
3081
3082         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3083         * DumpRenderTree/mac/EventSendingController.h:
3084         * DumpRenderTree/mac/EventSendingController.mm:
3085         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3086         (+[EventSendingController webScriptNameForSelector:]):
3087         (eventTypeForMouseButtonAndAction):
3088         (-[EventSendingController updateClickCountForButton:]):
3089         (-[EventSendingController mouseDown:]):
3090         (-[EventSendingController mouseUp:]):
3091         (-[EventSendingController mouseMoveToX:Y:]):
3092         (-[EventSendingController contextClick]):
3093
3094 2008-06-28  Nikolas Zimmermann  <zimmermann@kde.org>
3095
3096         Reviewed by Oliver.
3097
3098         Copy <test>-expected.png from the right location to /tmp/layout-test-results.
3099         Use $expectedPixelDir instead of $expectedDir. Allows using SVG pixel tests again.
3100
3101         * Scripts/run-webkit-tests:
3102
3103 2008-06-27  Jan Michael Alonzo  <jmalonzo@webkit.org>
3104
3105         Reviewed by Christian Dywan.
3106
3107         [Gtk] Initialize webview settings before running DRT tests
3108         http://bugs.webkit.org/show_bug.cgi?id=19778
3109
3110         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3111         (setDefaultsToConsistentStateValuesForTesting):
3112         (main):
3113
3114 2008-06-26  Darin Adler  <darin@apple.com>
3115
3116         * Scripts/check-for-weak-vtables: Fixed comment.
3117
3118 2008-06-26  Darin Adler  <darin@apple.com>
3119
3120         * Scripts/check-for-weak-vtables: Added.
3121
3122 2008-06-26  Beth Dakin  <bdakin@apple.com>
3123
3124         Reviewed by Sam.
3125
3126         Do not include AXPosition in the dump of all of the accessibility 
3127         attributes since it is screen-specific.
3128
3129         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3130         (AccessibilityController::allAttributesOfFocusedElement):
3131
3132 2008-06-26  Beth Dakin  <bdakin@apple.com>
3133
3134         Reviewed by Anders.
3135
3136         This is a speculative fix for the failing layout test on the build 
3137         bot. It seems that the problem that the Build Bot is having is 
3138         Tiger-specific. On Tiger, [NSValue description] was not very smart. 
3139         So I replaced our call to description with a hand-rolled equivalent 
3140         that will match on both platforms. 
3141
3142         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3143         (descriptionOfValue):
3144
3145 2008-06-25  Beth Dakin  <bdakin@apple.com>
3146
3147         Reviewed by Sam Weinig.
3148
3149         This patch adds support to the AccessibilityController to query the 
3150         following attributes specifically, without a full attribute dump: 
3151         AXRole, AXTitle, and AXDescription.
3152
3153         * DumpRenderTree/AccessibilityController.cpp:
3154         (allAttributesForFocusedElementCallback):
3155         (roleOfFocusedElementCallback):
3156         (titleOfFocusedElementCallback):
3157         (descriptionOfFocusedElementCallback):
3158         (AccessibilityController::staticFunctions):
3159         * DumpRenderTree/AccessibilityController.h:
3160         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3161         (AccessibilityController::allAttributesForFocusedElement):
3162         (concatenateAttributeAndValue):
3163         (AccessibilityController::roleOfFocusedElement):
3164         (AccessibilityController::titleOfFocusedElement):
3165         (AccessibilityController::descriptionOfFocusedElement):
3166
3167 2008-06-24  Dan Bernstein  <mitz@apple.com>
3168
3169         Reviewed by Stephanie Lewis.
3170
3171         - move the linker flags from the debug configuration in the project
3172           to the shared configuration
3173
3174         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3175         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3176
3177 2008-06-24  Dan Bernstein  <mitz@apple.com>
3178
3179         - try to fix the Tiger build
3180
3181         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3182
3183 2008-06-24  Sam Weinig and Beth Dakin  <bdakin@apple.com and sam@webkit.org>
3184
3185         Reviewed by Darin Adler.
3186
3187         Fix for <rdar://problem/5884881> Make DumpRenderTree support 
3188         accessibility tests
3189
3190         This patch adds some basic support for accessibility layout tests 
3191         on the Mac.
3192
3193         * DumpRenderTree/AccessibilityController.cpp: Added.
3194         (AccessibilityController::AccessibilityController):
3195         (AccessibilityController::~AccessibilityController):
3196         (dumpCurrentAttributesCallback):
3197         (AccessibilityController::makeWindowObject):
3198         (AccessibilityController::getJSClass):
3199         (AccessibilityController::staticFunctions):
3200         * DumpRenderTree/AccessibilityController.h: Added.
3201         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3202         * DumpRenderTree/mac/AccessibilityControllerMac.mm: Added.
3203         (descriptionOfValue):
3204         (AccessibilityController::dumpCurrentAttributes):
3205         * DumpRenderTree/mac/DumpRenderTree.mm:
3206         * DumpRenderTree/mac/FrameLoadDelegate.h:
3207         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3208         (-[FrameLoadDelegate init]):
3209         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3210
3211 2008-06-24  John Sullivan  <sullivan@apple.com>
3212
3213         Reviewed by Dan Bernstein
3214
3215         * Scripts/extract-localizable-strings:
3216         add UI_STRING_LOCALIZE_LATER, LPCTSTR_UI_STRING_LOCALIZE_LATER, and LOG_WARNING to the 
3217         list of debugging macros, to avoid noise when keeping the list of localized string 
3218         exceptions up to date
3219
3220 2008-06-24  Dan Bernstein  <mitz@apple.com>
3221
3222         Rubber-stamped by Darin Adler.
3223
3224         - add a font family for testing font-weight
3225
3226         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linker
3227         flags to create data sections for the WeightWatcher fonts.
3228         * DumpRenderTree/fonts: Added.
3229         * DumpRenderTree/fonts/WebKitWeightWatcher100.ttf: Added.
3230         * DumpRenderTree/fonts/WebKitWeightWatcher200.ttf: Added.
3231         * DumpRenderTree/fonts/WebKitWeightWatcher300.ttf: Added.
3232         * DumpRenderTree/fonts/WebKitWeightWatcher400.ttf: Added.
3233         * DumpRenderTree/fonts/WebKitWeightWatcher500.ttf: Added.
3234         * DumpRenderTree/fonts/WebKitWeightWatcher600.ttf: Added.
3235         * DumpRenderTree/fonts/WebKitWeightWatcher700.ttf: Added.
3236         * DumpRenderTree/fonts/WebKitWeightWatcher800.ttf: Added.
3237         * DumpRenderTree/fonts/WebKitWeightWatcher900.ttf: Added.
3238         * DumpRenderTree/mac/DumpRenderTree.mm:
3239         (activateFonts): Renamed activateAhemFont to this and made it activate
3240         the WeightWatcher fonts in addition to Ahem.
3241         (prepareConsistentTestingEnvironment): Adjusted for the name change.
3242         * DumpRenderTree/win/DumpRenderTree.cpp:
3243         (initialize): Added the WeightWatcher fonts.
3244
3245 2008-06-20  Brent Fulgham  <bfulgham@gmail.com>
3246
3247         Reviewed by Darin Adler.
3248
3249         Extend the build-webkit (and set-webkit-configuration) script to
3250         support Cairo-based webkit builds.  (see http://bugs.webkit.org/show_bug.cgi?17952)
3251
3252         * Scripts/build-webkit:  Add --cairo-win32 to the help message
3253         * Scripts/webkitdirs.pm:  Extend the 'determinePassedConfiguration
3254           subroutine to recognize the --cairo-win32 flag.  When present,
3255           the build configuration is changed from Debug/Release to
3256           Debug_Cairo/Release_Cairo.  This flag is only active when the
3257           isCygwin() test is true.
3258
3259 2008-06-17  Dan Bernstein  <mitz@apple.com>
3260
3261         Reviewed by Justin Garcia.
3262
3263         - prefer Leopard results when running on Snow Leopard.
3264
3265         * Scripts/run-webkit-tests: Added a mapping of Snow Leopard to
3266           mac-leopard.
3267         * Scripts/webkitdirs.pm: Added isSnowLeopard().
3268
3269 2008-06-15  Darin Adler  <darin@apple.com>
3270
3271         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
3272
3273 2008-06-15  Darin Adler  <darin@apple.com>
3274
3275         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
3276
3277 2008-06-15  Darin Adler  <darin@apple.com>
3278
3279         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
3280
3281 2008-06-15  Darin Adler  <darin@apple.com>
3282
3283         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
3284
3285 2008-06-15  Darin Adler  <darin@apple.com>
3286
3287         * Scripts/do-file-rename: Updated.
3288         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
3289
3290 2008-06-15  Darin Adler  <darin@apple.com>
3291
3292         * Scripts/do-file-rename: Updated for the latest round of renaming.
3293         * Scripts/do-webcore-rename: Tweaked and reorganized a bit.
3294
3295 2008-06-15  Darin Adler  <darin@apple.com>
3296
3297         * Scripts/create-exports: Added.
3298         * Scripts/do-file-rename: Added some planned renames.
3299         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
3300
3301 2008-06-15  Darin Adler  <darin@apple.com>
3302
3303         * Scripts/do-webcore-rename: Updated for the latest round of renaming.
3304
3305 2008-06-15  Maciej Stachowiak  <mjs@apple.com>
3306
3307         Reviewed by Oliver.
3308         
3309         - rename testkjs to jsc
3310
3311         * Scripts/build-jsc: Copied from Scripts/build-testkjs.
3312         * Scripts/build-testkjs: Removed.
3313         * Scripts/run-javascriptcore-tests:
3314         * Scripts/run-jsc: Copied from Scripts/run-testkjs.
3315         * Scripts/run-sunspider:
3316         * Scripts/run-testkjs: Removed.
3317         * Scripts/sunspider-compare-results:
3318
3319 2008-06-14  Darin Adler  <darin@apple.com>
3320
3321         * Scripts/do-webcore-rename: Moved planned renames into a separate hash
3322         from the actual renames. Removed many renames that are either done or
3323         no longer planned.
3324
3325 2008-06-14  Darin Adler  <darin@apple.com>
3326
3327         * Scripts/do-webcore-rename: Fixed obvious typo.
3328
3329 2008-06-13  Darin Adler  <darin@apple.com>
3330
3331         * Scripts/make-js-test-wrappers: Added three more exceptions.
3332
3333 2008-06-10  Joerg Bornemann  <joerg.bornemann@trolltech.com>
3334
3335         Reviewed by Simon.
3336
3337         For the qmake based build make it possible to build against makespecs where
3338         QMAKE_CC is defined in a configuration file included from qmake.conf.
3339
3340         * Scripts/webkitdirs.pm: Added support for include() statements in
3341         qmake.conf.
3342
3343 2008-06-09  Alp Toker  <alp@nuanti.com>
3344
3345         gcc3/autotools build fix. Add explicit -O2 -fno-strict-aliasing to
3346         each of the tools since these are no longer set globally.
3347
3348         * GNUmakefile.am:
3349
3350 2008-06-08  Darin Adler  <darin@apple.com>
3351
3352         * Scripts/make-js-test-wrappers: Added another exception.
3353
3354 2008-06-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
3355
3356         Reviewed by Timothy.
3357
3358         Remove the --squirrelfish option from SunSpider, as it is no longer needed.
3359
3360         * Scripts/run-sunspider:
3361
3362 2008-06-05  Alp Toker  <alp@nuanti.com>
3363
3364         Build fix for r34387.
3365
3366         * GNUmakefile.am:
3367
3368 2008-06-04  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
3369
3370         Reviewed by Oliver.
3371
3372         Add an exception for Opcode.o to the global initializers check so that
3373         we can dump instruction statistics in the JavaScript virtual machine.
3374
3375         * Scripts/check-for-global-initializers:
3376
3377 2008-05-30  Steve Falkenburg  <sfalken@apple.com>
3378
3379         Generate an isolated COM manifest for registry free COM.
3380         
3381         * DumpRenderTree/win/DumpRenderTree.vcproj:
3382
3383 2008-06-02  Anders Carlsson  <andersca@apple.com>
3384
3385         Reviewed by David Hyatt and Mitz.
3386
3387         <rdar://problem/5704119> 
3388         repro crash in WebCore::RenderPart::setWidget (plugin-related?)
3389         
3390         Call -[WebView display] in the "plug-in" failed delegate method, simulating
3391         the sheet that Safari puts up.
3392         
3393         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3394         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
3395
3396 2008-05-30  Timothy Hatcher  <timothy@apple.com>
3397
3398         Made the starting line number of scripts be 1-based throughout the engine.
3399         This cleans up script line numbers so they are all consistent now.
3400
3401         Reviewed by Oliver Hunt.
3402
3403         * DumpRenderTree/mac/ObjCController.m:
3404         (runJavaScriptThread): Pass a line number of 1 instead of 0 to JSEvaluateScript.
3405         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
3406         (runJavaScriptThread): Ditto.
3407         * DumpRenderTree/win/DumpRenderTree.cpp:
3408         (runJavaScriptThread): Ditto.
3409
3410 2008-05-29  Geoffrey Garen  <ggaren@apple.com>
3411
3412         Reviewed by Adam Roben.
3413
3414         Fixed VCSUtils.pm to work with git repositories inside symlinks.
3415
3416         * Scripts/VCSUtils.pm: Compute a relative path from the git repository
3417         root, instead of the root of the filesystem, to work around a bug in
3418         abs2rel when traversing symlinked home directories.
3419
3420 2008-05-29  Kevin Ollivier  <kevino@theolliviers.com>
3421
3422         Reviewed by Darin Adler.
3423         
3424         Restore original behavior of isOSX() referring to the Mac port, not the OS itself.
3425         
3426         https://bugs.webkit.org/show_bug.cgi?id=19311
3427
3428         * Scripts/webkitdirs.pm:
3429
3430 2008-05-29  Alexey Proskuryakov  <ap@webkit.org>
3431
3432         Reviewed by Adam Roben.
3433
3434         Fix run-iexploder-tests and run-mangleme-tests to work with updated shared scripts and
3435         configuration files.
3436
3437         * Scripts/run-iexploder-tests:
3438         * Scripts/run-mangleme-tests:
3439         Renamed runSafari to not conflict with the one in webkitdirs.
3440         Added SSLCertificateFile option for httpd, as now needed.
3441
3442 2008-05-27  Kevin Ollivier  <kevino@theolliviers.com>
3443
3444         wx build fix. Update the sample app after wxWebFrame->wxWebBrowserShell rename.
3445
3446         * wx/browser/browser.cpp:
3447         (MyApp::OnInit):
3448
3449 2008-05-24  Andreia Gaita  <shana@isninja.com>
3450
3451         Reviewed by Alp Toker.
3452
3453         cygwin-downloader.py fixes.
3454
3455         Remove two non-working mirrors. Add a check for missing dependency
3456         packages to avoid bailing out on an inconsistent Cygwin package list.
3457
3458         * CygwinDownloader/cygwin-downloader.py:
3459
3460 2008-05-24  Jan Michael Alonzo  <jmalonzo@webkit.org>
3461
3462         Reviewed by Darin Adler.
3463
3464         Remove useQmake usage. QMake build doesn't support Gtk port
3465         anymore.
3466
3467         Also fix 2 occurences of "Web Kit". Should be WebKit.
3468
3469         * Scripts/build-webkit:
3470         * Scripts/run-javascriptcore-tests:
3471         * Scripts/run-launcher:
3472         * Scripts/run-webkit-tests:
3473         * Scripts/webkitdirs.pm:
3474
3475 2008-05-22  Stephanie Lewis  <slewis@apple.com>
3476
3477         Reviewed by Dan.
3478
3479         implement the beforeUnload UI delegate so that DRT will dispatch beforeunload events.
3480
3481         * DumpRenderTree/mac/UIDelegate.mm:
3482         (-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]):
3483         * DumpRenderTree/win/UIDelegate.cpp:
3484         (SearchableWebViewHost::runBeforeUnloadConfirmPanelWithMessage):
3485
3486 2008-05-21  Adele Peterson  <adele@apple.com>
3487
3488         Reviewed by Adam.
3489
3490         DumpRenderTree support for <rdar://problem/5787733> fast/dom/HTMLDocument/hasFocus.html fails on Windows
3491
3492         * DumpRenderTree/win/UIDelegate.cpp:
3493         (UIDelegate::webViewFocus): Added.
3494         (UIDelegate::webViewUnfocus): Added.
3495         * DumpRenderTree/win/UIDelegate.h:
3496
3497 2008-05-21  Mark Rowe  <mrowe@apple.com>
3498
3499         Rubber-stamped by Stephanie Lewis.
3500
3501         Set the pass_through flag on Getopt so that extra arguments can be passed through to Safari,
3502         rather than trigger an unknown argument message.  This allows run-webkit-tests to display results
3503         once more.
3504
3505         * Scripts/run-safari:
3506
3507 2008-05-21  Stephanie Lewis  <slewis@apple.com>
3508
3509         Reviewed by Maciej, Mark.
3510   
3511         arch doesn't take arguments on tiger.  expand DRT timeout for guardMalloc.
3512
3513         * Scripts/run-webkit-tests:
3514         * Scripts/webkitdirs.pm:
3515
3516 2008-05-20  Mark Rowe  <mrowe@apple.com>
3517
3518         Reviewed by Stephanie Lewis.
3519
3520         Improve the behavior of run-webkit-tests with 64-bit WebKit by automatically inferring whether to run 64-bit.
3521
3522         If --64-bit is not passed to run-webkit-tests, attempt to guess whether we should run 64-bit.
3523         This decision is made based on the 64-bitness of the built WebKit framework if it exists, and
3524         can be manually overridden by passing --64-bit or --no-64-bit.  This removes the need to always
3525         pass an argument to run-webkit-tests after having built with "make x86_64".
3526
3527         * Scripts/gdb-safari:
3528         * Scripts/run-safari:
3529         * Scripts/run-webkit-tests:
3530         * Scripts/webkitdirs.pm: Split the setting of the 64-bit flag, the determination of the
3531         preferred architecture, and exporting of the environment variables for 'arch' out into
3532         separate subroutines.
3533
3534 2008-05-20  Mark Rowe  <mrowe@apple.com>
3535
3536         Fix "make x86_64" by adding x86_64 target to WebKitTools Makefile.
3537
3538         * Makefile:
3539
3540 === End merge of squirrelfish ===
3541
3542 2008-04-14  Maciej Stachowiak  <mjs@apple.com>
3543
3544         Reviewed by Oliver.
3545         
3546         - added support for --ubench mode
3547
3548         * Scripts/run-sunspider:
3549
3550 2008-03-26  Geoffrey Garen  <ggaren@apple.com>
3551
3552         Reviewed by Oliver Hunt.
3553
3554         --squirrelfish mode: pared down tests for squirrelfish to chew on.
3555
3556         * Scripts/run-sunspider:
3557
3558 === Start merge of squirrelfish ===
3559
3560 2008-05-21  Darin Adler  <darin@apple.com>
3561
3562         * Scripts/make-js-test-wrappers: Added another exception.
3563
3564 2008-05-19  Stephanie Lewis  <slewis@apple.com>
3565
3566         Reviewed by Adam.
3567
3568         Explicitly set run mode to 32bit unless overridden to avoid
3569         confusion when running tests
3570
3571         * Scripts/build-dumprendertree:
3572         * Scripts/gdb-safari:
3573         * Scripts/run-webkit-tests:
3574         * Scripts/webkitdirs.pm:
3575
3576 2008-05-16  Stephanie Lewis  <slewis@apple.com>
3577
3578         Reviewed by Steve.
3579
3580         Print out pending unload event count. Also print out main frame name to match Mac.         
3581
3582         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3583         (descriptionSuitableForTestResult):
3584         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
3585
3586 2008-05-16  Timothy Hatcher  <timothy@apple.com>
3587
3588         Remove the Drosera project, code and resources since it has been
3589         replaced with the Web Inspector's debugger. Removes references to
3590         Drosera in various scripts and makefiles.
3591
3592         Rubber-stamped by Mark Rowe.
3593
3594         * BuildSlaveSupport/build-launcher-app:
3595         * Drosera/DebuggerDocument.cpp: Removed.
3596         * Drosera/DebuggerDocument.h: Removed.
3597         * Drosera/Drosera.icns: Removed.
3598         * Drosera/DroseraWin.make: Removed.
3599         * Drosera/English.lproj/Debugger.nib/classes.nib: Removed.
3600         * Drosera/English.lproj/Debugger.nib/info.nib: Removed.
3601         * Drosera/English.lproj/Debugger.nib/keyedobjects.nib: Removed.
3602         * Drosera/English.lproj/MainMenu.nib/classes.nib: Removed.
3603         * Drosera/English.lproj/MainMenu.nib/info.nib: Removed.
3604         * Drosera/English.lproj/MainMenu.nib/keyedobjects.nib: Removed.
3605         * Drosera/ForwardingHeaders/wtf/Assertions.h: Removed.
3606         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Removed.
3607         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Removed.
3608         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Removed.
3609         * Drosera/ForwardingHeaders/wtf/Platform.h: Removed.
3610         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Removed.
3611         * Drosera/Images/Drosera.ico: Removed.
3612         * Drosera/Images/SourceArrow.png: Removed.
3613         * Drosera/Images/SourceArrowBlank.png: Removed.
3614         * Drosera/Images/SourceArrowOpen.png: Removed.
3615         * Drosera/Images/background_stripe.png: Removed.
3616         * Drosera/Images/breakPoint.tif: Removed.
3617         * Drosera/Images/breakPointDisabled.tif: Removed.
3618         * Drosera/Images/breakpointeditor.png: Removed.
3619         * Drosera/Images/close.tif: Removed.
3620         * Drosera/Images/close_active.tif: Removed.
3621         * Drosera/Images/close_hover.tif: Removed.
3622         * Drosera/Images/console.png: Removed.
3623         * Drosera/Images/continue.tif: Removed.
3624         * Drosera/Images/fileIcon.jpg: Removed.
3625         * Drosera/Images/finishFunction.tif: Removed.
3626         * Drosera/Images/glossyFooterFill.tif: Removed.
3627         * Drosera/Images/glossyHeader.png: Removed.
3628         * Drosera/Images/glossyHeaderPressed.png: Removed.
3629         * Drosera/Images/gradientBackground.png: Removed.
3630         * Drosera/Images/gutter.png: Removed.
3631         * Drosera/Images/navLeftDisabled.png: Removed.
3632         * Drosera/Images/navLeftNormal.png: Removed.
3633         * Drosera/Images/navLeftPressed.png: Removed.
3634         * Drosera/Images/navRightDisabled.png: Removed.
3635         * Drosera/Images/navRightNormal.png: Removed.
3636         * Drosera/Images/navRightPressed.png: Removed.
3637         * Drosera/Images/pause.tif: Removed.
3638         * Drosera/Images/popUpArrows.png: Removed.
3639         * Drosera/Images/programCounter.tif: Removed.
3640         * Drosera/Images/programCounterBreakPoint.tif: Removed.
3641         * Drosera/Images/programCounterBreakPointDisabled.tif: Removed.
3642         * Drosera/Images/run.tif: Removed.
3643         * Drosera/Images/siteCollapsed.tif: Removed.
3644         * Drosera/Images/siteExpanded.tif: Removed.
3645         * Drosera/Images/siteIcon.tif: Removed.
3646         * Drosera/Images/small.ico: Removed.
3647         * Drosera/Images/splitterBar.tif: Removed.
3648         * Drosera/Images/splitterDimple.tif: Removed.
3649         * Drosera/Images/step.tif: Removed.
3650         * Drosera/Images/stepOut.tif: Removed.
3651         * Drosera/Images/stepOver.tif: Removed.
3652         * Drosera/Images/stop.tif: Removed.
3653         * Drosera/Images/toolbarBackground.png: Removed.
3654         * Drosera/Images/verticalSplitterBar.tiff: Removed.
3655         * Drosera/Images/verticalSplitterDimple.tiff: Removed.
3656         * Drosera/Makefile: Removed.
3657         * Drosera/breakpointEditor.html: Removed.
3658         * Drosera/config.h: Removed.
3659         * Drosera/console.css: Removed.
3660         * Drosera/console.html: Removed.
3661         * Drosera/console.js: Removed.
3662         * Drosera/debugger.css: Removed.
3663         * Drosera/debugger.html: Removed.
3664         * Drosera/debugger.js: Removed.
3665         * Drosera/mac/DebuggerApplication.h: Removed.
3666         * Drosera/mac/DebuggerApplication.mm: Removed.
3667         * Drosera/mac/DebuggerClient.h: Removed.
3668         * Drosera/mac/DebuggerClient.mm: Removed.
3669         * Drosera/mac/DebuggerDocumentPlatform.mm: Removed.
3670         * Drosera/mac/Drosera.xcodeproj/project.pbxproj: Removed.
3671         * Drosera/mac/Info.plist: Removed.
3672         * Drosera/mac/LauncherInfo.plist: Removed.
3673         * Drosera/mac/Makefile: Removed.
3674         * Drosera/mac/ServerConnection.h: Removed.
3675         * Drosera/mac/ServerConnection.mm: Removed.
3676         * Drosera/mac/launcher.m: Removed.
3677         * Drosera/mac/main.m: Removed.
3678         * Drosera/viewer.css: Removed.
3679         * Drosera/viewer.html: Removed.
3680         * Drosera/win/BaseDelegate.h: Removed.
3681         * Drosera/win/DebuggerClient.cpp: Removed.
3682         * Drosera/win/DebuggerClient.h: Removed.
3683         * Drosera/win/DebuggerDocumentPlatform.cpp: Removed.
3684         * Drosera/win/Drosera.cpp: Removed.
3685         * Drosera/win/Drosera.h: Removed.
3686         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed.
3687         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed.
3688         * Drosera/win/DroseraPrefix.cpp: Removed.
3689         * Drosera/win/DroseraPrefix.h: Removed.
3690         * Drosera/win/Info.plist: Removed.
3691         * Drosera/win/ServerConnection.cpp: Removed.
3692         * Drosera/win/ServerConnection.h: Removed.
3693         * Drosera/win/resource.h: Removed.
3694         * Makefile:
3695         * Scripts/build-drosera: Removed.
3696         * Scripts/gdb-drosera: Removed.
3697         * Scripts/run-drosera: Removed.
3698         * Scripts/run-drosera-nightly.cmd: Removed.
3699         * Scripts/run-drosera.cmd: Removed.
3700         * Scripts/webkitdirs.pm:
3701
3702 2008-05-15  Stephanie Lewis  <slewis@apple.com>
3703
3704         Reviewed by Anders.
3705
3706         Dump the unload count for a frame after parsing is finished.
3707
3708         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3709         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3710
3711 2008-05-15  Alexey Proskuryakov  <ap@webkit.org>
3712
3713         Reviewed by Dan Bernstein.
3714
3715         https://bugs.webkit.org/show_bug.cgi?id=10707
3716         DumpRenderTree should not be able to access non-local resources
3717
3718         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3719         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3720         Block them, and complain.
3721
3722 2008-05-15  Kevin Ollivier  <kevino@theolliviers.com>
3723
3724         wx build fix. Update the version of libpng to download and instsall.
3725
3726         * wx/install-unix-extras:
3727
3728 2008-05-14  Julien Chaffraix  <jchaffraix@webkit.org>
3729
3730         Reviewed by Eric.
3731
3732         - isDarwin() and isCygwin() returned an empty string if the platform equality check fails.
3733           We now force the return value to be numeric.
3734
3735         - Removed platform checks as it was a work around the previous issue.
3736
3737         - Replaced isDarwin() by isOSX() as they have now the same behaviour.
3738
3739         * Scripts/build-webkit:
3740         * Scripts/webkitdirs.pm:
3741
3742 2008-05-12  Adam Roben  <aroben@apple.com>
3743
3744         Support for testing NPN_PostURL
3745
3746         Reviewed by Anders Carlsson.
3747
3748         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3749         (toCString): Added this helper function.
3750         (testPostURLFile): Added. Writes the passed-in content to the
3751         passed-in file and calls NPN_PostURL with the passed-in URL and
3752         target.
3753         (pluginInvoke): Added a case for testPostURLFile.
3754         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3755         (followShortcuts): Changed to allow paths that don't yet exist.
3756
3757 2008-05-12  Mark Rowe  <mrowe@apple.com>
3758
3759         Reviewed by Sam Weinig.
3760
3761         Minor cleanup of the DRT Xcode project.
3762
3763         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:  Use GCC_OPTIMIZATION_LEVEL rather than
3764         OPTIMIZATION_CFLAGS.  Don't include Info.plist in the "Copy Bundle Resources" build phase as it does
3765         not need to be there.
3766
3767 2008-05-12  Anders Carlsson  <andersca@apple.com>
3768
3769         Reviewed by Adam.
3770
3771         Add support for testing application caches.
3772         
3773         * DumpRenderTree/mac/DumpRenderTree.mm:
3774         (dumpRenderTree):
3775         Empty the cache.
3776         
3777         (resetWebViewToConsistentStateBeforeTesting):
3778         Turn on support for the application cache.
3779
3780 2008-05-09  Mark Rowe  <mrowe@apple.com>
3781
3782         Reviewed by Anders Carlsson.
3783
3784         Update TestNetscapePlugIn to build 64-bit using the Cocoa event model.
3785
3786         It currently does not attempt to print events which means that plugins/mouse-events.html
3787         will fail when run 64-bit.  All other tests that use this plugin pass.
3788
3789         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3790         (testGetIntIdentifier):
3791         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3792         (NPP_New):
3793         (NPP_HandleEvent):
3794
3795 2008-05-09  Brady Eidson  <beidson@apple.com>
3796
3797         Reviewed by Adam Roben
3798
3799         Explicitly call shutDownWebKit() before quitting.
3800
3801         * Drosera/win/Drosera.cpp:
3802         (_tWinMain):
3803
3804         * DumpRenderTree/win/DumpRenderTree.cpp:
3805         (main):
3806
3807 2008-05-09  Mark Rowe  <mrowe@apple.com>
3808
3809         Fix the Tiger build of Drosera.
3810
3811         * Drosera/config.h: Define BUILDING_ON_TIGER when building on Tiger.
3812
3813 2008-05-09  Sam Weinig  <sam@webkit.org>
3814
3815         Rubber-stamped by Mark Rowe.
3816
3817         Remove the ENABLE_CROSS_DOCUMENT_MESSAGING #ifdefs.
3818
3819         * Scripts/build-webkit:
3820
3821 2008-05-08  Mark Rowe  <mrowe@apple.com>
3822
3823         Another attempt at a Tiger build fix.
3824
3825         Use DumpRenderTreeMac.h rather than DumpRenderTree.h as DumpRenderTreePasteboard is not an Obj-C++ file.
3826
3827         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3828
3829 2008-05-08  Mark Rowe  <mrowe@apple.com>
3830
3831         Tiger build fix.  Include DumpRenderTree.h so that BUILDING_ON_TIGER will be defined.
3832
3833         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3834
3835 2008-05-08  Mark Rowe  <mrowe@apple.com>
3836
3837         Reviewed by Oliver Hunt and Dan Bernstein.
3838
3839         Update DumpRenderTree to build 64-bit.
3840
3841         The three major changes here are:
3842         1) Use NSInteger in the appropriate places.
3843         2) Use ColorSync API that is available in 64-bit to switch display profiles.
3844         3) Use method-swizzling to achieve similar results to class posing when using the Obj-C 2.0 runtime.
3845
3846         The build of DumpRenderTree will still fail in 64-bit for now as the TestNetscapePlugIn target also
3847         needs updated to successfully build.
3848
3849         * DumpRenderTree/mac/Configurations/Base.xcconfig: Don't prevent Xcode from building 64-bit.
3850         * DumpRenderTree/mac/DumpRenderTree.mm:
3851         (swizzleAllMethods):
3852         (poseAsClass):
3853         (prepareConsistentTestingEnvironment):
3854         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3855         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3856         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3857         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3858         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3859         (restoreColorSpace):
3860         (failedGettingCurrentProfile):
3861         (setDefaultColorProfileToRGB):
3862
3863 2008-05-08  Mark Rowe  <mrowe@apple.com>
3864
3865         Reviewed by Darin Adler.
3866
3867         Clean up Drosera so that it will build 64-bit.
3868
3869         * Drosera/mac/DebuggerApplication.mm:
3870         (-[DebuggerApplication numberOfRowsInTableView:]): Use NSInteger rather than int.
3871         (-[DebuggerApplication tableView:objectValueForTableColumn:row:]): Ditto.
3872         * Drosera/mac/Drosera.xcodeproj/project.pbxproj: Use the default value for VALID_ARCHS.
3873
3874 2008-05-07  David Kilzer  <ddkilzer@apple.com>
3875
3876         Use File::Find and Getopt::Long in make-js-test-wrappers
3877
3878         Reviewed by Darin Adler.
3879
3880         * Scripts/make-js-test-wrappers:
3881         - Updated Apple copyright statement.
3882         - Added command-line switch parsing and -h|--help switch.
3883         - Allowed user to pass list of files/directories on which to do
3884           a restricted search for TEMPLATE.html files.  The default
3885           behavior is still to search the entire LayoutTests directory.
3886         - Removed duplicate 'use strict' statement.
3887         - Replaced use of `find` statements with File::Find::find().
3888         - Remove unneeded chomp() calls now that we use File::Find.
3889         (directoryFilter): Added.  Filters .svn directories when used
3890         with File::Find::find().
3891         (findTemplateFiles): Added.  Returns a list of TEMPLATE.html
3892         files found.
3893
3894 2008-05-05  Steve Falkenburg  <sfalken@apple.com>
3895
3896         Copy dependencies of ImageDiff, DumpRenderTree in post-build step.
3897
3898         * DumpRenderTree/win/DumpRenderTree.vcproj:
3899         * DumpRenderTree/win/ImageDiff.vcproj:
3900
3901 2008-05-05  Adele Peterson  <adele@apple.com>
3902
3903         Reviewed by Adam.
3904
3905         Look for the right ImageDiff executable for debug builds.
3906
3907         * Scripts/run-webkit-tests:
3908
3909 2008-05-05  Darin Adler  <darin@apple.com>
3910
3911         * Scripts/run-webkit-tests: Ignore a Java leak showing up in the WebKit
3912         leak tests.
3913
3914 2008-05-05  Ariya Hidayat  <ariya.hidayat@trolltech.com>
3915
3916         Reviewed by Simon.
3917
3918         In the Qt's DumpRenderTree, adjust the web view properly (because W3C SVG 
3919         tests expect to be 480x360)
3920
3921         * DumpRenderTree/qt/DumpRenderTree.cpp:
3922         (WebCore::DumpRenderTree::open):
3923
3924 2008-05-02  Dan Bernstein  <mitz@apple.com>
3925
3926         Reviewed by Adam Roben.
3927
3928         - add an option to svn-apply to set the reviewer name in change logs
3929
3930         * Scripts/svn-apply: Added a [-r|--reviewer name] option.
3931
3932 2008-05-01  David Kilzer  <ddkilzer@apple.com>
3933
3934         Clean up configuration usage in run-webkit-tests
3935
3936         Reviewed by Adam.
3937
3938         * Scripts/run-webkit-tests: Parse configuration switches using
3939         passedConfiguration() from webkitdirs.pm like every other script.
3940         Note that we must still call setConfiguration() afterwards in
3941         case the --configuration switch was used.  Use $configurationOption
3942         when running build-dumprendertree instead of recreating the switch.
3943
3944 2008-04-29  Adam Roben  <aroben@apple.com>
3945
3946         Restore the beloved COMPtr::operator&
3947
3948 2008-04-29  Adam Roben  <aroben@apple.com>
3949
3950         Windows build fixes
3951
3952         Replace COMPtr::operator& with COMPtr::adoptionPointer.
3953
3954 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
3955
3956         Reviewed by Darin Adler.
3957
3958         Fix run-webkit-tests --threading
3959         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
3960         Proxy server issue in Sunday's Nightly
3961
3962         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
3963         (runJavaScriptThread):
3964         (startJavaScriptThreads):
3965         (stopJavaScriptThreads):
3966         Spawned threads were immediately detached, unlike the original ones, so joining them
3967         made no sense. Now, all threads are created detached, and stopJavaScriptThreads() just
3968         waits for them all to exit.
3969
3970 2008-04-28  Holger Hans Peter Freyther  <zecke@selfish.org>
3971
3972         Reviewed by Simon.
3973
3974         Reset dumping resource load callbacks to false for the next test
3975         
3976
3977         * DumpRenderTree/qt/jsobjects.cpp:
3978         (LayoutTestController::reset):
3979
3980 2008-04-28  Tor Arne Vestbø  <tavestbo@trolltech.com>
3981
3982         Reviewed by Simon.
3983
3984         Adapt to the latest API changes in WebKit/qt/Api.
3985
3986         * DumpRenderTree/qt/DumpRenderTree.cpp:
3987         (WebCore::DumpRenderTree::DumpRenderTree):
3988         * DumpRenderTree/qt/jsobjects.cpp:
3989
3990 2008-04-26  Robin Dunn  <robin@alldunn.com>
3991
3992         Reviewed by Kevin Ollivier.
3993         
3994         Delete the DerivedSources after make clean has been done so that the DerivedSources
3995         don't get re-created. Also, use the proper extension for the Win wxPython extension.
3996         
3997         https://bugs.webkit.org/show_bug.cgi?id=18756
3998
3999         * wx/build-wxwebkit:
4000
4001 2008-04-26  Adam Barth <hk9565@gmail.com>
4002
4003         Reviewed by Adam Roben and Sam Weinig.
4004
4005         Updates LayoutTestController to use host instead of domain.
4006
4007         Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
4008
4009         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4010         (LayoutTestController::setDatabaseQuota):
4011         * DumpRenderTree/mac/UIDelegate.mm:
4012         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
4013
4014 2008-04-26  Kevin Ollivier  <kevino@theolliviers.com>
4015
4016         wx build fix. Need the latest libpng. (Somehow my initial test passed without it.)
4017
4018         * wx/install-unix-extras:
4019
4020 2008-04-26  Robin Dunn  <robin@alldunn.com>
4021
4022         Reviewed by Kevin Ollivier.
4023         
4024         Allow the user to set the path to SWIG using an environment variable.
4025         
4026         https://bugs.webkit.org/show_bug.cgi?id=18660
4027
4028         * wx/build-wxwebkit:
4029
4030 2008-04-26  Kevin Ollivier  <kevino@theolliviers.com>
4031
4032         wx build fix. Download the latest libpng version for building the
4033         dependencies.
4034
4035         * wx/install-unix-extras:
4036
4037 2008-04-25  Holger Hans Peter Freyther  <zecke@selfish.org>
4038
4039         Reviewed by Simon.
4040
4041         Implement dumping of resource load callbacks to pass http/tests/xmlhttprequest/abort-should-cancel-load.html
4042         
4043         Similar to Editing and Frameloading we do the dumping within WebCore
4044         
4045
4046         * DumpRenderTree/qt/jsobjects.cpp:
4047         (LayoutTestController::dumpResourceLoadCallbacks):
4048         * DumpRenderTree/qt/jsobjects.h:
4049
4050 2008-04-24  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
4051
4052         Reviewed by Maciej Stachowiak.
4053
4054         http://bugs.webkit.org/show_bug.cgi?id=18485
4055         Typo and documentation fix for build-webkit
4056
4057         * Scripts/build-webkit:
4058
4059 2008-04-24  Anders Carlsson  <andersca@apple.com>
4060
4061         Reviewed by Sam.
4062
4063         Don't call fprintf from the signal handler.
4064         
4065         * DumpRenderTree/mac/DumpRenderTree.mm:
4066         (crashHandler):
4067
4068 2008-04-23  Adam Roben  <aroben@apple.com>
4069
4070         Make crashes be reported as crashes, not hangs
4071
4072         Reviewed by David Kilzer.
4073
4074         * Scripts/run-webkit-tests:
4075         (top level): Use the new status field of the output from
4076         readFromDumpToolWithTimer to determine if the test crashed or hung.
4077         (sub readFromDumpToolWithTimer):
4078           - If we fail to read a line and $! is not EAGAIN, then we've crashed
4079             and should not try to read any more.
4080           - Changed the timedout field to a more general status field.
4081
4082 2008-04-22  David Kilzer  <ddkilzer@apple.com>
4083
4084         Bug 18683: update-webkit returns 0 even if it fails
4085
4086         <https://bugs.webkit.org/show_bug.cgi?id=18683>
4087
4088         Reviewed by Mitz Pettel.
4089
4090         * Scripts/update-webkit:
4091         (runSvnUpdate): Die if close() fails.
4092
4093 2008-04-21  Adam Roben  <aroben@apple.com>
4094
4095         Flush stdout/stderr after printing every #EOF separator
4096
4097         This fixes a hang when running the pixel tests on Windows
4098
4099         Reviewed by Mitz Pettel.
4100
4101         * DumpRenderTree/win/DumpRenderTree.cpp:
4102         (dump):
4103         (main): We don't have to flush stdout/stderr in the arguments loop
4104         anymore, as runTest flushes for us.
4105
4106 2008-04-21  Adam Roben  <aroben@apple.com>
4107
4108         Fix pixel tests
4109
4110         * Scripts/run-webkit-tests:
4111         (sub readFromDumpToolWithTimer): Use readline instead of read to
4112         ensure that we don't read past the #EOF marker.
4113
4114 2008-04-21  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
4115
4116         Reviewed by Simon.
4117
4118         Build fix for Qt 4.3
4119
4120         * When building WebCore/internal make sure the QT_[BEGIN,END]_NAMESPACE is
4121         always defined. Do this by adding defines to the compiler line
4122
4123         * DumpRenderTree/qt/DumpRenderTree.pro:
4124
4125 2008-04-19  Mike Hommey  <glandium@debian.org>
4126
4127         Reviewed by Alp Toker.
4128
4129         Don't build GtkLauncher and DumpRenderTree with rpath.
4130
4131         * GNUmakefile.am:
4132
4133 2008-04-18  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
4134
4135         Reviewed by Alp Toker.
4136
4137         http://bugs.webkit.org/show_bug.cgi?id=16620
4138         [GTK] Autotools make dist and make check support
4139
4140         Cleanups.
4141
4142         * GNUmakefile.am:
4143
4144 2008-04-18  Adam Roben  <aroben@apple.com>
4145
4146         Drop the hang timer to 30 seconds
4147
4148         This matches what DRT/mac was using.
4149
4150         Reviewed by Mitz Pettel.
4151
4152         * Scripts/run-webkit-tests:
4153
4154 2008-04-18  Adam Roben  <aroben@apple.com>
4155
4156         Get rid of DRT's Watchdog
4157
4158         run-webkit-tests now detects hangs and samples DRT as needed.
4159
4160         Reviewed by Mitz Pettel.
4161
4162         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Removed
4163         Watchdog* files from the project.
4164         * DumpRenderTree/Watchdog.cpp: Removed.
4165         * DumpRenderTree/Watchdog.h: Removed.
4166         * DumpRenderTree/mac/DumpRenderTree.mm: Removed uses of Watchdog
4167         (dumpRenderTree):
4168         (runTest):
4169         * DumpRenderTree/mac/WatchdogMac.h: Removed.
4170         * DumpRenderTree/mac/WatchdogMac.mm: Removed.
4171         * Scripts/run-webkit-tests:
4172         (sub testCrashedOrTimedOut): Call sampleDumpTool() if we timed out.
4173         (sub sampleDumpTool): Added. Writes a sample report to
4174         ~/Library/Logs/DumpRenderTree/HangReport.txt.
4175
4176 2008-04-18  Simon Hausmann  <hausmann@webkit.org>
4177
4178         Reviewed by Holger.
4179
4180         Adapt to the API changes in WebKit/qt
4181
4182         * DumpRenderTree/qt/DumpRenderTree.cpp:
4183         (WebCore::WebPage::WebPage):
4184         (WebCore::DumpRenderTree::DumpRenderTree):
4185         (WebCore::DumpRenderTree::initJSObjects):
4186         (WebCore::DumpRenderTree::dumpFramesAsText):
4187         (WebCore::DumpRenderTree::dump):
4188
4189 2008-04-17  Adam Roben  <aroben@apple.com>
4190
4191         Fix many tests on Windows
4192
4193         * Scripts/run-webkit-tests:
4194         (readFromDumpToolWithTimer):
4195          - Use read instead of sysread to ensure that we don't interfere with
4196            other uses of buffered IO in this script.
4197         (setFileHandleNonBlocking): Actually set the filehandle to blocking
4198         when specified.
4199
4200 2008-04-17  Adam Roben  <aroben@apple.com>
4201
4202         Fix ~10 tests
4203
4204         * Scripts/run-webkit-tests: Only remove the newline after #EOF, not
4205         whatever newline happens to be at the end of what we've read.
4206
4207 2008-04-17  Adam Roben  <aroben@apple.com>
4208
4209         Remove DRT/win's hang timer
4210
4211         run-webkit-tests takes care of this for us now
4212
4213         Reviewed by Anders Carlsson.
4214
4215         * DumpRenderTree/win/DumpRenderTree.cpp:
4216
4217 2008-04-17  Adam Roben  <aroben@apple.com>
4218
4219         Don't wait for the hang timer twice in the case of a hang
4220
4221         Previously we'd wait for a hang while reading both stdout and stderr
4222         from DRT. Now we'll only wait for one or the other.
4223
4224         Reviewed by Anders Carlsson.
4225
4226         * Scripts/run-webkit-tests:
4227         (top level): Don't wait for stderr to time out if stdout already timed
4228         out.
4229         (readFromDumpToolWithTimer): If $dontWaitForTimeOut is true, quit
4230         after the first read that returns no data.
4231
4232 2008-04-17  Adam Roben  <aroben@apple.com>
4233
4234         Don't throw away the output from timed out tests
4235
4236         Reviewed by Anders Carlsson.
4237
4238         * Scripts/run-webkit-tests:
4239         (top level): Updated for changes to readFromDumpToolWithTimer.
4240         (readFromDumpToolWithTimer): Return a hash that contains both the
4241         output and whether or not the test timed out.
4242
4243 2008-04-17  Adam Roben  <aroben@apple.com>
4244
4245         Make the hang timer 60 seconds
4246
4247         * Scripts/run-webkit-tests:
4248
4249 2008-04-17  Adam Roben  <aroben@apple.com>
4250
4251         Get rid of carriage returns in DRT/win's stderr
4252
4253         Reviewed by Eric Seidel.
4254
4255         * DumpRenderTree/win/DumpRenderTree.cpp:
4256         (main): Mark stderr as binary like we already do for stdout.
4257
4258 2008-04-17  Adam Roben  <aroben@apple.com>
4259
4260         Fix Bug 17678: run-webkit-tests should have a watchdog timer (and
4261         timeout long tests)
4262
4263         <https://bugs.webkit.org/show_bug.cgi?id=17678>
4264
4265         We now abort tests that take longer than 60 seconds to produce output.
4266         This matches the watchdog timer in DRT/mac and DRT/win (which we can
4267         now remove).
4268
4269         Reviewed by Eric Seidel.
4270
4271         * Scripts/run-webkit-tests:
4272         (top level): Read DRT's output using the new readFromDumpToolWithTimer
4273         subroutine. If readFromDumpToolWithTimer returns undefined it means
4274         the test timed out, so we register the test as a hang and move on.
4275         (sub testCrashedOrTimedOut): Renamed from testCrashed. Now handles
4276         both crashed and timed out tests. If the test timed out, we kill DRT
4277         before returning.
4278         (sub linksForTimedOutTest): Added. We don't have any output to link to for
4279         tests that timed out.
4280         (sub recordActualResultsAndDiff): Don't call length on undefined.
4281         (sub readFromDumpToolWithTimer): Added. Performs non-blocking reads
4282         from a filehandle until an #EOF is reached or
4283         $maximumSecondsWithoutOutput have elapsed.
4284         (sub setFileHandleNonBlocking): Marks a filehandle as blocking or
4285         non-blocking.
4286
4287 2008-04-17  Adam Roben  <aroben@apple.com>
4288
4289         Refactor test results page generation
4290
4291         Reviewed by Eric Seidel.
4292
4293         * Scripts/run-webkit-tests:
4294         (sub htmlForResultsSection): Added. Takes a set of tests, a
4295         description, and a subroutine to generate the links for each test, and
4296         creates a HTML string containing a table of the tests and their
4297         links.
4298         (sub linksForExpectedAndActualResults): Added. Replaces the
4299         htmlForExpectedAndActualResults subroutine.
4300         (sub linksForMismatchTest): Added.
4301         (sub linksForCrashOrErrorTest): Added.
4302         (sub linksForNewTest): Added.
4303
4304 2008-04-17  Adam Roben  <aroben@apple.com>
4305
4306         Print the extension for all tests in the test results page
4307
4308         Reviewed by Eric Seidel.
4309
4310         * Scripts/run-webkit-tests:
4311
4312 2008-04-17  Adam Roben  <aroben@apple.com>
4313
4314         Move code that counts finished tests into a subroutine
4315
4316         Reviewed by Eric Seidel.