46f0116457a375e3cb991e667a0334b9eff06a52
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-11-18  Tony Chang  <tony@chromium.org>
2
3         Reviewed by Adam Barth.
4
5         run platform/chromium/plugins/refcount-leaks.html on all platforms
6         https://bugs.webkit.org/show_bug.cgi?id=49485
7
8         Add PluginObject.testObjectCount which returns the number of allocated
9         TestObjects. Add PluginObject.testCreateTestObject which allocates
10         and returns a TestObject.
11
12         Add TestObject.refCount which returns the number of refs on the
13         TestObject.
14
15         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
16         (pluginGetProperty):
17         (pluginInvoke):
18         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
19         (getTestObjectCount):
20         (testAllocate):
21         (testDeallocate):
22         (testGetProperty):
23         (testScriptObjectInvoke): Release a ref to a plugin object that was
24             previously leaked.
25         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
26
27 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
28
29         Reviewed by Adam Roben.
30
31         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
32         https://bugs.webkit.org/show_bug.cgi?id=49711
33
34         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
35         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
36         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
37         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
38         * record-memory-win/record-memory-win-common.vsprops: Added.
39         * record-memory-win/record-memory-win.vcproj:
40
41 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
42
43         Reviewed by Csaba Osztrogonác.
44
45         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
46
47         * MiniBrowser/qt/BrowserWindow.cpp:
48         (BrowserWindow::updateUserAgentList):
49
50 2010-11-17  Adam Roben  <aroben@apple.com>
51
52         Don't trigger Windows builds when chromium-win test results change
53
54         Reviewed by Mark Rowe.
55
56         * Scripts/webkitpy/common/config/build.py:
57         (_should_file_trigger_build): Changed the regular expression used to
58         search for directory names to only consider full directory names,
59         rather than matching directory names where the string we care about is
60         a suffix of the name.
61
62         * Scripts/webkitpy/common/config/build_unittest.py:
63         (ShouldBuildTest): Added a test.
64
65 2010-11-17  Hayato Ito  <hayato@chromium.org>
66
67         Reviewed by Shinichiro Hamaji.
68
69         Remove a uri member from TestInput class.
70
71         https://bugs.webkit.org/show_bug.cgi?id=49691
72
73         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
74         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
75
76 2010-11-17  Adam Roben  <aroben@apple.com>
77
78         Move FindSafari's settings into a vsprops file
79
80         Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
81
82         Reviewed by Steve Falkenburg.
83
84         * FindSafari/FindSafari.vcproj:
85         * FindSafari/FindSafariCommon.vsprops: Added.
86
87 2010-11-17  Adam Roben  <aroben@apple.com>
88
89         Use a minimum font size of 0 in DRT on Windows
90
91         This is the Windows equivalent of r72164.
92
93         Rubber-stamped by Dave Hyatt.
94
95         * DumpRenderTree/win/DumpRenderTree.cpp:
96         (resetDefaultsToConsistentValues):
97
98 2010-11-17  Dirk Pranke  <dpranke@chromium.org>
99
100         Reviewed by Andreas Kling.
101
102         webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
103         https://bugs.webkit.org/show_bug.cgi?id=49639
104
105         * Scripts/webkitpy/common/checkout/scm.py:
106
107 2010-11-17  Mihai Parparita  <mihaip@chromium.org>
108
109         Reviewed by Tony Chang.
110
111         Rebaseline server: add loupe for image diffs
112         https://bugs.webkit.org/show_bug.cgi?id=49692
113         
114         Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
115         enlarged area of the expected, actual and diff images side by side.
116
117         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
118         * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
119         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
120         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
121
122 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
123
124         Reviewed by Adam Roben.
125
126         WebKitLauncherWin should use vsprops for shared build settings
127         https://bugs.webkit.org/show_bug.cgi?id=49696
128
129         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
130         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
131
132 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
133
134         Reviewed by Adam Roben.
135
136         WinLauncher should use vsprops for shared build settings
137         https://bugs.webkit.org/show_bug.cgi?id=49695
138
139         * WinLauncher/WinLauncher.cpp:
140         (_tWinMain):
141         (PrintView):
142         (WndProc):
143         (MyEditProc):
144         * WinLauncher/WinLauncher.vcproj:
145         * WinLauncher/WinLauncherCommon.vsprops: Added.
146
147 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
148
149         Delete unused file unintentionally added in last change.
150
151         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
152
153 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
154
155         Reviewed by Adam Roben.
156
157         DumpRenderTree on Windows should use a vsprops file for shared project settings
158         https://bugs.webkit.org/show_bug.cgi?id=49690
159
160         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
161         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
162         * DumpRenderTree/win/DumpRenderTree.vcproj:
163         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
164         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
165         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
166         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
167         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
168         * DumpRenderTree/win/ImageDiff.vcproj:
169         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
170
171 2010-11-17  Hayato Ito  <hayato@chromium.org>
172
173         Refactor TestTypeBase.compare_output().
174
175         Introduce a TestOutput class and update compare_output() of each test
176         types so that they can take both actual and expected TestOutput objects.
177
178         https://bugs.webkit.org/show_bug.cgi?id=49431
179
180         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
181         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
182         * Scripts/webkitpy/layout_tests/port/base.py:
183         * Scripts/webkitpy/layout_tests/port/chromium.py:
184         * Scripts/webkitpy/layout_tests/port/dryrun.py:
185         * Scripts/webkitpy/layout_tests/port/test.py:
186         * Scripts/webkitpy/layout_tests/port/webkit.py:
187         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
188         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
189         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
190         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
191
192 2010-11-17  Adam Roben  <aroben@apple.com>
193
194         Make each Windows Test builder use the same OS for all its slaves
195
196         Currently each WebKit1 Windows Test builder has one Windows XP slave
197         and one Windows 7 slave. Having different OSes in a single builder
198         meant that the builders would alternate between red and green when
199         there were OS-specific failures.
200
201         Fixes <http://webkit.org/b/49688> Windows Test builders alternate
202         between red and green because of multiple OS versions
203
204         Reviewed by Mark Rowe.
205
206         * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
207         "Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
208         Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
209         (WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
210         builders for the two WebKit1 builders so that they would all use the
211         appropriate OS.
212
213 2010-11-17  James Robinson  <jamesr@chromium.org>
214
215         Reviewed by Dan Bernstein.
216
217         [chromium] Set minimum font size to 0 for DRT
218         https://bugs.webkit.org/show_bug.cgi?id=49677
219
220         Followup for http://trac.webkit.org/changeset/72141.
221
222         Test: http/tests/misc/acid3.html
223
224         * DumpRenderTree/chromium/WebPreferences.cpp:
225         (WebPreferences::reset):
226
227 2010-11-17  Andras Becsi  <abecsi@webkit.org>
228
229         Unreviewed build fix.
230
231         [Qt] Add missing file I forgot in r72220.
232
233         * MiniBrowser/MiniBrowser.qrc: Added.
234
235 2010-11-17  Andras Becsi  <abecsi@webkit.org>
236
237         Reviewed by Andreas Kling.
238
239         [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
240         https://bugs.webkit.org/show_bug.cgi?id=49627
241
242         Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.
243
244         * MiniBrowser/MiniBrowser.qrc: Added.
245         Add it here to prevent qmake from detecting it
246         since it needs to be copied to the build directory.
247         * MiniBrowser/qt/BrowserWindow.cpp:
248         (BrowserWindow::BrowserWindow):
249         (BrowserWindow::updateUserAgentList):
250         (BrowserWindow::showUserAgentDialog):
251         * MiniBrowser/qt/BrowserWindow.h:
252         * MiniBrowser/qt/MiniBrowser.pro:
253
254 2010-11-17  Adam Roben  <aroben@apple.com>
255
256         Make changes to the Mac WebKit2 Skipped file trigger Windows builds
257
258         We use that file on Windows!
259
260         Fixes <http://webkit.org/b/49643> Changes to
261         LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
262
263         Reviewed by Steve Falkenburg.
264
265         * Scripts/webkitpy/common/config/build.py:
266         (_should_file_trigger_build): Added the mac-wk2 directory and make it
267         trigger builds on SnowLeopard and Windows.
268
269         * Scripts/webkitpy/common/config/build_unittest.py:
270         (ShouldBuildTest.test_should_build): Added a test.
271
272 2010-11-17  Satish Sampath  <satish@chromium.org>
273
274         Reviewed by Jeremy Orlow.
275
276         Clear the speech input mock explicitly before each test.
277         https://bugs.webkit.org/show_bug.cgi?id=49660
278
279         * DumpRenderTree/chromium/LayoutTestController.cpp:
280         (LayoutTestController::setMockSpeechInputResult):
281         * DumpRenderTree/chromium/LayoutTestController.h:
282         * DumpRenderTree/chromium/WebViewHost.cpp:
283         (WebViewHost::speechInputController):
284         (WebViewHost::reset): Invoke speech input mock's clearResults method.
285         * DumpRenderTree/chromium/WebViewHost.h:
286         (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
287
288 2010-11-17  Alexander Pavlov  <apavlov@chromium.org>
289
290         Unreviewed, specify IRC nickname in committers.py.
291
292         * Scripts/webkitpy/common/config/committers.py:
293
294 2010-11-17  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
295
296         Reviewed by Tony Chang.
297
298         [NRWT] Make http locking similar to perl implementation
299         https://bugs.webkit.org/show_bug.cgi?id=49187
300
301         * Scripts/webkitpy/common/system/file_lock.py: Added.
302         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
303         * Scripts/webkitpy/layout_tests/port/http_lock.py:
304
305 2010-11-17  MORITA Hajime  <morrita@google.com>
306
307         Reviewed by Kent Tamura.
308
309         [Chromium][DRT] EventSender.contextClick() should aware spellchecking
310         https://bugs.webkit.org/show_bug.cgi?id=49366
311
312         - EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries
313           according to the spellchecker suggestion
314         - MockSpellCheck: add fillSuggestionList to provide fake suggestions.
315
316         test_expectations.txt will be changed after this change is ported to test_shell.
317         
318         * DumpRenderTree/chromium/EventSender.cpp:
319         (makeMenuItemStringsFor):
320         (EventSender::contextClick):
321         * DumpRenderTree/chromium/MockSpellCheck.cpp:
322         (MockSpellCheck::fillSuggestionList):
323         (MockSpellCheck::initializeIfNeeded):
324         * DumpRenderTree/chromium/MockSpellCheck.h:
325         * DumpRenderTree/chromium/WebViewHost.cpp:
326         (WebViewHost::mockSpellCheck):
327         * DumpRenderTree/chromium/WebViewHost.h:
328
329 2010-11-16  Dave Hyatt  <hyatt@apple.com>
330
331         Reviewed by Sam Weinig.
332
333         Make sure the pref for minimum font size is just explicitly set to 0 every time,
334         since the bots have 1 stuck in their plist otherwise.
335
336         * DumpRenderTree/mac/DumpRenderTree.mm:
337         (resetDefaultsToConsistentValues):
338
339 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
340
341         Reviewed by Tony Chang.
342
343         Rebaseline server: compute diffs client-side
344         https://bugs.webkit.org/show_bug.cgi?id=49640
345         
346         The image diff output from the DRT is pretty bad on some ports (at
347         least the Mac one), so it's better to compute diffs on the client by
348         using <canvas>.
349
350         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
351         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
352         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
353
354 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
355
356         Reviewed by Tony Chang.
357
358         Rebaseline server: display test results
359         https://bugs.webkit.org/show_bug.cgi?id=49626
360         
361         Adds basic result display to the rebaseline server. On the Python side
362         this involves:
363         - Parsing the unexpected_results.json into a dictionary.
364         - Serving it as JSON under /results.json.
365         (the JSON -> dict -> JSON transform isn't strictly necessary right now,
366         but I'll need to have access to the parsed results on the Python side
367         for follow-up changes).
368         
369         On the web UI side this adds:
370         - Markup for display image and text results (expected, actual, diff),
371           and JS for populating it.
372         - Markup for breaking down test results by failure type and directory,
373           and JS for populating it.
374
375         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
376         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
377         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
378         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
379         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
380
381 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
382
383         Reviewed by Ojan Vafai.
384
385         See Chromium issue http://codereview.chromium.org/5133001/ - we
386         are modifying the build bots to pass in the builder name with
387         the "GPU" string appended instead of appending it in the code.
388
389         https://bugs.webkit.org/show_bug.cgi?id=49636
390
391         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
392
393 2010-11-16  Steve Falkenburg  <sfalken@apple.com>
394
395         Reviewed by Adam Roben.
396
397         Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
398         https://bugs.webkit.org/show_bug.cgi?id=49632
399
400         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
401         * DumpRenderTree/win/DumpRenderTree.vcproj:
402         * DumpRenderTree/win/ImageDiff.vcproj:
403         * MiniBrowser/MiniBrowser.vcproj:
404         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
405         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
406         * WebKitTestRunner/win/InjectedBundle.vcproj:
407         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
408         * WinLauncher/WinLauncher.vcproj:
409         * record-memory-win/record-memory-win.vcproj:
410
411 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
412
413         Reviewed by Ojan Vafai.
414
415         new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread
416
417         Rename the TestInfo class to TestInput to be clearer about its
418         function, and move the checksum-reading code into dump_render_tree_thread
419         to avoid cross-thread access.
420
421         https://bugs.webkit.org/show_bug.cgi?id=49573
422
423         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
424         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
425         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
426
427 2010-11-16  Dave Hyatt  <hyatt@apple.com>
428
429         Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.
430
431         * DumpRenderTree/mac/DumpRenderTree.mm:
432         (resetDefaultsToConsistentValues):
433
434 2010-11-16  Stephanie Lewis  <slewis@apple.com>
435
436         Reviewed by Geoff Garen.
437
438         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
439
440         Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock 
441         for every WebView, and the WebKit API doesn't support that ownership model.
442
443         I also fixed a leak in setMockDeviceOrientation by adding a missing release.
444
445         * DumpRenderTree/mac/DumpRenderTree.mm:
446         (createWebViewAndOffscreenWindow):
447         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
448         (LayoutTestController::setMockDeviceOrientation):
449
450 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
451
452         Reviewed by Ojan Vafai.
453
454         new-run-webkit-tests: log the process id in --verbose mode
455
456         As part of the switch to multi-process mode, we should log the
457         process id when running w/ --verbose.
458
459         https://bugs.webkit.org/show_bug.cgi?id=49571
460
461         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
462
463 2010-11-16  Adam Roben  <aroben@apple.com>
464
465         Only trigger Windows builds when files that we actually use on Windows
466         are changed
467
468         A new Scheduler subclass, PlatformSpecificScheduler, has been added.
469         It uses the new webkitpy.common.config.build module to determine
470         whether a particular change should trigger a build on a particular
471         platform. The Windows builders have been switched to use a
472         PlatformSpecificScheduler.
473
474         The logic to determine whether or not a particular change should
475         trigger a build on a given platform has only been implemented/tested
476         for Windows. I tried to make it easy to add more platforms in the
477         future, but I don't have enough familiarity with all platforms to be
478         able to implement it for them.
479
480         Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
481         lots irrelevant changes (e.g., rebaselining Chromium test results)
482
483         Reviewed by Eric Seidel.
484
485         * BuildSlaveSupport/build.webkit.org-config/config.json: Use a
486         PlatformSpecificScheduler for the Windows builders.
487
488         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
489         (PlatformSpecificScheduler.__init__): Added. Stores our platform, sets
490         up a ChangeFilter that filters to our branch and will call through to
491         our filter method, and calls up to our base class.
492         (PlatformSpecificScheduler.filter): Calls through to
493         build.should_build to find out whether we should trigger a build for
494         this change.
495
496         * Scripts/webkitpy/common/net/build.py: Added.
497         (_should_file_trigger_build): Uses a set of directories and regexp
498         patterns to determine whether the given file should trigger a build on
499         the given platform. As mentioned earlier, this has only been
500         implemented for Windows, though I did try to make some guesses about
501         other platforms.
502         (should_build): Returns true if any of the files should trigger a
503         build on the given platform.
504
505         * Scripts/webkitpy/common/net/build_unittest.py: Added.
506         (ShouldBuildTest.test_should_build): Does some basic testing to make
507         sure we're triggering builds for the right files. It only tests
508         Windows for now, though I tried to make some guesses about other
509         platforms.
510
511 2010-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
512
513         Reviewed by Andreas Kling.
514
515         [Qt] Remove synchronous QWebPage::checkPermissions signal
516         https://bugs.webkit.org/show_bug.cgi?id=46810
517
518         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
519         (WebCore::WebPage::WebPage):
520         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
521         (LayoutTestController::grantDesktopNotificationPermission): When granting
522         permission, grant it directly on the QWebPage/Frame, that will remember it.
523         * QtTestBrowser/webpage.cpp:
524         (WebPage::WebPage):
525         * QtTestBrowser/webpage.h:
526
527
528 2010-11-16  Andras Becsi  <abecsi@inf.u-szeged.hu>
529
530         Reviewed by Csaba Osztrogonác.
531
532         [Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
533
534         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
535         (LayoutTestController::reset):
536         * DumpRenderTree/qt/LayoutTestControllerQt.h:
537         (LayoutTestController::isPrinting):
538         (LayoutTestController::setPrinting):
539
540 2010-11-16  Balazs Kelemen  <kbalazs@webkit.org>
541
542         Reviewed by Andreas Kling.
543
544         [Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
545         https://bugs.webkit.org/show_bug.cgi?id=49587
546
547         * MiniBrowser/qt/BrowserView.cpp:
548         (BrowserView::BrowserView): Added BackingStoreType
549         argument to ctor. Propagating it to the QGraphicsWKView.
550         * MiniBrowser/qt/BrowserView.h:
551         * MiniBrowser/qt/BrowserWindow.cpp:
552         (BrowserWindow::BrowserWindow):
553         (BrowserWindow::newWindow): Create the new BrowserWindow
554         with the same BackingStoreType that this instance has.
555         * MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
556         * MiniBrowser/qt/main.cpp:
557         (main): Use tiled backing store if got -tiled command line argument.
558         Avoid redundant copy of command line args.
559
560 2010-11-16  John Knottenbelt  <jknotten@chromium.org>
561
562         Reviewed by Jeremy Orlow.
563
564         Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
565         https://bugs.webkit.org/show_bug.cgi?id=48506
566
567         This ensures that there is one mock per page WebView / WebViewHost. This is a
568         design constraint of the DeviceOrientationClientMock because the m_controller
569         field can only store a pointer to a single instance of the corresponding
570         DeviceOrientationController.
571
572         Test: fast/dom/DeviceOrientation/no-page-cache.html
573
574         * DumpRenderTree/chromium/LayoutTestController.cpp:
575         (LayoutTestController::setMockDeviceOrientation):
576         (LayoutTestController::deviceOrientationClientMock):
577         * DumpRenderTree/chromium/LayoutTestController.h:
578         * DumpRenderTree/chromium/WebViewHost.cpp:
579         (WebViewHost::deviceOrientationClientMock):
580         (WebViewHost::deviceOrientationClient):
581         (WebViewHost::reset):
582         * DumpRenderTree/chromium/WebViewHost.h:
583
584 2010-11-15  Andras Becsi  <abecsi@webkit.org>
585
586         Reviewed by Andreas Kling.
587
588         [Qt][WK2] Avoid polling in WebKitTestRunner.
589         https://bugs.webkit.org/show_bug.cgi?id=49542
590
591         Make the WK2 testing session about 10-15% faster and decrease random flakiness
592         resulting from timing skew by removing the millisecond polling from TestControllerQt.
593
594         * WebKitTestRunner/TestController.cpp:
595         (WTR::TestController::didFinishLoadForFrame):
596         * WebKitTestRunner/TestController.h:
597         * WebKitTestRunner/TestInvocation.cpp:
598         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
599         * WebKitTestRunner/mac/TestControllerMac.mm:
600         (WTR::TestController::notifyDone): Add method stub.
601         * WebKitTestRunner/qt/TestControllerQt.cpp:
602         (WTR::TestControllerRunLoop::instance):
603         (WTR::TestControllerRunLoop::start):
604         (WTR::TestControllerRunLoop::stop):
605         (WTR::TestControllerRunLoop::TestControllerRunLoop):
606         (WTR::TestControllerRunLoop::timerEvent):
607         (WTR::TestController::notifyDone):
608         (WTR::TestController::platformRunUntil):
609         * WebKitTestRunner/win/TestControllerWin.cpp:
610         (WTR::TestController::notifyDone): Add method stub.
611
612 2010-11-15  Darin Adler  <darin@apple.com>
613
614         * Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
615
616 2010-11-15  Benjamin Poulain  <benjamin.poulain@nokia.com>
617
618         Reviewed by Andreas Kling.
619
620         [Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
621         https://bugs.webkit.org/show_bug.cgi?id=49544
622
623         Add the shortcut to BrowserWindow.
624
625         * MiniBrowser/qt/BrowserWindow.cpp:
626         (BrowserWindow::BrowserWindow):
627         (BrowserWindow::openLocation):
628         * MiniBrowser/qt/BrowserWindow.h:
629
630 2010-11-14  David Levin  <levin@chromium.org>
631
632         Reviewed by Daniel Bates.
633
634         check-webkit-style should detect PassRefPtr usage in functions.
635         https://bugs.webkit.org/show_bug.cgi?id=49513
636
637         * Scripts/webkitpy/style/checkers/cpp.py:
638         (check_for_function_lengths): Revert a comment change that I
639          accidentally made in r71986.
640         (check_pass_ptr_usage): Added the code to do the check.
641         (process_line): Added the call to check_pass_ptr_usage.
642         (CppChecker): Added the new error category.
643         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
644         (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for
645          testing purposes.
646         (PassPtrTest::*): The class/functions to unit test the new
647          functionality.
648
649 2010-11-14  David Levin  <levin@chromium.org>
650
651         Reviewed by Shinichiro Hamaji.
652
653         check-webkit-style function detection and the line count style checks should be separate.
654         https://bugs.webkit.org/show_bug.cgi?id=49512
655
656         * Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
657         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to
658           call the detection function and fix line counts in two places now that
659           the code really only counts the lines in the body of the function.
660
661 2010-11-14  Andreas Kling  <kling@webkit.org>
662
663         Reviewed by Antonio Gomes.
664
665         http/tests/plugins tests print "Unhandled variable" to stderr under Qt
666         https://bugs.webkit.org/show_bug.cgi?id=33438
667
668         Stifle "Unhandled variable" warning to match what the other
669         TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
670         simply returns NPERR_GENERIC_ERROR for unhandled variables.)
671
672         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
673         (webkit_test_plugin_get_value):
674
675 2010-11-13  David Levin  <levin@chromium.org>
676
677         Reviewed by Eric Seidel.
678
679         check-webkit-style function detection crashes on functions in templates.
680         https://bugs.webkit.org/show_bug.cgi?id=49504
681
682         For example "template <bool shouldClose(const Element*)>".
683
684         * Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out.
685         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex
686           function detection test to expose this issue.
687
688 2010-11-12  David Levin  <levin@chromium.org>
689
690         Reviewed by Shinichiro Hamaji.
691
692         check-webkit-style function detection doesn't detect indented functions declaractions.
693         https://bugs.webkit.org/show_bug.cgi?id=49446
694
695         Indented function declarations occur inside class definitions, so
696         they are a pretty common (and worth detecting).
697
698         * Scripts/webkitpy/style/checkers/cpp.py:
699           Changed regex to allow indentation.
700           Changed the function start detection to only happen when not in a
701           function.
702           Changed function end detection to work based on matching braces
703           instead of finding a close brace at the beginning of the line.
704           Fixed close_expression to do what it says when it doesn't find
705           the close.
706         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Indented function test.
707
708 2010-11-12  Daniel Bates  <dbates@rim.com>
709
710         Rubber-stamped by Nikolas Zimmermann.
711
712         Make do-file-rename rename files in the directory WebKit2.
713
714         This also makes the list of searched directories in do-file-rename
715         consistent with the list of searched directories in the script do-webcore-rename.
716
717         * Scripts/do-file-rename:
718
719 2010-11-12  Dirk Pranke  <dpranke@chromium.org>
720
721         Reviewed by James Robinson.
722
723         Attempt yet again to land the fix for bug 49360 (respecting
724         set-webkit-configuration). We need to handle the cases where
725         trying to run webkit-build-directory to find out where the
726         default configuration might be fails (that shows up on some
727         Chromium bots that apparently don't have perl installed).
728
729         https://bugs.webkit.org/show_bug.cgi?id=49360
730
731         * Scripts/webkitpy/layout_tests/port/config.py:
732         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Added.
733         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
734
735 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
736
737         Reviewed by Adam Barth.
738
739         webkit-patch land logs commit message twice
740         https://bugs.webkit.org/show_bug.cgi?id=49482
741         
742         Don't log the comment that's used by bugzilla.close_bug_as_fixed, since
743         that's just the commit message, which we now output following the
744         actual commit.
745
746         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
747
748 2010-11-12  Tony Chang  <tony@chromium.org>
749
750         Reviewed by Adam Barth.
751
752         run platform/chromium/plugins/script-object-invoke.html on all platforms
753         https://bugs.webkit.org/show_bug.cgi?id=49280
754
755         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
756         (testScriptObjectInvoke):
757         (pluginInvoke):
758
759 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
760
761         Reviewed by Adam Barth.
762
763         webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch
764         https://bugs.webkit.org/show_bug.cgi?id=49471
765
766         Right now there's no indication of a successful commit.
767         
768         * Scripts/webkitpy/tool/commands/download_unittest.py:
769         * Scripts/webkitpy/tool/steps/commit.py:
770
771 2010-11-12  Kinuko Yasuda  <kinuko@chromium.org>
772
773         Reviewed by Ojan Vafai.
774
775         Include detailed test modifiers in results.json and enable incremental uploading for non-layout tests
776         https://bugs.webkit.org/show_bug.cgi?id=49354
777
778         Also moved/integrated the upload method from run_webkit_tests.py to json_results_generator.py.
779
780         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
781         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
782         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
783         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
784
785 2010-11-12  Tony Chang  <tony@chromium.org>
786
787         Reviewed by Kent Tamura.
788
789         [chromium] Load a blank page when closing DRT WebViewHosts
790         https://bugs.webkit.org/show_bug.cgi?id=49417
791
792         In test_shell, when we close a window, we first load about:blank
793         and run GC to fire the destruction logic of the page.  In test_shell,
794         this happens in ~TestShell.  In DRT, we manage virtual windows as
795         WebViewHosts, so we need to replicate this logic in ~WebViewHost.
796
797         Managing focus is a bit trickier, since normally you would get window
798         events to reset the focus to the right window.  We do it manually
799         instead.
800
801         This fixes 2 plugin tests on DRT.
802
803         * DumpRenderTree/chromium/TestShell.cpp:
804         (TestShell::~TestShell): Move window close logic to ~WebViewHost.
805         (TestShell::closeWindow): Move widget close() to WVH destructor and
806             manage focus manually.
807         (TestShell::closeRemainingWindows): Comment typo.
808         * DumpRenderTree/chromium/WebViewHost.cpp:
809         (WebViewHost::closeWidget):
810         (invokeCloseWidget):
811         (WebViewHost::closeWidgetSoon): Close the window asynchronously (matches
812             test_shell).
813         (WebViewHost::~WebViewHost):
814         * DumpRenderTree/chromium/WebViewHost.h:
815
816 2010-11-12  David Levin  <levin@chromium.org>
817
818         Reviewed by Adam Barth.
819
820         cpp.py needs some tidying.
821         https://bugs.webkit.org/show_bug.cgi?id=49443
822
823         * Scripts/webkitpy/style/checkers/cpp.py:
824           Fix parameter ordering for iteratively_replace_matches_with_char
825           to mirror other similar functions (and improved comments, etc.)
826           Also, use a python-ism (for/else) to get rid of a variable that
827           was there to determine if something had been found in the loop.
828
829 2010-11-12  Robert Kroeger  <rjkroege@chromium.org>
830
831         Reviewed by James Robinson.
832
833         [Chromium/DRT] Make EventSendingController send complete touch events.
834         https://bugs.webkit.org/show_bug.cgi?id=49285
835
836         * DumpRenderTree/chromium/EventSender.cpp:
837         (EventSender::addTouchPoint):
838         (EventSender::updateTouchPoint):
839         (EventSender::sendCurrentTouchEvent):
840
841 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
842
843         Unreviewed rollout of r71858.
844
845         Rollout out r71858 since it breaks new-run-webkit-httpd as used by the
846         NaCl tests.
847
848         * Scripts/webkitpy/layout_tests/port/config.py:
849         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Removed.
850         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
851
852 2010-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
853
854         Reviewed by Kenneth Rohde Christiansen.
855
856         [Qt] TestController::runUntil doesn't honor the timeout parameter
857         https://bugs.webkit.org/show_bug.cgi?id=48941
858
859         Implement the missing timeout of WebKitTestRunner for Qt.
860
861         A QElapsedTimer has been added to RunUntilConditionLoop in order
862         to measure how long the loop has been running. When the timer
863         is bigger or equal than the timeout, the loop ends even if the
864         condition is not met.
865
866         * WebKitTestRunner/qt/TestControllerQt.cpp:
867         (WTR::RunUntilConditionLoop::start):
868         (WTR::RunUntilConditionLoop::run):
869         (WTR::RunUntilConditionLoop::timerEvent):
870         (WTR::TestController::platformRunUntil):
871
872 2010-11-11  David Levin  <levin@chromium.org>
873
874         Reviewed by Shinichiro Hamaji.
875
876         check-webkit-style function detection doesn't handle templates with spaces.
877         https://bugs.webkit.org/show_bug.cgi?id=49427
878
879         * Scripts/webkitpy/style/checkers/cpp.py: Stripped out templates when
880           finding the function name.
881         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test have a
882           template with a space.
883
884 2010-11-11  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
885
886         Reviewed by Shinichiro Hamaji.
887
888         Enable check-webkit-style on Qt files
889         https://bugs.webkit.org/show_bug.cgi?id=48322
890
891         Adding exception for _q_... private slots and
892         ..._data() methods in tests
893
894         * Scripts/webkitpy/style/checker.py: enable Qt dirs, add exceptions
895         * Scripts/webkitpy/style/checker_unittest.py: improve unittests
896
897 2010-11-11  David Levin  <levin@chromium.org>
898
899         Reviewed by Shinichiro Hamaji.
900
901         check-webkit-style function detection doesn't work for templates and destructors.
902         https://bugs.webkit.org/show_bug.cgi?id=49425
903
904         * Scripts/webkitpy/style/checkers/cpp.py: Changed regex for templates and destructors.
905         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test hit this issue.
906
907 2010-11-11  Joone Hur  <joone@kldp.org>
908
909         Reviewed by Antonio Gomes.
910
911         [GTK][DRT] Implement LayoutTestController::nodesFromRect
912         https://bugs.webkit.org/show_bug.cgi?id=46598
913
914         Support nodesFromRect in DRT
915
916         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
917         (LayoutTestController::nodesFromRect):
918
919 2010-11-11  MORITA Hajime  <morrita@google.com>
920
921         Reviewed by Kent Tamura.
922
923         editing/selection/context-menu-on-text.html fails on chromium
924         https://bugs.webkit.org/show_bug.cgi?id=45898
925
926         Enhance Chromium's EventSender::contextClick() to return
927         array of menu strings. The implementation incomplete because
928         Although actual context menu is implemented by the browser,
929         it reflects editability of underlying context thus makes
930         context-menu-on-text.html passed.
931         
932         * DumpRenderTree/chromium/EventSender.cpp:
933         (makeMenuItemStringsFor): Added.
934         (EventSender::contextClick): Now returns array of menu strings.
935         * DumpRenderTree/chromium/WebViewHost.cpp:
936         (WebViewHost::showContextMenu): Now storing given WebContextMenuData object.
937         (WebViewHost::clearContextMenuData): Added.
938         (WebViewHost::lastContextMenuData): Added.
939         * DumpRenderTree/chromium/WebViewHost.h:
940
941 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
942
943         Unreviewed, build fix.
944
945         fix build breakage caused by fix for bug 49380 (r71858).
946
947         config_standalone needs to ensure that the packages it needs are
948         in sys.path.
949
950         https://bugs.webkit.org/show_bug.cgi?id=49419
951
952         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
953
954 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
955
956         Reviewed by Adam Roben.
957
958         Fix NRWT to respect set-webkit-configuration again :(
959
960         This change fixes a typo in config.py that was causing the wrong
961         value to be read initially and us never actually looking into
962         the filesystem to get the default configuration.
963         
964         * Scripts/webkitpy/layout_tests/port/config.py:
965         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
966         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
967
968 2010-11-11  Eric Seidel  <eric@webkit.org>
969
970         Reviewed by Adam Barth.
971
972         Split out Bug, Attachment and CommitterValidator from bugzilla.py
973         https://bugs.webkit.org/show_bug.cgi?id=49403
974
975         CommitterValidator really had nothing to do with bugzilla.py.
976         I've put it next to committers.py for now since its rather tied to that file.
977
978         * Scripts/webkitpy/common/config/committervalidator.py: Added.
979         * Scripts/webkitpy/common/config/committervalidator_unittest.py: Added.
980         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
981         * Scripts/webkitpy/common/net/bugzilla/attachment.py: Added.
982         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added.
983         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: Added.
984         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
985         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
986         * Scripts/webkitpy/tool/bot/feeders.py:
987         * Scripts/webkitpy/tool/commands/queues.py:
988
989 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
990
991         Reviewed by Eric Seidel.
992
993         fix missing 'pid' argument for http lockfile checking on win32
994         https://bugs.webkit.org/show_bug.cgi?id=49363
995
996         * Scripts/webkitpy/common/system/executive.py:
997
998 2010-11-11  Eric Seidel  <eric@webkit.org>
999
1000         Rubber-stamped by Adam Barth.
1001
1002         Move bugzilla.py into its own module in preparation for splitting one-file-per-class
1003         https://bugs.webkit.org/show_bug.cgi?id=49402
1004
1005         * Scripts/webkitpy/common/net/bugzilla/__init__.py: Added.
1006         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla.py.
1007         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla_unittest.py.
1008
1009 2010-11-10  Chris Guillory  <chris.guillory@google.com>
1010
1011         Reviewed by Chris Fleizach.
1012
1013         Use IAccessibleComparable to compare accessibility objects.
1014         https://bugs.webkit.org/show_bug.cgi?id=49118
1015
1016         * DumpRenderTree/AccessibilityUIElement.cpp:
1017         (AccessibilityUIElement::isEqual):
1018         * DumpRenderTree/AccessibilityUIElement.h:
1019         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1020         (comparableObject):
1021         (AccessibilityUIElement::isEqual):
1022
1023 2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>
1024
1025         Reviewed by David Hyatt.
1026
1027         HTML5 Ruby support should be mandatory feature
1028         https://bugs.webkit.org/show_bug.cgi?id=49272
1029
1030         Remove Ruby as optional feature.
1031
1032         * Scripts/build-webkit:
1033
1034 2010-11-10  Adam Roben  <aroben@apple.com>
1035
1036         Print VC++ Express build logs in the same order that the projects are
1037         built
1038
1039         Fixes <http://webkit.org/b/49326> print-vse-failure-logs prints logs
1040         in an unhelpful order
1041
1042         Reviewed by Eric Seidel.
1043
1044         * Scripts/print-vse-failure-logs:
1045         (PrintVisualStudioExpressLogs._build_order): Added. Uses
1046         print-msvc-project-dependencies to figure out the order in which
1047         projects are built.
1048         (PrintVisualStudioExpressLogs._sort_buildlogs): Added. Sorts the logs
1049         based on their build order and project name.
1050         (PrintVisualStudioExpressLogs._obj_directory): Moved code to find the
1051         scripts directory from here...
1052         (PrintVisualStudioExpressLogs._scripts_directory): ...to here.
1053         (PrintVisualStudioExpressLogs.main): Sort the logs before printing
1054         them.
1055
1056 2010-11-10  Adam Roben  <aroben@apple.com>
1057
1058         Only print the interesting text from VC++ Express build logs
1059
1060         Fixes <http://webkit.org/b/49325> It's hard to find the interesting
1061         output from print-vse-failure-logs
1062
1063         Reviewed by Eric Seidel.
1064
1065         * Scripts/print-vse-failure-logs: Removed unnecessary os.path import,
1066         added newly-required imports. Removed a comment that was essentially a
1067         FIXME, and is now fixed.
1068         (PrintVisualStudioExpressLogs._relevant_text): Added. Uses
1069         BeautifulSoup to extract the relevant text from the build log.
1070         (PrintVisualStudioExpressLogs.main): Only print the relevant text.
1071
1072 2010-11-09  Mihai Parparita  <mihaip@chromium.org>
1073
1074         Reviewed by Tony Chang.
1075
1076         [Chromium] http/tests/security/XFrameOptions fail with Chromium DRT
1077         https://bugs.webkit.org/show_bug.cgi?id=49286
1078         
1079         The tests in http/tests/security/XFrameOptions started to fail after
1080         r71297, since it changed the WebViewHost::assignIdentifierToRequest
1081         logic to always assign identifiers to requests, even if we're not going
1082         to be dumping resource load callbacks at that point. These tests
1083         only call LayoutTestController.dumpResourceLoadCallbacks after the
1084         request is started, thus their expectations have "<unknown>" as the
1085         identifier. Change WebViewHost to the previous behavior, which also
1086         match the other ports'.
1087
1088         * DumpRenderTree/chromium/WebViewHost.cpp:
1089         (WebViewHost::assignIdentifierToRequest):
1090         (WebViewHost::removeIdentifierForRequest):
1091
1092 2010-11-08  Tony Chang  <tony@chromium.org>
1093
1094         Reviewed by Adam Barth.
1095
1096         run platform/chromium/plugins/return-npobject.html on all platforms
1097         https://bugs.webkit.org/show_bug.cgi?id=49103
1098
1099         This tests that we can get an NPObject returned through a method on
1100         an NPAPI Object.
1101
1102         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1103         (testCallbackReturn):
1104         (pluginInvoke):
1105
1106 2010-11-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1107
1108         Unreviewed, rolling out r71672.
1109         http://trac.webkit.org/changeset/71672
1110         https://bugs.webkit.org/show_bug.cgi?id=49276
1111
1112         It doesn't work on Chromium Windows bot (Requested by Ossy on
1113         #webkit).
1114
1115         * Scripts/webkitpy/common/system/file_lock.py: Removed.
1116         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
1117         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1118
1119 2010-11-09  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1120
1121         Reviewed by Tony Chang.
1122
1123         [NRWT] Make http locking similar to perl implementation
1124         https://bugs.webkit.org/show_bug.cgi?id=49187
1125
1126         * Scripts/webkitpy/common/system/file_lock.py: Added.
1127         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
1128         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1129
1130 2010-11-09  James Kozianski  <koz@chromium.org>
1131
1132         Reviewed by Eric Seidel.
1133
1134         Clean up imports for webkit-patch.
1135         https://bugs.webkit.org/show_bug.cgi?id=49083
1136
1137         Move some imports from commands into main.py where they are used.
1138         Move command imports into the __init__ of the commands module.
1139
1140         * Scripts/webkitpy/tool/commands/__init__.py:
1141         * Scripts/webkitpy/tool/commands/download.py:
1142         * Scripts/webkitpy/tool/commands/queues.py:
1143         * Scripts/webkitpy/tool/main.py:
1144
1145 2010-11-09  Yi Shen  <yi.4.shen@nokia.com>
1146
1147         Reviewed by Andreas Kling.
1148
1149         [Qt][QtTestBrowser] Don't erase incorrect url in the Url Bar
1150         https://bugs.webkit.org/show_bug.cgi?id=49047
1151
1152         * QtTestBrowser/mainwindow.cpp:
1153         (MainWindow::setAddressUrl):
1154
1155 2010-11-09  Andras Becsi  <abecsi@webkit.org>
1156
1157         Reviewed by Csaba Osztrogonác.
1158
1159         Improve old-run-webkit-tests --verbose to show DumpTool opening/closing
1160         https://bugs.webkit.org/show_bug.cgi?id=49252
1161
1162         * Scripts/old-run-webkit-tests:
1163
1164 2010-11-09  Csaba Osztrogonác  <ossy@webkit.org>
1165
1166         Reviewed by Tor Arne Vestbø.
1167
1168         Output of old-run-webkit-tests is buggy in verbose mode
1169         https://bugs.webkit.org/show_bug.cgi?id=49249
1170
1171         * Scripts/old-run-webkit-tests: Redundant outputs removed.
1172
1173 2010-11-08  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
1174
1175         Reviewed by Martin Robinson.
1176
1177         [GTK] Link with target name set does not work
1178         https://bugs.webkit.org/show_bug.cgi?id=48865
1179
1180         When a new page is created with a name (target=myFrame), the new
1181         mainFrame could not be found because they where not stored in the
1182         same PageGroup. As PageGroup are not exposed externally so the
1183         simpliest solution is to use a global page group name. This also fixes
1184         issue with visited link coloration across pages. After this change the
1185         private function webkit_web_view_set_group_name() was no longer used
1186         so it was removed completly.
1187
1188         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1189         (createWebView):
1190
1191 2010-11-08  John Knottenbelt  <jknotten@chromium.org>
1192
1193         Reviewed by Kent Tamura.
1194
1195         WebViewHost::reset() uses placement new.
1196         https://bugs.webkit.org/show_bug.cgi?id=49069
1197
1198         WebViewHost is using placement destruction / new to simulate a fresh
1199         WebViewHost object at the same address. This is because the WebView remains
1200         open across tests and maintains a pointer to the WebViewHost.
1201         This change resets member variables explictly instead of the placement new dance.
1202
1203         * DumpRenderTree/chromium/WebViewHost.cpp:
1204         (WebViewHost::WebViewHost):
1205         (WebViewHost::reset):
1206
1207 2010-11-08  Dirk Pranke <dpranke@chromium.org>
1208
1209         Reviewed by Eric Seidel.
1210
1211         Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py. 
1212         It turns out that NRWT can't use the code in scm.find_checkout_root()
1213         because the Chromium bots don't do full checkouts of the WebKit
1214         tree; they only check out subdirectories like WebKitTools/Scripts.
1215         Until we can figure out a better approach for this, I've
1216         restored the base_dir-detecting code from NRWT, which works in
1217         any directory tree, scm or no.
1218
1219         This also restores the files modified in r71475 and r71474.
1220
1221         https://bugs.webkit.org/show_bug.cgi?id=49151
1222
1223         * WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
1224         * WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py
1225
1226 2010-11-08  Eric Seidel  <eric@webkit.org>
1227
1228         Reviewed by Adam Barth.
1229
1230         webkit-patch failure-reason explodes if a build is missing
1231         https://bugs.webkit.org/show_bug.cgi?id=49195
1232
1233         This is likely a recent regression.  Adding a unit test for this case.
1234
1235         * Scripts/webkitpy/common/net/buildbot.py:
1236         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1237
1238 2010-11-08  Dan Bernstein  <mitz@apple.com>
1239
1240         Reviewed by Darin Adler.
1241
1242         Ignore the system scrollbar setting.
1243
1244         * DumpRenderTree/mac/DumpRenderTree.mm:
1245         (resetDefaultsToConsistentValues): Set the scrollbar default.
1246
1247 2010-11-05  Adam Roben  <aroben@apple.com>
1248
1249         Make webkitpy.common.system.executive_unittest pass when running under
1250         Win32 Python
1251
1252         Fixes <http://webkit.org/b/49033>.
1253
1254         Reviewed by Dave Levin and Eric Seidel.
1255
1256         * Scripts/webkitpy/common/system/executive.py:
1257         (Executive._run_command_with_teed_output): Pass the arguments through
1258         encode_argument_if_needed rather than using Cygwin-specific code here.
1259         (Executive.run_and_throw_if_fail): Use child_process_encoding to decode
1260         the output.
1261         (Executive.run_command): Use encode_argument_if_needed to encode the
1262         arguments and child_process_encoding to decode the output.
1263         (Executive._child_process_encoding): Returns the encoding that should be
1264         used when communicating with child processes. On Windows we use mbcs,
1265         which maps to the current code page. On all other platforms we use
1266         UTF-8.
1267         (Executive._should_encode_child_process_arguments): Returns True if
1268         arguments to child processes need to be encoded. This is currently
1269         only needed on Cygwin and Win32 Python 2.x.
1270         (Executive._encode_argument_if_needed): Encode the argument using
1271         child_process_encoding if we need to encode arguments to child
1272         processes on this platform.
1273
1274         * Scripts/webkitpy/common/system/executive_unittest.py:
1275         (never_ending_command): Added. Returns arguments to run a command that
1276         will not quit until we kill it. On Windows we use wmic, on other
1277         platforms we use yes.
1278         (ExecutiveTest.test_run_command_with_unicode): Changed to expect the
1279         mbcs encoding to be used and for output from the child processes to
1280         have been roundtripped through encode/decode on Win32 Python. When
1281         UTF-8 is the encoding the roundtripping is undetectable, but with mbcs
1282         it's possible that some characters will not be able to be converted
1283         and will be replaced by question marks; the round-tripping allows us
1284         to expect this result.
1285
1286         (ExecutiveTest.test_kill_process):
1287         (ExecutiveTest.test_kill_all):
1288         Use never_ending_command instead of invoking "yes" directly. Expect an
1289         exit code of 1 when using Win32 Python, as that's what seems to happen.
1290
1291 2010-11-08  Adam Roben  <aroben@apple.com>
1292
1293         Roll out r71532
1294
1295         It broke the build for Cygwin 1.7 installs. Cygwin 1.7's default
1296         .bashrc unsets %TEMP%, which broke copy-tools.cmd.
1297
1298         * Scripts/webkitdirs.pm:
1299
1300 2010-11-08  Tony Chang  <tony@chromium.org>
1301
1302         Reviewed by Adam Barth.
1303
1304         run platform/chromium/plugins/nested-plugin-objects.html on all platforms
1305         https://bugs.webkit.org/show_bug.cgi?id=49094
1306
1307         This tests that objects created by plugins are proplery cleaned up.
1308
1309         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1310         (testPassTestObject):
1311         (pluginInvoke):
1312         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
1313         (testAllocate):
1314         (testDeallocate):
1315         (testGetProperty):
1316         (testConstruct):
1317
1318 2010-11-08  Adam Roben  <aroben@apple.com>
1319
1320         Mark Windows builds triggered from Perl as being non-interactive
1321
1322         This affects whether some of our scripts will show alerts vs. printing
1323         to the build log.
1324
1325         Fixes <http://webkit.org/b/49181> Windows build fail mysteriously when
1326         .vsprops files are updated
1327
1328         Reviewed by Steve Falkenburg.
1329
1330         * Scripts/webkitdirs.pm:
1331         (buildVisualStudioProject): Set WEBKIT_NONINTERACTIVE_BUILD to 1.
1332
1333 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1334
1335         Reviewed by Ojan Vafai.
1336
1337         Make http locking default in NRWT.
1338         https://bugs.webkit.org/show_bug.cgi?id=48053
1339
1340         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1341         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1342
1343 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1344
1345         Reviewed by Csaba Osztrogonác.
1346
1347         [NRWT] If the http lock fails we shouldn't do any locking
1348         https://bugs.webkit.org/show_bug.cgi?id=49164
1349
1350         If something goes wrong with the locking, the test should keep going.
1351
1352         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1353
1354 2010-11-08  Adam Roben  <aroben@apple.com>
1355
1356         Switch back to using kCGImageAlphaPremultipliedFirst when generating
1357         pixel dumps on Windows
1358
1359         I changed this behavior in r71418 thinking that it was required for
1360         getting plugins to show up in pixel dumps. But it doesn't seem to be
1361         necessary, and was making it impossible to compare new Windows pixel
1362         dumps with existing Windows or Mac pixel dumps (because ImageDiff won't
1363         compare an image with alpha to an image without alpha).
1364
1365         Fixes <http://webkit.org/b/49172> REGRESION (r71418): Can't compare
1366         new Windows pixel results to existing Windows or Mac results
1367
1368         Reviewed by Antti Koivisto.
1369
1370         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1371         (createBitmapContextFromWebView): Replaced kCGImageAlphaNoneSkipFirst
1372         with kCGImageAlphaPremultipliedFirst.
1373
1374 2010-11-08  Csaba Osztrogonac  <ossy@webkit.org>
1375
1376         Unreviewed, rolling out r71466.
1377         http://trac.webkit.org/changeset/71466
1378         https://bugs.webkit.org/show_bug.cgi?id=48865
1379
1380         It broke layout tests on GTK bots.
1381
1382         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1383         (createWebView):
1384
1385 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1386
1387         Reviewed by Csaba Osztrogonác.
1388
1389         Enable running of Qt API tests on BuildBot
1390         https://bugs.webkit.org/show_bug.cgi?id=49004
1391
1392         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1393
1394 2010-11-08  Eric Seidel  <eric@webkit.org>
1395
1396         Reviewed by Adam Barth.
1397
1398         Add clean-review-queue command to remove closed bugs from the webkit.org/pending-review
1399         https://bugs.webkit.org/show_bug.cgi?id=49160
1400
1401         Bugzilla doesn't automatically remove r? when a bug gets closed.
1402         This script takes care of that for webkit.org.
1403
1404         * Scripts/webkitpy/common/net/bugzilla.py:
1405         * Scripts/webkitpy/tool/commands/upload.py:
1406
1407 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
1408
1409         Unreviewed, rolling out r71474.
1410         http://trac.webkit.org/changeset/71474
1411         https://bugs.webkit.org/show_bug.cgi?id=48280
1412
1413         breaks chromium webkit tests
1414         https://bugs.webkit.org/show_bug.cgi?id=49151
1415
1416         * Scripts/webkitpy/layout_tests/port/base.py:
1417         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1418         * Scripts/webkitpy/layout_tests/port/config.py:
1419         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1420         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1421         * Scripts/webkitpy/layout_tests/port/webkit.py:
1422         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1423         * Scripts/webkitpy/tool/mocktool.py:
1424
1425 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
1426
1427         Unreviewed, rolling out r71475.
1428         http://trac.webkit.org/changeset/71475
1429  
1430         breaks chromium webkit tests
1431         https://bugs.webkit.org/show_bug.cgi?id=49151
1432
1433         * Scripts/webkitpy/common/newstringio.py: Removed.
1434         * Scripts/webkitpy/common/newstringio_unittest.py: Removed.
1435         * Scripts/webkitpy/common/system/executive_mock.py: Removed.
1436         * Scripts/webkitpy/common/system/filesystem_mock.py: Removed.
1437         * Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
1438
1439 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
1440
1441         Unreviewed, build fix.
1442
1443         Add files inexplicably not committed in r71474 as part of the
1444         fix for bug 48280.
1445
1446         * Scripts/webkitpy/common/newstringio.py: Added.
1447         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
1448         * Scripts/webkitpy/common/system/executive_mock.py: Added.
1449         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
1450         * Scripts/webkitpy/layout_tests/port/config_mock.py: Added.
1451
1452 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
1453
1454         Reviewed by Eric Siedel.
1455
1456         new-run-webkit-tests: update port/base and port/webkit to use the
1457         new FileSystem and Config abstractions, pulling more logic out of
1458         the base Port classes into separate, mockable objects.
1459
1460         Also create a MockFileSystem object, a MockConfig object, move
1461         MockExecutive into common/system to be next to executive, and
1462         update the config object to use a FileSystem.
1463
1464         https://bugs.webkit.org/show_bug.cgi?id=48280
1465
1466         * Scripts/webkitpy/common/newstringio.py: Added.
1467         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
1468         * Scripts/webkitpy/common/system/executive_mock.py: Added.
1469         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
1470         * Scripts/webkitpy/layout_tests/port/base.py:
1471         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1472         * Scripts/webkitpy/layout_tests/port/config.py:
1473         * Scripts/webkitpy/layout_tests/port/config_mock.py:
1474         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1475         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1476         * Scripts/webkitpy/layout_tests/port/webkit.py:
1477         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1478         * Scripts/webkitpy/tool/mocktool.py:
1479
1480 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
1481
1482         Unreviewed, build breakage.
1483
1484         Apparently I uploaded the wrong version of the file to fix 49122
1485         and neither Eric or I noticed - it was missing a dirname() call.
1486         Fixing ...
1487
1488         https://bugs.webkit.org/show_bug.cgi?id=49122
1489
1490         * Scripts/webkitpy/common/checkout/scm.py:
1491
1492 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
1493
1494         Reviewed by Eric Seidel.
1495
1496         webkitpy/tool/* unittests change cwd and don't clean up properly
1497
1498         https://bugs.webkit.org/show_bug.cgi?id=49122
1499
1500         * Scripts/webkitpy/common/checkout/scm.py:
1501
1502 2010-11-05  Chris Marrin  <cmarrin@apple.com>
1503
1504         Reviewed by Simon Fraser.
1505
1506         suspendAnimations/resumeAnimations not present in WebKit2
1507         https://bugs.webkit.org/show_bug.cgi?id=49109
1508
1509         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1510         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1511         (WTR::LayoutTestController::suspendAnimations):
1512         (WTR::LayoutTestController::resumeAnimations):
1513         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1514
1515 2010-11-05  Tony Chang  <tony@chromium.org>
1516
1517         Reviewed by David Levin.
1518
1519         cleanup style in TestNetscapePlugIn/PluginObject.cpp
1520         https://bugs.webkit.org/show_bug.cgi?id=49044
1521
1522         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1523         (getPluginClass):
1524         (pluginGetProperty):
1525         (pluginSetProperty):
1526         (variantToIdentifier):
1527         (testCallback):
1528         (getURL):
1529         (getURLNotify):
1530         (testInvokeDefault):
1531         (testGetProperty):
1532         (testDocumentOpen):
1533         (testWindowOpen):
1534         (pluginInvoke):
1535         (handleCallback):
1536         (notifyStream):
1537         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1538
1539 2010-11-05  Eric Seidel  <eric@webkit.org>
1540
1541         Reviewed by David Levin.
1542
1543         Add QueueStatusServer/__init__.py so others can run the QueueStatusServer tests
1544         https://bugs.webkit.org/show_bug.cgi?id=49032
1545
1546         I wrote this file as part of bug 47847, but I forgot to commit it.
1547         No one else noticed it missing because test-webkitpy knows how
1548         to recover in the case where it can't import QueueStatusServer
1549         (which generally occurs due to not having installed the AppEngine SDK).
1550
1551         * QueueStatusServer/__init__.py: Added.
1552         * QueueStatusServer/model/workitems_unittest.py:
1553          - Remove a test which fails.  This was probably landed (by me)
1554            from my other machine, which since this __init__.py was missing
1555            I never noticed the failure and landed this invalid test.
1556            Sadly we can't really test remove_work_item as it depends
1557            on .key() working.  .key() will throw unless the object
1558            has already been saved it seems.
1559            This may be a mis-design in our remove_work_item implementation,
1560            but for now, just removing the test.
1561
1562 2010-11-04  Adam Roben  <aroben@apple.com>
1563
1564         Teach check-webkit-style about TestNetscapePlugIn
1565
1566         Fixes <http://webkit.org/b/49030> check-webkit-style is ignorant of
1567         TestNetscapePlugIn's coding conventions
1568
1569         Reviewed by John Sullivan.
1570
1571         * Scripts/webkitpy/style/checker.py: Lump TestNetscapePlugIn in with
1572         WebKitAPITest and TestWebKitAPI in having different include order and
1573         naming conventions than WebCore. Added some comments about why the
1574         exceptions exist.
1575
1576 2010-11-04  Adam Roben  <aroben@apple.com>
1577
1578         Add a test that shows that windowed plugins are able to paint
1579
1580         Somehow we never had a test for this before.
1581
1582         Fixes <http://webkit.org/b/49029> Should add a test that shows
1583         windowed plugins can paint
1584
1585         Reviewed by Jon Honeycutt.
1586
1587         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DrawsGradient.cpp: Added.
1588         (DrawsGradient::DrawsGradient):
1589         (DrawsGradient::wndProc): We handle the WM_PAINT and WM_PRINTCLIENT messages.
1590
1591         (DrawsGradient::onPaint):
1592         (DrawsGradient::onPrintClient):
1593         These both just call through to paint.
1594
1595         (DrawsGradient::paint): Fills our client area with some gradients.
1596
1597         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Link
1598         against Msimg32.lib for ::GradientFill and added DrawsGradient.
1599
1600         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1601         (createBitmapContextFromWebView): Use WM_PRINT instead of
1602         WM_PRINTCLIENT so that ::DefWindowProc will send
1603         WM_PRINT/WM_PRINTCLIENT messages to the WebView's child windows.
1604         Replaced kCGImageAlphaPremultipledFirst with kCGImageAlphaNoneSkipFirst
1605         because GDI doesn't support alpha and kCGImageBitmapOrder32Little with
1606         kCGImageBitmapOrder32Host because, who knows, maybe someday Windows
1607         will run on a big-endian platform.
1608
1609 2010-11-04  Adam Roben  <aroben@apple.com>
1610
1611         Extract much of NPNInvalidateRectInvalidatesWindow's code into a
1612         WindowedPluginTest base class
1613
1614         The base class takes care of subclassing the plugin's window so that a
1615         custom WNDPROC is called. This will make it easier to write tests that
1616         need to handle window messages.
1617
1618         Fixes <http://webkit.org/b/49028> It's hard to write a PluginTest with
1619         a custom WNDPROC
1620
1621         Reviewed by Jon Honeycutt.
1622
1623         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
1624         (NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
1625         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow):
1626         (NPNInvalidateRectInvalidatesWindow::wndProc):
1627         (NPNInvalidateRectInvalidatesWindow::testInvalidateRect):
1628         Moved code from here to WindowedPluginTest. Changed to use window()
1629         instead of m_window.
1630
1631         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1632         Added WindowedPluginTest and added TestNetscapePlugIn/win to the
1633         include path. Also reordered the include path to make a little more
1634         sense and simplified the entry that added TestNetscapePlugIn itself to
1635         the include path.
1636
1637         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp: Added.
1638         (WindowedPluginTest::WindowedPluginTest):
1639         (WindowedPluginTest::NPP_SetWindow):
1640         (WindowedPluginTest::staticWndProc):
1641         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h: Added.
1642         (WindowedPluginTest::window):
1643         Code came from NPNInvalidateRectInvalidatesWindow.
1644
1645 2010-11-04  Adam Roben  <aroben@apple.com>
1646
1647         Add a plugin test to show that windowed plugins are clipped correctly
1648
1649         Fixes <http://webkit.org/b/49024> <rdar://problem/8487847> Windowed
1650         plugins aren't clipped in WebKit2 on Windows
1651
1652         Reviewed by Jon Honeycutt.
1653
1654         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp: Added.
1655         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Initialize members.
1656         (WindowRegionIsSetToClipRect::NPP_SetWindow): Check that our window
1657         region matches the clip rect we know we should have based on
1658         window-region-is-set-to-clip-rect.html, and check that our window class
1659         doesn't have the CS_PARENTDC style.
1660
1661         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1662         Added WindowRegionIsSetToClipRect.
1663
1664 2010-11-05  Alejandro G. Castro  <alex@igalia.com>
1665
1666         Reviewed by Martin Robinson.
1667
1668         [GTK] Avoid font hinting in the DRT
1669         https://bugs.webkit.org/show_bug.cgi?id=48548
1670
1671         Change the settings to avoid font hinting, it was causing
1672         different results depending on the distribution.
1673
1674         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1675         (initializeGtkFontSettings):
1676         * DumpRenderTree/gtk/fonts/fonts.conf:
1677
1678 2010-11-05  Eric Seidel  <eric@webkit.org>
1679
1680         Reviewed by Adam Barth.
1681
1682         build-webkit spams system.log by repeatedly checking for PBXProductDirectory in com.apple.Xcode
1683         https://bugs.webkit.org/show_bug.cgi?id=49051
1684
1685         This is a speculative fix.  The unit tests cover these methods, however
1686         I don't know if this will fully stop the system.log spam.
1687
1688         * Scripts/webkitpy/layout_tests/port/base.py:
1689         * Scripts/webkitpy/layout_tests/port/webkit.py:
1690
1691 2010-11-05  Eric Seidel  <eric@webkit.org>
1692
1693         Reviewed by Adam Barth.
1694
1695         Add basic support for showing bot id on /queue-status/ pages
1696         https://bugs.webkit.org/show_bug.cgi?id=49037
1697
1698         This support is really simple.  Eventually we'll want to
1699         show the bot id in the lock table too, but we don't have
1700         that information stored in the server yet.
1701
1702         * QueueStatusServer/handlers/queuestatus.py:
1703         * QueueStatusServer/handlers/queuestatus_unittest.py: Added.
1704         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1705
1706 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
1707
1708         Reviewed by Adam Barth.
1709
1710         Create a filesystem wrapper that we can use to enforce
1711         particular conventions and use for mocking and dependency
1712         injection down the line.
1713
1714         https://bugs.webkit.org/show_bug.cgi?id=48144
1715
1716         * Scripts/webkitpy/common/system/filesystem.py: Added.
1717         * Scripts/webkitpy/common/system/filesystem_unittest.py: Added.
1718
1719 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
1720
1721         Reviewed by Tony Chang.
1722
1723         run_webkit_tests_unittest fails under Python 2.5
1724         https://bugs.webkit.org/show_bug.cgi?id=49043
1725         
1726         Switch from itertools.chain.from_iterable (which was added in 2.6)
1727         to using itertools.chain directly.
1728
1729         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1730
1731 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
1732
1733         Unreviewed fix to webkit-patch rebaseline-server so that it runs under
1734         Python 2.5 (it needs an import to use the with statement).
1735
1736         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1737
1738 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
1739
1740         Reviewed by Adam Barth.
1741
1742         new-run-webkit-tests: split out webkit-specific configuration stuff into a new module
1743
1744         The current NRWT code has webkit-specific configuration code (like
1745         _script_path, default configuration, etc.) mixed in with
1746         layout-test-specific stuff in port/base. The configuration code
1747         should be split out into a separate module for easier mocking,
1748         testing, and isolation.
1749
1750         https://bugs.webkit.org/show_bug.cgi?id=48264
1751
1752         * Scripts/webkitpy/layout_tests/port/config.py: Added.
1753         * Scripts/webkitpy/layout_tests/port/config_unittest.py: Added.
1754
1755 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
1756
1757         Reviewed by Tony Chang.
1758
1759         Rebaseline server: initial framework
1760         https://bugs.webkit.org/show_bug.cgi?id=48892
1761         
1762         Adds the basic framework for the rebaseline server (details at 
1763         http://webkit.org/b/47761). Includes the rebaseline-server webkit-patch
1764         command, which starts an HTTP server that can serve static files or
1765         invoke handler methods on a class.
1766
1767         * Scripts/webkitpy/tool/commands/__init__.py:
1768         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: Added.
1769         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: Added.
1770         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: Added.
1771         * Scripts/webkitpy/tool/commands/rebaselineserver.py: Added.
1772
1773 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
1774
1775         Reviewed by James Robinson.
1776
1777         new-run-webkit-tests wasn't using DRT by default for
1778         --platform chromium-gpu
1779
1780         The default value was set to False instead of None, which meant
1781         that the platform specific logic wasn't firing to change the
1782         value to True (b/c we were afraid we'd be overriding the user
1783         preference).
1784
1785         https://bugs.webkit.org/show_bug.cgi?id=49038
1786
1787         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1788
1789 2010-11-04  Tony Chang  <tony@chromium.org>
1790
1791         Reviewed by Adam Barth.
1792
1793         make platform/chromium/plugins/multiple-plugins.html pass on all platforms
1794         https://bugs.webkit.org/show_bug.cgi?id=49026
1795
1796         Have the testObject.bar property return the string "bar".  This lets
1797         us run and pass platform/chromium/plugins/multiple-plugins.html on all
1798         platforms.
1799
1800         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
1801         (testGetProperty):
1802
1803 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
1804
1805         Reviewed by Tony Chang.
1806
1807         NRWT doesn't have good test coverage for --run-chunk, --batch-size, --run-part, etc.
1808         https://bugs.webkit.org/show_bug.cgi?id=48878
1809         
1810         Add get_tests_run so that it's easy to see which tests get run (and with
1811         what batching) for a given flag combination. Flesh out the various
1812         test cases that have FIXMEs.
1813         
1814         Also fixes an off-by-one error (batch sizes were one larger than 
1815         expected) and makes --run-part also have wraparound behavior, like
1816         --run-chunk.
1817
1818         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1819         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1820         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1821
1822 2010-11-04  Erik Arvidsson  <arv@chromium.org>
1823
1824         Reviewed by Dimitri Glazkov.
1825
1826         Support box-sizing without the vendor prefix
1827         https://bugs.webkit.org/show_bug.cgi?id=36713
1828
1829         Based on patch by Peter Beverloo <peter@lvp-media.com>
1830
1831         * iExploder/htdocs/cssproperties.in: Change -webkit-box-sizing to box-sizing.
1832
1833 2010-11-04  Csaba Osztrogonác  <ossy@webkit.org>
1834
1835         Unreviewed rollout r71340, because it broke Chromium Windows bot.
1836
1837         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1838         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1839
1840 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1841
1842         Reviewed by Ojan Vafai.
1843
1844         Make http locking default in NRWT.
1845         https://bugs.webkit.org/show_bug.cgi?id=48053
1846
1847         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1848         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1849
1850 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1851
1852         Reviewed by Eric Seidel.
1853
1854         [NRWT] Clear invalid http locks on Windows platform as well
1855         https://bugs.webkit.org/show_bug.cgi?id=48515
1856
1857         * Scripts/webkitpy/common/system/executive.py:
1858         * Scripts/webkitpy/common/system/executive_unittest.py:
1859         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1860
1861 2010-11-02  Adam Roben  <aroben@apple.com>
1862
1863         Reduce our dependence on coreutils when running Python tests
1864
1865         This patch introduces versions of the standard echo and cat utilities
1866         implemented in Python. They are probably missing features of their
1867         coreutils equivalents, but they can do what's necessary for our Python
1868         tests. This is useful on Windows, where these utilities typically
1869         aren't available.
1870
1871         Fixes <http://webkit.org/b/48883> executive_unittest relies on echo
1872         and cat utilities from coreutils, which are not present on Windows
1873
1874         Reviewed by Eric Seidel.
1875
1876         * Scripts/webkitpy/common/system/executive_unittest.py: Changed to use
1877         our Python-based echo and cat.
1878
1879         * Scripts/webkitpy/common/system/fileutils.py: Added.
1880         (make_stdout_binary): On Windows, puts sys.stdout into binary mode so
1881         that \n won't be translated into \r\n. I couldn't think of a good way
1882         to test this directly without touching the filesystem, but it is tested
1883         indirectly by echo_unittest.
1884
1885         * Scripts/webkitpy/test/cat.py: Added.
1886         (command_arguments): Returns a list for invoking cat with the given arguments.
1887         (main): Acts like a simplified version of the coreutils cat utility.
1888
1889         * Scripts/webkitpy/test/cat_unittest.py: Added.
1890         (CatTest.assert_cat): Runs cat with the given input and ensures the
1891         output matches the input.
1892         (CatTest.test_basic): Performs a simple test of cat.
1893         (CatTest.test_no_newline): Tests what happens when the input string
1894         doesn't have a trailing newline.
1895         (CatTest.test_unicode): Tests passing a unicode string to cat.
1896         (CatTest.test_as_command): Tests running cat as a separate command.
1897
1898         * Scripts/webkitpy/test/echo.py: Added.
1899         (command_arguments): Returns a list for invoking echo with the given arguments.
1900         (main): Acts like a simplified version of the coreutils echo utility.
1901
1902         * Scripts/webkitpy/test/echo_unittest.py: Added.
1903         (EchoTest.test_basic): Performs a simple test of echo.
1904         (EchoTest.test_no_newline): Tests passing -n to echo to suppress the
1905         trailing newline.
1906         (EchoTest.test_unicode): Tests passing unicode and non-unicode strings
1907         to echo.
1908         (EchoTest.test_argument_order): Tests what happens when -n is not the
1909         first argument.
1910         (EchoTest.test_empty_arguments): Tests what happens when you pass [] to
1911         echo.main.
1912         (EchoTest.test_no_arguments): Tests what happens when you call
1913         echo.main with no arguments.
1914         (EchoTest.test_as_command): Tests running echo as a separate command.
1915
1916 2010-11-04  Renata Hodovan  <reni@inf.u-szeged.hu>
1917
1918         Unreviewed: Add myself to the list of Committers.
1919
1920         * Scripts/webkitpy/common/config/committers.py:
1921
1922 2010-11-04  Andreas Kling  <kling@webkit.org>
1923
1924         Reviewed by Kenneth Rohde Christiansen.
1925
1926         [Qt] Hook into QWebPage::scrollRequested for resizes-to-contents mode
1927
1928         In RTC mode the QGraphicsWebView item is the size of the contents,
1929         scrolling works a bit differently  (we need to react to scrollRequested.)
1930
1931         Normally QGraphicsView will replay the last mouse event when scrolling,
1932         so to prevent WebKit from getting confused by this we temporarily make
1933         the QGraphicsView non-interactive.
1934
1935         * QtTestBrowser/webview.cpp:
1936         (WebViewGraphicsBased::setPage):
1937         (WebViewGraphicsBased::scrollRequested):
1938         * QtTestBrowser/webview.h:
1939
1940 2010-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1941
1942         Reviewed by Andreas Kling.
1943
1944         Use OS(MAC_OS_X) rather than PLATFORM(MAC) in TestControllerQt
1945
1946         PLATFORM(MAC) is not defined for the Qt port, as it refers to
1947         the Mac-port, not the Mac OS X operating system.
1948
1949         * WebKitTestRunner/qt/TestControllerQt.cpp:
1950         (WTR::isExistingLibrary):
1951
1952 2010-11-04  Leonid Ebril  <leonid.ebril@nokia.com>
1953
1954         Reviewed by Andreas Kling.
1955
1956         [Qt] Adding iphone user agent string the user agent list for QtTestBrowser
1957         https://bugs.webkit.org/show_bug.cgi?id=48869
1958
1959         * QtTestBrowser/useragentlist.txt:
1960
1961 2010-11-03  Adam Roben  <aroben@apple.com>
1962
1963         Always use uppercase drive names in strings returned by abspath_to_uri
1964
1965         Some versions of cygpath use lowercase drive letters while others use
1966         uppercase, which makes it hard to test the output of code that uses
1967         cygpath.
1968
1969         Fixes <http://webkit.org/b/48914> webkitpy.common.system.path_unittest
1970         fails with Cygwin 1.5
1971
1972         Reviewed by Eric Seidel.
1973
1974         * Scripts/webkitpy/common/system/path.py:
1975         (cygpath): Updated the docstring to indicate that only absolute paths
1976         should be passed for now (though relative paths will work fine).
1977         (_Cygpath.convert): Upper-case the first letter of the converted Windows path.
1978
1979 2010-11-03  George Guo  <George.Guo@Nokia.com>
1980
1981         Reviewed by Andreas Kling.
1982
1983         [Qt] QtTestBrowser : set mmp rule pageddata in Symbian
1984         https://bugs.webkit.org/show_bug.cgi?id=48767
1985     
1986         Paging is needd on Symbian devices to support benchmarks tests like
1987         dromaeo.com and Celtic Kane that need a lot of memory to run  
1988
1989         * QtTestBrowser/QtTestBrowser.pro:
1990
1991 2010-11-03  Jenn Braithwaite  <jennb@chromium.org>
1992
1993         Reviewed by Dmitry Titov.
1994
1995         Chromium: Update resource tracking when moving a frame between documents
1996         https://bugs.webkit.org/show_bug.cgi?id=48363
1997
1998         * DumpRenderTree/chromium/WebViewHost.cpp:
1999         (WebViewHost::assignIdentifierToRequest):
2000         Always put resource id in map so we can make assumptions about its
2001         presence.
2002         (WebViewHost::removeIdentifierForRequest):
2003         Added.
2004         (WebViewHost::didFinishResourceLoad):
2005         (WebViewHost::didFailResourceLoad):
2006         Check existence of resource id before removing from map.
2007         * DumpRenderTree/chromium/WebViewHost.h:
2008
2009 2010-11-03  Victor Wang  <victorw@chromium.org>
2010
2011         Reviewed by Adam Barth.
2012
2013         [Chromium] update buildbot names in chromium rebaseline tool.
2014
2015         https://bugs.webkit.org/show_bug.cgi?id=48881
2016
2017         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2018
2019 2010-11-03  Darin Adler  <darin@apple.com>
2020
2021         Updated Xcode projects by opening them with Xcode 3.2.4.
2022         Updated svn:ignore for Xcode projects.
2023
2024         * MiniBrowser/MiniBrowser.xcodeproj: Added property svn:ignore.
2025         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added property svn:ignore.
2026         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2027         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.
2028
2029 2010-11-03  Adam Roben  <aroben@apple.com>
2030
2031         Stop waiting for messages from the web process after a timeout elapses
2032
2033         TestController::runUntil now takes a timeout parameter that specifies
2034         how long to wait for the condition to become true. WebKitTestRunner
2035         takes a --timeout flag that specifies how long the timeout should be.
2036         run-webkit-tests passes this flag to WebKitTestRunner so its timeout
2037         will be similar to run-webkit-tests.
2038
2039         Fixes <http://webkit.org/b/43047> <rdar://problem/8365833>
2040         WebKitTestRunner waits forever if the web process crashes
2041
2042         Reviewed by Darin Adler and Anders Carlsson.
2043
2044         * Scripts/old-run-webkit-tests:
2045         (top level): Moved the GuardMalloc timeout adjustment here from
2046         readFromDumpToolWithTimer.
2047         (openDumpTool): Make WTR use a timeout similar to but slightly shorter
2048         than the one that was specified on the command line.
2049
2050         * WebKitTestRunner/TestController.cpp:
2051         (WTR::TestController::TestController): Initialize our timeout values.
2052         (WTR::TestController::initialize): Parse the --timeout flag and use it
2053         to modify our timeout values.
2054         (WTR::TestController::resetStateToConsistentValues): Changed to use a
2055         short timeout while waiting for the web process to reset and to return
2056         a boolean indicating whether we were able to reset the web process.
2057         Uses a 5-second timeout while waiting for the process to be reset.
2058         (WTR::TestController::runTest): Changed to return a boolean indicating
2059         whether we were able to reset the web process (and thus run the test).
2060         (WTR::TestController::runUntil): Call through to platformRunUntil.
2061
2062         (WTR::TestController::runTestingServerLoop):
2063         (WTR::TestController::run):
2064         Changed to bail if any test can't be run. This will cause the process
2065         to exit. (Unfortunately this will make run-webkit-tests think we
2066         crashed; see <http://webkit.org/b/48943>.)
2067
2068         * WebKitTestRunner/TestController.h: Added platformRunUntil,
2069         m_longTimeout, and m_shortTimeout.
2070
2071         * WebKitTestRunner/TestInvocation.cpp:
2072         (WTR::TestInvocation::invoke): Use a short timeout when waiting for the
2073         initial response and a long timeout when waiting for the test to
2074         complete. Check whether runUntil timed out and print an error message
2075         if so.
2076
2077         * WebKitTestRunner/mac/TestControllerMac.mm:
2078         (WTR::TestController::platformRunUntil): Renamed from runUntil. Pass
2079         [NSDate distantPast] to -[NSRunLoop runMode:beforeDate:] so that we
2080         won't block waiting for the run loop. Only loop until the timeout
2081         elapses.
2082
2083         * WebKitTestRunner/qt/TestControllerQt.cpp:
2084         (WTR::TestController::platformRunUntil): Renamed from runUntil. Added a
2085         FIXME about honoring the timeout.
2086
2087         * WebKitTestRunner/win/TestControllerWin.cpp:
2088         (WTR::TestController::platformRunUntil): Renamed from runUntil. Use
2089         ::MsgWaitForMultipleObjectsEx to implement the timeout. Changed to use
2090         ::PeekMessageW so that we don't block waiting for messages to become
2091         available.
2092
2093 2010-11-03  Adam Roben  <aroben@apple.com>
2094
2095         Add a plugin test that evaluates JS after removing the plugin element
2096         from the document
2097
2098         This test replaces platform/win/plugins/plugin-delayed-destroy.html.
2099         That test was made to prevent a crash very similar to this one, but
2100         unfortunately tested only the mechanism that prevented the crash and
2101         not whether the crash itself was prevented. Since WebKit2 uses a
2102         different mechanism to prevent the crash, the test was failing even
2103         though WebKit2 was not vulnerable to the crash. This new test crashes
2104         if there is no mechanism in place to prevent it and passes in both
2105         WebKit1 and WebKit2.
2106
2107         Fixes <http://webkit.org/b/46711> <rdar://problem/8485903>
2108         platform/win/plugins/plugin-delayed-destroy.html fails in WebKit2
2109
2110         Reviewed by Anders Carlsson.
2111
2112         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2113         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2114         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2115         * GNUmakefile.am:
2116         Added new file.
2117
2118         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2119         (pluginDeallocate): Make sure we delete the PluginTest object. This
2120         prevents a leak and also allows us to test the crash.
2121
2122         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2123         (PluginTest::executeScript): Made this into a non-static member
2124         function.
2125
2126         (PluginTest::waitUntilDone):
2127         (PluginTest::notifyDone):
2128         Updated for changes to executeScript.
2129
2130         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added executeScript.
2131
2132         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp: Added.
2133         (EvaluateJSAfterRemovingPluginElement::EvaluateJSAfterRemovingPluginElement):
2134         Initialize ourselves and tell the test harness to wait.
2135         (EvaluateJSAfterRemovingPluginElement::NPP_DestroyStream): Remove our
2136         plugin element from the document, then execute some JavaScript. If
2137         WebKit does not have appropriate mechanisms in place, we'll be
2138         destroyed inside the first call to executeScript and crash on the
2139         second call.
2140
2141 2010-11-02  Stephen White  <senorblanco@chromium.org>
2142
2143         Reviewed by Tony Chang.
2144
2145         [chromium] Fix LayoutTestController UMRs.
2146         https://bugs.webkit.org/show_bug.cgi?id=48872
2147
2148         * DumpRenderTree/chromium/LayoutTestController.cpp:
2149         (LayoutTestController::LayoutTestController):
2150
2151 2010-11-03  Kent Tamura  <tkent@chromium.org>
2152
2153         Reviewed by Dimitri Glazkov.
2154
2155         REGRESSION: rebaseline-chromium-webkit-tests uses non-zero tolerance for
2156         image dup detection
2157         https://bugs.webkit.org/show_bug.cgi?id=48744
2158
2159         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2160          - Make a function for option parsing for ease of test
2161          - Set 0 to options.tolerance
2162         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2163          - Add a test for this change
2164
2165 2010-11-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2166
2167         Unreviewed: Add myself to the list of Committers.
2168
2169         * Scripts/webkitpy/common/config/committers.py:
2170
2171 2010-11-02  Anders Carlsson  <andersca@apple.com>
2172
2173         Fix build.
2174
2175         * TestWebKitAPI/PlatformUtilities.cpp:
2176         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2177
2178 2010-11-02  Sam Weinig  <sam@webkit.org>
2179
2180         Reviewed by Anders Carlsson.
2181
2182         Add a way to send startup messages on the context which can be posted when a process launches
2183         <rdar://problem/8617928>
2184         https://bugs.webkit.org/show_bug.cgi?id=48838
2185
2186         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2187         (WKBundleInitialize):
2188         * TestWebKitAPI/InjectedBundleController.cpp:
2189         (TestWebKitAPI::InjectedBundleController::initialize):
2190         (TestWebKitAPI::InjectedBundleController::didReceiveMessage):
2191         * TestWebKitAPI/InjectedBundleController.h:
2192         * TestWebKitAPI/InjectedBundleMain.cpp:
2193         (WKBundleInitialize):
2194         * TestWebKitAPI/PlatformUtilities.cpp:
2195         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2196         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2197         (WKBundleInitialize):
2198         Update implementations of WKBundleInitialize to take an initial userData
2199         argument.  Change TestWebKitAPI to use the new initial userData to initialize
2200         each test's bundle.
2201
2202 2010-11-02  Benjamin Kalman  <kalman@google.com>
2203
2204         Reviewed by Ojan Vafai.
2205
2206         new-run-webkit-tests doesn't strip "LayoutTests/" from prefix, unlike old-run-webkit-tests
2207         https://bugs.webkit.org/show_bug.cgi?id=48794
2208
2209         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Strip the "LayoutTests/" prefix from test argument paths.
2210
2211 2010-11-02  Adam Roben  <aroben@apple.com>
2212
2213         Skip webkitpy.layout_tests.run_webkit_tests_unittest.MainTest on Cygwin
2214         Python 2.5.x
2215
2216         It is known to hang on that version of Python. See
2217         <http://webkit.org/b/48614>.
2218
2219         Reviewed by Adam Barth.
2220
2221         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Use
2222         skip_if to skip MainTest on Cygwin Python 2.5.x.
2223
2224         * Scripts/webkitpy/test/skip.py: Added.
2225         (skip_if): If the passed-in condition is false, find all the test_*
2226         methods of the given class and replace them with a function that just
2227         logs that we're skipping these tests. This is loosely based on the
2228         unittest.skip_if decorator added in Python 3.1.
2229         (_skipped_method): Returns a function that just logs that the tests are
2230         being skipped. This is used in place of the actual test_* functions.
2231
2232         * Scripts/webkitpy/test/skip_unittest.py: Added.
2233         (SkipTest.setUp): Create a logger for ourselves and give it a handler
2234         that logs to a private stream.
2235         (SkipTest.tearDown): Reset the logger.
2236         (SkipTest.create_fixture_class): Returns a class that we use to test
2237         skip_if. It has a single test_* method, test_foo, that just calls
2238         through to a callback.
2239         (SkipTest.foo_callback): Record that test_foo was called.
2240         (SkipTest.test_skip_if_false): Pass skip_if a False condition and test
2241         that test_foo does get called.
2242         (SkipTest.test_skip_if_true): Pass skip_if a True condition and test
2243         that test_foo does not get called and the appropriate message gets
2244         logged.
2245
2246 2010-11-02  Adam Barth  <abarth@webkit.org>
2247
2248         Reviewed by Eric Seidel.
2249
2250         webkit-patch should tell check-webkit-style which files were changed so
2251         check-webkit-style doesn't have to stat the whole working copy again
2252         https://bugs.webkit.org/show_bug.cgi?id=48792
2253
2254         * Scripts/webkitpy/tool/mocktool.py:
2255         * Scripts/webkitpy/tool/steps/checkstyle.py:
2256
2257 2010-11-02  Robert Kroeger  <rjkroege@chromium.org>
2258
2259         Reviewed by James Robinson.
2260
2261         [Chromium/DRT] Make EventSendingController honour leapForward for touch events.
2262         https://bugs.webkit.org/show_bug.cgi?id=48777
2263
2264         * DumpRenderTree/chromium/EventSender.cpp:
2265         (EventSender::sendCurrentTouchEvent):
2266
2267 2010-11-02  Adam Roben  <aroben@apple.com>
2268
2269         Only track resource identifiers in DRT when dumpResourceLoadCallbacks
2270         is on
2271
2272         This reverts Windows to our pre-r71097 behavior. That patch made us
2273         track all resource identifiers, including the main resource, so the
2274         main resource's URL started appearing in test output instead of
2275         "<unknown>". Arguably having the main resource's URL is better, but all
2276         other platforms print "<unknown>" and we want to match.
2277
2278         Fixes <http://webkit.org/b/48837> <rdar://problem/8620351> REGRESSION
2279         (r71097): Many http tests failing on Windows
2280
2281         Reviewed by Anders Carlsson.
2282
2283         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2284         (ResourceLoadDelegate::identifierForInitialRequest): Don't add the
2285         identifier to the URL map if we're not supposed to dump resource load
2286         callbacks.
2287         (ResourceLoadDelegate::removeIdentifierForRequest): Always remove the
2288         identifier from the URL map even if we're already "done". There's no
2289         point in keeping out-of-date identifiers around.
2290
2291 2010-11-01  Jenn Braithwaite  <jennb@chromium.org>
2292
2293         Reviewed by Adam Roben.
2294
2295         Windows: Update resource tracking when moving a frame between documents
2296         https://bugs.webkit.org/show_bug.cgi?id=48364
2297
2298         * DumpRenderTree/win/DumpRenderTree.cpp:
2299         (createWebViewAndOffscreenWindow):
2300         (main):
2301         Give each WebView its own ResourceLoadDelegate instance in order to
2302         make assertions about resource ids on a particular WebView.
2303         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2304         (ResourceLoadDelegate::identifierForInitialRequest):
2305         Always add id to the map.
2306         (ResourceLoadDelegate::removeIdentifierForRequest):
2307         Added.
2308         (ResourceLoadDelegate::willSendRequest):
2309         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2310         (ResourceLoadDelegate::didReceiveResponse):
2311         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2312         (ResourceLoadDelegate::didFailLoadingWithError):
2313         (ResourceLoadDelegate::descriptionSuitableForTestResult):
2314         Replace static descriptionSuitableForTestResult with static member function to access identifier map.
2315         * DumpRenderTree/win/ResourceLoadDelegate.h:
2316         (ResourceLoadDelegate::urlMap):
2317         Moved within class so that each WebView has its own id map.
2318
2319 2010-11-01  Ojan Vafai  <ojan@chromium.org>
2320
2321         Reviewed by Dimitri Glazkov.
2322
2323         remove debug code from run_webkit_tests.py
2324         https://bugs.webkit.org/show_bug.cgi?id=48800
2325
2326         Remove temporary debug code and make --master-name required
2327         if --test-results-server is set now that all clients set
2328         --master-name.
2329
2330         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2331
2332 2010-11-01  Tony Chang  <tony@chromium.org>
2333
2334         Reviewed by Kent Tamura.
2335
2336         add plugin event logging for linux
2337         https://bugs.webkit.org/show_bug.cgi?id=48779
2338
2339         This is taken from Chromium's fork of the layout test plugin:
2340         http://git.chromium.org/gitweb/?p=chromium.git/.git;a=blob;f=webkit/tools/npapi_layout_test_plugin/main.cpp;h=3ebdada2f049b3624756438cff852364f86a2ede;hb=HEAD#l348
2341
2342         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2343         (handleEventX11):
2344         (NPP_HandleEvent):
2345
2346 2010-11-01  Dirk Pranke  <dpranke@chromium.org>
2347
2348         Reviewed by James Robinson.
2349
2350         new-run-webkit-tests: use DRT, child-processes=1 for GPU tests by default
2351         https://bugs.webkit.org/show_bug.cgi?id=48790
2352
2353         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2354         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2355
2356 2010-11-01  Adam Barth  <abarth@webkit.org>
2357
2358         Reviewed by Eric Seidel.
2359
2360         Teach check-webkit-style how to accept a list of files to diff on the
2361         command line
2362         https://bugs.webkit.org/show_bug.cgi?id=48784
2363
2364         In a future patch, webkit-patch will use this option to improve
2365         performance.  I'm landing this in two pieces to avoid causing a version
2366         skew problem for the style-bot.
2367
2368         * Scripts/check-webkit-style:
2369         * Scripts/webkitpy/style/optparser.py:
2370         * Scripts/webkitpy/style/optparser_unittest.py:
2371         * Scripts/webkitpy/style_references.py:
2372
2373 2010-11-01  Anders Carlsson  <andersca@apple.com>
2374
2375         Reviewed by John Sullivan.
2376
2377         Tear down the related WebProcessProxy when a WebContext is deallocated
2378         https://bugs.webkit.org/show_bug.cgi?id=48769
2379
2380         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2381         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
2382         We don't support empty URLs anymore, update test to expect a null URL instead.
2383
2384 2010-11-01  Søren Gjesse  <sgjesse@chromium.org>
2385
2386         Reviewed by Andreas Kling.
2387
2388         Fix warning when compiling the chromium port of DumpRenderShell
2389         with clang.
2390         https://bugs.webkit.org/show_bug.cgi?id=48414
2391
2392         * DumpRenderTree/chromium/TestShell.h:
2393         (TestShell::javaScriptFlagsForLoad):
2394
2395 2010-11-01  Adam Roben  <aroben@apple.com>
2396
2397         Fix typo from r71022
2398
2399         * BuildSlaveSupport/build.webkit.org-config/config.json:
2400
2401 2010-11-01  Adam Roben  <aroben@apple.com>
2402
2403         Trigger the Windows Release WebKit2 tests when a Release build
2404         finishes, not when a Debug build finishes
2405
2406         Fixes <http://webkit.org/b/48754> Windows Release WebKit2 tests are
2407         triggered at the wrong time
2408
2409         Reviewed by Sam Weinig.
2410
2411         * BuildSlaveSupport/build.webkit.org-config/config.json: Fixed
2412         triggerable name and trigger.
2413
2414 2010-11-01  Mario Sanchez Prada  <msanchez@igalia.com>
2415
2416         Unreviewed. Adding my IRC nickname to the list of committers.
2417
2418         * Scripts/webkitpy/common/config/committers.py:
2419
2420 2010-10-31  Robert Hogan  <robert@webkit.org>
2421
2422         Reviewed by Antonio Gomes.
2423
2424         [Qt] [Gtk] Plug-ins having upper case in mime type are failing to load
2425
2426         Qt and Gtk are case-sensitive when storing the declared mime-type
2427         of plugins. Since plugin mime-types are lowercased prior to searching
2428         for them in the plugin database, ensure they are loaded with the
2429         mime-type in lower case too.
2430
2431         Change the test netscape plugin to declare its mimetype in sentence
2432         case so that the correct behaviour is enforced.
2433
2434         https://bugs.webkit.org/show_bug.cgi?id=36815
2435
2436         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2437         (NP_GetMIMEDescription):
2438
2439 2010-10-31  Robert Hogan  <robert@webkit.org>
2440
2441         Reviewed by Antonio Gomes.
2442
2443         [Qt] Support nodesFromRect in DRT
2444
2445         https://bugs.webkit.org/show_bug.cgi?id=48716
2446
2447         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2448         (LayoutTestController::nodesFromRect):
2449         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2450
2451 2010-10-30  Andreas Kling  <kling@webkit.org>
2452
2453         Reviewed by Antonio Gomes.
2454
2455         [Qt] QtTestBrowser: Switching view type moves the embedded inspector
2456         https://bugs.webkit.org/show_bug.cgi?id=48705
2457
2458         Reinsert the embedded inspector into the splitter after changing
2459         between QWebView/QGraphicsWebView.
2460
2461         * QtTestBrowser/launcherwindow.cpp:
2462         (LauncherWindow::init):
2463         (LauncherWindow::initializeView):
2464         * QtTestBrowser/webinspector.h:
2465         (WebInspector::WebInspector):
2466
2467 2010-10-28  Antonio Gomes  <agomes@rim.com>
2468
2469         Reviewed by Ojan Vafai.
2470
2471         Needs a "LinuxEditingBehavior", perhaps with a better name
2472         https://bugs.webkit.org/show_bug.cgi?id=36627
2473
2474         Adding support to Mac's, GTK+'s, Windows' and Chromium's LayoutTestController class to test the newly introduced Unix editing behavior.
2475
2476         * DumpRenderTree/chromium/LayoutTestController.cpp:
2477         (LayoutTestController::setEditingBehavior):
2478         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2479         (LayoutTestController::setEditingBehavior):
2480         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2481         (LayoutTestController::setEditingBehavior):
2482         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2483         (LayoutTestController::setEditingBehavior):
2484
2485 2010-10-29  Andreas Kling  <kling@webkit.org>
2486
2487         Reviewed by Kenneth Rohde Christiansen.
2488
2489         [Qt] QtTestBrowser: Add keyboard shortcut to toggle full screen (F11)
2490         https://bugs.webkit.org/show_bug.cgi?id=48695
2491
2492         * QtTestBrowser/launcherwindow.cpp:
2493         (LauncherWindow::createChrome):
2494
2495 2010-10-29  Andreas Kling  <kling@webkit.org>
2496
2497         Reviewed by Kenneth Rohde Christiansen.
2498
2499         [Qt] QtTestBrowser: Fix uninitialized read in FpsTimer
2500         https://bugs.webkit.org/show_bug.cgi?id=48675
2501
2502         FpsTimer::m_timer was never initialized and passed to QObject::killTimer()
2503         on startup with in -graphicsbased mode.
2504
2505         * QtTestBrowser/fpstimer.cpp:
2506         (FpsTimer::FpsTimer):
2507         (FpsTimer::numFrames):
2508         (FpsTimer::stop):
2509         (FpsTimer::timerEvent):
2510         * QtTestBrowser/fpstimer.h:
2511
2512 2010-10-29  Dirk Pranke  <dpranke@chromium.org>
2513
2514         Reviewed by Tony Chang.
2515
2516         new-run-webkit-tests: change TestResults to be serializable
2517
2518         In preparation for changing new-run-webkit-tests from
2519         multithreaded to multiprocess, we need to make sure the data
2520         going between the threads is easily serialized over a socket.
2521
2522         This change adds serialization/pickling for the TestResults and
2523         TestFailure objects (using cPickle).
2524
2525         The TestFailure objects included a "has_wdiff" flag for Text
2526         results, but the flag wasn't being used, so I've removed it,
2527         simplifying the state to basically a set of enum objects with
2528         associated methods.
2529
2530         https://bugs.webkit.org/show_bug.cgi?id=48616
2531
2532         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2533         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2534         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2535         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
2536         * Scripts/webkitpy/layout_tests/layout_package/test_results.py: Added.
2537         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:Added. 
2538         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2539         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2540
2541 2010-10-29  Dirk Pranke  <dpranke@chromium.org>
2542
2543         Reviewed by Ojan Vafai.
2544
2545         new-run-webkit-tests: need to provide separate dashboard results for GPU tests
2546         https://bugs.webkit.org/show_bug.cgi?id=48687
2547
2548         Modify the steps to upload the JSON files to the dashboards so
2549         that the GPU tests don't conflict with the regular tests on a
2550         port. We do this by modifying the --builder-name parameter to
2551         append " - GPU", which should cause the app to treat the results
2552         as a completely new builder. This is a little non-obvious, but
2553         keeps us from having to restructure the app.
2554
2555         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2556         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2557         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2558
2559 2010-10-29  Ojan Vafai  <ojan@chromium.org>
2560
2561         Reviewed by Tony Chang.
2562
2563         [chromium] add debug logging to help diagnose flakiness dashboard issues
2564         https://bugs.webkit.org/show_bug.cgi?id=48657
2565
2566         The appengine app thinks it's getting empty files uploaded. Add some logging
2567         to see if new-run-webkit-tests agrees.
2568         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2569
2570 2010-10-29  Dimitri Glazkov  <dglazkov@chromium.org>
2571
2572         Reviewed by Ojan Vafai.
2573
2574         [Chromium/DRT] Add master-name flag to new-run-webkit-tests.
2575         https://bugs.webkit.org/show_bug.cgi?id=48649
2576
2577         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added flag.
2578
2579 2010-10-29  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2580
2581         Reviewed by Martin Robinson.
2582
2583         Enable popup window in GtkLauncher
2584         https://bugs.webkit.org/show_bug.cgi?id=48335
2585
2586         The GtkLauncher application does not support opening new window when
2587         a link with "target=_blank" is clicked or similar call to
2588         window.open(). Instead, GtkLauncher does nothing which breaks
2589         navigation of some websites.
2590
2591         * GtkLauncher/main.c:
2592         (activate_uri_entry_cb):
2593         (update_title):
2594         (link_hover_cb):
2595         (notify_title_cb):
2596         (notify_load_status_cb):
2597         (notify_progress_cb):
2598         (destroy_cb):
2599         (go_back_cb):
2600         (go_forward_cb):
2601         (create_web_view_cb):
2602         (web_view_ready_cb):
2603         (close_web_view_cb):
2604         (create_browser):
2605         (create_statusbar):
2606         (create_toolbar):
2607         (create_window):
2608         (main):
2609
2610 2010-10-29  Adam Roben  <aroben@apple.com>
2611
2612         Teach check-webkit-style about WebKit2's idiosyncracies
2613
2614         Fixes <http://webkit.org/b/48638> Style bot complains about a number
2615         of WebKit2 conventions
2616
2617         Reviewed by Anders Carlsson.
2618
2619         * Scripts/webkitpy/style/checker.py: Excluded some rules for various
2620         WebKit2-related files. Also updated the excluded rules for
2621         WebKitAPITest to match the current code.
2622
2623 2010-10-29  Csaba Osztrogonác  <ossy@webkit.org>
2624
2625         Reviewed by Adam Roben and David Kilzer.
2626
2627         Fix and cleanup of build systems
2628         https://bugs.webkit.org/show_bug.cgi?id=48342
2629
2630         * Scripts/build-webkit:
2631          - Remove unnecessary ENABLE_SANDBOX option.
2632          - Add ENABLE_FULLSCREEN_API option.
2633
2634 2010-10-28  Adam Roben  <aroben@apple.com>
2635
2636         Switch the Windows WebKit2 bot to the Release configuration
2637
2638         We only have one machine testing WebKit2 on Windows right now, and
2639         Debug is just too slow for it to keep up.
2640
2641         Fixes (hopefully!) <http://webkit.org/b/48615> Windows WebKit2 bot is
2642         always way behind
2643
2644         Reviewed by Jon Honeycutt.
2645
2646         * BuildSlaveSupport/build.webkit.org-config/config.json:
2647
2648 2010-10-29  Leandro Gracia Gil  <leandrogracia@google.com>
2649
2650         Reviewed by Jeremy Orlow.
2651
2652         Added a second parameter to setMockSpeechInputResult for
2653         the language used in speech input.
2654         https://bugs.webkit.org/show_bug.cgi?id=47089
2655
2656         * DumpRenderTree/LayoutTestController.cpp:
2657         (setMockSpeechInputResultCallback):
2658         * DumpRenderTree/LayoutTestController.h:
2659         * DumpRenderTree/chromium/LayoutTestController.cpp:
2660         (LayoutTestController::setMockSpeechInputResult):
2661         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2662         (LayoutTestController::setMockSpeechInputResult):
2663         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2664         (LayoutTestController::setMockSpeechInputResult):
2665         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2666         (LayoutTestController::setMockSpeechInputResult):
2667         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2668         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2669         (LayoutTestController::setMockSpeechInputResult):
2670         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2671         (LayoutTestController::setMockSpeechInputResult):
2672         (LayoutTestController::pageSizeAndMarginsInPixels):
2673
2674 2010-10-28  Ojan Vafai  <ojan@chromium.org>
2675
2676         Reviewed by Tony Chang.
2677
2678         [chromium] add a result-small.json file for the test dashboard
2679         https://bugs.webkit.org/show_bug.cgi?id=48547
2680
2681         Output both a results.json file and a results-small.json file.
2682         The dashboard will load results-small.json by default so it loads faster.
2683
2684         * TestResultServer/model/jsonresults.py:
2685         * TestResultServer/model/jsonresults_unittest.py:
2686         Added a bunch of sys.path hackery. Unforunately, this uses hardcoded
2687         paths. That obviously needs to be fixed, but at least this way it
2688         clearly documents what paths are necessary.
2689
2690 2010-10-28  Eric Seidel  <eric@webkit.org>
2691
2692         Reviewed by Adam Barth.
2693
2694         webkit-patch upload calls changed_files more often than it should
2695         https://bugs.webkit.org/show_bug.cgi?id=48567
2696
2697         Passing changed_files around everywhere isn't a very elegant solution
2698         but it's the one we have for the moment.  I think keeping an explicit
2699         cache on Checkout (or making StepState() a real class) is a better
2700         long-term option.
2701
2702         Previously bug_id_for_this_commit was calling changed_files and the
2703         result was never getting cached on the state.  Now we're explicitly
2704         caching the result on the state and passing that to the bug_id_for_this_commit call.
2705
2706         I looked into building unit tests for this.  Doing so would require
2707         using a real Checkout object with a MockSCM and overriding the appropriate
2708         calls on SCM to count how often we're stating the file system.
2709         That's a useful set of tests to build for a separate change.
2710
2711         * Scripts/webkitpy/common/checkout/api.py:
2712         * Scripts/webkitpy/tool/commands/download.py:
2713         * Scripts/webkitpy/tool/commands/upload.py:
2714         * Scripts/webkitpy/tool/mocktool.py:
2715
2716 2010-10-28  Eric Seidel  <eric@webkit.org>
2717
2718         Reviewed by Adam Barth.
2719
2720         Make suggest-reviewers slightly faster
2721         https://bugs.webkit.org/show_bug.cgi?id=48562
2722
2723         Add @memoized to one more common call.
2724
2725         * Scripts/webkitpy/common/checkout/api.py:
2726
2727 2010-10-28  Eric Seidel  <eric@webkit.org>
2728
2729         Reviewed by Adam Barth.
2730
2731         webkit-patch suggest-reviewers -g 260550a6e30b7bf34f16bdb4a5396cf26264fc1c is still very slow
2732         https://bugs.webkit.org/show_bug.cgi?id=48536
2733
2734         This patch makes it about 40 seconds faster, but it still
2735         takes 1:40.  This will require more refinement.
2736
2737         The suggested reviewers list appears to be the same.
2738
2739         I think the next step may be to have it stop the search after
2740         5 reviewers are found.  We never want to suggest 30 people.
2741
2742         * Scripts/webkitpy/common/checkout/scm.py:
2743          - Using --remove-empty to theoretically stop lookups past
2744            when a file is removed.  I'm not entirely clear that the option
2745            does what it says it does.  Example:
2746            git log --pretty=format:%H -5 --remove-empty -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h
2747            returns only one commit
2748            vs.
2749            git log --pretty=format:%H -5 -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h
2750            which returns 5.  I was not aware that wx files were ever removed from the repository?
2751
2752 2010-10-28  Kinuko Yasuda  <kinuko@chromium.org>
2753
2754         Reviewed by David Levin.
2755
2756         [Chromium] Support FileSystem in chromium DRT
2757         https://bugs.webkit.org/show_bug.cgi?id=47643
2758
2759         * DumpRenderTree/chromium/WebViewHost.cpp:
2760         (WebViewHost::openFileSystem): Added.
2761         * DumpRenderTree/chromium/WebViewHost.h:
2762         (WebViewHost::openFileSystem): Added.
2763
2764 2010-10-28  Sam Weinig  <sam@webkit.org>
2765
2766         Reviewed by Anders Carlsson.
2767
2768         WKURLRefs should be allowed to be null
2769         <rdar://problem/8575621>
2770         https://bugs.webkit.org/show_bug.cgi?id=48535
2771
2772         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2773         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2774         (TestWebKitAPI::didStartProvisionalLoadForFrame):
2775         (TestWebKitAPI::didCommitLoadForFrame):
2776         (TestWebKitAPI::didFinishLoadForFrame):
2777         Test that URLs are null pointers when unset.
2778
2779 2010-10-28  Chris Fleizach  <cfleizach@apple.com>
2780
2781         Reviewed by Adele Peterson.
2782
2783         AX: multi select group option does not handle setting of AXSelectedChildren correctly
2784         https://bugs.webkit.org/show_bug.cgi?id=48464
2785
2786         Add support for querying information about selected children to DRT, including:
2787            selectedChildAtIndex
2788            selectedChildrenCount
2789            setSelectedChild
2790
2791         * DumpRenderTree/AccessibilityUIElement.cpp:
2792         (selectedChildAtIndexCallback):
2793         (setSelectedChildCallback):
2794         (selectedChildrenCountCallback):
2795         (AccessibilityUIElement::setSelectedChild):
2796         (AccessibilityUIElement::selectedChildrenCount):
2797         (AccessibilityUIElement::selectedChildAtIndex):
2798         (AccessibilityUIElement::getJSClass):
2799         * DumpRenderTree/AccessibilityUIElement.h:
2800         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2801         (AccessibilityUIElement::selectedChildAtIndex):
2802         (AccessibilityUIElement::selectedChildrenCount):
2803         (AccessibilityUIElement::setSelectedChild):
2804
2805 2010-10-27  Sam Weinig  <sam@webkit.org>
2806
2807         Reviewed by Anders Carlsson.
2808
2809         Add WebKit2 API for window feature getter/setters
2810         <rdar://problem/8590373>
2811         https://bugs.webkit.org/show_bug.cgi?id=48496
2812
2813         * MiniBrowser/mac/BrowserWindowController.m:
2814         (-[BrowserWindowController awakeFromNib]):
2815         * MiniBrowser/win/BrowserView.cpp:
2816         (BrowserView::create):
2817         * WebKitTestRunner/TestController.cpp:
2818         (WTR::createOtherPage):
2819         (WTR::TestController::initialize):
2820
2821 2010-10-28  Søren Gjesse  <sgjesse@chromium.org>
2822
2823         Reviewed by Tony Chang.
2824
2825         Added support for the DumpRenderTree flags --multiple-loads and --js-flags to the Python test runner.
2826         https://bugs.webkit.org/show_bug.cgi?id=48236
2827
2828         * Scripts/webkitpy/layout_tests/port/chromium.py:
2829         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2830
2831 2010-10-28  Sergio Villar Senin  <svillar@igalia.com>
2832
2833         Reviewed by Martin Robinson.
2834
2835         [GTK] WebKitWebFrame's load-status is not properly notified to the tests
2836         https://bugs.webkit.org/show_bug.cgi?id=48048
2837
2838         DRT now listens to WebKitWebFrame load-status signals for each
2839         created frame instead of the load-status signal of the
2840         WebKitWebView that only notifies about changes in the main frame.
2841
2842         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2843         (webViewLoadFinished):
2844         (webFrameLoadStatusNotified):
2845         (frameCreatedCallback):
2846         (createWebView):
2847         (main):
2848
2849 2010-10-28  Tony Chang  <tony@chromium.org>
2850
2851         Reviewed by Kent Tamura.
2852
2853         [chromium] fix textInputController.{selectedRange,markedRange}
2854         https://bugs.webkit.org/show_bug.cgi?id=48487
2855
2856         * DumpRenderTree/chromium/TextInputController.cpp:
2857         (TextInputController::markedRange): Return arrays of ints, rather than a string
2858         (TextInputController::selectedRange): Ditto.
2859
2860 2010-10-27  Ojan Vafai  <ojan@chromium.org>
2861
2862         Reviewed by Tony Chang.
2863
2864         [chromium] add a master-name flag to new-run-webkit-tests
2865         https://bugs.webkit.org/show_bug.cgi?id=48488
2866
2867         The test results server now allows adding a master name to
2868         the uploaded files. This lets us distinguish bots that have
2869         the same name, but are on different masters.
2870
2871         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2872
2873 2010-10-28  Adam Roben  <aroben@apple.com>
2874
2875         Don't append a newline to the test output if the frame has no document
2876         element in WebKitTestRunner
2877
2878         Fixes <http://webkit.org/b/48526> Extra trailing newline when running
2879         plugins/document-open.html in WebKitTestRunner
2880
2881         Reviewed by Anders Carlsson.
2882
2883         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2884         (WTR::toJS): Added. Turns a UTF-8 C string into a JSStringRef.
2885         (WTR::hasDocumentElement): Added. Uses the JSC API to figure out
2886         whether the frame has a document element.
2887         (WTR::dumpFrameText): Match DRT by bailing (rather than appending an
2888         empty string and a newline) if the frame has no document element.
2889
2890 2010-10-28  Adam Roben  <aroben@apple.com>
2891
2892         Skip npn-invalidate-rect-invalidates-window.html on headless XP
2893         machines
2894
2895         TestNetscapePlugIn never receives a WM_PAINT message on headless XP
2896         machines, so this test times out. Fixing the test is covered by
2897         <http://webkit.org/b/48333>.
2898
2899         * Scripts/old-run-webkit-tests: Skip
2900         npn-invalidate-rect-invalidates-window.html on Windows if accelerated
2901         compositing support is disabled, which likely means we're on a headless
2902         XP machine.
2903
2904 2010-10-28  Kimmo Kinnunen  <kimmok@iki.fi>
2905
2906         Adding myself as a committer.
2907
2908         * Scripts/webkitpy/common/config/committers.py:
2909
2910 2010-10-27  Eric Seidel  <eric@webkit.org>
2911
2912         Reviewed by Adam Barth.
2913
2914         webkit-patch suggest-reviewers -g 260550a6e30b7bf34f16bdb4a5396cf26264fc1c is very slow
2915         https://bugs.webkit.org/show_bug.cgi?id=48500
2916
2917         This doesn't fix the problem, but it makes things slightly better.
2918         Each git svn find-rev call takes about .25 seconds on my desktop.
2919         This patch uses a new memoized class to avoid those calls when possible.
2920
2921         The real slowness is still git log on some files, like:
2922         git log --pretty=format:%H -5 -- /Projects/WebKit/WebCore/platform/wx/SearchPopupMenuWx.h
2923         I'm not yet sure how to make the pathological git logs better.
2924
2925         * Scripts/webkitpy/common/checkout/scm.py:
2926         * Scripts/webkitpy/common/memoized.py: Added.
2927         * Scripts/webkitpy/common/memoized_unittest.py: Added.
2928
2929 2010-10-27  Eric Seidel  <eric@webkit.org>
2930
2931         Reviewed by Ojan Vafai.
2932
2933         EWS bots should not use --quiet when running build-webkit
2934         https://bugs.webkit.org/show_bug.cgi?id=48482
2935
2936         --quiet is only correct when the sub-process does the error reporting.
2937         In the case of _can_build() the parent process is reporting the error.
2938         We'd like the full build log at queues.webkit.org so someone can look
2939         at the log and understand why the EWS is failing to build trunk.
2940
2941         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2942         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2943         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2944         * Scripts/webkitpy/tool/mocktool.py:
2945
2946 2010-10-27  Brian Weinstein  <bweinstein@apple.com>
2947
2948         More Windows build fixage. Rename a variable that was named string.
2949
2950         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2951         (WTR::hasPrefix):
2952
2953 2010-10-27  Ojan Vafai  <ojan@chromium.org>
2954
2955         Reviewed by Dimitri Glazkov.
2956
2957         [chromium] Make the test results server store which master the bot is on
2958         https://bugs.webkit.org/show_bug.cgi?id=48478
2959
2960         The chromium bots recently changed so that there are multiple slaves with
2961         the same name on different masters. Up till now, the test results server
2962         assumed slave names were unique. Adds a master field to the file in order
2963         to distinguish.
2964
2965         Also, for files that currently lack a master or testtype, set them appropriately.
2966
2967         * TestResultServer/handlers/testfilehandler.py:
2968         * TestResultServer/index.yaml:
2969         * TestResultServer/model/jsonresults.py:
2970         * TestResultServer/model/testfile.py:
2971         * TestResultServer/templates/showfilelist.html:
2972         * TestResultServer/templates/uploadform.html:
2973
2974 2010-10-26  Darin Adler  <darin@apple.com>
2975
2976         Reviewed by Sam Weinig.
2977
2978         WebKitTestRunner needs to support layoutTestController.dumpBackForwardList
2979         https://bugs.webkit.org/show_bug.cgi?id=42322
2980         rdar://problem/8193631
2981
2982         WebKitTestRunner needs to support layoutTestController.clearBackForwardList
2983         https://bugs.webkit.org/show_bug.cgi?id=42333
2984         rdar://problem/8193643
2985
2986         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2987         Renamed the product to WebKitTestRunnerInjectedBundle to avoid
2988         name conflicts in the build directory.
2989
2990         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2991         Added dumpBackForwardList and clearBackForwardList.
2992
2993         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2994         (WTR::InjectedBundle::InjectedBundle): Removed initialization of m_mainPage.
2995         (WTR::InjectedBundle::didCreatePage): Removed unneeded underscore.
2996         (WTR::InjectedBundle::willDestroyPage): Ditto.
2997         (WTR::InjectedBundle::didReceiveMessage): Ditto.
2998         (WTR::InjectedBundle::initialize): Ditto.
2999         (WTR::InjectedBundle::didCreatePage): Changed code to use m_pages
3000         instead of m_mainPage and m_otherPages.
3001         (WTR::InjectedBundle::willDestroyPage): Ditto.
3002         (WTR::InjectedBundle::page): Ditto.
3003         (WTR::InjectedBundle::beginTesting): Ditto.
3004         (WTR::InjectedBundle::done): Ditto.
3005         (WTR::InjectedBundle::closeOtherPages): Ditto.
3006         (WTR::InjectedBundle::dumpBackForwardListsForAllPages): Added.
3007
3008         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Changed
3009         page function to longer be inline, and pageCount function
3010         to use m_pages. Added dumpBackForwardListsForAllPages, and
3011         removed some underscores. Replaced m_mainPage and m_otherPageas
3012         with m_pages.
3013
3014         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3015         (WTR::adoptWK): Added.
3016         (WTR::hasPrefix): Added.
3017         (WTR::InjectedBundlePage::reset): Added code to set up
3018         m_previousTestBackForwardListItem.
3019         (WTR::InjectedBundlePage::dump): Added code to call
3020         dumpBackForwardListsForAllPages.
3021         (WTR::compareByTargetName): Added.
3022         (WTR::dumpBackForwardListItem): Added.
3023         (WTR::InjectedBundlePage::dumpBackForwardList): Added.
3024
3025         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added
3026         dumpBackForwardList and m_previousTestBackForwardListItem.
3027
3028         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3029         (WTR::LayoutTestController::LayoutTestController): Initialize
3030         m_shouldDumpBackForwardListsForAllWindows to false.
3031         (WTR::LayoutTestController::clearBackForwardList): Added.
3032
3033         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3034         Added dumpBackForwardList, clearBackForwardList,
3035         shouldDumpBackForwardListsForAllWindows, and
3036         m_shouldDumpBackForwardListsForAllWindows.
3037
3038         * WebKitTestRunner/TestController.cpp:
3039         (WTR::TestController::initialize): Set up
3040         didReceiveSynchronousMessageFromInjectedBundle.
3041         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3042         Added.
3043         * WebKitTestRunner/TestController.h: Ditto.
3044
3045         * WebKitTestRunner/TestInvocation.cpp:
3046         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3047         Added.
3048         * WebKitTestRunner/TestInvocation.h: Ditto.
3049
3050         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3051         Renamed bundle to WebKitTestRunnerInjectedBundle (see above).
3052         * WebKitTestRunner/mac/TestControllerMac.mm:
3053         (WTR::TestController::initializeInjectedBundlePath): Ditto.
3054
3055 2010-10-27  Chris Rogers  <crogers@google.com>
3056
3057         Reviewed by Chris Marrin.
3058
3059         Add ENABLE_WEB_AUDIO feature enable flag (initially disabled) to build-webkit
3060         https://bugs.webkit.org/show_bug.cgi?id=48279
3061
3062         * Scripts/build-webkit:
3063
3064 2010-10-27  Eric Seidel  <eric@webkit.org>
3065
3066         Unreviewed.
3067
3068         build-webkit should collect Visual Studio Express logs and display them
3069         https://bugs.webkit.org/show_bug.cgi?id=39199
3070
3071         It turns out my previous patch wasn't actually working on the win-ews
3072         machine.  So I've fixed my mistakes from before.
3073
3074         * Scripts/build-webkit:
3075          - Windows VSE builds change the CWD while building.  Why?  Who knows.
3076         * Scripts/print-vse-failure-logs:
3077          - windows VSE builds don't use Debug/Release as I expected, so I've
3078            moved off of --configuration to --top-level and added the /obj
3079            optimization while I was there.
3080
3081 2010-10-27  Dimitri Glazkov  <dglazkov@chromium.org>
3082
3083         Unreviewed, rolling out r70674.
3084         http://trac.webkit.org/changeset/70674
3085         https://bugs.webkit.org/show_bug.cgi?id=48053
3086
3087         Broke Chromium Windows build.
3088
3089         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3090         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3091
3092 2010-10-25  Tony Chang  <tony@chromium.org>
3093
3094         Reviewed by Anders Carlsson.
3095
3096         compile TestNetscapePlugIn on chromium linux
3097         https://bugs.webkit.org/show_bug.cgi?id=48274
3098
3099         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3100         (NP_Initialize): On Linux, plugin funcs are set in initialize.
3101         (NPP_New): Mark the plugin as windowless.
3102         (NPP_GetValue): Handle mime type values.
3103         (NP_GetMIMEDescription):
3104         (NP_GetValue):
3105         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: define TRUE and FALSE, which are in webkit's npapi.h.
3106         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Pull in npapi.h to get TRUE/FALSE (matches webkit's npfunctions.h)
3107
3108 2010-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3109
3110         Reviewed by Anders Carlsson.
3111
3112         Remove contentSizeChanged callbacks as it is no longer
3113         part of the public UIClient.
3114
3115         Make WKPageContentsSizeChangedCallback be a private API
3116         https://bugs.webkit.org/show_bug.cgi?id=48409
3117
3118         * MiniBrowser/mac/BrowserWindowController.m:
3119         (-[BrowserWindowController awakeFromNib]):
3120         * MiniBrowser/win/BrowserView.cpp:
3121         (BrowserView::create):
3122         * WebKitTestRunner/TestController.cpp:
3123         (WTR::createOtherPage):
3124         (WTR::TestController::initialize):
3125
3126 2010-10-27  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3127
3128         Reviewed by Ojan Vafai.
3129
3130         Make http locking default in NRWT.
3131         https://bugs.webkit.org/show_bug.cgi?id=48053
3132
3133         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3134         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3135
3136 2010-10-27  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3137
3138         Reviewed by Tony Chang.
3139
3140         [NRWT] Fix http lock on Windows platform
3141         https://bugs.webkit.org/show_bug.cgi?id=48321
3142
3143         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3144
3145 2010-10-27  Satish Sampath  <satish@chromium.org>
3146
3147         Unreviewed, rolling out r70665.
3148         http://trac.webkit.org/changeset/70665
3149         https://bugs.webkit.org/show_bug.cgi?id=47089
3150
3151         Need to address Alexey's review comments.
3152
3153         * DumpRenderTree/LayoutTestController.cpp:
3154         (setMockSpeechInputResultCallback):
3155         * DumpRenderTree/LayoutTestController.h:
3156         * DumpRenderTree/chromium/LayoutTestController.cpp:
3157         (LayoutTestController::setMockSpeechInputResult):
3158         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3159         (LayoutTestController::setMockSpeechInputResult):
3160         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3161         (LayoutTestController::setMockSpeechInputResult):
3162         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3163         (LayoutTestController::setMockSpeechInputResult):
3164         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3165         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3166         (LayoutTestController::setMockSpeechInputResult):
3167         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3168         (LayoutTestController::setMockSpeechInputResult):
3169
3170 2010-10-27  Leandro Gracia Gil  <leandrogracia@google.com>
3171
3172         Reviewed by Jeremy Orlow.
3173
3174         Added a second parameter to setMockSpeechInputResult for
3175         the language used in speech input.
3176         https://bugs.webkit.org/show_bug.cgi?id=47089
3177
3178         * DumpRenderTree/LayoutTestController.cpp:
3179         (setMockSpeechInputResultCallback):
3180         * DumpRenderTree/LayoutTestController.h:
3181         * DumpRenderTree/chromium/LayoutTestController.cpp:
3182         (LayoutTestController::setMockSpeechInputResult):
3183         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3184         (LayoutTestController::setMockSpeechInputResult):
3185         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3186         (LayoutTestController::setMockSpeechInputResult):
3187         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3188         (LayoutTestController::setMockSpeechInputResult):
3189         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3190         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3191         (LayoutTestController::setMockSpeechInputResult):
3192         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3193         (LayoutTestController::setMockSpeechInputResult):
3194         (LayoutTestController::pageSizeAndMarginsInPixels):
3195
3196 2010-10-27  Adam Roben  <aroben@apple.com>
3197
3198         Reset TestNetscapePlugIn's NPP_GetValue pointer when
3199         NullNPPGetValuePointer finishes running
3200
3201         Fixes <http://webkit.org/b/48435> REGRESSION (r70655): Many plugins
3202         tests are failing on Qt
3203
3204         Reviewed by Anders Carlsson.
3205
3206         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3207         (PluginTest::NPP_Destroy):
3208         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3209         Added a do-nothing NPP_Destroy implementation.
3210
3211         * DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:
3212         (NullNPPGetValuePointer::NullNPPGetValuePointer): Save the original
3213         NPP_GetValue pointer in m_originalNPPGetValuePointer so we can restore
3214         it later.
3215         (NullNPPGetValuePointer::NPP_Destroy): Added. Restores the original
3216         NPP_GetValue pointer so it can be used in other tests.
3217
3218         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3219         (NPP_Destroy):
3220         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3221         (webkit_test_plugin_destroy_instance):
3222         Call through to the PluginTest when NPP_Destroy is called.
3223
3224 2010-10-26  Brian Weinstein  <bweinstein@apple.com>
3225
3226         Reviewed by Adam Roben.
3227
3228         WebKit2 shouldn't try to send an empty user agent
3229         https://bugs.webkit.org/show_bug.cgi?id=48397
3230         
3231         Add a test that when we set our custom user agent to an empty string, we don't send
3232         an empty user agent.
3233
3234         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: Added.
3235         (TestWebKitAPI::didRunJavaScript): Make sure that the result of navigator.userAgent isn't empty.
3236         (TestWebKitAPI::TEST): Set our custom user agent to the empty string, and run navigator.userAgent.
3237         
3238         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add the new file.
3239         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
3240
3241 2010-10-27  Adam Roben  <aroben@apple.com>
3242
3243         Check in file I forgot in r70653
3244
3245         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3246         (NP_Initialize): Save the NPPluginFuncs struct the browser passed to us
3247         so we can be naughty and modify it later.
3248
3249 2010-10-27  Adam Roben  <aroben@apple.com>
3250
3251         Test that WebKit doesn't crash if the plugin passes 0 for its
3252         NPP_GetValue pointer
3253
3254         Test for <http://webkit.org/b/48433> Crash in
3255         NetscapePlugin::shouldLoadSrcURL when using Shockwave Director 10.3 in
3256         WebKit2 on Windows
3257
3258         Reviewed by Eric Carlson.
3259
3260         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3261         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3262         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3263         * GNUmakefile.am:
3264         Added NullNPPGetValuePointer.cpp.
3265
3266         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3267         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3268         Set up a place to store the NPPluginFuncs struct the browser passed to us.
3269
3270         * DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp: Added.
3271         (NullNPPGetValuePointer::NullNPPGetValuePointer): Null out the
3272         NPP_GetValue pointer we passed to the browser to simulate a plugin that
3273         doesn't implement NPP_GetValue.
3274         (NullNPPGetValuePointer::NPP_GetValue): Print an error message. If this
3275         function is called, it means that WebKit has changed in a way that
3276         makes this test invalid.
3277
3278         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3279         (NP_GetEntryPoints): Save the NPPluginFuncs struct the browser passed
3280         to us so we can be naughty and modify it later.
3281
3282 2010-10-27  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3283
3284         Reviewed by Andreas Kling.
3285
3286         Remove references to ancient QGVLauncher and QtLauncher
3287         https://bugs.webkit.org/show_bug.cgi?id=48430
3288
3289         QtTestBrowser substitutes both and has checks enabled.
3290
3291         * Scripts/webkitpy/style/checker.py: remove references
3292         * Scripts/webkitpy/style/checker_unittest.py: ditto
3293
3294 2010-10-27  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3295
3296         Reviewed by Ojan Vafai.
3297
3298         [NRWT] Don't use image hash when it's no need in single test mode.
3299         https://bugs.webkit.org/show_bug.cgi?id=48326
3300
3301         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3302
3303 2010-10-27  David Kilzer  <ddkilzer@apple.com>
3304
3305         Fix leak of CFMutableDictionaryRef in createXMLStringFromWebArchiveData()
3306
3307         Reviewed by Adam Roben.
3308
3309         Follow-up fix for: <https://bugs.webkit.org/show_bug.cgi?id=48278>
3310
3311         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3312         (createXMLStringFromWebArchiveData): Use RetainPtr<> to fix a
3313         leak introduced in r70613.
3314
3315 2010-10-27  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3316
3317         Reviewed by Csaba Osztrogonác.
3318
3319         [NRWT] Add platform specific baseline search paths for Qt port
3320         https://bugs.webkit.org/show_bug.cgi?id=48428
3321
3322         * Scripts/webkitpy/layout_tests/port/qt.py:
3323
3324 2010-10-27  Adam Roben  <aroben@apple.com>
3325
3326         Catch exceptions when checking if we're inside a git working directory
3327
3328         Fixes <http://webkit.org/b/48420> REGRESSION (r70562): test-webkitpy
3329         fails on systems without git installed
3330
3331         Reviewed by Anders Carlsson.
3332
3333         * Scripts/webkitpy/common/net/credentials.py:
3334         (Credentials._credentials_from_git): Put the call to
3335         Git.in_working_directory inside the try/except since it, too, attempts
3336         to execute git and thus will throw on systems that don't have git
3337         installed.
3338
3339 2010-10-27  Nikolas Zimmermann  <nzimmermann@rim.com>
3340
3341         Reviewed by David Kilzer.
3342
3343         Convert DumpRenderTree webarchive code to CoreFoundation
3344         https://bugs.webkit.org/show_bug.cgi?id=48278
3345
3346         CFPropertyListCreateWithData and CFPropertyListCreateData are only available in 10.6+.
3347         Replace CFPropertyListCreateWithData by a combination of CFReadStreamCreateWithBytesNoCopy and CFPropertyListCreateFromStream.
3348         Replace CFPropertyListCreateData by CFPropertyListCreateXMLData.
3349
3350         These changes are wrapped in BUILDING_ON_LEOPARD, as the methods are deprecated on 10.6+.
3351
3352         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3353         (createXMLStringFromWebArchiveData):
3354
3355 2010-10-26  Antonio Gomes  <agomes@rim.com>
3356
3357         Reviewed by Martin Robinson.
3358
3359         Remove the absolute path used to include DumpRenderTreeSupportGtk.h from LayoutTestController.h
3360
3361         It turns out this is rather unneeded since WebKitTools/GNUMakefile.am has WebKit/gtk/ in its include
3362         path, and then we can just do #include "WebCoreSupport/DumpRenderTreeSupportGtk.h"
3363
3364         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3365
3366 2010-10-26  David Kilzer  <ddkilzer@apple.com>
3367
3368         Rename WebArchiveDumpSupport.mm to WebArchiveDumpSupport.cpp
3369
3370         Reviewed by Adam Roben.
3371
3372         Part 4 of 4: <http://webkit.org/b/48278> Convert DumpRenderTree webarchive code to CoreFoundation
3373
3374         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3375         Updated for file moves and renames.
3376         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Renamed from DumpRenderTree/mac/WebArchiveDumpSupport.mm.
3377         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Renamed from DumpRenderTree/mac/WebArchiveDumpSupport.h.
3378
3379 2010-10-26  David Kilzer  <ddkilzer@apple.com>
3380
3381         Convert WebArchiveDumpSupport.mm from NS objects to CF types
3382
3383         Reviewed by Adam Roben.
3384
3385         Part 3 of 4: <http://webkit.org/b/48278> Convert DumpRenderTree webarchive code to CoreFoundation
3386
3387         In order to share WebArchive code between the Mac and Windows
3388         ports, the code in WebArchiveDumpSupport.mm was converted from
3389         Cocoa to C++ using CoreFoundation (CF) types.
3390
3391         * DumpRenderTree/mac/DumpRenderTree.mm:
3392         (dump): Renamed serializeWebArchiveToXML() to
3393         createXMLStringFromWebArchiveData() and added HardAutorelease()
3394         to prevent leaks.
3395         * DumpRenderTree/mac/WebArchiveDumpSupport.h:
3396         (createXMLStringFromWebArchiveData): Renamed from
3397         serializeWebArchiveToXML().  Changed to use CF types.
3398         (createCFURLResponseFromResponseData): Renamed from
3399         unarchiveNSURLResponseFromResponseData().  Changed to use CF
3400         types for its parameter and return type.
3401         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Replaced use of
3402         NS objects with CF types.  It will be renamed to *.cpp in a
3403         future commit.
3404         (convertMIMEType): Changed to use case-insensitive string
3405         comparisons.
3406         (convertWebResourceDataToString):
3407         (normalizeHTTPResponseHeaderFields):
3408         (normalizeWebResourceURL):
3409         (convertWebResourceResponseToDictionary):
3410         (compareResourceURLs):
3411         (createXMLStringFromWebArchiveData):
3412         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
3413         (createCFURLResponseFromResponseData): Renamed from
3414         unarchiveNSURLResponseFromResponseData().  Changed to use CF
3415         types for its parameter and return type.
3416
3417 2010-10-26  David Kilzer  <ddkilzer@apple.com>
3418
3419         Extract use of NSKeyedUnarchiver from WebArchiveDumpSupport.mm
3420
3421         Reviewed by Adam Roben.
3422
3423         Part 2 of 4: <http://webkit.org/b/48278> Convert DumpRenderTree webarchive code to CoreFoundation
3424
3425         There is no equivalent to NSKeyedUnarchiver in CoreFoundation,
3426         so extract it into a platform-specific source file.
3427
3428         * DumpRenderTree/mac/WebArchiveDumpSupport.h:
3429         (unarchiveNSURLResponseFromResponseData): Added declaration.
3430         * DumpRenderTree/mac/WebArchiveDumpSupport.mm:
3431         (convertWebResourceResponseToDictionary): Extracted code to
3432         unarchiveNSURLResponseFromResponseData() in
3433         WebArchiveDumpSupportMac.mm.  Updated logic to return early if
3434         nil is returned from unarchiveNSURLResponseFromResponseData().
3435         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
3436         (unarchiveNSURLResponseFromResponseData): Added.  Extracted
3437         code from convertWebResourceResponseToDictionary() in
3438         WebArchiveDumpSupport.mm.
3439
3440 2010-10-26  David Kilzer  <ddkilzer@apple.com>
3441
3442         Extract call to -[WebHTMLRepresentation supportedNonImageMIMETypes] from WebArchiveDumpSupport.mm
3443
3444         Reviewed by Adam Roben.
3445
3446         Part 1 of 4: <http://webkit.org/b/48278> Convert DumpRenderTree webarchive code to CoreFoundation
3447
3448         The call to -[WebHTMLRepresentation supportedNonImageMIMETypes]
3449         is not cross-platform between Mac and Windows, so extract it
3450         into a platform-specific source file.
3451
3452         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
3453         WebArchiveDumpSupportMac.mm to the project.
3454         * DumpRenderTree/mac/WebArchiveDumpSupport.h:
3455         (supportedNonImageMIMETypes): Added declaration.
3456         * DumpRenderTree/mac/WebArchiveDumpSupport.mm:
3457         (convertWebResourceDataToString): Replaced call to
3458         -[WebHTMLRepresentation supportedNonImageMIMETypes] with
3459         supportedNonImageMIMETypes().
3460         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Added.
3461         (supportedNonImageMIMETypes): Added.  Extracted from
3462         WebArchiveDumpSupport.mm.
3463
3464 2010-10-26  Antonio Gomes  <agomes@rim.com>
3465
3466         Reviewed by Martin Robinson.
3467
3468         [GTK] Implement DumpRenderTreeSupportGtk (similarly to DumpRenderTreeSupportQt idea)
3469         https://bugs.webkit.org/show_bug.cgi?id=48199
3470
3471         Implements support to WebKitTabToLinksPreferenceKey through LayoutTestController::overridePreference.
3472         The corresponding DumpRenderTreeSupportGtk method is called in the DRT context only.
3473
3474         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3475         (resetDefaultsToConsistentValues):
3476         (createWebView):
3477         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3478         (LayoutTestController::overridePreference):
3479
3480 2010-10-26  Ariya Hidayat  <ariya@sencha.com>
3481
3482         Unreviewed, change the order of my emails for bugzilla autocompletion.
3483
3484         * Scripts/webkitpy/common/config/committers.py:
3485
3486 2010-10-26  Eric Seidel  <eric@webkit.org>
3487
3488         Reviewed by David Kilzer.
3489
3490         build-webkit should collect Visual Studio Express logs and display them
3491         https://bugs.webkit.org/show_bug.cgi?id=39199
3492
3493         * Scripts/build-webkit:
3494         * Scripts/print-vse-failure-logs: Added.
3495         * Scripts/webkitdirs.pm:
3496
3497 2010-10-26  David Kilzer  <ddkilzer@apple.com>
3498
3499         <http://webkit.org/b/48224> build-webkit: add support for --meter-tag switch
3500
3501         Reviewed by Csaba Osztrogonác.
3502
3503         * Scripts/build-webkit: Added support for --meter-tag switch.
3504         It should have been added with r60820.
3505
3506 2010-10-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
3507
3508         Reviewed by Dumitru Daniliuc.
3509
3510         check-webkit-style fails on operator+=, operator-=, ... methods
3511         https://bugs.webkit.org/show_bug.cgi?id=48258
3512
3513         * Scripts/webkitpy/style/checkers/cpp.py: Added exceptions
3514         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added unit-tests
3515
3516 2010-10-26  Ojan Vafai  <ojan@chromium.org>
3517
3518         Reviewed by Tony Chang.
3519
3520         remove DEFER support from new-run-webkit-tests
3521         https://bugs.webkit.org/show_bug.cgi?id=48387
3522
3523         DEFER was needed when we were trying to ship Chrome beta.
3524         Now it's just extra complication.
3525
3526         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3527         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3528         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3529         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3530         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3531         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3532
3533 2010-10-26  Eric Seidel  <eric@webkit.org>
3534
3535         Unreviewed.  Adding import with_statement to fix python 2.5.
3536
3537         Teach webkit-patch how to read credentials from the environment
3538         https://bugs.webkit.org/show_bug.cgi?id=48275
3539
3540         * Scripts/webkitpy/common/net/credentials_unittest.py:
3541          - import with_statement to fix python 2.5.
3542
3543 2010-10-26  Alexey Proskuryakov  <ap@apple.com>
3544
3545         Reviewed by Sam Weinig.
3546
3547         https://bugs.webkit.org/show_bug.cgi?id=48375
3548         <rdar://problem/8392724> Need delegate calls in PageLoaderClient to indicate if we have
3549         loaded insecure content
3550
3551         Updated for WebKit2 changes.
3552
3553         * MiniBrowser/mac/BrowserWindowController.m:
3554         (didDisplayInsecureContentForFrame):
3555         (didRunInsecureContentForFrame):
3556         (-[BrowserWindowController awakeFromNib]):
3557         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3558         (WTR::InjectedBundlePage::InjectedBundlePage):
3559         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
3560         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
3561         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3562         * WebKitTestRunner/TestController.cpp:
3563         (WTR::TestController::initialize):
3564
3565 2010-10-26  Adam Roben  <aroben@apple.com>
3566
3567         Clear up confusion between "3D rendering" and "accelerated compositing"
3568
3569         WebKit has no software-based 3D rendering implementation, so 3D
3570         rendering can only be enabled when accelerated compositing is. But DRT
3571         was falsely reporting that 3D rendering was available on machines that
3572         don't support accelerated compositing, leading to much confusion.
3573
3574         Reviewed by Darin Adler.
3575
3576         Fixes <http://webkit.org/b/48370> REGRESSION (r70540): Many
3577         transforms/3d tests are failing on the XP bots
3578
3579         * DumpRenderTree/win/DumpRenderTree.cpp:
3580         (main): When ENABLE(3D_RENDERING) is turned on, only report that 3D
3581         rendering is available when acclerated compositing is also available.
3582
3583         * Scripts/old-run-webkit-tests: Skip tests that use the
3584         -webkit-transform-3d media query when 3D rendering is disabled,
3585         rather than when accelerated compositing is disabled.
3586
3587 2010-10-26  Eric Seidel  <eric@webkit.org>
3588
3589         Reviewed by Ojan Vafai.
3590
3591         Remove rietveld code now that it's unused
3592         https://bugs.webkit.org/show_bug.cgi?id=48359
3593
3594         Was cool that we added this support, but now that it's
3595         not used it makes little sense to keep it around.
3596         We can always restore this code from SVN if we need it.
3597
3598         * Scripts/webkitpy/common/config/__init__.py:
3599         * Scripts/webkitpy/common/net/bugzilla.py:
3600         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
3601         * Scripts/webkitpy/common/net/rietveld.py: Removed.
3602         * Scripts/webkitpy/common/net/rietveld_unittest.py: Removed.
3603         * Scripts/webkitpy/thirdparty/__init__.py:
3604         * Scripts/webkitpy/tool/commands/download.py:
3605         * Scripts/webkitpy/tool/commands/download_unittest.py:
3606         * Scripts/webkitpy/tool/commands/queues.py:
3607         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3608         * Scripts/webkitpy/tool/main.py:
3609         * Scripts/webkitpy/tool/mocktool.py:
3610         * Scripts/webkitpy/tool/steps/__init__.py:
3611         * Scripts/webkitpy/tool/steps/postcodereview.py: Removed.
3612
3613 2010-10-26  Anders Carlsson  <andersca@apple.com>
3614
3615         Reviewed by Sam Weinig.
3616
3617         pageDidScroll callback should be on the UI process client rather than (or in addition to) the web process client
3618         https://bugs.webkit.org/show_bug.cgi?id=48366
3619         <rdar://problem/8595202>
3620
3621         * MiniBrowser/mac/BrowserWindowController.m:
3622         (-[BrowserWindowController awakeFromNib]):
3623         * WebKitTestRunner/TestController.cpp:
3624         (WTR::createOtherPage):
3625         (WTR::TestController::initialize):
3626
3627 2010-10-26  Eric Seidel  <eric@webkit.org>
3628
3629         Reviewed by Tony Chang.
3630
3631         Teach webkit-patch how to read credentials from the environment
3632         https://bugs.webkit.org/show_bug.cgi?id=48275
3633
3634         This makes it possible for svn users to have their bugzilla credentials
3635         stored in their environment instead of typing them every time.
3636
3637         We need this for making it easy to run the win-ews bot (which currently
3638         uses svn instead of git).
3639
3640         * Scripts/webkitpy/common/net/credentials.py:
3641         * Scripts/webkitpy/common/net/credentials_unittest.py:
3642
3643 2010-10-26  Kenichi Ishibashi  <bashi@google.com>
3644
3645         Reviewed by Kent Tamura.
3646
3647         Input Method inserts conversion candidates unexpectedly
3648         https://bugs.webkit.org/show_bug.cgi?id=46868
3649
3650         Adds setComposition() to TextInputController to make DRT emulate
3651         an input method behavior.
3652
3653         * DumpRenderTree/chromium/TextInputController.cpp:
3654         (TextInputController::TextInputController):
3655         (TextInputController::setComposition): Added.
3656         * DumpRenderTree/chromium/TextInputController.h:
3657
3658 2010-10-26  Simon Fraser  <simon.fraser@apple.com>
3659
3660         Reviewed by Sam Weinig.
3661
3662         Support layoutTestController.layerTreeAsText in WebKitTestRunner
3663         https://bugs.webkit.org/show_bug.cgi?id=42145
3664         
3665         Implement layerTreeAsText() in WebKitTestRunner.
3666
3667         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3668         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3669         (WTR::LayoutTestController::layerTreeAsText):
3670         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3671
3672 2010-10-26  Adam Barth  <abarth@webkit.org>
3673
3674         Reviewed by Eric Seidel.
3675
3676         webkit-patch rollout produces incorrect patch when using svn move
3677         https://bugs.webkit.org/show_bug.cgi?id=48244
3678
3679         We need to flush our caches when we modify the working copy.
3680
3681         * Scripts/webkitpy/tool/steps/revertrevision.py:
3682
3683 2010-10-26  Eric Seidel  <eric@webkit.org>
3684
3685         Reviewed by Adam Barth.
3686
3687         commit-queue flaky test message can list the same author more than once
3688         https://bugs.webkit.org/show_bug.cgi?id=48268
3689
3690         tonikitoo reported to me over IRC this morning that he's seen
3691         the commit-queue report flaky tests with author lists like:
3692         "adam, adam and adam", suggesting we're not uniquing authors
3693         before writing the message.
3694
3695         I fixed the uniquing and added a bunch more unit testing.
3696
3697         * Scripts/webkitpy/tool/commands/queues.py:
3698         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3699         * Scripts/webkitpy/tool/mocktool.py:
3700
3701 2010-10-26  Adam Roben  <aroben@apple.com>
3702
3703         Pull in the FeatureDefines*.vsprops files when building DRT
3704
3705         This ensures that various ENABLE() macros will get set correctly.
3706         (Prior to r70320 we were picking up the ENABLE(3D_RENDERING) flag
3707         through wtf/Platform.h.)
3708
3709         Fixes <http://webkit.org/b/48343> REGRESSION (r70320): DumpRenderTree
3710         says 3D_RENDERING is disabled even when it is enabled
3711
3712         Reviewed by Ada Chan.
3713
3714         * DumpRenderTree/win/DumpRenderTree.vcproj: Added
3715         FeaturesDefines*.vsprops to all configurations.
3716
3717         * DumpRenderTree/win/DumpRenderTreeWin.h: Touched to force a rebuild.
3718
3719 2010-10-26  Søren Gjesse  <sgjesse@chromium.org>
3720
3721         Reviewed by Dimitri Glazkov.
3722
3723         Added options --multiple-loads and --js-flags to chromium DumpRenderTree. The option --multiple-loads=X
3724         is used to have DumpRenderTree load each test it runs X times. To be able to have more fine-grained control
3725         of how the JavaScript engine behaves for each load the flag --js-flags can specify a list of flag-sets like this
3726
3727           --js-flags="--xxx,--noxxx --yyy,--noyyy"
3728
3729         First load will run with --xxx, the second with --yyy and the third without any (the 'no' prefix is handled by
3730         V8 to turn off the flag).
3731
3732         The changes to the Python test runner will be in a separate change.
3733
3734
3735         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3736         (runTest):
3737         (main):
3738         * DumpRenderTree/chromium/TestShell.cpp:
3739         (TestShell::TestShell):
3740         (TestShell::runFileTest):
3741         (TestShell::testFinished):
3742         * DumpRenderTree/chromium/TestShell.h:
3743         (TestShell::loadCount):
3744         (TestShell::setLoadCount):
3745         (TestShell::javaScriptFlagsForLoad):
3746         (TestShell::setJavaScriptFlags):
3747         (TestShell::setDumpWhenFinished):
3748
3749 2010-10-26  Adam Roben  <aroben@apple.com>
3750
3751         Skip more tests that depend on accelerated compositing when accelerated
3752         compositing is disabled
3753
3754         Fixes <http://webkit.org/b/48329> Some tests fail when accelerated
3755         compositing is disabled
3756
3757         Reviewed by John Sullivan.
3758
3759         * Scripts/old-run-webkit-tests: Added more tests to skip when
3760         accelerated compositing is disable. The tests all have output that
3761         changes depending on whether accelerated compositing is enabled.
3762
3763 2010-10-25  Eric Seidel  <eric@webkit.org>
3764
3765         Reviewed by Adam Barth.
3766
3767         webkit-patch should clean up svn locks when passed --force-clean
3768         https://bugs.webkit.org/show_bug.cgi?id=48269
3769
3770         * Scripts/webkitpy/common/checkout/scm.py:
3771
3772 2010-10-25  Anders Carlsson  <andersca@apple.com>
3773
3774         Reviewed by Adam Roben.
3775
3776         Add a pageDidScroll BundleUIClient callback
3777         https://bugs.webkit.org/show_bug.cgi?id=48260
3778         <rdar://problem/8531159>
3779
3780         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3781         (WTR::InjectedBundlePage::InjectedBundlePage):
3782
3783 2010-10-25  Johnny Ding  <jnd@chromium.org>
3784
3785         Reviewed by Tony Chang.
3786
3787         Dump the gesture status of frame in frame load callbacks in DumpRenderTree
3788         by adding a new method dumpUserGestureInFrameLoadCallbacks.
3789         Now only dump the gesture status in "DidStartProvisionalLoad" callback.
3790         https://bugs.webkit.org/show_bug.cgi?id=47849
3791
3792         * DumpRenderTree/LayoutTestController.cpp:
3793         (LayoutTestController::LayoutTestController):
3794         (dumpUserGestureInFrameLoadCallbacksCallback):
3795         (LayoutTestController::staticFunctions):
3796         * DumpRenderTree/LayoutTestController.h:
3797         (LayoutTestController::dumpUserGestureInFrameLoadCallbacks):
3798         (LayoutTestController::setDumpUserGestureInFrameLoadCallbacks):
3799         * DumpRenderTree/chromium/LayoutTestController.cpp:
3800         (LayoutTestController::LayoutTestController):
3801         (LayoutTestController::dumpUserGestureInFrameLoadCallbacks):
3802         (LayoutTestController::reset):
3803         * DumpRenderTree/chromium/LayoutTestController.h:
3804         (LayoutTestController::shouldDumpUserGestureInFrameLoadCallbacks):
3805         (LayoutTestController::setShouldDumpUserGestureInFrameLoadCallbacks):
3806         * DumpRenderTree/chromium/TestShell.h:
3807         (TestShell::shouldDumpUserGestureInFrameLoadCallbacks):
3808         * DumpRenderTree/chromium/WebViewHost.cpp:
3809         (WebViewHost::didStartProvisionalLoad):
3810         (WebViewHost::printFrameUserGestureStatus):
3811         * DumpRenderTree/chromium/WebViewHost.h:
3812         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3813         (-[WebFrame _drt_printFrameUserGestureStatus]):
3814         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3815         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3816         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3817         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3818         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3819         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3820         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3821         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3822         (LayoutTestController::reset):
3823         (LayoutTestController::dumpUserGestureInFrameLoadCallbacks):
3824         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3825
3826 2010-10-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3827
3828         Unreviewed, rolling out r70442.
3829         http://trac.webkit.org/changeset/70442
3830         https://bugs.webkit.org/show_bug.cgi?id=48248
3831
3832         http locking doesn't work on Windows (Requested by Ossy on
3833         #webkit).
3834
3835         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3836         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3837
3838 2010-10-25  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3839
3840         Reviewed by Ojan Vafai.
3841
3842         Make http locking default in NRWT.
3843         https://bugs.webkit.org/show_bug.cgi?id=48053
3844
3845         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3846         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3847
3848 2010-10-25  David Kilzer  <ddkilzer@apple.com>
3849
3850         <http://webkit.org/b/48185> build-webkit: add support for --progress-tag switch
3851         (Re-landing r70413 after Qt minimal buildfix: r70440.)
3852
3853         Reviewed by Kenneth Rohde Christiansen.
3854
3855         * Scripts/build-webkit: Added support for --progress-tag switch.
3856         It should have been added with r57051.
3857
3858 2010-10-24  Adam Barth  <abarth@webkit.org>
3859
3860         Reviewed by David Kilzer.
3861
3862         webkit-patch upload fails when the patch removes a file
3863         https://bugs.webkit.org/show_bug.cgi?id=48187
3864
3865         We need to use "--" to separate file names from the rest of the
3866         command.
3867
3868         * Scripts/webkitpy/common/checkout/scm.py:
3869
3870 2010-10-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3871
3872         Unreviewed, rolling out r70413.
3873         http://trac.webkit.org/changeset/70413
3874         https://bugs.webkit.org/show_bug.cgi?id=48210
3875
3876         It broke Qt minimal build (Requested by Ossy on #webkit).
3877
3878         * Scripts/build-webkit:
3879
3880 2010-10-24  Yi Shen  <yi.4.shen@nokia.com>
3881
3882         Reviewed by Andreas Kling.
3883
3884         [Qt][QtTestBrowser] Toggle use of QGraphicsView messes up the menu
3885         https://bugs.webkit.org/show_bug.cgi?id=48141
3886
3887         * QtTestBrowser/launcherwindow.cpp:
3888         (LauncherWindow::init):
3889         (LauncherWindow::initializeView):
3890         (LauncherWindow::toggleWebView):
3891
3892 2010-10-24  Daniel Bates  <dbates@rim.com>
3893
3894         Reviewed by David Kilzer.
3895
3896         Fix Perl uninitialized warnings in VCSUtils::svnStatus()
3897         and VCSUtils::removeEOL().
3898         https://bugs.webkit.org/show_bug.cgi?id=48196
3899
3900         VCSUtils::svnStatus() concatenates the output of svn status with
3901         a new line character and svn status may return no output (say for
3902         a file that has not been added, deleted, or modified). We should
3903         only concatenate the output of svn status if there is some.
3904
3905         Also, VCSUtils::removeEOL() should ensure that its argument
3906         is initialized before performing a string substitution.
3907
3908         * Scripts/VCSUtils.pm:
3909           - Modified removeEOL() to return "" if its argument is undefined.
3910           - Exported removeEOL() so that it can be tested. 
3911         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Added.
3912
3913 2010-10-24  David Kilzer  <ddkilzer@apple.com>
3914
3915         <http://webkit.org/b/48185> build-webkit: add support for --progress-tag switch
3916
3917         Reviewed by Kenneth Rohde Christiansen.
3918
3919         * Scripts/build-webkit: Added support for --progress-tag switch.
3920         It should have been added with r57051.
3921
3922 2010-10-24  David Kilzer  <ddkilzer@apple.com>
3923
3924         <http://webkit.org/b/48184> build-webkit: reformat support variables for better maintainability
3925
3926         Reviewed by Daniel Bates.
3927
3928         * Scripts/build-webkit: Alphabetized the @features array based
3929         on the name of the feature.  Reformatted the list of support
3930         variables so that they match the order of @features, and so that
3931         each has its own line.  This makes it easy to add new variables
3932         in the correct order.
3933
3934 2010-10-23  Eric Seidel  <eric@webkit.org>
3935
3936         Reviewed by Adam Barth.
3937
3938         EWS never removes invalid patch ids
3939         https://bugs.webkit.org/show_bug.cgi?id=48173
3940
3941         This is just sticking another finger in the dam.
3942         However this adds more unit testing which will help
3943         us make sure we're always releasing patches once we
3944         redesign the release_patch API and call these from
3945         a more central place.
3946
3947         * Scripts/webkitpy/tool/commands/queues.py:
3948         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3949         * Scripts/webkitpy/tool/mocktool.py:
3950          - Added the ability to request invalid patches.
3951            Log a warning message to make sure we don't ever have
3952            tests use invalid patch fetches by mistake.
3953
3954 2010-10-23  Dan Bernstein  <mitz@apple.com>
3955
3956         Build fix. Add stub implementations for required NSDraggingInfo methods.
3957
3958         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3959         (-[DumpRenderTreeDraggingInfo draggingFormation]):
3960         (-[DumpRenderTreeDraggingInfo setDraggingFormation:]):
3961         (-[DumpRenderTreeDraggingInfo animatesToDestination]):
3962         (-[DumpRenderTreeDraggingInfo setAnimatesToDestination:]):
3963         (-[DumpRenderTreeDraggingInfo numberOfValidItemsForDrop]):
3964         (-[DumpRenderTreeDraggingInfo setNumberOfValidItemsForDrop:]):
3965         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3966
3967 2010-10-23  David Kilzer  <ddkilzer@apple.com>
3968
3969         <http://webkit.org/b/48186> Remove unneeded WebHTMLRepresentationInternal.h header
3970
3971         Reviewed by Sam Weinig.
3972
3973         The only method defined in WebHTMLRepresentationInternal.h is
3974         also defined in WebHTMLRepresentation.h, so use that instead.
3975
3976         * DumpRenderTree/mac/InternalHeaders/WebKit/WebHTMLRepresentationInternal.h: Removed.
3977         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Switched to use
3978         WebHTMLRepresentation.h.
3979
3980 2010-10-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3981
3982         Unreviewed, rolling out r70367.
3983         http://trac.webkit.org/changeset/70367
3984         https://bugs.webkit.org/show_bug.cgi?id=48176
3985
3986         It made 8-10 tests crash on Qt bot (Requested by Ossy on
3987         #webkit).
3988
3989         * DumpRenderTree/LayoutTestController.cpp:
3990         (setCustomPolicyDelegateCallback):
3991         * DumpRenderTree/LayoutTestController.h:
3992         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3993         (LayoutTestController::setCustomPolicyDelegate):
3994         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3995         (LayoutTestController::setCustomPolicyDelegate):
3996         * DumpRenderTree/mac/PolicyDelegate.h:
3997         * DumpRenderTree/mac/PolicyDelegate.mm:
3998         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3999         (-[PolicyDelegate setPermissive:]):
4000         (-[PolicyDelegate setControllerToNotifyDone:]):
4001         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4002         (LayoutTestController::setCustomPolicyDelegate):
4003         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4004         (LayoutTestController::setCustomPolicyDelegate):
4005
4006 2010-10-22  Eric Seidel  <eric@webkit.org>
4007
4008         Reviewed by Adam Barth.
4009
4010         EWS never releases patches which fail to apply
4011         https://bugs.webkit.org/show_bug.cgi?id=48171
4012
4013         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4014         * Scripts/webkitpy/tool/commands/queues.py:
4015
4016 2010-10-22  Eric Seidel  <eric@webkit.org>
4017
4018         Unreviewed.
4019
4020         Make the EWS queues restart themselves more often.
4021         This matches the commit-queue.
4022
4023         * EWSTools/start-queue.sh:
4024
4025 2010-10-22  Eric Seidel  <eric@webkit.org>
4026
4027         Reviewed by Adam Barth.
4028
4029         commit-queue should not pass --quiet to subcommands now that the parent command does the reporting
4030         https://bugs.webkit.org/show_bug.cgi?id=48165
4031
4032         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4033         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4034         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4035
4036 2010-10-22  Mario Sanchez Prada  <msanchez@igalia.com>
4037
4038         Adding myself as a committer.
4039
4040         * Scripts/webkitpy/common/config/committers.py:
4041
4042 2010-10-20  Anders Carlsson  <andersca@apple.com>
4043
4044         Reviewed by Adam Barth and Darin Adler.
4045
4046         Using the decidePolicyForMIMEType delegate message in an asynchronous manner does not work
4047         https://bugs.webkit.org/show_bug.cgi?id=48014
4048         <rdar://problem/8202716>
4049         
4050         * DumpRenderTree/LayoutTestController.cpp:
4051         (setCustomPolicyDelegateCallback):
4052         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
4053
4054         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4055         (LayoutTestController::setCustomPolicyDelegate):
4056         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
4057
4058         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4059         (LayoutTestController::setCustomPolicyDelegate):
4060         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
4061
4062         * DumpRenderTree/mac/PolicyDelegate.h:
4063         * DumpRenderTree/mac/PolicyDelegate.mm:
4064         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
4065         If _callIgnoreInDecidePolicyForMIMETypeAfterOneSecond is true, call [listener ignore] after one second.
4066
4067         (-[PolicyDelegate setCallIgnoreInDecidePolicyForMIMETypeAfterOneSecond:]):
4068         Update _callIgnoreInDecidePolicyForMIMETypeAfterOneSecond.
4069         
4070         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4071         (LayoutTestController::setCustomPolicyDelegate):
4072         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
4073
4074         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4075         (LayoutTestController::setCustomPolicyDelegate):
4076         Add callIgnoreInDecidePolicyForMIMETypeAfterOneSecond argument.
4077
4078 2010-10-22  Sam Weinig  <sam@webkit.org>
4079
4080         Reviewed by Anders Carlsson.
4081
4082         Rename the InjectedBundle for TestWebKitAPI to InjectedBundleTestWebKitAPI.bundle
4083
4084         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
4085         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4086         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
4087         (TestWebKitAPI::Util::createInjectedBundlePath):
4088
4089 2010-10-22  Dirk Pranke  <dpranke@chromium.org>
4090
4091         Reviewed by Eric Seidel.
4092
4093         test-webkitpy fails when passed -v (or any other option)
4094
4095         Fix port/base_unittest to pass an explicit list of arguments
4096         rather than accidentally picking up sys.argv.
4097
4098         https://bugs.webkit.org/show_bug.cgi?id=48071
4099
4100         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4101
4102 2010-10-22  Brian Weinstein  <bweinstein@apple.com>
4103
4104         Windows build fix. Update the createNewPage callback to account for the new
4105         arguments.
4106
4107         * MiniBrowser/win/BrowserView.cpp:
4108         (createNewPage):
4109
4110 2010-10-22  Sam Weinig  <sam@webkit.org>
4111
4112         Reviewed by Anders Carlsson.
4113
4114         WebKit2 needs to pass the current event modifier flags when requesting a new window
4115         https://bugs.webkit.org/show_bug.cgi?id=48140
4116
4117         * MiniBrowser/mac/BrowserWindowController.m:
4118         (createNewPage):
4119         * WebKitTestRunner/TestController.cpp:
4120         (WTR::createOtherPage):
4121         Update for new signature for the WKPageCreateNewPageCallback.
4122
4123 2010-10-22  Eric Seidel  <eric@webkit.org>
4124
4125         Unreviewed.  Just adding a test case.
4126
4127         The style-queue was not recognizing new patches.  It turns
4128         out I had fixed this in an earlier change, but just not
4129         deployed to queues.webkit.org.  As part of investigating why it
4130         was broken, I wrote a test for my previous change which I'm now landing.
4131
4132         * QueueStatusServer/model/queues_unittest.py:
4133
4134 2010-10-22  Eric Seidel  <eric@webkit.org>
4135
4136         Reviewed by Adam Barth.
4137
4138         EWS does not need to process obsolete patches
4139         https://bugs.webkit.org/show_bug.cgi?id=48093
4140
4141         This was an easy change, but to test it I had to pipe
4142         real Attachment objects into the queue testing system.
4143         Doing so revealed a whole bunch of bugs in our unit tests,
4144         which I fixed as part of this patch.
4145
4146         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4147          - This is the actual code change.  This will not reduce the
4148            backlog in the EWS queues much, but it will make rejections
4149            much quicker for obsolete patches or closed bugs.
4150         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4151          - Test my new code.
4152          - Used a real attachment object and got rid of MockPatch
4153          - Shared code between the mac-ews and cr-mac-ews tests.
4154         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4155          - Can't use MockPatch anymore.
4156          - Removing MockPatch found more bugs here!
4157         * Scripts/webkitpy/tool/commands/queuestest.py:
4158         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
4159         * Scripts/webkitpy/tool/mocktool.py:
4160          - MockBugzilla should not be a "Mock" object.  Right now tool.bugs()
4161            is allowed, but wrong.  Making it not a Mock will make tool.bugs() correctly fail.
4162
4163 2010-10-22  Sheriff Bot  <webkit.review.bot@gmail.com>
4164
4165         Unreviewed, rolling out r70301.
4166         http://trac.webkit.org/changeset/70301
4167         https://bugs.webkit.org/show_bug.cgi?id=48126
4168
4169         "Lang attribute layout tests failing" (Requested by satish on
4170         #webkit).
4171
4172         * DumpRenderTree/LayoutTestController.cpp:
4173         (setMockSpeechInputResultCallback):
4174         * DumpRenderTree/LayoutTestController.h:
4175         * DumpRenderTree/chromium/LayoutTestController.cpp:
4176         (LayoutTestController::setMockSpeechInputResult):
4177         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4178         (LayoutTestController::setMockSpeechInputResult):
4179         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4180         (LayoutTestController::setMockSpeechInputResult):
4181         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4182         (LayoutTestController::setMockSpeechInputResult):
4183         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4184         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4185         (LayoutTestController::setMockSpeechInputResult):
4186         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4187         (LayoutTestController::setMockSpeechInputResult):
4188
4189 2010-10-22  Leandro Gracia Gil  <leandrogracia@google.com>
4190
4191         Reviewed by Jeremy Orlow.
4192
4193         Added a second parameter to setMockSpeechInputResult for
4194         the language used in speech input.
4195         https://bugs.webkit.org/show_bug.cgi?id=47089
4196
4197         * DumpRenderTree/LayoutTestController.cpp:
4198         (setMockSpeechInputResultCallback):
4199         * DumpRenderTree/LayoutTestController.h:
4200         * DumpRenderTree/chromium/LayoutTestController.cpp:
4201         (LayoutTestController::setMockSpeechInputResult):
4202         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4203         (LayoutTestController::setMockSpeechInputResult):
4204         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4205         (LayoutTestController::setMockSpeechInputResult):
4206         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4207         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4208         (LayoutTestController::setMockSpeechInputResult):
4209         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4210         (LayoutTestController::setMockSpeechInputResult):
4211         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4212         (LayoutTestController::setMockSpeechInputResult):
4213
4214 2010-10-21  MORITA Hajime  <morrita@google.com>
4215
4216         Reviewed by Kent Tamura.
4217