467337f2673dfa47dfc699a10915d5d7733838d2
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-02-09 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
2
3         Reviewed by Tor Arne Vestbø.
4
5         Add possibility of passing parameters to build-webkit by environment variable,
6         because the buildbot slaves can't control the arguments.
7
8         * Scripts/build-webkit:
9
10 2010-02-09  Chang Shu  <Chang.Shu@nokia.com>
11
12         Reviewed by Laszlo Gombos.
13
14         [Qt] Enable appcache feature.
15         https://bugs.webkit.org/show_bug.cgi?id=34713
16
17
18         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
19         (WebCore::WebPage::WebPage):
20         * DumpRenderTree/qt/main.cpp:
21         (main):
22
23 2010-02-09  Shinichiro Hamaji  <hamaji@chromium.org>
24
25         Reviewed by Darin Adler.
26
27         Provide a way to get total number of pages to be printed
28         https://bugs.webkit.org/show_bug.cgi?id=34699
29
30         * DumpRenderTree/LayoutTestController.cpp:
31         (parsePageParameters):
32         (pageNumberForElementByIdCallback):
33         (numberOfPagesCallback):
34         (LayoutTestController::staticFunctions):
35         * DumpRenderTree/LayoutTestController.h:
36         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
37         (LayoutTestController::numberOfPages):
38         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
39         (LayoutTestController::numberOfPages):
40         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
41         (LayoutTestController::numberOfPages):
42
43 2010-02-08  Alexey Proskuryakov  <ap@apple.com>
44
45         Reviewed by Darin Adler.
46
47         https://bugs.webkit.org/show_bug.cgi?id=34727
48         Assertion crashes and freezes when plug-in property access results in an exception
49
50         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
51         (pluginGetProperty): Raise an exception when accessing a particular property.
52         (pluginSetProperty): Ditto.
53         (pluginInvoke): Added methods to get and set host object properties.
54
55 2010-02-08  Kenneth Rohde Christiansen  <kenneth@webkit.org>
56
57         Reviewed by Ariya Hidayat.
58
59         [Qt] Backport No'am Rosenthal's frame rate measurement
60
61         * QtLauncher/main.cpp:
62         (LauncherWindow::LauncherWindow):
63         (LauncherApplication::handleUserOptions):
64         * QtLauncher/webview.cpp:
65         (WebViewGraphicsBased::WebViewGraphicsBased):
66         (WebViewGraphicsBased::enableFrameRateMeasurement):
67         (WebViewGraphicsBased::updateFrameRate):
68         (WebViewGraphicsBased::paintEvent):
69         * QtLauncher/webview.h:
70
71 2010-02-08  Kenneth Rohde Christiansen  <kenneth@webkit.org>
72
73         Reviewed by Tor Arne Vestbø.
74
75         [Qt] Make overridePreference complain when it does not
76         support the preference given.
77
78         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
79         (LayoutTestController::overridePreference):
80
81 2010-02-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
82
83         Reviewed by Kenneth Rohde Christiansen.
84
85         [Qt] Set stdout/stderr to binary mode for DRT on Windows
86
87         This makes sure we don't end up with lots of CRLFs in the
88         DRT output, which breaks tons of results. Matches what
89         the Windows DRT does.
90
91         * DumpRenderTree/qt/main.cpp:
92
93 2010-02-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
94
95         Reviewed by Kenneth Rohde Christiansen.
96
97         Build fix for Qt on Windows.
98
99         Don't use noreturn directly since it's a gcc attribute.
100         Instead use the NO_RETURN macro from AlwaysInline.h
101
102         * QtLauncher/QtLauncher.pro:
103         * QtLauncher/utils.h:
104
105 2010-02-05  Chris Jerdonek  <cjerdonek@webkit.org>
106
107         Reviewed by Shinichiro Hamaji.
108
109         Suppressed check-webkit-style's underscore check in Qt's autotests.
110         Also made the path-specific filter check case-insensitive.
111
112         https://bugs.webkit.org/show_bug.cgi?id=34574
113
114         * Scripts/webkitpy/style/checker.py:
115           - Added a list element to _PATH_RULES_SPECIFIER for
116             directories that should be excluded from the
117             "readability/naming" category (the category that relates to
118             underscores in identifiers, for example).
119
120         * Scripts/webkitpy/style/checker_unittest.py:
121           - Added an "end-to-end" test for "WebKit/qt/tests/".
122
123         * Scripts/webkitpy/style/filter.py:
124           - Altered FilterConfiguration's should_check() method to
125             check for path substring matches case-insensitively.
126
127         * Scripts/webkitpy/style/filter_unittest.py:
128           - Added a test to check case-insensitive path substring matching.
129
130         * Scripts/webkitpy/style/processors/cpp.py:
131           - Removed the hard-coded "WebKit/gtk/webkit/" path reference
132             since this is now taken care of by the _PATH_RULES_SPECIFIER
133             configuration variable.
134
135         * Scripts/webkitpy/style/processors/cpp_unittest.py:
136           - Removed the unit test for the GTK directory since this
137             is now taken care of by the checker._PATH_RULES_SPECIFIER
138             end-to-end tests.
139
140 2010-02-08  Leith Bade  <leith@leithalweapon.geek.nz>
141
142         Reviewed by Darin Adler.
143
144         Fixes: https://bugs.webkit.org/show_bug.cgi?id=34637
145         Corrects the newline inserted into WebKitOutputDir, and WebKitLibrariesDir Windows
146         environemnt variables when there is a space in the user's /home path.
147
148         * Scripts/webkitdirs.pm:
149          - Added missing quotes around $sourceDir in argument list of cygpath in determineWindowsSourceDir().
150
151 2010-02-05  Alexey Proskuryakov  <ap@apple.com>
152
153         Reviewed by Oliver Hunt.
154
155         https://bugs.webkit.org/show_bug.cgi?id=34670
156         TestNetscapePlugin should work with Firefox
157
158         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Default to Carbon if
159         browser doesn't tell what it supports.
160
161 2010-02-05  Shinichiro Hamaji  <hamaji@chromium.org>
162
163         Reviewed by Gustavo Noronha Silva.
164
165         [Gtk] Implement layoutTestController.pageNumberForElementById
166         https://bugs.webkit.org/show_bug.cgi?id=34572
167
168         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
169         (LayoutTestController::pageNumberForElementById):
170
171 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
172
173         Reviewed by Eric Seidel.
174
175         Add a simple test implementation and the WebKit Mac implementation
176         for the layout_tests/port package. Also add a simple test driver of
177         that interface.
178
179         https://bugs.webkit.org/show_bug.cgi?id=34511
180
181         * Scripts/webkitpy/layout_tests/driver_test.py: Added.
182         * Scripts/webkitpy/layout_tests/port/__init__.py:
183         * Scripts/webkitpy/layout_tests/port/mac.py: Added.
184         * Scripts/webkitpy/layout_tests/port/test.py: Added.
185
186 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
187
188         Reviewed by Eric Siedel.
189
190         Refactor the port package into an object-oriented style and merge
191         path_utils into it. We add a 'base' and a 'chromium' object to the
192         port package; this will allow us to easily add new ports (like
193         WebKit Mac).
194
195         https://bugs.webkit.org/show_bug.cgi?id=34511
196
197         * Scripts/rebaseline-chromium-webkit-tests:
198         * Scripts/run-chromium-webkit-tests:
199         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
200         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
201         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
202         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
203         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
204         * Scripts/webkitpy/layout_tests/port/__init__.py:
205         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
206         * Scripts/webkitpy/layout_tests/port/base.py: Added.
207         * Scripts/webkitpy/layout_tests/port/chromium.py: Added.
208         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
209         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
210         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
211         * Scripts/webkitpy/layout_tests/port/http_server.py:
212         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
213         * Scripts/webkitpy/layout_tests/port/path_utils.py: Removed.
214         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
215         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
216         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
217         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
218         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
219         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
220         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
221
222 2010-01-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
223
224         Reviewed by Dave Hyatt.
225
226         Implement flattening of framesets
227         https://bugs.webkit.org/show_bug.cgi?id=32717
228
229         Add support for testing frame flattening with the Qt DRT
230
231         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
232         (LayoutTestController::setFrameSetFlatteningEnabled):
233         * DumpRenderTree/qt/LayoutTestControllerQt.h:
234
235 2010-02-03  Chris Jerdonek  <cjerdonek@webkit.org>
236
237         Reviewed by Shinichiro Hamaji.
238
239         Provided a way in check-webkit-style to specify filter rules
240         on a per file or folder basis, via a configuration variable.
241
242         https://bugs.webkit.org/show_bug.cgi?id=33684
243
244         * Scripts/webkitpy/style/checker.py:
245           - Added _PATH_RULES_SPECIFIER configuration variable.
246           - In ProcessorOptions class--
247             - Changed the CategoryFilter attribute to FilterConfiguration.
248             - Added path parameter to is_reportable().
249           - Renamed ArgumentDefaults filter_rules attribute to
250             base_filter_rules.
251           - Updated ArgumentPrinter class.
252           - Added filter rule validation to ArgumentParser (instead of
253             in CategoryFilter constructor).
254
255         * Scripts/webkitpy/style/checker_unittest.py:
256           - Updated unit tests as necessary.
257           - Added unit tests for PATH_RULES_SPECIFIER.
258
259         * Scripts/webkitpy/style/error_handlers.py:
260           - Updated DefaultStyleErrorHandler to use file path when
261             calling is_reportable().
262
263         * Scripts/webkitpy/style/error_handlers_unittest.py:
264           - Updated unit tests as necessary.
265
266         * Scripts/webkitpy/style/filter.py:
267           - Marked CategoryFilter internal with an underscore.
268           - Removed argument validation from CategoryFilter.
269           - Added FilterConfiguration class.
270
271         * Scripts/webkitpy/style/filter_unittest.py:
272           - Updated CategoryFilterTest class.
273           - Added FilterConfigurationTest unit tests.
274
275         * Scripts/webkitpy/style/processors/cpp.py:
276           - Removed _is_test_filename() code.
277           - Removed hard-coded path checks from check_include_line().
278
279         * Scripts/webkitpy/style/processors/cpp_unittest.py:
280           - Removed three unit tests related to exempted files.
281
282 2010-02-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
283
284         Reviewed by Ariya Hidayat.
285
286         [Qt] Apply the command line options as settings to the
287         graphics system.
288
289         * QtLauncher/main.cpp:
290         (LauncherWindow::LauncherWindow):
291         (requiresGraphicsView):
292         (LauncherApplication::handleUserOptions):
293         * QtLauncher/webview.h:
294         (WebViewGraphicsBased::setItemCacheMode):
295
296 2010-02-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
297
298         Reviewed by Simon Hausmann.
299
300         Notify user that run-webkit-tests has to be run under Cygwin
301
302         The script will bail out if run under Windows shell or Msys.
303
304         * Scripts/run-webkit-tests:
305         * Scripts/webkitdirs.pm:
306
307 2010-02-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
308
309         Reviewed by Simon Hausmann.
310
311         [Qt] Generate convenience headers (QWebView, etc) using qmake
312
313         In Qt this is done using syncqt, but we use a pro-file instead
314         that generates makefile-rules for each of the extra headers.
315
316         These extra headers are installed alongside the normal headers.
317
318         * Scripts/webkitdirs.pm: Run qmake and make on new API-DerivedSources
319
320 2010-02-05  Andras Becsi  <abecsi@webkit.org>
321
322         Unreviewed typo fix.
323
324         Fix wrong whitespace alignment introduced in r54342.
325
326         * Scripts/run-webkit-tests:
327
328 2010-02-04  Mark Rowe  <mrowe@apple.com>
329
330         Reviewed by Timothy Hatcher.
331
332         Build fix.  Remove a symbol corresponding to an inline function from the linker export
333         file to prevent a weak external failure.
334
335         * Scripts/check-for-weak-vtables-and-externals: Renamed from WebKitTools/Scripts/check-for-weak-vtables.
336         Teach the script how to detect weak external symbols so that these errors can be caught immediately
337         in the future.
338
339 2010-02-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
340
341         Rubberstamped by Oliver Hunt.
342
343         [Qt] Make it possible to choose whether the launcher should
344         use the traditional QWidget based QWebView or the newer
345         QGraphics based QGraphicsWebView on a QGraphicsView.
346
347         * QtLauncher/main.cpp:
348         (LauncherWindow::LauncherWindow):
349         (LauncherWindow::eventFilter):
350         (LauncherWindow::loadStarted):
351         (LauncherWindow::print):
352         (LauncherWindow::screenshot):
353         (LauncherWindow::setEditable):
354         (LauncherWindow::setupUI):
355         (main):
356         * QtLauncher/webview.cpp:
357         (WebViewGraphicsBased::WebViewGraphicsBased):
358         (WebViewGraphicsBased::resizeEvent):
359         (GraphicsWebView::mousePressEvent):
360         (GraphicsWebView::contextMenuEvent):
361         * QtLauncher/webview.h:
362         (WebViewTraditional::WebViewTraditional):
363         (GraphicsWebView::GraphicsWebView):
364         (WebViewGraphicsBased::setPage):
365
366 2010-02-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
367
368         Rubberstamped by Oliver Hunt.
369
370         [Qt] QtLauncher cleanup.
371
372         Refactor option handling out in utility functions and make the
373         arguments more Qt compatible.
374
375         * QtLauncher/main.cpp:
376         (requiresGraphicsView):
377         (LauncherApplication::handleUserOptions):
378         * QtLauncher/utils.cpp:
379         (takeOptionValue):
380         (formatKeys):
381         (enumToKeys):
382         (appQuit):
383         * QtLauncher/utils.h:
384
385 2010-02-04  Andras Becsi  <abecsi@inf.u-szeged.hu>
386
387         Reviewed by Tor Arne Vestbø.
388
389         Implement a locking and scheduling mechanism for http testing sessions to be able
390         to run multiple instances of run-webkit-tests parallel on the same machine.
391         If a test session wants to run http tests and this feature is enabled, the pending
392         sessions create lockfiles with sequential lock numbers. These locks are used to schedule
393         the running test sessions in first come first served order. An exclusive lock ensures
394         that the lock numbers are sequential to avoid deadlocks and starvation.
395         Because the buildbot master specifies the flags used by slaves we need an environment
396         variable too to be able to use the feature per-slave.
397         Exporting WEBKIT_WAIT_FOR_HTTPD=1 before testing or using the --wait-for-httpd
398         flag enables this feature, otherwise this patch has no effect on the testing whatsoever.
399
400         https://bugs.webkit.org/show_bug.cgi?id=33153
401
402         * Scripts/run-webkit-tests:
403         * Scripts/webkitperl/httpd.pm:
404
405 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
406
407         Reviewed by Simon Hausmann.
408
409         Make run-webkit-tests work under Cygwin for the Qt port
410
411         setPathForRunningWebKitApp() is implemented for the Qt port
412         by using qmake to query for the location of the Qt libraries.
413
414         This requires the original environment (%ENV) to be untouched,
415         so launchWithCurrentEnv() was refactored to launchWithEnv(),
416         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
417         instead. This has the added benefit of getting rid of the temp
418         variables used for storing the current env.
419
420         openDumpTool() is also refactored a bit into platform-spesific,
421         port-spesific, and generic environment variables.
422
423         Checks for undef was added a few places to fix Perl concat
424         warnings when run-webkit-tests is aborted.
425
426         https://bugs.webkit.org/show_bug.cgi?id=33895
427
428         * Scripts/run-webkit-tests:
429         * Scripts/webkitdirs.pm:
430
431 2010-02-04  Yuzo Fujishima  <yuzo@google.com>
432
433         Unreviewed.
434
435         Add Yuzo to the committers list.
436
437         * Scripts/webkitpy/committers.py:
438
439 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
440
441         Rubber-stamped by Eric Seidel.
442
443         Change "the Chromium name" to "the name of Google Inc." in the licenses
444
445         https://bugs.webkit.org/show_bug.cgi?id=34511
446
447         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
448         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
449         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
450         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
451         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
452         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
453         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
454         * Scripts/webkitpy/layout_tests/port/__init__.py:
455         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
456         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
457         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
458         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
459         * Scripts/webkitpy/layout_tests/port/http_server.py:
460         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
461         * Scripts/webkitpy/layout_tests/port/path_utils.py:
462         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
463         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
464         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
465         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
466         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
467         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
468         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
469
470 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
471
472         Rubber-stamped by Eric Siedel.
473
474         Rename files as part of refactoring the layout_tests package. All
475         the platform_utils* module, the path_utils.py module, and
476         the http server and web socket server modules are moved into a new
477         port/ package.
478
479         https://bugs.webkit.org/show_bug.cgi?id=34511
480
481         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Removed.
482         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Removed.
483         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Removed.
484         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Removed.
485         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
486         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
487         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Removed.
488         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Removed.
489         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Removed.
490         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Removed.
491         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Removed.
492         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Removed.
493         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
494         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
495         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
496         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Removed.
497         * Scripts/webkitpy/layout_tests/port: Added.
498         * Scripts/webkitpy/layout_tests/port/__init__.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils.py.
499         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py.
500         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py.
501         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py.
502         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py.
503         * Scripts/webkitpy/layout_tests/port/http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server.py.
504         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server_base.py.
505         * Scripts/webkitpy/layout_tests/port/httpd2.pem: Copied from Scripts/webkitpy/layout_tests/layout_package/httpd2.pem.
506         * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Copied from Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf.
507         * Scripts/webkitpy/layout_tests/port/path_utils.py: Copied from Scripts/webkitpy/layout_tests/layout_package/path_utils.py.
508         * Scripts/webkitpy/layout_tests/port/websocket_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/websocket_server.py.
509         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
510         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
511         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
512         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
513         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
514         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
515
516
517 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
518
519         Rubber-stamped by Eric Seidel.
520
521         Roll back r53559 and r54084 again, because roll out didn't solve flakeyness on the Windows Test bots
522         https://bugs.webkit.org/show_bug.cgi?id=34399
523
524         * Scripts/run-iexploder-tests:
525         * Scripts/run-webkit-httpd:
526         * Scripts/run-webkit-tests:
527         * Scripts/webkitperl/httpd.pm: Added.
528
529 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
530
531         Rubber-stamped by Eric Seidel.
532
533         Roll out r53559 and r54084, because it might caused flakeyness on the Windows Test bots
534
535         * Scripts/run-iexploder-tests:
536         * Scripts/run-webkit-httpd:
537         * Scripts/run-webkit-tests:
538         * Scripts/webkitperl/httpd.pm: Removed.
539
540 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
541
542         Rubber-stamped by Ariya Hidayat.
543
544         Roll back r53889 again, because roll out didn't solve flakeyness on the Windows Test bots
545         https://bugs.webkit.org/show_bug.cgi?id=34399
546
547         * DumpRenderTree/win/EventSender.cpp:
548         (buildModifierFlags):
549         (mouseDownCallback):
550         (mouseUpCallback):
551         (keyDownCallback):
552
553 2010-02-03  Eric Seidel  <eric@webkit.org>
554
555         No review, just fixing copyrights.
556
557         Concerns were expressed about "The Chromium Authors" being
558         a valid legal entity for copyright assignment in the WebKit repository,
559         so this change removes all "The Chromium Authors".
560
561         I looked at the svn logs in src.chromium.org and failed to find any
562         non-google contributions to these files, so they are all now
563         marked as copyright "Google Inc" as all Google contributers assign
564         copyright to "Google Inc" as part of their employment agreement.
565
566         * Scripts/rebaseline-chromium-webkit-tests:
567         * Scripts/run-chromium-webkit-tests:
568         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py:
569         * Scripts/webkitpy/layout_tests/layout_package/http_server.py:
570         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py:
571         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
572         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
573         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
574         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py:
575         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py:
576         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py:
577         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py:
578         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py:
579         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
580         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
581         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
582         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
583         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py:
584         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
585         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
586         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
587         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
588         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
589         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
590
591 2010-02-03  Kenneth Rohde Christiansen  <kenneth@webkit.org>
592
593         Reviewed by Ariya Hidayat.
594
595         [Qt] QtLauncher, refactor argument handling in preparation of merge
596         with QGVLauncher
597
598         * QtLauncher/main.cpp:
599         (LauncherApplication::urls):
600         (LauncherApplication::isRobotized):
601         (LauncherApplication::applyDefaultSettings):
602         (LauncherApplication::LauncherApplication):
603         (LauncherApplication::formatKeys):
604         (LauncherApplication::enumToKeys):
605         (fail):
606         (LauncherApplication::handleUserOptions):
607         (main):
608
609 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
610
611         Rubber-stamped by Ariya Hidayat.
612
613         Rolling out r53889, because it might caused flakeyness on the Windows Test bots
614         https://bugs.webkit.org/show_bug.cgi?id=34399
615
616         * DumpRenderTree/win/EventSender.cpp:
617         (mouseDownCallback):
618         (mouseUpCallback):
619         (keyDownCallback):
620
621 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
622
623         Reviewed by Ariya Hidayat.
624
625         [Qt] Fix pixel tests support.
626         https://bugs.webkit.org/show_bug.cgi?id=27813
627
628         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
629         (WebCore::DumpRenderTree::open):
630         (WebCore::DumpRenderTree::processLine):
631          - Hash processing mechanism moved from DumpRenderTree::open to DumpRenderTree::processLine.
632         (WebCore::DumpRenderTree::dump): Fixed and renamed variables.
633
634 2010-02-03  Kevin Watters  <kevinwatters@gmail.com>
635
636         Reviewed by Kevin Ollivier.
637
638         [wx] Enable JIT compilation for wx.
639         
640         https://bugs.webkit.org/show_bug.cgi?id=34536
641
642         * wx/build/settings.py:
643
644 2010-02-02  Kevin Ollivier  <kevino@theolliviers.com>
645
646         [wx] Build fix after introduction of pageNumberForElementById.
647
648         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
649         (LayoutTestController::pageNumberForElementById):
650
651 2010-02-02  Shu Chang  <Chang.Shu@nokia.com>
652
653         Unreviewed.
654
655         Add myself to list of committers.
656
657         * Scripts/webkitpy/committers.py:
658
659 2010-02-02  Chris Jerdonek  <cjerdonek@webkit.org>
660
661         Reviewed by Shinichiro Hamaji.
662
663         Moved filter-related check-webkit-style code into a separate
664         filter module.
665
666         https://bugs.webkit.org/show_bug.cgi?id=34408
667
668         This is preparatory refactoring for Bug 33684, which will allow
669         file and folder-specific filter rules.
670
671         * Scripts/webkitpy/style/checker.py:
672           - Removed CategoryFilter class (moved to filter.py).
673
674         * Scripts/webkitpy/style/checker_unittest.py:
675           - Removed CategoryFilter unit tests (moved to filter_unittest.py).
676
677         * Scripts/webkitpy/style/filter.py: Added.
678           - Added CategoryFilter class (moved from checker.py).
679
680         * Scripts/webkitpy/style/filter_unittest.py: Added.
681           - Added CategoryFilter unit tests (moved from checker_unittest.py).
682
683         * Scripts/webkitpy/style/unittests.py:
684           - Added reference to filter_unittest.py.
685
686 2010-02-01  Chris Jerdonek  <cjerdonek@webkit.org>
687
688         Reviewed by Shinichiro Hamaji.
689
690         Addressed FIXME in check-webkit-style so that the carriage-return
691         check will work for patches.
692
693         https://bugs.webkit.org/show_bug.cgi?id=34260
694
695         Also added support for limiting the number of errors reported
696         per category, per file.
697
698         * Scripts/webkitpy/style/checker.py:
699           - Added new "whitespace/carriage_return" category from common.py.
700           - Added MAX_REPORTS_PER_CATEGORY dictionary.
701           - Added max_reports_per_category attribute to ProcessorOptions class.
702           - Refactored StyleChecker._process_file().
703
704         * Scripts/webkitpy/style/checker_unittest.py:
705           - Updated ProcessorOptionsTest tests.
706           - Added test to check MAX_REPORTS_PER_CATEGORY.
707
708         * Scripts/webkitpy/style/error_handlers.py:
709           - Added support for suppressing the display of errors after
710             reaching a per-category maximum (from max_reports_per_category).
711
712         * Scripts/webkitpy/style/error_handlers_unittest.py:
713           - Added test for suppressing error display.
714
715         * Scripts/webkitpy/style/processors/common.py: Added.
716           - Moved carriage-return check to new file.
717
718         * Scripts/webkitpy/style/processors/common_unittest.py: Added.
719           - Added unit tests for carriage-return check.
720
721         * Scripts/webkitpy/style/unittests.py:
722           - Added reference to common_unittest.py.
723
724 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
725
726         Reviewed by Eric Seidel.
727
728         Provide a way to get page number with layoutTestController
729         https://bugs.webkit.org/show_bug.cgi?id=33840
730
731         * DumpRenderTree/LayoutTestController.cpp:
732         (pageNumberForElementByIdCallback):
733         (LayoutTestController::staticFunctions):
734         * DumpRenderTree/LayoutTestController.h:
735         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
736         (LayoutTestController::pageNumberForElementById):
737         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
738         (LayoutTestController::pageNumberForElementById):
739         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
740         (LayoutTestController::pageNumberForElementById):
741
742 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
743
744         Unreviewed fix for an invalid function call.
745
746         check-webkit-style: Remove filename parameter from all functions where no longer used
747         https://bugs.webkit.org/show_bug.cgi?id=34249
748
749         * Scripts/webkitpy/style/checker.py:
750
751 2010-02-01  Diego Gonzalez  <diego.gonzalez@openbossa.org>
752
753         Reviewed by Kenneth Rohde Christiansen.
754
755         [Qt] DRT Provide global flag ability
756         https://bugs.webkit.org/show_bug.cgi?id=34418
757
758         Add the globalFlag property to the Qt LayoutTestController to allow
759         cross-domain indications.
760
761         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
762         (LayoutTestController::reset):
763         * DumpRenderTree/qt/LayoutTestControllerQt.h:
764         (LayoutTestController::globalFlag):
765         (LayoutTestController::setGlobalFlag):
766
767 2010-02-01  Brady Eidson  <beidson@apple.com>
768
769         Reviewed by Adele Peterson.
770
771         Crash in Safari opening new tabs to "same page"
772         <rdar://problem/7593857> and https://bugs.webkit.org/show_bug.cgi?id=34444
773
774         Add a mode (Mac-only for now) that exercises the WebView SPI _loadBackForwardListFromOtherView:
775
776         * DumpRenderTree/LayoutTestController.cpp:
777         (LayoutTestController::LayoutTestController):
778         (setNewWindowsCopyBackForwardListCallback):
779         (LayoutTestController::staticFunctions):
780
781         * DumpRenderTree/LayoutTestController.h:
782         (LayoutTestController::newWindowsCopyBackForwardList):
783         (LayoutTestController::setNewWindowsCopyBackForwardList):
784
785         * DumpRenderTree/mac/UIDelegate.mm:
786         (-[UIDelegate webView:createWebViewWithRequest:]):
787
788 2010-02-01  Carol Szabo  <carol.szabo@nokia.com>
789
790         Unreviewed.
791
792         Add myself to list of committers.
793
794         * Scripts/webkitpy/committers.py:
795
796 2010-02-01  Nate Chapin  <japhet@chromium.org>
797
798         Rubber-stamped by David Levin.
799
800         Add myself to reviewer list.
801
802         * Scripts/webkitpy/committers.py:
803
804 2010-01-31  Chris Jerdonek  <cjerdonek@webkit.org>
805
806         Reviewed by Shinichiro Hamaji.
807
808         Moved style error handler code to their own classes, and
809         related refactoring. Increased unit test code coverage of
810         style error handling.
811
812         https://bugs.webkit.org/show_bug.cgi?id=34379
813
814         * Scripts/check-webkit-style:
815           - Minor change: added error_count variable.
816
817         * Scripts/webkitpy/style/checker.py:
818           - Renamed ProcessorOptions.should_report_error() to is_reportable().
819           - In the StyleChecker class--
820             - Removed _default_style_error_handler().
821             - Added _increment_error_count().
822             - Refactored to use DefaultStyleErrorHandler and
823               PatchStyleErrorHandler constructors.
824
825         * Scripts/webkitpy/style/checker_unittest.py:
826           - In the StyleStyleCheckerTest class--
827             - Removed write_sample_error().
828             - Removed test_default_style_error_handler().
829
830         * Scripts/webkitpy/style/error_handlers.py: Added.
831           - Added DefaultStyleErrorHandler class.
832           - Added PatchStyleErrorHandler class.
833
834         * Scripts/webkitpy/style/error_handlers_unittest.py: Added.
835           - Added unit tests for DefaultStyleErrorHandler and
836             PatchStyleErrorHandler.
837
838         * Scripts/webkitpy/style/unittests.py:
839           - Added error_handlers unit tests.
840
841 2010-01-29  Mark Rowe  <mrowe@apple.com>
842
843         Rubber-stamped by Stephanie Lewis.
844
845         Fix run-leaks with newer versions of the leaks tool.
846
847         * Scripts/run-leaks:
848
849 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
850
851         Reviewed by Eric Siedel.
852
853         Top-level test drivers for running the Chromium port of run-webkit-tests
854         and being able to rebaseline test results from the test bots.  The
855         files in the Scripts directory are simply wrappers around the files
856         in webkitpy/layout_tests for convenience.
857  
858         https://bugs.webkit.org/show_bug.cgi?id=31498
859
860         * Scripts/rebaseline-chromium-webkit-tests: Added.
861         * Scripts/run-chromium-webkit-tests: Added.
862         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Added.
863         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: Added.
864
865 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
866
867         Reviewed by Eric Siedel.
868
869         Add in the second block of python code for the Chromium port
870         of run-webkit-tests. These files execute different diffs to classify
871         the various types of failures from a test.
872
873         * Scripts/webkitpy/layout_tests/test_types: Added.
874         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Added.
875         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Added.
876         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Added.
877         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Added.
878         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Added.
879
880 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
881
882         Reviewed by Eric Siedel.
883
884         Check in the first part of the Chromium Python port of the 
885         run-webkit-tests test driver. The files under 
886         layout_tests/layout_layout constitute most of the implementation;
887         they can be roughly divided into code that parses the 
888         "test_expectations.txt" file that describes how we expect tests to
889         pass or fail, platform-specific hooks for the different Chromium 
890         ports (in platform_utils*), code for parsing the output of the
891         tests and generating results files and HTML and JSON for the
892         dashboards, auxiliary scripts for starting and stopping HTTP and
893         Web Socket servers, and then one of the actual driver files 
894         (test_shell_thread). Code for actually parsing test output for 
895         failures and the top-level driver scripts will follow shortly.
896
897         https://bugs.webkit.org/show_bug.cgi?id=31498
898
899         * Scripts/webkitpy/layout_tests: Added.
900         * Scripts/webkitpy/layout_tests/layout_package: Added.
901         * Scripts/webkitpy/layout_tests/layout_package/__init__.py: Added.
902         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Added.
903         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Added.
904         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Added.
905         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Added.
906           - scripts to start and stop apache. Note that the apache file
907             generates a conf file dynamically, and we should switch to 
908             using the same static conf file that the regular run-webkit-tests
909             uses, and we can also use the same httpd2.pem file.
910
911         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Added.
912         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Added.
913           - scripts to generate the JSON layout test dashboard and the
914             flakiness dashboard
915         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Added.
916           - default configuration for LigHTTPd (used on Windows)
917         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Added.
918           - utility class that implements progress bars on the console to
919             be displayed while the tests are running
920         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Added.
921           - various routines for manipulating paths and URIs
922         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Added.
923         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Added.
924         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Added.
925         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Added.
926           - platform-specific aspects of the drivers (binary names, paths,
927             process control, etc.)
928         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Added.
929           - code for parsing the 'test_expectations.txt' file to determine
930             which tests are expected to fail (and how) on which platforms
931         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Added.
932           - code for handling different kinds of failures (generating output
933             in the results, etc.)
934         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Added.
935           - code to gather the lists of tests
936         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Added.
937           - code to actually execute tests via TestShell and process
938             the output
939         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Added.
940           - scripts to start and stop the pywebsocket server
941
942 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
943
944         Reviewed by Eric Seidel.
945
946         Check in a copy of the simplejson library; it will be used by
947         the Chromium port of run-webkit-tests.
948         
949         https://bugs.webkit.org/show_bug.cgi?id=31498
950
951         * simplejson: Added.
952         * simplejson/LICENSE.txt: Added.
953         * simplejson/README.txt: Added.
954         * simplejson/__init__.py: Added.
955         * simplejson/_speedups.c: Added.
956         (ascii_escape_char):
957         (ascii_escape_unicode):
958         (ascii_escape_str):
959         (py_encode_basestring_ascii):
960         (init_speedups):
961         * simplejson/decoder.py: Added.
962         * simplejson/encoder.py: Added.
963         * simplejson/jsonfilter.py: Added.
964         * simplejson/scanner.py: Added.
965
966 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
967
968         No review
969
970         Add myself to the committers list
971
972         * Scripts/webkitpy/committers.py:
973
974 2010-01-29  Jeremy Orlow  <jorlow@chromium.org>
975
976         Reviewed by Dimitri Glazkov.
977
978         A first step towards the Indexed Database API
979         https://bugs.webkit.org/show_bug.cgi?id=34342
980
981         Add indexed database API.
982
983         * Scripts/build-webkit:
984
985 2010-01-29  Andras Becsi  <abecsi@webkit.org>
986
987         Reviewed by Alexey Proskuryakov.
988
989         Correct openHTTPD() to print requests to stdout if run-webkit-httpd is used.
990         This fixes a regression introduced in r53559.
991
992         https://bugs.webkit.org/show_bug.cgi?id=34336
993
994         * Scripts/webkitperl/httpd.pm:
995
996 2010-01-28  Jon Honeycutt  <jhoneycutt@apple.com>
997
998         MSAA: Crash when posting a notification for a detached object
999
1000         https://bugs.webkit.org/show_bug.cgi?id=34309
1001         <rdar://problem/7409759>
1002
1003         Reviewed by Darin Adler.
1004
1005         * DumpRenderTree/AccessibilityController.h:
1006         Declare new functions. Add new members to store the event hook and the
1007         mapping of accessibility elements to their JS callbacks.
1008
1009         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1010         (AccessibilityController::notificationReceived):
1011         Stubbed.
1012         (AccessibilityController::addNotificationListener):
1013         Stubbed.
1014
1015         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1016         (AccessibilityController::notificationReceived):
1017         Stubbed.
1018         (AccessibilityController::addNotificationListener):
1019         Stubbed.
1020
1021         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1022         (AccessibilityController::AccessibilityController):
1023         Initialize the event hook.
1024         (AccessibilityController::~AccessibilityController):
1025         Remove the event hook. Unprotect all of the JS functions that are stored
1026         in the map.
1027         (logEventProc):
1028         Clean-up a variable.
1029         (stringEvent):
1030         Return a string description of the MSAA event code.
1031         (notificationListenerProc):
1032         Get the accessible object from the event, and query it for IAccessible.
1033         Call the AccessibilityController's notificationReceived().
1034         (comparableObject):
1035         Use QueryService to obtain the IAccessibleComparable for the
1036         IServiceProvider.
1037         (AccessibilityController::notificationReceived):
1038         Iterate the map of objects that have registered for notification
1039         callbacks. Query each for IServiceProvider, then use comparableObject()
1040         to get an IAccessibleComparable. If we find an object matching the
1041         notified object, call its callback, passing the event that was received.
1042         (AccessibilityController::addNotificationListener):
1043         If we have not created the event hook, create it. Protect the JS
1044         callback function object, and add the object and its callback to our
1045         map.
1046
1047         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1048         (AccessibilityUIElement::addNotificationListener):
1049         Call through to the AccessibilityController's addNotificationListener().
1050
1051         * DumpRenderTree/win/DumpRenderTreeWin.h:
1052         Add an extern declaration for the shared FrameLoadDelegate extern, so we
1053         can access it from AccessibilityController.
1054
1055         * DumpRenderTree/win/FrameLoadDelegate.h:
1056         (FrameLoadDelegate::accessibilityController):
1057         Return the AccessibilityController.
1058
1059 2010-01-29  Shinichiro Hamaji  <hamaji@chromium.org>
1060
1061         Reviewed by Darin Adler.
1062
1063         prepare-ChangeLog outputs useless messages for a nonexistent bug ID
1064         https://bugs.webkit.org/show_bug.cgi?id=34313
1065
1066         * Scripts/prepare-ChangeLog:
1067
1068 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1069
1070         Rubberstamped by Simon Hausmann.
1071
1072         [Qt] Separate implementation from class definition.
1073
1074         * QtLauncher/main.cpp:
1075         (LauncherWindow::webView):
1076         (LauncherWindow::LauncherWindow):
1077         (LauncherWindow::~LauncherWindow):
1078         (LauncherWindow::keyPressEvent):
1079         (LauncherWindow::grabZoomKeys):
1080         (LauncherWindow::sendTouchEvent):
1081         (LauncherWindow::eventFilter):
1082         (LauncherWindow::loadStarted):
1083         (LauncherWindow::loadFinished):
1084         (LauncherWindow::showLinkHover):
1085         (LauncherWindow::zoomIn):
1086         (LauncherWindow::zoomOut):
1087         (LauncherWindow::resetZoom):
1088         (LauncherWindow::toggleZoomTextOnly):
1089         (LauncherWindow::print):
1090         (LauncherWindow::screenshot):
1091         (LauncherWindow::setEditable):
1092         (LauncherWindow::dumpHtml):
1093         (LauncherWindow::selectElements):
1094         (LauncherWindow::setTouchMocking):
1095         (LauncherWindow::newWindow):
1096         (LauncherWindow::setupUI):
1097
1098 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1099
1100         Reviewed by Ariya Hidayat.
1101
1102         [Qt] On Maemo5, a click/touch in the location bar (when unfocused)
1103         should result in all text selected.
1104
1105         * QtLauncher/locationedit.cpp:
1106         (LocationEdit::focusInEvent):
1107         * QtLauncher/locationedit.h:
1108
1109 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1110
1111         Reviewed by Ariya Hidayat.
1112
1113         [Qt] Show progress reaching 100% for loads.
1114
1115         * QtLauncher/locationedit.cpp:
1116         (LocationEdit::LocationEdit):
1117         (LocationEdit::setProgress):
1118         (LocationEdit::reset):
1119         (LocationEdit::paintEvent):
1120         * QtLauncher/locationedit.h:
1121
1122 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
1123
1124         Reviewed by Kenneth Rohde Christiansen.
1125
1126         [Qt] Disable the QtLauncher statusbar on Maemo
1127
1128         https://bugs.webkit.org/show_bug.cgi?id=34330
1129
1130         * QtLauncher/main.cpp:
1131         (LauncherWindow::showLinkHover):
1132         (LauncherWindow::selectElements):
1133
1134 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
1135
1136         Reviewed by Kenneth Rohde Christiansen.
1137
1138         [Qt] Display page loading progress inside the QtLauncher location bar
1139
1140         https://bugs.webkit.org/show_bug.cgi?id=34210
1141
1142         * QtLauncher/QtLauncher.pro:
1143         * QtLauncher/locationedit.cpp: Added.
1144         (LocationEdit::LocationEdit):
1145         (LocationEdit::setProgress):
1146         (LocationEdit::paintEvent):
1147         * QtLauncher/locationedit.h: Added.
1148         * QtLauncher/mainwindow.cpp:
1149         (MainWindow::buildUI):
1150         * QtLauncher/mainwindow.h:
1151
1152 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
1153
1154         Reviewed by Kenneth Rohde Christiansen.
1155
1156         [Qt] Add support for Maemo zoom keys in QtLauncher
1157
1158         https://bugs.webkit.org/show_bug.cgi?id=34160
1159
1160         * QtLauncher/main.cpp:
1161         (LauncherWindow::LauncherWindow):
1162         (LauncherWindow::~LauncherWindow):
1163         (LauncherWindow::keyPressEvent):
1164         (LauncherWindow::grabZoomKeys):
1165
1166 2010-01-29  Benjamin Poulain  <benjamin.poulain@nokia.com>
1167
1168         Reviewed by Kenneth Rohde Christiansen.
1169
1170         [Qt] Implement the display() method of the layout test controller
1171         https://bugs.webkit.org/show_bug.cgi?id=34258
1172
1173         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1174         (WebCore::DumpRenderTree::DumpRenderTree):
1175         (WebCore::DumpRenderTree::showPage):
1176         (WebCore::DumpRenderTree::hidePage):
1177         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1178         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1179         (LayoutTestController::reset):
1180         (LayoutTestController::display):
1181         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1182
1183 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
1184
1185         [wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation
1186         implements pthread_t in a way that makes it impossible to check its validity,
1187         which is needed by ThreadingPthreads.cpp.
1188
1189         * DumpRenderTree/wscript:
1190         * wx/build/settings.py:
1191
1192 2010-01-28  Andras Becsi  <abecsi@webkit.org>
1193
1194         Adding myself to the committer list. No review needed.
1195
1196         * Scripts/webkitpy/committers.py:
1197
1198 2010-01-28  Hayato Ito  <hayato@chromium.org>
1199
1200         Reviewed by David Levin.
1201
1202         Remove NULL char from input JS file because 'grep' fails if the file contains NULL char.
1203
1204         https://bugs.webkit.org/show_bug.cgi?id=34252
1205
1206         * Scripts/make-script-test-wrappers:
1207
1208 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
1209
1210         [wx] Build fix after removal of the zlib image decoder.
1211
1212         * wx/build/settings.py:
1213
1214 2010-01-28  Csaba Osztrogonác  <ossy@webkit.org>
1215
1216         [Qt] Unreviewed, roll out r54000.
1217
1218         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1219         (WebCore::DumpRenderTree::DumpRenderTree):
1220         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1221         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1222         (LayoutTestController::reset):
1223         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1224         (LayoutTestController::display):
1225
1226 2010-01-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1227
1228         Reviewed by Kenneth Rohde Christiansen.
1229
1230         [Qt] Implement the display() method of the layout test controller
1231         https://bugs.webkit.org/show_bug.cgi?id=34258
1232
1233         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1234         (WebCore::DumpRenderTree::DumpRenderTree):
1235         (WebCore::DumpRenderTree::showPage):
1236         (WebCore::DumpRenderTree::hidePage):
1237         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1238         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1239         (LayoutTestController::reset):
1240         (LayoutTestController::display):
1241         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1242
1243 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
1244
1245         Reviewed by Shinichiro Hamaji.
1246
1247         Eliminated the filename parameter from functions in
1248         check-webkit-style's cpp.py where it is no longer used.
1249
1250         https://bugs.webkit.org/show_bug.cgi?id=34249
1251
1252         * Scripts/webkitpy/style/processors/cpp.py:
1253           - Reduced number of occurrences of "filename" variable from
1254             approximately 200 to 120.
1255
1256         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1257           - Refactored unit tests as necessary to accommodate changes to cpp.py.
1258           - Fixed bug in CppStyleTestBase.perform_include_what_you_use()
1259             where the incorrect file extension was getting passed to
1260             cpp_style.check_language().
1261
1262 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
1263
1264         Reviewed by Shinichiro Hamaji.
1265
1266         In check-webkit-style, eliminated the dependency of
1267         processors/cpp_unittest.py on checker.py.
1268
1269         https://bugs.webkit.org/show_bug.cgi?id=34205
1270
1271         * Scripts/webkitpy/style/checker.py:
1272           - Addressed FIXME by removing STYLE_CATEGORIES data.
1273           - Added style_categories().
1274
1275         * Scripts/webkitpy/style/checker_unittest.py:
1276           - Minor changes.
1277
1278         * Scripts/webkitpy/style/processors/cpp.py:
1279           - Added categories attribute to CppProcessor class (data
1280             was originally checker.STYLE_CATEGORIES).
1281
1282         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1283           - Addressed FIXME by eliminating "import" from checker.py.
1284
1285 2010-01-28  Anton Muhin  <antonm@chromium.org>
1286
1287         Reviewed by Shinichiro Hamaji.
1288
1289         Improve treatment of conditions and rest of the line for if, else, switch and alikes
1290         https://bugs.webkit.org/show_bug.cgi?id=34173
1291
1292         * Scripts/webkitpy/style/cpp_style.py:
1293         * Scripts/webkitpy/style/cpp_style_unittest.py:
1294
1295 2010-01-28  Joe Mason  <jmason@rim.com>
1296
1297         Reviewed by Adam Barth.
1298
1299         Limit login retries to 5
1300         https://bugs.webkit.org/show_bug.cgi?id=34193
1301
1302         * Scripts/webkitpy/bugzilla.py:
1303
1304 2010-01-27  Martin Robinson  <mrobinson@webkit.org>
1305
1306         Adding myself to the committer list. No review necessary.
1307
1308         * Scripts/webkitpy/committers.py:
1309
1310 2010-01-27  George Wright  <gwright@rim.com>
1311
1312         Reviewed by Adam Treat.
1313
1314         https://bugs.webkit.org/show_bug.cgi?id=34216
1315
1316         Add missing include for wtf/Platform.h
1317
1318         * DumpRenderTree/AccessibilityController.h:
1319
1320 2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1321
1322         Reviewed by Kenneth Rohde Christiansen.
1323
1324         [Qt] DRT Provide worker thread ability to track counters
1325         https://bugs.webkit.org/show_bug.cgi?id=34221
1326
1327         Implement workerThreadCount() in LayoutTestController of Qt DRT
1328
1329         Tests:
1330         fast/workers/dedicated-worker-lifecycle.html
1331         fast/workers/shared-worker-frame-lifecycle.html
1332         fast/workers/shared-worker-lifecycle.html
1333         fast/workers/worker-lifecycle.html
1334
1335         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1336         (LayoutTestController::workerThreadCount):
1337         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1338
1339 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1340
1341         Rubberstamped by Simon Hausmann.
1342
1343         [Qt] QtLauncher refactoring:
1344
1345         Make the LauncherWindow depend less on the view, so that more
1346         code can be shared in near future.
1347
1348         * QtLauncher/main.cpp:
1349         (LauncherWindow::sendTouchEvent):
1350         (LauncherWindow::loadFinished):
1351         (LauncherWindow::zoomIn):
1352         (LauncherWindow::zoomOut):
1353         (LauncherWindow::resetZoom):
1354         (LauncherWindow::toggleZoomTextOnly):
1355         (LauncherWindow::dumpHtml):
1356         (LauncherWindow::selectElements):
1357         (LauncherWindow::setupUI):
1358
1359 2010-01-27  Kinuko Yasuda  <kinuko@chromium.org>
1360
1361         Reviewed by Eric Seidel.
1362
1363         Correctly handle the KeyLocation argument that has been introduced
1364         recently to test location-dependent key events in EventSender.keyDown.
1365         http://bugs.webkit.org/show_bug.cgi?id=28247
1366
1367         Test: fast/events/keydown-numpad-keys.html
1368
1369         * DumpRenderTree/gtk/EventSender.cpp:
1370         (keyDownCallback):
1371
1372 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1373
1374         Rubberstamped by Simon Hausmann.
1375
1376         [Qt] QtLauncher refactoring:
1377
1378         Move out code from the MainWindow (renamed to LauncherWindow)
1379         that is not depending on the view, and add it to a new class
1380         called MainWindow.
1381
1382         * QtLauncher/QtLauncher.pro:
1383         * QtLauncher/main.cpp:
1384         (LauncherWindow::LauncherWindow):
1385         (LauncherWindow::eventFilter):
1386         (LauncherWindow::loadStarted):
1387         (LauncherWindow::loadFinished):
1388         (LauncherWindow::newWindow):
1389         (LauncherWindow::setupUI):
1390         (WebPage::createWindow):
1391         (main):
1392         * QtLauncher/mainwindow.cpp: Added.
1393         (MainWindow::MainWindow):
1394         (MainWindow::buildUI):
1395         (MainWindow::page):
1396         (MainWindow::setAddressUrl):
1397         (MainWindow::addCompleterEntry):
1398         (MainWindow::load):
1399         (MainWindow::changeLocation):
1400         (MainWindow::openFile):
1401         * QtLauncher/mainwindow.h: Added.
1402
1403 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1404
1405         Rubberstamped by Simon Hausmann.
1406
1407         [Qt] QtLauncher, coding style fixes.
1408
1409         * QtLauncher/main.cpp:
1410         (MainWindow::MainWindow):
1411         (MainWindow::sendTouchEvent):
1412         (MainWindow::eventFilter):
1413         (MainWindow::loadURL):
1414         (MainWindow::setupUI):
1415         (WebPage::createPlugin):
1416
1417 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1418
1419         Rubberstamped by Simon Hausmann.
1420
1421         [Qt] QtLauncher refactoring, separating the webview and
1422         adding a QGraphicsWebView based version.
1423
1424         * QtLauncher/QtLauncher.pro:
1425         * QtLauncher/main.cpp:
1426         (MainWindow::MainWindow):
1427         * QtLauncher/webpage.h:
1428         * QtLauncher/webview.cpp: Added.
1429         (createContextMenu):
1430         (WebViewGraphicsBased::mousePressEvent):
1431         (WebViewTraditional::mousePressEvent):
1432         (WebViewGraphicsBased::contextMenuEvent):
1433         (WebViewTraditional::contextMenuEvent):
1434         * QtLauncher/webview.h: Added.
1435         (WebViewGraphicsBased::WebViewGraphicsBased):
1436         (WebViewTraditional::WebViewTraditional):
1437
1438 2010-01-27  Alexander Pavlov  <apavlov@chromium.org>
1439
1440         Adding myself as committer. No review necessary.
1441
1442         * Scripts/webkitpy/committers.py:
1443
1444 2010-01-27  Eric Seidel  <eric@webkit.org>
1445
1446         Reviewed by Darin Adler.
1447
1448         webkit-patch needs an open-bugs command
1449         https://bugs.webkit.org/show_bug.cgi?id=30793
1450
1451         * Scripts/test-webkitpy: import OpenBugsTest
1452         * Scripts/webkit-patch: import OpenBugs
1453         * Scripts/webkitpy/commands/download_unittest.py: don't import unittest
1454         * Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto
1455         * Scripts/webkitpy/commands/queries_unittest.py: ditto
1456         * Scripts/webkitpy/commands/queues_unittest.py: ditto
1457         * Scripts/webkitpy/commands/upload_unittest.py: ditto
1458         * Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called.
1459
1460 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1461
1462         Rubberstamped by Simon Hausmann
1463
1464         [Qt] QtLauncher refactoring, separating utility methods.
1465
1466         * QtLauncher/QtLauncher.pro:
1467         * QtLauncher/main.cpp:
1468         * QtLauncher/utils.cpp: Added.
1469         (urlFromUserInput):
1470         * QtLauncher/utils.h: Added.
1471
1472 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1473
1474         Rubberstamped by Simon Hausmann
1475
1476         [Qt] Refactor the code in the QtLauncher dealing with HTTP proxy.
1477
1478         * QtLauncher/main.cpp:
1479         (MainWindow::MainWindow):
1480         * QtLauncher/webpage.cpp:
1481         (WebPage::WebPage):
1482         (WebPage::applyProxy):
1483         * QtLauncher/webpage.h:
1484
1485 2010-01-26  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1486
1487         Reviewed by Tor Arne Vestbø.
1488
1489         [Qt] Corrects debug build of DumpRenderTree on Windows.
1490
1491         * DumpRenderTree/qt/DumpRenderTree.pro:
1492
1493 2010-01-26  Daniel Bates  <dbates@webkit.org>
1494
1495         Reviewed by Adam Barth.
1496
1497         https://bugs.webkit.org/show_bug.cgi?id=34070
1498
1499         Moves the try/catch for OSError exceptions in Executive.run_command
1500         to Credentials.read_credentials() so that the unit test
1501         webkitpy.scm_unittest.SCMClassTests.test_error_handlers can
1502         assert that Executive.run_command throws an OSError exception.
1503
1504         * Scripts/webkitpy/credentials.py:
1505         * Scripts/webkitpy/executive.py: Moved try/catch for OSError to
1506         method Credentials.read_credentials().
1507         * Scripts/webkitpy/executive_unittest.py: Removed tests that no longer
1508         apply: test_run_command_with_bad_command_check_return_code and
1509         test_run_command_with_bad_command_check_calls_error_handler. Added new
1510         test to assert that run_command throws OSError exceptions.
1511
1512 2010-01-26  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1513
1514         Reviewed by Kenneth Rohde Christiansen.
1515
1516         [Qt] DRT WebHistory support
1517         https://bugs.webkit.org/show_bug.cgi?id=34167
1518
1519         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1520         (LayoutTestController::reset):
1521         (LayoutTestController::webHistoryItemCount):
1522         (LayoutTestController::keepWebHistory):
1523         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1524
1525 2010-01-26  Kent Tamura  <tkent@chromium.org>
1526
1527         Reviewed by Eric Seidel.
1528
1529         [Win] Add modifiers parameter support to Windows DumpRenderTree
1530         https://bugs.webkit.org/show_bug.cgi?id=34068
1531
1532         Add support for functional name modifiers; "addSelectionKey" and
1533         "rangeSelectionKey", and modifiers parameter to eventSender.mouseDown()
1534         and eventSender.mouseUp().
1535         This change is similar to r53498 for Mac.
1536         
1537         * DumpRenderTree/win/EventSender.cpp:
1538         (buildModifierFlags): New function to set MK_CONTROL or MK_SHIFT to WPARAM.
1539         (mouseDownCallback): Call buidlModifiersFlags().
1540         (mouseUpCallback): ditto.
1541         (keyDownCallback): Add support for "addSelectionkey" and "rangeSelectionKey".
1542
1543 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
1544
1545         Reviewed by Eric Seidel.
1546
1547         The Python autoinstall cache directory now only gets created
1548         in the directory containing autoinstall.py.
1549
1550         https://bugs.webkit.org/show_bug.cgi?id=33365
1551
1552         * Scripts/webkitpy/autoinstall.py:
1553           - Also added a README file to the cache directory saying
1554             where it came from.
1555
1556 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
1557
1558         Reviewed by Eric Seidel.
1559
1560         Moved the check-webkit-style processors into a new
1561         webkitpy/style/processors directory.
1562
1563         https://bugs.webkit.org/show_bug.cgi?id=34060
1564
1565         * Scripts/webkitpy/style/checker.py:
1566         * Scripts/webkitpy/style/checker_unittest.py:
1567         * Scripts/webkitpy/style/cpp_style.py: Removed.
1568         * Scripts/webkitpy/style/cpp_style_unittest.py: Removed.
1569         * Scripts/webkitpy/style/processors: Added.
1570         * Scripts/webkitpy/style/processors/__init__.py: Added.
1571         * Scripts/webkitpy/style/processors/cpp.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style.py.
1572         * Scripts/webkitpy/style/processors/cpp_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py.
1573         * Scripts/webkitpy/style/processors/text.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style.py.
1574         * Scripts/webkitpy/style/processors/text_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style_unittest.py.
1575         * Scripts/webkitpy/style/text_style.py: Removed.
1576         * Scripts/webkitpy/style/text_style_unittest.py: Removed.
1577         * Scripts/webkitpy/style/unittests.py:
1578
1579 2010-01-26  Kevin Ollivier  <kevino@theolliviers.com>
1580
1581         [wx] Build fix, make sure stub function returns a value.
1582
1583         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1584         (LayoutTestController::counterValueForElementById):
1585
1586 2010-01-26  Steve Falkenburg  <sfalken@apple.com>
1587
1588         Reviewed by Oliver Hunt.
1589
1590         Windows build references non-existent include paths
1591         https://bugs.webkit.org/show_bug.cgi?id=34175
1592
1593         * DumpRenderTree/win/DumpRenderTree.vcproj:
1594         * DumpRenderTree/win/ImageDiff.vcproj:
1595         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1596
1597 2010-01-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1598
1599         Reviewed by Ariya Hidayat.
1600
1601         [Qt] Separating out the UrlLoader from the QtLauncher in it's
1602         own implementation and header file.
1603
1604         * QtLauncher/main.cpp:
1605         (main):
1606         * QtLauncher/urlloader.cpp: Added.
1607         (UrlLoader::UrlLoader):
1608         (UrlLoader::loadNext):
1609         (UrlLoader::init):
1610         (UrlLoader::getUrl):
1611         * QtLauncher/urlloader.h: Added.
1612
1613 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
1614
1615         Reviewed by Shinichiro Hamaji.
1616
1617         Refactored check-webkit-style by removing the file path
1618         parameter from the style error handler functions.
1619
1620         https://bugs.webkit.org/show_bug.cgi?id=34031
1621
1622         * Scripts/webkitpy/style/checker.py:
1623           - Added _default_style_error_handler() to StyleChecker class.
1624           - Moved handle_style_error() to inside _default_style_error_handler().
1625
1626         * Scripts/webkitpy/style/checker_unittest.py:
1627           - Removed file path from calls to error handler.
1628
1629         * Scripts/webkitpy/style/cpp_style.py:
1630           - Removed file path from calls to error handler.
1631
1632         * Scripts/webkitpy/style/cpp_style_unittest.py:
1633           - Removed file path from calls to error handler.
1634
1635         * Scripts/webkitpy/style/text_style.py:
1636           - Removed file path from calls to error handler.
1637
1638         * Scripts/webkitpy/style/text_style_unittest.py:
1639           - Removed file path from calls to error handler.
1640
1641 2010-01-25  Jeremy Orlow  <jorlow@chromium.org>
1642
1643         Adding myself as reviewer.  No review necessary.
1644
1645         * Scripts/webkitpy/committers.py:
1646
1647 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
1648
1649         Reviewed by Adam Barth.
1650
1651         Improved prepare-ChangeLog so that it preserves the relative
1652         indentation of a git commit message.
1653
1654         https://bugs.webkit.org/show_bug.cgi?id=34058
1655
1656         * Scripts/prepare-ChangeLog:
1657           - Also adjusted the script so that it does not add white
1658             space characters to empty lines.
1659
1660 2010-01-24  Eric Seidel  <eric@webkit.org>
1661
1662         No review, rolling out r53763.
1663         http://trac.webkit.org/changeset/53763
1664         https://bugs.webkit.org/show_bug.cgi?id=33895
1665
1666         Broke 20+ tests on Windows.
1667
1668         * Scripts/run-webkit-tests:
1669         * Scripts/webkitdirs.pm:
1670
1671 2010-01-24  Adam Barth  <abarth@webkit.org>
1672
1673         Rubber stamped by Eric Seidel.
1674
1675         More pep8 compliance.
1676
1677         * Scripts/webkitpy/mock_bugzillatool.py:
1678
1679 2010-01-24  Adam Barth  <abarth@webkit.org>
1680
1681         Rubber stamped by Eric Seidel.
1682
1683         More pep8 compliance.
1684
1685         * Scripts/webkitpy/executive.py:
1686         * Scripts/webkitpy/grammar.py:
1687
1688 2010-01-24  Adam Barth  <abarth@webkit.org>
1689
1690         Rubber stamped by Eric Seidel.
1691
1692         More pep8 compliance.
1693
1694         * Scripts/webkitpy/comments.py:
1695         * Scripts/webkitpy/committers.py:
1696         * Scripts/webkitpy/credentials.py:
1697
1698 2010-01-24  Adam Barth  <abarth@webkit.org>
1699
1700         Rubber stamped by Eric Seidel.
1701
1702         Make changelogs.py pass pep8.
1703
1704         * Scripts/webkitpy/changelogs.py:
1705
1706 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1707
1708         [Qt] Unreviewed build fix
1709
1710         * QtLauncher/QtLauncher.pro:
1711         * QtLauncher/webinspector.h:
1712
1713 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1714
1715         Rubberstamped by Simon Hausmann.
1716
1717         [Qt] Move the WebInspector class to it's own header file.
1718
1719         * QtLauncher/main.cpp:
1720         * QtLauncher/webinspector.h: Added.
1721         (WebInspector::WebInspector):
1722         (WebInspector::showEvent):
1723         (WebInspector::hideEvent):
1724
1725 2010-01-23  Robert Hogan  <robert@roberthogan.net>
1726
1727         Reviewed by Kenneth Rohde Christiansen.
1728
1729         Qt DRT: respect window.close() and window.closed()
1730         
1731         Qt DRT needs to maintain a correct count of open windows
1732         for windowCount(). It also needs to delete windows that
1733         have been closed by window.close().
1734         
1735         This fixes the following tests:
1736         
1737         plugins/destroy-during-npp-new.html
1738         fast/dom/Document/early-document-access.html
1739         fast/dom/Window/window-early-properties.html
1740         fast/events/open-window-from-another-frame.html
1741         fast/events/popup-blocking-click-in-iframe.html
1742         
1743         https://bugs.webkit.org/show_bug.cgi?id=32953
1744
1745         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1746         (WebCore::DumpRenderTree::DumpRenderTree):
1747         (WebCore::DumpRenderTree::createWindow):
1748         (WebCore::DumpRenderTree::windowCloseRequested):
1749         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1750         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1751         (LayoutTestController::maybeDump):
1752
1753 2010-01-23  Dan Bernstein  <mitz@apple.com>
1754
1755         Reviewed by Mark Rowe.
1756
1757         Added a user default for specifying a fallback frameworks path in case
1758         the bundle does not contain frameworks for the current Mac OS X version.
1759
1760         * WebKitLauncher/main.m:
1761         (fallbackMacOSXVersion): Added. Looks up the fallback version in a dictionary
1762         keyed by the FallbackSystemVersions user default and returns it.
1763         (main): If a frameworks directory for the current system version is not found,
1764         try the fallback.
1765
1766 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1767
1768         Reviewed by Simon Hausmann.
1769
1770         Make run-webkit-tests work under Cygwin for the Qt port
1771
1772         setPathForRunningWebKitApp() is implemented for the Qt port
1773         by using qmake to query for the location of the Qt libraries.
1774
1775         This requires the original environment (%ENV) to be untouched,
1776         so launchWithCurrentEnv() was refactored to launchWithEnv(),
1777         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
1778         instead. This has the added benefit of getting rid of the temp
1779         variables used for storing the current env.
1780
1781         openDumpTool() is also refactored a bit into platform-spesific,
1782         port-spesific, and generic environment variables.
1783
1784         Checks for undef was added a few places to fix Perl concat
1785         warnings when run-webkit-tests is aborted.
1786
1787         https://bugs.webkit.org/show_bug.cgi?id=33895
1788
1789         * Scripts/run-webkit-tests:
1790         * Scripts/webkitdirs.pm:
1791
1792 2010-01-22  Kevin Watters  <kevinwatters@gmail.com>
1793
1794         Reviewed by Kevin Ollivier.
1795
1796         [wx] Remove the Bakefile build system, which is no longer being used.
1797         
1798         https://bugs.webkit.org/show_bug.cgi?id=34022
1799
1800         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
1801         * wx/browser/browser.bkl: Removed.
1802         * wx/build-wxwebkit: Removed.
1803
1804 2010-01-22  Gustavo Noronha Silva  <gns@gnome.org>
1805
1806         Reviewed by Simon Fraser.
1807
1808         Reset zoom level to 1.0 when resetting view state. This is causing
1809         many tests to fail after svg/custom/text-zoom.xhtml changes the
1810         zoom level.
1811
1812         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1813         (resetDefaultsToConsistentValues):
1814
1815 2010-01-22  Steve Falkenburg  <sfalken@apple.com>
1816
1817         Reviewed by Darin Adler.
1818
1819         https://bugs.webkit.org/show_bug.cgi?id=34025
1820         Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.
1821
1822         * Scripts/build-webkit:
1823
1824 2010-01-22  Adam Barth  <abarth@webkit.org>
1825
1826         Unreviewed.  Arg.  Someone renamed limit to output_limit on me.
1827
1828         * Scripts/webkitpy/commands/queues.py:
1829
1830 2010-01-22  Adam Barth  <abarth@webkit.org>
1831
1832         Rubber stamped by Eric Seidel.
1833
1834         Make __init__.py and buildbot.py pass pep8 style checker.
1835
1836         * Scripts/webkitpy/__init__.py:
1837         * Scripts/webkitpy/buildbot.py:
1838
1839 2010-01-21  Joe Mason  <jmason@rim.com>
1840
1841         Reviewed by Adam Barth.
1842
1843         webkit-patch should retry on invalid password
1844         https://bugs.webkit.org/show_bug.cgi?id=33955
1845
1846         Ask for bugs.webkit.org authentication in a loop.
1847
1848         * Scripts/webkitpy/bugzilla.py:
1849
1850 2010-01-22  Adam Barth  <abarth@webkit.org>
1851
1852         Unreviewed.  Don't call seek on a NoneType.
1853
1854         * Scripts/webkitpy/statusserver.py:
1855
1856 2010-01-22  Petri Latvala  <petri.latvala@nomovok.com>
1857
1858         Reviewed by David Levin.
1859
1860         check-webkit-style breaks on files with unknown types
1861         https://bugs.webkit.org/show_bug.cgi?id=34001
1862
1863         For files with type FileType.NONE, dispatch_processor returns None.
1864
1865         * Scripts/webkitpy/style/checker.py: Don't call process_file with a processor of value None.
1866
1867 2010-01-22  Adam Barth  <abarth@webkit.org>
1868
1869         Reviewed by Eric Seidel.
1870
1871         Make bugzilla.py and webkitport.py conform to pep8
1872         https://bugs.webkit.org/show_bug.cgi?id=34015
1873
1874         This patch makes webkitport.py and bugzilla.py mostly conform to PEP8
1875         style as enforced by pep8.py.  I wasn't able to get rid of all the
1876         errors because I'm not sure how to wrap some lines properly.  Also,
1877         there are a few deprication errors that I couldn't resolve easily.
1878         However, this is a massive improvement in compliance.
1879
1880         * Scripts/webkitpy/bugzilla.py:
1881         * Scripts/webkitpy/webkitport.py:
1882
1883 2010-01-22  Adam Barth  <abarth@webkit.org>
1884
1885         Reviewed by Darin Adler.
1886
1887         Limit length of EWS results to 5MB
1888         https://bugs.webkit.org/show_bug.cgi?id=34016
1889
1890         Hopefully this will fix the bug where the results link doesn't appear.
1891         Our current theory is that the results blob is too big and the server
1892         is rejecting the request with a 500 error.  That causes us to re-try
1893         the post, but when we re-try the StringIO buffer has its seek pointer
1894         at the end.
1895
1896         * Scripts/webkitpy/commands/queues.py:
1897         * Scripts/webkitpy/statusserver.py:
1898
1899 2010-01-22  Chris Jerdonek  <cjerdonek@webkit.org>
1900
1901         Reviewed by Adam Barth.
1902
1903         Made check-webkit-style able to check patches when script not
1904         run from source root. Also consolidated external references
1905         to a single file.
1906
1907         https://bugs.webkit.org/show_bug.cgi?id=33791
1908
1909         * Scripts/check-webkit-style:
1910           - Changed to import style_references.py.
1911
1912         * Scripts/webkitpy/style/__init__.py:
1913           - Removed __path__ hack that allowed searching Scripts/ directory.
1914
1915         * Scripts/webkitpy/style/checker.py:
1916           - Changed to import style_references.py.
1917
1918         * Scripts/webkitpy/style_references.py: Added.
1919
1920 2010-01-22  Dmitry Titov  <dimich@chromium.org>
1921
1922         Reviewed by Maciej Stachowiak.
1923
1924         Fix the leak of ThreadIdentifiers in threadMap across threads.
1925         https://bugs.webkit.org/show_bug.cgi?id=32689
1926
1927         Add a new test to verify the ThreadIdentifiers are not reused across threads.
1928         The test runs in the beginning of DumpRenderTree and spawns 2 non-WTF treads sequentially,
1929         waiting for the previous thread to terminate before starting the next.
1930         The treads use WTF::currentThread() in their thread function. Without a fix, this
1931         causes both threads to have the same ThreadIdentifier which triggers ASSERT in thread function.
1932         It also starts another thread using WTF. Without the fix, this finds pthread handle from previous
1933         threads in the WTF threadMap and asserts in WTF::establishIdentifierForPthreadHandle().
1934         The test practically does not affect the DRT run time because the threads end immediately.
1935
1936         * DumpRenderTree/mac/DumpRenderTree.mm:
1937         (runThread): Test thread function.
1938         (testThreadIdentifierMap):
1939         (dumpRenderTree):
1940
1941 2010-01-22  Kent Tamura  <tkent@chromium.org>
1942
1943         Reviewed by Maciej Stachowiak.
1944
1945         Fix a bug that mouseDown:withModifiers: is never called.
1946         https://bugs.webkit.org/show_bug.cgi?id=33989
1947
1948         * DumpRenderTree/mac/EventSendingController.mm:
1949         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1950         (+[EventSendingController webScriptNameForSelector:]):
1951
1952 2010-01-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1953
1954         Rubberstamped by Antti Koivisto.
1955
1956         [Qt] Separate out the WebPage class into it's own
1957         cpp/header files. Also, removed the assumption that
1958         the view is a QWebView, in preparation of a merger
1959         of the two Qt WebKit launchers.
1960
1961         * QtLauncher/QtLauncher.pro:
1962         * QtLauncher/main.cpp:
1963         (WebView::mousePressEvent):
1964         * QtLauncher/webpage.cpp: Added.
1965         (WebPage::supportsExtension):
1966         (WebPage::extension):
1967         (WebPage::acceptNavigationRequest):
1968         (WebPage::openUrlInDefaultBrowser):
1969         * QtLauncher/webpage.h: Added.
1970         (WebPage::WebPage):
1971
1972 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
1973
1974         Reviewed by Shinichiro Hamaji.
1975
1976         Refactored to move file name and file-reading related code
1977         from cpp_style.py and text_style.py to checker.py.
1978
1979         https://bugs.webkit.org/show_bug.cgi?id=33775
1980
1981         * Scripts/check-webkit-style:
1982           - Updates caused by changes to checker.py.
1983
1984         * Scripts/webkitpy/style/checker.py:
1985           - Added SKIPPED_FILES_WITH_WARNING list.
1986           - Added SKIPPED_FILES_WITHOUT_WARNING list.
1987           - Added FileType class.
1988           - Added ProcessorDispatcher class.
1989           - In StyleChecker class:
1990             - Renamed process_patch() to check_patch().
1991             - Renamed process_file() to check_file().
1992             - Added _process_file().
1993             - Related refactoring.
1994             - Addressed check_patch() FIXME to share code with process_file().
1995
1996         * Scripts/webkitpy/style/checker_unittest.py:
1997           - Added ProcessorDispatcherSkipTest class.
1998           - Added ProcessorDispatcherDispatchTest class.
1999           - Added StyleCheckerCheckFileTest class.
2000
2001         * Scripts/webkitpy/style/cpp_style.py:
2002           - Renamed process_file_data() to _process_lines.
2003           - Removed process_file() (moved logic to checker.py).
2004           - Removed can_handle() (moved logic to checker.py).
2005           - Added CppProcessor class.
2006           - Removed is_exempt() (moved logic to checker.py).
2007           - Added process_file_data() back as a wrapper function.
2008
2009         * Scripts/webkitpy/style/cpp_style_unittest.py:
2010           - Removed test_can_handle().
2011           - Removed test_is_exempt().
2012           - Added CppProcessorTest class.
2013
2014         * Scripts/webkitpy/style/text_style.py:
2015           - Added TextProcessor class.
2016           - Removed process_file().
2017           - Removed can_handle().
2018
2019         * Scripts/webkitpy/style/text_style_unittest.py:
2020           - Removed test_can_handle().
2021           - Added TextProcessorTest class.
2022
2023 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
2024
2025         Reviewed by David Kilzer.
2026
2027         Create a unit-tested subroutine to parse patch files created
2028         by svn-create-patch.
2029
2030         https://bugs.webkit.org/show_bug.cgi?id=33475
2031
2032         * Scripts/VCSUtils.pm:
2033           - Added parseDiff().
2034           - Added parsePatch().
2035
2036         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Added.
2037           - Added unit tests for parseDiff().
2038
2039         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
2040           - Total number of tests now computed dynamically.
2041
2042         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl: Added.
2043           - Added unit tests for parsePatch().
2044
2045 2010-01-21  Kevin Ollivier  <kevino@theolliviers.com>
2046
2047         [wx] Build fix, add new directory to dir list.
2048
2049         * wx/build/settings.py:
2050
2051 2010-01-21  Adam Barth  <abarth@webkit.org>
2052
2053         Reviewed by Eric Seidel.
2054
2055         Make the EWS transactional
2056         https://bugs.webkit.org/show_bug.cgi?id=33978
2057
2058         Now if the EWS gets interrupted in the middle of processing a patch,
2059         the bots will re-process the patch.
2060
2061         * Scripts/test-webkitpy:
2062         * Scripts/webkitpy/commands/queues.py:
2063         * Scripts/webkitpy/commands/queues_unittest.py:
2064         * Scripts/webkitpy/patchcollection.py:
2065         * Scripts/webkitpy/patchcollection_unittest.py: Added.
2066
2067 2010-01-21  Adam Barth  <abarth@webkit.org>
2068
2069         Unreviewed.  Add missing "ago" for style in the status bubble.
2070
2071         * QueueStatusServer/templates/statusbubble.html:
2072
2073 2010-01-21  Adam Barth  <abarth@webkit.org>
2074
2075         Reviewed by David Levin.
2076
2077         [style-queue] should not complain about identifier names with underscores under WebKit/gtk/webkit/
2078         https://bugs.webkit.org/show_bug.cgi?id=33356
2079
2080         White list unix_hacker_style names in WebKit/gtk/webkit because these
2081         are used in the GTK+ API.
2082
2083         * Scripts/webkitpy/style/cpp_style.py:
2084         * Scripts/webkitpy/style/cpp_style_unittest.py:
2085
2086 2010-01-21  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2087
2088         Reviewed by Kenneth Rohde Christiansen.
2089
2090         [Qt] add setDomainRelaxationForbiddenForURLScheme in Qt DRT
2091         https://bugs.webkit.org/show_bug.cgi?id=33945
2092
2093         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2094         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2095         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2096
2097 2010-01-21  Simon Hausmann  <simon.hausmann@nokia.com>
2098
2099         No review, rolling out 53615 as it causes two
2100         crashes on the bot.
2101
2102         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2103         (WebCore::DumpRenderTree::DumpRenderTree):
2104         (WebCore::DumpRenderTree::createWindow):
2105         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2106         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2107         (LayoutTestController::maybeDump):
2108
2109 2010-01-21  Robert Hogan  <robert@roberthogan.net>
2110
2111         Reviewed by Simon Hausmann.
2112
2113         Qt DRT: respect window.close() and window.closed()
2114
2115         Qt DRT needs to maintain a correct count of open windows
2116         for windowCount(). It also needs to delete windows that
2117         have been closed by window.close().
2118
2119         This fixes the following tests:
2120
2121         plugins/destroy-during-npp-new.html
2122         fast/dom/Document/early-document-access.html
2123         fast/dom/Window/window-early-properties.html
2124         fast/events/open-window-from-another-frame.html
2125         fast/events/popup-blocking-click-in-iframe.html
2126
2127         https://bugs.webkit.org/show_bug.cgi?id=32953
2128
2129         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2130         (WebCore::DumpRenderTree::DumpRenderTree):
2131         (WebCore::DumpRenderTree::createWindow):
2132         (WebCore::DumpRenderTree::windowCloseRequested):
2133         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2134         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2135         (LayoutTestController::maybeDump):
2136
2137 2010-01-20  Eric Seidel  <eric@webkit.org>
2138
2139         No review, rolling out r53593.
2140         http://trac.webkit.org/changeset/53593
2141         https://bugs.webkit.org/show_bug.cgi?id=33496
2142
2143         Re-rollout this patch, the commit-queue should not have landed
2144         it again, but it did due to land-diff and rollout both not
2145         clearing flags.
2146
2147         * Scripts/webkitpy/commands/early_warning_system.py:
2148         * Scripts/webkitpy/commands/queues.py:
2149         * Scripts/webkitpy/queueengine.py:
2150         * Scripts/webkitpy/scm.py:
2151         * Scripts/webkitpy/scm_unittest.py:
2152
2153 2010-01-20  Eric Seidel  <eric@webkit.org>
2154
2155         Reviewed by Adam Barth.
2156
2157         webkit-commit-queue status page is confusing
2158         https://bugs.webkit.org/show_bug.cgi?id=33496
2159
2160         This should improve the status page by removing more Fail messages.
2161         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
2162         to behave more like one another.  This meant moving where the failure reporting was done.
2163         Previously the AbstractReviewQueue always used the parent process to report the error,
2164         while CommitQueue used the subprocess when possible, and the parent only reported errors
2165         that we didn't know how to handle (bugs in the commit-queue itself).
2166         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
2167         in both implementations and required teaching handle_script_error in each to post Fail messages
2168         to the status server instead of calling exit(1).
2169
2170         This will also make the style-queue share more bug posting logic with other queues:
2171         https://bugs.webkit.org/show_bug.cgi?id=33871
2172
2173         * Scripts/webkitpy/commands/early_warning_system.py:
2174          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
2175            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
2176            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
2177            _update_status_for_script_error knows how to post the Fail message to the status server.
2178          - Teach _update_status_for_script_error how to post Fail messages to the status server.
2179         * Scripts/webkitpy/commands/queues.py:
2180          - Remove the try block from process_work_item since the caller already has one.
2181          - Only CC watchers on failure to cut down on commit-queue generated mail.
2182          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
2183          - Abstract _format_script_error_output_for_bug to share code between all queues.
2184          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
2185          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
2186          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
2187          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
2188         * Scripts/webkitpy/queueengine.py:
2189          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
2190         * Scripts/webkitpy/scm.py:
2191          - Add new checkout_revision function.
2192         * Scripts/webkitpy/scm_unittest.py:
2193          - Test our new checkout_revision function.
2194
2195 2010-01-20  Fumitoshi Ukai  <ukai@chromium.org>
2196
2197         Reviewed by Alexey Proskuryakov.
2198
2199         WebSocket: Missing Request-URI, when no tralling slash in host
2200         https://bugs.webkit.org/show_bug.cgi?id=33689
2201
2202         Update pywebsocket to 0.4.7.1, which supports alias for resource
2203         name, so that we could test for ws://127.0.0.1:8880
2204
2205         * Scripts/run-webkit-tests:
2206         * Scripts/run-webkit-websocketserver:
2207         * pywebsocket/mod_pywebsocket/dispatch.py:
2208         * pywebsocket/mod_pywebsocket/handshake.py:
2209         * pywebsocket/mod_pywebsocket/standalone.py:
2210         * pywebsocket/setup.py:
2211         * pywebsocket/test/test_dispatch.py:
2212         * pywebsocket/test/test_handshake.py:
2213
2214 2010-01-20  Eric Seidel  <eric@webkit.org>
2215
2216         No review, rolling out r53537.
2217         http://trac.webkit.org/changeset/53537
2218         https://bugs.webkit.org/show_bug.cgi?id=33496
2219
2220         Added a failure condition to the commit-queue and looks to
2221         have broken the EWS bots
2222
2223         * Scripts/webkitpy/commands/early_warning_system.py:
2224         * Scripts/webkitpy/commands/queues.py:
2225         * Scripts/webkitpy/queueengine.py:
2226         * Scripts/webkitpy/scm.py:
2227         * Scripts/webkitpy/scm_unittest.py:
2228
2229 2010-01-20  Jon Honeycutt  <jhoneycutt@apple.com>
2230
2231         MSAA: accSelect() is not implemented
2232
2233         https://bugs.webkit.org/show_bug.cgi?id=33918
2234         <rdar://problem/7436861>
2235
2236         Reviewed by Darin Adler.
2237
2238         * DumpRenderTree/AccessibilityUIElement.cpp:
2239         (takeFocusCallback):
2240         Call the object's takeFocus() function.
2241         (takeSelectionCallback):
2242         Call its takeSelection() function.
2243         (addSelectionCallback):
2244         Call its addSelection() function.
2245         (removeSelectionCallback):
2246         Call its removeSelection() function.
2247         (AccessibilityUIElement::getJSClass):
2248         Add new functions to the JS class definition.
2249
2250         * DumpRenderTree/AccessibilityUIElement.h:
2251         Declare new functions.
2252
2253         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2254         (AccessibilityUIElement::takeFocus):
2255         Stubbed.
2256         (AccessibilityUIElement::takeSelection):
2257         Stubbed.
2258         (AccessibilityUIElement::addSelection):
2259         Stubbed.
2260         (AccessibilityUIElement::removeSelection):
2261         Stubbed.
2262
2263         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2264         (AccessibilityUIElement::takeFocus):
2265         Stubbed.
2266         (AccessibilityUIElement::takeSelection):
2267         Stubbed.
2268         (AccessibilityUIElement::addSelection):
2269         Stubbed.
2270         (AccessibilityUIElement::removeSelection):
2271         Stubbed.
2272
2273         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2274         (AccessibilityUIElement::takeFocus):
2275         Call the object's accSelect() function, passing the appropriate flag.
2276         (AccessibilityUIElement::takeSelection):
2277         Ditto.
2278         (AccessibilityUIElement::addSelection):
2279         Ditto.
2280         (AccessibilityUIElement::removeSelection):
2281         Ditto.
2282
2283 2010-01-20  Andras Becsi  <abecsi@inf.u-szeged.hu>
2284
2285         Reviewed by Alexey Proskuryakov.
2286
2287         Extract Apache handling to httpd.pm module and use the provided functionality
2288         in scripts where Apache is needed.
2289         The module httpd.pm stores the PID of Apache in a variable and cleans up
2290         the PID directory after Apache properly shut down. Catching INT and TERM
2291         signals allows the scripts to close Apache and clean up its PID directory
2292         even if the testing was interrupted.
2293
2294         https://bugs.webkit.org/show_bug.cgi?id=33153
2295
2296         * Scripts/webkitperl/httpd.pm: Added.
2297         * Scripts/run-iexploder-tests:
2298         * Scripts/run-webkit-httpd:
2299         * Scripts/run-webkit-tests:
2300
2301 2010-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2302
2303         Reviewed by Simon Hausmann.
2304
2305         [Qt] Make DumpRenderTree build on Windows
2306
2307         * DumpRenderTree/qt/DumpRenderTree.pro:
2308         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2309         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2310         * DumpRenderTree/qt/main.cpp:
2311
2312 2010-01-20  Steve Block  <steveblock@google.com>
2313
2314         Reviewed by Eric Seidel.
2315
2316         Fix commit bot to land patches in order of the bug last modification date.
2317         https://bugs.webkit.org/show_bug.cgi?id=33395
2318
2319         * Scripts/webkitpy/bugzilla.py: Modified. Added 'order=Last+Changed' to bugzilla commit queue URL.
2320
2321 2010-01-20  Adam Barth  <abarth@webkit.org>
2322
2323         Reviewed by Eric Seidel.
2324
2325         Teach check-webkit-style about WebKit/gtk/tests
2326         https://bugs.webkit.org/show_bug.cgi?id=33892
2327
2328         Removes false positives found in
2329         https://bugs.webkit.org/show_bug.cgi?id=30883
2330
2331         * Scripts/webkitpy/style/cpp_style.py:
2332         * Scripts/webkitpy/style/cpp_style_unittest.py:
2333
2334 2010-01-20  Adam Barth  <abarth@webkit.org>
2335
2336         Reviewed by Eric Seidel.
2337
2338         Teach check-webkit-style about QGVLauncher
2339         https://bugs.webkit.org/show_bug.cgi?id=33890
2340
2341         Remove false positives found in
2342         https://bugs.webkit.org/show_bug.cgi?id=33708
2343
2344         * Scripts/webkitpy/style/cpp_style.py:
2345         * Scripts/webkitpy/style/cpp_style_unittest.py:
2346
2347 2010-01-20  Eric Seidel  <eric@webkit.org>
2348
2349         Reviewed by Adam Barth.
2350
2351         webkit-commit-queue status page is confusing
2352         https://bugs.webkit.org/show_bug.cgi?id=33496
2353
2354         This should improve the status page by removing more Fail messages.
2355         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
2356         to behave more like one another.  This meant moving where the failure reporting was done.
2357         Previously the AbstractReviewQueue always used the parent process to report the error,
2358         while CommitQueue used the subprocess when possible, and the parent only reported errors
2359         that we didn't know how to handle (bugs in the commit-queue itself).
2360         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
2361         in both implementations and required teaching handle_script_error in each to post Fail messages
2362         to the status server instead of calling exit(1).
2363
2364         This will also make the style-queue share more bug posting logic with other queues:
2365         https://bugs.webkit.org/show_bug.cgi?id=33871
2366
2367         * Scripts/webkitpy/commands/early_warning_system.py:
2368          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
2369            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
2370            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
2371            _update_status_for_script_error knows how to post the Fail message to the status server.
2372          - Teach _update_status_for_script_error how to post Fail messages to the status server.
2373         * Scripts/webkitpy/commands/queues.py:
2374          - Remove the try block from process_work_item since the caller already has one.
2375          - Only CC watchers on failure to cut down on commit-queue generated mail.
2376          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
2377          - Abstract _format_script_error_output_for_bug to share code between all queues.
2378          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
2379          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
2380          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
2381          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
2382         * Scripts/webkitpy/queueengine.py:
2383          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
2384         * Scripts/webkitpy/scm.py:
2385          - Add new checkout_revision function.
2386         * Scripts/webkitpy/scm_unittest.py:
2387          - Test our new checkout_revision function.
2388
2389 2010-01-20  Adam Barth  <abarth@webkit.org>
2390
2391         Reviewed by Darin Adler.
2392
2393         Exempt JavaScriptCore/qt/api from style checks
2394         https://bugs.webkit.org/show_bug.cgi?id=33879
2395
2396         Apparently there is a JavaScriptCore API for Qt as well as a WebKit
2397         API.
2398
2399         * Scripts/webkitpy/style/cpp_style.py:
2400         * Scripts/webkitpy/style/cpp_style_unittest.py:
2401
2402 2010-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2403
2404         Reviewed by Simon Hausmann.
2405
2406         [Qt] Don't use QSocketNotifier in the DRT for reading stdin
2407
2408         QSocketNotifier is not available on Windows. Instead we read
2409         stdin synchronously after each test using signals and slots.
2410
2411         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2412         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2413         * DumpRenderTree/qt/main.cpp:
2414
2415 2010-01-19  Adam Barth  <abarth@webkit.org>
2416
2417         Rubber stamped by Eric Seidel.
2418
2419         Move chromium-ews back to building release only to make the EWS faster.
2420
2421         * Scripts/webkitpy/commands/early_warning_system.py:
2422
2423 2010-01-17  Jon Honeycutt  <jhoneycutt@apple.com>
2424
2425         MSAA: The child <option> elements of a non-multiple <select> are not
2426         exposed
2427
2428         https://bugs.webkit.org/show_bug.cgi?id=33773
2429         <rdar://problem/7550556>
2430
2431         Reviewed by Alice Liu.
2432
2433         * DumpRenderTree/AccessibilityUIElement.cpp:
2434         (getIsVisibleCallback):
2435         Call the object's isVisible() function.
2436         (getIsOffScreenCallback):
2437         Ditto, for isOffScreen().
2438         (getIsCollapsedCallback):
2439         Ditto, for isCollapsed().
2440         (getHasPopupCallback):
2441         Ditto, for hasPopup().
2442         (AccessibilityUIElement::getJSClass):
2443         Add isVisible and isOffScreen attributes.
2444
2445         * DumpRenderTree/AccessibilityUIElement.h:
2446         Declare new functions.
2447
2448         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2449         (AccessibilityUIElement::isVisible):
2450         Stubbed.
2451         (AccessibilityUIElement::isOffScreen):
2452         Stubbed.
2453         (AccessibilityUIElement::isCollapsed):
2454         Stubbed.
2455         (AccessibilityUIElement::hasPopup):
2456         Stubbed.
2457
2458         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2459         (AccessibilityUIElement::isVisible):
2460         Stubbed.
2461         (AccessibilityUIElement::isOffScreen):
2462         Stubbed.
2463         (AccessibilityUIElement::isCollapsed):
2464         Stubbed.
2465         (AccessibilityUIElement::hasPopup):
2466         Stubbed.
2467
2468         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2469         (AccessibilityUIElement::showMenu):
2470         Call the object's accDoDefaultAction() to show its popup menu.
2471         (AccessibilityUIElement::isEnabled):
2472         Check that the object does not have the "unavailable" state.
2473         (AccessibilityUIElement::isVisible):
2474         Check that the object does not have the "invisible" state.
2475         (AccessibilityUIElement::isOffScreen):
2476         Check whether the object has the "offscreen" state.
2477         (AccessibilityUIElement::isCollapsed):
2478         Check whether the object has the "collapsed" state.
2479         (AccessibilityUIElement::hasPopup):
2480         Check whether the object has the "has popup" state.
2481
2482 2010-01-19  Victor Wang  <victorw@chromium.org>
2483
2484         Reviewed by Eric Seidel.
2485
2486         Correct committer name.
2487         https://bugs.webkit.org/show_bug.cgi?id=33868
2488
2489         * Scripts/webkitpy/committers.py:
2490
2491 2010-01-19  Kent Tamura  <tkent@chromium.org>
2492
2493         Reviewed by Darin Adler.
2494
2495         [DRT][Mac] Add modifiers parameter to eventSender.mouseDown() and eventSender.mouseUp()
2496         https://bugs.webkit.org/show_bug.cgi?id=33783
2497
2498         Some listbox tests check selection behavior by click events with
2499         "meta" or "shift" keys. Behaviors for such modifier keys are
2500         platform-dependent. The new parameter of mouseDown() and mouseUp()
2501         allows to specify not only concrete modifier keys such as
2502         "shiftKey" "metaKey", but also functional names like
2503         "addSelectionKey" "rangeSelectionKey".
2504
2505         * DumpRenderTree/mac/EventSendingController.mm:
2506         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2507         (+[EventSendingController webScriptNameForSelector:]):
2508         (buildModifierFlags):
2509         (-[EventSendingController mouseDown:withModifiers:]):
2510         (-[EventSendingController mouseDown:]):
2511         (-[EventSendingController mouseUp:withModifiers:]):
2512         (-[EventSendingController mouseUp:]):
2513         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2514
2515 2010-01-19  Adam Barth  <abarth@webkit.org>
2516
2517         Reviewed by Eric Seidel.
2518
2519         Unbreak --request-commit
2520         https://bugs.webkit.org/show_bug.cgi?id=33832
2521
2522         * Scripts/webkitpy/bugzilla.py:
2523
2524 2010-01-19  Eric Seidel  <eric@webkit.org>
2525
2526         Reviewed by Adam Barth.
2527
2528         validate-committer-lists throws exception and committers.py needs a refresh
2529         https://bugs.webkit.org/show_bug.cgi?id=33831
2530
2531         * Scripts/validate-committer-lists: use webkit_logging
2532         * Scripts/webkitpy/committers.py: Add recently minted committers.  Fix Simon Hausmanns email address list to include his webkit-committers@lists address.
2533
2534 2010-01-18  Adam Roben  <aroben@apple.com>
2535
2536         Add LayoutTestController support for calling new WebKit SPI to
2537         disallow setting document.domain
2538
2539         DRT part of fixing <http://webkit.org/b/33806>
2540         <rdar://problem/7552837> Would like API to disallow setting of
2541         document.domain for pages with certain URL schemes
2542
2543         Reviewed by Sam Weinig.
2544
2545         * DumpRenderTree/LayoutTestController.cpp:
2546         (setDomainRelaxationForbiddenForURLSchemeCallback): Added. Calls
2547         through to LayoutTestController.
2548         (LayoutTestController::staticFunctions): Added
2549         setDomainRelaxationForbiddenForURLScheme.
2550
2551         * DumpRenderTree/LayoutTestController.h: Added
2552         setDomainRelaxationForbiddenForURLScheme.
2553
2554         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2555         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2556         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2557         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2558         Added. Calls through to WebKit.
2559
2560         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2561         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2562         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2563         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
2564         Stubbed out.
2565
2566 2010-01-18  Adam Barth  <abarth@webkit.org>
2567
2568         Reviewed by Adam Roben.
2569
2570         Rename patches-to-commit to patches-in-commit-queue
2571         https://bugs.webkit.org/show_bug.cgi?id=33789
2572
2573         The command really lists the patches in the commit-queue not all the
2574         patches that are pending-commit (as the FIXME commands).
2575
2576         * Scripts/webkitpy/commands/queries.py:
2577         * Scripts/webkitpy/commands/queries_unittest.py:
2578
2579 2010-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2580
2581         Reviewed by Simon Hausmann.
2582
2583         [Qt] Force qmake to generate a single makefile for DerivedSources.pro
2584
2585         * Scripts/webkitdirs.pm:
2586
2587 2010-01-18  Adam Roben  <aroben@apple.com>
2588
2589         Clean up use of /useenv when invoking Visual C++
2590
2591         This change reverts things to their pre-r49485 state. That revision
2592         (and, subsequently, r49664 and r51788) started passing /useenv to
2593         Visual C++, even in cases where we don't want to do so (such as when
2594         invoking Visual C++ Express), in the name of making the Chromium build
2595         work. Now that Chromium isn't using buildVisualStudioProject or
2596         pdevenv, we can put things back they way they were.
2597
2598         Fixes <http://webkit.org/b/33797> build-webkit fails with VC++ Express
2599         (due to /useenv flag)
2600
2601         Reviewed by Sam Weinig.
2602
2603         * Scripts/pdevenv: Always pass /useenv. Chromium doesn't use this
2604         script anymore.
2605         * Scripts/webkitdirs.pm:
2606         (buildVisualStudioProject): Never pass /useenv anymore. pdevenv takes
2607         care of this itself, and we don't want to pass /useenv when not using
2608         pdevenv (e.g., when using VC++ Express, because that will cause it to
2609         ignore the Platform SDK).
2610
2611 2010-01-18  Adam Barth  <abarth@webkit.org>
2612
2613         Reviewed by Eric Seidel.
2614
2615         webkit-patch land-safely should obsolete old patches
2616         https://bugs.webkit.org/show_bug.cgi?id=33788
2617
2618         When posting a commit-queue+ patch with land-safely, we should
2619         obsolete the old patches on the bug.  They're really confusing
2620         because the main use case is to address reviewer feedback on a
2621         previous patch.
2622
2623         * Scripts/webkitpy/commands/upload.py:
2624         * Scripts/webkitpy/commands/upload_unittest.py:
2625
2626 2010-01-18  Adam Barth  <abarth@webkit.org>
2627
2628         Reviewed by David Levin.
2629
2630         webkit-patch should authenticate more often
2631         https://bugs.webkit.org/show_bug.cgi?id=33701
2632
2633         This makes it easier to work with security patches.
2634
2635         * Scripts/webkitpy/bugzilla.py:
2636
2637 2010-01-18  Adam Barth  <abarth@webkit.org>
2638
2639         Reviewed by Darin Adler.
2640
2641         style checker needs to know about GObject-specific requirements
2642         inside WebCore/bindings/gobject/
2643         https://bugs.webkit.org/show_bug.cgi?id=33606
2644
2645         Add an exception to the underscore rule for certain
2646         GObject-specific names.
2647
2648         * Scripts/webkitpy/style/cpp_style.py:
2649         * Scripts/webkitpy/style/cpp_style_unittest.py:
2650
2651 2010-01-18  Adam Barth  <abarth@webkit.org>
2652
2653         Reviewed by Shinichiro Hamaji.
2654
2655         [check-webkit-style] does understand ResourceHandleWin.h
2656         https://bugs.webkit.org/show_bug.cgi?id=32975
2657
2658         I'm not 100% convinced this fix is correct, but without more examples,
2659         it's hard to generalize.  We can always generalize the fix in the
2660         future.
2661
2662         * Scripts/webkitpy/style/cpp_style.py:
2663         * Scripts/webkitpy/style/cpp_style_unittest.py:
2664
2665 2010-01-18  Adam Barth  <abarth@webkit.org>
2666
2667         Unreviewed "build" fix.
2668
2669         * Scripts/webkitpy/bugzilla.py:
2670
2671 2010-01-18  Adam Barth  <abarth@webkit.org>
2672
2673         Unreviewed.  Actually make land-safely mark commit-queue+ as
2674         discussed with Eric.
2675
2676         * Scripts/webkitpy/bugzilla.py:
2677         * Scripts/webkitpy/steps/postdiffforcommit.py:
2678
2679 2010-01-17  Adam Barth  <abarth@webkit.org>
2680
2681         Reviewed by Darin Adler.
2682
2683         style-queue complains about one-line macros that include multiple statements
2684         https://bugs.webkit.org/show_bug.cgi?id=33173
2685
2686         Add an exception for multiple statements on a line that starts a macro.
2687
2688         * Scripts/webkitpy/style/cpp_style.py:
2689         * Scripts/webkitpy/style/cpp_style_unittest.py:
2690
2691 2010-01-17  Adam Barth  <abarth@webkit.org>
2692
2693         Reviewed by Darin Adler.
2694
2695         [check-webkit-style] qt unit testing false positives
2696         https://bugs.webkit.org/show_bug.cgi?id=32833
2697
2698         Exempt the Qt API and unit tests from the style checker.
2699
2700         * Scripts/webkitpy/style/cpp_style.py:
2701         * Scripts/webkitpy/style/cpp_style_unittest.py:
2702
2703 2010-01-17  Adam Barth  <abarth@webkit.org>
2704
2705         Reviewed by Darin Adler.
2706
2707         style-check script reports loads of errors on gtk2drawing.c
2708         https://bugs.webkit.org/show_bug.cgi?id=33771
2709
2710         Exempt WebCore/platform/gtk/gtk2drawing.c and
2711         WebCore/platform/gtk/gtk2drawing.h from style checks.
2712
2713         * Scripts/webkitpy/style/cpp_style.py:
2714         * Scripts/webkitpy/style/cpp_style_unittest.py:
2715
2716 2010-01-17  Chris Jerdonek  <cjerdonek@webkit.org>
2717
2718         Reviewed by Shinichiro Hamaji.
2719
2720         Finished eliminating _cpp_style_state global state variable from
2721         check-webkit-style code and eliminating _CppStyleState class.
2722
2723         https://bugs.webkit.org/show_bug.cgi?id=33764
2724
2725         * Scripts/webkitpy/style/checker.py:
2726           - Minor updates caused by changes to cpp_style.py.
2727
2728         * Scripts/webkitpy/style/cpp_style.py:
2729           - Removed _CppStyleState class.
2730           - Removed verbose_level functions.
2731           - Added verbosity as a parameter to _FunctionState constructor.
2732           - Added verbosity as a parameter to process_file().
2733           - Added verbosity as a parameter to process_file_data().
2734
2735         * Scripts/webkitpy/style/cpp_style_unittest.py:
2736           - Added helper functions to set verbosity while running tests.
2737
2738 2010-01-17  Adam Barth  <abarth@webkit.org>
2739
2740         Reviewed by Shinichiro Hamaji.
2741
2742         check-webkit-style underscore check should be disabled for Qt methods starting with qt_
2743         https://bugs.webkit.org/show_bug.cgi?id=33663
2744
2745         * Scripts/webkitpy/style/cpp_style.py:
2746         * Scripts/webkitpy/style/cpp_style_unittest.py:
2747
2748 2010-01-17  Adam Barth  <abarth@webkit.org>
2749
2750         Reviewed by Eric Seidel.
2751
2752         style-queue complains about missing #include of config.h for non-WebCore projects
2753         https://bugs.webkit.org/show_bug.cgi?id=33170
2754
2755         WebKitAPITests are consumers of the WebKit API and therefore do not
2756         need to follow the same include discipline as the rest of WebKit.  This
2757         patch exempts them from the include checks.
2758
2759         * Scripts/webkitpy/style/cpp_style.py:
2760         * Scripts/webkitpy/style/cpp_style_unittest.py:
2761
2762 2010-01-17  Adam Barth  <abarth@webkit.org>
2763
2764         Reviewed by Eric Seidel.
2765
2766         EWS (Early Warning Systems) should build both debug and release
2767         https://bugs.webkit.org/show_bug.cgi?id=33681
2768
2769         Build both debug and release for chromium-ews.
2770
2771         * Scripts/webkitpy/commands/early_warning_system.py:
2772
2773 2010-01-17  Adam Barth  <abarth@webkit.org>
2774
2775         Reviewed by Darin Adler.
2776
2777         style-queue should include instructions for how to file bugs against check-webkit-style
2778         https://bugs.webkit.org/show_bug.cgi?id=32345
2779
2780         Added some text to the error message asking folks to file bugs against
2781         false positives.
2782
2783         * Scripts/webkitpy/commands/queues.py:
2784
2785 2010-01-17  Chris Jerdonek  <cjerdonek@webkit.org>
2786
2787         Reviewed by Adam Barth.
2788
2789         Eliminated the error_count global variable and related
2790         check-webkit-style refactoring.
2791
2792         https://bugs.webkit.org/show_bug.cgi?id=33678
2793
2794         * Scripts/check-webkit-style:
2795           - Updated to use webkit_argument_defaults().
2796           - Renamed styleChecker to style_checker.
2797
2798         * Scripts/webkitpy/style/checker.py:
2799           - Prefixed the three default arguments with WEBKIT_DEFAULT.
2800           - Added webkit_argument_defaults().
2801           - Added default filter_rules parameter to CategoryFilter constructor.
2802           - Added __ne__() to CategoryFilter class.
2803           - Added __eq__() and __ne__() to ProcessorOptions class.
2804           - Added error_count and _write_error attributes to StyleChecker class.
2805           - Made StyleChecker._handle_error() increment the error count.
2806
2807         * Scripts/webkitpy/style/checker_unittest.py:
2808           - Improved CategoryFilterTest.test_eq().
2809           - Added CategoryFilterTest.test_ne().
2810           - Added test_eq() and test_ne() to ProcessorOptionsTest class.
2811           - Updated unit tests to use webkit_argument_defaults().
2812           - Added StyleCheckerTest class.
2813
2814         * Scripts/webkitpy/style/cpp_style.py:
2815           - Removed references to global error_count.
2816
2817         * Scripts/webkitpy/style/cpp_style_unittest.py:
2818           - Removed CppStyleStateTest class.
2819
2820 2010-01-15  Jon Honeycutt  <jhoneycutt@apple.com>
2821
2822         get_accParent should try to retrieve parent AccessibilityObject, before
2823         calling upon window
2824
2825         https://bugs.webkit.org/show_bug.cgi?id=22893
2826
2827         Reviewed by Darin Adler.
2828
2829         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2830         (AccessibilityUIElement::parentElement):
2831         Get the object's parent. Query it for IAccessible, and return it.
2832
2833 2010-01-16  Dan Bernstein  <mitz@apple.com>
2834
2835         Reviewed by Mark Rowe.
2836
2837         <rdar://problem/7529519> DumpRenderTree crashes in makeLargeMallocFailSilently()
2838
2839         * DumpRenderTree/mac/CheckedMalloc.cpp:
2840         (makeLargeMallocFailSilently): Temporarily allow writing to the default
2841         malloc zone structure while modifying it.
2842
2843 2010-01-16  David Kilzer  <ddkilzer@apple.com>
2844
2845         Added back removed properties to iExploder input files
2846
2847         While the update-iexploder-cssproperties script works great to
2848         add new properties, it has the side-effect of removing old
2849         properties that once were parsed.
2850
2851         * iExploder/htdocs/cssproperties.in: Added back removed
2852         properties into their own section.
2853         * iExploder/htdocs/htmlattrs.in: Ditto.
2854
2855 2010-01-16  Holger Hans Peter Freyther  <zecke@selfish.org>
2856
2857         Reviewed by David Kilzer.
2858
2859         Update iExploder/htdocs/*.in by running update-iexploder-cssproperties 
2860         https://bugs.webkit.org/show_bug.cgi?id=33756
2861
2862         * iExploder/htdocs/cssproperties.in: New CSS attributes
2863         * iExploder/htdocs/htmlattrs.in: New HTML attributes
2864         * iExploder/htdocs/htmltags.in: New HTML tags
2865
2866 2010-01-15  Chris Jerdonek  <chris.jerdonek@gmail.com>
2867
2868         Reviewed by David Kilzer.
2869
2870         Altered parseDiffHeader() to skip unrecognized lines and
2871         other minor clean-ups.
2872
2873         https://bugs.webkit.org/show_bug.cgi?id=33476
2874
2875         * Scripts/VCSUtils.pm:
2876           - Changed parseDiffHeader() as follows:
2877             - Skips over unrecognized lines.
2878             - Addressed FIXME to remove substitution for "diff" line.
2879             - Renamed "version" header hash key to "sourceRevision".
2880             - Eliminated "copiedFromVersion" header hash key.
2881             - Included "sourceRevision" also for copied files.
2882             - Checks that copy revision number matches "sourceRevision".
2883             - No longer returns $foundHeaderEnding.
2884             - Dies if header ending not found.
2885             - Diff header dividing line now always added.
2886
2887         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
2888           - Made necessary changes in parseDiffHeader() unit tests.
2889           - Shortened the file paths in some test cases.
2890
2891 2010-01-14  Yuzo Fujishima  <yuzo@google.com>
2892
2893         Reviewed by Alexey Proskuryakov.
2894
2895         Update pywebsocket to 0.4.6
2896         https://bugs.webkit.org/show_bug.cgi?id=32299
2897         The newer pywebsocket can handle more simultaneous connections.
2898
2899         * pywebsocket/mod_pywebsocket/handshake.py:
2900         * pywebsocket/mod_pywebsocket/standalone.py:
2901         * pywebsocket/setup.py:
2902         * pywebsocket/test/test_handshake.py:
2903
2904 2010-01-14  Eric Seidel  <eric@webkit.org>
2905
2906         Reviewed by Adam Barth.
2907
2908         REGRESSION(53133): commit-queue no longer rejects patches with invalid committers, instead it hangs
2909         https://bugs.webkit.org/show_bug.cgi?id=33638
2910
2911         * Scripts/webkitpy/bugzilla.py:
2912          - Add Bug.id() to match Attachment.id()
2913          - Give Bug.reviewed_patches and commit_queued_patches the option to return patches with invalid committers/reviewers.
2914          - Add back a missing variable to _validate_setter_email found by the new unit tests!
2915         * Scripts/webkitpy/commands/queries.py:
2916          - Add FIXMEs about the commands being confusingly named.
2917         * Scripts/webkitpy/commands/queries_unittest.py:
2918          - Update results to reflect the newly restructured mock bug cache.
2919         * Scripts/webkitpy/commands/queues.py:
2920          - Add a new _validate_patches_in_commit_queue method (this is what fixes the regression).
2921          - Add a FIXME about eventually sorting the patches into some order.
2922         * Scripts/webkitpy/commands/queues_unittest.py:
2923          - Update results now that with the newly restructure mock bug cache we're testing cq+'d patches with an invalid committer.
2924         * Scripts/webkitpy/commands/upload_unittest.py:
2925          - Update results to match the newly restructured mock bug cache.
2926         * Scripts/webkitpy/mock_bugzillatool.py:
2927          - Restructure fetch_ methods to not use a manual list of ids, but rather use Bug and Attachment classes to make real queries from all of the Bugs.
2928          - Add a few more attachments and bug dictionaries for use by the tests.
2929
2930 2010-01-13  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2931
2932         Reviewed by Kenneth Christiansen.
2933
2934         [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
2935         https://bugs.webkit.org/show_bug.cgi?id=33617
2936
2937         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2938         (WebCore::WebPage::resetSettings):
2939         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2940         (LayoutTestController::setUserStyleSheetLocation):
2941         (LayoutTestController::setUserStyleSheetEnabled):
2942         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2943
2944 2010-01-14  Adam Roben  <aroben@apple.com>
2945
2946         Add LayoutTestController API to force
2947         -webView:resource:willSendRequest:: to return null
2948
2949         Enables tests for <rdar://problem/7533333> <http://webkit.org/b/33533>
2950         window.onload never fires if page contains an <iframe> with a bad
2951         scheme or whose load is cancelled by returning null from resource load
2952         delegate's willSendRequest
2953
2954         Reviewed by Brady Eidson.
2955
2956         * DumpRenderTree/LayoutTestController.cpp:
2957         (LayoutTestController::LayoutTestController): Initialize new member.
2958         (setWillSendRequestReturnsNullCallback): Call through to
2959         LayoutTestController.
2960         (LayoutTestController::staticFunctions): Added new function.
2961
2962         * DumpRenderTree/LayoutTestController.h: Added
2963         m_willSendRequestReturnsNull.
2964         (LayoutTestController::willSendRequestReturnsNull):
2965         (LayoutTestController::setWillSendRequestReturnsNull):
2966         Added standard accessors.
2967
2968         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2969         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2970         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2971         (ResourceLoadDelegate::willSendRequest):
2972         Return null if LayoutTestController says to.
2973
2974 2010-01-14  Kevin Ollivier  <kevino@theolliviers.com>
2975
2976         [wx] Build fix after removal of XBM support.
2977
2978         * wx/build/settings.py:
2979
2980 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2981
2982         Reviewed by Simon Hausmann.
2983
2984         Add support for partial building on Symbian.
2985
2986         The build happens in the source directory as out of source builds are
2987         not supported by qmake for Symbian.
2988
2989         Also the actual build isn't started but it is left to the developer
2990         to choose the architecture/configuration.
2991
2992         * Scripts/webkitdirs.pm:
2993
2994 2010-01-14  Simon Hausmann  <simon.hausmann@nokia.com>
2995
2996         Reviewed by Kenneth Rohde Christiansen.
2997
2998         Add support for "detecting" Symbian environments by either
2999         looking for the EPOCROOT environment variable or via --symbian
3000         being passed on the commandline.
3001
3002         * Scripts/webkitdirs.pm:
3003
3004 2010-01-14  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3005
3006         Unreviewed.
3007
3008         [Qt] Use a different Makefile names for sources generation and compilation.
3009         This prevents Makefile overwriting when running build-webkit twice.
3010
3011         * Scripts/webkitdirs.pm:
3012
3013 2010-01-14  Andreas Kling  <andreas.kling@nokia.com>
3014
3015         Reviewed by Kenneth Rohde Christiansen.
3016
3017         [Qt] Add an "alien_QLabel" classId for manual testing of alien widgets.
3018
3019         https://bugs.webkit.org/show_bug.cgi?id=33373
3020
3021         * QtLauncher/main.cpp:
3022         (WebPage::createPlugin):
3023
3024 2010-01-14  Eric Seidel  <eric@webkit.org>
3025
3026         No review, rolling out r53249.
3027         http://trac.webkit.org/changeset/53249
3028         https://bugs.webkit.org/show_bug.cgi?id=33617
3029
3030         This caused http/tests/security/local-user-CSS-from-
3031         remote.html to fail on the Qt Release Build Bot.
3032
3033         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3034         (WebCore::WebPage::resetSettings):
3035         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3036         (LayoutTestController::overridePreference):
3037         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3038
3039 2010-01-14  Chris Jerdonek  <chris.jerdonek@gmail.com>
3040
3041         Reviewed by Shinichiro Hamaji.
3042
3043         Moved error() from cpp_style.py to checker.py.
3044
3045         https://bugs.webkit.org/show_bug.cgi?id=33620
3046
3047         * Scripts/check-webkit-style:
3048           - Addressed FIXME to not set global state.
3049
3050         * Scripts/webkitpy/style/checker.py:
3051           - Added argument validation to ProcessorOptions constructor.
3052           - Added should_report_error() to ProcessorOptions class.
3053           - Removed set_options().
3054           - Added StyleChecker class.
3055
3056         * Scripts/webkitpy/style/checker_unittest.py:
3057           - Added unit test class for ProcessorOptions class.
3058           - Added unit test to check that parse() strips white space.
3059
3060         * Scripts/webkitpy/style/cpp_style.py:
3061           - Removed "filter" and "output_format" methods.
3062           - Removed should_print_error() and error() functions.
3063           - Removed default parameter value from process_file().
3064
3065         * Scripts/webkitpy/style/cpp_style_unittest.py:
3066           - Removed call to cpp_style._should_print_error().
3067           - Removed test_filter() and test_filter_appending().
3068
3069         * Scripts/webkitpy/style/text_style.py:
3070           - Removed default parameter value from process_file().
3071
3072 2010-01-14  Diego Gonzalez  <diego.gonzalez@openbossa.org>
3073
3074         Reviewed by Kenneth Rohde Christiansen.
3075
3076         [Qt] DRT missing setUserStyleSheetLocation and setUserStyleSheetEnabled in LayoutTestController
3077         https://bugs.webkit.org/show_bug.cgi?id=33617
3078
3079         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3080         (WebCore::WebPage::resetSettings):
3081         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3082         (LayoutTestController::setUserStyleSheetLocation):
3083         (LayoutTestController::setUserStyleSheetEnabled):
3084         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3085
3086 2010-01-13  Adam Barth  <abarth@webkit.org>
3087
3088         Reviewed by Eric Seidel.
3089
3090         Fix CloseBugForLandDiff unittest to actually run
3091         https://bugs.webkit.org/show_bug.cgi?id=33640
3092
3093         * Scripts/webkitpy/mock_bugzillatool.py:
3094         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py:
3095
3096 2010-01-12  Jon Honeycutt  <jhoneycutt@apple.com>
3097
3098         MSAA: selected, selectable, extended selectable, and multiple
3099         selectable states are not reported
3100
3101         https://bugs.webkit.org/show_bug.cgi?id=33574
3102         <rdar://problem/7536826>
3103
3104         Reviewed by Darin Adler.
3105
3106         * DumpRenderTree/AccessibilityUIElement.cpp:
3107         (getIsSelectableCallback):
3108         Return the result of calling isSelectable().
3109         (getIsMultiSelectableCallback):
3110         Return the result of calling isMultiSelectable().
3111         (AccessibilityUIElement::getJSClass):
3112         Add isSelected and isMultiSelectable properties to the JSClass
3113         definition.
3114
3115         * DumpRenderTree/AccessibilityUIElement.h:
3116         Declare isSelectable() and isMultiSelectable().
3117
3118         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3119         (AccessibilityUIElement::isSelectable):
3120         Stubbed.
3121         (AccessibilityUIElement::isMultiSelectable):
3122         Stubbed.
3123
3124         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3125         (AccessibilityUIElement::isSelectable):
3126         Stubbed.
3127         (AccessibilityUIElement::isMultiSelectable):
3128         Stubbed.
3129
3130         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3131         (accessibilityState):
3132         Get the object's state, and return it.
3133         (AccessibilityUIElement::isSelected):
3134         Check the object's selected state.
3135         (AccessibilityUIElement::isSelectable):
3136         Check the object's selectable state.
3137         (AccessibilityUIElement::isMultiSelectable):
3138         Check the object's extended/multiple selectable state.
3139
3140 2010-01-13  Adam Barth  <abarth@webkit.org>
3141
3142         Unreviewed.  Repeat the below for CloseBugForLandDiff.
3143
3144         * Scripts/test-webkitpy:
3145         * Scripts/webkitpy/steps/closebugforlanddiff.py:
3146         * Scripts/webkitpy/steps/closebugforlanddiff_unittest.py: Added.
3147
3148 2010-01-13  Adam Barth  <abarth@webkit.org>
3149
3150         Unreviewed.  Turn the mac-ews status bubbles back on now that this bot
3151         is running again.
3152
3153         * QueueStatusServer/templates/statusbubble.html:
3154
3155 2010-01-13  Adam Barth  <abarth@webkit.org>
3156
3157         Reviewed by Darin Adler.
3158
3159         REGRESSION(53133): webkit-patch land dies if it can't find a bug id.
3160         https://bugs.webkit.org/show_bug.cgi?id=33634
3161
3162         Deal with the case of no bug patch object in the state.
3163
3164         * Scripts/webkitpy/steps/updatechangelogswithreview_unittests.py:
3165         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py:
3166
3167 2010-01-13  Kenneth Russell  <kbr@google.com>
3168
3169         Unreviewed; added myself to the committers list.
3170
3171         * Scripts/webkitpy/committers.py:
3172
3173 2010-01-13  Darin Adler  <darin@apple.com>
3174
3175         Ignore compiled Python in more of webkitpy.
3176
3177         * Scripts/webkitpy/commands: Added property svn:ignore.
3178         * Scripts/webkitpy/steps: Added property svn:ignore.
3179         * Scripts/webkitpy/style: Added property svn:ignore.
3180
3181 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3182
3183         Reviewed by Simon Hausmann.
3184
3185         [Qt] Fix build problem related to the pushd command
3186
3187         * Scripts/webkitdirs.pm:
3188
3189 2010-01-13  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3190
3191         Reviewed by Simon Hausmann.
3192
3193         [Qt] Split the build process in two different .pro files.
3194         This allows qmake to be run once all source files are available.
3195
3196         * Scripts/webkitdirs.pm: Add calls to make DerivedSources.pro in JSC and WC.
3197
3198 2010-01-13  Shinichiro Hamaji  <hamaji@chromium.org>
3199
3200         Unreviewed tiny typo fix in docstrings.
3201
3202         * Scripts/webkitpy/style/checker_unittest.py:
3203
3204 2010-01-13  Chris Jerdonek  <chris.jerdonek@gmail.com>
3205
3206         Reviewed by Shinichiro Hamaji.
3207
3208         Created a CategoryFilter class to encapsulate the logic of
3209         filter rules.
3210
3211         https://bugs.webkit.org/show_bug.cgi?id=33454
3212
3213         * Scripts/webkitpy/style/checker.py:
3214           - Added CategoryFilter class.
3215
3216         * Scripts/webkitpy/style/checker_unittest.py:
3217           - Added CategoryFilter unit tests.
3218
3219         * Scripts/webkitpy/style/cpp_style.py:
3220           - Updated filter methods to use CategoryFilter.
3221
3222         * Scripts/webkitpy/style/cpp_style_unittest.py:
3223           - Updated references to filters.
3224
3225 2010-01-12  Shinichiro Hamaji  <hamaji@chromium.org>
3226
3227         Unreviewed. Now I can review :)
3228
3229         * Scripts/webkitpy/committers.py:
3230
3231 2010-01-12  Brent Fulgham  <bfulgham@webkit.org>
3232
3233         Reviewed by Darin Adler.
3234
3235         Extend WinLauncher example with better printing features.
3236
3237         * WinLauncher/PrintWebUIDelegate.cpp:
3238         (PrintWebUIDelegate::webViewPrintingMarginRect): Provide slightly
3239          larger margins.
3240         (PrintWebUIDelegate::webViewHeaderHeight): Compute header height based
3241          on text metrics.
3242         (PrintWebUIDelegate::webViewFooterHeight): Compute footer height based
3243          on text metrics.
3244         (PrintWebUIDelegate::drawHeaderInRect): Write useful header, along
3245          with separating line.
3246         (PrintWebUIDelegate::drawFooterInRect):
3247         * WinLauncher/PrintWebUIDelegate.h: Remove stubs.
3248         * WinLauncher/WinLauncher.cpp:
3249         (PrintView): Correct loop used to print individual pages.
3250          Previously it started at 0, which is a wild-card to print all
3251          pages at once.
3252
3253 2010-01-12  Alexey Proskuryakov  <ap@apple.com>
3254
3255         Reviewed by Darin Adler.
3256
3257         https://bugs.webkit.org/show_bug.cgi?id=33540
3258         Make it possible to build in debug mode with assertions disabled
3259
3260         * DumpRenderTree/mac/ObjCController.m: (-[ObjCController accessStoredWebScriptObject]):
3261
3262 2010-01-11  Darin Fisher  <darin@chromium.org>
3263
3264         Reviewed by Dimitri Glazkov.
3265
3266         [Chromium] "build-webkit --chromium" should run "make all" on Linux
3267         https://bugs.webkit.org/show_bug.cgi?id=33500
3268
3269         * Scripts/webkitdirs.pm:
3270
3271 2010-01-12  Eric Seidel  <eric@webkit.org>
3272
3273         Reviewed by Adam Barth.
3274
3275         AssignToCommitter does not need to fetch bugs twice
3276         https://bugs.webkit.org/show_bug.cgi?id=33530
3277
3278         This is a no-brainer patch now that we've added Bug.reviewed_patches
3279
3280         * Scripts/webkitpy/commands/upload.py:
3281
3282 2010-01-12  Eric Seidel  <eric@webkit.org>
3283
3284         Reviewed by Adam Barth.
3285
3286         bugzilla.py should have an Attachment object instead of passing around dictionaries
3287         https://bugs.webkit.org/show_bug.cgi?id=31594
3288
3289         * Scripts/webkitpy/bugzilla.py:
3290          - Add a new Attachment class, with accessor methods for all the necessary properties.
3291          - Update Bug to carry a pointer back to bugzilla (attachments need to access Bugzilla for committer validation and url())
3292          - Move reviewed_patches and commit_queued_patches out of Bugzilla custom methods and onto Bug
3293          - Move committer validation logic into its own class.
3294          - Committer rejection is only used in one place.  Make the new Bug reviewed_patches and commit_queued_patches
3295            handle the common case (of returning "reviewer" or "committer" as None), and let CommitterValidation handle
3296            the case where we want to reject patches in bugzilla.
3297          - Simplify fetch_patches_from_commit_queue now that committer validation is simpler.
3298          - Make all self.bugzilla.fetch_bug access go through BugzillaQueries._fetch_bug.
3299          - Mark set_flag_on_attachment as non-private to denote that CommitterValidation depends on it.
3300          - Move fetch_reviewed_patches_from_bug and fetch_commit_queue_patches_from_bug logic onto the Bug class.
3301         * Scripts/webkitpy/bugzilla_unittest.py:
3302          - Move test_flag_permission_rejection_message into a new CommitterValidationTest class.
3303         * Scripts/webkitpy/commands/download.py:
3304          - Store "bug_id" in state instead of making a fake patch object.
3305          - Update to use Attachment and Bug objects.
3306         * Scripts/webkitpy/commands/download_unittest.py:
3307          - Update expected results now that our testing framework covers more code.
3308         * Scripts/webkitpy/commands/early_warning_system.py: Update to use new Attachment class.
3309         * Scripts/webkitpy/commands/queries.py: Remove unused ReviewedPatches class.
3310         * Scripts/webkitpy/commands/queries_unittest.py: ditto.
3311         * Scripts/webkitpy/commands/queues.py: Update to use new Attachment and CommitterValidator classes.
3312         * Scripts/webkitpy/commands/queuestest.py: ditto.
3313         * Scripts/webkitpy/commands/upload.py: ditto.
3314         * Scripts/webkitpy/mock_bugzillatool.py:
3315          - Now that more logic has moved into Attachment and Bug, we have to actually
3316            provide real reviewer emails as well as real reviewer flags.
3317          - Update mock methods to return Attachment objects.
3318         * Scripts/webkitpy/scm.py: Update to use Attachment class.
3319         * Scripts/webkitpy/scm_unittest.py: Update to use Attachment class.
3320         * Scripts/webkitpy/statusserver.py: ditto.
3321         * Scripts/webkitpy/steps/applypatch.py: ditto.
3322         * Scripts/webkitpy/steps/applypatchwithlocalcommit.py: ditto.
3323         * Scripts/webkitpy/steps/closebug.py: ditto.
3324         * Scripts/webkitpy/steps/closebugforlanddiff.py: Handle either state["bug_id"] or state["patch"].bug_id()
3325         * Scripts/webkitpy/steps/closepatch.py: Update to use Attachment class.
3326         * Scripts/webkitpy/steps/obsoletepatches.py: ditto.
3327         * Scripts/webkitpy/steps/updatechangelogswithreviewer.py: ditto.
3328
3329 2010-01-12  Adam Barth  <abarth@webkit.org>
3330
3331         Unreviewed typo fix.  :(
3332
3333         * Scripts/webkitpy/commands/early_warning_system.py:
3334         * Scripts/webkitpy/commands/queues.py:
3335
3336 2010-01-12  Adam Barth  <abarth@webkit.org>
3337
3338         Unreviewed.  Add "error" to the right part of the message.
3339
3340         * Scripts/webkitpy/commands/queues.py:
3341
3342 2010-01-12  Adam Barth  <abarth@webkit.org>
3343
3344         Reviewed by Eric Seidel.
3345
3346         EWS should show purple when svn-apply fails
3347         https://bugs.webkit.org/show_bug.cgi?id=33527
3348
3349         * Scripts/webkitpy/commands/early_warning_system.py:
3350         * Scripts/webkitpy/commands/queues.py:
3351
3352 2010-01-12  Adam Barth  <abarth@webkit.org>
3353
3354         Reviewed by Eric Seidel.
3355
3356         Remove copy/paste code from subclasses of AbstractReviewQueue
3357         https://bugs.webkit.org/show_bug.cgi?id=33525
3358
3359         * Scripts/webkitpy/commands/early_warning_system.py:
3360         * Scripts/webkitpy/commands/queues.py:
3361
3362 2010-01-12  Adam Barth  <abarth@webkit.org>
3363
3364         Reviewed by Eric Seidel.
3365
3366         Add Gustavo and Xan as gtk-ews watchers
3367         https://bugs.webkit.org/show_bug.cgi?id=33519
3368
3369         * Scripts/webkitpy/commands/early_warning_system.py:
3370
3371 2010-01-12  Adam Barth  <abarth@webkit.org>
3372
3373         Reviewed by Eric Seidel.
3374
3375         webkit-patch shouldn't waste my time for with a component prompt
3376         https://bugs.webkit.org/show_bug.cgi?id=33521
3377
3378         The component field isn't very useful for bugs created with
3379         webkit-patch because they're likely to be resolved quickly.  Instead of
3380         always prompting for a component, we should just default to the "New
3381         Bugs" component.  If the bug stays around for more than five minutes,
3382         we can assign it a proper component.
3383
3384         * Scripts/webkitpy/bugzilla.py:
3385
3386 2010-01-12  Adam Barth  <abarth@webkit.org>
3387
3388         Reviewed by Eric Seidel.
3389
3390         Add experimental "land-safely" command to webkit-patch
3391         https://bugs.webkit.org/show_bug.cgi?id=33518
3392
3393         * Scripts/webkitpy/commands/upload.py:
3394         * Scripts/webkitpy/commands/upload_unittest.py:
3395         * Scripts/webkitpy/steps/__init__.py:
3396         * Scripts/webkitpy/steps/postdiffforcommit.py: Added.
3397
3398 2010-01-11  Kevin Ollivier  <kevino@theolliviers.com>
3399
3400         [wx] Build fix after introduction of JS_NO_EXPORT
3401         
3402         * wx/build/settings.py:
3403
3404 2010-01-11  Eric Seidel  <eric@webkit.org>
3405
3406         No review, rolling out r53079.
3407         http://trac.webkit.org/changeset/53079
3408         https://bugs.webkit.org/show_bug.cgi?id=33197
3409
3410         Adam doens't think this actually works, and believe it caused
3411         a regression https://bugs.webkit.org/show_bug.cgi?id=33488 so
3412         rolling this out.
3413
3414         * Scripts/test-webkitpy:
3415         * Scripts/webkitpy/commands/abstractdiffcommand.py: Removed.
3416         * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Removed.
3417         * Scripts/webkitpy/commands/download.py:
3418         * Scripts/webkitpy/commands/upload.py:
3419         * Scripts/webkitpy/mock_bugzillatool.py:
3420
3421 2010-01-10  Adam Barth  <abarth@webkit.org>
3422
3423         Reviewed by David Kilzer.
3424
3425         bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
3426         https://bugs.webkit.org/show_bug.cgi?id=33197
3427
3428         We should just search for bug numbers in the ChangeLogs instead of in
3429         the whole diff.
3430  
3431         * Scripts/test-webkitpy:
3432         * Scripts/webkitpy/commands/abstractdiffcommand.py: Added.
3433         * Scripts/webkitpy/commands/abstractdiffcommand_unittest.py: Added.
3434         * Scripts/webkitpy/commands/download.py:
3435         * Scripts/webkitpy/commands/upload.py:
3436         * Scripts/webkitpy/mock_bugzillatool.py:
3437
3438 2010-01-11  Chris Jerdonek  <chris.jerdonek@gmail.com>
3439
3440         Reviewed by David Kilzer.
3441
3442         Created a unit-tested function to parse the header block of
3443         a Git or SVN diff -- for future refactoring of svn-apply and
3444         svn-unapply.
3445
3446         https://bugs.webkit.org/show_bug.cgi?id=33447
3447
3448         * Scripts/VCSUtils.pm:
3449           - Added parseDiffHeader().
3450           - Removed irrelevant comment from gitdiff2svndiff().
3451
3452         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl: Added.
3453           - Added 48 unit tests for parseDiffHeader().
3454
3455 2010-01-10  Adam Barth  <abarth@webkit.org>
3456
3457         Rubber stamped by David Kilzer.
3458
3459         bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files
3460         https://bugs.webkit.org/show_bug.cgi?id=33197
3461
3462         Fix a typo: Commmand -> Command.
3463
3464         * Scripts/webkitpy/commands/abstractsequencedcommand.py:
3465         * Scripts/webkitpy/commands/download.py:
3466         * Scripts/webkitpy/commands/queries.py:
3467         * Scripts/webkitpy/commands/upload.py:
3468         * Scripts/webkitpy/multicommandtool.py:
3469
3470 2010-01-10  Adam Barth  <abarth@webkit.org>
3471
3472         Reviewed by Darin Adler.
3473
3474         Let webkit-patch work with options in $EDITOR
3475         https://bugs.webkit.org/show_bug.cgi?id=33414
3476
3477         The $EDITOR evironment variable might have command line options like
3478         bbedit -w.  This patch lets us run those $EDITORs.
3479
3480         * Scripts/webkitpy/user.py:
3481
3482 2010-01-10  Robert Hogan  <robert@roberthogan.net>
3483
3484         Reviewed by Adam Barth.
3485
3486         [Qt] Add enableXSSAuditor support to QWebSettings and DRT.
3487
3488         https://bugs.webkit.org/show_bug.cgi?id=33419
3489
3490         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3491         (WebCore::WebPage::WebPage):
3492         (WebCore::WebPage::resetSettings):
3493         (WebCore::DumpRenderTree::createWindow):
3494         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3495         (LayoutTestController::setXSSAuditorEnabled):
3496         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3497
3498 2010-01-10  Adam Barth  <abarth@webkit.org>
3499
3500         Unreviewed cosmetic change.  Remove the status bubble for mac-ews
3501         because we don't have hardware for it at the moment.
3502
3503         * QueueStatusServer/templates/statusbubble.html:
3504
3505 2010-01-09  Daniel Bates  <dbates@webkit.org>
3506
3507         No review, rolling out r53044.
3508         http://trac.webkit.org/changeset/53044
3509         https://bugs.webkit.org/show_bug.cgi?id=33419
3510         
3511         We need to look into this some more because the Qt
3512         bot is failing the XSSAuditor tests. See bug #33419
3513         for more details.
3514
3515         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3516         (WebCore::WebPage::WebPage):
3517         (WebCore::WebPage::resetSettings):
3518         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3519         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3520
3521 2010-01-09  Daniel Bates  <dbates@webkit.org>
3522
3523         Reviewed by Adam Barth.
3524
3525         https://bugs.webkit.org/show_bug.cgi?id=33419
3526
3527         Adds support for the XSSAuditor to the Qt DRT.
3528
3529         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3530         (WebCore::WebPage::WebPage):
3531         (WebCore::WebPage::resetSettings):
3532         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3533         (LayoutTestController::setXSSAuditorEnabled):
3534         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3535
3536 2010-01-09  Adam Barth  <abarth@webkit.org>
3537
3538         Reviewed by Eric Seidel.
3539
3540         Retry writes to QueueStatusServer when we get 500 errors
3541         https://bugs.webkit.org/show_bug.cgi?id=33412
3542
3543         This prevents the queues from failing to mark a patch as "pass" or
3544         "fail" when AppEngine throws 500 errors.
3545
3546         * Scripts/test-webkitpy:
3547         * Scripts/webkitpy/networktransaction.py: Added.
3548         * Scripts/webkitpy/networktransaction_unittest.py: Added.
3549         * Scripts/webkitpy/statusserver.py:
3550         * Scripts/webkitpy/steps/closebugformarkbugfixed.py: Added.
3551         * Scripts/webkitpy/steps/closebugregardlessofpatches.py: Added.
3552         * Scripts/webkitpy/steps/findbugidfromsvnrevision.py: Added.
3553
3554 2010-01-09  David Kilzer  <ddkilzer@apple.com>
3555
3556         <http://webkit.org/b/33430> Fix rounded borders in queue status on older Firefox and Safari browsers
3557
3558         Reviewed by Eric Seidel.
3559
3560         * QueueStatusServer/templates/statusbubble.html: Added
3561         -moz-border-radius and -webkit-border-radius to provide rounded
3562         borders in older Firefox and Safari browsers.
3563
3564 2010-01-09  Chris Jerdonek  <chris.jerdonek@gmail.com>
3565
3566         Reviewed by David Kilzer.
3567
3568         Modified VCSUtils::gitdiff2svndiff() to accept strings that
3569         end in vertical white space.
3570
3571         https://bugs.webkit.org/show_bug.cgi?id=33415
3572
3573         * Scripts/VCSUtils.pm:
3574         * Scripts/webkitperl/VCSUtils_unittest/gitdiff2svndiff.pl:
3575
3576 2010-01-08  Eric Seidel  <eric@webkit.org>
3577
3578         Reviewed by Adam Barth.
3579
3580         run-javascriptcore-tests needs a --quiet flag
3581         https://bugs.webkit.org/show_bug.cgi?id=33399
3582
3583         Until run-javascriptcore-tests has a --quiet flag, lets just stiffle the output in webkit-patch.
3584
3585         * Scripts/webkitpy/steps/runtests.py:
3586
3587 2010-01-08  Andras Becsi  <abecsi@inf.u-szeged.hu>
3588
3589         Reviewed by Alexey Proskuryakov.
3590
3591         Only run http and websocket tests as last if no argument is given to be able to explicitly control the test order.
3592
3593         To be able to run multiple instances of run-webkit-tests besides each other on the same machine we need to minimize
3594         the time when Apache and WebSocketServer is locked by tests.
3595         Because closeHTTPD() and closeWebSocketServer() is only called at the end of the testing,
3596         we need to run http and websocket tests after all other tests.
3597         If one however explicitly specifies the tests to run in the argument list of run-webkit-tests
3598         we need to preserve the given order.
3599
3600         * Scripts/run-webkit-tests:
3601
3602 2010-01-08  Adam Barth  <abarth@webkit.org>
3603
3604         Reviewed by Eric Seidel.
3605
3606         Don't post style-queue pass messages to bugs
3607         https://bugs.webkit.org/show_bug.cgi?id=33404
3608
3609         These messages aren't needed any more now that we have the status
3610         bubble reporting pass events passively.
3611
3612         * Scripts/webkitpy/commands/queues.py:
3613
3614 2010-01-08  Adam Barth  <abarth@webkit.org>
3615
3616         Reviewed by Eric Seidel.
3617
3618         Optimize the number of CPUs used for building Qt and Gtk
3619         https://bugs.webkit.org/show_bug.cgi?id=33394
3620
3621         Instead of hardcoding the number 8, we should read the number of CPUs
3622         from the environment.
3623
3624         * Scripts/webkitpy/executive.py:
3625         * Scripts/webkitpy/webkitport.py:
3626         * Scripts/webkitpy/webkitport_unittest.py:
3627
3628 2010-01-08  Chris Fleizach  <cfleizach@apple.com>
3629
3630         Reviewed by Eric Seidel.
3631
3632         REGRESSION(52819?): AXLoadComplete and AXLayoutComplete causes 4 tests fail on Snow Leopard Debug bot
3633         https://bugs.webkit.org/show_bug.cgi?id=33300
3634
3635         * DumpRenderTree/AccessibilityUIElement.h:
3636         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3637         (AccessibilityUIElement::AccessibilityUIElement):
3638         (AccessibilityUIElement::~AccessibilityUIElement):
3639         (_accessibilityNotificationCallback):
3640         (AccessibilityUIElement::addNotificationListener):
3641
3642 2010-01-08  Eric Seidel  <eric@webkit.org>
3643
3644         Reviewed by Simon Hausmann.
3645
3646         commit-queue should run run-javascriptcore-tests
3647         https://bugs.webkit.org/show_bug.cgi?id=33376
3648
3649         I also made it run the python and perl unit tests.
3650
3651         * Scripts/webkitpy/steps/runtests.py:
3652         * Scripts/webkitpy/webkitport.py:
3653
3654 2010-01-07  Andras Becsi  <abecsi@inf.u-szeged.hu>
3655
3656         Reviewed by Darin Adler.
3657
3658         Run the http and websocket tests after all other tests.
3659         https://bugs.webkit.org/show_bug.cgi?id=33153
3660
3661         * Scripts/run-webkit-tests:
3662
3663 2010-01-07  Adam Barth  <abarth@webkit.org>
3664
3665         Reviewed by Eric Seidel.
3666
3667         Fix some test-webkitpy expectations
3668         https://bugs.webkit.org/show_bug.cgi?id=33345
3669
3670         I forgot to change these when I added the CheckStyle step.
3671
3672         * Scripts/webkitpy/commands/upload_unittest.py:
3673
3674 2010-01-07  Adam Barth  <abarth@webkit.org>
3675
3676         Reviewed by Eric Seidel.
3677
3678         webkit-patch edit-changelogs (or upload) will open blank files if run outside the root
3679         https://bugs.webkit.org/show_bug.cgi?id=33341
3680
3681         Fix this by moving to the root directory before editing ChangeLogs.
3682         There is a related bug with CheckStyle.
3683
3684         * Scripts/webkitpy/steps/checkstyle.py:
3685         * Scripts/webkitpy/steps/editchangelog.py:
3686
3687 2010-01-07  Eric Seidel  <eric@webkit.org>
3688
3689         Reviewed by Nikolas Zimmermann.
3690
3691         media/unsupported-tracks.html is failing on Snow Leopard Release bot
3692         https://bugs.webkit.org/show_bug.cgi?id=32339
3693
3694         This is a speculative fix.  I do not have a Snow Leopard machine to test on
3695         and I've not seen mention of someone being able to reproduce this locally.
3696
3697         Prevent watchdog timer from firing after a test completes but before
3698         the next one starts, causing the error to appear in the next test.
3699
3700         * DumpRenderTree/mac/DumpRenderTree.mm:
3701         (dump): Stop the watchdog before printing #EOF for the test content.
3702         We only need to care about the JavaScript of the test running too long
3703         or some hang in WebCore.  Any other failures will be covered by the calling
3704         script's own watchdog timer.
3705
3706 2010-01-07  Eric Seidel  <eric@webkit.org>
3707
3708         Reviewed by Adam Barth.
3709
3710         commit-queue is stuck spinning due to exception
3711         https://bugs.webkit.org/show_bug.cgi?id=33358
3712
3713         * Scripts/webkitpy/commands/queues.py:
3714          - Don't try to stringify the exception.
3715
3716 2010-01-07  Mark Rowe  <mrowe@apple.com>
3717
3718         Reviewed by Jon Honeycutt.
3719
3720         Don't leak a JSStringRef within _accessibilityNotificationCallback.
3721
3722         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3723         (_accessibilityNotificationCallback): Have a JSRetainPtr adopt the JSStringRef so that it will be cleaned up
3724         when it goes out of scope.
3725
3726 2010-01-07  Simon Fraser  <simon.fraser@apple.com>
3727
3728         Reviewed by Darin Adler.
3729
3730         Add proposed rename of HTMLPlugInImageElement to HTMLEmbeddedObjectElement.
3731
3732         * Scripts/do-webcore-rename:
3733
3734 2010-01-07  Kim Grönholm  <kim.gronholm@nomovok.com>
3735
3736         Reviewed by Antti Koivisto.
3737
3738         Wrong state and TouchLists in TouchEvents
3739         https://bugs.webkit.org/show_bug.cgi?id=32878
3740
3741         * DumpRenderTree/qt/EventSenderQt.cpp:
3742         (EventSender::touchStart):
3743         (EventSender::touchEnd):
3744         (EventSender::clearTouchPoints):
3745         * DumpRenderTree/qt/EventSenderQt.h:
3746
3747 2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>
3748
3749         Reviewed by Adam Barth.
3750
3751         Created a module that runs the style package unit tests.
3752
3753         https://bugs.webkit.org/show_bug.cgi?id=32973
3754
3755         * Scripts/test-webkitpy:
3756         * Scripts/webkitpy/style/unittests.py: Added.
3757
3758 2010-01-07  Adam Barth  <abarth@webkit.org>
3759
3760         Reviewed by Maciej Stachowiak.
3761
3762         Don't print a redundant message when confirming a diff
3763         https://bugs.webkit.org/show_bug.cgi?id=33315
3764
3765         Instead of saying "ERROR: User declined" we should just exit because
3766         the use knows they just declined!
3767
3768         * Scripts/webkitpy/steps/confirmdiff.py:
3769
3770 2010-01-07  Adam Barth  <abarth@webkit.org>
3771
3772         Reviewed by Maciej Stachowiak.
3773
3774         Check style before uploading a patch
3775         https://bugs.webkit.org/show_bug.cgi?id=33314
3776
3777         * Scripts/webkitpy/commands/upload.py:
3778         * Scripts/webkitpy/steps/checkstyle.py:
3779         * Scripts/webkitpy/steps/options.py:
3780
3781 2010-01-07  Adam Barth  <abarth@webkit.org>
3782
3783         Reviewed by Maciej Stachowiak.
3784
3785         Add prepare and post to webkit-patch main help
3786         https://bugs.webkit.org/show_bug.cgi?id=33313
3787
3788         * Scripts/webkitpy/commands/upload.py:
3789
3790 2010-01-07  Eric Seidel  <eric@webkit.org>
3791
3792         Reviewed by Adam Barth.
3793
3794         Add Chromium bots to the list of "core builders" (builders which stop the commit-queue when they turn red)
3795         https://bugs.webkit.org/show_bug.cgi?id=33290
3796
3797         Add the Chromium builders to our list of core builders and test that our regexps work.
3798         I also updated our regexp testing to make sure we cover all known builders at build.webkit.org.
3799
3800         * Scripts/webkitpy/buildbot.py:
3801         * Scripts/webkitpy/buildbot_unittest.py:
3802
3803 2010-01-07  Adam Barth  <abarth@webkit.org>
3804
3805         Reviewed by Eric Seidel.
3806
3807         bugzilla-tool needs a new name
3808         https://bugs.webkit.org/show_bug.cgi?id=28459
3809
3810         Rename bugzilla-tool to webkit-patch.  Also, rename some commands to
3811         make more sense with the new name.
3812
3813         * Scripts/bugzilla-tool: Removed.
3814         * Scripts/webkit-patch: Added.
3815         * Scripts/webkit-tools-completion.sh:
3816         * Scripts/webkitpy/bugzilla_unittest.py:
3817         * Scripts/webkitpy/commands/download.py:
3818         * Scripts/webkitpy/commands/download_unittest.py:
3819         * Scripts/webkitpy/commands/early_warning_system.py:
3820         * Scripts/webkitpy/commands/queries.py:
3821         * Scripts/webkitpy/commands/queues.py:
3822         * Scripts/webkitpy/commands/queues_unittest.py:
3823         * Scripts/webkitpy/commands/upload.py:
3824         * Scripts/webkitpy/commands/upload_unittest.py:
3825         * Scripts/webkitpy/queueengine.py:
3826         * Scripts/webkitpy/steps/completerollout.py:
3827
3828 2010-01-07  Chris Jerdonek  <chris.jerdonek@gmail.com>
3829
3830         Reviewed by Eric Seidel.
3831
3832         Moved style-related modules to webkitpy.style sub-package.
3833
3834         https://bugs.webkit.org/show_bug.cgi?id=32971
3835
3836         * Scripts/check-webkit-style:
3837           - Updated import statement.
3838
3839         * Scripts/test-webkitpy:
3840           - Updated import statements.
3841
3842         * Scripts/webkitpy/cpp_style.py: Removed.
3843           - Moved to webkitpy/style.
3844
3845         * Scripts/webkitpy/cpp_style_unittest.py: Removed.
3846           - Moved to webkitpy/style.
3847
3848         * Scripts/webkitpy/style.py: Removed.
3849           - Moved to webkitpy/style/checker.py.
3850
3851         * Scripts/webkitpy/style/__init__.py: Added.
3852           - Added containing webkitpy directory to package search path.
3853
3854         * Scripts/webkitpy/style/checker.py: Copied from Scripts/webkitpy/style.py.
3855         * Scripts/webkitpy/style/checker_unittest.py: Copied from Scripts/webkitpy/style_unittest.py.
3856           - Updated import statement.
3857
3858         * Scripts/webkitpy/style/cpp_style.py: Copied from Scripts/webkitpy/cpp_style.py.
3859         * Scripts/webkitpy/style/cpp_style_unittest.py: Copied from Scripts/webkitpy/cpp_style_unittest.py.
3860           - Update import statement.
3861
3862         * Scripts/webkitpy/style/text_style.py: Copied from Scripts/webkitpy/text_style.py.
3863         * Scripts/webkitpy/style/text_style_unittest.py: Copied from Scripts/webkitpy/text_style_unittest.py.
3864         * Scripts/webkitpy/style_unittest.py: Removed.
3865           - Moved to webkitpy/style/checker_unittest.py.
3866
3867         * Scripts/webkitpy/text_style.py: Removed.
3868           - Moved to webkitpy/style.
3869
3870         * Scripts/webkitpy/text_style_unittest.py: Removed.
3871           - Moved to webkitpy/style.
3872
3873 2010-01-06  Kinuko Yasuda  <kinuko@chromium.org>
3874
3875         Reviewed by Eric Seidel.
3876
3877         [Qt] Support the 3rd argument of EventSender.keyDown that
3878         has been recently added to report keyLocation
3879         (see also: https://bugs.webkit.org/show_bug.cgi?id=28247).
3880         https://bugs.webkit.org/show_bug.cgi?id=33250
3881
3882         Test: fast/events/keydown-numpad-keys.html
3883
3884         * DumpRenderTree/qt/EventSenderQt.cpp:
3885         (EventSender::keyDown):
3886         * DumpRenderTree/qt/EventSenderQt.h:
3887
3888 2010-01-06  Eric Seidel  <eric@webkit.org>
3889
3890         Reviewed by Adam Barth.
3891
3892         Add long_help for all common commands.
3893         https://bugs.webkit.org/show_bug.cgi?id=33261
3894
3895         For now these long_helps are pretty basic.
3896         These were all written to just explain the steps
3897         that each command runs.  This style long_help could
3898         be made easier by using:
3899         https://bugs.webkit.org/show_bug.cgi?id=33257
3900
3901         * Scripts/webkitpy/commands/download.py:
3902         * Scripts/webkitpy/commands/queries.py:
3903
3904 2010-01-06  Diego Gonzalez  <diego.gonzalez@openbossa.org>
3905
3906         Reviewed by Kenneth Christiansen.
3907
3908         [Qt] Add page zooming support to Qt DumpRenderTree
3909         https://bugs.webkit.org/show_bug.cgi?id=32898
3910
3911         Patch by Kim Grönholm  <kim.gronholm@nomovok.com>,
3912                  Diego Gonzalez <diego.gonzalez@openbossa.org> and
3913                  Afonso Costa <afonso.costa@openbossa.org>
3914
3915         * DumpRenderTree/qt/EventSenderQt.cpp:
3916         (EventSender::zoomPageIn):
3917         (EventSender::zoomPageOut):
3918         * DumpRenderTree/qt/EventSenderQt.h:
3919
3920 2010-01-06  Eric Seidel  <eric@webkit.org>
3921
3922         No review, just adding Mike Belshe's new bugzilla email at his request.
3923
3924         * Scripts/webkitpy/committers.py:
3925
3926 2010-01-06  Eric Seidel  <eric@webkit.org>
3927
3928         Unreviewed.  Rolling out r52869 and r52853 due to bot
3929         and local run-webkit-test failures
3930
3931         REGRESSION(52854?) fast/workers/shared-worker-constructor.html failed on Leopard Build Bot
3932         https://bugs.webkit.org/show_bug.cgi?id=33256
3933
3934         The original bug was https://bugs.webkit.org/show_bug.cgi?id=33153
3935
3936         * Scripts/run-webkit-tests:
3937
3938 2010-01-06  Eric Seidel  <eric@webkit.org>
3939
3940         Unreviewed "build" fix.  Just adding missing include.
3941
3942         bugzilla-tool rollout --complete-rollout should make a nicer bug comment
3943         https://bugs.webkit.org/show_bug.cgi?id=29212
3944
3945         * Scripts/webkitpy/steps/completerollout.py:
3946
3947 2010-01-06  Eric Seidel  <eric@webkit.org>
3948
3949         Reviewed by Adam Barth.
3950
3951         bugzilla-tool rollout --complete-rollout should make a nicer bug comment
3952         https://bugs.webkit.org/show_bug.cgi?id=29212
3953
3954         * Scripts/webkitpy/bugzilla.py:
3955          - Make reopen_bug robust against the bug already being open.
3956         * Scripts/webkitpy/commands/download.py:
3957          - Remove dead code from Rollout.
3958         * Scripts/webkitpy/steps/completerollout.py:
3959          - Improve the rollout comment.
3960
3961 2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>
3962
3963         Reviewed by Darin Adler.
3964
3965         Set isHttpdOpen to 0 if pidfile does not exist for some reason.
3966         Speculative fix for https://bugs.webkit.org/show_bug.cgi?id=33256.
3967
3968         * Scripts/run-webkit-tests:
3969
3970 2010-01-06  Andras Becsi  <abecsi@inf.u-szeged.hu>
3971
3972         Reviewed by Darin Adler.
3973
3974         Change hardcoded /tmp in run-webkit-tests to File::Spec->tmpdir(),
3975         and remove the httpd's pidfile directory if httpd terminated.
3976
3977         * Scripts/run-webkit-tests:
3978
3979 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
3980
3981         Reviewed by David Levin.
3982
3983         Refactored check-webkit-style's argument parser to not rely
3984         on global state, and improved its error handling and unit
3985         test coverage.
3986
3987         https://bugs.webkit.org/show_bug.cgi?id=32966
3988
3989         * Scripts/check-webkit-style:
3990           - Adjusted to use new argument parser.
3991
3992         * Scripts/webkitpy/cpp_style.py:
3993           - Changed _CppStyleState to accept an array of filter rules
3994             instead of a comma-delimited string.
3995           - Eliminated cpp_style._DEFAULT_FILTER_RULES.
3996           - Eliminated cpp_style._USAGE.
3997
3998         * Scripts/webkitpy/cpp_style_unittest.py:
3999           - Updated test_filter() and test_default_filter().
4000
4001         * Scripts/webkitpy/style.py:
4002           - Converted style._USAGE to create_usage().
4003           - Corrected usage instructions by removing 0 as a valid
4004             --verbose flag value.
4005           - Removed use_webkit_styles().
4006           - Added ProcessorOptions class.
4007           - Added ArgumentDefaults class.
4008           - Added ArgumentPrinter class.
4009           - Removed parse_arguments and added ArgumentParser class.
4010           - Moved exit_with_usage() and exit_with_categories() into
4011             ArgumentParser.
4012           - Refactored parse_arguments() as ArgumentParser.parse().
4013           - Improved parser error handling.
4014
4015         * Scripts/webkitpy/style_unittest.py:
4016           - Added DefaultArgumentsTest class.
4017           - Addressed FIXME to check style.WEBKIT_FILTER_RULES
4018             against style.STYLE_CATEGORIES.
4019           - Added ArgumentPrinterTest class.
4020           - Added ArgumentParserTest class and rewrote parser unit tests.
4021
4022 2010-01-05  Adam Roben  <aroben@apple.com>
4023
4024         Test that it's safe to call IWebView::close when
4025         IWebView::initWithFrame hasn't been called
4026
4027         Part of <http://webkit.org/b/32827> Crash when calling
4028         IWebView::close, then releasing the WebView, without calling
4029         DestroyWindow
4030
4031         Reviewed by Steve Falkenburg.
4032
4033         * WebKitAPITest/tests/WebViewDestruction.cpp:
4034         (WebKitAPITest::CloseWithoutInitWithFrame): Calls IWebView::close
4035         without ever calling IWebView::initWithFrame and tests that we don't
4036         crash or leak.
4037
4038 2010-01-05  Adam Roben  <aroben@apple.com>
4039
4040         Add more WebViewDestruction tests
4041
4042         Fixes <http://webkit.org/b/33216>.
4043
4044         Reviewed by Eric Seidel.
4045
4046         * WebKitAPITest/tests/WebViewDestruction.cpp:
4047         (WebKitAPITest::NoInitWithFrame):
4048         (WebKitAPITest::CloseThenDestroyViewWindow):
4049         (WebKitAPITest::DestroyViewWindowThenClose):
4050         (WebKitAPITest::DestroyHostWindow):
4051         (WebKitAPITest::DestroyHostWindowThenClose):
4052         (WebKitAPITest::CloseThenDestroyHostWindow):
4053         Added these tests that exercise tearing down a WebView in various
4054         ways, all of which we eventually want to have work. Some of them
4055         currently crash or leak.
4056
4057 2010-01-05  Robert Hogan  <robert@roberthogan.net>
4058
4059         Reviewed by Eric Seidel.
4060
4061         [Qt] fix DRT link failures on --no-svg builds when only making changes to DRT
4062         
4063         If you're working from a --minimal or --no-svg build and make changes to the
4064         DRT, then recompile, the build will fail.
4065         
4066         This is because the current behavior at build time is to assume that the
4067         previous Qt build supported SVG and consequently delete libQtWebKit.so.
4068         Unfortunately, just deleting libQtWebKit.so will not cause the library to
4069         re-link. Instead the build will see libQtWebKit.so.4 and co., pass over the
4070         linking phase, and attempt to link the DRT with libQtWebKit.so absent. This
4071         results in a link failure on the DRT.
4072         
4073         Since re-linking libQtWebKit can take up to ten minutes and should be avoided
4074         in cases where not actually required, remove the assumption that
4075         the previous Qt build supported SVG, and amend the symbol detection to look for
4076         a symbol name that is not present in SVG builds. Currently webkitdirs.pm looks
4077         for 'SVGElement' but even non-SVG builds contain the symbol 'isSVGElement'.
4078         
4079         https://bugs.webkit.org/show_bug.cgi?id=32992
4080
4081         * Scripts/webkitdirs.pm:
4082
4083 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
4084
4085         Reviewed by David Kilzer.
4086
4087         Switched to generating list of Perl unit test files dynamically,
4088         instead of explicitly.
4089
4090         https://bugs.webkit.org/show_bug.cgi?id=33200
4091
4092         * Scripts/test-webkitperl:
4093
4094 2010-01-05  Yael Aharon  <yael.aharon@nokia.com>
4095
4096         Reviewed by Kenneth Rohde Christiansen.
4097
4098         [Qt] Reimplement EventSender::leapForward
4099         https://bugs.webkit.org/show_bug.cgi?id=33114
4100
4101         Follow Windows implementation of leapForward. When leapForward is called, 
4102         messages are queued and posted after the timeout. A new event loop is created to
4103         handle those messages and the additional messages that are created as a result.
4104
4105         * DumpRenderTree/qt/DumpRenderTree.pro:
4106         * DumpRenderTree/qt/EventSenderQt.cpp:
4107         (EventSender::EventSender):
4108         (EventSender::mouseDown):
4109         (EventSender::mouseUp):
4110         (EventSender::mouseMoveTo):
4111         (EventSender::leapForward):
4112         (EventSender::sendOrQueueEvent):
4113         (EventSender::replaySavedEvents):
4114         (EventSender::eventFilter):
4115         * DumpRenderTree/qt/EventSenderQt.h:
4116
4117 2010-01-05  Adam Barth  <abarth@webkit.org>
4118
4119         Reviewed by Darin Adler.
4120
4121         Fix obscure queue crash in queueengine
4122         https://bugs.webkit.org/show_bug.cgi?id=33196
4123
4124         Sometimes we get an exception that can't be stringified.  For example:
4125
4126         AttributeError: 'ParseError' object has no attribute 'msg'
4127
4128         In these cases, the whole queue dies because we're in the global
4129         exception handler.  Instead of dieing here, we should just print a less
4130         informative message to the console.  We're already printing the whole
4131         backtrace anyway, so there's not much point to stringifying the
4132         exception anyway.
4133
4134         * Scripts/webkitpy/queueengine.py:
4135
4136 2010-01-05  Dominic Mazzoni  <dmazzoni@google.com>
4137
4138         Reviewed by Darin Adler.
4139
4140         https://bugs.webkit.org/show_bug.cgi?id=32571
4141
4142         For an object with an aria role of "checkbox" or "radiobutton",
4143         use the "aria-checked" attribute to determine if it's checked.
4144         These changes add an isChecked() method to AccessibilityUIElement
4145         so that we can check for this property from a layout test.
4146
4147         * DumpRenderTree/AccessibilityUIElement.cpp:
4148         (getIsCheckedCallback):
4149         (AccessibilityUIElement::getJSClass):
4150         * DumpRenderTree/AccessibilityUIElement.h:
4151         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4152         (AccessibilityUIElement::isChecked):
4153         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4154         (AccessibilityUIElement::isChecked):
4155         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4156         (AccessibilityUIElement::isChecked):
4157
4158 2010-01-05  David Levin  <levin@chromium.org>
4159
4160         Reviewed by Darin Adler.
4161
4162         Having a comment for the #endif for a header guard is not required WebKit style.
4163         https://bugs.webkit.org/show_bug.cgi?id=33214
4164
4165         * Scripts/webkitpy/cpp_style.py: removed the check and made the loop exit
4166           early when it has all the needed information to continue.
4167         * Scripts/webkitpy/cpp_style_unittest.py: removed the corresponding tests.
4168
4169 2010-01-05  Adam Roben  <aroben@apple.com>
4170
4171         Share more code in the WebViewDestruction tests
4172
4173         Part of <http://webkit.org/b/33212> Small fixes/improvements to
4174         WebKitAPITest
4175
4176         Reviewed by Sam Weinig.
4177
4178         * WebKitAPITest/tests/WebViewDestruction.cpp:
4179         (WebKitAPITest::createAndInitializeWebView): Renamed from
4180         createWebView. Now initializes the HostWindow and returns the
4181         WebView's HWND via an out-parameter.
4182         (WebKitAPITest::finishWebViewDestructionTest): Added. Code came from
4183         the CloseWithoutDestroyWindow test.
4184         (WebKitAPITest::CloseWithoutDestroyViewWindow): Renamed from
4185         CloseWithoutDestroyWindow and changed to use the new functions.
4186         (WebKitAPITest::MainFrameAfterClose): Changed to use the new
4187         functions.
4188         (WebKitAPITest::NoCloseOrDestroyViewWindow): Renamed from
4189         NoCloseOrDestroyWindow and changed to use the new functions.
4190
4191 2010-01-05  Adam Roben  <aroben@apple.com>
4192
4193         Don't show HostWindows by default
4194
4195         This was making WebKitAPITest very flashy as windows appeared and
4196         disappeared.
4197
4198         Part of <http://webkit.org/b/33212> Small fixes/improvements to
4199         WebKitAPITest
4200
4201         Reviewed by Sam Weinig.
4202
4203         * WebKitAPITest/HostWindow.cpp:
4204         (WebKitAPITest::HostWindow::initialize): Removed the WS_VISIBLE style
4205         from the window.
4206
4207 2010-01-05  Adam Roben  <aroben@apple.com>
4208
4209         Don't hang in WebKitAPITest if no messages have been posted
4210
4211         Part of <http://webkit.org/b/33212> Small fixes/improvements to
4212         WebKitAPITest
4213
4214         Reviewed by Sam Weinig.
4215
4216         * WebKitAPITest/tests/WebViewDestruction.cpp:
4217         (WebKitAPITest::runMessagePump): Use PeekMessage instead of GetMessage
4218         to avoid hanging if no messages have been posted.
4219
4220 2010-01-05  Adam Roben  <aroben@apple.com>
4221
4222         Fix WebKitCreateInstance helper
4223
4224         Part of <http://webkit.org/b/33212> Small fixes/improvements to
4225         WebKitAPITest
4226
4227         Reviewed by Sam Weinig.
4228
4229         * WebKitAPITest/tests/WebViewDestruction.cpp:
4230         (WebKitAPITest::WebKitCreateInstance): Pass the pointer straight
4231         through, instead of taking its address.
4232
4233 2010-01-04  Maciej Stachowiak  <mjs@apple.com>
4234
4235         Reviewed by Darin Fisher.
4236
4237         Reorganize, document and rename OS() platform macros.
4238         https://bugs.webkit.org/show_bug.cgi?id=33198
4239
4240         Adapt to name changes.
4241         
4242         * DumpRenderTree/DumpRenderTree.h:
4243         * DumpRenderTree/config.h:
4244
4245 2010-01-05  Chris Jerdonek  <chris.jerdonek@gmail.com>
4246
4247         Reviewed by Eric Seidel.
4248
4249         Minor improvements to test-webkit-scripts, as suggested
4250         by an earlier review.
4251
4252         https://bugs.webkit.org/show_bug.cgi?id=33125
4253
4254         * Scripts/test-webkit-scripts:
4255           - Used OptionParser class instead of getopt.getopt().
4256           - Created main() method for __main__ block.