42fc713c52c798f94bb38c851ec55bed0ca046ac
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2
3         Reviewed by Anders Carlsson.
4
5         Add the ability to run script on 'new' and 'paint' in the test plugin
6         https://bugs.webkit.org/show_bug.cgi?id=50425
7         
8         Add "onnew" and "onpaintevent" attributes to the test plugin,
9         so that tests can run JS at these times.
10
11         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
12         (pluginAllocate):
13         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
14         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
15         (NPP_New):
16         (NPP_Destroy):
17         (handleEventCarbon):
18         (handleEventCocoa):
19         (NPP_HandleEvent):
20
21 2010-12-02  Sam Weinig  <sam@webkit.org>
22
23         Fix Qt build.
24
25         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
26         (WTR::PlatformWebView::PlatformWebView):
27
28 2010-12-02  Sam Weinig  <sam@webkit.org>
29
30         Reviewed by Anders Carlsson.
31
32         WebKit2 Preferences should be held off the PageGroup, not the Context
33         https://bugs.webkit.org/show_bug.cgi?id=50414
34
35         Update for API changes.
36
37         * WebKitTestRunner/PlatformWebView.h:
38         * WebKitTestRunner/TestController.cpp:
39         (WTR::createOtherPage):
40         (WTR::TestController::initialize):
41         (WTR::TestController::resetStateToConsistentValues):
42         * WebKitTestRunner/TestController.h:
43         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
44         (WTR::PlatformWebView::PlatformWebView):
45         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
46         (WTR::PlatformWebView::PlatformWebView):
47
48 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
49
50         Reviewed by Tony Chang.
51
52         new-run-webkit-tests: minor cleanup for multiprocessing work
53
54         This change:
55         * moves worker naming into TestShellThread, eliminating a
56           parameter to the constructor and putting the responsibility in
57           the correct place.
58         * eliminates the _WorkerState() class in message_broker, because
59           it turns out that state really needs to be in run_webkit_tests
60         * renames the Broker classes to be module-private.
61         * fixes a bunch of minor commenting and whitespace issues to
62           make subsequent patches a bit clearer.
63         * Adds a Port hook for default_worker_model() so that we can
64           accomodate the potential for different worker models on
65           different ports.
66         * merge in the fix from 50420 for the brokenness introduced in
67           bug 50367.
68
69         This patch depends on bug 50367.
70
71         https://bugs.webkit.org/show_bug.cgi?id=50372
72
73         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
74         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
75         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
76         * Scripts/webkitpy/layout_tests/port/base.py:
77         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
78         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
79
80 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
81
82         Reviewed by Tony Chang.
83
84         This change is a bunch of cleanup / refactoring of the file
85         below. It moves a bunch of free functions to methods on the
86         TestShellThread class, and restructures other methods to be
87         closer to the structure we'll need for the multiprocessing
88         rewrite.
89
90         It also makes the logic of --run-singly a *lot* easier to follow
91         by nestling all of the separate-thread logic into a single
92         routine.
93
94         There should be no semantic changes in this patch, just cleanup.
95
96         https://bugs.webkit.org/show_bug.cgi?id=50367
97
98         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
99
100 2010-12-02  Tony Chang  <tony@chromium.org>
101
102         Unreviewed, rolling out r73164.
103         http://trac.webkit.org/changeset/73164
104         https://bugs.webkit.org/show_bug.cgi?id=50359
105
106         broke debugger tests on win
107
108         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
109
110 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
111
112         Reviewed by Tony Chang.
113
114         Rebaseline server: add updating of baselines
115         https://bugs.webkit.org/show_bug.cgi?id=50305
116         
117         Implements updating of baselines, where we copy -actual.* files over
118         the current -expected.* files. To do this, we need a
119         _get_actual_result_files method to get test results files and a
120         _rebaseline_test method to actually do the file copy and SCM operation.
121         _rebaseline_test logs output into a buffer, this is useful for both
122         showing result in the UI and for unit tests.
123         
124         To make passing around of the various test environment properties
125         (results directory, filesystem, SCM, etc) easier, add a TestConfig
126         class for them.
127         
128         Moving of existing baselines is not implemented yet, this patch is big
129         enough as it is.
130
131         * Scripts/webkitpy/common/system/filesystem.py:
132         * Scripts/webkitpy/common/system/filesystem_mock.py:
133         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
134         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
135         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
136         * Scripts/webkitpy/tool/mocktool.py:
137
138 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
139
140         Unreviewed build fix after vcproj updates.
141
142         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
143         that WIN_CAIRO is defined for this build.
144         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
145         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
146         (these were previously 'Debug_Cairo' and 'Release_Cairo'
147
148 2010-12-02  Sam Weinig  <sam@webkit.org>
149
150         Reviewed by Anders Carlsson.
151
152         WebKit2 needs API to turn on popup blocking
153         https://bugs.webkit.org/show_bug.cgi?id=50407
154
155         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
156         (TestWebKitAPI::TEST):
157         * WebKitTestRunner/TestController.cpp:
158         (WTR::TestController::resetStateToConsistentValues):
159
160 2010-12-01  Tony Chang  <tony@chromium.org>
161
162         Reviewed by Ojan Vafai.
163
164         [chromium] force NRWT to use DRT
165         https://bugs.webkit.org/show_bug.cgi?id=50359
166
167         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
168
169 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
170
171         Reviewed by Xan Lopez.
172
173         [GTK] DumpRenderTree has two copies of JavaScriptCore
174         https://bugs.webkit.org/show_bug.cgi?id=49877
175
176         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
177         LDADD list for DumpRenderTree.
178
179 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
180
181         Unreviewed: Added myself to list of Committers.
182
183         * Scripts/webkitpy/common/config/committers.py:
184
185 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
186
187         Reviewed by Adam Barth.
188
189         build-webkit --chromium always updates DEPS and re-generates project files
190         https://bugs.webkit.org/show_bug.cgi?id=50340
191         
192         Make build-webkit --chromium invoke update-webkit-chromium only when
193         --update-chromium is passed in, so that we don't add 20 seconds to all
194         builds.
195         
196         Making all invocations update was added with r61883, with the goal of
197         making EWS bots always update. The bots will switch to using this flag
198         (as will all other webkit-patch build steps) so nothing should change
199         for them.
200
201         * Scripts/webkitdirs.pm:
202         * Scripts/webkitpy/common/config/ports.py:
203         * Scripts/webkitpy/common/config/ports_unittest.py:
204
205 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
206
207         Reviewed by Tony Chang.
208
209         new-run-webkit-tests: add a --dry-run / -n flag
210         https://bugs.webkit.org/show_bug.cgi?id=50045
211
212         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
213         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
214
215 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
216
217         Reviewed by Adam Roben.
218
219         WinCairo build should not use link-time code generation (LTCG)
220         https://bugs.webkit.org/show_bug.cgi?id=50353
221
222         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
223         * DumpRenderTree/win/DumpRenderTree.vcproj:
224         * DumpRenderTree/win/ImageDiff.vcproj:
225         * FindSafari/FindSafari.vcproj:
226         * MiniBrowser/MiniBrowser.vcproj:
227         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
228         * WebKitAPITest/WebKitAPITest.vcproj:
229         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
230         * WebKitTestRunner/win/InjectedBundle.vcproj:
231         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
232         * WinLauncher/WinLauncher.vcproj:
233         * record-memory-win/record-memory-win.vcproj:
234
235 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
236
237         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
238         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
239         adding the file to the sources list was not enough to force the rebuild.
240
241         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
242         Remove an empty line at the end of this file to force a rebuild.
243
244 2010-12-01  Sam Weinig  <sam@webkit.org>
245
246         Fix windows build.
247
248         * MiniBrowser/win/BrowserView.cpp:
249         (BrowserView::create):
250
251 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
252
253         Add missing file to the TestNetscapePlugin sources list after r73057.
254
255         * GNUmakefile.am: Add missing file.
256
257 2010-12-01  Sam Weinig  <sam@webkit.org>
258
259         Reviewed by Anders Carlsson.
260
261         Add PageGrouping to WebKit2 API
262         https://bugs.webkit.org/show_bug.cgi?id=50332
263
264         - Update testing harnesses to deal with new PageGroup API.
265
266         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
267         (WKBundleInitialize):
268         * TestWebKitAPI/InjectedBundleController.cpp:
269         (TestWebKitAPI::InjectedBundleController::initialize):
270         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
271         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
272         * TestWebKitAPI/InjectedBundleController.h:
273         * TestWebKitAPI/InjectedBundleTest.h:
274         (TestWebKitAPI::InjectedBundleTest::initialize):
275         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
276         * TestWebKitAPI/PlatformUtilities.cpp:
277         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
278         * TestWebKitAPI/PlatformUtilities.h:
279         * TestWebKitAPI/PlatformWebView.h:
280         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
281         (TestWebKitAPI::TEST):
282         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
283         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
284         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
285         (TestWebKitAPI::PlatformWebView::PlatformWebView):
286         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
287         (TestWebKitAPI::PlatformWebView::PlatformWebView):
288         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
289         (WTR::InjectedBundle::didInitializePageGroup):
290         (WTR::InjectedBundle::initialize):
291         (WTR::InjectedBundle::beginTesting):
292         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
293         (WTR::InjectedBundle::pageGroup):
294         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
295         (WTR::LayoutTestController::addUserScript):
296         (WTR::LayoutTestController::addUserStyleSheet):
297         (WTR::LayoutTestController::setXSSAuditorEnabled):
298         * WebKitTestRunner/TestController.cpp:
299         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
300         (WTR::PlatformWebView::PlatformWebView):
301
302 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
303
304         Reviewed by Adam Roben.
305
306         vcproj changes can't be applied cleanly by the Windows EWS bot
307         https://bugs.webkit.org/show_bug.cgi?id=50328
308
309         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
310         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
311         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
312         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
313         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
314         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
315         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
316         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
317         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
318         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
319         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
320         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
321         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
322         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
323         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
324         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
325         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
326         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
327         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
328         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
329         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
330         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
331         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
332         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
333         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
334         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
335         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
336         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
337         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
338         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
339         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
340         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
341         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
342         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
343         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
344         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
345         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
346         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
347         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
348         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
349         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
350         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
351         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
352         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
353         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
354
355 2010-12-01  Anders Carlsson  <andersca@apple.com>
356
357         Reviewed by Darin Adler.
358
359         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
360         https://bugs.webkit.org/show_bug.cgi?id=50336
361
362         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
363         Add new test.
364
365         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
366         (PluginTest::NPP_New):
367         Add default implementation/
368
369         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
370         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
371         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
372         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
373         Get the user agent.
374
375         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
376         (NPP_New):
377         Call PluginTest::NPP_New.
378
379         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
380         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
381         Add new files.
382
383         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
384         (webkit_test_plugin_new_instance):
385         Call PluginTest::NPP_New.
386
387 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
388
389         [wx] Build fixes after recent trunk changes.
390
391         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
392         (LayoutTestController::findString):
393         * wx/build/settings.py:
394
395 2010-12-01  Dan Bernstein  <mitz@apple.com>
396
397         Reviewed by Darin Adler.
398
399         WebKitTestRunner needs layoutTestController.findString
400         https://bugs.webkit.org/show_bug.cgi?id=50238
401
402         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
403         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
404         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
405         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
406
407 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
408
409         Try using svn:eol-style native on a vcproj file.
410
411         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
412
413 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
414
415         Reviewed by Adam Roben.
416
417         [WINCE] Add WinCELauncher
418         https://bugs.webkit.org/show_bug.cgi?id=50217
419
420         * WinCELauncher/main.cpp: Added.
421
422 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
423
424         Reviewed by Kenneth Rohde Christiansen.
425
426         [Qt] Implement layoutTestController.findString
427         https://bugs.webkit.org/show_bug.cgi?id=50236
428
429         Add the missing function to the LayoutTestController.
430
431         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
432         (LayoutTestController::findString):
433         * DumpRenderTree/qt/LayoutTestControllerQt.h:
434
435 2010-11-30  Tony Chang  <tony@chromium.org>
436
437         Reviewed by Adam Barth.
438
439         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
440         https://bugs.webkit.org/show_bug.cgi?id=49036
441
442         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
443             for CppVariants.
444         (LayoutTestController::cppVariantToBool):
445         (LayoutTestController::cppVariantToInt32):
446         (LayoutTestController::setDatabaseQuota):
447         (LayoutTestController::evaluateInWebInspector):
448         (LayoutTestController::setMockGeolocationError):
449
450 2010-11-30  Eric Seidel  <eric@webkit.org>
451
452         Reviewed by Tony Chang.
453
454         update-webkit should call git fetch before git svn rebase
455         https://bugs.webkit.org/show_bug.cgi?id=50273
456
457         After discussion on webkit-dev, we've decided to move the "default"
458         git setup to pulling updates from git.webkit.org in preference
459         to rebuilding the local svn index using git svn fetch every time.
460
461         This change should have no effect on people using the "old" git setup
462         and should dramatically increase the speed of updates for those using
463         the "new" git setup along with update-webkit.  I'm about to move the
464         EWS and other queues over to this setup once this lands.
465
466         * Scripts/update-webkit:
467
468 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
469
470         Reviewed by Xan Lopez.
471
472         GTK: AX: implement press in DRT
473         https://bugs.webkit.org/show_bug.cgi?id=36146
474
475         Implement AccessibilityUIElement::press() for GTK.
476
477         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
478         (AccessibilityUIElement::press): Implemented.
479
480 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
481
482         Reviewed by Tony Chang.
483
484         config.webkit_base_dir returns a path with a trailing slash
485         https://bugs.webkit.org/show_bug.cgi?id=50197
486         
487         config.webkit_base_dir() should return a path without a trailing slash,
488         like all the other methods that return paths.
489         
490         Undoes MockFileSytem changes by r72640, since they're no longer
491         necessary for GetBaselinesTest to pass.
492
493         * Scripts/webkitpy/common/system/filesystem_mock.py:
494         * Scripts/webkitpy/layout_tests/port/base.py:
495         * Scripts/webkitpy/layout_tests/port/config.py:
496         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
497
498 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
499
500         Reviewed by Tony Chang.
501
502         Rebaseline server: baseline display tweaks
503         https://bugs.webkit.org/show_bug.cgi?id=50207
504         
505         Determine which baselines were used when running the tests and highlight
506         them in the UI. Sort platform names alphabetically.
507         
508         Also makes the server URL be launched in the user's browser
509         automatically.
510
511         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
512         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
513         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
514         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
515         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
516
517 2010-11-30  Dan Bernstein  <mitz@apple.com>
518
519         Reviewed by Anders Carlsson.
520
521         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
522         https://bugs.webkit.org/show_bug.cgi?id=50238
523
524         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
525         (WTR::LayoutTestController::findString): Added.
526         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
527
528 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
529
530         Reviewed by Adam Roben.
531
532         All projects on Windows should use cmd files for build events
533         https://bugs.webkit.org/show_bug.cgi?id=50213
534
535         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
536         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
537         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
538         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
539         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
540         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
541         * DumpRenderTree/win/ImageDiffCommon.vsprops:
542         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
543         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
544         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
545         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
546         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
547         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
548         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
549         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
550         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
551         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
552         * WebKitAPITest/WebKitAPITestCommon.vsprops:
553         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
554         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
555         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
556         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
557         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
558         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
559         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
560         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
561         * WinLauncher/WinLauncherCommon.vsprops:
562         * WinLauncher/WinLauncherPostBuild.cmd: Added.
563         * WinLauncher/WinLauncherPreBuild.cmd: Added.
564
565 2010-11-29  Dan Bernstein  <mitz@apple.com>
566
567         GTK DumpRenderTree build fix after r72887.
568
569         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
570         (LayoutTestController::findString):
571
572 2010-11-29  Dan Bernstein  <mitz@apple.com>
573
574         Windows DumpRenderTree build fix after r72887.
575
576         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
577         (LayoutTestController::findString): Added empty implementation.
578
579 2010-11-29  Dan Bernstein  <mitz@apple.com>
580
581         Reviewed by Darin Adler.
582
583         DumpRenderTree changes for testing the text search API.
584         https://bugs.webkit.org/show_bug.cgi?id=50038
585
586         * DumpRenderTree/LayoutTestController.cpp:
587         (findStringCallback):
588         (LayoutTestController::staticFunctions):
589         * DumpRenderTree/LayoutTestController.h:
590         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
591         (LayoutTestController::findString):
592         * MiniBrowser/mac/BrowserWindowController.m:
593         (-[BrowserWindowController find:]):
594
595 2010-11-29  Johnny Ding  <jnd@chromium.org>
596
597         Unreviewed: Add myself to the list of Committers.
598
599         * Scripts/webkitpy/common/config/committers.py:
600
601 2010-11-29  Mark Rowe  <mrowe@apple.com>
602
603         Reviewed by Adele Peterson.
604
605         <rdar://problem/8694997> DumpRenderTree fails to build.
606
607         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
608
609 2010-11-29  Mark Rowe  <mrowe@apple.com>
610
611         Reviewed by Adele Peterson.
612
613         <rdar://problem/8694997> DumpRenderTree fails to build.
614
615         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
616         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
617         * DumpRenderTree/mac/PerlSupport/Makefile:
618
619 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
620
621         Reviewed by Martin Robinson.
622
623         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
624         https://bugs.webkit.org/show_bug.cgi?id=50154
625
626         Added missing checks to allAttributes().
627
628         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
629         (AccessibilityUIElement::allAttributes): Added missing checks.
630
631 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
632
633         Reviewed by Kenneth Rohde Christiansen.
634
635         [Qt] Allow pre-generation for package builds for WebKit2
636         https://bugs.webkit.org/show_bug.cgi?id=50139
637
638         Use a build variable for the generated directory path and set the
639         value based on CONFIG just like for WebKit1.
640
641         For non-package builds use a relative base path for the
642         genrated directory just like for WebKit1.
643
644         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
645         * WebKitTestRunner/qt/WebKitTestRunner.pro:
646
647 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
648
649         Reviewed by Kenneth Rohde Christiansen.
650
651         [Qt] Move some build logic from Qt to platform independent code
652         https://bugs.webkit.org/show_bug.cgi?id=50134
653
654         Create target directories inside generate-forwarding-headers.pl.
655
656         * Scripts/generate-forwarding-headers.pl:
657
658 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
659
660         Reviewed by Martin Robinson.
661
662         [GTK] Windowless plugins gets broken key input
663         https://bugs.webkit.org/show_bug.cgi?id=49927
664
665         Convert the XEvent::keycode to ASCII before printing it. Not
666         doing this was causing false positive in 
667         plugins/keyboard-events.html.
668
669         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
670         (keycode_to_char):
671         (webkit_test_plugin_handle_event):
672
673 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
674
675         Reviewed by Antonio Gomes.
676
677         [Qt] Html autofocus not working with QGraphicsWebView
678         https://bugs.webkit.org/show_bug.cgi?id=43169
679
680         Tell the scene to set the webview item as the currently
681         focused item. This makes the input field with autofocus get
682         focus as it should.
683
684         * QtTestBrowser/webview.cpp:
685         (WebViewGraphicsBased::WebViewGraphicsBased):
686
687 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
688
689         Reviewed by Tony Chang.
690
691         nrwt - clean up create_driver interface and print out the
692         command line used for DumpRenderTree/TestShell.
693
694         This patch adds a driver_cmd_line() call to the Port class in
695         order to retrive the command line to print it out (as part of
696         --print config).
697
698         In addition, this patch cleans up the Port.create_driver()
699         signature and the Driver constructor interface to take a worker
700         number and no longer require the image_path argument (Chromium's
701         drivers now synthesize the image_path from the worker number
702         internally).
703
704         https://bugs.webkit.org/show_bug.cgi?id=49934
705
706         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
707         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
708         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
709         * Scripts/webkitpy/layout_tests/port/base.py:
710         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
711         * Scripts/webkitpy/layout_tests/port/chromium.py:
712         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
713         * Scripts/webkitpy/layout_tests/port/dryrun.py:
714         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
715         * Scripts/webkitpy/layout_tests/port/test.py:
716         * Scripts/webkitpy/layout_tests/port/webkit.py:
717         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
718         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
719
720 2010-11-24  Ojan Vafai  <ojan@chromium.org>
721
722         Reviewed by Tony Chang.
723
724         [chromium] improve memory usage for test results server and store fewer runs
725         https://bugs.webkit.org/show_bug.cgi?id=50035
726
727         Store fewer runs and don't pass full files around when we only need bools.
728         Greatly improves error rates on test-results.appspot.com.
729
730         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
731         * TestResultServer/handlers/testfilehandler.py:
732         * TestResultServer/model/dashboardfile.py:
733         * TestResultServer/model/jsonresults.py:
734
735 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
736
737         Reviewed by Tony Chang.
738
739         This patch implements the first part of the manager side of the
740         Broker objects - it handles creating threads, waiting for them
741         to complete, and running a single-threaded loop as well.
742
743         https://bugs.webkit.org/show_bug.cgi?id=49779
744
745         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
746         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
747         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
748         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
749
750 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
751
752         Reviewed by David Levin.
753
754         DRT should not generate pixel output for text/plain tests
755         https://bugs.webkit.org/show_bug.cgi?id=50002
756         
757         Modify Mac, Windows and GTK DRT implementations to disable pixel output
758         when encountering a text/plain response (the Chromium one already does
759         this, and none of the other ports special-case text/plain output in
760         the first place).
761
762         * DumpRenderTree/gtk/DumpRenderTree.cpp:
763         (dump):
764         * DumpRenderTree/mac/DumpRenderTree.mm:
765         (dump):
766         * DumpRenderTree/win/DumpRenderTree.cpp:
767         (dump):
768
769 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
770
771         Unreviewed.
772
773         Add my other email address to committers.py.
774
775         * Scripts/webkitpy/common/config/committers.py:
776
777 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
778
779         Reviewed by Csaba Osztrogonác.
780
781         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
782         https://bugs.webkit.org/show_bug.cgi?id=49975
783
784         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
785         to enable the script to define it 0 in case of a minimal build.
786
787 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
788
789         Reviewed by Xan Lopez.
790
791         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
792         https://bugs.webkit.org/show_bug.cgi?id=49143
793
794         * DumpRenderTree/gtk/DumpRenderTree.cpp:
795         (createWebView): Call the new connectEditingCallbacks function.
796         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
797         (dumpNodePath):
798         (dumpRange):
799         (insertActionString):
800         (selectionAffinityString):
801         (shouldBeginEditing):
802         (shouldEndEditing):
803         (shouldInsertNode):
804         (shouldInsertText):
805         (shouldDeleteRange):
806         (shouldShowDeleteInterfaceForElement):
807         (shouldChangeSelectedRange):
808         (shouldApplyStyle):
809         (editingBegan):
810         (userChangedContents):
811         (editingEnded):
812         (selectionChanged):
813         (connectEditingCallbacks):
814         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
815         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
816
817 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
818
819         Reviewed by Andreas Kling.
820
821         [Qt] Make QtTestBrowser remember the selected user agent
822         https://bugs.webkit.org/show_bug.cgi?id=50021
823
824         Set user agent for a new page by using the old page's
825
826         * QtTestBrowser/mainwindow.cpp:
827         (MainWindow::setPage):
828
829 2010-11-24 Patrick Gansterer <paroga@webkit.org>
830
831         Reviewed by Csaba Osztrogonác.
832
833         Remove Bakefile build system files
834         https://bugs.webkit.org/show_bug.cgi?id=49983
835
836         r53757 only removed the content, but not the files.
837         This patch removes that empty files.
838
839         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
840         * wx/browser/browser.bkl: Removed.
841         * wx/build-wxwebkit: Removed.
842
843 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
844
845         Reviewed by Tony Chang.
846
847         This patch cleans up the logic used to shard tests into groups a
848         bit and adds the --worker-model flag to NRWT. The flag is only
849         used at the moment to control whether to run single-threaded or
850         not, but eventually will also allow toggling between threads and
851         processes.
852
853         Also add a minor cleanup with _test_is_slow(), which just
854         eliminates some repetition and gives slightly better encapsulation.
855
856         https://bugs.webkit.org/show_bug.cgi?id=49773
857
858         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
859         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
860
861 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
862
863         Reviewed by Tony Chang.
864
865         Rebaseline server: list current baselines and platforms
866         https://bugs.webkit.org/show_bug.cgi?id=49991
867         
868         List existing baselines (with Trac links) for tests.
869         
870         Add dropdowns for choosing with platform baselines to target (and what
871         to do with existing ones).
872
873         Also fix MockFileSystem.join to behave more like os.path.join (unit
874         test was ending up with two consecutive slashes in a layout test
875         path).        
876
877         * Scripts/webkitpy/common/system/filesystem_mock.py:
878         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
879         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
880         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
881         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
882         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
883         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
884         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
885
886 2010-11-23  Ojan Vafai  <ojan@chromium.org>
887
888         Reviewed by Tony Chang.
889
890         remove timeout argument to urlopen
891         https://bugs.webkit.org/show_bug.cgi?id=49995
892
893         Apparently the version of python we have on the bots doesn't accept a timeout argument.
894
895         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
896
897 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
898
899         Unreviewed, rolling out r72628.
900         http://trac.webkit.org/changeset/72628
901         https://bugs.webkit.org/show_bug.cgi?id=49994
902
903         This patch is causing layout-test failtures on GTK Linux
904         64-bit Debug (Requested by ctguil on #webkit).
905
906         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
907         (AccessibilityUIElement::AccessibilityUIElement):
908         (AccessibilityUIElement::parentElementCallback):
909         * DumpRenderTree/chromium/AccessibilityUIElement.h:
910         * DumpRenderTree/chromium/CppBoundClass.cpp:
911         * DumpRenderTree/chromium/CppBoundClass.h:
912
913 2010-11-22  Ojan Vafai  <ojan@chromium.org>
914
915         Reviewed by Tony Chang.
916
917         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
918         https://bugs.webkit.org/show_bug.cgi?id=49944
919
920         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
921
922 2010-11-23  Chris Guillory  <chris.guillory@google.com>
923
924         Reviewed by Dimitri Glazkov.
925
926         Include the FrameView widget of a RenderWidget in the accessibility tree.
927         https://bugs.webkit.org/show_bug.cgi?id=49106
928
929         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
930         (AccessibilityUIElement::AccessibilityUIElement):
931         (AccessibilityUIElement::parentElementCallback):
932         (AccessibilityUIElement::isEqualCallback):
933         * DumpRenderTree/chromium/AccessibilityUIElement.h:
934         * DumpRenderTree/chromium/CppBoundClass.cpp:
935         (CppBoundClass::getFromCppVariant):
936         * DumpRenderTree/chromium/CppBoundClass.h:
937
938 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
939
940         Reviewed by Kenneth Rohde Christiansen.
941
942         [EFL] Add tiled backing store to EWebLauncher
943         https://bugs.webkit.org/show_bug.cgi?id=45777
944
945         Allow EWebLauncher to choose between single and tiled backing store
946
947         * EWebLauncher/main.c:
948         (on_key_down):
949         (browserCreate):
950         (main):
951
952 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
953
954         Reviewed by Tor Arne Vestbø.
955
956         [Qt] Review the setUserPermission & friends API
957         https://bugs.webkit.org/show_bug.cgi?id=46810
958
959         Renamed requestPermissionFromUser to featurePermissionRequested
960         and cancelRequestsForPermission to featurePermissionRequestCanceled.
961
962         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
963         (WebCore::WebPage::WebPage):
964         * QtTestBrowser/webpage.cpp:
965         (WebPage::WebPage):
966         (WebPage::featurePermissionRequestCanceled):
967         * QtTestBrowser/webpage.h:
968
969 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
970
971         Reviewed by Tor Arne Vestbø.
972
973         [Qt] Review the setUserPermission & friends API
974         https://bugs.webkit.org/show_bug.cgi?id=46810
975
976         Rename setUserPermission to setFeaturePermission
977
978         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
979         (WebCore::WebPage::requestPermission):
980         (WebCore::WebPage::permissionSet):
981         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
982         (LayoutTestController::grantDesktopNotificationPermission):
983         * QtTestBrowser/webpage.cpp:
984         (WebPage::requestPermission):
985
986 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
987
988         Reviewed by Tor Arne Vestbø.
989
990         [Qt] Review the setUserPermission & friends API
991         https://bugs.webkit.org/show_bug.cgi?id=46810
992
993         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
994         and GeolocationPermissionDomain to Geolocation.
995
996         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
997         (WebCore::WebPage::WebPage):
998         (WebCore::WebPage::requestPermission):
999         (WebCore::WebPage::cancelPermission):
1000         (WebCore::WebPage::permissionSet):
1001         (WebCore::DumpRenderTree::geolocationPermissionSet):
1002         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1003         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1004         (LayoutTestController::grantDesktopNotificationPermission):
1005         * QtTestBrowser/webpage.cpp:
1006         (WebPage::WebPage):
1007         (WebPage::requestPermission):
1008         (WebPage::cancelRequestsForPermission):
1009         * QtTestBrowser/webpage.h:
1010
1011 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
1012
1013         Reviewed by Tor Arne Vestbø.
1014
1015         [Qt] Review the setUserPermission & friends API
1016         https://bugs.webkit.org/show_bug.cgi?id=46810
1017
1018         Add a ByUser suffix to PermissionGranted/Denied. In the future
1019         we can add PermissionGrantedByDefault.
1020
1021
1022         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1023         (WebCore::WebPage::requestPermission):
1024         (WebCore::WebPage::permissionSet):
1025         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1026         (LayoutTestController::grantDesktopNotificationPermission):
1027         * QtTestBrowser/webpage.cpp:
1028         (WebPage::requestPermission):
1029
1030 2010-11-18  Satish Sampath  <satish@chromium.org>
1031
1032         Reviewed by Jeremy Orlow.
1033
1034         For speech input event, send an event object containing all the recognition results and metadata.
1035         https://bugs.webkit.org/show_bug.cgi?id=49736
1036
1037         Updated DRT by renaming the mock result method on all platforms to the new signature.
1038
1039         * DumpRenderTree/LayoutTestController.cpp:
1040         (addMockSpeechInputResultCallback):
1041         (LayoutTestController::staticFunctions):
1042         * DumpRenderTree/LayoutTestController.h:
1043         * DumpRenderTree/chromium/LayoutTestController.cpp:
1044         (LayoutTestController::LayoutTestController):
1045         (LayoutTestController::addMockSpeechInputResult):
1046         * DumpRenderTree/chromium/LayoutTestController.h:
1047         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1048         (LayoutTestController::addMockSpeechInputResult):
1049         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1050         (LayoutTestController::addMockSpeechInputResult):
1051         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1052         (LayoutTestController::addMockSpeechInputResult):
1053         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1054         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1055         (LayoutTestController::addMockSpeechInputResult):
1056         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1057         (LayoutTestController::addMockSpeechInputResult):
1058
1059 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
1060
1061         Reviewed by Tony Chang.
1062
1063         Fix some spacing issues with log messages with
1064         new-run-webkit-tests --verbose.
1065
1066         https://bugs.webkit.org/show_bug.cgi?id=49936
1067
1068         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1069
1070 2010-11-22  Ojan Vafai  <ojan@chromium.org>
1071
1072         Reviewed by Adam Barth.
1073
1074         update scm to work with different remote branches
1075         https://bugs.webkit.org/show_bug.cgi?id=49949
1076
1077         This works if there are multiple svn tracking branches
1078         and/or if the tracking branch is refs/remots/origin/master
1079         instead of refs/remotes/trunk which is the direction we're trying
1080         to head since that makes fetches faster.
1081
1082         * Scripts/webkitpy/common/checkout/scm.py:
1083         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1084
1085 2010-11-22  Hayato Ito  <hayato@chromium.org>
1086
1087         Reviewed by Shinichiro Hamaji.
1088
1089         Ignore reference files which will be used by reftests when collecting
1090         test cases.
1091         https://bugs.webkit.org/show_bug.cgi?id=49835
1092
1093         * Scripts/webkitpy/layout_tests/port/test_files.py:
1094         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1095
1096 2010-11-22  Adam Roben  <aroben@apple.com>
1097
1098         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
1099
1100         Apple's Windows build allows placing header files and import libraries for WebKit's
1101         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
1102         $WebKitLibrariesDir environment variable. This is both required for production builds and
1103         convenient for Apple-internal developer builds. Apple's production builds also require that
1104         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
1105         builds, the files are copied into that directory tree by the
1106         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
1107         copying is done by
1108         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
1109
1110         This .vsprops copying is problematic in one very important case: when a developer updates
1111         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
1112         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
1113         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
1114         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
1115         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
1116         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
1117
1118         To fix this, we now use normal relative paths to access the .vsprops files in the source
1119         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
1120         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
1121         unset, so the normal relative paths are used to read the .vsprops files out of the source
1122         tree directly. In production builds, this environment variable is set to a fake directory
1123         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
1124         is resolved.
1125         
1126         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
1127
1128         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1129
1130         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
1131         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
1132         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
1133         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
1134         FeatureDefines.vsprops becomes:
1135
1136         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1137
1138         which resolves to:
1139
1140         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
1141
1142         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
1143         actually exist since they are matched by an equal number of ".." path components.)
1144
1145         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
1146         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
1147
1148         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
1149         updated
1150
1151         Reviewed by Dave Hyatt.
1152
1153         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1154         * DumpRenderTree/win/DumpRenderTree.vcproj:
1155         * DumpRenderTree/win/ImageDiff.vcproj:
1156         * FindSafari/FindSafari.vcproj:
1157         * MiniBrowser/MiniBrowser.vcproj:
1158         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1159         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1160         * WebKitAPITest/WebKitAPITest.vcproj:
1161         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1162         * WebKitTestRunner/win/InjectedBundle.vcproj:
1163         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1164         * WinLauncher/WinLauncher.vcproj:
1165         * record-memory-win/record-memory-win.vcproj:
1166         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
1167         files.
1168
1169 2010-11-22  Adam Roben  <aroben@apple.com>
1170
1171         Make it possible to run tests on Windows without Visual Studio or VC++
1172         Express installed
1173
1174         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
1175         are not installed. But this function doesn't need to be called when we
1176         already have a build available and are just trying to run the tests.
1177
1178         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
1179         because Visual Studio/VC++ Express aren't installed
1180
1181         Reviewed by Dave Hyatt.
1182
1183         * Scripts/webkitdirs.pm:
1184         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
1185         it is not needed by this function. Also added a FIXME.
1186
1187         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
1188         relying on determineConfigurationForVisualStudio doing it.
1189
1190 2010-11-19  Hayato Ito  <hayato@chromium.org>
1191
1192         Reviewed by Shinichiro Hamaji.
1193
1194         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
1195
1196         https://bugs.webkit.org/show_bug.cgi?id=49812
1197
1198         * Scripts/webkitpy/layout_tests/driver_test.py:
1199         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1200         * Scripts/webkitpy/layout_tests/port/base.py:
1201         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1202         * Scripts/webkitpy/layout_tests/port/chromium.py:
1203         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1204         * Scripts/webkitpy/layout_tests/port/test.py:
1205         * Scripts/webkitpy/layout_tests/port/webkit.py:
1206         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1207         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1208
1209 2010-11-22  Hayato Ito  <hayato@chromium.org>
1210
1211         Reviewed by Tony Chang.
1212
1213         [NRWT] Retry a few times in reading a png image to avoid a race condition.
1214
1215         https://bugs.webkit.org/show_bug.cgi?id=49924
1216
1217         * Scripts/webkitpy/layout_tests/port/chromium.py:
1218
1219 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
1220
1221         Reviewed by Kenneth Rohde Christiansen.
1222
1223         Fix EWebLauncher zoom discretization
1224         https://bugs.webkit.org/show_bug.cgi?id=49810
1225
1226         * EWebLauncher/main.c:
1227         (nearest_zoom_level_get):
1228         (zoom_level_set):
1229         (on_load_finished):
1230         (on_key_down):
1231
1232 2010-11-21  Sam Weinig  <sam@webkit.org>
1233
1234         Rubber-stamped by Dan Bernstein.
1235
1236         Fix ~300 WebKit2 tests by enabling developer extras preference.
1237
1238         * WebKitTestRunner/TestController.cpp:
1239         (WTR::TestController::resetStateToConsistentValues):
1240
1241 2010-11-21  Sam Weinig  <sam@webkit.org>
1242
1243         Reviewed by Dan Bernstein.
1244
1245         Textareas should be resizable by default
1246         https://bugs.webkit.org/show_bug.cgi?id=49892
1247
1248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1249         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
1250         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1251         Add preferences test.
1252
1253 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
1254
1255         Reviewed by Tony Chang.
1256
1257         Rebaseline server: checksum-only differences and prefetching
1258         https://bugs.webkit.org/show_bug.cgi?id=49841
1259         
1260         Add support for image test results where the only difference is in the
1261         checksum.
1262         
1263         Add prefetching of the image results from the next test.
1264         
1265         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1266         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1267         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1268
1269 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1270
1271         Reviewed by Tony Chang.
1272
1273         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
1274
1275         Add the 'worker number' and 'worker name' concepts to the 
1276         TestShellThread objects, and move test_types and test_args from
1277         the TestRunner to the TestShellThread.
1278
1279         https://bugs.webkit.org/show_bug.cgi?id=49768
1280
1281         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1282         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1283
1284 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1285
1286         Reviewed by Ojan Vafai.
1287
1288         Do some minor cleanup and bug fixing.
1289
1290         https://bugs.webkit.org/show_bug.cgi?id=49777
1291
1292         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1293         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1294
1295 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
1296
1297         Reviewed by Ojan Vafai.
1298
1299         nrwt - config.build_directory() is busted
1300
1301         Fixes a typo that was causing us to usually return the top level
1302         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
1303         bug was hidden by test stubs that were too simplistic :(.
1304
1305         https://bugs.webkit.org/show_bug.cgi?id=49815
1306
1307         * Scripts/webkitpy/common/system/executive_mock.py:
1308         * Scripts/webkitpy/layout_tests/port/config.py:
1309         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1310
1311 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
1312
1313         Reviewed by Adam Roben.
1314
1315         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
1316         https://bugs.webkit.org/show_bug.cgi?id=49819
1317
1318         * DumpRenderTree/DumpRenderTree.sln:
1319         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1320         * DumpRenderTree/win/DumpRenderTree.vcproj:
1321         * DumpRenderTree/win/ImageDiff.vcproj:
1322         * FindSafari/FindSafari.vcproj:
1323         * MiniBrowser/MiniBrowser.vcproj:
1324         * TestWebKitAPI/win/TestWebKitAPI.sln:
1325         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1326         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1327         * WebKitAPITest/WebKitAPITest.vcproj:
1328         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1329         * WebKitTestRunner/win/InjectedBundle.vcproj:
1330         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1331         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1332         * WinLauncher/WinLauncher.vcproj:
1333         * record-memory-win/record-memory-win.vcproj:
1334
1335 2010-11-19  Adam Roben  <aroben@apple.com>
1336
1337         Add some more Windows slaves
1338
1339         This is probably more than we will be using in the immediate future,
1340         but having some extra slave names makes experimenting with different
1341         configurations easier.
1342
1343         Reviewed by Jon Honeycutt.
1344
1345         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
1346         Windows slaves and distributed them among the three different Test
1347         builders.
1348
1349 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
1350
1351         Reviewed by Ojan Vafai.
1352
1353         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
1354         https://bugs.webkit.org/show_bug.cgi?id=49702
1355
1356         Re-landing r72357 with a test fix.
1357
1358         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1359         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1360         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1361
1362 2010-11-19  Avi Drissman  <avi@google.com>
1363
1364         Reviewed by Antonio Gomes.
1365
1366         Complete support for Unix editing mode
1367         https://bugs.webkit.org/show_bug.cgi?id=49757
1368
1369         * DumpRenderTree/LayoutTestController.cpp:
1370         (setEditingBehaviorCallback):
1371         * DumpRenderTree/chromium/LayoutTestController.cpp:
1372         (LayoutTestController::setEditingBehavior):
1373
1374 2010-11-19  Adam Roben  <aroben@apple.com>
1375
1376         Fix run-javascriptcore-tests when there's a space in the path to
1377         testapi
1378
1379         Reviewed by Sam Weinig.
1380
1381         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
1382         system() to force it to interpret spaces in the path correctly.
1383
1384 2010-11-19  Adam Roben  <aroben@apple.com>
1385
1386         Update scripts for .exe name changes after r72327
1387
1388         As of r72327, the "_debug" suffix is only used in Debug_All builds.
1389
1390         Reviewed by Sam Weinig.
1391
1392         * Scripts/run-javascriptcore-tests:
1393         (testapiPath):
1394
1395         * Scripts/sunspider-compare-results:
1396         (pathToBuiltJSC):
1397
1398         * Scripts/webkitdirs.pm:
1399         (jscPath):
1400         (safariPath):
1401
1402 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
1403
1404         Reviewed by Darin Adler.
1405
1406         Normalize Cairo/CFLite project/solution configuration names
1407         https://bugs.webkit.org/show_bug.cgi?id=49818
1408
1409         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1410         * DumpRenderTree/win/DumpRenderTree.vcproj:
1411         * DumpRenderTree/win/ImageDiff.vcproj:
1412         * MiniBrowser/MiniBrowser.vcproj:
1413         * TestWebKitAPI/win/TestWebKitAPI.sln:
1414         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1415         * WebKitAPITest/WebKitAPITest.vcproj:
1416         * WebKitTestRunner/win/InjectedBundle.vcproj:
1417         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1418         * WinLauncher/WinLauncher.vcproj:
1419         * Scripts/webkitdirs.pm: Updated cairo build configs.
1420
1421 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1422
1423         Reviewed by Adam Roben.
1424
1425         Windows vcproj configuration names should be normalized across projects
1426         https://bugs.webkit.org/show_bug.cgi?id=49776
1427
1428         * DumpRenderTree/DumpRenderTree.sln:
1429         * FindSafari/FindSafari.vcproj:
1430         * TestWebKitAPI/win/TestWebKitAPI.sln:
1431         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1432         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
1433         * WebKitAPITest/WebKitAPITest.vcproj:
1434         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1435         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1436         * WebKitTestRunner/WebKitTestRunner.sln:
1437         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1438         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
1439         * record-memory-win/record-memory-win.vcproj:
1440
1441 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
1442
1443         Build fix - as per DRT-mac, always enabled developer extras,
1444         in win/qt/gtk DRT.
1445
1446         This is necessary to enable rich exception messages to be generated
1447         following https://bugs.webkit.org/show_bug.cgi?id=49708.
1448
1449         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1450         (shouldEnableDeveloperExtras):
1451         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1452         (WebCore::shouldEnableDeveloperExtras):
1453         * DumpRenderTree/win/DumpRenderTree.cpp:
1454         (shouldEnableDeveloperExtras):
1455
1456 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
1457
1458         Unreviewed, rolling out r72357.
1459         http://trac.webkit.org/changeset/72357
1460         https://bugs.webkit.org/show_bug.cgi?id=49784
1461
1462         It broke test-webkitpy tests since the patch didn't have the
1463         corresponding test update (Requested by kinuko on #webkit).
1464
1465         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1466         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1467
1468 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
1469
1470         Reviewed by Tony Chang.
1471
1472         Rebaseline server: add rebaseline queue
1473         https://bugs.webkit.org/show_bug.cgi?id=49763
1474         
1475         Add a UI queue (a multi-item <select>) where tests to be baselined
1476         can be enqueued (also supports basic removal). A queue is used instead
1477         of immediately doing rebaselines since SCM operations can take a while.
1478         It's better to go through lots of tests quickly to mark them as
1479         needing rebaselining and then batch the SCM operations.
1480         
1481         Also adds a simple log where results can be displayed.
1482
1483         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1484         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1485         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1486         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
1487         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
1488         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1489
1490 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
1491
1492         Reviewed by Oliver Hunt.
1493
1494         Bug 49708 - Stop recompiling functions to regenerate exception info.
1495
1496         Instead only hold info as necessary – keep divot info is the inspector
1497         is enabled, line number info is debugging or profiling, and handler
1498         info for functions with try/catch.
1499
1500         * DumpRenderTree/mac/DumpRenderTree.mm:
1501         (shouldEnableDeveloperExtras):
1502             - always enable the developer tools from DRT, to ensure we
1503               produce rich error messages on JavaScript exceptions.
1504
1505 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
1506
1507         Reviewed by Ojan Vafai.
1508
1509         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
1510         https://bugs.webkit.org/show_bug.cgi?id=49702
1511
1512         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1513         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1514
1515 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
1516
1517         Reviewed by Tony Chang.
1518
1519         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
1520
1521         Create the first version of the 'message_broker' package. This
1522         class will encapsulate all of the threading/multiprocessing and
1523         message-sending details for the communication between the
1524         'manager' object and the 'worker' objects. For the moment, it
1525         just holds some routines and tests for logging thread stacks.
1526
1527         There should be no functional changes in this patch, just moving stuff
1528         around.
1529
1530         https://bugs.webkit.org/show_bug.cgi?id=49707
1531
1532         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1533         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
1534         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
1535         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
1536         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1537         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1538
1539 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1540
1541         Reviewed by Adam Roben.
1542
1543         Remove leftover Windows Debug_Internal configurations
1544         https://bugs.webkit.org/show_bug.cgi?id=49758
1545
1546         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1547         * DumpRenderTree/win/DumpRenderTree.vcproj:
1548         * DumpRenderTree/win/ImageDiff.vcproj:
1549         * MiniBrowser/MiniBrowser.vcproj:
1550         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1551         * WebKitAPITest/WebKitAPITest.vcproj:
1552         * WebKitTestRunner/win/InjectedBundle.vcproj:
1553         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1554         * WinLauncher/WinLauncher.vcproj:
1555
1556 2010-11-18  Adam Roben  <aroben@apple.com>
1557
1558         Add three new Windows XP build slaves
1559
1560         Reviewed by Steve Falkenburg.
1561
1562         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
1563         new slaves, and added them to the Windows XP Debug (Tests) builder.
1564
1565 2010-11-18  Daniel Bates  <dbates@rim.com>
1566
1567         Reviewed by Adam Roben.
1568
1569         update-webkit-support-libs should fall back to existing
1570         WebKitSupportLibrary version if there is no internet connectivity
1571         https://bugs.webkit.org/show_bug.cgi?id=49503
1572
1573         Fall back to existing support libraries (if present) when there is
1574         no internet connection.
1575
1576         Currently, update-webkit-support-libs dies with an "out-of-date"
1577         error when there is no internet connection because it cannot
1578         retrieve versioning information from developer.apple.com. Because
1579         update-webkit-support-libs fails, build-webkit fails. Instead,
1580         if there is no internet connection and the support libraries are
1581         present then we should warn the user and exit() with success so
1582         that build-webkit can work without an internet connection.
1583
1584         * Scripts/update-webkit-support-libs:
1585
1586 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1587
1588         Reviewed by Adam Roben.
1589
1590         Debug_Internal Windows configuration is unnecessary, should be removed
1591         https://bugs.webkit.org/show_bug.cgi?id=49753
1592
1593         * DumpRenderTree/win/DumpRenderTree.cpp:
1594         * MiniBrowser/win/stdafx.h:
1595         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1596         * WebKitTestRunner/win/TestControllerWin.cpp:
1597
1598 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
1599
1600         Reviewed by Adam Roben.
1601
1602         Clean up vcproj errors
1603         https://bugs.webkit.org/show_bug.cgi?id=49741
1604
1605         * MiniBrowser/MiniBrowser.vcproj:
1606         * WebKitAPITest/WebKitAPITest.vcproj:
1607         * WebKitTestRunner/win/InjectedBundle.vcproj:
1608         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1609
1610 2010-11-18  Hayato Ito  <hayato@chromium.org>
1611
1612         Reviewed by Shinichiro Hamaji.
1613
1614         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
1615         which is caused by r72249.
1616
1617         https://bugs.webkit.org/show_bug.cgi?id=49751
1618
1619         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1620
1621 2010-11-18  Adam Roben  <aroben@apple.com>
1622
1623         Implement layoutTestController.waitForPolicyDelegate on Windows
1624
1625         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
1626
1627         Reviewed by Simon Fraser.
1628
1629         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1630         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
1631         code from LayoutTestControllerMac.mm.
1632
1633 2010-11-18  Hayato Ito  <hayato@chromium.org>
1634
1635         Reviewed by Shinichiro Hamaji.
1636
1637         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
1638
1639         https://bugs.webkit.org/show_bug.cgi?id=49740
1640
1641         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1642
1643 2010-11-18  Tony Chang  <tony@chromium.org>
1644
1645         Reviewed by Adam Barth.
1646
1647         run platform/chromium/plugins/refcount-leaks.html on all platforms
1648         https://bugs.webkit.org/show_bug.cgi?id=49485
1649
1650         Add PluginObject.testObjectCount which returns the number of allocated
1651         TestObjects. Add PluginObject.testCreateTestObject which allocates
1652         and returns a TestObject.
1653
1654         Add TestObject.refCount which returns the number of refs on the
1655         TestObject.
1656
1657         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1658         (pluginGetProperty):
1659         (pluginInvoke):
1660         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
1661         (getTestObjectCount):
1662         (testAllocate):
1663         (testDeallocate):
1664         (testGetProperty):
1665         (testScriptObjectInvoke): Release a ref to a plugin object that was
1666             previously leaked.
1667         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
1668
1669 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1670
1671         Reviewed by Adam Roben.
1672
1673         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
1674         https://bugs.webkit.org/show_bug.cgi?id=49711
1675
1676         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
1677         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
1678         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
1679         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1680         * record-memory-win/record-memory-win-common.vsprops: Added.
1681         * record-memory-win/record-memory-win.vcproj:
1682
1683 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
1684
1685         Reviewed by Csaba Osztrogonác.
1686
1687         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
1688
1689         * MiniBrowser/qt/BrowserWindow.cpp:
1690         (BrowserWindow::updateUserAgentList):
1691
1692 2010-11-17  Adam Roben  <aroben@apple.com>
1693
1694         Don't trigger Windows builds when chromium-win test results change
1695
1696         Reviewed by Mark Rowe.
1697
1698         * Scripts/webkitpy/common/config/build.py:
1699         (_should_file_trigger_build): Changed the regular expression used to
1700         search for directory names to only consider full directory names,
1701         rather than matching directory names where the string we care about is
1702         a suffix of the name.
1703
1704         * Scripts/webkitpy/common/config/build_unittest.py:
1705         (ShouldBuildTest): Added a test.
1706
1707 2010-11-17  Hayato Ito  <hayato@chromium.org>
1708
1709         Reviewed by Shinichiro Hamaji.
1710
1711         Remove a uri member from TestInput class.
1712
1713         https://bugs.webkit.org/show_bug.cgi?id=49691
1714
1715         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1716         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1717
1718 2010-11-17  Adam Roben  <aroben@apple.com>
1719
1720         Move FindSafari's settings into a vsprops file
1721
1722         Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
1723
1724         Reviewed by Steve Falkenburg.
1725
1726         * FindSafari/FindSafari.vcproj:
1727         * FindSafari/FindSafariCommon.vsprops: Added.
1728
1729 2010-11-17  Adam Roben  <aroben@apple.com>
1730
1731         Use a minimum font size of 0 in DRT on Windows
1732
1733         This is the Windows equivalent of r72164.
1734
1735         Rubber-stamped by Dave Hyatt.
1736
1737         * DumpRenderTree/win/DumpRenderTree.cpp:
1738         (resetDefaultsToConsistentValues):
1739
1740 2010-11-17  Dirk Pranke  <dpranke@chromium.org>
1741
1742         Reviewed by Andreas Kling.
1743
1744         webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
1745         https://bugs.webkit.org/show_bug.cgi?id=49639
1746
1747         * Scripts/webkitpy/common/checkout/scm.py:
1748
1749 2010-11-17  Mihai Parparita  <mihaip@chromium.org>
1750
1751         Reviewed by Tony Chang.
1752
1753         Rebaseline server: add loupe for image diffs
1754         https://bugs.webkit.org/show_bug.cgi?id=49692
1755         
1756         Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
1757         enlarged area of the expected, actual and diff images side by side.
1758
1759         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1760         * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
1761         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1762         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1763
1764 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1765
1766         Reviewed by Adam Roben.
1767
1768         WebKitLauncherWin should use vsprops for shared build settings
1769         https://bugs.webkit.org/show_bug.cgi?id=49696
1770
1771         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1772         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
1773
1774 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1775
1776         Reviewed by Adam Roben.
1777
1778         WinLauncher should use vsprops for shared build settings
1779         https://bugs.webkit.org/show_bug.cgi?id=49695
1780
1781         * WinLauncher/WinLauncher.cpp:
1782         (_tWinMain):
1783         (PrintView):
1784         (WndProc):
1785         (MyEditProc):
1786         * WinLauncher/WinLauncher.vcproj:
1787         * WinLauncher/WinLauncherCommon.vsprops: Added.
1788
1789 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1790
1791         Delete unused file unintentionally added in last change.
1792
1793         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
1794
1795 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
1796
1797         Reviewed by Adam Roben.
1798
1799         DumpRenderTree on Windows should use a vsprops file for shared project settings
1800         https://bugs.webkit.org/show_bug.cgi?id=49690
1801
1802         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1803         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
1804         * DumpRenderTree/win/DumpRenderTree.vcproj:
1805         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
1806         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
1807         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
1808         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
1809         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
1810         * DumpRenderTree/win/ImageDiff.vcproj:
1811         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
1812
1813 2010-11-17  Hayato Ito  <hayato@chromium.org>
1814
1815         Refactor TestTypeBase.compare_output().
1816
1817         Introduce a TestOutput class and update compare_output() of each test
1818         types so that they can take both actual and expected TestOutput objects.
1819
1820         https://bugs.webkit.org/show_bug.cgi?id=49431
1821
1822         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1823         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
1824         * Scripts/webkitpy/layout_tests/port/base.py:
1825         * Scripts/webkitpy/layout_tests/port/chromium.py:
1826         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1827         * Scripts/webkitpy/layout_tests/port/test.py:
1828         * Scripts/webkitpy/layout_tests/port/webkit.py:
1829         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1830         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1831         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1832         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1833
1834 2010-11-17  Adam Roben  <aroben@apple.com>
1835
1836         Make each Windows Test builder use the same OS for all its slaves
1837
1838         Currently each WebKit1 Windows Test builder has one Windows XP slave
1839         and one Windows 7 slave. Having different OSes in a single builder
1840         meant that the builders would alternate between red and green when
1841         there were OS-specific failures.
1842
1843         Fixes <http://webkit.org/b/49688> Windows Test builders alternate
1844         between red and green because of multiple OS versions
1845
1846         Reviewed by Mark Rowe.
1847
1848         * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
1849         "Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
1850         Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
1851         (WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
1852         builders for the two WebKit1 builders so that they would all use the
1853         appropriate OS.
1854
1855 2010-11-17  James Robinson  <jamesr@chromium.org>
1856
1857         Reviewed by Dan Bernstein.
1858
1859         [chromium] Set minimum font size to 0 for DRT
1860         https://bugs.webkit.org/show_bug.cgi?id=49677
1861
1862         Followup for http://trac.webkit.org/changeset/72141.
1863
1864         Test: http/tests/misc/acid3.html
1865
1866         * DumpRenderTree/chromium/WebPreferences.cpp:
1867         (WebPreferences::reset):
1868
1869 2010-11-17  Andras Becsi  <abecsi@webkit.org>
1870
1871         Unreviewed build fix.
1872
1873         [Qt] Add missing file I forgot in r72220.
1874
1875         * MiniBrowser/MiniBrowser.qrc: Added.
1876
1877 2010-11-17  Andras Becsi  <abecsi@webkit.org>
1878
1879         Reviewed by Andreas Kling.
1880
1881         [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
1882         https://bugs.webkit.org/show_bug.cgi?id=49627
1883
1884         Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.
1885
1886         * MiniBrowser/MiniBrowser.qrc: Added.
1887         Add it here to prevent qmake from detecting it
1888         since it needs to be copied to the build directory.
1889         * MiniBrowser/qt/BrowserWindow.cpp:
1890         (BrowserWindow::BrowserWindow):
1891         (BrowserWindow::updateUserAgentList):
1892         (BrowserWindow::showUserAgentDialog):
1893         * MiniBrowser/qt/BrowserWindow.h:
1894         * MiniBrowser/qt/MiniBrowser.pro:
1895
1896 2010-11-17  Adam Roben  <aroben@apple.com>
1897
1898         Make changes to the Mac WebKit2 Skipped file trigger Windows builds
1899
1900         We use that file on Windows!
1901
1902         Fixes <http://webkit.org/b/49643> Changes to
1903         LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
1904
1905         Reviewed by Steve Falkenburg.
1906
1907         * Scripts/webkitpy/common/config/build.py:
1908         (_should_file_trigger_build): Added the mac-wk2 directory and make it
1909         trigger builds on SnowLeopard and Windows.
1910
1911         * Scripts/webkitpy/common/config/build_unittest.py:
1912         (ShouldBuildTest.test_should_build): Added a test.
1913
1914 2010-11-17  Satish Sampath  <satish@chromium.org>
1915
1916         Reviewed by Jeremy Orlow.
1917
1918         Clear the speech input mock explicitly before each test.
1919         https://bugs.webkit.org/show_bug.cgi?id=49660
1920
1921         * DumpRenderTree/chromium/LayoutTestController.cpp:
1922         (LayoutTestController::setMockSpeechInputResult):
1923         * DumpRenderTree/chromium/LayoutTestController.h:
1924         * DumpRenderTree/chromium/WebViewHost.cpp:
1925         (WebViewHost::speechInputController):
1926         (WebViewHost::reset): Invoke speech input mock's clearResults method.
1927         * DumpRenderTree/chromium/WebViewHost.h:
1928         (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
1929
1930 2010-11-17  Alexander Pavlov  <apavlov@chromium.org>
1931
1932         Unreviewed, specify IRC nickname in committers.py.
1933
1934         * Scripts/webkitpy/common/config/committers.py:
1935
1936 2010-11-17  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1937
1938         Reviewed by Tony Chang.
1939
1940         [NRWT] Make http locking similar to perl implementation
1941         https://bugs.webkit.org/show_bug.cgi?id=49187
1942
1943         * Scripts/webkitpy/common/system/file_lock.py: Added.
1944         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
1945         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1946
1947 2010-11-17  MORITA Hajime  <morrita@google.com>
1948
1949         Reviewed by Kent Tamura.
1950
1951         [Chromium][DRT] EventSender.contextClick() should aware spellchecking
1952         https://bugs.webkit.org/show_bug.cgi?id=49366
1953
1954         - EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries
1955           according to the spellchecker suggestion
1956         - MockSpellCheck: add fillSuggestionList to provide fake suggestions.
1957
1958         test_expectations.txt will be changed after this change is ported to test_shell.
1959         
1960         * DumpRenderTree/chromium/EventSender.cpp:
1961         (makeMenuItemStringsFor):
1962         (EventSender::contextClick):
1963         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1964         (MockSpellCheck::fillSuggestionList):
1965         (MockSpellCheck::initializeIfNeeded):
1966         * DumpRenderTree/chromium/MockSpellCheck.h:
1967         * DumpRenderTree/chromium/WebViewHost.cpp:
1968         (WebViewHost::mockSpellCheck):
1969         * DumpRenderTree/chromium/WebViewHost.h:
1970
1971 2010-11-16  Dave Hyatt  <hyatt@apple.com>
1972
1973         Reviewed by Sam Weinig.
1974
1975         Make sure the pref for minimum font size is just explicitly set to 0 every time,
1976         since the bots have 1 stuck in their plist otherwise.
1977
1978         * DumpRenderTree/mac/DumpRenderTree.mm:
1979         (resetDefaultsToConsistentValues):
1980
1981 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
1982
1983         Reviewed by Tony Chang.
1984
1985         Rebaseline server: compute diffs client-side
1986         https://bugs.webkit.org/show_bug.cgi?id=49640
1987         
1988         The image diff output from the DRT is pretty bad on some ports (at
1989         least the Mac one), so it's better to compute diffs on the client by
1990         using <canvas>.
1991
1992         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1993         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1994         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1995
1996 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
1997
1998         Reviewed by Tony Chang.
1999
2000         Rebaseline server: display test results
2001         https://bugs.webkit.org/show_bug.cgi?id=49626
2002         
2003         Adds basic result display to the rebaseline server. On the Python side
2004         this involves:
2005         - Parsing the unexpected_results.json into a dictionary.
2006         - Serving it as JSON under /results.json.
2007         (the JSON -> dict -> JSON transform isn't strictly necessary right now,
2008         but I'll need to have access to the parsed results on the Python side
2009         for follow-up changes).
2010         
2011         On the web UI side this adds:
2012         - Markup for display image and text results (expected, actual, diff),
2013           and JS for populating it.
2014         - Markup for breaking down test results by failure type and directory,
2015           and JS for populating it.
2016
2017         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2018         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2019         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2020         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
2021         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2022
2023 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2024
2025         Reviewed by Ojan Vafai.
2026
2027         See Chromium issue http://codereview.chromium.org/5133001/ - we
2028         are modifying the build bots to pass in the builder name with
2029         the "GPU" string appended instead of appending it in the code.
2030
2031         https://bugs.webkit.org/show_bug.cgi?id=49636
2032
2033         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2034
2035 2010-11-16  Steve Falkenburg  <sfalken@apple.com>
2036
2037         Reviewed by Adam Roben.
2038
2039         Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
2040         https://bugs.webkit.org/show_bug.cgi?id=49632
2041
2042         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2043         * DumpRenderTree/win/DumpRenderTree.vcproj:
2044         * DumpRenderTree/win/ImageDiff.vcproj:
2045         * MiniBrowser/MiniBrowser.vcproj:
2046         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2047         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2048         * WebKitTestRunner/win/InjectedBundle.vcproj:
2049         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2050         * WinLauncher/WinLauncher.vcproj:
2051         * record-memory-win/record-memory-win.vcproj:
2052
2053 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2054
2055         Reviewed by Ojan Vafai.
2056
2057         new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread
2058
2059         Rename the TestInfo class to TestInput to be clearer about its
2060         function, and move the checksum-reading code into dump_render_tree_thread
2061         to avoid cross-thread access.
2062
2063         https://bugs.webkit.org/show_bug.cgi?id=49573
2064
2065         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2066         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2067         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2068
2069 2010-11-16  Dave Hyatt  <hyatt@apple.com>
2070
2071         Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.
2072
2073         * DumpRenderTree/mac/DumpRenderTree.mm:
2074         (resetDefaultsToConsistentValues):
2075
2076 2010-11-16  Stephanie Lewis  <slewis@apple.com>
2077
2078         Reviewed by Geoff Garen.
2079
2080         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
2081
2082         Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock 
2083         for every WebView, and the WebKit API doesn't support that ownership model.
2084
2085         I also fixed a leak in setMockDeviceOrientation by adding a missing release.
2086
2087         * DumpRenderTree/mac/DumpRenderTree.mm:
2088         (createWebViewAndOffscreenWindow):
2089         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2090         (LayoutTestController::setMockDeviceOrientation):
2091
2092 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
2093
2094         Reviewed by Ojan Vafai.
2095
2096         new-run-webkit-tests: log the process id in --verbose mode
2097
2098         As part of the switch to multi-process mode, we should log the
2099         process id when running w/ --verbose.
2100
2101         https://bugs.webkit.org/show_bug.cgi?id=49571
2102
2103         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2104
2105 2010-11-16  Adam Roben  <aroben@apple.com>
2106
2107         Only trigger Windows builds when files that we actually use on Windows
2108         are changed
2109
2110         A new Scheduler subclass, PlatformSpecificScheduler, has been added.
2111         It uses the new webkitpy.common.config.build module to determine
2112         whether a particular change should trigger a build on a particular
2113         platform. The Windows builders have been switched to use a
2114         PlatformSpecificScheduler.
2115
2116         The logic to determine whether or not a particular change should
2117         trigger a build on a given platform has only been implemented/tested
2118         for Windows. I tried to make it easy to add more platforms in the
2119         future, but I don't have enough familiarity with all platforms to be
2120         able to implement it for them.
2121
2122         Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
2123         lots irrelevant changes (e.g., rebaselining Chromium test results)
2124
2125         Reviewed by Eric Seidel.
2126
2127         * BuildSlaveSupport/build.webkit.org-config/config.json: Use a
2128         PlatformSpecificScheduler for the Windows builders.
2129
2130         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2131         (PlatformSpecificScheduler.__init__): Added. Stores our platform, sets
2132         up a ChangeFilter that filters to our branch and will call through to
2133         our filter method, and calls up to our base class.
2134         (PlatformSpecificScheduler.filter): Calls through to
2135         build.should_build to find out whether we should trigger a build for
2136         this change.
2137
2138         * Scripts/webkitpy/common/net/build.py: Added.
2139         (_should_file_trigger_build): Uses a set of directories and regexp
2140         patterns to determine whether the given file should trigger a build on
2141         the given platform. As mentioned earlier, this has only been
2142         implemented for Windows, though I did try to make some guesses about
2143         other platforms.
2144         (should_build): Returns true if any of the files should trigger a
2145         build on the given platform.
2146
2147         * Scripts/webkitpy/common/net/build_unittest.py: Added.
2148         (ShouldBuildTest.test_should_build): Does some basic testing to make
2149         sure we're triggering builds for the right files. It only tests
2150         Windows for now, though I tried to make some guesses about other
2151         platforms.
2152
2153 2010-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
2154
2155         Reviewed by Andreas Kling.
2156
2157         [Qt] Remove synchronous QWebPage::checkPermissions signal
2158         https://bugs.webkit.org/show_bug.cgi?id=46810
2159
2160         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2161         (WebCore::WebPage::WebPage):
2162         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2163         (LayoutTestController::grantDesktopNotificationPermission): When granting
2164         permission, grant it directly on the QWebPage/Frame, that will remember it.
2165         * QtTestBrowser/webpage.cpp:
2166         (WebPage::WebPage):
2167         * QtTestBrowser/webpage.h:
2168
2169
2170 2010-11-16  Andras Becsi  <abecsi@inf.u-szeged.hu>
2171
2172         Reviewed by Csaba Osztrogonác.
2173
2174         [Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
2175
2176         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2177         (LayoutTestController::reset):
2178         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2179         (LayoutTestController::isPrinting):
2180         (LayoutTestController::setPrinting):
2181
2182 2010-11-16  Balazs Kelemen  <kbalazs@webkit.org>
2183
2184         Reviewed by Andreas Kling.
2185
2186         [Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
2187         https://bugs.webkit.org/show_bug.cgi?id=49587
2188
2189         * MiniBrowser/qt/BrowserView.cpp:
2190         (BrowserView::BrowserView): Added BackingStoreType
2191         argument to ctor. Propagating it to the QGraphicsWKView.
2192         * MiniBrowser/qt/BrowserView.h:
2193         * MiniBrowser/qt/BrowserWindow.cpp:
2194         (BrowserWindow::BrowserWindow):
2195         (BrowserWindow::newWindow): Create the new BrowserWindow
2196         with the same BackingStoreType that this instance has.
2197         * MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
2198         * MiniBrowser/qt/main.cpp:
2199         (main): Use tiled backing store if got -tiled command line argument.
2200         Avoid redundant copy of command line args.
2201
2202 2010-11-16  John Knottenbelt  <jknotten@chromium.org>
2203
2204         Reviewed by Jeremy Orlow.
2205
2206         Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
2207         https://bugs.webkit.org/show_bug.cgi?id=48506
2208
2209         This ensures that there is one mock per page WebView / WebViewHost. This is a
2210         design constraint of the DeviceOrientationClientMock because the m_controller
2211         field can only store a pointer to a single instance of the corresponding
2212         DeviceOrientationController.
2213
2214         Test: fast/dom/DeviceOrientation/no-page-cache.html
2215
2216         * DumpRenderTree/chromium/LayoutTestController.cpp:
2217         (LayoutTestController::setMockDeviceOrientation):
2218         (LayoutTestController::deviceOrientationClientMock):
2219         * DumpRenderTree/chromium/LayoutTestController.h:
2220         * DumpRenderTree/chromium/WebViewHost.cpp:
2221         (WebViewHost::deviceOrientationClientMock):
2222         (WebViewHost::deviceOrientationClient):
2223         (WebViewHost::reset):
2224         * DumpRenderTree/chromium/WebViewHost.h:
2225
2226 2010-11-15  Andras Becsi  <abecsi@webkit.org>
2227
2228         Reviewed by Andreas Kling.
2229
2230         [Qt][WK2] Avoid polling in WebKitTestRunner.
2231         https://bugs.webkit.org/show_bug.cgi?id=49542
2232
2233         Make the WK2 testing session about 10-15% faster and decrease random flakiness
2234         resulting from timing skew by removing the millisecond polling from TestControllerQt.
2235
2236         * WebKitTestRunner/TestController.cpp:
2237         (WTR::TestController::didFinishLoadForFrame):
2238         * WebKitTestRunner/TestController.h:
2239         * WebKitTestRunner/TestInvocation.cpp:
2240         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2241         * WebKitTestRunner/mac/TestControllerMac.mm:
2242         (WTR::TestController::notifyDone): Add method stub.
2243         * WebKitTestRunner/qt/TestControllerQt.cpp:
2244         (WTR::TestControllerRunLoop::instance):
2245         (WTR::TestControllerRunLoop::start):
2246         (WTR::TestControllerRunLoop::stop):
2247         (WTR::TestControllerRunLoop::TestControllerRunLoop):
2248         (WTR::TestControllerRunLoop::timerEvent):
2249         (WTR::TestController::notifyDone):
2250         (WTR::TestController::platformRunUntil):
2251         * WebKitTestRunner/win/TestControllerWin.cpp:
2252         (WTR::TestController::notifyDone): Add method stub.
2253
2254 2010-11-15  Darin Adler  <darin@apple.com>
2255
2256         * Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
2257
2258 2010-11-15  Benjamin Poulain  <benjamin.poulain@nokia.com>
2259
2260         Reviewed by Andreas Kling.
2261
2262         [Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
2263         https://bugs.webkit.org/show_bug.cgi?id=49544
2264
2265         Add the shortcut to BrowserWindow.
2266
2267         * MiniBrowser/qt/BrowserWindow.cpp:
2268         (BrowserWindow::BrowserWindow):
2269         (BrowserWindow::openLocation):
2270         * MiniBrowser/qt/BrowserWindow.h:
2271
2272 2010-11-14  David Levin  <levin@chromium.org>
2273
2274         Reviewed by Daniel Bates.
2275
2276         check-webkit-style should detect PassRefPtr usage in functions.
2277         https://bugs.webkit.org/show_bug.cgi?id=49513
2278
2279         * Scripts/webkitpy/style/checkers/cpp.py:
2280         (check_for_function_lengths): Revert a comment change that I
2281          accidentally made in r71986.
2282         (check_pass_ptr_usage): Added the code to do the check.
2283         (process_line): Added the call to check_pass_ptr_usage.
2284         (CppChecker): Added the new error category.
2285         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2286         (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for
2287          testing purposes.
2288         (PassPtrTest::*): The class/functions to unit test the new
2289          functionality.
2290
2291 2010-11-14  David Levin  <levin@chromium.org>
2292
2293         Reviewed by Shinichiro Hamaji.
2294
2295         check-webkit-style function detection and the line count style checks should be separate.
2296         https://bugs.webkit.org/show_bug.cgi?id=49512
2297
2298         * Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
2299         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to
2300           call the detection function and fix line counts in two places now that
2301           the code really only counts the lines in the body of the function.
2302
2303 2010-11-14  Andreas Kling  <kling@webkit.org>
2304
2305         Reviewed by Antonio Gomes.
2306
2307         http/tests/plugins tests print "Unhandled variable" to stderr under Qt
2308         https://bugs.webkit.org/show_bug.cgi?id=33438
2309
2310         Stifle "Unhandled variable" warning to match what the other
2311         TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
2312         simply returns NPERR_GENERIC_ERROR for unhandled variables.)
2313
2314         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2315         (webkit_test_plugin_get_value):
2316
2317 2010-11-13  David Levin  <levin@chromium.org>
2318
2319         Reviewed by Eric Seidel.
2320
2321         check-webkit-style function detection crashes on functions in templates.
2322         https://bugs.webkit.org/show_bug.cgi?id=49504
2323
2324         For example "template <bool shouldClose(const Element*)>".
2325
2326         * Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out.
2327         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex
2328           function detection test to expose this issue.
2329
2330 2010-11-12  David Levin  <levin@chromium.org>
2331
2332         Reviewed by Shinichiro Hamaji.
2333
2334         check-webkit-style function detection doesn't detect indented functions declaractions.
2335         https://bugs.webkit.org/show_bug.cgi?id=49446
2336
2337         Indented function declarations occur inside class definitions, so
2338         they are a pretty common (and worth detecting).
2339
2340         * Scripts/webkitpy/style/checkers/cpp.py:
2341           Changed regex to allow indentation.
2342           Changed the function start detection to only happen when not in a
2343           function.
2344           Changed function end detection to work based on matching braces
2345           instead of finding a close brace at the beginning of the line.
2346           Fixed close_expression to do what it says when it doesn't find
2347           the close.
2348         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Indented function test.
2349
2350 2010-11-12  Daniel Bates  <dbates@rim.com>
2351
2352         Rubber-stamped by Nikolas Zimmermann.
2353
2354         Make do-file-rename rename files in the directory WebKit2.
2355
2356         This also makes the list of searched directories in do-file-rename
2357         consistent with the list of searched directories in the script do-webcore-rename.
2358
2359         * Scripts/do-file-rename:
2360
2361 2010-11-12  Dirk Pranke  <dpranke@chromium.org>
2362
2363         Reviewed by James Robinson.
2364
2365         Attempt yet again to land the fix for bug 49360 (respecting
2366         set-webkit-configuration). We need to handle the cases where
2367         trying to run webkit-build-directory to find out where the
2368         default configuration might be fails (that shows up on some
2369         Chromium bots that apparently don't have perl installed).
2370
2371         https://bugs.webkit.org/show_bug.cgi?id=49360
2372
2373         * Scripts/webkitpy/layout_tests/port/config.py:
2374         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Added.
2375         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2376
2377 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2378
2379         Reviewed by Adam Barth.
2380
2381         webkit-patch land logs commit message twice
2382         https://bugs.webkit.org/show_bug.cgi?id=49482
2383         
2384         Don't log the comment that's used by bugzilla.close_bug_as_fixed, since
2385         that's just the commit message, which we now output following the
2386         actual commit.
2387
2388         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2389
2390 2010-11-12  Tony Chang  <tony@chromium.org>
2391
2392         Reviewed by Adam Barth.
2393
2394         run platform/chromium/plugins/script-object-invoke.html on all platforms
2395         https://bugs.webkit.org/show_bug.cgi?id=49280
2396
2397         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2398         (testScriptObjectInvoke):
2399         (pluginInvoke):
2400
2401 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2402
2403         Reviewed by Adam Barth.
2404
2405         webkit-patch land-cowboy (and other commands) should display the committed SVN revision after landing a patch
2406         https://bugs.webkit.org/show_bug.cgi?id=49471
2407
2408         Right now there's no indication of a successful commit.
2409         
2410         * Scripts/webkitpy/tool/commands/download_unittest.py:
2411         * Scripts/webkitpy/tool/steps/commit.py:
2412
2413 2010-11-12  Kinuko Yasuda  <kinuko@chromium.org>
2414
2415         Reviewed by Ojan Vafai.
2416
2417         Include detailed test modifiers in results.json and enable incremental uploading for non-layout tests
2418         https://bugs.webkit.org/show_bug.cgi?id=49354
2419
2420         Also moved/integrated the upload method from run_webkit_tests.py to json_results_generator.py.
2421
2422         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2423         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2424         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2425         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2426
2427 2010-11-12  Tony Chang  <tony@chromium.org>
2428
2429         Reviewed by Kent Tamura.
2430
2431         [chromium] Load a blank page when closing DRT WebViewHosts
2432         https://bugs.webkit.org/show_bug.cgi?id=49417
2433
2434         In test_shell, when we close a window, we first load about:blank
2435         and run GC to fire the destruction logic of the page.  In test_shell,
2436         this happens in ~TestShell.  In DRT, we manage virtual windows as
2437         WebViewHosts, so we need to replicate this logic in ~WebViewHost.
2438
2439         Managing focus is a bit trickier, since normally you would get window
2440         events to reset the focus to the right window.  We do it manually
2441         instead.
2442
2443         This fixes 2 plugin tests on DRT.
2444
2445         * DumpRenderTree/chromium/TestShell.cpp:
2446         (TestShell::~TestShell): Move window close logic to ~WebViewHost.
2447         (TestShell::closeWindow): Move widget close() to WVH destructor and
2448             manage focus manually.
2449         (TestShell::closeRemainingWindows): Comment typo.
2450         * DumpRenderTree/chromium/WebViewHost.cpp:
2451         (WebViewHost::closeWidget):
2452         (invokeCloseWidget):
2453         (WebViewHost::closeWidgetSoon): Close the window asynchronously (matches
2454             test_shell).
2455         (WebViewHost::~WebViewHost):
2456         * DumpRenderTree/chromium/WebViewHost.h:
2457
2458 2010-11-12  David Levin  <levin@chromium.org>
2459
2460         Reviewed by Adam Barth.
2461
2462         cpp.py needs some tidying.
2463         https://bugs.webkit.org/show_bug.cgi?id=49443
2464
2465         * Scripts/webkitpy/style/checkers/cpp.py:
2466           Fix parameter ordering for iteratively_replace_matches_with_char
2467           to mirror other similar functions (and improved comments, etc.)
2468           Also, use a python-ism (for/else) to get rid of a variable that
2469           was there to determine if something had been found in the loop.
2470
2471 2010-11-12  Robert Kroeger  <rjkroege@chromium.org>
2472
2473         Reviewed by James Robinson.
2474
2475         [Chromium/DRT] Make EventSendingController send complete touch events.
2476         https://bugs.webkit.org/show_bug.cgi?id=49285
2477
2478         * DumpRenderTree/chromium/EventSender.cpp:
2479         (EventSender::addTouchPoint):
2480         (EventSender::updateTouchPoint):
2481         (EventSender::sendCurrentTouchEvent):
2482
2483 2010-11-12  Mihai Parparita  <mihaip@chromium.org>
2484
2485         Unreviewed rollout of r71858.
2486
2487         Rollout out r71858 since it breaks new-run-webkit-httpd as used by the
2488         NaCl tests.
2489
2490         * Scripts/webkitpy/layout_tests/port/config.py:
2491         * Scripts/webkitpy/layout_tests/port/config_standalone.py: Removed.
2492         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2493
2494 2010-11-12  Benjamin Poulain  <benjamin.poulain@nokia.com>
2495
2496         Reviewed by Kenneth Rohde Christiansen.
2497
2498         [Qt] TestController::runUntil doesn't honor the timeout parameter
2499         https://bugs.webkit.org/show_bug.cgi?id=48941
2500
2501         Implement the missing timeout of WebKitTestRunner for Qt.
2502
2503         A QElapsedTimer has been added to RunUntilConditionLoop in order
2504         to measure how long the loop has been running. When the timer
2505         is bigger or equal than the timeout, the loop ends even if the
2506         condition is not met.
2507
2508         * WebKitTestRunner/qt/TestControllerQt.cpp:
2509         (WTR::RunUntilConditionLoop::start):
2510         (WTR::RunUntilConditionLoop::run):
2511         (WTR::RunUntilConditionLoop::timerEvent):
2512         (WTR::TestController::platformRunUntil):
2513
2514 2010-11-11  David Levin  <levin@chromium.org>
2515
2516         Reviewed by Shinichiro Hamaji.
2517
2518         check-webkit-style function detection doesn't handle templates with spaces.
2519         https://bugs.webkit.org/show_bug.cgi?id=49427
2520
2521         * Scripts/webkitpy/style/checkers/cpp.py: Stripped out templates when
2522           finding the function name.
2523         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test have a
2524           template with a space.
2525
2526 2010-11-11  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2527
2528         Reviewed by Shinichiro Hamaji.
2529
2530         Enable check-webkit-style on Qt files
2531         https://bugs.webkit.org/show_bug.cgi?id=48322
2532
2533         Adding exception for _q_... private slots and
2534         ..._data() methods in tests
2535
2536         * Scripts/webkitpy/style/checker.py: enable Qt dirs, add exceptions
2537         * Scripts/webkitpy/style/checker_unittest.py: improve unittests
2538
2539 2010-11-11  David Levin  <levin@chromium.org>
2540
2541         Reviewed by Shinichiro Hamaji.
2542
2543         check-webkit-style function detection doesn't work for templates and destructors.
2544         https://bugs.webkit.org/show_bug.cgi?id=49425
2545
2546         * Scripts/webkitpy/style/checkers/cpp.py: Changed regex for templates and destructors.
2547         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Made the test hit this issue.
2548
2549 2010-11-11  Joone Hur  <joone@kldp.org>
2550
2551         Reviewed by Antonio Gomes.
2552
2553         [GTK][DRT] Implement LayoutTestController::nodesFromRect
2554         https://bugs.webkit.org/show_bug.cgi?id=46598
2555
2556         Support nodesFromRect in DRT
2557
2558         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2559         (LayoutTestController::nodesFromRect):
2560
2561 2010-11-11  MORITA Hajime  <morrita@google.com>
2562
2563         Reviewed by Kent Tamura.
2564
2565         editing/selection/context-menu-on-text.html fails on chromium
2566         https://bugs.webkit.org/show_bug.cgi?id=45898
2567
2568         Enhance Chromium's EventSender::contextClick() to return
2569         array of menu strings. The implementation incomplete because
2570         Although actual context menu is implemented by the browser,
2571         it reflects editability of underlying context thus makes
2572         context-menu-on-text.html passed.
2573         
2574         * DumpRenderTree/chromium/EventSender.cpp:
2575         (makeMenuItemStringsFor): Added.
2576         (EventSender::contextClick): Now returns array of menu strings.
2577         * DumpRenderTree/chromium/WebViewHost.cpp:
2578         (WebViewHost::showContextMenu): Now storing given WebContextMenuData object.
2579         (WebViewHost::clearContextMenuData): Added.
2580         (WebViewHost::lastContextMenuData): Added.
2581         * DumpRenderTree/chromium/WebViewHost.h:
2582
2583 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2584
2585         Unreviewed, build fix.
2586
2587         fix build breakage caused by fix for bug 49380 (r71858).
2588
2589         config_standalone needs to ensure that the packages it needs are
2590         in sys.path.
2591
2592         https://bugs.webkit.org/show_bug.cgi?id=49419
2593
2594         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2595
2596 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2597
2598         Reviewed by Adam Roben.
2599
2600         Fix NRWT to respect set-webkit-configuration again :(
2601
2602         This change fixes a typo in config.py that was causing the wrong
2603         value to be read initially and us never actually looking into
2604         the filesystem to get the default configuration.
2605         
2606         * Scripts/webkitpy/layout_tests/port/config.py:
2607         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2608         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2609
2610 2010-11-11  Eric Seidel  <eric@webkit.org>
2611
2612         Reviewed by Adam Barth.
2613
2614         Split out Bug, Attachment and CommitterValidator from bugzilla.py
2615         https://bugs.webkit.org/show_bug.cgi?id=49403
2616
2617         CommitterValidator really had nothing to do with bugzilla.py.
2618         I've put it next to committers.py for now since its rather tied to that file.
2619
2620         * Scripts/webkitpy/common/config/committervalidator.py: Added.
2621         * Scripts/webkitpy/common/config/committervalidator_unittest.py: Added.
2622         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
2623         * Scripts/webkitpy/common/net/bugzilla/attachment.py: Added.
2624         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added.
2625         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: Added.
2626         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2627         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2628         * Scripts/webkitpy/tool/bot/feeders.py:
2629         * Scripts/webkitpy/tool/commands/queues.py:
2630
2631 2010-11-11  Dirk Pranke  <dpranke@chromium.org>
2632
2633         Reviewed by Eric Seidel.
2634
2635         fix missing 'pid' argument for http lockfile checking on win32
2636         https://bugs.webkit.org/show_bug.cgi?id=49363
2637
2638         * Scripts/webkitpy/common/system/executive.py:
2639
2640 2010-11-11  Eric Seidel  <eric@webkit.org>
2641
2642         Rubber-stamped by Adam Barth.
2643
2644         Move bugzilla.py into its own module in preparation for splitting one-file-per-class
2645         https://bugs.webkit.org/show_bug.cgi?id=49402
2646
2647         * Scripts/webkitpy/common/net/bugzilla/__init__.py: Added.
2648         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla.py.
2649         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/bugzilla_unittest.py.
2650
2651 2010-11-10  Chris Guillory  <chris.guillory@google.com>
2652
2653         Reviewed by Chris Fleizach.
2654
2655         Use IAccessibleComparable to compare accessibility objects.
2656         https://bugs.webkit.org/show_bug.cgi?id=49118
2657
2658         * DumpRenderTree/AccessibilityUIElement.cpp:
2659         (AccessibilityUIElement::isEqual):
2660         * DumpRenderTree/AccessibilityUIElement.h:
2661         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2662         (comparableObject):
2663         (AccessibilityUIElement::isEqual):
2664
2665 2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>
2666
2667         Reviewed by David Hyatt.
2668
2669         HTML5 Ruby support should be mandatory feature
2670         https://bugs.webkit.org/show_bug.cgi?id=49272
2671
2672         Remove Ruby as optional feature.
2673
2674         * Scripts/build-webkit:
2675
2676 2010-11-10  Adam Roben  <aroben@apple.com>
2677
2678         Print VC++ Express build logs in the same order that the projects are
2679         built
2680
2681         Fixes <http://webkit.org/b/49326> print-vse-failure-logs prints logs
2682         in an unhelpful order
2683
2684         Reviewed by Eric Seidel.
2685
2686         * Scripts/print-vse-failure-logs:
2687         (PrintVisualStudioExpressLogs._build_order): Added. Uses
2688         print-msvc-project-dependencies to figure out the order in which
2689         projects are built.
2690         (PrintVisualStudioExpressLogs._sort_buildlogs): Added. Sorts the logs
2691         based on their build order and project name.
2692         (PrintVisualStudioExpressLogs._obj_directory): Moved code to find the
2693         scripts directory from here...
2694         (PrintVisualStudioExpressLogs._scripts_directory): ...to here.
2695         (PrintVisualStudioExpressLogs.main): Sort the logs before printing
2696         them.
2697
2698 2010-11-10  Adam Roben  <aroben@apple.com>
2699
2700         Only print the interesting text from VC++ Express build logs
2701
2702         Fixes <http://webkit.org/b/49325> It's hard to find the interesting
2703         output from print-vse-failure-logs
2704
2705         Reviewed by Eric Seidel.
2706
2707         * Scripts/print-vse-failure-logs: Removed unnecessary os.path import,
2708         added newly-required imports. Removed a comment that was essentially a
2709         FIXME, and is now fixed.
2710         (PrintVisualStudioExpressLogs._relevant_text): Added. Uses
2711         BeautifulSoup to extract the relevant text from the build log.
2712         (PrintVisualStudioExpressLogs.main): Only print the relevant text.
2713
2714 2010-11-09  Mihai Parparita  <mihaip@chromium.org>
2715
2716         Reviewed by Tony Chang.
2717
2718         [Chromium] http/tests/security/XFrameOptions fail with Chromium DRT
2719         https://bugs.webkit.org/show_bug.cgi?id=49286
2720         
2721         The tests in http/tests/security/XFrameOptions started to fail after
2722         r71297, since it changed the WebViewHost::assignIdentifierToRequest
2723         logic to always assign identifiers to requests, even if we're not going
2724         to be dumping resource load callbacks at that point. These tests
2725         only call LayoutTestController.dumpResourceLoadCallbacks after the
2726         request is started, thus their expectations have "<unknown>" as the
2727         identifier. Change WebViewHost to the previous behavior, which also
2728         match the other ports'.
2729
2730         * DumpRenderTree/chromium/WebViewHost.cpp:
2731         (WebViewHost::assignIdentifierToRequest):
2732         (WebViewHost::removeIdentifierForRequest):
2733
2734 2010-11-08  Tony Chang  <tony@chromium.org>
2735
2736         Reviewed by Adam Barth.
2737
2738         run platform/chromium/plugins/return-npobject.html on all platforms
2739         https://bugs.webkit.org/show_bug.cgi?id=49103
2740
2741         This tests that we can get an NPObject returned through a method on
2742         an NPAPI Object.
2743
2744         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2745         (testCallbackReturn):
2746         (pluginInvoke):
2747
2748 2010-11-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2749
2750         Unreviewed, rolling out r71672.
2751         http://trac.webkit.org/changeset/71672
2752         https://bugs.webkit.org/show_bug.cgi?id=49276
2753
2754         It doesn't work on Chromium Windows bot (Requested by Ossy on
2755         #webkit).
2756
2757         * Scripts/webkitpy/common/system/file_lock.py: Removed.
2758         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
2759         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2760
2761 2010-11-09  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2762
2763         Reviewed by Tony Chang.
2764
2765         [NRWT] Make http locking similar to perl implementation
2766         https://bugs.webkit.org/show_bug.cgi?id=49187
2767
2768         * Scripts/webkitpy/common/system/file_lock.py: Added.
2769         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
2770         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2771
2772 2010-11-09  James Kozianski  <koz@chromium.org>
2773
2774         Reviewed by Eric Seidel.
2775
2776         Clean up imports for webkit-patch.
2777         https://bugs.webkit.org/show_bug.cgi?id=49083
2778
2779         Move some imports from commands into main.py where they are used.
2780         Move command imports into the __init__ of the commands module.
2781
2782         * Scripts/webkitpy/tool/commands/__init__.py:
2783         * Scripts/webkitpy/tool/commands/download.py:
2784         * Scripts/webkitpy/tool/commands/queues.py:
2785         * Scripts/webkitpy/tool/main.py:
2786
2787 2010-11-09  Yi Shen  <yi.4.shen@nokia.com>
2788
2789         Reviewed by Andreas Kling.
2790
2791         [Qt][QtTestBrowser] Don't erase incorrect url in the Url Bar
2792         https://bugs.webkit.org/show_bug.cgi?id=49047
2793
2794         * QtTestBrowser/mainwindow.cpp:
2795         (MainWindow::setAddressUrl):
2796
2797 2010-11-09  Andras Becsi  <abecsi@webkit.org>
2798
2799         Reviewed by Csaba Osztrogonác.
2800
2801         Improve old-run-webkit-tests --verbose to show DumpTool opening/closing
2802         https://bugs.webkit.org/show_bug.cgi?id=49252
2803
2804         * Scripts/old-run-webkit-tests:
2805
2806 2010-11-09  Csaba Osztrogonác  <ossy@webkit.org>
2807
2808         Reviewed by Tor Arne Vestbø.
2809
2810         Output of old-run-webkit-tests is buggy in verbose mode
2811         https://bugs.webkit.org/show_bug.cgi?id=49249
2812
2813         * Scripts/old-run-webkit-tests: Redundant outputs removed.
2814
2815 2010-11-08  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2816
2817         Reviewed by Martin Robinson.
2818
2819         [GTK] Link with target name set does not work
2820         https://bugs.webkit.org/show_bug.cgi?id=48865
2821
2822         When a new page is created with a name (target=myFrame), the new
2823         mainFrame could not be found because they where not stored in the
2824         same PageGroup. As PageGroup are not exposed externally so the
2825         simpliest solution is to use a global page group name. This also fixes
2826         issue with visited link coloration across pages. After this change the
2827         private function webkit_web_view_set_group_name() was no longer used
2828         so it was removed completly.
2829
2830         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2831         (createWebView):
2832
2833 2010-11-08  John Knottenbelt  <jknotten@chromium.org>
2834
2835         Reviewed by Kent Tamura.
2836
2837         WebViewHost::reset() uses placement new.
2838         https://bugs.webkit.org/show_bug.cgi?id=49069
2839
2840         WebViewHost is using placement destruction / new to simulate a fresh
2841         WebViewHost object at the same address. This is because the WebView remains
2842         open across tests and maintains a pointer to the WebViewHost.
2843         This change resets member variables explictly instead of the placement new dance.
2844
2845         * DumpRenderTree/chromium/WebViewHost.cpp:
2846         (WebViewHost::WebViewHost):
2847         (WebViewHost::reset):
2848
2849 2010-11-08  Dirk Pranke <dpranke@chromium.org>
2850
2851         Reviewed by Eric Seidel.
2852
2853         Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py. 
2854         It turns out that NRWT can't use the code in scm.find_checkout_root()
2855         because the Chromium bots don't do full checkouts of the WebKit
2856         tree; they only check out subdirectories like WebKitTools/Scripts.
2857         Until we can figure out a better approach for this, I've
2858         restored the base_dir-detecting code from NRWT, which works in
2859         any directory tree, scm or no.
2860
2861         This also restores the files modified in r71475 and r71474.
2862
2863         https://bugs.webkit.org/show_bug.cgi?id=49151
2864
2865         * WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
2866         * WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py
2867
2868 2010-11-08  Eric Seidel  <eric@webkit.org>
2869
2870         Reviewed by Adam Barth.
2871
2872         webkit-patch failure-reason explodes if a build is missing
2873         https://bugs.webkit.org/show_bug.cgi?id=49195
2874
2875         This is likely a recent regression.  Adding a unit test for this case.
2876
2877         * Scripts/webkitpy/common/net/buildbot.py:
2878         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2879
2880 2010-11-08  Dan Bernstein  <mitz@apple.com>
2881
2882         Reviewed by Darin Adler.
2883
2884         Ignore the system scrollbar setting.
2885
2886         * DumpRenderTree/mac/DumpRenderTree.mm:
2887         (resetDefaultsToConsistentValues): Set the scrollbar default.
2888
2889 2010-11-05  Adam Roben  <aroben@apple.com>
2890
2891         Make webkitpy.common.system.executive_unittest pass when running under
2892         Win32 Python
2893
2894         Fixes <http://webkit.org/b/49033>.
2895
2896         Reviewed by Dave Levin and Eric Seidel.
2897
2898         * Scripts/webkitpy/common/system/executive.py:
2899         (Executive._run_command_with_teed_output): Pass the arguments through
2900         encode_argument_if_needed rather than using Cygwin-specific code here.
2901         (Executive.run_and_throw_if_fail): Use child_process_encoding to decode
2902         the output.
2903         (Executive.run_command): Use encode_argument_if_needed to encode the
2904         arguments and child_process_encoding to decode the output.
2905         (Executive._child_process_encoding): Returns the encoding that should be
2906         used when communicating with child processes. On Windows we use mbcs,
2907         which maps to the current code page. On all other platforms we use
2908         UTF-8.
2909         (Executive._should_encode_child_process_arguments): Returns True if
2910         arguments to child processes need to be encoded. This is currently
2911         only needed on Cygwin and Win32 Python 2.x.
2912         (Executive._encode_argument_if_needed): Encode the argument using
2913         child_process_encoding if we need to encode arguments to child
2914         processes on this platform.
2915
2916         * Scripts/webkitpy/common/system/executive_unittest.py:
2917         (never_ending_command): Added. Returns arguments to run a command that
2918         will not quit until we kill it. On Windows we use wmic, on other
2919         platforms we use yes.
2920         (ExecutiveTest.test_run_command_with_unicode): Changed to expect the
2921         mbcs encoding to be used and for output from the child processes to
2922         have been roundtripped through encode/decode on Win32 Python. When
2923         UTF-8 is the encoding the roundtripping is undetectable, but with mbcs
2924         it's possible that some characters will not be able to be converted
2925         and will be replaced by question marks; the round-tripping allows us
2926         to expect this result.
2927
2928         (ExecutiveTest.test_kill_process):
2929         (ExecutiveTest.test_kill_all):
2930         Use never_ending_command instead of invoking "yes" directly. Expect an
2931         exit code of 1 when using Win32 Python, as that's what seems to happen.
2932
2933 2010-11-08  Adam Roben  <aroben@apple.com>
2934
2935         Roll out r71532
2936
2937         It broke the build for Cygwin 1.7 installs. Cygwin 1.7's default
2938         .bashrc unsets %TEMP%, which broke copy-tools.cmd.
2939
2940         * Scripts/webkitdirs.pm:
2941
2942 2010-11-08  Tony Chang  <tony@chromium.org>
2943
2944         Reviewed by Adam Barth.
2945
2946         run platform/chromium/plugins/nested-plugin-objects.html on all platforms
2947         https://bugs.webkit.org/show_bug.cgi?id=49094
2948
2949         This tests that objects created by plugins are proplery cleaned up.
2950
2951         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2952         (testPassTestObject):
2953         (pluginInvoke):
2954         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
2955         (testAllocate):
2956         (testDeallocate):
2957         (testGetProperty):
2958         (testConstruct):
2959
2960 2010-11-08  Adam Roben  <aroben@apple.com>
2961
2962         Mark Windows builds triggered from Perl as being non-interactive
2963
2964         This affects whether some of our scripts will show alerts vs. printing
2965         to the build log.
2966
2967         Fixes <http://webkit.org/b/49181> Windows build fail mysteriously when
2968         .vsprops files are updated
2969
2970         Reviewed by Steve Falkenburg.
2971
2972         * Scripts/webkitdirs.pm:
2973         (buildVisualStudioProject): Set WEBKIT_NONINTERACTIVE_BUILD to 1.
2974
2975 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2976
2977         Reviewed by Ojan Vafai.
2978
2979         Make http locking default in NRWT.
2980         https://bugs.webkit.org/show_bug.cgi?id=48053
2981
2982         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2983         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2984
2985 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2986
2987         Reviewed by Csaba Osztrogonác.
2988
2989         [NRWT] If the http lock fails we shouldn't do any locking
2990         https://bugs.webkit.org/show_bug.cgi?id=49164
2991
2992         If something goes wrong with the locking, the test should keep going.
2993
2994         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2995
2996 2010-11-08  Adam Roben  <aroben@apple.com>
2997
2998         Switch back to using kCGImageAlphaPremultipliedFirst when generating
2999         pixel dumps on Windows
3000
3001         I changed this behavior in r71418 thinking that it was required for
3002         getting plugins to show up in pixel dumps. But it doesn't seem to be
3003         necessary, and was making it impossible to compare new Windows pixel
3004         dumps with existing Windows or Mac pixel dumps (because ImageDiff won't
3005         compare an image with alpha to an image without alpha).
3006
3007         Fixes <http://webkit.org/b/49172> REGRESION (r71418): Can't compare
3008         new Windows pixel results to existing Windows or Mac results
3009
3010         Reviewed by Antti Koivisto.
3011
3012         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3013         (createBitmapContextFromWebView): Replaced kCGImageAlphaNoneSkipFirst
3014         with kCGImageAlphaPremultipliedFirst.
3015
3016 2010-11-08  Csaba Osztrogonac  <ossy@webkit.org>
3017
3018         Unreviewed, rolling out r71466.
3019         http://trac.webkit.org/changeset/71466
3020         https://bugs.webkit.org/show_bug.cgi?id=48865
3021
3022         It broke layout tests on GTK bots.
3023
3024         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3025         (createWebView):
3026
3027 2010-11-08  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3028
3029         Reviewed by Csaba Osztrogonác.
3030
3031         Enable running of Qt API tests on BuildBot
3032         https://bugs.webkit.org/show_bug.cgi?id=49004
3033
3034         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3035
3036 2010-11-08  Eric Seidel  <eric@webkit.org>
3037
3038         Reviewed by Adam Barth.
3039
3040         Add clean-review-queue command to remove closed bugs from the webkit.org/pending-review
3041         https://bugs.webkit.org/show_bug.cgi?id=49160
3042
3043         Bugzilla doesn't automatically remove r? when a bug gets closed.
3044         This script takes care of that for webkit.org.
3045
3046         * Scripts/webkitpy/common/net/bugzilla.py:
3047         * Scripts/webkitpy/tool/commands/upload.py:
3048
3049 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
3050
3051         Unreviewed, rolling out r71474.
3052         http://trac.webkit.org/changeset/71474
3053         https://bugs.webkit.org/show_bug.cgi?id=48280
3054
3055         breaks chromium webkit tests
3056         https://bugs.webkit.org/show_bug.cgi?id=49151
3057
3058         * Scripts/webkitpy/layout_tests/port/base.py:
3059         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3060         * Scripts/webkitpy/layout_tests/port/config.py:
3061         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3062         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3063         * Scripts/webkitpy/layout_tests/port/webkit.py:
3064         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3065         * Scripts/webkitpy/tool/mocktool.py:
3066
3067 2010-11-07  Fumitoshi Ukai  <ukai@chromium.org>
3068
3069         Unreviewed, rolling out r71475.
3070         http://trac.webkit.org/changeset/71475
3071  
3072         breaks chromium webkit tests
3073         https://bugs.webkit.org/show_bug.cgi?id=49151
3074
3075         * Scripts/webkitpy/common/newstringio.py: Removed.
3076         * Scripts/webkitpy/common/newstringio_unittest.py: Removed.
3077         * Scripts/webkitpy/common/system/executive_mock.py: Removed.
3078         * Scripts/webkitpy/common/system/filesystem_mock.py: Removed.
3079         * Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
3080
3081 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3082
3083         Unreviewed, build fix.
3084
3085         Add files inexplicably not committed in r71474 as part of the
3086         fix for bug 48280.
3087
3088         * Scripts/webkitpy/common/newstringio.py: Added.
3089         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
3090         * Scripts/webkitpy/common/system/executive_mock.py: Added.
3091         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
3092         * Scripts/webkitpy/layout_tests/port/config_mock.py: Added.
3093
3094 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3095
3096         Reviewed by Eric Siedel.
3097
3098         new-run-webkit-tests: update port/base and port/webkit to use the
3099         new FileSystem and Config abstractions, pulling more logic out of
3100         the base Port classes into separate, mockable objects.
3101
3102         Also create a MockFileSystem object, a MockConfig object, move
3103         MockExecutive into common/system to be next to executive, and
3104         update the config object to use a FileSystem.
3105
3106         https://bugs.webkit.org/show_bug.cgi?id=48280
3107
3108         * Scripts/webkitpy/common/newstringio.py: Added.
3109         * Scripts/webkitpy/common/newstringio_unittest.py: Added.
3110         * Scripts/webkitpy/common/system/executive_mock.py: Added.
3111         * Scripts/webkitpy/common/system/filesystem_mock.py: Added.
3112         * Scripts/webkitpy/layout_tests/port/base.py:
3113         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3114         * Scripts/webkitpy/layout_tests/port/config.py:
3115         * Scripts/webkitpy/layout_tests/port/config_mock.py:
3116         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3117         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3118         * Scripts/webkitpy/layout_tests/port/webkit.py:
3119         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3120         * Scripts/webkitpy/tool/mocktool.py:
3121
3122 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3123
3124         Unreviewed, build breakage.
3125
3126         Apparently I uploaded the wrong version of the file to fix 49122
3127         and neither Eric or I noticed - it was missing a dirname() call.
3128         Fixing ...
3129
3130         https://bugs.webkit.org/show_bug.cgi?id=49122
3131
3132         * Scripts/webkitpy/common/checkout/scm.py:
3133
3134 2010-11-06  Dirk Pranke  <dpranke@chromium.org>
3135
3136         Reviewed by Eric Seidel.
3137
3138         webkitpy/tool/* unittests change cwd and don't clean up properly
3139
3140         https://bugs.webkit.org/show_bug.cgi?id=49122
3141
3142         * Scripts/webkitpy/common/checkout/scm.py:
3143
3144 2010-11-05  Chris Marrin  <cmarrin@apple.com>
3145
3146         Reviewed by Simon Fraser.
3147
3148         suspendAnimations/resumeAnimations not present in WebKit2
3149         https://bugs.webkit.org/show_bug.cgi?id=49109
3150
3151         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3152         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3153         (WTR::LayoutTestController::suspendAnimations):
3154         (WTR::LayoutTestController::resumeAnimations):
3155         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3156
3157 2010-11-05  Tony Chang  <tony@chromium.org>
3158
3159         Reviewed by David Levin.
3160
3161         cleanup style in TestNetscapePlugIn/PluginObject.cpp
3162         https://bugs.webkit.org/show_bug.cgi?id=49044
3163
3164         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3165         (getPluginClass):
3166         (pluginGetProperty):
3167         (pluginSetProperty):
3168         (variantToIdentifier):
3169         (testCallback):
3170         (getURL):
3171         (getURLNotify):
3172         (testInvokeDefault):
3173         (testGetProperty):
3174         (testDocumentOpen):
3175         (testWindowOpen):
3176         (pluginInvoke):
3177         (handleCallback):
3178         (notifyStream):
3179         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3180
3181 2010-11-05  Eric Seidel  <eric@webkit.org>
3182
3183         Reviewed by David Levin.
3184
3185         Add QueueStatusServer/__init__.py so others can run the QueueStatusServer tests
3186         https://bugs.webkit.org/show_bug.cgi?id=49032
3187
3188         I wrote this file as part of bug 47847, but I forgot to commit it.
3189         No one else noticed it missing because test-webkitpy knows how
3190         to recover in the case where it can't import QueueStatusServer
3191         (which generally occurs due to not having installed the AppEngine SDK).
3192
3193         * QueueStatusServer/__init__.py: Added.
3194         * QueueStatusServer/model/workitems_unittest.py:
3195          - Remove a test which fails.  This was probably landed (by me)
3196            from my other machine, which since this __init__.py was missing
3197            I never noticed the failure and landed this invalid test.
3198            Sadly we can't really test remove_work_item as it depends
3199            on .key() working.  .key() will throw unless the object
3200            has already been saved it seems.
3201            This may be a mis-design in our remove_work_item implementation,
3202            but for now, just removing the test.
3203
3204 2010-11-04  Adam Roben  <aroben@apple.com>
3205
3206         Teach check-webkit-style about TestNetscapePlugIn
3207
3208         Fixes <http://webkit.org/b/49030> check-webkit-style is ignorant of
3209         TestNetscapePlugIn's coding conventions
3210
3211         Reviewed by John Sullivan.
3212
3213         * Scripts/webkitpy/style/checker.py: Lump TestNetscapePlugIn in with
3214         WebKitAPITest and TestWebKitAPI in having different include order and
3215         naming conventions than WebCore. Added some comments about why the
3216         exceptions exist.
3217
3218 2010-11-04  Adam Roben  <aroben@apple.com>
3219
3220         Add a test that shows that windowed plugins are able to paint
3221
3222         Somehow we never had a test for this before.
3223
3224         Fixes <http://webkit.org/b/49029> Should add a test that shows
3225         windowed plugins can paint
3226
3227         Reviewed by Jon Honeycutt.
3228
3229         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DrawsGradient.cpp: Added.
3230         (DrawsGradient::DrawsGradient):
3231         (DrawsGradient::wndProc): We handle the WM_PAINT and WM_PRINTCLIENT messages.
3232
3233         (DrawsGradient::onPaint):
3234         (DrawsGradient::onPrintClient):
3235         These both just call through to paint.
3236
3237         (DrawsGradient::paint): Fills our client area with some gradients.
3238
3239         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Link
3240         against Msimg32.lib for ::GradientFill and added DrawsGradient.
3241
3242         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3243         (createBitmapContextFromWebView): Use WM_PRINT instead of
3244         WM_PRINTCLIENT so that ::DefWindowProc will send
3245         WM_PRINT/WM_PRINTCLIENT messages to the WebView's child windows.
3246         Replaced kCGImageAlphaPremultipledFirst with kCGImageAlphaNoneSkipFirst
3247         because GDI doesn't support alpha and kCGImageBitmapOrder32Little with
3248         kCGImageBitmapOrder32Host because, who knows, maybe someday Windows
3249         will run on a big-endian platform.
3250
3251 2010-11-04  Adam Roben  <aroben@apple.com>
3252
3253         Extract much of NPNInvalidateRectInvalidatesWindow's code into a
3254         WindowedPluginTest base class
3255
3256         The base class takes care of subclassing the plugin's window so that a
3257         custom WNDPROC is called. This will make it easier to write tests that
3258         need to handle window messages.
3259
3260         Fixes <http://webkit.org/b/49028> It's hard to write a PluginTest with
3261         a custom WNDPROC
3262
3263         Reviewed by Jon Honeycutt.
3264
3265         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
3266         (NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
3267         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow):
3268         (NPNInvalidateRectInvalidatesWindow::wndProc):
3269         (NPNInvalidateRectInvalidatesWindow::testInvalidateRect):
3270         Moved code from here to WindowedPluginTest. Changed to use window()
3271         instead of m_window.
3272
3273         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3274         Added WindowedPluginTest and added TestNetscapePlugIn/win to the
3275         include path. Also reordered the include path to make a little more
3276         sense and simplified the entry that added TestNetscapePlugIn itself to
3277         the include path.
3278
3279         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp: Added.
3280         (WindowedPluginTest::WindowedPluginTest):
3281         (WindowedPluginTest::NPP_SetWindow):
3282         (WindowedPluginTest::staticWndProc):
3283         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h: Added.
3284         (WindowedPluginTest::window):
3285         Code came from NPNInvalidateRectInvalidatesWindow.
3286
3287 2010-11-04  Adam Roben  <aroben@apple.com>
3288
3289         Add a plugin test to show that windowed plugins are clipped correctly
3290
3291         Fixes <http://webkit.org/b/49024> <rdar://problem/8487847> Windowed
3292         plugins aren't clipped in WebKit2 on Windows
3293
3294         Reviewed by Jon Honeycutt.
3295
3296         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp: Added.
3297         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Initialize members.
3298         (WindowRegionIsSetToClipRect::NPP_SetWindow): Check that our window
3299         region matches the clip rect we know we should have based on
3300         window-region-is-set-to-clip-rect.html, and check that our window class
3301         doesn't have the CS_PARENTDC style.
3302
3303         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3304         Added WindowRegionIsSetToClipRect.
3305
3306 2010-11-05  Alejandro G. Castro  <alex@igalia.com>
3307
3308         Reviewed by Martin Robinson.
3309
3310         [GTK] Avoid font hinting in the DRT
3311         https://bugs.webkit.org/show_bug.cgi?id=48548
3312
3313         Change the settings to avoid font hinting, it was causing
3314         different results depending on the distribution.
3315
3316         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3317         (initializeGtkFontSettings):
3318         * DumpRenderTree/gtk/fonts/fonts.conf:
3319
3320 2010-11-05  Eric Seidel  <eric@webkit.org>
3321
3322         Reviewed by Adam Barth.
3323
3324         build-webkit spams system.log by repeatedly checking for PBXProductDirectory in com.apple.Xcode
3325         https://bugs.webkit.org/show_bug.cgi?id=49051
3326
3327         This is a speculative fix.  The unit tests cover these methods, however
3328         I don't know if this will fully stop the system.log spam.
3329
3330         * Scripts/webkitpy/layout_tests/port/base.py:
3331         * Scripts/webkitpy/layout_tests/port/webkit.py:
3332
3333 2010-11-05  Eric Seidel  <eric@webkit.org>
3334
3335         Reviewed by Adam Barth.
3336
3337         Add basic support for showing bot id on /queue-status/ pages
3338         https://bugs.webkit.org/show_bug.cgi?id=49037
3339
3340         This support is really simple.  Eventually we'll want to
3341         show the bot id in the lock table too, but we don't have
3342         that information stored in the server yet.
3343
3344         * QueueStatusServer/handlers/queuestatus.py:
3345         * QueueStatusServer/handlers/queuestatus_unittest.py: Added.
3346         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3347
3348 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3349
3350         Reviewed by Adam Barth.
3351
3352         Create a filesystem wrapper that we can use to enforce
3353         particular conventions and use for mocking and dependency
3354         injection down the line.
3355
3356         https://bugs.webkit.org/show_bug.cgi?id=48144
3357
3358         * Scripts/webkitpy/common/system/filesystem.py: Added.
3359         * Scripts/webkitpy/common/system/filesystem_unittest.py: Added.
3360
3361 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3362
3363         Reviewed by Tony Chang.
3364
3365         run_webkit_tests_unittest fails under Python 2.5
3366         https://bugs.webkit.org/show_bug.cgi?id=49043
3367         
3368         Switch from itertools.chain.from_iterable (which was added in 2.6)
3369         to using itertools.chain directly.
3370
3371         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3372
3373 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3374
3375         Unreviewed fix to webkit-patch rebaseline-server so that it runs under
3376         Python 2.5 (it needs an import to use the with statement).
3377
3378         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3379
3380 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3381
3382         Reviewed by Adam Barth.
3383
3384         new-run-webkit-tests: split out webkit-specific configuration stuff into a new module
3385
3386         The current NRWT code has webkit-specific configuration code (like
3387         _script_path, default configuration, etc.) mixed in with
3388         layout-test-specific stuff in port/base. The configuration code
3389         should be split out into a separate module for easier mocking,
3390         testing, and isolation.
3391
3392         https://bugs.webkit.org/show_bug.cgi?id=48264
3393
3394         * Scripts/webkitpy/layout_tests/port/config.py: Added.
3395         * Scripts/webkitpy/layout_tests/port/config_unittest.py: Added.
3396
3397 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3398
3399         Reviewed by Tony Chang.
3400
3401         Rebaseline server: initial framework
3402         https://bugs.webkit.org/show_bug.cgi?id=48892
3403         
3404         Adds the basic framework for the rebaseline server (details at 
3405         http://webkit.org/b/47761). Includes the rebaseline-server webkit-patch
3406         command, which starts an HTTP server that can serve static files or
3407         invoke handler methods on a class.
3408
3409         * Scripts/webkitpy/tool/commands/__init__.py:
3410         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: Added.
3411         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: Added.
3412         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: Added.
3413         * Scripts/webkitpy/tool/commands/rebaselineserver.py: Added.
3414
3415 2010-11-04  Dirk Pranke  <dpranke@chromium.org>
3416
3417         Reviewed by James Robinson.
3418
3419         new-run-webkit-tests wasn't using DRT by default for
3420         --platform chromium-gpu
3421
3422         The default value was set to False instead of None, which meant
3423         that the platform specific logic wasn't firing to change the
3424         value to True (b/c we were afraid we'd be overriding the user
3425         preference).
3426
3427         https://bugs.webkit.org/show_bug.cgi?id=49038
3428
3429         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3430
3431 2010-11-04  Tony Chang  <tony@chromium.org>
3432
3433         Reviewed by Adam Barth.
3434
3435         make platform/chromium/plugins/multiple-plugins.html pass on all platforms
3436         https://bugs.webkit.org/show_bug.cgi?id=49026
3437
3438         Have the testObject.bar property return the string "bar".  This lets
3439         us run and pass platform/chromium/plugins/multiple-plugins.html on all
3440         platforms.
3441
3442         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
3443         (testGetProperty):
3444
3445 2010-11-04  Mihai Parparita  <mihaip@chromium.org>
3446
3447         Reviewed by Tony Chang.
3448
3449         NRWT doesn't have good test coverage for --run-chunk, --batch-size, --run-part, etc.
3450         https://bugs.webkit.org/show_bug.cgi?id=48878
3451         
3452         Add get_tests_run so that it's easy to see which tests get run (and with
3453         what batching) for a given flag combination. Flesh out the various
3454         test cases that have FIXMEs.
3455         
3456         Also fixes an off-by-one error (batch sizes were one larger than 
3457         expected) and makes --run-part also have wraparound behavior, like
3458         --run-chunk.
3459
3460         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3461         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3462         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3463
3464 2010-11-04  Erik Arvidsson  <arv@chromium.org>
3465
3466         Reviewed by Dimitri Glazkov.
3467
3468         Support box-sizing without the vendor prefix
3469         https://bugs.webkit.org/show_bug.cgi?id=36713
3470
3471         Based on patch by Peter Beverloo <peter@lvp-media.com>
3472
3473         * iExploder/htdocs/cssproperties.in: Change -webkit-box-sizing to box-sizing.
3474
3475 2010-11-04  Csaba Osztrogonác  <ossy@webkit.org>
3476
3477         Unreviewed rollout r71340, because it broke Chromium Windows bot.
3478
3479         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3480         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3481
3482 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3483
3484         Reviewed by Ojan Vafai.
3485
3486         Make http locking default in NRWT.
3487         https://bugs.webkit.org/show_bug.cgi?id=48053
3488
3489         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3490         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3491
3492 2010-11-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3493
3494         Reviewed by Eric Seidel.
3495
3496         [NRWT] Clear invalid http locks on Windows platform as well
3497         https://bugs.webkit.org/show_bug.cgi?id=48515
3498
3499         * Scripts/webkitpy/common/system/executive.py:
3500         * Scripts/webkitpy/common/system/executive_unittest.py:
3501         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3502
3503 2010-11-02  Adam Roben  <aroben@apple.com>
3504
3505         Reduce our dependence on coreutils when running Python tests
3506
3507         This patch introduces versions of the standard echo and cat utilities
3508         implemented in Python. They are probably missing features of their
3509         coreutils equivalents, but they can do what's necessary for our Python
3510         tests. This is useful on Windows, where these utilities typically
3511         aren't available.
3512
3513         Fixes <http://webkit.org/b/48883> executive_unittest relies on echo
3514         and cat utilities from coreutils, which are not present on Windows
3515
3516         Reviewed by Eric Seidel.
3517
3518         * Scripts/webkitpy/common/system/executive_unittest.py: Changed to use
3519         our Python-based echo and cat.
3520
3521         * Scripts/webkitpy/common/system/fileutils.py: Added.
3522         (make_stdout_binary): On Windows, puts sys.stdout into binary mode so
3523         that \n won't be translated into \r\n. I couldn't think of a good way
3524         to test this directly without touching the filesystem, but it is tested
3525         indirectly by echo_unittest.
3526
3527         * Scripts/webkitpy/test/cat.py: Added.
3528         (command_arguments): Returns a list for invoking cat with the given arguments.
3529         (main): Acts like a simplified version of the coreutils cat utility.
3530
3531         * Scripts/webkitpy/test/cat_unittest.py: Added.
3532         (CatTest.assert_cat): Runs cat with the given input and ensures the
3533         output matches the input.
3534         (CatTest.test_basic): Performs a simple test of cat.
3535         (CatTest.test_no_newline): Tests what happens when the input string
3536         doesn't have a trailing newline.
3537         (CatTest.test_unicode): Tests passing a unicode string to cat.
3538         (CatTest.test_as_command): Tests running cat as a separate command.
3539
3540         * Scripts/webkitpy/test/echo.py: Added.
3541         (command_arguments): Returns a list for invoking echo with the given arguments.
3542         (main): Acts like a simplified version of the coreutils echo utility.
3543
3544         * Scripts/webkitpy/test/echo_unittest.py: Added.
3545         (EchoTest.test_basic): Performs a simple test of echo.
3546         (EchoTest.test_no_newline): Tests passing -n to echo to suppress the
3547         trailing newline.
3548         (EchoTest.test_unicode): Tests passing unicode and non-unicode strings
3549         to echo.
3550         (EchoTest.test_argument_order): Tests what happens when -n is not the
3551         first argument.
3552         (EchoTest.test_empty_arguments): Tests what happens when you pass [] to
3553         echo.main.
3554         (EchoTest.test_no_arguments): Tests what happens when you call
3555         echo.main with no arguments.
3556         (EchoTest.test_as_command): Tests running echo as a separate command.
3557
3558 2010-11-04  Renata Hodovan  <reni@inf.u-szeged.hu>
3559
3560         Unreviewed: Add myself to the list of Committers.
3561
3562         * Scripts/webkitpy/common/config/committers.py:
3563
3564 2010-11-04  Andreas Kling  <kling@webkit.org>
3565
3566         Reviewed by Kenneth Rohde Christiansen.
3567
3568         [Qt] Hook into QWebPage::scrollRequested for resizes-to-contents mode
3569
3570         In RTC mode the QGraphicsWebView item is the size of the contents,
3571         scrolling works a bit differently  (we need to react to scrollRequested.)
3572
3573         Normally QGraphicsView will replay the last mouse event when scrolling,
3574         so to prevent WebKit from getting confused by this we temporarily make
3575         the QGraphicsView non-interactive.
3576
3577         * QtTestBrowser/webview.cpp:
3578         (WebViewGraphicsBased::setPage):
3579         (WebViewGraphicsBased::scrollRequested):
3580         * QtTestBrowser/webview.h:
3581
3582 2010-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3583
3584         Reviewed by Andreas Kling.
3585
3586         Use OS(MAC_OS_X) rather than PLATFORM(MAC) in TestControllerQt
3587
3588         PLATFORM(MAC) is not defined for the Qt port, as it refers to
3589         the Mac-port, not the Mac OS X operating system.
3590
3591         * WebKitTestRunner/qt/TestControllerQt.cpp:
3592         (WTR::isExistingLibrary):
3593
3594 2010-11-04  Leonid Ebril  <leonid.ebril@nokia.com>
3595
3596         Reviewed by Andreas Kling.
3597
3598         [Qt] Adding iphone user agent string the user agent list for QtTestBrowser
3599         https://bugs.webkit.org/show_bug.cgi?id=48869
3600
3601         * QtTestBrowser/useragentlist.txt:
3602
3603 2010-11-03  Adam Roben  <aroben@apple.com>
3604
3605         Always use uppercase drive names in strings returned by abspath_to_uri
3606
3607         Some versions of cygpath use lowercase drive letters while others use
3608         uppercase, which makes it hard to test the output of code that uses
3609         cygpath.
3610
3611         Fixes <http://webkit.org/b/48914> webkitpy.common.system.path_unittest
3612         fails with Cygwin 1.5
3613
3614         Reviewed by Eric Seidel.
3615
3616         * Scripts/webkitpy/common/system/path.py:
3617         (cygpath): Updated the docstring to indicate that only absolute paths
3618         should be passed for now (though relative paths will work fine).
3619         (_Cygpath.convert): Upper-case the first letter of the converted Windows path.
3620
3621 2010-11-03  George Guo  <George.Guo@Nokia.com>
3622
3623         Reviewed by Andreas Kling.
3624
3625         [Qt] QtTestBrowser : set mmp rule pageddata in Symbian
3626         https://bugs.webkit.org/show_bug.cgi?id=48767
3627     
3628         Paging is needd on Symbian devices to support benchmarks tests like
3629         dromaeo.com and Celtic Kane that need a lot of memory to run  
3630
3631         * QtTestBrowser/QtTestBrowser.pro:
3632
3633 2010-11-03  Jenn Braithwaite  <jennb@chromium.org>
3634
3635         Reviewed by Dmitry Titov.
3636
3637         Chromium: Update resource tracking when moving a frame between documents
3638         https://bugs.webkit.org/show_bug.cgi?id=48363
3639
3640         * DumpRenderTree/chromium/WebViewHost.cpp:
3641         (WebViewHost::assignIdentifierToRequest):
3642         Always put resource id in map so we can make assumptions about its
3643         presence.
3644         (WebViewHost::removeIdentifierForRequest):
3645         Added.
3646         (WebViewHost::didFinishResourceLoad):
3647         (WebViewHost::didFailResourceLoad):
3648         Check existence of resource id before removing from map.
3649         * DumpRenderTree/chromium/WebViewHost.h:
3650
3651 2010-11-03  Victor Wang  <victorw@chromium.org>
3652
3653         Reviewed by Adam Barth.
3654
3655         [Chromium] update buildbot names in chromium rebaseline tool.
3656
3657         https://bugs.webkit.org/show_bug.cgi?id=48881
3658
3659         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3660
3661 2010-11-03  Darin Adler  <darin@apple.com>
3662
3663         Updated Xcode projects by opening them with Xcode 3.2.4.
3664         Updated svn:ignore for Xcode projects.
3665
3666         * MiniBrowser/MiniBrowser.xcodeproj: Added property svn:ignore.
3667         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added property svn:ignore.
3668         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
3669         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Updated with Xcode 3.2.4.
3670
3671 2010-11-03  Adam Roben  <aroben@apple.com>
3672
3673         Stop waiting for messages from the web process after a timeout elapses
3674
3675         TestController::runUntil now takes a timeout parameter that specifies
3676         how long to wait for the condition to become true. WebKitTestRunner
3677         takes a --timeout flag that specifies how long the timeout should be.
3678         run-webkit-tests passes this flag to WebKitTestRunner so its timeout
3679         will be similar to run-webkit-tests.
3680
3681         Fixes <http://webkit.org/b/43047> <rdar://problem/8365833>
3682         WebKitTestRunner waits forever if the web process crashes
3683
3684         Reviewed by Darin Adler and Anders Carlsson.
3685
3686         * Scripts/old-run-webkit-tests:
3687         (top level): Moved the GuardMalloc timeout adjustment here from
3688         readFromDumpToolWithTimer.
3689         (openDumpTool): Make WTR use a timeout similar to but slightly shorter
3690         than the one that was specified on the command line.
3691
3692         * WebKitTestRunner/TestController.cpp:
3693         (WTR::TestController::TestController): Initialize our timeout values.
3694         (WTR::TestController::initialize): Parse the --timeout flag and use it
3695         to modify our timeout values.
3696         (WTR::TestController::resetStateToConsistentValues): Changed to use a
3697         short timeout while waiting for the web process to reset and to return
3698         a boolean indicating whether we were able to reset the web process.
3699         Uses a 5-second timeout while waiting for the process to be reset.
3700         (WTR::TestController::runTest): Changed to return a boolean indicating
3701         whether we were able to reset the web process (and thus run the test).
3702         (WTR::TestController::runUntil): Call through to platformRunUntil.
3703
3704         (WTR::TestController::runTestingServerLoop):
3705         (WTR::TestController::run):
3706         Changed to bail if any test can't be run. This will cause the process
3707         to exit. (Unfortunately this will make run-webkit-tests think we
3708         crashed; see <http://webkit.org/b/48943>.)
3709
3710         * WebKitTestRunner/TestController.h: Added platformRunUntil,
3711         m_longTimeout, and m_shortTimeout.
3712
3713         * WebKitTestRunner/TestInvocation.cpp:
3714         (WTR::TestInvocation::invoke): Use a short timeout when waiting for the
3715         initial response and a long timeout when waiting for the test to
3716         complete. Check whether runUntil timed out and print an error message
3717         if so.
3718
3719         * WebKitTestRunner/mac/TestControllerMac.mm:
3720         (WTR::TestController::platformRunUntil): Renamed from runUntil. Pass
3721         [NSDate distantPast] to -[NSRunLoop runMode:beforeDate:] so that we
3722         won't block waiting for the run loop. Only loop until the timeout
3723         elapses.
3724
3725         * WebKitTestRunner/qt/TestControllerQt.cpp:
3726         (WTR::TestController::platformRunUntil): Renamed from runUntil. Added a
3727         FIXME about honoring the timeout.
3728
3729         * WebKitTestRunner/win/TestControllerWin.cpp:
3730         (WTR::TestController::platformRunUntil): Renamed from runUntil. Use
3731         ::MsgWaitForMultipleObjectsEx to implement the timeout. Changed to use
3732         ::PeekMessageW so that we don't block waiting for messages to become
3733         available.
3734
3735 2010-11-03  Adam Roben  <aroben@apple.com>
3736
3737         Add a plugin test that evaluates JS after removing the plugin element
3738         from the document
3739
3740         This test replaces platform/win/plugins/plugin-delayed-destroy.html.
3741         That test was made to prevent a crash very similar to this one, but
3742         unfortunately tested only the mechanism that prevented the crash and
3743         not whether the crash itself was prevented. Since WebKit2 uses a
3744         different mechanism to prevent the crash, the test was failing even
3745         though WebKit2 was not vulnerable to the crash. This new test crashes
3746         if there is no mechanism in place to prevent it and passes in both
3747         WebKit1 and WebKit2.
3748
3749         Fixes <http://webkit.org/b/46711> <rdar://problem/8485903>
3750         platform/win/plugins/plugin-delayed-destroy.html fails in WebKit2
3751
3752         Reviewed by Anders Carlsson.
3753
3754         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3755         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3756         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3757         * GNUmakefile.am:
3758         Added new file.
3759
3760         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3761         (pluginDeallocate): Make sure we delete the PluginTest object. This
3762         prevents a leak and also allows us to test the crash.
3763
3764         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3765         (PluginTest::executeScript): Made this into a non-static member
3766         function.
3767
3768         (PluginTest::waitUntilDone):
3769         (PluginTest::notifyDone):
3770         Updated for changes to executeScript.
3771
3772         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added executeScript.
3773
3774         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp: Added.
3775         (EvaluateJSAfterRemovingPluginElement::EvaluateJSAfterRemovingPluginElement):
3776         Initialize ourselves and tell the test harness to wait.
3777         (EvaluateJSAfterRemovingPluginElement::NPP_DestroyStream): Remove our
3778         plugin element from the document, then execute some JavaScript. If
3779         WebKit does not have appropriate mechanisms in place, we'll be
3780         destroyed inside the first call to executeScript and crash on the
3781         second call.
3782
3783 2010-11-02  Stephen White  <senorblanco@chromium.org>
3784
3785         Reviewed by Tony Chang.
3786
3787         [chromium] Fix LayoutTestController UMRs.
3788         https://bugs.webkit.org/show_bug.cgi?id=48872
3789
3790         * DumpRenderTree/chromium/LayoutTestController.cpp:
3791         (LayoutTestController::LayoutTestController):
3792
3793 2010-11-03  Kent Tamura  <tkent@chromium.org>
3794
3795         Reviewed by Dimitri Glazkov.
3796
3797         REGRESSION: rebaseline-chromium-webkit-tests uses non-zero tolerance for
3798         image dup detection
3799         https://bugs.webkit.org/show_bug.cgi?id=48744
3800
3801         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3802          - Make a function for option parsing for ease of test
3803          - Set 0 to options.tolerance
3804         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3805          - Add a test for this change
3806
3807 2010-11-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3808
3809         Unreviewed: Add myself to the list of Committers.
3810
3811         * Scripts/webkitpy/common/config/committers.py:
3812
3813 2010-11-02  Anders Carlsson  <andersca@apple.com>
3814
3815         Fix build.
3816
3817         * TestWebKitAPI/PlatformUtilities.cpp:
3818         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
3819
3820 2010-11-02  Sam Weinig  <sam@webkit.org>
3821
3822         Reviewed by Anders Carlsson.
3823
3824         Add a way to send startup messages on the context which can be posted when a process launches
3825         <rdar://problem/8617928>
3826         https://bugs.webkit.org/show_bug.cgi?id=48838
3827
3828         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3829         (WKBundleInitialize):
3830         * TestWebKitAPI/InjectedBundleController.cpp:
3831         (TestWebKitAPI::InjectedBundleController::initialize):
3832         (TestWebKitAPI::InjectedBundleController::didReceiveMessage):
3833         * TestWebKitAPI/InjectedBundleController.h:
3834         * TestWebKitAPI/InjectedBundleMain.cpp:
3835         (WKBundleInitialize):
3836         * TestWebKitAPI/PlatformUtilities.cpp:
3837         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
3838         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
3839         (WKBundleInitialize):
3840         Update implementations of WKBundleInitialize to take an initial userData
3841         argument.  Change TestWebKitAPI to use the new initial userData to initialize
3842         each test's bundle.
3843
3844 2010-11-02  Benjamin Kalman  <kalman@google.com>
3845
3846         Reviewed by Ojan Vafai.
3847
3848         new-run-webkit-tests doesn't strip "LayoutTests/" from prefix, unlike old-run-webkit-tests
3849         https://bugs.webkit.org/show_bug.cgi?id=48794
3850
3851         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Strip the "LayoutTests/" prefix from test argument paths.
3852
3853 2010-11-02  Adam Roben  <aroben@apple.com>
3854
3855         Skip webkitpy.layout_tests.run_webkit_tests_unittest.MainTest on Cygwin
3856         Python 2.5.x
3857
3858         It is known to hang on that version of Python. See
3859         <http://webkit.org/b/48614>.
3860
3861         Reviewed by Adam Barth.
3862
3863         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Use
3864         skip_if to skip MainTest on Cygwin Python 2.5.x.
3865
3866         * Scripts/webkitpy/test/skip.py: Added.
3867         (skip_if): If the passed-in condition is false, find all the test_*
3868         methods of the given class and replace them with a function that just
3869         logs that we're skipping these tests. This is loosely based on the
3870         unittest.skip_if decorator added in Python 3.1.
3871         (_skipped_method): Returns a function that just logs that the tests are
3872         being skipped. This is used in place of the actual test_* functions.
3873
3874         * Scripts/webkitpy/test/skip_unittest.py: Added.
3875         (SkipTest.setUp): Create a logger for ourselves and give it a handler
3876         that logs to a private stream.
3877         (SkipTest.tearDown): Reset the logger.
3878         (SkipTest.create_fixture_class): Returns a class that we use to test
3879         skip_if. It has a single test_* method, test_foo, that just calls
3880         through to a callback.
3881         (SkipTest.foo_callback): Record that test_foo was called.
3882         (SkipTest.test_skip_if_false): Pass skip_if a False condition and test
3883         that test_foo does get called.
3884         (SkipTest.test_skip_if_true): Pass skip_if a True condition and test
3885         that test_foo does not get called and the appropriate message gets
3886         logged.
3887
3888 2010-11-02  Adam Barth  <abarth@webkit.org>
3889
3890         Reviewed by Eric Seidel.
3891
3892         webkit-patch should tell check-webkit-style which files were changed so
3893         check-webkit-style doesn't have to stat the whole working copy again
3894         https://bugs.webkit.org/show_bug.cgi?id=48792
3895
3896         * Scripts/webkitpy/tool/mocktool.py:
3897         * Scripts/webkitpy/tool/steps/checkstyle.py:
3898
3899 2010-11-02  Robert Kroeger  <rjkroege@chromium.org>
3900
3901         Reviewed by James Robinson.
3902
3903         [Chromium/DRT] Make EventSendingController honour leapForward for touch events.
3904         https://bugs.webkit.org/show_bug.cgi?id=48777
3905
3906         * DumpRenderTree/chromium/EventSender.cpp:
3907         (EventSender::sendCurrentTouchEvent):
3908
3909 2010-11-02  Adam Roben  <aroben@apple.com>
3910
3911         Only track resource identifiers in DRT when dumpResourceLoadCallbacks
3912         is on
3913
3914         This reverts Windows to our pre-r71097 behavior. That patch made us
3915         track all resource identifiers, including the main resource, so the
3916         main resource's URL started appearing in test output instead of
3917         "<unknown>". Arguably having the main resource's URL is better, but all
3918         other platforms print "<unknown>" and we want to match.
3919
3920         Fixes <http://webkit.org/b/48837> <rdar://problem/8620351> REGRESSION
3921         (r71097): Many http tests failing on Windows
3922
3923         Reviewed by Anders Carlsson.
3924
3925         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3926         (ResourceLoadDelegate::identifierForInitialRequest): Don't add the
3927         identifier to the URL map if we're not supposed to dump resource load
3928         callbacks.
3929         (ResourceLoadDelegate::removeIdentifierForRequest): Always remove the
3930         identifier from the URL map even if we're already "done". There's no
3931         point in keeping out-of-date identifiers around.
3932
3933 2010-11-01  Jenn Braithwaite  <jennb@chromium.org>
3934
3935         Reviewed by Adam Roben.
3936
3937         Windows: Update resource tracking when moving a frame between documents
3938         https://bugs.webkit.org/show_bug.cgi?id=48364
3939
3940         * DumpRenderTree/win/DumpRenderTree.cpp:
3941         (createWebViewAndOffscreenWindow):
3942         (main):
3943         Give each WebView its own ResourceLoadDelegate instance in order to
3944         make assertions about resource ids on a particular WebView.
3945         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3946         (ResourceLoadDelegate::identifierForInitialRequest):
3947         Always add id to the map.
3948         (ResourceLoadDelegate::removeIdentifierForRequest):
3949         Added.
3950         (ResourceLoadDelegate::willSendRequest):
3951         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3952         (ResourceLoadDelegate::didReceiveResponse):
3953         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3954         (ResourceLoadDelegate::didFailLoadingWithError):
3955         (ResourceLoadDelegate::descriptionSuitableForTestResult):
3956         Replace static descriptionSuitableForTestResult with static member function to access identifier map.
3957         * DumpRenderTree/win/ResourceLoadDelegate.h:
3958         (ResourceLoadDelegate::urlMap):
3959         Moved within class so that each WebView has its own id map.
3960
3961 2010-11-01  Ojan Vafai  <ojan@chromium.org>
3962
3963         Reviewed by Dimitri Glazkov.
3964
3965         remove debug code from run_webkit_tests.py
3966         https://bugs.webkit.org/show_bug.cgi?id=48800
3967
3968         Remove temporary debug code and make --master-name required
3969         if --test-results-server is set now that all clients set
3970         --master-name.
3971
3972         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3973
3974 2010-11-01  Tony Chang  <tony@chromium.org>
3975
3976         Reviewed by Kent Tamura.
3977
3978         add plugin event logging for linux
3979         https://bugs.webkit.org/show_bug.cgi?id=48779
3980
3981         This is taken from Chromium's fork of the layout test plugin:
3982         http://git.chromium.org/gitweb/?p=chromium.git/.git;a=blob;f=webkit/tools/npapi_layout_test_plugin/main.cpp;h=3ebdada2f049b3624756438cff852364f86a2ede;hb=HEAD#l348
3983
3984         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3985         (handleEventX11):
3986         (NPP_HandleEvent):
3987
3988 2010-11-01  Dirk Pranke  <dpranke@chromium.org>
3989
3990         Reviewed by James Robinson.
3991
3992         new-run-webkit-tests: use DRT, child-processes=1 for GPU tests by default
3993         https://bugs.webkit.org/show_bug.cgi?id=48790
3994
3995         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3996         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3997
3998 2010-11-01  Adam Barth  <abarth@webkit.org>
3999
4000         Reviewed by Eric Seidel.
4001
4002         Teach check-webkit-style how to accept a list of files to diff on the
4003         command line
4004         https://bugs.webkit.org/show_bug.cgi?id=48784
4005
4006         In a future patch, webkit-patch will use this option to improve
4007         performance.  I'm landing this in two pieces to avoid causing a version
4008         skew problem for the style-bot.
4009
4010         * Scripts/check-webkit-style:
4011         * Scripts/webkitpy/style/optparser.py:
4012         * Scripts/webkitpy/style/optparser_unittest.py:
4013         * Scripts/webkitpy/style_references.py:
4014
4015 2010-11-01  Anders Carlsson  <andersca@apple.com>
4016
4017         Reviewed by John Sullivan.
4018
4019         Tear down the related WebProcessProxy when a WebContext is deallocated
4020         https://bugs.webkit.org/show_bug.cgi?id=48769
4021
4022         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
4023         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
4024         We don't support empty URLs anymore, update test to expect a null URL instead.
4025
4026 2010-11-01  Søren Gjesse  <sgjesse@chromium.org>
4027
4028         Reviewed by Andreas Kling.
4029
4030         Fix warning when compiling the chromium port of DumpRenderShell
4031         with clang.
4032         https://bugs.webkit.org/show_bug.cgi?id=48414
4033
4034         * DumpRenderTree/chromium/TestShell.h:
4035         (TestShell::javaScriptFlagsForLoad):
4036
4037 2010-11-01  Adam Roben  <aroben@apple.com>
4038
4039         Fix typo from r71022
4040
4041         * BuildSlaveSupport/build.webkit.org-config/config.json:
4042
4043 2010-11-01  Adam Roben  <aroben@apple.com>
4044
4045         Trigger the Windows Release WebKit2 tests when a Release build
4046         finishes, not when a Debug build finishes
4047
4048         Fixes <http://webkit.org/b/48754> Windows Release WebKit2 tests are
4049         triggered at the wrong time
4050
4051         Reviewed by Sam Weinig.
4052
4053         * BuildSlaveSupport/build.webkit.org-config/config.json: Fixed
4054         triggerable name and trigger.
4055
4056 2010-11-01  Mario Sanchez Prada  <msanchez@igalia.com>
4057
4058         Unreviewed. Adding my IRC nickname to the list of committers.
4059
4060         * Scripts/webkitpy/common/config/committers.py:
4061
4062 2010-10-31  Robert Hogan  <robert@webkit.org>
4063
4064         Reviewed by Antonio Gomes.
4065
4066         [Qt] [Gtk] Plug-ins having upper case in mime type are failing to load
4067
4068         Qt and Gtk are case-sensitive when storing the declared mime-type
4069         of plugins. Since plugin mime-types are lowercased prior to searching
4070         for them in the plugin database, ensure they are loaded with the
4071         mime-type in lower case too.
4072
4073         Change the test netscape plugin to declare its mimetype in sentence
4074         case so that the correct behaviour is enforced.
4075
4076         https://bugs.webkit.org/show_bug.cgi?id=36815
4077
4078         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
4079         (NP_GetMIMEDescription):
4080
4081 2010-10-31  Robert Hogan  <robert@webkit.org>
4082
4083         Reviewed by Antonio Gomes.
4084
4085         [Qt] Support nodesFromRect in DRT
4086
4087         https://bugs.webkit.org/show_bug.cgi?id=48716
4088
4089         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4090         (LayoutTestController::nodesFromRect):
4091         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4092
4093 2010-10-30  Andreas Kling  <kling@webkit.org>
4094
4095         Reviewed by Antonio Gomes.
4096
4097         [Qt] QtTestBrowser: Switching view type moves the embedded inspector
4098         https://bugs.webkit.org/show_bug.cgi?id=48705
4099
4100         Reinsert the embedded inspector into the splitter after changing
4101         between QWebView/QGraphicsWebView.
4102
4103         * QtTestBrowser/launcherwindow.cpp:
4104         (LauncherWindow::init):
4105         (LauncherWindow::initializeView):
4106         * QtTestBrowser/webinspector.h:
4107         (WebInspector::WebInspector):
4108
4109 2010-10-28  Antonio Gomes  <agomes@rim.com>
4110
4111         Reviewed by Ojan Vafai.
4112
4113         Needs a "LinuxEditingBehavior", perhaps with a better name
4114         https://bugs.webkit.org/show_bug.cgi?id=36627
4115
4116         Adding support to Mac's, GTK+'s, Windows' and Chromium's LayoutTestController class to test the newly introduced Unix editing behavior.
4117
4118         * DumpRenderTree/chromium/LayoutTestController.cpp:
4119         (LayoutTestController::setEditingBehavior):
4120         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4121         (LayoutTestController::setEditingBehavior):
4122         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4123         (LayoutTestController::setEditingBehavior):
4124         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4125         (LayoutTestController::setEditingBehavior):
4126
4127 2010-10-29  Andreas Kling  <kling@webkit.org>
4128
4129         Reviewed by Kenneth Rohde Christiansen.
4130
4131         [Qt] QtTestBrowser: Add keyboard shortcut to toggle full screen (F11)
4132         https://bugs.webkit.org/show_bug.cgi?id=48695
4133
4134         * QtTestBrowser/launcherwindow.cpp:
4135         (LauncherWindow::createChrome):
4136
4137 2010-10-29  Andreas Kling  <kling@webkit.org>
4138
4139         Reviewed by Kenneth Rohde Christiansen.
4140
4141         [Qt] QtTestBrowser: Fix uninitialized read in FpsTimer
4142         https://bugs.webkit.org/show_bug.cgi?id=48675
4143
4144         FpsTimer::m_timer was never initialized and passed to QObject::killTimer()
4145         on startup with in -graphicsbased mode.
4146
4147         * QtTestBrowser/fpstimer.cpp:
4148         (FpsTimer::FpsTimer):
4149         (FpsTimer::numFrames):
4150         (FpsTimer::stop):
4151         (FpsTimer::timerEvent):
4152         * QtTestBrowser/fpstimer.h:
4153
4154 2010-10-29  Dirk Pranke  <dpranke@chromium.org>
4155
4156         Reviewed by Tony Chang.
4157
4158         new-run-webkit-tests: change TestResults to be serializable
4159
4160         In preparation for changing new-run-webkit-tests from
4161         multithreaded to multiprocess, we need to make sure the data
4162         going between the threads is easily serialized over a socket.
4163
4164         This change adds serialization/pickling for the TestResults and
4165         TestFailure objects (using cPickle).
4166
4167         The TestFailure objects included a "has_wdiff" flag for Text
4168         results, but the flag wasn't being used, so I've removed it,
4169         simplifying the state to basically a set of enum objects with
4170         associated methods.
4171
4172         https://bugs.webkit.org/show_bug.cgi?id=48616
4173
4174         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4175         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
4176         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
4177         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
4178         * Scripts/webkitpy/layout_tests/layout_package/test_results.py: Added.
4179         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:Added. 
4180         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4181         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
4182
4183 2010-10-29  Dirk Pranke  <dpranke@chromium.org>
4184
4185         Reviewed by Ojan Vafai.
4186
4187         new-run-webkit-tests: need to provide separate dashboard results for GPU tests
4188         https://bugs.webkit.org/show_bug.cgi?id=48687
4189
4190         Modify the steps to upload the JSON files to the dashboards so
4191         that the GPU tests don't conflict with the regular tests on a
4192         port. We do this by modifying the --builder-name parameter to
4193         append " - GPU", which should cause the app to treat the results
4194         as a completely new builder. This is a little non-obvious, but
4195         keeps us from having to restructure the app.
4196
4197         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4198         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
4199         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4200
4201 2010-10-29  Ojan Vafai  <ojan@chromium.org>
4202
4203         Reviewed by Tony Chang.
4204
4205         [chromium] add debug logging to help diagnose flakiness dashboard issues
4206         https://bugs.webkit.org/show_bug.cgi?id=48657
4207
4208         The appengine app thinks it's getting empty files uploaded. Add some logging
4209         to see if new-run-webkit-tests agrees.
4210         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4211
4212 2010-10-29  Dimitri Glazkov  <dglazkov@chromium.org>
4213
4214         Reviewed by Ojan Vafai.
4215
4216         [Chromium/DRT] Add master-name flag to new-run-webkit-tests.
4217         https://bugs.webkit.org/show_bug.cgi?id=48649
4218
4219     &n