41cbade9840d91b264283bb8fa281a3eb31b1e52
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
2
3         Unreviewed buildfix for 69297 again
4
5         * WebKitTestRunner/TestController.cpp:
6         (WTR::blankURL):
7
8 2010-10-07  Balazs Kelemen  <Balazs Kelemen>
9
10         Unreviewed trivial build fix for r69297
11
12         * WebKitTestRunner/TestController.cpp:
13         (WTR::blankURL):
14
15 2010-10-07  Balazs Kelemen  <kbalazs@webkit.org>
16
17         Reviewed by Kenneth Rohde Christiansen.
18
19         WebKitTestRunner should be portable
20         https://bugs.webkit.org/show_bug.cgi?id=45393
21
22         Use only the WebKit API for working with urls.
23         * WebKitTestRunner/StringFunctions.h:
24         (WTR::createWKURL):
25         * WebKitTestRunner/TestController.cpp:
26         (WTR::blankURL):
27         (WTR::TestController::resetStateToConsistentValues):
28         (WTR::TestController::didFinishLoadForFrame):
29
30 2010-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
31
32         Reviewed by Xan Lopez.
33
34         [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3
35         https://bugs.webkit.org/show_bug.cgi?id=47332
36
37         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
38         (createBitmapContextFromWebView):
39
40 2010-10-06  Chris Guillory  <chris.guillory@google.com>
41
42         Reviewed by Chris Fleizach.
43
44         Remove unused accessibility functions from webkit.
45         https://bugs.webkit.org/attachment.cgi?bugid=46707
46
47         * DumpRenderTree/chromium/WebViewHost.cpp:
48         (WebViewHost::postAccessibilityNotification):
49         * DumpRenderTree/chromium/WebViewHost.h:
50
51 2010-10-06  Lucas Forschler  <lforschler@apple.com>
52
53         Reviewed by Adam Roben.
54
55         Fix the sunspider-compare-results to actually use the passed in value for $root.
56
57         * Scripts/sunspider-compare-results:
58
59 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
60
61         Reviewed by Kenneth Rohde Christiansen.
62
63         [Qt] Runloop implementation for WTR
64         https://bugs.webkit.org/show_bug.cgi?id=47280
65
66         * WebKitTestRunner/qt/TestControllerQt.cpp:
67         Implemented TestController::runUntil by a timerEvent
68         and a QEventLoop. We step into the event loop from runUntil.
69         While we are waiting in the loop a timerEvent is periodically
70         checking the value of the condition. Once the condition has
71         becoming true the timerEvent wakes us up.
72         (WTR::RunUntilLoop::start):
73         (WTR::RunUntilLoop::RunUntilLoop):
74         (WTR::RunUntilLoop::run):
75         (WTR::RunUntilLoop::timerEvent):
76         (WTR::TestController::platformInitialize):
77         (WTR::TestController::runUntil):
78         * WebKitTestRunner/qt/main.cpp:
79         Start the main event loop first and creating the TestController later.
80         (Launcher::Launcher):
81         (Launcher::~Launcher):
82         (Launcher::launch): Creating the TestController.
83         (main): Setting up a timer for calling Launcher::launch from
84         the main event loop.
85
86 2010-10-06  Dirk Pranke  <dpranke@chromium.org>
87
88         Reviewed by Kenneth Russell.
89
90         new-run-webkit-tests: fix typo in chromium-gpu that was trying to
91         enable 'accelerated-composting' instead of 'accelerated-compositing'.
92
93         https://bugs.webkit.org/show_bug.cgi?id=47312
94
95         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
96         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
97
98 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
99
100         Reviewed by Kenneth Rohde Christiansen.
101
102         [Qt] PlatformWebView implementation for WebKitTestRunner
103         https://bugs.webkit.org/show_bug.cgi?id=47276
104
105         The implementation follows the way how
106         we use the API in MiniBrowser.
107         * WebKitTestRunner/PlatformWebView.h:
108         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
109         (WTR::WebView::wkView):
110         (WTR::WebView::~WebView):
111         (WTR::WebView::WebView):
112         (WTR::PlatformWebView::PlatformWebView):
113         (WTR::PlatformWebView::~PlatformWebView):
114         (WTR::PlatformWebView::resizeTo):
115         (WTR::PlatformWebView::page):
116         (WTR::PlatformWebView::focus):
117         * WebKitTestRunner/qt/WebKitTestRunner.pro:
118
119 2010-10-06  Balazs Kelemen  <kbalazs@webkit.org>
120
121         Reviewed by Kenneth Rohde Christiansen.
122
123         [Qt] Add WebKitTestRunner's build files
124         https://bugs.webkit.org/show_bug.cgi?id=44155
125
126         Parts was taken by Zoltan Horvath's patch.
127
128         * Scripts/generate-forwarding-headers.pl: Moved from WebKit2.
129         * Scripts/webkitdirs.pm: Make the generated files needed by WTR.
130         * WebKitTestRunner/PlatformWebView.h: Addeed typedefs for
131         PlatformWKView and PlatformWindow (void* for now).
132         Buildfix the case when __APPLE__ is not defined.
133         * WebKitTestRunner/qt/DerivedSources.pro: Added.
134         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Added.
135         Empty stub implementation.
136         (WTR::registerWindowClass):
137         (WTR::PlatformWebView::PlatformWebView):
138         (WTR::PlatformWebView::~PlatformWebView):
139         (WTR::PlatformWebView::resizeTo):
140         (WTR::PlatformWebView::page):
141         (WTR::PlatformWebView::focus):
142         * WebKitTestRunner/qt/TestControllerQt.cpp: Added.
143         Empty stub implementation.
144         (WTR::registerWindowClass):
145         (WTR::TestController::runUntil):
146         (WTR::TestController::platformInitialize):
147         (WTR::TestController::initializeInjectedBundlePath):
148         (WTR::TestController::initializeTestPluginDirectory):
149         (WTR::TestController::platformInitializeContext):
150         * WebKitTestRunner/qt/WebKitTestRunner.pro: Added.
151         * WebKitTestRunner/qt/main.cpp: Added.
152         (main):
153
154 2010-10-06  Tony Chang  <tony@chromium.org>
155
156         Unreviewed, rolling out r69202.
157         http://trac.webkit.org/changeset/69202
158         https://bugs.webkit.org/show_bug.cgi?id=46937
159
160         Broke compile of test_shell
161
162         * DumpRenderTree/chromium/EventSender.cpp:
163         (EventSender::beginDragWithFiles):
164         * DumpRenderTree/chromium/WebViewHost.cpp:
165         (addDRTFakeFileToDataObject):
166
167 2010-10-06  Daniel Cheng  <dcheng@chromium.org>
168
169         Reviewed by Tony Chang.
170
171         [chromium] Minor naming cleanup in WebDragData, part 2
172         https://bugs.webkit.org/show_bug.cgi?id=46937
173
174         Update DRT to use the renamed methods.
175
176         * DumpRenderTree/chromium/EventSender.cpp:
177         (EventSender::beginDragWithFiles):
178         * DumpRenderTree/chromium/WebViewHost.cpp:
179         (addDRTFakeFileToDataObject):
180
181 2010-10-06  David Kilzer  <ddkilzer@apple.com>
182
183         <http://webkit.org/b/47270> Move WebArchive serialization code into its own file
184
185         Reviewed by Adam Roben.
186
187         This is the first step in making webarchive tests work on
188         Windows.
189
190         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added
191         new files to the project.
192         * DumpRenderTree/mac/DumpRenderTree.mm: Removed code that moved
193         to WebArchiveDumpSupport.mm.
194         * DumpRenderTree/mac/WebArchiveDumpSupport.h: Added.
195         * DumpRenderTree/mac/WebArchiveDumpSupport.mm: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTree.mm.
196         (serializeWebArchiveToXML):
197
198 2010-10-05  Daniel Bates  <dbates@rim.com>
199
200         Reviewed by David Kilzer.
201
202         Add infrastructure to towards detecting change log diffs that aren't at the top of the ChangeLog
203         https://bugs.webkit.org/show_bug.cgi?id=46058
204
205         Make VCSUtils::fixChangeLogPatch() return a reference to a hash
206         structure so as to support returning additional information
207         about a change log diff.
208
209         Currently, VCSUtils::fixChangeLogPatch() returns a string that
210         represents the change log diff. Towards supporting the return
211         of additional information, such as whether the change log diff
212         inserts an entry at the top of the ChangeLog file, we need to
213         make VCSUtils::fixChangeLogPatch() return a reference to hash
214         structure.
215
216         * Scripts/VCSUtils.pm:
217           - Modified fixChangeLogPatch() to return a reference to a
218             hash structure.
219           - Added documentation to fixChangeLogPatch().
220           - Modified call site in mergeChangeLogs() as necessary.
221         * Scripts/svn-apply:
222           - Modified call site in patch() as necessary.
223         * Scripts/svn-create-patch:
224           - Modified call site in generateDiff() as necessary.
225         * Scripts/svn-unapply:
226           - Modified call site in patch() as necessary.
227         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
228           - Modified the unit tests as necessary.
229
230 2010-10-05  Tony Chang  <tony@chromium.org>
231
232         Reviewed by Darin Adler.
233
234         fix the link to the expected image on windows
235         https://bugs.webkit.org/show_bug.cgi?id=47228
236
237         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: On
238             windows, the file must be opened in binary mode when writing
239             binary data.
240
241 2010-10-05  Adam Barth  <abarth@webkit.org>
242
243         Update expected result of unittest to match Tony's change below.
244
245         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
246
247 2010-10-05  Tony Chang  <tony@chromium.org>
248
249         Reviewed by Ojan Vafai (over the shoulder).
250
251         Paper over errors in image_diff so we don't crash the whole test run.
252
253         * Scripts/webkitpy/layout_tests/port/chromium.py:
254
255 2010-10-05  Tony Chang  <tony@chromium.org>
256
257         Unreviewed, make shutil.rmtree more resiliant to errors
258         since windows was raising WindowsError: The process cannot access the file because it
259         is being used by another process.
260
261         * Scripts/webkitpy/layout_tests/port/chromium.py:
262
263 2010-10-05  Tony Chang  <tony@chromium.org>
264
265         Reviewed by Ojan Vafai.
266
267         [chromium] fix image diffing in NRWT
268         https://bugs.webkit.org/show_bug.cgi?id=47128
269
270         * Scripts/webkitpy/layout_tests/port/chromium.py: Stop using
271             NamedTemporaryFile since it doesn't work on Windows.
272         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
273
274 2010-10-05  Kenneth Russell  <kbr@google.com>
275
276         Reviewed by Tony Chang.
277
278         [chromium] Implement layerTreeAsText in DumpRenderTree
279         https://bugs.webkit.org/show_bug.cgi?id=47216
280
281         Plumbed Frame::layerTreeAsText through Chromium's WebKit API to
282         make it callable from DumpRenderTree.
283
284         No new tests; verified with existing compositor layout tests.
285
286         * DumpRenderTree/chromium/LayoutTestController.cpp:
287         (LayoutTestController::LayoutTestController):
288         (LayoutTestController::layerTreeAsText):
289         * DumpRenderTree/chromium/LayoutTestController.h:
290
291 2010-10-05  Brent Fulgham  <bfulgham@webkit.org>
292
293         Unreviewed build correction.
294
295         * DumpRenderTree/win/ImageDiff.vcproj: Use WinCairo debug
296         property sheet so proper libraries are linked.
297
298 2010-10-05  Robert Hogan  <robert@webkit.org>
299
300         Reviewed by Andreas Kling.
301
302         [Qt] Fix url conversion in QWebHistory
303
304         Converting from KURL to WFT::String to QUrl does not
305         permit proper percent encoding later.
306
307         https://bugs.webkit.org/show_bug.cgi?id=47048
308
309         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
310         (WebCore::dumpHistoryItem):
311
312 2010-10-05  Anders Carlsson  <andersca@apple.com>
313
314         Reviewed by Sam Weinig.
315
316         REGRESSION (r68966?): All dumpAsText test fail on WebKit2
317         https://bugs.webkit.org/show_bug.cgi?id=47188
318         <rdar://problem/8514104>
319
320         When constructing the std::string, use the real string length instead of the maximum buffer size.
321
322         * TestWebKitAPI/PlatformUtilities.h:
323         (TestWebKitAPI::Util::toSTD):
324         * WebKitTestRunner/StringFunctions.h:
325         (WTR::toSTD):
326
327 2010-10-04  Sam Weinig  <sam@webkit.org>
328
329         Reviewed by Mark Rowe.
330
331         Add MIMEType accessor to WKFrame
332         <rdar://problem/8347683>
333         https://bugs.webkit.org/show_bug.cgi?id=47138
334
335         * TestWebKitAPI/PlatformUtilities.h:
336         (TestWebKitAPI::Util::toSTD):
337         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
338         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp: Added.
339         (TestWebKitAPI::didStartProvisionalLoadForFrame):
340         (TestWebKitAPI::didCommitLoadForFrame):
341         (TestWebKitAPI::didFinishLoadForFrame):
342         (TestWebKitAPI::TEST):
343         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp: Added.
344         (TestWebKitAPI::didStartProvisionalLoadForFrame):
345         (TestWebKitAPI::didCommitLoadForFrame):
346         (TestWebKitAPI::didFinishLoadForFrame):
347         (TestWebKitAPI::TEST):
348         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
349         (TestWebKitAPI::TEST):
350         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Removed.
351         * TestWebKitAPI/Tests/WebKit2/icon.png: Added.
352         * TestWebKitAPI/Tests/WebKit2/simple.html: Added.
353         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
354         (TestWebKitAPI::Util::createURLForResource):
355
356 2010-10-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
357
358         Reviewed by Ojan Vafai.
359
360         [NRWT] Rename current_dir to current_group because it's not a directory
361         https://bugs.webkit.org/show_bug.cgi?id=47169
362
363         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
364         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
365
366 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
367
368         Unreviewed, build fix.
369
370         r69065 broke test-webkitpy by trying to create a '/tmp-X' directory,
371         which can't always be done. This test uses tempfile.mkdtemp(), which
372         should be safe.
373
374         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
375
376 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
377
378         Unreviewed, build fix.
379
380         Add missing "from __future__ import with_statement" that was
381         breaking test-webkitpy on the Leopard bots (broke in r69040).
382
383         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
384
385 2010-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
386
387         Unreviewed, rolling out r69066.
388         http://trac.webkit.org/changeset/69066
389         https://bugs.webkit.org/show_bug.cgi?id=47163
390
391         Made NRWT reliability worse. (Requested by tkent on #webkit).
392
393         * Scripts/webkitpy/layout_tests/port/chromium.py:
394         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
395
396 2010-10-04  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
397
398         Reviewed by Tony Chang.
399
400         [NRWT] Reverse the http tests to alphabetical order.
401         https://bugs.webkit.org/show_bug.cgi?id=47075
402
403         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
404
405 2010-10-04  Robert Hogan  <robert@webkit.org>
406
407         Reviewed by Andreas Kling.
408
409         [Qt] Fix timeout on http/tests/navigation/post-goback2.html and postredirect-goback2.html
410
411         We need to queue back and forward navigations in the DRT from the
412         LayoutTestController so that maybeDump() knows about them.
413
414         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
415         (LayoutTestController::queueBackNavigation):
416         (LayoutTestController::queueForwardNavigation):
417
418 2010-10-04  Tony Chang  <tony@chromium.org>
419
420         Reviewed by Kent Tamura.
421
422         [chromium] fix image diffing in NRWT
423         https://bugs.webkit.org/show_bug.cgi?id=47128
424
425         * Scripts/webkitpy/layout_tests/port/chromium.py: Flush data to the
426               temp file and check the image_diff error code more carefully
427         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
428
429 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
430
431         Reviewed by Adam Barth.
432
433         aroben's change in r68792 actually broke new-run-webkit-tests when
434         running the DRT code path. His change was intended to fix the
435         way we were converting windows paths to URIs when running under
436         Cygwin (the paths were getting one too many "/" on the front).
437         However, the change ended up breaking the chromium_win port, which
438         had slightly different logic.
439
440         This patch removes the port-specific code and adds tests to make
441         sure we're getting the behavior we expect. The Port object no longer
442         exposes a get_absolute_path() method that can be used outside of
443         of converting test filenames, because it's unreliable otherwise
444         (we don't have the right context to know which conversion is intended).
445
446         https://bugs.webkit.org/show_bug.cgi?id=47140
447
448         * Scripts/webkitpy/layout_tests/port/base.py:
449         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
450         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
451         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
452         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
453
454 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
455
456         Unreviewed, build fix.
457
458         Handle crash introduced in r69040 if we are not running in a
459         Chromium checkout.
460
461         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
462
463 2010-10-04  Dirk Pranke  <dpranke@chromium.org>
464
465         Reviewed by Tony Chang.
466
467         Add a way for us to have test expectations that are specific to the
468         official builds of Google Chrome (as opposed to Chromium). This change
469         looks for an additional "test_expectations_chrome.txt" file in
470         Chromium's repository (webkit/tools/layout_tests), and uses the
471         concatenation of that file and the regular test_expectations.txt
472         file for test overrides.
473
474         https://bugs.webkit.org/show_bug.cgi?id=46854
475
476         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
477         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
478
479 2010-10-04  Simon Fraser  <simon.fraser@apple.com>
480
481         Color tests in the list based on existing pass/fail result.
482         
483         Fix the summary data to account for htmlOnly and nonHTML tests.
484
485         * CSSTestSuiteHarness/harness/harness.css:
486         (#test-list > option.pass):
487         (#test-list > option.fail):
488         (#test-list > option.skipped):
489         * CSSTestSuiteHarness/harness/harness.js:
490         (Test):
491         (Test.prototype.statusForFormat):
492         (TestSuite.prototype.fillTestList):
493         (TestSuite.prototype.updateTestList):
494         (TestSuite.prototype.recordResult):
495         (TestSuite.prototype.markTestCompleted):
496         (TestSuite.prototype.countTestsWithFlag):
497         (TestSuite.prototype.queryDatabaseForSummary.this.db.transaction):
498         (TestSuite.prototype.queryDatabaseForSummary):
499
500 2010-10-04  Chris Fleizach  <cfleizach@apple.com>
501
502         Reviewed by Beth Dakin.
503
504         AX: doAXRangeForLine does not work
505         https://bugs.webkit.org/show_bug.cgi?id=47101
506
507         DRT support to handle NSAccessibilityRangeForLineParameterizedAttribute.
508
509         * DumpRenderTree/AccessibilityUIElement.cpp:
510         (rangeForLineCallback):
511         (AccessibilityUIElement::rangeForLine):
512         (AccessibilityUIElement::getJSClass):
513         * DumpRenderTree/AccessibilityUIElement.h:
514         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
515         (AccessibilityUIElement::rangeForLine):
516
517 2010-10-04  Andrey Kosyakov  <caseq@chromium.org>
518
519         Unreviewed. Adding myself to the committers list.
520
521         * Scripts/webkitpy/common/config/committers.py:
522
523 2010-10-04  Sam Weinig  <sam@webkit.org>
524
525         Reviewed by Anders Carlsson.
526
527         Add ability to set the CacheModel in Webkit2
528         https://bugs.webkit.org/show_bug.cgi?id=47066
529
530         * MiniBrowser/mac/AppDelegate.m:
531         (-[BrowserAppDelegate init]): Opt minibrowser into
532         a PrimaryWebBrowser cache model.
533
534 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
535
536         Make sure to enter all tests when creating the database
537         for the first time.
538         
539         When migrating to a new version of the suite, be sure to
540         sync up the database and testinfo.data by removing old
541         tests, and inserting new ones.
542
543         * CSSTestSuiteHarness/harness/harness.js:
544         (TestSuite.prototype.openDatabase.creation):
545         (TestSuite.prototype.databaseCreated):
546         (TestSuite.prototype.populateDatabaseFromTestInfoData):
547         (TestSuite.prototype.insertTest):
548
549 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
550
551         More work on treating HTML4 and XHTML1 independently; when 
552         changing the format, rebuild the test list, and update the 
553         numbers in the chapter popup.
554
555         * CSSTestSuiteHarness/harness/harness.js:
556         (Test):
557         (Test.prototype.runForFormat):
558         (Test.prototype.completedForFormat):
559         (ChapterSection):
560         (ChapterSection.prototype.countTests):
561         (Chapter):
562         (Chapter.prototype.description):
563         (Chapter.prototype.countTests):
564         (Chapter.prototype.testCount):
565         (Chapter.prototype.untestedCount):
566         (TestSuite.prototype.buildChapters):
567         (TestSuite.prototype.loadCurrentTest):
568         (TestSuite.prototype.updateProgressLabel):
569         (TestSuite.prototype.processFlags):
570         (TestSuite.prototype.formatChanged):
571
572 2010-10-03  Simon Fraser  <simon.fraser@apple.com>
573
574         Update test suite version 20101001.
575         
576         Handle database migration, and delete tests from the db that are
577         not present in testinfo.data.
578         
579         Load about:blank into the test frame before the test url, to make
580         missing tests more obvious.
581         
582         * CSSTestSuiteHarness/harness/harness.js:
583         (TestSuite.prototype.loadTest):
584         (TestSuite.prototype.openDatabase.creation):
585         (TestSuite.prototype.openDatabase.migration1_0To1_1):
586         (TestSuite.prototype.openDatabase.if.return):
587         (TestSuite.prototype.databaseReady):
588         (TestSuite.prototype.populateDatabaseFromTestInfoData):
589         (TestSuite.prototype.syncDatabaseWithTestInfoData.this.db.transaction):
590         (TestSuite.prototype.syncDatabaseWithTestInfoData):
591
592 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
593
594         Add the ability to jump to a specific test.
595
596         * CSSTestSuiteHarness/harness/harness.html:
597         * CSSTestSuiteHarness/harness/harness.js:
598         (TestSuite.prototype.goToTestByName):
599         (TestSuite.prototype.switchToFormat):
600
601 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
602
603         For a ref test, load the ref in the same format (HTML4 vs XHTML1)
604         as the test.
605
606         * CSSTestSuiteHarness/harness/harness.js:
607         (TestSuite.prototype.loadRef):
608
609 2010-10-02  Simon Fraser  <simon.fraser@apple.com>
610
611         Update the UI to reflect the fact that each test needs to be tested
612         in both HTML4 and XHTML1 format.
613         
614         * CSSTestSuiteHarness/harness/harness.js:
615         (Test):
616         (Chapter.prototype.description):
617         (Chapter.prototype.untestedCount):
618         (TestSuite.prototype.fillChapterPopup):
619         (TestSuite.prototype.updateChapterPopup):
620         (TestSuite.prototype.fillTestList):
621         (TestSuite.prototype.updateTestList):
622         (TestSuite.prototype.goToNextIncompleteTest):
623         (TestSuite.prototype.firstIncompleteTestIndex):
624         (TestSuite.prototype.recordResult):
625         (TestSuite.prototype.formatChanged):
626         (TestSuite.prototype.markTestCompleted):
627         (TestSuite.prototype.resetTestStatus):
628
629 2010-10-01  Simon Fraser  <simon.fraser@apple.com>
630
631         Add the ability to remove results for re-testing, and
632         to import results.
633
634         * CSSTestSuiteHarness/harness/harness.css:
635         (.custom button):
636         (#overlay):
637         (#overlay.visible):
638         (.overlay-contents):
639         (.overlay-contents textarea):
640         (.overlay-contents .buttons):
641         (.overlay-contents .note):
642         (.overlay-contents .buttons button):
643         * CSSTestSuiteHarness/harness/harness.html:
644         * CSSTestSuiteHarness/harness/harness.js:
645         (TestSuite.prototype.importResults):
646         (TestSuite.prototype.clearResults):
647         (TestSuite.prototype.markTestCompleted):
648         (TestSuite.prototype.resetTestStatus):
649         (TestSuite.prototype.storeTestResult):
650         (TestSuite.prototype.importTestResults):
651         (TestSuite.prototype.clearTestResults):
652
653 2010-10-01  Sam Weinig  <sam@webkit.org>
654
655         Reviewed by Jon Honeycutt.
656
657         Deploy the new WKString functions to remove most uses of CF from
658         the WebKitTestRunner.
659
660         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
661         (WTR::InjectedBundle::didReceiveMessage):
662         (WTR::InjectedBundle::done):
663         * WebKitTestRunner/StringFunctions.h:
664         (WTR::toWK):
665         (WTR::toJS):
666         (WTR::toSTD):
667         (WTR::operator<<):
668         (WTR::copyURLString):
669         * WebKitTestRunner/TestController.cpp:
670         (WTR::TestController::resetStateToConsistentValues):
671         (WTR::TestController::didFinishLoadForFrame):
672         * WebKitTestRunner/TestInvocation.cpp:
673         (WTR::TestInvocation::invoke):
674         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
675
676 2010-10-01  Mihai Parparita  <mihaip@chromium.org>
677
678         Unreviewed TestResultsServer change.
679
680         Add files introduced by http://crrev.com/61273 to the list of dashboard 
681         files to update.
682
683         * TestResultServer/handlers/dashboardhandler.py:
684
685 2010-10-01  Brian Weinstein  <bweinstein@apple.com>
686
687         Build Fix for Windows.
688
689         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Don't copy ForwardingHeaders from
690             WebKitTestRunner/ForwardingHeaders, instead, add $(WebKitOutputDir)/include/WebCore/
691             ForwardingHeaders to the include path.
692
693 2010-10-01  Sam Weinig  <sam@webkit.org>
694
695         Reviewed by Anders Carlsson.
696
697         Add SPI to convert a WKStringRef to a JSStringRef and vice-versa.
698
699         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
700         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
701         (TestWebKitAPI::TEST):
702         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp: Added.
703         (TestWebKitAPI::TEST):
704
705 2010-10-01  Sam Weinig  <sam@webkit.org>
706
707         Reviewed by Kenneth Rohde Christiansen.
708
709         Add additional WKString API
710         https://bugs.webkit.org/show_bug.cgi?id=46958
711
712         Add basic WKStringRef tests.
713
714         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
715         * TestWebKitAPI/Tests/WebKit2/WKString.cpp: Added.
716
717 2010-10-01  Sam Weinig  <sam@webkit.org>
718
719         Reviewed by Dan Bernstein.
720
721         Add makefile for TestWebKitAPI and call it from the base makefile.
722
723         * Makefile:
724         * TestWebKitAPI/Makefile: Added.
725
726 2010-10-01  Sam Weinig  <sam@webkit.org>
727
728         Reviewed by Adam Roben.
729
730         Remove unnecessary ForwardingHeaders from test runners.
731         https://bugs.webkit.org/show_bug.cgi?id=47010
732
733         * TestWebKitAPI/Configurations/Base.xcconfig:
734         * TestWebKitAPI/ForwardingHeaders: Removed.
735         * WebKitTestRunner/Configurations/Base.xcconfig:
736         * WebKitTestRunner/ForwardingHeaders: Removed.
737
738 2010-09-30  Adam Barth  <abarth@webkit.org>
739
740         Reviewed by Eric Seidel.
741
742         WebSocket tests are flaky
743         https://bugs.webkit.org/show_bug.cgi?id=46956
744
745         Update these tools to understand how to run the WebSocket tests off the
746         Apache server.
747
748         * Scripts/old-run-webkit-tests:
749         * Scripts/webkitpy/layout_tests/port/base.py:
750         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
751         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
752
753 2010-10-01  Adam Roben  <aroben@apple.com>
754
755         Encode Executive command arguments using UTF-8 on Cygwin
756
757         Cygwin's Python's os.execv doesn't support unicode command arguments.
758         Cygwin's execv expects arguments to be encoded using the current code
759         page. But code pages are limited in what characters they can handle,
760         and our tests include characters that the English code page can't
761         handle.  So for now we'll just encode everything in UTF-8 on Cygwin,
762         which can handle all characters but might confuse some commands, for
763         expediency's sake. I'm sure we'll run into cases where UTF-8 isn't
764         good enough, but we can deal with that when the problem arises.
765
766         Reviewed by Adam Barth.
767
768         Fixes <http://webkit.org/b/46892> <rdar://problem/8496639>
769         webkitpy.common.system.executive_unittest.ExecutiveTest.test_run_command_with_unicode
770         fails on Windows
771
772         * Scripts/webkitpy/common/system/executive.py:
773         (Executive._run_command_with_teed_output):
774         (Executive.run_command):
775         On Cygwin, encode arguments using UTF-8.
776
777 2010-10-01  Sam Weinig  <sam@webkit.org>
778
779         Reviewed by Adam Roben.
780
781         Add simple API tester for WebKit2
782         https://bugs.webkit.org/show_bug.cgi?id=46953
783
784         This adds a very simple testing infrastructure for testing APIs exposed
785         through the WebKit project. It consists of two parts: 1) a project that
786         builds the all the tests 2) a script that searches the tests directory and
787         calls the tester once for each test.
788
789         This adds the infrastructure and two tests:
790         - Tests/WTF/Vector1.cpp - A proof of concept test of WTF data-structures.
791         - Tests/WebKit2/BasicTest1.cpp - A proof of concept test of WebKit2 API.
792
793         This currently only works on the mac, but is designed to be easily ported 
794         to any platform.
795
796         * Scripts/run-api-tests: Added.
797         * Scripts/build-api-tests: Added.
798         Scripts to build/run the tests.
799
800         * TestWebKitAPI: Added.
801         * TestWebKitAPI/Configurations: Added.
802         * TestWebKitAPI/Configurations/Base.xcconfig: Added.
803         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Added.
804         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Added.
805         * TestWebKitAPI/ForwardingHeaders: Added.
806         * TestWebKitAPI/ForwardingHeaders/wtf: Added.
807         * TestWebKitAPI/PlatformUtilities.h: Added.
808         * TestWebKitAPI/PlatformWebView.h: Added.
809         (TestWebKitAPI::PlatformWebView::platformView):
810         * TestWebKitAPI/StringFunctions.h: Added.
811         * TestWebKitAPI/Test.h: Added.
812         (TestWebKitAPI::Test::~Test):
813         (TestWebKitAPI::Test::name):
814         (TestWebKitAPI::Test::Register::Register):
815         (TestWebKitAPI::Test::Register::create):
816         (TestWebKitAPI::Test::Test):
817         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Added.
818         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added.
819         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added.
820         * TestWebKitAPI/TestsController.cpp: Added.
821         (TestWebKitAPI::TestsController::shared):
822         (TestWebKitAPI::TestsController::TestsController):
823         (TestWebKitAPI::TestsController::runTestNamed):
824         (TestWebKitAPI::TestsController::testFailed):
825         (TestWebKitAPI::TestsController::registerCreateTestFunction):
826         * TestWebKitAPI/TestsController.h: Added.
827         * TestWebKitAPI/mac: Added.
828         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm: Added.
829         (TestWebKitAPI::Util::run):
830         (TestWebKitAPI::Util::createURLForResource):
831         * TestWebKitAPI/mac/PlatformWebViewMac.mm: Added.
832         (TestWebKitAPI::PlatformWebView::PlatformWebView):
833         (TestWebKitAPI::PlatformWebView::resizeTo):
834         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
835         (TestWebKitAPI::PlatformWebView::page):
836         (TestWebKitAPI::PlatformWebView::focus):
837         * TestWebKitAPI/mac/main.mm: Added.
838         Infrastructure.
839
840         * TestWebKitAPI/Tests: Added.
841         * TestWebKitAPI/Tests/WTF: Added.
842         * TestWebKitAPI/Tests/WTF/Vector1.cpp: Added.
843         * TestWebKitAPI/Tests/WebKit2: Added.
844         * TestWebKitAPI/Tests/WebKit2/BasicTest1.cpp: Added.
845         (TestWebKitAPI::State::State):
846         * TestWebKitAPI/Tests/WebKit2/basic-1.html: Added.
847         Proof of concept tests.
848
849 2010-10-01  Adam Roben  <aroben@apple.com>
850
851         Don't assume AccessibleObjectFromEvent succeeds
852
853         Fixes <http://webkit.org/b/44136> <rdar://problem/8321684> Crash in
854         DumpRenderTree!notificationListenerProc when running
855         plugins/access-after-page-destroyed.html
856
857         Reviewed by Sam Weinig.
858
859         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
860         (notificationListenerProc): Check both the return value of
861         AccessibleObjectFromEvent and the object it returns, as MSDN
862         recommends.
863
864 2010-10-01  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
865
866         Reviewed by Tony Chang.
867
868         [NRWT] Put the http and websocket tests first in the test list.
869         https://bugs.webkit.org/show_bug.cgi?id=46453
870
871         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
872         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
873
874 2010-10-01  Fady Samuel  <fsamuel@chromium.org>
875
876         Unreviewed, adding myself to the committer list.
877
878         * Scripts/webkitpy/common/config/committers.py:
879
880 2010-10-01  Adam Roben  <aroben@apple.com>
881
882         Test NPN_GetValue(NPNVnetscapeWindow)
883
884         Test for <http://webkit.org/b/46726> <rdar://problem/8486319>
885         Right-clicking on windowless Flash plugin in WebKit2 makes a context
886         menu appear in the bottom-right corner of the screen
887
888         Reviewed by Anders Carlsson.
889
890         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
891         (PluginTest::NPN_GetValue): Added. Calls through to the browser.
892
893         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added NPN_GetValue.
894
895         * DumpRenderTree/TestNetscapePlugIn/Tests/win/GetValueNetscapeWindow.cpp: Added.
896         (GetValueNetscapeWindow::GetValueNetscapeWindow): Initialize members.
897         (GetValueNetscapeWindow::NPP_SetWindow): Test that
898         NPN_GetValue(NPNVnetscapeWindow) returns a valid HWND and that it
899         isn't our HWND.
900
901         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
902         Added GetValueNetscapeWindow.
903
904 2010-10-01  Andreas Kling  <andreas.kling@nokia.com>
905
906         Unreviewed, adding my webkit.org identity to reviewer list.
907
908         * Scripts/webkitpy/common/config/committers.py:
909
910 2010-09-30  Adam Barth  <abarth@webkit.org>
911
912         Reviewed by Eric Seidel.
913
914         The WebSocket server should flush its logs
915         https://bugs.webkit.org/show_bug.cgi?id=46946
916
917         The WebSocket server logs are truncated because the driver just
918         terminates the child.  It should run Python without buffering so we can
919         see the end of the log.
920
921         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
922
923 2010-09-30  Simon Fraser  <simon.fraser@apple.com>
924
925         Add a button to jump to the next untested test.
926         
927         * CSSTestSuiteHarness/harness/harness.css:
928         (.test-type):
929         (.name > button):
930         * CSSTestSuiteHarness/harness/harness.html:
931         * CSSTestSuiteHarness/harness/harness.js:
932         (Chapter.prototype.description):
933         (Chapter.prototype.untestedCount):
934         (TestSuite.prototype.testInfoDataLoaded):
935         (TestSuite.prototype.fillChapterPopup):
936         (TestSuite.prototype.updateChapterPopup):
937         (TestSuite.prototype.buildTestListForChapter):
938         (TestSuite.prototype.goToNextIncompleteTest):
939         (TestSuite.prototype.firstIncompleteTestIndex):
940         (TestSuite.prototype.testCompletionStateChanged):
941
942 2010-09-29  Jon Honeycutt  <jhoneycutt@apple.com>
943
944         WebKit2 on Windows should use Windows fonts for the various standard
945         font families
946         https://bugs.webkit.org/show_bug.cgi?id=43499
947         <rdar://problem/8272758>
948
949         Reviewed by Adam Roben.
950
951         * WebKitTestRunner/TestController.cpp:
952         (WTR::TestController::resetStateToConsistentValues):
953         Use the Mac fonts for running tests. This matches DRT behavior.
954
955 2010-09-30  Adam Barth  <abarth@webkit.org>
956
957         Third attempt.  We need a better integration test environment.
958
959         * Scripts/webkitpy/common/net/failuremap.py:
960         * Scripts/webkitpy/common/net/failuremap_unittest.py:
961
962 2010-09-30  Robert Hogan  <robert@webkit.org>
963
964         Reviewed by Andreas Kling.
965
966         [Qt] Support for PlainTextController
967
968         Unskip editing/text-iterator/basic-iteration.html
969
970         https://bugs.webkit.org/show_bug.cgi?id=38805
971
972         * DumpRenderTree/qt/DumpRenderTree.pro:
973         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
974         (WebCore::DumpRenderTree::DumpRenderTree):
975         (WebCore::DumpRenderTree::initJSObjects):
976         * DumpRenderTree/qt/DumpRenderTreeQt.h:
977         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Added.
978         (PlainTextController::PlainTextController):
979         (PlainTextController::plainText):
980         * DumpRenderTree/qt/PlainTextControllerQt.h: Added.
981
982 2010-09-30  Adam Barth  <abarth@webkit.org>
983
984         Unreviewed.  Second attempt to fix sheriffbot.
985
986         * Scripts/webkitpy/common/net/buildbot.py:
987
988 2010-09-30  Adam Barth  <abarth@webkit.org>
989
990         Unreviewed.
991
992         This patch should stop the sheriffbot from throwing an exception.
993
994         * Scripts/webkitpy/common/net/buildbot.py:
995
996 2010-09-30  Brian Weinstein  <bweinstein@apple.com>
997
998         Reviewed by Adam Roben.
999
1000         The same bots shouldn't run both Windows Debug Tests and Windows Release Tests.
1001         https://bugs.webkit.org/show_bug.cgi?id=46926
1002
1003         * BuildSlaveSupport/build.webkit.org-config/config.json: Have two bots running Windows 
1004             Release Tests, and two bots running Windows Debug Tests, instead of four running both.
1005
1006 2010-09-30  Adam Barth  <abarth@webkit.org>
1007
1008         Reviewed by Eric Seidel.
1009
1010         webkit-patch find-flaky-tests should print results URLs
1011         https://bugs.webkit.org/show_bug.cgi?id=46917
1012
1013         Printing out the results URL makes find-flaky-tests more actionable
1014         because you can see what happens when a test fails.  The output from
1015         the script is still pretty noisy, but it seems useful.
1016
1017         * Scripts/webkitpy/tool/commands/queries.py:
1018
1019 2010-09-30  Chris Marrin  <cmarrin@apple.com>
1020
1021         Reviewed by Simon Fraser.
1022
1023         Make 2D accelerated canvas rendering build on Mac
1024         https://bugs.webkit.org/show_bug.cgi?id=46007
1025         
1026         Added ACCELERATED_2D_CANVAS to build-webkit
1027
1028         * Scripts/build-webkit:
1029
1030 2010-09-29  Kenneth Russell  <kbr@google.com>
1031
1032         Reviewed by Dimitri Glazkov.
1033
1034         [chromium] Add accelerated compositing support to DumpRenderTree and test_shell
1035         https://bugs.webkit.org/show_bug.cgi?id=46849
1036
1037         Added offscreen code path for WebGraphicsContext3DDefaultImpl which
1038         works with the compositor integration in both DumpRenderTree and
1039         test_shell, since both pass a non-null WebCanvas* to WebViewImpl::paint
1040         and thereby trigger the compositor's readback code path. Added support
1041         for --enable-accelerated-compositing to DumpRenderTree.
1042
1043         Tested in both test_shell and DumpRenderTree on Linux, the latter by
1044         modifying a compositing layout test, dumping the pixels and verifying
1045         that they matched the output when the compositor was active.
1046
1047         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1048         (main):
1049         * DumpRenderTree/chromium/TestShell.cpp:
1050         (TestShell::TestShell):
1051         (TestShell::resetWebSettings):
1052         * DumpRenderTree/chromium/TestShell.h:
1053         (TestShell::setAcceleratedCompositingEnabled):
1054         * DumpRenderTree/chromium/WebPreferences.cpp:
1055         (WebPreferences::reset):
1056         (WebPreferences::applyTo):
1057         * DumpRenderTree/chromium/WebPreferences.h:
1058         * DumpRenderTree/chromium/WebViewHost.cpp:
1059         (WebViewHost::scheduleComposite):
1060         * DumpRenderTree/chromium/WebViewHost.h:
1061
1062 2010-09-30  Adam Roben  <aroben@apple.com>
1063
1064         Ensure that QueueEngine cleans up its log files when its delegate
1065         tells it to stop processing work
1066
1067         Reviewed by Adam Barth.
1068
1069         Fixes <http://webkit.org/b/46891> <rdar://problem/8496638> Many tests
1070         in webkitpy.tool.bot.queueengine_unittest.QueueEngineTest crash on
1071         Windows
1072
1073         * Scripts/webkitpy/tool/bot/queueengine.py:
1074         (QueueEngine.run): Stop ourselves normally (including cleaning up log
1075         files) when the delegate tells us to stop processing work.
1076
1077         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1078         (LoggingDelegate.__init__): Moved code here from
1079         RaisingDelegate.__init__.
1080         (LoggingDelegate.expeced_callbacks): Added the stop_work_queue
1081         callback.
1082         (LoggingDelegate.stop_work_queue): Moved here from RaisingDelegate.
1083         (RaisingDelegate.__init__): Removed code that LoggingDelegate takes
1084         care of for us now.
1085         (QueueEngineTest.test_trivial): Make sure we got the expected stop
1086         message.
1087         (QueueEngineTest.test_not_safe_to_proceed): Changed to explicitly
1088         remove the callbacks that are related to processing a single work
1089         item, rather than removing all callbacks after a certain point, as
1090         there are now more callbacks we expect to receive at the end.
1091
1092 2010-09-30  Adam Roben  <aroben@apple.com>
1093
1094         Fix path -> URL conversion on Cygwin
1095
1096         Reviewed by Adam Barth.
1097
1098         Fixes <http://webkit.org/b/46890> <rdar://problem/8496637> Many tests
1099         in webkitpy.layout_tests.run_webkit_tests_unittest assert on Windows
1100
1101         * Scripts/webkitpy/layout_tests/port/base.py:
1102         (Port.filename_to_uri): Treat Cygwin like other UNIX-y platforms by
1103         assuming paths already have a leading slash.
1104
1105 2010-09-30  Adam Roben  <aroben@apple.com>
1106
1107         Teach WindowGeometryInitializedBeforeSetWindow that NPP_SetWindow can
1108         be called more than once
1109
1110         The NPP_SetWindow call made when the plugin is torn down was confusing
1111         us, and was causing us to spew an error into the next test.
1112
1113         Fixes <http://webkit.org/b/46900> <rdar://problem/8496888> REGRESSION
1114         (r68520): plugins/access-after-page-destroyed.html failing on Windows
1115
1116         Reviewed by Anders Carlsson.
1117
1118         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
1119         (WindowGeometryInitializedBeforeSetWindow::WindowGeometryInitializedBeforeSetWindow):
1120         Initialize member.
1121         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Bail if
1122         this isn't the first time this is called.
1123
1124 2010-09-30  Eric Seidel  <eric@webkit.org>
1125
1126         Reviewed by Adam Barth.
1127
1128         webkit-patch upload warns that I'm using Xcode when I'm not
1129         https://bugs.webkit.org/show_bug.cgi?id=46869
1130
1131         String.find returns -1 when not found, so switched to "in".
1132
1133         * Scripts/webkitpy/common/system/user.py:
1134         * Scripts/webkitpy/common/system/user_unittest.py:
1135
1136 2010-09-30  Eric Seidel  <eric@webkit.org>
1137
1138         Reviewed by Adam Barth.
1139
1140         webkit-patch failure-reason dies if non-trunk commits are in the blame range
1141         https://bugs.webkit.org/show_bug.cgi?id=46866
1142
1143         I also made failure-reason use RegressionWindow in a cleaner way.
1144
1145         * Scripts/webkitpy/tool/commands/queries.py:
1146
1147 2010-09-29  Adam Barth  <abarth@webkit.org>
1148
1149         Reviewed by Eric Seidel.
1150
1151         webkit-patch find-flaky-tests
1152         https://bugs.webkit.org/show_bug.cgi?id=46876
1153
1154         This command helps us find flaky tests so we can squash them.
1155
1156         * Scripts/webkitpy/tool/commands/queries.py:
1157
1158 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1159
1160         Fix export to use '?' instead of 'null' for
1161         tests with no results.
1162         
1163         * CSSTestSuiteHarness/harness/harness.js:
1164
1165 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1166
1167         Add a warning when a test requires special steps.
1168         Add a Print Preview button for 'paged' tests that
1169         brings up the print dialog, allowing the user to 
1170         judge paged media tests.
1171
1172         * CSSTestSuiteHarness/harness/harness.css:
1173         * CSSTestSuiteHarness/harness/harness.html:
1174         * CSSTestSuiteHarness/harness/harness.js:
1175         (TestSuite.prototype.loadTest):
1176         (TestSuite.prototype.processFlags):
1177
1178 2010-09-29  Adam Barth  <abarth@webkit.org>
1179
1180         Reviewed by Eric Seidel.
1181
1182         Remove revisions_casuing_failures
1183         https://bugs.webkit.org/show_bug.cgi?id=46872
1184
1185         This function exists only to be unit tested.
1186
1187         * Scripts/webkitpy/common/net/failuremap.py:
1188         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1189         * Scripts/webkitpy/tool/mocktool.py:
1190
1191 2010-09-29  Adam Barth  <abarth@webkit.org>
1192
1193         Reviewed by Eric Seidel.
1194
1195         SheriffBot should post the list of failing tests to bugs
1196         https://bugs.webkit.org/show_bug.cgi?id=46871
1197
1198         * Scripts/webkitpy/common/net/buildbot.py:
1199         * Scripts/webkitpy/common/net/failuremap.py:
1200         * Scripts/webkitpy/common/net/regressionwindow.py:
1201         * Scripts/webkitpy/tool/bot/sheriff.py:
1202         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1203         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1204         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1205         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1206         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1207         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1208         * Scripts/webkitpy/tool/mocktool.py:
1209
1210 2010-09-29  Brent Fulgham  <bfulgham@webkit.org>
1211
1212         Reviewed by Martin Robinson, Eric Seidel, and Mark Rowe.
1213
1214         [WinCairo] Adds a build slave.
1215         https://bugs.webkit.org/show_bug.cgi?id=46360
1216
1217         * BuildSlaveSupport/build.webkit.org-config/config.json: Add
1218         entries for a debug build of the WinCairo port.
1219         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add
1220         platform flag to configuration for wincairo (like gtk, chromium, etc.)
1221         * Scripts/build-webkit: Change 'cairo-win32' labeling to 'wincairo'
1222         * Scripts/webkitdirs.pm: Change 'cairo-win32' labeling to 'wincairo'
1223
1224 2010-09-29  Adam Barth  <abarth@webkit.org>
1225
1226         Reviewed by Eric Seidel.
1227
1228         Move more SheriffBot smarts into FailureMap
1229         https://bugs.webkit.org/show_bug.cgi?id=46703
1230
1231         This patch pushes the FailureMap model object further into the
1232         SheriffBot machine.  In addition, it moves a couple operations on this
1233         object from SheriffBot itself to the model.
1234
1235         Eventually, FailureMap will be the canonical context object for
1236         SheriffBot operations.  FailureMap represents a map of the current
1237         failures on the bots that might require remediation.
1238
1239         * Scripts/webkitpy/common/net/failuremap.py:
1240         * Scripts/webkitpy/common/net/regressionwindow.py:
1241         * Scripts/webkitpy/tool/commands/queries.py:
1242         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1243         * Scripts/webkitpy/tool/mocktool.py:
1244
1245 2010-09-29  Tony Chang  <tony@chromium.org>
1246
1247         Reviewed by James Robinson.
1248
1249         [chromium] enable -Werror for DRT and webkit_unit_tests on Linux
1250         https://bugs.webkit.org/show_bug.cgi?id=46829
1251
1252         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
1253         (DRTDevToolsClient::DRTDevToolsClient):
1254         * DumpRenderTree/chromium/TestShell.cpp:
1255         (TestShell::TestShell):
1256         * DumpRenderTree/chromium/WebViewHost.cpp:
1257         (WebViewHost::postAccessibilityNotification):
1258         (WebViewHost::WebViewHost):
1259
1260 2010-09-29  Chris Fleizach  <cfleizach@apple.com>
1261
1262         Reviewed by Darin Adler.
1263
1264         AX: implement CSS3 Speech "speak"
1265         https://bugs.webkit.org/show_bug.cgi?id=46827
1266
1267         * DumpRenderTree/AccessibilityUIElement.cpp:
1268         (speakCallback):
1269         (AccessibilityUIElement::speak):
1270         (AccessibilityUIElement::getJSClass):
1271         * DumpRenderTree/AccessibilityUIElement.h:
1272         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1273         (AccessibilityUIElement::speak):
1274
1275 2010-09-29  Mihai Parparita  <mihaip@chromium.org>
1276
1277         Reviewed by Adam Barth.
1278
1279         Record bot ID when updating queue status
1280         https://bugs.webkit.org/show_bug.cgi?id=46764
1281         
1282         Since we now have multiple bots handling patches from the commit queue,
1283         we need to differentiate status updates from them, so that we can group
1284         the queue status page in a less confusing way.
1285
1286         * QueueStatusServer/handlers/updatestatus.py: Accept bot_id as input
1287         * QueueStatusServer/model/queuestatus.py: Add bot_id property
1288         * QueueStatusServer/templates/updatestatus.html: Add bot_id input
1289         * Scripts/webkitpy/common/net/bugzilla_unittest.py: Extract MockBrowser
1290         * Scripts/webkitpy/common/net/statusserver.py: Add bot_id
1291         * Scripts/webkitpy/common/net/statusserver_unittest.py: Added.
1292         * Scripts/webkitpy/tool/main.py: Add --bot-id
1293         * Scripts/webkitpy/tool/mocktool.py: Add MockBrowser
1294
1295 2010-09-29  Simon Fraser  <simon.fraser@apple.com>
1296
1297         No review.
1298         
1299         References always refert to a file in .xht format, even
1300         for HTML tests, so fix their loading.
1301
1302         * CSSTestSuiteHarness/harness/harness.js:
1303         (TestSuite.prototype.loadRef):
1304
1305 2010-09-28  Johnny Ding  <jnd@chromium.org>
1306
1307         Reviewed by Adam Barth.
1308
1309         https://bugs.webkit.org/show_bug.cgi?id=41292
1310         Add a new parameter to the test plugin to allow specifying a script 
1311         and a mouse/keyboard event. The specified script will be evaluated
1312         in the browser when the specified event is received by the plugin.
1313
1314         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1315         (pluginAllocate):
1316         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1317         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1318         (NPP_New):
1319         (handleEventCarbon):
1320         (handleEventCocoa):
1321
1322 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1323
1324         Fix export by adding missing argument.
1325
1326         * CSSTestSuiteHarness/harness/harness.js:
1327         (TestSuite.prototype.showResultsForAllTests):
1328
1329 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1330
1331         [wx] Build fix, add missing import.
1332
1333         * wx/packaging/build-win-installer.py:
1334
1335 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1336
1337         No review
1338         
1339         Show which tests have been run by dimming them out in the test list.
1340         
1341         Adjust some element sizes.
1342         
1343         * CSSTestSuiteHarness/harness/harness.css:
1344         (#test-list > option.untested):
1345         (#test-list > option.completed):
1346         (#output):
1347         (.output-options):
1348         * CSSTestSuiteHarness/harness/harness.js:
1349         (Test):
1350         (TestSuite.prototype.fillTestList):
1351         (TestSuite.prototype.updateTestList):
1352         (TestSuite.prototype.setSelectedChapter):
1353         (TestSuite.prototype.recordResult):
1354         (TestSuite.prototype.markTestCompleted):
1355         (TestSuite.prototype.testCompletionStateChanged):
1356         (TestSuite.prototype.loadTestStatus):
1357
1358 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1359
1360         No review.
1361         
1362         Implement export of various queries on the test database, sharing
1363         code with that which displays results inline.
1364
1365         * CSSTestSuiteHarness/harness/harness.js:
1366         ():
1367         (TestSuite.prototype.exportResultsCompletion.var):
1368         (TestSuite.prototype.exportResultsCompletion):
1369         (TestSuite.prototype.showResultsForCompletedTests):
1370         (TestSuite.prototype.exportResultsForCompletedTests):
1371         (TestSuite.prototype.showResultsForAllTests):
1372         (TestSuite.prototype.exportResultsForAllTests):
1373         (TestSuite.prototype.exportResultsForTestsNotRun):
1374         (TestSuite.prototype.exportResultsForTestsWithStatus):
1375         (TestSuite.prototype.exportResultsForTestsWithMismatchedResults):
1376
1377 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1378
1379         No review.
1380
1381         Work around uncertainty about the order of database
1382         transactions when creating the database, so that we don't
1383         try to query the table before it has been created.
1384
1385         * CSSTestSuiteHarness/harness/harness.js:
1386         (TestSuite):
1387         (TestSuite.prototype.databaseCreated):
1388         (TestSuite.prototype.storeTestResult):
1389         (TestSuite.prototype.populateDatabaseFromTestInfoData):
1390         (TestSuite.prototype.queryDatabaseForTestsWithStatus):
1391         (TestSuite.prototype.queryDatabaseForTestsWithMixedStatus):
1392         (TestSuite.prototype.queryDatabaseForCompletedTests):
1393         (TestSuite.prototype.queryDatabaseForTestsNotRun):
1394
1395 2010-09-28  Tony Chang  <tony@chromium.org>
1396
1397         Reviewed by Eric Seidel.
1398
1399         add python keyring support to webkit-patch
1400         https://bugs.webkit.org/show_bug.cgi?id=41269
1401
1402         * Scripts/webkitpy/common/net/credentials.py: Add the ability to read passwords using
1403             the python keyring module
1404         * Scripts/webkitpy/common/net/credentials_unittest.py:
1405         * Scripts/webkitpy/common/system/user.py: Allow confirm() to default to no and add testing params.
1406         * Scripts/webkitpy/common/system/user_unittest.py:
1407         * Scripts/webkitpy/tool/mocktool.py:
1408
1409 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1410
1411         Reviewed by Gustavo Noronha Silva.
1412
1413         [Cairo] FreeType fonts should obey FontConfig hinting/anti-aliasing settings
1414         https://bugs.webkit.org/show_bug.cgi?id=46740
1415
1416         * DumpRenderTree/gtk/fonts/fonts.conf: Add specialized variants of common
1417         fonts which can be used to fully test FontConfig rendering settings.
1418
1419 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1420
1421         Reviewed by Gustavo Noronha Silva.
1422
1423         [gtk] Fedora has a different path for the liberation fonts
1424         https://bugs.webkit.org/show_bug.cgi?id=46709
1425
1426         When searching for DRT fonts, also look in the path where those fonts
1427         are commonly found on Fedora systems.
1428
1429         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1430         (initializeFonts): Include logic for looking for Fedora-style font paths.
1431
1432 2010-09-28  Martin Robinson  <mrobinson@igalia.com>
1433
1434         Reviewed by Andreas Kling.
1435
1436         run-webkit-tests needs an updated list of directories with webgl tests
1437         https://bugs.webkit.org/show_bug.cgi?id=46747
1438
1439         Update the list of directories containing WebGL tests and a unit test
1440         which depends on this list.
1441
1442         * Scripts/old-run-webkit-tests: Update the list of directories.
1443         * Scripts/webkitpy/layout_tests/port/webkit.py: Ditto.
1444         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Update the expected result.
1445
1446 2010-09-28  Adam Barth  <abarth@webkit.org>
1447
1448         Reviewed by Eric Seidel.
1449
1450         Introduce FailureMap to summaries the failures status of all the bots
1451         https://bugs.webkit.org/show_bug.cgi?id=46700
1452
1453         This patch gives the SheriffBot a handle on the list of failing tests.
1454
1455         * Scripts/webkitpy/common/net/buildbot.py:
1456         * Scripts/webkitpy/common/net/failuremap.py: Added.
1457         * Scripts/webkitpy/tool/commands/queries.py:
1458         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1459         * Scripts/webkitpy/tool/mocktool.py:
1460
1461 2010-09-28  Adam Roben  <aroben@apple.com>
1462
1463         Update for the addition of WKPageUIClient::didNotHandleKeyEvent
1464
1465         Fixes <http://webkit.org/b/46660> <rdar://problem/8483465> Need API to
1466         tell a WebKit2 client application that a key event was not handled
1467
1468         Reviewed by Kenneth Rohde Christiansen and Sam Weinig.
1469
1470         * MiniBrowser/mac/BrowserWindowController.m:
1471         (-[BrowserWindowController awakeFromNib]):
1472         * MiniBrowser/win/BrowserView.cpp:
1473         (BrowserView::create):
1474         * WebKitTestRunner/TestController.cpp:
1475         (WTR::createOtherPage):
1476         (WTR::TestController::initialize):
1477
1478 2010-09-28  Simon Fraser  <simon.fraser@apple.com>
1479
1480         Unreviewed.
1481
1482         Update the CSSTestSuiteHarness to not scrape the XHTML chapter files
1483         for the test order, but instead use information from testinfo.data.
1484         
1485         * CSSTestSuiteHarness/harness/harness.html:
1486         * CSSTestSuiteHarness/harness/harness.js:
1487
1488 2010-09-28  Kevin Ollivier  <kevino@theolliviers.com>
1489
1490         [wx] Build fix, don't try to get the svn revision from the git repo when packaging,
1491         it causes the process to hang on the gitorious repo.
1492
1493         * wx/packaging/build-mac-installer.py:
1494         * wx/packaging/build-win-installer.py:
1495
1496 2010-09-28  Adam Roben  <aroben@apple.com>
1497
1498         Test that a plugin's HWND is sized/positioned before NPP_SetWindow is
1499         called
1500
1501         Reviewed by Anders Carlsson.
1502
1503         Test for <http://webkit.org/b/46716> <rdar://problem/8482014>
1504         Full-page Adobe Reader does not paint until window is resized
1505
1506         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1507         (PluginTest::NPP_SetWindow): Added. Just returns NPERR_NO_ERROR at
1508         this level.
1509
1510         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Declared
1511         NPP_SetWindow.
1512
1513         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp: Added.
1514         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Checks that
1515         the plugin's HWND has a non-zero size and that its size/position
1516         matches that specified in the NPWindow.
1517
1518         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1519         (NPP_SetWindow): Call through to the PluginTest.
1520
1521         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1522         Added WindowGeometryInitializedBeforeSetWindow.cpp, and let VS reorder
1523         the files as it saw fit.
1524
1525 2010-09-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
1526
1527         Reviewed by Andreas Kling.
1528
1529         [Qt] Remove support for Qt 4.5
1530         https://bugs.webkit.org/show_bug.cgi?id=46718
1531
1532         Remove the code for versions of Qt prior to 4.6.
1533
1534         * DumpRenderTree/qt/EventSenderQt.cpp:
1535         (EventSender::addTouchPoint):
1536         (EventSender::updateTouchPoint):
1537         (EventSender::setTouchModifier):
1538         (EventSender::touchStart):
1539         (EventSender::touchMove):
1540         (EventSender::touchEnd):
1541         (EventSender::clearTouchPoints):
1542         (EventSender::releaseTouchPoint):
1543         (EventSender::sendTouchEvent):
1544         * DumpRenderTree/qt/EventSenderQt.h:
1545         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1546         (TextInputController::setMarkedText):
1547         * QtTestBrowser/launcherwindow.cpp:
1548         (LauncherWindow::LauncherWindow):
1549         (LauncherWindow::initializeView):
1550         (LauncherWindow::createChrome):
1551         (LauncherWindow::sendTouchEvent):
1552         (LauncherWindow::eventFilter):
1553         (LauncherWindow::applyZoom):
1554         (LauncherWindow::setTouchMocking):
1555         * QtTestBrowser/launcherwindow.h:
1556         * QtTestBrowser/utils.cpp:
1557         (urlFromUserInput):
1558         * QtTestBrowser/webview.cpp:
1559         (WebViewGraphicsBased::animatedFlip):
1560         (WebViewGraphicsBased::animatedYFlip):
1561         * QtTestBrowser/webview.h:
1562         (WebViewGraphicsBased::setYRotation):
1563
1564 2010-09-28  İsmail Dönmez  <ismail@namtrac.org>
1565
1566         Reviewed by Andreas Kling.
1567
1568         Fix DRT compilation on WinCE. Introduce a WCECOMPAT variable
1569         which should point to wcecompat installation. Needs wcecompat
1570         library from http://github.com/mauricek/wcecompat .
1571
1572         * DumpRenderTree/qt/DumpRenderTree.pro:
1573         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1574         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1575
1576 2010-09-28  Daniel Bates  <dbates@rim.com>
1577
1578         Rollout changeset 68493 <http://trac.webkit.org/changeset/68493>
1579         <https://bugs.webkit.org/show_bug.cgi?id=39136>
1580
1581         Rollout changeset 68493 because it broke Sheriffbot's rollout feature.
1582         In particular, this change caused Sheriffbot to raise an exception when
1583         trying to parse the bug id on a bug page. We need to look into this
1584         some more.
1585
1586         * Scripts/webkitpy/common/net/bugzilla.py:
1587         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1588         * Scripts/webkitpy/tool/bot/sheriff.py:
1589         * Scripts/webkitpy/tool/commands/download.py:
1590         * Scripts/webkitpy/tool/commands/queues.py:
1591         * Scripts/webkitpy/tool/commands/upload.py:
1592         * Scripts/webkitpy/tool/steps/closebug.py:
1593         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1594         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1595         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1596
1597 2010-09-28  Adam Barth  <abarth@webkit.org>
1598
1599         Reviewed by Eric Seidel.
1600
1601         Move RegressionWindow further up the dependency chain
1602         https://bugs.webkit.org/show_bug.cgi?id=46698
1603
1604         Baby steps towards pushing this information into bug posts.
1605
1606         * Scripts/webkitpy/common/net/buildbot.py:
1607         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1608         * Scripts/webkitpy/common/net/regressionwindow.py:
1609         * Scripts/webkitpy/tool/commands/queries.py:
1610
1611 2010-09-27  Daniel Bates  <dbates@rim.com>
1612
1613         Reviewed by Adam Barth.
1614
1615         sheriffbot can't roll out security patches
1616         https://bugs.webkit.org/show_bug.cgi?id=39136
1617
1618         Make SheriffBot determine if it's authorized to view a bug
1619         whose change it wants to rollout before it tries to rollout
1620         the change.
1621
1622         Moreover, make both webkit-patch and Sheriffbot provide human-
1623         readable error messages when they are not authorized to view
1624         a bug and when a bug number is invalid.
1625
1626         Currently, Sheriffbot does not parse Bugzilla bugs for
1627         <bug error="...">, which indicates an error when retrieving
1628         a bug. In particular, error="NotPermitted" if a person (or bot)
1629         is not authorized to view a bug. For such error="NotPermitted" bugs,
1630         Sheriffbot raises an exception when parsing the bug report and
1631         this exception does not explicitly indicate Sheriffbot's lack
1632         of authorization. Instead, Sheriffbot should explicitly check
1633         for the presence <bug error="..."> before operating on a bug
1634         and error with a human-readable message if it's not permitted
1635         to view it.
1636
1637         * Scripts/webkitpy/common/net/bugzilla.py: Added BugzillaError class.
1638         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
1639           - Added unit test test_bug_parsing_for_bugzilla_not_permitted_error().
1640           - Added unit test test_bug_parsing_for_bugzilla_not_found_error().
1641           - Added unit test test_bug_parsing_for_bugzilla_invalid_bug_id_error().
1642         * Scripts/webkitpy/tool/bot/sheriff.py: Modified to catch BugzillaError.
1643         * Scripts/webkitpy/tool/commands/download.py: Ditto.
1644         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
1645         * Scripts/webkitpy/tool/commands/upload.py: Ditto.
1646         * Scripts/webkitpy/tool/steps/closebug.py: Ditto.
1647         * Scripts/webkitpy/tool/steps/obsoletepatches.py: Ditto.
1648         * Scripts/webkitpy/tool/steps/preparechangelog.py: Ditto.
1649         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py: Ditto.
1650
1651 2010-09-27  Adam Barth  <abarth@webkit.org>
1652
1653         Reviewed by Eric Seidel.
1654
1655         Expose more more failure information from Buildbot to SheriffBot
1656         https://bugs.webkit.org/show_bug.cgi?id=46697
1657
1658         This patch moves the information about what tests failured closer to
1659         SheriffBot.  There are still a couple more patches to go before
1660         SheriffBot can post this information to bugs, but this is a step in
1661         that direction.  Yay for unit tests, which caught some bugs in earlier
1662         versions of this patch.
1663
1664         * Scripts/webkitpy/common/net/buildbot.py:
1665         * Scripts/webkitpy/common/net/buildbot_unittest.py:
1666         * Scripts/webkitpy/common/net/regressionwindow.py: Added.
1667         * Scripts/webkitpy/tool/commands/queries.py:
1668
1669 2010-09-27  Eric Seidel  <eric@webkit.org>
1670
1671         Unreviewed.  Fixing 500 error seen in the status server.
1672
1673         It turns out that a = b = []; b.append(1); then a[0] will be 1!
1674         This should have been obvious to me, I guess, but it was not what I was expecting.
1675
1676         * QueueStatusServer/model/activeworkitems.py:
1677
1678 2010-09-27  Adam Barth  <abarth@webkit.org>
1679
1680         Reviewed by Eric Seidel.
1681
1682         commit-queue should reject patches that fail to land
1683         https://bugs.webkit.org/show_bug.cgi?id=46694
1684
1685         This can happen, for example, if there's no reviewer.  Without this
1686         patch, we'll keep retrying the patch.
1687
1688         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1689         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1690
1691 2010-09-27  Simon Fraser  <simon.fraser@apple.com>
1692
1693         Rubber-stamped by Adele Peterson.
1694
1695         Add a harness for running the CSS 2.1 test suite.
1696         
1697         This harness assumes that you've got a local a copy of the suite
1698         adjacent to the 'harness' directory.
1699         
1700         The harness lets you go through the tests in chapter order,
1701         denoting pass/fail/skipped for each test.
1702         
1703         It uses a client-side database to store the results of testing.
1704
1705         * CSSTestSuiteHarness/harness/harness.css: Added.
1706         * CSSTestSuiteHarness/harness/harness.html: Added.
1707         * CSSTestSuiteHarness/harness/harness.js: Added.
1708
1709 2010-09-27  Eric Seidel  <eric@webkit.org>
1710
1711         Reviewed by Adam Barth.
1712
1713         Patch locks should expire if a patch is marked for retry
1714         https://bugs.webkit.org/show_bug.cgi?id=46682
1715
1716         This was part Adam's original CommitQueueTask design,
1717         but support for it was missing from the server.
1718         I added the support, but triggering lock-release based on this
1719         special "retry" status feels a bit strange so I added a FIXME.
1720
1721         I also changed the text in queuestatus.html to say "Lock Acquired"
1722         since "Last Activity" isn't really true.  We only update the lock
1723         date when the patch is started, not on every status update.
1724
1725         I also noticed an exception in next-patch, which I fixed by re-writing
1726         the unzip logic in activeworkitems.py again.
1727
1728         * QueueStatusServer/handlers/updatestatus.py:
1729         * QueueStatusServer/model/activeworkitems.py:
1730         * QueueStatusServer/templates/queuestatus.html:
1731
1732 2010-09-27  Tony Chang  <tony@chromium.org>
1733
1734         Reviewed by David Levin.
1735
1736         [chromium] fix a warning when compiling DRT on 32-bit linux
1737         https://bugs.webkit.org/show_bug.cgi?id=46641
1738
1739         * DumpRenderTree/chromium/TestEventPrinter.cpp:
1740         (DRTPrinter::handleImage):
1741
1742 2010-09-27  Eric Seidel  <eric@webkit.org>
1743
1744         Reviewed by Adam Barth.
1745
1746         queue-status should report when the patch was last locked to a queue
1747         https://bugs.webkit.org/show_bug.cgi?id=46674
1748
1749         This isn't necessarily the best way to expose this information
1750         but having this accessible via the web interface is very
1751         useful until we come up with a nicer way to display this.
1752
1753         I also cleaned up the code in activeworkitems.py a little
1754         to use list comprehensions and to have the code work with
1755         pairs instead of two lists at once.  Eventually I think those
1756         item/time pairs need to be their own little helper class.
1757
1758         * QueueStatusServer/handlers/queuestatus.py:
1759         * QueueStatusServer/model/activeworkitems.py:
1760         * QueueStatusServer/templates/queuestatus.html:
1761
1762 2010-09-27  Tony Chang  <tony@chromium.org>
1763
1764         Reviewed by David Levin.
1765
1766         [chromium] fix detection of missing fonts on DRT
1767         https://bugs.webkit.org/show_bug.cgi?id=46651
1768
1769         * DumpRenderTree/chromium/TestShellGtk.cpp:
1770         (setupFontconfig):  Only print an error message if lohit isn't found in both locations.
1771
1772 2010-09-27  Tony Chang  <tony@chromium.org>
1773
1774         Reviewed by Dimitri Glazkov.
1775
1776         add webkit unit tests to the chromium testers
1777         https://bugs.webkit.org/show_bug.cgi?id=46669
1778
1779         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1780         * Scripts/run-chromium-webkit-unit-tests: Fix a bug where we weren't using the right configuration.
1781
1782 2010-09-27  Kwang Yul Seo  <skyul@company100.net>
1783
1784         Unreviewed.
1785
1786         Adding myself to the committers list.
1787
1788         * Scripts/webkitpy/common/config/committers.py:
1789
1790 2010-09-27  Mihai Parparita  <mihaip@chromium.org>
1791
1792         Reviewed by Eric Seidel.
1793
1794         webkitpy.common.system.user_unittest.UserTest.test_prompt_with_list spams the console
1795         https://bugs.webkit.org/show_bug.cgi?id=46634
1796         
1797         Use OutputCapture to prevent console spam (and also check for expected
1798         output).
1799
1800         * Scripts/webkitpy/common/system/user_unittest.py:
1801
1802 2010-09-27  Eric Seidel  <eric@webkit.org>
1803
1804         Reviewed by James Robinson.
1805
1806         start-commit-queue should abort any rebases in progress
1807         https://bugs.webkit.org/show_bug.cgi?id=46640
1808
1809         webkit-patch commit-queue would do this itself, but this just
1810         helps ensure that the commit-queue script is properly updated
1811         before we run it (in the case where a previous rebase is in
1812         progress the git svn rebase would not work before we run the
1813         commit-queue).
1814
1815         * EWSTools/start-commit-queue.sh:
1816
1817 2010-09-18  Martin Robinson  <mrobinson@igalia.com>
1818
1819         Reviewed by Gustavo Noronha Silva.
1820
1821         [GTK] Clean up the DRT fonts.conf and switch to Liberation
1822         https://bugs.webkit.org/show_bug.cgi?id=46038
1823
1824         Switch to Liberation fonts for GTK+ layout tests. This will make our
1825         test results metric-compatible with many Windows/Chromium results. It
1826         also simplifies the fonts.conf that we load and prepares the way for
1827         fixing many font bugs.
1828
1829         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1830         (initializeFonts): Initialize a known list of fonts instead of loading
1831         every font in the WEBKIT_TESTFONTS directory.
1832         * DumpRenderTree/gtk/fonts.conf: Removed.
1833         * DumpRenderTree/gtk/fonts/AHEM____.TTF: Copied from WebKitTools/DumpRenderTree/qt/fonts/AHEM____.TTF.
1834         * DumpRenderTree/gtk/fonts/fonts.conf: Added.
1835         * GNUmakefile.am: Modify FONTS_CONF_FILE to be FONTS_CONF_DIR, so that
1836         we can load both fonts.conf and AHEM____.TTF from this location.
1837         * Scripts/old-run-webkit-tests: Remove the check for WEBKIT_TESTFONTS, since
1838         it is no longer used.
1839
1840 2010-09-26  Mihai Parparita  <mihaip@chromium.org>
1841
1842         Reviewed by Ojan Vafai.
1843
1844         new-run-webkit-httpd fails if Perl is not installed
1845         https://bugs.webkit.org/show_bug.cgi?id=46602
1846         
1847         Make Port._read_configuration catch all exceptions, since trying to run
1848         perl (because of _webkit_build_directory) when it's not installed throws
1849         a WindowsError or OSError, not an IOError (this became an issue after 
1850         r68268, since ChromiumPort ends up calling Port.default_configuration in
1851         its constructor, which means that we're ending up on this codepath in
1852         non-NRWT cases too, e.g. for the Chromium NaCl tests, which use
1853         new-run-webkit-httpd).
1854
1855         * Scripts/webkitpy/layout_tests/port/base.py:
1856         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1857
1858 2010-09-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1859
1860         Reviewed by Antonio Gomes.
1861
1862         [EFL] Add setting API to set a local storage database path.
1863         https://bugs.webkit.org/show_bug.cgi?id=45446
1864
1865         Add a setting API to set local storage database path.
1866
1867         * EWebLauncher/main.c:
1868         (on_key_down):
1869         (browserCreate):
1870         (main):
1871
1872 2010-09-26  Sam Weinig  <sam@webkit.org>
1873
1874         Reviewed by Anders Carlsson.
1875
1876         Move shared WebKit2 API (used by both bundle and main API) to WebKit2/Shared/API
1877         https://bugs.webkit.org/show_bug.cgi?id=46587
1878
1879         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1880
1881 2010-09-26  Antonio Gomes  <agomes@rim.com>
1882
1883         Reviewed by Kenneth Rohde Christiansen.
1884
1885         DRT/Mac nodesFromRect support
1886
1887         [Mac][DRT] Implement LayoutTestController::nodesFromRect
1888         https://bugs.webkit.org/show_bug.cgi?id=46580
1889
1890         Implements LayoutTestController::nodesFromRect for Mac DRT, and
1891         adding stubs for GTK+ and Windows.
1892
1893         * DumpRenderTree/LayoutTestController.cpp:
1894         (nodesFromRectCallback):
1895         (LayoutTestController::staticFunctions):
1896         * DumpRenderTree/LayoutTestController.h:
1897         (LayoutTestController::LayoutTestController::nodesFromRect):
1898         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1899         (LayoutTestController::nodesFromRect):
1900
1901 2010-09-25  Nicolas Weber  <thakis@chromium.org>
1902
1903         Reviewed by Adam Barth.
1904
1905         https://bugs.webkit.org/show_bug.cgi?id=46555
1906         Fix typo in prepare-ChangeLog's help output.
1907
1908         * Scripts/prepare-ChangeLog:
1909
1910 2010-09-24  Sam Weinig  <sam@webkit.org>
1911
1912         Reviewed by Darin Adler.
1913
1914         Implement WebKit2 callback equivalent to -[WebUIDelegate mouseDidMoveOverElement:modifierFlags:]
1915         <rdar://problem/8359279>
1916         https://bugs.webkit.org/show_bug.cgi?id=46546
1917
1918         * MiniBrowser/mac/BrowserWindowController.m:
1919         (mouseDidMoveOverElement):
1920         (-[BrowserWindowController awakeFromNib]):
1921         * MiniBrowser/win/BrowserView.cpp:
1922         (mouseDidMoveOverElement):
1923         (BrowserView::create):
1924         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1925         (WTR::InjectedBundlePage::InjectedBundlePage):
1926         * WebKitTestRunner/TestController.cpp:
1927         (WTR::createOtherPage):
1928         (WTR::TestController::initialize):
1929
1930 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
1931
1932         Reviewed by Adam Barth.
1933
1934         Allow rebaselines for webkit-patch rebaseline to be chosen
1935         https://bugs.webkit.org/show_bug.cgi?id=46407
1936         
1937         Instead of always rebaselining all failing tests, allow a subset to be
1938         chosen.
1939
1940         * Scripts/webkitpy/common/system/user.py:
1941         * Scripts/webkitpy/tool/commands/rebaseline.py:
1942
1943 2010-09-24  Ryosuke Niwa  <rniwa@webkit.org>
1944
1945         Reviewed by Tony Chang.
1946
1947         [chromium] Implement TextInputController::firstRectForCharacterRange
1948         https://bugs.webkit.org/show_bug.cgi?id=38100
1949
1950         Implemented TextInputController::firstRectForCharacterRange for chromium platform.
1951         No new tests are added since we need to implement the same feature in chromium side
1952         in order to enable any tests that uses this function.
1953
1954         * DumpRenderTree/chromium/TextInputController.cpp:
1955         (TextInputController::firstRectForCharacterRange): Added.
1956
1957 2010-09-24  Adam Barth  <abarth@webkit.org>
1958
1959         Reviewed by Eric Seidel.
1960
1961         commit-queue reports land failures as "PASS"
1962         https://bugs.webkit.org/show_bug.cgi?id=46530
1963
1964         We were ignoring the return value of land instead of passing it back to
1965         CommitQueue.  Of course, this was the one case I forgot to test!
1966
1967         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1968         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1969
1970 2010-09-24  Kenichi Ishibashi  <bashi@google.com>
1971
1972         Reviewed by Eric Seidel.
1973
1974         new-run-webkit-tests prints out nothing when build-dumprendertree fails
1975         https://bugs.webkit.org/show_bug.cgi?id=37563
1976
1977         Print error message when build-dumprendertree fails.
1978
1979         * Scripts/webkitpy/layout_tests/port/webkit.py:
1980         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1981
1982 2010-09-24  Mihai Parparita  <mihaip@chromium.org>
1983
1984         Reviewed by Tony Chang.
1985
1986         NRWT doesn't respect config set with set-webkit-configuration
1987         https://bugs.webkit.org/show_bug.cgi?id=46278
1988         
1989         Use Port.default_configuration() instead of hardcoding Release in
1990         ChromiumPort configuration initialization, so that we still inherit the
1991         configuration set by set-webkit-configuration.
1992
1993         * Scripts/webkitpy/layout_tests/port/chromium.py:
1994         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1995
1996 2010-09-24  Chang Shu  <chang.shu@nokia.com>
1997
1998         Reviewed by Csaba Osztrogonác.
1999
2000         [Qt] Fix the code to check file existence.
2001         https://bugs.webkit.org/show_bug.cgi?id=46465
2002
2003         * QtTestBrowser/main.cpp:
2004         (main):
2005
2006 2010-09-23  Tony Chang  <tony@chromium.org>
2007
2008         Unreviewed, rolling out r68232.
2009         http://trac.webkit.org/changeset/68232
2010
2011         Broken NRWT on the canary bots.
2012
2013         * Scripts/webkitpy/layout_tests/port/chromium.py:
2014
2015 2010-09-23  Dirk Pranke  <dpranke@chromium.org>
2016
2017         Unreviewed, build fix.
2018
2019         r68008 broke new-run-webkit-tests in that the chromium ports no
2020         longer respect set-webkit-configuration. The correct fix for this
2021         is being pursued in bug 46278 (along with a bunch of unit tests),
2022         but in the meantime I'm reverting the particular lines that broke
2023         things. This was tested by hand.
2024
2025         * Scripts/webkitpy/layout_tests/port/chromium.py:
2026
2027 2010-09-23  Sam Weinig  <sam@webkit.org>
2028
2029         Reviewed by Anders Carlsson.
2030
2031         WebKit2 API: Need way to know when a frame is removed from the hierarchy
2032         <rdar://problem/8414062>
2033         https://bugs.webkit.org/show_bug.cgi?id=46432
2034
2035         * MiniBrowser/mac/BrowserWindowController.m:
2036         (didRemoveFrameFromHierarchy):
2037         (-[BrowserWindowController awakeFromNib]):
2038         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2039         (WTR::InjectedBundlePage::InjectedBundlePage):
2040         * WebKitTestRunner/TestController.cpp:
2041         (WTR::TestController::initialize):
2042
2043 2010-09-23  Tony Chang  <tony@chromium.org>
2044
2045         Reviewed by Dimitri Glazkov.
2046
2047         [chromium] implement layoutTestController.sampleSVGAnimationForElementAtTime
2048         https://bugs.webkit.org/show_bug.cgi?id=46426
2049
2050         * DumpRenderTree/chromium/LayoutTestController.cpp:
2051         (LayoutTestController::LayoutTestController):
2052         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2053         * DumpRenderTree/chromium/LayoutTestController.h:
2054
2055 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2056
2057         Reviewed by Nate Chapin.
2058
2059         [GTK] r68199 introduced two test failures
2060         https://bugs.webkit.org/show_bug.cgi?id=46424
2061
2062         Fix a regression handling preference overrides that are attached to boolean properties.
2063
2064         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2065         (LayoutTestController::overridePreference): g_strcasecmp returns 0 when strings match
2066         so we must check for that when converting a string to a boolean.
2067
2068 2010-09-23  Dimitri Glazkov  <dglazkov@chromium.org>
2069
2070         Reviewed by David Levin.
2071
2072         Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
2073         https://bugs.webkit.org/show_bug.cgi?id=46406
2074
2075         This breaks when the method is called with specified size of data (image data), and the
2076         buffer hasn't yet reached this size.
2077
2078         * Scripts/webkitpy/layout_tests/port/server_process.py: Changed to check for values of
2079           index larger than 0.
2080
2081 2010-09-23  Martin Robinson  <mrobinson@igalia.com>
2082
2083         Reviewed by Nate Chapin.
2084
2085         [GTK] Some tests from r68174 fail on the GTK+ bots
2086         https://bugs.webkit.org/show_bug.cgi?id=46396
2087
2088         Simplify LayoutTestController::overridePreference to make it easier for
2089         people unfamiliar with the code to keep the list of preferences up to date.
2090         Add the conversion for enable-hyperlink-auditing.
2091
2092         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2093         (LayoutTestController::overridePreference): Use a simple if-else block to determine
2094         out the property name for overrridePreference. Also simplify the logic for setting
2095         string properties. Add the conversion for enable-hyperlink-auditing.
2096
2097 2010-09-23  Tony Chang  <tony@chromium.org>
2098
2099         Reviewed by David Levin.
2100
2101         [chromium] add caretBrowsingEnabled to WebSettings and DRT
2102         https://bugs.webkit.org/show_bug.cgi?id=46388
2103
2104         * DumpRenderTree/chromium/LayoutTestController.cpp:
2105         (LayoutTestController::overridePreference):
2106         * DumpRenderTree/chromium/WebPreferences.cpp:
2107         (WebPreferences::reset):
2108         (WebPreferences::applyTo):
2109         * DumpRenderTree/chromium/WebPreferences.h:
2110
2111 2010-09-23  Nate Chapin  <japhet@chromium.org>
2112
2113         Reviewed by Darin Fisher.
2114
2115         Allow DRT to toggle hyperlink auditing (i.e., <a ping>).
2116         https://bugs.webkit.org/show_bug.cgi?id=30458
2117
2118         * DumpRenderTree/chromium/LayoutTestController.cpp:
2119         (LayoutTestController::overridePreference):
2120         * DumpRenderTree/chromium/WebPreferences.cpp:
2121         (WebPreferences::reset):
2122         (WebPreferences::applyTo):
2123         * DumpRenderTree/chromium/WebPreferences.h:
2124         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2125         (resetDefaultsToConsistentValues):
2126         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2127         (LayoutTestController::overridePreference):
2128
2129 2010-09-21  Stephen White  <senorblanco@chromium.org>
2130
2131         Reviewed by David Levin.
2132
2133         Implement --enable-accelerated-2d-canvas flag in DumpRenderTree.
2134         https://bugs.webkit.org/show_bug.cgi?id=46208
2135
2136         This flag allows the layout tests to be run with or without accelerated
2137         2D canvas rendering.
2138
2139         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2140         (main):
2141         Declare the new flag string, and check for it on startup.
2142         * DumpRenderTree/chromium/TestShell.cpp:
2143         (TestShell::TestShell):
2144         Add a boolean for the new flag, in order to preserve its value over
2145         preferences reset.
2146         (TestShell::resetWebSettings):
2147         Set the new flag to the stored value on reset.
2148         * DumpRenderTree/chromium/TestShell.h:
2149         (TestShell::setAccelerated2dCanvasEnabled):
2150         Add an accessor for the new flag.
2151         * DumpRenderTree/chromium/WebPreferences.cpp:
2152         (WebPreferences::reset):
2153         Initialize the new flag to false.
2154         (WebPreferences::applyTo):
2155         Copy the flag's value to the WebSettings.
2156         * DumpRenderTree/chromium/WebPreferences.h:
2157         Add the new flag.
2158
2159 2010-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2160
2161         Reviewed by Simon Hausmann.
2162
2163         [Qt] Refactor QtWebKitPlatformPlugin interface
2164
2165         Make it easier to keep source-compability for the
2166         QtWebKitPlatformPlugin interface, and run qmake
2167         on the example (but not build) for convenience. 
2168
2169         https://bugs.webkit.org/show_bug.cgi?id=46345
2170
2171         * Scripts/webkitdirs.pm:
2172
2173 2010-09-23  Adam Barth  <abarth@webkit.org>
2174
2175         Reviewed by Eric Seidel.
2176
2177         Tweak some status messages that Eric thought were confusing
2178         https://bugs.webkit.org/show_bug.cgi?id=46342
2179
2180         * Scripts/webkitpy/tool/commands/queues.py:
2181         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2182
2183 2010-09-22  Adam Barth  <abarth@webkit.org>
2184
2185         Reviewed by Eric Seidel.
2186
2187         Fix comm-queue typo
2188         https://bugs.webkit.org/show_bug.cgi?id=46339
2189
2190         We were missing a "self".  The real problem is that we didn't have an
2191         integration test for the failure case.
2192
2193         * Scripts/webkitpy/tool/commands/queues.py:
2194         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2195
2196 2010-09-22  Adam Barth  <abarth@webkit.org>
2197
2198         Reviewed by Eric Seidel.
2199
2200         commit-queue should log more detailed messages to the QueueStatusServer
2201         https://bugs.webkit.org/show_bug.cgi?id=46333
2202
2203         When I created CommitQueueTask, I removed most of the previous logging.
2204         This patch adds back more detailed logging so folks can see their patch
2205         progress through the queue.
2206
2207         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2208         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2209         * Scripts/webkitpy/tool/commands/queues.py:
2210         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2211
2212 2010-09-22  Mihai Parparita  <mihaip@chromium.org>
2213
2214         Reviewed by Darin Fisher.
2215
2216         [Chromium] User style layout tests don't pass on Chromium
2217         https://bugs.webkit.org/show_bug.cgi?id=46069
2218
2219         Fix a typo in LayoutTestController::addUserStyleSheet that was causing a
2220         crash the Chromium DRT. Pass InjectInExistingDocuments to mimic DRT
2221         behavior from other ports.
2222
2223         * DumpRenderTree/chromium/LayoutTestController.cpp:
2224         (LayoutTestController::addUserStyleSheet):
2225
2226 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2227
2228         Reviewed by Martin Robinson.
2229
2230         [WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
2231         https://bugs.webkit.org/show_bug.cgi?id=46303.
2232
2233         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added.
2234         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Moved
2235         CoreFoundation-specific stuff to new MiniBrowserCoreFoundation
2236         property sheet.
2237         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added.
2238         * MiniBrowser/MiniBrowser.vcproj: Updated configuration to use
2239         appropriate property sheet for the build types.
2240         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Updated the
2241         configuration to use appropriate property sheet for CoreFoundation
2242         and CFLite-style builds.
2243
2244 2010-09-22  Adam Barth  <abarth@webkit.org>
2245
2246         Reviewed by Eric Seidel.
2247
2248         Optimize commit-queue performance for green trees
2249         https://bugs.webkit.org/show_bug.cgi?id=46254
2250
2251         This patch redesigns the controller logic for the commit-queue.  In the
2252         new design, the controller exercises much finer-grained control over
2253         the landing process.  In particular:
2254
2255         - Patches that fail to apply now get rejected almost immediately.
2256         - Patches that fail to build get rejects after two builds (instead of
2257           three builds and one test run).
2258         - Patches that run into a flaky test now get accepted after one build
2259           and two test runs instead of three full build-and-test runs.
2260
2261         The main cost of these optimizations is that we don't find out the tree
2262         has a failing test until the very end of the process, but if the tree
2263         has a busted test, there's not much we can do anyway.  We might as well
2264         burn commit-queue resources spinning optimisticly.
2265
2266         * Scripts/webkitpy/tool/bot/commitqueuetask.py: Added.
2267         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: Added.
2268         * Scripts/webkitpy/tool/commands/queues.py:
2269
2270 2010-09-22  Brent Fulgham  <bfulgham@webkit.org>
2271
2272         Reviewed by Martin Robinson.
2273
2274         [WinCairo] Update WebKitTestRunner and DumpRenderTree Build.
2275         https://bugs.webkit.org/show_bug.cgi?id=46303.
2276
2277         * DumpRenderTree/win/DumpRenderTree.vcproj: Disable local MD5 sources
2278         for Cairo build. Copy wtf MD5 header to ForwardingHeaders for the
2279         WinCairo build.
2280         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added.
2281         * WebKitTestRunner/win/InjectedBundle.vcproj: Update win new *_Cairo
2282         build targets that use the new InjectedBundleCFLite.vsprops file.
2283
2284 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2285
2286         Unreviewed, build fix.
2287
2288         Fix bustage of rebaseline-chromium-webkit-tests resulting from
2289         r67974. Really need better unit tests for this tool :(
2290
2291         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2292
2293 2010-09-22  Adam Roben  <aroben@apple.com>
2294
2295         Unbreak test-webkitpy
2296
2297         * Scripts/webkitpy/test/main.py:
2298         (Tester.run_tests): Add a line that mysteriously got deleted.
2299
2300 2010-09-22  Adam Roben  <aroben@apple.com>
2301
2302         Make test-webkitpy test WebKit2's scripts
2303
2304         These scripts can't be in WebKitTools due to limitations of Apple's
2305         build process. But that doesn't mean we can't test them!
2306
2307         Fixes <http://webkit.org/b/46297> test-webkitpy should test code in
2308         WebKit2/Scripts
2309
2310         Reviewed by Adam Barth.
2311
2312         * Scripts/test-webkitpy:
2313         (_clean_packages_with_test): Renamed from _clean_webkitpy_with_test.
2314         Now takes an external_package_paths parameter and cleans both webkitpy
2315         and any external packages.
2316         (init): Added an external_package_paths parameter which we pass along
2317         to _clean_packages_with_test.
2318         (top level): Add WebKit2/Scripts/webkit2 as our only external package
2319         and pass it along to init and Tester.run_tests.
2320
2321         * Scripts/webkitpy/test/main.py:
2322         (Tester.run_tests): Added an optional external_package_paths
2323         parameter. We modify sys.path so that the external packages can be
2324         imported, and search for unittest files inside all external packages
2325         in addition to inside webkitpy.
2326
2327 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2328
2329         Reviewed by Tony Chang.
2330
2331         new-run-webkit-tests: r68063 broke linux python tests
2332
2333         Add a missing "from __future__ import with_statement" to this
2334         new file; the perils of testing only on the Mac and by review :(
2335
2336         https://bugs.webkit.org/show_bug.cgi?id=46293
2337
2338         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2339
2340 2010-09-22  Dirk Pranke  <dpranke@chromium.org>
2341
2342         Reviewed by Tony Chang.
2343
2344         Add a 'chromium-gpu' set of ports that will test the accelerated
2345         GPU paths. This patch adds:
2346
2347         - support for the '--accelerated-compositing' and
2348           'accelerated-2d-canvas' flags to new-run-webkit-tests (and the
2349           'no-' flags)
2350         - adds a new set of Ports that will look under
2351           platform/chromium-gpu-$OS/ for baselines before looking in the
2352           regular chromium search path
2353         - adds a new test_expectations.txt file in platform/chromium-gpu
2354           that skips all but the tests we actually want to run with
2355           acceleration.
2356
2357         This patch will allow us to run both with and without acceleration
2358         and to change the defaults for both the regular and -gpu options
2359         as the code evolves.
2360
2361         We plan to add both --chromium-$OS and --chromium-gpu-$OS runs to
2362         each test bot.
2363
2364         https://bugs.webkit.org/show_bug.cgi?id=46225
2365
2366         * Scripts/webkitpy/layout_tests/port/chromium.py:
2367         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2368         * Scripts/webkitpy/layout_tests/port/factory.py:
2369         * Scripts/webkitpy/layout_tests/port/webkit.py:
2370
2371 2010-09-22  Jamey Hicks  <jamey.hicks@nokia.com>
2372
2373         Reviewed by Kenneth Rohde Christiansen.
2374
2375         [Qt] Web Inspector: Remote Web Inspector support for QtWebKit
2376         https://bugs.webkit.org/show_bug.cgi?id=43988
2377
2378         Runs a web debug server on port specified by QtTestBrowser
2379         argument -remote-inspector-port. Property
2380         _q_webInspectorServerPort of the QWebPage instance will be set
2381         according to the argument. All pages with that property set will
2382         be remotely inspectable.
2383
2384         URL for remote inspection of first QWebPage is
2385             http://localhost:9222/webkit/inspector/inspector.html?page=1
2386         where 1 is the number of the QWebPage instance.
2387
2388         The base URL yields an index page with links to the individual inspectors:
2389             http://localhost:9222/
2390
2391         * QtTestBrowser/launcherwindow.cpp:
2392         (LauncherWindow::init):
2393         * QtTestBrowser/launcherwindow.h:
2394         * QtTestBrowser/main.cpp:
2395         (LauncherApplication::handleUserOptions):
2396
2397 2010-09-22  Adam Roben  <aroben@apple.com>
2398
2399         Fix webkit-patch failure-reason now that build.webkit.org has been
2400         updated
2401
2402         Fixes <http://webkit.org/b/46273> webkit-patch failure-reason crashes
2403         every time
2404
2405         Reviewed by Eric Seidel.
2406
2407         * Scripts/webkitpy/common/net/buildbot.py:
2408         (BuildBot._file_cell_text): Added. Travels down the firstChild chain
2409         looking for an element that contains text, then returns it.
2410         (BuildBot._parse_twisted_file_row): Use _file_cell_text to get the
2411         text out of the cells. This way it doesn't matter whether the cells
2412         have <b> children (as for cells in directory rows) or not (as for
2413         cells in file rows)
2414         (BuildBot._parse_twisted_directory_listing): Look for rows that have
2415         the "directory" or "file" class, rather than rows with any class,
2416         since header rows now have a class attribute.
2417
2418         * Scripts/webkitpy/common/net/buildbot_unittest.py:
2419         (BuildBotTest._example_directory_listing): Updated to more closely
2420         match the markup that build.webkit.org is producing now.
2421
2422 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2423
2424         Unreviewed, build fix.
2425
2426         new-run-webkit-tests: fix bug introduced in r68008 where if you
2427         specify --chromium and no --platform, and you're running on
2428         windows, you use the 'chromium-win' port by default instead of the
2429         version-specific port. This breaks the buildbots.
2430
2431         It will be good for this refactoring to settle down so I can
2432         rewrite the logic for default ports and the unit tests to be
2433         clearer (and the testing more comprehensive).
2434
2435         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2436
2437 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2438
2439         Reviewed by Adam Barth.
2440
2441         Modify the Port interface to take only a series of keyword arguments
2442         in the constructor, and modify Port/factory.get() to accomodate that,
2443         and to accept user=XXX as an argument so we can pass
2444         webkitpy.common.system.user.User objects in.
2445
2446         Then, modify new-run-webkit-tests and rebaseline-chromium-webkit-tests
2447         to use the common routine in webkitpy.common.system.user.open_url()
2448         to display HTML files.
2449
2450         There was a routine in the Port interface to do the same thing,
2451         but I see no need for a port-specific hook for this, since it is
2452         something that will always be executed by the host environment
2453         and displaying web pages has nothing to do with running layout tests.
2454
2455         Note that new-run-webkit-tests used to use test_shell to display
2456         the page; this is potentially useful so that you can actually click
2457         from a result to the broken page; however, since DumpRenderTree
2458         doesn't support this functionality, it will be going away eventually.
2459
2460         https://bugs.webkit.org/show_bug.cgi?id=46128
2461
2462         * Scripts/webkitpy/layout_tests/port/base.py:
2463         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2464         * Scripts/webkitpy/layout_tests/port/chromium.py:
2465         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2466         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2467         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2468         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2469         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2470         * Scripts/webkitpy/layout_tests/port/factory.py:
2471         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2472         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2473         * Scripts/webkitpy/layout_tests/port/gtk.py:
2474         * Scripts/webkitpy/layout_tests/port/mac.py:
2475         * Scripts/webkitpy/layout_tests/port/qt.py:
2476         * Scripts/webkitpy/layout_tests/port/test.py:
2477         * Scripts/webkitpy/layout_tests/port/webkit.py:
2478         * Scripts/webkitpy/layout_tests/port/win.py:
2479         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2480         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2481         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2482
2483 2010-09-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2484
2485         Reviewed by Kenneth Rohde Christiansen.
2486
2487         [EFL] Get fresh theme when running EWebLauncher
2488         https://bugs.webkit.org/show_bug.cgi?id=46210
2489
2490         If user tried to run EWebLauncher outside of the build tree, it would
2491         not find the theme and fallback to the installed one. However, since
2492         EWebLauncher is not installed, we always want to take the theme from
2493         the just compiled source code. If user had never installed WebKit's
2494         EFL port it could even receive a segv since no theme would be found.
2495
2496         Now EWebLauncher does not fallback to the installed theme and CMake
2497         gives as DATA_DIR the directory of the theme it has just built.
2498
2499         * CMakeListsEfl.txt: Pass the build directory as DATA_DIR to
2500         EWebLauncher.
2501         * EWebLauncher/main.c: Use only the theme from build director. Do not
2502         fallback to others as this could hide real bugs.
2503         (quit):
2504         (browserCreate):
2505         (findThemePath):
2506         (main):
2507
2508 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2509
2510         Unreviewed, build fix.
2511
2512         Don't pass the --test-shell arg to the Chromium Mac port of DRT;
2513         it just confuses it.
2514
2515         https://bugs.webkit.org/show_bug.cgi?id=46230
2516
2517         * Scripts/webkitpy/layout_tests/port/webkit.py:
2518
2519 2010-09-21  Lucas Forschler  <lforschler@apple.com>
2520
2521         Reviewed by Stephanie Lewis.
2522
2523         Make a new buildbot for Leopard Debug Test
2524
2525         * BuildSlaveSupport/build.webkit.org-config/config.json:
2526
2527 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2528
2529         Unreviewed, build fix.
2530
2531         Fix breakage of Chromium Mac DRT port caused by r67905.
2532
2533         https://bugs.webkit.org/show_bug.cgi?id=46230
2534
2535         * Scripts/webkitpy/layout_tests/port/webkit.py:
2536
2537 2010-09-21  Dirk Pranke  <dpranke@chromium.org>
2538
2539         Unreviewed, build fix.
2540
2541         Add missing import of 'tempfile'.
2542
2543         * Scripts/webkitpy/layout_tests/port/chromium.py:
2544
2545 2010-09-17  Dirk Pranke  <dpranke@chromium.org>
2546
2547         Reviewed by Ojan Vafai.
2548
2549         new-run-webkit-tests: pull the list of tests from the Port, and
2550            make it possible to run with no actual test files in the filesystem.
2551
2552         This set of changes allows us to delete the special
2553         webkitpy/layout_tests/data directory and test the generic code without
2554         touching the filesystem (except to write results). This speeds up
2555         test-webkitpy substantially.
2556
2557         This also cleans up and removes several code paths in the generic
2558         code and fixes some minor bugs, notably in the test_expectations
2559         parsing, which was previously fragile if the tests weren't present.
2560
2561         We also change the way we diff image results to be able to do so
2562         in memory, without relying on files. This slows down chromium
2563         test_shell, which always writes images to files, but should speed
2564         up DRT and ImageDiff-based implementations slightly.
2565
2566         Note that pulling the list of tests to run from the Port will allow
2567         ports to specify what tests to run as an inclusive list; previously
2568         you could only do this as an exclusive list by using a 
2569         test_expectations file or Skipped files; nothing actually uses this
2570         feature yet and it's unclear if it should be used.
2571
2572         Note that there are no functional changes -- apart from now 
2573         always printing out the location of the checksum file when we are
2574         tracing test runs -- and the total number of lines of non-test code
2575         actually drops by two.
2576
2577         There is some more cleanup that can be done in the Port/Driver 
2578         interface and in some handling of filenames, but I'll save that
2579         for another change.
2580
2581         https://bugs.webkit.org/show_bug.cgi?id=45801
2582
2583         * Scripts/webkitpy/layout_tests/data/*: Removed.
2584             - no longer need special mock layout_tests_directory in the
2585               repository.
2586         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2587             - add code to display missing text files, checksums when tracing
2588             - update to not look at the filesystem directly.
2589         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2590             - add more unit tests
2591         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2592             - remove tests_are_present flag
2593             - update with changes in Port interface - no longer access
2594               the filesystem directly, although we still use os.path for
2595               filename manipulation.
2596         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2597             - add more unit tests
2598         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Removed.
2599             - renamed to port/test_files.py
2600         * Scripts/webkitpy/layout_tests/port/base.py:
2601             - change diff_image() to expect actual image data, not filenames
2602             - add expected_checksum(), expected_image(), expected_text() to
2603               return the content of the files so that we don't need a filesystem
2604             - add path_exists(), path_isdir() for filesystem-like access.
2605             - add test_dirs() to keep clobber-test-results from needing to
2606               actually look at a real layout tests dir
2607             - add tests() to return the list of tests to run on the port
2608               (calls port/test_files to do the work).
2609             - add update_baseline() to be able to save new baselines
2610             - add uri_to_test_name() from port/dryrun.py so we can easily check
2611               filename_to_uri()
2612         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2613             - add more unit tests
2614         * Scripts/webkitpy/layout_tests/port/chromium.py:
2615             - change diff_image() to accept image content, not filenames.
2616               This will be slower for test_shell/image_diff, but faster
2617               for DRT/ImageDiff.
2618         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2619             - add more unit tests
2620         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2621             - simplify greatly
2622         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2623             - add more unit tests
2624         * Scripts/webkitpy/layout_tests/port/test.py:
2625             - massive rewrite to use in-script list of tests and expectations
2626         * Scripts/webkitpy/layout_tests/port/test_files.py:
2627             - rename from layout_package/test_files.
2628         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2629             - add unit tests
2630         * Scripts/webkitpy/layout_tests/port/webkit.py:
2631             - update diff_image() to take image contents, not files. Should
2632               make things slightly faster.
2633         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2634             - update with changes to diff_image()
2635         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2636             - update with changes to diff_image()
2637         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2638             - remove tests_are_present from test_expectations
2639             - pull the list of tests from port.tests() instead
2640               of calling test_files.py directly.
2641         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2642             - update unit tests
2643         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2644             - update with changes to 
2645         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2646             - update with change in Port interface
2647         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2648             - update with change in Port interface
2649         * Scripts/webkitpy/style/checkers/test_expectations.py:
2650             - remove the tests_are_present flag
2651
2652 2010-09-21  Anders Carlsson  <andersca@apple.com>
2653
2654         Disable logging.
2655
2656         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
2657
2658 2010-09-21  Tony Chang  <tony@chromium.org>
2659
2660         Reviewed by Kent Tamura.
2661
2662         add a script for running webkit_unit_tests
2663         https://bugs.webkit.org/show_bug.cgi?id=46014
2664
2665         * Scripts/run-chromium-webkit-unit-tests: Added.
2666
2667 2010-09-21  Fridrich Strba  <fridrich.strba@bluewin.ch>
2668
2669         Reviewed by Martin Robinson.
2670
2671         Fix linking problems on Windows.
2672         https://bugs.webkit.org/show_bug.cgi?id=45844
2673
2674         * GNUmakefile.am: link the executables with winmm.dll
2675
2676 2010-09-21  Adam Barth  <abarth@webkit.org>
2677
2678         Reviewed by Eric Seidel.
2679
2680         feeder-queue svn updates more often than needed
2681         https://bugs.webkit.org/show_bug.cgi?id=46171
2682
2683         We don't need to poll SVN every time we feed the feeders.  Rather, we
2684         can count on the wrapper shell script to auto-update the queue.
2685
2686         * Scripts/webkitpy/tool/commands/queues.py:
2687         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2688
2689 2010-09-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2690
2691         Reviewed by Andreas Kling.
2692
2693         [Qt] Add robot loader timeout and extra time options.
2694         https://bugs.webkit.org/show_bug.cgi?id=46172
2695
2696         [-robot-timeout <s>]: Load the next page after s seconds if the current
2697         page didn't finish loading.
2698         [-robot-extra-time <s>]: Wait s seconds after the current page finished
2699         loading before loading the next one. This should allow some time for the
2700         page's JavaScript to execute.
2701
2702         * QtTestBrowser/launcherwindow.cpp:
2703         (LauncherWindow::applyPrefs):
2704         * QtTestBrowser/main.cpp:
2705         (LauncherApplication::robotTimeout):
2706         (LauncherApplication::robotExtraTime):
2707         (LauncherApplication::LauncherApplication):
2708         (LauncherApplication::handleUserOptions):
2709         (main):
2710         * QtTestBrowser/urlloader.cpp:
2711         (UrlLoader::UrlLoader):
2712         (UrlLoader::loadNext):
2713         (UrlLoader::loadUrlList):
2714         * QtTestBrowser/urlloader.h:
2715
2716 2010-09-21  Pavel Podivilov  <podivilov@chromium.org>
2717
2718         Unreviewed.
2719
2720         Adding myself to the committers list.
2721
2722         * Scripts/webkitpy/common/config/committers.py:
2723
2724 2010-09-20  Philippe Normand  <pnormand@igalia.com>
2725
2726         Reviewed by Eric Carlson.
2727
2728         [GTK] enhanced context menu for media elements
2729         https://bugs.webkit.org/show_bug.cgi?id=45021
2730
2731         EventSender::contextClick() now returns an array of js
2732         objects. Each object has a title property and a click() method.
2733
2734         * DumpRenderTree/gtk/EventSender.cpp:
2735         (getMenuItemTitleCallback):
2736         (setMenuItemTitleCallback):
2737         (menuItemClickCallback):
2738         (getMenuItemClass):
2739         (contextClickCallback):
2740
2741 2010-09-20  Hayato Ito  <hayato@chromium.org>
2742
2743         Unreviewed.
2744         Adding myself to the committers list.
2745
2746         * Scripts/webkitpy/common/config/committers.py:
2747
2748 2010-09-20  Adam Barth  <abarth@webkit.org>
2749
2750         Reviewed by Eric Seidel.
2751
2752         The tool member variable should be called _tool
2753         https://bugs.webkit.org/show_bug.cgi?id=46160
2754
2755         Created by find-and-replace.
2756
2757         * Scripts/webkitpy/tool/commands/download.py:
2758         * Scripts/webkitpy/tool/commands/openbugs.py:
2759         * Scripts/webkitpy/tool/commands/queries.py:
2760         * Scripts/webkitpy/tool/commands/queues.py:
2761         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2762         * Scripts/webkitpy/tool/commands/rebaseline.py:
2763         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2764         * Scripts/webkitpy/tool/commands/upload.py:
2765         * Scripts/webkitpy/tool/multicommandtool.py:
2766
2767 2010-09-20  Adam Barth  <abarth@webkit.org>
2768
2769         I ran the tests before landing but ignored the fact that they failed.  :(
2770
2771         * Scripts/webkitpy/tool/commands/queues.py:
2772
2773 2010-09-20  Adam Barth  <abarth@webkit.org>
2774
2775         Reviewed by Eric Seidel.
2776
2777         Add a feeder queue that polls bugs.webkit.org for the commit-cluster
2778         https://bugs.webkit.org/show_bug.cgi?id=46141
2779
2780         The feeder-queue polls bugs.webkit.org every 30 seconds and updates the
2781         list of work items on the status server.  The individual commit-cluster
2782         nodes then grab the patches from the server and process them.
2783
2784         * Scripts/webkitpy/tool/bot/feeders.py: Added.
2785         * Scripts/webkitpy/tool/bot/feeders_unittest.py: Added.
2786         * Scripts/webkitpy/tool/commands/queues.py:
2787         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2788         * Scripts/webkitpy/tool/commands/queuestest.py:
2789
2790 2010-09-20  Leandro Pereira  <leandro@profusion.mobi>
2791
2792         Reviewed by Darin Adler.
2793
2794         build-webkit: Add support for CMake build system
2795         https://bugs.webkit.org/show_bug.cgi?id=44979
2796
2797         * Scripts/build-webkit: Add "--efl" command-line option to build the
2798         EFL port of WebKit.
2799         * Scripts/webkitdirs.pm: Define buildCMakeProject() and
2800         buildEflCMakeProject() subroutines.
2801
2802 2010-09-20  Dirk Pranke  <dpranke@chromium.org>
2803
2804         Reviewed by Ojan Vafai.
2805
2806         new-run-webkit-tests: refactor command line args getting passed to DRT
2807
2808         This change cleans up some argument parsing between functions to get
2809         rid of some overlapping data structures. There should be no functional
2810         changes in this patch; it is pure refactoring in preparation for
2811         landing the Chrome GPU port and adding a generic way to pass
2812         args to DRT/TestShell.
2813
2814         https://bugs.webkit.org/show_bug.cgi?id=46135
2815
2816         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2817           - pass the options argument explicitly to the threads and drivers,
2818             also consolidate the passing of options to the driver.
2819           - pass options directly to process_output() to remove a couple
2820             parameters (minor cleanup).
2821         * Scripts/webkitpy/layout_tests/port/base.py:
2822           - pass the options argument to Port.create_driver().
2823         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2824           - update Port.create_driver() test
2825         * Scripts/webkitpy/layout_tests/port/chromium.py:
2826           - pass the options argument to Port.create_driver(), and clean up
2827             building of the cmd line for DRT.
2828         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2829           - pass the options argument to Port.create_driver()
2830         * Scripts/webkitpy/layout_tests/port/test.py:
2831           - pass the options argument to Port.create_driver()
2832         * Scripts/webkitpy/layout_tests/port/webkit.py:
2833           - pass the options argument to Port.create_driver(), and clean up
2834             building of the cmd line for DRT.
2835         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2836           - consolidate args in _get_dump_render_tree_args and rename to
2837             _get_test_args(); move all of the command-line args to the
2838             Port implementations.
2839
2840 2010-09-20  Andrew Wilson  <atwilson@chromium.org>
2841
2842         Revert change which was accidentally committed along with some expectation changes.
2843
2844         * Scripts/webkitpy/layout_tests/port/base.py:
2845
2846 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
2847
2848         Reviewed by Adam Barth.
2849
2850         Add explicit --force-patch flag to webkitpy tools
2851         https://bugs.webkit.org/show_bug.cgi?id=46103
2852         
2853         It wasn't obvious until I read the applypatch.py source code that
2854         --non-interfactive implies passing --force to patch. Add --force-patch
2855         as an alias to the flag, so that this behavior is more discoverable.
2856
2857         * Scripts/webkitpy/tool/steps/applypatch.py:
2858         * Scripts/webkitpy/tool/steps/options.py:
2859
2860 2010-09-20  Eric Seidel  <eric@webkit.org>
2861
2862         Unreviewed, adding a line which got dropped and is trivially correct (and tested).
2863
2864         commit-queue can't land patches
2865         https://bugs.webkit.org/show_bug.cgi?id=46138
2866
2867         Add a line of code I forgot in my last commit.
2868
2869         * Scripts/webkitpy/common/net/bugzilla.py:
2870         * Scripts/webkitpy/common/net/bugzilla_unittest.py:
2871
2872 2010-09-20  Adam Barth  <abarth@webkit.org>
2873
2874         Reviewed by Eric Seidel.
2875
2876         The commit-cluster bots still race to lock patch_ids
2877         https://bugs.webkit.org/show_bug.cgi?id=46130
2878
2879         It turns out we need to use a transaction object to make the
2880         read/modify/write lock operation atomic.  From reading the AppEngine
2881         documentation, I think this patch should do what we want.  It's hard to
2882         test locally because the test instance isn't distributed in the same
2883         way the production instance is.
2884
2885         * QueueStatusServer/handlers/nextpatch.py:
2886         * QueueStatusServer/model/activeworkitems.py: Added.
2887
2888 2010-09-20  Andy Estes  <aestes@apple.com>
2889
2890         Reviewed by Adam Barth.
2891
2892         REGRESSION (HTML5 Parser): Pages broken due to <tag<tag> parsing changes
2893         https://bugs.webkit.org/show_bug.cgi?id=40961
2894
2895         Implement WebKitUsePreHTML5ParserQuirks preference.
2896
2897         * DumpRenderTree/mac/DumpRenderTree.mm:
2898         (resetDefaultsToConsistentValues): Reset WebKitUsePreHTML5ParserQuirks
2899         to false after a test finishes.
2900
2901 2010-09-20  Adam Roben  <aroben@apple.com>
2902
2903         Windows build fix
2904
2905         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Put
2906         $(WebKitOutputDir)\include before $(WebKitLibrariesDir)\include so
2907         we'll pick up the most recent versions of the headers.
2908
2909 2010-09-20  Eric Seidel  <eric@webkit.org>
2910
2911         Reviewed by Adam Barth.
2912
2913         commit-queue should check commit-queue+ again just before committing
2914         https://bugs.webkit.org/show_bug.cgi?id=32679
2915
2916         Added a _revalidate_patch check, right before landing.
2917
2918         Since _revalidate_patch passes the patch_id from the work item
2919         back to bugzilla, I had to fix all of the previous queue tests to
2920         use valid attachment ids (that's the majority of this change).
2921
2922         In order to validate that the bug was still open, I had to teach
2923         bugzilla.Bug about open/closed states.
2924
2925         * Scripts/webkitpy/common/net/bugzilla.py:
2926         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2927         * Scripts/webkitpy/tool/commands/queues.py:
2928         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2929         * Scripts/webkitpy/tool/commands/queuestest.py:
2930         * Scripts/webkitpy/tool/mocktool.py:
2931
2932 2010-09-20  Mihai Parparita  <mihaip@chromium.org>
2933
2934         Unreviewed.
2935
2936         Adding myself as a comitter.
2937
2938         * Scripts/webkitpy/common/config/committers.py:
2939
2940 2010-09-20  Adam Barth  <abarth@webkit.org>
2941
2942         Reviewed by Eric Seidel.
2943
2944         Two instances of commit-queue try to process the same patch
2945         https://bugs.webkit.org/show_bug.cgi?id=46113
2946
2947         This patch makes next-patch atomic so that the server won't vend the
2948         same patch twice in the same hour.
2949
2950         * QueueStatusServer/handlers/nextpatch.py:
2951
2952 2010-09-20  Adam Roben  <aroben@apple.com>
2953
2954         Make WebKitTestRunner's wait-to-dump watchdog timer work on Windows
2955
2956         We were previously trying to use a CFRunLoopTimer, but since Windows
2957         doesn't use CFRunLoop on most threads this doesn't work. Now we use a
2958         Windows-style timer on Windows.
2959
2960         I also replaced all uses of "watchdog" with "watchdog timer".
2961
2962         Fixes <http://webkit.org/b/46101> WebKitTestRunner's wait-to-dump
2963         watchdog timer doesn't work on Windows
2964
2965         Reviewed by Anders Carlsson.
2966
2967         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2968         (WTR::InjectedBundlePage::dump): Updated for rename.
2969
2970         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed
2971         platform-specific functions.
2972         (WTR::LayoutTestController::LayoutTestController): Added call to
2973         platformInitialize.
2974         (WTR::LayoutTestController::waitUntilDone): Changed to call
2975         initializeWaitToDumpWatchdogTimerIfNeeded instead of doing the work
2976         right in this function.
2977         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Updated for
2978         rename.
2979
2980         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added new
2981         members needed to support the watchdog timer abstraction. Replaced
2982         some "watchdog"s with "watchdog timer".
2983
2984         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
2985         Added.
2986         (WTR::LayoutTestController::platformInitialize): Does nothing on this
2987         platform.
2988         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Moved here
2989         from LayoutTestController.cpp and changed to use an early return.
2990         (WTR::waitUntilDoneWatchdogTimerFired): Moved here from
2991         LayoutTestController.cpp.
2992         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
2993         Moved code here from LayoutTestController::waitUntilDone and changed
2994         to use an early return.
2995
2996         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
2997         Added.
2998         (WTR::LayoutTestController::platformInitialize): Initialize our
2999         watchdog timer.
3000         (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Added.
3001         Kills and clears the watchdog timer.
3002         (WTR::waitToDumpWatchdogTimerFired): Added. Calls through to the
3003         LayoutTestController member function of the same name.
3004         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
3005         Added. Sets up the timer if it isn't already set.
3006
3007         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added
3008         LayoutTestControllerMac.mm.
3009
3010         * WebKitTestRunner/win/InjectedBundle.vcproj: Added
3011         LayoutTestControllerWin.cpp.
3012
3013 2010-09-20  Martin Robinson  <mrobinson@igalia.com>
3014
3015         Reviewed by Daniel Bates.
3016
3017         [GTK] fast/forms/listbox-selection.html fails
3018         https://bugs.webkit.org/show_bug.cgi?id=45942
3019
3020         Use the gdkModifersFromJSValue helper to parse all appropriate modifier
3021         strings in keyDownCallback.
3022
3023         * DumpRenderTree/gtk/EventSender.cpp:
3024         (keyDownCallback): Use the gdkModifersFromJSValue instead of duplicating the 
3025         modifier parsing logic.
3026
3027 2010-09-19  Sam Weinig  <sam@webkit.org>
3028
3029         Reviewed by Anders Carlsson.
3030
3031         WebKit2 decidePolicyForNavigationAction should include mouse button information
3032         <rdar://problem/8413165>
3033         https://bugs.webkit.org/show_bug.cgi?id=46060
3034
3035         * MiniBrowser/mac/BrowserWindowController.m:
3036         (decidePolicyForNavigationAction):
3037         (decidePolicyForNewWindowAction):
3038
3039 2010-09-19  Daniel Bates  <dbates@rim.com>
3040
3041         Reviewed by Martin Robinson.
3042
3043         Add unit tests for diffs that delete or modify a change log entry
3044         or describe changes that are far apart
3045         https://bugs.webkit.org/show_bug.cgi?id=46046
3046
3047         Add additional unit tests to test change log diffs that contain
3048         deletions or changes that are far apart from each other in the
3049         ChangeLog file.
3050
3051         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3052           - Added the following unit tests:
3053           "fixChangeLogPatch: [no change] In-place change."
3054           "fixChangeLogPatch: [no change] Remove first entry."
3055           "fixChangeLogPatch: [no change] Remove entry in the middle."
3056           "fixChangeLogPatch: [no change] Far apart changes (i.e. more than one chunk)."
3057
3058 2010-09-19  Sam Weinig  <sam@webkit.org>
3059
3060         Reviewed by Anders Carlsson.
3061
3062         Replace WKBundleRangeRef with WKBundleRangeHandleRef.
3063         https://bugs.webkit.org/show_bug.cgi?id=46054
3064
3065         The new one acts like WKBundleNodeHandleRef and allows for getting a
3066         wrapper in a specific world for the handle.
3067
3068         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3069         (WTR::propertyValue):
3070         (WTR::propertyValueDouble):
3071         (WTR::propertyValueInt):
3072         (WTR::numericWindowPropertyValue):
3073         (WTR::toStr):
3074         (WTR::InjectedBundlePage::shouldBeginEditing):
3075         (WTR::InjectedBundlePage::shouldEndEditing):
3076         (WTR::InjectedBundlePage::shouldInsertNode):
3077         (WTR::InjectedBundlePage::shouldInsertText):
3078         (WTR::InjectedBundlePage::shouldDeleteRange):
3079         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3080         (WTR::InjectedBundlePage::shouldApplyStyle):
3081         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3082
3083 2010-09-19  Kent Tamura  <tkent@chromium.org>
3084
3085         Unreviewed. Fix WebGL test regressions by r67809.
3086
3087         * DumpRenderTree/chromium/WebPreferences.cpp:
3088         (WebPreferences::applyTo): Call setExperimentalWebGLEnabled().
3089
3090 2010-09-19  Kent Tamura  <tkent@chromium.org>
3091
3092         Reviewed by Adam Barth.
3093
3094         [DRT/Chromium] Fix a WebSettings handling bug
3095         https://bugs.webkit.org/show_bug.cgi?id=45945
3096
3097         Before this change, Chromium DRT reset WebSettings for every new
3098         window. It was wrong.
3099         If new window is not the first one, we have to apply the same
3100         settings as the first window.  So, we introduce WebPreference to
3101         store the current settings, and apply it to new windows. It's same
3102         as test_shell's behavior.
3103
3104         * DumpRenderTree/DumpRenderTree.gypi:
3105         * DumpRenderTree/chromium/LayoutTestController.cpp:
3106           Use WebPreferences instead of WebSettings.
3107         (LayoutTestController::setUserStyleSheetEnabled):
3108         (LayoutTestController::setUserStyleSheetLocation):
3109         (LayoutTestController::setAuthorAndUserStylesEnabled):
3110         (LayoutTestController::setPopupBlockingEnabled):
3111         (LayoutTestController::disableImageLoading):
3112         (LayoutTestController::setJavaScriptCanAccessClipboard):
3113         (LayoutTestController::setXSSAuditorEnabled):
3114         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
3115         (LayoutTestController::setAllowFileAccessFromFileURLs):
3116         (LayoutTestController::overridePreference):
3117         (LayoutTestController::setEditingBehavior):
3118         * DumpRenderTree/chromium/TestShell.cpp:
3119         (TestShell::resetWebSettings): Use WebPreferences.
3120         (TestShell::runFileTest): ditto.
3121         (TestShell::createNewWindow): Apply existing WebPreferences to a new WebView.
3122         * DumpRenderTree/chromium/TestShell.h:
3123         (TestShell::preferences):
3124         (TestShell::applyPreferences):
3125         * DumpRenderTree/chromium/WebPreferences.cpp: Added.
3126         * DumpRenderTree/chromium/WebPreferences.h: Added.
3127
3128 2010-09-18  Prasad Tammana  <prasadt@chromium.org>
3129
3130         Reviewed by David Levin.
3131
3132         update-webkit --chromium spitting out a spurious error
3133         https://bugs.webkit.org/show_bug.cgi?id=45868
3134
3135         * Scripts/update-webkit-chromium: Use commandExists() function to check for existence of gclient.
3136
3137 2010-09-18  Sam Weinig  <sam@webkit.org>
3138
3139         Reviewed by Dan Bernstein.
3140
3141         Improve/unify the PageLoadClient interfaces
3142         https://bugs.webkit.org/show_bug.cgi?id=46043
3143
3144         * MiniBrowser/mac/BrowserWindowController.m:
3145         (didStartProvisionalLoadForFrame):
3146         (didReceiveServerRedirectForProvisionalLoadForFrame):
3147         (didFailProvisionalLoadWithErrorForFrame):
3148         (didCommitLoadForFrame):
3149         (didFinishDocumentLoadForFrame):
3150         (didFinishLoadForFrame):
3151         (didFailLoadWithErrorForFrame):
3152         (didReceiveTitleForFrame):
3153         (didFirstLayoutForFrame):
3154         (didFirstVisuallyNonEmptyLayoutForFrame):
3155         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3156         (WTR::InjectedBundlePage::InjectedBundlePage):
3157         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
3158         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
3159         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
3160         (WTR::InjectedBundlePage::didCommitLoadForFrame):
3161         (WTR::InjectedBundlePage::didFinishLoadForFrame):
3162         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
3163         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
3164         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
3165         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3166         * WebKitTestRunner/TestController.cpp:
3167         (WTR::TestController::didReceiveMessageFromInjectedBundle):
3168         (WTR::TestController::didFinishLoadForFrame):
3169         * WebKitTestRunner/TestController.h:
3170
3171 2010-09-17  Eric Seidel  <eric@webkit.org>
3172
3173         Unreviewed.  Adding a shell script I use to run the
3174         commit-queue. Now that multiple machines run the cq,
3175         it makes sense to share the script between them.
3176
3177         * EWSTools/start-commit-queue.sh: Added.
3178
3179 2010-09-17  Brian Weinstein  <bweinstein@apple.com>
3180
3181         Reviewed by Jon Honeycutt.
3182
3183         The colors on the new build.webkit.org (after upgrading the master to 0.8.1) are
3184         slightly harder to read, so this reverts the previous background colors for various
3185         states, making it easier to read.
3186
3187         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3188         (.success):
3189         (.failure):
3190         (.warnings):
3191         (.exception):
3192         (.start,.running,td.building):
3193         (.offline,td.offline):
3194
3195 2010-09-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3196
3197         Unreviewed, rolling out r67692.
3198         http://trac.webkit.org/changeset/67692
3199         https://bugs.webkit.org/show_bug.cgi?id=46011
3200
3201         broke layout test dashboard (Requested by johnny_g on
3202         #webkit).
3203
3204         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3205         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3206         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3207
3208 2010-09-17  Martin Robinson  <mrobinson@igalia.com>
3209
3210         Reviewed by Oliver Hunt.
3211
3212         Style bot complains about cairo forward declaration naming
3213         https://bugs.webkit.org/show_bug.cgi?id=45867
3214
3215         Exclude Cairo forward declarations from indentifiers with underscores checks.
3216
3217         * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
3218         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3219
3220 2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>
3221
3222         Reviewed by Ojan Vafai.
3223
3224         Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
3225         https://bugs.webkit.org/show_bug.cgi?id=45408
3226
3227         This change also tries to remove duplicated upload_results_json methods
3228         in run_webkit_tests.py and json_results_generator.py.
3229
3230         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3231         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3232         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3233
3234 2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>
3235
3236         Reviewed by Andreas Kling.
3237
3238         [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.
3239
3240         Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
3241         different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
3242         were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
3243         all page specific stuff to the UI.
3244
3245         * QtTestBrowser/launcherwindow.cpp:
3246         (LauncherWindow::initializeView):
3247         * QtTestBrowser/mainwindow.cpp:
3248         (MainWindow::MainWindow):
3249         (MainWindow::buildUI):
3250         (MainWindow::setPage):
3251         * QtTestBrowser/mainwindow.h:
3252
3253 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3254
3255         Reviewed by Andreas Kling.
3256
3257         Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.
3258
3259         This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
3260         object will move to the qgraphicsscene instead of the qgraphicsview.
3261
3262         * QtTestBrowser/webview.cpp:
3263         (WebViewGraphicsBased::setPage):
3264         (WebViewGraphicsBased::setResizesToContents):
3265         (WebViewGraphicsBased::resizeEvent):
3266         (WebViewGraphicsBased::animatedFlip):
3267         * QtTestBrowser/webview.h:
3268         (WebViewGraphicsBased::setItemCacheMode):
3269         (WebViewGraphicsBased::itemCacheMode):
3270
3271 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3272
3273         Reviewed by Andreas Kling.
3274
3275         Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.
3276
3277         We usually separate methods whose body are larger than a few lines from the class definition.
3278
3279         * QtTestBrowser/webview.h:
3280         (WebViewGraphicsBased::yRotation):
3281         (WebViewGraphicsBased::setYRotation):
3282
3283 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3284
3285         Reviewed by Andreas Kling.
3286
3287         Make initializeView method of LauncherWindow private.
3288
3289         No one else needs to be able to call it but LauncherWindow.
3290         Also moving the declation of isGraphicsBased method down in the same file, in order
3291         to better group related methods.
3292
3293         * QtTestBrowser/launcherwindow.h:
3294
3295 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3296
3297         Reviewed by Andreas Kling.
3298
3299         Make the getter 'page' method of MainWindow const.
3300
3301         * QtTestBrowser/mainwindow.cpp:
3302         (MainWindow::page):
3303         * QtTestBrowser/mainwindow.h:
3304
3305 2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>
3306
3307         Reviewed by Andreas Kling.
3308
3309         Remove useless parameter from MainWindow class' constructor.
3310
3311         The parameter defaults to an empty URL and is not being used by any caller. Apart from that it is also
3312         not referred in the constructor body and does not make much sense.
3313
3314         * QtTestBrowser/mainwindow.cpp:
3315         (MainWindow::MainWindow):
3316         * QtTestBrowser/mainwindow.h:
3317
3318 2010-09-15  Tony Chang  <tony@chromium.org>
3319
3320         Reviewed by Kent Tamura.
3321
3322         [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
3323         https://bugs.webkit.org/show_bug.cgi?id=42151
3324
3325         * DumpRenderTree/chromium/LayoutTestController.cpp:
3326         (LayoutTestController::LayoutTestController):
3327         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
3328         (WorkItemLoadHTMLString::run):
3329         (LayoutTestController::queueLoadHTMLString):
3330         (LayoutTestController::reset):
3331         (LayoutTestController::setDeferMainResourceDataLoad):
3332         * DumpRenderTree/chromium/LayoutTestController.h:
3333         (LayoutTestController::deferMainResourceDataLoad):
3334         * DumpRenderTree/chromium/WebViewHost.cpp:
3335         (WebViewHost::didCreateDataSource):
3336
3337 2010-09-16  Adrienne Walker  <enne@google.com>
3338
3339         Reviewed by Kenneth Russell.
3340
3341         Add script to synchronize WebKit and Khronos WebGL tests
3342         https://bugs.webkit.org/show_bug.cgi?id=42336
3343
3344         * Scripts/update-webgl-conformance-tests: Added.
3345         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
3346         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.
3347
3348 2010-09-16  Sam Weinig  <sam@webkit.org>
3349
3350         Reviewed by Anders Carlsson.
3351
3352         Add support for sending synchronous messages from the InjectedBundle to the WKContext
3353         <rdar://problem/8365320>
3354         https://bugs.webkit.org/show_bug.cgi?id=44785
3355
3356         * MiniBrowser/mac/AppDelegate.m:
3357         (didReceiveSynchronousMessageFromInjectedBundle):
3358         (-[BrowserAppDelegate init]):
3359         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3360         (didCreatePage):
3361         * WebKitTestRunner/TestController.cpp:
3362         (WTR::TestController::initialize):
3363
3364 2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>
3365
3366         Reviewed by Andreas Kling.
3367
3368         [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
3369         https://bugs.webkit.org/show_bug.cgi?id=45885
3370
3371         Avoid creation of an additional window for screenshot to prevent overlapping with original window.
3372
3373         * QtTestBrowser/launcherwindow.cpp:
3374         (LauncherWindow::screenshot):
3375
3376 2010-09-16  Anders Carlsson  <andersca@apple.com>
3377
3378         Fix clang++ build.
3379
3380         * MiniBrowser/mac/BrowserWindowController.m:
3381         (-[BrowserWindowController zoomIn:]):
3382         (-[BrowserWindowController zoomOut:]):
3383         (-[BrowserWindowController resetZoom:]):
3384         Remove trailing semicolons.
3385
3386 2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
3387
3388         Unreviewed, rolling out r67628.
3389         http://trac.webkit.org/changeset/67628
3390         https://bugs.webkit.org/show_bug.cgi?id=45904
3391
3392         broke the build (Requested by eric_carlson on #webkit).
3393
3394         * DumpRenderTree/gtk/EventSender.cpp:
3395         (contextClickCallback):
3396
3397 2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>
3398
3399         Unreviewed.
3400
3401         Adding myself as a comitter.
3402
3403         * Scripts/webkitpy/common/config/committers.py:
3404
3405 2010-09-15  Philippe Normand  <pnormand@igalia.com>
3406
3407         Reviewed by Eric Carlson.
3408
3409         [GTK] enhanced context menu for media elements
3410         https://bugs.webkit.org/show_bug.cgi?id=45021
3411
3412         EventSender::contextClick() now returns an array of js
3413         objects. Each object has a title property and a click() method.
3414
3415         * DumpRenderTree/gtk/EventSender.cpp:
3416         (getMenuItemTitleCallback):
3417         (setMenuItemTitleCallback):
3418         (menuItemClickCallback):
3419         (getMenuItemClass):
3420         (contextClickCallback):
3421
3422 2010-09-14  Philippe Normand  <pnormand@igalia.com>
3423
3424         Reviewed by Eric Carlson and Martin Robinson.
3425
3426         [GTK] eventSender.contextClick() should return the contents of the context menu
3427         https://bugs.webkit.org/show_bug.cgi?id=39102
3428
3429         Make the eventSender use the new private WebKitGtk+ API to
3430         retrieve the context-menu item titles and store them in an array.
3431
3432         * DumpRenderTree/gtk/EventSender.cpp:
3433         (contextClickCallback):
3434
3435 2010-09-16  Eric Uhrhane  <ericu@chromium.org>
3436
3437         Reviewed by Jian Li.
3438
3439         Unify FILE_SYSTEM and FILE_WRITER enables under the name FILE_SYSTEM.
3440         https://bugs.webkit.org/show_bug.cgi?id=45798
3441
3442         * Scripts/build-webkit:
3443
3444 2010-09-16  Robert Hogan  <robert@webkit.org>
3445
3446         Reviewed by Antonio Gomes.
3447
3448         [Qt] Support globalhistory tests
3449         https://bugs.webkit.org/show_bug.cgi?id=45774
3450
3451         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3452         (WebCore::isGlobalHistoryTest):
3453         (WebCore::DumpRenderTree::open):
3454         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3455         (LayoutTestController::reset):
3456         (LayoutTestController::dumpHistoryCallbacks):
3457         (LayoutTestController::removeAllVisitedLinks):
3458         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3459
3460 2010-09-10  Tony Chang  <tony@chromium.org>
3461
3462         Reviewed by Eric Seidel.
3463
3464         deduplicate-tests should be runnable from any WebKit directory
3465         https://bugs.webkit.org/show_bug.cgi?id=44709
3466
3467         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
3468         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3469
3470 2010-09-15  Tony Chang  <tony@chromium.org>
3471
3472         Reviewed by Kent Tamura.
3473
3474         [chromium] sort testing methods in DRT
3475         https://bugs.webkit.org/show_bug.cgi?id=45850
3476
3477         * DumpRenderTree/chromium/EventSender.cpp:
3478         (EventSender::EventSender):
3479         * DumpRenderTree/chromium/LayoutTestController.cpp:
3480         (LayoutTestController::LayoutTestController):
3481         * DumpRenderTree/chromium/TextInputController.cpp:
3482         (TextInputController::TextInputController):
3483
3484 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
3485
3486         Reviewed by Adam Barth.
3487
3488         CQ status shows items out of order
3489         https://bugs.webkit.org/show_bug.cgi?id=45846
3490         
3491         Only group consecutive status items with the same patch ID into the same
3492         group, so that overall item ordering is preserved.
3493         
3494         Also don't indent status items that only have a single item in their
3495         group.
3496
3497         * QueueStatusServer/handlers/queuestatus.py:
3498         * QueueStatusServer/templates/includes/singlequeuestatus.html: Added.
3499         * QueueStatusServer/templates/queuestatus.html:
3500
3501 2010-09-15  Eric Seidel  <eric@webkit.org>
3502
3503         Reviewed by Adam Barth.
3504
3505         Add queue start/stop messages
3506         https://bugs.webkit.org/show_bug.cgi?id=45853
3507
3508         I ended up needing to clean up a bunch of our unit testing
3509         in order to test this new code path nicely.
3510
3511         There are also a few PEP8 changes needed to pass check-webkit-style.
3512
3513         * Scripts/webkitpy/tool/bot/queueengine.py:
3514         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3515         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3516         * Scripts/webkitpy/tool/commands/queues.py:
3517         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3518         * Scripts/webkitpy/tool/commands/queuestest.py:
3519         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3520
3521 2010-09-15  Simon Fraser  <simon.fraser@apple.com>
3522
3523         https://bugs.webkit.org/show_bug.cgi?id=45849
3524         WKURLCreateWithCFURL crashes with null url
3525         
3526         Fix MiniBrowser crash when the url is not parseable.
3527
3528         * MiniBrowser/mac/BrowserWindowController.m:
3529         (-[BrowserWindowController fetch:]):
3530
3531 2010-09-15  Patrick Gansterer  <paroga@paroga.com>
3532
3533         Unreviewed.
3534
3535         Adding myself to the committers list.
3536
3537         * Scripts/webkitpy/common/config/committers.py:
3538
3539 2010-09-14  Eric Seidel  <eric@webkit.org>
3540
3541         Reviewed by Adam Barth.
3542
3543         Make it possible to run more than one commit-queue instance
3544         https://bugs.webkit.org/show_bug.cgi?id=45786
3545
3546         Mostly we need to make sure the two (or more) instances get
3547         different patches to work on.  To do this, I re-worked
3548         the code responsible for getting the next work item to
3549         round trip through the status server.  The status server only
3550         vends patches from the work items list, only if those patches
3551         have not had status reported for them in the last hour.
3552
3553         This is another step towards making all queues go through the
3554         status server, thus making it possible to run more than one
3555         instance of various EWS bots (as requested in bug 44292).
3556
3557         The webkitpy changes are already covered by existing unit tests.
3558         The QueueStatusSever sadly has no testing infrastructure yet. :(
3559
3560         * QueueStatusServer/handlers/nextpatch.py: Added.
3561         * QueueStatusServer/index.yaml:
3562         * QueueStatusServer/main.py:
3563         * Scripts/webkitpy/tool/commands/queues.py:
3564
3565 2010-09-15  Mihai Parparita  <mihaip@chromium.org>
3566
3567         Reviewed by Tony Chang.
3568
3569         NRWT fails with UnicodeDecodeError on editing/selection/mixed-editability-10.html
3570         https://bugs.webkit.org/show_bug.cgi?id=45791
3571
3572         Force filenames to be raw bytes before running difflib.unified_diff.
3573
3574         * Scripts/webkitpy/layout_tests/port/base.py:
3575         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3576
3577 2010-09-15  Simon Hausmann  <simon.hausmann@nokia.com>
3578
3579         Reviewed by Tor Arne Vestbø.
3580
3581         [Qt] QtTestBrowser crashes when enabling QGraphicsView mode after first loading page without it enabled
3582         https://bugs.webkit.org/show_bug.cgi?id=35247
3583
3584         The main issue when changing the views is that the plugins and any other components that
3585         depend on view specific attributes such as the native window id are not teared down.
3586         Even if we had a tear-down procedure, we'd have to re-initialize the plugin after
3587         switching to the new view (QGraphicsWebView). This is a rather uncommon situation, so
3588         we decided to work around this in QtTestBrowser by making toggling between QWebView
3589         and QGraphicsWebView also re-create the page.
3590
3591         * QtTestBrowser/launcherwindow.cpp:
3592         (LauncherWindow::initializeView):
3593         * QtTestBrowser/mainwindow.h:
3594
3595 2010-09-14  Mihai Parparita  <mihaip@chromium.org>
3596
3597         Reviewed by Adam Barth.
3598
3599         Send webkit accessibility notifications to Chromium
3600         https://bugs.webkit.org/show_bug.cgi?id=45156
3601
3602         Move printf inside shouldDumpAccessibilityNotifications check.
3603
3604         * DumpRenderTree/chromium/WebViewHost.cpp:
3605         (WebViewHost::postAccessibilityNotification):
3606
3607 2010-09-14  Tony Chang  <tony@chromium.org>
3608
3609         Reviewed by Kent Tamura.
3610
3611         [chromium] fix http/tests/security/local-user-CSS-from-remote.html
3612         https://bugs.webkit.org/show_bug.cgi?id=45788
3613
3614         * DumpRenderTree/chromium/LayoutTestController.cpp:
3615         (LayoutTestController::setUserStyleSheetLocation): use a base64 url like in Chrome
3616
3617 2010-09-14  Tony Chang  <tony@chromium.org>
3618
3619         Reviewed by Ojan Vafai.
3620
3621         [chromium] Remove WebKit::areLayoutTestImagesOpaque since it's no longer needed
3622         https://bugs.webkit.org/show_bug.cgi?id=45768
3623
3624         * DumpRenderTree/chromium/TestShell.cpp:
3625         (TestShell::dumpImage): new baselines are checked in and Linux will match Windows going forward.
3626
3627 2010-09-14  Kevin Ollivier  <kevino@theolliviers.com>
3628
3629         [wx] Build fix, add newly added directories to the directory list.
3630
3631         * wx/build/settings.py:
3632
3633 2010-09-14  Sam Weinig  <sam@webkit.org>
3634
3635         Reviewed by Anders Carlsson.
3636
3637         Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
3638         https://bugs.webkit.org/show_bug.cgi?id=45785
3639
3640         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3641         (WTR::propertyValue):
3642         (WTR::numericWindowPropertyValue):
3643         (WTR::dumpPath):
3644         (WTR::toStr):
3645         (WTR::operator<<):
3646         (WTR::InjectedBundlePage::InjectedBundlePage):
3647         (WTR::InjectedBundlePage::shouldInsertNode):
3648         (WTR::InjectedBundlePage::shouldBeginEditing):
3649         (WTR::InjectedBundlePage::shouldEndEditing):
3650         (WTR::InjectedBundlePage::shouldInsertText):
3651         (WTR::InjectedBundlePage::shouldDeleteRange):
3652         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
3653         (WTR::InjectedBundlePage::shouldApplyStyle):
3654         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3655
3656 2010-09-14  Adam Barth  <abarth@webkit.org>
3657
3658         Fix two typos in commit-queue.  The first is harmless.  The second
3659         causes the queue to reject patches when the build is broken.  :(
3660
3661         * Scripts/webkitpy/tool/commands/queues.py:
3662         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3663
3664 2010-09-14  Chris Guillory   <chris.guillory@google.com>
3665
3666         Reviewed by Chris Fleizach.
3667
3668         Send all accessibility notifications to Chromium.
3669         https://bugs.webkit.org/show_bug.cgi?id=45156
3670
3671         * DumpRenderTree/chromium/WebViewHost.cpp:
3672         (WebViewHost::postAccessibilityNotification):
3673         * DumpRenderTree/chromium/WebViewHost.h:
3674
3675 2010-09-14  Adam Barth  <abarth@webkit.org>
3676
3677         Reviewed by Eric Seidel.
3678
3679         commit-queue is slow during the day
3680         https://bugs.webkit.org/show_bug.cgi?id=45780
3681
3682         Thanks to the new logging, we've noticed that checkout-is-out-of-date
3683         errors in the first pass of landing don't retry the land.  Instead,
3684         they're treated as failures and cause the commit-queue to do two more
3685         builds before really trying to land the patch.  Worse, in the second
3686         build, we can get bitten by a flaky test.
3687
3688         This patch takes a slightly different approach to the commit-queue's
3689         main control logic.  We now use a separate subprocess for building and
3690         testing and for landing.  This means we should very rarely see the
3691         checkout-is-out-of-date error, and when we do see it, we should retry
3692         more quickly.  If my understanding is correct, this should be a big
3693         speed win for the commit-queue.
3694
3695         * Scripts/webkitpy/tool/commands/download.py:
3696         * Scripts/webkitpy/tool/commands/queues.py:
3697         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3698
3699 2010-09-14  Tony Chang  <tony@chromium.org>
3700
3701         Reviewed by Dimitri Glazkov.
3702
3703         [chromium] implement layoutTestController.setDomainRelaxationForbiddenForURLScheme
3704         https://bugs.webkit.org/show_bug.cgi?id=45762
3705
3706         * DumpRenderTree/chromium/LayoutTestController.cpp:
3707         (LayoutTestController::LayoutTestController):
3708         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
3709         * DumpRenderTree/chromium/LayoutTestController.h:
3710
3711 2010-09-14  Csaba Osztrogonác  <ossy@webkit.org>
3712
3713         Adding myself as a reviewer.
3714
3715         * Scripts/webkitpy/common/config/committers.py:
3716
3717 2010-09-14  Zoltan Horvath  <zoltan@webkit.org>
3718
3719         Reviewed by Kenneth Rohde Christiansen.
3720
3721         [Qt] Build-webkit shows a warning when WebKitBuild directory is not exist
3722         https://bugs.webkit.org/show_bug.cgi?id=45736
3723
3724         Build-webkit has showed a warning when WebKitBuild didn't exist, add
3725         an additional condition to avoid it.
3726
3727         * Scripts/build-webkit:
3728
3729 2010-09-13  Eric Seidel  <eric@webkit.org>
3730
3731         Reviewed by Adam Barth.
3732
3733         commit-queue should log when it's retrying due to checkout out of date error
3734         https://bugs.webkit.org/show_bug.cgi?id=45725
3735
3736         This will allow us to better track how often we see these errors
3737         and how long it takes the queue to recover from them.
3738
3739         In order to pass the tests, I had to correct an error
3740         from a previous change.  The UnitTestPort should not have
3741         ever been using the base port method as that will read
3742         a file from disk.  If the unit tests haven't passed the contents
3743         it should raise an IOError as though the file doesn't exist.
3744
3745         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3746         * Scripts/webkitpy/tool/commands/queues.py:
3747         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3748
3749 2010-09-13  Mihai Parparita  <mihaip@chromium.org>
3750
3751         Reviewed by Adam Barth.
3752
3753         Upload results when cq patch landing fails
3754         https://bugs.webkit.org/show_bug.cgi?id=45683
3755         
3756         Include script errors when CommitQueue._land fails.
3757
3758         * Scripts/webkitpy/tool/commands/queues.py:
3759
3760 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
3761
3762         Reviewed by David Kilzer.
3763
3764         AX: accessibilityIsIgnored is returning nil when return value expects a BOOL
3765         https://bugs.webkit.org/show_bug.cgi?id=45548
3766
3767         * DumpRenderTree/AccessibilityUIElement.cpp:
3768         (isIgnoredCallback):
3769         (AccessibilityUIElement::getJSClass):
3770         * DumpRenderTree/AccessibilityUIElement.h:
3771         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3772         (AccessibilityUIElement::isIgnored):
3773         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3774         (AccessibilityUIElement::isIgnored):
3775         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3776         (AccessibilityUIElement::isIgnored):
3777
3778 2010-09-13  Csaba Osztrogonác  <ossy@webkit.org>
3779
3780         Reviewed by Andreas Kling.
3781
3782         jscPath() is incorrect in Windows' cmd.exe shell
3783         https://bugs.webkit.org/show_bug.cgi?id=45651
3784
3785         * Scripts/webkitdirs.pm: Add ".exe" suffix to $jscName on Windows.
3786
3787 2010-09-13  Chris Fleizach  <cfleizach@apple.com>
3788
3789         Reviewed by Darin Adler.
3790
3791         REGRESSION (r64816-r64889): Crash in WebCore::AccessibilityRenderObject
3792         https://bugs.webkit.org/show_bug.cgi?id=43807
3793
3794         * DumpRenderTree/AccessibilityUIElement.cpp:
3795         (textMarkerForPointCallback):
3796         (AccessibilityUIElement::textMarkerForPoint):
3797         (AccessibilityUIElement::getJSClass):
3798         * DumpRenderTree/AccessibilityUIElement.h:
3799         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3800         (AccessibilityUIElement::textMarkerForPoint):
3801
3802 2010-09-13  Andreas Kling  <andreas.kling@nokia.com>
3803
3804         Reviewed by Kenneth Rohde Christiansen.
3805
3806         [Qt] build-webkit: Add --v8 option to build against V8
3807
3808         Note that V8 is picked up from QtScript, so this currently requires building
3809         against the experimental qt-script-v8 branch.
3810
3811         * Scripts/build-webkit:
3812
3813 2010-09-13  Hans Wennborg  <hans@chromium.org>
3814
3815         Reviewed by Jeremy Orlow.
3816
3817         Add WebDeviceOrientationClientMock::create() and use it from DRT.
3818         https://bugs.webkit.org/show_bug.cgi?id=45650
3819
3820         Do not use the WebDeviceOrientationClientMock constructor directly,
3821         but use the create() member function.
3822
3823         This should fix the linker errors for the multi-DLL Chromium DRT build.
3824
3825         * DumpRenderTree/chromium/LayoutTestController.cpp:
3826         (LayoutTestController::setMockDeviceOrientation):
3827         (LayoutTestController::deviceOrientationClient):
3828
3829 2010-08-27  Kenneth Rohde Christiansen  <kenneth.christiansen@openbossa.org>
3830
3831         Reviewed by Antti Koivisto.
3832
3833         Add support for testing the viewport meta tag algorithm,
3834         based on the following draft spec:
3835
3836         http://people.opera.com/rune/TR/ED-css-viewport-20100806/
3837
3838         Add common handling of viewport meta tag based on new Opera spec
3839         https://bugs.webkit.org/show_bug.cgi?id=44201
3840
3841         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3842         (LayoutTestController::dumpConfigurationForViewport):
3843         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3844
3845 2010-09-12  Kent Tamura  <tkent@chromium.org>
3846
3847         Reviewed by Tony Chang.
3848
3849         [DRT/Chromium] Remove dependency to base/string16.h and gfx/codec/png_codec.h
3850         https://bugs.webkit.org/show_bug.cgi?id=45517
3851
3852         Use webkit_support_gfx.h for PNG encoding/decoding instead of png_codec.h
3853
3854         * DumpRenderTree/chromium/ImageDiff.cpp:
3855         (Image::craeteFromStdin):
3856         (Image::createFromFilename):
3857         (diffImages):
3858         * DumpRenderTree/chromium/TestShell.cpp:
3859         (TestShell::dumpImage):
3860
3861 2010-09-10  MORITA Hajime  <morrita@google.com>
3862
3863         Reviewed by Tony Chang.
3864
3865         [Chromium] Implement textInputController.hasSpellingMarker() for Chromium
3866         https://bugs.webkit.org/show_bug.cgi?id=45441
3867
3868         Added TextInputController::hasSpellingMarker().
3869         
3870         * DumpRenderTree/chromium/TextInputController.cpp:
3871         (TextInputController::TextInputController):
3872         (TextInputController::hasSpellingMarker):
3873         * DumpRenderTree/chromium/TextInputController.h:
3874
3875 2010-09-12  Dirk Pranke  <dpranke@chromium.org>
3876
3877         Unreviewed, build fix.
3878
3879         My last change accidentally contained a local change to the
3880         rebaselinig script; webkit-patch land picked it up without telling
3881         me and committed it :(
3882
3883         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3884
3885 2010-09-11  Maciej Stachowiak  <mjs@apple.com>
3886
3887         Reviewed by Anders Carlsson.
3888
3889         Attempt to fix Windows MiniBrowser build (untested)
3890         https://bugs.webkit.org/show_bug.cgi?id=45609
3891
3892         * MiniBrowser/win/BrowserView.cpp:
3893         (runJavaScriptConfirm):
3894         (runJavaScriptPrompt):
3895
3896 2010-09-11  Sam Weinig  <sam@webkit.org>
3897
3898         Reviewed by Maciej Stachowiak.
3899
3900         Fix zoom related tests when testing WebKit2.
3901
3902         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3903         (WTR::EventSendingController::zoomPageIn): Zoom in and zoom out are not the same.
3904
3905 2010-09-11  Sam Weinig  <sam@webkit.org>
3906
3907         Reviewed by Dan Bernstein.
3908
3909         Implement WebKit2 callback equivalent to - [WebUIDelegate webView:setStatusText:]
3910         <rdar://problem/8359252>
3911         https://bugs.webkit.org/show_bug.cgi?id=45605
3912
3913         * MiniBrowser/mac/BrowserWindowController.m:
3914         (setStatusText):
3915         (contentsSizeChanged):
3916         (-[BrowserWindowController awakeFromNib]):
3917         * MiniBrowser/win/BrowserView.cpp:
3918         (runJavaScriptConfirm):
3919         (runJavaScriptPrompt):
3920         (setStatusText):
3921         (contentsSizeChanged):
3922         (BrowserView::create):
3923         * WebKitTestRunner/TestController.cpp:
3924         (WTR::createOtherPage):
3925         (WTR::TestController::initialize):
3926
3927 2010-09-11  Sam Weinig  <sam@webkit.org>
3928
3929         Reviewed by Dan Bernstein.
3930
3931         Add callback mechanism for the getting the source of a frame
3932         <rdar://problem/8364681>
3933         https://bugs.webkit.org/show_bug.cgi?id=45604
3934
3935         Add ability to dump the main frame's source to the console.
3936
3937         * MiniBrowser/mac/BrowserWindowController.h:
3938         * MiniBrowser/mac/BrowserWindowController.m:
3939         (-[BrowserWindowController dumpSourceToConsole:]):
3940         * MiniBrowser/mac/MainMenu.xib:
3941
3942 2010-09-11  Eric Seidel  <eric@webkit.org>
3943
3944         Reviewed by Adam Barth.
3945
3946         Remove unneeded Empty Queue messages
3947         https://bugs.webkit.org/show_bug.cgi?id=45602
3948
3949         We already have a /gc job to delete these.
3950         recentstatus.py is already smart enough to use the
3951         most recent of the workitems last update or the most recent status,
3952         so removing these should not change the _last_status_date() return
3953         value more than a few milliseconds.
3954
3955         These messages just spam the recent status log.
3956
3957         * Scripts/webkitpy/tool/commands/queues.py:
3958
3959 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
3960
3961         Reviewed by Adam Barth.
3962
3963         Fix Python exception when generating synthetic patch IDs
3964         https://bugs.webkit.org/show_bug.cgi?id=45592
3965
3966         Can't concatenate strings and numbers directly.
3967
3968         * QueueStatusServer/handlers/queuestatus.py:
3969
3970 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
3971
3972         Reviewed by Adam Barth.
3973
3974         Group statuses in queue status by patch ID
3975         https://bugs.webkit.org/show_bug.cgi?id=45588
3976
3977         Group statuses by patch ID so that the status page is easier
3978         to scan.
3979
3980         * QueueStatusServer/handlers/queuestatus.py:
3981         * QueueStatusServer/stylesheets/dashboard.css:
3982         (.status-group):
3983         (.status-bug):
3984         (.status-group ul):
3985         (.status-group ul li):
3986         (.status-group ul li:hover):
3987         (.status-cell):
3988         (.status-cell:hover):
3989         (.status-cell.pass):
3990         (.status-cell.fail):
3991         (.status-cell.pending):
3992         (.status-cell.error):
3993         * QueueStatusServer/templates/dashboard.html:
3994         * QueueStatusServer/templates/queuestatus.html:
3995
3996 2010-09-11  Mihai Parparita  <mihaip@chromium.org>
3997
3998         Reviewed by Tony Chang.
3999
4000         Implement layoutTestController.dumpResourceResponseMIMETypes in Chromium DRT
4001         https://bugs.webkit.org/show_bug.cgi?id=45479
4002
4003         Implement layoutTestController.dumpResourceResponseMIMETypes (modelled after
4004         implementation in ResourceLoadDelegate in the Mac port).
4005
4006         * DumpRenderTree/chromium/LayoutTestController.cpp:
4007         (LayoutTestController::LayoutTestController):
4008         (LayoutTestController::dumpResourceResponseMIMETypes):
4009         (LayoutTestController::reset):
4010         * DumpRenderTree/chromium/LayoutTestController.h:
4011         (LayoutTestController::setShouldDumpResourceResponseMIMETypes):
4012         (LayoutTestController::shouldDumpResourceResponseMIMETypes):
4013         * DumpRenderTree/chromium/TestShell.h:
4014         (TestShell::shouldDumpResourceResponseMIMETypes):
4015         * DumpRenderTree/chromium/WebViewHost.cpp:
4016         (WebViewHost::didReceiveResponse):
4017
4018 2010-09-11  Eric Seidel  <eric@webkit.org>
4019
4020         Reviewed by Adam Barth.
4021
4022         queues.webkit.org should expose /remote_api for data upload/download
4023         https://bugs.webkit.org/show_bug.cgi?id=45559
4024
4025         * QueueStatusServer/app.yaml:
4026          - /remote_api is a standard app-engine service which allows use of
4027            the bulk uploader for data upload/download.  Exposing this
4028            (for admin access only) allows us to use 
4029
4030 2010-09-10  Sam Weinig  <sam@webkit.org>
4031
4032         Reviewed by Dan Bernstein.
4033
4034         Add zoom support to WebKit2 API
4035         <rdar://problem/7660657>
4036         https://bugs.webkit.org/show_bug.cgi?id=45585
4037
4038         - Add zoom options to MiniBrowser that mimic Safari's options using
4039           the new WebKit2 zoom APIs.
4040         - Switch uses of float for the zoom APIs to use double.
4041
4042         * MiniBrowser/mac/BrowserWindowController.h:
4043         * MiniBrowser/mac/BrowserWindowController.m:
4044         (-[BrowserWindowController initWithPageNamespace:]):
4045         (-[BrowserWindowController validateMenuItem:]):
4046         (-[BrowserWindowController validateUserInterfaceItem:]):
4047         (-[BrowserWindowController currentZoomFactor]):
4048         (-[BrowserWindowController setCurrentZoomFactor:]):
4049         (-[BrowserWindowController canZoomIn]):
4050         (-[BrowserWindowController zoomIn:]):
4051         (-[BrowserWindowController canZoomOut]):
4052         (-[BrowserWindowController zoomOut:]):
4053         (-[BrowserWindowController canResetZoom]):
4054         (-[BrowserWindowController resetZoom:]):
4055         (-[BrowserWindowController toggleZoomMode:]):
4056         * MiniBrowser/mac/MainMenu.xib:
4057         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4058         (WTR::EventSendingController::textZoomIn):
4059         (WTR::EventSendingController::textZoomOut):
4060         (WTR::EventSendingController::zoomPageIn):
4061         (WTR::EventSendingController::zoomPageOut):
4062
4063 2010-09-10  Robert Hogan  <robert@webkit.org>
4064
4065         Reviewed by Andreas Kling.
4066
4067         [Qt] Fix crash in DRT in standalone mode
4068
4069         https://bugs.webkit.org/show_bug.cgi?id=45454
4070
4071         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4072         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
4073
4074 2010-09-10  Sam Weinig  <sam@webkit.org>
4075
4076         Reviewed by Darin Adler.
4077
4078         Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
4079         Precursor to <rdar://problem/7660657>
4080         https://bugs.webkit.org/show_bug.cgi?id=45522
4081
4082         Update for changes to the Bundle API to allow separate control of page and text zoom
4083         levels.
4084
4085         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4086         (WTR::EventSendingController::textZoomIn):
4087         (WTR::EventSendingController::textZoomOut):
4088         (WTR::EventSendingController::zoomPageIn):
4089         (WTR::EventSendingController::zoomPageOut):
4090         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4091         (WTR::InjectedBundlePage::reset):
4092
4093 2010-09-10  Yael Aharon  <yael.aharon@nokia.com>
4094
4095         Reviewed by Andreas Kling.
4096
4097         [Qt] Support click event for notifications
4098         https://bugs.webkit.org/show_bug.cgi?id=44836
4099
4100         Add support for simulateDesktopNotificationClick by calling
4101         back to DumpRenderTreeSupportQt.cpp.
4102
4103         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4104         (LayoutTestController::simulateDesktopNotificationClick):
4105         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4106
4107 2010-09-10  Mihai Parparita  <mihaip@chromium.org>
4108
4109         Reviewed by Eric Seidel.
4110
4111         Update queue status when patches fail their first land attempt
4112         https://bugs.webkit.org/show_bug.cgi?id=45583
4113
4114         Add a few more _update_status calls to make it more obvious if a patch is 
4115         being retried because tests failed.
4116
4117         * Scripts/webkitpy/tool/commands/queues.py:
4118
4119 2010-09-10  Balazs Kelemen  <kb@inf.u-szeged.hu>
4120
4121         Reviewed by Andreas Kling.
4122
4123         [Qt] MiniBrowser crashes with multiply windows when closing one of them
4124         https://bugs.webkit.org/show_bug.cgi?id=45536
4125
4126         * MiniBrowser/qt/BrowserView.cpp:
4127         (BrowserView::BrowserView): Reference the context instead of adopting it
4128         because it can be shared across different views.
4129
4130 2010-09-10  Tony Chang  <tony@chromium.org>
4131
4132         Unreviewed, rolling out r67241.
4133         http://trac.webkit.org/changeset/67241
4134         https://bugs.webkit.org/show_bug.cgi?id=44709
4135
4136         Accidentally committed.
4137
4138         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
4139         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
4140
4141 2010-09-10  Tony Chang  <tony@chromium.org>
4142
4143         Reviewed by Ojan Vafai.
4144
4145         deduplicate-tests should be runnable from any WebKit directory
4146         https://bugs.webkit.org/show_bug.cgi?id=44709
4147
4148         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
4149         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
4150
4151 2010-09-10  Tony Chang  <tony@chromium.org>
4152
4153         Unreviewed, rolling out r67216.
4154         http://trac.webkit.org/changeset/67216
4155         https://bugs.webkit.org/show_bug.cgi?id=44709
4156
4157         Broke
4158
4159         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
4160         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
4161
4162 2010-09-10  Tony Chang  <tony@chromium.org>
4163
4164         Reviewed by Ojan Vafai.
4165
4166         deduplicate-tests should be runnable from any WebKit directory
4167         https://bugs.webkit.org/show_bug.cgi?id=44709
4168
4169         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
4170         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
4171
4172 2010-09-09  Hans Wennborg  <hans@chromium.org>
4173
4174         Reviewed by Jeremy Orlow.
4175
4176         Hook up LayoutTestController.setMockDeviceOrientation() in Chromium DumpRenderTree.
4177         https://bugs.webkit.org/show_bug.cgi?id=45460
4178
4179         This enables DumpRenderTree to run layout tests for DeviceOrientation.
4180
4181         Also declare the LayoutTestController destructor out-of-line.
4182         Otherwise the implicit destructor would cause compiler errors because
4183         of the OwnPtr<WebKit::WebDeviceOrientationClientMock> member.
4184
4185         * DumpRenderTree/chromium/LayoutTestController.cpp:
4186         (LayoutTestController::~LayoutTestController):
4187         (LayoutTestController::setMockDeviceOrientation):
4188         (LayoutTestController::deviceOrientationClient):
4189         * DumpRenderTree/chromium/LayoutTestController.h:
4190         * DumpRenderTree/chromium/WebViewHost.cpp:
4191         (WebViewHost::deviceOrientationClient):
4192         * DumpRenderTree/chromium/WebViewHost.h:
4193
4194 2010-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
4195
4196         Unreviewed, rolling out r67119.
4197         http://trac.webkit.org/changeset/67119
4198         https://bugs.webkit.org/show_bug.cgi?id=45505
4199
4200         Extra newlines in results (Requested by tony^work on #webkit).
4201
4202         * DumpRenderTree/chromium/LayoutTestController.cpp:
4203         (LayoutTestController::LayoutTestController):
4204         (LayoutTestController::reset):
4205         * DumpRenderTree/chromium/LayoutTestController.h:
4206         * DumpRenderTree/chromium/TestShell.h:
4207         * DumpRenderTree/chromium/WebViewHost.cpp:
4208         (printResponseDescription):
4209         (printNodeDescription):
4210         (printRangeDescription):
4211         (WebViewHost::shouldBeginEditing):
4212         (WebViewHost::shouldEndEditing):
4213         (WebViewHost::shouldInsertNode):
4214         (WebViewHost::shouldChangeSelectedRange):
4215         (WebViewHost::shouldDeleteRange):
4216         (WebViewHost::shouldApplyStyle):
4217         (WebViewHost::didBeginEditing):
4218         (WebViewHost::didChangeSelection):
4219         (WebViewHost::didChangeContents):
4220         (WebViewHost::didEndEditing):
4221         (WebViewHost::decidePolicyForNavigation):
4222         (WebViewHost::didCancelClientRedirect):
4223         (WebViewHost::didStartProvisionalLoad):
4224         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
4225         (WebViewHost::didFailProvisionalLoad):
4226         (WebViewHost::didCommitProvisionalLoad):
4227         (WebViewHost::didFinishDocumentLoad):
4228         (WebViewHost::didHandleOnloadEvents):
4229         (WebViewHost::didFailLoad):
4230         (WebViewHost::didFinishLoad):
4231         (WebViewHost::didChangeLocationWithinPage):
4232         (WebViewHost::willSendRequest):
4233         (WebViewHost::didReceiveResponse):
4234         (WebViewHost::didFinishResourceLoad):
4235         (WebViewHost::didFailResourceLoad):
4236         (WebViewHost::didDisplayInsecureContent):
4237         (WebViewHost::didRunInsecureContent):
4238         (WebViewHost::printFrameDescription):
4239
4240 2010-09-09  Michael Saboff  <msaboff@apple.com>
4241
4242         Unreviewed, adding myself to committers list.
4243
4244         * Scripts/webkitpy/common/config/committers.py:
4245
4246 2010-09-09  Mihai Parparita  <mihaip@chromium.org>
4247
4248