3fcde2d1944c307bb3301e8315a885c259b25606
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Darin.
4         
5         - add some more renames, adjust some
6
7         * Scripts/do-webcore-rename:
8
9 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
10
11         Reviewed by Oliver.
12
13         Enable SVG Fonts support by default.
14
15         * Scripts/build-webkit:
16
17 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
18
19         Reviewed by Adam.
20
21         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
22         DRT doesn't handle platform specific pixel test results correctly.
23
24         <test>-expected.txt files and <test>-expected.png files may now live
25         in different directories (ie. a cross-platform <test>-expected.txt file
26         and a platform-specific <test>-expected.png file).
27
28         * Scripts/run-webkit-tests:
29
30 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
31
32         Reviewed by Darin.
33
34         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
35         DRT did not correctly handle printing the '\0' char.  Now it does.
36
37         * DumpRenderTree/win/DumpRenderTree.cpp:
38         (dumpFramesAsText):
39         (dump):
40
41 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
42
43         Reviewed by Lars.
44
45         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
46         
47
48         * DumpRenderTree/qt/main.cpp:
49         * DumpRenderTree/qt/testplugin.cpp:
50         * DumpRenderTree/qt/testplugin.h:
51
52 2008-01-05  Mark Rowe  <mrowe@apple.com>
53
54         Reviewed by Alp Toker.
55
56         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
57
58         * DumpRenderTree/gtk/DumpRenderTree.cpp:
59         (processWork): Process pending work.
60         (webViewLoadFinished): Schedule processing of pending work.
61         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
62
63 2008-01-05  Darin Adler  <darin@apple.com>
64
65         * Scripts/do-webcore-rename: Some more renaming plans.
66
67 2008-01-04  Alice Liu  <alice.liu@apple.com>
68
69         Reviewed by Alexey and Darin.
70
71         Adding "home" and "end" to DRT's keydown since
72         DOM key events can't handle keyIdentifiers at this point. 
73
74         * DumpRenderTree/mac/EventSendingController.mm:
75         (-[EventSendingController keyDown:withModifiers:]):
76         * DumpRenderTree/win/EventSender.cpp:
77         (keyDownCallback):
78
79 2008-01-04  Lars Knoll  <lars@trolltech.com>
80
81         Reviewed by Simon.
82
83         fix DRT after the changes to QWebPage.
84         
85         The great thing is that we actually don't have
86         any regressions from the QWebPage change :)
87         
88
89         * DumpRenderTree/qt/DumpRenderTree.cpp:
90         (WebCore::DumpRenderTree::DumpRenderTree):
91
92 2008-01-04  Lars Knoll  <lars@trolltech.com>
93
94         Reviewed by Simon.
95
96         make QWebPage a QObject and get things to compile.
97         
98         Nothing works currently though.
99         
100
101         * DumpRenderTree/qt/DumpRenderTree.cpp:
102         (WebCore::DumpRenderTree::DumpRenderTree):
103
104 2008-01-04  Lars Knoll  <lars@trolltech.com>
105
106         Reviewed by Simon.
107
108         take a QString as identifier in QWebFrame::addToJSWindowObject.
109
110         * DumpRenderTree/qt/DumpRenderTree.cpp:
111         (WebCore::DumpRenderTree::initJSObjects):
112
113 2008-01-04  Alp Toker  <alp@atoker.com>
114
115         GTK+ DRT build fix for breakage introduced in r29149.
116
117         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
118         (LayoutTestController::execCommand):
119
120 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
121
122         Reviewed by Darin.
123
124         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
125
126         Added layoutTestController.execCommand to access editor commands that are not available
127         via document.execCommand.
128
129         * DumpRenderTree/LayoutTestController.cpp:
130         (execCommandCallback):
131         (LayoutTestController::staticFunctions):
132         * DumpRenderTree/LayoutTestController.h:
133         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
134         (LayoutTestController::execCommand):
135         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
136         (LayoutTestController::queueLoad):
137         (LayoutTestController::execCommand):
138
139 2008-01-03  Alice Liu  <alice.liu@apple.com>
140
141         Reviewed by Darin, Mitz.
142
143         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
144
145         the clickcount should not increase if the last click was at a different location.  it's a new click.
146
147         * DumpRenderTree/mac/DumpRenderTree.mm:
148         (runTest):
149         * DumpRenderTree/mac/EventSendingController.h:
150         * DumpRenderTree/mac/EventSendingController.mm:
151         (-[EventSendingController mouseDown]):
152         (-[EventSendingController mouseUp]):
153
154 2008-01-03  Darin Adler  <darin@apple.com>
155
156         Reviewed by Adam.
157
158         * Scripts/update-webkit: Make this work a little better for the people at Apple
159         who have a directory named Internal.
160
161 2008-01-03  Adam Roben  <aroben@apple.com>
162
163         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
164
165         Rubberstamped by Mark.
166
167         * Scripts/update-webkit-auxiliary-libs:
168
169 2008-01-03  Adam Roben  <aroben@apple.com>
170
171         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
172
173         http://bugs.webkit.org/show_bug.cgi?id=15663
174
175         Added a fuzz factor into the Last-Modified comparison for downloading
176         WebKitAuxiliaryLibrary.zip.
177
178         The zip file is served from a set of mirrors who give Last-Modified
179         times that are off by 1-3 seconds from each other. This was causing
180         the build bots to redownload WebKitAuxiliaryLibrary for every build,
181         which would then cause all of WebCore to rebuild each time.
182
183         Reviewed by Mark.
184
185         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
186         at least 30 seconds newer than the old one -- otherwise we assume that
187         the difference in time is due to the mirrors being slightly offset
188         from each other.
189         (sub lastModifiedToUnixTime): Added.
190
191 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
192
193         Windows build fix.
194
195         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
196
197 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
198
199         Reviewed by Lars.
200
201         Moved QWebPage::open to QWebFrame::load and added setHtml.
202         
203
204         * DumpRenderTree/qt/DumpRenderTree.cpp:
205         (WebCore::DumpRenderTree::open):
206
207 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
208
209         Reviewed by Lars.
210
211         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
212         
213
214         * DumpRenderTree/qt/DumpRenderTree.cpp:
215         (WebCore::DumpRenderTree::DumpRenderTree):
216
217 2008-01-02  Sam Weinig  <sam@webkit.org>
218
219         * Scripts/do-webcore-rename: Yet more renaming ideas.
220
221 2008-01-02  Darin Adler  <darin@apple.com>
222
223         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
224
225 2008-01-02  Alice Liu  <alice.liu@apple.com>
226
227         Reviewed by Sam Weinig.
228
229         fixing assertion hit with editing/selection/move-begin-end.html
230
231         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
232         * DumpRenderTree/win/DumpRenderTree.vcproj:
233         * DumpRenderTree/win/EventSender.cpp:
234         (keyDownCallback):
235         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
236
237 2008-01-02  Darin Adler  <darin@apple.com>
238
239         * Scripts/do-webcore-rename: Some more name change plans.
240
241 2008-01-02  Alice Liu  <alice.liu@apple.com>
242
243         Reviewed by Maciej.
244
245         Added handling for page up and page down in EventSender
246
247         * DumpRenderTree/mac/EventSendingController.mm:
248         (-[EventSendingController keyDown:withModifiers:]):
249         * DumpRenderTree/win/EventSender.cpp:
250         (keyDownCallback):
251
252 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
253
254         Reviewed by Darin.
255
256         Fix fast/events/arrow-keys-on-body.html for real.
257
258         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
259
260 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
261
262         Reviewed by Darin.
263
264         http://bugs.webkit.org/show_bug.cgi?id=16674
265         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
266
267         * Scripts/run-launcher:
268
269 2007-12-31  Darin Adler  <darin@apple.com>
270
271         Suggested by Antti.
272
273         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
274         we get it installed on the build bots.
275
276 2007-12-30  Eric Seidel  <eric@webkit.org>
277
278         Reviewed by Sam.
279
280         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
281
282 2007-12-29  Darin Adler  <darin@apple.com>
283
284         Reviewed by Oliver.
285
286         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
287           leak bot shows createCStringFromNPVariant result leaking
288
289         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
290         (pluginInvoke): Added a missing free.
291
292 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
293
294         Reviewed by Alp Toker.
295
296         http://bugs.webkit.org/show_bug.cgi?id=16390
297         Use autotools or GNU make as the build system for the GTK port
298
299         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
300         * GNUmakefile.am: Added.
301
302 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
303
304         Reviewed by Oliver.
305
306         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
307
308         * DumpRenderTree/win/EventSender.cpp:
309         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
310         of 1, even though WebKit currently ignores it.
311
312 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
313
314         wx buildbot fix. Update libpng dl script to the latest version.
315
316         * wx/install-unix-extras:
317
318 2007-12-22  Antti Koivisto  <antti@apple.com>
319
320         Fix a typo.
321
322         * Scripts/webkitdirs.pm:
323
324 2007-12-21  Sam Weinig  <sam@webkit.org>
325
326         Reviewed by Mark Rowe.
327
328         - Disable the back/forward cache using the new WebPreferences API
329           instead of through the BackForwardList.  This makes us match what
330           we do on Windows.
331
332         * DumpRenderTree/mac/DumpRenderTree.mm:
333         (createWebViewAndOffscreenWindow):
334         (setDefaultsToConsistentValuesForTesting):
335
336 2007-12-21  Dan Bernstein  <mitz@apple.com>
337
338         Reviewed by Mark Rowe.
339
340         - disable the back/forward cache in Windows DumpRenderTree. It is
341           already disabled in Mac DumpRenderTree.
342
343         * DumpRenderTree/win/DumpRenderTree.cpp:
344         (initializePreferences):
345
346 2007-12-13  Antti Koivisto  <antti@apple.com>
347
348         Reviewed by Darin and Steve.
349         
350         - check for QuickTime SDK on Windows.
351         - build media support on Windows by default
352
353         * Scripts/build-webkit:
354         * Scripts/webkitdirs.pm:
355
356 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
357
358         Build script fix for buildbot.
359
360         * wx/build-wxwebkit:
361
362 2007-12-20  Eric Seidel  <eric@webkit.org>
363
364         Reviewed by mjs.
365
366         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
367
368 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
369
370         Reviewed by Steve.
371
372         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
373         WebKit.
374
375         - Drosera and Safari need to use the same ProgIDs in order for
376         CoCreateInstance to work properly.  The most robust way to do this is
377         for WebKit to dynamically publish those ProgIDs.
378
379         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
380         (DebuggerClient::createWebViewWithRequest):
381         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
382         statics.
383         (Drosera::initUI):
384         (Drosera::attach):
385         (Drosera::attemptToCreateServerConnection):
386         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
387         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
388         make use of the published ProgIDs.
389         (ServerConnection::attemptToCreateServerConnection):
390
391 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
392
393         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
394         - Build bot and leak fix.
395
396         * DumpRenderTree/LayoutTestController.cpp:
397         (pathToLocalResourceCallback):
398
399 2007-12-19  David Kilzer  <ddkilzer@apple.com>
400
401         Make svn-apply/svn-unapply work with patches from git-format-patch.
402
403         Reviewed by Darin.
404
405         * Scripts/svn-apply:
406         (patch): If 'Index:' can't be found in the text passed in, print it
407         out with a warning and return early.
408         * Scripts/svn-unapply:
409         (patch): Ditto.
410
411 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
412
413         Reviewed by Alp Toker.
414
415         Build related fixes.
416
417         * wx/build-wxwebkit:
418         - Check to make sure the user is running a supported wx port
419         - More robust checks for Cygwin
420         - Only run install-unix-extras on Mac, it's not the right solution
421           for Linux distros.
422         - Remove outdated Linux instructions after successful build
423         - Clean Bakefile-generated files during a clean operation
424
425 2007-12-18  Darin Adler  <darin@apple.com>
426
427         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
428
429 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
430
431         Add script to run Drosera as part of the nightly.
432         
433         Reviewed by Kevin M.
434
435         * Scripts/run-drosera.cmd: Added.
436
437 2007-12-18  Darin Adler  <darin@apple.com>
438
439         * Scripts/do-webcore-rename: Remove a stray K.
440
441 2007-12-18  Darin Adler  <darin@apple.com>
442
443         * Scripts/do-webcore-rename: Plan more renaming.
444
445 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
446
447         Reviewed by Alp Toker.
448
449         http://bugs.webkit.org/show_bug.cgi?id=16042
450         [GTK] Eliminate webkit_init()
451
452         Moving webkit initialization to WebView class init.
453
454         * DumpRenderTree/gtk/DumpRenderTree.cpp:
455         (main):
456         * GtkLauncher/main.c:
457         (main):
458
459 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
460
461         Reviewed by Alp Toker.
462
463         http://bugs.webkit.org/show_bug.cgi?id=13542
464         gdklauncher doesnt change URL in adress GTKEntry.
465
466         * GtkLauncher/main.c:
467         (load_commit_cb): added
468         (title_change_cb):
469         (create_browser):
470
471 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
472
473         Reviewed by Adam Roben.
474
475         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
476
477         * FindSafari/FindSafari.cpp:
478         (_tmain):
479
480 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
481
482         Reviewed by Adam Roben.
483
484         http://bugs.webkit.org/show_bug.cgi?id=16315
485         FindSafari needs a path-only option.
486
487         * FindSafari/FindSafari.cpp:
488         (_tmain):
489
490 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
491
492         Reviewed by Darin.
493
494         http://bugs.webkit.org/show_bug.cgi?id=16462
495         REGRESSION: access keys broken on Windows
496
497         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
498         if Alt is pressed.
499
500 2007-12-15  Sam Weinig  <sam@webkit.org>
501
502         Reviewed by Mark Rowe.
503
504         Fix urlSuitableForTestResult to correctly identify wstring::npos as
505         the case when wstring.find doesn't find anything.
506
507         * DumpRenderTree/win/DumpRenderTree.cpp:
508         (urlSuitableForTestResult):
509
510 2007-12-15  Alp Toker  <alp@atoker.com>
511
512         GTK+ DRT build fix for GLib < 2.14.
513
514         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
515         (LayoutTestController::setWaitToDump):
516
517 2007-12-05  Mark Rowe  <mrowe@apple.com>
518
519         Reviewed by Alp Toker.
520
521         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
522         many layout tests from hanging while waiting on user responses to dialogs.
523
524         * DumpRenderTree/gtk/DumpRenderTree.cpp:
525         (invalidateAnyPreviousWaitToDumpWatchdog):
526         (webViewScriptAlert):
527         (webViewScriptPrompt):
528         (webViewScriptConfirm):
529         (main):
530         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
531         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
532         (waitToDumpWatchdogFired):
533         (LayoutTestController::setWaitToDump):
534
535 2007-12-05  Mark Rowe  <mrowe@apple.com>
536
537         Reviewed by Alp Toker.
538
539         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
540
541         * DumpRenderTree/gtk/DumpRenderTree.cpp:
542         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
543         (dump):
544         (runTest):
545         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
546         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
547         work queue is empty.
548         (webViewWindowObjectCleared): Set up window.layoutTestController.
549         (webViewConsoleMessage): Match the console message format expected by the layout test results.
550         (main): Hook up the new signals.
551         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
552         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
553         dumping multiple times.
554         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
555         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
556
557 2007-12-14  Anders Carlsson  <andersca@apple.com>
558
559         Reviewed by Brady.
560
561         Assert that a web frame that's loading a resource always has either a data source or 
562         a provisional data source.
563         
564         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
565         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
566
567 2007-12-14  Darin Adler  <darin@apple.com>
568
569         - fix mistake causing nearly all tests to fail on Windows
570
571         * DumpRenderTree/win/UIDelegate.cpp:
572         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
573         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
574
575         * DumpRenderTree/mac/UIDelegate.mm:
576         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
577         than passing the entire message.
578
579 2007-12-14  Darin Adler  <darin@apple.com>
580
581         - fix Tiger build
582
583         * DumpRenderTree/mac/UIDelegate.mm:
584         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
585         new-to-Leopard methods.
586
587 2007-12-14  Darin Adler  <darin@apple.com>
588
589         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
590         since it now triggers unwanted icon loading. We only had it because we implemented "all"
591         delegate methods here.
592
593 2007-12-14  Anders Carlsson  <andersca@apple.com>
594
595         Reviewed by Darin and Geoff.
596
597         <rdar://problem/5619295> 
598         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
599         
600         Add property getting methods to the plug-in.
601         
602         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
603         (pluginInvoke):
604
605 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
606
607         Reviewed by Darin.
608
609         - Layout test fix for mac. When dumped to the console local file paths
610         now only show the name of the resource not the whole path.  This is to
611         make the results machine and OS independent.
612
613         * DumpRenderTree/mac/UIDelegate.mm:
614         (-[UIDelegate webView:addMessageToConsole:]):
615
616 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
617
618         Reviewed by Adam.
619
620         - Layout tests fix.  We need a way to remove machine-dependent
621         information from paths in layout test results. The UIDelegate now does
622         this.
623
624         * DumpRenderTree/DumpRenderTree.h:
625         * DumpRenderTree/win/DumpRenderTree.cpp:
626         (urlSuitableForTestResult):
627         * DumpRenderTree/win/DumpRenderTreeWin.h:
628         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
629         * DumpRenderTree/win/UIDelegate.cpp:
630         (UIDelegate::webViewAddMessageToConsole):
631
632 2007-12-13  Alp Toker  <alp@atoker.com>
633
634         Build fix for DRT breakage introduced in r28690.
635
636         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
637         (LayoutTestController::pathToLocalResource):
638
639 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
640
641         Reviewed by Alice and Sam.
642
643         - <rdar://5621435> Need a way to specify local resources (being loaded
644         from HTTP tests) on Windows.
645         - Implemented pathToLocalResource which exposes the functionality of
646         converting a given unix path to the correct location on Windows.
647
648         * DumpRenderTree/LayoutTestController.cpp:
649         (pathToLocalResourceCallback):
650         (LayoutTestController::staticFunctions):
651         * DumpRenderTree/LayoutTestController.h:
652         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
653         (LayoutTestController::pathToLocalResource):
654         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
655         (LayoutTestController::pathToLocalResource):
656
657 2007-12-12  Anders Carlsson  <andersca@apple.com>
658
659         Reviewed by Sam.
660
661         <rdar://problem/5132003>
662         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
663
664         * DumpRenderTree/win/DumpRenderTree.cpp:
665         (main):
666         Set the resource load delegate.
667         
668         * DumpRenderTree/win/DumpRenderTree.vcproj:
669         
670         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
671         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
672
673 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
674
675         Reviewed by Adam Roben.
676
677         Fix conversion from double to LPARAM in dispatchMessage().
678
679         * DumpRenderTree/win/EventSender.cpp:
680         (dispatchMessageCallback):
681
682 2007-12-11  Dan Bernstein  <mitz@apple.com>
683
684         Reviewed by Mark Rowe and Sam Weinig too!
685
686         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
687           fonts DumpRenderTree registers.
688
689         * DumpRenderTree/win/DumpRenderTree.cpp:
690         (initialize):
691
692 2007-12-11  Brady Eidson  <beidson@apple.com>
693
694         Reviewed by Anders
695
696         Make DumpRenderTree on mac use its own path for Databases testing
697
698         * DumpRenderTree/mac/DumpRenderTree.mm:
699         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
700           for future DRT-only use, then use it to construct the Databases path and set that default
701
702 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
703
704         Reviewed by Darin.
705
706         <rdar://problem/5535636>
707         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
708
709         http://bugs.webkit.org/show_bug.cgi?id=13916
710         JavaScript detects Tab as a character input on a textfield validation
711
712         * DumpRenderTree/mac/EventSendingController.mm:
713         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
714         Dispatch a keyup to better match what happens when a key is physically pressed.
715
716         * DumpRenderTree/win/EventSender.cpp:
717         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
718         returning from keyDown().
719         (getConstantCallback): Fixed a couple copy/paste mistakes.
720
721 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
722
723         Reviewed by Oliver.
724
725         - <rdar://5599845> Drosera: Does not show loal files in the file list
726         on the left side.
727
728         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
729         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
730         so the open source community can build.
731
732 2007-12-10  Brady Eidson  <beidson@apple.com>
733
734         Rubberstamped by Sam Weinig
735
736         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
737
738         * DumpRenderTree/mac/UIDelegate.mm:
739         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
740         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
741
742 2007-12-08  Oliver Hunt  <oliver@apple.com>
743
744         Reviewed by Sam W.
745
746         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
747         
748         Fixes <rdar://problem/5620249> Must disable SVG animation
749         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
750         
751         In order to allow finer grained control over the set of SVG features
752         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
753         distinct flags:
754         ENABLE_SVG_ANIMATION
755         ENABLE_SVG_FILTERS
756         ENABLE_SVG_FONTS
757         ENABLE_SVG_AS_IMAGE
758         ENABLE_SVG_USE
759         
760         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
761         
762         Script handles all the new build flags, and allows --svg-experimental
763         to automatically enable all features.
764
765         * Scripts/build-webkit:
766
767 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
768
769         Fix version parsing.
770
771         Rubber-stamped by Oliver.
772
773         * Drosera/win/Drosera.vcproj/auto-version.sh:
774
775 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
776
777         Build modifications for Drosera.
778
779         Reviewed by Adam.
780
781         * Drosera/DroseraWin.make: Added.
782         * Drosera/win/Drosera.vcproj/Drosera.rc:
783         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
784         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
785         * Drosera/win/Drosera.vcproj/VERSION: Added.
786         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
787
788 2007-12-06  Adam Roben  <aroben@apple.com>
789
790         Explicitly turn on the Mac font ascent hack on Windows
791
792         This keeps our font metrics matching those from Mac.
793
794         Reviewed by Hyatt.
795
796         * DumpRenderTree/win/DumpRenderTree.cpp:
797         (main):
798
799 2007-12-06  Anders Carlsson  <andersca@apple.com>
800
801         Rename main.c to main.cpp here too.
802         
803         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
804
805 2007-12-06  Sam Weinig  <sam@webkit.org>
806
807         Rubber stamped by Geoff.
808
809         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
810
811 2007-12-06  Darin Adler  <darin@apple.com>
812
813         * Scripts/do-webcore-rename: Some more renaming plans.
814
815 2007-12-06  Anders Carlsson  <andersca@apple.com>
816
817         Restore implementation of testGetIntIdentifier that was accidentally
818         removed somehow (possibly when I made PluginObject be a cpp file).
819         
820         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
821         (pluginInvoke):
822
823 2007-12-05  Anders Carlsson  <andersca@apple.com>
824
825         Make the entry points extern "C".
826         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
827         
828 2007-12-05  Anders Carlsson  <andersca@apple.com>
829
830         C++ warning fixes.
831         
832         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
833         (NPP_New):
834         (NPP_Destroy):
835         (NPP_SetWindow):
836         (NPP_NewStream):
837         (NPP_HandleEvent):
838         (NPP_URLNotify):
839         (NPP_GetValue):
840
841 2007-12-05  Anders Carlsson  <andersca@apple.com>
842
843         Add the .cpp files to the TestNetscapePlugIn target.
844
845         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
846
847 2007-12-05  Anders Carlsson  <andersca@apple.com>
848
849         Reviewed by Geoff.
850         
851         Rename the TestNetscapePlugIn .c files to be .cpp.
852
853         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
854         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
855         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
856         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
857         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
858         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
859         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
860         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
861
862 2007-12-05  Adam Roben  <aroben@apple.com>
863
864         Fix case of keypresses from the Windows implementation of eventSender.keyDown
865
866         This fixes several regression tests.
867
868         Reviewed by Alice.
869
870         * DumpRenderTree/win/EventSender.cpp:
871         (keyDownCallback): Virtual keycodes for ASCII characters are always
872         uppercase, so we need to check the case of the original character
873         passed in to eventSender.keyDown.
874
875 2007-12-05  Adam Roben  <aroben@apple.com>
876
877         Learn from Tim's mistakes
878
879         * DumpRenderTree/win/DumpRenderTree.cpp:
880         (runTest): Reset the authorAndUserStylesEnabled preference for each
881         test.
882
883 2007-12-05  Alp Toker  <alp@atoker.com>
884
885         Reviewed by Mark Rowe.
886
887         Initialize GTK+ and WebKit so the tests can run.
888
889         Reorganize the headers a little.
890
891         * DumpRenderTree/gtk/DumpRenderTree.cpp:
892         (main):
893
894 2007-12-04  Anders Carlsson  <andersca@apple.com>
895
896         Remove IWebScriptScope include.
897         
898         * Drosera/win/DebuggerDocumentPlatform.cpp:
899
900 2007-12-04  Sam Weinig  <sam@webkit.org>
901
902         Rubber stamped by Mark Rowe.
903
904         Define CF as platform for mac and revert r28409
905
906         * DumpRenderTree/DumpRenderTree.h:
907         * DumpRenderTree/mac/DumpRenderTreeMac.h:
908
909 2007-12-04  Sam Weinig  <sam@webkit.org>
910
911         Define CF as platform for windows.
912
913         Reviewed by Adam Roben.
914
915         * DumpRenderTree/win/DumpRenderTreeWin.h:
916
917 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
918
919         Reviewed by Adam and Darin.
920
921         - Removed a needless BSTR cleanup.
922
923         * Drosera/win/DebuggerDocumentPlatform.cpp:
924         (DebuggerDocument::getPlatformCurrentFunctionStack):
925
926 2007-11-27  Adam Roben  <aroben@apple.com>
927
928         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
929
930         Reviewed by Maciej.
931
932         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
933         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
934
935 2007-12-04  Alp Toker  <alp@atoker.com>
936
937         Prospective Win DRT build fix.
938
939         * DumpRenderTree/DumpRenderTree.h:
940
941 2007-12-04  Alp Toker  <alp@atoker.com>
942
943         Fix a clobbered copyright header.
944
945         * DumpRenderTree/gtk/DumpRenderTree.cpp:
946
947 2007-12-04  Xan Lopez  <xan@gnome.org>
948
949         Reviewed by Alp Toker.
950
951         http://bugs.webkit.org/show_bug.cgi?id=15561
952         GTK port needs DumpRenderTree implementation
953
954         Start work on the GTK+ DRT.
955
956         This does not work yet, and there are a few lingering style issues
957         (nothing major) but this patch has been stuck in the bug tracker for
958         too long already.
959
960         * DumpRenderTree/DumpRenderTree.h:
961         * DumpRenderTree/gtk: Added.
962         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
963         (autocorrectURL):
964         (shouldLogFrameLoadDelegates):
965         (dumpFrameScrollPosition):
966         (displayWebView):
967         (appendString):
968         (dumpFramesAsText):
969         (dumpRenderTreeAsText):
970         (dump):
971         (runTest):
972         (main):
973         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
974         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
975         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
976         (GCController::collect):
977         (GCController::collectOnAlternateThread):
978         (GCController::getJSObjectCount):
979         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
980         (LayoutTestController::~LayoutTestController):
981         (LayoutTestController::addDisallowedURL):
982         (LayoutTestController::clearBackForwardList):
983         (LayoutTestController::copyDecodedHostName):
984         (LayoutTestController::copyEncodedHostName):
985         (LayoutTestController::display):
986         (LayoutTestController::keepWebHistory):
987         (LayoutTestController::notifyDone):
988         (LayoutTestController::queueBackNavigation):
989         (LayoutTestController::queueForwardNavigation):
990         (LayoutTestController::queueLoad):
991         (LayoutTestController::queueReload):
992         (LayoutTestController::queueScript):
993         (LayoutTestController::setAcceptsEditing):
994         (LayoutTestController::setCustomPolicyDelegate):
995         (LayoutTestController::setMainFrameIsFirstResponder):
996         (LayoutTestController::setTabKeyCyclesThroughElements):
997         (LayoutTestController::setUseDashboardCompatibilityMode):
998         (LayoutTestController::setUserStyleSheetEnabled):
999         (LayoutTestController::setUserStyleSheetLocation):
1000         (LayoutTestController::setWindowIsKey):
1001         (LayoutTestController::setWaitToDump):
1002         (LayoutTestController::windowCount):
1003         (LayoutTestController::setPrivateBrowsingEnabled):
1004         (LayoutTestController::setAuthorAndUserStylesEnabled):
1005         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
1006         (JSStringCopyUTF8CString):
1007         (LoadItem::invoke):
1008         (ReloadItem::invoke):
1009         (ScriptItem::invoke):
1010         (BackForwardItem::invoke):
1011
1012 2007-12-03  Sam Weinig  <sam@webkit.org>
1013
1014         Move JavaScriptCore thread testing code to pthread specific directory
1015         and remove the dependance on CoreFoundation by using WTF::HashSet.
1016
1017         Reviewed by Geoff and Oliver.
1018
1019         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1020         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
1021         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
1022         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
1023         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
1024         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
1025         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
1026         * DumpRenderTree/pthreads: Added.
1027         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
1028         (javaScriptThreads):
1029         (runJavaScriptThread):
1030         (startJavaScriptThreads):
1031         (stopJavaScriptThreads):
1032
1033 2007-12-03  Andrew Bonventre  <andybons@google.com>
1034
1035         Reviewed by Darin Adler.
1036
1037         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
1038         Symbol lookup menu broken in debugger view
1039
1040         * Drosera/debugger.js: Fixed javascript error where document property
1041         should have been used instead of contentDocument in switchFunction that
1042         was breaking the select symbol dropdown menu.  This is because
1043         window.frames will return a Window object and not a frame object like
1044         the author was originally expecting.
1045
1046 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
1047
1048         Reviewed by Adam.
1049
1050         - <rdar://5618942> Drosera: Console window does not process everything
1051         correctly.
1052         - <rdar://5619005> Drosera: could be sped up by moving the 
1053         WebScriptScope stuff into the WebScriptCallFrame.
1054         - Now the console can correctly process objects and does not receive
1055         notifications from JavaScriptCore about the JavaScript in Drosera's
1056         own process.
1057
1058         * Drosera/win/DebuggerDocumentPlatform.cpp:
1059         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1060         (DebuggerDocument::platformValueForScopeVariableNamed):
1061
1062 2007-12-03  Stephanie  <slewis@apple.com>
1063
1064         Reviewed by Darin.
1065
1066         Check to see if we are building a debug root
1067
1068         * Scripts/check-for-global-initializers: 
1069
1070 2007-12-03  Dan Bernstein  <mitz@apple.com>
1071
1072         Reviewed by Darin Adler.
1073
1074         - added a testGetIntIdentifier() method to TestNetscapePlugIn
1075
1076         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
1077         (pluginInvoke):
1078
1079 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
1080
1081         Reviewed by Oliver.
1082
1083         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
1084         in a more fine-grained manner than eventSender.keyDown().
1085
1086         * DumpRenderTree/win/EventSender.cpp:
1087         (getConstantCallback):
1088         (dispatchMessageCallback):
1089
1090 2007-12-02  Darin Adler  <darin@apple.com>
1091
1092         * Scripts/do-webcore-rename: More planned renaming.
1093
1094 2007-12-02  Sam Weinig  <sam@webkit.org>
1095
1096         Rubber stamped by Anders.
1097
1098         Use [NSURL absoluteString] instead of [NSURL description] in order to get
1099         more uniform results cross platform.
1100
1101         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1102         (-[NSURL _drt_descriptionSuitableForTestResult]):
1103
1104 2007-12-02  Sam Weinig  <sam@webkit.org>
1105
1106         Rubber stamped by Niko.
1107
1108         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
1109
1110         * DumpRenderTree/win/DumpRenderTree.cpp:
1111         * DumpRenderTree/win/DumpRenderTree.vcproj:
1112         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
1113         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
1114         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
1115         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
1116
1117 2007-12-01  Alp Toker  <alp@atoker.com>
1118
1119         Reviewed by Adam Roben.
1120
1121         Make use of the newly introduced webkit.h convenience header.
1122
1123         * GtkLauncher/main.c:
1124
1125 2007-12-01  Adam Treat  <treat@kde.org>
1126
1127         Reviewed by Simon.
1128
1129         * Check to see if the directory exists and exit if not.
1130
1131         * DumpRenderTree/qt/main.cpp:
1132         (main):
1133
1134 2007-12-01  Adam Treat  <treat@kde.org>
1135
1136         Reviewed by Simon.
1137
1138         * Don't hide symbols when in Debug mode
1139         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
1140
1141
1142         * DumpRenderTree/qt/main.cpp:
1143         (messageHandler):
1144
1145 2007-11-30  Alp Toker  <alp@atoker.com>
1146
1147         Reviewed by Adam Roben.
1148
1149         http://bugs.webkit.org/show_bug.cgi?id=15691
1150         [GTK] Public API does not follow GTK+ conventions
1151
1152         Refactor the WebKit/GTK+ public API. Changes:
1153           WebKitPage -> WebKitWebView
1154           WebKitFrame -> WebKitWebFrame
1155
1156         Public API source and header names have been updated to mirror the API
1157         changes.
1158
1159         The API is now kept in WebKit/gtk/WebView to match other ports in the
1160         same class such as Mac and Win.
1161
1162         * GtkLauncher/main.c:
1163         (activate_uri_entry_cb):
1164         (link_hover_cb):
1165         (title_change_cb):
1166         (progress_change_cb):
1167         (go_back_cb):
1168         (go_forward_cb):
1169         (create_browser):
1170         (main):
1171
1172 2007-11-30  Adam Roben  <aroben@apple.com>
1173
1174         Hopefully the final build fix
1175
1176         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
1177         pull in WTF's assertion/logging functions.
1178
1179 2007-11-30  Adam Roben  <aroben@apple.com>
1180
1181         Another build fix
1182
1183         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
1184         WebKit.lib.
1185
1186 2007-11-30  Adam Roben  <aroben@apple.com>
1187
1188         Debug build fix
1189
1190         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
1191         configuration.
1192         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
1193         projects.
1194         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
1195         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
1196         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
1197
1198 2007-11-30  Sam Weinig  <sam@webkit.org>
1199
1200         Reviewed by Adam Roben.
1201
1202         Fix drawSelectionRect to actually draw the selection rect.
1203
1204         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1205         (drawSelectionRect):
1206
1207 2007-11-30  Darin Adler  <darin@apple.com>
1208
1209         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
1210
1211 2007-11-30  Darin Adler  <darin@apple.com>
1212
1213         * Scripts/do-webcore-rename: Get ready for some future renaming.
1214
1215 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1216
1217         Reviewed by Adam.
1218
1219         - Removed some unnecessary functions and changed an unused return type. 
1220
1221         * Drosera/win/DebuggerClient.cpp:
1222         (registerConsoleClass):
1223         * Drosera/win/DebuggerClient.h:
1224         * Drosera/win/Drosera.cpp:
1225         (registerDroseraClass):
1226
1227 2007-11-28  Alp Toker  <alp@atoker.com>
1228
1229         Reviewed by Timothy Hatcher.
1230
1231         http://bugs.webkit.org/show_bug.cgi?id=16174
1232         [GTK] Use "URI" not "URL" in public API
1233
1234         Replace use of the term "URL" with "URI" in public headers,
1235         documentation and some internal code to match GLib/GTK+ convention.
1236
1237         This is now mentioned in the API guidelines:
1238           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
1239
1240         * GtkLauncher/main.c:
1241         (activate_uri_entry_cb):
1242         (title_change_cb):
1243         (create_toolbar):
1244         (main):
1245
1246 2007-11-29  Anders Carlsson  <andersca@apple.com>
1247
1248         Reviewed by Sam.
1249
1250         <rdar://problem/5230478>
1251         FrameLoadDelegate callbacks are not dumped in DRT.
1252         
1253         * DumpRenderTree/win/DumpRenderTree.cpp:
1254         (shouldLogFrameLoadDelegates):
1255         (runTest):
1256         (main):
1257         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
1258         (BSTRtoString):
1259         (descriptionSuitableForTestResult):
1260         (FrameLoadDelegate::QueryInterface):
1261         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1262         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1263         (FrameLoadDelegate::didCommitLoadForFrame):
1264         (FrameLoadDelegate::didFinishLoadForFrame):
1265         (FrameLoadDelegate::willCloseFrame):
1266         (FrameLoadDelegate::didClearWindowObject):
1267         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1268         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1269         * DumpRenderTree/win/FrameLoaderDelegate.h:
1270         (FrameLoadDelegate::windowScriptObjectAvailable):
1271         (FrameLoadDelegate::didFirstLayoutInFrame):
1272
1273 2007-11-29  Sam Weinig  <sam@webkit.org>
1274
1275         Reviewed by Anders.
1276
1277         Add database quota UIDelegates methods to DRT UIDelegate.
1278
1279         * DumpRenderTree/mac/UIDelegate.mm:
1280         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1281         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
1282
1283 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1284
1285         Reviewed by Sam.
1286
1287         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
1288         dying and vice versa.
1289         - This fix will allow Drosera and Safari to reconnect if either of them
1290         closes correctly, but does not fix the case where one of them dies
1291         silently.
1292
1293         * Drosera/win/ServerConnection.cpp:
1294         (ServerConnection::attemptToCreateServerConnection): Added a safety
1295         check, because it's possilbe to try to connect to a server that's dying.
1296         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
1297         the server has died.
1298         * Drosera/win/ServerConnection.h: Added the new function and removed
1299         an unnecessary member.
1300
1301 2007-11-29  Anders Carlsson  <andersca@apple.com>
1302
1303         * DumpRenderTree/win/DumpRenderTree.vcproj:
1304         Add shlwapi.lib to all configurations.
1305
1306 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1307
1308         - Build fix.  Added additional includes for VS Express to the Release
1309         project.
1310
1311         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1312
1313 2007-11-29  Anders Carlsson  <andersca@apple.com>
1314
1315         Reviewed by Adam.
1316
1317         <rdar://problem/5132005>
1318         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
1319         
1320         * DumpRenderTree/win/DumpRenderTree.vcproj:
1321         Add shlwapi.lib
1322         
1323         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1324         (LayoutTestController::setUserStyleSheetEnabled):
1325         Implement this.
1326         
1327         (appendComponentToPath):
1328         New method which wraps the Win32 API PathAppend.
1329         
1330         (followShortcuts):
1331         New method which checks if a file points to a shortcut and
1332         follows the shortcut.
1333         
1334         (resolveCygwinPath):
1335         New method that takes a cygwin unix-style path and returns the Win32 path.
1336         
1337         (cfStringRefToWString):
1338         
1339         (LayoutTestController::setUserStyleSheetLocation):
1340         Implement this.
1341
1342 2007-11-29  Alice Liu  <alice.liu@apple.com>
1343
1344         Reviewed by Adam.
1345
1346         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
1347
1348         * DumpRenderTree/win/EventSender.cpp:
1349         (keyDownCallback):
1350         uppercase letters were being sent as lowercase letters without the shift key down.
1351
1352 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
1353
1354         - Windows build fix. VS express needs some love.
1355
1356         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1357
1358 2007-11-28  Darin Adler  <darin@apple.com>
1359
1360         Reviewed by Adam Roben.
1361
1362         * DumpRenderTree/mac/EventSendingController.mm:
1363         (-[EventSendingController keyDown:withModifiers:]):
1364         Send capital letters through as lowercase letters with the shift key down
1365         rather than sending them as if they were highly unusual "capital letter keys".
1366
1367         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
1368         where you need to update results and more tests are failing than before.
1369
1370 2007-11-28  Anders Carlsson  <andersca@apple.com>
1371
1372         Reviewed by Darin.
1373
1374         <rdar://problem/5132001>
1375         contextClick is not implemented in DRT on Windows.
1376         
1377         * DumpRenderTree/win/EventSender.cpp:
1378         (contextClickCallback):
1379         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
1380         by a WM_RBUTTONUP message.
1381         
1382         * DumpRenderTree/win/UIDelegate.cpp:
1383         (UIDelegate::hasCustomMenuImplementation):
1384         (UIDelegate::trackCustomPopupMenu):
1385         * DumpRenderTree/win/UIDelegate.h:
1386         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
1387         menu from being shown (and causing the DRT to hang).
1388
1389 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
1390
1391         Reviewed by Darin.
1392
1393         Fix DumpRenderTree ObjC bug comparing strings.
1394
1395         * DumpRenderTree/mac/ObjCController.m:
1396         (-[ObjCController identityIsEqual::]): Compare strings with string
1397         equality instead of identiy equality.
1398
1399 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1400
1401         Reviewed by Sam.
1402
1403         Reset the authorAndUserStylesEnabled preference
1404         back to YES for each test. Fixes the broken tests.
1405
1406         * DumpRenderTree/mac/DumpRenderTree.mm:
1407         (resetWebViewToConsistentStateBeforeTesting):
1408
1409 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
1410
1411         Reviewed by Adam.
1412
1413         - Drosera now displays the console window, although it cannot currently
1414         process JavaScript.
1415
1416         * Drosera/win/DebuggerClient.cpp: Shows the console window.
1417         (registerConsoleClass): Implemented.
1418         (consoleWndProc): Implemented.
1419         (DebuggerClient::onSize): Implemented.
1420         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
1421         new window.
1422         * Drosera/win/DebuggerClient.h: Added needed method and members for 
1423         creating and maintaining a new window.
1424         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
1425         lines of code to more appropriate places.
1426         (Drosera::handleCommand):
1427         (Drosera::initUI):
1428         (Drosera::onSize):
1429         (Drosera::attach):
1430
1431 2007-11-27  Timothy Hatcher  <timothy@apple.com>
1432
1433         Reviewed by Dave Hyatt.
1434
1435         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
1436         
1437         Add support for disabling author and user styles for testing.
1438
1439         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1440         * DumpRenderTree/LayoutTestController.cpp:
1441         (setAuthorAndUserStylesEnabledCallback):
1442         (LayoutTestController::staticFunctions):
1443         * DumpRenderTree/LayoutTestController.h:
1444         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1445         (LayoutTestController::setAuthorAndUserStylesEnabled):
1446         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1447         (LayoutTestController::setAuthorAndUserStylesEnabled):
1448
1449 2007-11-26  Dan Bernstein  <mitz@apple.com>
1450
1451         - Tiger build fix.
1452
1453         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1454
1455 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
1456
1457         Reviewed by Maciej.
1458
1459         - Implemented displaying variables for Drosera on Win.
1460
1461         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
1462         that retrieve variables to not hold onto the return value since it's
1463         not returned.  Also changed to use the new signatures of the retrieval
1464         functions.
1465         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
1466         (DebuggerDocument::platformValueForScopeVariableNamed):
1467         * Drosera/win/Drosera.cpp: Removed a needless TODO.
1468         (droseraWndProc):
1469
1470 2007-11-26  Sam Weinig  <sam@webkit.org>
1471
1472         Cleanup names of painting and repainting functions.
1473
1474         Reviewed by Adam Roben.
1475
1476         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1477         (drawSelectionRect): was drawSelectionRectIntoContext.
1478         (dumpWebViewAsPixelsAndCompareWithExpected):
1479         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1480         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1481         (paintWebView): was drawWebViewIntoContext.
1482         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
1483
1484 2007-11-26  Sam Weinig  <sam@webkit.org>
1485
1486         Reviewed by Dan Bernstein.
1487
1488         - Leopard build fix
1489
1490         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1491
1492 2007-11-26  Sam Weinig  <sam@webkit.org>
1493
1494         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
1495         Use shared PixelDumpSupport for Mac DRT
1496
1497         Reviewed by Adam Roben.
1498
1499         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1500         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
1501         * DumpRenderTree/cg/ImageDiffCG.cpp:
1502         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1503         (drawSelectionRectIntoContext):
1504         (dumpWebViewAsPixelsAndCompareWithExpected):
1505         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1506         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1507         * DumpRenderTree/mac/DumpRenderTree.mm:
1508         (dump):
1509         * DumpRenderTree/mac/ImageDiff.m: Removed.
1510         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
1511         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
1512         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
1513         (setDefaultColorProfileToRGB):
1514         (getBitmapContextFromWebView):
1515         (drawWebViewIntoContext):
1516         (repaintWithVerticalSweep):
1517         (repaintWithHorizontalSweep):
1518         (getSelectionRect):
1519         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
1520
1521 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
1522
1523         Bug 16052: prepare-ChangeLog doesn't report deleted files
1524         <http://bugs.webkit.org/show_bug.cgi?id=16052>
1525
1526         Reviewed by Sam.
1527
1528         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
1529
1530 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
1531
1532         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
1533         <http://bugs.webkit.org/show_bug.cgi?id=15864>
1534
1535         Reviewed by Adam.
1536
1537         Roll functionality of merge-changelog into resolve-ChangeLogs
1538         script.  The script now checks for ChangeLog.rej and
1539         ChangeLog.orig files first.  If it finds them, it uses the
1540         ChangeLog.rej file as a patch (in old contextual diff format) to
1541         apply with --fuzz=3.
1542
1543         * Scripts/merge-changelog: Removed.
1544         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
1545
1546 2007-11-25  Sam Weinig  <sam@webkit.org>
1547
1548         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
1549
1550         Reviewed by Mark Rowe.
1551
1552         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1553         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1554         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1555         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
1556         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
1557
1558 2007-11-25  Sam Weinig  <sam@webkit.org>
1559
1560         Convert DumpRenderTree to ues .xcconfig files.
1561
1562         Reviewed by Mark Rowe.
1563
1564         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1565         * DumpRenderTree/mac/Configurations: Added.
1566         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
1567         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
1568         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
1569
1570 2007-11-25  Sam Weinig  <sam@webkit.org>
1571
1572         Add ForwardingHeaders to wtf for DumpRenderTree.
1573
1574         Reviewed by Mark Rowe.
1575
1576         * DumpRenderTree/DumpRenderTree.h:
1577         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1578         * DumpRenderTree/ForwardingHeaders: Added.
1579         * DumpRenderTree/ForwardingHeaders/wtf: Added.
1580         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
1581         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
1582         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
1583         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
1584         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
1585         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
1586         * DumpRenderTree/LayoutTestController.cpp:
1587         * DumpRenderTree/WorkQueue.cpp:
1588         * DumpRenderTree/mac/DumpRenderTree.mm:
1589         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1590         * DumpRenderTree/mac/JavaScriptThreading.cpp:
1591         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1592         * DumpRenderTree/mac/ObjCController.m:
1593         * DumpRenderTree/mac/UIDelegate.mm:
1594         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1595
1596 2007-11-25  Adam Roben  <aroben@apple.com>
1597
1598         Fix some test failures caused by r28019
1599
1600         Now that stdout is in binary mode, we need to always use printf
1601         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
1602         the output.
1603
1604         Reviewed by Sam.
1605
1606         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
1607         printf.
1608         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1609         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1610         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1611         (UIDelegate::webViewAddMessageToConsole):
1612
1613 2007-11-25  Adam Roben  <aroben@apple.com>
1614
1615         Set the font smoothing preference in DRT
1616
1617         This makes the pixel results on Windows closer to the Mac results.
1618
1619         Reviewed by Mitz.
1620
1621         * DumpRenderTree/win/DumpRenderTree.cpp:
1622         (initializePreferences):
1623
1624 2007-11-25  Adam Roben  <aroben@apple.com>
1625
1626         Port ImageDiff to CG and C++
1627
1628         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
1629         <rdar://5071708>
1630
1631         Reviewed by Sam.
1632
1633         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
1634         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
1635         (main):
1636         (createImageFromStdin):
1637         (compareImages):
1638         (getDifferenceBitmap):
1639         (computePercentageDifferent):
1640         * DumpRenderTree/win/ImageDiff.vcproj: Added.
1641
1642 2007-11-25  Adam Roben  <aroben@apple.com>
1643
1644         Fix image diff link generation on Windows
1645
1646         Reviewed by Sam.
1647
1648         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
1649         to toURL.
1650
1651 2007-11-25  Adam Roben  <aroben@apple.com>
1652
1653         Implement pixel dumping in Windows DRT
1654
1655         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
1656         <rdar://5071708>
1657
1658         Reviewed by Sam.
1659
1660         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
1661         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
1662         Content-Length header.
1663         (getMD5HashStringForBitmap):
1664         (dumpWebViewAsPixelsAndCompareWithExpected):
1665         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
1666         * DumpRenderTree/win/DumpRenderTree.cpp:
1667         (dump): Do a pixel dump if requested.
1668         (main): Parse pixel test options.
1669         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
1670         the cg/ subdirectory to the include path.
1671         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
1672         available in a header or import library, so we have to go through this
1673         LoadLibrary/GetProcAddress dance to use them.
1674         (cryptDLL):
1675         (init):
1676         (update):
1677         (final):
1678         (MD5_Init):
1679         (MD5_Update):
1680         (MD5_Final):
1681         * DumpRenderTree/win/MD5.h: Added.
1682         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
1683         moved up to the top level to share it with Mac eventually.
1684         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
1685         (getBitmapContextFromWebView): Forces the WebView to paint using a
1686         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
1687
1688 2007-11-25  Adam Roben  <aroben@apple.com>
1689
1690         Clean up Windows DRT's option parsing a little bit
1691
1692         Reviewed by Sam.
1693
1694         * DumpRenderTree/win/DumpRenderTree.cpp:
1695         (main): Put non-option arguments into a Vector.
1696
1697 2007-11-25  Adam Roben  <aroben@apple.com>
1698
1699         Make Windows DRT stop changing LF into CRLF
1700
1701         Reviewed by Sam.
1702
1703         * DumpRenderTree/win/DumpRenderTree.cpp:
1704         (main): Put stdout in binary mode.
1705         * Scripts/run-webkit-tests: Remove the CRLF hack.
1706
1707 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
1708
1709         Removed empty directory.
1710
1711         * Scripts/resources: Removed.
1712
1713 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
1714
1715         Fix bisect-builds to work with recent WebKit nightly builds.
1716
1717         Reviewed by Dan.
1718
1719         * Scripts/bisect-builds: Check for the 
1720         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
1721         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
1722         to WebKit.app/Contents/Resources.
1723
1724 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
1725
1726         Reviewed by Maciej.
1727
1728         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
1729         not closed (affects digg.com)
1730
1731         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
1732         one after finishing with a test to avoid having its delayed onload handler firing when
1733         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
1734         but it helps somewhat.
1735
1736 2007-11-22  Mark Rowe  <mrowe@apple.com>
1737
1738         Reviewed by Alp Toker.
1739
1740         Fix build-webkit to propagate make's exit status if it fails.
1741
1742         * Scripts/webkitdirs.pm:
1743
1744 2007-11-22  Dan Bernstein  <mitz@apple.com>
1745
1746         Reviewed by Mark Rowe.
1747
1748         - fix crash when running pixel tests
1749
1750         * DumpRenderTree/mac/DumpRenderTree.mm:
1751         (dumpRenderTree): Parse the command line options before setting up the
1752         environment so that we know if we need to set up the pixel dump
1753         machinery.
1754
1755 2007-11-21  Eric Seidel  <eric@webkit.org>
1756
1757         Speculative build fix for Tiger.
1758
1759         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
1760
1761 2007-11-21  Eric Seidel  <eric@webkit.org>
1762
1763         Reviewed by Tim Hatcher.
1764
1765         Break out more of DumpRenderTree.mm into individual files
1766
1767         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1768         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
1769         (checkedMalloc):
1770         (checkedRealloc):
1771         (makeLargeMallocFailSilently):
1772         * DumpRenderTree/mac/CheckedMalloc.h: Added.
1773         * DumpRenderTree/mac/DumpRenderTree.mm:
1774         (crashHandler):
1775         (dump):
1776         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1777         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
1778         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1779         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1780         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1781         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
1782         (javaScriptThreads):
1783         (runJavaScriptThread):
1784         (startJavaScriptThreads):
1785         (stopJavaScriptThreads):
1786         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
1787         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
1788         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
1789         (restoreColorSpace):
1790         (setDefaultColorProfileToRGB):
1791         (initializeColorSpaceAndScreeBufferForPixelTests):
1792         (md5HashStringForBitmap):
1793         (dumpWebViewAsPixelsAndCompareWithExpected):
1794
1795 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
1796
1797         Move install-unix-extras to wx directory as it seems only to be used by that 
1798         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
1799         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
1800         have install-unix-extras install into WebKitLibraries as per
1801         convention.
1802         
1803         Reviewed by Mark Rowe.
1804
1805         * Scripts/install-unix-extras: Removed.
1806         * wx/build-wxwebkit:
1807         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
1808
1809 2007-11-21  Eric Seidel  <eric@webkit.org>
1810
1811         Reviewed by Adam.
1812
1813         More refactoring for greater code readability
1814
1815         * DumpRenderTree/mac/DumpRenderTree.mm:
1816         (initializeGlobalsFromCommandLineOptions):
1817         (initializeColorSpaceAndScreeBufferForPixelTests):
1818         (addTestPluginsToPluginSearchPath):
1819         (useLongRunningServerMode):
1820         (runTestingServerLoop):
1821         (prepareConsistentTestingEnvironment):
1822         (dumpRenderTree):
1823         (main):
1824         (dumpFramesAsText):
1825         (dumpBackForwardListForWebView):
1826         (sizeWebViewForCurrentTest):
1827         (methodNameStringForFailedTest):
1828         (dumpBackForwardListForAllWindows):
1829         (dumpWebViewAsPixelsAndCompareWithExpected):
1830         (invalidateAnyPreviousWaitToDumpWatchdog):
1831         (dump):
1832         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1833         * DumpRenderTree/mac/UIDelegate.mm:
1834         (-[UIDelegate webView:createWebViewWithRequest:]):
1835
1836 2007-11-21  Eric Seidel  <eric@webkit.org>
1837
1838         Reviewed by Tim Hatcher.
1839
1840         Abstract more of DRT into static methods
1841
1842         * DumpRenderTree/mac/DumpRenderTree.mm:
1843         (setDefaultsToConsistentValuesForTesting):
1844         (setupSignalHandlers):
1845         (allocateGlobalControllers):
1846         (releaseAndZero):
1847         (releaseGlobalControllers):
1848         (dumpRenderTree):
1849         (shouldLogFrameLoadDelegates):
1850         (createCFURLFromPathOrURL):
1851         (resetWebViewToConsistentStateBeforeTesting):
1852         (runTest):
1853
1854 2007-11-21  Eric Seidel  <eric@webkit.org>
1855
1856         Reviewed by Tim Hatcher.
1857
1858         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
1859
1860         * DumpRenderTree/DumpRenderTree.h:
1861         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1862         * DumpRenderTree/mac/DumpRenderTree.mm:
1863         (dumpRenderTree):
1864         (dump):
1865         (runTest):
1866         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
1867         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
1868         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1869         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
1870         (-[DumpRenderTreePasteboard declareType:owner:]):
1871         (+[LocalPasteboard alloc]):
1872         (-[LocalPasteboard init]):
1873         (-[LocalPasteboard dealloc]):
1874         (-[LocalPasteboard name]):
1875         (-[LocalPasteboard releaseGlobally]):
1876         (-[LocalPasteboard declareTypes:owner:]):
1877         (-[LocalPasteboard addTypes:owner:]):
1878         (-[LocalPasteboard changeCount]):
1879         (-[LocalPasteboard types]):
1880         (-[LocalPasteboard availableTypeFromArray:]):
1881         (-[LocalPasteboard setData:forType:]):
1882         (-[LocalPasteboard dataForType:]):
1883         (-[LocalPasteboard setPropertyList:forType:]):
1884         (-[LocalPasteboard setString:forType:]):
1885         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
1886         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
1887         (+[DumpRenderTreeWindow allWindows]):
1888         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1889         (-[DumpRenderTreeWindow dealloc]):
1890         (-[DumpRenderTreeWindow isKeyWindow]):
1891         (-[DumpRenderTreeWindow keyDown:]):
1892
1893 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
1894
1895         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
1896         it indiscriminately copies any headers inside JavaScriptCore,
1897         which includes Tiger ICU headers. 
1898
1899         * wx/build-wxwebkit:
1900         Don't run WebCore/move-js-headers.sh any longer.
1901
1902 2007-11-20  Adam Treat  <treat@kde.org>
1903
1904         Reviewed by David Kilzer.
1905
1906         * Prepend git branch name to $baseProductDir
1907
1908         * Scripts/VCSUtils.pm:
1909         * Scripts/webkitdirs.pm:
1910
1911 2007-11-20  Mark Rowe  <mrowe@apple.com>
1912
1913         Reviewed by Simon Hausmann.
1914
1915         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
1916         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
1917         Have it trigger a "make distclean" rather than "make clean" to ensure that the
1918         built product and generated Makefile's are removed.
1919
1920 2007-11-19  Alp Toker  <alp@atoker.com>
1921
1922         Reviewed by Mark Rowe.
1923
1924         http://bugs.webkit.org/show_bug.cgi?id=16040
1925         [GTK] GtkLauncher should be written in C
1926
1927         Port GtkLauncher to plain C.
1928
1929         Use a more conventional GTK+ coding style.
1930
1931         Use a toolbar instead of menus.
1932
1933         Various signature fixes and cleanups.
1934
1935         Add a license header. Assume all previous modifications were copyright
1936         assigned to Apple Inc. by default.
1937
1938         * GtkLauncher/GtkLauncher.pro:
1939         * GtkLauncher/main.c: Added.
1940         (activate_url_entry_cb):
1941         (update_title):
1942         (link_hover_cb):
1943         (title_change_cb):
1944         (progress_change_cb):
1945         (destroy_cb):
1946         (go_back_cb):
1947         (go_forward_cb):
1948         (create_browser):
1949         (create_statusbar):
1950         (create_toolbar):
1951         (create_window):
1952         (main):
1953         * GtkLauncher/main.cpp: Removed.
1954
1955 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
1956
1957         Build script fixes to ensure they do the right thing for the 
1958         wx port, and update build-wxwebkit to reflect the way the
1959         build scripts now work.
1960
1961         Reviewed by Adam.
1962
1963         * Scripts/build-testkjs:
1964         * Scripts/build-webkit:
1965         * Scripts/run-javascriptcore-tests:
1966         * Scripts/webkitdirs.pm:
1967         * wx/build-wxwebkit:
1968
1969 2007-11-18  Eric Seidel  <eric@webkit.org>
1970
1971         Reviewed by Anders.
1972
1973         Make run-javascriptcore-tests report failures on exit (to support git bisect)
1974
1975         * Scripts/run-javascriptcore-tests:
1976
1977 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
1978
1979         Reviewed by Adam Roben.
1980
1981         Make run-webkit-tests work with Windows debug build.
1982
1983         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
1984         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
1985         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
1986         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
1987         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
1988
1989 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
1990
1991         Add wxWebKit sample and build script, and integrate it with 
1992         build-webkit. Also make build-webkit --clean work for all
1993         ports.
1994
1995         Reviewed by Darin Adler.
1996
1997         * Scripts/build-webkit:
1998         * Scripts/webkitdirs.pm:
1999         * wx: Added.
2000         * wx/browser: Added.
2001         * wx/browser/browser.bkl: Added.
2002         * wx/browser/browser.cpp: Added.
2003         * wx/build-wxwebkit: Added.
2004
2005 2007-11-17  Adam Roben  <aroben@apple.com>
2006
2007         Make it easy to run Safari in the debugger on Windows
2008
2009         I've added a new script, debug-safari, which launches Safari in the
2010         debugger. On OS X it just calls gdb-safari.
2011
2012         Reviewed by Mark Rowe.
2013
2014         * FindSafari/FindSafari.cpp:
2015         (_tmain): Added a /debugger flag, which in combination with
2016         /printSafariLauncher will print a script that launches Safari in the
2017         debugger.
2018         * Scripts/debug-safari: Added.
2019         * Scripts/run-safari: Changed to call runSafari().
2020         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
2021         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
2022         first argument along to FindSafari.
2023         * Scripts/webkitdirs.pm:
2024         (sub runSafari): Added.
2025
2026 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
2027
2028         Reviewed by Adam Roben.
2029
2030         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
2031
2032 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
2033
2034         Reviewed by David Kilzer.
2035
2036         The git config command was renamed to repo-config at some point. This
2037         change tries git config and then git repo-config if the first fails.
2038
2039         * Scripts/prepare-ChangeLog:
2040         (gitConfig):
2041
2042 2007-11-16  Dan Bernstein  <mitz@apple.com>
2043
2044         Reviewed by Darin Adler and Sam Weinig.
2045
2046         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
2047
2048         * DumpRenderTree/win/EventSender.cpp:
2049         (keyDownCallback): For characters that cannot be entered on the active
2050         keyboard layout, send a WM_CHAR message with the character along with
2051         a WM_KEYDOWN message with a virtual key code of 255.
2052
2053 2007-11-16  Mark Rowe  <mrowe@apple.com>
2054
2055         Reviewed by Tim Hatcher.
2056
2057         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
2058
2059         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2060         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2061
2062 2007-11-15  Adam Roben  <aroben@apple.com>
2063
2064         Make run-safari actually work on Windows
2065
2066         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
2067         chdir call.
2068
2069 2007-11-14  Adam Roben  <aroben@apple.com>
2070
2071         Updates to Safari launching now that 3.0.4 is released
2072
2073         Reviewed by Sam.
2074
2075         * FindSafari/FindSafari.cpp:
2076         (getWebViewCLSID): Use version-independent ProgID.
2077         * Scripts/run-safari: Use run-webkit-nightly.cmd.
2078
2079 2007-11-14  Anders Carlsson  <andersca@apple.com>
2080
2081         Reviewed by Adam.
2082
2083         <rdar://problem/5309081>
2084         In DRT, "plugin.logDestroy = true" not working on Windows.
2085         
2086         * DumpRenderTree/win/TestNetscapePlugin/main.c:
2087         (NPP_Destroy):
2088
2089 2007-11-14  Eric Seidel  <eric@webkit.org>
2090
2091         Reviewed by Sam.
2092
2093         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
2094
2095 2007-11-14  Anders Carlsson  <andersca@apple.com>
2096
2097         Reviewed by Adam.
2098
2099         <rdar://problem/5141186>
2100         window.layoutTestController.setWindowIsKey is not implemented in DRT.
2101         
2102         Implement setWindowIsKey.
2103         
2104         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2105         (LayoutTestController::setWindowIsKey):
2106
2107 2007-11-13  Sam Weinig  <sam@webkit.org>
2108
2109         Reviewed by Adam Roben.
2110
2111         Fix for <rdar://problem/5382579>
2112         http/tests/security/cross-frame-access-put.html reports large 
2113         negative numbers for screenLeft and screenTop (Mac reports "0")
2114
2115         * DumpRenderTree/win/UIDelegate.cpp:
2116         (UIDelegate::UIDelegate): Initialize the RECT.
2117         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
2118         (UIDelegate::webViewFrame): ditto.
2119         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
2120
2121 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
2122
2123         Reviewed by Adam.
2124
2125         - Make Drosera show source, source URLs, and function stack on Windows,
2126         and some minor fixes.
2127
2128         * Drosera/DebuggerDocument.cpp: Force source to always update display.
2129         (DebuggerDocument::updateFileSource):
2130         * Drosera/debugger.js: Force source to always update display.
2131         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
2132         menu controls.
2133         (DebuggerClient::resume):
2134         (DebuggerClient::pause):
2135         (DebuggerClient::stepInto):
2136         (DebuggerClient::stepOver):
2137         (DebuggerClient::stepOut):
2138         (DebuggerClient::showConsole):
2139         (DebuggerClient::closeCurrentFile):
2140         * Drosera/win/DebuggerClient.h: Ditto.
2141         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
2142         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
2143         removed two bugs.  1) caller could be in a bad state when asked to
2144         assign into it. 2) BSTRs were not created correctly.
2145         (DebuggerDocument::getPlatformCurrentFunctionStack):
2146         * Drosera/win/Drosera.cpp: Hook up the menu controls.
2147         (droseraWndProc):
2148         (handleCommand):
2149         (Drosera::resume):
2150         (Drosera::pause):
2151         (Drosera::stepInto):
2152         (Drosera::stepOver):
2153         (Drosera::stepOut):
2154         (Drosera::showConsole):
2155         (Drosera::closeCurrentFile):
2156         * Drosera/win/Drosera.h: Hook up the menu controls.
2157         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
2158         functions, added a null check, and fixed another bug where caller could
2159         be in a bad state when asked to assign into it.
2160         (ServerConnection::didLoadMainResourceForDataSource):
2161         (ServerConnection::getCallerFrame):
2162         * Drosera/win/ServerConnection.h: Safety first.
2163
2164 2007-11-13  Dan Bernstein  <mitz@apple.com>
2165
2166         Reviewed by Darin Adler.
2167
2168         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
2169           DumpRenderTree --pixel-tests renders each test twice
2170
2171         * DumpRenderTree/mac/DumpRenderTree.mm:
2172         (dumpRenderTree): Removed the --paint option because the painting code
2173         is always exercised as a result of
2174         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
2175         calling -displayIfNeeded.
2176         (dump): Changed to always grab the image from the window since the view
2177         is always displayed.
2178         (runTest):
2179         (displayWebView):
2180         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
2181         because it always paints.
2182
2183 2007-11-12  Antti Koivisto  <antti@apple.com>
2184
2185         Reviewed by Adele.
2186         
2187         Add support for http media tests
2188
2189         * Scripts/run-webkit-tests:
2190
2191 2007-11-12  Sam Weinig  <sam@webkit.org>
2192
2193         Reviewed by Adam Roben.
2194
2195         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
2196
2197         * DumpRenderTree/win/DumpRenderTree.cpp:
2198         (runTest):
2199         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2200         (LayoutTestController::setPrivateBrowsingEnabled):
2201
2202 2007-11-12  Adam Roben  <aroben@apple.com>
2203
2204         * Scripts/update-webkit-localizable-strings: Changed to only scan the
2205         mac and win subdirectories.
2206
2207 2007-11-11  Adam Roben  <aroben@apple.com>
2208
2209         Fix <rdar://5133816> keepWebHistory is not implemented
2210
2211         Fixes fast/history/clicked-link-is-visited.html.
2212
2213         Reviewed by Darin.
2214
2215         * DumpRenderTree/win/DumpRenderTree.cpp:
2216         (runTest): Clear the optionalSharedHistory.
2217         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2218         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
2219
2220 2007-11-10  Sam Weinig  <sam@webkit.org>
2221
2222         Reviewed by Tim Hatcher.
2223
2224         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
2225         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
2226         is turned on)
2227
2228         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
2229
2230         Added test: http/tests/security/cross-frame-access-private-browsing.html
2231
2232         * DumpRenderTree/LayoutTestController.cpp:
2233         (setPrivateBrowsingEnabledCallback):
2234         (LayoutTestController::staticFunctions):
2235         * DumpRenderTree/LayoutTestController.h:
2236         * DumpRenderTree/mac/DumpRenderTree.mm:
2237         (runTest): Default to private browsing disabled.
2238         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2239         (LayoutTestController::setPrivateBrowsingEnabled):
2240         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2241         (LayoutTestController::setPrivateBrowsingEnabled):
2242
2243 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2244
2245         Reviewed by Adam.
2246
2247         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
2248         WebCore's!
2249
2250         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
2251         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
2252         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
2253         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
2254         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
2255         * Drosera/win/Drosera.cpp:
2256         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2257
2258 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
2259
2260         Reviewed by Sam.
2261
2262         - Use the new IWebFrame [local] function signature and get the shared
2263         server correctly.
2264
2265         * Drosera/win/DebuggerClient.cpp:
2266         (DebuggerClient::didFinishLoadForFrame):
2267         * Drosera/win/ServerConnection.cpp:
2268         (ServerConnection::attemptToCreateServerConnection):
2269
2270 2007-11-07  Dan Bernstein  <mitz@apple.com>
2271
2272         Reviewed by Darin Adler.
2273
2274         - add an option to run-webkit-tests to ignore pixel test failures where
2275           all pixels differ by no more than a specified threshold
2276
2277         * DumpRenderTree/mac/ImageDiff.m:
2278         (main):
2279         (compareImages):
2280         (computePercentageDifferent):
2281         * Scripts/run-webkit-tests:
2282
2283 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2284
2285         Reviewed by Lars.
2286
2287         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
2288
2289         * DumpRenderTree/qt/DumpRenderTree.cpp:
2290
2291 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2292
2293         Reviewed by Lars.
2294
2295         Reworked the QWebSettings API.
2296         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
2297
2298         * DumpRenderTree/qt/DumpRenderTree.cpp:
2299
2300 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2301
2302         Reviewed by Lars.
2303
2304         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
2305
2306         * DumpRenderTree/qt/jsobjects.cpp:
2307
2308 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2309
2310         Reviewed by Lars Knoll <lars@trolltech.com>.
2311
2312         Add a QWebPage::frameCreated() signal and fix DRT
2313         
2314         The removal of createFrame in QWebPage broke the re-implementation
2315         in DumpRenderTree. Instead emit a frameCreated() signal and
2316         connect to it in DumpRenderTree.
2317         
2318
2319         * DumpRenderTree/qt/DumpRenderTree.cpp:
2320         (WebCore::WebPage::WebPage):
2321         (WebCore::DumpRenderTree::dump):
2322         (WebCore::DumpRenderTree::connectFrame):
2323         * DumpRenderTree/qt/DumpRenderTree.h:
2324
2325 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2326
2327         Reviewed by Lars Knoll <lars@trolltech.com>.
2328
2329         Moved all the event handlers from QWebFrame into QWebPage.
2330         
2331         This cleans up the public API and allows us to remove the
2332         HackWebFrame hack in DumpRenderTree.
2333         
2334
2335         * DumpRenderTree/qt/jsobjects.cpp:
2336         (EventSender::mouseDown):
2337         (EventSender::mouseUp):
2338         (EventSender::mouseMoveTo):
2339
2340 2007-11-07  Simon Hausmann  <hausmann@kde.org>
2341
2342         Reviewed by Mark.
2343
2344         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
2345         to prevent the default implementation from popping up messageboxes.
2346
2347         * DumpRenderTree/qt/DumpRenderTree.cpp:
2348         (WebCore::WebPage::javaScriptConfirm):
2349         (WebCore::WebPage::javaScriptPrompt):
2350
2351 2007-11-06  Eric Seidel  <eric@webkit.org>
2352
2353         * Scripts/build-testkjs: build fix... too many $$
2354
2355 2007-11-06  Eric Seidel  <eric@webkit.org>
2356
2357         Reviewed by Mark Rowe.
2358
2359         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
2360
2361 2007-11-05  Adam Roben  <aroben@apple.com>
2362
2363         Add support on Windows for WEBKIT_TESTFONTS
2364
2365         This environment variable lets you specify where the fonts to be used
2366         by DumpRenderTree reside. The Qt port is already using this, so I'm
2367         just following their lead.
2368
2369         Reviewed by Darin.
2370
2371         * DumpRenderTree/win/DumpRenderTree.cpp:
2372         (exePath): Refactored code out of initialize().
2373         (fontsPath): Returns either $WEBKIT_TESTFONTS or
2374         DumpRenderTree.resources.
2375         (initialize): Use the new fontsPath function.
2376         (main): Use the new exePath function.
2377         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
2378         variable to DRT, like Qt does.
2379
2380 2007-11-05  Mark Rowe  <mrowe@apple.com>
2381
2382         Rubber-stamped by Alp Toker.
2383
2384         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
2385
2386         * GtkLauncher/main.cpp:
2387         (goToURLBarText):
2388         (main):
2389
2390 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
2391
2392         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
2393         <http://bugs.webkit.org/show_bug.cgi?id=15830>
2394
2395         Reviewed by Timothy.
2396
2397         Restrict the range of nightly builds used by the bisect-builds script
2398         based on the version of Safari and the version of Mac OS X being used.
2399
2400         Mac OS X 10.4: Safari 2.0: r11976 or newer
2401         Mac OS X 10.4: Safari 3.0: r19992 or newer
2402
2403         Mac OS X 10.5: Safari 2.0: r19594 or newer
2404         Mac OS X 10.5: Safari 3.0: r25124 or newer
2405
2406         * Scripts/bisect-builds:
2407         (findMacOSXVersion): Added.
2408         (makeNightlyList): Added argument to provide version of Mac OS X.
2409         Restrict range of nightly builds based on Safari and Mac OS X versions.
2410
2411 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
2412
2413         Reviewed by Maciej.
2414
2415         - This patch involves several changes, all of them were noticed that
2416         they were needed by the work being done in WebKit to get Drosera and
2417         WebKit working together on Windows.
2418         - The changes are:
2419         1) Added a debugger console for output messages.
2420         2) Drosera now listens for the WebKit server (before, the server would
2421         have to be running before Drosera was started.)
2422         3) Fixed a bug where the WebView started out as 0x0 pixels.
2423         4) Fixed a bug when there is no scope.
2424         5) Added the HTML, JS, and CSS to the project file to make them easy to
2425         find.
2426         6) Made the ServerConnection functions virtual.
2427
2428         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
2429         for the WebKit server.
2430         (DebuggerClient::DebuggerClient):
2431         (DebuggerClient::~DebuggerClient):
2432         (DebuggerClient::didFinishLoadForFrame):
2433         (DebuggerClient::serverConnected):
2434         (DebuggerClient::attemptToCreateServerConnection):
2435         * Drosera/win/DebuggerClient.h: Ditto.
2436         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
2437         scope.
2438         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2439         (DebuggerDocument::platformValueForScopeVariableNamed):
2440         * Drosera/win/Drosera.cpp:
2441         (_tWinMain): Added a console in debug for output messages.
2442         (Drosera::Drosera): Listen for server.
2443         (Drosera::initUI): The server now Initializes COM.
2444         (Drosera::serverConnected): Part of the listening for the server.
2445         (Drosera::attemptToCreateServerConnection): Ditto.
2446         * Drosera/win/Drosera.h: New interface for listening for the server.
2447         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
2448         files to the VS project.
2449         * Drosera/win/ServerConnection.cpp: Part of listening for the server
2450         connection.
2451         (ServerConnection::ServerConnection):
2452         (ServerConnection::attemptToCreateServerConnection):
2453         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
2454         methods.
2455         (ServerConnection::serverConnected):
2456
2457 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
2458
2459         Reviewed by Maciej.
2460
2461         http://bugs.webkit.org/show_bug.cgi?id=15832
2462         fast/dom/gc-10.html crashes when run alone
2463
2464         Check for !done before using objects that can be already deallocated.
2465
2466         * DumpRenderTree/mac/EditingDelegate.mm:
2467         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
2468         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
2469         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
2470         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
2471         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
2472         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
2473         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
2474         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
2475         (-[EditingDelegate webViewDidBeginEditing:]):
2476         (-[EditingDelegate webViewDidChange:]):
2477         (-[EditingDelegate webViewDidEndEditing:]):
2478         (-[EditingDelegate webViewDidChangeTypingStyle:]):
2479         (-[EditingDelegate webViewDidChangeSelection:]):
2480         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2481         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2482         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2483         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2484         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
2485         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
2486         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
2487         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
2488         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
2489         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
2490         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
2491         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
2492         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
2493         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
2494         (-[FrameLoadDelegate webView:willCloseFrame:]):
2495         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
2496         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
2497         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2498         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2499         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2500         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
2501         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
2502         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
2503         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
2504
2505 2007-11-04  Mark Rowe  <mrowe@apple.com>
2506
2507         Build fix.  Don't use Carbon.h as the prefix header as it triggers
2508         warnings that would otherwise be suppressed due to it being a system header.
2509
2510         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2511
2512 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
2513
2514         Rubber stamped by Adam.
2515         
2516         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
2517
2518         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2519
2520 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2521
2522         Sort files(...); sections of Xcode project files.
2523
2524         Rubber-stamped by Darin.
2525
2526         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
2527         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
2528         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2529         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2530
2531 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
2532
2533         Script to sort "files(...);" sections in Xcode project.pbxproj files.
2534
2535         Reviewed by Darin.
2536
2537         * Scripts/sort-Xcode-project-file: Added.
2538
2539 2007-11-02  Darin Adler  <darin@apple.com>
2540
2541         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
2542
2543 2007-11-02  Darin Adler  <darin@apple.com>
2544
2545         Reviewed by Maciej.
2546
2547         * Scripts/run-sunspider: Pass the "--base" option through.
2548
2549         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
2550         the real script do that. Default configuration to Release to match run-sunspider
2551         so we don't end up building Debug just to compare results.
2552
2553 2007-11-01  Adam Roben  <aroben@apple.com>
2554
2555         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
2556
2557         Reviewed by Sam.
2558
2559         * Scripts/commit-log-editor: Show all the directories beneath the
2560         source root, instead of just the last one.
2561
2562 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
2563
2564         Reviewed by Adam Roben.
2565
2566         Print out an error message when the Windows build fails
2567         and provide guidance on how to find out what went wrong.
2568
2569         * Scripts/build-webkit:
2570         * Scripts/webkitdirs.pm:
2571
2572 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
2573
2574         Rubber-stamped by Adam Roben.
2575
2576         Rolled out r27326 - debug CRT seems to cause no problems after all.
2577
2578         * DumpRenderTree/win/DumpRenderTree.vcproj:
2579
2580 2007-10-31  Adam Roben  <aroben@apple.com>
2581
2582         Switch the Debug configuration to using the non-debug CRT
2583
2584         This matches WebKit.
2585
2586         Reviewed by Steve.
2587
2588         * DumpRenderTree/win/DumpRenderTree.vcproj:
2589
2590 2007-10-31  Antti Koivisto  <antti@apple.com>
2591
2592         Reviewed by bdash.
2593         
2594         Disable media tests when doing leak checking on Tiger.
2595         They crash in QuickTime (rdar://problem/5537157).
2596
2597         * Scripts/run-webkit-tests:
2598
2599 2007-10-29  Antti Koivisto  <antti@apple.com>
2600
2601         Reviewed by Maciej.
2602         
2603         Build media support by default on OSX only.
2604
2605         * Scripts/build-webkit:
2606
2607 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2608
2609         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
2610         get caught by the pre-commit hooks.
2611
2612 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2613
2614         Reviewed by Adam.
2615
2616         - This is a collection of relatively unrelated changes and cleanups
2617         to Drosera to prepare it for interacting with WebKit.  A lot of these
2618         changes are just correcting mistakes, for example removing included
2619         headers that are no longer needed.
2620
2621         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
2622         this will be needed by the DebuggerClient.
2623         (DebuggerDocument::server):
2624         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
2625         * Drosera/win/DebuggerClient.cpp: 
2626         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
2627         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
2628         (DebuggerClient::createWebViewWithRequest): Added comment about its
2629         purpose. 
2630         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
2631         declarations.
2632         (DebuggerClient::webViewLoaded): Moved.
2633         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
2634         file, since this was the only place it was used.
2635         (cfStringToBSTR):
2636         * Drosera/win/Drosera.h: Cleaned up the includes.
2637         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
2638         * Drosera/win/HelperFunctions.h: Removed.
2639
2640 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2641
2642         Reviewed by Adam.
2643
2644         - Small cleanup in the ServerConnection class.
2645
2646         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
2647         and added an include.
2648         (ServerConnection::currentFrame):
2649         (ServerConnection::getCallerFrame):
2650         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
2651         made a pointer into a COMPtr, and cleaned up the includes.
2652
2653 2007-10-29  Timothy Hatcher  <timothy@apple.com>
2654
2655         Reviewed by John Sullivan.
2656         
2657         - Place the Localizable.strings file in mac or win directories
2658           if that location exists.
2659         - Also look for UI_STRING in .c files.
2660
2661         * Scripts/extract-localizable-strings:
2662
2663 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2664
2665         Reviewed by Adam.
2666
2667         - Set the eol-style to native and made all the line endings the same
2668         so that I avoid messy diffs that show eol changes.
2669
2670         * Drosera/win/ServerConnection.cpp:
2671         (ServerConnection::didParseSource):
2672         (ServerConnection::didEnterCallFrame):
2673         (ServerConnection::willExecuteStatement):
2674         (ServerConnection::willLeaveCallFrame):
2675         (ServerConnection::exceptionWasRaised):
2676
2677 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
2678
2679         Reviewed by Adam.
2680
2681         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
2682         functionality that could not have existed previously without the new
2683         interfaces.
2684         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
2685         from a BSTR to a JSValueRef.
2686         (DebuggerDocument::platformEvaluateScript): Implemented.
2687         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
2688         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2689         Implemented.
2690         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
2691         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
2692         * Drosera/win/ServerConnection.cpp: Added a helper function.
2693         (ServerConnection::getCallerFrame):
2694         * Drosera/win/ServerConnection.h: Added a helper function.
2695
2696 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2697
2698         updated reviewers for my previous changelog.
2699
2700 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
2701         Reviewed by Maciej and Adam and Geoff.
2702
2703         - Minor mac-side improvements including moving a function to a more
2704         appropriate location, fixing a warning, and correctly checking
2705         exceptions.
2706
2707         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
2708         (DebuggerDocument::willExecuteStatement):
2709         (DebuggerDocument::didEnterCallFrame):
2710         (DebuggerDocument::willLeaveCallFrame):
2711         (DebuggerDocument::windowScriptObjectAvailable):
2712         (DebuggerDocument::callFunctionOnObject):
2713         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
2714         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
2715         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
2716         because it doesn't require the ServerConnection at all.
2717         (NSStringCreateWithJSStringRef): Made an argument const.
2718         (JSValueRefCreateWithNSString): Made an argument const.
2719         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
2720         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2721         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
2722         * Drosera/mac/ServerConnection.mm: Ditto.
2723         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
2724
2725 2007-10-29  Sam Weinig  <sam@webkit.org>
2726
2727         Reviewed by Adam Roben.
2728
2729         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
2730
2731         * DumpRenderTree/LayoutTestController.cpp:
2732         (LayoutTestController::LayoutTestController):
2733         (getGlobalFlagCallback):
2734         (setGlobalFlagCallback):
2735         (LayoutTestController::getJSClass):
2736         (LayoutTestController::staticValues):
2737         * DumpRenderTree/LayoutTestController.h:
2738         (LayoutTestController::globalFlag):
2739         (LayoutTestController::setGlobalFlag):
2740
2741 2007-10-29  Darin Adler  <darin@apple.com>
2742
2743         Reviewed by Maciej.
2744
2745         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
2746         resolution instead of its default.
2747
2748 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
2749
2750         Fixed showStatus() to print status for successfully resolved conflicts when using git.
2751
2752         Reviewed by Mark Rowe.
2753
2754         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
2755         was successfully resolved, but this would not show any status because the change had
2756         already been cached in the index using "git add".  The solution is to add an optional
2757         second argument to showStatus() which adds the "--cached" switch to the command.
2758
2759         * Scripts/resolve-ChangeLogs:
2760         (showStatus):
2761
2762 2007-10-28  Eric Seidel  <eric@webkit.org>
2763
2764         Reviewed by Maciej and Geoff, in unison.
2765
2766         * Scripts/run-webkit-tests: remove broken --svg option
2767
2768 2007-10-28  Darin Adler  <darin@apple.com>
2769
2770         Reviewed by Adam.
2771
2772         * Scripts/run-sunspider: Default to "Release" configuration rather than
2773         defaulting to the last configuration used as other scripts do. This can
2774         still be overriden on the command line with "--debug" if there's some
2775         reason to do so. Also fix a typo.
2776
2777         * Scripts/sunspider-compare-results: Fix a typo.
2778
2779 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
2780
2781         Reviewed by Adam.
2782
2783         - Implemented the WebScriptDebugListener functions now that the
2784         WebScriptDebugServer exists
2785
2786         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
2787         functions.
2788         (ServerConnection::currentFrame):
2789         (ServerConnection::didLoadMainResourceForDataSource):
2790         (ServerConnection::didParseSource):
2791         (ServerConnection::failedToParseSource):
2792         (ServerConnection::didEnterCallFrame):
2793         (ServerConnection::willExecuteStatement):
2794         (ServerConnection::willLeaveCallFrame):
2795         (ServerConnection::exceptionWasRaised):
2796         * Drosera/win/ServerConnection.h: Removed unused arguments from the
2797         members arguments list.
2798
2799 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
2800
2801         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
2802         <http://bugs.webkit.org/show_bug.cgi?id=15600>
2803
2804         Reviewed by Darin.
2805
2806         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
2807         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
2808         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
2809         file.  Note that it may also be used as a stand-alone script.
2810
2811         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
2812         * Scripts/resolve-ChangeLogs: Added.
2813         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
2814
2815 2007-10-26  Mark Rowe  <mrowe@apple.com>
2816
2817         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
2818         to the Qt port on the assumption that it was an implementation of the cross-platform
2819         LayoutTestController class.  It is not, so it did not need to be changed.
2820
2821         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
2822
2823 2007-10-25  Mark Rowe  <mrowe@apple.com>
2824
2825         Reviewed by Maciej.
2826
2827         Fix builds with code coverage enabled.
2828
2829         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
2830
2831 2007-10-25  Darin Adler  <darin@apple.com>
2832
2833         Reviewed by Mark Rowe.
2834
2835         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
2836         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
2837
2838 2007-10-25  Stephanie  <slewis@apple.com>
2839
2840         build Fix
2841
2842         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2843
2844 2007-10-25  Stephanie  <slewis@apple.com>
2845
2846         Reviewed by Mark Rowe, Adam Roben.
2847
2848         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
2849
2850         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
2851
2852 2007-10-25  Alice Liu  <alice.liu@apple.com>
2853
2854         Reviewed by Adam.
2855
2856         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
2857
2858         Moving destructor into platform-specific files
2859         * DumpRenderTree/LayoutTestController.cpp:
2860         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2861         (LayoutTestController::~LayoutTestController):
2862         * DumpRenderTree/qt/jsobjects.cpp:
2863         (LayoutTestController::~LayoutTestController):
2864
2865         LayoutTestController wasn't being destroyed
2866         * DumpRenderTree/win/DumpRenderTree.cpp:
2867         (runTest):
2868
2869         Added declspec
2870         * DumpRenderTree/win/EditingDelegate.h:
2871
2872         Reset certain values on the webview (or related delegate) that might 
2873         have changed while running a test
2874         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2875         (LayoutTestController::~LayoutTestController):
2876
2877 2007-10-25  Adam Roben  <aroben@apple.com>
2878
2879         Make sunspider-compare-results work with relative paths
2880
2881         Reviewed by Sam.
2882
2883         * Scripts/sunspider-compare-results: Convert arguments to absolute
2884         paths before we chdir.
2885
2886 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
2887
2888         Reviewed by Sam.
2889
2890         - Implemented server calls now the WebScriptDebugServer exists.
2891         - Also removed no longer needed call to initialize CG.
2892
2893         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
2894         automatically now.
2895         (_tWinMain):
2896         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
2897         (ServerConnection::ServerConnection):
2898         (ServerConnection::~ServerConnection):
2899         (ServerConnection::pause):
2900         (ServerConnection::resume):
2901         (ServerConnection::stepInto):
2902         (ServerConnection::applicationTerminating):
2903         (ServerConnection::serverConnectionDidDie):
2904         * Drosera/win/ServerConnection.h: Now uses the COM class.
2905
2906 2007-10-24  George Staikos  <staikos@kde.org>
2907
2908         Unbreak Qt build.
2909
2910         * Scripts/build-webkit:
2911
2912 2007-10-24  Adam Roben  <aroben@apple.com>
2913
2914         Remove now-unnecessary call to InitializeCoreGraphics
2915
2916         WebKit takes care of this now.
2917
2918         Reviewed by Ada.
2919
2920         * DumpRenderTree/win/DumpRenderTree.cpp:
2921         (initialize):
2922
2923 2007-10-24  Adam Roben  <aroben@apple.com>
2924
2925         Use WebTextRenderer in DRT
2926
2927         Reviewed by Ada.
2928
2929         * DumpRenderTree/win/DumpRenderTree.cpp:
2930         (initialize): Use WebTextRenderer instead of using AddFontResourceEx.
2931
2932 2007-10-24  Sven Herzberg  <sven@imendio.com>
2933
2934         Reviewed by Mark Rowe.
2935
2936         Fixes http://bugs.webkit.org/show_bug.cgi?id=15614
2937         Bug 15614: [GTK] qmake based backends don't build on OS X
2938
2939         * Scripts/build-webkit: set QMAKESPEC correctly if building the QT or
2940         GTK backend on a Mac
2941         * Scripts/webkitdirs.pm: extracted the darwin-test from isOSX() into
2942         isDarwin() to make it reusable in other places (like the workaround-
2943         for-prebuilt-qmake in build-webkit)
2944
2945 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2946
2947         Refurbish update-webkit script.
2948
2949         Reviewed by Adam.
2950
2951         * Scripts/update-webkit: Add -h|--help switch and usage statement.  Check result of
2952         GetOptions() call.  Fix -q|--quiet switch to be passed to svn command properly.  Use
2953         multi-argument version of system() for flexibility and security.  Check for existence
2954         of Internal directory using -d test instead of -x.
2955
2956 2007-10-24  David Kilzer  <ddkilzer@webkit.org>
2957
2958         Minor clean-up of prepare-ChangeLog script.
2959
2960         Reviewed by Adam.
2961
2962         * Scripts/prepare-ChangeLog: Keep list of updated ChangeLog files in an array instead
2963         of a string.  Use multi-argument versions of open() and system() for flexibility and
2964         security.
2965
2966 2007-10-24  Alice Liu  <alice.liu@apple.com>
2967
2968         Reviewed by Oliver.
2969
2970         Fix <rdar://5410959>  editing/selection/drag-to-contenteditable-iframe.html fails on Windows
2971
2972         Move the call to replaySavedEvents from doDragDrop to doMouseMove because we don't want to 
2973         replay the saved events when we're still processing the mousedown that starts the drag
2974         * DumpRenderTree/win/EventSender.cpp:
2975         (doMouseMove):
2976         * DumpRenderTree/win/UIDelegate.cpp:
2977         (UIDelegate::doDragDrop):
2978
2979 2007-10-24  Kevin McCullough  <kmccullough@apple.com>
2980
2981         Reviewed by Sam, Steve and Darin.
2982
2983         - Stubbed out the WebScriptDebugListener functionality in the Server
2984         Connection class to prepare it for receiving those callbacks.
2985         - Also I changed the instantiation of DebuggerClient, DebuggerDocument
2986         and the ServerConnection to not need to be initialized with a server
2987         name, since that is not the way we connect to the WebKit server. 
2988
2989         * Drosera/DebuggerDocument.cpp: Fixed a bug where I was always logging
2990         no exception.  Now it only loggs when there is an exception
2991         (DebuggerDocument::willExecuteStatement):
2992         (DebuggerDocument::didEnterCallFrame):
2993         (DebuggerDocument::willLeaveCallFrame):
2994         (DebuggerDocument::windowScriptObjectAvailable):
2995         (DebuggerDocument::callFunctionOnObject):
2996         * Drosera/win/DebuggerClient.cpp: No longer needs the ServerConnection
2997         to be instantiated with a server's name.
2998         (DebuggerClient::DebuggerClient):
2999         (DebuggerClient::didFinishLoadForFrame):
3000         * Drosera/win/DebuggerClient.h: Removed unsued variable.
3001         * Drosera/win/Drosera.cpp: Client no longer needs to be initialized with
3002         a server name.
3003         (Drosera::init):
3004         (Drosera::initServer):
3005         * Drosera/win/Drosera.h: No longer need the ServerConnection to be
3006         instantiated with a server's name.
3007         * Drosera/win/ServerConnection.cpp: 
3008         (ServerConnection::ServerConnection): No longer needs a server name
3009         (ServerConnection::~ServerConnection): Only release the global context
3010         if there is one.
3011         (ServerConnection::serverConnectionDidDie): Stub for
3012         IWebScriptDebugListener
3013         (ServerConnection::QueryInterface): ditto
3014         (ServerConnection::AddRef): ditto
3015         (ServerConnection::Release): ditto
3016         (ServerConnection::didLoadMainResourceForDataSource): ditto
3017         (ServerConnection::didParseSource): ditto
3018         (ServerConnection::failedToParseSource): ditto
3019         (ServerConnection::didEnterCallFrame): ditto
3020         (ServerConnection::willExecuteStatement): ditto
3021         (ServerConnection::willLeaveCallFrame): ditto
3022         (ServerConnection::exceptionWasRaised): ditto
3023         * Drosera/win/ServerConnection.h: Stubbed out the
3024         IWebScriptDebugListener functions, and this class no longer needs to be
3025         instantiated with a server name.
3026
3027 2007-10-24  Lars Knoll  <lars@trolltech.com>
3028
3029         Reviewed by Simon.
3030
3031         add a layoutTestController.dumpSelectionRect() dummy. It only has an effect on mac pixel tests anyway. Makes us pass another 5 test cases.
3032
3033         * DumpRenderTree/qt/jsobjects.h:
3034
3035 2007-10-24  Lars Knoll  <lars@trolltech.com>
3036
3037         Reviewed by Simon.
3038
3039         add another command.
3040
3041         * DumpRenderTree/qt/jsobjects.cpp:
3042         (TextInputController::doCommand):
3043
3044 2007-10-24  Lars Knoll  <lars@trolltech.com>
3045
3046         Reviewed by Simon.
3047
3048         add empty eventSender.clearKillRing(), and map some of the special keys used in eventSender.keyDown() to things that work on Qt/X11.
3049
3050         * DumpRenderTree/qt/jsobjects.cpp:
3051         (EventSender::keyDown):
3052         * DumpRenderTree/qt/jsobjects.h:
3053
3054 2007-10-24  Lars Knoll  <lars@trolltech.com>
3055
3056         Reviewed by Simon.
3057
3058         implement eventSender.keyDown().
3059
3060         * DumpRenderTree/qt/jsobjects.cpp:
3061         (EventSender::keyDown):
3062
3063 2007-10-24  Lars Knoll  <lars@trolltech.com>
3064
3065         Reviewed by Simon.
3066
3067         some smaller fixes to the editing support in DRT. Makes another few tests pass.
3068
3069         * DumpRenderTree/qt/DumpRenderTree.cpp:
3070         (WebCore::DumpRenderTree::DumpRenderTree):
3071         (WebCore::DumpRenderTree::initJSObjects):
3072         * DumpRenderTree/qt/jsobjects.cpp:
3073         (TextInputController::doCommand):
3074
3075 2007-10-24  Lars Knoll  <lars@trolltech.com>
3076
3077         Reviewed by Simon.
3078
3079         first bit of implementation for the textinputcontroller.
3080
3081         * DumpRenderTree/qt/DumpRenderTree.cpp:
3082         (WebCore::DumpRenderTree::DumpRenderTree):
3083         * DumpRenderTree/qt/DumpRenderTree.h:
3084         * DumpRenderTree/qt/jsobjects.cpp:
3085         (TextInputController::TextInputController):
3086         (TextInputController::doCommand):
3087         * DumpRenderTree/qt/jsobjects.h:
3088
3089 2007-10-24  Lars Knoll  <lars@trolltech.com>
3090
3091         Reviewed by Simon.
3092
3093         make the man webpage believe it has focus, so the editing tests work correctly.
3094
3095         * DumpRenderTree/qt/DumpRenderTree.cpp:
3096         (WebCore::DumpRenderTree::DumpRenderTree):
3097
3098 2007-10-24  Lars Knoll  <lars@trolltech.com>
3099
3100         Reviewed by Simon.
3101
3102         implement layoutTestController.dumpEditingCallbacks() correctly.
3103
3104         * DumpRenderTree/qt/DumpRenderTree.cpp:
3105         (WebCore::DumpRenderTree::DumpRenderTree):
3106         * DumpRenderTree/qt/jsobjects.cpp:
3107         (LayoutTestController::reset):
3108         (LayoutTestController::dumpEditingCallbacks):
3109
3110 2007-10-24  Lars Knoll  <lars@trolltech.com>
3111
3112         Reviewed by Simon.
3113
3114         Implement support for testing editing.
3115
3116         * DumpRenderTree/qt/DumpRenderTree.cpp:
3117         (WebCore::DumpRenderTree::DumpRenderTree):
3118
3119 2007-10-23  Sam Weinig  <sam@webkit.org>
3120
3121         Check for null BSTR that can be passed to the UIDelegate methods
3122         from javascript null and undefined.  Fixes a failing test case on
3123         Windows (fast/dom/Window/alert-undefined.html)
3124
3125         Reviewed by Eric Seidel.
3126
3127         * DumpRenderTree/win/UIDelegate.cpp:
3128         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3129         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3130         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3131         (UIDelegate::webViewAddMessageToConsole):
3132
3133 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3134
3135         Reviewed by Darin.
3136         
3137         Don't print a massive pile of setenvs from tools that automatically build testkjs.
3138
3139         * Scripts/build-testkjs:
3140
3141 2007-10-23  Maciej Stachowiak  <mjs@apple.com>
3142
3143         Reviewed by Darin.
3144
3145         - add wrapper that finds the right copy of testkjs
3146         
3147         * Scripts/sunspider-compare-results: Added.
3148
3149 2007-10-23  Kevin McCullough  <kmccullough@apple.com>
3150
3151         Reviewed by Sam.
3152
3153         - After talking with Steve I now see that the WebKit server must be
3154         running for DCOM to create the distributed objects, which makes sense
3155         and currently WebKit only allows one instance to be running at a time
3156         which avoids accidentally connecting to the wrong server
3157         - In light of this I have removed the code for the attach box and
3158         NotificationServer and known server names, since they are all extranious
3159         now.
3160
3161         * Drosera/win/Drosera.cpp: Removed notification classes and known server
3162         names.
3163         (_tWinMain): Uses init instead of initUI.
3164         (droseraWndProc): No longer creats an attach dialog box.
3165         (Drosera::Drosera): Does the OleInitialize so COM is ready to go and
3166         it's not manditory to call init before doing COM stuff.
3167         (Drosera::init): calls initUI and will call attach when the
3168         functionality exists. 
3169         (Drosera::initUI): Has changed very little.
3170         (Drosera::attach): Changed the signature to reflect that we no longer
3171         need the dictionary of known server names.
3172         * Drosera/win/Drosera.h: Removed notification classes and known server
3173         names.  Also renamed and moved some functions.
3174         * Drosera/win/Drosera.vcproj/Drosera.rc: Removed the Attach box.
3175         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Moved resource.h from the
3176         headers to the resources folder. 
3177         * Drosera/win/resource.h: Removed the Attach box.
3178
3179 2007-10-22  Adam Roben  <aroben@apple.com>
3180
3181         Windows build fix
3182
3183         * Scripts/build-dumprendertree: Fix path to DumpRenderTree.sln.
3184
3185 2007-10-22  Kevin McCullough  <kmccullough@apple.com>
3186
3187         - Removed a leak that was fixed.
3188
3189         * Scripts/run-webkit-tests:
3190
3191 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3192
3193         Reviewed by Darin.
3194
3195         - Changed the Client so that the DebuggerDocument now own the
3196         ServerConnection.  This simplifies ownership and cleanup. 
3197
3198         * Drosera/win/DebuggerClient.cpp: The DebuggerDocument now owns the
3199         ServerConnection.
3200         (DebuggerClient::initWithServerName):
3201         (DebuggerClient::didFinishLoadForFrame):
3202         * Drosera/win/DebuggerClient.h: DebuggerDocument now owns the 
3203         ServerConnection.
3204         * Drosera/win/Drosera.cpp: Moved some WebFrame initialization logic to
3205         until after we have a server which we are attached to.
3206         (Drosera::initUI):
3207         (Drosera::attach):
3208         * Drosera/win/Drosera.h: Removed two needless pointers I forgot to take
3209         out previously.
3210
3211 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3212
3213         Reviewed by Nikolas.
3214
3215         When running build-testkjs make sure it's called through the perl interpreter, to fix the build for Qt/Windows.
3216
3217         * Scripts/run-javascriptcore-tests:
3218
3219 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3220
3221         Reviewed by Nikolas.
3222
3223         Wrap WEXITSTATUS with a little exitStatus() helper function that falls back to the use of $returnvalue >> 8 on Windows to determine the exit status on platforms without WEXITSTATUS.
3224
3225         * Scripts/build-drosera:
3226         * Scripts/build-dumprendertree:
3227         * Scripts/build-testkjs:
3228         * Scripts/build-webkit:
3229         * Scripts/run-javascriptcore-tests:
3230         * Scripts/run-sunspider:
3231         * Scripts/run-webkit-tests:
3232         * Scripts/webkitdirs.pm:
3233
3234 2007-10-22  Andrew Wellington  <proton@wiretapped.net>
3235
3236         Reviewed by Mark Rowe.
3237         
3238         Fix for local database support after r26879
3239         Ensure that ENABLE_DATABASE and ENABLE_ICONDATABASE are correctly set
3240
3241         * Scripts/build-webkit:
3242
3243 2007-10-22  Holger Freyther  <zecke@selfish.org>
3244
3245         Reviewed by Simon Hausmann <hausmann@kde.org>.
3246
3247         - Do not build testkjs as an application bundle. This is
3248         needed for run-javascriptcore-tests on OSX.
3249         - Also, based on r26633, allow to test the WebKit/Qt port on OSX.
3250         - Set DYLD_LIBRARY_PATH if it was set in the environment. It must be set
3251         as we do not have -rpath on OSX.
3252
3253         * DumpRenderTree/qt/DumpRenderTree.pro:
3254         * Scripts/run-webkit-tests:
3255
3256 2007-10-22  Simon Hausmann  <hausmann@kde.org>
3257
3258         Reviewed by aroben.
3259
3260         Fix support for Signed-off-by detection in prepare-ChangeLog
3261         --git-commit. The Signed-off-by tag does not appear in the header
3262         but usually at the end.
3263
3264         * Scripts/prepare-ChangeLog:
3265
3266 2007-10-21  Mark Rowe  <mrowe@apple.com>
3267
3268         Reviewed by Eric.
3269
3270         Fix run-javascriptcore-tests for Gtk.
3271
3272         * Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
3273
3274 2007-10-20  Eric Seidel  <eric@webkit.org>
3275
3276         Reviewed by aroben.
3277
3278         * Scripts/find-extra-includes: fix path matching regex to not match ".patch"
3279
3280 2007-10-20  Eric Seidel  <eric@webkit.org>
3281
3282         Reviewed by darin.
3283         
3284         Add improved argument handling to run-sunspider, including
3285         --runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
3286         Also re-factor code into subroutines
3287
3288         * Scripts/build-dumprendertree: removed bogus comments
3289         * Scripts/build-testkjs: Added.
3290         * Scripts/run-javascriptcore-tests: use build-testkjs
3291         * Scripts/run-sunspider: improved argument handling, abstraction
3292         * Scripts/run-webkit-tests: improved abstraction
3293
3294 2007-10-20  Matt Lilek  <webkit@mattlilek.com>
3295
3296         Not reviewed, Windows build fix.
3297
3298         * DumpRenderTree/win/EventSender.cpp:
3299         (keyDownCallback):
3300
3301 2007-10-20  Darin Adler  <darin@apple.com>
3302
3303         Reviewed by Tim Hatcher.
3304
3305         - http://bugs.webkit.org/show_bug.cgi?id=15544
3306           <rdar://problem/5076426> fast/events/arrow-navigation.html needs to
3307           not rely on Apple-specific key codes
3308
3309         * DumpRenderTree/mac/EventSendingController.mm:
3310         (-[EventSendingController keyDown:withModifiers:]):
3311         Added named key "rightArrow". Later we could have a whole table of these.
3312         Also tweaked modifiers code a little.
3313
3314         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.
3315
3316 2007-10-19  Darin Adler  <darin@apple.com>
3317
3318         Reviewed by Eric.
3319
3320         - http://bugs.webkit.org/show_bug.cgi?id=15566
3321           possible fix for leak seen in DumpRenderTree
3322
3323         * DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue):
3324         Delete the item if it's not put on the queue, since the caller has
3325         no way of knowing that. Would be better to have the parameter type
3326         be auto_ptr to express the fact that we take ownership.
3327
3328         - unrelated change
3329
3330         * Drosera/mac/main.m: Add missing include.
3331
3332 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3333
3334         Reviewed by Adam.
3335
3336         - This change should be identical but for some reason was not working
3337         on my machine.
3338
3339         * Scripts/prepare-ChangeLog:
3340
3341 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3342
3343         Reviewed by Oliver and Tim.
3344
3345         - Made use of RetainPtr to avoid retain and release issues and moved the
3346         log function to DebuggerDocumentPlatform, which seems to be a more
3347         logical place for it to live.
3348         - Also moved knownServers from the ServerConnection to
3349         DebuggerApplication to match the Windows code and because it makes sense
3350         that a connection knows its own server but not all of them.
3351
3352         * Drosera/mac/DebuggerClient.h: Moved the log function to
3353           DebuggerDocumentPlatform.
3354         * Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server
3355           Because it's owned by an own Ptr in DebuggerDocument.  Also moved the
3356           call for the server name up from the ServerConnection class.
3357         (-[DebuggerClient dealloc]):
3358         (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call
3359           for the server name up from the ServerConnection.
3360         * Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr.
3361         (DebuggerDocument::platformPause):
3362         (DebuggerDocument::platformResume):
3363         (DebuggerDocument::platformStepInto):
3364         (DebuggerDocument::platformEvaluateScript):
3365         (DebuggerDocument::getPlatformCurrentFunctionStack):
3366         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3367         (DebuggerDocument::platformValueForScopeVariableNamed):
3368         (DebuggerDocument::platformLog): Log directly from here. No need to call
3369           DebuggerClient.
3370         * Drosera/mac/ServerConnection.h: Removed the knownServers function. The
3371           way I see it, a ServerConnection should only know about its connection
3372           and the group of all possible servers should be kept by the
3373           application.
3374         * Drosera/mac/ServerConnection.mm: Removed knownServer but added
3375           currentServerName, it makes sense that the connection should know that
3376           name.
3377         (-[ServerConnection currentServerName]):
3378
3379 2007-10-19  Kevin McCullough  <kmccullough@apple.com>
3380
3381         Reviewed by Adam.
3382
3383         - Integrated changes from mac drosera.  Recently I've encapsulated
3384         out the server connection object from the rest of Drosera because
3385         it is very platform dependent right now and RPC is not implemented on
3386         windows.  This functionality, of communicating with the WebKit server
3387         is the next area I will be focusing on in Windows.
3388
3389         - Other changes and cleanup were made to organize the code and add notes
3390         on which parts still need work.  Also some mac code is added and
3391         commented out, to act as pseudocode for the logic of those parts.
3392
3393         * Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart
3394           pointer.
3395         * Drosera/config.h: Added whitespace.
3396         * Drosera/win/DebuggerApplication.cpp: Removed. The functionality of
3397           these files got moved into Drosera.h/cpp
3398         * Drosera/win/DebuggerApplication.h: Removed.
3399         * Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring 
3400           happened here to better match the logic flow of the same code on the 
3401           mac side and to use the new ServerConnection class.
3402         (DebuggerClient::DebuggerClient): Constructor that takes a server name.
3403         (DebuggerClient::initWithServerName): Initializer that will set up the
3404           class to use a ServerConnection object.  This was necessary so I could
3405           create a DebuggerClient without having to initilaize it at
3406           construction.
3407         (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client
3408           will be the UIDelegate and FrameLoadDelegate.
3409         (DebuggerClient::AddRef): For IUnknown.
3410         (DebuggerClient::Release): For IUnknown.
3411         (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate
3412           this still needs to set the global context of the server, but
3413           IWebFrame does not have an accessor for the global context yet. 
3414         (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate
3415           this is a pass through for the same function in the document.
3416         (DebuggerClient::didReceiveTitle): Unimplemented part of
3417           FrameLoadDelegate this would change the title of the window.
3418         (DebuggerClient::createWebViewWithRequest): Part of the
3419           FrameLoadDelegate.  This is about new windows via Window.open() and
3420           how their delegates are set.
3421         (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the
3422           UIDelegate.  Just a debug function for printing messages.
3423         * Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h
3424           because the Client should be the UIDelegate and FrameLoadDelegate
3425           to match the delegates on mac.
3426         (DebuggerClient::webViewLoaded): Added accessor method.
3427         * Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently
3428           forgotten to add this file before.  This is where the platform
3429           dependent versions of the Documents functions live. Most of these are
3430           unimplemented because some piece of functionality does not exist on
3431           Windows yet.
3432         (DebuggerDocument::platformPause):
3433         (DebuggerDocument::platformResume):
3434         (DebuggerDocument::platformStepInto):
3435         (DebuggerDocument::platformEvaluateScript):
3436         (DebuggerDocument::getPlatformCurrentFunctionStack):
3437         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3438         (DebuggerDocument::platformValueForScopeVariableNamed):
3439         (DebuggerDocument::platformLog):
3440         * Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate
3441           responsibilities becaue they belong in the Client. Also I laid the
3442           groundwork for attaching Drosera to a WebKit process
3443         (attachWndProc): Now if a server is selected the Client becomes it's
3444           delegate.
3445         (Drosera::Drosera): Added the construction of the Client and dictionary
3446           of server names. 
3447         (Drosera::initUI): This is no longer the delegates, the Client is.
3448         (Drosera::webViewLoaded): Now asks the Client instead of holding local
3449           state. 
3450         (Drosera::applicationDidFinishLaunching): Placeholder for needed
3451           notification registration when it's possible to implement.
3452         (Drosera::serverLoaded): Ditto
3453         (Drosera::serverUnloaded): Ditto
3454         (Drosera::attach): Attach Drosera to the WebKit server.
3455         * Drosera/win/Drosera.h: Ditto for Drosera.cpp comment.
3456         (Drosera::getInst): 
3457         (Drosera::setInst):
3458         (Drosera::knownServers):
3459         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication
3460           and added the ServerConnection.
3461         * Drosera/win/DroseraPrefix.h: Added an ifndef check.
3462         * Drosera/win/ServerConnection.cpp: Added. This is the interesting part
3463           Most of the functions are completely unimlemented because they cannot
3464           connect with the WebKit server, because one does not exist on Windows
3465           yet.
3466         (ServerConnection::initWithServerName): 
3467         (ServerConnection::~ServerConnection):
3468         (ServerConnection::setGlobalContext):
3469         (ServerConnection::pause):
3470         (ServerConnection::resume):
3471         (ServerConnection::stepInto):
3472         (ServerConnection::switchToServerNamed):
3473         (ServerConnection::applicationTerminating):
3474         (ServerConnection::serverConnectionDidDie):
3475         (ServerConnection::currentFrame):
3476         * Drosera/win/ServerConnection.h: Added. Ditto.
3477         (ServerConnection::ServerConnection):
3478
3479 2007-10-19  Alice Liu  <alice.liu@apple.com>
3480
3481         Reviewed by Darin.
3482
3483         Fix for these broken layout tests on Windows:
3484         
3485         fast/forms/focus-selection-input.html
3486         fast/forms/focus-selection-textarea.html
3487         fast/forms/select-accesskey.html
3488         
3489         * DumpRenderTree/win/EventSender.cpp:
3490         (keyDownCallback):
3491         correct the VK code for alt key.
3492         
3493 2007-10-19  Eric Seidel  <eric@webkit.org>
3494
3495         Reviewed by Mark Rowe.
3496         
3497         Make the GtkLauncher code slightly more readable.
3498
3499         * GtkLauncher/main.cpp:
3500         (setupMainMenu): Added.
3501         (setupMainWindowUI): Added.
3502         (main):
3503
3504 2007-10-19  Maciej Stachowiak  <mjs@apple.com>
3505
3506         Rubber stamped by Adam.
3507         
3508         - don't delay-load WebKit in DumpRenderTree.
3509
3510         * DumpRenderTree/win/DumpRenderTree.vcproj:
3511
3512 2007-10-18  Dan Bernstein  <mitz@apple.com>
3513
3514         Reviewed by Adam Roben.
3515
3516         - fix <rdar://problem/5313523>
3517         REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
3518
3519         * DumpRenderTree/mac/DumpRenderTree.mm:
3520         (dump): Changed to use _responseMIMEType.
3521
3522 2007-10-17  Adam Roben  <aroben@apple.com>
3523
3524         Make it possible to have Windows-specific tests and results
3525
3526         When searching for tests to run and the Skipped file, we will only
3527         look in platform/win and the cross-platform directory. When looking
3528         for expected results, we will look in platform/win, then
3529         platform/mac-leopard, then platform/mac, then finally the
3530         cross-platform directory.
3531
3532         Reviewed by Sam.
3533
3534         * Scripts/run-webkit-tests:
3535         (sub expectedDirectoryForTest): Search in mac-leopard and mac before
3536         searching in the cross-platform directory.
3537         (sub buildPlatformHierarchy): Removed some unneeded calls to
3538         dirname/basename.
3539
3540 2007-10-17  Adam Roben  <aroben@apple.com>
3541
3542         Add back the call to register WebKit that we had before WebKitInitializer existed
3543
3544         This is needed to ensure that the right WebKit is used when
3545         instantiating COM objects.
3546
3547         Reviewed by Oliver.
3548
3549         * DumpRenderTree/win/debug_internal.vsprops: Define
3550         DEBUG_WEBKIT_HAS_SUFFIX.
3551         * DumpRenderTree/win/DumpRenderTree.cpp:
3552         (initialize):
3553
3554 2007-10-17  Adam Roben  <aroben@apple.com>
3555
3556         Import File::Basename in webkitdirs since we use it
3557
3558         * Scripts/webkitdirs.pm:
3559
3560 2007-10-17  Kevin McCullough  <kmccullough@apple.com>
3561
3562         - Updated the tiger leaks list to make the internal bots green.
3563
3564         * Scripts/run-webkit-tests:
3565
3566 2007-10-17  Adam Roben  <aroben@apple.com>
3567
3568         Build fix for VC++ Express
3569
3570         * FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib
3571         and ole32.lib.
3572
3573 2007-10-16  Kevin McCullough  <kmccullough@apple.com>
3574
3575         Reviewed by Sam.
3576
3577         - Minor mac improvements based on observations I made while implementing the
3578         Windows code.
3579
3580         * Drosera/mac/DebuggerApplication.mm: Attach does not need to create the server
3581         then hand it to the Client who will retain it, it should just be the client who
3582         creates and owns the server.
3583         (-[DebuggerApplication attach:]):
3584         * Drosera/mac/DebuggerClient.h: Can now be created with just a server name.
3585         * Drosera/mac/DebuggerClient.mm: Creates the server.
3586         (-[DebuggerClient initWithServerName:]):
3587         * Drosera/mac/ServerConnection.mm: Does not need to include 2 header files, but
3588         can instead forward declare what it needs.
3589
3590 2007-10-16  Darin Adler  <darin@apple.com>
3591
3592         Reviewed by Geoff Garen.
3593
3594         * Scripts/run-webkit-tests: Added --add-platform-exceptions; useful when you
3595         want to turn failing tests into platform-specific test results. Also did a
3596         number of tweaks, including fixing a potential bug where expectedDirectoryForTest
3597         would take the type of results into account only some of the time.
3598
3599 2007-10-16  Adam Roben  <aroben@apple.com>
3600
3601         Add a new nightly launcher script for Windows
3602
3603         This new script is for versions of Safari that don't delay-load
3604         WebKit. I had to make FindSafari be able to print out the nightly
3605         launcher script on stdout because Windows shell scripts can't capture
3606         the output from a command into an environment variable.
3607
3608         Reviewed by Steve.
3609
3610         * FindSafari/FindSafari.cpp:
3611         (_tmain): Added /printSafariLauncher option.
3612         * Scripts/run-webkit-nightly.cmd: Added.
3613
3614 2007-10-16  Adam Roben  <aroben@apple.com>
3615
3616         Replace WebKitInitializer with FindSafari
3617
3618         We now rely on setting the PATH environment variable to tell Windows
3619         where to find WebKit and its dependencies (similar to
3620         DYLD_FRAMEWORK_PATH on Mac).
3621
3622         This change also make DumpRenderTree no longer delay-load WebKit.
3623
3624         Reviewed by Sam.
3625
3626         * DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added
3627         FindSafari.
3628         * DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
3629         * DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against
3630         WebKitInitializer, don't delay-load WebKit.
3631         * Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
3632         * Scripts/run-webkit-tests: Ditto.
3633         * Scripts/webkitdirs.pm:
3634         (sub setPathForRunningWebKitApp): Added.
3635         * WebKitInitializer/WebKitInitializer.cpp: Removed.
3636         * WebKitInitializer/WebKitInitializer.h: Removed.
3637         * WebKitInitializer/WebKitInitializer.vcproj: Removed.