3aa747041b0fd0032c111ca4adbeb0ccadd65a1c
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-04-25  Alexey Proskuryakov  <ap@webkit.org>
2
3         Reviewed by Darin.
4
5         Fix run-webkit-tests --threading
6         and provisionally fix <https://bugs.webkit.org/show_bug.cgi?id=18661>
7         Proxy server issue in Sunday's Nightly
8
9         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
10         (runJavaScriptThread):
11         (startJavaScriptThreads):
12         (stopJavaScriptThreads):
13         Spawned threads were immediately detached, unlike the original ones, so joining them
14         made no sense. Now, all threads are created detached, and stopJavaScriptThreads() just
15         waits for them all to exit.
16
17 2008-04-28  Holger Hans Peter Freyther  <zecke@selfish.org>
18
19         Reviewed by Simon.
20
21         Reset dumping resource load callbacks to false for the next test
22         
23
24         * DumpRenderTree/qt/jsobjects.cpp:
25         (LayoutTestController::reset):
26
27 2008-04-28  Tor Arne Vestbø  <tavestbo@trolltech.com>
28
29         Reviewed by Simon.
30
31         Adapt to the latest API changes in WebKit/qt/Api.
32
33         * DumpRenderTree/qt/DumpRenderTree.cpp:
34         (WebCore::DumpRenderTree::DumpRenderTree):
35         * DumpRenderTree/qt/jsobjects.cpp:
36
37 2008-04-26  Robin Dunn  <robin@alldunn.com>
38
39         Reviewed by Kevin Ollivier.
40         
41         Delete the DerivedSources after make clean has been done so that the DerivedSources
42         don't get re-created. Also, use the proper extension for the Win wxPython extension.
43         
44         https://bugs.webkit.org/show_bug.cgi?id=18756
45
46         * wx/build-wxwebkit:
47
48 2008-04-26  Adam Barth <hk9565@gmail.com>
49
50         Reviewed by Adam Roben and Sam Weinig.
51
52         Updates LayoutTestController to use host instead of domain.
53
54         Collin Jackson <collinj-webkit@collinjackson.com> also contributed to this patch.
55
56         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
57         (LayoutTestController::setDatabaseQuota):
58         * DumpRenderTree/mac/UIDelegate.mm:
59         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
60
61 2008-04-26  Kevin Ollivier  <kevino@theolliviers.com>
62
63         wx build fix. Need the latest libpng. (Somehow my initial test passed without it.)
64
65         * wx/install-unix-extras:
66
67 2008-04-26  Robin Dunn  <robin@alldunn.com>
68
69         Reviewed by Kevin Ollivier.
70         
71         Allow the user to set the path to SWIG using an environment variable.
72         
73         https://bugs.webkit.org/show_bug.cgi?id=18660
74
75         * wx/build-wxwebkit:
76
77 2008-04-26  Kevin Ollivier  <kevino@theolliviers.com>
78
79         wx build fix. Download the latest libpng version for building the
80         dependencies.
81
82         * wx/install-unix-extras:
83
84 2008-04-25  Holger Hans Peter Freyther  <zecke@selfish.org>
85
86         Reviewed by Simon.
87
88         Implement dumping of resource load callbacks to pass http/tests/xmlhttprequest/abort-should-cancel-load.html
89         
90         Similar to Editing and Frameloading we do the dumping within WebCore
91         
92
93         * DumpRenderTree/qt/jsobjects.cpp:
94         (LayoutTestController::dumpResourceLoadCallbacks):
95         * DumpRenderTree/qt/jsobjects.h:
96
97 2008-04-24  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
98
99         Reviewed by Maciej Stachowiak.
100
101         http://bugs.webkit.org/show_bug.cgi?id=18485
102         Typo and documentation fix for build-webkit
103
104         * Scripts/build-webkit:
105
106 2008-04-24  Anders Carlsson  <andersca@apple.com>
107
108         Reviewed by Sam.
109
110         Don't call fprintf from the signal handler.
111         
112         * DumpRenderTree/mac/DumpRenderTree.mm:
113         (crashHandler):
114
115 2008-04-23  Adam Roben  <aroben@apple.com>
116
117         Make crashes be reported as crashes, not hangs
118
119         Reviewed by David Kilzer.
120
121         * Scripts/run-webkit-tests:
122         (top level): Use the new status field of the output from
123         readFromDumpToolWithTimer to determine if the test crashed or hung.
124         (sub readFromDumpToolWithTimer):
125           - If we fail to read a line and $! is not EAGAIN, then we've crashed
126             and should not try to read any more.
127           - Changed the timedout field to a more general status field.
128
129 2008-04-22  David Kilzer  <ddkilzer@apple.com>
130
131         Bug 18683: update-webkit returns 0 even if it fails
132
133         <https://bugs.webkit.org/show_bug.cgi?id=18683>
134
135         Reviewed by Mitz Pettel.
136
137         * Scripts/update-webkit:
138         (runSvnUpdate): Die if close() fails.
139
140 2008-04-21  Adam Roben  <aroben@apple.com>
141
142         Flush stdout/stderr after printing every #EOF separator
143
144         This fixes a hang when running the pixel tests on Windows
145
146         Reviewed by Mitz Pettel.
147
148         * DumpRenderTree/win/DumpRenderTree.cpp:
149         (dump):
150         (main): We don't have to flush stdout/stderr in the arguments loop
151         anymore, as runTest flushes for us.
152
153 2008-04-21  Adam Roben  <aroben@apple.com>
154
155         Fix pixel tests
156
157         * Scripts/run-webkit-tests:
158         (sub readFromDumpToolWithTimer): Use readline instead of read to
159         ensure that we don't read past the #EOF marker.
160
161 2008-04-21  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
162
163         Reviewed by Simon.
164
165         Build fix for Qt 4.3
166
167         * When building WebCore/internal make sure the QT_[BEGIN,END]_NAMESPACE is
168         always defined. Do this by adding defines to the compiler line
169
170         * DumpRenderTree/qt/DumpRenderTree.pro:
171
172 2008-04-19  Mike Hommey  <glandium@debian.org>
173
174         Reviewed by Alp Toker.
175
176         Don't build GtkLauncher and DumpRenderTree with rpath.
177
178         * GNUmakefile.am:
179
180 2008-04-18  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
181
182         Reviewed by Alp Toker.
183
184         http://bugs.webkit.org/show_bug.cgi?id=16620
185         [GTK] Autotools make dist and make check support
186
187         Cleanups.
188
189         * GNUmakefile.am:
190
191 2008-04-18  Adam Roben  <aroben@apple.com>
192
193         Drop the hang timer to 30 seconds
194
195         This matches what DRT/mac was using.
196
197         Reviewed by Mitz Pettel.
198
199         * Scripts/run-webkit-tests:
200
201 2008-04-18  Adam Roben  <aroben@apple.com>
202
203         Get rid of DRT's Watchdog
204
205         run-webkit-tests now detects hangs and samples DRT as needed.
206
207         Reviewed by Mitz Pettel.
208
209         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Removed
210         Watchdog* files from the project.
211         * DumpRenderTree/Watchdog.cpp: Removed.
212         * DumpRenderTree/Watchdog.h: Removed.
213         * DumpRenderTree/mac/DumpRenderTree.mm: Removed uses of Watchdog
214         (dumpRenderTree):
215         (runTest):
216         * DumpRenderTree/mac/WatchdogMac.h: Removed.
217         * DumpRenderTree/mac/WatchdogMac.mm: Removed.
218         * Scripts/run-webkit-tests:
219         (sub testCrashedOrTimedOut): Call sampleDumpTool() if we timed out.
220         (sub sampleDumpTool): Added. Writes a sample report to
221         ~/Library/Logs/DumpRenderTree/HangReport.txt.
222
223 2008-04-18  Simon Hausmann  <hausmann@webkit.org>
224
225         Reviewed by Holger.
226
227         Adapt to the API changes in WebKit/qt
228
229         * DumpRenderTree/qt/DumpRenderTree.cpp:
230         (WebCore::WebPage::WebPage):
231         (WebCore::DumpRenderTree::DumpRenderTree):
232         (WebCore::DumpRenderTree::initJSObjects):
233         (WebCore::DumpRenderTree::dumpFramesAsText):
234         (WebCore::DumpRenderTree::dump):
235
236 2008-04-17  Adam Roben  <aroben@apple.com>
237
238         Fix many tests on Windows
239
240         * Scripts/run-webkit-tests:
241         (readFromDumpToolWithTimer):
242          - Use read instead of sysread to ensure that we don't interfere with
243            other uses of buffered IO in this script.
244         (setFileHandleNonBlocking): Actually set the filehandle to blocking
245         when specified.
246
247 2008-04-17  Adam Roben  <aroben@apple.com>
248
249         Fix ~10 tests
250
251         * Scripts/run-webkit-tests: Only remove the newline after #EOF, not
252         whatever newline happens to be at the end of what we've read.
253
254 2008-04-17  Adam Roben  <aroben@apple.com>
255
256         Remove DRT/win's hang timer
257
258         run-webkit-tests takes care of this for us now
259
260         Reviewed by Anders Carlsson.
261
262         * DumpRenderTree/win/DumpRenderTree.cpp:
263
264 2008-04-17  Adam Roben  <aroben@apple.com>
265
266         Don't wait for the hang timer twice in the case of a hang
267
268         Previously we'd wait for a hang while reading both stdout and stderr
269         from DRT. Now we'll only wait for one or the other.
270
271         Reviewed by Anders Carlsson.
272
273         * Scripts/run-webkit-tests:
274         (top level): Don't wait for stderr to time out if stdout already timed
275         out.
276         (readFromDumpToolWithTimer): If $dontWaitForTimeOut is true, quit
277         after the first read that returns no data.
278
279 2008-04-17  Adam Roben  <aroben@apple.com>
280
281         Don't throw away the output from timed out tests
282
283         Reviewed by Anders Carlsson.
284
285         * Scripts/run-webkit-tests:
286         (top level): Updated for changes to readFromDumpToolWithTimer.
287         (readFromDumpToolWithTimer): Return a hash that contains both the
288         output and whether or not the test timed out.
289
290 2008-04-17  Adam Roben  <aroben@apple.com>
291
292         Make the hang timer 60 seconds
293
294         * Scripts/run-webkit-tests:
295
296 2008-04-17  Adam Roben  <aroben@apple.com>
297
298         Get rid of carriage returns in DRT/win's stderr
299
300         Reviewed by Eric Seidel.
301
302         * DumpRenderTree/win/DumpRenderTree.cpp:
303         (main): Mark stderr as binary like we already do for stdout.
304
305 2008-04-17  Adam Roben  <aroben@apple.com>
306
307         Fix Bug 17678: run-webkit-tests should have a watchdog timer (and
308         timeout long tests)
309
310         <https://bugs.webkit.org/show_bug.cgi?id=17678>
311
312         We now abort tests that take longer than 60 seconds to produce output.
313         This matches the watchdog timer in DRT/mac and DRT/win (which we can
314         now remove).
315
316         Reviewed by Eric Seidel.
317
318         * Scripts/run-webkit-tests:
319         (top level): Read DRT's output using the new readFromDumpToolWithTimer
320         subroutine. If readFromDumpToolWithTimer returns undefined it means
321         the test timed out, so we register the test as a hang and move on.
322         (sub testCrashedOrTimedOut): Renamed from testCrashed. Now handles
323         both crashed and timed out tests. If the test timed out, we kill DRT
324         before returning.
325         (sub linksForTimedOutTest): Added. We don't have any output to link to for
326         tests that timed out.
327         (sub recordActualResultsAndDiff): Don't call length on undefined.
328         (sub readFromDumpToolWithTimer): Added. Performs non-blocking reads
329         from a filehandle until an #EOF is reached or
330         $maximumSecondsWithoutOutput have elapsed.
331         (sub setFileHandleNonBlocking): Marks a filehandle as blocking or
332         non-blocking.
333
334 2008-04-17  Adam Roben  <aroben@apple.com>
335
336         Refactor test results page generation
337
338         Reviewed by Eric Seidel.
339
340         * Scripts/run-webkit-tests:
341         (sub htmlForResultsSection): Added. Takes a set of tests, a
342         description, and a subroutine to generate the links for each test, and
343         creates a HTML string containing a table of the tests and their
344         links.
345         (sub linksForExpectedAndActualResults): Added. Replaces the
346         htmlForExpectedAndActualResults subroutine.
347         (sub linksForMismatchTest): Added.
348         (sub linksForCrashOrErrorTest): Added.
349         (sub linksForNewTest): Added.
350
351 2008-04-17  Adam Roben  <aroben@apple.com>
352
353         Print the extension for all tests in the test results page
354
355         Reviewed by Eric Seidel.
356
357         * Scripts/run-webkit-tests:
358
359 2008-04-17  Adam Roben  <aroben@apple.com>
360
361         Move code that counts finished tests into a subroutine
362
363         Reviewed by Eric Seidel.
364
365         * Scripts/run-webkit-tests:
366         (sub countFinishedTest): Added.
367
368 2008-04-17  Adam Roben  <aroben@apple.com>
369
370         Move code that handles a crash into a subroutine
371
372         Reviewed by Eric Seidel.
373
374         * Scripts/run-webkit-tests:
375         (sub testCrashed): Added.
376
377 2008-04-17  Eric Seidel  <eric@webkit.org>
378
379         Reviewed by hyatt.
380         
381         Rename RenderView to RenderViewport in the next rename patch.
382
383         * Scripts/do-webcore-rename:
384
385 2008-04-17  Mario Bensi  <mbensi@pleyo.com>
386
387         Reviewed by Alp Toker.
388
389         http://bugs.webkit.org/show_bug.cgi?id=18543
390         DumpRenderTree gtk freeze
391
392         fix DumpRenderTree gtk freeze 
393
394         * DumpRenderTree/gtk/DumpRenderTree.cpp:
395         (dump):
396
397 2008-04-15  Anders Carlsson  <andersca@apple.com>
398
399         Add missing ;
400         
401         * Scripts/build-webkit:
402         
403 2008-04-15  Anders Carlsson  <andersca@apple.com>
404
405         Reviewed by Adam.
406
407         Add ENABLE_OFFLINE_WEB_APPLICATIONS to FEATURE_DEFINES.
408
409         * Scripts/build-webkit:
410
411 2008-04-15  Andre Poenitz  <andre.poenitz@trolltech.com>
412
413         Reviewed by Simon.
414
415         Fix compilation with Qt namespaces
416
417         Qt can be configured to have all of its classes inside a specified namespaces.
418         This is for example used in plugin/component environments like Eclipse.
419
420         This change makes it possible to let the Qt port compile against a namespaced
421         Qt by the use of macros Qt provides to properly forward declare Qt classes in
422         the namespace.
423
424         * DumpRenderTree/qt/DumpRenderTree.h:
425
426 2008-04-08  Kevin Ollivier  <kevino@theolliviers.com>
427
428         Reviewed by Darin Adler.
429
430         Add a script that propagates any file changes made to the Bakefiles
431         over to GTK and Qt build systems. Still needs to be wired into
432         those ports though.
433
434         * Scripts/update-sources-list.py: Added.
435
436 2008-04-08  Mark Rowe  <mrowe@apple.com>
437
438         Clean up after Brady.
439
440         * DumpRenderTree/mac/DumpRenderTree.mm: Add an include so that NSInteger can be found.
441
442 2008-04-08  Brady Eidson  <beidson@apple.com>
443
444         Reviewed by Mitzpettel
445
446         Fixed http://bugs.webkit.org/show_bug.cgi?id=18302
447         -WebArchive subresources dump in random order, intermittent failures
448
449         * DumpRenderTree/mac/DumpRenderTree.mm:
450         (compareResourceURLs): Sorting function based on the resource URLs
451         (serializeWebArchiveToXML): Sort the subresource array
452
453 2008-04-07  Brady Eidson  <beidson@apple.com>
454
455         OMG, BUILD - please!
456
457         * Scripts/build-webkit:
458
459 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
460
461         Reviewed by Simon.
462
463         * Enable running http tests for Qt again. Failing tests can be put into the skipped list.
464         * Running these tests on windows and other platforms might need some work.
465
466         * Scripts/run-webkit-tests:
467
468 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
469
470         Reviewed by Simon.
471
472         * For the http tests we need the output of the FrameLoaderClient. The QtWebKit API
473         is not exporting enough to create the output in DRT itself. Settle with the approach
474         Lars has taken for the Editing support and add branches to our FrameLoaderClient code.
475         * run-webkit-tests http/tests(/loading) can now be executed.
476         * For tests in loading/ directories we are going to throw away the dirty
477         QWebPage to start with something clean.
478         
479
480         * DumpRenderTree/qt/DumpRenderTree.cpp:
481
482 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
483
484         Reviewed by Simon.
485
486         * Treat http and https as special URLs as well. Change the main.cpp and
487         DumpRenderTree.cpp to handle http and https URIs as input.
488         * I'm not doing the clean up and merging of these two checks now.
489         
490
491         * DumpRenderTree/qt/DumpRenderTree.cpp:
492         (WebCore::DumpRenderTree::readStdin):
493         * DumpRenderTree/qt/main.cpp:
494         (main):
495
496 2008-04-03  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
497
498         Reviewed by Simon.
499
500         * Remove dumpFrameLoadCallbacks from simple-subframe.html because it is
501         located in a directory with the name "loading". And this will autoamtically
502         enable dumping.
503         * Remove this method from the LayoutTestController as it is unused now and this
504         avoids adding it to the DRT of the Qt port.
505         
506
507         * DumpRenderTree/LayoutTestController.cpp:
508         (setPrivateBrowsingEnabledCallback):
509
510 2008-04-01  Christian Dywan  <christian@imendio.com>
511
512         Build fix for GCC 4.3.
513
514         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: include string.h
515
516 2008-04-01  Simon Hausmann  <hausmann@webkit.org>
517
518         Reviewed by Holger.
519
520         Fix Qt DRT run by also printing EOF on stderr, as expected by
521         run-webkit-tests.
522
523         * DumpRenderTree/qt/DumpRenderTree.cpp:
524         (WebCore::DumpRenderTree::dump):
525
526 2008-03-31  Julien Chaffraix  <julien.chaffraix@gmail.com>
527
528         Reviewed by Darin.
529
530         Bug 17665: determineSourceDir() dies if $sourceDir has a trailing backslash
531
532         Remove trailing '/' in $sourceDir in determineSourceDir().
533
534         Fix suggested by Dmitriy Kazachkov.
535
536         * Scripts/webkitdirs.pm:
537
538 2008-03-29  Adam Roben  <aroben@apple.com>
539
540         Update for rename of an IWebViewPrivate method
541
542         Reviewed by Mitz Pettel.
543
544         * DumpRenderTree/win/DumpRenderTree.cpp:
545         (createWebViewAndOffscreenWindow):
546
547 2008-03-26  Antti Koivisto  <antti@apple.com>
548
549         Reviewed by Anders.
550         
551         Enable SVG animation support by default.
552
553         * Scripts/build-webkit:
554
555 2008-03-25  Adam Roben  <aroben@apple.com>
556
557         Windows build fix
558
559         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
560         Add $(WebKitLibrariesDir)\include to the include path so we can find
561         stdint.h there.
562
563 2008-03-24  Eric Seidel  <eric@webkit.org>
564
565         Reviewed by Mark.
566
567         Clean up SVG features message to be less confusing.
568
569         * Scripts/build-webkit:
570
571 2008-03-24  Sam Weinig  <sam@webkit.org>
572
573         Reviewed by Dave Hyatt.
574
575         Add EventSender.zoomPageIn/zoomPageOut support to DRT.
576
577         * DumpRenderTree/mac/DumpRenderTree.mm:
578         (resetWebViewToConsistentStateBeforeTesting):
579         * DumpRenderTree/mac/EventSendingController.mm:
580         (+[EventSendingController isSelectorExcludedFromWebScript:]):
581         (-[EventSendingController zoomPageIn]):
582         (-[EventSendingController zoomPageOut]):
583         * DumpRenderTree/win/DumpRenderTree.cpp:
584         (resetWebViewToConsistentStateBeforeTesting):
585         * DumpRenderTree/win/EventSender.cpp:
586         (textZoomInCallback):
587         (textZoomOutCallback):
588         (zoomPageInCallback):
589         (zoomPageOutCallback):
590
591 2008-03-24  Dan Bernstein  <mitz@apple.com>
592
593         Reviewed by Mark Rowe.
594
595         - update bisect-builds for Safari 3.1
596
597         * Scripts/bisect-builds: Added Safari 3.1 and the corresponding minimal
598         revision, r29711.
599
600 2008-03-21  Rodney Dawes  <dobey@wayofthemonkey.com>
601
602         Reviewed by Holger.
603
604         http://bugs.webkit.org/show_bug.cgi?id=17981
605
606         Add webcore and javascriptcore cppflags to programs' _CPPFLAGS.
607
608         * GNUmakefile.am:
609
610 2008-03-21  Adam Roben  <aroben@apple.com>
611
612         Remove a non-working mirror from cygwin-downloader and add the ruby package
613
614         * CygwinDownloader/cygwin-downloader.py:
615         * CygwinDownloader/cygwin-downloader.zip: Updated.
616
617 2008-03-20  Mark Rowe  <mrowe@apple.com>
618
619         Reviewed by Sam Weinig.
620
621         Ensure that the defines generated for FEATURE_DEFINES are sorted so that they will match the default settings of each project.
622         This will prevent the world from being rebuilt if you happen to switch between building in Xcode and with build-webkit on the
623         command-line.
624
625         * Scripts/build-webkit:
626
627 2008-03-17  Eric Seidel  <eric@webkit.org>
628
629         Reviewed by Dan Bernstein.
630
631         Fix bogus argCount check breaking plugin test.
632
633         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
634
635 2008-03-17  Eric Seidel  <eric@webkit.org>
636
637         Reviewed by darin.
638
639         Cleanup PluginObject.cpp and add support for testing
640         converting from int -> identifier -> string
641         and from string -> identifier -> int
642         as well as round-tripping ints and stings through identifiers
643
644         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
645         (pluginGetProperty):
646         (pluginSetProperty):
647         (testDOMAccess):
648         (stringVariantToIdentifier):
649         (int32VariantToIdentifier):
650         (doubleVariantToIdentifier):
651         (variantToIdentifier):
652         (testIdentifierToString):
653         (testIdentifierToInt):
654         (testCallback):
655         (getURL):
656         (removeDefaultMethod):
657         (getURLNotify):
658         (testInvokeDefault):
659         (destroyStream):
660         (testEnumerate):
661         (testGetIntIdentifier):
662         (testGetProperty):
663         (testEvaluate):
664         (testGetPropertyReturnValue):
665         (pluginInvoke):
666         (pluginInvokeDefault):
667         (pluginInvalidate):
668         (pluginAllocate):
669         (pluginDeallocate):
670         (handleCallback):
671
672 2008-03-16  Kevin Ollivier  <kevino@theolliviers.com>
673
674         Rubber stamped by Darin.
675
676         Add set-webkit-configuration support for wx port, and centralize
677         build dir location setting.
678
679         http://bugs.webkit.org/show_bug.cgi?id=17790
680
681         * wx/browser/browser.bkl:
682         * wx/build-wxwebkit:
683
684 2008-03-15  Darin Adler  <darin@apple.com>
685
686         * Scripts/commit-log-editor: Include the name line of the change log entry.
687         A long time ago I designed this script to not include the name because I
688         thought it was redundant (same as the name of the person checking in), but
689         nowadays it's more common for someone to check something in done by someone
690         else.
691
692         * Scripts/do-webcore-rename: Added some more planned renames and removed
693         some that were already done "by hand".
694
695 2008-03-13  Brent Fulgham  <bfulgham@gmail.com>
696
697         Reviewed by Darin.
698
699         Correct paths to vsprops files so they use the environment
700         variable, rather than hard-coded path.
701         http://bugs.webkit.org/show_bug.cgi?id=17797.
702
703         * WinLauncher/WinLauncher.vcproj:  Correct paths to vsprops.
704
705 2008-03-12  Steve Falkenburg  <sfalken@apple.com>
706
707         VSExpress build fix
708
709         * WinLauncher/WinLauncher.vcproj:
710
711 2008-03-12  Holger Hans Peter Freyther  <zecke@selfish.org>
712
713         Reviewed by Alp Toker.
714
715         Run testkjs in the correct productsDir in the GTK+ port.
716
717         * Scripts/run-javascriptcore-tests:
718
719 2008-03-11  Brent Fulgham  <bfulgham@gmail.com>
720
721         Reviewed by Adam Roben.
722
723         Enabled WinLauncher as part of normal Windows build.
724         http://bugs.webkit.org/show_bug.cgi?id=17715.
725
726         * WinLauncher/WinLauncher.vcproj: Update to use vsprops so that
727           it can find the proper libraries to link against.
728
729 2008-03-10  Julien Chaffraix  <julien.chaffraix@gmail.com>
730
731         Reviewed and landed by Darin.
732
733         http://bugs.webkit.org/show_bug.cgi?id=17581
734         Bug 17581: Use of uninitialized value in string ne at WebKitTools/Scripts/run-webkit-tests line 1576.
735
736         Remove the previous warning which occurs when the --random option is used.
737
738         * Scripts/run-webkit-tests: verify that $component[0] is defined before checking for
739         its inequality
740
741 2008-03-07  Simon Hausmann  <hausmann@webkit.org>
742
743         Reviewed by Darin.
744
745         Done with Lars.
746
747         Ported the netscape test plugin to QWebPluginFactory.
748
749         * DumpRenderTree/qt/DumpRenderTree.cpp:
750         (WebCore::WebPage::WebPage):
751         * DumpRenderTree/qt/main.cpp:
752         * DumpRenderTree/qt/testplugin.cpp:
753         (TestPlugin::plugins):
754         (TestPlugin::create):
755         * DumpRenderTree/qt/testplugin.h:
756
757 2008-03-09  Steve Falkenburg  <sfalken@apple.com>
758
759         Stop Windows build if an error occurs in a prior project.
760
761         Rubber stamped by Darin.
762
763         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
764         * DumpRenderTree/win/DumpRenderTree.vcproj:
765         * DumpRenderTree/win/ImageDiff.vcproj:
766         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
767
768 2008-03-08  Julien Chaffraix  <julien.chaffraix@gmail.com>
769
770         Reviewed by Mark Rowe.
771
772         DRT build fix for Tiger.
773
774         * DumpRenderTree/mac/DumpRenderTreeMac.h: Define BUILDING_ON_TIGER.
775
776 2008-03-07  Mark Rowe  <mrowe@apple.com>
777
778         Reviewed by Oliver Hunt.
779
780         Fix WebKit build with GCC 4.2.
781
782         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Use correct argument type in method signature.
783
784 2008-03-07  Stephanie Lewis <slewis@apple.com>
785
786         Reviewed by Oliver.
787
788         Add Windows part of <rdar://problem/5693690> 
789
790         * DumpRenderTree/win/DumpRenderTree.cpp:
791         (dump):
792         (main):
793
794 2008-03-07  Alp Toker  <alp@atoker.com>
795
796         Back out the r30818, r30819 build fix attempts now the GTK+ build
797         server has been upgraded.
798
799         * Scripts/webkitdirs.pm:
800
801 2008-03-07  Stephanie Lewis <slewis@apple.com>
802
803         Reviewed by Geoff.
804
805         <rdar://problem/5693690> run-webkit-tests swallows STDERR output, including WebCore LEAK messages
806
807         * DumpRenderTree/mac/DumpRenderTree.mm:
808         (dump): push EOF to stderr after every test
809         * Scripts/run-webkit-tests: collect stderr output and print it
810
811 2008-03-07  Steve Falkenburg  <sfalken@apple.com>
812
813         Get pdevenv working with Visual Studio Express.
814         
815         Reviewed by Adam.
816
817         * Scripts/pdevenv:
818
819 2008-03-06  Adele Peterson  <adele@apple.com>
820
821         Reviewed by Darin.
822
823         Updated for testing <rdar://problem/5785895> Implement hasFocus() for HTMLDocument (HTML5)
824
825         * DumpRenderTree/mac/UIDelegate.mm:
826         (-[UIDelegate webViewFocus:]): Remove duplicate code that was also in LayoutTestController::setWindowIsKey
827         (-[UIDelegate webViewUnfocus:]): Added.  In Safari, the default is to focus another window if there is one.
828          To easily test cases where the window is unfocused, I made this just call setWindowIsKey(false).
829
830 2008-03-06  Matt Lilek  <webkit@mattlilek.com>
831
832         Reviewed by Adam Roben.
833
834         Bug 17691: REGRESSION: FindSafari doesn't work
835         http://bugs.webkit.org/show_bug.cgi?id=17691
836
837         Swap my change from r30394 to use the Release libraries instead of Debug
838         since some machines don't have the Debug version.
839
840         * FindSafari/FindSafari.vcproj:
841
842 2008-03-06  Kevin McCullough  <kmccullough@apple.com>
843
844         Reviewed by Sam and Tim.
845
846         <rdar://5631450> Drosera: breakpoint indicators disappear after the
847         script is finished running.
848         - If there is a pre-existing breakpoint on a line when the file is
849         updated we need to redraw it.
850
851         * Drosera/debugger.js:
852
853 2008-03-06  Brady Eidson  <beidson@apple.com>
854
855         Tiger build fix...?
856
857         * DumpRenderTree/mac/WatchdogMac.mm:
858
859 2008-03-06  Brady Eidson  <beidson@apple.com>
860
861         Reviewed by Darin
862
863         Added a cross-platform Watchdog thread to DRT.
864
865         The current watchdog in both DRTWin and DRTMac is Timer based.  Therefore, deadlocks and long running
866         main thread hangs still affect DRT.
867
868         By placing the watchdog on a thread and having DRT "check in" after each test, long-running hangs
869         and true deadlocks can be caught.
870
871         There is one hook for platform specific code.  As I did my development and testing on Mac, and Mac has
872         `sample` available, the Mac implementation of this hook samples the process before it is killed.
873
874         I arbitrarily chose 30 seconds as the timeout for now - this can be tweaked easily if we find a need.
875
876         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
877         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added LINKER_DISPLAYS_MANGLED_NAMES
878
879         * DumpRenderTree/ForwardingHeaders/wtf/Locker.h: Added.
880         * DumpRenderTree/ForwardingHeaders/wtf/Threading.h: Added.
881
882         * DumpRenderTree/Watchdog.cpp: Added.
883         (Watchdog::Watchdog):
884         (Watchdog::~Watchdog):
885         (Watchdog::start):
886         (Watchdog::stop):
887         (Watchdog::checkIn):
888         (Watchdog::setWatchdogInterval):
889         (Watchdog::handleHang):
890         (Watchdog::watchdogThreadStart):
891         (Watchdog::watchdogThread):
892         * DumpRenderTree/Watchdog.h: Added.
893
894         * DumpRenderTree/mac/WatchdogMac.h: Added.
895         * DumpRenderTree/mac/WatchdogMac.mm: Added.
896         (WatchdogMac::handleHang): Sample the process and write it out to a file
897
898         * DumpRenderTree/mac/DumpRenderTree.mm:
899         (dumpRenderTree): Setup and start the watchdog before running any tests
900         (runTest): Checkin with the watchdog after each test
901
902 2008-03-05  Alp Toker  <alp@atoker.com>
903
904         Attempt to get the autotools build working again on the bot with
905         build-webkit.
906
907         Force the use of /bin/bash since we seem to have bash-isms in the
908         configure script right now.
909
910         * Scripts/webkitdirs.pm:
911
912 2008-03-05  Alp Toker  <alp@atoker.com>
913
914         Re-attempt to switch to the autotools build system for GTK+.
915
916         Change scripts to continue when distclean fails.
917
918         * Scripts/webkitdirs.pm:
919
920 2008-03-05  Alp Toker  <alp@atoker.com>
921
922         Force qmake for the GTK+ build until we get the build bot to succeed
923         with autotools (currently dies at make distclean)
924
925         * Scripts/webkitdirs.pm:
926
927 2008-03-04  Alp Toker  <alp@atoker.com>
928
929         Reviewed by Mark Rowe.
930
931         Switch the default GTK+ build system from qmake to autotools.
932
933         qmake can still be used by defining WEBKIT_BUILD_SYSTEM=qmake
934
935         * Scripts/build-webkit:
936         * Scripts/run-launcher:
937         * Scripts/run-webkit-tests:
938         * Scripts/webkitdirs.pm:
939
940 2008-03-04  Sam Weinig  <sam@webkit.org>
941
942         Reviewed by Darin Adler.
943
944         * Scripts/do-webcore-rename: Update renaming plan.
945
946 2008-03-02  Brent Fulgham  <bfulgham@gmail.com>
947
948         Reviewed by Alp Toker.
949
950         Remove some needless LIBS.
951
952         * GNUmakefile.am:
953
954 2008-03-02  Alp Toker  <alp@atoker.com>
955
956         Reviewed by Mark Rowe.
957
958         Split the WebKit GTK+ build out of the WebCore build and change the
959         shared object name to match the package name.
960
961         * GNUmakefile.am:
962
963 2008-03-01  Mark Rowe  <mrowe@apple.com>
964
965         Reviewed by Tim Hatcher.
966
967         Update Xcode configuration to support building debug and release from the mysterious future.
968
969         * DumpRenderTree/mac/Configurations/Base.xcconfig:
970
971 2008-02-29  David Kilzer  <ddkilzer@apple.com>
972
973         Pass the correct configuration switch (--Debug|--Release) to build-testkjs.
974
975         Reviewed by Dan.
976
977         Originally broken in r26838.
978
979         * Scripts/run-javascriptcore-tests: Push configuration switch onto @xcodeArgs
980         not local, unused @args variable.
981
982 2008-02-29  David Kilzer  <ddkilzer@apple.com>
983
984         Bug 15754: webarchive layout tests fail when WebKit directory path contains symlinks
985
986         <http://bugs.webkit.org/show_bug.cgi?id=15754>
987
988         Reviewed by Geoff and Darin.
989
990         We were using -[NSFileManager currentDirectoryPath] to get the current working directory,
991         then removing that path from all file:/// URLs in the WebArchive output so these tests
992         would pass no matter where they were run.
993
994         The problem was that -[NSFileManager currentDirectoryPath] resolves symlinks in the
995         current working directory, but the WebArchive does not.  This left the current working
996         directory in all file:/// URLs in the test output, and thus all tests failed, for any
997         developer that used symlinks to get to their WebKit source directory.
998
999         The fix is to look backwards for "/LayoutTests/" in the URL we're passed, and simply
1000         remove the current working directory path (no matter what it is) after "file://" but
1001         before "/LayoutTests/".  
1002
1003         * DumpRenderTree/mac/DumpRenderTree.mm:
1004         (normalizeWebResourceURL): Removed unused oldURLBase argument.  We now replace the
1005         current working directory as described above.
1006         (convertWebResourceResponseToDictionary): Remove unused oldURLBase argument.  Update
1007         calls to normalizeWebResourceURL().
1008         (serializeWebArchiveToXML): Removed now unused cwdURL variable.  Update calls to
1009         normalizeWebResourceURL() and convertWebResourceResponseToDictionary().
1010
1011 2008-02-26  Robin Dunn <robin@alldunn.com>
1012
1013         Reviewed by Kevin Ollivier.
1014
1015         Improvements to the wx build script.
1016
1017         http://bugs.webkit.org/show_bug.cgi?id=17492
1018
1019         * wx/build-wxwebkit:
1020         - Update the Windows dll copying logic to copy dlls inside WebKitLibraries/win
1021         - Allow the build script to properly find wxPython includes under different setups
1022         - Make sure WX_PREFIX is set to WXWIN (wxWindows dir environment var.) if not defined
1023
1024 2008-02-26  Timothy Hatcher  <timothy@apple.com>
1025
1026         Reviewed by Darin Adler.
1027
1028         * Scripts/build-webkit: Add --universal and --64-bit flags to make building
1029         64-bit architectures easy. Combine the two flags to build 4-way universal.
1030         * Makefile: Add "64" and "64u" make rules. Fix the universal rule to return
1031         non-zero when the build failes.
1032
1033 2008-02-26  Jessica Kahn  <jess@apple.com>
1034
1035         Reviewed by Darin.
1036
1037         * Scripts/gdb-safari: Set WEBKIT_UNSET_DYLD_FRAMEWORK_PATH in gdb's environment,
1038         so that Safari inherits it when launched. Preexisting code in WebKit checks this
1039         environment variable, and if set, unsets DYLD_FRAMEWORK_PATH, so that applications
1040         launched by Safari continue to use the standard system WebKit.
1041
1042 2008-02-25  Adam Roben  <aroben@apple.com>
1043
1044         Fix run-webkit-tests after r30394
1045
1046         * Scripts/webkitdirs.pm: Never append _debug to FindSafari's
1047         executable name.
1048
1049 2008-02-24  Darin Adler  <darin@apple.com>
1050
1051         * Scripts/do-webcore-rename: Make some updates based on a trial run of
1052         the renaming script.
1053
1054 2008-02-24  Darin Adler  <darin@apple.com>
1055
1056         * Scripts/do-webcore-rename: More renaming plans.
1057
1058 2008-02-23  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1059
1060         Rubber stamped by Darin.
1061
1062         Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
1063         whitespaces introduced in the previous commit.
1064
1065         * GNUmakefile.am:
1066
1067 2008-02-23  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1068
1069         Rubber-stamped by Darin.
1070
1071         * GNUmakefile.am: Add both GLOBALDEPS and WEBKITDEPS instead of DEPENDENCIES.
1072
1073 2008-02-23  David Kilzer  <ddkilzer@apple.com>
1074
1075         Please clarify licensing for some files
1076         <http://bugs.webkit.org/show_bug.cgi?id=14970>
1077
1078         Reviewed by Darin.
1079
1080         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Added
1081         copyright statement.  Replaced license with newer Apple BSD-style license.
1082         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Ditto.
1083         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Ditto.
1084         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Ditto.
1085         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Ditto.
1086         * DumpRenderTree/win/TestNetscapePlugin/main.c: Ditto.
1087         * mangleme/LICENSE: Added (LGPL).
1088
1089 2008-02-22  Anders Carlsson  <andersca@apple.com>
1090
1091         Reviewed by Adam.
1092
1093         <rdar://problem/5748781> 
1094         https://bugs.webkit.org/show_bug.cgi?id=17413
1095         REGRESSION: Latest Nightly doesn't load Java plugin w/Safari 3.1b
1096         
1097         Copy the Java plug-in over to the new location.
1098         
1099         * FindSafari/FindSafari.cpp:
1100         (_tmain):
1101
1102 2008-02-22  Anders Carlsson  <andersca@apple.com>
1103
1104         Reviewed by Adam.
1105
1106         <rdar://problem/5747325> REGRESSION: HTTP layout tests hang
1107         
1108         * DumpRenderTree/win/DumpRenderTree.cpp:
1109         (runTest):
1110         Init the URL request with the correct timeout.
1111
1112 2008-02-21  Mike Auty  <mike.auty@gmail.com>
1113
1114         Reviewed by Alp Toker.
1115
1116         http://bugs.webkit.org/show_bug.cgi?id=17445
1117         [GTK] WebKit doesn't compile with LDFLAGS="-Wl,--as-needed"
1118
1119         GTK+/autotools build system improvements
1120
1121         The GNUmakefile.am files make use of the LDFLAGS variable to include library
1122         additions such as -ljpeg etc.  Unfortunately, if these inclusions aren't made
1123         in LIBADD/LDADD variables, then they are mis-ordered during the linking.
1124
1125         The as-needed flag discards libraries whose functions have not been needed by
1126         earlier libraries, which therefore makes the ordering important.
1127
1128         This moves all -l library inclusion statements from LDFLAGS variables to
1129         LIBADD/LDADD variables.
1130
1131         * GNUmakefile.am:
1132
1133 2008-02-20  Brent Fulgham  <bfulgham@gmail.com>
1134
1135         Reviewed by Alp.
1136
1137         - http://bugs.webkit.org/show_bug.cgi?id=17428
1138           Reenable a Windows-based launcher
1139
1140         This patch reenables the venerable Spinneret application,
1141         changing its name to match the other lanch applications.
1142
1143         * WinLauncher: Added.
1144         * WinLauncher/WinLauncher.cpp: Added.
1145         (WinLauncherWebHost::updateAddressBar):
1146         (WinLauncherWebHost::QueryInterface):
1147         (WinLauncherWebHost::AddRef):
1148         (WinLauncherWebHost::Release):
1149         (resizeSubViews):
1150         (_tWinMain):
1151         (MyRegisterClass):
1152         (InitInstance):
1153         (WndProc):
1154         (MyEditProc):
1155         (About):
1156         (loadURL):
1157         * WinLauncher/WinLauncher.h: Added.
1158         (WinLauncherWebHost::WinLauncherWebHost):
1159         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
1160         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
1161         (WinLauncherWebHost::didFailProvisionalLoadWithError):
1162         (WinLauncherWebHost::didCommitLoadForFrame):
1163         (WinLauncherWebHost::didReceiveTitle):
1164         (WinLauncherWebHost::didReceiveIcon):
1165         (WinLauncherWebHost::didFinishLoadForFrame):
1166         (WinLauncherWebHost::didFailLoadWithError):
1167         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
1168         (WinLauncherWebHost::willPerformClientRedirectToURL):
1169         (WinLauncherWebHost::didCancelClientRedirectForFrame):
1170         (WinLauncherWebHost::willCloseFrame):
1171         (WinLauncherWebHost::windowScriptObjectAvailable):
1172         * WinLauncher/WinLauncher.ico: Added.
1173         * WinLauncher/WinLauncher.rc: Added.
1174         * WinLauncher/WinLauncher.vcproj: Added.
1175         * WinLauncher/resource.h: Added.
1176         * WinLauncher/small.ico: Added.
1177         * WinLauncher/stdafx.cpp: Added.
1178         * WinLauncher/stdafx.h: Added.
1179
1180 2008-02-19  Brady Eidson  <beidson@apple.com>
1181
1182         Reviewed by Geoff
1183
1184         Fixed a bug in DRT --threaded mode
1185
1186         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
1187         (startJavaScriptThreads): Don't detach the newly created thread.  The later call to stopJavaScriptThreads() tries
1188           to pthread_join() each thread that had been created, but you can't join a detached thread!
1189
1190 2008-02-18  Brady Eidson  <beidson@apple.com>
1191
1192         Changes by Geoff Garen, Reviewed by Darin
1193
1194         Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released
1195
1196         DRT changes for test: platform/mac/plugins/webScriptObject-exception-deadlock.html
1197
1198         [WebScriptObject valueForKey:] might throw an exception, and previously might have "leaked" the global JSLock
1199         This test calls valueForKey, then runs some arbitrary Javascript on a 2ndary thread.  If the lock has leaked,
1200         this series of method calls will deadlock.  If things are good, it will complete successfully.
1201
1202         * DumpRenderTree/mac/ObjCController.m:
1203         (runJavaScriptThread):
1204         (+[ObjCController isSelectorExcludedFromWebScript:]):
1205         (+[ObjCController webScriptNameForSelector:]):
1206         (-[ObjCController testValueForKey]):
1207
1208 2008-02-18  Matt Lilek  <webkit@mattlilek.com>
1209
1210         Reviewed by Adam.
1211
1212         Remove FindSafari's Release configuration.
1213
1214         * FindSafari/FindSafari.vcproj:
1215
1216 2008-02-15  Adam Roben  <aroben@apple.com>
1217
1218         Fix a typo that broke the Mac build
1219
1220         Reviewed by Mark.
1221
1222         * Scripts/build-webkit:
1223
1224 2008-02-14  Adam Roben  <aroben@apple.com>
1225
1226         Turn on cross-document messaging support by default
1227
1228         Reviewed by Darin.
1229
1230         * Scripts/build-webkit:
1231
1232 2008-02-14  Adam Roben  <aroben@apple.com>
1233
1234         Conditionalize cross-document messaging support
1235
1236         The cross-document messaging parts of HTML 5 are in flux and we want
1237         ports to be able to turn off the support as needed.
1238
1239         Note that the support is turned off by default right now. A subsequent
1240         commit will turn it on by default.
1241
1242         Reviewed by Darin.
1243
1244         * Scripts/build-webkit:
1245
1246 2008-02-14  Darin Adler  <darin@apple.com>
1247
1248        - fix Windows build
1249
1250         * DumpRenderTree/win/UIDelegate.cpp:
1251         (UIDelegate::setStatusText): Update parameter types to match declaration.
1252
1253 2008-02-14  Oliver Hunt  <oliver@apple.com>
1254
1255         Reviewed by Geoff G and Weinig.
1256
1257         Add ability for DRT to report tests setting the status text.
1258
1259         * DumpRenderTree/LayoutTestController.cpp:
1260         (LayoutTestController::LayoutTestController):
1261         (dumpStatusCallbacksCallback):
1262         (LayoutTestController::staticFunctions):
1263         * DumpRenderTree/LayoutTestController.h:
1264         * DumpRenderTree/mac/UIDelegate.mm:
1265         (-[UIDelegate webView:setStatusText:]):
1266         * DumpRenderTree/win/UIDelegate.cpp:
1267         * DumpRenderTree/win/UIDelegate.h:
1268
1269 2008-02-13  Adam Roben  <aroben@apple.com>
1270
1271         Windows build fix
1272
1273         * DumpRenderTree/ForwardingHeaders/wtf/MathExtras.h: Added.
1274
1275 2008-02-13  Adam Roben  <aroben@apple.com>
1276
1277         Windows/GTK+ build fix
1278
1279         * DumpRenderTree/LayoutTestController.cpp: #include MathExtras.h to
1280         get isnan.
1281
1282 2008-02-13  Brady Eidson  <beidson@apple.com>
1283
1284         Reviewed by Darin Adler
1285
1286         Add some much needed Database support to DRT
1287
1288         * DumpRenderTree/LayoutTestController.cpp:
1289         (LayoutTestController::LayoutTestController):
1290         (dumpDatabaseCallbacksCallback): Flag to control if the UIDelegate methods related to
1291           databases are called
1292         (clearAllDatabasesCallback): Allow a test to delete all databases
1293         (setDatabaseQuotaCallback): Allow a test to set the quota new origins will get
1294         (LayoutTestController::staticFunctions):
1295
1296         * DumpRenderTree/LayoutTestController.h:
1297         (LayoutTestController::dumpDatabaseCallbacks):
1298         (LayoutTestController::setDumpDatabaseCallbacks):
1299
1300         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1301         (LayoutTestController::clearAllDatabases):
1302         (LayoutTestController::setDatabaseQuota):
1303
1304         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1305         (LayoutTestController::clearAllDatabases): Stubbed out
1306         (LayoutTestController::setDatabaseQuota): Ditto
1307         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1308         (LayoutTestController::clearAllDatabases): Stubbed out with error message
1309         (LayoutTestController::setDatabaseQuota): Ditto
1310
1311         * DumpRenderTree/mac/UIDelegate.mm:
1312         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Print a
1313           message with details about the event then return a 5mb quota like before
1314
1315
1316 2008-02-12  Steve Falkenburg  <sfalken@apple.com>
1317
1318         Changes to support merged MIDL output.
1319
1320         All COM interfaces are now generated to WebKit.h.
1321
1322         Reviewed by Sam, Ada.
1323
1324         * Drosera/win/BaseDelegate.h:
1325         * Drosera/win/DebuggerClient.cpp:
1326         * Drosera/win/DebuggerDocumentPlatform.cpp:
1327         * Drosera/win/Drosera.cpp:
1328         * Drosera/win/ServerConnection.cpp:
1329         * Drosera/win/ServerConnection.h:
1330         * DumpRenderTree/win/DumpRenderTree.cpp:
1331         * DumpRenderTree/win/EditingDelegate.h:
1332         * DumpRenderTree/win/EventSender.cpp:
1333         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1334         * DumpRenderTree/win/FrameLoadDelegate.h:
1335         * DumpRenderTree/win/GCControllerWin.cpp:
1336         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1337         * DumpRenderTree/win/PolicyDelegate.h:
1338         * DumpRenderTree/win/ResourceLoadDelegate.h:
1339         * DumpRenderTree/win/UIDelegate.cpp:
1340         * DumpRenderTree/win/UIDelegate.h:
1341         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1342
1343 2008-02-10  Dan Bernstein  <mitz@apple.com>
1344
1345         Reviewed by Oliver Hunt.
1346
1347         - fix a memory leak
1348
1349         * DumpRenderTree/cg/ImageDiffCG.cpp:
1350         (getDifferenceBitmap): Use a static CFMutableData instead of allocating
1351         and leaking the buffer each time.
1352
1353 2008-02-07  Adam Roben  <aroben@apple.com>
1354
1355         Fix error in bisect-builds when responding "broken" for the first
1356         build
1357
1358         Reviewed by Dave Kilzer.
1359
1360         * Scripts/bisect-builds: Only try to test the build if the nightly
1361         info for the current index has not been deleted.
1362
1363 2008-02-07  Geoffrey Garen  <ggaren@apple.com>
1364
1365         Reviewed by Alexey Proskuryakov.
1366
1367         Fixed two minor typos in the --root option, to get it working.
1368
1369         * Scripts/run-sunspider:
1370             1. Actually assign the function argument to our local variable.
1371             2. Actually set the $root variable, so we don't try to build later.
1372
1373 2008-02-05  Oliver Hunt  <oliver@apple.com>
1374
1375         RS=Eric.
1376
1377         Re-enable foreignObject by default as it is needed for a number of non-fO
1378         related SVG tests and none of the old known crashes occur anymore.
1379
1380         * Scripts/build-webkit:
1381
1382 2008-02-05  Steve Falkenburg  <sfalken@apple.com>
1383
1384         Build fix.  Don't override intermediate directory.
1385
1386         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1387
1388 2008-02-05  Holger Hans Peter Freyther  <zecke@selfish.org>
1389
1390         Build fix for Windows. willCloseFrame is a pure virtual and we are
1391         forced to have an implementation.
1392         
1393         This partially reverts r30014.
1394
1395         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1396         (FrameLoadDelegate::willCloseFrame):
1397         * DumpRenderTree/win/FrameLoadDelegate.h:
1398
1399 2008-02-05  Nikolas Zimmermann  <zimmermann@kde.org>
1400
1401         Reviewed by Holger.
1402
1403         Don't build wrapper for SVGTestCase.js (special file for svg/dynamic-updates)
1404
1405         * Scripts/make-js-test-wrappers:
1406
1407 2008-02-05  Holger Freyther  <zecke@selfish.org>
1408
1409         Reviewed by Darin.
1410
1411         In http://bugs.webkit.org/show_bug.cgi?id=16853 it was identified that the
1412         the output of the willCloseFrame and didClearWindowObject FrameLoadDelegate
1413         depends on the order the tests are executed.
1414         
1415         Propose to remove willCloseFrame and didlCearWindowObject output from the
1416         FrameLoadDelegate and update the test results. The output of didClearWindowObject
1417         is not interesting for any of the current tests and we have other ways to find
1418         out if a frame was closed or not.
1419
1420         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1421         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1422         (FrameLoadDelegate::didClearWindowObject):
1423         * DumpRenderTree/win/FrameLoadDelegate.h:
1424
1425 2008-02-04  Mark Rowe  <mrowe@apple.com>
1426
1427         Reviewed by Oliver Hunt.
1428
1429         Workaround for http://bugs.webkit.org/show_bug.cgi?id=16842
1430         Bug 16842: Hang in DRT in leaks mode due to signal handler doing unsafe things
1431
1432         Don't install the signal handler unless we are running the pixel tests.
1433         It is currently only used to restore the color profile, but by catching
1434         signals we can trigger a deadlock in DRT while running leak tests.
1435         The deadlock is tracked by http://bugs.webkit.org/show_bug.cgi?id=16842,
1436         and a more complete fix will need to be developed to address this for
1437         pixel tests as well.
1438
1439         * DumpRenderTree/mac/DumpRenderTree.mm:
1440         (dumpRenderTree):
1441
1442 2008-02-04  Mark Rowe  <mrowe@apple.com>
1443
1444        Gtk qmake build fix.
1445
1446         * Scripts/webkitdirs.pm:  Fix perl's complaint about an odd number of elements in anonymous hash.
1447
1448 2008-02-04  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1449
1450         Reviewed by Alp Toker and Mark Rowe.
1451
1452         http://bugs.webkit.org/show_bug.cgi?id=16618
1453         [GTK] build-webkit and run-webkit-tests autootools support
1454
1455         * Scripts/build-webkit: added --database and --icon-database options
1456         * Scripts/run-launcher:
1457         * Scripts/run-webkit-tests:
1458         * Scripts/webkitdirs.pm:
1459
1460 2008-02-04  Oliver Hunt  <oliver@apple.com>
1461
1462         Reviewed by Steve F.
1463
1464         Partial fix for <rdar://5621244> Drag & Drop doesn't work correctly in DRT
1465
1466         Implement required DRT functionality to allow majority of Drag and Drop testcases to work.
1467         Issues include:
1468           * Uses Sleep() to implement leapForward reliably.
1469           * 3 DND tests still fail for reasons that i have not yet determined
1470           * Has to explicitly ignore an extraneous WM_MOUSELEAVE that i am at a loss to explain 
1471
1472         * DumpRenderTree/win/EventSender.cpp:
1473         (leapForwardCallback):
1474         (mouseDownCallback):
1475         (doMouseUp):
1476         (mouseUpCallback):
1477         (doMouseMove):
1478         (mouseMoveToCallback):
1479           Minor updates to these functions to handle the different message queue structure.
1480
1481         (replaySavedEvents):
1482           More complicated now.  Where possible we just use the old while-loop model of execution,
1483           but when leapForward has been used we have to jump through some hoops and set up an 
1484           inner event loop so that we can ensure messages get the correct time stamp.
1485
1486         * DumpRenderTree/win/UIDelegate.cpp:
1487         (UIDelegate::doDragDrop):
1488           Call replaySavedEvents directly to force synchronous handling of drag and drop.
1489
1490 2008-02-04  Rodney Dawes  <dobey@wayofthemonkey.com>
1491
1492         Reviewed by Alp Toker and Mark Rowe.
1493
1494         Fix http://bugs.webkit.org/show_bug.cgi?id=17175.
1495         Bug 17175: Use of C++ compiler flags in CFLAGS
1496
1497         * GNUmakefile.am: Use global_cxxflags as well as global_cflags in CXXFLAGS.
1498
1499 2008-02-04  Darin Adler  <darin@apple.com>
1500
1501         Reviewed by Geoff.
1502
1503         * Scripts/make-js-test-wrappers: Look at the whole LayoutTests tree, not just the fast
1504         and svg subdirectories. Added some more exceptions for the benefit of the fast/dom
1505         subdirectory.
1506
1507 2008-02-04  Adam Roben  <aroben@apple.com>
1508
1509         Windows Apple-only build fix
1510
1511         * DumpRenderTree/win/DumpRenderTree.vcproj: Added a new include
1512         directory.
1513
1514 2008-02-04  Alp Toker  <alp@atoker.com>
1515
1516         Rubber-stamped by Mark Rowe.
1517
1518         Remove all trailing whitespace in the GTK+ port and related
1519         components.
1520
1521         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1522         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1523         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1524         * GNUmakefile.am:
1525
1526 2008-02-01  Eric Seidel  <eric@webkit.org>
1527
1528         Reviewed by Oliver.
1529
1530         Also search LayoutTests/svg for js-based tests.
1531
1532         * Scripts/make-js-test-wrappers:
1533
1534 2008-01-31  Alp Toker  <alp@atoker.com>
1535
1536         Rubber-stamped by Adam Roben.
1537
1538         http://bugs.webkit.org/show_bug.cgi?id=17006
1539         [GTK] Header path should be webkit/webkit.h
1540
1541         Move the GTK+ API sources as needed and update the build systems.
1542
1543         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1544         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1545         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1546         * GNUmakefile.am:
1547         * GtkLauncher/main.c:
1548
1549 2008-01-30  Stephanie  <slewis@apple.com>
1550
1551         Reviewed by Geoff.
1552
1553         Add an option to run-webkit-tests to merge leaks results and print the number of unique leaks found under a certain call depth.  This should make it easier for the buildbots to track new leaks.
1554
1555         * Scripts/run-webkit-tests:
1556
1557 2008-01-30  Alexey Proskuryakov  <ap@webkit.org>
1558
1559         Reviewed by Adam Roben.
1560
1561         One more debug (external) fix.
1562
1563         * DumpRenderTree/win/DumpRenderTree.cpp: TestNetscapePlugin is built with a _debug suffix in both DebugInternal
1564         and Debug configurations. 
1565
1566 2008-01-29  Geoffrey Garen  <ggaren@apple.com>
1567
1568         Reviewed by Sam Weinig. Sam Weinig.
1569         
1570         Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
1571         fails when run after fast/dom/Window/window-property-shadowing.html (16902)
1572
1573         Modified our policy delegates not to output window.name. Since a
1574         previous test may have explicitly set window.name, we can't rely on its
1575         implicit value in test results.
1576
1577         * DumpRenderTree/mac/PolicyDelegate.mm:
1578         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1579
1580         * DumpRenderTree/win/PolicyDelegate.cpp:
1581         (PolicyDelegate::decidePolicyForNavigationAction):
1582
1583 2008-01-29  Mark Rowe  <mrowe@apple.com>
1584
1585         Reviewed by Tim Hatcher.
1586
1587         <rdar://problem/5600926> WebCore on Tiger must link to its own copy of SQLite 3.4 or newer (so HTML database behavior will be correct).
1588
1589         * Scripts/build-webkit: Copy SQLite static library and headers into the build directory.
1590
1591 2008-01-29  David Kilzer  <ddkilzer@apple.com>
1592
1593         Refactor ChangeLog path code
1594
1595         Reviewed by Adam.
1596
1597         * Scripts/prepare-ChangeLog: Simplify code in one foreach() loop, and extract
1598         duplicate code in another foreach() loop.
1599
1600 2008-01-29  Alexey Proskuryakov  <ap@webkit.org>
1601
1602         Reviewed by Darin.
1603
1604         <rdar://problem/5710692> All storage tests fail/crash
1605
1606         * DumpRenderTree/mac/UIDelegate.mm:
1607         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Set an
1608         arbitrary quota of 5 megabytes.
1609
1610         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
1611         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
1612         Removed unused (I think) code.
1613         
1614         * DumpRenderTree/win/UIDelegate.cpp:
1615         (UIDelegate::QueryInterface): IWebUIDelegatePrivate3 is now supported.
1616         (UIDelegate::webViewPainted): A stub implementation.
1617         (UIDelegate::exceededDatabaseQuota): Set an arbitrary quota of 5 megabytes.
1618         * DumpRenderTree/win/UIDelegate.h:
1619
1620 2008-01-27  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1621
1622         GTK+ DRT build fix for breakage introduced in r29822.
1623
1624         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1625         (LayoutTestController::setPersistentUserStyleSheetLocation):
1626         (LayoutTestController::clearPersistentUserStyleSheet):
1627
1628 2008-01-27  Dan Bernstein  <mitz@apple.com>
1629
1630         Reviewed by Darin Adler.
1631
1632         - add support for directory prologues and epilogues to run-webkit-tests
1633         - allow setting a persistent user style sheet in DumpRenderTree
1634         - activate the WebKit Layout Tests font in Windows DumpRenderTree
1635
1636         * DumpRenderTree/LayoutTestController.cpp:
1637         (clearPersistentUserStyleSheetCallback): Added.
1638         (setPersistentUserStyleSheetLocationCallback): Added.
1639         (LayoutTestController::staticFunctions): Added.
1640         clearPersistentUserStyleSheet and setPersistentUserStyleSheet.
1641         * DumpRenderTree/LayoutTestController.h:
1642         * DumpRenderTree/mac/DumpRenderTree.mm:
1643         (setPersistentUserStyleSheetLocation): Added.
1644         (resetWebViewToConsistentStateBeforeTesting): Added the user style sheet
1645         to the set of things this function resets. Now it either disables the
1646         user style sheet or sets it to the persistent user style sheet and
1647         enables it.
1648         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1649         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1650         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
1651         (LayoutTestController::clearPersistentUserStyleSheet): Added.
1652         * DumpRenderTree/win/DumpRenderTree.cpp:
1653         (setPersistentUserStyleSheetLocation): Added.
1654         (initialize): Added the WebKit Layout Tests font to the set of fonts to
1655         install.
1656         (resetWebViewToConsistentStateBeforeTesting): See DumpRenderTree.mm.
1657         * DumpRenderTree/win/DumpRenderTreeWin.h:
1658         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1659         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
1660         (LayoutTestController::clearPersistentUserStyleSheet): Added.
1661         * Scripts/run-webkit-tests: Changed to look for, and if found process in
1662         DumpRenderTree, files named run-webkit-tests-prologue.html and
1663         run-webkit-tests-epilogue.html in the resources subdirectory of any
1664         test directory and platform test results directory. The prologues are
1665         processed before the first test from the directory (and its
1666         subdirectories) is run, and the epilogues are processed after the last
1667         test from the directory is run. Platform-specific prologues and
1668         epilogues are processed in order of specificity.
1669
1670 2008-01-25  Alexey Proskuryakov  <ap@webkit.org>
1671
1672         Reviewed by Mark Rowe.
1673
1674         <rdar://problem/5699933> http/tests/security/cross-frame-access-get.html is still failing
1675
1676         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Clear HTTP cache to ensure consistent test environment
1677         (matching Mac DRT).
1678         * DumpRenderTree/win/DumpRenderTree.vcproj: Link to CFNetwork.
1679
1680 2008-01-24  Sam Weinig  <sam@webkit.org>
1681
1682         Reviewed by Ada Chan.
1683
1684         Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo
1685
1686         - Adds simplified UndoManager to windows DRT to allow testing the
1687           undo/redo code paths in WebCore and WebKit.  This is a temporary
1688           solution to an issue that should eventually be solved by having a
1689           shared UndoManager in WebKit.
1690
1691         * DumpRenderTree/win/DumpRenderTree.cpp:
1692         (runTest):
1693         * DumpRenderTree/win/UIDelegate.cpp:
1694         (DRTUndoObject::DRTUndoObject):
1695         (DRTUndoObject::invoke):
1696         (DRTUndoStack::~DRTUndoStack):
1697         (DRTUndoStack::isEmpty):
1698         (DRTUndoStack::clear):
1699         (DRTUndoStack::push):
1700         (DRTUndoStack::pop):
1701         (DRTUndoManager::canRedo):
1702         (DRTUndoManager::canUndo):
1703         (DRTUndoManager::DRTUndoManager):
1704         (DRTUndoManager::removeAllActions):
1705         (DRTUndoManager::registerUndoWithTarget):
1706         (DRTUndoManager::redo):
1707         (DRTUndoManager::undo):
1708         (UIDelegate::UIDelegate):
1709         (UIDelegate::resetUndoManager):
1710         (UIDelegate::registerUndoWithTarget):
1711         (UIDelegate::removeAllActionsWithTarget):
1712         (UIDelegate::setActionTitle):
1713         (UIDelegate::undo):
1714         (UIDelegate::redo):
1715         (UIDelegate::canUndo):
1716         (UIDelegate::canRedo):
1717         * DumpRenderTree/win/UIDelegate.h:
1718
1719 2008-01-23  Adam Roben  <aroben@apple.com>
1720
1721         Allow directories containing ChangeLogs to be passed to
1722         resolve-ChangeLogs
1723
1724         Reviewed by David Kilzer.
1725
1726         * Scripts/resolve-ChangeLogs:
1727         (sub findChangeLog): Return a ChangeLog contained within the specified
1728         directory if one exists.
1729
1730 2008-01-23  Steve Falkenburg  <sfalken@apple.com>
1731
1732         <rdar://problem/5698732> Copyright strings should include 2008
1733
1734         Reviewed by Sam.
1735
1736         * Drosera/win/Drosera.vcproj/Drosera.rc:
1737         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
1738
1739 2008-01-23  Alp Toker  <alp@atoker.com>
1740
1741         Rubber-stamped by Mark Rowe.
1742
1743         Remove whitespace after -I in automake include lists.
1744
1745         * GNUmakefile.am:
1746
1747 2008-01-23  Michael Goddard <michael.goddard@trolltech.com>
1748
1749         Reviewed by Lars Knoll <lars@trolltech.com>.
1750
1751         Reworked the JavaScriptCore Qt bindings:
1752         
1753         * Update JS DRT controller for Qt JS binding changes.
1754         There were two functions that needed some changes
1755         so that the layout tests would work, so this makes
1756         a few tests pass again.
1757         
1758         * Bump the timeout for layout tests up to 11s.
1759         At least some tests have an internal timeout of
1760         10 seconds, so make the waitUntilDone approach
1761         wait at least 11s.  fast/dom/open-and-close-by-DOM.html
1762         is one of these - now the failure message is more
1763         accurate.
1764         
1765
1766         * DumpRenderTree/qt/jsobjects.cpp:
1767         (LayoutTestController::waitUntilDone):
1768         * DumpRenderTree/qt/jsobjects.h:
1769
1770 2008-01-22  Anders Carlsson  <andersca@apple.com>
1771
1772         Reviewed by Darin and Adam.
1773
1774         <rdar://problem/5688975>
1775         div element on microsoft site has wrong left offset.
1776         
1777         Add new method for testing the return vale of NPN_GetProperty.
1778         
1779         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1780         (pluginInvoke):
1781
1782 2008-01-22  Alexey Proskuryakov  <ap@webkit.org>
1783
1784         Reviewed by Adam Roben.
1785
1786         <rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail
1787
1788         * DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.
1789
1790 2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1791
1792         Reviewed by Alp Toker.
1793
1794         http://bugs.webkit.org/show_bug.cgi?id=16955
1795         Get errors when cross-compile webkit-gtk
1796
1797         * GNUmakefile.am: Removed ICU_CFLAGS 
1798
1799 2008-01-21  Darin Adler  <darin@apple.com>
1800
1801         Reviewed by Mitz and Adam.
1802
1803         * Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the
1804         sorting speed by doing all sort criteria in a single pass instead of three sorts.
1805
1806 2008-01-21  Simon Hausmann  <hausmann@webkit.org>
1807
1808         Reviewed by Holger.
1809
1810         Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
1811         
1812         * Fix GraphicsContext::drawFocusRing to also draw single focus rects.
1813         * Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
1814         and make the return value depend on whether we successfully determined a focusable
1815         node or not.
1816         * Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
1817         if we could not handle the focus chain ourselves.
1818         * Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
1819         * Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
1820         used to control the situation of stepping out of the focus chain inside the page.
1821         * Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
1822         The layout tests expect this to be disabled but for the user it seems sensible to have it
1823         on by default, hence the default in qwebsettings.cpp
1824         
1825
1826         * DumpRenderTree/qt/DumpRenderTree.cpp:
1827         (WebCore::WebPage::WebPage):
1828
1829 2008-01-19  Mark Rowe  <mrowe@apple.com>
1830
1831         Reviewed by Alp Toker.
1832
1833         Allow the --http flag to run-webkit-tests to override
1834         the default behaviour of disabling HTTP tests for Qt,
1835         Gtk and Wx.
1836
1837         * Scripts/run-webkit-tests:
1838
1839 2008-01-19  David Kilzer  <ddkilzer@apple.com>
1840
1841         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
1842
1843         Reviewed by Darin.
1844
1845         We now touch a check-for-global-initializers.timestamp file in
1846         the TARGET_TEMP_DIR directory to determine when new object files
1847         have been compiled and thus need to be checked.  If the timestamp
1848         file doesn't exist, all object files will be checked.
1849
1850         Previously the modification time of the "executable" (the
1851         framework binary, e.g., WebKit.framework/WebKit) was used, but
1852         since this was the last file modified at the end of the compile
1853         phase, no object files would ever get checked!
1854
1855         Also added JSCustomSQLTransactionCallback.o to the list of files
1856         since it has static initializers in Debug builds of WebCore.
1857
1858         * Scripts/check-for-global-initializers:
1859
1860 2008-01-18  Adam Roben  <aroben@apple.com>
1861
1862         Build fix
1863
1864         * Scripts/build-webkit:
1865
1866 2008-01-18  Beth Dakin  <bdakin@apple.com>
1867
1868         Reviewed by Oliver.
1869
1870         Update build-webkit to account for foreign-object being disabled by 
1871         default.
1872
1873         * Scripts/build-webkit:
1874
1875 2008-01-18  Adam Roben  <aroben@apple.com>
1876
1877         Updated for method renames
1878
1879         Reviewed by Adele.
1880
1881         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1882         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1883         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1884         (LayoutTestController::setMainFrameIsFirstResponder):
1885         (LayoutTestController::setWindowIsKey):
1886         * DumpRenderTree/mac/UIDelegate.mm:
1887         (-[UIDelegate webViewFocus:]):
1888         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1889         (FrameLoadDelegate::didCommitLoadForFrame):
1890
1891 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
1892
1893         Reviewed by Adam Roben.
1894
1895         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
1896         between DRT and TestNetscapePlugin.
1897
1898         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
1899         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
1900
1901 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
1902
1903         Reviewed by Holger.
1904
1905         Fix fast/dom/Window/window-resize.html
1906         
1907         In DRT connect the page's geometryChangeRequest signal to a slot that
1908         sets the geometry of the view widget.
1909         
1910
1911         * DumpRenderTree/qt/DumpRenderTree.cpp:
1912         (WebCore::WebPage::setViewGeometry):
1913         (WebCore::WebPage::WebPage):
1914
1915 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
1916
1917         Build fix.
1918
1919         * Drosera/DroseraWin.make:
1920
1921 2008-01-17  Darin Adler  <darin@apple.com>
1922
1923         * Scripts/run-webkit-tests: Fixed a bug number.
1924
1925 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
1926
1927         Reviewed by Adam Roben.
1928
1929         http://bugs.webkit.org/show_bug.cgi?id=16908
1930         run-webkit-tests complains about missing FindSafari.exe
1931
1932         * Scripts/webkitdirs.pm: Append _debug as appropriate.
1933
1934 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
1935
1936         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
1937         
1938         Rubber-stamped by Jon Honeycutt.
1939
1940         * DumpRenderTree/win/DumpRenderTree.vcproj:
1941
1942 2008-01-16  Alp Toker  <alp@atoker.com>
1943
1944         Reviewed by Mark Rowe.
1945
1946         http://bugs.webkit.org/show_bug.cgi?id=16218
1947         [GTK] API: Should this entry point be called go_back rather than go_backward?
1948
1949         Track back/forward API changes in the tools.
1950
1951         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1952         (BackForwardItem::invoke):
1953         * GtkLauncher/main.c:
1954         (go_back_cb):
1955
1956 2008-01-16  Adam Roben  <aroben@apple.com>
1957
1958         Windows build fix after r29488
1959
1960         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1961         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
1962         expects to find the plugin.
1963
1964 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
1965
1966         Reviewed by Sam Weinig.
1967         
1968         Fixed the waitUntilDone watchdog timer -- the old code never added the
1969         timer to the run loop, so it didn't do anything.
1970
1971         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1972         (LayoutTestController::setWaitToDump):
1973         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1974         (LayoutTestController::setWaitToDump):
1975
1976 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
1977
1978         Use shared vsprops for most vcproj properties.
1979         
1980         Reviewed by Darin.
1981
1982         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1983         * DumpRenderTree/win/DumpRenderTree.vcproj:
1984         * DumpRenderTree/win/ImageDiff.vcproj:
1985         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1986         * FindSafari/FindSafari.vcproj:
1987
1988 2008-01-14  Stephanie  <slewis@apple.com>
1989
1990        Reviewed by NOBODY.
1991   
1992        revert accidental character.
1993
1994        * Scripts/run-webkit-tests:
1995
1996 2008-01-14  Stephanie  <slewis@apple.com>
1997
1998         RS=Oliver
1999
2000         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
2001
2002         * Scripts/run-webkit-tests:
2003
2004 2008-01-14  Darin Adler  <darin@apple.com>
2005
2006         * Scripts/do-webcore-rename: Queue up another rename.
2007
2008 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
2009
2010         Reviewed by Darin.
2011
2012         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
2013         the tests were ran.
2014         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
2015
2016         * Scripts/run-webkit-tests:
2017
2018 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
2019
2020         Reviewed by Darin.
2021
2022         * Randomize tests array to spot test cases where the results depends on the order
2023         the tests are ran.
2024         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
2025
2026         * Scripts/run-webkit-tests:
2027
2028 2008-01-14  Darin Adler  <darin@apple.com>
2029
2030         * Scripts/run-webkit-tests: More ignore list tweaking.
2031
2032 2008-01-14  Darin Adler  <darin@apple.com>
2033
2034         * Scripts/run-webkit-tests: Add another leak to the ignore list.
2035
2036 2008-01-14  Dan Bernstein  <mitz@apple.com>
2037
2038         Reviewed by Adam Roben.
2039
2040         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
2041           build bots
2042
2043         * DumpRenderTree/win/DumpRenderTree.cpp:
2044         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
2045
2046 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
2047
2048         Share common files across projects.
2049         
2050         Unify vsprops files
2051         Debug:          common.vsprops, debug.vsprops
2052         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
2053         Release:        common.vsprops, release.vsprops
2054         
2055         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
2056         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
2057
2058         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
2059
2060         Reviewed by Adam Roben.
2061
2062         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2063         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
2064         * Drosera/win/Drosera.vcproj/VERSION: Removed.
2065         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
2066         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
2067         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
2068         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
2069         * DumpRenderTree/win/DumpRenderTree.vcproj:
2070         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2071         * DumpRenderTree/win/debug.vsprops: Removed.
2072         * DumpRenderTree/win/debug_internal.vsprops: Removed.
2073         * DumpRenderTree/win/release.vsprops: Removed.
2074
2075 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
2076
2077         Reviewed by Maciej.
2078
2079         - http://bugs.webkit.org/show_bug.cgi?id=16314
2080           Script to launch Drosera
2081
2082         * Scripts/gdb-drosera: Added.
2083         * Scripts/run-drosera: Added.
2084         * Scripts/run-drosera-nightly.cmd: Added.
2085         * Scripts/webkitdirs.pm: Added runDrosera function.
2086
2087 2008-01-13  Dan Bernstein  <mitz@apple.com>
2088
2089         - fix breakage due to last-minute change
2090
2091         * DumpRenderTree/win/DumpRenderTree.cpp:
2092         (runTest): Declare the loop variable.
2093
2094 2008-01-13  Dan Bernstein  <mitz@apple.com>
2095
2096         Reviewed by Adam Roben.
2097
2098         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
2099
2100         * DumpRenderTree/win/DumpRenderTree.cpp:
2101         (DumpRenderTreeWndProc):
2102         (initialize):
2103         (dumpBackForwardList):
2104         (dumpBackForwardListForAllWindows):
2105         (dump):
2106         (resetWebViewToConsistentStateBeforeTesting): Factored out of
2107         runTest().
2108         (runTest):
2109         (allWindows): Added. Returns a vector of all open windows.
2110         (windowToWebViewMap): Added. Returns a map from open windows to their
2111         WebViews.
2112         (createWebViewAndOffscreenWindow): Factored out of main() to be
2113         reusable for creating extra windows.
2114         (main):
2115         * DumpRenderTree/win/DumpRenderTreeWin.h:
2116         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2117         (LayoutTestController::windowCount): Implemented.
2118         * DumpRenderTree/win/UIDelegate.cpp:
2119         (UIDelegate::createWebViewWithRequest): Implemented.
2120         (UIDelegate::webViewClose): Implemented.
2121         * DumpRenderTree/win/UIDelegate.h:
2122
2123 2008-01-12  Alp Toker  <alp@atoker.com>
2124
2125         Reviewed by Mark Rowe.
2126
2127         Hide non-public symbols in GTK+/autotools release builds.
2128
2129         * GNUmakefile.am:
2130
2131 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
2132
2133         Reviewed by Ap.
2134
2135         * Make launching of the WebKit httpd work on GNU/Debian/Linux
2136         
2137         The configuration of Apache2 and installation does not depend on
2138         the kernel but on the distribution policy. Make launching of httpd
2139         work for Debian derived distributions.
2140
2141         * Scripts/run-webkit-httpd:
2142         * Scripts/run-webkit-tests:
2143         * Scripts/webkitdirs.pm:
2144
2145 2008-01-12  Mark Rowe  <mrowe@apple.com>
2146
2147         Reviewed by Maciej Stachowiak.
2148
2149         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
2150
2151         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
2152         match the callers expectations that it can take ownership of the string.
2153
2154 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
2155
2156         Reviewed by Adam Roben.
2157
2158         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
2159
2160         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
2161         as these are only posted because the test window is not a normal visible one, and
2162         they confuse drag&drop machinery.
2163
2164 2008-01-11  Adam Roben  <aroben@apple.com>
2165
2166         Fix a crash when pathToLocalResource fails and a leak
2167
2168         Reviewed by Darin.
2169
2170         * DumpRenderTree/LayoutTestController.cpp:
2171         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
2172         sure not to pass null to JSValueMakeString.
2173         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2174         (LayoutTestController::pathToLocalResource): Print an error message if
2175         the conversion fails so it's clear what happened.
2176
2177 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
2178
2179         Reviewed by John Sullivan.
2180
2181         * DumpRenderTree/mac/GCControllerMac.mm:
2182         (GCController::collectOnAlternateThread): Updated for name change.
2183
2184 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
2185
2186         wx build fix. Don't build dftables any longer since it's now a Perl
2187         script.
2188
2189         * wx/build-wxwebkit:
2190
2191 2008-01-10  Sam Weinig  <sam@webkit.org>
2192
2193         Reviewed by Anders Carlsson.
2194
2195         Make DRT track open windows instead of allocated windows so that
2196         we can avoid ASSERTION due to late deallocs out of our control.
2197
2198         * DumpRenderTree/mac/DumpRenderTree.mm:
2199         (dumpBackForwardListForAllWindows):
2200         (runTest):
2201         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2202         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2203         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2204         (+[DumpRenderTreeWindow openWindows]):
2205         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2206         (-[DumpRenderTreeWindow close]):
2207         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2208         (LayoutTestController::windowCount):
2209
2210 2008-01-10  Ada Chan  <adachan@apple.com>
2211
2212         Meta key is not the same as Alt key on windows.
2213
2214         Reviewed by Darin.
2215
2216         * DumpRenderTree/win/EventSender.cpp:
2217         (keyDownCallback):
2218
2219 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
2220
2221         Reviewed by Darin, Sam and Adam.
2222
2223         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
2224         link in gmail message displays JavaScript alert falsely complaining
2225         about pop-up blocking.
2226         - Added the ability to enable the pop-up blocker via the
2227         LayoutTestController.
2228
2229         * DumpRenderTree/LayoutTestController.cpp:
2230         (setPopupBlockingEnabledCallback):
2231         (LayoutTestController::staticFunctions):
2232         * DumpRenderTree/LayoutTestController.h:
2233         * DumpRenderTree/mac/DumpRenderTree.mm:
2234         (setDefaultsToConsistentValuesForTesting):
2235         (resetWebViewToConsistentStateBeforeTesting):
2236         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2237         (LayoutTestController::setPopupBlockingEnabled):
2238
2239 2008-01-10  Lars Knoll  <lars@trolltech.com>
2240
2241         Reviewed by Simon.
2242
2243         rename QWebPageHistory to QWebHistory.
2244         
2245
2246         * DumpRenderTree/qt/jsobjects.cpp:
2247
2248 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
2249
2250         Reviewed by Darin.
2251         
2252         - add some more renames, adjust some
2253
2254         * Scripts/do-webcore-rename:
2255
2256 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
2257
2258         Reviewed by Oliver.
2259
2260         Enable SVG Fonts support by default.
2261
2262         * Scripts/build-webkit:
2263
2264 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
2265
2266         Reviewed by Adam.
2267
2268         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
2269         DRT doesn't handle platform specific pixel test results correctly.
2270
2271         <test>-expected.txt files and <test>-expected.png files may now live
2272         in different directories (ie. a cross-platform <test>-expected.txt file
2273         and a platform-specific <test>-expected.png file).
2274
2275         * Scripts/run-webkit-tests:
2276
2277 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
2278
2279         Reviewed by Darin.
2280
2281         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
2282         DRT did not correctly handle printing the '\0' char.  Now it does.
2283
2284         * DumpRenderTree/win/DumpRenderTree.cpp:
2285         (dumpFramesAsText):
2286         (dump):
2287
2288 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
2289
2290         Reviewed by Lars.
2291
2292         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
2293         
2294
2295         * DumpRenderTree/qt/main.cpp:
2296         * DumpRenderTree/qt/testplugin.cpp:
2297         * DumpRenderTree/qt/testplugin.h:
2298
2299 2008-01-05  Mark Rowe  <mrowe@apple.com>
2300
2301         Reviewed by Alp Toker.
2302
2303         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
2304
2305         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2306         (processWork): Process pending work.
2307         (webViewLoadFinished): Schedule processing of pending work.
2308         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
2309
2310 2008-01-05  Darin Adler  <darin@apple.com>
2311
2312         * Scripts/do-webcore-rename: Some more renaming plans.
2313
2314 2008-01-04  Alice Liu  <alice.liu@apple.com>
2315
2316         Reviewed by Alexey and Darin.
2317
2318         Adding "home" and "end" to DRT's keydown since
2319         DOM key events can't handle keyIdentifiers at this point. 
2320
2321         * DumpRenderTree/mac/EventSendingController.mm:
2322         (-[EventSendingController keyDown:withModifiers:]):
2323         * DumpRenderTree/win/EventSender.cpp:
2324         (keyDownCallback):
2325
2326 2008-01-04  Lars Knoll  <lars@trolltech.com>
2327
2328         Reviewed by Simon.
2329
2330         fix DRT after the changes to QWebPage.
2331         
2332         The great thing is that we actually don't have
2333         any regressions from the QWebPage change :)
2334         
2335
2336         * DumpRenderTree/qt/DumpRenderTree.cpp:
2337         (WebCore::DumpRenderTree::DumpRenderTree):
2338
2339 2008-01-04  Lars Knoll  <lars@trolltech.com>
2340
2341         Reviewed by Simon.
2342
2343         make QWebPage a QObject and get things to compile.
2344         
2345         Nothing works currently though.
2346         
2347
2348         * DumpRenderTree/qt/DumpRenderTree.cpp:
2349         (WebCore::DumpRenderTree::DumpRenderTree):
2350
2351 2008-01-04  Lars Knoll  <lars@trolltech.com>
2352
2353         Reviewed by Simon.
2354
2355         take a QString as identifier in QWebFrame::addToJSWindowObject.
2356
2357         * DumpRenderTree/qt/DumpRenderTree.cpp:
2358         (WebCore::DumpRenderTree::initJSObjects):
2359
2360 2008-01-04  Alp Toker  <alp@atoker.com>
2361
2362         GTK+ DRT build fix for breakage introduced in r29149.
2363
2364         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2365         (LayoutTestController::execCommand):
2366
2367 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
2368
2369         Reviewed by Darin.
2370
2371         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
2372
2373         Added layoutTestController.execCommand to access editor commands that are not available
2374         via document.execCommand.
2375
2376         * DumpRenderTree/LayoutTestController.cpp:
2377         (execCommandCallback):
2378         (LayoutTestController::staticFunctions):
2379         * DumpRenderTree/LayoutTestController.h:
2380         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2381         (LayoutTestController::execCommand):
2382         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2383         (LayoutTestController::queueLoad):
2384         (LayoutTestController::execCommand):
2385
2386 2008-01-03  Alice Liu  <alice.liu@apple.com>
2387
2388         Reviewed by Darin, Mitz.
2389
2390         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
2391
2392         the clickcount should not increase if the last click was at a different location.  it's a new click.
2393
2394         * DumpRenderTree/mac/DumpRenderTree.mm:
2395         (runTest):
2396         * DumpRenderTree/mac/EventSendingController.h:
2397         * DumpRenderTree/mac/EventSendingController.mm:
2398         (-[EventSendingController mouseDown]):
2399         (-[EventSendingController mouseUp]):
2400
2401 2008-01-03  Darin Adler  <darin@apple.com>
2402
2403         Reviewed by Adam.
2404
2405         * Scripts/update-webkit: Make this work a little better for the people at Apple
2406         who have a directory named Internal.
2407
2408 2008-01-03  Adam Roben  <aroben@apple.com>
2409
2410         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
2411
2412         Rubberstamped by Mark.
2413
2414         * Scripts/update-webkit-auxiliary-libs:
2415
2416 2008-01-03  Adam Roben  <aroben@apple.com>
2417
2418         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
2419
2420         http://bugs.webkit.org/show_bug.cgi?id=15663
2421
2422         Added a fuzz factor into the Last-Modified comparison for downloading
2423         WebKitAuxiliaryLibrary.zip.
2424
2425         The zip file is served from a set of mirrors who give Last-Modified
2426         times that are off by 1-3 seconds from each other. This was causing
2427         the build bots to redownload WebKitAuxiliaryLibrary for every build,
2428         which would then cause all of WebCore to rebuild each time.
2429
2430         Reviewed by Mark.
2431
2432         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
2433         at least 30 seconds newer than the old one -- otherwise we assume that
2434         the difference in time is due to the mirrors being slightly offset
2435         from each other.
2436         (sub lastModifiedToUnixTime): Added.
2437
2438 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
2439
2440         Windows build fix.
2441
2442         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
2443
2444 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
2445
2446         Reviewed by Lars.
2447
2448         Moved QWebPage::open to QWebFrame::load and added setHtml.
2449         
2450
2451         * DumpRenderTree/qt/DumpRenderTree.cpp:
2452         (WebCore::DumpRenderTree::open):
2453
2454 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
2455
2456         Reviewed by Lars.
2457
2458         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
2459         
2460
2461         * DumpRenderTree/qt/DumpRenderTree.cpp:
2462         (WebCore::DumpRenderTree::DumpRenderTree):
2463
2464 2008-01-02  Sam Weinig  <sam@webkit.org>
2465
2466         * Scripts/do-webcore-rename: Yet more renaming ideas.
2467
2468 2008-01-02  Darin Adler  <darin@apple.com>
2469
2470         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
2471
2472 2008-01-02  Alice Liu  <alice.liu@apple.com>
2473
2474         Reviewed by Sam Weinig.
2475
2476         fixing assertion hit with editing/selection/move-begin-end.html
2477
2478         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
2479         * DumpRenderTree/win/DumpRenderTree.vcproj:
2480         * DumpRenderTree/win/EventSender.cpp:
2481         (keyDownCallback):
2482         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
2483
2484 2008-01-02  Darin Adler  <darin@apple.com>
2485
2486         * Scripts/do-webcore-rename: Some more name change plans.
2487
2488 2008-01-02  Alice Liu  <alice.liu@apple.com>
2489
2490         Reviewed by Maciej.
2491
2492         Added handling for page up and page down in EventSender
2493
2494         * DumpRenderTree/mac/EventSendingController.mm:
2495         (-[EventSendingController keyDown:withModifiers:]):
2496         * DumpRenderTree/win/EventSender.cpp:
2497         (keyDownCallback):
2498
2499 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
2500
2501         Reviewed by Darin.
2502
2503         Fix fast/events/arrow-keys-on-body.html for real.
2504
2505         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
2506
2507 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
2508
2509         Reviewed by Darin.
2510
2511         http://bugs.webkit.org/show_bug.cgi?id=16674
2512         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
2513
2514         * Scripts/run-launcher:
2515
2516 2007-12-31  Darin Adler  <darin@apple.com>
2517
2518         Suggested by Antti.
2519
2520         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
2521         we get it installed on the build bots.
2522
2523 2007-12-30  Eric Seidel  <eric@webkit.org>
2524
2525         Reviewed by Sam.
2526
2527         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
2528
2529 2007-12-29  Darin Adler  <darin@apple.com>
2530
2531         Reviewed by Oliver.
2532
2533         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
2534           leak bot shows createCStringFromNPVariant result leaking
2535
2536         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2537         (pluginInvoke): Added a missing free.
2538
2539 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
2540
2541         Reviewed by Alp Toker.
2542
2543         http://bugs.webkit.org/show_bug.cgi?id=16390
2544         Use autotools or GNU make as the build system for the GTK port
2545
2546         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
2547         * GNUmakefile.am: Added.
2548
2549 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
2550
2551         Reviewed by Oliver.
2552
2553         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
2554
2555         * DumpRenderTree/win/EventSender.cpp:
2556         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
2557         of 1, even though WebKit currently ignores it.
2558
2559 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
2560
2561         wx buildbot fix. Update libpng dl script to the latest version.
2562
2563         * wx/install-unix-extras:
2564
2565 2007-12-22  Antti Koivisto  <antti@apple.com>
2566
2567         Fix a typo.
2568
2569         * Scripts/webkitdirs.pm:
2570
2571 2007-12-21  Sam Weinig  <sam@webkit.org>
2572
2573         Reviewed by Mark Rowe.
2574
2575         - Disable the back/forward cache using the new WebPreferences API
2576           instead of through the BackForwardList.  This makes us match what
2577           we do on Windows.
2578
2579         * DumpRenderTree/mac/DumpRenderTree.mm:
2580         (createWebViewAndOffscreenWindow):
2581         (setDefaultsToConsistentValuesForTesting):
2582
2583 2007-12-21  Dan Bernstein  <mitz@apple.com>
2584
2585         Reviewed by Mark Rowe.
2586
2587         - disable the back/forward cache in Windows DumpRenderTree. It is
2588           already disabled in Mac DumpRenderTree.
2589
2590         * DumpRenderTree/win/DumpRenderTree.cpp:
2591         (initializePreferences):
2592
2593 2007-12-13  Antti Koivisto  <antti@apple.com>
2594
2595         Reviewed by Darin and Steve.
2596         
2597         - check for QuickTime SDK on Windows.
2598         - build media support on Windows by default
2599
2600         * Scripts/build-webkit:
2601         * Scripts/webkitdirs.pm:
2602
2603 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
2604
2605         Build script fix for buildbot.
2606
2607         * wx/build-wxwebkit:
2608
2609 2007-12-20  Eric Seidel  <eric@webkit.org>
2610
2611         Reviewed by mjs.
2612
2613         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
2614
2615 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
2616
2617         Reviewed by Steve.
2618
2619         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
2620         WebKit.
2621
2622         - Drosera and Safari need to use the same ProgIDs in order for
2623         CoCreateInstance to work properly.  The most robust way to do this is
2624         for WebKit to dynamically publish those ProgIDs.
2625
2626         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
2627         (DebuggerClient::createWebViewWithRequest):
2628         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
2629         statics.
2630         (Drosera::initUI):
2631         (Drosera::attach):
2632         (Drosera::attemptToCreateServerConnection):
2633         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
2634         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
2635         make use of the published ProgIDs.
2636         (ServerConnection::attemptToCreateServerConnection):
2637
2638 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
2639
2640         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
2641         - Build bot and leak fix.
2642
2643         * DumpRenderTree/LayoutTestController.cpp:
2644         (pathToLocalResourceCallback):
2645
2646 2007-12-19  David Kilzer  <ddkilzer@apple.com>
2647
2648         Make svn-apply/svn-unapply work with patches from git-format-patch.
2649
2650         Reviewed by Darin.
2651
2652         * Scripts/svn-apply:
2653         (patch): If 'Index:' can't be found in the text passed in, print it
2654         out with a warning and return early.
2655         * Scripts/svn-unapply:
2656         (patch): Ditto.
2657
2658 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
2659
2660         Reviewed by Alp Toker.
2661
2662         Build related fixes.
2663
2664         * wx/build-wxwebkit:
2665         - Check to make sure the user is running a supported wx port
2666         - More robust checks for Cygwin
2667         - Only run install-unix-extras on Mac, it's not the right solution
2668           for Linux distros.
2669         - Remove outdated Linux instructions after successful build
2670         - Clean Bakefile-generated files during a clean operation
2671
2672 2007-12-18  Darin Adler  <darin@apple.com>
2673
2674         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
2675
2676 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
2677
2678         Add script to run Drosera as part of the nightly.
2679         
2680         Reviewed by Kevin M.
2681
2682         * Scripts/run-drosera.cmd: Added.
2683
2684 2007-12-18  Darin Adler  <darin@apple.com>
2685
2686         * Scripts/do-webcore-rename: Remove a stray K.
2687
2688 2007-12-18  Darin Adler  <darin@apple.com>
2689
2690         * Scripts/do-webcore-rename: Plan more renaming.
2691
2692 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
2693
2694         Reviewed by Alp Toker.
2695
2696         http://bugs.webkit.org/show_bug.cgi?id=16042
2697         [GTK] Eliminate webkit_init()
2698
2699         Moving webkit initialization to WebView class init.
2700
2701         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2702         (main):
2703         * GtkLauncher/main.c:
2704         (main):
2705
2706 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
2707
2708         Reviewed by Alp Toker.
2709
2710         http://bugs.webkit.org/show_bug.cgi?id=13542
2711         gdklauncher doesnt change URL in adress GTKEntry.
2712
2713         * GtkLauncher/main.c:
2714         (load_commit_cb): added
2715         (title_change_cb):
2716         (create_browser):
2717
2718 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
2719
2720         Reviewed by Adam Roben.
2721
2722         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
2723
2724         * FindSafari/FindSafari.cpp:
2725         (_tmain):
2726
2727 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
2728
2729         Reviewed by Adam Roben.
2730
2731         http://bugs.webkit.org/show_bug.cgi?id=16315
2732         FindSafari needs a path-only option.
2733
2734         * FindSafari/FindSafari.cpp:
2735         (_tmain):
2736
2737 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
2738
2739         Reviewed by Darin.
2740
2741         http://bugs.webkit.org/show_bug.cgi?id=16462
2742         REGRESSION: access keys broken on Windows
2743
2744         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
2745         if Alt is pressed.
2746
2747 2007-12-15  Sam Weinig  <sam@webkit.org>
2748
2749         Reviewed by Mark Rowe.
2750
2751         Fix urlSuitableForTestResult to correctly identify wstring::npos as
2752         the case when wstring.find doesn't find anything.
2753
2754         * DumpRenderTree/win/DumpRenderTree.cpp:
2755         (urlSuitableForTestResult):
2756
2757 2007-12-15  Alp Toker  <alp@atoker.com>
2758
2759         GTK+ DRT build fix for GLib < 2.14.
2760
2761         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2762         (LayoutTestController::setWaitToDump):
2763
2764 2007-12-05  Mark Rowe  <mrowe@apple.com>
2765
2766         Reviewed by Alp Toker.
2767
2768         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
2769         many layout tests from hanging while waiting on user responses to dialogs.
2770
2771         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2772         (invalidateAnyPreviousWaitToDumpWatchdog):
2773         (webViewScriptAlert):
2774         (webViewScriptPrompt):
2775         (webViewScriptConfirm):
2776         (main):
2777         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
2778         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2779         (waitToDumpWatchdogFired):
2780         (LayoutTestController::setWaitToDump):
2781
2782 2007-12-05  Mark Rowe  <mrowe@apple.com>
2783
2784         Reviewed by Alp Toker.
2785
2786         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
2787
2788         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2789         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
2790         (dump):
2791         (runTest):
2792         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
2793         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
2794         work queue is empty.
2795         (webViewWindowObjectCleared): Set up window.layoutTestController.
2796         (webViewConsoleMessage): Match the console message format expected by the layout test results.
2797         (main): Hook up the new signals.
2798         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
2799         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
2800         dumping multiple times.
2801         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
2802         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
2803
2804 2007-12-14  Anders Carlsson  <andersca@apple.com>
2805
2806         Reviewed by Brady.
2807
2808         Assert that a web frame that's loading a resource always has either a data source or 
2809         a provisional data source.
2810         
2811         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2812         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2813
2814 2007-12-14  Darin Adler  <darin@apple.com>
2815
2816         - fix mistake causing nearly all tests to fail on Windows
2817
2818         * DumpRenderTree/win/UIDelegate.cpp:
2819         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
2820         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
2821
2822         * DumpRenderTree/mac/UIDelegate.mm:
2823         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
2824         than passing the entire message.
2825
2826 2007-12-14  Darin Adler  <darin@apple.com>
2827
2828         - fix Tiger build
2829
2830         * DumpRenderTree/mac/UIDelegate.mm:
2831         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
2832         new-to-Leopard methods.
2833
2834 2007-12-14  Darin Adler  <darin@apple.com>
2835
2836         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
2837         since it now triggers unwanted icon loading. We only had it because we implemented "all"
2838         delegate methods here.
2839
2840 2007-12-14  Anders Carlsson  <andersca@apple.com>
2841
2842         Reviewed by Darin and Geoff.
2843
2844         <rdar://problem/5619295> 
2845         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
2846         
2847         Add property getting methods to the plug-in.
2848         
2849         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2850         (pluginInvoke):
2851
2852 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
2853
2854         Reviewed by Darin.
2855
2856         - Layout test fix for mac. When dumped to the console local file paths
2857         now only show the name of the resource not the whole path.  This is to
2858         make the results machine and OS independent.
2859
2860         * DumpRenderTree/mac/UIDelegate.mm:
2861         (-[UIDelegate webView:addMessageToConsole:]):
2862
2863 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
2864
2865         Reviewed by Adam.
2866
2867         - Layout tests fix.  We need a way to remove machine-dependent
2868         information from paths in layout test results. The UIDelegate now does
2869         this.
2870
2871         * DumpRenderTree/DumpRenderTree.h:
2872         * DumpRenderTree/win/DumpRenderTree.cpp:
2873         (urlSuitableForTestResult):
2874         * DumpRenderTree/win/DumpRenderTreeWin.h:
2875         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2876         * DumpRenderTree/win/UIDelegate.cpp:
2877         (UIDelegate::webViewAddMessageToConsole):
2878
2879 2007-12-13  Alp Toker  <alp@atoker.com>
2880
2881         Build fix for DRT breakage introduced in r28690.
2882
2883         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2884         (LayoutTestController::pathToLocalResource):
2885
2886 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
2887
2888         Reviewed by Alice and Sam.
2889
2890         - <rdar://5621435> Need a way to specify local resources (being loaded
2891         from HTTP tests) on Windows.
2892         - Implemented pathToLocalResource which exposes the functionality of
2893         converting a given unix path to the correct location on Windows.
2894
2895         * DumpRenderTree/LayoutTestController.cpp:
2896         (pathToLocalResourceCallback):
2897         (LayoutTestController::staticFunctions):
2898         * DumpRenderTree/LayoutTestController.h:
2899         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2900         (LayoutTestController::pathToLocalResource):
2901         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2902         (LayoutTestController::pathToLocalResource):
2903
2904 2007-12-12  Anders Carlsson  <andersca@apple.com>
2905
2906         Reviewed by Sam.
2907
2908         <rdar://problem/5132003>
2909         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
2910
2911         * DumpRenderTree/win/DumpRenderTree.cpp:
2912         (main):
2913         Set the resource load delegate.
2914         
2915         * DumpRenderTree/win/DumpRenderTree.vcproj:
2916         
2917         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
2918         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
2919
2920 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
2921
2922         Reviewed by Adam Roben.
2923
2924         Fix conversion from double to LPARAM in dispatchMessage().
2925
2926         * DumpRenderTree/win/EventSender.cpp:
2927         (dispatchMessageCallback):
2928
2929 2007-12-11  Dan Bernstein  <mitz@apple.com>
2930
2931         Reviewed by Mark Rowe and Sam Weinig too!
2932
2933         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
2934           fonts DumpRenderTree registers.
2935
2936         * DumpRenderTree/win/DumpRenderTree.cpp:
2937         (initialize):
2938
2939 2007-12-11  Brady Eidson  <beidson@apple.com>
2940
2941         Reviewed by Anders
2942
2943         Make DumpRenderTree on mac use its own path for Databases testing
2944
2945         * DumpRenderTree/mac/DumpRenderTree.mm:
2946         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
2947           for future DRT-only use, then use it to construct the Databases path and set that default
2948
2949 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
2950
2951         Reviewed by Darin.
2952
2953         <rdar://problem/5535636>
2954         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
2955
2956         http://bugs.webkit.org/show_bug.cgi?id=13916
2957         JavaScript detects Tab as a character input on a textfield validation
2958
2959         * DumpRenderTree/mac/EventSendingController.mm:
2960         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
2961         Dispatch a keyup to better match what happens when a key is physically pressed.
2962
2963         * DumpRenderTree/win/EventSender.cpp:
2964         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
2965         returning from keyDown().
2966         (getConstantCallback): Fixed a couple copy/paste mistakes.
2967
2968 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
2969
2970         Reviewed by Oliver.
2971
2972         - <rdar://5599845> Drosera: Does not show loal files in the file list
2973         on the left side.
2974
2975         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
2976         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
2977         so the open source community can build.
2978
2979 2007-12-10  Brady Eidson  <beidson@apple.com>
2980
2981         Rubberstamped by Sam Weinig
2982
2983         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
2984
2985         * DumpRenderTree/mac/UIDelegate.mm:
2986         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
2987         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
2988
2989 2007-12-08  Oliver Hunt  <oliver@apple.com>
2990
2991         Reviewed by Sam W.
2992
2993         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
2994         
2995         Fixes <rdar://problem/5620249> Must disable SVG animation
2996         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
2997         
2998         In order to allow finer grained control over the set of SVG features
2999         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
3000         distinct flags:
3001         ENABLE_SVG_ANIMATION
3002         ENABLE_SVG_FILTERS
3003         ENABLE_SVG_FONTS
3004         ENABLE_SVG_AS_IMAGE
3005         ENABLE_SVG_USE
3006         
3007         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
3008         
3009         Script handles all the new build flags, and allows --svg-experimental
3010         to automatically enable all features.
3011
3012         * Scripts/build-webkit:
3013
3014 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
3015
3016         Fix version parsing.
3017
3018         Rubber-stamped by Oliver.
3019
3020         * Drosera/win/Drosera.vcproj/auto-version.sh:
3021
3022 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
3023
3024         Build modifications for Drosera.
3025
3026         Reviewed by Adam.
3027
3028         * Drosera/DroseraWin.make: Added.
3029         * Drosera/win/Drosera.vcproj/Drosera.rc:
3030         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3031         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
3032         * Drosera/win/Drosera.vcproj/VERSION: Added.
3033         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
3034
3035 2007-12-06  Adam Roben  <aroben@apple.com>
3036
3037         Explicitly turn on the Mac font ascent hack on Windows
3038
3039         This keeps our font metrics matching those from Mac.
3040
3041         Reviewed by Hyatt.
3042
3043         * DumpRenderTree/win/DumpRenderTree.cpp:
3044         (main):
3045
3046 2007-12-06  Anders Carlsson  <andersca@apple.com>
3047
3048         Rename main.c to main.cpp here too.
3049         
3050         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
3051
3052 2007-12-06  Sam Weinig  <sam@webkit.org>
3053
3054         Rubber stamped by Geoff.
3055
3056         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
3057
3058 2007-12-06  Darin Adler  <darin@apple.com>
3059
3060         * Scripts/do-webcore-rename: Some more renaming plans.
3061
3062 2007-12-06  Anders Carlsson  <andersca@apple.com>
3063
3064         Restore implementation of testGetIntIdentifier that was accidentally
3065         removed somehow (possibly when I made PluginObject be a cpp file).
3066         
3067         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3068         (pluginInvoke):
3069
3070 2007-12-05  Anders Carlsson  <andersca@apple.com>
3071
3072         Make the entry points extern "C".
3073         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3074         
3075 2007-12-05  Anders Carlsson  <andersca@apple.com>
3076
3077         C++ warning fixes.
3078         
3079         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3080         (NPP_New):
3081         (NPP_Destroy):
3082         (NPP_SetWindow):
3083         (NPP_NewStream):
3084         (NPP_HandleEvent):
3085         (NPP_URLNotify):
3086         (NPP_GetValue):
3087
3088 2007-12-05  Anders Carlsson  <andersca@apple.com>
3089
3090         Add the .cpp files to the TestNetscapePlugIn target.
3091
3092         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3093
3094 2007-12-05  Anders Carlsson  <andersca@apple.com>
3095
3096         Reviewed by Geoff.
3097         
3098         Rename the TestNetscapePlugIn .c files to be .cpp.
3099
3100         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3101         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
3102         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
3103         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
3104         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
3105         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
3106         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
3107         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3108
3109 2007-12-05  Adam Roben  <aroben@apple.com>
3110
3111         Fix case of keypresses from the Windows implementation of eventSender.keyDown
3112
3113         This fixes several regression tests.
3114
3115         Reviewed by Alice.
3116
3117         * DumpRenderTree/win/EventSender.cpp:
3118         (keyDownCallback): Virtual keycodes for ASCII characters are always
3119         uppercase, so we need to check the case of the original character
3120         passed in to eventSender.keyDown.
3121
3122 2007-12-05  Adam Roben  <aroben@apple.com>
3123
3124         Learn from Tim's mistakes
3125
3126         * DumpRenderTree/win/DumpRenderTree.cpp:
3127         (runTest): Reset the authorAndUserStylesEnabled preference for each
3128         test.
3129
3130 2007-12-05  Alp Toker  <alp@atoker.com>
3131
3132         Reviewed by Mark Rowe.
3133
3134         Initialize GTK+ and WebKit so the tests can run.
3135
3136         Reorganize the headers a little.
3137
3138         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3139         (main):
3140
3141 2007-12-04  Anders Carlsson  <andersca@apple.com>
3142
3143         Remove IWebScriptScope include.
3144         
3145         * Drosera/win/DebuggerDocumentPlatform.cpp:
3146
3147 2007-12-04  Sam Weinig  <sam@webkit.org>
3148
3149         Rubber stamped by Mark Rowe.
3150
3151         Define CF as platform for mac and revert r28409
3152
3153         * DumpRenderTree/DumpRenderTree.h:
3154         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3155
3156 2007-12-04  Sam Weinig  <sam@webkit.org>
3157
3158         Define CF as platform for windows.
3159
3160         Reviewed by Adam Roben.
3161
3162         * DumpRenderTree/win/DumpRenderTreeWin.h:
3163
3164 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
3165
3166         Reviewed by Adam and Darin.
3167
3168         - Removed a needless BSTR cleanup.
3169
3170         * Drosera/win/DebuggerDocumentPlatform.cpp:
3171         (DebuggerDocument::getPlatformCurrentFunctionStack):
3172
3173 2007-11-27  Adam Roben  <aroben@apple.com>
3174
3175         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
3176
3177         Reviewed by Maciej.
3178
3179         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3180         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
3181
3182 2007-12-04  Alp Toker  <alp@atoker.com>
3183
3184         Prospective Win DRT build fix.
3185
3186         * DumpRenderTree/DumpRenderTree.h:
3187
3188 2007-12-04  Alp Toker  <alp@atoker.com>
3189
3190         Fix a clobbered copyright header.
3191
3192         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3193
3194 2007-12-04  Xan Lopez  <xan@gnome.org>
3195
3196         Reviewed by Alp Toker.
3197
3198         http://bugs.webkit.org/show_bug.cgi?id=15561
3199         GTK port needs DumpRenderTree implementation
3200
3201         Start work on the GTK+ DRT.
3202
3203         This does not work yet, and there are a few lingering style issues
3204         (nothing major) but this patch has been stuck in the bug tracker for
3205         too long already.
3206
3207         * DumpRenderTree/DumpRenderTree.h:
3208         * DumpRenderTree/gtk: Added.
3209         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
3210         (autocorrectURL):
3211         (shouldLogFrameLoadDelegates):
3212         (dumpFrameScrollPosition):
3213         (displayWebView):
3214         (appendString):
3215         (dumpFramesAsText):
3216         (dumpRenderTreeAsText):
3217         (dump):
3218         (runTest):
3219         (main):
3220         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
3221         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
3222         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
3223         (GCController::collect):
3224         (GCController::collectOnAlternateThread):
3225         (GCController::getJSObjectCount):
3226         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
3227         (LayoutTestController::~LayoutTestController):
3228         (LayoutTestController::addDisallowedURL):
3229         (LayoutTestController::clearBackForwardList):
3230         (LayoutTestController::copyDecodedHostName):
3231         (LayoutTestController::copyEncodedHostName):
3232         (LayoutTestController::display):
3233         (LayoutTestController::keepWebHistory):
3234         (LayoutTestController::notifyDone):
3235         (LayoutTestController::queueBackNavigation):
3236         (LayoutTestController::queueForwardNavigation):
3237         (LayoutTestController::queueLoad):
3238         (LayoutTestController::queueReload):
3239         (LayoutTestController::queueScript):
3240         (LayoutTestController::setAcceptsEditing):
3241         (LayoutTestController::setCustomPolicyDelegate):
3242         (LayoutTestController::setMainFrameIsFirstResponder):
3243         (LayoutTestController::setTabKeyCyclesThroughElements):
3244         (LayoutTestController::setUseDashboardCompatibilityMode):
3245         (LayoutTestController::setUserStyleSheetEnabled):
3246         (LayoutTestController::setUserStyleSheetLocation):
3247         (LayoutTestController::setWindowIsKey):
3248         (LayoutTestController::setWaitToDump):
3249         (LayoutTestController::windowCount):
3250         (LayoutTestController::setPrivateBrowsingEnabled):
3251         (LayoutTestController::setAuthorAndUserStylesEnabled):
3252         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
3253         (JSStringCopyUTF8CString):
3254         (LoadItem::invoke):
3255         (ReloadItem::invoke):
3256         (ScriptItem::invoke):
3257         (BackForwardItem::invoke):
3258
3259 2007-12-03  Sam Weinig  <sam@webkit.org>
3260
3261         Move JavaScriptCore thread testing code to pthread specific directory
3262         and remove the dependance on CoreFoundation by using WTF::HashSet.
3263
3264         Reviewed by Geoff and Oliver.
3265
3266         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3267         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
3268         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
3269         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
3270         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
3271         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
3272         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
3273         * DumpRenderTree/pthreads: Added.
3274         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
3275         (javaScriptThreads):
3276         (runJavaScriptThread):
3277         (startJavaScriptThreads):
3278         (stopJavaScriptThreads):
3279
3280 2007-12-03  Andrew Bonventre  <andybons@google.com>
3281
3282         Reviewed by Darin Adler.
3283
3284         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
3285         Symbol lookup menu broken in debugger view
3286
3287         * Drosera/debugger.js: Fixed javascript error where document property
3288         should have been used instead of contentDocument in switchFunction that
3289         was breaking the select symbol dropdown menu.  This is because
3290         window.frames will return a Window object and not a frame object like
3291         the author was originally expecting.
3292
3293 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
3294
3295         Reviewed by Adam.
3296
3297         - <rdar://5618942> Drosera: Console window does not process everything
3298         correctly.
3299         - <rdar://5619005> Drosera: could be sped up by moving the 
3300         WebScriptScope stuff into the WebScriptCallFrame.
3301         - Now the console can correctly process objects and does not receive
3302         notifications from JavaScriptCore about the JavaScript in Drosera's
3303         own process.
3304
3305         * Drosera/win/DebuggerDocumentPlatform.cpp:
3306         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3307         (DebuggerDocument::platformValueForScopeVariableNamed):
3308
3309 2007-12-03  Stephanie  <slewis@apple.com>
3310
3311         Reviewed by Darin.
3312
3313         Check to see if we are building a debug root
3314
3315         * Scripts/check-for-global-initializers: 
3316
3317 2007-12-03  Dan Bernstein  <mitz@apple.com>
3318
3319         Reviewed by Darin Adler.
3320
3321         - added a testGetIntIdentifier() method to TestNetscapePlugIn
3322
3323         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
3324         (pluginInvoke):
3325
3326 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
3327
3328         Reviewed by Oliver.
3329
3330         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
3331         in a more fine-grained manner than eventSender.keyDown().
3332
3333         * DumpRenderTree/win/EventSender.cpp:
3334         (getConstantCallback):
3335         (dispatchMessageCallback):
3336
3337 2007-12-02  Darin Adler  <darin@apple.com>
3338
3339         * Scripts/do-webcore-rename: More planned renaming.
3340
3341 2007-12-02  Sam Weinig  <sam@webkit.org>
3342
3343         Rubber stamped by Anders.
3344
3345         Use [NSURL absoluteString] instead of [NSURL description] in order to get
3346         more uniform results cross platform.
3347
3348         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3349         (-[NSURL _drt_descriptionSuitableForTestResult]):
3350
3351 2007-12-02  Sam Weinig  <sam@webkit.org>
3352
3353         Rubber stamped by Niko.
3354
3355         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
3356
3357         * DumpRenderTree/win/DumpRenderTree.cpp:
3358         * DumpRenderTree/win/DumpRenderTree.vcproj:
3359         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
3360         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
3361         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
3362         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
3363
3364 2007-12-01  Alp Toker  <alp@atoker.com>
3365
3366         Reviewed by Adam Roben.
3367
3368         Make use of the newly introduced webkit.h convenience header.
3369
3370         * GtkLauncher/main.c:
3371
3372 2007-12-01  Adam Treat  <treat@kde.org>
3373
3374         Reviewed by Simon.
3375
3376         * Check to see if the directory exists and exit if not.
3377
3378         * DumpRenderTree/qt/main.cpp:
3379         (main):
3380
3381 2007-12-01  Adam Treat  <treat@kde.org>
3382
3383         Reviewed by Simon.
3384
3385         * Don't hide symbols when in Debug mode
3386         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
3387
3388
3389         * DumpRenderTree/qt/main.cpp:
3390         (messageHandler):
3391
3392 2007-11-30  Alp Toker  <alp@atoker.com>
3393
3394         Reviewed by Adam Roben.
3395
3396         http://bugs.webkit.org/show_bug.cgi?id=15691
3397         [GTK] Public API does not follow GTK+ conventions
3398
3399         Refactor the WebKit/GTK+ public API. Changes:
3400           WebKitPage -> WebKitWebView
3401           WebKitFrame -> WebKitWebFrame
3402
3403         Public API source and header names have been updated to mirror the API
3404         changes.
3405
3406         The API is now kept in WebKit/gtk/WebView to match other ports in the
3407         same class such as Mac and Win.
3408
3409         * GtkLauncher/main.c:
3410         (activate_uri_entry_cb):
3411         (link_hover_cb):
3412         (title_change_cb):
3413         (progress_change_cb):
3414         (go_back_cb):
3415         (go_forward_cb):
3416         (create_browser):
3417         (main):
3418
3419 2007-11-30  Adam Roben  <aroben@apple.com>
3420
3421         Hopefully the final build fix
3422
3423         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
3424         pull in WTF's assertion/logging functions.
3425
3426 2007-11-30  Adam Roben  <aroben@apple.com>
3427
3428         Another build fix
3429
3430         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
3431         WebKit.lib.
3432
3433 2007-11-30  Adam Roben  <aroben@apple.com>
3434
3435         Debug build fix
3436
3437         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
3438         configuration.
3439         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
3440         projects.
3441         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
3442         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
3443         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
3444
3445 2007-11-30  Sam Weinig  <sam@webkit.org>
3446
3447         Reviewed by Adam Roben.
3448
3449         Fix drawSelectionRect to actually draw the selection rect.
3450
3451         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3452         (drawSelectionRect):
3453
3454 2007-11-30  Darin Adler  <darin@apple.com>
3455
3456         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
3457
3458 2007-11-30  Darin Adler  <darin@apple.com>
3459
3460         * Scripts/do-webcore-rename: Get ready for some future renaming.
3461
3462 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
3463
3464         Reviewed by Adam.
3465
3466         - Removed some unnecessary functions and changed an unused return type. 
3467
3468         * Drosera/win/DebuggerClient.cpp:
3469         (registerConsoleClass):
3470         * Drosera/win/DebuggerClient.h:
3471         * Drosera/win/Drosera.cpp:
3472         (registerDroseraClass):
3473
3474 2007-11-28  Alp Toker  <alp@atoker.com>
3475
3476         Reviewed by Timothy Hatcher.
3477
3478         http://bugs.webkit.org/show_bug.cgi?id=16174
3479         [GTK] Use "URI" not "URL" in public API
3480
3481         Replace use of the term "URL" with "URI" in public headers,
3482         documentation and some internal code to match GLib/GTK+ convention.
3483
3484         This is now mentioned in the API guidelines:
3485           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
3486
3487         * GtkLauncher/main.c:
3488         (activate_uri_entry_cb):
3489         (title_change_cb):
3490         (create_toolbar):
3491         (main):
3492
3493 2007-11-29  Anders Carlsson  <andersca@apple.com>
3494
3495         Reviewed by Sam.
3496
3497         <rdar://problem/5230478>
3498         FrameLoadDelegate callbacks are not dumped in DRT.
3499         
3500         * DumpRenderTree/win/DumpRenderTree.cpp:
3501         (shouldLogFrameLoadDelegates):
3502         (runTest):
3503         (main):
3504         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
3505         (BSTRtoString):
3506         (descriptionSuitableForTestResult):
3507         (FrameLoadDelegate::QueryInterface):
3508         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
3509         (FrameLoadDelegate::didFailProvisionalLoadWithError):
3510         (FrameLoadDelegate::didCommitLoadForFrame):
3511         (FrameLoadDelegate::didFinishLoadForFrame):
3512         (FrameLoadDelegate::willCloseFrame):
3513         (FrameLoadDelegate::didClearWindowObject):
3514         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
3515         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
3516         * DumpRenderTree/win/FrameLoaderDelegate.h:
3517         (FrameLoadDelegate::windowScriptObjectAvailable):
3518         (FrameLoadDelegate::didFirstLayoutInFrame):
3519
3520 2007-11-29  Sam Weinig  <sam@webkit.org>
3521
3522         Reviewed by Anders.
3523
3524         Add database quota UIDelegates methods to DRT UIDelegate.
3525
3526         * DumpRenderTree/mac/UIDelegate.mm:
3527         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
3528         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
3529
3530 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
3531
3532         Reviewed by Sam.
3533
3534         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
3535         dying and vice versa.
3536         - This fix will allow Drosera and Safari to reconnect if either of them
3537         closes correctly, but does not fix the case where one of them dies
3538         silently.
3539
3540         * Drosera/win/ServerConnection.cpp:
3541         (ServerConnection::attemptToCreateServerConnection): Added a safety
3542         check, because it's possilbe to try to connect to a server that's dying.
3543         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
3544         the server has died.
3545         * Drosera/win/ServerConnection.h: Added the new function and removed
3546         an unnecessary member.
3547
3548 2007-11-29  Anders Carlsson  <andersca@apple.com>
3549
3550         * DumpRenderTree/win/DumpRenderTree.vcproj:
3551         Add shlwapi.lib to all configurations.
3552
3553 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
3554
3555         - Build fix.  Added additional includes for VS Express to the Release
3556         project.
3557
3558         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3559
3560 2007-11-29  Anders Carlsson  <andersca@apple.com>
3561
3562         Reviewed by Adam.
3563
3564         <rdar://problem/5132005>
3565         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
3566         
3567         * DumpRenderTree/win/DumpRenderTree.vcproj:
3568         Add shlwapi.lib
3569         
3570         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3571         (LayoutTestController::setUserStyleSheetEnabled):
3572         Implement this.
3573         
3574         (appendComponentToPath):
3575         New method which wraps the Win32 API PathAppend.
3576         
3577         (followShortcuts):
3578         New method which checks if a file points to a shortcut and
3579         follows the shortcut.
3580         
3581         (resolveCygwinPath):
3582         New method that takes a cygwin unix-style path and returns the Win32 path.
3583         
3584         (cfStringRefToWString):
3585         
3586         (LayoutTestController::setUserStyleSheetLocation):
3587         Implement this.
3588
3589 2007-11-29  Alice Liu  <alice.liu@apple.com>
3590
3591         Reviewed by Adam.
3592
3593         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
3594
3595         * DumpRenderTree/win/EventSender.cpp:
3596         (keyDownCallback):
3597         uppercase letters were being sent as lowercase letters without the shift key down.
3598
3599 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
3600
3601         - Windows build fix. VS express needs some love.
3602
3603         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3604
3605 2007-11-28  Darin Adler  <darin@apple.com>
3606
3607         Reviewed by Adam Roben.
3608
3609         * DumpRenderTree/mac/EventSendingController.mm:
3610         (-[EventSendingController keyDown:withModifiers:]):
3611         Send capital letters through as lowercase letters with the shift key down
3612         rather than sending them as if they were highly unusual "capital letter keys".
3613
3614         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
3615         where you need to update results and more tests are failing than before.
3616
3617 2007-11-28  Anders Carlsson  <andersca@apple.com>
3618
3619         Reviewed by Darin.
3620
3621         <rdar://problem/5132001>
3622         contextClick is not implemented in DRT on Windows.
3623         
3624         * DumpRenderTree/win/EventSender.cpp:
3625         (contextClickCallback):
3626         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
3627         by a WM_RBUTTONUP message.
3628         
3629         * DumpRenderTree/win/UIDelegate.cpp:
3630         (UIDelegate::hasCustomMenuImplementation):
3631         (UIDelegate::trackCustomPopupMenu):
3632         * DumpRenderTree/win/UIDelegate.h:
3633         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
3634         menu from being shown (and causing the DRT to hang).
3635
3636 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
3637
3638         Reviewed by Darin.
3639
3640         Fix DumpRenderTree ObjC bug comparing strings.
3641
3642         * DumpRenderTree/mac/ObjCController.m:
3643         (-[ObjCController identityIsEqual::]): Compare strings with string
3644         equality instead of identiy equality.
3645
3646 2007-11-27  Timothy Hatcher  <timothy@apple.com>
3647
3648         Reviewed by Sam.
3649
3650         Reset the authorAndUserStylesEnabled preference
3651         back to YES for each test. Fixes the broken tests.
3652
3653         * DumpRenderTree/mac/DumpRenderTree.mm:
3654         (resetWebViewToConsistentStateBeforeTesting):
3655
3656 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
3657
3658         Reviewed by Adam.
3659
3660         - Drosera now displays the console window, although it cannot currently
3661         process JavaScript.
3662
3663         * Drosera/win/DebuggerClient.cpp: Shows the console window.
3664         (registerConsoleClass): Implemented.
3665         (consoleWndProc): Implemented.
3666         (DebuggerClient::onSize): Implemented.
3667         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
3668         new window.
3669         * Drosera/win/DebuggerClient.h: Added needed method and members for 
3670         creating and maintaining a new window.
3671         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
3672         lines of code to more appropriate places.
3673         (Drosera::handleCommand):
3674         (Drosera::initUI):
3675         (Drosera::onSize):
3676         (Drosera::attach):
3677
3678 2007-11-27  Timothy Hatcher  <timothy@apple.com>
3679
3680         Reviewed by Dave Hyatt.
3681
3682         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
3683         
3684         Add support for disabling author and user styles for testing.
3685
3686         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3687         * DumpRenderTree/LayoutTestController.cpp:
3688         (setAuthorAndUserStylesEnabledCallback):
3689         (LayoutTestController::staticFunctions):
3690         * DumpRenderTree/LayoutTestController.h:
3691         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3692         (LayoutTestController::setAuthorAndUserStylesEnabled):
3693         * DumpRenderTree/win