2009-11-20 Adam Barth <abarth@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-20  Adam Barth  <abarth@webkit.org>
2
3         Reviewed by Eric Seidel.
4
5         Create LandingSequence as the all-sing, all-dance landing class
6         https://bugs.webkit.org/show_bug.cgi?id=31709
7
8         Client can inherit from this class to carefully control exactly which
9         steps they wish to have happen in the landing sequence.
10
11         * Scripts/bugzilla-tool:
12         * Scripts/modules/landingsequence.py: Added.
13         * Scripts/modules/webkitlandingscripts.py: Added.
14
15 2009-11-19  Adam Barth  <abarth@webkit.org>
16
17         Reviewed by Eric Seidel.
18
19         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
20         https://bugs.webkit.org/show_bug.cgi?id=31707
21
22         This is to help when we implement build-attachment.
23
24         * Scripts/bugzilla-tool:
25
26 2009-11-19  Adam Barth  <abarth@webkit.org>
27
28         Reviewed by Eric Seidel.
29
30         Support Qt port in bugzilla-tool
31         https://bugs.webkit.org/show_bug.cgi?id=31701
32
33         Now we support building with Qt!
34
35         * Scripts/bugzilla-tool:
36         * Scripts/modules/webkitport.py: Added.
37         * Scripts/modules/webkitport_unittest.py: Added.
38         * Scripts/run-webkit-unittests:
39
40 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
41
42         Reviewed by Adam Barth.
43
44         Remove inserting stderr into patch in bugzilla-tool
45         https://bugs.webkit.org/show_bug.cgi?id=29914
46
47         Modify SCM python module's run_command function to avoid return of stderr
48         by default, so stderr won't be inserted into the patches.
49         Modify the related unit test.
50
51         * Scripts/modules/scm.py:
52         * Scripts/modules/scm_unittest.py:
53
54 2009-11-19  Eric Seidel  <eric@webkit.org>
55
56         Reviewed by Adam Barth.
57
58         bugzilla-tool needs per-command help
59         https://bugs.webkit.org/show_bug.cgi?id=31697
60
61         Added support for "bugzilla-tool help command-name"
62         and a unit test to make sure it works.
63
64         * Scripts/modules/multicommandtool.py:
65         * Scripts/modules/multicommandtool_unittest.py:
66
67 2009-11-19  Eric Seidel  <eric@webkit.org>
68
69         Reviewed by Adam Barth.
70
71         Move MultiCommandTool and Command into a separate file and add some basic unit tests
72         https://bugs.webkit.org/show_bug.cgi?id=31695
73
74         * Scripts/bugzilla-tool:
75         * Scripts/modules/multicommandtool.py: Added.
76         * Scripts/modules/multicommandtool_unittest.py: Added.
77         * Scripts/run-webkit-unittests:
78
79 2009-11-19  Eric Seidel  <eric@webkit.org>
80
81         No review, just adding a FIXME.
82
83         Split out command parsing and help printing from BugzillaTool
84         https://bugs.webkit.org/show_bug.cgi?id=31688
85
86         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
87
88 2009-11-19  Eric Seidel  <eric@webkit.org>
89
90         Reviewed by Adam Barth.
91
92         Split out command parsing and help printing from BugzillaTool
93         https://bugs.webkit.org/show_bug.cgi?id=31688
94
95         * Scripts/bugzilla-tool:
96          - Add new MultiCommandTool class to contain option parsing and help printing logic.
97          - Rename private methods to use _ pattern.
98          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
99          - 
100
101 2009-11-19  Eric Seidel  <eric@webkit.org>
102
103         Reviewed by Adam Barth.
104
105         Re-factor help printing to use modern python idioms
106         https://bugs.webkit.org/show_bug.cgi?id=31685
107
108         * Scripts/bugzilla-tool:
109
110 2009-11-19  Eric Seidel  <eric@webkit.org>
111
112         Reviewed by Darin Adler.
113
114         commit-queue empty queue logs twice
115         https://bugs.webkit.org/show_bug.cgi?id=31679
116
117         * Scripts/bugzilla-tool:
118
119 2009-11-19  Eric Seidel  <eric@webkit.org>
120
121         Reviewed by Darin Adler.
122
123         bugzilla-tool's reviewer/committer rejection message should be clearer
124         https://bugs.webkit.org/show_bug.cgi?id=31126
125
126         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
127
128         * Scripts/modules/bugzilla.py:
129
130 2009-11-19  Eric Z. Ayers  <zundel@google.com>
131
132         Reviewed by Pavel Feldman.
133
134         Forces a WM_PAINT event on calling layoutTestController.display()
135         in order to enable the timeline-paint.html test on Windows.
136         ::UpdateWindow() does not force an event becaue the window is 
137         not visible.
138
139         https://bugs.webkit.org/show_bug.cgi?id=31402
140
141         * DumpRenderTree/win/DumpRenderTree.cpp:
142         (displayWebView):
143
144 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
145
146         No review needed.
147
148         Added myself to committers list.
149
150         * Scripts/modules/committers.py:
151
152 2009-11-19  Adam Barth  <abarth@webkit.org>
153
154         Reviewed by Eric Seidel.
155
156         Bugzilla-tool command classes should match command names
157         https://bugs.webkit.org/show_bug.cgi?id=31666
158
159         I renamed all the commands except CommitMessageForCurrentDiff because
160         the new name would conflict with an existing class.
161
162         * Scripts/bugzilla-tool:
163
164 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
165
166         Reviewed by Gustavo Noronha Silva.
167
168         Web Inspector: Implement "show inspector" in WebKit GTK
169         API and enable console tests.
170
171         https://bugs.webkit.org/show_bug.cgi?id=31669
172
173         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
174         (LayoutTestController::showWebInspector):
175
176 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
177
178         Reviewed by Simon Hausmann.
179
180         Minor refactoring + more documentation.
181
182         * DumpRenderTree/qt/DumpRenderTree.cpp:
183         (WebCore::clearHistory):
184         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
185
186 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
187
188         Reviewed by Eric Seidel.
189
190         Ignore websocket tests when --no-http is specified.
191         https://bugs.webkit.org/show_bug.cgi?id=31662
192
193         * Scripts/run-webkit-tests:
194
195 2009-11-18  Adam Barth  <abarth@webkit.org>
196
197         Reviewed by Eric Seidel.
198
199         Normalize ' and " in bugzilla-tool
200         https://bugs.webkit.org/show_bug.cgi?id=31655
201
202         We decided " is better than ' and we should be consistent.
203
204         * Scripts/bugzilla-tool:
205
206 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
207
208         Reviewed by Kenneth Rohde Christiansen.
209
210         [Qt] Remove support for Qt v4.3 or older versions
211         https://bugs.webkit.org/show_bug.cgi?id=29469
212
213         * DumpRenderTree/qt/DumpRenderTree.pro:
214         * DumpRenderTree/qt/ImageDiff.pro:
215
216 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
217
218         Reviewed by Eric Seidel.
219
220         GitTest.test_create_binary_patch fails if /tmp is symlink
221         https://bugs.webkit.org/show_bug.cgi?id=31536
222
223         * Scripts/modules/scm_unittest.py:
224
225 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
226
227         Reviewed by Darin Adler.
228
229         Configuration for Chromium Build Slaves.
230
231         https://bugs.webkit.org/show_bug.cgi?id=31442
232
233         * BuildSlaveSupport/build.webkit.org-config/config.json:
234         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
235
236 2009-11-18  Eric Seidel  <eric@webkit.org>
237
238         Reviewed by Darin Adler.
239
240         workqueue.py results in totally broken commit-queue UI
241         https://bugs.webkit.org/show_bug.cgi?id=31645
242
243         * Scripts/bugzilla-tool:
244          - Remove unneeded use of PatchCollection.
245          - Grab a new copy of the cq'd patches every run of the queue.
246
247 2009-11-18  Sam Weinig  <sam@webkit.org>
248
249         Reviewed by Anders Carlsson.
250
251         Make the Mac Geolocation API async.
252
253         Update DRT to use the new async Mac Geolocation API.
254
255         * DumpRenderTree/mac/UIDelegate.mm:
256         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
257
258 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
259
260         Reviewed by Kenneth Rohde Christiansen.
261
262         Add and option to toggle HTML5 datalist support to build-webkit
263         https://bugs.webkit.org/show_bug.cgi?id=31599
264
265         * Scripts/build-webkit:
266
267 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
268
269         Reviewed by Kevin Ollivier.
270
271         Enable wx plugin support using the Windows implementation as a base.
272         
273         https://bugs.webkit.org/show_bug.cgi?id=31636
274
275         * wx/build/settings.py:
276
277 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
278
279         Reviewed by Simon Hausmann.
280
281         Change the initialization order so that the controllers
282         will be created before exporting them to the JS DOM window.
283
284         * DumpRenderTree/qt/DumpRenderTree.cpp:
285         (WebCore::DumpRenderTree::DumpRenderTree):
286
287 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
288
289         Reviewed by Simon Hausmann.
290
291         Fix a code copy and paste error. m_page should be page.
292
293         * DumpRenderTree/qt/DumpRenderTree.cpp:
294         (WebCore::DumpRenderTree::createWindow):
295
296 2009-11-17  Mark Rowe  <mrowe@apple.com>
297
298         Reviewed by Alexey Proskuryakov.
299
300         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
301
302         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
303         This prevents symlinks from confusing the descendant check.
304
305 2009-11-17  Mark Rowe  <mrowe@apple.com>
306
307         Reviewed by Alexey Proskuryakov.
308
309         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
310
311         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
312         server to be up rather than having run-webkit-tests abort immediately.
313
314         * Scripts/run-webkit-tests:
315
316 2009-11-17  Eric Seidel  <eric@webkit.org>
317
318         Reviewed by Darin Adler.
319
320         commit-queue is failing to set reviewer in ChangeLogs
321         https://bugs.webkit.org/show_bug.cgi?id=31592
322
323         * Scripts/bugzilla-tool: Clarify the "applying" log message.
324         * Scripts/modules/bugzilla.py:
325          - Add a new _validate_committer_and_reviewer function as a
326            temporary solution until we can make a real Attachment object
327            which knows how to fill in its committer/reviewer fields automatically.
328
329 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
330
331         Unreviewed buildbot fix.
332
333         Revert part of earlier patch and add comment, as it
334         was causing timeouts on the buildbot.
335
336         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
337         (LayoutTestController::notifyDone):
338
339 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
340
341         Reviewed by Oliver Hunt.
342
343         Make the timeout 15 sec as for the other DRT's and make
344         it print out the same output when a test timeout.
345
346         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
347         (LayoutTestController::waitUntilDone):
348         (LayoutTestController::notifyDone):
349         (LayoutTestController::timerEvent):
350
351 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
352
353         Reviewed by Timothy Hatcher.
354
355         Fixed typos in comments.
356
357         * Scripts/modules/committers.py:
358
359 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
360
361         Reviewed by Timothy Hatcher.
362
363         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
364         - Updated DRT to show/close inspector for all tests under /inspector
365         - Introduced LayoutTestController::setTimelineProfilingEnabled and
366           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
367         - Removed reload on each inspector test
368         - Renamed fast/inspector to fast/inspector-support in order not to trigger
369         inspector for those.
370         - Reimplemented timeline tests in order to get rid of reload there.
371         - Moved tests that don't require harness into the fast group.
372
373         https://bugs.webkit.org/show_bug.cgi?id=31472
374
375         * DumpRenderTree/LayoutTestController.cpp:
376         (setTimelineProfilingEnabledCallback):
377         (closeWebInspectorCallback):
378         (LayoutTestController::staticFunctions):
379         * DumpRenderTree/LayoutTestController.h:
380         * DumpRenderTree/gtk/DumpRenderTree.cpp:
381         (shouldOpenWebInspector):
382         (runTest):
383         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
384         (LayoutTestController::setTimelineProfilingEnabled):
385         * DumpRenderTree/mac/DumpRenderTree.mm:
386         (shouldOpenWebInspector):
387         (runTest):
388         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
389         (LayoutTestController::setTimelineProfilingEnabled):
390         * DumpRenderTree/win/DumpRenderTree.cpp:
391         (shouldOpenWebInspector):
392         (runTest):
393         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
394         (LayoutTestController::setTimelineProfilingEnabled):
395
396 2009-11-17  Oliver Hunt  <oliver@apple.com>
397
398         Reviewed by Maciej Stachowiak.
399
400         Incorrect use of JavaScriptCore API in DumpRenderTree
401         https://bugs.webkit.org/show_bug.cgi?id=31577
402
403         Return undefined rather than a literal null.
404
405         * DumpRenderTree/AccessibilityUIElement.cpp:
406         (setSelectedTextRangeCallback):
407         (incrementCallback):
408         (decrementCallback):
409         (showMenuCallback):
410
411 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
412
413         Reviewed by Beth Dakin.
414
415         AX: aria-labelledby duplicates some of its WAI-ARIA label
416         https://bugs.webkit.org/show_bug.cgi?id=31565
417
418         * DumpRenderTree/AccessibilityUIElement.cpp:
419         (titleUIElementCallback):
420         (getIsValidCallback):
421         (AccessibilityUIElement::getJSClass):
422
423 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
424
425         Reviewed by Simon Hausmann.
426
427         r50942 broke output from created windows. Make the
428         m_enableTextOutput a member of the DRT and not the
429         WebPage.
430
431         * DumpRenderTree/qt/DumpRenderTree.cpp:
432         (WebCore::WebPage::WebPage):
433         (WebCore::WebPage::javaScriptAlert):
434         (WebCore::WebPage::javaScriptConsoleMessage):
435         (WebCore::WebPage::javaScriptConfirm):
436         (WebCore::WebPage::javaScriptPrompt):
437         (WebCore::WebPage::acceptNavigationRequest):
438         (WebCore::DumpRenderTree::DumpRenderTree):
439         (WebCore::DumpRenderTree::open):
440         (WebCore::DumpRenderTree::createWindow):
441         * DumpRenderTree/qt/DumpRenderTree.h:
442         (WebCore::DumpRenderTree::setTextOutputEnabled):
443         (WebCore::DumpRenderTree::isTextOutputEnabled):
444         (WebCore::WebPage::shouldInterruptJavaScript):
445         (WebCore::WebPage::isTextOutputEnabled):
446         (WebCore::WebPage::setViewGeometry):
447
448 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
449
450         Reviewed by Gustavo Noronha Silva.
451
452         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
453         as the implementation is being used by at least Qt and Gtk+.
454
455         Update buildsystems as well.
456
457         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
458         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
459         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
460         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
461         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
462         * GNUmakefile.am:
463
464 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
465
466         Reviewed by Alexey Proskuryakov.
467
468         Disable wss until all platforms support pyOpenSSL
469
470         https://bugs.webkit.org/show_bug.cgi?id=31479
471
472         * Scripts/run-webkit-tests:
473
474 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
475
476         Reviewed by Kenneth Christiansen.
477
478         [Qt] Implement load error pages support for Qt's DRT.
479         https://bugs.webkit.org/show_bug.cgi?id=31509
480
481         For now, it will not be a default feature, and layout tests
482         that want to make use of this have to explicitily call
483         'handleErrorPages();' for the test source.
484
485         Any of the other DumpRenderTree's (mac, win and gtk)
486         support handling error pages. Qt's will be the first.
487
488         * DumpRenderTree/qt/DumpRenderTree.cpp:
489         (WebCore::WebPage::supportsExtension):
490         (WebCore::WebPage::extension):
491         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
492         (LayoutTestController::reset):
493         * DumpRenderTree/qt/LayoutTestControllerQt.h:
494         (LayoutTestController::shouldHandleErrorPages):
495         (LayoutTestController::handleErrorPages):
496
497 2009-11-16  Eric Seidel  <eric@webkit.org>
498
499         Reviewed by Adam Barth.
500
501         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
502         https://bugs.webkit.org/show_bug.cgi?id=31549
503
504         Renamed --commit-queue to --non-interactive in most places
505         and remove the code in land-patches which is no longer needed.
506
507         * Scripts/bugzilla-tool:
508
509 2009-11-16  Eric Seidel  <eric@webkit.org>
510
511         Reviewed by Adam Barth.
512
513         The commit-queue should use land-attachment
514         https://bugs.webkit.org/show_bug.cgi?id=31548
515
516         * Scripts/bugzilla-tool:
517
518 2009-11-16  Adam Barth  <abarth@webkit.org>
519
520         Reviewed by Eric Seidel.
521
522         Convert CommitQueue over to PatchCollection
523         https://bugs.webkit.org/show_bug.cgi?id=31547
524
525         Also fixes a bug in workqueue and adds a test!
526
527         * Scripts/bugzilla-tool:
528         * Scripts/modules/workqueue.py:
529         * Scripts/modules/workqueue_unittest.py:
530
531 2009-11-16  Adam Barth  <abarth@webkit.org>
532
533         Reviewed by Eric Seidel.
534
535         Move StyleQueue over to using PatchCollection
536         https://bugs.webkit.org/show_bug.cgi?id=31544
537
538         That's what the class it's for.
539
540         * Scripts/bugzilla-tool:
541         * Scripts/modules/patchcollection.py:
542         * Scripts/modules/patchcollection_unittest.py:
543
544 2009-11-16  Eric Seidel  <eric@webkit.org>
545
546         Reviewed by Adam Barth.
547
548         bugzilla-tool needs a land-attachment command
549         https://bugs.webkit.org/show_bug.cgi?id=31546
550
551         * Scripts/bugzilla-tool:
552          - Move all the logic into AbstractLandingCommand and
553            add a new LandAttachment command subclass.
554          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
555
556 2009-11-16  Eric Seidel  <eric@webkit.org>
557
558         Reviewed by Adam Barth.
559
560         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
561         https://bugs.webkit.org/show_bug.cgi?id=31543
562
563         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
564
565         * Scripts/bugzilla-tool:
566
567 2009-11-16  Eric Seidel  <eric@webkit.org>
568
569         Reviewed by Adam Barth.
570
571         Disable the style queue from posting to the commit queue status page.
572
573         * Scripts/bugzilla-tool:
574
575 2009-11-16  Adam Barth  <abarth@webkit.org>
576
577         Reviewed by Eric Seidel.
578
579         Implement PatchCollection
580         https://bugs.webkit.org/show_bug.cgi?id=31541
581
582         This class holds a set of patches and lets clients iterate through
583         them.  Optionally, clients can install a filter.
584
585         * Scripts/modules/patchcollection.py: Added.
586         * Scripts/modules/patchcollection_unittest.py: Added.
587         * Scripts/run-webkit-unittests:
588
589 2009-11-16  Eric Seidel  <eric@webkit.org>
590
591         Reviewed by Adam Barth.
592
593         bugzilla-tool land-patches will close bugs with patches r=?
594         https://bugs.webkit.org/show_bug.cgi?id=28230
595
596         The commit-queue shouldn't close patches with outstanding reviews on them,
597         even if many reviewers seem to be against multi-patch bugs.
598
599         * Scripts/bugzilla-tool:
600
601 2009-11-16  Eric Seidel  <eric@webkit.org>
602
603         Reviewed by Adam Barth.
604
605         bugzilla-tool check-style should work with attachment ids instead of bug ids
606         https://bugs.webkit.org/show_bug.cgi?id=31540
607
608         * Scripts/bugzilla-tool:
609
610 2009-11-16  Eric Seidel  <eric@webkit.org>
611
612         Reviewed by Adam Barth.
613
614         WorkQueue is the only place that should know about special exit codes
615         https://bugs.webkit.org/show_bug.cgi?id=31534
616
617         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
618         and add tests for handling exit codes.
619         I also cleaned up workqueue_unittest.py more.
620
621         * Scripts/bugzilla-tool:
622         * Scripts/modules/workqueue.py:
623         * Scripts/modules/workqueue_unittest.py:
624
625 2009-11-16  Eric Seidel  <eric@webkit.org>
626
627         Reviewed by Adam Barth.
628
629         Re-factor workqueue_unittest to allow for more than one test.
630         https://bugs.webkit.org/show_bug.cgi?id=31535
631
632         * Scripts/modules/workqueue_unittest.py:
633
634 2009-11-16  Eric Seidel  <eric@webkit.org>
635
636         Reviewed by Adam Barth.
637
638         land-patches needs to be re-factored into smaller chunks
639         https://bugs.webkit.org/show_bug.cgi?id=31532
640
641         * Scripts/bugzilla-tool: fix a couple obvious typos.
642
643 2009-11-16  Eric Seidel  <eric@webkit.org>
644
645         Reviewed by Adam Barth.
646
647         land-patches needs to be re-factored into smaller chunks
648         https://bugs.webkit.org/show_bug.cgi?id=31532
649
650         The next patch will move these methods into WebKitLandingScripts.
651
652         * Scripts/bugzilla-tool:
653          - Split out _land_patch and _close_bug_if_no_active_patches.
654
655 2009-11-16  Adam Barth  <abarth@webkit.org>
656
657         Reviewed by Eric Seidel.
658
659         Fix silly copy-and-paste code.  I am a terrible coder.
660
661         * Scripts/modules/bugzilla.py:
662
663 2009-11-16  Adam Barth  <abarth@webkit.org>
664
665         Reviewed by Eric Seidel.
666
667         Implement a StyleQueue
668         https://bugs.webkit.org/show_bug.cgi?id=31537
669
670         The first iteration of the style queue only produces output locally.
671         There is also a limit of 10 patches because it's not that useful to
672         iterate through the entire review queue at this point.  We can remove
673         the limit later.
674
675         * Scripts/bugzilla-tool:
676         * Scripts/modules/bugzilla.py:
677
678 2009-11-16  Adam Barth  <abarth@webkit.org>
679
680         Reviewed by Eric Seidel.
681
682         Unit test WorkQueue
683         https://bugs.webkit.org/show_bug.cgi?id=31531
684
685         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
686
687         * Scripts/bugzilla-tool:
688         * Scripts/modules/statusbot.py:
689         * Scripts/modules/workqueue.py:
690         * Scripts/modules/workqueue_unittest.py: Added.
691         * Scripts/run-webkit-unittests:
692
693 2009-11-16  Eric Seidel  <eric@webkit.org>
694
695         Reviewed by Adam Barth.
696
697         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
698         https://bugs.webkit.org/show_bug.cgi?id=31530
699
700         * Scripts/bugzilla-tool:
701
702 2009-11-16  Eric Seidel  <eric@webkit.org>
703
704         Reviewed by Adam Barth.
705
706         bugzilla-tool needs apply-attachment
707         https://bugs.webkit.org/show_bug.cgi?id=31528
708
709         * Scripts/bugzilla-tool:
710          - Add ApplyAttachment command.
711          - Abstract applying code into WebKitApplyingScripts.
712          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
713         * Scripts/modules/bugzilla.py:
714          - Add fetch_attachment and bug_id_for_attachment_id.
715         * Scripts/modules/bugzilla_unittest.py:
716          - Add test for new parsing.
717          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
718
719 2009-11-16  Eric Seidel  <eric@webkit.org>
720
721         Reviewed by Adam Barth.
722
723         Document check-style's use of force_clean.
724
725         * Scripts/bugzilla-tool:
726         * Scripts/modules/scm.py:
727
728 2009-11-16  Adam Barth  <abarth@webkit.org>
729
730         Reviewed by Eric Seidel.
731
732         Move WorkQueue to its own file
733         https://bugs.webkit.org/show_bug.cgi?id=31529
734
735         WorkQueue and WorkQueueDelegate are separate concerns from
736         bugzilla-tool.  Also added a missing include to logging.py.
737
738         * Scripts/bugzilla-tool:
739         * Scripts/modules/logging.py:
740         * Scripts/modules/workqueue.py:
741
742 2009-11-16  Adam Barth  <abarth@webkit.org>
743
744         Reviewed by Eric Seidel.
745
746         Move OutputTee to logging.py.
747
748         * Scripts/bugzilla-tool:
749         * Scripts/modules/logging.py:
750
751 2009-11-15  Adam Barth  <abarth@webkit.org>
752
753         Reviewed by Eric Seidel.
754
755         Refactor bugzilla-tool to allow for multiple queues
756         https://bugs.webkit.org/show_bug.cgi?id=31513
757
758         Divide the commit queue class into three class to make creating
759         additional queues easier.
760
761         * Scripts/bugzilla-tool:
762
763 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
764
765         Reviewed by Eric Seidel.
766
767         svn-apply may not handle git patches created by bugzilla-tool
768         https://bugs.webkit.org/show_bug.cgi?id=31457
769
770         * Scripts/modules/scm.py:
771         * Scripts/modules/scm_unittest.py:
772
773 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
774
775         Reviewed by Eric Seidel.
776
777         bugzilla-tool should post git binary diff
778         https://bugs.webkit.org/show_bug.cgi?id=31458
779
780         Add --binary option to Git.create_patch.
781
782         * Scripts/modules/scm.py:
783         * Scripts/modules/scm_unittest.py:
784
785 2009-11-15  Adam Barth  <abarth@webkit.org>
786
787         Reviewed by Darin Adler.
788
789         Add bugzilla-tool check-style
790         https://bugs.webkit.org/show_bug.cgi?id=31515
791
792         * Scripts/bugzilla-tool:
793         * Scripts/modules/bugzilla.py:
794
795 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
796
797         Reviewed by Simon Hausmann.
798
799         Make the Qt Linux only --valgrind feature, suppress errors
800         defined in the SuppressedValgrindErrors file.
801
802         * Scripts/run-webkit-tests:
803
804 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
805
806         Reviewed by Simon Hausmann.
807
808         Set the locale to C and not to the current one in use on the system.
809
810         * DumpRenderTree/qt/DumpRenderTree.cpp:
811         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
812
813 2009-11-13  Adam Roben  <aroben@apple.com>
814
815         Add support for
816         http/tests/security/isolatedWorld/didClearWindowObject.html
817
818         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
819         window objects in isolated worlds are cleared
820
821         Reviewed by Dave Hyatt.
822
823         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
824
825         * DumpRenderTree/mac/FrameLoadDelegate.mm:
826         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
827         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
828         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
829         Added. Sets a __worldID property on the global object whose value is
830         the ID of this world.
831         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
832         Respond to this new delegate callback by calling through to one of the
833         above new methods.
834         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
835         (worldMap): Added. Returns a HashMap containing all the worlds we've
836         created.
837         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
838         haven't kept track of this world.
839         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
840         instead of declaring our own.
841
842         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
843
844         * DumpRenderTree/win/FrameLoadDelegate.cpp:
845         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
846         didClearWindowObjectForFrameInStandardWorld.
847         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
848         Respond to this new delegate callback by calling through to one of the
849         below new methods.
850         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
851         Added. Sets a __worldID property on the gobal object whose value is
852         the ID of this world.
853         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
854         Added. Moved code here from didClearWindowObject.
855
856         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
857         didClearWindowObjectForFrame* functions.
858
859         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
860         (worldMap): Added. Returns a HashMap containing all the worlds we've
861         created.
862         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
863         haven't kept track of this world.
864         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
865         instead of declaring our own.
866
867 2009-11-13  Adam Roben  <aroben@apple.com>
868
869         Finish replacing worldIDs with world objects
870
871         The only remaining use of worldIDs was in a method only used by DRT
872         for the isolated worlds tests.
873
874         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
875
876         Reviewed by Mark Rowe.
877
878         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
879         (LayoutTestController::evaluateScriptInIsolatedWorld):
880         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
881         (LayoutTestController::evaluateScriptInIsolatedWorld):
882         Updated for changes to WebFrame. Now holds the map of worldID -> world
883         at this level instead of making WebKit do it.
884
885 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
886
887         Reviewed by Simon Hausmann.
888
889         [Qt] Ensure the DRT does not output anything until first test is run
890
891         * DumpRenderTree/qt/DumpRenderTree.cpp:
892         * DumpRenderTree/qt/DumpRenderTree.h:
893
894 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
895
896         Reviewed by Tor Arne Vestbø.
897
898         Clear the undo stack in before each new test run.
899
900         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
901
902         * DumpRenderTree/qt/DumpRenderTree.cpp:
903         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
904
905 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
906
907         Reviewed by Kenneth Rohde Christiansen.
908
909         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
910
911         * DumpRenderTree/qt/DumpRenderTree.cpp:
912         (WebCore::WebPage::resetSettings):
913         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
914         (LayoutTestController::overridePreference):
915
916 2009-11-13  Eric Seidel  <eric@webkit.org>
917
918         Reviewed by Adam Barth.
919
920         Update committers.py based on svn records
921         https://bugs.webkit.org/show_bug.cgi?id=31366
922
923         This list was generated using validate-committer-lists from
924         https://bugs.webkit.org/show_bug.cgi?id=30970
925         and makes committers.py current for committers who have
926         committed in the last 3 years.
927
928         * Scripts/modules/committers.py:
929
930 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
931
932         Reviewed by Adam Barth.
933
934         The document-open.html test was flaky at times. The test invokes the layout test plugin
935         which in its destroy stream handler opens a new document. This basically tears down the
936         stream and the associated plugin instance. The pluginLog function in the layout test
937         plugin attempts to retrieve the window script object on a torn down plugin instance
938         which crashed consistently on windows in the debugger. The functions which issue
939         these logs already have a valid window script object. We now have variants of the pluginLog
940         function which take in a window script object with and without variable arguments. 
941
942         https://bugs.webkit.org/show_bug.cgi?id=31067
943
944         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
945         (pluginLogWithWindowObject):
946         (pluginLogWithWindowObjectVariableArgs):
947         (pluginLog):
948         (notifyTestCompletion):
949         (testDocumentOpen):
950         (testWindowOpen):
951
952 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
953
954         Reviewed by Gustavo Noronha Silva.
955
956         https://bugs.webkit.org/show_bug.cgi?id=30997
957         [Gtk] Implemment AtkDocument
958
959         Added testing support.
960
961         * DumpRenderTree/AccessibilityUIElement.cpp:
962         * DumpRenderTree/AccessibilityUIElement.h:
963         (getDocumentEncodingCallback):
964         (getDocumentURICallback):
965         (AccessibilityUIElement::getJSClass):
966         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
967         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
968         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
969         (AccessibilityUIElement::documentEncoding):
970         (AccessibilityUIElement::documentURI):
971
972 2009-11-12  Adam Roben  <aroben@apple.com>
973
974         Replace worldIDs with world objects
975
976         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
977         user scripts/stylesheets and isolated worlds
978
979         Reviewed by Sam Weinig.
980
981         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
982         (LayoutTestController::addUserScript):
983         (LayoutTestController::addUserStyleSheet):
984         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
985         (LayoutTestController::addUserScript):
986         (LayoutTestController::addUserStyleSheet):
987         Changed these functions to create a new WebJSWorld each time they're
988         called and to pass that world to WebKit.
989
990 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
991
992         Reviewed by Oliver Hunt.
993
994         need to implement aria tree roles
995         https://bugs.webkit.org/show_bug.cgi?id=31284
996
997         * DumpRenderTree/AccessibilityUIElement.cpp:
998         (disclosedRowAtIndexCallback):
999         (selectedRowAtIndexCallback):
1000         (isEqualCallback):
1001         (isAttributeSettableCallback):
1002         (isActionSupportedCallback):
1003         (disclosedByRowCallback):
1004         (hierarchicalLevelCallback):
1005         (AccessibilityUIElement::getJSClass):
1006         * DumpRenderTree/AccessibilityUIElement.h:
1007         (AccessibilityUIElement::isEqual):
1008         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1009         (AccessibilityUIElement::hierarchicalLevel):
1010         (AccessibilityUIElement::disclosedRowAtIndex):
1011         (AccessibilityUIElement::selectedRowAtIndex):
1012         (AccessibilityUIElement::disclosedByRow):
1013         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1014         (AccessibilityUIElement::getChildAtIndex):
1015         (AccessibilityUIElement::disclosedRowAtIndex):
1016         (AccessibilityUIElement::selectedRowAtIndex):
1017         (AccessibilityUIElement::titleUIElement):
1018         (AccessibilityUIElement::parentElement):
1019         (AccessibilityUIElement::disclosedByRow):
1020         (AccessibilityUIElement::hierarchicalLevel):
1021         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1022         (AccessibilityUIElement::hierarchicalLevel):
1023         (AccessibilityUIElement::disclosedRowAtIndex):
1024         (AccessibilityUIElement::selectedRowAtIndex):
1025         (AccessibilityUIElement::disclosedByRow):
1026
1027 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1028
1029         Reviewed by Darin Adler.
1030
1031         svn-apply can not handle git binary diffs
1032         https://bugs.webkit.org/show_bug.cgi?id=26830
1033
1034         Support "literal" type git binary diffs.
1035
1036         * Scripts/VCSUtils.pm:
1037         * Scripts/modules/scm_unittest.py:
1038         * Scripts/svn-apply:
1039
1040 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1041
1042         Not reviewed, removing duplicate entry for myself in committers.py.
1043
1044         * Scripts/modules/committers.py:
1045
1046 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1047
1048         Reviewed by Darin Adler and Mark Rowe.
1049
1050         https://bugs.webkit.org/show_bug.cgi?id=31200
1051         Tests in http/tests/security/mixedContent start to fail when new tests are added
1052
1053         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1054
1055 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1056
1057         Reviewed by Jan Alonzo.
1058
1059         Create, and display a window for the inspector, for inspector
1060         tests.
1061
1062         Need to also show/hide the inspector window to avoid having
1063         problems with code assuming it is realized
1064         https://bugs.webkit.org/show_bug.cgi?id=31347
1065
1066         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1067         (webInspectorShowWindow):
1068         (webInspectorCloseWindow):
1069         (webInspectorInspectWebView):
1070         (createWebView):
1071
1072 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1073
1074         Unreviewed Qt buildbot fix.
1075
1076         My previous fix was wrong, so revert that change and fix it by
1077         returning when the document of the frame has no document element.
1078         Idea is borrowed from mac and win DRT.
1079
1080         * DumpRenderTree/qt/DumpRenderTree.cpp:
1081         (WebCore::DumpRenderTree::dumpFramesAsText):
1082
1083 2009-11-11  Eric Seidel  <eric@webkit.org>
1084
1085         Reviewed byg Kenneth Rohde Christiansen.
1086
1087         Update Kenneth's committer record to include the email he
1088         uses on lists.webkit.org.
1089
1090         * Scripts/modules/committers.py:
1091
1092 2009-11-11  Eric Seidel  <eric@webkit.org>
1093
1094         Reviewed by Gustavo Noronha Silva.
1095
1096         Several committers use separate email addresses for bugzilla and svn.webkit.org
1097         https://bugs.webkit.org/show_bug.cgi?id=31364
1098
1099         Update records for existing committers to include email addresses
1100         used in svn.webkit.org and lists.webkit.org.
1101         Most committers use the same email address in all 3 places, but some use
1102         separate addresses.  committers.py needs record of each of these addresses.
1103
1104         * Scripts/modules/committers.py:
1105
1106 2009-11-11  Eric Seidel  <eric@webkit.org>
1107
1108         No review, adding second email address for an existing committer.
1109
1110         Add Yong Li's second bugzilla account to his committer record.
1111         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1112
1113         * Scripts/modules/committers.py:
1114
1115 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1116
1117         Reviewed by Simon Hausmann.
1118
1119         If the frame has no innerText don't append it, and
1120         do not add a newline which breaks some cross platform
1121         results.
1122
1123         * DumpRenderTree/qt/DumpRenderTree.cpp:
1124         (WebCore::DumpRenderTree::dumpFramesAsText):
1125
1126 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1127
1128         Reviewed by Simon Hausmann.
1129
1130         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1131
1132         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1133         (webkit_test_plugin_new_instance):
1134         (webkit_test_plugin_destroy_instance):
1135         (webkit_test_plugin_destroy_stream):
1136
1137 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1138
1139         Reviewed by Mark Rowe.
1140
1141         Implement the functionality needed by plugins/window-open.html
1142
1143         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1144         (webkit_test_plugin_new_instance):
1145         (webkit_test_plugin_set_window):
1146
1147 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1148
1149         Reviewed by Simon Hausmann.
1150
1151         [Qt] Force -graphicssystem raster and -style windows when running DRT
1152
1153         * DumpRenderTree/qt/main.cpp:
1154         * Scripts/run-webkit-tests:
1155
1156 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1157
1158         Reviewed by Simon Hausmann.
1159
1160         Compute correct library paths for Qt
1161
1162         * Scripts/webkitdirs.pm:
1163
1164 2009-11-10  Mark Rowe  <mrowe@apple.com>
1165
1166         Reviewed by Sam Weinig.
1167
1168         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1169
1170         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1171         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1172         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1173         that had enabled frame load delegate logging this would result in extra log messages being generated,
1174         causing the test to fail.
1175
1176         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1177         tests.
1178
1179         * DumpRenderTree/mac/DumpRenderTree.mm:
1180         (dumpRenderTree):
1181         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1182         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1183
1184 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1185
1186         Reviewed by Kenneth Rohde Christiansen.
1187
1188         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1189
1190         * DumpRenderTree/qt/DumpRenderTree.cpp:
1191         (WebCore::DumpRenderTree::DumpRenderTree):
1192
1193 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1194
1195         Reviewed by Jan Alonzo.
1196
1197         [GTK] Remove WebSocket configuration from WebKitWebSettings
1198         https://bugs.webkit.org/show_bug.cgi?id=31244
1199
1200         Follow-up of r50724. Don't set the enable-web-socket property
1201         anymore.
1202
1203         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1204         (resetDefaultsToConsistentValues):
1205
1206 2009-11-10  Oliver Hunt  <oliver@apple.com>
1207
1208         Reviewed by Maciej Stachowiak.
1209
1210         Rename 3D Canvas related classes to use WebGL prefix
1211         https://bugs.webkit.org/show_bug.cgi?id=29095
1212
1213         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1214         and upate webkitdirs script to new method of testing for WebGL.
1215
1216         * Scripts/do-webcore-rename:
1217         * Scripts/webkitdirs.pm:
1218
1219 2009-11-09  Oliver Hunt  <oliver@apple.com>
1220
1221         Reviewed by Geoff Garen.
1222
1223         Make do-webcore-rename work with git.
1224
1225         * Scripts/do-webcore-rename:
1226
1227 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1228
1229         Adding Kenneth to the reviewers list.
1230
1231         * Scripts/modules/committers.py:
1232
1233 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1234
1235         Reviewed by Jan Alonzo.
1236
1237         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1238         https://bugs.webkit.org/show_bug.cgi?id=30482
1239
1240         LayoutTestControllerGtk now uses the exposed
1241         Page::tabKeyCyclesThroughElements API
1242
1243         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1244         (LayoutTestController::setTabKeyCyclesThroughElements):
1245
1246 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1247
1248         Reviewed by Holger Freyther.
1249
1250         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1251         This helps to pass the test case below. Also replaced hardcoded
1252         code numbers with defined constants.
1253         https://bugs.webkit.org/show_bug.cgi?id=31185
1254         
1255         Test: editing/undo/undo-deleteWord.html
1256
1257         * DumpRenderTree/qt/EventSenderQt.cpp:
1258         (EventSender::keyDown):
1259
1260 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1261
1262         Reviewed by Holger Freyther.
1263
1264         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1265         https://bugs.webkit.org/show_bug.cgi?id=31164
1266
1267         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1268
1269         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1270         (LayoutTestController::processWork):
1271
1272 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1273
1274         Reviewed by Holger Freyther.
1275
1276         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1277         https://bugs.webkit.org/show_bug.cgi?id=31158
1278
1279         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1280         always, which from WorkQueue prospective means that a load has been started
1281         and the queue processing should stop and wait for the load to finish.
1282         Spinning it off into a loading and a non-loading variants was the solution
1283         adopted by Mac's DRT to work around this problem. The former keeps returning
1284         'true' while the later executes the script synchronously and returns 'false'
1285         making it possible to the WorkQueue to proceed right away.
1286
1287         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1288         (LayoutTestController::processWork):
1289         (LayoutTestController::queueLoadingScript):
1290         (LayoutTestController::queueNonLoadingScript):
1291         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1292         * DumpRenderTree/qt/WorkQueueItem.h:
1293         (LoadingScriptItem::LoadingScriptItem):
1294         (LoadingScriptItem::invoke):
1295         (NonLoadingScriptItem::NonLoadingScriptItem):
1296         (NonLoadingScriptItem::invoke):
1297
1298 2009-11-07  Mark Rowe  <mrowe@apple.com>
1299
1300         Rubber-stamped by Cameron Zwarich.
1301
1302         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1303
1304         * Scripts/commit-log-editor:
1305
1306 2009-11-07  Mark Rowe  <mrowe@apple.com>
1307
1308         Reviewed by Darin Adler.
1309
1310         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1311         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1312
1313         Move logic for determining the name and email address to use in a ChangeLog entry from
1314         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1315         whether the author of the patch matches committer, and therefore needs access to the
1316         email address that would be used in a ChangeLog entry.
1317
1318         Based on a patch by Pierre d'Herbemont.
1319
1320         * Scripts/VCSUtils.pm:
1321         * Scripts/commit-log-editor:
1322         * Scripts/prepare-ChangeLog:
1323         * Scripts/webkitdirs.pm:
1324
1325 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1326
1327         Reviewed by Adam Barth.
1328
1329         Added functionality to the layout test plugin to invoke document.open and
1330         window.open with default arguments. The associated webkit bug is
1331         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1332         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1333         work in Chromium (V8) if there is no calling javascript context. To achieve this
1334         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1335         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1336
1337         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1338         (testDocumentOpen):
1339         (testWindowOpen):
1340         (pluginAllocate):
1341         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1342         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1343         (NPP_New):
1344         (NPP_SetWindow):
1345         (NPP_DestroyStream):
1346         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1347         (NPP_New):
1348         (NPP_SetWindow):
1349         (NPP_NewStream):
1350         (NPP_DestroyStream):
1351
1352 2009-11-06  Eric Seidel  <eric@webkit.org>
1353
1354         Reviewed by Adam Barth.
1355
1356         bugzilla-tool crashed with exception
1357         https://bugs.webkit.org/show_bug.cgi?id=31092
1358
1359         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1360
1361 2009-11-04  Eric Seidel  <eric@webkit.org>
1362
1363         No review, just add a line which got left out of the patch uploaded for commit.
1364
1365         commit-queue is crashing when trying to reject patches after unknown failures
1366         https://bugs.webkit.org/show_bug.cgi?id=31091
1367
1368         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1369
1370 2009-11-04  Adam Roben  <aroben@apple.com>
1371
1372         Remove bogus else clause in bugzilla-tool
1373
1374         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1375         create-bug raises exception after entering bug description
1376
1377         Reviewed by David Kilzer.
1378
1379         * Scripts/bugzilla-tool:
1380         (CreateBug): else clauses are only hit if no exception is raised, so
1381         it makes no sense to try to re-raise the exception in an else clause.
1382         The exception will automatically be re-raised if it doesn't match any
1383         of the except clauses, so we don't have to do anything special here at
1384         all to get the desired behavior.
1385
1386 2009-11-04  Eric Seidel  <eric@webkit.org>
1387
1388         Reviewed by David Kilzer.
1389
1390         svn-apply's fixChangeLogPatch function seems broken
1391         https://bugs.webkit.org/show_bug.cgi?id=30683
1392
1393         Update fixChangeLogPatch to be able to handle patches which
1394         don't start at line 1.
1395         Add unit tests for svn-apply to scm_unittest.py.
1396
1397         * Scripts/VCSUtils.pm:
1398         * Scripts/modules/scm_unittest.py:
1399
1400 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1401
1402         Reviewed by Beth Dakin.
1403
1404         Need to implement ARIA role="combobox"
1405         https://bugs.webkit.org/show_bug.cgi?id=31096
1406
1407         * DumpRenderTree/AccessibilityUIElement.cpp:
1408         (showMenuCallback):
1409         (getIsExpandedCallback):
1410         (AccessibilityUIElement::getJSClass):
1411         * DumpRenderTree/AccessibilityUIElement.h:
1412         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1413         (AccessibilityUIElement::isExpanded):
1414         (AccessibilityUIElement::showMenu):
1415         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1416         (AccessibilityUIElement::isExpanded):
1417         (AccessibilityUIElement::showMenu):
1418         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1419         (AccessibilityUIElement::isSelected):
1420         (AccessibilityUIElement::isExpanded):
1421         (AccessibilityUIElement::showMenu):
1422
1423 2009-11-04  Eric Seidel  <eric@webkit.org>
1424
1425         Reviewed by Adam Barth.
1426
1427         commit-queue is crashing when trying to reject patches after unknown failures
1428         https://bugs.webkit.org/show_bug.cgi?id=31091
1429
1430         * Scripts/bugzilla-tool:
1431          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
1432            so we have to find out what the current patch is by asking bugzilla again.
1433          - Discovered that this code was also leaking file descriptors, so fixed that.
1434
1435 2009-11-04  Adam Roben  <aroben@apple.com>
1436
1437         Make run-webkit-tests work for the Debug_Internal Windows
1438         configuration
1439
1440         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
1441         suffix.
1442
1443         Fixes <http://webkit.org/b/31123>.
1444
1445         Reviewed by Sam Weinig.
1446
1447         * Scripts/run-webkit-tests: Don't add the _debug suffix in
1448         Debug_Internal, either.
1449
1450 2009-11-04  Eric Seidel  <eric@webkit.org>
1451
1452         Reviewed by Adam Barth.
1453
1454         committers.py needs a way to store non-bugzilla email addresses
1455         https://bugs.webkit.org/show_bug.cgi?id=31037
1456
1457         Make Committer and Reviewer constructors take a single email or a list of emails.
1458         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
1459         Expose reviewers(), used by validate-committer-lists on bug 30970.
1460
1461         * Scripts/modules/committers.py:
1462         * Scripts/modules/committers_unittest.py: Added tests for the new code.
1463
1464 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
1465
1466         Reviewed by David Levin.
1467
1468         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
1469         https://bugs.webkit.org/show_bug.cgi?id=27491
1470
1471         The test path determination logic is changed to handle websocket and websocket/ssl cases.
1472         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
1473
1474         Functions to start or stop Web Socket servers are added.
1475
1476         * Scripts/run-webkit-tests:
1477
1478 2009-11-03  Eric Seidel  <eric@webkit.org>
1479
1480         No review, just changing wording of log message.
1481
1482         Change log string to say "failed" instead of "rejected"
1483         when a commit fails due to an out of date checkout.
1484         This makes grepping the commit-queue log for rejected patches easier.
1485
1486         * Scripts/bugzilla-tool:
1487
1488 2009-11-03  Eric Seidel  <eric@webkit.org>
1489
1490         No review, adding commonly known committers missing from the file.
1491
1492         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
1493
1494 2009-11-03  Eric Seidel  <eric@webkit.org>
1495
1496         No review, just sort-order cleanup.
1497
1498         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
1499
1500 2009-11-03  Stephen White  <senorblanco@chromium.org>
1501
1502         (Unreviewed).
1503
1504         Add myself to committers.py.
1505
1506         * Scripts/modules/committers.py:
1507
1508 2009-11-03  Robin Dunn  <robin@alldunn.com>
1509
1510         Reviewed by Kevin Ollviier.
1511
1512         Add packaging scripts for Debian-based Linux distros.
1513         
1514         https://bugs.webkit.org/show_bug.cgi?id=31075
1515
1516         * wx/packaging/build-debian-installer.py: Added.
1517         * wx/packaging/debian: Added.
1518
1519 2009-11-03  Dan Bernstein  <mitz@apple.com>
1520
1521         Reviewed by Anders Carlsson and Beth Dakin.
1522
1523         https://bugs.webkit.org/show_bug.cgi?id=31070
1524
1525         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
1526         destroyed, it executes the value of the 'ondestroy' parameter as a
1527         script.
1528
1529         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1530         (pluginAllocate): Initialize onDestroy.
1531         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
1532         onDestroy.
1533         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1534         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
1535         specified.
1536         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
1537
1538 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1539
1540         Reviewed by Xan Lopez.
1541
1542         https://bugs.webkit.org/show_bug.cgi?id=31035
1543         [GTK] some accessibility tests hitting assertion in debug builds
1544
1545         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
1546
1547         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1548         (AccessibilityController::rootElement):
1549
1550 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
1551
1552         Reviewed by Beth Dakin.
1553
1554         Support ARIA "tab" roles
1555         https://bugs.webkit.org/show_bug.cgi?id=30842
1556
1557         * DumpRenderTree/AccessibilityUIElement.cpp:
1558         * DumpRenderTree/AccessibilityUIElement.h:
1559         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1560         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1561         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1562
1563 2009-11-01  Eric Seidel  <eric@webkit.org>
1564
1565         Reviewed by David Levin.
1566
1567         buildbots should use --exit-after-N-failures
1568         https://bugs.webkit.org/show_bug.cgi?id=30809
1569
1570         Make the bots exit after 20 failures to prevent never-ending
1571         test runs where every test spends a minute crashing.
1572
1573         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1574
1575 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1576
1577         Reviewed by Eric Seidel.
1578
1579         Turn on warnings for QtWebKit for gcc
1580         https://bugs.webkit.org/show_bug.cgi?id=30958
1581
1582         * DumpRenderTree/qt/main.cpp: 
1583         (crashHandler): Mark function NO_RETURN
1584
1585 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
1586
1587         Adding myself to the committers list.
1588
1589         * Scripts/modules/committers.py:
1590
1591 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
1592
1593         Fix an issue that Adam noticed in DRT.
1594
1595         Reviewed by Darin Adler.
1596
1597         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1598         (AccessibilityUIElement::role):
1599         Get the length of the role text, and create a buffer dynamically.
1600
1601 2009-10-30  Eric Seidel  <eric@webkit.org>
1602
1603         No review, rolling out r50105.
1604         http://trac.webkit.org/changeset/50105
1605
1606         This commit was causing:
1607         https://bugs.webkit.org/show_bug.cgi?id=30869
1608         We'll re-implement the feature a different way.
1609
1610         * Scripts/bugzilla-tool:
1611
1612 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1613
1614         Test for MSAA: Accessibility of headings is not correct
1615
1616         https://bugs.webkit.org/show_bug.cgi?id=30937
1617
1618         Reviewed by Adam Roben.
1619
1620         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1621         (AccessibilityUIElement::role):
1622         Allow the role returned to be a BSTR.
1623         (AccessibilityUIElement::description):
1624         Fix a copy/paste error.
1625
1626 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
1627
1628         Test for MSAA: Accessibility of links is wrong
1629
1630         https://bugs.webkit.org/show_bug.cgi?id=30928
1631
1632         Reviewed by Darin Adler.
1633
1634         * DumpRenderTree/AccessibilityUIElement.cpp:
1635         (getAccessibilityValueCallback):
1636         Return the accessibility value.
1637         (AccessibilityUIElement::getJSClass):
1638         Added "accessibilityValue" value.
1639
1640         * DumpRenderTree/AccessibilityUIElement.h:
1641
1642         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1643         (AccessibilityUIElement::accessibilityValue):
1644         Stubbed.
1645
1646         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1647         (AccessibilityUIElement::accessibilityValue):
1648         Stubbed.
1649
1650         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1651         (AccessibilityUIElement::accessibilityValue):
1652         Get the object's value, and return it as a JS string.
1653
1654 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
1655
1656         Fix typo in command name used by wx build system.
1657
1658         * wx/build/build_utils.py:
1659
1660 2009-10-30  Adam Barth  <abarth@webkit.org>
1661
1662         Reviewed by Darin Adler.
1663
1664         Patch v1 is a dumb default name for patches
1665         https://bugs.webkit.org/show_bug.cgi?id=30952
1666
1667         Let's use "Patch" instead.
1668
1669         * Scripts/bugzilla-tool:
1670
1671 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1672
1673         Unreviewed trivial buildfix.
1674
1675         [Qt] Buildfix for r50333.
1676
1677         * DumpRenderTree/qt/DumpRenderTree.pro:
1678
1679 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
1680
1681         Reviewed by Holger Freyther.
1682
1683         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
1684         https://bugs.webkit.org/show_bug.cgi?id=30953
1685
1686         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
1687         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
1688         makes qt DRT to share this implementation (as gtk and mac ports do).
1689
1690         * DumpRenderTree/qt/DumpRenderTree.pro:
1691         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
1692         * DumpRenderTree/qt/WorkQueue.h: Removed.
1693
1694 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1695
1696         Unreviewed potential buildbot fix.
1697
1698         Second try: Reset page history before running each test.
1699
1700         Apparently the QWebHistory::clear() keeps the current page
1701         in history which is not what we want, so we not additionally
1702         sets the history capacity to 0 (forces removing everything)
1703         and then sets it back to its original value.
1704
1705         * DumpRenderTree/qt/DumpRenderTree.cpp:
1706         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1707
1708 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1709
1710         Unreviewed potential buildbot fix.
1711
1712         Reset page history before running each test.
1713
1714         * DumpRenderTree/qt/DumpRenderTree.cpp:
1715         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1716
1717 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
1718
1719         Reviewed by Eric Seidel.
1720
1721         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
1722
1723         Bug 28420 -  Implement HTML5 <ruby> rendering
1724         (https://bugs.webkit.org/show_bug.cgi?id=28420)
1725
1726         No new tests (no functional change).
1727
1728         * Scripts/build-webkit:
1729
1730 2009-10-29  Dan Bernstein  <mitz@apple.com>
1731
1732         Reviewed by Mark Rowe.
1733
1734         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
1735         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
1736         define it.
1737
1738         * Scripts/VCSUtils.pm:
1739         * Scripts/svn-apply:
1740         * Scripts/svn-unapply:
1741
1742 2009-10-29  Xan Lopez  <xlopez@igalia.com>
1743
1744         Reviewed by Gustavo Noronha.
1745
1746         Use the GTK+ main loop instead of rolling our own mini-version of
1747         it.
1748
1749         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1750         (dump):
1751         (runTest):
1752         (webViewLoadFinished):
1753
1754 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1755
1756         Reviewed by Oliver Hunt.
1757
1758         Implement the Qt version of DRT dumpBackForwardList().
1759
1760         * DumpRenderTree/qt/DumpRenderTree.cpp:
1761         (WebCore::dumpHistoryItem):
1762         (WebCore::DumpRenderTree::dumpBackForwardList):
1763
1764 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1765
1766         Reviewed by Adam Roben.
1767
1768         Implement DRT functionality for Qt introduced in
1769         r28690 and r28705.
1770
1771         - Implemented pathToLocalResource which exposes the functionality of
1772         converting a given unix path to the correct location on Windows.
1773         - Implemented a way to remove machine-dependent information from paths
1774         in layout test results.
1775
1776         * DumpRenderTree/qt/DumpRenderTree.cpp:
1777         (WebCore::urlSuitableForTestResult):
1778         (WebCore::WebPage::javaScriptConsoleMessage):
1779         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1780         (LayoutTestController::pathToLocalResource):
1781         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1782
1783 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
1784
1785         Adding myself to the committers list.
1786
1787         * Scripts/modules/committers.py:
1788
1789 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
1790
1791         Adding myself to the committers list.
1792
1793         * Scripts/modules/committers.py:
1794
1795 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1796
1797         Reviewed by Jan Alonzo.
1798
1799         [GTK] API to start inspector for a WebView
1800         https://bugs.webkit.org/show_bug.cgi?id=22551
1801
1802         Use the new inspector API to implement the LayoutTestController
1803         interfaces used to test the inspector.
1804
1805         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1806         (webInspectorInspectWebView):
1807         (createWebView):
1808         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1809         (LayoutTestController::showWebInspector):
1810         (LayoutTestController::closeWebInspector):
1811         (LayoutTestController::evaluateInWebInspector):
1812
1813 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
1814
1815         Reviewed by Eric Seidel.
1816
1817         [Qt] WebFrame::counterValueForElementById must not be exposed
1818         https://bugs.webkit.org/show_bug.cgi?id=30882
1819
1820         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1821         (LayoutTestController::counterValueForElementById):
1822
1823 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1824
1825         Rubberstamped by Oliver Hunt.
1826
1827         Fix the warning:
1828
1829         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
1830         declared with attribute warn_unused_result".
1831
1832         by actually checking the result. In the case it is null, an
1833         error has occoured, so treat it as the other fatal errors.
1834
1835         * DumpRenderTree/qt/DumpRenderTree.cpp:
1836         (WebCore::DumpRenderTree::initializeFonts):
1837
1838 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
1839
1840         Reviewed by Darin Adler.
1841
1842         Provide a way to get counter values with layoutTestContoller
1843         https://bugs.webkit.org/show_bug.cgi?id=30555
1844
1845         Define layoutTestContoller.counterValueForElementById.
1846
1847         * DumpRenderTree/LayoutTestController.cpp:
1848         (counterValueForElementByIdCallback):
1849         (LayoutTestController::staticFunctions):
1850         * DumpRenderTree/LayoutTestController.h:
1851         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1852         (LayoutTestController::counterValueForElementById):
1853
1854 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1855
1856         Rubberstamped by Oliver Hunt.
1857
1858         Change two methods to be internal for DRT use only.
1859
1860         Part of [Qt] Review all new API in Qt 4.6
1861         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
1862
1863         * DumpRenderTree/qt/DumpRenderTree.cpp:
1864         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1865         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1866         (LayoutTestController::whiteListAccessFromOrigin):
1867
1868 2009-10-27  Eric Seidel  <eric@webkit.org>
1869
1870         Reviewed by Adam Barth.
1871
1872         REGRESSION: svn-apply exits(1) when applying a patch with a file add
1873         https://bugs.webkit.org/show_bug.cgi?id=30826
1874
1875         * Scripts/svn-apply:
1876          - Add () around all system() calls.
1877          - Use the correct system() == 0 or die instead of system() or die
1878          - Add descriptive messages to all die statements.
1879
1880 2009-10-27  Steve Block  <steveblock@google.com>
1881
1882         Reviewed by NOBODY.
1883
1884         Adds steveblock@google.com to list of committers.
1885
1886         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
1887
1888 2009-10-27  Eric Seidel  <eric@webkit.org>
1889
1890         Reviewed by Adam Barth.
1891
1892         svn-apply can exit(0) even on patch failure
1893         https://bugs.webkit.org/show_bug.cgi?id=29622
1894
1895         * Scripts/svn-apply:
1896          - Add a bunch of "or die" statements, hopefully catching all
1897            possible cases where failure could still exit(0).
1898
1899 2009-10-27  Eric Seidel  <eric@webkit.org>
1900
1901         Reviewed by Adam Barth.
1902
1903         svn-* scripts should share code through VCSUtils.pm
1904         https://bugs.webkit.org/show_bug.cgi?id=30791
1905
1906         Just moving code into a shared location.
1907
1908         * Scripts/VCSUtils.pm:
1909         * Scripts/prepare-ChangeLog:
1910         * Scripts/resolve-ChangeLogs:
1911         * Scripts/svn-apply:
1912         * Scripts/svn-create-patch:
1913         * Scripts/svn-unapply:
1914         * Scripts/update-webkit:
1915
1916 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
1917
1918         Suppress a huge number of MSVC warnings when building wxWebKit.
1919
1920         * wx/build/settings.py:
1921
1922 2009-10-26  Eric Seidel  <eric@webkit.org>
1923
1924         No review, just adding Mike Belshe to the committers list.
1925
1926         * Scripts/modules/committers.py:
1927
1928 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1929
1930         Reviewed by Darin Adler.
1931
1932         Make .rc files compile on Windows without depending on MFC headers
1933         https://bugs.webkit.org/show_bug.cgi?id=30750
1934
1935         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
1936         windows.h instead of afxres.h because it exists even when MFC is not 
1937         installed, and is all that's needed here.
1938
1939         * FindSafari/FindSafari.rc: Ditto
1940
1941 2009-10-24  Eric Seidel  <eric@webkit.org>
1942
1943         Reviewed by Adam Barth.
1944
1945         bugzilla-tool post-diff should know how to mark commit-queue=?
1946         https://bugs.webkit.org/show_bug.cgi?id=29202
1947
1948         * Scripts/bugzilla-tool:
1949          - Add --commit-queue option to post-diff, post-commits and create-bug.
1950         * Scripts/modules/bugzilla.py:
1951          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
1952          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
1953
1954 2009-10-23  Eric Seidel  <eric@webkit.org>
1955
1956         Reviewed by Adam Barth.
1957
1958         bugzilla-tool commit-queue does not notice modifications to committers.py
1959         https://bugs.webkit.org/show_bug.cgi?id=30084
1960
1961         * Scripts/bugzilla-tool:
1962          - Make commit-queue re-exec itself instead of using while(1).
1963          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
1964          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
1965
1966 2009-10-22  Eric Seidel  <eric@webkit.org>
1967
1968         Reviewed by Adam Barth.
1969
1970         commit-queue will get stuck on patches if land-patches terminates unexpectedly
1971         https://bugs.webkit.org/show_bug.cgi?id=30634
1972
1973         * Scripts/bugzilla-tool:
1974          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
1975          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
1976
1977 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
1978
1979         Reviewed by Eric Seidel.
1980
1981         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
1982
1983         https://bugs.webkit.org/show_bug.cgi?id=30763
1984
1985         * pywebsocket/mod_pywebsocket/__init__.py:
1986         * pywebsocket/mod_pywebsocket/dispatch.py:
1987         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
1988         * pywebsocket/mod_pywebsocket/standalone.py:
1989         * pywebsocket/setup.py:
1990         * pywebsocket/test/test_dispatch.py:
1991
1992 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
1993
1994         Reviewed by David Levin.
1995
1996         REGRESSION: 2 failures in run-webkit-unittests
1997         https://bugs.webkit.org/show_bug.cgi?id=30645
1998
1999         * Scripts/modules/cpp_style_unittest.py:
2000         Fixed a few test scenarios which apparently lost some spaces from 
2001         text literals.
2002
2003 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2004
2005         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2006
2007         * Scripts/webkitdirs.pm:
2008
2009 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2010
2011         Reviewed by Darin Adler.
2012
2013         Unification of using null device in perl scripts.
2014         https://bugs.webkit.org/show_bug.cgi?id=30572
2015
2016         * Scripts/VCSUtils.pm:
2017         * Scripts/bisect-builds:
2018         * Scripts/resolve-ChangeLogs:
2019         * Scripts/run-iexploder-tests:
2020         * Scripts/run-jsc:
2021         * Scripts/run-mangleme-tests:
2022         * Scripts/run-webkit-tests:
2023         * Scripts/webkitdirs.pm:
2024         Using File::Spec->devnull() instead of hard coded /dev/null.
2025
2026 2009-10-26  Eric Seidel  <eric@webkit.org>
2027
2028         Reviewed by Holger Freyther.
2029
2030         Reviewers are missing from committers.py
2031         https://bugs.webkit.org/show_bug.cgi?id=30733
2032
2033         * Scripts/modules/committers.py:
2034
2035 2009-10-23  Eric Seidel  <eric@webkit.org>
2036
2037         No review, only adding Alice to the list of reviewers.
2038
2039         * Scripts/modules/committers.py:
2040
2041 2009-10-23  Eric Seidel  <eric@webkit.org>
2042
2043         Reviewed by Eric Carlson.
2044
2045         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2046         https://bugs.webkit.org/show_bug.cgi?id=30700
2047
2048         * DumpRenderTree/mac/DumpRenderTree.mm:
2049         (resetDefaultsToConsistentValues): Update QuickTime version check.
2050
2051 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2052
2053         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2054         character measurement APIs that are private on Tiger.
2055
2056         * wx/build/settings.py:
2057
2058 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2059
2060         Reviewed by NOBODY (build fix).
2061         Build fix following bug #30696.
2062
2063         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2064         (LayoutTestController::evaluateScriptInIsolatedWorld):
2065
2066 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2067
2068         Reviewed by Sam Weinig & Geoff Garen.
2069
2070         https://bugs.webkit.org/show_bug.cgi?id=30696
2071         Enable isolated-worlds tests on mac.
2072
2073         Add private interface for DRT to invoke execution in a given world.
2074
2075         * DumpRenderTree/LayoutTestController.cpp:
2076         (evaluateScriptInIsolatedWorldCallback):
2077         (LayoutTestController::staticFunctions):
2078         * DumpRenderTree/LayoutTestController.h:
2079         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2080         (LayoutTestController::evaluateScriptInIsolatedWorld):
2081         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2082         (LayoutTestController::evaluateScriptInIsolatedWorld):
2083
2084 2009-10-21  Eric Seidel  <eric@webkit.org>
2085
2086         Reviewed by Adam Barth.
2087
2088         bugzilla-tool's "patch failed to download an apply" error should give more information
2089         https://bugs.webkit.org/show_bug.cgi?id=30632
2090
2091         * Scripts/modules/scm.py:
2092          - Use the common run_command method instead of custom POpen code.
2093          - Make run_command know how to take pipes as input.
2094         * Scripts/modules/scm_unittest.py:
2095          - Add new tests to cover change.
2096          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2097
2098 2009-10-21  Kent Tamura  <tkent@chromium.org>
2099
2100         Unreviewed.  Adding myself to the committers list.
2101
2102         * Scripts/modules/committers.py:
2103
2104 2009-10-21  Robin Dunn  <robin@alldunn.com>
2105
2106         Reviewed by Kevin Ollivier.
2107
2108         Update the Windows installer builder to work with Vista / Win 7 and with git.
2109         
2110         https://bugs.webkit.org/show_bug.cgi?id=30649
2111
2112         * wx/build/build_utils.py:
2113         * wx/packaging/build-mac-installer.py:
2114         * wx/packaging/build-win-installer.py:
2115         * wx/packaging/wxWebKitInstaller.iss.in:
2116
2117 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2118
2119         Reviewed by Gustavo Noronha.
2120
2121         [GTK] Added conditional code to avoid using
2122         gdk_window_get_root_coords if we do not have a gtk+ release newer
2123         than 2.17.3.
2124         https://bugs.webkit.org/show_bug.cgi?id=30636
2125
2126         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2127
2128 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2129
2130         Reviewed by Eric Seidel.
2131
2132         [Qt] Added dummy implementation for keepWebHistory()
2133         https://bugs.webkit.org/show_bug.cgi?id=30592
2134
2135         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2136         (LayoutTestController::keepWebHistory):
2137         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2138
2139 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2140
2141         Reviewed by Xan Lopez.
2142
2143         [GTK] Fixed the double click condition, it is not double click if
2144         we move in just in one direction.
2145         https://bugs.webkit.org/show_bug.cgi?id=30636
2146
2147         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2148
2149 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2150
2151         Reviewed by Xan Lopez.
2152
2153         [GTK] Initialize the events completly before emitting them.
2154         https://bugs.webkit.org/show_bug.cgi?id=30633
2155
2156         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2157
2158 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2159
2160         wx build fix. Fix for when linking using --as-needed with gcc.
2161
2162         * wx/browser/wscript:
2163
2164 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2165
2166         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2167         to support all the features used by CURL backend.
2168         
2169         * wx/build/settings.py:
2170         * wx/install-unix-extras:
2171
2172 2009-10-20  Anton Muhin  <antonm@chromium.org>
2173
2174         Reviewed by Adam Barth.
2175
2176         Add {ager,antonm,yurys}@chromium.org into committers.py
2177         https://bugs.webkit.org/show_bug.cgi?id=30560
2178
2179         * Scripts/modules/committers.py:
2180
2181 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2182
2183         Reviewed by Tor Arne Vestbø.
2184
2185         Make the Netscape Test plugin available to the Qt launcher.
2186
2187         * Scripts/run-launcher:
2188
2189 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2190
2191         Reviewed by David Levin.
2192
2193         Removed WebSocket runtime settings.
2194         https://bugs.webkit.org/show_bug.cgi?id=29896
2195
2196         WebSocket runtime configuration is supported by chromium/v8 only.
2197
2198         * DumpRenderTree/mac/DumpRenderTree.mm:
2199         (resetDefaultsToConsistentValues):
2200         * DumpRenderTree/win/DumpRenderTree.cpp:
2201         (resetDefaultsToConsistentValues):
2202
2203 2009-10-19  Nate Chapin  <japhet@chromium.org>
2204
2205         Reviewed by Adam Barth.
2206
2207         Add testFail() to test plugin so we can test our handling of a
2208         plugin invoke call returning false.
2209
2210         https://bugs.webkit.org/show_bug.cgi?id=30239
2211
2212         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2213         (pluginInvoke):
2214         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2215
2216 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2217
2218         Reviewed by Gustavo Noronha.
2219
2220         Enable DOM pasting when running layout tests.
2221
2222         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2223         (resetDefaultsToConsistentValues):
2224
2225 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2226
2227         Reviewed by Simon Hausmann.
2228
2229         Use the setPreferredContentsSize method instead
2230         of setFixedContentsSize, as the method has been renamed.
2231
2232         * DumpRenderTree/qt/DumpRenderTree.cpp:
2233         (WebCore::DumpRenderTree::open):
2234         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2235         (LayoutTestController::setFixedContentsSize):
2236
2237 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2238
2239         Reviewed by Dan Bernstein.
2240
2241         https://bugs.webkit.org/show_bug.cgi?id=30456
2242         Fixes for new Debug_All Windows build configuration.
2243
2244         * DumpRenderTree/win/DumpRenderTree.cpp:
2245         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2246         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2247
2248 2009-10-16  Eric Seidel  <eric@webkit.org>
2249
2250         Reviewed by Adam Barth.
2251
2252         commit-queue status bot should list which buildbot is blocking the queue
2253         https://bugs.webkit.org/show_bug.cgi?id=30452
2254
2255         Add new methods and testing.
2256
2257         * Scripts/bugzilla-tool:
2258         * Scripts/modules/buildbot.py:
2259         * Scripts/modules/buildbot_unittest.py:
2260
2261 2009-10-16  Eric Seidel  <eric@webkit.org>
2262
2263         Reviewed by Adam Barth.
2264
2265         run-webkit-tests fails when CWD is not inside a WebKit checkout
2266         https://bugs.webkit.org/show_bug.cgi?id=30451
2267
2268         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2269         * Scripts/modules/scm_unittest.py:
2270           - Remove use of original_path (we don't need to restore the CWD).
2271           - Don't use '.' to find the webkit checkout, use __file__ instead.
2272
2273 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2274
2275         Reviewed by Adam Roben.
2276
2277         Add a Debug_All configuration to build entire stack as debug.
2278         Change Debug_Internal to:
2279         - stop using _debug suffix for all WebKit/Safari binaries
2280         - not use _debug as a DLL naming suffix
2281         - use non-debug C runtime lib.
2282
2283         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2284         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2285         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2286         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2287         Add missing debug.vsprops inherited property sheet.
2288         Add Debug_All configuration.
2289         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2290         * WinLauncher/WinLauncher.vcproj:
2291         Removed extraneous definitions inherited from vsprops.
2292         Add Debug_All configuration.
2293
2294 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2295
2296         Reviewed by David Levin.
2297
2298         check-webkit-style is wrong about indent checking in namespaces
2299         in header files and a few other things
2300         https://bugs.webkit.org/show_bug.cgi?id=30362
2301
2302         The few other things include:
2303         + check-webkit-style does not require spaces around the equal sign
2304           inside 'if' statements and around binary operators that take 
2305           numeric literals.
2306         + check-webkit-style reports false errors for the / operator
2307           when part of a filename in the #include directive.
2308
2309         * Scripts/modules/cpp_style.py:
2310         Improved indentation checking and space checking around
2311         binary operators. While the checks are still not perfect,
2312         they are clearly better than before.
2313         * Scripts/modules/cpp_style_unittest.py:
2314         Added test cases for the newly supported checks and modified old
2315         test cases to match the new guidelines
2316
2317 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2318
2319         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2320
2321         * wx/build/settings.py:
2322
2323 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2324
2325         Reviewed by David Levin.
2326
2327         Add mod_pywebsocket to test Web Sockets.
2328         http://code.google.com/p/pywebsocket/
2329         https://bugs.webkit.org/show_bug.cgi?id=27490
2330
2331         * pywebsocket/COPYING: Added.
2332         * pywebsocket/MANIFEST.in: Added.
2333         * pywebsocket/README: Added.
2334         * pywebsocket/example/echo_client.py: Added.
2335         * pywebsocket/example/echo_wsh.py: Added.
2336         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2337         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2338         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2339         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2340         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2341         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2342         * pywebsocket/mod_pywebsocket/util.py: Added.
2343         * pywebsocket/setup.py: Added.
2344         * pywebsocket/test/config.py: Added.
2345         * pywebsocket/test/mock.py: Added.
2346         * pywebsocket/test/run_all.py: Added.
2347         * pywebsocket/test/test_dispatch.py: Added.
2348         * pywebsocket/test/test_handshake.py: Added.
2349         * pywebsocket/test/test_mock.py: Added.
2350         * pywebsocket/test/test_msgutil.py: Added.
2351         * pywebsocket/test/test_util.py: Added.
2352         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2353         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2354         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2355         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2356         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2357         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2358         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2359         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2360
2361 2009-10-15  James Robinson  <jamesr@google.com>
2362
2363         Reviewed by David Levin.
2364
2365         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2366
2367         https://bugs.webkit.org/show_bug.cgi?id=30426
2368
2369         * Scripts/modules/cpp_style.py:
2370         * Scripts/modules/cpp_style_unittest.py:
2371
2372 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2373
2374         Reviewed by Adam Roben.
2375
2376         Fixes <http://webkit.org/b/30411>.
2377         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2378         
2379         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2380         building Chromium.
2381
2382         * Scripts/pdevenv:
2383
2384 2009-10-15  Robin Dunn  <robin@alldunn.com>
2385
2386         Reviewed by Kevin Ollivier.
2387
2388         Add Mac package building scripts for wx.
2389         
2390         https://bugs.webkit.org/show_bug.cgi?id=30405
2391
2392         * wx/build/build_utils.py:
2393         * wx/build/settings.py:
2394         * wx/packaging/build-mac-installer.py: Added.
2395
2396 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2397
2398         Reviewed by Gustavo Noronha.
2399
2400         Enable Web Sockets support when running layout tests.
2401
2402         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2403         (resetDefaultsToConsistentValues):
2404
2405 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2406
2407         Reviewed by Gustavo Noronha.
2408
2409         Need to initialize event.button.button, since in most cases a
2410         button number is not passed as an argument.
2411
2412         * DumpRenderTree/gtk/EventSender.cpp:
2413         (mouseDownCallback):
2414         (mouseUpCallback):
2415
2416 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
2417
2418         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
2419         the OS if none was explicitly set.
2420
2421         * wx/build/settings.py:
2422
2423 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2424
2425         Reviewed by Timothy Hatcher.
2426
2427         Web Inspector: enable developers extras within inspector layout tests.
2428
2429         https://bugs.webkit.org/show_bug.cgi?id=30014
2430
2431         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2432         (LayoutTestController::showWebInspector):
2433         (LayoutTestController::closeWebInspector):
2434         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2435         (LayoutTestController::showWebInspector):
2436         (LayoutTestController::closeWebInspector):
2437
2438 2009-10-14  José Millán Soto  <jmillan@igalia.com>
2439
2440         Reviewed by Jan Alonzo.
2441
2442         GtkLauncher is using a deprecated signal
2443         https://bugs.webkit.org/show_bug.cgi?id=30364
2444
2445         Modified GtkLauncher to use notify::title signal instead of
2446         deprecated title-changed signal
2447
2448         * GtkLauncher/main.c:
2449         (notify_title_cb):
2450         (create_browser):
2451
2452 2009-10-14  Brady Eidson  <beidson@apple.com>
2453
2454         Reviewed by Sam Weinig.
2455
2456         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
2457         1 - Disables WebHistory
2458         2 - Doesn't make sense in that context anyway.
2459
2460         * DumpRenderTree/win/DumpRenderTree.cpp:
2461         (createWebViewAndOffscreenWindow):
2462
2463 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
2464
2465         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
2466         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
2467
2468         * wx/build/settings.py:
2469         * wx/install-unix-extras:
2470
2471 2009-10-14  Brady Eidson  <beidson@apple.com>
2472
2473         Reviewed by Sam Weinig.
2474
2475         WebKit Win API should provide a delegate interface for global history.
2476         https://bugs.webkit.org/show_bug.cgi?id=29905
2477
2478         * DumpRenderTree/LayoutTestController.cpp:
2479         (LayoutTestController::LayoutTestController):
2480         * DumpRenderTree/LayoutTestController.h:
2481         (LayoutTestController::dumpHistoryDelegateCallbacks):
2482         (LayoutTestController::setDumpHistoryDelegateCallbacks):
2483                 
2484         * DumpRenderTree/win/DumpRenderTree.cpp:
2485         (shouldLogHistoryDelegates):
2486         (runTest):
2487         (createWebViewAndOffscreenWindow):
2488         (main):
2489         * DumpRenderTree/win/DumpRenderTree.vcproj:
2490         
2491         Add the IWebHistoryDelegate to DRT Windows:
2492         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
2493         (wstringFromBSTR):
2494         (HistoryDelegate::HistoryDelegate):
2495         (HistoryDelegate::~HistoryDelegate):
2496         (HistoryDelegate::QueryInterface):
2497         (HistoryDelegate::AddRef):
2498         (HistoryDelegate::Release):
2499         (HistoryDelegate::didNavigateWithNavigationData):
2500         (HistoryDelegate::didPerformClientRedirectFromURL):
2501         (HistoryDelegate::didPerformServerRedirectFromURL):
2502         (HistoryDelegate::updateHistoryTitle):
2503         (HistoryDelegate::populateVisitedLinksForWebView):
2504         * DumpRenderTree/win/HistoryDelegate.h: Added.
2505
2506         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2507         (LayoutTestController::removeAllVisitedLinks):
2508
2509 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
2510
2511         Reviewed by Simon Hausmann.
2512
2513         [Qt] Implement support for setPOSIXLocale on Qt.
2514         https://bugs.webkit.org/show_bug.cgi?id=30268 
2515  
2516         * DumpRenderTree/qt/DumpRenderTree.cpp:
2517         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2518         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2519         (LayoutTestController::setPOSIXLocale):
2520         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2521
2522 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2523
2524         Unreviewed, adding myself to reviewers list.
2525
2526         * Scripts/modules/committers.py:
2527
2528 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2529
2530         Reviewed by Mark Rowe.
2531
2532         Fix null assignment so root tests work again.
2533
2534         * Scripts/webkitdirs.pm:
2535
2536 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2537
2538         Reviewed by Simon Hausmann.
2539
2540         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
2541         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
2542         This is done in preparation of implementing missing features in DRT.
2543         No functionality changes made yet.
2544
2545         * DumpRenderTree/qt/DumpRenderTree.cpp:
2546         * DumpRenderTree/qt/DumpRenderTree.pro:
2547         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
2548         (EventSender::EventSender):
2549         (EventSender::mouseDown):
2550         (EventSender::mouseUp):
2551         (EventSender::mouseMoveTo):
2552         (EventSender::leapForward):
2553         (EventSender::keyDown):
2554         (EventSender::contextClick):
2555         (EventSender::scheduleAsynchronousClick):
2556         (EventSender::frameUnderMouse):
2557         * DumpRenderTree/qt/EventSenderQt.h: Added.
2558         (EventSender::clearKillRing):
2559         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
2560         (LayoutTestController::LayoutTestController):
2561         (LayoutTestController::reset):
2562         (LayoutTestController::processWork):
2563         (LayoutTestController::maybeDump):
2564         (LayoutTestController::waitUntilDone):
2565         (LayoutTestController::notifyDone):
2566         (LayoutTestController::windowCount):
2567         (LayoutTestController::clearBackForwardList):
2568         (LayoutTestController::dumpEditingCallbacks):
2569         (LayoutTestController::dumpResourceLoadCallbacks):
2570         (LayoutTestController::queueBackNavigation):
2571         (LayoutTestController::queueForwardNavigation):
2572         (LayoutTestController::queueLoad):
2573         (LayoutTestController::queueReload):
2574         (LayoutTestController::queueScript):
2575         (LayoutTestController::provisionalLoad):
2576         (LayoutTestController::timerEvent):
2577         (LayoutTestController::encodeHostName):
2578         (LayoutTestController::decodeHostName):
2579         (LayoutTestController::setJavaScriptProfilingEnabled):
2580         (LayoutTestController::setFixedContentsSize):
2581         (LayoutTestController::setPrivateBrowsingEnabled):
2582         (LayoutTestController::setPopupBlockingEnabled):
2583         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2584         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2585         (LayoutTestController::numberOfActiveAnimations):
2586         (LayoutTestController::disableImageLoading):
2587         (LayoutTestController::dispatchPendingLoadRequests):
2588         (LayoutTestController::setDatabaseQuota):
2589         (LayoutTestController::clearAllDatabases):
2590         (LayoutTestController::whiteListAccessFromOrigin):
2591         (LayoutTestController::waitForPolicyDelegate):
2592         (LayoutTestController::overridePreference):
2593         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
2594         (LayoutTestController::isLoading):
2595         (LayoutTestController::setLoading):
2596         (LayoutTestController::shouldDumpAsText):
2597         (LayoutTestController::shouldDumpBackForwardList):
2598         (LayoutTestController::shouldDumpChildrenAsText):
2599         (LayoutTestController::shouldDumpDatabaseCallbacks):
2600         (LayoutTestController::shouldDumpStatusCallbacks):
2601         (LayoutTestController::shouldWaitUntilDone):
2602         (LayoutTestController::canOpenWindows):
2603         (LayoutTestController::shouldDumpTitleChanges):
2604         (LayoutTestController::waitForPolicy):
2605         (LayoutTestController::dumpAsText):
2606         (LayoutTestController::dumpChildFramesAsText):
2607         (LayoutTestController::dumpDatabaseCallbacks):
2608         (LayoutTestController::dumpStatusCallbacks):
2609         (LayoutTestController::setCanOpenWindows):
2610         (LayoutTestController::dumpBackForwardList):
2611         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
2612         (LayoutTestController::display):
2613         (LayoutTestController::dumpTitleChanges):
2614         (LayoutTestController::dumpSelectionRect):
2615         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
2616         (TextInputController::TextInputController):
2617         (TextInputController::doCommand):
2618         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
2619         * DumpRenderTree/qt/WorkQueue.cpp:
2620         * DumpRenderTree/qt/WorkQueue.h:
2621         * DumpRenderTree/qt/WorkQueueItem.h:
2622         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
2623         (findFrameNamed):
2624         (LoadItem::invoke):
2625         (ReloadItem::invoke):
2626         (ScriptItem::invoke):
2627         (BackForwardItem::invoke):
2628         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
2629         * DumpRenderTree/qt/jsobjects.h:
2630
2631 2009-10-13  Dmitry Titov  <dimich@chromium.org>
2632
2633         Not reviewed, adding myself to the list of reviewers.
2634
2635         * Scripts/modules/committers.py:
2636
2637 2009-10-13  Anders Carlsson  <andersca@apple.com>
2638
2639         Reviewed by Sam Weinig.
2640
2641         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
2642
2643         Make the private browsing mode testable by the test plug-in.
2644         
2645         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2646         (pluginGetProperty):
2647         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2648         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2649         (NPP_New):
2650         (NPP_SetValue):
2651
2652 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
2653
2654         No review, just adding self to the list of reviewers.
2655
2656         * Scripts/modules/committers.py:
2657
2658 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
2659
2660         Reviewed by Adam Roben.
2661
2662         Web Inspector: Use proper web view in inspector layout
2663         tests for windows.
2664
2665         https://bugs.webkit.org/show_bug.cgi?id=30298
2666
2667         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2668         (LayoutTestController::showWebInspector):
2669         (LayoutTestController::closeWebInspector):
2670         (LayoutTestController::evaluateInWebInspector):
2671
2672 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
2673
2674         Reviewed by Sam Weinig.
2675
2676         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
2677         https://bugs.webkit.org/show_bug.cgi?id=29841
2678
2679         * DumpRenderTree/mac/DumpRenderTree.mm:
2680         (resetDefaultsToConsistentValues):
2681         * DumpRenderTree/win/DumpRenderTree.cpp:
2682         (resetDefaultsToConsistentValues):
2683
2684 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
2685
2686         Reviewed by Dimitri Glazkov.
2687
2688         Chromium Port - Windows
2689         https://bugs.webkit.org/show_bug.cgi?id=29969
2690
2691         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
2692         * Scripts/webkitdirs.pm:
2693
2694 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
2695
2696         Reviewed by Darin Adler.
2697
2698         jsc scripts cleanup and Qt/GTK fix
2699         https://bugs.webkit.org/show_bug.cgi?id=30288
2700
2701         Duplicated jscPath() moved to webkitdirs.pm.
2702         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
2703         Configuration added (release/debug) to path for Qt-port on Windows.
2704
2705         * Scripts/run-javascriptcore-tests:
2706         * Scripts/run-jsc:
2707         * Scripts/run-sunspider:
2708         * Scripts/sunspider-compare-results:
2709         * Scripts/webkitdirs.pm:
2710
2711 2009-10-11  Adam Barth  <abarth@webkit.org>
2712
2713         Unreviewed.  Add Collin to committers.py.
2714
2715         * Scripts/modules/committers.py:
2716
2717 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
2718
2719         wx build fix, add bindings to source/include dirs now that there are sources there.
2720
2721         * wx/build/settings.py:
2722
2723 2009-10-09  Mark Rowe  <mrowe@apple.com>
2724
2725         Reviewed by Brady Eidson.
2726
2727         Enable plug-in halting in DumpRenderTree.
2728
2729         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
2730         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
2731
2732         * DumpRenderTree/mac/DumpRenderTree.mm:
2733         (resetDefaultsToConsistentValues):
2734         * DumpRenderTree/mac/UIDelegate.mm:
2735         (-[UIDelegate webView:shouldHaltPlugin:]):
2736
2737 2009-10-08  Brady Eidson  <beidson@apple.com>
2738
2739         Reviewed by Dan Bernstein.
2740
2741         Ask the History Delegate to populate the visited links hash.
2742         <rdar://problem/7285293> and https://webkit.org/b/29904
2743
2744         Add the ability for LayoutTestController to clear all visited links.
2745         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
2746
2747         * DumpRenderTree/LayoutTestController.cpp:
2748         (LayoutTestController::LayoutTestController):
2749         (removeAllVisitedLinksCallback):
2750         (LayoutTestController::staticFunctions):
2751         * DumpRenderTree/LayoutTestController.h:
2752         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2753         (LayoutTestController::removeAllVisitedLinks):
2754
2755         * DumpRenderTree/mac/HistoryDelegate.mm:
2756         (-[HistoryDelegate populateVisitedLinksForWebView:]):
2757
2758         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2759         (LayoutTestController::removeAllVisitedLinks):
2760         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2761         (LayoutTestController::removeAllVisitedLinks):
2762         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2763         (LayoutTestController::removeAllVisitedLinks):
2764
2765
2766 2009-10-08  Daniel Bates  <dbates@webkit.org>
2767
2768         Reviewed by Adam Roben.
2769
2770         https://bugs.webkit.org/show_bug.cgi?id=30175
2771         
2772         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
2773         the OLE drag-and-drop return value like the function it emulates. Currently, 
2774         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
2775         whether the drag-and-drop operation was successful or was cancelled.
2776         
2777         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
2778         return value according to whether the drop operation was successful or not.
2779
2780         * DumpRenderTree/win/EventSender.cpp:
2781         (doMouseUp): Added parameter oleDragAndDropReturnValue.
2782         (replaySavedEvents): Ditto.
2783         * DumpRenderTree/win/EventSender.h:
2784         * DumpRenderTree/win/UIDelegate.cpp:
2785         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
2786
2787 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
2788
2789         Reviewed by Xan Lopez.
2790
2791         [GTK] Added support for a parameter setting the button that was
2792         pressed in the mouseDown function.
2793         https://bugs.webkit.org/show_bug.cgi?id=30220
2794
2795         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2796
2797 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
2798
2799         Reviewed by Xan Lopez.
2800
2801         [GTK] Added a line to the bottom of the expected result to match
2802         the output of the test.
2803         https://bugs.webkit.org/show_bug.cgi?id=30220
2804
2805         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
2806         expected.txt:
2807
2808 2009-10-08  Adam Roben  <aroben@apple.com>
2809
2810         Use QueryInterface to get IWebInspectorPrivate
2811
2812         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
2813         accessed in a more standard way
2814
2815         Reviewed by John Sullivan and Tim Hatcher.
2816
2817         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2818         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
2819         by calling IWebViewPrivate::inspector, then use QueryInterface to get
2820         to the IWebInspectorPrivate interface.
2821
2822 2009-10-07  Adam Roben  <aroben@apple.com>
2823
2824         Implement DRT support for origin whitelisting
2825
2826         Fixes <http://webkit.org/b/30185>.
2827
2828         Reviewed by Eric Seidel.
2829
2830         * DumpRenderTree/win/DumpRenderTree.cpp:
2831         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
2832         whitelist, to match Mac DRT.
2833         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2834         (LayoutTestController::whiteListAccessFromOrigin): Call through to
2835         IWebViewPrivate::whiteListAccessFromOrigin.
2836
2837 2009-10-07  Brady Eidson  <beidson@apple.com>
2838
2839         Reviewed by Darin Adler.
2840
2841         Send title changes to the global history delegate.
2842         <rdar://problem/7285293> and https://webkit.org/b/29904
2843
2844         * DumpRenderTree/mac/HistoryDelegate.mm:
2845         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
2846
2847 2009-10-07  Adam Barth  <abarth@webkit.org>
2848
2849         Unreviewed.  Remove some folks from committers.py who were listed on
2850         the WebKit Team wiki page but who weren't actually listed as commit+.
2851         At some point, we should coorelate this list with the committers
2852         mailing list.
2853
2854         * Scripts/modules/committers.py:
2855
2856 2009-10-07  Adam Barth  <abarth@webkit.org>
2857
2858         Unreviewed.  Import a bunch of committers from the WebKit Team page on
2859         the wiki into committers.py.
2860
2861         * Scripts/modules/committers.py:
2862
2863 2009-10-07  Adam Barth  <abarth@webkit.org>
2864
2865         Unreviewed.  Added Aaron Boodman to committers.py.
2866
2867         * Scripts/modules/committers.py:
2868
2869 2009-10-07  Evan Martin  <evan@chromium.org>
2870
2871         Reviewed by Darin Adler.
2872
2873         Add API to LayoutTestController for re/setting the system locale.
2874         https://bugs.webkit.org/show_bug.cgi?id=18994
2875
2876         * DumpRenderTree/LayoutTestController.cpp:
2877         (setLocaleCallback):
2878         (LayoutTestController::staticFunctions):
2879         (LayoutTestController::setLocale):
2880         * DumpRenderTree/LayoutTestController.h:
2881
2882 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
2883
2884         Reviewed by Jan Alonzo.
2885
2886         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
2887         https://bugs.webkit.org/show_bug.cgi?id=29689
2888
2889         Build fix by adding -lfontconfig for DumpRenderTree.
2890
2891         * GNUmakefile.am:
2892
2893 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
2894
2895         Reviewed by Simon Hausmann.
2896
2897         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
2898
2899         * Scripts/run-webkit-tests:
2900
2901 2009-10-07  Xan Lopez  <xlopez@igalia.com>
2902
2903         Reviewed by Gustavo Noronha.
2904
2905         "delete" in EventSender is the backspace key, not the delete one.
2906
2907         * DumpRenderTree/gtk/EventSender.cpp:
2908         (keyDownCallback):
2909
2910 2009-10-07  Xan Lopez  <xlopez@igalia.com>
2911
2912         Reviewed by Gustavo Noronha.
2913
2914         getChildrenWithRange expects as last parameter the end index, not
2915         the length of the range. Correct this and clarify the variable
2916         names to reflect how the code works.
2917
2918         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2919         (AccessibilityUIElement::getChildrenWithRange):
2920         (AccessibilityUIElement::getChildAtIndex):
2921
2922 2009-10-06  Mark Rowe  <mrowe@apple.com>
2923
2924         Reviewed by Simon Fraser.
2925
2926         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
2927
2928         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
2929         the fact we have already changed the working directory to the top of the open source tree.
2930
2931 2009-10-06  Julie Parent  <jparent@chromium.org>
2932
2933         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
2934         rather than my committer email.
2935
2936         * Scripts/modules/committers.py:
2937
2938 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2939
2940         Reviewed by Eric Seidel.
2941
2942         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
2943
2944         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
2945         it after each layout test as it should do, making the DRT dump additional output
2946         for all of the subsequent layout tests.
2947
2948         * DumpRenderTree/qt/jsobjects.cpp:
2949         (LayoutTestController::reset):
2950
2951 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2952
2953         Reviewed by Simon Hausmann.
2954
2955         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
2956         fast/dom/assign-to-window-status.html test, which is passing as a result.
2957
2958         https://bugs.webkit.org/show_bug.cgi?id=30127
2959
2960         * DumpRenderTree/qt/DumpRenderTree.cpp:
2961         (WebCore::DumpRenderTree::DumpRenderTree):
2962         (WebCore::DumpRenderTree::statusBarMessage):
2963         * DumpRenderTree/qt/DumpRenderTree.h:
2964         * DumpRenderTree/qt/jsobjects.h:
2965         (LayoutTestController::shouldDumpStatusCallbacks):
2966         (LayoutTestController::dumpStatusCallbacks):
2967
2968 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2969
2970         Reviewed by Simon Hausmann.
2971
2972         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
2973         ignores the argument indicating which mouse button to trigger.
2974         https://bugs.webkit.org/show_bug.cgi?id=30048
2975
2976         This affects the fast/events/mouse-click-events.html layout test.
2977
2978         * DumpRenderTree/qt/jsobjects.cpp:
2979         (EventSender::mouseDown):
2980         (EventSender::mouseUp):
2981         * DumpRenderTree/qt/jsobjects.h:
2982
2983 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
2984
2985         Reviewed by Simon Hausmann.
2986
2987         [Qt] Fix the EventSender::keyDown() implementation
2988         https://bugs.webkit.org/show_bug.cgi?id=30043
2989
2990         It should post both a key press event and a key release event,
2991         just like other ports do.
2992
2993         * DumpRenderTree/qt/jsobjects.cpp:
2994         (EventSender::keyDown):
2995
2996 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
2997
2998         wx build fix. Add jpeg to the list of libs to link against.
2999
3000         * wx/build/settings.py:
3001
3002 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3003
3004         Reviewed by Simon Hausmann.
3005
3006         [Qt] EventSender::keyDown() cannot send function-key events.
3007         https://bugs.webkit.org/show_bug.cgi?id=30044
3008
3009         This affects the fast/events/keydown-function-keys.html layout test.
3010
3011         * DumpRenderTree/qt/jsobjects.cpp:
3012         (EventSender::keyDown):
3013
3014 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3015
3016         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3017         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3018
3019         * wx/build/settings.py:
3020         * wx/build/wxpresets.py:
3021
3022 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3023
3024         Reviewed by Timothy Hatcher.
3025
3026         Web Inspector: add testing harness for Web Inspector.
3027
3028         https://bugs.webkit.org/show_bug.cgi?id=30010
3029
3030         * DumpRenderTree/LayoutTestController.cpp:
3031         (showWebInspectorCallback):
3032         (closeWebInspectorCallback):
3033         (evaluateInWebInspectorCallback):
3034         (LayoutTestController::staticFunctions):
3035         * DumpRenderTree/LayoutTestController.h:
3036         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3037         (LayoutTestController::showWebInspector):
3038         (LayoutTestController::closeWebInspector):
3039         (LayoutTestController::evaluateInWebInspector):
3040         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3041         (LayoutTestController::showWebInspector):
3042         (LayoutTestController::closeWebInspector):
3043         (LayoutTestController::evaluateInWebInspector):
3044         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3045         (LayoutTestController::showWebInspector):
3046         (LayoutTestController::closeWebInspector):
3047         (LayoutTestController::evaluateInWebInspector):
3048         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3049         (LayoutTestController::showWebInspector):
3050         (LayoutTestController::closeWebInspector):
3051         (LayoutTestController::evaluateInWebInspector):
3052
3053 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3054
3055         Reviewed by Ariyha Hidayat.
3056
3057         Pass arguments to system() as a string instead of array
3058
3059         When passed as an array entries with a space fail to translate
3060         to two arguments to the child process, so instead of manually
3061         splitting all the entries in @buildArgs we pass the whole thing
3062         as a string instead.
3063
3064         * Scripts/webkitdirs.pm:
3065
3066 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3067
3068         Reviewed by David Levin.
3069
3070         check-webkit-style misses whitespace errors for operators:
3071         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3072         https://bugs.webkit.org/show_bug.cgi?id=30021
3073
3074         * Scripts/modules/cpp_style.py:
3075         Added the operators mentioned above to the same list as == and !=.
3076
3077 2009-10-02  Julie Parent  <jparent@chromium.org>
3078
3079         Unreviewed.
3080
3081         Adding myself and Ojan Vafai as committers, because we are committers.
3082
3083         * Scripts/modules/committers.py:
3084
3085 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3086
3087         Reviewed by Adam Roben.
3088
3089         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3090         this will help the patch merging process when TryBots are used.
3091
3092         * Scripts/svn-create-patch:
3093
3094 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
3095
3096         Reviewed by Simon Hausmann.
3097
3098         [Qt] Implement layoutTestController.overridePreference().
3099         https://bugs.webkit.org/show_bug.cgi?id=29970
3100
3101         * DumpRenderTree/qt/DumpRenderTree.cpp:
3102         (WebCore::WebPage::WebPage):
3103         (WebCore::WebPage::resetSettings):
3104         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3105         * DumpRenderTree/qt/jsobjects.cpp:
3106         (LayoutTestController::reset):
3107         (LayoutTestController::setPrivateBrowsingEnabled):
3108         (LayoutTestController::setPopupBlockingEnabled):
3109         (LayoutTestController::overridePreference):
3110         * DumpRenderTree/qt/jsobjects.h:
3111
3112 2009-10-01  Chris Marrin  <cmarrin@apple.com>
3113
3114         Reviewed by Oliver Hunt.
3115
3116         Turn on ENABLE_3D_CANVAS in TOT
3117         https://bugs.webkit.org/show_bug.cgi?id=29906
3118
3119         * Scripts/build-webkit:
3120
3121 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3122
3123         Rubberstamped by Simon Hausmann.
3124
3125         Enable HTTP tests for Qt
3126
3127         * Scripts/run-webkit-tests:
3128
3129 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3130
3131         Reviewed by Dimitri Glazkov.
3132
3133         build-webkit --chromium now also works on cygwin.
3134
3135         https://bugs.webkit.org/show_bug.cgi?id=29973
3136
3137         * Scripts/webkitdirs.pm:
3138
3139 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3140
3141         Reviewed by Simon Hausmann.
3142
3143         [Qt] Don't use TCmalloc in DumpRenderTree
3144         https://bugs.webkit.org/show_bug.cgi?id=27029
3145
3146         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3147
3148         * DumpRenderTree/qt/DumpRenderTree.pro:
3149
3150 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3151
3152         Reviewed by Simon Hausmann.
3153
3154         [Qt] Implement eventSender.scheduleAsynchronousClick().
3155
3156         https://bugs.webkit.org/show_bug.cgi?id=29931
3157
3158         * DumpRenderTree/qt/jsobjects.cpp:
3159         (EventSender::scheduleAsynchronousClick):
3160         * DumpRenderTree/qt/jsobjects.h:
3161
3162 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3163
3164         Reviewed by Simon Hausmann.
3165
3166         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
3167         fast/events/open-window-from-another-frame.html from the Skipped list.
3168
3169         https://bugs.webkit.org/show_bug.cgi?id=29930
3170
3171         * DumpRenderTree/qt/jsobjects.cpp:
3172         (LayoutTestController::setPopupBlockingEnabled):
3173         * DumpRenderTree/qt/jsobjects.h:
3174
3175 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
3176
3177         Unreviewed.
3178
3179         Added myself to the list of committers.
3180
3181         * Scripts/modules/committers.py:
3182
3183 2009-09-30  Eric Seidel  <eric@webkit.org>
3184
3185         No review, just adding Geoff to the list of reviewers.
3186
3187         * Scripts/modules/committers.py:
3188
3189 2009-09-30  Dan Bernstein  <mitz@apple.com>
3190
3191         Reviewed by Sam Weinig.
3192
3193         Added the WebKit Layout Tests fonts that are referenced in
3194         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
3195
3196         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
3197         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
3198
3199 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3200
3201         Reviewed by David Kilzer.
3202
3203         Make sunspider scripts work on Windows platform.
3204         https://bugs.webkit.org/show_bug.cgi?id=29656
3205
3206         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
3207         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
3208         * Scripts/webkitdirs.pm: currentPerlPath() added.
3209
3210 2009-09-29  Brady Eidson  <beidson@apple.com>
3211
3212         Rubberstamped by Dan Bernstein.
3213
3214         Fix license and some sorting in new files.
3215
3216         * DumpRenderTree/mac/HistoryDelegate.h:
3217         * DumpRenderTree/mac/HistoryDelegate.mm:
3218
3219 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
3220
3221         Reviewed by David Kilzer.
3222
3223         Fixed how error codes are handled.
3224         https://bugs.webkit.org/show_bug.cgi?id=29898
3225
3226         * Scripts/update-webkit:
3227         * Scripts/update-webkit-chromium:
3228
3229 2009-09-29  Brady Eidson  <beidson@apple.com>
3230
3231         Reviewed by John Sullivan.
3232
3233         Updated way-out-of-date sorting throughout the dump methods/flags.
3234
3235         * DumpRenderTree/LayoutTestController.cpp:
3236         (LayoutTestController::LayoutTestController):
3237         (dumpAsPDFCallback):
3238         (dumpAsTextCallback):
3239         (dumpFrameLoadCallbacksCallback):
3240         (dumpResourceLoadCallbacksCallback):
3241         (LayoutTestController::staticFunctions):
3242
3243         * DumpRenderTree/LayoutTestController.h:
3244         (LayoutTestController::dumpAsText):
3245         (LayoutTestController::setDumpAsText):
3246         (LayoutTestController::dumpFrameLoadCallbacks):
3247         (LayoutTestController::setDumpFrameLoadCallbacks):
3248         (LayoutTestController::dumpSelectionRect):
3249         (LayoutTestController::setDumpSelectionRect):
3250         (LayoutTestController::dumpSourceAsWebArchive):
3251         (LayoutTestController::setDumpSourceAsWebArchive):
3252         (LayoutTestController::dumpStatusCallbacks):
3253         (LayoutTestController::setDumpStatusCallbacks):
3254         (LayoutTestController::dumpTitleChanges):
3255         (LayoutTestController::setDumpTitleChanges):
3256         (LayoutTestController::dumpWillCacheResponse):
3257         (LayoutTestController::setDumpWillCacheResponse):
3258
3259 2009-09-29  Brady Eidson  <beidson@apple.com>
3260
3261         Reviewed by John Sullivan.
3262
3263         WebKit Mac API should provide a delegate interface for global history.
3264         <rdar://problem/7042773> and https://webkit.org/b/29904
3265
3266         Adding the dumping of global history delegate callbacks.
3267
3268         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3269
3270         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
3271         * DumpRenderTree/mac/DumpRenderTree.mm:
3272         (createWebViewAndOffscreenWindow):
3273         (allocateGlobalControllers):
3274         (shouldLogFrameLoadDelegates):
3275         (shouldLogHistoryDelegates):
3276         (runTest):
3277
3278         Dump history delegate callbacks:
3279         * DumpRenderTree/mac/HistoryDelegate.h: Added.
3280         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
3281         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
3282         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
3283         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
3284
3285 2009-09-29  Daniel Bates  <dbates@webkit.org>
3286
3287         Reviewed by Adam Roben.
3288
3289         https://bugs.webkit.org/show_bug.cgi?id=28902
3290         
3291         Fixes an issue where the drop effect returned by Window Dump Render Tree 
3292         was always DROPEFFECT_NONE (since it was hard coded to do so).
3293         
3294         This patch corrects this issue by determining the actual drop effect 
3295         performed by the corresponding drag-and-drop operation so that we can 
3296         return it.
3297
3298         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
3299         (DraggingInfo::DraggingInfo):
3300         (DraggingInfo::performedDropEffect): Added method.
3301         (DraggingInfo::setPerformedDropEffect): Added method.
3302         * DumpRenderTree/win/EventSender.cpp:
3303         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
3304         Moved delete draggingInfo to UIDelegate::doDragDrop.
3305         * DumpRenderTree/win/UIDelegate.cpp:
3306         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
3307
3308 2009-09-29  Dan Bernstein  <mitz@apple.com>
3309
3310         Reviewed by Adam Roben.
3311
3312         Remove copying of unnecessary or nonexistent files from the ImageDiff
3313         post-build event.
3314
3315         * DumpRenderTree/win/ImageDiff.vcproj:
3316
3317 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3318
3319         Reviewed by David Kilzer.
3320
3321         [Qt] Make build-webkit script work on Windows
3322         https://bugs.webkit.org/show_bug.cgi?id=29802
3323
3324         * Scripts/run-webkit-tests:
3325         * Scripts/webkitdirs.pm:
3326          - Removed unnecessary -p switch for mkdir on Windows.
3327          - Use canonical path, which uses slashes or backslashes depends on platform.
3328          - isWindows() only test for Windows and not for Cyqwin.
3329
3330 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3331
3332         Reviewed by Simon Hausmann.
3333
3334         Fix time measurement in build-webkit after refactoring done in r48853.
3335
3336         * Scripts/build-webkit:
3337
3338 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3339
3340         Reviewed by Tor Arne Vestbø.
3341
3342         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
3343         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
3344
3345         * DumpRenderTree/qt/DumpRenderTree.cpp:
3346         (WebCore::WebPage::WebPage):
3347
3348 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
3349
3350         Reviewed by Simon Hausmann.
3351
3352         [Qt] Implement eventSender.contextClick().
3353         https://bugs.webkit.org/show_bug.cgi?id=29821
3354
3355         * DumpRenderTree/qt/jsobjects.cpp:
3356         (EventSender::contextClick):
3357         * DumpRenderTree/qt/jsobjects.h:
3358
3359 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3360
3361         Reviewed by Eric Seidel.
3362
3363         Add experimentalWebSocketsEnabled in WebPreferences.
3364         https://bugs.webkit.org/show_bug.cgi?id=28941
3365
3366         * DumpRenderTree/mac/DumpRenderTree.mm:
3367         (resetDefaultsToConsistentValues):
3368         * DumpRenderTree/win/DumpRenderTree.cpp:
3369         (resetDefaultsToConsistentValues):
3370
3371 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
3372
3373         Reviewed by David Kilzer.
3374
3375         Integrated chromium port building into webkit tools update-webkit and
3376         build-webkit.
3377
3378         https://bugs.webkit.org/show_bug.cgi?id=29749
3379
3380         * Scripts/build-webkit: When --chromium is specified, will build
3381           the chromium port (currently only Mac is supported).
3382         * Scripts/update-webkit: When --chromium is specified, delegates to
3383           update-webkit-chromium.
3384         * Scripts/webkitdirs.pm: Added chromium specific defs.
3385         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
3386           chromium port's dependencies and update its project files.
3387
3388 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3389
3390         Unreviewed.
3391
3392         Add myself to list of committers.
3393
3394         * Scripts/modules/committers.py:
3395
3396 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3397
3398         Reviewed by Darin Adler.
3399
3400         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
3401         https://bugs.webkit.org/show_bug.cgi?id=29771
3402
3403         * Scripts/run-webkit-tests:
3404
3405 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3406
3407         Reviewed by Simon Hausmann.
3408
3409         [Qt] Implement layoutTestController.waitForPolicyDelegate.
3410         https://bugs.webkit.org/show_bug.cgi?id=25037
3411
3412         * DumpRenderTree/qt/DumpRenderTree.cpp:
3413         (WebCore::WebPage::acceptNavigationRequest):
3414         * DumpRenderTree/qt/DumpRenderTree.pro:
3415         * DumpRenderTree/qt/jsobjects.cpp:
3416         (LayoutTestController::reset):
3417         (LayoutTestController::notifyDone):
3418         (LayoutTestController::waitForPolicyDelegate):
3419         * DumpRenderTree/qt/jsobjects.h:
3420         (LayoutTestController::waitForPolicy):
3421
3422 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3423
3424         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
3425
3426         Reviewed by Eric Seidel.
3427
3428         The -o|--open switch uses the open(1) command on Mac OS X to
3429         open the bug URL in the default web browser.  If there are
3430         similar mechanisms on other platforms, they may be added later.
3431
3432         * Scripts/mark-bug-fixed:
3433         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
3434         options.
3435         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
3436         code into main() and extracted prompting code into
3437         _prompt_user_for_correctness().
3438         (MarkBugFixed._open_bug_in_web_browser): Added.
3439         (MarkBugFixed._prompt_user_for_correctness): Added.
3440         (MarkBugFixed.main): Added logging code from
3441         _determine_bug_id_and_svn_revision().  Added code to call
3442         _open_bug_in_web_browser() if the switch is set.  Added code to
3443         call _prompt_user_for_correctness() when needed.
3444         * Scripts/modules/bugzilla.py:
3445         (Bugzilla.short_bug_url_for_bug_id): Added.
3446
3447 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3448
3449         svn-unapply and svn-apply don't work when used outside multiple svn working directories
3450
3451         <http://webkit.org/b/29744>
3452         <rdar://problem/7252905>
3453
3454         Reviewed by Eric Seidel.
3455
3456         Some users have a workflow where svn-create-patch, svn-apply and
3457         svn-unapply are used outside of multiple svn working
3458         directories.  Instead of aborting the scripts in these cases,
3459         print a warning and assume that Subversion is being used.
3460
3461         * Scripts/VCSUtils.pm:
3462         (determineVCSRoot): Call warn() instead of die() if both isGit()
3463         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
3464         to enforce the assumption about Subversion, then return
3465         determineSVNRoot().
3466         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
3467         VCSUtils.pm.  They both already cache their values and checking
3468         here is redundant since determineVCSRoot() is called later.
3469
3470 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
3471
3472         Reviewed by Gustavo Noronha.
3473
3474         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3475         https://bugs.webkit.org/show_bug.cgi?id=29689
3476
3477         Load test fonts through FontConfig before each test.
3478         This ensures a more proper rendering of the tests.
3479
3480         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3481         (initializeFonts):
3482         (runTest):
3483         (main):
3484         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
3485         * GNUmakefile.am:
3486
3487 2009-09-25  David Kilzer  <ddkilzer@apple.com>
3488
3489         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
3490
3491         Reviewed by Eric Seidel.
3492
3493         * Scripts/mark-bug-fixed:
3494         (MarkBugFixed.__init__): Added -u|--update-only switch to list
3495         of parse options.
3496         (MarkBugFixed.main): When -u|--update-only is specified, add a
3497         comment to the bug without marking it Resolved/Fixed.
3498
3499 2009-09-25  Darin Adler  <darin@apple.com>
3500
3501         Reviewed by Geoffrey Garen.
3502
3503         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
3504         out, just as we do for the resources directory.
3505
3506 2009-09-25  Adam Barth  <abarth@webkit.org>
3507
3508         Unreviewed.  Added Tony to committers.py because he's a
3509         committer now.
3510
3511         * Scripts/modules/committers.py:
3512
3513 2009-09-25  Eric Seidel  <eric@webkit.org>
3514
3515         Reviewed by Simon Fraser.
3516
3517         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
3518         https://bugs.webkit.org/show_bug.cgi?id=28624
3519
3520         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
3521
3522         * DumpRenderTree/mac/DumpRenderTree.mm:
3523         (resetDefaultsToConsistentValues):
3524
3525 2009-09-25  Eric Seidel  <eric@webkit.org>
3526
3527         Reviewed by Adam Barth.
3528
3529         commit-queue should auto-retry patches which fail to commit due to out of date files
3530         https://bugs.webkit.org/show_bug.cgi?id=28316
3531
3532         * Scripts/bugzilla-tool:
3533          - Handle new CheckoutNeedsUpdate exception.
3534         * Scripts/modules/logging_unittest.py:
3535          - Call the ScriptError constructor correctly (this test had regressed).
3536         * Scripts/modules/scm.py:
3537          - Added the ability to define custom error handlers for run_command
3538            and added a commit_error_handler which throws CheckoutNeedsUpdate
3539            instead of ScriptError.
3540          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
3541         * Scripts/modules/scm_unittest.py:
3542          - Added tests of new error handlers.
3543
3544 2009-09-25  Eric Seidel  <eric@webkit.org>
3545
3546         Reviewed by Adam Barth.
3547
3548         commit-queue should give better feedback when failing a patch
3549         https://bugs.webkit.org/show_bug.cgi?id=29316
3550
3551         * Scripts/bugzilla-tool:
3552          - Update ScriptError uses to the new constructor format.
3553          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
3554            so that we can print to both stdout as well as an output buffer for error reporting.
3555          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
3556          - Use e.message_with_output() when failing a patch (this is the real fix here).
3557            I also removed use of "This patch will require manual commit." as that's not always true.
3558          - Add missing word "bug" from log message.
3559         * Scripts/modules/scm.py:
3560          - Make ScriptError save a bunch more data so that error messages can be nicer.
3561          - Update ScriptError callers.
3562
3563 2009-09-24  John Gregg  <johnnyg@google.com>
3564
3565         Reviewed by Eric Seidel.
3566
3567         Enable switch for notifications (experimental) in Page Settings
3568         https://bugs.webkit.org/show_bug.cgi?id=28930
3569
3570         Now that desktop notifications are controlled by run-time switch,
3571         set that switch to true for DumpRenderTree.
3572
3573         * DumpRenderTree/mac/DumpRenderTree.mm:
3574         (resetDefaultsToConsistentValues):
3575         * DumpRenderTree/win/DumpRenderTree.cpp:
3576         (resetDefaultsToConsistentValues):
3577         * DumpRenderTree/win/UIDelegate.cpp:
3578         (UIDelegate::QueryInterface):
3579
3580 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
3581
3582         wx build fix. SnowLeopard fixes for Mac dependencies.
3583
3584         * wx/build/build_utils.py:
3585         * wx/build/settings.py:
3586         * wx/install-unix-extras:
3587
3588 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3589
3590         Reviewed by Oliver Hunt.
3591
3592         Add support for DRT to send mouse wheel events.
3593
3594         https://bugs.webkit.org/show_bug.cgi?id=29348
3595         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
3596
3597         * DumpRenderTree/gtk/EventSender.cpp:
3598         (mouseWheelToCallback):
3599
3600 2009-09-17  Eric Seidel  <eric@webkit.org>
3601
3602         Reviewed by David Levin.
3603
3604         commit-queue needs web-based status reporting
3605         https://bugs.webkit.org/show_bug.cgi?id=29307
3606
3607         Add a first-pass web-based status for the commit-queue.
3608         The bot is currently reachable at:
3609         http://webkit-commit-queue.appspot.com/
3610
3611         * CommitQueueStatus/app.yaml: Added.
3612          - Application description file required by App Engine.
3613         * CommitQueueStatus/filters/__init__.py: Added.
3614          - Required by python to treat 'filters' as a module.
3615         * CommitQueueStatus/filters/webkit_extras.py: Added.
3616          - Support for turning 'bug 123' and 'patch 123' into links.
3617            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
3618         * CommitQueueStatus/index.html: Added.
3619         * CommitQueueStatus/index.yaml: Added.
3620          - Some auto-generated file from app engine.
3621         * CommitQueueStatus/queue_status.py: Added.
3622          - The core logic of this bot.  We could eventually split this file out into pieces.
3623         * CommitQueueStatus/stylesheets/main.css: Added.
3624          - Some basic lame-o CSS to make the page look less awful.
3625         * CommitQueueStatus/update_status.html: Added.
3626          - The form that the commit-queue (or a human) can use to update the status.
3627         * Scripts/bugzilla-tool:
3628          - Add some very basic update_status calls.
3629         * Scripts/modules/statusbot.py: Added.
3630          - Knows how to post to the CommitQueueStatus web application.
3631
3632 2009-09-24  David Kilzer  <ddkilzer@apple.com>
3633
3634         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
3635
3636         Reviewed by Adam Roben.
3637
3638         * Scripts/mark-bug-fixed:
3639         (MarkBugFixed.__init__): Added -m|--comment switch to list of
3640         parse options.
3641         (MarkBugFixed.main): When specified, prepend comment from
3642         -m|--comment command-line switch to the bug comment.
3643
3644 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3645
3646         Reviewed by Jan Alonzo.
3647
3648         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
3649         https://bugs.webkit.org/show_bug.cgi?id=29693
3650
3651         Show the window, to be able to synthesize events correctly.
3652
3653         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3654         (runTest):
3655         (main):
3656
3657 2009-09-24  Oliver Hunt  <oliver@apple.com>
3658
3659         Reviewed by NOBODY(rollout)
3660
3661         Roll out r48712 as it is incorrect.
3662
3663         * DumpRenderTree/mac/ObjCController.m:
3664         (+[ObjCController isSelectorExcludedFromWebScript:]):
3665         (+[ObjCController webScriptNameForSelector:]):
3666
3667 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
3668
3669         Reviewed by Eric Seidel.
3670
3671         https://bugs.webkit.org/show_bug.cgi?id=29005
3672         The indices of RuntimeArray should be enumerated like for a regular array.
3673
3674         * DumpRenderTree/mac/ObjCController.m:
3675         (+[ObjCController isSelectorExcludedFromWebScript:]):
3676         (+[ObjCController webScriptNameForSelector:]):
3677         (-[ObjCController arrayOfString]):
3678
3679 2009-09-23  David Kilzer  <ddkilzer@apple.com>
3680
3681         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
3682
3683         Reviewed by Darin Adler.
3684
3685         Also fixed a bug where specifying a revision on the command-line