38e61001ac2650c53eb6ab0c13814e413d26846f
[WebKit-https.git] / WebKitTools / ChangeLog
1 2008-03-06  Kevin McCullough  <kmccullough@apple.com>
2
3         Reviewed by Sam and Tim.
4
5         <rdar://5631450> Drosera: breakpoint indicators disappear after the
6         script is finished running.
7         - If there is a pre-existing breakpoint on a line when the file is
8         updated we need to redraw it.
9
10         * Drosera/debugger.js:
11
12 2008-03-06  Brady Eidson  <beidson@apple.com>
13
14         Tiger build fix...?
15
16         * DumpRenderTree/mac/WatchdogMac.mm:
17
18 2008-03-06  Brady Eidson  <beidson@apple.com>
19
20         Reviewed by Darin
21
22         Added a cross-platform Watchdog thread to DRT.
23
24         The current watchdog in both DRTWin and DRTMac is Timer based.  Therefore, deadlocks and long running
25         main thread hangs still affect DRT.
26
27         By placing the watchdog on a thread and having DRT "check in" after each test, long-running hangs
28         and true deadlocks can be caught.
29
30         There is one hook for platform specific code.  As I did my development and testing on Mac, and Mac has
31         `sample` available, the Mac implementation of this hook samples the process before it is killed.
32
33         I arbitrarily chose 30 seconds as the timeout for now - this can be tweaked easily if we find a need.
34
35         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
36         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added LINKER_DISPLAYS_MANGLED_NAMES
37
38         * DumpRenderTree/ForwardingHeaders/wtf/Locker.h: Added.
39         * DumpRenderTree/ForwardingHeaders/wtf/Threading.h: Added.
40
41         * DumpRenderTree/Watchdog.cpp: Added.
42         (Watchdog::Watchdog):
43         (Watchdog::~Watchdog):
44         (Watchdog::start):
45         (Watchdog::stop):
46         (Watchdog::checkIn):
47         (Watchdog::setWatchdogInterval):
48         (Watchdog::handleHang):
49         (Watchdog::watchdogThreadStart):
50         (Watchdog::watchdogThread):
51         * DumpRenderTree/Watchdog.h: Added.
52
53         * DumpRenderTree/mac/WatchdogMac.h: Added.
54         * DumpRenderTree/mac/WatchdogMac.mm: Added.
55         (WatchdogMac::handleHang): Sample the process and write it out to a file
56
57         * DumpRenderTree/mac/DumpRenderTree.mm:
58         (dumpRenderTree): Setup and start the watchdog before running any tests
59         (runTest): Checkin with the watchdog after each test
60
61 2008-03-05  Alp Toker  <alp@atoker.com>
62
63         Attempt to get the autotools build working again on the bot with
64         build-webkit.
65
66         Force the use of /bin/bash since we seem to have bash-isms in the
67         configure script right now.
68
69         * Scripts/webkitdirs.pm:
70
71 2008-03-05  Alp Toker  <alp@atoker.com>
72
73         Re-attempt to switch to the autotools build system for GTK+.
74
75         Change scripts to continue when distclean fails.
76
77         * Scripts/webkitdirs.pm:
78
79 2008-03-05  Alp Toker  <alp@atoker.com>
80
81         Force qmake for the GTK+ build until we get the build bot to succeed
82         with autotools (currently dies at make distclean)
83
84         * Scripts/webkitdirs.pm:
85
86 2008-03-04  Alp Toker  <alp@atoker.com>
87
88         Reviewed by Mark Rowe.
89
90         Switch the default GTK+ build system from qmake to autotools.
91
92         qmake can still be used by defining WEBKIT_BUILD_SYSTEM=qmake
93
94         * Scripts/build-webkit:
95         * Scripts/run-launcher:
96         * Scripts/run-webkit-tests:
97         * Scripts/webkitdirs.pm:
98
99 2008-03-04  Sam Weinig  <sam@webkit.org>
100
101         Reviewed by Darin Adler.
102
103         * Scripts/do-webcore-rename: Update renaming plan.
104
105 2008-03-02  Brent Fulgham  <bfulgham@gmail.com>
106
107         Reviewed by Alp Toker.
108
109         Remove some needless LIBS.
110
111         * GNUmakefile.am:
112
113 2008-03-02  Alp Toker  <alp@atoker.com>
114
115         Reviewed by Mark Rowe.
116
117         Split the WebKit GTK+ build out of the WebCore build and change the
118         shared object name to match the package name.
119
120         * GNUmakefile.am:
121
122 2008-03-01  Mark Rowe  <mrowe@apple.com>
123
124         Reviewed by Tim Hatcher.
125
126         Update Xcode configuration to support building debug and release from the mysterious future.
127
128         * DumpRenderTree/mac/Configurations/Base.xcconfig:
129
130 2008-02-29  David Kilzer  <ddkilzer@apple.com>
131
132         Pass the correct configuration switch (--Debug|--Release) to build-testkjs.
133
134         Reviewed by Dan.
135
136         Originally broken in r26838.
137
138         * Scripts/run-javascriptcore-tests: Push configuration switch onto @xcodeArgs
139         not local, unused @args variable.
140
141 2008-02-29  David Kilzer  <ddkilzer@apple.com>
142
143         Bug 15754: webarchive layout tests fail when WebKit directory path contains symlinks
144
145         <http://bugs.webkit.org/show_bug.cgi?id=15754>
146
147         Reviewed by Geoff and Darin.
148
149         We were using -[NSFileManager currentDirectoryPath] to get the current working directory,
150         then removing that path from all file:/// URLs in the WebArchive output so these tests
151         would pass no matter where they were run.
152
153         The problem was that -[NSFileManager currentDirectoryPath] resolves symlinks in the
154         current working directory, but the WebArchive does not.  This left the current working
155         directory in all file:/// URLs in the test output, and thus all tests failed, for any
156         developer that used symlinks to get to their WebKit source directory.
157
158         The fix is to look backwards for "/LayoutTests/" in the URL we're passed, and simply
159         remove the current working directory path (no matter what it is) after "file://" but
160         before "/LayoutTests/".  
161
162         * DumpRenderTree/mac/DumpRenderTree.mm:
163         (normalizeWebResourceURL): Removed unused oldURLBase argument.  We now replace the
164         current working directory as described above.
165         (convertWebResourceResponseToDictionary): Remove unused oldURLBase argument.  Update
166         calls to normalizeWebResourceURL().
167         (serializeWebArchiveToXML): Removed now unused cwdURL variable.  Update calls to
168         normalizeWebResourceURL() and convertWebResourceResponseToDictionary().
169
170 2008-02-26  Robin Dunn <robin@alldunn.com>
171
172         Reviewed by Kevin Ollivier.
173
174         Improvements to the wx build script.
175
176         http://bugs.webkit.org/show_bug.cgi?id=17492
177
178         * wx/build-wxwebkit:
179         - Update the Windows dll copying logic to copy dlls inside WebKitLibraries/win
180         - Allow the build script to properly find wxPython includes under different setups
181         - Make sure WX_PREFIX is set to WXWIN (wxWindows dir environment var.) if not defined
182
183 2008-02-26  Timothy Hatcher  <timothy@apple.com>
184
185         Reviewed by Darin Adler.
186
187         * Scripts/build-webkit: Add --universal and --64-bit flags to make building
188         64-bit architectures easy. Combine the two flags to build 4-way universal.
189         * Makefile: Add "64" and "64u" make rules. Fix the universal rule to return
190         non-zero when the build failes.
191
192 2008-02-26  Jessica Kahn  <jess@apple.com>
193
194         Reviewed by Darin.
195
196         * Scripts/gdb-safari: Set WEBKIT_UNSET_DYLD_FRAMEWORK_PATH in gdb's environment,
197         so that Safari inherits it when launched. Preexisting code in WebKit checks this
198         environment variable, and if set, unsets DYLD_FRAMEWORK_PATH, so that applications
199         launched by Safari continue to use the standard system WebKit.
200
201 2008-02-25  Adam Roben  <aroben@apple.com>
202
203         Fix run-webkit-tests after r30394
204
205         * Scripts/webkitdirs.pm: Never append _debug to FindSafari's
206         executable name.
207
208 2008-02-24  Darin Adler  <darin@apple.com>
209
210         * Scripts/do-webcore-rename: Make some updates based on a trial run of
211         the renaming script.
212
213 2008-02-24  Darin Adler  <darin@apple.com>
214
215         * Scripts/do-webcore-rename: More renaming plans.
216
217 2008-02-23  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
218
219         Rubber stamped by Darin.
220
221         Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
222         whitespaces introduced in the previous commit.
223
224         * GNUmakefile.am:
225
226 2008-02-23  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
227
228         Rubber-stamped by Darin.
229
230         * GNUmakefile.am: Add both GLOBALDEPS and WEBKITDEPS instead of DEPENDENCIES.
231
232 2008-02-23  David Kilzer  <ddkilzer@apple.com>
233
234         Please clarify licensing for some files
235         <http://bugs.webkit.org/show_bug.cgi?id=14970>
236
237         Reviewed by Darin.
238
239         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Added
240         copyright statement.  Replaced license with newer Apple BSD-style license.
241         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Ditto.
242         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Ditto.
243         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Ditto.
244         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Ditto.
245         * DumpRenderTree/win/TestNetscapePlugin/main.c: Ditto.
246         * mangleme/LICENSE: Added (LGPL).
247
248 2008-02-22  Anders Carlsson  <andersca@apple.com>
249
250         Reviewed by Adam.
251
252         <rdar://problem/5748781> 
253         https://bugs.webkit.org/show_bug.cgi?id=17413
254         REGRESSION: Latest Nightly doesn't load Java plugin w/Safari 3.1b
255         
256         Copy the Java plug-in over to the new location.
257         
258         * FindSafari/FindSafari.cpp:
259         (_tmain):
260
261 2008-02-22  Anders Carlsson  <andersca@apple.com>
262
263         Reviewed by Adam.
264
265         <rdar://problem/5747325> REGRESSION: HTTP layout tests hang
266         
267         * DumpRenderTree/win/DumpRenderTree.cpp:
268         (runTest):
269         Init the URL request with the correct timeout.
270
271 2008-02-21  Mike Auty  <mike.auty@gmail.com>
272
273         Reviewed by Alp Toker.
274
275         http://bugs.webkit.org/show_bug.cgi?id=17445
276         [GTK] WebKit doesn't compile with LDFLAGS="-Wl,--as-needed"
277
278         GTK+/autotools build system improvements
279
280         The GNUmakefile.am files make use of the LDFLAGS variable to include library
281         additions such as -ljpeg etc.  Unfortunately, if these inclusions aren't made
282         in LIBADD/LDADD variables, then they are mis-ordered during the linking.
283
284         The as-needed flag discards libraries whose functions have not been needed by
285         earlier libraries, which therefore makes the ordering important.
286
287         This moves all -l library inclusion statements from LDFLAGS variables to
288         LIBADD/LDADD variables.
289
290         * GNUmakefile.am:
291
292 2008-02-20  Brent Fulgham  <bfulgham@gmail.com>
293
294         Reviewed by Alp.
295
296         - http://bugs.webkit.org/show_bug.cgi?id=17428
297           Reenable a Windows-based launcher
298
299         This patch reenables the venerable Spinneret application,
300         changing its name to match the other lanch applications.
301
302         * WinLauncher: Added.
303         * WinLauncher/WinLauncher.cpp: Added.
304         (WinLauncherWebHost::updateAddressBar):
305         (WinLauncherWebHost::QueryInterface):
306         (WinLauncherWebHost::AddRef):
307         (WinLauncherWebHost::Release):
308         (resizeSubViews):
309         (_tWinMain):
310         (MyRegisterClass):
311         (InitInstance):
312         (WndProc):
313         (MyEditProc):
314         (About):
315         (loadURL):
316         * WinLauncher/WinLauncher.h: Added.
317         (WinLauncherWebHost::WinLauncherWebHost):
318         (WinLauncherWebHost::didStartProvisionalLoadForFrame):
319         (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
320         (WinLauncherWebHost::didFailProvisionalLoadWithError):
321         (WinLauncherWebHost::didCommitLoadForFrame):
322         (WinLauncherWebHost::didReceiveTitle):
323         (WinLauncherWebHost::didReceiveIcon):
324         (WinLauncherWebHost::didFinishLoadForFrame):
325         (WinLauncherWebHost::didFailLoadWithError):
326         (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
327         (WinLauncherWebHost::willPerformClientRedirectToURL):
328         (WinLauncherWebHost::didCancelClientRedirectForFrame):
329         (WinLauncherWebHost::willCloseFrame):
330         (WinLauncherWebHost::windowScriptObjectAvailable):
331         * WinLauncher/WinLauncher.ico: Added.
332         * WinLauncher/WinLauncher.rc: Added.
333         * WinLauncher/WinLauncher.vcproj: Added.
334         * WinLauncher/resource.h: Added.
335         * WinLauncher/small.ico: Added.
336         * WinLauncher/stdafx.cpp: Added.
337         * WinLauncher/stdafx.h: Added.
338
339 2008-02-19  Brady Eidson  <beidson@apple.com>
340
341         Reviewed by Geoff
342
343         Fixed a bug in DRT --threaded mode
344
345         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
346         (startJavaScriptThreads): Don't detach the newly created thread.  The later call to stopJavaScriptThreads() tries
347           to pthread_join() each thread that had been created, but you can't join a detached thread!
348
349 2008-02-18  Brady Eidson  <beidson@apple.com>
350
351         Changes by Geoff Garen, Reviewed by Darin
352
353         Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released
354
355         DRT changes for test: platform/mac/plugins/webScriptObject-exception-deadlock.html
356
357         [WebScriptObject valueForKey:] might throw an exception, and previously might have "leaked" the global JSLock
358         This test calls valueForKey, then runs some arbitrary Javascript on a 2ndary thread.  If the lock has leaked,
359         this series of method calls will deadlock.  If things are good, it will complete successfully.
360
361         * DumpRenderTree/mac/ObjCController.m:
362         (runJavaScriptThread):
363         (+[ObjCController isSelectorExcludedFromWebScript:]):
364         (+[ObjCController webScriptNameForSelector:]):
365         (-[ObjCController testValueForKey]):
366
367 2008-02-18  Matt Lilek  <webkit@mattlilek.com>
368
369         Reviewed by Adam.
370
371         Remove FindSafari's Release configuration.
372
373         * FindSafari/FindSafari.vcproj:
374
375 2008-02-15  Adam Roben  <aroben@apple.com>
376
377         Fix a typo that broke the Mac build
378
379         Reviewed by Mark.
380
381         * Scripts/build-webkit:
382
383 2008-02-14  Adam Roben  <aroben@apple.com>
384
385         Turn on cross-document messaging support by default
386
387         Reviewed by Darin.
388
389         * Scripts/build-webkit:
390
391 2008-02-14  Adam Roben  <aroben@apple.com>
392
393         Conditionalize cross-document messaging support
394
395         The cross-document messaging parts of HTML 5 are in flux and we want
396         ports to be able to turn off the support as needed.
397
398         Note that the support is turned off by default right now. A subsequent
399         commit will turn it on by default.
400
401         Reviewed by Darin.
402
403         * Scripts/build-webkit:
404
405 2008-02-14  Darin Adler  <darin@apple.com>
406
407        - fix Windows build
408
409         * DumpRenderTree/win/UIDelegate.cpp:
410         (UIDelegate::setStatusText): Update parameter types to match declaration.
411
412 2008-02-14  Oliver Hunt  <oliver@apple.com>
413
414         Reviewed by Geoff G and Weinig.
415
416         Add ability for DRT to report tests setting the status text.
417
418         * DumpRenderTree/LayoutTestController.cpp:
419         (LayoutTestController::LayoutTestController):
420         (dumpStatusCallbacksCallback):
421         (LayoutTestController::staticFunctions):
422         * DumpRenderTree/LayoutTestController.h:
423         * DumpRenderTree/mac/UIDelegate.mm:
424         (-[UIDelegate webView:setStatusText:]):
425         * DumpRenderTree/win/UIDelegate.cpp:
426         * DumpRenderTree/win/UIDelegate.h:
427
428 2008-02-13  Adam Roben  <aroben@apple.com>
429
430         Windows build fix
431
432         * DumpRenderTree/ForwardingHeaders/wtf/MathExtras.h: Added.
433
434 2008-02-13  Adam Roben  <aroben@apple.com>
435
436         Windows/GTK+ build fix
437
438         * DumpRenderTree/LayoutTestController.cpp: #include MathExtras.h to
439         get isnan.
440
441 2008-02-13  Brady Eidson  <beidson@apple.com>
442
443         Reviewed by Darin Adler
444
445         Add some much needed Database support to DRT
446
447         * DumpRenderTree/LayoutTestController.cpp:
448         (LayoutTestController::LayoutTestController):
449         (dumpDatabaseCallbacksCallback): Flag to control if the UIDelegate methods related to
450           databases are called
451         (clearAllDatabasesCallback): Allow a test to delete all databases
452         (setDatabaseQuotaCallback): Allow a test to set the quota new origins will get
453         (LayoutTestController::staticFunctions):
454
455         * DumpRenderTree/LayoutTestController.h:
456         (LayoutTestController::dumpDatabaseCallbacks):
457         (LayoutTestController::setDumpDatabaseCallbacks):
458
459         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
460         (LayoutTestController::clearAllDatabases):
461         (LayoutTestController::setDatabaseQuota):
462
463         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
464         (LayoutTestController::clearAllDatabases): Stubbed out
465         (LayoutTestController::setDatabaseQuota): Ditto
466         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
467         (LayoutTestController::clearAllDatabases): Stubbed out with error message
468         (LayoutTestController::setDatabaseQuota): Ditto
469
470         * DumpRenderTree/mac/UIDelegate.mm:
471         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Print a
472           message with details about the event then return a 5mb quota like before
473
474
475 2008-02-12  Steve Falkenburg  <sfalken@apple.com>
476
477         Changes to support merged MIDL output.
478
479         All COM interfaces are now generated to WebKit.h.
480
481         Reviewed by Sam, Ada.
482
483         * Drosera/win/BaseDelegate.h:
484         * Drosera/win/DebuggerClient.cpp:
485         * Drosera/win/DebuggerDocumentPlatform.cpp:
486         * Drosera/win/Drosera.cpp:
487         * Drosera/win/ServerConnection.cpp:
488         * Drosera/win/ServerConnection.h:
489         * DumpRenderTree/win/DumpRenderTree.cpp:
490         * DumpRenderTree/win/EditingDelegate.h:
491         * DumpRenderTree/win/EventSender.cpp:
492         * DumpRenderTree/win/FrameLoadDelegate.cpp:
493         * DumpRenderTree/win/FrameLoadDelegate.h:
494         * DumpRenderTree/win/GCControllerWin.cpp:
495         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
496         * DumpRenderTree/win/PolicyDelegate.h:
497         * DumpRenderTree/win/ResourceLoadDelegate.h:
498         * DumpRenderTree/win/UIDelegate.cpp:
499         * DumpRenderTree/win/UIDelegate.h:
500         * DumpRenderTree/win/WorkQueueItemWin.cpp:
501
502 2008-02-10  Dan Bernstein  <mitz@apple.com>
503
504         Reviewed by Oliver Hunt.
505
506         - fix a memory leak
507
508         * DumpRenderTree/cg/ImageDiffCG.cpp:
509         (getDifferenceBitmap): Use a static CFMutableData instead of allocating
510         and leaking the buffer each time.
511
512 2008-02-07  Adam Roben  <aroben@apple.com>
513
514         Fix error in bisect-builds when responding "broken" for the first
515         build
516
517         Reviewed by Dave Kilzer.
518
519         * Scripts/bisect-builds: Only try to test the build if the nightly
520         info for the current index has not been deleted.
521
522 2008-02-07  Geoffrey Garen  <ggaren@apple.com>
523
524         Reviewed by Alexey Proskuryakov.
525
526         Fixed two minor typos in the --root option, to get it working.
527
528         * Scripts/run-sunspider:
529             1. Actually assign the function argument to our local variable.
530             2. Actually set the $root variable, so we don't try to build later.
531
532 2008-02-05  Oliver Hunt  <oliver@apple.com>
533
534         RS=Eric.
535
536         Re-enable foreignObject by default as it is needed for a number of non-fO
537         related SVG tests and none of the old known crashes occur anymore.
538
539         * Scripts/build-webkit:
540
541 2008-02-05  Steve Falkenburg  <sfalken@apple.com>
542
543         Build fix.  Don't override intermediate directory.
544
545         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
546
547 2008-02-05  Holger Hans Peter Freyther  <zecke@selfish.org>
548
549         Build fix for Windows. willCloseFrame is a pure virtual and we are
550         forced to have an implementation.
551         
552         This partially reverts r30014.
553
554         * DumpRenderTree/win/FrameLoadDelegate.cpp:
555         (FrameLoadDelegate::willCloseFrame):
556         * DumpRenderTree/win/FrameLoadDelegate.h:
557
558 2008-02-05  Nikolas Zimmermann  <zimmermann@kde.org>
559
560         Reviewed by Holger.
561
562         Don't build wrapper for SVGTestCase.js (special file for svg/dynamic-updates)
563
564         * Scripts/make-js-test-wrappers:
565
566 2008-02-05  Holger Freyther  <zecke@selfish.org>
567
568         Reviewed by Darin.
569
570         In http://bugs.webkit.org/show_bug.cgi?id=16853 it was identified that the
571         the output of the willCloseFrame and didClearWindowObject FrameLoadDelegate
572         depends on the order the tests are executed.
573         
574         Propose to remove willCloseFrame and didlCearWindowObject output from the
575         FrameLoadDelegate and update the test results. The output of didClearWindowObject
576         is not interesting for any of the current tests and we have other ways to find
577         out if a frame was closed or not.
578
579         * DumpRenderTree/mac/FrameLoadDelegate.mm:
580         * DumpRenderTree/win/FrameLoadDelegate.cpp:
581         (FrameLoadDelegate::didClearWindowObject):
582         * DumpRenderTree/win/FrameLoadDelegate.h:
583
584 2008-02-04  Mark Rowe  <mrowe@apple.com>
585
586         Reviewed by Oliver Hunt.
587
588         Workaround for http://bugs.webkit.org/show_bug.cgi?id=16842
589         Bug 16842: Hang in DRT in leaks mode due to signal handler doing unsafe things
590
591         Don't install the signal handler unless we are running the pixel tests.
592         It is currently only used to restore the color profile, but by catching
593         signals we can trigger a deadlock in DRT while running leak tests.
594         The deadlock is tracked by http://bugs.webkit.org/show_bug.cgi?id=16842,
595         and a more complete fix will need to be developed to address this for
596         pixel tests as well.
597
598         * DumpRenderTree/mac/DumpRenderTree.mm:
599         (dumpRenderTree):
600
601 2008-02-04  Mark Rowe  <mrowe@apple.com>
602
603        Gtk qmake build fix.
604
605         * Scripts/webkitdirs.pm:  Fix perl's complaint about an odd number of elements in anonymous hash.
606
607 2008-02-04  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
608
609         Reviewed by Alp Toker and Mark Rowe.
610
611         http://bugs.webkit.org/show_bug.cgi?id=16618
612         [GTK] build-webkit and run-webkit-tests autootools support
613
614         * Scripts/build-webkit: added --database and --icon-database options
615         * Scripts/run-launcher:
616         * Scripts/run-webkit-tests:
617         * Scripts/webkitdirs.pm:
618
619 2008-02-04  Oliver Hunt  <oliver@apple.com>
620
621         Reviewed by Steve F.
622
623         Partial fix for <rdar://5621244> Drag & Drop doesn't work correctly in DRT
624
625         Implement required DRT functionality to allow majority of Drag and Drop testcases to work.
626         Issues include:
627           * Uses Sleep() to implement leapForward reliably.
628           * 3 DND tests still fail for reasons that i have not yet determined
629           * Has to explicitly ignore an extraneous WM_MOUSELEAVE that i am at a loss to explain 
630
631         * DumpRenderTree/win/EventSender.cpp:
632         (leapForwardCallback):
633         (mouseDownCallback):
634         (doMouseUp):
635         (mouseUpCallback):
636         (doMouseMove):
637         (mouseMoveToCallback):
638           Minor updates to these functions to handle the different message queue structure.
639
640         (replaySavedEvents):
641           More complicated now.  Where possible we just use the old while-loop model of execution,
642           but when leapForward has been used we have to jump through some hoops and set up an 
643           inner event loop so that we can ensure messages get the correct time stamp.
644
645         * DumpRenderTree/win/UIDelegate.cpp:
646         (UIDelegate::doDragDrop):
647           Call replaySavedEvents directly to force synchronous handling of drag and drop.
648
649 2008-02-04  Rodney Dawes  <dobey@wayofthemonkey.com>
650
651         Reviewed by Alp Toker and Mark Rowe.
652
653         Fix http://bugs.webkit.org/show_bug.cgi?id=17175.
654         Bug 17175: Use of C++ compiler flags in CFLAGS
655
656         * GNUmakefile.am: Use global_cxxflags as well as global_cflags in CXXFLAGS.
657
658 2008-02-04  Darin Adler  <darin@apple.com>
659
660         Reviewed by Geoff.
661
662         * Scripts/make-js-test-wrappers: Look at the whole LayoutTests tree, not just the fast
663         and svg subdirectories. Added some more exceptions for the benefit of the fast/dom
664         subdirectory.
665
666 2008-02-04  Adam Roben  <aroben@apple.com>
667
668         Windows Apple-only build fix
669
670         * DumpRenderTree/win/DumpRenderTree.vcproj: Added a new include
671         directory.
672
673 2008-02-04  Alp Toker  <alp@atoker.com>
674
675         Rubber-stamped by Mark Rowe.
676
677         Remove all trailing whitespace in the GTK+ port and related
678         components.
679
680         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
681         * DumpRenderTree/gtk/GCControllerGtk.cpp:
682         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
683         * GNUmakefile.am:
684
685 2008-02-01  Eric Seidel  <eric@webkit.org>
686
687         Reviewed by Oliver.
688
689         Also search LayoutTests/svg for js-based tests.
690
691         * Scripts/make-js-test-wrappers:
692
693 2008-01-31  Alp Toker  <alp@atoker.com>
694
695         Rubber-stamped by Adam Roben.
696
697         http://bugs.webkit.org/show_bug.cgi?id=17006
698         [GTK] Header path should be webkit/webkit.h
699
700         Move the GTK+ API sources as needed and update the build systems.
701
702         * DumpRenderTree/gtk/DumpRenderTree.cpp:
703         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
704         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
705         * GNUmakefile.am:
706         * GtkLauncher/main.c:
707
708 2008-01-30  Stephanie  <slewis@apple.com>
709
710         Reviewed by Geoff.
711
712         Add an option to run-webkit-tests to merge leaks results and print the number of unique leaks found under a certain call depth.  This should make it easier for the buildbots to track new leaks.
713
714         * Scripts/run-webkit-tests:
715
716 2008-01-30  Alexey Proskuryakov  <ap@webkit.org>
717
718         Reviewed by Adam Roben.
719
720         One more debug (external) fix.
721
722         * DumpRenderTree/win/DumpRenderTree.cpp: TestNetscapePlugin is built with a _debug suffix in both DebugInternal
723         and Debug configurations. 
724
725 2008-01-29  Geoffrey Garen  <ggaren@apple.com>
726
727         Reviewed by Sam Weinig. Sam Weinig.
728         
729         Fixed <rdar://problem/5692566> fast/encoding/mailto-always-utf-8.html
730         fails when run after fast/dom/Window/window-property-shadowing.html (16902)
731
732         Modified our policy delegates not to output window.name. Since a
733         previous test may have explicitly set window.name, we can't rely on its
734         implicit value in test results.
735
736         * DumpRenderTree/mac/PolicyDelegate.mm:
737         (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
738
739         * DumpRenderTree/win/PolicyDelegate.cpp:
740         (PolicyDelegate::decidePolicyForNavigationAction):
741
742 2008-01-29  Mark Rowe  <mrowe@apple.com>
743
744         Reviewed by Tim Hatcher.
745
746         <rdar://problem/5600926> WebCore on Tiger must link to its own copy of SQLite 3.4 or newer (so HTML database behavior will be correct).
747
748         * Scripts/build-webkit: Copy SQLite static library and headers into the build directory.
749
750 2008-01-29  David Kilzer  <ddkilzer@apple.com>
751
752         Refactor ChangeLog path code
753
754         Reviewed by Adam.
755
756         * Scripts/prepare-ChangeLog: Simplify code in one foreach() loop, and extract
757         duplicate code in another foreach() loop.
758
759 2008-01-29  Alexey Proskuryakov  <ap@webkit.org>
760
761         Reviewed by Darin.
762
763         <rdar://problem/5710692> All storage tests fail/crash
764
765         * DumpRenderTree/mac/UIDelegate.mm:
766         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Set an
767         arbitrary quota of 5 megabytes.
768
769         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
770         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
771         Removed unused (I think) code.
772         
773         * DumpRenderTree/win/UIDelegate.cpp:
774         (UIDelegate::QueryInterface): IWebUIDelegatePrivate3 is now supported.
775         (UIDelegate::webViewPainted): A stub implementation.
776         (UIDelegate::exceededDatabaseQuota): Set an arbitrary quota of 5 megabytes.
777         * DumpRenderTree/win/UIDelegate.h:
778
779 2008-01-27  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
780
781         GTK+ DRT build fix for breakage introduced in r29822.
782
783         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
784         (LayoutTestController::setPersistentUserStyleSheetLocation):
785         (LayoutTestController::clearPersistentUserStyleSheet):
786
787 2008-01-27  Dan Bernstein  <mitz@apple.com>
788
789         Reviewed by Darin Adler.
790
791         - add support for directory prologues and epilogues to run-webkit-tests
792         - allow setting a persistent user style sheet in DumpRenderTree
793         - activate the WebKit Layout Tests font in Windows DumpRenderTree
794
795         * DumpRenderTree/LayoutTestController.cpp:
796         (clearPersistentUserStyleSheetCallback): Added.
797         (setPersistentUserStyleSheetLocationCallback): Added.
798         (LayoutTestController::staticFunctions): Added.
799         clearPersistentUserStyleSheet and setPersistentUserStyleSheet.
800         * DumpRenderTree/LayoutTestController.h:
801         * DumpRenderTree/mac/DumpRenderTree.mm:
802         (setPersistentUserStyleSheetLocation): Added.
803         (resetWebViewToConsistentStateBeforeTesting): Added the user style sheet
804         to the set of things this function resets. Now it either disables the
805         user style sheet or sets it to the persistent user style sheet and
806         enables it.
807         * DumpRenderTree/mac/DumpRenderTreeMac.h:
808         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
809         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
810         (LayoutTestController::clearPersistentUserStyleSheet): Added.
811         * DumpRenderTree/win/DumpRenderTree.cpp:
812         (setPersistentUserStyleSheetLocation): Added.
813         (initialize): Added the WebKit Layout Tests font to the set of fonts to
814         install.
815         (resetWebViewToConsistentStateBeforeTesting): See DumpRenderTree.mm.
816         * DumpRenderTree/win/DumpRenderTreeWin.h:
817         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
818         (LayoutTestController::setPersistentUserStyleSheetLocation): Added.
819         (LayoutTestController::clearPersistentUserStyleSheet): Added.
820         * Scripts/run-webkit-tests: Changed to look for, and if found process in
821         DumpRenderTree, files named run-webkit-tests-prologue.html and
822         run-webkit-tests-epilogue.html in the resources subdirectory of any
823         test directory and platform test results directory. The prologues are
824         processed before the first test from the directory (and its
825         subdirectories) is run, and the epilogues are processed after the last
826         test from the directory is run. Platform-specific prologues and
827         epilogues are processed in order of specificity.
828
829 2008-01-25  Alexey Proskuryakov  <ap@webkit.org>
830
831         Reviewed by Mark Rowe.
832
833         <rdar://problem/5699933> http/tests/security/cross-frame-access-get.html is still failing
834
835         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Clear HTTP cache to ensure consistent test environment
836         (matching Mac DRT).
837         * DumpRenderTree/win/DumpRenderTree.vcproj: Link to CFNetwork.
838
839 2008-01-24  Sam Weinig  <sam@webkit.org>
840
841         Reviewed by Ada Chan.
842
843         Fix for <rdar://5131975> DumpRenderTree doesn't support undo/redo
844
845         - Adds simplified UndoManager to windows DRT to allow testing the
846           undo/redo code paths in WebCore and WebKit.  This is a temporary
847           solution to an issue that should eventually be solved by having a
848           shared UndoManager in WebKit.
849
850         * DumpRenderTree/win/DumpRenderTree.cpp:
851         (runTest):
852         * DumpRenderTree/win/UIDelegate.cpp:
853         (DRTUndoObject::DRTUndoObject):
854         (DRTUndoObject::invoke):
855         (DRTUndoStack::~DRTUndoStack):
856         (DRTUndoStack::isEmpty):
857         (DRTUndoStack::clear):
858         (DRTUndoStack::push):
859         (DRTUndoStack::pop):
860         (DRTUndoManager::canRedo):
861         (DRTUndoManager::canUndo):
862         (DRTUndoManager::DRTUndoManager):
863         (DRTUndoManager::removeAllActions):
864         (DRTUndoManager::registerUndoWithTarget):
865         (DRTUndoManager::redo):
866         (DRTUndoManager::undo):
867         (UIDelegate::UIDelegate):
868         (UIDelegate::resetUndoManager):
869         (UIDelegate::registerUndoWithTarget):
870         (UIDelegate::removeAllActionsWithTarget):
871         (UIDelegate::setActionTitle):
872         (UIDelegate::undo):
873         (UIDelegate::redo):
874         (UIDelegate::canUndo):
875         (UIDelegate::canRedo):
876         * DumpRenderTree/win/UIDelegate.h:
877
878 2008-01-23  Adam Roben  <aroben@apple.com>
879
880         Allow directories containing ChangeLogs to be passed to
881         resolve-ChangeLogs
882
883         Reviewed by David Kilzer.
884
885         * Scripts/resolve-ChangeLogs:
886         (sub findChangeLog): Return a ChangeLog contained within the specified
887         directory if one exists.
888
889 2008-01-23  Steve Falkenburg  <sfalken@apple.com>
890
891         <rdar://problem/5698732> Copyright strings should include 2008
892
893         Reviewed by Sam.
894
895         * Drosera/win/Drosera.vcproj/Drosera.rc:
896         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc:
897
898 2008-01-23  Alp Toker  <alp@atoker.com>
899
900         Rubber-stamped by Mark Rowe.
901
902         Remove whitespace after -I in automake include lists.
903
904         * GNUmakefile.am:
905
906 2008-01-23  Michael Goddard <michael.goddard@trolltech.com>
907
908         Reviewed by Lars Knoll <lars@trolltech.com>.
909
910         Reworked the JavaScriptCore Qt bindings:
911         
912         * Update JS DRT controller for Qt JS binding changes.
913         There were two functions that needed some changes
914         so that the layout tests would work, so this makes
915         a few tests pass again.
916         
917         * Bump the timeout for layout tests up to 11s.
918         At least some tests have an internal timeout of
919         10 seconds, so make the waitUntilDone approach
920         wait at least 11s.  fast/dom/open-and-close-by-DOM.html
921         is one of these - now the failure message is more
922         accurate.
923         
924
925         * DumpRenderTree/qt/jsobjects.cpp:
926         (LayoutTestController::waitUntilDone):
927         * DumpRenderTree/qt/jsobjects.h:
928
929 2008-01-22  Anders Carlsson  <andersca@apple.com>
930
931         Reviewed by Darin and Adam.
932
933         <rdar://problem/5688975>
934         div element on microsoft site has wrong left offset.
935         
936         Add new method for testing the return vale of NPN_GetProperty.
937         
938         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
939         (pluginInvoke):
940
941 2008-01-22  Alexey Proskuryakov  <ap@webkit.org>
942
943         Reviewed by Adam Roben.
944
945         <rdar://problem/5670257> editing/selection/4895428-3.html makes editing/selection/5131716-2.html fail
946
947         * DumpRenderTree/win/EventSender.cpp: (makeEventSender): Reset static variables for a new test.
948
949 2008-01-21  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
950
951         Reviewed by Alp Toker.
952
953         http://bugs.webkit.org/show_bug.cgi?id=16955
954         Get errors when cross-compile webkit-gtk
955
956         * GNUmakefile.am: Removed ICU_CFLAGS 
957
958 2008-01-21  Darin Adler  <darin@apple.com>
959
960         Reviewed by Mitz and Adam.
961
962         * Scripts/svn-create-patch: Sort ChangeLog files first. Also slightly improved the
963         sorting speed by doing all sort criteria in a single pass instead of three sorts.
964
965 2008-01-21  Simon Hausmann  <hausmann@webkit.org>
966
967         Reviewed by Holger.
968
969         Fix focus chain handling and cycling through focusable objects (links) using tab/backtab.
970         
971         * Fix GraphicsContext::drawFocusRing to also draw single focus rects.
972         * Implemented QWebPage::focusNextPrevChild by sending fake tab/shift-tab events
973         and make the return value depend on whether we successfully determined a focusable
974         node or not.
975         * Changed QWebView::focusNextPrevChild() to call the base QWidget implementation correctly
976         if we could not handle the focus chain ourselves.
977         * Changed the focus policy of QWebView to correctly use WheelFocus instead of ClickFocus.
978         * Made ChromeClientQt::canTakeFocus() and takeFocus() dummy method since they are only
979         used to control the situation of stepping out of the focus chain inside the page.
980         * Made inclusion of links in the focus chain configurable through QWebSettings::LinksIncludedInFocusChain.
981         The layout tests expect this to be disabled but for the user it seems sensible to have it
982         on by default, hence the default in qwebsettings.cpp
983         
984
985         * DumpRenderTree/qt/DumpRenderTree.cpp:
986         (WebCore::WebPage::WebPage):
987
988 2008-01-19  Mark Rowe  <mrowe@apple.com>
989
990         Reviewed by Alp Toker.
991
992         Allow the --http flag to run-webkit-tests to override
993         the default behaviour of disabling HTTP tests for Qt,
994         Gtk and Wx.
995
996         * Scripts/run-webkit-tests:
997
998 2008-01-19  David Kilzer  <ddkilzer@apple.com>
999
1000         <rdar://problem/5695344> check-for-global-initializers script never checks any object files
1001
1002         Reviewed by Darin.
1003
1004         We now touch a check-for-global-initializers.timestamp file in
1005         the TARGET_TEMP_DIR directory to determine when new object files
1006         have been compiled and thus need to be checked.  If the timestamp
1007         file doesn't exist, all object files will be checked.
1008
1009         Previously the modification time of the "executable" (the
1010         framework binary, e.g., WebKit.framework/WebKit) was used, but
1011         since this was the last file modified at the end of the compile
1012         phase, no object files would ever get checked!
1013
1014         Also added JSCustomSQLTransactionCallback.o to the list of files
1015         since it has static initializers in Debug builds of WebCore.
1016
1017         * Scripts/check-for-global-initializers:
1018
1019 2008-01-18  Adam Roben  <aroben@apple.com>
1020
1021         Build fix
1022
1023         * Scripts/build-webkit:
1024
1025 2008-01-18  Beth Dakin  <bdakin@apple.com>
1026
1027         Reviewed by Oliver.
1028
1029         Update build-webkit to account for foreign-object being disabled by 
1030         default.
1031
1032         * Scripts/build-webkit:
1033
1034 2008-01-18  Adam Roben  <aroben@apple.com>
1035
1036         Updated for method renames
1037
1038         Reviewed by Adele.
1039
1040         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1041         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
1042         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1043         (LayoutTestController::setMainFrameIsFirstResponder):
1044         (LayoutTestController::setWindowIsKey):
1045         * DumpRenderTree/mac/UIDelegate.mm:
1046         (-[UIDelegate webViewFocus:]):
1047         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1048         (FrameLoadDelegate::didCommitLoadForFrame):
1049
1050 2008-01-18  Alexey Proskuryakov  <ap@webkit.org>
1051
1052         Reviewed by Adam Roben.
1053
1054         Fix plugin-related tests in Debug_Internal configuration, which are failing because of CRT version mismatch
1055         between DRT and TestNetscapePlugin.
1056
1057         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Added a Debug_Internal configuration.
1058         * DumpRenderTree/DumpRenderTree.sln: Use this configuration.
1059
1060 2008-01-18  Simon Hausmann  <hausmann@webkit.org>
1061
1062         Reviewed by Holger.
1063
1064         Fix fast/dom/Window/window-resize.html
1065         
1066         In DRT connect the page's geometryChangeRequest signal to a slot that
1067         sets the geometry of the view widget.
1068         
1069
1070         * DumpRenderTree/qt/DumpRenderTree.cpp:
1071         (WebCore::WebPage::setViewGeometry):
1072         (WebCore::WebPage::WebPage):
1073
1074 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
1075
1076         Build fix.
1077
1078         * Drosera/DroseraWin.make:
1079
1080 2008-01-17  Darin Adler  <darin@apple.com>
1081
1082         * Scripts/run-webkit-tests: Fixed a bug number.
1083
1084 2008-01-17  Alexey Proskuryakov  <ap@webkit.org>
1085
1086         Reviewed by Adam Roben.
1087
1088         http://bugs.webkit.org/show_bug.cgi?id=16908
1089         run-webkit-tests complains about missing FindSafari.exe
1090
1091         * Scripts/webkitdirs.pm: Append _debug as appropriate.
1092
1093 2008-01-17  Steve Falkenburg  <sfalken@apple.com>
1094
1095         Re-add DEBUG_WEBKIT_HAS_SUFFIX.
1096         
1097         Rubber-stamped by Jon Honeycutt.
1098
1099         * DumpRenderTree/win/DumpRenderTree.vcproj:
1100
1101 2008-01-16  Alp Toker  <alp@atoker.com>
1102
1103         Reviewed by Mark Rowe.
1104
1105         http://bugs.webkit.org/show_bug.cgi?id=16218
1106         [GTK] API: Should this entry point be called go_back rather than go_backward?
1107
1108         Track back/forward API changes in the tools.
1109
1110         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1111         (BackForwardItem::invoke):
1112         * GtkLauncher/main.c:
1113         (go_back_cb):
1114
1115 2008-01-16  Adam Roben  <aroben@apple.com>
1116
1117         Windows build fix after r29488
1118
1119         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1120         Build into a subdirectory of $WebKitOutputDir\bin to match where DRT
1121         expects to find the plugin.
1122
1123 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
1124
1125         Reviewed by Sam Weinig.
1126         
1127         Fixed the waitUntilDone watchdog timer -- the old code never added the
1128         timer to the run loop, so it didn't do anything.
1129
1130         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1131         (LayoutTestController::setWaitToDump):
1132         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1133         (LayoutTestController::setWaitToDump):
1134
1135 2008-01-14  Steve Falkenburg  <sfalken@apple.com>
1136
1137         Use shared vsprops for most vcproj properties.
1138         
1139         Reviewed by Darin.
1140
1141         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1142         * DumpRenderTree/win/DumpRenderTree.vcproj:
1143         * DumpRenderTree/win/ImageDiff.vcproj:
1144         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1145         * FindSafari/FindSafari.vcproj:
1146
1147 2008-01-14  Stephanie  <slewis@apple.com>
1148
1149        Reviewed by NOBODY.
1150   
1151        revert accidental character.
1152
1153        * Scripts/run-webkit-tests:
1154
1155 2008-01-14  Stephanie  <slewis@apple.com>
1156
1157         RS=Oliver
1158
1159         add Quicktime PPC only leaks to Leopard exclude list. See <rdar://problem/5667132>
1160
1161         * Scripts/run-webkit-tests:
1162
1163 2008-01-14  Darin Adler  <darin@apple.com>
1164
1165         * Scripts/do-webcore-rename: Queue up another rename.
1166
1167 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1168
1169         Reviewed by Darin.
1170
1171         * Allow to run the tests in reverse order to spot test cases where the result depends on the order
1172         the tests were ran.
1173         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
1174
1175         * Scripts/run-webkit-tests:
1176
1177 2008-01-14  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1178
1179         Reviewed by Darin.
1180
1181         * Randomize tests array to spot test cases where the results depends on the order
1182         the tests are ran.
1183         * This is from http://bugs.webkit.org/show_bug.cgi?id=16869
1184
1185         * Scripts/run-webkit-tests:
1186
1187 2008-01-14  Darin Adler  <darin@apple.com>
1188
1189         * Scripts/run-webkit-tests: More ignore list tweaking.
1190
1191 2008-01-14  Darin Adler  <darin@apple.com>
1192
1193         * Scripts/run-webkit-tests: Add another leak to the ignore list.
1194
1195 2008-01-14  Dan Bernstein  <mitz@apple.com>
1196
1197         Reviewed by Adam Roben.
1198
1199         - try to fix failure in fast/dom/Window/window-onFocus.html seen on the
1200           build bots
1201
1202         * DumpRenderTree/win/DumpRenderTree.cpp:
1203         (resetWebViewToConsistentStateBeforeTesting): Focus the web view.
1204
1205 2008-01-13  Steve Falkenburg  <sfalken@apple.com>
1206
1207         Share common files across projects.
1208         
1209         Unify vsprops files
1210         Debug:          common.vsprops, debug.vsprops
1211         Debug_Internal: common.vsprops, debug.vsprops, debug_internal.vsprops
1212         Release:        common.vsprops, release.vsprops
1213         
1214         Shared properties can go into common.vsprops, shared debug settings can go into debug.vsprops.
1215         debug_internal.vsprops will be mostly empty except for file path prefix modifiers.
1216
1217         Pull auto-version.sh, VERSION, and PRODUCTVERSION from tools.
1218
1219         Reviewed by Adam Roben.
1220
1221         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
1222         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Removed.
1223         * Drosera/win/Drosera.vcproj/VERSION: Removed.
1224         * Drosera/win/Drosera.vcproj/auto-version.sh: Removed.
1225         * Drosera/win/Drosera.vcproj/debug.vsprops: Removed.
1226         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Removed.
1227         * Drosera/win/Drosera.vcproj/release.vsprops: Removed.
1228         * DumpRenderTree/win/DumpRenderTree.vcproj:
1229         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1230         * DumpRenderTree/win/debug.vsprops: Removed.
1231         * DumpRenderTree/win/debug_internal.vsprops: Removed.
1232         * DumpRenderTree/win/release.vsprops: Removed.
1233
1234 2008-01-13  Brent Fulgham  <bfulgham@gmail.com>
1235
1236         Reviewed by Maciej.
1237
1238         - http://bugs.webkit.org/show_bug.cgi?id=16314
1239           Script to launch Drosera
1240
1241         * Scripts/gdb-drosera: Added.
1242         * Scripts/run-drosera: Added.
1243         * Scripts/run-drosera-nightly.cmd: Added.
1244         * Scripts/webkitdirs.pm: Added runDrosera function.
1245
1246 2008-01-13  Dan Bernstein  <mitz@apple.com>
1247
1248         - fix breakage due to last-minute change
1249
1250         * DumpRenderTree/win/DumpRenderTree.cpp:
1251         (runTest): Declare the loop variable.
1252
1253 2008-01-13  Dan Bernstein  <mitz@apple.com>
1254
1255         Reviewed by Adam Roben.
1256
1257         - fix <rdar://problem/5132009> Windows DRT does not support multiple windows
1258
1259         * DumpRenderTree/win/DumpRenderTree.cpp:
1260         (DumpRenderTreeWndProc):
1261         (initialize):
1262         (dumpBackForwardList):
1263         (dumpBackForwardListForAllWindows):
1264         (dump):
1265         (resetWebViewToConsistentStateBeforeTesting): Factored out of
1266         runTest().
1267         (runTest):
1268         (allWindows): Added. Returns a vector of all open windows.
1269         (windowToWebViewMap): Added. Returns a map from open windows to their
1270         WebViews.
1271         (createWebViewAndOffscreenWindow): Factored out of main() to be
1272         reusable for creating extra windows.
1273         (main):
1274         * DumpRenderTree/win/DumpRenderTreeWin.h:
1275         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1276         (LayoutTestController::windowCount): Implemented.
1277         * DumpRenderTree/win/UIDelegate.cpp:
1278         (UIDelegate::createWebViewWithRequest): Implemented.
1279         (UIDelegate::webViewClose): Implemented.
1280         * DumpRenderTree/win/UIDelegate.h:
1281
1282 2008-01-12  Alp Toker  <alp@atoker.com>
1283
1284         Reviewed by Mark Rowe.
1285
1286         Hide non-public symbols in GTK+/autotools release builds.
1287
1288         * GNUmakefile.am:
1289
1290 2008-01-12  Holger Hans Peter Freyther  <holger.freyther@trolltech.com>
1291
1292         Reviewed by Ap.
1293
1294         * Make launching of the WebKit httpd work on GNU/Debian/Linux
1295         
1296         The configuration of Apache2 and installation does not depend on
1297         the kernel but on the distribution policy. Make launching of httpd
1298         work for Debian derived distributions.
1299
1300         * Scripts/run-webkit-httpd:
1301         * Scripts/run-webkit-tests:
1302         * Scripts/webkitdirs.pm:
1303
1304 2008-01-12  Mark Rowe  <mrowe@apple.com>
1305
1306         Reviewed by Maciej Stachowiak.
1307
1308         Fix crash in http/tests/security/local-JavaScript-from-remote.html under guard malloc.
1309
1310         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Retain string before returning it to
1311         match the callers expectations that it can take ownership of the string.
1312
1313 2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
1314
1315         Reviewed by Adam Roben.
1316
1317         <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
1318
1319         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
1320         as these are only posted because the test window is not a normal visible one, and
1321         they confuse drag&drop machinery.
1322
1323 2008-01-11  Adam Roben  <aroben@apple.com>
1324
1325         Fix a crash when pathToLocalResource fails and a leak
1326
1327         Reviewed by Darin.
1328
1329         * DumpRenderTree/LayoutTestController.cpp:
1330         (pathToLocalResourceCallback): Dont leak the JSStringRef, and make
1331         sure not to pass null to JSValueMakeString.
1332         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1333         (LayoutTestController::pathToLocalResource): Print an error message if
1334         the conversion fails so it's clear what happened.
1335
1336 2008-01-11  Geoffrey Garen  <ggaren@apple.com>
1337
1338         Reviewed by John Sullivan.
1339
1340         * DumpRenderTree/mac/GCControllerMac.mm:
1341         (GCController::collectOnAlternateThread): Updated for name change.
1342
1343 2008-01-10  Kevin Ollivier  <kevino@theolliviers.com>
1344
1345         wx build fix. Don't build dftables any longer since it's now a Perl
1346         script.
1347
1348         * wx/build-wxwebkit:
1349
1350 2008-01-10  Sam Weinig  <sam@webkit.org>
1351
1352         Reviewed by Anders Carlsson.
1353
1354         Make DRT track open windows instead of allocated windows so that
1355         we can avoid ASSERTION due to late deallocs out of our control.
1356
1357         * DumpRenderTree/mac/DumpRenderTree.mm:
1358         (dumpBackForwardListForAllWindows):
1359         (runTest):
1360         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1361         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1362         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1363         (+[DumpRenderTreeWindow openWindows]):
1364         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1365         (-[DumpRenderTreeWindow close]):
1366         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1367         (LayoutTestController::windowCount):
1368
1369 2008-01-10  Ada Chan  <adachan@apple.com>
1370
1371         Meta key is not the same as Alt key on windows.
1372
1373         Reviewed by Darin.
1374
1375         * DumpRenderTree/win/EventSender.cpp:
1376         (keyDownCallback):
1377
1378 2008-01-09  Kevin McCullough  <kmccullough@apple.com>
1379
1380         Reviewed by Darin, Sam and Adam.
1381
1382         -<rdar://problem/5654486> REGRESSION (Safari 3.0.4-TOT): clicking on
1383         link in gmail message displays JavaScript alert falsely complaining
1384         about pop-up blocking.
1385         - Added the ability to enable the pop-up blocker via the
1386         LayoutTestController.
1387
1388         * DumpRenderTree/LayoutTestController.cpp:
1389         (setPopupBlockingEnabledCallback):
1390         (LayoutTestController::staticFunctions):
1391         * DumpRenderTree/LayoutTestController.h:
1392         * DumpRenderTree/mac/DumpRenderTree.mm:
1393         (setDefaultsToConsistentValuesForTesting):
1394         (resetWebViewToConsistentStateBeforeTesting):
1395         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1396         (LayoutTestController::setPopupBlockingEnabled):
1397
1398 2008-01-10  Lars Knoll  <lars@trolltech.com>
1399
1400         Reviewed by Simon.
1401
1402         rename QWebPageHistory to QWebHistory.
1403         
1404
1405         * DumpRenderTree/qt/jsobjects.cpp:
1406
1407 2008-01-09  Maciej Stachowiak  <mjs@apple.com>
1408
1409         Reviewed by Darin.
1410         
1411         - add some more renames, adjust some
1412
1413         * Scripts/do-webcore-rename:
1414
1415 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
1416
1417         Reviewed by Oliver.
1418
1419         Enable SVG Fonts support by default.
1420
1421         * Scripts/build-webkit:
1422
1423 2008-01-07  Nikolas Zimmermann  <zimmermann@kde.org>
1424
1425         Reviewed by Adam.
1426
1427         Fixes: http://bugs.webkit.org/show_bug.cgi?id=16244
1428         DRT doesn't handle platform specific pixel test results correctly.
1429
1430         <test>-expected.txt files and <test>-expected.png files may now live
1431         in different directories (ie. a cross-platform <test>-expected.txt file
1432         and a platform-specific <test>-expected.png file).
1433
1434         * Scripts/run-webkit-tests:
1435
1436 2008-01-04  Kevin McCullough  <kmccullough@apple.com>
1437
1438         Reviewed by Darin.
1439
1440         - <rdar://problem/5666914> fast/regex/test{1,4}.html are failing
1441         DRT did not correctly handle printing the '\0' char.  Now it does.
1442
1443         * DumpRenderTree/win/DumpRenderTree.cpp:
1444         (dumpFramesAsText):
1445         (dump):
1446
1447 2008-01-07  Simon Hausmann  <hausmann@webkit.org>
1448
1449         Reviewed by Lars.
1450
1451         Ported of the network backend of the Qt platform to Qt 4.4's new networking API.
1452         
1453
1454         * DumpRenderTree/qt/main.cpp:
1455         * DumpRenderTree/qt/testplugin.cpp:
1456         * DumpRenderTree/qt/testplugin.h:
1457
1458 2008-01-05  Mark Rowe  <mrowe@apple.com>
1459
1460         Reviewed by Alp Toker.
1461
1462         Fix hang in fast/frames/frame-display-none-focus.html during Gtk layout tests.
1463
1464         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1465         (processWork): Process pending work.
1466         (webViewLoadFinished): Schedule processing of pending work.
1467         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Use webkit_web_frame_reload.
1468
1469 2008-01-05  Darin Adler  <darin@apple.com>
1470
1471         * Scripts/do-webcore-rename: Some more renaming plans.
1472
1473 2008-01-04  Alice Liu  <alice.liu@apple.com>
1474
1475         Reviewed by Alexey and Darin.
1476
1477         Adding "home" and "end" to DRT's keydown since
1478         DOM key events can't handle keyIdentifiers at this point. 
1479
1480         * DumpRenderTree/mac/EventSendingController.mm:
1481         (-[EventSendingController keyDown:withModifiers:]):
1482         * DumpRenderTree/win/EventSender.cpp:
1483         (keyDownCallback):
1484
1485 2008-01-04  Lars Knoll  <lars@trolltech.com>
1486
1487         Reviewed by Simon.
1488
1489         fix DRT after the changes to QWebPage.
1490         
1491         The great thing is that we actually don't have
1492         any regressions from the QWebPage change :)
1493         
1494
1495         * DumpRenderTree/qt/DumpRenderTree.cpp:
1496         (WebCore::DumpRenderTree::DumpRenderTree):
1497
1498 2008-01-04  Lars Knoll  <lars@trolltech.com>
1499
1500         Reviewed by Simon.
1501
1502         make QWebPage a QObject and get things to compile.
1503         
1504         Nothing works currently though.
1505         
1506
1507         * DumpRenderTree/qt/DumpRenderTree.cpp:
1508         (WebCore::DumpRenderTree::DumpRenderTree):
1509
1510 2008-01-04  Lars Knoll  <lars@trolltech.com>
1511
1512         Reviewed by Simon.
1513
1514         take a QString as identifier in QWebFrame::addToJSWindowObject.
1515
1516         * DumpRenderTree/qt/DumpRenderTree.cpp:
1517         (WebCore::DumpRenderTree::initJSObjects):
1518
1519 2008-01-04  Alp Toker  <alp@atoker.com>
1520
1521         GTK+ DRT build fix for breakage introduced in r29149.
1522
1523         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1524         (LayoutTestController::execCommand):
1525
1526 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
1527
1528         Reviewed by Darin.
1529
1530         <rdar://problem/5463489> A number of layout tests should be using execCommand instead of textInputController
1531
1532         Added layoutTestController.execCommand to access editor commands that are not available
1533         via document.execCommand.
1534
1535         * DumpRenderTree/LayoutTestController.cpp:
1536         (execCommandCallback):
1537         (LayoutTestController::staticFunctions):
1538         * DumpRenderTree/LayoutTestController.h:
1539         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1540         (LayoutTestController::execCommand):
1541         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1542         (LayoutTestController::queueLoad):
1543         (LayoutTestController::execCommand):
1544
1545 2008-01-03  Alice Liu  <alice.liu@apple.com>
1546
1547         Reviewed by Darin, Mitz.
1548
1549         fixed <rdar://5130762> mousedowns in different locations increase the clickcount incorrectly
1550
1551         the clickcount should not increase if the last click was at a different location.  it's a new click.
1552
1553         * DumpRenderTree/mac/DumpRenderTree.mm:
1554         (runTest):
1555         * DumpRenderTree/mac/EventSendingController.h:
1556         * DumpRenderTree/mac/EventSendingController.mm:
1557         (-[EventSendingController mouseDown]):
1558         (-[EventSendingController mouseUp]):
1559
1560 2008-01-03  Darin Adler  <darin@apple.com>
1561
1562         Reviewed by Adam.
1563
1564         * Scripts/update-webkit: Make this work a little better for the people at Apple
1565         who have a directory named Internal.
1566
1567 2008-01-03  Adam Roben  <aroben@apple.com>
1568
1569         Use HTTP::Date instead of Date::Parse because it's installed by Cygwin by default
1570
1571         Rubberstamped by Mark.
1572
1573         * Scripts/update-webkit-auxiliary-libs:
1574
1575 2008-01-03  Adam Roben  <aroben@apple.com>
1576
1577         Fix Bug 15663: update-webkit re-downloads WebKitAuxiliaryLibrary unnecessarily
1578
1579         http://bugs.webkit.org/show_bug.cgi?id=15663
1580
1581         Added a fuzz factor into the Last-Modified comparison for downloading
1582         WebKitAuxiliaryLibrary.zip.
1583
1584         The zip file is served from a set of mirrors who give Last-Modified
1585         times that are off by 1-3 seconds from each other. This was causing
1586         the build bots to redownload WebKitAuxiliaryLibrary for every build,
1587         which would then cause all of WebCore to rebuild each time.
1588
1589         Reviewed by Mark.
1590
1591         * Scripts/update-webkit-auxiliary-libs: Check if the new zip file is
1592         at least 30 seconds newer than the old one -- otherwise we assume that
1593         the difference in time is due to the mirrors being slightly offset
1594         from each other.
1595         (sub lastModifiedToUnixTime): Added.
1596
1597 2008-01-03  Alexey Proskuryakov  <ap@webkit.org>
1598
1599         Windows build fix.
1600
1601         * DumpRenderTree/ForwardingHeaders/wtf/HashTraits.h: Added (needed by COMPtr.h).
1602
1603 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
1604
1605         Reviewed by Lars.
1606
1607         Moved QWebPage::open to QWebFrame::load and added setHtml.
1608         
1609
1610         * DumpRenderTree/qt/DumpRenderTree.cpp:
1611         (WebCore::DumpRenderTree::open):
1612
1613 2008-01-03  Simon Hausmann  <hausmann@webkit.org>
1614
1615         Reviewed by Lars.
1616
1617         Added the first revision of QWebView and started moving functionality from QWebPave over to QWebView and QWebFrame.
1618         
1619
1620         * DumpRenderTree/qt/DumpRenderTree.cpp:
1621         (WebCore::DumpRenderTree::DumpRenderTree):
1622
1623 2008-01-02  Sam Weinig  <sam@webkit.org>
1624
1625         * Scripts/do-webcore-rename: Yet more renaming ideas.
1626
1627 2008-01-02  Darin Adler  <darin@apple.com>
1628
1629         * Scripts/do-webcore-rename: More renaming ideas. (Maciej, please merge yours with mine.)
1630
1631 2008-01-02  Alice Liu  <alice.liu@apple.com>
1632
1633         Reviewed by Sam Weinig.
1634
1635         fixing assertion hit with editing/selection/move-begin-end.html
1636
1637         * DumpRenderTree/ForwardingHeaders/wtf/ASCIICType.h: Added.
1638         * DumpRenderTree/win/DumpRenderTree.vcproj:
1639         * DumpRenderTree/win/EventSender.cpp:
1640         (keyDownCallback):
1641         using isupper will cause an assertion for inputs outside of ascii range. use isASCIIUpper instead.
1642
1643 2008-01-02  Darin Adler  <darin@apple.com>
1644
1645         * Scripts/do-webcore-rename: Some more name change plans.
1646
1647 2008-01-02  Alice Liu  <alice.liu@apple.com>
1648
1649         Reviewed by Maciej.
1650
1651         Added handling for page up and page down in EventSender
1652
1653         * DumpRenderTree/mac/EventSendingController.mm:
1654         (-[EventSendingController keyDown:withModifiers:]):
1655         * DumpRenderTree/win/EventSender.cpp:
1656         (keyDownCallback):
1657
1658 2008-01-02  Alexey Proskuryakov  <ap@webkit.org>
1659
1660         Reviewed by Darin.
1661
1662         Fix fast/events/arrow-keys-on-body.html for real.
1663
1664         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Pass proper keyData for WM_KEYUP, too.
1665
1666 2008-01-02  Luca Bruno  <lethalman88@gmail.com>
1667
1668         Reviewed by Darin.
1669
1670         http://bugs.webkit.org/show_bug.cgi?id=16674
1671         [GTK] run-launcher sets wrong LD_LIBRARY_PATH
1672
1673         * Scripts/run-launcher:
1674
1675 2007-12-31  Darin Adler  <darin@apple.com>
1676
1677         Suggested by Antti.
1678
1679         * Scripts/webkitdirs.pm: Turned off the QuickTime requirement for Windows until
1680         we get it installed on the build bots.
1681
1682 2007-12-30  Eric Seidel  <eric@webkit.org>
1683
1684         Reviewed by Sam.
1685
1686         * Scripts/do-webcore-rename: Add a few more planned renames s/(\w+)Imp/\1/
1687
1688 2007-12-29  Darin Adler  <darin@apple.com>
1689
1690         Reviewed by Oliver.
1691
1692         - fix http://bugs.webkit.org/show_bug.cgi?id=16663
1693           leak bot shows createCStringFromNPVariant result leaking
1694
1695         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1696         (pluginInvoke): Added a missing free.
1697
1698 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
1699
1700         Reviewed by Alp Toker.
1701
1702         http://bugs.webkit.org/show_bug.cgi?id=16390
1703         Use autotools or GNU make as the build system for the GTK port
1704
1705         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: include glib.h
1706         * GNUmakefile.am: Added.
1707
1708 2007-12-24  Alexey Proskuryakov  <ap@webkit.org>
1709
1710         Reviewed by Oliver.
1711
1712         Fix fast/events/arrow-keys-on-body.html, failing on Windows.
1713
1714         * DumpRenderTree/win/EventSender.cpp:
1715         (keyDownCallback): Add KF_EXTENDED flag to arrow keys. Also add a count
1716         of 1, even though WebKit currently ignores it.
1717
1718 2007-12-23  Kevin Ollivier  <kevino@theolliviers.com>
1719
1720         wx buildbot fix. Update libpng dl script to the latest version.
1721
1722         * wx/install-unix-extras:
1723
1724 2007-12-22  Antti Koivisto  <antti@apple.com>
1725
1726         Fix a typo.
1727
1728         * Scripts/webkitdirs.pm:
1729
1730 2007-12-21  Sam Weinig  <sam@webkit.org>
1731
1732         Reviewed by Mark Rowe.
1733
1734         - Disable the back/forward cache using the new WebPreferences API
1735           instead of through the BackForwardList.  This makes us match what
1736           we do on Windows.
1737
1738         * DumpRenderTree/mac/DumpRenderTree.mm:
1739         (createWebViewAndOffscreenWindow):
1740         (setDefaultsToConsistentValuesForTesting):
1741
1742 2007-12-21  Dan Bernstein  <mitz@apple.com>
1743
1744         Reviewed by Mark Rowe.
1745
1746         - disable the back/forward cache in Windows DumpRenderTree. It is
1747           already disabled in Mac DumpRenderTree.
1748
1749         * DumpRenderTree/win/DumpRenderTree.cpp:
1750         (initializePreferences):
1751
1752 2007-12-13  Antti Koivisto  <antti@apple.com>
1753
1754         Reviewed by Darin and Steve.
1755         
1756         - check for QuickTime SDK on Windows.
1757         - build media support on Windows by default
1758
1759         * Scripts/build-webkit:
1760         * Scripts/webkitdirs.pm:
1761
1762 2007-12-21  Kevin Ollivier  <kevino@theolliviers.com>
1763
1764         Build script fix for buildbot.
1765
1766         * wx/build-wxwebkit:
1767
1768 2007-12-20  Eric Seidel  <eric@webkit.org>
1769
1770         Reviewed by mjs.
1771
1772         * Scripts/run-sunspider: change --runs default to 10 for better accuracy
1773
1774 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1775
1776         Reviewed by Steve.
1777
1778         - <rdar://5656485> Drosera: Win: Nightly does not reliably connect to
1779         WebKit.
1780
1781         - Drosera and Safari need to use the same ProgIDs in order for
1782         CoCreateInstance to work properly.  The most robust way to do this is
1783         for WebKit to dynamically publish those ProgIDs.
1784
1785         * Drosera/win/DebuggerClient.cpp: Use the published ProgIDs
1786         (DebuggerClient::createWebViewWithRequest):
1787         * Drosera/win/Drosera.cpp: Use the published ProgIDs and rename some
1788         statics.
1789         (Drosera::initUI):
1790         (Drosera::attach):
1791         (Drosera::attemptToCreateServerConnection):
1792         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Fix a runtime failure.
1793         * Drosera/win/ServerConnection.cpp: Reformat the connection function and
1794         make use of the published ProgIDs.
1795         (ServerConnection::attemptToCreateServerConnection):
1796
1797 2007-12-20  Kevin McCullough  <kmccullough@apple.com>
1798
1799         - <rdar://problem/5658317> REGRESSION: 20+ leaks seen on buildbots.
1800         - Build bot and leak fix.
1801
1802         * DumpRenderTree/LayoutTestController.cpp:
1803         (pathToLocalResourceCallback):
1804
1805 2007-12-19  David Kilzer  <ddkilzer@apple.com>
1806
1807         Make svn-apply/svn-unapply work with patches from git-format-patch.
1808
1809         Reviewed by Darin.
1810
1811         * Scripts/svn-apply:
1812         (patch): If 'Index:' can't be found in the text passed in, print it
1813         out with a warning and return early.
1814         * Scripts/svn-unapply:
1815         (patch): Ditto.
1816
1817 2007-12-18  Kevin Ollivier  <kevino@theolliviers.com>
1818
1819         Reviewed by Alp Toker.
1820
1821         Build related fixes.
1822
1823         * wx/build-wxwebkit:
1824         - Check to make sure the user is running a supported wx port
1825         - More robust checks for Cygwin
1826         - Only run install-unix-extras on Mac, it's not the right solution
1827           for Linux distros.
1828         - Remove outdated Linux instructions after successful build
1829         - Clean Bakefile-generated files during a clean operation
1830
1831 2007-12-18  Darin Adler  <darin@apple.com>
1832
1833         * Scripts/make-js-test-wrappers: Don't generate a wrapper for select-options-remove.js.
1834
1835 2007-12-18  Steve Falkenburg  <sfalken@apple.com>
1836
1837         Add script to run Drosera as part of the nightly.
1838         
1839         Reviewed by Kevin M.
1840
1841         * Scripts/run-drosera.cmd: Added.
1842
1843 2007-12-18  Darin Adler  <darin@apple.com>
1844
1845         * Scripts/do-webcore-rename: Remove a stray K.
1846
1847 2007-12-18  Darin Adler  <darin@apple.com>
1848
1849         * Scripts/do-webcore-rename: Plan more renaming.
1850
1851 2007-12-14  Juan A. Suarez Romero  <jasuarez@igalia.com>
1852
1853         Reviewed by Alp Toker.
1854
1855         http://bugs.webkit.org/show_bug.cgi?id=16042
1856         [GTK] Eliminate webkit_init()
1857
1858         Moving webkit initialization to WebView class init.
1859
1860         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1861         (main):
1862         * GtkLauncher/main.c:
1863         (main):
1864
1865 2007-12-17  Luca Bruno  <lethalman88@gmail.com>
1866
1867         Reviewed by Alp Toker.
1868
1869         http://bugs.webkit.org/show_bug.cgi?id=13542
1870         gdklauncher doesnt change URL in adress GTKEntry.
1871
1872         * GtkLauncher/main.c:
1873         (load_commit_cb): added
1874         (title_change_cb):
1875         (create_browser):
1876
1877 2007-12-16  Dimitri Glazkov  <dimitri@glazkov.com>
1878
1879         Reviewed by Adam Roben.
1880
1881         Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
1882
1883         * FindSafari/FindSafari.cpp:
1884         (_tmain):
1885
1886 2007-12-16  Brent Fulgham  <bfulgham@gmail.com>
1887
1888         Reviewed by Adam Roben.
1889
1890         http://bugs.webkit.org/show_bug.cgi?id=16315
1891         FindSafari needs a path-only option.
1892
1893         * FindSafari/FindSafari.cpp:
1894         (_tmain):
1895
1896 2007-12-16  Alexey Proskuryakov  <ap@webkit.org>
1897
1898         Reviewed by Darin.
1899
1900         http://bugs.webkit.org/show_bug.cgi?id=16462
1901         REGRESSION: access keys broken on Windows
1902
1903         * DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Send system key events
1904         if Alt is pressed.
1905
1906 2007-12-15  Sam Weinig  <sam@webkit.org>
1907
1908         Reviewed by Mark Rowe.
1909
1910         Fix urlSuitableForTestResult to correctly identify wstring::npos as
1911         the case when wstring.find doesn't find anything.
1912
1913         * DumpRenderTree/win/DumpRenderTree.cpp:
1914         (urlSuitableForTestResult):
1915
1916 2007-12-15  Alp Toker  <alp@atoker.com>
1917
1918         GTK+ DRT build fix for GLib < 2.14.
1919
1920         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1921         (LayoutTestController::setWaitToDump):
1922
1923 2007-12-05  Mark Rowe  <mrowe@apple.com>
1924
1925         Reviewed by Alp Toker.
1926
1927         Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.  This prevents
1928         many layout tests from hanging while waiting on user responses to dialogs.
1929
1930         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1931         (invalidateAnyPreviousWaitToDumpWatchdog):
1932         (webViewScriptAlert):
1933         (webViewScriptPrompt):
1934         (webViewScriptConfirm):
1935         (main):
1936         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1937         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1938         (waitToDumpWatchdogFired):
1939         (LayoutTestController::setWaitToDump):
1940
1941 2007-12-05  Mark Rowe  <mrowe@apple.com>
1942
1943         Reviewed by Alp Toker.
1944
1945         Flesh out DumpRenderTree for Gtk.  After these changes, the majority of the tests in fast/js pass.
1946
1947         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1948         (dumpFramesAsText): Don't print the frame name when dumping the main frame as text.
1949         (dump):
1950         (runTest):
1951         (webViewLoadStarted): Store the top frame when it starts loading so we can use it to determine when to dump.
1952         (webViewLoadFinished): Dump when the top frame load completes if we're not waiting for a JS callback and the
1953         work queue is empty.
1954         (webViewWindowObjectCleared): Set up window.layoutTestController.
1955         (webViewConsoleMessage): Match the console message format expected by the layout test results.
1956         (main): Hook up the new signals.
1957         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1958         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Only notify done if the top frame has completed loading to avoid
1959         dumping multiple times.
1960         * Scripts/build-dumprendertree: Ensure build-dumprendertree is a no-op for Gtk too.
1961         * Scripts/run-webkit-tests: Teach run-webkit-tests that Gtk is like Qt in many ways.  Use run-launcher to open test results.
1962
1963 2007-12-14  Anders Carlsson  <andersca@apple.com>
1964
1965         Reviewed by Brady.
1966
1967         Assert that a web frame that's loading a resource always has either a data source or 
1968         a provisional data source.
1969         
1970         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1971         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1972
1973 2007-12-14  Darin Adler  <darin@apple.com>
1974
1975         - fix mistake causing nearly all tests to fail on Windows
1976
1977         * DumpRenderTree/win/UIDelegate.cpp:
1978         (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with
1979         npos, not 0. Also pass URL in to URL function rather than passing the entire message.
1980
1981         * DumpRenderTree/mac/UIDelegate.mm:
1982         (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather
1983         than passing the entire message.
1984
1985 2007-12-14  Darin Adler  <darin@apple.com>
1986
1987         - fix Tiger build
1988
1989         * DumpRenderTree/mac/UIDelegate.mm:
1990         (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any
1991         new-to-Leopard methods.
1992
1993 2007-12-14  Darin Adler  <darin@apple.com>
1994
1995         * DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method
1996         since it now triggers unwanted icon loading. We only had it because we implemented "all"
1997         delegate methods here.
1998
1999 2007-12-14  Anders Carlsson  <andersca@apple.com>
2000
2001         Reviewed by Darin and Geoff.
2002
2003         <rdar://problem/5619295> 
2004         REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
2005         
2006         Add property getting methods to the plug-in.
2007         
2008         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2009         (pluginInvoke):
2010
2011 2007-12-14  Kevin McCullough  <kmccullough@apple.com>
2012
2013         Reviewed by Darin.
2014
2015         - Layout test fix for mac. When dumped to the console local file paths
2016         now only show the name of the resource not the whole path.  This is to
2017         make the results machine and OS independent.
2018
2019         * DumpRenderTree/mac/UIDelegate.mm:
2020         (-[UIDelegate webView:addMessageToConsole:]):
2021
2022 2007-12-13  Kevin McCullough  <kmccullough@apple.com>
2023
2024         Reviewed by Adam.
2025
2026         - Layout tests fix.  We need a way to remove machine-dependent
2027         information from paths in layout test results. The UIDelegate now does
2028         this.
2029
2030         * DumpRenderTree/DumpRenderTree.h:
2031         * DumpRenderTree/win/DumpRenderTree.cpp:
2032         (urlSuitableForTestResult):
2033         * DumpRenderTree/win/DumpRenderTreeWin.h:
2034         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2035         * DumpRenderTree/win/UIDelegate.cpp:
2036         (UIDelegate::webViewAddMessageToConsole):
2037
2038 2007-12-13  Alp Toker  <alp@atoker.com>
2039
2040         Build fix for DRT breakage introduced in r28690.
2041
2042         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2043         (LayoutTestController::pathToLocalResource):
2044
2045 2007-12-12  Kevin McCullough  <kmccullough@apple.com>
2046
2047         Reviewed by Alice and Sam.
2048
2049         - <rdar://5621435> Need a way to specify local resources (being loaded
2050         from HTTP tests) on Windows.
2051         - Implemented pathToLocalResource which exposes the functionality of
2052         converting a given unix path to the correct location on Windows.
2053
2054         * DumpRenderTree/LayoutTestController.cpp:
2055         (pathToLocalResourceCallback):
2056         (LayoutTestController::staticFunctions):
2057         * DumpRenderTree/LayoutTestController.h:
2058         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2059         (LayoutTestController::pathToLocalResource):
2060         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2061         (LayoutTestController::pathToLocalResource):
2062
2063 2007-12-12  Anders Carlsson  <andersca@apple.com>
2064
2065         Reviewed by Sam.
2066
2067         <rdar://problem/5132003>
2068         dumpResourceLoadCallbacks is not implemented in DRT on Windows.
2069
2070         * DumpRenderTree/win/DumpRenderTree.cpp:
2071         (main):
2072         Set the resource load delegate.
2073         
2074         * DumpRenderTree/win/DumpRenderTree.vcproj:
2075         
2076         * DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
2077         * DumpRenderTree/win/ResourceLoadDelegate.h: Added.
2078
2079 2007-12-12  Alexey Proskuryakov  <ap@webkit.org>
2080
2081         Reviewed by Adam Roben.
2082
2083         Fix conversion from double to LPARAM in dispatchMessage().
2084
2085         * DumpRenderTree/win/EventSender.cpp:
2086         (dispatchMessageCallback):
2087
2088 2007-12-11  Dan Bernstein  <mitz@apple.com>
2089
2090         Reviewed by Mark Rowe and Sam Weinig too!
2091
2092         - added Helvetica Oblique and Helvetica Bold Oblique to the list of
2093           fonts DumpRenderTree registers.
2094
2095         * DumpRenderTree/win/DumpRenderTree.cpp:
2096         (initialize):
2097
2098 2007-12-11  Brady Eidson  <beidson@apple.com>
2099
2100         Reviewed by Anders
2101
2102         Make DumpRenderTree on mac use its own path for Databases testing
2103
2104         * DumpRenderTree/mac/DumpRenderTree.mm:
2105         (setDefaultsToConsistentValuesForTesting): Keep a string to ~/Library/Application Support/DumpRenderTree 
2106           for future DRT-only use, then use it to construct the Databases path and set that default
2107
2108 2007-12-07  Alexey Proskuryakov  <ap@webkit.org>
2109
2110         Reviewed by Darin.
2111
2112         <rdar://problem/5535636>
2113         Have to press 4 times instead of 2 times to get the expected result of ^^ with german keyboard.
2114
2115         http://bugs.webkit.org/show_bug.cgi?id=13916
2116         JavaScript detects Tab as a character input on a textfield validation
2117
2118         * DumpRenderTree/mac/EventSendingController.mm:
2119         (-[EventSendingController keyDown:withModifiers:]): Added a few more named keys.
2120         Dispatch a keyup to better match what happens when a key is physically pressed.
2121
2122         * DumpRenderTree/win/EventSender.cpp:
2123         (keyDownCallback): Ditto. Also make sure that WM_CHAR is consistently dispatched before
2124         returning from keyDown().
2125         (getConstantCallback): Fixed a couple copy/paste mistakes.
2126
2127 2007-12-07  Kevin McCullough  <kmccullough@apple.com>
2128
2129         Reviewed by Oliver.
2130
2131         - <rdar://5599845> Drosera: Does not show loal files in the file list
2132         on the left side.
2133
2134         * Drosera/debugger.js: - Updated url dividing regex to handle %s and :s.
2135         * Drosera/win/Drosera.vcproj/Drosera.vcproj: - Updated Debug settings
2136         so the open source community can build.
2137
2138 2007-12-10  Brady Eidson  <beidson@apple.com>
2139
2140         Rubberstamped by Sam Weinig
2141
2142         Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
2143
2144         * DumpRenderTree/mac/UIDelegate.mm:
2145         (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
2146         (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
2147
2148 2007-12-08  Oliver Hunt  <oliver@apple.com>
2149
2150         Reviewed by Sam W.
2151
2152         Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
2153         
2154         Fixes <rdar://problem/5620249> Must disable SVG animation
2155         <rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
2156         
2157         In order to allow finer grained control over the set of SVG features
2158         this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
2159         distinct flags:
2160         ENABLE_SVG_ANIMATION
2161         ENABLE_SVG_FILTERS
2162         ENABLE_SVG_FONTS
2163         ENABLE_SVG_AS_IMAGE
2164         ENABLE_SVG_USE
2165         
2166         by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
2167         
2168         Script handles all the new build flags, and allows --svg-experimental
2169         to automatically enable all features.
2170
2171         * Scripts/build-webkit:
2172
2173 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
2174
2175         Fix version parsing.
2176
2177         Rubber-stamped by Oliver.
2178
2179         * Drosera/win/Drosera.vcproj/auto-version.sh:
2180
2181 2007-12-07  Steve Falkenburg  <sfalken@apple.com>
2182
2183         Build modifications for Drosera.
2184
2185         Reviewed by Adam.
2186
2187         * Drosera/DroseraWin.make: Added.
2188         * Drosera/win/Drosera.vcproj/Drosera.rc:
2189         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2190         * Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
2191         * Drosera/win/Drosera.vcproj/VERSION: Added.
2192         * Drosera/win/Drosera.vcproj/auto-version.sh: Added.
2193
2194 2007-12-06  Adam Roben  <aroben@apple.com>
2195
2196         Explicitly turn on the Mac font ascent hack on Windows
2197
2198         This keeps our font metrics matching those from Mac.
2199
2200         Reviewed by Hyatt.
2201
2202         * DumpRenderTree/win/DumpRenderTree.cpp:
2203         (main):
2204
2205 2007-12-06  Anders Carlsson  <andersca@apple.com>
2206
2207         Rename main.c to main.cpp here too.
2208         
2209         * DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
2210
2211 2007-12-06  Sam Weinig  <sam@webkit.org>
2212
2213         Rubber stamped by Geoff.
2214
2215         * Scripts/do-webcore-rename: Don't rename kjs_css twice.
2216
2217 2007-12-06  Darin Adler  <darin@apple.com>
2218
2219         * Scripts/do-webcore-rename: Some more renaming plans.
2220
2221 2007-12-06  Anders Carlsson  <andersca@apple.com>
2222
2223         Restore implementation of testGetIntIdentifier that was accidentally
2224         removed somehow (possibly when I made PluginObject be a cpp file).
2225         
2226         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2227         (pluginInvoke):
2228
2229 2007-12-05  Anders Carlsson  <andersca@apple.com>
2230
2231         Make the entry points extern "C".
2232         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2233         
2234 2007-12-05  Anders Carlsson  <andersca@apple.com>
2235
2236         C++ warning fixes.
2237         
2238         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2239         (NPP_New):
2240         (NPP_Destroy):
2241         (NPP_SetWindow):
2242         (NPP_NewStream):
2243         (NPP_HandleEvent):
2244         (NPP_URLNotify):
2245         (NPP_GetValue):
2246
2247 2007-12-05  Anders Carlsson  <andersca@apple.com>
2248
2249         Add the .cpp files to the TestNetscapePlugIn target.
2250
2251         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2252
2253 2007-12-05  Anders Carlsson  <andersca@apple.com>
2254
2255         Reviewed by Geoff.
2256         
2257         Rename the TestNetscapePlugIn .c files to be .cpp.
2258
2259         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2260         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Removed.
2261         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c.
2262         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Removed.
2263         * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c.
2264         * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: Removed.
2265         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Copied from DumpRenderTree/TestNetscapePlugIn.subproj/main.c.
2266         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2267
2268 2007-12-05  Adam Roben  <aroben@apple.com>
2269
2270         Fix case of keypresses from the Windows implementation of eventSender.keyDown
2271
2272         This fixes several regression tests.
2273
2274         Reviewed by Alice.
2275
2276         * DumpRenderTree/win/EventSender.cpp:
2277         (keyDownCallback): Virtual keycodes for ASCII characters are always
2278         uppercase, so we need to check the case of the original character
2279         passed in to eventSender.keyDown.
2280
2281 2007-12-05  Adam Roben  <aroben@apple.com>
2282
2283         Learn from Tim's mistakes
2284
2285         * DumpRenderTree/win/DumpRenderTree.cpp:
2286         (runTest): Reset the authorAndUserStylesEnabled preference for each
2287         test.
2288
2289 2007-12-05  Alp Toker  <alp@atoker.com>
2290
2291         Reviewed by Mark Rowe.
2292
2293         Initialize GTK+ and WebKit so the tests can run.
2294
2295         Reorganize the headers a little.
2296
2297         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2298         (main):
2299
2300 2007-12-04  Anders Carlsson  <andersca@apple.com>
2301
2302         Remove IWebScriptScope include.
2303         
2304         * Drosera/win/DebuggerDocumentPlatform.cpp:
2305
2306 2007-12-04  Sam Weinig  <sam@webkit.org>
2307
2308         Rubber stamped by Mark Rowe.
2309
2310         Define CF as platform for mac and revert r28409
2311
2312         * DumpRenderTree/DumpRenderTree.h:
2313         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2314
2315 2007-12-04  Sam Weinig  <sam@webkit.org>
2316
2317         Define CF as platform for windows.
2318
2319         Reviewed by Adam Roben.
2320
2321         * DumpRenderTree/win/DumpRenderTreeWin.h:
2322
2323 2007-12-04  Kevin McCullough  <kmccullough@apple.com>
2324
2325         Reviewed by Adam and Darin.
2326
2327         - Removed a needless BSTR cleanup.
2328
2329         * Drosera/win/DebuggerDocumentPlatform.cpp:
2330         (DebuggerDocument::getPlatformCurrentFunctionStack):
2331
2332 2007-11-27  Adam Roben  <aroben@apple.com>
2333
2334         Fix <rdar://5614497> setAuthorAndUserStylesEnabled is not implemented in DRT
2335
2336         Reviewed by Maciej.
2337
2338         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2339         (LayoutTestController::setAuthorAndUserStylesEnabled): Implemented.
2340
2341 2007-12-04  Alp Toker  <alp@atoker.com>
2342
2343         Prospective Win DRT build fix.
2344
2345         * DumpRenderTree/DumpRenderTree.h:
2346
2347 2007-12-04  Alp Toker  <alp@atoker.com>
2348
2349         Fix a clobbered copyright header.
2350
2351         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2352
2353 2007-12-04  Xan Lopez  <xan@gnome.org>
2354
2355         Reviewed by Alp Toker.
2356
2357         http://bugs.webkit.org/show_bug.cgi?id=15561
2358         GTK port needs DumpRenderTree implementation
2359
2360         Start work on the GTK+ DRT.
2361
2362         This does not work yet, and there are a few lingering style issues
2363         (nothing major) but this patch has been stuck in the bug tracker for
2364         too long already.
2365
2366         * DumpRenderTree/DumpRenderTree.h:
2367         * DumpRenderTree/gtk: Added.
2368         * DumpRenderTree/gtk/DumpRenderTree.cpp: Added.
2369         (autocorrectURL):
2370         (shouldLogFrameLoadDelegates):
2371         (dumpFrameScrollPosition):
2372         (displayWebView):
2373         (appendString):
2374         (dumpFramesAsText):
2375         (dumpRenderTreeAsText):
2376         (dump):
2377         (runTest):
2378         (main):
2379         * DumpRenderTree/gtk/DumpRenderTree.pro: Added.
2380         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Added.
2381         * DumpRenderTree/gtk/GCControllerGtk.cpp: Added.
2382         (GCController::collect):
2383         (GCController::collectOnAlternateThread):
2384         (GCController::getJSObjectCount):
2385         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added.
2386         (LayoutTestController::~LayoutTestController):
2387         (LayoutTestController::addDisallowedURL):
2388         (LayoutTestController::clearBackForwardList):
2389         (LayoutTestController::copyDecodedHostName):
2390         (LayoutTestController::copyEncodedHostName):
2391         (LayoutTestController::display):
2392         (LayoutTestController::keepWebHistory):
2393         (LayoutTestController::notifyDone):
2394         (LayoutTestController::queueBackNavigation):
2395         (LayoutTestController::queueForwardNavigation):
2396         (LayoutTestController::queueLoad):
2397         (LayoutTestController::queueReload):
2398         (LayoutTestController::queueScript):
2399         (LayoutTestController::setAcceptsEditing):
2400         (LayoutTestController::setCustomPolicyDelegate):
2401         (LayoutTestController::setMainFrameIsFirstResponder):
2402         (LayoutTestController::setTabKeyCyclesThroughElements):
2403         (LayoutTestController::setUseDashboardCompatibilityMode):
2404         (LayoutTestController::setUserStyleSheetEnabled):
2405         (LayoutTestController::setUserStyleSheetLocation):
2406         (LayoutTestController::setWindowIsKey):
2407         (LayoutTestController::setWaitToDump):
2408         (LayoutTestController::windowCount):
2409         (LayoutTestController::setPrivateBrowsingEnabled):
2410         (LayoutTestController::setAuthorAndUserStylesEnabled):
2411         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Added.
2412         (JSStringCopyUTF8CString):
2413         (LoadItem::invoke):
2414         (ReloadItem::invoke):
2415         (ScriptItem::invoke):
2416         (BackForwardItem::invoke):
2417
2418 2007-12-03  Sam Weinig  <sam@webkit.org>
2419
2420         Move JavaScriptCore thread testing code to pthread specific directory
2421         and remove the dependance on CoreFoundation by using WTF::HashSet.
2422
2423         Reviewed by Geoff and Oliver.
2424
2425         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2426         * DumpRenderTree/ForwardingHeaders/wtf/HashMap.h: Added.
2427         * DumpRenderTree/ForwardingHeaders/wtf/HashSet.h: Added.
2428         * DumpRenderTree/ForwardingHeaders/wtf/Vector.h: Added.
2429         * DumpRenderTree/JavaScriptThreading.h: Copied from DumpRenderTree/mac/JavaScriptThreading.h.
2430         * DumpRenderTree/mac/JavaScriptThreading.cpp: Removed.
2431         * DumpRenderTree/mac/JavaScriptThreading.h: Removed.
2432         * DumpRenderTree/pthreads: Added.
2433         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Copied from DumpRenderTree/mac/JavaScriptThreading.cpp.
2434         (javaScriptThreads):
2435         (runJavaScriptThread):
2436         (startJavaScriptThreads):
2437         (stopJavaScriptThreads):
2438
2439 2007-12-03  Andrew Bonventre  <andybons@google.com>
2440
2441         Reviewed by Darin Adler.
2442
2443         - fix http://bugs.webkit.org/show_bug.cgi?id=16267
2444         Symbol lookup menu broken in debugger view
2445
2446         * Drosera/debugger.js: Fixed javascript error where document property
2447         should have been used instead of contentDocument in switchFunction that
2448         was breaking the select symbol dropdown menu.  This is because
2449         window.frames will return a Window object and not a frame object like
2450         the author was originally expecting.
2451
2452 2007-12-03  Kevin McCullough  <kmccullough@apple.com>
2453
2454         Reviewed by Adam.
2455
2456         - <rdar://5618942> Drosera: Console window does not process everything
2457         correctly.
2458         - <rdar://5619005> Drosera: could be sped up by moving the 
2459         WebScriptScope stuff into the WebScriptCallFrame.
2460         - Now the console can correctly process objects and does not receive
2461         notifications from JavaScriptCore about the JavaScript in Drosera's
2462         own process.
2463
2464         * Drosera/win/DebuggerDocumentPlatform.cpp:
2465         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2466         (DebuggerDocument::platformValueForScopeVariableNamed):
2467
2468 2007-12-03  Stephanie  <slewis@apple.com>
2469
2470         Reviewed by Darin.
2471
2472         Check to see if we are building a debug root
2473
2474         * Scripts/check-for-global-initializers: 
2475
2476 2007-12-03  Dan Bernstein  <mitz@apple.com>
2477
2478         Reviewed by Darin Adler.
2479
2480         - added a testGetIntIdentifier() method to TestNetscapePlugIn
2481
2482         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
2483         (pluginInvoke):
2484
2485 2007-12-03  Alexey Proskuryakov  <ap@webkit.org>
2486
2487         Reviewed by Oliver.
2488
2489         Added eventSender.dispatchMessage() - will be used to test Windows keyboard input
2490         in a more fine-grained manner than eventSender.keyDown().
2491
2492         * DumpRenderTree/win/EventSender.cpp:
2493         (getConstantCallback):
2494         (dispatchMessageCallback):
2495
2496 2007-12-02  Darin Adler  <darin@apple.com>
2497
2498         * Scripts/do-webcore-rename: More planned renaming.
2499
2500 2007-12-02  Sam Weinig  <sam@webkit.org>
2501
2502         Rubber stamped by Anders.
2503
2504         Use [NSURL absoluteString] instead of [NSURL description] in order to get
2505         more uniform results cross platform.
2506
2507         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2508         (-[NSURL _drt_descriptionSuitableForTestResult]):
2509
2510 2007-12-02  Sam Weinig  <sam@webkit.org>
2511
2512         Rubber stamped by Niko.
2513
2514         Rename FrameLoaderDelegate.h/cpp to FrameLoadDelegate.h/cpp.
2515
2516         * DumpRenderTree/win/DumpRenderTree.cpp:
2517         * DumpRenderTree/win/DumpRenderTree.vcproj:
2518         * DumpRenderTree/win/FrameLoadDelegate.cpp: Copied from DumpRenderTree/win/FrameLoaderDelegate.cpp.
2519         * DumpRenderTree/win/FrameLoadDelegate.h: Copied from DumpRenderTree/win/FrameLoaderDelegate.h.
2520         * DumpRenderTree/win/FrameLoaderDelegate.cpp: Removed.
2521         * DumpRenderTree/win/FrameLoaderDelegate.h: Removed.
2522
2523 2007-12-01  Alp Toker  <alp@atoker.com>
2524
2525         Reviewed by Adam Roben.
2526
2527         Make use of the newly introduced webkit.h convenience header.
2528
2529         * GtkLauncher/main.c:
2530
2531 2007-12-01  Adam Treat  <treat@kde.org>
2532
2533         Reviewed by Simon.
2534
2535         * Check to see if the directory exists and exit if not.
2536
2537         * DumpRenderTree/qt/main.cpp:
2538         (main):
2539
2540 2007-12-01  Adam Treat  <treat@kde.org>
2541
2542         Reviewed by Simon.
2543
2544         * Don't hide symbols when in Debug mode
2545         * On Linux (glibc) provide a backtrace in the test output for debugging purposes
2546
2547
2548         * DumpRenderTree/qt/main.cpp:
2549         (messageHandler):
2550
2551 2007-11-30  Alp Toker  <alp@atoker.com>
2552
2553         Reviewed by Adam Roben.
2554
2555         http://bugs.webkit.org/show_bug.cgi?id=15691
2556         [GTK] Public API does not follow GTK+ conventions
2557
2558         Refactor the WebKit/GTK+ public API. Changes:
2559           WebKitPage -> WebKitWebView
2560           WebKitFrame -> WebKitWebFrame
2561
2562         Public API source and header names have been updated to mirror the API
2563         changes.
2564
2565         The API is now kept in WebKit/gtk/WebView to match other ports in the
2566         same class such as Mac and Win.
2567
2568         * GtkLauncher/main.c:
2569         (activate_uri_entry_cb):
2570         (link_hover_cb):
2571         (title_change_cb):
2572         (progress_change_cb):
2573         (go_back_cb):
2574         (go_forward_cb):
2575         (create_browser):
2576         (main):
2577
2578 2007-11-30  Adam Roben  <aroben@apple.com>
2579
2580         Hopefully the final build fix
2581
2582         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Link against WTF.lib to
2583         pull in WTF's assertion/logging functions.
2584
2585 2007-11-30  Adam Roben  <aroben@apple.com>
2586
2587         Another build fix
2588
2589         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Use the right suffix for
2590         WebKit.lib.
2591
2592 2007-11-30  Adam Roben  <aroben@apple.com>
2593
2594         Debug build fix
2595
2596         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added a Debug_Internal
2597         configuration.
2598         * Drosera/win/Drosera.vcproj/debug.vsprops: Updated to match other
2599         projects.
2600         * Drosera/win/Drosera.vcproj/release.vsprops: Ditto.
2601         * Drosera/win/Drosera.vcproj/debug_internal.vsprops: Copied from
2602         WebKitTools/DumpRenderTree/win/debug_internal.vsprops.
2603
2604 2007-11-30  Sam Weinig  <sam@webkit.org>
2605
2606         Reviewed by Adam Roben.
2607
2608         Fix drawSelectionRect to actually draw the selection rect.
2609
2610         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2611         (drawSelectionRect):
2612
2613 2007-11-30  Darin Adler  <darin@apple.com>
2614
2615         * Scripts/do-webcore-rename: WildFox already did the TextStyle -> FontStyle one.
2616
2617 2007-11-30  Darin Adler  <darin@apple.com>
2618
2619         * Scripts/do-webcore-rename: Get ready for some future renaming.
2620
2621 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2622
2623         Reviewed by Adam.
2624
2625         - Removed some unnecessary functions and changed an unused return type. 
2626
2627         * Drosera/win/DebuggerClient.cpp:
2628         (registerConsoleClass):
2629         * Drosera/win/DebuggerClient.h:
2630         * Drosera/win/Drosera.cpp:
2631         (registerDroseraClass):
2632
2633 2007-11-28  Alp Toker  <alp@atoker.com>
2634
2635         Reviewed by Timothy Hatcher.
2636
2637         http://bugs.webkit.org/show_bug.cgi?id=16174
2638         [GTK] Use "URI" not "URL" in public API
2639
2640         Replace use of the term "URL" with "URI" in public headers,
2641         documentation and some internal code to match GLib/GTK+ convention.
2642
2643         This is now mentioned in the API guidelines:
2644           http://trac.webkit.org/projects/webkit/wiki/HackingGtk
2645
2646         * GtkLauncher/main.c:
2647         (activate_uri_entry_cb):
2648         (title_change_cb):
2649         (create_toolbar):
2650         (main):
2651
2652 2007-11-29  Anders Carlsson  <andersca@apple.com>
2653
2654         Reviewed by Sam.
2655
2656         <rdar://problem/5230478>
2657         FrameLoadDelegate callbacks are not dumped in DRT.
2658         
2659         * DumpRenderTree/win/DumpRenderTree.cpp:
2660         (shouldLogFrameLoadDelegates):
2661         (runTest):
2662         (main):
2663         * DumpRenderTree/win/FrameLoaderDelegate.cpp:
2664         (BSTRtoString):
2665         (descriptionSuitableForTestResult):
2666         (FrameLoadDelegate::QueryInterface):
2667         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2668         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2669         (FrameLoadDelegate::didCommitLoadForFrame):
2670         (FrameLoadDelegate::didFinishLoadForFrame):
2671         (FrameLoadDelegate::willCloseFrame):
2672         (FrameLoadDelegate::didClearWindowObject):
2673         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2674         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2675         * DumpRenderTree/win/FrameLoaderDelegate.h:
2676         (FrameLoadDelegate::windowScriptObjectAvailable):
2677         (FrameLoadDelegate::didFirstLayoutInFrame):
2678
2679 2007-11-29  Sam Weinig  <sam@webkit.org>
2680
2681         Reviewed by Anders.
2682
2683         Add database quota UIDelegates methods to DRT UIDelegate.
2684
2685         * DumpRenderTree/mac/UIDelegate.mm:
2686         (-[UIDelegate webView:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]):
2687         (-[UIDelegate webView:quotaForSecurityOrigin:fromProposedQuota:database:]):
2688
2689 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2690
2691         Reviewed by Sam.
2692
2693         - <rdar://5618976> Drosera: should listen for the WebScriptDebugServer
2694         dying and vice versa.
2695         - This fix will allow Drosera and Safari to reconnect if either of them
2696         closes correctly, but does not fix the case where one of them dies
2697         silently.
2698
2699         * Drosera/win/ServerConnection.cpp:
2700         (ServerConnection::attemptToCreateServerConnection): Added a safety
2701         check, because it's possilbe to try to connect to a server that's dying.
2702         (ServerConnection::serverDidDie): Implemented. This resets Drosera when
2703         the server has died.
2704         * Drosera/win/ServerConnection.h: Added the new function and removed
2705         an unnecessary member.
2706
2707 2007-11-29  Anders Carlsson  <andersca@apple.com>
2708
2709         * DumpRenderTree/win/DumpRenderTree.vcproj:
2710         Add shlwapi.lib to all configurations.
2711
2712 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2713
2714         - Build fix.  Added additional includes for VS Express to the Release
2715         project.
2716
2717         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2718
2719 2007-11-29  Anders Carlsson  <andersca@apple.com>
2720
2721         Reviewed by Adam.
2722
2723         <rdar://problem/5132005>
2724         setUserStyleSheetEnabled is not fully implemented in Windows DRT.
2725         
2726         * DumpRenderTree/win/DumpRenderTree.vcproj:
2727         Add shlwapi.lib
2728         
2729         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2730         (LayoutTestController::setUserStyleSheetEnabled):
2731         Implement this.
2732         
2733         (appendComponentToPath):
2734         New method which wraps the Win32 API PathAppend.
2735         
2736         (followShortcuts):
2737         New method which checks if a file points to a shortcut and
2738         follows the shortcut.
2739         
2740         (resolveCygwinPath):
2741         New method that takes a cygwin unix-style path and returns the Win32 path.
2742         
2743         (cfStringRefToWString):
2744         
2745         (LayoutTestController::setUserStyleSheetLocation):
2746         Implement this.
2747
2748 2007-11-29  Alice Liu  <alice.liu@apple.com>
2749
2750         Reviewed by Adam.
2751
2752         Fixed <rdar://5133828> fast/frames/iframe-window-focus.html output is lowercase
2753
2754         * DumpRenderTree/win/EventSender.cpp:
2755         (keyDownCallback):
2756         uppercase letters were being sent as lowercase letters without the shift key down.
2757
2758 2007-11-29  Kevin McCullough  <kmccullough@apple.com>
2759
2760         - Windows build fix. VS express needs some love.
2761
2762         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
2763
2764 2007-11-28  Darin Adler  <darin@apple.com>
2765
2766         Reviewed by Adam Roben.
2767
2768         * DumpRenderTree/mac/EventSendingController.mm:
2769         (-[EventSendingController keyDown:withModifiers:]):
2770         Send capital letters through as lowercase letters with the shift key down
2771         rather than sending them as if they were highly unusual "capital letter keys".
2772
2773         * Scripts/update-javascriptcore-test-results: Add a "--force" option for cases
2774         where you need to update results and more tests are failing than before.
2775
2776 2007-11-28  Anders Carlsson  <andersca@apple.com>
2777
2778         Reviewed by Darin.
2779
2780         <rdar://problem/5132001>
2781         contextClick is not implemented in DRT on Windows.
2782         
2783         * DumpRenderTree/win/EventSender.cpp:
2784         (contextClickCallback):
2785         Add a callback for contextClick, which sends a WM_RBUTTONDOWN message followed
2786         by a WM_RBUTTONUP message.
2787         
2788         * DumpRenderTree/win/UIDelegate.cpp:
2789         (UIDelegate::hasCustomMenuImplementation):
2790         (UIDelegate::trackCustomPopupMenu):
2791         * DumpRenderTree/win/UIDelegate.h:
2792         Add a no-op implementation of trackCustomPopupMenu, to prevent the default popup
2793         menu from being shown (and causing the DRT to hang).
2794
2795 2007-11-27  Maciej Stachowiak  <mjs@apple.com>
2796
2797         Reviewed by Darin.
2798
2799         Fix DumpRenderTree ObjC bug comparing strings.
2800
2801         * DumpRenderTree/mac/ObjCController.m:
2802         (-[ObjCController identityIsEqual::]): Compare strings with string
2803         equality instead of identiy equality.
2804
2805 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2806
2807         Reviewed by Sam.
2808
2809         Reset the authorAndUserStylesEnabled preference
2810         back to YES for each test. Fixes the broken tests.
2811
2812         * DumpRenderTree/mac/DumpRenderTree.mm:
2813         (resetWebViewToConsistentStateBeforeTesting):
2814
2815 2007-11-27  Kevin McCullough  <kmccullough@apple.com>
2816
2817         Reviewed by Adam.
2818
2819         - Drosera now displays the console window, although it cannot currently
2820         process JavaScript.
2821
2822         * Drosera/win/DebuggerClient.cpp: Shows the console window.
2823         (registerConsoleClass): Implemented.
2824         (consoleWndProc): Implemented.
2825         (DebuggerClient::onSize): Implemented.
2826         (DebuggerClient::createWebViewWithRequest): Implemented, now creates a
2827         new window.
2828         * Drosera/win/DebuggerClient.h: Added needed method and members for 
2829         creating and maintaining a new window.
2830         * Drosera/win/Drosera.cpp: Fixed some minor bugs, and moved a couple of
2831         lines of code to more appropriate places.
2832         (Drosera::handleCommand):
2833         (Drosera::initUI):
2834         (Drosera::onSize):
2835         (Drosera::attach):
2836
2837 2007-11-27  Timothy Hatcher  <timothy@apple.com>
2838
2839         Reviewed by Dave Hyatt.
2840
2841         <rdar://problem/5569233> Add the ability to disable author and user CSS styles
2842         
2843         Add support for disabling author and user styles for testing.
2844
2845         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2846         * DumpRenderTree/LayoutTestController.cpp:
2847         (setAuthorAndUserStylesEnabledCallback):
2848         (LayoutTestController::staticFunctions):
2849         * DumpRenderTree/LayoutTestController.h:
2850         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2851         (LayoutTestController::setAuthorAndUserStylesEnabled):
2852         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2853         (LayoutTestController::setAuthorAndUserStylesEnabled):
2854
2855 2007-11-26  Dan Bernstein  <mitz@apple.com>
2856
2857         - Tiger build fix.
2858
2859         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2860
2861 2007-11-26  Kevin McCullough  <kmccullough@apple.com>
2862
2863         Reviewed by Maciej.
2864
2865         - Implemented displaying variables for Drosera on Win.
2866
2867         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed Drosera functions
2868         that retrieve variables to not hold onto the return value since it's
2869         not returned.  Also changed to use the new signatures of the retrieval
2870         functions.
2871         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
2872         (DebuggerDocument::platformValueForScopeVariableNamed):
2873         * Drosera/win/Drosera.cpp: Removed a needless TODO.
2874         (droseraWndProc):
2875
2876 2007-11-26  Sam Weinig  <sam@webkit.org>
2877
2878         Cleanup names of painting and repainting functions.
2879
2880         Reviewed by Adam Roben.
2881
2882         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2883         (drawSelectionRect): was drawSelectionRectIntoContext.
2884         (dumpWebViewAsPixelsAndCompareWithExpected):
2885         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2886         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2887         (paintWebView): was drawWebViewIntoContext.
2888         (repaintWebView): was repaintWithVerticalSweep and repaintWithHorizontalSweep.
2889
2890 2007-11-26  Sam Weinig  <sam@webkit.org>
2891
2892         Reviewed by Dan Bernstein.
2893
2894         - Leopard build fix
2895
2896         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2897
2898 2007-11-26  Sam Weinig  <sam@webkit.org>
2899
2900         Fix for http://bugs.webkit.org/show_bug.cgi?id=16136
2901         Use shared PixelDumpSupport for Mac DRT
2902
2903         Reviewed by Adam Roben.
2904
2905         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2906         * DumpRenderTree/PixelDumpSupport.h: Copied from DumpRenderTree/win/PixelDumpSupport.h.
2907         * DumpRenderTree/cg/ImageDiffCG.cpp:
2908         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2909         (drawSelectionRectIntoContext):
2910         (dumpWebViewAsPixelsAndCompareWithExpected):
2911         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2912         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2913         * DumpRenderTree/mac/DumpRenderTree.mm:
2914         (dump):
2915         * DumpRenderTree/mac/ImageDiff.m: Removed.
2916         * DumpRenderTree/mac/PixelDumpSupport.h: Removed.
2917         * DumpRenderTree/mac/PixelDumpSupport.mm: Removed.
2918         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Copied from DumpRenderTree/mac/PixelDumpSupport.mm.
2919         (setDefaultColorProfileToRGB):
2920         (getBitmapContextFromWebView):
2921         (drawWebViewIntoContext):
2922         (repaintWithVerticalSweep):
2923         (repaintWithHorizontalSweep):
2924         (getSelectionRect):
2925         * DumpRenderTree/win/PixelDumpSupport.h: Removed.
2926
2927 2007-11-25  David D. Kilzer  <ddkilzer@webkit.org>
2928
2929         Bug 16052: prepare-ChangeLog doesn't report deleted files
2930         <http://bugs.webkit.org/show_bug.cgi?id=16052>
2931
2932         Reviewed by Sam.
2933
2934         * Scripts/prepare-ChangeLog: Fixed logic that checks for removed files.
2935
2936 2007-11-25  David Kilzer  <ddkilzer@webkit.org>
2937
2938         Bug 15864: Replace merge-changelog with resolve-ChangeLogs
2939         <http://bugs.webkit.org/show_bug.cgi?id=15864>
2940
2941         Reviewed by Adam.
2942
2943         Roll functionality of merge-changelog into resolve-ChangeLogs
2944         script.  The script now checks for ChangeLog.rej and
2945         ChangeLog.orig files first.  If it finds them, it uses the
2946         ChangeLog.rej file as a patch (in old contextual diff format) to
2947         apply with --fuzz=3.
2948
2949         * Scripts/merge-changelog: Removed.
2950         * Scripts/resolve-ChangeLogs: Handle traditional rejected patches.
2951
2952 2007-11-25  Sam Weinig  <sam@webkit.org>
2953
2954         Add .xcconfig files for the ImageDiff and TestNetscapePlugIn targets of the DumpRenderTree.
2955
2956         Reviewed by Mark Rowe.
2957
2958         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2959         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2960         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2961         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig: Added.
2962         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Added.
2963
2964 2007-11-25  Sam Weinig  <sam@webkit.org>
2965
2966         Convert DumpRenderTree to ues .xcconfig files.
2967
2968         Reviewed by Mark Rowe.
2969
2970         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2971         * DumpRenderTree/mac/Configurations: Added.
2972         * DumpRenderTree/mac/Configurations/Base.xcconfig: Added.
2973         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Added.
2974         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Added.
2975
2976 2007-11-25  Sam Weinig  <sam@webkit.org>
2977
2978         Add ForwardingHeaders to wtf for DumpRenderTree.
2979
2980         Reviewed by Mark Rowe.
2981
2982         * DumpRenderTree/DumpRenderTree.h:
2983         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2984         * DumpRenderTree/ForwardingHeaders: Added.
2985         * DumpRenderTree/ForwardingHeaders/wtf: Added.
2986         * DumpRenderTree/ForwardingHeaders/wtf/Assertions.h: Added.
2987         * DumpRenderTree/ForwardingHeaders/wtf/Noncopyable.h: Added.
2988         * DumpRenderTree/ForwardingHeaders/wtf/OwnPtr.h: Added.
2989         * DumpRenderTree/ForwardingHeaders/wtf/Platform.h: Added.
2990         * DumpRenderTree/ForwardingHeaders/wtf/RetainPtr.h: Added.
2991         * DumpRenderTree/ForwardingHeaders/wtf/StringExtras.h: Added.
2992         * DumpRenderTree/LayoutTestController.cpp:
2993         * DumpRenderTree/WorkQueue.cpp:
2994         * DumpRenderTree/mac/DumpRenderTree.mm:
2995         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2996         * DumpRenderTree/mac/JavaScriptThreading.cpp:
2997         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2998         * DumpRenderTree/mac/ObjCController.m:
2999         * DumpRenderTree/mac/UIDelegate.mm:
3000         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3001
3002 2007-11-25  Adam Roben  <aroben@apple.com>
3003
3004         Fix some test failures caused by r28019
3005
3006         Now that stdout is in binary mode, we need to always use printf
3007         instead of wprintf. Otherwise we'll end up with UTF-16 characters in
3008         the output.
3009
3010         Reviewed by Sam.
3011
3012         * DumpRenderTree/win/UIDelegate.cpp: Replaced uses of wprintf with
3013         printf.
3014         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3015         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3016         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3017         (UIDelegate::webViewAddMessageToConsole):
3018
3019 2007-11-25  Adam Roben  <aroben@apple.com>
3020
3021         Set the font smoothing preference in DRT
3022
3023         This makes the pixel results on Windows closer to the Mac results.
3024
3025         Reviewed by Mitz.
3026
3027         * DumpRenderTree/win/DumpRenderTree.cpp:
3028         (initializePreferences):
3029
3030 2007-11-25  Adam Roben  <aroben@apple.com>
3031
3032         Port ImageDiff to CG and C++
3033
3034         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133
3035         <rdar://5071708>
3036
3037         Reviewed by Sam.
3038
3039         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
3040         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
3041         (main):
3042         (createImageFromStdin):
3043         (compareImages):
3044         (getDifferenceBitmap):
3045         (computePercentageDifferent):
3046         * DumpRenderTree/win/ImageDiff.vcproj: Added.
3047
3048 2007-11-25  Adam Roben  <aroben@apple.com>
3049
3050         Fix image diff link generation on Windows
3051
3052         Reviewed by Sam.
3053
3054         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
3055         to toURL.
3056
3057 2007-11-25  Adam Roben  <aroben@apple.com>
3058
3059         Implement pixel dumping in Windows DRT
3060
3061         Part of http://bugs.webkit.org/show_bug.cgi?id=16133
3062         <rdar://5071708>
3063
3064         Reviewed by Sam.
3065
3066         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
3067         (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
3068         Content-Length header.
3069         (getMD5HashStringForBitmap):
3070         (dumpWebViewAsPixelsAndCompareWithExpected):
3071         * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
3072         * DumpRenderTree/win/DumpRenderTree.cpp:
3073         (dump): Do a pixel dump if requested.
3074         (main): Parse pixel test options.
3075         * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
3076         the cg/ subdirectory to the include path.
3077         * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
3078         available in a header or import library, so we have to go through this
3079         LoadLibrary/GetProcAddress dance to use them.
3080         (cryptDLL):
3081         (init):
3082         (update):
3083         (final):
3084         (MD5_Init):
3085         (MD5_Update):
3086         (MD5_Final):
3087         * DumpRenderTree/win/MD5.h: Added.
3088         * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
3089         moved up to the top level to share it with Mac eventually.
3090         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
3091         (getBitmapContextFromWebView): Forces the WebView to paint using a
3092         WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.
3093
3094 2007-11-25  Adam Roben  <aroben@apple.com>
3095
3096         Clean up Windows DRT's option parsing a little bit
3097
3098         Reviewed by Sam.
3099
3100         * DumpRenderTree/win/DumpRenderTree.cpp:
3101         (main): Put non-option arguments into a Vector.
3102
3103 2007-11-25  Adam Roben  <aroben@apple.com>
3104
3105         Make Windows DRT stop changing LF into CRLF
3106
3107         Reviewed by Sam.
3108
3109         * DumpRenderTree/win/DumpRenderTree.cpp:
3110         (main): Put stdout in binary mode.
3111         * Scripts/run-webkit-tests: Remove the CRLF hack.
3112
3113 2007-11-24  David Kilzer  <ddkilzer@webkit.org>
3114
3115         Removed empty directory.
3116
3117         * Scripts/resources: Removed.
3118
3119 2007-11-23  David D. Kilzer  <ddkilzer@webkit.org>
3120
3121         Fix bisect-builds to work with recent WebKit nightly builds.
3122
3123         Reviewed by Dan.
3124
3125         * Scripts/bisect-builds: Check for the 
3126         WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
3127         it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
3128         to WebKit.app/Contents/Resources.
3129
3130 2007-11-23  Alexey Proskuryakov  <ap@webkit.org>
3131
3132         Reviewed by Maciej.
3133
3134         <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
3135         not closed (affects digg.com)
3136
3137         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
3138         one after finishing with a test to avoid having its delayed onload handler firing when
3139         replaced with the next one. This is ugly and still unreliable (see LayoutTests ChangeLog),
3140         but it helps somewhat.
3141
3142 2007-11-22  Mark Rowe  <mrowe@apple.com>
3143
3144         Reviewed by Alp Toker.
3145
3146         Fix build-webkit to propagate make's exit status if it fails.
3147
3148         * Scripts/webkitdirs.pm:
3149
3150 2007-11-22  Dan Bernstein  <mitz@apple.com>
3151
3152         Reviewed by Mark Rowe.
3153
3154         - fix crash when running pixel tests
3155
3156         * DumpRenderTree/mac/DumpRenderTree.mm:
3157         (dumpRenderTree): Parse the command line options before setting up the
3158         environment so that we know if we need to set up the pixel dump
3159         machinery.
3160
3161 2007-11-21  Eric Seidel  <eric@webkit.org>
3162
3163         Speculative build fix for Tiger.
3164
3165         * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h
3166
3167 2007-11-21  Eric Seidel  <eric@webkit.org>
3168
3169         Reviewed by Tim Hatcher.
3170
3171         Break out more of DumpRenderTree.mm into individual files
3172
3173         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3174         * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
3175         (checkedMalloc):
3176         (checkedRealloc):
3177         (makeLargeMallocFailSilently):
3178         * DumpRenderTree/mac/CheckedMalloc.h: Added.
3179         * DumpRenderTree/mac/DumpRenderTree.mm:
3180         (crashHandler):
3181         (dump):
3182         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3183         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
3184         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3185         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3186         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3187         * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
3188         (javaScriptThreads):
3189         (runJavaScriptThread):
3190         (startJavaScriptThreads):
3191         (stopJavaScriptThreads):
3192         * DumpRenderTree/mac/JavaScriptThreading.h: Added.
3193         * DumpRenderTree/mac/PixelDumpSupport.h: Added.
3194         * DumpRenderTree/mac/PixelDumpSupport.mm: Added.
3195         (restoreColorSpace):
3196         (setDefaultColorProfileToRGB):
3197         (initializeColorSpaceAndScreeBufferForPixelTests):
3198         (md5HashStringForBitmap):
3199         (dumpWebViewAsPixelsAndCompareWithExpected):
3200
3201 2007-11-21  Kevin Ollivier  <kevino@theolliviers.com>
3202
3203         Move install-unix-extras to wx directory as it seems only to be used by that 
3204         port now. It now supports universal binaries on Mac and adds libpng and libjpeg. 
3205         Also, have build-wxwebkit run it in order to fix the Mac buildbot, and
3206         have install-unix-extras install into WebKitLibraries as per
3207         convention.
3208         
3209         Reviewed by Mark Rowe.
3210
3211         * Scripts/install-unix-extras: Removed.
3212         * wx/build-wxwebkit:
3213         * wx/install-unix-extras: Copied from WebKitTools/Scripts/install-unix-extras.
3214
3215 2007-11-21  Eric Seidel  <eric@webkit.org>
3216
3217         Reviewed by Adam.
3218
3219         More refactoring for greater code readability
3220
3221         * DumpRenderTree/mac/DumpRenderTree.mm:
3222         (initializeGlobalsFromCommandLineOptions):
3223         (initializeColorSpaceAndScreeBufferForPixelTests):
3224         (addTestPluginsToPluginSearchPath):
3225         (useLongRunningServerMode):
3226         (runTestingServerLoop):
3227         (prepareConsistentTestingEnvironment):
3228         (dumpRenderTree):
3229         (main):
3230         (dumpFramesAsText):
3231         (dumpBackForwardListForWebView):
3232         (sizeWebViewForCurrentTest):
3233         (methodNameStringForFailedTest):
3234         (dumpBackForwardListForAllWindows):
3235         (dumpWebViewAsPixelsAndCompareWithExpected):
3236         (invalidateAnyPreviousWaitToDumpWatchdog):
3237         (dump):
3238         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3239         * DumpRenderTree/mac/UIDelegate.mm:
3240         (-[UIDelegate webView:createWebViewWithRequest:]):
3241
3242 2007-11-21  Eric Seidel  <eric@webkit.org>
3243
3244         Reviewed by Tim Hatcher.
3245
3246         Abstract more of DRT into static methods
3247
3248         * DumpRenderTree/mac/DumpRenderTree.mm:
3249         (setDefaultsToConsistentValuesForTesting):
3250         (setupSignalHandlers):
3251         (allocateGlobalControllers):
3252         (releaseAndZero):
3253         (releaseGlobalControllers):
3254         (dumpRenderTree):
3255         (shouldLogFrameLoadDelegates):
3256         (createCFURLFromPathOrURL):
3257         (resetWebViewToConsistentStateBeforeTesting):
3258         (runTest):
3259
3260 2007-11-21  Eric Seidel  <eric@webkit.org>
3261
3262         Reviewed by Tim Hatcher.
3263
3264         Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files
3265
3266         * DumpRenderTree/DumpRenderTree.h:
3267         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3268         * DumpRenderTree/mac/DumpRenderTree.mm:
3269         (dumpRenderTree):
3270         (dump):
3271         (runTest):
3272         * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
3273         * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
3274         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
3275         (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
3276         (-[DumpRenderTreePasteboard declareType:owner:]):
3277         (+[LocalPasteboard alloc]):
3278         (-[LocalPasteboard init]):
3279         (-[LocalPasteboard dealloc]):
3280         (-[LocalPasteboard name]):
3281         (-[LocalPasteboard releaseGlobally]):
3282         (-[LocalPasteboard declareTypes:owner:]):
3283         (-[LocalPasteboard addTypes:owner:]):
3284         (-[LocalPasteboard changeCount]):
3285         (-[LocalPasteboard types]):
3286         (-[LocalPasteboard availableTypeFromArray:]):
3287         (-[LocalPasteboard setData:forType:]):
3288         (-[LocalPasteboard dataForType:]):
3289         (-[LocalPasteboard setPropertyList:forType:]):
3290         (-[LocalPasteboard setString:forType:]):
3291         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
3292         * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
3293         (+[DumpRenderTreeWindow allWindows]):
3294         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
3295         (-[DumpRenderTreeWindow dealloc]):
3296         (-[DumpRenderTreeWindow isKeyWindow]):
3297         (-[DumpRenderTreeWindow keyDown:]):
3298
3299 2007-11-20  Kevin Ollivier  <kevino@theolliviers.com>
3300
3301         wx build fix for Windows. Don't use WebCore/move-js-headers.sh as
3302         it indiscriminately copies any headers inside JavaScriptCore,
3303         which includes Tiger ICU headers. 
3304
3305         * wx/build-wxwebkit:
3306         Don't run WebCore/move-js-headers.sh any longer.
3307
3308 2007-11-20  Adam Treat  <treat@kde.org>
3309
3310         Reviewed by David Kilzer.
3311
3312         * Prepend git branch name to $baseProductDir
3313
3314         * Scripts/VCSUtils.pm:
3315         * Scripts/webkitdirs.pm:
3316
3317 2007-11-20  Mark Rowe  <mrowe@apple.com>
3318
3319         Reviewed by Simon Hausmann.
3320
3321         * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
3322         * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
3323         Have it trigger a "make distclean" rather than "make clean" to ensure that the
3324         built product and generated Makefile's are removed.
3325
3326 2007-11-19  Alp Toker  <alp@atoker.com>
3327
3328         Reviewed by Mark Rowe.
3329
3330         http://bugs.webkit.org/show_bug.cgi?id=16040
3331         [GTK] GtkLauncher should be written in C
3332
3333         Port GtkLauncher to plain C.
3334
3335         Use a more conventional GTK+ coding style.
3336
3337         Use a toolbar instead of menus.
3338
3339         Various signature fixes and cleanups.
3340
3341         Add a license header. Assume all previous modifications were copyright
3342         assigned to Apple Inc. by default.
3343
3344         * GtkLauncher/GtkLauncher.pro:
3345         * GtkLauncher/main.c: Added.
3346         (activate_url_entry_cb):
3347         (update_title):
3348         (link_hover_cb):
3349         (title_change_cb):
3350         (progress_change_cb):
3351         (destroy_cb):
3352         (go_back_cb):
3353         (go_forward_cb):
3354         (create_browser):
3355         (create_statusbar):
3356         (create_toolbar):
3357         (create_window):
3358         (main):
3359         * GtkLauncher/main.cpp: Removed.
3360
3361 2007-11-19  Kevin Ollivier  <kevino@theolliviers.com>
3362
3363         Build script fixes to ensure they do the right thing for the 
3364         wx port, and update build-wxwebkit to reflect the way the
3365         build scripts now work.
3366
3367         Reviewed by Adam.
3368
3369         * Scripts/build-testkjs:
3370         * Scripts/build-webkit:
3371         * Scripts/run-javascriptcore-tests:
3372         * Scripts/webkitdirs.pm:
3373         * wx/build-wxwebkit:
3374
3375 2007-11-18  Eric Seidel  <eric@webkit.org>
3376
3377         Reviewed by Anders.
3378
3379         Make run-javascriptcore-tests report failures on exit (to support git bisect)
3380
3381         * Scripts/run-javascriptcore-tests:
3382
3383 2007-11-18  Alexey Proskuryakov  <ap@webkit.org>
3384
3385         Reviewed by Adam Roben.
3386
3387         Make run-webkit-tests work with Windows debug build.
3388
3389         * DumpRenderTree/win/DumpRenderTree.cpp: (main): Only use memory checks with debug CRT.
3390         * DumpRenderTree/win/DumpRenderTree.vcproj: Switched Debug configuration to release CRT,
3391         as it is supposed to run with release Apple libraries. Removed _DEBUG preprocessor
3392         symbol, as it goes with debug CRT (AFAIK, it is supposed to be added automatically,
3393         and shouldn't be needed in Debug_internal configuration, but I didn't dare to change that).
3394
3395 2007-11-18  Kevin Ollivier  <kevino@theolliviers.com>
3396
3397         Add wxWebKit sample and build script, and integrate it with 
3398         build-webkit. Also make build-webkit --clean work for all
3399         ports.
3400
3401         Reviewed by Darin Adler.
3402
3403         * Scripts/build-webkit:
3404         * Scripts/webkitdirs.pm:
3405         * wx: Added.
3406         * wx/browser: Added.
3407         * wx/browser/browser.bkl: Added.
3408         * wx/browser/browser.cpp: Added.
3409         * wx/build-wxwebkit: Added.
3410
3411 2007-11-17  Adam Roben  <aroben@apple.com>
3412
3413         Make it easy to run Safari in the debugger on Windows
3414
3415         I've added a new script, debug-safari, which launches Safari in the
3416         debugger. On OS X it just calls gdb-safari.
3417
3418         Reviewed by Mark Rowe.
3419
3420         * FindSafari/FindSafari.cpp:
3421         (_tmain): Added a /debugger flag, which in combination with
3422         /printSafariLauncher will print a script that launches Safari in the
3423         debugger.
3424         * Scripts/debug-safari: Added.
3425         * Scripts/run-safari: Changed to call runSafari().
3426         * Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
3427         vsvars32.bat, which will let us find VS/VC++ Express, and passes the
3428         first argument along to FindSafari.
3429         * Scripts/webkitdirs.pm:
3430         (sub runSafari): Added.
3431
3432 2007-11-16  Alexey Proskuryakov  <ap@webkit.org>
3433
3434         Reviewed by Adam Roben.
3435
3436         * Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined. 
3437
3438 2007-11-16  Ryan Leavengood  <leavengood@gmail.com>
3439
3440         Reviewed by David Kilzer.
3441
3442         The git config command was renamed to repo-config at some point. This
3443         change tries git config and then git repo-config if the first fails.
3444
3445         * Scripts/prepare-ChangeLog:
3446         (gitConfig):
3447
3448 2007-11-16  Dan Bernstein  <mitz@apple.com>
3449
3450         Reviewed by Darin Adler and Sam Weinig.
3451
3452         - fix <rdar://problem/5134075> fast/forms/select-type-ahead-non-latin.html fails on Windows
3453
3454         * DumpRenderTree/win/EventSender.cpp:
3455         (keyDownCallback): For characters that cannot be entered on the active
3456         keyboard layout, send a WM_CHAR message with the character along with
3457         a WM_KEYDOWN message with a virtual key code of 255.
3458
3459 2007-11-16  Mark Rowe  <mrowe@apple.com>
3460
3461         Reviewed by Tim Hatcher.
3462
3463         Don't weak link against WebCore now that it is a sub-framework of WebKit in all configurations.
3464
3465         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3466         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3467
3468 2007-11-15  Adam Roben  <aroben@apple.com>
3469
3470         Make run-safari actually work on Windows
3471
3472         * Scripts/run-safari: Fixed the order of arguments to cp, and added a
3473         chdir call.
3474
3475 2007-11-14  Adam Roben  <aroben@apple.com>
3476
3477         Updates to Safari launching now that 3.0.4 is released
3478
3479         Reviewed by Sam.
3480
3481         * FindSafari/FindSafari.cpp:
3482         (getWebViewCLSID): Use version-independent ProgID.
3483         * Scripts/run-safari: Use run-webkit-nightly.cmd.
3484
3485 2007-11-14  Anders Carlsson  <andersca@apple.com>
3486
3487         Reviewed by Adam.
3488
3489         <rdar://problem/5309081>
3490         In DRT, "plugin.logDestroy = true" not working on Windows.
3491         
3492         * DumpRenderTree/win/TestNetscapePlugin/main.c:
3493         (NPP_Destroy):
3494
3495 2007-11-14  Eric Seidel  <eric@webkit.org>
3496
3497         Reviewed by Sam.
3498
3499         * Scripts/run-sunspider: add --shark-cache for L2 Cache Miss profiling
3500
3501 2007-11-14  Anders Carlsson  <andersca@apple.com>
3502
3503         Reviewed by Adam.
3504
3505         <rdar://problem/5141186>
3506         window.layoutTestController.setWindowIsKey is not implemented in DRT.
3507         
3508         Implement setWindowIsKey.
3509         
3510         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3511         (LayoutTestController::setWindowIsKey):
3512
3513 2007-11-13  Sam Weinig  <sam@webkit.org>
3514
3515         Reviewed by Adam Roben.
3516
3517         Fix for <rdar://problem/5382579>
3518         http/tests/security/cross-frame-access-put.html reports large 
3519         negative numbers for screenLeft and screenTop (Mac reports "0")
3520
3521         * DumpRenderTree/win/UIDelegate.cpp:
3522         (UIDelegate::UIDelegate): Initialize the RECT.
3523         (UIDelegate::setFrame): copy the contents of the rect, not the pointer.
3524         (UIDelegate::webViewFrame): ditto.
3525         * DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
3526
3527 2007-11-13  Kevin McCullough  <kmccullough@apple.com>
3528
3529         Reviewed by Adam.
3530
3531         - Make Drosera show source, source URLs, and function stack on Windows,
3532         and some minor fixes.
3533
3534         * Drosera/DebuggerDocument.cpp: Force source to always update display.
3535         (DebuggerDocument::updateFileSource):
3536         * Drosera/debugger.js: Force source to always update display.
3537         * Drosera/win/DebuggerClient.cpp: Create the needed functions for the
3538         menu controls.
3539         (DebuggerClient::resume):
3540         (DebuggerClient::pause):
3541         (DebuggerClient::stepInto):
3542         (DebuggerClient::stepOver):
3543         (DebuggerClient::stepOut):
3544         (DebuggerClient::showConsole):
3545         (DebuggerClient::closeCurrentFile):
3546         * Drosera/win/DebuggerClient.h: Ditto.
3547         * Drosera/win/DebuggerDocumentPlatform.cpp: Changed
3548         getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
3549         removed two bugs.  1) caller could be in a bad state when asked to
3550         assign into it. 2) BSTRs were not created correctly.
3551         (DebuggerDocument::getPlatformCurrentFunctionStack):
3552         * Drosera/win/Drosera.cpp: Hook up the menu controls.
3553         (droseraWndProc):
3554         (handleCommand):
3555         (Drosera::resume):
3556         (Drosera::pause):
3557         (Drosera::stepInto):
3558         (Drosera::stepOver):
3559         (Drosera::stepOut):
3560         (Drosera::showConsole):
3561         (Drosera::closeCurrentFile):
3562         * Drosera/win/Drosera.h: Hook up the menu controls.
3563         * Drosera/win/ServerConnection.cpp: Removed unncessary server connection
3564         functions, added a null check, and fixed another bug where caller could
3565         be in a bad state when asked to assign into it.
3566         (ServerConnection::didLoadMainResourceForDataSource):
3567         (ServerConnection::getCallerFrame):
3568         * Drosera/win/ServerConnection.h: Safety first.
3569
3570 2007-11-13  Dan Bernstein  <mitz@apple.com>
3571
3572         Reviewed by Darin Adler.
3573
3574         - fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
3575           DumpRenderTree --pixel-tests renders each test twice
3576
3577         * DumpRenderTree/mac/DumpRenderTree.mm:
3578         (dumpRenderTree): Removed the --paint option because the painting code
3579         is always exercised as a result of
3580         -[FrameLoadDelegate webView:didFinishLoadFromFrame:]
3581         calling -displayIfNeeded.
3582         (dump): Changed to always grab the image from the window since the view
3583         is always displayed.
3584         (runTest):
3585         (displayWebView):
3586         * Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
3587         because it always paints.
3588
3589 2007-11-12  Antti Koivisto  <antti@apple.com>
3590
3591         Reviewed by Adele.
3592         
3593         Add support for http media tests
3594
3595         * Scripts/run-webkit-tests:
3596
3597 2007-11-12  Sam Weinig  <sam@webkit.org>
3598
3599         Reviewed by Adam Roben.
3600
3601         Implement LayoutTestController.setPrivateBrowsingEnabled(bool) for windows.
3602
3603         * DumpRenderTree/win/DumpRenderTree.cpp:
3604         (runTest):
3605         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3606         (LayoutTestController::setPrivateBrowsingEnabled):
3607
3608 2007-11-12  Adam Roben  <aroben@apple.com>
3609
3610         * Scripts/update-webkit-localizable-strings: Changed to only scan the
3611         mac and win subdirectories.
3612
3613 2007-11-11  Adam Roben  <aroben@apple.com>
3614
3615         Fix <rdar://5133816> keepWebHistory is not implemented
3616
3617         Fixes fast/history/clicked-link-is-visited.html.
3618
3619         Reviewed by Darin.
3620
3621         * DumpRenderTree/win/DumpRenderTree.cpp:
3622         (runTest): Clear the optionalSharedHistory.
3623         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3624         (LayoutTestController::keepWebHistory): Set the optionalSharedHistory.
3625
3626 2007-11-10  Sam Weinig  <sam@webkit.org>
3627
3628         Reviewed by Tim Hatcher.
3629
3630         Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
3631         attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
3632         is turned on)
3633
3634         - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
3635
3636         Added test: http/tests/security/cross-frame-access-private-browsing.html
3637
3638         * DumpRenderTree/LayoutTestController.cpp:
3639         (setPrivateBrowsingEnabledCallback):
3640         (LayoutTestController::staticFunctions):
3641         * DumpRenderTree/LayoutTestController.h:
3642         * DumpRenderTree/mac/DumpRenderTree.mm:
3643         (runTest): Default to private browsing disabled.
3644         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3645         (LayoutTestController::setPrivateBrowsingEnabled):
3646         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3647         (LayoutTestController::setPrivateBrowsingEnabled):
3648
3649 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
3650
3651         Reviewed by Adam.
3652
3653         - Changed the vcproj file to use Drosera's ForwardingHeaders and not
3654         WebCore's!
3655
3656         * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
3657         * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
3658         * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
3659         * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
3660         * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
3661         * Drosera/win/Drosera.cpp:
3662         * Drosera/win/Drosera.vcproj/Drosera.vcproj:
3663
3664 2007-11-08  Kevin McCullough  <kmccullough@apple.com>
3665
3666         Reviewed by Sam.
3667
3668         - Use the new IWebFrame [local] function signature and get the shared
3669         server correctly.
3670
3671         * Drosera/win/DebuggerClient.cpp:
3672         (DebuggerClient::didFinishLoadForFrame):
3673         * Drosera/win/ServerConnection.cpp:
3674         (ServerConnection::attemptToCreateServerConnection):
3675
3676 2007-11-07  Dan Bernstein  <mitz@apple.com>
3677
3678         Reviewed by Darin Adler.
3679
3680         - add an option to run-webkit-tests to ignore pixel test failures where
3681           all pixels differ by no more than a specified threshold
3682
3683         * DumpRenderTree/mac/ImageDiff.m:
3684         (main):
3685         (compareImages):
3686         (computePercentageDifferent):
3687         * Scripts/run-webkit-tests:
3688
3689 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3690
3691         Reviewed by Lars.
3692
3693         Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
3694
3695         * DumpRenderTree/qt/DumpRenderTree.cpp:
3696
3697 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3698
3699         Reviewed by Lars.
3700
3701         Reworked the QWebSettings API.
3702         QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
3703
3704         * DumpRenderTree/qt/DumpRenderTree.cpp:
3705
3706 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3707
3708         Reviewed by Lars.
3709
3710         Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
3711
3712         * DumpRenderTree/qt/jsobjects.cpp:
3713
3714 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3715
3716         Reviewed by Lars Knoll <lars@trolltech.com>.
3717
3718         Add a QWebPage::frameCreated() signal and fix DRT
3719         
3720         The removal of createFrame in QWebPage broke the re-implementation
3721         in DumpRenderTree. Instead emit a frameCreated() signal and
3722         connect to it in DumpRenderTree.
3723         
3724
3725         * DumpRenderTree/qt/DumpRenderTree.cpp:
3726         (WebCore::WebPage::WebPage):
3727         (WebCore::DumpRenderTree::dump):
3728         (WebCore::DumpRenderTree::connectFrame):
3729         * DumpRenderTree/qt/DumpRenderTree.h:
3730
3731 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3732
3733         Reviewed by Lars Knoll <lars@trolltech.com>.
3734
3735         Moved all the event handlers from QWebFrame into QWebPage.
3736         
3737         This cleans up the public API and allows us to remove the
3738         HackWebFrame hack in DumpRenderTree.
3739         
3740
3741         * DumpRenderTree/qt/jsobjects.cpp:
3742         (EventSender::mouseDown):
3743         (EventSender::mouseUp):
3744         (EventSender::mouseMoveTo):
3745
3746 2007-11-07  Simon Hausmann  <hausmann@kde.org>
3747
3748         Reviewed by Mark.
3749
3750         Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
3751         to prevent the default implementation from popping up messageboxes.
3752
3753         * DumpRenderTree/qt/DumpRenderTree.cpp:
3754         (WebCore::WebPage::javaScriptConfirm):
3755         (WebCore::WebPage::javaScriptPrompt):
3756
3757 2007-11-06  Eric Seidel  <eric@webkit.org>
3758
3759         * Scripts/build-testkjs: build fix... too many $$
3760
3761 2007-11-06  Eric Seidel  <eric@webkit.org>
3762
3763         Reviewed by Mark Rowe.
3764
3765         * Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
3766
3767 2007-11-05  Adam Roben  <aroben@apple.com>
3768
3769         Add support on Windows for WEBKIT_TESTFONTS
3770
3771         This environment variable lets you specify where the fonts to be used
3772         by DumpRenderTree reside. The Qt port is already using this, so I'm
3773         just following their lead.
3774
3775         Reviewed by Darin.
3776
3777         * DumpRenderTree/win/DumpRenderTree.cpp:
3778         (exePath): Refactored code out of initialize().
3779         (fontsPath): Returns either $WEBKIT_TESTFONTS or
3780         DumpRenderTree.resources.
3781         (initialize): Use the new fontsPath function.
3782         (main): Use the new exePath function.
3783         * Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment
3784         variable to DRT, like Qt does.
3785
3786 2007-11-05  Mark Rowe  <mrowe@apple.com>
3787
3788         Rubber-stamped by Alp Toker.
3789
3790         Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
3791
3792         * GtkLauncher/main.cpp:
3793         (goToURLBarText):
3794         (main):
3795
3796 2007-11-04  David D. Kilzer  <ddkilzer@webkit.org>
3797
3798         bisect-builds doesn't work with nightly build r19992 or newer on Leopard
3799         <http://bugs.webkit.org/show_bug.cgi?id=15830>
3800
3801         Reviewed by Timothy.
3802
3803         Restrict the range of nightly builds used by the bisect-builds script
3804         based on the version of Safari and the version of Mac OS X being used.
3805
3806         Mac OS X 10.4: Safari 2.0: r11976 or newer
3807         Mac OS X 10.4: Safari 3.0: r19992 or newer
3808
3809         Mac OS X 10.5: Safari 2.0: r19594 or newer
3810         Mac OS X 10.5: Safari 3.0: r25124 or newer
3811
3812         * Scripts/bisect-builds:
3813         (findMacOSXVersion): Added.
3814         (makeNightlyList): Added argument to provide version of Mac OS X.
3815         Restrict range of nightly builds based on Safari and Mac OS X versions.
3816
3817 2007-11-04  Kevin McCullough  <kmccullough@apple.com>
3818
3819         Reviewed by Maciej.
3820
3821         - This patch involves several changes, all of them were noticed that
3822         they were needed by the work being done in WebKit to get Drosera and
3823         WebKit working together on Windows.
3824         - The changes are:
3825         1) Added a debugger console for output messages.
3826         2) Drosera now listens for the WebKit server (before, the server would
3827         have to be running before Drosera was started.)
3828         3) Fixed a bug where the WebView started out as 0x0 pixels.
3829         4) Fixed a bug when there is no scope.
3830         5) Added the HTML, JS, and CSS to the project file to make them easy to
3831         find.
3832         6) Made the ServerConnection functions virtual.
3833
3834         * Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens
3835         for the WebKit server.
3836         (DebuggerClient::DebuggerClient):
3837         (DebuggerClient::~DebuggerClient):
3838         (DebuggerClient::didFinishLoadForFrame):
3839         (DebuggerClient::serverConnected):
3840         (DebuggerClient::attemptToCreateServerConnection):
3841         * Drosera/win/DebuggerClient.h: Ditto.
3842         * Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no
3843         scope.
3844         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
3845         (DebuggerDocument::platformValueForScopeVariableNamed):
3846         * Drosera/win/Drosera.cpp:
3847         (_tWinMain): Added a console in debug for output messages.
3848         (Drosera::Drosera): Listen for server.
3849         (Drosera::initUI): The server now Initializes COM.
3850         (Drosera::serverConnected): Part of the listening for the server.
3851         (Drosera::attemptToCreateServerConnection): Ditto.
3852         * Drosera/win/Drosera.h: New interface for listening for the server.
3853         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS
3854         files to the VS project.
3855         * Drosera/win/ServerConnection.cpp: Part of listening for the server
3856         connection.
3857         (ServerConnection::ServerConnection):
3858         (ServerConnection::attemptToCreateServerConnection):
3859         * Drosera/win/ServerConnection.h: Ditto and virtualized the Interface
3860         methods.
3861         (ServerConnection::serverConnected):
3862
3863 2007-11-04  Alexey Proskuryakov  <ap@webkit.org>
3864
3865         Reviewed by Maciej.
3866
3867         http://bugs.webkit.org/show_bug.cgi?id=15832
3868         fast/dom/gc-10.html crashes when run alone
3869
3870         Check for !done before using objects that can be already deallocated.
3871
3872         * DumpRenderTree/mac/EditingDelegate.mm:
3873         (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
3874         (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
3875         (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
3876         (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
3877         (-[EditingDelegate webView:shouldDeleteDOMRange:]):
3878         (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
3879         (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
3880         (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
3881         (-[EditingDelegate webViewDidBeginEditing:]):
3882         (-[EditingDelegate webViewDidChange:]):
3883         (-[EditingDelegate webViewDidEndEditing:]):
3884         (-[EditingDelegate webViewDidChangeTypingStyle:]):
3885         (-[EditingDelegate webViewDidChangeSelection:]):
3886         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3887         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
3888         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
3889         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3890         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]):
3891         (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]):
3892         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3893         (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):
3894         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
3895         (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]):
3896         (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]):
3897         (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]):
3898         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
3899         (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]):
3900         (-[FrameLoadDelegate webView:willCloseFrame:]):
3901         (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]):
3902         (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
3903         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3904         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3905         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3906         (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]):
3907         (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3908         (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3909         (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
3910
3911 2007-11-04  Mark Rowe  <mrowe@apple.com>
3912
3913         Build fix.  Don't use Carbon.h as the prefix header as it triggers
3914         warnings that would otherwise be suppressed due to it being a system header.
3915
3916         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3917
3918 2007-11-03  Maciej Stachowiak  <mjs@apple.com>
3919
3920         Rubber stamped by Adam.
3921         
3922         - Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
3923
3924         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3925
3926 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3927
3928         Sort files(...); sections of Xcode project files.
3929
3930         Rubber-stamped by Darin.
3931
3932         * DrawTest/DrawTest.xcodeproj/project.pbxproj:
3933         * Drosera/mac/Drosera.xcodeproj/project.pbxproj:
3934         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3935         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3936
3937 2007-11-03  David D. Kilzer  <ddkilzer@webkit.org>
3938
3939         Script to sort "files(...);" sections in Xcode project.pbxproj files.
3940
3941         Reviewed by Darin.
3942
3943         * Scripts/sort-Xcode-project-file: Added.
3944
3945 2007-11-02  Darin Adler  <darin@apple.com>
3946
3947         * Scripts/run-sunspider: Changed "--base" to "--set-baseline".
3948
3949 2007-11-02  Darin Adler  <darin@apple.com>
3950
3951         Reviewed by Maciej.
3952
3953         * Scripts/run-sunspider: Pass the "--base" option through.
3954
3955         * Scripts/sunspider-compare-results: Don't check the number of parameters; let
3956         the real script do that. Default configuration to Release to match run-sunspider
3957         so we don't end up building Debug just to compare results.
3958
3959 2007-11-01  Adam Roben  <aroben@apple.com>
3960
3961         Make changes in WebKit/win show up under "WebKit/win:" instead of just "win:"
3962
3963         Reviewed by Sam.
3964
3965         * Scripts/commit-log-editor: Show all the directories beneath the
3966         source root, instead of just the last one.
3967
3968 2007-11-01  Kevin Ollivier  <kevino@theolliviers.com>
3969
3970         Reviewed by Adam Roben.
3971
3972         Print out an error message when the Windows build fails
3973         and provide guidance on how to find out what went wrong.
3974
3975         * Scripts/build-webkit:
3976         * Scripts/webkitdirs.pm:
3977
3978 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
3979
3980         Rubber-stamped by Adam Roben.
3981
3982         Rolled out r27326 - debug CRT seems to cause no problems after all.
3983
3984         * DumpRenderTree/win/DumpRenderTree.vcproj:
3985
3986 2007-10-31  Adam Roben  <aroben@apple.com>
3987
3988         Switch the Debug configuration to using the non-debug CRT
3989
3990         This matches WebKit.
3991
3992         Reviewed by Steve.
3993
3994         * DumpRenderTree/win/DumpRenderTree.vcproj:
3995
3996 2007-10-31  Antti Koivisto  <antti@apple.com>
3997
3998         Reviewed by bdash.
3999         
4000         Disable media tests when doing leak checking on Tiger.
4001         They crash in QuickTime (rdar://problem/5537157).
4002
4003         * Scripts/run-webkit-tests:
4004
4005 2007-10-29  Antti Koivisto  <antti@apple.com>
4006
4007         Reviewed by Maciej.
4008         
4009         Build media support by default on OSX only.
4010
4011         * Scripts/build-webkit:
4012
4013 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
4014
4015         - Made Adam the reviewer for a previous checkin. Not sure how it didn't
4016         get caught by the pre-commit hooks.
4017
4018 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
4019
4020         Reviewed by Adam.
4021
4022         - This is a collection of relatively unrelated changes and cleanups
4023         to Drosera to prepare it for interacting with WebKit.  A lot of these
4024         changes are just correcting mistakes, for example removing included
4025         headers that are no longer needed.
4026
4027         * Drosera/DebuggerDocument.h: Added accessor for the ServerConnection
4028         this will be needed by the DebuggerClient.
4029         (DebuggerDocument::server):
4030         * Drosera/win/BaseDelegate.h: Removed unnecessary include.
4031         * Drosera/win/DebuggerClient.cpp: 
4032         (DebuggerClient::didFinishLoadForFrame): Finished implementing.
4033         (DebuggerClient::didReceiveTitle): Added comment about its purpose.
4034         (DebuggerClient::createWebViewWithRequest): Added comment about its
4035         purpose. 
4036         * Drosera/win/DebuggerClient.h: Removed unnecessary include, and forward
4037         declarations.
4038         (DebuggerClient::webViewLoaded): Moved.
4039         * Drosera/win/Drosera.cpp: Moved a function from the HelperFunctions
4040         file, since this was the only place it was used.
4041         (cfStringToBSTR):
4042         * Drosera/win/Drosera.h: Cleaned up the includes.
4043         * Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed HelperFunctions.h
4044         * Drosera/win/HelperFunctions.h: Removed.
4045
4046 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
4047
4048         Reviewed by Adam.
4049
4050         - Small cleanup in the ServerConnection class.
4051
4052         * Drosera/win/ServerConnection.cpp: Added comments, moved some functions
4053         and added an include.
4054         (ServerConnection::currentFrame):
4055         (ServerConnection::getCallerFrame):
4056         * Drosera/win/ServerConnection.h: Added comments, moved some functions,
4057         made a pointer into a COMPtr, and cleaned up the includes.
4058
4059 2007-10-29  Timothy Hatcher  <timothy@apple.com>
4060
4061         Reviewed by John Sullivan.
4062         
4063         - Place the Localizable.strings file in mac or win directories
4064           if that location exists.
4065         - Also look for UI_STRING in .c files.
4066
4067         * Scripts/extract-localizable-strings:
4068
4069 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
4070
4071         Reviewed by Adam.
4072
4073         - Set the eol-style to native and made all the line endings the same
4074         so that I avoid messy diffs that show eol changes.
4075
4076         * Drosera/win/ServerConnection.cpp:
4077         (ServerConnection::didParseSource):
4078         (ServerConnection::didEnterCallFrame):
4079         (ServerConnection::willExecuteStatement):
4080         (ServerConnection::willLeaveCallFrame):
4081         (ServerConnection::exceptionWasRaised):
4082
4083 2007-10-30  Kevin McCullough  <kmccullough@apple.com>
4084
4085         Reviewed by Adam.
4086
4087         * Drosera/win/DebuggerDocumentPlatform.cpp:Implemented much of the
4088         functionality that could not have existed previously without the new
4089         interfaces.
4090         (JSValueRefCreateWithBSTR): Added a helper function to easily convert
4091         from a BSTR to a JSValueRef.
4092         (DebuggerDocument::platformEvaluateScript): Implemented.
4093         (DebuggerDocument::getPlatformCurrentFunctionStack): Implemented.
4094         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
4095         Implemented.
4096         (DebuggerDocument::platformValueForScopeVariableNamed): Implemented.
4097         * Drosera/win/HelperFunctions.h: Cleaned up some comments.
4098         * Drosera/win/ServerConnection.cpp: Added a helper function.
4099         (ServerConnection::getCallerFrame):
4100         * Drosera/win/ServerConnection.h: Added a helper function.
4101
4102 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
4103
4104         updated reviewers for my previous changelog.
4105
4106 2007-10-29  Kevin McCullough  <kmccullough@apple.com>
4107         Reviewed by Maciej and Adam and Geoff.
4108
4109         - Minor mac-side improvements including moving a function to a more
4110         appropriate location, fixing a warning, and correctly checking
4111         exceptions.
4112
4113         * Drosera/DebuggerDocument.cpp: Corrected the exception checking.
4114         (DebuggerDocument::willExecuteStatement):
4115         (DebuggerDocument::didEnterCallFrame):
4116         (DebuggerDocument::willLeaveCallFrame):
4117         (DebuggerDocument::windowScriptObjectAvailable):
4118         (DebuggerDocument::callFunctionOnObject):
4119         * Drosera/mac/DebuggerClient.mm: Fixes a warning.
4120         * Drosera/mac/DebuggerDocumentPlatform.mm: Moved
4121         webScriptAttributeKeysForScriptObject to DebuggerDocumentPlatform
4122         because it doesn't require the ServerConnection at all.
4123         (NSStringCreateWithJSStringRef): Made an argument const.
4124         (JSValueRefCreateWithNSString): Made an argument const.
4125         (+[WebScriptObject webScriptAttributeKeysForScriptObject:]):
4126         (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame):
4127         * Drosera/mac/ServerConnection.h: Moved aforementioned function.
4128         * Drosera/mac/ServerConnection.mm: Ditto.
4129         (-[ServerConnection webView:didLoadMainResourceForDataSource:]):
4130
4131 2007-10-29  Sam Weinig  <sam@webkit.org>
4132
4133         Reviewed by Adam Roben.
4134
4135         Add a globalFlag property to the LayoutTestController to allow cross-domain indications.
4136
4137         * DumpRenderTree/LayoutTestController.cpp:
4138         (LayoutTestController::LayoutTestController):
4139         (getGlobalFlagCallback):
4140         (setGlobalFlagCallback):
4141         (LayoutTestController::getJSClass):
4142         (LayoutTestController::staticValues):
4143         * DumpRenderTree/LayoutTestController.h:
4144         (LayoutTestController::globalFlag):
4145         (LayoutTestController::setGlobalFlag):
4146
4147 2007-10-29  Darin Adler  <darin@apple.com>
4148
4149         Reviewed by Maciej.
4150
4151         * Scripts/run-sunspider: Added --shark20 option, to run Shark at its highest sample
4152         resolution instead of its default.
4153
4154 2007-10-29  David Kilzer  <ddkilzer@webkit.org>
4155
4156         Fixed showStatus() to print status for successfully resolved conflicts when using git.
4157
4158         Reviewed by Mark Rowe.
4159
4160         Previously showStatus() would run "git diff --name-status" after a ChangeLog conflict
4161         was successfully resolved, but this would not show any status because the change had
4162         already been cached in the index using "git add".  The solution is to add an optional
4163         second argument to showStatus() which adds the "--cached" switch to the command.
4164
4165         * Scripts/resolve-ChangeLogs:
4166         (showStatus):
4167
4168 2007-10-28  Eric Seidel  <eric@webkit.org>
4169
4170         Reviewed by Maciej and Geoff, in unison.
4171
4172         * Scripts/run-webkit-tests: remove broken --svg option
4173
4174 2007-10-28  Darin Adler  <darin@apple.com>
4175
4176         Reviewed by Adam.
4177
4178         * Scripts/run-sunspider: Default to "Release" configuration rather than
4179         defaulting to the last configuration used as other scripts do. This can
4180         still be overriden on the command line with "--debug" if there's some
4181         reason to do so. Also fix a typo.
4182
4183         * Scripts/sunspider-compare-results: Fix a typo.
4184
4185 2007-10-26  Kevin McCullough  <kmccullough@apple.com>
4186
4187         Reviewed by Adam.
4188
4189         - Implemented the WebScriptDebugListener functions now that the
4190         WebScriptDebugServer exists
4191
4192         * Drosera/win/ServerConnection.cpp: Implemented WebScriptDebugListener
4193         functions.
4194         (ServerConnection::currentFrame):
4195         (ServerConnection::didLoadMainResourceForDataSource):
4196         (ServerConnection::didParseSource):
4197         (ServerConnection::failedToParseSource):
4198         (ServerConnection::didEnterCallFrame):
4199         (ServerConnection::willExecuteStatement):
4200         (ServerConnection::willLeaveCallFrame):
4201         (ServerConnection::exceptionWasRaised):
4202         * Drosera/win/ServerConnection.h: Removed unused arguments from the
4203         members arguments list.
4204
4205 2007-10-26  David Kilzer  <ddkilzer@webkit.org>
4206
4207         prepare-ChangeLog and update-webkit create needless ChangeLog conflicts
4208         <http://bugs.webkit.org/show_bug.cgi?id=15600>
4209
4210         Reviewed by Darin.
4211
4212         The resolve-ChangeLog script merges conflicted ChangeLogs in svn or git by creating
4213         a patch of the local changes and applying it with a fuzz level of 3 to the new file.
4214         If the patch is successful, it runs 'svn resolved' or 'git add' on the new ChangeLog
4215         file.  Note that it may also be used as a stand-alone script.
4216
4217         * Scripts/prepare-ChangeLog: Call resolve-ChangeLogs for conflicted ChangeLog files.
4218         * Scripts/resolve-ChangeLogs: Added.
4219         * Scripts/update-webkit: Call resolve-ChangeLogs for conflicted ChangeLog files.
4220
4221 2007-10-26  Mark Rowe  <mrowe@apple.com>
4222
4223         Qt build fix.  r27084 added a destructor implementation for LayoutTestController
4224         to the Qt port on the assumption that it was an implementation of the cross-platform
4225         LayoutTestController class.  It is not, so it did not need to be changed.
4226
4227         * DumpRenderTree/qt/jsobjects.cpp: Remove empty destructor.
4228
4229 2007-10-25  Mark Rowe  <mrowe@apple.com>
4230
4231         Reviewed by Maciej.
4232
4233         Fix builds with code coverage enabled.
4234
4235         * Scripts/build-webkit: Don't overwrite the existing value of OTHER_LDFLAGS.
4236
4237 2007-10-25  Darin Adler  <darin@apple.com>
4238
4239         Reviewed by Mark Rowe.
4240
4241         * Scripts/make-js-test-wrappers: Don't generate a wrapper for intersectsNode.js.
4242         * Scripts/prepare-ChangeLog: Add a special case for prefix of empty string.
4243
4244 2007-10-25  Stephanie  <slewis@apple.com>
4245
4246         build Fix
4247
4248         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4249
4250 2007-10-25  Stephanie  <slewis@apple.com>
4251
4252         Reviewed by Mark Rowe, Adam Roben.
4253
4254         Weak link against WebCore so DumpRenderTree can be bundled with production roots.
4255
4256         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: 
4257
4258 2007-10-25  Alice Liu  <alice.liu@apple.com>
4259
4260         Reviewed by Adam.
4261
4262         Fixed <rdar://5549689> 2 tests in fast/forms fail when run with other tests on Windows
4263
4264         Moving destructor into platform-specific files
4265         * DumpRenderTree/LayoutTestController.cpp:
4266         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4267         (LayoutTestController::~LayoutTestController):
4268         * DumpRenderTree/qt/jsobjects.cpp:
4269         (LayoutTestController::~LayoutTestController):
4270
4271         LayoutTestController wasn't being destroyed
4272         * DumpRenderTree/win/DumpRenderTree.cpp:
4273         (runTest):
4274
4275         Added declspec
4276         * DumpRenderTree/win/EditingDelegate.h:
4277
4278         Reset certain values on the webview (or related delegate) that might 
4279         have changed while running a test
4280         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4281         (LayoutTestController::~LayoutTestController):
4282
4283 2007-10-25  Adam Roben  <aroben@apple.com>
4284
4285         Make sunspider-compare-results work with relative paths
4286
4287         Reviewed by Sam.
4288
4289         * Scripts/sunspider-compare-results: Convert arguments to absolute
4290         paths before we chdir.
4291
4292 2007-10-25  Kevin McCullough  <kmccullough@apple.com>
4293
4294         Reviewed by Sam.
4295
4296         - Implemented server calls now the WebScriptDebugServer exists.
4297         - Also removed no longer needed call to initialize CG.
4298
4299         * Drosera/win/Drosera.cpp: No longer initializes CG because this happens
4300         automatically now.
4301         (_tWinMain):
4302         * Drosera/win/ServerConnection.cpp: Now uses the COM class.
4303         (ServerConnection::ServerConnection):
4304         (ServerConnection::~ServerConnection):
4305         (ServerConnection::pause):
4306         (ServerConnection::resume):
4307         (ServerConnection::stepInto):
4308         (ServerConnection::applicationTerminating):
4309         (ServerConnection::serverConnectionDidDie):
4310         * Drosera/win/ServerConnection.h: Now uses the COM class.
4311
4312 2007-10-24  George Staikos  <staikos@kde.org>
4313
4314         Unbreak Qt build.
4315
4316         * Scripts/build-webkit:
4317
4318 2007-10-24  Adam Roben  <aroben@apple.com>
4319
4320         Remove now-unnecessary call to InitializeCoreGraphics
4321
4322         WebKit takes care of this now.
4323
4324         Reviewed by Ada.<