WebKitTools/ChangeLog

   1 2009-11-28  Adam Barth  <abarth@webkit.org>
   2
   3         Reviewed by Eric Seidel.
   4
   5         [bzt] style-queue shouldn't reject patches from the commit-queue
   6         https://bugs.webkit.org/show_bug.cgi?id=31944
   7
   8         Currently the style-queue subprocess gets confused and thinks its the
   9         commit-queue.  If the patch has an error, it rejects it from the
  10         commit-queue.  Instead, we should have style-queue specific logic.
  11         This patch doesn't add that logic, but it gives us a callback we can
  12         use to add that logic.
  13
  14         * Scripts/modules/buildsteps.py:
  15         * Scripts/modules/commands/queues.py:
  16         * Scripts/modules/landingsequence.py:
  17
  18 2009-11-27  Adam Barth  <abarth@webkit.org>
  19
  20         Rubber stamped by Eric Seidel.
  21
  22         Rename CommitQueueStatus to QueueStatusServer to allow for more queues.
  23
  24         * CommitQueueStatus: Removed.
  25         * CommitQueueStatus/app.yaml: Removed.
  26         * CommitQueueStatus/filters: Removed.
  27         * CommitQueueStatus/filters/__init__.py: Removed.
  28         * CommitQueueStatus/filters/webkit_extras.py: Removed.
  29         * CommitQueueStatus/index.html: Removed.
  30         * CommitQueueStatus/index.yaml: Removed.
  31         * CommitQueueStatus/queue_status.py: Removed.
  32         * CommitQueueStatus/stylesheets: Removed.
  33         * CommitQueueStatus/stylesheets/main.css: Removed.
  34         * CommitQueueStatus/update_status.html: Removed.
  35         * QueueStatusServer: Copied from WebKitTools/CommitQueueStatus.
  36
  37 2009-11-27  Adam Barth  <abarth@webkit.org>
  38
  39         Reviewed by Eric Seidel.
  40
  41         style-queue should only process each patch once
  42         https://bugs.webkit.org/show_bug.cgi?id=31939
  43
  44         Actually address reviewer comments!
  45
  46         * Scripts/bugzilla-tool:
  47
  48 2009-11-27  Adam Barth  <abarth@webkit.org>
  49
  50         Reviewed by Eric Seidel.
  51
  52         [bzt] style-queue fails to apply a bunch of patches for no reason
  53         https://bugs.webkit.org/show_bug.cgi?id=31942
  54
  55         By passing --non-interactive to check-style, we convince check-style
  56         to pass --force to svn-apply, which lets it apply more patches.
  57
  58         * Scripts/modules/commands/queues.py:
  59
  60 2009-11-27  Adam Barth  <abarth@webkit.org>
  61
  62         Reviewed by Eric Seidel.
  63
  64         [bzt] Support --status-host in style-queue
  65         https://bugs.webkit.org/show_bug.cgi?id=31941
  66
  67         * Scripts/modules/commands/queues.py:
  68         * Scripts/modules/statusbot.py:
  69
  70 2009-11-27  Adam Barth  <abarth@webkit.org>
  71
  72         Reviewed by Eric Seidel.
  73
  74         style-queue should only process each patch once
  75         https://bugs.webkit.org/show_bug.cgi?id=31939
  76
  77         Before processing a patch, the try-queues now ask the web service
  78         whether they have already processed the patch.  This is an initial cut
  79         of this functionality.  I expect we're make it richer over time.
  80
  81         * Scripts/bugzilla-tool:
  82         * Scripts/modules/commands/queues.py:
  83         * Scripts/modules/patchcollection.py:
  84
  85 2009-11-27  Adam Barth  <abarth@webkit.org>
  86
  87         Reviewed by Eric Seidel.
  88
  89         PatchStatus does not return status
  90         https://bugs.webkit.org/show_bug.cgi?id=31938
  91
  92         We need to parse attachment_id as an int.  Otherwise, we can't find
  93         anything in the datastore.
  94
  95         * CommitQueueStatus/queue_status.py:
  96
  97 2009-11-27  Adam Barth  <abarth@webkit.org>
  98
  99         Reviewed by Eric Seidel.
 100
 101         Make commit-queue status not throw an exception where there is not
 102         status
 103         https://bugs.webkit.org/show_bug.cgi?id=31936
 104
 105         We need to actually fetch the results of the query to see what's in the
 106         datastore.
 107
 108         * CommitQueueStatus/queue_status.py:
 109
 110 2009-11-27  Adam Barth  <abarth@webkit.org>
 111
 112         Reviewed by Eric Seidel.
 113
 114         [bzt] unit test ApplyPatches and ApplyAttachment
 115         https://bugs.webkit.org/show_bug.cgi?id=31935
 116
 117         * Scripts/modules/commands/download.py:
 118         * Scripts/modules/commands/download_unittest.py:
 119
 120 2009-11-27  Adam Barth  <abarth@webkit.org>
 121
 122         Reviewed by Eric Seidel.
 123
 124         [bzt] Unit test download commands
 125         https://bugs.webkit.org/show_bug.cgi?id=31923
 126
 127         Adds download_unittest and fixes a bug found while testing.
 128
 129         * Scripts/modules/commands/commandtest.py:
 130         * Scripts/modules/commands/download.py:
 131             Fixed a bug where we'd throw an error because [].append returns
 132             None.
 133         * Scripts/modules/commands/download_unittest.py: Added.
 134         * Scripts/modules/mock_bugzillatool.py:
 135         * Scripts/run-webkit-unittests:
 136
 137 2009-11-27  Adam Barth  <abarth@webkit.org>
 138
 139         Unreviewed "build" fix found while writing unit tests.
 140
 141         * Scripts/modules/commands/download.py:
 142
 143 2009-11-27  Adam Barth  <abarth@webkit.org>
 144
 145         Reviewed by Eric Seidel.
 146
 147         [bzt] Kill WebKitLandingScripts
 148         https://bugs.webkit.org/show_bug.cgi?id=31904
 149
 150         Step 6: Kill the rest.
 151
 152         * Scripts/modules/buildsteps.py:
 153         * Scripts/modules/commands/download.py:
 154         * Scripts/modules/commands/queries.py:
 155         * Scripts/modules/commands/upload.py:
 156         * Scripts/modules/landingsequence.py:
 157         * Scripts/modules/scm.py:
 158         * Scripts/modules/webkitlandingscripts.py: Removed.
 159
 160 2009-11-27  Adam Barth  <abarth@webkit.org>
 161
 162         Reviewed by Eric Seidel.
 163
 164         [bzt] Unit test upload commands
 165         https://bugs.webkit.org/show_bug.cgi?id=31903
 166
 167         Adds unit tests for all but two of the upload commands.  The two
 168         remaining ones are more difficult.  I'll return to them later.  The
 169         goal of these tests is just to run the commands.  We can test more
 170         detailed behavior later.
 171
 172         * Scripts/modules/commands/commandtest.py:
 173         * Scripts/modules/commands/upload.py:
 174         * Scripts/modules/commands/upload_unittest.py:
 175         * Scripts/modules/mock.py: Added.
 176         * Scripts/modules/mock_bugzillatool.py:
 177
 178 2009-11-26  Adam Barth  <abarth@webkit.org>
 179
 180         Reviewed by Eric Seidel.
 181
 182         [bzt] Kill WebKitLandingScripts
 183         https://bugs.webkit.org/show_bug.cgi?id=31904
 184
 185         Step 5: Kill run_and_throw_if_fail.
 186
 187         * Scripts/modules/buildsteps.py:
 188         * Scripts/modules/processutils.py: Added.
 189         * Scripts/modules/webkitlandingscripts.py:
 190
 191 2009-11-26  Adam Barth  <abarth@webkit.org>
 192
 193         Reviewed by Eric Seidel.
 194
 195         [bzt] Kill WebKitLandingScripts
 196         https://bugs.webkit.org/show_bug.cgi?id=31904
 197
 198         Step 4: Kill run_webkit_script.
 199
 200         * Scripts/modules/buildsteps.py:
 201         * Scripts/modules/commands/download.py:
 202         * Scripts/modules/webkitlandingscripts.py:
 203
 204 2009-11-26  Adam Barth  <abarth@webkit.org>
 205
 206         Reviewed by Eric Seidel.
 207
 208         [bzt] Kill WebKitLandingScripts
 209         https://bugs.webkit.org/show_bug.cgi?id=31904
 210
 211         Step 3: Kill build_webkit.
 212
 213         * Scripts/modules/buildsteps.py:
 214         * Scripts/modules/landingsequence.py:
 215         * Scripts/modules/webkitlandingscripts.py:
 216
 217 2009-11-26  Adam Barth  <abarth@webkit.org>
 218
 219         Reviewed by Eric Seidel.
 220
 221         [bzt] Kill WebKitLandingScripts
 222         https://bugs.webkit.org/show_bug.cgi?id=31904
 223
 224         Step 2: Kill ensure_builders_are_green.
 225
 226         * Scripts/modules/buildsteps.py:
 227         * Scripts/modules/commands/download.py:
 228         * Scripts/modules/landingsequence.py:
 229         * Scripts/modules/webkitlandingscripts.py:
 230
 231 2009-11-26  Adam Barth  <abarth@webkit.org>
 232
 233         Reviewed by Eric Seidel.
 234
 235         [bzt] Kill WebKitLandingScripts
 236         https://bugs.webkit.org/show_bug.cgi?id=31904
 237
 238         Step 1: Kill prepare_clean_working_directory and run_webkit_tests.
 239
 240         * Scripts/bugzilla-tool:
 241         * Scripts/modules/buildsteps.py: Added.
 242         * Scripts/modules/commands/download.py:
 243         * Scripts/modules/landingsequence.py:
 244         * Scripts/modules/webkitlandingscripts.py:
 245
 246 2009-11-26  Zoltan Horvath  <zoltan@webkit.org>
 247
 248         Reviewed by Adam Barth.
 249
 250         Remove directory prefixes from linux commands
 251
 252         SCM unittests can cause errors on some systems if we use absolute reference to
 253         the commands, so directory prefixes have been removed.
 254
 255         * Scripts/modules/scm_unittest.py:
 256
 257 2009-11-21  Holger Hans Peter Freyther  <zecke@selfish.org>
 258
 259         Reviewed by Kenneth Rohde Christiansen.
 260
 261         Link DumpRenderTree to the Qt Ui Tools
 262         https://bugs.webkit.org/show_bug.cgi?id=31203
 263
 264         Implement QWebPage::createPlugin using the Qt Ui Tools
 265         to be able to create classes like QProgressBar from within
 266         the <object></object> tags This is required for the
 267         new automatic test of Qt Plugins.
 268
 269         * DumpRenderTree/qt/DumpRenderTree.cpp:
 270         (WebCore::WebPage::createPlugin):
 271         * DumpRenderTree/qt/DumpRenderTree.h:
 272         * DumpRenderTree/qt/DumpRenderTree.pro:
 273
 274 2009-11-25  Yuzo Fujishima  <yuzo@google.com>
 275
 276         Reviewed by Eric Seidel.
 277
 278         Update pywebsocket to 0.4.2
 279
 280         Update pywebsocket to 0.4.2
 281         https://bugs.webkit.org/show_bug.cgi?id=31861
 282
 283         * pywebsocket/example/echo_client.py:
 284         * pywebsocket/example/echo_wsh.py:
 285         * pywebsocket/mod_pywebsocket/__init__.py:
 286         * pywebsocket/mod_pywebsocket/dispatch.py:
 287         * pywebsocket/mod_pywebsocket/msgutil.py:
 288         * pywebsocket/mod_pywebsocket/standalone.py:
 289         * pywebsocket/setup.py:
 290         * pywebsocket/test/test_dispatch.py:
 291         * pywebsocket/test/test_msgutil.py:
 292
 293 2009-11-25  Adam Barth  <abarth@webkit.org>
 294
 295         Reviewed by Eric Seidel.
 296
 297         Add unit test for mark-fixed
 298         https://bugs.webkit.org/show_bug.cgi?id=31896
 299
 300         * Scripts/modules/commands/commandtest.py: Added.
 301         * Scripts/modules/commands/queries_unittest.py:
 302         * Scripts/modules/commands/upload_unittest.py: Added.
 303         * Scripts/modules/mock_bugzillatool.py:
 304         * Scripts/run-webkit-unittests:
 305
 306 2009-11-25  Adam Barth  <abarth@webkit.org>
 307
 308         Reviewed by Eric Seidel.
 309
 310         bugzilla-tool should have a mark-fixed command
 311         https://bugs.webkit.org/show_bug.cgi?id=31853
 312
 313         Pretty simple stuff.
 314
 315         * Scripts/modules/commands/upload.py:
 316
 317 2009-11-25  Eric Seidel  <eric@webkit.org>
 318
 319         Reviewed by Adam Barth.
 320
 321         'bugzilla-tool help' should only show common commands like how 'git help' does
 322         https://bugs.webkit.org/show_bug.cgi?id=31772
 323
 324         I also took this opportunity to make 'help' a real Command.
 325         Making 'help' a real command required adding Command.tool (which we've wanted to do for a while).
 326
 327         * Scripts/bugzilla-tool:
 328          - change should_show_command_help to should_show_in_main_help
 329         * Scripts/modules/commands/download.py:
 330          - Mark commands as being shown in main help or not.
 331          - show_in_main_help = False is not required (default is false),
 332            but it seemed to make the commands more self-documenting.
 333         * Scripts/modules/commands/queries.py: ditto
 334         * Scripts/modules/commands/queues.py: ditto
 335         * Scripts/modules/commands/upload.py: ditto
 336         * Scripts/modules/multicommandtool.py:
 337          - Make Command hold a pointer to tool in self.tool.  Most Command
 338            subclasses do not take advantage of this yet, but it was required
 339            for HelpCommand to be able to reach the tool from _help_epilog().
 340          - Move MultiCommandTool._standalone_help_for_command to Command.standalone_help
 341          - Move MultiCommandTool._help_epilog to Command._help_epilog
 342          - Move "help" logic into HelpCommand.execute()
 343          - Change should_show_command_help to should_show_in_main_help and add a default implementation.
 344         * Scripts/modules/multicommandtool_unittest.py:
 345          - Test hiding of Commands in --help, and that all commands are shown in 'help --all-commands'
 346
 347 2009-11-25  Brian Weinstein  <bweinstein@apple.com>
 348
 349         Reviewed by Dan Bernstein.
 350
 351         Patch by Mark Rowe.
 352
 353         The buildbots are failing on Windows because when they were upgraded
 354         to 4.0.4, Apple Application Support was not in their path. Add it to
 355         the path to fix the buildots.
 356
 357         * Scripts/webkitdirs.pm:
 358
 359 2009-11-25  Csaba Osztrogonác  <ossy@webkit.org>
 360
 361         Reviewed by David Kilzer.
 362
 363         run-webkit-tests doesn't accept directories/files with --skipped=only parameter
 364         https://bugs.webkit.org/show_bug.cgi?id=31799
 365
 366         * Scripts/run-webkit-tests: Fixed.
 367
 368 2009-11-25  Zoltan Horvath  <zoltan@webkit.org>
 369
 370         Reviewed by Eric Seidel.
 371
 372         Change run_command to give back stderr by default
 373         https://bugs.webkit.org/show_bug.cgi?id=31734
 374
 375         Change run_command to give back stderr by default.
 376         Set run_commands's 'svn-create-patch' calling to put only the stdout into the patches.
 377         Change the related unittest call.
 378
 379         * Scripts/modules/scm.py:
 380         * Scripts/modules/scm_unittest.py:
 381
 382 2009-11-25  Eric Seidel  <eric@webkit.org>
 383
 384         Reviewed by Adam Barth.
 385
 386         Centralize required argument parsing in Command
 387         https://bugs.webkit.org/show_bug.cgi?id=31872
 388
 389         * Scripts/modules/commands/download.py: remove custom required arg message.
 390         * Scripts/modules/commands/upload.py: ditto.
 391         * Scripts/modules/multicommandtool.py:
 392          - Add _parse_required_arguments.
 393          - Pass program name off to OptionParser.
 394          - Add name() for access to tool name.
 395          - Add check_arguments_and_execute and make it return a return code.
 396          - Replace a couple uses of + with %.
 397         * Scripts/modules/multicommandtool_unittest.py: test _parse_required_arguments
 398
 399 2009-11-25  Eric Seidel  <eric@webkit.org>
 400
 401         Reviewed by Adam Barth.
 402
 403         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
 404         https://bugs.webkit.org/show_bug.cgi?id=31870
 405
 406         * Scripts/modules/commands/queries_unittest.py: Use the new class.
 407         * Scripts/modules/multicommandtool_unittest.py: Ditto.
 408         * Scripts/modules/outputcapture.py: Added.
 409
 410 2009-11-24  Dmitry Titov  <dimich@chromium.org>
 411
 412         Reviewed by Eric Seidel.
 413
 414         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
 415         https://bugs.webkit.org/show_bug.cgi?id=31444
 416
 417         * Scripts/build-webkit:
 418
 419 2009-11-24  Chris Marrin  <cmarrin@apple.com>
 420
 421         Reviewed by Simon Fraser.
 422
 423         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
 424         https://bugs.webkit.org/show_bug.cgi?id=27314
 425
 426         Now the script allows the directories with these tests to be included on all
 427         platforms but Mac, where they behave the same as always. For all other platforms
 428         the tests need to be excluded using the Skipped files, which is currently done
 429         for all platforms (including win since we're not turned on yet)
 430
 431         * Scripts/webkitdirs.pm:
 432
 433 2009-11-24  Eric Seidel  <eric@webkit.org>
 434
 435         Reviewed by Adam Barth.
 436
 437         queries_unittest.py should test command output
 438         https://bugs.webkit.org/show_bug.cgi?id=31845
 439
 440         * Scripts/modules/commands/queries_unittest.py:
 441          - Capture stdout and stderr and compare with expected strings.
 442
 443 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
 444
 445         No Review.
 446
 447         Fix spelling error ("depenedencies").
 448
 449         * Scripts/build-webkit:
 450
 451 2009-11-24  Mark Rowe  <mrowe@apple.com>
 452
 453         Land the configuration that includes the two debug GTK Linux builders.
 454
 455         * BuildSlaveSupport/build.webkit.org-config/config.json:
 456
 457 2009-11-24  David Kilzer  <ddkilzer@apple.com>
 458
 459         <http://webkit.org/b/31840> bisect-builds broke after r50080
 460
 461         Reviewed by Dan Bernstein.
 462
 463         * Scripts/bisect-builds:
 464         (mountAndRunNightly): Switched back to using backticks to run
 465         the hdiutil command since exec() will terminate the existing
 466         script, which is not what we want.  Store the output of
 467         File::Spec->devnull() in a variable for use in the hdiutil
 468         detach commands.
 469
 470 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 471
 472         Reviewed by Kenneth Rohde Christiansen.
 473
 474         Include "config.h" to meet Coding Style Guidelines
 475         https://bugs.webkit.org/show_bug.cgi?id=31792
 476
 477         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
 478         * DumpRenderTree/qt/jsobjects.cpp:
 479         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
 480
 481 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
 482
 483         Reviewed by Oliver Hunt.
 484
 485         Implement new required function to pass test we used to pass. This
 486         change is required since r51294.
 487
 488         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 489         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 490
 491 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
 492
 493         Reviewed by Kenneth Rohde Christiansen.
 494
 495         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
 496         https://bugs.webkit.org/show_bug.cgi?id=31775
 497
 498         LayoutTestController::dumpBackForwardList() should work with local URLs
 499         as well as with normal URLs (in http tests for instance).
 500         Currently it does not output the latter properly.
 501
 502         Unskip a bunch of passing http/navigation tests.
 503
 504         * DumpRenderTree/qt/DumpRenderTree.cpp:
 505         (WebCore::dumpHistoryItem):
 506
 507 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
 508
 509         Reviewed by Oliver Hunt.
 510
 511         ARIA: support aria-flowto
 512         https://bugs.webkit.org/show_bug.cgi?id=31762
 513
 514         * DumpRenderTree/AccessibilityUIElement.cpp:
 515         (ariaFlowToElementAtIndexCallback):
 516         (AccessibilityUIElement::getJSClass):
 517         * DumpRenderTree/AccessibilityUIElement.h:
 518         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 519         (AccessibilityUIElement::ariaFlowToElementAtIndex):
 520         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 521         (AccessibilityUIElement::ariaFlowToElementAtIndex):
 522         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 523         (AccessibilityUIElement::ariaFlowToElementAtIndex):
 524
 525 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
 526
 527         Reviewed by Kenneth Christiansen.
 528
 529         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
 530         https://bugs.webkit.org/show_bug.cgi?id=31638
 531
 532         Unfreeze WorkQueue after each test execution.
 533
 534         * DumpRenderTree/qt/DumpRenderTree.cpp:
 535         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 536
 537 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
 538
 539         Reviewed by Adam Barth.
 540
 541         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
 542         for localhost and 127.0.0.1.
 543         https://bugs.webkit.org/show_bug.cgi?id=31783
 544
 545         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
 546
 547         * DumpRenderTree/qt/DumpRenderTree.cpp:
 548         (WebCore::NetworkAccessManager::NetworkAccessManager):
 549         (WebCore::NetworkAccessManager::sslErrorsEncountered):
 550         (WebCore::WebPage::WebPage):
 551         * DumpRenderTree/qt/DumpRenderTree.h:
 552
 553 2009-11-22  Chris Evans  <cevans@chromium.org>
 554
 555         Reviewed by Adam Barth.
 556
 557         Disable access to file:/// directory listings
 558         https://bugs.webkit.org/show_bug.cgi?id=31329
 559
 560         Implemented setAllowUniversalAccessFromFileURLs to support testing of
 561         file URL security.
 562
 563         * DumpRenderTree/LayoutTestController.cpp:
 564         (setAllowUniversalAccessFromFileURLsCallback):
 565         (LayoutTestController::staticFunctions):
 566         * DumpRenderTree/LayoutTestController.h:
 567         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 568         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 569         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 570         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 571         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 572         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 573         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 574         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
 575
 576 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
 577
 578         Reviewed by Kenneth Rohde Christiansen.
 579
 580         [Qt] Fix the timeout of fast/frames/frame-navigation.html
 581         https://bugs.webkit.org/show_bug.cgi?id=31638
 582
 583         The test is timeouting, because it uses the WorkQueue to load a document in one
 584         of the child frames and once the loading is finished, the DRT does not dump the
 585         tree. This is because it waits for the QWebFrame::loadFinished() signal from
 586         the main frame, while it should connect to QWebPage::loadFinished().
 587
 588         * DumpRenderTree/qt/DumpRenderTree.cpp:
 589         (WebCore::DumpRenderTree::DumpRenderTree):
 590
 591 2009-11-21  Eric Seidel  <eric@webkit.org>
 592
 593         Reviewed by Adam Barth.
 594
 595         bugzilla-tool --help spews way too much text
 596         https://bugs.webkit.org/show_bug.cgi?id=31771
 597
 598         * Scripts/bugzilla-tool:
 599          - Remove self.cached_scm initialization hack.
 600         * Scripts/modules/buildbot.py:
 601          - Make default_host accessible to callers.
 602         * Scripts/modules/commands/download.py:
 603          - Phrase help for all commands consistently and remove spurious help text punctuation.
 604         * Scripts/modules/commands/queries.py: Ditto.
 605         * Scripts/modules/commands/queues.py: Ditto.
 606         * Scripts/modules/commands/upload.py: Ditto.
 607         * Scripts/modules/multicommandtool.py:
 608          - Add HelpPrintingOptionParser.format_epilog to replace
 609            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
 610            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
 611          - Make --help only show a list of commands like "svn help" and "git help" do --
 612            previously --help was listing all commands and options.
 613          - Sort list of commands alphabetically.
 614
 615 2009-11-21  Eric Seidel  <eric@webkit.org>
 616
 617         No review.  Fixing a typo from the previous patch for bug 31767.
 618
 619         AbstractQueue.run_bugzilla_tool throws an exception
 620         https://bugs.webkit.org/show_bug.cgi?id=31769
 621
 622         * Scripts/modules/commands/queues.py:
 623
 624 2009-11-21  Eric Seidel  <eric@webkit.org>
 625
 626         Reviewed by Adam Barth.
 627
 628         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
 629         https://bugs.webkit.org/show_bug.cgi?id=31767
 630
 631         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
 632         Since we don't have a good way to test BugzillaTool pieces, I've
 633         left out a test for now.
 634
 635         * Scripts/bugzilla-tool:
 636          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
 637         * Scripts/modules/commands/queues.py:
 638          - Use tool.path() instead of __file__.
 639         * Scripts/modules/multicommandtool.py:
 640          - Add a new path() method to MultiComandTool.
 641         * Scripts/modules/multicommandtool_unittest.py:
 642          - Provide a path() method.  Little point in testing this mock implementation.
 643
 644 2009-11-21  Adam Barth  <abarth@webkit.org>
 645
 646         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
 647         WebKitTools.
 648
 649         * Scripts/modules/commands/download.py:
 650
 651 2009-11-21  Adam Barth  <abarth@webkit.org>
 652
 653         Reviewed by Eric Seidel.
 654
 655         Convert check-style to use LandingSequence
 656         https://bugs.webkit.org/show_bug.cgi?id=31763
 657
 658         Instead of manipulating the working copy by hand, we should use the
 659         LandingSequence in CheckStyle.  This will make this code eaiser to
 660         test.
 661
 662         * Scripts/modules/commands/download.py:
 663
 664 2009-11-20  Adam Barth  <abarth@webkit.org>
 665
 666         Reviewed by Eric Seidel.
 667
 668         Unit test query commands
 669         https://bugs.webkit.org/show_bug.cgi?id=31755
 670
 671         These tests are pretty rough, but hopefully they'll grow.
 672
 673         * Scripts/modules/commands/queries_unittest.py: Added.
 674         * Scripts/modules/mock_bugzillatool.py: Added.
 675         * Scripts/run-webkit-unittests:
 676
 677 2009-11-20  Eric Seidel  <eric@webkit.org>
 678
 679         Reviewed by Adam Barth.
 680
 681         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
 682         https://bugs.webkit.org/show_bug.cgi?id=31758
 683
 684         * Scripts/modules/multicommandtool.py:
 685          - Allow passing of explicit commands to MultiCommandTool.__init__
 686         * Scripts/modules/multicommandtool_unittest.py:
 687          - Use new Command.name naming system.
 688          - Test Command auto-discovery.
 689         * Scripts/modules/workqueue.py:
 690          - bug_id no longer exists, use patch['bug_id'] instead.
 691         * Scripts/modules/workqueue_unittest.py:
 692          - WorkQueues require names now.
 693          - should_proceed_with_work_item must return a patch object.
 694
 695 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
 696
 697         Reviewed by Beth Dakin.
 698
 699         WAI-ARIA: add support for aria-owns
 700         https://bugs.webkit.org/show_bug.cgi?id=31702
 701
 702         * DumpRenderTree/AccessibilityUIElement.cpp:
 703         (ariaOwnsElementAtIndexCallback):
 704         (AccessibilityUIElement::getJSClass):
 705         * DumpRenderTree/AccessibilityUIElement.h:
 706         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 707         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 708         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 709         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 710         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 711         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 712
 713 2009-11-20  Eric Seidel  <eric@webkit.org>
 714
 715         Reviewed by Adam Barth.
 716
 717         Fix exception thrown when running the commit-queue.
 718
 719         * Scripts/modules/statusbot.py: patch is optional.
 720         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
 721
 722 2009-11-20  Eric Seidel  <eric@webkit.org>
 723
 724         Reviewed by Adam Barth.
 725
 726         Teach the StatusBot how to support more than just the commit-queue
 727         https://bugs.webkit.org/show_bug.cgi?id=31754
 728
 729         * Scripts/modules/workqueue.py: Another typo.
 730
 731 2009-11-20  Eric Seidel  <eric@webkit.org>
 732
 733         Reviewed by Adam Barth.
 734
 735         Teach the StatusBot how to support more than just the commit-queue
 736         https://bugs.webkit.org/show_bug.cgi?id=31754
 737
 738         * Scripts/modules/commands/queues.py: Fix silly typo.
 739
 740 2009-11-20  Eric Seidel  <eric@webkit.org>
 741
 742         Reviewed by Adam Barth.
 743
 744         Teach the StatusBot how to support more than just the commit-queue
 745         https://bugs.webkit.org/show_bug.cgi?id=31754
 746
 747         * CommitQueueStatus/index.yaml:
 748          - Add indices required for the new queries.
 749         * CommitQueueStatus/queue_status.py:
 750          - Add a patch-status page and move update_status to update-status.
 751          - Only display "commit-queue" status records for the commit-queue.
 752          - Add support for a queue_name property on status records.
 753          - Fix _int_from_request to actually work.
 754         * CommitQueueStatus/update_status.html:
 755          - Add support for a queue_name on status records.
 756          - Remove unused list of bug ids.
 757          * Scripts/modules/commands/queues.py
 758           - Make the queues pass the patch instead of the bug_id to StatusBot.
 759         * Scripts/modules/statusbot.py:
 760          - Support passing the queue_name to the status updates.
 761          - Support fetching patch status with patch_status().
 762         * Scripts/modules/workqueue.py:
 763          - Pass the patch to the StatusBot instead of the bug_id.
 764          - Let WorkQueues have a name.
 765
 766 2009-11-20  Adam Barth  <abarth@webkit.org>
 767
 768         Reviewed by Eric Seidel.
 769
 770         Move bugzilla-tool commands into their own file
 771         https://bugs.webkit.org/show_bug.cgi?id=31752
 772
 773         This will let us write unit tests.
 774
 775         * Scripts/bugzilla-tool:
 776         * Scripts/modules/commands/__init__.py: Added.
 777         * Scripts/modules/commands/download.py: Added.
 778         * Scripts/modules/commands/queries.py: Added.
 779         * Scripts/modules/commands/queues.py: Added.
 780         * Scripts/modules/commands/upload.py: Added.
 781         * Scripts/modules/grammar.py: Added.
 782
 783 2009-11-20  Adam Barth  <abarth@webkit.org>
 784
 785         Reviewed by Eric Seidel.
 786
 787         BuildQueue should check if the tree is currently buildable
 788         https://bugs.webkit.org/show_bug.cgi?id=31744
 789
 790         * Scripts/bugzilla-tool:
 791         * Scripts/modules/landingsequence.py:
 792         * Scripts/modules/webkitlandingscripts.py:
 793
 794 2009-11-20  Adam Barth  <abarth@webkit.org>
 795
 796         Reviewed by Eric Seidel.
 797
 798         Move prepare_clean_working_directory into the LandingSequence
 799         https://bugs.webkit.org/show_bug.cgi?id=31743
 800
 801         * Scripts/bugzilla-tool:
 802         * Scripts/modules/landingsequence.py:
 803
 804 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
 805
 806         Reviewed by Kenneth Rohde Christiansen.
 807
 808         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
 809         https://bugs.webkit.org/show_bug.cgi?id=30460
 810
 811         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
 812
 813         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 814         (pluginInvoke):
 815
 816 2009-11-20  Adam Barth  <abarth@webkit.org>
 817
 818         Reviewed by Eric Seidel.
 819
 820         Pass the port information to the child process
 821         https://bugs.webkit.org/show_bug.cgi?id=31736
 822
 823         We need to do this so the child process knows what to build!
 824
 825         * Scripts/bugzilla-tool:
 826         * Scripts/modules/landingsequence.py:
 827         * Scripts/modules/webkitport.py:
 828         * Scripts/modules/webkitport_unittest.py:
 829
 830 2009-11-20  Adam Barth  <abarth@webkit.org>
 831
 832         Reviewed by Eric Seidel.
 833
 834         Support Qt port in build-queue
 835         https://bugs.webkit.org/show_bug.cgi?id=31733
 836
 837         * Scripts/bugzilla-tool:
 838
 839 2009-11-20  Adam Barth  <abarth@webkit.org>
 840
 841         Reviewed by Eric Seidel.
 842
 843         Implement a build-queue
 844         https://bugs.webkit.org/show_bug.cgi?id=31725
 845
 846         Currently this just builds the first 10 patches in the review queue.
 847         We'll want to do something smarter soon.
 848
 849         * Scripts/bugzilla-tool:
 850
 851 2009-11-20  Adam Barth  <abarth@webkit.org>
 852
 853         Reviewed by Eric Seidel.
 854
 855         Make commit-queue and style-queue show up in help
 856         https://bugs.webkit.org/show_bug.cgi?id=31724
 857
 858         We need to store their names on their class to make these commands
 859         properly register themselves with MultiCommandTool.
 860
 861         * Scripts/bugzilla-tool:
 862
 863 2009-11-20  Adam Barth  <abarth@webkit.org>
 864
 865         Reviewed by Eric Seidel.
 866
 867         Implement bugzilla-tool build-attachment
 868         https://bugs.webkit.org/show_bug.cgi?id=31722
 869
 870         This command builds an attachment from bugzilla.  It leaves the built
 871         patch in the working copy.
 872
 873         * Scripts/bugzilla-tool:
 874         * Scripts/modules/landingsequence.py:
 875         * Scripts/modules/webkitlandingscripts.py:
 876
 877 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
 878
 879         Reviewed by Xan Lopez.
 880
 881         [GTK] DRT release event does not create the state correctly
 882         https://bugs.webkit.org/show_bug.cgi?id=31717
 883
 884         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
 885
 886 2009-11-20  Eric Seidel  <eric@webkit.org>
 887
 888         Reviewed by Adam Barth.
 889
 890         MultiCommandTool should find Command objects automatically instead of with a manual list
 891         https://bugs.webkit.org/show_bug.cgi?id=31710
 892
 893         * Scripts/bugzilla-tool:
 894         * Scripts/modules/multicommandtool.py:
 895          - Use some wild python-fu to crawl all the known subclasses of Command.
 896
 897 2009-11-20  Adam Barth  <abarth@webkit.org>
 898
 899         Unreviewed "build" fix.  Added missing import.
 900
 901         * Scripts/bugzilla-tool:
 902
 903 2009-11-20  Adam Barth  <abarth@webkit.org>
 904
 905         Unreviewed "build" fix.  I failed to update LandingSequence.test
 906         properly.
 907
 908         * Scripts/modules/landingsequence.py:
 909
 910 2009-11-20  Adam Barth  <abarth@webkit.org>
 911
 912         Reviewed by Eric Seidel.
 913
 914         Create LandingSequence as the all-sing, all-dance landing class
 915         https://bugs.webkit.org/show_bug.cgi?id=31709
 916
 917         Client can inherit from this class to carefully control exactly which
 918         steps they wish to have happen in the landing sequence.
 919
 920         * Scripts/bugzilla-tool:
 921         * Scripts/modules/landingsequence.py: Added.
 922         * Scripts/modules/webkitlandingscripts.py: Added.
 923
 924 2009-11-19  Adam Barth  <abarth@webkit.org>
 925
 926         Reviewed by Eric Seidel.
 927
 928         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
 929         https://bugs.webkit.org/show_bug.cgi?id=31707
 930
 931         This is to help when we implement build-attachment.
 932
 933         * Scripts/bugzilla-tool:
 934
 935 2009-11-19  Adam Barth  <abarth@webkit.org>
 936
 937         Reviewed by Eric Seidel.
 938
 939         Support Qt port in bugzilla-tool
 940         https://bugs.webkit.org/show_bug.cgi?id=31701
 941
 942         Now we support building with Qt!
 943
 944         * Scripts/bugzilla-tool:
 945         * Scripts/modules/webkitport.py: Added.
 946         * Scripts/modules/webkitport_unittest.py: Added.
 947         * Scripts/run-webkit-unittests:
 948
 949 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
 950
 951         Reviewed by Adam Barth.
 952
 953         Remove inserting stderr into patch in bugzilla-tool
 954         https://bugs.webkit.org/show_bug.cgi?id=29914
 955
 956         Modify SCM python module's run_command function to avoid return of stderr
 957         by default, so stderr won't be inserted into the patches.
 958         Modify the related unit test.
 959
 960         * Scripts/modules/scm.py:
 961         * Scripts/modules/scm_unittest.py:
 962
 963 2009-11-19  Eric Seidel  <eric@webkit.org>
 964
 965         Reviewed by Adam Barth.
 966
 967         bugzilla-tool needs per-command help
 968         https://bugs.webkit.org/show_bug.cgi?id=31697
 969
 970         Added support for "bugzilla-tool help command-name"
 971         and a unit test to make sure it works.
 972
 973         * Scripts/modules/multicommandtool.py:
 974         * Scripts/modules/multicommandtool_unittest.py:
 975
 976 2009-11-19  Eric Seidel  <eric@webkit.org>
 977
 978         Reviewed by Adam Barth.
 979
 980         Move MultiCommandTool and Command into a separate file and add some basic unit tests
 981         https://bugs.webkit.org/show_bug.cgi?id=31695
 982
 983         * Scripts/bugzilla-tool:
 984         * Scripts/modules/multicommandtool.py: Added.
 985         * Scripts/modules/multicommandtool_unittest.py: Added.
 986         * Scripts/run-webkit-unittests:
 987
 988 2009-11-19  Eric Seidel  <eric@webkit.org>
 989
 990         No review, just adding a FIXME.
 991
 992         Split out command parsing and help printing from BugzillaTool
 993         https://bugs.webkit.org/show_bug.cgi?id=31688
 994
 995         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
 996
 997 2009-11-19  Eric Seidel  <eric@webkit.org>
 998
 999         Reviewed by Adam Barth.
1000
1001         Split out command parsing and help printing from BugzillaTool
1002         https://bugs.webkit.org/show_bug.cgi?id=31688
1003
1004         * Scripts/bugzilla-tool:
1005          - Add new MultiCommandTool class to contain option parsing and help printing logic.
1006          - Rename private methods to use _ pattern.
1007          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
1008          -
1009
1010 2009-11-19  Eric Seidel  <eric@webkit.org>
1011
1012         Reviewed by Adam Barth.
1013
1014         Re-factor help printing to use modern python idioms
1015         https://bugs.webkit.org/show_bug.cgi?id=31685
1016
1017         * Scripts/bugzilla-tool:
1018
1019 2009-11-19  Eric Seidel  <eric@webkit.org>
1020
1021         Reviewed by Darin Adler.
1022
1023         commit-queue empty queue logs twice
1024         https://bugs.webkit.org/show_bug.cgi?id=31679
1025
1026         * Scripts/bugzilla-tool:
1027
1028 2009-11-19  Eric Seidel  <eric@webkit.org>
1029
1030         Reviewed by Darin Adler.
1031
1032         bugzilla-tool's reviewer/committer rejection message should be clearer
1033         https://bugs.webkit.org/show_bug.cgi?id=31126
1034
1035         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
1036
1037         * Scripts/modules/bugzilla.py:
1038
1039 2009-11-19  Eric Z. Ayers  <zundel@google.com>
1040
1041         Reviewed by Pavel Feldman.
1042
1043         Forces a WM_PAINT event on calling layoutTestController.display()
1044         in order to enable the timeline-paint.html test on Windows.
1045         ::UpdateWindow() does not force an event becaue the window is
1046         not visible.
1047
1048         https://bugs.webkit.org/show_bug.cgi?id=31402
1049
1050         * DumpRenderTree/win/DumpRenderTree.cpp:
1051         (displayWebView):
1052
1053 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
1054
1055         No review needed.
1056
1057         Added myself to committers list.
1058
1059         * Scripts/modules/committers.py:
1060
1061 2009-11-19  Adam Barth  <abarth@webkit.org>
1062
1063         Reviewed by Eric Seidel.
1064
1065         Bugzilla-tool command classes should match command names
1066         https://bugs.webkit.org/show_bug.cgi?id=31666
1067
1068         I renamed all the commands except CommitMessageForCurrentDiff because
1069         the new name would conflict with an existing class.
1070
1071         * Scripts/bugzilla-tool:
1072
1073 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
1074
1075         Reviewed by Gustavo Noronha Silva.
1076
1077         Web Inspector: Implement "show inspector" in WebKit GTK
1078         API and enable console tests.
1079
1080         https://bugs.webkit.org/show_bug.cgi?id=31669
1081
1082         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1083         (LayoutTestController::showWebInspector):
1084
1085 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1086
1087         Reviewed by Simon Hausmann.
1088
1089         Minor refactoring + more documentation.
1090
1091         * DumpRenderTree/qt/DumpRenderTree.cpp:
1092         (WebCore::clearHistory):
1093         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1094
1095 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
1096
1097         Reviewed by Eric Seidel.
1098
1099         Ignore websocket tests when --no-http is specified.
1100         https://bugs.webkit.org/show_bug.cgi?id=31662
1101
1102         * Scripts/run-webkit-tests:
1103
1104 2009-11-18  Adam Barth  <abarth@webkit.org>
1105
1106         Reviewed by Eric Seidel.
1107
1108         Normalize ' and " in bugzilla-tool
1109         https://bugs.webkit.org/show_bug.cgi?id=31655
1110
1111         We decided " is better than ' and we should be consistent.
1112
1113         * Scripts/bugzilla-tool:
1114
1115 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1116
1117         Reviewed by Kenneth Rohde Christiansen.
1118
1119         [Qt] Remove support for Qt v4.3 or older versions
1120         https://bugs.webkit.org/show_bug.cgi?id=29469
1121
1122         * DumpRenderTree/qt/DumpRenderTree.pro:
1123         * DumpRenderTree/qt/ImageDiff.pro:
1124
1125 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
1126
1127         Reviewed by Eric Seidel.
1128
1129         GitTest.test_create_binary_patch fails if /tmp is symlink
1130         https://bugs.webkit.org/show_bug.cgi?id=31536
1131
1132         * Scripts/modules/scm_unittest.py:
1133
1134 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
1135
1136         Reviewed by Darin Adler.
1137
1138         Configuration for Chromium Build Slaves.
1139
1140         https://bugs.webkit.org/show_bug.cgi?id=31442
1141
1142         * BuildSlaveSupport/build.webkit.org-config/config.json:
1143         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1144
1145 2009-11-18  Eric Seidel  <eric@webkit.org>
1146
1147         Reviewed by Darin Adler.
1148
1149         workqueue.py results in totally broken commit-queue UI
1150         https://bugs.webkit.org/show_bug.cgi?id=31645
1151
1152         * Scripts/bugzilla-tool:
1153          - Remove unneeded use of PatchCollection.
1154          - Grab a new copy of the cq'd patches every run of the queue.
1155
1156 2009-11-18  Sam Weinig  <sam@webkit.org>
1157
1158         Reviewed by Anders Carlsson.
1159
1160         Make the Mac Geolocation API async.
1161
1162         Update DRT to use the new async Mac Geolocation API.
1163
1164         * DumpRenderTree/mac/UIDelegate.mm:
1165         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
1166
1167 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1168
1169         Reviewed by Kenneth Rohde Christiansen.
1170
1171         Add and option to toggle HTML5 datalist support to build-webkit
1172         https://bugs.webkit.org/show_bug.cgi?id=31599
1173
1174         * Scripts/build-webkit:
1175
1176 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
1177
1178         Reviewed by Kevin Ollivier.
1179
1180         Enable wx plugin support using the Windows implementation as a base.
1181
1182         https://bugs.webkit.org/show_bug.cgi?id=31636
1183
1184         * wx/build/settings.py:
1185
1186 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1187
1188         Reviewed by Simon Hausmann.
1189
1190         Change the initialization order so that the controllers
1191         will be created before exporting them to the JS DOM window.
1192
1193         * DumpRenderTree/qt/DumpRenderTree.cpp:
1194         (WebCore::DumpRenderTree::DumpRenderTree):
1195
1196 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1197
1198         Reviewed by Simon Hausmann.
1199
1200         Fix a code copy and paste error. m_page should be page.
1201
1202         * DumpRenderTree/qt/DumpRenderTree.cpp:
1203         (WebCore::DumpRenderTree::createWindow):
1204
1205 2009-11-17  Mark Rowe  <mrowe@apple.com>
1206
1207         Reviewed by Alexey Proskuryakov.
1208
1209         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
1210
1211         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
1212         This prevents symlinks from confusing the descendant check.
1213
1214 2009-11-17  Mark Rowe  <mrowe@apple.com>
1215
1216         Reviewed by Alexey Proskuryakov.
1217
1218         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
1219
1220         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
1221         server to be up rather than having run-webkit-tests abort immediately.
1222
1223         * Scripts/run-webkit-tests:
1224
1225 2009-11-17  Eric Seidel  <eric@webkit.org>
1226
1227         Reviewed by Darin Adler.
1228
1229         commit-queue is failing to set reviewer in ChangeLogs
1230         https://bugs.webkit.org/show_bug.cgi?id=31592
1231
1232         * Scripts/bugzilla-tool: Clarify the "applying" log message.
1233         * Scripts/modules/bugzilla.py:
1234          - Add a new _validate_committer_and_reviewer function as a
1235            temporary solution until we can make a real Attachment object
1236            which knows how to fill in its committer/reviewer fields automatically.
1237
1238 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1239
1240         Unreviewed buildbot fix.
1241
1242         Revert part of earlier patch and add comment, as it
1243         was causing timeouts on the buildbot.
1244
1245         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1246         (LayoutTestController::notifyDone):
1247
1248 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1249
1250         Reviewed by Oliver Hunt.
1251
1252         Make the timeout 15 sec as for the other DRT's and make
1253         it print out the same output when a test timeout.
1254
1255         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1256         (LayoutTestController::waitUntilDone):
1257         (LayoutTestController::notifyDone):
1258         (LayoutTestController::timerEvent):
1259
1260 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
1261
1262         Reviewed by Timothy Hatcher.
1263
1264         Fixed typos in comments.
1265
1266         * Scripts/modules/committers.py:
1267
1268 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
1269
1270         Reviewed by Timothy Hatcher.
1271
1272         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
1273         - Updated DRT to show/close inspector for all tests under /inspector
1274         - Introduced LayoutTestController::setTimelineProfilingEnabled and
1275           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
1276         - Removed reload on each inspector test
1277         - Renamed fast/inspector to fast/inspector-support in order not to trigger
1278         inspector for those.
1279         - Reimplemented timeline tests in order to get rid of reload there.
1280         - Moved tests that don't require harness into the fast group.
1281
1282         https://bugs.webkit.org/show_bug.cgi?id=31472
1283
1284         * DumpRenderTree/LayoutTestController.cpp:
1285         (setTimelineProfilingEnabledCallback):
1286         (closeWebInspectorCallback):
1287         (LayoutTestController::staticFunctions):
1288         * DumpRenderTree/LayoutTestController.h:
1289         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1290         (shouldOpenWebInspector):
1291         (runTest):
1292         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1293         (LayoutTestController::setTimelineProfilingEnabled):
1294         * DumpRenderTree/mac/DumpRenderTree.mm:
1295         (shouldOpenWebInspector):
1296         (runTest):
1297         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1298         (LayoutTestController::setTimelineProfilingEnabled):
1299         * DumpRenderTree/win/DumpRenderTree.cpp:
1300         (shouldOpenWebInspector):
1301         (runTest):
1302         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1303         (LayoutTestController::setTimelineProfilingEnabled):
1304
1305 2009-11-17  Oliver Hunt  <oliver@apple.com>
1306
1307         Reviewed by Maciej Stachowiak.
1308
1309         Incorrect use of JavaScriptCore API in DumpRenderTree
1310         https://bugs.webkit.org/show_bug.cgi?id=31577
1311
1312         Return undefined rather than a literal null.
1313
1314         * DumpRenderTree/AccessibilityUIElement.cpp:
1315         (setSelectedTextRangeCallback):
1316         (incrementCallback):
1317         (decrementCallback):
1318         (showMenuCallback):
1319
1320 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
1321
1322         Reviewed by Beth Dakin.
1323
1324         AX: aria-labelledby duplicates some of its WAI-ARIA label
1325         https://bugs.webkit.org/show_bug.cgi?id=31565
1326
1327         * DumpRenderTree/AccessibilityUIElement.cpp:
1328         (titleUIElementCallback):
1329         (getIsValidCallback):
1330         (AccessibilityUIElement::getJSClass):
1331
1332 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1333
1334         Reviewed by Simon Hausmann.
1335
1336         r50942 broke output from created windows. Make the
1337         m_enableTextOutput a member of the DRT and not the
1338         WebPage.
1339
1340         * DumpRenderTree/qt/DumpRenderTree.cpp:
1341         (WebCore::WebPage::WebPage):
1342         (WebCore::WebPage::javaScriptAlert):
1343         (WebCore::WebPage::javaScriptConsoleMessage):
1344         (WebCore::WebPage::javaScriptConfirm):
1345         (WebCore::WebPage::javaScriptPrompt):
1346         (WebCore::WebPage::acceptNavigationRequest):
1347         (WebCore::DumpRenderTree::DumpRenderTree):
1348         (WebCore::DumpRenderTree::open):
1349         (WebCore::DumpRenderTree::createWindow):
1350         * DumpRenderTree/qt/DumpRenderTree.h:
1351         (WebCore::DumpRenderTree::setTextOutputEnabled):
1352         (WebCore::DumpRenderTree::isTextOutputEnabled):
1353         (WebCore::WebPage::shouldInterruptJavaScript):
1354         (WebCore::WebPage::isTextOutputEnabled):
1355         (WebCore::WebPage::setViewGeometry):
1356
1357 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1358
1359         Reviewed by Gustavo Noronha Silva.
1360
1361         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
1362         as the implementation is being used by at least Qt and Gtk+.
1363
1364         Update buildsystems as well.
1365
1366         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1367         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
1368         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
1369         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
1370         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
1371         * GNUmakefile.am:
1372
1373 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
1374
1375         Reviewed by Alexey Proskuryakov.
1376
1377         Disable wss until all platforms support pyOpenSSL
1378
1379         https://bugs.webkit.org/show_bug.cgi?id=31479
1380
1381         * Scripts/run-webkit-tests:
1382
1383 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
1384
1385         Reviewed by Kenneth Christiansen.
1386
1387         [Qt] Implement load error pages support for Qt's DRT.
1388         https://bugs.webkit.org/show_bug.cgi?id=31509
1389
1390         For now, it will not be a default feature, and layout tests
1391         that want to make use of this have to explicitily call
1392         'handleErrorPages();' for the test source.
1393
1394         Any of the other DumpRenderTree's (mac, win and gtk)
1395         support handling error pages. Qt's will be the first.
1396
1397         * DumpRenderTree/qt/DumpRenderTree.cpp:
1398         (WebCore::WebPage::supportsExtension):
1399         (WebCore::WebPage::extension):
1400         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1401         (LayoutTestController::reset):
1402         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1403         (LayoutTestController::shouldHandleErrorPages):
1404         (LayoutTestController::handleErrorPages):
1405
1406 2009-11-16  Eric Seidel  <eric@webkit.org>
1407
1408         Reviewed by Adam Barth.
1409
1410         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1411         https://bugs.webkit.org/show_bug.cgi?id=31549
1412
1413         Renamed --commit-queue to --non-interactive in most places
1414         and remove the code in land-patches which is no longer needed.
1415
1416         * Scripts/bugzilla-tool:
1417
1418 2009-11-16  Eric Seidel  <eric@webkit.org>
1419
1420         Reviewed by Adam Barth.
1421
1422         The commit-queue should use land-attachment
1423         https://bugs.webkit.org/show_bug.cgi?id=31548
1424
1425         * Scripts/bugzilla-tool:
1426
1427 2009-11-16  Adam Barth  <abarth@webkit.org>
1428
1429         Reviewed by Eric Seidel.
1430
1431         Convert CommitQueue over to PatchCollection
1432         https://bugs.webkit.org/show_bug.cgi?id=31547
1433
1434         Also fixes a bug in workqueue and adds a test!
1435
1436         * Scripts/bugzilla-tool:
1437         * Scripts/modules/workqueue.py:
1438         * Scripts/modules/workqueue_unittest.py:
1439
1440 2009-11-16  Adam Barth  <abarth@webkit.org>
1441
1442         Reviewed by Eric Seidel.
1443
1444         Move StyleQueue over to using PatchCollection
1445         https://bugs.webkit.org/show_bug.cgi?id=31544
1446
1447         That's what the class it's for.
1448
1449         * Scripts/bugzilla-tool:
1450         * Scripts/modules/patchcollection.py:
1451         * Scripts/modules/patchcollection_unittest.py:
1452
1453 2009-11-16  Eric Seidel  <eric@webkit.org>
1454
1455         Reviewed by Adam Barth.
1456
1457         bugzilla-tool needs a land-attachment command
1458         https://bugs.webkit.org/show_bug.cgi?id=31546
1459
1460         * Scripts/bugzilla-tool:
1461          - Move all the logic into AbstractLandingCommand and
1462            add a new LandAttachment command subclass.
1463          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1464
1465 2009-11-16  Eric Seidel  <eric@webkit.org>
1466
1467         Reviewed by Adam Barth.
1468
1469         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1470         https://bugs.webkit.org/show_bug.cgi?id=31543
1471
1472         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1473
1474         * Scripts/bugzilla-tool:
1475
1476 2009-11-16  Eric Seidel  <eric@webkit.org>
1477
1478         Reviewed by Adam Barth.
1479
1480         Disable the style queue from posting to the commit queue status page.
1481
1482         * Scripts/bugzilla-tool:
1483
1484 2009-11-16  Adam Barth  <abarth@webkit.org>
1485
1486         Reviewed by Eric Seidel.
1487
1488         Implement PatchCollection
1489         https://bugs.webkit.org/show_bug.cgi?id=31541
1490
1491         This class holds a set of patches and lets clients iterate through
1492         them.  Optionally, clients can install a filter.
1493
1494         * Scripts/modules/patchcollection.py: Added.
1495         * Scripts/modules/patchcollection_unittest.py: Added.
1496         * Scripts/run-webkit-unittests:
1497
1498 2009-11-16  Eric Seidel  <eric@webkit.org>
1499
1500         Reviewed by Adam Barth.
1501
1502         bugzilla-tool land-patches will close bugs with patches r=?
1503         https://bugs.webkit.org/show_bug.cgi?id=28230
1504
1505         The commit-queue shouldn't close patches with outstanding reviews on them,
1506         even if many reviewers seem to be against multi-patch bugs.
1507
1508         * Scripts/bugzilla-tool:
1509
1510 2009-11-16  Eric Seidel  <eric@webkit.org>
1511
1512         Reviewed by Adam Barth.
1513
1514         bugzilla-tool check-style should work with attachment ids instead of bug ids
1515         https://bugs.webkit.org/show_bug.cgi?id=31540
1516
1517         * Scripts/bugzilla-tool:
1518
1519 2009-11-16  Eric Seidel  <eric@webkit.org>
1520
1521         Reviewed by Adam Barth.
1522
1523         WorkQueue is the only place that should know about special exit codes
1524         https://bugs.webkit.org/show_bug.cgi?id=31534
1525
1526         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1527         and add tests for handling exit codes.
1528         I also cleaned up workqueue_unittest.py more.
1529
1530         * Scripts/bugzilla-tool:
1531         * Scripts/modules/workqueue.py:
1532         * Scripts/modules/workqueue_unittest.py:
1533
1534 2009-11-16  Eric Seidel  <eric@webkit.org>
1535
1536         Reviewed by Adam Barth.
1537
1538         Re-factor workqueue_unittest to allow for more than one test.
1539         https://bugs.webkit.org/show_bug.cgi?id=31535
1540
1541         * Scripts/modules/workqueue_unittest.py:
1542
1543 2009-11-16  Eric Seidel  <eric@webkit.org>
1544
1545         Reviewed by Adam Barth.
1546
1547         land-patches needs to be re-factored into smaller chunks
1548         https://bugs.webkit.org/show_bug.cgi?id=31532
1549
1550         * Scripts/bugzilla-tool: fix a couple obvious typos.
1551
1552 2009-11-16  Eric Seidel  <eric@webkit.org>
1553
1554         Reviewed by Adam Barth.
1555
1556         land-patches needs to be re-factored into smaller chunks
1557         https://bugs.webkit.org/show_bug.cgi?id=31532
1558
1559         The next patch will move these methods into WebKitLandingScripts.
1560
1561         * Scripts/bugzilla-tool:
1562          - Split out _land_patch and _close_bug_if_no_active_patches.
1563
1564 2009-11-16  Adam Barth  <abarth@webkit.org>
1565
1566         Reviewed by Eric Seidel.
1567
1568         Fix silly copy-and-paste code.  I am a terrible coder.
1569
1570         * Scripts/modules/bugzilla.py:
1571
1572 2009-11-16  Adam Barth  <abarth@webkit.org>
1573
1574         Reviewed by Eric Seidel.
1575
1576         Implement a StyleQueue
1577         https://bugs.webkit.org/show_bug.cgi?id=31537
1578
1579         The first iteration of the style queue only produces output locally.
1580         There is also a limit of 10 patches because it's not that useful to
1581         iterate through the entire review queue at this point.  We can remove
1582         the limit later.
1583
1584         * Scripts/bugzilla-tool:
1585         * Scripts/modules/bugzilla.py:
1586
1587 2009-11-16  Adam Barth  <abarth@webkit.org>
1588
1589         Reviewed by Eric Seidel.
1590
1591         Unit test WorkQueue
1592         https://bugs.webkit.org/show_bug.cgi?id=31531
1593
1594         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1595
1596         * Scripts/bugzilla-tool:
1597         * Scripts/modules/statusbot.py:
1598         * Scripts/modules/workqueue.py:
1599         * Scripts/modules/workqueue_unittest.py: Added.
1600         * Scripts/run-webkit-unittests:
1601
1602 2009-11-16  Eric Seidel  <eric@webkit.org>
1603
1604         Reviewed by Adam Barth.
1605
1606         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1607         https://bugs.webkit.org/show_bug.cgi?id=31530
1608
1609         * Scripts/bugzilla-tool:
1610
1611 2009-11-16  Eric Seidel  <eric@webkit.org>
1612
1613         Reviewed by Adam Barth.
1614
1615         bugzilla-tool needs apply-attachment
1616         https://bugs.webkit.org/show_bug.cgi?id=31528
1617
1618         * Scripts/bugzilla-tool:
1619          - Add ApplyAttachment command.
1620          - Abstract applying code into WebKitApplyingScripts.
1621          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1622         * Scripts/modules/bugzilla.py:
1623          - Add fetch_attachment and bug_id_for_attachment_id.
1624         * Scripts/modules/bugzilla_unittest.py:
1625          - Add test for new parsing.
1626          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1627
1628 2009-11-16  Eric Seidel  <eric@webkit.org>
1629
1630         Reviewed by Adam Barth.
1631
1632         Document check-style's use of force_clean.
1633
1634         * Scripts/bugzilla-tool:
1635         * Scripts/modules/scm.py:
1636
1637 2009-11-16  Adam Barth  <abarth@webkit.org>
1638
1639         Reviewed by Eric Seidel.
1640
1641         Move WorkQueue to its own file
1642         https://bugs.webkit.org/show_bug.cgi?id=31529
1643
1644         WorkQueue and WorkQueueDelegate are separate concerns from
1645         bugzilla-tool.  Also added a missing include to logging.py.
1646
1647         * Scripts/bugzilla-tool:
1648         * Scripts/modules/logging.py:
1649         * Scripts/modules/workqueue.py:
1650
1651 2009-11-16  Adam Barth  <abarth@webkit.org>
1652
1653         Reviewed by Eric Seidel.
1654
1655         Move OutputTee to logging.py.
1656
1657         * Scripts/bugzilla-tool:
1658         * Scripts/modules/logging.py:
1659
1660 2009-11-15  Adam Barth  <abarth@webkit.org>
1661
1662         Reviewed by Eric Seidel.
1663
1664         Refactor bugzilla-tool to allow for multiple queues
1665         https://bugs.webkit.org/show_bug.cgi?id=31513
1666
1667         Divide the commit queue class into three class to make creating
1668         additional queues easier.
1669
1670         * Scripts/bugzilla-tool:
1671
1672 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1673
1674         Reviewed by Eric Seidel.
1675
1676         svn-apply may not handle git patches created by bugzilla-tool
1677         https://bugs.webkit.org/show_bug.cgi?id=31457
1678
1679         * Scripts/modules/scm.py:
1680         * Scripts/modules/scm_unittest.py:
1681
1682 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1683
1684         Reviewed by Eric Seidel.
1685
1686         bugzilla-tool should post git binary diff
1687         https://bugs.webkit.org/show_bug.cgi?id=31458
1688
1689         Add --binary option to Git.create_patch.
1690
1691         * Scripts/modules/scm.py:
1692         * Scripts/modules/scm_unittest.py:
1693
1694 2009-11-15  Adam Barth  <abarth@webkit.org>
1695
1696         Reviewed by Darin Adler.
1697
1698         Add bugzilla-tool check-style
1699         https://bugs.webkit.org/show_bug.cgi?id=31515
1700
1701         * Scripts/bugzilla-tool:
1702         * Scripts/modules/bugzilla.py:
1703
1704 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1705
1706         Reviewed by Simon Hausmann.
1707
1708         Make the Qt Linux only --valgrind feature, suppress errors
1709         defined in the SuppressedValgrindErrors file.
1710
1711         * Scripts/run-webkit-tests:
1712
1713 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1714
1715         Reviewed by Simon Hausmann.
1716
1717         Set the locale to C and not to the current one in use on the system.
1718
1719         * DumpRenderTree/qt/DumpRenderTree.cpp:
1720         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1721
1722 2009-11-13  Adam Roben  <aroben@apple.com>
1723
1724         Add support for
1725         http/tests/security/isolatedWorld/didClearWindowObject.html
1726
1727         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1728         window objects in isolated worlds are cleared
1729
1730         Reviewed by Dave Hyatt.
1731
1732         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1733
1734         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1735         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1736         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1737         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1738         Added. Sets a __worldID property on the global object whose value is
1739         the ID of this world.
1740         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1741         Respond to this new delegate callback by calling through to one of the
1742         above new methods.
1743         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1744         (worldMap): Added. Returns a HashMap containing all the worlds we've
1745         created.
1746         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1747         haven't kept track of this world.
1748         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1749         instead of declaring our own.
1750
1751         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1752
1753         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1754         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1755         didClearWindowObjectForFrameInStandardWorld.
1756         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1757         Respond to this new delegate callback by calling through to one of the
1758         below new methods.
1759         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1760         Added. Sets a __worldID property on the gobal object whose value is
1761         the ID of this world.
1762         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1763         Added. Moved code here from didClearWindowObject.
1764
1765         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1766         didClearWindowObjectForFrame* functions.
1767
1768         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1769         (worldMap): Added. Returns a HashMap containing all the worlds we've
1770         created.
1771         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1772         haven't kept track of this world.
1773         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1774         instead of declaring our own.
1775
1776 2009-11-13  Adam Roben  <aroben@apple.com>
1777
1778         Finish replacing worldIDs with world objects
1779
1780         The only remaining use of worldIDs was in a method only used by DRT
1781         for the isolated worlds tests.
1782
1783         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1784
1785         Reviewed by Mark Rowe.
1786
1787         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1788         (LayoutTestController::evaluateScriptInIsolatedWorld):
1789         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1790         (LayoutTestController::evaluateScriptInIsolatedWorld):
1791         Updated for changes to WebFrame. Now holds the map of worldID -> world
1792         at this level instead of making WebKit do it.
1793
1794 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1795
1796         Reviewed by Simon Hausmann.
1797
1798         [Qt] Ensure the DRT does not output anything until first test is run
1799
1800         * DumpRenderTree/qt/DumpRenderTree.cpp:
1801         * DumpRenderTree/qt/DumpRenderTree.h:
1802
1803 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1804
1805         Reviewed by Tor Arne Vestbø.
1806
1807         Clear the undo stack in before each new test run.
1808
1809         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1810
1811         * DumpRenderTree/qt/DumpRenderTree.cpp:
1812         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1813
1814 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1815
1816         Reviewed by Kenneth Rohde Christiansen.
1817
1818         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1819
1820         * DumpRenderTree/qt/DumpRenderTree.cpp:
1821         (WebCore::WebPage::resetSettings):
1822         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1823         (LayoutTestController::overridePreference):
1824
1825 2009-11-13  Eric Seidel  <eric@webkit.org>
1826
1827         Reviewed by Adam Barth.
1828
1829         Update committers.py based on svn records
1830         https://bugs.webkit.org/show_bug.cgi?id=31366
1831
1832         This list was generated using validate-committer-lists from
1833         https://bugs.webkit.org/show_bug.cgi?id=30970
1834         and makes committers.py current for committers who have
1835         committed in the last 3 years.
1836
1837         * Scripts/modules/committers.py:
1838
1839 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1840
1841         Reviewed by Adam Barth.
1842
1843         The document-open.html test was flaky at times. The test invokes the layout test plugin
1844         which in its destroy stream handler opens a new document. This basically tears down the
1845         stream and the associated plugin instance. The pluginLog function in the layout test
1846         plugin attempts to retrieve the window script object on a torn down plugin instance
1847         which crashed consistently on windows in the debugger. The functions which issue
1848         these logs already have a valid window script object. We now have variants of the pluginLog
1849         function which take in a window script object with and without variable arguments.
1850
1851         https://bugs.webkit.org/show_bug.cgi?id=31067
1852
1853         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1854         (pluginLogWithWindowObject):
1855         (pluginLogWithWindowObjectVariableArgs):
1856         (pluginLog):
1857         (notifyTestCompletion):
1858         (testDocumentOpen):
1859         (testWindowOpen):
1860
1861 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1862
1863         Reviewed by Gustavo Noronha Silva.
1864
1865         https://bugs.webkit.org/show_bug.cgi?id=30997
1866         [Gtk] Implemment AtkDocument
1867
1868         Added testing support.
1869
1870         * DumpRenderTree/AccessibilityUIElement.cpp:
1871         * DumpRenderTree/AccessibilityUIElement.h:
1872         (getDocumentEncodingCallback):
1873         (getDocumentURICallback):
1874         (AccessibilityUIElement::getJSClass):
1875         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1876         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1877         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1878         (AccessibilityUIElement::documentEncoding):
1879         (AccessibilityUIElement::documentURI):
1880
1881 2009-11-12  Adam Roben  <aroben@apple.com>
1882
1883         Replace worldIDs with world objects
1884
1885         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1886         user scripts/stylesheets and isolated worlds
1887
1888         Reviewed by Sam Weinig.
1889
1890         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1891         (LayoutTestController::addUserScript):
1892         (LayoutTestController::addUserStyleSheet):
1893         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1894         (LayoutTestController::addUserScript):
1895         (LayoutTestController::addUserStyleSheet):
1896         Changed these functions to create a new WebJSWorld each time they're
1897         called and to pass that world to WebKit.
1898
1899 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1900
1901         Reviewed by Oliver Hunt.
1902
1903         need to implement aria tree roles
1904         https://bugs.webkit.org/show_bug.cgi?id=31284
1905
1906         * DumpRenderTree/AccessibilityUIElement.cpp:
1907         (disclosedRowAtIndexCallback):
1908         (selectedRowAtIndexCallback):
1909         (isEqualCallback):
1910         (isAttributeSettableCallback):
1911         (isActionSupportedCallback):
1912         (disclosedByRowCallback):
1913         (hierarchicalLevelCallback):
1914         (AccessibilityUIElement::getJSClass):
1915         * DumpRenderTree/AccessibilityUIElement.h:
1916         (AccessibilityUIElement::isEqual):
1917         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1918         (AccessibilityUIElement::hierarchicalLevel):
1919         (AccessibilityUIElement::disclosedRowAtIndex):
1920         (AccessibilityUIElement::selectedRowAtIndex):
1921         (AccessibilityUIElement::disclosedByRow):
1922         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1923         (AccessibilityUIElement::getChildAtIndex):
1924         (AccessibilityUIElement::disclosedRowAtIndex):
1925         (AccessibilityUIElement::selectedRowAtIndex):
1926         (AccessibilityUIElement::titleUIElement):
1927         (AccessibilityUIElement::parentElement):
1928         (AccessibilityUIElement::disclosedByRow):
1929         (AccessibilityUIElement::hierarchicalLevel):
1930         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1931         (AccessibilityUIElement::hierarchicalLevel):
1932         (AccessibilityUIElement::disclosedRowAtIndex):
1933         (AccessibilityUIElement::selectedRowAtIndex):
1934         (AccessibilityUIElement::disclosedByRow):
1935
1936 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1937
1938         Reviewed by Darin Adler.
1939
1940         svn-apply can not handle git binary diffs
1941         https://bugs.webkit.org/show_bug.cgi?id=26830
1942
1943         Support "literal" type git binary diffs.
1944
1945         * Scripts/VCSUtils.pm:
1946         * Scripts/modules/scm_unittest.py:
1947         * Scripts/svn-apply:
1948
1949 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1950
1951         Not reviewed, removing duplicate entry for myself in committers.py.
1952
1953         * Scripts/modules/committers.py:
1954
1955 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1956
1957         Reviewed by Darin Adler and Mark Rowe.
1958
1959         https://bugs.webkit.org/show_bug.cgi?id=31200
1960         Tests in http/tests/security/mixedContent start to fail when new tests are added
1961
1962         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1963
1964 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1965
1966         Reviewed by Jan Alonzo.
1967
1968         Create, and display a window for the inspector, for inspector
1969         tests.
1970
1971         Need to also show/hide the inspector window to avoid having
1972         problems with code assuming it is realized
1973         https://bugs.webkit.org/show_bug.cgi?id=31347
1974
1975         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1976         (webInspectorShowWindow):
1977         (webInspectorCloseWindow):
1978         (webInspectorInspectWebView):
1979         (createWebView):
1980
1981 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1982
1983         Unreviewed Qt buildbot fix.
1984
1985         My previous fix was wrong, so revert that change and fix it by
1986         returning when the document of the frame has no document element.
1987         Idea is borrowed from mac and win DRT.
1988
1989         * DumpRenderTree/qt/DumpRenderTree.cpp:
1990         (WebCore::DumpRenderTree::dumpFramesAsText):
1991
1992 2009-11-11  Eric Seidel  <eric@webkit.org>
1993
1994         Reviewed byg Kenneth Rohde Christiansen.
1995
1996         Update Kenneth's committer record to include the email he
1997         uses on lists.webkit.org.
1998
1999         * Scripts/modules/committers.py:
2000
2001 2009-11-11  Eric Seidel  <eric@webkit.org>
2002
2003         Reviewed by Gustavo Noronha Silva.
2004
2005         Several committers use separate email addresses for bugzilla and svn.webkit.org
2006         https://bugs.webkit.org/show_bug.cgi?id=31364
2007
2008         Update records for existing committers to include email addresses
2009         used in svn.webkit.org and lists.webkit.org.
2010         Most committers use the same email address in all 3 places, but some use
2011         separate addresses.  committers.py needs record of each of these addresses.
2012
2013         * Scripts/modules/committers.py:
2014
2015 2009-11-11  Eric Seidel  <eric@webkit.org>
2016
2017         No review, adding second email address for an existing committer.
2018
2019         Add Yong Li's second bugzilla account to his committer record.
2020         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
2021
2022         * Scripts/modules/committers.py:
2023
2024 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2025
2026         Reviewed by Simon Hausmann.
2027
2028         If the frame has no innerText don't append it, and
2029         do not add a newline which breaks some cross platform
2030         results.
2031
2032         * DumpRenderTree/qt/DumpRenderTree.cpp:
2033         (WebCore::DumpRenderTree::dumpFramesAsText):
2034
2035 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2036
2037         Reviewed by Simon Hausmann.
2038
2039         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
2040
2041         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2042         (webkit_test_plugin_new_instance):
2043         (webkit_test_plugin_destroy_instance):
2044         (webkit_test_plugin_destroy_stream):
2045
2046 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2047
2048         Reviewed by Mark Rowe.
2049
2050         Implement the functionality needed by plugins/window-open.html
2051
2052         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
2053         (webkit_test_plugin_new_instance):
2054         (webkit_test_plugin_set_window):
2055
2056 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2057
2058         Reviewed by Simon Hausmann.
2059
2060         [Qt] Force -graphicssystem raster and -style windows when running DRT
2061
2062         * DumpRenderTree/qt/main.cpp:
2063         * Scripts/run-webkit-tests:
2064
2065 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2066
2067         Reviewed by Simon Hausmann.
2068
2069         Compute correct library paths for Qt
2070
2071         * Scripts/webkitdirs.pm:
2072
2073 2009-11-10  Mark Rowe  <mrowe@apple.com>
2074
2075         Reviewed by Sam Weinig.
2076
2077         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
2078
2079         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
2080         about the validity of the self-signed certificates used in the regression tests.  We would then add the
2081         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
2082         that had enabled frame load delegate logging this would result in extra log messages being generated,
2083         causing the test to fail.
2084
2085         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
2086         tests.
2087
2088         * DumpRenderTree/mac/DumpRenderTree.mm:
2089         (dumpRenderTree):
2090         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2091         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2092
2093 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2094
2095         Reviewed by Kenneth Rohde Christiansen.
2096
2097         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
2098
2099         * DumpRenderTree/qt/DumpRenderTree.cpp:
2100         (WebCore::DumpRenderTree::DumpRenderTree):
2101
2102 2009-11-10  Philippe Normand  <pnormand@igalia.com>
2103
2104         Reviewed by Jan Alonzo.
2105
2106         [GTK] Remove WebSocket configuration from WebKitWebSettings
2107         https://bugs.webkit.org/show_bug.cgi?id=31244
2108
2109         Follow-up of r50724. Don't set the enable-web-socket property
2110         anymore.
2111
2112         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2113         (resetDefaultsToConsistentValues):
2114
2115 2009-11-10  Oliver Hunt  <oliver@apple.com>
2116
2117         Reviewed by Maciej Stachowiak.
2118
2119         Rename 3D Canvas related classes to use WebGL prefix
2120         https://bugs.webkit.org/show_bug.cgi?id=29095
2121
2122         Checkin new version of do-webcore-rename used to do the WebGL type rename,
2123         and upate webkitdirs script to new method of testing for WebGL.
2124
2125         * Scripts/do-webcore-rename:
2126         * Scripts/webkitdirs.pm:
2127
2128 2009-11-09  Oliver Hunt  <oliver@apple.com>
2129
2130         Reviewed by Geoff Garen.
2131
2132         Make do-webcore-rename work with git.
2133
2134         * Scripts/do-webcore-rename:
2135
2136 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2137
2138         Adding Kenneth to the reviewers list.
2139
2140         * Scripts/modules/committers.py:
2141
2142 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
2143
2144         Reviewed by Jan Alonzo.
2145
2146         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
2147         https://bugs.webkit.org/show_bug.cgi?id=30482
2148
2149         LayoutTestControllerGtk now uses the exposed
2150         Page::tabKeyCyclesThroughElements API
2151
2152         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2153         (LayoutTestController::setTabKeyCyclesThroughElements):
2154
2155 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
2156
2157         Reviewed by Holger Freyther.
2158
2159         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
2160         This helps to pass the test case below. Also replaced hardcoded
2161         code numbers with defined constants.
2162         https://bugs.webkit.org/show_bug.cgi?id=31185
2163
2164         Test: editing/undo/undo-deleteWord.html
2165
2166         * DumpRenderTree/qt/EventSenderQt.cpp:
2167         (EventSender::keyDown):
2168
2169 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
2170
2171         Reviewed by Holger Freyther.
2172
2173         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
2174         https://bugs.webkit.org/show_bug.cgi?id=31164
2175
2176         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
2177
2178         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2179         (LayoutTestController::processWork):
2180
2181 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
2182
2183         Reviewed by Holger Freyther.
2184
2185         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
2186         https://bugs.webkit.org/show_bug.cgi?id=31158
2187
2188         By invoking a script queue'd by queueScript(), 'true' was beeing returned
2189         always, which from WorkQueue prospective means that a load has been started
2190         and the queue processing should stop and wait for the load to finish.
2191         Spinning it off into a loading and a non-loading variants was the solution
2192         adopted by Mac's DRT to work around this problem. The former keeps returning
2193         'true' while the later executes the script synchronously and returns 'false'
2194         making it possible to the WorkQueue to proceed right away.
2195
2196         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2197         (LayoutTestController::processWork):
2198         (LayoutTestController::queueLoadingScript):
2199         (LayoutTestController::queueNonLoadingScript):
2200         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2201         * DumpRenderTree/qt/WorkQueueItem.h:
2202         (LoadingScriptItem::LoadingScriptItem):
2203         (LoadingScriptItem::invoke):
2204         (NonLoadingScriptItem::NonLoadingScriptItem):
2205         (NonLoadingScriptItem::invoke):
2206
2207 2009-11-07  Mark Rowe  <mrowe@apple.com>
2208
2209         Rubber-stamped by Cameron Zwarich.
2210
2211         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
2212
2213         * Scripts/commit-log-editor:
2214
2215 2009-11-07  Mark Rowe  <mrowe@apple.com>
2216
2217         Reviewed by Darin Adler.
2218
2219         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
2220         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
2221
2222         Move logic for determining the name and email address to use in a ChangeLog entry from
2223         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
2224         whether the author of the patch matches committer, and therefore needs access to the
2225         email address that would be used in a ChangeLog entry.
2226
2227         Based on a patch by Pierre d'Herbemont.
2228
2229         * Scripts/VCSUtils.pm:
2230         * Scripts/commit-log-editor:
2231         * Scripts/prepare-ChangeLog:
2232         * Scripts/webkitdirs.pm:
2233
2234 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
2235
2236         Reviewed by Adam Barth.
2237
2238         Added functionality to the layout test plugin to invoke document.open and
2239         window.open with default arguments. The associated webkit bug is
2240         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
2241         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
2242         work in Chromium (V8) if there is no calling javascript context. To achieve this
2243         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
2244         for the window.open test case and in NPP_DestroyStream for the document.open test case.
2245
2246         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2247         (testDocumentOpen):
2248         (testWindowOpen):
2249         (pluginAllocate):
2250         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
2251         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2252         (NPP_New):
2253         (NPP_SetWindow):
2254         (NPP_DestroyStream):
2255         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
2256         (NPP_New):
2257         (NPP_SetWindow):
2258         (NPP_NewStream):
2259         (NPP_DestroyStream):
2260
2261 2009-11-06  Eric Seidel  <eric@webkit.org>
2262
2263         Reviewed by Adam Barth.
2264
2265         bugzilla-tool crashed with exception
2266         https://bugs.webkit.org/show_bug.cgi?id=31092
2267
2268         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
2269
2270 2009-11-04  Eric Seidel  <eric@webkit.org>
2271
2272         No review, just add a line which got left out of the patch uploaded for commit.
2273
2274         commit-queue is crashing when trying to reject patches after unknown failures
2275         https://bugs.webkit.org/show_bug.cgi?id=31091
2276
2277         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
2278
2279 2009-11-04  Adam Roben  <aroben@apple.com>
2280
2281         Remove bogus else clause in bugzilla-tool
2282
2283         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
2284         create-bug raises exception after entering bug description
2285
2286         Reviewed by David Kilzer.
2287
2288         * Scripts/bugzilla-tool:
2289         (CreateBug): else clauses are only hit if no exception is raised, so
2290         it makes no sense to try to re-raise the exception in an else clause.
2291         The exception will automatically be re-raised if it doesn't match any
2292         of the except clauses, so we don't have to do anything special here at
2293         all to get the desired behavior.
2294
2295 2009-11-04  Eric Seidel  <eric@webkit.org>
2296
2297         Reviewed by David Kilzer.
2298
2299         svn-apply's fixChangeLogPatch function seems broken
2300         https://bugs.webkit.org/show_bug.cgi?id=30683
2301
2302         Update fixChangeLogPatch to be able to handle patches which
2303         don't start at line 1.
2304         Add unit tests for svn-apply to scm_unittest.py.
2305
2306         * Scripts/VCSUtils.pm:
2307         * Scripts/modules/scm_unittest.py:
2308
2309 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
2310
2311         Reviewed by Beth Dakin.
2312
2313         Need to implement ARIA role="combobox"
2314         https://bugs.webkit.org/show_bug.cgi?id=31096
2315
2316         * DumpRenderTree/AccessibilityUIElement.cpp:
2317         (showMenuCallback):
2318         (getIsExpandedCallback):
2319         (AccessibilityUIElement::getJSClass):
2320         * DumpRenderTree/AccessibilityUIElement.h:
2321         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2322         (AccessibilityUIElement::isExpanded):
2323         (AccessibilityUIElement::showMenu):
2324         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2325         (AccessibilityUIElement::isExpanded):
2326         (AccessibilityUIElement::showMenu):
2327         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2328         (AccessibilityUIElement::isSelected):
2329         (AccessibilityUIElement::isExpanded):
2330         (AccessibilityUIElement::showMenu):
2331
2332 2009-11-04  Eric Seidel  <eric@webkit.org>
2333
2334         Reviewed by Adam Barth.
2335
2336         commit-queue is crashing when trying to reject patches after unknown failures
2337         https://bugs.webkit.org/show_bug.cgi?id=31091
2338
2339         * Scripts/bugzilla-tool:
2340          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
2341            so we have to find out what the current patch is by asking bugzilla again.
2342          - Discovered that this code was also leaking file descriptors, so fixed that.
2343
2344 2009-11-04  Adam Roben  <aroben@apple.com>
2345
2346         Make run-webkit-tests work for the Debug_Internal Windows
2347         configuration
2348
2349         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
2350         suffix.
2351
2352         Fixes <http://webkit.org/b/31123>.
2353
2354         Reviewed by Sam Weinig.
2355
2356         * Scripts/run-webkit-tests: Don't add the _debug suffix in
2357         Debug_Internal, either.
2358
2359 2009-11-04  Eric Seidel  <eric@webkit.org>
2360
2361         Reviewed by Adam Barth.
2362
2363         committers.py needs a way to store non-bugzilla email addresses
2364         https://bugs.webkit.org/show_bug.cgi?id=31037
2365
2366         Make Committer and Reviewer constructors take a single email or a list of emails.
2367         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
2368         Expose reviewers(), used by validate-committer-lists on bug 30970.
2369
2370         * Scripts/modules/committers.py:
2371         * Scripts/modules/committers_unittest.py: Added tests for the new code.
2372
2373 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
2374
2375         Reviewed by David Levin.
2376
2377         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
2378         https://bugs.webkit.org/show_bug.cgi?id=27491
2379
2380         The test path determination logic is changed to handle websocket and websocket/ssl cases.
2381         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
2382
2383         Functions to start or stop Web Socket servers are added.
2384
2385         * Scripts/run-webkit-tests:
2386
2387 2009-11-03  Eric Seidel  <eric@webkit.org>
2388
2389         No review, just changing wording of log message.
2390
2391         Change log string to say "failed" instead of "rejected"
2392         when a commit fails due to an out of date checkout.
2393         This makes grepping the commit-queue log for rejected patches easier.
2394
2395         * Scripts/bugzilla-tool:
2396
2397 2009-11-03  Eric Seidel  <eric@webkit.org>
2398
2399         No review, adding commonly known committers missing from the file.
2400
2401         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2402
2403 2009-11-03  Eric Seidel  <eric@webkit.org>
2404
2405         No review, just sort-order cleanup.
2406
2407         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2408
2409 2009-11-03  Stephen White  <senorblanco@chromium.org>
2410
2411         (Unreviewed).
2412
2413         Add myself to committers.py.
2414
2415         * Scripts/modules/committers.py:
2416
2417 2009-11-03  Robin Dunn  <robin@alldunn.com>
2418
2419         Reviewed by Kevin Ollviier.
2420
2421         Add packaging scripts for Debian-based Linux distros.
2422
2423         https://bugs.webkit.org/show_bug.cgi?id=31075
2424
2425         * wx/packaging/build-debian-installer.py: Added.
2426         * wx/packaging/debian: Added.
2427
2428 2009-11-03  Dan Bernstein  <mitz@apple.com>
2429
2430         Reviewed by Anders Carlsson and Beth Dakin.
2431
2432         https://bugs.webkit.org/show_bug.cgi?id=31070
2433
2434         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2435         destroyed, it executes the value of the 'ondestroy' parameter as a
2436         script.
2437
2438         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2439         (pluginAllocate): Initialize onDestroy.
2440         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2441         onDestroy.
2442         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2443         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2444         specified.
2445         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2446
2447 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2448
2449         Reviewed by Xan Lopez.
2450
2451         https://bugs.webkit.org/show_bug.cgi?id=31035
2452         [GTK] some accessibility tests hitting assertion in debug builds
2453
2454         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2455
2456         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2457         (AccessibilityController::rootElement):
2458
2459 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2460
2461         Reviewed by Beth Dakin.
2462
2463         Support ARIA "tab" roles
2464         https://bugs.webkit.org/show_bug.cgi?id=30842
2465
2466         * DumpRenderTree/AccessibilityUIElement.cpp:
2467         * DumpRenderTree/AccessibilityUIElement.h:
2468         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2469         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2470         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2471
2472 2009-11-01  Eric Seidel  <eric@webkit.org>
2473
2474         Reviewed by David Levin.
2475
2476         buildbots should use --exit-after-N-failures
2477         https://bugs.webkit.org/show_bug.cgi?id=30809
2478
2479         Make the bots exit after 20 failures to prevent never-ending
2480         test runs where every test spends a minute crashing.
2481
2482         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2483
2484 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2485
2486         Reviewed by Eric Seidel.
2487
2488         Turn on warnings for QtWebKit for gcc
2489         https://bugs.webkit.org/show_bug.cgi?id=30958
2490
2491         * DumpRenderTree/qt/main.cpp:
2492         (crashHandler): Mark function NO_RETURN
2493
2494 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2495
2496         Adding myself to the committers list.
2497
2498         * Scripts/modules/committers.py:
2499
2500 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2501
2502         Fix an issue that Adam noticed in DRT.
2503
2504         Reviewed by Darin Adler.
2505
2506         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2507         (AccessibilityUIElement::role):
2508         Get the length of the role text, and create a buffer dynamically.
2509
2510 2009-10-30  Eric Seidel  <eric@webkit.org>
2511
2512         No review, rolling out r50105.
2513         http://trac.webkit.org/changeset/50105
2514
2515         This commit was causing:
2516         https://bugs.webkit.org/show_bug.cgi?id=30869
2517         We'll re-implement the feature a different way.
2518
2519         * Scripts/bugzilla-tool:
2520
2521 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2522
2523         Test for MSAA: Accessibility of headings is not correct
2524
2525         https://bugs.webkit.org/show_bug.cgi?id=30937
2526
2527         Reviewed by Adam Roben.
2528
2529         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2530         (AccessibilityUIElement::role):
2531         Allow the role returned to be a BSTR.
2532         (AccessibilityUIElement::description):
2533         Fix a copy/paste error.
2534
2535 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2536
2537         Test for MSAA: Accessibility of links is wrong
2538
2539         https://bugs.webkit.org/show_bug.cgi?id=30928
2540
2541         Reviewed by Darin Adler.
2542
2543         * DumpRenderTree/AccessibilityUIElement.cpp:
2544         (getAccessibilityValueCallback):
2545         Return the accessibility value.
2546         (AccessibilityUIElement::getJSClass):
2547         Added "accessibilityValue" value.
2548
2549         * DumpRenderTree/AccessibilityUIElement.h:
2550
2551         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2552         (AccessibilityUIElement::accessibilityValue):
2553         Stubbed.
2554
2555         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2556         (AccessibilityUIElement::accessibilityValue):
2557         Stubbed.
2558
2559         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2560         (AccessibilityUIElement::accessibilityValue):
2561         Get the object's value, and return it as a JS string.
2562
2563 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2564
2565         Fix typo in command name used by wx build system.
2566
2567         * wx/build/build_utils.py:
2568
2569 2009-10-30  Adam Barth  <abarth@webkit.org>
2570
2571         Reviewed by Darin Adler.
2572
2573         Patch v1 is a dumb default name for patches
2574         https://bugs.webkit.org/show_bug.cgi?id=30952
2575
2576         Let's use "Patch" instead.
2577
2578         * Scripts/bugzilla-tool:
2579
2580 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2581
2582         Unreviewed trivial buildfix.
2583
2584         [Qt] Buildfix for r50333.
2585
2586         * DumpRenderTree/qt/DumpRenderTree.pro:
2587
2588 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2589
2590         Reviewed by Holger Freyther.
2591
2592         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2593         https://bugs.webkit.org/show_bug.cgi?id=30953
2594
2595         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2596         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2597         makes qt DRT to share this implementation (as gtk and mac ports do).
2598
2599         * DumpRenderTree/qt/DumpRenderTree.pro:
2600         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2601         * DumpRenderTree/qt/WorkQueue.h: Removed.
2602
2603 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2604
2605         Unreviewed potential buildbot fix.
2606
2607         Second try: Reset page history before running each test.
2608
2609         Apparently the QWebHistory::clear() keeps the current page
2610         in history which is not what we want, so we not additionally
2611         sets the history capacity to 0 (forces removing everything)
2612         and then sets it back to its original value.
2613
2614         * DumpRenderTree/qt/DumpRenderTree.cpp:
2615         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2616
2617 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2618
2619         Unreviewed potential buildbot fix.
2620
2621         Reset page history before running each test.
2622
2623         * DumpRenderTree/qt/DumpRenderTree.cpp:
2624         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2625
2626 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2627
2628         Reviewed by Eric Seidel.
2629
2630         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2631
2632         Bug 28420 -  Implement HTML5 <ruby> rendering
2633         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2634
2635         No new tests (no functional change).
2636
2637         * Scripts/build-webkit:
2638
2639 2009-10-29  Dan Bernstein  <mitz@apple.com>
2640
2641         Reviewed by Mark Rowe.
2642
2643         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2644         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2645         define it.
2646
2647         * Scripts/VCSUtils.pm:
2648         * Scripts/svn-apply:
2649         * Scripts/svn-unapply:
2650
2651 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2652
2653         Reviewed by Gustavo Noronha.
2654
2655         Use the GTK+ main loop instead of rolling our own mini-version of
2656         it.
2657
2658         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2659         (dump):
2660         (runTest):
2661         (webViewLoadFinished):
2662
2663 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2664
2665         Reviewed by Oliver Hunt.
2666
2667         Implement the Qt version of DRT dumpBackForwardList().
2668
2669         * DumpRenderTree/qt/DumpRenderTree.cpp:
2670         (WebCore::dumpHistoryItem):
2671         (WebCore::DumpRenderTree::dumpBackForwardList):
2672
2673 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2674
2675         Reviewed by Adam Roben.
2676
2677         Implement DRT functionality for Qt introduced in
2678         r28690 and r28705.
2679
2680         - Implemented pathToLocalResource which exposes the functionality of
2681         converting a given unix path to the correct location on Windows.
2682         - Implemented a way to remove machine-dependent information from paths
2683         in layout test results.
2684
2685         * DumpRenderTree/qt/DumpRenderTree.cpp:
2686         (WebCore::urlSuitableForTestResult):
2687         (WebCore::WebPage::javaScriptConsoleMessage):
2688         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2689         (LayoutTestController::pathToLocalResource):
2690         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2691
2692 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2693
2694         Adding myself to the committers list.
2695
2696         * Scripts/modules/committers.py:
2697
2698 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2699
2700         Adding myself to the committers list.
2701
2702         * Scripts/modules/committers.py:
2703
2704 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2705
2706         Reviewed by Jan Alonzo.
2707
2708         [GTK] API to start inspector for a WebView
2709         https://bugs.webkit.org/show_bug.cgi?id=22551
2710
2711         Use the new inspector API to implement the LayoutTestController
2712         interfaces used to test the inspector.
2713
2714         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2715         (webInspectorInspectWebView):
2716         (createWebView):
2717         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2718         (LayoutTestController::showWebInspector):
2719         (LayoutTestController::closeWebInspector):
2720         (LayoutTestController::evaluateInWebInspector):
2721
2722 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2723
2724         Reviewed by Eric Seidel.
2725
2726         [Qt] WebFrame::counterValueForElementById must not be exposed
2727         https://bugs.webkit.org/show_bug.cgi?id=30882
2728
2729         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2730         (LayoutTestController::counterValueForElementById):
2731
2732 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2733
2734         Rubberstamped by Oliver Hunt.
2735
2736         Fix the warning:
2737
2738         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2739         declared with attribute warn_unused_result".
2740
2741         by actually checking the result. In the case it is null, an
2742         error has occoured, so treat it as the other fatal errors.
2743
2744         * DumpRenderTree/qt/DumpRenderTree.cpp:
2745         (WebCore::DumpRenderTree::initializeFonts):
2746
2747 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2748
2749         Reviewed by Darin Adler.
2750
2751         Provide a way to get counter values with layoutTestContoller
2752         https://bugs.webkit.org/show_bug.cgi?id=30555
2753
2754         Define layoutTestContoller.counterValueForElementById.
2755
2756         * DumpRenderTree/LayoutTestController.cpp:
2757         (counterValueForElementByIdCallback):
2758         (LayoutTestController::staticFunctions):
2759         * DumpRenderTree/LayoutTestController.h:
2760         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2761         (LayoutTestController::counterValueForElementById):
2762
2763 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2764
2765         Rubberstamped by Oliver Hunt.
2766
2767         Change two methods to be internal for DRT use only.
2768
2769         Part of [Qt] Review all new API in Qt 4.6
2770         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2771
2772         * DumpRenderTree/qt/DumpRenderTree.cpp:
2773         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2774         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2775         (LayoutTestController::whiteListAccessFromOrigin):
2776
2777 2009-10-27  Eric Seidel  <eric@webkit.org>
2778
2779         Reviewed by Adam Barth.
2780
2781         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2782         https://bugs.webkit.org/show_bug.cgi?id=30826
2783
2784         * Scripts/svn-apply:
2785          - Add () around all system() calls.
2786          - Use the correct system() == 0 or die instead of system() or die
2787          - Add descriptive messages to all die statements.
2788
2789 2009-10-27  Steve Block  <steveblock@google.com>
2790
2791         Reviewed by NOBODY.
2792
2793         Adds steveblock@google.com to list of committers.
2794
2795         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2796
2797 2009-10-27  Eric Seidel  <eric@webkit.org>
2798
2799         Reviewed by Adam Barth.
2800
2801         svn-apply can exit(0) even on patch failure
2802         https://bugs.webkit.org/show_bug.cgi?id=29622
2803
2804         * Scripts/svn-apply:
2805          - Add a bunch of "or die" statements, hopefully catching all
2806            possible cases where failure could still exit(0).
2807
2808 2009-10-27  Eric Seidel  <eric@webkit.org>
2809
2810         Reviewed by Adam Barth.
2811
2812         svn-* scripts should share code through VCSUtils.pm
2813         https://bugs.webkit.org/show_bug.cgi?id=30791
2814
2815         Just moving code into a shared location.
2816
2817         * Scripts/VCSUtils.pm:
2818         * Scripts/prepare-ChangeLog:
2819         * Scripts/resolve-ChangeLogs:
2820         * Scripts/svn-apply:
2821         * Scripts/svn-create-patch:
2822         * Scripts/svn-unapply:
2823         * Scripts/update-webkit:
2824
2825 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2826
2827         Suppress a huge number of MSVC warnings when building wxWebKit.
2828
2829         * wx/build/settings.py:
2830
2831 2009-10-26  Eric Seidel  <eric@webkit.org>
2832
2833         No review, just adding Mike Belshe to the committers list.
2834
2835         * Scripts/modules/committers.py:
2836
2837 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2838
2839         Reviewed by Darin Adler.
2840
2841         Make .rc files compile on Windows without depending on MFC headers
2842         https://bugs.webkit.org/show_bug.cgi?id=30750
2843
2844         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2845         windows.h instead of afxres.h because it exists even when MFC is not
2846         installed, and is all that's needed here.
2847
2848         * FindSafari/FindSafari.rc: Ditto
2849
2850 2009-10-24  Eric Seidel  <eric@webkit.org>
2851
2852         Reviewed by Adam Barth.
2853
2854         bugzilla-tool post-diff should know how to mark commit-queue=?
2855         https://bugs.webkit.org/show_bug.cgi?id=29202
2856
2857         * Scripts/bugzilla-tool:
2858          - Add --commit-queue option to post-diff, post-commits and create-bug.
2859         * Scripts/modules/bugzilla.py:
2860          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2861          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2862
2863 2009-10-23  Eric Seidel  <eric@webkit.org>
2864
2865         Reviewed by Adam Barth.
2866
2867         bugzilla-tool commit-queue does not notice modifications to committers.py
2868         https://bugs.webkit.org/show_bug.cgi?id=30084
2869
2870         * Scripts/bugzilla-tool:
2871          - Make commit-queue re-exec itself instead of using while(1).
2872          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2873          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2874
2875 2009-10-22  Eric Seidel  <eric@webkit.org>
2876
2877         Reviewed by Adam Barth.
2878
2879         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2880         https://bugs.webkit.org/show_bug.cgi?id=30634
2881
2882         * Scripts/bugzilla-tool:
2883          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2884          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2885
2886 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2887
2888         Reviewed by Eric Seidel.
2889
2890         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2891
2892         https://bugs.webkit.org/show_bug.cgi?id=30763
2893
2894         * pywebsocket/mod_pywebsocket/__init__.py:
2895         * pywebsocket/mod_pywebsocket/dispatch.py:
2896         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2897         * pywebsocket/mod_pywebsocket/standalone.py:
2898         * pywebsocket/setup.py:
2899         * pywebsocket/test/test_dispatch.py:
2900
2901 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2902
2903         Reviewed by David Levin.
2904
2905         REGRESSION: 2 failures in run-webkit-unittests
2906         https://bugs.webkit.org/show_bug.cgi?id=30645
2907
2908         * Scripts/modules/cpp_style_unittest.py:
2909         Fixed a few test scenarios which apparently lost some spaces from
2910         text literals.
2911
2912 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2913
2914         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2915
2916         * Scripts/webkitdirs.pm:
2917
2918 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2919
2920         Reviewed by Darin Adler.
2921
2922         Unification of using null device in perl scripts.
2923         https://bugs.webkit.org/show_bug.cgi?id=30572
2924
2925         * Scripts/VCSUtils.pm:
2926         * Scripts/bisect-builds:
2927         * Scripts/resolve-ChangeLogs:
2928         * Scripts/run-iexploder-tests:
2929         * Scripts/run-jsc:
2930         * Scripts/run-mangleme-tests:
2931         * Scripts/run-webkit-tests:
2932         * Scripts/webkitdirs.pm:
2933         Using File::Spec->devnull() instead of hard coded /dev/null.
2934
2935 2009-10-26  Eric Seidel  <eric@webkit.org>
2936
2937         Reviewed by Holger Freyther.
2938
2939         Reviewers are missing from committers.py
2940         https://bugs.webkit.org/show_bug.cgi?id=30733
2941
2942         * Scripts/modules/committers.py:
2943
2944 2009-10-23  Eric Seidel  <eric@webkit.org>
2945
2946         No review, only adding Alice to the list of reviewers.
2947
2948         * Scripts/modules/committers.py:
2949
2950 2009-10-23  Eric Seidel  <eric@webkit.org>
2951
2952         Reviewed by Eric Carlson.
2953
2954         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2955         https://bugs.webkit.org/show_bug.cgi?id=30700
2956
2957         * DumpRenderTree/mac/DumpRenderTree.mm:
2958         (resetDefaultsToConsistentValues): Update QuickTime version check.
2959
2960 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2961
2962         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
2963         character measurement APIs that are private on Tiger.
2964
2965         * wx/build/settings.py:
2966
2967 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2968
2969         Reviewed by NOBODY (build fix).
2970         Build fix following bug #30696.
2971
2972         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2973         (LayoutTestController::evaluateScriptInIsolatedWorld):
2974
2975 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2976
2977         Reviewed by Sam Weinig & Geoff Garen.
2978
2979         https://bugs.webkit.org/show_bug.cgi?id=30696
2980         Enable isolated-worlds tests on mac.
2981
2982         Add private interface for DRT to invoke execution in a given world.
2983
2984         * DumpRenderTree/LayoutTestController.cpp:
2985         (evaluateScriptInIsolatedWorldCallback):
2986         (LayoutTestController::staticFunctions):
2987         * DumpRenderTree/LayoutTestController.h:
2988         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2989         (LayoutTestController::evaluateScriptInIsolatedWorld):
2990         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2991         (LayoutTestController::evaluateScriptInIsolatedWorld):
2992
2993 2009-10-21  Eric Seidel  <eric@webkit.org>
2994
2995         Reviewed by Adam Barth.
2996
2997         bugzilla-tool's "patch failed to download an apply" error should give more information
2998         https://bugs.webkit.org/show_bug.cgi?id=30632
2999
3000         * Scripts/modules/scm.py:
3001          - Use the common run_command method instead of custom POpen code.
3002          - Make run_command know how to take pipes as input.
3003         * Scripts/modules/scm_unittest.py:
3004          - Add new tests to cover change.
3005          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
3006
3007 2009-10-21  Kent Tamura  <tkent@chromium.org>
3008
3009         Unreviewed.  Adding myself to the committers list.
3010
3011         * Scripts/modules/committers.py:
3012
3013 2009-10-21  Robin Dunn  <robin@alldunn.com>
3014
3015         Reviewed by Kevin Ollivier.
3016
3017         Update the Windows installer builder to work with Vista / Win 7 and with git.
3018
3019         https://bugs.webkit.org/show_bug.cgi?id=30649
3020
3021         * wx/build/build_utils.py:
3022         * wx/packaging/build-mac-installer.py:
3023         * wx/packaging/build-win-installer.py:
3024         * wx/packaging/wxWebKitInstaller.iss.in:
3025
3026 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3027
3028         Reviewed by Gustavo Noronha.
3029
3030         [GTK] Added conditional code to avoid using
3031         gdk_window_get_root_coords if we do not have a gtk+ release newer
3032         than 2.17.3.
3033         https://bugs.webkit.org/show_bug.cgi?id=30636
3034
3035         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3036
3037 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
3038
3039         Reviewed by Eric Seidel.
3040
3041         [Qt] Added dummy implementation for keepWebHistory()
3042         https://bugs.webkit.org/show_bug.cgi?id=30592
3043
3044         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3045         (LayoutTestController::keepWebHistory):
3046         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3047
3048 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3049
3050         Reviewed by Xan Lopez.
3051
3052         [GTK] Fixed the double click condition, it is not double click if
3053         we move in just in one direction.
3054         https://bugs.webkit.org/show_bug.cgi?id=30636
3055
3056         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3057
3058 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
3059
3060         Reviewed by Xan Lopez.
3061
3062         [GTK] Initialize the events completly before emitting them.
3063         https://bugs.webkit.org/show_bug.cgi?id=30633
3064
3065         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3066
3067 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3068
3069         wx build fix. Fix for when linking using --as-needed with gcc.
3070
3071         * wx/browser/wscript:
3072
3073 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
3074
3075         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
3076         to support all the features used by CURL backend.
3077
3078         * wx/build/settings.py:
3079         * wx/install-unix-extras:
3080
3081 2009-10-20  Anton Muhin  <antonm@chromium.org>
3082
3083         Reviewed by Adam Barth.
3084
3085         Add {ager,antonm,yurys}@chromium.org into committers.py
3086         https://bugs.webkit.org/show_bug.cgi?id=30560
3087
3088         * Scripts/modules/committers.py:
3089
3090 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3091
3092         Reviewed by Tor Arne Vestbø.
3093
3094         Make the Netscape Test plugin available to the Qt launcher.
3095
3096         * Scripts/run-launcher:
3097
3098 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
3099
3100         Reviewed by David Levin.
3101
3102         Removed WebSocket runtime settings.
3103         https://bugs.webkit.org/show_bug.cgi?id=29896
3104
3105         WebSocket runtime configuration is supported by chromium/v8 only.
3106
3107         * DumpRenderTree/mac/DumpRenderTree.mm:
3108         (resetDefaultsToConsistentValues):
3109         * DumpRenderTree/win/DumpRenderTree.cpp:
3110         (resetDefaultsToConsistentValues):
3111
3112 2009-10-19  Nate Chapin  <japhet@chromium.org>
3113
3114         Reviewed by Adam Barth.
3115
3116         Add testFail() to test plugin so we can test our handling of a
3117         plugin invoke call returning false.
3118
3119         https://bugs.webkit.org/show_bug.cgi?id=30239
3120
3121         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
3122         (pluginInvoke):
3123         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
3124
3125 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
3126
3127         Reviewed by Gustavo Noronha.
3128
3129         Enable DOM pasting when running layout tests.
3130
3131         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3132         (resetDefaultsToConsistentValues):
3133
3134 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3135
3136         Reviewed by Simon Hausmann.
3137
3138         Use the setPreferredContentsSize method instead
3139         of setFixedContentsSize, as the method has been renamed.
3140
3141         * DumpRenderTree/qt/DumpRenderTree.cpp:
3142         (WebCore::DumpRenderTree::open):
3143         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3144         (LayoutTestController::setFixedContentsSize):
3145
3146 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3147
3148         Reviewed by Dan Bernstein.
3149
3150         https://bugs.webkit.org/show_bug.cgi?id=30456
3151         Fixes for new Debug_All Windows build configuration.
3152
3153         * DumpRenderTree/win/DumpRenderTree.cpp:
3154         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
3155         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
3156
3157 2009-10-16  Eric Seidel  <eric@webkit.org>
3158
3159         Reviewed by Adam Barth.
3160
3161         commit-queue status bot should list which buildbot is blocking the queue
3162         https://bugs.webkit.org/show_bug.cgi?id=30452
3163
3164         Add new methods and testing.
3165
3166         * Scripts/bugzilla-tool:
3167         * Scripts/modules/buildbot.py:
3168         * Scripts/modules/buildbot_unittest.py:
3169
3170 2009-10-16  Eric Seidel  <eric@webkit.org>
3171
3172         Reviewed by Adam Barth.
3173
3174         run-webkit-tests fails when CWD is not inside a WebKit checkout
3175         https://bugs.webkit.org/show_bug.cgi?id=30451
3176
3177         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
3178         * Scripts/modules/scm_unittest.py:
3179           - Remove use of original_path (we don't need to restore the CWD).
3180           - Don't use '.' to find the webkit checkout, use __file__ instead.
3181
3182 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
3183
3184         Reviewed by Adam Roben.
3185
3186         Add a Debug_All configuration to build entire stack as debug.
3187         Change Debug_Internal to:
3188         - stop using _debug suffix for all WebKit/Safari binaries
3189         - not use _debug as a DLL naming suffix
3190         - use non-debug C runtime lib.
3191
3192         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
3193         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
3194         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
3195         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3196         Add missing debug.vsprops inherited property sheet.
3197         Add Debug_All configuration.
3198         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
3199         * WinLauncher/WinLauncher.vcproj:
3200         Removed extraneous definitions inherited from vsprops.
3201         Add Debug_All configuration.
3202
3203 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
3204
3205         Reviewed by David Levin.
3206
3207         check-webkit-style is wrong about indent checking in namespaces
3208         in header files and a few other things
3209         https://bugs.webkit.org/show_bug.cgi?id=30362
3210
3211         The few other things include:
3212         + check-webkit-style does not require spaces around the equal sign
3213           inside 'if' statements and around binary operators that take
3214           numeric literals.
3215         + check-webkit-style reports false errors for the / operator
3216           when part of a filename in the #include directive.
3217
3218         * Scripts/modules/cpp_style.py:
3219         Improved indentation checking and space checking around
3220         binary operators. While the checks are still not perfect,
3221         they are clearly better than before.
3222         * Scripts/modules/cpp_style_unittest.py:
3223         Added test cases for the newly supported checks and modified old
3224         test cases to match the new guidelines
3225
3226 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
3227
3228         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
3229
3230         * wx/build/settings.py:
3231
3232 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
3233
3234         Reviewed by David Levin.
3235
3236         Add mod_pywebsocket to test Web Sockets.
3237         http://code.google.com/p/pywebsocket/
3238         https://bugs.webkit.org/show_bug.cgi?id=27490
3239
3240         * pywebsocket/COPYING: Added.
3241         * pywebsocket/MANIFEST.in: Added.
3242         * pywebsocket/README: Added.
3243         * pywebsocket/example/echo_client.py: Added.
3244         * pywebsocket/example/echo_wsh.py: Added.
3245         * pywebsocket/mod_pywebsocket/__init__.py: Added.
3246         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
3247         * pywebsocket/mod_pywebsocket/handshake.py: Added.
3248         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
3249         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
3250         * pywebsocket/mod_pywebsocket/standalone.py: Added.
3251         * pywebsocket/mod_pywebsocket/util.py: Added.
3252         * pywebsocket/setup.py: Added.
3253         * pywebsocket/test/config.py: Added.
3254         * pywebsocket/test/mock.py: Added.
3255         * pywebsocket/test/run_all.py: Added.
3256         * pywebsocket/test/test_dispatch.py: Added.
3257         * pywebsocket/test/test_handshake.py: Added.
3258         * pywebsocket/test/test_mock.py: Added.
3259         * pywebsocket/test/test_msgutil.py: Added.
3260         * pywebsocket/test/test_util.py: Added.
3261         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
3262         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
3263         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
3264         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
3265         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
3266         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
3267         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
3268         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
3269
3270 2009-10-15  James Robinson  <jamesr@google.com>
3271
3272         Reviewed by David Levin.
3273
3274         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
3275
3276         https://bugs.webkit.org/show_bug.cgi?id=30426
3277
3278         * Scripts/modules/cpp_style.py:
3279         * Scripts/modules/cpp_style_unittest.py:
3280
3281 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
3282
3283         Reviewed by Adam Roben.
3284
3285         Fixes <http://webkit.org/b/30411>.
3286         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
3287
3288         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
3289         building Chromium.
3290
3291         * Scripts/pdevenv:
3292
3293 2009-10-15  Robin Dunn  <robin@alldunn.com>
3294
3295         Reviewed by Kevin Ollivier.
3296
3297         Add Mac package building scripts for wx.
3298
3299         https://bugs.webkit.org/show_bug.cgi?id=30405
3300
3301         * wx/build/build_utils.py:
3302         * wx/build/settings.py:
3303         * wx/packaging/build-mac-installer.py: Added.
3304
3305 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
3306
3307         Reviewed by Gustavo Noronha.
3308
3309         Enable Web Sockets support when running layout tests.
3310
3311         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3312         (resetDefaultsToConsistentValues):
3313
3314 2009-10-15  Xan Lopez  <xlopez@igalia.com>
3315
3316         Reviewed by Gustavo Noronha.
3317
3318         Need to initialize event.button.button, since in most cases a
3319         button number is not passed as an argument.
3320
3321         * DumpRenderTree/gtk/EventSender.cpp:
3322         (mouseDownCallback):
3323         (mouseUpCallback):
3324
3325 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
3326
3327         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
3328         the OS if none was explicitly set.
3329
3330         * wx/build/settings.py:
3331
3332 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
3333
3334         Reviewed by Timothy Hatcher.
3335
3336         Web Inspector: enable developers extras within inspector layout tests.
3337
3338         https://bugs.webkit.org/show_bug.cgi?id=30014
3339
3340         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3341         (LayoutTestController::showWebInspector):
3342         (LayoutTestController::closeWebInspector):
3343         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3344         (LayoutTestController::showWebInspector):
3345         (LayoutTestController::closeWebInspector):
3346
3347 2009-10-14  José Millán Soto  <jmillan@igalia.com>
3348
3349         Reviewed by Jan Alonzo.
3350
3351         GtkLauncher is using a deprecated signal
3352         https://bugs.webkit.org/show_bug.cgi?id=30364
3353
3354         Modified GtkLauncher to use notify::title signal instead of
3355         deprecated title-changed signal
3356
3357         * GtkLauncher/main.c:
3358         (notify_title_cb):
3359         (create_browser):
3360
3361 2009-10-14  Brady Eidson  <beidson@apple.com>
3362
3363         Reviewed by Sam Weinig.
3364
3365         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
3366         1 - Disables WebHistory
3367         2 - Doesn't make sense in that context anyway.
3368
3369         * DumpRenderTree/win/DumpRenderTree.cpp:
3370         (createWebViewAndOffscreenWindow):
3371
3372 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
3373
3374         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
3375         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
3376
3377         * wx/build/settings.py:
3378         * wx/install-unix-extras:
3379
3380 2009-10-14  Brady Eidson  <beidson@apple.com>
3381
3382         Reviewed by Sam Weinig.
3383
3384         WebKit Win API should provide a delegate interface for global history.
3385         https://bugs.webkit.org/show_bug.cgi?id=29905
3386
3387         * DumpRenderTree/LayoutTestController.cpp:
3388         (LayoutTestController::LayoutTestController):
3389         * DumpRenderTree/LayoutTestController.h:
3390         (LayoutTestController::dumpHistoryDelegateCallbacks):
3391         (LayoutTestController::setDumpHistoryDelegateCallbacks):
3392
3393         * DumpRenderTree/win/DumpRenderTree.cpp:
3394         (shouldLogHistoryDelegates):
3395         (runTest):
3396         (createWebViewAndOffscreenWindow):
3397         (main):
3398         * DumpRenderTree/win/DumpRenderTree.vcproj:
3399
3400         Add the IWebHistoryDelegate to DRT Windows:
3401         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3402         (wstringFromBSTR):
3403         (HistoryDelegate::HistoryDelegate):
3404         (HistoryDelegate::~HistoryDelegate):
3405         (HistoryDelegate::QueryInterface):
3406         (HistoryDelegate::AddRef):
3407         (HistoryDelegate::Release):
3408         (HistoryDelegate::didNavigateWithNavigationData):
3409         (HistoryDelegate::didPerformClientRedirectFromURL):
3410         (HistoryDelegate::didPerformServerRedirectFromURL):
3411         (HistoryDelegate::updateHistoryTitle):
3412         (HistoryDelegate::populateVisitedLinksForWebView):
3413         * DumpRenderTree/win/HistoryDelegate.h: Added.
3414
3415         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3416         (LayoutTestController::removeAllVisitedLinks):
3417
3418 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3419
3420         Reviewed by Simon Hausmann.
3421
3422         [Qt] Implement support for setPOSIXLocale on Qt.
3423         https://bugs.webkit.org/show_bug.cgi?id=30268
3424
3425         * DumpRenderTree/qt/DumpRenderTree.cpp:
3426         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3427         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3428         (LayoutTestController::setPOSIXLocale):
3429         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3430
3431 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3432
3433         Unreviewed, adding myself to reviewers list.
3434
3435         * Scripts/modules/committers.py:
3436
3437 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3438
3439         Reviewed by Mark Rowe.
3440
3441         Fix null assignment so root tests work again.
3442
3443         * Scripts/webkitdirs.pm:
3444
3445 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3446
3447         Reviewed by Simon Hausmann.
3448
3449         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3450         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3451         This is done in preparation of implementing missing features in DRT.
3452         No functionality changes made yet.
3453
3454         * DumpRenderTree/qt/DumpRenderTree.cpp:
3455         * DumpRenderTree/qt/DumpRenderTree.pro:
3456         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3457         (EventSender::EventSender):
3458         (EventSender::mouseDown):
3459         (EventSender::mouseUp):
3460         (EventSender::mouseMoveTo):
3461         (EventSender::leapForward):
3462         (EventSender::keyDown):
3463         (EventSender::contextClick):
3464         (EventSender::scheduleAsynchronousClick):
3465         (EventSender::frameUnderMouse):
3466         * DumpRenderTree/qt/EventSenderQt.h: Added.
3467         (EventSender::clearKillRing):
3468         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3469         (LayoutTestController::LayoutTestController):
3470         (LayoutTestController::reset):
3471         (LayoutTestController::processWork):
3472         (LayoutTestController::maybeDump):
3473         (LayoutTestController::waitUntilDone):
3474         (LayoutTestController::notifyDone):
3475         (LayoutTestController::windowCount):
3476         (LayoutTestController::clearBackForwardList):
3477         (LayoutTestController::dumpEditingCallbacks):
3478         (LayoutTestController::dumpResourceLoadCallbacks):
3479         (LayoutTestController::queueBackNavigation):
3480         (LayoutTestController::queueForwardNavigation):
3481         (LayoutTestController::queueLoad):
3482         (LayoutTestController::queueReload):
3483         (LayoutTestController::queueScript):
3484         (LayoutTestController::provisionalLoad):
3485         (LayoutTestController::timerEvent):
3486         (LayoutTestController::encodeHostName):
3487         (LayoutTestController::decodeHostName):
3488         (LayoutTestController::setJavaScriptProfilingEnabled):
3489         (LayoutTestController::setFixedContentsSize):
3490         (LayoutTestController::setPrivateBrowsingEnabled):
3491         (LayoutTestController::setPopupBlockingEnabled):
3492         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3493         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3494         (LayoutTestController::numberOfActiveAnimations):
3495         (LayoutTestController::disableImageLoading):
3496         (LayoutTestController::dispatchPendingLoadRequests):
3497         (LayoutTestController::setDatabaseQuota):
3498         (LayoutTestController::clearAllDatabases):
3499         (LayoutTestController::whiteListAccessFromOrigin):
3500         (LayoutTestController::waitForPolicyDelegate):
3501         (LayoutTestController::overridePreference):
3502         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3503         (LayoutTestController::isLoading):
3504         (LayoutTestController::setLoading):
3505         (LayoutTestController::shouldDumpAsText):
3506         (LayoutTestController::shouldDumpBackForwardList):
3507         (LayoutTestController::shouldDumpChildrenAsText):
3508         (LayoutTestController::shouldDumpDatabaseCallbacks):
3509         (LayoutTestController::shouldDumpStatusCallbacks):
3510         (LayoutTestController::shouldWaitUntilDone):
3511         (LayoutTestController::canOpenWindows):
3512         (LayoutTestController::shouldDumpTitleChanges):
3513         (LayoutTestController::waitForPolicy):
3514         (LayoutTestController::dumpAsText):
3515         (LayoutTestController::dumpChildFramesAsText):
3516         (LayoutTestController::dumpDatabaseCallbacks):
3517         (LayoutTestController::dumpStatusCallbacks):
3518         (LayoutTestController::setCanOpenWindows):
3519         (LayoutTestController::dumpBackForwardList):
3520         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3521         (LayoutTestController::display):
3522         (LayoutTestController::dumpTitleChanges):
3523         (LayoutTestController::dumpSelectionRect):
3524         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3525         (TextInputController::TextInputController):
3526         (TextInputController::doCommand):
3527         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3528         * DumpRenderTree/qt/WorkQueue.cpp:
3529         * DumpRenderTree/qt/WorkQueue.h:
3530         * DumpRenderTree/qt/WorkQueueItem.h:
3531         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3532         (findFrameNamed):
3533         (LoadItem::invoke):
3534         (ReloadItem::invoke):
3535         (ScriptItem::invoke):
3536         (BackForwardItem::invoke):
3537         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3538         * DumpRenderTree/qt/jsobjects.h:
3539
3540 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3541
3542         Not reviewed, adding myself to the list of reviewers.
3543
3544         * Scripts/modules/committers.py:
3545
3546 2009-10-13  Anders Carlsson  <andersca@apple.com>
3547
3548         Reviewed by Sam Weinig.
3549
3550         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3551
3552         Make the private browsing mode testable by the test plug-in.
3553
3554         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3555         (pluginGetProperty):
3556         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3557         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3558         (NPP_New):
3559         (NPP_SetValue):
3560
3561 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3562
3563         No review, just adding self to the list of reviewers.
3564
3565         * Scripts/modules/committers.py:
3566
3567 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3568
3569         Reviewed by Adam Roben.
3570
3571         Web Inspector: Use proper web view in inspector layout
3572         tests for windows.
3573
3574         https://bugs.webkit.org/show_bug.cgi?id=30298
3575
3576         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3577         (LayoutTestController::showWebInspector):
3578         (LayoutTestController::closeWebInspector):
3579         (LayoutTestController::evaluateInWebInspector):
3580
3581 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3582
3583         Reviewed by Sam Weinig.
3584
3585         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3586         https://bugs.webkit.org/show_bug.cgi?id=29841
3587
3588         * DumpRenderTree/mac/DumpRenderTree.mm:
3589         (resetDefaultsToConsistentValues):
3590         * DumpRenderTree/win/DumpRenderTree.cpp:
3591         (resetDefaultsToConsistentValues):
3592
3593 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3594
3595         Reviewed by Dimitri Glazkov.
3596
3597         Chromium Port - Windows
3598         https://bugs.webkit.org/show_bug.cgi?id=29969
3599
3600         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3601         * Scripts/webkitdirs.pm:
3602
3603 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3604
3605         Reviewed by Darin Adler.
3606
3607         jsc scripts cleanup and Qt/GTK fix
3608         https://bugs.webkit.org/show_bug.cgi?id=30288
3609
3610         Duplicated jscPath() moved to webkitdirs.pm.
3611         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3612         Configuration added (release/debug) to path for Qt-port on Windows.
3613
3614         * Scripts/run-javascriptcore-tests:
3615         * Scripts/run-jsc:
3616         * Scripts/run-sunspider:
3617         * Scripts/sunspider-compare-results:
3618         * Scripts/webkitdirs.pm:
3619
3620 2009-10-11  Adam Barth  <abarth@webkit.org>
3621
3622         Unreviewed.  Add Collin to committers.py.
3623
3624         * Scripts/modules/committers.py:
3625
3626 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3627
3628         wx build fix, add bindings to source/include dirs now that there are sources there.
3629
3630         * wx/build/settings.py:
3631
3632 2009-10-09  Mark Rowe  <mrowe@apple.com>
3633
3634         Reviewed by Brady Eidson.
3635
3636         Enable plug-in halting in DumpRenderTree.
3637
3638         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3639         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3640
3641         * DumpRenderTree/mac/DumpRenderTree.mm:
3642         (resetDefaultsToConsistentValues):
3643         * DumpRenderTree/mac/UIDelegate.mm:
3644         (-[UIDelegate webView:shouldHaltPlugin:]):
3645
3646 2009-10-08  Brady Eidson  <beidson@apple.com>
3647
3648         Reviewed by Dan Bernstein.
3649
3650         Ask the History Delegate to populate the visited links hash.
3651         <rdar://problem/7285293> and https://webkit.org/b/29904
3652
3653         Add the ability for LayoutTestController to clear all visited links.
3654         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3655
3656         * DumpRenderTree/LayoutTestController.cpp:
3657         (LayoutTestController::LayoutTestController):
3658         (removeAllVisitedLinksCallback):
3659         (LayoutTestController::staticFunctions):
3660         * DumpRenderTree/LayoutTestController.h:
3661         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3662         (LayoutTestController::removeAllVisitedLinks):
3663
3664         * DumpRenderTree/mac/HistoryDelegate.mm:
3665         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3666
3667         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3668         (LayoutTestController::removeAllVisitedLinks):
3669         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3670         (LayoutTestController::removeAllVisitedLinks):
3671         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3672         (LayoutTestController::removeAllVisitedLinks):
3673
3674
3675 2009-10-08  Daniel Bates  <dbates@webkit.org>
3676
3677         Reviewed by Adam Roben.
3678
3679         https://bugs.webkit.org/show_bug.cgi?id=30175
3680
3681         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3682         the OLE drag-and-drop return value like the function it emulates. Currently,
3683         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine
3684         whether the drag-and-drop operation was successful or was cancelled.
3685
3686         This patch fixes this issue by having UIDe