3533a65f7c3e36b5b0f533eaa742e723bfff6709
[WebKit-https.git] / WebKitTools / ChangeLog
1 2010-02-26  Dumitru Daniliuc  <dumi@chromium.org>
2
3         Reviewed by Dimitri Glazkov.
4
5         Moving the script to the right location.
6
7         * pywebsocket/mod_pywebsocket: Added.
8         * pywebsocket/mod_pywebsocket/standalone.py: Copied from WebKitTools/pywebsocket/standalone.py.
9         * pywebsocket/standalone.py: Removed.
10
11 2010-02-26  Dumitru Daniliuc  <dumi@chromium.org>
12
13         Unreviewed, fixing the license.
14
15         * pywebsocket/standalone.py:
16
17 2010-02-26  Dumitru Daniliuc  <dumi@chromium.org>
18
19         Reviewed by Adam Barth.
20
21         Adding pywebsocket/standalone.py back to fix the Chromium webkit
22         canaries. Once all layout tests pass, we can get in the patch that
23         moves this directorty to WebKitTools/Scripts, update all Chromium
24         scripts, and revert this patch.
25
26         https://bugs.webkit.org/show_bug.cgi?id=35464
27
28         * pywebsocket: Added.
29         * pywebsocket/standalone.py: Added.
30
31 2010-02-26  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
32
33         Reviewed by Xan Lopez.
34
35         [GTK] Needs proper reporting of frame loader callbacks, in DRT
36         https://bugs.webkit.org/show_bug.cgi?id=32170
37
38         Fix reporting of unload handlers, so that it is emitted where
39         needed, not after it.
40
41         * DumpRenderTree/gtk/DumpRenderTree.cpp:
42         (webViewLoadFinished):
43         (webViewDocumentLoadFinished):
44         (createWebView):
45
46 2010-02-26  Antonio Gomes  <tonikitoo@webkit.org>
47
48         Reviewed by Gustavo Noronha.
49         Patch by Antonio Gomes <tonikitoo@webkit.org>
50
51         [Gtk] Make DRT EventSender::keyDown to consider 'hardware_keycode' field when synthesizing an event.
52         https://bugs.webkit.org/show_bug.cgi?id=35432
53
54         When a directional key-press event (arrow keys, End, Home, PageUp,
55         PageDown, etc) is synthesized by DRT's EventSender and it targets
56         an editor (e.g. <input type=text>, <textare>, etc), event is processed
57         by WebCore::EventHandler. On the other hand, if event target is not
58         an editor, event is bubbled up to Gtk+ for processing. In such cases,
59         if 'hardware_keycode' is not provided at event synthesize time
60         its processing fails (at some point in gtk_bindings_activate_event),
61         and no scroll action is performed.
62
63         Unskip fast/events/node-event-anchor-lock.html
64
65         * DumpRenderTree/win/EventSender.cpp:
66         (keyDownCallback):
67         * platform/gtk/Skipped:
68
69 2010-02-26  Dimitri Glazkov  <dglazkov@chromium.org>
70
71         Reviewed by David Levin.
72
73         new-webkit-run-tests: Extraneous parenthesis in websocket_server.py
74         https://bugs.webkit.org/show_bug.cgi?id=35436
75
76          * Scripts/webkitpy/layout_tests/port/websocket_server.py: Removed extra paren.
77
78 2010-02-26  Chris Jerdonek  <cjerdonek@webkit.org>
79
80         Reviewed by David Levin.
81
82         Moved pywebsocket into the webkitpy/thirdparty directory and added
83         an associated README.webkit file to the pywebsocket directory.
84         This makes pywebsocket more consistent with the other third-party
85         Python code in our repository.
86
87         https://bugs.webkit.org/show_bug.cgi?id=35198
88
89         * Scripts/run-webkit-tests:
90           - Updated paths to pywebsocket.
91
92         * Scripts/run-webkit-websocketserver:
93           - Updated paths to pywebsocket.
94
95         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
96           - Updated paths to pywebsocket.
97
98         * Scripts/webkitpy/thirdparty/pywebsocket: Copied from WebKitTools/pywebsocket.
99         * Scripts/webkitpy/thirdparty/pywebsocket/README.webkit: Added.
100           - Added a file containing information about the contents
101             of the pywebsocket directory. This will make it easier to
102             understand where the third-party code came from and what
103             local changes have been made.
104
105         * pywebsocket: Removed.
106         * pywebsocket/COPYING: Removed.
107         * pywebsocket/MANIFEST.in: Removed.
108         * pywebsocket/README: Removed.
109         * pywebsocket/example: Removed.
110         * pywebsocket/example/echo_client.py: Removed.
111         * pywebsocket/example/echo_wsh.py: Removed.
112         * pywebsocket/mod_pywebsocket: Removed.
113         * pywebsocket/mod_pywebsocket/__init__.py: Removed.
114         * pywebsocket/mod_pywebsocket/dispatch.py: Removed.
115         * pywebsocket/mod_pywebsocket/handshake.py: Removed.
116         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Removed.
117         * pywebsocket/mod_pywebsocket/memorizingfile.py: Removed.
118         * pywebsocket/mod_pywebsocket/msgutil.py: Removed.
119         * pywebsocket/mod_pywebsocket/standalone.py: Removed.
120         * pywebsocket/mod_pywebsocket/util.py: Removed.
121         * pywebsocket/setup.py: Removed.
122         * pywebsocket/test: Removed.
123         * pywebsocket/test/config.py: Removed.
124         * pywebsocket/test/mock.py: Removed.
125         * pywebsocket/test/run_all.py: Removed.
126         * pywebsocket/test/test_dispatch.py: Removed.
127         * pywebsocket/test/test_handshake.py: Removed.
128         * pywebsocket/test/test_memorizingfile.py: Removed.
129         * pywebsocket/test/test_mock.py: Removed.
130         * pywebsocket/test/test_msgutil.py: Removed.
131         * pywebsocket/test/test_util.py: Removed.
132         * pywebsocket/test/testdata: Removed.
133         * pywebsocket/test/testdata/handlers: Removed.
134         * pywebsocket/test/testdata/handlers/blank_wsh.py: Removed.
135         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Removed.
136         * pywebsocket/test/testdata/handlers/sub: Removed.
137         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Removed.
138         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Removed.
139         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Removed.
140         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Removed.
141         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Removed.
142         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Removed.
143
144 2010-02-26  Chris Jerdonek  <cjerdonek@webkit.org>
145
146         Reviewed by Eric Seidel.
147
148         Changed the diff_parser module to log to a module-specific
149         logging.logger rather than the root logger.
150
151         https://bugs.webkit.org/show_bug.cgi?id=35391
152
153         * Scripts/webkitpy/diff_parser.py:
154
155 2010-02-26  Csaba Osztrogonác  <ossy@webkit.org>
156
157         Reviewed by Kenneth Rohde Christiansen.
158
159         [Qt] LayoutTestController.numberOfPages() should have default parameters
160         https://bugs.webkit.org/show_bug.cgi?id=35428
161
162         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: maxViewWidth and maxViewHeight moved to
163         LayoutTestController to converge to platform independent implementation.
164         (WebCore::DumpRenderTree::DumpRenderTree):
165         (WebCore::DumpRenderTree::open):
166         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Initialization of maxViewWidth and maxViewHeight added.
167         * DumpRenderTree/qt/LayoutTestControllerQt.h:
168          - Default parameters for LayoutTestController.numberOfPages() added.
169          - maxViewWidth and maxViewHeight members added.
170
171 2010-02-26  Jamey Hicks  <jamey.hicks@nokia.com>
172
173         Reviewed by Laszlo Gombos.
174
175         [Qt] added QWebSettings::setInspectorUrl() and QWebSettings::inspectorUrl()
176
177         Enables the use of alternate Web Inspector frontends by changing
178         the location of the frontend. The location is specified by providing 
179             -inspector-url url
180         as an argument to QtLauncher.
181
182         This is required so that the Web Inspector may be run from an
183         external process or an external tool such as Eclipse or Aptana may
184         be used instead of the in-process Web Inspector UI.
185         
186         https://bugs.webkit.org/show_bug.cgi?id=35340
187
188         * QtLauncher/main.cpp:
189         (LauncherWindow::init):
190         (LauncherApplication::handleUserOptions):
191
192 2010-02-25  Dirk Pranke  <dpranke@chromium.org>
193
194         Reviewed by Eric Seidel.
195
196         Add a 'passing' port implementation to new-run-webkit-tests that
197         acts as a wrapper around an existing implementation but stubs out
198         the actual test invocations (instead, the expected results are echoed
199         back to the harness). This is useful for coverage and perf testing
200         of the harness (especially perf testing as it essentially provides
201         a lower bound on how fast the harness can run).
202
203         Also added a --nostart-helper flag to new-run-webkit-tests so that
204         you can skip starting the layout_test_helper and actually run the
205         harness even if you don't have a build of that port.
206
207         Also fix a bug in the 'test' port implementation to actually
208         create the results directory under /tmp instead of /.
209
210         https://bugs.webkit.org/show_bug.cgi?id=35370
211
212         * Scripts/webkitpy/layout_tests/port/factory.py: Modified.
213         * Scripts/webkitpy/layout_tests/port/passing.py: Added.
214         * Scripts/webkitpy/layout_tests/port/test.py: Added.
215         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Modified.
216
217 2010-02-25  Eric Seidel  <eric@webkit.org>
218
219         Fix typo in my last change.  No review.
220
221         Rename run-chromium-webkit-tests to new-run-webkit-tests to stop confusion
222         https://bugs.webkit.org/show_bug.cgi?id=35408
223
224         * Scripts/new-run-webkit-tests:
225
226 2010-02-25  Eric Seidel  <eric@webkit.org>
227
228         Reviewed by Adam Barth.
229
230         Rename run-chromium-webkit-tests to new-run-webkit-tests to stop confusion
231         https://bugs.webkit.org/show_bug.cgi?id=35408
232
233         * Scripts/new-run-webkit-tests: Added.
234         * Scripts/run-chromium-webkit-tests: Removed.
235         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Renamed from WebKitTools/Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py.
236
237 2010-02-25  Adam Barth  <abarth@webkit.org>
238
239         Reviewed by David Levin.
240
241         EWS leaks memory slowly
242         https://bugs.webkit.org/show_bug.cgi?id=35395
243
244         The EWS bots leak memory very slowly.  If you run them for about a
245         month, each one will take up around 1 GB of virutal memory.  If you run
246         several of them on one machine, you'll eventually exhaust all available
247         memory and grind the bots to a halt.
248
249         This patch introduces a --exit-after-iteration option to the queues so
250         that we run them for a finite amount of time.  Once they exit and
251         restart, they'll reclaim the leaked memory.  I'm not sure how many
252         iterations I'll end up running them for.  I'll need to sort that out
253         operationally, but my initial guess is around 1000.
254
255         * Scripts/webkitpy/commands/queues.py:
256         * Scripts/webkitpy/commands/queues_unittest.py:
257
258 2010-02-25  Jarkko Sakkinen  <jarkko.sakkinen@tieto.com>
259
260         Reviewed by Kenneth Rohde Christiansen.
261
262         Qt WebGL support
263
264         Adds toggling of WebGL support to QtLauncher.
265         https://bugs.webkit.org/show_bug.cgi?id=35153
266
267         * QtLauncher/main.cpp:
268         (LauncherWindow::toggleWebGL):
269         (LauncherWindow::setupUI):
270
271 2010-02-25  Ben Murdoch  <benm@google.com>
272
273         Reviewed by Kenneth Rohde Christiansen.
274
275         The target element of a Touch should be the target where that touch originated, not where it is now.
276         https://bugs.webkit.org/show_bug.cgi?id=34585
277
278         * DumpRenderTree/qt/EventSenderQt.cpp:
279         (EventSender::addTouchPoint): Fix a bug where touch points were not being given unique ids.
280
281 2010-02-24  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
282
283         Reviewed by Kenneth Rohde Christiansen.
284
285         [Qt] QtLauncher has a border when running on QGraphicsView mode
286         https://bugs.webkit.org/show_bug.cgi?id=35352
287
288         Fix 2-pixels frame on each border of QtLauncher when running on QGraphicsView mode.
289
290         * QtLauncher/webview.cpp:
291         (WebViewGraphicsBased::WebViewGraphicsBased):
292
293 2010-02-23  Dirk Pranke  <dpranke@chromium.org>
294
295         Reviewed by David Levin.
296
297         When the run-chromium-webkit-tests code was landed and the code was
298         refactored into the 'port' package, I accidentally broke using
299         http_server.py or websocket_server.py as command-line scripts
300         (the constructors needed a port object they weren't getting). This
301         change fixes them so that --server start|stop actually works.
302
303         As a part of this, the two files need to be able to call port.get(),
304         but doing that is awkward from a file inside the package, so I moved
305         get() into factory.py and imported that into __init__.py so that
306         http_server.py and websocket_server.py can just import factory.
307
308         https://bugs.webkit.org/show_bug.cgi?id=35316
309
310         * Scripts/webkitpy/layout_tests/port/__init__.py:
311         * Scripts/webkitpy/layout_tests/port/factory.py:
312         * Scripts/webkitpy/layout_tests/port/http_server.py:
313         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
314
315 2010-02-24  Dirk Pranke  <dpranke@chromium.org>
316
317         Reviewed by David Levin.
318
319         Fix the function signature for check_sys_deps on the mac port, and
320         fix the ordering of port_obj.check_sys_deps() and
321         port_obj.start_helper() (helper needs to be started before we check
322         the system configuration).
323
324         http://bugs.webkit.org/show_bug.cgi?id=35367
325
326         * Scripts/webkitpy/layout_tests/port/mac.py:
327         * Scripts/webkitpy/layout_tests/port/test.py:
328         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
329
330 2010-02-24  James Robinson  <jamesr@chromium.org>
331
332         Reviewed by Eric Seidel.
333
334         Provide default username parameter to SVN.commit_with_message().
335
336         * Scripts/webkitpy/scm.py:
337
338 2010-02-24  Dirk Pranke  <dpranke@chromium.org>
339
340         Reviewed by Eric Siedel.
341
342         Check the proper directory for a WebKit SVN version (Chromium does
343         not check out the entire WebKit tree directly, but rather pulls
344         individual subdirectories. So, checking for the SVN version in
345         WebKit/WebCore rather than just in WebKit works more reliably across
346         different ports).
347
348         http://bugs.webkit.org/show_bug.cgi?id=35321
349
350         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
351
352 2010-02-24  Alexey Proskuryakov  <ap@apple.com>
353
354         Reviewed by Dan Bernstein.
355
356         https://bugs.webkit.org/show_bug.cgi?id=35357
357         Two editing tests fail after DumpRenderTree run loop changes
358
359         AppKit decided that it wanted to group all editing commands for some reason (and thus undo
360         reverted them all at once).
361
362         * DumpRenderTree/mac/DumpRenderTree.mm:
363         (dump): Reverted the change that made DumpRenderTree use -[NSApplication run].
364         (runTest): Ditto.
365         (-[DumpRenderTreeApplication isRunning]): Override isRunning with a function that always
366         returns YES. This is another way to make the Java plug-in work.
367
368 2010-02-23  Adam Roben  <aroben@apple.com>
369
370         Make commit-log-editor find just-added ChangeLog files
371
372         Fixes <http://webkit.org/b/35294> commit-log-editor doesn't find
373         just-added ChangeLog files
374
375         Reviewed by Dave Levin.
376
377         * Scripts/commit-log-editor:
378         (top level): Modified the regular expression that's used to find
379         modified ChangeLog files to also look for just-added ChangeLog files.
380
381 2010-02-24  Shinichiro Hamaji  <hamaji@chromium.org>
382
383         Reviewed by Darin Adler.
384
385         check-webkit-style false positive for WebCore forwarding header
386         https://bugs.webkit.org/show_bug.cgi?id=34604
387
388         * Scripts/webkitpy/style/checker.py:
389         * Scripts/webkitpy/style/checker_unittest.py:
390
391 2010-02-23  Alexey Proskuryakov  <ap@apple.com>
392
393         Reviewed by Mark Rowe.
394
395         https://bugs.webkit.org/show_bug.cgi?id=22602
396         Enable Java in DumpRenderTree (on Mac)
397
398         * DumpRenderTree/mac/DumpRenderTree.mm:
399         (exitApplicationRunLoop):
400         (dump):
401         (runTest):
402         DumpRenderTree now runs an NSApplication, not just an event loop. This way, the Java plug-in
403         can start without freezing.
404
405         * Scripts/run-webkit-tests: Compile java sources in LayputTests/java.
406
407 2010-02-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
408
409         Reviewed by Kenneth Rohde Christiansen.
410
411         [Qt] Need a final integration between QtLauncher and QGVLauncher
412         https://bugs.webkit.org/show_bug.cgi?id=35292
413
414         WebKit coding style fixes.
415
416         * QtLauncher/main.cpp:
417         (LauncherWindow::resetZoom):
418
419 2010-02-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
420
421         Reviewed by Kenneth Rohde Christiansen.
422
423         [Qt] Need a final integration between QtLauncher and QGVLauncher
424         https://bugs.webkit.org/show_bug.cgi?id=35292
425
426         Add cloneWindow feature to QtLauncher, when running on QGraphicsView mode.
427
428         * QtLauncher/main.cpp:
429         (LauncherWindow::LauncherWindow):
430         (LauncherWindow::~LauncherWindow):
431         (LauncherWindow::init):
432         (LauncherWindow::cloneWindow):
433         (LauncherWindow::setupUI):
434
435 2010-02-23  Dirk Pranke  <dpranke@chromium.org>
436
437         Reviewed by Dimitri Glazkov.
438
439         Fix handling of check_wdiff_install when wdiff isn't installed.
440
441         http://bugs.webkit.org/show_bug.cgi?id=35304
442
443         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
444
445 2010-02-23  Leandro Pereira  <leandro@profusion.mobi>
446
447         Reviewed by NOBODY.
448
449         Fix false positives for 'delete *pointer' statements.
450         http://webkit.org/b/35235
451
452         * WebKitTools/Scripts/webkitpy/style/processors/cpp.py:
453
454 2010-02-23  Shinichiro Hamaji  <hamaji@chromium.org>
455
456         Reviewed by Eric Seidel.
457
458         [Gtk] Implement layoutTestController.numberOfPages
459         https://bugs.webkit.org/show_bug.cgi?id=35228
460
461         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
462         (LayoutTestController::numberOfPages):
463
464 2010-02-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
465
466         Reviewed by Kenneth Rohde Christiansen.
467
468         [Qt] QtLauncher should not use internal JavaScriptCore and WebCore interfaces
469         https://bugs.webkit.org/show_bug.cgi?id=35248
470
471         * QtLauncher/QtLauncher.pro:
472         * QtLauncher/utils.h:
473
474 2010-02-23  Daniel Bates  <dbates@rim.com>
475
476         Reviewed by Eric Seidel.
477
478         https://bugs.webkit.org/show_bug.cgi?id=34439
479
480         Prompts a person for their SVN username if not already cached (by Subversion).
481
482         Currently, webkit-patch is unable to commit to the SVN repo. unless the
483         WebKit SVN username is already cached (from of a prior commit by hand)
484         because "svn commit" (called by webkit-patch) defaults to using the system
485         login name unless the username is already cached or specified on the
486         command line.
487
488         * Scripts/webkitpy/scm.py: Added methods SVN.has_authorization_for_realm and
489         modified SVN.commit_with_message to call it. Added optional username parameter
490         to method SVN.commit_with_message.
491         * Scripts/webkitpy/scm_unittest.py: Added unit test methods: SVNTest.test_commit_with_username,
492         SVNTest.test_has_authorization_for_realm, and SVNTest.test_not_have_authorization_for_realm.
493
494 2010-02-22  Dirk Pranke  <dpranke@chromium.org>
495
496         Reviewed by Eric Siedel.
497
498         Add more checking for missing binaries and packages to check_sys_deps()
499
500         https://bugs.webkit.org/show_bug.cgi?id=35062
501
502         * Scripts/webkitpy/layout_tests/port/base.py:
503         * Scripts/webkitpy/layout_tests/port/chromium.py:
504         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
505         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
506         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
507         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
508
509 2010-02-22  Shinichiro Hamaji  <hamaji@chromium.org>
510
511         Reviewed by David Levin.
512
513         [Gtk] check-webkit-style: GTK style should be allowed in WebKitTools/DumpRenderTree/gtk
514         https://bugs.webkit.org/show_bug.cgi?id=35229
515
516         * Scripts/webkitpy/style/checker.py:
517         * Scripts/webkitpy/style/checker_unittest.py:
518
519 2010-02-22  James Robinson  <jamesr@chromium.org>
520
521         Unreviewed. Adding myself to committers list.
522
523         * Scripts/webkitpy/committers.py:
524
525 2010-02-22  Simon Fraser  <simon.fraser@apple.com>
526
527         Reviewed by Darin Adler.
528
529         Remove DRT hack that turns off hardware acceleration with older QuickTimes
530         https://bugs.webkit.org/show_bug.cgi?id=35275
531         
532         Now that WebKit does a version check to avoid a QuickTime-related
533         crash (r55100), DumpRenderTree does not need to.
534
535         * DumpRenderTree/mac/DumpRenderTree.mm:
536         (resetDefaultsToConsistentValues):
537
538 2010-02-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
539
540         Reviewed by Kenneth Rohde Christiansen.
541
542         [Qt] Build the DRT in debug on Mac OS X
543
544         * DumpRenderTree/qt/DumpRenderTree.pro:
545
546 2010-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
547
548         Reviewed by Kenneth Rohde Christiansen.
549
550         [Qt] Add support for layout tests on Symbian
551         https://bugs.webkit.org/show_bug.cgi?id=31589
552
553         * DumpRenderTree/qt/DumpRenderTree.pro:
554         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
555         * DumpRenderTree/qt/main.cpp:
556         (main):
557
558 2010-02-20  Chris Jerdonek  <cjerdonek@webkit.org>
559
560         Reviewed by Adam Barth.
561
562         Moved simplejson into webkitpy/thirdparty directory.
563
564         https://bugs.webkit.org/show_bug.cgi?id=35196
565
566         * Scripts/run-chromium-webkit-tests:
567           - Added webkitpy/thirdparty to the script's search path.
568
569         * Scripts/webkitpy/thirdparty/simplejson: Copied from WebKitTools/simplejson.
570           - Copied simplejson directory.
571
572         * simplejson: Removed.
573         * simplejson/LICENSE.txt: Removed.
574         * simplejson/README.txt: Removed.
575         * simplejson/__init__.py: Removed.
576         * simplejson/_speedups.c: Removed.
577         * simplejson/decoder.py: Removed.
578         * simplejson/encoder.py: Removed.
579         * simplejson/jsonfilter.py: Removed.
580         * simplejson/scanner.py: Removed.
581
582 2010-02-20  Chris Jerdonek  <cjerdonek@webkit.org>
583
584         Reviewed by Adam Barth.
585
586         Moved BeautifulSoup to webkitpy/thirdparty directory.
587
588         https://bugs.webkit.org/show_bug.cgi?id=35195
589
590         * Scripts/webkitpy/BeautifulSoup.py: Removed.
591           - Moved to webkitpy/thirdparty.
592
593         * Scripts/webkitpy/bugzilla.py:
594           - Updated import statement.
595
596         * Scripts/webkitpy/bugzilla_unittest.py:
597           - Updated import statement.
598
599         * Scripts/webkitpy/buildbot.py:
600           - Updated import statement.
601
602         * Scripts/webkitpy/buildbot_unittest.py:
603           - Updated import statement.
604
605         * Scripts/webkitpy/statusserver.py:
606           - Updated import statement.
607
608         * Scripts/webkitpy/thirdparty/BeautifulSoup.py: Copied from WebKitTools/Scripts/webkitpy/BeautifulSoup.py.
609
610 2010-02-20  Chris Jerdonek  <cjerdonek@webkit.org>
611
612         Reviewed by Adam Barth.
613
614         Created a directory for third-party Python code, and moved
615         autoinstall.py into it.
616
617         https://bugs.webkit.org/show_bug.cgi?id=34540
618
619         * Scripts/webkitpy/__init__.py:
620           - Updated "import autoinstall" statement.
621
622         * Scripts/webkitpy/autoinstall.py: Removed.
623           - Moved to thirdparty/autoinstall.py.
624
625         * Scripts/webkitpy/thirdparty: Added.
626         * Scripts/webkitpy/thirdparty/__init__.py: Added.
627         * Scripts/webkitpy/thirdparty/autoinstall.py: Copied from WebKitTools/Scripts/webkitpy/autoinstall.py.
628
629 2010-02-20  Gustavo Noronha Silva  <gns@gnome.org>
630
631         Unreviewed, obvious fix for the python failure in our new buildbot
632         step:
633
634         http://build.webkit.org/builders/GTK Linux 32-bit Release/builds/9075/steps/API tests/logs/err.text
635
636         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
637
638 2010-02-19  Maciej Stachowiak  <mjs@apple.com>
639
640         Reviewed by David Levin.
641
642         Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
643         https://bugs.webkit.org/show_bug.cgi?id=35147
644
645         * Scripts/build-webkit: Handle new flag.
646
647 2010-02-19  Leandro Pereira  <leandro@profusion.mobi>
648
649         Reviewed by Shinichiro Hamaji.
650
651         [style-queue] should not complain about identifier names with underscores under WebKit/efl/ewk/
652         https://bugs.webkit.org/show_bug.cgi?id=35091
653
654         White list unix_hacker_style names in WebKit/efl/ewk because these
655         are used in the EFL API.
656
657         * Scripts/webkitpy/style/checker.py:
658          - Filter out readability/naming on WebKit/efl/ewk.
659
660 2010-02-19  Eric Seidel  <eric@webkit.org>
661
662         Reviewed by Adam Barth.
663
664         Split out "prepare-rollout" from "rollout" and make --complete-rollout default
665         https://bugs.webkit.org/show_bug.cgi?id=33745
666
667         * Scripts/webkitpy/commands/download.py:
668          - Add a new AbstractRolloutPrepCommand to share code between PrepareRollout and Rollout
669          - Add PrepareRollout
670         * Scripts/webkitpy/commands/download_unittest.py: Test PrepareRollout, remove CompleteRollout tests.
671         * Scripts/webkitpy/steps/__init__.py: include ReopenBugAfterRollout step.
672         * Scripts/webkitpy/steps/completerollout.py: Removed.
673         * Scripts/webkitpy/steps/options.py: remove complete_rollout
674         * Scripts/webkitpy/steps/reopenbugafterrollout.py: Added.
675
676 2010-02-19  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
677
678         Reviewed by Kenneth Rohde Christiansen.
679
680         [Qt] Need a final integration between QtLauncher and QGVLauncher
681         https://bugs.webkit.org/show_bug.cgi?id=35161
682
683         Add animated flip support to QtLauncher when running on QGraphicsView mode.
684
685         * QtLauncher/main.cpp:
686         (LauncherWindow::initializeView):
687         (LauncherWindow::setupUI):
688         * QtLauncher/webview.cpp:
689         (WebViewGraphicsBased::WebViewGraphicsBased):
690         (WebViewGraphicsBased::animatedFlip):
691         (WebViewGraphicsBased::animatedYFlip):
692         * QtLauncher/webview.h:
693         (WebViewGraphicsBased::setYRotation):
694         (WebViewGraphicsBased::yRotation):
695
696 2010-02-19  Andras Becsi  <abecsi@webkit.org>
697
698         Reviewed by Kenneth Rohde Christiansen.
699
700         [Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender, add results
701         for passing new tests and unskip the passing ones from the Skipped list.
702         https://bugs.webkit.org/show_bug.cgi?id=35159
703
704         * DumpRenderTree/qt/EventSenderQt.cpp:
705         (EventSender::textZoomIn):
706         (EventSender::textZoomOut):
707         * DumpRenderTree/qt/EventSenderQt.h:
708
709 2010-02-19  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
710
711         Reviewed by Eric Seidel.
712
713         [Qt] Clean-up the handling of HTML5 persistent data for LayoutTests
714         https://bugs.webkit.org/show_bug.cgi?id=35004
715
716         DumpRenderTreeQt.cpp calls QWebSettings::enablePersistentStorage which sets up 
717         and enables all HTML5 persistent data. All the other calls for setting the 
718         persistent path or enabling the persistent feature are redundant. 
719
720         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
721         (WebCore::WebPage::WebPage): No need to enable AppCache again.
722         * DumpRenderTree/qt/main.cpp:
723         (main): No need to setup and enable HTML5 LocalStorage again.
724
725 2010-02-19  Diego Gonzalez  <diego.gonzalez@openbossa.org>
726
727         Reviewed by Kenneth Rohde Christiansen.
728
729         Send the context menu event from contextClick() of EventSender
730         and do not show context menu in DRT.
731
732         LayoutTests:
733             fast/events/contextmenu-scrolled-page-with-frame.html
734
735         [Qt] DRT: Send context menu event from EventSender
736         https://bugs.webkit.org/show_bug.cgi?id=35131
737
738         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
739         (WebCore::DumpRenderTree::DumpRenderTree):
740         * DumpRenderTree/qt/EventSenderQt.cpp:
741         (EventSender::contextClick):
742
743 2010-02-18  Chris Jerdonek  <cjerdonek@webkit.org>
744
745         Reviewed by Shinichiro Hamaji.
746
747         Moved parsing-related code to a separate file. Also increased
748         the unit test coverage in some affected areas.
749
750         https://bugs.webkit.org/show_bug.cgi?id=34675
751
752         This revision contains no new functionality.
753
754         * Scripts/check-webkit-style:
755           - Adjusted to call check_webkit_style_parser().
756
757         * Scripts/webkitpy/style/checker.py:
758           - Added check_webkit_style_parser() to pass checker.py
759             configuration settings to optparser.py.
760           - Moved _create_usage() and the CommandOptionValues,
761             DefaultCommandOptionValues, ArgumentPrinter, and
762             ArgumentParser classes to optparser.py.
763
764         * Scripts/webkitpy/style/checker_unittest.py:
765           - Moved the ProcessorOptionsTest, ArgumentPrinterTest, and
766             ArgumentParserTest classes to optparser.py.
767           - Added the CheckWebKitStyleFunctionTest class to check
768             the check_webkit_style_configuration() and
769             check_webkit_style_parser() code paths.
770
771         * Scripts/webkitpy/style/optparser.py: Added.
772           - From checker.py, added _create_usage() and the
773             CommandOptionValues, DefaultCommandOptionValues,
774             ArgumentPrinter, and ArgumentParser classes.
775           - In the ArgumentParser constructor--
776             - Added all_categories as a required parameter.
777             - Removed the default value from the default_options parameter.
778
779         * Scripts/webkitpy/style/optparser_unittest.py: Added.
780           - From checker_unittest.py, added the ProcessorOptionsTest,
781             ArgumentPrinterTest, and ArgumentParserTest classes.
782           - Added the CreateUsageTest class to test _create_usage().
783
784         * Scripts/webkitpy/style/unittests.py:
785           - Added optparser_unittest import.
786
787 2010-02-18  Alexey Proskuryakov  <ap@apple.com>
788
789         Reviewed by Dan Bernstein.
790
791         https://bugs.webkit.org/show_bug.cgi?id=35134
792         <rdar://problem/7246280> Crash when a plugin calls NPN_SetStatus(0)
793
794         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
795         (testSetStatus):
796         (pluginInvoke):
797         Added a setStatus() method.
798
799 2010-02-18  Brady Eidson  <beidson@apple.com>
800
801         Reviewed by Sam Weinig.
802
803         Particularly constructed WebFrames can try to access a null HistoryItem
804         <rdar://problem/7638892> and https://bugs.webkit.org/show_bug.cgi?id=35063
805
806         Add the specific ability to test this API pattern. 
807
808         For now only on Mac, perhaps on the main Windows port later, probably not relevant for other ports.
809
810         * DumpRenderTree/LayoutTestController.cpp:
811         (apiTestNewWindowDataLoadBaseURLCallback):
812         (LayoutTestController::staticFunctions):
813         * DumpRenderTree/LayoutTestController.h:
814
815         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
816         (-[APITestDelegate initWithCompletionCondition:]):
817         (-[APITestDelegate webView:didFailLoadWithError:forFrame:]):
818         (-[APITestDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
819         (-[APITestDelegate webView:didFinishLoadForFrame:]):
820         (LayoutTestController::apiTestNewWindowDataLoadBaseURL): Create a WebView, do a loadData: in its
821           mainFrame, and synchronously wait for main load completion.
822
823         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
824         (LayoutTestController::apiTestNewWindowDataLoadBaseURL):
825         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
826         (LayoutTestController::apiTestNewWindowDataLoadBaseURL):
827         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
828         (LayoutTestController::apiTestNewWindowDataLoadBaseURL):
829
830 2010-02-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
831
832         Reviewed by Eric Seidel.
833
834         Teach resolve-ChangeLogs to act as a merge-driver for Git
835
836         https://bugs.webkit.org/show_bug.cgi?id=28721
837
838         To enable automatic merging of ChangeLog files, use the following command:
839
840         git config merge.changelog.driver "resolve-ChangeLogs --merge-driver %O %A %B"
841
842         The driver always works in "downstream" merge mode, meaning
843         it will always put the user's changelog entries on top.
844
845         * Scripts/resolve-ChangeLogs:
846
847 2009-12-05  Gustavo Noronha Silva  <gns@gnome.org>
848
849         Reviewed by Eric Seidel.
850
851         Enable running of GTK+ API tests.
852
853         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
854         * Scripts/run-gtk-tests: Added.
855
856 2010-02-18  Shinichiro Hamaji  <hamaji@chromium.org>
857
858         Reviewed by Adam Barth.
859
860         debug-safari doesn't pass --debug option to gdb-safari on MacOSX
861         https://bugs.webkit.org/show_bug.cgi?id=34411
862
863         * Scripts/webkitdirs.pm:
864
865 2010-02-18  Eric Seidel  <eric@webkit.org>
866
867         Reviewed by Adam Barth.
868
869         run-chromium-webkit-tests --platform=mac-leopard needs to run build-dumprendertree
870         https://bugs.webkit.org/show_bug.cgi?id=35053
871
872         * Scripts/webkitpy/layout_tests/port/base.py: Add script_path() function for finding scripts.
873         * Scripts/webkitpy/layout_tests/port/chromium.py: Remove unused argument.
874         * Scripts/webkitpy/layout_tests/port/mac.py:
875          - Make sure that calling webkit-build-directory works even if Scripts/ is not in the user's path.
876          - Call build-dumprendertree (and make sure it succeeds) before running the tests.
877
878 2010-02-16  Chris Jerdonek  <cjerdonek@webkit.org>
879
880         Reviewed by Shinichiro Hamaji.
881
882         Refactored check-webkit-style's ProcessorOptions class into two
883         classes. This revision contains no new functionality.
884
885         https://bugs.webkit.org/show_bug.cgi?id=34674
886
887         Divided the ProcessorOptions class into a CommandOptionValues
888         class (the result of parsing the command-line options) and
889         a StyleCheckerConfiguration class (which configures the main
890         StyleChecker).
891
892         * Scripts/check-webkit-style:
893           - Updated main() to convert the parsed command option values
894             to a StyleCheckConfiguration instance prior to constructing
895             a StyleChecker.
896
897         * Scripts/webkitpy/style/checker.py:
898           - Added check_webkit_style_configuration() to convert a
899             CommandOptionValues instance into a StyleCheckerConfiguration
900             instance.
901           - Renamed the ProcessorOptions class to CommandOptionValues.
902           - In the CommandOptionValues class--
903             - Replaced the filter_configuration attribute with the
904               simpler filter_rules attribute.
905             - Removed the max_reports_per_error attribute.
906             - Moved the is_reportable() method to the new
907               StyleCheckerConfiguration class.
908           - Removed the base_filter_rules attribute from the
909             DefaultCommandOptionValues class.
910           - In the ArgumentParser class--
911             - Added base_filter_rules to the constructor.
912             - Changed the parse() method to return a CommandOptionValues
913               instance instead of a ProcessorOptions instance.
914           - Created a StyleCheckerConfiguration class.
915             - Added the data attributes max_reports_per_category,
916               stderr_write, and verbosity.
917             - Added is_reportable() (moved from the ProcessorOptions
918               class) and write_style_error() (moved from the
919               DefaultStyleErrorHandler class).
920           - In the StyleChecker class--
921             - Replaced the ProcessorOptions options attribute with the
922               StyleCheckerConfiguration _configuration attribute.
923             - Removed the _stderr_write attribute.
924
925         * Scripts/webkitpy/style/checker_unittest.py:
926           - Updated the existing unit test classes as necessary.
927           - Added a StyleCheckerConfigurationTest class.
928
929         * Scripts/webkitpy/style/error_handlers.py:
930           - Updated the DefaultStyleErrorHandler class to accept a
931             StyleCheckerConfiguration instance instead of a ProcessorOptions
932             instance and an stderr_write method.
933
934         * Scripts/webkitpy/style/error_handlers_unittest.py:
935           - Updated the unit test classes as necessary.
936
937         * Scripts/webkitpy/style/filter.py:
938           - Addressed the FIXME in the FilterConfiguration class to change
939             the user_rules attribute to _user_rules (since it is now
940             accessed only internally).
941
942         * Scripts/webkitpy/style/filter_unittest.py:
943           - Updated to reflect the change from user_rules to _user_rules.
944
945 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
946
947         Reviewed by Eric Seidel.
948
949         Share the DRT values maxViewWidth/Height among ports
950         https://bugs.webkit.org/show_bug.cgi?id=34474
951
952         * DumpRenderTree/LayoutTestController.cpp:
953         (pageNumberForElementByIdCallback):
954         * DumpRenderTree/LayoutTestController.h:
955         (LayoutTestController::maxViewWidth):
956         (LayoutTestController::maxViewHeight):
957         * DumpRenderTree/gtk/DumpRenderTree.cpp:
958         (runTest):
959         * DumpRenderTree/mac/DumpRenderTree.mm:
960         (createWebViewAndOffscreenWindow):
961         (sizeWebViewForCurrentTest):
962         * DumpRenderTree/win/DumpRenderTree.cpp:
963         (dump):
964         (createWebViewAndOffscreenWindow):
965
966 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
967
968         Reviewed by Eric Seidel.
969
970         [Win] Implement test functions for printing
971         https://bugs.webkit.org/show_bug.cgi?id=34570
972
973         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
974         (LayoutTestController::pageNumberForElementById):
975         (LayoutTestController::numberOfPages):
976
977 2010-02-17  Fumitoshi Ukai  <ukai@chromium.org>
978
979         Reviewed by Eric Seidel.
980
981         websocket/tests/cookies/httponly-cookie.pl fails every time under run-chromium-webkit-tests
982         https://bugs.webkit.org/show_bug.cgi?id=35001
983
984         * Scripts/webkitpy/layout_tests/port/websocket_server.py: add -x flag to run pywebsocket.
985
986 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
987
988         Reviewed by Eric Seidel.
989
990         check-webkit-style: Misses variables that contain underscores.
991         https://bugs.webkit.org/show_bug.cgi?id=33724
992
993         - Check identifiers whose types are unsigned.
994         - Check bitfields properly.
995
996         * Scripts/webkitpy/style/processors/cpp.py:
997         * Scripts/webkitpy/style/processors/cpp_unittest.py:
998
999 2010-02-17  Shinichiro Hamaji  <hamaji@chromium.org>
1000
1001         Reviewed by Eric Seidel.
1002
1003         check-webkit-style should report the number of files checked
1004         https://bugs.webkit.org/show_bug.cgi?id=34971
1005
1006         * Scripts/check-webkit-style:
1007         * Scripts/webkitpy/style/checker.py:
1008         * Scripts/webkitpy/style/checker_unittest.py:
1009
1010 2010-02-17  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1011
1012         Reviewed by Ariya Hidayat.
1013
1014         Make possible Qt DRT to get total number of pages to be printed
1015
1016         LayoutTests:
1017             printing/numberOfPages.html
1018
1019         [Qt] DRT: Get total number of pages to be printed
1020         https://bugs.webkit.org/show_bug.cgi?id=34955
1021
1022         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1023         (LayoutTestController::numberOfPages):
1024         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1025
1026 2010-02-17  Xan Lopez  <xlopez@igalia.com>
1027
1028         Reviewed by Gustavo Noronha.
1029
1030         Update to use new property name.
1031
1032         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1033         (resetDefaultsToConsistentValues):
1034
1035 2010-02-17  Julien Chaffraix  <jchaffraix@webkit.org>
1036
1037         Reviewed by Ariya Hidayat.
1038
1039         Remove some warnings seen when building Qt
1040         https://bugs.webkit.org/show_bug.cgi?id=35017
1041
1042         Using a machine without the needed tools to build WebKit leads to
1043         several errors and warnings.
1044
1045         * Scripts/webkitdirs.pm: Refactored the code testing the command's
1046         presence into a commandExists routine. While doing so removed, stderr
1047         output as it usually does not give anything more than our message. Also
1048         added a Qt check for qmake that was missing.
1049
1050 2010-02-17  Xan Lopez  <xlopez@igalia.com>
1051
1052         Rubber-stamped by Gustavo Noronha.
1053
1054         Disable Java by default in DRT.
1055
1056         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1057         (resetDefaultsToConsistentValues):
1058
1059 2010-02-15  Chris Jerdonek  <cjerdonek@webkit.org>
1060
1061         Reviewed by Shinichiro Hamaji.
1062
1063         Some minor check-webkit-style code clean-ups.  This revision
1064         contains no new functionality.
1065
1066         https://bugs.webkit.org/show_bug.cgi?id=34932
1067
1068         * Scripts/check-webkit-style:
1069           - Replaced the call to webkit_argument_defaults() with a
1070             default parameter in the ArgumentParser constructor.
1071
1072         * Scripts/webkitpy/style/checker.py:
1073           - Removed the WEBKIT prefix from the default global variables.
1074           - Prefixed several of the global variables with an underscore
1075             to reflect that they are used internally.
1076           - Renamed _DEFAULT_FILTER_RULES to _BASE_FILTER_RULES.
1077           - Addressed a FIXME by changing the _PATH_RULES_SPECIFIER
1078             configuration from list-tuple pairs to list-list pairs.
1079           - Renamed style_categories() to _all_categories().
1080           - Renamed webkit_argument_defaults() to _check_webkit_style_defaults().
1081           - Renamed the ArgumentDefaults class to DefaultCommandOptionValues.
1082           - In the ArgumentParser class--
1083             - Renamed the doc_print attribute to stderr_write.
1084             - Other minor updates.
1085
1086         * Scripts/webkitpy/style/checker_unittest.py:
1087           - Updated the import statements and unit test classes as necessary.
1088           - Added assertions to test _PATH_RULES_SPECIFIER more fully.
1089
1090         * Scripts/webkitpy/style/error_handlers_unittest.py:
1091           - Updated the unit test classes as necessary.
1092           - Changed StyleErrorHandlerTestBase to store a list of error
1093             messages rather than just the last one.
1094
1095         * Scripts/webkitpy/style/filter.py:
1096           - Altered FilterConfiguration._path_rules_from_path()
1097             to convert the path_rules list to a tuple.
1098
1099         * Scripts/webkitpy/style/filter_unittest.py:
1100           - Updated the unit tests to reflect the change from tuples to
1101             lists in the _PATH_RULES_SPECIFIER configuration variable.
1102
1103 2010-02-16  Mark Rowe  <mrowe@apple.com>
1104
1105         Let's not check garbage in to common build scripts and hose the world now eh guys?
1106
1107         * Scripts/webkitdirs.pm:
1108
1109 2010-02-16  Eric Seidel  <eric@webkit.org>
1110
1111         Reviewed by Adam Barth.
1112
1113         re-factor Skipped list parsing code into multiple functions and unit test it
1114         https://bugs.webkit.org/show_bug.cgi?id=34986
1115
1116         * Scripts/test-webkitpy: Add new unit test.
1117         * Scripts/webkitpy/layout_tests/__init__.py: Copied from WebKitTools/QueueStatusServer/filters/__init__.py.
1118         * Scripts/webkitpy/layout_tests/port/mac.py: Split parsing function into multiple functions for testing.
1119         * Scripts/webkitpy/layout_tests/port/mac_unittest.py: Added.
1120
1121 2010-02-16  Xan Lopez  <xlopez@igalia.com>
1122
1123         Reviewed by Gustavo Noronha.
1124
1125         Enable 'auto-resize-window' in our DRT.
1126
1127         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1128         (resetDefaultsToConsistentValues):
1129
1130 2010-02-15  Martin Robinson  <mrobinson@webkit.org>
1131
1132         Reviewed by Darin Adler.
1133
1134         check-webkit-style should not complain about NULL sentinel in calls to g_strconcat and g_strjoin
1135         https://bugs.webkit.org/show_bug.cgi?id=34834
1136
1137         * Scripts/webkitpy/style/processors/cpp.py:
1138         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1139
1140 2010-02-12  Alexey Proskuryakov  <ap@apple.com>
1141
1142         Reviewed by Kevin Decker.
1143
1144         <rdar://problem/7130641> Browser objects identity is not preserved by Safari
1145
1146         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1147         (pluginInvoke): Added methods for checking object identity (via refcount).
1148
1149 2010-02-15  Robert Hogan  <robert@roberthogan.net>
1150
1151         Reviewed by Simon Hausmann.
1152
1153         [Qt] DRT: Support evaluateInWebInspector(), setTimelineProfilingEnabled().
1154
1155         Support LayoutTestController.evaluateInWebInspector(), setTimelineProfilingEnabled() in Qt DRT.
1156
1157         https://bugs.webkit.org/show_bug.cgi?id=33096
1158
1159         This allows the following tests to pass:
1160
1161         inspector/console-format-collections.html
1162         inspector/styles-iframe.html
1163         inspector/syntax-highlight-css.html
1164         inspector/syntax-highlight-javascript.html
1165         inspector/timeline-enum-stability.html
1166         inspector/timeline-layout.html
1167         inspector/timeline-mark-timeline.html
1168         inspector/timeline-paint.html
1169         inspector/timeline-parse-html.html
1170         inspector/timeline-recalculate-styles.html
1171         inspector/timeline-script-tag-1.html
1172         inspector/timeline-script-tag-2.html
1173         inspector/timeline-trivial.html
1174         inspector/cookie-resource-match.html
1175         inspector/elements-img-tooltip.html
1176         inspector/elements-panel-selection-on-refresh.html
1177         inspector/inspected-objects-not-overriden.html
1178         inspector/timeline-event-dispatch.html
1179         inspector/timeline-network-resource.html
1180         inspector/elements-panel-rewrite-href.html
1181         inspector/console-dir.html
1182         inspector/console-dirxml.html
1183         inspector/console-format.html
1184         inspector/console-tests.html
1185         inspector/elements-panel-structure.html
1186         inspector/evaluate-in-frontend.html
1187         inspector/console-clear.html
1188
1189         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1190         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1191         (WebCore::isWebInspectorTest):
1192         (WebCore::DumpRenderTree::open):
1193         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1194         (WebCore::DumpRenderTree::display):
1195         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1196         (LayoutTestController::closeWebInspector):
1197         (LayoutTestController::showWebInspector):
1198         (LayoutTestController::evaluateInWebInspector):
1199         (LayoutTestController::setTimelineProfilingEnabled):
1200         (LayoutTestController::display):
1201         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1202
1203 2010-02-14  Dirk Pranke  <dpranke@chromium.org>
1204
1205         Reviewed by Eric Seidel.
1206
1207         Update rebaseline-chromium-webkit-tests to work with the new code
1208         structure (port objects instead of path_utils and platform_utils).
1209
1210         Added a path_to_test_expectations_file() to the Port interface.
1211   
1212         Fixed a bug in the chromium_* platform implementations where the
1213         'target' option was assumed to be set.
1214
1215         * Scripts/rebaseline-chromium-webkit-tests:
1216         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1217         * Scripts/webkitpy/layout_tests/port/base.py:
1218         * Scripts/webkitpy/layout_tests/port/chromium.py:
1219         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1220         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1221         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1222         * Scripts/webkitpy/layout_tests/port/test.py:
1223         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1224
1225 2010-02-14  Eric Seidel  <eric@webkit.org>
1226
1227         Reviewed by Darin Adler.
1228
1229         webkit-build-directory misuses terms
1230         https://bugs.webkit.org/show_bug.cgi?id=34822
1231
1232         * Scripts/webkit-build-directory:
1233          - Add --top-level and --configuration options and make using one of them required.
1234         * Scripts/webkitpy/layout_tests/port/mac.py:
1235          - Use --top-level instead of --base.
1236
1237 2010-02-14  Chang Shu  <Chang.Shu@nokia.com>
1238
1239         Reviewed by Laszlo Gombos.
1240
1241         [Qt] Enable appcache feature.
1242         https://bugs.webkit.org/show_bug.cgi?id=34713
1243
1244         Re-land r54543 without the change in DumpRenderTree/qt/main.cpp.
1245         Persistent storage for AppCache is already initialized in
1246         DumpRenderTreeQt.cpp.
1247
1248         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1249         (WebCore::WebPage::WebPage):
1250
1251 2010-02-12  Chang Shu  <Chang.Shu@nokia.com>
1252
1253         Not Reviewed.
1254
1255         Change case of my email address as a work-around for the following bug.
1256         https://bugs.webkit.org/show_bug.cgi?id=34717
1257
1258         * Scripts/webkitpy/committers.py:
1259
1260 2010-02-12  Darin Adler  <darin@apple.com>
1261
1262         Ignore compiled Python in more of webkitpy.
1263
1264         * Scripts/webkitpy/style/processors: Added property svn:ignore.
1265
1266 2010-02-12  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1267
1268         Reviewed by Kenneth Rohde Christiansen.
1269
1270         Qt DRT now dump the frame loader callbacks when LayoutTestController()
1271         method is called.
1272
1273         LayoutTests:
1274             http/tests/security/mixedContent/data-url-script-in-iframe.html
1275             http/tests/security/mixedContent/empty-url-plugin-in-frame.html
1276             http/tests/security/mixedContent/insecure-css-in-iframe.html
1277             http/tests/security/mixedContent/insecure-iframe-in-iframe.html
1278             http/tests/security/mixedContent/insecure-image-in-iframe.html
1279             http/tests/security/mixedContent/insecure-plugin-in-iframe.html
1280             http/tests/security/mixedContent/insecure-script-in-iframe.html
1281             http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe.html
1282             http/tests/security/mixedContent/redirect-https-to-http-script-in-iframe.html
1283
1284         [Qt] Make possible Qt DRT dump frame load callbacks
1285         https://bugs.webkit.org/show_bug.cgi?id=34702
1286
1287         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1288         (LayoutTestController::reset):
1289         (LayoutTestController::dumpFrameLoadCallbacks):
1290         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1291
1292 2010-02-12  Simon Hausmann  <simon.hausmann@nokia.com>
1293
1294         Reviewed by Antti Koivisto.
1295
1296         Make QtLauncher somewhat useable on S60.
1297
1298         Show the window fullscreen to make scrollbars appear, resize
1299         the toolbar buttons to 16x16 to give more screen space to
1300         web content and moved the location lineedit into a separate
1301         line.
1302
1303         * QtLauncher/main.cpp:
1304         (LauncherWindow::LauncherWindow):
1305         * QtLauncher/mainwindow.cpp:
1306         (MainWindow::buildUI):
1307
1308 2010-02-12  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1309
1310         Reviewed by Kenneth Rohde Christiansen.
1311
1312         Support frameset flattening
1313         https://bugs.webkit.org/show_bug.cgi?id=32717
1314
1315         Add FrameSet Flattening support to Mac DRT.
1316
1317         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1318         (LayoutTestController::setFrameSetFlatteningEnabled):
1319         * DumpRenderTree/win/DumpRenderTree.cpp:
1320         (resetDefaultsToConsistentValues):
1321         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1322         (LayoutTestController::setXSSAuditorEnabled):
1323         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1324         (LayoutTestController::setFrameSetFlatteningEnabled):
1325         * DumpRenderTree/LayoutTestController.cpp:
1326         (setFrameSetFlatteningEnabledCallback):
1327         (LayoutTestController::staticFunctions):
1328         * DumpRenderTree/LayoutTestController.h:
1329         * DumpRenderTree/mac/DumpRenderTree.mm:
1330         (resetDefaultsToConsistentValues):
1331         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1332         (LayoutTestController::setFrameSetFlatteningEnabled):
1333
1334 2010-02-12  Dirk Pranke  <dpranke@chromium.org>
1335
1336         Reviewed by Eric Seidel.
1337
1338         Fix typos in driver_test.py 
1339
1340         https://bugs.webkit.org/show_bug.cgi?id=34810
1341
1342         * Scripts/webkitpy/layout_tests/driver_test.py:
1343
1344 2010-02-12  Simon Hausmann  <simon.hausmann@nokia.com>
1345
1346         Reviewed by Kenneth Rohde Christiansen.
1347
1348         [Qt] Make it possible to toggle the use of QGraphicsView in QtLauncher at run-time
1349         https://bugs.webkit.org/show_bug.cgi?id=34844
1350
1351         * QtLauncher/main.cpp:
1352         (LauncherWindow::LauncherWindow):
1353         (LauncherWindow::initializeView):
1354         (LauncherWindow::setupUI):
1355         * QtLauncher/webview.cpp:
1356         (WebViewGraphicsBased::WebViewGraphicsBased):
1357
1358 2010-02-11  Fumitoshi Ukai  <ukai@chromium.org>
1359
1360         Reviewed by Alexey Proskuryakov.
1361
1362         WebSocket ignores HttpOnly cookies, but should use in Handshake.
1363         https://bugs.webkit.org/show_bug.cgi?id=34289
1364
1365         Update pywebsocket to 0.4.8, which supports cgi directories.
1366         run-webkit-tests and run-webkit-websocketserver will run
1367         pywebsocket, specifying /websocket/test/cookies as cgi directory.
1368
1369         * Scripts/run-webkit-tests:
1370         * Scripts/run-webkit-websocketserver:
1371         * pywebsocket/mod_pywebsocket/standalone.py:
1372         * pywebsocket/setup.py:
1373
1374 2010-02-11  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1375
1376         Reviewed by Dan Bernstein.
1377
1378         [Mac] Duplicated setXSSAuditorEnabled preference at Mac DRT
1379         https://bugs.webkit.org/show_bug.cgi?id=34798
1380
1381         Remove duplicated setXSSAuditorEnabled preference at Mac DRT
1382
1383         * DumpRenderTree/mac/DumpRenderTree.mm:
1384         (resetDefaultsToConsistentValues):
1385
1386 2010-02-11  Eric Seidel  <eric@webkit.org>
1387
1388         No review, build fix only.
1389
1390         webkitdirs.pm has a crazy amount of duplicated feature detection code
1391         https://bugs.webkit.org/show_bug.cgi?id=34869
1392
1393         * Scripts/build-webkit: Fix typo which broke bots.
1394
1395 2010-02-11  Eric Seidel  <eric@webkit.org>
1396
1397         Reviewed by Adam Barth.
1398
1399         webkitdirs.pm has a crazy amount of duplicated feature detection code
1400         https://bugs.webkit.org/show_bug.cgi?id=34869
1401
1402         * Scripts/build-webkit: Use the new hotness.
1403         * Scripts/run-webkit-tests: ditto
1404         * Scripts/webkitdirs.pm: Remove a bunch of bad duplicate code.
1405         * Scripts/webkitperl/features.pm: Added.
1406          - Simplified the 10 methods in webkitdirs.pm into 2 exported methods in this new file.
1407
1408 2010-02-11  Daniel Bates  <dbates@rim.com>
1409
1410         Reviewed by Adam Barth.
1411
1412         https://bugs.webkit.org/show_bug.cgi?id=34830
1413
1414         Makes method User.prompt static and adds the parameter repeat
1415         to prompt the user up to repeat times.
1416
1417         * Scripts/test-webkitpy:
1418         * Scripts/webkitpy/bugzilla.py: Substituted method User.prompt for method raw_input.
1419         * Scripts/webkitpy/commands/upload.py: Ditto
1420         * Scripts/webkitpy/credentials.py: Ditto
1421         * Scripts/mock_bugzillatool.py: Updated prototype of MockUser.prompt to match User.prompt.
1422         * Scripts/webkitpy/user.py: Made method prompt static and added parameter repeat.
1423         * Scripts/webkitpy/user_unittest.py: Added.
1424
1425 2010-02-10  Yuzo Fujishima  <yuzo@google.com>
1426
1427         Reviewed by Darin Adler.
1428
1429         Allow underscored identifiers in CSSParser.cpp
1430
1431         Flex (http://flex.sourceforge.net/) uses identifiers named as yy_*.
1432         WebCore/css/CSSParser.cpp needs to handle some such identifiers.
1433         We should relax the style rule for the file to allow underscored identifiers.
1434
1435         https://bugs.webkit.org/show_bug.cgi?id=34787
1436
1437         * Scripts/webkitpy/style/checker.py:
1438
1439 2010-02-11  Eric Seidel  <eric@webkit.org>
1440
1441         Rubber-stamped by Adam Barth.
1442
1443         Remove DrawTest, the application I used when bringing up SVG support on the Mac.
1444         The code hasn't been touched (or used) in years.  No sense in keeping it in trunk.
1445
1446         * Scripts/build-drawtest: Removed.
1447         * Scripts/run-drawtest: Removed.
1448         * DrawTest: Removed.
1449
1450 2010-02-11  Eric Seidel  <eric@webkit.org>
1451
1452         Reviewed by Adam Barth.
1453
1454         Need a command to clear r+ on obsolete patches in the pending-commit queue.
1455         https://bugs.webkit.org/show_bug.cgi?id=34863
1456
1457         Unfortunately our http://webkit.org/pending-commit bugzilla query is not
1458         smart enough to ignore obsolete patches, so bugs show up there which are
1459         still open, but do not have patches ready for landing on them.
1460         This new command "clean-pending-commit" will remove r+ from obsolete patches
1461         in the pending-commit list.
1462
1463         * Scripts/test-webkitpy: Add grammar_unittest
1464         * Scripts/webkitpy/commands/upload.py: Add clean-pending-commit and make assign-to-committer ignore cq+'d patches.
1465         * Scripts/webkitpy/grammar.py: Add join_with_separators
1466         * Scripts/webkitpy/grammar_unittest.py: Added.
1467
1468 2010-02-11  Eric Seidel  <eric@webkit.org>
1469
1470         Reviewed by Adam Barth.
1471
1472         run-chromium-webkit-tests fails random pixel tests on Mac
1473         https://bugs.webkit.org/show_bug.cgi?id=34862
1474
1475         This is due to the fact that the Mac port has an
1476         invalid path to the image diff tool.  Currently it points
1477         to image_diff even though ImageDiff would be correct.  We
1478         can't change it to the right path yet without causing the
1479         script to hang.  ImageDiff expects to be long-running and
1480         be passed image data over stdin.  image_diff (chromium's fork)
1481         expects to be passed command line arguments.
1482         This fix works around the random failures by disabling pixel
1483         tests on mac and logging if the user was trying to run with pixel
1484         tests enabled.
1485
1486         * Scripts/webkitpy/layout_tests/port/mac.py:
1487
1488 2010-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
1489
1490         Reviewed by Adam Roben.
1491         Try to fix build breakage from r54665.
1492         
1493         * Scripts/check-for-global-initializers:
1494
1495 2010-02-11  Simon Hausmann  <simon.hausmann@nokia.com>
1496
1497         Reviewed by Tor Arne Vestbø.
1498
1499         Make it possible to toggle accelerated compositing from the menu
1500         at run-time.
1501
1502         * QtLauncher/main.cpp:
1503         (LauncherWindow::toggleAcceleratedCompositing):
1504         (LauncherWindow::setupUI):
1505
1506 2010-02-08  Maciej Stachowiak  <mjs@apple.com>
1507
1508         Reviewed by Cameron Zwarich.
1509
1510         Restore ENABLE_RUBY flag so vendors can ship with Ruby disabled if they choose.
1511         https://bugs.webkit.org/show_bug.cgi?id=34698
1512
1513         * Scripts/build-webkit:
1514
1515 2010-02-10  Dirk Pranke  <dpranke@chromium.org>
1516
1517         Reviewed by Eric Seidel.
1518
1519         Fix various minor bugs keeping run-chromium-webkit-tests from actually
1520         working on the linux and win ports of Chromium.
1521
1522         https://bugs.webkit.org/show_bug.cgi?id=34739
1523
1524         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
1525         * Scripts/webkitpy/layout_tests/port/__init__.py:
1526         * Scripts/webkitpy/layout_tests/port/base.py:
1527         * Scripts/webkitpy/layout_tests/port/chromium.py:
1528         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1529         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1530         * Scripts/webkitpy/layout_tests/port/http_server.py:
1531         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1532
1533 2010-02-10  Eric Seidel  <eric@webkit.org>
1534
1535         Reviewed by David Levin.
1536
1537         run-chromium-webkit-tests --platform=mac-leopard crashes when using a custom build directory
1538         https://bugs.webkit.org/show_bug.cgi?id=34817
1539
1540         This doesn't fix the root cause of us not
1541         correctly failing when support binaries are missing.
1542         This only causes the DumpRenderTree binary not to be
1543         missing in the custom build directory case.
1544         Later patches will make us correctly fail fast when
1545         support binaries (like DumpRenderTree or ImageDiff) are missing.
1546
1547         * Scripts/webkit-build-directory: Added.
1548          - Need a way to re-use the perl logic for finding build directories in non-perl scripts.
1549         * Scripts/webkitpy/layout_tests/port/base.py: Add a FIXME.
1550         * Scripts/webkitpy/layout_tests/port/mac.py:
1551          - Call webkit-build-directory to find the build directory instead of assuming "WebKitBuild"
1552         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Add FIXMEs.
1553
1554 2010-02-10  Kevin Watters  <kevinwatters@gmail.com>
1555
1556         Reviewed by Kevin Ollivier.
1557
1558         [wx] Add Windows complex text support.
1559         
1560         https://bugs.webkit.org/show_bug.cgi?id=34759
1561
1562         * wx/build/settings.py:
1563
1564 2010-02-10  Kevin Ollivier  <kevino@theolliviers.com>
1565
1566         [wx] Build fix. Add stub for new LayoutTestController method.
1567
1568         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1569         (LayoutTestController::numberOfPages):
1570
1571 2010-02-10  Csaba Osztrogonác  <ossy@webkit.org>
1572
1573         Unreviewed. Roll out r54626, because it broke GTK and Win build.
1574         https://bugs.webkit.org/show_bug.cgi?id=32717
1575
1576         * DumpRenderTree/LayoutTestController.cpp:
1577         (LayoutTestController::staticFunctions):
1578         * DumpRenderTree/LayoutTestController.h:
1579         * DumpRenderTree/mac/DumpRenderTree.mm:
1580         (resetDefaultsToConsistentValues):
1581         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1582
1583 2010-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1584
1585         Reviewed by Kenneth Rohde Christiansen.
1586
1587         Support frameset flattening
1588         https://bugs.webkit.org/show_bug.cgi?id=32717
1589
1590         Add FrameSet Flattening support to Mac DRT.
1591
1592         * DumpRenderTree/LayoutTestController.cpp:
1593         (setFrameSetFlatteningEnabledCallback):
1594         (LayoutTestController::staticFunctions):
1595         * DumpRenderTree/LayoutTestController.h:
1596         * DumpRenderTree/mac/DumpRenderTree.mm:
1597         (resetDefaultsToConsistentValues):
1598         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1599         (LayoutTestController::setFrameSetFlatteningEnabled):
1600
1601 2010-02-08  Jon Honeycutt  <jhoneycutt@apple.com>
1602
1603         <rdar://problem/7436875> Crash in Flash when visiting
1604         http://www.cctv.com/default.shtml (WER ID 819298200) [watson 2502260]
1605
1606         Reviewed by Darin Adler.
1607
1608         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1609         (executeScript):
1610         Moved to an earlier point in the file.
1611         (NPP_New):
1612         If the plug-in has an onDestroy attribute, store its value.
1613         (NPP_Destroy):
1614         If the plug-in has code to run on destruction, run it and free it.
1615
1616 2010-02-10  Diego Gonzalez  <diego.gonzalez@openbossa.org>
1617
1618         Reviewed by Kenneth Rohde Christiansen.
1619
1620         Implement pageNumberForElementById() method in Qt DRT LayoutTestController,
1621         to make Qt DRT able to get page number.
1622
1623         LayoutTests:
1624             printing/page-break-always.html
1625             printing/pageNumerForElementById.html
1626             printing/css2.1/page-break-before-000.html
1627             printing/css2.1/page-break-after-000.html
1628             printing/css2.1/page-break-after-004.html
1629             printing/css2.1/page-break-before-001.html
1630             printing/css2.1/page-break-after-001.html
1631             printing/css2.1/page-break-after-002.html
1632             printing/css2.1/page-break-before-002.html
1633             printing/css2.1/page-break-inside-000.html
1634
1635         [Qt] Make possible Qt DRT get a page number for element by ID
1636         https://bugs.webkit.org/show_bug.cgi?id=34777
1637
1638         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1639         (LayoutTestController::pageNumberForElementById):
1640         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1641
1642 2010-02-10  Andras Becsi  <abecsi@webkit.org>
1643
1644         Reviewed by Adam Barth.
1645
1646         Make run-iexploder-tests work on Linux.
1647         https://bugs.webkit.org/show_bug.cgi?id=34748
1648
1649         Extract the platform dependant Apache configuration checking code in httpd.pm to a separate function
1650         called getHTTPDConfigPathForTestDirectory and use run-launcher instead of run-safari if run on Linux.
1651
1652         * Scripts/run-iexploder-tests:
1653         * Scripts/webkitperl/httpd.pm:
1654
1655 2010-02-09  Csaba Osztrogonác  <ossy@webkit.org>
1656
1657         [Qt] Unreviewed. Roll-out r54543, because layout tests crash in debug mode.
1658         https://bugs.webkit.org/show_bug.cgi?id=34713
1659
1660         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1661         (WebCore::WebPage::WebPage):
1662         * DumpRenderTree/qt/main.cpp:
1663         (main):
1664
1665 2010-02-09  Alejandro G. Castro  <alex@igalia.com>
1666
1667         Unreviewed; added myself to committers
1668
1669         * Scripts/webkitpy/committers.py:
1670
1671 2010-02-09  Yael Aharon  <yael.aharon@nokia.com>
1672
1673         Reviewed by Kenneth Rohde Christiansen.
1674
1675         [Qt] Webkit in Qt does not have window.showModalDialog
1676         https://bugs.webkit.org/show_bug.cgi?id=25585
1677
1678         Set the modality flag when createWindow is called with window type WebWindowDialog.
1679
1680         * QtLauncher/main.cpp:
1681         (WebPage::createWindow):
1682
1683 2010-02-09  Andras Becsi  <abecsi@webkit.org>
1684
1685         Unreviewed trivial warning fix.
1686
1687         * Scripts/build-webkit:
1688
1689 2010-02-09 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>
1690
1691         Reviewed by Tor Arne Vestbø.
1692
1693         Add possibility of passing parameters to build-webkit by environment variable,
1694         because the buildbot slaves can't control the arguments.
1695
1696         * Scripts/build-webkit:
1697
1698 2010-02-09  Chang Shu  <Chang.Shu@nokia.com>
1699
1700         Reviewed by Laszlo Gombos.
1701
1702         [Qt] Enable appcache feature.
1703         https://bugs.webkit.org/show_bug.cgi?id=34713
1704
1705
1706         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1707         (WebCore::WebPage::WebPage):
1708         * DumpRenderTree/qt/main.cpp:
1709         (main):
1710
1711 2010-02-09  Shinichiro Hamaji  <hamaji@chromium.org>
1712
1713         Reviewed by Darin Adler.
1714
1715         Provide a way to get total number of pages to be printed
1716         https://bugs.webkit.org/show_bug.cgi?id=34699
1717
1718         * DumpRenderTree/LayoutTestController.cpp:
1719         (parsePageParameters):
1720         (pageNumberForElementByIdCallback):
1721         (numberOfPagesCallback):
1722         (LayoutTestController::staticFunctions):
1723         * DumpRenderTree/LayoutTestController.h:
1724         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1725         (LayoutTestController::numberOfPages):
1726         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1727         (LayoutTestController::numberOfPages):
1728         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1729         (LayoutTestController::numberOfPages):
1730
1731 2010-02-08  Alexey Proskuryakov  <ap@apple.com>
1732
1733         Reviewed by Darin Adler.
1734
1735         https://bugs.webkit.org/show_bug.cgi?id=34727
1736         Assertion crashes and freezes when plug-in property access results in an exception
1737
1738         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1739         (pluginGetProperty): Raise an exception when accessing a particular property.
1740         (pluginSetProperty): Ditto.
1741         (pluginInvoke): Added methods to get and set host object properties.
1742
1743 2010-02-08  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1744
1745         Reviewed by Ariya Hidayat.
1746
1747         [Qt] Backport No'am Rosenthal's frame rate measurement
1748
1749         * QtLauncher/main.cpp:
1750         (LauncherWindow::LauncherWindow):
1751         (LauncherApplication::handleUserOptions):
1752         * QtLauncher/webview.cpp:
1753         (WebViewGraphicsBased::WebViewGraphicsBased):
1754         (WebViewGraphicsBased::enableFrameRateMeasurement):
1755         (WebViewGraphicsBased::updateFrameRate):
1756         (WebViewGraphicsBased::paintEvent):
1757         * QtLauncher/webview.h:
1758
1759 2010-02-08  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1760
1761         Reviewed by Tor Arne Vestbø.
1762
1763         [Qt] Make overridePreference complain when it does not
1764         support the preference given.
1765
1766         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1767         (LayoutTestController::overridePreference):
1768
1769 2010-02-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1770
1771         Reviewed by Kenneth Rohde Christiansen.
1772
1773         [Qt] Set stdout/stderr to binary mode for DRT on Windows
1774
1775         This makes sure we don't end up with lots of CRLFs in the
1776         DRT output, which breaks tons of results. Matches what
1777         the Windows DRT does.
1778
1779         * DumpRenderTree/qt/main.cpp:
1780
1781 2010-02-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1782
1783         Reviewed by Kenneth Rohde Christiansen.
1784
1785         Build fix for Qt on Windows.
1786
1787         Don't use noreturn directly since it's a gcc attribute.
1788         Instead use the NO_RETURN macro from AlwaysInline.h
1789
1790         * QtLauncher/QtLauncher.pro:
1791         * QtLauncher/utils.h:
1792
1793 2010-02-05  Chris Jerdonek  <cjerdonek@webkit.org>
1794
1795         Reviewed by Shinichiro Hamaji.
1796
1797         Suppressed check-webkit-style's underscore check in Qt's autotests.
1798         Also made the path-specific filter check case-insensitive.
1799
1800         https://bugs.webkit.org/show_bug.cgi?id=34574
1801
1802         * Scripts/webkitpy/style/checker.py:
1803           - Added a list element to _PATH_RULES_SPECIFIER for
1804             directories that should be excluded from the
1805             "readability/naming" category (the category that relates to
1806             underscores in identifiers, for example).
1807
1808         * Scripts/webkitpy/style/checker_unittest.py:
1809           - Added an "end-to-end" test for "WebKit/qt/tests/".
1810
1811         * Scripts/webkitpy/style/filter.py:
1812           - Altered FilterConfiguration's should_check() method to
1813             check for path substring matches case-insensitively.
1814
1815         * Scripts/webkitpy/style/filter_unittest.py:
1816           - Added a test to check case-insensitive path substring matching.
1817
1818         * Scripts/webkitpy/style/processors/cpp.py:
1819           - Removed the hard-coded "WebKit/gtk/webkit/" path reference
1820             since this is now taken care of by the _PATH_RULES_SPECIFIER
1821             configuration variable.
1822
1823         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1824           - Removed the unit test for the GTK directory since this
1825             is now taken care of by the checker._PATH_RULES_SPECIFIER
1826             end-to-end tests.
1827
1828 2010-02-08  Leith Bade  <leith@leithalweapon.geek.nz>
1829
1830         Reviewed by Darin Adler.
1831
1832         Fixes: https://bugs.webkit.org/show_bug.cgi?id=34637
1833         Corrects the newline inserted into WebKitOutputDir, and WebKitLibrariesDir Windows
1834         environemnt variables when there is a space in the user's /home path.
1835
1836         * Scripts/webkitdirs.pm:
1837          - Added missing quotes around $sourceDir in argument list of cygpath in determineWindowsSourceDir().
1838
1839 2010-02-05  Alexey Proskuryakov  <ap@apple.com>
1840
1841         Reviewed by Oliver Hunt.
1842
1843         https://bugs.webkit.org/show_bug.cgi?id=34670
1844         TestNetscapePlugin should work with Firefox
1845
1846         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Default to Carbon if
1847         browser doesn't tell what it supports.
1848
1849 2010-02-05  Shinichiro Hamaji  <hamaji@chromium.org>
1850
1851         Reviewed by Gustavo Noronha Silva.
1852
1853         [Gtk] Implement layoutTestController.pageNumberForElementById
1854         https://bugs.webkit.org/show_bug.cgi?id=34572
1855
1856         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1857         (LayoutTestController::pageNumberForElementById):
1858
1859 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
1860
1861         Reviewed by Eric Seidel.
1862
1863         Add a simple test implementation and the WebKit Mac implementation
1864         for the layout_tests/port package. Also add a simple test driver of
1865         that interface.
1866
1867         https://bugs.webkit.org/show_bug.cgi?id=34511
1868
1869         * Scripts/webkitpy/layout_tests/driver_test.py: Added.
1870         * Scripts/webkitpy/layout_tests/port/__init__.py:
1871         * Scripts/webkitpy/layout_tests/port/mac.py: Added.
1872         * Scripts/webkitpy/layout_tests/port/test.py: Added.
1873
1874 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
1875
1876         Reviewed by Eric Siedel.
1877
1878         Refactor the port package into an object-oriented style and merge
1879         path_utils into it. We add a 'base' and a 'chromium' object to the
1880         port package; this will allow us to easily add new ports (like
1881         WebKit Mac).
1882
1883         https://bugs.webkit.org/show_bug.cgi?id=34511
1884
1885         * Scripts/rebaseline-chromium-webkit-tests:
1886         * Scripts/run-chromium-webkit-tests:
1887         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1888         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1889         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1890         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
1891         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
1892         * Scripts/webkitpy/layout_tests/port/__init__.py:
1893         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
1894         * Scripts/webkitpy/layout_tests/port/base.py: Added.
1895         * Scripts/webkitpy/layout_tests/port/chromium.py: Added.
1896         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1897         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1898         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1899         * Scripts/webkitpy/layout_tests/port/http_server.py:
1900         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1901         * Scripts/webkitpy/layout_tests/port/path_utils.py: Removed.
1902         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1903         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1904         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
1905         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
1906         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1907         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1908         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1909
1910 2010-01-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1911
1912         Reviewed by Dave Hyatt.
1913
1914         Implement flattening of framesets
1915         https://bugs.webkit.org/show_bug.cgi?id=32717
1916
1917         Add support for testing frame flattening with the Qt DRT
1918
1919         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1920         (LayoutTestController::setFrameSetFlatteningEnabled):
1921         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1922
1923 2010-02-03  Chris Jerdonek  <cjerdonek@webkit.org>
1924
1925         Reviewed by Shinichiro Hamaji.
1926
1927         Provided a way in check-webkit-style to specify filter rules
1928         on a per file or folder basis, via a configuration variable.
1929
1930         https://bugs.webkit.org/show_bug.cgi?id=33684
1931
1932         * Scripts/webkitpy/style/checker.py:
1933           - Added _PATH_RULES_SPECIFIER configuration variable.
1934           - In ProcessorOptions class--
1935             - Changed the CategoryFilter attribute to FilterConfiguration.
1936             - Added path parameter to is_reportable().
1937           - Renamed ArgumentDefaults filter_rules attribute to
1938             base_filter_rules.
1939           - Updated ArgumentPrinter class.
1940           - Added filter rule validation to ArgumentParser (instead of
1941             in CategoryFilter constructor).
1942
1943         * Scripts/webkitpy/style/checker_unittest.py:
1944           - Updated unit tests as necessary.
1945           - Added unit tests for PATH_RULES_SPECIFIER.
1946
1947         * Scripts/webkitpy/style/error_handlers.py:
1948           - Updated DefaultStyleErrorHandler to use file path when
1949             calling is_reportable().
1950
1951         * Scripts/webkitpy/style/error_handlers_unittest.py:
1952           - Updated unit tests as necessary.
1953
1954         * Scripts/webkitpy/style/filter.py:
1955           - Marked CategoryFilter internal with an underscore.
1956           - Removed argument validation from CategoryFilter.
1957           - Added FilterConfiguration class.
1958
1959         * Scripts/webkitpy/style/filter_unittest.py:
1960           - Updated CategoryFilterTest class.
1961           - Added FilterConfigurationTest unit tests.
1962
1963         * Scripts/webkitpy/style/processors/cpp.py:
1964           - Removed _is_test_filename() code.
1965           - Removed hard-coded path checks from check_include_line().
1966
1967         * Scripts/webkitpy/style/processors/cpp_unittest.py:
1968           - Removed three unit tests related to exempted files.
1969
1970 2010-02-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1971
1972         Reviewed by Ariya Hidayat.
1973
1974         [Qt] Apply the command line options as settings to the
1975         graphics system.
1976
1977         * QtLauncher/main.cpp:
1978         (LauncherWindow::LauncherWindow):
1979         (requiresGraphicsView):
1980         (LauncherApplication::handleUserOptions):
1981         * QtLauncher/webview.h:
1982         (WebViewGraphicsBased::setItemCacheMode):
1983
1984 2010-02-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1985
1986         Reviewed by Simon Hausmann.
1987
1988         Notify user that run-webkit-tests has to be run under Cygwin
1989
1990         The script will bail out if run under Windows shell or Msys.
1991
1992         * Scripts/run-webkit-tests:
1993         * Scripts/webkitdirs.pm:
1994
1995 2010-02-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1996
1997         Reviewed by Simon Hausmann.
1998
1999         [Qt] Generate convenience headers (QWebView, etc) using qmake
2000
2001         In Qt this is done using syncqt, but we use a pro-file instead
2002         that generates makefile-rules for each of the extra headers.
2003
2004         These extra headers are installed alongside the normal headers.
2005
2006         * Scripts/webkitdirs.pm: Run qmake and make on new API-DerivedSources
2007
2008 2010-02-05  Andras Becsi  <abecsi@webkit.org>
2009
2010         Unreviewed typo fix.
2011
2012         Fix wrong whitespace alignment introduced in r54342.
2013
2014         * Scripts/run-webkit-tests:
2015
2016 2010-02-04  Mark Rowe  <mrowe@apple.com>
2017
2018         Reviewed by Timothy Hatcher.
2019
2020         Build fix.  Remove a symbol corresponding to an inline function from the linker export
2021         file to prevent a weak external failure.
2022
2023         * Scripts/check-for-weak-vtables-and-externals: Renamed from WebKitTools/Scripts/check-for-weak-vtables.
2024         Teach the script how to detect weak external symbols so that these errors can be caught immediately
2025         in the future.
2026
2027 2010-02-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2028
2029         Rubberstamped by Oliver Hunt.
2030
2031         [Qt] Make it possible to choose whether the launcher should
2032         use the traditional QWidget based QWebView or the newer
2033         QGraphics based QGraphicsWebView on a QGraphicsView.
2034
2035         * QtLauncher/main.cpp:
2036         (LauncherWindow::LauncherWindow):
2037         (LauncherWindow::eventFilter):
2038         (LauncherWindow::loadStarted):
2039         (LauncherWindow::print):
2040         (LauncherWindow::screenshot):
2041         (LauncherWindow::setEditable):
2042         (LauncherWindow::setupUI):
2043         (main):
2044         * QtLauncher/webview.cpp:
2045         (WebViewGraphicsBased::WebViewGraphicsBased):
2046         (WebViewGraphicsBased::resizeEvent):
2047         (GraphicsWebView::mousePressEvent):
2048         (GraphicsWebView::contextMenuEvent):
2049         * QtLauncher/webview.h:
2050         (WebViewTraditional::WebViewTraditional):
2051         (GraphicsWebView::GraphicsWebView):
2052         (WebViewGraphicsBased::setPage):
2053
2054 2010-02-04  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2055
2056         Rubberstamped by Oliver Hunt.
2057
2058         [Qt] QtLauncher cleanup.
2059
2060         Refactor option handling out in utility functions and make the
2061         arguments more Qt compatible.
2062
2063         * QtLauncher/main.cpp:
2064         (requiresGraphicsView):
2065         (LauncherApplication::handleUserOptions):
2066         * QtLauncher/utils.cpp:
2067         (takeOptionValue):
2068         (formatKeys):
2069         (enumToKeys):
2070         (appQuit):
2071         * QtLauncher/utils.h:
2072
2073 2010-02-04  Andras Becsi  <abecsi@inf.u-szeged.hu>
2074
2075         Reviewed by Tor Arne Vestbø.
2076
2077         Implement a locking and scheduling mechanism for http testing sessions to be able
2078         to run multiple instances of run-webkit-tests parallel on the same machine.
2079         If a test session wants to run http tests and this feature is enabled, the pending
2080         sessions create lockfiles with sequential lock numbers. These locks are used to schedule
2081         the running test sessions in first come first served order. An exclusive lock ensures
2082         that the lock numbers are sequential to avoid deadlocks and starvation.
2083         Because the buildbot master specifies the flags used by slaves we need an environment
2084         variable too to be able to use the feature per-slave.
2085         Exporting WEBKIT_WAIT_FOR_HTTPD=1 before testing or using the --wait-for-httpd
2086         flag enables this feature, otherwise this patch has no effect on the testing whatsoever.
2087
2088         https://bugs.webkit.org/show_bug.cgi?id=33153
2089
2090         * Scripts/run-webkit-tests:
2091         * Scripts/webkitperl/httpd.pm:
2092
2093 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2094
2095         Reviewed by Simon Hausmann.
2096
2097         Make run-webkit-tests work under Cygwin for the Qt port
2098
2099         setPathForRunningWebKitApp() is implemented for the Qt port
2100         by using qmake to query for the location of the Qt libraries.
2101
2102         This requires the original environment (%ENV) to be untouched,
2103         so launchWithCurrentEnv() was refactored to launchWithEnv(),
2104         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
2105         instead. This has the added benefit of getting rid of the temp
2106         variables used for storing the current env.
2107
2108         openDumpTool() is also refactored a bit into platform-spesific,
2109         port-spesific, and generic environment variables.
2110
2111         Checks for undef was added a few places to fix Perl concat
2112         warnings when run-webkit-tests is aborted.
2113
2114         https://bugs.webkit.org/show_bug.cgi?id=33895
2115
2116         * Scripts/run-webkit-tests:
2117         * Scripts/webkitdirs.pm:
2118
2119 2010-02-04  Yuzo Fujishima  <yuzo@google.com>
2120
2121         Unreviewed.
2122
2123         Add Yuzo to the committers list.
2124
2125         * Scripts/webkitpy/committers.py:
2126
2127 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
2128
2129         Rubber-stamped by Eric Seidel.
2130
2131         Change "the Chromium name" to "the name of Google Inc." in the licenses
2132
2133         https://bugs.webkit.org/show_bug.cgi?id=34511
2134
2135         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2136         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2137         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2138         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2139         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2140         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
2141         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
2142         * Scripts/webkitpy/layout_tests/port/__init__.py:
2143         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
2144         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2145         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2146         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2147         * Scripts/webkitpy/layout_tests/port/http_server.py:
2148         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2149         * Scripts/webkitpy/layout_tests/port/path_utils.py:
2150         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2151         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2152         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
2153         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
2154         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2155         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2156         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2157
2158 2010-02-03  Dirk Pranke  <dpranke@chromium.org>
2159
2160         Rubber-stamped by Eric Siedel.
2161
2162         Rename files as part of refactoring the layout_tests package. All
2163         the platform_utils* module, the path_utils.py module, and
2164         the http server and web socket server modules are moved into a new
2165         port/ package.
2166
2167         https://bugs.webkit.org/show_bug.cgi?id=34511
2168
2169         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Removed.
2170         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Removed.
2171         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Removed.
2172         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Removed.
2173         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2174         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2175         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Removed.
2176         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Removed.
2177         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Removed.
2178         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Removed.
2179         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Removed.
2180         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Removed.
2181         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2182         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
2183         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
2184         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Removed.
2185         * Scripts/webkitpy/layout_tests/port: Added.
2186         * Scripts/webkitpy/layout_tests/port/__init__.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils.py.
2187         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py.
2188         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py.
2189         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py.
2190         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Copied from Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py.
2191         * Scripts/webkitpy/layout_tests/port/http_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server.py.
2192         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Copied from Scripts/webkitpy/layout_tests/layout_package/http_server_base.py.
2193         * Scripts/webkitpy/layout_tests/port/httpd2.pem: Copied from Scripts/webkitpy/layout_tests/layout_package/httpd2.pem.
2194         * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Copied from Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf.
2195         * Scripts/webkitpy/layout_tests/port/path_utils.py: Copied from Scripts/webkitpy/layout_tests/layout_package/path_utils.py.
2196         * Scripts/webkitpy/layout_tests/port/websocket_server.py: Copied from Scripts/webkitpy/layout_tests/layout_package/websocket_server.py.
2197         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2198         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
2199         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
2200         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2201         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2202         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2203
2204
2205 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
2206
2207         Rubber-stamped by Eric Seidel.
2208
2209         Roll back r53559 and r54084 again, because roll out didn't solve flakeyness on the Windows Test bots
2210         https://bugs.webkit.org/show_bug.cgi?id=34399
2211
2212         * Scripts/run-iexploder-tests:
2213         * Scripts/run-webkit-httpd:
2214         * Scripts/run-webkit-tests:
2215         * Scripts/webkitperl/httpd.pm: Added.
2216
2217 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
2218
2219         Rubber-stamped by Eric Seidel.
2220
2221         Roll out r53559 and r54084, because it might caused flakeyness on the Windows Test bots
2222
2223         * Scripts/run-iexploder-tests:
2224         * Scripts/run-webkit-httpd:
2225         * Scripts/run-webkit-tests:
2226         * Scripts/webkitperl/httpd.pm: Removed.
2227
2228 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
2229
2230         Rubber-stamped by Ariya Hidayat.
2231
2232         Roll back r53889 again, because roll out didn't solve flakeyness on the Windows Test bots
2233         https://bugs.webkit.org/show_bug.cgi?id=34399
2234
2235         * DumpRenderTree/win/EventSender.cpp:
2236         (buildModifierFlags):
2237         (mouseDownCallback):
2238         (mouseUpCallback):
2239         (keyDownCallback):
2240
2241 2010-02-03  Eric Seidel  <eric@webkit.org>
2242
2243         No review, just fixing copyrights.
2244
2245         Concerns were expressed about "The Chromium Authors" being
2246         a valid legal entity for copyright assignment in the WebKit repository,
2247         so this change removes all "The Chromium Authors".
2248
2249         I looked at the svn logs in src.chromium.org and failed to find any
2250         non-google contributions to these files, so they are all now
2251         marked as copyright "Google Inc" as all Google contributers assign
2252         copyright to "Google Inc" as part of their employment agreement.
2253
2254         * Scripts/rebaseline-chromium-webkit-tests:
2255         * Scripts/run-chromium-webkit-tests:
2256         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py:
2257         * Scripts/webkitpy/layout_tests/layout_package/http_server.py:
2258         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py:
2259         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2260         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2261         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
2262         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py:
2263         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py:
2264         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py:
2265         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py:
2266         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py:
2267         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2268         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2269         * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
2270         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
2271         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py:
2272         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2273         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
2274         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
2275         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2276         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2277         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2278
2279 2010-02-03  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2280
2281         Reviewed by Ariya Hidayat.
2282
2283         [Qt] QtLauncher, refactor argument handling in preparation of merge
2284         with QGVLauncher
2285
2286         * QtLauncher/main.cpp:
2287         (LauncherApplication::urls):
2288         (LauncherApplication::isRobotized):
2289         (LauncherApplication::applyDefaultSettings):
2290         (LauncherApplication::LauncherApplication):
2291         (LauncherApplication::formatKeys):
2292         (LauncherApplication::enumToKeys):
2293         (fail):
2294         (LauncherApplication::handleUserOptions):
2295         (main):
2296
2297 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
2298
2299         Rubber-stamped by Ariya Hidayat.
2300
2301         Rolling out r53889, because it might caused flakeyness on the Windows Test bots
2302         https://bugs.webkit.org/show_bug.cgi?id=34399
2303
2304         * DumpRenderTree/win/EventSender.cpp:
2305         (mouseDownCallback):
2306         (mouseUpCallback):
2307         (keyDownCallback):
2308
2309 2010-02-03  Csaba Osztrogonác  <ossy@webkit.org>
2310
2311         Reviewed by Ariya Hidayat.
2312
2313         [Qt] Fix pixel tests support.
2314         https://bugs.webkit.org/show_bug.cgi?id=27813
2315
2316         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2317         (WebCore::DumpRenderTree::open):
2318         (WebCore::DumpRenderTree::processLine):
2319          - Hash processing mechanism moved from DumpRenderTree::open to DumpRenderTree::processLine.
2320         (WebCore::DumpRenderTree::dump): Fixed and renamed variables.
2321
2322 2010-02-03  Kevin Watters  <kevinwatters@gmail.com>
2323
2324         Reviewed by Kevin Ollivier.
2325
2326         [wx] Enable JIT compilation for wx.
2327         
2328         https://bugs.webkit.org/show_bug.cgi?id=34536
2329
2330         * wx/build/settings.py:
2331
2332 2010-02-02  Kevin Ollivier  <kevino@theolliviers.com>
2333
2334         [wx] Build fix after introduction of pageNumberForElementById.
2335
2336         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2337         (LayoutTestController::pageNumberForElementById):
2338
2339 2010-02-02  Shu Chang  <Chang.Shu@nokia.com>
2340
2341         Unreviewed.
2342
2343         Add myself to list of committers.
2344
2345         * Scripts/webkitpy/committers.py:
2346
2347 2010-02-02  Chris Jerdonek  <cjerdonek@webkit.org>
2348
2349         Reviewed by Shinichiro Hamaji.
2350
2351         Moved filter-related check-webkit-style code into a separate
2352         filter module.
2353
2354         https://bugs.webkit.org/show_bug.cgi?id=34408
2355
2356         This is preparatory refactoring for Bug 33684, which will allow
2357         file and folder-specific filter rules.
2358
2359         * Scripts/webkitpy/style/checker.py:
2360           - Removed CategoryFilter class (moved to filter.py).
2361
2362         * Scripts/webkitpy/style/checker_unittest.py:
2363           - Removed CategoryFilter unit tests (moved to filter_unittest.py).
2364
2365         * Scripts/webkitpy/style/filter.py: Added.
2366           - Added CategoryFilter class (moved from checker.py).
2367
2368         * Scripts/webkitpy/style/filter_unittest.py: Added.
2369           - Added CategoryFilter unit tests (moved from checker_unittest.py).
2370
2371         * Scripts/webkitpy/style/unittests.py:
2372           - Added reference to filter_unittest.py.
2373
2374 2010-02-01  Chris Jerdonek  <cjerdonek@webkit.org>
2375
2376         Reviewed by Shinichiro Hamaji.
2377
2378         Addressed FIXME in check-webkit-style so that the carriage-return
2379         check will work for patches.
2380
2381         https://bugs.webkit.org/show_bug.cgi?id=34260
2382
2383         Also added support for limiting the number of errors reported
2384         per category, per file.
2385
2386         * Scripts/webkitpy/style/checker.py:
2387           - Added new "whitespace/carriage_return" category from common.py.
2388           - Added MAX_REPORTS_PER_CATEGORY dictionary.
2389           - Added max_reports_per_category attribute to ProcessorOptions class.
2390           - Refactored StyleChecker._process_file().
2391
2392         * Scripts/webkitpy/style/checker_unittest.py:
2393           - Updated ProcessorOptionsTest tests.
2394           - Added test to check MAX_REPORTS_PER_CATEGORY.
2395
2396         * Scripts/webkitpy/style/error_handlers.py:
2397           - Added support for suppressing the display of errors after
2398             reaching a per-category maximum (from max_reports_per_category).
2399
2400         * Scripts/webkitpy/style/error_handlers_unittest.py:
2401           - Added test for suppressing error display.
2402
2403         * Scripts/webkitpy/style/processors/common.py: Added.
2404           - Moved carriage-return check to new file.
2405
2406         * Scripts/webkitpy/style/processors/common_unittest.py: Added.
2407           - Added unit tests for carriage-return check.
2408
2409         * Scripts/webkitpy/style/unittests.py:
2410           - Added reference to common_unittest.py.
2411
2412 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
2413
2414         Reviewed by Eric Seidel.
2415
2416         Provide a way to get page number with layoutTestController
2417         https://bugs.webkit.org/show_bug.cgi?id=33840
2418
2419         * DumpRenderTree/LayoutTestController.cpp:
2420         (pageNumberForElementByIdCallback):
2421         (LayoutTestController::staticFunctions):
2422         * DumpRenderTree/LayoutTestController.h:
2423         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2424         (LayoutTestController::pageNumberForElementById):
2425         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2426         (LayoutTestController::pageNumberForElementById):
2427         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2428         (LayoutTestController::pageNumberForElementById):
2429
2430 2010-02-01  Shinichiro Hamaji  <hamaji@chromium.org>
2431
2432         Unreviewed fix for an invalid function call.
2433
2434         check-webkit-style: Remove filename parameter from all functions where no longer used
2435         https://bugs.webkit.org/show_bug.cgi?id=34249
2436
2437         * Scripts/webkitpy/style/checker.py:
2438
2439 2010-02-01  Diego Gonzalez  <diego.gonzalez@openbossa.org>
2440
2441         Reviewed by Kenneth Rohde Christiansen.
2442
2443         [Qt] DRT Provide global flag ability
2444         https://bugs.webkit.org/show_bug.cgi?id=34418
2445
2446         Add the globalFlag property to the Qt LayoutTestController to allow
2447         cross-domain indications.
2448
2449         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2450         (LayoutTestController::reset):
2451         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2452         (LayoutTestController::globalFlag):
2453         (LayoutTestController::setGlobalFlag):
2454
2455 2010-02-01  Brady Eidson  <beidson@apple.com>
2456
2457         Reviewed by Adele Peterson.
2458
2459         Crash in Safari opening new tabs to "same page"
2460         <rdar://problem/7593857> and https://bugs.webkit.org/show_bug.cgi?id=34444
2461
2462         Add a mode (Mac-only for now) that exercises the WebView SPI _loadBackForwardListFromOtherView:
2463
2464         * DumpRenderTree/LayoutTestController.cpp:
2465         (LayoutTestController::LayoutTestController):
2466         (setNewWindowsCopyBackForwardListCallback):
2467         (LayoutTestController::staticFunctions):
2468
2469         * DumpRenderTree/LayoutTestController.h:
2470         (LayoutTestController::newWindowsCopyBackForwardList):
2471         (LayoutTestController::setNewWindowsCopyBackForwardList):
2472
2473         * DumpRenderTree/mac/UIDelegate.mm:
2474         (-[UIDelegate webView:createWebViewWithRequest:]):
2475
2476 2010-02-01  Carol Szabo  <carol.szabo@nokia.com>
2477
2478         Unreviewed.
2479
2480         Add myself to list of committers.
2481
2482         * Scripts/webkitpy/committers.py:
2483
2484 2010-02-01  Nate Chapin  <japhet@chromium.org>
2485
2486         Rubber-stamped by David Levin.
2487
2488         Add myself to reviewer list.
2489
2490         * Scripts/webkitpy/committers.py:
2491
2492 2010-01-31  Chris Jerdonek  <cjerdonek@webkit.org>
2493
2494         Reviewed by Shinichiro Hamaji.
2495
2496         Moved style error handler code to their own classes, and
2497         related refactoring. Increased unit test code coverage of
2498         style error handling.
2499
2500         https://bugs.webkit.org/show_bug.cgi?id=34379
2501
2502         * Scripts/check-webkit-style:
2503           - Minor change: added error_count variable.
2504
2505         * Scripts/webkitpy/style/checker.py:
2506           - Renamed ProcessorOptions.should_report_error() to is_reportable().
2507           - In the StyleChecker class--
2508             - Removed _default_style_error_handler().
2509             - Added _increment_error_count().
2510             - Refactored to use DefaultStyleErrorHandler and
2511               PatchStyleErrorHandler constructors.
2512
2513         * Scripts/webkitpy/style/checker_unittest.py:
2514           - In the StyleStyleCheckerTest class--
2515             - Removed write_sample_error().
2516             - Removed test_default_style_error_handler().
2517
2518         * Scripts/webkitpy/style/error_handlers.py: Added.
2519           - Added DefaultStyleErrorHandler class.
2520           - Added PatchStyleErrorHandler class.
2521
2522         * Scripts/webkitpy/style/error_handlers_unittest.py: Added.
2523           - Added unit tests for DefaultStyleErrorHandler and
2524             PatchStyleErrorHandler.
2525
2526         * Scripts/webkitpy/style/unittests.py:
2527           - Added error_handlers unit tests.
2528
2529 2010-01-29  Mark Rowe  <mrowe@apple.com>
2530
2531         Rubber-stamped by Stephanie Lewis.
2532
2533         Fix run-leaks with newer versions of the leaks tool.
2534
2535         * Scripts/run-leaks:
2536
2537 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
2538
2539         Reviewed by Eric Siedel.
2540
2541         Top-level test drivers for running the Chromium port of run-webkit-tests
2542         and being able to rebaseline test results from the test bots.  The
2543         files in the Scripts directory are simply wrappers around the files
2544         in webkitpy/layout_tests for convenience.
2545  
2546         https://bugs.webkit.org/show_bug.cgi?id=31498
2547
2548         * Scripts/rebaseline-chromium-webkit-tests: Added.
2549         * Scripts/run-chromium-webkit-tests: Added.
2550         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Added.
2551         * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py: Added.
2552
2553 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
2554
2555         Reviewed by Eric Siedel.
2556
2557         Add in the second block of python code for the Chromium port
2558         of run-webkit-tests. These files execute different diffs to classify
2559         the various types of failures from a test.
2560
2561         * Scripts/webkitpy/layout_tests/test_types: Added.
2562         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Added.
2563         * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py: Added.
2564         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Added.
2565         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Added.
2566         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Added.
2567
2568 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
2569
2570         Reviewed by Eric Siedel.
2571
2572         Check in the first part of the Chromium Python port of the 
2573         run-webkit-tests test driver. The files under 
2574         layout_tests/layout_layout constitute most of the implementation;
2575         they can be roughly divided into code that parses the 
2576         "test_expectations.txt" file that describes how we expect tests to
2577         pass or fail, platform-specific hooks for the different Chromium 
2578         ports (in platform_utils*), code for parsing the output of the
2579         tests and generating results files and HTML and JSON for the
2580         dashboards, auxiliary scripts for starting and stopping HTTP and
2581         Web Socket servers, and then one of the actual driver files 
2582         (test_shell_thread). Code for actually parsing test output for 
2583         failures and the top-level driver scripts will follow shortly.
2584
2585         https://bugs.webkit.org/show_bug.cgi?id=31498
2586
2587         * Scripts/webkitpy/layout_tests: Added.
2588         * Scripts/webkitpy/layout_tests/layout_package: Added.
2589         * Scripts/webkitpy/layout_tests/layout_package/__init__.py: Added.
2590         * Scripts/webkitpy/layout_tests/layout_package/apache_http_server.py: Added.
2591         * Scripts/webkitpy/layout_tests/layout_package/http_server.py: Added.
2592         * Scripts/webkitpy/layout_tests/layout_package/http_server_base.py: Added.
2593         * Scripts/webkitpy/layout_tests/layout_package/httpd2.pem: Added.
2594           - scripts to start and stop apache. Note that the apache file
2595             generates a conf file dynamically, and we should switch to 
2596             using the same static conf file that the regular run-webkit-tests
2597             uses, and we can also use the same httpd2.pem file.
2598
2599         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Added.
2600         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: Added.
2601           - scripts to generate the JSON layout test dashboard and the
2602             flakiness dashboard
2603         * Scripts/webkitpy/layout_tests/layout_package/lighttpd.conf: Added.
2604           - default configuration for LigHTTPd (used on Windows)
2605         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Added.
2606           - utility class that implements progress bars on the console to
2607             be displayed while the tests are running
2608         * Scripts/webkitpy/layout_tests/layout_package/path_utils.py: Added.
2609           - various routines for manipulating paths and URIs
2610         * Scripts/webkitpy/layout_tests/layout_package/platform_utils.py: Added.
2611         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_linux.py: Added.
2612         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_mac.py: Added.
2613         * Scripts/webkitpy/layout_tests/layout_package/platform_utils_win.py: Added.
2614           - platform-specific aspects of the drivers (binary names, paths,
2615             process control, etc.)
2616         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Added.
2617           - code for parsing the 'test_expectations.txt' file to determine
2618             which tests are expected to fail (and how) on which platforms
2619         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Added.
2620           - code for handling different kinds of failures (generating output
2621             in the results, etc.)
2622         * Scripts/webkitpy/layout_tests/layout_package/test_files.py: Added.
2623           - code to gather the lists of tests
2624         * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py: Added.
2625           - code to actually execute tests via TestShell and process
2626             the output
2627         * Scripts/webkitpy/layout_tests/layout_package/websocket_server.py: Added.
2628           - scripts to start and stop the pywebsocket server
2629
2630 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
2631
2632         Reviewed by Eric Seidel.
2633
2634         Check in a copy of the simplejson library; it will be used by
2635         the Chromium port of run-webkit-tests.
2636         
2637         https://bugs.webkit.org/show_bug.cgi?id=31498
2638
2639         * simplejson: Added.
2640         * simplejson/LICENSE.txt: Added.
2641         * simplejson/README.txt: Added.
2642         * simplejson/__init__.py: Added.
2643         * simplejson/_speedups.c: Added.
2644         (ascii_escape_char):
2645         (ascii_escape_unicode):
2646         (ascii_escape_str):
2647         (py_encode_basestring_ascii):
2648         (init_speedups):
2649         * simplejson/decoder.py: Added.
2650         * simplejson/encoder.py: Added.
2651         * simplejson/jsonfilter.py: Added.
2652         * simplejson/scanner.py: Added.
2653
2654 2010-01-29  Dirk Pranke  <dpranke@chromium.org>
2655
2656         No review
2657
2658         Add myself to the committers list
2659
2660         * Scripts/webkitpy/committers.py:
2661
2662 2010-01-29  Jeremy Orlow  <jorlow@chromium.org>
2663
2664         Reviewed by Dimitri Glazkov.
2665
2666         A first step towards the Indexed Database API
2667         https://bugs.webkit.org/show_bug.cgi?id=34342
2668
2669         Add indexed database API.
2670
2671         * Scripts/build-webkit:
2672
2673 2010-01-29  Andras Becsi  <abecsi@webkit.org>
2674
2675         Reviewed by Alexey Proskuryakov.
2676
2677         Correct openHTTPD() to print requests to stdout if run-webkit-httpd is used.
2678         This fixes a regression introduced in r53559.
2679
2680         https://bugs.webkit.org/show_bug.cgi?id=34336
2681
2682         * Scripts/webkitperl/httpd.pm:
2683
2684 2010-01-28  Jon Honeycutt  <jhoneycutt@apple.com>
2685
2686         MSAA: Crash when posting a notification for a detached object
2687
2688         https://bugs.webkit.org/show_bug.cgi?id=34309
2689         <rdar://problem/7409759>
2690
2691         Reviewed by Darin Adler.
2692
2693         * DumpRenderTree/AccessibilityController.h:
2694         Declare new functions. Add new members to store the event hook and the
2695         mapping of accessibility elements to their JS callbacks.
2696
2697         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2698         (AccessibilityController::notificationReceived):
2699         Stubbed.
2700         (AccessibilityController::addNotificationListener):
2701         Stubbed.
2702
2703         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2704         (AccessibilityController::notificationReceived):
2705         Stubbed.
2706         (AccessibilityController::addNotificationListener):
2707         Stubbed.
2708
2709         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2710         (AccessibilityController::AccessibilityController):
2711         Initialize the event hook.
2712         (AccessibilityController::~AccessibilityController):
2713         Remove the event hook. Unprotect all of the JS functions that are stored
2714         in the map.
2715         (logEventProc):
2716         Clean-up a variable.
2717         (stringEvent):
2718         Return a string description of the MSAA event code.
2719         (notificationListenerProc):
2720         Get the accessible object from the event, and query it for IAccessible.
2721         Call the AccessibilityController's notificationReceived().
2722         (comparableObject):
2723         Use QueryService to obtain the IAccessibleComparable for the
2724         IServiceProvider.
2725         (AccessibilityController::notificationReceived):
2726         Iterate the map of objects that have registered for notification
2727         callbacks. Query each for IServiceProvider, then use comparableObject()
2728         to get an IAccessibleComparable. If we find an object matching the
2729         notified object, call its callback, passing the event that was received.
2730         (AccessibilityController::addNotificationListener):
2731         If we have not created the event hook, create it. Protect the JS
2732         callback function object, and add the object and its callback to our
2733         map.
2734
2735         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2736         (AccessibilityUIElement::addNotificationListener):
2737         Call through to the AccessibilityController's addNotificationListener().
2738
2739         * DumpRenderTree/win/DumpRenderTreeWin.h:
2740         Add an extern declaration for the shared FrameLoadDelegate extern, so we
2741         can access it from AccessibilityController.
2742
2743         * DumpRenderTree/win/FrameLoadDelegate.h:
2744         (FrameLoadDelegate::accessibilityController):
2745         Return the AccessibilityController.
2746
2747 2010-01-29  Shinichiro Hamaji  <hamaji@chromium.org>
2748
2749         Reviewed by Darin Adler.
2750
2751         prepare-ChangeLog outputs useless messages for a nonexistent bug ID
2752         https://bugs.webkit.org/show_bug.cgi?id=34313
2753
2754         * Scripts/prepare-ChangeLog:
2755
2756 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2757
2758         Rubberstamped by Simon Hausmann.
2759
2760         [Qt] Separate implementation from class definition.
2761
2762         * QtLauncher/main.cpp:
2763         (LauncherWindow::webView):
2764         (LauncherWindow::LauncherWindow):
2765         (LauncherWindow::~LauncherWindow):
2766         (LauncherWindow::keyPressEvent):
2767         (LauncherWindow::grabZoomKeys):
2768         (LauncherWindow::sendTouchEvent):
2769         (LauncherWindow::eventFilter):
2770         (LauncherWindow::loadStarted):
2771         (LauncherWindow::loadFinished):
2772         (LauncherWindow::showLinkHover):
2773         (LauncherWindow::zoomIn):
2774         (LauncherWindow::zoomOut):
2775         (LauncherWindow::resetZoom):
2776         (LauncherWindow::toggleZoomTextOnly):
2777         (LauncherWindow::print):
2778         (LauncherWindow::screenshot):
2779         (LauncherWindow::setEditable):
2780         (LauncherWindow::dumpHtml):
2781         (LauncherWindow::selectElements):
2782         (LauncherWindow::setTouchMocking):
2783         (LauncherWindow::newWindow):
2784         (LauncherWindow::setupUI):
2785
2786 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2787
2788         Reviewed by Ariya Hidayat.
2789
2790         [Qt] On Maemo5, a click/touch in the location bar (when unfocused)
2791         should result in all text selected.
2792
2793         * QtLauncher/locationedit.cpp:
2794         (LocationEdit::focusInEvent):
2795         * QtLauncher/locationedit.h:
2796
2797 2010-01-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2798
2799         Reviewed by Ariya Hidayat.
2800
2801         [Qt] Show progress reaching 100% for loads.
2802
2803         * QtLauncher/locationedit.cpp:
2804         (LocationEdit::LocationEdit):
2805         (LocationEdit::setProgress):
2806         (LocationEdit::reset):
2807         (LocationEdit::paintEvent):
2808         * QtLauncher/locationedit.h:
2809
2810 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
2811
2812         Reviewed by Kenneth Rohde Christiansen.
2813
2814         [Qt] Disable the QtLauncher statusbar on Maemo
2815
2816         https://bugs.webkit.org/show_bug.cgi?id=34330
2817
2818         * QtLauncher/main.cpp:
2819         (LauncherWindow::showLinkHover):
2820         (LauncherWindow::selectElements):
2821
2822 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
2823
2824         Reviewed by Kenneth Rohde Christiansen.
2825
2826         [Qt] Display page loading progress inside the QtLauncher location bar
2827
2828         https://bugs.webkit.org/show_bug.cgi?id=34210
2829
2830         * QtLauncher/QtLauncher.pro:
2831         * QtLauncher/locationedit.cpp: Added.
2832         (LocationEdit::LocationEdit):
2833         (LocationEdit::setProgress):
2834         (LocationEdit::paintEvent):
2835         * QtLauncher/locationedit.h: Added.
2836         * QtLauncher/mainwindow.cpp:
2837         (MainWindow::buildUI):
2838         * QtLauncher/mainwindow.h:
2839
2840 2010-01-29  Andreas Kling  <andreas.kling@nokia.com>
2841
2842         Reviewed by Kenneth Rohde Christiansen.
2843
2844         [Qt] Add support for Maemo zoom keys in QtLauncher
2845
2846         https://bugs.webkit.org/show_bug.cgi?id=34160
2847
2848         * QtLauncher/main.cpp:
2849         (LauncherWindow::LauncherWindow):
2850         (LauncherWindow::~LauncherWindow):
2851         (LauncherWindow::keyPressEvent):
2852         (LauncherWindow::grabZoomKeys):
2853
2854 2010-01-29  Benjamin Poulain  <benjamin.poulain@nokia.com>
2855
2856         Reviewed by Kenneth Rohde Christiansen.
2857
2858         [Qt] Implement the display() method of the layout test controller
2859         https://bugs.webkit.org/show_bug.cgi?id=34258
2860
2861         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2862         (WebCore::DumpRenderTree::DumpRenderTree):
2863         (WebCore::DumpRenderTree::showPage):
2864         (WebCore::DumpRenderTree::hidePage):
2865         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2866         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2867         (LayoutTestController::reset):
2868         (LayoutTestController::display):
2869         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2870
2871 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
2872
2873         [wx] Build fix for MSW, use ThreadingWin.cpp as the Windows pthreads implementation
2874         implements pthread_t in a way that makes it impossible to check its validity,
2875         which is needed by ThreadingPthreads.cpp.
2876
2877         * DumpRenderTree/wscript:
2878         * wx/build/settings.py:
2879
2880 2010-01-28  Andras Becsi  <abecsi@webkit.org>
2881
2882         Adding myself to the committer list. No review needed.
2883
2884         * Scripts/webkitpy/committers.py:
2885
2886 2010-01-28  Hayato Ito  <hayato@chromium.org>
2887
2888         Reviewed by David Levin.
2889
2890         Remove NULL char from input JS file because 'grep' fails if the file contains NULL char.
2891
2892         https://bugs.webkit.org/show_bug.cgi?id=34252
2893
2894         * Scripts/make-script-test-wrappers:
2895
2896 2010-01-28  Kevin Ollivier  <kevino@theolliviers.com>
2897
2898         [wx] Build fix after removal of the zlib image decoder.
2899
2900         * wx/build/settings.py:
2901
2902 2010-01-28  Csaba Osztrogonác  <ossy@webkit.org>
2903
2904         [Qt] Unreviewed, roll out r54000.
2905
2906         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2907         (WebCore::DumpRenderTree::DumpRenderTree):
2908         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2909         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2910         (LayoutTestController::reset):
2911         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2912         (LayoutTestController::display):
2913
2914 2010-01-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
2915
2916         Reviewed by Kenneth Rohde Christiansen.
2917
2918         [Qt] Implement the display() method of the layout test controller
2919         https://bugs.webkit.org/show_bug.cgi?id=34258
2920
2921         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2922         (WebCore::DumpRenderTree::DumpRenderTree):
2923         (WebCore::DumpRenderTree::showPage):
2924         (WebCore::DumpRenderTree::hidePage):
2925         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2926         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2927         (LayoutTestController::reset):
2928         (LayoutTestController::display):
2929         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2930
2931 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
2932
2933         Reviewed by Shinichiro Hamaji.
2934
2935         Eliminated the filename parameter from functions in
2936         check-webkit-style's cpp.py where it is no longer used.
2937
2938         https://bugs.webkit.org/show_bug.cgi?id=34249
2939
2940         * Scripts/webkitpy/style/processors/cpp.py:
2941           - Reduced number of occurrences of "filename" variable from
2942             approximately 200 to 120.
2943
2944         * Scripts/webkitpy/style/processors/cpp_unittest.py:
2945           - Refactored unit tests as necessary to accommodate changes to cpp.py.
2946           - Fixed bug in CppStyleTestBase.perform_include_what_you_use()
2947             where the incorrect file extension was getting passed to
2948             cpp_style.check_language().
2949
2950 2010-01-28  Chris Jerdonek  <cjerdonek@webkit.org>
2951
2952         Reviewed by Shinichiro Hamaji.
2953
2954         In check-webkit-style, eliminated the dependency of
2955         processors/cpp_unittest.py on checker.py.
2956
2957         https://bugs.webkit.org/show_bug.cgi?id=34205
2958
2959         * Scripts/webkitpy/style/checker.py:
2960           - Addressed FIXME by removing STYLE_CATEGORIES data.
2961           - Added style_categories().
2962
2963         * Scripts/webkitpy/style/checker_unittest.py:
2964           - Minor changes.
2965
2966         * Scripts/webkitpy/style/processors/cpp.py:
2967           - Added categories attribute to CppProcessor class (data
2968             was originally checker.STYLE_CATEGORIES).
2969
2970         * Scripts/webkitpy/style/processors/cpp_unittest.py:
2971           - Addressed FIXME by eliminating "import" from checker.py.
2972
2973 2010-01-28  Anton Muhin  <antonm@chromium.org>
2974
2975         Reviewed by Shinichiro Hamaji.
2976
2977         Improve treatment of conditions and rest of the line for if, else, switch and alikes
2978         https://bugs.webkit.org/show_bug.cgi?id=34173
2979
2980         * Scripts/webkitpy/style/cpp_style.py:
2981         * Scripts/webkitpy/style/cpp_style_unittest.py:
2982
2983 2010-01-28  Joe Mason  <jmason@rim.com>
2984
2985         Reviewed by Adam Barth.
2986
2987         Limit login retries to 5
2988         https://bugs.webkit.org/show_bug.cgi?id=34193
2989
2990         * Scripts/webkitpy/bugzilla.py:
2991
2992 2010-01-27  Martin Robinson  <mrobinson@webkit.org>
2993
2994         Adding myself to the committer list. No review necessary.
2995
2996         * Scripts/webkitpy/committers.py:
2997
2998 2010-01-27  George Wright  <gwright@rim.com>
2999
3000         Reviewed by Adam Treat.
3001
3002         https://bugs.webkit.org/show_bug.cgi?id=34216
3003
3004         Add missing include for wtf/Platform.h
3005
3006         * DumpRenderTree/AccessibilityController.h:
3007
3008 2010-01-27  Diego Gonzalez  <diego.gonzalez@openbossa.org>
3009
3010         Reviewed by Kenneth Rohde Christiansen.
3011
3012         [Qt] DRT Provide worker thread ability to track counters
3013         https://bugs.webkit.org/show_bug.cgi?id=34221
3014
3015         Implement workerThreadCount() in LayoutTestController of Qt DRT
3016
3017         Tests:
3018         fast/workers/dedicated-worker-lifecycle.html
3019         fast/workers/shared-worker-frame-lifecycle.html
3020         fast/workers/shared-worker-lifecycle.html
3021         fast/workers/worker-lifecycle.html
3022
3023         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3024         (LayoutTestController::workerThreadCount):
3025         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3026
3027 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3028
3029         Rubberstamped by Simon Hausmann.
3030
3031         [Qt] QtLauncher refactoring:
3032
3033         Make the LauncherWindow depend less on the view, so that more
3034         code can be shared in near future.
3035
3036         * QtLauncher/main.cpp:
3037         (LauncherWindow::sendTouchEvent):
3038         (LauncherWindow::loadFinished):
3039         (LauncherWindow::zoomIn):
3040         (LauncherWindow::zoomOut):
3041         (LauncherWindow::resetZoom):
3042         (LauncherWindow::toggleZoomTextOnly):
3043         (LauncherWindow::dumpHtml):
3044         (LauncherWindow::selectElements):
3045         (LauncherWindow::setupUI):
3046
3047 2010-01-27  Kinuko Yasuda  <kinuko@chromium.org>
3048
3049         Reviewed by Eric Seidel.
3050
3051         Correctly handle the KeyLocation argument that has been introduced
3052         recently to test location-dependent key events in EventSender.keyDown.
3053         http://bugs.webkit.org/show_bug.cgi?id=28247
3054
3055         Test: fast/events/keydown-numpad-keys.html
3056
3057         * DumpRenderTree/gtk/EventSender.cpp:
3058         (keyDownCallback):
3059
3060 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3061
3062         Rubberstamped by Simon Hausmann.
3063
3064         [Qt] QtLauncher refactoring:
3065
3066         Move out code from the MainWindow (renamed to LauncherWindow)
3067         that is not depending on the view, and add it to a new class
3068         called MainWindow.
3069
3070         * QtLauncher/QtLauncher.pro:
3071         * QtLauncher/main.cpp:
3072         (LauncherWindow::LauncherWindow):
3073         (LauncherWindow::eventFilter):
3074         (LauncherWindow::loadStarted):
3075         (LauncherWindow::loadFinished):
3076         (LauncherWindow::newWindow):
3077         (LauncherWindow::setupUI):
3078         (WebPage::createWindow):
3079         (main):
3080         * QtLauncher/mainwindow.cpp: Added.
3081         (MainWindow::MainWindow):
3082         (MainWindow::buildUI):
3083         (MainWindow::page):
3084         (MainWindow::setAddressUrl):
3085         (MainWindow::addCompleterEntry):
3086         (MainWindow::load):
3087         (MainWindow::changeLocation):
3088         (MainWindow::openFile):
3089         * QtLauncher/mainwindow.h: Added.
3090
3091 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3092
3093         Rubberstamped by Simon Hausmann.
3094
3095         [Qt] QtLauncher, coding style fixes.
3096
3097         * QtLauncher/main.cpp:
3098         (MainWindow::MainWindow):
3099         (MainWindow::sendTouchEvent):
3100         (MainWindow::eventFilter):
3101         (MainWindow::loadURL):
3102         (MainWindow::setupUI):
3103         (WebPage::createPlugin):
3104
3105 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3106
3107         Rubberstamped by Simon Hausmann.
3108
3109         [Qt] QtLauncher refactoring, separating the webview and
3110         adding a QGraphicsWebView based version.
3111
3112         * QtLauncher/QtLauncher.pro:
3113         * QtLauncher/main.cpp:
3114         (MainWindow::MainWindow):
3115         * QtLauncher/webpage.h:
3116         * QtLauncher/webview.cpp: Added.
3117         (createContextMenu):
3118         (WebViewGraphicsBased::mousePressEvent):
3119         (WebViewTraditional::mousePressEvent):
3120         (WebViewGraphicsBased::contextMenuEvent):
3121         (WebViewTraditional::contextMenuEvent):
3122         * QtLauncher/webview.h: Added.
3123         (WebViewGraphicsBased::WebViewGraphicsBased):
3124         (WebViewTraditional::WebViewTraditional):
3125
3126 2010-01-27  Alexander Pavlov  <apavlov@chromium.org>
3127
3128         Adding myself as committer. No review necessary.
3129
3130         * Scripts/webkitpy/committers.py:
3131
3132 2010-01-27  Eric Seidel  <eric@webkit.org>
3133
3134         Reviewed by Darin Adler.
3135
3136         webkit-patch needs an open-bugs command
3137         https://bugs.webkit.org/show_bug.cgi?id=30793
3138
3139         * Scripts/test-webkitpy: import OpenBugsTest
3140         * Scripts/webkit-patch: import OpenBugs
3141         * Scripts/webkitpy/commands/download_unittest.py: don't import unittest
3142         * Scripts/webkitpy/commands/early_warning_system_unittest.py: ditto
3143         * Scripts/webkitpy/commands/queries_unittest.py: ditto
3144         * Scripts/webkitpy/commands/queues_unittest.py: ditto
3145         * Scripts/webkitpy/commands/upload_unittest.py: ditto
3146         * Scripts/webkitpy/mock_bugzillatool.py: log when user.open_url is called.
3147
3148 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3149
3150         Rubberstamped by Simon Hausmann
3151
3152         [Qt] QtLauncher refactoring, separating utility methods.
3153
3154         * QtLauncher/QtLauncher.pro:
3155         * QtLauncher/main.cpp:
3156         * QtLauncher/utils.cpp: Added.
3157         (urlFromUserInput):
3158         * QtLauncher/utils.h: Added.
3159
3160 2010-01-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3161
3162         Rubberstamped by Simon Hausmann
3163
3164         [Qt] Refactor the code in the QtLauncher dealing with HTTP proxy.
3165
3166         * QtLauncher/main.cpp:
3167         (MainWindow::MainWindow):
3168         * QtLauncher/webpage.cpp:
3169         (WebPage::WebPage):
3170         (WebPage::applyProxy):
3171         * QtLauncher/webpage.h:
3172
3173 2010-01-26  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3174
3175         Reviewed by Tor Arne Vestbø.
3176
3177         [Qt] Corrects debug build of DumpRenderTree on Windows.
3178
3179         * DumpRenderTree/qt/DumpRenderTree.pro:
3180
3181 2010-01-26  Daniel Bates  <dbates@webkit.org>
3182
3183         Reviewed by Adam Barth.
3184
3185         https://bugs.webkit.org/show_bug.cgi?id=34070
3186
3187         Moves the try/catch for OSError exceptions in Executive.run_command
3188         to Credentials.read_credentials() so that the unit test
3189         webkitpy.scm_unittest.SCMClassTests.test_error_handlers can
3190         assert that Executive.run_command throws an OSError exception.
3191
3192         * Scripts/webkitpy/credentials.py:
3193         * Scripts/webkitpy/executive.py: Moved try/catch for OSError to
3194         method Credentials.read_credentials().
3195         * Scripts/webkitpy/executive_unittest.py: Removed tests that no longer
3196         apply: test_run_command_with_bad_command_check_return_code and
3197         test_run_command_with_bad_command_check_calls_error_handler. Added new
3198         test to assert that run_command throws OSError exceptions.
3199
3200 2010-01-26  Diego Gonzalez  <diego.gonzalez@openbossa.org>
3201
3202         Reviewed by Kenneth Rohde Christiansen.
3203
3204         [Qt] DRT WebHistory support
3205         https://bugs.webkit.org/show_bug.cgi?id=34167
3206
3207         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3208         (LayoutTestController::reset):
3209         (LayoutTestController::webHistoryItemCount):
3210         (LayoutTestController::keepWebHistory):
3211         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3212
3213 2010-01-26  Kent Tamura  <tkent@chromium.org>
3214
3215         Reviewed by Eric Seidel.
3216
3217         [Win] Add modifiers parameter support to Windows DumpRenderTree
3218         https://bugs.webkit.org/show_bug.cgi?id=34068
3219
3220         Add support for functional name modifiers; "addSelectionKey" and
3221         "rangeSelectionKey", and modifiers parameter to eventSender.mouseDown()
3222         and eventSender.mouseUp().
3223         This change is similar to r53498 for Mac.
3224         
3225         * DumpRenderTree/win/EventSender.cpp:
3226         (buildModifierFlags): New function to set MK_CONTROL or MK_SHIFT to WPARAM.
3227         (mouseDownCallback): Call buidlModifiersFlags().
3228         (mouseUpCallback): ditto.
3229         (keyDownCallback): Add support for "addSelectionkey" and "rangeSelectionKey".
3230
3231 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
3232
3233         Reviewed by Eric Seidel.
3234
3235         The Python autoinstall cache directory now only gets created
3236         in the directory containing autoinstall.py.
3237
3238         https://bugs.webkit.org/show_bug.cgi?id=33365
3239
3240         * Scripts/webkitpy/autoinstall.py:
3241           - Also added a README file to the cache directory saying
3242             where it came from.
3243
3244 2010-01-26  Chris Jerdonek  <cjerdonek@webkit.org>
3245
3246         Reviewed by Eric Seidel.
3247
3248         Moved the check-webkit-style processors into a new
3249         webkitpy/style/processors directory.
3250
3251         https://bugs.webkit.org/show_bug.cgi?id=34060
3252
3253         * Scripts/webkitpy/style/checker.py:
3254         * Scripts/webkitpy/style/checker_unittest.py:
3255         * Scripts/webkitpy/style/cpp_style.py: Removed.
3256         * Scripts/webkitpy/style/cpp_style_unittest.py: Removed.
3257         * Scripts/webkitpy/style/processors: Added.
3258         * Scripts/webkitpy/style/processors/__init__.py: Added.
3259         * Scripts/webkitpy/style/processors/cpp.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style.py.
3260         * Scripts/webkitpy/style/processors/cpp_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py.
3261         * Scripts/webkitpy/style/processors/text.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style.py.
3262         * Scripts/webkitpy/style/processors/text_unittest.py: Copied from WebKitTools/Scripts/webkitpy/style/text_style_unittest.py.
3263         * Scripts/webkitpy/style/text_style.py: Removed.
3264         * Scripts/webkitpy/style/text_style_unittest.py: Removed.
3265         * Scripts/webkitpy/style/unittests.py:
3266
3267 2010-01-26  Kevin Ollivier  <kevino@theolliviers.com>
3268
3269         [wx] Build fix, make sure stub function returns a value.
3270
3271         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3272         (LayoutTestController::counterValueForElementById):
3273
3274 2010-01-26  Steve Falkenburg  <sfalken@apple.com>
3275
3276         Reviewed by Oliver Hunt.
3277
3278         Windows build references non-existent include paths
3279         https://bugs.webkit.org/show_bug.cgi?id=34175
3280
3281         * DumpRenderTree/win/DumpRenderTree.vcproj:
3282         * DumpRenderTree/win/ImageDiff.vcproj:
3283         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
3284
3285 2010-01-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3286
3287         Reviewed by Ariya Hidayat.
3288
3289         [Qt] Separating out the UrlLoader from the QtLauncher in it's
3290         own implementation and header file.
3291
3292         * QtLauncher/main.cpp:
3293         (main):
3294         * QtLauncher/urlloader.cpp: Added.
3295         (UrlLoader::UrlLoader):
3296         (UrlLoader::loadNext):
3297         (UrlLoader::init):
3298         (UrlLoader::getUrl):
3299         * QtLauncher/urlloader.h: Added.
3300
3301 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
3302
3303         Reviewed by Shinichiro Hamaji.
3304
3305         Refactored check-webkit-style by removing the file path
3306         parameter from the style error handler functions.
3307
3308         https://bugs.webkit.org/show_bug.cgi?id=34031
3309
3310         * Scripts/webkitpy/style/checker.py:
3311           - Added _default_style_error_handler() to StyleChecker class.
3312           - Moved handle_style_error() to inside _default_style_error_handler().
3313
3314         * Scripts/webkitpy/style/checker_unittest.py:
3315           - Removed file path from calls to error handler.
3316
3317         * Scripts/webkitpy/style/cpp_style.py:
3318           - Removed file path from calls to error handler.
3319
3320         * Scripts/webkitpy/style/cpp_style_unittest.py:
3321           - Removed file path from calls to error handler.
3322
3323         * Scripts/webkitpy/style/text_style.py:
3324           - Removed file path from calls to error handler.
3325
3326         * Scripts/webkitpy/style/text_style_unittest.py:
3327           - Removed file path from calls to error handler.
3328
3329 2010-01-25  Jeremy Orlow  <jorlow@chromium.org>
3330
3331         Adding myself as reviewer.  No review necessary.
3332
3333         * Scripts/webkitpy/committers.py:
3334
3335 2010-01-25  Chris Jerdonek  <cjerdonek@webkit.org>
3336
3337         Reviewed by Adam Barth.
3338
3339         Improved prepare-ChangeLog so that it preserves the relative
3340         indentation of a git commit message.
3341
3342         https://bugs.webkit.org/show_bug.cgi?id=34058
3343
3344         * Scripts/prepare-ChangeLog:
3345           - Also adjusted the script so that it does not add white
3346             space characters to empty lines.
3347
3348 2010-01-24  Eric Seidel  <eric@webkit.org>
3349
3350         No review, rolling out r53763.
3351         http://trac.webkit.org/changeset/53763
3352         https://bugs.webkit.org/show_bug.cgi?id=33895
3353
3354         Broke 20+ tests on Windows.
3355
3356         * Scripts/run-webkit-tests:
3357         * Scripts/webkitdirs.pm:
3358
3359 2010-01-24  Adam Barth  <abarth@webkit.org>
3360
3361         Rubber stamped by Eric Seidel.
3362
3363         More pep8 compliance.
3364
3365         * Scripts/webkitpy/mock_bugzillatool.py:
3366
3367 2010-01-24  Adam Barth  <abarth@webkit.org>
3368
3369         Rubber stamped by Eric Seidel.
3370
3371         More pep8 compliance.
3372
3373         * Scripts/webkitpy/executive.py:
3374         * Scripts/webkitpy/grammar.py:
3375
3376 2010-01-24  Adam Barth  <abarth@webkit.org>
3377
3378         Rubber stamped by Eric Seidel.
3379
3380         More pep8 compliance.
3381
3382         * Scripts/webkitpy/comments.py:
3383         * Scripts/webkitpy/committers.py:
3384         * Scripts/webkitpy/credentials.py:
3385
3386 2010-01-24  Adam Barth  <abarth@webkit.org>
3387
3388         Rubber stamped by Eric Seidel.
3389
3390         Make changelogs.py pass pep8.
3391
3392         * Scripts/webkitpy/changelogs.py:
3393
3394 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3395
3396         [Qt] Unreviewed build fix
3397
3398         * QtLauncher/QtLauncher.pro:
3399         * QtLauncher/webinspector.h:
3400
3401 2010-01-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3402
3403         Rubberstamped by Simon Hausmann.
3404
3405         [Qt] Move the WebInspector class to it's own header file.
3406
3407         * QtLauncher/main.cpp:
3408         * QtLauncher/webinspector.h: Added.
3409         (WebInspector::WebInspector):
3410         (WebInspector::showEvent):
3411         (WebInspector::hideEvent):
3412
3413 2010-01-23  Robert Hogan  <robert@roberthogan.net>
3414
3415         Reviewed by Kenneth Rohde Christiansen.
3416
3417         Qt DRT: respect window.close() and window.closed()
3418         
3419         Qt DRT needs to maintain a correct count of open windows
3420         for windowCount(). It also needs to delete windows that
3421         have been closed by window.close().
3422         
3423         This fixes the following tests:
3424         
3425         plugins/destroy-during-npp-new.html
3426         fast/dom/Document/early-document-access.html
3427         fast/dom/Window/window-early-properties.html
3428         fast/events/open-window-from-another-frame.html
3429         fast/events/popup-blocking-click-in-iframe.html
3430         
3431         https://bugs.webkit.org/show_bug.cgi?id=32953
3432
3433         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3434         (WebCore::DumpRenderTree::DumpRenderTree):
3435         (WebCore::DumpRenderTree::createWindow):
3436         (WebCore::DumpRenderTree::windowCloseRequested):
3437         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3438         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3439         (LayoutTestController::maybeDump):
3440
3441 2010-01-23  Dan Bernstein  <mitz@apple.com>
3442
3443         Reviewed by Mark Rowe.
3444
3445         Added a user default for specifying a fallback frameworks path in case
3446         the bundle does not contain frameworks for the current Mac OS X version.
3447
3448         * WebKitLauncher/main.m:
3449         (fallbackMacOSXVersion): Added. Looks up the fallback version in a dictionary
3450         keyed by the FallbackSystemVersions user default and returns it.
3451         (main): If a frameworks directory for the current system version is not found,
3452         try the fallback.
3453
3454 2010-01-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3455
3456         Reviewed by Simon Hausmann.
3457
3458         Make run-webkit-tests work under Cygwin for the Qt port
3459
3460         setPathForRunningWebKitApp() is implemented for the Qt port
3461         by using qmake to query for the location of the Qt libraries.
3462
3463         This requires the original environment (%ENV) to be untouched,
3464         so launchWithCurrentEnv() was refactored to launchWithEnv(),
3465         and the code in openDumpTool() to not use %ENV but a %CLEAN_ENV
3466         instead. This has the added benefit of getting rid of the temp
3467         variables used for storing the current env.
3468
3469         openDumpTool() is also refactored a bit into platform-spesific,
3470         port-spesific, and generic environment variables.
3471
3472         Checks for undef was added a few places to fix Perl concat
3473         warnings when run-webkit-tests is aborted.
3474
3475         https://bugs.webkit.org/show_bug.cgi?id=33895
3476
3477         * Scripts/run-webkit-tests:
3478         * Scripts/webkitdirs.pm:
3479
3480 2010-01-22  Kevin Watters  <kevinwatters@gmail.com>
3481
3482         Reviewed by Kevin Ollivier.
3483
3484         [wx] Remove the Bakefile build system, which is no longer being used.
3485         
3486         https://bugs.webkit.org/show_bug.cgi?id=34022
3487
3488         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
3489         * wx/browser/browser.bkl: Removed.
3490         * wx/build-wxwebkit: Removed.
3491
3492 2010-01-22  Gustavo Noronha Silva  <gns@gnome.org>
3493
3494         Reviewed by Simon Fraser.
3495
3496         Reset zoom level to 1.0 when resetting view state. This is causing
3497         many tests to fail after svg/custom/text-zoom.xhtml changes the
3498         zoom level.
3499
3500         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3501         (resetDefaultsToConsistentValues):
3502
3503 2010-01-22  Steve Falkenburg  <sfalken@apple.com>
3504
3505         Reviewed by Darin Adler.
3506
3507         https://bugs.webkit.org/show_bug.cgi?id=34025
3508         Enable client-based Geolocation abstraction for Mac, Windows AppleWebKit targets.
3509
3510         * Scripts/build-webkit:
3511
3512 2010-01-22  Adam Barth  <abarth@webkit.org>
3513
3514         Unreviewed.  Arg.  Someone renamed limit to output_limit on me.
3515
3516         * Scripts/webkitpy/commands/queues.py:
3517
3518 2010-01-22  Adam Barth  <abarth@webkit.org>
3519
3520         Rubber stamped by Eric Seidel.
3521
3522         Make __init__.py and buildbot.py pass pep8 style checker.
3523
3524         * Scripts/webkitpy/__init__.py:
3525         * Scripts/webkitpy/buildbot.py:
3526
3527 2010-01-21  Joe Mason  <jmason@rim.com>
3528
3529         Reviewed by Adam Barth.
3530
3531         webkit-patch should retry on invalid password
3532         https://bugs.webkit.org/show_bug.cgi?id=33955
3533
3534         Ask for bugs.webkit.org authentication in a loop.
3535
3536         * Scripts/webkitpy/bugzilla.py:
3537
3538 2010-01-22  Adam Barth  <abarth@webkit.org>
3539
3540         Unreviewed.  Don't call seek on a NoneType.
3541
3542         * Scripts/webkitpy/statusserver.py:
3543
3544 2010-01-22  Petri Latvala  <petri.latvala@nomovok.com>
3545
3546         Reviewed by David Levin.
3547
3548         check-webkit-style breaks on files with unknown types
3549         https://bugs.webkit.org/show_bug.cgi?id=34001
3550
3551         For files with type FileType.NONE, dispatch_processor returns None.
3552
3553         * Scripts/webkitpy/style/checker.py: Don't call process_file with a processor of value None.
3554
3555 2010-01-22  Adam Barth  <abarth@webkit.org>
3556
3557         Reviewed by Eric Seidel.
3558
3559         Make bugzilla.py and webkitport.py conform to pep8
3560         https://bugs.webkit.org/show_bug.cgi?id=34015
3561
3562         This patch makes webkitport.py and bugzilla.py mostly conform to PEP8
3563         style as enforced by pep8.py.  I wasn't able to get rid of all the
3564         errors because I'm not sure how to wrap some lines properly.  Also,
3565         there are a few deprication errors that I couldn't resolve easily.
3566         However, this is a massive improvement in compliance.
3567
3568         * Scripts/webkitpy/bugzilla.py:
3569         * Scripts/webkitpy/webkitport.py:
3570
3571 2010-01-22  Adam Barth  <abarth@webkit.org>
3572
3573         Reviewed by Darin Adler.
3574
3575         Limit length of EWS results to 5MB
3576         https://bugs.webkit.org/show_bug.cgi?id=34016
3577
3578         Hopefully this will fix the bug where the results link doesn't appear.
3579         Our current theory is that the results blob is too big and the server
3580         is rejecting the request with a 500 error.  That causes us to re-try
3581         the post, but when we re-try the StringIO buffer has its seek pointer
3582         at the end.
3583
3584         * Scripts/webkitpy/commands/queues.py:
3585         * Scripts/webkitpy/statusserver.py:
3586
3587 2010-01-22  Chris Jerdonek  <cjerdonek@webkit.org>
3588
3589         Reviewed by Adam Barth.
3590
3591         Made check-webkit-style able to check patches when script not
3592         run from source root. Also consolidated external references
3593         to a single file.
3594
3595         https://bugs.webkit.org/show_bug.cgi?id=33791
3596
3597         * Scripts/check-webkit-style:
3598           - Changed to import style_references.py.
3599
3600         * Scripts/webkitpy/style/__init__.py:
3601           - Removed __path__ hack that allowed searching Scripts/ directory.
3602
3603         * Scripts/webkitpy/style/checker.py:
3604           - Changed to import style_references.py.
3605
3606         * Scripts/webkitpy/style_references.py: Added.
3607
3608 2010-01-22  Dmitry Titov  <dimich@chromium.org>
3609
3610         Reviewed by Maciej Stachowiak.
3611
3612         Fix the leak of ThreadIdentifiers in threadMap across threads.
3613         https://bugs.webkit.org/show_bug.cgi?id=32689
3614
3615         Add a new test to verify the ThreadIdentifiers are not reused across threads.
3616         The test runs in the beginning of DumpRenderTree and spawns 2 non-WTF treads sequentially,
3617         waiting for the previous thread to terminate before starting the next.
3618         The treads use WTF::currentThread() in their thread function. Without a fix, this
3619         causes both threads to have the same ThreadIdentifier which triggers ASSERT in thread function.
3620         It also starts another thread using WTF. Without the fix, this finds pthread handle from previous
3621         threads in the WTF threadMap and asserts in WTF::establishIdentifierForPthreadHandle().
3622         The test practically does not affect the DRT run time because the threads end immediately.
3623
3624         * DumpRenderTree/mac/DumpRenderTree.mm:
3625         (runThread): Test thread function.
3626         (testThreadIdentifierMap):
3627         (dumpRenderTree):
3628
3629 2010-01-22  Kent Tamura  <tkent@chromium.org>
3630
3631         Reviewed by Maciej Stachowiak.
3632
3633         Fix a bug that mouseDown:withModifiers: is never called.
3634         https://bugs.webkit.org/show_bug.cgi?id=33989
3635
3636         * DumpRenderTree/mac/EventSendingController.mm:
3637         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3638         (+[EventSendingController webScriptNameForSelector:]):
3639
3640 2010-01-22  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3641
3642         Rubberstamped by Antti Koivisto.
3643
3644         [Qt] Separate out the WebPage class into it's own
3645         cpp/header files. Also, removed the assumption that
3646         the view is a QWebView, in preparation of a merger
3647         of the two Qt WebKit launchers.
3648
3649         * QtLauncher/QtLauncher.pro:
3650         * QtLauncher/main.cpp:
3651         (WebView::mousePressEvent):
3652         * QtLauncher/webpage.cpp: Added.
3653         (WebPage::supportsExtension):
3654         (WebPage::extension):
3655         (WebPage::acceptNavigationRequest):
3656         (WebPage::openUrlInDefaultBrowser):
3657         * QtLauncher/webpage.h: Added.
3658         (WebPage::WebPage):
3659
3660 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
3661
3662         Reviewed by Shinichiro Hamaji.
3663
3664         Refactored to move file name and file-reading related code
3665         from cpp_style.py and text_style.py to checker.py.
3666
3667         https://bugs.webkit.org/show_bug.cgi?id=33775
3668
3669         * Scripts/check-webkit-style:
3670           - Updates caused by changes to checker.py.
3671
3672         * Scripts/webkitpy/style/checker.py:
3673           - Added SKIPPED_FILES_WITH_WARNING list.
3674           - Added SKIPPED_FILES_WITHOUT_WARNING list.
3675           - Added FileType class.
3676           - Added ProcessorDispatcher class.
3677           - In StyleChecker class:
3678             - Renamed process_patch() to check_patch().
3679             - Renamed process_file() to check_file().
3680             - Added _process_file().
3681             - Related refactoring.
3682             - Addressed check_patch() FIXME to share code with process_file().
3683
3684         * Scripts/webkitpy/style/checker_unittest.py:
3685           - Added ProcessorDispatcherSkipTest class.
3686           - Added ProcessorDispatcherDispatchTest class.
3687           - Added StyleCheckerCheckFileTest class.
3688
3689         * Scripts/webkitpy/style/cpp_style.py:
3690           - Renamed process_file_data() to _process_lines.
3691           - Removed process_file() (moved logic to checker.py).
3692           - Removed can_handle() (moved logic to checker.py).
3693           - Added CppProcessor class.
3694           - Removed is_exempt() (moved logic to checker.py).
3695           - Added process_file_data() back as a wrapper function.
3696
3697         * Scripts/webkitpy/style/cpp_style_unittest.py:
3698           - Removed test_can_handle().
3699           - Removed test_is_exempt().
3700           - Added CppProcessorTest class.
3701
3702         * Scripts/webkitpy/style/text_style.py:
3703           - Added TextProcessor class.
3704           - Removed process_file().
3705           - Removed can_handle().
3706
3707         * Scripts/webkitpy/style/text_style_unittest.py:
3708           - Removed test_can_handle().
3709           - Added TextProcessorTest class.
3710
3711 2010-01-21  Chris Jerdonek  <cjerdonek@webkit.org>
3712
3713         Reviewed by David Kilzer.
3714
3715         Create a unit-tested subroutine to parse patch files created
3716         by svn-create-patch.
3717
3718         https://bugs.webkit.org/show_bug.cgi?id=33475
3719
3720         * Scripts/VCSUtils.pm:
3721           - Added parseDiff().
3722           - Added parsePatch().
3723
3724         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Added.
3725           - Added unit tests for parseDiff().
3726
3727         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
3728           - Total number of tests now computed dynamically.
3729
3730         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl: Added.
3731           - Added unit tests for parsePatch().
3732
3733 2010-01-21  Kevin Ollivier  <kevino@theolliviers.com>
3734
3735         [wx] Build fix, add new directory to dir list.
3736
3737         * wx/build/settings.py:
3738
3739 2010-01-21  Adam Barth  <abarth@webkit.org>
3740
3741         Reviewed by Eric Seidel.
3742
3743         Make the EWS transactional
3744         https://bugs.webkit.org/show_bug.cgi?id=33978
3745
3746         Now if the EWS gets interrupted in the middle of processing a patch,
3747         the bots will re-process the patch.
3748
3749         * Scripts/test-webkitpy:
3750         * Scripts/webkitpy/commands/queues.py:
3751         * Scripts/webkitpy/commands/queues_unittest.py:
3752         * Scripts/webkitpy/patchcollection.py:
3753         * Scripts/webkitpy/patchcollection_unittest.py: Added.
3754
3755 2010-01-21  Adam Barth  <abarth@webkit.org>
3756
3757         Unreviewed.  Add missing "ago" for style in the status bubble.
3758
3759         * QueueStatusServer/templates/statusbubble.html:
3760
3761 2010-01-21  Adam Barth  <abarth@webkit.org>
3762
3763         Reviewed by David Levin.
3764
3765         [style-queue] should not complain about identifier names with underscores under WebKit/gtk/webkit/
3766         https://bugs.webkit.org/show_bug.cgi?id=33356
3767
3768         White list unix_hacker_style names in WebKit/gtk/webkit because these
3769         are used in the GTK+ API.
3770
3771         * Scripts/webkitpy/style/cpp_style.py:
3772         * Scripts/webkitpy/style/cpp_style_unittest.py:
3773
3774 2010-01-21  Diego Gonzalez  <diego.gonzalez@openbossa.org>
3775
3776         Reviewed by Kenneth Rohde Christiansen.
3777
3778         [Qt] add setDomainRelaxationForbiddenForURLScheme in Qt DRT
3779         https://bugs.webkit.org/show_bug.cgi?id=33945
3780
3781         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3782         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
3783         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3784
3785 2010-01-21  Simon Hausmann  <simon.hausmann@nokia.com>
3786
3787         No review, rolling out 53615 as it causes two
3788         crashes on the bot.
3789
3790         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3791         (WebCore::DumpRenderTree::DumpRenderTree):
3792         (WebCore::DumpRenderTree::createWindow):
3793         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3794         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3795         (LayoutTestController::maybeDump):
3796
3797 2010-01-21  Robert Hogan  <robert@roberthogan.net>
3798
3799         Reviewed by Simon Hausmann.
3800
3801         Qt DRT: respect window.close() and window.closed()
3802
3803         Qt DRT needs to maintain a correct count of open windows
3804         for windowCount(). It also needs to delete windows that
3805         have been closed by window.close().
3806
3807         This fixes the following tests:
3808
3809         plugins/destroy-during-npp-new.html
3810         fast/dom/Document/early-document-access.html
3811         fast/dom/Window/window-early-properties.html
3812         fast/events/open-window-from-another-frame.html
3813         fast/events/popup-blocking-click-in-iframe.html
3814
3815         https://bugs.webkit.org/show_bug.cgi?id=32953
3816
3817         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3818         (WebCore::DumpRenderTree::DumpRenderTree):
3819         (WebCore::DumpRenderTree::createWindow):
3820         (WebCore::DumpRenderTree::windowCloseRequested):
3821         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3822         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3823         (LayoutTestController::maybeDump):
3824
3825 2010-01-20  Eric Seidel  <eric@webkit.org>
3826
3827         No review, rolling out r53593.
3828         http://trac.webkit.org/changeset/53593
3829         https://bugs.webkit.org/show_bug.cgi?id=33496
3830
3831         Re-rollout this patch, the commit-queue should not have landed
3832         it again, but it did due to land-diff and rollout both not
3833         clearing flags.
3834
3835         * Scripts/webkitpy/commands/early_warning_system.py:
3836         * Scripts/webkitpy/commands/queues.py:
3837         * Scripts/webkitpy/queueengine.py:
3838         * Scripts/webkitpy/scm.py:
3839         * Scripts/webkitpy/scm_unittest.py:
3840
3841 2010-01-20  Eric Seidel  <eric@webkit.org>
3842
3843         Reviewed by Adam Barth.
3844
3845         webkit-commit-queue status page is confusing
3846         https://bugs.webkit.org/show_bug.cgi?id=33496
3847
3848         This should improve the status page by removing more Fail messages.
3849         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
3850         to behave more like one another.  This meant moving where the failure reporting was done.
3851         Previously the AbstractReviewQueue always used the parent process to report the error,
3852         while CommitQueue used the subprocess when possible, and the parent only reported errors
3853         that we didn't know how to handle (bugs in the commit-queue itself).
3854         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
3855         in both implementations and required teaching handle_script_error in each to post Fail messages
3856         to the status server instead of calling exit(1).
3857
3858         This will also make the style-queue share more bug posting logic with other queues:
3859         https://bugs.webkit.org/show_bug.cgi?id=33871
3860
3861         * Scripts/webkitpy/commands/early_warning_system.py:
3862          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
3863            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
3864            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
3865            _update_status_for_script_error knows how to post the Fail message to the status server.
3866          - Teach _update_status_for_script_error how to post Fail messages to the status server.
3867         * Scripts/webkitpy/commands/queues.py:
3868          - Remove the try block from process_work_item since the caller already has one.
3869          - Only CC watchers on failure to cut down on commit-queue generated mail.
3870          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
3871          - Abstract _format_script_error_output_for_bug to share code between all queues.
3872          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
3873          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
3874          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
3875          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
3876         * Scripts/webkitpy/queueengine.py:
3877          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
3878         * Scripts/webkitpy/scm.py:
3879          - Add new checkout_revision function.
3880         * Scripts/webkitpy/scm_unittest.py:
3881          - Test our new checkout_revision function.
3882
3883 2010-01-20  Fumitoshi Ukai  <ukai@chromium.org>
3884
3885         Reviewed by Alexey Proskuryakov.
3886
3887         WebSocket: Missing Request-URI, when no tralling slash in host
3888         https://bugs.webkit.org/show_bug.cgi?id=33689
3889
3890         Update pywebsocket to 0.4.7.1, which supports alias for resource
3891         name, so that we could test for ws://127.0.0.1:8880
3892
3893         * Scripts/run-webkit-tests:
3894         * Scripts/run-webkit-websocketserver:
3895         * pywebsocket/mod_pywebsocket/dispatch.py:
3896         * pywebsocket/mod_pywebsocket/handshake.py:
3897         * pywebsocket/mod_pywebsocket/standalone.py:
3898         * pywebsocket/setup.py:
3899         * pywebsocket/test/test_dispatch.py:
3900         * pywebsocket/test/test_handshake.py:
3901
3902 2010-01-20  Eric Seidel  <eric@webkit.org>
3903
3904         No review, rolling out r53537.
3905         http://trac.webkit.org/changeset/53537
3906         https://bugs.webkit.org/show_bug.cgi?id=33496
3907
3908         Added a failure condition to the commit-queue and looks to
3909         have broken the EWS bots
3910
3911         * Scripts/webkitpy/commands/early_warning_system.py:
3912         * Scripts/webkitpy/commands/queues.py:
3913         * Scripts/webkitpy/queueengine.py:
3914         * Scripts/webkitpy/scm.py:
3915         * Scripts/webkitpy/scm_unittest.py:
3916
3917 2010-01-20  Jon Honeycutt  <jhoneycutt@apple.com>
3918
3919         MSAA: accSelect() is not implemented
3920
3921         https://bugs.webkit.org/show_bug.cgi?id=33918
3922         <rdar://problem/7436861>
3923
3924         Reviewed by Darin Adler.
3925
3926         * DumpRenderTree/AccessibilityUIElement.cpp:
3927         (takeFocusCallback):
3928         Call the object's takeFocus() function.
3929         (takeSelectionCallback):
3930         Call its takeSelection() function.
3931         (addSelectionCallback):
3932         Call its addSelection() function.
3933         (removeSelectionCallback):
3934         Call its removeSelection() function.
3935         (AccessibilityUIElement::getJSClass):
3936         Add new functions to the JS class definition.
3937
3938         * DumpRenderTree/AccessibilityUIElement.h:
3939         Declare new functions.
3940
3941         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3942         (AccessibilityUIElement::takeFocus):
3943         Stubbed.
3944         (AccessibilityUIElement::takeSelection):
3945         Stubbed.
3946         (AccessibilityUIElement::addSelection):
3947         Stubbed.
3948         (AccessibilityUIElement::removeSelection):
3949         Stubbed.
3950
3951         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3952         (AccessibilityUIElement::takeFocus):
3953         Stubbed.
3954         (AccessibilityUIElement::takeSelection):
3955         Stubbed.
3956         (AccessibilityUIElement::addSelection):
3957         Stubbed.
3958         (AccessibilityUIElement::removeSelection):
3959         Stubbed.
3960
3961         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3962         (AccessibilityUIElement::takeFocus):
3963         Call the object's accSelect() function, passing the appropriate flag.
3964         (AccessibilityUIElement::takeSelection):
3965         Ditto.
3966         (AccessibilityUIElement::addSelection):
3967         Ditto.
3968         (AccessibilityUIElement::removeSelection):
3969         Ditto.
3970
3971 2010-01-20  Andras Becsi  <abecsi@inf.u-szeged.hu>
3972
3973         Reviewed by Alexey Proskuryakov.
3974
3975         Extract Apache handling to httpd.pm module and use the provided functionality
3976         in scripts where Apache is needed.
3977         The module httpd.pm stores the PID of Apache in a variable and cleans up
3978         the PID directory after Apache properly shut down. Catching INT and TERM
3979         signals allows the scripts to close Apache and clean up its PID directory
3980         even if the testing was interrupted.
3981
3982         https://bugs.webkit.org/show_bug.cgi?id=33153
3983
3984         * Scripts/webkitperl/httpd.pm: Added.
3985         * Scripts/run-iexploder-tests:
3986         * Scripts/run-webkit-httpd:
3987         * Scripts/run-webkit-tests:
3988
3989 2010-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3990
3991         Reviewed by Simon Hausmann.
3992
3993         [Qt] Make DumpRenderTree build on Windows
3994
3995         * DumpRenderTree/qt/DumpRenderTree.pro:
3996         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3997         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3998         * DumpRenderTree/qt/main.cpp:
3999
4000 2010-01-20  Steve Block  <steveblock@google.com>
4001
4002         Reviewed by Eric Seidel.
4003
4004         Fix commit bot to land patches in order of the bug last modification date.
4005         https://bugs.webkit.org/show_bug.cgi?id=33395
4006
4007         * Scripts/webkitpy/bugzilla.py: Modified. Added 'order=Last+Changed' to bugzilla commit queue URL.
4008
4009 2010-01-20  Adam Barth  <abarth@webkit.org>
4010
4011         Reviewed by Eric Seidel.
4012
4013         Teach check-webkit-style about WebKit/gtk/tests
4014         https://bugs.webkit.org/show_bug.cgi?id=33892
4015
4016         Removes false positives found in
4017         https://bugs.webkit.org/show_bug.cgi?id=30883
4018
4019         * Scripts/webkitpy/style/cpp_style.py:
4020         * Scripts/webkitpy/style/cpp_style_unittest.py:
4021
4022 2010-01-20  Adam Barth  <abarth@webkit.org>
4023
4024         Reviewed by Eric Seidel.
4025
4026         Teach check-webkit-style about QGVLauncher
4027         https://bugs.webkit.org/show_bug.cgi?id=33890
4028
4029         Remove false positives found in
4030         https://bugs.webkit.org/show_bug.cgi?id=33708
4031
4032         * Scripts/webkitpy/style/cpp_style.py:
4033         * Scripts/webkitpy/style/cpp_style_unittest.py:
4034
4035 2010-01-20  Eric Seidel  <eric@webkit.org>
4036
4037         Reviewed by Adam Barth.
4038
4039         webkit-commit-queue status page is confusing
4040         https://bugs.webkit.org/show_bug.cgi?id=33496
4041
4042         This should improve the status page by removing more Fail messages.
4043         To do this, I re-factored the CommitQueue and the AbstractReviewQueues
4044         to behave more like one another.  This meant moving where the failure reporting was done.
4045         Previously the AbstractReviewQueue always used the parent process to report the error,
4046         while CommitQueue used the subprocess when possible, and the parent only reported errors
4047         that we didn't know how to handle (bugs in the commit-queue itself).
4048         Now the AbstractReviewQueue follow's the commit-queue's model.  This got rid of a try-block
4049         in both implementations and required teaching handle_script_error in each to post Fail messages
4050         to the status server instead of calling exit(1).
4051
4052         This will also make the style-queue share more bug posting logic with other queues:
4053         https://bugs.webkit.org/show_bug.cgi?id=33871
4054
4055         * Scripts/webkitpy/commands/early_warning_system.py:
4056          - Don't exit(1) as that will cause the calling queue to also report Fail to the status server.
4057            Implementors of handle_script_error are expected to update the status server if needed, but only exit if the error could not be handled.
4058            So we instead pass patch_has_failed_this_queue=True to _update_status_for_script_error in the case that this was a real failure.
4059            _update_status_for_script_error knows how to post the Fail message to the status server.
4060          - Teach _update_status_for_script_error how to post Fail messages to the status server.
4061         * Scripts/webkitpy/commands/queues.py:
4062          - Remove the try block from process_work_item since the caller already has one.
4063          - Only CC watchers on failure to cut down on commit-queue generated mail.
4064          - handle_unexpected_error needs to mark _did_fail now that the try block is gone from process_work_item.
4065          - Abstract _format_script_error_output_for_bug to share code between all queues.
4066          - The new _format_script_error_output_for_bug allows the style-queue to share the posting limit with other queues, as well as support linking to the full output.
4067          - Rename _can_build_and_test to _current_checkout_builds_and_passes_tests to better explain what revision it's testing.
4068          - Move logging out of _can_build_and_test and make the logs explain what revision we're testing.
4069          - handle_script_error now posts Fail instead of the try block in process_work_item handling it.
4070         * Scripts/webkitpy/queueengine.py:
4071          - QueueEngine is no longer used just by the commit-queue, update the logging to say "processing" instead of landing.
4072         * Scripts/webkitpy/scm.py:
4073          - Add new checkout_revision function.
4074         * Scripts/webkitpy/scm_unittest.py:
4075          - Test our new checkout_revision function.
4076
4077 2010-01-20  Adam Barth  <abarth@webkit.org>
4078
4079         Reviewed by Darin Adler.
4080
4081         Exempt JavaScriptCore/qt/api from style checks
4082         https://bugs.webkit.org/show_bug.cgi?id=33879
4083
4084         Apparently there is a JavaScriptCore API for Qt as well as a WebKit
4085         API.
4086
4087         * Scripts/webkitpy/style/cpp_style.py:
4088         * Scripts/webkitpy/style/cpp_style_unittest.py:
4089
4090 2010-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4091
4092         Reviewed by Simon Hausmann.
4093
4094         [Qt] Don't use QSocketNotifier in the DRT for reading stdin
4095
4096         QSocketNotifier is not available on Windows. Instead we read
4097         stdin synchronously after each test using signals and slots.
4098
4099         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4100         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4101         * DumpRenderTree/qt/main.cpp:
4102
4103 2010-01-19  Adam Barth  <abarth@webkit.org>
4104
4105         Rubber stamped by Eric Seidel.
4106
4107         Move chromium-ews back to building release only to make the EWS faster.
4108
4109         * Scripts/webkitpy/commands/early_warning_system.py:
4110
4111 2010-01-17  Jon Honeycutt  <jhoneycutt@apple.com>
4112
4113         MSAA: The child <option> elements of a non-multiple <select> are not
4114         exposed
4115
4116         https://bugs.webkit.org/show_bug.cgi?id=33773
4117         <rdar://problem/7550556>
4118
4119         Reviewed by Alice Liu.
4120
4121         * DumpRenderTree/AccessibilityUIElement.cpp:
4122         (getIsVisibleCallback):
4123         Call the object's isVisible() function.
4124         (getIsOffScreenCallback):
4125         Ditto, for isOffScreen().
4126         (getIsCollapsedCallback):
4127         Ditto, for isCollapsed().
4128         (getHasPopupCallback):
4129         Ditto, for hasPopup().
4130         (AccessibilityUIElement::getJSClass):
4131         Add isVisible and isOffScreen attributes.
4132
4133         * DumpRenderTree/AccessibilityUIElement.h:
4134         Declare new functions.
4135
4136         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4137         (AccessibilityUIElement::isVisible):
4138         Stubbed.
4139         (AccessibilityUIElement::isOffScreen):
4140         Stubbed.
4141         (AccessibilityUIElement::isCollapsed):
4142         Stubbed.
4143         (AccessibilityUIElement::hasPopup):
4144         Stubbed.
4145
4146         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4147         (AccessibilityUIElement::isVisible):
4148         Stubbed.
4149         (AccessibilityUIElement::isOffScreen):
4150         Stubbed.
4151         (AccessibilityUIElement::isCollapsed):
4152         Stubbed.
4153         (AccessibilityUIElement::hasPopup):
4154         Stubbed.
4155
4156         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4157         (AccessibilityUIElement::showMenu):
4158         Call the object's accDoDefaultAction() to show its popup menu.
4159         (AccessibilityUIElement::isEnabled):
4160         Check that the object does not have the "unavailable" state.
4161         (AccessibilityUIElement::isVisible):
4162         Check that the object does not have the "invisible" state.
4163         (AccessibilityUIElement::isOffScreen):
4164         Check whether the object has the "offscreen" state.
4165         (AccessibilityUIElement::isCollapsed):
4166         Check whether the object has the "collapsed" state.
4167         (AccessibilityUIElement::hasPopup):
4168         Check whether the object has the "has popup" state.
4169
4170 2010-01-19  Victor Wang  <victorw@chromium.org>
4171
4172         Reviewed by Eric Seidel.
4173
4174         Correct committer name.
4175         https://bugs.webkit.org/show_bug.cgi?id=33868
4176
4177         * Scripts/webkitpy/committers.py:
4178
4179 2010-01-19  Kent Tamura  <tkent@chromium.org>
4180
4181         Reviewed by Darin Adler.
4182
4183         [DRT][Mac] Add modifiers parameter to eventSender.mouseDown() and eventSender.mouseUp()
4184         https://bugs.webkit.org/show_bug.cgi?id=33783
4185
4186         Some listbox tests check selection behavior by click events with
4187         "meta" or "shift" keys. Behaviors for such modifier keys are
4188         platform-dependent. The new parameter of mouseDown() and mouseUp()
4189         allows to specify not only concrete modifier keys such as
4190         "shiftKey" "metaKey", but also functional names like
4191         "addSelectionKey" "rangeSelectionKey".
4192
4193         * DumpRenderTree/mac/EventSendingController.mm:
4194         (+[EventSendingController isSelectorExcludedFromWebScript:]):
4195         (+[EventSendingController webScriptNameForSelector:]):
4196         (buildModifierFlags):
4197         (-[EventSendingController mouseDown:withModifiers:]):
4198         (-[EventSendingController mouseDown:]):
4199         (-[EventSendingController mouseUp:withModifiers:]):
4200         (-[EventSendingController mouseUp:]):
4201         (-[EventSendingController keyDown:withModifiers:withLocation:]):
4202
4203 2010-01-19  Adam Barth  <abarth@webkit.org>
4204
4205         Reviewed by Eric Seidel.
4206
4207         Unbreak --request-commit
4208         https://bugs.webkit.org/show_bug.cgi?id=33832
4209
4210         * Scripts/webkitpy/bugzilla.py:
4211
4212 2010-01-19  Eric Seidel  <eric@webkit.org>
4213
4214         Reviewed by Adam Barth.
4215
4216         validate-committer-lists throws exception and committers.py needs a refresh
4217         https://bugs.webkit.org/show_bug.cgi?id=33831
4218
4219         * Scripts/validate-committer-lists: use webkit_logging
4220         * Scripts/webkitpy/committers.py: Add recently minted committers.  Fix Simon Hausmanns email address list to include his webkit-committers@lists address.
4221
4222 2010-01-18  Adam Roben  <aroben@apple.com>
4223
4224         Add LayoutTestController support for calling new WebKit SPI to
4225         disallow setting document.domain
4226
4227         DRT part of fixing <http://webkit.org/b/33806>
4228         <rdar://problem/7552837> Would like API to disallow setting of
4229         document.domain for pages with certain URL schemes
4230
4231         Reviewed by Sam Weinig.
4232
4233         * DumpRenderTree/LayoutTestController.cpp:
4234         (setDomainRelaxationForbiddenForURLSchemeCallback): Added. Calls
4235         through to LayoutTestController.
4236         (LayoutTestController::staticFunctions): Added
4237         setDomainRelaxationForbiddenForURLScheme.
4238
4239         * DumpRenderTree/LayoutTestController.h: Added
4240         setDomainRelaxationForbiddenForURLScheme.
4241
4242         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4243         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
4244         * DumpRenderTree/win/LayoutTestControllerWin.cpp: