WebKitTools/ChangeLog

   1 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
   2
   3         Reviewed by Oliver Hunt.
   4
   5         ARIA: support aria-flowto
   6         https://bugs.webkit.org/show_bug.cgi?id=31762
   7
   8         * DumpRenderTree/AccessibilityUIElement.cpp:
   9         (ariaFlowToElementAtIndexCallback):
  10         (AccessibilityUIElement::getJSClass):
  11         * DumpRenderTree/AccessibilityUIElement.h:
  12         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  13         (AccessibilityUIElement::ariaFlowToElementAtIndex):
  14         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  15         (AccessibilityUIElement::ariaFlowToElementAtIndex):
  16         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
  17         (AccessibilityUIElement::ariaFlowToElementAtIndex):
  18
  19 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
  20
  21         Reviewed by Kenneth Christiansen.
  22
  23         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
  24         https://bugs.webkit.org/show_bug.cgi?id=31638
  25
  26         Unfreeze WorkQueue after each test execution.
  27
  28         * DumpRenderTree/qt/DumpRenderTree.cpp:
  29         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  30
  31 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
  32
  33         Reviewed by Adam Barth.
  34
  35         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
  36         for localhost and 127.0.0.1.
  37         https://bugs.webkit.org/show_bug.cgi?id=31783
  38
  39         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
  40
  41         * DumpRenderTree/qt/DumpRenderTree.cpp:
  42         (WebCore::NetworkAccessManager::NetworkAccessManager):
  43         (WebCore::NetworkAccessManager::sslErrorsEncountered):
  44         (WebCore::WebPage::WebPage):
  45         * DumpRenderTree/qt/DumpRenderTree.h:
  46
  47 2009-11-22  Chris Evans  <cevans@chromium.org>
  48
  49         Reviewed by Adam Barth.
  50
  51         Disable access to file:/// directory listings
  52         https://bugs.webkit.org/show_bug.cgi?id=31329
  53
  54         Implemented setAllowUniversalAccessFromFileURLs to support testing of
  55         file URL security.
  56
  57         * DumpRenderTree/LayoutTestController.cpp:
  58         (setAllowUniversalAccessFromFileURLsCallback):
  59         (LayoutTestController::staticFunctions):
  60         * DumpRenderTree/LayoutTestController.h:
  61         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  62         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
  63         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  64         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
  65         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  66         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
  67         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  68         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
  69
  70 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
  71
  72         Reviewed by Kenneth Rohde Christiansen.
  73
  74         [Qt] Fix the timeout of fast/frames/frame-navigation.html
  75         https://bugs.webkit.org/show_bug.cgi?id=31638
  76
  77         The test is timeouting, because it uses the WorkQueue to load a document in one
  78         of the child frames and once the loading is finished, the DRT does not dump the
  79         tree. This is because it waits for the QWebFrame::loadFinished() signal from
  80         the main frame, while it should connect to QWebPage::loadFinished().
  81
  82         * DumpRenderTree/qt/DumpRenderTree.cpp:
  83         (WebCore::DumpRenderTree::DumpRenderTree):
  84
  85 2009-11-21  Eric Seidel  <eric@webkit.org>
  86
  87         Reviewed by Adam Barth.
  88
  89         bugzilla-tool --help spews way too much text
  90         https://bugs.webkit.org/show_bug.cgi?id=31771
  91
  92         * Scripts/bugzilla-tool:
  93          - Remove self.cached_scm initialization hack.
  94         * Scripts/modules/buildbot.py:
  95          - Make default_host accessible to callers.
  96         * Scripts/modules/commands/download.py:
  97          - Phrase help for all commands consistently and remove spurious help text punctuation.
  98         * Scripts/modules/commands/queries.py: Ditto.
  99         * Scripts/modules/commands/queues.py: Ditto.
 100         * Scripts/modules/commands/upload.py: Ditto.
 101         * Scripts/modules/multicommandtool.py:
 102          - Add HelpPrintingOptionParser.format_epilog to replace
 103            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
 104            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
 105          - Make --help only show a list of commands like "svn help" and "git help" do --
 106            previously --help was listing all commands and options.
 107          - Sort list of commands alphabetically.
 108
 109 2009-11-21  Eric Seidel  <eric@webkit.org>
 110
 111         No review.  Fixing a typo from the previous patch for bug 31767.
 112
 113         AbstractQueue.run_bugzilla_tool throws an exception
 114         https://bugs.webkit.org/show_bug.cgi?id=31769
 115
 116         * Scripts/modules/commands/queues.py:
 117
 118 2009-11-21  Eric Seidel  <eric@webkit.org>
 119
 120         Reviewed by Adam Barth.
 121
 122         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
 123         https://bugs.webkit.org/show_bug.cgi?id=31767
 124
 125         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
 126         Since we don't have a good way to test BugzillaTool pieces, I've
 127         left out a test for now.
 128
 129         * Scripts/bugzilla-tool:
 130          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
 131         * Scripts/modules/commands/queues.py:
 132          - Use tool.path() instead of __file__.
 133         * Scripts/modules/multicommandtool.py:
 134          - Add a new path() method to MultiComandTool.
 135         * Scripts/modules/multicommandtool_unittest.py:
 136          - Provide a path() method.  Little point in testing this mock implementation.
 137
 138 2009-11-21  Adam Barth  <abarth@webkit.org>
 139
 140         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
 141         WebKitTools.
 142
 143         * Scripts/modules/commands/download.py:
 144
 145 2009-11-21  Adam Barth  <abarth@webkit.org>
 146
 147         Reviewed by Eric Seidel.
 148
 149         Convert check-style to use LandingSequence
 150         https://bugs.webkit.org/show_bug.cgi?id=31763
 151
 152         Instead of manipulating the working copy by hand, we should use the
 153         LandingSequence in CheckStyle.  This will make this code eaiser to
 154         test.
 155
 156         * Scripts/modules/commands/download.py:
 157
 158 2009-11-20  Adam Barth  <abarth@webkit.org>
 159
 160         Reviewed by Eric Seidel.
 161
 162         Unit test query commands
 163         https://bugs.webkit.org/show_bug.cgi?id=31755
 164
 165         These tests are pretty rough, but hopefully they'll grow.
 166
 167         * Scripts/modules/commands/queries_unittest.py: Added.
 168         * Scripts/modules/mock_bugzillatool.py: Added.
 169         * Scripts/run-webkit-unittests:
 170
 171 2009-11-20  Eric Seidel  <eric@webkit.org>
 172
 173         Reviewed by Adam Barth.
 174
 175         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
 176         https://bugs.webkit.org/show_bug.cgi?id=31758
 177
 178         * Scripts/modules/multicommandtool.py:
 179          - Allow passing of explicit commands to MultiCommandTool.__init__
 180         * Scripts/modules/multicommandtool_unittest.py:
 181          - Use new Command.name naming system.
 182          - Test Command auto-discovery.
 183         * Scripts/modules/workqueue.py:
 184          - bug_id no longer exists, use patch['bug_id'] instead.
 185         * Scripts/modules/workqueue_unittest.py:
 186          - WorkQueues require names now.
 187          - should_proceed_with_work_item must return a patch object.
 188
 189 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
 190
 191         Reviewed by Beth Dakin.
 192
 193         WAI-ARIA: add support for aria-owns
 194         https://bugs.webkit.org/show_bug.cgi?id=31702
 195
 196         * DumpRenderTree/AccessibilityUIElement.cpp:
 197         (ariaOwnsElementAtIndexCallback):
 198         (AccessibilityUIElement::getJSClass):
 199         * DumpRenderTree/AccessibilityUIElement.h:
 200         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 201         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 202         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
 203         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 204         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
 205         (AccessibilityUIElement::ariaOwnsElementAtIndex):
 206
 207 2009-11-20  Eric Seidel  <eric@webkit.org>
 208
 209         Reviewed by Adam Barth.
 210
 211         Fix exception thrown when running the commit-queue.
 212
 213         * Scripts/modules/statusbot.py: patch is optional.
 214         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
 215
 216 2009-11-20  Eric Seidel  <eric@webkit.org>
 217
 218         Reviewed by Adam Barth.
 219
 220         Teach the StatusBot how to support more than just the commit-queue
 221         https://bugs.webkit.org/show_bug.cgi?id=31754
 222
 223         * Scripts/modules/workqueue.py: Another typo.
 224
 225 2009-11-20  Eric Seidel  <eric@webkit.org>
 226
 227         Reviewed by Adam Barth.
 228
 229         Teach the StatusBot how to support more than just the commit-queue
 230         https://bugs.webkit.org/show_bug.cgi?id=31754
 231
 232         * Scripts/modules/commands/queues.py: Fix silly typo.
 233
 234 2009-11-20  Eric Seidel  <eric@webkit.org>
 235
 236         Reviewed by Adam Barth.
 237
 238         Teach the StatusBot how to support more than just the commit-queue
 239         https://bugs.webkit.org/show_bug.cgi?id=31754
 240
 241         * CommitQueueStatus/index.yaml:
 242          - Add indices required for the new queries.
 243         * CommitQueueStatus/queue_status.py:
 244          - Add a patch-status page and move update_status to update-status.
 245          - Only display "commit-queue" status records for the commit-queue.
 246          - Add support for a queue_name property on status records.
 247          - Fix _int_from_request to actually work.
 248         * CommitQueueStatus/update_status.html:
 249          - Add support for a queue_name on status records.
 250          - Remove unused list of bug ids.
 251          * Scripts/modules/commands/queues.py
 252           - Make the queues pass the patch instead of the bug_id to StatusBot.
 253         * Scripts/modules/statusbot.py:
 254          - Support passing the queue_name to the status updates.
 255          - Support fetching patch status with patch_status().
 256         * Scripts/modules/workqueue.py:
 257          - Pass the patch to the StatusBot instead of the bug_id.
 258          - Let WorkQueues have a name.
 259
 260 2009-11-20  Adam Barth  <abarth@webkit.org>
 261
 262         Reviewed by Eric Seidel.
 263
 264         Move bugzilla-tool commands into their own file
 265         https://bugs.webkit.org/show_bug.cgi?id=31752
 266
 267         This will let us write unit tests.
 268
 269         * Scripts/bugzilla-tool:
 270         * Scripts/modules/commands/__init__.py: Added.
 271         * Scripts/modules/commands/download.py: Added.
 272         * Scripts/modules/commands/queries.py: Added.
 273         * Scripts/modules/commands/queues.py: Added.
 274         * Scripts/modules/commands/upload.py: Added.
 275         * Scripts/modules/grammar.py: Added.
 276
 277 2009-11-20  Adam Barth  <abarth@webkit.org>
 278
 279         Reviewed by Eric Seidel.
 280
 281         BuildQueue should check if the tree is currently buildable
 282         https://bugs.webkit.org/show_bug.cgi?id=31744
 283
 284         * Scripts/bugzilla-tool:
 285         * Scripts/modules/landingsequence.py:
 286         * Scripts/modules/webkitlandingscripts.py:
 287
 288 2009-11-20  Adam Barth  <abarth@webkit.org>
 289
 290         Reviewed by Eric Seidel.
 291
 292         Move prepare_clean_working_directory into the LandingSequence
 293         https://bugs.webkit.org/show_bug.cgi?id=31743
 294
 295         * Scripts/bugzilla-tool:
 296         * Scripts/modules/landingsequence.py:
 297
 298 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
 299
 300         Reviewed by Kenneth Rohde Christiansen.
 301
 302         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
 303         https://bugs.webkit.org/show_bug.cgi?id=30460
 304
 305         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
 306
 307         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
 308         (pluginInvoke):
 309
 310 2009-11-20  Adam Barth  <abarth@webkit.org>
 311
 312         Reviewed by Eric Seidel.
 313
 314         Pass the port information to the child process
 315         https://bugs.webkit.org/show_bug.cgi?id=31736
 316
 317         We need to do this so the child process knows what to build!
 318
 319         * Scripts/bugzilla-tool:
 320         * Scripts/modules/landingsequence.py:
 321         * Scripts/modules/webkitport.py:
 322         * Scripts/modules/webkitport_unittest.py:
 323
 324 2009-11-20  Adam Barth  <abarth@webkit.org>
 325
 326         Reviewed by Eric Seidel.
 327
 328         Support Qt port in build-queue
 329         https://bugs.webkit.org/show_bug.cgi?id=31733
 330
 331         * Scripts/bugzilla-tool:
 332
 333 2009-11-20  Adam Barth  <abarth@webkit.org>
 334
 335         Reviewed by Eric Seidel.
 336
 337         Implement a build-queue
 338         https://bugs.webkit.org/show_bug.cgi?id=31725
 339
 340         Currently this just builds the first 10 patches in the review queue.
 341         We'll want to do something smarter soon.
 342
 343         * Scripts/bugzilla-tool:
 344
 345 2009-11-20  Adam Barth  <abarth@webkit.org>
 346
 347         Reviewed by Eric Seidel.
 348
 349         Make commit-queue and style-queue show up in help
 350         https://bugs.webkit.org/show_bug.cgi?id=31724
 351
 352         We need to store their names on their class to make these commands
 353         properly register themselves with MultiCommandTool.
 354
 355         * Scripts/bugzilla-tool:
 356
 357 2009-11-20  Adam Barth  <abarth@webkit.org>
 358
 359         Reviewed by Eric Seidel.
 360
 361         Implement bugzilla-tool build-attachment
 362         https://bugs.webkit.org/show_bug.cgi?id=31722
 363
 364         This command builds an attachment from bugzilla.  It leaves the built
 365         patch in the working copy.
 366
 367         * Scripts/bugzilla-tool:
 368         * Scripts/modules/landingsequence.py:
 369         * Scripts/modules/webkitlandingscripts.py:
 370
 371 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
 372
 373         Reviewed by Xan Lopez.
 374
 375         [GTK] DRT release event does not create the state correctly
 376         https://bugs.webkit.org/show_bug.cgi?id=31717
 377
 378         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
 379
 380 2009-11-20  Eric Seidel  <eric@webkit.org>
 381
 382         Reviewed by Adam Barth.
 383
 384         MultiCommandTool should find Command objects automatically instead of with a manual list
 385         https://bugs.webkit.org/show_bug.cgi?id=31710
 386
 387         * Scripts/bugzilla-tool:
 388         * Scripts/modules/multicommandtool.py:
 389          - Use some wild python-fu to crawl all the known subclasses of Command.
 390
 391 2009-11-20  Adam Barth  <abarth@webkit.org>
 392
 393         Unreviewed "build" fix.  Added missing import.
 394
 395         * Scripts/bugzilla-tool:
 396
 397 2009-11-20  Adam Barth  <abarth@webkit.org>
 398
 399         Unreviewed "build" fix.  I failed to update LandingSequence.test
 400         properly.
 401
 402         * Scripts/modules/landingsequence.py:
 403
 404 2009-11-20  Adam Barth  <abarth@webkit.org>
 405
 406         Reviewed by Eric Seidel.
 407
 408         Create LandingSequence as the all-sing, all-dance landing class
 409         https://bugs.webkit.org/show_bug.cgi?id=31709
 410
 411         Client can inherit from this class to carefully control exactly which
 412         steps they wish to have happen in the landing sequence.
 413
 414         * Scripts/bugzilla-tool:
 415         * Scripts/modules/landingsequence.py: Added.
 416         * Scripts/modules/webkitlandingscripts.py: Added.
 417
 418 2009-11-19  Adam Barth  <abarth@webkit.org>
 419
 420         Reviewed by Eric Seidel.
 421
 422         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
 423         https://bugs.webkit.org/show_bug.cgi?id=31707
 424
 425         This is to help when we implement build-attachment.
 426
 427         * Scripts/bugzilla-tool:
 428
 429 2009-11-19  Adam Barth  <abarth@webkit.org>
 430
 431         Reviewed by Eric Seidel.
 432
 433         Support Qt port in bugzilla-tool
 434         https://bugs.webkit.org/show_bug.cgi?id=31701
 435
 436         Now we support building with Qt!
 437
 438         * Scripts/bugzilla-tool:
 439         * Scripts/modules/webkitport.py: Added.
 440         * Scripts/modules/webkitport_unittest.py: Added.
 441         * Scripts/run-webkit-unittests:
 442
 443 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
 444
 445         Reviewed by Adam Barth.
 446
 447         Remove inserting stderr into patch in bugzilla-tool
 448         https://bugs.webkit.org/show_bug.cgi?id=29914
 449
 450         Modify SCM python module's run_command function to avoid return of stderr
 451         by default, so stderr won't be inserted into the patches.
 452         Modify the related unit test.
 453
 454         * Scripts/modules/scm.py:
 455         * Scripts/modules/scm_unittest.py:
 456
 457 2009-11-19  Eric Seidel  <eric@webkit.org>
 458
 459         Reviewed by Adam Barth.
 460
 461         bugzilla-tool needs per-command help
 462         https://bugs.webkit.org/show_bug.cgi?id=31697
 463
 464         Added support for "bugzilla-tool help command-name"
 465         and a unit test to make sure it works.
 466
 467         * Scripts/modules/multicommandtool.py:
 468         * Scripts/modules/multicommandtool_unittest.py:
 469
 470 2009-11-19  Eric Seidel  <eric@webkit.org>
 471
 472         Reviewed by Adam Barth.
 473
 474         Move MultiCommandTool and Command into a separate file and add some basic unit tests
 475         https://bugs.webkit.org/show_bug.cgi?id=31695
 476
 477         * Scripts/bugzilla-tool:
 478         * Scripts/modules/multicommandtool.py: Added.
 479         * Scripts/modules/multicommandtool_unittest.py: Added.
 480         * Scripts/run-webkit-unittests:
 481
 482 2009-11-19  Eric Seidel  <eric@webkit.org>
 483
 484         No review, just adding a FIXME.
 485
 486         Split out command parsing and help printing from BugzillaTool
 487         https://bugs.webkit.org/show_bug.cgi?id=31688
 488
 489         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
 490
 491 2009-11-19  Eric Seidel  <eric@webkit.org>
 492
 493         Reviewed by Adam Barth.
 494
 495         Split out command parsing and help printing from BugzillaTool
 496         https://bugs.webkit.org/show_bug.cgi?id=31688
 497
 498         * Scripts/bugzilla-tool:
 499          - Add new MultiCommandTool class to contain option parsing and help printing logic.
 500          - Rename private methods to use _ pattern.
 501          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
 502          -
 503
 504 2009-11-19  Eric Seidel  <eric@webkit.org>
 505
 506         Reviewed by Adam Barth.
 507
 508         Re-factor help printing to use modern python idioms
 509         https://bugs.webkit.org/show_bug.cgi?id=31685
 510
 511         * Scripts/bugzilla-tool:
 512
 513 2009-11-19  Eric Seidel  <eric@webkit.org>
 514
 515         Reviewed by Darin Adler.
 516
 517         commit-queue empty queue logs twice
 518         https://bugs.webkit.org/show_bug.cgi?id=31679
 519
 520         * Scripts/bugzilla-tool:
 521
 522 2009-11-19  Eric Seidel  <eric@webkit.org>
 523
 524         Reviewed by Darin Adler.
 525
 526         bugzilla-tool's reviewer/committer rejection message should be clearer
 527         https://bugs.webkit.org/show_bug.cgi?id=31126
 528
 529         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
 530
 531         * Scripts/modules/bugzilla.py:
 532
 533 2009-11-19  Eric Z. Ayers  <zundel@google.com>
 534
 535         Reviewed by Pavel Feldman.
 536
 537         Forces a WM_PAINT event on calling layoutTestController.display()
 538         in order to enable the timeline-paint.html test on Windows.
 539         ::UpdateWindow() does not force an event becaue the window is
 540         not visible.
 541
 542         https://bugs.webkit.org/show_bug.cgi?id=31402
 543
 544         * DumpRenderTree/win/DumpRenderTree.cpp:
 545         (displayWebView):
 546
 547 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
 548
 549         No review needed.
 550
 551         Added myself to committers list.
 552
 553         * Scripts/modules/committers.py:
 554
 555 2009-11-19  Adam Barth  <abarth@webkit.org>
 556
 557         Reviewed by Eric Seidel.
 558
 559         Bugzilla-tool command classes should match command names
 560         https://bugs.webkit.org/show_bug.cgi?id=31666
 561
 562         I renamed all the commands except CommitMessageForCurrentDiff because
 563         the new name would conflict with an existing class.
 564
 565         * Scripts/bugzilla-tool:
 566
 567 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
 568
 569         Reviewed by Gustavo Noronha Silva.
 570
 571         Web Inspector: Implement "show inspector" in WebKit GTK
 572         API and enable console tests.
 573
 574         https://bugs.webkit.org/show_bug.cgi?id=31669
 575
 576         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 577         (LayoutTestController::showWebInspector):
 578
 579 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 580
 581         Reviewed by Simon Hausmann.
 582
 583         Minor refactoring + more documentation.
 584
 585         * DumpRenderTree/qt/DumpRenderTree.cpp:
 586         (WebCore::clearHistory):
 587         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 588
 589 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
 590
 591         Reviewed by Eric Seidel.
 592
 593         Ignore websocket tests when --no-http is specified.
 594         https://bugs.webkit.org/show_bug.cgi?id=31662
 595
 596         * Scripts/run-webkit-tests:
 597
 598 2009-11-18  Adam Barth  <abarth@webkit.org>
 599
 600         Reviewed by Eric Seidel.
 601
 602         Normalize ' and " in bugzilla-tool
 603         https://bugs.webkit.org/show_bug.cgi?id=31655
 604
 605         We decided " is better than ' and we should be consistent.
 606
 607         * Scripts/bugzilla-tool:
 608
 609 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 610
 611         Reviewed by Kenneth Rohde Christiansen.
 612
 613         [Qt] Remove support for Qt v4.3 or older versions
 614         https://bugs.webkit.org/show_bug.cgi?id=29469
 615
 616         * DumpRenderTree/qt/DumpRenderTree.pro:
 617         * DumpRenderTree/qt/ImageDiff.pro:
 618
 619 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
 620
 621         Reviewed by Eric Seidel.
 622
 623         GitTest.test_create_binary_patch fails if /tmp is symlink
 624         https://bugs.webkit.org/show_bug.cgi?id=31536
 625
 626         * Scripts/modules/scm_unittest.py:
 627
 628 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
 629
 630         Reviewed by Darin Adler.
 631
 632         Configuration for Chromium Build Slaves.
 633
 634         https://bugs.webkit.org/show_bug.cgi?id=31442
 635
 636         * BuildSlaveSupport/build.webkit.org-config/config.json:
 637         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 638
 639 2009-11-18  Eric Seidel  <eric@webkit.org>
 640
 641         Reviewed by Darin Adler.
 642
 643         workqueue.py results in totally broken commit-queue UI
 644         https://bugs.webkit.org/show_bug.cgi?id=31645
 645
 646         * Scripts/bugzilla-tool:
 647          - Remove unneeded use of PatchCollection.
 648          - Grab a new copy of the cq'd patches every run of the queue.
 649
 650 2009-11-18  Sam Weinig  <sam@webkit.org>
 651
 652         Reviewed by Anders Carlsson.
 653
 654         Make the Mac Geolocation API async.
 655
 656         Update DRT to use the new async Mac Geolocation API.
 657
 658         * DumpRenderTree/mac/UIDelegate.mm:
 659         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
 660
 661 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 662
 663         Reviewed by Kenneth Rohde Christiansen.
 664
 665         Add and option to toggle HTML5 datalist support to build-webkit
 666         https://bugs.webkit.org/show_bug.cgi?id=31599
 667
 668         * Scripts/build-webkit:
 669
 670 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
 671
 672         Reviewed by Kevin Ollivier.
 673
 674         Enable wx plugin support using the Windows implementation as a base.
 675
 676         https://bugs.webkit.org/show_bug.cgi?id=31636
 677
 678         * wx/build/settings.py:
 679
 680 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 681
 682         Reviewed by Simon Hausmann.
 683
 684         Change the initialization order so that the controllers
 685         will be created before exporting them to the JS DOM window.
 686
 687         * DumpRenderTree/qt/DumpRenderTree.cpp:
 688         (WebCore::DumpRenderTree::DumpRenderTree):
 689
 690 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 691
 692         Reviewed by Simon Hausmann.
 693
 694         Fix a code copy and paste error. m_page should be page.
 695
 696         * DumpRenderTree/qt/DumpRenderTree.cpp:
 697         (WebCore::DumpRenderTree::createWindow):
 698
 699 2009-11-17  Mark Rowe  <mrowe@apple.com>
 700
 701         Reviewed by Alexey Proskuryakov.
 702
 703         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
 704
 705         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
 706         This prevents symlinks from confusing the descendant check.
 707
 708 2009-11-17  Mark Rowe  <mrowe@apple.com>
 709
 710         Reviewed by Alexey Proskuryakov.
 711
 712         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
 713
 714         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
 715         server to be up rather than having run-webkit-tests abort immediately.
 716
 717         * Scripts/run-webkit-tests:
 718
 719 2009-11-17  Eric Seidel  <eric@webkit.org>
 720
 721         Reviewed by Darin Adler.
 722
 723         commit-queue is failing to set reviewer in ChangeLogs
 724         https://bugs.webkit.org/show_bug.cgi?id=31592
 725
 726         * Scripts/bugzilla-tool: Clarify the "applying" log message.
 727         * Scripts/modules/bugzilla.py:
 728          - Add a new _validate_committer_and_reviewer function as a
 729            temporary solution until we can make a real Attachment object
 730            which knows how to fill in its committer/reviewer fields automatically.
 731
 732 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 733
 734         Unreviewed buildbot fix.
 735
 736         Revert part of earlier patch and add comment, as it
 737         was causing timeouts on the buildbot.
 738
 739         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 740         (LayoutTestController::notifyDone):
 741
 742 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 743
 744         Reviewed by Oliver Hunt.
 745
 746         Make the timeout 15 sec as for the other DRT's and make
 747         it print out the same output when a test timeout.
 748
 749         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 750         (LayoutTestController::waitUntilDone):
 751         (LayoutTestController::notifyDone):
 752         (LayoutTestController::timerEvent):
 753
 754 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
 755
 756         Reviewed by Timothy Hatcher.
 757
 758         Fixed typos in comments.
 759
 760         * Scripts/modules/committers.py:
 761
 762 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
 763
 764         Reviewed by Timothy Hatcher.
 765
 766         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
 767         - Updated DRT to show/close inspector for all tests under /inspector
 768         - Introduced LayoutTestController::setTimelineProfilingEnabled and
 769           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
 770         - Removed reload on each inspector test
 771         - Renamed fast/inspector to fast/inspector-support in order not to trigger
 772         inspector for those.
 773         - Reimplemented timeline tests in order to get rid of reload there.
 774         - Moved tests that don't require harness into the fast group.
 775
 776         https://bugs.webkit.org/show_bug.cgi?id=31472
 777
 778         * DumpRenderTree/LayoutTestController.cpp:
 779         (setTimelineProfilingEnabledCallback):
 780         (closeWebInspectorCallback):
 781         (LayoutTestController::staticFunctions):
 782         * DumpRenderTree/LayoutTestController.h:
 783         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 784         (shouldOpenWebInspector):
 785         (runTest):
 786         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 787         (LayoutTestController::setTimelineProfilingEnabled):
 788         * DumpRenderTree/mac/DumpRenderTree.mm:
 789         (shouldOpenWebInspector):
 790         (runTest):
 791         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 792         (LayoutTestController::setTimelineProfilingEnabled):
 793         * DumpRenderTree/win/DumpRenderTree.cpp:
 794         (shouldOpenWebInspector):
 795         (runTest):
 796         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 797         (LayoutTestController::setTimelineProfilingEnabled):
 798
 799 2009-11-17  Oliver Hunt  <oliver@apple.com>
 800
 801         Reviewed by Maciej Stachowiak.
 802
 803         Incorrect use of JavaScriptCore API in DumpRenderTree
 804         https://bugs.webkit.org/show_bug.cgi?id=31577
 805
 806         Return undefined rather than a literal null.
 807
 808         * DumpRenderTree/AccessibilityUIElement.cpp:
 809         (setSelectedTextRangeCallback):
 810         (incrementCallback):
 811         (decrementCallback):
 812         (showMenuCallback):
 813
 814 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
 815
 816         Reviewed by Beth Dakin.
 817
 818         AX: aria-labelledby duplicates some of its WAI-ARIA label
 819         https://bugs.webkit.org/show_bug.cgi?id=31565
 820
 821         * DumpRenderTree/AccessibilityUIElement.cpp:
 822         (titleUIElementCallback):
 823         (getIsValidCallback):
 824         (AccessibilityUIElement::getJSClass):
 825
 826 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 827
 828         Reviewed by Simon Hausmann.
 829
 830         r50942 broke output from created windows. Make the
 831         m_enableTextOutput a member of the DRT and not the
 832         WebPage.
 833
 834         * DumpRenderTree/qt/DumpRenderTree.cpp:
 835         (WebCore::WebPage::WebPage):
 836         (WebCore::WebPage::javaScriptAlert):
 837         (WebCore::WebPage::javaScriptConsoleMessage):
 838         (WebCore::WebPage::javaScriptConfirm):
 839         (WebCore::WebPage::javaScriptPrompt):
 840         (WebCore::WebPage::acceptNavigationRequest):
 841         (WebCore::DumpRenderTree::DumpRenderTree):
 842         (WebCore::DumpRenderTree::open):
 843         (WebCore::DumpRenderTree::createWindow):
 844         * DumpRenderTree/qt/DumpRenderTree.h:
 845         (WebCore::DumpRenderTree::setTextOutputEnabled):
 846         (WebCore::DumpRenderTree::isTextOutputEnabled):
 847         (WebCore::WebPage::shouldInterruptJavaScript):
 848         (WebCore::WebPage::isTextOutputEnabled):
 849         (WebCore::WebPage::setViewGeometry):
 850
 851 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 852
 853         Reviewed by Gustavo Noronha Silva.
 854
 855         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
 856         as the implementation is being used by at least Qt and Gtk+.
 857
 858         Update buildsystems as well.
 859
 860         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
 861         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
 862         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
 863         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
 864         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
 865         * GNUmakefile.am:
 866
 867 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
 868
 869         Reviewed by Alexey Proskuryakov.
 870
 871         Disable wss until all platforms support pyOpenSSL
 872
 873         https://bugs.webkit.org/show_bug.cgi?id=31479
 874
 875         * Scripts/run-webkit-tests:
 876
 877 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
 878
 879         Reviewed by Kenneth Christiansen.
 880
 881         [Qt] Implement load error pages support for Qt's DRT.
 882         https://bugs.webkit.org/show_bug.cgi?id=31509
 883
 884         For now, it will not be a default feature, and layout tests
 885         that want to make use of this have to explicitily call
 886         'handleErrorPages();' for the test source.
 887
 888         Any of the other DumpRenderTree's (mac, win and gtk)
 889         support handling error pages. Qt's will be the first.
 890
 891         * DumpRenderTree/qt/DumpRenderTree.cpp:
 892         (WebCore::WebPage::supportsExtension):
 893         (WebCore::WebPage::extension):
 894         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 895         (LayoutTestController::reset):
 896         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 897         (LayoutTestController::shouldHandleErrorPages):
 898         (LayoutTestController::handleErrorPages):
 899
 900 2009-11-16  Eric Seidel  <eric@webkit.org>
 901
 902         Reviewed by Adam Barth.
 903
 904         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
 905         https://bugs.webkit.org/show_bug.cgi?id=31549
 906
 907         Renamed --commit-queue to --non-interactive in most places
 908         and remove the code in land-patches which is no longer needed.
 909
 910         * Scripts/bugzilla-tool:
 911
 912 2009-11-16  Eric Seidel  <eric@webkit.org>
 913
 914         Reviewed by Adam Barth.
 915
 916         The commit-queue should use land-attachment
 917         https://bugs.webkit.org/show_bug.cgi?id=31548
 918
 919         * Scripts/bugzilla-tool:
 920
 921 2009-11-16  Adam Barth  <abarth@webkit.org>
 922
 923         Reviewed by Eric Seidel.
 924
 925         Convert CommitQueue over to PatchCollection
 926         https://bugs.webkit.org/show_bug.cgi?id=31547
 927
 928         Also fixes a bug in workqueue and adds a test!
 929
 930         * Scripts/bugzilla-tool:
 931         * Scripts/modules/workqueue.py:
 932         * Scripts/modules/workqueue_unittest.py:
 933
 934 2009-11-16  Adam Barth  <abarth@webkit.org>
 935
 936         Reviewed by Eric Seidel.
 937
 938         Move StyleQueue over to using PatchCollection
 939         https://bugs.webkit.org/show_bug.cgi?id=31544
 940
 941         That's what the class it's for.
 942
 943         * Scripts/bugzilla-tool:
 944         * Scripts/modules/patchcollection.py:
 945         * Scripts/modules/patchcollection_unittest.py:
 946
 947 2009-11-16  Eric Seidel  <eric@webkit.org>
 948
 949         Reviewed by Adam Barth.
 950
 951         bugzilla-tool needs a land-attachment command
 952         https://bugs.webkit.org/show_bug.cgi?id=31546
 953
 954         * Scripts/bugzilla-tool:
 955          - Move all the logic into AbstractLandingCommand and
 956            add a new LandAttachment command subclass.
 957          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
 958
 959 2009-11-16  Eric Seidel  <eric@webkit.org>
 960
 961         Reviewed by Adam Barth.
 962
 963         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
 964         https://bugs.webkit.org/show_bug.cgi?id=31543
 965
 966         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
 967
 968         * Scripts/bugzilla-tool:
 969
 970 2009-11-16  Eric Seidel  <eric@webkit.org>
 971
 972         Reviewed by Adam Barth.
 973
 974         Disable the style queue from posting to the commit queue status page.
 975
 976         * Scripts/bugzilla-tool:
 977
 978 2009-11-16  Adam Barth  <abarth@webkit.org>
 979
 980         Reviewed by Eric Seidel.
 981
 982         Implement PatchCollection
 983         https://bugs.webkit.org/show_bug.cgi?id=31541
 984
 985         This class holds a set of patches and lets clients iterate through
 986         them.  Optionally, clients can install a filter.
 987
 988         * Scripts/modules/patchcollection.py: Added.
 989         * Scripts/modules/patchcollection_unittest.py: Added.
 990         * Scripts/run-webkit-unittests:
 991
 992 2009-11-16  Eric Seidel  <eric@webkit.org>
 993
 994         Reviewed by Adam Barth.
 995
 996         bugzilla-tool land-patches will close bugs with patches r=?
 997         https://bugs.webkit.org/show_bug.cgi?id=28230
 998
 999         The commit-queue shouldn't close patches with outstanding reviews on them,
1000         even if many reviewers seem to be against multi-patch bugs.
1001
1002         * Scripts/bugzilla-tool:
1003
1004 2009-11-16  Eric Seidel  <eric@webkit.org>
1005
1006         Reviewed by Adam Barth.
1007
1008         bugzilla-tool check-style should work with attachment ids instead of bug ids
1009         https://bugs.webkit.org/show_bug.cgi?id=31540
1010
1011         * Scripts/bugzilla-tool:
1012
1013 2009-11-16  Eric Seidel  <eric@webkit.org>
1014
1015         Reviewed by Adam Barth.
1016
1017         WorkQueue is the only place that should know about special exit codes
1018         https://bugs.webkit.org/show_bug.cgi?id=31534
1019
1020         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1021         and add tests for handling exit codes.
1022         I also cleaned up workqueue_unittest.py more.
1023
1024         * Scripts/bugzilla-tool:
1025         * Scripts/modules/workqueue.py:
1026         * Scripts/modules/workqueue_unittest.py:
1027
1028 2009-11-16  Eric Seidel  <eric@webkit.org>
1029
1030         Reviewed by Adam Barth.
1031
1032         Re-factor workqueue_unittest to allow for more than one test.
1033         https://bugs.webkit.org/show_bug.cgi?id=31535
1034
1035         * Scripts/modules/workqueue_unittest.py:
1036
1037 2009-11-16  Eric Seidel  <eric@webkit.org>
1038
1039         Reviewed by Adam Barth.
1040
1041         land-patches needs to be re-factored into smaller chunks
1042         https://bugs.webkit.org/show_bug.cgi?id=31532
1043
1044         * Scripts/bugzilla-tool: fix a couple obvious typos.
1045
1046 2009-11-16  Eric Seidel  <eric@webkit.org>
1047
1048         Reviewed by Adam Barth.
1049
1050         land-patches needs to be re-factored into smaller chunks
1051         https://bugs.webkit.org/show_bug.cgi?id=31532
1052
1053         The next patch will move these methods into WebKitLandingScripts.
1054
1055         * Scripts/bugzilla-tool:
1056          - Split out _land_patch and _close_bug_if_no_active_patches.
1057
1058 2009-11-16  Adam Barth  <abarth@webkit.org>
1059
1060         Reviewed by Eric Seidel.
1061
1062         Fix silly copy-and-paste code.  I am a terrible coder.
1063
1064         * Scripts/modules/bugzilla.py:
1065
1066 2009-11-16  Adam Barth  <abarth@webkit.org>
1067
1068         Reviewed by Eric Seidel.
1069
1070         Implement a StyleQueue
1071         https://bugs.webkit.org/show_bug.cgi?id=31537
1072
1073         The first iteration of the style queue only produces output locally.
1074         There is also a limit of 10 patches because it's not that useful to
1075         iterate through the entire review queue at this point.  We can remove
1076         the limit later.
1077
1078         * Scripts/bugzilla-tool:
1079         * Scripts/modules/bugzilla.py:
1080
1081 2009-11-16  Adam Barth  <abarth@webkit.org>
1082
1083         Reviewed by Eric Seidel.
1084
1085         Unit test WorkQueue
1086         https://bugs.webkit.org/show_bug.cgi?id=31531
1087
1088         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1089
1090         * Scripts/bugzilla-tool:
1091         * Scripts/modules/statusbot.py:
1092         * Scripts/modules/workqueue.py:
1093         * Scripts/modules/workqueue_unittest.py: Added.
1094         * Scripts/run-webkit-unittests:
1095
1096 2009-11-16  Eric Seidel  <eric@webkit.org>
1097
1098         Reviewed by Adam Barth.
1099
1100         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1101         https://bugs.webkit.org/show_bug.cgi?id=31530
1102
1103         * Scripts/bugzilla-tool:
1104
1105 2009-11-16  Eric Seidel  <eric@webkit.org>
1106
1107         Reviewed by Adam Barth.
1108
1109         bugzilla-tool needs apply-attachment
1110         https://bugs.webkit.org/show_bug.cgi?id=31528
1111
1112         * Scripts/bugzilla-tool:
1113          - Add ApplyAttachment command.
1114          - Abstract applying code into WebKitApplyingScripts.
1115          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1116         * Scripts/modules/bugzilla.py:
1117          - Add fetch_attachment and bug_id_for_attachment_id.
1118         * Scripts/modules/bugzilla_unittest.py:
1119          - Add test for new parsing.
1120          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1121
1122 2009-11-16  Eric Seidel  <eric@webkit.org>
1123
1124         Reviewed by Adam Barth.
1125
1126         Document check-style's use of force_clean.
1127
1128         * Scripts/bugzilla-tool:
1129         * Scripts/modules/scm.py:
1130
1131 2009-11-16  Adam Barth  <abarth@webkit.org>
1132
1133         Reviewed by Eric Seidel.
1134
1135         Move WorkQueue to its own file
1136         https://bugs.webkit.org/show_bug.cgi?id=31529
1137
1138         WorkQueue and WorkQueueDelegate are separate concerns from
1139         bugzilla-tool.  Also added a missing include to logging.py.
1140
1141         * Scripts/bugzilla-tool:
1142         * Scripts/modules/logging.py:
1143         * Scripts/modules/workqueue.py:
1144
1145 2009-11-16  Adam Barth  <abarth@webkit.org>
1146
1147         Reviewed by Eric Seidel.
1148
1149         Move OutputTee to logging.py.
1150
1151         * Scripts/bugzilla-tool:
1152         * Scripts/modules/logging.py:
1153
1154 2009-11-15  Adam Barth  <abarth@webkit.org>
1155
1156         Reviewed by Eric Seidel.
1157
1158         Refactor bugzilla-tool to allow for multiple queues
1159         https://bugs.webkit.org/show_bug.cgi?id=31513
1160
1161         Divide the commit queue class into three class to make creating
1162         additional queues easier.
1163
1164         * Scripts/bugzilla-tool:
1165
1166 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1167
1168         Reviewed by Eric Seidel.
1169
1170         svn-apply may not handle git patches created by bugzilla-tool
1171         https://bugs.webkit.org/show_bug.cgi?id=31457
1172
1173         * Scripts/modules/scm.py:
1174         * Scripts/modules/scm_unittest.py:
1175
1176 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1177
1178         Reviewed by Eric Seidel.
1179
1180         bugzilla-tool should post git binary diff
1181         https://bugs.webkit.org/show_bug.cgi?id=31458
1182
1183         Add --binary option to Git.create_patch.
1184
1185         * Scripts/modules/scm.py:
1186         * Scripts/modules/scm_unittest.py:
1187
1188 2009-11-15  Adam Barth  <abarth@webkit.org>
1189
1190         Reviewed by Darin Adler.
1191
1192         Add bugzilla-tool check-style
1193         https://bugs.webkit.org/show_bug.cgi?id=31515
1194
1195         * Scripts/bugzilla-tool:
1196         * Scripts/modules/bugzilla.py:
1197
1198 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1199
1200         Reviewed by Simon Hausmann.
1201
1202         Make the Qt Linux only --valgrind feature, suppress errors
1203         defined in the SuppressedValgrindErrors file.
1204
1205         * Scripts/run-webkit-tests:
1206
1207 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1208
1209         Reviewed by Simon Hausmann.
1210
1211         Set the locale to C and not to the current one in use on the system.
1212
1213         * DumpRenderTree/qt/DumpRenderTree.cpp:
1214         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1215
1216 2009-11-13  Adam Roben  <aroben@apple.com>
1217
1218         Add support for
1219         http/tests/security/isolatedWorld/didClearWindowObject.html
1220
1221         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1222         window objects in isolated worlds are cleared
1223
1224         Reviewed by Dave Hyatt.
1225
1226         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1227
1228         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1229         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1230         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1231         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1232         Added. Sets a __worldID property on the global object whose value is
1233         the ID of this world.
1234         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1235         Respond to this new delegate callback by calling through to one of the
1236         above new methods.
1237         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1238         (worldMap): Added. Returns a HashMap containing all the worlds we've
1239         created.
1240         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1241         haven't kept track of this world.
1242         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1243         instead of declaring our own.
1244
1245         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1246
1247         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1248         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1249         didClearWindowObjectForFrameInStandardWorld.
1250         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1251         Respond to this new delegate callback by calling through to one of the
1252         below new methods.
1253         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1254         Added. Sets a __worldID property on the gobal object whose value is
1255         the ID of this world.
1256         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1257         Added. Moved code here from didClearWindowObject.
1258
1259         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1260         didClearWindowObjectForFrame* functions.
1261
1262         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1263         (worldMap): Added. Returns a HashMap containing all the worlds we've
1264         created.
1265         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1266         haven't kept track of this world.
1267         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1268         instead of declaring our own.
1269
1270 2009-11-13  Adam Roben  <aroben@apple.com>
1271
1272         Finish replacing worldIDs with world objects
1273
1274         The only remaining use of worldIDs was in a method only used by DRT
1275         for the isolated worlds tests.
1276
1277         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1278
1279         Reviewed by Mark Rowe.
1280
1281         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1282         (LayoutTestController::evaluateScriptInIsolatedWorld):
1283         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1284         (LayoutTestController::evaluateScriptInIsolatedWorld):
1285         Updated for changes to WebFrame. Now holds the map of worldID -> world
1286         at this level instead of making WebKit do it.
1287
1288 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1289
1290         Reviewed by Simon Hausmann.
1291
1292         [Qt] Ensure the DRT does not output anything until first test is run
1293
1294         * DumpRenderTree/qt/DumpRenderTree.cpp:
1295         * DumpRenderTree/qt/DumpRenderTree.h:
1296
1297 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1298
1299         Reviewed by Tor Arne Vestbø.
1300
1301         Clear the undo stack in before each new test run.
1302
1303         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1304
1305         * DumpRenderTree/qt/DumpRenderTree.cpp:
1306         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1307
1308 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1309
1310         Reviewed by Kenneth Rohde Christiansen.
1311
1312         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1313
1314         * DumpRenderTree/qt/DumpRenderTree.cpp:
1315         (WebCore::WebPage::resetSettings):
1316         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1317         (LayoutTestController::overridePreference):
1318
1319 2009-11-13  Eric Seidel  <eric@webkit.org>
1320
1321         Reviewed by Adam Barth.
1322
1323         Update committers.py based on svn records
1324         https://bugs.webkit.org/show_bug.cgi?id=31366
1325
1326         This list was generated using validate-committer-lists from
1327         https://bugs.webkit.org/show_bug.cgi?id=30970
1328         and makes committers.py current for committers who have
1329         committed in the last 3 years.
1330
1331         * Scripts/modules/committers.py:
1332
1333 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1334
1335         Reviewed by Adam Barth.
1336
1337         The document-open.html test was flaky at times. The test invokes the layout test plugin
1338         which in its destroy stream handler opens a new document. This basically tears down the
1339         stream and the associated plugin instance. The pluginLog function in the layout test
1340         plugin attempts to retrieve the window script object on a torn down plugin instance
1341         which crashed consistently on windows in the debugger. The functions which issue
1342         these logs already have a valid window script object. We now have variants of the pluginLog
1343         function which take in a window script object with and without variable arguments.
1344
1345         https://bugs.webkit.org/show_bug.cgi?id=31067
1346
1347         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1348         (pluginLogWithWindowObject):
1349         (pluginLogWithWindowObjectVariableArgs):
1350         (pluginLog):
1351         (notifyTestCompletion):
1352         (testDocumentOpen):
1353         (testWindowOpen):
1354
1355 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1356
1357         Reviewed by Gustavo Noronha Silva.
1358
1359         https://bugs.webkit.org/show_bug.cgi?id=30997
1360         [Gtk] Implemment AtkDocument
1361
1362         Added testing support.
1363
1364         * DumpRenderTree/AccessibilityUIElement.cpp:
1365         * DumpRenderTree/AccessibilityUIElement.h:
1366         (getDocumentEncodingCallback):
1367         (getDocumentURICallback):
1368         (AccessibilityUIElement::getJSClass):
1369         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1370         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1371         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1372         (AccessibilityUIElement::documentEncoding):
1373         (AccessibilityUIElement::documentURI):
1374
1375 2009-11-12  Adam Roben  <aroben@apple.com>
1376
1377         Replace worldIDs with world objects
1378
1379         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1380         user scripts/stylesheets and isolated worlds
1381
1382         Reviewed by Sam Weinig.
1383
1384         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1385         (LayoutTestController::addUserScript):
1386         (LayoutTestController::addUserStyleSheet):
1387         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1388         (LayoutTestController::addUserScript):
1389         (LayoutTestController::addUserStyleSheet):
1390         Changed these functions to create a new WebJSWorld each time they're
1391         called and to pass that world to WebKit.
1392
1393 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1394
1395         Reviewed by Oliver Hunt.
1396
1397         need to implement aria tree roles
1398         https://bugs.webkit.org/show_bug.cgi?id=31284
1399
1400         * DumpRenderTree/AccessibilityUIElement.cpp:
1401         (disclosedRowAtIndexCallback):
1402         (selectedRowAtIndexCallback):
1403         (isEqualCallback):
1404         (isAttributeSettableCallback):
1405         (isActionSupportedCallback):
1406         (disclosedByRowCallback):
1407         (hierarchicalLevelCallback):
1408         (AccessibilityUIElement::getJSClass):
1409         * DumpRenderTree/AccessibilityUIElement.h:
1410         (AccessibilityUIElement::isEqual):
1411         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1412         (AccessibilityUIElement::hierarchicalLevel):
1413         (AccessibilityUIElement::disclosedRowAtIndex):
1414         (AccessibilityUIElement::selectedRowAtIndex):
1415         (AccessibilityUIElement::disclosedByRow):
1416         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1417         (AccessibilityUIElement::getChildAtIndex):
1418         (AccessibilityUIElement::disclosedRowAtIndex):
1419         (AccessibilityUIElement::selectedRowAtIndex):
1420         (AccessibilityUIElement::titleUIElement):
1421         (AccessibilityUIElement::parentElement):
1422         (AccessibilityUIElement::disclosedByRow):
1423         (AccessibilityUIElement::hierarchicalLevel):
1424         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1425         (AccessibilityUIElement::hierarchicalLevel):
1426         (AccessibilityUIElement::disclosedRowAtIndex):
1427         (AccessibilityUIElement::selectedRowAtIndex):
1428         (AccessibilityUIElement::disclosedByRow):
1429
1430 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1431
1432         Reviewed by Darin Adler.
1433
1434         svn-apply can not handle git binary diffs
1435         https://bugs.webkit.org/show_bug.cgi?id=26830
1436
1437         Support "literal" type git binary diffs.
1438
1439         * Scripts/VCSUtils.pm:
1440         * Scripts/modules/scm_unittest.py:
1441         * Scripts/svn-apply:
1442
1443 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1444
1445         Not reviewed, removing duplicate entry for myself in committers.py.
1446
1447         * Scripts/modules/committers.py:
1448
1449 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1450
1451         Reviewed by Darin Adler and Mark Rowe.
1452
1453         https://bugs.webkit.org/show_bug.cgi?id=31200
1454         Tests in http/tests/security/mixedContent start to fail when new tests are added
1455
1456         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1457
1458 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1459
1460         Reviewed by Jan Alonzo.
1461
1462         Create, and display a window for the inspector, for inspector
1463         tests.
1464
1465         Need to also show/hide the inspector window to avoid having
1466         problems with code assuming it is realized
1467         https://bugs.webkit.org/show_bug.cgi?id=31347
1468
1469         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1470         (webInspectorShowWindow):
1471         (webInspectorCloseWindow):
1472         (webInspectorInspectWebView):
1473         (createWebView):
1474
1475 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1476
1477         Unreviewed Qt buildbot fix.
1478
1479         My previous fix was wrong, so revert that change and fix it by
1480         returning when the document of the frame has no document element.
1481         Idea is borrowed from mac and win DRT.
1482
1483         * DumpRenderTree/qt/DumpRenderTree.cpp:
1484         (WebCore::DumpRenderTree::dumpFramesAsText):
1485
1486 2009-11-11  Eric Seidel  <eric@webkit.org>
1487
1488         Reviewed byg Kenneth Rohde Christiansen.
1489
1490         Update Kenneth's committer record to include the email he
1491         uses on lists.webkit.org.
1492
1493         * Scripts/modules/committers.py:
1494
1495 2009-11-11  Eric Seidel  <eric@webkit.org>
1496
1497         Reviewed by Gustavo Noronha Silva.
1498
1499         Several committers use separate email addresses for bugzilla and svn.webkit.org
1500         https://bugs.webkit.org/show_bug.cgi?id=31364
1501
1502         Update records for existing committers to include email addresses
1503         used in svn.webkit.org and lists.webkit.org.
1504         Most committers use the same email address in all 3 places, but some use
1505         separate addresses.  committers.py needs record of each of these addresses.
1506
1507         * Scripts/modules/committers.py:
1508
1509 2009-11-11  Eric Seidel  <eric@webkit.org>
1510
1511         No review, adding second email address for an existing committer.
1512
1513         Add Yong Li's second bugzilla account to his committer record.
1514         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1515
1516         * Scripts/modules/committers.py:
1517
1518 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1519
1520         Reviewed by Simon Hausmann.
1521
1522         If the frame has no innerText don't append it, and
1523         do not add a newline which breaks some cross platform
1524         results.
1525
1526         * DumpRenderTree/qt/DumpRenderTree.cpp:
1527         (WebCore::DumpRenderTree::dumpFramesAsText):
1528
1529 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1530
1531         Reviewed by Simon Hausmann.
1532
1533         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1534
1535         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1536         (webkit_test_plugin_new_instance):
1537         (webkit_test_plugin_destroy_instance):
1538         (webkit_test_plugin_destroy_stream):
1539
1540 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1541
1542         Reviewed by Mark Rowe.
1543
1544         Implement the functionality needed by plugins/window-open.html
1545
1546         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1547         (webkit_test_plugin_new_instance):
1548         (webkit_test_plugin_set_window):
1549
1550 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1551
1552         Reviewed by Simon Hausmann.
1553
1554         [Qt] Force -graphicssystem raster and -style windows when running DRT
1555
1556         * DumpRenderTree/qt/main.cpp:
1557         * Scripts/run-webkit-tests:
1558
1559 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1560
1561         Reviewed by Simon Hausmann.
1562
1563         Compute correct library paths for Qt
1564
1565         * Scripts/webkitdirs.pm:
1566
1567 2009-11-10  Mark Rowe  <mrowe@apple.com>
1568
1569         Reviewed by Sam Weinig.
1570
1571         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1572
1573         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1574         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1575         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1576         that had enabled frame load delegate logging this would result in extra log messages being generated,
1577         causing the test to fail.
1578
1579         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1580         tests.
1581
1582         * DumpRenderTree/mac/DumpRenderTree.mm:
1583         (dumpRenderTree):
1584         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1585         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1586
1587 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1588
1589         Reviewed by Kenneth Rohde Christiansen.
1590
1591         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1592
1593         * DumpRenderTree/qt/DumpRenderTree.cpp:
1594         (WebCore::DumpRenderTree::DumpRenderTree):
1595
1596 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1597
1598         Reviewed by Jan Alonzo.
1599
1600         [GTK] Remove WebSocket configuration from WebKitWebSettings
1601         https://bugs.webkit.org/show_bug.cgi?id=31244
1602
1603         Follow-up of r50724. Don't set the enable-web-socket property
1604         anymore.
1605
1606         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1607         (resetDefaultsToConsistentValues):
1608
1609 2009-11-10  Oliver Hunt  <oliver@apple.com>
1610
1611         Reviewed by Maciej Stachowiak.
1612
1613         Rename 3D Canvas related classes to use WebGL prefix
1614         https://bugs.webkit.org/show_bug.cgi?id=29095
1615
1616         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1617         and upate webkitdirs script to new method of testing for WebGL.
1618
1619         * Scripts/do-webcore-rename:
1620         * Scripts/webkitdirs.pm:
1621
1622 2009-11-09  Oliver Hunt  <oliver@apple.com>
1623
1624         Reviewed by Geoff Garen.
1625
1626         Make do-webcore-rename work with git.
1627
1628         * Scripts/do-webcore-rename:
1629
1630 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1631
1632         Adding Kenneth to the reviewers list.
1633
1634         * Scripts/modules/committers.py:
1635
1636 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1637
1638         Reviewed by Jan Alonzo.
1639
1640         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1641         https://bugs.webkit.org/show_bug.cgi?id=30482
1642
1643         LayoutTestControllerGtk now uses the exposed
1644         Page::tabKeyCyclesThroughElements API
1645
1646         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1647         (LayoutTestController::setTabKeyCyclesThroughElements):
1648
1649 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1650
1651         Reviewed by Holger Freyther.
1652
1653         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1654         This helps to pass the test case below. Also replaced hardcoded
1655         code numbers with defined constants.
1656         https://bugs.webkit.org/show_bug.cgi?id=31185
1657
1658         Test: editing/undo/undo-deleteWord.html
1659
1660         * DumpRenderTree/qt/EventSenderQt.cpp:
1661         (EventSender::keyDown):
1662
1663 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1664
1665         Reviewed by Holger Freyther.
1666
1667         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1668         https://bugs.webkit.org/show_bug.cgi?id=31164
1669
1670         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1671
1672         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1673         (LayoutTestController::processWork):
1674
1675 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1676
1677         Reviewed by Holger Freyther.
1678
1679         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1680         https://bugs.webkit.org/show_bug.cgi?id=31158
1681
1682         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1683         always, which from WorkQueue prospective means that a load has been started
1684         and the queue processing should stop and wait for the load to finish.
1685         Spinning it off into a loading and a non-loading variants was the solution
1686         adopted by Mac's DRT to work around this problem. The former keeps returning
1687         'true' while the later executes the script synchronously and returns 'false'
1688         making it possible to the WorkQueue to proceed right away.
1689
1690         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1691         (LayoutTestController::processWork):
1692         (LayoutTestController::queueLoadingScript):
1693         (LayoutTestController::queueNonLoadingScript):
1694         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1695         * DumpRenderTree/qt/WorkQueueItem.h:
1696         (LoadingScriptItem::LoadingScriptItem):
1697         (LoadingScriptItem::invoke):
1698         (NonLoadingScriptItem::NonLoadingScriptItem):
1699         (NonLoadingScriptItem::invoke):
1700
1701 2009-11-07  Mark Rowe  <mrowe@apple.com>
1702
1703         Rubber-stamped by Cameron Zwarich.
1704
1705         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1706
1707         * Scripts/commit-log-editor:
1708
1709 2009-11-07  Mark Rowe  <mrowe@apple.com>
1710
1711         Reviewed by Darin Adler.
1712
1713         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1714         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1715
1716         Move logic for determining the name and email address to use in a ChangeLog entry from
1717         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1718         whether the author of the patch matches committer, and therefore needs access to the
1719         email address that would be used in a ChangeLog entry.
1720
1721         Based on a patch by Pierre d'Herbemont.
1722
1723         * Scripts/VCSUtils.pm:
1724         * Scripts/commit-log-editor:
1725         * Scripts/prepare-ChangeLog:
1726         * Scripts/webkitdirs.pm:
1727
1728 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1729
1730         Reviewed by Adam Barth.
1731
1732         Added functionality to the layout test plugin to invoke document.open and
1733         window.open with default arguments. The associated webkit bug is
1734         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1735         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1736         work in Chromium (V8) if there is no calling javascript context. To achieve this
1737         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1738         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1739
1740         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1741         (testDocumentOpen):
1742         (testWindowOpen):
1743         (pluginAllocate):
1744         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1745         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1746         (NPP_New):
1747         (NPP_SetWindow):
1748         (NPP_DestroyStream):
1749         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1750         (NPP_New):
1751         (NPP_SetWindow):
1752         (NPP_NewStream):
1753         (NPP_DestroyStream):
1754
1755 2009-11-06  Eric Seidel  <eric@webkit.org>
1756
1757         Reviewed by Adam Barth.
1758
1759         bugzilla-tool crashed with exception
1760         https://bugs.webkit.org/show_bug.cgi?id=31092
1761
1762         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1763
1764 2009-11-04  Eric Seidel  <eric@webkit.org>
1765
1766         No review, just add a line which got left out of the patch uploaded for commit.
1767
1768         commit-queue is crashing when trying to reject patches after unknown failures
1769         https://bugs.webkit.org/show_bug.cgi?id=31091
1770
1771         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1772
1773 2009-11-04  Adam Roben  <aroben@apple.com>
1774
1775         Remove bogus else clause in bugzilla-tool
1776
1777         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1778         create-bug raises exception after entering bug description
1779
1780         Reviewed by David Kilzer.
1781
1782         * Scripts/bugzilla-tool:
1783         (CreateBug): else clauses are only hit if no exception is raised, so
1784         it makes no sense to try to re-raise the exception in an else clause.
1785         The exception will automatically be re-raised if it doesn't match any
1786         of the except clauses, so we don't have to do anything special here at
1787         all to get the desired behavior.
1788
1789 2009-11-04  Eric Seidel  <eric@webkit.org>
1790
1791         Reviewed by David Kilzer.
1792
1793         svn-apply's fixChangeLogPatch function seems broken
1794         https://bugs.webkit.org/show_bug.cgi?id=30683
1795
1796         Update fixChangeLogPatch to be able to handle patches which
1797         don't start at line 1.
1798         Add unit tests for svn-apply to scm_unittest.py.
1799
1800         * Scripts/VCSUtils.pm:
1801         * Scripts/modules/scm_unittest.py:
1802
1803 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1804
1805         Reviewed by Beth Dakin.
1806
1807         Need to implement ARIA role="combobox"
1808         https://bugs.webkit.org/show_bug.cgi?id=31096
1809
1810         * DumpRenderTree/AccessibilityUIElement.cpp:
1811         (showMenuCallback):
1812         (getIsExpandedCallback):
1813         (AccessibilityUIElement::getJSClass):
1814         * DumpRenderTree/AccessibilityUIElement.h:
1815         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1816         (AccessibilityUIElement::isExpanded):
1817         (AccessibilityUIElement::showMenu):
1818         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1819         (AccessibilityUIElement::isExpanded):
1820         (AccessibilityUIElement::showMenu):
1821         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1822         (AccessibilityUIElement::isSelected):
1823         (AccessibilityUIElement::isExpanded):
1824         (AccessibilityUIElement::showMenu):
1825
1826 2009-11-04  Eric Seidel  <eric@webkit.org>
1827
1828         Reviewed by Adam Barth.
1829
1830         commit-queue is crashing when trying to reject patches after unknown failures
1831         https://bugs.webkit.org/show_bug.cgi?id=31091
1832
1833         * Scripts/bugzilla-tool:
1834          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
1835            so we have to find out what the current patch is by asking bugzilla again.
1836          - Discovered that this code was also leaking file descriptors, so fixed that.
1837
1838 2009-11-04  Adam Roben  <aroben@apple.com>
1839
1840         Make run-webkit-tests work for the Debug_Internal Windows
1841         configuration
1842
1843         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
1844         suffix.
1845
1846         Fixes <http://webkit.org/b/31123>.
1847
1848         Reviewed by Sam Weinig.
1849
1850         * Scripts/run-webkit-tests: Don't add the _debug suffix in
1851         Debug_Internal, either.
1852
1853 2009-11-04  Eric Seidel  <eric@webkit.org>
1854
1855         Reviewed by Adam Barth.
1856
1857         committers.py needs a way to store non-bugzilla email addresses
1858         https://bugs.webkit.org/show_bug.cgi?id=31037
1859
1860         Make Committer and Reviewer constructors take a single email or a list of emails.
1861         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
1862         Expose reviewers(), used by validate-committer-lists on bug 30970.
1863
1864         * Scripts/modules/committers.py:
1865         * Scripts/modules/committers_unittest.py: Added tests for the new code.
1866
1867 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
1868
1869         Reviewed by David Levin.
1870
1871         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
1872         https://bugs.webkit.org/show_bug.cgi?id=27491
1873
1874         The test path determination logic is changed to handle websocket and websocket/ssl cases.
1875         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
1876
1877         Functions to start or stop Web Socket servers are added.
1878
1879         * Scripts/run-webkit-tests:
1880
1881 2009-11-03  Eric Seidel  <eric@webkit.org>
1882
1883         No review, just changing wording of log message.
1884
1885         Change log string to say "failed" instead of "rejected"
1886         when a commit fails due to an out of date checkout.
1887         This makes grepping the commit-queue log for rejected patches easier.
1888
1889         * Scripts/bugzilla-tool:
1890
1891 2009-11-03  Eric Seidel  <eric@webkit.org>
1892
1893         No review, adding commonly known committers missing from the file.
1894
1895         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
1896
1897 2009-11-03  Eric Seidel  <eric@webkit.org>
1898
1899         No review, just sort-order cleanup.
1900
1901         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
1902
1903 2009-11-03  Stephen White  <senorblanco@chromium.org>
1904
1905         (Unreviewed).
1906
1907         Add myself to committers.py.
1908
1909         * Scripts/modules/committers.py:
1910
1911 2009-11-03  Robin Dunn  <robin@alldunn.com>
1912
1913         Reviewed by Kevin Ollviier.
1914
1915         Add packaging scripts for Debian-based Linux distros.
1916
1917         https://bugs.webkit.org/show_bug.cgi?id=31075
1918
1919         * wx/packaging/build-debian-installer.py: Added.
1920         * wx/packaging/debian: Added.
1921
1922 2009-11-03  Dan Bernstein  <mitz@apple.com>
1923
1924         Reviewed by Anders Carlsson and Beth Dakin.
1925
1926         https://bugs.webkit.org/show_bug.cgi?id=31070
1927
1928         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
1929         destroyed, it executes the value of the 'ondestroy' parameter as a
1930         script.
1931
1932         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1933         (pluginAllocate): Initialize onDestroy.
1934         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
1935         onDestroy.
1936         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1937         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
1938         specified.
1939         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
1940
1941 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1942
1943         Reviewed by Xan Lopez.
1944
1945         https://bugs.webkit.org/show_bug.cgi?id=31035
1946         [GTK] some accessibility tests hitting assertion in debug builds
1947
1948         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
1949
1950         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1951         (AccessibilityController::rootElement):
1952
1953 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
1954
1955         Reviewed by Beth Dakin.
1956
1957         Support ARIA "tab" roles
1958         https://bugs.webkit.org/show_bug.cgi?id=30842
1959
1960         * DumpRenderTree/AccessibilityUIElement.cpp:
1961         * DumpRenderTree/AccessibilityUIElement.h:
1962         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1963         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1964         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1965
1966 2009-11-01  Eric Seidel  <eric@webkit.org>
1967
1968         Reviewed by David Levin.
1969
1970         buildbots should use --exit-after-N-failures
1971         https://bugs.webkit.org/show_bug.cgi?id=30809
1972
1973         Make the bots exit after 20 failures to prevent never-ending
1974         test runs where every test spends a minute crashing.
1975
1976         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1977
1978 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1979
1980         Reviewed by Eric Seidel.
1981
1982         Turn on warnings for QtWebKit for gcc
1983         https://bugs.webkit.org/show_bug.cgi?id=30958
1984
1985         * DumpRenderTree/qt/main.cpp:
1986         (crashHandler): Mark function NO_RETURN
1987
1988 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
1989
1990         Adding myself to the committers list.
1991
1992         * Scripts/modules/committers.py:
1993
1994 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
1995
1996         Fix an issue that Adam noticed in DRT.
1997
1998         Reviewed by Darin Adler.
1999
2000         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2001         (AccessibilityUIElement::role):
2002         Get the length of the role text, and create a buffer dynamically.
2003
2004 2009-10-30  Eric Seidel  <eric@webkit.org>
2005
2006         No review, rolling out r50105.
2007         http://trac.webkit.org/changeset/50105
2008
2009         This commit was causing:
2010         https://bugs.webkit.org/show_bug.cgi?id=30869
2011         We'll re-implement the feature a different way.
2012
2013         * Scripts/bugzilla-tool:
2014
2015 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2016
2017         Test for MSAA: Accessibility of headings is not correct
2018
2019         https://bugs.webkit.org/show_bug.cgi?id=30937
2020
2021         Reviewed by Adam Roben.
2022
2023         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2024         (AccessibilityUIElement::role):
2025         Allow the role returned to be a BSTR.
2026         (AccessibilityUIElement::description):
2027         Fix a copy/paste error.
2028
2029 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2030
2031         Test for MSAA: Accessibility of links is wrong
2032
2033         https://bugs.webkit.org/show_bug.cgi?id=30928
2034
2035         Reviewed by Darin Adler.
2036
2037         * DumpRenderTree/AccessibilityUIElement.cpp:
2038         (getAccessibilityValueCallback):
2039         Return the accessibility value.
2040         (AccessibilityUIElement::getJSClass):
2041         Added "accessibilityValue" value.
2042
2043         * DumpRenderTree/AccessibilityUIElement.h:
2044
2045         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2046         (AccessibilityUIElement::accessibilityValue):
2047         Stubbed.
2048
2049         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2050         (AccessibilityUIElement::accessibilityValue):
2051         Stubbed.
2052
2053         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2054         (AccessibilityUIElement::accessibilityValue):
2055         Get the object's value, and return it as a JS string.
2056
2057 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2058
2059         Fix typo in command name used by wx build system.
2060
2061         * wx/build/build_utils.py:
2062
2063 2009-10-30  Adam Barth  <abarth@webkit.org>
2064
2065         Reviewed by Darin Adler.
2066
2067         Patch v1 is a dumb default name for patches
2068         https://bugs.webkit.org/show_bug.cgi?id=30952
2069
2070         Let's use "Patch" instead.
2071
2072         * Scripts/bugzilla-tool:
2073
2074 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2075
2076         Unreviewed trivial buildfix.
2077
2078         [Qt] Buildfix for r50333.
2079
2080         * DumpRenderTree/qt/DumpRenderTree.pro:
2081
2082 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2083
2084         Reviewed by Holger Freyther.
2085
2086         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2087         https://bugs.webkit.org/show_bug.cgi?id=30953
2088
2089         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2090         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2091         makes qt DRT to share this implementation (as gtk and mac ports do).
2092
2093         * DumpRenderTree/qt/DumpRenderTree.pro:
2094         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2095         * DumpRenderTree/qt/WorkQueue.h: Removed.
2096
2097 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2098
2099         Unreviewed potential buildbot fix.
2100
2101         Second try: Reset page history before running each test.
2102
2103         Apparently the QWebHistory::clear() keeps the current page
2104         in history which is not what we want, so we not additionally
2105         sets the history capacity to 0 (forces removing everything)
2106         and then sets it back to its original value.
2107
2108         * DumpRenderTree/qt/DumpRenderTree.cpp:
2109         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2110
2111 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2112
2113         Unreviewed potential buildbot fix.
2114
2115         Reset page history before running each test.
2116
2117         * DumpRenderTree/qt/DumpRenderTree.cpp:
2118         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2119
2120 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2121
2122         Reviewed by Eric Seidel.
2123
2124         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2125
2126         Bug 28420 -  Implement HTML5 <ruby> rendering
2127         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2128
2129         No new tests (no functional change).
2130
2131         * Scripts/build-webkit:
2132
2133 2009-10-29  Dan Bernstein  <mitz@apple.com>
2134
2135         Reviewed by Mark Rowe.
2136
2137         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2138         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2139         define it.
2140
2141         * Scripts/VCSUtils.pm:
2142         * Scripts/svn-apply:
2143         * Scripts/svn-unapply:
2144
2145 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2146
2147         Reviewed by Gustavo Noronha.
2148
2149         Use the GTK+ main loop instead of rolling our own mini-version of
2150         it.
2151
2152         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2153         (dump):
2154         (runTest):
2155         (webViewLoadFinished):
2156
2157 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2158
2159         Reviewed by Oliver Hunt.
2160
2161         Implement the Qt version of DRT dumpBackForwardList().
2162
2163         * DumpRenderTree/qt/DumpRenderTree.cpp:
2164         (WebCore::dumpHistoryItem):
2165         (WebCore::DumpRenderTree::dumpBackForwardList):
2166
2167 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2168
2169         Reviewed by Adam Roben.
2170
2171         Implement DRT functionality for Qt introduced in
2172         r28690 and r28705.
2173
2174         - Implemented pathToLocalResource which exposes the functionality of
2175         converting a given unix path to the correct location on Windows.
2176         - Implemented a way to remove machine-dependent information from paths
2177         in layout test results.
2178
2179         * DumpRenderTree/qt/DumpRenderTree.cpp:
2180         (WebCore::urlSuitableForTestResult):
2181         (WebCore::WebPage::javaScriptConsoleMessage):
2182         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2183         (LayoutTestController::pathToLocalResource):
2184         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2185
2186 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2187
2188         Adding myself to the committers list.
2189
2190         * Scripts/modules/committers.py:
2191
2192 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2193
2194         Adding myself to the committers list.
2195
2196         * Scripts/modules/committers.py:
2197
2198 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2199
2200         Reviewed by Jan Alonzo.
2201
2202         [GTK] API to start inspector for a WebView
2203         https://bugs.webkit.org/show_bug.cgi?id=22551
2204
2205         Use the new inspector API to implement the LayoutTestController
2206         interfaces used to test the inspector.
2207
2208         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2209         (webInspectorInspectWebView):
2210         (createWebView):
2211         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2212         (LayoutTestController::showWebInspector):
2213         (LayoutTestController::closeWebInspector):
2214         (LayoutTestController::evaluateInWebInspector):
2215
2216 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2217
2218         Reviewed by Eric Seidel.
2219
2220         [Qt] WebFrame::counterValueForElementById must not be exposed
2221         https://bugs.webkit.org/show_bug.cgi?id=30882
2222
2223         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2224         (LayoutTestController::counterValueForElementById):
2225
2226 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2227
2228         Rubberstamped by Oliver Hunt.
2229
2230         Fix the warning:
2231
2232         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2233         declared with attribute warn_unused_result".
2234
2235         by actually checking the result. In the case it is null, an
2236         error has occoured, so treat it as the other fatal errors.
2237
2238         * DumpRenderTree/qt/DumpRenderTree.cpp:
2239         (WebCore::DumpRenderTree::initializeFonts):
2240
2241 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2242
2243         Reviewed by Darin Adler.
2244
2245         Provide a way to get counter values with layoutTestContoller
2246         https://bugs.webkit.org/show_bug.cgi?id=30555
2247
2248         Define layoutTestContoller.counterValueForElementById.
2249
2250         * DumpRenderTree/LayoutTestController.cpp:
2251         (counterValueForElementByIdCallback):
2252         (LayoutTestController::staticFunctions):
2253         * DumpRenderTree/LayoutTestController.h:
2254         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2255         (LayoutTestController::counterValueForElementById):
2256
2257 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2258
2259         Rubberstamped by Oliver Hunt.
2260
2261         Change two methods to be internal for DRT use only.
2262
2263         Part of [Qt] Review all new API in Qt 4.6
2264         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2265
2266         * DumpRenderTree/qt/DumpRenderTree.cpp:
2267         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2268         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2269         (LayoutTestController::whiteListAccessFromOrigin):
2270
2271 2009-10-27  Eric Seidel  <eric@webkit.org>
2272
2273         Reviewed by Adam Barth.
2274
2275         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2276         https://bugs.webkit.org/show_bug.cgi?id=30826
2277
2278         * Scripts/svn-apply:
2279          - Add () around all system() calls.
2280          - Use the correct system() == 0 or die instead of system() or die
2281          - Add descriptive messages to all die statements.
2282
2283 2009-10-27  Steve Block  <steveblock@google.com>
2284
2285         Reviewed by NOBODY.
2286
2287         Adds steveblock@google.com to list of committers.
2288
2289         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2290
2291 2009-10-27  Eric Seidel  <eric@webkit.org>
2292
2293         Reviewed by Adam Barth.
2294
2295         svn-apply can exit(0) even on patch failure
2296         https://bugs.webkit.org/show_bug.cgi?id=29622
2297
2298         * Scripts/svn-apply:
2299          - Add a bunch of "or die" statements, hopefully catching all
2300            possible cases where failure could still exit(0).
2301
2302 2009-10-27  Eric Seidel  <eric@webkit.org>
2303
2304         Reviewed by Adam Barth.
2305
2306         svn-* scripts should share code through VCSUtils.pm
2307         https://bugs.webkit.org/show_bug.cgi?id=30791
2308
2309         Just moving code into a shared location.
2310
2311         * Scripts/VCSUtils.pm:
2312         * Scripts/prepare-ChangeLog:
2313         * Scripts/resolve-ChangeLogs:
2314         * Scripts/svn-apply:
2315         * Scripts/svn-create-patch:
2316         * Scripts/svn-unapply:
2317         * Scripts/update-webkit:
2318
2319 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2320
2321         Suppress a huge number of MSVC warnings when building wxWebKit.
2322
2323         * wx/build/settings.py:
2324
2325 2009-10-26  Eric Seidel  <eric@webkit.org>
2326
2327         No review, just adding Mike Belshe to the committers list.
2328
2329         * Scripts/modules/committers.py:
2330
2331 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2332
2333         Reviewed by Darin Adler.
2334
2335         Make .rc files compile on Windows without depending on MFC headers
2336         https://bugs.webkit.org/show_bug.cgi?id=30750
2337
2338         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2339         windows.h instead of afxres.h because it exists even when MFC is not
2340         installed, and is all that's needed here.
2341
2342         * FindSafari/FindSafari.rc: Ditto
2343
2344 2009-10-24  Eric Seidel  <eric@webkit.org>
2345
2346         Reviewed by Adam Barth.
2347
2348         bugzilla-tool post-diff should know how to mark commit-queue=?
2349         https://bugs.webkit.org/show_bug.cgi?id=29202
2350
2351         * Scripts/bugzilla-tool:
2352          - Add --commit-queue option to post-diff, post-commits and create-bug.
2353         * Scripts/modules/bugzilla.py:
2354          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2355          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2356
2357 2009-10-23  Eric Seidel  <eric@webkit.org>
2358
2359         Reviewed by Adam Barth.
2360
2361         bugzilla-tool commit-queue does not notice modifications to committers.py
2362         https://bugs.webkit.org/show_bug.cgi?id=30084
2363
2364         * Scripts/bugzilla-tool:
2365          - Make commit-queue re-exec itself instead of using while(1).
2366          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2367          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2368
2369 2009-10-22  Eric Seidel  <eric@webkit.org>
2370
2371         Reviewed by Adam Barth.
2372
2373         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2374         https://bugs.webkit.org/show_bug.cgi?id=30634
2375
2376         * Scripts/bugzilla-tool:
2377          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2378          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2379
2380 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2381
2382         Reviewed by Eric Seidel.
2383
2384         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2385
2386         https://bugs.webkit.org/show_bug.cgi?id=30763
2387
2388         * pywebsocket/mod_pywebsocket/__init__.py:
2389         * pywebsocket/mod_pywebsocket/dispatch.py:
2390         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2391         * pywebsocket/mod_pywebsocket/standalone.py:
2392         * pywebsocket/setup.py:
2393         * pywebsocket/test/test_dispatch.py:
2394
2395 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2396
2397         Reviewed by David Levin.
2398
2399         REGRESSION: 2 failures in run-webkit-unittests
2400         https://bugs.webkit.org/show_bug.cgi?id=30645
2401
2402         * Scripts/modules/cpp_style_unittest.py:
2403         Fixed a few test scenarios which apparently lost some spaces from
2404         text literals.
2405
2406 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2407
2408         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2409
2410         * Scripts/webkitdirs.pm:
2411
2412 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2413
2414         Reviewed by Darin Adler.
2415
2416         Unification of using null device in perl scripts.
2417         https://bugs.webkit.org/show_bug.cgi?id=30572
2418
2419         * Scripts/VCSUtils.pm:
2420         * Scripts/bisect-builds:
2421         * Scripts/resolve-ChangeLogs:
2422         * Scripts/run-iexploder-tests:
2423         * Scripts/run-jsc:
2424         * Scripts/run-mangleme-tests:
2425         * Scripts/run-webkit-tests:
2426         * Scripts/webkitdirs.pm:
2427         Using File::Spec->devnull() instead of hard coded /dev/null.
2428
2429 2009-10-26  Eric Seidel  <eric@webkit.org>
2430
2431         Reviewed by Holger Freyther.
2432
2433         Reviewers are missing from committers.py
2434         https://bugs.webkit.org/show_bug.cgi?id=30733
2435
2436         * Scripts/modules/committers.py:
2437
2438 2009-10-23  Eric Seidel  <eric@webkit.org>
2439
2440         No review, only adding Alice to the list of reviewers.
2441
2442         * Scripts/modules/committers.py:
2443
2444 2009-10-23  Eric Seidel  <eric@webkit.org>
2445
2446         Reviewed by Eric Carlson.
2447
2448         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2449         https://bugs.webkit.org/show_bug.cgi?id=30700
2450
2451         * DumpRenderTree/mac/DumpRenderTree.mm:
2452         (resetDefaultsToConsistentValues): Update QuickTime version check.
2453
2454 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2455
2456         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get
2457         character measurement APIs that are private on Tiger.
2458
2459         * wx/build/settings.py:
2460
2461 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2462
2463         Reviewed by NOBODY (build fix).
2464         Build fix following bug #30696.
2465
2466         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2467         (LayoutTestController::evaluateScriptInIsolatedWorld):
2468
2469 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2470
2471         Reviewed by Sam Weinig & Geoff Garen.
2472
2473         https://bugs.webkit.org/show_bug.cgi?id=30696
2474         Enable isolated-worlds tests on mac.
2475
2476         Add private interface for DRT to invoke execution in a given world.
2477
2478         * DumpRenderTree/LayoutTestController.cpp:
2479         (evaluateScriptInIsolatedWorldCallback):
2480         (LayoutTestController::staticFunctions):
2481         * DumpRenderTree/LayoutTestController.h:
2482         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2483         (LayoutTestController::evaluateScriptInIsolatedWorld):
2484         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2485         (LayoutTestController::evaluateScriptInIsolatedWorld):
2486
2487 2009-10-21  Eric Seidel  <eric@webkit.org>
2488
2489         Reviewed by Adam Barth.
2490
2491         bugzilla-tool's "patch failed to download an apply" error should give more information
2492         https://bugs.webkit.org/show_bug.cgi?id=30632
2493
2494         * Scripts/modules/scm.py:
2495          - Use the common run_command method instead of custom POpen code.
2496          - Make run_command know how to take pipes as input.
2497         * Scripts/modules/scm_unittest.py:
2498          - Add new tests to cover change.
2499          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2500
2501 2009-10-21  Kent Tamura  <tkent@chromium.org>
2502
2503         Unreviewed.  Adding myself to the committers list.
2504
2505         * Scripts/modules/committers.py:
2506
2507 2009-10-21  Robin Dunn  <robin@alldunn.com>
2508
2509         Reviewed by Kevin Ollivier.
2510
2511         Update the Windows installer builder to work with Vista / Win 7 and with git.
2512
2513         https://bugs.webkit.org/show_bug.cgi?id=30649
2514
2515         * wx/build/build_utils.py:
2516         * wx/packaging/build-mac-installer.py:
2517         * wx/packaging/build-win-installer.py:
2518         * wx/packaging/wxWebKitInstaller.iss.in:
2519
2520 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2521
2522         Reviewed by Gustavo Noronha.
2523
2524         [GTK] Added conditional code to avoid using
2525         gdk_window_get_root_coords if we do not have a gtk+ release newer
2526         than 2.17.3.
2527         https://bugs.webkit.org/show_bug.cgi?id=30636
2528
2529         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2530
2531 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2532
2533         Reviewed by Eric Seidel.
2534
2535         [Qt] Added dummy implementation for keepWebHistory()
2536         https://bugs.webkit.org/show_bug.cgi?id=30592
2537
2538         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2539         (LayoutTestController::keepWebHistory):
2540         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2541
2542 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2543
2544         Reviewed by Xan Lopez.
2545
2546         [GTK] Fixed the double click condition, it is not double click if
2547         we move in just in one direction.
2548         https://bugs.webkit.org/show_bug.cgi?id=30636
2549
2550         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2551
2552 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2553
2554         Reviewed by Xan Lopez.
2555
2556         [GTK] Initialize the events completly before emitting them.
2557         https://bugs.webkit.org/show_bug.cgi?id=30633
2558
2559         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2560
2561 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2562
2563         wx build fix. Fix for when linking using --as-needed with gcc.
2564
2565         * wx/browser/wscript:
2566
2567 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2568
2569         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2570         to support all the features used by CURL backend.
2571
2572         * wx/build/settings.py:
2573         * wx/install-unix-extras:
2574
2575 2009-10-20  Anton Muhin  <antonm@chromium.org>
2576
2577         Reviewed by Adam Barth.
2578
2579         Add {ager,antonm,yurys}@chromium.org into committers.py
2580         https://bugs.webkit.org/show_bug.cgi?id=30560
2581
2582         * Scripts/modules/committers.py:
2583
2584 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2585
2586         Reviewed by Tor Arne Vestbø.
2587
2588         Make the Netscape Test plugin available to the Qt launcher.
2589
2590         * Scripts/run-launcher:
2591
2592 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2593
2594         Reviewed by David Levin.
2595
2596         Removed WebSocket runtime settings.
2597         https://bugs.webkit.org/show_bug.cgi?id=29896
2598
2599         WebSocket runtime configuration is supported by chromium/v8 only.
2600
2601         * DumpRenderTree/mac/DumpRenderTree.mm:
2602         (resetDefaultsToConsistentValues):
2603         * DumpRenderTree/win/DumpRenderTree.cpp:
2604         (resetDefaultsToConsistentValues):
2605
2606 2009-10-19  Nate Chapin  <japhet@chromium.org>
2607
2608         Reviewed by Adam Barth.
2609
2610         Add testFail() to test plugin so we can test our handling of a
2611         plugin invoke call returning false.
2612
2613         https://bugs.webkit.org/show_bug.cgi?id=30239
2614
2615         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2616         (pluginInvoke):
2617         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2618
2619 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2620
2621         Reviewed by Gustavo Noronha.
2622
2623         Enable DOM pasting when running layout tests.
2624
2625         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2626         (resetDefaultsToConsistentValues):
2627
2628 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2629
2630         Reviewed by Simon Hausmann.
2631
2632         Use the setPreferredContentsSize method instead
2633         of setFixedContentsSize, as the method has been renamed.
2634
2635         * DumpRenderTree/qt/DumpRenderTree.cpp:
2636         (WebCore::DumpRenderTree::open):
2637         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2638         (LayoutTestController::setFixedContentsSize):
2639
2640 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2641
2642         Reviewed by Dan Bernstein.
2643
2644         https://bugs.webkit.org/show_bug.cgi?id=30456
2645         Fixes for new Debug_All Windows build configuration.
2646
2647         * DumpRenderTree/win/DumpRenderTree.cpp:
2648         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2649         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2650
2651 2009-10-16  Eric Seidel  <eric@webkit.org>
2652
2653         Reviewed by Adam Barth.
2654
2655         commit-queue status bot should list which buildbot is blocking the queue
2656         https://bugs.webkit.org/show_bug.cgi?id=30452
2657
2658         Add new methods and testing.
2659
2660         * Scripts/bugzilla-tool:
2661         * Scripts/modules/buildbot.py:
2662         * Scripts/modules/buildbot_unittest.py:
2663
2664 2009-10-16  Eric Seidel  <eric@webkit.org>
2665
2666         Reviewed by Adam Barth.
2667
2668         run-webkit-tests fails when CWD is not inside a WebKit checkout
2669         https://bugs.webkit.org/show_bug.cgi?id=30451
2670
2671         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2672         * Scripts/modules/scm_unittest.py:
2673           - Remove use of original_path (we don't need to restore the CWD).
2674           - Don't use '.' to find the webkit checkout, use __file__ instead.
2675
2676 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2677
2678         Reviewed by Adam Roben.
2679
2680         Add a Debug_All configuration to build entire stack as debug.
2681         Change Debug_Internal to:
2682         - stop using _debug suffix for all WebKit/Safari binaries
2683         - not use _debug as a DLL naming suffix
2684         - use non-debug C runtime lib.
2685
2686         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2687         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2688         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2689         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2690         Add missing debug.vsprops inherited property sheet.
2691         Add Debug_All configuration.
2692         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2693         * WinLauncher/WinLauncher.vcproj:
2694         Removed extraneous definitions inherited from vsprops.
2695         Add Debug_All configuration.
2696
2697 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2698
2699         Reviewed by David Levin.
2700
2701         check-webkit-style is wrong about indent checking in namespaces
2702         in header files and a few other things
2703         https://bugs.webkit.org/show_bug.cgi?id=30362
2704
2705         The few other things include:
2706         + check-webkit-style does not require spaces around the equal sign
2707           inside 'if' statements and around binary operators that take
2708           numeric literals.
2709         + check-webkit-style reports false errors for the / operator
2710           when part of a filename in the #include directive.
2711
2712         * Scripts/modules/cpp_style.py:
2713         Improved indentation checking and space checking around
2714         binary operators. While the checks are still not perfect,
2715         they are clearly better than before.
2716         * Scripts/modules/cpp_style_unittest.py:
2717         Added test cases for the newly supported checks and modified old
2718         test cases to match the new guidelines
2719
2720 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2721
2722         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2723
2724         * wx/build/settings.py:
2725
2726 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2727
2728         Reviewed by David Levin.
2729
2730         Add mod_pywebsocket to test Web Sockets.
2731         http://code.google.com/p/pywebsocket/
2732         https://bugs.webkit.org/show_bug.cgi?id=27490
2733
2734         * pywebsocket/COPYING: Added.
2735         * pywebsocket/MANIFEST.in: Added.
2736         * pywebsocket/README: Added.
2737         * pywebsocket/example/echo_client.py: Added.
2738         * pywebsocket/example/echo_wsh.py: Added.
2739         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2740         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2741         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2742         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2743         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2744         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2745         * pywebsocket/mod_pywebsocket/util.py: Added.
2746         * pywebsocket/setup.py: Added.
2747         * pywebsocket/test/config.py: Added.
2748         * pywebsocket/test/mock.py: Added.
2749         * pywebsocket/test/run_all.py: Added.
2750         * pywebsocket/test/test_dispatch.py: Added.
2751         * pywebsocket/test/test_handshake.py: Added.
2752         * pywebsocket/test/test_mock.py: Added.
2753         * pywebsocket/test/test_msgutil.py: Added.
2754         * pywebsocket/test/test_util.py: Added.
2755         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2756         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2757         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2758         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2759         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2760         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2761         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2762         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2763
2764 2009-10-15  James Robinson  <jamesr@google.com>
2765
2766         Reviewed by David Levin.
2767
2768         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2769
2770         https://bugs.webkit.org/show_bug.cgi?id=30426
2771
2772         * Scripts/modules/cpp_style.py:
2773         * Scripts/modules/cpp_style_unittest.py:
2774
2775 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2776
2777         Reviewed by Adam Roben.
2778
2779         Fixes <http://webkit.org/b/30411>.
2780         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2781
2782         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2783         building Chromium.
2784
2785         * Scripts/pdevenv:
2786
2787 2009-10-15  Robin Dunn  <robin@alldunn.com>
2788
2789         Reviewed by Kevin Ollivier.
2790
2791         Add Mac package building scripts for wx.
2792
2793         https://bugs.webkit.org/show_bug.cgi?id=30405
2794
2795         * wx/build/build_utils.py:
2796         * wx/build/settings.py:
2797         * wx/packaging/build-mac-installer.py: Added.
2798
2799 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2800
2801         Reviewed by Gustavo Noronha.
2802
2803         Enable Web Sockets support when running layout tests.
2804
2805         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2806         (resetDefaultsToConsistentValues):
2807
2808 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2809
2810         Reviewed by Gustavo Noronha.
2811
2812         Need to initialize event.button.button, since in most cases a
2813         button number is not passed as an argument.
2814
2815         * DumpRenderTree/gtk/EventSender.cpp:
2816         (mouseDownCallback):
2817         (mouseUpCallback):
2818
2819 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
2820
2821         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
2822         the OS if none was explicitly set.
2823
2824         * wx/build/settings.py:
2825
2826 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2827
2828         Reviewed by Timothy Hatcher.
2829
2830         Web Inspector: enable developers extras within inspector layout tests.
2831
2832         https://bugs.webkit.org/show_bug.cgi?id=30014
2833
2834         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2835         (LayoutTestController::showWebInspector):
2836         (LayoutTestController::closeWebInspector):
2837         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2838         (LayoutTestController::showWebInspector):
2839         (LayoutTestController::closeWebInspector):
2840
2841 2009-10-14  José Millán Soto  <jmillan@igalia.com>
2842
2843         Reviewed by Jan Alonzo.
2844
2845         GtkLauncher is using a deprecated signal
2846         https://bugs.webkit.org/show_bug.cgi?id=30364
2847
2848         Modified GtkLauncher to use notify::title signal instead of
2849         deprecated title-changed signal
2850
2851         * GtkLauncher/main.c:
2852         (notify_title_cb):
2853         (create_browser):
2854
2855 2009-10-14  Brady Eidson  <beidson@apple.com>
2856
2857         Reviewed by Sam Weinig.
2858
2859         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
2860         1 - Disables WebHistory
2861         2 - Doesn't make sense in that context anyway.
2862
2863         * DumpRenderTree/win/DumpRenderTree.cpp:
2864         (createWebViewAndOffscreenWindow):
2865
2866 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
2867
2868         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
2869         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
2870
2871         * wx/build/settings.py:
2872         * wx/install-unix-extras:
2873
2874 2009-10-14  Brady Eidson  <beidson@apple.com>
2875
2876         Reviewed by Sam Weinig.
2877
2878         WebKit Win API should provide a delegate interface for global history.
2879         https://bugs.webkit.org/show_bug.cgi?id=29905
2880
2881         * DumpRenderTree/LayoutTestController.cpp:
2882         (LayoutTestController::LayoutTestController):
2883         * DumpRenderTree/LayoutTestController.h:
2884         (LayoutTestController::dumpHistoryDelegateCallbacks):
2885         (LayoutTestController::setDumpHistoryDelegateCallbacks):
2886
2887         * DumpRenderTree/win/DumpRenderTree.cpp:
2888         (shouldLogHistoryDelegates):
2889         (runTest):
2890         (createWebViewAndOffscreenWindow):
2891         (main):
2892         * DumpRenderTree/win/DumpRenderTree.vcproj:
2893
2894         Add the IWebHistoryDelegate to DRT Windows:
2895         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
2896         (wstringFromBSTR):
2897         (HistoryDelegate::HistoryDelegate):
2898         (HistoryDelegate::~HistoryDelegate):
2899         (HistoryDelegate::QueryInterface):
2900         (HistoryDelegate::AddRef):
2901         (HistoryDelegate::Release):
2902         (HistoryDelegate::didNavigateWithNavigationData):
2903         (HistoryDelegate::didPerformClientRedirectFromURL):
2904         (HistoryDelegate::didPerformServerRedirectFromURL):
2905         (HistoryDelegate::updateHistoryTitle):
2906         (HistoryDelegate::populateVisitedLinksForWebView):
2907         * DumpRenderTree/win/HistoryDelegate.h: Added.
2908
2909         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2910         (LayoutTestController::removeAllVisitedLinks):
2911
2912 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
2913
2914         Reviewed by Simon Hausmann.
2915
2916         [Qt] Implement support for setPOSIXLocale on Qt.
2917         https://bugs.webkit.org/show_bug.cgi?id=30268
2918
2919         * DumpRenderTree/qt/DumpRenderTree.cpp:
2920         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2921         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2922         (LayoutTestController::setPOSIXLocale):
2923         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2924
2925 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2926
2927         Unreviewed, adding myself to reviewers list.
2928
2929         * Scripts/modules/committers.py:
2930
2931 2009-10-13  Stephanie Lewis  <slewis@apple.com>
2932
2933         Reviewed by Mark Rowe.
2934
2935         Fix null assignment so root tests work again.
2936
2937         * Scripts/webkitdirs.pm:
2938
2939 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2940
2941         Reviewed by Simon Hausmann.
2942
2943         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
2944         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
2945         This is done in preparation of implementing missing features in DRT.
2946         No functionality changes made yet.
2947
2948         * DumpRenderTree/qt/DumpRenderTree.cpp:
2949         * DumpRenderTree/qt/DumpRenderTree.pro:
2950         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
2951         (EventSender::EventSender):
2952         (EventSender::mouseDown):
2953         (EventSender::mouseUp):
2954         (EventSender::mouseMoveTo):
2955         (EventSender::leapForward):
2956         (EventSender::keyDown):
2957         (EventSender::contextClick):
2958         (EventSender::scheduleAsynchronousClick):
2959         (EventSender::frameUnderMouse):
2960         * DumpRenderTree/qt/EventSenderQt.h: Added.
2961         (EventSender::clearKillRing):
2962         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
2963         (LayoutTestController::LayoutTestController):
2964         (LayoutTestController::reset):
2965         (LayoutTestController::processWork):
2966         (LayoutTestController::maybeDump):
2967         (LayoutTestController::waitUntilDone):
2968         (LayoutTestController::notifyDone):
2969         (LayoutTestController::windowCount):
2970         (LayoutTestController::clearBackForwardList):
2971         (LayoutTestController::dumpEditingCallbacks):
2972         (LayoutTestController::dumpResourceLoadCallbacks):
2973         (LayoutTestController::queueBackNavigation):
2974         (LayoutTestController::queueForwardNavigation):
2975         (LayoutTestController::queueLoad):
2976         (LayoutTestController::queueReload):
2977         (LayoutTestController::queueScript):
2978         (LayoutTestController::provisionalLoad):
2979         (LayoutTestController::timerEvent):
2980         (LayoutTestController::encodeHostName):
2981         (LayoutTestController::decodeHostName):
2982         (LayoutTestController::setJavaScriptProfilingEnabled):
2983         (LayoutTestController::setFixedContentsSize):
2984         (LayoutTestController::setPrivateBrowsingEnabled):
2985         (LayoutTestController::setPopupBlockingEnabled):
2986         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2987         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2988         (LayoutTestController::numberOfActiveAnimations):
2989         (LayoutTestController::disableImageLoading):
2990         (LayoutTestController::dispatchPendingLoadRequests):
2991         (LayoutTestController::setDatabaseQuota):
2992         (LayoutTestController::clearAllDatabases):
2993         (LayoutTestController::whiteListAccessFromOrigin):
2994         (LayoutTestController::waitForPolicyDelegate):
2995         (LayoutTestController::overridePreference):
2996         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
2997         (LayoutTestController::isLoading):
2998         (LayoutTestController::setLoading):
2999         (LayoutTestController::shouldDumpAsText):
3000         (LayoutTestController::shouldDumpBackForwardList):
3001         (LayoutTestController::shouldDumpChildrenAsText):
3002         (LayoutTestController::shouldDumpDatabaseCallbacks):
3003         (LayoutTestController::shouldDumpStatusCallbacks):
3004         (LayoutTestController::shouldWaitUntilDone):
3005         (LayoutTestController::canOpenWindows):
3006         (LayoutTestController::shouldDumpTitleChanges):
3007         (LayoutTestController::waitForPolicy):
3008         (LayoutTestController::dumpAsText):
3009         (LayoutTestController::dumpChildFramesAsText):
3010         (LayoutTestController::dumpDatabaseCallbacks):
3011         (LayoutTestController::dumpStatusCallbacks):
3012         (LayoutTestController::setCanOpenWindows):
3013         (LayoutTestController::dumpBackForwardList):
3014         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3015         (LayoutTestController::display):
3016         (LayoutTestController::dumpTitleChanges):
3017         (LayoutTestController::dumpSelectionRect):
3018         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3019         (TextInputController::TextInputController):
3020         (TextInputController::doCommand):
3021         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3022         * DumpRenderTree/qt/WorkQueue.cpp:
3023         * DumpRenderTree/qt/WorkQueue.h:
3024         * DumpRenderTree/qt/WorkQueueItem.h:
3025         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3026         (findFrameNamed):
3027         (LoadItem::invoke):
3028         (ReloadItem::invoke):
3029         (ScriptItem::invoke):
3030         (BackForwardItem::invoke):
3031         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3032         * DumpRenderTree/qt/jsobjects.h:
3033
3034 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3035
3036         Not reviewed, adding myself to the list of reviewers.
3037
3038         * Scripts/modules/committers.py:
3039
3040 2009-10-13  Anders Carlsson  <andersca@apple.com>
3041
3042         Reviewed by Sam Weinig.
3043
3044         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3045
3046         Make the private browsing mode testable by the test plug-in.
3047
3048         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3049         (pluginGetProperty):
3050         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3051         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3052         (NPP_New):
3053         (NPP_SetValue):
3054
3055 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3056
3057         No review, just adding self to the list of reviewers.
3058
3059         * Scripts/modules/committers.py:
3060
3061 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3062
3063         Reviewed by Adam Roben.
3064
3065         Web Inspector: Use proper web view in inspector layout
3066         tests for windows.
3067
3068         https://bugs.webkit.org/show_bug.cgi?id=30298
3069
3070         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3071         (LayoutTestController::showWebInspector):
3072         (LayoutTestController::closeWebInspector):
3073         (LayoutTestController::evaluateInWebInspector):
3074
3075 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3076
3077         Reviewed by Sam Weinig.
3078
3079         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3080         https://bugs.webkit.org/show_bug.cgi?id=29841
3081
3082         * DumpRenderTree/mac/DumpRenderTree.mm:
3083         (resetDefaultsToConsistentValues):
3084         * DumpRenderTree/win/DumpRenderTree.cpp:
3085         (resetDefaultsToConsistentValues):
3086
3087 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3088
3089         Reviewed by Dimitri Glazkov.
3090
3091         Chromium Port - Windows
3092         https://bugs.webkit.org/show_bug.cgi?id=29969
3093
3094         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3095         * Scripts/webkitdirs.pm:
3096
3097 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3098
3099         Reviewed by Darin Adler.
3100
3101         jsc scripts cleanup and Qt/GTK fix
3102         https://bugs.webkit.org/show_bug.cgi?id=30288
3103
3104         Duplicated jscPath() moved to webkitdirs.pm.
3105         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3106         Configuration added (release/debug) to path for Qt-port on Windows.
3107
3108         * Scripts/run-javascriptcore-tests:
3109         * Scripts/run-jsc:
3110         * Scripts/run-sunspider:
3111         * Scripts/sunspider-compare-results:
3112         * Scripts/webkitdirs.pm:
3113
3114 2009-10-11  Adam Barth  <abarth@webkit.org>
3115
3116         Unreviewed.  Add Collin to committers.py.
3117
3118         * Scripts/modules/committers.py:
3119
3120 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3121
3122         wx build fix, add bindings to source/include dirs now that there are sources there.
3123
3124         * wx/build/settings.py:
3125
3126 2009-10-09  Mark Rowe  <mrowe@apple.com>
3127
3128         Reviewed by Brady Eidson.
3129
3130         Enable plug-in halting in DumpRenderTree.
3131
3132         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3133         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3134
3135         * DumpRenderTree/mac/DumpRenderTree.mm:
3136         (resetDefaultsToConsistentValues):
3137         * DumpRenderTree/mac/UIDelegate.mm:
3138         (-[UIDelegate webView:shouldHaltPlugin:]):
3139
3140 2009-10-08  Brady Eidson  <beidson@apple.com>
3141
3142         Reviewed by Dan Bernstein.
3143
3144         Ask the History Delegate to populate the visited links hash.
3145         <rdar://problem/7285293> and https://webkit.org/b/29904
3146
3147         Add the ability for LayoutTestController to clear all visited links.
3148         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3149
3150         * DumpRenderTree/LayoutTestController.cpp:
3151         (LayoutTestController::LayoutTestController):
3152         (removeAllVisitedLinksCallback):
3153         (LayoutTestController::staticFunctions):
3154         * DumpRenderTree/LayoutTestController.h:
3155         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3156         (LayoutTestController::removeAllVisitedLinks):
3157
3158         * DumpRenderTree/mac/HistoryDelegate.mm:
3159         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3160
3161         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3162         (LayoutTestController::removeAllVisitedLinks):
3163         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3164         (LayoutTestController::removeAllVisitedLinks):
3165         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3166         (LayoutTestController::removeAllVisitedLinks):
3167
3168
3169 2009-10-08  Daniel Bates  <dbates@webkit.org>
3170
3171         Reviewed by Adam Roben.
3172
3173         https://bugs.webkit.org/show_bug.cgi?id=30175
3174
3175         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3176         the OLE drag-and-drop return value like the function it emulates. Currently,
3177         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine
3178         whether the drag-and-drop operation was successful or was cancelled.
3179
3180         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop
3181         return value according to whether the drop operation was successful or not.
3182
3183         * DumpRenderTree/win/EventSender.cpp:
3184         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3185         (replaySavedEvents): Ditto.
3186         * DumpRenderTree/win/EventSender.h:
3187         * DumpRenderTree/win/UIDelegate.cpp:
3188         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3189
3190 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3191
3192         Reviewed by Xan Lopez.
3193
3194         [GTK] Added support for a parameter setting the button that was
3195         pressed in the mouseDown function.
3196         https://bugs.webkit.org/show_bug.cgi?id=30220
3197
3198         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3199
3200 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3201
3202         Reviewed by Xan Lopez.
3203
3204         [GTK] Added a line to the bottom of the expected result to match
3205         the output of the test.
3206         https://bugs.webkit.org/show_bug.cgi?id=30220
3207
3208         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3209         expected.txt:
3210
3211 2009-10-08  Adam Roben  <aroben@apple.com>
3212
3213         Use QueryInterface to get IWebInspectorPrivate
3214
3215         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3216         accessed in a more standard way
3217
3218         Reviewed by John Sullivan and Tim Hatcher.
3219
3220         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3221         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3222         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3223         to the IWebInspectorPrivate interface.
3224
3225 2009-10-07  Adam Roben  <aroben@apple.com>
3226
3227         Implement DRT support for origin whitelisting
3228
3229         Fixes <http://webkit.org/b/30185>.
3230
3231         Reviewed by Eric Seidel.
3232
3233         * DumpRenderTree/win/DumpRenderTree.cpp:
3234         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3235         whitelist, to match Mac DRT.
3236         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3237         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3238         IWebViewPrivate::whiteListAccessFromOrigin.
3239
3240 2009-10-07  Brady Eidson  <beidson@apple.com>
3241
3242         Reviewed by Darin Adler.
3243
3244         Send title changes to the global history delegate.
3245         <rdar://problem/7285293> and https://webkit.org/b/29904
3246
3247         * DumpRenderTree/mac/HistoryDelegate.mm:
3248         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3249
3250 2009-10-07  Adam Barth  <abarth@webkit.org>
3251
3252         Unreviewed.  Remove some folks from committers.py who were listed on
3253         the WebKit Team wiki page but who weren't actually listed as commit+.
3254         At some point, we should coorelate this list with the committers
3255         mailing list.
3256
3257         * Scripts/modules/committers.py:
3258
3259 2009-10-07  Adam Barth  <abarth@webkit.org>
3260
3261         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3262         the wiki into committers.py.
3263
3264         * Scripts/modules/committers.py:
3265
3266 2009-10-07  Adam Barth  <abarth@webkit.org>
3267
3268         Unreviewed.  Added Aaron Boodman to committers.py.
3269
3270         * Scripts/modules/committers.py:
3271
3272 2009-10-07  Evan Martin  <evan@chromium.org>
3273
3274         Reviewed by Darin Adler.
3275
3276         Add API to LayoutTestController for re/setting the system locale.
3277         https://bugs.webkit.org/show_bug.cgi?id=18994
3278
3279         * DumpRenderTree/LayoutTestController.cpp:
3280         (setLocaleCallback):
3281         (LayoutTestController::staticFunctions):
3282         (LayoutTestController::setLocale):
3283         * DumpRenderTree/LayoutTestController.h:
3284
3285 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3286
3287         Reviewed by Jan Alonzo.
3288
3289         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3290         https://bugs.webkit.org/show_bug.cgi?id=29689
3291
3292         Build fix by adding -lfontconfig for DumpRenderTree.
3293
3294         * GNUmakefile.am:
3295
3296 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3297
3298         Reviewed by Simon Hausmann.
3299
3300         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3301
3302         * Scripts/run-webkit-tests:
3303
3304 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3305
3306         Reviewed by Gustavo Noronha.
3307
3308         "delete" in EventSender is the backspace key, not the delete one.
3309
3310         * DumpRenderTree/gtk/EventSender.cpp:
3311         (keyDownCallback):
3312
3313 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3314
3315         Reviewed by Gustavo Noronha.
3316
3317         getChildrenWithRange expects as last parameter the end index, not
3318         the length of the range. Correct this and clarify the variable
3319         names to reflect how the code works.
3320
3321         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3322         (AccessibilityUIElement::getChildrenWithRange):
3323         (AccessibilityUIElement::getChildAtIndex):
3324
3325 2009-10-06  Mark Rowe  <mrowe@apple.com>
3326
3327         Reviewed by Simon Fraser.
3328
3329         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3330
3331         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3332         the fact we have already changed the working directory to the top of the open source tree.
3333
3334 2009-10-06  Julie Parent  <jparent@chromium.org>
3335
3336         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3337         rather than my committer email.
3338
3339         * Scripts/modules/committers.py:
3340
3341 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3342
3343         Reviewed by Eric Seidel.
3344
3345         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3346
3347         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3348         it after each layout test as it should do, making the DRT dump additional output
3349         for all of the subsequent layout tests.
3350
3351         * DumpRenderTree/qt/jsobjects.cpp:
3352         (LayoutTestController::reset):
3353
3354 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3355
3356         Reviewed by Simon Hausmann.
3357
3358         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3359         fast/dom/assign-to-window-status.html test, which is passing as a result.
3360
3361         https://bugs.webkit.org/show_bug.cgi?id=30127
3362
3363         * DumpRenderTree/qt/DumpRenderTree.cpp:
3364         (WebCore::DumpRenderTree::DumpRenderTree):
3365         (WebCore::DumpRenderTree::statusBarMessage):
3366         * DumpRenderTree/qt/DumpRenderTree.h:
3367         * DumpRenderTree/qt/jsobjects.h:
3368         (LayoutTestController::shouldDumpStatusCallbacks):
3369         (LayoutTestController::dumpStatusCallbacks):
3370
3371 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3372
3373         Reviewed by Simon Hausmann.
3374
3375         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3376         ignores the argument indicating which mouse button to trigger.
3377         https://bugs.webkit.org/show_bug.cgi?id=30048
3378
3379         This affects the fast/events/mouse-click-events.html layout test.
3380
3381         * DumpRenderTree/qt/jsobjects.cpp:
3382         (EventSender::mouseDown):
3383         (EventSender::mouseUp):
3384         * DumpRenderTree/qt/jsobjects.h:
3385
3386 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3387
3388         Reviewed by Simon Hausmann.
3389
3390         [Qt] Fix the EventSender::keyDown() implementation
3391         https://bugs.webkit.org/show_bug.cgi?id=30043
3392
3393         It should post both a key press event and a key release event,
3394         just like other ports do.
3395
3396         * DumpRenderTree/qt/jsobjects.cpp:
3397         (EventSender::keyDown):
3398
3399 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
3400
3401         wx build fix. Add jpeg to the list of libs to link against.
3402
3403         * wx/build/settings.py:
3404
3405 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3406
3407         Reviewed by Simon Hausmann.
3408
3409         [Qt] EventSender::keyDown() cannot send function-key events.
3410         https://bugs.webkit.org/show_bug.cgi?id=30044
3411
3412         This affects the fast/events/keydown-function-keys.html layout test.
3413
3414         * DumpRenderTree/qt/jsobjects.cpp:
3415         (EventSender::keyDown):
3416
3417 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3418
3419         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3420         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3421
3422         * wx/build/settings.py:
3423         * wx/build/wxpresets.py:
3424
3425 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3426
3427         Reviewed by Timothy Hatcher.
3428
3429         Web Inspector: add testing harness for Web Inspector.
3430
3431         https://bugs.webkit.org/show_bug.cgi?id=30010
3432
3433         * DumpRenderTree/LayoutTestController.cpp:
3434         (showWebInspectorCallback):
3435         (closeWebInspectorCallback):
3436         (evaluateInWebInspectorCallback):
3437         (LayoutTestController::staticFunctions):
3438         * DumpRenderTree/LayoutTestController.h:
3439         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3440         (LayoutTestController::showWebInspector):
3441         (LayoutTestController::closeWebInspector):
3442         (LayoutTestController::evaluateInWebInspector):
3443         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3444         (LayoutTestController::showWebInspector):
3445         (LayoutTestController::closeWebInspector):
3446         (LayoutTestController::evaluateInWebInspector):
3447         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3448         (LayoutTestController::showWebInspector):
3449         (LayoutTestController::closeWebInspector):
3450         (LayoutTestController::evaluateInWebInspector):
3451         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3452         (LayoutTestController::showWebInspector):
3453         (LayoutTestController::closeWebInspector):
3454         (LayoutTestController::evaluateInWebInspector):
3455
3456 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3457
3458         Reviewed by Ariyha Hidayat.
3459
3460         Pass arguments to system() as a string instead of array
3461
3462         When passed as an array entries with a space fail to translate
3463         to two arguments to the child process, so instead of manually
3464         splitting all the entries in @buildArgs we pass the whole thing
3465         as a string instead.
3466
3467         * Scripts/webkitdirs.pm:
3468
3469 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3470
3471         Reviewed by David Levin.
3472
3473         check-webkit-style misses whitespace errors for operators:
3474         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3475         https://bugs.webkit.org/show_bug.cgi?id=30021
3476
3477         * Scripts/modules/cpp_style.py:
3478         Added the operators mentioned above to the same list as == and !=.
3479
3480 2009-10-02  Julie Parent  <jparent@chromium.org>
3481
3482         Unreviewed.
3483
3484         Adding myself and Ojan Vafai as committers, because we are committers.
3485
3486         * Scripts/modules/committers.py:
3487
3488 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3489
3490         Reviewed by Adam Roben.
3491
3492         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3493         this will help the patch merging process when TryBots are used.
3494
3495         * Scripts/svn-create-patch:
3496
3497 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
3498
3499         Reviewed by Simon Hausmann.
3500
3501         [Qt] Implement layoutTestController.overridePreference().
3502         https://bugs.webkit.org/show_bug.cgi?id=29970
3503
3504         * DumpRenderTree/qt/DumpRenderTree.cpp:
3505         (WebCore::WebPage::WebPage):
3506         (WebCore::WebPage::resetSettings):
3507         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3508         * DumpRenderTree/qt/jsobjects.cpp:
3509         (LayoutTestController::reset):
3510         (LayoutTestController::setPrivateBrowsingEnabled):
3511         (LayoutTestController::setPopupBlockingEnabled):
3512         (LayoutTestController::overridePreference):
3513         * DumpRenderTree/qt/jsobjects.h:
3514
3515 2009-10-01  Chris Marrin  <cmarrin@apple.com>
3516
3517         Reviewed by Oliver Hunt.
3518
3519         Turn on ENABLE_3D_CANVAS in TOT
3520         https://bugs.webkit.org/show_bug.cgi?id=29906
3521
3522         * Scripts/build-webkit:
3523
3524 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3525
3526         Rubberstamped by Simon Hausmann.
3527
3528         Enable HTTP tests for Qt
3529
3530         * Scripts/run-webkit-tests:
3531
3532 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3533
3534         Reviewed by Dimitri Glazkov.
3535
3536         build-webkit --chromium now also works on cygwin.
3537
3538         https://bugs.webkit.org/show_bug.cgi?id=29973
3539
3540         * Scripts/webkitdirs.pm:
3541
3542 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3543
3544         Reviewed by Simon Hausmann.
3545
3546         [Qt] Don't use TCmalloc in DumpRenderTree
3547         https://bugs.webkit.org/show_bug.cgi?id=27029
3548
3549         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3550
3551         * DumpRenderTree/qt/DumpRenderTree.pro:
3552
3553 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3554
3555         Reviewed by Simon Hausmann.
3556
3557         [Qt] Implement eventSender.scheduleAsynchronousClick().
3558
3559         https://bugs.webkit.org/show_bug.cgi?id=29931
3560
3561         * DumpRenderTree/qt/jsobjects.cpp:
3562         (EventSender::scheduleAsynchronousClick):
3563         * DumpRenderTree/qt/jsobjects.h:
3564
3565 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3566
3567         Reviewed by Simon Hausmann.
3568
3569         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
3570         fast/events/open-window-from-another-frame.html from the Skipped list.
3571
3572         https://bugs.webkit.org/show_bug.cgi?id=29930
3573
3574         * DumpRenderTree/qt/jsobjects.cpp:
3575         (LayoutTestController::setPopupBlockingEnabled):
3576         * DumpRenderTree/qt/jsobjects.h:
3577
3578 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
3579
3580         Unreviewed.
3581
3582         Added myself to the list of committers.
3583
3584         * Scripts/modules/committers.py:
3585
3586 2009-09-30  Eric Seidel  <eric@webkit.org>
3587
3588         No review, just adding Geoff to the list of reviewers.
3589
3590         * Scripts/modules/committers.py:
3591
3592 2009-09-30  Dan Bernstein  <mitz@apple.com>
3593
3594         Reviewed by Sam Weinig.
3595
3596         Added the WebKit Layout Tests fonts that are referenced in
3597         LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css
3598
3599         * DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
3600         * DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.
3601
3602 2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3603
3604         Reviewed by David Kilzer.
3605
3606         Make sunspider scripts work on Windows platform.
3607         https://bugs.webkit.org/show_bug.cgi?id=29656
3608
3609         * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
3610         * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
3611         * Scripts/webkitdirs.pm: currentPerlPath() added.
3612
3613 2009-09-29  Brady Eidson  <beidson@apple.com>
3614
3615         Rubberstamped by Dan Bernstein.
3616
3617         Fix license and some sorting in new files.
3618
3619         * DumpRenderTree/mac/HistoryDelegate.h:
3620         * DumpRenderTree/mac/HistoryDelegate.mm:
3621
3622 2009-09-29  Yaar Schnitman  <yaar@chromium.org>
3623
3624         Reviewed by David Kilzer.
3625
3626         Fixed how error codes are handled.
3627         https://bugs.webkit.org/show_bug.cgi?id=29898
3628
3629         * Scripts/update-webkit:
3630         * Scripts/update-webkit-chromium:
3631
3632 2009-09-29  Brady Eidson  <beidson@apple.com>
3633
3634         Reviewed by John Sullivan.
3635
3636         Updated way-out-of-date sorting throughout the dump methods/flags.
3637
3638         * DumpRenderTree/LayoutTestController.cpp:
3639         (LayoutTestController::LayoutTestController):
3640         (dumpAsPDFCallback):
3641         (dumpAsTextCallback):
3642         (dumpFrameLoadCallbacksCallback):
3643         (dumpResourceLoadCallbacksCallback):
3644         (LayoutTestController::staticFunctions):
3645
3646         * DumpRenderTree/LayoutTestController.h:
3647         (LayoutTestController::dumpAsText):
3648         (LayoutTestController::setDumpAsText):
3649         (LayoutTestController::dumpFrameLoadCallbacks):
3650         (LayoutTestController::setDumpFrameLoadCallbacks):
3651         (LayoutTestController::dumpSelectionRect):
3652         (LayoutTestController::setDumpSelectionRect):
3653         (LayoutTestController::dumpSourceAsWebArchive):
3654         (LayoutTestController::setDumpSourceAsWebArchive):
3655         (LayoutTestController::dumpStatusCallbacks):
3656         (LayoutTestController::setDumpStatusCallbacks):
3657         (LayoutTestController::dumpTitleChanges):
3658         (LayoutTestController::setDumpTitleChanges):
3659         (LayoutTestController::dumpWillCacheResponse):
3660         (LayoutTestController::setDumpWillCacheResponse):
3661
3662 2009-09-29  Brady Eidson  <beidson@apple.com>
3663
3664         Reviewed by John Sullivan.
3665
3666         WebKit Mac API should provide a delegate interface for global history.
3667         <rdar://problem/7042773> and https://webkit.org/b/29904
3668
3669         Adding the dumping of global history delegate callbacks.
3670
3671         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3672
3673         Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
3674         * DumpRenderTree/mac/DumpRenderTree.mm:
3675         (createWebViewAndOffscreenWindow):
3676         (allocateGlobalControllers):
3677         (shouldLogFrameLoadDelegates):
3678         (shouldLogHistoryDelegates):
3679         (runTest):
3680
3681         Dump history delegate callbacks:
3682         * DumpRenderTree/mac/HistoryDelegate.h: Added.
3683         * DumpRenderTree/mac/HistoryDelegate.mm: Added.
3684         (-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
3685         (-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
3686         (-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):
3687
3688 2009-09-29  Daniel Bates  <dbates@webkit.org>
3689
3690         Reviewed by Adam Roben.
3691
3692         https://bugs.webkit.org/show_bug.cgi?id=28902
3693
3694         Fixes an issue where the drop effect returned by Window Dump Render Tree
3695         was always DROPEFFECT_NONE (since it was hard coded to do so).
3696
3697         This patch corrects this issue by determining the actual drop effect
3698         performed by the corresponding drag-and-drop operation so that we can
3699         return it.
3700
3701         * DumpRenderTree/win/DraggingInfo.h: Added field m_dropEffect to store performed drop effect.
3702         (DraggingInfo::DraggingInfo):
3703         (DraggingInfo::performedDropEffect): Added method.
3704         (DraggingInfo::setPerformedDropEffect): Added method.
3705         * DumpRenderTree/win/EventSender.cpp:
3706         (doMouseUp): Calls method DraggingInfo::setPerformedDropEffect with performed drop effect.
3707         Moved delete draggingInfo to UIDelegate::doDragDrop.
3708         * DumpRenderTree/win/UIDelegate.cpp:
3709         (UIDelegate::doDragDrop): Sets performedDropEffect to DraggingInfo::performedDropEffect().
3710
3711 2009-09-29  Dan Bernstein  <mitz@apple.com>
3712
3713         Reviewed by Adam Roben.
3714
3715         Remove copying of unnecessary or nonexistent files from the ImageDiff
3716         post-build event.
3717
3718         * DumpRenderTree/win/ImageDiff.vcproj:
3719
3720 2009-09-29  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3721
3722         Reviewed by David Kilzer.
3723
3724         [Qt] Make build-webkit script work on Windows
3725         https://bugs.webkit.org/show_bug.cgi?id=29802
3726
3727         * Scripts/run-webkit-tests:
3728         * Scripts/webkitdirs.pm:
3729          - Removed unnecessary -p switch for mkdir on Windows.
3730          - Use canonical path, which uses slashes or backslashes depends on platform.
3731          - isWindows() only test for Windows and not for Cyqwin.
3732
3733 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3734
3735         Reviewed by Simon Hausmann.
3736
3737         Fix time measurement in build-webkit after refactoring done in r48853.
3738
3739         * Scripts/build-webkit:
3740
3741 2009-09-29  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3742
3743         Reviewed by Tor Arne Vestbø.
3744
3745         [Qt] Default font size reconciliation to 16px/13px to match other platform's de-facto standard.
3746         This fixes https://bugs.webkit.org/show_bug.cgi?id=19674.
3747
3748         * DumpRenderTree/qt/DumpRenderTree.cpp:
3749         (WebCore::WebPage::WebPage):
3750
3751 2009-09-29  Jakub Wieczorek  <faw217@gmail.com>
3752
3753         Reviewed by Simon Hausmann.
3754
3755         [Qt] Implement eventSender.contextClick().
3756         https://bugs.webkit.org/show_bug.cgi?id=29821
3757
3758         * DumpRenderTree/qt/jsobjects.cpp:
3759         (EventSender::contextClick):
3760         * DumpRenderTree/qt/jsobjects.h:
3761
3762 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3763
3764         Reviewed by Eric Seidel.
3765
3766         Add experimentalWebSocketsEnabled in WebPreferences.
3767         https://bugs.webkit.org/show_bug.cgi?id=28941
3768
3769         * DumpRenderTree/mac/DumpRenderTree.mm:
3770         (resetDefaultsToConsistentValues):
3771         * DumpRenderTree/win/DumpRenderTree.cpp:
3772         (resetDefaultsToConsistentValues):
3773
3774 2009-09-28  Yaar Schnitman  <yaar@chromium.org>
3775
3776         Reviewed by David Kilzer.
3777
3778         Integrated chromium port building into webkit tools update-webkit and
3779         build-webkit.
3780
3781         https://bugs.webkit.org/show_bug.cgi?id=29749
3782
3783         * Scripts/build-webkit: When --chromium is specified, will build
3784           the chromium port (currently only Mac is supported).
3785         * Scripts/update-webkit: When --chromium is specified, delegates to
3786           update-webkit-chromium.
3787         * Scripts/webkitdirs.pm: Added chromium specific defs.
3788         * Scripts/update-webkit-chromium: Uses gclient and gyp to fetch
3789           chromium port's dependencies and update its project files.
3790
3791 2009-09-28  Fumitoshi Ukai  <ukai@chromium.org>
3792
3793         Unreviewed.
3794
3795         Add myself to list of committers.
3796
3797         * Scripts/modules/committers.py:
3798
3799 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3800
3801         Reviewed by Darin Adler.
3802
3803         run-webkit-tests: Do not strip the metrics when there is no expected result for a test.
3804         https://bugs.webkit.org/show_bug.cgi?id=29771
3805
3806         * Scripts/run-webkit-tests:
3807
3808 2009-09-27  Jakub Wieczorek  <faw217@gmail.com>
3809
3810         Reviewed by Simon Hausmann.
3811
3812         [Qt] Implement layoutTestController.waitForPolicyDelegate.
3813         https://bugs.webkit.org/show_bug.cgi?id=25037
3814
3815         * DumpRenderTree/qt/DumpRenderTree.cpp:
3816         (WebCore::WebPage::acceptNavigationRequest):
3817         * DumpRenderTree/qt/DumpRenderTree.pro:
3818         * DumpRenderTree/qt/jsobjects.cpp:
3819         (LayoutTestController::reset):
3820         (LayoutTestController::notifyDone):
3821         (LayoutTestController::waitForPolicyDelegate):
3822         * DumpRenderTree/qt/jsobjects.h:
3823         (LayoutTestController::waitForPolicy):
3824
3825 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3826
3827         <http://webkit.org/b/29764> mark-bug-fixed: add -o|--open switch
3828
3829         Reviewed by Eric Seidel.
3830
3831         The -o|--open switch uses the open(1) command on Mac OS X to
3832         open the bug URL in the default web browser.  If there are
3833         similar mechanisms on other platforms, they may be added later.
3834
3835         * Scripts/mark-bug-fixed:
3836         (MarkBugFixed.__init__): Added -o|--open switch to list of parse
3837         options.
3838         (MarkBugFixed._determine_bug_id_and_svn_revision): Moved logging
3839         code into main() and extracted prompting code into
3840         _prompt_user_for_correctness().
3841         (MarkBugFixed._open_bug_in_web_browser): Added.
3842         (MarkBugFixed._prompt_user_for_correctness): Added.
3843         (MarkBugFixed.main): Added logging code from
3844         _determine_bug_id_and_svn_revision().  Added code to call
3845         _open_bug_in_web_browser() if the switch is set.  Added code to
3846         call _prompt_user_for_correctness() when needed.
3847         * Scripts/modules/bugzilla.py:
3848         (Bugzilla.short_bug_url_for_bug_id): Added.
3849
3850 2009-09-26  David Kilzer  <ddkilzer@apple.com>
3851
3852         svn-unapply and svn-apply don't work when used outside multiple svn working directories
3853
3854         <http://webkit.org/b/29744>
3855         <rdar://problem/7252905>
3856
3857         Reviewed by Eric Seidel.
3858
3859         Some users have a workflow where svn-create-patch, svn-apply and
3860         svn-unapply are used outside of multiple svn working
3861         directories.  Instead of aborting the scripts in these cases,
3862         print a warning and assume that Subversion is being used.
3863
3864         * Scripts/VCSUtils.pm:
3865         (determineVCSRoot): Call warn() instead of die() if both isGit()
3866         and isSVN() initially return false.  Set $VCSUtils::isSVN to 1
3867         to enforce the assumption about Subversion, then return
3868         determineSVNRoot().
3869         * Scripts/svn-apply: Switch to using isGit() and isSVN() from
3870         VCSUtils.pm.  They both already cache their values and checking
3871         here is redundant since determineVCSRoot() is called later.
3872
3873 2009-09-26  Zan Dobersek  <zandobersek@gmail.com>
3874
3875         Reviewed by Gustavo Noronha.
3876
3877         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3878         https://bugs.webkit.org/show_bug.cgi?id=29689
3879
3880         Load test fonts through FontConfig before each test.
3881         This ensures a more proper rendering of the tests.
3882
3883         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3884         (initializeFonts):
3885         (runTest):
3886         (main):
3887         * DumpRenderTree/gtk/fonts.conf: Copied from WebKitTools/DumpRenderTree/qt/fonts.conf.
3888         * GNUmakefile.am:
3889
3890 2009-09-25  David Kilzer  <ddkilzer@apple.com>
3891
3892         <http://webkit.org/b/29718> mark-bug-fixed: add -u|--update-only switch
3893
3894         Reviewed by Eric Seidel.
3895
3896         * Scripts/mark-bug-fixed:
3897         (MarkBugFixed.__init__): Added -u|--update-only switch to list
3898         of parse options.
3899         (MarkBugFixed.main): When -u|--update-only is specified, add a
3900         comment to the bug without marking it Resolved/Fixed.
3901
3902 2009-09-25  Darin Adler  <darin@apple.com>
3903
3904         Reviewed by Geoffrey Garen.
3905
3906         * Scripts/prepare-ChangeLog: Leave files from the script-tests directory
3907         out, just as we do for the resources directory.
3908
3909 2009-09-25  Adam Barth  <abarth@webkit.org>
3910
3911         Unreviewed.  Added Tony to committers.py because he's a
3912         committer now.
3913
3914         * Scripts/modules/committers.py:
3915
3916 2009-09-25  Eric Seidel  <eric@webkit.org>
3917
3918         Reviewed by Simon Fraser.
3919
3920         REGRESSION: media/video-pause-empty-events.html is occasionally timing out on bots
3921         https://bugs.webkit.org/show_bug.cgi?id=28624
3922
3923         Disable hardware compositing on Leopard for versions of QuickTime 7.6.4 and older.
3924
3925         * DumpRenderTree/mac/DumpRenderTree.mm:
3926         (resetDefaultsToConsistentValues):
3927
3928 2009-09-25  Eric Seidel  <eric@webkit.org>
3929
3930         Reviewed by Adam Barth.
3931
3932         commit-queue should auto-retry patches which fail to commit due to out of date files
3933         https://bugs.webkit.org/show_bug.cgi?id=28316
3934
3935         * Scripts/bugzilla-tool:
3936          - Handle new CheckoutNeedsUpdate exception.
3937         * Scripts/modules/logging_unittest.py:
3938          - Call the ScriptError constructor correctly (this test had regressed).
3939         * Scripts/modules/scm.py:
3940          - Added the ability to define custom error handlers for run_command
3941            and added a commit_error_handler which throws CheckoutNeedsUpdate
3942            instead of ScriptError.
3943          - Re-ordered ScriptError constructor arguments to make ScriptError("message text") usage possible.
3944         * Scripts/modules/scm_unittest.py:
3945          - Added tests of new error handlers.
3946
3947 2009-09-25  Eric Seidel  <eric@webkit.org>
3948
3949         Reviewed by Adam Barth.
3950
3951         commit-queue should give better feedback when failing a patch
3952         https://bugs.webkit.org/show_bug.cgi?id=29316
3953
3954         * Scripts/bugzilla-tool:
3955          - Update ScriptError uses to the new constructor format.
3956          - Move CommitQueue._run_command to WebKitLandingScripts.run_command_with_teed_output
3957            so that we can print to both stdout as well as an output buffer for error reporting.
3958          - Update run_and_throw_if_fail to use teed output so that it can report the "output" as part of ScriptError.
3959          - Use e.message_with_output() when failing a patch (this is the real fix here).
3960            I also removed use of "This patch will require manual commit." as that's not always true.
3961          - Add missing word "bug" from log message.
3962         * Scripts/modules/scm.py:
3963          - Make ScriptError save a bunch more data so that error messages can be nicer.
3964          - Update ScriptError callers.
3965
3966 2009-09-24  John Gregg  <johnnyg@google.com>
3967
3968         Reviewed by Eric Seidel.
3969
3970         Enable switch for notifications (experimental) in Page Settings
3971         https://bugs.webkit.org/show_bug.cgi?id=28930
3972
3973         Now that desktop notifications are controlled by run-time switch,
3974         set that switch to true for DumpRenderTree.
3975
3976         * DumpRenderTree/mac/DumpRenderTree.mm:
3977         (resetDefaultsToConsistentValues):
3978         * DumpRenderTree/win/DumpRenderTree.cpp:
3979         (resetDefaultsToConsistentValues):
3980         * DumpRenderTree/win/UIDelegate.cpp:
3981         (UIDelegate::QueryInterface):
3982
3983 2009-09-24  Kevin Ollivier  <kevino@theolliviers.com>
3984
3985         wx build fix. SnowLeopard fixes for Mac dependencies.
3986
3987         * wx/build/build_utils.py:
3988         * wx/build/settings.py:
3989         * wx/install-unix-extras:
3990
3991 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3992
3993         Reviewed by Oliver Hunt.
3994
3995         Add support for DRT to send mouse wheel events.
3996
3997         https://bugs.webkit.org/show_bug.cgi?id=29348
3998         [Gtk] Scrollwheel on horizontal scrollbars should slide horizontally
3999
4000         * DumpRenderTree/gtk/EventSender.cpp:
4001         (mouseWheelToCallback):
4002
4003 2009-09-17  Eric Seidel  <eric@webkit.org>
4004
4005         Reviewed by David Levin.
4006
4007         commit-queue needs web-based status reporting
4008         https://bugs.webkit.org/show_bug.cgi?id=29307
4009
4010         Add a first-pass web-based status for the commit-queue.
4011         The bot is currently reachable at:
4012         http://webkit-commit-queue.appspot.com/
4013
4014         * CommitQueueStatus/app.yaml: Added.
4015          - Application description file required by App Engine.
4016         * CommitQueueStatus/filters/__init__.py: Added.
4017          - Required by python to treat 'filters' as a module.
4018         * CommitQueueStatus/filters/webkit_extras.py: Added.
4019          - Support for turning 'bug 123' and 'patch 123' into links.
4020            This lets us use plain text strings in our logs yet display nice HTML (help prevent XSS attacks on the page).
4021         * CommitQueueStatus/index.html: Added.
4022         * CommitQueueStatus/index.yaml: Added.
4023          - Some auto-generated file from app engine.
4024         * CommitQueueStatus/queue_status.py: Added.
4025          - The core logic of this bot.  We could eventually split this file out into pieces.
4026         * CommitQueueStatus/stylesheets/main.css: Added.
4027          - Some basic lame-o CSS to make the page look less awful.
4028         * CommitQueueStatus/update_status.html: Added.
4029          - The form that the commit-queue (or a human) can use to update the status.
4030         * Scripts/bugzilla-tool:
4031          - Add some very basic update_status calls.
4032         * Scripts/modules/statusbot.py: Added.
4033          - Knows how to post to the CommitQueueStatus web application.
4034
4035 2009-09-24  David Kilzer  <ddkilzer@apple.com>
4036
4037         <http://webkit.org/b/29712> mark-bug-fixed: add -m|--comment switch
4038
4039         Reviewed by Adam Roben.
4040
4041         * Scripts/mark-bug-fixed:
4042         (MarkBugFixed.__init__): Added -m|--comment switch to list of
4043         parse options.
4044         (MarkBugFixed.main): When specified, prepend comment from
4045         -m|--comment command-line switch to the bug comment.
4046
4047 2009-09-24  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4048
4049         Reviewed by Jan Alonzo.
4050
4051         [GTK] DRT must display window instead of just realizing, to enable synthesizing events correctly
4052         https://bugs.webkit.org/show_bug.cgi?id=29693
4053
4054         Show the window, to be able to synthesize events correctly.
4055
4056         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4057         (runTest):
4058         (main):
4059
4060 2009-09-24  Oliver Hunt  <oliver@apple.com>
4061
4062         Reviewed by NOBODY(rollout)
4063
4064         Roll out r48712 as it is incorrect.
4065
4066         * DumpRenderTree/mac/ObjCController.m:
4067         (+[ObjCController isSelectorExcludedFromWebScript:]):
4068         (+[ObjCController webScriptNameForSelector:]):
4069
4070 2009-09-24  Benjamin Poulain  <benjamin.poulain@nokia.com>
4071
4072         Reviewed by Eric Seidel.
4073
4074         https://bugs.webkit.org/show_bug.cgi?id=29005
4075         The indices of RuntimeArray should be enumerated like for a regular array.
4076
4077         * DumpRenderTree/mac/ObjCController.m:
4078         (+[ObjCController isSelectorExcludedFromWebScript:]):
4079         (+[ObjCController webScriptNameForSelector:]):
4080         (-[ObjCController arrayOfString]):
4081
4082 2009-09-23  David Kilzer  <ddkilzer@apple.com>
4083
4084         <http://webkit.org/b/28910> Move bugzilla-tool mark-fixed to standalone mark-bug-fixed tool
4085
4086         Reviewed by Darin Adler.
4087
4088         Also fixed a bug where specifying a revision on the command-line
4089         as 'r12345' would fail.  See <http://webkit.org/b/29699>.
4090
4091         * Scripts/bugzilla-tool: Updated module import statements.
4092         (parse_bug_id): Removed.  Moved to bugzilla.py.
4093         (bug_comment_from_svn_revision): Removed.  Moved to comments.py.
4094         (bug_comment_from_commit_text): Removed.  Moved to comments.py.
4095         (MarkBugFixed): Removed.  Code moved to mark-bug-fixed.
4096         (BugzillaTool.__init__): Removed mark-fixed subcommand.
4097         * Scripts/mark-bug-fixed: Added.
4098         * Scripts/modules/bugzilla.py:
4099         (parse_bug_id): Added.  Moved from bugzilla-tool.
4100         * Scripts/modules/comments.py: Added.
4101         (bug_comment_from_svn_revision): Added.  Moved from bugzilla-tool.
4102         (bug_comment_from_commit_text): Added.  Moved from bugzilla-tool.
4103
4104 2009-09-23  Marshall Culpepper  <mculpepper@appcelerator.com>
4105
4106         Reviewed by Eric Seidel.
4107
4108          jpeg.lib is now libjpeg.lib in DRT Cairo dependencies. return
4109          "false" in non-implemented stub for setAlwaysAcceptCookies.
4110          https://bugs.webkit.org/show_bug.cgi?id=29661
4111
4112         * DumpRenderTree/win/DumpRenderTree.vcproj:
4113         * DumpRenderTree/win/DumpRenderTree.cpp:
4114
4115 2009-09-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4116
4117         Reviewed by Xan Lopez.
4118
4119         [GTK] need to dump number of pending unload handlers
4120         https://bugs.webkit.org/show_bug.cgi?id=29685
4121
4122         Implement dumping of the number of pending unload handlers.
4123
4124         The following tests will pass:
4125
4126           fast/loader/unload-form-about-blank.html
4127           fast/loader/unload-form-post-about-blank.html
4128           fast/loader/unload-form-post.html
4129           fast/loader/unload-form.html
4130           fast/loader/unload-hyperlink.html
4131           fast/loader/unload-javascript-url.html
4132           fast/loader/unload-reload.html
4133           fast/loader/unload-window-location.html
4134
4135         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4136         (getFrameNameSuitableForTestResult):
4137         (webViewLoadFinished):
4138
4139 2009-09-22  Shinichiro Hamaji  <hamaji@chromium.org>
4140
4141         Reviewed by Eric Seidel.
4142
4143         js tests should move into jstests subdirectory instead of resources/
4144         https://bugs.webkit.org/show_bug.cgi?id=25880
4145
4146         Remove support of resources directory.
4147
4148         * Scripts/make-script-test-wrappers:
4149
4150 2009-09-22  Eric Seidel  <eric@webkit.org>
4151
4152         No review, only fixing typo (missing space character).
4153
4154         Fix typo from https://bugs.webkit.org/show_bug.cgi?id=29220
4155
4156         * Scripts/run-webkit-tests:
4157
4158 2009-09-22  Eric Seidel  <eric@webkit.org>
4159
4160         Reviewed by Darin Adler.
4161
4162         run-webkit-tests needs a --repeat-each=N option (AAABBBCCC instead of ABCABCABC)
4163         https://bugs.webkit.org/show_bug.cgi?id=29220
4164
4165         * Scripts/run-webkit-tests:
4166
4167 2009-09-22  Eric Seidel  <eric@webkit.org>
4168
4169         Reviewed by David Kilzer.
4170
4171         svn-apply can't handle single-line binary file additions
4172         https://bugs.webkit.org/show_bug.cgi?id=29100
4173
4174         Fixed the regexp and added a unit test.
4175
4176         * Scripts/modules/scm_unittest.py:
4177         * Scripts/svn-apply:
4178
4179 2009-09-11  Eric Seidel  <eric@webkit.org>
4180
4181         Reviewed by David Kilzer.
4182
4183         post-diff and post-commits should be able to find bug urls in ChangeLogs.
4184         https://bugs.webkit.org/show_bug.cgi?id=29206
4185
4186         * Scripts/bugzilla-tool:
4187          - Share common options by adding a PostDiffAsPatchToBug.posting_options() method.
4188          - Rename --no-comment to --add-log-as-comment and reverse behavior.
4189            Comments tend to just be noise.  I'll eventually remove this argument if no one uses it.
4190          - Split out code into helper functions to try and make execute() more legible.
4191          - Make post-diff find the bug url in the ChangeLogs if not passed as an argument.
4192          - Fallback to bug urls in commit diffs, instead of just in commit messages,
4193            meaning post-commits will now find bug urls in ChangeLogs.
4194
4195 2009-09-21  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
4196
4197         Reviewed by Maciej Stachowiak.
4198
4199         --parse-only parameter wasn't passed to SunSpider/sunspider script.
4200         https://bugs.webkit.org/show_bug.cgi?id=29611
4201
4202         * Scripts/run-sunspider: Missing parameter passing added.
4203
4204 2009-09-20  David Kilzer  <ddkilzer@apple.com>
4205
4206         <http://webkit.org/b/29521> run-webkit-tests: use require instead eval to load DumpRenderTreeSupport module
4207
4208         Reviewed by Mark Rowe.
4209
4210         The require statement is like the use statement, except that it
4211         is run during script execution instead of during the 'BEGIN'
4212         phase.  This makes it possible to change @INC before the require
4213         statement is run.  See 'require' and 'use' in the perlfunc(1)
4214         manpage and 'BEGIN' in perlmod(1) manpage.
4215
4216         * Scripts/run-webkit-tests: Replace eval statement with require
4217         statement.
4218
4219 2009-09-18  Kevin Ollivier  <kevino@theolliviers.com>
4220
4221         wx build fixes. Fix the config name under git and allow users to specify
4222         their own waf install for experimenting with new versions.
4223
4224         * Scripts/webkitdirs.pm:
4225         * wx/build/settings.py:
4226
4227 2009-09-18  Alex Milowski  <alex@milowski.com>
4228
4229         Reviewed by Maciej Stachowiak.
4230
4231         Added checkWebCoreMathMLSupport and hasMathMLSupport to support
4232         checking for whether MathML tests should be run
4233
4234         * Scripts/run-webkit-tests:
4235         * Scripts/webkitdirs.pm:
4236
4237 2009-08-28  Darin Adler  <darin@apple.com>
4238
4239         Reviewed by Mark Rowe.
4240
4241         Break more of run-webkit-tests into separate functions
4242         https://bugs.webkit.org/show_bug.cgi?id=29497
4243
4244         Some small steps toward improving run-webkit-tests. My goal is to
4245         refactor much more of the script into functions. Later we can add
4246         parallel test running to the tool. But better structure may help
4247         even if someone decides to translate this into another scripting
4248         language instead.
4249
4250         * Scripts/run-webkit-tests: Break more pieces of the script into
4251         seprate functions. Added readSkippedFiles, findTestsToRun, and
4252         printResults functions. Removed custom code to skip results.html
4253         and instead just put it into the ignoredFiles hash. Fixed some
4254         indentation. Sorted function declarations, global variables,
4255         and options at the top of the file alphabetically so they're not
4256         in a semi-random order.
4257
4258 2009-09-17  Kevin Ollivier  <kevino@theolliviers.com>
4259
4260         wx build fix, add missing dependency.
4261
4262         * wx/browser/wscript:
4263
4264 2009-09-16  Mark Rowe  <mrowe@apple.com>
4265
4266         Split the SnowLeopard build across a few machines.
4267
4268         * BuildSlaveSupport/build.webkit.org-config/config.json:
4269
4270 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
4271
4272         wx build fix to support monolithic builds on Windows.
4273
4274         * wx/build/wxpresets.py:
4275
4276 2009-09-16  Kevin Ollivier  <kevino@theolliviers.com>
4277
4278         wx build fix, improve debug support and 2.9 support on MSW.
4279
4280         * wx/build/settings.py:
4281         * wx/build/wxpresets.py:
4282
4283 2009-09-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
4284
4285         Blind try at fixing new test failure on Windows.
4286
4287         * DumpRenderTree/win/FrameLoadDelegate.cpp:
4288         (FrameLoadDelegate::didReceiveTitle):
4289
4290 2009-09-15  Alex Milowski  <alex@milowski.com>
4291
4292         Reviewed by Tor Arne Vestbø.
4293
4294         Added mathml toggle
4295
4296         * Scripts/build-webkit:
4297
4298 2009-09-15  Kevin Ollivier  <kevino@theolliviers.com>
4299
4300         wx build fix. Allow waf build to support Python < 2.6.
4301
4302         * wx/build/waf_extensions.py:
4303
4304 2009-09-14  Chris Marrin  <cmarrin@apple.com>
4305
4306         Reviewed by Oliver Hunt.
4307
4308         Add LayoutTests infrastructure to enable and disable webgl tests.
4309         https://bugs.webkit.org/show_bug.cgi?id=29254
4310
4311         * Scripts/run-webkit-tests:
4312         * Scripts/webkitdirs.pm:
4313
4314 2009-09-14  Simon Fraser  <simon.fraser@apple.com>
4315
4316         Reviewed by Darin Adler.
4317
4318         Add --iterations option to run-webkit-tests to repeat the tests N times
4319         https://bugs.webkit.org/show_bug.cgi?id=29263
4320
4321         When run with --iterations N, run-webkit-tests will repeat the tests N times.
4322
4323         * Scripts/run-webkit-tests:
4324
4325 2009-09-14  Brady Eidson  <beidson@apple.com>
4326
4327         Not reviewed, maybe should've been:
4328
4329         Cleaning up more Windows-specific fallout from the fix for:
4330         <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
4331
4332         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
4333         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):  Correct printf() formatter,
4334           and call the correct method to get the Sender.
4335
4336 2009-09-14  Jon Honeycutt  <jhoneycutt@apple.com>
4337
4338         GTK build fix.
4339
4340         Unreviewed.
4341
4342         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
4343         (AccessibilityController::setLogScrollingStartEvents):
4344
4345 2009-09-11  Jon Honeycutt  <jhoneycutt@apple.com>
4346
4347         DRT/test part of
4348         <rdar://problem/7197644> WebKit should broadcast an MSAA event when
4349         jumping to a named anchor
4350
4351         https://bugs.webkit.org/show_bug.cgi?id=28899
4352
4353         Reviewed by Adam Roben.
4354
4355         * DumpRenderTree/AccessibilityController.cpp:
4356         (logScrollingStartEventsCallback):
4357         Turn on logging of scrolling start events.
4358         (AccessibilityController::getJSClass):
4359         Add a "logScrollingStartEvents" to the AccessibilityController's JS
4360         class definition.