2009-11-25 Eric Seidel <eric@webkit.org>
[WebKit-https.git] / WebKitTools / ChangeLog
1 2009-11-25  Eric Seidel  <eric@webkit.org>
2
3         Reviewed by Adam Barth.
4
5         Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.
6         https://bugs.webkit.org/show_bug.cgi?id=31870
7
8         * Scripts/modules/commands/queries_unittest.py: Use the new class.
9         * Scripts/modules/multicommandtool_unittest.py: Ditto.
10         * Scripts/modules/outputcapture.py: Added.
11
12 2009-11-24  Dmitry Titov  <dimich@chromium.org>
13
14         Reviewed by Eric Seidel.
15
16         Add ENABLE_SHARED_SCRIPT feature define and flag for build-webkit
17         https://bugs.webkit.org/show_bug.cgi?id=31444
18
19         * Scripts/build-webkit:
20
21 2009-11-24  Chris Marrin  <cmarrin@apple.com>
22
23         Reviewed by Simon Fraser.
24
25         Changes the way 3D_RENDERING and ACCELERATED_COMPOSITING related tests are excluded
26         https://bugs.webkit.org/show_bug.cgi?id=27314
27         
28         Now the script allows the directories with these tests to be included on all
29         platforms but Mac, where they behave the same as always. For all other platforms
30         the tests need to be excluded using the Skipped files, which is currently done
31         for all platforms (including win since we're not turned on yet)
32
33         * Scripts/webkitdirs.pm:
34
35 2009-11-24  Eric Seidel  <eric@webkit.org>
36
37         Reviewed by Adam Barth.
38
39         queries_unittest.py should test command output
40         https://bugs.webkit.org/show_bug.cgi?id=31845
41
42         * Scripts/modules/commands/queries_unittest.py:
43          - Capture stdout and stderr and compare with expected strings.
44
45 2009-11-24  Simon Fraser  <simon.fraser@apple.com>
46
47         No Review.
48
49         Fix spelling error ("depenedencies").
50
51         * Scripts/build-webkit:
52
53 2009-11-24  Mark Rowe  <mrowe@apple.com>
54
55         Land the configuration that includes the two debug GTK Linux builders.
56
57         * BuildSlaveSupport/build.webkit.org-config/config.json:
58
59 2009-11-24  David Kilzer  <ddkilzer@apple.com>
60
61         <http://webkit.org/b/31840> bisect-builds broke after r50080
62
63         Reviewed by Dan Bernstein.
64
65         * Scripts/bisect-builds:
66         (mountAndRunNightly): Switched back to using backticks to run
67         the hdiutil command since exec() will terminate the existing
68         script, which is not what we want.  Store the output of
69         File::Spec->devnull() in a variable for use in the hdiutil
70         detach commands.
71
72 2009-11-23  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
73
74         Reviewed by Kenneth Rohde Christiansen.
75
76         Include "config.h" to meet Coding Style Guidelines
77         https://bugs.webkit.org/show_bug.cgi?id=31792
78
79         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
80         * DumpRenderTree/qt/jsobjects.cpp:
81         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
82
83 2009-11-23  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
84
85         Reviewed by Oliver Hunt.
86
87         Implement new required function to pass test we used to pass. This
88         change is required since r51294.
89
90         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
91         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
92
93 2009-11-23  Jakub Wieczorek  <faw217@gmail.com>
94
95         Reviewed by Kenneth Rohde Christiansen.
96
97         [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs.
98         https://bugs.webkit.org/show_bug.cgi?id=31775
99
100         LayoutTestController::dumpBackForwardList() should work with local URLs
101         as well as with normal URLs (in http tests for instance).
102         Currently it does not output the latter properly.
103
104         Unskip a bunch of passing http/navigation tests.
105
106         * DumpRenderTree/qt/DumpRenderTree.cpp:
107         (WebCore::dumpHistoryItem):
108
109 2009-11-22  Chris Fleizach  <cfleizach@apple.com>
110
111         Reviewed by Oliver Hunt.
112
113         ARIA: support aria-flowto
114         https://bugs.webkit.org/show_bug.cgi?id=31762
115
116         * DumpRenderTree/AccessibilityUIElement.cpp:
117         (ariaFlowToElementAtIndexCallback):
118         (AccessibilityUIElement::getJSClass):
119         * DumpRenderTree/AccessibilityUIElement.h:
120         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
121         (AccessibilityUIElement::ariaFlowToElementAtIndex):
122         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
123         (AccessibilityUIElement::ariaFlowToElementAtIndex):
124         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
125         (AccessibilityUIElement::ariaFlowToElementAtIndex):
126
127 2009-11-22  Antonio Gomes  <tonikitoo@webkit.org>
128
129         Reviewed by Kenneth Christiansen.
130
131         [Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
132         https://bugs.webkit.org/show_bug.cgi?id=31638
133
134         Unfreeze WorkQueue after each test execution.
135
136         * DumpRenderTree/qt/DumpRenderTree.cpp:
137         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
138
139 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
140
141         Reviewed by Adam Barth.
142
143         [Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
144         for localhost and 127.0.0.1.
145         https://bugs.webkit.org/show_bug.cgi?id=31783
146
147         Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
148
149         * DumpRenderTree/qt/DumpRenderTree.cpp:
150         (WebCore::NetworkAccessManager::NetworkAccessManager):
151         (WebCore::NetworkAccessManager::sslErrorsEncountered):
152         (WebCore::WebPage::WebPage):
153         * DumpRenderTree/qt/DumpRenderTree.h:
154
155 2009-11-22  Chris Evans  <cevans@chromium.org>
156
157         Reviewed by Adam Barth.
158
159         Disable access to file:/// directory listings
160         https://bugs.webkit.org/show_bug.cgi?id=31329
161
162         Implemented setAllowUniversalAccessFromFileURLs to support testing of
163         file URL security.
164
165         * DumpRenderTree/LayoutTestController.cpp:
166         (setAllowUniversalAccessFromFileURLsCallback):
167         (LayoutTestController::staticFunctions):
168         * DumpRenderTree/LayoutTestController.h:
169         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
170         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
171         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
172         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
173         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
174         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
175         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
176         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
177
178 2009-11-22  Jakub Wieczorek  <faw217@gmail.com>
179
180         Reviewed by Kenneth Rohde Christiansen.
181
182         [Qt] Fix the timeout of fast/frames/frame-navigation.html
183         https://bugs.webkit.org/show_bug.cgi?id=31638
184
185         The test is timeouting, because it uses the WorkQueue to load a document in one
186         of the child frames and once the loading is finished, the DRT does not dump the
187         tree. This is because it waits for the QWebFrame::loadFinished() signal from
188         the main frame, while it should connect to QWebPage::loadFinished().
189
190         * DumpRenderTree/qt/DumpRenderTree.cpp:
191         (WebCore::DumpRenderTree::DumpRenderTree):
192
193 2009-11-21  Eric Seidel  <eric@webkit.org>
194
195         Reviewed by Adam Barth.
196
197         bugzilla-tool --help spews way too much text
198         https://bugs.webkit.org/show_bug.cgi?id=31771
199
200         * Scripts/bugzilla-tool:
201          - Remove self.cached_scm initialization hack.
202         * Scripts/modules/buildbot.py:
203          - Make default_host accessible to callers.
204         * Scripts/modules/commands/download.py:
205          - Phrase help for all commands consistently and remove spurious help text punctuation.
206         * Scripts/modules/commands/queries.py: Ditto.
207         * Scripts/modules/commands/queues.py: Ditto.
208         * Scripts/modules/commands/upload.py: Ditto.
209         * Scripts/modules/multicommandtool.py:
210          - Add HelpPrintingOptionParser.format_epilog to replace
211            NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
212            per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
213          - Make --help only show a list of commands like "svn help" and "git help" do --
214            previously --help was listing all commands and options.
215          - Sort list of commands alphabetically.
216
217 2009-11-21  Eric Seidel  <eric@webkit.org>
218
219         No review.  Fixing a typo from the previous patch for bug 31767.
220
221         AbstractQueue.run_bugzilla_tool throws an exception
222         https://bugs.webkit.org/show_bug.cgi?id=31769
223
224         * Scripts/modules/commands/queues.py:
225
226 2009-11-21  Eric Seidel  <eric@webkit.org>
227
228         Reviewed by Adam Barth.
229
230         commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
231         https://bugs.webkit.org/show_bug.cgi?id=31767
232
233         What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
234         Since we don't have a good way to test BugzillaTool pieces, I've
235         left out a test for now.
236
237         * Scripts/bugzilla-tool:
238          - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
239         * Scripts/modules/commands/queues.py:
240          - Use tool.path() instead of __file__.
241         * Scripts/modules/multicommandtool.py:
242          - Add a new path() method to MultiComandTool.
243         * Scripts/modules/multicommandtool_unittest.py:
244          - Provide a path() method.  Little point in testing this mock implementation.
245
246 2009-11-21  Adam Barth  <abarth@webkit.org>
247
248         Unreviewed "build" fix.  Turns out I was testing the wrong copy of
249         WebKitTools.
250
251         * Scripts/modules/commands/download.py:
252
253 2009-11-21  Adam Barth  <abarth@webkit.org>
254
255         Reviewed by Eric Seidel.
256
257         Convert check-style to use LandingSequence
258         https://bugs.webkit.org/show_bug.cgi?id=31763
259
260         Instead of manipulating the working copy by hand, we should use the
261         LandingSequence in CheckStyle.  This will make this code eaiser to
262         test.
263
264         * Scripts/modules/commands/download.py:
265
266 2009-11-20  Adam Barth  <abarth@webkit.org>
267
268         Reviewed by Eric Seidel.
269
270         Unit test query commands
271         https://bugs.webkit.org/show_bug.cgi?id=31755
272
273         These tests are pretty rough, but hopefully they'll grow.
274
275         * Scripts/modules/commands/queries_unittest.py: Added.
276         * Scripts/modules/mock_bugzillatool.py: Added.
277         * Scripts/run-webkit-unittests:
278
279 2009-11-20  Eric Seidel  <eric@webkit.org>
280
281         Reviewed by Adam Barth.
282
283         Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
284         https://bugs.webkit.org/show_bug.cgi?id=31758
285
286         * Scripts/modules/multicommandtool.py:
287          - Allow passing of explicit commands to MultiCommandTool.__init__
288         * Scripts/modules/multicommandtool_unittest.py:
289          - Use new Command.name naming system.
290          - Test Command auto-discovery.
291         * Scripts/modules/workqueue.py:
292          - bug_id no longer exists, use patch['bug_id'] instead.
293         * Scripts/modules/workqueue_unittest.py:
294          - WorkQueues require names now.
295          - should_proceed_with_work_item must return a patch object.
296
297 2009-11-20  Chris Fleizach  <cfleizach@apple.com>
298
299         Reviewed by Beth Dakin.
300
301         WAI-ARIA: add support for aria-owns
302         https://bugs.webkit.org/show_bug.cgi?id=31702
303
304         * DumpRenderTree/AccessibilityUIElement.cpp:
305         (ariaOwnsElementAtIndexCallback):
306         (AccessibilityUIElement::getJSClass):
307         * DumpRenderTree/AccessibilityUIElement.h:
308         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
309         (AccessibilityUIElement::ariaOwnsElementAtIndex):
310         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
311         (AccessibilityUIElement::ariaOwnsElementAtIndex):
312         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
313         (AccessibilityUIElement::ariaOwnsElementAtIndex):
314
315 2009-11-20  Eric Seidel  <eric@webkit.org>
316
317         Reviewed by Adam Barth.
318
319         Fix exception thrown when running the commit-queue.
320
321         * Scripts/modules/statusbot.py: patch is optional.
322         * Scripts/modules/workqueue.py: WorkQUeue requires a name.
323
324 2009-11-20  Eric Seidel  <eric@webkit.org>
325
326         Reviewed by Adam Barth.
327
328         Teach the StatusBot how to support more than just the commit-queue
329         https://bugs.webkit.org/show_bug.cgi?id=31754
330
331         * Scripts/modules/workqueue.py: Another typo.
332
333 2009-11-20  Eric Seidel  <eric@webkit.org>
334
335         Reviewed by Adam Barth.
336
337         Teach the StatusBot how to support more than just the commit-queue
338         https://bugs.webkit.org/show_bug.cgi?id=31754
339
340         * Scripts/modules/commands/queues.py: Fix silly typo.
341
342 2009-11-20  Eric Seidel  <eric@webkit.org>
343
344         Reviewed by Adam Barth.
345
346         Teach the StatusBot how to support more than just the commit-queue
347         https://bugs.webkit.org/show_bug.cgi?id=31754
348
349         * CommitQueueStatus/index.yaml:
350          - Add indices required for the new queries.
351         * CommitQueueStatus/queue_status.py:
352          - Add a patch-status page and move update_status to update-status.
353          - Only display "commit-queue" status records for the commit-queue.
354          - Add support for a queue_name property on status records.
355          - Fix _int_from_request to actually work.
356         * CommitQueueStatus/update_status.html:
357          - Add support for a queue_name on status records.
358          - Remove unused list of bug ids.
359          * Scripts/modules/commands/queues.py
360           - Make the queues pass the patch instead of the bug_id to StatusBot.
361         * Scripts/modules/statusbot.py:
362          - Support passing the queue_name to the status updates.
363          - Support fetching patch status with patch_status().
364         * Scripts/modules/workqueue.py:
365          - Pass the patch to the StatusBot instead of the bug_id.
366          - Let WorkQueues have a name.
367
368 2009-11-20  Adam Barth  <abarth@webkit.org>
369
370         Reviewed by Eric Seidel.
371
372         Move bugzilla-tool commands into their own file
373         https://bugs.webkit.org/show_bug.cgi?id=31752
374
375         This will let us write unit tests.
376
377         * Scripts/bugzilla-tool:
378         * Scripts/modules/commands/__init__.py: Added.
379         * Scripts/modules/commands/download.py: Added.
380         * Scripts/modules/commands/queries.py: Added.
381         * Scripts/modules/commands/queues.py: Added.
382         * Scripts/modules/commands/upload.py: Added.
383         * Scripts/modules/grammar.py: Added.
384
385 2009-11-20  Adam Barth  <abarth@webkit.org>
386
387         Reviewed by Eric Seidel.
388
389         BuildQueue should check if the tree is currently buildable
390         https://bugs.webkit.org/show_bug.cgi?id=31744
391
392         * Scripts/bugzilla-tool:
393         * Scripts/modules/landingsequence.py:
394         * Scripts/modules/webkitlandingscripts.py:
395
396 2009-11-20  Adam Barth  <abarth@webkit.org>
397
398         Reviewed by Eric Seidel.
399
400         Move prepare_clean_working_directory into the LandingSequence
401         https://bugs.webkit.org/show_bug.cgi?id=31743
402
403         * Scripts/bugzilla-tool:
404         * Scripts/modules/landingsequence.py:
405
406 2009-11-20  Yael Aharon  <yael.aharon@nokia.com>
407
408         Reviewed by Kenneth Rohde Christiansen.
409
410         NPN_ReloadPlugins does not reload the page even if reloadPages is true.
411         https://bugs.webkit.org/show_bug.cgi?id=30460
412
413         Added code for calling NPN_ReloadPlugins with reloadPages true and false.
414
415         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
416         (pluginInvoke):
417
418 2009-11-20  Adam Barth  <abarth@webkit.org>
419
420         Reviewed by Eric Seidel.
421
422         Pass the port information to the child process
423         https://bugs.webkit.org/show_bug.cgi?id=31736
424
425         We need to do this so the child process knows what to build!
426
427         * Scripts/bugzilla-tool:
428         * Scripts/modules/landingsequence.py:
429         * Scripts/modules/webkitport.py:
430         * Scripts/modules/webkitport_unittest.py:
431
432 2009-11-20  Adam Barth  <abarth@webkit.org>
433
434         Reviewed by Eric Seidel.
435
436         Support Qt port in build-queue
437         https://bugs.webkit.org/show_bug.cgi?id=31733
438
439         * Scripts/bugzilla-tool:
440
441 2009-11-20  Adam Barth  <abarth@webkit.org>
442
443         Reviewed by Eric Seidel.
444
445         Implement a build-queue
446         https://bugs.webkit.org/show_bug.cgi?id=31725
447
448         Currently this just builds the first 10 patches in the review queue.
449         We'll want to do something smarter soon.
450
451         * Scripts/bugzilla-tool:
452
453 2009-11-20  Adam Barth  <abarth@webkit.org>
454
455         Reviewed by Eric Seidel.
456
457         Make commit-queue and style-queue show up in help
458         https://bugs.webkit.org/show_bug.cgi?id=31724
459
460         We need to store their names on their class to make these commands
461         properly register themselves with MultiCommandTool.
462
463         * Scripts/bugzilla-tool:
464
465 2009-11-20  Adam Barth  <abarth@webkit.org>
466
467         Reviewed by Eric Seidel.
468
469         Implement bugzilla-tool build-attachment
470         https://bugs.webkit.org/show_bug.cgi?id=31722
471
472         This command builds an attachment from bugzilla.  It leaves the built
473         patch in the working copy.
474
475         * Scripts/bugzilla-tool:
476         * Scripts/modules/landingsequence.py:
477         * Scripts/modules/webkitlandingscripts.py:
478
479 2009-11-20  Alejandro G. Castro  <alex@igalia.com>
480
481         Reviewed by Xan Lopez.
482
483         [GTK] DRT release event does not create the state correctly
484         https://bugs.webkit.org/show_bug.cgi?id=31717
485
486         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
487
488 2009-11-20  Eric Seidel  <eric@webkit.org>
489
490         Reviewed by Adam Barth.
491
492         MultiCommandTool should find Command objects automatically instead of with a manual list
493         https://bugs.webkit.org/show_bug.cgi?id=31710
494
495         * Scripts/bugzilla-tool:
496         * Scripts/modules/multicommandtool.py:
497          - Use some wild python-fu to crawl all the known subclasses of Command.
498
499 2009-11-20  Adam Barth  <abarth@webkit.org>
500
501         Unreviewed "build" fix.  Added missing import.
502
503         * Scripts/bugzilla-tool:
504
505 2009-11-20  Adam Barth  <abarth@webkit.org>
506
507         Unreviewed "build" fix.  I failed to update LandingSequence.test
508         properly.
509
510         * Scripts/modules/landingsequence.py:
511
512 2009-11-20  Adam Barth  <abarth@webkit.org>
513
514         Reviewed by Eric Seidel.
515
516         Create LandingSequence as the all-sing, all-dance landing class
517         https://bugs.webkit.org/show_bug.cgi?id=31709
518
519         Client can inherit from this class to carefully control exactly which
520         steps they wish to have happen in the landing sequence.
521
522         * Scripts/bugzilla-tool:
523         * Scripts/modules/landingsequence.py: Added.
524         * Scripts/modules/webkitlandingscripts.py: Added.
525
526 2009-11-19  Adam Barth  <abarth@webkit.org>
527
528         Reviewed by Eric Seidel.
529
530         Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
531         https://bugs.webkit.org/show_bug.cgi?id=31707
532
533         This is to help when we implement build-attachment.
534
535         * Scripts/bugzilla-tool:
536
537 2009-11-19  Adam Barth  <abarth@webkit.org>
538
539         Reviewed by Eric Seidel.
540
541         Support Qt port in bugzilla-tool
542         https://bugs.webkit.org/show_bug.cgi?id=31701
543
544         Now we support building with Qt!
545
546         * Scripts/bugzilla-tool:
547         * Scripts/modules/webkitport.py: Added.
548         * Scripts/modules/webkitport_unittest.py: Added.
549         * Scripts/run-webkit-unittests:
550
551 2009-11-19  Zoltan Horvath  <zoltan@webkit.org>
552
553         Reviewed by Adam Barth.
554
555         Remove inserting stderr into patch in bugzilla-tool
556         https://bugs.webkit.org/show_bug.cgi?id=29914
557
558         Modify SCM python module's run_command function to avoid return of stderr
559         by default, so stderr won't be inserted into the patches.
560         Modify the related unit test.
561
562         * Scripts/modules/scm.py:
563         * Scripts/modules/scm_unittest.py:
564
565 2009-11-19  Eric Seidel  <eric@webkit.org>
566
567         Reviewed by Adam Barth.
568
569         bugzilla-tool needs per-command help
570         https://bugs.webkit.org/show_bug.cgi?id=31697
571
572         Added support for "bugzilla-tool help command-name"
573         and a unit test to make sure it works.
574
575         * Scripts/modules/multicommandtool.py:
576         * Scripts/modules/multicommandtool_unittest.py:
577
578 2009-11-19  Eric Seidel  <eric@webkit.org>
579
580         Reviewed by Adam Barth.
581
582         Move MultiCommandTool and Command into a separate file and add some basic unit tests
583         https://bugs.webkit.org/show_bug.cgi?id=31695
584
585         * Scripts/bugzilla-tool:
586         * Scripts/modules/multicommandtool.py: Added.
587         * Scripts/modules/multicommandtool_unittest.py: Added.
588         * Scripts/run-webkit-unittests:
589
590 2009-11-19  Eric Seidel  <eric@webkit.org>
591
592         No review, just adding a FIXME.
593
594         Split out command parsing and help printing from BugzillaTool
595         https://bugs.webkit.org/show_bug.cgi?id=31688
596
597         * Scripts/bugzilla-tool: Add an extra comment about current design failures.
598
599 2009-11-19  Eric Seidel  <eric@webkit.org>
600
601         Reviewed by Adam Barth.
602
603         Split out command parsing and help printing from BugzillaTool
604         https://bugs.webkit.org/show_bug.cgi?id=31688
605
606         * Scripts/bugzilla-tool:
607          - Add new MultiCommandTool class to contain option parsing and help printing logic.
608          - Rename private methods to use _ pattern.
609          - MultiCommandTool has two abstract methods should_show_command_help and should_execute_command.
610          - 
611
612 2009-11-19  Eric Seidel  <eric@webkit.org>
613
614         Reviewed by Adam Barth.
615
616         Re-factor help printing to use modern python idioms
617         https://bugs.webkit.org/show_bug.cgi?id=31685
618
619         * Scripts/bugzilla-tool:
620
621 2009-11-19  Eric Seidel  <eric@webkit.org>
622
623         Reviewed by Darin Adler.
624
625         commit-queue empty queue logs twice
626         https://bugs.webkit.org/show_bug.cgi?id=31679
627
628         * Scripts/bugzilla-tool:
629
630 2009-11-19  Eric Seidel  <eric@webkit.org>
631
632         Reviewed by Darin Adler.
633
634         bugzilla-tool's reviewer/committer rejection message should be clearer
635         https://bugs.webkit.org/show_bug.cgi?id=31126
636
637         Add more explanatory prose to bugzilla-tool's flag permission rejection message.
638
639         * Scripts/modules/bugzilla.py:
640
641 2009-11-19  Eric Z. Ayers  <zundel@google.com>
642
643         Reviewed by Pavel Feldman.
644
645         Forces a WM_PAINT event on calling layoutTestController.display()
646         in order to enable the timeline-paint.html test on Windows.
647         ::UpdateWindow() does not force an event becaue the window is 
648         not visible.
649
650         https://bugs.webkit.org/show_bug.cgi?id=31402
651
652         * DumpRenderTree/win/DumpRenderTree.cpp:
653         (displayWebView):
654
655 2009-11-19  Michelangelo De Simone  <michelangelo@webkit.org>
656
657         No review needed.
658
659         Added myself to committers list.
660
661         * Scripts/modules/committers.py:
662
663 2009-11-19  Adam Barth  <abarth@webkit.org>
664
665         Reviewed by Eric Seidel.
666
667         Bugzilla-tool command classes should match command names
668         https://bugs.webkit.org/show_bug.cgi?id=31666
669
670         I renamed all the commands except CommitMessageForCurrentDiff because
671         the new name would conflict with an existing class.
672
673         * Scripts/bugzilla-tool:
674
675 2009-11-19  Pavel Feldman  <pfeldman@chromium.org>
676
677         Reviewed by Gustavo Noronha Silva.
678
679         Web Inspector: Implement "show inspector" in WebKit GTK
680         API and enable console tests.
681
682         https://bugs.webkit.org/show_bug.cgi?id=31669
683
684         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
685         (LayoutTestController::showWebInspector):
686
687 2009-11-19  Kenneth Rohde Christiansen  <kenneth@webkit.org>
688
689         Reviewed by Simon Hausmann.
690
691         Minor refactoring + more documentation.
692
693         * DumpRenderTree/qt/DumpRenderTree.cpp:
694         (WebCore::clearHistory):
695         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
696
697 2009-11-19  Fumitoshi Ukai  <ukai@chromium.org>
698
699         Reviewed by Eric Seidel.
700
701         Ignore websocket tests when --no-http is specified.
702         https://bugs.webkit.org/show_bug.cgi?id=31662
703
704         * Scripts/run-webkit-tests:
705
706 2009-11-18  Adam Barth  <abarth@webkit.org>
707
708         Reviewed by Eric Seidel.
709
710         Normalize ' and " in bugzilla-tool
711         https://bugs.webkit.org/show_bug.cgi?id=31655
712
713         We decided " is better than ' and we should be consistent.
714
715         * Scripts/bugzilla-tool:
716
717 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
718
719         Reviewed by Kenneth Rohde Christiansen.
720
721         [Qt] Remove support for Qt v4.3 or older versions
722         https://bugs.webkit.org/show_bug.cgi?id=29469
723
724         * DumpRenderTree/qt/DumpRenderTree.pro:
725         * DumpRenderTree/qt/ImageDiff.pro:
726
727 2009-11-18  Shinichiro Hamaji  <hamaji@chromium.org>
728
729         Reviewed by Eric Seidel.
730
731         GitTest.test_create_binary_patch fails if /tmp is symlink
732         https://bugs.webkit.org/show_bug.cgi?id=31536
733
734         * Scripts/modules/scm_unittest.py:
735
736 2009-11-18  Yaar Schnitman  <yaar@chromium.org>
737
738         Reviewed by Darin Adler.
739
740         Configuration for Chromium Build Slaves.
741
742         https://bugs.webkit.org/show_bug.cgi?id=31442
743
744         * BuildSlaveSupport/build.webkit.org-config/config.json:
745         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
746
747 2009-11-18  Eric Seidel  <eric@webkit.org>
748
749         Reviewed by Darin Adler.
750
751         workqueue.py results in totally broken commit-queue UI
752         https://bugs.webkit.org/show_bug.cgi?id=31645
753
754         * Scripts/bugzilla-tool:
755          - Remove unneeded use of PatchCollection.
756          - Grab a new copy of the cq'd patches every run of the queue.
757
758 2009-11-18  Sam Weinig  <sam@webkit.org>
759
760         Reviewed by Anders Carlsson.
761
762         Make the Mac Geolocation API async.
763
764         Update DRT to use the new async Mac Geolocation API.
765
766         * DumpRenderTree/mac/UIDelegate.mm:
767         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
768
769 2009-11-18  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
770
771         Reviewed by Kenneth Rohde Christiansen.
772
773         Add and option to toggle HTML5 datalist support to build-webkit
774         https://bugs.webkit.org/show_bug.cgi?id=31599
775
776         * Scripts/build-webkit:
777
778 2009-11-18  Kevin Watters  <kevinwatters@gmail.com>
779
780         Reviewed by Kevin Ollivier.
781
782         Enable wx plugin support using the Windows implementation as a base.
783         
784         https://bugs.webkit.org/show_bug.cgi?id=31636
785
786         * wx/build/settings.py:
787
788 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
789
790         Reviewed by Simon Hausmann.
791
792         Change the initialization order so that the controllers
793         will be created before exporting them to the JS DOM window.
794
795         * DumpRenderTree/qt/DumpRenderTree.cpp:
796         (WebCore::DumpRenderTree::DumpRenderTree):
797
798 2009-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
799
800         Reviewed by Simon Hausmann.
801
802         Fix a code copy and paste error. m_page should be page.
803
804         * DumpRenderTree/qt/DumpRenderTree.cpp:
805         (WebCore::DumpRenderTree::createWindow):
806
807 2009-11-17  Mark Rowe  <mrowe@apple.com>
808
809         Reviewed by Alexey Proskuryakov.
810
811         <http://webkit.org/b/31603> WebSocket server is confused if WebKit tests run from within /tmp on Mac OS X
812
813         * pywebsocket/mod_pywebsocket/dispatch.py: Use os.path.realpath as it returns the canonical path of a file.
814         This prevents symlinks from confusing the descendant check.
815
816 2009-11-17  Mark Rowe  <mrowe@apple.com>
817
818         Reviewed by Alexey Proskuryakov.
819
820         <http://webkit.org/b/31602> Failing to start the WebSocket server shouldn’t terminate entire test run
821
822         If the WebSocket server fails to start have DRT load an error page in place of tests that require the
823         server to be up rather than having run-webkit-tests abort immediately.
824
825         * Scripts/run-webkit-tests:
826
827 2009-11-17  Eric Seidel  <eric@webkit.org>
828
829         Reviewed by Darin Adler.
830
831         commit-queue is failing to set reviewer in ChangeLogs
832         https://bugs.webkit.org/show_bug.cgi?id=31592
833
834         * Scripts/bugzilla-tool: Clarify the "applying" log message.
835         * Scripts/modules/bugzilla.py:
836          - Add a new _validate_committer_and_reviewer function as a
837            temporary solution until we can make a real Attachment object
838            which knows how to fill in its committer/reviewer fields automatically.
839
840 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
841
842         Unreviewed buildbot fix.
843
844         Revert part of earlier patch and add comment, as it
845         was causing timeouts on the buildbot.
846
847         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
848         (LayoutTestController::notifyDone):
849
850 2009-11-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
851
852         Reviewed by Oliver Hunt.
853
854         Make the timeout 15 sec as for the other DRT's and make
855         it print out the same output when a test timeout.
856
857         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
858         (LayoutTestController::waitUntilDone):
859         (LayoutTestController::notifyDone):
860         (LayoutTestController::timerEvent):
861
862 2009-11-17  Joseph Pecoraro  <joepeck@webkit.org>
863
864         Reviewed by Timothy Hatcher.
865
866         Fixed typos in comments.
867
868         * Scripts/modules/committers.py:
869
870 2009-11-17  Pavel Feldman  <pfeldman@chromium.org>
871
872         Reviewed by Timothy Hatcher.
873
874         Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
875         - Updated DRT to show/close inspector for all tests under /inspector
876         - Introduced LayoutTestController::setTimelineProfilingEnabled and
877           WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
878         - Removed reload on each inspector test
879         - Renamed fast/inspector to fast/inspector-support in order not to trigger
880         inspector for those.
881         - Reimplemented timeline tests in order to get rid of reload there.
882         - Moved tests that don't require harness into the fast group.
883
884         https://bugs.webkit.org/show_bug.cgi?id=31472
885
886         * DumpRenderTree/LayoutTestController.cpp:
887         (setTimelineProfilingEnabledCallback):
888         (closeWebInspectorCallback):
889         (LayoutTestController::staticFunctions):
890         * DumpRenderTree/LayoutTestController.h:
891         * DumpRenderTree/gtk/DumpRenderTree.cpp:
892         (shouldOpenWebInspector):
893         (runTest):
894         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
895         (LayoutTestController::setTimelineProfilingEnabled):
896         * DumpRenderTree/mac/DumpRenderTree.mm:
897         (shouldOpenWebInspector):
898         (runTest):
899         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
900         (LayoutTestController::setTimelineProfilingEnabled):
901         * DumpRenderTree/win/DumpRenderTree.cpp:
902         (shouldOpenWebInspector):
903         (runTest):
904         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
905         (LayoutTestController::setTimelineProfilingEnabled):
906
907 2009-11-17  Oliver Hunt  <oliver@apple.com>
908
909         Reviewed by Maciej Stachowiak.
910
911         Incorrect use of JavaScriptCore API in DumpRenderTree
912         https://bugs.webkit.org/show_bug.cgi?id=31577
913
914         Return undefined rather than a literal null.
915
916         * DumpRenderTree/AccessibilityUIElement.cpp:
917         (setSelectedTextRangeCallback):
918         (incrementCallback):
919         (decrementCallback):
920         (showMenuCallback):
921
922 2009-11-16  Chris Fleizach  <cfleizach@apple.com>
923
924         Reviewed by Beth Dakin.
925
926         AX: aria-labelledby duplicates some of its WAI-ARIA label
927         https://bugs.webkit.org/show_bug.cgi?id=31565
928
929         * DumpRenderTree/AccessibilityUIElement.cpp:
930         (titleUIElementCallback):
931         (getIsValidCallback):
932         (AccessibilityUIElement::getJSClass):
933
934 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
935
936         Reviewed by Simon Hausmann.
937
938         r50942 broke output from created windows. Make the
939         m_enableTextOutput a member of the DRT and not the
940         WebPage.
941
942         * DumpRenderTree/qt/DumpRenderTree.cpp:
943         (WebCore::WebPage::WebPage):
944         (WebCore::WebPage::javaScriptAlert):
945         (WebCore::WebPage::javaScriptConsoleMessage):
946         (WebCore::WebPage::javaScriptConfirm):
947         (WebCore::WebPage::javaScriptPrompt):
948         (WebCore::WebPage::acceptNavigationRequest):
949         (WebCore::DumpRenderTree::DumpRenderTree):
950         (WebCore::DumpRenderTree::open):
951         (WebCore::DumpRenderTree::createWindow):
952         * DumpRenderTree/qt/DumpRenderTree.h:
953         (WebCore::DumpRenderTree::setTextOutputEnabled):
954         (WebCore::DumpRenderTree::isTextOutputEnabled):
955         (WebCore::WebPage::shouldInterruptJavaScript):
956         (WebCore::WebPage::isTextOutputEnabled):
957         (WebCore::WebPage::setViewGeometry):
958
959 2009-11-16  Kenneth Rohde Christiansen  <kenneth@webkit.org>
960
961         Reviewed by Gustavo Noronha Silva.
962
963         Moved DumpRenderTree/gtk/TestNetscapePlugin to DumpRenderTree/unix/TestNetscapePlugin
964         as the implementation is being used by at least Qt and Gtk+.
965
966         Update buildsystems as well.
967
968         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
969         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
970         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h:
971         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
972         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
973         * GNUmakefile.am:
974
975 2009-11-16  Yuzo Fujishima  <yuzo@google.com>
976
977         Reviewed by Alexey Proskuryakov.
978
979         Disable wss until all platforms support pyOpenSSL
980
981         https://bugs.webkit.org/show_bug.cgi?id=31479
982
983         * Scripts/run-webkit-tests:
984
985 2009-11-14  Antonio Gomes  <tonikitoo@webkit.org>
986
987         Reviewed by Kenneth Christiansen.
988
989         [Qt] Implement load error pages support for Qt's DRT.
990         https://bugs.webkit.org/show_bug.cgi?id=31509
991
992         For now, it will not be a default feature, and layout tests
993         that want to make use of this have to explicitily call
994         'handleErrorPages();' for the test source.
995
996         Any of the other DumpRenderTree's (mac, win and gtk)
997         support handling error pages. Qt's will be the first.
998
999         * DumpRenderTree/qt/DumpRenderTree.cpp:
1000         (WebCore::WebPage::supportsExtension):
1001         (WebCore::WebPage::extension):
1002         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1003         (LayoutTestController::reset):
1004         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1005         (LayoutTestController::shouldHandleErrorPages):
1006         (LayoutTestController::handleErrorPages):
1007
1008 2009-11-16  Eric Seidel  <eric@webkit.org>
1009
1010         Reviewed by Adam Barth.
1011
1012         Rename the --commit-queue flag on land-* now that the commit-queue needs no special treatment
1013         https://bugs.webkit.org/show_bug.cgi?id=31549
1014
1015         Renamed --commit-queue to --non-interactive in most places
1016         and remove the code in land-patches which is no longer needed.
1017
1018         * Scripts/bugzilla-tool:
1019
1020 2009-11-16  Eric Seidel  <eric@webkit.org>
1021
1022         Reviewed by Adam Barth.
1023
1024         The commit-queue should use land-attachment
1025         https://bugs.webkit.org/show_bug.cgi?id=31548
1026
1027         * Scripts/bugzilla-tool:
1028
1029 2009-11-16  Adam Barth  <abarth@webkit.org>
1030
1031         Reviewed by Eric Seidel.
1032
1033         Convert CommitQueue over to PatchCollection
1034         https://bugs.webkit.org/show_bug.cgi?id=31547
1035
1036         Also fixes a bug in workqueue and adds a test!
1037
1038         * Scripts/bugzilla-tool:
1039         * Scripts/modules/workqueue.py:
1040         * Scripts/modules/workqueue_unittest.py:
1041
1042 2009-11-16  Adam Barth  <abarth@webkit.org>
1043
1044         Reviewed by Eric Seidel.
1045
1046         Move StyleQueue over to using PatchCollection
1047         https://bugs.webkit.org/show_bug.cgi?id=31544
1048
1049         That's what the class it's for.
1050
1051         * Scripts/bugzilla-tool:
1052         * Scripts/modules/patchcollection.py:
1053         * Scripts/modules/patchcollection_unittest.py:
1054
1055 2009-11-16  Eric Seidel  <eric@webkit.org>
1056
1057         Reviewed by Adam Barth.
1058
1059         bugzilla-tool needs a land-attachment command
1060         https://bugs.webkit.org/show_bug.cgi?id=31546
1061
1062         * Scripts/bugzilla-tool:
1063          - Move all the logic into AbstractLandingCommand and
1064            add a new LandAttachment command subclass.
1065          - Split out _collect_patches_by_bug logging from _fetch_list_of_patches_to_land.
1066
1067 2009-11-16  Eric Seidel  <eric@webkit.org>
1068
1069         Reviewed by Adam Barth.
1070
1071         Move more patch-landing code into WebKitLandingScripts in preparation for land-attachment
1072         https://bugs.webkit.org/show_bug.cgi?id=31543
1073
1074         Just moving code and updating the one caller to use WebKitLandingScripts instead of 'self'.
1075
1076         * Scripts/bugzilla-tool:
1077
1078 2009-11-16  Eric Seidel  <eric@webkit.org>
1079
1080         Reviewed by Adam Barth.
1081
1082         Disable the style queue from posting to the commit queue status page.
1083
1084         * Scripts/bugzilla-tool:
1085
1086 2009-11-16  Adam Barth  <abarth@webkit.org>
1087
1088         Reviewed by Eric Seidel.
1089
1090         Implement PatchCollection
1091         https://bugs.webkit.org/show_bug.cgi?id=31541
1092
1093         This class holds a set of patches and lets clients iterate through
1094         them.  Optionally, clients can install a filter.
1095
1096         * Scripts/modules/patchcollection.py: Added.
1097         * Scripts/modules/patchcollection_unittest.py: Added.
1098         * Scripts/run-webkit-unittests:
1099
1100 2009-11-16  Eric Seidel  <eric@webkit.org>
1101
1102         Reviewed by Adam Barth.
1103
1104         bugzilla-tool land-patches will close bugs with patches r=?
1105         https://bugs.webkit.org/show_bug.cgi?id=28230
1106
1107         The commit-queue shouldn't close patches with outstanding reviews on them,
1108         even if many reviewers seem to be against multi-patch bugs.
1109
1110         * Scripts/bugzilla-tool:
1111
1112 2009-11-16  Eric Seidel  <eric@webkit.org>
1113
1114         Reviewed by Adam Barth.
1115
1116         bugzilla-tool check-style should work with attachment ids instead of bug ids
1117         https://bugs.webkit.org/show_bug.cgi?id=31540
1118
1119         * Scripts/bugzilla-tool:
1120
1121 2009-11-16  Eric Seidel  <eric@webkit.org>
1122
1123         Reviewed by Adam Barth.
1124
1125         WorkQueue is the only place that should know about special exit codes
1126         https://bugs.webkit.org/show_bug.cgi?id=31534
1127
1128         Move LandPatchesFromBugs.handled_error to WorkQueue.exit_after_handled_error
1129         and add tests for handling exit codes.
1130         I also cleaned up workqueue_unittest.py more.
1131
1132         * Scripts/bugzilla-tool:
1133         * Scripts/modules/workqueue.py:
1134         * Scripts/modules/workqueue_unittest.py:
1135
1136 2009-11-16  Eric Seidel  <eric@webkit.org>
1137
1138         Reviewed by Adam Barth.
1139
1140         Re-factor workqueue_unittest to allow for more than one test.
1141         https://bugs.webkit.org/show_bug.cgi?id=31535
1142
1143         * Scripts/modules/workqueue_unittest.py:
1144
1145 2009-11-16  Eric Seidel  <eric@webkit.org>
1146
1147         Reviewed by Adam Barth.
1148
1149         land-patches needs to be re-factored into smaller chunks
1150         https://bugs.webkit.org/show_bug.cgi?id=31532
1151
1152         * Scripts/bugzilla-tool: fix a couple obvious typos.
1153
1154 2009-11-16  Eric Seidel  <eric@webkit.org>
1155
1156         Reviewed by Adam Barth.
1157
1158         land-patches needs to be re-factored into smaller chunks
1159         https://bugs.webkit.org/show_bug.cgi?id=31532
1160
1161         The next patch will move these methods into WebKitLandingScripts.
1162
1163         * Scripts/bugzilla-tool:
1164          - Split out _land_patch and _close_bug_if_no_active_patches.
1165
1166 2009-11-16  Adam Barth  <abarth@webkit.org>
1167
1168         Reviewed by Eric Seidel.
1169
1170         Fix silly copy-and-paste code.  I am a terrible coder.
1171
1172         * Scripts/modules/bugzilla.py:
1173
1174 2009-11-16  Adam Barth  <abarth@webkit.org>
1175
1176         Reviewed by Eric Seidel.
1177
1178         Implement a StyleQueue
1179         https://bugs.webkit.org/show_bug.cgi?id=31537
1180
1181         The first iteration of the style queue only produces output locally.
1182         There is also a limit of 10 patches because it's not that useful to
1183         iterate through the entire review queue at this point.  We can remove
1184         the limit later.
1185
1186         * Scripts/bugzilla-tool:
1187         * Scripts/modules/bugzilla.py:
1188
1189 2009-11-16  Adam Barth  <abarth@webkit.org>
1190
1191         Reviewed by Eric Seidel.
1192
1193         Unit test WorkQueue
1194         https://bugs.webkit.org/show_bug.cgi?id=31531
1195
1196         Adds basic unit testing for WorkQueue.  Just runs through one cycle.
1197
1198         * Scripts/bugzilla-tool:
1199         * Scripts/modules/statusbot.py:
1200         * Scripts/modules/workqueue.py:
1201         * Scripts/modules/workqueue_unittest.py: Added.
1202         * Scripts/run-webkit-unittests:
1203
1204 2009-11-16  Eric Seidel  <eric@webkit.org>
1205
1206         Reviewed by Adam Barth.
1207
1208         bugzilla-tool land-diff should know how to parse bug ids out of ChangeLogs
1209         https://bugs.webkit.org/show_bug.cgi?id=31530
1210
1211         * Scripts/bugzilla-tool:
1212
1213 2009-11-16  Eric Seidel  <eric@webkit.org>
1214
1215         Reviewed by Adam Barth.
1216
1217         bugzilla-tool needs apply-attachment
1218         https://bugs.webkit.org/show_bug.cgi?id=31528
1219
1220         * Scripts/bugzilla-tool:
1221          - Add ApplyAttachment command.
1222          - Abstract applying code into WebKitApplyingScripts.
1223          - Rename setup_for_landing to prepare_clean_working_directory and make local_commit checking optional.
1224         * Scripts/modules/bugzilla.py:
1225          - Add fetch_attachment and bug_id_for_attachment_id.
1226         * Scripts/modules/bugzilla_unittest.py:
1227          - Add test for new parsing.
1228          - Fix previous parsing test which broke with Adam's check-style patch (bug 31515).
1229
1230 2009-11-16  Eric Seidel  <eric@webkit.org>
1231
1232         Reviewed by Adam Barth.
1233
1234         Document check-style's use of force_clean.
1235
1236         * Scripts/bugzilla-tool:
1237         * Scripts/modules/scm.py:
1238
1239 2009-11-16  Adam Barth  <abarth@webkit.org>
1240
1241         Reviewed by Eric Seidel.
1242
1243         Move WorkQueue to its own file
1244         https://bugs.webkit.org/show_bug.cgi?id=31529
1245
1246         WorkQueue and WorkQueueDelegate are separate concerns from
1247         bugzilla-tool.  Also added a missing include to logging.py.
1248
1249         * Scripts/bugzilla-tool:
1250         * Scripts/modules/logging.py:
1251         * Scripts/modules/workqueue.py:
1252
1253 2009-11-16  Adam Barth  <abarth@webkit.org>
1254
1255         Reviewed by Eric Seidel.
1256
1257         Move OutputTee to logging.py.
1258
1259         * Scripts/bugzilla-tool:
1260         * Scripts/modules/logging.py:
1261
1262 2009-11-15  Adam Barth  <abarth@webkit.org>
1263
1264         Reviewed by Eric Seidel.
1265
1266         Refactor bugzilla-tool to allow for multiple queues
1267         https://bugs.webkit.org/show_bug.cgi?id=31513
1268
1269         Divide the commit queue class into three class to make creating
1270         additional queues easier.
1271
1272         * Scripts/bugzilla-tool:
1273
1274 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1275
1276         Reviewed by Eric Seidel.
1277
1278         svn-apply may not handle git patches created by bugzilla-tool
1279         https://bugs.webkit.org/show_bug.cgi?id=31457
1280
1281         * Scripts/modules/scm.py:
1282         * Scripts/modules/scm_unittest.py:
1283
1284 2009-11-15  Shinichiro Hamaji  <hamaji@chromium.org>
1285
1286         Reviewed by Eric Seidel.
1287
1288         bugzilla-tool should post git binary diff
1289         https://bugs.webkit.org/show_bug.cgi?id=31458
1290
1291         Add --binary option to Git.create_patch.
1292
1293         * Scripts/modules/scm.py:
1294         * Scripts/modules/scm_unittest.py:
1295
1296 2009-11-15  Adam Barth  <abarth@webkit.org>
1297
1298         Reviewed by Darin Adler.
1299
1300         Add bugzilla-tool check-style
1301         https://bugs.webkit.org/show_bug.cgi?id=31515
1302
1303         * Scripts/bugzilla-tool:
1304         * Scripts/modules/bugzilla.py:
1305
1306 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1307
1308         Reviewed by Simon Hausmann.
1309
1310         Make the Qt Linux only --valgrind feature, suppress errors
1311         defined in the SuppressedValgrindErrors file.
1312
1313         * Scripts/run-webkit-tests:
1314
1315 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1316
1317         Reviewed by Simon Hausmann.
1318
1319         Set the locale to C and not to the current one in use on the system.
1320
1321         * DumpRenderTree/qt/DumpRenderTree.cpp:
1322         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1323
1324 2009-11-13  Adam Roben  <aroben@apple.com>
1325
1326         Add support for
1327         http/tests/security/isolatedWorld/didClearWindowObject.html
1328
1329         Fixes <http://webkit.org/b/31124> Tell the WebFrameLoadDelegate when
1330         window objects in isolated worlds are cleared
1331
1332         Reviewed by Dave Hyatt.
1333
1334         * DumpRenderTree/mac/DumpRenderTreeMac.h: Declared worldIDForWorld.
1335
1336         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1337         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
1338         Added. Moved code here from -webView:didClearWindowObject:forFrame:.
1339         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
1340         Added. Sets a __worldID property on the global object whose value is
1341         the ID of this world.
1342         (-[FrameLoadDelegate webView:didClearWindowObjectForFrame:inScriptWorld:]):
1343         Respond to this new delegate callback by calling through to one of the
1344         above new methods.
1345         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1346         (worldMap): Added. Returns a HashMap containing all the worlds we've
1347         created.
1348         (worldIDForWorld): Added. Returns the ID for this world, or 0 if we
1349         haven't kept track of this world.
1350         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1351         instead of declaring our own.
1352
1353         * DumpRenderTree/win/DumpRenderTreeWin.h: Declared worldIDForWorld.
1354
1355         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1356         (FrameLoadDelegate::didClearWindowObject): Moved code from hear to
1357         didClearWindowObjectForFrameInStandardWorld.
1358         (FrameLoadDelegate::didClearWindowObjectForFrameInScriptWorld):
1359         Respond to this new delegate callback by calling through to one of the
1360         below new methods.
1361         (FrameLoadDelegate::didClearWindowObjectForFrameInIsolatedWorld):
1362         Added. Sets a __worldID property on the gobal object whose value is
1363         the ID of this world.
1364         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
1365         Added. Moved code here from didClearWindowObject.
1366
1367         * DumpRenderTree/win/FrameLoadDelegate.h: Added the
1368         didClearWindowObjectForFrame* functions.
1369
1370         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1371         (worldMap): Added. Returns a HashMap containing all the worlds we've
1372         created.
1373         (worldIDForWorld): Added. Returns the ID of this world, or 0 if we
1374         haven't kept track of this world.
1375         (LayoutTestController::evaluateScriptInIsolatedWorld): Use worldMap()
1376         instead of declaring our own.
1377
1378 2009-11-13  Adam Roben  <aroben@apple.com>
1379
1380         Finish replacing worldIDs with world objects
1381
1382         The only remaining use of worldIDs was in a method only used by DRT
1383         for the isolated worlds tests.
1384
1385         Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
1386
1387         Reviewed by Mark Rowe.
1388
1389         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1390         (LayoutTestController::evaluateScriptInIsolatedWorld):
1391         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1392         (LayoutTestController::evaluateScriptInIsolatedWorld):
1393         Updated for changes to WebFrame. Now holds the map of worldID -> world
1394         at this level instead of making WebKit do it.
1395
1396 2009-11-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1397
1398         Reviewed by Simon Hausmann.
1399
1400         [Qt] Ensure the DRT does not output anything until first test is run
1401
1402         * DumpRenderTree/qt/DumpRenderTree.cpp:
1403         * DumpRenderTree/qt/DumpRenderTree.h:
1404
1405 2009-11-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1406
1407         Reviewed by Tor Arne Vestbø.
1408
1409         Clear the undo stack in before each new test run.
1410
1411         Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
1412
1413         * DumpRenderTree/qt/DumpRenderTree.cpp:
1414         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1415
1416 2009-11-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1417
1418         Reviewed by Kenneth Rohde Christiansen.
1419
1420         [Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
1421
1422         * DumpRenderTree/qt/DumpRenderTree.cpp:
1423         (WebCore::WebPage::resetSettings):
1424         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1425         (LayoutTestController::overridePreference):
1426
1427 2009-11-13  Eric Seidel  <eric@webkit.org>
1428
1429         Reviewed by Adam Barth.
1430
1431         Update committers.py based on svn records
1432         https://bugs.webkit.org/show_bug.cgi?id=31366
1433
1434         This list was generated using validate-committer-lists from
1435         https://bugs.webkit.org/show_bug.cgi?id=30970
1436         and makes committers.py current for committers who have
1437         committed in the last 3 years.
1438
1439         * Scripts/modules/committers.py:
1440
1441 2009-11-12  Anantanarayanan G Iyengar  <ananta@chromium.org>
1442
1443         Reviewed by Adam Barth.
1444
1445         The document-open.html test was flaky at times. The test invokes the layout test plugin
1446         which in its destroy stream handler opens a new document. This basically tears down the
1447         stream and the associated plugin instance. The pluginLog function in the layout test
1448         plugin attempts to retrieve the window script object on a torn down plugin instance
1449         which crashed consistently on windows in the debugger. The functions which issue
1450         these logs already have a valid window script object. We now have variants of the pluginLog
1451         function which take in a window script object with and without variable arguments. 
1452
1453         https://bugs.webkit.org/show_bug.cgi?id=31067
1454
1455         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1456         (pluginLogWithWindowObject):
1457         (pluginLogWithWindowObjectVariableArgs):
1458         (pluginLog):
1459         (notifyTestCompletion):
1460         (testDocumentOpen):
1461         (testWindowOpen):
1462
1463 2009-11-12  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
1464
1465         Reviewed by Gustavo Noronha Silva.
1466
1467         https://bugs.webkit.org/show_bug.cgi?id=30997
1468         [Gtk] Implemment AtkDocument
1469
1470         Added testing support.
1471
1472         * DumpRenderTree/AccessibilityUIElement.cpp:
1473         * DumpRenderTree/AccessibilityUIElement.h:
1474         (getDocumentEncodingCallback):
1475         (getDocumentURICallback):
1476         (AccessibilityUIElement::getJSClass):
1477         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1478         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1479         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1480         (AccessibilityUIElement::documentEncoding):
1481         (AccessibilityUIElement::documentURI):
1482
1483 2009-11-12  Adam Roben  <aroben@apple.com>
1484
1485         Replace worldIDs with world objects
1486
1487         Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
1488         user scripts/stylesheets and isolated worlds
1489
1490         Reviewed by Sam Weinig.
1491
1492         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1493         (LayoutTestController::addUserScript):
1494         (LayoutTestController::addUserStyleSheet):
1495         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1496         (LayoutTestController::addUserScript):
1497         (LayoutTestController::addUserStyleSheet):
1498         Changed these functions to create a new WebJSWorld each time they're
1499         called and to pass that world to WebKit.
1500
1501 2009-11-11  Chris Fleizach  <cfleizach@apple.com>
1502
1503         Reviewed by Oliver Hunt.
1504
1505         need to implement aria tree roles
1506         https://bugs.webkit.org/show_bug.cgi?id=31284
1507
1508         * DumpRenderTree/AccessibilityUIElement.cpp:
1509         (disclosedRowAtIndexCallback):
1510         (selectedRowAtIndexCallback):
1511         (isEqualCallback):
1512         (isAttributeSettableCallback):
1513         (isActionSupportedCallback):
1514         (disclosedByRowCallback):
1515         (hierarchicalLevelCallback):
1516         (AccessibilityUIElement::getJSClass):
1517         * DumpRenderTree/AccessibilityUIElement.h:
1518         (AccessibilityUIElement::isEqual):
1519         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1520         (AccessibilityUIElement::hierarchicalLevel):
1521         (AccessibilityUIElement::disclosedRowAtIndex):
1522         (AccessibilityUIElement::selectedRowAtIndex):
1523         (AccessibilityUIElement::disclosedByRow):
1524         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1525         (AccessibilityUIElement::getChildAtIndex):
1526         (AccessibilityUIElement::disclosedRowAtIndex):
1527         (AccessibilityUIElement::selectedRowAtIndex):
1528         (AccessibilityUIElement::titleUIElement):
1529         (AccessibilityUIElement::parentElement):
1530         (AccessibilityUIElement::disclosedByRow):
1531         (AccessibilityUIElement::hierarchicalLevel):
1532         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1533         (AccessibilityUIElement::hierarchicalLevel):
1534         (AccessibilityUIElement::disclosedRowAtIndex):
1535         (AccessibilityUIElement::selectedRowAtIndex):
1536         (AccessibilityUIElement::disclosedByRow):
1537
1538 2009-11-11  Shinichiro Hamaji  <hamaji@chromium.org>
1539
1540         Reviewed by Darin Adler.
1541
1542         svn-apply can not handle git binary diffs
1543         https://bugs.webkit.org/show_bug.cgi?id=26830
1544
1545         Support "literal" type git binary diffs.
1546
1547         * Scripts/VCSUtils.pm:
1548         * Scripts/modules/scm_unittest.py:
1549         * Scripts/svn-apply:
1550
1551 2009-11-11  Dmitry Titov  <dimich@chromium.org>
1552
1553         Not reviewed, removing duplicate entry for myself in committers.py.
1554
1555         * Scripts/modules/committers.py:
1556
1557 2009-11-11  Alexey Proskuryakov  <ap@apple.com>
1558
1559         Reviewed by Darin Adler and Mark Rowe.
1560
1561         https://bugs.webkit.org/show_bug.cgi?id=31200
1562         Tests in http/tests/security/mixedContent start to fail when new tests are added
1563
1564         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Added a workaround for Tiger bug.
1565
1566 2009-11-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1567
1568         Reviewed by Jan Alonzo.
1569
1570         Create, and display a window for the inspector, for inspector
1571         tests.
1572
1573         Need to also show/hide the inspector window to avoid having
1574         problems with code assuming it is realized
1575         https://bugs.webkit.org/show_bug.cgi?id=31347
1576
1577         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1578         (webInspectorShowWindow):
1579         (webInspectorCloseWindow):
1580         (webInspectorInspectWebView):
1581         (createWebView):
1582
1583 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1584
1585         Unreviewed Qt buildbot fix.
1586
1587         My previous fix was wrong, so revert that change and fix it by
1588         returning when the document of the frame has no document element.
1589         Idea is borrowed from mac and win DRT.
1590
1591         * DumpRenderTree/qt/DumpRenderTree.cpp:
1592         (WebCore::DumpRenderTree::dumpFramesAsText):
1593
1594 2009-11-11  Eric Seidel  <eric@webkit.org>
1595
1596         Reviewed byg Kenneth Rohde Christiansen.
1597
1598         Update Kenneth's committer record to include the email he
1599         uses on lists.webkit.org.
1600
1601         * Scripts/modules/committers.py:
1602
1603 2009-11-11  Eric Seidel  <eric@webkit.org>
1604
1605         Reviewed by Gustavo Noronha Silva.
1606
1607         Several committers use separate email addresses for bugzilla and svn.webkit.org
1608         https://bugs.webkit.org/show_bug.cgi?id=31364
1609
1610         Update records for existing committers to include email addresses
1611         used in svn.webkit.org and lists.webkit.org.
1612         Most committers use the same email address in all 3 places, but some use
1613         separate addresses.  committers.py needs record of each of these addresses.
1614
1615         * Scripts/modules/committers.py:
1616
1617 2009-11-11  Eric Seidel  <eric@webkit.org>
1618
1619         No review, adding second email address for an existing committer.
1620
1621         Add Yong Li's second bugzilla account to his committer record.
1622         See: https://bugs.webkit.org/show_bug.cgi?id=27371#c27
1623
1624         * Scripts/modules/committers.py:
1625
1626 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1627
1628         Reviewed by Simon Hausmann.
1629
1630         If the frame has no innerText don't append it, and
1631         do not add a newline which breaks some cross platform
1632         results.
1633
1634         * DumpRenderTree/qt/DumpRenderTree.cpp:
1635         (WebCore::DumpRenderTree::dumpFramesAsText):
1636
1637 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1638
1639         Reviewed by Simon Hausmann.
1640
1641         Implement missing functionality in the Gtk/Qt TestNetscapePlugin.
1642
1643         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1644         (webkit_test_plugin_new_instance):
1645         (webkit_test_plugin_destroy_instance):
1646         (webkit_test_plugin_destroy_stream):
1647
1648 2009-11-11  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1649
1650         Reviewed by Mark Rowe.
1651
1652         Implement the functionality needed by plugins/window-open.html
1653
1654         * DumpRenderTree/gtk/TestNetscapePlugin/TestNetscapePlugin.cpp:
1655         (webkit_test_plugin_new_instance):
1656         (webkit_test_plugin_set_window):
1657
1658 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1659
1660         Reviewed by Simon Hausmann.
1661
1662         [Qt] Force -graphicssystem raster and -style windows when running DRT
1663
1664         * DumpRenderTree/qt/main.cpp:
1665         * Scripts/run-webkit-tests:
1666
1667 2009-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1668
1669         Reviewed by Simon Hausmann.
1670
1671         Compute correct library paths for Qt
1672
1673         * Scripts/webkitdirs.pm:
1674
1675 2009-11-10  Mark Rowe  <mrowe@apple.com>
1676
1677         Reviewed by Sam Weinig.
1678
1679         <http://webkit.org/b/31200> Tests in http/tests/security/mixedContent start to fail when new tests are added
1680
1681         The first request to an HTTPS URL results in didFailProvisionalLoadWithError being called with an error
1682         about the validity of the self-signed certificates used in the regression tests.  We would then add the
1683         host to the ignore list for SSL certificate errors and retry the request.  If this happened during a test
1684         that had enabled frame load delegate logging this would result in extra log messages being generated,
1685         causing the test to fail.
1686
1687         We address this by explicitly ignoring SSL certificate errors for localhost and 127.0.0.1 before running any
1688         tests.
1689
1690         * DumpRenderTree/mac/DumpRenderTree.mm:
1691         (dumpRenderTree):
1692         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1693         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
1694
1695 2009-11-10  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
1696
1697         Reviewed by Kenneth Rohde Christiansen.
1698
1699         [Qt] Remove obsolete scrollbar policy settings from DRT constructor.
1700
1701         * DumpRenderTree/qt/DumpRenderTree.cpp:
1702         (WebCore::DumpRenderTree::DumpRenderTree):
1703
1704 2009-11-10  Philippe Normand  <pnormand@igalia.com>
1705
1706         Reviewed by Jan Alonzo.
1707
1708         [GTK] Remove WebSocket configuration from WebKitWebSettings
1709         https://bugs.webkit.org/show_bug.cgi?id=31244
1710
1711         Follow-up of r50724. Don't set the enable-web-socket property
1712         anymore.
1713
1714         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1715         (resetDefaultsToConsistentValues):
1716
1717 2009-11-10  Oliver Hunt  <oliver@apple.com>
1718
1719         Reviewed by Maciej Stachowiak.
1720
1721         Rename 3D Canvas related classes to use WebGL prefix
1722         https://bugs.webkit.org/show_bug.cgi?id=29095
1723
1724         Checkin new version of do-webcore-rename used to do the WebGL type rename,
1725         and upate webkitdirs script to new method of testing for WebGL.
1726
1727         * Scripts/do-webcore-rename:
1728         * Scripts/webkitdirs.pm:
1729
1730 2009-11-09  Oliver Hunt  <oliver@apple.com>
1731
1732         Reviewed by Geoff Garen.
1733
1734         Make do-webcore-rename work with git.
1735
1736         * Scripts/do-webcore-rename:
1737
1738 2009-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1739
1740         Adding Kenneth to the reviewers list.
1741
1742         * Scripts/modules/committers.py:
1743
1744 2009-11-09  Martin Robinson  <martin.james.robinson@gmail.com>
1745
1746         Reviewed by Jan Alonzo.
1747
1748         [GTK] Expose Page::tabKeyCyclesThroughElements in the API
1749         https://bugs.webkit.org/show_bug.cgi?id=30482
1750
1751         LayoutTestControllerGtk now uses the exposed
1752         Page::tabKeyCyclesThroughElements API
1753
1754         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1755         (LayoutTestController::setTabKeyCyclesThroughElements):
1756
1757 2009-11-08  Shu Chang  <Chang.Shu@nokia.com>
1758
1759         Reviewed by Holger Freyther.
1760
1761         [Qt] Added support for key code 8 (backspace) in EventSenderQt.
1762         This helps to pass the test case below. Also replaced hardcoded
1763         code numbers with defined constants.
1764         https://bugs.webkit.org/show_bug.cgi?id=31185
1765         
1766         Test: editing/undo/undo-deleteWord.html
1767
1768         * DumpRenderTree/qt/EventSenderQt.cpp:
1769         (EventSender::keyDown):
1770
1771 2009-11-07  Antonio Gomes  <tonikitoo@webkit.org>
1772
1773         Reviewed by Holger Freyther.
1774
1775         [Qt] [DRT] Fix wrong logic in LayoutTestController processWork
1776         https://bugs.webkit.org/show_bug.cgi?id=31164
1777
1778         Fixed wrong logic to assume WorkQueue is done in QT's DRT.
1779
1780         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1781         (LayoutTestController::processWork):
1782
1783 2009-11-05  Antonio Gomes  <tonikitoo@webkit.org>
1784
1785         Reviewed by Holger Freyther.
1786
1787         [Qt][DRT] Replace queueScript by queueNonLoadingScript and queueLoadingScript method
1788         https://bugs.webkit.org/show_bug.cgi?id=31158
1789
1790         By invoking a script queue'd by queueScript(), 'true' was beeing returned
1791         always, which from WorkQueue prospective means that a load has been started
1792         and the queue processing should stop and wait for the load to finish.
1793         Spinning it off into a loading and a non-loading variants was the solution
1794         adopted by Mac's DRT to work around this problem. The former keeps returning
1795         'true' while the later executes the script synchronously and returns 'false'
1796         making it possible to the WorkQueue to proceed right away.
1797
1798         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1799         (LayoutTestController::processWork):
1800         (LayoutTestController::queueLoadingScript):
1801         (LayoutTestController::queueNonLoadingScript):
1802         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1803         * DumpRenderTree/qt/WorkQueueItem.h:
1804         (LoadingScriptItem::LoadingScriptItem):
1805         (LoadingScriptItem::invoke):
1806         (NonLoadingScriptItem::NonLoadingScriptItem):
1807         (NonLoadingScriptItem::invoke):
1808
1809 2009-11-07  Mark Rowe  <mrowe@apple.com>
1810
1811         Rubber-stamped by Cameron Zwarich.
1812
1813         Invoke prepare-ChangeLog via an absolute path rather than assuming it can be found in PATH.
1814
1815         * Scripts/commit-log-editor:
1816
1817 2009-11-07  Mark Rowe  <mrowe@apple.com>
1818
1819         Reviewed by Darin Adler.
1820
1821         Fix <https://bugs.webkit.org/show_bug.cgi?id=28168>.
1822         commit-log-editor does not support all the email address configurations that prepare-Changelog supports
1823
1824         Move logic for determining the name and email address to use in a ChangeLog entry from
1825         prepare-ChangeLog to VCSUtils so that commit-log-editor can use it.  It wants to check
1826         whether the author of the patch matches committer, and therefore needs access to the
1827         email address that would be used in a ChangeLog entry.
1828
1829         Based on a patch by Pierre d'Herbemont.
1830
1831         * Scripts/VCSUtils.pm:
1832         * Scripts/commit-log-editor:
1833         * Scripts/prepare-ChangeLog:
1834         * Scripts/webkitdirs.pm:
1835
1836 2009-11-06  Anantanarayanan G Iyengar  <ananta@chromium.org>
1837
1838         Reviewed by Adam Barth.
1839
1840         Added functionality to the layout test plugin to invoke document.open and
1841         window.open with default arguments. The associated webkit bug is
1842         https://bugs.webkit.org/show_bug.cgi?id=31067, which affects Chromium. Basically
1843         window.open and document.open calls issued by NPAPI plugins via NPN_Invoke don't
1844         work in Chromium (V8) if there is no calling javascript context. To achieve this
1845         effect we invoke these functions in the layout test plugin in the NPP_SetWindow
1846         for the window.open test case and in NPP_DestroyStream for the document.open test case.
1847
1848         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
1849         (testDocumentOpen):
1850         (testWindowOpen):
1851         (pluginAllocate):
1852         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
1853         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
1854         (NPP_New):
1855         (NPP_SetWindow):
1856         (NPP_DestroyStream):
1857         * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
1858         (NPP_New):
1859         (NPP_SetWindow):
1860         (NPP_NewStream):
1861         (NPP_DestroyStream):
1862
1863 2009-11-06  Eric Seidel  <eric@webkit.org>
1864
1865         Reviewed by Adam Barth.
1866
1867         bugzilla-tool crashed with exception
1868         https://bugs.webkit.org/show_bug.cgi?id=31092
1869
1870         * Scripts/modules/bugzilla.py: Change a ',' to a '%' to fix the error.
1871
1872 2009-11-04  Eric Seidel  <eric@webkit.org>
1873
1874         No review, just add a line which got left out of the patch uploaded for commit.
1875
1876         commit-queue is crashing when trying to reject patches after unknown failures
1877         https://bugs.webkit.org/show_bug.cgi?id=31091
1878
1879         * Scripts/bugzilla-tool: Set bug_log = None after closing to we don't re-close and crash.
1880
1881 2009-11-04  Adam Roben  <aroben@apple.com>
1882
1883         Remove bogus else clause in bugzilla-tool
1884
1885         Fixes <http://webkit.org/b/31125> REGRESSION (r47121): bugzilla-tool
1886         create-bug raises exception after entering bug description
1887
1888         Reviewed by David Kilzer.
1889
1890         * Scripts/bugzilla-tool:
1891         (CreateBug): else clauses are only hit if no exception is raised, so
1892         it makes no sense to try to re-raise the exception in an else clause.
1893         The exception will automatically be re-raised if it doesn't match any
1894         of the except clauses, so we don't have to do anything special here at
1895         all to get the desired behavior.
1896
1897 2009-11-04  Eric Seidel  <eric@webkit.org>
1898
1899         Reviewed by David Kilzer.
1900
1901         svn-apply's fixChangeLogPatch function seems broken
1902         https://bugs.webkit.org/show_bug.cgi?id=30683
1903
1904         Update fixChangeLogPatch to be able to handle patches which
1905         don't start at line 1.
1906         Add unit tests for svn-apply to scm_unittest.py.
1907
1908         * Scripts/VCSUtils.pm:
1909         * Scripts/modules/scm_unittest.py:
1910
1911 2009-11-04  Chris Fleizach  <cfleizach@apple.com>
1912
1913         Reviewed by Beth Dakin.
1914
1915         Need to implement ARIA role="combobox"
1916         https://bugs.webkit.org/show_bug.cgi?id=31096
1917
1918         * DumpRenderTree/AccessibilityUIElement.cpp:
1919         (showMenuCallback):
1920         (getIsExpandedCallback):
1921         (AccessibilityUIElement::getJSClass):
1922         * DumpRenderTree/AccessibilityUIElement.h:
1923         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1924         (AccessibilityUIElement::isExpanded):
1925         (AccessibilityUIElement::showMenu):
1926         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1927         (AccessibilityUIElement::isExpanded):
1928         (AccessibilityUIElement::showMenu):
1929         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1930         (AccessibilityUIElement::isSelected):
1931         (AccessibilityUIElement::isExpanded):
1932         (AccessibilityUIElement::showMenu):
1933
1934 2009-11-04  Eric Seidel  <eric@webkit.org>
1935
1936         Reviewed by Adam Barth.
1937
1938         commit-queue is crashing when trying to reject patches after unknown failures
1939         https://bugs.webkit.org/show_bug.cgi?id=31091
1940
1941         * Scripts/bugzilla-tool:
1942          - patch['id'] was a copy/paste mistake.  This code has no 'patch' variable
1943            so we have to find out what the current patch is by asking bugzilla again.
1944          - Discovered that this code was also leaking file descriptors, so fixed that.
1945
1946 2009-11-04  Adam Roben  <aroben@apple.com>
1947
1948         Make run-webkit-tests work for the Debug_Internal Windows
1949         configuration
1950
1951         In Debug_Internal, DumpRenderTree.exe and ImageDiff.exe have no _debug
1952         suffix.
1953
1954         Fixes <http://webkit.org/b/31123>.
1955
1956         Reviewed by Sam Weinig.
1957
1958         * Scripts/run-webkit-tests: Don't add the _debug suffix in
1959         Debug_Internal, either.
1960
1961 2009-11-04  Eric Seidel  <eric@webkit.org>
1962
1963         Reviewed by Adam Barth.
1964
1965         committers.py needs a way to store non-bugzilla email addresses
1966         https://bugs.webkit.org/show_bug.cgi?id=31037
1967
1968         Make Committer and Reviewer constructors take a single email or a list of emails.
1969         Change committer_by_bugzilla_email functions to committer_by_email to support lookup by any email.
1970         Expose reviewers(), used by validate-committer-lists on bug 30970.
1971
1972         * Scripts/modules/committers.py:
1973         * Scripts/modules/committers_unittest.py: Added tests for the new code.
1974
1975 2009-11-03  Yuzo Fujishima  <yuzo@google.com>
1976
1977         Reviewed by David Levin.
1978
1979         Start/Stop Web Socket and Web Socket Secure servers for layout tests.
1980         https://bugs.webkit.org/show_bug.cgi?id=27491
1981
1982         The test path determination logic is changed to handle websocket and websocket/ssl cases.
1983         The logic for non-http (and now also non-websocket) tests is moved toward the end of the if-elsif statement.
1984
1985         Functions to start or stop Web Socket servers are added.
1986
1987         * Scripts/run-webkit-tests:
1988
1989 2009-11-03  Eric Seidel  <eric@webkit.org>
1990
1991         No review, just changing wording of log message.
1992
1993         Change log string to say "failed" instead of "rejected"
1994         when a commit fails due to an out of date checkout.
1995         This makes grepping the commit-queue log for rejected patches easier.
1996
1997         * Scripts/bugzilla-tool:
1998
1999 2009-11-03  Eric Seidel  <eric@webkit.org>
2000
2001         No review, adding commonly known committers missing from the file.
2002
2003         * Scripts/modules/committers.py: Add committers found by looking at SVN records.
2004
2005 2009-11-03  Eric Seidel  <eric@webkit.org>
2006
2007         No review, just sort-order cleanup.
2008
2009         * Scripts/modules/committers.py: Sort committers/reviewers alphabetically.
2010
2011 2009-11-03  Stephen White  <senorblanco@chromium.org>
2012
2013         (Unreviewed).
2014
2015         Add myself to committers.py.
2016
2017         * Scripts/modules/committers.py:
2018
2019 2009-11-03  Robin Dunn  <robin@alldunn.com>
2020
2021         Reviewed by Kevin Ollviier.
2022
2023         Add packaging scripts for Debian-based Linux distros.
2024         
2025         https://bugs.webkit.org/show_bug.cgi?id=31075
2026
2027         * wx/packaging/build-debian-installer.py: Added.
2028         * wx/packaging/debian: Added.
2029
2030 2009-11-03  Dan Bernstein  <mitz@apple.com>
2031
2032         Reviewed by Anders Carlsson and Beth Dakin.
2033
2034         https://bugs.webkit.org/show_bug.cgi?id=31070
2035
2036         Added an 'ondestroy' parameter to the test plug-in. When the plug-in is
2037         destroyed, it executes the value of the 'ondestroy' parameter as a
2038         script.
2039
2040         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
2041         (pluginAllocate): Initialize onDestroy.
2042         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Define
2043         onDestroy.
2044         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
2045         (NPP_New): Set onDestroy to the value of the 'ondestroy' parameter, if
2046         specified.
2047         (NPP_Destroy): Execute the value of 'ondestroy' as a script.
2048
2049 2009-11-02  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
2050
2051         Reviewed by Xan Lopez.
2052
2053         https://bugs.webkit.org/show_bug.cgi?id=31035
2054         [GTK] some accessibility tests hitting assertion in debug builds
2055
2056         Get the correct Gtk+ object before attempting to turn it into an AtkObject.
2057
2058         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2059         (AccessibilityController::rootElement):
2060
2061 2009-11-02  Chris Fleizach  <cfleizach@apple.com>
2062
2063         Reviewed by Beth Dakin.
2064
2065         Support ARIA "tab" roles
2066         https://bugs.webkit.org/show_bug.cgi?id=30842
2067
2068         * DumpRenderTree/AccessibilityUIElement.cpp:
2069         * DumpRenderTree/AccessibilityUIElement.h:
2070         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2071         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2072         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2073
2074 2009-11-01  Eric Seidel  <eric@webkit.org>
2075
2076         Reviewed by David Levin.
2077
2078         buildbots should use --exit-after-N-failures
2079         https://bugs.webkit.org/show_bug.cgi?id=30809
2080
2081         Make the bots exit after 20 failures to prevent never-ending
2082         test runs where every test spends a minute crashing.
2083
2084         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2085
2086 2009-11-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2087
2088         Reviewed by Eric Seidel.
2089
2090         Turn on warnings for QtWebKit for gcc
2091         https://bugs.webkit.org/show_bug.cgi?id=30958
2092
2093         * DumpRenderTree/qt/main.cpp: 
2094         (crashHandler): Mark function NO_RETURN
2095
2096 2009-11-01  Jessie Berlin  <jberlin@webkit.org>
2097
2098         Adding myself to the committers list.
2099
2100         * Scripts/modules/committers.py:
2101
2102 2009-10-30  Jon Honeycutt  <jhoneycutt@apple.com>
2103
2104         Fix an issue that Adam noticed in DRT.
2105
2106         Reviewed by Darin Adler.
2107
2108         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2109         (AccessibilityUIElement::role):
2110         Get the length of the role text, and create a buffer dynamically.
2111
2112 2009-10-30  Eric Seidel  <eric@webkit.org>
2113
2114         No review, rolling out r50105.
2115         http://trac.webkit.org/changeset/50105
2116
2117         This commit was causing:
2118         https://bugs.webkit.org/show_bug.cgi?id=30869
2119         We'll re-implement the feature a different way.
2120
2121         * Scripts/bugzilla-tool:
2122
2123 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2124
2125         Test for MSAA: Accessibility of headings is not correct
2126
2127         https://bugs.webkit.org/show_bug.cgi?id=30937
2128
2129         Reviewed by Adam Roben.
2130
2131         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2132         (AccessibilityUIElement::role):
2133         Allow the role returned to be a BSTR.
2134         (AccessibilityUIElement::description):
2135         Fix a copy/paste error.
2136
2137 2009-10-29  Jon Honeycutt  <jhoneycutt@apple.com>
2138
2139         Test for MSAA: Accessibility of links is wrong
2140
2141         https://bugs.webkit.org/show_bug.cgi?id=30928
2142
2143         Reviewed by Darin Adler.
2144
2145         * DumpRenderTree/AccessibilityUIElement.cpp:
2146         (getAccessibilityValueCallback):
2147         Return the accessibility value.
2148         (AccessibilityUIElement::getJSClass):
2149         Added "accessibilityValue" value.
2150
2151         * DumpRenderTree/AccessibilityUIElement.h:
2152
2153         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2154         (AccessibilityUIElement::accessibilityValue):
2155         Stubbed.
2156
2157         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2158         (AccessibilityUIElement::accessibilityValue):
2159         Stubbed.
2160
2161         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2162         (AccessibilityUIElement::accessibilityValue):
2163         Get the object's value, and return it as a JS string.
2164
2165 2009-10-30  Kevin Ollivier  <kevino@theolliviers.com>
2166
2167         Fix typo in command name used by wx build system.
2168
2169         * wx/build/build_utils.py:
2170
2171 2009-10-30  Adam Barth  <abarth@webkit.org>
2172
2173         Reviewed by Darin Adler.
2174
2175         Patch v1 is a dumb default name for patches
2176         https://bugs.webkit.org/show_bug.cgi?id=30952
2177
2178         Let's use "Patch" instead.
2179
2180         * Scripts/bugzilla-tool:
2181
2182 2009-10-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
2183
2184         Unreviewed trivial buildfix.
2185
2186         [Qt] Buildfix for r50333.
2187
2188         * DumpRenderTree/qt/DumpRenderTree.pro:
2189
2190 2009-10-30  Antonio Gomes  <tonikitoo@webkit.org>
2191
2192         Reviewed by Holger Freyther.
2193
2194         [Qt] Remove qt/WorkQueue.cpp|h in favor of platform independent WorkQueue
2195         https://bugs.webkit.org/show_bug.cgi?id=30953
2196
2197         DumpRenderTree/WorkQueue and DumpRenderTree/qt/WorkQueue share mostly the
2198         same implementation. Some Q_ASSERTs differ from ASSERTs basically. Patch
2199         makes qt DRT to share this implementation (as gtk and mac ports do).
2200
2201         * DumpRenderTree/qt/DumpRenderTree.pro:
2202         * DumpRenderTree/qt/WorkQueue.cpp: Removed.
2203         * DumpRenderTree/qt/WorkQueue.h: Removed.
2204
2205 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2206
2207         Unreviewed potential buildbot fix.
2208
2209         Second try: Reset page history before running each test.
2210
2211         Apparently the QWebHistory::clear() keeps the current page
2212         in history which is not what we want, so we not additionally
2213         sets the history capacity to 0 (forces removing everything)
2214         and then sets it back to its original value.
2215
2216         * DumpRenderTree/qt/DumpRenderTree.cpp:
2217         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2218
2219 2009-10-30  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2220
2221         Unreviewed potential buildbot fix.
2222
2223         Reset page history before running each test.
2224
2225         * DumpRenderTree/qt/DumpRenderTree.cpp:
2226         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2227
2228 2009-10-30  Roland Steiner  <rolandsteiner@chromium.org>
2229
2230         Reviewed by Eric Seidel.
2231
2232         Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
2233
2234         Bug 28420 -  Implement HTML5 <ruby> rendering
2235         (https://bugs.webkit.org/show_bug.cgi?id=28420)
2236
2237         No new tests (no functional change).
2238
2239         * Scripts/build-webkit:
2240
2241 2009-10-29  Dan Bernstein  <mitz@apple.com>
2242
2243         Reviewed by Mark Rowe.
2244
2245         Fix “Undefined subroutine” errors in svn-*apply by moving the removeEOL subroutine
2246         from the two scripts that define it but don’t use it to the script that uses it but doesn’t
2247         define it.
2248
2249         * Scripts/VCSUtils.pm:
2250         * Scripts/svn-apply:
2251         * Scripts/svn-unapply:
2252
2253 2009-10-29  Xan Lopez  <xlopez@igalia.com>
2254
2255         Reviewed by Gustavo Noronha.
2256
2257         Use the GTK+ main loop instead of rolling our own mini-version of
2258         it.
2259
2260         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2261         (dump):
2262         (runTest):
2263         (webViewLoadFinished):
2264
2265 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2266
2267         Reviewed by Oliver Hunt.
2268
2269         Implement the Qt version of DRT dumpBackForwardList().
2270
2271         * DumpRenderTree/qt/DumpRenderTree.cpp:
2272         (WebCore::dumpHistoryItem):
2273         (WebCore::DumpRenderTree::dumpBackForwardList):
2274
2275 2009-10-29  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2276
2277         Reviewed by Adam Roben.
2278
2279         Implement DRT functionality for Qt introduced in
2280         r28690 and r28705.
2281
2282         - Implemented pathToLocalResource which exposes the functionality of
2283         converting a given unix path to the correct location on Windows.
2284         - Implemented a way to remove machine-dependent information from paths
2285         in layout test results.
2286
2287         * DumpRenderTree/qt/DumpRenderTree.cpp:
2288         (WebCore::urlSuitableForTestResult):
2289         (WebCore::WebPage::javaScriptConsoleMessage):
2290         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2291         (LayoutTestController::pathToLocalResource):
2292         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2293
2294 2009-10-28  Roland Steiner  <rolandsteiner@chromium.org>
2295
2296         Adding myself to the committers list.
2297
2298         * Scripts/modules/committers.py:
2299
2300 2009-10-28  Chris Fleizach  <cfleizach@apple.com>
2301
2302         Adding myself to the committers list.
2303
2304         * Scripts/modules/committers.py:
2305
2306 2009-10-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2307
2308         Reviewed by Jan Alonzo.
2309
2310         [GTK] API to start inspector for a WebView
2311         https://bugs.webkit.org/show_bug.cgi?id=22551
2312
2313         Use the new inspector API to implement the LayoutTestController
2314         interfaces used to test the inspector.
2315
2316         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2317         (webInspectorInspectWebView):
2318         (createWebView):
2319         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2320         (LayoutTestController::showWebInspector):
2321         (LayoutTestController::closeWebInspector):
2322         (LayoutTestController::evaluateInWebInspector):
2323
2324 2009-10-28  Shinichiro Hamaji  <hamaji@chromium.org>
2325
2326         Reviewed by Eric Seidel.
2327
2328         [Qt] WebFrame::counterValueForElementById must not be exposed
2329         https://bugs.webkit.org/show_bug.cgi?id=30882
2330
2331         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2332         (LayoutTestController::counterValueForElementById):
2333
2334 2009-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2335
2336         Rubberstamped by Oliver Hunt.
2337
2338         Fix the warning:
2339
2340         "warning: ignoring return value of 'char* getcwd(char*, size_t)',
2341         declared with attribute warn_unused_result".
2342
2343         by actually checking the result. In the case it is null, an
2344         error has occoured, so treat it as the other fatal errors.
2345
2346         * DumpRenderTree/qt/DumpRenderTree.cpp:
2347         (WebCore::DumpRenderTree::initializeFonts):
2348
2349 2009-10-27  Shinichiro Hamaji  <hamaji@chromium.org>
2350
2351         Reviewed by Darin Adler.
2352
2353         Provide a way to get counter values with layoutTestContoller
2354         https://bugs.webkit.org/show_bug.cgi?id=30555
2355
2356         Define layoutTestContoller.counterValueForElementById.
2357
2358         * DumpRenderTree/LayoutTestController.cpp:
2359         (counterValueForElementByIdCallback):
2360         (LayoutTestController::staticFunctions):
2361         * DumpRenderTree/LayoutTestController.h:
2362         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2363         (LayoutTestController::counterValueForElementById):
2364
2365 2009-10-27  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2366
2367         Rubberstamped by Oliver Hunt.
2368
2369         Change two methods to be internal for DRT use only.
2370
2371         Part of [Qt] Review all new API in Qt 4.6
2372         https://bugs.webkit.org/show_bug.cgi?id=29843#c11
2373
2374         * DumpRenderTree/qt/DumpRenderTree.cpp:
2375         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2376         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2377         (LayoutTestController::whiteListAccessFromOrigin):
2378
2379 2009-10-27  Eric Seidel  <eric@webkit.org>
2380
2381         Reviewed by Adam Barth.
2382
2383         REGRESSION: svn-apply exits(1) when applying a patch with a file add
2384         https://bugs.webkit.org/show_bug.cgi?id=30826
2385
2386         * Scripts/svn-apply:
2387          - Add () around all system() calls.
2388          - Use the correct system() == 0 or die instead of system() or die
2389          - Add descriptive messages to all die statements.
2390
2391 2009-10-27  Steve Block  <steveblock@google.com>
2392
2393         Reviewed by NOBODY.
2394
2395         Adds steveblock@google.com to list of committers.
2396
2397         * Scripts/modules/committers.py: Adds steveblock@google.com to list of committers.
2398
2399 2009-10-27  Eric Seidel  <eric@webkit.org>
2400
2401         Reviewed by Adam Barth.
2402
2403         svn-apply can exit(0) even on patch failure
2404         https://bugs.webkit.org/show_bug.cgi?id=29622
2405
2406         * Scripts/svn-apply:
2407          - Add a bunch of "or die" statements, hopefully catching all
2408            possible cases where failure could still exit(0).
2409
2410 2009-10-27  Eric Seidel  <eric@webkit.org>
2411
2412         Reviewed by Adam Barth.
2413
2414         svn-* scripts should share code through VCSUtils.pm
2415         https://bugs.webkit.org/show_bug.cgi?id=30791
2416
2417         Just moving code into a shared location.
2418
2419         * Scripts/VCSUtils.pm:
2420         * Scripts/prepare-ChangeLog:
2421         * Scripts/resolve-ChangeLogs:
2422         * Scripts/svn-apply:
2423         * Scripts/svn-create-patch:
2424         * Scripts/svn-unapply:
2425         * Scripts/update-webkit:
2426
2427 2009-10-27  Vadim Zeitlin  <vadim@wxwidgets.org>
2428
2429         Suppress a huge number of MSVC warnings when building wxWebKit.
2430
2431         * wx/build/settings.py:
2432
2433 2009-10-26  Eric Seidel  <eric@webkit.org>
2434
2435         No review, just adding Mike Belshe to the committers list.
2436
2437         * Scripts/modules/committers.py:
2438
2439 2009-10-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2440
2441         Reviewed by Darin Adler.
2442
2443         Make .rc files compile on Windows without depending on MFC headers
2444         https://bugs.webkit.org/show_bug.cgi?id=30750
2445
2446         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.rc: Use
2447         windows.h instead of afxres.h because it exists even when MFC is not 
2448         installed, and is all that's needed here.
2449
2450         * FindSafari/FindSafari.rc: Ditto
2451
2452 2009-10-24  Eric Seidel  <eric@webkit.org>
2453
2454         Reviewed by Adam Barth.
2455
2456         bugzilla-tool post-diff should know how to mark commit-queue=?
2457         https://bugs.webkit.org/show_bug.cgi?id=29202
2458
2459         * Scripts/bugzilla-tool:
2460          - Add --commit-queue option to post-diff, post-commits and create-bug.
2461         * Scripts/modules/bugzilla.py:
2462          - Added support for --commit-queue to add_patch_to_bug and create_bug_with_patch.
2463          - Added _fill_attachment_form to share code between add_patch_to_bug and create_bug_with_patch.
2464
2465 2009-10-23  Eric Seidel  <eric@webkit.org>
2466
2467         Reviewed by Adam Barth.
2468
2469         bugzilla-tool commit-queue does not notice modifications to committers.py
2470         https://bugs.webkit.org/show_bug.cgi?id=30084
2471
2472         * Scripts/bugzilla-tool:
2473          - Make commit-queue re-exec itself instead of using while(1).
2474          - Add a --is-relaunch parameter to commit-queue to bypass initialization on re-launch.
2475          - Add a _next_patch() method which calls exec() (and could eventually call update-webkit too).
2476
2477 2009-10-22  Eric Seidel  <eric@webkit.org>
2478
2479         Reviewed by Adam Barth.
2480
2481         commit-queue will get stuck on patches if land-patches terminates unexpectedly
2482         https://bugs.webkit.org/show_bug.cgi?id=30634
2483
2484         * Scripts/bugzilla-tool:
2485          - Add a way for land-patches to exit(2) to indicate an error, but one it has handled.
2486          - Make commit-queue auto cq- any patch where land-patches exited anything other than '0' or '2'.
2487
2488 2009-10-26  Yuzo Fujishima  <yuzo@google.com>
2489
2490         Reviewed by Eric Seidel.
2491
2492         Upgrade pywebsocket to 0.4.1. This will make reusing LayoutTests/fast/js/resources easier, for example.
2493
2494         https://bugs.webkit.org/show_bug.cgi?id=30763
2495
2496         * pywebsocket/mod_pywebsocket/__init__.py:
2497         * pywebsocket/mod_pywebsocket/dispatch.py:
2498         * pywebsocket/mod_pywebsocket/headerparserhandler.py:
2499         * pywebsocket/mod_pywebsocket/standalone.py:
2500         * pywebsocket/setup.py:
2501         * pywebsocket/test/test_dispatch.py:
2502
2503 2009-10-26  Carol Szabo  <carol.szabo@nokia.com>
2504
2505         Reviewed by David Levin.
2506
2507         REGRESSION: 2 failures in run-webkit-unittests
2508         https://bugs.webkit.org/show_bug.cgi?id=30645
2509
2510         * Scripts/modules/cpp_style_unittest.py:
2511         Fixed a few test scenarios which apparently lost some spaces from 
2512         text literals.
2513
2514 2009-10-26  Kevin Ollivier  <kevino@theolliviers.com>
2515
2516         wx build fix. Make sure isQt() doesn't return true if --wx was passed to build-webkit.
2517
2518         * Scripts/webkitdirs.pm:
2519
2520 2009-10-26  Csaba Osztrogonác  <ossy@webkit.org>
2521
2522         Reviewed by Darin Adler.
2523
2524         Unification of using null device in perl scripts.
2525         https://bugs.webkit.org/show_bug.cgi?id=30572
2526
2527         * Scripts/VCSUtils.pm:
2528         * Scripts/bisect-builds:
2529         * Scripts/resolve-ChangeLogs:
2530         * Scripts/run-iexploder-tests:
2531         * Scripts/run-jsc:
2532         * Scripts/run-mangleme-tests:
2533         * Scripts/run-webkit-tests:
2534         * Scripts/webkitdirs.pm:
2535         Using File::Spec->devnull() instead of hard coded /dev/null.
2536
2537 2009-10-26  Eric Seidel  <eric@webkit.org>
2538
2539         Reviewed by Holger Freyther.
2540
2541         Reviewers are missing from committers.py
2542         https://bugs.webkit.org/show_bug.cgi?id=30733
2543
2544         * Scripts/modules/committers.py:
2545
2546 2009-10-23  Eric Seidel  <eric@webkit.org>
2547
2548         No review, only adding Alice to the list of reviewers.
2549
2550         * Scripts/modules/committers.py:
2551
2552 2009-10-23  Eric Seidel  <eric@webkit.org>
2553
2554         Reviewed by Eric Carlson.
2555
2556         fast/media/mq-transform-02.html failed on Leopard Commit Bot
2557         https://bugs.webkit.org/show_bug.cgi?id=30700
2558
2559         * DumpRenderTree/mac/DumpRenderTree.mm:
2560         (resetDefaultsToConsistentValues): Update QuickTime version check.
2561
2562 2009-10-23  Kevin Ollivier  <kevino@theolliviers.com>
2563
2564         wxMac 10.4 build fix, needs to link against WebKitSystemInterfaceTiger to get 
2565         character measurement APIs that are private on Tiger.
2566
2567         * wx/build/settings.py:
2568
2569 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2570
2571         Reviewed by NOBODY (build fix).
2572         Build fix following bug #30696.
2573
2574         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2575         (LayoutTestController::evaluateScriptInIsolatedWorld):
2576
2577 2009-10-22  Gavin Barraclough  <barraclough@apple.com>
2578
2579         Reviewed by Sam Weinig & Geoff Garen.
2580
2581         https://bugs.webkit.org/show_bug.cgi?id=30696
2582         Enable isolated-worlds tests on mac.
2583
2584         Add private interface for DRT to invoke execution in a given world.
2585
2586         * DumpRenderTree/LayoutTestController.cpp:
2587         (evaluateScriptInIsolatedWorldCallback):
2588         (LayoutTestController::staticFunctions):
2589         * DumpRenderTree/LayoutTestController.h:
2590         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2591         (LayoutTestController::evaluateScriptInIsolatedWorld):
2592         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2593         (LayoutTestController::evaluateScriptInIsolatedWorld):
2594
2595 2009-10-21  Eric Seidel  <eric@webkit.org>
2596
2597         Reviewed by Adam Barth.
2598
2599         bugzilla-tool's "patch failed to download an apply" error should give more information
2600         https://bugs.webkit.org/show_bug.cgi?id=30632
2601
2602         * Scripts/modules/scm.py:
2603          - Use the common run_command method instead of custom POpen code.
2604          - Make run_command know how to take pipes as input.
2605         * Scripts/modules/scm_unittest.py:
2606          - Add new tests to cover change.
2607          - Also move test_error_handlers into new SCMClassTests so we don't run it 3 times.
2608
2609 2009-10-21  Kent Tamura  <tkent@chromium.org>
2610
2611         Unreviewed.  Adding myself to the committers list.
2612
2613         * Scripts/modules/committers.py:
2614
2615 2009-10-21  Robin Dunn  <robin@alldunn.com>
2616
2617         Reviewed by Kevin Ollivier.
2618
2619         Update the Windows installer builder to work with Vista / Win 7 and with git.
2620         
2621         https://bugs.webkit.org/show_bug.cgi?id=30649
2622
2623         * wx/build/build_utils.py:
2624         * wx/packaging/build-mac-installer.py:
2625         * wx/packaging/build-win-installer.py:
2626         * wx/packaging/wxWebKitInstaller.iss.in:
2627
2628 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2629
2630         Reviewed by Gustavo Noronha.
2631
2632         [GTK] Added conditional code to avoid using
2633         gdk_window_get_root_coords if we do not have a gtk+ release newer
2634         than 2.17.3.
2635         https://bugs.webkit.org/show_bug.cgi?id=30636
2636
2637         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2638
2639 2009-10-21  Shu Chang  <Chang.Shu@nokia.com>
2640
2641         Reviewed by Eric Seidel.
2642
2643         [Qt] Added dummy implementation for keepWebHistory()
2644         https://bugs.webkit.org/show_bug.cgi?id=30592
2645
2646         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2647         (LayoutTestController::keepWebHistory):
2648         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2649
2650 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2651
2652         Reviewed by Xan Lopez.
2653
2654         [GTK] Fixed the double click condition, it is not double click if
2655         we move in just in one direction.
2656         https://bugs.webkit.org/show_bug.cgi?id=30636
2657
2658         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2659
2660 2009-10-21  Alejandro G. Castro  <alex@igalia.com>
2661
2662         Reviewed by Xan Lopez.
2663
2664         [GTK] Initialize the events completly before emitting them.
2665         https://bugs.webkit.org/show_bug.cgi?id=30633
2666
2667         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
2668
2669 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2670
2671         wx build fix. Fix for when linking using --as-needed with gcc.
2672
2673         * wx/browser/wscript:
2674
2675 2009-10-21  Kevin Ollivier  <kevino@theolliviers.com>
2676
2677         wxMac 10.4 build fix. Build and link against a version of libcurl new enough
2678         to support all the features used by CURL backend.
2679         
2680         * wx/build/settings.py:
2681         * wx/install-unix-extras:
2682
2683 2009-10-20  Anton Muhin  <antonm@chromium.org>
2684
2685         Reviewed by Adam Barth.
2686
2687         Add {ager,antonm,yurys}@chromium.org into committers.py
2688         https://bugs.webkit.org/show_bug.cgi?id=30560
2689
2690         * Scripts/modules/committers.py:
2691
2692 2009-10-20  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2693
2694         Reviewed by Tor Arne Vestbø.
2695
2696         Make the Netscape Test plugin available to the Qt launcher.
2697
2698         * Scripts/run-launcher:
2699
2700 2009-10-20  Fumitoshi Ukai  <ukai@chromium.org>
2701
2702         Reviewed by David Levin.
2703
2704         Removed WebSocket runtime settings.
2705         https://bugs.webkit.org/show_bug.cgi?id=29896
2706
2707         WebSocket runtime configuration is supported by chromium/v8 only.
2708
2709         * DumpRenderTree/mac/DumpRenderTree.mm:
2710         (resetDefaultsToConsistentValues):
2711         * DumpRenderTree/win/DumpRenderTree.cpp:
2712         (resetDefaultsToConsistentValues):
2713
2714 2009-10-19  Nate Chapin  <japhet@chromium.org>
2715
2716         Reviewed by Adam Barth.
2717
2718         Add testFail() to test plugin so we can test our handling of a
2719         plugin invoke call returning false.
2720
2721         https://bugs.webkit.org/show_bug.cgi?id=30239
2722
2723         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Add testFail().
2724         (pluginInvoke):
2725         (testIdentifierToString): Always return true, since returning false will now cause an exception to be thrown.
2726
2727 2009-10-19  Zan Dobersek  <zandobersek@gmail.com>
2728
2729         Reviewed by Gustavo Noronha.
2730
2731         Enable DOM pasting when running layout tests.
2732
2733         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2734         (resetDefaultsToConsistentValues):
2735
2736 2009-10-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2737
2738         Reviewed by Simon Hausmann.
2739
2740         Use the setPreferredContentsSize method instead
2741         of setFixedContentsSize, as the method has been renamed.
2742
2743         * DumpRenderTree/qt/DumpRenderTree.cpp:
2744         (WebCore::DumpRenderTree::open):
2745         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2746         (LayoutTestController::setFixedContentsSize):
2747
2748 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2749
2750         Reviewed by Dan Bernstein.
2751
2752         https://bugs.webkit.org/show_bug.cgi?id=30456
2753         Fixes for new Debug_All Windows build configuration.
2754
2755         * DumpRenderTree/win/DumpRenderTree.cpp:
2756         (sharedCFURLCache): Use new DEBUG_ALL preprocessor define for library naming.
2757         * DumpRenderTree/win/DumpRenderTree.vcproj: Remove unused DEBUG_WEBKIT_HAS_SUFFIX.
2758
2759 2009-10-16  Eric Seidel  <eric@webkit.org>
2760
2761         Reviewed by Adam Barth.
2762
2763         commit-queue status bot should list which buildbot is blocking the queue
2764         https://bugs.webkit.org/show_bug.cgi?id=30452
2765
2766         Add new methods and testing.
2767
2768         * Scripts/bugzilla-tool:
2769         * Scripts/modules/buildbot.py:
2770         * Scripts/modules/buildbot_unittest.py:
2771
2772 2009-10-16  Eric Seidel  <eric@webkit.org>
2773
2774         Reviewed by Adam Barth.
2775
2776         run-webkit-tests fails when CWD is not inside a WebKit checkout
2777         https://bugs.webkit.org/show_bug.cgi?id=30451
2778
2779         * Scripts/modules/scm.py: in_working_directory shouldn't throw exceptions on failure.
2780         * Scripts/modules/scm_unittest.py:
2781           - Remove use of original_path (we don't need to restore the CWD).
2782           - Don't use '.' to find the webkit checkout, use __file__ instead.
2783
2784 2009-10-16  Steve Falkenburg  <sfalken@apple.com>
2785
2786         Reviewed by Adam Roben.
2787
2788         Add a Debug_All configuration to build entire stack as debug.
2789         Change Debug_Internal to:
2790         - stop using _debug suffix for all WebKit/Safari binaries
2791         - not use _debug as a DLL naming suffix
2792         - use non-debug C runtime lib.
2793
2794         * DumpRenderTree/DumpRenderTree.sln: Add Debug_All configuration.
2795         * DumpRenderTree/win/DumpRenderTree.vcproj: Add Debug_All configuration.
2796         * DumpRenderTree/win/ImageDiff.vcproj: Add Debug_All configuration.
2797         * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj:
2798         Add missing debug.vsprops inherited property sheet.
2799         Add Debug_All configuration.
2800         * FindSafari/FindSafari.vcproj: Renamed single configuration from "Release" to "all".
2801         * WinLauncher/WinLauncher.vcproj:
2802         Removed extraneous definitions inherited from vsprops.
2803         Add Debug_All configuration.
2804
2805 2009-10-16  Carol Szabo  <carol.szabo@nokia.com>
2806
2807         Reviewed by David Levin.
2808
2809         check-webkit-style is wrong about indent checking in namespaces
2810         in header files and a few other things
2811         https://bugs.webkit.org/show_bug.cgi?id=30362
2812
2813         The few other things include:
2814         + check-webkit-style does not require spaces around the equal sign
2815           inside 'if' statements and around binary operators that take 
2816           numeric literals.
2817         + check-webkit-style reports false errors for the / operator
2818           when part of a filename in the #include directive.
2819
2820         * Scripts/modules/cpp_style.py:
2821         Improved indentation checking and space checking around
2822         binary operators. While the checks are still not perfect,
2823         they are clearly better than before.
2824         * Scripts/modules/cpp_style_unittest.py:
2825         Added test cases for the newly supported checks and modified old
2826         test cases to match the new guidelines
2827
2828 2009-10-16  Kevin Ollivier  <kevino@theolliviers.com>
2829
2830         wxMSW build fix. Link to MSW library needed by PluginPackageWin.cpp.
2831
2832         * wx/build/settings.py:
2833
2834 2009-10-15  Yuzo Fujishima  <yuzo@google.com>
2835
2836         Reviewed by David Levin.
2837
2838         Add mod_pywebsocket to test Web Sockets.
2839         http://code.google.com/p/pywebsocket/
2840         https://bugs.webkit.org/show_bug.cgi?id=27490
2841
2842         * pywebsocket/COPYING: Added.
2843         * pywebsocket/MANIFEST.in: Added.
2844         * pywebsocket/README: Added.
2845         * pywebsocket/example/echo_client.py: Added.
2846         * pywebsocket/example/echo_wsh.py: Added.
2847         * pywebsocket/mod_pywebsocket/__init__.py: Added.
2848         * pywebsocket/mod_pywebsocket/dispatch.py: Added.
2849         * pywebsocket/mod_pywebsocket/handshake.py: Added.
2850         * pywebsocket/mod_pywebsocket/headerparserhandler.py: Added.
2851         * pywebsocket/mod_pywebsocket/msgutil.py: Added.
2852         * pywebsocket/mod_pywebsocket/standalone.py: Added.
2853         * pywebsocket/mod_pywebsocket/util.py: Added.
2854         * pywebsocket/setup.py: Added.
2855         * pywebsocket/test/config.py: Added.
2856         * pywebsocket/test/mock.py: Added.
2857         * pywebsocket/test/run_all.py: Added.
2858         * pywebsocket/test/test_dispatch.py: Added.
2859         * pywebsocket/test/test_handshake.py: Added.
2860         * pywebsocket/test/test_mock.py: Added.
2861         * pywebsocket/test/test_msgutil.py: Added.
2862         * pywebsocket/test/test_util.py: Added.
2863         * pywebsocket/test/testdata/handlers/blank_wsh.py: Added.
2864         * pywebsocket/test/testdata/handlers/origin_check_wsh.py: Added.
2865         * pywebsocket/test/testdata/handlers/sub/exception_in_transfer_wsh.py: Added.
2866         * pywebsocket/test/testdata/handlers/sub/no_wsh_at_the_end.py: Added.
2867         * pywebsocket/test/testdata/handlers/sub/non_callable_wsh.py: Added.
2868         * pywebsocket/test/testdata/handlers/sub/plain_wsh.py: Added.
2869         * pywebsocket/test/testdata/handlers/sub/wrong_handshake_sig_wsh.py: Added.
2870         * pywebsocket/test/testdata/handlers/sub/wrong_transfer_sig_wsh.py: Added.
2871
2872 2009-10-15  James Robinson  <jamesr@google.com>
2873
2874         Reviewed by David Levin.
2875
2876         Updates check-webkit-style to reflect that code inside a namespace should not be indented, even in a header file.
2877
2878         https://bugs.webkit.org/show_bug.cgi?id=30426
2879
2880         * Scripts/modules/cpp_style.py:
2881         * Scripts/modules/cpp_style_unittest.py:
2882
2883 2009-10-15  Brian Weinstein  <bweinstein@apple.com>
2884
2885         Reviewed by Adam Roben.
2886
2887         Fixes <http://webkit.org/b/30411>.
2888         REGRESSION(49485): pdevenv doesn't compile in parallel for non-chromium builds on Windows.
2889         
2890         Added a check for isChromium() in pdevenv, and pass /useenv if we are not
2891         building Chromium.
2892
2893         * Scripts/pdevenv:
2894
2895 2009-10-15  Robin Dunn  <robin@alldunn.com>
2896
2897         Reviewed by Kevin Ollivier.
2898
2899         Add Mac package building scripts for wx.
2900         
2901         https://bugs.webkit.org/show_bug.cgi?id=30405
2902
2903         * wx/build/build_utils.py:
2904         * wx/build/settings.py:
2905         * wx/packaging/build-mac-installer.py: Added.
2906
2907 2009-10-15  Zan Dobersek  <zandobersek@gmail.com>
2908
2909         Reviewed by Gustavo Noronha.
2910
2911         Enable Web Sockets support when running layout tests.
2912
2913         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2914         (resetDefaultsToConsistentValues):
2915
2916 2009-10-15  Xan Lopez  <xlopez@igalia.com>
2917
2918         Reviewed by Gustavo Noronha.
2919
2920         Need to initialize event.button.button, since in most cases a
2921         button number is not passed as an argument.
2922
2923         * DumpRenderTree/gtk/EventSender.cpp:
2924         (mouseDownCallback):
2925         (mouseUpCallback):
2926
2927 2009-10-15  Kevin Ollivier  <kevino@theolliviers.com>
2928
2929         wx build fix. More SDK fixes for Mac, make sure we use the SDK corresponding to
2930         the OS if none was explicitly set.
2931
2932         * wx/build/settings.py:
2933
2934 2009-10-14  Pavel Feldman  <pfeldman@chromium.org>
2935
2936         Reviewed by Timothy Hatcher.
2937
2938         Web Inspector: enable developers extras within inspector layout tests.
2939
2940         https://bugs.webkit.org/show_bug.cgi?id=30014
2941
2942         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2943         (LayoutTestController::showWebInspector):
2944         (LayoutTestController::closeWebInspector):
2945         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2946         (LayoutTestController::showWebInspector):
2947         (LayoutTestController::closeWebInspector):
2948
2949 2009-10-14  José Millán Soto  <jmillan@igalia.com>
2950
2951         Reviewed by Jan Alonzo.
2952
2953         GtkLauncher is using a deprecated signal
2954         https://bugs.webkit.org/show_bug.cgi?id=30364
2955
2956         Modified GtkLauncher to use notify::title signal instead of
2957         deprecated title-changed signal
2958
2959         * GtkLauncher/main.c:
2960         (notify_title_cb):
2961         (create_browser):
2962
2963 2009-10-14  Brady Eidson  <beidson@apple.com>
2964
2965         Reviewed by Sam Weinig.
2966
2967         Don't set the history delegate on new windows that are opened during a test, as the history delegate:
2968         1 - Disables WebHistory
2969         2 - Doesn't make sense in that context anyway.
2970
2971         * DumpRenderTree/win/DumpRenderTree.cpp:
2972         (createWebViewAndOffscreenWindow):
2973
2974 2009-10-14  Kevin Ollivier  <kevino@theolliviers.com>
2975
2976         wxMac build fix. Ensure 10.4 compatibility for deps, and allow the user to specify
2977         the SDK to use since Python overrides any user-set value of MACOSX_DEPLOYMENT_TARGET.
2978
2979         * wx/build/settings.py:
2980         * wx/install-unix-extras:
2981
2982 2009-10-14  Brady Eidson  <beidson@apple.com>
2983
2984         Reviewed by Sam Weinig.
2985
2986         WebKit Win API should provide a delegate interface for global history.
2987         https://bugs.webkit.org/show_bug.cgi?id=29905
2988
2989         * DumpRenderTree/LayoutTestController.cpp:
2990         (LayoutTestController::LayoutTestController):
2991         * DumpRenderTree/LayoutTestController.h:
2992         (LayoutTestController::dumpHistoryDelegateCallbacks):
2993         (LayoutTestController::setDumpHistoryDelegateCallbacks):
2994                 
2995         * DumpRenderTree/win/DumpRenderTree.cpp:
2996         (shouldLogHistoryDelegates):
2997         (runTest):
2998         (createWebViewAndOffscreenWindow):
2999         (main):
3000         * DumpRenderTree/win/DumpRenderTree.vcproj:
3001         
3002         Add the IWebHistoryDelegate to DRT Windows:
3003         * DumpRenderTree/win/HistoryDelegate.cpp: Added.
3004         (wstringFromBSTR):
3005         (HistoryDelegate::HistoryDelegate):
3006         (HistoryDelegate::~HistoryDelegate):
3007         (HistoryDelegate::QueryInterface):
3008         (HistoryDelegate::AddRef):
3009         (HistoryDelegate::Release):
3010         (HistoryDelegate::didNavigateWithNavigationData):
3011         (HistoryDelegate::didPerformClientRedirectFromURL):
3012         (HistoryDelegate::didPerformServerRedirectFromURL):
3013         (HistoryDelegate::updateHistoryTitle):
3014         (HistoryDelegate::populateVisitedLinksForWebView):
3015         * DumpRenderTree/win/HistoryDelegate.h: Added.
3016
3017         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3018         (LayoutTestController::removeAllVisitedLinks):
3019
3020 2009-10-14  Shu Chang  <Chang.Shu@nokia.com>
3021
3022         Reviewed by Simon Hausmann.
3023
3024         [Qt] Implement support for setPOSIXLocale on Qt.
3025         https://bugs.webkit.org/show_bug.cgi?id=30268 
3026  
3027         * DumpRenderTree/qt/DumpRenderTree.cpp:
3028         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3029         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3030         (LayoutTestController::setPOSIXLocale):
3031         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3032
3033 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3034
3035         Unreviewed, adding myself to reviewers list.
3036
3037         * Scripts/modules/committers.py:
3038
3039 2009-10-13  Stephanie Lewis  <slewis@apple.com>
3040
3041         Reviewed by Mark Rowe.
3042
3043         Fix null assignment so root tests work again.
3044
3045         * Scripts/webkitdirs.pm:
3046
3047 2009-10-13  Andras Becsi  <becsi.andras@stud.u-szeged.hu>
3048
3049         Reviewed by Simon Hausmann.
3050
3051         [Qt] Refactor LayoutTestController, EventSender, TextInputController and WorkQueueItem classes
3052         out of jsobjects into separate files to get a more structured DumpRenderTree implementation.
3053         This is done in preparation of implementing missing features in DRT.
3054         No functionality changes made yet.
3055
3056         * DumpRenderTree/qt/DumpRenderTree.cpp:
3057         * DumpRenderTree/qt/DumpRenderTree.pro:
3058         * DumpRenderTree/qt/EventSenderQt.cpp: Added.
3059         (EventSender::EventSender):
3060         (EventSender::mouseDown):
3061         (EventSender::mouseUp):
3062         (EventSender::mouseMoveTo):
3063         (EventSender::leapForward):
3064         (EventSender::keyDown):
3065         (EventSender::contextClick):
3066         (EventSender::scheduleAsynchronousClick):
3067         (EventSender::frameUnderMouse):
3068         * DumpRenderTree/qt/EventSenderQt.h: Added.
3069         (EventSender::clearKillRing):
3070         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added.
3071         (LayoutTestController::LayoutTestController):
3072         (LayoutTestController::reset):
3073         (LayoutTestController::processWork):
3074         (LayoutTestController::maybeDump):
3075         (LayoutTestController::waitUntilDone):
3076         (LayoutTestController::notifyDone):
3077         (LayoutTestController::windowCount):
3078         (LayoutTestController::clearBackForwardList):
3079         (LayoutTestController::dumpEditingCallbacks):
3080         (LayoutTestController::dumpResourceLoadCallbacks):
3081         (LayoutTestController::queueBackNavigation):
3082         (LayoutTestController::queueForwardNavigation):
3083         (LayoutTestController::queueLoad):
3084         (LayoutTestController::queueReload):
3085         (LayoutTestController::queueScript):
3086         (LayoutTestController::provisionalLoad):
3087         (LayoutTestController::timerEvent):
3088         (LayoutTestController::encodeHostName):
3089         (LayoutTestController::decodeHostName):
3090         (LayoutTestController::setJavaScriptProfilingEnabled):
3091         (LayoutTestController::setFixedContentsSize):
3092         (LayoutTestController::setPrivateBrowsingEnabled):
3093         (LayoutTestController::setPopupBlockingEnabled):
3094         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3095         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3096         (LayoutTestController::numberOfActiveAnimations):
3097         (LayoutTestController::disableImageLoading):
3098         (LayoutTestController::dispatchPendingLoadRequests):
3099         (LayoutTestController::setDatabaseQuota):
3100         (LayoutTestController::clearAllDatabases):
3101         (LayoutTestController::whiteListAccessFromOrigin):
3102         (LayoutTestController::waitForPolicyDelegate):
3103         (LayoutTestController::overridePreference):
3104         * DumpRenderTree/qt/LayoutTestControllerQt.h: Added.
3105         (LayoutTestController::isLoading):
3106         (LayoutTestController::setLoading):
3107         (LayoutTestController::shouldDumpAsText):
3108         (LayoutTestController::shouldDumpBackForwardList):
3109         (LayoutTestController::shouldDumpChildrenAsText):
3110         (LayoutTestController::shouldDumpDatabaseCallbacks):
3111         (LayoutTestController::shouldDumpStatusCallbacks):
3112         (LayoutTestController::shouldWaitUntilDone):
3113         (LayoutTestController::canOpenWindows):
3114         (LayoutTestController::shouldDumpTitleChanges):
3115         (LayoutTestController::waitForPolicy):
3116         (LayoutTestController::dumpAsText):
3117         (LayoutTestController::dumpChildFramesAsText):
3118         (LayoutTestController::dumpDatabaseCallbacks):
3119         (LayoutTestController::dumpStatusCallbacks):
3120         (LayoutTestController::setCanOpenWindows):
3121         (LayoutTestController::dumpBackForwardList):
3122         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
3123         (LayoutTestController::display):
3124         (LayoutTestController::dumpTitleChanges):
3125         (LayoutTestController::dumpSelectionRect):
3126         * DumpRenderTree/qt/TextInputControllerQt.cpp: Added.
3127         (TextInputController::TextInputController):
3128         (TextInputController::doCommand):
3129         * DumpRenderTree/qt/TextInputControllerQt.h: Added.
3130         * DumpRenderTree/qt/WorkQueue.cpp:
3131         * DumpRenderTree/qt/WorkQueue.h:
3132         * DumpRenderTree/qt/WorkQueueItem.h:
3133         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Added.
3134         (findFrameNamed):
3135         (LoadItem::invoke):
3136         (ReloadItem::invoke):
3137         (ScriptItem::invoke):
3138         (BackForwardItem::invoke):
3139         * DumpRenderTree/qt/jsobjects.cpp: Move all the above classes into separate files
3140         * DumpRenderTree/qt/jsobjects.h:
3141
3142 2009-10-13  Dmitry Titov  <dimich@chromium.org>
3143
3144         Not reviewed, adding myself to the list of reviewers.
3145
3146         * Scripts/modules/committers.py:
3147
3148 2009-10-13  Anders Carlsson  <andersca@apple.com>
3149
3150         Reviewed by Sam Weinig.
3151
3152         <rdar://problem/6660507> Add "privacy mode" to Netscape Plug-in API
3153
3154         Make the private browsing mode testable by the test plug-in.
3155         
3156         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
3157         (pluginGetProperty):
3158         * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
3159         * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
3160         (NPP_New):
3161         (NPP_SetValue):
3162
3163 2009-10-13  Pavel Feldman  <pfeldman@chromium.org>
3164
3165         No review, just adding self to the list of reviewers.
3166
3167         * Scripts/modules/committers.py:
3168
3169 2009-10-12  Pavel Feldman  <pfeldman@chromium.org>
3170
3171         Reviewed by Adam Roben.
3172
3173         Web Inspector: Use proper web view in inspector layout
3174         tests for windows.
3175
3176         https://bugs.webkit.org/show_bug.cgi?id=30298
3177
3178         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3179         (LayoutTestController::showWebInspector):
3180         (LayoutTestController::closeWebInspector):
3181         (LayoutTestController::evaluateInWebInspector):
3182
3183 2009-10-12  Fumitoshi Ukai  <ukai@chromium.org>
3184
3185         Reviewed by Sam Weinig.
3186
3187         Enable experimentalWebSocket in DumpRenderTree for LayoutTest.
3188         https://bugs.webkit.org/show_bug.cgi?id=29841
3189
3190         * DumpRenderTree/mac/DumpRenderTree.mm:
3191         (resetDefaultsToConsistentValues):
3192         * DumpRenderTree/win/DumpRenderTree.cpp:
3193         (resetDefaultsToConsistentValues):
3194
3195 2009-10-12  Yaar Schnitman  <yaar@chromium.org>
3196
3197         Reviewed by Dimitri Glazkov.
3198
3199         Chromium Port - Windows
3200         https://bugs.webkit.org/show_bug.cgi?id=29969
3201
3202         * Scripts/pdevenv: removed msvc's /useenv for chromium builds
3203         * Scripts/webkitdirs.pm:
3204
3205 2009-10-12  Csaba Osztrogonac  <ossy@webkit.org>
3206
3207         Reviewed by Darin Adler.
3208
3209         jsc scripts cleanup and Qt/GTK fix
3210         https://bugs.webkit.org/show_bug.cgi?id=30288
3211
3212         Duplicated jscPath() moved to webkitdirs.pm.
3213         New jscProductDir() added to webkitdirs.pm instead of duplicated codes.
3214         Configuration added (release/debug) to path for Qt-port on Windows.
3215
3216         * Scripts/run-javascriptcore-tests:
3217         * Scripts/run-jsc:
3218         * Scripts/run-sunspider:
3219         * Scripts/sunspider-compare-results:
3220         * Scripts/webkitdirs.pm:
3221
3222 2009-10-11  Adam Barth  <abarth@webkit.org>
3223
3224         Unreviewed.  Add Collin to committers.py.
3225
3226         * Scripts/modules/committers.py:
3227
3228 2009-10-11  Kevin Ollivier  <kevino@theolliviers.com>
3229
3230         wx build fix, add bindings to source/include dirs now that there are sources there.
3231
3232         * wx/build/settings.py:
3233
3234 2009-10-09  Mark Rowe  <mrowe@apple.com>
3235
3236         Reviewed by Brady Eidson.
3237
3238         Enable plug-in halting in DumpRenderTree.
3239
3240         We drop the plug-in halting delay to 1 second and opt in the delegate method to never halt plug-ins.
3241         This is sufficient to ensure that the crash covered by <rdar://problem/7290671> no longer occurs.
3242
3243         * DumpRenderTree/mac/DumpRenderTree.mm:
3244         (resetDefaultsToConsistentValues):
3245         * DumpRenderTree/mac/UIDelegate.mm:
3246         (-[UIDelegate webView:shouldHaltPlugin:]):
3247
3248 2009-10-08  Brady Eidson  <beidson@apple.com>
3249
3250         Reviewed by Dan Bernstein.
3251
3252         Ask the History Delegate to populate the visited links hash.
3253         <rdar://problem/7285293> and https://webkit.org/b/29904
3254
3255         Add the ability for LayoutTestController to clear all visited links.
3256         Also lets the History Delegate dump visited links, but only if this test specifically cleared them.
3257
3258         * DumpRenderTree/LayoutTestController.cpp:
3259         (LayoutTestController::LayoutTestController):
3260         (removeAllVisitedLinksCallback):
3261         (LayoutTestController::staticFunctions):
3262         * DumpRenderTree/LayoutTestController.h:
3263         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3264         (LayoutTestController::removeAllVisitedLinks):
3265
3266         * DumpRenderTree/mac/HistoryDelegate.mm:
3267         (-[HistoryDelegate populateVisitedLinksForWebView:]):
3268
3269         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3270         (LayoutTestController::removeAllVisitedLinks):
3271         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3272         (LayoutTestController::removeAllVisitedLinks):
3273         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3274         (LayoutTestController::removeAllVisitedLinks):
3275
3276
3277 2009-10-08  Daniel Bates  <dbates@webkit.org>
3278
3279         Reviewed by Adam Roben.
3280
3281         https://bugs.webkit.org/show_bug.cgi?id=30175
3282         
3283         The Windows DRT equivalent of DoDragDrop (i.e. UIDelegate::doDragDrop) does not return
3284         the OLE drag-and-drop return value like the function it emulates. Currently, 
3285         UIDelegate::doDragDrop returns a hard-coded S_OK. Hence, the caller cannot determine 
3286         whether the drag-and-drop operation was successful or was cancelled.
3287         
3288         This patch fixes this issue by having UIDelegate::doDragDrop return the OLE drag-and-drop 
3289         return value according to whether the drop operation was successful or not.
3290
3291         * DumpRenderTree/win/EventSender.cpp:
3292         (doMouseUp): Added parameter oleDragAndDropReturnValue.
3293         (replaySavedEvents): Ditto.
3294         * DumpRenderTree/win/EventSender.h:
3295         * DumpRenderTree/win/UIDelegate.cpp:
3296         (UIDelegate::doDragDrop): Modified to return OLE drag-and-drop return value.
3297
3298 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3299
3300         Reviewed by Xan Lopez.
3301
3302         [GTK] Added support for a parameter setting the button that was
3303         pressed in the mouseDown function.
3304         https://bugs.webkit.org/show_bug.cgi?id=30220
3305
3306         * WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
3307
3308 2009-10-08  Alejandro G. Castro  <alex@igalia.com>
3309
3310         Reviewed by Xan Lopez.
3311
3312         [GTK] Added a line to the bottom of the expected result to match
3313         the output of the test.
3314         https://bugs.webkit.org/show_bug.cgi?id=30220
3315
3316         * LayoutTests/platform/gtk/editing/pasteboard/middle-click-onpaste-
3317         expected.txt:
3318
3319 2009-10-08  Adam Roben  <aroben@apple.com>
3320
3321         Use QueryInterface to get IWebInspectorPrivate
3322
3323         Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
3324         accessed in a more standard way
3325
3326         Reviewed by John Sullivan and Tim Hatcher.
3327
3328         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3329         (LayoutTestController::evaluateInWebInspector): Get the IWebInspector
3330         by calling IWebViewPrivate::inspector, then use QueryInterface to get
3331         to the IWebInspectorPrivate interface.
3332
3333 2009-10-07  Adam Roben  <aroben@apple.com>
3334
3335         Implement DRT support for origin whitelisting
3336
3337         Fixes <http://webkit.org/b/30185>.
3338
3339         Reviewed by Eric Seidel.
3340
3341         * DumpRenderTree/win/DumpRenderTree.cpp:
3342         (resetWebViewToConsistentStateBeforeTesting): Reset any origin
3343         whitelist, to match Mac DRT.
3344         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3345         (LayoutTestController::whiteListAccessFromOrigin): Call through to
3346         IWebViewPrivate::whiteListAccessFromOrigin.
3347
3348 2009-10-07  Brady Eidson  <beidson@apple.com>
3349
3350         Reviewed by Darin Adler.
3351
3352         Send title changes to the global history delegate.
3353         <rdar://problem/7285293> and https://webkit.org/b/29904
3354
3355         * DumpRenderTree/mac/HistoryDelegate.mm:
3356         (-[HistoryDelegate webView:updateHistoryTitle:forURL:]):
3357
3358 2009-10-07  Adam Barth  <abarth@webkit.org>
3359
3360         Unreviewed.  Remove some folks from committers.py who were listed on
3361         the WebKit Team wiki page but who weren't actually listed as commit+.
3362         At some point, we should coorelate this list with the committers
3363         mailing list.
3364
3365         * Scripts/modules/committers.py:
3366
3367 2009-10-07  Adam Barth  <abarth@webkit.org>
3368
3369         Unreviewed.  Import a bunch of committers from the WebKit Team page on
3370         the wiki into committers.py.
3371
3372         * Scripts/modules/committers.py:
3373
3374 2009-10-07  Adam Barth  <abarth@webkit.org>
3375
3376         Unreviewed.  Added Aaron Boodman to committers.py.
3377
3378         * Scripts/modules/committers.py:
3379
3380 2009-10-07  Evan Martin  <evan@chromium.org>
3381
3382         Reviewed by Darin Adler.
3383
3384         Add API to LayoutTestController for re/setting the system locale.
3385         https://bugs.webkit.org/show_bug.cgi?id=18994
3386
3387         * DumpRenderTree/LayoutTestController.cpp:
3388         (setLocaleCallback):
3389         (LayoutTestController::staticFunctions):
3390         (LayoutTestController::setLocale):
3391         * DumpRenderTree/LayoutTestController.h:
3392
3393 2009-10-06  Shinichiro Hamaji  <hamaji@chromium.org>
3394
3395         Reviewed by Jan Alonzo.
3396
3397         [Layout tests] [Gtk] Gtk DumpRenderTree should use WebKit test fonts
3398         https://bugs.webkit.org/show_bug.cgi?id=29689
3399
3400         Build fix by adding -lfontconfig for DumpRenderTree.
3401
3402         * GNUmakefile.am:
3403
3404 2009-10-07  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>
3405
3406         Reviewed by Simon Hausmann.
3407
3408         Re-enable use-remote-links-to-tests for Qt. Disabled in r46416.
3409
3410         * Scripts/run-webkit-tests:
3411
3412 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3413
3414         Reviewed by Gustavo Noronha.
3415
3416         "delete" in EventSender is the backspace key, not the delete one.
3417
3418         * DumpRenderTree/gtk/EventSender.cpp:
3419         (keyDownCallback):
3420
3421 2009-10-07  Xan Lopez  <xlopez@igalia.com>
3422
3423         Reviewed by Gustavo Noronha.
3424
3425         getChildrenWithRange expects as last parameter the end index, not
3426         the length of the range. Correct this and clarify the variable
3427         names to reflect how the code works.
3428
3429         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3430         (AccessibilityUIElement::getChildrenWithRange):
3431         (AccessibilityUIElement::getChildAtIndex):
3432
3433 2009-10-06  Mark Rowe  <mrowe@apple.com>
3434
3435         Reviewed by Simon Fraser.
3436
3437         <http://webkit.org/b/30138> update-webkit-localizable-strings assumes that WebKitTools/Scripts is in the PATH
3438
3439         * Scripts/update-webkit-localizable-strings: Use an explicit path to extract-localizable-strings based on the
3440         the fact we have already changed the working directory to the top of the open source tree.
3441
3442 2009-10-06  Julie Parent  <jparent@chromium.org>
3443
3444         Unreviewed. Fixing the entry for myself in committers.py to use my bugzilla email,
3445         rather than my committer email.
3446
3447         * Scripts/modules/committers.py:
3448
3449 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3450
3451         Reviewed by Eric Seidel.
3452
3453         [Qt] LayoutTestController: Reset m_dumpStatusCallbacks to false in reset().
3454
3455         r49189 added support for the 'dumpStatusCallbacks' setting but didn't reset
3456         it after each layout test as it should do, making the DRT dump additional output
3457         for all of the subsequent layout tests.
3458
3459         * DumpRenderTree/qt/jsobjects.cpp:
3460         (LayoutTestController::reset):
3461
3462 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3463
3464         Reviewed by Simon Hausmann.
3465
3466         [Qt] Implement layoutTestController.dumpStatusCallbacks() and unskip the
3467         fast/dom/assign-to-window-status.html test, which is passing as a result.
3468
3469         https://bugs.webkit.org/show_bug.cgi?id=30127
3470
3471         * DumpRenderTree/qt/DumpRenderTree.cpp:
3472         (WebCore::DumpRenderTree::DumpRenderTree):
3473         (WebCore::DumpRenderTree::statusBarMessage):
3474         * DumpRenderTree/qt/DumpRenderTree.h:
3475         * DumpRenderTree/qt/jsobjects.h:
3476         (LayoutTestController::shouldDumpStatusCallbacks):
3477         (LayoutTestController::dumpStatusCallbacks):
3478
3479 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3480
3481         Reviewed by Simon Hausmann.
3482
3483         [Qt] The implementation of EventSender::mouseUp() and EventSender::mouseDown()
3484         ignores the argument indicating which mouse button to trigger.
3485         https://bugs.webkit.org/show_bug.cgi?id=30048
3486
3487         This affects the fast/events/mouse-click-events.html layout test.
3488
3489         * DumpRenderTree/qt/jsobjects.cpp:
3490         (EventSender::mouseDown):
3491         (EventSender::mouseUp):
3492         * DumpRenderTree/qt/jsobjects.h:
3493
3494 2009-10-06  Jakub Wieczorek  <faw217@gmail.com>
3495
3496         Reviewed by Simon Hausmann.
3497
3498         [Qt] Fix the EventSender::keyDown() implementation
3499         https://bugs.webkit.org/show_bug.cgi?id=30043
3500
3501         It should post both a key press event and a key release event,
3502         just like other ports do.
3503
3504         * DumpRenderTree/qt/jsobjects.cpp:
3505         (EventSender::keyDown):
3506
3507 2009-10-05  Kevin Ollivier  <kevino@theolliviers.com>
3508
3509         wx build fix. Add jpeg to the list of libs to link against.
3510
3511         * wx/build/settings.py:
3512
3513 2009-10-05  Jakub Wieczorek  <faw217@gmail.com>
3514
3515         Reviewed by Simon Hausmann.
3516
3517         [Qt] EventSender::keyDown() cannot send function-key events.
3518         https://bugs.webkit.org/show_bug.cgi?id=30044
3519
3520         This affects the fast/events/keydown-function-keys.html layout test.
3521
3522         * DumpRenderTree/qt/jsobjects.cpp:
3523         (EventSender::keyDown):
3524
3525 2009-10-05  Vadim Zeitlin  <vadim@wxwidgets.org>
3526
3527         Added --wx-compiler-prefix waf option to allow building wxWebKit with
3528         wxWidgets built using "nmake COMPILER_PREFIX=something-non-default".
3529
3530         * wx/build/settings.py:
3531         * wx/build/wxpresets.py:
3532
3533 2009-10-05  Pavel Feldman  <pfeldman@chromium.org>
3534
3535         Reviewed by Timothy Hatcher.
3536
3537         Web Inspector: add testing harness for Web Inspector.
3538
3539         https://bugs.webkit.org/show_bug.cgi?id=30010
3540
3541         * DumpRenderTree/LayoutTestController.cpp:
3542         (showWebInspectorCallback):
3543         (closeWebInspectorCallback):
3544         (evaluateInWebInspectorCallback):
3545         (LayoutTestController::staticFunctions):
3546         * DumpRenderTree/LayoutTestController.h:
3547         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3548         (LayoutTestController::showWebInspector):
3549         (LayoutTestController::closeWebInspector):
3550         (LayoutTestController::evaluateInWebInspector):
3551         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3552         (LayoutTestController::showWebInspector):
3553         (LayoutTestController::closeWebInspector):
3554         (LayoutTestController::evaluateInWebInspector):
3555         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3556         (LayoutTestController::showWebInspector):
3557         (LayoutTestController::closeWebInspector):
3558         (LayoutTestController::evaluateInWebInspector):
3559         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3560         (LayoutTestController::showWebInspector):
3561         (LayoutTestController::closeWebInspector):
3562         (LayoutTestController::evaluateInWebInspector):
3563
3564 2009-10-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3565
3566         Reviewed by Ariyha Hidayat.
3567
3568         Pass arguments to system() as a string instead of array
3569
3570         When passed as an array entries with a space fail to translate
3571         to two arguments to the child process, so instead of manually
3572         splitting all the entries in @buildArgs we pass the whole thing
3573         as a string instead.
3574
3575         * Scripts/webkitdirs.pm:
3576
3577 2009-10-04  Carol Szabo  <carol.szabo@nokia.com>
3578
3579         Reviewed by David Levin.
3580
3581         check-webkit-style misses whitespace errors for operators:
3582         <<, >>, <<=, >>=, &=, |=, +=, -=, *=, /=, /, |, &&, ||.
3583         https://bugs.webkit.org/show_bug.cgi?id=30021
3584
3585         * Scripts/modules/cpp_style.py:
3586         Added the operators mentioned above to the same list as == and !=.
3587
3588 2009-10-02  Julie Parent  <jparent@chromium.org>
3589
3590         Unreviewed.
3591
3592         Adding myself and Ojan Vafai as committers, because we are committers.
3593
3594         * Scripts/modules/committers.py:
3595
3596 2009-10-02  Brian Weinstein  <bweinstein@apple.com>
3597
3598         Reviewed by Adam Roben.
3599
3600         svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
3601         this will help the patch merging process when TryBots are used.
3602
3603         * Scripts/svn-create-patch:
3604
3605 2009-10-02  Jakub Wieczorek  <faw217@gmail.com>
3606
3607         Reviewed by Simon Hausmann.
3608
3609         [Qt] Implement layoutTestController.overridePreference().
3610         https://bugs.webkit.org/show_bug.cgi?id=29970
3611
3612         * DumpRenderTree/qt/DumpRenderTree.cpp:
3613         (WebCore::WebPage::WebPage):
3614         (WebCore::WebPage::resetSettings):
3615         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3616         * DumpRenderTree/qt/jsobjects.cpp:
3617         (LayoutTestController::reset):
3618         (LayoutTestController::setPrivateBrowsingEnabled):
3619         (LayoutTestController::setPopupBlockingEnabled):
3620         (LayoutTestController::overridePreference):
3621         * DumpRenderTree/qt/jsobjects.h:
3622
3623 2009-10-01  Chris Marrin  <cmarrin@apple.com>
3624
3625         Reviewed by Oliver Hunt.
3626
3627         Turn on ENABLE_3D_CANVAS in TOT
3628         https://bugs.webkit.org/show_bug.cgi?id=29906
3629
3630         * Scripts/build-webkit:
3631
3632 2009-10-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3633
3634         Rubberstamped by Simon Hausmann.
3635
3636         Enable HTTP tests for Qt
3637
3638         * Scripts/run-webkit-tests:
3639
3640 2009-10-01  Yaar Schnitman  <yaar@chromium.org>
3641
3642         Reviewed by Dimitri Glazkov.
3643
3644         build-webkit --chromium now also works on cygwin.
3645
3646         https://bugs.webkit.org/show_bug.cgi?id=29973
3647
3648         * Scripts/webkitdirs.pm:
3649
3650 2009-10-01  Zoltan Horvath  <zoltan@webkit.org>
3651
3652         Reviewed by Simon Hausmann.
3653
3654         [Qt] Don't use TCmalloc in DumpRenderTree
3655         https://bugs.webkit.org/show_bug.cgi?id=27029
3656
3657         Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.
3658
3659         * DumpRenderTree/qt/DumpRenderTree.pro:
3660
3661 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3662
3663         Reviewed by Simon Hausmann.
3664
3665         [Qt] Implement eventSender.scheduleAsynchronousClick().
3666
3667         https://bugs.webkit.org/show_bug.cgi?id=29931
3668
3669         * DumpRenderTree/qt/jsobjects.cpp:
3670         (EventSender::scheduleAsynchronousClick):
3671         * DumpRenderTree/qt/jsobjects.h:
3672
3673 2009-10-01  Jakub Wieczorek  <faw217@gmail.com>
3674
3675         Reviewed by Simon Hausmann.
3676
3677         [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
3678         fast/events/open-window-from-another-frame.html from the Skipped list.
3679
3680         https://bugs.webkit.org/show_bug.cgi?id=29930
3681
3682         * DumpRenderTree/qt/jsobjects.cpp:
3683         (LayoutTestController::setPopupBlockingEnabled):
3684         * DumpRenderTree/qt/jsobjects.h:
3685
3686 2009-09-30  Cameron McCormack  <cam@mcc.id.au>
3687
3688         Unreviewed.
3689
3690         Added myself to the list of committers.
3691
3692         * Scripts/modules/committers.py: